REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
[WebKit-https.git] / Tools / ChangeLog
1 2015-12-31  David Kilzer  <ddkilzer@apple.com>
2
3         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
4         <https://bugs.webkit.org/show_bug.cgi?id=152601>
5
6         Ignore unknown pragmas on older clangs.  Fixes the following
7         build failure:
8
9             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
10             #pragma clang diagnostic ignored "-Wself-move"
11                                              ^
12             1 error generated.
13
14         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
15         (TestWebKitAPI::TEST):
16         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
17         (TestWebKitAPI::TEST):
18
19 2015-12-31  Andy Estes  <aestes@apple.com>
20
21         Update the style checker to advise using WTFMove() instead of WTF::move()
22         https://bugs.webkit.org/show_bug.cgi?id=152601
23
24         Reviewed by Daniel Bates.
25
26         * Scripts/webkitpy/style/checkers/cpp.py:
27         (check_wtf_move):
28         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
29         (WebKitStyleTest.test_wtf_move):
30
31 2015-12-31  Andy Estes  <aestes@apple.com>
32
33         Fix warnings uncovered by migrating to WTF_MOVE
34         https://bugs.webkit.org/show_bug.cgi?id=152601
35
36         Reviewed by Daniel Bates.
37
38         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
39         self-move, even if doing so would trigger a warning.
40
41         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
42         (TestWebKitAPI::TEST):
43         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
44         (TestWebKitAPI::TEST):
45
46 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
47
48         [GTK] The install-dependencies script has a syntax error
49         https://bugs.webkit.org/show_bug.cgi?id=152613
50
51         Reviewed by Michael Catanzaro.
52
53         * gtk/install-dependencies: Add the missing 'then.'
54
55 2015-12-30  Philippe Normand  <pnormand@igalia.com>
56
57         [Mac][GTK] Jhbuild support for OSX
58         https://bugs.webkit.org/show_bug.cgi?id=150799
59
60         Reviewed by Michael Catanzaro.
61
62         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
63         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
64         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
65         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
66
67 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
68
69         Unreviewed, move Sebastian Dröge to committers list
70
71         He accidentally added himself to the reviewers list because the file is confusing.
72
73         * Scripts/webkitpy/common/config/contributors.json:
74
75 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
76
77         Remove the unused #define _USE_MATH_DEFINES
78         https://bugs.webkit.org/show_bug.cgi?id=152034
79
80         Reviewed by Tim Horton.
81         
82         Update this test to use piDouble from MathExtras.h, and
83         std::numeric_limits<>.
84
85         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
86
87 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
88
89         Python SCM should be able to retrieve untracked files - Generic changes
90         https://bugs.webkit.org/show_bug.cgi?id=152536
91
92         Reviewed by Brent Fulgham.
93
94         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
95         No support is yet added to GIT and SVN specific implementations.
96
97         * Scripts/webkitpy/common/checkout/scm/scm.py:
98         (SCM.untracked_files):
99         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
100         (SCMTest._shared_test_untracked_files):
101
102 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
103
104         SVN checkout used by RunBenchmark should be non-interactive
105         https://bugs.webkit.org/show_bug.cgi?id=152542
106
107         Reviewed by Ryosuke Niwa.
108
109         RunBenchmark should not require user interaction while running.
110
111         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
112         (BenchmarkBuilder._checkout_with_subversion):
113
114 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
115
116         Web Inspector: add support for running protocol-test.js tests on Windows
117         https://bugs.webkit.org/show_bug.cgi?id=148037
118         <rdar://problem/22292237>
119
120         Reviewed by Simon Fraser.
121
122         * DumpRenderTree/win/TestRunnerWin.cpp:
123         (TestRunner::inspectorTestStubURL): Provide implementation.
124
125 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
126
127         [MediaStream] MediaDeviceInfo.label must be empty in some situations
128         https://bugs.webkit.org/show_bug.cgi?id=152000
129
130         Reviewed by Brent Fulgham.
131
132         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
133         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
134         (WTR::InjectedBundle::setUserMediaPermission):
135         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
136         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
137
138         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
139         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
140         * WebKitTestRunner/InjectedBundle/TestRunner.h:
141
142         * WebKitTestRunner/TestController.cpp:
143         (WTR::TestController::setUserMediaPermissionForOrigin):
144         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
145         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
146           persistent permission for origin, that can be done from script now.
147         * WebKitTestRunner/TestController.h:
148
149         * WebKitTestRunner/TestInvocation.cpp:
150         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
151           SetUserMediaPermissionForOrigin.
152
153 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
154
155         [Win] Unreviewed build fix: Recognize Windows 10 variants.
156
157         * Scripts/webkitpy/common/system/platforminfo.py:
158         (PlatformInfo._determine_win_version):
159
160 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
161
162         Content blockers should be able to promote http to https
163         https://bugs.webkit.org/show_bug.cgi?id=148966
164
165         Reviewed by Benjamin Poulain.
166
167         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
168         (WebCore::ContentExtensions::operator<<):
169         (TestWebKitAPI::TEST_F):
170
171 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
172
173         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
174         https://bugs.webkit.org/show_bug.cgi?id=152516
175
176         Reviewed by Gyuyoung Kim.
177
178         * MiniBrowser/efl/main.c:
179
180 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
181
182         Unreviewed: Add John Wilander as a contributor.
183
184         * Scripts/webkitpy/common/config/contributors.json:
185
186 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
187
188         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
189         https://bugs.webkit.org/show_bug.cgi?id=152482
190
191         Reviewed by Brent Fulgham.
192
193         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
194         for the same property. On WK2, the element returned will not be valid, but is still present and
195         that can lead to looping.
196
197         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
198         (AccessibilityUIElement::horizontalScrollbar):
199         (AccessibilityUIElement::verticalScrollbar):
200         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
201         (WTR::AccessibilityUIElement::horizontalScrollbar):
202         (WTR::AccessibilityUIElement::verticalScrollbar):
203
204 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
205
206         Unreviewed.
207
208         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
209
210 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
211
212         [EFL] test_ewk2_context failed after r192808
213         https://bugs.webkit.org/show_bug.cgi?id=151846
214
215         Reviewed by Gyuyoung Kim.
216
217         Used the added ewk_context_web_process_count_limit_set api
218         instead of the deprecated ewk_context_process_model_set.
219
220         * MiniBrowser/efl/main.c:
221         (elm_main):
222
223 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
224
225         Unreviewed, move myself to reviewer list.
226
227         * Scripts/webkitpy/common/config/contributors.json:
228
229 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
230
231         Unreviewed, add myself to the committers list.
232
233         * Scripts/webkitpy/common/config/contributors.json:
234
235 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
236
237         [GTK] jquery.min.js violates DFSG
238         https://bugs.webkit.org/show_bug.cgi?id=152428
239
240         Reviewed by Joseph Pecoraro.
241
242         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
243         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
244
245         * gtk/manifest.txt.in:
246
247 2015-12-19  Dan Bernstein  <mitz@apple.com>
248
249         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
250         https://bugs.webkit.org/show_bug.cgi?id=152462
251
252         Reviewed by Alexey Proskuryakov.
253
254         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
255           OS X 10.9:
256
257         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
258         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
259         * MiniBrowser/Configurations/DebugRelease.xcconfig:
260         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
261         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
262
263         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
264           never getting compiled:
265
266         * DumpRenderTree/mac/TextInputController.m:
267         * MiniBrowser/mac/BrowserWindowController.m:
268         * TestWebKitAPI/Tests/mac/AttributedString.mm:
269         * WebKitTestRunner/mac/EventSenderProxy.mm:
270
271 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
272
273         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
274
275         This is to make it easy to CC it on Bugzilla.
276
277         * Scripts/webkitpy/common/config/contributors.json:
278
279 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
280
281         Pasteboard get messed up after running kill-old-processes
282         https://bugs.webkit.org/show_bug.cgi?id=152426
283
284         Reviewed by Alexey Proskuryakov.
285
286         * BuildSlaveSupport/kill-old-processes:
287         (main): Do not kill pasteboard anymore.
288
289 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
290
291         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
292         https://bugs.webkit.org/show_bug.cgi?id=152157
293         <rdar://problem/23851817>
294
295         Reviewed by Alexey Proskuryakov.
296
297         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
298         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
299         * Scripts/webkitpy/layout_tests/controllers/manager.py:
300         (Manager._get_test_inputs): Common method to calculate test_inputs.
301         (Manager._update_worker_count): Calculate and update required number of workers.
302
303 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
304
305         run-webkit-tests fails to delete Simulator device during cleanup
306         https://bugs.webkit.org/show_bug.cgi?id=152363
307
308         Reviewed by Alexey Proskuryakov.
309
310         * Scripts/webkitpy/xcode/simulator.py:
311         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
312
313 2015-12-16  Tim Horton  <timothy_horton@apple.com>
314
315         [mac-wk2] fast/events force click tests crashing
316         https://bugs.webkit.org/show_bug.cgi?id=152339
317
318         Reviewed by Beth Dakin.
319
320         * WebKitTestRunner/mac/EventSenderProxy.mm:
321         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
322         Set the NSEvent's _type member in addition to overriding -type,
323         because there are assertions in touch event handling code that depend on it.
324
325 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
326
327         Enforce temporarily bots to sync WebKit and WPT testharness.js
328         https://bugs.webkit.org/show_bug.cgi?id=152334
329
330         Reviewed by Darin Adler.
331
332         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
333         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
334
335 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
336
337         [Fetch API] Add fetch API compile time flag
338         https://bugs.webkit.org/show_bug.cgi?id=152254
339
340         Reviewed by Darin Adler.
341
342         * Scripts/webkitperl/FeatureList.pm:
343
344 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
345
346         Unreviewed.
347
348         Added files that have impact in building Streams API to the watchlist.
349
350         * Scripts/webkitpy/common/config/watchlist:
351
352 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
353
354         Unreviewed.
355
356         Added imported tests to Streams API watchlist.
357
358         * Scripts/webkitpy/common/config/watchlist:
359
360 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
361
362         Remove default copy of wpt testharness.js when launching wpt server
363         https://bugs.webkit.org/show_bug.cgi?id=152298
364
365         Reviewed by Darin Adler.
366
367         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
368         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
369
370 2015-12-15  David Kilzer  <ddkilzer@apple.com>
371
372         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
373         <http://webkit.org/b/152314>
374
375         Reviewed by Daniel Bates.
376
377         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
378         code path to exit immediately when calling main().
379         Unfortunately, DumpRenderTreeMain.mm was used for both
380         DumpRenderTree command-line binary and DumpRenderTree.app, which
381         meant that the app would exit immediately with no error code
382         when run!
383
384         The workaround is to introduce a separate source file called
385         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
386         already does.
387
388         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
389         DumpRenderTreeAppMain.mm to the project.  Make it the only
390         compiled source for the DumpRenderTree.app target.
391         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
392         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
393         case someone tries mistakenly to use the app.
394         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
395         Link to JavaScriptCore.framework on iOS for the assert.
396         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
397         Link to JavaScriptCore.framework on OS X for the assert.  Remove
398         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
399         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
400         (main): Add assert for iOS so that a crash occurs if someone
401         tries to run the wrong command.
402
403 2015-12-14  Tim Horton  <timothy_horton@apple.com>
404
405         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
406         https://bugs.webkit.org/show_bug.cgi?id=152266
407         <rdar://problem/22092676>
408
409         Reviewed by Simon Fraser.
410
411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
412         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
413         Add a test that crashed before this change, and doesn't crash after.
414
415 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
416
417         AX: iOS: Text field variations do not have the correct traits
418         https://bugs.webkit.org/show_bug.cgi?id=152237
419
420         Reviewed by Mario Sanchez Prada.
421
422         Add iOS calls for determing if an object is a search field or a text area.
423
424         * DumpRenderTree/AccessibilityUIElement.cpp:
425         (getIsSearchFieldCallback):
426         (getIsTextAreaCallback):
427         (stringForSelectionCallback):
428         (AccessibilityUIElement::getJSClass):
429         * DumpRenderTree/AccessibilityUIElement.h:
430         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
431         (AccessibilityUIElement::identifier):
432         (AccessibilityUIElement::isTextArea):
433         (AccessibilityUIElement::isSearchField):
434         (AccessibilityUIElement::traits):
435         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
436         (WTR::AccessibilityUIElement::scrollPageRight):
437         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
438         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
439         (WTR::AccessibilityUIElement::isSearchField):
440         (WTR::AccessibilityUIElement::isTextArea):
441         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
442         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
443         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
444         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
445         (WTR::AccessibilityUIElement::isTextArea):
446         (WTR::AccessibilityUIElement::isSearchField):
447         (WTR::AccessibilityUIElement::rowCount):
448
449 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
450
451         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
452         https://bugs.webkit.org/show_bug.cgi?id=152252
453
454         Reviewed by Sergio Villar Senin.
455
456         * gtk/install-dependencies: Add libtool-bin to the list of packages required
457         for building the JHBuild on Debian systems.
458
459 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
460
461         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
462         https://bugs.webkit.org/show_bug.cgi?id=152156
463
464         Reviewed by Dan Bernstein.
465
466         Our frameworks should appropriately prefix all ObjC classes,
467         not just external symbols.
468
469         * Scripts/check-for-inappropriate-objc-class-names:
470         Remove the -g switch to check all ObjC class names.
471
472 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
473
474         [MediaStream] Expose media capture devices persistent permissions to WebCore
475         https://bugs.webkit.org/show_bug.cgi?id=152087
476
477         Add support for the new user media permission checker page UI client method.
478
479         Reviewed by Chris Dumez.
480
481         * WebKitTestRunner/TestController.cpp:
482         (WTR::decidePolicyForUserMediaPermissionRequest):
483         (WTR::checkUserMediaPermissionForOrigin):
484         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
485         (WTR::TestController::createWebViewWithOptions): Ditto.
486         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
487         (WTR::originUserVisibleName): New, create a string for the origin.
488         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
489           according to the state of the origin permission map.
490         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
491           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
492         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
493           origin permission map.
494         * WebKitTestRunner/TestController.h:
495
496 2015-12-10  Alex Christensen  <achristensen@webkit.org>
497
498         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
499         https://bugs.webkit.org/show_bug.cgi?id=152022
500         rdar://problem/23763584
501
502         Reviewed by Darin Adler.
503
504         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
505         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
506         (WTR::InjectedBundlePage::willSendRequestForFrame):
507         * WebKitTestRunner/InjectedBundle/TestRunner.h:
508         (WTR::TestRunner::setWillSendRequestReturnsNull):
509         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
510         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
511         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
512         (WTR::TestRunner::willSendRequestHTTPBody):
513         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
514
515 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
516
517         Remove additional simulator checks before running layout-tests
518         https://bugs.webkit.org/show_bug.cgi?id=152146
519
520         Reviewed by Darin Adler.
521
522         * Scripts/webkitpy/port/ios.py:
523         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
524         * Scripts/webkitpy/xcode/simulator.py:
525         (Simulator._boot_and_shutdown_simulator_device): Deleted.
526         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
527
528 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
529
530         Run atleast one simulator even if max process limit is low
531         https://bugs.webkit.org/show_bug.cgi?id=152081
532         <rdar://problem/23819694>
533
534         Reviewed by Alexey Proskuryakov.
535
536 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
537
538         [GTK] Crash in WebProcess when loading large content with custom URI schemes
539         https://bugs.webkit.org/show_bug.cgi?id=144262
540
541         Reviewed by Carlos Garcia Campos.
542
543         Added new unit test to check the additional scenarios we now
544         handle for custom URI schemes.
545
546         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
547         (generateHTMLContent): New helper function to generate big enough content.
548         (testWebContextURIScheme): New unit test.
549
550 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
551
552         [EFL] Fix unhandled web process message when launching MiniBrowser
553         https://bugs.webkit.org/show_bug.cgi?id=152048
554
555         Reviewed by Gyuyoung Kim.
556
557         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
558         (TestWebKitAPI::TEST):
559
560 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
561
562         [GTK] Add API to handle beforeunload events
563         https://bugs.webkit.org/show_bug.cgi?id=139090
564
565         Reviewed by Gustavo Noronha Silva.
566
567         * MiniBrowser/gtk/BrowserWindow.c:
568         (browserWindowConstructed):
569         (browserWindowDeleteEvent):
570         (browser_window_class_init):
571         Handle delete-event to prevent the window from being closed when
572         the page has beforeunload handlers. Use
573         webkit_web_view_try_close() when the window is requested to be
574         closed.
575         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
576         (testWebViewJavaScriptDialogs):
577         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
578         script dialog type.
579
580 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
581
582         Refactored initialization code in LoadTrackingTest.
583
584         Rubber-stamped by Carlos Garcia Campos.
585
586         Small refactoring to make sure that the state of a LoadTrackingTest
587         gets properly reset before loading new web content.
588
589         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
590         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
591         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
592         functions and reset the remaining local variables.
593         (LoadTrackingTest::loadURI): Call reset();
594         (LoadTrackingTest::loadHtml): Ditto.
595         (LoadTrackingTest::loadPlainText): Ditto.
596         (LoadTrackingTest::loadBytes): Ditto.
597         (LoadTrackingTest::loadRequest): Ditto.
598         (LoadTrackingTest::reload): Ditto.
599         (LoadTrackingTest::goBack): Ditto.
600         (LoadTrackingTest::goForward): Ditto.
601
602 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
603
604         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
605         https://bugs.webkit.org/show_bug.cgi?id=151942
606
607         Reviewed by Darin Adler.
608
609         * MiniBrowser/efl/main.c:
610         (window_create): Enable offline web application cache feature on MiniBrowser.
611         (elm_main):
612
613 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
614
615         https://bugs.webkit.org/show_bug.cgi?id=151243
616         <rdar://problem/22955197>
617
618         Reviewed by Alexey Proskuryakov.
619
620         * LayoutTestRelay/LayoutTestRelay/main.m:
621         (getTestingSimDevice): Use separate testing device for each worker.
622         * Scripts/webkitpy/layout_tests/controllers/manager.py:
623         (Manager.run): Perform cleanup even if setup fails.
624         * Scripts/webkitpy/port/ios.py:
625         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
626         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
627         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
628         (IOSSimulatorPort._quit_ios_simulator): Same
629         (IOSSimulatorPort.clean_up_test_run): Same
630         (IOSSimulatorPort.check_sys_deps): Same
631         (IOSSimulatorPort.testing_device): Same
632         (IOSSimulatorPort.reset_preferences): Same
633         (IOSSimulatorPort.get_simulator_path): Return simulator path.
634         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
635         * Scripts/webkitpy/xcode/simulator.py:
636         (Device.delete): Delete the simulator device.
637         (Simulator.delete_device): Same
638         (Simulator.wait_until_device_is_booted): Wait for device booting.
639
640 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
641
642         [EFL] Add API to provide preferences before creating ewk_view
643         https://bugs.webkit.org/show_bug.cgi?id=151587
644
645         Reviewed by Gyuyoung Kim.
646
647         * MiniBrowser/efl/main.c:
648         (on_key_down):
649         (quit):
650         (window_create):
651         Moved settings related code to configuration() not to update settings
652         whenever ewk_view is created.
653         (configuration):
654         (elm_main):
655
656 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
657
658         Unreviewed. Fix GTK+ API tests after r193639.
659
660         The new jhbuild version needs some more variables ot be present in
661         the builtin dict, even if they are set to None.
662
663         * jhbuild/jhbuildutils.py:
664         (enter_jhbuild_environment_if_available):
665
666 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
667
668         [GTK] Notify WebCore when notification is clicked
669         https://bugs.webkit.org/show_bug.cgi?id=151951
670
671         Reviewed by Carlos Garcia Campos.
672
673         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
674         (testWebViewNotification): test the new API.
675
676 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
677
678         'jhbuild build' should fail immediately when building any module fails
679         https://bugs.webkit.org/show_bug.cgi?id=145697
680
681         Reviewed by Carlos Garcia Campos.
682
683         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
684         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
685         Everything is placed under lib instead of lib64 now.
686         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
687         --exit-on-error when running 'jhbuild build'.
688         * jhbuild/jhbuildrc_common.py:
689         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
690         jhbuild should be able to handle these for us without breaking things....
691
692 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
693
694         Add support to import w3c tests from a repository with a different root that the main repo dir
695         https://bugs.webkit.org/show_bug.cgi?id=151751
696
697         Reviewed by Ryosuke Niwa and Youenn Fablet.
698
699         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
700         in a different directory than the repository root.
701
702         This patch introduces a new parameter tests_directory that we will use as root directory to search for
703         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
704         requires having the copy_path lists including tuples of origin and destination directories.
705
706         * Scripts/webkitpy/w3c/test_downloader.py:
707         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
708         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
709         * Scripts/webkitpy/w3c/test_importer_unittest.py:
710         (TestImporterTest.test_tests_directory): Test.
711
712 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
713
714         Mock TestRepositories in W3C importer tests
715         https://bugs.webkit.org/show_bug.cgi?id=151938
716
717         Reviewed by Youenn Fablet.
718
719         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
720         is because the test repository method reading the file was using the filesystem directly instead of taking the
721         host one. This patch changes that.
722
723         * Scripts/webkitpy/w3c/test_downloader.py:
724         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
725         default one.
726         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
727         * Scripts/webkitpy/w3c/test_importer_unittest.py:
728         (TestImporterTest.test_harnesslinks_conversion):
729         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
730
731 2015-12-07  David Kilzer  <ddkilzer@apple.com>
732
733         TestNetscapePlugIn: Address review comment on 193607
734         <http://webkit.org/b/151881>
735
736         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
737         (testSetStatus): Initializing std::unique_ptr<char[]> with
738         nullptr is redundant.
739
740 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
741
742         [GTK] Add webkit_uri_request_get_http_method
743         https://bugs.webkit.org/show_bug.cgi?id=151601
744
745         Reviewed by Martin Robinson.
746
747         Add test case to check HTTP method of WebKitURIRequest.
748
749         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
750         (testURIRequestHTTPMethod):
751         (serverCallback):
752         (beforeAll):
753         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
754         (sendRequestCallback):
755
756 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
757
758         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
759         https://bugs.webkit.org/show_bug.cgi?id=79918
760
761         Reviewed by Gustavo Noronha Silva.
762
763         Add unit tests to check the different console messages.
764
765         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
766         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
767         (ConsoleMessageTest::ConsoleMessage::operator==):
768         (ConsoleMessageTest::consoleMessageReceivedCallback):
769         (ConsoleMessageTest::ConsoleMessageTest):
770         (ConsoleMessageTest::~ConsoleMessageTest):
771         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
772         (testWebKitConsoleMessageConsoleAPI):
773         (testWebKitConsoleMessageJavaScriptException):
774         (testWebKitConsoleMessageNetworkError):
775         (testWebKitConsoleMessageSecurityError):
776         (beforeAll):
777         (afterAll):
778         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
779         (consoleMessageSentCallback):
780         (pageCreatedCallback):
781
782 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
783
784         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
785         https://bugs.webkit.org/show_bug.cgi?id=151934
786
787         Reviewed by Csaba Osztrogonác.
788
789         * MiniBrowser/efl/main.c:
790         (on_window_deletion): Revert the changes of r192767.
791
792 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
793
794         [GTK] update-webkitgtk-libs cannot build mesa
795         https://bugs.webkit.org/show_bug.cgi?id=151535
796
797         Reviewed by Martin Robinson.
798
799         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
800         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
801         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
802         does not have a stable API and we cannot expect mesa to be buildable unless we control the
803         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
804         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
805
806         * gtk/jhbuild.modules:
807
808 2015-12-07  Philippe Normand  <pnormand@igalia.com>
809
810         [GTK][Mac] libWebExtensionTest link error
811         https://bugs.webkit.org/show_bug.cgi?id=150802
812
813         Reviewed by Carlos Garcia Campos.
814
815         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
816
817 2015-12-06  David Kilzer  <ddkilzer@apple.com>
818
819         TestNetscapePlugIn: Fix leaks found by static analyzer
820         <http://webkit.org/b/151881>
821
822         Reviewed by Darin Adler.
823
824         Fixes the following leaks found by the static analyzer:
825             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
826                     return false;
827                            ^~~~~
828             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
829                     return false;
830                            ^~~~~
831             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
832                     return false;
833                            ^~~~~
834
835         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
836         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
837         early return if allocation fails.
838         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
839         Make sure to call fclose() on filehandle, even for an early
840         return.
841         (testSetStatus): Switch to using std::unique_ptr<char[]>.
842
843 2015-12-05  David Kilzer  <ddkilzer@apple.com>
844
845         prepare-ChangeLog: Fix some warning messages when using svn
846         <http://webkit.org/b/151914>
847
848         Reviewed by Daniel Bates.
849
850         * Scripts/prepare-ChangeLog:
851         (generateFunctionLists): Simplify logic so that we never call
852         normalizePath() with an undefined value.
853         (attributeCommand): Quote $subPath for the shell so that we
854         don't try to run "svn propget" on invalid paths.
855
856 2015-12-04  David Kilzer  <ddkilzer@apple.com>
857
858         TestNetscapePlugIn: Fix remaining static analyzer warnings
859         <http://webkit.org/b/151888>
860
861         Reviewed by Alexey Proskuryakov.
862
863         Fixes the following static analyzer warnings:
864             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
865                     CRASH();
866                     ^~~~~~~
867             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
868                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
869                 ^~~~~~~~~~~~~~~~
870             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
871                 return obj->pluginTest->NPP_SetWindow(window);
872                        ^~~~~~~~~~~~~~~
873             2 warnings generated.
874
875         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
876         (CRASH): Use __builtin_trap() for gcc/clang.
877         (NPP_SetWindow): Add early return if obj is nullptr.
878
879 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
880
881         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
882         https://bugs.webkit.org/show_bug.cgi?id=151797
883
884         Reviewed by Martin Robinson.
885
886         Since we switched to use the network process to run the unit tests
887         the test /webkit2/WebKitWebResource/get-data sometimes fails and
888         sometimes passes. We are now also getting the notification for the
889         css image. Since we wait for 3 resources, sometimes the css image
890         is loaded before and then checkResourceData is called for it, but
891         not handled. When the css image is the last one loaded the test
892         passes. So, we just need to wait for the 4 resources.
893
894         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
895         (testWebResourceGetData):
896
897 2015-12-03  David Kilzer  <ddkilzer@apple.com>
898
899         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
900         <http://webkit.org/b/151845>
901
902         Reviewed by Simon Fraser.
903
904         Fixes the following static analyzer warning:
905             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
906                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
907                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
908
909         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
910         (createBitmapContext): Free 'buffer' after using it in logging
911         to fix the use-after-free.  Assign a value of nullptr to buffer
912         so we don't return with it set to a freed address.
913
914 2015-12-03  Jer Noble  <jer.noble@apple.com>
915
916         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
917         https://bugs.webkit.org/show_bug.cgi?id=151830
918
919         Reviewed by Anders Carlsson.
920
921         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
922
923         * DumpRenderTree/mac/DumpRenderTree.mm:
924         (resetWebPreferencesToConsistentValues):
925         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
926         (WTR::initializeWebViewConfiguration):
927
928 2015-12-03  Anders Carlsson  <andersca@apple.com>
929
930         Remove Objective-C GC support
931         https://bugs.webkit.org/show_bug.cgi?id=151819
932         rdar://problem/23746991
933
934         Reviewed by Dan Bernstein.
935
936         * asan/asan.xcconfig:
937
938 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
939
940         Allow nil for unspecified benchmark pathes
941         https://bugs.webkit.org/show_bug.cgi?id=151784
942
943         Reviewed by Filip Pizlo.
944
945         `Pathname.new(nil)` will raise an error.
946         Only generate Pathname if the benchmark path is specified.
947
948         * Scripts/run-jsc-benchmarks:
949
950 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
951
952         [Win] Run non-http tests without Cygwin
953         https://bugs.webkit.org/show_bug.cgi?id=151721
954
955         Reviewed by Andy Estes.
956
957         Support native 32-bit and 64-bit Python (and Perl) builds
958         for running tests:
959
960         1. Use "startswith('win')", rather than "== 'win32'" to support
961         various Windows build types.
962         2. Supply full path for some native Windows utilities, since the
963         path environment does not always have the specified, and they are
964         guaranteed to exist in those specific locations.
965         3. Make sure native Windows Python test runs pass proper environment
966         variables to run programs.
967         4. Append 'exe' suffix when running Windows executables.
968         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
969         command doesn't exist.
970         
971         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
972         the current Perl executable, rather than requiring a new path search.
973         * Scripts/webkitpy/common/find_files_unittest.py:
974         (TestWinNormalize.test_win): Use startswith('win').
975         * Scripts/webkitpy/common/prettypatch_unittest.py:
976         (test_pretty_diff_encodings): Ditto.
977         * Scripts/webkitpy/common/system/executive.py:
978         (Executive._should_close_fds): Ditto.
979         (Executive.shell_command_for_script): Use startswith('win').
980         (Executive.kill_process): Use full path to killall executable.
981         (Executive.check_running_pid): Use startswith('win').
982         (Executive.running_pids): Ditto.
983         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
984         running under native Windows Python.
985         (Executive._child_process_encoding): Use startswith('win').
986         (Executive._should_encode_child_process_arguments): Ditto.
987         (Executive.popen): Recognize proper script engine on Windows, since it
988         does not support the shebang syntax.
989         (Executive.run_in_parallel): Use startswith('win').
990         * Scripts/webkitpy/common/system/executive_unittest.py:
991         (never_ending_command): Ditto.
992         (ExecutiveTest.test_run_command_with_unicode): Ditto.
993         (ExecutiveTest.serial_test_kill_process): Ditto.
994         (ExecutiveTest.serial_test_kill_all): Ditto.
995         (ExecutiveTest.serial_test_check_running_pid): Ditto.
996         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
997         (main): Ditto.
998         * Scripts/webkitpy/common/system/file_lock.py:
999         (FileLock._create_lock): Ditto.
1000         (FileLock._remove_lock): Ditto.
1001         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1002         (RealFileSystemTest.test_chdir): Ditto.
1003         (RealFileSystemTest.test_chdir__notexists): Ditto.
1004         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1005         * Scripts/webkitpy/common/system/path_unittest.py:
1006         (AbspathTest.test_abspath_to_uri_win): Ditto.
1007         * Scripts/webkitpy/common/system/platforminfo.py:
1008         (PlatformInfo._determine_os_name): Ditto.
1009         * Scripts/webkitpy/common/system/user.py: Ditto.
1010         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1011         (ManagerTest.integration_test_needs_servers): Ditto.
1012         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1013         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1014         driver letters.
1015         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1016         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1017         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1018         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1019         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1020         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1021         (TestHttpServer.test_start_cmd): Ditto.
1022         * Scripts/webkitpy/port/base.py:
1023         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1024         and 'SYSTEMROOT' in environment passed to test runners.
1025         (Port._apache_config_file_name_for_platform): Use startswith('win').
1026         (Port._build_path): Ditto.
1027         (Port._path_to_driver): Include 'exe' suffix when running under native
1028         Windows.
1029         * Scripts/webkitpy/port/driver.py:
1030         (Driver._setup_environ_for_driver): Explicitly make some environment
1031         variables strings.
1032         * Scripts/webkitpy/port/server_process.py:
1033         (ServerProcess.__init__): Use startswith('win').
1034         * Scripts/webkitpy/port/win.py:
1035         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1036         registry key formats.
1037         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1038         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1039         and regtool on Cygwin.
1040         (WinPort.write_registry_value): Ditto.
1041         (WinPort.setup_crash_log_saving): Ditto.
1042         (WinPort.restore_crash_log_saving): Ditto.
1043         (WinPort.prevent_error_dialogs): Ditto.
1044         (WinPort.allow_error_dialogs): Ditto.
1045         (WinPort.find_system_pid): Revise to use Windows management
1046         infrastructure on native Windows, continue using 'ps' on Cygwin.
1047         (WinPort.read_registry_string): Deleted.
1048         (WinPort.write_registry_string): Deleted.
1049         * Scripts/webkitpy/test/main.py:
1050         (main): Use startswith('win').
1051         (Tester._parse_args): Ditto.
1052
1053 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1054
1055         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1056         https://bugs.webkit.org/show_bug.cgi?id=150792
1057
1058         Reviewed by Saam Barati.
1059
1060         * Scripts/webkitperl/FeatureList.pm:
1061
1062 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1063
1064         Unreviewed, rolling out r192914.
1065         https://bugs.webkit.org/show_bug.cgi?id=151734
1066
1067         JSC tests for this change are failing on 32 and 64-bit bots
1068         (Requested by ryanhaddad on #webkit).
1069
1070         Reverted changeset:
1071
1072         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1073         enable this feature"
1074         https://bugs.webkit.org/show_bug.cgi?id=150792
1075         http://trac.webkit.org/changeset/192914
1076
1077 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1078
1079         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1080         <http://webkit.org/b/151726>
1081
1082         Reviewed by Simon Fraser.
1083
1084         * WebKitTestRunner/mac/EventSenderProxy.mm:
1085         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1086         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1087
1088 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
1089
1090         Give String and AtomicString an existingHash() function
1091         https://bugs.webkit.org/show_bug.cgi?id=151717
1092
1093         Reviewed by Andreas Kling.
1094
1095         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1096         (TestWebKitAPI::TEST):
1097         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1098         (TestWebKitAPI::TEST):
1099
1100 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1101
1102         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1103         https://bugs.webkit.org/show_bug.cgi?id=150792
1104
1105         Reviewed by Saam Barati.
1106
1107         * Scripts/webkitperl/FeatureList.pm:
1108
1109 2015-12-01  Sam Weinig  <sam@webkit.org>
1110
1111         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1112         <rdar://problem/23320863>
1113         https://bugs.webkit.org/show_bug.cgi?id=151708
1114
1115         Reviewed by Anders Carlsson.
1116
1117         * WebKitTestRunner/TestController.cpp:
1118         (WTR::TestController::createOtherPage):
1119         (WTR::TestController::createWebViewWithOptions):
1120         Update for new WKPageUIClient.
1121
1122 2015-12-01  Anders Carlsson  <andersca@apple.com>
1123
1124         Remove WebKit2.framework
1125         https://bugs.webkit.org/show_bug.cgi?id=151715
1126
1127         Reviewed by Dan Bernstein.
1128
1129         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1130         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1131         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1132         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1133         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1134         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1135         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1136
1137 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
1138
1139         Unreviewed common typo fix "occurance" => "occurrence".
1140
1141         * Scripts/webkitpy/tool/commands/queries.py:
1142         (FindFlakyTests._print_statistics):
1143
1144 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1145
1146         Make ProcessModel always MultipleSecondaryProcesses
1147         https://bugs.webkit.org/show_bug.cgi?id=151662
1148
1149         Reviewed by Antti Koivisto.
1150
1151         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1152         (TestWebKitAPI::TEST):
1153         * WebKitTestRunner/TestController.cpp:
1154         (WTR::TestController::generatePageConfiguration):
1155
1156 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1157
1158         Make usesNetworkProcess always true
1159         https://bugs.webkit.org/show_bug.cgi?id=151580
1160
1161         Reviewed by Darin Adler.
1162
1163         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1164         (TestWebKitAPI::TEST):
1165         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1166         (TestWebKitAPI::TEST):
1167         * WebKitTestRunner/TestController.cpp:
1168         (WTR::TestController::generatePageConfiguration):
1169
1170 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1171
1172         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
1173
1174         Add a way to skip unit tests only for Debug or Release builds and
1175         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
1176
1177         * Scripts/run-gtk-tests:
1178         (SkippedTest):
1179         (SkippedTest.__init__):
1180         (SkippedTest.__str__):
1181         (SkippedTest.skip_entire_suite):
1182         (SkippedTest.skip_for_build_type):
1183         (TestRunner):
1184         (TestRunner.__init__):
1185
1186 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1187
1188         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
1189
1190         It's an assert hit because we are reloading a view loaded with
1191         HTML data which is not supported. Use loadURI instead.
1192
1193         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1194         (testWebViewCustomCharset):
1195
1196 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1197
1198         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
1199         https://bugs.webkit.org/show_bug.cgi?id=151633
1200
1201         Reviewed by Csaba Osztrogonác.
1202
1203         * TestWebKitAPI/PlatformGTK.cmake:
1204         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
1205
1206 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1207
1208         [GTK] Remove the remaining uses of GMainLoopSource
1209         https://bugs.webkit.org/show_bug.cgi?id=151632
1210
1211         Reviewed by Žan Doberšek.
1212
1213         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1214         (testWebViewSyncRequestOnMaxConns):
1215         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1216         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1217         (WTR::TestRunner::TestRunner):
1218         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1219         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1220         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1221         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1222         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1223         (WTR::timeoutSource):
1224         (WTR::TestController::notifyDone):
1225         (WTR::TestController::platformRunUntil):
1226
1227 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1228
1229         [cmake] Add testb3 to the build system
1230         https://bugs.webkit.org/show_bug.cgi?id=151619
1231
1232         Reviewed by Gyuyoung Kim.
1233
1234         * Scripts/build-jsc:
1235
1236 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1237
1238         [jhbuild] Fix pixman build with clang
1239         https://bugs.webkit.org/show_bug.cgi?id=151441
1240
1241         Reviewed by Carlos Garcia Campos.
1242
1243         * efl/jhbuild.modules:
1244         * gtk/jhbuild.modules:
1245
1246 2015-11-26  David Kilzer  <ddkilzer@apple.com>
1247
1248         Extract prependToEnvironmentVariableList
1249         <http://webkit.org/b/151536>
1250
1251         Reviewed by Daniel Bates.
1252
1253         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1254                webkitdirs_unittest/prependToEnvironmentVariableList.pl
1255
1256         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
1257         and prependToEnvironmentVariableList.
1258         (appendToEnvironmentVariableList): Simplify variable name.
1259         Switch to use $Config{path_sep}.
1260         (prependToEnvironmentVariableList): Add new method.
1261         (setupMacWebKitEnvironment): Switch to use
1262         prependToEnvironmentVariableList().
1263         (setupIOSWebKitEnvironment): Ditto.
1264
1265         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
1266         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
1267
1268 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1269
1270         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1271         https://bugs.webkit.org/show_bug.cgi?id=151567
1272
1273         Reviewed by Darin Adler.
1274
1275         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1276         (on_window_deletion):
1277
1278 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1279
1280         [GTK] Use the network process unconditionally
1281         https://bugs.webkit.org/show_bug.cgi?id=151541
1282
1283         Reviewed by Alex Christensen.
1284
1285         Fix TestInspectorServer test. Do not assume we already have the
1286         title we want when the page has been loaded, since the title is
1287         changed afterwards. So, check if the title has already been set,
1288         and if not wait for it.
1289
1290         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1291         (openRemoteDebuggingSession):
1292
1293 2015-11-23  Alex Christensen  <achristensen@webkit.org>
1294
1295         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
1296         https://bugs.webkit.org/show_bug.cgi?id=151532
1297
1298         Reviewed by Benjamin Poulain.
1299
1300         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1301         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1302         (TestWebKitAPI::TEST):
1303         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1304         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
1305         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
1306         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
1307         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
1308         so it was calling a function on a test object that had gone out of scope.
1309         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
1310         but that will become the default soon and that call will be removed.
1311
1312 2015-11-22  David Kilzer  <ddkilzer@apple.com>
1313
1314         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
1315         <http://webkit.org/b/151542>
1316
1317         Reviewed by Daniel Bates.
1318
1319         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1320         (base_url): Use the Port object (already passed in) to give us
1321         the path to the LayoutTests directory, which already checks for a
1322         --layout-tests-directory command-line switch.
1323         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
1324         argument since we can get this from the Port object already
1325         passed in via Port.results_directory().  Also switch to use
1326         Port.layout_tests_dir() to get the LayoutTests directory.
1327
1328         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1329         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
1330         Add test case for custom LayoutTests directory.
1331         (TestWebPlatformTestServer.test_previously_spawned_instance):
1332         Update Port object to set mock results directory as if it was
1333         set on the command-line.  Remove unneeded argument from
1334         WebPlatformTestServer constructor.
1335         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
1336
1337         * Scripts/webkitpy/port/base.py:
1338         (Port.to.start_web_platform_test_server): Remove unneeded
1339         argument from WebPlatformTestServer constuctor.
1340
1341 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1342
1343         [GTK] Some unit tests fail when using the network process
1344         https://bugs.webkit.org/show_bug.cgi?id=151490
1345
1346         Reviewed by Martin Robinson.
1347
1348         Run the soup server in a separate thread in TestResources test to
1349         avoid deadlocks.
1350
1351         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
1352         /webkit2/WebKitWebResource/get-data when using the network process.
1353
1354         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1355         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
1356         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1357         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
1358         present, create a WorkQueue to run the server.
1359         (WebKitTestServer::run): Run the server in the work queue if it
1360         has been created.
1361         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1362         type into server options as flags.
1363
1364 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1365
1366         [GTK] ImageDiff should normalize the diff image
1367         https://bugs.webkit.org/show_bug.cgi?id=151261
1368
1369         Reviewed by Sergio Villar Senin.
1370
1371         * ImageDiff/gtk/ImageDiff.cpp:
1372         (readPixbufFromStdin): Fix memory leak.
1373         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
1374         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
1375
1376 == Rolled over to ChangeLog-2015-11-21 ==