Fix iOS EWS.
[WebKit-https.git] / Tools / ChangeLog
1 2016-03-01  Dean Johnson  <dean_johnson@apple.com>
2
3         Fix iOS EWS.
4         https://bugs.webkit.org/show_bug.cgi?id=154880
5
6         Reviewed by Alexey Proskuryakov.
7
8         * Scripts/copy-webkitlibraries-to-product-directory:
9
10 2016-02-29  Chris Dumez  <cdumez@apple.com>
11
12         Have parseHTMLInteger() / parseHTMLNonNegativeInteger() use WTF::Optional
13         https://bugs.webkit.org/show_bug.cgi?id=154845
14
15         Reviewed by Ryosuke Niwa.
16
17         Update API tests accordingly.
18
19         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
20         (TestWebKitAPI::testParseHTMLInteger):
21         (TestWebKitAPI::parseHTMLIntegerFails):
22         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
23         (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
24         (TestWebKitAPI::TEST): Deleted.
25
26 2016-02-29  Simon Fraser  <simon.fraser@apple.com>
27
28         Remove the experimental feature of antialiased font dilation
29         https://bugs.webkit.org/show_bug.cgi?id=154843
30
31         Reviewed by Zalan Bujtas.
32
33         Remove the "antialiased font dilation" code path, and related prefs.
34
35         * DumpRenderTree/mac/DumpRenderTree.mm:
36         (resetWebPreferencesToConsistentValues): Deleted.
37         * WebKitTestRunner/TestController.cpp:
38         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
39
40 2016-02-29  Brady Eidson  <beidson@apple.com>
41
42         Fix timing flakiness in test I added in http://trac.webkit.org/changeset/197372
43
44         Unreviewed.
45
46         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html:
47         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
48         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
49         (TEST): Sometimes a third message from the first html file was leaking through. The message is expected
50           so we should always wait for it and make sure we got it.
51
52 2016-02-29  Brady Eidson  <beidson@apple.com>
53
54         Modern IDB: WebKit 2 IPC layer easily confused about multiple web processes being connected.
55         https://bugs.webkit.org/show_bug.cgi?id=154837
56
57         Reviewed by Alex Christensen.
58
59         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
60         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: Added.
61         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: Added.
62         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Added.
63
64 2016-02-29  Joanmarie Diggs  <jdiggs@igalia.com>
65
66         [GTK][jhbuild] GLib build fails with GCC 6.0
67         https://bugs.webkit.org/show_bug.cgi?id=154825
68
69         Use the upstream work-around. https://bugzilla.gnome.org/show_bug.cgi?id=761550
70
71         Reviewed by Csaba Osztrogonác.
72
73         * gtk/jhbuild.modules: Apply upstream path.
74         * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Added.
75
76 2016-02-29  Filip Pizlo  <fpizlo@apple.com>
77
78         We've been running Octane/regexp all wrong in run-jsc-benchmarks
79         https://bugs.webkit.org/show_bug.cgi?id=154827
80
81         Reviewed by Andreas Kling.
82
83         Octane v.2 and JetStream v.1.1 run this benchmark with warmup. This script was running
84         it without warmup. This patches fixes this by making this script run it with warmup.
85
86         This fix shows that my last patch, which added FTL support for regexp, was actually a 3%
87         speed-up on Octane/regexp, not a slow-down as the ChangeLog claimed.
88
89         It discovered this bug because for each Octane test that I want to debug, I usually make
90         a standalone .js file that contains the whole test along with a miniharness - usually
91         a plain loop - that runs it almost like it would for real but with whatever hacks I'm
92         using for debugging. When I wrote such a thing for regexp, I used a ~20 iteration warmup
93         to match the one second of warmup that this benchmark gets in Octane. To my surprise,
94         this quite faithful regexp runner did not see the regression that run-jsc-benchmarks
95         saw. That's when I found out that run-jsc-benchmarks was running it wrong.
96
97         The reason for the no-warmup slow-down is that the FTL is actually fairly expensive to
98         run on some of these very large functions in the regexp benchmark. I don't think we can
99         do anything about that, and I'd argue that the speed-up we see after the compilation is
100         done suggests that it was worth it.
101
102         * Scripts/run-jsc-benchmarks:
103
104 2016-02-29  Gavin Barraclough  <barraclough@apple.com>
105
106         RefCounter<T>::Event -> RefCounterEvent
107         https://bugs.webkit.org/show_bug.cgi?id=154767
108
109         Reviewed by Darin Adler.
110
111         RefCounter<T>::Event is kinda verbose to use, and there is no need for this
112         to be specific to a particular typeof RefCounter. Move the enum class up to
113         the top level & rename to RefCounterEvent.
114
115         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
116         (TestWebKitAPI::TEST):
117
118 2016-02-29  Csaba Osztrogonác  <ossy@webkit.org>
119
120         Remove more LLVM related cruft
121         https://bugs.webkit.org/show_bug.cgi?id=154821
122
123         Reviewed by Darin Adler.
124
125         * Scripts/build-jsc:
126         * Scripts/build-webkit:
127         * Scripts/copy-webkitlibraries-to-product-directory:
128         * Scripts/export-llvm-build: Removed.
129         * Scripts/run-jsc-stress-tests:
130
131 2016-02-28  Sam Weinig  <sam@webkit.org>
132
133         Reimplement WKPageGroup in terms of WKUserContentController
134         https://bugs.webkit.org/show_bug.cgi?id=154804
135
136         Reviewed by Dan Bernstein.
137
138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
139         * TestWebKitAPI/Tests/WebKit2/PageGroup.cpp: Added.
140
141 2016-02-28  Sam Weinig  <sam@webkit.org>
142
143         Bind _WKUserStyleSheets to WKUserContentWorlds to allow for grouping of user content by associating to a world
144         https://bugs.webkit.org/show_bug.cgi?id=154798
145
146         Reviewed by Dan Bernstein.
147
148         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
149         Add tests for removing _WKUserStyleSheets and WKUserScripts
150
151 2016-02-27  Alexey Proskuryakov  <ap@apple.com>
152
153         Silence leaks under TextCodecICU::registerCodecs
154         https://bugs.webkit.org/show_bug.cgi?id=154737
155
156         Reviewed by Darin Adler.
157
158         * Scripts/webkitpy/port/leakdetector.py:
159         (LeakDetector._callstacks_to_exclude_from_leaks):
160
161 2016-02-26  Michael Catanzaro  <mcatanzaro@igalia.com>
162
163         [GTK] Fix incorrect cast
164
165         Unreviewed.
166
167         * MiniBrowser/gtk/main.c:
168         (createBrowserWindow):
169
170 2016-02-26  Chris Dumez  <cdumez@apple.com>
171
172         Fix the behavior of reflecting IDL attributes of type unsigned long
173         https://bugs.webkit.org/show_bug.cgi?id=154771
174
175         Reviewed by Ryosuke Niwa.
176
177         Update API tests to cover the fixes to the parseHTMLNonNegativeInteger()
178         implementation:
179         - "-0" is parsed as 0.
180         - Range boundaries are now [0; 2147483647].
181
182         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
183         (TestWebKitAPI::TEST):
184
185 2016-02-26  Brady Eidson  <beidson@apple.com>
186
187         Modern IDB: New database versions are never committed to SQLite.
188         <rdar://problem/24860952> and https://bugs.webkit.org/show_bug.cgi?id=154741
189         
190         Modern IDB: If a database handle is not open, files are not actually deleted from disk
191         https://bugs.webkit.org/show_bug.cgi?id=154756
192
193         Reviewed by Alex Christensen.
194
195         This also happens to test the previously untested fix for http://trac.webkit.org/changeset/197190
196
197         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
198         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-1.html: Added.
199         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-2.html: Added.
200         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: Added.
201         (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]):
202         (-[IndexedDBMessageHandler userContentController:didReceiveScriptMessage:]):
203         (TEST):
204
205 2016-02-26  Commit Queue  <commit-queue@webkit.org>
206
207         Unreviewed, rolling out r197216.
208         https://bugs.webkit.org/show_bug.cgi?id=154766
209
210         Test simply needs updated result (Requested by litherum on
211         #webkit).
212
213         Reverted changeset:
214
215         "Unreviewed, rolling out r197158."
216         https://bugs.webkit.org/show_bug.cgi?id=154758
217         http://trac.webkit.org/changeset/197216
218
219 2016-02-26  Alexey Proskuryakov  <ap@apple.com>
220
221         [iOS Simulator] Reftests don't work
222         https://bugs.webkit.org/show_bug.cgi?id=154764
223
224         Reviewed by Daniel Bates.
225
226         * Scripts/webkitpy/port/image_diff.py: (IOSSimulatorImageDiffer._start):
227         Use simctl instead of sim.
228
229 2016-02-26  Chris Dumez  <cdumez@apple.com>
230
231         Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger
232         https://bugs.webkit.org/show_bug.cgi?id=154714
233
234         Reviewed by Darin Adler.
235
236         Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger as per:
237         - https://html.spec.whatwg.org/multipage/infrastructure.html#signed-integers
238         - https://html.spec.whatwg.org/multipage/infrastructure.html#non-negative-integers
239
240         * TestWebKitAPI/PlatformEfl.cmake:
241         * TestWebKitAPI/PlatformGTK.cmake:
242         * TestWebKitAPI/PlatformWin.cmake:
243         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
244         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
245         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
246         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp: Added.
247         (TestWebKitAPI::testParseHTMLInteger):
248         (TestWebKitAPI::parseHTMLIntegerFails):
249         (TestWebKitAPI::TEST):
250         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
251         (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
252
253 2016-02-26  Commit Queue  <commit-queue@webkit.org>
254
255         Unreviewed, rolling out r197158.
256         https://bugs.webkit.org/show_bug.cgi?id=154758
257
258         This change did not fix the failing test (Requested by
259         ryanhaddad on #webkit).
260
261         Reverted changeset:
262
263         "REGRESSION(r195795): [WK2] fast/text/crash-complex-text-
264         surrogate.html is flakey"
265         https://bugs.webkit.org/show_bug.cgi?id=154709
266         http://trac.webkit.org/changeset/197158
267
268 2016-02-26  Anders Carlsson  <andersca@apple.com>
269
270         WKWebsiteDataStore/WKWebsiteDataRecord needs to provide size information about each type of data
271         https://bugs.webkit.org/show_bug.cgi?id=154750
272         rdar://problem/23861395
273
274         Reviewed by Tim Horton.
275
276         * MiniBrowser/mac/WK2BrowserWindowController.m:
277         (-[WK2BrowserWindowController fetchWebsiteData:]):
278         Use the new WKWebsiteDataStore SPI to compute data sizes.
279
280 2016-02-25  Gavin Barraclough  <barraclough@apple.com>
281
282         RefCounter value changed callback should be called on all changes (not just zero edge).
283         https://bugs.webkit.org/show_bug.cgi?id=154699
284
285         Reviewed by Geoff Garen.
286
287         RefCounter currently only triggers a callback when the count goes from zero
288         to non-zero and vice-versa. Change that, to be useful to more clients.
289
290         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
291         (TestWebKitAPI::TEST):
292             - Updated for change in RefCounter callback siganture & behaviour.
293
294 2016-02-25  Sam Weinig  <sam@webkit.org>
295
296         Allow WKUserScripts to be run in isolated worlds
297         https://bugs.webkit.org/show_bug.cgi?id=154701
298
299         Reviewed by Anders Carlsson.
300
301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
302         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorld.mm: Added.
303         (-[SimpleDelegate webView:didFinishNavigation:]):
304         (-[UserContentWorldRemoteObject didObserveNormalWorld]):
305         (-[UserContentWorldRemoteObject didObserveWorldWithName:]):
306         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldPlugIn.mm: Added.
307         (-[_WKUserContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
308         (-[_WKUserContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
309         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldProtocol.h: Added.
310
311 2016-02-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
312
313         W3C test importer should have an option to clean the destination directory
314         https://bugs.webkit.org/show_bug.cgi?id=152685
315
316         Reviewed by Darin Adler.
317
318         Adding --clean-dest-dir option to W3C test importer.
319         When this option is set, all files in the destination directory will be deleted
320         except for WebKit specific files (test expectations, .gitignore...) before new tests import.
321         Dangling test expectations are removed after tests import.'
322
323         Adding unit test and minor refactoring for the other tests.
324
325         * Scripts/webkitpy/w3c/test_importer.py:
326         (parse_args): Add '--clean-dest-dir' option.
327         (TestImporter.do_import):
328         (TestImporter._is_baseline): helper routine to capture -expected.txt files.
329         (TestImporter):
330         (TestImporter._should_not_keep_when_importing): helper routine to filter files that should not be cleaned before importing.
331         (TestImporter.clean_destination_directory):
332         (TestImporter.remove_dangling_expectations):
333         * Scripts/webkitpy/w3c/test_importer_unittest.py:
334         (TestImporterTest._parse_options):
335         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
336         (TestImporterTest.test_import_dir_with_no_tests):
337         (TestImporterTest.test_import_dir_with_empty_init_py):
338         (test_clean_directory_option):
339
340 2016-02-25  Myles C. Maxfield  <mmaxfield@apple.com>
341
342         REGRESSION(r195795): [WK2] fast/text/crash-complex-text-surrogate.html is flakey
343         https://bugs.webkit.org/show_bug.cgi?id=154709
344         <rdar://problem/24483596>
345
346         Reviewed by Dan Bernstein.
347
348         Force auto-activation rules to a consistent state.
349
350         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
351         (WTR::InjectedBundle::platformInitialize):
352
353 2016-02-25  Jiewen Tan  <jiewen_tan@apple.com>
354
355         Unreivewed build fix for r197150.
356
357         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
358
359 2016-02-25  Jiewen Tan  <jiewen_tan@apple.com>
360
361         Restrict information passed with navigation action which is triggered by untrusted event
362         https://bugs.webkit.org/show_bug.cgi?id=154571
363         <rdar://problem/15967937>
364
365         Reviewed by Andy Estes.
366
367         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
368         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm: Added.
369         (-[WKNavigationActionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
370         (TestWebKitAPI::TEST):
371         (-[NavigationActionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
372         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.html: Added.
373
374 2016-02-25  Gavin Barraclough  <barraclough@apple.com>
375
376         Should template RefCounter instead of RefCounter::Token
377         https://bugs.webkit.org/show_bug.cgi?id=154691
378
379         Reviewed by Anders Carlsson.
380
381         Mechanical update per RefCounter interface change.
382
383         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
384         (TestWebKitAPI::TEST):
385
386 2016-02-25  Skachkov Aleksandr  <gskachkov@gmail.com>
387
388         Unreviewed: Add Aleksandr Skachkov as a commiter
389
390         * Scripts/webkitpy/common/config/contributors.json:
391
392 2016-02-25  Sam Weinig  <sam@webkit.org>
393
394         HashMap::ensure() should return an AddResult like all the other add-like functions
395         https://bugs.webkit.org/show_bug.cgi?id=154680
396
397         Reviewed by Anders Carlsson.
398
399         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
400         (TestWebKitAPI::TEST):
401         Update tests to use/test the new AddResult result.
402
403 2016-02-25  Alexey Proskuryakov  <ap@apple.com>
404
405         Enable MallocScribble when detecting leaks
406         https://bugs.webkit.org/show_bug.cgi?id=154679
407
408         Reviewed by Geoffrey Garen.
409
410         * Scripts/webkitpy/port/ios.py:
411         (IOSSimulatorPort.setup_environ_for_server):
412         * Scripts/webkitpy/port/mac.py:
413         (MacPort.setup_environ_for_server):
414         * Scripts/webkitpy/port/mac_unittest.py:
415         (MacTest.test_setup_environ_for_server):
416
417 2016-02-25  Eric Carlson  <eric.carlson@apple.com>
418
419         Unreviewed, fix iOS builds after r197114.
420
421         * WebKitTestRunner/TestController.cpp:
422         (WTR::createCanonicalUUIDString):
423         (WTR::TestController::saltForOrigin):
424
425 2016-02-25  Eric Carlson  <eric.carlson@apple.com>
426
427         [MediaStream] MediaDeviceInfo deviceId and groupId must be unique to the page's origin
428         https://bugs.webkit.org/show_bug.cgi?id=153163
429         <rdar://problem/24334526>
430
431         Reviewed by Tim Horton.
432
433         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
434         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Take top level document origin.
435         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
436
437         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
438         (WTR::TestRunner::setUserMediaPermissionForOrigin): Ditto.
439         * WebKitTestRunner/InjectedBundle/TestRunner.h:
440
441         * WebKitTestRunner/TestController.cpp:
442         (WTR::decidePolicyForUserMediaPermissionRequest): Pass through top level document origin.
443         (WTR::checkUserMediaPermissionForOrigin): Ditto.
444         (WTR::TestController::resetStateToConsistentValues): m_userMediaOriginPermissions -> m_cahcedUserMediaPermissions.
445         (WTR::originUserVisibleName): Return a String.
446         (WTR::userMediaOriginHash): Create a hash of the origin plus top level document origin.
447         (WTR::TestController::saltForOrigin): Return salt for an origin.
448         (WTR::TestController::setUserMediaPermissionForOrigin): Return permission for an origin.
449         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
450         (WTR::TestController::handleUserMediaPermissionRequest):
451         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
452         (WTR::OriginSettings::OriginSettings): New, class to cache settings for an origin.
453         (WTR::OriginSettings::persistentPermission): Persistent permissions for origin.
454         (WTR::OriginSettings::setPersistentPermission): Set permissions for origin.
455         (WTR::OriginSettings::persistentSalt): Return the persistent salt for the origin, if any.
456         (WTR::OriginSettings::setPersistentSalt): Set the persistent salt for the origin
457         (WTR::OriginSettings::ephemeralSalts): Return hashmap used to store per-frame salts.
458         * WebKitTestRunner/TestController.h:
459
460         * WebKitTestRunner/TestInvocation.cpp:
461         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
462
463 2016-02-24  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
464
465         [web-animations] Add AnimationTimeline, DocumentTimeline and add extensions to Document interface
466         https://bugs.webkit.org/show_bug.cgi?id=151688
467
468         Reviewed by Dean Jackson.
469
470         Enables the WEB_ANIMATIONS compiler switch by default.
471
472         * Scripts/webkitperl/FeatureList.pm:
473
474 2016-02-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
475
476         W3C importer should generate all web-platform-tests submodules descriptions
477         https://bugs.webkit.org/show_bug.cgi?id=154587
478
479         Reviewed by Darin Adler.
480
481         Updated submodules description format (removing submodule name as it is the last string of the path really).
482         Added git subroutines.
483
484         * Scripts/webkitpy/common/checkout/scm/git.py:
485         (Git.origin_url):
486         (Git):
487         (Git.init_submodules):
488         (Git.submodules_status):
489         (Git.deinit_submodules):
490         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
491         (WebPlatformTestServer._install_modules): Updated to submodule name removal.
492         * Scripts/webkitpy/w3c/test_downloader.py:
493         (TestDownloader._git_submodules_description): Updated to cope with recursive submodules (use of submodule init/deinit).
494         * Scripts/webkitpy/w3c/test_importer_unittest.py:
495         (TestImporterTest.test_submodules_generation): Reactivated partially this test.
496
497 2016-02-23  Dan Bernstein  <mitz@apple.com>
498
499         [Xcode] Linker errors display mangled names, but no longer should
500         https://bugs.webkit.org/show_bug.cgi?id=154632
501
502         Reviewed by Sam Weinig.
503
504         * ContentExtensionTester/Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
505         * DumpRenderTree/mac/Configurations/Base.xcconfig: Ditto.
506         * LayoutTestRelay/Configurations/Base.xcconfig: Ditto.
507         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
508         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
509         * WebEditingTester/Configurations/Base.xcconfig: Ditto.
510         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
511
512 2016-02-23  Anders Carlsson  <andersca@apple.com>
513
514         WKWebView should implement NSCoding
515         https://bugs.webkit.org/show_bug.cgi?id=137160
516
517         Reviewed by Dan Bernstein.
518
519         Add tests.
520
521         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
522         (TEST):
523
524 2016-02-23  Anders Carlsson  <andersca@apple.com>
525
526         WKProcessPool should conform to NSCoding
527         https://bugs.webkit.org/show_bug.cgi?id=154608
528
529         Reviewed by Sam Weinig.
530
531         Add tests.
532
533         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
534         (TEST):
535
536 2016-02-23  Anders Carlsson  <andersca@apple.com>
537
538         WKWebsiteDataStore should conform to NSCoding
539         https://bugs.webkit.org/show_bug.cgi?id=154605
540
541         Reviewed by Dan Bernstein.
542
543         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
544         (TEST):
545
546 2016-02-23  Anders Carlsson  <andersca@apple.com>
547
548         WKWebViewConfiguration should conform to NSCoding
549         https://bugs.webkit.org/show_bug.cgi?id=154602
550
551         Reviewed by Beth Dakin.
552
553         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
554         (TEST):
555
556 2016-02-23  Anders Carlsson  <andersca@apple.com>
557
558         WKPreferences should conform to NSCoding
559         https://bugs.webkit.org/show_bug.cgi?id=154597
560
561         Reviewed by Sam Weinig.
562
563         Test encoding and decoding WKPreferences.
564
565         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
566         (encodeAndDecode):
567         (TEST):
568
569 2016-02-23  Anders Carlsson  <andersca@apple.com>
570
571         Fix build.
572
573         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
574         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]):
575
576 2016-02-23  Carlos Alberto Lopez Perez  <clopez@igalia.com>
577
578         [GTK] Allow to run the WebKitGTK+ MiniBrowser with the run-benchmark script.
579         https://bugs.webkit.org/show_bug.cgi?id=153993
580
581         Reviewed by Carlos Garcia Campos.
582
583         * MiniBrowser/gtk/main.c:
584         (createBrowserWindow): Support --geometry argument for MiniBrowser.
585         We use this on the gtk_minibrowser_driver script to start the MiniBrowser maximized.
586         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Fix loading of subclasses:
587         The base class has to be loaded first, otherwise any subclase referencing it will give import error.
588         In OSX the ordering of os.listdir() causes the base class (browser_driver.py) to be first on the list, but not on Linux.
589         By specifiying the name of the base class file, we ensure it is always loaded first on any system despite the ordering of listdir.
590         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
591         (BrowserDriverFactory.create):
592         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py: Added.
593         (GTKBrowserDriver):
594         (GTKBrowserDriver.prepare_env):
595         (GTKBrowserDriver.restore_env):
596         (GTKBrowserDriver.close_browsers):
597         (GTKBrowserDriver._launch_process):
598         (GTKBrowserDriver._terminate_processes):
599         (GTKBrowserDriver._screen_size):
600         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Added.
601         (GTKMiniBrowserDriver):
602         (GTKMiniBrowserDriver.prepare_env):
603         (GTKMiniBrowserDriver.launch_url):
604         (GTKMiniBrowserDriver.close_browsers):
605         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Fix loading of subclasses. See description above.
606         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
607         (SimpleHTTPServerDriver):
608         (SimpleHTTPServerDriver.kill_server): Check if the server is still running before trying to terminate it.
609         Usually the server ends gracefully (no need to terminate it), so this was causing ugly errors on the log.
610         * Scripts/webkitpy/benchmark_runner/utils.py: Fix loading of subclasses. See description above.
611         (load_subclasses):
612
613 2016-02-23  Alejandro G. Castro  <alex@igalia.com>
614
615         [GTK] Missing configuration patch for openh264 compilation
616         https://bugs.webkit.org/show_bug.cgi?id=154455
617
618         This patch is required for the openh264 compilation with the
619         jhbuild-webrtc.modules. The code was implemented by Alessandro
620         Decina.
621
622         Reviewed by Philippe Normand.
623
624         * gtk/patches/openh264-configure.patch: Added.
625
626 2016-02-20  Olivier Blin  <olivier.blin@softathome.com>
627
628         [cmake] Use ICU include dirs in WebKit2 and WebKitTestRunner
629         https://bugs.webkit.org/show_bug.cgi?id=154479
630
631         Reviewed by Michael Catanzaro.
632
633         * WebKitTestRunner/CMakeLists.txt:
634
635 2016-02-19  Konstantin Tokarev  <annulen@yandex.ru>
636
637         [GTK] Fixed link error when G_DEFINE_AUTOPTR_CLEANUP_FUNC is not defined.
638         https://bugs.webkit.org/show_bug.cgi?id=154467
639
640         Reviewed by Michael Catanzaro.
641
642         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp:
643         (beforeAll):
644         (afterAll):
645
646 2016-02-19  Brady Eidson  <beidson@apple.com>
647
648         Add "databaseProcessDidCrash" to the WKContextClient; Adopt it in WKTR.
649         https://bugs.webkit.org/show_bug.cgi?id=154428
650
651         Reviewed by Jer Noble.
652
653         * WebKitTestRunner/TestController.cpp:
654         (WTR::TestController::generatePageConfiguration):
655         (WTR::TestController::databaseProcessName):
656         (WTR::TestController::databaseProcessDidCrash):
657         * WebKitTestRunner/TestController.h:
658
659 2016-02-18  Philippe Normand  <pnormand@igalia.com>
660
661         [GStreamer] Bump internal jhbuild versions to 1.6.3
662         https://bugs.webkit.org/show_bug.cgi?id=149594
663
664         Reviewed by Michael Catanzaro.
665
666         * gtk/jhbuild.modules: Bump to GStreamer 1.6.3.
667         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
668         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
669         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
670
671 2016-02-18  Brent Fulgham  <bfulgham@apple.com>
672
673         Extend HashCountedSet with a method to efficiently set the count of an entry
674         https://bugs.webkit.org/show_bug.cgi?id=154352
675
676         Reviewed by Geoffrey Garen.
677
678         * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
680         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
681
682 2016-02-18  Commit Queue  <commit-queue@webkit.org>
683
684         Unreviewed, rolling out r196791.
685         https://bugs.webkit.org/show_bug.cgi?id=154438
686
687         broke windows build (Requested by alexchristensen on #webkit).
688
689         Reverted changeset:
690
691         "Extend HashCountedSet with a method to efficiently set the
692         count of an entry"
693         https://bugs.webkit.org/show_bug.cgi?id=154352
694         http://trac.webkit.org/changeset/196791
695
696 2016-02-18  Brent Fulgham  <bfulgham@apple.com>
697
698         Extend HashCountedSet with a method to efficiently set the count of an entry
699         https://bugs.webkit.org/show_bug.cgi?id=154352
700
701         Reviewed by Geoffrey Garen.
702
703         * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
705         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
706
707 2016-02-18  Anders Carlsson  <andersca@apple.com>
708
709         Get rid of the --target-web-process and --use-web-process-xpc-service options.
710
711         Rubber-stamped by Dan Bernstein.
712
713         We now always use XPC, and --target-web-process is no longer supported.
714
715         * Scripts/webkitdirs.pm:
716         (execMacWebKitAppForDebugging):
717         (shouldTargetWebProcess): Deleted.
718         (determineShouldTargetWebProcess): Deleted.
719         (shouldUseXPCServiceForWebProcess): Deleted.
720         (determineShouldUseXPCServiceForWebProcess): Deleted.
721         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Deleted.
722         (argumentsForRunAndDebugMacWebKitApp): Deleted.
723
724 2016-02-18  Ryan Haddad  <ryanhaddad@apple.com>
725
726         Skip API test WTF_ParkingLot.UnparkOneFiftyThenFiftyAll on ios-simulator
727         https://bugs.webkit.org/show_bug.cgi?id=153997
728
729         Reviewed by Filip Pizlo.
730
731         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
732
733 2016-02-18  Jer Noble  <jer.noble@apple.com>
734
735         run-webkit-httpd should use webkitpy to run httpd.
736         https://bugs.webkit.org/show_bug.cgi?id=154271
737
738         Reviewed by Alexey Proskuryakov.
739
740         Update run-webkit-httpd to use webkitpy.port to launch httpd. Pass on http_port and http_all_interface
741         options to match the current run-webkit-httpd (optional) behavior.
742
743         * Scripts/run-webkit-httpd:
744         (parse_args):
745         (main):
746         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
747         (LayoutTestApacheHttpd.__init__):
748         * Scripts/webkitpy/layout_tests/servers/http_server.py:
749         (Lighttpd._prepare_config):
750         * Scripts/webkitpy/port/base.py:
751         (Port.to.start_http_server):
752
753 2016-02-18  Filip Pizlo  <fpizlo@apple.com>
754
755         Remove remaining references to LLVM, and make sure comments refer to the backend as "B3" not "LLVM"
756         https://bugs.webkit.org/show_bug.cgi?id=154383
757
758         Reviewed by Saam Barati.
759
760         * Scripts/run-jsc-stress-tests:
761
762 2016-02-17  Filip Pizlo  <fpizlo@apple.com>
763
764         Remove LLVM dependencies from WebKit
765         https://bugs.webkit.org/show_bug.cgi?id=154323
766
767         Reviewed by Antti Koivisto and Benjamin Poulain.
768
769         * Scripts/copy-webkitlibraries-to-product-directory:
770         (isContentOfFileEqualToString):
771         (fileContains): Deleted.
772         (buildLLVM): Deleted.
773         (symlinkLLVMLibrariesIfNeeded): Deleted.
774
775 2016-02-16  Sam Weinig  <sam@webkit.org>
776
777         Add an ensure function on HashMap that takes a key and a function to make the lazy value initialization idiom easier
778         https://bugs.webkit.org/show_bug.cgi?id=134857
779
780         Reviewed by Geoffrey Garen.
781
782         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
783         Add tests for HashMap::ensure.
784
785 2016-02-17  Nan Wang  <n_wang@apple.com>
786
787         AX: Implement sentence related text marker functions using TextIterator
788         https://bugs.webkit.org/show_bug.cgi?id=154312
789
790         Reviewed by Chris Fleizach.
791
792         * DumpRenderTree/AccessibilityUIElement.cpp:
793         (nextParagraphEndTextMarkerForTextMarkerCallback):
794         (sentenceTextMarkerRangeForTextMarkerCallback):
795         (previousSentenceStartTextMarkerForTextMarkerCallback):
796         (nextSentenceEndTextMarkerForTextMarkerCallback):
797         (setSelectedVisibleTextRangeCallback):
798         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
799         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
800         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
801         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
802         (AccessibilityUIElement::getJSClass):
803         * DumpRenderTree/AccessibilityUIElement.h:
804         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
805         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
806         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
807         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
808         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
809         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
810         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
811         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
812         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
813         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
814         (AccessibilityUIElement::supportedActions):
815         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
816         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
817         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
818         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
819         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
820         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
821         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
822         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
823         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
824         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
825         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
826         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
827         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
828         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
829         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
830         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
831         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
832         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
833         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
834         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
835         (WTR::_convertMathMultiscriptPairsToString):
836
837 2016-02-15  Brent Fulgham  <bfulgham@apple.com>
838
839         [Mac] Gather some rudimentary statistics during resource load 
840         https://bugs.webkit.org/show_bug.cgi?id=153575
841         <rdar://problem/24075254>
842
843         Reviewed by Brady Eidson.
844
845         * MiniBrowser/mac/SettingsController.h:
846         * MiniBrowser/mac/SettingsController.m:
847         (-[SettingsController _populateMenu]): Add menu item for new debug flag.
848         (-[SettingsController toggleResourceLoadStatisticsEnabled:]): Added.
849         (-[SettingsController resourceLoadStatisticsEnabled]): Added.
850         * MiniBrowser/mac/WK1BrowserWindowController.m:
851         (-[WK1BrowserWindowController didChangeSettings]): React to changes in
852         users's desire to track resource load statistics.
853
854 2016-02-15  Csaba Osztrogonác  <ossy@webkit.org>
855
856         [EFL] Update Tools/efl/install-dependencies
857         https://bugs.webkit.org/show_bug.cgi?id=154239
858
859         Reviewed by Michael Catanzaro.
860
861         * efl/install-dependencies:
862
863 2016-02-15  Alex Christensen  <achristensen@webkit.org>
864
865         Fix internal Windows build of projects built after WebKit
866         https://bugs.webkit.org/show_bug.cgi?id=154249
867         rdar://problem/24644805
868
869         Reviewed by Chris Dumez.
870
871         * DumpRenderTree/PlatformWin.cmake:
872         * MiniBrowser/win/CMakeLists.txt:
873         Don't include DerivedSources/WebKit/Interfaces to make MiniBrowser and DumpRenderTree
874         more like projects built internally after WebKit.  They should only need to use what
875         is in ForwardingHeaders/WebKit.
876
877 2016-02-12  Nan Wang  <n_wang@apple.com>
878
879         AX: Implement paragraph related text marker functions using TextIterator
880         https://bugs.webkit.org/show_bug.cgi?id=154098
881         <rdar://problem/24269675>
882
883         Reviewed by Chris Fleizach.
884
885         * DumpRenderTree/AccessibilityUIElement.cpp:
886         (nextWordEndTextMarkerForTextMarkerCallback):
887         (paragraphTextMarkerRangeForTextMarkerCallback):
888         (previousParagraphStartTextMarkerForTextMarkerCallback):
889         (nextParagraphEndTextMarkerForTextMarkerCallback):
890         (setSelectedVisibleTextRangeCallback):
891         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
892         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
893         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
894         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
895         (AccessibilityUIElement::getJSClass):
896         * DumpRenderTree/AccessibilityUIElement.h:
897         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
898         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
899         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
900         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
901         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
902         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
903         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
904         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
905         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
906         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
907         (AccessibilityUIElement::supportedActions):
908         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
909         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
910         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
911         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
912         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
913         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
914         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
915         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
916         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
917         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
918         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
919         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
920         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
921         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
922         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
923         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
924         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
925         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
926         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
927         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
928         (WTR::_convertMathMultiscriptPairsToString):
929
930 2016-02-12  Jason Marcell  <jmarcell@apple.com>
931
932         Open source bot watcher's dashboard fails assertion in BuildbotQueue.prototype.compareIterationsByRevisions
933         https://bugs.webkit.org/show_bug.cgi?id=154180
934
935         Reviewed by Alexey Proskuryakov.
936
937         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Remove reference to Internal
938         repository.
939
940 2016-02-12  Jer Noble  <jer.noble@apple.com>
941
942         [Mac] Adopt MediaResourceLoader (instead of CachedResourceLoader) in WebCoreNSURLSession.
943         https://bugs.webkit.org/show_bug.cgi?id=154136
944
945         Reviewed by Alex Christensen.
946
947         Use a MediaResourceLoader instead of a CachedResourceLoader for WebCoreNSURLSession.
948
949         Drive-by fix: generate USE and ENABLE macros for TestWebKitAPI by adding FEATURE_DEFINES
950         to GCC_PREPROCESSOR_DEFINES.
951
952         * TestWebKitAPI/Configurations/Base.xcconfig:
953         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
954         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
955         (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
956         (TestWebKitAPI::TEST_F):
957
958 2016-02-11  Dana Burkart  <dburkart@apple.com>
959
960         Large logs can bring down the webkit master
961         https://bugs.webkit.org/show_bug.cgi?id=122112
962
963         Reviewed by Lucas Forschler.
964
965         Implement the suggested fix of throwing away stdout / stderr.
966
967         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
968         (RunWebKit1LeakTests):
969
970 2016-02-10  Jason Marcell  <jmarcell@apple.com>
971
972         Remove calls to parseInt in order to work with non-integer revisions
973         https://bugs.webkit.org/show_bug.cgi?id=153820
974
975         Reviewed by Daniel Bates.
976
977         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
978         (BuildbotIteration.prototype.sourceStampChanges): Remove calls to parseInt in order to work with non-integer
979         revisions.
980         (BuildbotIteration.prototype._parseData): Ditto.
981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
982         (BuildbotQueue.prototype.update): Ditto.
983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:
984         (MockBuildbotQueueView.prototype._latestProductiveIteration): Change integers to strings in test code.
985         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
986         (MockTrac.prototype.get oldestRecordedRevisionNumber): Ditto.
987         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
988         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Ditto.
989
990 2016-02-10  Jason Marcell  <jmarcell@apple.com>
991
992         Teach dashboard code to compare non-integer revisions
993         https://bugs.webkit.org/show_bug.cgi?id=152345
994
995         Reviewed by Daniel Bates.
996
997         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
998         (BuildbotQueue.prototype.compareIterationsByRevisions): Compare non-integer revisions.
999         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1000         (BuildbotQueueView.prototype._appendPendingRevisionCount): Use Trac.indexOfRevision in order to compare non-integer
1001         revisions. Also uses new Trac.commitsOnBranchLaterThanRevision method.
1002         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Ditto.
1003         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Use Trac.indexOfRevision in order to compare non-integer
1004         revisions. Also uses new Trac.nextRevision method to calculate a revision range.
1005         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
1006         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1007         (Trac.prototype._commitsOnBranch): Renamed this to indicate that it should be a private method used by the latter two new
1008         methods.
1009         (Trac.prototype.commitsOnBranchLaterThanRevision): Finds revisions on a branch later than the specified revision.
1010         (Trac.prototype.commitsOnBranchInRevisionRange): Finds revisions on a branch within a specified range.
1011         (Trac.prototype.nextRevision): Finds the next revision after a given revision on a specific branch.
1012         (Trac.prototype.indexOfRevision): Finds the index of a given revision within the recordedCommits array.
1013         (Trac.prototype.commitsOnBranch): Deleted. Renamed to _commitsOnBranch.
1014         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests.
1015
1016 2016-02-09  Nan Wang  <n_wang@apple.com>
1017
1018         AX: Implement word related text marker functions using TextIterator
1019         https://bugs.webkit.org/show_bug.cgi?id=153939
1020         <rdar://problem/24269605>
1021
1022         Reviewed by Chris Fleizach.
1023
1024         * DumpRenderTree/AccessibilityUIElement.cpp:
1025         (endTextMarkerCallback):
1026         (leftWordTextMarkerRangeForTextMarkerCallback):
1027         (rightWordTextMarkerRangeForTextMarkerCallback):
1028         (previousWordStartTextMarkerForTextMarkerCallback):
1029         (nextWordEndTextMarkerForTextMarkerCallback):
1030         (setSelectedVisibleTextRangeCallback):
1031         (AccessibilityUIElement::setSelectedVisibleTextRange):
1032         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1033         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1034         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1035         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1036         (AccessibilityUIElement::getJSClass):
1037         * DumpRenderTree/AccessibilityUIElement.h:
1038         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1039         (AccessibilityUIElement::setSelectedVisibleTextRange):
1040         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1041         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1042         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1043         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1044         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1045         (AccessibilityUIElement::setSelectedVisibleTextRange):
1046         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1047         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1048         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1049         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1050         (AccessibilityUIElement::supportedActions):
1051         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1052         (WTR::AccessibilityUIElement::setBoolAttributeValue):
1053         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1054         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1055         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1056         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1057         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1058         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1059         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1060         (WTR::AccessibilityUIElement::endTextMarker):
1061         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1062         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1063         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1064         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1065         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1066         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1067         (WTR::AccessibilityUIElement::endTextMarker):
1068         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1069         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1070         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1071         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1072         (WTR::_convertMathMultiscriptPairsToString):
1073
1074 2016-02-09  Csaba Osztrogonác  <ossy@webkit.org>
1075
1076         [EFL] Remove eail related cruft after r195725
1077         https://bugs.webkit.org/show_bug.cgi?id=154030
1078
1079         Reviewed by Alex Christensen.
1080
1081         * efl/jhbuildrc:
1082
1083 2016-02-09  Csaba Osztrogonác  <ossy@webkit.org>
1084
1085         [EFL] Remove LLVM related cruft after r196077
1086         https://bugs.webkit.org/show_bug.cgi?id=154031
1087
1088         Reviewed by Alex Christensen.
1089
1090         * efl/jhbuild.modules:
1091         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Removed.
1092         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed.
1093         * efl/patches/llvm-version-arm64.patch: Removed.
1094
1095 2016-02-05  Aakash Jain  <aakash_jain@apple.com>
1096
1097         tests fail if display sleeps while run-webkit-tests is running
1098         https://bugs.webkit.org/show_bug.cgi?id=153919
1099
1100         Reviewed by Alexey Proskuryakov.
1101
1102         * DumpRenderTree/mac/LayoutTestHelper.m:
1103         (addDisplaySleepAssertion): Add the assertion so that the display doesn't turn off.
1104         (releaseDisplaySleepAssertion): Release the DisplaySleep Assertion.
1105         (simpleSignalHandler): Release the DisplaySleepAssertion in case of any iterrupt.
1106
1107 2016-02-05  Alex Christensen  <achristensen@webkit.org>
1108
1109         Fix iOS API tests after r196082
1110         https://bugs.webkit.org/show_bug.cgi?id=153900
1111
1112         Reviewed by Jer Noble.
1113
1114         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1115         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
1116         [WebView initialize] doesn't call JSC::initializeThreading on iOS.
1117
1118 2016-02-04  Jason Marcell  <jmarcell@apple.com>
1119
1120         The status message for passing combined builder queues should say "all builds succeeded" when expanded.
1121         https://bugs.webkit.org/show_bug.cgi?id=153882
1122
1123         Reviewed by Alexey Proskuryakov.
1124
1125         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1126         (BuildbotCombinedQueueView.prototype.update): Set status to "all builds succeeded" for combined builder queues
1127         when expanded.
1128
1129 2016-02-03  Filip Pizlo  <fpizlo@apple.com>
1130
1131         run-jsc-stress-tests should be better at telling you details about test failures
1132         https://bugs.webkit.org/show_bug.cgi?id=153845
1133
1134         Reviewed by Geoffrey Garen.
1135
1136         Here's an example of the contents of results/resultsByFamily, one of the new files that this
1137         generates, for some local testing I'm doing.  Notice how it groups families of tests together.
1138
1139         You won't see this unless you cat results/resultsByFamily.
1140
1141         regress.yaml/Regress/radar-24289839.js:
1142             regress.yaml/Regress/radar-24289839.js.default: PASS
1143             regress.yaml/Regress/radar-24289839.js.ftl: PASS
1144             regress.yaml/Regress/radar-24289839.js.ftl-no-cjit: FAIL
1145             regress.yaml/Regress/radar-24289839.js.ftl-eager-no-cjit: FAIL
1146         
1147         regress.yaml/Regress/radar-24290639.js:
1148             regress.yaml/Regress/radar-24290639.js.default: PASS
1149             regress.yaml/Regress/radar-24290639.js.ftl: PASS
1150             regress.yaml/Regress/radar-24290639.js.ftl-no-cjit: PASS
1151             regress.yaml/Regress/radar-24290639.js.ftl-eager-no-cjit: FAIL
1152         
1153         regress.yaml/Regress/radar-24290670.js: FAILED
1154         
1155         * Scripts/run-jsc-stress-tests:
1156
1157 2016-02-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1158
1159         [WTR] Crash in EventSendingController::contextClick() when context menu event is not handled
1160         https://bugs.webkit.org/show_bug.cgi?id=153835
1161
1162         Reviewed by Martin Robinson.
1163
1164         WKBundlePageCopyContextMenuAtPointInWindow() returns nullptr when
1165         the context menu event is not handled, but we are using the
1166         returned value without null checking it.
1167
1168         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1169         (WTR::EventSendingController::contextClick):
1170
1171 2016-02-03  Jason Marcell  <jmarcell@apple.com>
1172
1173         Format revisions for display according to repository type
1174         https://bugs.webkit.org/show_bug.cgi?id=153818
1175
1176         Reviewed by Alexey Proskuryakov.
1177
1178         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1179         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Use new _formatRevisionForDisplay to display revisions according
1180         to repository type.
1181         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
1182         (BuildbotQueueView.prototype._formatRevisionForDisplay): Formats revisions for display according to repository type.
1183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test new
1184         _formatRevisionForDisplay function.
1185
1186 2016-02-03  Aakash Jain  <aakash_jain@apple.com>
1187
1188         Logs/CoreSimulator filling up OS disk on WebKit testers
1189         https://bugs.webkit.org/show_bug.cgi?id=153853
1190         <rdar://problem/24496003>
1191
1192         Reviewed by Alexey Proskuryakov.
1193
1194         * Scripts/webkitpy/port/ios.py:
1195         (IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup.
1196
1197 2016-02-03  Brian Burg  <bburg@apple.com>
1198
1199         git-add-reviewer should work when run from a subdirectory within the repository
1200         https://bugs.webkit.org/show_bug.cgi?id=153842
1201
1202         Reviewed by David Kilzer.
1203
1204         There are two problems that needed to be fixed:
1205
1206          - We can't assume .git is in $PWD/.git
1207          - We can't specify absolute paths to `git commit`
1208
1209         Fix these problems using the helpers in VCSUtils that were added to
1210         fix this same issue for prepare-changeCogs.
1211
1212         * Scripts/VCSUtils.pm: Export gitDirectory()
1213         * Scripts/git-add-reviewer:
1214         (nonInteractive): Cache gitDirectory() result.
1215         (addReviewer):
1216         (commit):
1217         (changeLogsForCommit): Make paths relative.
1218
1219 2016-02-03  Jer Noble  <jer.noble@apple.com>
1220
1221         Yet another Yosemite build fix.
1222
1223         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1224
1225 2016-02-03  Jer Noble  <jer.noble@apple.com>
1226
1227         iOS build fix after Yosemite build fix broke iOS build.
1228
1229         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1230
1231 2016-02-03  Jer Noble  <jer.noble@apple.com>
1232
1233         Yosemite build fix; hide the entire WebCoreNSURLSessionDataTask class from Yosemite and prior.
1234
1235         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1236
1237 2016-02-03  Joonghun Park  <jh718.park@samsung.com>
1238
1239         [Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well
1240         https://bugs.webkit.org/show_bug.cgi?id=153827
1241
1242         Reviewed by Michael Catanzaro.
1243
1244         When an array is passed to subroutines as argument in perl,
1245         a list containing its element is returned from the array.
1246         Currently @$ arguments are being passed, then it is going to be one list
1247         including all the elements not only from @ but also from $.
1248         As a result, --cmakeargs option's value is included in @cmakeArgs
1249         at generateBuildSystemFromCMakeProject subroutine,
1250         so $additionalCMakeArgs doesn't needed anymore.
1251
1252         * Scripts/webkitdirs.pm:
1253         (generateBuildSystemFromCMakeProject):
1254
1255 2016-02-03  Jer Noble  <jer.noble@apple.com>
1256
1257         [Mac] Wrap a resource and resource loader in a NSURLSession-like object for use by lower level frameworks
1258         https://bugs.webkit.org/show_bug.cgi?id=153669
1259
1260         Reviewed by Alex Christensen.
1261
1262         Add an API test for WebCoreNSURLSession, testing that it behaves like a regulare NSURLSession, including
1263         calling appropriate NSURLSessionDelegate callbacks.
1264
1265         Drive-by fix: Add a FeatureDefines.xcconfig to TestWebKitAPI.  Without this, the ENABLE macros in WebCore
1266         header files will not match the one used when compiling WebCore, leading to strange crashes and weird
1267         inconsistencies when calling, e.g., inline methods.
1268
1269         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added.
1270         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1271         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1272         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: Added.
1273         (-[TestNSURLSessionLoaderDelegate webView:didCommitLoadForFrame:]):
1274         (-[TestNSURLSessionDataDelegate URLSession:task:didCompleteWithError:]):
1275         (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
1276         (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveData:]):
1277         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
1278         (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
1279         (TestWebKitAPI::TEST_F):
1280
1281 2016-02-03  Konstantin Tokarev  <annulen@yandex.ru>
1282
1283         [webkitdirs] Clarify logic behind is{PortName} functions.
1284         https://bugs.webkit.org/show_bug.cgi?id=153554
1285
1286         Reviewed by Michael Catanzaro.
1287
1288         * Scripts/webkitdirs.pm:
1289         (prohibitUnknownPort): This function makes determinePortName()
1290         failure fatal.
1291         (determinePortName): Added new function which decides which port are
1292         we building based on command line switches and platform defaults.
1293         (portName): Added getter for determined $portName.
1294         (isEfl): Modified to use portName().
1295         (isGtk): Ditto.
1296         (isWinCairo): Ditto.
1297         (isAppleMacWebKit): Ditto.
1298         (isAppleWinWebKit): Ditto.
1299         (isIOSWebKit): Ditto.
1300         (cmakeBasedPortName): Return portName() with capitalized first letter.
1301         (determineIsEfl): Deleted.
1302         (determineIsGtk): Deleted.
1303         (determineIsWinCairo): Deleted.
1304
1305         * Scripts/build-jsc: Call prohibitUnknownPort().
1306         * Scripts/run-minibrowser: Ditto.
1307         * Scripts/webkitperl/FeatureList.pm: Ditto.
1308         * Scripts/update-webkit: Call determinePortName() instead of
1309         determineIsWinCairo().
1310
1311 2016-02-02  Dan Bernstein  <mitz@apple.com>
1312
1313         Better fix for Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
1314         https://bugs.webkit.org/show_bug.cgi?id=153683
1315
1316         Reviewed by Darin Adler.
1317
1318         * Scripts/webkitpy/port/driver.py:
1319         (Driver._setup_environ_for_driver): Reverted change from r196013. DUMPRENDERTREE_TEMP is not
1320           used by any code in the Web Content process. If that ever changed, we should send it over
1321           as a bundle parameter.
1322
1323         * Scripts/webkitpy/port/ios.py:
1324         (IOSSimulatorPort.setup_environ_for_server): Reverted change from r196013.
1325
1326         * Scripts/webkitpy/port/mac.py:
1327         (MacPort.setup_environ_for_server): Ditto.
1328
1329         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1330         (WTR::InjectedBundle::platformInitialize): Set XML_CATALOG_FILES in the Web Process
1331           environment. This is early enough that libxml2 has not been initialized yet.
1332
1333         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1334         (WTR::InjectedBundle::platformInitialize): Ditto.
1335
1336 2016-02-02  Dan Bernstein  <mitz@apple.com>
1337
1338         Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
1339         https://bugs.webkit.org/show_bug.cgi?id=153683
1340
1341         Reviewed by Alexey Proskuryakov.
1342
1343         Ensure that XML_CATALOG_FILES is set in the Web Content service’s environment as well.
1344
1345         * Scripts/webkitpy/port/driver.py:
1346         (Driver._setup_environ_for_driver): Also set __XPC_DUMPRENDERTREE_TEMP.
1347         * Scripts/webkitpy/port/ios.py:
1348         (IOSSimulatorPort.setup_environ_for_server): Set __XPC_XML_CATALOG_FILES.
1349         * Scripts/webkitpy/port/mac.py:
1350         (MacPort.setup_environ_for_server): Ditto.
1351
1352 2016-01-29 Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1353
1354         [EFL] Virtual Keyboard overlaps MiniBrowser's WebView
1355         https://bugs.webkit.org/show_bug.cgi?id=153009
1356
1357         Reviewed by Gyuyoung Kim.
1358
1359         On mobile, virtual keyboard represented by ecore_imf module appears on
1360         the top of application layer usually covering bottom part of the screen.
1361         If the web page contains the editable content on the bottom of the page
1362         it will be overlapped by keyboard which prevents user from seeing the
1363         typed text.
1364
1365         Pack MiniBrowser layout into conformant widget to allow EFL to guess
1366         the space that will be required by the keyboard, finally resizing it
1367         to the desired size. As a result, webview gets resized and scrolled
1368         into focused elements which makes the editable elements visible while
1369         typing.
1370
1371         More details about elm_conformant widger can be found at:
1372         https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
1373         https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
1374
1375         * MiniBrowser/efl/main.c:
1376         (window_create): pack a box into conformant widget.
1377
1378 2016-02-02  Alejandro G. Castro  <alex@igalia.com>
1379
1380         [GTK][EFL] Upgrade OpenWebRTC dependency
1381         https://bugs.webkit.org/show_bug.cgi?id=153489
1382
1383         Reviewed by Philippe Normand.
1384
1385         * Scripts/run-gtk-tests:
1386         (TestRunner): Avoid running the mediastream API test.
1387         * Scripts/webkitperl/FeatureList.pm: Stop compiling mediastream by
1388         default for gtk and efl.
1389         * gtk/jhbuild-webrtc.modules: Added modules files with
1390         dependencies required to compile and test the mediastream.
1391
1392 2016-02-01  Jason Marcell  <jmarcell@apple.com>
1393
1394         Add code to parse the git branches out of the Trac RSS feed
1395         https://bugs.webkit.org/show_bug.cgi?id=153624
1396
1397         Reviewed by Daniel Bates.
1398
1399         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1400         (Trac.prototype.commitsOnBranch): Update filter to check for Git branches.
1401         (Trac.prototype._convertCommitInfoElementToObject): Parse Git branches from the Trac RSS feed. Also changed "branchName" to
1402         "branches" and updated the code to work with an array instead of a string.
1403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
1404         (MockTrac): Refactored example commits out into a constant, MockTrac.EXAMPLE_TRAC_COMMITS.
1405         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml: Added. Test
1406         fixture that contains XML with a Git branch.
1407         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing Git
1408         branches from Trac RSS feed. Also updated code to work with the new MockTrac.EXAMPLE_TRAC_COMMITS constant.
1409
1410 2016-02-01  Brady Eidson  <beidson@apple.com>
1411
1412         Add command line flag to DRT to output the number of tests completed in server mode.
1413         https://bugs.webkit.org/show_bug.cgi?id=153750
1414
1415         Reviewed by Darin Adler.
1416
1417         * DumpRenderTree/mac/DumpRenderTree.mm:
1418         (initializeGlobalsFromCommandLineOptions):
1419         (runTestingServerLoop):
1420
1421 2016-02-01  Jason Marcell  <jmarcell@apple.com>
1422
1423         Improvements to botwatcher's dashboard unit tests.
1424         https://bugs.webkit.org/show_bug.cgi?id=153621
1425
1426         Reviewed by Darin Adler.
1427
1428         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
1429         (PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.
1430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
1431         (MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and
1432         _popoverLinesForCommitRange have to traverse commits from different branches.
1433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual
1434         in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
1435         _revisionContentWithPopoverForIteration.
1436
1437 2016-02-01  Jason Marcell  <jmarcell@apple.com>
1438
1439         Refactor to add event listeners and start periodic updates for all trac instances.
1440         https://bugs.webkit.org/show_bug.cgi?id=153609
1441
1442         Reviewed by Darin Adler.
1443
1444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1445         (BuildbotQueueView): Adding event listeners for all trac instances.
1446         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Starting periodic updates
1447         for all trac instances.
1448
1449 2016-01-31  Darin Adler  <darin@apple.com>
1450
1451         Replace CaseFoldingHash with ASCIICaseInsensitiveHash
1452         https://bugs.webkit.org/show_bug.cgi?id=153639
1453
1454         Reviewed by Filip Pizlo.
1455
1456         * Scripts/do-webcore-rename: Use script to do this rename.
1457
1458 2016-01-30  Commit Queue  <commit-queue@webkit.org>
1459
1460         Unreviewed, rolling out r195911.
1461         https://bugs.webkit.org/show_bug.cgi?id=153723
1462
1463         Caused frequent assertion failures on bots (Requested by ap on
1464         #webkit).
1465
1466         Reverted changeset:
1467
1468         "Replace CaseFoldingHash with ASCIICaseInsensitiveHash"
1469         https://bugs.webkit.org/show_bug.cgi?id=153639
1470         http://trac.webkit.org/changeset/195911
1471
1472 2016-01-30  Darin Adler  <darin@apple.com>
1473
1474         Replace CaseFoldingHash with ASCIICaseInsensitiveHash
1475         https://bugs.webkit.org/show_bug.cgi?id=153639
1476
1477         Reviewed by Filip Pizlo.
1478
1479         * Scripts/do-webcore-rename: Use script to do this rename.
1480
1481 2016-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1482
1483         TouchList should be retargeted
1484         https://bugs.webkit.org/show_bug.cgi?id=149592
1485
1486         Reviewed by Antti Koivisto.
1487
1488         Added touchDownAtPoint and liftUpAtPoint to UIScriptController so that we can test touch events with
1489         multiple touch targets on iOS. fast/shadow-dom/touch-event-ios.html uses this new testing feature.
1490
1491         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1492         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1493         (WTR::UIScriptController::touchDownAtPoint): Added.
1494         (WTR::UIScriptController::liftUpAtPoint): Added.
1495         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1496         * WebKitTestRunner/ios/HIDEventGenerator.h:
1497         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1498         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]): Added. Sends touch down and waits.
1499         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]): Ditto for lift up.
1500         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1501         (WTR::UIScriptController::touchDownAtPoint): Added.
1502         (WTR::UIScriptController::liftUpAtPoint): Added.
1503
1504 2016-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1505
1506         Enable SamplingProfiler on POSIX environment
1507         https://bugs.webkit.org/show_bug.cgi?id=153584
1508
1509         Reviewed by Michael Saboff.
1510
1511         * Scripts/run-jsc-stress-tests:
1512
1513 2016-01-29  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
1514
1515         update-webkit-dependency fails to fetch updates through firewall on Windows
1516         https://bugs.webkit.org/show_bug.cgi?id=153619
1517
1518         Reviewed by Myles C. Maxfield.
1519
1520         On Windows, when a firewall is present we need to read proxy settings
1521         from environment variables.
1522
1523         This patch relies on the following environment variables being set:
1524         HTTP_PROXY
1525         HTTPS_PROXY
1526
1527         * Scripts/update-webkit-dependency:
1528
1529 2016-01-28  Dan Bernstein  <mitz@apple.com>
1530
1531         [Cocoa] Use the non-Development variants of XPC services for development
1532         https://bugs.webkit.org/show_bug.cgi?id=152545
1533
1534         Reviewed by Darin Adler.
1535
1536         * Scripts/webkitdirs.pm:
1537         (setUpGuardMallocIfNeeded): Ensure that libgmalloc is loaded into XPC services as well.
1538
1539         * Scripts/webkitpy/port/driver.py:
1540         (Driver._setup_environ_for_driver): Ensure that the DYLD_LIBRARY_PATH and ASAN_OPTIONS are
1541           set in the XPC services as well.
1542
1543         * Scripts/webkitpy/port/ios.py:
1544         (IOSSimulatorPort.setup_environ_for_server): Ensure that malloc stack logging for leaks and
1545           Guard Malloc are enabled in XPC services as well.
1546
1547         * Scripts/webkitpy/port/mac.py:
1548         (MacPort.setup_environ_for_server): Ditto.
1549
1550 2016-01-28  Csaba Osztrogonác  <ossy@webkit.org>
1551
1552         Unreviewed buildfix after r195743.
1553
1554         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1555         (WTR::AccessibilityUIElement::isPressActionSupported):
1556
1557 2016-01-12  Jer Noble  <jer.noble@apple.com>
1558
1559         Custom protocol loading through AVFoundation does not support byte-range requests.
1560         https://bugs.webkit.org/show_bug.cgi?id=152919
1561         <rdar://problem/23664657>
1562
1563         Reviewed by Alex Christensen.
1564
1565         Add tests for new ParsedContntRange class.
1566
1567         * TestWebKitAPI/PlatformWin.cmake:
1568         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1569         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1570         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1571         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: Added.
1572         (TestWebKitAPI::TEST):
1573
1574 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
1575
1576         Use isAnyWindows() instead of isCygwin() || isWindows() in Perl scripts.
1577         https://bugs.webkit.org/show_bug.cgi?id=153594
1578
1579         Reviewed by Alex Christensen.
1580
1581         * Scripts/webkitdirs.pm:
1582         (determineNumberOfCPUs):
1583         (jscPath):
1584         (checkFrameworks):
1585         (setupCygwinEnv):
1586         (wrapperPrefixIfNeeded):
1587         (cmakeGeneratedBuildfile):
1588         (generateBuildSystemFromCMakeProject):
1589         * Scripts/webkitperl/features.pm:
1590         (libraryContainsSymbol):
1591
1592 2016-01-28  Chris Dumez  <cdumez@apple.com>
1593
1594         Unreviewed, rolling out r195742.
1595
1596         Broke EWS
1597
1598         Reverted changeset:
1599
1600         "[webkitdirs] Clarify logic behind is{PortName} functions."
1601         https://bugs.webkit.org/show_bug.cgi?id=153554
1602         http://trac.webkit.org/changeset/195742
1603
1604 2016-01-28  Darin Adler  <darin@apple.com>
1605
1606         Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
1607         https://bugs.webkit.org/show_bug.cgi?id=153411
1608
1609         Reviewed by Ryosuke Niwa.
1610
1611         * Scripts/do-webcore-rename: Removed rename of equalIgnoringCase since we
1612         have removed the function instead.
1613
1614         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1615         (TestWebKitAPI::TEST): Updated test since nullptr is now ambiguous since we
1616         added overloads for const char*.
1617
1618         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1619         (WTR::AccessibilityUIElement::isPressActionSupported): Use equalLettersIgnoringASCIICase.
1620         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1621         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1622         (WTR::testPathFromURL): Ditto.
1623
1624 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
1625
1626         [webkitdirs] Clarify logic behind is{PortName} functions.
1627         https://bugs.webkit.org/show_bug.cgi?id=153554
1628
1629         Reviewed by Darin Adler.
1630
1631         * Scripts/webkitdirs.pm:
1632         (determinePortName): Added new function which decides which port are
1633         we building based on command line switches and platform defaults.
1634         (portName): Added getter for determined $portName.
1635         (isEfl): Modified to use portName().
1636         (isGtk): Ditto.
1637         (isWinCairo): Ditto.
1638         (isAppleMacWebKit): Ditto.
1639         (isAppleWinWebKit): Ditto.
1640         (isIOSWebKit): Ditto.
1641         (cmakeBasedPortName): Code replaced with portName() call.
1642         (determineIsEfl): Deleted.
1643         (determineIsGtk): Deleted.
1644         (determineIsWinCairo): Deleted.
1645
1646 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
1647
1648         [webkitdirs] Don't pass cmakeBasedPortName around.
1649         https://bugs.webkit.org/show_bug.cgi?id=153589
1650
1651         Reviewed by Darin Adler.
1652
1653         It should be local function of webkitdirs.pm instead.
1654
1655         * Scripts/build-jsc: Don't pass cmakeBasedPortName to
1656         buildCMakeProjectOrExit().
1657         * Scripts/build-webkit: Don't pass cmakeBasedPortName to
1658         buildCMakeProjectOrExit() and generateBuildSystemFromCMakeProject().
1659         * Scripts/run-efl-tests: Don't pass cmakeBasedPortName to
1660         generateBuildSystemFromCMakeProject().
1661         * Scripts/webkitdirs.pm: Don't export cmakeBasedPortName.
1662         (generateBuildSystemFromCMakeProject): Removed $port argument as we
1663         can get it from cmakeBasedPortName().
1664         (buildCMakeProjectOrExit): Ditto.
1665
1666 2016-01-28  Gwang Yoon Hwang  <yoon@igalia.com>
1667
1668         [GStreamer] Clean up includes and headers related with GStreamerGL
1669         https://bugs.webkit.org/show_bug.cgi?id=153590
1670
1671         Reviewed by Philippe Normand.
1672
1673         * Scripts/webkitpy/style/checker.py: Skips
1674         include_order check for MediaPlayerPrivateGStreamerBase.cpp
1675         Removes VideoSinkGStreamer1.cpp which doesn't exist anymore.
1676
1677 2016-01-27  Krzysztof Czech  <k.czech@samsung.com>
1678
1679         [EFL] Remove unused accessibility related code
1680         https://bugs.webkit.org/show_bug.cgi?id=153543
1681
1682         Reviewed by Darin Adler.
1683
1684         Removed reference to EAIL library.
1685         It not going to be support anymore. There have been changes in
1686         EFL/Elementary in terms of the accessibility and we should
1687         follow those.
1688
1689         * efl/jhbuild-optional.modules:
1690
1691 2016-01-27  Daniel Bates  <dabates@apple.com>
1692
1693         Remove WebKitSystemInterface for iOS SDK < 9
1694         https://bugs.webkit.org/show_bug.cgi?id=153570
1695
1696         Reviewed by Andy Estes.
1697
1698         * Scripts/copy-webkitlibraries-to-product-directory:
1699
1700 2016-01-27  Jason Marcell  <jmarcell@apple.com>
1701
1702         Fix bugs caused by incorrect usage of "branch" vs. "branchName".
1703         https://bugs.webkit.org/show_bug.cgi?id=153330
1704
1705         Reviewed by Daniel Bates.
1706
1707         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
1708         "branchName" implies that the variable or property in question is simply a string. We fixed some
1709         inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
1710         spotted in BuildbotQueueView.js.
1711
1712         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1713         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
1714         Changed branchName to branch.name in call to commitsOnBranch.
1715         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
1716         _popoverLinesForCommitRange.
1717         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
1718         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
1719         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
1720         fix.
1721
1722 2016-01-27  Ryosuke Niwa  <rniwa@webkit.org>
1723
1724         Add API to access closed shadowRoot in InjectedBundle
1725         https://bugs.webkit.org/show_bug.cgi?id=153533
1726
1727         Reviewed by Antti Koivisto.
1728
1729         Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
1730
1731         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1732         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
1733         (TestWebKitAPI::runJavaScriptAlert):
1734         (TestWebKitAPI::TEST):
1735         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
1736         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
1737         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
1738
1739 2016-01-27  Jason Marcell  <jmarcell@apple.com>
1740
1741         Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
1742         https://bugs.webkit.org/show_bug.cgi?id=153332
1743
1744         Reviewed by Alexey Proskuryakov.
1745
1746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1747         (Trac.prototype._xmlTimelineURL): Uses new function.
1748         (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
1749         logic for parsing git hashes.
1750         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
1751         Trac._parseRevisionFromURL.
1752
1753 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
1754
1755         Remove Mavericks from the flakiness dashboard
1756         https://bugs.webkit.org/show_bug.cgi?id=153521
1757
1758         Reviewed by Dan Bernstein.
1759
1760         * TestResultServer/static-dashboards/builders.jsonp:
1761         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1762
1763 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
1764
1765         Remove ENABLE_CURRENTSRC
1766         https://bugs.webkit.org/show_bug.cgi?id=153545
1767
1768         Reviewed by Simon Fraser.
1769
1770         * Scripts/webkitperl/FeatureList.pm:
1771
1772 2016-01-26  Jason Marcell  <jmarcell@apple.com>
1773
1774         Sort incoming commits via date instead of revision number.
1775         https://bugs.webkit.org/show_bug.cgi?id=153467
1776
1777         Reviewed by Alexey Proskuryakov.
1778
1779         Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
1780         for sorting revisions. Instead we use the commit date to sort revisions chronologically.
1781
1782         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1783         (Trac.prototype._loaded): Sort via date instead of revision number.
1784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
1785         (MockTrac): Fix up the mock data to look more like real-world data.
1786         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
1787         Fake RSS feed that adds three more commits.
1788         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
1789         Trac._loaded().
1790
1791 2016-01-26  I-Ting Liu  <iting_liu@apple.com>
1792
1793         Add a test for WebKit::stringMatchesWildcardString.
1794         https://bugs.webkit.org/show_bug.cgi?id=153090
1795
1796         Reviewed by Darin Adler.
1797
1798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1799         Add the file to the project.
1800
1801         * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
1802         (TestWebKitAPI::TEST):
1803         Test that a string matches another string that may contain wildcard characters.
1804
1805 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
1806
1807         [webkitdirs] Removed check for bison, gperf, and flex.
1808         https://bugs.webkit.org/show_bug.cgi?id=153496
1809
1810         Reviewed by Alex Christensen.
1811
1812         This prerequisites are checked in WebKitCommon.cmake and don't
1813         have to be in $PATH.
1814
1815         * Scripts/webkitdirs.pm:
1816         (checkRequiredSystemConfig):
1817
1818 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
1819
1820         [webkitdirs] isCMakeBuild should be true by default
1821         https://bugs.webkit.org/show_bug.cgi?id=153497
1822
1823         Reviewed by Michael Catanzaro.
1824
1825         * Scripts/webkitdirs.pm:
1826         (isCMakeBuild):
1827
1828 2016-01-26  Daniel Bates  <dabates@apple.com>
1829
1830         Add WebKitSystemInterface for iOS 9.2
1831         https://bugs.webkit.org/show_bug.cgi?id=153355
1832
1833         Rubber-stamped by David Kilzer.
1834
1835         * Scripts/copy-webkitlibraries-to-product-directory:
1836
1837 2016-01-26  Daniel Bates  <dabates@apple.com>
1838
1839         WebKitTestRunner: Credential cache is not cleared between tests
1840         https://bugs.webkit.org/show_bug.cgi?id=153407
1841         <rdar://problem/24280834>
1842
1843         Reviewed by Alexey Proskuryakov.
1844
1845         * WebKitTestRunner/TestController.cpp:
1846         (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
1847         to clear cached credentials.
1848
1849 2016-01-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1850
1851         kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
1852         https://bugs.webkit.org/show_bug.cgi?id=153483
1853
1854         Reviewed by Csaba Osztrogonác.
1855
1856         * BuildSlaveSupport/kill-old-processes:
1857         (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
1858
1859 2016-01-25  Simon Fraser  <simon.fraser@apple.com>
1860
1861         Give the layout test results file a <title> showing the date and time the tests were run
1862         https://bugs.webkit.org/show_bug.cgi?id=153187
1863
1864         Reviewed by Darin Adler.
1865         
1866         Include a 'date' property in the JSON with the date and time the tests completed.
1867
1868         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1869         (summarize_results):
1870
1871 2016-01-25  Commit Queue  <commit-queue@webkit.org>
1872
1873         Unreviewed, rolling out r195543.
1874         https://bugs.webkit.org/show_bug.cgi?id=153451
1875
1876         regressed performance of test bots by ~6% (Requested by dydz
1877         on #webkit).
1878
1879         Reverted changeset:
1880
1881         "WebKitTestRunner: Credential cache is not cleared between
1882         tests"
1883         https://bugs.webkit.org/show_bug.cgi?id=153407
1884         http://trac.webkit.org/changeset/195543
1885
1886 2016-01-25  Aakash Jain  <aakash_jain@apple.com>
1887
1888         Failing to upload to flakiness dashboard should not be a hard error
1889         https://bugs.webkit.org/show_bug.cgi?id=153444
1890         <rdar://problem/22146294>
1891
1892         Reviewed by Alexey Proskuryakov.
1893
1894         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1895         (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
1896
1897 2016-01-25  Daniel Bates  <dabates@apple.com>
1898
1899         WebKitTestRunner: Credential cache is not cleared between tests
1900         https://bugs.webkit.org/show_bug.cgi?id=153407
1901         <rdar://problem/24280834>
1902
1903         Reviewed by Brady Eidson.
1904
1905         * WebKitTestRunner/TestController.cpp:
1906         (WTR::TestController::resetStateToConsistentValues): Reset testing network session
1907         to clear cached credentials.
1908
1909 2016-01-24  Dan Bernstein  <mitz@apple.com>
1910
1911         Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
1912
1913         * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
1914
1915 2016-01-22  Enrica Casucci  <enrica@apple.com>
1916
1917         Unreviewed build fix after http://trac.webkit.org/changeset/195474.
1918
1919         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1920         (WTR::TestController::platformCreateWebView):
1921
1922 2016-01-22  Tim Horton  <timothy_horton@apple.com>
1923
1924         Add a test for iOS arrow-key repeat
1925         https://bugs.webkit.org/show_bug.cgi?id=152857
1926         <rdar://problem/24017380>
1927
1928         Reviewed by Darin Adler.
1929
1930         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1931         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1932         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
1933         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
1934         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1935         * WebKitTestRunner/ios/HIDEventGenerator.h:
1936         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1937         (-[HIDEventGenerator keyPress:completionBlock:]):
1938         (-[HIDEventGenerator keyDown:completionBlock:]):
1939         (-[HIDEventGenerator keyUp:completionBlock:]):
1940         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1941         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1942         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
1943         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
1944         Make it possible to independently send keyUp/keyDown, instead of just paired.
1945
1946 2016-01-22  Tim Horton  <timothy_horton@apple.com>
1947
1948         Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
1949         https://bugs.webkit.org/show_bug.cgi?id=153193
1950         <rdar://problem/24222034>
1951
1952         Reviewed by Darin Adler.
1953
1954         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1955         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
1956         (TEST):
1957         Add a test that exhibits the problems we're fixing here.
1958         Before, it would both log and assert in debug, and crash in release.
1959         Now it runs happily to completion.
1960
1961 2016-01-22  Enrica Casucci  <enrica@apple.com>
1962
1963         Add support for testing data detection.
1964         https://bugs.webkit.org/show_bug.cgi?id=153360
1965
1966         Reviewed by Tim Horton.
1967
1968         Adding a new testing option (useDataDetection) to turn on
1969         data detection when running the a test.
1970
1971         * WebKitTestRunner/TestController.cpp:
1972         (WTR::updateTestOptionsFromTestHeader):
1973         * WebKitTestRunner/TestOptions.h:
1974         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1975         (WTR::TestController::platformCreateWebView):
1976
1977 2016-01-21  Simon Fraser  <simon.fraser@apple.com>
1978
1979         Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
1980         https://bugs.webkit.org/show_bug.cgi?id=153334
1981
1982         Reviewed by Zalan Bujtas.
1983         
1984         Evaluating expressions in the LayoutUnit summary provider seems to cause
1985         re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
1986         denominator to 64.
1987
1988         * lldb/lldb_webkit.py:
1989         (WebCoreLayoutUnitProvider.to_string):
1990
1991 2016-01-21  Filip Pizlo  <fpizlo@apple.com>
1992
1993         display-profiler-output should be able to display code blocks sorted by machine counts
1994         https://bugs.webkit.org/show_bug.cgi?id=153298
1995
1996         Reviewed by Oliver Hunt.
1997
1998         * Scripts/display-profiler-output:
1999
2000 2016-01-21  Julien Isorce  <j.isorce@samsung.com>
2001
2002         Ensure to use compatible liborc version with wanted gstreamer version
2003         https://bugs.webkit.org/show_bug.cgi?id=153276
2004
2005         For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
2006         The user may have a very recent liborc installed on his system.
2007
2008         Reviewed by Philippe Normand.
2009
2010         * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
2011         * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
2012
2013 2016-01-21  Nan Wang  <n_wang@apple.com>
2014
2015         AX: [IOS] Implement next/previous text marker functions using TextIterator
2016         https://bugs.webkit.org/show_bug.cgi?id=153292
2017         <rdar://problem/24268243>
2018
2019         Reviewed by Chris Fleizach.
2020
2021         Made text marker tests available on iOS.
2022
2023         * DumpRenderTree/AccessibilityTextMarker.h:
2024         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2025         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
2026         (AccessibilityTextMarker::AccessibilityTextMarker):
2027         (AccessibilityTextMarker::~AccessibilityTextMarker):
2028         (AccessibilityTextMarker::isEqual):
2029         (AccessibilityTextMarker::platformTextMarker):
2030         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2031         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2032         (AccessibilityTextMarkerRange::isEqual):
2033         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2034         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2035         (AccessibilityUIElement::pathDescription):
2036         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2037         (AccessibilityUIElement::textMarkerRangeForElement):
2038         (AccessibilityUIElement::selectedTextMarkerRange):
2039         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2040         (AccessibilityUIElement::textMarkerRangeLength):
2041         (AccessibilityUIElement::textMarkerRangeForMarkers):
2042         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2043         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2044         (AccessibilityUIElement::accessibilityElementForTextMarker):
2045         (AccessibilityUIElement::endTextMarkerForBounds):
2046         (AccessibilityUIElement::startTextMarkerForBounds):
2047         (AccessibilityUIElement::textMarkerForPoint):
2048         (AccessibilityUIElement::previousTextMarker):
2049         (AccessibilityUIElement::nextTextMarker):
2050         (AccessibilityUIElement::stringForTextMarkerRange):
2051         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2052         (AccessibilityUIElement::indexForTextMarker):
2053         (AccessibilityUIElement::isTextMarkerValid):
2054         (AccessibilityUIElement::textMarkerForIndex):
2055         (AccessibilityUIElement::startTextMarker):
2056         (AccessibilityUIElement::endTextMarker):
2057         (AccessibilityUIElement::setSelectedVisibleTextRange):
2058         (AccessibilityUIElement::getLinkedUIElements):
2059         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2060         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2061         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2062         (AccessibilityUIElement::removeSelection):
2063         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2064         (AccessibilityUIElement::setSelectedVisibleTextRange):
2065         (AccessibilityUIElement::supportedActions):
2066         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2067         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2068         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2069         (WTR::AccessibilityUIElement::previousTextMarker):
2070         (WTR::AccessibilityUIElement::nextTextMarker):
2071         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2072         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2073         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2074         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2075         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2076         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2077         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2078
2079 2016-01-20  Filip Pizlo  <fpizlo@apple.com>
2080
2081         Unreviewed, revert accidental unreviewed commit.
2082
2083         * Scripts/display-profiler-output:
2084
2085 2016-01-20  Jason Marcell  <jmarcell@apple.com>
2086
2087         Refactor compareIterations to remove duplicate code.
2088         https://bugs.webkit.org/show_bug.cgi?id=152913
2089
2090         Reviewed by Daniel Bates.
2091
2092         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2093         (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
2094         (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
2095         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
2096         the same behavior before and after refactor.
2097
2098 2016-01-20  Dana Burkart  <dburkart@apple.com>
2099
2100         Botwatcher's dashboard should show an 'X' when the build is broken
2101         https://bugs.webkit.org/show_bug.cgi?id=152507
2102
2103         Reviewed by David Kilzer.
2104
2105         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2106         (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
2107         (BuildbotStaticAnalyzerQueueView.prototype.update):
2108
2109 2016-01-19  Jason Marcell  <jmarcell@apple.com>
2110
2111         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
2112         https://bugs.webkit.org/show_bug.cgi?id=153262
2113
2114         Reviewed by Alexey Proskuryakov.
2115
2116         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
2117         such cases this revisionContentForIteration method does not have any content to return, thus the
2118         assertion fails.
2119
2120         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2121         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
2122
2123 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2124
2125         [GTK] Runtime critical warnings when loading a URL after a session restore
2126         https://bugs.webkit.org/show_bug.cgi?id=153233
2127
2128         Reviewed by Michael Catanzaro.
2129
2130         Add new test case.
2131
2132         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
2133         (viewLoadChanged):
2134         (testWebKitWebViewNavigationAfterSessionRestore):
2135         (beforeAll):
2136
2137 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2138
2139         [GTK] Remove jhbuild-optional.modules
2140         https://bugs.webkit.org/show_bug.cgi?id=152964
2141
2142         Reviewed by Alex Christensen.
2143
2144         * gtk/jhbuild-optional.modules: Removed.
2145         * gtk/jhbuild.modules:
2146
2147 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2148
2149         [GTK] Add support to load/save session in MiniBrowser
2150         https://bugs.webkit.org/show_bug.cgi?id=153201
2151
2152         Reviewed by Michael Catanzaro.
2153
2154         It makes it easier to test the new WebView session API.
2155
2156         * MiniBrowser/gtk/BrowserWindow.c:
2157         (browserWindowFinalize): Free the session file path.
2158         (browserWindowSaveSession): Save the current WebView session if
2159         there's a session file path.
2160         (browserWindowDeleteEvent): Call browserWindowSaveSession().
2161         (browser_window_load_session): Try to load the session from the
2162         given file path, otherwise fall back to homepage and keep the
2163         session file to save the session on window close.
2164         * MiniBrowser/gtk/BrowserWindow.h:
2165         * MiniBrowser/gtk/main.c:
2166         (createBrowserWindow): Pass the given session file path when
2167         shouldLoadSession is TRUE.
2168         (main): Only allow to restore/save session when MiniBrowser is
2169         launched without URL arguments.
2170
2171 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2172
2173         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
2174
2175         Geolocation is no longer allowed for unique origins after r195075.
2176
2177         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2178         (testWebViewGeolocationPermissionRequests):
2179
2180 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2181
2182         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
2183         https://bugs.webkit.org/show_bug.cgi?id=153216
2184
2185         Reviewed by Michael Catanzaro.
2186
2187         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
2188         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
2189
2190 2016-01-18  Nan Wang  <n_wang@apple.com>
2191
2192         AX: [Mac] Implement next/previous text marker functions using TextIterator
2193         https://bugs.webkit.org/show_bug.cgi?id=152728
2194
2195         Reviewed by Chris Fleizach.
2196
2197         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2198         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2199
2200 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
2201
2202         [cmake] Add testair to the build system
2203         https://bugs.webkit.org/show_bug.cgi?id=153126
2204
2205         Reviewed by Michael Catanzaro.
2206
2207         * Scripts/build-jsc:
2208
2209 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
2210
2211         Remove TextRun::allowsRoundingHacks()
2212         https://bugs.webkit.org/show_bug.cgi?id=153185
2213
2214         Reviewed by Simon Fraser.
2215
2216         * DumpRenderTree/mac/DumpRenderTree.mm:
2217         (resetWebViewToConsistentStateBeforeTesting): Deleted.
2218
2219 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
2220
2221         [webkitdirs] Avoid list form of open because it broke WinCairo
2222         https://bugs.webkit.org/show_bug.cgi?id=153106
2223
2224         Reviewed by Alex Christensen.
2225
2226         * Scripts/webkitdirs.pm:
2227         (determineArchitecture):
2228
2229 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
2230
2231         Add kdebug_trace signposts for a few WebCore operations
2232         https://bugs.webkit.org/show_bug.cgi?id=153136
2233         rdar://problem/24208487
2234
2235         Reviewed by Sam Weinig.
2236         
2237         Plist used by kdebug_trace() viewing tools.
2238
2239         * Tracing/SystemTracePoints.plist: Added.
2240
2241 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
2242
2243         [webkitdirs] Replaced grep invocation with perl code
2244         https://bugs.webkit.org/show_bug.cgi?id=153106
2245
2246         Reviewed by Alex Christensen.
2247
2248         * Scripts/webkitdirs.pm:
2249         (determineArchitecture):
2250
2251 2016-01-14  Brian Burg  <bburg@apple.com>
2252
2253         prepare-changelog does not read paths containing spaces properly
2254         https://bugs.webkit.org/show_bug.cgi?id=137982
2255
2256         Reviewed by Joseph Pecoraro.
2257
2258         Escape whitespace in filenames before passing the file path to other functions.
2259
2260         * Scripts/prepare-ChangeLog:
2261         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
2262
2263 2016-01-14  Jason Marcell  <jmarcell@apple.com>
2264
2265         Standardize the usage of "branch" vs. "branchName".
2266         https://bugs.webkit.org/show_bug.cgi?id=152982
2267
2268         Reviewed by Daniel Bates.
2269
2270         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
2271         "branchName" implies that the variable or property in question is simply a string.
2272
2273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2274         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
2275         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
2276         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
2277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2278         (Trac.prototype.commitsOnBranch): Change branch to branchName.
2279         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
2280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
2281         (MockTrac): Ditto.
2282
2283 2016-01-14  Jason Marcell  <jmarcell@apple.com>
2284
2285         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
2286         https://bugs.webkit.org/show_bug.cgi?id=152910
2287
2288         Reviewed by Daniel Bates.
2289
2290         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
2291         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
2292         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
2293         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
2294         the need to talk to a real Buildbot server.
2295         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
2296         without the need to talk to a real Buildbot server.
2297         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
2298         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
2299         server.
2300         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
2301         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
2302         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
2303         trying to talk to Trac.
2304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
2305         QUnit unit tests.
2306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
2307
2308 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
2309
2310         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
2311         https://bugs.webkit.org/show_bug.cgi?id=132599
2312
2313         Reviewed by Michael Catanzaro.
2314
2315         Check if cmake Ninja generators are installed.
2316
2317         * Scripts/webkitdirs.pm:
2318         (canUseNinjaGenerator):
2319         (canUseEclipseNinjaGenerator):
2320         (generateBuildSystemFromCMakeProject):
2321         (canUseEclipse): Deleted.
2322
2323 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
2324
2325         [Cocoa] Testing with font family name "System Font" is unused
2326         https://bugs.webkit.org/show_bug.cgi?id=153073
2327         <rdar://problem/24091683>
2328
2329         Reviewed by Brent Fulgham.
2330
2331         * DumpRenderTree/mac/DumpRenderTree.mm:
2332         (allowedFontFamilySet): Deleted.
2333         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2334         (WTR::allowedFontFamilySet): Deleted.
2335         * WebKitTestRunner/mac/TestControllerMac.mm:
2336         (WTR::allowedFontFamilySet): Deleted.
2337
2338 2016-01-13  Daniel Bates  <dabates@apple.com>
2339
2340         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
2341         https://bugs.webkit.org/show_bug.cgi?id=152871
2342
2343         Reviewed by Brent Fulgham.
2344
2345         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
2346         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
2347
2348         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
2349
2350 2016-01-08  Andy Estes  <aestes@apple.com>
2351
2352         [Content Filtering] Lazily load platform frameworks
2353         https://bugs.webkit.org/show_bug.cgi?id=152881
2354         rdar://problem/23270886
2355
2356         Reviewed by Brady Eidson.
2357
2358         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
2359         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
2360         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
2361         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
2362         is loaded after an HTTPS request.
2363
2364         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
2365         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
2366         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
2367         also re-enabled on iOS after mistakenly being disabled by r188892.
2368
2369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2370         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2371         (TestWebKitAPI::TEST):
2372         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
2373         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
2374         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2375         (TEST):
2376         (downloadTest):
2377         (-[LazilyLoadPlatformFrameworksController init]):
2378         (-[LazilyLoadPlatformFrameworksController webView]):
2379         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
2380         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
2381         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2382         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2383         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
2384         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
2385         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2386         (TestWebKitAPI::TEST):
2387         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2388         (TestWebKitAPI::TEST): Deleted.
2389         * TestWebKitAPI/cocoa/TestProtocol.h:
2390         * TestWebKitAPI/cocoa/TestProtocol.mm:
2391         (+[TestProtocol registerWithScheme:]):
2392         (+[TestProtocol unregister]):
2393
2394 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
2395
2396         Fix the Sunpider converage in slow device.
2397         https://bugs.webkit.org/show_bug.cgi?id=152938
2398         <rdar://problem/22511411>
2399
2400         Reviewed by Ryosuke Niwa.
2401
2402         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
2403
2404         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
2405
2406 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
2407
2408         Add a build flag for custom element
2409         https://bugs.webkit.org/show_bug.cgi?id=153005
2410
2411         Reviewed by Alex Christensen.
2412
2413         Added --custom-elements option to enable custom elements support.
2414
2415         * Scripts/webkitperl/FeatureList.pm:
2416
2417 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
2418
2419         [JSC] Add a help message when run-jsc-stress-tests fails
2420         https://bugs.webkit.org/show_bug.cgi?id=153014
2421
2422         Reviewed by Csaba Osztrogonác.
2423
2424         * Scripts/run-jsc-stress-tests:
2425
2426 2016-01-11  Saam barati  <sbarati@apple.com>
2427
2428         run-jsc-stress-tests should try to figure out a JSC path
2429         https://bugs.webkit.org/show_bug.cgi?id=152971
2430
2431         Reviewed by Yusuke Suzuki.
2432
2433         This patch now allows run-jsc-stress-tests to be run
2434         without a "--jsc <jsc-path>" argument. It tries
2435         to take its best guess at a <jsc-path> automagically.
2436         
2437         This makes it much easier to just run run-jsc-stress-tests
2438         with a directory or a yaml file as an argument.
2439         You now just do this:
2440         `run-jsc-stress-tests <path-to-yaml>`
2441         or
2442         `run-jsc-stress-tests <path-to-directory-of-js-files>`
2443         
2444         I wrote this patch because I'd often find myself hacking the 
2445         run-javascriptcore-tests file just to run a particular subset of tests.
2446         Because I always forget the arguments to run-jsc-stress-tests (which means
2447         I always forgot to provide a --jsc argument), I always found it easier to 
2448         just hack on that file instead of calling run-jsc-stress-tests directly.
2449         No longer is this true!
2450
2451         * Scripts/run-jsc-stress-tests:
2452
2453 2016-01-09  Andy Estes  <aestes@apple.com>
2454
2455         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
2456         https://bugs.webkit.org/show_bug.cgi?id=152950
2457         rdar://problem/24066652
2458
2459         Reviewed by Tim Horton.
2460
2461         Added an API test.
2462
2463         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2464         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
2465         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
2466         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
2467         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
2468         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
2469         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
2470         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
2471         (TEST):
2472
2473 2016-01-11  Commit Queue  <commit-queue@webkit.org>
2474
2475         Unreviewed, rolling out r194866.
2476         https://bugs.webkit.org/show_bug.cgi?id=152986
2477
2478         This change broke the mac build (Requested by ryanhaddad on
2479         #webkit).
2480
2481         Reverted changeset:
2482
2483         "[Cocoa] Add SPI to opt out a URL scheme from the memory
2484         cache"
2485         https://bugs.webkit.org/show_bug.cgi?id=152950
2486         http://trac.webkit.org/changeset/194866
2487
2488 2016-01-11  Andy Estes  <aestes@apple.com>
2489
2490         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
2491         https://bugs.webkit.org/show_bug.cgi?id=152950
2492         rdar://problem/24066652
2493
2494         Reviewed by Tim Horton.
2495
2496         Added an API test.
2497
2498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2499         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
2500         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
2501         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
2502         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
2503         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
2504         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
2505         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
2506         (TEST):
2507
2508 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
2509
2510         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
2511         https://bugs.webkit.org/show_bug.cgi?id=152959
2512
2513         Reviewed by Brent Fulgham.
2514
2515         * Scripts/webkitdirs.pm:
2516         (determineArchitecture):
2517
2518 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2519
2520         [GTK] W3C CSS2.1 anonymous table tests are failing
2521         https://bugs.webkit.org/show_bug.cgi?id=152455
2522
2523         Reviewed by Mario Sanchez Prada.
2524
2525         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
2526         tests. Add upstream patches to fix detection of XHTML files.
2527
2528         * gtk/jhbuild.modules:
2529         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
2530         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
2531
2532 2016-01-10  Saam barati  <sbarati@apple.com>
2533
2534         Implement a sampling profiler
2535         https://bugs.webkit.org/show_bug.cgi?id=151713
2536
2537         Reviewed by Filip Pizlo.
2538
2539         * Scripts/run-jsc-stress-tests:
2540
2541 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
2542
2543         [webkitdirs] Try arch and uname commands on non-windows OS
2544         https://bugs.webkit.org/show_bug.cgi?id=152958
2545
2546         Reviewed by Michael Catanzaro.
2547
2548         Right now, determineArchitecture()  uses `arch` and `uname -m`
2549         commands to determine architecture in case of condition (isGtk() ||
2550         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
2551         instead, because this code is applicable to any non-windows OS WebKit
2552         supports (even Haiku which once was supported is moderately
2553         POSIX-compliant and has uname command).
2554
2555         * Scripts/webkitdirs.pm:
2556         (determineArchitecture):
2557
2558 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
2559
2560         run-webkit-tests mis-counts totals when there are other crashes
2561         https://bugs.webkit.org/show_bug.cgi?id=152894
2562         <rdar://problem/24098697>
2563
2564         Reviewed by Alexey Proskuryakov.
2565
2566         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2567         (TestRunResults.add): Do not update result counters for other crashes.
2568
2569 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2570
2571         webkit-patch build-and-test should have an option to iterate over new tests
2572         https://bugs.webkit.org/show_bug.cgi?id=143093
2573
2574         Reviewed by Michael Catanzaro.
2575
2576         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
2577         It allows running run-webkit-tests on modified or new paths in LayoutTests.
2578         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
2579         It implements the translation of -expected.* paths to their related tests.
2580         It also implements the removal of skipped tests.
2581
2582         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2583         (LayoutTestFinder.find_touched_tests):
2584         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
2585         (MockPort):
2586         (MockPort.__init__):
2587         (MockPort.tests):
2588         (LayoutTestFinderTests):
2589         (LayoutTestFinderTests.touched_files):
2590         (LayoutTestFinderTests.test_touched_test):
2591         (LayoutTestFinderTests.test_expected_touched_test):
2592         (LayoutTestFinderTests.test_platform_expected_touched_test):
2593         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
2594         (LayoutTestFinderTests.test_touched_but_skipped_test):
2595         * Scripts/webkitpy/port/base.py:
2596         (Port.potential_test_names_from_expected_file):
2597         * Scripts/webkitpy/tool/commands/download_unittest.py:
2598         (DownloadCommandsTest._default_options):
2599         * Scripts/webkitpy/tool/steps/options.py:
2600         (Options):
2601         * Scripts/webkitpy/tool/steps/runtests.py:
2602         (RunTests.options):
2603         (RunTests.run):
2604         (RunTests):
2605         (RunTests._new_or_modified_tests):
2606         (RunTests._run_webkit_tests):
2607         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2608         (RunTestsTest.test_webkit_run_unit_tests):
2609         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2610         (StepsTest._step_options):
2611
2612 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
2613
2614         prepare-ChangeLog should include radar number
2615         https://bugs.webkit.org/show_bug.cgi?id=152839
2616         <rdar://problem/24093563>
2617
2618         Reviewed by Daniel Bates.
2619
2620         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
2621         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
2622         in the ChangeLog description after the bug URL.
2623
2624         * Scripts/prepare-ChangeLog:
2625         (main): Update signatures.
2626         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
2627         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
2628         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
2629         (generateNewChangeLogs): Include radar URL if we found one.
2630
2631         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
2632         Tests for the radar URL extraction.
2633
2634 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
2635
2636         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
2637         https://bugs.webkit.org/show_bug.cgi?id=152390
2638         <rdar://problem/23948321>
2639
2640         Reviewed by Simon Fraser.
2641
2642         Fix two use-after-frees.
2643
2644         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
2645         but we may have already progressed to another test by the time the callback fires,
2646         having destroyed the TestInvocation.
2647         2. UIScriptController is a RefCounted object, but it has a raw pointer to
2648         UIScriptContext which has the same lifetime as a TestInvocation.
2649         As a result, completion blocks of UIScriptController actions would use a destroyed
2650         TestInvocation.
2651
2652         * WebKitTestRunner/TestInvocation.cpp:
2653         (WTR::TestInvocation::~TestInvocation):
2654         (WTR::TestInvocation::url):
2655         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2656         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
2657         (WTR::TestInvocation::runUISideScript):
2658         * WebKitTestRunner/TestInvocation.h:
2659         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
2660         (UIScriptContext::UIScriptContext):
2661         (UIScriptContext::~UIScriptContext):
2662         (UIScriptContext::runUIScript):
2663         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
2664         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2665         (WTR::UIScriptController::UIScriptController):
2666         (WTR::UIScriptController::contextDestroyed):
2667         (WTR::UIScriptController::makeWindowObject):
2668         (WTR::UIScriptController::setWillBeginZoomingCallback):
2669         (WTR::UIScriptController::willBeginZoomingCallback):
2670         (WTR::UIScriptController::setDidEndZoomingCallback):
2671         (WTR::UIScriptController::didEndZoomingCallback):
2672         (WTR::UIScriptController::setDidEndScrollingCallback):
2673         (WTR::UIScriptController::didEndScrollingCallback):
2674         (WTR::UIScriptController::setDidShowKeyboardCallback):
2675         (WTR::UIScriptController::didShowKeyboardCallback):
2676         (WTR::UIScriptController::setDidHideKeyboardCallback):
2677         (WTR::UIScriptController::didHideKeyboardCallback):
2678         (WTR::UIScriptController::uiScriptComplete):
2679         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2680         (WTR::UIScriptController::create):
2681         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2682         (WTR::UIScriptController::doAsyncTask):
2683         (WTR::UIScriptController::zoomToScale):
2684         (WTR::UIScriptController::singleTapAtPoint):
2685         (WTR::UIScriptController::doubleTapAtPoint):
2686         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
2687         (WTR::UIScriptController::contentVisibleRect):
2688         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2689         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2690         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
2691         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
2692         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
2693         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2694         (WTR::UIScriptController::doAsyncTask):
2695
2696 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2697
2698         [buildbot] clean-build script should remove untracked files and revert local changes too
2699         https://bugs.webkit.org/show_bug.cgi?id=142400
2700
2701         Reviewed by Ryosuke Niwa.
2702
2703         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
2704         A helper routine SCM.discard_untracked_files is added for that purpose.
2705
2706         * BuildSlaveSupport/clean-build:
2707         (main): Making call to Scripts/clean-webkit
2708         * Scripts/clean-webkit: Added.
2709         (main): Revert changes and delete untracked files.
2710         * Scripts/webkitpy/common/checkout/scm/scm.py:
2711         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
2712         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2713         (SCMTest._shared_test_discard_untracked_files):
2714         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
2715
2716 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
2717
2718         Add a setting and preferences to enable display-list drawing. Does nothing yet.
2719         https://bugs.webkit.org/show_bug.cgi?id=152807
2720
2721         Reviewed by Zalan Bujtas.
2722         
2723         Add an item to the Settings menu to toggle display-list drawing.
2724
2725         * MiniBrowser/mac/SettingsController.h:
2726         * MiniBrowser/mac/SettingsController.m:
2727         (-[SettingsController _populateMenu]):
2728         (-[SettingsController validateMenuItem:]):
2729         (-[SettingsController toggleDisplayListDrawingEnabled:]):
2730         (-[SettingsController displayListDrawingEnabled]):
2731         * MiniBrowser/mac/WK2BrowserWindowController.m:
2732         (-[WK2BrowserWindowController didChangeSettings]):
2733
2734 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2735
2736         Python SCM should be able to retrieve untracked files - Add GIT support
2737         https://bugs.webkit.org/show_bug.cgi?id=143135
2738
2739         Reviewed by Michael Catanzaro.
2740
2741         * Scripts/webkitpy/common/checkout/scm/git.py:
2742         (Git.untracked_files): Adding support for git.
2743         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2744         (GitTest.setUp):
2745         (GitTest.test_untracked_files): Adding test.
2746
2747 2016-01-05  Mark Lam  <mark.lam@apple.com>
2748
2749         Rename badly named JSC_timeout env var to JSCTEST_timeout.
2750         https://bugs.webkit.org/show_bug.cgi?id=152748
2751
2752         Reviewed by Geoffrey Garen.
2753
2754         Now that we validate JSC options, the badly named JSC_timeout env var causes the
2755         bots to have a bad time.
2756
2757         * Scripts/run-javascriptcore-tests:
2758         * Scripts/run-jsc-stress-tests:
2759
2760 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2761
2762         [GTK] Allow to save and restore session
2763         https://bugs.webkit.org/show_bug.cgi?id=115600
2764
2765         Reviewed by Michael Catanzaro.
2766
2767         Add test case to check the new session API.
2768
2769         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
2770         (testWebKitWebViewSessionState):
2771         (testWebKitWebViewSessionStateWithFormData):
2772         (beforeAll):
2773
2774 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
2775
2776         [EFL] Bump EFL version to 1.16.1
2777         https://bugs.webkit.org/show_bug.cgi?id=152688
2778
2779         Reviewed by Gyuyoung Kim.
2780
2781         * efl/jhbuild.modules:
2782
2783 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
2784
2785         error running layout tests on iOS simulator on latest build
2786         https://bugs.webkit.org/show_bug.cgi?id=152719
2787         <rdar://problem/24009549>
2788
2789         Reviewed by Alexey Proskuryakov.
2790
2791         * Scripts/webkitpy/xcode/simulator.py:
2792         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
2793           before running simctl spawn command.
2794
2795 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2796
2797         Unreviewed, move Frédéric Wang to committers list
2798
2799         He seems to be on the contributors list by accident. He has been landing his own commits for
2800         about two years now.
2801
2802         * Scripts/webkitpy/common/config/contributors.json:
2803
2804 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2805
2806         Unreviewed, move Sebastian Dröge to committers list harder
2807
2808         He accidentally added himself to the reviewers list because the file is confusing. Then I
2809         accidentially moved him to the contributors list because the file is confusing, even though
2810         I knew the contributors list existed in this file and was attempting to add him to the
2811         committers list. Really move him to the committers list now.
2812
2813         * Scripts/webkitpy/common/config/contributors.json:
2814
2815 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2816
2817         Python SCM should be able to retrieve untracked files - Add SVN support
2818         https://bugs.webkit.org/show_bug.cgi?id=152546
2819
2820         Reviewed by Michael Catanzaro.
2821
2822         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2823         (test_untracked_files): Activating test for SVN.
2824         * Scripts/webkitpy/common/checkout/scm/svn.py:
2825         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
2826
2827 2015-12-31  Andy Estes  <aestes@apple.com>
2828
2829         Replace WTF::move with WTFMove
2830         https://bugs.webkit.org/show_bug.cgi?id=152601
2831
2832         Reviewed by Brady Eidson.
2833
2834         * DumpRenderTree/TestRunner.h:
2835         (TestRunner::setAllowedHosts):
2836         * DumpRenderTree/win/DRTDataObject.cpp:
2837         (DRTDataObject::SetData):
2838         * TestWebKitAPI/Tests/WTF/Deque.cpp:
2839         (TestWebKitAPI::TEST):
2840         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2841         (TestWebKitAPI::TEST):
2842         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2843         (TestWebKitAPI::TEST):
2844         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
2845         (TestWebKitAPI::TEST):
2846         * TestWebKitAPI/Tests/WTF/Ref.cpp:
2847         (TestWebKitAPI::passWithRef):
2848         (TestWebKitAPI::TEST):
2849         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2850         (TestWebKitAPI::TEST):
2851         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2852         (TestWebKitAPI::TEST):
2853         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2854         (TestWebKitAPI::TEST):
2855         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2856         (TestWebKitAPI::TEST):
2857         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2858         (TestWebKitAPI::createTestValue):
2859         (TestWebKitAPI::TEST):
2860         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2861         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2862         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2863         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2864         (TestWebKitAPI::createNFAs):
2865         (TestWebKitAPI::TEST_F):
2866         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
2867         (TestWebKitAPI::combine):
2868         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
2869         (TestWebKitAPI::createNFAs):
2870         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
2871         (TEST):
2872         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2873         (WebProcessTest::add):
2874
2875 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
2876
2877         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
2878         https://bugs.webkit.org/show_bug.cgi?id=152634
2879
2880         Reviewed by Carlos Garcia Campos.
2881
2882         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2883         (testLoadFromGResource): Added test.
2884         (beforeAll):
2885         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2886         (registerGResource): Added.
2887         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
2888         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
2889         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
2890
2891 2015-12-31  David Kilzer  <ddkilzer@apple.com>
2892
2893         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
2894         <https://bugs.webkit.org/show_bug.cgi?id=152601>
2895
2896         Ignore unknown pragmas on older clangs.  Fixes the following
2897         build failure:
2898
2899             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
2900             #pragma clang diagnostic ignored "-Wself-move"
2901                                              ^
2902             1 error generated.
2903
2904         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
2905         (TestWebKitAPI::TEST):
2906         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2907         (TestWebKitAPI::TEST):
2908
2909 2015-12-31  Andy Estes  <aestes@apple.com>
2910
2911         Update the style checker to advise using WTFMove() instead of WTF::move()
2912         https://bugs.webkit.org/show_bug.cgi?id=152601
2913
2914         Reviewed by Daniel Bates.
2915
2916         * Scripts/webkitpy/style/checkers/cpp.py:
2917         (check_wtf_move):
2918         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2919         (WebKitStyleTest.test_wtf_move):
2920
2921 2015-12-31  Andy Estes  <aestes@apple.com>
2922
2923         Fix warnings uncovered by migrating to WTF_MOVE
2924         https://bugs.webkit.org/show_bug.cgi?id=152601
2925
2926         Reviewed by Daniel Bates.
2927
2928         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
2929         self-move, even if doing so would trigger a warning.
2930
2931         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
2932         (TestWebKitAPI::TEST):
2933         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2934         (TestWebKitAPI::TEST):
2935
2936 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
2937
2938         [GTK] The install-dependencies script has a syntax error
2939         https://bugs.webkit.org/show_bug.cgi?id=152613
2940
2941         Reviewed by Michael Catanzaro.
2942
2943         * gtk/install-dependencies: Add the missing 'then.'
2944
2945 2015-12-30  Philippe Normand  <pnormand@igalia.com>
2946
2947         [Mac][GTK] Jhbuild support for OSX
2948         https://bugs.webkit.org/show_bug.cgi?id=150799
2949
2950         Reviewed by Michael Catanzaro.
2951
2952         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
2953         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
2954         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
2955         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
2956
2957 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2958
2959         Unreviewed, move Sebastian Dröge to committers list
2960
2961         He accidentally added himself to the reviewers list because the file is confusing.
2962
2963         * Scripts/webkitpy/common/config/contributors.json:
2964
2965 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
2966
2967         Remove the unused #define _USE_MATH_DEFINES
2968         https://bugs.webkit.org/show_bug.cgi?id=152034
2969
2970         Reviewed by Tim Horton.
2971         
2972         Update this test to use piDouble from MathExtras.h, and
2973         std::numeric_limits<>.
2974
2975         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2976
2977 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2978
2979         Python SCM should be able to retrieve untracked files - Generic changes
2980         https://bugs.webkit.org/show_bug.cgi?id=152536
2981
2982         Reviewed by Brent Fulgham.
2983
2984         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
2985         No support is yet added to GIT and SVN specific implementations.
2986
2987         * Scripts/webkitpy/common/checkout/scm/scm.py:
2988         (SCM.untracked_files):
2989         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2990         (SCMTest._shared_test_untracked_files):
2991
2992 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
2993
2994         SVN checkout used by RunBenchmark should be non-interactive
2995         https://bugs.webkit.org/show_bug.cgi?id=152542
2996
2997         Reviewed by Ryosuke Niwa.
2998
2999         RunBenchmark should not require user interaction while running.
3000
3001         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
3002         (BenchmarkBuilder._checkout_with_subversion):
3003
3004 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
3005
3006         Web Inspector: add support for running protocol-test.js tests on Windows
3007         https://bugs.webkit.org/show_bug.cgi?id=148037
3008         <rdar://problem/22292237>
3009
3010         Reviewed by Simon Fraser.
3011
3012         * DumpRenderTree/win/TestRunnerWin.cpp:
3013         (TestRunner::inspectorTestStubURL): Provide implementation.
3014
3015 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
3016
3017         [MediaStream] MediaDeviceInfo.label must be empty in some situations
3018         https://bugs.webkit.org/show_bug.cgi?id=152000
3019
3020         Reviewed by Brent Fulgham.
3021
3022         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3023         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3024         (WTR::InjectedBundle::setUserMediaPermission):
3025         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
3026         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3027
3028         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3029         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
3030         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3031
3032         * WebKitTestRunner/TestController.cpp:
3033         (WTR::TestController::setUserMediaPermissionForOrigin):
3034         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
3035         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
3036           persistent permission for origin, that can be done from script now.
3037         * WebKitTestRunner/TestController.h:
3038
3039         * WebKitTestRunner/TestInvocation.cpp:
3040         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
3041           SetUserMediaPermissionForOrigin.
3042
3043 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
3044
3045         [Win] Unreviewed build fix: Recognize Windows 10 variants.
3046
3047         * Scripts/webkitpy/common/system/platforminfo.py:
3048         (PlatformInfo._determine_win_version):
3049
3050 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
3051
3052         Content blockers should be able to promote http to https
3053         https://bugs.webkit.org/show_bug.cgi?id=148966
3054
3055         Reviewed by Benjamin Poulain.
3056
3057         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3058         (WebCore::ContentExtensions::operator<<):
3059         (TestWebKitAPI::TEST_F):
3060
3061 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
3062
3063         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
3064         https://bugs.webkit.org/show_bug.cgi?id=152516
3065
3066         Reviewed by Gyuyoung Kim.
3067
3068         * MiniBrowser/efl/main.c:
3069
3070 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
3071
3072         Unreviewed: Add John Wilander as a contributor.
3073
3074         * Scripts/webkitpy/common/config/contributors.json:
3075
3076 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
3077
3078         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
3079         https://bugs.webkit.org/show_bug.cgi?id=152482
3080
3081         Reviewed by Brent Fulgham.
3082
3083         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
3084         for the same property. On WK2, the element returned will not be valid, but is still present and
3085         that can lead to looping.
3086
3087         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3088         (AccessibilityUIElement::horizontalScrollbar):
3089         (AccessibilityUIElement::verticalScrollbar):
3090         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3091         (WTR::AccessibilityUIElement::horizontalScrollbar):
3092         (WTR::AccessibilityUIElement::verticalScrollbar):
3093
3094 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3095
3096         Unreviewed.
3097
3098         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
3099
3100 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
3101
3102         [EFL] test_ewk2_context failed after r192808
3103         https://bugs.webkit.org/show_bug.cgi?id=151846
3104
3105         Reviewed by Gyuyoung Kim.
3106
3107         Used the added ewk_context_web_process_count_limit_set api
3108         instead of the deprecated ewk_context_process_model_set.
3109
3110         * MiniBrowser/efl/main.c:
3111         (elm_main):
3112
3113 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3114
3115         Unreviewed, move myself to reviewer list.
3116
3117         * Scripts/webkitpy/common/config/contributors.json:
3118
3119 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
3120
3121         Unreviewed, add myself to the committers list.
3122
3123         * Scripts/webkitpy/common/config/contributors.json:
3124
3125 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3126
3127         [GTK] jquery.min.js violates DFSG
3128         https://bugs.webkit.org/show_bug.cgi?id=152428
3129
3130         Reviewed by Joseph Pecoraro.
3131
3132         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
3133         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
3134
3135         * gtk/manifest.txt.in:
3136
3137 2015-12-19  Dan Bernstein  <mitz@apple.com>
3138
3139         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
3140         https://bugs.webkit.org/show_bug.cgi?id=152462
3141
3142         Reviewed by Alexey Proskuryakov.
3143
3144         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
3145           OS X 10.9:
3146
3147         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3148         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3149         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3150         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3151         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3152
3153         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
3154           never getting compiled:
3155
3156         * DumpRenderTree/mac/TextInputController.m:
3157         * MiniBrowser/mac/BrowserWindowController.m:
3158         * TestWebKitAPI/Tests/mac/AttributedString.mm:
3159         * WebKitTestRunner/mac/EventSenderProxy.mm:
3160
3161 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
3162
3163         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
3164
3165         This is to make it easy to CC it on Bugzilla.
3166
3167         * Scripts/webkitpy/common/config/contributors.json:
3168
3169 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
3170
3171         Pasteboard get messed up after running kill-old-processes
3172         https://bugs.webkit.org/show_bug.cgi?id=152426
3173
3174         Reviewed by Alexey Proskuryakov.
3175
3176         * BuildSlaveSupport/kill-old-processes:
3177         (main): Do not kill pasteboard anymore.
3178
3179 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
3180
3181         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
3182         https://bugs.webkit.org/show_bug.cgi?id=152157
3183         <rdar://problem/23851817>
3184
3185         Reviewed by Alexey Proskuryakov.
3186
3187         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3188         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
3189         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3190         (Manager._get_test_inputs): Common method to calculate test_inputs.
3191         (Manager._update_worker_count): Calculate and update required number of workers.
3192
3193 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
3194
3195         run-webkit-tests fails to delete Simulator device during cleanup
3196         https://bugs.webkit.org/show_bug.cgi?id=152363
3197
3198         Reviewed by Alexey Proskuryakov.
3199
3200         * Scripts/webkitpy/xcode/simulator.py:
3201         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
3202
3203 2015-12-16  Tim Horton  <timothy_horton@apple.com>
3204
3205         [mac-wk2] fast/events force click tests crashing
3206         https://bugs.webkit.org/show_bug.cgi?id=152339
3207
3208         Reviewed by Beth Dakin.
3209
3210         * WebKitTestRunner/mac/EventSenderProxy.mm:
3211         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
3212         Set the NSEvent's _type member in addition to overriding -type,
3213         because there are assertions in touch event handling code that depend on it.
3214
3215 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3216
3217         Enforce temporarily bots to sync WebKit and WPT testharness.js
3218         https://bugs.webkit.org/show_bug.cgi?id=152334
3219
3220         Reviewed by Darin Adler.
3221
3222         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3223         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
3224
3225 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3226
3227         [Fetch API] Add fetch API compile time flag
3228         https://bugs.webkit.org/show_bug.cgi?id=152254
3229
3230         Reviewed by Darin Adler.
3231
3232         * Scripts/webkitperl/FeatureList.pm:
3233
3234 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3235
3236         Unreviewed.
3237
3238         Added files that have impact in building Streams API to the watchlist.
3239
3240         * Scripts/webkitpy/common/config/watchlist:
3241
3242 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3243
3244         Unreviewed.
3245
3246         Added imported tests to Streams API watchlist.
3247
3248         * Scripts/webkitpy/common/config/watchlist:
3249
3250 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3251
3252         Remove default copy of wpt testharness.js when launching wpt server
3253         https://bugs.webkit.org/show_bug.cgi?id=152298
3254
3255         Reviewed by Darin Adler.
3256
3257         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3258         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
3259
3260 2015-12-15  David Kilzer  <ddkilzer@apple.com>
3261
3262         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
3263         <http://webkit.org/b/152314>
3264
3265         Reviewed by Daniel Bates.
3266
3267         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
3268         code path to exit immediately when calling main().
3269         Unfortunately, DumpRenderTreeMain.mm was used for both
3270         DumpRenderTree command-line binary and DumpRenderTree.app, which
3271         meant that the app would exit immediately with no error code
3272         when run!
3273
3274         The workaround is to introduce a separate source file called
3275         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
3276         already does.
3277
3278         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
3279         DumpRenderTreeAppMain.mm to the project.  Make it the only
3280         compiled source for the DumpRenderTree.app target.
3281         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
3282         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
3283         case someone tries mistakenly to use the app.
3284         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3285         Link to JavaScriptCore.framework on iOS for the assert.
3286         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3287         Link to JavaScriptCore.framework on OS X for the assert.  Remove
3288         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
3289         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
3290         (main): Add assert for iOS so that a crash occurs if someone
3291         tries to run the wrong command.
3292
3293 2015-12-14  Tim Horton  <timothy_horton@apple.com>
3294
3295         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
3296         https://bugs.webkit.org/show_bug.cgi?id=152266
3297         <rdar://problem/22092676>
3298
3299         Reviewed by Simon Fraser.
3300
3301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3302         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
3303         Add a test that crashed before this change, and doesn't crash after.
3304
3305 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
3306
3307         AX: iOS: Text field variations do not have the correct traits
3308         https://bugs.webkit.org/show_bug.cgi?id=152237
3309
3310         Reviewed by Mario Sanchez Prada.
3311
3312         Add iOS calls for determing if an object is a search field or a text area.
3313
3314         * DumpRenderTree/AccessibilityUIElement.cpp:
3315         (getIsSearchFieldCallback):
3316         (getIsTextAreaCallback):
3317         (stringForSelectionCallback):
3318         (AccessibilityUIElement::getJSClass):
3319         * DumpRenderTree/AccessibilityUIElement.h:
3320         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3321         (AccessibilityUIElement::identifier):
3322         (AccessibilityUIElement::isTextArea):
3323         (AccessibilityUIElement::isSearchField):
3324         (AccessibilityUIElement::traits):
3325         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3326         (WTR::AccessibilityUIElement::scrollPageRight):
3327         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
3328         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
3329         (WTR::AccessibilityUIElement::isSearchField):
3330         (WTR::AccessibilityUIElement::isTextArea):
3331         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3332         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3333         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3334         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
3335         (WTR::AccessibilityUIElement::isTextArea):
3336         (WTR::AccessibilityUIElement::isSearchField):
3337         (WTR::AccessibilityUIElement::rowCount):
3338
3339 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3340
3341         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
3342         https://bugs.webkit.org/show_bug.cgi?id=152252
3343
3344         Reviewed by Sergio Villar Senin.
3345
3346         * gtk/install-dependencies: Add libtool-bin to the list of packages required
3347         for building the JHBuild on Debian systems.
3348
3349 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
3350
3351         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
3352         https://bugs.webkit.org/show_bug.cgi?id=152156
3353
3354         Reviewed by Dan Bernstein.
3355
3356         Our frameworks should appropriately prefix all ObjC classes,
3357         not just external symbols.
3358
3359         * Scripts/check-for-inappropriate-objc-class-names:
3360         Remove the -g switch to check all ObjC class names.
3361
3362 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
3363
3364         [MediaStream] Expose media capture devices persistent permissions to WebCore
3365         https://bugs.webkit.org/show_bug.cgi?id=152087
3366
3367         Add support for the new user media permission checker page UI client method.
3368
3369         Reviewed by Chris Dumez.
3370
3371         * WebKitTestRunner/TestController.cpp:
3372         (WTR::decidePolicyForUserMediaPermissionRequest):
3373         (WTR::checkUserMediaPermissionForOrigin):
3374         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
3375         (WTR::TestController::createWebViewWithOptions): Ditto.
3376         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
3377         (WTR::originUserVisibleName): New, create a string for the origin.
3378         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
3379           according to the state of the origin permission map.
3380         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
3381           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
3382         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
3383           origin permission map.
3384         * WebKitTestRunner/TestController.h:
3385
3386 2015-12-10  Alex Christensen  <achristensen@webkit.org>
3387
3388         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
3389         https://bugs.webkit.org/show_bug.cgi?id=152022
3390         rdar://problem/23763584
3391
3392         Reviewed by Darin Adler.
3393
3394         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3395         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3396         (WTR::InjectedBundlePage::willSendRequestForFrame):
3397         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3398         (WTR::TestRunner::setWillSendRequestReturnsNull):
3399         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
3400         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
3401         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
3402         (WTR::TestRunner::willSendRequestHTTPBody):
3403         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
3404
3405 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
3406
3407         Remove additional simulator checks before running layout-tests
3408         https://bugs.webkit.org/show_bug.cgi?id=152146
3409
3410         Reviewed by Darin Adler.
3411
3412         * Scripts/webkitpy/port/ios.py:
3413         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
3414         * Scripts/webkitpy/xcode/simulator.py:
3415         (Simulator._boot_and_shutdown_simulator_device): Deleted.
3416         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
3417
3418 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
3419
3420         Run atleast one simulator even if max process limit is low
3421         https://bugs.webkit.org/show_bug.cgi?id=152081
3422         <rdar://problem/23819694>
3423
3424         Reviewed by Alexey Proskuryakov.
3425
3426 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
3427
3428         [GTK] Crash in WebProcess when loading large content with custom URI schemes
3429         https://bugs.webkit.org/show_bug.cgi?id=144262
3430
3431         Reviewed by Carlos Garcia Campos.
3432
3433         Added new unit test to check the additional scenarios we now
3434         handle for custom URI schemes.
3435
3436         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3437         (generateHTMLContent): New helper function to generate big enough content.
3438         (testWebContextURIScheme): New unit test.
3439
3440 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
3441
3442         [EFL] Fix unhandled web process message when launching MiniBrowser
3443         https://bugs.webkit.org/show_bug.cgi?id=152048
3444
3445         Reviewed by Gyuyoung Kim.
3446
3447         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
3448         (TestWebKitAPI::TEST):
3449
3450 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3451
3452         [GTK] Add API to handle beforeunload events
3453         https://bugs.webkit.org/show_bug.cgi?id=139090
3454
3455         Reviewed by Gustavo Noronha Silva.
3456
3457         * MiniBrowser/gtk/BrowserWindow.c:
3458         (browserWindowConstructed):
3459         (browserWindowDeleteEvent):
3460         (browser_window_class_init):
3461         Handle delete-event to prevent the window from being closed when
3462         the page has beforeunload handlers. Use
3463         webkit_web_view_try_close() when the window is requested to be
3464         closed.
3465         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3466         (testWebViewJavaScriptDialogs):
3467         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
3468         script dialog type.
3469
3470 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
3471
3472         Refactored initialization code in LoadTrackingTest.
3473
3474         Rubber-stamped by Carlos Garcia Campos.
3475
3476         Small refactoring to make sure that the state of a LoadTrackingTest
3477         gets properly reset before loading new web content.
3478
3479         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
3480         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3481         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
3482         functions and reset the remaining local variables.
3483         (LoadTrackingTest::loadURI): Call reset();
3484         (LoadTrackingTest::loadHtml): Ditto.
3485         (LoadTrackingTest::loadPlainText): Ditto.
3486         (LoadTrackingTest::loadBytes): Ditto.
3487         (LoadTrackingTest::loadRequest): Ditto.
3488         (LoadTrackingTest::reload): Ditto.
3489         (LoadTrackingTest::goBack): Ditto.
3490         (LoadTrackingTest::goForward): Ditto.
3491
3492 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3493
3494         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
3495         https://bugs.webkit.org/show_bug.cgi?id=151942
3496
3497         Reviewed by Darin Adler.
3498
3499         * MiniBrowser/efl/main.c:
3500         (window_create): Enable offline web application cache feature on MiniBrowser.
3501         (elm_main):
3502
3503 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
3504
3505         https://bugs.webkit.org/show_bug.cgi?id=151243
3506         <rdar://problem/22955197>
3507
3508         Reviewed by Alexey Proskuryakov.
3509
3510         * LayoutTestRelay/LayoutTestRelay/main.m:
3511         (getTestingSimDevice): Use separate testing device for each worker.
3512         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3513         (Manager.run): Perform cleanup even if setup fails.
3514         * Scripts/webkitpy/port/ios.py:
3515         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
3516         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
3517         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
3518         (IOSSimulatorPort._quit_ios_simulator): Same
3519         (IOSSimulatorPort.clean_up_test_run): Same
3520         (IOSSimulatorPort.check_sys_deps): Same
3521         (IOSSimulatorPort.testing_device): Same
3522         (IOSSimulatorPort.reset_preferences): Same
3523         (IOSSimulatorPort.get_simulator_path): Return simulator path.
3524         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
3525         * Scripts/webkitpy/xcode/simulator.py:
3526         (Device.delete): Delete the simulator device.
3527         (Simulator.delete_device): Same
3528         (Simulator.wait_until_device_is_booted): Wait for device booting.
3529
3530 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
3531
3532         [EFL] Add API to provide preferences before creating ewk_view
3533         https://bugs.webkit.org/show_bug.cgi?id=151587
3534
3535         Reviewed by Gyuyoung Kim.
3536
3537         * MiniBrowser/efl/main.c:
3538         (on_key_down):
3539         (quit):
3540         (window_create):
3541         Moved settings related code to configuration() not to update settings
3542         whenever ewk_view is created.
3543         (configuration):
3544         (elm_main):
3545
3546 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3547
3548         Unreviewed. Fix GTK+ API tests after r193639.
3549
3550         The new jhbuild version needs some more variables ot be present in
3551         the builtin dict, even if they are set to None.
3552
3553         * jhbuild/jhbuildutils.py:
3554         (enter_jhbuild_environment_if_available):
3555
3556 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
3557
3558         [GTK] Notify WebCore when notification is clicked
3559         https://bugs.webkit.org/show_bug.cgi?id=151951
3560
3561         Reviewed by Carlos Garcia Campos.
3562
3563         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3564         (testWebViewNotification): test the new API.
3565
3566 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3567
3568         'jhbuild build' should fail immediately when building any module fails
3569         https://bugs.webkit.org/show_bug.cgi?id=145697
3570
3571         Reviewed by Carlos Garcia Campos.
3572
3573         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
3574         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
3575         Everything is placed under lib instead of lib64 now.
3576         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
3577         --exit-on-error when running 'jhbuild build'.
3578         * jhbuild/jhbuildrc_common.py:
3579         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
3580         jhbuild should be able to handle these for us without breaking things....
3581
3582 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3583
3584         Add support to import w3c tests from a repository with a different root that the main repo dir
3585         https://bugs.webkit.org/show_bug.cgi?id=151751
3586
3587         Reviewed by Ryosuke Niwa and Youenn Fablet.
3588
3589         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
3590         in a different directory than the repository root.
3591
3592         This patch introduces a new parameter tests_directory that we will use as root directory to search for
3593         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
3594         requires having the copy_path lists including tuples of origin and destination directories.
3595
3596         * Scripts/webkitpy/w3c/test_downloader.py:
3597         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
3598         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
3599         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3600         (TestImporterTest.test_tests_directory): Test.
3601
3602 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3603
3604         Mock TestRepositories in W3C importer tests
3605         https://bugs.webkit.org/show_bug.cgi?id=151938
3606
3607         Reviewed by Youenn Fablet.
3608
3609         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
3610         is because the test repository method reading the file was using the filesystem directly instead of taking the
3611         host one. This patch changes that.
3612
3613         * Scripts/webkitpy/w3c/test_downloader.py:
3614         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
3615         default one.
3616         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
3617         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3618         (TestImporterTest.test_harnesslinks_conversion):
3619         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
3620
3621 2015-12-07  David Kilzer  <ddkilzer@apple.com>
3622
3623         TestNetscapePlugIn: Address review comment on 193607
3624         <http://webkit.org/b/151881>
3625
3626         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3627         (testSetStatus): Initializing std::unique_ptr<char[]> with
3628         nullptr is redundant.
3629
3630 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3631
3632         [GTK] Add webkit_uri_request_get_http_method
3633         https://bugs.webkit.org/show_bug.cgi?id=151601
3634
3635         Reviewed by Martin Robinson.
3636
3637         Add test case to check HTTP method of WebKitURIRequest.
3638
3639         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3640         (testURIRequestHTTPMethod):
3641         (serverCallback):
3642         (beforeAll):
3643         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3644         (sendRequestCallback):
3645
3646 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3647
3648         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
3649         https://bugs.webkit.org/show_bug.cgi?id=79918
3650
3651         Reviewed by Gustavo Noronha Silva.
3652
3653         Add unit tests to check the different console messages.
3654
3655         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3656         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
3657         (ConsoleMessageTest::ConsoleMessage::operator==):
3658         (ConsoleMessageTest::consoleMessageReceivedCallback):
3659         (ConsoleMessageTest::ConsoleMessageTest):
3660         (ConsoleMessageTest::~ConsoleMessageTest):
3661         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
3662         (testWebKitConsoleMessageConsoleAPI):
3663         (testWebKitConsoleMessageJavaScriptException):
3664         (testWebKitConsoleMessageNetworkError):
3665         (testWebKitConsoleMessageSecurityError):
3666         (beforeAll):
3667         (afterAll):
3668         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3669         (consoleMessageSentCallback):
3670         (pageCreatedCallback):
3671
3672 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
3673
3674         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
3675         https://bugs.webkit.org/show_bug.cgi?id=151934
3676
3677         Reviewed by Csaba Osztrogonác.
3678
3679         * MiniBrowser/efl/main.c:
3680         (on_window_deletion): Revert the changes of r192767.
3681
3682 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3683
3684         [GTK] update-webkitgtk-libs cannot build mesa
3685         https://bugs.webkit.org/show_bug.cgi?id=151535
3686
3687         Reviewed by Martin Robinson.
3688
3689         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
3690         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
3691         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
3692         does not have a stable API and we cannot expect mesa to be buildable unless we control the
3693         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
3694         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
3695
3696         * gtk/jhbuild.modules:
3697
3698 2015-12-07  Philippe Normand  <pnormand@igalia.com>
3699
3700         [GTK][Mac] libWebExtensionTest link error
3701         https://bugs.webkit.org/show_bug.cgi?id=150802
3702
3703         Reviewed by Carlos Garcia Campos.
3704
3705         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
3706
3707 2015-12-06  David Kilzer  <ddkilzer@apple.com>
3708
3709         TestNetscapePlugIn: Fix leaks found by static analyzer
3710         <http://webkit.org/b/151881>
3711
3712         Reviewed by Darin Adler.
3713
3714         Fixes the following leaks found by the static analyzer:
3715             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
3716                     return false;
3717                            ^~~~~
3718             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
3719                     return false;
3720                            ^~~~~
3721             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
3722                     return false;
3723                            ^~~~~
3724
3725         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3726         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
3727         early return if allocation fails.
3728         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
3729         Make sure to call fclose() on filehandle, even for an early
3730         return.
3731         (testSetStatus): Switch to using std::unique_ptr<char[]>.
3732
3733 2015-12-05  David Kilzer  <ddkilzer@apple.com>
3734
3735         prepare-ChangeLog: Fix some warning messages when using svn
3736         <http://webkit.org/b/151914>
3737
3738         Reviewed by Daniel Bates.
3739
3740         * Scripts/prepare-ChangeLog:
3741         (generateFunctionLists): Simplify logic so that we never call
3742         normalizePath() with an undefined value.
3743         (attributeCommand): Quote $subPath for the shell so that we
3744         don't try to run "svn propget" on invalid paths.
3745
3746 2015-12-04  David Kilzer  <ddkilzer@apple.com>
3747
3748         TestNetscapePlugIn: Fix remaining static analyzer warnings
3749         <http://webkit.org/b/151888>
3750
3751         Reviewed by Alexey Proskuryakov.
3752
3753         Fixes the following static analyzer warnings:
3754             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
3755                     CRASH();
3756                     ^~~~~~~
3757             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
3758                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
3759                 ^~~~~~~~~~~~~~~~
3760             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
3761                 return obj->pluginTest->NPP_SetWindow(window);
3762                        ^~~~~~~~~~~~~~~
3763             2 warnings generated.
3764
3765         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3766         (CRASH): Use __builtin_trap() for gcc/clang.
3767         (NPP_SetWindow): Add early return if obj is nullptr.
3768
3769 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3770
3771         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
3772         https://bugs.webkit.org/show_bug.cgi?id=151797
3773
3774         Reviewed by Martin Robinson.
3775
3776         Since we switched to use the network process to run the unit tests
3777         the test /webkit2/WebKitWebResource/get-data sometimes fails and
3778         sometimes passes. We are now also getting the notification for the
3779         css image. Since we wait for 3 resources, sometimes the css image
3780         is loaded before and then checkResourceData is called for it, but
3781         not handled. When the css image is the last one loaded the test
3782         passes. So, we just need to wait for the 4 resources.
3783
3784         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3785         (testWebResourceGetData):
3786
3787 2015-12-03  David Kilzer  <ddkilzer@apple.com>
3788
3789         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
3790         <http://webkit.org/b/151845>
3791
3792         Reviewed by Simon Fraser.
3793
3794         Fixes the following static analyzer warning:
3795             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
3796                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
3797                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3798
3799         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3800         (createBitmapContext): Free 'buffer' after using it in logging
3801         to fix the use-after-free.  Assign a value of nullptr to buffer
3802         so we don't return with it set to a freed address.
3803
3804 2015-12-03  Jer Noble  <jer.noble@apple.com>
3805
3806         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
3807         https://bugs.webkit.org/show_bug.cgi?id=151830
3808
3809         Reviewed by Anders Carlsson.
3810
3811         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
3812
3813         * DumpRenderTree/mac/DumpRenderTree.mm:
3814         (resetWebPreferencesToConsistentValues):
3815         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3816         (WTR::initializeWebViewConfiguration):
3817
3818 2015-12-03  Anders Carlsson  <andersca@apple.com>
3819
3820         Remove Objective-C GC support
3821         https://bugs.webkit.org/show_bug.cgi?id=151819
3822         rdar://problem/23746991
3823
3824         Reviewed by Dan Bernstein.
3825
3826         * asan/asan.xcconfig:
3827
3828 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3829
3830         Allow nil for unspecified benchmark pathes
3831         https://bugs.webkit.org/show_bug.cgi?id=151784
3832
3833         Reviewed by Filip Pizlo.
3834
3835         `Pathname.new(nil)` will raise an error.
3836         Only generate Pathname if the benchmark path is specified.
3837
3838         * Scripts/run-jsc-benchmarks:
3839
3840 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
3841
3842         [Win] Run non-http tests without Cygwin
3843         https://bugs.webkit.org/show_bug.cgi?id=151721
3844
3845         Reviewed by Andy Estes.
3846
3847         Support native 32-bit and 64-bit Python (and Perl) builds
3848         for running tests:
3849
3850         1. Use "startswith('win')", rather than "== 'win32'" to support
3851         various Windows build types.
3852         2. Supply full path for some native Windows utilities, since the
3853         path environment does not always have the specified, and they are
3854         guaranteed to exist in those specific locations.
3855         3. Make sure native Windows Python test runs pass proper environment
3856         variables to run programs.
3857         4. Append 'exe' suffix when running Windows executables.
3858         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
3859         command doesn't exist.
3860         
3861         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
3862         the current Perl executable, rather than requiring a new path search.
3863         * Scripts/webkitpy/common/find_files_unittest.py:
3864         (TestWinNormalize.test_win): Use startswith('win').
3865         * Scripts/webkitpy/common/prettypatch_unittest.py:
3866         (test_pretty_diff_encodings): Ditto.
3867         * Scripts/webkitpy/common/system/executive.py:
3868         (Executive._should_close_fds): Ditto.
3869         (Executive.shell_command_for_script): Use startswith('win').
3870         (Executive.kill_process): Use full path to killall executable.
3871         (Executive.check_running_pid): Use startswith('win').
3872         (Executive.running_pids): Ditto.
3873         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
3874         running under native Windows Python.
3875         (Executive._child_process_encoding): Use startswith('win').
3876         (Executive._should_encode_child_process_arguments): Ditto.
3877         (Executive.popen): Recognize proper script engine on Windows, since it
3878         does not support the shebang syntax.
3879         (Executive.run_in_parallel): Use startswith('win').
3880         * Scripts/webkitpy/common/system/executive_unittest.py:
3881         (never_ending_command): Ditto.
3882         (ExecutiveTest.test_run_command_with_unicode): Ditto.
3883         (ExecutiveTest.serial_test_kill_process): Ditto.
3884         (ExecutiveTest.serial_test_kill_all): Ditto.
3885         (ExecutiveTest.serial_test_check_running_pid): Ditto.
3886         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
3887         (main): Ditto.
3888         * Scripts/webkitpy/common/system/file_lock.py:
3889         (FileLock._create_lock): Ditto.
3890         (FileLock._remove_lock): Ditto.
3891         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3892         (RealFileSystemTest.test_chdir): Ditto.
3893         (RealFileSystemTest.test_chdir__notexists): Ditto.
3894         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
3895         * Scripts/webkitpy/common/system/path_unittest.py:
3896         (AbspathTest.test_abspath_to_uri_win): Ditto.
3897         * Scripts/webkitpy/common/system/platforminfo.py:
3898         (PlatformInfo._determine_os_name): Ditto.
3899         * Scripts/webkitpy/common/system/user.py: Ditto.
3900         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3901         (ManagerTest.integration_test_needs_servers): Ditto.
3902         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3903         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
3904         driver letters.
3905         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
3906         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3907         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
3908         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3909         (HttpServerBase._check_that_all_ports_are_available): Ditto.
3910         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3911         (TestHttpServer.test_start_cmd): Ditto.
3912         * Scripts/webkitpy/port/base.py:
3913         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
3914         and 'SYSTEMROOT' in environment passed to test runners.
3915         (Port._apache_config_file_name_for_platform): Use startswith('win').
3916         (Port._build_path): Ditto.
3917         (Port._path_to_driver): Include 'exe' suffix when running under native
3918         Windows.
3919         * Scripts/webkitpy/port/driver.py:
3920         (Driver._setup_environ_for_driver): Explicitly make some environment
3921         variables strings.
3922         * Scripts/webkitpy/port/server_process.py:
3923         (ServerProcess.__init__): Use startswith('win').
3924         * Scripts/webkitpy/port/win.py:
3925         (WinPort): Use the win32 registry utilities on Windows, and appropriate
3926         registry key formats.
3927         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
3928         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
3929         and regtool on Cygwin.
3930         (WinPort.write_registry_value): Ditto.
3931         (WinPort.setup_crash_log_saving): Ditto.
3932         (WinPort.restore_crash_log_saving): Ditto.
3933         (WinPort.prevent_error_dialogs): Ditto.
3934         (WinPort.allow_error_dialogs): Ditto.
3935         (WinPort.find_system_pid): Revise to use Windows management
3936         infrastructure on native Windows, continue using 'ps' on Cygwin.
3937         (WinPort.read_registry_string): Deleted.
3938         (WinPort.write_registry_string): Deleted.
3939         * Scripts/webkitpy/test/main.py:
3940         (main): Use startswith('win').
3941         (Tester._parse_args): Ditto.
3942
3943 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
3944
3945         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
3946         https://bugs.webkit.org/show_bug.cgi?id=150792
3947
3948         Reviewed by Saam Barati.
3949
3950         * Scripts/webkitperl/FeatureList.pm:
3951
3952 2015-12-01  Commit Queue  <commit-queue@webkit.org>
3953
3954         Unreviewed, rolling out r192914.
3955         https://bugs.webkit.org/show_bug.cgi?id=151734
3956
3957         JSC tests for this change are failing on 32 and 64-bit bots
3958         (Requested by ryanhaddad on #webkit).
3959
3960         Reverted changeset:
3961
3962         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
3963         enable this feature"
3964         https://bugs.webkit.org/show_bug.cgi?id=150792
3965         http://trac.webkit.org/changeset/192914
3966
3967 2015-12-01  David Kilzer  <ddkilzer@apple.com>
3968
3969         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
3970         <http://webkit.org/b/151726>
3971
3972         Reviewed by Simon Fraser.
3973
3974         * WebKitTestRunner/mac/EventSenderProxy.mm:
3975         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
3976         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
3977
3978 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
3979
3980         Give String and AtomicString an existingHash() function
3981         https://bugs.webkit.org/show_bug.cgi?id=151717
3982
3983         Reviewed by Andreas Kling.
3984
3985         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
3986         (TestWebKitAPI::TEST):
3987         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3988         (TestWebKitAPI::TEST):
3989
3990 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
3991
3992         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
3993         https://bugs.webkit.org/show_bug.cgi?id=150792
3994
3995         Reviewed by Saam Barati.
3996
3997         * Scripts/webkitperl/FeatureList.pm:
3998
3999 2015-12-01  Sam Weinig  <sam@webkit.org>
4000
4001         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
4002         <rdar://problem/23320863>
4003         https://bugs.webkit.org/show_bug.cgi?id=151708
4004
4005         Reviewed by Anders Carlsson.
4006
4007         * WebKitTestRunner/TestController.cpp:
4008         (WTR::TestController::createOtherPage):
4009         (WTR::TestController::createWebViewWithOptions):
4010         Update for new WKPageUIClient.
4011
4012 2015-12-01  Anders Carlsson  <andersca@apple.com>
4013
4014         Remove WebKit2.framework
4015         https://bugs.webkit.org/show_bug.cgi?id=151715
4016
4017         Reviewed by Dan Bernstein.
4018
4019         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
4020         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
4021         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
4022         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
4023         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
4024         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
4025         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
4026
4027 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
4028
4029         Unreviewed common typo fix "occurance" => "occurrence".
4030
4031         * Scripts/webkitpy/tool/commands/queries.py:
4032         (FindFlakyTests._print_statistics):
4033
4034 2015-11-30  Alex Christensen  <achristensen@webkit.org>
4035
4036         Make ProcessModel always MultipleSecondaryProcesses
4037         https://bugs.webkit.org/show_bug.cgi?id=151662
4038
4039         Reviewed by Antti Koivisto.
4040
4041         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
4042         (TestWebKitAPI::TEST):
4043         * WebKitTestRunner/TestController.cpp:
4044         (WTR::TestController::generatePageConfiguration):
4045
4046 2015-11-30  Alex Christensen  <achristensen@webkit.org>
4047
4048         Make usesNetworkProcess always true
4049         https://bugs.webkit.org/show_bug.cgi?id=151580
4050
4051         Reviewed by Darin Adler.
4052
4053         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
4054         (TestWebKitAPI::TEST):
4055         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
4056         (TestWebKitAPI::TEST):
4057         * WebKitTestRunner/TestController.cpp:
4058         (WTR::TestController::generatePageConfiguration):
4059
4060 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
4061
4062         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
4063
4064         Add a way to skip unit tests only for Debug or Release builds and
4065         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
4066
4067         * Scripts/run-gtk-tests:
4068         (SkippedTest):
4069         (SkippedTest.__init__):
4070         (SkippedTest.__str__):
4071         (SkippedTest.skip_entire_suite):
4072         (SkippedTest.skip_for_build_type):
4073         (TestRunner):
4074         (TestRunner.__init__):
4075
4076 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
4077
4078         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
4079
4080         It's an assert hit because we are reloading a view loaded with
4081         HTML data which is not supported. Use loadURI instead.
4082
4083         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
4084         (testWebViewCustomCharset):
4085
4086 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
4087
4088         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
4089         https://bugs.webkit.org/show_bug.cgi?id=151633
4090
4091         Reviewed by Csaba Osztrogonác.
4092
4093         * TestWebKitAPI/PlatformGTK.cmake:
4094         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
4095
4096 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
4097
4098         [GTK] Remove the remaining uses of GMainLoopSource
4099         https://bugs.webkit.org/show_bug.cgi?id=151632
4100
4101         Reviewed by Žan Doberšek.
4102
4103         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
4104         (testWebViewSyncRequestOnMaxConns):
4105         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
4106         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4107         (WTR::TestRunner::TestRunner):
4108         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4109         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
4110         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
4111         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
4112         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4113         (WTR::timeoutSource):
4114         (WTR::TestController::notifyDone):
4115         (WTR::TestController::platformRunUntil):
4116
4117 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
4118
4119         [cmake] Add testb3 to the build system
4120         https://bugs.webkit.org/show_bug.cgi?id=151619
4121
4122         Reviewed by Gyuyoung Kim.
4123
4124         * Scripts/build-jsc:
4125
4126 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
4127
4128         [jhbuild] Fix pixman build with clang
4129         https://bugs.webkit.org/show_bug.cgi?id=151441
4130
4131         Reviewed by Carlos Garcia Campos.
4132
4133         * efl/jhbuild.modules:
4134         * gtk/jhbuild.modules:
4135
4136 2015-11-26  David Kilzer  <ddkilzer@apple.com>
4137
4138         Extract prependToEnvironmentVariableList
4139         <http://webkit.org/b/151536>
4140
4141         Reviewed by Daniel Bates.
4142
4143         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
4144                webkitdirs_unittest/prependToEnvironmentVariableList.pl
4145
4146         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
4147         and prependToEnvironmentVariableList.
4148         (appendToEnvironmentVariableList): Simplify variable name.
4149         Switch to use $Config{path_sep}.
4150         (prependToEnvironmentVariableList): Add new method.
4151         (setupMacWebKitEnvironment): Switch to use
4152         prependToEnvironmentVariableList().
4153         (setupIOSWebKitEnvironment): Ditto.
4154
4155         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
4156         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
4157
4158 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4159
4160         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
4161         https://bugs.webkit.org/show_bug.cgi?id=151567
4162
4163         Reviewed by Darin Adler.
4164
4165         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
4166         (on_window_deletion):
4167
4168 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
4169
4170         [GTK] Use the network process unconditionally
4171         https://bugs.webkit.org/show_bug.cgi?id=151541
4172
4173         Reviewed by Alex Christensen.
4174
4175         Fix TestInspectorServer test. Do not assume we already have the
4176         title we want when the page has been loaded, since the title is
4177         changed afterwards. So, check if the title has already been set,
4178         and if not wait for it.
4179
4180         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
4181         (openRemoteDebuggingSession):
4182
4183 2015-11-23  Alex Christensen  <achristensen@webkit.org>
4184
4185         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
4186         https://bugs.webkit.org/show_bug.cgi?id=151532
4187
4188         Reviewed by Benjamin Poulain.
4189
4190         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
4191         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
4192         (TestWebKitAPI::TEST):
4193         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
4194         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
4195         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
4196         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
4197         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
4198         so it was calling a function on a test object that had gone out of scope.
4199         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
4200         but that will become the default soon and that call will be removed.
4201
4202 2015-11-22  David Kilzer  <ddkilzer@apple.com>
4203
4204         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
4205         <http://webkit.org/b/151542>
4206
4207         Reviewed by Daniel Bates.
4208
4209         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
4210         (base_url): Use the Port object (already passed in) to give us
4211         the path to the LayoutTests directory, which already checks for a
4212         --layout-tests-directory command-line switch.
4213         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
4214         argument since we can get this from the Port object already
4215         passed in via Port.results_directory().  Also switch to use
4216         Port.layout_tests_dir() to get the LayoutTests directory.
4217
4218         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
4219         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
4220         Add test case for custom LayoutTests directory.
4221         (TestWebPlatformTestServer.test_previously_spawned_instance):
4222         Update Port object to set mock results directory as if it was
4223         set on the command-line.  Remove unneeded argument from
4224         WebPlatformTestServer constructor.
4225         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
4226
4227         * Scripts/webkitpy/port/base.py:
4228         (Port.to.start_web_platform_test_server): Remove unneeded
4229         argument from WebPlatformTestServer constuctor.
4230
4231 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
4232
4233         [GTK] Some unit tests fail when using the network process
4234         https://bugs.webkit.org/show_bug.cgi?id=151490
4235
4236         Reviewed by Martin Robinson.
4237
4238         Run the soup server in a separate thread in TestResources test to
4239         avoid deadlocks.
4240
4241         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
4242         /webkit2/WebKitWebResource/get-data when using the network process.
4243
4244         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
4245         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
4246         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
4247         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
4248         present, create a WorkQueue to run the server.
4249         (WebKitTestServer::run): Run the server in the work queue if it
4250         has been created.
4251         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
4252         type into server options as flags.
4253
4254 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
4255
4256         [GTK] ImageDiff should normalize the diff image
4257         https://bugs.webkit.org/show_bug.cgi?id=151261
4258
4259         Reviewed by Sergio Villar Senin.
4260
4261         * ImageDiff/gtk/ImageDiff.cpp:
4262         (readPixbufFromStdin): Fix memory leak.
4263         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
4264         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
4265
4266 == Rolled over to ChangeLog-2015-11-21 ==