Add support for incremental bytecode cache updates
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2
3         Add support for incremental bytecode cache updates
4         https://bugs.webkit.org/show_bug.cgi?id=195000
5
6         Reviewed by Filip Pizlo.
7
8         Exit when the initial run to generate bytecode fails.
9
10         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
11
12 2019-04-10  Alex Christensen  <achristensen@webkit.org>
13
14         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
15         https://bugs.webkit.org/show_bug.cgi?id=196744
16         <rdar://49415309>
17
18         Reviewed by Chris Dumez.
19
20         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
21         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
22
23 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
24
25         Add a way to opt into modern compatibility mode in layout tests
26         https://bugs.webkit.org/show_bug.cgi?id=196770
27         <rdar://problem/49777550>
28
29         Reviewed by Antoine Quint.
30
31         Add a new test option to enable modern compatibility mode in layout tests.
32
33         * WebKitTestRunner/TestController.cpp:
34         (WTR::updateTestOptionsFromTestHeader):
35         * WebKitTestRunner/TestController.h:
36         * WebKitTestRunner/TestOptions.h:
37         (WTR::TestOptions::hasSameInitializationOptions const):
38         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
39         (WTR::TestController::platformCreateWebView):
40         (WTR::TestController::enableModernCompatibilityMode):
41
42 2019-04-10  Andy Estes  <aestes@apple.com>
43
44         Try to fix the 32-bit watchOS build.
45
46         * TestWebKitAPI/cocoa/TestWKWebView.mm:
47         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
48
49 2019-04-10  Antoine Quint  <graouts@apple.com>
50
51         Enable Pointer Events on watchOS
52         https://bugs.webkit.org/show_bug.cgi?id=196771
53         <rdar://problem/49040909>
54
55         Reviewed by Dean Jackson.
56
57         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
58
59 2019-04-10  Philippe Normand  <pnormand@igalia.com>
60
61         Unreviewed. Fix WPE accessibility tests after r244059.
62
63         We are failing to load the injected bundle due to undefined symbol
64         AccessibilityUIElement::replaceTextInRange().
65
66         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
67         (WTR::AccessibilityUIElement::replaceTextInRange):
68
69 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
70
71         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
72         https://bugs.webkit.org/show_bug.cgi?id=196727
73
74         Reviewed by Fujii Hironori.
75
76         * MiniBrowser/win/WebKitBrowserWindow.cpp:
77         (WebKitBrowserWindow::create):
78
79 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
80
81         [ews-build] Add unit tests for PrintConfiguration
82         https://bugs.webkit.org/show_bug.cgi?id=196752
83
84         Reviewed by Dewei Zhu.
85
86         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
87
88 2019-04-09  Keith Rollin  <krollin@apple.com>
89
90         Unreviewed build maintenance -- update .xcfilelists.
91
92         * DumpRenderTree/DerivedSources-input.xcfilelist:
93         * DumpRenderTree/DerivedSources-output.xcfilelist:
94
95 2019-04-09  Zalan Bujtas  <zalan@apple.com>
96
97         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
98         https://bugs.webkit.org/show_bug.cgi?id=196743
99         <rdar://problem/43897551>
100
101         Reviewed by Tim Horton.
102
103         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
104         (TEST):
105
106 2019-04-09  Youenn Fablet  <youenn@apple.com>
107
108         Close service worker database on network process suspension
109         https://bugs.webkit.org/show_bug.cgi?id=196623
110         <rdar://problem/48930869>
111
112         Reviewed by Alex Christensen.
113
114         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
115
116 2019-04-09  Daniel Bates  <dabates@apple.com>
117
118         [iPad] Should open popover when the spacebar is pressed
119         https://bugs.webkit.org/show_bug.cgi?id=196360
120         <rdar://problem/49389129>
121
122         Reviewed by Brent Fulgham.
123
124         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
125
126         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
127         (WTR::UIScriptController::isShowingPopover const): Added.
128         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
129         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
130         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
131         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
132         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
133         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
134         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
135         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
136         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
137         (WTR::UIScriptController::isShowingPopover const): Added.
138         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
139         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
140         * TestRunnerShared/UIScriptContext/UIScriptController.h:
141         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
142         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
143         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
144         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
145         (-[TestRunnerWKWebView _willPresentPopover]): Added.
146         (-[TestRunnerWKWebView _didDismissPopover]): Added.
147         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
148         (WTR::UIScriptController::isShowingPopover const): Added.
149         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
150         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
151
152 2019-04-09  Alex Christensen  <achristensen@webkit.org>
153
154         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
155         https://bugs.webkit.org/show_bug.cgi?id=196665
156         <rdar://45115669>
157
158         Reviewed by Geoff Garen.
159
160         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
161         (goBack):
162         (+[SimpleLookupContext sharedLookupContext]):
163         (-[SimpleLookupContext lookUpURL:completionHandler:]):
164         (TEST):
165         (+[Simple3LookupContext sharedLookupContext]): Deleted.
166         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
167
168 2019-04-09  John Wilander  <wilander@apple.com>
169
170         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
171         https://bugs.webkit.org/show_bug.cgi?id=196558
172         <rdar://problem/47650245>
173
174         Reviewed by Youenn Fablet.
175
176         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
177         (TestWebKitAPI::TEST):
178             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
179
180 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
181
182         [CMake] Apple builds should use ICU_INCLUDE_DIRS
183         https://bugs.webkit.org/show_bug.cgi?id=196720
184
185         Reviewed by Konstantin Tokarev.
186
187         * TestWebKitAPI/PlatformMac.cmake:
188
189 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
190
191         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
192         https://bugs.webkit.org/show_bug.cgi?id=196694
193         <rdar://problem/48388734>
194
195         Rubber-stamped by Aakash Jain.
196
197         * Scripts/webkitpy/port/image_diff.py:
198         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
199         * Scripts/webkitpy/port/server_process.py:
200         (ServerProcess.has_available_stdout): Check if stdout has data in it.
201         (ServerProcess._wait_for_data_and_update_buffers_using_select):
202         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
203         * Scripts/webkitpy/port/server_process_mock.py:
204         (MockServerProcess.has_available_stdout):
205         * Scripts/webkitpy/port/server_process_unittest.py:
206         (TestServerProcess.serial_test_basic):
207
208 2019-04-09  Jer Noble  <jer.noble@apple.com>
209
210         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
211         https://bugs.webkit.org/show_bug.cgi?id=196097
212
213         Reviewed by Eric Carlson.
214
215         Drive-by bug fix: allow tests to play audio without a user gesture by default.
216
217         * DumpRenderTree/mac/DumpRenderTree.mm:
218         (resetWebPreferencesToConsistentValues):
219         * WebKitTestRunner/TestController.cpp:
220         (WTR::TestController::resetPreferencesToConsistentValues):
221
222 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
223
224         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
225         https://bugs.webkit.org/show_bug.cgi?id=196690
226
227         Reviewed by Michael Catanzaro.
228
229         * QueueStatusServer/config/queues.py:
230         * Scripts/webkitpy/common/config/ews.json:
231         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
232         (test_ews_name):
233
234 2019-04-09  Chris Dumez  <cdumez@apple.com>
235
236         Loads using loadHTMLString() cause flashing when process-swapping
237         https://bugs.webkit.org/show_bug.cgi?id=196714
238         <rdar://problem/49637354>
239
240         Reviewed by Antti Koivisto.
241
242         Add API test coverage.
243
244         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
245
246 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
247
248         Unreviewed. Fix ATK accessibility tests after r244059.
249
250         We are failing to load the injected bundle due to undefined symbol
251         AccessibilityUIElement::replaceTextInRange().
252
253         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
254         (WTR::AccessibilityUIElement::replaceTextInRange):
255
256 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
257
258         AX: Support API: accessibilityReplaceRange:withText
259         https://bugs.webkit.org/show_bug.cgi?id=196636
260
261         Unreviewed build fix for Windows port.
262
263         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
264         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
265
266 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
267
268         [CMake][WinCairo] Separate copied headers into different directories
269         https://bugs.webkit.org/show_bug.cgi?id=196655
270
271         Reviewed by Michael Catanzaro.
272
273         * DumpRenderTree/CMakeLists.txt:
274         * MiniBrowser/win/CMakeLists.txt:
275         * TestWebKitAPI/CMakeLists.txt:
276         * TestWebKitAPI/PlatformWin.cmake:
277
278 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
279
280         Log stack-trace for run-webkit-tests when interrupted
281         https://bugs.webkit.org/show_bug.cgi?id=176393
282         <rdar://problem/34262310>
283
284         Reviewed by Lucas Forschler.
285
286         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
287         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
288         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
289         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
290         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
291         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
292         (main): Set handlers to log stack trace on interruption.
293
294 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
295
296         AX: Support API: accessibilityReplaceRange:withText
297         https://bugs.webkit.org/show_bug.cgi?id=196636
298
299         Unreviewed build fix for Windows port.
300
301         * DumpRenderTree/AccessibilityUIElement.cpp:
302         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
303
304 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
305
306         [ews-build] Scripts using Buildbot API have CORS error
307         https://bugs.webkit.org/show_bug.cgi?id=196709
308
309         Reviewed by Alexey Proskuryakov.
310
311         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
312
313 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
314
315         AX: Support API: accessibilityReplaceRange:withText
316         https://bugs.webkit.org/show_bug.cgi?id=196636
317
318         Reviewed by Daniel Bates.
319
320         * DumpRenderTree/AccessibilityUIElement.cpp:
321         (replaceTextInRangeCallback):
322         (AccessibilityUIElement::replaceTextInRange):
323         (AccessibilityUIElement::getJSClass):
324         * DumpRenderTree/AccessibilityUIElement.h:
325         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
326         (AccessibilityUIElement::replaceTextInRange):
327         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
328         (AccessibilityUIElement::replaceTextInRange):
329         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
330         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
331         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
332         (WTR::AccessibilityUIElement::replaceTextInRange):
333         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
334         (WTR::AccessibilityUIElement::replaceTextInRange):
335
336 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
337
338         [iOS] Do not allow starting selection drags when selection views are not visible
339         https://bugs.webkit.org/show_bug.cgi?id=196686
340         <rdar://problem/49399192>
341
342         Reviewed by Tim Horton.
343
344         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
345         also add some new API tests to cover scenarios where the web view is not first responder.
346
347         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
348         (TestWebKitAPI::TEST):
349         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
350
351         Add a switch to optionally make the web view first responder when starting the simulated drag.
352
353         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
354         (-[DragAndDropSimulator initWithWebView:]):
355         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
356
357 2019-04-08  Justin Fan  <justin_fan@apple.com>
358
359         [Web GPU] Fix Web GPU experimental feature on iOS
360         https://bugs.webkit.org/show_bug.cgi?id=196632
361
362         Reviewed by Myles C. Maxfield.
363
364         Properly make Web GPU available on iOS 11+.
365
366         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
367
368 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
369
370         [ews-build] Do not upload archive when Compile Fails
371         https://bugs.webkit.org/show_bug.cgi?id=196674
372
373         Reviewed by Alexey Proskuryakov.
374
375         * BuildSlaveSupport/ews-build/factories.py:
376         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
377         * BuildSlaveSupport/ews-build/steps.py:
378         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
379         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
380         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
381
382 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
383
384         Enable DFG on MIPS
385         https://bugs.webkit.org/show_bug.cgi?id=196689
386
387         Reviewed by Žan Doberšek.
388
389         Since the bytecode change, we enabled the baseline JIT on mips in
390         r240432, but DFG is still missing. With this change, all tests are
391         passing on a ci20 board.
392
393         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
394
395 2019-04-08  Philippe Normand  <pnormand@igalia.com>
396
397         [Flatpak] Second run update-webkitwpe-flatpak fails
398         https://bugs.webkit.org/show_bug.cgi?id=192702
399
400         Reviewed by Carlos Garcia Campos.
401
402         * flatpak/flatpakutils.py:
403         (FlatpakObject.flatpak): Fix typo.
404         (FlatpakPackage.install): When installing, also update to the configured remote commit.
405         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
406
407 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
408
409         [GTK][WPE] outlook.live.com displays old-fashioned UI
410         https://bugs.webkit.org/show_bug.cgi?id=196642
411
412         Reviewed by Carlos Garcia Campos.
413
414         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
415         (TestWebKitAPI::TEST): New Mac platform quirk test.
416
417 2019-04-07  Commit Queue  <commit-queue@webkit.org>
418
419         Unreviewed, rolling out r243956.
420         https://bugs.webkit.org/show_bug.cgi?id=196688
421
422         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
423         by aakashjain on #webkit).
424
425         Reverted changeset:
426
427         "Clicking "Go Back" from a safe browsing warning from an
428         iframe should navigate the WKWebView back to the previous
429         page"
430         https://bugs.webkit.org/show_bug.cgi?id=196665
431         https://trac.webkit.org/changeset/243956
432
433 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
434
435         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
436         https://bugs.webkit.org/show_bug.cgi?id=196669
437
438         Reviewed by Geoffrey Garen.
439
440         Added three new unit tests for WeakHashSet.
441
442         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
443         (WTF_WeakPtr.WeakHashSetConstObjects):
444         (WTF_WeakPtr.WeakHashSetComputesEmpty):
445         (WTF_WeakPtr.WeakHashSetComputeSize):
446
447 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
448
449         Hide next and previous form control buttons when WKWebView is editable
450         https://bugs.webkit.org/show_bug.cgi?id=196672
451         <rdar://problem/35625321>
452
453         Reviewed by Tim Horton.
454
455         Add a new API test.
456
457         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
458         (-[TestWKWebView lastTrailingBarButtonGroup]):
459         (TestWebKitAPI::TEST):
460         * TestWebKitAPI/ios/UIKitSPI.h:
461
462 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
463
464         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
465         https://bugs.webkit.org/show_bug.cgi?id=196077
466         <rdar://problem/49108202>
467
468         Reviewed by Chris Dumez.
469
470         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
471         on new web view.
472
473         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
474
475 2019-04-05  Saam Barati  <sbarati@apple.com>
476
477         Make compare-results understand MotionMark
478         https://bugs.webkit.org/show_bug.cgi?id=196666
479
480         Reviewed by Yusuke Suzuki.
481
482         * Scripts/compare-results:
483         (PLT5Results):
484         (detectMotionMark):
485         (detectMotionMark1_1):
486         (motionMarkResults):
487         (motionMark1_1Results):
488         (detectBenchmark):
489         (biggerIsBetter):
490         (main):
491
492 2019-04-05  Alex Christensen  <achristensen@webkit.org>
493
494         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
495         https://bugs.webkit.org/show_bug.cgi?id=196665
496         <rdar://45115669>
497
498         Reviewed by Geoff Garen.
499
500         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
501         (goBack):
502         (+[SimpleLookupContext sharedLookupContext]):
503         (-[SimpleLookupContext lookUpURL:completionHandler:]):
504         (TEST):
505         (+[Simple3LookupContext sharedLookupContext]): Deleted.
506         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
507
508 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
509
510         [ews-build] Add configuration and architecture for windows builders
511         https://bugs.webkit.org/show_bug.cgi?id=196660
512
513         Reviewed by Lucas Forschler.
514
515         * BuildSlaveSupport/ews-build/config.json:
516
517 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
518
519         webkitpy: Don't run subsequent rounds if interrupted
520         https://bugs.webkit.org/show_bug.cgi?id=196646
521
522         Reviewed by Aakash Jain.
523
524         * Scripts/webkitpy/layout_tests/controllers/manager.py:
525         (Manager.run): Bail out if interrupted.
526
527 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
528
529         Test sessionStorage in PSON private browsing mode
530         https://bugs.webkit.org/show_bug.cgi?id=196561
531
532         Reviewed by Alex Christensen.
533
534         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
535
536 2019-04-05  Commit Queue  <commit-queue@webkit.org>
537
538         Unreviewed, rolling out r243833.
539         https://bugs.webkit.org/show_bug.cgi?id=196645
540
541         This change breaks build of WPE and GTK ports (Requested by
542         annulen on #webkit).
543
544         Reverted changeset:
545
546         "[CMake][WTF] Mirror XCode header directories"
547         https://bugs.webkit.org/show_bug.cgi?id=191662
548         https://trac.webkit.org/changeset/243833
549
550 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
551
552         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
553         https://bugs.webkit.org/show_bug.cgi?id=196635
554
555         Reviewed by Antti Koivisto.
556         
557         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
558         for a test to enable async frame scrolling via:
559             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
560         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
561         
562         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
563
564         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
565         (WTR::InjectedBundle::beginTesting):
566         * WebKitTestRunner/TestController.cpp:
567         (WTR::TestController::resetPreferencesToConsistentValues):
568
569 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
570
571         Use a correct LC_RPATH when building with ASan
572         https://bugs.webkit.org/show_bug.cgi?id=196576
573
574         Reviewed by David Kilzer.
575
576         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
577         so that ../Frameworks is checked. This is simpler and more reliable than updating
578         each SPC service xcconfig.
579
580 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
581
582         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
583         https://bugs.webkit.org/show_bug.cgi?id=196629
584
585         Reviewed by Lucas Forschler.
586
587         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
588
589 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
590
591         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
592         https://bugs.webkit.org/show_bug.cgi?id=196618
593
594         Reviewed by Lucas Forschler.
595
596         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
597         (StatusBubble): Added QUEUE_TRIGGERS.
598         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
599         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
600         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
601         its parent(builder).
602
603 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
604
605         [ews-app] Status-bubble steps are sometimes displayed in reverse order
606         https://bugs.webkit.org/show_bug.cgi?id=196625
607
608         Reviewed by Lucas Forschler.
609
610         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
611         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
612
613 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
614
615         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
616         https://bugs.webkit.org/show_bug.cgi?id=196630
617
618         Reviewed by Wenson Hsieh.
619
620         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
621
622 2019-04-04  Youenn Fablet  <youenn@apple.com>
623
624         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
625         https://bugs.webkit.org/show_bug.cgi?id=196543
626
627         Reviewed by Alex Christensen.
628
629         * WebKitTestRunner/TestController.cpp:
630         (WTR::TestController::generatePageConfiguration):
631
632 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
633
634         [ews-app] Status bubble should not display skipped buildbot steps
635         https://bugs.webkit.org/show_bug.cgi?id=196584
636
637         Reviewed by Lucas Forschler.
638
639         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
640
641 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
642
643         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
644         https://bugs.webkit.org/show_bug.cgi?id=196620
645
646         Reviewed by Lucas Forschler.
647
648         * BuildSlaveSupport/ews-app/ews/config.py:
649
650 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
651
652         [Win] DumpRenderTreeWatchDog.py is not checked into source
653         https://bugs.webkit.org/show_bug.cgi?id=196567
654         <rdar://problem/49525901>
655
656         Reviewed by Lucas Forschler.
657
658         This script is used on Win EWS bots to terminate hanging DRT processes.
659
660         * EWSTools/dumprendertreewatchdog.py: Added.
661
662 2019-04-04  Chris Dumez  <cdumez@apple.com>
663
664         Unreviewed, roll out r243858 which made tests time out.
665
666         Disable new API tests on Windows instead.
667
668         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
669         (TestWebKitAPI::TEST):
670
671 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
672
673         [ATK] Cleanup WebPageAccessibilityObjectAtk
674         https://bugs.webkit.org/show_bug.cgi?id=196537
675
676         Reviewed by Michael Catanzaro.
677
678         Also consider files under atk directories as exceptions for GObject conventions.
679
680         * Scripts/webkitpy/style/checkers/cpp.py:
681         (check_identifier_name_in_declaration):
682
683 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
684
685         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
686         https://bugs.webkit.org/show_bug.cgi?id=196588
687         <rdar://problem/49365787>
688
689         Unreviewed build fix for Windows port.
690
691         error C3861: 'kill': identifier not found
692
693         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
694         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
695
696 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
697
698         [ews-build] Cancel build and similar operations should have authentication
699         https://bugs.webkit.org/show_bug.cgi?id=196520
700
701         Reviewed by Dewei Zhu.
702
703         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
704         environment variables.
705
706 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
707
708         [ews-build] Do not trigger queues which are not in production yet
709         https://bugs.webkit.org/show_bug.cgi?id=196581
710
711         Reviewed by Dewei Zhu.
712
713         * BuildSlaveSupport/ews-build/config.json:
714
715 2019-04-03  Chris Dumez  <cdumez@apple.com>
716
717         Unreviewed, fix typo in the name of API test added in r243848.
718
719         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
720         (TestWebKitAPI::TEST):
721
722 2019-04-03  Chris Dumez  <cdumez@apple.com>
723
724         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
725         https://bugs.webkit.org/show_bug.cgi?id=196588
726         <rdar://problem/49365787>
727
728         Reviewed by Ryosuke Niwa.
729
730         Add API test coverage.
731
732         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
733         (TestWebKitAPI::nullJavaScriptCallback):
734         (TestWebKitAPI::didCrashCheckFrames):
735         (TestWebKitAPI::TEST):
736
737 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
738
739         run-webkit-tests: Upload test results (new results database)
740         https://bugs.webkit.org/show_bug.cgi?id=196577
741         <rdar://problem/34841155>
742
743         Reviewed by Lucas Forschler.
744
745         * Scripts/webkitpy/layout_tests/controllers/manager.py:
746         (Manager.run): Upload results after each device shard, since the configuration will be
747         different for each device.
748         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
749         uploaded to a results database.
750         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
751         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
752
753 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
754
755         -apple-trailing-word is needed for browser detection
756         https://bugs.webkit.org/show_bug.cgi?id=196575
757
758         Unreviewed.
759
760         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
761
762 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
763
764         [CMake][WTF] Mirror XCode header directories
765         https://bugs.webkit.org/show_bug.cgi?id=191662
766
767         Reviewed by Konstantin Tokarev.
768
769         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
770         builds.
771
772         * CMakeLists.txt:
773         * DumpRenderTree/CMakeLists.txt:
774         * DumpRenderTree/PlatformWin.cmake:
775         * MiniBrowser/win/CMakeLists.txt:
776         * TestWebKitAPI/CMakeLists.txt:
777         * TestWebKitAPI/PlatformWin.cmake:
778         * WebKitTestRunner/PlatformGTK.cmake:
779         * WebKitTestRunner/PlatformWin.cmake:
780
781 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
782
783         [ews-app] Status bubble should not display certain infrastructure status messages
784         https://bugs.webkit.org/show_bug.cgi?id=196550
785
786         Reviewed by Lucas Forschler.
787
788         Do not display the steps which are un-needed for end-user. This information is still avaiable
789         if the user click on the bubble and look at the Buildbot build.
790         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
791         (StatusBubble._steps_messages):
792         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
793
794 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
795
796         [ews-build] Use https for sending data to ews-app
797         https://bugs.webkit.org/show_bug.cgi?id=196492
798
799         Reviewed by Lucas Forschler.
800
801         * BuildSlaveSupport/ews-build/events.py:
802
803 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
804
805         Remove support for -apple-trailing-word
806         https://bugs.webkit.org/show_bug.cgi?id=196525
807
808         Reviewed by Zalan Bujtas.
809
810         This CSS property is nonstandard and not used.
811
812         * Scripts/webkitperl/FeatureList.pm:
813         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
814
815 2019-04-03  Youenn Fablet  <youenn@apple.com>
816
817         Add a test for DOMCache on multiple browsing in case of private browsing
818         https://bugs.webkit.org/show_bug.cgi?id=196524
819
820         Reviewed by Alex Christensen.
821
822         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
823         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
824
825 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
826
827         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
828         https://bugs.webkit.org/show_bug.cgi?id=196540
829
830         Reviewed by Aakash Jain.
831
832         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
833
834 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
835
836         Add plumbing for a compatibility mode preference in WebKit
837         https://bugs.webkit.org/show_bug.cgi?id=196005
838
839         Reviewed by Tim Horton.
840
841         Add new API tests.
842
843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
844         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
845
846 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
847
848         [WPE][GTK] Update libsrtp dependency package for Debian
849         https://bugs.webkit.org/show_bug.cgi?id=196528
850
851         Reviewed by Frédéric Wang.
852
853         * gtk/install-dependencies:
854         * wpe/install-dependencies:
855
856 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
857
858         [WK2] Add support for Window's beforeprint / afterprint events
859         https://bugs.webkit.org/show_bug.cgi?id=196478
860         <rdar://problem/49535124>
861
862         Unreviewed build fix for MSVC.
863
864         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
865
866         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
867
868         * WebKitTestRunner/TestController.cpp:
869         (WTR::printFrame): Use int and float literals.
870
871 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
872
873         [ews-build] Reassign bots to queues
874
875         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
876
877 2019-04-02  Chris Dumez  <cdumez@apple.com>
878
879         [WK2] Add support for Window's beforeprint / afterprint events
880         https://bugs.webkit.org/show_bug.cgi?id=196478
881
882         Reviewed by Alex Christensen.
883
884         Add minimal implementation for printFrame in WebKitTestRunner.
885
886         * WebKitTestRunner/TestController.cpp:
887         (WTR::printFrame):
888         (WTR::TestController::createOtherPage):
889         (WTR::TestController::createWebViewWithOptions):
890
891 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
892
893         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
894         https://bugs.webkit.org/show_bug.cgi?id=196491
895
896         Reviewed by Lucas Forschler.
897
898         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
899
900 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
901
902         [ews-build] Configure buildbot try credentials in environment variables
903         https://bugs.webkit.org/show_bug.cgi?id=196501
904
905         Reviewed by Lucas Forschler.
906
907         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
908         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
909         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
910
911 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
912
913         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
914         https://bugs.webkit.org/show_bug.cgi?id=196496
915         <rdar://problem/49521634>
916
917         Reviewed by Chris Dumez.
918
919         Add new API tests (see WebKit ChangeLog for more detail).
920
921         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
922         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
923         (TEST):
924
925 2019-04-02  David Kilzer  <ddkilzer@apple.com>
926
927         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
928         <https://webkit.org/b/196499>
929
930         Reviewed by Alexey Proskuryakov.
931
932         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
933         ENABLE_ADDRESS_SANITIZER.
934
935 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
936
937         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
938         https://bugs.webkit.org/show_bug.cgi?id=182757
939
940         Reviewed by Don Olmstead.
941
942         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
943         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
944
945 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
946
947         run-api-tests: Upload test results
948         https://bugs.webkit.org/show_bug.cgi?id=196323
949         <rdar://problem/49356714>
950
951         Reviewed by Lucas Forschler.
952
953         * Scripts/webkitpy/api_tests/manager.py:
954         (Manager):
955         (Manager.run): Upload results to a results database.
956         * Scripts/webkitpy/api_tests/run_api_tests.py:
957         (parse_args): Add upload arguments.
958         * Scripts/webkitpy/port/base.py:
959         (Port):
960         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
961         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
962         with commits from any other associated repositories.
963         * Scripts/webkitpy/port/device.py:
964         (Device):
965         (Device.build_version): Access build_versoin of underlying platform device.
966         * Scripts/webkitpy/port/ios_simulator_unittest.py:
967         (IOSSimulatorTest):
968         (IOSSimulatorTest.test_configuration_for_upload):
969         * Scripts/webkitpy/port/device_port.py:
970         (DevicePort):
971         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
972         the same as the machine uploading results.
973         * Scripts/webkitpy/port/mac.py:
974         (MacPort):
975         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
976         * Scripts/webkitpy/port/mac_unittest.py:
977         (MacTest):
978         (MacTest.test_configuration_for_upload):
979         * Scripts/webkitpy/xcode/simulated_device.py:
980         (SimulatedDeviceManager._create_device_with_runtime):
981         (SimulatedDevice.__init__): Create simulated device with a build_version.
982         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
983         (test_existing_simulator):
984
985 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
986
987         Remove extra newline characters (Follow-up fix to r243707)
988
989         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
990
991 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
992
993         [ews-app] Use API_KEY to accept results data
994         https://bugs.webkit.org/show_bug.cgi?id=196461
995
996         Reviewed by Dewei Zhu.
997
998         * BuildSlaveSupport/ews-app/ews/views/results.py:
999         (Results.post): Validate EWS_API_KEY before accepting any data.
1000         * BuildSlaveSupport/ews-build/events.py:
1001         (Events.sendData): Send EWS_API_KEY if available along with event data.
1002
1003 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1004
1005         Unable to copy and paste a PDF from Notes into Mail compose body
1006         https://bugs.webkit.org/show_bug.cgi?id=196442
1007         <rdar://problem/48573098>
1008
1009         Reviewed by Tim Horton.
1010
1011         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1012         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1013         to be specified on the item providers.
1014
1015         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1016         (TestWebKitAPI::mapItemForTesting):
1017         (TestWebKitAPI::contactItemForTesting):
1018
1019 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1020
1021         Make UIWKDocumentContext rects per-character instead of per-word
1022         https://bugs.webkit.org/show_bug.cgi?id=196459
1023
1024         Reviewed by Wenson Hsieh.
1025
1026         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1027         (TEST):
1028         Adjust test results due to switching to per-character rects.
1029
1030 2019-04-01  Chris Dumez  <cdumez@apple.com>
1031
1032         UIProcess crash when a prewarmed process is terminated
1033         https://bugs.webkit.org/show_bug.cgi?id=196451
1034         <rdar://problem/49245471>
1035
1036         Reviewed by Geoffrey Garen.
1037
1038         Add API test coverage.
1039
1040         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1041         (TEST):
1042
1043 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1044
1045         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1046         https://bugs.webkit.org/show_bug.cgi?id=196449
1047
1048         Reviewed by Lucas Forschler.
1049
1050         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1051         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1052         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1053         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1054
1055 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1056
1057         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1058         https://bugs.webkit.org/show_bug.cgi?id=196444
1059
1060         Reviewed by Lucas Forschler.
1061
1062         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1063
1064 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1065
1066         Add SPI to canonicalize NSURLs with WTF::URL
1067         https://bugs.webkit.org/show_bug.cgi?id=196415
1068         <rdar://problem/44980271>
1069
1070         Reviewed by Darin Adler.
1071
1072         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1073         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1074         (TestWebKitAPI::TEST):
1075
1076 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1077
1078         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1079         https://bugs.webkit.org/show_bug.cgi?id=196441
1080
1081         Reviewed by Carlos Garcia Campos.
1082
1083         Don't cache the wpe_view_backend object that might not exist yet at the
1084         time of EventSenderProxy constructor invocation, but instead retrieve
1085         that object whenever it's required for event dispatching. This should
1086         avoid crashes in this constructor now that it's invoked before any
1087         PlatformWindow has been set up (as changed in r243496).
1088
1089         * WebKitTestRunner/EventSenderProxy.h:
1090         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1091         (WTR::viewBackend):
1092         (WTR::EventSenderProxy::EventSenderProxy):
1093         (WTR::EventSenderProxy::mouseDown):
1094         (WTR::EventSenderProxy::mouseUp):
1095         (WTR::EventSenderProxy::mouseMoveTo):
1096         (WTR::EventSenderProxy::mouseScrollBy):
1097         (WTR::EventSenderProxy::keyDown):
1098         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1099
1100 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1101
1102         [Win][WebKit] MiniBrowser should support high DPI display
1103         https://bugs.webkit.org/show_bug.cgi?id=196391
1104
1105         Reviewed by Alex Christensen.
1106
1107         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1108         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1109         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1110         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1111
1112 2019-03-31  Sam Weinig  <weinig@apple.com>
1113
1114         Remove more i386 specific configurations
1115         https://bugs.webkit.org/show_bug.cgi?id=196430
1116
1117         Reviewed by Alexey Proskuryakov.
1118
1119         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1120         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1121
1122 2019-03-31  Andy Estes  <aestes@apple.com>
1123
1124         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1125         https://bugs.webkit.org/show_bug.cgi?id=196433
1126         <rdar://problem/49293305>
1127
1128         Reviewed by Tim Horton.
1129
1130         Enhanced API test coverage to include all navigation response policy decisions in both
1131         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1132
1133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1134         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1135         (TestWebKitAPI::TEST):
1136         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1137         (readFile):
1138         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1139         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1140         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1141         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1142         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1143         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1144         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1145         (-[QuickLookDelegate _downloadDidStart:]):
1146         (-[QuickLookDelegate _download:didReceiveResponse:]):
1147         (-[QuickLookDelegate _download:didReceiveData:]):
1148         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1149         (-[QuickLookDelegate _downloadDidFinish:]):
1150         (-[QuickLookDelegate _download:didFailWithError:]):
1151         (-[QuickLookDelegate _downloadDidCancel:]):
1152         (-[QuickLookDelegate verifyDownload]):
1153         (runTest):
1154         (runTestDecideBeforeLoading):
1155         (runTestDecideAfterLoading):
1156         (TEST):
1157         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1158         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1159         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1160         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1161         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1162         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1163         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1164         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1165         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1166         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1167         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1168         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1169         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1170         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1171
1172 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1173
1174         [CMake] add testdfg as target with build-jsc
1175         https://bugs.webkit.org/show_bug.cgi?id=196393
1176
1177         Reviewed by Saam Barati.
1178
1179         Added testdfg as one of the targets to build when
1180         using CMake.
1181
1182         * Scripts/build-jsc:
1183
1184 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1185
1186         Delete WebMetal implementation in favor of WebGPU
1187         https://bugs.webkit.org/show_bug.cgi?id=195418
1188
1189         Reviewed by Dean Jackson.
1190
1191         * DumpRenderTree/mac/DumpRenderTree.mm:
1192         (enableExperimentalFeatures):
1193         (resetWebPreferencesToConsistentValues):
1194         * Scripts/webkitperl/FeatureList.pm:
1195         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1197         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1198         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1199         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1200         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1201         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1202         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1203         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1204         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1205         (WTR::InjectedBundle::beginTesting):
1206         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1207         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1208         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1209
1210 2019-03-29  Chris Dumez  <cdumez@apple.com>
1211
1212         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1213         https://bugs.webkit.org/show_bug.cgi?id=196405
1214         <rdar://problem/49428130>
1215
1216         Reviewed by Wenson Hsieh.
1217
1218         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1219         the popover presentation methods to be no-ops. Use this in the new test added in
1220         r243523 so that we do not swizzle those methods for all tests. This is needed because
1221         those WatchOS tests rely on the popover getting presented and interactive.
1222
1223         * WebKitTestRunner/TestController.cpp:
1224         (WTR::updateTestOptionsFromTestHeader):
1225         * WebKitTestRunner/TestController.h:
1226         * WebKitTestRunner/TestOptions.h:
1227         (WTR::TestOptions::hasSameInitializationOptions const):
1228         * WebKitTestRunner/ios/TestControllerIOS.mm:
1229         (WTR::TestController::platformInitialize):
1230         (WTR::TestController::platformResetStateToConsistentValues):
1231
1232 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1233
1234         [Curl] Add Server Trust Evaluation Support.
1235         https://bugs.webkit.org/show_bug.cgi?id=191646
1236
1237         Reviewed by Fujii Hironori.
1238
1239         Implemented MiniBrowser UI for asking if user trusts the server.
1240
1241         * MiniBrowser/win/Common.cpp:
1242         (askServerTrustEvaluation):
1243         (replaceString):
1244         * MiniBrowser/win/Common.h:
1245         * MiniBrowser/win/MiniBrowserLib.rc:
1246         * MiniBrowser/win/MiniBrowserLibResource.h:
1247         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1248         (createPEMString):
1249         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1250         (WebKitBrowserWindow::canTrustServerCertificate):
1251         * MiniBrowser/win/WebKitBrowserWindow.h:
1252
1253 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1254
1255         Implement ResizeObserver.
1256         https://bugs.webkit.org/show_bug.cgi?id=157743
1257
1258         Reviewed by Simon Fraser.
1259
1260         Support resizeObserverEnabled webPreferences.
1261
1262         * DumpRenderTree/TestOptions.cpp:
1263         (TestOptions::TestOptions):
1264         * DumpRenderTree/TestOptions.h:
1265         * DumpRenderTree/mac/DumpRenderTree.mm:
1266         (setWebPreferencesForTestOptions):
1267         * DumpRenderTree/win/DumpRenderTree.cpp:
1268         (enableExperimentalFeatures):
1269         * Scripts/webkitperl/FeatureList.pm:
1270         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1271
1272 2019-03-28  John Wilander  <wilander@apple.com>
1273
1274         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1275         https://bugs.webkit.org/show_bug.cgi?id=196281
1276         <rdar://problem/48938748>
1277
1278         Reviewed by Alex Christensen.
1279
1280         This patch adds the function isStatisticsHasLocalStorage() to the
1281         TestRunner. With it, the page can query the WebsiteDataStore in the
1282         UI process to make sure that it sees LocalStorage.
1283
1284         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1285         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1286         (WTR::TestRunner::isStatisticsHasLocalStorage):
1287         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1288         * WebKitTestRunner/TestController.cpp:
1289         (WTR::TestController::isStatisticsHasLocalStorage):
1290         * WebKitTestRunner/TestController.h:
1291         * WebKitTestRunner/TestInvocation.cpp:
1292         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1293
1294 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1295
1296         API::Data::createWithoutCopying should do a null check before calling CFRelease
1297         https://bugs.webkit.org/show_bug.cgi?id=196276
1298         <rdar://problem/48059859>
1299
1300         Reviewed by Alex Christensen.
1301
1302         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1303
1304         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1305         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1306         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1307         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1308         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1309         (TestWebKitAPI::TEST):
1310
1311 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1312
1313         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1314         https://bugs.webkit.org/show_bug.cgi?id=186276
1315
1316         Reviewed by Carlos Garcia Campos.
1317
1318         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1319         (webViewLoadChanged):
1320         (testWebResourceGetDataError):
1321         (testWebResourceGetDataEmpty):
1322         (beforeAll):
1323         (webViewloadChanged): Deleted.
1324
1325 2019-03-27  Andy Estes  <aestes@apple.com>
1326
1327         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1328         https://bugs.webkit.org/show_bug.cgi?id=196317
1329
1330         Reviewed by Dan Bernstein.
1331
1332         package-root copies built products into a staging directory using ditto(1), which does not
1333         follow symbolic links as it traverses a directory. Now that the files in
1334         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1335         itself, these become broken links when ditto'd into the staging directory.
1336
1337         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1338
1339         * Scripts/package-root:
1340
1341 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1342
1343         [ews-app] Update display text of Submit for ews analysis
1344         https://bugs.webkit.org/show_bug.cgi?id=196309
1345
1346         Reviewed by Dewei Zhu.
1347
1348         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1349
1350 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1351
1352         run-webkit-tests should check for leaks in WebKit processes
1353         <https://webkit.org/b/193772>
1354         <rdar://problem/46526680>
1355
1356         Reviewed by Ryosuke Niwa.
1357
1358         This works by doing the following:
1359         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1360           The list of child processes are returned one per line:
1361           process.name: pid
1362         - Run the "#LIST CHILD PROCESSES" command just before the
1363           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1364           processes on the ServerProcess object.
1365         - When the `--leaks` switch is handled, run check_for_leaks() on
1366           each child process after the main test harness.
1367
1368         * DumpRenderTree/mac/DumpRenderTree.mm:
1369         (handleControlCommand):
1370         - Use strncmp() instead of strcmp().
1371         - Add support for handling "#LIST CHILD PROCESSES" command.
1372
1373         * Scripts/webkitpy/port/base.py:
1374         (Port.check_for_leaks):
1375         * Scripts/webkitpy/port/darwin.py:
1376         (DarwinPort.check_for_leaks):
1377         - Rename redundant 'process_pid' argument to 'process_id'.
1378
1379         * Scripts/webkitpy/port/driver.py:
1380         (Driver.do_post_tests_work):
1381         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1382           longer the only command this sends to WebKitTestRunner.
1383         - If the `--leaks` switch is present, send the
1384           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1385           result using Port.set_webkit_processes().
1386         (Driver._parse_child_processes_output):
1387         - Add helper method to parse list of child process names and
1388           process IDs returned from WebKitTestRunner.
1389
1390         * Scripts/webkitpy/port/ios_device.py:
1391         (IOSDevicePort.check_for_leaks):
1392         - Rename redundant 'process_pid' argument to 'process_id'.
1393
1394         * Scripts/webkitpy/port/leakdetector.py:
1395         (LeakDetector._parse_leaks_output):
1396         - Return early if there is no leaks_output.
1397         (LeakDetector.check_for_leaks):
1398         - Rename redundant 'process_pid' argument to 'process_id'.
1399
1400         * Scripts/webkitpy/port/server_process.py:
1401         (ServerProcess.__init__):
1402         (ServerProcess.child_processes):
1403         (ServerProcess.set_child_processes):
1404         - Add instance variable to Port to store list of child process
1405           names and process IDs returned from WebKitTestRunner.
1406         (ServerProcess._start):
1407         - Clear self._child_processes.
1408         (ServerProcess.stop):
1409         - If self._child_processes is set, call
1410           self._port.check_for_leaks() for each child process.
1411
1412         * Scripts/webkitpy/port/server_process_unittest.py:
1413         (TrivialMockPort.check_for_leaks):
1414         - Rename redundant 'process_pid' argument to 'process_id'.
1415
1416         * Scripts/webkitpy/port/simulator_process.py:
1417         (SimulatorProcess.stop):
1418         - If self._child_processes is set, call
1419           self._port.check_for_leaks() for each child process.
1420
1421         * Scripts/webkitpy/port/watch_device.py:
1422         (WatchDevicePort.check_for_leaks):
1423         - Rename redundant 'process_pid' argument to 'process_id'.
1424
1425         * WebKitTestRunner/TestController.cpp:
1426         (WTR::TestController::dumpResponse):
1427         - Extract method from findAndDumpWorldLeaks() so that it may be
1428           reused by findAndDumpWebKitProcessIdentifiers().
1429         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1430         - Add method to output process name and process ID of both the
1431           WebContent and Networking processes.
1432         (WTR::TestController::findAndDumpWorldLeaks):
1433         - Fix missing newline in output when there were no abandoned
1434           documents.
1435         - Call dumpResponse() for extracted code.
1436         (WTR::TestController::handleControlCommand):
1437         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1438         - Use strncmp() instead of strcmp().
1439         - Call findAndDumpWebKitProcessIdentifiers() when
1440           "#LIST CHILD PROCESSES" command is sent.
1441         * WebKitTestRunner/TestController.h:
1442         (WTR::TestController::dumpResponse):
1443         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1444         - Declare methods.
1445
1446 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1447
1448         Unreviewed. Add GLib API test cases after r243434.
1449
1450         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1451         (testWebViewActiveURI):
1452         (serverCallback):
1453         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1454         (sendRequestCallback):
1455
1456 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1457
1458         Geolocation request not complete when watch request was started in a different web process
1459         https://bugs.webkit.org/show_bug.cgi?id=195996
1460
1461         Reviewed by Alex Christensen.
1462
1463         Add a test case.
1464
1465         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1466         (TestWebKitAPI::runJavaScriptAlert):
1467         (TestWebKitAPI::TEST):
1468
1469 2019-03-26  Keith Rollin  <krollin@apple.com>
1470
1471         Update the way generate-xcfilelists returns strings from functions
1472         https://bugs.webkit.org/show_bug.cgi?id=195975
1473         <rdar://problem/49040807>
1474
1475         Reviewed by Dean Jackson.
1476
1477         There are places where generate-xcfilelists executes assignments with
1478         statements like:
1479
1480             FOO=$(some_function)
1481
1482         where "some_function" return a string by echoing it. E.g.
1483
1484             some_function()
1485             {
1486                 echo "Hello, World"
1487             }
1488
1489         This is a common idiom, but it has a problem if "some_function" needs
1490         to call "exit" in an attempt to halt the entire script right then and
1491         there. Since "some_function" is called inside of $(), it's being
1492         executed in a sub-shell. Calling exit in that sub-shell simply exits
1493         that shell; it doesn't not exit the outer shell in which the main part
1494         of the script is still running. As such, the main script keeps
1495         executing when the intent was for the script to halt.
1496
1497         The solution to this is to use a different idiom for returning
1498         strings. The one we now is to pass in the name of the variable to
1499         receive the string result:
1500
1501             some_function()
1502             {
1503                 variable_name=$1
1504                 eval $variable_name ="Hello, World"
1505             }
1506
1507         The call site now looks like
1508
1509             some_function FOO
1510
1511         Because there's no invocation of a sub-shell, some_function can now
1512         call "exit" if it wants to, and the entire script will exit at that
1513         point.
1514
1515         * Scripts/generate-xcfilelists:
1516
1517 2019-03-26  Chris Dumez  <cdumez@apple.com>
1518
1519         Add basic layout test coverage for File Picker on iOS
1520         https://bugs.webkit.org/show_bug.cgi?id=196265
1521
1522         Reviewed by Wenson Hsieh.
1523
1524         Add layout test infrastructure to test the file picker on iOS.
1525
1526         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1527         (WTR::UIScriptController::dismissFilePicker):
1528         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1529         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1530         (WTR::UIScriptController::dismissFilePicker):
1531         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1532         * WebKitTestRunner/TestController.cpp:
1533         (WTR::TestController::createWebViewWithOptions):
1534         (WTR::updateTestOptionsFromTestHeader):
1535         * WebKitTestRunner/TestOptions.h:
1536         (WTR::TestOptions::hasSameInitializationOptions const):
1537         * WebKitTestRunner/ios/TestControllerIOS.mm:
1538         (overridePresentViewController):
1539         (WTR::TestController::platformInitialize):
1540         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1541         (WTR::UIScriptController::dismissFilePicker):
1542
1543 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1544
1545         Implement async paste method on UIWKInteractionViewProtocol
1546         https://bugs.webkit.org/show_bug.cgi?id=196267
1547         <rdar://problem/49236346>
1548
1549         Reviewed by Tim Horton.
1550
1551         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1552         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1553         are now a part of all iOS 12 internal SDKs.
1554
1555         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1556
1557         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1558         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1559
1560         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1561         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1562         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1563         * TestWebKitAPI/ios/UIKitSPI.h:
1564
1565 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1566
1567         [ews-build] Use PostgreSQL for ews.webkit.org database
1568         https://bugs.webkit.org/show_bug.cgi?id=196270
1569
1570         Reviewed by Lucas Forschler.
1571
1572         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1573
1574 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1575
1576         [ews] Reset simctl states on reboot
1577         https://bugs.webkit.org/show_bug.cgi?id=196260
1578
1579         Rubber-stamped by Aakash Jain.
1580
1581         * EWSTools/start-queue-mac.sh:
1582
1583 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1584
1585         [ews-build] Use PostgreSQL for ews-build database
1586         https://bugs.webkit.org/show_bug.cgi?id=196229
1587
1588         Reviewed by Lucas Forschler.
1589
1590         * BuildSlaveSupport/ews-build/master.cfg:
1591
1592 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1593
1594         [ews-build] Get master_hostname dynamically in master.cfg
1595         https://bugs.webkit.org/show_bug.cgi?id=196255
1596
1597         Reviewed by Lucas Forschler.
1598
1599         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1600         send events data in test mode.
1601
1602 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1603
1604         [ews-app] Set db_constraint to False for Foreign Keys
1605         https://bugs.webkit.org/show_bug.cgi?id=196252
1606
1607         Reviewed by Lucas Forschler.
1608
1609         * BuildSlaveSupport/ews-app/ews/models/build.py:
1610         * BuildSlaveSupport/ews-app/ews/models/step.py:
1611
1612 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1613
1614         [ews-build] is_test_mode_enabled should default to True
1615         https://bugs.webkit.org/show_bug.cgi?id=196248
1616
1617         Reviewed by Lucas Forschler.
1618
1619         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1620
1621 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1622
1623         [ews-app] Add webkitperl to ENABLED_QUEUES
1624         https://bugs.webkit.org/show_bug.cgi?id=196253
1625
1626         Reviewed by Lucas Forschler.
1627
1628         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1629
1630 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1631
1632         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1633         https://bugs.webkit.org/show_bug.cgi?id=196211
1634         rdar://problem/49110552
1635
1636         Reviewed by Tim Horton.
1637
1638         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1639         Make sure that EventSenderProxy always exists when running tests. We used to create
1640         it when resetting before the first test, which is a bit too late.
1641
1642         * WebKitTestRunner/TestController.h:
1643         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1644         (WTR::TestController::platformCreateWebView):
1645         (WTR::TestController::platformCreateOtherPage):
1646         (WTR::TestController::finishCreatingPlatformWebView):
1647         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1648         (WTR::PlatformWebView::PlatformWebView):
1649         Moved some code that made NSWindow use NSEvent during web view creation. We may
1650         need to move more if some other case us found, but this is enough for now.
1651
1652 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1653
1654         Unreviewed. Fix typo in GLib geolocation API after r243285.
1655
1656         gelocation -> geolocation.
1657
1658         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1659         (testGeolocationManagerWatchPosition):
1660
1661 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1662
1663         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1664         https://bugs.webkit.org/show_bug.cgi?id=196213
1665
1666         Reviewed by Geoff Garen.
1667
1668         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1669         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1670         (credentialWithIdentityAndKeychainPath):
1671         (-[ChallengeDelegate webView:didFinishNavigation:]):
1672         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1673         (TestWebKitAPI::TEST):
1674
1675 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1676
1677         Expected shouldn't assume its contained types are copyable
1678         https://bugs.webkit.org/show_bug.cgi?id=195986
1679
1680         Reviewed by JF Bastien.
1681
1682         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1683         (TestWebKitAPI::NonCopyable::operator== const):
1684         (TestWebKitAPI::NonCopyable::operator!= const):
1685         (TestWebKitAPI::TEST):
1686
1687 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1688
1689         Remove some now-unnecessary dynamic class lookup
1690         https://bugs.webkit.org/show_bug.cgi?id=196237
1691
1692         Reviewed by Simon Fraser.
1693
1694         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1695         (makeRequest):
1696         (TEST):
1697
1698 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1699
1700         Unreviewed, rolling out r243450.
1701
1702         AppleWin and WinCairo port builds get broken.
1703
1704         Reverted changeset:
1705
1706         "Add test for fix of #196095"
1707         https://bugs.webkit.org/show_bug.cgi?id=196097
1708         https://trac.webkit.org/changeset/243450
1709
1710 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1711
1712         Unreviewed, rolling out r243465.
1713         https://bugs.webkit.org/show_bug.cgi?id=196226
1714
1715         the test doesn't build (Requested by thorton on #webkit).
1716
1717         Reverted changeset:
1718
1719         "Do not terminate the NetworkProcess if a third party
1720         application sends a NSCredential with a SecIdentityRef"
1721         https://bugs.webkit.org/show_bug.cgi?id=196213
1722         https://trac.webkit.org/changeset/243465
1723
1724 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1725
1726         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1727         https://bugs.webkit.org/show_bug.cgi?id=196213
1728
1729         Reviewed by Geoff Garen.
1730
1731         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1732         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1733         (credentialWithIdentityAndKeychainPath):
1734         (-[ChallengeDelegate webView:didFinishNavigation:]):
1735         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1736         (TestWebKitAPI::TEST):
1737
1738 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1739
1740         [ews-build] Gracefully handle missing patch_id in events
1741         https://bugs.webkit.org/show_bug.cgi?id=196216
1742
1743         Reviewed by Lucas Forschler.
1744
1745         * BuildSlaveSupport/ews-build/events.py:
1746
1747 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1748
1749         [ews-build] use lz4 compression for improving buildbot performance
1750         https://bugs.webkit.org/show_bug.cgi?id=196155
1751
1752         Reviewed by Lucas Forschler.
1753
1754         * BuildSlaveSupport/ews-build/master.cfg:
1755
1756 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1757
1758         Pull some API testing helper methods out of TestWKWebView
1759         https://bugs.webkit.org/show_bug.cgi?id=196212
1760
1761         Reviewed by Tim Horton.
1762
1763         Refactor some more API testing utility methods, so that they can be used in
1764         tests that do not use TestWKWebView.
1765
1766         * TestWebKitAPI/cocoa/TestWKWebView.h:
1767         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1768         (-[WKWebView loadTestPageNamed:]):
1769         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1770         (-[WKWebView synchronouslyLoadHTMLString:]):
1771         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1772         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1773         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1774         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1775         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1776
1777 2019-03-25  Jer Noble  <jer.noble@apple.com>
1778
1779         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1780         https://bugs.webkit.org/show_bug.cgi?id=196097
1781
1782         Reviewed by Eric Carlson.
1783
1784         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1785
1786         * DumpRenderTree/mac/DumpRenderTree.mm:
1787         (resetWebPreferencesToConsistentValues):
1788         * WebKitTestRunner/TestController.cpp:
1789         (WTR::TestController::resetPreferencesToConsistentValues):
1790
1791 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1792
1793         Pull IPadUserInterfaceSwizzler out into a separate header file
1794         https://bugs.webkit.org/show_bug.cgi?id=196193
1795
1796         Reviewed by Anders Carlsson.
1797
1798         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1799         be used in other API tests.
1800
1801         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1802         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1803         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1804         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1805         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1806         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1807         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1808
1809 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1810
1811         Remove NavigatorContentUtils in WebCore/Modules
1812         https://bugs.webkit.org/show_bug.cgi?id=196070
1813
1814         Reviewed by Alex Christensen.
1815
1816         NavigatorContentUtils was to support the custom scheme spec [1].
1817         However, in WebKit side, no port has supported the feature in
1818         WebKit layer after EFL port was removed. So there has been the
1819         only IDL implementation of the NavigatorContentUtils in WebCore.
1820         So we don't need to keep the implementation in WebCore anymore.
1821
1822         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1823
1824         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1825
1826 2019-03-24  Andy Estes  <aestes@apple.com>
1827
1828         [watchOS] Remove unused Proximity Networking code
1829         https://bugs.webkit.org/show_bug.cgi?id=196188
1830
1831         Reviewed by Tim Horton.
1832
1833         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1834         (TEST):
1835
1836 2019-03-23  Keith Miller  <keith_miller@apple.com>
1837
1838         Refactor clz/ctz and fix getLSBSet.
1839         https://bugs.webkit.org/show_bug.cgi?id=196162
1840
1841         Reviewed by Saam Barati.
1842
1843         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1844
1845         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1846         (TestWebKitAPI::TEST):
1847
1848 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1849
1850         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1851         https://bugs.webkit.org/show_bug.cgi?id=196143
1852
1853         Reviewed by Michael Catanzaro.
1854
1855         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1856         directories.
1857
1858         * Scripts/webkitpy/style/checkers/cpp.py:
1859         (check_identifier_name_in_declaration):
1860         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1861         (WebKitStyleTest.test_names):
1862
1863 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1864
1865         [Flatpak] Manifest expanding fails for qt WPE extension
1866         https://bugs.webkit.org/show_bug.cgi?id=196148
1867
1868         Reviewed by Alex Christensen.
1869
1870         * flatpak/flatpakutils.py:
1871         (expand_submodules_recurse): The last recurse manifest expand
1872         iteration might lead to a single module so take it into account
1873         and don't try to recurse further.
1874
1875 2019-03-22  Chris Dumez  <cdumez@apple.com>
1876
1877         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1878         https://bugs.webkit.org/show_bug.cgi?id=195348
1879         <rdar://problem/48622090>
1880
1881         Reviewed by Alex Christensen.
1882
1883         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1884         to NO when test.options().shouldIgnoreMetaViewport is false.
1885
1886         * WebKitTestRunner/ios/TestControllerIOS.mm:
1887         (WTR::TestController::platformConfigureViewForTest):
1888
1889 2019-03-22  Chris Dumez  <cdumez@apple.com>
1890
1891         Prewarmed processes should be usable with any website data store
1892         https://bugs.webkit.org/show_bug.cgi?id=196104
1893
1894         Reviewed by Alex Christensen.
1895
1896         Add API test coverage.
1897
1898         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1899         (runInitialWarmedProcessUsedTest):
1900         (TEST):
1901
1902 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1903
1904         Back out local changes to Alex's Subversion working directory
1905
1906         They were accidentally committed.
1907
1908         * Scripts/webkitpy/common/system/abstractexecutive.py:
1909         (AbstractExecutive.wait_newest):
1910         * Scripts/webkitpy/common/system/executive.py:
1911         (Executive.running_pids):
1912         * Scripts/webkitpy/common/system/executive_mock.py:
1913         (MockExecutive.running_pids):
1914         * Scripts/webkitpy/common/system/executive_unittest.py:
1915         (ExecutiveTest.serial_test_running_pids):
1916         * Scripts/webkitpy/port/darwin.py:
1917         (DarwinPort.check_for_leaks):
1918         * Scripts/webkitpy/port/leakdetector.py:
1919         (LeakDetector.check_for_leaks):
1920         - This was the hack attached to Bug 193772.
1921
1922         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1923         (+[WebKitTestRunnerEvent mouseLocation]):
1924         - This works around a crash on an internal build.
1925
1926 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1927
1928         Fix the build after r243354
1929         https://bugs.webkit.org/show_bug.cgi?id=196138
1930         <rdar://problem/49145951>
1931
1932         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1933         (TEST):
1934         * TestWebKitAPI/ios/UIKitSPI.h:
1935
1936 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1937
1938         Adopt UIWKDocumentContext
1939         https://bugs.webkit.org/show_bug.cgi?id=196040
1940         <rdar://problem/48642440>
1941
1942         Reviewed by Ryosuke Niwa.
1943
1944         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1945         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1946         (makeRequest):
1947         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1948         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1949         (applyStyle):
1950         (TEST):
1951         Add tests for UIWKDocumentContext.
1952
1953         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1954         (TEST):
1955         (recursiveFindWKContentView): Deleted.
1956         * TestWebKitAPI/cocoa/TestWKWebView.h:
1957         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1958         (recursiveFindWKContentView):
1959         (-[TestWKWebView wkContentView]):
1960         * TestWebKitAPI/ios/UIKitSPI.h:
1961         Share the WKContentView finding code between tests.
1962
1963 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1964
1965         [iOS WK2] Turn on async overflow scrolling by default
1966         https://bugs.webkit.org/show_bug.cgi?id=196011
1967         rdar://problem/48453859
1968
1969         Reviewed by Antti Koivisto.
1970         
1971         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1972         since so many basic layout tests have different results when compositing is triggered for
1973         overflow.
1974         
1975         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1976
1977         * WebKitTestRunner/TestController.cpp:
1978         (WTR::TestController::resetPreferencesToConsistentValues):
1979
1980 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1981
1982         [ews-build] Retry API test in case of failures
1983         https://bugs.webkit.org/show_bug.cgi?id=196004
1984
1985         Reviewed by Lucas Forschler.
1986
1987         * BuildSlaveSupport/ews-build/steps.py:
1988         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1989         (CompileWebKitToT.doStepIf): Ditto.
1990         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1991         (ReRunAPITests): Re-run API tests.
1992         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1993         (RunAPITestsWithoutPatch): Run API tests without patch.
1994         (RunAPITestsWithoutPatch.doStepIf):
1995         (RunAPITestsWithoutPatch.hideStepIf):
1996         (RunAPITestsWithoutPatch.evaluateCommand):
1997         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1998         (AnalyzeAPITestsResults.start):
1999         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2000         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2001         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2002         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2003
2004 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2005
2006         [ews-build] Update queues configurations
2007         https://bugs.webkit.org/show_bug.cgi?id=196074
2008
2009         Reviewed by Dewei Zhu.
2010
2011         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2012         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2013
2014 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2015
2016         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2017         https://bugs.webkit.org/show_bug.cgi?id=195680
2018         <rdar://problem/48903534>
2019
2020         Unreviewed infrastructure fix.
2021
2022         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2023         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2024
2025 2019-03-21  Andy Estes  <aestes@apple.com>
2026
2027         [iOS] Apple Pay should be available in documents with no user agent scripts
2028         https://bugs.webkit.org/show_bug.cgi?id=196061
2029         <rdar://problem/48649391>
2030
2031         Reviewed by Brady Eidson.
2032
2033         Added API tests and related infrastructure.
2034
2035         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2036         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2037         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2038         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2039         (TestWebKitAPI::TEST):
2040         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2041         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2042         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2043         * TestWebKitAPI/cocoa/TestProtocol.mm:
2044         (-[TestProtocol startLoading]):
2045         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2046         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2047         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2048         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2049
2050 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2051
2052         REGRESSSION (r243297): webkitpy tests broken
2053         https://bugs.webkit.org/show_bug.cgi?id=196108
2054
2055         Reviewed by Aakash Jain.
2056
2057         r243297 updated contributors.json, which broke a few unit tests.
2058
2059         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2060         (IRCCommandTest.test_whois):
2061         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2062
2063 2019-03-21  Chris Dumez  <cdumez@apple.com>
2064
2065         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2066         https://bugs.webkit.org/show_bug.cgi?id=196041
2067         <rdar://problem/49083230>
2068
2069         Reviewed by Alex Christensen.
2070
2071         Add API test coverage.
2072
2073         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2074         (TEST):
2075
2076 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2077
2078         Add SPI to inform applications of WKContentRuleList actions
2079         https://bugs.webkit.org/show_bug.cgi?id=195965
2080         <rdar://problem/42664365>
2081
2082         Reviewed by Geoff Garen.
2083
2084         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2085         (TestWebKitAPI::allActionsForResourceLoad):
2086         (TestWebKitAPI::testRequest):
2087         (TestWebKitAPI::TEST_F):
2088         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2089         (Notification::description):
2090         (Notification::operator== const):
2091         (toVector):
2092         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2093         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2094         (makeContentRuleList):
2095         (TEST):
2096         (makeWarnContentRuleList): Deleted.
2097
2098 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2099
2100         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2101         https://bugs.webkit.org/show_bug.cgi?id=196088
2102
2103         Reviewed by Brian Burg.
2104
2105         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2106         Support checks when only one platform is specified. Also deprecate macosx() and
2107         force the use of macos() instead.
2108
2109         * Scripts/webkitpy/style/checkers/cpp.py:
2110         (check_min_versions_of_wk_api_available):
2111         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2112         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2113
2114 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2115
2116         Update status inactive committers' status to 'contributor'.
2117
2118         * Scripts/webkitpy/common/config/contributors.json:
2119
2120 2019-03-21  Xan Lopez  <xan@igalia.com>
2121
2122         [JSC][x86] Drop support for x87 floating point
2123         https://bugs.webkit.org/show_bug.cgi?id=194853
2124
2125         Reviewed by Don Olmstead.
2126
2127         Force SSE2 on x86/32bit builds.
2128
2129         * Scripts/webkitdirs.pm:
2130         (generateBuildSystemFromCMakeProject):
2131
2132 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2133
2134         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2135         https://bugs.webkit.org/show_bug.cgi?id=196073
2136
2137         Reviewed by Michael Catanzaro.
2138
2139         Add test cases to check functions and constructors with no arguments but receiving user data.
2140
2141         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2142         (checkUserData):
2143         (testJSCFunction):
2144         (fooCreateWithUserData):
2145         (testJSCClass):
2146
2147 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2148
2149         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2150
2151         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2152
2153         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2154
2155 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2156
2157         [GTK][WPE] Add API to provide geolocation information
2158         https://bugs.webkit.org/show_bug.cgi?id=195940
2159
2160         Reviewed by Michael Catanzaro.
2161
2162         Add a new test to check the new API.
2163
2164         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2165         (testGeolocationManagerCurrentPosition):
2166         (testGeolocationManagerWatchPosition):
2167         (beforeAll):
2168         (afterAll):
2169         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2170         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2171         (beforeAll): Ditto.
2172         * TestWebKitAPI/glib/CMakeLists.txt:
2173
2174 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2175
2176         [GLib] Returning G_TYPE_OBJECT from a method does not work
2177         https://bugs.webkit.org/show_bug.cgi?id=195574
2178
2179         Reviewed by Michael Catanzaro.
2180
2181         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2182
2183         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2184         (getGFile):
2185         (getParent):
2186         (createGString):
2187         (getGString):
2188         (getGStringCopyWillRaise):
2189         (getGStringCopy):
2190         (getGStringStr):
2191         (getGStringLen):
2192         (freeGString):
2193         (testJSCClass):
2194
2195 2019-03-20  Saam Barati  <sbarati@apple.com>
2196
2197         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2198         https://bugs.webkit.org/show_bug.cgi?id=195721
2199
2200         Reviewed by Filip Pizlo.
2201
2202         * Scripts/run-javascriptcore-tests:
2203
2204 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2205
2206         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2207         https://bugs.webkit.org/show_bug.cgi?id=196049
2208
2209         Reviewed by Tim Horton.
2210
2211         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2212         overflow scrolling in general, so rename it.
2213
2214         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2215
2216 2019-03-20  Daniel Bates  <dabates@apple.com>
2217
2218         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2219         https://bugs.webkit.org/show_bug.cgi?id=196031
2220         <rdar://problem/49078172>
2221
2222         Reviewed by Tim Horton.
2223
2224         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2225         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2226         same code path used when the Done button is pressed to dismiss the <select> picker.
2227
2228         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2229         (TestWebKitAPI::TEST):
2230
2231 2019-03-20  Chris Dumez  <cdumez@apple.com>
2232
2233         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2234         https://bugs.webkit.org/show_bug.cgi?id=196029
2235         <rdar://problem/48954651>
2236
2237         Reviewed by Tim Horton.
2238
2239         Add API test coverage.
2240
2241         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2242
2243 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2244
2245         [ews-build] Improve failure summary string for ApplyPatch step
2246         https://bugs.webkit.org/show_bug.cgi?id=195995
2247
2248         Reviewed by Alexey Proskuryakov.
2249
2250         * BuildSlaveSupport/ews-build/steps.py:
2251         (ApplyPatch.getResultSummary): Override getResultSummary.
2252
2253 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2254
2255         AX: Implement support for new meter ARIA role
2256         https://bugs.webkit.org/show_bug.cgi?id=195966
2257
2258         Reviewed by Chris Fleizach.
2259
2260         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2261         to AXLevelIndicator.
2262
2263         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2264
2265 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2266
2267         [WebAuthN] Implement FIDO AppID extension
2268         https://bugs.webkit.org/show_bug.cgi?id=143491
2269         <rdar://problem/48298273>
2270
2271         Reviewed by Brent Fulgham.
2272
2273         Add a test that covers the new flag of convertToU2fSignCommand.
2274
2275         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2276         (TestWebKitAPI::TEST):
2277         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2278         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2279         (TestWebKitAPI::TEST):
2280
2281 2019-03-19  Keith Rollin  <krollin@apple.com>
2282
2283         Add support for more platforms to generate-xcfilelists
2284         https://bugs.webkit.org/show_bug.cgi?id=195977
2285
2286         Reviewed by Alexey Proskuryakov.
2287
2288         generate-xcfilelists incorrectly complains when involved with building
2289         WebKit for iphonesimulator:
2290
2291             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2292             …
2293             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2294
2295         Address this by teaching generate-xcfilelists about more platforms.
2296
2297         * Scripts/generate-xcfilelists:
2298
2299 2019-03-19  John Wilander  <wilander@apple.com>
2300
2301         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2302         https://bugs.webkit.org/show_bug.cgi?id=195923
2303         <rdar://problem/49001272>
2304
2305         Reviewed by Alex Christensen.
2306
2307         This patch does the following to the TestRunner:
2308         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2309         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2310         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2311
2312         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2313         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2314         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2315         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2316         * WebKitTestRunner/TestController.cpp:
2317         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2318         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2319         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2320         * WebKitTestRunner/TestController.h:
2321         * WebKitTestRunner/TestInvocation.cpp:
2322         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2323
2324 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2325
2326         [CMake] Support more clang and gcc sanitizers
2327         https://bugs.webkit.org/show_bug.cgi?id=195956
2328
2329         Reviewed by Michael Catanzaro.
2330
2331         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2332
2333 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2334
2335         [ews-build] Improve summary for PrintConfiguration step
2336         https://bugs.webkit.org/show_bug.cgi?id=195945
2337
2338         Reviewed by Lucas Forschler.
2339
2340         * BuildSlaveSupport/ews-build/steps.py:
2341         (PrintConfiguration.getResultSummary): Override getResultSummary.
2342
2343 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2344
2345         [ews-build] Improve summary for CheckOutSource step
2346         https://bugs.webkit.org/show_bug.cgi?id=195963
2347
2348         Reviewed by Lucas Forschler.
2349
2350         * BuildSlaveSupport/ews-build/steps.py:
2351         (CheckOutSource.getResultSummary):
2352
2353 2019-03-19  Daniel Bates  <dabates@apple.com>
2354
2355         [iOS] Focus not preserved when switching between tabs
2356         https://bugs.webkit.org/show_bug.cgi?id=195820
2357         <rdar://problem/43614450>
2358
2359         Reviewed by Brent Fulgham.
2360
2361         Add tests to ensure that we restore focus when resigning and becoming first responder.
2362
2363         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2364         (TestWebKitAPI::TEST):
2365
2366 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2367
2368         Make WTFLogChannelState and WTFLogLevel enum classes
2369         https://bugs.webkit.org/show_bug.cgi?id=195904
2370
2371         Reviewed by Eric Carlson.
2372
2373         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2374         (TestWebKitAPI::TEST_F):
2375
2376 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2377
2378         [GStreamer][EME] Backported mssdemux protection data crash fix
2379         https://bugs.webkit.org/show_bug.cgi?id=195918
2380
2381         Reviewed by Philippe Normand.
2382
2383         * gstreamer/jhbuild.modules:
2384         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2385
2386 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2387
2388         Unreviewed, rolling out r243132.
2389
2390         Broke GTK build
2391
2392         Reverted changeset:
2393
2394         "Make WTFLogChannelState and WTFLogLevel enum classes"
2395         https://bugs.webkit.org/show_bug.cgi?id=195904
2396         https://trac.webkit.org/changeset/243132
2397
2398 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2399
2400         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2401
2402         * Scripts/webkitdirs.pm:
2403         (builtDylibPathForName): Adjust the shared library name that's changed
2404         with the API version bump in r243073.
2405
2406 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2407
2408         Make WTFLogChannelState and WTFLogLevel enum classes
2409         https://bugs.webkit.org/show_bug.cgi?id=195904
2410
2411         Reviewed by Eric Carlson.
2412
2413         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2414         (TestWebKitAPI::TEST_F):
2415
2416 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2417
2418         Disable flaky test added in r2431100
2419         https://webkit.org/b/195785
2420
2421         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2422         (TestWebKitAPI::TEST):
2423         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2424
2425 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2426
2427         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2428         https://bugs.webkit.org/show_bug.cgi?id=195916
2429
2430         Reviewed by Tim Horton.
2431
2432         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2433         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2434
2435 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2436
2437         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2438
2439         * Scripts/webkitpy/common/config/contributors.json:
2440
2441 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2442
2443         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2444         https://bugs.webkit.org/show_bug.cgi?id=195785
2445
2446         Reviewed by Geoffrey Garen.
2447
2448         * TestWebKitAPI/TCPServer.cpp: Added.
2449         (TestWebKitAPI::TCPServer::TCPServer):
2450         (TestWebKitAPI::TCPServer::~TCPServer):
2451         (TestWebKitAPI::TCPServer::socketBindListen):
2452         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2453         * TestWebKitAPI/TCPServer.h: Added.
2454         (TestWebKitAPI::TCPServer::port const):
2455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2456         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2457         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2458         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2459         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2460         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2461         (TestWebKitAPI::respondSlowly):
2462         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2463         (TestWebKitAPI::downloadAtRate):
2464         (TestWebKitAPI::TEST):
2465
2466 2019-03-18  Saam Barati  <sbarati@apple.com>
2467
2468         Add a plan file for JetStream 2
2469         https://bugs.webkit.org/show_bug.cgi?id=190734
2470
2471         Reviewed by Mark Lam.
2472
2473         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2474
2475 2019-03-18  Chris Dumez  <cdumez@apple.com>
2476
2477         Delay WebProcess launch until a load is triggered in a Web view
2478         https://bugs.webkit.org/show_bug.cgi?id=195758
2479         <rdar://problem/48126013>
2480
2481         Reviewed by Geoff Garen.
2482
2483         Add API test coverage. Also update some existing API tests to not expect
2484         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2485
2486         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2487         (TestWebKitAPI::TEST):
2488         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2489         (TestWebKitAPI::TEST):
2490         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2491         (TEST):
2492         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2493         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2494         (TEST):
2495         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2496         (TEST):
2497         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2498
2499 2019-03-18  Xan Lopez  <xan@igalia.com>
2500
2501         [CMake] Prevent potential warning when determining $architecture
2502         https://bugs.webkit.org/show_bug.cgi?id=195891
2503
2504         Reviewed by Michael Catanzaro.
2505
2506         It's possible for generateBuildSystemForCMakeProject to be called
2507         before determineArchitecture() is ever called. This will make the
2508         first eq check with $architecture to be bogus (and print a
2509         warning). Change that to an eq check with architecture(), which
2510         implicitly calls determineArchitecture() if needed, and change all
2511         the other similar cases in the method in the same way to prevent
2512         future bugs like this one.
2513
2514         * Scripts/webkitdirs.pm:
2515         (generateBuildSystemFromCMakeProject):
2516
2517 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2518
2519         [WPE] Tarballs generated with “make dist” cannot build documentation
2520         https://bugs.webkit.org/show_bug.cgi?id=195885
2521
2522         Reviewed by Carlos Garcia Campos.
2523
2524         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2525
2526 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2527
2528         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2529         https://bugs.webkit.org/show_bug.cgi?id=195883
2530
2531         Reviewed by Carlos Garcia Campos.
2532
2533         * gtkdoc/gtkdoc.py:
2534         (GTKDoc._run_command): When commands fail to run, include the full command line for
2535         the program invocation and the output it has generated on the standard error stream.
2536
2537 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2538
2539         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2540         https://bugs.webkit.org/show_bug.cgi?id=195786
2541
2542         Reviewed by Philippe Normand.
2543
2544         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2545         * wpe/jhbuild.modules: Ditto.
2546
2547 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2548
2549         [ews-build] Don't run clean builds on EWS builders
2550         https://bugs.webkit.org/show_bug.cgi?id=195851
2551
2552         Reviewed by Geoffrey Garen.
2553
2554         * BuildSlaveSupport/ews-build/factories.py:
2555
2556 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2557
2558         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2559         https://bugs.webkit.org/show_bug.cgi?id=195849
2560
2561         Reviewed by Chris Dumez.
2562
2563         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2564
2565         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2566         (runWebsiteDataStoreCustomPaths):
2567
2568 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2569
2570         webkitpy: Upload test results
2571         https://bugs.webkit.org/show_bug.cgi?id=195755
2572         <rdar://problem/48896182>
2573
2574         Reviewed by Aakash Jain.
2575
2576         Establish a new format for uploading results that is not tied to layout tests, apply
2577         that format to webkitpy tests.
2578
2579         * Scripts/webkitpy/common/checkout/scm/git.py:
2580         (Git.native_branch): Return what branch the current checkout is on.
2581         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2582         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2583         * Scripts/webkitpy/common/checkout/scm/svn.py:
2584         (SVN.native_branch): Ditto.
2585         * Scripts/webkitpy/common/system/platforminfo.py:
2586         (PlatformInfo.build_version): Return a build version for Mac.
2587         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2588         (MockPlatformInfo.__init__):
2589         (MockPlatformInfo.build_version):
2590         * Scripts/webkitpy/results: Added.
2591         * Scripts/webkitpy/results/__init__.py: Added.
2592         * Scripts/webkitpy/results/options.py: Added.
2593         (upload_options): OptParse list for upload options.
2594         * Scripts/webkitpy/results/upload.py: Added.
2595         (Upload): Class which enforces the upload format expected by the results server.
2596         (Upload.Expectations):
2597         (Upload.create_configuration):
2598         (Upload.create_commit):
2599         (Upload.create_details):
2600         (Upload.create_run_stats):
2601         (Upload.create_test_result):
2602         (Upload.__init__):
2603         (Upload.Encoder): Encode Upload object as json.
2604         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2605         * Scripts/webkitpy/results/upload_unittest.py: Added.
2606         * Scripts/webkitpy/test/main.py:
2607         (Tester._parse_args): Add upload arguments.
2608         (Tester._run_tests): Allow results to be uploaded.
2609         * Scripts/webkitpy/test/runner.py:
2610         (Runner.__init__): Record which tests were run, rather than just counting them.
2611         (Runner.handle):
2612         * Scripts/webkitpy/test/runner_unittest.py:
2613         (RunnerTest.test_run):
2614         * Scripts/webkitpy/thirdparty/__init__.py:
2615         (AutoinstallImportHook.find_module): Add requests auto-install.
2616         (AutoinstallImportHook._install_requests):
2617         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2618         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2619
2620 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2621
2622         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2623         https://bugs.webkit.org/show_bug.cgi?id=195810
2624
2625         Reviewed by Tim Horton.
2626
2627         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2628         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2629         ending certain layout tests.
2630
2631         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2632         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2633         (-[TestRunnerWKWebView dealloc]):
2634         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2635
2636         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2637         helper method when destroying the web view, and when resetting state between tests.
2638
2639         * WebKitTestRunner/ios/TestControllerIOS.mm:
2640         (WTR::TestController::platformResetStateToConsistentValues):
2641
2642         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2643
2644 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2645
2646         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2647         https://bugs.webkit.org/show_bug.cgi?id=190350
2648         <rdar://problem/45089503>
2649
2650         Reviewed by Geoffrey Garen.
2651
2652         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2653         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2654         (TEST):
2655         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2656         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2657         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2658         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2659         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2660         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2661         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2662         (runTest):
2663         (createDirectories):
2664         (TEST):
2665         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2666         (TEST):
2667         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2668         (TEST):
2669
2670 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2671
2672         Add support to WebPage for getting the contents as an attributed string.
2673         https://bugs.webkit.org/show_bug.cgi?id=195636
2674         rdar://problem/45055697
2675
2676         Reviewed by Tim Horton.
2677
2678         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2679         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2680
2681 2019-03-15  Chris Dumez  <cdumez@apple.com>
2682
2683         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2684         https://bugs.webkit.org/show_bug.cgi?id=195747
2685
2686         Reviewed by Geoff Garen.
2687
2688         Add API test coverage.
2689
2690         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2691
2692 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2693
2694         Unreviewed, rolling out r242952.
2695
2696         Causing API failures on iOS Simulator
2697
2698         Reverted changeset:
2699
2700         "[PSON] Make sure the WebProcessCache is leverage when
2701         relaunching a process after termination"
2702         https://bugs.webkit.org/show_bug.cgi?id=195747
2703         https://trac.webkit.org/changeset/242952
2704
2705 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2706
2707         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2708         https://bugs.webkit.org/show_bug.cgi?id=195740
2709
2710         Reviewed by Ross Kirsling.
2711
2712         window.open doesn't work for WebKitBrowserWindow because it is not
2713         implemented yet.
2714
2715         1. Implemented createNewPage callback of WKPageUIClient.
2716         2. Changed MainWindow to take a BrowserWindow factory function
2717           instead of BrowserWindowType to be flexible to create
2718           BrowserWindow with extra settings.
2719         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2720           because it is not relevant with MainWindow anymore.
2721
2722         * MiniBrowser/win/Common.cpp:
2723         (parseCommandLine):
2724         * MiniBrowser/win/Common.h:
2725         (CommandLineOptions::CommandLineOptions):
2726         * MiniBrowser/win/MainWindow.cpp:
2727         (MainWindow::MainWindow):
2728         (MainWindow::create):
2729         (MainWindow::init):
2730         (MainWindow::WndProc):
2731         * MiniBrowser/win/MainWindow.h:
2732         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2733         (PrintWebUIDelegate::createWebViewWithRequest):
2734         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2735         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2736         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2737         (WebKitBrowserWindow::updateProxySettings):
2738         (WebKitBrowserWindow::createNewPage):
2739         * MiniBrowser/win/WebKitBrowserWindow.h:
2740         * MiniBrowser/win/WinMain.cpp:
2741         (wWinMain):
2742
2743 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2744
2745         Make it possible to test scrolling tree layer manipulation more easily
2746         https://bugs.webkit.org/show_bug.cgi?id=195780
2747
2748         Reviewed by Tim Horton.
2749         
2750         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2751         cuts off communication of scrolling tree scrolls back to the web process
2752         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2753         allows tests to trigger scrolls which run the scrolling tree layer positioning
2754         logic, but never get another commit from the web process that might mask
2755         scrolling tree bugs.
2756         
2757         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2758         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2759         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2760
2761         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2762         (WTR::UIScriptController::scrollUpdatesDisabled const):
2763         (WTR::UIScriptController::setScrollUpdatesDisabled):
2764         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2765         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2766         (WTR::UIScriptController::scrollUpdatesDisabled const):
2767         (WTR::UIScriptController::setScrollUpdatesDisabled):
2768         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2769         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2770         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2771         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2772         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2773         * WebKitTestRunner/ios/TestControllerIOS.mm:
2774         (WTR::TestController::platformResetStateToConsistentValues):
2775         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2776         (WTR::UIScriptController::scrollUpdatesDisabled const):
2777         (WTR::UIScriptController::setScrollUpdatesDisabled):
2778
2779 2019-03-14  Youenn Fablet  <youenn@apple.com>
2780
2781         Move IDB storage in private browsing mode to NetworkProcess
2782         https://bugs.webkit.org/show_bug.cgi?id=195602
2783
2784         Reviewed by Brady Eidson.
2785
2786         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2787         (TEST):
2788
2789 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2790
2791         [ews-build] Make descriptionDone messages more readable
2792         https://bugs.webkit.org/show_bug.cgi?id=195760
2793
2794         Reviewed by Lucas Forschler.
2795
2796         * BuildSlaveSupport/ews-build/steps.py:
2797         * BuildSlaveSupport/ews-build/steps_unittest.py:
2798
2799 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2800
2801         [ews-build] Generate status-bubble hover-over messages
2802         https://bugs.webkit.org/show_bug.cgi?id=195680
2803
2804         Reviewed by Lucas Forschler.
2805
2806         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2807         (StatusBubble):
2808         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2809         on hover-over.
2810         (StatusBubble._iso_time):
2811         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2812         hover-over message.
2813         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2814
2815 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2816
2817         [ews-app] Gracefully handle the case when state_string is None
2818         https://bugs.webkit.org/show_bug.cgi?id=195753
2819
2820         Reviewed by Lucas Forschler.
2821
2822         * BuildSlaveSupport/ews-app/ews/models/build.py:
2823         * BuildSlaveSupport/ews-app/ews/models/step.py:
2824
2825 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2826
2827         [ews-app] Status bubble display pending for currently running build step
2828         https://bugs.webkit.org/show_bug.cgi?id=195744
2829
2830         Reviewed by Lucas Forschler.
2831
2832         * BuildSlaveSupport/ews-build/events.py:
2833         (Events.stepStarted): If state_string is pending, replace it with step name.
2834
2835 2019-03-14  Chris Dumez  <cdumez@apple.com>
2836
2837         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2838         https://bugs.webkit.org/show_bug.cgi?id=195750
2839
2840         Reviewed by Geoffrey Garen.
2841
2842         Add API test coverage.
2843
2844         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2845         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2846         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2847         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2848
2849 2019-03-14  Chris Dumez  <cdumez@apple.com>
2850
2851         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2852         https://bugs.webkit.org/show_bug.cgi?id=195747
2853
2854         Reviewed by Geoff Garen.
2855
2856         Add API test coverage.
2857
2858         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2859
2860 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2861
2862         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2863         https://bugs.webkit.org/show_bug.cgi?id=195725
2864         <rdar://problem/48545062>
2865
2866         Reviewed by Tim Horton.
2867
2868         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2869         handler is nil.
2870
2871         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2872         (TestWebKitAPI::TEST):
2873
2874 2019-03-13  Sam Weinig  <sam@webkit.org>
2875
2876         Add utility function to allow easy reverse range-based iteration of a container
2877         https://bugs.webkit.org/show_bug.cgi?id=195542
2878
2879         Reviewed by Antti Koivisto.
2880
2881         * TestWebKitAPI/CMakeLists.txt:
2882         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2883         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2884         (TestWebKitAPI::TEST):
2885         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2886
2887 2019-03-13  Chris Dumez  <cdumez@apple.com>
2888
2889         Use a ServiceWorker process per registrable domain
2890         https://bugs.webkit.org/show_bug.cgi?id=195649
2891
2892         Reviewed by Youenn Fablet.
2893
2894         Update API test coverage.
2895
2896         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2897
2898 2019-03-13  Chris Dumez  <cdumez@apple.com>
2899
2900         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2901         https://bugs.webkit.org/show_bug.cgi?id=195684
2902         <rdar://problem/48294714>
2903
2904         Reviewed by Antti Koivisto.
2905
2906         Add API test coverage.
2907
2908         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2909
2910 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2911
2912         [ews-app] Remove unused patch view
2913         https://bugs.webkit.org/show_bug.cgi?id=195669
2914
2915         Reviewed by Lucas Forschler.
2916
2917         * BuildSlaveSupport/ews-app/ews/urls.py:
2918         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2919
2920 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2921
2922         [ews-app] Use Buildbot result code variables
2923         https://bugs.webkit.org/show_bug.cgi?id=195668
2924
2925         Reviewed by Alexey Proskuryakov.
2926
2927         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2928         (Buildbot): Added Buildbot result code variables.
2929         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2930         (StatusBubble._build_bubble): Used Buildbot result code variables.
2931
2932 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2933
2934         [Flatpak] Expand submodule recursively
2935         https://bugs.webkit.org/show_bug.cgi?id=195672
2936
2937         Building WPE with flatpak was impossible without that as it was raising an exception.
2938         Also update wpebackend-fdo to match what is built in jhbuild
2939
2940         Reviewed by Philippe Normand.
2941
2942         * flatpak/flatpakutils.py:
2943         (expand_submodules_recurse):
2944         (expand_manifest):
2945         * flatpak/org.webkit.WPEModules.yaml:
2946
2947 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2948
2949         [ews-app] status bubble should be hidden for certain builds
2950         https://bugs.webkit.org/show_bug.cgi?id=194597
2951
2952         Reviewed by Dewei Zhu.
2953
2954         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2955         (StatusBubble._build_bubble):
2956         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2957         because the patch didn't have relevant changes.
2958         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2959         in production yet.
2960
2961 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2962
2963         [Win] Fix a slew of simple clang-cl warnings.
2964         https://bugs.webkit.org/show_bug.cgi?id=195652
2965
2966         Reviewed by Don Olmstead.
2967
2968         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2969         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2970
2971 2019-03-12  Justin Fan  <justin_fan@apple.com>
2972
2973         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2974         https://bugs.webkit.org/show_bug.cgi?id=195518
2975         <rdar://problem/46322356>
2976
2977         Reviewed by Myles C. Maxfield.
2978
2979         * DumpRenderTree/DerivedSources-input.xcfilelist:
2980         * DumpRenderTree/DerivedSources-output.xcfilelist:
2981
2982 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2983
2984         Unreviewed, rolling out r242825.
2985         https://bugs.webkit.org/show_bug.cgi?id=195648
2986
2987         "Broke webkitpy tests with my change to
2988         lldb_dump_class_layout.py" (Requested by rmorisset on
2989         #webkit).
2990
2991         Reverted changeset:
2992
2993         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2994         classes with suspicious padding"
2995         https://bugs.webkit.org/show_bug.cgi?id=195573
2996         https://trac.webkit.org/changeset/242825
2997
2998 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2999
3000         [ews-build] Show status bubbles while the patch is waiting in queue
3001         https://bugs.webkit.org/show_bug.cgi?id=195618
3002
3003         Reviewed by Lucas Forschler.
3004
3005         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3006         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3007         enabled in initial deployment.
3008         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3009         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3010         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3011         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3012         (StatusBubble._build_bubbles_for_patch):
3013
3014 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3015
3016         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3017         https://bugs.webkit.org/show_bug.cgi?id=195573
3018
3019         Reviewed by Simon Fraser.
3020
3021         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3022
3023         * Scripts/dump-class-layout:
3024         (main):
3025         * lldb/lldb_dump_class_layout.py:
3026         (ClassLayout.__init__):
3027         (ClassLayout._compute_padding_recursive):
3028         (LLDBDebuggerInstance.dump_layout_for_classname):
3029         (LLDBDebuggerInstance):
3030         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3031         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3032
3033 2019-03-12  Chris Dumez  <cdumez@apple.com>
3034
3035         Device Orientation access permission should be denied unless explicitly granted by the client
3036         https://bugs.webkit.org/show_bug.cgi?id=195625
3037
3038         Reviewed by Youenn Fablet.
3039
3040         add API test coverage.
3041
3042         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3043         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3044         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3045         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3046         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3047         (runDeviceOrientationTest):
3048         (TEST):
3049         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3050         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3051
3052 2019-03-12  Jer Noble  <jer.noble@apple.com>
3053
3054         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3055         https://bugs.webkit.org/show_bug.cgi?id=195137
3056         <rdar://problem/48810307>
3057
3058         Reviewed by Eric Carlson.
3059
3060         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3061         (TestWebKitAPI::TEST):
3062
3063 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3064
3065         [ews-build] Change urls from uat to production
3066         https://bugs.webkit.org/show_bug.cgi?id=195566
3067
3068         Reviewed by Lucas Forschler.
3069
3070         * BuildSlaveSupport/ews-app/ews/config.py:
3071         * BuildSlaveSupport/ews-build/events.py:
3072         * BuildSlaveSupport/ews-build/steps.py:
3073
3074 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3075
3076         [ews-build] change max_builds for local-worker to 1
3077         https://bugs.webkit.org/show_bug.cgi?id=195568
3078
3079         Reviewed by Lucas Forschler.
3080
3081         * BuildSlaveSupport/ews-build/loadConfig.py:
3082
3083 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3084
3085         Fix the build
3086
3087         * TestRunnerShared/spi/PencilKitTestSPI.h:
3088         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3089
3090 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3091
3092         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3093         https://bugs.webkit.org/show_bug.cgi?id=194131
3094
3095         Reviewed by Michael Catanzaro.
3096
3097         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3098         (uriChanged):
3099         (testUnfinishedSubresourceLoad):
3100         (serverCallback):
3101         (beforeAll):
3102
3103 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3104
3105         WTF::Expected should use std::addressof instead of operator&
3106         https://bugs.webkit.org/show_bug.cgi?id=195604
3107
3108         Reviewed by Myles Maxfield.
3109
3110         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3111         (TestWebKitAPI::Unique::Unique):
3112         (TestWebKitAPI::Unique::operator&):
3113         (TestWebKitAPI::TEST):
3114
3115 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3116
3117         Add Optional to Forward.h.
3118         https://bugs.webkit.org/show_bug.cgi?id=195586
3119
3120         Reviewed by Darin Adler.
3121
3122         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3123         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3124         Remove unnecessary includes from headers.
3125
3126 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3127
3128         Add testing API to hit-test and scroll overflow scrollers
3129         https://bugs.webkit.org/show_bug.cgi?id=195278
3130
3131         Reviewed by Antti Koivisto.
3132         
3133         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3134         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3135         
3136         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3137
3138         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3139         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3140         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3141         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3142         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3143         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3144         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3145         (WTR::enclosingScrollViewIncludingSelf):
3146         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3147
3148 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3149
3150         API test WebKit.RequestTextInputContext fails on iOS
3151         https://bugs.webkit.org/show_bug.cgi?id=195585
3152
3153         Reviewed by Wenson Hsieh and Simon Fraser.
3154
3155         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3156         (applyStyle):
3157         (TEST):
3158         Add a viewport, so that the coordinates match up on iOS.
3159         Scroll by moving the UIScrollView's contentOffset.
3160
3161 2019-03-11  Chris Dumez  <cdumez@apple.com>
3162
3163         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3164         https://bugs.webkit.org/show_bug.cgi?id=195506
3165         <rdar://problem/48733477>
3166
3167         Reviewed by Alex Christensen.
3168
3169         Add API test coverage.
3170
3171         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3172
3173 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3174
3175         Adding myself to contributors.json
3176
3177         Unreviewed, addming myself to contributors.json .
3178
3179         * Scripts/webkitpy/common/config/contributors.json:
3180
3181 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3182
3183         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3184         https://bugs.webkit.org/show_bug.cgi?id=195511
3185         <rdar://problem/44873269>
3186
3187         Reviewed by Darin Adler.
3188
3189         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3190         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3191         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3192         (TEST_F):
3193
3194 2019-03-11  Chris Dumez  <cdumez@apple.com>
3195
3196         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3197         https://bugs.webkit.org/show_bug.cgi?id=195561
3198
3199         Reviewed by Youenn Fablet.
3200
3201         Make sure the JS in the test requests for permission to receive device orientation events.
3202
3203         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3204
3205 2019-03-11  Youenn Fablet  <youenn@apple.com>
3206
3207         Allow storage quota increase by default in WTR
3208         https://bugs.webkit.org/show_bug.cgi?id=195541
3209
3210         Reviewed by Geoffrey Garen.
3211
3212         Allow storage quota increase by default in WTR.
3213         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3214         Use this for tests that explicitly need cache increase.
3215
3216         Instead of increasing quota by 2, make sure the next request is
3217         granted by adding all given parameters.
3218
3219         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3220         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3221         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3222         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3223         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3224         * WebKitTestRunner/TestController.cpp:
3225         (WTR::TestController::setAllowStorageQuotaIncrease):
3226         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3227         * WebKitTestRunner/TestController.h:
3228         * WebKitTestRunner/TestInvocation.cpp:
3229         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3230         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3231         (WTR::TestController::cocoaResetStateToConsistentValues):
3232         (WTR::TestController::setAllowStorageQuotaIncrease):
3233         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3234         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3235         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3236
3237 2019-03-11  Xan Lopez  <xan@igalia.com>
3238
3239         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3240         https://bugs.webkit.org/show_bug.cgi?id=194147
3241
3242         Reviewed by Michael Saboff.
3243
3244         To make --32-bit work correctly on Linux/64bit we need to:
3245
3246         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3247         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3248         unfortunately CMake only allows us to do this during
3249         crosscompilation, which is overkill here.
3250         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3251         pkg-config detection module uses the x86 .pc files instead of the
3252         x86_64 ones.
3253         - Set the -m32 flags for the compiler.
3254
3255         * Scripts/webkitdirs.pm:
3256         (generateBuildSystemFromCMakeProject):
3257
3258 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3259
3260         Add MotionMark-1.1 plan file for run-benchmark script.
3261         https://bugs.webkit.org/show_bug.cgi?id=195481
3262
3263         Rubber-stamped by Darin Adler.
3264
3265         Run-benchmark script should support MontionMark-1.1.
3266
3267         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3268
3269 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3270
3271         [ews-app] Add support for submit-to-ews url
3272         https://bugs.webkit.org/show_bug.cgi?id=195477
3273
3274         Reviewed by Lucas Forschler.
3275
3276         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3277         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3278         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3279         * BuildSlaveSupport/ews-app/ews/urls.py:
3280         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3281
3282 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3283
3284         Unreviewed, rolling out r242688, r242643, r242624.
3285
3286         Caused multiple layout test failures and crashes on iOS and macOS.
3287
3288         Reverted changeset:
3289
3290         "requestAnimationFrame should execute before the next frame"
3291         https://bugs.webkit.org/show_bug.cgi?id=177484
3292         https://trac.webkit.org/changeset/242624/webkit
3293
3294         * Tracing/SystemTracePoints.plist:
3295
3296 2019-03-11  John Wilander  <wilander@apple.com>
3297
3298         Resource Load Statistics: Make it possible exclude localhost from classification
3299         https://bugs.webkit.org/show_bug.cgi?id=195474
3300         <rdar://problem/47520577>
3301
3302         Reviewed by Brent Fulgham.
3303
3304         This patch allows for localhost to be excluded from classification and
3305         treatment as a prevalent resource.
3306
3307         The WebKit Tools change adds a new function called
3308         testRunner.setStatisticsIsRunningTest() which can be used to control this
3309         behavior.
3310
3311         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3312         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3313         (WTR::TestRunner::setStatisticsIsRunningTest):
3314         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3315         * WebKitTestRunner/TestController.cpp:
3316         (WTR::TestController::setStatisticsIsRunningTest):
3317         * WebKitTestRunner/TestController.h:
3318         * WebKitTestRunner/TestInvocation.cpp:
3319         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3320
3321 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3322
3323         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3324         https://bugs.webkit.org/show_bug.cgi?id=195560
3325
3326         Reviewed by Lucas Forschler.
3327
3328         * BuildSlaveSupport/ews-build/master.cfg:
3329
3330 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3331
3332         Unreviewed, rolling out r242698.
3333
3334         API test crashes on bots.
3335
3336         Reverted changeset:
3337
3338         "Add a WKContentRuleList variant that uses copied memory
3339         instead of mmap'd shared memory for class A containerized
3340         apps"
3341         https://bugs.webkit.org/show_bug.cgi?id=195511
3342         https://trac.webkit.org/changeset/242698
3343
3344 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3345
3346         [WPE] Enable web process sandbox
3347         https://bugs.webkit.org/show_bug.cgi?id=195169
3348
3349         Reviewed by Daniel Bates.
3350
3351         * wpe/install-dependencies:
3352         * wpe/jhbuild.modules:
3353
3354 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3355
3356         [ews-app] Use port 17000 for worker communication
3357         https://bugs.webkit.org/show_bug.cgi?id=195558
3358
3359         Reviewed by Lucas Forschler.
3360
3361         * BuildSlaveSupport/ews-build/master.cfg:
3362
3363 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3364
3365         [ews-build] unit-tests fail when passwords.json is missing
3366         https://bugs.webkit.org/show_bug.cgi?id=195557
3367
3368         Reviewed by Lucas Forschler.
3369
3370         * BuildSlaveSupport/ews-build/loadConfig.py:
3371         (loadBuilderConfig):
3372         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3373         (ConfigDotJSONTest.test_configuration):
3374         * BuildSlaveSupport/ews-build/master.cfg:
3375
3376 2019-03-11  Truitt Savell  <tsavell@apple.com>
3377
3378         Unreviewed, rolling out r242702.
3379
3380         Broke High Sierra builders.
3381
3382         Reverted changeset:
3383
3384         "Add utility function to allow easy reverse range-based
3385         iteration of a container"
3386         https://bugs.webkit.org/show_bug.cgi?id=195542
3387         https://trac.webkit.org/changeset/242702
3388
3389 2019-03-11  Sam Weinig  <sam@webkit.org>
3390
3391         Add utility function to allow easy reverse range-based iteration of a container
3392         https://bugs.webkit.org/show_bug.cgi?id=195542
3393
3394         Reviewed by Antti Koivisto.
3395
3396         * TestWebKitAPI/CMakeLists.txt:
3397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3398         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3399         (TestWebKitAPI::TEST):
3400         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3401
3402 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3403
3404         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3405         https://bugs.webkit.org/show_bug.cgi?id=195511
3406         <rdar://problem/44873269>
3407
3408         Reviewed by Darin Adler.
3409
3410         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3411         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3412         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3413         (TEST_F):
3414
3415 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3416
3417         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3418         https://bugs.webkit.org/show_bug.cgi?id=195499
3419
3420         Reviewed by Darin Adler.
3421
3422         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3423         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3424         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3425         (-[WKWebView synchronouslyFocusTextInputContext:]):
3426         (applyStyle):
3427         (applyIframe):
3428         (TEST):
3429         Add some tests for this SPI.
3430
3431 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3432
3433         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3434         https://bugs.webkit.org/show_bug.cgi?id=181151
3435
3436         Reviewed by Don Olmstead.
3437
3438         * TestWebKitAPI/CMakeLists.txt:
3439         * TestWebKitAPI/PlatformWin.cmake:
3440         Enable TestWTF RunLoop tests in all platforms.
3441
3442         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3443         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3444         (TestWebKitAPI::DerivedOneShotTimer::fired):
3445         (TestWebKitAPI::TEST):
3446         Only a few platforms support nested RunLoop.
3447
3448         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3449         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3450
3451 2019-03-10  David Quesada  <david_quesada@apple.com>
3452
3453         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3454         https://bugs.webkit.org/show_bug.cgi?id=152480
3455
3456         Reviewed by Chris Dumez.
3457
3458         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3459         there are no additional references to the process pool besides the one held by
3460         the download, waits for the download to finish (in the sense that the
3461         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3462         measure, also check that the process pool has been deallocated at the end of the
3463         test. The test wouldn't be meaningful if the process pool were still alive.
3464
3465         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3466         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3467         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3468             The download will be canceled because the delegate does not implement the
3469             method to decide the download's destination, so this is where we know the
3470             DownloadProxyMap is done with the DownloadProxy.
3471         (TEST):
3472
3473 2019-03-08  Chris Dumez  <cdumez@apple.com>
3474
3475         Add support for Device Orientation / Motion permission API
3476         https://bugs.webkit.org/show_bug.cgi?id=195329
3477         <rdar://problem/47645367>
3478
3479         Reviewed by Geoffrey Garen.
3480
3481         Add test infrastructure to help test the Device Orientation / Motion permission API.
3482
3483         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3484         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3485         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3486         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3487         * WebKitTestRunner/TestController.cpp:
3488         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3489         (WTR::TestController::createWebViewWithOptions):
3490         (WTR::TestController::resetStateToConsistentValues):
3491         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3492         * WebKitTestRunner/TestController.h:
3493         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3494         * WebKitTestRunner/TestInvocation.cpp:
3495         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3496
3497 2019-03-08  Saam barati  <sbarati@apple.com>
3498
3499         Add a compare-results script to compare benchmark results
3500         https://bugs.webkit.org/show_bug.cgi?id=195486
3501         <rdar://problem/48723397>
3502
3503         Reviewed by Geoffrey Garen.
3504
3505         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3506         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3507         to extend it to learn about our other benchmarks.
3508
3509         * Scripts/compare-results: Added.
3510         (readJSONFile):
3511         (detectJetStream2):
3512         (JetStream2Results):
3513         (detectSpeedometer2):
3514         (Speedometer2Results):
3515         (detectPLT5):
3516         (PLT5Results):
3517         (detectBenchmark):
3518         (biggerIsBetter):
3519         (ttest):
3520         (getOptions):
3521         (main):
3522
3523 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3524
3525         Ensure old tab state is cleared between iterations of run-benchmark
3526         https://bugs.webkit.org/show_bug.cgi?id=195393
3527         <rdar://problem/46885583>
3528
3529         Reviewed by Dewei Zhu.
3530
3531         a) ensure the default to restore state is not set
3532         b) terminate Safari correctly
3533         c) Set the system default to ignore Persistent State in Safari
3534
3535         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3536         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3537         (OSXBrowserDriver.prepare_env): 
3538         (OSXBrowserDriver.restore_env):
3539         (OSXBrowserDriver.close_browsers):
3540         (OSXBrowserDriver._terminate_processes):
3541         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3542         (OSXChromeDriver):
3543         (OSXChromeCanaryDriver):
3544         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3545         (OSXFirefoxDriver):
3546         (OSXFirefoxNightlyDriver):
3547         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3548         (OSXSafariDriver):
3549         (OSXSafariDriver.prepare_env):
3550
3551 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3552
3553         [GTK] Several InputMethodFilter tests are failing
3554         https://bugs.webkit.org/show_bug.cgi?id=195408
3555
3556         Reviewed by Carlos Garcia Campos.
3557
3558         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3559         Regressed in r241751.
3560         Hexadecimal values of keycodes are expressed now in upper letters.
3561         Composited characters should be cast to UTF8 strings.
3562
3563         (TestWebKitAPI::TEST):
3564
3565 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3566
3567         [GTK] Make Tools/gtkdoc python3 compatible
3568         https://bugs.webkit.org/show_bug.cgi?id=195359
3569
3570         Reviewed by Carlos Garcia Campos.
3571
3572         * gtkdoc/generate-gtkdoc:
3573         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3574         work with Python 2 and 3.
3575         (get_gtkdoc_module_paths):
3576         The iteritems() was removed in Python 3, so let's use items() that's
3577         available in Python 2 and 3.
3578         (get_generator_for_config):
3579         * gtkdoc/gtkdoc.py:
3580         (GTKDoc._run_command):
3581         The sys.stdout.write() is expecting str in Python 3 and not bytes
3582         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3583         for passing the bytes there.
3584
3585 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3586
3587         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3588         https://bugs.webkit.org/show_bug.cgi?id=195346
3589         <rdar://problem/48667048>
3590
3591         Unreviewed build fix for clang-cl.
3592
3593         * DumpRenderTree/win/DumpRenderTree.cpp:
3594         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3595
3596 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3597
3598         requestAnimationFrame should execute before the next frame
3599         https://bugs.webkit.org/show_bug.cgi?id=177484
3600
3601         Reviewed by Simon Fraser.
3602
3603         Add trace points for the page RenderingUpdate.
3604
3605         * Tracing/SystemTracePoints.plist:
3606
3607 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3608
3609         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3610         https://bugs.webkit.org/show_bug.cgi?id=195353
3611         <rdar://problem/48626394>
3612
3613         Reviewed by Simon Fraser.
3614
3615         * WebKitTestRunner/ios/TestControllerIOS.mm:
3616         (WTR::TestController::platformResetPreferencesToConsistentValues):
3617
3618 2019-03-07  John Wilander  <wilander@apple.com>
3619
3620         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3621         https://bugs.webkit.org/show_bug.cgi?id=195383
3622         <rdar://problem/48570136>
3623
3624         Reviewed by Brent Fulgham.
3625
3626         This patch adds test infrastructure to purge only script-accessible cookies,
3627         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3628
3629         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3630         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3631         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3632         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3633         * WebKitTestRunner/TestController.cpp:
3634         (WTR::TestController::statisticsDeleteCookiesForHost):
3635         * WebKitTestRunner/TestController.h:
3636         * WebKitTestRunner/TestInvocation.cpp:
3637         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3638
3639 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3640
3641         Unreviewed, rolling out r242354.
3642         https://bugs.webkit.org/show_bug.cgi?id=195402
3643
3644         breaks layout tests in all configurations (Requested by
3645         zdobersek on #webkit).
3646
3647         Reverted changeset:
3648
3649         "[WPE] Enable web process sandbox"
3650         https://bugs.webkit.org/show_bug.cgi?id=195169
3651         https://trac.webkit.org/changeset/242354
3652
3653 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3654
3655         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3656         https://bugs.webkit.org/show_bug.cgi?id=195346
3657
3658         Reviewed by Fujii Hironori.
3659
3660         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3661         (TestWebKitAPI::TEST):
3662         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3663
3664         * DumpRenderTree/win/DumpRenderTree.cpp:
3665         (findFontFallback):
3666         (addFontFallbackIfPresent):
3667         (removeFontFallbackIfPresent):
3668         (main):
3669         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3670         (TestWebKitAPI::Util::moduleDirectory):
3671         (TestWebKitAPI::Util::createInjectedBundlePath):
3672         Use wchar helpers as needed.
3673
3674 2019-03-06  Rob Buis  <rbuis@igalia.com>
3675
3676         Consider supporting the `referrerpolicy` attribute.
3677         https://bugs.webkit.org/show_bug.cgi?id=179053
3678
3679         Reviewed by Darin Adler.
3680
3681         Add a runtime flag for referrerpolicy attribute.
3682
3683         * DumpRenderTree/mac/DumpRenderTree.mm:
3684         (enableExperimentalFeatures):
3685
3686 2019-03-05  Daniel Bates  <dabates@apple.com>
3687
3688         Update expected API test result following r242379
3689         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3690
3691         Update expected x-coordinate of selection rect now that the left padding of
3692         a textarea is sized in ems (so dependent on the font size) just like the left
3693         padding of a text field.
3694
3695         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3696         (TestWebKitAPI::TEST):
3697
3698 2019-03-05  David Quesada  <david_quesada@apple.com>
3699
3700         [WK2] It should be possible to follow links with 'download' attributes
3701         https://bugs.webkit.org/show_bug.cgi?id=195145
3702         rdar://problem/48462642
3703
3704         Reviewed by Alex Christensen.
3705
3706         Add a unit test to verify that activating links with 'download' attributes now
3707         navigates to the linked resource, rather than starts downloading it. Add another
3708         to verify that it is still possible to explicitly download the link via the
3709         'Download' navigation action policy.
3710
3711         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3712         (-[DownloadAttributeTestDelegate init]):
3713         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3714         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3715         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3716         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3717         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3718         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3719         (TEST):
3720         * WebKitTestRunner/TestController.cpp:
3721         (WTR::TestController::decidePolicyForNavigationAction):
3722         * WebKitTestRunner/TestController.h:
3723
3724 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3725
3726         [Curl] Implement Cookie Accept Policy.
3727         https://bugs.webkit.org/show_bug.cgi?id=191645
3728
3729         Reviewed by Fujii Hironori.
3730
3731         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3732         (TestWebKitAPI::Curl::TEST_F):
3733
3734 2019-03-05  Youenn Fablet  <youenn@apple.com>
3735
3736         Rename requestCacheStorageSpace to requestStorageSpace
3737         https://bugs.webkit.org/show_bug.cgi?id=195282
3738
3739         Reviewed by Chris Dumez.
3740
3741         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3742         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3743         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3744
3745 2019-03-05  Brady Eidson  <beidson@apple.com>
3746
3747         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3748         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3749
3750         Reviewed by Tim Horton.
3751
3752         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3753         different directory into that same WKWebView should work.
3754
3755         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3756         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3757
3758 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3759
3760         Add WeakHashSet
3761         https://bugs.webkit.org/show_bug.cgi?id=195152
3762
3763         Reviewed by Antti Koivisto.
3764
3765         Added tests for WeakHashSet.
3766
3767         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3768         (TestWebKitAPI::Base::Base): Moved.
3769         (TestWebKitAPI::Derived::foo): Moved.
3770         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3771         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3772         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3773         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3774
3775 2019-03-04  Chris Dumez  <cdumez@apple.com>
3776
3777         Do not share WebProcesses between private and regular sessions
3778         https://bugs.webkit.org/show_bug.cgi?id=195189
3779         <rdar://problem/48421064>
3780
3781         Reviewed by Alex Christensen.
3782
3783         Add API test coverage.
3784
3785         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3786         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3787
3788 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3789
3790         [WPE] Enable web process sandbox
3791         https://bugs.webkit.org/show_bug.cgi?id=195169
3792
3793         Reviewed by Daniel Bates.
3794
3795         * wpe/install-dependencies:
3796         * wpe/jhbuild.modules:
3797
3798 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3799
3800         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3801         https://bugs.webkit.org/show_bug.cgi?id=195206
3802
3803         Reviewed by Žan Doberšek.
3804
3805         Add a new test case.
3806
3807         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3808         (testJSCClass):
3809
3810 2019-03-04  Charlie Turner  <cturner@igalia.com>
3811
3812         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3813         https://bugs.webkit.org/show_bug.cgi?id=194898
3814
3815         Reviewed by Žan Doberšek.
3816
3817         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3818         a GCC extension that permits arithmetic on void* pointer. Inline
3819         the macro until this issue is fixed upstream.
3820
3821 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3822
3823         Rid the world of WK_API_ENABLED
3824         https://bugs.webkit.org/show_bug.cgi?id=195263
3825
3826         Reviewed by Dan Bernstein.
3827
3828         List of changed files elided because it's useless.
3829
3830 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3831
3832         Unreviewed follow-up to r242292.
3833
3834         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3835
3836         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3837         (TestWebKitAPI::testStrip): Renamed from strip.
3838         (TestWebKitAPI::TEST):
3839
3840 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3841
3842         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3843
3844         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3845         and bug #194272 for details.
3846
3847         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3848
3849 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3850
3851         Remove some more unused 32-bit code
3852         https://bugs.webkit.org/show_bug.cgi?id=195255
3853
3854         Reviewed by Darin Adler.
3855
3856         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3857         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3858         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3859         (NPP_New):
3860         (NPP_HandleEvent):
3861         (handleEventCarbon): Deleted.
3862
3863 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3864
3865         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3866
3867         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3868         (TestWebKitAPI::TEST):
3869
3870 2019-03-01  Darin Adler  <darin@apple.com>
3871
3872         Finish removing String::format
3873         https://bugs.webkit.org/show_bug.cgi?id=194893
3874
3875         Reviewed by Daniel Bates.
3876 '
3877         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3878
3879 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3880
3881         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3882         https://bugs.webkit.org/show_bug.cgi?id=195229
3883         <rdar://problem/48520362>
3884
3885         Reviewed by Chris Dumez.
3886
3887         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3888         (TEST):
3889
3890 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3891
3892         Add a system trace scope for event region building
3893         https://bugs.webkit.org/show_bug.cgi?id=195226
3894
3895         Reviewed by Jon Lee.
3896
3897         This trace scope measures the time spend converting element rects into Region objects,
3898         which can be large on some pages.
3899
3900         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3901
3902         * Tracing/SystemTracePoints.plist:
3903
3904 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3905
3906         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3907         https://bugs.webkit.org/show_bug.cgi?id=194612
3908
3909         Reviewed by Alex Christensen.
3910
3911         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3912         Just test the new string-processing function and don't touch the actual environment.
3913         (Test cases are all as before, but based on operator== instead of strcmp.)
3914
3915 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3916
3917         [ews-app] Update primary keys for handling multiple Buildbot instances
3918         https://bugs.webkit.org/show_bug.cgi?id=195120
3919
3920         Reviewed by Stephanie Lewis.
3921
3922         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3923         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3924         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3925
3926         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3927         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3928         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3929         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3930         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3931         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3932
3933 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3934
3935         [WinCairo] Enable service worker
3936         https://bugs.webkit.org/show_bug.cgi?id=188318
3937
3938         Reviewed by Youenn Fablet.
3939
3940         * DumpRenderTree/DumpRenderTreePrefix.h:
3941         * TestWebKitAPI/PlatformWin.cmake:
3942         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3943         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3944         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3945
3946 2019-03-01  Justin Fan  <justin_fan@apple.com>
3947
3948         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3949         https://bugs.webkit.org/show_bug.cgi?id=195191
3950
3951         Rubber-stamped by Dean Jackson.
3952
3953         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3954
3955         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3956
3957 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3958
3959         Unreviewed, fix lldb webkitpy tests
3960         https://bugs.webkit.org/show_bug.cgi?id=194375
3961
3962         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3963
3964         * lldb/lldb_webkit.py:
3965         (WTFStringImplProvider.is_8bit):
3966
3967 2019-02-28  David Quesada  <david_quesada@apple.com>
3968
3969         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3970         https://bugs.webkit.org/show_bug.cgi?id=195121
3971         rdar://problem/48450302
3972
3973         Reviewed by Alex Christensen.
3974
3975         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3976         configurations where the 'download' attribute is absent, blank, or populated
3977         with a filename, and where the anchor element is same-origin or cross-origin
3978         (meaning the 'download' attribute shouldn't be honored).
3979
3980         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3981         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3982         (-[NavigationActionTestDelegate init]):
3983         (-[NavigationActionTestDelegate navigationAction]):
3984         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3985         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3986         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3987         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3988         (TEST):
3989
3990 2019-02-28  Antoine Quint  <graouts@apple.com>
3991
3992         Enable the Pointer Events runtime flag by default
3993         https://bugs.webkit.org/show_bug.cgi?id=195156
3994
3995         Reviewed by Dean Jackson.
3996
3997         * DumpRenderTree/mac/DumpRenderTree.mm:
3998         (enableExperimentalFeatures):
3999
4000 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4001
4002         Several PasteImage API tests are flaky
4003         https://bugs.webkit.org/show_bug.cgi?id=195160
4004
4005         Reviewed by Tim Horton.
4006
4007         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4008         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4009         listening for a "load" event after image load is already complete.
4010
4011         To address this, make these tests first register a "load" event handler, then run script to insert an image
4012         element into the document, and finally wait until the load event is observed before checking image size.
4013
4014         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4015
4016 2019-02-28  Chris Dumez  <cdumez@apple.com>
4017
4018         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4019         https://bugs.webkit.org/show_bug.cgi?id=195107
4020
4021         Reviewed by Alex Christensen.
4022
4023         Give some time for the zoom level to get restored.
4024
4025         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4026
4027 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4028
4029         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4030         https://bugs.webkit.org/show_bug.cgi?id=194958
4031
4032         Reviewed by Geoffrey Garen.
4033
4034         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4035         (TEST):
4036
4037 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4038
4039         [ews-app] Update method to save build to handle builder_display_name
4040         https://bugs.webkit.org/show_bug.cgi?id=195047
4041
4042         Reviewed by Dewei Zhu.
4043
4044         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4045         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4046
4047 2019-02-28  Justin Fan  <justin_fan@apple.com>
4048
4049         [Web GPU] Enable Web GPU only on 64-bit
4050         https://bugs.webkit.org/show_bug.cgi?id=195139
4051
4052         Because Metal is only supported on 64 bit apps.
4053
4054         Unreviewed build fix.
4055
4056         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4057
4058 2019-02-27  Youenn Fablet  <youenn@apple.com>
4059
4060         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4061         https://bugs.webkit.org/show_bug.cgi?id=194959
4062
4063         Reviewed by Chris Dumez.
4064
4065         Spin loop until getting the condition to remove flakiness.
4066
4067         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4068
4069 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4070
4071         [ews-build] Buildbot should include builder_display_name in the build events
4072         https://bugs.webkit.org/show_bug.cgi?id=195045
4073
4074         Reviewed by Dewei Zhu.
4075
4076         * BuildSlaveSupport/ews-build/events.py:
4077         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4078         buildername to builder_name to be consistent in naming style.
4079         (Events.buildFinished): Ditto.
4080
4081 2019-02-27  Chris Dumez  <cdumez@apple.com>
4082
4083         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4084         https://bugs.webkit.org/show_bug.cgi?id=194480
4085
4086         Reviewed by Brady Eidson.
4087
4088         Update existing API test to make it more likely to reproduce the issue.
4089
4090         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4091
4092 2019-02-27  Brady Eidson  <beidson@apple.com>
4093
4094         Universal links from Google search results pages don't open the app.
4095         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4096
4097         Reviewed by Geoffrey Garen.
4098
4099         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4100         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4101         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4102         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4103
4104 2019-02-27  Chris Dumez  <cdumez@apple.com>
4105
4106         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4107         https://bugs.webkit.org/show_bug.cgi?id=195102
4108
4109         Reviewed by Geoffrey Garen.
4110
4111         If the number of processes is not yet what we expect, wait a bit and check again to give
4112         processes some time to exit.
4113
4114         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4115
4116 2019-02-27  Chris Dumez  <cdumez@apple.com>
4117
4118         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4119         https://bugs.webkit.org/show_bug.cgi?id=194545
4120
4121         Reviewed by Brady Eidson.
4122
4123         Make sure the test navigates forward and then back only once. Previously, navigating
4124         back would trigger a navigation again in a timer.
4125
4126         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4127
4128 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4129
4130         High Sierra Debug JSC test queue should use faster hardware
4131         https://bugs.webkit.org/show_bug.cgi?id=194603
4132
4133         Rubber-stamped by Alexey Proskuryakov.
4134
4135         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4136
4137         * BuildSlaveSupport/build.webkit.org-config/config.json:
4138         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4139         (BubbleQueueServer):
4140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4141         (WebKitBuildbot):
4142         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4143         * QueueStatusServer/config/queues.py:
4144         * Scripts/webkitpy/common/config/ews.json:
4145         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4146         (test_ews_name):
4147
4148 2019-02-27  John Wilander  <wilander@apple.com>
4149
4150         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4151         https://bugs.webkit.org/show_bug.cgi?id=195071
4152         <rdar://problem/48417690>
4153
4154         Reviewed by Alex Christensen and Brent Fulgham.
4155
4156         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4157         (TestWebKitAPI::createURL):
4158             Convenience function.
4159         (TestWebKitAPI::TEST):
4160             WebCore::AdClickAttribution now takes a URL when creating Source and
4161             Destination.
4162         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4163         (TestWebKitAPI::TEST):
4164             WebCore::AdClickAttribution now takes a URL when creating Source and
4165             Destination.
4166
4167 2019-02-27  Antoine Quint  <graouts@apple.com>
4168
4169         Support Pointer Events on macOS
4170         https://bugs.webkit.org/show_bug.cgi?id=195008
4171         <rdar://problem/47454419>
4172
4173         Reviewed by Dean Jackson.
4174
4175         * DumpRenderTree/mac/DumpRenderTree.mm:
4176         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4177         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4178
4179 2019-02-26  Mark Lam  <mark.lam@apple.com>
4180
4181         Remove remaining poisoning code.
4182         https://bugs.webkit.org/show_bug.cgi?id=194138
4183
4184         Reviewed by Saam Barati.
4185
4186         * TestWebKitAPI/CMakeLists.txt:
4187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4188         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4189         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4190         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4191         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4192         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4193         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4194
4195 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4196
4197         Move ephemeral local storage from WebProcess to UIProcess
4198         https://bugs.webkit.org/show_bug.cgi?id=195074
4199         <rdar://problem/47937975>
4200
4201         Reviewed by Geoff Garen.
4202
4203         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4204
4205 2019-02-20  Jer Noble  <jer.noble@apple.com>
4206
4207         [Cocoa] Media elements will restart network buffering just before suspending
4208         https://bugs.webkit.org/show_bug.cgi?id=193691
4209
4210         Reviewed by Eric Carlson.
4211
4212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4213         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4214         (TEST):
4215
4216 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4217
4218         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4219         https://bugs.webkit.org/show_bug.cgi?id=191652
4220
4221         Reviewed by Alex Christensen.
4222
4223         Fix WinCairo MiniBrowser behavior of authentication dialog.
4224
4225         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4226         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4227
4228 2019-02-26  Youenn Fablet  <youenn@apple.com>
4229
4230         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4231         https://bugs.webkit.org/show_bug.cgi?id=195028
4232         <rdar://problem/48243733>
4233
4234         Reviewed by Eric Carlson.
4235
4236         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4237
4238 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4239
4240         [WPE] Add API for webview background color configuration
4241         https://bugs.webkit.org/show_bug.cgi?id=192305
4242
4243         Reviewed by Michael Catanzaro.
4244
4245         * MiniBrowser/wpe/main.cpp:
4246         (main): Add a new option to configure the webview background
4247         color. Example: --bg-color=transparent.
4248         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4249         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4250         (beforeAll): Ditto.
4251
4252 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4253
4254         scalableNativeWebpageParameters() is not preserved on new page navigation.
4255         https://bugs.webkit.org/show_bug.cgi?id=194892
4256         <rdar://problem/47538280>
4257
4258         Reviewed by Wenson Hsieh.
4259         
4260         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4261
4262         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4263         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4264         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4265         (WTR::UIScriptController::allowsViewportShrinkToFit):
4266         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4267         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4268         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4269         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4270         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4271         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4272
4273 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4274
4275         [ews-app] Add model for handling multiple Buildbot instances
4276         https://bugs.webkit.org/show_bug.cgi?id=194863
4277
4278         Reviewed by Stephanie Lewis.
4279
4280         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4281
4282 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4283
4284         [ews-app] Remove BuilderMapping table
4285         https://bugs.webkit.org/show_bug.cgi?id=194961
4286
4287         Reviewed by Stephanie Lewis.
4288
4289         Store builder name directly in build table, instead of having a separate
4290         table for it.
4291
4292         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4293         * BuildSlaveSupport/ews-app/ews/models/build.py:
4294         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4295         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4296
4297 2019-02-25  John Wilander  <wilander@apple.com>
4298
4299         Introduce and adopt new class RegistrableDomain for eTLD+1
4300         https://bugs.webkit.org/show_bug.cgi?id=194791
4301         <rdar://problem/48179240>
4302
4303         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4304
4305         This patch adds an API test and replaces two instances of
4306         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4307
4308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4309         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4310         (TestWebKitAPI::TEST):
4311             Changed two strings to make sure the registrable domains are still considered
4312             invalid and pass the test.
4313         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4314         (TestWebKitAPI::TEST):
4315         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4316         (WTR::InjectedBundle::didReceiveMessageToPage):
4317
4318 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4319
4320         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4321         https://bugs.webkit.org/show_bug.cgi?id=195001
4322
4323         Reviewed by Carlos Garcia Campos.
4324
4325         API version 1.0 always includes the functionality previously guarded with
4326         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4327         unconditionally.
4328
4329         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4330         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4331         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4332         (WebViewTest::showInWindow): Ditto.
4333         (WebViewTest::hideView): Ditto.
4334         * wpe/backends/HeadlessViewBackend.cpp:
4335         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4336         * wpe/backends/ViewBackend.cpp:
4337         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4338         * wpe/backends/WindowViewBackend.cpp:
4339         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4340         WPE_BACKEND_CHECK_VERSION().
4341         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4342
4343 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4344
4345         [Flatpak] Add support for flatpak > 1.1.2
4346         https://bugs.webkit.org/show_bug.cgi?id=194088
4347
4348         Flatpak 1.2 is now out so we need to support that
4349         version now.
4350
4351         Reviewed by Michael Catanzaro.
4352
4353         * flatpak/flatpakutils.py:
4354         (check_flatpak):
4355         (FlatpakPackages.__init__):
4356         (FlatpakPackages.__detect_packages):
4357         (FlatpakPackages.__detect_packages.in):
4358         (FlatpakRepos.update):
4359
4360 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4361
4362         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4363         https://bugs.webkit.org/show_bug.cgi?id=194998
4364
4365         Reviewed by Carlos Garcia Campos.
4366
4367         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4368         to a Git checkout and using the latest commit containing various fixes
4369         and improvements.