Remove check for SkipSafariExecutableEntitlementChecks
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
2
3         Remove check for SkipSafariExecutableEntitlementChecks
4         https://bugs.webkit.org/show_bug.cgi?id=167762
5
6         Reviewed by Dan Bernstein.
7
8         Follow-up fix: don't break internal behavior.
9
10         * Scripts/webkitdirs.pm:
11         (safariPath):
12         (executableHasEntitlements): Deleted.
13         (safariPathFromSafariBundle): Deleted.
14         (installedSafariPath): Deleted.
15
16 2017-02-03  Daniel Bates  <dabates@apple.com>
17
18         [Mac][WK2] Add SPI to override the Content Security Policy of a page
19         https://bugs.webkit.org/show_bug.cgi?id=167810
20         <rdar://problem/30102568>
21
22         Reviewed by Anders Carlsson.
23
24         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
25
26         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
27         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
28         (TEST):
29         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
30         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
31         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
32         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
33
34 2017-02-02  Alex Christensen  <achristensen@webkit.org>
35
36         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
37         https://bugs.webkit.org/show_bug.cgi?id=167773
38         <rdar://problem/30221102>
39
40         Reviewed by Ryosuke Niwa.
41
42         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
43         (TestWebKitAPI::TEST_F):
44
45 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
46
47         Remove check for SkipSafariExecutableEntitlementChecks
48         https://bugs.webkit.org/show_bug.cgi?id=167762
49         rdar://problem/22480673
50
51         Reviewed by Dan Bernstein.
52
53         * Scripts/webkitdirs.pm:
54         (safariPathFromSafariBundle):
55         (skipSafariExecutableEntitlementChecks): Deleted.
56
57 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
58
59         Undefined subroutine in svn-create-patch
60         https://bugs.webkit.org/show_bug.cgi?id=167742
61
62         Unreviewed build-fix after r211543.
63
64         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
65
66 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
67
68         Unreviewed. Fix jhbuild dependencies build.
69
70         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
71         Patch updated.
72
73 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
74
75         [EME][GStreamer] Fixed decryptor selection
76         https://bugs.webkit.org/show_bug.cgi?id=167588
77
78         Reviewed by Žan Doberšek.
79
80         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
81
82         * gtk/jhbuild.modules: Added patches to gstreamer and
83         gst-plugins-good packages.
84         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
85         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
86
87 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
88
89         Make run-benchmark script supports 'config' key in test plan.
90         https://bugs.webkit.org/show_bug.cgi?id=167715
91
92         Reviewed by Ryosuke Niwa.
93
94         Add support for 'config' key in test paln.
95         'config' key is a dictionary that specifies environment configurations while test is running.
96         Specifies orientation to be portrait in MotionMark benchmark.
97
98         * Scripts/webkitpy/benchmark_runner/README.md:
99         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
100         (BenchmarkRunner.__init__):
101         (BenchmarkRunner._run_benchmark):
102         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
103         (BrowserDriver.prepare_env):
104         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
105         (LinuxBrowserDriver.prepare_env):
106         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
107         (OSXBrowserDriver.prepare_env):
108         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
109         (OSXSafariDriver.prepare_env):
110         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
111
112 2017-02-01  Daniel Bates  <dabates@apple.com>
113
114         REGRESSION (r210820): svn-create-patch does not emit property change only diff
115         https://bugs.webkit.org/show_bug.cgi?id=167169
116
117         Reviewed by David Kilzer.
118
119         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
120         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
121         header from the output of "svn diff" on a file that was copied or moved.
122
123         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
124         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
125         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
126         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
127         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
128         of a file with only a property change also does not contain any chunk range lines. Therefore
129         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
130         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
131         we should directly test for the presence of a leading SVN diff header with an empty body and
132         remove such lines from the diff.
133
134         * Scripts/VCSUtils.pm:
135         (fixSVNPatchForAdditionWithHistory): Added.
136         * Scripts/svn-create-patch:
137         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
138         we have a non empty patch for an added file with history (i.e. a copied or moved file).
139         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
140
141 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
142
143         [Mac] Update CARingBuffer class
144         https://bugs.webkit.org/show_bug.cgi?id=167656
145
146         Reviewed by Jer Noble.
147
148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
149         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
150         (TestWebKitAPI::CARingBufferTest::SetUp):
151         (TestWebKitAPI::CARingBufferTest::setup):
152         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
153         (TestWebKitAPI::CARingBufferTest::description):
154         (TestWebKitAPI::CARingBufferTest::bufferList):
155         (TestWebKitAPI::CARingBufferTest::ringBuffer):
156         (TestWebKitAPI::CARingBufferTest::capacity):
157         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
158         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
159         (TestWebKitAPI::TEST_F):
160         (TestWebKitAPI::MixingTest::run):
161
162 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
163
164         [Mac] TestWebKitAPI includes system frameworks incorrectly
165         https://bugs.webkit.org/show_bug.cgi?id=167703
166         rdar://problem/30301498
167
168         Reviewed by Ryosuke Niwa.
169
170         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
171         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
172
173         Also, reduced the number of subframework search paths, looks like we only need one now.
174
175         * TestWebKitAPI/Configurations/Base.xcconfig:
176
177 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
178
179         Correct "filesHaveSameVolume" predicate
180         https://bugs.webkit.org/show_bug.cgi?id=167696
181         <rdar://problem/30298722>
182
183         Reviewed by David Kilzer.
184
185         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
186         percent-escaped path inputs.
187
188         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
189         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
190         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
191         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
192         (TestWebKitAPI::TEST_F):
193
194 2017-02-01  Tomas Popela  <tpopela@redhat.com>
195
196         Unreviewed. Fix coding style in MiniBrowser
197
198         * MiniBrowser/gtk/BrowserWindow.c:
199         (editingCommandCallback):
200         (insertImageCommandCallback):
201         (insertLinkCommandCallback):
202
203 2017-02-01  Tomas Popela  <tpopela@redhat.com>
204
205         [GTK] Add an API to add a custom tab into the print dialog
206         https://bugs.webkit.org/show_bug.cgi?id=151998
207
208         Reviewed by Carlos Garcia Campos.
209
210         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
211         that is testing a newly added API.
212
213         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
214         (testPrintCustomWidget):
215         (beforeAll):
216
217 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
218
219         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
220         https://bugs.webkit.org/show_bug.cgi?id=166529
221
222         Reviewed by Xabier Rodriguez-Calvar.
223
224         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
225         New patch version accepted in GStreamer upstream.
226
227 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
228
229         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
230         https://bugs.webkit.org/show_bug.cgi?id=167498
231
232         Reviewed by Carlos Garcia Campos.
233
234         Depending on the distro version you can need either libxfont1-dev
235         or libfont-dev to build with jhbuild.
236
237         * gtk/install-dependencies:
238
239 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
240
241         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
242         https://bugs.webkit.org/show_bug.cgi?id=167594
243
244         Unreviewed test gardening.
245
246         Disabling this test while we investigate the cause of a timeout on ios-simulator.
247
248         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
249         (TEST):
250
251 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
252
253         Move slow-running microbenchmarks out of JSTests/microbenchmarks
254         https://bugs.webkit.org/show_bug.cgi?id=167676
255
256         Reviewed by Saam Barati.
257
258         * Scripts/run-javascriptcore-tests:
259         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
260
261 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
262
263         Make Dump Render Tree not crash
264         https://bugs.webkit.org/show_bug.cgi?id=167667
265
266         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
267         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
268         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
269         This does not fix any tests, it just fixes the crash.
270         
271         Reviewed by Simon Fraser.
272
273         * DumpRenderTree/TestRunner.cpp:
274         (TestRunner::callUIScriptCallback):
275
276 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
277
278         Workaround for simctl install failing to report install failure
279         https://bugs.webkit.org/show_bug.cgi?id=167654
280
281         Reviewed by Daniel Bates.
282
283         simctl install will sometimes report success even though install has failed.
284         To workaround this bug, we attempt an app launch after install to ensure
285         install has succeeded.
286
287         * Scripts/webkitpy/xcode/simulator.py:
288         (Device.install_app): Attempt app launch after install, retry install if launch fails.
289         (Device.launch_app): Correct comment.
290
291 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
292
293         Unreviewed webkitpy fix after r211405.
294
295         * Scripts/webkitpy/xcode/simulator.py:
296         (Device.launch_app): Remove @staticmethod on _log_debug_error.
297
298 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
299
300         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
301
302         * gtk/manifest.txt.in:
303
304 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
305
306         AX: enable search predication for iOS
307         https://bugs.webkit.org/show_bug.cgi?id=167558
308         <rdar://problem/30251367>
309
310         Reviewed by Joanmarie Diggs.
311
312         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
313         (AccessibilityUIElement::uiElementForSearchPredicate):
314         * DumpRenderTree/mac/AccessibilityCommonMac.h:
315         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
316         (searchPredicateParameterizedAttributeForSearchCriteria):
317         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
318         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
319         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
320         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
321         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
322         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
323         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
324         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
325         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
326         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
327         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
328
329 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
330
331         Workaround for simctl launch bug
332         https://bugs.webkit.org/show_bug.cgi?id=167613
333
334         Reviewed by Daniel Bates.
335
336         simctl launch will sometimes fail because of a race condition when many
337         simulators are being run simultaneously. These failures will always have
338         an exit code of 1. This change attempts to launch an app multiple times
339         before reporting a failure to workaround this bug.
340
341         * Scripts/webkitpy/xcode/simulator.py:
342         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
343
344 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
345
346         Commit queue fails to look at real name aliases for the reviewer
347         https://bugs.webkit.org/show_bug.cgi?id=167422
348
349         Reviewed by Joseph Pecoraro.
350
351         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
352         (test_has_valid_reviewer): Added tests.
353
354         * Scripts/webkitpy/common/config/committers.py:
355         (CommitterList._name_to_contributor_map):
356         Made _name_to_contributor_map include alias names.
357
358         * Scripts/webkitpy/common/config/committers_unittest.py:
359         (CommittersTest.test_contributors_by_fuzzy_match):
360         Removed subtests that are now obsolete, as these matches are strict. It is not
361         obvious if distance based fuzzy matching for names is useful at all, but we can
362         look into that some other time.
363
364 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
365
366         QueueStatusServer should have an explicit timeout for _fetch_url
367         https://bugs.webkit.org/show_bug.cgi?id=167467
368
369         Reviewed by Alexey Proskuryakov.
370
371         * Scripts/webkitpy/common/net/statusserver.py:
372         (StatusServer._fetch_url): Add an explicit timeout of 300s.
373
374 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
375
376         Add support for Trac instances that host multiple projects.
377         https://bugs.webkit.org/show_bug.cgi?id=167524
378
379         Reviewed by Alexey Proskuryakov.
380
381         When multiple projects are hosted on a single Trac instance, the current
382         behavior will retrieve changesets from all tracked projects.
383         This patch teaches Trac.js to get project-specific changesets from Trac.
384         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
385         when querying the Trac timeline.
386
387         To tell Trac to be aware of multi-project instances we leverage the 
388         `options` parameter when creating a new instance: 
389
390             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
391
392         If this option is not provided, the original behaviour will prevail.
393         Additionally, add corresponding tests.
394
395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
396         (Trac): Reason about new optional parameter 'projectIdentifier'.
397         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
398         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
399         replace default parameter `changeset=on` with `repo-projectname=on`.
400         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
402         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
404         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
405         Add the following tests:
406             test("revisionURL")
407             test("revisionURL with Trac Identifier")
408             test("_xmlTimelineURL")
409             test("_xmlTimelineURL with Trac Identifier")
410         (this.view._latestProductiveIteration): Fix missing ';'.
411
412 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
413
414         Correct spacing regression on inter-element complex path shaping on some fonts
415         https://bugs.webkit.org/show_bug.cgi?id=166013
416
417         Reviewed by Simon Fraser.
418
419         Unskip existing tests and make some new tests:
420         - Testing complex text with no origins
421         - Testing initial expansions
422         - Testing the sign of vertical advances
423
424         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
425         (TestWebKitAPI::TEST_F):
426
427 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
428
429         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
430         https://bugs.webkit.org/show_bug.cgi?id=167596
431
432         Reviewed by Daniel Bates.
433
434         We avoid needing a thin directory by invoking the zip program with
435         the list of directories from the build directory to be zipped,
436         and by using the zip feature to exclude files matching a pattern.
437
438         * BuildSlaveSupport/built-product-archive:
439         (copyBuildFiles):
440         (createZipFromList):
441         (archiveBuiltProduct):
442
443 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
444
445         Use simctl instead of LayoutTestRelay
446         https://bugs.webkit.org/show_bug.cgi?id=165927
447
448         Reviewed by Daniel Bates.
449
450         Part 1
451
452         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
453         simulators through simctl (iOS 10 and later), use this functionality instead.
454
455         * Scripts/webkitpy/port/base.py:
456         (Port.__init__): Added _test_runner_process_constructor.
457         * Scripts/webkitpy/port/darwin.py:
458         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
459         * Scripts/webkitpy/port/driver.py:
460         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
461         (IOSSimulatorDriver): Deleted.
462         * Scripts/webkitpy/port/driver_unittest.py:
463         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
464         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
465         (DriverTest.test_start_actually_starts): Ditto.
466         * Scripts/webkitpy/port/ios.py:
467         (IOSSimulatorPort): Remove relay_name.
468         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
469         (IOSSimulatorPort._create_simulators): Formatting change.
470         (IOSSimulatorPort.relay_path): Deleted.
471         (IOSSimulatorPort._check_relay): Deleted.
472         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
473         (IOSSimulatorPort._build_relay): Deleted.
474         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
475         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
476         * Scripts/webkitpy/port/ios_unittest.py:
477         (iosTest.test_32bit): Update test.
478         (iosTest.test_64bit): Update test.
479         * Scripts/webkitpy/port/server_process.py:
480         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
481         (ServerProcess._set_file_nonblocking): Added to share common code.
482         * Scripts/webkitpy/port/server_process_mock.py:
483         (MockServerProcess.__init__): Added argument worker_number.
484         * Scripts/webkitpy/port/simulator_process.py: Added.
485         (SimulatorProcess): Added.
486         (SimulatorProcess.Popen): Added.
487         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
488         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
489         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
490         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
491         (SimulatorProcess._reset): Added. Unlink fifos.
492         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
493         (SimulatorProcess._kill): Added. Shutdown app on simulator.
494         * Scripts/webkitpy/xcode/simulator.py:
495         (Device.__init__): Accept host to run install/launch/terminate.
496         (Device.install_app): Install app to target Device.
497         (Device.launch_app): Launch app on target Device.
498         (Device.terminate_app): Shutdown app on target Device.
499         (Simulator._parse_devices): Pass host to Device.
500
501 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
502
503         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
504         https://bugs.webkit.org/show_bug.cgi?id=167411
505
506         Reviewed by Michael Catanzaro.
507
508         Disable the ARM iwMMXt fast path for pixman, because it triggers
509         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
510
511         * gtk/jhbuild.modules:
512
513 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
514
515         [GTK] Add API to handle the accelerated compositing policy
516         https://bugs.webkit.org/show_bug.cgi?id=167509
517
518         Reviewed by Michael Catanzaro.
519
520         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
521         as a special case. Also add test cases to the get/set API.
522
523         * MiniBrowser/gtk/BrowserSettingsDialog.c:
524         (hardwareAccelerationPolicyToString):
525         (stringToHardwareAccelerationPolicy):
526         (cellRendererChanged):
527         (browserSettingsDialogConstructed):
528         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
529         (testWebKitSettings):
530
531 2017-01-29  Andy Estes  <aestes@apple.com>
532
533         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
534         https://bugs.webkit.org/show_bug.cgi?id=167563
535         <rdar://problem/30253207>
536
537         Reviewed by Andreas Kling.
538
539         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
540         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
541         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
542         (runTest):
543         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
544         (TEST):
545
546 2017-01-29  Dan Bernstein  <mitz@apple.com>
547
548         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
549         https://bugs.webkit.org/show_bug.cgi?id=167565
550
551         Reviewed by Sam Weinig.
552
553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
554         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
555         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
556         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
557         (TEST):
558         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
559         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
560         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
561         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
562
563 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
564
565         Add Link Preload as an off-by-default experimental feature menu item.
566         https://bugs.webkit.org/show_bug.cgi?id=167201
567
568         Reviewed by Ryosuke Niwa.
569
570         * DumpRenderTree/mac/DumpRenderTree.mm:
571         (resetWebPreferencesToConsistentValues):
572         * DumpRenderTree/win/DumpRenderTree.cpp:
573         (resetWebPreferencesToConsistentValues):
574
575 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
576
577         Add User Timing Experimental Feature
578         https://bugs.webkit.org/show_bug.cgi?id=167542
579         <rdar://problem/22746307>
580
581         Reviewed by Ryosuke Niwa.
582
583         * DumpRenderTree/mac/DumpRenderTree.mm:
584         (enableExperimentalFeatures):
585         (resetWebPreferencesToConsistentValues):
586         * DumpRenderTree/win/DumpRenderTree.cpp:
587         (enableExperimentalFeatures):
588
589 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
590
591         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
592         https://bugs.webkit.org/show_bug.cgi?id=167519
593
594         Reviewed by Ryosuke Niwa.
595
596         * QueueStatusServer/templates/statusbubble.html:
597         To measure the bubbleContainer's width, it must not be wrapping based
598         on its parent container. So when measuring the width temporarily set
599         the parent to a very large width so as to not artificially wrap us.
600         Restore the parent's width after measuring.
601
602 2017-01-27  Andy Estes  <aestes@apple.com>
603
604         [iOS] Add a test for _WKNSFileManagerExtras
605         https://bugs.webkit.org/show_bug.cgi?id=167478
606
607         Reviewed by Andreas Kling.
608
609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
610         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
611         (expectAttributes):
612         (TEST):
613
614 2017-01-27  Keith Miller  <keith_miller@apple.com>
615
616         run-benchmarks should make sure it passes the test url to the right application
617         https://bugs.webkit.org/show_bug.cgi?id=167533
618
619         Reviewed by Joseph Pecoraro.
620
621         This fixes an issue when trying to run-benchmark script with the
622         system default browser set to STP. Previously, it would run
623         the test in STP rather than the provided build. Now, it should run
624         in the provided build.
625
626         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
627         (OSXSafariDriver.launch_url):
628
629 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
630
631         [Cocoa] Prepare ComplexTextController for unit testing
632         https://bugs.webkit.org/show_bug.cgi?id=167493
633
634         Reviewed by Simon Fraser.
635
636         Addressing post-review comments from Simon Fraser.
637
638         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
639         (TestWebKitAPI::TEST_F):
640
641 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
642
643         [Cocoa] Prepare ComplexTextController for unit testing
644         https://bugs.webkit.org/show_bug.cgi?id=167493
645
646         Reviewed by Dean Jackson.
647
648         Create four unit tests.
649
650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
651         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
652         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
653         (TestWebKitAPI::TEST_F):
654
655 2017-01-26  Chris Dumez  <cdumez@apple.com>
656
657         Crash when navigating back to a page in PacheCache when one of its frames has been removed
658         https://bugs.webkit.org/show_bug.cgi?id=167421
659         <rdar://problem/30188490>
660
661         Reviewed by Darin Adler.
662
663         Add a new setting allowing layout tests to enable PageCache in a window
664         that has an opener, for convenience.
665
666         * DumpRenderTree/mac/DumpRenderTree.mm:
667         (resetWebPreferencesToConsistentValues):
668         * DumpRenderTree/win/DumpRenderTree.cpp:
669         (resetWebPreferencesToConsistentValues):
670         * WebKitTestRunner/TestController.cpp:
671         (WTR::TestController::resetPreferencesToConsistentValues):
672
673 2017-01-26  Keith Miller  <keith_miller@apple.com>
674
675         classInfo should take a VM so it is not materialized from the object on each call
676         https://bugs.webkit.org/show_bug.cgi?id=167424
677
678         Rubber Stamped by Michael Saboff.
679
680         Previously, classInfo() would get the VM from the target's
681         MarkedBlock.  Most callers already have a VM on hand, so it is
682         wasteful to compute the VM from the marked block every time. This
683         patch refactors some of the most common callers of classInfo(),
684         jsDynamicCast and inherits to take a VM as well.
685
686         * DumpRenderTree/TestRunner.cpp:
687         (setAudioResultCallback):
688
689 2017-01-26  Jer Noble  <jer.noble@apple.com>
690
691         Autoplay muted videos stop playback of any streaming app in the background
692         https://bugs.webkit.org/show_bug.cgi?id=163993
693         <rdar://problem/29020431>
694
695         Reviewed by Eric Carlson.
696
697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
698         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
699         (TestWebKitAPI::TEST):
700         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
701
702 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
703
704         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
705         https://bugs.webkit.org/show_bug.cgi?id=167466
706
707         Unreviewed test gardening.
708
709         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
710         (TEST):
711
712 2017-01-26  Matt Rajca  <mrajca@apple.com>
713
714         Notify clients when the user plays media otherwise prevented from autoplaying
715         https://bugs.webkit.org/show_bug.cgi?id=167390
716
717         Reviewed by Alex Christensen.
718
719         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
720         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
721         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
722         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
723         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
724         (TEST):
725         * TestWebKitAPI/cocoa/TestWKWebView.h:
726         * TestWebKitAPI/cocoa/TestWKWebView.mm:
727         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
728         (-[TestWKWebView waitForLoad]):
729         (-[TestWKWebView mouseUpAtPoint:]):
730         * WebKitTestRunner/TestController.cpp:
731         (WTR::TestController::createOtherPage):
732         (WTR::TestController::createWebViewWithOptions):
733
734 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
735
736         Crash when setting custom scale factor.
737         https://bugs.webkit.org/show_bug.cgi?id=167369
738
739         Reviewed by Sam Weinig.
740
741         Added API test.
742
743         * TestWebKitAPI/PlatformWin.cmake:
744         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
745         (TestWebKitAPI::WebKitCreateInstance):
746         (TestWebKitAPI::ScaleWebView::SetUp):
747         (TestWebKitAPI::ScaleWebView::TearDown):
748         (TestWebKitAPI::TEST_F):
749
750 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
751
752         run-benchmark nests MotionMark results by the suite name twice
753         https://bugs.webkit.org/show_bug.cgi?id=164948
754
755         Reviewed by Said Abou-Hallawa.
756
757         Use a single level MotionMark now that this is the name of the benchmark,
758         and we no longer have tests that aren't part of the MotionMark suite.
759
760         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
761
762 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
763
764         Unreviewed, rolling out r211193.
765
766         This change broke internal builds.
767
768         Reverted changeset:
769
770         "Notify clients when the user plays media otherwise prevented
771         from autoplaying"
772         https://bugs.webkit.org/show_bug.cgi?id=167390
773         http://trac.webkit.org/changeset/211193
774
775 2017-01-25  Matt Rajca  <mrajca@apple.com>
776
777         Notify clients when the user plays media otherwise prevented from autoplaying
778         https://bugs.webkit.org/show_bug.cgi?id=167390
779
780         Reviewed by Alex Christensen.
781
782         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
783         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
784         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
785         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
786         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
787         (TEST):
788         * TestWebKitAPI/cocoa/TestWKWebView.h:
789         * TestWebKitAPI/cocoa/TestWKWebView.mm:
790         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
791         (-[TestWKWebView waitForLoad]):
792         (-[TestWKWebView mouseUpAtPoint:]):
793         * WebKitTestRunner/TestController.cpp:
794         (WTR::TestController::createOtherPage):
795         (WTR::TestController::createWebViewWithOptions):
796
797 2017-01-25  Matt Rajca  <mrajca@apple.com>
798
799         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
800         https://bugs.webkit.org/show_bug.cgi?id=167385
801
802         Reviewed by Alex Christensen.
803
804         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
805         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
806         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
807         (TEST): Allow inline (rather than full screen) media playback on iOS.
808
809 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
810
811         [GTK] Icon Database should be in private browsing mode for ephemeral web views
812         https://bugs.webkit.org/show_bug.cgi?id=167414
813
814         Reviewed by Michael Catanzaro.
815
816         Add a test case to check ephemeral web views don't write favicons to the database.
817
818         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
819         (ephemeralViewLoadChanged):
820         (testPrivateBrowsing):
821         (testFaviconDatabase):
822
823 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
824
825         [GTK] Add a private browsing mode to MiniBrowser
826         https://bugs.webkit.org/show_bug.cgi?id=167413
827
828         Reviewed by Michael Catanzaro.
829
830         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
831         private windows, even on non-private instances.
832
833         * MiniBrowser/gtk/BrowserWindow.c:
834         (webViewTitleChanged): Add [Private] to title window for private windows.
835         (webViewCreate): Pass web context to browser_window_new.
836         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
837         (browserWindowFinalize): Disconnect web context signal handlers.
838         (browser_window_init): Add shortcut for opening private window.
839         (browser_window_new): It now receives the context and connect to download-started here.
840         (browser_window_get_web_context): Return the context.
841         * MiniBrowser/gtk/BrowserWindow.h:
842         * MiniBrowser/gtk/main.c:
843         (createBrowserTab): Create the web view for the window web context.
844         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
845         (aboutDataHandleRequest): Ditto.
846         (aboutURISchemeRequestCallback): Ditto.
847         (main): Create ephemeral web context if private command line option is used.
848
849 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
850
851         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
852         https://bugs.webkit.org/show_bug.cgi?id=167409
853
854         Reviewed by Antti Koivisto.
855
856         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
857         as well as tests for the newly added matchingElementInFlatTree.
858
859         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
860         (TestWebKitAPI::runJavaScriptAlert):
861         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
862         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
863         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
864
865 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
866
867         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
868         https://bugs.webkit.org/show_bug.cgi?id=167370
869
870         Reviewed by Michael Catanzaro.
871
872         Add several test cases of ephemeral web views.
873
874         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
875         (testWebViewAuthenticationStorage):
876         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
877         (ephemeralViewloadChanged):
878         (testCookieManagerEphemeral):
879         (beforeAll):
880         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
881         (testWebKitSettings):
882         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
883         (testWebContextEphemeral):
884         (ephemeralViewloadChanged):
885         (testWebContextProxySettings):
886         (beforeAll):
887         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
888         (ephemeralViewloadChanged):
889         (testWebViewEphemeral):
890         (beforeAll):
891         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
892         (ephemeralViewloadChanged):
893         (testWebsiteDataEphemeral):
894         (beforeAll):
895
896 2017-01-24  Alex Christensen  <achristensen@webkit.org>
897
898         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
899         https://bugs.webkit.org/show_bug.cgi?id=167402
900
901         Reviewed by Ryosuke Niwa.
902
903         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
904         (TestWebKitAPI::TEST):
905
906 2017-01-24  Zalan Bujtas  <zalan@apple.com>
907
908         Add simple line layout toggle to MiniBrowser
909         https://bugs.webkit.org/show_bug.cgi?id=167405
910
911         Reviewed by Andreas Kling.
912
913         * MiniBrowser/mac/SettingsController.h:
914         * MiniBrowser/mac/SettingsController.m:
915         (-[SettingsController _populateMenu]):
916         (-[SettingsController validateMenuItem:]):
917         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
918         (-[SettingsController simpleLineLayoutEnabled]):
919         * MiniBrowser/mac/WK1BrowserWindowController.m:
920         (-[WK1BrowserWindowController didChangeSettings]):
921         * MiniBrowser/mac/WK2BrowserWindowController.m:
922         (-[WK2BrowserWindowController didChangeSettings]):
923
924 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
925
926         WKR does not include my nick when commit-queue lands my patch
927         https://bugs.webkit.org/show_bug.cgi?id=167388
928
929         Reviewed by Ryosuke Niwa.
930
931         * Scripts/webkitpy/tool/commands/newcommitbot.py:
932         (NewCommitBot._summarize_commit_log):
933         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
934         Perform nickname insertion before grabbing "Patch by" details.
935         This way we can include the nickname with the full name.
936
937 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
938
939         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
940         https://bugs.webkit.org/show_bug.cgi?id=167394
941
942         Reviewed by Ryosuke Niwa.
943
944         * Scripts/webkitperl/FeatureList.pm:
945         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
946
947 2017-01-24  Youenn Fablet  <youenn@apple.com>
948
949         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
950         https://bugs.webkit.org/show_bug.cgi?id=167353
951
952         Reviewed by Alex Christensen.
953
954         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
955         (CMakeGenerator.initialize_targets):
956
957 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
958
959         WKR should not confuse Miguel Gomez with Andres Gomez
960         https://bugs.webkit.org/show_bug.cgi?id=167389
961
962         Reviewed by Lucas Forschler.
963
964         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
965         "mAndres Gomez". Fix this.
966
967         * Scripts/webkitpy/tool/commands/newcommitbot.py:
968         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
969         space on each side of the email address, so expect both spaces to be there before
970         considering the email for replacement.
971         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
972
973 2017-01-24  Matt Rajca  <mrajca@apple.com>
974
975         Pass down website autoplay policies to media elements
976         https://bugs.webkit.org/show_bug.cgi?id=167355
977
978         Reviewed by Alex Christensen.
979
980         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
981         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
982         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
983         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
984         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
985         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
986         (TEST):
987
988 2017-01-24  Nan Wang  <n_wang@apple.com>
989
990         AX: Speak Selection does not work in an iframe
991         https://bugs.webkit.org/show_bug.cgi?id=166794
992         <rdar://problem/29913013>
993
994         Reviewed by Chris Fleizach.
995
996         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
997         (WTR::UIScriptController::retrieveSpeakSelectionContent):
998         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
999         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1000         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1001         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1002         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1003         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1004         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1005         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1006         (-[TestRunnerWKWebView dealloc]):
1007         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1008         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1009         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1010         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1011         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1012
1013 2017-01-24  Daniel Bates  <dabates@apple.com>
1014
1015         StringView.split() should use an iterator design pattern instead of allocating a Vector
1016         https://bugs.webkit.org/show_bug.cgi?id=163225
1017
1018         Reviewed by Darin Adler.
1019
1020         Add unit tests for StringView.split().
1021
1022         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1023         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1024         used in the StringView.split() unit tests.
1025         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1026         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1027         object to a Vector of String objects.
1028         (TestWebKitAPI::TEST): Added the following tests:
1029             - WTF.StringViewSplitEmptyAndNullStrings
1030             - WTF.StringViewSplitBasic
1031             - WTF.StringViewSplitWithConsecutiveSeparators
1032
1033 2017-01-23  Anders Carlsson  <andersca@apple.com>
1034
1035         The Score Esports crashes on launch
1036         https://bugs.webkit.org/show_bug.cgi?id=167338
1037         rdar://problem/29948645
1038
1039         Reviewed by Dan Bernstein.
1040
1041         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1042         (TestWebKitAPI::TEST):
1043         Add a test.
1044
1045 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1046
1047         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1048         https://bugs.webkit.org/show_bug.cgi?id=146589
1049
1050         Reviewed by Michael Catanzaro.
1051
1052         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1053         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1054
1055         * MiniBrowser/gtk/BrowserWindow.c:
1056         (webViewDecidePolicy):
1057         (newTabCallback):
1058         * MiniBrowser/gtk/main.c:
1059         (createBrowserTab):
1060         (aboutDataRequestFree):
1061         (aboutDataRequestNew):
1062         (aboutDataRequestForView):
1063         (websiteDataRemovedCallback):
1064         (websiteDataClearedCallback):
1065         (aboutDataScriptMessageReceivedCallback):
1066         (domainListFree):
1067         (aboutDataFillTable):
1068         (gotWebsiteDataCallback):
1069         (aboutDataHandleRequest):
1070         (aboutURISchemeRequestCallback):
1071         (main):
1072         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1073         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1074         (serverCallback):
1075         (beforeAll):
1076         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
1077         (serverCallback):
1078         (WebsiteDataTest::WebsiteDataTest):
1079         (WebsiteDataTest::~WebsiteDataTest):
1080         (WebsiteDataTest::fetch):
1081         (WebsiteDataTest::remove):
1082         (WebsiteDataTest::clear):
1083         (testWebsiteDataConfiguration):
1084         (testWebsiteDataCache):
1085         (testWebsiteDataStorage):
1086         (testWebsiteDataDatabases):
1087         (testWebsiteDataAppcache):
1088         (beforeAll):
1089         (afterAll):
1090
1091 2017-01-23  Commit Queue  <commit-queue@webkit.org>
1092
1093         Unreviewed, rolling out r211062.
1094         https://bugs.webkit.org/show_bug.cgi?id=167354
1095
1096         broke API tests (Requested by alexchristensen on #webkit).
1097
1098         Reverted changeset:
1099
1100         "Pass down website autoplay policies to media elements"
1101         https://bugs.webkit.org/show_bug.cgi?id=167132
1102         http://trac.webkit.org/changeset/211062
1103
1104 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1105
1106         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
1107         https://bugs.webkit.org/show_bug.cgi?id=167330
1108
1109         Reviewed by Tim Horton.
1110
1111         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1112         (TestWebKitAPI::TEST_F):
1113
1114 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1115
1116         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
1117         https://bugs.webkit.org/show_bug.cgi?id=167317
1118
1119         Reviewed by Sam Weinig.
1120
1121         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1122         (TestWebKitAPI::TEST_F):
1123
1124 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
1125
1126         svn-create-patch should emit properties when files are moved or copied
1127         https://bugs.webkit.org/show_bug.cgi?id=167264
1128
1129         Reviewed by Daniel Bates.
1130
1131         * Scripts/svn-create-patch:
1132         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
1133
1134 2017-01-23  Youenn Fablet  <youenn@apple.com>
1135
1136         [WebRTC] Filter libwebrtc link flags
1137         https://bugs.webkit.org/show_bug.cgi?id=167287
1138
1139         Reviewed by Alex Christensen.
1140
1141         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1142         (CMakeGenerator._compute_link_flags):
1143         (CMakeGenerator._compute_link_flags.keep_flag):
1144         (CMakeGenerator._generate_compile_target_options):
1145
1146 2017-01-23  Youenn Fablet  <youennf@gmail.com>
1147
1148         [WebRTC] Make VP8 optional in libwebrtc
1149         https://bugs.webkit.org/show_bug.cgi?id=167257
1150
1151         Reviewed by Darin Adler.
1152
1153         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1154         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
1155
1156 2017-01-23  Jer Noble  <jer.noble@apple.com>
1157
1158         Video details does not apear and missing scrubber in Control Center
1159         https://bugs.webkit.org/show_bug.cgi?id=167233
1160
1161         Reviewed by Alex Christensen.
1162
1163         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
1164         NowPlayingControlTests for iOS.
1165
1166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1167         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1168         (-[NowPlayingTestWebView setWindowVisible:]):
1169         (TestWebKitAPI::TEST):
1170         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1171         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1172         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1173         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
1174         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
1175         (SOFT_LINK_CLASS):
1176         (-[TestMessageHandler addMessage:withHandler:]):
1177         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1178         (__simulated_forceClickAssociatedEventsMask):
1179         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1180         (-[TestWKWebViewHostWindow isKeyWindow]):
1181         (-[TestWKWebViewHostWindow makeKeyWindow]):
1182         (-[TestWKWebViewHostWindow resignKeyWindow]):
1183         (-[TestWKWebView initWithFrame:]):
1184         (-[TestWKWebView initWithFrame:configuration:]):
1185         (-[TestWKWebView _setUpTestWindow:]):
1186         (-[TestWKWebView performAfterReceivingMessage:action:]):
1187         (-[TestWKWebView loadTestPageNamed:]):
1188         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1189         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1190         (-[TestWKWebView waitForMessage:]):
1191         (-[TestWKWebView performAfterLoading:]):
1192         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1193         (-[TestWKWebView typeCharacter:]):
1194
1195 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1196
1197         Unreviewed. Bring back gtk-doc error messages after r209981.
1198
1199         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
1200         impossible to know what's wrong.
1201
1202         * gtk/gtkdoc.py:
1203         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
1204
1205 2017-01-20  Youenn Fablet  <youennf@gmail.com>
1206
1207         [WebRTC] Update build system to make G711 optional in libwebrtc
1208         https://bugs.webkit.org/show_bug.cgi?id=167256
1209
1210         Reviewed by Alex Christensen.
1211
1212         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1213         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
1214
1215 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1216
1217         Cleanup RuntimeEnabledFeatures
1218         https://bugs.webkit.org/show_bug.cgi?id=167228
1219
1220         Reviewed by Simon Fraser.
1221
1222         * DumpRenderTree/mac/DumpRenderTree.mm:
1223         (enableExperimentalFeatures):
1224         (resetWebPreferencesToConsistentValues):
1225         (setWebPreferencesForTestOptions):
1226         (resetWebViewToConsistentStateBeforeTesting):
1227         * DumpRenderTree/win/DumpRenderTree.cpp:
1228         (enableExperimentalFeatures):
1229         (resetWebPreferencesToConsistentValues):
1230         More closely match WebKitTestRunner initialization of preferences
1231         for experimental features.
1232
1233 2017-01-20  Alex Christensen  <achristensen@webkit.org>
1234
1235         Build Fix for Windows DumpRenderTree after r210976
1236         https://bugs.webkit.org/show_bug.cgi?id=167115
1237
1238         * DumpRenderTree/win/DumpRenderTree.cpp:
1239         (resetWebPreferencesToConsistentValues):
1240
1241 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1242
1243         Remove outdated ENABLE(CSP_NEXT) build flag
1244         https://bugs.webkit.org/show_bug.cgi?id=167252
1245
1246         Reviewed by Brent Fulgham.
1247
1248         * Scripts/webkitperl/FeatureList.pm:
1249         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1250
1251 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1252
1253         Build Fix for Windows DumpRenderTree after r210976
1254
1255         * DumpRenderTree/win/DumpRenderTree.cpp:
1256         (resetWebPreferencesToConsistentValues):
1257
1258 2017-01-20  Antoine Quint  <graouts@apple.com>
1259
1260         Web Animations should be off by default and enabled as an experimental feature
1261         https://bugs.webkit.org/show_bug.cgi?id=167115
1262         <rdar://problem/30048963>
1263
1264         Reviewed by Joseph Pecoraro.
1265
1266         Turn Web Animations on in DRT.
1267
1268         * DumpRenderTree/mac/DumpRenderTree.mm:
1269         (resetWebPreferencesToConsistentValues):
1270         * DumpRenderTree/win/DumpRenderTree.cpp:
1271         (resetWebPreferencesToConsistentValues):
1272
1273 2017-01-20  Youenn Fablet  <youenn@apple.com>
1274
1275         [WebRTC] Add libwebrtc build infrastructure
1276         https://bugs.webkit.org/show_bug.cgi?id=167207
1277
1278         Reviewed by Alex Christensen.
1279
1280         Adding a script doing the libwebrtc project json to CMake file conversion.
1281
1282         * Scripts/generate-libwebrtc-cmake: Added.
1283         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
1284         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
1285
1286 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1287
1288         Mini Browser: Show tooltip for Experimental Features
1289         https://bugs.webkit.org/show_bug.cgi?id=167225
1290
1291         Reviewed by Alex Christensen.
1292
1293         * MiniBrowser/mac/SettingsController.m:
1294         (-[SettingsController _populateMenu]):
1295         Include the full details string as a tooltip.
1296
1297 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
1298
1299         [Win] Test output results should not be written twice.
1300         https://bugs.webkit.org/show_bug.cgi?id=167197
1301
1302         Reviewed by Brent Fulgham.
1303
1304         Prevent test output from being written twice by returning early from
1305         the dump() function, if it already has been called.
1306         This patch also adds a missing newline to a test output line. 
1307         
1308         * DumpRenderTree/win/DumpRenderTree.cpp:
1309         (dump):
1310
1311 2017-01-20  Antoine Quint  <graouts@apple.com>
1312
1313         [Modern Media Controls] Turn modern media controls on by default
1314         https://bugs.webkit.org/show_bug.cgi?id=165668
1315
1316         Reviewed by Dean Jackson.
1317
1318         Enabled modern media controls by default in test runners.
1319
1320         * DumpRenderTree/TestOptions.h:
1321         * WebKitTestRunner/TestOptions.h:
1322
1323 2017-01-19  Chris Dumez  <cdumez@apple.com>
1324
1325         iterable<> should be enabled on WK1
1326         https://bugs.webkit.org/show_bug.cgi?id=167221
1327         <rdar://problem/30108531>
1328
1329         Reviewed by Youenn Fablet.
1330
1331         * DumpRenderTree/mac/DumpRenderTree.mm:
1332         (resetWebPreferencesToConsistentValues):
1333         * DumpRenderTree/win/DumpRenderTree.cpp:
1334         (resetWebPreferencesToConsistentValues):
1335         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1336         (WTR::InjectedBundle::beginTesting):
1337         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1338         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
1339         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1340
1341 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
1342
1343         Ensure status server logs go to log file
1344         https://bugs.webkit.org/show_bug.cgi?id=167210
1345
1346         Reviewed by Alexey Proskuryakov.
1347
1348         * Scripts/webkitpy/common/net/statusserver.py:
1349         (StatusServer.next_work_item): Change log level from debug to info in
1350         order to facilitate deubgging issues.
1351         (StatusServer.update_work_items): Same.
1352
1353 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
1354
1355         Additional selection tests and interpolation fix
1356         https://bugs.webkit.org/show_bug.cgi?id=167171
1357
1358         Reviewed by Simon Fraser.
1359
1360         We weren't adding the final event when interpolating event streams.
1361
1362         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1363         (-[HIDEventGenerator interpolatedEvents:]):
1364
1365 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1366
1367         [Cocoa] Variation fonts are erroneously disabled on iOS
1368         https://bugs.webkit.org/show_bug.cgi?id=167172
1369
1370         Reviewed by Simon Fraser.
1371
1372         OpenSource builders don't seem to understand sdk=embedded*.
1373
1374         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1375
1376 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1377
1378         Unreviewed. Fix GTK+ unit tests failing since r210531.
1379
1380         Avoid using paths to files that don't actually exist.
1381
1382         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
1383         (testWebKitConsoleMessageNetworkError):
1384         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1385         (testContextMenuDefaultMenu):
1386         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
1387         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
1388         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
1389
1390 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1391
1392         [GTK] Provide API to set proxy settings
1393         https://bugs.webkit.org/show_bug.cgi?id=128674
1394
1395         Reviewed by Michael Catanzaro.
1396
1397         Add tests for new proxy settings API.
1398
1399         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1400         (serverCallback):
1401         (ProxyTest::ProxyTest):
1402         (ProxyTest::~ProxyTest):
1403         (ProxyTest::loadURIAndGetMainResourceData):
1404         (ProxyTest::proxyServerPortAsString):
1405         (testWebContextProxySettings):
1406         (beforeAll):
1407
1408 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1409
1410         Add back my old email address so old commits will still match it.
1411
1412         * Scripts/webkitpy/common/config/contributors.json:
1413
1414 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1415
1416         Remove my old email address from contributors.json and watchlist.
1417
1418         * Scripts/validate-committer-lists:
1419         (CommitterListFromGit): Change the mapping to the correct email.
1420         * Scripts/webkitpy/common/config/contributors.json:
1421         * Scripts/webkitpy/common/config/watchlist:
1422
1423 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1424
1425         Unreviewed, rolling out r210848.
1426
1427         This change introduced media-related LayoutTest failures and
1428         crashes on macOS.
1429
1430         Reverted changeset:
1431
1432         "[Modern Media Controls] Turn modern media controls on by
1433         default"
1434         https://bugs.webkit.org/show_bug.cgi?id=165668
1435         http://trac.webkit.org/changeset/210848
1436
1437 2017-01-18  Andreas Kling  <akling@apple.com>
1438
1439         Document::securityOrigin() should return a reference.
1440         <https://webkit.org/b/167124>
1441
1442         Reviewed by Sam Weinig.
1443
1444         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1445         (TestWebKitAPI::TEST_F):
1446
1447 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
1448
1449         [Win] Clipboard tests are flaky.
1450         https://bugs.webkit.org/show_bug.cgi?id=167088
1451
1452         Reviewed by Brent Fulgham.
1453
1454         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
1455         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
1456
1457         * DumpRenderTree/win/DumpRenderTree.cpp:
1458         (main):
1459
1460 2017-01-18  Antoine Quint  <graouts@apple.com>
1461
1462         [Modern Media Controls] Turn modern media controls on by default
1463         https://bugs.webkit.org/show_bug.cgi?id=165668
1464
1465         Reviewed by Dean Jackson.
1466
1467         Enabled modern media controls by default in test runners. 
1468
1469         * DumpRenderTree/TestOptions.h:
1470         * WebKitTestRunner/TestOptions.h:
1471
1472 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1473
1474         Unreviewed, rolling out r210834
1475         https://bugs.webkit.org/show_bug.cgi?id=165668
1476
1477         It introduced dozens of test timeouts.
1478
1479         Reverted changeset:
1480         "[Modern Media Controls] Turn modern media controls on by default"
1481         https://bugs.webkit.org/show_bug.cgi?id=165668
1482         http://trac.webkit.org/changeset/210834
1483
1484 2017-01-17  Antoine Quint  <graouts@apple.com>
1485
1486         [Modern Media Controls] Turn modern media controls on by default
1487         https://bugs.webkit.org/show_bug.cgi?id=165668
1488
1489         Reviewed by Dean Jackson.
1490
1491         Enabled modern media controls by default in test runners. 
1492
1493         * DumpRenderTree/TestOptions.h:
1494         * WebKitTestRunner/TestOptions.h:
1495
1496 2017-01-17  Chris Dumez  <cdumez@apple.com>
1497
1498         Document title changed twice when setting document.title
1499         https://bugs.webkit.org/show_bug.cgi?id=167065
1500
1501         Reviewed by Darin Adler.
1502
1503         Add WebKit2GTK API test that was written by Michael Catanzaro.
1504
1505         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1506         (testWebViewTitleChange):
1507         (beforeAll):
1508
1509 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1510
1511         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
1512         https://bugs.webkit.org/show_bug.cgi?id=116551
1513         <rdar://problem/13949830>
1514
1515         Reviewed by Alex Christensen.
1516
1517         * Scripts/webkitperl/FeatureList.pm:
1518         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
1519         that is part of the existing WEB_TIMING feature.
1520
1521         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1522
1523 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
1524
1525         'webkit-patch post' no longer works with moved/copied files
1526         https://bugs.webkit.org/show_bug.cgi?id=166914
1527         <rdar://problem/29979707>
1528
1529         Reviewed by Daniel Bates.
1530
1531         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
1532         file outputs only the "Index:" line with an empty body.  This workaround
1533         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
1534         public email list tracking this bug is below.
1535         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
1536         
1537
1538         * Scripts/svn-create-patch:
1539         (generateDiff): Ignore an "Index:" line with an empty body.
1540
1541 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
1542
1543         Remove the REQUEST_ANIMATION_FRAME flag
1544         https://bugs.webkit.org/show_bug.cgi?id=156980
1545         <rdar://problem/25906849>
1546
1547         Reviewed by Simon Fraser.
1548
1549         * Scripts/webkitperl/FeatureList.pm:
1550         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1551
1552 2017-01-15  Sam Weinig  <sam@webkit.org>
1553
1554         Add the ability to use numbers in makeString()
1555         https://bugs.webkit.org/show_bug.cgi?id=167087
1556
1557         Reviewed by Darin Adler.
1558
1559         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1560         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
1561         Add tests for StringConcatenate, focusing on new numeric additions.
1562
1563 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1564
1565         Unreviewed, remove stale comment.
1566
1567         This test was fixed by r163173.
1568
1569         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1570
1571 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1572
1573         Annotate large string tests with largeHeap
1574         https://bugs.webkit.org/show_bug.cgi?id=167054
1575
1576         Reviewed by Filip Pizlo.
1577
1578         * Scripts/run-javascriptcore-tests:
1579         * Scripts/run-jsc-stress-tests:
1580
1581 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
1582
1583         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
1584         https://bugs.webkit.org/show_bug.cgi?id=167043
1585
1586         Reviewed by Darin Adler.
1587
1588         * Scripts/webkitperl/FeatureList.pm:
1589
1590 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
1591
1592         Remove ENABLE(DETAILS_ELEMENT) guards
1593         https://bugs.webkit.org/show_bug.cgi?id=167042
1594
1595         Reviewed by Alex Christensen.
1596
1597         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1598
1599 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
1600
1601         26 MotionMark performance tests failing
1602         https://bugs.webkit.org/show_bug.cgi?id=166854
1603
1604         Reviewed by Ryosuke Niwa.
1605
1606         Unrelated change. This is the last place that we need to rename Animometer
1607         to MotionMark.
1608
1609         * Scripts/webkitpy/common/config/watchlist:
1610
1611 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
1612
1613         run-jsc-benchmarks' echo should have -e option
1614         https://bugs.webkit.org/show_bug.cgi?id=167009
1615
1616         Reviewed by Sam Weinig.
1617
1618         echo requires `-e` option to use escape sequence.
1619         Without it, in some environment (in my Fedora 25), the escape sequence is not
1620         recognized and just dumped as `\c` etc.
1621
1622         * Scripts/run-jsc-benchmarks:
1623
1624 2017-01-12  Chris Dumez  <cdumez@apple.com>
1625
1626         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1627         https://bugs.webkit.org/show_bug.cgi?id=166995
1628
1629         Reviewed by Jer Noble.
1630
1631         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1632         as some people are having trouble building without it.
1633
1634         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1635
1636 2017-01-12  Sam Weinig  <sam@webkit.org>
1637
1638         Add the ability to filter the set of bindings tests you want to run
1639         https://bugs.webkit.org/show_bug.cgi?id=166977
1640
1641         Reviewed by Tim Horton.
1642
1643         Allows doing things like:
1644             run-bindings-tests TestObj* TestCEReactions*
1645         
1646         to run only those tests that match the patterns.
1647
1648         * Scripts/run-bindings-tests:
1649         (main):
1650         Switch to using optparse and pass the remaining args as the filters.
1651
1652         * Scripts/webkitpy/bindings/main.py:
1653         (BindingsTests.__init__):
1654         Store the pattens.
1655
1656         (BindingsTests.test_matches_patterns):
1657         Add helper predicate to determine if a test should be run. When no
1658         patterns are present, all tests should run.
1659
1660         (BindingsTests.run_tests):
1661         Filter tests using the passed in patterns.
1662
1663 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
1664
1665         Followup fix after r210503.
1666         https://bugs.webkit.org/show_bug.cgi?id=166887
1667
1668         Reviewed by Alex Christensen.
1669
1670         After <http://trac.webkit.org/changeset/210503>, test results are written to a
1671         duplicated file handle on Windows. This patch fixes the remaining call sites.
1672
1673         * DumpRenderTree/PixelDumpSupport.cpp:
1674         * DumpRenderTree/TestRunner.cpp:
1675         (TestRunner::waitToDumpWatchdogTimerFired):
1676         * DumpRenderTree/TestRunner.h:
1677         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1678         * DumpRenderTree/win/DumpRenderTree.cpp:
1679         * DumpRenderTree/win/DumpRenderTreeWin.h:
1680         * DumpRenderTree/win/TestRunnerWin.cpp:
1681         (TestRunner::setSpellCheckerLoggingEnabled):
1682
1683 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
1684
1685         Add committer status for Megan
1686         https://bugs.webkit.org/show_bug.cgi?id=166954
1687
1688         Reviewed by Tim Horton.
1689
1690         Add committer status for Megan Gardner
1691
1692         * Scripts/webkitpy/common/config/contributors.json:
1693
1694 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1695
1696         Unreviewed test fix after r210599.
1697
1698         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1699         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
1700
1701 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1702
1703         Unreviewed build fix after r210599.
1704
1705         Add missing files.
1706
1707         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1708         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1709
1710 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1711
1712         File scheme should not allow access of a resource on a different volume.
1713         https://bugs.webkit.org/show_bug.cgi?id=158552
1714         <rdar://problem/15307582>
1715
1716         Reviewed by Alex Christensen.
1717
1718         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1719         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1720         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1721
1722 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
1723
1724         Unreviewed, rolling out r210571.
1725
1726         This change broke the 32-bit macOS build and caused LayoutTest
1727         failures.
1728
1729         Reverted changeset:
1730
1731         "File scheme should not allow access of a resource on a
1732         different volume."
1733         https://bugs.webkit.org/show_bug.cgi?id=158552
1734         http://trac.webkit.org/changeset/210571
1735
1736 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1737
1738         [GTK] install-dependencies script misses gdb
1739         https://bugs.webkit.org/show_bug.cgi?id=166917
1740
1741         Reviewed by Michael Catanzaro.
1742
1743         gdb is needed for generating the crash logs.
1744
1745         * gtk/install-dependencies:
1746
1747 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1748
1749         [GTK] No way for applications to set notification permissions without waiting for permission request
1750         https://bugs.webkit.org/show_bug.cgi?id=163366
1751
1752         Reviewed by Carlos Garcia Campos.
1753
1754         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1755         (testWebViewNotification):
1756         (setInitialNotificationPermissionsAllowedCallback):
1757         (setInitialNotificationPermissionsDisallowedCallback):
1758         (testWebViewNotificationInitialPermissionAllowed):
1759         (testWebViewNotificationInitialPermissionDisallowed):
1760         (beforeAll):
1761         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1762         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1763         (WebViewTest::WebViewTest):
1764         (WebViewTest::initializeWebView):
1765         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1766
1767 2017-01-10  Tim Horton  <timothy_horton@apple.com>
1768
1769         MobileMiniBrowser tests don't work by default
1770         https://bugs.webkit.org/show_bug.cgi?id=166910
1771
1772         Reviewed by Alex Christensen.
1773
1774         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
1775         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
1776
1777 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
1778
1779         File scheme should not allow access of a resource on a different volume.
1780         https://bugs.webkit.org/show_bug.cgi?id=158552
1781         <rdar://problem/15307582>
1782
1783         Reviewed by Alex Christensen.
1784
1785         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1786         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1787         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1788
1789 2017-01-10  Mark Lam  <mark.lam@apple.com>
1790
1791         Reverting run-jsc-stress-tests' $buildType to use string values.
1792         https://bugs.webkit.org/show_bug.cgi?id=166912
1793
1794         Rubber stamped by Filip Pizlo.
1795
1796         This is so that we can test for it in the tests e.g.
1797         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
1798
1799         * Scripts/run-jsc-stress-tests:
1800
1801 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1802
1803         Temporarily add back the file removed in r210463 to unbreak internal bots.
1804
1805         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
1806
1807 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
1808
1809         svn-apply failed to apply a patch (deleting file with svn property)
1810         https://bugs.webkit.org/show_bug.cgi?id=165953
1811
1812         Reviewed by Daniel Bates.
1813
1814         * Scripts/VCSUtils.pm:
1815         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
1816         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
1817
1818 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1819
1820         Update flakiness dashboard configuration.
1821         https://bugs.webkit.org/show_bug.cgi?id=166869
1822
1823         Reviewed by Alexey Proskuryakov.
1824
1825         * TestResultServer/static-dashboards/builders.jsonp:
1826         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1827
1828 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1829
1830         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
1831         https://bugs.webkit.org/show_bug.cgi?id=165232
1832
1833         Unreviewed follow-up patch after r210539 and r210523.
1834
1835         Instead of using that environment variable, the argument
1836         --display-server=xorg should be passed now.
1837
1838         The GTK+ performance bot was the only bot using this, and is
1839         already passing --display-server=xorg after r210539.
1840
1841         * Scripts/webkitpy/port/gtk.py:
1842         (GtkPort._driver_class):
1843
1844 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1845
1846         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
1847         https://bugs.webkit.org/show_bug.cgi?id=166872
1848
1849         Reviewed by Michael Catanzaro.
1850
1851         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
1852         Define the required "--display-server=driver" in the bot additionalArguments config entry.
1853         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
1854         The step RunWebKitTests already has support for it.
1855
1856         * BuildSlaveSupport/build.webkit.org-config/config.json:
1857         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1858         (RunGtkAPITests.start):
1859         (RunAndUploadPerfTests.start):
1860         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1861
1862 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
1863
1864         Unreviewed, rolling out r210531.
1865
1866         This change broke the 32-bit macOS build and caused LayoutTest
1867         failures.
1868
1869         Reverted changeset:
1870
1871         "File scheme should not allow access of a resource on a
1872         different volume."
1873         https://bugs.webkit.org/show_bug.cgi?id=158552
1874         http://trac.webkit.org/changeset/210531
1875
1876 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
1877
1878         File scheme should not allow access of a resource on a different volume.
1879         https://bugs.webkit.org/show_bug.cgi?id=158552
1880         <rdar://problem/15307582>
1881
1882         Reviewed by Alex Christensen.
1883
1884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1885         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1886         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1887
1888 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1889
1890         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
1891         https://bugs.webkit.org/show_bug.cgi?id=165232
1892
1893         Reviewed by Michael Catanzaro.
1894
1895         Add a new WaylandDriver to run the tests in the user current wayland session.
1896
1897         Also merge all the configuration options for selecting the display server inside one
1898         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
1899
1900         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
1901
1902         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
1903         (TestRunner._create_driver):
1904         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1905         (parse_args):
1906         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1907         (PerfTestsRunner._parse_args):
1908         * Scripts/webkitpy/port/gtk.py:
1909         (GtkPort.__init__):
1910         (GtkPort._driver_class):
1911         (GtkPort._search_paths):
1912         * Scripts/webkitpy/port/waylanddriver.py: Added.
1913         (WaylandDriver):
1914         (WaylandDriver.check_driver):
1915         (WaylandDriver._setup_environ_for_test):
1916         (WaylandDriver._start):
1917
1918 2017-01-09  Andy Estes  <aestes@apple.com>
1919
1920         [QuickLook] Add a layout test for webkit.org/b/135651
1921         https://bugs.webkit.org/show_bug.cgi?id=166855
1922
1923         Reviewed by Andreas Kling.
1924
1925         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1926         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
1927         errors with code WebKitErrorCannotShowURL.
1928         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1929         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
1930         not specific to WebKit2 error codes.
1931
1932 2017-01-09  Antoine Quint  <graouts@apple.com>
1933
1934         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
1935         https://bugs.webkit.org/show_bug.cgi?id=166837
1936
1937         Reviewed by Alex Christensen.
1938
1939         We now correctly handle the --absolutePath argument in DumpRenderTree and use
1940         the provided value when trying to determine the path to the test file. Failing
1941         that, we use the computed URL or the raw path provided to cover all cases.
1942         
1943         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
1944         by applying this patch and seeing the number test failures dramatically reduced
1945         with WK1 due to the option to turn modern media controls off for older media controls
1946         tests.
1947
1948         * DumpRenderTree/DumpRenderTree.h:
1949         * DumpRenderTree/DumpRenderTreeCommon.cpp:
1950         (parseInputLine):
1951         * DumpRenderTree/TestOptions.h:
1952         * DumpRenderTree/TestOptions.mm:
1953         (TestOptions::TestOptions):
1954         * DumpRenderTree/mac/DumpRenderTree.mm:
1955         (runTest):
1956
1957 2017-01-09  Milan Crha  <mcrha@redhat.com>
1958
1959         prepare-ChangeLog: Correct help string for --style option
1960         https://bugs.webkit.org/show_bug.cgi?id=166725
1961
1962         Reviewed by Alexey Proskuryakov.
1963
1964         * Scripts/prepare-ChangeLog:
1965         (main):
1966
1967 2017-01-09  Lucas Forschler  <lforschler@apple.com>
1968
1969         https://bugs.webkit.org/show_bug.cgi?id=166839
1970         Add php7 support for macOS.
1971         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
1972
1973         Reviewed by Alexey Proskuryakov.
1974
1975         * Scripts/webkitpy/port/base.py:
1976         (Port._is_darwin_php_version_7):
1977         (Port._debian_php_version):
1978         (Port):
1979         (Port._darwin_php_version):
1980         (Port._apache_config_file_name_for_platform):
1981
1982 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1983
1984         [GTK] Should support key and code properties on keyboard events
1985         https://bugs.webkit.org/show_bug.cgi?id=166759
1986
1987         Reviewed by Carlos Garcia Campos.
1988
1989         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1990         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
1991         on tests.
1992
1993 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
1994
1995         [Win] Some tests are flaky because certain DLLs are writing to stdout.
1996         https://bugs.webkit.org/show_bug.cgi?id=166760
1997
1998         Reviewed by Darin Adler.
1999
2000         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2001         We can work around that by duplicating and redirecting stdout.
2002
2003         * DumpRenderTree/PixelDumpSupport.cpp:
2004         (dumpWebViewAsPixelsAndCompareWithExpected):
2005         (printPNG):
2006         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2007         (logEventProc):
2008         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2009         (DRTDesktopNotificationPresenter::showDesktopNotification):
2010         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2011         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2012         * DumpRenderTree/win/DumpRenderTree.cpp:
2013         (dumpFrameScrollPosition):
2014         (dumpHistoryItem):
2015         (dumpBackForwardList):
2016         (dump):
2017         (runTest):
2018         (main):
2019         * DumpRenderTree/win/DumpRenderTreeWin.h:
2020         * DumpRenderTree/win/EditingDelegate.cpp:
2021         (EditingDelegate::shouldBeginEditingInDOMRange):
2022         (EditingDelegate::shouldEndEditingInDOMRange):
2023         (EditingDelegate::shouldInsertNode):
2024         (EditingDelegate::shouldInsertText):
2025         (EditingDelegate::shouldDeleteDOMRange):
2026         (EditingDelegate::shouldChangeSelectedDOMRange):
2027         (EditingDelegate::shouldApplyStyle):
2028         (EditingDelegate::shouldChangeTypingStyle):
2029         (EditingDelegate::doPlatformCommand):
2030         (EditingDelegate::webViewDidBeginEditing):
2031         (EditingDelegate::webViewDidChange):
2032         (EditingDelegate::webViewDidEndEditing):
2033         (EditingDelegate::webViewDidChangeTypingStyle):
2034         (EditingDelegate::webViewDidChangeSelection):
2035         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2036         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2037         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2038         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2039         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2040         (FrameLoadDelegate::didCommitLoadForFrame):
2041         (FrameLoadDelegate::didReceiveTitle):
2042         (FrameLoadDelegate::didFinishLoadForFrame):
2043         (FrameLoadDelegate::didFailLoadWithError):
2044         (FrameLoadDelegate::willPerformClientRedirectToURL):
2045         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2046         (FrameLoadDelegate::windowScriptObjectAvailable):
2047         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2048         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2049         (FrameLoadDelegate::didDisplayInsecureContent):
2050         (FrameLoadDelegate::didRunInsecureContent):
2051         (FrameLoadDelegate::webViewProgressFinishedNotification):
2052         * DumpRenderTree/win/HistoryDelegate.cpp:
2053         (HistoryDelegate::didNavigateWithNavigationData):
2054         (HistoryDelegate::didPerformClientRedirectFromURL):
2055         (HistoryDelegate::didPerformServerRedirectFromURL):
2056         (HistoryDelegate::updateHistoryTitle):
2057         (HistoryDelegate::populateVisitedLinksForWebView):
2058         * DumpRenderTree/win/PolicyDelegate.cpp:
2059         (PolicyDelegate::decidePolicyForNavigationAction):
2060         (PolicyDelegate::unableToImplementPolicyWithError):
2061         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2062         (ResourceLoadDelegate::willSendRequest):
2063         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2064         (ResourceLoadDelegate::didReceiveResponse):
2065         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2066         (ResourceLoadDelegate::didFailLoadingWithError):
2067         * DumpRenderTree/win/TestRunnerWin.cpp:
2068         (TestRunner::addDisallowedURL):
2069         (TestRunner::originsWithApplicationCache):
2070         (TestRunner::setStorageDatabaseIdleInterval):
2071         (TestRunner::closeIdleLocalStorageDatabases):
2072         (TestRunner::copyDecodedHostName):
2073         (TestRunner::copyEncodedHostName):
2074         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2075         (TestRunner::isGeolocationProviderActive):
2076         (TestRunner::pathToLocalResource):
2077         (TestRunner::setMockDeviceOrientation):
2078         (TestRunner::setMockGeolocationPosition):
2079         (TestRunner::setMockGeolocationPositionUnavailableError):
2080         (TestRunner::setSpatialNavigationEnabled):
2081         (TestRunner::setAutomaticLinkDetectionEnabled):
2082         (TestRunner::isCommandEnabled):
2083         (TestRunner::authenticateSession):
2084         (TestRunner::addChromeInputField):
2085         (TestRunner::removeChromeInputField):
2086         (TestRunner::focusWebView):
2087         (TestRunner::grantWebNotificationPermission):
2088         (TestRunner::denyWebNotificationPermission):
2089         (TestRunner::removeAllWebNotificationPermissions):
2090         (TestRunner::simulateWebNotificationClick):
2091         (TestRunner::imageCountInGeneralPasteboard):
2092         * DumpRenderTree/win/UIDelegate.cpp:
2093         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2094         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2095         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2096         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2097         (UIDelegate::webViewAddMessageToConsole):
2098         (UIDelegate::exceededDatabaseQuota):
2099         (UIDelegate::setStatusText):
2100         (UIDelegate::didPressMissingPluginButton):
2101
2102 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2103
2104         Add a setting to create editable MiniBrowser windows by default
2105         https://bugs.webkit.org/show_bug.cgi?id=166806
2106
2107         Reviewed by Beth Dakin.
2108
2109         * MiniBrowser/mac/AppDelegate.m:
2110         (-[BrowserAppDelegate createBrowserWindowController:]):
2111         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2112         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2113         * MiniBrowser/mac/SettingsController.h:
2114         * MiniBrowser/mac/SettingsController.m:
2115         (-[SettingsController _populateMenu]):
2116         (-[SettingsController validateMenuItem:]):
2117         (-[SettingsController toggleCreateEditorByDefault:]):
2118         (-[SettingsController createEditorByDefault]):
2119         Add a setting and update the key equivalents accordingly.
2120         Also make sure to make the right kind of window on launch.
2121
2122 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2123
2124         Fix the 32-bit build.
2125
2126         * MiniBrowser/mac/BrowserWindowController.h:
2127         * MiniBrowser/mac/BrowserWindowController.m:
2128
2129 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2130
2131         Fix the 32-bit build.
2132
2133         * MiniBrowser/mac/BrowserWindowController.m:
2134
2135 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2136
2137         Make it possible to drop HTML files on the MiniBrowser icon
2138         https://bugs.webkit.org/show_bug.cgi?id=166802
2139
2140         Reviewed by Simon Fraser.
2141
2142         * MiniBrowser/mac/AppDelegate.m:
2143         (-[BrowserAppDelegate application:openFile:]):
2144         * MiniBrowser/mac/Info.plist:
2145         If you're using an editable window, the usual trick of dropping on the
2146         window doesn't work anymore (it makes an <attachment> instead).
2147
2148 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2149
2150         MiniBrowser window gets smaller each time it is instantiated
2151         https://bugs.webkit.org/show_bug.cgi?id=166807
2152
2153         Reviewed by Andy Estes.
2154
2155         * MiniBrowser/mac/BrowserWindowController.m:
2156         (-[BrowserWindowController windowDidLoad]):
2157         * MiniBrowser/mac/BrowserWindow.xib:
2158         Turn on full-window content view support with IB, instead of waiting
2159         until after the views have been loaded. This seems to resolve the
2160         longstanding ever-shrinking-window problem.
2161
2162 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2163
2164         Add indent/outdent items to MiniBrowser's new format menu
2165         https://bugs.webkit.org/show_bug.cgi?id=166805
2166
2167         Reviewed by Dan Bernstein.
2168
2169         * MiniBrowser/mac/MainMenu.xib:
2170
2171 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2172
2173         Add a stock Format menu to MiniBrowser
2174         https://bugs.webkit.org/show_bug.cgi?id=166804
2175
2176         Reviewed by Andy Estes.
2177
2178         * MiniBrowser/mac/MainMenu.xib:
2179         Many of the features automatically work with editable web views.
2180         However, this seems to expose a bug where none of the font-related features
2181         (Cmd-B, for example) work until the first time the font panel is shown,
2182         per process, which will need to be investigated separately.
2183
2184 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2185
2186         Remove unused applicationWillTerminate methods from MiniBrowser
2187         https://bugs.webkit.org/show_bug.cgi?id=166803
2188
2189         Reviewed by Andy Estes.
2190
2191         * MiniBrowser/mac/AppDelegate.m:
2192         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
2193         * MiniBrowser/mac/BrowserWindowController.h:
2194         * MiniBrowser/mac/BrowserWindowController.m:
2195         (-[BrowserWindowController applicationTerminating]): Deleted.
2196         * MiniBrowser/mac/WK1BrowserWindowController.m:
2197         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
2198         * MiniBrowser/mac/WK2BrowserWindowController.m:
2199         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
2200
2201 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2202
2203         Add the ability to create empty contentEditable windows in MiniBrowser
2204         https://bugs.webkit.org/show_bug.cgi?id=166801
2205
2206         Reviewed by Wenson Hsieh.
2207
2208         * MiniBrowser/mac/AppDelegate.h:
2209         * MiniBrowser/mac/AppDelegate.m:
2210         (-[BrowserAppDelegate createBrowserWindowController:]):
2211         (-[BrowserAppDelegate newWindow:]):
2212         (-[BrowserAppDelegate newEditorWindow:]):
2213         (-[BrowserAppDelegate openDocument:]):
2214         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2215         * MiniBrowser/mac/BrowserWindowController.h:
2216         * MiniBrowser/mac/BrowserWindowController.m:
2217         (-[BrowserWindowController loadHTMLString:]):
2218         (-[BrowserWindowController toggleEditable:]):
2219         * MiniBrowser/mac/MainMenu.xib:
2220         * MiniBrowser/mac/WK1BrowserWindowController.m:
2221         (-[WK1BrowserWindowController awakeFromNib]):
2222         (-[WK1BrowserWindowController loadHTMLString:]):
2223         (-[WK1BrowserWindowController validateMenuItem:]):
2224         (-[WK1BrowserWindowController setEditable:]):
2225         (-[WK1BrowserWindowController updateTitle:]):
2226         * MiniBrowser/mac/WK2BrowserWindowController.m:
2227         (-[WK2BrowserWindowController awakeFromNib]):
2228         (-[WK2BrowserWindowController validateMenuItem:]):
2229         (-[WK2BrowserWindowController setEditable:]):
2230         (-[WK2BrowserWindowController updateTitle:]):
2231         (-[WK2BrowserWindowController loadHTMLString:]):
2232         Merge more functionality from WebEditingTester.
2233         Add two menu items for creating empty editable WebKit1/2 windows.
2234         Add a menu item to the Edit menu to toggle editability on any window.
2235
2236 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2237
2238         Implement find-in-page in MiniBrowser
2239         https://bugs.webkit.org/show_bug.cgi?id=166799
2240
2241         Reviewed by Andy Estes.
2242
2243         * MiniBrowser/mac/BrowserWindow.xib:
2244         * MiniBrowser/mac/BrowserWindowController.h:
2245         * MiniBrowser/mac/BrowserWindowController.m:
2246         (-[BrowserWindowController find:]): Deleted.
2247         * MiniBrowser/mac/MainMenu.xib:
2248         * MiniBrowser/mac/WK1BrowserWindowController.m:
2249         (-[WK1BrowserWindowController toggleShrinkToFit:]):
2250         (-[WK1BrowserWindowController find:]): Deleted.
2251         * MiniBrowser/mac/WK2BrowserWindowController.m:
2252         (-[WK2BrowserWindowController awakeFromNib]):
2253         (-[WK2BrowserWindowController dealloc]):
2254         (-[WK2BrowserWindowController validateMenuItem:]):
2255         (-[WK2BrowserWindowController performTextFinderAction:]):
2256         (-[WK2BrowserWindowController findBarView]):
2257         (-[WK2BrowserWindowController setFindBarView:]):
2258         (-[WK2BrowserWindowController isFindBarVisible]):
2259         (-[WK2BrowserWindowController setFindBarVisible:]):
2260         (-[WK2BrowserWindowController contentView]):
2261         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
2262         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
2263         (-[WK2BrowserWindowController find:]): Deleted.
2264         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
2265         protocol. At first glance, it's pretty broken, but vaguely works.
2266
2267 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2268
2269         Share the implementation of MiniBrowser view hiding functionality
2270         https://bugs.webkit.org/show_bug.cgi?id=166800
2271
2272         Reviewed by Andy Estes.
2273
2274         * MiniBrowser/mac/BrowserWindowController.m:
2275         (-[BrowserWindowController showHideWebView:]):
2276         (-[BrowserWindowController removeReinsertWebView:]):
2277         * MiniBrowser/mac/WK1BrowserWindowController.m:
2278         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
2279         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
2280         * MiniBrowser/mac/WK2BrowserWindowController.m:
2281         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
2282         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
2283         Move the implementation of these two things to the shared superclass,
2284         since they don't depend on WebKit-specific things.
2285         Also, there was no reason to retain the (WK)WebView while it was unparented,
2286         as the BrowserWindowController maintains a reference the entire time.
2287
2288 2017-01-06  Andy Estes  <aestes@apple.com>
2289
2290         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
2291         https://bugs.webkit.org/show_bug.cgi?id=166789
2292
2293         Reviewed by Alex Christensen.
2294
2295         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2296         * DumpRenderTree/PlatformMac.cmake:
2297         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
2298         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
2299         * DumpRenderTree/mac/DumpRenderTree.mm:
2300         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2301         createXMLStringFromWebArchiveData().
2302         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
2303         * WebKitTestRunner/Configurations/Base.xcconfig:
2304         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
2305         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2306         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2307         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2308         createXMLStringFromWebArchiveData().
2309         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
2310         * WebKitTestRunner/PlatformMac.cmake:
2311         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2312         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
2313
2314 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2315
2316         Minor cleanups to IndentOutdentCommand and related code
2317         https://bugs.webkit.org/show_bug.cgi?id=166791
2318
2319         Reviewed by Simon Fraser.
2320
2321         * WebEditingTester/EditingOperations.m:
2322         (editingOperations):
2323         Add the outdent operation to WebEditingTester.
2324
2325 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
2326
2327         Create a plan and a patch files for MotionMark and delete the Animometer's ones
2328         https://bugs.webkit.org/show_bug.cgi?id=166785
2329
2330         Reviewed by Ryosuke Niwa.
2331
2332         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2333         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
2334
2335 2017-01-06  Antoine Quint  <graouts@apple.com>
2336
2337         Support webkit-test-runner key-value pairs in http tests
2338         https://bugs.webkit.org/show_bug.cgi?id=149812
2339
2340         Reviewed by Alex Christensen.
2341
2342         We pass the absolute path for a test through to WKTR so that we can parse
2343         tests that are running as URLs for webkit-test-runner options.
2344
2345         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2346         (parseInputLine):
2347
2348         Explicitly skip the --absolute-path option in DRT or else we'd crash.
2349
2350         * Scripts/webkitpy/port/driver.py:
2351         (Driver._command_from_driver_input):
2352
2353         Pass the absolute path to the file through the CLI.
2354
2355         * WebKitTestRunner/TestController.cpp:
2356         (WTR::updateTestOptionsFromTestHeader):
2357         (WTR::TestController::testOptionsForTest):
2358         (WTR::parseInputLine):
2359         (WTR::TestController::runTest):
2360         * WebKitTestRunner/TestController.h:
2361
2362 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2363
2364         Warning about unconnectable outlets when opening a MiniBrowser window
2365         https://bugs.webkit.org/show_bug.cgi?id=166756
2366
2367         Reviewed by Dan Bernstein.
2368
2369         * MiniBrowser/mac/BrowserWindow.xib:
2370         When launching MiniBrowser, it says:
2371         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
2372             (MBToolbarItem): missing setter or instance variable
2373         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
2374             (NSButtonCell): missing setter or instance variable.
2375
2376         It looks like someone added the connection from the share button
2377         to the BrowserWindowController three times; only one of the connections
2378         is valid. Remove the other two.
2379
2380 2017-01-05  Keith Rollin  <krollin@apple.com>
2381
2382         Add WebCore::URL::protocolHostAndPort
2383         https://bugs.webkit.org/show_bug.cgi?id=166426
2384
2385         Reviewed by Alex Christensen.
2386
2387         Add test for protocolHostAndPort.
2388
2389         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2390         (TestWebKitAPI::TEST_F):
2391
2392 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
2393
2394         [Win] Archive test result is failing.
2395         https://bugs.webkit.org/show_bug.cgi?id=166720
2396
2397         Reviewed by Alex Christensen.
2398
2399         Deleting the layout test result folder is sometimes failing
2400         on Windows. This is not a critical error.
2401
2402         * BuildSlaveSupport/test-result-archive:
2403         (archiveTestResults):
2404
2405 2017-01-04  Tomas Popela  <tpopela@redhat.com>
2406
2407         [GTK] Minibrowser: Add printing support
2408         https://bugs.webkit.org/show_bug.cgi?id=165298
2409
2410         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
2411         an error during the print, it's printed on the console.
2412
2413         Reviewed by Michael Catanzaro.
2414
2415         * MiniBrowser/gtk/BrowserWindow.c:
2416         (webKitPrintOperationFailedCallback):
2417         (printPage):
2418         (browser_window_init):
2419
2420 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
2421
2422         [css-grid] Fix crash clamping grid lines
2423         https://bugs.webkit.org/show_bug.cgi?id=166637
2424
2425         Reviewed by Darin Adler.
2426
2427         Creates new unit test to verify that the maximum tracks limit
2428         is used in GridPosition too.
2429
2430         * TestWebKitAPI/PlatformEfl.cmake:
2431         * TestWebKitAPI/PlatformGTK.cmake:
2432         * TestWebKitAPI/PlatformWin.cmake:
2433         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2434         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
2435         (TestWebKitAPI::TEST):
2436
2437 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2438
2439         Move editing history scripts to WebCore PrivateHeaders
2440         https://bugs.webkit.org/show_bug.cgi?id=166709
2441         <rdar://problem/29876612>
2442
2443         Reviewed by Dan Bernstein.
2444
2445         Update references to editing script files in WebCore that were moved.
2446
2447         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
2448
2449 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2450
2451         Unreviewed, build fix after r210313 part 2
2452         https://bugs.webkit.org/show_bug.cgi?id=166676
2453
2454         Add 'U' suffix.
2455
2456         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2457         (TestWebKitAPI::TEST):
2458         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2459         (TestWebKitAPI::TEST):
2460
2461 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2462
2463         Limit thread name appropriately
2464         https://bugs.webkit.org/show_bug.cgi?id=166676
2465
2466         Reviewed by Sam Weinig.
2467
2468         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2469         (TestWebKitAPI::TEST):
2470         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2471         (TestWebKitAPI::TEST):
2472
2473 2017-01-04  Andy Estes  <aestes@apple.com>
2474
2475         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
2476         https://bugs.webkit.org/show_bug.cgi?id=166696
2477
2478         Reviewed by Tim Horton.
2479
2480         * TestWebKitAPI/PlatformGTK.cmake:
2481         * TestWebKitAPI/PlatformWin.cmake:
2482         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2483         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
2484         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
2485         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
2486         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
2487         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
2488         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
2489
2490 2017-01-03  Brian Burg  <bburg@apple.com>
2491
2492         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
2493         https://bugs.webkit.org/show_bug.cgi?id=166003
2494         <rdar://problem/28718990>
2495
2496         Reviewed by Joseph Pecoraro.
2497
2498         Teach run-inspector-generator-tests to generate test output using the platform name
2499         derived from the directory that the test is in. For example, tests in the /generic/
2500         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
2501
2502         * Scripts/webkitpy/inspector/main.py:
2503         (InspectorGeneratorTests.generate_from_json):
2504         (InspectorGeneratorTests.run_tests):
2505         (InspectorGeneratorTests.main):
2506
2507 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
2508
2509         Unreviewed cmake buildfix after r210266.
2510
2511         * DumpRenderTree/PlatformMac.cmake:
2512
2513 2017-01-04  Tim Horton  <timothy_horton@apple.com>
2514
2515         Provide a setting for clients to always prefer low-power WebGL
2516         https://bugs.webkit.org/show_bug.cgi?id=166675
2517         <rdar://problem/29834093>
2518
2519         Reviewed by Dan Bernstein.
2520
2521         * MiniBrowser/mac/Info.plist:
2522         Have MiniBrowser claim to be a modern app that supports
2523         automatic graphics switching. WebKit needs to support automatic
2524         graphics switching, so our test app might as well. Without this
2525         Info.plist parameter, this change has no effect, and bringing up
2526         a WebGL context still brings up the discrete GPU (also true of the
2527         existing web-exposed preferLowPowerToHighPerformance API).
2528
2529 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
2530
2531         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
2532         https://bugs.webkit.org/show_bug.cgi?id=166645
2533
2534         Reviewed by Carlos Garcia Campos.
2535
2536         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2537         (TestWebKitAPI::TEST):
2538
2539 2017-01-03  Andy Estes  <aestes@apple.com>
2540
2541         Place all the Cocoa WebCore API tests in the same directory
2542         https://bugs.webkit.org/show_bug.cgi?id=166673
2543
2544         Reviewed by Michael Catanzaro.
2545
2546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2547         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
2548         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
2549         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
2550
2551 2017-01-03  Tim Horton  <timothy_horton@apple.com>
2552
2553         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
2554         https://bugs.webkit.org/show_bug.cgi?id=166450
2555         <rdar://problem/29447824>
2556
2557         Reviewed by Darin Adler.
2558
2559         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2560         * DumpRenderTree/TestRunner.cpp:
2561         (TestRunner::staticFunctions):
2562         * DumpRenderTree/mac/TestRunnerMac.mm:
2563         (setSpellCheckerLoggingEnabledCallback):
2564         * DumpRenderTree/win/TestRunnerWin.cpp:
2565         (setSpellCheckerLoggingEnabledCallback):
2566         * DumpRenderTree/mac/DumpRenderTree.mm:
2567         (resetWebViewToConsistentStateBeforeTesting):
2568         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
2569         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
2570         (stringForCorrectionResponse):
2571         (drt_NSSpellChecker_recordResponseToCorrection):
2572         (swizzleNSSpellCheckerMethodsIfNeeded):
2573         (setSpellCheckerLoggingEnabled):
2574         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
2575         set to true, logs to stdout (which ends up in the test result) whenever
2576         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
2577         is called, and then calls the original method. It is reset to false between tests.
2578
2579 2017-01-03  Sam Weinig  <sam@webkit.org>
2580
2581         Make WTF::Expected support Ref template parameters
2582         https://bugs.webkit.org/show_bug.cgi?id=166662
2583
2584         Reviewed by Alex Christensen.
2585
2586         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2587         (TestWebKitAPI::TEST):
2588         Add tests for using Ref with Expected.
2589
2590 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2591
2592         [GTK] Expose WebKitSecurityOrigin API
2593         https://bugs.webkit.org/show_bug.cgi?id=166632
2594
2595         Reviewed by Carlos Garcia Campos.
2596
2597         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2598         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
2599         (testSecurityOriginBasicConstructor):
2600         (testSecurityOriginURIConstructor):
2601         (testSecurityOriginDefaultPort):
2602         (testSecurityOriginFileURI):
2603         (testSecurityOriginDataURI):
2604         (beforeAll):
2605         (afterAll):
2606
2607 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2608
2609         [GTK] HTTP auth layout tests are flaky
2610         https://bugs.webkit.org/show_bug.cgi?id=158919
2611
2612         Reviewed by Michael Catanzaro.
2613
2614         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
2615         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
2616         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
2617         missing valac in the bots.
2618
2619 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2620
2621         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
2622         https://bugs.webkit.org/show_bug.cgi?id=165797
2623
2624         Reviewed by Michael Catanzaro.
2625
2626         Move directory ruleset after all exclude rules of Source rulset.
2627
2628         * gtk/manifest.txt.in:
2629
2630 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2631
2632         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
2633         https://bugs.webkit.org/show_bug.cgi?id=166636
2634
2635         Reviewed by Darin Adler.
2636
2637         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2638         (TestWebKitAPI::TEST):
2639
2640 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
2641
2642         [GTK] WebCore/CSSParser unit test is not being built
2643         https://bugs.webkit.org/show_bug.cgi?id=166492
2644
2645         Reviewed by Michael Catanzaro.
2646
2647         This test was introduced in r175930, but we were not building
2648         it on GTK+ port since r176015.
2649         This patch marks the test to be built again on GTK+.
2650         JFTR, the test is passing right now.
2651
2652         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
2653         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
2654
2655 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
2656
2657         AX: Expose block quote level to iOS API
2658         https://bugs.webkit.org/show_bug.cgi?id=166629
2659         <rdar://problem/29834793>
2660
2661         Reviewed by Darin Adler.
2662
2663         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2664         (AccessibilityUIElement::numberAttributeValue):
2665         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2666         (WTR::AccessibilityUIElement::numberAttributeValue):
2667
2668 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
2669
2670         SecurityOrigin::create triplet constructor does not canonicalize port
2671         https://bugs.webkit.org/show_bug.cgi?id=166624
2672
2673         Reviewed by Daniel Bates.
2674
2675         * TestWebKitAPI/PlatformGTK.cmake:
2676         * TestWebKitAPI/PlatformWin.cmake:
2677         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2678         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
2679         (TestWebKitAPI::SecurityOriginTest::SetUp):
2680         (TestWebKitAPI::TEST_F):
2681
2682 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2683
2684         [GTK] Improve user agent construction
2685         https://bugs.webkit.org/show_bug.cgi?id=142074
2686
2687         Reviewed by Carlos Garcia Campos.
2688
2689         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2690         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
2691         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2692         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
2693         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
2694         (TestWebKitAPI::TEST):
2695
2696 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2697
2698         [GTK] Improve user agent construction
2699         https://bugs.webkit.org/show_bug.cgi?id=142074
2700
2701         Reviewed by Carlos Garcia Campos.
2702
2703         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2704         (TestWebKitAPI::TEST):
2705
2706 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
2707
2708         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
2709         https://bugs.webkit.org/show_bug.cgi?id=166472
2710         rdar://problem/29675551
2711
2712         Reviewed by Tim Horton.
2713
2714         These changes are necessary to allow the mouse to leave the WTR window while
2715         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
2716         (which DRT does); we'd always go through mouseMoved, which hits an early return
2717         in WebViewImpl::mouseMoved() when the point is outside the view.
2718
2719         * WebKitTestRunner/mac/EventSenderProxy.mm:
2720         (WTR::EventSenderProxy::mouseMoveTo):
2721
2722 2016-12-23  Andy Estes  <aestes@apple.com>
2723
2724         [iOS] Fix some crashing webarchive tests
2725         https://bugs.webkit.org/show_bug.cgi?id=166470
2726
2727         Reviewed by Andreas Kling.
2728
2729         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
2730         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
2731         so this change uses that on both platforms.
2732
2733         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
2734         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
2735         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
2736         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
2737         * WebKitTestRunner/PlatformMac.cmake:
2738         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2739         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
2740
2741 2016-12-22  Saam Barati  <sbarati@apple.com>
2742
2743         WebAssembly: Silence the output of the spec-tests
2744         https://bugs.webkit.org/show_bug.cgi?id=166417
2745
2746         Reviewed by Mark Lam.
2747
2748         * Scripts/run-jsc-stress-tests:
2749
2750 2016-12-22  Zhuo Li  <zachli@apple.com>
2751
2752         [Cocoa] SPI for setloadsImagesAutomatically.
2753         https://bugs.webkit.org/show_bug.cgi?id=166401.
2754
2755         Reviewed by Darin Adler.
2756
2757         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2758         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
2759         _loadsImagesAutomatically returns YES.
2760
2761 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2762
2763         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
2764         https://bugs.webkit.org/show_bug.cgi?id=161328
2765         <rdar://problem/28475977>
2766
2767         Reviewed by Darin Adler.
2768
2769         Running a test that scales the viewport and listens to a didEndZooming callback (such as
2770         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
2771         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
2772         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
2773         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
2774         load, should prevent this from happening, but from reading documentation and code inspection, this is not
2775         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
2776         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
2777         we finish running a test and before we load the next test.
2778
2779         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
2780         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
2781         previous test started zooming and then finished before zooming completed. Since this happens before the next
2782         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
2783
2784         * WebKitTestRunner/ios/TestControllerIOS.mm:
2785         (WTR::TestController::platformResetStateToConsistentValues):
2786
2787 2016-12-22  Jer Noble  <jer.noble@apple.com>
2788
2789         Muted media element playback should not interrupt other audio playback
2790         https://bugs.webkit.org/show_bug.cgi?id=166347
2791
2792         Reviewed by Eric Carlson.
2793
2794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2795         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2796         (TestWebKitAPI::TEST):
2797         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
2798
2799 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
2800
2801         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
2802         https://bugs.webkit.org/show_bug.cgi?id=166346
2803
2804         Reviewed by Carlos Garcia Campos.
2805
2806         Enable WebRTC by default to simplify testing.
2807
2808         * MiniBrowser/gtk/main.c:
2809         (main):
2810
2811 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2812
2813         REGRESSION: API test failure: WKWebView.LocalStorageClear
2814         https://bugs.webkit.org/show_bug.cgi?id=166032
2815         <rdar://problem/29758423>
2816
2817         Reviewed by Simon Fraser.
2818
2819         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2820         to ensure that the view is destroyed before the callback fires.
2821
2822         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2823         (TEST):
2824
2825 2016-12-21  Saam Barati  <sbarati@apple.com>
2826
2827         WebAssembly: Import spec tests
2828         https://bugs.webkit.org/show_bug.cgi?id=166395
2829
2830         Rubber stamped by Keith Miller.
2831
2832         * Scripts/run-jsc-stress-tests:
2833
2834 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2835
2836         REGRESSION: API test failure: _WKDownload.OriginatingWebView
2837         https://bugs.webkit.org/show_bug.cgi?id=166033
2838         <rdar://problem/29758428>
2839
2840         Reviewed by Simon Fraser.
2841
2842         Add an @autoreleasepool around the code that allocates the WKWebView, 
2843         so that it can be destroyed by removing the last reference in _downloadDidStart.
2844
2845         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2846         (TEST):
2847
2848 2016-12-21  Daniel Bates  <dabates@apple.com>
2849
2850         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
2851         https://bugs.webkit.org/show_bug.cgi?id=166356
2852
2853         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
2854         as a means to allow a test to explicit allow an embedding client to open a new windows
2855         such that the default behavior is for the embedding client to forbid such an action.
2856         The test plugins/get-url-with-blank-target.html assumes this default behavior though
2857         it is currently skipped on WebKit2 because questions were raised in the patch for
2858         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
2859         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
2860         this test.
2861
2862         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2863         (WTR::TestRunner::setCanOpenWindows):
2864
2865 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
2866
2867         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
2868         https://bugs.webkit.org/show_bug.cgi?id=166031
2869
2870         Reviewed by Tim Horton.
2871         
2872         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2873         to ensure that the view is destroyed before the callback fires.
2874
2875         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
2876
2877 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
2878
2879         Throw Exception when test doesn't clean up HID Events properly
2880         https://bugs.webkit.org/show_bug.cgi?id=166271
2881
2882         Reviewed by Simon Fraser.
2883
2884         Add in a check when UIScriptController is deleted to make sure that the HID event
2885         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
2886         the program to crash without any good information. Crashes are race-y, and will still
2887         happen with malformed test, but the information will be much more helpful. 
2888
2889         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2890         (WTR::UIScriptController::checkForClean):
2891         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2892         (UIScriptContext::~UIScriptContext):
2893         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2894         (WTR::UIScriptController::checkForClean):
2895         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2896         * WebKitTestRunner/ios/HIDEventGenerator.h:
2897         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2898         (-[HIDEventGenerator checkHIDCallbacksClear]):
2899         * WebKitTestRunner/ios/TestControllerIOS.mm:
2900         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2901         (WTR::UIScriptController::checkForClean):
2902
2903 2016-12-20  Andy Estes  <aestes@apple.com>
2904
2905         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
2906         https://bugs.webkit.org/show_bug.cgi?id=165992
2907
2908         Reviewed by Brady Eidson.
2909
2910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2911         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
2912         (expectException):
2913         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2914         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2915         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2916         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2917         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2918         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
2919         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
2920         (TEST):
2921         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
2922
2923 2016-12-20  Dean Jackson  <dino@apple.com>
2924
2925         Remove INDIE_UI
2926         https://bugs.webkit.org/show_bug.cgi?id=165881
2927         <rdar://problem/29672532>
2928
2929         Reviewed by Simon Fraser.
2930
2931         The Indie UI work has been discontinued.
2932
2933         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2934
2935 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2936
2937         [ES6] Enable ES6 Modules
2938         https://bugs.webkit.org/show_bug.cgi?id=165849
2939
2940         Reviewed by Geoffrey Garen.
2941
2942         * DumpRenderTree/mac/DumpRenderTree.mm:
2943         (resetWebPreferencesToConsistentValues):
2944         * DumpRenderTree/win/DumpRenderTree.cpp:
2945         (resetWebPreferencesToConsistentValues):
2946         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2947         (WTR::InjectedBundle::beginTesting):
2948         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2949         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
2950         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2951
2952 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
2953
2954         Repurpose bots and clean up dashboard.
2955         https://bugs.webkit.org/show_bug.cgi?id=166045
2956
2957         Reviewed by Lucas Forschler.
2958
2959         * BuildSlaveSupport/build.webkit.org-config/config.json:
2960         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2961         (BubbleQueueServer):
2962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2963         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2964         (WebKitBuildbot):
2965         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2966         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
2967
2968 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2969
2970         [CMake] TestWebKitAPIBase links to itself
2971         https://bugs.webkit.org/show_bug.cgi?id=165985
2972
2973         Reviewed by Alex Christensen.
2974
2975         Fix CMake warning about a target linking to itself, which makes no sense.
2976
2977         * TestWebKitAPI/CMakeLists.txt:
2978
2979 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2980
2981         [GTK] GtkDoc build should be quieter
2982         https://bugs.webkit.org/show_bug.cgi?id=165994
2983
2984         Reviewed by Carlos Garcia Campos.
2985
2986         Make it not print by default.
2987
2988         * gtk/generate-gtkdoc:
2989         (get_generator_for_config):
2990         (generate_doc):
2991         * gtk/gtkdoc.py:
2992         (GTKDoc._run_command):
2993         (GTKDoc._copy_doc_files_to_output_dir):
2994
2995 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
2996
2997         Expose a way for MiniBrowser to simulate header and footer banners
2998         https://bugs.webkit.org/show_bug.cgi?id=166005
2999
3000         Reviewed by Wenson Hsieh.
3001         
3002         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3003         banners. This only works in WebKit2.
3004         
3005         We need to reset these on each navigation, since newly created FrameViews
3006         don't re-fetch the header and footer height stored on Page.
3007         
3008         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3009         as well as fixing webViewWebContentProcessDidTerminate:
3010
3011         * MiniBrowser/mac/SettingsController.h:
3012         * MiniBrowser/mac/SettingsController.m:
3013         (-[SettingsController _populateMenu]):
3014         (-[SettingsController validateMenuItem:]):
3015         (-[SettingsController toggleReserveSpaceForBanners:]):
3016         (-[SettingsController isSpaceReservedForBanners]):
3017         * MiniBrowser/mac/WK2BrowserWindowController.m:
3018         (-[WK2BrowserWindowController didChangeSettings]):
3019         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3020         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3021         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3022         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3023
3024 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3025
3026         Fix iOS test results after r209967.
3027         
3028         Subtracting out the status bar height was erroneously happening for all tests,
3029         not just for flexible viewport tests.
3030         
3031         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3032
3033         * WebKitTestRunner/PlatformWebView.h:
3034         * WebKitTestRunner/TestController.cpp:
3035         (WTR::TestController::resetStateToConsistentValues):
3036         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3037         (WTR::PlatformWebView::resizeTo):
3038         (WTR::PlatformWebView::setWindowFrame):
3039         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3040         (WTR::PlatformWebView::resizeTo):
3041         (WTR::PlatformWebView::setWindowFrame):
3042         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3043         (WTR::PlatformWebView::resizeTo):
3044         (WTR::PlatformWebView::setWindowFrame):
3045         * WebKitTestRunner/ios/TestControllerIOS.mm:
3046         (WTR::TestController::platformConfigureViewForTest):
3047         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3048         (WTR::PlatformWebView::resizeTo):
3049         (WTR::PlatformWebView::setWindowFrame):
3050
3051 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3052
3053         [EFL] bump EFL version to 1.18.4
3054         https://bugs.webkit.org/show_bug.cgi?id=166004
3055
3056         Reviewed by Gyuyoung Kim.
3057
3058         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3059
3060 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3061
3062         Visual viewports: bottom fixed elements disappear behind the keyboard
3063         https://bugs.webkit.org/show_bug.cgi?id=165983
3064         <rdar://problem/29409852>
3065
3066         Reviewed by Simon Fraser.
3067
3068         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
3069         the keyboard when it is up.
3070
3071         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3072         (WTR::UIScriptController::inputViewBounds):
3073         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3074         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3075         (WTR::UIScriptController::inputViewBounds):
3076         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3077         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3078         (WTR::viewRectForWindowRect):
3079
3080         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
3081         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
3082         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
3083
3084         (WTR::PlatformWebView::PlatformWebView):
3085         (WTR::PlatformWebView::setWindowFrame):
3086         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3087         (WTR::UIScriptController::inputViewBounds):
3088
3089 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3090
3091         Deleting a character converted from pinyin after an image causes a Safari crash
3092         https://bugs.webkit.org/show_bug.cgi?id=165839
3093         <rdar://problem/27951933>
3094
3095         Reviewed by Wenson Hsieh.
3096
3097         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
3098         while the proposed range contains an image. This should not cause a WebProcess to crash
3099         or send an invalid message to the UIProcess.
3100
3101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3102         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
3103         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
3104         (TestWebKitAPI::didFinishLoadForFrame):
3105         (TestWebKitAPI::processDidCrash):
3106         (TestWebKitAPI::invalidMessageFunction):
3107         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
3108
3109 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3110
3111         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
3112         https://bugs.webkit.org/show_bug.cgi?id=165767
3113         <rdar://problem/29602382>
3114
3115         Reviewed by Simon Fraser.
3116
3117         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
3118         WebKit2 ChangeLog for more details.
3119
3120         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3121         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3122         (WTR::UIScriptController::textSelectionCaretRect):
3123         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3124         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3125         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3126         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3127         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3128         (WTR::UIScriptController::textSelectionCaretRect):
3129         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3130         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3131         (-[TestRunnerWKWebView _setStableStateOverride:]):
3132
3133         Force the WKWebView to update its visible content rects when changing the stable state override.
3134
3135         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3136         (WTR::toNSDictionary):
3137         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3138         (WTR::UIScriptController::selectionRangeViewRects):
3139         (WTR::UIScriptController::textSelectionCaretRect):
3140         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3141         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3142
3143 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
3144
3145         Arguments called in wrong order
3146         https://bugs.webkit.org/show_bug.cgi?id=165923
3147
3148         Reviewed by Simon Fraser.
3149
3150         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
3151         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
3152
3153         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3154         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
3155         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
3156
3157 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
3158
3159         [EFL] Disable non-srcdir builds for failing libraries
3160         https://bugs.webkit.org/show_bug.cgi?id=165896
3161
3162         Reviewed by Gyuyoung Kim.
3163
3164         * efl/jhbuild.modules: Set non srcdir builds to no
3165
3166 2016-12-15  Daniel Bates  <dabates@apple.com>
3167
3168         check-style should not complain about code in icu directories
3169         https://bugs.webkit.org/show_bug.cgi?id=53929
3170
3171         Reviewed by Darin Adler.
3172
3173         Skip style checking of imported ICU headers to avoid a deluge of style issues
3174         as they do not conform to the WebKit Code Style guideline. We want to preserve
3175         the formatting of these headers so as to make it straightforward to merge
3176         changes to them, if necessary.
3177
3178         * Scripts/webkitpy/style/checker.py:
3179
3180 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
3181
3182         Move JSC testers from Yosemite to Sierra
3183         https://bugs.webkit.org/show_bug.cgi?id=165925
3184
3185         Reviewed by Lucas Forschler.
3186
3187         * BuildSlaveSupport/build.webkit.org-config/config.json:
3188         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3189         (WebKitBuildbot):
3190
3191 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
3192
3193         Add coordinate space to event streams and streamline tests
3194         https://bugs.webkit.org/show_bug.cgi?id=165119
3195
3196         Reviewed by Simon Fraser.
3197
3198         Update event streams to allow for both content and global coordinate space.
3199         Update example script to more accurately show all the available options.
3200
3201         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3202         * WebKitTestRunner/ios/HIDEventGenerator.h:
3203         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3204         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3205         (WTR::convertCoordinates):
3206         (WTR::UIScriptController::sendEventStream):
3207
3208 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
3209
3210         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
3211         https://bugs.webkit.org/show_bug.cgi?id=165855
3212
3213         Reviewed by Philippe Normand.
3214
3215         GStreamer's autogen.sh enables gtk-doc always so we end up building
3216         docs even if we disable them. Use the configure script instead, since
3217         we build from packages and these include it already.
3218
3219         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
3220         upstream gstreamer packages.
3221
3222 2016-12-15  Alex Christensen  <achristensen@webkit.org>
3223
3224         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
3225         https://bugs.webkit.org/show_bug.cgi?id=165885
3226         <rdar://problem/29476917>
3227
3228         Reviewed by Darin Adler.
3229
3230         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3231         (TestWebKitAPI::utf16String): Deleted.
3232         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
3233         (TestWebKitAPI::TEST_F):
3234         * TestWebKitAPI/WTFStringUtilities.h:
3235         (utf16String):
3236         Moved from URLParser to share with other tests.
3237
3238 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3239
3240         iOS: An element with tabindex is not focusable unless there is no mouse event handler
3241         https://bugs.webkit.org/show_bug.cgi?id=165843
3242
3243         Reviewed by Antti Koivisto.
3244
3245         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
3246         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
3247         and DumpRenderTree's runUIScript would hit an assertion :(
3248
3249         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3250         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3251         (WTR::TestRunner::isWebKit2):
3252
3253 2016-12-14  Brady Eidson  <beidson@apple.com>
3254
3255         IndexedDB 2.0: Massively speedup IDBIndex.get().
3256         https://bugs.webkit.org/show_bug.cgi?id=165802
3257
3258         Reviewed by Alex Christensen.
3259
3260         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3261         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
3262         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
3263         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
3264         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
3265
3266 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3267
3268         [GTK][EFL] Update the JHBuild version.
3269         https://bugs.webkit.org/show_bug.cgi?id=165838
3270
3271         Reviewed by Michael Catanzaro.
3272
3273         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
3274         usage of the JHBUILD_MIRROR feature with git repositories.
3275
3276 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3277
3278         [GTK] Yasm is needed for building the JHBuild after r208940
3279         https://bugs.webkit.org/show_bug.cgi?id=165837
3280
3281         Reviewed by Alejandro G. Castro.
3282
3283         * gtk/install-dependencies: Yasm is needed for building libvpx.
3284
3285 2016-12-14  Youenn Fablet  <youenn@apple.com>
3286
3287         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
3288         https://bugs.webkit.org/show_bug.cgi?id=161310
3289
3290         Reviewed by Ryosuke Niwa.
3291
3292         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
3293         When set, WTR and DRT output JS console log in the stderr and not the test output.
3294         This allows removing potentially flaky information while still being able to read it for investigation.
3295
3296         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
3297
3298         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
3299         This test should have this option when fetch API will start logging resource loader errors.
3300
3301         * DumpRenderTree/DumpRenderTree.h:
3302         (TestCommand::TestCommand): Deleted.
3303         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3304         (parseInputLine):
3305         * DumpRenderTree/TestRunner.h:
3306         (TestRunner::setDumpJSConsoleLogInStdErr):
3307         (TestRunner::dumpJSConsoleLogInStdErr):
3308         * DumpRenderTree/mac/DumpRenderTree.mm:
3309         (runTest):
3310         * DumpRenderTree/mac/UIDelegate.mm:
3311         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3312         * DumpRenderTree/win/DumpRenderTree.cpp:
3313         (runTest):
3314         * DumpRenderTree/win/UIDelegate.cpp:
3315         (UIDelegate::webViewAddMessageToConsole):
3316         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3317         (TestExpectationParser._tokenize_line):
3318         * Scripts/webkitpy/port/driver.py:
3319         (Driver._command_from_driver_input):
3320         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3321         (WTR::InjectedBundle::didReceiveMessageToPage):
3322         (WTR::InjectedBundle::dumpToStdErr):
3323         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3324         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
3325         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3326         (WTR::InjectedBundlePage::willAddMessageToConsole):
3327         * WebKitTestRunner/TestController.cpp:
3328         (WTR::parseInputLine):
3329         (WTR::TestController::runTest):
3330         (WTR::TestCommand::TestCommand): Deleted.
3331         * WebKitTestRunner/TestInvocation.cpp:
3332         (WTR::TestInvocation::invoke):
3333         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3334         * WebKitTestRunner/TestInvocation.h:
3335         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
3336
3337
3338 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
3339
3340         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
3341         https://bugs.webkit.org/show_bug.cgi?id=164022
3342
3343         Reviewed by Xabier Rodriguez-Calvar.
3344
3345         * Scripts/webkitperl/FeatureList.pm:
3346           Re-enable MEDIA_SOURCE for the GTK+ port.
3347
3348 2016-12-13  Alex Christensen  <achristensen@webkit.org>
3349
3350         Fix CMake build.
3351
3352         * DumpRenderTree/PlatformMac.cmake:
3353         Define NS_RETURNS_RETAINED as nothing for now.
3354
3355 2016-12-13  Jer Noble  <jer.noble@apple.com>
3356
3357         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
3358         https://bugs.webkit.org/show_bug.cgi?id=165697
3359
3360         Reviewed by Tim Horton.
3361
3362         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
3363         (TestWebKitAPI::TEST):
3364
3365 2016-12-13  Andy Estes  <aestes@apple.com>
3366
3367         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
3368         https://bugs.webkit.org/show_bug.cgi?id=165785
3369         <rdar://problem/26929398>
3370
3371         Reviewed by Darin Adler.
3372
3373         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3374         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
3375         expectations for the text, range, and action.
3376         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
3377         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
3378         plain-text string to the pasteboard, executed a paste action, and verified that the selected
3379         text in the web view did not change.
3380         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
3381         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
3382         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
3383         parameter.
3384         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
3385         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
3386         and returned the value of _editingDelegateShouldInsertText.
3387         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
3388         -shouldInsertText:replacingRange:givenAction:.
3389
3390 2016-12-13  Chris Dumez  <cdumez@apple.com>
3391
3392         Unreviewed, rolling out r209544.
3393
3394         Looks like r209489 did not cause the performance regression
3395         after all
3396
3397         Reverted changeset:
3398
3399         "Unreviewed, rolling out r209489."
3400         https://bugs.webkit.org/show_bug.cgi?id=165550
3401         http://trac.webkit.org/changeset/209544
3402
3403 2016-12-12  Sam Weinig  <sam@webkit.org>
3404
3405         [WebIDL] Remove use of Dictionary in ApplePaySession
3406         https://bugs.webkit.org/show_bug.cgi?id=165787
3407
3408         Reviewed by Anders Carlsson.
3409
3410         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3411         (WTR::initializeWebViewConfiguration):
3412         (WTR::TestController::platformCreateWebView):
3413         Enable ApplePay for the tests (where supported).
3414
3415 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
3416
3417         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3418         https://bugs.webkit.org/show_bug.cgi?id=165251
3419
3420         Reviewed by Youenn Fablet.
3421
3422         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
3423         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
3424         the preferences have been set.
3425
3426 2016-12-08  Antti Koivisto  <antti@apple.com>
3427
3428         Enable network cache speculative revalidation in MiniBrowser
3429         https://bugs.webkit.org/show_bug.cgi?id=165616
3430
3431         Reviewed by Darin Adler.
3432
3433         Match Safari. Also add a menu item to disable it.
3434
3435         * MiniBrowser/mac/AppDelegate.m:
3436         (defaultConfiguration):
3437         * MiniBrowser/mac/SettingsController.h:
3438         * MiniBrowser/mac/SettingsController.m:
3439         (-[SettingsController _populateMenu]):
3440         (-[SettingsController validateMenuItem:]):
3441         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
3442         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
3443
3444 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
3445
3446         ChangeLogs become readonly after resolving a conflict
3447         https://bugs.webkit.org/show_bug.cgi?id=165440
3448         rdar://problem/29491002
3449
3450         Reviewed by Darin Adler.
3451
3452         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
3453         moving the file.
3454
3455 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
3456
3457         Re-enable collectContinuously since it doesn't crash anymore
3458
3459         Rubber stamped by Michael Saboff.
3460
3461         * Scripts/run-jsc-stress-tests:
3462
3463 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
3464
3465         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
3466         https://bugs.webkit.org/show_bug.cgi?id=165686
3467
3468         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
3469         so that right config.h comes first in include path.
3470
3471 2016-12-11  Dave Hyatt  <hyatt@apple.com>
3472
3473         [CSS Parser] Make sure content extensions initialize AtomicString
3474         https://bugs.webkit.org/show_bug.cgi?id=165737
3475
3476         Reviewed by Darin Adler.
3477
3478         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3479         (TestWebKitAPI::makeBackend):
3480
3481 2016-12-08  Dave Hyatt  <hyatt@apple.com>
3482
3483         [CSS Parser] Remove the old CSS Parser
3484         https://bugs.webkit.org/show_bug.cgi?id=165645
3485
3486         Reviewed by Daniel Bates.
3487
3488         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
3489         (TestWebKitAPI::TEST):
3490
3491 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
3492
3493         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
3494         https://bugs.webkit.org/show_bug.cgi?id=165686
3495
3496         Reviewed by Michael Catanzaro.
3497
3498         This change reduces duplication of include path lists between modules,
3499         and reduces future need for fixes like r209605 (broken build because of
3500         WebCore header suddenly becoming used in WebKit2).
3501
3502         * DumpRenderTree/CMakeLists.txt:
3503         * DumpRenderTree/PlatformMac.cmake:
3504         * ImageDiff/CMakeLists.txt:
3505         * MiniBrowser/gtk/CMakeLists.txt:
3506         * MiniBrowser/mac/CMakeLists.txt:
3507         * MiniBrowser/win/CMakeLists.txt:
3508         * TestWebKitAPI/CMakeLists.txt:
3509         * TestWebKitAPI/PlatformEfl.cmake:
3510         * TestWebKitAPI/PlatformJSCOnly.cmake:
3511         * TestWebKitAPI/PlatformMac.cmake:
3512         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3513         * WebKitTestRunner/CMakeLists.txt:
3514         * WebKitTestRunner/PlatformGTK.cmake:
3515         * WebKitTestRunner/PlatformMac.cmake:
3516
3517 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
3518
3519         Unreviewed buildfix after r209630.
3520
3521         * Scripts/build-jsc: Remove building the non-existing testWASM.
3522
3523 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
3524
3525         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3526         https://bugs.webkit.org/show_bug.cgi?id=165251
3527
3528         Reviewed by Dean Jackson.
3529
3530         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
3531
3532         * DumpRenderTree/mac/DumpRenderTree.mm:
3533         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
3534
3535         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3536         (WTR::InjectedBundle::beginTesting): Ditto.
3537
3538         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3539         (WTR::TestRunner::setMediaStreamEnabled): New.
3540         (WTR::TestRunner::setPeerConnectionEnabled): New.
3541         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3542
3543 2016-12-09  Brady Eidson  <beidson@apple.com> 
3544  
3545         Re-landing:
3546         Add _WKIconLoadingDelegate SPI. 
3547         https://bugs.webkit.org/show_bug.cgi?id=164894 
3548  
3549         Reviewed by Alex Christensen. 
3550         
3551         Add MiniBrowser support for this new SPI, configurable with a setting. 
3552  
3553         * MiniBrowser/mac/SettingsController.h: 
3554         * MiniBrowser/mac/SettingsController.m: 
3555         (-[SettingsController _populateMenu]): 
3556         (-[SettingsController validateMenuItem:]): 
3557         (-[SettingsController loadsAllSiteIcons]): 
3558         (-[SettingsController toggleLoadsAllSiteIcons:]): 
3559         * MiniBrowser/mac/WK2BrowserWindowController.m: 
3560         (-[WK2BrowserWindowController awakeFromNib]): 
3561         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
3562
3563 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3564
3565         Fix the 32-bit build.
3566
3567         Unreviewed build fix.
3568
3569         * MiniBrowser/mac/SettingsController.h:
3570
3571 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3572
3573         Fedora also needs a PHP7 config file alternative
3574         https://bugs.webkit.org/show_bug.cgi?id=165606
3575
3576         Reviewed by Michael Catanzaro.
3577
3578         * Scripts/webkitpy/port/base.py:
3579         (Port._is_fedora_php_version_7): check for the php7 library.
3580         (Port._fedora_php_version): get the appropriate filename for Fedora.
3581         (Port._apache_config_file_name_for_platform):
3582
3583 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3584
3585         Complete the revert of r208865.
3586         https://bugs.webkit.org/show_bug.cgi?id=164894
3587
3588         Unreviewed build fix.
3589
3590         * MiniBrowser/mac/SettingsController.h:
3591         * MiniBrowser/mac/SettingsController.m:
3592         (-[SettingsController _populateMenu]):
3593         (-[SettingsController validateMenuItem:]):
3594         (-[SettingsController loadsAllSiteIcons]): Deleted.
3595         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
3596         * MiniBrowser/mac/WK2BrowserWindowController.m:
3597         (-[WK2BrowserWindowController awakeFromNib]):
3598         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
3599
3600 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3601
3602         [GTK] Force GDK backend to x11 when running with XvfbDriver
3603         https://bugs.webkit.org/show_bug.cgi?id=165612
3604
3605         Reviewed by Michael Catanzaro.
3606
3607         When the developer is running a Wayland session, GDK may get confused
3608         and try to use its Wayland backend (which is higher priority) instead.
3609         This ensures it will use the appropriate backend when running under
3610         Xvfb.
3611
3612         * Scripts/webkitpy/port/gtk.py:
3613         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
3614         force GDK_BACKEND to x11.
3615
3616 2016-12-08  Keith Miller  <keith_miller@apple.com>
3617
3618         Add 64-bit signed LEB decode method
3619         https://bugs.webkit.org/show_bug.cgi?id=165630
3620
3621         Reviewed by Ryosuke Niwa.
3622
3623         Add tests for LEB int64 and uint64 decode since I guess
3624         I forgot to add tests before.
3625
3626         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
3627         (TestWebKitAPI::testUInt32LEBDecode):
3628         (TestWebKitAPI::TEST):
3629         (TestWebKitAPI::testUInt64LEBDecode):
3630         (TestWebKitAPI::testInt32LEBDecode):
3631         (TestWebKitAPI::testInt64LEBDecode):
3632         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
3633
3634 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3635
3636         Make it easy to enable --force-collectContinuously
3637         https://bugs.webkit.org/show_bug.cgi?id=165638
3638
3639         Reviewed by Keith Miller.
3640
3641         * Scripts/run-javascriptcore-tests:
3642         (runJSCStressTests):
3643
3644 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3645
3646         Disable the collectContinuously mode until I investigate failures.
3647
3648         Rubber stamped by Keith Miller.
3649         
3650         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
3651         while I investigate.
3652
3653         * Scripts/run-jsc-stress-tests:
3654
3655 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3656
3657         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
3658         https://bugs.webkit.org/show_bug.cgi?id=165621
3659
3660         Reviewed by Dan Bernstein.
3661
3662         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3663         (TestWebKitAPI::TEST_F):
3664
3665 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
3666
3667         Concurrent GC should be stable enough to land enabled
3668         https://bugs.webkit.org/show_bug.cgi?id=164990
3669
3670         Reviewed by Geoffrey Garen.
3671         
3672         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
3673         
3674         It's clear that this works just fine in release, but I'm still trying to figure out if it's
3675         safe for debug. It might be too slow for debug.
3676
3677         * Scripts/run-jsc-stress-tests:
3678
3679 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3680
3681         Add SPI for sending WebsiteSettings to WebProcess during navigation
3682         https://bugs.webkit.org/show_bug.cgi?id=165517
3683         <rdar://29341068>
3684
3685         Reviewed by Anders Carlsson.
3686
3687         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3688         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
3689         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
3690         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3691         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3692         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3693         (TEST):
3694
3695 2016-12-08  Chris Dumez  <cdumez@apple.com>
3696
3697         Unreviewed, rolling out r209489.
3698
3699         Likely caused large regressions on JetStream, Sunspider and
3700         Speedometer
3701
3702         Reverted changeset:
3703
3704         "Add system trace points for JavaScript VM entry/exit"
3705         https://bugs.webkit.org/show_bug.cgi?id=165550
3706         http://trac.webkit.org/changeset/209489
3707
3708 2016-12-08  Keith Miller  <keith_miller@apple.com>
3709
3710         Move LEB tests to API tests
3711         https://bugs.webkit.org/show_bug.cgi?id=165586
3712
3713         Reviewed by Saam Barati.
3714
3715         Move the tests from testWasm.cpp and make them functions
3716         rather than macros.
3717
3718         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3719         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
3720         (TestWebKitAPI::testUnsignedLEBDecode):
3721         (TestWebKitAPI::TEST):
3722         (TestWebKitAPI::testInt32LEBDecode):
3723
3724 2016-12-08  Chris Dumez  <cdumez@apple.com>
3725
3726         Support running the layout tests offline
3727         https://bugs.webkit.org/show_bug.cgi?id=165534
3728
3729         Reviewed by Ryosuke Niwa.
3730
3731         * Scripts/webkitpy/common/system/autoinstall.py:
3732         (AutoInstaller._download_to_stream):
3733         getcode() returns None for file URLs so handle this.
3734
3735         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3736         (WebPlatformTestServer._install_modules):
3737         Deal with local path in the json file and resolve them into file URLs
3738         before using AutoInstall.
3739
3740 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3741
3742         Fix CMake build.
3743
3744         * DumpRenderTree/PlatformMac.cmake:
3745         Remove CheckedMalloc.cpp after r209516.
3746
3747 2016-12-07  Mark Lam  <mark.lam@apple.com>
3748
3749         DumpRenderTree should stop using CheckedMalloc.
3750         https://bugs.webkit.org/show_bug.cgi?id=165563
3751         <rdar://problem/28945820>
3752
3753         Reviewed by Geoffrey Garen.
3754
3755         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
3756            in CheckedMalloc.
3757         2. bmalloc does not honor the settings of CheckedMalloc.
3758
3759         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
3760         malloc.  As a result, DRT exhibits different behavior from the normal way we run
3761         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
3762         with WKTR.
3763
3764         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3765         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
3766         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
3767         * DumpRenderTree/mac/DumpRenderTree.mm:
3768         (prepareConsistentTestingEnvironment):
3769
3770 2016-12-07  Dean Jackson  <dino@apple.com>
3771
3772         Remove runtime toggle for pointer-lock
3773         https://bugs.webkit.org/show_bug.cgi?id=165577
3774         <rdar://problems/29566996>
3775
3776         Reviewed by Jon Lee.
3777
3778         Remove any runtime calls to check if pointer-lock is enabled. It's
3779         either compiled in or out.
3780
3781         * DumpRenderTree/mac/DumpRenderTree.mm:
3782         (resetWebPreferencesToConsistentValues):
3783         * WebKitTestRunner/TestController.cpp:
3784         (WTR::TestController::resetPreferencesToConsistentValues):
3785
3786 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
3787
3788         [MediaStream][Mac] Revoke sandbox extensions when capture ends
3789         https://bugs.webkit.org/show_bug.cgi?id=165476
3790
3791         Reviewed by Brady Eidson.
3792         
3793         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
3794         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
3795         is reset and recreated when a web page exits and is reloaded.
3796
3797         * TestWebKitAPI/PlatformGTK.cmake:
3798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3799         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
3800         (TestWebKitAPI::checkUserMediaPermissionCallback):
3801         (TestWebKitAPI::TEST):
3802         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
3803
3804 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
3805
3806         One esc to exit fullscreen and pointer lock
3807         https://bugs.webkit.org/show_bug.cgi?id=165416
3808         rdar://problem/29430711
3809
3810         Reviewed by Jer Noble.
3811
3812         Implement WKPageUIClientV8 for pointer lock support.
3813         Add "escape" key support in EventSenderProxy.
3814
3815         * WebKitTestRunner/TestController.cpp:
3816         (WTR::requestPointerLock):
3817         (WTR::TestController::createOtherPage):
3818         (WTR::TestController::createWebViewWithOptions):
3819         * WebKitTestRunner/mac/EventSenderProxy.mm:
3820         (WTR::EventSenderProxy::keyDown):
3821
3822 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3823
3824         Add system trace points for JavaScript VM entry/exit
3825         https://bugs.webkit.org/show_bug.cgi?id=165550
3826
3827         Reviewed by Tim Horton.
3828
3829         Add trace points for entry/exit into/out of the JS VM.
3830
3831         * Tracing/SystemTracePoints.plist:
3832
3833 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
3834
3835         [GTK] Cannot build GTK+ with CUPS 2.* versions
3836         https://bugs.webkit.org/show_bug.cgi?id=163591
3837
3838         Reviewed by Michael Catanzaro.
3839
3840         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
3841         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
3842         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
3843         old gtk+ since it requires not only bumping up glib accordingly and its consequence
3844         causes many printing test failures. So, I propose to fix the configuration issue by
3845         applying the change to the configure file directly. By doing this, we don't need to
3846         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
3847
3848         * gtk/jhbuild.modules:
3849         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
3850
3851 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3852
3853         Fix use of enum in a WK2 C SPI header.
3854         rdar://problem/28725583
3855
3856         Followup to correctly prefix the enum values.
3857
3858         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3859         (WTR::InjectedBundlePage::prepare):
3860
3861 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3862
3863         Fix use of enum in a WK2 C SPI header.
3864         rdar://problem/28725583
3865
3866         Reviewed by Dan Bernstein.
3867
3868         Use correct enum style for a C SPI header and fix the callers.
3869
3870         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3871         (WTR::InjectedBundlePage::prepare):
3872
3873 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3874
3875         Add a new project for recording and playing back editing commands in editable web content
3876         https://bugs.webkit.org/show_bug.cgi?id=165114
3877         <rdar://problem/29408135>
3878
3879         Reviewed by Beth Dakin.
3880
3881         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
3882         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
3883         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
3884         then be dragged into the playback test harness.
3885
3886         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
3887         steps:
3888
3889         1. Load the capture harness and perform test-specific editing on the web view.
3890         2. Let originalState be a dump of the DOM at this point in time.
3891         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
3892         4. Rewind all editing to the beginning.
3893         5. Playback all editing to the end.
3894         6. Dump the state of the DOM. This should be identical to originalState.
3895
3896         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
3897         * EditingHistory/EditingHistory/Info.plist: Added.
3898         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
3899         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
3900         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
3901         * EditingHistory/EditingHistory/TestRunner.h: Added.
3902         * EditingHistory/EditingHistory/TestRunner.m: Added.
3903         (injectedMessageEventHandlerScript):
3904         (-[TestRunner init]):
3905         (-[TestRunner deleteBackwards:]):
3906         (-[TestRunner typeString:]):
3907         (-[TestRunner bodyElementSubtree]):
3908         (-[TestRunner bodyTextContent]):
3909         (-[TestRunner editingHistoryJSON]):
3910         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
3911         (-[TestRunner numberOfUpdates]):
3912         (-[TestRunner jumpToUpdateIndex:]):
3913         (-[TestRunner expectEvents:afterPerforming:]):
3914         (-[TestRunner loadCaptureTestHarness]):
3915         (-[TestRunner setTextObfuscationEnabled:]):
3916         (-[TestRunner isDoneWaitingForPendingEvents]):
3917         (-[TestRunner userContentController:didReceiveScriptMessage:]):
3918
3919         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
3920         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
3921
3922         * EditingHistory/EditingHistory/TestUtil.h: Added.
3923         * EditingHistory/EditingHistory/TestUtil.m: Added.
3924         (waitUntilWithTimeout):
3925         (waitUntil):
3926
3927         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
3928
3929         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
3930         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
3931         (-[WKWebView loadPageFromBundleNamed:]):
3932         (-[WKWebView typeCharacter:]):
3933         (-[WKWebView keyPressWithCharacters:keyCode:]):
3934         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
3935
3936         Provides utilities for simulating interaction in a web view.
3937
3938         * EditingHistory/EditingHistory/main.m: Added.
3939         (main):
3940         * EditingHistory/EditingHistoryTests/Info.plist: Added.
3941         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
3942         (-[RewindAndPlaybackTests setUp]):
3943         (-[RewindAndPlaybackTests tearDown]):
3944         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
3945         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
3946         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
3947         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
3948         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
3949
3950 2016-12-07  Philippe Normand  <pnormand@igalia.com>
3951
3952         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
3953         https://bugs.webkit.org/show_bug.cgi?id=165525
3954
3955         Reviewed by Carlos Garcia Campos.
3956
3957         * gtk/jhbuild.modules: gst-plugins-good should depend on the
3958         libvpx package built within jhbuild.
3959
3960 2016-12-07  Philippe Normand  <pnormand@igalia.com>
3961
3962         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
3963         https://bugs.webkit.org/show_bug.cgi?id=165520
3964
3965         Reviewed by Carlos Garcia Campos.
3966
3967         * gtk/jhbuild.modules: Added missing dependency on openh264 in
3968         gst-plugins-bad, along with 2 upstream patches fixing the build
3969         against OpenSSL 1.1.0.
3970         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
3971         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
3972
3973 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
3974
3975         Correct SDKROOT values in xcconfig files
3976         https://bugs.webkit.org/show_bug.cgi?id=165487
3977         rdar://problem/29539209
3978
3979         Reviewed by Dan Bernstein.
3980
3981         Fix suggested by Dan Bernstein.
3982
3983         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3984         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3985         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3986         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3987         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3988         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3989
3990 2016-12-06  Daniel Bates  <dabates@apple.com>
3991
3992         WebKitTestRunner: Plugins are disabled in new windows
3993         https://bugs.webkit.org/show_bug.cgi?id=165410
3994
3995         Reviewed by Alex Christensen.
3996
3997         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
3998         a new window and loads a plugin will fail. We should enable plugins in all windows by
3999         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
4000
4001         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
4002         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
4003         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
4004
4005         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4006         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
4007         WKBundleSetPluginsEnabled().
4008         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4009         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
4010         and make use of WKBundleOverrideBoolPreferenceForTestRunner().
4011
4012 2016-12-05  Dean Jackson  <dino@apple.com>
4013
4014         pointer lock needs to be feature detectable
4015         https://bugs.webkit.org/show_bug.cgi?id=165426
4016         <rdar://problem/29486715>
4017
4018         Reviewed by Antoine Quint.
4019
4020         Expose the comment line to turn on/off pointer lock.
4021
4022         * DumpRenderTree/TestOptions.h:
4023         * DumpRenderTree/TestOptions.mm:
4024         (TestOptions::TestOptions):
4025         * DumpRenderTree/mac/DumpRenderTree.mm:
4026         (resetWebPreferencesToConsistentValues):
4027         * WebKitTestRunner/TestController.cpp:
4028         (WTR::TestController::resetPreferencesToConsistentValues):
4029         (WTR::updateTestOptionsFromTestHeader):
4030         * WebKitTestRunner/TestOptions.h:
4031         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4032         (WTR::PlatformWebView::viewSupportsOptions):
4033         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4034         (WTR::PlatformWebView::viewSupportsOptions):
4035
4036 2016-12-05  Jonathan Bedard  <jbedard@apple.com>
4037
4038         Make it possible to use an existing simulator instance for one-off testing
4039         https://bugs.webkit.org/show_bug.cgi?id=164568
4040         <rdar://problem/29189133>
4041
4042         Reviewed by Daniel Bates.
4043
4044         With this patch, if a simulator is currently running on the machine and
4045         '--dedicated-simulators' is not passed into the application, only one simulator
4046         instance will be used, and this instance will be the existing instance.
4047         If no simulator is running or '--dedicated-simulators' is passed to the script,
4048         previous behavior will be used.
4049
4050         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4051         (parse_args):
4052         * Scripts/webkitpy/port/ios.py:
4053         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
4054         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
4055         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
4056         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
4057         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
4058         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
4059         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
4060         * Scripts/webkitpy/xcode/simulator.py:
4061         (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator.
4062         (Simulator.current_device): Get currently running device.
4063
4064 2016-12-05  Dan Bernstein  <mitz@apple.com>
4065
4066         Disable a crashing test on iOS.
4067
4068         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4069
4070 2016-12-04  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4071
4072         Fix a build break on EFL since r209303.
4073
4074         Unreviewed build fix.
4075
4076         * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily.
4077
4078 2016-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
4079
4080         Refactor SymbolImpl layout
4081         https://bugs.webkit.org/show_bug.cgi?id=165247
4082
4083         Reviewed by Darin Adler.
4084
4085         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4086         (TestWebKitAPI::TEST):
4087
4088 2016-12-03  Dan Bernstein  <mitz@apple.com>
4089
4090         Fixed the build after r209307.
4091
4092         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4093         (TEST):
4094
4095 2016-12-03  Dan Bernstein  <mitz@apple.com>
4096
4097         [Cocoa] Expose InjectedBundlePageEditorClient via the Objective-C bundle SPI
4098         https://bugs.webkit.org/show_bug.cgi?id=165276
4099         <rdar://problem/29467040>
4100
4101         Reviewed by Darin Adler.
4102
4103         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4104         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Added.
4105         (-[BundleEditingDelegateRemoteObject willWriteToPasteboard:]):
4106         (-[BundleEditingDelegateRemoteObject didWriteToPasteboard]):
4107         (TEST):
4108         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Added.
4109         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4110         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:willWriteRangeToPasteboard:]):
4111         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
4112         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextControllerDidWriteToPasteboard:]):
4113         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Added.
4114
4115 2016-12-02  Andy Estes  <aestes@apple.com>
4116
4117         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
4118         https://bugs.webkit.org/show_bug.cgi?id=164492
4119
4120         Reviewed by Dan Bernstein.
4121
4122         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
4123         com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
4124         * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
4125         org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
4126         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
4127         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
4128         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
4129         PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
4130         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
4131         org.webkit.$(PRODUCT_NAME:rfc1034identifier).
4132         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
4133         com.apple.$(PRODUCT_NAME:rfc1034identifier).
4134         * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
4135         com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
4136         * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
4137         org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
4138         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
4139         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
4140         com.apple.$(PRODUCT_NAME:rfc1034identifier).
4141         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
4142         com.apple.$(PRODUCT_NAME:rfc1034identifier).
4143         * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
4144         com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
4145         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
4146         value ${PRODUCT_BUNDLE_IDENTIFIER}.
4147         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
4148         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
4149         com.apple.WebKitTestRunner.InjectedBundle.
4150         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
4151         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
4152         * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
4153         com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
4154         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
4155         CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
4156         ${PRODUCT_BUNDLE_IDENTIFIER}.
4157
4158 2016-12-02  Brady Eidson  <beidson@apple.com>
4159
4160         Make IndexedDB.WebProcessKillIDBCleanup even more reliable.
4161         https://bugs.webkit.org/show_bug.cgi?id=165330
4162
4163         Reviewed by Alex Christensen.
4164
4165         The test currently nulls out a RetainPtr<WKWebView> to try to destroy the view and kill the process.
4166
4167         Problem is that doesn't reliably destroy the view.
4168         We should explicitly kill the process instead.
4169
4170         Also, by relocating when we kill the process, we can better test behavior of the IndexedDB mechanism.
4171         e.g. We explicitly confirm that a second WebProcess can simultaneously attach to the same unique database as the first.
4172
4173         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
4174         (TEST):
4175
4176 2016-12-02  Commit Queue  <commit-queue@webkit.org>
4177
4178         Unreviewed, rolling out r209136.
4179         https://bugs.webkit.org/show_bug.cgi?id=165337
4180
4181         broke 36 webkitpy tests (Requested by mcatanzaro on #webkit).
4182
4183         Reverted changeset:
4184
4185         "Make it possible to use an existing simulator instance for
4186         one-off testing"
4187         https://bugs.webkit.org/show_bug.cgi?id=164568
4188         http://trac.webkit.org/changeset/209136
4189
4190 2016-12-02  Chris Dumez  <cdumez@apple.com>
4191
4192         [Mac][WK1] Implement new HTML interactive form validation user interface
4193         https://bugs.webkit.org/show_bug.cgi?id=164483
4194
4195         Reviewed by Simon Fraser.
4196
4197         Add support for UIScriptController's contentsOfUserInterfaceItem("validationBubble")
4198         on Mac DRT as this is needed by the HTML form validation layout tests.
4199
4200         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4201         (WTR::UIScriptController::contentsOfUserInterfaceItem):
4202
4203 2016-12-02  Brady Eidson  <beidson@apple.com>
4204
4205         IndexedDB.IndexedDBMultiProcess and IndexedDB.WebProcessKillIDBCleanup sometimes timeout.
4206         https://bugs.webkit.org/show_bug.cgi?id=160780 and https://bugs.webkit.org/show_bug.cgi?id=161001
4207
4208         Reviewed by Alexey Proskuryakov.
4209
4210         These tests had "run-loop races."
4211         
4212         The test spins the runloop waiting for one message.
4213         Two messages might come in from the WebProcess in short succession, and both be delivered to the
4214         UIProcess in the same spin of the runloop.
4215
4216         Therefore by the time the test stops spinning the runloop, notified that a message was received,
4217         the first message has been overwritten by the second.
4218
4219         These tests are fixed by queueing the incoming messages instead of just storing one.
4220
4221         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
4222         (-[IndexedDBMPMessageHandler userContentController:didReceiveScriptMessage:]):
4223         (getNextMessage):
4224         (TEST):
4225
4226         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
4227         (-[IndexedDBWebProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
4228         (getNextMessage):
4229         (TEST):
4230
4231 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
4232
4233         Add a runtime flag for SubtleCrypto
4234         https://bugs.webkit.org/show_bug.cgi?id=164982
4235
4236         Reviewed by Brent Fulgham.
4237
4238         * DumpRenderTree/mac/DumpRenderTree.mm:
4239         (resetWebPreferencesToConsistentValues):
4240         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4241         (WTR::InjectedBundle::beginTesting):
4242         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4243         (WTR::TestRunner::setSubtleCryptoEnabled):
4244         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4245
4246 2016-12-01  Alexey Proskuryakov  <ap@apple.com>
4247
4248         Remove webkitpy dependency on Eliza
4249         https://bugs.webkit.org/show_bug.cgi?id=164979
4250
4251         Reviewed by Daniel Bates.
4252
4253         This module is not on pypi, so installing it is a challenge. The jokes feel pretty old too!
4254
4255         * Scripts/webkitpy/thirdparty/__init__.py:
4256         * Scripts/webkitpy/thirdparty/__init___unittest.py: Changed mock import hook to
4257         test buildbot instead of eliza.
4258         * Scripts/webkitpy/tool/bot/ircbot.py:
4259         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
4260
4261 2016-12-01  Beth Dakin  <bdakin@apple.com>
4262
4263         Force clicking tests fail on some machines
4264         https://bugs.webkit.org/show_bug.cgi?id=165263
4265
4266         Reviewed by Tim Horton.
4267
4268         Initialize com.apple.trackpad.forceClick to 1 so that we don’t have to depend on 
4269         the user account having this feature enabled. 
4270         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4271         (WTR::InjectedBundle::platformInitialize):
4272         * WebKitTestRunner/mac/main.mm:
4273         (setDefaultsToConsistentValuesForTesting):
4274
4275 2016-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
4276
4277         Introduce StringImpl::StaticStringImpl with constexpr constructor
4278         https://bugs.webkit.org/show_bug.cgi?id=165093
4279
4280         Reviewed by Darin Adler.
4281
4282         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4283         (TestWebKitAPI::TEST):
4284
4285 2016-11-30  Antoine Quint  <graouts@apple.com>
4286
4287         [Modern Media Controls] Add an HTML comment flag to turn the feature on
4288         https://bugs.webkit.org/show_bug.cgi?id=165226
4289
4290         Reviewed by Dean Jackson.
4291
4292         Add a new flag to turn Modern Media Controls on in the test runners.
4293
4294         * DumpRenderTree/TestOptions.h:
4295         * DumpRenderTree/TestOptions.mm:
4296         (TestOptions::TestOptions):
4297         * DumpRenderTree/mac/DumpRenderTree.mm:
4298         (resetWebPreferencesToConsistentValues):
4299         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4300         (WTR::InjectedBundle::beginTesting):
4301         * WebKitTestRunner/TestController.cpp: