Unreviewed, rolling out r244434.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-18  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r244434.
4         https://bugs.webkit.org/show_bug.cgi?id=197089
5
6         caused 1 API test failure (Requested by zalan on #webkit).
7
8         Reverted changeset:
9
10         "Regression (r244291): Broken API Test
11         AutoLayoutRenderingProgressRelativeOrdering"
12         https://bugs.webkit.org/show_bug.cgi?id=196948
13         https://trac.webkit.org/changeset/244434
14
15 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
16
17         Add new compatibility mode API on WKNavigation
18         https://bugs.webkit.org/show_bug.cgi?id=197069
19         <rdar://problem/50025800>
20
21         Reviewed by Tim Horton.
22
23         Add a block property for -didCommitNavigation to TestNavigationDelegate.
24
25         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
26         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
27         (-[TestNavigationDelegate webView:didCommitNavigation:]):
28
29 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
30
31         [CMake] Make WebCore headers copies
32         https://bugs.webkit.org/show_bug.cgi?id=182512
33         <rdar://problem/37510435>
34
35         Reviewed by Alex Christensen.
36
37         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
38         ports.
39
40         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
41         of WebCore headers using "*.h" were modified to <WebCore/*.h>
42
43         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
44         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
45         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
46         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
47         * TestWebKitAPI/CMakeLists.txt:
48         * TestWebKitAPI/PlatformWin.cmake:
49         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
50         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
51         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
52
53 2019-04-18  Jer Noble  <jer.noble@apple.com>
54
55         Add support for parsing FairPlayStreaming PSSH boxes.
56         https://bugs.webkit.org/show_bug.cgi?id=197064
57
58         Reviewed by Eric Carlson.
59
60         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
61         (TestWebKitAPI::TEST):
62
63 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
64
65         InjectedBundle parameters often need initialization function called before unarchiving
66         https://bugs.webkit.org/show_bug.cgi?id=189709
67         <rdar://problem/44573653>
68
69         Reviewed by Ryosuke Niwa.
70
71         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
72         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
73
74 2019-04-18  Zalan Bujtas  <zalan@apple.com>
75
76         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
77         https://bugs.webkit.org/show_bug.cgi?id=196948
78         <rdar://problem/49927131>
79
80         Reviewed by Tim Horton.
81
82         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
83         (TEST): 
84         The expected order of incoming events is
85         1. didInvalidateIntrinsicContentSize
86         2. didFirstLayout
87         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
88         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
89         (and remember, all we care about is ordering).
90
91 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
92
93         Unreviewed, rolling out r244299.
94
95         Breaks internal tests.
96
97         Reverted changeset:
98
99         "InjectedBundle parameters often need initialization function
100         called before unarchiving"
101         https://bugs.webkit.org/show_bug.cgi?id=189709
102         https://trac.webkit.org/changeset/244299
103
104 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
105
106         [WTF] StringBuilder should set correct m_is8Bit flag when merging
107         https://bugs.webkit.org/show_bug.cgi?id=197053
108
109         Reviewed by Saam Barati.
110
111         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
112         (TestWebKitAPI::TEST):
113
114 2019-04-17  Tim Horton  <timothy_horton@apple.com>
115
116         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
117         https://bugs.webkit.org/show_bug.cgi?id=197028
118         <rdar://problem/49985290>
119
120         Reviewed by Wenson Hsieh.
121
122         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
123         (TEST):
124         Liberal application of waitForNextPresentationUpdate works around a race
125         where if the page rapidly changes its viewport arguments (or an API client
126         rapidly changes its viewport arguments), we'd get stuck thinking that the
127         user had intentionally zoomed the page, and stop resetting the initial scale.
128         This deserves a separate bug, but no need to keep the test failing while
129         we think about it.
130
131 2019-04-17  Tim Horton  <timothy_horton@apple.com>
132
133         REGRESSION (r241988): Switching tabs is slow
134         https://bugs.webkit.org/show_bug.cgi?id=197037
135         <rdar://problem/49951473>
136
137         Reviewed by Simon Fraser.
138
139         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
140         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
141         (TEST):
142         * TestWebKitAPI/cocoa/TestWKWebView.h:
143         * TestWebKitAPI/cocoa/TestWKWebView.mm:
144         (-[TestWKWebView addToTestWindow]):
145         Add a test that hangs without this fix.
146
147 2019-04-17  Truitt Savell  <tsavell@apple.com>
148
149         Unreviewed, rolling out r244400.
150
151         Caused testing to exit early with assertionon Debug WK2
152
153         Reverted changeset:
154
155         "UI↔Web deadlock when printing with a JavaScript alert
156         visible"
157         https://bugs.webkit.org/show_bug.cgi?id=196839
158         https://trac.webkit.org/changeset/244400
159
160 2019-04-17  Brady Eidson  <beidson@apple.com>
161
162         Link clicks in PDFs shouldn't send referrer headers.
163         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
164
165         Reviewed by Tim Horton.
166
167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
168         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
169         (putPDFBytesCallback):
170         (emptyReleaseInfoCallback):
171         (createPDFWithLinkToURL):
172         (TEST):
173
174 2019-04-17  Tim Horton  <timothy_horton@apple.com>
175
176         UI↔Web deadlock when printing with a JavaScript alert visible
177         https://bugs.webkit.org/show_bug.cgi?id=196839
178         <rdar://problem/49157642>
179
180         Reviewed by Andy Estes.
181
182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
183         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
184         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
185         (TEST):
186
187 2019-04-17  Alex Christensen  <achristensen@webkit.org>
188
189         WKRetainPtr's adoption constructor should be private
190         https://bugs.webkit.org/show_bug.cgi?id=197019
191
192         Reviewed by Tim Horton.
193
194         * DumpRenderTree/mac/DumpRenderTree.mm:
195         (dumpFramesAsText):
196         * TestWebKitAPI/InjectedBundleController.cpp:
197         (TestWebKitAPI::InjectedBundleController::initialize):
198         * TestWebKitAPI/PlatformUtilities.cpp:
199         (TestWebKitAPI::Util::createContextWithInjectedBundle):
200         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
201         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
202         (TestWebKitAPI::Util::toWK):
203         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
204         (TestWebKitAPI::TEST):
205         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
206         (TestWebKitAPI::TEST):
207         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
208         (TestWebKitAPI::TEST):
209         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
210         (TestWebKitAPI::TEST):
211         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
212         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
213         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
214         (TestWebKitAPI::TEST):
215         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
216         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
217         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
218         (TestWebKitAPI::TEST):
219         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
220         (TestWebKitAPI::TEST):
221         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
222         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
223         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
224         (TestWebKitAPI::TEST):
225         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
226         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
227         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
228         (TestWebKitAPI::TEST):
229         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
230         (TestWebKitAPI::TEST):
231         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
232         (TestWebKitAPI::TEST):
233         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
234         (TestWebKitAPI::TEST):
235         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
236         (TestWebKitAPI::TEST):
237         * TestWebKitAPI/Tests/WebKit/Find.cpp:
238         (TestWebKitAPI::TEST):
239         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
240         (TestWebKitAPI::TEST):
241         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
242         (TestWebKitAPI::TEST):
243         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
244         (TestWebKitAPI::TEST):
245         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
246         (TestWebKitAPI::TEST):
247         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
248         (TestWebKitAPI::TEST):
249         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
250         (TestWebKitAPI::TEST):
251         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
252         (TestWebKitAPI::TEST):
253         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
254         (TestWebKitAPI::TEST):
255         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
256         (TestWebKitAPI::TEST):
257         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
258         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
259         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
260         (TestWebKitAPI::TEST):
261         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
262         (TestWebKitAPI::TEST):
263         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
264         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
265         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
266         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
267         (TestWebKitAPI::TEST):
268         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
269         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
270         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
271         (TestWebKitAPI::TEST):
272         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
273         (TestWebKitAPI::TEST):
274         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
275         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
276         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
277         (TestWebKitAPI::TEST):
278         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
279         (TestWebKitAPI::loadAlternateHTMLString):
280         (TestWebKitAPI::TEST):
281         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
282         (TestWebKitAPI::TEST):
283         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
284         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
285         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
286         (TestWebKitAPI::buildAndPerformTest):
287         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
288         (TestWebKitAPI::TEST):
289         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
290         (TestWebKitAPI::TEST):
291         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
292         (TestWebKitAPI::TEST):
293         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
294         (TestWebKitAPI::TEST):
295         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
296         (TestWebKitAPI::TEST):
297         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
298         (TestWebKitAPI::TEST):
299         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
300         (TestWebKitAPI::TEST):
301         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
302         (TestWebKitAPI::TEST):
303         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
304         (TestWebKitAPI::TEST):
305         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
306         (TestWebKitAPI::TEST):
307         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
308         (TestWebKitAPI::TEST):
309         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
310         (TestWebKitAPI::TEST):
311         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
312         (TestWebKitAPI::TEST):
313         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
314         (TestWebKitAPI::TEST):
315         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
316         (TestWebKitAPI::TEST):
317         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
318         (TestWebKitAPI::TEST):
319         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
320         (TestWebKitAPI::TEST):
321         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
322         (TestWebKitAPI::TEST):
323         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
324         (TestWebKitAPI::TEST):
325         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
326         (TestWebKitAPI::TEST):
327         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
328         (TestWebKitAPI::TEST):
329         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
330         (TestWebKitAPI::TEST):
331         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
332         (TestWebKitAPI::TEST):
333         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
334         (TestWebKitAPI::TEST):
335         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
336         (TestWebKitAPI::TEST):
337         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
338         (TestWebKitAPI::TEST):
339         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
340         (TestWebKitAPI::TEST):
341         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
342         (TestWebKitAPI::TEST):
343         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
344         (TestWebKitAPI::TEST):
345         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
346         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
347         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
348         (TestWebKitAPI::TEST):
349         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
350         (TestWebKitAPI::TEST):
351         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
352         (TestWebKitAPI::TEST):
353         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
354         (TestWebKitAPI::TEST):
355         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
356         (TestWebKitAPI::TEST):
357         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
358         (TestWebKitAPI::TEST):
359         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
360         (TestWebKitAPI::TEST):
361         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
362         (TestWebKitAPI::TEST):
363         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
364         (TestWebKitAPI::TEST):
365         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
366         (TestWebKitAPI::TEST):
367         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
368         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
369         (TEST):
370         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
371         (TEST):
372         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
373         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
374         (TEST):
375         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
376         (TestWebKitAPI::TEST):
377         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
378         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
379         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
380         (WTR::getMenuItemTitleCallback):
381         (WTR::createMouseMessageBody):
382         (WTR::EventSendingController::mouseDown):
383         (WTR::EventSendingController::mouseUp):
384         (WTR::EventSendingController::mouseMoveTo):
385         (WTR::EventSendingController::mouseForceClick):
386         (WTR::EventSendingController::startAndCancelMouseForceClick):
387         (WTR::EventSendingController::mouseForceDown):
388         (WTR::EventSendingController::mouseForceUp):
389         (WTR::EventSendingController::mouseForceChanged):
390         (WTR::EventSendingController::leapForward):
391         (WTR::EventSendingController::scheduleAsynchronousClick):
392         (WTR::createKeyDownMessageBody):
393         (WTR::EventSendingController::keyDown):
394         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
395         (WTR::EventSendingController::mouseScrollBy):
396         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
397         (WTR::EventSendingController::continuousMouseScrollBy):
398         (WTR::EventSendingController::addTouchPoint):
399         (WTR::EventSendingController::updateTouchPoint):
400         (WTR::EventSendingController::setTouchModifier):
401         (WTR::EventSendingController::setTouchPointRadius):
402         (WTR::EventSendingController::touchStart):
403         (WTR::EventSendingController::touchMove):
404         (WTR::EventSendingController::touchEnd):
405         (WTR::EventSendingController::touchCancel):
406         (WTR::EventSendingController::clearTouchPoints):
407         (WTR::EventSendingController::releaseTouchPoint):
408         (WTR::EventSendingController::cancelTouchPoint):
409         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
410         (WTR::InjectedBundle::didCreatePage):
411         (WTR::InjectedBundle::didReceiveMessage):
412         (WTR::InjectedBundle::didReceiveMessageToPage):
413         (WTR::InjectedBundle::booleanForKey):
414         (WTR::InjectedBundle::done):
415         (WTR::InjectedBundle::dumpToStdErr):
416         (WTR::InjectedBundle::outputText):
417         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
418         (WTR::InjectedBundle::postAddChromeInputField):
419         (WTR::InjectedBundle::postRemoveChromeInputField):
420         (WTR::InjectedBundle::postFocusWebView):
421         (WTR::InjectedBundle::postSetBackingScaleFactor):
422         (WTR::InjectedBundle::postSetWindowIsKey):
423         (WTR::InjectedBundle::postSetViewSize):
424         (WTR::InjectedBundle::postSimulateWebNotificationClick):
425         (WTR::InjectedBundle::postSetAddsVisitedLinks):
426         (WTR::InjectedBundle::setGeolocationPermission):
427         (WTR::InjectedBundle::setMockGeolocationPosition):
428         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
429         (WTR::InjectedBundle::isGeolocationProviderActive const):
430         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
431         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
432         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
433         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
434         (WTR::InjectedBundle::setCustomPolicyDelegate):
435         (WTR::InjectedBundle::setHidden):
436         (WTR::InjectedBundle::setCacheModel):
437         (WTR::InjectedBundle::shouldProcessWorkQueue const):
438         (WTR::InjectedBundle::processWorkQueue):
439         (WTR::InjectedBundle::queueBackNavigation):
440         (WTR::InjectedBundle::queueForwardNavigation):
441         (WTR::InjectedBundle::queueLoad):
442         (WTR::InjectedBundle::queueLoadHTMLString):
443         (WTR::InjectedBundle::queueReload):
444         (WTR::InjectedBundle::queueLoadingScript):
445         (WTR::InjectedBundle::queueNonLoadingScript):
446         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
447         (WTR::frameToStr):
448         (WTR::InjectedBundlePage::InjectedBundlePage):
449         (WTR::dumpFrameDescriptionSuitableForTestResult):
450         (WTR::dumpFrameScrollPosition):
451         (WTR::dumpDescendantFrameScrollPositions):
452         (WTR::dumpFrameText):
453         (WTR::dumpDescendantFramesText):
454         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
455         (WTR::TestRunner::shouldDumpPixels const):
456         (WTR::TestRunner::setDumpPixels):
457         (WTR::TestRunner::whatToDump const):
458         (WTR::TestRunner::setWhatToDump):
459         (WTR::TestRunner::setWaitUntilDone):
460         (WTR::TestRunner::shouldWaitUntilDone const):
461         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
462         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
463         (WTR::TestRunner::clearAllDatabases):
464         (WTR::TestRunner::setIDBPerOriginQuota):
465         (WTR::TestRunner::originsWithApplicationCache):
466         (WTR::TestRunner::setCanOpenWindows):
467         (WTR::TestRunner::setXSSAuditorEnabled):
468         (WTR::TestRunner::setMediaDevicesEnabled):
469         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
470         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
471         (WTR::TestRunner::setCustomUserAgent):
472         (WTR::TestRunner::setWebAPIStatisticsEnabled):
473         (WTR::TestRunner::setModernMediaControlsEnabled):
474         (WTR::TestRunner::setWebGL2Enabled):
475         (WTR::TestRunner::setWritableStreamAPIEnabled):
476         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
477         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
478         (WTR::TestRunner::setAllowsAnySSLCertificate):
479         (WTR::TestRunner::setPluginsEnabled):
480         (WTR::TestRunner::setValueForUser):
481         (WTR::TestRunner::setAudioResult):
482         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
483         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
484         (WTR::TestRunner::setAlwaysAcceptCookies):
485         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
486         (WTR::TestRunner::isDoingMediaCapture const):
487         (WTR::TestRunner::queueLoad):
488         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
489         (WTR::TestRunner::setHandlesAuthenticationChallenges):
490         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
491         (WTR::TestRunner::setShouldLogDownloadCallbacks):
492         (WTR::TestRunner::setAuthenticationUsername):
493         (WTR::TestRunner::setAuthenticationPassword):
494         (WTR::TestRunner::secureEventInputIsEnabled const):
495         (WTR::TestRunner::setBlockAllPlugins):
496         (WTR::TestRunner::setPluginSupportedMode):
497         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
498         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
499         (WTR::TestRunner::setNavigationGesturesEnabled):
500         (WTR::TestRunner::setIgnoresViewportScaleLimits):
501         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
502         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
503         (WTR::TestRunner::terminateNetworkProcess):
504         (WTR::TestRunner::terminateServiceWorkerProcess):
505         (WTR::TestRunner::runUIScript):
506         (WTR::TestRunner::setStatisticsDebugMode):
507         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
508         (WTR::TestRunner::setStatisticsLastSeen):
509         (WTR::TestRunner::setStatisticsPrevalentResource):
510         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
511         (WTR::TestRunner::dumpResourceLoadStatistics):
512         (WTR::TestRunner::isStatisticsPrevalentResource):
513         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
514         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
515         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
516         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
517         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
518         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
519         (WTR::TestRunner::setStatisticsGrandfathered):
520         (WTR::TestRunner::isStatisticsGrandfathered):
521         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
522         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
523         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
524         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
525         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
526         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
527         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
528         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
529         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
530         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
531         (WTR::TestRunner::statisticsUpdateCookieBlocking):
532         (WTR::TestRunner::statisticsSubmitTelemetry):
533         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
534         (WTR::TestRunner::setStatisticsIsRunningTest):
535         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
536         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
537         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
538         (WTR::TestRunner::setStatisticsGrandfatheringTime):
539         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
540         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
541         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
542         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
543         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
544         (WTR::TestRunner::statisticsDeleteCookiesForHost):
545         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
546         (WTR::TestRunner::statisticsResetToConsistentState):
547         (WTR::TestRunner::setStorageAccessAPIEnabled):
548         (WTR::TestRunner::getAllStorageAccessEntries):
549         (WTR::TestRunner::addMockMediaDevice):
550         (WTR::TestRunner::clearMockMediaDevices):
551         (WTR::TestRunner::removeMockMediaDevice):
552         (WTR::TestRunner::resetMockMediaDevices):
553         (WTR::TestRunner::connectMockGamepad):
554         (WTR::TestRunner::disconnectMockGamepad):
555         (WTR::TestRunner::setMockGamepadDetails):
556         (WTR::TestRunner::setMockGamepadAxisValue):
557         (WTR::TestRunner::setMockGamepadButtonValue):
558         (WTR::TestRunner::removeAllSessionCredentials):
559         (WTR::TestRunner::clearDOMCache):
560         (WTR::TestRunner::clearDOMCaches):
561         (WTR::TestRunner::hasDOMCache):
562         (WTR::TestRunner::domCacheSize):
563         (WTR::TestRunner::setAllowStorageQuotaIncrease):
564         (WTR::TestRunner::getApplicationManifestThen):
565         (WTR::TestRunner::injectUserScript):
566         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
567         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
568         (WTR::TestRunner::addTestKeyToKeychain):
569         (WTR::TestRunner::cleanUpKeychain):
570         (WTR::TestRunner::keyExistsInKeychain):
571         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
572         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
573         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
574         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
575         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
576         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
577         * WebKitTestRunner/TestController.cpp:
578         (WTR::TestController::initialize):
579         (WTR::parseStringTestHeaderValueAsRelativePath):
580         (WTR::updateTestOptionsFromTestHeader):
581         (WTR::TestController::runTest):
582         (WTR::TestController::didReceiveLiveDocumentsList):
583         (WTR::TestController::didReceiveMessageFromInjectedBundle):
584         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
585         (WTR::TestController::didFinishNavigation):
586         (WTR::TestController::didReceiveAuthenticationChallenge):
587         * WebKitTestRunner/TestInvocation.cpp:
588         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
589         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
590         (WTR::TestInvocation::uiScriptDidComplete):
591         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
592         * WebKitTestRunner/WebNotificationProvider.cpp:
593         (WTR::WebNotificationProvider::closeWebNotification):
594         * WebKitTestRunner/WorkQueueManager.cpp:
595         (WTR::ScriptItem::ScriptItem):
596         (WTR::WorkQueueManager::queueLoad):
597         (WTR::WorkQueueManager::queueLoadHTMLString):
598
599 2019-04-17  Alex Christensen  <achristensen@webkit.org>
600
601         Add a comment to make my test from r244139 less mysterious.
602         https://bugs.webkit.org/show_bug.cgi?id=196744
603
604         As suggested by Darin Adler.
605
606         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
607         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
608
609 2019-04-17  Chris Dumez  <cdumez@apple.com>
610
611         Remember device orientation permission for the duration of the browsing session
612         https://bugs.webkit.org/show_bug.cgi?id=196992
613         <rdar://problem/49946067>
614
615         Reviewed by Alex Christensen.
616
617         Add API test coverage.
618
619         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
620         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
621         (TEST):
622
623 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
624
625         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
626         https://bugs.webkit.org/show_bug.cgi?id=196675
627
628         Reviewed by Lucas Forschler.
629
630         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
631         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
632
633 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
634
635         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
636         https://bugs.webkit.org/show_bug.cgi?id=196919
637         <rdar://problem/41630459>
638
639         Reviewed by Tim Horton.
640
641         Add iOS support for several new testing hooks. See below for more detail.
642
643         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
644         (WTR::UIScriptController::isDismissingMenu const):
645
646         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
647         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
648         by UIKit when dismissing the callout bar (i.e. UIMenuController).
649
650         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
651         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
652         (WTR::UIScriptController::isDismissingMenu const):
653         * TestRunnerShared/UIScriptContext/UIScriptController.h:
654         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
655         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
656         (WTR::InjectedBundle::didReceiveMessageToPage):
657         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
658         (WTR::TestRunner::setAllowedMenuActions):
659
660         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
661         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
662         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
663         against the name of the custom action.
664
665         (WTR::TestRunner::installCustomMenuAction):
666
667         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
668         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
669         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
670         triggered.
671
672         (WTR::TestRunner::performCustomMenuAction):
673
674         Invoked when the custom menu action is triggered.
675
676         * WebKitTestRunner/InjectedBundle/TestRunner.h:
677         * WebKitTestRunner/TestController.cpp:
678         (WTR::TestController::installCustomMenuAction):
679         (WTR::TestController::setAllowedMenuActions):
680         * WebKitTestRunner/TestController.h:
681         * WebKitTestRunner/TestInvocation.cpp:
682         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
683         (WTR::TestInvocation::performCustomMenuAction):
684
685         Add plumbing to call back into the injected bundle when performing the custom action.
686
687         * WebKitTestRunner/TestInvocation.h:
688         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
689         (WTR::TestController::installCustomMenuAction):
690         (WTR::TestController::setAllowedMenuActions):
691         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
692         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
693         (-[TestRunnerWKWebView initWithFrame:configuration:]):
694         (-[TestRunnerWKWebView becomeFirstResponder]):
695         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
696
697         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
698         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
699         in the Mail app on iOS.
700
701         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
702         (-[TestRunnerWKWebView setAllowedMenuActions:]):
703         (-[TestRunnerWKWebView resetCustomMenuAction]):
704         (-[TestRunnerWKWebView performCustomAction:]):
705         (-[TestRunnerWKWebView canPerformAction:withSender:]):
706         (-[TestRunnerWKWebView _willHideMenu]):
707         (-[TestRunnerWKWebView _didHideMenu]):
708         * WebKitTestRunner/ios/TestControllerIOS.mm:
709         (WTR::TestController::platformResetStateToConsistentValues):
710
711         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
712         if specified.
713
714         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
715         (WTR::UIScriptController::isDismissingMenu const):
716
717 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
718
719         Allow sharing from imageSheet on an image document
720         https://bugs.webkit.org/show_bug.cgi?id=196891
721         <rdar://problem/25377386>
722
723         Reviewed by Tim Horton.
724
725         Test to make sure that the correct imageURL is extracted from an image element.
726
727         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
728         (TestWebKitAPI::TEST):
729
730 2019-04-16  Alex Christensen  <achristensen@webkit.org>
731
732         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
733         https://bugs.webkit.org/show_bug.cgi?id=196995
734
735         Reviewed by Brady Eidson.
736
737         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
738         (TEST):
739
740 2019-04-16  Chris Dumez  <cdumez@apple.com>
741
742         URL set by document.open() is not communicated to the UIProcess
743         https://bugs.webkit.org/show_bug.cgi?id=196941
744         <rdar://problem/49237544>
745
746         Reviewed by Geoff Garen.
747
748         Add API test coverage.
749
750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
751         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
752         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
753         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
754         (TEST):
755
756 2019-04-16  Commit Queue  <commit-queue@webkit.org>
757
758         Unreviewed, rolling out r244321.
759         https://bugs.webkit.org/show_bug.cgi?id=196968
760
761         Causing all WK2 Debug builds to exit early after Assertion
762         failures. (Requested by ShawnRoberts on #webkit).
763
764         Reverted changeset:
765
766         "URL set by document.open() is not communicated to the
767         UIProcess"
768         https://bugs.webkit.org/show_bug.cgi?id=196941
769         https://trac.webkit.org/changeset/244321
770
771 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
772
773         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
774         https://bugs.webkit.org/show_bug.cgi?id=196948
775
776         Reviewed by Zalan Bujtas.
777
778         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
779         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
780
781 2019-04-15  Chris Dumez  <cdumez@apple.com>
782
783         URL set by document.open() is not communicated to the UIProcess
784         https://bugs.webkit.org/show_bug.cgi?id=196941
785         <rdar://problem/49237544>
786
787         Reviewed by Geoffrey Garen.
788
789         Add API test coverage.
790
791         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
792         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
793         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
794         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
795         (TEST):
796
797 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
798
799         Using Tools/Scripts/clean-webkit should not install requests
800         https://bugs.webkit.org/show_bug.cgi?id=196940
801
802         Reviewed by Lucas Forschler.
803
804         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
805         existing, depending on the path autoinstalled is run through.
806         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
807         needed.
808         (Port.configuration_for_upload):
809         (Port.commits_for_upload):
810
811 2019-04-15  Alex Christensen  <achristensen@webkit.org>
812
813         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
814         https://bugs.webkit.org/show_bug.cgi?id=196773
815
816         Reviewed by Jer Noble.
817
818         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
819         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
820         (TEST):
821
822 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
823
824         ews-build should clearly indicate flaky test failures
825         https://bugs.webkit.org/show_bug.cgi?id=196947
826
827         Reviewed by Lucas Forschler.
828
829         * BuildSlaveSupport/ews-build/steps.py:
830         (AnalyzeAPITestsResults.analyzeResults):
831
832 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
833
834         InjectedBundle parameters often need initialization function called before unarchiving
835         https://bugs.webkit.org/show_bug.cgi?id=189709
836         <rdar://problem/44573653>
837
838         Reviewed by Ryosuke Niwa.
839
840         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
841         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
842
843 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
844
845         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
846         https://bugs.webkit.org/show_bug.cgi?id=196681
847
848         Reviewed by Darin Adler.
849
850         Added tests.
851
852         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
853         (WTF_HashSet.RemoveIf):
854         (WTF_HashSet.RemoveIfShrinkToBestSize):
855
856 2019-04-15  John Wilander  <wilander@apple.com>
857
858         Send delayed Ad Click Attribution conversion requests to the click source
859         https://bugs.webkit.org/show_bug.cgi?id=196838
860         <rdar://problem/47650157>
861
862         Reviewed by Chris Dumez and Youenn Fablet.
863
864         This patch adds test infrastructure to override the default behavior in
865         WebKit::NetworkAdClickAttribution.
866
867         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
868         (TestWebKitAPI::TEST):
869         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
870         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
871         (WTR::TestRunner::dumpAdClickAttribution):
872         (WTR::TestRunner::clearAdClickAttribution):
873         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
874         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
875         * WebKitTestRunner/InjectedBundle/TestRunner.h:
876         * WebKitTestRunner/TestController.cpp:
877         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
878         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
879         * WebKitTestRunner/TestController.h:
880         * WebKitTestRunner/TestInvocation.cpp:
881         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
882
883 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
884
885         [ews-app] status-bubble should display position in queue
886         https://bugs.webkit.org/show_bug.cgi?id=196607
887
888         Reviewed by Lucas Forschler.
889
890         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
891         (StatusBubble._build_bubble):
892         (StatusBubble._queue_position): Method to calculate patch's position in queue.
893
894 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
895
896         [ews-build] Do not run clean build by default on EWS builders
897         https://bugs.webkit.org/show_bug.cgi?id=196897
898
899         Reviewed by Lucas Forschler.
900
901         * BuildSlaveSupport/ews-build/steps.py:
902         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
903         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
904         untracked directories like WebKitBuild).
905         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
906         untracked files/directories (like WebKitBuild).
907
908 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
909
910         TestRunner::notifyDone() should be safely reentrant
911         https://bugs.webkit.org/show_bug.cgi?id=196898
912
913         Reviewed by Darin Adler.
914
915         It is currently possible that TestRunner::notifyDone() will call itself, since
916         notifyDone() will force a repaint, which can start executing JavaScript, which
917         may call notifyDone() again. This can lead to test failures and flakiness.
918         Fix this by setting the m_waitToDump flag before calling the dump() method.
919
920         * DumpRenderTree/mac/TestRunnerMac.mm:
921         (TestRunner::notifyDone):
922         (TestRunner::forceImmediateCompletion):
923         * DumpRenderTree/win/TestRunnerWin.cpp:
924         (TestRunner::notifyDone):
925         (TestRunner::forceImmediateCompletion):
926
927 2019-04-15  Philippe Normand  <pnormand@igalia.com>
928
929         [GTK][WPE] Add enable-media websetting
930         https://bugs.webkit.org/show_bug.cgi?id=196863
931
932         Reviewed by Michael Catanzaro.
933
934         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
935         (testWebKitSettings): Add test for the enable-media web-setting.
936
937 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
938
939         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
940         https://bugs.webkit.org/show_bug.cgi?id=196905
941         <rdar://problem/49886096>
942
943         Reviewed by Tim Horton.
944
945         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
946         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
947         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
948         delay timer, we end up with this sequence of events in the problematic (failure) case:
949
950         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
951             ...IPC from UI to web process...
952         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
953             ...IPC from web to UI process...
954         (c) [UI]    Invoke completion handler for script #1
955         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
956             ...IPC from UI to web process...
957         (e) [Web]   Evaluate script #2 in the web process
958         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
959
960         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
961         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
962         #2 is run in step (e).
963
964         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
965         the UI process by waiting on a script message posted by the web process, after attachment updates are
966         dispatched.
967
968         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
969         (TestWebKitAPI::TEST):
970
971 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
972
973         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
974         https://bugs.webkit.org/show_bug.cgi?id=196909
975
976         Reviewed by Wenson Hsieh.
977
978         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
979         (TestWebKitAPI::TEST):
980
981 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
982
983         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
984         https://bugs.webkit.org/show_bug.cgi?id=196880
985
986         Reviewed by Yusuke Suzuki.
987
988         Add a new function for bytecode cache tests that does not forceDiskCache
989         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
990         test added in this patch, since the code is invalid and therefore won't be
991         cached. It should also be useful for tests that evaluate dynamically
992         generated code.
993
994         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
995         * Scripts/run-jsc-stress-tests:
996
997 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
998
999         Update AudioSession route sharing policy
1000         https://bugs.webkit.org/show_bug.cgi?id=196776
1001         <rdar://problem/46501611>
1002
1003         Reviewed by Jer Noble.
1004
1005         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1006         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1007         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1008         (TestWebKitAPI::TEST):
1009
1010 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1011
1012         [iOS] Software keyboard is shown too frequently on some websites
1013         https://bugs.webkit.org/show_bug.cgi?id=195856
1014         <rdar://problem/49191395>
1015
1016         Reviewed by Darin Adler.
1017
1018         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1019
1020         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1021         (WTR::UIScriptController::setHardwareKeyboardAttached):
1022         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1023         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1024         (WTR::UIScriptController::setHardwareKeyboardAttached):
1025         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1026         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1027
1028         Additionally link against GraphicsServices in WebKitTestRunner.
1029
1030         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1031         (WTR::TestController::platformResetStateToConsistentValues):
1032         (WTR::UIScriptController::setHardwareKeyboardAttached):
1033
1034 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1035
1036         [GTK][WPE] Fix pacman install-dependencies packages
1037         https://bugs.webkit.org/show_bug.cgi?id=196817
1038
1039         Reviewed by Žan Doberšek.
1040         
1041         python3-setuptools is called python-setuptools
1042         ruby-highline is only available on AUR
1043         libv4l-devel is incorporated in v4l-utils
1044
1045         * gtk/install-dependencies:
1046         * wpe/install-dependencies:
1047
1048 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1049
1050         [GTK] REGRESSION(r243860): Many tests failing
1051         https://bugs.webkit.org/show_bug.cgi?id=196791
1052
1053         Reviewed by Joanmarie Diggs.
1054
1055         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1056         multiple documents and check that accessibility hierarchy is updated after a navigation.
1057
1058         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1059         (loadChangedCallback):
1060         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1061         (AccessibilityTest::AccessibilityTest):
1062         (AccessibilityTest::~AccessibilityTest):
1063         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1064         (AccessibilityTest::findTestServerApplication):
1065         (AccessibilityTest::findDocumentWeb):
1066         (AccessibilityTest::findRootObject):
1067         (AccessibilityTest::waitUntilChildrenRemoved):
1068         (AccessibilityTest::ensureProxy):
1069         (testAtspiBasicHierarchy):
1070         (beforeAll):
1071         (afterAll):
1072
1073 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1074
1075         [ews-build] Handle bug titles with unicode characters
1076         https://bugs.webkit.org/show_bug.cgi?id=196802
1077
1078         Reviewed by Dewei Zhu.
1079
1080         * BuildSlaveSupport/ews-build/steps.py:
1081         (ValidatePatch._is_bug_closed):
1082
1083 2019-04-11  Michael Saboff  <msaboff@apple.com>
1084
1085         Improve the Inline Cache Stats code
1086         https://bugs.webkit.org/show_bug.cgi?id=196836
1087
1088         Reviewed by Saam Barati.
1089
1090         Added a new script to consolidate and arrange the output of --useICStats option.
1091
1092         This script merges the output from every group into one large table and sorts it from most common to
1093         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1094         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1095         Put together, this is useful to see what property accesses are not getting cached.
1096
1097         * Scripts/ic-stats.py: Added.
1098         (ICStats):
1099         (ICStats.__init__):
1100         (ICStats.parse):
1101         (ICStats.dumpStats):
1102         (usage):
1103
1104 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1105
1106         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1107         https://bugs.webkit.org/show_bug.cgi?id=196809
1108         <rdar://49800762>
1109
1110         Reviewed by Brady Eidson.
1111
1112         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1113         (TEST):
1114
1115 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1116
1117         requestAnimationFrame should execute before the next frame
1118         https://bugs.webkit.org/show_bug.cgi?id=177484
1119
1120         Reviewed by Simon Fraser.
1121
1122         Add trace points for the page RenderingUpdate.
1123
1124         * Tracing/SystemTracePoints.plist:
1125
1126 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1127
1128         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1129         https://bugs.webkit.org/show_bug.cgi?id=196760
1130
1131         Reviewed by Don Olmstead.
1132
1133         vswhere.exe has been bundled since Visual Studio 2017 version
1134         15.2. We shouldn't download vswhere.exe.
1135
1136         * Scripts/build-jsc: Do not call update-vswhere.py.
1137         * Scripts/build-webkit: Ditto.
1138         * Scripts/update-vswhere.py: Removed.
1139         * Scripts/webkitdirs.pm:
1140         (requireModulesForVSWhere): Deleted.
1141         (pickCurrentVisualStudioInstallation): Deleted.
1142         (visualStudioInstallDirVSWhere): Return the latest installed VS
1143         installation path by using the bundled vswhere.exe.
1144         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1145         (visualStudioInstallDirFallback): Removed.
1146
1147 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1148
1149         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1150         https://bugs.webkit.org/show_bug.cgi?id=196780
1151
1152         Reviewed by Alexey Proskuryakov.
1153
1154         * BuildSlaveSupport/ews-build/steps.py:
1155         * BuildSlaveSupport/ews-build/steps_unittest.py:
1156
1157 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1158
1159         Add SPI WKNavigationResponse._downloadAttribute
1160         https://bugs.webkit.org/show_bug.cgi?id=196755
1161         <rdar://49587365>
1162
1163         Reviewed by Brady Eidson.
1164
1165         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1166         (-[NavigationResponseTestDelegate navigationResponse]):
1167         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1168         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1169         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1170         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1171         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1172         (readRequest):
1173         (writeResponse):
1174         (TEST):
1175
1176 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1177
1178         Add modern API for overriding the page's specified viewport configuration
1179         https://bugs.webkit.org/show_bug.cgi?id=167734
1180         <rdar://problem/30331795>
1181
1182         Reviewed by Simon Fraser.
1183
1184         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1185         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1186
1187 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1188
1189         Add support for incremental bytecode cache updates
1190         https://bugs.webkit.org/show_bug.cgi?id=195000
1191
1192         Reviewed by Filip Pizlo.
1193
1194         Exit when the initial run to generate bytecode fails.
1195
1196         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1197
1198 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1199
1200         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1201         https://bugs.webkit.org/show_bug.cgi?id=196744
1202         <rdar://49415309>
1203
1204         Reviewed by Chris Dumez.
1205
1206         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1207         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1208
1209 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1210
1211         Add a way to opt into modern compatibility mode in layout tests
1212         https://bugs.webkit.org/show_bug.cgi?id=196770
1213         <rdar://problem/49777550>
1214
1215         Reviewed by Antoine Quint.
1216
1217         Add a new test option to enable modern compatibility mode in layout tests.
1218
1219         * WebKitTestRunner/TestController.cpp:
1220         (WTR::updateTestOptionsFromTestHeader):
1221         * WebKitTestRunner/TestController.h:
1222         * WebKitTestRunner/TestOptions.h:
1223         (WTR::TestOptions::hasSameInitializationOptions const):
1224         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1225         (WTR::TestController::platformCreateWebView):
1226         (WTR::TestController::enableModernCompatibilityMode):
1227
1228 2019-04-10  Andy Estes  <aestes@apple.com>
1229
1230         Try to fix the 32-bit watchOS build.
1231
1232         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1233         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1234
1235 2019-04-10  Antoine Quint  <graouts@apple.com>
1236
1237         Enable Pointer Events on watchOS
1238         https://bugs.webkit.org/show_bug.cgi?id=196771
1239         <rdar://problem/49040909>
1240
1241         Reviewed by Dean Jackson.
1242
1243         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1244
1245 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1246
1247         Unreviewed. Fix WPE accessibility tests after r244059.
1248
1249         We are failing to load the injected bundle due to undefined symbol
1250         AccessibilityUIElement::replaceTextInRange().
1251
1252         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1253         (WTR::AccessibilityUIElement::replaceTextInRange):
1254
1255 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1256
1257         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1258         https://bugs.webkit.org/show_bug.cgi?id=196727
1259
1260         Reviewed by Fujii Hironori.
1261
1262         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1263         (WebKitBrowserWindow::create):
1264
1265 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1266
1267         [ews-build] Add unit tests for PrintConfiguration
1268         https://bugs.webkit.org/show_bug.cgi?id=196752
1269
1270         Reviewed by Dewei Zhu.
1271
1272         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1273
1274 2019-04-09  Keith Rollin  <krollin@apple.com>
1275
1276         Unreviewed build maintenance -- update .xcfilelists.
1277
1278         * DumpRenderTree/DerivedSources-input.xcfilelist:
1279         * DumpRenderTree/DerivedSources-output.xcfilelist:
1280
1281 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1282
1283         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1284         https://bugs.webkit.org/show_bug.cgi?id=196743
1285         <rdar://problem/43897551>
1286
1287         Reviewed by Tim Horton.
1288
1289         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1290         (TEST):
1291
1292 2019-04-09  Youenn Fablet  <youenn@apple.com>
1293
1294         Close service worker database on network process suspension
1295         https://bugs.webkit.org/show_bug.cgi?id=196623
1296         <rdar://problem/48930869>
1297
1298         Reviewed by Alex Christensen.
1299
1300         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1301
1302 2019-04-09  Daniel Bates  <dabates@apple.com>
1303
1304         [iPad] Should open popover when the spacebar is pressed
1305         https://bugs.webkit.org/show_bug.cgi?id=196360
1306         <rdar://problem/49389129>
1307
1308         Reviewed by Brent Fulgham.
1309
1310         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1311
1312         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1313         (WTR::UIScriptController::isShowingPopover const): Added.
1314         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1315         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1316         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1317         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1318         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1319         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1320         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1321         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1322         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1323         (WTR::UIScriptController::isShowingPopover const): Added.
1324         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1325         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1326         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1327         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1328         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1329         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1330         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1331         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1332         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1333         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1334         (WTR::UIScriptController::isShowingPopover const): Added.
1335         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1336         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1337
1338 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1339
1340         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1341         https://bugs.webkit.org/show_bug.cgi?id=196665
1342         <rdar://45115669>
1343
1344         Reviewed by Geoff Garen.
1345
1346         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1347         (goBack):
1348         (+[SimpleLookupContext sharedLookupContext]):
1349         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1350         (TEST):
1351         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1352         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1353
1354 2019-04-09  John Wilander  <wilander@apple.com>
1355
1356         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1357         https://bugs.webkit.org/show_bug.cgi?id=196558
1358         <rdar://problem/47650245>
1359
1360         Reviewed by Youenn Fablet.
1361
1362         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1363         (TestWebKitAPI::TEST):
1364             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1365
1366 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1367
1368         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1369         https://bugs.webkit.org/show_bug.cgi?id=196720
1370
1371         Reviewed by Konstantin Tokarev.
1372
1373         * TestWebKitAPI/PlatformMac.cmake:
1374
1375 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1376
1377         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1378         https://bugs.webkit.org/show_bug.cgi?id=196694
1379         <rdar://problem/48388734>
1380
1381         Rubber-stamped by Aakash Jain.
1382
1383         * Scripts/webkitpy/port/image_diff.py:
1384         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1385         * Scripts/webkitpy/port/server_process.py:
1386         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1387         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1388         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1389         * Scripts/webkitpy/port/server_process_mock.py:
1390         (MockServerProcess.has_available_stdout):
1391         * Scripts/webkitpy/port/server_process_unittest.py:
1392         (TestServerProcess.serial_test_basic):
1393
1394 2019-04-09  Jer Noble  <jer.noble@apple.com>
1395
1396         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1397         https://bugs.webkit.org/show_bug.cgi?id=196097
1398
1399         Reviewed by Eric Carlson.
1400
1401         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1402
1403         * DumpRenderTree/mac/DumpRenderTree.mm:
1404         (resetWebPreferencesToConsistentValues):
1405         * WebKitTestRunner/TestController.cpp:
1406         (WTR::TestController::resetPreferencesToConsistentValues):
1407
1408 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1409
1410         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1411         https://bugs.webkit.org/show_bug.cgi?id=196690
1412
1413         Reviewed by Michael Catanzaro.
1414
1415         * QueueStatusServer/config/queues.py:
1416         * Scripts/webkitpy/common/config/ews.json:
1417         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1418         (test_ews_name):
1419
1420 2019-04-09  Chris Dumez  <cdumez@apple.com>
1421
1422         Loads using loadHTMLString() cause flashing when process-swapping
1423         https://bugs.webkit.org/show_bug.cgi?id=196714
1424         <rdar://problem/49637354>
1425
1426         Reviewed by Antti Koivisto.
1427
1428         Add API test coverage.
1429
1430         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1431
1432 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1433
1434         Unreviewed. Fix ATK accessibility tests after r244059.
1435
1436         We are failing to load the injected bundle due to undefined symbol
1437         AccessibilityUIElement::replaceTextInRange().
1438
1439         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1440         (WTR::AccessibilityUIElement::replaceTextInRange):
1441
1442 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1443
1444         AX: Support API: accessibilityReplaceRange:withText
1445         https://bugs.webkit.org/show_bug.cgi?id=196636
1446
1447         Unreviewed build fix for Windows port.
1448
1449         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1450         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1451
1452 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1453
1454         [CMake][WinCairo] Separate copied headers into different directories
1455         https://bugs.webkit.org/show_bug.cgi?id=196655
1456
1457         Reviewed by Michael Catanzaro.
1458
1459         * DumpRenderTree/CMakeLists.txt:
1460         * MiniBrowser/win/CMakeLists.txt:
1461         * TestWebKitAPI/CMakeLists.txt:
1462         * TestWebKitAPI/PlatformWin.cmake:
1463
1464 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1465
1466         Log stack-trace for run-webkit-tests when interrupted
1467         https://bugs.webkit.org/show_bug.cgi?id=176393
1468         <rdar://problem/34262310>
1469
1470         Reviewed by Lucas Forschler.
1471
1472         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1473         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1474         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1475         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1476         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1477         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1478         (main): Set handlers to log stack trace on interruption.
1479
1480 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1481
1482         AX: Support API: accessibilityReplaceRange:withText
1483         https://bugs.webkit.org/show_bug.cgi?id=196636
1484
1485         Unreviewed build fix for Windows port.
1486
1487         * DumpRenderTree/AccessibilityUIElement.cpp:
1488         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1489
1490 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1491
1492         [ews-build] Scripts using Buildbot API have CORS error
1493         https://bugs.webkit.org/show_bug.cgi?id=196709
1494
1495         Reviewed by Alexey Proskuryakov.
1496
1497         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1498
1499 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1500
1501         AX: Support API: accessibilityReplaceRange:withText
1502         https://bugs.webkit.org/show_bug.cgi?id=196636
1503
1504         Reviewed by Daniel Bates.
1505
1506         * DumpRenderTree/AccessibilityUIElement.cpp:
1507         (replaceTextInRangeCallback):
1508         (AccessibilityUIElement::replaceTextInRange):
1509         (AccessibilityUIElement::getJSClass):
1510         * DumpRenderTree/AccessibilityUIElement.h:
1511         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1512         (AccessibilityUIElement::replaceTextInRange):
1513         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1514         (AccessibilityUIElement::replaceTextInRange):
1515         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1516         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1517         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1518         (WTR::AccessibilityUIElement::replaceTextInRange):
1519         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1520         (WTR::AccessibilityUIElement::replaceTextInRange):
1521
1522 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1523
1524         [iOS] Do not allow starting selection drags when selection views are not visible
1525         https://bugs.webkit.org/show_bug.cgi?id=196686
1526         <rdar://problem/49399192>
1527
1528         Reviewed by Tim Horton.
1529
1530         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1531         also add some new API tests to cover scenarios where the web view is not first responder.
1532
1533         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1534         (TestWebKitAPI::TEST):
1535         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1536
1537         Add a switch to optionally make the web view first responder when starting the simulated drag.
1538
1539         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1540         (-[DragAndDropSimulator initWithWebView:]):
1541         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1542
1543 2019-04-08  Justin Fan  <justin_fan@apple.com>
1544
1545         [Web GPU] Fix Web GPU experimental feature on iOS
1546         https://bugs.webkit.org/show_bug.cgi?id=196632
1547
1548         Reviewed by Myles C. Maxfield.
1549
1550         Properly make Web GPU available on iOS 11+.
1551
1552         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1553
1554 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1555
1556         [ews-build] Do not upload archive when Compile Fails
1557         https://bugs.webkit.org/show_bug.cgi?id=196674
1558
1559         Reviewed by Alexey Proskuryakov.
1560
1561         * BuildSlaveSupport/ews-build/factories.py:
1562         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1563         * BuildSlaveSupport/ews-build/steps.py:
1564         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1565         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1566         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1567
1568 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1569
1570         Enable DFG on MIPS
1571         https://bugs.webkit.org/show_bug.cgi?id=196689
1572
1573         Reviewed by Žan Doberšek.
1574
1575         Since the bytecode change, we enabled the baseline JIT on mips in
1576         r240432, but DFG is still missing. With this change, all tests are
1577         passing on a ci20 board.
1578
1579         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1580
1581 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1582
1583         [Flatpak] Second run update-webkitwpe-flatpak fails
1584         https://bugs.webkit.org/show_bug.cgi?id=192702
1585
1586         Reviewed by Carlos Garcia Campos.
1587
1588         * flatpak/flatpakutils.py:
1589         (FlatpakObject.flatpak): Fix typo.
1590         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1591         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1592
1593 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1594
1595         [GTK][WPE] outlook.live.com displays old-fashioned UI
1596         https://bugs.webkit.org/show_bug.cgi?id=196642
1597
1598         Reviewed by Carlos Garcia Campos.
1599
1600         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1601         (TestWebKitAPI::TEST): New Mac platform quirk test.
1602
1603 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1604
1605         Unreviewed, rolling out r243956.
1606         https://bugs.webkit.org/show_bug.cgi?id=196688
1607
1608         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1609         by aakashjain on #webkit).
1610
1611         Reverted changeset:
1612
1613         "Clicking "Go Back" from a safe browsing warning from an
1614         iframe should navigate the WKWebView back to the previous
1615         page"
1616         https://bugs.webkit.org/show_bug.cgi?id=196665
1617         https://trac.webkit.org/changeset/243956
1618
1619 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1620
1621         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1622         https://bugs.webkit.org/show_bug.cgi?id=196669
1623
1624         Reviewed by Geoffrey Garen.
1625
1626         Added three new unit tests for WeakHashSet.
1627
1628         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1629         (WTF_WeakPtr.WeakHashSetConstObjects):
1630         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1631         (WTF_WeakPtr.WeakHashSetComputeSize):
1632
1633 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1634
1635         Hide next and previous form control buttons when WKWebView is editable
1636         https://bugs.webkit.org/show_bug.cgi?id=196672
1637         <rdar://problem/35625321>
1638
1639         Reviewed by Tim Horton.
1640
1641         Add a new API test.
1642
1643         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1644         (-[TestWKWebView lastTrailingBarButtonGroup]):
1645         (TestWebKitAPI::TEST):
1646         * TestWebKitAPI/ios/UIKitSPI.h:
1647
1648 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1649
1650         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1651         https://bugs.webkit.org/show_bug.cgi?id=196077
1652         <rdar://problem/49108202>
1653
1654         Reviewed by Chris Dumez.
1655
1656         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1657         on new web view.
1658
1659         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1660
1661 2019-04-05  Saam Barati  <sbarati@apple.com>
1662
1663         Make compare-results understand MotionMark
1664         https://bugs.webkit.org/show_bug.cgi?id=196666
1665
1666         Reviewed by Yusuke Suzuki.
1667
1668         * Scripts/compare-results:
1669         (PLT5Results):
1670         (detectMotionMark):
1671         (detectMotionMark1_1):
1672         (motionMarkResults):
1673         (motionMark1_1Results):
1674         (detectBenchmark):
1675         (biggerIsBetter):
1676         (main):
1677
1678 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1679
1680         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1681         https://bugs.webkit.org/show_bug.cgi?id=196665
1682         <rdar://45115669>
1683
1684         Reviewed by Geoff Garen.
1685
1686         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1687         (goBack):
1688         (+[SimpleLookupContext sharedLookupContext]):
1689         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1690         (TEST):
1691         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1692         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1693
1694 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1695
1696         [ews-build] Add configuration and architecture for windows builders
1697         https://bugs.webkit.org/show_bug.cgi?id=196660
1698
1699         Reviewed by Lucas Forschler.
1700
1701         * BuildSlaveSupport/ews-build/config.json:
1702
1703 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1704
1705         webkitpy: Don't run subsequent rounds if interrupted
1706         https://bugs.webkit.org/show_bug.cgi?id=196646
1707
1708         Reviewed by Aakash Jain.
1709
1710         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1711         (Manager.run): Bail out if interrupted.
1712
1713 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1714
1715         Test sessionStorage in PSON private browsing mode
1716         https://bugs.webkit.org/show_bug.cgi?id=196561
1717
1718         Reviewed by Alex Christensen.
1719
1720         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1721
1722 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1723
1724         Unreviewed, rolling out r243833.
1725         https://bugs.webkit.org/show_bug.cgi?id=196645
1726
1727         This change breaks build of WPE and GTK ports (Requested by
1728         annulen on #webkit).
1729
1730         Reverted changeset:
1731
1732         "[CMake][WTF] Mirror XCode header directories"
1733         https://bugs.webkit.org/show_bug.cgi?id=191662
1734         https://trac.webkit.org/changeset/243833
1735
1736 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1737
1738         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1739         https://bugs.webkit.org/show_bug.cgi?id=196635
1740
1741         Reviewed by Antti Koivisto.
1742         
1743         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1744         for a test to enable async frame scrolling via:
1745             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1746         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1747         
1748         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1749
1750         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1751         (WTR::InjectedBundle::beginTesting):
1752         * WebKitTestRunner/TestController.cpp:
1753         (WTR::TestController::resetPreferencesToConsistentValues):
1754
1755 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1756
1757         Use a correct LC_RPATH when building with ASan
1758         https://bugs.webkit.org/show_bug.cgi?id=196576
1759
1760         Reviewed by David Kilzer.
1761
1762         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1763         so that ../Frameworks is checked. This is simpler and more reliable than updating
1764         each SPC service xcconfig.
1765
1766 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1767
1768         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1769         https://bugs.webkit.org/show_bug.cgi?id=196629
1770
1771         Reviewed by Lucas Forschler.
1772
1773         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1774
1775 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1776
1777         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1778         https://bugs.webkit.org/show_bug.cgi?id=196618
1779
1780         Reviewed by Lucas Forschler.
1781
1782         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1783         (StatusBubble): Added QUEUE_TRIGGERS.
1784         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1785         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1786         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1787         its parent(builder).
1788
1789 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1790
1791         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1792         https://bugs.webkit.org/show_bug.cgi?id=196625
1793
1794         Reviewed by Lucas Forschler.
1795
1796         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1797         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1798
1799 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1800
1801         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1802         https://bugs.webkit.org/show_bug.cgi?id=196630
1803
1804         Reviewed by Wenson Hsieh.
1805
1806         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1807
1808 2019-04-04  Youenn Fablet  <youenn@apple.com>
1809
1810         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1811         https://bugs.webkit.org/show_bug.cgi?id=196543
1812
1813         Reviewed by Alex Christensen.
1814
1815         * WebKitTestRunner/TestController.cpp:
1816         (WTR::TestController::generatePageConfiguration):
1817
1818 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1819
1820         [ews-app] Status bubble should not display skipped buildbot steps
1821         https://bugs.webkit.org/show_bug.cgi?id=196584
1822
1823         Reviewed by Lucas Forschler.
1824
1825         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1826
1827 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1828
1829         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1830         https://bugs.webkit.org/show_bug.cgi?id=196620
1831
1832         Reviewed by Lucas Forschler.
1833
1834         * BuildSlaveSupport/ews-app/ews/config.py:
1835
1836 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1837
1838         [Win] DumpRenderTreeWatchDog.py is not checked into source
1839         https://bugs.webkit.org/show_bug.cgi?id=196567
1840         <rdar://problem/49525901>
1841
1842         Reviewed by Lucas Forschler.
1843
1844         This script is used on Win EWS bots to terminate hanging DRT processes.
1845
1846         * EWSTools/dumprendertreewatchdog.py: Added.
1847
1848 2019-04-04  Chris Dumez  <cdumez@apple.com>
1849
1850         Unreviewed, roll out r243858 which made tests time out.
1851
1852         Disable new API tests on Windows instead.
1853
1854         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1855         (TestWebKitAPI::TEST):
1856
1857 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1858
1859         [ATK] Cleanup WebPageAccessibilityObjectAtk
1860         https://bugs.webkit.org/show_bug.cgi?id=196537
1861
1862         Reviewed by Michael Catanzaro.
1863
1864         Also consider files under atk directories as exceptions for GObject conventions.
1865
1866         * Scripts/webkitpy/style/checkers/cpp.py:
1867         (check_identifier_name_in_declaration):
1868
1869 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1870
1871         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1872         https://bugs.webkit.org/show_bug.cgi?id=196588
1873         <rdar://problem/49365787>
1874
1875         Unreviewed build fix for Windows port.
1876
1877         error C3861: 'kill': identifier not found
1878
1879         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1880         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1881
1882 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1883
1884         [ews-build] Cancel build and similar operations should have authentication
1885         https://bugs.webkit.org/show_bug.cgi?id=196520
1886
1887         Reviewed by Dewei Zhu.
1888
1889         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1890         environment variables.
1891
1892 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1893
1894         [ews-build] Do not trigger queues which are not in production yet
1895         https://bugs.webkit.org/show_bug.cgi?id=196581
1896
1897         Reviewed by Dewei Zhu.
1898
1899         * BuildSlaveSupport/ews-build/config.json:
1900
1901 2019-04-03  Chris Dumez  <cdumez@apple.com>
1902
1903         Unreviewed, fix typo in the name of API test added in r243848.
1904
1905         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1906         (TestWebKitAPI::TEST):
1907
1908 2019-04-03  Chris Dumez  <cdumez@apple.com>
1909
1910         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1911         https://bugs.webkit.org/show_bug.cgi?id=196588
1912         <rdar://problem/49365787>
1913
1914         Reviewed by Ryosuke Niwa.
1915
1916         Add API test coverage.
1917
1918         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1919         (TestWebKitAPI::nullJavaScriptCallback):
1920         (TestWebKitAPI::didCrashCheckFrames):
1921         (TestWebKitAPI::TEST):
1922
1923 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1924
1925         run-webkit-tests: Upload test results (new results database)
1926         https://bugs.webkit.org/show_bug.cgi?id=196577
1927         <rdar://problem/34841155>
1928
1929         Reviewed by Lucas Forschler.
1930
1931         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1932         (Manager.run): Upload results after each device shard, since the configuration will be
1933         different for each device.
1934         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1935         uploaded to a results database.
1936         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1937         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1938
1939 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1940
1941         -apple-trailing-word is needed for browser detection
1942         https://bugs.webkit.org/show_bug.cgi?id=196575
1943
1944         Unreviewed.
1945
1946         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1947
1948 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1949
1950         [CMake][WTF] Mirror XCode header directories
1951         https://bugs.webkit.org/show_bug.cgi?id=191662
1952
1953         Reviewed by Konstantin Tokarev.
1954
1955         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1956         builds.
1957
1958         * CMakeLists.txt:
1959         * DumpRenderTree/CMakeLists.txt:
1960         * DumpRenderTree/PlatformWin.cmake:
1961         * MiniBrowser/win/CMakeLists.txt:
1962         * TestWebKitAPI/CMakeLists.txt:
1963         * TestWebKitAPI/PlatformWin.cmake:
1964         * WebKitTestRunner/PlatformGTK.cmake:
1965         * WebKitTestRunner/PlatformWin.cmake:
1966
1967 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1968
1969         [ews-app] Status bubble should not display certain infrastructure status messages
1970         https://bugs.webkit.org/show_bug.cgi?id=196550
1971
1972         Reviewed by Lucas Forschler.
1973
1974         Do not display the steps which are un-needed for end-user. This information is still avaiable
1975         if the user click on the bubble and look at the Buildbot build.
1976         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1977         (StatusBubble._steps_messages):
1978         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1979
1980 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1981
1982         [ews-build] Use https for sending data to ews-app
1983         https://bugs.webkit.org/show_bug.cgi?id=196492
1984
1985         Reviewed by Lucas Forschler.
1986
1987         * BuildSlaveSupport/ews-build/events.py:
1988
1989 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1990
1991         Remove support for -apple-trailing-word
1992         https://bugs.webkit.org/show_bug.cgi?id=196525
1993
1994         Reviewed by Zalan Bujtas.
1995
1996         This CSS property is nonstandard and not used.
1997
1998         * Scripts/webkitperl/FeatureList.pm:
1999         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2000
2001 2019-04-03  Youenn Fablet  <youenn@apple.com>
2002
2003         Add a test for DOMCache on multiple browsing in case of private browsing
2004         https://bugs.webkit.org/show_bug.cgi?id=196524
2005
2006         Reviewed by Alex Christensen.
2007
2008         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2009         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2010
2011 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2012
2013         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2014         https://bugs.webkit.org/show_bug.cgi?id=196540
2015
2016         Reviewed by Aakash Jain.
2017
2018         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2019
2020 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2021
2022         Add plumbing for a compatibility mode preference in WebKit
2023         https://bugs.webkit.org/show_bug.cgi?id=196005
2024
2025         Reviewed by Tim Horton.
2026
2027         Add new API tests.
2028
2029         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2030         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2031
2032 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2033
2034         [WPE][GTK] Update libsrtp dependency package for Debian
2035         https://bugs.webkit.org/show_bug.cgi?id=196528
2036
2037         Reviewed by Frédéric Wang.
2038
2039         * gtk/install-dependencies:
2040         * wpe/install-dependencies:
2041
2042 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2043
2044         [WK2] Add support for Window's beforeprint / afterprint events
2045         https://bugs.webkit.org/show_bug.cgi?id=196478
2046         <rdar://problem/49535124>
2047
2048         Unreviewed build fix for MSVC.
2049
2050         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2051
2052         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2053
2054         * WebKitTestRunner/TestController.cpp:
2055         (WTR::printFrame): Use int and float literals.
2056
2057 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2058
2059         [ews-build] Reassign bots to queues
2060
2061         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2062
2063 2019-04-02  Chris Dumez  <cdumez@apple.com>
2064
2065         [WK2] Add support for Window's beforeprint / afterprint events
2066         https://bugs.webkit.org/show_bug.cgi?id=196478
2067
2068         Reviewed by Alex Christensen.
2069
2070         Add minimal implementation for printFrame in WebKitTestRunner.
2071
2072         * WebKitTestRunner/TestController.cpp:
2073         (WTR::printFrame):
2074         (WTR::TestController::createOtherPage):
2075         (WTR::TestController::createWebViewWithOptions):
2076
2077 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2078
2079         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2080         https://bugs.webkit.org/show_bug.cgi?id=196491
2081
2082         Reviewed by Lucas Forschler.
2083
2084         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2085
2086 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2087
2088         [ews-build] Configure buildbot try credentials in environment variables
2089         https://bugs.webkit.org/show_bug.cgi?id=196501
2090
2091         Reviewed by Lucas Forschler.
2092
2093         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2094         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2095         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2096
2097 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2098
2099         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2100         https://bugs.webkit.org/show_bug.cgi?id=196496
2101         <rdar://problem/49521634>
2102
2103         Reviewed by Chris Dumez.
2104
2105         Add new API tests (see WebKit ChangeLog for more detail).
2106
2107         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2108         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2109         (TEST):
2110
2111 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2112
2113         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2114         <https://webkit.org/b/196499>
2115
2116         Reviewed by Alexey Proskuryakov.
2117
2118         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2119         ENABLE_ADDRESS_SANITIZER.
2120
2121 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2122
2123         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2124         https://bugs.webkit.org/show_bug.cgi?id=182757
2125
2126         Reviewed by Don Olmstead.
2127
2128         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2129         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2130
2131 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2132
2133         run-api-tests: Upload test results
2134         https://bugs.webkit.org/show_bug.cgi?id=196323
2135         <rdar://problem/49356714>
2136
2137         Reviewed by Lucas Forschler.
2138
2139         * Scripts/webkitpy/api_tests/manager.py:
2140         (Manager):
2141         (Manager.run): Upload results to a results database.
2142         * Scripts/webkitpy/api_tests/run_api_tests.py:
2143         (parse_args): Add upload arguments.
2144         * Scripts/webkitpy/port/base.py:
2145         (Port):
2146         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2147         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2148         with commits from any other associated repositories.
2149         * Scripts/webkitpy/port/device.py:
2150         (Device):
2151         (Device.build_version): Access build_versoin of underlying platform device.
2152         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2153         (IOSSimulatorTest):
2154         (IOSSimulatorTest.test_configuration_for_upload):
2155         * Scripts/webkitpy/port/device_port.py:
2156         (DevicePort):
2157         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2158         the same as the machine uploading results.
2159         * Scripts/webkitpy/port/mac.py:
2160         (MacPort):
2161         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2162         * Scripts/webkitpy/port/mac_unittest.py:
2163         (MacTest):
2164         (MacTest.test_configuration_for_upload):
2165         * Scripts/webkitpy/xcode/simulated_device.py:
2166         (SimulatedDeviceManager._create_device_with_runtime):
2167         (SimulatedDevice.__init__): Create simulated device with a build_version.
2168         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2169         (test_existing_simulator):
2170
2171 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2172
2173         Remove extra newline characters (Follow-up fix to r243707)
2174
2175         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2176
2177 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2178
2179         [ews-app] Use API_KEY to accept results data
2180         https://bugs.webkit.org/show_bug.cgi?id=196461
2181
2182         Reviewed by Dewei Zhu.
2183
2184         * BuildSlaveSupport/ews-app/ews/views/results.py:
2185         (Results.post): Validate EWS_API_KEY before accepting any data.
2186         * BuildSlaveSupport/ews-build/events.py:
2187         (Events.sendData): Send EWS_API_KEY if available along with event data.
2188
2189 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2190
2191         Unable to copy and paste a PDF from Notes into Mail compose body
2192         https://bugs.webkit.org/show_bug.cgi?id=196442
2193         <rdar://problem/48573098>
2194
2195         Reviewed by Tim Horton.
2196
2197         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2198         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2199         to be specified on the item providers.
2200
2201         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2202         (TestWebKitAPI::mapItemForTesting):
2203         (TestWebKitAPI::contactItemForTesting):
2204
2205 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2206
2207         Make UIWKDocumentContext rects per-character instead of per-word
2208         https://bugs.webkit.org/show_bug.cgi?id=196459
2209
2210         Reviewed by Wenson Hsieh.
2211
2212         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2213         (TEST):
2214         Adjust test results due to switching to per-character rects.
2215
2216 2019-04-01  Chris Dumez  <cdumez@apple.com>
2217
2218         UIProcess crash when a prewarmed process is terminated
2219         https://bugs.webkit.org/show_bug.cgi?id=196451
2220         <rdar://problem/49245471>
2221
2222         Reviewed by Geoffrey Garen.
2223
2224         Add API test coverage.
2225
2226         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2227         (TEST):
2228
2229 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2230
2231         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2232         https://bugs.webkit.org/show_bug.cgi?id=196449
2233
2234         Reviewed by Lucas Forschler.
2235
2236         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2237         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2238         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2239         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2240
2241 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2242
2243         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2244         https://bugs.webkit.org/show_bug.cgi?id=196444
2245
2246         Reviewed by Lucas Forschler.
2247
2248         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2249
2250 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2251
2252         Add SPI to canonicalize NSURLs with WTF::URL
2253         https://bugs.webkit.org/show_bug.cgi?id=196415
2254         <rdar://problem/44980271>
2255
2256         Reviewed by Darin Adler.
2257
2258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2259         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2260         (TestWebKitAPI::TEST):
2261
2262 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2263
2264         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2265         https://bugs.webkit.org/show_bug.cgi?id=196441
2266
2267         Reviewed by Carlos Garcia Campos.
2268
2269         Don't cache the wpe_view_backend object that might not exist yet at the
2270         time of EventSenderProxy constructor invocation, but instead retrieve
2271         that object whenever it's required for event dispatching. This should
2272         avoid crashes in this constructor now that it's invoked before any
2273         PlatformWindow has been set up (as changed in r243496).
2274
2275         * WebKitTestRunner/EventSenderProxy.h:
2276         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2277         (WTR::viewBackend):
2278         (WTR::EventSenderProxy::EventSenderProxy):
2279         (WTR::EventSenderProxy::mouseDown):
2280         (WTR::EventSenderProxy::mouseUp):
2281         (WTR::EventSenderProxy::mouseMoveTo):
2282         (WTR::EventSenderProxy::mouseScrollBy):
2283         (WTR::EventSenderProxy::keyDown):
2284         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2285
2286 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2287
2288         [Win][WebKit] MiniBrowser should support high DPI display
2289         https://bugs.webkit.org/show_bug.cgi?id=196391
2290
2291         Reviewed by Alex Christensen.
2292
2293         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2294         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2295         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2296         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2297
2298 2019-03-31  Sam Weinig  <weinig@apple.com>
2299
2300         Remove more i386 specific configurations
2301         https://bugs.webkit.org/show_bug.cgi?id=196430
2302
2303         Reviewed by Alexey Proskuryakov.
2304
2305         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2306         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2307
2308 2019-03-31  Andy Estes  <aestes@apple.com>
2309
2310         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2311         https://bugs.webkit.org/show_bug.cgi?id=196433
2312         <rdar://problem/49293305>
2313
2314         Reviewed by Tim Horton.
2315
2316         Enhanced API test coverage to include all navigation response policy decisions in both
2317         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2318
2319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2320         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2321         (TestWebKitAPI::TEST):
2322         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2323         (readFile):
2324         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2325         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2326         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2327         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2328         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2329         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2330         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2331         (-[QuickLookDelegate _downloadDidStart:]):
2332         (-[QuickLookDelegate _download:didReceiveResponse:]):
2333         (-[QuickLookDelegate _download:didReceiveData:]):
2334         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2335         (-[QuickLookDelegate _downloadDidFinish:]):
2336         (-[QuickLookDelegate _download:didFailWithError:]):
2337         (-[QuickLookDelegate _downloadDidCancel:]):
2338         (-[QuickLookDelegate verifyDownload]):
2339         (runTest):
2340         (runTestDecideBeforeLoading):
2341         (runTestDecideAfterLoading):
2342         (TEST):
2343         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2344         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2345         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2346         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2347         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2348         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2349         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2350         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2351         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2352         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2353         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2354         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2355         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2356         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2357
2358 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2359
2360         [CMake] add testdfg as target with build-jsc
2361         https://bugs.webkit.org/show_bug.cgi?id=196393
2362
2363         Reviewed by Saam Barati.
2364
2365         Added testdfg as one of the targets to build when
2366         using CMake.
2367
2368         * Scripts/build-jsc:
2369
2370 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2371
2372         Delete WebMetal implementation in favor of WebGPU
2373         https://bugs.webkit.org/show_bug.cgi?id=195418
2374
2375         Reviewed by Dean Jackson.
2376
2377         * DumpRenderTree/mac/DumpRenderTree.mm:
2378         (enableExperimentalFeatures):
2379         (resetWebPreferencesToConsistentValues):
2380         * Scripts/webkitperl/FeatureList.pm:
2381         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2383         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2384         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2385         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2386         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2387         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2388         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2389         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2390         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2391         (WTR::InjectedBundle::beginTesting):
2392         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2393         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2394         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2395
2396 2019-03-29  Chris Dumez  <cdumez@apple.com>
2397
2398         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2399         https://bugs.webkit.org/show_bug.cgi?id=196405
2400         <rdar://problem/49428130>
2401
2402         Reviewed by Wenson Hsieh.
2403
2404         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2405         the popover presentation methods to be no-ops. Use this in the new test added in
2406         r243523 so that we do not swizzle those methods for all tests. This is needed because
2407         those WatchOS tests rely on the popover getting presented and interactive.
2408
2409         * WebKitTestRunner/TestController.cpp:
2410         (WTR::updateTestOptionsFromTestHeader):
2411         * WebKitTestRunner/TestController.h:
2412         * WebKitTestRunner/TestOptions.h:
2413         (WTR::TestOptions::hasSameInitializationOptions const):
2414         * WebKitTestRunner/ios/TestControllerIOS.mm:
2415         (WTR::TestController::platformInitialize):
2416         (WTR::TestController::platformResetStateToConsistentValues):
2417
2418 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2419
2420         [Curl] Add Server Trust Evaluation Support.
2421         https://bugs.webkit.org/show_bug.cgi?id=191646
2422
2423         Reviewed by Fujii Hironori.
2424
2425         Implemented MiniBrowser UI for asking if user trusts the server.
2426
2427         * MiniBrowser/win/Common.cpp:
2428         (askServerTrustEvaluation):
2429         (replaceString):
2430         * MiniBrowser/win/Common.h:
2431         * MiniBrowser/win/MiniBrowserLib.rc:
2432         * MiniBrowser/win/MiniBrowserLibResource.h:
2433         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2434         (createPEMString):
2435         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2436         (WebKitBrowserWindow::canTrustServerCertificate):
2437         * MiniBrowser/win/WebKitBrowserWindow.h:
2438
2439 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2440
2441         Implement ResizeObserver.
2442         https://bugs.webkit.org/show_bug.cgi?id=157743
2443
2444         Reviewed by Simon Fraser.
2445
2446         Support resizeObserverEnabled webPreferences.
2447
2448         * DumpRenderTree/TestOptions.cpp:
2449         (TestOptions::TestOptions):
2450         * DumpRenderTree/TestOptions.h:
2451         * DumpRenderTree/mac/DumpRenderTree.mm:
2452         (setWebPreferencesForTestOptions):
2453         * DumpRenderTree/win/DumpRenderTree.cpp:
2454         (enableExperimentalFeatures):
2455         * Scripts/webkitperl/FeatureList.pm:
2456         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2457
2458 2019-03-28  John Wilander  <wilander@apple.com>
2459
2460         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2461         https://bugs.webkit.org/show_bug.cgi?id=196281
2462         <rdar://problem/48938748>
2463
2464         Reviewed by Alex Christensen.
2465
2466         This patch adds the function isStatisticsHasLocalStorage() to the
2467         TestRunner. With it, the page can query the WebsiteDataStore in the
2468         UI process to make sure that it sees LocalStorage.
2469
2470         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2471         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2472         (WTR::TestRunner::isStatisticsHasLocalStorage):
2473         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2474         * WebKitTestRunner/TestController.cpp:
2475         (WTR::TestController::isStatisticsHasLocalStorage):
2476         * WebKitTestRunner/TestController.h:
2477         * WebKitTestRunner/TestInvocation.cpp:
2478         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2479
2480 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2481
2482         API::Data::createWithoutCopying should do a null check before calling CFRelease
2483         https://bugs.webkit.org/show_bug.cgi?id=196276
2484         <rdar://problem/48059859>
2485
2486         Reviewed by Alex Christensen.
2487
2488         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2489
2490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2491         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2492         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2493         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2494         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2495         (TestWebKitAPI::TEST):
2496
2497 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2498
2499         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2500         https://bugs.webkit.org/show_bug.cgi?id=186276
2501
2502         Reviewed by Carlos Garcia Campos.
2503
2504         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2505         (webViewLoadChanged):
2506         (testWebResourceGetDataError):
2507         (testWebResourceGetDataEmpty):
2508         (beforeAll):
2509         (webViewloadChanged): Deleted.
2510
2511 2019-03-27  Andy Estes  <aestes@apple.com>
2512
2513         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2514         https://bugs.webkit.org/show_bug.cgi?id=196317
2515
2516         Reviewed by Dan Bernstein.
2517
2518         package-root copies built products into a staging directory using ditto(1), which does not
2519         follow symbolic links as it traverses a directory. Now that the files in
2520         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2521         itself, these become broken links when ditto'd into the staging directory.
2522
2523         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2524
2525         * Scripts/package-root:
2526
2527 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2528
2529         [ews-app] Update display text of Submit for ews analysis
2530         https://bugs.webkit.org/show_bug.cgi?id=196309
2531
2532         Reviewed by Dewei Zhu.
2533
2534         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2535
2536 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2537
2538         run-webkit-tests should check for leaks in WebKit processes
2539         <https://webkit.org/b/193772>
2540         <rdar://problem/46526680>
2541
2542         Reviewed by Ryosuke Niwa.
2543
2544         This works by doing the following:
2545         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2546           The list of child processes are returned one per line:
2547           process.name: pid
2548         - Run the "#LIST CHILD PROCESSES" command just before the
2549           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2550           processes on the ServerProcess object.
2551         - When the `--leaks` switch is handled, run check_for_leaks() on
2552           each child process after the main test harness.
2553
2554         * DumpRenderTree/mac/DumpRenderTree.mm:
2555         (handleControlCommand):
2556         - Use strncmp() instead of strcmp().
2557         - Add support for handling "#LIST CHILD PROCESSES" command.
2558
2559         * Scripts/webkitpy/port/base.py:
2560         (Port.check_for_leaks):
2561         * Scripts/webkitpy/port/darwin.py:
2562         (DarwinPort.check_for_leaks):
2563         - Rename redundant 'process_pid' argument to 'process_id'.
2564
2565         * Scripts/webkitpy/port/driver.py:
2566         (Driver.do_post_tests_work):
2567         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2568           longer the only command this sends to WebKitTestRunner.
2569         - If the `--leaks` switch is present, send the
2570           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2571           result using Port.set_webkit_processes().
2572         (Driver._parse_child_processes_output):
2573         - Add helper method to parse list of child process names and
2574           process IDs returned from WebKitTestRunner.
2575
2576         * Scripts/webkitpy/port/ios_device.py:
2577         (IOSDevicePort.check_for_leaks):
2578         - Rename redundant 'process_pid' argument to 'process_id'.
2579
2580         * Scripts/webkitpy/port/leakdetector.py:
2581         (LeakDetector._parse_leaks_output):
2582         - Return early if there is no leaks_output.
2583         (LeakDetector.check_for_leaks):
2584         - Rename redundant 'process_pid' argument to 'process_id'.
2585
2586         * Scripts/webkitpy/port/server_process.py:
2587         (ServerProcess.__init__):
2588         (ServerProcess.child_processes):
2589         (ServerProcess.set_child_processes):
2590         - Add instance variable to Port to store list of child process
2591           names and process IDs returned from WebKitTestRunner.
2592         (ServerProcess._start):
2593         - Clear self._child_processes.
2594         (ServerProcess.stop):
2595         - If self._child_processes is set, call
2596           self._port.check_for_leaks() for each child process.
2597
2598         * Scripts/webkitpy/port/server_process_unittest.py:
2599         (TrivialMockPort.check_for_leaks):
2600         - Rename redundant 'process_pid' argument to 'process_id'.
2601
2602         * Scripts/webkitpy/port/simulator_process.py:
2603         (SimulatorProcess.stop):
2604         - If self._child_processes is set, call
2605           self._port.check_for_leaks() for each child process.
2606
2607         * Scripts/webkitpy/port/watch_device.py:
2608         (WatchDevicePort.check_for_leaks):
2609         - Rename redundant 'process_pid' argument to 'process_id'.
2610
2611         * WebKitTestRunner/TestController.cpp:
2612         (WTR::TestController::dumpResponse):
2613         - Extract method from findAndDumpWorldLeaks() so that it may be
2614           reused by findAndDumpWebKitProcessIdentifiers().
2615         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2616         - Add method to output process name and process ID of both the
2617           WebContent and Networking processes.
2618         (WTR::TestController::findAndDumpWorldLeaks):
2619         - Fix missing newline in output when there were no abandoned
2620           documents.
2621         - Call dumpResponse() for extracted code.
2622         (WTR::TestController::handleControlCommand):
2623         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2624         - Use strncmp() instead of strcmp().
2625         - Call findAndDumpWebKitProcessIdentifiers() when
2626           "#LIST CHILD PROCESSES" command is sent.
2627         * WebKitTestRunner/TestController.h:
2628         (WTR::TestController::dumpResponse):
2629         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2630         - Declare methods.
2631
2632 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2633
2634         Unreviewed. Add GLib API test cases after r243434.
2635
2636         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2637         (testWebViewActiveURI):
2638         (serverCallback):
2639         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2640         (sendRequestCallback):
2641
2642 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2643
2644         Geolocation request not complete when watch request was started in a different web process
2645         https://bugs.webkit.org/show_bug.cgi?id=195996
2646
2647         Reviewed by Alex Christensen.
2648
2649         Add a test case.
2650
2651         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2652         (TestWebKitAPI::runJavaScriptAlert):
2653         (TestWebKitAPI::TEST):
2654
2655 2019-03-26  Keith Rollin  <krollin@apple.com>
2656
2657         Update the way generate-xcfilelists returns strings from functions
2658         https://bugs.webkit.org/show_bug.cgi?id=195975
2659         <rdar://problem/49040807>
2660
2661         Reviewed by Dean Jackson.
2662
2663         There are places where generate-xcfilelists executes assignments with
2664         statements like:
2665
2666             FOO=$(some_function)
2667
2668         where "some_function" return a string by echoing it. E.g.
2669
2670             some_function()
2671             {
2672                 echo "Hello, World"
2673             }
2674
2675         This is a common idiom, but it has a problem if "some_function" needs
2676         to call "exit" in an attempt to halt the entire script right then and
2677         there. Since "some_function" is called inside of $(), it's being
2678         executed in a sub-shell. Calling exit in that sub-shell simply exits
2679         that shell; it doesn't not exit the outer shell in which the main part
2680         of the script is still running. As such, the main script keeps
2681         executing when the intent was for the script to halt.
2682
2683         The solution to this is to use a different idiom for returning
2684         strings. The one we now is to pass in the name of the variable to
2685         receive the string result:
2686
2687             some_function()
2688             {
2689                 variable_name=$1
2690                 eval $variable_name ="Hello, World"
2691             }
2692
2693         The call site now looks like
2694
2695             some_function FOO
2696
2697         Because there's no invocation of a sub-shell, some_function can now
2698         call "exit" if it wants to, and the entire script will exit at that
2699         point.
2700
2701         * Scripts/generate-xcfilelists:
2702
2703 2019-03-26  Chris Dumez  <cdumez@apple.com>
2704
2705         Add basic layout test coverage for File Picker on iOS
2706         https://bugs.webkit.org/show_bug.cgi?id=196265
2707
2708         Reviewed by Wenson Hsieh.
2709
2710         Add layout test infrastructure to test the file picker on iOS.
2711
2712         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2713         (WTR::UIScriptController::dismissFilePicker):
2714         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2715         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2716         (WTR::UIScriptController::dismissFilePicker):
2717         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2718         * WebKitTestRunner/TestController.cpp:
2719         (WTR::TestController::createWebViewWithOptions):
2720         (WTR::updateTestOptionsFromTestHeader):
2721         * WebKitTestRunner/TestOptions.h:
2722         (WTR::TestOptions::hasSameInitializationOptions const):
2723         * WebKitTestRunner/ios/TestControllerIOS.mm:
2724         (overridePresentViewController):
2725         (WTR::TestController::platformInitialize):
2726         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2727         (WTR::UIScriptController::dismissFilePicker):
2728
2729 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2730
2731         Implement async paste method on UIWKInteractionViewProtocol
2732         https://bugs.webkit.org/show_bug.cgi?id=196267
2733         <rdar://problem/49236346>
2734
2735         Reviewed by Tim Horton.
2736
2737         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2738         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2739         are now a part of all iOS 12 internal SDKs.
2740
2741         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2742
2743         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2744         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2745
2746         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2747         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2748         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2749         * TestWebKitAPI/ios/UIKitSPI.h:
2750
2751 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2752
2753         [ews-build] Use PostgreSQL for ews.webkit.org database
2754         https://bugs.webkit.org/show_bug.cgi?id=196270
2755
2756         Reviewed by Lucas Forschler.
2757
2758         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2759
2760 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2761
2762         [ews] Reset simctl states on reboot
2763         https://bugs.webkit.org/show_bug.cgi?id=196260
2764
2765         Rubber-stamped by Aakash Jain.
2766
2767         * EWSTools/start-queue-mac.sh:
2768
2769 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2770
2771         [ews-build] Use PostgreSQL for ews-build database
2772         https://bugs.webkit.org/show_bug.cgi?id=196229
2773
2774         Reviewed by Lucas Forschler.
2775
2776         * BuildSlaveSupport/ews-build/master.cfg:
2777
2778 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2779
2780         [ews-build] Get master_hostname dynamically in master.cfg
2781         https://bugs.webkit.org/show_bug.cgi?id=196255
2782
2783         Reviewed by Lucas Forschler.
2784
2785         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2786         send events data in test mode.
2787
2788 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2789
2790         [ews-app] Set db_constraint to False for Foreign Keys
2791         https://bugs.webkit.org/show_bug.cgi?id=196252
2792
2793         Reviewed by Lucas Forschler.
2794
2795         * BuildSlaveSupport/ews-app/ews/models/build.py:
2796         * BuildSlaveSupport/ews-app/ews/models/step.py:
2797
2798 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2799
2800         [ews-build] is_test_mode_enabled should default to True
2801         https://bugs.webkit.org/show_bug.cgi?id=196248
2802
2803         Reviewed by Lucas Forschler.
2804
2805         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2806
2807 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2808
2809         [ews-app] Add webkitperl to ENABLED_QUEUES
2810         https://bugs.webkit.org/show_bug.cgi?id=196253
2811
2812         Reviewed by Lucas Forschler.
2813
2814         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2815
2816 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2817
2818         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2819         https://bugs.webkit.org/show_bug.cgi?id=196211
2820         rdar://problem/49110552
2821
2822         Reviewed by Tim Horton.
2823
2824         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2825         Make sure that EventSenderProxy always exists when running tests. We used to create
2826         it when resetting before the first test, which is a bit too late.
2827
2828         * WebKitTestRunner/TestController.h:
2829         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2830         (WTR::TestController::platformCreateWebView):
2831         (WTR::TestController::platformCreateOtherPage):
2832         (WTR::TestController::finishCreatingPlatformWebView):
2833         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2834         (WTR::PlatformWebView::PlatformWebView):
2835         Moved some code that made NSWindow use NSEvent during web view creation. We may
2836         need to move more if some other case us found, but this is enough for now.
2837
2838 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2839
2840         Unreviewed. Fix typo in GLib geolocation API after r243285.
2841
2842         gelocation -> geolocation.
2843
2844         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2845         (testGeolocationManagerWatchPosition):
2846
2847 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2848
2849         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2850         https://bugs.webkit.org/show_bug.cgi?id=196213
2851
2852         Reviewed by Geoff Garen.
2853
2854         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2855         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2856         (credentialWithIdentityAndKeychainPath):
2857         (-[ChallengeDelegate webView:didFinishNavigation:]):
2858         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2859         (TestWebKitAPI::TEST):
2860
2861 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2862
2863         Expected shouldn't assume its contained types are copyable
2864         https://bugs.webkit.org/show_bug.cgi?id=195986
2865
2866         Reviewed by JF Bastien.
2867
2868         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2869         (TestWebKitAPI::NonCopyable::operator== const):
2870         (TestWebKitAPI::NonCopyable::operator!= const):
2871         (TestWebKitAPI::TEST):
2872
2873 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2874
2875         Remove some now-unnecessary dynamic class lookup
2876         https://bugs.webkit.org/show_bug.cgi?id=196237
2877
2878         Reviewed by Simon Fraser.
2879
2880         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2881         (makeRequest):
2882         (TEST):
2883
2884 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2885
2886         Unreviewed, rolling out r243450.
2887
2888         AppleWin and WinCairo port builds get broken.
2889
2890         Reverted changeset:
2891
2892         "Add test for fix of #196095"
2893         https://bugs.webkit.org/show_bug.cgi?id=196097
2894         https://trac.webkit.org/changeset/243450
2895
2896 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2897
2898         Unreviewed, rolling out r243465.
2899         https://bugs.webkit.org/show_bug.cgi?id=196226
2900
2901         the test doesn't build (Requested by thorton on #webkit).
2902
2903         Reverted changeset:
2904
2905         "Do not terminate the NetworkProcess if a third party
2906         application sends a NSCredential with a SecIdentityRef"
2907         https://bugs.webkit.org/show_bug.cgi?id=196213
2908         https://trac.webkit.org/changeset/243465
2909
2910 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2911
2912         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2913         https://bugs.webkit.org/show_bug.cgi?id=196213
2914
2915         Reviewed by Geoff Garen.
2916
2917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2918         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2919         (credentialWithIdentityAndKeychainPath):
2920         (-[ChallengeDelegate webView:didFinishNavigation:]):
2921         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2922         (TestWebKitAPI::TEST):
2923
2924 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2925
2926         [ews-build] Gracefully handle missing patch_id in events
2927         https://bugs.webkit.org/show_bug.cgi?id=196216
2928
2929         Reviewed by Lucas Forschler.
2930
2931         * BuildSlaveSupport/ews-build/events.py:
2932
2933 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2934
2935         [ews-build] use lz4 compression for improving buildbot performance
2936         https://bugs.webkit.org/show_bug.cgi?id=196155
2937
2938         Reviewed by Lucas Forschler.
2939
2940         * BuildSlaveSupport/ews-build/master.cfg:
2941
2942 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2943
2944         Pull some API testing helper methods out of TestWKWebView
2945         https://bugs.webkit.org/show_bug.cgi?id=196212
2946
2947         Reviewed by Tim Horton.
2948
2949         Refactor some more API testing utility methods, so that they can be used in
2950         tests that do not use TestWKWebView.
2951
2952         * TestWebKitAPI/cocoa/TestWKWebView.h:
2953         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2954         (-[WKWebView loadTestPageNamed:]):
2955         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2956         (-[WKWebView synchronouslyLoadHTMLString:]):
2957         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2958         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2959         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2960         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2961         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2962
2963 2019-03-25  Jer Noble  <jer.noble@apple.com>
2964
2965         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2966         https://bugs.webkit.org/show_bug.cgi?id=196097
2967
2968         Reviewed by Eric Carlson.
2969
2970         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2971
2972         * DumpRenderTree/mac/DumpRenderTree.mm:
2973         (resetWebPreferencesToConsistentValues):
2974         * WebKitTestRunner/TestController.cpp:
2975         (WTR::TestController::resetPreferencesToConsistentValues):
2976
2977 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2978
2979         Pull IPadUserInterfaceSwizzler out into a separate header file
2980         https://bugs.webkit.org/show_bug.cgi?id=196193
2981
2982         Reviewed by Anders Carlsson.
2983
2984         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2985         be used in other API tests.
2986
2987         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2988         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2989         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2990         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2991         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2992         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2993         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2994
2995 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2996
2997         Remove NavigatorContentUtils in WebCore/Modules
2998         https://bugs.webkit.org/show_bug.cgi?id=196070
2999
3000         Reviewed by Alex Christensen.
3001
3002         NavigatorContentUtils was to support the custom scheme spec [1].
3003         However, in WebKit side, no port has supported the feature in
3004         WebKit layer after EFL port was removed. So there has been the
3005         only IDL implementation of the NavigatorContentUtils in WebCore.
3006         So we don't need to keep the implementation in WebCore anymore.
3007
3008         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
3009
3010         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3011
3012 2019-03-24  Andy Estes  <aestes@apple.com>
3013
3014         [watchOS] Remove unused Proximity Networking code
3015         https://bugs.webkit.org/show_bug.cgi?id=196188
3016
3017         Reviewed by Tim Horton.
3018
3019         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3020         (TEST):
3021
3022 2019-03-23  Keith Miller  <keith_miller@apple.com>
3023
3024         Refactor clz/ctz and fix getLSBSet.
3025         https://bugs.webkit.org/show_bug.cgi?id=196162
3026
3027         Reviewed by Saam Barati.
3028
3029         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3030
3031         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3032         (TestWebKitAPI::TEST):
3033
3034 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3035
3036         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3037         https://bugs.webkit.org/show_bug.cgi?id=196143
3038
3039         Reviewed by Michael Catanzaro.
3040
3041         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3042         directories.
3043
3044         * Scripts/webkitpy/style/checkers/cpp.py:
3045         (check_identifier_name_in_declaration):
3046         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3047         (WebKitStyleTest.test_names):
3048
3049 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3050
3051         [Flatpak] Manifest expanding fails for qt WPE extension
3052         https://bugs.webkit.org/show_bug.cgi?id=196148
3053
3054         Reviewed by Alex Christensen.
3055
3056         * flatpak/flatpakutils.py:
3057         (expand_submodules_recurse): The last recurse manifest expand
3058         iteration might lead to a single module so take it into account
3059         and don't try to recurse further.
3060
3061 2019-03-22  Chris Dumez  <cdumez@apple.com>
3062
3063         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3064         https://bugs.webkit.org/show_bug.cgi?id=195348
3065         <rdar://problem/48622090>
3066
3067         Reviewed by Alex Christensen.
3068
3069         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3070         to NO when test.options().shouldIgnoreMetaViewport is false.
3071
3072         * WebKitTestRunner/ios/TestControllerIOS.mm:
3073         (WTR::TestController::platformConfigureViewForTest):
3074
3075 2019-03-22  Chris Dumez  <cdumez@apple.com>
3076
3077         Prewarmed processes should be usable with any website data store
3078         https://bugs.webkit.org/show_bug.cgi?id=196104
3079
3080         Reviewed by Alex Christensen.
3081
3082         Add API test coverage.
3083
3084         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3085         (runInitialWarmedProcessUsedTest):
3086         (TEST):
3087
3088 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3089
3090         Back out local changes to Alex's Subversion working directory
3091
3092         They were accidentally committed.
3093
3094         * Scripts/webkitpy/common/system/abstractexecutive.py:
3095         (AbstractExecutive.wait_newest):
3096         * Scripts/webkitpy/common/system/executive.py:
3097         (Executive.running_pids):
3098         * Scripts/webkitpy/common/system/executive_mock.py:
3099         (MockExecutive.running_pids):
3100         * Scripts/webkitpy/common/system/executive_unittest.py:
3101         (ExecutiveTest.serial_test_running_pids):
3102         * Scripts/webkitpy/port/darwin.py:
3103         (DarwinPort.check_for_leaks):
3104         * Scripts/webkitpy/port/leakdetector.py:
3105         (LeakDetector.check_for_leaks):
3106         - This was the hack attached to Bug 193772.
3107
3108         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3109         (+[WebKitTestRunnerEvent mouseLocation]):
3110         - This works around a crash on an internal build.
3111
3112 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3113
3114         Fix the build after r243354
3115         https://bugs.webkit.org/show_bug.cgi?id=196138
3116         <rdar://problem/49145951>
3117
3118         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3119         (TEST):
3120         * TestWebKitAPI/ios/UIKitSPI.h:
3121
3122 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3123
3124         Adopt UIWKDocumentContext
3125         https://bugs.webkit.org/show_bug.cgi?id=196040
3126         <rdar://problem/48642440>
3127
3128         Reviewed by Ryosuke Niwa.
3129
3130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3131         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3132         (makeRequest):
3133         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3134         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3135         (applyStyle):
3136         (TEST):
3137         Add tests for UIWKDocumentContext.
3138
3139         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3140         (TEST):
3141         (recursiveFindWKContentView): Deleted.
3142         * TestWebKitAPI/cocoa/TestWKWebView.h:
3143         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3144         (recursiveFindWKContentView):
3145         (-[TestWKWebView wkContentView]):
3146         * TestWebKitAPI/ios/UIKitSPI.h:
3147         Share the WKContentView finding code between tests.
3148
3149 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3150
3151         [iOS WK2] Turn on async overflow scrolling by default
3152         https://bugs.webkit.org/show_bug.cgi?id=196011
3153         rdar://problem/48453859
3154
3155         Reviewed by Antti Koivisto.
3156         
3157         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3158         since so many basic layout tests have different results when compositing is triggered for
3159         overflow.
3160         
3161         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3162
3163         * WebKitTestRunner/TestController.cpp:
3164         (WTR::TestController::resetPreferencesToConsistentValues):
3165
3166 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3167
3168         [ews-build] Retry API test in case of failures
3169         https://bugs.webkit.org/show_bug.cgi?id=196004
3170
3171         Reviewed by Lucas Forschler.
3172
3173         * BuildSlaveSupport/ews-build/steps.py:
3174         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3175         (CompileWebKitToT.doStepIf): Ditto.
3176         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3177         (ReRunAPITests): Re-run API tests.
3178         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3179         (RunAPITestsWithoutPatch): Run API tests without patch.
3180         (RunAPITestsWithoutPatch.doStepIf):
3181         (RunAPITestsWithoutPatch.hideStepIf):
3182         (RunAPITestsWithoutPatch.evaluateCommand):
3183         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3184         (AnalyzeAPITestsResults.start):
3185         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3186         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3187         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3188         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3189
3190 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3191
3192         [ews-build] Update queues configurations
3193         https://bugs.webkit.org/show_bug.cgi?id=196074
3194
3195         Reviewed by Dewei Zhu.
3196
3197         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3198         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3199
3200 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3201
3202         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3203         https://bugs.webkit.org/show_bug.cgi?id=195680
3204         <rdar://problem/48903534>
3205
3206         Unreviewed infrastructure fix.
3207
3208         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3209         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3210
3211 2019-03-21  Andy Estes  <aestes@apple.com>
3212
3213         [iOS] Apple Pay should be available in documents with no user agent scripts
3214         https://bugs.webkit.org/show_bug.cgi?id=196061
3215         <rdar://problem/48649391>
3216
3217         Reviewed by Brady Eidson.
3218
3219         Added API tests and related infrastructure.
3220
3221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3222         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3223         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3224         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3225         (TestWebKitAPI::TEST):
3226         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3227         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3228         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3229         * TestWebKitAPI/cocoa/TestProtocol.mm:
3230         (-[TestProtocol startLoading]):
3231         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3232         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3233         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3234         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3235
3236 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3237
3238         REGRESSSION (r243297): webkitpy tests broken
3239         https://bugs.webkit.org/show_bug.cgi?id=196108
3240
3241         Reviewed by Aakash Jain.
3242
3243         r243297 updated contributors.json, which broke a few unit tests.
3244
3245         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3246         (IRCCommandTest.test_whois):
3247         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3248
3249 2019-03-21  Chris Dumez  <cdumez@apple.com>
3250
3251         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3252         https://bugs.webkit.org/show_bug.cgi?id=196041
3253         <rdar://problem/49083230>
3254
3255         Reviewed by Alex Christensen.
3256
3257         Add API test coverage.
3258
3259         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3260         (TEST):
3261
3262 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3263
3264         Add SPI to inform applications of WKContentRuleList actions
3265         https://bugs.webkit.org/show_bug.cgi?id=195965
3266         <rdar://problem/42664365>
3267
3268         Reviewed by Geoff Garen.
3269
3270         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3271         (TestWebKitAPI::allActionsForResourceLoad):
3272         (TestWebKitAPI::testRequest):
3273         (TestWebKitAPI::TEST_F):
3274         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3275         (Notification::description):
3276         (Notification::operator== const):
3277         (toVector):
3278         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3279         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3280         (makeContentRuleList):
3281         (TEST):
3282         (makeWarnContentRuleList): Deleted.
3283
3284 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3285
3286         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3287         https://bugs.webkit.org/show_bug.cgi?id=196088
3288
3289         Reviewed by Brian Burg.
3290
3291         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3292         Support checks when only one platform is specified. Also deprecate macosx() and
3293         force the use of macos() instead.
3294
3295         * Scripts/webkitpy/style/checkers/cpp.py:
3296         (check_min_versions_of_wk_api_available):
3297         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3298         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3299
3300 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3301
3302         Update status inactive committers' status to 'contributor'.
3303
3304         * Scripts/webkitpy/common/config/contributors.json:
3305
3306 2019-03-21  Xan Lopez  <xan@igalia.com>
3307
3308         [JSC][x86] Drop support for x87 floating point
3309         https://bugs.webkit.org/show_bug.cgi?id=194853
3310
3311         Reviewed by Don Olmstead.
3312
3313         Force SSE2 on x86/32bit builds.
3314
3315         * Scripts/webkitdirs.pm:
3316         (generateBuildSystemFromCMakeProject):
3317
3318 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3319
3320         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3321         https://bugs.webkit.org/show_bug.cgi?id=196073
3322
3323         Reviewed by Michael Catanzaro.
3324
3325         Add test cases to check functions and constructors with no arguments but receiving user data.
3326
3327         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3328         (checkUserData):
3329         (testJSCFunction):
3330         (fooCreateWithUserData):
3331         (testJSCClass):
3332
3333 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3334
3335         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3336
3337         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3338
3339         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3340
3341 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3342
3343         [GTK][WPE] Add API to provide geolocation information
3344         https://bugs.webkit.org/show_bug.cgi?id=195940
3345
3346         Reviewed by Michael Catanzaro.
3347
3348         Add a new test to check the new API.
3349
3350         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3351         (testGeolocationManagerCurrentPosition):
3352         (testGeolocationManagerWatchPosition):
3353         (beforeAll):
3354         (afterAll):
3355         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3356         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3357         (beforeAll): Ditto.
3358         * TestWebKitAPI/glib/CMakeLists.txt:
3359
3360 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3361
3362         [GLib] Returning G_TYPE_OBJECT from a method does not work
3363         https://bugs.webkit.org/show_bug.cgi?id=195574
3364
3365         Reviewed by Michael Catanzaro.
3366
3367         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3368
3369         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3370         (getGFile):
3371         (getParent):
3372         (createGString):
3373         (getGString):
3374         (getGStringCopyWillRaise):
3375         (getGStringCopy):
3376         (getGStringStr):
3377         (getGStringLen):
3378         (freeGString):
3379         (testJSCClass):
3380
3381 2019-03-20  Saam Barati  <sbarati@apple.com>
3382
3383         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3384         https://bugs.webkit.org/show_bug.cgi?id=195721
3385
3386         Reviewed by Filip Pizlo.
3387
3388         * Scripts/run-javascriptcore-tests:
3389
3390 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3391
3392         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3393         https://bugs.webkit.org/show_bug.cgi?id=196049
3394
3395         Reviewed by Tim Horton.
3396
3397         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3398         overflow scrolling in general, so rename it.
3399
3400         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3401
3402 2019-03-20  Daniel Bates  <dabates@apple.com>
3403
3404         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3405         https://bugs.webkit.org/show_bug.cgi?id=196031
3406         <rdar://problem/49078172>
3407
3408         Reviewed by Tim Horton.
3409
3410         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3411         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3412         same code path used when the Done button is pressed to dismiss the <select> picker.
3413
3414         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3415         (TestWebKitAPI::TEST):
3416
3417 2019-03-20  Chris Dumez  <cdumez@apple.com>
3418
3419         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3420         https://bugs.webkit.org/show_bug.cgi?id=196029
3421         <rdar://problem/48954651>
3422
3423         Reviewed by Tim Horton.
3424
3425         Add API test coverage.
3426
3427         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3428
3429 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3430
3431         [ews-build] Improve failure summary string for ApplyPatch step
3432         https://bugs.webkit.org/show_bug.cgi?id=195995
3433
3434         Reviewed by Alexey Proskuryakov.
3435
3436         * BuildSlaveSupport/ews-build/steps.py:
3437         (ApplyPatch.getResultSummary): Override getResultSummary.
3438
3439 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3440
3441         AX: Implement support for new meter ARIA role
3442         https://bugs.webkit.org/show_bug.cgi?id=195966
3443
3444         Reviewed by Chris Fleizach.
3445
3446         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3447         to AXLevelIndicator.
3448
3449         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3450
3451 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3452
3453         [WebAuthN] Implement FIDO AppID extension
3454         https://bugs.webkit.org/show_bug.cgi?id=143491
3455         <rdar://problem/48298273>
3456
3457         Reviewed by Brent Fulgham.
3458
3459         Add a test that covers the new flag of convertToU2fSignCommand.
3460
3461         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3462         (TestWebKitAPI::TEST):
3463         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3464         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3465         (TestWebKitAPI::TEST):
3466
3467 2019-03-19  Keith Rollin  <krollin@apple.com>
3468
3469         Add support for more platforms to generate-xcfilelists
3470         https://bugs.webkit.org/show_bug.cgi?id=195977
3471
3472         Reviewed by Alexey Proskuryakov.
3473
3474         generate-xcfilelists incorrectly complains when involved with building
3475         WebKit for iphonesimulator:
3476
3477             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3478             …
3479             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3480
3481         Address this by teaching generate-xcfilelists about more platforms.
3482
3483         * Scripts/generate-xcfilelists:
3484
3485 2019-03-19  John Wilander  <wilander@apple.com>
3486
3487         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3488         https://bugs.webkit.org/show_bug.cgi?id=195923
3489         <rdar://problem/49001272>
3490
3491         Reviewed by Alex Christensen.
3492
3493         This patch does the following to the TestRunner:
3494         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3495         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3496         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3497
3498         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3499         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3500         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3501         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3502         * WebKitTestRunner/TestController.cpp:
3503         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3504         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3505         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3506         * WebKitTestRunner/TestController.h:
3507         * WebKitTestRunner/TestInvocation.cpp:
3508         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3509
3510 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3511
3512         [CMake] Support more clang and gcc sanitizers
3513         https://bugs.webkit.org/show_bug.cgi?id=195956
3514
3515         Reviewed by Michael Catanzaro.
3516
3517         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3518
3519 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3520
3521         [ews-build] Improve summary for PrintConfiguration step
3522         https://bugs.webkit.org/show_bug.cgi?id=195945
3523
3524         Reviewed by Lucas Forschler.
3525
3526         * BuildSlaveSupport/ews-build/steps.py:
3527         (PrintConfiguration.getResultSummary): Override getResultSummary.
3528
3529 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3530
3531         [ews-build] Improve summary for CheckOutSource step
3532         https://bugs.webkit.org/show_bug.cgi?id=195963
3533
3534         Reviewed by Lucas Forschler.
3535
3536         * BuildSlaveSupport/ews-build/steps.py:
3537         (CheckOutSource.getResultSummary):
3538
3539 2019-03-19  Daniel Bates  <dabates@apple.com>
3540
3541         [iOS] Focus not preserved when switching between tabs
3542         https://bugs.webkit.org/show_bug.cgi?id=195820
3543         <rdar://problem/43614450>
3544
3545         Reviewed by Brent Fulgham.
3546
3547         Add tests to ensure that we restore focus when resigning and becoming first responder.
3548
3549         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3550         (TestWebKitAPI::TEST):
3551
3552 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3553
3554         Make WTFLogChannelState and WTFLogLevel enum classes
3555         https://bugs.webkit.org/show_bug.cgi?id=195904
3556
3557         Reviewed by Eric Carlson.
3558
3559         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3560         (TestWebKitAPI::TEST_F):
3561
3562 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3563
3564         [GStreamer][EME] Backported mssdemux protection data crash fix
3565         https://bugs.webkit.org/show_bug.cgi?id=195918
3566
3567         Reviewed by Philippe Normand.
3568
3569         * gstreamer/jhbuild.modules:
3570         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3571
3572 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3573
3574         Unreviewed, rolling out r243132.
3575
3576         Broke GTK build
3577
3578         Reverted changeset:
3579
3580         "Make WTFLogChannelState and WTFLogLevel enum classes"
3581         https://bugs.webkit.org/show_bug.cgi?id=195904
3582         https://trac.webkit.org/changeset/243132
3583
3584 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3585
3586         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3587
3588         * Scripts/webkitdirs.pm:
3589         (builtDylibPathForName): Adjust the shared library name that's changed
3590         with the API version bump in r243073.
3591
3592 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3593
3594         Make WTFLogChannelState and WTFLogLevel enum classes
3595         https://bugs.webkit.org/show_bug.cgi?id=195904
3596
3597         Reviewed by Eric Carlson.
3598
3599         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3600         (TestWebKitAPI::TEST_F):
3601
3602 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3603
3604         Disable flaky test added in r2431100
3605         https://webkit.org/b/195785
3606
3607         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3608         (TestWebKitAPI::TEST):
3609         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3610
3611 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3612
3613         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3614         https://bugs.webkit.org/show_bug.cgi?id=195916
3615
3616         Reviewed by Tim Horton.
3617
3618         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3619         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3620
3621 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3622
3623         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3624
3625         * Scripts/webkitpy/common/config/contributors.json:
3626
3627 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3628
3629         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3630         https://bugs.webkit.org/show_bug.cgi?id=195785
3631
3632         Reviewed by Geoffrey Garen.
3633
3634         * TestWebKitAPI/TCPServer.cpp: Added.
3635         (TestWebKitAPI::TCPServer::TCPServer):
3636         (TestWebKitAPI::TCPServer::~TCPServer):
3637         (TestWebKitAPI::TCPServer::socketBindListen):
3638         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3639         * TestWebKitAPI/TCPServer.h: Added.
3640         (TestWebKitAPI::TCPServer::port const):
3641         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3642         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3643         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3644         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3645         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3646         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3647         (TestWebKitAPI::respondSlowly):
3648         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3649         (TestWebKitAPI::downloadAtRate):
3650         (TestWebKitAPI::TEST):
3651
3652 2019-03-18  Saam Barati  <sbarati@apple.com>
3653
3654         Add a plan file for JetStream 2
3655         https://bugs.webkit.org/show_bug.cgi?id=190734
3656
3657         Reviewed by Mark Lam.
3658
3659         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3660
3661 2019-03-18  Chris Dumez  <cdumez@apple.com>
3662
3663         Delay WebProcess launch until a load is triggered in a Web view
3664         https://bugs.webkit.org/show_bug.cgi?id=195758
3665         <rdar://problem/48126013>
3666
3667         Reviewed by Geoff Garen.
3668
3669         Add API test coverage. Also update some existing API tests to not expect
3670         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3671
3672         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3673         (TestWebKitAPI::TEST):
3674         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3675         (TestWebKitAPI::TEST):
3676         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3677         (TEST):
3678         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3679         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3680         (TEST):
3681         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3682         (TEST):
3683         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3684
3685 2019-03-18  Xan Lopez  <xan@igalia.com>
3686
3687         [CMake] Prevent potential warning when determining $architecture
3688         https://bugs.webkit.org/show_bug.cgi?id=195891
3689
3690         Reviewed by Michael Catanzaro.
3691
3692         It's possible for generateBuildSystemForCMakeProject to be called
3693         before determineArchitecture() is ever called. This will make the
3694         first eq check with $architecture to be bogus (and print a
3695         warning). Change that to an eq check with architecture(), which
3696         implicitly calls determineArchitecture() if needed, and change all
3697         the other similar cases in the method in the same way to prevent
3698         future bugs like this one.
3699
3700         * Scripts/webkitdirs.pm:
3701         (generateBuildSystemFromCMakeProject):
3702
3703 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3704
3705         [WPE] Tarballs generated with “make dist” cannot build documentation
3706         https://bugs.webkit.org/show_bug.cgi?id=195885
3707
3708         Reviewed by Carlos Garcia Campos.
3709
3710         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3711
3712 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3713
3714         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3715         https://bugs.webkit.org/show_bug.cgi?id=195883
3716
3717         Reviewed by Carlos Garcia Campos.
3718
3719         * gtkdoc/gtkdoc.py:
3720         (GTKDoc._run_command): When commands fail to run, include the full command line for
3721         the program invocation and the output it has generated on the standard error stream.
3722
3723 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3724
3725         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3726         https://bugs.webkit.org/show_bug.cgi?id=195786
3727
3728         Reviewed by Philippe Normand.
3729
3730         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3731         * wpe/jhbuild.modules: Ditto.
3732
3733 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3734
3735         [ews-build] Don't run clean builds on EWS builders
3736         https://bugs.webkit.org/show_bug.cgi?id=195851
3737
3738         Reviewed by Geoffrey Garen.
3739
3740         * BuildSlaveSupport/ews-build/factories.py:
3741
3742 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3743
3744         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3745         https://bugs.webkit.org/show_bug.cgi?id=195849
3746
3747         Reviewed by Chris Dumez.
3748
3749         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3750
3751         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3752         (runWebsiteDataStoreCustomPaths):
3753
3754 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3755
3756         webkitpy: Upload test results
3757         https://bugs.webkit.org/show_bug.cgi?id=195755
3758         <rdar://problem/48896182>
3759
3760         Reviewed by Aakash Jain.
3761
3762         Establish a new format for uploading results that is not tied to layout tests, apply
3763         that format to webkitpy tests.
3764
3765         * Scripts/webkitpy/common/checkout/scm/git.py:
3766         (Git.native_branch): Return what branch the current checkout is on.
3767         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3768         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3769         * Scripts/webkitpy/common/checkout/scm/svn.py:
3770         (SVN.native_branch): Ditto.
3771         * Scripts/webkitpy/common/system/platforminfo.py:
3772         (PlatformInfo.build_version): Return a build version for Mac.
3773         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3774         (MockPlatformInfo.__init__):
3775         (MockPlatformInfo.build_version):
3776         * Scripts/webkitpy/results: Added.
3777         * Scripts/webkitpy/results/__init__.py: Added.
3778         * Scripts/webkitpy/results/options.py: Added.
3779         (upload_options): OptParse list for upload options.
3780         * Scripts/webkitpy/results/upload.py: Added.
3781         (Upload): Class which enforces the upload format expected by the results server.
3782         (Upload.Expectations):
3783         (Upload.create_configuration):
3784         (Upload.create_commit):
3785         (Upload.create_details):
3786         (Upload.create_run_stats):
3787         (Upload.create_test_result):
3788         (Upload.__init__):
3789         (Upload.Encoder): Encode Upload object as json.
3790         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3791         * Scripts/webkitpy/results/upload_unittest.py: Added.
3792         * Scripts/webkitpy/test/main.py:
3793         (Tester._parse_args): Add upload arguments.
3794         (Tester._run_tests): Allow results to be uploaded.
3795         * Scripts/webkitpy/test/runner.py:
3796         (Runner.__init__): Record which tests were run, rather than just counting them.
3797         (Runner.handle):
3798         * Scripts/webkitpy/test/runner_unittest.py:
3799         (RunnerTest.test_run):
3800         * Scripts/webkitpy/thirdparty/__init__.py:
3801         (AutoinstallImportHook.find_module): Add requests auto-install.
3802         (AutoinstallImportHook._install_requests):
3803         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3804         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3805
3806 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3807
3808         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3809         https://bugs.webkit.org/show_bug.cgi?id=195810
3810
3811         Reviewed by Tim Horton.
3812
3813         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3814         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3815         ending certain layout tests.
3816
3817         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3818         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3819         (-[TestRunnerWKWebView dealloc]):
3820         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3821
3822         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3823         helper method when destroying the web view, and when resetting state between tests.
3824
3825         * WebKitTestRunner/ios/TestControllerIOS.mm:
3826         (WTR::TestController::platformResetStateToConsistentValues):
3827
3828         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3829
3830 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3831
3832         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3833         https://bugs.webkit.org/show_bug.cgi?id=190350
3834         <rdar://problem/45089503>
3835
3836         Reviewed by Geoffrey Garen.
3837
3838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3839         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3840         (TEST):
3841         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3842         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3843         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3844         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3845         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3846         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3847         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3848         (runTest):
3849         (createDirectories):
3850         (TEST):
3851         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3852         (TEST):
3853         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3854         (TEST):
3855
3856 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3857
3858         Add support to WebPage for getting the contents as an attributed string.
3859         https://bugs.webkit.org/show_bug.cgi?id=195636
3860         rdar://problem/45055697
3861
3862         Reviewed by Tim Horton.
3863
3864         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3865         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3866
3867 2019-03-15  Chris Dumez  <cdumez@apple.com>
3868
3869         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3870         https://bugs.webkit.org/show_bug.cgi?id=195747
3871
3872         Reviewed by Geoff Garen.
3873
3874         Add API test coverage.
3875
3876         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3877
3878 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3879
3880         Unreviewed, rolling out r242952.
3881
3882         Causing API failures on iOS Simulator
3883
3884         Reverted changeset:
3885
3886         "[PSON] Make sure the WebProcessCache is leverage when
3887         relaunching a process after termination"
3888         https://bugs.webkit.org/show_bug.cgi?id=195747
3889         https://trac.webkit.org/changeset/242952
3890
3891 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3892
3893         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3894         https://bugs.webkit.org/show_bug.cgi?id=195740
3895
3896         Reviewed by Ross Kirsling.
3897
3898         window.open doesn't work for WebKitBrowserWindow because it is not
3899         implemented yet.
3900
3901         1. Implemented createNewPage callback of WKPageUIClient.
3902         2. Changed MainWindow to take a BrowserWindow factory function
3903           instead of BrowserWindowType to be flexible to create
3904           BrowserWindow with extra settings.
3905         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3906           because it is not relevant with MainWindow anymore.
3907
3908         * MiniBrowser/win/Common.cpp:
3909         (parseCommandLine):
3910         * MiniBrowser/win/Common.h:
3911         (CommandLineOptions::CommandLineOptions):
3912         * MiniBrowser/win/MainWindow.cpp:
3913         (MainWindow::MainWindow):
3914         (MainWindow::create):
3915         (MainWindow::init):
3916         (MainWindow::WndProc):
3917         * MiniBrowser/win/MainWindow.h:
3918         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3919         (PrintWebUIDelegate::createWebViewWithRequest):
3920         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3921         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3922         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3923         (WebKitBrowserWindow::updateProxySettings):
3924         (WebKitBrowserWindow::createNewPage):
3925         * MiniBrowser/win/WebKitBrowserWindow.h:
3926         * MiniBrowser/win/WinMain.cpp:
3927         (wWinMain):
3928
3929 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3930
3931         Make it possible to test scrolling tree layer manipulation more easily
3932         https://bugs.webkit.org/show_bug.cgi?id=195780
3933
3934         Reviewed by Tim Horton.
3935         
3936         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3937         cuts off communication of scrolling tree scrolls back to the web process
3938         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3939         allows tests to trigger scrolls which run the scrolling tree layer positioning
3940         logic, but never get another commit from the web process that might mask
3941         scrolling tree bugs.
3942         
3943         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3944         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3945         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3946
3947         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3948         (WTR::UIScriptController::scrollUpdatesDisabled const):
3949         (WTR::UIScriptController::setScrollUpdatesDisabled):
3950         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3951         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3952         (WTR::UIScriptController::scrollUpdatesDisabled const):
3953         (WTR::UIScriptController::setScrollUpdatesDisabled):
3954         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3955         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3956         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3957         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3958         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3959         * WebKitTestRunner/ios/TestControllerIOS.mm:
3960         (WTR::TestController::platformResetStateToConsistentValues):
3961         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3962         (WTR::UIScriptController::scrollUpdatesDisabled const):
3963         (WTR::UIScriptController::setScrollUpdatesDisabled):
3964
3965 2019-03-14  Youenn Fablet  <youenn@apple.com>
3966
3967         Move IDB storage in private browsing mode to NetworkProcess
3968         https://bugs.webkit.org/show_bug.cgi?id=195602
3969
3970         Reviewed by Brady Eidson.
3971
3972         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3973         (TEST):
3974
3975 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3976
3977         [ews-build] Make descriptionDone messages more readable
3978         https://bugs.webkit.org/show_bug.cgi?id=195760
3979
3980         Reviewed by Lucas Forschler.
3981
3982         * BuildSlaveSupport/ews-build/steps.py:
3983         * BuildSlaveSupport/ews-build/steps_unittest.py:
3984
3985 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3986
3987         [ews-build] Generate status-bubble hover-over messages
3988         https://bugs.webkit.org/show_bug.cgi?id=195680
3989
3990         Reviewed by Lucas Forschler.
3991
3992         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3993         (StatusBubble):
3994         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3995         on hover-over.
3996         (StatusBubble._iso_time):
3997         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3998         hover-over message.
3999         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
4000
4001 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4002
4003         [ews-app] Gracefully handle the case when state_string is None
4004         https://bugs.webkit.org/show_bug.cgi?id=195753
4005
4006         Reviewed by Lucas Forschler.
4007
4008         * BuildSlaveSupport/ews-app/ews/models/build.py:
4009         * BuildSlaveSupport/ews-app/ews/models/step.py:
4010
4011 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4012
4013         [ews-app] Status bubble display pending for currently running build step
4014         https://bugs.webkit.org/show_bug.cgi?id=195744
4015
4016         Reviewed by Lucas Forschler.
4017
4018         * BuildSlaveSupport/ews-build/events.py:
4019         (Events.stepStarted): If state_string is pending, replace it with step name.
4020
4021 2019-03-14  Chris Dumez  <cdumez@apple.com>
4022
4023         Add WebsitePolicy for the client to specify the device orientation & motion access policy
4024         https://bugs.webkit.org/show_bug.cgi?id=195750
4025
4026         Reviewed by Geoffrey Garen.
4027
4028         Add API test coverage.
4029
4030         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4031         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
4032         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4033         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4034
4035 2019-03-14  Chris Dumez  <cdumez@apple.com>
4036
4037         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
4038         https://bugs.webkit.org/show_bug.cgi?id=195747
4039
4040         Reviewed by Geoff Garen.
4041
4042         Add API test coverage.
4043
4044         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4045
4046 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4047
4048         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
4049         https://bugs.webkit.org/show_bug.cgi?id=195725
4050         <rdar://problem/48545062>
4051
4052         Reviewed by Tim Horton.
4053
4054         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
4055         handler is nil.
4056
4057         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4058         (TestWebKitAPI::TEST):
4059
4060 2019-03-13  Sam Weinig  <sam@webkit.org>
4061
4062         Add utility function to allow easy reverse range-based iteration of a container
4063         https://bugs.webkit.org/show_bug.cgi?id=195542
4064
4065         Reviewed by Antti Koivisto.
4066
4067         * TestWebKitAPI/CMakeLists.txt:
4068         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4069         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
4070         (TestWebKitAPI::TEST):
4071         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
4072
4073 2019-03-13  Chris Dumez  <cdumez@apple.com>
4074
4075         Use a ServiceWorker process per registrable domain
4076         https://bugs.webkit.org/show_bug.cgi?id=195649
4077
4078         Reviewed by Youenn Fablet.
4079
4080         Update API test coverage.
4081
4082         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4083
4084 2019-03-13  Chris Dumez  <cdumez@apple.com>
4085
4086         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
4087         https://bugs.webkit.org/show_bug.cgi?id=195684
4088         <rdar://problem/48294714>
4089
4090         Reviewed by Antti Koivisto.
4091
4092         Add API test coverage.
4093
4094         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4095
4096 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4097
4098         [ews-app] Remove unused patch view
4099         https://bugs.webkit.org/show_bug.cgi?id=195669
4100
4101         Reviewed by Lucas Forschler.
4102
4103         * BuildSlaveSupport/ews-app/ews/urls.py:
4104         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
4105
4106 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4107
4108         [ews-app] Use Buildbot result code variables
4109         https://bugs.webkit.org/show_bug.cgi?id=195668
4110
4111         Reviewed by Alexey Proskuryakov.
4112
4113         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
4114         (Buildbot): Added Buildbot result code variables.
4115         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4116         (StatusBubble._build_bubble): Used Buildbot result code variables.
4117
4118 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
4119
4120         [Flatpak] Expand submodule recursively
4121         https://bugs.webkit.org/show_bug.cgi?id=195672
4122
4123         Building WPE with flatpak was impossible without that as it was raising an exception.
4124         Also update wpebackend-fdo to match what is built in jhbuild
4125
4126         Reviewed by Philippe Normand.
4127
4128         * flatpak/flatpakutils.py:
4129         (expand_submodules_recurse):
4130         (expand_manifest):
4131         * flatpak/org.webkit.WPEModules.yaml:
4132
4133 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4134
4135         [ews-app] status bubble should be hidden for certain builds
4136         https://bugs.webkit.org/show_bug.cgi?id=194597
4137
4138         Reviewed by Dewei Zhu.
4139
4140         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4141         (StatusBubble._build_bubble):
4142         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
4143         because the patch didn't have relevant changes.
4144         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
4145         in production yet.
4146
4147 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
4148
4149         [Win] Fix a slew of simple clang-cl warnings.
4150         https://bugs.webkit.org/show_bug.cgi?id=195652
4151
4152         Reviewed by Don Olmstead.
4153
4154         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4155         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
4156
4157 2019-03-12  Justin Fan  <justin_fan@apple.com>
4158
4159         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
4160         https://bugs.webkit.org/show_bug.cgi?id=195518
4161         <rdar://problem/46322356>
4162
4163         Reviewed by Myles C. Maxfield.
4164
4165         * DumpRenderTree/DerivedSources-input.xcfilelist:
4166         * DumpRenderTree/DerivedSources-output.xcfilelist:
4167
4168 2019-03-12  Commit Queue  <commit-queue@webkit.org>
4169
4170         Unreviewed, rolling out r242825.
4171         https://bugs.webkit.org/show_bug.cgi?id=195648
4172
4173         "Broke webkitpy tests with my change to
4174         lldb_dump_class_layout.py" (Requested by rmorisset on
4175         #webkit).
4176
4177         Reverted changeset:
4178
4179         "Alter Tools/Scripts/dump-class-layout to be able to dump all
4180         classes with suspicious padding"
4181         https://bugs.webkit.org/show_bug.cgi?id=195573
4182         https://trac.webkit.org/changeset/242825
4183
4184 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4185
4186         [ews-build] Show status bubbles while the patch is waiting in queue
4187         https://bugs.webkit.org/show_bug.cgi?id=195618
4188
4189         Reviewed by Lucas Forschler.
4190
4191         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4192         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
4193         enabled in initial deployment.
4194         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
4195         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
4196         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
4197         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
4198         (StatusBubble._build_bubbles_for_patch):
4199
4200 2019-03-12  Robin Morisset  <rmorisset@apple.com>
4201
4202         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
4203         https://bugs.webkit.org/show_bug.cgi?id=195573
4204
4205         Reviewed by Simon Fraser.
4206
4207         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
4208
4209         * Scripts/dump-class-layout:
4210         (main):
4211         * lldb/lldb_dump_class_layout.py:
4212         (ClassLayout.__init__):
4213         (ClassLayout._compute_padding_recursive):
4214         (LLDBDebuggerInstance.dump_layout_for_classname):
4215         (LLDBDebuggerInstance):
4216         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
4217         (LLDBDebuggerInstance.layout_for_classname): Deleted.
4218
4219 2019-03-12  Chris Dumez  <cdumez@apple.com>
4220
4221         Device Orientation access permission should be denied unless explicitly granted by the client
4222         https://bugs.webkit.org/show_bug.cgi?id=195625
4223
4224         Reviewed by Youenn Fablet.
4225
4226         add API test coverage.
4227
4228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4229         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
4230         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
4231         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
4232         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4233         (runDeviceOrientationTest):
4234         (TEST):
4235         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4236         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4237
4238 2019-03-12  Jer Noble  <jer.noble@apple.com>
4239
4240         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
4241         https://bugs.webkit.org/show_bug.cgi?id=195137
4242         <rdar://problem/48810307>
4243
4244         Reviewed by Eric Carlson.
4245
4246         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
4247         (TestWebKitAPI::TEST):
4248
4249 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4250
4251         [ews-build] Change urls from uat to production
4252         https://bugs.webkit.org/show_bug.cgi?id=195566
4253
4254         Reviewed by Lucas Forschler.
4255
4256         * BuildSlaveSupport/ews-app/ews/config.py:
4257         * BuildSlaveSupport/ews-build/events.py:
4258         * BuildSlaveSupport/ews-build/steps.py:
4259
4260 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4261
4262         [ews-build] change max_builds for local-worker to 1
4263         https://bugs.webkit.org/show_bug.cgi?id=195568
4264
4265         Reviewed by Lucas Forschler.
4266
4267         * BuildSlaveSupport/ews-build/loadConfig.py:
4268
4269 2019-03-12  Tim Horton  <timothy_horton@apple.com>
4270
4271         Fix the build
4272
4273         * TestRunnerShared/spi/PencilKitTestSPI.h:
4274         * TestWebKitAPI/ios/PencilKitTestSPI.h:
4275
4276 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
4277
4278         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
4279         https://bugs.webkit.org/show_bug.cgi?id=194131
4280
4281         Reviewed by Michael Catanzaro.
4282
4283         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4284         (uriChanged):
4285         (testUnfinishedSubresourceLoad):
4286         (serverCallback):
4287         (beforeAll):
4288
4289 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4290
4291         WTF::Expected should use std::addressof instead of operator&
4292         https://bugs.webkit.org/show_bug.cgi?id=195604
4293
4294         Reviewed by Myles Maxfield.
4295
4296         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4297         (TestWebKitAPI::Unique::Unique):
4298         (TestWebKitAPI::Unique::operator&):
4299         (TestWebKitAPI::TEST):
4300
4301 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
4302
4303         Add Optional to Forward.h.
4304         https://bugs.webkit.org/show_bug.cgi?id=195586
4305
4306         Reviewed by Darin Adler.
4307
4308         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
4309         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
4310         Remove unnecessary includes from headers.
4311
4312 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
4313
4314         Add testing API to hit-test and scroll overflow scrollers
4315         https://bugs.webkit.org/show_bug.cgi?id=195278
4316
4317         Reviewed by Antti Koivisto.
4318         
4319         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
4320         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
4321         
4322         Tests: scrollingcoordinator/ios/scroll-element-at-point.html