Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2
3         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
4         https://bugs.webkit.org/show_bug.cgi?id=193941
5
6         Reviewed by Alex Christensen.
7
8         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
9         * TestWebKitAPI/Tests/WTF/Condition.cpp:
10         * TestWebKitAPI/Tests/WTF/Lock.cpp:
11         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
12         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
13         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
14         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
15         * TestWebKitAPI/Tests/WTF/Time.cpp:
16         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
17         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
18         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
19         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
20
21 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
22
23         Unreviewed, reorder my emails to fix autocomplete in bugzilla
24
25         * Scripts/webkitpy/common/config/contributors.json:
26
27 2019-01-28  Andy Estes  <aestes@apple.com>
28
29         [watchOS] Enable Parental Controls content filtering
30         https://bugs.webkit.org/show_bug.cgi?id=193939
31         <rdar://problem/46641912>
32
33         Reviewed by Ryosuke Niwa.
34
35         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
36
37 2019-01-28  David Kilzer  <ddkilzer@apple.com>
38
39         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
40         <https://webkit.org/b/193884>
41
42         Reviewed by Jiewen Tan.
43
44         * Scripts/webkitpy/style/checkers/cpp.py:
45         (check_language): Add LocalAuthentication to
46         `frameworks_with_soft_links`.
47
48 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
49
50         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
51         https://bugs.webkit.org/show_bug.cgi?id=193891
52
53         Reviewed by Ross Kirsling.
54
55         There were three problems in window sizes of WebView and the host window.
56         1. The sizes of pixel image output were incorrect.
57         2. The host window is going to appear after window.resize was invoked.
58         3. window.resize resized only the host window, not WebView.
59
60         This change solves them with a following approach.
61         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
62         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
63            as well as DumpRenderTree in order to match the client area and the window area.
64         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
65         d. PlatformWebView::setWindowFrame changes both window sizes.
66         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
67
68         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
69         (WTR::PlatformWebView::PlatformWebView): Create the host window
70         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
71         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
72         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
73
74 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
75
76         [ews-app] Add method to save Step data to database
77         https://bugs.webkit.org/show_bug.cgi?id=193890
78
79         Reviewed by Lucas Forschler.
80
81         * BuildSlaveSupport/ews-app/ews/models/step.py:
82         (Step.save_step): Method to save step data.
83         (Step.update_step): Method to update step data.
84         (Step.get_existing_step): Method to fetch existing step from database.
85         (Step.is_valid_result): Method to validate valid step result.
86
87 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
88
89         [ews-app] Add method to save Build data to database
90         https://bugs.webkit.org/show_bug.cgi?id=193735
91
92         Reviewed by Lucas Forschler.
93
94         * BuildSlaveSupport/ews-app/ews/models/build.py:
95         (Build.save_build): Method to save build information to database.
96         (Build.get_existing_build): Method to fetch existing build from database.
97         (Build.is_valid_result): Method to validate build result.
98         * BuildSlaveSupport/ews-app/ews/common/util.py:
99         (is_valid_int_id): Method to validate valid id.
100
101 2019-01-28  Chris Dumez  <cdumez@apple.com>
102
103         Regression(PSON) Crash under WebPageProxy::didStartProgress()
104         https://bugs.webkit.org/show_bug.cgi?id=193915
105         <rdar://problem/47560907>
106
107         Reviewed by Alex Christensen.
108
109         Add API test coverage.
110
111         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
112
113 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
114
115         [ews-app] Rename id variables
116         https://bugs.webkit.org/show_bug.cgi?id=193883
117
118         Reviewed by Lucas Forschler.
119
120         * BuildSlaveSupport/ews-app/ews/models/build.py:
121         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
122         * BuildSlaveSupport/ews-app/ews/models/step.py:
123         * BuildSlaveSupport/ews-app/ews/urls.py:
124         * BuildSlaveSupport/ews-app/ews/views/patch.py:
125         * BuildSlaveSupport/ews-app/ews/views/results.py:
126         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
127
128 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
129
130         [ews-app] Allow certain fields to be empty
131         https://bugs.webkit.org/show_bug.cgi?id=193892
132
133         Reviewed by Lucas Forschler.
134
135         * BuildSlaveSupport/ews-app/ews/models/build.py:
136         * BuildSlaveSupport/ews-app/ews/models/step.py:
137
138 2019-01-28  Rob Buis  <rbuis@igalia.com>
139
140         Update MIME type parser
141         https://bugs.webkit.org/show_bug.cgi?id=180526
142
143         Reviewed by Frédéric Wang.
144
145         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
146         (TestWebKitAPI::TEST):
147
148 2019-01-28  Zalan Bujtas  <zalan@apple.com>
149
150         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
151         https://bugs.webkit.org/show_bug.cgi?id=193896
152
153         Reviewed by Antti Koivisto.
154
155         * LayoutReloaded/misc/LFC-passing-tests.txt:
156
157 2018-12-15  Darin Adler  <darin@apple.com>
158
159         Replace many uses of String::format with more type-safe alternatives
160         https://bugs.webkit.org/show_bug.cgi?id=192742
161
162         Reviewed by Mark Lam.
163
164         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
165         (WTR::cacheTestRunnerCallback): Use makeString.
166         * WebKitTestRunner/TestController.cpp:
167         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
168         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
169
170 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
171
172         Use a load optimizer for some sites
173         https://bugs.webkit.org/show_bug.cgi?id=193881
174         <rdar://problem/46325455>
175
176         Reviewed by Brent Fulgham.
177
178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
179         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
180
181 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
182
183         AX: Introduce a static accessibility tree
184         https://bugs.webkit.org/show_bug.cgi?id=193348
185         <rdar://problem/47203295>
186
187         Reviewed by Ryosuke Niwa.
188
189         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
190
191 2019-01-26  Zalan Bujtas  <zalan@apple.com>
192
193         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
194         https://bugs.webkit.org/show_bug.cgi?id=193867
195
196         Reviewed by Antti Koivisto.
197
198         * LayoutReloaded/misc/LFC-passing-tests.txt:
199
200 2019-01-26  Zalan Bujtas  <zalan@apple.com>
201
202         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
203         https://bugs.webkit.org/show_bug.cgi?id=193865
204
205         Reviewed by Antti Koivisto.
206
207         * LayoutReloaded/misc/LFC-passing-tests.txt:
208
209 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
210
211         Need a mechanism to override navigator.userAgent
212         https://bugs.webkit.org/show_bug.cgi?id=193762
213         <rdar://problem/47504939>
214
215         Reviewed by Brent Fulgham.
216
217         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
218
219         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
220         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
221         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
222
223 2019-01-25  Dean Jackson  <dino@apple.com>
224
225         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
226         https://bugs.webkit.org/show_bug.cgi?id=193831
227         <rdar://problem/47399263>
228
229         Reviewed by Chris Dumez.
230
231         Two new tests that exercise cross-origin and same-origin System
232         Previews.
233
234         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
235
236 2019-01-25  Keith Rollin  <krollin@apple.com>
237
238         Update Xcode projects with "Check .xcfilelists" build phase
239         https://bugs.webkit.org/show_bug.cgi?id=193790
240         <rdar://problem/47201374>
241
242         Reviewed by Alex Christensen.
243
244         Support for XCBuild includes specifying inputs and outputs to various
245         Run Script build phases. These inputs and outputs are specified as
246         .xcfilelist files. Once created, these .xcfilelist files need to be
247         kept up-to-date. In order to check that they are up-to-date or not,
248         add an Xcode build step that invokes an external script that performs
249         the checking. If the .xcfilelists are found to be out-of-date, update
250         them, halt the build, and instruct the developer to restart the build
251         with up-to-date files.
252
253         At this time, the checking and regenerating is performed only if the
254         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
255         who want to use this facility can set this variable and test out the
256         checking/regenerating. Once it seems like there are no egregious
257         issues that upset a developer's workflow, we'll unconditionally enable
258         this facility.
259
260         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
261         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
262         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
263         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
264
265 2019-01-25  Keith Rollin  <krollin@apple.com>
266
267         Update Xcode projects with "Apply Configuration to XCFileLists" build target
268         https://bugs.webkit.org/show_bug.cgi?id=193781
269         <rdar://problem/47201153>
270
271         Reviewed by Alex Christensen.
272
273         Part of generating the .xcfilelists used as part of adopting XCBuild
274         includes running `make DerivedSources.make` from a standalone script.
275         It’s important for this invocation to have the same environment as
276         when the actual build invokes `make DerivedSources.make`. If the
277         environments are different, then the two invocations will provide
278         different results. In order to get the same environment in the
279         standalone script, have the script launch xcodebuild targeting the
280         "Apply Configuration to XCFileLists" build target, which will then
281         re-invoke our standalone script. The script is now running again, this
282         time in an environment with all workspace, project, target, xcconfig
283         and other environment variables established.
284
285         The "Apply Configuration to XCFileLists" build target accomplishes
286         this task via a small embedded shell script that consists only of:
287
288             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
289
290         The process that invokes "Apply Configuration to XCFileLists" first
291         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
292         evaluated and exports it into the shell environment. When xcodebuild
293         is invoked, it inherits the value of this variable and can `eval` the
294         contents of that variable. Our external standalone script can then set
295         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
296         of command-line parameters needed to restart itself in the appropriate
297         state.
298
299         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
300         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
301
302 2019-01-25  Alex Christensen  <achristensen@webkit.org>
303
304         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
305         https://bugs.webkit.org/show_bug.cgi?id=193802
306         <rdar://problem/46010580>
307
308         Reviewed by Andy Estes.
309
310         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
311         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
312         (TEST):
313
314 2019-01-25  Daniel Bates  <dabates@apple.com>
315
316         [iOS] uiController.keyDown() does not translate Control modified key
317         https://bugs.webkit.org/show_bug.cgi?id=192898
318
319         Reviewed by Wenson Hsieh.
320
321         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
322         key translation, as applicable. Among other cases, key translation occurs when performing
323         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
324         also makes the behavior of uiController.keyDown() more closely match the behavior of a
325         human pressing down and releasing key(s) using a hardware keyboard.
326
327         * WebKitTestRunner/ios/HIDEventGenerator.h:
328         * WebKitTestRunner/ios/HIDEventGenerator.mm:
329         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
330
331         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
332         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
333         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
334         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
335         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
336         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
337         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
338         (-[HIDEventGenerator longPress:completionBlock:]):
339         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
340         Update code for above renaming.
341
342         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
343         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
344
345         (-[HIDEventGenerator keyDown:]): Added.
346         (-[HIDEventGenerator keyUp:]): Added.
347         (-[HIDEventGenerator keyPress:completionBlock:]):
348         (-[HIDEventGenerator eventDispatchThreadEntry:]):
349         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
350         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
351         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
352         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
353         (WTR::parseModifier): Deleted.
354
355 2019-01-25  Keith Rollin  <krollin@apple.com>
356
357         Complete the implementation of generate-xcfilelists
358         https://bugs.webkit.org/show_bug.cgi?id=193782
359
360         Reviewed by Alex Christensen.
361
362         A preliminary version of generate-xcfilelists was added in r238008.
363         This patch updates that script in order to:
364
365         - Support checking of .xcfilelists
366         - Perform better execution of `make DerivedSources.make` by
367           relaunching generate-xcfilelists under xcodebuild
368         - Support incremental generation and checking of .xcfilelists
369         - Support supplementary .xcfilelists files from WebKitAdditions
370         - Support being wrapped by parallel version of generate-xcfilelists in
371           Internal that adds support for (re)generating WebKit projects in
372           that repo.
373         - Support builds that have been performed in WebKitBuild as well as
374           ~/Library/Developer/code/DerivedData
375         - Increase robustness and debugging facilities.
376
377         * Scripts/generate-xcfilelists:
378
379 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
380
381         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
382         https://bugs.webkit.org/show_bug.cgi?id=193297
383         <rdar://problem/47158841>
384
385         Unreviewed test case fix.
386
387         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
388         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
389
390         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
391         (TEST):
392
393 2019-01-25  Keith Rollin  <krollin@apple.com>
394
395         Update existing .xcfilelists
396         https://bugs.webkit.org/show_bug.cgi?id=193791
397         <rdar://problem/47201706>
398
399         Reviewed by Alex Christensen.
400
401         Many .xcfilelist files were added in r238824 in order to support
402         XCBuild. Update these with recent changes to the set of build files
403         and with the current generate-xcfilelist script.
404
405         * DumpRenderTree/DerivedSources-input.xcfilelist:
406         * DumpRenderTree/DerivedSources-output.xcfilelist:
407         * WebKitTestRunner/DerivedSources-input.xcfilelist:
408         * WebKitTestRunner/DerivedSources-output.xcfilelist:
409
410 2019-01-25  Keith Rollin  <krollin@apple.com>
411
412         Fix missing dependencies in extract-dependencies-from-makefile
413         https://bugs.webkit.org/show_bug.cgi?id=193783
414         <rdar://problem/47201571>
415
416         Reviewed by Alex Christensen.
417
418         The extract-dependencies-from-makefile script generates .xcfilelists
419         for XCBuild by invoking a makefile in --debug mode, parsing the
420         dependency information in the output, and extracting information
421         regarding targets and dependents. However, the way `make` emits this
422         dependency information is not rigorous, and so we need to determine
423         what lines to look for and parse by trial and error. This approach
424         didn't coriginally atch all the information we needed to collect, so
425         update the script to look for the additional lines we now know to look
426         for.
427
428         * Scripts/extract-dependencies-from-makefile:
429         (Parser):
430         (Parser.addTarget):
431         (Parser.addPrereq):
432         (Parser.doParse):
433
434 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
435
436         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
437         https://bugs.webkit.org/show_bug.cgi?id=193297
438         <rdar://problem/47158841>
439
440         Reviewed by Alex Christensen.
441
442         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
443             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
444         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
445         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
446         activating the message used to trigger the callback when it is set.
447
448 2019-01-25  Alex Christensen  <achristensen@webkit.org>
449
450         WKWebView.goBack should reload if there is a safe browsing warning
451         https://bugs.webkit.org/show_bug.cgi?id=193805
452         <rdar://problem/46908216>
453
454         Reviewed by Geoff Garen.
455
456         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
457         (+[Simple3LookupContext sharedLookupContext]):
458         (-[Simple3LookupContext lookUpURL:completionHandler:]):
459         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
460         (TEST):
461
462 2019-01-25  Chris Dumez  <cdumez@apple.com>
463
464         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
465         https://bugs.webkit.org/show_bug.cgi?id=193788
466         <rdar://problem/47531231>
467
468         Reviewed by Alex Christensen.
469
470         Add API test coverage.
471
472         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
473         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
474
475 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
476
477         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
478         https://bugs.webkit.org/show_bug.cgi?id=193771
479
480         Unreviewed infrastructure fix.
481
482         * Scripts/webkitpy/port/darwin.py:
483         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
484
485 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
486
487         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
488
489 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
490
491         Add contributors.json entries for Ling Ho and for a new bot watchers group.
492
493         * Scripts/webkitpy/common/config/contributors.json:
494
495 2019-01-25  Chris Dumez  <cdumez@apple.com>
496
497         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
498         https://bugs.webkit.org/show_bug.cgi?id=193779
499         <rdar://problem/46170903>
500
501         Reviewed by Antti Koivisto.
502
503         Add API test that quickly navigates forward to a previous process without waiting for it to
504         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
505         the process' previous page when reconnecting the it for the forward navigation.
506
507         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
508
509 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
510
511         Need a way for JavaScript (or bundle) code to participate in undo
512         https://bugs.webkit.org/show_bug.cgi?id=190009
513         <rdar://problem/44807048>
514
515         Reviewed by Ryosuke Niwa.
516
517         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
518         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
519
520         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
521         (WTR::UIScriptController::lastUndoLabel const):
522         (WTR::UIScriptController::firstRedoLabel const):
523         (WTR::UIScriptController::platformUndoManager const):
524         * DumpRenderTree/mac/UIScriptControllerMac.mm:
525         (WTR::UIScriptController::lastUndoLabel const):
526         (WTR::UIScriptController::firstRedoLabel const):
527         (WTR::UIScriptController::platformUndoManager const):
528         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
529         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
530         (WTR::UIScriptController::lastUndoLabel const):
531         (WTR::UIScriptController::firstRedoLabel const):
532         * TestRunnerShared/UIScriptContext/UIScriptController.h:
533         * WebKitTestRunner/UIScriptControllerCocoa.mm:
534         (WTR::UIScriptController::lastUndoLabel const):
535         (WTR::UIScriptController::firstRedoLabel const):
536         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
537         (WTR::UIScriptController::platformUndoManager const):
538         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
539         (WTR::UIScriptController::platformUndoManager const):
540
541 2019-01-25  Zalan Bujtas  <zalan@apple.com>
542
543         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
544         https://bugs.webkit.org/show_bug.cgi?id=193824
545
546         Reviewed by Antti Koivisto.
547
548         * LayoutReloaded/misc/LFC-passing-tests.txt:
549
550 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
551
552         Update macOS JSC bot configurations
553         https://bugs.webkit.org/show_bug.cgi?id=193739
554
555         Reviewed by Alexey Proskuryakov.
556
557         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
558         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
559         (BubbleQueueServer): Move JSC EWS to Mojave section.
560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
561         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
562         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
563
564 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
565
566         [Win][WebKitTestRunner] Implement EventSenderProxy
567         https://bugs.webkit.org/show_bug.cgi?id=193755
568
569         Reviewed by Don Olmstead.
570
571         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
572         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
573         (WTR::EventSenderProxy::dispatchMessage):
574         (WTR::EventSenderProxy::EventSenderProxy):
575         (WTR::EventSenderProxy::mouseDown):
576         (WTR::EventSenderProxy::mouseUp):
577         (WTR::EventSenderProxy::mouseMoveTo):
578         (WTR::EventSenderProxy::mouseScrollBy):
579         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
580
581 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
582
583         Unreviewed fix for API test failure after r240437.
584
585         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
586
587         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
588
589 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
590
591         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
592         https://bugs.webkit.org/show_bug.cgi?id=193787
593         <rdar://problem/47497634>
594
595         Reviewed by Alexey Proskuryakov.
596
597         * Scripts/webkitdirs.pm:
598         (iosSimulatorApplicationsPath): Pick from available runtime directories.
599
600 2019-01-24  Truitt Savell  <tsavell@apple.com>
601
602         Unreviewed, rolling out r240446.
603
604         Casued 5 API failures
605
606         Reverted changeset:
607
608         "Activate the WebResourceLoadStatisticsStore in the
609         NetworkProcess and deactivate it in the UIProcess."
610         https://bugs.webkit.org/show_bug.cgi?id=193297
611         https://trac.webkit.org/changeset/240446
612
613 2019-01-24  Zalan Bujtas  <zalan@apple.com>
614
615         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
616         https://bugs.webkit.org/show_bug.cgi?id=193741
617         <rdar://problem/47135030>
618
619         Reviewed by Antti Koivisto and Simon Fraser.
620
621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
622         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
623         (TestWebKitAPI::TEST):
624
625 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
626
627         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
628         https://bugs.webkit.org/show_bug.cgi?id=193297
629         <rdar://problem/47158841>
630
631         Reviewed by Alex Christensen.
632
633         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
634         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
635         activating the message used to trigger the callback when it is set.
636
637 2019-01-24  John Wilander  <wilander@apple.com>
638
639         Add Ad Click Attribution as an internal/experimental feature
640         https://bugs.webkit.org/show_bug.cgi?id=193685
641         <rdar://problem/47450399>
642
643         Reviewed by Brent Fulgham.
644
645         Added test option adClickAttributionEnabled.
646
647         * DumpRenderTree/TestOptions.cpp:
648         (TestOptions::TestOptions):
649         * DumpRenderTree/TestOptions.h:
650         * DumpRenderTree/mac/DumpRenderTree.mm:
651         (setWebPreferencesForTestOptions):
652
653 2019-01-24  Antti Koivisto  <antti@apple.com>
654
655         [PSON] Flash on back navigation on Mac
656         https://bugs.webkit.org/show_bug.cgi?id=193716
657         <rdar://problem/47148458>
658
659         Reviewed by Chris Dumez.
660
661         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
662
663         Closing of the previous page is delayed so waiting for didFinishNavigation is
664         not sufficient to guarantee we have received all the messages. Wait for them.
665
666 2019-01-24  Chris Dumez  <cdumez@apple.com>
667
668         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
669         https://bugs.webkit.org/show_bug.cgi?id=193761
670         <rdar://problem/47456405>
671
672         Reviewed by Alex Christensen.
673
674         Add API test coverage.
675
676         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
677
678 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
679
680         webkitpy: Missing PID in crashlog name should not be fatal
681         https://bugs.webkit.org/show_bug.cgi?id=193771
682
683         If we can't determine the PID of a crashlog, just ignore the crashlog instead
684         of raising an exception.
685
686         Reviewed by Lucas Forschler.
687
688         * Scripts/webkitpy/port/darwin.py:
689         (DarwinPort._merge_crash_logs):
690
691 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
692
693         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
694         https://bugs.webkit.org/show_bug.cgi?id=193746
695
696         Reviewed by Youenn Fablet.
697
698         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
699         so we'd best just not call it.
700
701         * Scripts/webkitpy/w3c/test_exporter.py:
702         (WebPlatformTestExporter.create_branch_with_patch):
703
704 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
705
706         Move FileSystem to WTF
707         https://bugs.webkit.org/show_bug.cgi?id=193602
708
709         Reviewed by Yusuke Suzuki.
710
711         * DumpRenderTree/win/DumpRenderTree.cpp:
712         * TestWebKitAPI/CMakeLists.txt:
713         * TestWebKitAPI/PlatformGTK.cmake:
714         * TestWebKitAPI/PlatformJSCOnly.cmake:
715         * TestWebKitAPI/PlatformPlayStation.cmake:
716         * TestWebKitAPI/PlatformWPE.cmake:
717         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
718         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
719         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
720         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
721         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
722         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
723         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
724         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
725         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
726         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
727
728 2019-01-24  Philippe Normand  <pnormand@igalia.com>
729
730         [WPE] Remove hard dependency on subprocess32 for the API tests
731
732         Rubber-stamped by Carlos Garcia Campos.
733
734         * glib/api_test_runner.py:
735         (TestRunner._run_test_qt): Lazily import subprocess32 and check
736         its presence only when running WPEQt tests.
737
738 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
739
740         [GLIB] Expose JavaScriptCore options in GLib public API
741         https://bugs.webkit.org/show_bug.cgi?id=188742
742
743         Reviewed by Michael Catanzaro.
744
745         Add a test for the new API.
746
747         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
748         (testsJSCOptions):
749         (main):
750
751 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
752
753         [GTK][WPE] Support JPEG 2000 images
754         https://bugs.webkit.org/show_bug.cgi?id=186272
755
756         Reviewed by Žan Doberšek.
757
758         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
759
760         * gtk/jhbuild.modules:
761         * wpe/jhbuild.modules:
762
763 2019-01-23  David Kilzer  <ddkilzer@apple.com>
764
765         check-webkit-style should warn when using soft-linking macros in a header
766         <https://webkit.org/b/193750>
767
768         Reviewed by Darin Adler.
769
770         * Scripts/webkitpy/style/checkers/cpp.py:
771         (check_language): Add softlink/header check by refactoring the
772         softlink/framework check.
773         (CppChecker): Enable softlink/header check by default.
774         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
775         (CppStyleTest.test_softlink_framework): Rename from
776         CppStyleTest.test_softlink() and change test framework name in
777         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
778         files. Set file_name for macros that only appear in headers.
779         (CppStyleTest.test_softlink_header): Add tests for using
780         soft-link macros in headers.
781
782 2019-01-23  Chris Dumez  <cdumez@apple.com>
783
784         Deprecate API to limit the maximum number of WebProcesses
785         https://bugs.webkit.org/show_bug.cgi?id=193725
786         <rdar://problem/47464879>
787
788         Reviewed by Geoff Garen.
789
790         Update existing API tests to stop using deprecated API.
791
792         * MiniBrowser/mac/AppDelegate.m:
793         (defaultConfiguration):
794         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
795         (TestWebKitAPI::TEST):
796         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
797         (TestWebKitAPI::TEST):
798         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
799         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
800         (TEST):
801         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
802         (TEST):
803
804 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
805
806         [ews-app] Rename ews model buildermappings to buildermapping
807         https://bugs.webkit.org/show_bug.cgi?id=193729
808
809         Reviewed by Lucas Forschler.
810
811         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
812         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
813         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
814
815 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
816
817         [ews-app] Rename ews model steps to step
818         https://bugs.webkit.org/show_bug.cgi?id=193697
819
820         Reviewed by Lucas Forschler.
821
822         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
823         (Step): Renamed Steps to Step.
824
825 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
826
827         Clean up IndexedDB files between tests
828         https://bugs.webkit.org/show_bug.cgi?id=192796
829         <rdar://problem/46824999>
830
831         Reviewed by Geoffrey Garen.
832
833         * DumpRenderTree/mac/DumpRenderTree.mm:
834         (runTest):
835         * WebKitTestRunner/TestController.cpp:
836         (WTR::TestController::resetStateToConsistentValues):
837         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
838         (WTR::RemoveAllIndexedDatabasesCallback):
839         (WTR::TestController::ClearIndexedDatabases):
840         * WebKitTestRunner/TestController.h:
841         * WebKitTestRunner/TestInvocation.cpp:
842         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
843
844 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
845
846         [ews-app] Rename ews model Builds to Build
847         https://bugs.webkit.org/show_bug.cgi?id=193695
848
849         Reviewed by Lucas Forschler.
850
851         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
852         (Build): Renamed Builds to Build.
853
854 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
855
856         webkitpy: Wait longer when launching WebKitTestRunner
857         https://bugs.webkit.org/show_bug.cgi?id=193734
858
859         Reviewed by Aakash Jain.
860
861         * Scripts/webkitpy/port/simulator_process.py:
862         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
863
864 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
865
866         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
867         https://bugs.webkit.org/show_bug.cgi?id=193182
868         <rdar://problem/47452154>
869
870         Reviewed by Tim Horton.
871
872         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
873         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
874         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
875
876         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
877         preventing later tests from recognizing gestures.
878
879         * WebKitTestRunner/ios/TestControllerIOS.mm:
880         (WTR::TestController::platformResetStateToConsistentValues):
881
882         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
883
884 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
885
886         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
887         https://bugs.webkit.org/show_bug.cgi?id=193722
888         <rdar://problem/47481475>
889
890         Reviewed by Lucas Forschler.
891
892         iPhone and iPad ports should both use the iOS config.
893
894         * Scripts/webkitpy/port/ios_simulator.py:
895         (IPhoneSimulatorPort.__init__):
896         (IPadSimulatorPort.__init__):
897
898 2019-01-23  Rob Buis  <rbuis@igalia.com>
899
900         Update MIME type parser
901         https://bugs.webkit.org/show_bug.cgi?id=180526
902
903         Reviewed by Frédéric Wang.
904
905         Add unit tests for both parse modes of ParsedContentType.
906
907         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
908         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
909         (TestWebKitAPI::TEST):
910
911 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
912
913         [ews-app] fetch loop should not stop on network issues
914         https://bugs.webkit.org/show_bug.cgi?id=193666
915
916         Reviewed by Lucas Forschler.
917
918         * BuildSlaveSupport/ews-app/ews/fetcher.py:
919         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
920
921 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
922
923         [iOS] Multiple WKWebViewAutofillTests are flaky failures
924         https://bugs.webkit.org/show_bug.cgi?id=189165
925         <rdar://problem/47433765>
926
927         Reviewed by Tim Horton.
928
929         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
930         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
931         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
932         process in sufficient to ensure that any previous action that blurred the focused element in the web process
933         would make its way to the UI process by the time the layer tree commit is finished.
934
935         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
936         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
937         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
938         will fail because it asks for -_autofillContext too early.
939
940         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
941         is handled in the UI process.
942
943         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
944
945         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
946         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
947         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
948         input session.
949
950         (-[AutofillTestView textInputHasAutofillContext]):
951
952         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
953
954         * TestWebKitAPI/cocoa/TestWKWebView.h:
955         * TestWebKitAPI/cocoa/TestWKWebView.mm:
956         (nextInputSessionChangeCount):
957
958         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
959         This includes changing the focused element from one to another.
960
961         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
962         (-[TestWKWebView didStartFormControlInteraction]):
963         (-[TestWKWebView didEndFormControlInteraction]):
964         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
965
966         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
967         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
968         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
969         that doesn't require an input session to one that doesn't.
970
971 2019-01-22  David Kilzer  <ddkilzer@apple.com>
972
973         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
974         <https://webkit.org/b/193676>
975
976         Reviewed by Alexey Proskuryakov.
977
978         * Scripts/webkitpy/style/checkers/cpp.py:
979         (check_member_initialization_list):
980         - Don't report missing whitespace around colon if the colon at
981           the start of the line is formatted correctly.
982         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
983         (WebKitStyleTest.test_member_initialization_list):
984         - Add a test for a missing permutation of existing tests.
985         - Add a test this false-positive.
986         - Add blank lines between subtests to make them easier to read.
987
988 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
989
990         [build.webkit.org] Unit-test failure after r237113
991         https://bugs.webkit.org/show_bug.cgi?id=193669
992
993         Reviewed by Michael Catanzaro.
994
995         * BuildSlaveSupport/build.webkit.org-config/factories.py:
996         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
997         multiple or zero flags.
998
999 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
1000
1001         Cache bytecode to disk
1002         https://bugs.webkit.org/show_bug.cgi?id=192782
1003         <rdar://problem/46084932>
1004
1005         Reviewed by Keith Miller.
1006
1007         Add test helper to execute bytecode-cache tests: it executes each test
1008         twice, the first with JSC_diskCachePath set to a temporary directory
1009         and second with JSC_forceDiskCache=true (in addition to the cache path)
1010         to guarantee that only the disk cache is being used and no new
1011         UnlinkedCodeBlocks are being created.
1012
1013         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
1014         * Scripts/run-jsc-stress-tests:
1015
1016 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
1017
1018         [css-logical] Implement flow-relative margin, padding and border shorthands
1019         https://bugs.webkit.org/show_bug.cgi?id=188697
1020
1021         Reviewed by Simon Fraser and Antti Koivisto.
1022
1023         * DumpRenderTree/TestOptions.cpp:
1024         (TestOptions::TestOptions):
1025         * DumpRenderTree/TestOptions.h:
1026         * DumpRenderTree/mac/DumpRenderTree.mm:
1027         (setWebPreferencesForTestOptions):
1028         Allow tests to enable the CSSLogicalEnabled flag in WK1.
1029
1030         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1031         (JSONCSSPropertiesChecker.check_codegen_properties):
1032         Allow CSS property definitions to have a 'runtime-flag' parameter which
1033         disables the property when the specified runtime flag is disabled.
1034
1035 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1036
1037         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
1038         https://bugs.webkit.org/show_bug.cgi?id=193643
1039
1040         Reviewed by Michael Catanzaro.
1041
1042         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
1043         * wpe/jhbuild.modules: Ditto.
1044
1045 2019-01-21  Zalan Bujtas  <zalan@apple.com>
1046
1047         [LFC][Floats] Take float top position into account when computing containing block height.
1048         https://bugs.webkit.org/show_bug.cgi?id=193655
1049
1050         Reviewed by Antti Koivisto.
1051
1052         * LayoutReloaded/misc/LFC-passing-tests.txt:
1053
1054 2019-01-21  David Kilzer  <ddkilzer@apple.com>
1055
1056         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
1057         <https://webkit.org/b/193645>
1058         <rdar://problem/47421574>
1059
1060         Reviewed by Alex Christensen.
1061
1062         - Now checks for local soft-linking of all frameworks that have
1063           their own *SoftLinking.{cpp,h,mm} files.
1064         - Changes softlink/uikit warning to softlink/framework.
1065
1066         * Scripts/webkitpy/style/checkers/cpp.py:
1067         (check_language):
1068         (CppChecker):
1069         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1070         (CppStyleTest):
1071
1072 2019-01-20  Saam Barati  <sbarati@apple.com>
1073
1074         Rollout r240210: It broke tests on iOS
1075         https://bugs.webkit.org/show_bug.cgi?id=193640
1076
1077         Unreviewed.
1078
1079         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
1080         * Scripts/run-jsc-stress-tests:
1081
1082 2019-01-20  chris fleizach  <cfleizach@apple.com>
1083
1084         AX: Support returning relative frames for accessibility
1085         https://bugs.webkit.org/show_bug.cgi?id=193414
1086         <rdar://problem/47268501>
1087
1088         Reviewed by Zalan Bujtas.
1089
1090         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1091         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1092         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1093         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1094         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1095         (WTR::attributesOfElement):
1096         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1097
1098 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
1099
1100         Unreviewed, add my new email address
1101
1102         * Scripts/webkitpy/common/config/contributors.json:
1103
1104 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1105
1106         [LFC][BFC] <body>'s overflow property value is propagated to viewport
1107         https://bugs.webkit.org/show_bug.cgi?id=193617
1108
1109         Reviewed by Antti Koivisto.
1110
1111         * LayoutReloaded/misc/LFC-passing-tests.txt:
1112
1113 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1114
1115         Unreviewed, rolling out r240209.
1116
1117         Broke GTK/WPE injected bundle
1118
1119         Reverted changeset:
1120
1121         "AX: Support returning relative frames for accessibility"
1122         https://bugs.webkit.org/show_bug.cgi?id=193414
1123         https://trac.webkit.org/changeset/240209
1124
1125 2019-01-12  Dan Bernstein  <mitz@apple.com>
1126
1127         [Cocoa] Avoid importing directly from subumbrella frameworks
1128         https://bugs.webkit.org/show_bug.cgi?id=186016
1129         <rdar://problem/40591038>
1130
1131         Reviewed by Sam Weinig.
1132
1133         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1134           LaunchServices header.
1135         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1136           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1137         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1138           when using SDKs earlier than 10.13.
1139         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1140           and OTHER_CPLUSPLUSFLAGS.
1141         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1142           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1143         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1144           LaunchServices header.
1145
1146 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
1147
1148         Cache bytecode to disk
1149         https://bugs.webkit.org/show_bug.cgi?id=192782
1150         <rdar://problem/46084932>
1151
1152         Reviewed by Keith Miller.
1153
1154         Add test helper to execute bytecode-cache tests: it executes each test
1155         twice, the first with JSC_diskCachePath set to a temporary directory
1156         and second with JSC_forceDiskCache=true (in addition to the cache path)
1157         to guarantee that only the disk cache is being used and no new
1158         UnlinkedCodeBlocks are being created.
1159
1160         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
1161         * Scripts/run-jsc-stress-tests:
1162
1163 2019-01-20  chris fleizach  <cfleizach@apple.com>
1164
1165         AX: Support returning relative frames for accessibility
1166         https://bugs.webkit.org/show_bug.cgi?id=193414
1167         <rdar://problem/47268501>
1168
1169         Reviewed by Zalan Bujtas.
1170
1171         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1172         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1173         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1174         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1175         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1176         (WTR::attributesOfElement):
1177         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1178
1179 2019-01-20  Antoine Quint  <graouts@apple.com>
1180
1181         Add a POINTER_EVENTS feature flag
1182         https://bugs.webkit.org/show_bug.cgi?id=193577
1183         <rdar://problem/47408511>
1184
1185         Unreviewed. Also enable Pointer Events for iosmac.
1186
1187         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1188
1189 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1190
1191         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
1192         https://bugs.webkit.org/show_bug.cgi?id=193613
1193
1194         Reviewed by Antti Koivisto.
1195
1196         * LayoutReloaded/misc/LFC-passing-tests.txt:
1197
1198 2019-01-19  Antoine Quint  <graouts@apple.com>
1199
1200         Add a POINTER_EVENTS feature flag
1201         https://bugs.webkit.org/show_bug.cgi?id=193577
1202
1203         Reviewed by Dean Jackson.
1204
1205         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1206
1207 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
1208
1209         Disable the run-jsc-stress-test remote host key check [second round].
1210         https://bugs.webkit.org/show_bug.cgi?id=192988
1211
1212         Reviewed by Dewei Zhu.
1213
1214         * Scripts/run-jsc-stress-tests:
1215
1216 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1217
1218         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
1219         https://bugs.webkit.org/show_bug.cgi?id=193597
1220
1221         Reviewed by Lucas Forschler.
1222
1223         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1224
1225 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1226
1227         [build.webkit.org] api tests failures are incorrectly named as unit test failures
1228         https://bugs.webkit.org/show_bug.cgi?id=193595
1229
1230         Reviewed by Lucas Forschler.
1231
1232         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
1233         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
1234         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
1235
1236 2019-01-18  Chris Dumez  <cdumez@apple.com>
1237
1238         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
1239         https://bugs.webkit.org/show_bug.cgi?id=193588
1240         <rdar://problem/47131566>
1241
1242         Reviewed by Alex Christensen.
1243
1244         Add layout test coverage.
1245
1246         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1247
1248 2019-01-18  Jer Noble  <jer.noble@apple.com>
1249
1250         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1251         https://bugs.webkit.org/show_bug.cgi?id=189553
1252
1253         Reviewed by Tim Horton.
1254
1255         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1256
1257         * ContentExtensionTester/Configurations/Base.xcconfig:
1258         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1259         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1260         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1261         * ImageDiff/cg/Configurations/Base.xcconfig:
1262         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1263         * MiniBrowser/Configurations/Base.xcconfig:
1264         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1265         * MobileMiniBrowser/Configurations/Base.xcconfig:
1266         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1267         * Scripts/webkitpy/style/checker.py:
1268         (_all_categories):
1269         (FileType):
1270         (CheckerDispatcher._file_type):
1271         (CheckerDispatcher._create_checker):
1272         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1273         (SDKVariantChecker):
1274         (SDKVariantChecker.__init__):
1275         (SDKVariantChecker.check):
1276         * TestWebKitAPI/Configurations/Base.xcconfig:
1277         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1278         * WebEditingTester/Configurations/Base.xcconfig:
1279         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1280         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1281         * WebKitTestRunner/Configurations/Base.xcconfig:
1282         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1283         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1284         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1285
1286 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1287
1288         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1289         <https://webkit.org/b/193568>
1290         <rdar://problem/47381130>
1291
1292         Reviewed by Alex Christensen.
1293
1294         Make sure no one re-introduces UIKit soft-linking by adding a
1295         style rule.
1296
1297         * Scripts/webkitpy/style/checkers/cpp.py:
1298         (check_language): Add softlink/uikit check.
1299         (CppChecker): Enable softlink/uikit check.
1300         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1301         (CppStyleTest): Add test for softlink/uikit.
1302
1303 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1304
1305         [GTK] install-dependencies tool looks for libunistring-dev for dnf
1306         https://bugs.webkit.org/show_bug.cgi?id=193584
1307
1308         Change "-dev" to "-devel".
1309
1310         Reviewed by Michael Catanzaro.
1311
1312         * gtk/install-dependencies:
1313
1314 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1315
1316         webkitpy: Add iPhone and iPad ports
1317         https://bugs.webkit.org/show_bug.cgi?id=193537
1318         <rdar://problem/47353390>
1319
1320         Reviewed by Lucas Forschler.
1321
1322         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
1323         ports. Note that this separation is optional, the --ios-simulator command remains.
1324
1325         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1326         (RunTest.test_device_type_test_division): Drive-by fix.
1327         (RunTest.test_device_type_specific_listing): Ditto.
1328         (RunTest.test_ipad_test_division):
1329         (RunTest):
1330         (RunTest.test_ipad_listing):
1331         * Scripts/webkitpy/port/factory.py:
1332         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
1333         (PortFactory):
1334         * Scripts/webkitpy/port/ios_simulator.py:
1335         (IPhoneSimulatorPort):
1336         (IPadSimulatorPort):
1337
1338 2019-01-18  Chris Dumez  <cdumez@apple.com>
1339
1340         Regression(PSON) Scroll position is not always restored properly when navigating back
1341         https://bugs.webkit.org/show_bug.cgi?id=193578
1342         <rdar://problem/47386331>
1343
1344         Reviewed by Tim Horton.
1345
1346         Add API test coverage.
1347
1348         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1349
1350 2019-01-18  Youenn Fablet  <youenn@apple.com>
1351
1352         Add a new SPI to request for cache storage quota increase
1353         https://bugs.webkit.org/show_bug.cgi?id=193323
1354
1355         Reviewed by Alex Christensen.
1356
1357         Implement WebsiteDataStore quota delegate to handle quota requests.
1358         By default, do not update quota.
1359         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
1360
1361         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1362         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1363         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
1364         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1365         * WebKitTestRunner/TestController.cpp:
1366         (WTR::TestController::allowCacheStorageQuotaIncrease):
1367         * WebKitTestRunner/TestController.h:
1368         * WebKitTestRunner/TestInvocation.cpp:
1369         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1370         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1371         (-[CacheStorageQuotaManager init]):
1372         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1373         (WTR::initializeWebViewConfiguration):
1374         (WTR::TestController::cocoaResetStateToConsistentValues):
1375         (WTR::TestController::allowCacheStorageQuotaIncrease):
1376
1377 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1378
1379         [ews-build] Pass owner to the triggered builds
1380         https://bugs.webkit.org/show_bug.cgi?id=193574
1381
1382         Reviewed by Lucas Forschler.
1383
1384         * BuildSlaveSupport/ews-build/factories.py:
1385         (BuildFactory.propertiesToPassToTriggers):
1386
1387 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1388
1389         [ews-app] Send patch author as a build property
1390         https://bugs.webkit.org/show_bug.cgi?id=193560
1391
1392         Reviewed by Lucas Forschler.
1393
1394         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1395         (BugzillaPatchFetcher.fetch):
1396
1397 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1398
1399         webkitpy: Implement device type specific expected results (Follow-up fix)
1400         https://bugs.webkit.org/show_bug.cgi?id=192162
1401         <rdar://problem/46345449>
1402
1403         Unreviewed infrastructure fix.
1404
1405         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1406         (Manager.run): Don't boot a device if no tests are available to run on it.
1407
1408 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1409
1410         webkitpy: Implement device type specific expected results (Follow-up fix)
1411         https://bugs.webkit.org/show_bug.cgi?id=192162
1412         <rdar://problem/46345449>
1413
1414         Unreviewed infrastructure fix.
1415
1416         * Scripts/webkitpy/api_tests/manager.py:
1417         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
1418
1419 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1420
1421         webkitpy: Implement device type specific expected results (Part 2)
1422         https://bugs.webkit.org/show_bug.cgi?id=192162
1423         <rdar://problem/46345449>
1424
1425         Rubber-stamped by Aakash Jain.
1426
1427         This change uses device_type to select a different set of TestExpectation files based on the type of device running
1428         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
1429         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
1430
1431         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1432         (LayoutTestFinder.find_tests): Pass device_type through.
1433         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
1434         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
1435         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1436         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
1437         (Manager._collect_tests): Pass device type to test finder.
1438         (Manager._needs_web_platform_test):
1439         (Manager._prepare_lists): Index _expectations by device type.
1440         (Manager._test_input_for_file):
1441         (Manager._test_is_slow): Ditto.
1442         (Manager._test_should_dump_jsconsolelog_in_stderr):
1443         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
1444         (Manager._get_test_inputs):
1445         (Manager._update_worker_count):
1446         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
1447         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
1448         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
1449         the one which runs the test.
1450         (Manager._run_test_subset):
1451         (Manager._run_tests): Index _expectations by current_device_type.
1452         (Manager._print_expectation_line_for_test): Ditto.
1453         (Manager._print_expectations_for_subset): Ditto.
1454         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
1455         Unlike run, this function will behave the same regardless of what devices are available.
1456         (Manager._custom_device_for_test): Deleted.
1457         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1458         (ManagerTest.test_uses_custom_device): Deleted.
1459         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
1460         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1461         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
1462         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
1463         all of the expectations.
1464         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1465         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
1466         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1467         (TestExpectations.__init__): Allow device_type to be passed through.
1468         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
1469         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
1470         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1471         (summarize_results):
1472         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1473         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
1474         a test ran with, one must check all expectations to find the first non-skip expectation.
1475         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1476         (RunTest.test_device_type_test_division):
1477         (RunTest):
1478         (RunTest.test_device_type_specific_listing):
1479         * Scripts/webkitpy/port/base.py:
1480         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
1481         (Port.supported_device_types): The result of this function will change based on what devices are available.
1482         * Scripts/webkitpy/port/device_port.py:
1483         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1484         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1485         can be used.
1486         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1487         any, or the DEFAULT_DEVICE_TYPES of the port.
1488         * Scripts/webkitpy/port/ios.py:
1489         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1490         * Scripts/webkitpy/port/ios_simulator.py:
1491         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1492         * Scripts/webkitpy/port/watch.py:
1493         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1494         * Scripts/webkitpy/port/watch_simulator.py:
1495         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1496         * Scripts/webkitpy/xcode/device_type.py:
1497         (DeviceType):
1498         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1499
1500 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1501
1502         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1503         https://bugs.webkit.org/show_bug.cgi?id=193575
1504
1505         Reviewed by Michael Catanzaro.
1506
1507         Allow the script to run without explicit port argument because
1508         it's specific to the WPE port anyway.
1509
1510         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1511         and simplify the rest of the code accordingly.
1512
1513 2019-01-18  Charlie Turner  <cturner@igalia.com>
1514
1515         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1516         https://bugs.webkit.org/show_bug.cgi?id=192229
1517
1518         Reviewed by Xabier Rodriguez-Calvar.
1519
1520         * MiniBrowser/wpe/main.cpp:
1521         (main): Enable encrypted-media by default.
1522
1523 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1524
1525         [Flatpak] Missing KeyboardInterrupt exception handler
1526         https://bugs.webkit.org/show_bug.cgi?id=193570
1527
1528         Reviewed by Michael Catanzaro.
1529
1530         * flatpak/flatpakutils.py:
1531         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1532
1533 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1534
1535         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1536         https://bugs.webkit.org/show_bug.cgi?id=193564
1537
1538         Reviewed by Antti Koivisto.
1539
1540         * LayoutReloaded/misc/LFC-passing-tests.txt:
1541
1542 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1543
1544         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1545         https://bugs.webkit.org/show_bug.cgi?id=193562
1546
1547         Reviewed by Antti Koivisto.
1548
1549         * LayoutReloaded/misc/LFC-passing-tests.txt:
1550
1551 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1552
1553         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1554         https://bugs.webkit.org/show_bug.cgi?id=193555
1555
1556         Reviewed by Antti Koivisto.
1557
1558         * LayoutReloaded/misc/LFC-passing-tests.txt:
1559
1560 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1561
1562         [WPE] Add Qt extension
1563         https://bugs.webkit.org/show_bug.cgi?id=191464
1564
1565         Reviewed by Carlos Garcia Campos.
1566
1567         MiniBrowser and API tests for the WPE Qt API. To run the
1568         MiniBrowser a new script is introduced. Example invocation:
1569
1570         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1571
1572         Also note-worthy is the introduction of the python2-subprocess32
1573         dependency to run the GLib API tests.
1574
1575         * MiniBrowser/wpe/CMakeLists.txt:
1576         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1577         * MiniBrowser/wpe/qt/main.cpp: Added.
1578         (main):
1579         * MiniBrowser/wpe/qt/main.qml: Added.
1580         * MiniBrowser/wpe/qt/qml.qrc: Added.
1581         * Scripts/run-gtk-tests:
1582         (GtkTestRunner.is_google_test):
1583         (GtkTestRunner):
1584         (GtkTestRunner.is_qt_test):
1585         * Scripts/run-qt-wpe-minibrowser: Added.
1586         * Scripts/run-wpe-tests:
1587         (WPETestRunner):
1588         (WPETestRunner.is_google_test):
1589         (WPETestRunner.is_qt_test):
1590         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1591         (TestLoad::main):
1592         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1593         (TestLoadHtml::main):
1594         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1595         (TestLoadRequest::main):
1596         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1597         (TestRunJavaScript::main):
1598         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1599         (waitForSignal):
1600         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1601         (LoadSpy::LoadSpy):
1602         (LoadSpy::~LoadSpy):
1603         (LoadSpy::onLoadingChanged):
1604         (LoadStartedCatcher::LoadStartedCatcher):
1605         (LoadStartedCatcher::~LoadStartedCatcher):
1606         (LoadStartedCatcher::onLoadingChanged):
1607         (waitForLoadSucceeded):
1608         (waitForLoadFailed):
1609         * TestWebKitAPI/glib/CMakeLists.txt:
1610         * flatpak/flatpakutils.py:
1611         (WebkitFlatpak.load_from_args):
1612         (WebkitFlatpak.__init__):
1613         (WebkitFlatpak.clean_args):
1614         (WebkitFlatpak.run_in_sandbox):
1615         * flatpak/org.webkit.CommonModules.yaml:
1616         * flatpak/org.webkit.WPE.yaml:
1617         * flatpak/org.webkit.WPEModules.yaml:
1618         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1619         * flatpak/org.webkit.WebKit.yaml:
1620         * glib/api_test_runner.py:
1621         (TestRunner._run_test_qt):
1622         (TestRunner.is_qt_test):
1623         (TestRunner._run_test):
1624
1625 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1626
1627         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1628         https://bugs.webkit.org/show_bug.cgi?id=193494
1629         <rdar://problem/46859627>
1630
1631         Reviewed by Simon Fraser and Tim Horton.
1632
1633         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1634         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1635
1636         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1637         (WTR::UIScriptController::contentOffsetX const):
1638         (WTR::UIScriptController::contentOffsetY const):
1639         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1640         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1641         (WTR::UIScriptController::contentOffsetX const):
1642         (WTR::UIScriptController::contentOffsetY const):
1643         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1644
1645         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1646
1647         * WebKitTestRunner/TestController.cpp:
1648         (WTR::updateTestOptionsFromTestHeader):
1649         * WebKitTestRunner/TestOptions.h:
1650         (WTR::TestOptions::hasSameInitializationOptions const):
1651         * WebKitTestRunner/ios/TestControllerIOS.mm:
1652         (WTR::TestController::platformResetStateToConsistentValues):
1653         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1654         (WTR::UIScriptController::contentOffsetX const):
1655         (WTR::UIScriptController::contentOffsetY const):
1656
1657 2019-01-17  Truitt Savell  <tsavell@apple.com>
1658
1659         Unreviewed, rolling out r240124.
1660
1661         This commit broke an internal build.
1662
1663         Reverted changeset:
1664
1665         "SDK_VARIANT build destinations should be separate from non-
1666         SDK_VARIANT builds"
1667         https://bugs.webkit.org/show_bug.cgi?id=189553
1668         https://trac.webkit.org/changeset/240124
1669
1670 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1671
1672         Fix string concatenation API test after r239920
1673         https://bugs.webkit.org/show_bug.cgi?id=193551
1674         <rdar://problem/47359304>
1675
1676         Reviewed by Youenn Fablet.
1677
1678         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1679         (TestWebKitAPI::TEST):
1680         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1681         in WebKit's build configuration like it apparently is on Linux.
1682
1683 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1684
1685         [ews-build] validate-patch should handle the case when bug_id is None
1686         https://bugs.webkit.org/show_bug.cgi?id=193547
1687
1688         Reviewed by Lucas Forschler.
1689
1690         * BuildSlaveSupport/ews-build/steps.py:
1691         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1692         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1693
1694 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1695
1696         [ews-build] Add patch author information in build
1697         https://bugs.webkit.org/show_bug.cgi?id=193465
1698
1699         Reviewed by Lucas Forschler.
1700
1701         * BuildSlaveSupport/ews-build/steps.py:
1702         (ValidatePatch._is_patch_obsolete):
1703
1704 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1705
1706         [ews-build] Pass bug_id to the triggered builds
1707         https://bugs.webkit.org/show_bug.cgi?id=193548
1708
1709         Reviewed by Lucas Forschler.
1710
1711         * BuildSlaveSupport/ews-build/factories.py:
1712         (BuildFactory.propertiesToPassToTriggers):
1713
1714 2019-01-17  Jer Noble  <jer.noble@apple.com>
1715
1716         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1717         https://bugs.webkit.org/show_bug.cgi?id=189553
1718
1719         Reviewed by Tim Horton.
1720
1721         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1722
1723         * ContentExtensionTester/Configurations/Base.xcconfig:
1724         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1725         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1726         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1727         * ImageDiff/cg/Configurations/Base.xcconfig:
1728         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1729         * MiniBrowser/Configurations/Base.xcconfig:
1730         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1731         * MobileMiniBrowser/Configurations/Base.xcconfig:
1732         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1733         * Scripts/webkitpy/style/checker.py:
1734         (_all_categories):
1735         (FileType):
1736         (CheckerDispatcher._file_type):
1737         (CheckerDispatcher._create_checker):
1738         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1739         (SDKVariantChecker):
1740         (SDKVariantChecker.__init__):
1741         (SDKVariantChecker.check):
1742         * TestWebKitAPI/Configurations/Base.xcconfig:
1743         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1744         * WebEditingTester/Configurations/Base.xcconfig:
1745         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1746         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1747         * WebKitTestRunner/Configurations/Base.xcconfig:
1748         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1749         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1750         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1751
1752 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1753
1754         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1755         https://bugs.webkit.org/show_bug.cgi?id=193534
1756
1757         Reviewed by Antti Koivisto.
1758
1759         * LayoutReloaded/misc/LFC-passing-tests.txt:
1760
1761 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1762
1763         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1764         https://bugs.webkit.org/show_bug.cgi?id=193528
1765
1766         Reviewed by Antti Koivisto.
1767
1768         * LayoutReloaded/misc/LFC-passing-tests.txt:
1769
1770 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1771
1772         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1773         https://bugs.webkit.org/show_bug.cgi?id=193520
1774
1775         Reviewed by Antti Koivisto.
1776
1777         * LayoutReloaded/misc/LFC-passing-tests.txt:
1778
1779 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1780
1781         [ews-build] unapply-patch step should not update source
1782         https://bugs.webkit.org/show_bug.cgi?id=193234
1783
1784         Reviewed by Lucas Forschler.
1785
1786         * BuildSlaveSupport/ews-build/steps.py:
1787         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1788         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1789
1790 2019-01-16  Youenn Fablet  <youenn@apple.com>
1791
1792         Add a new SPI for controlling getUserMedia
1793         https://bugs.webkit.org/show_bug.cgi?id=192793
1794
1795         Reviewed by Eric Carlson.
1796
1797         * MiniBrowser/mac/WK2BrowserWindowController.m:
1798         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1799         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1800         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1801         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1802         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1803         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1804         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1805         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1806         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1807         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1808         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1809         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1810         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1811         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1812
1813 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1814
1815         [LFC][BFC] Inflow non-replaced used width should not be negative.
1816         https://bugs.webkit.org/show_bug.cgi?id=193495
1817
1818         Reviewed by Antti Koivisto.
1819
1820         * LayoutReloaded/misc/LFC-passing-tests.txt:
1821
1822 2019-01-16  Chris Dumez  <cdumez@apple.com>
1823
1824         Regression(PSON) View becomes blank after click a cross-site download link
1825         https://bugs.webkit.org/show_bug.cgi?id=193361
1826         <rdar://problem/47099573>
1827
1828         Reviewed by Geoffrey Garen.
1829
1830         Add API test coverage.
1831
1832         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1833         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1834
1835 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1836
1837         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1838         https://bugs.webkit.org/show_bug.cgi?id=193470
1839
1840         Reviewed by Antti Koivisto.
1841
1842         * LayoutReloaded/misc/LFC-passing-tests.txt:
1843
1844 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1845
1846         [LFC] Adjust margin box verification.
1847         https://bugs.webkit.org/show_bug.cgi?id=193482
1848
1849         Reviewed by Antti Koivisto.
1850
1851         * LayoutReloaded/misc/LFC-passing-tests.txt:
1852
1853 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1854
1855         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1856         https://bugs.webkit.org/show_bug.cgi?id=193451
1857
1858         Reviewed by Geoffrey Garen.
1859
1860         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1861         (TEST):
1862         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1863         (runWebsiteDataStoreCustomPaths):
1864
1865 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1866
1867         webkitpy: Support boolean simctl isAvailable
1868         https://bugs.webkit.org/show_bug.cgi?id=193472
1869         <rdar://problem/47296150>
1870
1871         Reviewed by Ryosuke Niwa.
1872
1873         * Scripts/webkitpy/xcode/simulated_device.py:
1874         (SimulatedDeviceManager._create_runtimes):
1875         (SimulatedDeviceManager._create_device_with_runtime):
1876
1877 2019-01-15  Chris Dumez  <cdumez@apple.com>
1878
1879         Unreviewed, rolling out r239993, r239995, r239997, and
1880         r239999.
1881
1882         Caused assertions under
1883         ViewGestureController::disconnectFromProcess()
1884
1885         Reverted changesets:
1886
1887         "Regression(PSON) View becomes blank after click a cross-site
1888         download link"
1889         https://bugs.webkit.org/show_bug.cgi?id=193361
1890         https://trac.webkit.org/changeset/239993
1891
1892         "Unreviewed iOS build fix after r239993."
1893         https://trac.webkit.org/changeset/239995
1894
1895         "Fix iOS build after r239993"
1896         https://bugs.webkit.org/show_bug.cgi?id=193361
1897         https://trac.webkit.org/changeset/239997
1898
1899         "Unreviewed, revert part of r239997 as it is not needed to fix
1900         the build."
1901         https://trac.webkit.org/changeset/239999
1902
1903 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1904
1905         Cannot tab out of WKWebView on macOS
1906         https://bugs.webkit.org/show_bug.cgi?id=161448
1907         <rdar://problem/28100085>
1908
1909         Reviewed by Dean Jackson.
1910
1911         Add a test that tabbing into and out of WKWebView works correctly.
1912
1913         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1914         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1915         (WebKit2_CommandBackForwardTest::SetUp):
1916         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1917         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1918         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1919         (-[FocusableView canBecomeKeyView]):
1920         (TEST):
1921         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1922         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1923         (-[OffscreenWindow initWithSize:]):
1924         (-[OffscreenWindow isKeyWindow]):
1925         (-[OffscreenWindow isVisible]):
1926         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1927         (TestWebKitAPI::PlatformWebView::initialize):
1928         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1929         (-[ActiveOffscreenWindow isVisible]): Deleted.
1930         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1931
1932 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1933
1934         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1935         https://bugs.webkit.org/show_bug.cgi?id=193459
1936
1937         Reviewed by Mark Lam.
1938
1939         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1940         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1941
1942 2019-01-15  Chris Dumez  <cdumez@apple.com>
1943
1944         Regression(PSON) View becomes blank after click a cross-site download link
1945         https://bugs.webkit.org/show_bug.cgi?id=193361
1946         <rdar://problem/47099573>
1947
1948         Reviewed by Geoff Garen.
1949
1950         Add API test coverage.
1951
1952         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1953         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1954
1955 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1956
1957         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
1958         https://bugs.webkit.org/show_bug.cgi?id=193448
1959
1960         Reviewed by Antti Koivisto.
1961
1962         * LayoutReloaded/misc/LFC-passing-tests.txt:
1963
1964 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1965
1966         webkitpy: Implement device type specific expected results (Part 1)
1967         https://bugs.webkit.org/show_bug.cgi?id=192162
1968
1969         Reviewed by Lucas Forschler.
1970
1971         Device type specific expected results covers two related ideas. The first (covered by this change)
1972         is where to search for -expected.* files. The second is which tests to run based on the
1973         TestExpectations.txt file.
1974
1975         After this change, the baseline search path will be determined by the type of device running a
1976         test. Device type will be passed into any function which picks a file based on the baseline search
1977         path.
1978
1979         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1980         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
1981         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1982         (Manager.run): Print baseline search path for each round of devices.
1983         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1984         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
1985         (SingleTestRunner._expected_driver_output): Ditto.
1986         (SingleTestRunner._driver_input): Ditto.
1987         * Scripts/webkitpy/layout_tests/views/printing.py:
1988         (Printer.print_config): Move printing of baseline search path to a separate function.
1989         (Printer.print_baseline_search_path): Moved from Printer.print_config.
1990         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1991         (Testprinter.test_print_config):
1992         (Testprinter.test_print_baseline_search_path):
1993         * Scripts/webkitpy/port/base.py:
1994         (Port.baseline_search_path): Pass device_type through.
1995         (Port._expected_baselines_for_suffixes): Ditto.
1996         (Port.expected_baselines): Ditto.
1997         (Port.expected_filename): Ditto.
1998         (Port.expected_checksum): Ditto.
1999         (Port.expected_image): Ditto.
2000         (Port.expected_audio): Ditto.
2001         (Port.expected_text): Ditto.
2002         (Port.reference_files): Ditto.
2003         (Port.tests): Ditto.
2004         (Port._expanded_paths): Ditto.
2005         (Port.skipped_layout_tests): Ditto.
2006         (Port.expectations_dict): Ditto.
2007         (Port._port_specific_expectations_files): Ditto.
2008         (Port.expectations_files): Ditto.
2009         (Port.test_search_path): Ditto.
2010         (Port._tests_for_other_platforms): Ditto.
2011         * Scripts/webkitpy/port/base_unittest.py:
2012         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
2013         (PortTest.test_nonexistant_expectations): Ditto.
2014         (test_ref_tests_platform_directory): Ditto.
2015         * Scripts/webkitpy/port/darwin.py:
2016         (DarwinPort._port_specific_expectations_files): Accept device_type.
2017         * Scripts/webkitpy/port/driver.py:
2018         (DriverProxy):
2019         (DriverProxy.host): Expose _target_host for device_type information.
2020         * Scripts/webkitpy/port/gtk.py:
2021         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
2022         * Scripts/webkitpy/port/ios.py:
2023         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2024         * Scripts/webkitpy/port/mac.py:
2025         (MacPort. default_baseline_search_path): Ditto.
2026         * Scripts/webkitpy/port/port_testcase.py:
2027         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
2028         * Scripts/webkitpy/port/test.py:
2029         * Scripts/webkitpy/port/watch.py:
2030         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2031         * Scripts/webkitpy/port/win.py:
2032         (WinPort.test_search_path): Accept, but do not use, device_type.
2033         * Scripts/webkitpy/port/wpe.py:
2034         (WPEPort._port_specific_expectations_files): Ditto.
2035         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2036         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
2037
2038 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2039
2040         [LFC] Use the containing block's padding box to position out-of-flow elements.
2041         https://bugs.webkit.org/show_bug.cgi?id=193431
2042
2043         Reviewed by Antti Koivisto.
2044
2045         * LayoutReloaded/misc/LFC-passing-tests.txt:
2046
2047 2019-01-14  Tim Horton  <timothy_horton@apple.com>
2048
2049         Move a test implementation file that got misplaced in the Xcode project
2050
2051         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2052
2053 2019-01-14  Commit Queue  <commit-queue@webkit.org>
2054
2055         Unreviewed, rolling out r239901, r239909, r239910, r239912,
2056         r239913, and r239914.
2057         https://bugs.webkit.org/show_bug.cgi?id=193407
2058
2059         These revisions caused an internal failure (Requested by
2060         Truitt on #webkit).
2061
2062         Reverted changesets:
2063
2064         "[Cocoa] Avoid importing directly from subumbrella frameworks"
2065         https://bugs.webkit.org/show_bug.cgi?id=186016
2066         https://trac.webkit.org/changeset/239901
2067
2068         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
2069         https://trac.webkit.org/changeset/239909
2070
2071         "Tried to fix the build."
2072         https://trac.webkit.org/changeset/239910
2073
2074         "Fixed iOS builds after r239910."
2075         https://trac.webkit.org/changeset/239912
2076
2077         "More build fixing."
2078         https://trac.webkit.org/changeset/239913
2079
2080         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
2081         https://trac.webkit.org/changeset/239914
2082
2083 2019-01-14  Mark Lam  <mark.lam@apple.com>
2084
2085         Re-enable ability to build --cloop builds.
2086         https://bugs.webkit.org/show_bug.cgi?id=192955
2087         <rdar://problem/46882363>
2088
2089         Reviewed by Saam barati and Keith Miller.
2090
2091         The --cloop build option was being ignored this whole time since r236381.
2092         This patch makes it possible to build CLoop builds again.
2093
2094         * Scripts/build-jsc:
2095         * Scripts/webkitperl/FeatureList.pm:
2096         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2097
2098 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2099
2100         webkitpy: Expose device_type from host-like objects
2101         https://bugs.webkit.org/show_bug.cgi?id=193406
2102         <rdar://problem/47262305>
2103
2104         Reviewed by Lucas Forschler.
2105
2106         Devices should expose device_type. As a result, all host objects should
2107         provide a device_type property, even if they do not yet define a device_type.
2108
2109         * Scripts/webkitpy/common/system/systemhost.py:
2110         (SystemHost):
2111         (SystemHost.device_type):
2112         * Scripts/webkitpy/common/system/systemhost_mock.py:
2113         (MockSystemHost):
2114         (MockSystemHost.device_type):
2115         * Scripts/webkitpy/port/device.py:
2116         (Device):
2117         (Device.device_type):
2118         * Scripts/webkitpy/xcode/simulated_device.py:
2119         (SimulatedDeviceManager._find_exisiting_device_for_request):
2120         (SimulatedDeviceManager._disambiguate_device_type):
2121         (SimulatedDeviceManager._does_fulfill_request):
2122         (SimulatedDeviceManager.device_count_for_type):
2123         (SimulatedDeviceManager.initialize_devices):
2124         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2125         (test_available_devices):
2126         (test_swapping_devices):
2127
2128 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2129
2130         webkitpy: Support alternate simctl device list output (Follow-up fix)
2131         https://bugs.webkit.org/show_bug.cgi?id=193362
2132         <rdar://problem/47122965>
2133
2134         Rubber-stamped by Lucas Forschler.
2135
2136         * Scripts/webkitpy/xcode/simulated_device.py:
2137         (SimulatedDeviceManager.populate_available_devices):
2138
2139 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2140
2141         [iOS] Expose SPI to access the current sentence boundary and selection state
2142         https://bugs.webkit.org/show_bug.cgi?id=193398
2143         <rdar://problem/45893108>
2144
2145         Reviewed by Dean Jackson.
2146
2147         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
2148         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
2149         expected.
2150
2151         * TestWebKitAPI/EditingTestHarness.h:
2152         * TestWebKitAPI/EditingTestHarness.mm:
2153         (-[EditingTestHarness moveBackward]):
2154         (-[EditingTestHarness moveForward]):
2155         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
2156
2157         Add a couple of new helper methods on EditingTestHarness.
2158
2159         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2160         (-[SelectionChangeObserver initWithWebView:]):
2161         (-[SelectionChangeObserver webView]):
2162         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
2163         (-[SelectionChangeObserver currentSelectionAttributes]):
2164
2165 2019-01-14  Zalan Bujtas  <zalan@apple.com>
2166
2167         [LFC][BFC] Add basic box-sizing support.
2168         https://bugs.webkit.org/show_bug.cgi?id=193392
2169
2170         Reviewed by Antti Koivisto.
2171
2172         * LayoutReloaded/misc/LFC-passing-tests.txt:
2173
2174 2019-01-14  Charlie Turner  <cturner@igalia.com>
2175
2176         [WPE] API test gardening
2177         https://bugs.webkit.org/show_bug.cgi?id=193319
2178
2179         Reviewed by Michael Catanzaro.
2180
2181         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
2182         passing tests.
2183
2184 2019-01-14  Charlie Turner  <cturner@igalia.com>
2185
2186         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
2187         https://bugs.webkit.org/show_bug.cgi?id=192977
2188
2189         Reviewed by Carlos Garcia Campos.
2190
2191         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
2192         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2193         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
2194         (TestWebKitAPI::GStreamerTest::SetUp):
2195         (TestWebKitAPI::GStreamerTest::TearDown):
2196         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
2197         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
2198         (TestWebKitAPI::TEST_F):
2199
2200 2019-01-14  Charlie Turner  <cturner@igalia.com>
2201
2202         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
2203         https://bugs.webkit.org/show_bug.cgi?id=193332
2204
2205         Reviewed by Michael Catanzaro.
2206
2207         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
2208         defined as a char16_t, which changed in ICU 59, the
2209         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
2210         unsigned short. This test is relying on the behaviour that
2211         UChar=unsigned short, which doesn't hold across platforms and ICU
2212         library versions. The full fix would be a special syntax for
2213         literal characters so that these ambiguities do not arise. That
2214         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
2215         (TestWebKitAPI::TEST):
2216
2217 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2218
2219         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
2220
2221         * Scripts/make-dist:
2222         (Distcheck.configure):
2223
2224 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
2225
2226         [ews-build] Update macOS queue configurations
2227         https://bugs.webkit.org/show_bug.cgi?id=193365
2228         <rdar://problem/47221073>
2229
2230         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
2231
2232         * BuildSlaveSupport/ews-build/config.json:
2233
2234 2019-01-13  Zalan Bujtas  <zalan@apple.com>
2235
2236         [LFC] Adjust assert for statically positioned fixed elements
2237         https://bugs.webkit.org/show_bug.cgi?id=193385
2238
2239         Reviewed by Antti Koivisto.
2240
2241         * LayoutReloaded/misc/LFC-passing-tests.txt:
2242
2243 2019-01-13  Philippe Normand  <pnormand@igalia.com>
2244
2245         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
2246         https://bugs.webkit.org/show_bug.cgi?id=193387
2247
2248         Reviewed by Carlos Garcia Campos.
2249
2250         * MiniBrowser/wpe/main.cpp:
2251         (main):
2252
2253 2019-01-12  Timothy Hatcher  <timothy@apple.com>
2254
2255         Have prefers-color-scheme: light always match on macOS versions before Mojave.
2256         https://bugs.webkit.org/show_bug.cgi?id=191655
2257         rdar://problem/46074680
2258
2259         Reviewed by Megan Gardner.
2260
2261         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
2262         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2263
2264 2019-01-12  Dan Bernstein  <mitz@apple.com>
2265
2266         [Cocoa] Avoid importing directly from subumbrella frameworks
2267         https://bugs.webkit.org/show_bug.cgi?id=186016
2268         <rdar://problem/40591038>
2269
2270         Reviewed by Sam Weinig.
2271
2272         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2273           LaunchServices header.
2274         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2275           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2276         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2277           when using SDKs earlier than 10.13.
2278         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2279           and OTHER_CPLUSPLUSFLAGS.
2280         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2281           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2282         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2283           LaunchServices header.
2284
2285 2019-01-11  John Wilander  <wilander@apple.com>
2286
2287         Compile out Web API Statistics Collection
2288         https://bugs.webkit.org/show_bug.cgi?id=193370
2289         <rdar://problem/45388584>
2290
2291         Reviewed by Brent Fulgham.
2292
2293         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2294             Defined ENABLE_WEB_API_STATISTICS, off by default.
2295
2296 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2297
2298         [WPE] Add gtk-doc
2299         https://bugs.webkit.org/show_bug.cgi?id=178900
2300
2301         Reviewed by Michael Catanzaro.
2302
2303         Add Tools/gtkdoc to manifest.txt.in files.
2304         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
2305
2306         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
2307         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
2308
2309 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2310
2311         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
2312         https://bugs.webkit.org/show_bug.cgi?id=193364
2313         <rdar://problem/47214117>
2314
2315         Reviewed by Tim Horton.
2316
2317         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
2318         precise, whereas dragging near the middle of the textarea does.
2319
2320         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2321         (TestWebKitAPI::TEST):
2322
2323 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2324
2325         webkitpy: Support alternate simctl device list output
2326         https://bugs.webkit.org/show_bug.cgi?id=193362
2327         <rdar://problem/47122965>
2328
2329         Reviewed by Lucas Forschler.
2330
2331         * Scripts/webkitpy/xcode/simulated_device.py:
2332         (SimulatedDeviceManager.populate_available_devices):
2333
2334 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
2335
2336         [ews-build] Update macOS queue configurations
2337         https://bugs.webkit.org/show_bug.cgi?id=193365
2338
2339         Reviewed by Lucas Forschler.
2340
2341         * BuildSlaveSupport/ews-build/config.json:
2342
2343 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2344
2345         webkitpy: Incorporate device type into baseline search path
2346         https://bugs.webkit.org/show_bug.cgi?id=193356
2347         <rdar://problem/47215515>
2348
2349         Reviewed by Lucas Forschler.
2350
2351         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
2352
2353         * Scripts/webkitpy/port/base.py:
2354         (Port.default_baseline_search_path): Allow device type to be passed in.
2355         * Scripts/webkitpy/port/gtk.py:
2356         (GtkPort.default_baseline_search_path): Ignore device type.
2357         * Scripts/webkitpy/port/ios.py:
2358         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
2359         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
2360         * Scripts/webkitpy/port/ios_device_unittest.py:
2361         (IOSDeviceTest):
2362         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2363         (IOSSimulatorTest):
2364         * Scripts/webkitpy/port/mac.py:
2365         (MacPort.default_baseline_search_path): Ignore device type.
2366         * Scripts/webkitpy/port/watch.py:
2367         (WatchPort.default_baseline_search_path): Ditto.
2368         * Scripts/webkitpy/port/win.py:
2369         (WinPort.default_baseline_search_path): Ditto.
2370         (WinCairoPort.default_baseline_search_path): Ditto.
2371         * Scripts/webkitpy/port/wpe.py:
2372         (WPEPort.default_baseline_search_path): Ditto.
2373
2374 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2375
2376         webkitpy: Print abbreviated baseline search path that includes only folders that exist
2377         https://bugs.webkit.org/show_bug.cgi?id=193352
2378         <rdar://problem/47210736>
2379
2380         Reviewed by Lucas Forschler.
2381
2382         * Scripts/webkitpy/layout_tests/views/printing.py:
2383         (Printer.print_config): Print list on only baseline search paths which exist. 
2384         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2385         (Testprinter.test_print_config):
2386
2387 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
2388
2389         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
2390         https://bugs.webkit.org/show_bug.cgi?id=193340
2391
2392         Reviewed by David Kilzer.
2393
2394         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2395         (WTR::InjectedBundle::didReceiveMessageToPage):
2396         Pull the strings out into a WKRetainPtr.
2397
2398         * WebKitTestRunner/WebNotificationProvider.cpp:
2399         (WTR::WebNotificationProvider::closeWebNotification):
2400         Adopt the created value into the WKRetainPtr.
2401
2402         * WebKitTestRunner/mac/TestControllerMac.mm:
2403         (WTR::generateWhitelist):
2404         Immediately adopt a created value to avoid potential mistakes.
2405
2406 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
2407
2408         Enable DFG on ARM/Linux again
2409         https://bugs.webkit.org/show_bug.cgi?id=192496
2410
2411         Reviewed by Yusuke Suzuki.
2412
2413         After changing the bytecode format DFG was disabled on all 32-bit
2414         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2415         on ARM by default.
2416
2417         * Scripts/run-jsc-stress-tests:
2418
2419 2019-01-11  Timothy Hatcher  <timothy@apple.com>
2420
2421         Unreviewed, fix #ifdef in API test added in r239851.
2422         https://bugs.webkit.org/show_bug.cgi?id=193327
2423         rdar://problem/47093222
2424
2425         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
2426
2427 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2428
2429         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
2430         https://bugs.webkit.org/show_bug.cgi?id=193109
2431         <rdar://problem/44807048>
2432
2433         Reviewed by Ryosuke Niwa.
2434
2435         Introduce and respect a test option to enable the UndoManager API.
2436
2437         * WebKitTestRunner/TestController.cpp:
2438         (WTR::updateTestOptionsFromTestHeader):
2439         * WebKitTestRunner/TestOptions.h:
2440         (WTR::TestOptions::hasSameInitializationOptions const):
2441         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2442         (WTR::TestController::platformCreateWebView):
2443
2444 2019-01-11  Zalan Bujtas  <zalan@apple.com>
2445
2446         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
2447         https://bugs.webkit.org/show_bug.cgi?id=193346
2448
2449         Reviewed by Antti Koivisto.
2450
2451         * LayoutReloaded/misc/LFC-passing-tests.txt:
2452
2453 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2454
2455         Unreviewed, fix typo that breaks dashboard link.
2456
2457         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2458         (WebKitBuildbot):
2459
2460 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2461
2462         Update macOS queue configurations
2463         https://bugs.webkit.org/show_bug.cgi?id=193329
2464
2465         Reviewed by Alexey Proskuryakov.
2466
2467         * BuildSlaveSupport/build.webkit.org-config/config.json:
2468         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2469         (BubbleQueueServer):
2470         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2471         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2472         (WebKitBuildbot):
2473         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2474         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
2475         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2476
2477 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2478
2479         MiniBrowser should be able to navigate to about:blank
2480         https://bugs.webkit.org/show_bug.cgi?id=193345
2481
2482         Reviewed by Simon Fraser.
2483
2484         * MiniBrowser/mac/BrowserWindowController.m:
2485         (-[BrowserWindowController addProtocolIfNecessary:]):
2486         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2487
2488         * MiniBrowser/mac/WK1BrowserWindowController.m:
2489         (-[WK1BrowserWindowController fetch:]):
2490         * MiniBrowser/mac/WK2BrowserWindowController.m:
2491         (-[WK2BrowserWindowController fetch:]):
2492         Clean up the code that uses this to match style.
2493
2494 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2495
2496         Remove MiniBrowser custom "Process Swap" menu item which does not work
2497         https://bugs.webkit.org/show_bug.cgi?id=193344
2498
2499         Reviewed by Simon Fraser.
2500
2501         There is a menu item under the Experimental menu that does work.
2502
2503         * MiniBrowser/mac/AppDelegate.m:
2504         (defaultConfiguration):
2505         * MiniBrowser/mac/SettingsController.h:
2506         * MiniBrowser/mac/SettingsController.m:
2507         (-[SettingsController _populateMenu]):
2508         (-[SettingsController validateMenuItem:]):
2509         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2510         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2511
2512 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2513
2514         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2515         https://bugs.webkit.org/show_bug.cgi?id=193327
2516         rdar://problem/47093222
2517
2518         Reviewed by Tim Horton.
2519
2520         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2521         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2522         (TestWebKitAPI::didFinishNavigation):
2523         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2524         (TestWebKitAPI::TEST):
2525         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2526         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2527         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2528         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2529         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2530
2531 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2532
2533         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2534         https://bugs.webkit.org/show_bug.cgi?id=193338
2535         <rdar://problem/46664774>
2536
2537         Reviewed by David Kilzer.
2538
2539         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2540         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2541
2542 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2543
2544         Unreviewed, rolling out r239825.
2545         https://bugs.webkit.org/show_bug.cgi?id=193330
2546
2547         Broke tests on armv7/linux bots (Requested by guijemont on
2548         #webkit).
2549
2550         Reverted changeset:
2551
2552         "Enable DFG on ARM/Linux again"
2553         https://bugs.webkit.org/show_bug.cgi?id=192496
2554         https://trac.webkit.org/changeset/239825
2555
2556 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2557
2558         Disable the run-jsc-stress-test remote host key check.
2559         https://bugs.webkit.org/show_bug.cgi?id=192988
2560
2561         Reviewed by Alexey Proskuryakov.
2562
2563         * Scripts/run-jsc-stress-tests:
2564
2565 2019-01-10  John Wilander  <wilander@apple.com>
2566
2567         Override the session configuration for cookieAcceptPolicy
2568         https://bugs.webkit.org/show_bug.cgi?id=190925
2569         <rdar://problem/45497382>
2570
2571         Reviewed by Alexey Proskuryakov and Alex Christensen.
2572
2573         Test infrastructure for setting a first-party-only cookie policy.
2574
2575         * DumpRenderTree/TestRunner.cpp:
2576         (setOnlyAcceptFirstPartyCookiesCallback):
2577         (TestRunner::staticFunctions):
2578         * DumpRenderTree/TestRunner.h:
2579         * DumpRenderTree/mac/TestRunnerMac.mm:
2580         (TestRunner::setOnlyAcceptFirstPartyCookies):
2581         * DumpRenderTree/win/TestRunnerWin.cpp:
2582         (TestRunner::setOnlyAcceptFirstPartyCookies):
2583         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2584         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2585         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2586         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2587         * WebKitTestRunner/TestInvocation.cpp:
2588         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2589
2590 2019-01-09  Matt Rajca  <mrajca@apple.com>
2591
2592         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2593         https://bugs.webkit.org/show_bug.cgi?id=193301
2594
2595         Reviewed by Jer Noble.
2596         
2597         Added API tests.
2598
2599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2600         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2601         (TEST):
2602         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2603
2604 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2605
2606         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2607         https://bugs.webkit.org/show_bug.cgi?id=193310
2608
2609         Reviewed by Antti Koivisto.
2610
2611         * LayoutReloaded/misc/LFC-passing-tests.txt:
2612
2613 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2614
2615         Enable DFG on ARM/Linux again
2616         https://bugs.webkit.org/show_bug.cgi?id=192496
2617
2618         Reviewed by Yusuke Suzuki.
2619
2620         After changing the bytecode format DFG was disabled on all 32-bit
2621         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2622         on ARM by default.
2623
2624         * Scripts/run-jsc-stress-tests:
2625
2626 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2627
2628         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2629         https://bugs.webkit.org/show_bug.cgi?id=193271
2630
2631         Reviewed by Brent Fulgham.
2632
2633         BSTR is a special data structure created by SysAllocString, not a
2634         wchar_t null-terminated string.
2635
2636         * DumpRenderTree/win/TestRunnerWin.cpp:
2637         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2638         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2639         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2640         BSTR from wide string literals.
2641
2642 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2643
2644         Tweak wording for build/version_check style checker error
2645         https://bugs.webkit.org/show_bug.cgi?id=193256
2646
2647         Reviewed by Tim Horton.
2648
2649         * Scripts/webkitpy/style/checkers/cpp.py:
2650         (check_os_version_checks):
2651         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2652         (WebKitStyleTest.test_os_version_checks):
2653
2654 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2655
2656         [ews-build] Add link to bug along with bug title
2657         https://bugs.webkit.org/show_bug.cgi?id=193293
2658
2659         Reviewed by Lucas Forschler.
2660
2661         * BuildSlaveSupport/ews-build/steps.py:
2662         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2663         (ConfigureBuild.add_bug_id_url): Deleted.
2664         (ConfigureBuild.getBugURL): Deleted.
2665
2666 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2667
2668         [ews-build] Use https for ews-build server
2669         https://bugs.webkit.org/show_bug.cgi?id=193193
2670
2671         Reviewed by Lucas Forschler.
2672
2673         * BuildSlaveSupport/ews-build/steps.py:
2674
2675 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2676
2677         [ews-build] Parse and display number of style failures
2678         https://bugs.webkit.org/show_bug.cgi?id=193280
2679
2680         Reviewed by Lucas Forschler.
2681
2682         * BuildSlaveSupport/ews-build/steps.py:
2683         (CheckStyle): Use TestWithFailureCount as base class.
2684         (CheckStyle.countFailures): Count the number of style failures.
2685
2686 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2687
2688         [ews-build] use patch_id instead of ewspatchid
2689         https://bugs.webkit.org/show_bug.cgi?id=193235
2690
2691         Reviewed by Lucas Forschler.
2692
2693         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2694         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2695         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2696
2697 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2698
2699         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2700         https://bugs.webkit.org/show_bug.cgi?id=192625
2701
2702         Reviewed by Antti Koivisto.
2703
2704         * LayoutReloaded/misc/LFC-passing-tests.txt:
2705
2706 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2707
2708         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2709         https://bugs.webkit.org/show_bug.cgi?id=192841
2710
2711         Reviewed by Carlos Garcia Campos.
2712
2713         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2714         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2715         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2716
2717         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2718
2719         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2720         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2721         (WebKitWebEditorTest::testSelectionChanged):
2722         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2723         (WebKitFrameTest::testMainFrame):
2724         (WebKitFrameTest::testURI):
2725         (WebKitFrameTest::testJavaScriptContext):
2726         (WebKitFrameTest::testJavaScriptValues):
2727         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2728         (testWebViewAuthenticationRequest):
2729         (testWebViewAuthenticationLoadCancelled):
2730         (testWebViewAuthenticationFailure):
2731         (testWebViewAuthenticationStorage):
2732         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2733         (testWebViewAuthenticationProxy):
2734         (testWebViewAuthenticationProxyHTTPS):
2735         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2736         (testAutomationSessionRequestSession):
2737         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2738         (testBackForwardListNavigation):
2739         (testWebKitWebViewSessionState):
2740         (testWebKitWebViewSessionStateWithFormData):
2741         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2742         (ConsoleMessageTest::consoleMessageReceivedCallback):
2743         (testWebKitConsoleMessageConsoleAPI):
2744         (testWebKitConsoleMessageJavaScriptException):
2745         (testWebKitConsoleMessageNetworkError):
2746         (testWebKitConsoleMessageSecurityError):
2747         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2748         (testCookieManagerAcceptPolicy):
2749         (testCookieManagerCookiesChanged):
2750         (testCookieManagerPersistentStorage):
2751         (testCookieManagerPersistentStorageDeleteAll):
2752         (testCookieManagerEphemeral):
2753         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2754         (testWebKitDOMElementAutoFill):
2755         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2756         (downloadLocalFileSuccessfully):
2757         (createFileAtDestination):
2758         (testDownloadOverwriteDestinationDisallowed):
2759         (testDownloadLocalFileError):
2760         (testDownloadRemoteFile):
2761         (testDownloadRemoteFileError):
2762         (testWebViewDownloadURI):
2763         (testPolicyResponseDownload):
2764         (testPolicyResponseDownloadCancel):
2765         (testDownloadMIMEType):
2766         (contextMenuCallback):
2767         (testContextMenuDownloadActions):
2768         (testBlobDownload):
2769         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2770         (testWebKitWebEditorSelectionChanged):
2771         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2772         (testWebKitFrameMainFrame):
2773         (testWebKitFrameURI):
2774         (testWebKitFrameJavaScriptContext):
2775         (testWebKitFrameJavaScriptValues):
2776         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2777         (LoadStopTrackingTest::loadFailed):
2778         (testWebViewTitle):
2779         (testURIRequestHTTPHeaders):
2780         (testURIRequestHTTPMethod):
2781         (testURIResponseHTTPHeaders):
2782         (testRedirectToDataURI):
2783         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2784         (testProcessPerWebView):
2785         (testWebProcessLimit):
2786         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2787         (testWebViewResources):
2788         (testWebResourceLoading):
2789         (testWebResourceSuggestedFilename):
2790         (testWebResourceGetData):
2791         (testWebResourceGetDataError):
2792         (testWebViewResourcesHistoryCache):
2793         (testWebResourceSendRequest):
2794         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2795         (testSSL):
2796         (testInsecureContent):
2797         (testTLSErrorsPolicy):
2798         (testTLSErrorsRedirect):
2799         (testTLSErrorsHTTPAuth):
2800         (testLoadFailedWithTLSErrors):
2801         (testSubresourceLoadFailedWithTLSErrors):
2802         (httpsServerCallback):
2803         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2804         (testWebViewCreateNavigationData):
2805         (testWebViewJavaScriptDialogs):
2806         (testWebViewWindowProperties):
2807         (testWebViewMouseTarget):
2808         (testWebViewFileChooserRequest):
2809         (testWebViewColorChooserRequest):
2810         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2811         (testWebExtensionGetTitle):
2812         (testDocumentLoadedSignal):
2813         (testWebKitWebViewProcessCrashed):
2814         (testWebExtensionWindowObjectCleared):
2815         (testWebExtensionIsolatedWorld):
2816         (permissionRequestCallback):
2817         (didAssociateFormControlsCallback):
2818         (testWebExtensionFormControlsAssociated):
2819         (FormSubmissionTest::FormSubmissionTest):
2820         (FormSubmissionTest::testFormSubmissionResult):
2821         (testWebExtensionFormSubmissionSteps):
2822         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2823         (testNotInitialized):
2824         (testClearDatabase):
2825         (testPrivateBrowsing):
2826         (testGetFavicon):
2827         (testWebViewFavicon):
2828         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2829         (testFindControllerTextFound):
2830         (testFindControllerTextNotFound):
2831         (testFindControllerMatchCount):
2832         (testFindControllerMaxMatchCount):
2833         (testFindControllerNext):
2834         (testFindControllerPrevious):
2835         (testFindControllerCountedMatches):
2836         (testFindControllerOptions):
2837         (testFindControllerHide):
2838         (testFindControllerInstance):
2839         (testFindControllerGetters):
2840         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2841         (testNavigationPolicy):
2842         (testResponsePolicy):
2843         (testNewWindowPolicy):
2844         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2845         (testSecurityOriginBasicConstructor):
2846         (testSecurityOriginURIConstructor):
2847         (testSecurityOriginDefaultPort):
2848         (testSecurityOriginFileURI):
2849         (testOpaqueSecurityOrigin):
2850         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2851         (testWebKitSettings):
2852         (testWebKitSettingsNewWithSettings):
2853         (testWebKitSettingsUserAgent):
2854         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2855         (testWebViewNewWithUserContentManager):
2856         (isStyleSheetInjectedForURLAtPath):
2857         (isScriptInjectedForURLAtPath):
2858         (testUserContentManagerInjectedStyleSheet):
2859         (testUserContentManagerInjectedScript):
2860         (UserScriptMessageTest::scriptMessageReceived):
2861         (UserScriptMessageTest::waitUntilMessageReceived):
2862         (UserScriptMessageTest::runJavaScriptFinished):
2863         (testUserContentManagerScriptMessageReceived):
2864         (testUserContentManagerScriptMessageInWorldReceived):
2865         (testUserContentManagerScriptMessageFromDOMBindings):
2866         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2867         (testWebContextDefault):
2868         (testWebContextEphemeral):
2869         (testWebContextGetPlugins):
2870         (testWebContextURIScheme):
2871         (testWebContextSpellChecker):
2872         (testWebContextLanguages):
2873         (consoleMessageReceivedCallback):
2874         (testWebContextSecurityFileXHR):
2875         (ProxyTest::ProxyTest):
2876         (testWebContextProxySettings):
2877         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2878         (testWebViewWebContext):
2879         (testWebViewWebBackend):
2880         (testWebViewEphemeral):
2881         (testWebViewCustomCharset):
2882         (testWebViewSettings):
2883         (testWebViewRunJavaScript):
2884         (testWebViewCanShowMIMEType):
2885         (testWebViewSubmitForm):
2886         (testWebViewSave):
2887         (testWebViewPageVisibility):
2888         (testWebViewSnapshot):
2889         (testWebViewNotification):
2890         (testWebViewNotificationInitialPermissionAllowed):
2891         (testWebViewNotificationInitialPermissionDisallowed):
2892         (testWebViewIsPlayingAudio):
2893         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2894         (WebsiteDataTest::WebsiteDataTest):
2895         (WebsiteDataTest::remove):
2896         (WebsiteDataTest::clear):
2897         (testWebsiteDataConfiguration):
2898         (testWebsiteDataEphemeral):
2899         (testWebsiteDataCache):
2900         (testWebsiteDataStorage):
2901         (testWebsiteDataDatabases):
2902         (testWebsiteDataAppcache):
2903         (testWebsiteDataCookies):
2904         (testWebsiteDataDeviceIdHashSalt):
2905         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2906         (emitDocumentLoaded):
2907         (emitURIChanged):
2908         (sendRequestCallback):
2909         (contextMenuCallback):
2910         (consoleMessageSentCallback):
2911         (emitFormControlsAssociated):
2912         (formControlsAssociatedCallback):
2913         (emitFormSubmissionEvent):
2914         (willSubmitFormCallback):
2915         (windowObjectCleared):
2916         (methodCallCallback):
2917         (registerGResource):
2918         (webkit_web_extension_initialize_with_user_data):
2919         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2920         (checkLeaks):
2921         (WebProcessTest::create):
2922         (runTest):
2923         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2924         (AutocleanupsTest::testWebProcessAutocleanups):
2925         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2926         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2927         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2928         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2929         (WebKitDOMDOMWindowTest::testSignals):
2930         (WebKitDOMDOMWindowTest::testDispatchEvent):
2931         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2932         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2933         (WebKitDOMNodeFilterTest::testTreeWalker):
2934         (WebKitDOMNodeFilterTest::testNodeIterator):
2935         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2936         (WebKitDOMNodeTest::testHierarchyNavigation):
2937         (WebKitDOMNodeTest::testInsertion):
2938         (WebKitDOMNodeTest::testTagNamesNodeList):
2939         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2940         (WebKitDOMNodeTest::testDOMCache):
2941         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2942         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2943         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2944         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2945         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2946         (testUIProcessAutocleanups):
2947         (testWebProcessAutocleanups):
2948         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2949         (testContextMenuPopulateMenu):
2950         (testContextMenuDismissed):
2951         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2952         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2953         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2954         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
2955         (testWebKitDOMDOMWindowSignals):
2956         (testWebKitDOMDOMWindowDispatchEvent):
2957         (testWebKitDOMDOMWindowGetComputedStyle):
2958         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
2959         (testWebKitDOMNodeHierarchyNavigation):
2960         (testWebKitDOMNodeInsertion):
2961         (testWebKitDOMNodeTagNamesNodeList):
2962         (testWebKitDOMNodeTagNamesHTMLCollection):
2963         (testWebKitDOMObjectCache):
2964         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
2965         (testWebKitDOMNodeFilterTreeWalker):
2966         (testWebKitDOMNodeFilterNodeIterator):
2967         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
2968         (testWebKitDOMXPathNSResolverNative):
2969         (testWebKitDOMXPathNSResolverCustom):
2970         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2971         (testInspectorDefault):
2972         (testInspectorManualAttachDetach):
2973         (testInspectorCustomContainerDestroyed):
2974         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
2975         (startTestServer):
2976         (testInspectorServerPageList):
2977         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
2978         (OptionMenuTest::showOptionMenuCallback):
2979         (OptionMenuTest::menuCloseCallback):
2980         (OptionMenuTest::close):
2981         (OptionMenuTest::activateItem):
2982         (OptionMenuTest::selectItem):
2983         (testOptionMenuSimple):
2984         (testOptionMenuGroups):
2985         (testOptionMenuActivate):
2986         (testOptionMenuSelect):
2987         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2988         (testPrintOperationPrintSettings):
2989         (webViewPrintCallback):
2990         (testPrintOperationPrint):
2991         (testPrintCustomWidget):
2992         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2993         (checkAtspiAccessible):
2994         (testAtspiBasicHierarchy):
2995         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
2996         (testWebKitCheckVersion):
2997         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2998         (testWebViewEditorCutCopyPasteNonEditable):
2999         (testWebViewEditorCutCopyPasteEditable):
3000         (testWebViewEditorSelectAllNonEditable):
3001         (testWebViewEditorSelectAllEditable):
3002         (loadContentsAndTryToCutSelection):
3003         (testWebViewEditorNonEditable):
3004         (testWebViewEditorEditable):
3005         (testWebViewEditorEditorStateTypingAttributes):
3006         (testWebViewEditorInsertImage):
3007         (testWebViewEditorCreateLink):
3008         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3009         (loadChangedCallback):
3010         (loadFailedCallback):
3011         (loadFailedWithTLSErrorsCallback):
3012         (LoadTrackingTest::LoadTrackingTest):
3013         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3014         (registerGResource):
3015         (removeNonEmptyDirectory):
3016         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3017         (Test::adoptView):
3018         (Test::~Test):
3019         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3020         (WebKitTestBus::getOrCreateConnection):
3021         (WebKitTestBus::createProxy):
3022         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
3023         (WebKitTestServer::getWebSocketURIForPath const):
3024         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3025         (WebViewTest::initializeWebView):
3026         (WebViewTest::loadURI):
3027         (WebViewTest::loadHtml):
3028         (WebViewTest::loadPlainText):
3029         (WebViewTest::loadBytes):
3030         (WebViewTest::loadRequest):
3031         (WebViewTest::loadAlternateHTML):
3032         (WebViewTest::goBack):
3033         (WebViewTest::goForward):
3034         (WebViewTest::goToBackForwardListItem):
3035         (resourceGetDataCallback):
3036         (WebViewTest::mainResourceData):
3037         (WebViewTest::javascriptResultToCString):
3038         (WebViewTest::javascriptResultToNumber):
3039         (WebViewTest::javascriptResultToBoolean):
3040         (WebViewTest::javascriptResultIsNull):
3041         (WebViewTest::javascriptResultIsUndefined):
3042         (onSnapshotReady):
3043         (WebViewTest::runWebProcessTest):
3044         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
3045         (WebViewTest::platformInitializeWebView):
3046         (WebViewTest::showInWindow):
3047         (WebViewTest::showInWindowAndWaitUntilMapped):
3048         (WebViewTest::mouseMoveTo):
3049         (WebViewTest::emitPopupMenuSignal):
3050         (WebViewTest::keyStroke):
3051         (WebViewTest::doMouseButtonEvent):
3052
3053 2019-01-09  Philippe Normand  <pnormand@igalia.com>
3054
3055         [WPE] API tests can't run in flatpak environment
3056         https://bugs.webkit.org/show_bug.cgi?id=193242
3057
3058         Reviewed by Michael Catanzaro.
3059
3060         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
3061         flatpakutils so that it knows which port it's dealing with.
3062         * glib/common.py: Remove build_dir globals so that subsequent
3063         calls actually take args into account.
3064         (library_build_path):
3065         (binary_build_path):
3066
3067 2019-01-08  Dean Jackson  <dino@apple.com>
3068
3069         Blob references for System Previews don't get a correct file extension
3070         https://bugs.webkit.org/show_bug.cgi?id=193268
3071         <rdar://problem/47133037>
3072
3073         Reviewed by Tim Horton.
3074
3075         New test that a Blob download of a USDZ file gets named correctly.
3076
3077         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3078         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3079         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3080         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
3081         (TEST):
3082         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
3083
3084 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
3085
3086         [WebAuthN] Support U2F HID Authenticators on macOS
3087         https://bugs.webkit.org/show_bug.cgi?id=191535
3088         <rdar://problem/47102027>
3089
3090         Reviewed by Brent Fulgham.
3091
3092         This patch:
3093         1) adds support for U2F mocking mechanism;
3094         2) updates tests to reflect U2fCommandConstructor changes.
3095
3096         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3097         (TestWebKitAPI::TEST):
3098         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3099         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3100         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3101
3102 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3103
3104         [iOS] Dispatch a synthetic mousedown event prior to starting drags
3105         https://bugs.webkit.org/show_bug.cgi?id=193229
3106         <rdar://problem/46717097>
3107
3108         Reviewed by Tim Horton.
3109
3110         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
3111         prevents a drag from starting.
3112
3113         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3114         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
3115
3116         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
3117
3118 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
3119   
3120         Layout test will generate a perf metric file to results dir.
3121         https://bugs.webkit.org/show_bug.cgi?id=192030
3122         <rdar://problem/32779516>
3123
3124         Reviewed by Aakash Jain.
3125
3126         Layout test running time will be collected to a perf metric file.
3127         For now, instead of outputing running time of all tests (which is huge),
3128         we aggregate them by test directories which are at most two level deep. 
3129
3130         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3131         (Manager._end_test_run):
3132         (Manager._output_perf_metrics):
3133         (Manager._print_expectation_line_for_test):
3134         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3135         (add_test_perf_metric):
3136         (test_perf_metrics):
3137         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3138         (JSONGeneratorTest.test_test_timings_trie):
3139         (JSONGeneratorTest):
3140         (JSONGeneratorTest.test_test_perf_metrics):
3141         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3142         (RebaselineTest.test_reset_results):
3143         (RebaselineTest.test_missing_results):
3144         (RebaselineTest.test_new_baseline):
3145
3146 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
3147
3148         [WPE][GTK] Add php-json to install-dependencies
3149         https://bugs.webkit.org/show_bug.cgi?id=193233
3150
3151         Reviewed by Michael Catanzaro.
3152
3153         * gtk/install-dependencies:
3154         * wpe/install-dependencies:
3155
3156 2019-01-08  Chris Dumez  <cdumez@apple.com>
3157
3158         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
3159         https://bugs.webkit.org/show_bug.cgi?id=193224
3160         <rdar://problem/47097726>
3161
3162         Reviewed by Alex Christensen.
3163
3164         Add API test coverage.
3165
3166         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3167
3168 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3169
3170         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
3171         <https://webkit.org/b/193222>
3172         <rdar://problem/46862309>
3173
3174         Reviewed by Joseph Pecoraro.
3175
3176         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3177         (WTR::executeCallback): Fix camel case of variable name.
3178         (WTR::EventSendingController::callAfterScrollingCompletes): If
3179         WKBundlePageRegisterScrollOperationCompletionCallback() returns
3180         false, make sure to release the ScrollCompletionCallbackData
3181         object.  This fixes the leak.
3182
3183 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3184
3185         [Win] EWS: wincairo-ews cannot apply a patch with *.png
3186         https://bugs.webkit.org/show_bug.cgi?id=193044
3187
3188         Reviewed by Daniel Bates.
3189
3190         WinCairo EWS bots are using Windows Perl. Binary files should be
3191         opened as binary mode.
3192
3193         * Scripts/svn-apply:
3194         (handleGitBinaryChange): Use 'binmode' for binary file handles.
3195
3196 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
3197
3198         [CMake] Add ENABLE_CSS_TYPED_OM option
3199         https://bugs.webkit.org/show_bug.cgi?id=193216
3200
3201         Reviewed by Michael Catanzaro.
3202
3203         * Scripts/webkitperl/FeatureList.pm:
3204
3205 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3206
3207         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
3208         <https://webkit.org/b/193056>
3209
3210         Reviewed by Alex Christensen.
3211
3212         * Scripts/webkitpy/style/checker.py:
3213         - Ignore use of new runtime/retainptr check in
3214           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
3215           contains tests to ensure RetainPtr<NSObject *> is compatible
3216           with RetainPtr<NSObject>.
3217
3218         * Scripts/webkitpy/style/checkers/cpp.py:
3219         (check_language):
3220         (CppChecker):
3221         - Add checker for use of '*' in RetainPtr<> type.  A for loop
3222           was used instead of a single regex so that angle brackets
3223           could be matched up when checking the type contained within
3224           the RetainPtr<> type.
3225
3226         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3227         (CppStyleTest):
3228         - Add unit test for new runtime/retainptr check.
3229
3230         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
3231         * TestWebKitAPI/EditingTestHarness.h:
3232         - Remove '*' from RetainPtr<> type.
3233
3234         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3235         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
3236           regressed in r201938.
3237
3238         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3239         (TestWebKitAPI::TEST):
3240         - Update tests to match RetainPtr.mm tests (except for the
3241           `*SimilarNSType` tests since there is no CF equivalent of
3242           RetainPtr<NSString> and RetainPtr<NSString *>).
3243
3244         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3245         (TestWebKitAPI::TEST):
3246         - Update tests to:
3247           - Not conflict by name with equivalent CF tests in
3248             RetainPtr.cpp.
3249           - Add test cases for RetainPtr<NSObject>,
3250             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
3251           - Add `*SimilarNSType` tests for converting between
3252             RetainPtr<NSObject> and RetainPtr<NSObject *>.
3253           - Change `0` to `nil` as appropriate.
3254           - Re-alphabetize the tests by name.
3255           - Add Optional<RetainPtr<>> tests.
3256           - Add retainPtr() tests.
3257
3258         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3259         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3260         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
3261         (TEST):
3262         - Remove '*' from RetainPtr<> type.
3263
3264         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
3265         (TEST(WebKit, JITEnabled)):
3266         - Add missing WTFMove().  Apparently a temporary was being
3267           created before in the argument list due to mismatched
3268           RetainPtr<> types.
3269
3270         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3271         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
3272         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
3273         (TestWebKitAPI::TEST):
3274         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3275         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3276         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3277         (WTR::resourcesDirectoryURL):
3278         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3279         (WTR::InjectedBundle::platformInitialize):
3280         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3281         - Remove '*' from RetainPtr<> type.
3282
3283 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
3284
3285         A MediaTime timescale must never be zero
3286         https://bugs.webkit.org/show_bug.cgi?id=193156
3287         <rdar://problem/32504501>
3288
3289         Reviewed by Jer Noble.
3290
3291         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3292         (TestWebKitAPI::TEST): Add tests for zero timescale.
3293
3294 2019-01-07  Youenn Fablet  <youenn@apple.com>
3295
3296         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
3297         https://bugs.webkit.org/show_bug.cgi?id=193175
3298
3299         Reviewed by Chris Dumez.
3300
3301         Updated API test as we bumped the SW schema to version 4.
3302
3303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3304         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
3305         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3306         (TEST):
3307
3308 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3309
3310         [Win][Clang] Fix compilation warnings of MiniBrowser
3311         https://bugs.webkit.org/show_bug.cgi?id=193029
3312
3313         Reviewed by Ross Kirsling.
3314
3315         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
3316         and m_URLBarFont. Reorder member variables to fix -Wreorder
3317         warning.
3318         * MiniBrowser/win/PageLoadTestClient.cpp:
3319         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
3320         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
3321         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
3322         m_currentURLIndex.
3323         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3324         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
3325         navigationClient with '{ }' to fix the missing field warning.
3326         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3327         (initDocStruct): Changed the argument type docname to const.
3328
3329 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
3330
3331         [WebAuthN] Import U2F command/response converters from Chromium
3332         https://bugs.webkit.org/show_bug.cgi?id=193150
3333         <rdar://problem/47054028>
3334
3335         Reviewed by Brent Fulgham.
3336
3337         Adds API tests.
3338
3339         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3340         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3341         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
3342         (TestWebKitAPI::getTestAuthenticatorDataBytes):
3343         (TestWebKitAPI::getTestAttestationObjectBytes):
3344         (TestWebKitAPI::getTestSignResponse):
3345         (TestWebKitAPI::getTestU2fRegisterResponse):
3346         (TestWebKitAPI::TEST):
3347         (TestWebKitAPI::convertToVector): Deleted.
3348         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3349         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
3350         (TestWebKitAPI::constructMakeCredentialRequest):
3351         (TestWebKitAPI::constructGetAssertionRequest):
3352         (TestWebKitAPI::TEST):
3353
3354 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
3355
3356         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
3357         https://bugs.webkit.org/show_bug.cgi?id=193136
3358
3359         Reviewed by Michael Catanzaro.
3360
3361         * gtk/install-dependencies:
3362         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
3363         they are needed by update-webkitgtk-libs.
3364
3365 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
3366
3367         Unreviewed follow-up fix to r239650
3368         https://bugs.webkit.org/show_bug.cgi?id=193140
3369         <rdar://problem/47063037>
3370
3371         Typecast patch_id to string.
3372
3373         * BuildSlaveSupport/ews-build/steps.py:
3374         (ValidatePatch._is_patch_obsolete):
3375
3376 2019-01-04  Daniel Bates  <dabates@apple.com>
3377
3378         [lldb-webkit]: Add support for pretty-printing raw bitmask types
3379         https://bugs.webkit.org/show_bug.cgi?id=193024
3380
3381         Reviewed by Jer Noble.
3382
3383         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
3384         for the bitmask type WebEventFlags as an example.
3385
3386         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
3387         that can be used to register summary and synthetic child formatters for a bitmask type.
3388         For example, consider the following enum and bitmask typedefs:
3389
3390         typedef enum {
3391             A = 1 << 0,
3392             B = 1 << 1,
3393             C = 1 << 2,
3394         } SpecialFlagValues;
3395         typedef unsigned SpecialFlags;
3396
3397         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
3398         __lldb_init_module():
3399
3400             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
3401                     1 << 0: "A",
3402                     1 << 1: "B",
3403                     1 << 2: "C",
3404             })
3405
3406         * lldb/lldb_webkit.py:
3407         (addSummaryAndSyntheticFormattersForRawBitmaskType):
3408         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
3409         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
3410         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
3411         A convenience function to dynamically creaste a synthetic formatter class and summary
3412         string function for the specified bitmask type and enumerator value to name map. This
3413         function register the dynamically created class and function with LLDB.
3414
3415         (__lldb_init_module):
3416         (FlagEnumerationProvider):
3417         (FlagEnumerationProvider._enumerator_value_to_name_map):
3418         (FlagEnumerationProvider._bitmask):
3419         (FlagEnumerationProvider._update):
3420         (FlagEnumerationProvider.has_children):
3421         (FlagEnumerationProvider.num_children):
3422         (FlagEnumerationProvider.get_child_index):
3423         (FlagEnumerationProvider.get_child_at_index):
3424         (FlagEnumerationProvider.update):
3425         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
3426
3427         (WTFOptionSetProvider):
3428         (WTFOptionSetProvider._enumerator_value_to_name_map):
3429         (WTFOptionSetProvider._bitmask):
3430         (WTFOptionSetProvider._update):
3431         Write in terms of the base class.
3432
3433         (RawBitmaskProviderBase):
3434         (RawBitmaskProviderBase._enumerator_value_to_name_map):
3435         (RawBitmaskProviderBase._bitmask):
3436         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
3437         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
3438         {
3439             1 << 0: "A",
3440             1 << 1: "B",
3441             1 << 2: "C",
3442         }
3443         It is not necessary to instantiate such a derived class directory. Instead use the convenience
3444         function addSummaryAndSyntheticFormattersForRawBitmaskType.
3445
3446         (WTFOptionSetProvider.has_children): Deleted.
3447         (WTFOptionSetProvider.num_children): Deleted.
3448         (WTFOptionSetProvider.get_child_index): Deleted.
3449         (WTFOptionSetProvider.get_child_at_index): Deleted.
3450         (WTFOptionSetProvider.update): Deleted.
3451
3452 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3453
3454         [ews-build] Add build step to validate the patch before processing it
3455         https://bugs.webkit.org/show_bug.cgi?id=193140
3456
3457         Reviewed by Lucas Forschler.
3458
3459         * BuildSlaveSupport/ews-build/factories.py:
3460         (Factory.__init__): Added ValidatePatch step.
3461         * BuildSlaveSupport/ews-build/steps.py:
3462         (ValidatePatch):
3463         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
3464         (ValidatePatch.get_patch_json): Get patch json data.
3465         (ValidatePatch.get_bug_json): Get bug json data.
3466         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
3467         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
3468         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
3469         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
3470         (ValidatePatch.skip_build): Skip the build.
3471         (ValidatePatch.start):
3472
3473 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3474
3475         Progress towards fixing Mac CMake build
3476         https://bugs.webkit.org/show_bug.cgi?id=193105
3477
3478         Reviewed by Don Olmstead.
3479
3480         * TestWebKitAPI/PlatformMac.cmake:
3481
3482 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3483
3484         Fix API test after r239631
3485         https://bugs.webkit.org/show_bug.cgi?id=193118
3486
3487         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3488         (TestWebKitAPI::TEST):
3489         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
3490         Do the same thing via the API to fix the test.
3491
3492 2019-01-04  Jer Noble  <jer.noble@apple.com>
3493
3494         [WebKitLegacy] Media playback pauses on scroll
3495         https://bugs.webkit.org/show_bug.cgi?id=192829
3496
3497         Reviewed by Eric Carlson.
3498
3499         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3500         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
3501         (TestWebKitAPI::TEST):
3502         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
3503         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
3504         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
3505         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
3506         (TestWebKitAPI::TEST):
3507
3508 2019-01-04  Chris Dumez  <cdumez@apple.com>
3509
3510         Add support for toggling device orientation API support per site
3511         https://bugs.webkit.org/show_bug.cgi?id=193143
3512         <rdar://problem/46605724>
3513
3514         Reviewed by Alex Christensen.
3515
3516         Add API test coverage.
3517
3518         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3519         (-[DataMappingSchemeHandler setTaskHandler:]):
3520         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3521         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
3522         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3523         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
3524
3525 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3526
3527         [ews-build] use svn-apply script to apply the patches
3528         https://bugs.webkit.org/show_bug.cgi?id=193138
3529
3530         Reviewed by Lucas Forschler.
3531
3532         * BuildSlaveSupport/ews-build/factories.py:
3533         (Factory.__init__): Add the ApplyPatch step.
3534         * BuildSlaveSupport/ews-build/steps.py:
3535         (CheckOutSource): Added step name.
3536         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
3537         (ApplyPatch): Build step to apply patch using svn-apply script.
3538         (UnApplyPatchIfRequired):
3539         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
3540
3541 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3542
3543         Deprecate WKContextCreate
3544         https://bugs.webkit.org/show_bug.cgi?id=193118
3545
3546         Reviewed by Brady Eidson.
3547
3548         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3549         (WebKitBrowserWindow::WebKitBrowserWindow):
3550         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
3551         (TestWebKitAPI::TEST):
3552         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3553         (TestWebKitAPI::TEST):
3554         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3555         (TestWebKitAPI::TEST):
3556         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3557         (TestWebKitAPI::TEST):
3558         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3559         (TestWebKitAPI::TEST):
3560         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3561         (TestWebKitAPI::TEST):
3562         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3563         (TestWebKitAPI::TEST):
3564         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3565         (TestWebKitAPI::TEST):
3566         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3567         (TestWebKitAPI::TEST):
3568         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3569         (TestWebKitAPI::TEST):
3570         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3571         (TestWebKitAPI::TEST):
3572         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3573         (TestWebKitAPI::TEST):
3574         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3575         (TestWebKitAPI::TEST):
3576         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3577         (TestWebKitAPI::TEST):
3578         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3579         (TestWebKitAPI::TEST):
3580         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3581         (TestWebKitAPI::TEST):
3582         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3583         (TestWebKitAPI::TEST):
3584         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3585         (TestWebKitAPI::TEST):
3586         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3587         (TestWebKitAPI::loadAlternateHTMLString):
3588         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3589         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3590         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3591         (TestWebKitAPI::buildAndPerformTest):
3592         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3593         (TestWebKitAPI::TEST):
3594         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3595         (TestWebKitAPI::TEST):
3596         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3597         (TestWebKitAPI::TEST):
3598         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3599         (TestWebKitAPI::TEST):
3600         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3601         (TestWebKitAPI::TEST):
3602         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3603         (TestWebKitAPI::TEST):
3604         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3605         (TestWebKitAPI::TEST):
3606         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3607         (TestWebKitAPI::TEST):
3608         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3609         (TestWebKitAPI::TEST):
3610         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3611         (TestWebKitAPI::TEST):
3612         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3613         (TestWebKitAPI::TEST):
3614         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3615         (TestWebKitAPI::TEST):
3616         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3617         (TestWebKitAPI::TEST):
3618         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3619         (TestWebKitAPI::TEST):
3620         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3621         (TestWebKitAPI::TEST):
3622         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3623         (TestWebKitAPI::TEST):
3624         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3625         (TestWebKitAPI::TEST):
3626         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3627         (TestWebKitAPI::TEST):
3628         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3629         (TestWebKitAPI::TEST):
3630         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3631         (TestWebKitAPI::TEST):
3632         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3633         (TestWebKitAPI::TEST):
3634         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3635         (TestWebKitAPI::TEST):
3636         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3637         (TestWebKitAPI::TEST):
3638         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3639         (TestWebKitAPI::TEST):
3640         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3641         (TestWebKitAPI::TEST):
3642         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3643         (TestWebKitAPI::TEST):
3644         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3645         (WebKit2_CommandBackForwardTestWKView::SetUp):
3646         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3647         (TestWebKitAPI::TEST):
3648         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3649         (TestWebKitAPI::TEST):
3650         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3651         (TestWebKitAPI::TEST):
3652         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3653         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3654
3655 2019-01-03  Matt Rajca  <mrajca@apple.com>
3656
3657         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3658         https://bugs.webkit.org/show_bug.cgi?id=193128
3659         rdar://34554231
3660
3661         Reviewed by Jer Noble.
3662
3663         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3664         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3665         event along with a flag that indicates whether or not autoplay was actually prevented.
3666
3667         Tests: existing API tests were updated to reflect the new names. New API tests
3668         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3669
3670         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3671         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3672         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3673         (TEST):
3674         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3675         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3676
3677 2019-01-04  Chris Dumez  <cdumez@apple.com>
3678
3679         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3680         https://bugs.webkit.org/show_bug.cgi?id=193120
3681
3682         Reviewed by Alex Christensen.
3683
3684         Add API test coverage.
3685
3686         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3687
3688 2019-01-04  Chris Dumez  <cdumez@apple.com>
3689
3690         Crash under WebProcessPool::addSuspendedPage()
3691         https://bugs.webkit.org/show_bug.cgi?id=193110
3692
3693         Reviewed by Youenn Fablet.
3694
3695         Add API test coverage.
3696
3697         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3698
3699 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3700
3701         [ews-build] Check patch relevance before applying the patch
3702         https://bugs.webkit.org/show_bug.cgi?id=193102
3703
3704         Reviewed by Lucas Forschler.
3705
3706         * BuildSlaveSupport/ews-build/factories.py:
3707         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3708
3709 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3710
3711         [ews-build] Check patch relevance step should print patch id
3712         https://bugs.webkit.org/show_bug.cgi?id=193137
3713
3714         Reviewed by Lucas Forschler.
3715
3716         * BuildSlaveSupport/ews-build/steps.py:
3717         (CheckPatchRelevance.start): Update the status to include patch id.
3718
3719 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3720
3721         webkitpy: Increase simulator teardown timeout
3722         https://bugs.webkit.org/show_bug.cgi?id=193141
3723         <rdar://problem/46174217>
3724
3725         Rubber-stamped by Aakash Jain.
3726
3727         * Scripts/webkitpy/xcode/simulated_device.py:
3728         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3729
3730 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3731
3732         test262-runner misbehaves when test file YAML has a trailing space
3733         https://bugs.webkit.org/show_bug.cgi?id=193053
3734
3735         Reviewed by Yusuke Suzuki.
3736
3737         * Scripts/test262/Runner.pm:
3738         (parseData):
3739         Accept trailing space when parsing a test file's YAML block.
3740
3741 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3742
3743         UserMedia test should use WKPageNavigationClient
3744         https://bugs.webkit.org/show_bug.cgi?id=192913
3745
3746         Reviewed by Youenn Fablet.
3747
3748         The test currently uses the deprecated WKPageLoaderClient. It should use
3749         WKPageNavigationClient instead, which provides the same callback under a similar name.
3750
3751         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3752         (TestWebKitAPI::TEST):
3753
3754 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3755
3756         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3757         https://bugs.webkit.org/show_bug.cgi?id=192944
3758
3759         Reviewed by Tim Horton.
3760
3761         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3762         (TestWebKitAPI::TEST):
3763
3764 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3765
3766         Add support for using the current text selection as the find string on iOS
3767         https://bugs.webkit.org/show_bug.cgi?id=193034
3768         <rdar://problem/45138739>
3769
3770         Reviewed by Tim Horton.
3771
3772         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3773         _setStringForFind) works as expected.
3774
3775         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3776         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3777
3778 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3779
3780         [ews-build] Use git on OpenSource EWS bots
3781         https://bugs.webkit.org/show_bug.cgi?id=193092
3782
3783         Reviewed by Lucas Forschler.
3784
3785         * BuildSlaveSupport/ews-build/steps.py:
3786         (CheckOutSource): Use git instead of svn.
3787         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3788
3789 2019-01-02  Daniel Bates  <dabates@apple.com>
3790
3791         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3792         https://bugs.webkit.org/show_bug.cgi?id=193023
3793
3794         Reviewed by Simon Fraser.
3795
3796         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3797         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3798         enumerator values. We should just remove this code.
3799
3800         * lldb/lldb_webkit.py:
3801         (WTFOptionSetProvider.has_children):
3802         (WTFOptionSetProvider.num_children):
3803         (WTFOptionSetProvider.get_child_index):
3804         (WTFOptionSetProvider.get_child_at_index):
3805
3806 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3807
3808         .ycm_extra_conf.py should handle XXXInlines.h
3809         https://bugs.webkit.org/show_bug.cgi?id=193055
3810
3811         Reviewed by Carlos Garcia Campos.
3812
3813         compile_commands.json database only records flags and options for cpp source files.
3814         So, when we open headers, this database does not have any information for that.
3815         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3816         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3817         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3818         we attempt to find XXX.cpp and use the configuration if it exists.
3819
3820         * gtk/ycm_extra_conf.py:
3821         (getImplementationFilename):
3822         (FlagsForFile):
3823
3824 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3825
3826         Unreviewed. Support PHP 7.3 in Debian.
3827
3828         Add 7.3 to the list of php versions supported in Debian.
3829
3830         * Scripts/webkitpy/port/base.py:
3831         (Port._debian_php_version):
3832
3833 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3834
3835         Resurrect Mac CMake build
3836         https://bugs.webkit.org/show_bug.cgi?id=192658
3837
3838         Reviewed by Yusuke Suzuki.
3839
3840         * DumpRenderTree/PlatformMac.cmake:
3841         * MiniBrowser/mac/CMakeLists.txt:
3842         * TestWebKitAPI/PlatformMac.cmake:
3843
3844 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3845
3846         [Tools] Remove references to Bison and Flex
3847         https://bugs.webkit.org/show_bug.cgi?id=193033
3848
3849         Reviewed by Michael Catanzaro.
3850
3851         The Bison and Flex tools are not needed anymore since r209883.
3852
3853         * CygwinDownloader/cygwin-downloader.py:
3854         * EWSTools/ubuntu-ews-packages:
3855         * Scripts/filter-build-webkit:
3856         (shouldIgnoreLine):
3857         * gtk/install-dependencies:
3858         * wpe/install-dependencies:
3859
3860 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3861
3862         WebDriver: warn about non existing tests when parsing expectations
3863         https://bugs.webkit.org/show_bug.cgi?id=192979
3864
3865         Reviewed by Michael Catanzaro.
3866
3867         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
3868         renamed.
3869
3870         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3871         (WebDriverTestRunner.__init__):
3872
3873 2018-12-21  Chris Dumez  <cdumez@apple.com>
3874
3875         navigator.userAgent in service workers does not reflect customUserAgent set by client
3876         https://bugs.webkit.org/show_bug.cgi?id=192951
3877
3878         Reviewed by Youenn Fablet.
3879
3880         Extend API test coverage.
3881
3882         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3883         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
3884         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3885         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
3886         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3887
3888 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3889
3890         [WebAuthN] userPresence should always be true
3891         https://bugs.webkit.org/show_bug.cgi?id=192835
3892         <rdar://problem/46538788>
3893
3894         Reviewed by Brent Fulgham.
3895
3896         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3897         (TestWebKitAPI::TEST):
3898
3899 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
3900
3901         Add support to run-benchmark to use non-default copies of the browser apps
3902         https://bugs.webkit.org/show_bug.cgi?id=192905
3903         rdar://problem/46845840
3904
3905         Reviewed by Dewei Zhu.
3906         
3907         Add support for a --browser-path argument to run-benchmark, which allows you to use
3908         a custom app bundle for a given browser (only implemented for Safari at present).
3909
3910         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3911         (BenchmarkRunner.__init__):
3912         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3913         (BrowserDriver.__init__):
3914         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3915         (BrowserDriverFactory.create):
3916         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3917         (OSXBrowserDriver._launch_process):
3918         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
3919         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
3920         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3921         (OSXChromeCanaryDriver.launch_url):
3922         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3923         (OSXFirefoxNightlyDriver.launch_url):
3924         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3925         (OSXSafariDriver.__init__):
3926         (OSXSafariDriver.launch_url):
3927         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3928         (parse_args):
3929         (run_benchmark_plan):
3930         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3931         (WebServerBenchmarkRunner.__init__):
3932         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
3933         (FakeBenchmarkRunner.__init__):
3934
3935 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3936
3937         [WebAuthN] Import an APDU coder from Chromium
3938         https://bugs.webkit.org/show_bug.cgi?id=192949
3939         <rdar://problem/46879933>
3940
3941         Reviewed by Brent Fulgham.
3942
3943         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3944         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
3945         (TestWebKitAPI::TEST):
3946
3947 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3948
3949         Setting the file wrapper and content type of an attachment to a PDF should update its image
3950         https://bugs.webkit.org/show_bug.cgi?id=192984
3951         <rdar://problem/46798028>
3952
3953         Reviewed by Tim Horton.
3954
3955         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
3956         PDF data correctly updates the image element.
3957
3958         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3959
3960 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3961
3962         Add JSCOnly to bot dashboard
3963         https://bugs.webkit.org/show_bug.cgi?id=192964
3964
3965         Reviewed by Alexey Proskuryakov.
3966
3967         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
3968         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
3969         useful if they were not so secret, so add them.
3970
3971         There appear to be no build-only bots, so the first column is blank. And of course there are
3972         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
3973         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
3974         and there's plenty of room in the final column for all the bots.
3975
3976         I had a hard time picking a logo to use, because the JavaScript language does not have an
3977         official logo. But I believe I've found one that will be satisfactory.
3978
3979         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
3980
3981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
3982         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
3983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3984         (BubbleQueueServer):
3985         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3986         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3987         (WebKitBuildbot):
3988         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3989         (table.queue-grid tr.platform.linux-jsconly img.logo):
3990
3991 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
3992
3993         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3994         https://bugs.webkit.org/show_bug.cgi?id=192821
3995
3996         Reviewed by Chris Dumez.
3997
3998         * DumpRenderTree/mac/DumpRenderTree.mm:
3999         (createWebViewAndOffscreenWindow):
4000         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
4001
4002 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
4003
4004         [Win][Clang] Fix compilation warnings of DumpRenderTree
4005         https://bugs.webkit.org/show_bug.cgi?id=192924
4006
4007         Reviewed by Alex Christensen.
4008
4009         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
4010         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4011         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
4012         * DumpRenderTree/win/DumpRenderTree.cpp:
4013         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
4014         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
4015         object to the argument of setDefaultTextEncodingName instead of a
4016         const string literal.
4017         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
4018         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
4019         (setCacheFolder): Deleted.
4020         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
4021         * DumpRenderTree/win/EditingDelegate.cpp:
4022         (dump): Use %d for int.
4023         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
4024         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4025         (BSTRFromString): Deleted unused function.
4026         * DumpRenderTree/win/TestRunnerWin.cpp:
4027         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
4028         the arguemnt of setQuota instead of const string literal.
4029         * DumpRenderTree/win/WorkQueueItemWin.cpp:
4030         (jsStringRefToWString): Deleted unused function.
4031
4032 2018-12-20  Chris Dumez  <cdumez@apple.com>
4033
4034         Add API test coverage for customUserAgent client setting and service workers
4035         https://bugs.webkit.org/show_bug.cgi?id=192952
4036
4037         Reviewed by Alex Christensen.
4038
4039         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4040         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
4041         (-[SWSchemes webView:startURLSchemeTask:]):
4042         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4043         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
4044
4045 2018-12-20  Chris Dumez  <cdumez@apple.com>
4046
4047         Use Optional::hasValue() instead of Optional::has_value()
4048         https://bugs.webkit.org/show_bug.cgi?id=192948
4049
4050         Reviewed by Tim Horton.
4051
4052         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
4053         (TestWebKitAPI::TEST):
4054         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
4055         (TestWebKitAPI::TEST):
4056         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
4057         (TestWebKitAPI::TEST_F):
4058
4059 2018-12-20  Chris Dumez  <cdumez@apple.com>
4060
4061         Add style script rule to check for uses of std::optional<>
4062         https://bugs.webkit.org/show_bug.cgi?id=192931
4063
4064         Reviewed by Tim Horton.
4065
4066         * Scripts/webkitpy/style/checkers/cpp.py:
4067         (check_wtf_optional):
4068         (check_style):
4069
4070 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
4071
4072         [WebAuthN] Add a runtime flag for local authenticator
4073         https://bugs.webkit.org/show_bug.cgi?id=192792
4074         <rdar://problem/46798738>
4075
4076         Reviewed by Brent Fulgham.
4077
4078         * DumpRenderTree/TestOptions.cpp:
4079         (TestOptions::TestOptions):
4080         * DumpRenderTree/TestOptions.h:
4081         * DumpRenderTree/mac/DumpRenderTree.mm:
4082         (enableExperimentalFeatures):
4083         (setWebPreferencesForTestOptions):
4084         * WebKitTestRunner/TestController.cpp:
4085         (WTR::TestController::resetPreferencesToConsistentValues):
4086         (WTR::updateTestOptionsFromTestHeader):
4087         * WebKitTestRunner/TestOptions.h:
4088         (WTR::TestOptions::hasSameInitializationOptions const):
4089
4090 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
4091
4092         webkitpy: Autoinstall package URLs have changed
4093         https://bugs.webkit.org/show_bug.cgi?id=192909
4094         <rdar://problem/46860359>
4095
4096         Rubber-stamped by Alexey Proskuryakov.
4097
4098         PyPi urls have been moved around, we need to update our auto-installed packages.
4099
4100         We should check for Selenium before asking PyPi for the latest version.
4101
4102         * Scripts/webkitpy/thirdparty/__init__.py:
4103         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
4104         (AutoinstallImportHook._install_keyring): Ditto.
4105         (AutoinstallImportHook._install_pep8): Ditto.
4106         (AutoinstallImportHook._install_mozlog): Ditto.
4107         (AutoinstallImportHook._install_mozprocess): Ditto.
4108         (AutoinstallImportHook._install_pytest_timeout): Ditto.
4109         (AutoinstallImportHook._install_pytest): Ditto.
4110         (AutoinstallImportHook._install_pylint): Ditto.
4111         (AutoinstallImportHook._install_buildbot): Ditto.
4112         (AutoinstallImportHook._install_coverage): Ditto.
4113         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
4114         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
4115         for new Selenium if the installed version isn't sufficient.
4116         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
4117
4118 2018-12-20  Chris Dumez  <cdumez@apple.com>
4119
4120         Use Optional::valueOr() instead of Optional::value_or()
4121         https://bugs.webkit.org/show_bug.cgi?id=192933
4122
4123         Reviewed by Geoffrey Garen.
4124
4125         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
4126         (TestWebKitAPI::checkURL):
4127         (TestWebKitAPI::checkRelativeURL):
4128         (TestWebKitAPI::checkURLDifferences):
4129         (TestWebKitAPI::checkRelativeURLDifferences):
4130         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
4131         (TestWebKitAPI::checkURL):
4132
4133 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
4134
4135         Unreviewed, rolling out r239417.
4136
4137         Introduced two API test failures on macOS.
4138
4139         Reverted changeset:
4140
4141         "<rdar://problem/46194315> macOS: WebKit1 does not handle
4142         occlusion changes"
4143         https://bugs.webkit.org/show_bug.cgi?id=192821
4144         https://trac.webkit.org/changeset/239417
4145
4146 2018-12-20  Devin Rousso  <drousso@apple.com>
4147
4148         Web Inspector: UIString should take an optional key and description to aid localization
4149         https://bugs.webkit.org/show_bug.cgi?id=153962
4150         <rdar://problem/24542505>
4151
4152         Reviewed by Brian Burg.
4153
4154         * Scripts/extract-localizable-js-strings:
4155
4156 2018-12-20  Tim Horton  <timothy_horton@apple.com>
4157
4158         Unparented WKWebView can't retrieve main resource data for a main frame plugin
4159         https://bugs.webkit.org/show_bug.cgi?id=192923
4160         <rdar://problem/46859068>
4161
4162         Reviewed by Wenson Hsieh.
4163
4164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4165         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
4166         Add a test ensuring that both parented and unparented WKWebViews can
4167         retrieve main resource data when loading a PDF.
4168
4169 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
4170
4171         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
4172         https://bugs.webkit.org/show_bug.cgi?id=192852
4173
4174         Reviewed by Michael Catanzaro.
4175
4176         EmojiOne font was replaced by Noto Color Emoji.
4177
4178         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
4179         * gtk/jhbuild.modules:
4180         * wpe/jhbuild.modules:
4181
4182 2018-12-19  Chris Dumez  <cdumez@apple.com>
4183
4184         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
4185         https://bugs.webkit.org/show_bug.cgi?id=192728
4186         <rdar://problem/46746779>
4187
4188         Reviewed by Geoff Garen.
4189
4190         * DumpRenderTree/*:
4191         * MiniBrowser/*:
4192         * TestRunnerShared/*:
4193         * TestWebKitAPI/*:
4194         * WebGPUAPIStructure/*:
4195         * WebKitTestRunner/*:
4196
4197 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
4198
4199         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
4200         https://bugs.webkit.org/show_bug.cgi?id=192821
4201
4202         Reviewed by Chris Dumez.
4203
4204         * DumpRenderTree/mac/DumpRenderTree.mm:
4205         (createWebViewAndOffscreenWindow):
4206
4207 2018-12-19  Alex Christensen  <achristensen@webkit.org>
4208
4209         Navigations away from the SafeBrowsing interstitial show a flash of old content
4210         https://bugs.webkit.org/show_bug.cgi?id=192676
4211
4212         Reviewed by Chris Dumez.
4213
4214         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4215         (safeBrowsingView):
4216         (TEST):
4217         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
4218
4219 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
4220
4221         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
4222         https://bugs.webkit.org/show_bug.cgi?id=192855
4223
4224         Reviewed by Michael Catanzaro.
4225
4226         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4227         (WTR::TestController::notifyDone): Use the WPE implementation.
4228         (WTR::TestController::platformRunUntil): Use the WPE implementation.
4229         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
4230         (WTR::TestController::platformRunUntil): Honor the condition flag.
4231
4232 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
4233
4234         Allow clients to set the navigator platform
4235         https://bugs.webkit.org/show_bug.cgi?id=192735
4236
4237         Reviewed by Tim Horton.
4238
4239         Add a test for setting a custom navigator platform.
4240
4241         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4242         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4243         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
4244
4245 2018-12-19  Truitt Savell  <tsavell@apple.com>
4246
4247         Unreviewed, rolling out r239358.
4248
4249         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
4250         crash on Debug bots
4251
4252         Reverted changeset:
4253
4254         "Clean up IndexedDB files between tests"
4255         https://bugs.webkit.org/show_bug.cgi?id=192796
4256         https://trac.webkit.org/changeset/239358
4257
4258 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4259
4260         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
4261         https://bugs.webkit.org/show_bug.cgi?id=192842
4262         <rdar://problem/46823586>
4263
4264         Reviewed by Tim Horton.
4265
4266         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
4267         item provider when dragging a rich text selection.
4268
4269         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4270
4271 2018-12-18  David Quesada  <david_quesada@apple.com>
4272
4273         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
4274         https://bugs.webkit.org/show_bug.cgi?id=192810
4275         <rdar://problem/46812536>
4276
4277         Reviewed by Alex Christensen.
4278
4279         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4280         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
4281             After releasing our reference to the web view, wait until the next turn of the runloop
4282             before checking that the originatingWebView has been zeroed, since the web view might
4283             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
4284             testing general memory management of WKWebViews, only that _WKDownload does not retain
<