Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-15  Chris Dumez  <cdumez@apple.com>
2
3         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4         https://bugs.webkit.org/show_bug.cgi?id=195102
5         <rdar://problem/48456786>
6
7         Reviewed by Alex Christensen.
8
9         Try to wait longer for the number of processes to reach the expected number
10         and before failing.
11
12         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
13
14 2019-05-15  Alex Christensen  <achristensen@webkit.org>
15
16         Allow NSFileCoordinator to be called from WebContent process
17         https://bugs.webkit.org/show_bug.cgi?id=197895
18         <rdar://problem/50107679>
19
20         Reviewed by Brent Fulgham.
21
22         Add a unit test that verifies calling the block succeeds.
23
24         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
25         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
26
27 2019-05-14  Andy Estes  <aestes@apple.com>
28
29         [Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
30         https://bugs.webkit.org/show_bug.cgi?id=197751
31         <rdar://problem/50631563>
32
33         Reviewed by Alex Christensen.
34
35         Added new API tests.
36
37         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
38         (-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]):
39         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
40         (TestWebKitAPI::TEST):
41         (-[TestApplePayScriptMessageHandler initWithExpectation:]): Deleted.
42         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
43
44 2019-05-14  Youenn Fablet  <youenn@apple.com>
45
46         A service worker process should app nap when all its clients app nap
47         https://bugs.webkit.org/show_bug.cgi?id=185626
48         <rdar://problem/46785908>
49
50         Reviewed by Alex Christensen.
51
52         Allow to enable app nap through test header.
53
54         * WebKitTestRunner/TestController.cpp:
55         (WTR::TestController::resetPreferencesToConsistentValues):
56         (WTR::updateTestOptionsFromTestHeader):
57         * WebKitTestRunner/TestOptions.h:
58         (WTR::TestOptions::hasSameInitializationOptions const):
59
60 2019-05-14  Commit Queue  <commit-queue@webkit.org>
61
62         Unreviewed, rolling out r245281.
63         https://bugs.webkit.org/show_bug.cgi?id=197887
64
65         Broke API Test TestWebKitAPI.Challenge.ClientCertificate
66         (Requested by aakashjain on #webkit).
67
68         Reverted changeset:
69
70         "Add a unit test for client certificate authentication"
71         https://bugs.webkit.org/show_bug.cgi?id=197800
72         https://trac.webkit.org/changeset/245281
73
74 2019-05-14  Youenn Fablet  <youenn@apple.com>
75
76         Add support for webkit-test-runner options to WPT importer
77         https://bugs.webkit.org/show_bug.cgi?id=197826
78
79         Reviewed by Alex Christensen.
80
81         In case of overwriting an existing test, check if the existing test
82         contains a <!-- webkit-test-runner --> comment and insert it back if
83         needed in the new test.
84
85         For exporter, forbid creating a WPT PR if there are changes containing
86         the webkit-test-runner string.
87
88         * Scripts/webkitpy/w3c/test_converter.py:
89         (convert_for_webkit):
90         (_W3CTestConverter.__init__):
91         (_W3CTestConverter.add_webkit_test_runner_options_if_needed):
92         (_W3CTestConverter.handle_starttag):
93         (_W3CTestConverter.handle_comment):
94         (_W3CTestConverter.handle_decl):
95         (_W3CTestConverter.handle_pi):
96         * Scripts/webkitpy/w3c/test_exporter.py:
97         (WebPlatformTestExporter.write_git_patch_file):
98         (WebPlatformTestExporter.make_pull_request):
99         * Scripts/webkitpy/w3c/test_importer.py:
100         (TestImporter.webkit_test_runner_options):
101         (TestImporter):
102         (TestImporter.add_webkit_test_runner_options_to_content):
103         (TestImporter.copy_html_file):
104         (TestImporter.write_html_template):
105         (TestImporter.write_html_files_for_templated_js_tests):
106         (TestImporter.import_tests):
107         * Scripts/webkitpy/w3c/test_importer_unittest.py:
108         (test_manual_slow_test):
109         (test_webkit_test_runner_options):
110
111 2019-05-14  Aakash Jain  <aakash_jain@apple.com>
112
113         [ews-app] Status bubble should turn orange when any build step fails
114         https://bugs.webkit.org/show_bug.cgi?id=197812
115
116         Reviewed by Jonathan Bedard.
117
118         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
119         (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
120         (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
121
122 2019-05-14  Alex Christensen  <achristensen@webkit.org>
123
124         Add a unit test for client certificate authentication
125         https://bugs.webkit.org/show_bug.cgi?id=197800
126
127         Reviewed by Youenn Fablet.
128
129         Make better abstractions for reading and writing from/to TCPServer.
130         Add a unit test that causes a client certificate authentication challenge to happen.
131
132         * TestWebKitAPI/TCPServer.cpp:
133         (TestWebKitAPI::TCPServer::TCPServer):
134         (TestWebKitAPI::TCPServer::read):
135         (TestWebKitAPI::TCPServer::write):
136         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
137         (TestWebKitAPI::TCPServer::respondWithOK):
138         * TestWebKitAPI/TCPServer.h:
139         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
140         (credentialWithIdentity):
141         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
142         (TEST):
143         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
144         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
145         (-[ClientCertificateDelegate challengeCount]):
146         (TestWebKitAPI::TEST):
147         (respondWithChallengeThenOK): Deleted.
148         (credentialWithIdentityAndKeychainPath): Deleted.
149         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
150         (TEST):
151         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
152         (TestWebKitAPI::TEST):
153         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
154         (TEST):
155         (readRequest): Deleted.
156         (writeResponse): Deleted.
157         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
158         (TestWebKitAPI::TEST):
159         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
160
161 2019-05-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
162
163         [CG] Adding support for HEIF-sequence ('public.heics') images
164         https://bugs.webkit.org/show_bug.cgi?id=197384
165
166         Reviewed by Simon Fraser.
167
168         * DumpRenderTree/TestOptions.cpp:
169         (TestOptions::TestOptions):
170         * DumpRenderTree/TestOptions.h:
171         * DumpRenderTree/mac/DumpRenderTree.mm:
172         (resetWebViewToConsistentStateBeforeTesting):
173         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
174         Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
175         the test.
176
177         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
178         (WTR::InjectedBundle::stringForKey):
179         (WTR::InjectedBundle::beginTesting):
180         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
181         * WebKitTestRunner/TestController.cpp:
182         (WTR::TestController::resetStateToConsistentValues):
183         (WTR::updateTestOptionsFromTestHeader):
184         * WebKitTestRunner/TestInvocation.cpp:
185         (WTR::TestInvocation::createTestSettingsDictionary):
186         * WebKitTestRunner/TestOptions.h:
187         (WTR::TestOptions::hasSameInitializationOptions const):
188         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
189         Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
190         the test.
191
192 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
193
194         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
195         https://bugs.webkit.org/show_bug.cgi?id=197730
196
197         Reviewed by Filip Pizlo.
198
199         * TestWebKitAPI/CMakeLists.txt:
200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
201         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
202         (TestWebKitAPI::TEST):
203         * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
204         (TestWebKitAPI::TEST):
205
206 2019-05-10  Chris Dumez  <cdumez@apple.com>
207
208         Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
209
210         It became flaky after r245198.
211
212         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
213
214 2019-05-10  Youenn Fablet  <youenn@apple.com>
215
216         A service worker instance should be terminated when its SWServer is destroyed
217         https://bugs.webkit.org/show_bug.cgi?id=197801
218         <rdar://problem/50587270>
219
220         Reviewed by Chris Dumez.
221
222         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
223
224 2019-05-10  Chris Dumez  <cdumez@apple.com>
225
226         Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
227         https://bugs.webkit.org/show_bug.cgi?id=197750
228
229         Reviewed by Geoffrey Garen.
230
231         Add API test coverage.
232
233         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
234         (TEST):
235
236 2019-05-10  Keith Miller  <keith_miller@apple.com>
237
238         Remove legacy test262 import script
239         https://bugs.webkit.org/show_bug.cgi?id=197788
240
241         Reviewed by Yusuke Suzuki.
242
243         import-test262-tests doesn't work anymore. We should be using test262-import instead.
244
245         * Scripts/import-test262-tests: Removed.
246
247 2019-05-10  Charlie Turner  <cturner@igalia.com>
248
249         [WPE] Forward libepoxy cflags
250         https://bugs.webkit.org/show_bug.cgi?id=197784
251
252         Reviewed by Žan Doberšek.
253
254         Patch by Zan Dobersek.
255
256         * wpe/backends/CMakeLists.txt: This is required to keep
257         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
258         up trying to include X11 headers even when they're not present in the
259         environment.
260
261 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
262
263         Fix a bunch of compiler warnings
264         https://bugs.webkit.org/show_bug.cgi?id=197785
265
266         Reviewed by Don Olmstead.
267
268         Add preprocessor guards to avoid -Wunused-function warnings.
269
270         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
271         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
272         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
273
274 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
275
276         [WPE][GTK] Add webkit_frame_get_id() API
277         https://bugs.webkit.org/show_bug.cgi?id=197270
278
279         Reviewed by Carlos Garcia Campos.
280
281         This was hard, but I added a test to verify that two different WebKitFrames of the same
282         WebKitWebPage return two different frame IDs.
283
284         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
285         (WebKitFrameTest::willSubmitFormCallback):
286         (WebKitFrameTest::testSubframe):
287         (registerTests):
288         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
289         (testWebKitFrameSubframe):
290         (beforeAll):
291         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
292         (willSubmitFormCallback):
293         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
294         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
295
296 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
297
298         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
299         https://bugs.webkit.org/show_bug.cgi?id=197271
300
301         Reviewed by Youenn Fablet.
302
303         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
304         (formControlsAssociatedForFrameCallback):
305         (pageCreatedCallback):
306         (formControlsAssociatedCallback): Deleted.
307
308 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
309
310         [Flatpak] Use the safe PyYAML loader if available
311         https://bugs.webkit.org/show_bug.cgi?id=197771
312
313         Reviewed by Philippe Normand.
314
315         * flatpak/flatpakutils.py:
316         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
317         still used as fallback when the former is not provided by the module.
318
319 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
320
321         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
322         https://bugs.webkit.org/show_bug.cgi?id=197734
323
324         Reviewed by Don Olmstead.
325
326         * Scripts/webkitpy/port/win.py:
327         (WinCairoPort._search_paths): Add 'wk2' and
328         additional_platform_directory to paths as well as other ports do.
329
330 2019-05-09  Daniel Bates  <dabates@apple.com>
331
332         [iOS] Numpad comma key has incorrect keyIdentifier property
333         https://bugs.webkit.org/show_bug.cgi?id=197753
334         <rdar://problem/50636274>
335
336         Reviewed by Brent Fulgham.
337
338         Recognize "numpadComma" and return the appropriate HID usage code.
339
340         * WebKitTestRunner/ios/HIDEventGenerator.mm:
341         (hidUsageCodeForCharacter):
342
343 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
344
345         Refine AudioSession route sharing policy
346         https://bugs.webkit.org/show_bug.cgi?id=197742
347         <rdar://problem/50590818>
348
349         Reviewed by Darin Adler.
350
351         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
352         (TestWebKitAPI::TEST):
353
354 2019-05-09  Alex Christensen  <achristensen@webkit.org>
355
356         Remove unnecessary test SPI after r244883
357         https://bugs.webkit.org/show_bug.cgi?id=197575
358
359         Reviewed by Tim Horton.
360
361         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
362         (TEST):
363         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
364         (TestWebKitAPI::TEST):
365
366 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
367
368         [ews-app] Add migrations file to repository
369         https://bugs.webkit.org/show_bug.cgi?id=197729
370
371         Reviewed by Jonathan Bedard.
372
373         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
374
375 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
376
377         [ews-build] Fix formatting issues and typos
378         https://bugs.webkit.org/show_bug.cgi?id=197737
379
380         Reviewed by Jonathan Bedard.
381
382         * BuildSlaveSupport/ews-build/steps.py:
383         (CompileWebKit.evaluateCommand): Removed extra empty line.
384         * BuildSlaveSupport/ews-build/steps_unittest.py:
385         (TestRunWebKitPerlTests): Fixed typo.
386         * BuildSlaveSupport/ews-app/ews/models/step.py:
387         (Step.save_step): Changed log level to info so that it is logged in production.
388
389 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
390
391         [ews-app] Production and Development env should configure DEBUG appropriately
392         https://bugs.webkit.org/show_bug.cgi?id=197700
393
394         Reviewed by Jonathan Bedard.
395
396         * BuildSlaveSupport/ews-app/ews-app/settings.py:
397
398 2019-05-09  Xan López  <xan@igalia.com>
399
400         [CMake] Detect SSE2 at compile time
401         https://bugs.webkit.org/show_bug.cgi?id=196488
402
403         Reviewed by Carlos Garcia Campos.
404
405         * Scripts/webkitdirs.pm:
406         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
407         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
408
409 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
410
411         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
412         https://bugs.webkit.org/show_bug.cgi?id=197697
413
414         Reviewed by Žan Doberšek.
415
416         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
417         * wpe/jhbuild.modules: Ditto.
418
419 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
420
421         Update ANGLE
422         https://bugs.webkit.org/show_bug.cgi?id=197676
423
424         Reviewed by Alex Christensen.
425
426         * TestWebKitAPI/PlatformWin.cmake:
427         Remove unnecessary library linkage.
428
429 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
430
431         [Win] build-webkit should be ready for Visual Studio 2019
432         https://bugs.webkit.org/show_bug.cgi?id=196622
433
434         Reviewed by Ross Kirsling.
435
436         1. Accommodated to the new msbuild.exe location of VS 2019.
437         2. Removed the hard coded "Visual Studio 15" generator.
438
439         build-webkit is going to choose a Visual Studio generator version
440         matching with the latest installed VS. If you invoke vcvars.bat
441         before build-webkit, it chooses the corresponding Visual Studio
442         generator version by cheking 'VisualStudioVersion' env var which
443         is set by vcvars.bat.
444
445         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
446         (msBuildPath): When looking for MSBuild, look in
447         "MSBuild\Current\bin" (the new expected location) and fallback
448         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
449         first location.
450         (msBuildInstallDir): Renamed to msBuildPath.
451         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
452         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
453
454 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
455
456         [PlayStation] Update port options
457         https://bugs.webkit.org/show_bug.cgi?id=197723
458
459         Reviewed by Ross Kirsling.
460
461         ICU headers were missing from TestWTF.
462
463         * TestWebKitAPI/PlatformPlayStation.cmake:
464
465 2019-05-08  Alex Christensen  <achristensen@webkit.org>
466
467         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
468         https://bugs.webkit.org/show_bug.cgi?id=197712
469         <rdar://problem/50429770>
470
471         Reviewed by Tim Horton.
472
473         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
474         (TestWebKitAPI::TEST):
475
476 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
477
478         Change my status to be a WebKit reviewer.
479
480         * Scripts/webkitpy/common/config/contributors.json:
481
482 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
483
484         Unreviewed, rolling out r244952.
485
486         Caused inspector to appear blank.
487
488         Reverted changeset:
489
490         "Web Inspector: Provide UIString descriptions to improve
491         localizations"
492         https://bugs.webkit.org/show_bug.cgi?id=195132
493         https://trac.webkit.org/changeset/244952
494
495 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
496
497         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
498         https://bugs.webkit.org/show_bug.cgi?id=197685
499
500         Reviewed by Alex Christensen.
501
502         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
503         completion. See LayoutTests/ChangeLog for more details.
504
505         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
506         (WTR::UIScriptController::platformClearAllCallbacks):
507
508 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
509
510         Unreviewed. Add myself as a committer.
511
512         * Scripts/webkitpy/common/config/contributors.json:
513
514 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
515
516         Unreviewed, rolling out r245038.
517
518         Breaks internal builds.
519
520         Reverted changeset:
521
522         "Add SPI to set a list of hosts to which to send custom header
523         fields cross-origin"
524         https://bugs.webkit.org/show_bug.cgi?id=197397
525         https://trac.webkit.org/changeset/245038
526
527 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
528
529         Unreviewed. Add myself as a committer.
530
531         * Scripts/webkitpy/common/config/contributors.json:
532
533 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
534
535         Define media buffering policy
536         https://bugs.webkit.org/show_bug.cgi?id=196979
537         <rdar://problem/28383861>
538
539         Reviewed by Jer Noble.
540
541         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
542         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
543         (waitUntilBufferingPolicyIsEqualTo):
544         (TEST):
545
546 2019-05-07  Alex Christensen  <achristensen@webkit.org>
547
548         Add SPI to set a list of hosts to which to send custom header fields cross-origin
549         https://bugs.webkit.org/show_bug.cgi?id=197397
550
551         Reviewed by Geoff Garen.
552
553         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
554         (TEST):
555         (expectLegacyHeaders):
556         (expectHeaders):
557         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
558         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
559         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
560
561 2019-05-07  Keith Rollin  <krollin@apple.com>
562
563         Add option to build-webkit to control whether or not XCBuild is used
564         https://bugs.webkit.org/show_bug.cgi?id=197668
565         <rdar://problem/50549728>
566
567         Reviewed by Tim Horton.
568
569         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
570         Also update build-webkit and the makefiles with the foundation for
571         automatically using XCBuild when the conditions allow it. This latter
572         facility is currently turned off until Xcode fully supports building
573         WebKit with XCBuild.
574
575         * Scripts/build-webkit:
576         * Scripts/webkitdirs.pm:
577         (XcodeOptions):
578         (canUseXCBuild):
579
580 2019-05-07  Andy Estes  <aestes@apple.com>
581
582         run-bindings-tests should test global scope constructor generation
583         https://bugs.webkit.org/show_bug.cgi?id=197669
584
585         Reviewed by Alex Christensen.
586
587         * Scripts/webkitpy/bindings/main.py:
588         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
589         invoking preprocess-idls.pl.
590
591 2019-05-07  Youenn Fablet  <youenn@apple.com>
592
593         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
594         https://bugs.webkit.org/show_bug.cgi?id=195997
595         <rdar://problem/50509884>
596
597         Reviewed by Chris Dumez.
598
599         Spin test until successful.
600
601         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
602
603 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
604
605         [Flatpak] webkit-build fails due to missing GTK2 in build environment
606         https://bugs.webkit.org/show_bug.cgi?id=197352
607
608         Reviewed by Philippe Normand.
609
610         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
611         to build it ourselves on top in order to be able to build the GTK 2.x plugin
612         process.
613
614         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
615
616 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
617
618         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
619         https://bugs.webkit.org/show_bug.cgi?id=197644
620         <rdar://problem/50526364>
621
622         Reviewed by Tim Horton.
623
624         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
625
626         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
627         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
628         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
629         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
630
631 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
632
633         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
634         https://bugs.webkit.org/show_bug.cgi?id=197651
635
636         Reviewed by Žan Doberšek.
637
638         This is required since the process creation was delayed until something is loaded in the view.
639
640         * MiniBrowser/gtk/BrowserWindow.c:
641         (browser_window_get_or_create_web_view_for_automation):
642         * MiniBrowser/wpe/main.cpp:
643         (main):
644
645 2019-05-06  Tim Horton  <timothy_horton@apple.com>
646
647         _overrideViewportWithArguments does not work when called before loading
648         https://bugs.webkit.org/show_bug.cgi?id=197638
649         <rdar://problem/50505111>
650
651         Reviewed by Wenson Hsieh.
652
653         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
654         (TEST):
655
656 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
657
658         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
659         https://bugs.webkit.org/show_bug.cgi?id=197510
660
661         Reviewed by Alex Christensen.
662
663         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
664         (TestWebKitAPI::TEST):
665
666 2019-05-06  Keith Rollin  <krollin@apple.com>
667
668         Temporarily disable generate-xcfilelists
669         https://bugs.webkit.org/show_bug.cgi?id=197619
670         <rdar://problem/50507392>
671
672         Reviewed by Alex Christensen.
673
674         We need to perform a significant update to the generate-xcfilelist
675         scripts. This work involves coordinated work with another facility. If
676         the work does not occur in tandem, the build will be broken. To avoid
677         this, disable the invoking of the scripts during the transition. The
678         checking will be restored once the new scripts are in place.
679
680         * DumpRenderTree/Scripts/check-xcfilelists.sh:
681         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
682
683 2019-05-04  Alex Christensen  <achristensen@webkit.org>
684
685         Revert r244953 and r244954 because they broke internal builds.
686         https://bugs.webkit.org/show_bug.cgi?id=197534
687
688         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
689         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
690         * DumpRenderTree/mac/DumpRenderTree.mm:
691         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
692         * DumpRenderTree/mac/TestRunnerMac.mm:
693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
694         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
695         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
696         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
697         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
698         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
699         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
700         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
701         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
702         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
703         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
704         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
705         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
706         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
707         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
708         * TestWebKitAPI/cocoa/TestWKWebView.mm:
709         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
710         * TestWebKitAPI/ios/UIKitSPI.h: Added.
711         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
712         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
713         * WebKitTestRunner/ios/HIDEventGenerator.h:
714         * WebKitTestRunner/ios/HIDEventGenerator.mm:
715         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
716         * WebKitTestRunner/ios/TestControllerIOS.mm:
717         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
718         * WebKitTestRunner/ios/mainIOS.mm:
719
720 2019-05-04  Alex Christensen  <achristensen@webkit.org>
721
722         Merge the three UIKitSPI.h files into a single one in PAL
723         https://bugs.webkit.org/show_bug.cgi?id=197534
724
725         Reviewed by Darin Adler.
726
727         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
728         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
729         * DumpRenderTree/mac/DumpRenderTree.mm:
730         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
731         * DumpRenderTree/mac/TestRunnerMac.mm:
732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
733         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
734         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
735         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
736         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
737         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
738         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
739         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
740         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
741         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
742         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
743         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
744         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
745         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
746         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
747         * TestWebKitAPI/cocoa/TestWKWebView.mm:
748         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
749         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
750         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
751         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
752         * WebKitTestRunner/ios/HIDEventGenerator.h:
753         * WebKitTestRunner/ios/HIDEventGenerator.mm:
754         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
755         * WebKitTestRunner/ios/TestControllerIOS.mm:
756         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
757         * WebKitTestRunner/ios/mainIOS.mm:
758
759 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
760
761         Web Inspector: Provide UIString descriptions to improve localizations
762         https://bugs.webkit.org/show_bug.cgi?id=195132
763         <rdar://problem/48457817>
764
765         Reviewed by Devin Rousso.
766
767         Allow WI.UIString to take:
768         - WI.UIString(string, key, comment)
769         - WI.UIString(string, comment)
770         - WI.UIString(string)
771
772         * Scripts/extract-localizable-js-strings:
773
774 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
775
776         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
777         https://bugs.webkit.org/show_bug.cgi?id=197579
778
779         Reviewed by Tim Horton.
780
781         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
782         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
783         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
784         ensure that the the focused element has been blurred.
785
786         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
787
788 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
789
790         Add a tool to block spammer accounts
791         https://bugs.webkit.org/show_bug.cgi?id=197537
792
793         Reviewed by Darin Adler.
794
795         Usage: block-spammers email1 email2 ...
796
797         The tool finds and hides all bugs and comments from this account. Before any work
798         is done, these bugs and comments are displayed for confirmation.
799
800         * Scripts/block-spammers: Added.
801         (get_bugzilla_token):
802         (invalidate_bugzilla_token):
803         (get_user_info):
804         (get_user_info_self):
805         (can_use_this_tool):
806         (disable_user):
807         (get_bugs_created_by_user):
808         (get_bugs_commented_on_by_user):
809         (get_comments):
810         (hide_bug):
811         (hide_comments):
812         (ask_yes_no):
813         (sanitized_string):
814         (main):
815
816 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
817
818         run-apit-tests: Add --iterations and --repeat-each
819         https://bugs.webkit.org/show_bug.cgi?id=197563
820
821         Reviewed by Aakash Jain.
822
823         * Scripts/webkitpy/api_tests/manager.py:
824         (Manager.run): Add --iterations and --repeat-each/
825         * Scripts/webkitpy/api_tests/run_api_tests.py:
826         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
827
828 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
829
830         New EWS: Clicking on white bubble navigates to page with only bubbles
831         https://bugs.webkit.org/show_bug.cgi?id=197520
832
833         Reviewed by Lucas Forschler.
834
835         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
836
837 2019-05-03  Daniel Bates  <dabates@apple.com>
838
839         [lldb-webkit] Support adding pretty-printing for qualified types
840         https://bugs.webkit.org/show_bug.cgi?id=197518
841
842         Reviewed by Darin Adler.
843
844         Remove all "::"s from the name of the specified type when computing the name for the Python classes
845         that will provide summary and synthetic details as LLDB is not happy about registering such classes
846         when they contain :: in their name.
847
848         * lldb/lldb_webkit.py:
849         (addSummaryAndSyntheticFormattersForRawBitmaskType):
850
851 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
852
853         New EWS: patches on recently added queues listed as #1 for older bugs
854         https://bugs.webkit.org/show_bug.cgi?id=197496
855
856         Reviewed by Lucas Forschler.
857
858         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
859         (StatusBubble._build_bubble):
860         (StatusBubble._queue_position):
861
862 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
863
864         webkit-patch --no-review upload does not submit patch to New EWS
865         https://bugs.webkit.org/show_bug.cgi?id=197519
866         <rdar://problem/50424887>
867
868         Reviewed by Lucas Forschler.
869
870         * Scripts/webkitpy/tool/steps/submittoews.py:
871         (SubmitToEWS.run): Submit to both old and new EWS.
872         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
873         * Scripts/webkitpy/common/net/ewsserver.py: Added.
874         (EWSServer._server_url): Method to return server url.
875         (EWSServer._post_patch_to_ews): Method to post patch to ews.
876         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
877         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
878         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
879         * Scripts/webkitpy/common/net/statusserver_mock.py:
880         (MockStatusServer.submit_to_ews): Updated the log text.
881         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
882         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
883         * Scripts/webkitpy/tool/main.py:
884         (WebKitPatch.__init__): Initialize ews_server. 
885         * Scripts/webkitpy/tool/mocktool.py:
886         (MockTool.__init__): Ditto.
887
888 2019-05-03  Chris Dumez  <cdumez@apple.com>
889
890         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
891         https://bugs.webkit.org/show_bug.cgi?id=197574
892         <rdar://problem/50453181>
893
894         Reviewed by Tim Horton.
895
896         Add API test coverage.
897
898         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
899         (TEST):
900
901 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
902
903         [JSC] Generator CodeBlock generation should be idempotent
904         https://bugs.webkit.org/show_bug.cgi?id=197552
905
906         Reviewed by Keith Miller.
907
908         * Scripts/run-javascriptcore-tests:
909         (runJSCStressTests):
910         * Scripts/run-jsc-stress-tests:
911
912 2019-05-03  Commit Queue  <commit-queue@webkit.org>
913
914         Unreviewed, rolling out r244881.
915         https://bugs.webkit.org/show_bug.cgi?id=197559
916
917         Breaks compilation of jsconly on linux, breaking compilation
918         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
919         guijemont on #webkit).
920
921         Reverted changeset:
922
923         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
924         WEBKIT_COPY_FILES"
925         https://bugs.webkit.org/show_bug.cgi?id=197174
926         https://trac.webkit.org/changeset/244881
927
928 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
929
930         Unreviewed WPE build fix after r244898.
931
932         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
933         (WTR::TestController::abortModal): Add the missing (no-op) definition.
934
935 2019-05-02  Alex Christensen  <achristensen@webkit.org>
936
937         Mark U+01C0 as a homograph of U+006C
938         https://bugs.webkit.org/show_bug.cgi?id=197526
939         <rdar://problem/50301904>
940
941         Reviewed by Tim Horton.
942
943         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
944         (TestWebKitAPI::TEST):
945
946 2019-05-02  Chris Dumez  <cdumez@apple.com>
947
948         Add test coverage for <rdar://problem/49731231>
949         https://bugs.webkit.org/show_bug.cgi?id=196730
950         <rdar://problem/49731231>
951
952         Reviewed by Ryosuke Niwa.
953
954         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
955         to match DumpRenderTree.
956
957         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
958         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
959         (WTR::TestRunner::abortModal):
960         * WebKitTestRunner/InjectedBundle/TestRunner.h:
961         * WebKitTestRunner/TestController.cpp:
962         (WTR::TestController::runModal):
963         * WebKitTestRunner/TestController.h:
964         * WebKitTestRunner/TestInvocation.cpp:
965         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
966         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
967         (WTR::TestController::abortModal):
968         * WebKitTestRunner/ios/TestControllerIOS.mm:
969         (WTR::TestController::abortModal):
970         * WebKitTestRunner/mac/TestControllerMac.mm:
971         (WTR::TestController::abortModal):
972         * WebKitTestRunner/win/TestControllerWin.cpp:
973         (WTR::TestController::abortModal):
974
975 2019-05-02  Christopher Reid  <chris.reid@sony.com>
976
977         [CMake] Add support for LTO builds
978         https://bugs.webkit.org/show_bug.cgi?id=188986
979
980         Reviewed by Don Olmstead.
981
982         Add support to configure --lto-mode with cmake builds.
983
984         * Scripts/build-webkit:
985         * Scripts/webkitdirs.pm:
986         (generateBuildSystemFromCMakeProject):
987
988 2019-05-02  John Wilander  <wilander@apple.com>
989
990         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
991         https://bugs.webkit.org/show_bug.cgi?id=197521
992         <rdar://problem/49651503>
993
994         Reviewed by Brent Fulgham.
995
996         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
997         (TestWebKitAPI::TEST):
998            Added a test for host strings with leading dots since they are
999            often used for the domain attribute in cookies.
1000
1001 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
1002
1003         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1004         https://bugs.webkit.org/show_bug.cgi?id=197510
1005
1006         Reviewed by Alex Christensen.
1007
1008         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1009         (TestWebKitAPI::TEST):
1010
1011 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
1012
1013         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
1014         https://bugs.webkit.org/show_bug.cgi?id=197174
1015
1016         Reviewed by Alex Christensen.
1017
1018         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
1019
1020         * TestWebKitAPI/PlatformGTK.cmake:
1021         * TestWebKitAPI/PlatformWPE.cmake:
1022
1023 2019-05-02  Alex Christensen  <achristensen@webkit.org>
1024
1025         Build fix for internal branch.
1026
1027         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1028         RetainPtr.h was not explicitly included.
1029
1030 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
1031
1032         webkitpy: Ignore errors when shutting down an already shutdown simulator
1033         <https://bugs.webkit.org/show_bug.cgi?id=197514>
1034         <rdar://problem/50390247>
1035
1036         Reviewed by Lucas Forschler.
1037
1038         * Scripts/webkitpy/xcode/simulated_device.py:
1039         (SimulatedDevice._shut_down):
1040
1041 2019-05-02  Frederic Wang  <fwang@igalia.com>
1042
1043         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
1044         https://bugs.webkit.org/show_bug.cgi?id=196142
1045
1046         This patch introduces some experimental runtime flag to let users
1047         disable MathML features that are removed from MathML Core [1]. For now,
1048         these features are only disabled on GTK and WPE ports.
1049
1050         [1] https://mathml-refresh.github.io/mathml-core/
1051
1052         Reviewed by Rob Buis.
1053
1054         * DumpRenderTree/TestOptions.cpp:
1055         (TestOptions::TestOptions):
1056         * DumpRenderTree/TestOptions.h:
1057         * DumpRenderTree/mac/DumpRenderTree.mm:
1058         (setWebPreferencesForTestOptions):
1059
1060 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
1061
1062         TestWebKitAPI config.h should be aware of what suite is being built
1063         https://bugs.webkit.org/show_bug.cgi?id=196583
1064
1065         Reviewed by Konstantin Tokarev.
1066
1067         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
1068         benefit the macro defines BUILDING_* for the executable which allows the includes
1069         of the config.h to be tailored to the test suite being built. Because of that the
1070         dependencies of the Test* executable are specific to the test suite which may
1071         speed up the build.
1072
1073         Some source files were including "PlatformUtilities.h" which includes WebKit headers
1074         when "Utilities.h" is what was needed.
1075
1076         * TestWebKitAPI/CMakeLists.txt:
1077         * TestWebKitAPI/PlatformGTK.cmake:
1078         * TestWebKitAPI/PlatformJSCOnly.cmake:
1079         * TestWebKitAPI/PlatformMac.cmake:
1080         * TestWebKitAPI/PlatformPlayStation.cmake:
1081         * TestWebKitAPI/PlatformUtilities.h:
1082         * TestWebKitAPI/PlatformWPE.cmake:
1083         * TestWebKitAPI/PlatformWin.cmake:
1084         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1085         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1086         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1087         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
1088         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
1089         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
1090         * TestWebKitAPI/config.h:
1091
1092 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
1093
1094         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
1095         https://bugs.webkit.org/show_bug.cgi?id=181950
1096         <rdar://problem/43357371>
1097
1098         Reviewed by Brent Fulgham.
1099
1100         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1101         (TestWebKitAPI::TEST_F):
1102
1103 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1104
1105         Remove webkitpy and bindings EWS queues from dashboard
1106         https://bugs.webkit.org/show_bug.cgi?id=197475
1107
1108         Reviewed by Alexey Proskuryakov.
1109
1110         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1111
1112 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1113
1114         Remove webkitpy and bindings test queues from old EWS
1115         https://bugs.webkit.org/show_bug.cgi?id=197468
1116
1117         Reviewed by Alexey Proskuryakov.
1118
1119         * QueueStatusServer/config/queues.py:
1120
1121 2019-04-30  Tim Horton  <timothy_horton@apple.com>
1122
1123         Fix the WebKitTestRunner build
1124         https://bugs.webkit.org/show_bug.cgi?id=197449
1125         <rdar://problem/50334169>
1126
1127         Reviewed by Alexey Proskuryakov.
1128
1129         * WebKitTestRunner/mac/EventSenderProxy.mm:
1130         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1131         (WTR::EventSenderProxy::mouseForceChanged):
1132         Use some SPI instead of IPI.
1133
1134 2019-04-30  Chris Dumez  <cdumez@apple.com>
1135
1136         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1137         https://bugs.webkit.org/show_bug.cgi?id=197426
1138         <rdar://problem/50256169>
1139
1140         Reviewed by Brady Eidson.
1141
1142         Add API test coverage.
1143
1144         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1145         (-[PSONScheme setShouldRespondAsynchronously:]):
1146         (-[PSONScheme webView:startURLSchemeTask:]):
1147         (-[PSONScheme webView:stopURLSchemeTask:]):
1148
1149 2019-04-30  Chris Dumez  <cdumez@apple.com>
1150
1151         Unreviewed, rolling out r244802.
1152
1153         Caused an API test failure
1154
1155         Reverted changeset:
1156
1157         "Regression(PSON) URL scheme handlers can no longer respond
1158         asynchronously"
1159         https://bugs.webkit.org/show_bug.cgi?id=197426
1160         https://trac.webkit.org/changeset/244802
1161
1162 2019-04-30  Chris Dumez  <cdumez@apple.com>
1163
1164         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1165         https://bugs.webkit.org/show_bug.cgi?id=197426
1166         <rdar://problem/50256169>
1167
1168         Reviewed by Brady Eidson.
1169
1170         Add API test coverage.
1171
1172         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1173         (-[PSONScheme setShouldRespondAsynchronously:]):
1174         (-[PSONScheme webView:startURLSchemeTask:]):
1175         (-[PSONScheme webView:stopURLSchemeTask:]):
1176
1177 2019-04-30  Chris Dumez  <cdumez@apple.com>
1178
1179         Only use a related page's process if that page has not been closed yet
1180         https://bugs.webkit.org/show_bug.cgi?id=197393
1181         <rdar://problem/50302423>
1182
1183         Reviewed by Tim Horton.
1184
1185         Add API test coverage.
1186
1187         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1188
1189 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1190
1191         [ews-build] Enable Bindings tests queue on new EWS
1192         https://bugs.webkit.org/show_bug.cgi?id=197424
1193
1194         Reviewed by Lucas Forschler.
1195
1196         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1197         (StatusBubble):
1198         * BuildSlaveSupport/ews-build/config.json:
1199
1200 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1201
1202         [ews-build] Configure ews151 for running various tests
1203         https://bugs.webkit.org/show_bug.cgi?id=197419
1204
1205         Reviewed by Lucas Forschler.
1206
1207         * BuildSlaveSupport/ews-build/config.json:
1208
1209 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1210
1211         [ews-build] Parse and display bindings test failures
1212         https://bugs.webkit.org/show_bug.cgi?id=197423
1213
1214         Reviewed by Lucas Forschler.
1215
1216         * BuildSlaveSupport/ews-build/steps.py:
1217         (RunBindingsTests.__init__): Set timeout of 5 minutes.
1218         (RunBindingsTests.start): Initialize log_observer for json output.
1219         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
1220         (RunBindingsTests._addToLog): Method to add message to log.
1221         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1222
1223 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
1224
1225         Unreviewed. Add myself as a committer.
1226
1227         * Scripts/webkitpy/common/config/contributors.json:
1228
1229 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1230
1231         [ews-build] Enable webkitpy queue on new EWS
1232         https://bugs.webkit.org/show_bug.cgi?id=197396
1233
1234         Reviewed by Lucas Forschler.
1235
1236         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1237         (StatusBubble):
1238         * BuildSlaveSupport/ews-build/config.json:
1239
1240 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1241
1242         [ews-build] Parse and display webkitpy failures
1243         https://bugs.webkit.org/show_bug.cgi?id=197395
1244
1245         Reviewed by Lucas Forschler.
1246
1247         * BuildSlaveSupport/ews-build/steps.py:
1248         (RunWebKitPyTests.start): Initialize log_observer for json output.
1249         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
1250         (RunWebKitPyTests._addToLog): Method to add message to log.
1251         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1252
1253 2019-04-29  Alex Christensen  <achristensen@webkit.org>
1254
1255         <rdar://problem/50299396> Fix internal High Sierra build
1256         https://bugs.webkit.org/show_bug.cgi?id=197388
1257
1258         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1259         * MiniBrowser/Configurations/Base.xcconfig:
1260         * MobileMiniBrowser/Configurations/Base.xcconfig:
1261         * TestWebKitAPI/Configurations/Base.xcconfig:
1262         * WebKitTestRunner/Configurations/Base.xcconfig:
1263
1264 2019-04-29  Youenn Fablet  <youenn@apple.com>
1265
1266         Remove spurious GVA printf logging
1267         https://bugs.webkit.org/show_bug.cgi?id=197368
1268         <rdar://problem/35975256>
1269
1270         Reviewed by Alexey Proskuryakov.
1271
1272         * Scripts/webkitpy/port/mac.py:
1273         (MacPort.logging_patterns_to_strip):
1274
1275 2019-04-29  Youenn Fablet  <youenn@apple.com>
1276
1277         getDisplayMedia should be called on user gesture
1278         https://bugs.webkit.org/show_bug.cgi?id=197356
1279         <rdar://problem/50296074>
1280
1281         Reviewed by Eric Carlson.
1282
1283         Update test configuration to inject internals
1284         so that we can use it to simulate a user click to call getDisplayMedia.
1285
1286         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1287         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1288         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
1289
1290 2019-04-26  Stephanie Lewis  <slewis@apple.com>
1291
1292         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
1293         https://bugs.webkit.org/show_bug.cgi?id=197339
1294
1295         Reviewed by Dewei Zhu.
1296
1297         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
1298         test run for setup steps that are too expensive to do every iteration.
1299
1300         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1301         (BenchmarkRunner._run_benchmark):
1302         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1303         (BrowserDriver):
1304         (BrowserDriver.prepare_initial_env):
1305         (BrowserDriver.restore_env_after_all_testing):
1306         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1307         (LinuxBrowserDriver.prepare_initial_env):
1308         (LinuxBrowserDriver.restore_env_after_all_testing):
1309         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1310         (OSXBrowserDriver.prepare_initial_env):
1311         (OSXBrowserDriver.restore_env_after_all_testing):
1312
1313 2019-04-28  Andy Estes  <aestes@apple.com>
1314
1315         Fix the watchOS engineering build.
1316
1317         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1318         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
1319
1320 2019-04-27  Chris Dumez  <cdumez@apple.com>
1321
1322         [WKTR] Move test timeout handling to the UIProcess
1323         https://bugs.webkit.org/show_bug.cgi?id=197333
1324
1325         Reviewed by Darin Adler.
1326
1327         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
1328         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
1329         every WebContent process in the case of swapping.
1330
1331         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
1332         would lead to crashes when firing the timer.
1333
1334         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1335         (WTR::InjectedBundle::didReceiveMessageToPage):
1336         (WTR::InjectedBundle::done):
1337         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1338         (WTR::InjectedBundle::shouldDumpPixels const):
1339         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1340         (WTR::TestRunner::TestRunner):
1341         (WTR::TestRunner::waitUntilDone):
1342         (WTR::TestRunner::setWaitUntilDone):
1343         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1344         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1345         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1346         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1347         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1348         * WebKitTestRunner/TestInvocation.cpp:
1349         (WTR::TestInvocation::TestInvocation):
1350         (WTR::TestInvocation::createTestSettingsDictionary):
1351         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1352         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1353         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
1354         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
1355         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
1356         (WTR::TestInvocation::setWaitUntilDone):
1357         (WTR::TestInvocation::done):
1358         * WebKitTestRunner/TestInvocation.h:
1359
1360 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
1361
1362         [JSC] linkPolymorphicCall now does GC
1363         https://bugs.webkit.org/show_bug.cgi?id=197306
1364
1365         Reviewed by Saam Barati.
1366
1367         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
1368         To add this test, we add `runWithoutBaseOption`.
1369
1370         * Scripts/run-jsc-stress-tests:
1371
1372 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1373
1374         Update inactive reviewers' status to 'contributor'.
1375
1376         Accidentally skipped one at first.
1377
1378         * Scripts/webkitpy/common/config/contributors.json:
1379
1380 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1381
1382         Update inactive reviewers' status to 'contributor'.
1383
1384         * Scripts/webkitpy/common/config/contributors.json: The change.
1385
1386         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1387         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1388         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1389         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1390         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1391         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1392         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1393         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1394         Sadly, regression tests operate on a crazy mix of mock and live data for
1395         contributors.json. It would be a substantial project to mock all code paths,
1396         so changing the tests instead.
1397
1398 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
1399
1400         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1401         https://bugs.webkit.org/show_bug.cgi?id=197171
1402         <rdar://problem/47454979>
1403
1404         Reviewed by Youenn Fablet.
1405
1406         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1407         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1408         (TestWebKitAPI::TEST):
1409
1410 2019-04-26  David Kilzer  <ddkilzer@apple.com>
1411
1412         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
1413         <https://webkit.org/b/197314>
1414         <rdar://problem/50245252>
1415
1416         Reviewed by Simon Fraser.
1417
1418         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1419         (WTR::UIScriptController::lastUndoLabel const):
1420         (WTR::UIScriptController::firstRedoLabel const):
1421         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1422
1423         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1424         (-[HIDEventGenerator sendEventStream:completionBlock:]):
1425         - Call -autorelease to fix leak of NSDictionary.
1426
1427         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1428         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
1429         (WTR::UIScriptController::selectFormPopoverTitle const):
1430         (WTR::UIScriptController::textContentType const):
1431         (WTR::UIScriptController::formInputLabel const):
1432         (WTR::UIScriptController::scrollingTreeAsText const):
1433         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1434
1435 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
1436
1437         webkitpy: Running a single test will always use the default device
1438         https://bugs.webkit.org/show_bug.cgi?id=195472
1439         <rdar://problem/48724825>
1440
1441         Reviewed by Lucas Forschler.
1442
1443         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
1444         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
1445         requested will be run regardless of what shard they are in.
1446
1447         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1448         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
1449         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1450         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
1451         on the default device type.
1452         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1453         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
1454         (RunTest.test_run_part): Ditto.
1455
1456 2019-04-26  Alex Christensen  <achristensen@webkit.org>
1457
1458         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
1459         https://bugs.webkit.org/show_bug.cgi?id=197165
1460
1461         Reviewed by Youenn Fablet.
1462
1463         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1464
1465 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1466
1467         Replace iOS build queue hardware
1468         https://bugs.webkit.org/show_bug.cgi?id=197312
1469
1470         Reviewed by Aakash Jain.
1471
1472         * BuildSlaveSupport/build.webkit.org-config/config.json:
1473         Use newer hardware that supports macOS Mojave.
1474
1475 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
1476
1477         check-webkit-style complains the first block in while loop.
1478         https://bugs.webkit.org/show_bug.cgi?id=197307
1479
1480         The style checker shouldn't complain about an open brace on
1481         its own line if the last non-whitespace character on the previous
1482         non-blank line is another open brace, because it's likely to
1483         indicate the begining of a nested code block.
1484
1485         Reviewed by Alex Christensen.
1486
1487         * Scripts/webkitpy/style/checkers/cpp.py:
1488         (check_braces):
1489         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1490         (WebKitStyleTest.test_braces):
1491
1492 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
1493
1494         Stop IDB transactions to release locked database files when network process is ready to suspend
1495         https://bugs.webkit.org/show_bug.cgi?id=196372
1496         <rdar://problem/48930116>
1497
1498         Reviewed by Brady Eidson.
1499
1500         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1501         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
1502         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
1503         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
1504         (runTestAndCheckResult):
1505         (keepNetworkProcessActive):
1506         (TEST):
1507
1508 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1509
1510         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
1511         https://bugs.webkit.org/show_bug.cgi?id=188357
1512         <rdar://problem/42986633>
1513
1514         Reviewed by Dean Jackson.
1515
1516         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
1517         tests would fall into low memory mode and have different behavior.
1518         
1519         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
1520         to Internals, so it's shared by DRT and WTR.
1521         
1522         We no longer need the WK2 C SPI glue.
1523
1524         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1525         (WTR::InjectedBundlePage::prepare):
1526
1527 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
1528
1529         webkitpy: Including skipped tests in the final count
1530         https://bugs.webkit.org/show_bug.cgi?id=197298
1531         <rdar://problem/49705424>
1532
1533         Reviewed by Lucas Forschler.
1534
1535         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1536         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
1537
1538 2019-04-25  Timothy Hatcher  <timothy@apple.com>
1539
1540         Disable date and time inputs on iOSMac.
1541         https://bugs.webkit.org/show_bug.cgi?id=197287
1542         rdar://problem/46794376
1543
1544         Reviewed by Wenson Hsieh.
1545
1546         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1547
1548 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1549
1550         Fix test-webkitpy after r244653
1551         https://bugs.webkit.org/show_bug.cgi?id=197131
1552
1553         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1554         Also use C++17.
1555
1556 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
1557
1558         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
1559         https://bugs.webkit.org/show_bug.cgi?id=196991
1560         <rdar://problem/45507423>
1561
1562         Reviewed by Alex Christensen.
1563
1564         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1565         (-[NavigationTestDelegate init]):
1566         (-[NavigationTestDelegate waitForDidFinishNavigation]):
1567         (-[NavigationTestDelegate webView:didFinishNavigation:]):
1568         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1569         (TestWebKitAPI::TEST):
1570         (TEST): Deleted.
1571
1572 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1573
1574         Revert some code accidentally committed with r244653
1575         https://bugs.webkit.org/show_bug.cgi?id=197131
1576
1577         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1578         (TestWebKitAPI::TEST):
1579
1580 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1581
1582         Start using C++17
1583         https://bugs.webkit.org/show_bug.cgi?id=197131
1584
1585         Reviewed by Darin Adler.
1586
1587         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1588         * MiniBrowser/Configurations/Base.xcconfig:
1589         * MobileMiniBrowser/Configurations/Base.xcconfig:
1590         * TestWebKitAPI/Configurations/Base.xcconfig:
1591         * WebKitTestRunner/Configurations/Base.xcconfig:
1592
1593 2019-04-25  Commit Queue  <commit-queue@webkit.org>
1594
1595         Unreviewed, rolling out r244627.
1596         https://bugs.webkit.org/show_bug.cgi?id=197282
1597
1598         Causing internal build failures (Requested by ShawnRoberts on
1599         #webkit).
1600
1601         Reverted changeset:
1602
1603         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1604         https://bugs.webkit.org/show_bug.cgi?id=197171
1605         https://trac.webkit.org/changeset/244627
1606
1607 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1608
1609         [GTK] Hardcoded text color in input fields
1610         https://bugs.webkit.org/show_bug.cgi?id=126907
1611
1612         Reviewed by Michael Catanzaro.
1613
1614         Add dark-mode command line option to MiniBrowser.
1615
1616         * MiniBrowser/gtk/main.c:
1617         (main):
1618
1619 2019-04-24  Zalan Bujtas  <zalan@apple.com>
1620
1621         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1622         https://bugs.webkit.org/show_bug.cgi?id=196948
1623         <rdar://problem/49927131>
1624
1625         Reviewed by Tim Horton.
1626
1627         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1628         (TEST):
1629         The expected order of incoming events is
1630         1. didInvalidateIntrinsicContentSize
1631         2. didFirstLayout
1632         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1633         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1634         (and remember, all we care about is ordering).
1635
1636 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
1637
1638         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1639         https://bugs.webkit.org/show_bug.cgi?id=197171
1640         <rdar://problem/47454979>
1641
1642         Reviewed by Youenn Fablet.
1643
1644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1645         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1646         (TestWebKitAPI::TEST):
1647
1648 2019-04-24  Brady Eidson  <beidson@apple.com>
1649
1650         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
1651         https://bugs.webkit.org/show_bug.cgi?id=191362
1652
1653         Reviewed by Alex Christensen.
1654
1655         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
1656           from an XHR to a custom protocol.
1657
1658 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1659
1660         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
1661         https://bugs.webkit.org/show_bug.cgi?id=197273
1662
1663         Reviewed by Dean Jackson.
1664
1665         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
1666         so that WebCoreTestSupport::resetInternalsObject() is always run.
1667
1668         * DumpRenderTree/mac/DumpRenderTree.mm:
1669         (resetWebViewToConsistentStateBeforeTesting):
1670         (runTest):
1671
1672 2019-04-24  John Wilander  <wilander@apple.com>
1673
1674         Age out unconverted Ad Click Attributions after one week.
1675         https://bugs.webkit.org/show_bug.cgi?id=197238
1676         <rdar://problem/50177349>
1677
1678         Reviewed by Chris Dumez.
1679
1680         This patch adds infrastructure to allow tests to expire all unconverted
1681         attributions early.
1682
1683         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1684         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1685         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
1686         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1687         * WebKitTestRunner/TestController.cpp:
1688         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
1689         * WebKitTestRunner/TestController.h:
1690         * WebKitTestRunner/TestInvocation.cpp:
1691         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1692
1693 2019-04-24  Chris Dumez  <cdumez@apple.com>
1694
1695         Fix flaky crashes in a couple of PSON API tests
1696         https://bugs.webkit.org/show_bug.cgi?id=197239
1697
1698         Reviewed by Tim Horton.
1699
1700         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
1701
1702         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1703
1704 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
1705
1706         Make it possible to control the renderTreeAsText output by setting options on testRunner
1707         https://bugs.webkit.org/show_bug.cgi?id=197133
1708
1709         Reviewed by Sam Weinig.
1710
1711         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
1712         that make sense in testing (those that don't dump unstable data like addresses), and plumb
1713         these flags through the various framework layers.
1714
1715         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
1716
1717         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
1718         and hand-code DumpRenderTree bindings.
1719
1720         Some cleanup of the TestRunners, using member initializers.
1721
1722         * DumpRenderTree/TestRunner.cpp:
1723         (TestRunner::TestRunner):
1724         (setRenderTreeDumpOptionsCallback):
1725         (TestRunner::staticFunctions):
1726         (TestRunner::setRenderTreeDumpOptions):
1727         * DumpRenderTree/TestRunner.h:
1728         (TestRunner::renderTreeDumpOptions const):
1729         * DumpRenderTree/mac/DumpRenderTree.mm:
1730         (dump):
1731         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1732         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1733         (WTR::InjectedBundlePage::dump):
1734         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1735         (WTR::TestRunner::TestRunner):
1736         (WTR::TestRunner::setRenderTreeDumpOptions):
1737         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1738         (WTR::TestRunner::renderTreeDumpOptions const):
1739
1740 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1741
1742         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
1743         https://bugs.webkit.org/show_bug.cgi?id=197078
1744         <rdar://problem/49564348>
1745
1746         Reviewed by Geoff Garen.
1747
1748         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1749         (TEST_F):
1750         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
1751         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
1752         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
1753
1754 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1755
1756         Add unit test for r239322
1757         https://bugs.webkit.org/show_bug.cgi?id=197236
1758
1759         Reviewed by Chris Dumez.
1760
1761         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
1762         May as well add the test infrastructure which was needed before and will be needed in the future.
1763
1764         * TestWebKitAPI/TCPServer.cpp:
1765         (TestWebKitAPI::TCPServer::TCPServer):
1766         * TestWebKitAPI/TCPServer.h:
1767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1768         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1769         (TestWebKitAPI::TEST):
1770         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1771         (TestWebKitAPI::downloadAtRate):
1772         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1773         (TEST):
1774         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
1775         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1776         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1777         (TestWebKitAPI::TEST):
1778         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1779         (TEST):
1780
1781 2019-04-24  Chris Dumez  <cdumez@apple.com>
1782
1783         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
1784         https://bugs.webkit.org/show_bug.cgi?id=197214
1785         <rdar://problem/49237544>
1786
1787         Reviewed by Alex Christensen.
1788
1789         Extend API test coverage.
1790
1791         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1792         (TEST):
1793
1794 2019-04-24  Philippe Normand  <pnormand@igalia.com>
1795
1796         [Build][GStreamer] Update to 1.16.0
1797         https://bugs.webkit.org/show_bug.cgi?id=197157
1798
1799         Reviewed by Xabier Rodriguez-Calvar.
1800
1801         The upstreamed patches were removed and a new one was added for a
1802         regression detected in the scaletempo GStreamer element. The GNOME
1803         Flatpak was migrated to 3.32 and I switched a few modules to Meson
1804         on the way, as it is the preferred build system now in GStreamer
1805         1.16.
1806
1807         * flatpak/files/httpd-autogen.sh:
1808         * flatpak/flatpakutils.py:
1809         (FlatpakPackage.install):
1810         (WebkitFlatpak.run_in_sandbox):
1811         * flatpak/org.webkit.CommonModules.yaml:
1812         * flatpak/org.webkit.WebKit.yaml:
1813         * gstreamer/jhbuild.modules:
1814         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
1815         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
1816         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
1817         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
1818         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
1819         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
1820         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
1821         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
1822         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
1823         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1824         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
1825         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1826         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
1827         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
1828         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
1829         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
1830         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
1831         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
1832         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
1833         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
1834         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
1835         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
1836
1837 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1838
1839         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
1840         https://bugs.webkit.org/show_bug.cgi?id=197156
1841
1842         Reviewed by Michael Catanzaro.
1843
1844         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
1845         support was added.
1846
1847         * MiniBrowser/gtk/BrowserTab.c:
1848         (browser_tab_set_background_color): Set the passed in color as web view background color.
1849         * MiniBrowser/gtk/BrowserTab.h:
1850         * MiniBrowser/gtk/BrowserWindow.c:
1851         (browser_window_init): Initialize backgroundColor.
1852         (browser_window_append_view): Call browser_tab_set_background_color().
1853         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
1854         are added.
1855         * MiniBrowser/gtk/main.c:
1856         (main): Call browser_window_set_background_color() before creating the tabs.
1857
1858 2019-04-23  John Wilander  <wilander@apple.com>
1859
1860         Move Ad Click Attribution from internal feature to experimental feature
1861         https://bugs.webkit.org/show_bug.cgi?id=197218
1862         <rdar://problem/47651691>
1863
1864         Reviewed by Brent Fulgham.
1865
1866         * DumpRenderTree/TestOptions.cpp:
1867         (TestOptions::TestOptions):
1868
1869 2019-04-23  Andy Estes  <aestes@apple.com>
1870
1871         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1872         https://bugs.webkit.org/show_bug.cgi?id=196749
1873         <rdar://problem/35773454>
1874
1875         Reviewed by Daniel Bates.
1876
1877         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1878
1879         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1880         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1881         (-[QuickLookDelegate webView:didFinishNavigation:]):
1882         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1883         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1884         (runTest):
1885         (runTestDecideBeforeLoading):
1886         (runTestDecideAfterLoading):
1887         (TEST):
1888
1889 2019-04-23  John Wilander  <wilander@apple.com>
1890
1891         Remove Ad Click Attribution data when removing website data
1892         https://bugs.webkit.org/show_bug.cgi?id=197215
1893         <rdar://problem/47668988>
1894
1895         Reviewed by Chris Dumez.
1896
1897         This patch adds test infrastructure to delete Ad Click Attribution data
1898         through WebsiteDataStore::removeData().
1899
1900         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1901         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1902         (WTR::TestRunner::clearAdClickAttribution):
1903         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1904         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1905         * WebKitTestRunner/TestController.cpp:
1906         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1907         * WebKitTestRunner/TestController.h:
1908         * WebKitTestRunner/TestInvocation.cpp:
1909         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1910
1911 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1912
1913         webkitpy: Kill unresponsive worker processes
1914         https://bugs.webkit.org/show_bug.cgi?id=197205
1915         <rdar://problem/50104388>
1916
1917         Reviewed by Lucas Forschler.
1918
1919         * Scripts/webkitpy/common/message_pool.py:
1920         (_MessagePool.__init__): Add close timeout.
1921         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1922
1923 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1924
1925         Add unit tests for WKWebView.serverTrust
1926         https://bugs.webkit.org/show_bug.cgi?id=197202
1927
1928         Reviewed by Youenn Fablet
1929
1930         * TestWebKitAPI/TCPServer.cpp:
1931         (TestWebKitAPI::deleter<BIO>::operator()):
1932         (TestWebKitAPI::deleter<SSL>::operator()):
1933         (TestWebKitAPI::deleter<X509>::operator()):
1934         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1935         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1936         (TestWebKitAPI::TCPServer::TCPServer):
1937         (TestWebKitAPI::TCPServer::listenForConnections):
1938         * TestWebKitAPI/TCPServer.h:
1939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1940         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1941         (TestWebKitAPI::TEST):
1942         (verifyCertificateAndPublicKey):
1943         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1944         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1945         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1946         (TestWebKitAPI::downloadAtRate):
1947         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1948         (TEST):
1949         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1950         (TEST):
1951
1952 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1953
1954         Unreviewed, rolling out r244556.
1955         https://bugs.webkit.org/show_bug.cgi?id=197212
1956
1957         Causing build failures on multiple builders (Requested by
1958         ShawnRoberts on #webkit).
1959
1960         Reverted changeset:
1961
1962         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1963         https://bugs.webkit.org/show_bug.cgi?id=197171
1964         https://trac.webkit.org/changeset/244556
1965
1966 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1967
1968         Fix iOS build.
1969         https://bugs.webkit.org/show_bug.cgi?id=195537
1970
1971         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1972         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1973         AdoptWK constructor is private now.  Use adoptWK instead.
1974
1975 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
1976
1977         Accessibility text search and selection API enhancements.
1978         https://bugs.webkit.org/show_bug.cgi?id=197095
1979         <rdar://problem/48181791>
1980
1981         Reviewed by Chris Fleizach.
1982
1983         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
1984
1985         * DumpRenderTree/AccessibilityTextMarker.h:
1986         * DumpRenderTree/AccessibilityUIElement.cpp:
1987         (searchTextWithCriteriaCallback):
1988         (AccessibilityUIElement::getJSClass):
1989         * DumpRenderTree/AccessibilityUIElement.h:
1990         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1991         (convertVectorToObjectArray):
1992         (convertNSArrayToVector):
1993         (searchTextParameterizedAttributeForCriteria):
1994         (AccessibilityUIElement::getLinkedUIElements):
1995         (AccessibilityUIElement::getDocumentLinks):
1996         (AccessibilityUIElement::getChildren):
1997         (AccessibilityUIElement::getChildrenWithRange):
1998         (AccessibilityUIElement::rowHeaders const):
1999         (AccessibilityUIElement::columnHeaders const):
2000         (AccessibilityUIElement::uiElementArrayAttributeValue const):
2001         (AccessibilityUIElement::searchTextWithCriteria):
2002         (AccessibilityUIElement::attributesOfColumnHeaders):
2003         (AccessibilityUIElement::attributesOfRowHeaders):
2004         (AccessibilityUIElement::attributesOfColumns):
2005         (AccessibilityUIElement::attributesOfRows):
2006         (AccessibilityUIElement::attributesOfVisibleCells):
2007         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2008         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2009         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2010         (WTR::convertVectorToObjectArray):
2011         (WTR::convertNSArrayToVector):
2012         (WTR::searchTextParameterizedAttributeForCriteria):
2013         (WTR::AccessibilityUIElement::getLinkedUIElements):
2014         (WTR::AccessibilityUIElement::getDocumentLinks):
2015         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
2016         (WTR::AccessibilityUIElement::getChildren):
2017         (WTR::AccessibilityUIElement::getChildrenWithRange):
2018         (WTR::AccessibilityUIElement::rowHeaders const):
2019         (WTR::AccessibilityUIElement::columnHeaders const):
2020         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
2021         (WTR::AccessibilityUIElement::searchTextWithCriteria):
2022         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2023         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2024         (WTR::AccessibilityUIElement::attributesOfColumns):
2025         (WTR::AccessibilityUIElement::attributesOfRows):
2026         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2027         (WTR::convertElementsToObjectArray): Deleted.
2028
2029 2019-04-23  Guy Lewin  <guy@lewin.co.il>
2030
2031         Multiple File Input Icon Set Regardless of File List
2032         https://bugs.webkit.org/show_bug.cgi?id=195537
2033
2034         Reviewed by Alexey Proskuryakov.
2035
2036         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
2037         display string in iOS file inputs
2038
2039         * DumpRenderTree/TestRunner.cpp:
2040         (SetOpenPanelFilesMediaIconCallback):
2041         (TestRunner::staticFunctions):
2042         (TestRunner::setOpenPanelFilesMediaIcon):
2043         * DumpRenderTree/TestRunner.h:
2044         (TestRunner::openPanelFilesMediaIcon const):
2045         * DumpRenderTree/mac/UIDelegate.mm:
2046         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
2047         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2048         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2049         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2050         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2051         * WebKitTestRunner/TestController.cpp:
2052         (WTR::runOpenPanel):
2053         (WTR::TestController::resetStateToConsistentValues):
2054         * WebKitTestRunner/TestController.h:
2055         (WTR::TestController::openPanelFileURLsMediaIcon const):
2056         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
2057         * WebKitTestRunner/TestInvocation.cpp:
2058         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2059
2060 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
2061
2062         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2063         https://bugs.webkit.org/show_bug.cgi?id=197171
2064         <rdar://problem/47454979>
2065
2066         Reviewed by Youenn Fablet.
2067
2068         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2069         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2070         (TestWebKitAPI::TEST):
2071
2072 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2073
2074         [ews-build] Add unit tests for UnApplyPatchIfRequired
2075         https://bugs.webkit.org/show_bug.cgi?id=197197
2076
2077         Reviewed by Lucas Forschler.
2078
2079         * BuildSlaveSupport/ews-build/steps_unittest.py:
2080         (TestUnApplyPatchIfRequired):
2081         (TestUnApplyPatchIfRequired.test_success):
2082         (TestUnApplyPatchIfRequired.test_failure):
2083         (TestUnApplyPatchIfRequired.test_skip):
2084
2085 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2086
2087         [ews-build] Add unit tests for CleanWorkingDirectory
2088         https://bugs.webkit.org/show_bug.cgi?id=197195
2089
2090         Reviewed by Lucas Forschler.
2091
2092         * BuildSlaveSupport/ews-build/steps_unittest.py:
2093         (TestCleanWorkingDirectory):
2094         (TestCleanWorkingDirectory.test_success):
2095         (TestCleanWorkingDirectory.test_failure):
2096
2097 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2098
2099         [ews-build] Use explicit imports instead of wildcard imports
2100         https://bugs.webkit.org/show_bug.cgi?id=197194
2101
2102         Reviewed by Lucas Forschler.
2103
2104         * BuildSlaveSupport/ews-build/factories.py:
2105         * BuildSlaveSupport/ews-build/loadConfig.py:
2106         * BuildSlaveSupport/ews-build/steps_unittest.py:
2107
2108 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2109
2110         [ews-build] Add unit tests for DownloadBuiltProduct
2111         https://bugs.webkit.org/show_bug.cgi?id=197193
2112
2113         Reviewed by Lucas Forschler.
2114
2115         * BuildSlaveSupport/ews-build/steps_unittest.py:
2116         (TestDownloadBuiltProduct):
2117         (TestDownloadBuiltProduct.setUp):
2118         (TestDownloadBuiltProduct.tearDown):
2119         (TestDownloadBuiltProduct.test_success):
2120         (TestDownloadBuiltProduct.test_failure):
2121
2122 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2123
2124         [ews-app] Exception while loading status-bubble when no build step has started
2125         https://bugs.webkit.org/show_bug.cgi?id=196676
2126
2127         Reviewed by Lucas Forschler.
2128
2129         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2130         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
2131
2132 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
2133
2134         [PlayStation] Support running of JSC tests on remote playstation devices
2135         https://bugs.webkit.org/show_bug.cgi?id=197170
2136
2137         Reviewed by Ross Kirsling.
2138
2139         Script changes
2140
2141         * Scripts/run-javascriptcore-tests:
2142         (runJSCStressTests): Pass arguments for playstation to
2143         run-jsc-stress-tests
2144         * Scripts/run-jsc-stress-tests:
2145         Handle $hostOS=="playstation" for determineArchitecture, turning
2146         off $isFTLPlatform and runProfiler and defaulting test writer.
2147         * Scripts/webkitdirs.pm:
2148         (jscPath): PlayStation WebKit executables have .elf extension
2149         (executableProductDir): PlayStation builds on Windows hosts but
2150         uses bin directory rather than bin64/bin32 for executable output
2151         location.
2152         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
2153
2154 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
2155
2156         [CMake][Win] Use target oriented design for WebKit
2157         https://bugs.webkit.org/show_bug.cgi?id=197173
2158
2159         Reviewed by Alex Christensen.
2160
2161         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
2162         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
2163
2164 2019-04-23  Chris Dumez  <cdumez@apple.com>
2165
2166         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
2167         https://bugs.webkit.org/show_bug.cgi?id=197097
2168         <rdar://problem/50048318>
2169
2170         Reviewed by Alex Christensen.
2171
2172         Add API test coverage.
2173
2174         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2175         (-[PSONScheme webView:startURLSchemeTask:]):
2176
2177 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2178
2179         [ATK] Implement AtkComponentIface scroll_to methods
2180         https://bugs.webkit.org/show_bug.cgi?id=196856
2181
2182         Reviewed by Michael Catanzaro.
2183
2184         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2185         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
2186         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
2187         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
2188
2189 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2190
2191         [ews-build] Improve summary for UploadBuiltProduct step
2192         https://bugs.webkit.org/show_bug.cgi?id=197182
2193
2194         Reviewed by Lucas Forschler.
2195
2196         * BuildSlaveSupport/ews-build/steps.py:
2197         (UploadBuiltProduct): Added descriptionDone.
2198         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
2199         * BuildSlaveSupport/ews-build/steps_unittest.py:
2200         (TestUploadBuiltProduct.test_success): Updated unit-test.
2201         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
2202
2203 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2204
2205         [ews-build] Trigger queues only after uploading the archive
2206         https://bugs.webkit.org/show_bug.cgi?id=197180
2207
2208         Reviewed by Lucas Forschler.
2209
2210         * BuildSlaveSupport/ews-build/factories.py:
2211         (Factory.__init__):
2212         (BuildFactory.__init__): Remove trigger step from factories.
2213         (BuildFactory.propertiesToPassToTriggers): Deleted.
2214         * BuildSlaveSupport/ews-build/steps.py:
2215         (ConfigureBuild.__init__): Confiure triggers property.
2216         (Trigger): Step to trigger other queues.
2217         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
2218         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
2219
2220 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2221
2222         Deprecate WKContextCreateWithInjectedBundlePath
2223         https://bugs.webkit.org/show_bug.cgi?id=197169
2224
2225         Reviewed by Youenn Fablet.
2226
2227         * TestWebKitAPI/PlatformUtilities.cpp:
2228         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2229         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
2230
2231 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2232
2233         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
2234         https://bugs.webkit.org/show_bug.cgi?id=197093
2235         <rdar://problem/49708268>
2236
2237         Reviewed by Chris Dumez.
2238
2239         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
2240         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
2241         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
2242         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
2243         and one for loads without credentials, so there are two TCP connections to the same server in this test.
2244
2245         * TestWebKitAPI/TCPServer.cpp:
2246         (TestWebKitAPI::TCPServer::TCPServer):
2247         (TestWebKitAPI::TCPServer::~TCPServer):
2248         (TestWebKitAPI::TCPServer::socketBindListen):
2249         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
2250         * TestWebKitAPI/TCPServer.h:
2251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2252         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
2253         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2254         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2255         (respondWithChallengeThenOK):
2256         (TestWebKitAPI::TEST):
2257         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
2258         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2259         (TEST):
2260
2261 2019-04-22  Chris Dumez  <cdumez@apple.com>
2262
2263         Delayed WebProcessLaunch may break the _relatedWebView SPI
2264         https://bugs.webkit.org/show_bug.cgi?id=197160
2265
2266         Reviewed by Alex Christensen.
2267
2268         Add API test coverage.
2269
2270         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2271
2272 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
2273
2274         Use curl to download packages for webkitpy autoinstaller
2275         https://bugs.webkit.org/show_bug.cgi?id=197164
2276
2277         Reviewed by Darin Adler.
2278
2279         * Scripts/webkitpy/common/system/autoinstall.py:
2280         (AutoInstaller._download): Use curl(1) to download packages necessary for
2281         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
2282         errors which are not present when using curl(1).
2283
2284 2019-04-22  Chris Dumez  <cdumez@apple.com>
2285
2286         Unreviewed, rolling out r244502.
2287
2288         Caused crashes on the bots
2289
2290         Reverted changeset:
2291
2292         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
2293         https://bugs.webkit.org/show_bug.cgi?id=197160
2294         https://trac.webkit.org/changeset/244502
2295
2296 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
2297
2298         Unreviewed, rolling out r244437.
2299
2300         Still breaks internal tests.
2301
2302         Reverted changeset:
2303
2304         "InjectedBundle parameters often need initialization function
2305         called before unarchiving"
2306         https://bugs.webkit.org/show_bug.cgi?id=189709
2307         https://trac.webkit.org/changeset/244437
2308
2309 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2310
2311         [ews-build] Use singular verb in failure description in case of single api test failure
2312         https://bugs.webkit.org/show_bug.cgi?id=197013
2313
2314         Reviewed by Lucas Forschler.
2315
2316         * BuildSlaveSupport/ews-build/steps.py:
2317         (AnalyzeAPITestsResults.analyzeResults):
2318
2319 2019-04-22  Chris Dumez  <cdumez@apple.com>
2320
2321         Delayed WebProcessLaunch may break the _relatedWebView SPI
2322         https://bugs.webkit.org/show_bug.cgi?id=197160
2323
2324         Reviewed by Alex Christensen.
2325
2326         Add API test coverage.
2327
2328         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2329
2330 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2331
2332         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
2333         https://bugs.webkit.org/show_bug.cgi?id=194630
2334
2335         Reviewed by Michael Catanzaro.
2336
2337         Return early from getAttributeSet() is passed in accessible is nullptr.
2338
2339         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2340
2341 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2342
2343         Defer EditorState updates until the next layer tree flush in a few additional circumstances
2344         https://bugs.webkit.org/show_bug.cgi?id=197145
2345         <rdar://problem/50078170>
2346
2347         Reviewed by Darin Adler.
2348
2349         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
2350         focus, or showing the font manager.
2351
2352         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2353         (TestWebKitAPI::TEST):
2354         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2355         (TEST):
2356         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2357         (TestWebKitAPI::TEST):
2358
2359 2019-04-21  Brian Burg  <bburg@apple.com>
2360
2361         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
2362         https://bugs.webkit.org/show_bug.cgi?id=197125
2363         <rdar://problem/50061468>
2364
2365         Reviewed by Darin Adler.
2366
2367         Sometimes I want to run wptserve independently of tests. Make it easier to script that
2368         using this class rather than making our own ./wpt serve invocation.
2369
2370         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2371         (WebDriverW3CWebServer):
2372         (WebDriverW3CWebServer.document_root): Expose this to clients.
2373         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
2374
2375         (WebDriverW3CWebServer.__enter__):
2376         (WebDriverW3CWebServer.__exit__):
2377         Make it possible to use the web server with a 'with' statement.
2378
2379 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
2380
2381         [CMake][Win] Use target oriented design for WebKitLegacy
2382         https://bugs.webkit.org/show_bug.cgi?id=197112
2383
2384         Reviewed by Konstantin Tokarev.
2385
2386         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
2387
2388         * DumpRenderTree/CMakeLists.txt:
2389         * DumpRenderTree/PlatformWin.cmake:
2390         * DumpRenderTree/win/EventSender.cpp:
2391
2392 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2393
2394         Update text for old EWS submit button
2395         https://bugs.webkit.org/show_bug.cgi?id=197140
2396
2397         Reviewed by Alexey Proskuryakov.
2398
2399         * QueueStatusServer/templates/statusbubble.html:
2400
2401 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2402
2403         [ews-app] New EWS should poll bugzilla more frequently
2404         https://bugs.webkit.org/show_bug.cgi?id=197138
2405
2406         Reviewed by Alexey Proskuryakov.
2407
2408         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2409         (FetchLoop.__init__):
2410
2411 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2412
2413         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
2414         https://bugs.webkit.org/show_bug.cgi?id=197139
2415
2416         Reviewed by Alexey Proskuryakov.
2417
2418         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2419         * QueueStatusServer/templates/statusbubble.html:
2420
2421 2019-04-20  Chris Dumez  <cdumez@apple.com>
2422
2423         Unreviewed, fix iOS build with recent SDKs.
2424
2425         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2426
2427 2019-04-19  Keith Miller  <keith_miller@apple.com>
2428
2429         Add script to merge run_benchmark jsons
2430         https://bugs.webkit.org/show_bug.cgi?id=197107
2431
2432         Reviewed by Michael Saboff.
2433
2434         The script basically recursively decends through all json objects until it gets
2435         to an array or JSON primitive and concats or takes the first value, respectively.
2436
2437         This patch also adds +x bits to the compare-results script so it
2438         can be run directly from the command line. I had to add a new line so that svn
2439         will accept the change... yay svn!
2440
2441         * Scripts/compare-results:
2442         * Scripts/merge-result-jsons: Added.
2443         (readJSONFile):
2444         (deepAppend):
2445         (mergeJSONs):
2446         (main):
2447
2448 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
2449
2450         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
2451         https://bugs.webkit.org/show_bug.cgi?id=197079
2452
2453         Reviewed by Darin Adler.
2454
2455         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
2456
2457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2458         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
2459
2460 2019-04-18  Commit Queue  <commit-queue@webkit.org>
2461
2462         Unreviewed, rolling out r244434.
2463         https://bugs.webkit.org/show_bug.cgi?id=197089
2464
2465         caused 1 API test failure (Requested by zalan on #webkit).
2466
2467         Reverted changeset:
2468
2469         "Regression (r244291): Broken API Test
2470         AutoLayoutRenderingProgressRelativeOrdering"
2471         https://bugs.webkit.org/show_bug.cgi?id=196948
2472         https://trac.webkit.org/changeset/244434
2473
2474 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2475
2476         Add new compatibility mode API on WKNavigation
2477         https://bugs.webkit.org/show_bug.cgi?id=197069
2478         <rdar://problem/50025800>
2479
2480         Reviewed by Tim Horton.
2481
2482         Add a block property for -didCommitNavigation to TestNavigationDelegate.
2483
2484         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2485         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2486         (-[TestNavigationDelegate webView:didCommitNavigation:]):
2487
2488 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
2489
2490         [CMake] Make WebCore headers copies
2491         https://bugs.webkit.org/show_bug.cgi?id=182512
2492         <rdar://problem/37510435>
2493
2494         Reviewed by Alex Christensen.
2495
2496         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
2497         ports.
2498
2499         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
2500         of WebCore headers using "*.h" were modified to <WebCore/*.h>
2501
2502         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2503         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
2504         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
2505         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
2506         * TestWebKitAPI/CMakeLists.txt:
2507         * TestWebKitAPI/PlatformWin.cmake:
2508         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2509         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
2510         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2511
2512 2019-04-18  Jer Noble  <jer.noble@apple.com>
2513
2514         Add support for parsing FairPlayStreaming PSSH boxes.
2515         https://bugs.webkit.org/show_bug.cgi?id=197064
2516
2517         Reviewed by Eric Carlson.
2518
2519         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2520         (TestWebKitAPI::TEST):
2521
2522 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
2523
2524         InjectedBundle parameters often need initialization function called before unarchiving
2525         https://bugs.webkit.org/show_bug.cgi?id=189709
2526         <rdar://problem/44573653>
2527
2528         Reviewed by Ryosuke Niwa.
2529
2530         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2531         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2532
2533 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2534
2535         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2536         https://bugs.webkit.org/show_bug.cgi?id=196948
2537         <rdar://problem/49927131>
2538
2539         Reviewed by Tim Horton.
2540
2541         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2542         (TEST): 
2543         The expected order of incoming events is
2544         1. didInvalidateIntrinsicContentSize
2545         2. didFirstLayout
2546         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2547         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2548         (and remember, all we care about is ordering).
2549
2550 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
2551
2552         Unreviewed, rolling out r244299.
2553
2554         Breaks internal tests.
2555
2556         Reverted changeset:
2557
2558         "InjectedBundle parameters often need initialization function
2559         called before unarchiving"
2560         https://bugs.webkit.org/show_bug.cgi?id=189709
2561         https://trac.webkit.org/changeset/244299
2562
2563 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2564
2565         [WTF] StringBuilder should set correct m_is8Bit flag when merging
2566         https://bugs.webkit.org/show_bug.cgi?id=197053
2567
2568         Reviewed by Saam Barati.
2569
2570         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2571         (TestWebKitAPI::TEST):
2572
2573 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2574
2575         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
2576         https://bugs.webkit.org/show_bug.cgi?id=197028
2577         <rdar://problem/49985290>
2578
2579         Reviewed by Wenson Hsieh.
2580
2581         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2582         (TEST):
2583         Liberal application of waitForNextPresentationUpdate works around a race
2584         where if the page rapidly changes its viewport arguments (or an API client
2585         rapidly changes its viewport arguments), we'd get stuck thinking that the
2586         user had intentionally zoomed the page, and stop resetting the initial scale.
2587         This deserves a separate bug, but no need to keep the test failing while
2588         we think about it.
2589
2590 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2591
2592         REGRESSION (r241988): Switching tabs is slow
2593         https://bugs.webkit.org/show_bug.cgi?id=197037
2594         <rdar://problem/49951473>
2595
2596         Reviewed by Simon Fraser.
2597
2598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2599         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
2600         (TEST):
2601         * TestWebKitAPI/cocoa/TestWKWebView.h:
2602         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2603         (-[TestWKWebView addToTestWindow]):
2604         Add a test that hangs without this fix.
2605
2606 2019-04-17  Truitt Savell  <tsavell@apple.com>
2607
2608         Unreviewed, rolling out r244400.
2609
2610         Caused testing to exit early with assertionon Debug WK2
2611
2612         Reverted changeset:
2613
2614         "UI↔Web deadlock when printing with a JavaScript alert
2615         visible"
2616         https://bugs.webkit.org/show_bug.cgi?id=196839
2617         https://trac.webkit.org/changeset/244400
2618
2619 2019-04-17  Brady Eidson  <beidson@apple.com>
2620
2621         Link clicks in PDFs shouldn't send referrer headers.
2622         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
2623
2624         Reviewed by Tim Horton.
2625
2626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2627         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
2628         (putPDFBytesCallback):
2629         (emptyReleaseInfoCallback):
2630         (createPDFWithLinkToURL):
2631         (TEST):
2632
2633 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2634
2635         UI↔Web deadlock when printing with a JavaScript alert visible
2636         https://bugs.webkit.org/show_bug.cgi?id=196839
2637         <rdar://problem/49157642>
2638
2639         Reviewed by Andy Estes.
2640
2641         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2642         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
2643         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2644         (TEST):
2645
2646 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2647
2648         WKRetainPtr's adoption constructor should be private
2649         https://bugs.webkit.org/show_bug.cgi?id=197019
2650
2651         Reviewed by Tim Horton.
2652
2653         * DumpRenderTree/mac/DumpRenderTree.mm:
2654         (dumpFramesAsText):
2655         * TestWebKitAPI/InjectedBundleController.cpp:
2656         (TestWebKitAPI::InjectedBundleController::initialize):
2657         * TestWebKitAPI/PlatformUtilities.cpp:
2658         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2659         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
2660         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2661         (TestWebKitAPI::Util::toWK):
2662         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2663         (TestWebKitAPI::TEST):
2664         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2665         (TestWebKitAPI::TEST):
2666         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2667         (TestWebKitAPI::TEST):
2668         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2669         (TestWebKitAPI::TEST):
2670         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2671         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2672         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
2673         (TestWebKitAPI::TEST):
2674         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
2675         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2676         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2677         (TestWebKitAPI::TEST):
2678         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
2679         (TestWebKitAPI::TEST):
2680         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2681         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2682         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
2683         (TestWebKitAPI::TEST):
2684         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2685         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2686         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2687         (TestWebKitAPI::TEST):
2688         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2689         (TestWebKitAPI::TEST):
2690         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2691         (TestWebKitAPI::TEST):
2692         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2693         (TestWebKitAPI::TEST):
2694         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2695         (TestWebKitAPI::TEST):
2696         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2697         (TestWebKitAPI::TEST):
2698         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2699         (TestWebKitAPI::TEST):
2700         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
2701         (TestWebKitAPI::TEST):
2702         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2703         (TestWebKitAPI::TEST):
2704         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2705         (TestWebKitAPI::TEST):
2706         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2707         (TestWebKitAPI::TEST):
2708         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2709         (TestWebKitAPI::TEST):
2710         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2711         (TestWebKitAPI::TEST):
2712         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
2713         (TestWebKitAPI::TEST):
2714         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
2715         (TestWebKitAPI::TEST):
2716         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
2717         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2718         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
2719         (TestWebKitAPI::TEST):
2720         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
2721         (TestWebKitAPI::TEST):
2722         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
2723         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
2724         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
2725         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
2726         (TestWebKitAPI::TEST):
2727         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
2728         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
2729         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
2730         (TestWebKitAPI::TEST):
2731         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
2732         (TestWebKitAPI::TEST):
2733         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2734         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2735         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2736         (TestWebKitAPI::TEST):
2737         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2738         (TestWebKitAPI::loadAlternateHTMLString):
2739         (TestWebKitAPI::TEST):
2740         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
2741         (TestWebKitAPI::TEST):
2742         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2743         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2744         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2745         (TestWebKitAPI::buildAndPerformTest):
2746         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2747         (TestWebKitAPI::TEST):
2748         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
2749         (TestWebKitAPI::TEST):
2750         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
2751         (TestWebKitAPI::TEST):
2752         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2753         (TestWebKitAPI::TEST):
2754         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2755         (TestWebKitAPI::TEST):
2756         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2757         (TestWebKitAPI::TEST):
2758         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2759         (TestWebKitAPI::TEST):
2760         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2761         (TestWebKitAPI::TEST):
2762         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
2763         (TestWebKitAPI::TEST):
2764         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2765         (TestWebKitAPI::TEST):
2766         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2767         (TestWebKitAPI::TEST):
2768         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2769         (TestWebKitAPI::TEST):
2770         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2771         (TestWebKitAPI::TEST):
2772         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2773         (TestWebKitAPI::TEST):
2774         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2775         (TestWebKitAPI::TEST):
2776         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2777         (TestWebKitAPI::TEST):
2778         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2779         (TestWebKitAPI::TEST):
2780         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2781         (TestWebKitAPI::TEST):
2782         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2783         (TestWebKitAPI::TEST):
2784         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2785         (TestWebKitAPI::TEST):
2786         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
2787         (TestWebKitAPI::TEST):
2788         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
2789         (TestWebKitAPI::TEST):
2790         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2791         (TestWebKitAPI::TEST):
2792         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2793         (TestWebKitAPI::TEST):
2794         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2795         (TestWebKitAPI::TEST):
2796         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2797         (TestWebKitAPI::TEST):
2798         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2799         (TestWebKitAPI::TEST):
2800         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2801         (TestWebKitAPI::TEST):
2802         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2803         (TestWebKitAPI::TEST):
2804         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2805         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2806         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
2807         (TestWebKitAPI::TEST):
2808         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2809         (TestWebKitAPI::TEST):
2810         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
2811         (TestWebKitAPI::TEST):
2812         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
2813         (TestWebKitAPI::TEST):
2814         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2815         (TestWebKitAPI::TEST):
2816         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2817         (TestWebKitAPI::TEST):
2818         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
2819         (TestWebKitAPI::TEST):
2820         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2821         (TestWebKitAPI::TEST):
2822         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2823         (TestWebKitAPI::TEST):
2824         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2825         (TestWebKitAPI::TEST):
2826         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2827         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
2828         (TEST):
2829         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2830         (TEST):
2831         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2832         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2833         (TEST):
2834         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
2835         (TestWebKitAPI::TEST):
2836         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2837         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2838         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2839         (WTR::getMenuItemTitleCallback):
2840         (WTR::createMouseMessageBody):
2841         (WTR::EventSendingController::mouseDown):
2842         (WTR::EventSendingController::mouseUp):
2843         (WTR::EventSendingController::mouseMoveTo):
2844         (WTR::EventSendingController::mouseForceClick):
2845         (WTR::EventSendingController::startAndCancelMouseForceClick):
2846         (WTR::EventSendingController::mouseForceDown):
2847         (WTR::EventSendingController::mouseForceUp):
2848         (WTR::EventSendingController::mouseForceChanged):
2849         (WTR::EventSendingController::leapForward):
2850         (WTR::EventSendingController::scheduleAsynchronousClick):
2851         (WTR::createKeyDownMessageBody):
2852         (WTR::EventSendingController::keyDown):
2853         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2854         (WTR::EventSendingController::mouseScrollBy):
2855         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2856         (WTR::EventSendingController::continuousMouseScrollBy):
2857         (WTR::EventSendingController::addTouchPoint):
2858         (WTR::EventSendingController::updateTouchPoint):
2859         (WTR::EventSendingController::setTouchModifier):
2860         (WTR::EventSendingController::setTouchPointRadius):
2861         (WTR::EventSendingController::touchStart):
2862         (WTR::EventSendingController::touchMove):
2863         (WTR::EventSendingController::touchEnd):
2864         (WTR::EventSendingController::touchCancel):
2865         (WTR::EventSendingController::clearTouchPoints):
2866         (WTR::EventSendingController::releaseTouchPoint):
2867         (WTR::EventSendingController::cancelTouchPoint):
2868         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2869         (WTR::InjectedBundle::didCreatePage):
2870         (WTR::InjectedBundle::didReceiveMessage):
2871         (WTR::InjectedBundle::didReceiveMessageToPage):
2872         (WTR::InjectedBundle::booleanForKey):
2873         (WTR::InjectedBundle::done):
2874         (WTR::InjectedBundle::dumpToStdErr):
2875         (WTR::InjectedBundle::outputText):
2876         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2877         (WTR::InjectedBundle::postAddChromeInputField):
2878         (WTR::InjectedBundle::postRemoveChromeInputField):
2879         (WTR::InjectedBundle::postFocusWebView):
2880         (WTR::InjectedBundle::postSetBackingScaleFactor):
2881         (WTR::InjectedBundle::postSetWindowIsKey):
2882         (WTR::InjectedBundle::postSetViewSize):
2883         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2884         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2885         (WTR::InjectedBundle::setGeolocationPermission):
2886         (WTR::InjectedBundle::setMockGeolocationPosition):
2887         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2888         (WTR::InjectedBundle::isGeolocationProviderActive const):
2889         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2890         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2891         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2892         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2893         (WTR::InjectedBundle::setCustomPolicyDelegate):
2894         (WTR::InjectedBundle::setHidden):
2895         (WTR::InjectedBundle::setCacheModel):
2896         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2897         (WTR::InjectedBundle::processWorkQueue):
2898         (WTR::InjectedBundle::queueBackNavigation):
2899         (WTR::InjectedBundle::queueForwardNavigation):
2900         (WTR::InjectedBundle::queueLoad):
2901         (WTR::InjectedBundle::queueLoadHTMLString):
2902         (WTR::InjectedBundle::queueReload):
2903         (WTR::InjectedBundle::queueLoadingScript):
2904         (WTR::InjectedBundle::queueNonLoadingScript):
2905         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2906         (WTR::frameToStr):
2907         (WTR::InjectedBundlePage::InjectedBundlePage):
2908         (WTR::dumpFrameDescriptionSuitableForTestResult):
2909         (WTR::dumpFrameScrollPosition):
2910         (WTR::dumpDescendantFrameScrollPositions):
2911         (WTR::dumpFrameText):
2912         (WTR::dumpDescendantFramesText):
2913         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2914         (WTR::TestRunner::shouldDumpPixels const):
2915         (WTR::TestRunner::setDumpPixels):
2916         (WTR::TestRunner::whatToDump const):
2917         (WTR::TestRunner::setWhatToDump):
2918         (WTR::TestRunner::setWaitUntilDone):
2919         (WTR::TestRunner::shouldWaitUntilDone const):
2920         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2921         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2922         (WTR::TestRunner::clearAllDatabases):
2923         (WTR::TestRunner::setIDBPerOriginQuota):
2924         (WTR::TestRunner::originsWithApplicationCache):
2925         (WTR::TestRunner::setCanOpenWindows):
2926         (WTR::TestRunner::setXSSAuditorEnabled):
2927         (WTR::TestRunner::setMediaDevicesEnabled):
2928         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2929         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2930         (WTR::TestRunner::setCustomUserAgent):
2931         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2932         (WTR::TestRunner::setModernMediaControlsEnabled):
2933         (WTR::TestRunner::setWebGL2Enabled):
2934         (WTR::TestRunner::setWritableStreamAPIEnabled):
2935         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2936         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2937         (WTR::TestRunner::setAllowsAnySSLCertificate):
2938         (WTR::TestRunner::setPluginsEnabled):
2939         (WTR::TestRunner::setValueForUser):
2940         (WTR::TestRunner::setAudioResult):
2941         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2942         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2943         (WTR::TestRunner::setAlwaysAcceptCookies):
2944         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2945         (WTR::TestRunner::isDoingMediaCapture const):
2946         (WTR::TestRunner::queueLoad):
2947         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2948         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2949         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2950         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2951         (WTR::TestRunner::setAuthenticationUsername):
2952         (WTR::TestRunner::setAuthenticationPassword):
2953         (WTR::TestRunner::secureEventInputIsEnabled const):
2954         (WTR::TestRunner::setBlockAllPlugins):
2955         (WTR::TestRunner::setPluginSupportedMode):
2956         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2957         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2958         (WTR::TestRunner::setNavigationGesturesEnabled):
2959         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2960         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2961         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2962         (WTR::TestRunner::terminateNetworkProcess):
2963         (WTR::TestRunner::terminateServiceWorkerProcess):
2964         (WTR::TestRunner::runUIScript):
2965         (WTR::TestRunner::setStatisticsDebugMode):
2966         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2967         (WTR::TestRunner::setStatisticsLastSeen):
2968         (WTR::TestRunner::setStatisticsPrevalentResource):
2969         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2970         (WTR::TestRunner::dumpResourceLoadStatistics):
2971         (WTR::TestRunner::isStatisticsPrevalentResource):
2972         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
2973         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
2974         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
2975         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
2976         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2977         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2978         (WTR::TestRunner::setStatisticsGrandfathered):
2979         (WTR::TestRunner::isStatisticsGrandfathered):
2980         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2981         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2982         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2983         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
2984         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
2985         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
2986         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2987         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
2988         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2989         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2990         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2991         (WTR::TestRunner::statisticsSubmitTelemetry):
2992         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2993         (WTR::TestRunner::setStatisticsIsRunningTest):
2994         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2995         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2996         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2997         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2998         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2999         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
3000         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
3001         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3002         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
3003         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3004         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
3005         (WTR::TestRunner::statisticsResetToConsistentState):
3006         (WTR::TestRunner::setStorageAccessAPIEnabled):
3007         (WTR::TestRunner::getAllStorageAccessEntries):
3008         (WTR::TestRunner::addMockMediaDevice):
3009         (WTR::TestRunner::clearMockMediaDevices):
3010         (WTR::TestRunner::removeMockMediaDevice):
3011         (WTR::TestRunner::resetMockMediaDevices):
3012         (WTR::TestRunner::connectMockGamepad):
3013         (WTR::TestRunner::disconnectMockGamepad):
3014         (WTR::TestRunner::setMockGamepadDetails):
3015         (WTR::TestRunner::setMockGamepadAxisValue):
3016         (WTR::TestRunner::setMockGamepadButtonValue):
3017         (WTR::TestRunner::removeAllSessionCredentials):
3018         (WTR::TestRunner::clearDOMCache):
3019         (WTR::TestRunner::clearDOMCaches):
3020         (WTR::TestRunner::hasDOMCache):
3021         (WTR::TestRunner::domCacheSize):
3022         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3023         (WTR::TestRunner::getApplicationManifestThen):
3024         (WTR::TestRunner::injectUserScript):
3025         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
3026         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3027         (WTR::TestRunner::addTestKeyToKeychain):
3028         (WTR::TestRunner::cleanUpKeychain):
3029         (WTR::TestRunner::keyExistsInKeychain):
3030         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3031         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3032         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3033         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3034         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3035         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3036         * WebKitTestRunner/TestController.cpp:
3037         (WTR::TestController::initialize):
3038         (WTR::parseStringTestHeaderValueAsRelativePath):
3039         (WTR::updateTestOptionsFromTestHeader):
3040         (WTR::TestController::runTest):
3041         (WTR::TestController::didReceiveLiveDocumentsList):
3042         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3043         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3044         (WTR::TestController::didFinishNavigation):
3045         (WTR::TestController::didReceiveAuthenticationChallenge):
3046         * WebKitTestRunner/TestInvocation.cpp:
3047         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3048         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3049         (WTR::TestInvocation::uiScriptDidComplete):
3050         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
3051         * WebKitTestRunner/WebNotificationProvider.cpp:
3052         (WTR::WebNotificationProvider::closeWebNotification):
3053         * WebKitTestRunner/WorkQueueManager.cpp:
3054         (WTR::ScriptItem::ScriptItem):
3055         (WTR::WorkQueueManager::queueLoad):
3056         (WTR::WorkQueueManager::queueLoadHTMLString):
3057
3058 2019-04-17  Alex Christensen  <achristensen@webkit.org>
3059
3060         Add a comment to make my test from r244139 less mysterious.
3061         https://bugs.webkit.org/show_bug.cgi?id=196744
3062
3063         As suggested by Darin Adler.
3064
3065         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3066         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3067
3068 2019-04-17  Chris Dumez  <cdumez@apple.com>
3069
3070         Remember device orientation permission for the duration of the browsing session
3071         https://bugs.webkit.org/show_bug.cgi?id=196992
3072         <rdar://problem/49946067>
3073
3074         Reviewed by Alex Christensen.
3075
3076         Add API test coverage.
3077
3078         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
3079         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3080         (TEST):
3081
3082 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
3083
3084         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
3085         https://bugs.webkit.org/show_bug.cgi?id=196675
3086
3087         Reviewed by Lucas Forschler.
3088
3089         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
3090         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
3091
3092 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3093
3094         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
3095         https://bugs.webkit.org/show_bug.cgi?id=196919
3096         <rdar://problem/41630459>
3097
3098         Reviewed by Tim Horton.
3099
3100         Add iOS support for several new testing hooks. See below for more detail.
3101
3102         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3103         (WTR::UIScriptController::isDismissingMenu const):
3104
3105         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
3106         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
3107         by UIKit when dismissing the callout bar (i.e. UIMenuController).
3108
3109         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3110         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3111         (WTR::UIScriptController::isDismissingMenu const):
3112         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3113         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3114         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3115         (WTR::InjectedBundle::didReceiveMessageToPage):
3116         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3117         (WTR::TestRunner::setAllowedMenuActions):
3118
3119         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
3120         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
3121         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
3122         against the name of the custom action.
3123
3124         (WTR::TestRunner::installCustomMenuAction):
3125
3126         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
3127         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
3128         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
3129         triggered.
3130
3131         (WTR::TestRunner::performCustomMenuAction):
3132
3133         Invoked when the custom menu action is triggered.
3134
3135         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3136         * WebKitTestRunner/TestController.cpp:
3137         (WTR::TestController::installCustomMenuAction):
3138         (WTR::TestController::setAllowedMenuActions):
3139         * WebKitTestRunner/TestController.h:
3140         * WebKitTestRunner/TestInvocation.cpp:
3141         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3142         (WTR::TestInvocation::performCustomMenuAction):
3143
3144         Add plumbing to call back into the injected bundle when performing the custom action.
3145
3146         * WebKitTestRunner/TestInvocation.h:
3147         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3148         (WTR::TestController::installCustomMenuAction):
3149         (WTR::TestController::setAllowedMenuActions):
3150         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3151         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3152         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3153         (-[TestRunnerWKWebView becomeFirstResponder]):
3154         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
3155
3156         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
3157         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
3158         in the Mail app on iOS.
3159
3160         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
3161         (-[TestRunnerWKWebView setAllowedMenuActions:]):
3162         (-[TestRunnerWKWebView resetCustomMenuAction]):
3163         (-[TestRunnerWKWebView performCustomAction:]):
3164         (-[TestRunnerWKWebView canPerformAction:withSender:]):
3165         (-[TestRunnerWKWebView _willHideMenu]):
3166         (-[TestRunnerWKWebView _didHideMenu]):
3167         * WebKitTestRunner/ios/TestControllerIOS.mm:
3168         (WTR::TestController::platformResetStateToConsistentValues):
3169
3170         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
3171         if specified.
3172
3173         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3174         (WTR::UIScriptController::isDismissingMenu const):
3175
3176 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
3177
3178         Allow sharing from imageSheet on an image document
3179         https://bugs.webkit.org/show_bug.cgi?id=196891
3180         <rdar://problem/25377386>
3181
3182         Reviewed by Tim Horton.
3183
3184         Test to make sure that the correct imageURL is extracted from an image element.
3185
3186         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3187         (TestWebKitAPI::TEST):
3188
3189 2019-04-16  Alex Christensen  <achristensen@webkit.org>
3190
3191         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
3192         https://bugs.webkit.org/show_bug.cgi?id=196995
3193
3194         Reviewed by Brady Eidson.
3195
3196         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3197         (TEST):
3198
3199 2019-04-16  Chris Dumez  <cdumez@apple.com>
3200
3201         URL set by document.open() is not communicated to the UIProcess
3202         https://bugs.webkit.org/show_bug.cgi?id=196941
3203         <rdar://problem/49237544>
3204
3205         Reviewed by Geoff Garen.
3206
3207         Add API test coverage.
3208
3209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3210         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3211         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3212         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3213         (TEST):
3214
3215 2019-04-16  Commit Queue  <commit-queue@webkit.org>
3216
3217         Unreviewed, rolling out r244321.
3218         https://bugs.webkit.org/show_bug.cgi?id=196968
3219
3220         Causing all WK2 Debug builds to exit early after Assertion
3221         failures. (Requested by ShawnRoberts on #webkit).
3222
3223         Reverted changeset:
3224
3225         "URL set by document.open() is not communicated to the
3226         UIProcess"
3227         https://bugs.webkit.org/show_bug.cgi?id=196941
3228         https://trac.webkit.org/changeset/244321
3229
3230 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3231
3232         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
3233         https://bugs.webkit.org/show_bug.cgi?id=196948
3234
3235         Reviewed by Zalan Bujtas.
3236
3237         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3238         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
3239
3240 2019-04-15  Chris Dumez  <cdumez@apple.com>
3241
3242         URL set by document.open() is not communicated to the UIProcess
3243         https://bugs.webkit.org/show_bug.cgi?id=196941
3244         <rdar://problem/49237544>
3245
3246         Reviewed by Geoffrey Garen.
3247
3248         Add API test coverage.
3249
3250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3251         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3252         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3253         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3254         (TEST):
3255
3256 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
3257
3258         Using Tools/Scripts/clean-webkit should not install requests
3259         https://bugs.webkit.org/show_bug.cgi?id=196940
3260
3261         Reviewed by Lucas Forschler.
3262
3263         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
3264         existing, depending on the path autoinstalled is run through.
3265         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
3266         needed.
3267         (Port.configuration_for_upload):
3268         (Port.commits_for_upload):
3269
3270 2019-04-15  Alex Christensen  <achristensen@webkit.org>
3271
3272         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
3273         https://bugs.webkit.org/show_bug.cgi?id=196773
3274
3275         Reviewed by Jer Noble.
3276
3277         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
3278         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
3279         (TEST):
3280
3281 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3282
3283         ews-build should clearly indicate flaky test failures
3284         https://bugs.webkit.org/show_bug.cgi?id=196947
3285
3286         Reviewed by Lucas Forschler.
3287
3288         * BuildSlaveSupport/ews-build/steps.py:
3289         (AnalyzeAPITestsResults.analyzeResults):
3290
3291 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
3292
3293         InjectedBundle parameters often need initialization function called before unarchiving
3294         https://bugs.webkit.org/show_bug.cgi?id=189709
3295         <rdar://problem/44573653>
3296
3297         Reviewed by Ryosuke Niwa.
3298
3299         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
3300         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
3301
3302 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
3303
3304         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
3305         https://bugs.webkit.org/show_bug.cgi?id=196681
3306
3307         Reviewed by Darin Adler.
3308
3309         Added tests.
3310
3311         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3312         (WTF_HashSet.RemoveIf):
3313         (WTF_HashSet.RemoveIfShrinkToBestSize):
3314
3315 2019-04-15  John Wilander  <wilander@apple.com>
3316
3317         Send delayed Ad Click Attribution conversion requests to the click source
3318         https://bugs.webkit.org/show_bug.cgi?id=196838
3319         <rdar://problem/47650157>
3320
3321         Reviewed by Chris Dumez and Youenn Fablet.
3322
3323         This patch adds test infrastructure to override the default behavior in
3324         WebKit::NetworkAdClickAttribution.
3325
3326         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3327         (TestWebKitAPI::TEST):
3328         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3329         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3330         (WTR::TestRunner::dumpAdClickAttribution):
3331         (WTR::TestRunner::clearAdClickAttribution):
3332         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3333         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3334         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3335         * WebKitTestRunner/TestController.cpp:
3336         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
3337         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
3338         * WebKitTestRunner/TestController.h:
3339         * WebKitTestRunner/TestInvocation.cpp:
3340         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3341
3342 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3343
3344         [ews-app] status-bubble should display position in queue
3345         https://bugs.webkit.org/show_bug.cgi?id=196607
3346
3347         Reviewed by Lucas Forschler.
3348
3349         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3350         (StatusBubble._build_bubble):
3351         (StatusBubble._queue_position): Method to calculate patch's position in queue.
3352
3353 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3354
3355         [ews-build] Do not run clean build by default on EWS builders
3356         https://bugs.webkit.org/show_bug.cgi?id=196897
3357
3358         Reviewed by Lucas Forschler.
3359
3360         * BuildSlaveSupport/ews-build/steps.py:
3361         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
3362         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
3363         untracked directories like WebKitBuild).
3364         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
3365         untracked files/directories (like WebKitBuild).
3366
3367 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
3368
3369         TestRunner::notifyDone() should be safely reentrant
3370         https://bugs.webkit.org/show_bug.cgi?id=196898
3371
3372         Reviewed by Darin Adler.
3373
3374         It is currently possible that TestRunner::notifyDone() will call itself, since
3375         notifyDone() will force a repaint, which can start executing JavaScript, which
3376         may call notifyDone() again. This can lead to test failures and flakiness.
3377         Fix this by setting the m_waitToDump flag before calling the dump() method.
3378
3379         * DumpRenderTree/mac/TestRunnerMac.mm:
3380         (TestRunner::notifyDone):
3381         (TestRunner::forceImmediateCompletion):
3382         * DumpRenderTree/win/TestRunnerWin.cpp:
3383         (TestRunner::notifyDone):
3384         (TestRunner::forceImmediateCompletion):
3385
3386 2019-04-15  Philippe Normand  <pnormand@igalia.com>
3387
3388         [GTK][WPE] Add enable-media websetting
3389         https://bugs.webkit.org/show_bug.cgi?id=196863
3390
3391         Reviewed by Michael Catanzaro.
3392
3393         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3394         (testWebKitSettings): Add test for the enable-media web-setting.
3395
3396 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3397
3398         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
3399         https://bugs.webkit.org/show_bug.cgi?id=196905
3400         <rdar://problem/49886096>
3401
3402         Reviewed by Tim Horton.
3403
3404         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
3405         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
3406         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
3407         delay timer, we end up with this sequence of events in the problematic (failure) case:
3408
3409         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
3410             ...IPC from UI to web process...
3411         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
3412             ...IPC from web to UI process...
3413         (c) [UI]    Invoke completion handler for script #1
3414         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
3415             ...IPC from UI to web process...
3416         (e) [Web]   Evaluate script #2 in the web process
3417         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
3418
3419         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
3420         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
3421         #2 is run in step (e).
3422
3423         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
3424         the UI process by waiting on a script message posted by the web process, after attachment updates are
3425         dispatched.
3426
3427         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3428         (TestWebKitAPI::TEST):
3429
3430 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
3431
3432         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
3433         https://bugs.webkit.org/show_bug.cgi?id=196909
3434
3435         Reviewed by Wenson Hsieh.
3436
3437         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3438         (TestWebKitAPI::TEST):
3439
3440 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
3441
3442         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
3443         https://bugs.webkit.org/show_bug.cgi?id=196880
3444
3445         Reviewed by Yusuke Suzuki.
3446
3447         Add a new function for bytecode cache tests that does not forceDiskCache
3448         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
3449         test added in this patch, since the code is invalid and therefore won't be
3450         cached. It should also be useful for tests that evaluate dynamically
3451         generated code.
3452
3453         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3454         * Scripts/run-jsc-stress-tests:
3455
3456 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
3457
3458         Update AudioSession route sharing policy
3459         https://bugs.webkit.org/show_bug.cgi?id=196776
3460         <rdar://problem/46501611>
3461
3462         Reviewed by Jer Noble.
3463
3464         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3465         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
3466         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
3467         (TestWebKitAPI::TEST):
3468
3469 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3470
3471         [iOS] Software keyboard is shown too frequently on some websites
3472         https://bugs.webkit.org/show_bug.cgi?id=195856
3473         <rdar://problem/49191395>
3474
3475         Reviewed by Darin Adler.
3476
3477         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
3478
3479         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3480         (WTR::UIScriptController::setHardwareKeyboardAttached):
3481         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3482         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3483         (WTR::UIScriptController::setHardwareKeyboardAttached):
3484         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3485         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3486
3487         Additionally link against GraphicsServices in WebKitTestRunner.
3488
3489         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3490         (WTR::TestController::platformResetStateToConsistentValues):
3491         (WTR::UIScriptController::setHardwareKeyboardAttached):
3492
3493 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
3494
3495         [GTK][WPE] Fix pacman install-dependencies packages
3496         https://bugs.webkit.org/show_bug.cgi?id=196817
3497
3498         Reviewed by Žan Doberšek.
3499         
3500         python3-setuptools is called python-setuptools
3501         ruby-highline is only available on AUR
3502         libv4l-devel is incorporated in v4l-utils
3503
3504         * gtk/install-dependencies:
3505         * wpe/install-dependencies:
3506
3507 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3508
3509         [GTK] REGRESSION(r243860): Many tests failing
3510         https://bugs.webkit.org/show_bug.cgi?id=196791
3511
3512         Reviewed by Joanmarie Diggs.
3513
3514         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
3515         multiple documents and check that accessibility hierarchy is updated after a navigation.
3516
3517         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
3518         (loadChangedCallback):
3519         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3520         (AccessibilityTest::AccessibilityTest):
3521         (AccessibilityTest::~AccessibilityTest):
3522         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
3523         (AccessibilityTest::findTestServerApplication):
3524         (AccessibilityTest::findDocumentWeb):
3525         (AccessibilityTest::findRootObject):
3526         (AccessibilityTest::waitUntilChildrenRemoved):
3527         (AccessibilityTest::ensureProxy):
3528         (testAtspiBasicHierarchy):
3529         (beforeAll):
3530         (afterAll):
3531
3532 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
3533
3534         [ews-build] Handle bug titles with unicode characters
3535         https://bugs.webkit.org/show_bug.cgi?id=196802
3536
3537         Reviewed by Dewei Zhu.
3538
3539         * BuildSlaveSupport/ews-build/steps.py:
3540         (ValidatePatch._is_bug_closed):
3541
3542 2019-04-11  Michael Saboff  <msaboff@apple.com>
3543
3544         Improve the Inline Cache Stats code
3545         https://bugs.webkit.org/show_bug.cgi?id=196836
3546
3547         Reviewed by Saam Barati.
3548
3549         Added a new script to consolidate and arrange the output of --useICStats option.
3550
3551         This script merges the output from every group into one large table and sorts it from most common to
3552         least common.  It also counts the slow path GetById and PutById variants and then calculates the
3553         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
3554         Put together, this is useful to see what property accesses are not getting cached.
3555
3556         * Scripts/ic-stats.py: Added.
3557         (ICStats):
3558         (ICStats.__init__):
3559         (ICStats.parse):
3560         (ICStats.dumpStats):
3561         (usage):
3562
3563 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3564
3565         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
3566         https://bugs.webkit.org/show_bug.cgi?id=196809
3567         <rdar://49800762>
3568
3569         Reviewed by Brady Eidson.
3570
3571         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3572         (TEST):
3573
3574 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
3575
3576         requestAnimationFrame should execute before the next frame
3577         https://bugs.webkit.org/show_bug.cgi?id=177484
3578
3579         Reviewed by Simon Fraser.
3580
3581         Add trace points for the page RenderingUpdate.
3582
3583         * Tracing/SystemTracePoints.plist:
3584
3585 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3586
3587         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
3588         https://bugs.webkit.org/show_bug.cgi?id=196760
3589
3590         Reviewed by Don Olmstead.
3591
3592         vswhere.exe has been bundled since Visual Studio 2017 version
3593         15.2. We shouldn't download vswhere.exe.
3594
3595         * Scripts/build-jsc: Do not call update-vswhere.py.
3596         * Scripts/build-webkit: Ditto.
3597         * Scripts/update-vswhere.py: Removed.
3598         * Scripts/webkitdirs.pm:
3599         (requireModulesForVSWhere): Deleted.
3600         (pickCurrentVisualStudioInstallation): Deleted.
3601         (visualStudioInstallDirVSWhere): Return the latest installed VS
3602         installation path by using the bundled vswhere.exe.
3603         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
3604         (visualStudioInstallDirFallback): Removed.
3605
3606 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
3607
3608         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
3609         https://bugs.webkit.org/show_bug.cgi?id=196780
3610
3611         Reviewed by Alexey Proskuryakov.
3612
3613         * BuildSlaveSupport/ews-build/steps.py:
3614         * BuildSlaveSupport/ews-build/steps_unittest.py:
3615
3616 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3617
3618         Add SPI WKNavigationResponse._downloadAttribute
3619         https://bugs.webkit.org/show_bug.cgi?id=196755
3620         <rdar://49587365>
3621
3622         Reviewed by Brady Eidson.
3623
3624         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3625         (-[NavigationResponseTestDelegate navigationResponse]):
3626         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
3627         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
3628         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3629         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
3630         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3631         (readRequest):
3632         (writeResponse):
3633         (TEST):
3634
3635 2019-04-10  Tim Horton  <timothy_horton@apple.com>
3636
3637         Add modern API for overriding the page's specified viewport configuration
3638         https://bugs.webkit.org/show_bug.cgi?id=167734
3639         <rdar://problem/30331795>
3640
3641         Reviewed by Simon Fraser.
3642
3643         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3644         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
3645
3646 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
3647
3648         Add support for incremental bytecode cache updates
3649         https://bugs.webkit.org/show_bug.cgi?id=195000
3650
3651         Reviewed by Filip Pizlo.
3652
3653         Exit when the initial run to generate bytecode fails.
3654
3655         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3656
3657 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3658
3659         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
3660         https://bugs.webkit.org/show_bug.cgi?id=196744
3661         <rdar://49415309>
3662
3663         Reviewed by Chris Dumez.
3664
3665         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3666         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3667
3668 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3669
3670         Add a way to opt into modern compatibility mode in layout tests
3671         https://bugs.webkit.org/show_bug.cgi?id=196770
3672         <rdar://problem/49777550>
3673
3674         Reviewed by Antoine Quint.
3675
3676         Add a new test option to enable modern compatibility mode in layout tests.
3677
3678         * WebKitTestRunner/TestController.cpp:
3679         (WTR::updateTestOptionsFromTestHeader):
3680         * WebKitTestRunner/TestController.h:
3681         * WebKitTestRunner/TestOptions.h:
3682         (WTR::TestOptions::hasSameInitializationOptions const):
3683         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3684         (WTR::TestController::platformCreateWebView):
3685         (WTR::TestController::enableModernCompatibilityMode):
3686
3687 2019-04-10  Andy Estes  <aestes@apple.com>
3688
3689         Try to fix the 32-bit watchOS build.
3690
3691         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3692         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3693
3694 2019-04-10  Antoine Quint  <graouts@apple.com>
3695
3696         Enable Pointer Events on watchOS
3697         https://bugs.webkit.org/show_bug.cgi?id=196771
3698         <rdar://problem/49040909>
3699
3700         Reviewed by Dean Jackson.
3701
3702         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3703
3704 2019-04-10  Philippe Normand  <pnormand@igalia.com>
3705
3706         Unreviewed. Fix WPE accessibility tests after r244059.
3707
3708         We are failing to load the injected bundle due to undefined symbol
3709         AccessibilityUIElement::replaceTextInRange().
3710
3711         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
3712         (WTR::AccessibilityUIElement::replaceTextInRange):
3713
3714 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
3715
3716         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
3717         https://bugs.webkit.org/show_bug.cgi?id=196727
3718
3719         Reviewed by Fujii Hironori.
3720
3721         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3722         (WebKitBrowserWindow::create):
3723
3724 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
3725
3726         [ews-build] Add unit tests for PrintConfiguration
3727         https://bugs.webkit.org/show_bug.cgi?id=196752
3728
3729         Reviewed by Dewei Zhu.
3730
3731         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3732
3733 2019-04-09  Keith Rollin  <krollin@apple.com>
3734
3735         Unreviewed build maintenance -- update .xcfilelists.
3736
3737         * DumpRenderTree/DerivedSources-input.xcfilelist:
3738         * DumpRenderTree/DerivedSources-output.xcfilelist:
3739
3740 2019-04-09  Zalan Bujtas  <zalan@apple.com>
3741
3742         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
3743         https://bugs.webkit.org/show_bug.cgi?id=196743
3744         <rdar://problem/43897551>
3745
3746         Reviewed by Tim Horton.
3747
3748         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
3749         (TEST):
3750
3751 2019-04-09  Youenn Fablet  <youenn@apple.com>
3752
3753         Close service worker database on network process suspension
3754         https://bugs.webkit.org/show_bug.cgi?id=196623
3755         <rdar://problem/48930869>
3756
3757         Reviewed by Alex Christensen.
3758
3759         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3760
3761 2019-04-09  Daniel Bates  <dabates@apple.com>
3762
3763         [iPad] Should open popover when the spacebar is pressed
3764         https://bugs.webkit.org/show_bug.cgi?id=196360
3765         <rdar://problem/49389129>
3766
3767         Reviewed by Brent Fulgham.
3768
3769         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
3770
3771         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3772         (WTR::UIScriptController::isShowingPopover const): Added.
3773         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3774         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3775         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3776         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3777         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3778         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
3779         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
3780         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
3781         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
3782         (WTR::UIScriptController::isShowingPopover const): Added.
3783         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3784         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3785         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3786         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3787         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3788         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
3789         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
3790         (-[TestRunnerWKWebView _willPresentPopover]): Added.
3791         (-[TestRunnerWKWebView _didDismissPopover]): Added.
3792         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3793         (WTR::UIScriptController::isShowingPopover const): Added.
3794         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3795         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3796
3797 2019-04-09  Alex Christensen  <achristensen@webkit.org>
3798
3799         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3800         https://bugs.webkit.org/show_bug.cgi?id=196665
3801         <rdar://45115669>
3802
3803         Reviewed by Geoff Garen.
3804
3805         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3806         (goBack):
3807         (+[SimpleLookupContext sharedLookupContext]):
3808         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3809         (TEST):
3810         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3811         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3812
3813 2019-04-09  John Wilander  <wilander@apple.com>
3814
3815         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
3816         https://bugs.webkit.org/show_bug.cgi?id=196558
3817         <rdar://problem/47650245>
3818
3819         Reviewed by Youenn Fablet.
3820
3821         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3822         (TestWebKitAPI::TEST):
3823             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
3824
3825 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
3826
3827         [CMake] Apple builds should use ICU_INCLUDE_DIRS
3828         https://bugs.webkit.org/show_bug.cgi?id=196720
3829
3830         Reviewed by Konstantin Tokarev.
3831
3832         * TestWebKitAPI/PlatformMac.cmake:
3833
3834 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
3835
3836         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
3837         https://bugs.webkit.org/show_bug.cgi?id=196694
3838         <rdar://problem/48388734>
3839
3840         Rubber-stamped by Aakash Jain.
3841
3842         * Scripts/webkitpy/port/image_diff.py:
3843         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
3844         * Scripts/webkitpy/port/server_process.py:
3845         (ServerProcess.has_available_stdout): Check if stdout has data in it.
3846         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3847         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
3848         * Scripts/webkitpy/port/server_process_mock.py:
3849         (MockServerProcess.has_available_stdout):
3850         * Scripts/webkitpy/port/server_process_unittest.py:
3851         (TestServerProcess.serial_test_basic):
3852
3853 2019-04-09  Jer Noble  <jer.noble@apple.com>
3854
3855         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3856         https://bugs.webkit.org/show_bug.cgi?id=196097
3857
3858         Reviewed by Eric Carlson.
3859
3860         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3861
3862         * DumpRenderTree/mac/DumpRenderTree.mm:
3863         (resetWebPreferencesToConsistentValues):
3864         * WebKitTestRunner/TestController.cpp:
3865         (WTR::TestController::resetPreferencesToConsistentValues):
3866
3867 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
3868
3869         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
3870         https://bugs.webkit.org/show_bug.cgi?id=196690
3871
3872         Reviewed by Michael Catanzaro.
3873
3874         * QueueStatusServer/config/queues.py:
3875         * Scripts/webkitpy/common/config/ews.json:
3876         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3877         (test_ews_name):
3878
3879 2019-04-09  Chris Dumez  <cdumez@apple.com>
3880
3881         Loads using loadHTMLString() cause flashing when process-swapping
3882         https://bugs.webkit.org/show_bug.cgi?id=196714
3883         <rdar://problem/49637354>
3884
3885         Reviewed by Antti Koivisto.
3886
3887         Add API test coverage.
3888
3889         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3890
3891 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3892
3893         Unreviewed. Fix ATK accessibility tests after r244059.
3894
3895         We are failing to load the injected bundle due to undefined symbol
3896         AccessibilityUIElement::replaceTextInRange().
3897
3898         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3899         (WTR::AccessibilityUIElement::replaceTextInRange):
3900
3901 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3902
3903         AX: Support API: accessibilityReplaceRange:withText
3904         https://bugs.webkit.org/show_bug.cgi?id=196636
3905
3906         Unreviewed build fix for Windows port.
3907
3908         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3909         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
3910
3911 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
3912
3913         [CMake][WinCairo] Separate copied headers into different directories
3914         https://bugs.webkit.org/show_bug.cgi?id=196655
3915
3916         Reviewed by Michael Catanzaro.
3917
3918         * DumpRenderTree/CMakeLists.txt:
3919         * MiniBrowser/win/CMakeLists.txt:
3920         * TestWebKitAPI/CMakeLists.txt:
3921         * TestWebKitAPI/PlatformWin.cmake:
3922
3923 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
3924
3925         Log stack-trace for run-webkit-tests when interrupted
3926         https://bugs.webkit.org/show_bug.cgi?id=176393
3927         <rdar://problem/34262310>
3928
3929         Reviewed by Lucas Forschler.
3930
3931         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
3932         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
3933         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
3934         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
3935         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
3936         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3937         (main): Set handlers to log stack trace on interruption.
3938
3939 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3940
3941         AX: Support API: accessibilityReplaceRange:withText
3942         https://bugs.webkit.org/show_bug.cgi?id=196636
3943
3944         Unreviewed build fix for Windows port.
3945
3946         * DumpRenderTree/AccessibilityUIElement.cpp:
3947         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
3948
3949 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3950
3951         [ews-build] Scripts using Buildbot API have CORS error
3952         https://bugs.webkit.org/show_bug.cgi?id=196709
3953
3954         Reviewed by Alexey Proskuryakov.
3955
3956         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
3957
3958 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
3959
3960         AX: Support API: accessibilityReplaceRange:withText
3961         https://bugs.webkit.org/show_bug.cgi?id=196636
3962
3963         Reviewed by Daniel Bates.
3964
3965         * DumpRenderTree/AccessibilityUIElement.cpp:
3966         (replaceTextInRangeCallback):
3967         (AccessibilityUIElement::replaceTextInRange):
3968         (AccessibilityUIElement::getJSClass):
3969         * DumpRenderTree/AccessibilityUIElement.h:
3970         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3971         (AccessibilityUIElement::replaceTextInRange):
3972         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3973         (AccessibilityUIElement::replaceTextInRange):
3974         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3975         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3976         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3977         (WTR::AccessibilityUIElement::replaceTextInRange):
3978         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3979         (WTR::AccessibilityUIElement::replaceTextInRange):
3980
3981 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3982
3983         [iOS] Do not allow starting selection drags when selection views are not visible
3984         https://bugs.webkit.org/show_bug.cgi?id=196686
3985         <rdar://problem/49399192>
3986
3987         Reviewed by Tim Horton.
3988
3989         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
3990         also add some new API tests to cover scenarios where the web view is not first responder.
3991
3992         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3993         (TestWebKitAPI::TEST):
3994         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3995
3996         Add a switch to optionally make the web view first responder when starting the simulated drag.
3997
3998         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3999         (-[DragAndDropSimulator initWithWebView:]):
4000         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
4001
4002 2019-04-08  Justin Fan  <justin_fan@apple.com>
4003
4004         [Web GPU] Fix Web GPU experimental feature on iOS
4005         https://bugs.webkit.org/show_bug.cgi?id=196632
4006
4007         Reviewed by Myles C. Maxfield.
4008
4009         Properly make Web GPU available on iOS 11+.
4010
4011         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4012
4013 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
4014
4015         [ews-build] Do not upload archive when Compile Fails
4016         https://bugs.webkit.org/show_bug.cgi?id=196674
4017
4018         Reviewed by Alexey Proskuryakov.
4019
4020         * BuildSlaveSupport/ews-build/factories.py:
4021         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
4022         * BuildSlaveSupport/ews-build/steps.py:
4023         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
4024         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
4025         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
4026
4027 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
4028
4029         Enable DFG on MIPS
4030         https://bugs.webkit.org/show_bug.cgi?id=196689
4031
4032         Reviewed by Žan Doberšek.
4033
4034         Since the bytecode change, we enabled the baseline JIT on mips in
4035         r240432, but DFG is still missing. With this change, all tests are
4036         passing on a ci20 board.
4037
4038         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
4039
4040 2019-04-08  Philippe Normand  <pnormand@igalia.com>
4041
4042         [Flatpak] Second run update-webkitwpe-flatpak fails
4043         https://bugs.webkit.org/show_bug.cgi?id=192702
4044
4045         Reviewed by Carlos Garcia Campos.
4046
4047         * flatpak/flatpakutils.py:
4048         (FlatpakObject.flatpak): Fix typo.
4049         (FlatpakPackage.install): When installing, also update to the configured remote commit.
4050         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
4051
4052 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
4053
4054         [GTK][WPE] outlook.live.com displays old-fashioned UI
4055         https://bugs.webkit.org/show_bug.cgi?id=196642
4056
4057         Reviewed by Carlos Garcia Campos.
4058
4059         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4060         (TestWebKitAPI::TEST): New Mac platform quirk test.
4061
4062 2019-04-07  Commit Queue  <commit-queue@webkit.org>
4063
4064         Unreviewed, rolling out r243956.
4065         https://bugs.webkit.org/show_bug.cgi?id=196688
4066
4067         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
4068         by aakashjain on #webkit).
4069
4070         Reverted changeset:
4071
4072         "Clicking "Go Back" from a safe browsing warning from an
4073         iframe should navigate the WKWebView back to the previous
4074         page"
4075         https://bugs.webkit.org/show_bug.cgi?id=196665
4076         https://trac.webkit.org/changeset/243956
4077
4078 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
4079
4080         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
4081         https://bugs.webkit.org/show_bug.cgi?id=196669
4082
4083         Reviewed by Geoffrey Garen.
4084
4085         Added three new unit tests for WeakHashSet.
4086
4087         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4088         (WTF_WeakPtr.WeakHashSetConstObjects):
4089         (WTF_WeakPtr.WeakHashSetComputesEmpty):
4090         (WTF_WeakPtr.WeakHashSetComputeSize):
4091
4092 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
4093
4094         Hide next and previous form control buttons when WKWebView is editable
4095         https://bugs.webkit.org/show_bug.cgi?id=196672
4096         <rdar://problem/35625321>
4097
4098         Reviewed by Tim Horton.
4099
4100         Add a new API test.
4101
4102         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4103         (-[TestWKWebView lastTrailingBarButtonGroup]):
4104         (TestWebKitAPI::TEST):
4105         * TestWebKitAPI/ios/UIKitSPI.h:
4106
4107 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
4108
4109         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
4110         https://bugs.webkit.org/show_bug.cgi?id=196077
4111         <rdar://problem/49108202>
4112
4113         Reviewed by Chris Dumez.
4114
4115         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
4116         on new web view.
4117
4118         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4119
4120 2019-04-05  Saam Barati  <sbarati@apple.com>
4121
4122         Make compare-results understand MotionMark
4123         https://bugs.webkit.org/show_bug.cgi?id=196666
4124
4125         Reviewed by Yusuke Suzuki.
4126
4127         * Scripts/compare-results:
4128         (PLT5Results):
4129         (detectMotionMark):
4130         (detectMotionMark1_1):
4131         (motionMarkResults):
4132         (motionMark1_1Results):
4133         (detectBenchmark):
4134         (biggerIsBetter):
4135         (main):
4136
4137 2019-04-05  Alex Christensen  <achristensen@webkit.org>
4138
4139         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
4140         https://bugs.webkit.org/show_bug.cgi?id=196665
4141         <rdar://45115669>
4142
4143         Reviewed by Geoff Garen.
4144
4145         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4146         (goBack):
4147         (+[SimpleLookupContext sharedLookupContext]):
4148         (-[SimpleLookupContext lookUpURL:completionHandler:]):
4149         (TEST):
4150         (+[Simple3LookupContext sharedLookupContext]): Deleted.
4151         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
4152
4153 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
4154
4155         [ews-build] Add configuration and architecture for windows builders
4156         https://bugs.webkit.org/show_bug.cgi?id=196660
4157
4158         Reviewed by Lucas Forschler.
4159
4160         * BuildSlaveSupport/ews-build/config.json:
4161
4162 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
4163
4164         webkitpy: Don't run subsequent rounds if interrupted
4165         https://bugs.webkit.org/show_bug.cgi?id=196646
4166
4167         Reviewed by Aakash Jain.
4168
4169         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4170         (Manager.run): Bail out if interrupted.
4171
4172 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
4173
4174         Test sessionStorage in PSON private browsing mode
4175         https://bugs.webkit.org/show_bug.cgi?id=196561
4176
4177         Reviewed by Alex Christensen.
4178
4179         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4180
4181 2019-04-05  Commit Queue  <commit-queue@webkit.org>
4182
4183         Unreviewed, rolling out r243833.
4184         https://bugs.webkit.org/show_bug.cgi?id=196645
4185
4186         This change breaks build of WPE and GTK ports (Requested by
4187         annulen on #webkit).
4188
4189         Reverted changeset:
4190
4191         "[CMake][WTF] Mirror XCode header directories"
4192         https://bugs.webkit.org/show_bug.cgi?id=191662
4193         https://trac.webkit.org/changeset/243833
4194
4195 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
4196
4197         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
4198         https://bugs.webkit.org/show_bug.cgi?id=196635
4199
4200         Reviewed by Antti Koivisto.
4201         
4202         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
4203         for a test to enable async frame scrolling via:
4204             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
4205         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
4206         
4207         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
4208
4209         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4210         (WTR::InjectedBundle::beginTesting):
4211         * WebKitTestRunner/TestController.cpp:
4212         (WTR::TestController::resetPreferencesToConsistentValues):
4213
4214 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
4215
4216         Use a correct LC_RPATH when building with ASan
4217         https://bugs.webkit.org/show_bug.cgi?id=196576
4218
4219         Reviewed by David Kilzer.
4220
4221         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
4222         so that ../Frameworks is checked. This is simpler and more reliable than updating
4223         each SPC service xcconfig.
4224
4225 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4226
4227         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
4228         https://bugs.webkit.org/show_bug.cgi?id=196629
4229
4230         Reviewed by Lucas Forschler.
4231
4232         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4233
4234 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4235
4236         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
4237         https://bugs.webkit.org/show_bug.cgi?id=196618
4238
4239         Reviewed by Lucas Forschler.
4240
4241         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4242         (StatusBubble): Added QUEUE_TRIGGERS.
4243         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
4244         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
4245         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
4246         its parent(builder).
4247
4248 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4249
4250         [ews-app] Status-bubble steps are sometimes displayed in reverse order
4251         https://bugs.webkit.org/show_bug.cgi?id=196625
4252
4253         Reviewed by Lucas Forschler.
4254
4255         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4256         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
4257
4258 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4259
4260         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
4261         https://bugs.webkit.org/show_bug.cgi?id=196630
4262
4263         Reviewed by Wenson Hsieh.
4264
4265         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4266
4267 2019-04-04  Youenn Fablet  <youenn@apple.com>
4268
4269         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
4270         https://bugs.webkit.org/show_bug.cgi?id=196543
4271
4272         Reviewed by Alex Christensen.
4273
4274         * WebKitTestRunner/TestController.cpp:
4275         (WTR::TestController::generatePageConfiguration):
4276
4277 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4278
4279         [ews-app] Status bubble should not display skipped buildbot steps
4280         https://bugs.webkit.org/show_bug.cgi?id=196584
4281
4282         Reviewed by Lucas Forschler.
4283
4284         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4285
4286 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4287
4288         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
4289         https://bugs.webkit.org/show_bug.cgi?id=196620
4290
4291         Reviewed by Lucas Forschler.
4292
4293         * BuildSlaveSupport/ews-app/ews/config.py:
4294
4295 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
4296
4297         [Win] DumpRenderTreeWatchDog.py is not checked into source
4298         https://bugs.webkit.org/show_bug.cgi?id=196567
4299         <rdar://problem/49525901>
4300
4301         Reviewed by Lucas Forschler.
4302
4303         This script is used on Win EWS bots to terminate hanging DRT processes.
4304
4305         * EWSTools/dumprendertreewatchdog.py: Added.
4306
4307 2019-04-04  Chris Dumez  <cdumez@apple.com>
4308
4309         Unreviewed, roll out r243858 which made tests time out.
4310
4311         Disable new API tests on Windows instead.
4312
4313         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4314         (TestWebKitAPI::TEST):
4315
4316 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4317
4318         [ATK] Cleanup WebPageAccessibilityObjectAtk
4319         https://bugs.webkit.org/show_bug.cgi?id=196537
4320
4321         Reviewed by Michael Catanzaro.
4322
4323         Also consider files under atk directories as exceptions for GObject conventions.