[EFL] Bump efl version from 1.17 to 1.18
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
2
3         [EFL] Bump efl version from 1.17 to 1.18
4         https://bugs.webkit.org/show_bug.cgi?id=160899
5
6         Reviewed by Antonio Gomes.
7
8         To use efl-1.18, EFL port needs to update install dependencies as well.
9
10         * efl/install-dependencies:
11         * efl/jhbuild.modules:
12
13 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
14
15         [Win] Add tests for linked fonts.
16         https://bugs.webkit.org/show_bug.cgi?id=160898
17
18         Reviewed by Brent Fulgham.
19
20         Add tests for https://trac.webkit.org/changeset/204502.
21
22         * TestWebKitAPI/PlatformWin.cmake:
23         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
24         (TestWebKitAPI::TEST):
25
26 2016-08-16  Daniel Bates  <dabates@apple.com>
27
28         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
29         https://bugs.webkit.org/show_bug.cgi?id=160924
30
31         Reviewed by Stephanie Lewis.
32
33         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
34         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
35         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
36         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
37         object that mocks out the file system and SCM operations.
38
39         * Scripts/VCSUtils.pm:
40         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
41         * Scripts/prepare-ChangeLog:
42         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
43         abstracting the logic to query the file system and SCM into functions on a delegate object that
44         we pass to it.
45         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
46         (diffHeaderFormat): Deleted.
47
48 2016-08-16  Alex Christensen  <achristensen@webkit.org>
49
50         URLParser should parse URLs without credentials
51         https://bugs.webkit.org/show_bug.cgi?id=160913
52
53         Reviewed by Brady Eidson.
54
55         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
56         (TestWebKitAPI::s):
57         (TestWebKitAPI::checkURL):
58         (TestWebKitAPI::TEST_F):
59
60 2016-08-16  Anders Carlsson  <andersca@apple.com>
61
62         Add WTF::ScopeExit
63         https://bugs.webkit.org/show_bug.cgi?id=160908
64
65         Reviewed by Geoffrey Garen.
66
67         * TestWebKitAPI/CMakeLists.txt:
68         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
69         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
70         (TestWebKitAPI::TEST):
71
72 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
73
74         EWS logs file are rotated too quickly
75         https://bugs.webkit.org/show_bug.cgi?id=160724
76
77         Reviewed by Daniel Bates.
78
79         Currently we are rotating the log file after 10 iterations of queue. If the queue
80         doesn't have any pending patches, these iterations result in very small amount of 
81         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
82         This results in a lot of log files in a day. This patch ensures that we rotate the
83         log file when its file size is greater than or equal to 100 KB.
84
85         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
86
87 2016-08-16  Daniel Bates  <dabates@apple.com>
88
89         WKSI static library should be named by major iOS revision, not individual updates
90         https://bugs.webkit.org/show_bug.cgi?id=160727
91         <rdar://problem/22274848>
92
93         Reviewed by Alexey Proskuryakov.
94
95         * DumpRenderTree/mac/Configurations/Base.xcconfig:
96         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
97         * Scripts/copy-webkitlibraries-to-product-directory:
98         * WebKitTestRunner/Configurations/Base.xcconfig:
99         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
100
101 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
102
103         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
104         https://bugs.webkit.org/show_bug.cgi?id=160909
105
106         Reviewed by Enrica Casucci.
107         
108         Add functions to UIScriptController to dismiss the form accessory view for iOS,
109         and to programmatically pick a row from a <select> picker.
110
111         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
112         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
113         (WTR::UIScriptController::dismissFormAccessoryView):
114         (WTR::UIScriptController::selectFormAccessoryPickerRow):
115         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
116         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
117         (WTR::UIScriptController::dismissFormAccessoryView):
118         (WTR::UIScriptController::selectFormAccessoryPickerRow):
119
120 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
121
122         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
123         https://bugs.webkit.org/show_bug.cgi?id=160878
124
125         Reviewed by Tim Horton.
126         
127         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
128         now that we have the ability to run tests in the iPad simulator.
129
130         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
131         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
132         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
133         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
134         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
135         * WebKitTestRunner/ios/TestControllerIOS.mm:
136         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
137         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
138         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
139         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
140
141 2016-08-15  Anders Carlsson  <andersca@apple.com>
142
143         Add an address-of operator to RetainPtr
144         https://bugs.webkit.org/show_bug.cgi?id=160879
145
146         Reviewed by Tim Horton.
147
148         Test HashMap and HashSet with an object whose operator& is deleted.
149
150         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
151         Sort the Xcode project.
152
153         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
154         (DeletedAddressOfOperator::DeletedAddressOfOperator):
155         (DeletedAddressOfOperator::value):
156         (DeletedAddressOfOperator::operator==):
157         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
158         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
159         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
160         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
161         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
162         (TestWebKitAPI::TEST):
163         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
164         (TestWebKitAPI::TEST):
165
166 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
167
168         False crashes in fast/text/emoji-gender-* tests
169         https://bugs.webkit.org/show_bug.cgi?id=160779
170
171         Reviewed by Alexey Proskuryakov.
172
173         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
174
175         * Scripts/webkitpy/port/driver.py:
176         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
177         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
178         * Scripts/webkitpy/port/server_process.py:
179         (ServerProcess.write): Allow caller to disable crash flag on exception.
180
181 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
182
183         webkitpy error in TestRunResults.merge()
184         https://bugs.webkit.org/show_bug.cgi?id=160882
185
186         Reviewed by Daniel Bates.
187         
188         The argument to TestRunResults.merge() can be None if there are no device-specifc
189         initial results or retry results in Manager.run(), so just return early in that case.
190
191         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
192         (TestRunResults.merge):
193
194 2016-08-15  Sam Weinig  <sam@webkit.org>
195
196         Speed up compile times by not including wtf/Variant.h so much
197         https://bugs.webkit.org/show_bug.cgi?id=160847
198
199         Reviewed by Alex Christensen and Saam Barati.
200
201         * TestWebKitAPI/Tests/WTF/Variant.cpp:
202         (TestWebKitAPI::TEST):
203         Explicitly use std::experimental::variant.
204
205 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
206
207         Allow a port to run tests with a custom device setup
208         https://bugs.webkit.org/show_bug.cgi?id=160833
209
210         Reviewed by Daniel Bates.
211
212         These changes allow the IOSSimulator port to run tests in iPad mode.
213
214         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
215         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
216         a custom device will be collected into a set, and run in that device's environment after
217         the other tests have run.
218
219         * Scripts/webkitpy/layout_tests/controllers/manager.py:
220         (Manager._custom_device_for_test): If the test contains a directory matching a
221         custom device suffix, return that custom device.
222         (Manager._set_up_run): Push the custom device class, if any, into options so
223         that the Worker can get to it.
224         (Manager.run): Go through the list of tests, and break it down into device-generic
225         tests, and tests for each device class. _run_test_subset is then called for
226         each collection of tests, and the results merged.
227         (Manager._run_test_subset): Some lines unwrapped.
228         (Manager._end_test_run):
229         (Manager._run_tests):
230         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
231         (SingleTestRunner.__init__): Unwrapped a line.
232         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
233         (TestRunResults.merge): Add this function to merge TestRunResults
234         * Scripts/webkitpy/layout_tests/views/printing.py:
235         (Printer.print_workers_and_shards): Print the custom device, if any.
236         * Scripts/webkitpy/port/base.py:
237         (Port): Base port has empty array of custom devices.
238         (Port.setup_test_run): Add device_class argument.
239         * Scripts/webkitpy/port/driver.py:
240         (DriverInput.__repr__):
241         (Driver.check_driver.implementation):
242         * Scripts/webkitpy/port/efl.py:
243         (EflPort.setup_test_run):
244         * Scripts/webkitpy/port/gtk.py:
245         (GtkPort.setup_test_run):
246         * Scripts/webkitpy/port/ios.py:
247         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
248         (IOSSimulatorPort.__init__):
249         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
250         based on the custom device class.
251         (IOSSimulatorPort._set_device_class):
252         (IOSSimulatorPort._create_simulators): Factor some code into this function.
253         (IOSSimulatorPort.setup_test_run):
254         (IOSSimulatorPort.testing_device):
255         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
256         seemed wrong for this function. That was moved to setup_test_run().
257         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
258         but this happened too early, before we knew which kind of devices to create. Devices
259         are now created in setup_test_run().
260         * Scripts/webkitpy/port/win.py:
261         (WinPort.setup_test_run):
262
263 2016-08-15  Daniel Bates  <dabates@apple.com>
264
265         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
266         private frameworks and libraries
267         https://bugs.webkit.org/show_bug.cgi?id=155931
268         <rdar://problem/25807989>
269
270         Reviewed by Dan Bernstein.
271
272         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
273         where X is the major version of the active iOS SDK.
274
275         * DumpRenderTree/mac/Configurations/Base.xcconfig:
276         * WebKitTestRunner/Configurations/Base.xcconfig:
277
278 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
279
280         Add a setting and preferences to enable visual viewport mode
281         https://bugs.webkit.org/show_bug.cgi?id=160843
282
283         Reviewed by Sam Weinig.
284         
285         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
286
287         * MiniBrowser/mac/SettingsController.h:
288         * MiniBrowser/mac/SettingsController.m:
289         (-[SettingsController _populateMenu]):
290         (-[SettingsController validateMenuItem:]):
291         (-[SettingsController visualViewportEnabled]):
292         (-[SettingsController toggleVisualViewportEnabled:]):
293         * MiniBrowser/mac/WK1BrowserWindowController.m:
294         (-[WK1BrowserWindowController didChangeSettings]):
295         * MiniBrowser/mac/WK2BrowserWindowController.m:
296         (-[WK2BrowserWindowController didChangeSettings]):
297
298 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
299
300         Allow using make-dist with non-GTK ports
301         https://bugs.webkit.org/show_bug.cgi?id=160842
302
303         Reviewed by Michael Catanzaro.
304
305         This patch adds support for setting base name of tarball and argument
306         passed to cmake's -DPORT= via command line arguments.
307
308         * gtk/make-dist.py:
309         (Distcheck.configure):
310         (Distcheck.check):
311         (get_tarball_root_and_output_filename_from_arguments):
312
313 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
314
315         [GTK] Install script lacks gstreamer related dependencies
316         https://bugs.webkit.org/show_bug.cgi?id=160814
317
318         Reviewed by Carlos Garcia Campos.
319
320         * gtk/install-dependencies: Fedora case had already listed this dependencies,
321         but both Arch and Debian/Ubuntu were missing them.
322
323 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
324
325         make-dist.py should not allow unknown rules in manifest
326         https://bugs.webkit.org/show_bug.cgi?id=160841
327
328         Reviewed by Carlos Garcia Campos.
329
330         * gtk/make-dist.py:
331         (Manifest.process_line):
332
333 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
334
335         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
336         https://bugs.webkit.org/show_bug.cgi?id=160809
337
338         Reviewed by Carlos Garcia Campos.
339
340         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
341         case, and use it also for the new package names of libpng and libgeoclue.
342         * gtk/install-dependencies: Ditto.
343
344 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
345
346         Skip to check directories existence in build-webkit
347         https://bugs.webkit.org/show_bug.cgi?id=160691
348
349         Reviewed by Alex Christensen.
350
351         CMake checks if directories are there itself. So CMake ports
352         don't need to check it in the build-webkit script.
353
354         * Scripts/build-webkit:
355         * Scripts/webkitdirs.pm:
356         (determineSourceDir):
357         (isCMakeBuild):
358
359 2016-08-12  Alex Christensen  <achristensen@webkit.org>
360
361         Make URLParser work with URLs missing URL parts
362         https://bugs.webkit.org/show_bug.cgi?id=160824
363
364         Reviewed by Brady Eidson.
365
366         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
367         (TestWebKitAPI::s):
368         (TestWebKitAPI::checkURL):
369         (TestWebKitAPI::TEST_F):
370         (TestWebKitAPI::eq): Deleted.
371
372 2016-08-12  John Wilander  <wilander@apple.com>
373
374         Add HashCountedSet API tests to TestWTFLibrary target
375         https://bugs.webkit.org/show_bug.cgi?id=160815
376
377         Reviewed by Alex Christensen.
378
379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
380             Added HashCountedSet.cpp and sorted the file reference section
381             according to UNIX sort.
382
383 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
384
385         run-benchmark should run JetStream 1.1 instead of 1.0.1
386         https://bugs.webkit.org/show_bug.cgi?id=160816
387
388         Reviewed by Filip Pizlo.
389
390         Use the latest JetStream 1.1 in run-benchmark.
391
392         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
393         (BenchmarkBuilder.__exit__):
394         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
395         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
396         change to JetStream directory.
397
398 2016-08-12  Alex Christensen  <achristensen@webkit.org>
399
400         Initial URLParser implementation
401         https://bugs.webkit.org/show_bug.cgi?id=160811
402
403         Reviewed by Brady Eidson.
404
405         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
406         (TestWebKitAPI::eq):
407         (TestWebKitAPI::checkURL):
408         (TestWebKitAPI::TEST_F):
409
410 2016-08-12  Brady Eidson  <beidson@apple.com>
411
412         Fix the 32-bit Mac build after:
413         Add WK2 ExperimentalFeature support to MiniBrowser
414         https://bugs.webkit.org/show_bug.cgi?id=160788
415
416         Unreviewed.
417
418         Sprinkle "#if WK_API_ENABLED"s liberally.
419         
420         * MiniBrowser/mac/AppDelegate.m:
421         (defaultConfiguration):
422         * MiniBrowser/mac/SettingsController.m:
423         (-[SettingsController _populateMenu]):
424         (-[SettingsController validateMenuItem:]):
425
426 2016-08-12  Philippe Normand  <pnormand@igalia.com>
427
428         [GStreamer][OWR] Video rendering fixes
429         https://bugs.webkit.org/show_bug.cgi?id=160764
430
431         Reviewed by Xabier Rodriguez-Calvar.
432
433         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
434
435 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
436
437         Add missing return statement in convertFast function added in r204376.
438
439         Unreviewed.
440
441         * Scripts/webkitpy/common/system/path.py:
442         (_CygPath.convertFast):
443
444 2016-08-11  Brady Eidson  <beidson@apple.com>
445
446         Add WK2 ExperimentalFeature support to MiniBrowser.
447         https://bugs.webkit.org/show_bug.cgi?id=160788
448
449         Reviewed by Alex Christensen.
450
451         * MiniBrowser/mac/AppDelegate.h:
452         * MiniBrowser/mac/AppDelegate.m:
453         (defaultConfiguration):
454         (defaultPreferences):
455         
456         * MiniBrowser/mac/SettingsController.m:
457         (-[SettingsController _populateMenu]):
458         (-[SettingsController validateMenuItem:]):
459         (-[SettingsController toggleExperimentalFeature:]):
460
461 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
462
463         Keep EWS logs for longer
464         https://bugs.webkit.org/show_bug.cgi?id=160776
465
466         Reviewed by Daniel Bates.
467
468         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
469
470 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
471
472         iOS DRT/WTR project cleanup
473         https://bugs.webkit.org/show_bug.cgi?id=160778
474
475         Reviewed by Tim Horton.
476
477         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
478
479         Remove AppDelegate.* which were unused.
480
481         Exclude ios/Launch.storyboard on more platforms.
482
483         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
484         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
485         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
486         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
487         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
488         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
489         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
490
491 2016-08-11  Alex Christensen  <achristensen@webkit.org>
492
493         Fix Yosemite bots' cookie accept policies after r204365.
494         https://bugs.webkit.org/show_bug.cgi?id=160758
495
496         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
497         (TEST):
498         This makes the test fully clean up after itself.
499
500 2016-08-11  Alex Christensen  <achristensen@webkit.org>
501
502         Fix Yosemite bots' cookie accept policies after r204365.
503         https://bugs.webkit.org/show_bug.cgi?id=160758
504
505         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
506         (TEST):
507         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
508         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
509         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
510         causing any problems because there are no other API tests that do anything with cookies.
511         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
512         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
513         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
514
515 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
516
517         EWS should check if the patch is still valid before executing every major step
518         https://bugs.webkit.org/show_bug.cgi?id=160739
519         rdar://problem/27768813
520
521         Reviewed by Alexey Proskuryakov.
522
523         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
524         (CommitQueueTask.run): validate method is now executed in base class.
525         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
526         (EarlyWarningSystemTask.run): validate method is now executed in base class.
527         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
528         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
529         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
530         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
531         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
532         * Scripts/webkitpy/tool/commands/perfalizer.py:
533         (PerfalizerTask.validate): Added.
534         * Scripts/webkitpy/tool/commands/queues_unittest.py:
535         (test_manual_reject_during_processing): Updated test case.
536
537 2016-08-11  Alex Christensen  <achristensen@webkit.org>
538
539         Add URLParser stub
540         https://bugs.webkit.org/show_bug.cgi?id=160770
541
542         Reviewed by Sam Weinig.
543
544         * TestWebKitAPI/PlatformGTK.cmake:
545         * TestWebKitAPI/PlatformWin.cmake:
546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
547         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
548         (TestWebKitAPI::TEST_F):
549
550 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
551
552         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
553         https://bugs.webkit.org/show_bug.cgi?id=160761
554
555         Reviewed by Tim Horton.
556
557         Give iOS DRT a Launch storyboard.
558
559         Have it use a UIViewController so future forms testing works correctly.
560
561         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
562         can run in iPad mode.
563
564         Remove empty InfoPlist.strings files.
565
566         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
567         * DumpRenderTree/ios/Info.plist:
568         * DumpRenderTree/ios/Launch.storyboard: Added.
569         * DumpRenderTree/mac/DumpRenderTree.mm:
570         (createWebViewAndOffscreenWindow):
571         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
572         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
573         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
574         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
575
576 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
577
578         [Win] Unable to reliably run tests in parallel
579         https://bugs.webkit.org/show_bug.cgi?id=140914
580
581         Reviewed by Brent Fulgham.
582
583         The cygpath utility function can fail badly when running with multiple DumpRenderTree
584         processes. We can use string replacement to convert the Cygwin path to a Windows path
585         instead.
586
587         * Scripts/webkitpy/common/system/path.py:
588         (cygpathFast):
589         * Scripts/webkitpy/port/driver.py:
590         (Driver._command_from_driver_input):
591
592 2016-08-10  Alex Christensen  <achristensen@webkit.org>
593
594         Fix crash when changing cookie accept policy after r204327
595         https://bugs.webkit.org/show_bug.cgi?id=160758
596
597         Reviewed by Simon Fraser.
598
599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
600         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
601         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
602         (TEST):
603         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
604
605 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
606
607         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
608         https://bugs.webkit.org/show_bug.cgi?id=160757
609
610         Reviewed by Tim Horton.
611
612         When programmatically creating the test UIWindow, make a root UIViewController and parent
613         the WKWebView in its view. This makes the app more like a normal UIKit application.
614         
615         Move the WKWebView down 20px to avoid the status bar.
616         
617         Give the UIWindow a gray background so it's obvious where the window and view positioned.
618
619         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
620         
621         Remove duplicate references to Launch.storyboard.
622
623         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
624         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
625         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
626         (-[AppDelegate applicationWillResignActive:]): Deleted.
627         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
628         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
629         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
630         (-[AppDelegate applicationWillTerminate:]): Deleted.
631         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
632         (WTR::viewRectForWindowRect):
633         (WTR::PlatformWebView::PlatformWebView):
634         (WTR::PlatformWebView::setWindowFrame):
635
636 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
637
638         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
639         https://bugs.webkit.org/show_bug.cgi?id=160748
640
641         Reviewed by Tim Horton.
642         
643         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
644         opens the door for tests using other device sizes.
645
646         * WebKitTestRunner/ios/TestControllerIOS.mm:
647         (WTR::TestController::platformConfigureViewForTest):
648
649 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
650
651         Sort the feature flags in the FEATURE_DEFINES lines
652         https://bugs.webkit.org/show_bug.cgi?id=160742
653
654         Reviewed by Anders Carlsson.
655         
656         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
657
658 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
659
660         Logging and other minor improvements to iOS webkitpy
661         https://bugs.webkit.org/show_bug.cgi?id=160722
662
663         Reviewed by Dan Bates.
664
665         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
666         to make it easier to debug launching issues.
667
668         Have reset_preferences() reset the device, rather than just nuking the data
669         directory (which broke some versions of the simulator).
670
671         Make the Simulator.app launch in the background with open -g.
672
673         Wait for the simulator device to be in a known state in some more places.
674
675         * Scripts/webkitpy/port/ios.py:
676         (IOSSimulatorPort.setup_test_run):
677         (IOSSimulatorPort._quit_ios_simulator):
678         (IOSSimulatorPort.clean_up_test_run):
679         (IOSSimulatorPort.setup_environ_for_server):
680         (IOSSimulatorPort.reset_preferences):
681         * Scripts/webkitpy/xcode/simulator.py:
682         (Device.create):
683         (Device.delete):
684         (Device):
685         (Device.reset):
686         (Simulator.wait_until_device_is_booted):
687         (Simulator.wait_until_device_is_in_state):
688         (Simulator):
689         (Simulator.delete_device):
690         (Simulator.reset_device):
691         (Simulator.lookup_or_create_device):
692
693 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
694
695         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
696         https://bugs.webkit.org/show_bug.cgi?id=160697
697
698         Reviewed by Antonio Gomes.
699
700         * Scripts/webkitpy/port/base.py:
701         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
702         list of environment variables to copy.
703
704 2016-08-09  George Ruan  <gruan@apple.com>
705
706         Implement functionality of media capture on iOS
707         https://bugs.webkit.org/show_bug.cgi?id=158945
708         <rdar://problem/26893343>
709
710         Reviewed by Tim Horton.
711
712         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
713         Capture feature on iOS.
714
715 2016-08-09  Saam Barati  <sbarati@apple.com>
716
717         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
718         https://bugs.webkit.org/show_bug.cgi?id=160671
719         <rdar://problem/27756112>
720
721         Reviewed by Mark Lam.
722
723         * Scripts/run-jsc-stress-tests:
724
725 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
726
727         Make directory reading code in iOSSimulatorDevices() more strict
728         https://bugs.webkit.org/show_bug.cgi?id=160702
729
730         Reviewed by Tim Horton.
731
732         * Scripts/webkitdirs.pm:
733         (iOSSimulatorDevices):
734
735 2016-08-06  Sam Weinig  <sam@webkit.org>
736
737         Replace NodeOrString with std::variant<RefPtr<Node>, String>
738         https://bugs.webkit.org/show_bug.cgi?id=160638
739
740         Reviewed by Anders Carlsson.
741
742         * TestWebKitAPI/CMakeLists.txt:
743         * TestWebKitAPI/Tests/WTF/Variant.cpp:
744         Add additional tests for the initial state of std::variant and using
745         makeVisitor for visiting.
746
747 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
748
749         EWS logging should ensure the logging to file is stopped on queue termination
750         https://bugs.webkit.org/show_bug.cgi?id=160698
751         rdar://problem/24464570
752
753         Reviewed by Daniel Bates.
754
755         * Scripts/webkitpy/tool/bot/queueengine.py:
756         (QueueEngine._stopping): Stop logging to file on queue termination.
757         (QueueEngine._begin_logging): Configure the Python logger to log to file.
758         * Scripts/webkitpy/common/system/logutils.py:
759         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
760         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
761         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
762         * Scripts/webkitpy/tool/commands/queues.py:
763         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
764         (AbstractQueue.queue_log_path): Same.
765         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
766         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
767         which moved to QueueEngine now.
768         (PatchProcessingQueue.__init__): Same.
769         (CommitQueue.__init__): Same.
770         (AbstractReviewQueue.__init__): Same.
771         (StyleQueue.__init__): Same.
772         * Scripts/webkitpy/tool/commands/queues_unittest.py:
773         (TestCommitQueue): Removed host parameter.
774         (TestCommitQueue.__init__): Same.
775         (AbstractPatchQueueTest.test_next_patch): Same.
776         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
777         (test_commit_queue_failure): Same.
778         (mock_run_webkit_patch):
779         (MockCommitQueueTask.results_from_patch_test_run): Same.
780         (test_rollout_lands): Same.
781         (test_non_valid_patch): Same.
782         (test_auto_retry): Same.
783         (test_style_queue_with_watch_list_exception): Same.
784         (TestQueue.__init__): Deleted.
785         (TestReviewQueue.__init__): Deleted.
786         (TestFeederQueue.__init__): Deleted.
787
788 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
789
790         webkit-gtk tarball fails to build due to missing files
791         https://bugs.webkit.org/show_bug.cgi?id=160684
792
793         Reviewed by Alex Christensen.
794
795         * gtk/manifest.txt.in: Added back spi directories.
796
797 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
798
799         [GTK] Build the jhbuild with -O2 optimization level by default
800         https://bugs.webkit.org/show_bug.cgi?id=160544
801
802         Reviewed by Michael Catanzaro.
803
804         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
805         which don't increases the required disk space significatively and
806         provides better debug information than no passing it.
807
808 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
809
810         Allow more --cmakeargs option in build-jsc and build-webkit
811         https://bugs.webkit.org/show_bug.cgi?id=160340
812
813         Reviewed by Michael Catanzaro.
814
815         * Scripts/build-jsc:
816         * Scripts/build-webkit:
817
818 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
819
820         Do not check if WebKitLibraries folder exists on EFL and GTK
821         https://bugs.webkit.org/show_bug.cgi?id=160659
822
823         Reviewed by Csaba Osztrogonác.
824
825         Though WebKitLibraries is only needed by mac and win ports,
826         EFL and GTK ports have checked whether it exists.
827
828         * Scripts/build-webkit:
829
830 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
831
832         Some EWS console logs doesn't go to log file
833         https://bugs.webkit.org/show_bug.cgi?id=160585
834         rdar://problem/24464570
835
836         Reviewed by Daniel Bates.
837
838         * Scripts/webkitpy/common/system/logutils.py:
839         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
840         any possible overwriting.
841         * Scripts/webkitpy/common/system/filesystem.py:
842         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
843         * Scripts/webkitpy/common/system/filesystem_mock.py:
844         (MockFileSystem.open_text_file_for_writing): Same.
845         * Scripts/webkitpy/common/system/filesystem_unittest.py:
846         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
847         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
848         * Scripts/webkitpy/tool/commands/queues.py:
849         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
850         This will ensure that all the sub-modules inside webkitpy will log to file.
851
852 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
853
854         Have the iOS platform interit from the Apple platform in webkitpy
855         https://bugs.webkit.org/show_bug.cgi?id=160672
856
857         Reviewed by Dan Bates.
858         
859         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
860         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
861         ApplePort.
862         
863         Since WinPort also inherits from ApplePort, it needs to stub out some things
864         that are unavailable on Windows (leaks, sampling).
865         
866         Some SnowLeopard-related code and the associated test were removed.
867
868         * Scripts/webkitpy/port/apple.py:
869         (ApplePort.__init__):
870         (ApplePort):
871         (ApplePort._make_leak_detector):
872         (ApplePort.default_timeout_ms):
873         (ApplePort.supports_per_test_timeout):
874         (ApplePort.should_retry_crashes):
875         (ApplePort._generate_all_test_configurations):
876         (ApplePort.check_for_leaks):
877         (ApplePort.print_leaks_summary):
878         (ApplePort._path_to_webcore_library):
879         (ApplePort.show_results_html_file):
880         (ApplePort._merge_crash_logs):
881         (ApplePort._look_for_all_crash_logs_in_log_dir):
882         (ApplePort._get_crash_log):
883         (ApplePort.look_for_new_crash_logs):
884         (ApplePort.sample_process):
885         (ApplePort.sample_file_path):
886         (ApplePort.look_for_new_samples):
887         (ApplePort._path_to_helper):
888         (ApplePort.determine_full_port_name): Deleted.
889         * Scripts/webkitpy/port/ios.py:
890         (IOSSimulatorPort):
891         (IOSSimulatorPort.__init__):
892         (IOSSimulatorPort.default_timeout_ms): Deleted.
893         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
894         (IOSSimulatorPort.should_retry_crashes): Deleted.
895         (IOSSimulatorPort.check_for_leaks): Deleted.
896         (IOSSimulatorPort.print_leaks_summary): Deleted.
897         (IOSSimulatorPort._path_to_webcore_library): Deleted.
898         (IOSSimulatorPort.show_results_html_file): Deleted.
899         (IOSSimulatorPort.sample_file_path): Deleted.
900         (IOSSimulatorPort._merge_crash_logs): Deleted.
901         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
902         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
903         (IOSSimulatorPort.look_for_new_samples): Deleted.
904         (IOSSimulatorPort.sample_process): Deleted.
905         (IOSSimulatorPort._path_to_helper): Deleted.
906         (IOSSimulatorPort.make_command): Deleted.
907         * Scripts/webkitpy/port/mac.py:
908         (MacPort.__init__):
909         (MacPort.make_command):
910         (MacPort._build_java_test_support):
911         (MacPort): Deleted.
912         (MacPort.default_timeout_ms): Deleted.
913         (MacPort.supports_per_test_timeout): Deleted.
914         (MacPort.should_retry_crashes): Deleted.
915         (MacPort.default_child_processes): Deleted.
916         (MacPort.check_for_leaks): Deleted.
917         (MacPort.print_leaks_summary): Deleted.
918         (MacPort._path_to_webcore_library): Deleted.
919         (MacPort.show_results_html_file): Deleted.
920         (MacPort.sample_file_path): Deleted.
921         (MacPort._merge_crash_logs): Deleted.
922         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
923         (MacPort.look_for_new_crash_logs): Deleted.
924         (MacPort.look_for_new_samples): Deleted.
925         (MacPort.sample_process): Deleted.
926         (MacPort._path_to_helper): Deleted.
927         * Scripts/webkitpy/port/mac_unittest.py:
928         (MacTest.test_default_child_processes): Deleted.
929         * Scripts/webkitpy/port/win.py:
930         (WinPort.look_for_new_samples):
931         (WinPort):
932         (WinPort.sample_process):
933         (WinPort._make_leak_detector):
934         (WinPort.check_for_leaks):
935         (WinPort.print_leaks_summary):
936         (WinPort._path_to_webcore_library):
937
938 2016-08-08  Matt Baker  <mattbaker@apple.com>
939
940         Unreviewed: moved myself to the reviewers list.
941
942         * Scripts/webkitpy/common/config/contributors.json:
943
944 2016-08-08  Chris Dumez  <cdumez@apple.com>
945
946         Update API tests in mac/SetDocumentURI.mm after r204247
947         https://bugs.webkit.org/show_bug.cgi?id=160660
948
949         Reviewed by Alex Christensen.
950
951         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
952         (TestWebKitAPI::TEST):
953
954 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
955
956         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
957         https://bugs.webkit.org/show_bug.cgi?id=159827
958
959         Reviewed by Daniel Bates.
960
961         This change was spurred by a process hang which occurred between tests and did
962         not produce a meaningful crashlog.
963
964         * Scripts/webkitpy/port/driver.py:
965         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
966
967          * Scripts/webkitpy/port/ios.py:
968         (IOSSimulatorPort):
969         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
970         * Scripts/webkitpy/port/mac.py:
971         (MacPort):
972         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
973
974         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
975         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
976
977         * WebKitTestRunner/TestController.h:
978         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
979         * WebKitTestRunner/TestInvocation.cpp:
980         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
981
982 2016-08-07  Dan Bernstein  <mitz@apple.com>
983
984         [Cocoa] Reply block leaks if the remote object doesn’t call it
985         https://bugs.webkit.org/show_bug.cgi?id=160642
986
987         Reviewed by Sam Weinig.
988
989         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
990         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
991         (TEST): Added a test case that checks that the reply block is released even when it’s not
992           called.
993         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
994         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
995           calling the completion handler.
996
997 2016-08-07  Chris Dumez  <cdumez@apple.com>
998
999         Write API test to cover crash fix in r204135
1000         https://bugs.webkit.org/show_bug.cgi?id=160587
1001
1002         Reviewed by Darin Adler.
1003
1004         Add API test to cover crash fix in r204135. This reproduces the crash
1005         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1006         callback.
1007
1008         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1009         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1010         (TEST):
1011
1012 2016-08-06  Chris Dumez  <cdumez@apple.com>
1013
1014         Unreviewed, rolling out r204226.
1015
1016         Broke some API tests
1017
1018         Reverted changeset:
1019
1020         "Write API test to cover crash fix in r204135"
1021         https://bugs.webkit.org/show_bug.cgi?id=160587
1022         http://trac.webkit.org/changeset/204226
1023
1024 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
1025
1026         EWS Style Queue fails to process patches which fails validation
1027         https://bugs.webkit.org/show_bug.cgi?id=160632
1028
1029         Reviewed by Alexey Proskuryakov.
1030
1031         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1032         (StyleQueueTask.validate): Add more information about validation failure.
1033         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1034         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1035         (test_non_valid_patch): Add a unit test to test the above code path.
1036
1037 2016-08-06  Sam Weinig  <sam@webkit.org>
1038
1039         WTF needs a variant implementation
1040         https://bugs.webkit.org/show_bug.cgi?id=160618
1041
1042         Reviewed by Darin Adler.
1043
1044         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1045         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
1046         Add tests for the variant implementation.
1047
1048 2016-08-06  Chris Dumez  <cdumez@apple.com>
1049
1050         Write API test to cover crash fix in r204135
1051         https://bugs.webkit.org/show_bug.cgi?id=160587
1052
1053         Reviewed by Darin Adler.
1054
1055         Add API test to cover crash fix in r204135. This reproduces the crash
1056         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1057         callback.
1058
1059         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1060         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1061         (TEST):
1062
1063 2016-08-05  Tim Horton  <timothy_horton@apple.com>
1064
1065         run-api-tests should use a headed simulator
1066         https://bugs.webkit.org/show_bug.cgi?id=160611
1067
1068         Reviewed by Sam Weinig.
1069
1070         CADisplayLink doesn't work in a headless simulator, but is
1071         vital for the proper functioning of WebKit2 painting on iOS.
1072         So, we should not use a headless simulator.
1073
1074         * Scripts/run-api-tests:
1075         Launch a simulator app, don't just boot the simulator.
1076
1077         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1078         Re-enable a test that works now.
1079
1080 2016-08-05  Dan Bernstein  <mitz@apple.com>
1081
1082         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
1083         https://bugs.webkit.org/show_bug.cgi?id=160589
1084
1085         Reviewed by Tim Horton.
1086
1087         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1088         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
1089           blocks, which wasn’t caught because the test wasn’t run correctly.
1090         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1091         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
1092           added a test that sends over an NSRange.
1093         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1094         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
1095           handler with the range‘s location and length.
1096
1097 2016-08-05  Enrica Casucci  <enrica@apple.com>
1098
1099         Fixing tests failing after r204175.
1100
1101         Unreviewed.
1102
1103         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
1104
1105 2016-08-05  Enrica Casucci  <enrica@apple.com>
1106
1107         Build fix after 204053.
1108
1109         Unreviewed.
1110
1111         * TestWebKitAPI/Configurations/Base.xcconfig:
1112         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1113         (-[MockContentFilterEnabler initWithCoder:]):
1114         (-[MockContentFilterEnabler dealloc]):
1115
1116 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
1117
1118         Print test name in "Last character read from DRT..." error message.
1119         https://bugs.webkit.org/show_bug.cgi?id=160559
1120
1121         Reviewed by Michael Catanzaro.
1122
1123         * Scripts/webkitpy/port/driver.py:
1124         (Driver.run_test):
1125         (Driver._read_first_block):
1126         (Driver._read_optional_image_block):
1127         (Driver._read_block):
1128         * Scripts/webkitpy/port/driver_unittest.py:
1129         (DriverTest.test_read_block):
1130         (DriverTest.test_read_binary_block):
1131         (DriverTest.test_read_base64_block):
1132
1133 2016-08-05  Commit Queue  <commit-queue@webkit.org>
1134
1135         Unreviewed, rolling out r204123.
1136         https://bugs.webkit.org/show_bug.cgi?id=160597
1137
1138         Caused layout test timeouts on Windows. (Requested by perarne
1139         on #webkit).
1140
1141         Reverted changeset:
1142
1143         "[Win] Unable to reliably run tests in parallel"
1144         https://bugs.webkit.org/show_bug.cgi?id=140914
1145         http://trac.webkit.org/changeset/204123
1146
1147 2016-08-04  Saam Barati  <sbarati@apple.com>
1148
1149         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1150         https://bugs.webkit.org/show_bug.cgi?id=151241
1151
1152         Reviewed by Benjamin Poulain.
1153
1154         * Scripts/run-jsc-stress-tests:
1155
1156 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1157
1158         UI improvements to Flakiness Dashboard.
1159         https://bugs.webkit.org/show_bug.cgi?id=153295
1160
1161         Reviewed by Alexey Proskuryakov.
1162
1163         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1164         (td.options-container): Center text in most fields.
1165         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1166         (createBugHTML): Text/Grammar updates.
1167         (tableHeaders): Ditto.
1168         (htmlForSingleTestRow): Ditto.
1169         (headerForTestTableHtml): Ditto.
1170         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1171         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1172
1173 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1174
1175         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1176         https://bugs.webkit.org/show_bug.cgi?id=160518
1177
1178         Reviewed by Michael Catanzaro.
1179
1180         * Scripts/webkitpy/thirdparty/__init__.py:
1181         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1182         * gtk/install-dependencies:
1183
1184 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1185
1186         Optimize bot watcher's dashboard a little
1187         https://bugs.webkit.org/show_bug.cgi?id=160515
1188         rdar://problem/26096900
1189
1190         Reviewed by Lucas Forschler.
1191
1192         Made re-sorting after loading an iteration more efficient.
1193
1194         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1195         (BuildbotIteration.prototype._updateWithData):
1196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1197         (BuildbotQueue.prototype.updateIterationPosition):
1198
1199 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1200
1201         [Win] Unable to reliably run tests in parallel
1202         https://bugs.webkit.org/show_bug.cgi?id=140914
1203
1204         Reviewed by Brent Fulgham.
1205
1206         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1207         processes. We can use string replacement to convert the Cygwin path to a Windows path
1208         instead.
1209  
1210         * Scripts/webkitpy/common/system/path.py:
1211         (cygpathFast):
1212         * Scripts/webkitpy/port/driver.py:
1213         (Driver._command_from_driver_input):
1214
1215 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1216
1217         Document instructions for increasing process and file limits
1218         https://bugs.webkit.org/show_bug.cgi?id=160528
1219         rdar://problem/24777576
1220
1221         Reviewed by Alexey Proskuryakov.
1222
1223         * Scripts/webkitpy/port/ios.py:
1224         (IOSSimulatorPort.default_child_processes):
1225
1226 2016-08-03  Anders Carlsson  <andersca@apple.com>
1227
1228         Remove the Objective-C bindings generator
1229         https://bugs.webkit.org/show_bug.cgi?id=160526
1230
1231         Reviewed by Sam Weinig.
1232
1233         * Scripts/run-bindings-tests:
1234         Update test.
1235
1236 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1237
1238         Revise a TestWebKitAPI comment to mention the actual underlying problem
1239
1240         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1241         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1242
1243 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1244
1245         Benchmark test content-animation timeouts always
1246         https://bugs.webkit.org/show_bug.cgi?id=160057
1247
1248         Reviewed by Simon Fraser.
1249
1250         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1251         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1252         (start):
1253
1254 2016-08-02  Nan Wang  <n_wang@apple.com>
1255
1256         AX: Simulated touch events are not working on iOS
1257         https://bugs.webkit.org/show_bug.cgi?id=160395
1258         <rdar://problem/27633597>
1259
1260         Reviewed by Chris Fleizach.
1261
1262         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1263         (WTR::AccessibilityUIElement::press):
1264         (WTR::AccessibilityUIElement::setSelectedChild):
1265
1266 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1267
1268         run-javascriptcore-tests should accept multiple --extra-tests
1269         https://bugs.webkit.org/show_bug.cgi?id=160486
1270
1271         Reviewed by Saam Barati.
1272         
1273         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1274         test suites. This does it by using GetOpt::Long's array support.
1275
1276         * Scripts/run-javascriptcore-tests:
1277         (runJSCStressTests):
1278
1279 2016-08-02  Enrica Casucci  <enrica@apple.com>
1280
1281         Allow building with content filtering disabled.
1282         https://bugs.webkit.org/show_bug.cgi?id=160454
1283
1284         Reviewed by Simon Fraser.
1285
1286         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1287
1288 2016-08-02  Brady Eidson  <beidson@apple.com>
1289
1290         Removing IndexedDB WebsiteData can fail for some users.
1291         https://bugs.webkit.org/show_bug.cgi?id=160463
1292
1293         Reviewed by Alex Christensen.
1294
1295         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1296
1297 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1298
1299         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1300         https://bugs.webkit.org/show_bug.cgi?id=160437
1301         <rdar://problem/27578272>
1302
1303         Reviewed by Brady Eidson.
1304
1305         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1306         (-[DownloadDelegate _download:didReceiveResponse:]):
1307         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1308         (runTest):
1309         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1310
1311 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1312
1313         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1314         https://bugs.webkit.org/show_bug.cgi?id=160414
1315
1316         Reviewed by Michael Catanzaro.
1317
1318         * Scripts/webkitpy/port/linux_get_crash_log.py:
1319         (GDBCrashLogGenerator._wait_for_corefile):
1320
1321 2016-08-01  Youenn Fablet  <youenn@apple.com>
1322
1323         Make wpt server generate its certificates in layout test results folder
1324         https://bugs.webkit.org/show_bug.cgi?id=160422
1325
1326         Reviewed by Chris Dumez.
1327
1328         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1329         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1330
1331 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1332
1333         Function Call on NULL Object
1334         https://bugs.webkit.org/show_bug.cgi?id=160325
1335
1336         Reviewed by Darin Adler.
1337
1338         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1339         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1340         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1341
1342 2016-08-01  Keith Miller  <keith_miller@apple.com>
1343
1344         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1345         https://bugs.webkit.org/show_bug.cgi?id=160372
1346
1347         Rubber stamped by Geoffrey Garen.
1348
1349         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1350         a new top level directory, JSTests. Having the tests in the Source directory
1351         was both confusing an inconvenient for people that just want to checkout the
1352         source code of WebKit. Since there is no other obvious place to put all the
1353         JavaScript tests a new top level directory seemed the most sensible.
1354
1355         * Scripts/import-test262-tests:
1356         * Scripts/run-javascriptcore-tests:
1357         * Scripts/update-javascriptcore-test-res:
1358
1359 2016-07-31  Nan Wang  <n_wang@apple.com>
1360
1361         AX: Add a check for touch event listener on iOS accessibility object
1362         https://bugs.webkit.org/show_bug.cgi?id=160388
1363
1364         Reviewed by Chris Fleizach.
1365
1366         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1367         (AccessibilityUIElement::boolAttributeValue):
1368         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1369         (WTR::AccessibilityUIElement::boolAttributeValue):
1370
1371 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1372
1373         Unreviewed: add myself to the reviewers list.
1374
1375         * Scripts/webkitpy/common/config/contributors.json:
1376
1377 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1378
1379         Undo r203939, and copy over a rule that clips the logos.
1380
1381         Sierra wasn't the only logo without transparency.
1382
1383         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1384         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1385         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1386
1387 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1388
1389         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1390         https://bugs.webkit.org/show_bug.cgi?id=160377
1391
1392         Reviewed by Brian Weinstein.
1393
1394         Update assets to remove the white background and use a transparent background instead.
1395
1396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1397         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1398
1399 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1400
1401         Ignore most check-webkit-style checks for ANGLE project
1402         <https://webkit.org/b/160333>
1403
1404         Reviewed by Daniel Bates.
1405
1406         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1407         - No tabs.
1408         - No spaces at the end of lines.
1409         - No carriage returns (DOS line endings).
1410
1411 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1412
1413         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1414         https://bugs.webkit.org/show_bug.cgi?id=160360
1415         <rdar://problem/27179484>
1416
1417         Reviewed by Myles C. Maxfield.
1418
1419         Adds two tests verifying that videos may be considered main content as long as they
1420         are large enough and cover a majority of the mainframe's viewport.
1421
1422         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1423         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1424         (TestWebKitAPI::TEST):
1425         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1426         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1427
1428 2016-07-29  Mark Lam  <mark.lam@apple.com>
1429
1430         Gardening: removed unused variable.
1431
1432         Not reviewed.
1433
1434         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1435         (TestWebKitAPI::TEST):
1436
1437 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1438
1439         Add TestWebKitAPI support for interacting with media controls
1440         https://bugs.webkit.org/show_bug.cgi?id=160342
1441         <rdar://problem/27610246>
1442
1443         Reviewed by Beth Dakin.
1444
1445         Adds support for testing interaction with some media controls, as well as a basic test
1446         verifying that media control teardown after interaction does not result in a crash.
1447
1448         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1449         (-[WKWebView mouseDownAtPoint:]):
1450         (-[WKWebView performAfterLoading:]):
1451         (TestWebKitAPI::TEST):
1452
1453 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1454
1455         Crash Log Clobbering on Unbound Crashes
1456         https://bugs.webkit.org/show_bug.cgi?id=160198
1457         <rdar://problem/27472618>
1458
1459         Reviewed by Alexey Proskuryakov.
1460
1461         * Scripts/webkitpy/common/system/crashlogs.py:
1462         (CrashLogs): Fix header order.
1463         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1464         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1465
1466 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1467
1468         Update for contributors.json
1469         https://bugs.webkit.org/show_bug.cgi?id=160294
1470
1471         * Scripts/webkitpy/common/config/contributors.json:
1472
1473 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1474
1475         Remove deprecated SPI for video inline / fullscreen controls
1476         https://bugs.webkit.org/show_bug.cgi?id=160318
1477
1478         Reviewed by Tim Horton.
1479
1480         * DumpRenderTree/mac/DumpRenderTree.mm:
1481         (setDefaultsToConsistentValuesForTesting): Deleted.
1482         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1483         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1484         * WebKitTestRunner/TestController.cpp:
1485         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1486         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1487         (WTR::initializeWebViewConfiguration): Deleted.
1488
1489 2016-07-28  Daniel Bates  <dabates@apple.com>
1490
1491         [iOS] TestWebKitAPI bundle targets are not code signed
1492         https://bugs.webkit.org/show_bug.cgi?id=160328
1493         <rdar://problem/27409246>
1494
1495         Reviewed by Andy Estes.
1496
1497         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1498         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1499         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1500
1501         * TestWebKitAPI/Configurations/Base.xcconfig:
1502
1503 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1504
1505         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1506
1507         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1508         (animatedResizeWebView):
1509         (TEST):
1510         This test times out only when run in the WebKit Testing simulator environment,
1511         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1512
1513 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1514
1515         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1516         https://bugs.webkit.org/show_bug.cgi?id=160289
1517         <rdar://problem/27553464>
1518
1519         Reviewed by Simon Fraser.
1520
1521         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1523         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1524         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1525         (-[AnimatedResizeWebView _endAnimatedResize]):
1526         (animatedResizeWebView):
1527         (TEST):
1528         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1529         Add two tests that ensure that hidden-content and animated resizes
1530         don't cause unnecessary synchronous waits. Only the hidden-content
1531         one fails before my patch, but it seemed reasonable to add both anyway.
1532
1533 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1534
1535         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1536         <https://webkit.org/b/83342>
1537
1538         Reviewed by Ryosuke Niwa.
1539
1540         * Scripts/webkitpy/common/checkout/scm/git.py:
1541         (Git.revisions_changing_file): Remove code to raise an exception
1542         when the file doesn't exist.  If a file was moved or renamed,
1543         then this caused the script to terminate, which was very
1544         frustrating when you wanted a list of reviewers.
1545         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1546         (SCMTest._shared_test_revisions_changing_file): Update test
1547         expectation to return an empty list of revisions.
1548         (test_create_patch_is_full_patch): Drive-by fix when running all
1549         webkitpy tests (including scm tests).
1550         * Scripts/webkitpy/common/checkout/scm/svn.py:
1551         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1552         return an empty array of revisions if this occurs.
1553
1554 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1555
1556         EWS error message "Error: * did not process patch" should include explanation
1557         https://bugs.webkit.org/show_bug.cgi?id=159903
1558         <rdar://problem/27410788>
1559
1560         Reviewed by Alexey Proskuryakov.
1561
1562         * QueueStatusServer/handlers/statusbubble.py:
1563         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1564         is not processed.
1565         * QueueStatusServer/handlers/processingtimesjson.py:
1566         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1567         of the code.
1568         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1569         (CommitQueueTask.validate): Add more information about validation failure.
1570         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1571         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1572         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1573         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1574         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1575         (PatchIsNotValid.__init__): Add the failure_message argument.
1576         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1577         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1578         failure details.
1579         * Scripts/webkitpy/tool/commands/queues.py:
1580         (CommitQueue.process_work_item): Same.
1581         (StyleQueue.review_patch): Same.
1582         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1583         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1584
1585 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1586
1587         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1588         https://bugs.webkit.org/show_bug.cgi?id=160262
1589
1590         Reviewed by Daniel Bates.
1591
1592         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1593         (-[LTRelayController installApp]):
1594
1595 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1596
1597         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1598         https://bugs.webkit.org/show_bug.cgi?id=160225
1599
1600         Reviewed by Alexey Proskuryakov.
1601
1602         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1603
1604 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1605
1606         [GTK] Fix some video/canvas tests that should be passing
1607         https://bugs.webkit.org/show_bug.cgi?id=160023
1608
1609         Reviewed by Carlos Garcia Campos.
1610
1611         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1612         EFL or GTK platforms.
1613
1614         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1615         (WTR::TestController::platformConfigureViewForTest):
1616         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1617         (WTR::TestController::platformConfigureViewForTest):
1618
1619 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1620
1621         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1622         https://bugs.webkit.org/show_bug.cgi?id=160247
1623
1624         Reviewed by Michael Catanzaro.
1625
1626         * BuildSlaveSupport/built-product-archive:
1627         (createZip):
1628         (dirContainsdwo):
1629         (archiveBuiltProduct):
1630
1631 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1632
1633         Fix tests after r203743.
1634         https://bugs.webkit.org/show_bug.cgi?id=156947
1635
1636         * WebKitTestRunner/TestController.cpp:
1637         (WTR::TestController::resetStateToConsistentValues):
1638         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1639
1640 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1641
1642         [iPhone] Playing a video on tudou.com plays only sound, no video
1643         https://bugs.webkit.org/show_bug.cgi?id=160178
1644         <rdar://problem/27535468>
1645
1646         Reviewed by Dan Bernstein.
1647
1648         * DumpRenderTree/mac/DumpRenderTree.mm:
1649         (setDefaultsToConsistentValuesForTesting):
1650         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1651         (RequiresUserActionForPlaybackTest::SetUp):
1652         * WebKitTestRunner/TestController.cpp:
1653         (WTR::TestController::resetPreferencesToConsistentValues):
1654         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1655         (WTR::initializeWebViewConfiguration):
1656
1657 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1658
1659         Allow LOG macros to be used outside the namespace, and other logging cleanup
1660         https://bugs.webkit.org/show_bug.cgi?id=160216
1661
1662         Reviewed by Anders Carlsson.
1663         
1664         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1665
1666         * DumpRenderTree/TestRunner.cpp:
1667         * DumpRenderTree/mac/DumpRenderTree.mm:
1668         (resetWebViewToConsistentStateBeforeTesting):
1669
1670 2016-07-26  David Kilzer <ddkilzer@apple.com>
1671
1672         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1673         https://bugs.webkit.org/show_bug.cgi?id=156947
1674         <rdar://problem/23325160>
1675
1676         Reviewed by Alex Christensen.
1677
1678         * DumpRenderTree/TestRunner.cpp:
1679         (TestRunner::TestRunner):
1680         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1681         * DumpRenderTree/TestRunner.h:
1682         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1683         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1684         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1685         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1686         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1687         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1688         (WTR::TestRunner::queueNonLoadingScript):
1689         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1690         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1691         * WebKitTestRunner/TestController.cpp:
1692         (WTR::TestController::didReceiveAuthenticationChallenge):
1693         * WebKitTestRunner/TestController.h:
1694         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1695         * WebKitTestRunner/TestInvocation.cpp:
1696         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1697         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1698
1699 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1700
1701         check-for-exit-time-destructors should be usable outside Xcode
1702         <https://webkit.org/b/160195>
1703
1704         Reviewed by Darin Adler.
1705
1706         * Scripts/check-for-exit-time-destructors: Update to parse
1707         -h|--help switch, or to take one argument to a binary to check
1708         for exit time destructors on the command-line.  The clang
1709         compiler will find these at compile-time with the
1710         -Wexit-time-destructors switch, but this script will check for
1711         them after-the-fact.
1712
1713 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1714
1715         Test svn.webkit.org functionality after maintenance.
1716
1717 2016-07-25  Brady Eidson  <beidson@apple.com>
1718
1719         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1720         https://bugs.webkit.org/show_bug.cgi?id=153783
1721
1722         Reviewed by Alex Christensen.
1723
1724         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
1725         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1726         
1727         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1728         
1729         Change the relevant API tests to make sure this continues to be no longer required.
1730
1731         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1732         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1733         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1734         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1735         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1736         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1737
1738 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1739
1740         Media controls should not be displayed for a video until it starts playing
1741         https://bugs.webkit.org/show_bug.cgi?id=160092
1742         <rdar://problem/26986673>
1743
1744         Reviewed by Beth Dakin.
1745
1746         Verify that multiple videos do or don't show the media controller depending on whether videos
1747         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1748         passing because we were always showing media controls for large videos with audio, even if they
1749         had not played back yet. This change ensures that large videos with audio show media controls
1750         only after they begin to play back, and not by virtue of being large enough for main content.
1751
1752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1753         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1754         (TestWebKitAPI::TEST):
1755         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1756         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1757         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1758
1759 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1760
1761         Media controls on apple.com don't disappear when movie finishes playing
1762         https://bugs.webkit.org/show_bug.cgi?id=160068
1763         <rdar://problem/26668526>
1764
1765         Reviewed by Darin Adler.
1766
1767         Adds new API tests. Please see WebCore ChangeLog for more details.
1768
1769         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1770         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1771         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1772         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1773         (TestWebKitAPI::TEST):
1774         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1775         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1776         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1777         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1778         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1779
1780 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1781
1782         Unreviewed, fix test-webkitpy after r203674.
1783
1784         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1785         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1786
1787 2016-07-24  Philippe Normand  <pnormand@igalia.com>
1788
1789         Unreviewed, forgot to commit this file in r203674.
1790
1791         * Scripts/process-linux-coredump: Added.
1792         (main):
1793
1794 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1795
1796         Improve GDB backtrace generation for GTK/EFL
1797         https://bugs.webkit.org/show_bug.cgi?id=128928
1798
1799         Reviewed by Carlos Garcia Campos.
1800
1801         The PID of the crashed process is now correctly supplied to the
1802         crash log reporter. The kernel core_pattern needs to be updated
1803         after this change to something like:
1804
1805         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1806
1807         * Scripts/process-linux-coredump: Added.
1808         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1809         * Scripts/webkitpy/port/efl.py:
1810         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1811         * Scripts/webkitpy/port/gtk.py:
1812         (GtkPort._get_crash_log): Ditto.
1813         * Scripts/webkitpy/port/linux_get_crash_log.py:
1814         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1815         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1816         (GDBCrashLogGenerator): Deleted.
1817         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1818         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
1819         * WebKitTestRunner/TestController.cpp:
1820         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
1821         (WTR::TestController::databaseProcessDidCrash): Ditto.
1822         (WTR::TestController::processDidCrash): Ditto.
1823
1824 2016-07-23  Youenn Fablet  <youenn@apple.com>
1825
1826         WPT stash server should be kept running when launching wpt server
1827         https://bugs.webkit.org/show_bug.cgi?id=160052
1828
1829         Reviewed by Sam Weinig.
1830
1831         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1832         (main): waiting to read stdin while stash server is started.
1833
1834 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1835
1836         Media controls should be displayed for media in media documents
1837         https://bugs.webkit.org/show_bug.cgi?id=160104
1838         <rdar://problem/27438936>
1839
1840         Reviewed by Myles C. Maxfield.
1841
1842         Verifies that even a small video with audio in a media document gets media controls.
1843
1844         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1845         (TestWebKitAPI::TEST):
1846
1847 2016-07-22  Michael Saboff  <msaboff@apple.com>
1848
1849         REGRESSION(203616): no FTL testing was inadvertently removed
1850         https://bugs.webkit.org/show_bug.cgi?id=160100
1851
1852         Rubber-stamped by Filip Pizlo.
1853
1854         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
1855         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
1856         logic for the runLayout and runNoisy variants to match the run test logic,
1857         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
1858         enabled platforms.
1859
1860         * Scripts/run-jsc-stress-tests:
1861
1862 2016-07-22  Brady Eidson  <beidson@apple.com>
1863
1864         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
1865         https://bugs.webkit.org/show_bug.cgi?id=160089
1866
1867         Reviewed by Darin Adler.
1868
1869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1870         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
1871         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
1872
1873 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
1874
1875         [GTK] Improved exclusion patterns in make-dist.py manifest.
1876         https://bugs.webkit.org/show_bug.cgi?id=160094
1877
1878         Reviewed by Michael Catanzaro.
1879
1880         * gtk/manifest.txt.in:
1881         Exclude Platform*.cmake files for more ports.
1882         Removed obsolete .gyp and .pro.user patterns.
1883         Exclude 'Configurations' and 'spi' directories.
1884         Exclude CMakeLists.txt.user (Qt Creator IDE).
1885
1886 2016-07-22  Michael Saboff  <msaboff@apple.com>
1887
1888         Don't run FTL related JSC stress tests on non-FTL platforms
1889         https://bugs.webkit.org/show_bug.cgi?id=160033
1890
1891         Reviewed by Mark Lam.
1892
1893         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
1894         Refactored several of the runXXX test methods to always runXXXDefault and made those
1895         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
1896         doesn't cause a problem.
1897
1898         * Scripts/run-jsc-stress-tests:
1899
1900 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
1901
1902         IWebView::mainFrame crashes if called after IWebView::close
1903         https://bugs.webkit.org/show_bug.cgi?id=32868
1904
1905         Reviewed by Brent Fulgham.
1906
1907         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1908         (TestWebKitAPI::TEST_F): Added test.
1909
1910 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1911
1912         [GTK] Enable threaded compositor by default
1913         https://bugs.webkit.org/show_bug.cgi?id=160079
1914
1915         Reviewed by Žan Doberšek.
1916
1917         * Scripts/webkitperl/FeatureList.pm:
1918
1919 2016-07-22  Youenn Fablet  <youenn@apple.com>
1920
1921         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
1922         https://bugs.webkit.org/show_bug.cgi?id=159921
1923
1924         Reviewed by Brian Burg.
1925
1926         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
1927
1928         * Scripts/webkitpy/codegen/main.py:
1929         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
1930         (BuiltinsGeneratorTests):
1931         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
1932         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
1933         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
1934         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
1935
1936 2016-07-21  Dan Bernstein  <mitz@apple.com>
1937
1938         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
1939         https://bugs.webkit.org/show_bug.cgi?id=160072
1940
1941         Reviewed by Andy Estes.
1942
1943         * Scripts/webkitdirs.pm:
1944         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
1945           for old Xcode versions.
1946         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
1947           to readXcodeUserDefault.
1948         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
1949           debugger.
1950         (determineDebugger): Ditto.
1951         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
1952           7.0.
1953         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
1954           switches.
1955         (execMacWebKitAppForDebugging): Removed support for GDB.
1956
1957 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1958
1959         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
1960         https://bugs.webkit.org/show_bug.cgi?id=160066
1961
1962         Reviewed by Dean Jackson.
1963
1964         * DumpRenderTree/mac/DumpRenderTree.mm:
1965         (setDefaultsToConsistentValuesForTesting): Deleted.
1966         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1967         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1968         * WebKitTestRunner/TestController.cpp:
1969         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1970         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1971         (WTR::initializeWebViewConfiguration): Deleted.
1972
1973 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
1974
1975         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
1976         https://bugs.webkit.org/show_bug.cgi?id=159980
1977         rdar://problem/27450825
1978
1979         Reviewed by Dan Bernstein.
1980
1981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1982         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
1983         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
1984         when our delegate has hit -dealloc.
1985         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
1986         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
1987         will not be messaged.
1988
1989 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1990
1991         Follow-up patch to r203520
1992         https://bugs.webkit.org/show_bug.cgi?id=159967
1993         <rdar://problem/26964090>
1994
1995         Unreviewed.
1996
1997         * DumpRenderTree/mac/DumpRenderTree.mm:
1998         (setDefaultsToConsistentValuesForTesting):
1999         * WebKitTestRunner/TestController.cpp:
2000         (WTR::TestController::resetPreferencesToConsistentValues):
2001
2002 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2003
2004         [iPhone] Playing a video on tudou.com plays only sound, no video
2005         https://bugs.webkit.org/show_bug.cgi?id=159967
2006         <rdar://problem/26964090>
2007
2008         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2009
2010         Migrate tests to use new SPI.
2011
2012         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2013         (RequiresUserActionForPlaybackTest::SetUp):
2014         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2015         (WTR::initializeWebViewConfiguration):
2016
2017 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
2018
2019         Clarify testing mode names in run-jsc-stress-tests
2020         https://bugs.webkit.org/show_bug.cgi?id=160021
2021
2022         Reviewed by Mark Lam.
2023
2024         Default should mean really default, not default with disabled FTL, renamed
2025         - runMozillaTestDefault to runMozillaTestNoFTL
2026         - runMozillaTestDefaultFTL to runMozillaTestDefault
2027         - runDefault to runNoFTL
2028         - runDefaultFTL to runDefault
2029         - runLayoutTestDefault to runLayoutTestNoFTL
2030         - runLayoutTestDefaultFTL to runLayoutTestDefault
2031         - runNoisyTestDefault to runNoisyTestNoFTL
2032         - runNoisyTestDefaultFTL to runNoisyTestDefault
2033
2034         * Scripts/run-jsc-stress-tests:
2035
2036 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
2037
2038         WebBackForwardList's currentIndex could get out of bounds when filtering items.
2039         https://bugs.webkit.org/show_bug.cgi?id=159986
2040
2041         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
2042         to 0.
2043
2044         Reviewed by Dan Bernstein.
2045
2046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2047         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
2048         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
2049         (TEST):
2050
2051 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2052
2053         [GTK] Web view background colors don't work in accelerated compositing mode
2054         https://bugs.webkit.org/show_bug.cgi?id=159455
2055
2056         Reviewed by Michael Catanzaro.
2057
2058         Set always RGBA visual to the view widget when setting a background color.
2059
2060         * MiniBrowser/gtk/BrowserWindow.c:
2061         (browser_window_set_background_color):
2062
2063 2016-07-20  Youenn Fablet  <youenn@apple.com>
2064
2065         Bots should run built-ins generator tests
2066         https://bugs.webkit.org/show_bug.cgi?id=159971
2067
2068         Reviewed by Alexey Proskuryakov.
2069
2070         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2071         (RunBuiltinsTests): New step to run built-in generator tests.
2072         (TestFactory.__init__): Adding an additional step for bultin generator tests.
2073         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
2074         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
2075
2076 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2077
2078         Revert temporary fix r203417
2079         https://bugs.webkit.org/show_bug.cgi?id=160001
2080
2081         Reviewed by Alexey Proskuryakov.
2082
2083         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
2084
2085 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2086
2087         REGRESSION(r148588): ews classes might get garbage collected
2088         https://bugs.webkit.org/show_bug.cgi?id=159990
2089
2090         Reviewed by Ryosuke Niwa.
2091
2092         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
2093         in a variable so that they do not get garbage collected.
2094
2095 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
2096
2097         Add API test for layout constraints after exit fullscreen
2098         https://bugs.webkit.org/show_bug.cgi?id=159900
2099
2100         Reviewed by Jon Lee.
2101
2102         Added Fullscreen.LaytoutConstraints API test. 
2103         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
2104
2105         This test compares layout constraints on the web view before and after fullscreen to make sure 
2106         they are preserved.
2107
2108         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
2109         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
2110         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2111         (TestWebKitAPI::TEST):
2112
2113 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
2114
2115         Disable two failing API tests.
2116
2117         Unreviewed test gardening.
2118
2119         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2120         (TestWebKitAPI::TEST):
2121
2122 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2123
2124         Unreviewed iOS build fix.
2125
2126         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
2127
2128 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2129
2130         Media controls don't appear when pausing a small autoplaying video
2131         https://bugs.webkit.org/show_bug.cgi?id=159972
2132         <rdar://problem/27180657>
2133
2134         Reviewed by Beth Dakin.
2135
2136         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
2137         for simulating basic user interaction in VideoControlsManager.
2138
2139         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2140         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2141         (-[WKWebView mouseDownAtPoint:]):
2142         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2143         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2144         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2145         (TestWebKitAPI::TEST):
2146         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2147
2148 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2149
2150         [Win] MathML fonts are not found.
2151         https://bugs.webkit.org/show_bug.cgi?id=159920
2152
2153         Reviewed by Alex Christensen.
2154
2155         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2156         for a specific registry key value.
2157
2158         * Scripts/webkitdirs.pm:
2159         (fontExists):
2160
2161 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2162
2163         Improve prepare-ChangeLog for @media blocks
2164         https://bugs.webkit.org/show_bug.cgi?id=159907
2165
2166         Reviewed by Timothy Hatcher.
2167
2168         * Scripts/prepare-ChangeLog:
2169         (get_selector_line_ranges_for_css):
2170         Get a range for @media blocks just like a selector.
2171             Start Line = line with '{'
2172             End line = line with '}'
2173             Name = "@media ..."
2174
2175         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2176         Improved error messages for unbalanced portions.
2177
2178         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2179         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2180         (.media-query::before):
2181         (@media only screen and (max-width: 980px)):
2182         (.media-query a):
2183         (@media (-webkit-min-device-pixel-ratio: 2)):
2184         (.both a):
2185         (.both b):
2186         (.media-query b):
2187         (.media-query::after):
2188
2189 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2190
2191         Fix expectedFailErrorHandler in run-jsc-stress-tests
2192         https://bugs.webkit.org/show_bug.cgi?id=159811
2193
2194         Reviewed by Yusuke Suzuki.
2195
2196         * Scripts/run-jsc-stress-tests:
2197
2198 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2199
2200         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2201
2202         * TestWebKitAPI/PlatformMac.cmake:
2203
2204 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2205
2206         The default testing mode should not involve disabling the FTL JIT
2207         https://bugs.webkit.org/show_bug.cgi?id=159929
2208
2209         Rubber stamped by Mark Lam and Saam Barati.
2210         
2211         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2212         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2213         FTL was not the default. You had to enable it with an option.
2214         
2215         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2216         all of the major ports. This has become a serious pain. For example, it's useful to be able
2217         to say that a test should only run in the default config that is representative of what a
2218         normal user would see if they ran JSC. Clearly, this would be a config that does not
2219         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2220         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2221         
2222         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2223         try to fix it, because:
2224         
2225         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2226           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2227           doesn't do anything. The code is not really structured to allow this.
2228         
2229         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2230           disabled in testing. On the other hand there are already build bots that do FTL tests
2231           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2232           preserving this broken feature, we should create something that (a) acknowledges the fact
2233           that the FTL is the default on those platforms that support it and (b) avoids running
2234           no-ftl tests on precisely those platforms that don't have FTL.
2235         
2236         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2237           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2238           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2239           pretending that the FTL JIT is not the default just because some bots used that as an
2240           optimization.
2241         
2242         This change allows me to speed up some debug tests and paint some bots green.
2243
2244         * Scripts/run-javascriptcore-tests:
2245         (runJSCStressTests):
2246         * Scripts/run-jsc-stress-tests:
2247
2248 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2249
2250         Fix API test after r203426.
2251         https://bugs.webkit.org/show_bug.cgi?id=159949
2252
2253         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2254         (TEST):
2255         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2256         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2257
2258 2016-07-19  Andy Estes  <aestes@apple.com>
2259
2260         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2261         https://bugs.webkit.org/show_bug.cgi?id=159956
2262
2263         Reviewed by Dan Bernstein.
2264
2265         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2266         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2267         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2268         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2269
2270 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2271
2272         Add regression test for r203392
2273         https://bugs.webkit.org/show_bug.cgi?id=159949
2274
2275         Reviewed by Brady Eidson.
2276
2277         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2278         (fileSize):
2279         (swizzledBundleIdentifierWebBookmarksD):
2280         (defaultApplicationCacheDirectory):
2281         (TEST):
2282         (swizzledBundleIdentifierMobileSafari): Deleted.
2283         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2284         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2285         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2286
2287 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2288
2289         Add regression test for r203392
2290         https://bugs.webkit.org/show_bug.cgi?id=159949
2291
2292         Reviewed by Brady Eidson.
2293
2294         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2295         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2296         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2297         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2298         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2299         (TEST):
2300         (fileSize):
2301         (swizzledBundleIdentifierMobileSafari):
2302         (swizzledBundleIdentifierWebBookmarksD):
2303         (defaultApplicationCacheDirectory):
2304         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2305         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2306         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2307         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2308
2309 2016-07-19  Keith Miller  <keith_miller@apple.com>
2310
2311         Test262 should have a file with the revision and url
2312         https://bugs.webkit.org/show_bug.cgi?id=159937
2313
2314         Reviewed by Mark Lam.
2315
2316         The import script should update the information from
2317         the path to the test262 repository it gets.
2318
2319         * Scripts/import-test262-tests:
2320
2321 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2322
2323         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2324         To be deleted once the root cause is found and addressed.
2325
2326         * EWSTools/start-queue-mac.sh:
2327
2328 2016-07-19  Frederic Wang  <fwang@igalia.com>
2329
2330         [win] Fixup the register name for STIX Math and Latin Modern Math
2331
2332         Unreviewed follow-up of r203406
2333
2334         * Scripts/webkitdirs.pm:
2335         (checkInstalledTools):
2336
2337 2016-07-19  Frederic Wang  <fwang@igalia.com>
2338
2339         [win] Update the list of MathML fonts
2340         https://bugs.webkit.org/show_bug.cgi?id=156838
2341
2342         The set of recommended math fonts is now described at
2343         https://trac.webkit.org/wiki/MathML/Fonts
2344         We update the Perl script to use the latest list of fonts.
2345
2346         Reviewed by Brent Fulgham.
2347
2348         * Scripts/webkitdirs.pm:
2349         (checkInstalledTools):
2350
2351 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2352
2353         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2354         https://bugs.webkit.org/show_bug.cgi?id=159342
2355
2356         Reviewed by Darin Adler.
2357
2358         Implement required functions in event sender.
2359
2360         * DumpRenderTree/PlatformWin.cmake:
2361         * DumpRenderTree/win/EventSender.cpp:
2362         (monitorWheelEvents): Added.
2363         (callAfterScrollingCompletes): Added.
2364
2365 2016-07-19  Youenn Fablet  <youenn@apple.com>
2366
2367         Add new aliases to http test server
2368         https://bugs.webkit.org/show_bug.cgi?id=159878
2369
2370         Reviewed by Darin Adler.
2371
2372         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2373         Adding explicitly these links to perl script.
2374         Extracting default alias in an aliases.json file.
2375         Reading that file from python scripts to initialize aliases from that file.
2376
2377         Python script changes covered by unit tests and changed layout test.
2378
2379         * Scripts/webkitperl/httpd.pm:
2380         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2381         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2382         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2383         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2384         Adding -c directives for each alias.
2385         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2386         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2387         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2388         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2389         Adding alias directive for each alias.
2390         (Lighttpd._prepare_config):
2391         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2392         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2393         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2394         layout tests directory.
2395         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2396         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2397         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2398
2399 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2400
2401         EWS console logs doesn't go to log file
2402         https://bugs.webkit.org/show_bug.cgi?id=159539
2403         <rdar://problem/24464570>
2404
2405         Reviewed by David Kilzer.
2406
2407         * Scripts/webkitpy/common/system/logutils.py:
2408         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2409         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2410         to filesystem. It also supports passing MockFilesystem.
2411         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2412         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2413         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2414         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2415         (_test_ews): Same.
2416         * Scripts/webkitpy/tool/commands/queues.py:
2417         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2418         (AbstractQueue._log_directory): Using filesystem object instead of os.
2419         (AbstractQueue.queue_log_path): Same.
2420         (AbstractQueue.__init__): Passed host parameter.
2421         (PatchProcessingQueue.__init__): Same.
2422         (CommitQueue.__init__): Same.
2423         (AbstractReviewQueue.__init__): Same.
2424         (StyleQueue.__init__): Same.
2425         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2426         (TestCommitQueue): Passed MockHost() as host.
2427         (TestCommitQueue.__init__): Same.
2428         (TestQueue.__init__): Same.
2429         (TestReviewQueue.__init__): Same.
2430         (TestFeederQueue.__init__): Same.
2431         (AbstractPatchQueueTest.test_next_patch): Same.
2432         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2433         (test_commit_queue_failure): Same.
2434         (MockCommitQueueTask.results_from_patch_test_run): Same.
2435         (test_rollout_lands): Same.
2436         (test_non_valid_patch): Same.
2437         (test_auto_retry): Same.
2438         (test_style_queue_with_watch_list_exception): Same.
2439
2440 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2441
2442         WTF::Lock should be fair eventually
2443         https://bugs.webkit.org/show_bug.cgi?id=159384
2444
2445         Reviewed by Geoffrey Garen.
2446
2447         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2448
2449 2016-07-17  Sam Weinig  <sam@webkit.org>
2450
2451         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2452         <rdar://problem/26554137>
2453         https://bugs.webkit.org/show_bug.cgi?id=159856
2454
2455         Reviewed by Dan Bernstein.
2456
2457         * MiniBrowser/mac/WK2BrowserWindowController.m:
2458         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2459         Add basic window.open implementation.
2460
2461         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2462         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2463         to open a single non-web URL, all others are dropped.
2464
2465         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2466         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2467         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2468         Add API for the new SPI.
2469
2470 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2471
2472         [JSC] Enable test262 module tests
2473         https://bugs.webkit.org/show_bug.cgi?id=159854
2474
2475         Reviewed by Saam Barati.
2476
2477         Use --module-file instead.
2478
2479         * Scripts/run-jsc-stress-tests:
2480
2481 2016-07-16  Chris Dumez  <cdumez@apple.com>
2482
2483         Unreviewed, rolling out r203318.
2484
2485         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2486         SunSpider)
2487
2488         Reverted changeset:
2489
2490         "[JSC] Change some parameters based on a random search"
2491         https://bugs.webkit.org/show_bug.cgi?id=158514
2492         http://trac.webkit.org/changeset/203318
2493
2494 2016-07-16  Chris Dumez  <cdumez@apple.com>
2495
2496         Add move constructor / assignment operator to ListHashSet
2497         https://bugs.webkit.org/show_bug.cgi?id=159837
2498
2499         Reviewed by Darin Adler.
2500
2501         Add API tests.
2502
2503         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2504         (TestWebKitAPI::TEST):
2505
2506 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2507
2508         [JSC] Change some parameters based on a random search
2509         https://bugs.webkit.org/show_bug.cgi?id=158514
2510
2511         Reviewed by Saam Barati.
2512
2513         * Scripts/run-jsc-stress-tests:
2514
2515 2016-07-15  Jon Davis  <jond@apple.com>
2516
2517         Changed the start page URL for WebKit Nightly builds.
2518         https://bugs.webkit.org/show_bug.cgi?id=159816
2519
2520         Reviewed by Timothy Hatcher.
2521
2522         * WebKitLauncher/start.html:
2523
2524 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2525
2526         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2527         https://bugs.webkit.org/show_bug.cgi?id=159414
2528
2529         Reviewed by Brent Fulgham.
2530
2531         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2532         when the HDC parameter is invalid.
2533
2534         * TestWebKitAPI/PlatformWin.cmake:
2535         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2536         (TestWebKitAPI::TEST):
2537
2538 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2539
2540         [GTK] Add basic tabs support to MiniBrowser
2541         https://bugs.webkit.org/show_bug.cgi?id=159803
2542
2543         Reviewed by Sergio Villar Senin.
2544
2545         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2546         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2547
2548         * MiniBrowser/gtk/BrowserTab.c: Added.
2549         (titleChanged):
2550         (isLoadingChanged):
2551         (decidePolicy):
2552         (removeChildIfInfoBar):
2553         (loadChanged):
2554         (createInfoBarQuestionMessage):
2555         (tlsErrorsDialogResponse):
2556         (loadFailedWithTLSerrors):
2557         (permissionRequestDialogResponse):
2558         (decidePermissionRequest):
2559         (colorChooserRGBAChanged):
2560         (popoverColorClosed):
2561         (colorChooserRequestFinished):
2562         (runColorChooserCallback):
2563         (inspectorOpenedInWindow):
2564         (inspectorClosed):
2565         (browserTabSetProperty):
2566         (browserTabFinalize):
2567         (browser_tab_init):
2568         (browserTabConstructed):
2569         (browser_tab_class_init):
2570         (getInternalURI):
2571         (browser_tab_new):
2572         (browser_tab_get_web_view):
2573         (browser_tab_load_uri):
2574         (browser_tab_get_title_widget):
2575         (browser_tab_set_status_text):
2576         (browser_tab_toggle_inspector):
2577         (browser_tab_start_search):
2578         (browser_tab_stop_search):
2579         (browser_tab_add_accelerators):
2580         (fullScreenMessageTimeoutCallback):
2581         (browser_tab_enter_fullscreen):
2582         (browser_tab_leave_fullscreen):
2583         * MiniBrowser/gtk/BrowserTab.h: Added.
2584         * MiniBrowser/gtk/BrowserWindow.c:
2585         (getExternalURI):
2586         (browserWindowSetStatusText):
2587         (reloadOrStopCallback):
2588         (goBackCallback):
2589         (goForwardCallback):
2590         (settingsCallback):
2591         (webViewURIChanged):
2592         (browserWindowHistoryItemActivated):
2593         (browserWindowUpdateNavigationActions):
2594         (webViewCreate):
2595         (webViewEnterFullScreen):
2596         (webViewLeaveFullScreen):
2597         (webViewDecidePolicy):
2598         (browserWindowCanZoomIn):
2599         (browserWindowCanZoomOut):
2600         (browserWindowZoomIn):
2601         (browserWindowZoomOut):
2602         (scrollEventCallback):
2603         (faviconChanged):
2604         (webViewIsLoadingChanged):
2605         (defaultZoomCallback):
2606         (searchCallback):
2607         (newTabCallback):
2608         (toggleWebInspector):
2609         (reloadPage):
2610         (reloadPageIgnoringCache):
2611         (stopPageLoad):
2612         (loadHomePage):
2613         (editingCommandCallback):
2614         (insertImageCommandCallback):
2615         (insertLinkCommandCallback):
2616         (browserWindowSetupEditorToolbar):
2617         (browserWindowSwitchTab):
2618         (browserWindowTabAddedOrRemoved):
2619         (browser_window_init):
2620         (browserWindowConstructed):
2621         (browserWindowSaveSession):
2622         (browserWindowDeleteEvent):
2623         (browser_window_new):
2624         (browser_window_append_view):
2625         (browser_window_load_uri):
2626         (browser_window_load_session):
2627         (browser_window_set_background_color):
2628         (resetStatusText): Deleted.
2629         (activateUriEntryCallback): Deleted.
2630         (webViewTitleChanged): Deleted.
2631         (resetEntryProgress): Deleted.
2632         (browserWindowCreateBackForwardMenu): Deleted.
2633         (webViewReadyToShow): Deleted.
2634         (webViewLoadFailed): Deleted.
2635         (webViewMouseTargetChanged): Deleted.
2636         (browserWindowUpdateZoomActions): Deleted.
2637         (webViewZoomLevelChanged): Deleted.
2638         (updateUriEntryIcon): Deleted.
2639         (zoomInCallback): Deleted.
2640         (zoomOutCallback): Deleted.
2641         (toggleFullScreen): Deleted.
2642         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2643         (browserWindowFinalize): Deleted.
2644         (browser_window_class_init): Deleted.
2645         * MiniBrowser/gtk/BrowserWindow.h:
2646         * MiniBrowser/gtk/CMakeLists.txt:
2647         * MiniBrowser/gtk/main.c:
2648         (createBrowserTab):
2649         (aboutURISchemeRequestCallback):
2650         (main):
2651         (parseBackgroundColor): Deleted.
2652
2653 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2654
2655         Allow RefPtrs of const RefCounted types
2656         https://bugs.webkit.org/show_bug.cgi?id=158269
2657
2658         Reviewed by Anders Carlsson.
2659
2660         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2661         (TestWebKitAPI::TEST):
2662         (TestWebKitAPI::ConstRefCounted::create):
2663         (TestWebKitAPI::returnConstRefCountedRef):
2664         (TestWebKitAPI::returnRefCountedRef):
2665
2666 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2667
2668         Test WTF.StringViewIterators is crashing since r203119
2669         https://bugs.webkit.org/show_bug.cgi?id=159710
2670
2671         Reviewed by Darin Adler.
2672
2673         There are two problems in the test case added in r203119. First is that it's testing
2674         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2675         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2676         const reference to the string view member of the deleted CodePoints object.
2677
2678         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2679         (TestWebKitAPI::TEST):
2680
2681 2016-07-13  Daniel Bates  <dabates@apple.com>
2682
2683         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2684         https://bugs.webkit.org/show_bug.cgi?id=159738
2685         <rdar://problem/27304649>
2686
2687         Reviewed by Dan Bernstein.
2688
2689         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2690         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2691         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2692         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2693
2694         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2695         * WebKitTestRunner/ios/TestControllerIOS.mm:
2696         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2697         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2698
2699 2016-07-13  Beth Dakin  <bdakin@apple.com>
2700
2701         Attempted build fix.
2702
2703         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2704
2705 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2706
2707         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2708         https://bugs.webkit.org/show_bug.cgi?id=159686
2709
2710         Reviewed by Chris Dumez.
2711
2712         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2713
2714         * WebKitTestRunner/TestController.cpp:
2715         (WTR::runOpenPanel):
2716         (WTR::TestController::createOtherPage):
2717         (WTR::TestController::createWebViewWithOptions):
2718
2719 2016-07-13  Beth Dakin  <bdakin@apple.com>
2720
2721         Add more candidate tests
2722         https://bugs.webkit.org/show_bug.cgi?id=159730
2723
2724         Reviewed by Tim Horton.
2725
2726         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
2727         two new tests to that file.
2728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2729         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2730         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2731         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2732         (TestWebKitAPI::TEST):
2733         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2734
2735 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2736
2737         AX: [ATK] spinbutton-crash.html fails
2738         https://bugs.webkit.org/show_bug.cgi?id=159723
2739
2740         Reviewed by Chris Fleizach.
2741
2742         Implement support for AXDecrementButton and AXIncrementButton in
2743         ATK's AccessibilityUIElement::uiElementAttributeValue().
2744
2745         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2746         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2747
2748 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2749
2750         [EFL] [GTK] Enable back crypto subtle on development builds.
2751         https://bugs.webkit.org/show_bug.cgi?id=159260
2752
2753         Reviewed by Carlos Garcia Campos.
2754
2755         * Scripts/webkitperl/FeatureList.pm:
2756
2757 2016-07-12  Mark Lam  <mark.lam@apple.com>
2758
2759         We should use different stack limits for stack checks from JS and host code.
2760         https://bugs.webkit.org/show_bug.cgi?id=159442
2761         <rdar://problem/26889188>
2762
2763         Reviewed by Geoffrey Garen.
2764
2765         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2766         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
2767         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
2768         order to keep the js/regress-139548.html test happy with this patch.
2769
2770         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2771         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
2772
2773         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2774         (-[LTRelayController _environmentVariables]):
2775         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2776         (main):
2777
2778 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
2779
2780         platformUserPreferredLanguages on Mac should not try to put the region into the language
2781         https://bugs.webkit.org/show_bug.cgi?id=159693
2782
2783         Rubber stamped by Alexey Proskuryakov.
2784         
2785         Revert the test change in r200105.
2786
2787         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2788         (TestWebKitAPI::languageForSystemLanguage):
2789
2790 2016-07-12  Chris Dumez  <cdumez@apple.com>
2791
2792         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2793         https://bugs.webkit.org/show_bug.cgi?id=159663
2794         <rdar://problem/18995873>
2795
2796         Reviewed by Benjamin Poulain.
2797
2798         Add API test coverage.
2799
2800         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2801         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2802         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2803         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2804         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2805         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2806         (TEST):
2807
2808 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
2809
2810         Relax ordering requirements on StringView::CodePoints iterator
2811         https://bugs.webkit.org/show_bug.cgi?id=159609
2812
2813         Reviewed by Darin Adler.
2814
2815         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2816         (TestWebKitAPI::TEST):
2817
2818 2016-07-12  Youenn Fablet  <youenn@apple.com>
2819
2820         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
2821         https://bugs.webkit.org/show_bug.cgi?id=159564
2822
2823         Reviewed by Brian Burg.
2824
2825         * Scripts/webkitpy/codegen/main.py:
2826         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
2827
2828 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2829
2830         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2831         https://bugs.webkit.org/show_bug.cgi?id=159671
2832
2833         Reviewed by Csaba Osztrogonác.
2834
2835         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2836         https://bugs.webkit.org/show_bug.cgi?id=89235
2837
2838         So this guard can be removed in build scripts.
2839
2840         * Scripts/webkitperl/FeatureList.pm:
2841         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2842
2843 2016-07-11  Jason Marcell  <jmarcell@apple.com>
2844
2845         SVN.create_patch should find svn-create-patch relative to the WebKit root.
2846         https://bugs.webkit.org/show_bug.cgi?id=159652
2847
2848         Reviewed by Daniel Bates.
2849
2850         * Scripts/webkitpy/common/checkout/scm/svn.py:
2851         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
2852
2853 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2854
2855         Implement grapheme cluster iterator on StringView
2856         https://bugs.webkit.org/show_bug.cgi?id=159598
2857
2858         Reviewed by Anders Carlsson.
2859
2860         This is in preparation for honoring the second argument to FontFaceSet.load().
2861
2862         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2863         (TestWebKitAPI::compareLoopIterations):
2864         (TestWebKitAPI::TEST):
2865
2866 2016-07-11  Nan Wang  <n_wang@apple.com>
2867
2868         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
2869         https://bugs.webkit.org/show_bug.cgi?id=158364
2870
2871         Reviewed by Anders Carlsson.
2872
2873         Added a function in TestRunner so that we can toggle the ignoring viewport
2874         scale limits setting. Also added a test option for that in order to change the 
2875         configuration of the webview in test.
2876
2877         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2878         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2879         (WTR::TestRunner::setNavigationGesturesEnabled):
2880         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2881         (WTR::nextUIScriptCallbackID):
2882         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2883         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2884         * WebKitTestRunner/TestController.cpp:
2885         (WTR::TestController::resetStateToConsistentValues):
2886         (WTR::updateTestOptionsFromTestHeader):
2887         (WTR::TestController::setNavigationGesturesEnabled):
2888         (WTR::TestController::setIgnoresViewportScaleLimits):
2889         (WTR::TestController::platformWillRunTest):
2890         * WebKitTestRunner/TestController.h:
2891         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2892         * WebKitTestRunner/TestInvocation.cpp:
2893         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2894         * WebKitTestRunner/TestOptions.h:
2895         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2896         (WTR::TestController::platformCreateWebView):
2897
2898 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
2899
2900         [GTK] install-dependencies should not install packages built by jhbuild.
2901         https://bugs.webkit.org/show_bug.cgi?id=159628
2902
2903         Reviewed by Michael Catanzaro.
2904
2905         * gtk/install-dependencies:
2906         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
2907
2908 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
2909
2910         System proxy settings not used when building deps with jhbuild
2911         https://bugs.webkit.org/show_bug.cgi?id=159567
2912
2913         Reviewed by Michael Catanzaro.
2914
2915         This adds the gsettings-desktop-schemas-devel build dep to enable
2916         the libgiognomeproxy.so gio module in glib-networking, which uses
2917         GSettings on org.gnome.system.proxy.
2918         This is needed to query system proxy settings for Gnome desktops.
2919
2920         dconf can be manually added to jhbuild to build the
2921         libdconfsettings.so gio module for GSettings, so that
2922         libgiognomeproxy.so can access system settings.
2923           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
2924
2925         As an alternative to dconf settings, this commit also adds the
2926         libproxy-devel build dep to enable the libgiolibproxy.so module in
2927         glib-networking (suggested by Fujii Hironori).
2928
2929         It is useful to read proxy settings from environment variables.
2930         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
2931         environment variable to force using the envvar module in libproxy.
2932
2933         * gtk/install-dependencies:
2934
2935 2016-07-11  Mark Lam  <mark.lam@apple.com>
2936
2937         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
2938         https://bugs.webkit.org/show_bug.cgi?id=159524
2939
2940         Reviewed by Michael Saboff.
2941
2942         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
2943         Also fixed up some tests to behave better to work with this new limit.  This
2944         should make stack overflow tests complete sooner.
2945
2946         * Scripts/run-jsc-stress-tests:
2947         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2948         (main):
2949
2950 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2951
2952         [GTK] Whitespace fixes in install-dependencies script
2953
2954         Unreviewed.
2955
2956         * gtk/install-dependencies:
2957
2958 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2959
2960         [GTK] Install missing Fedora dependencies
2961
2962         Unreviewed.
2963
2964         * gtk/install-dependencies:
2965
2966 2016-07-09  Dan Bernstein  <mitz@apple.com>
2967
2968         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
2969         https://bugs.webkit.org/show_bug.cgi?id=159600
2970
2971         Reviewed by Daniel Bates.
2972
2973         * Scripts/git-add-reviewer:
2974         Added the -s|--rubber-stamp option.
2975         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
2976           new option.
2977
2978 2016-07-08  Andy Estes  <aestes@apple.com>
2979
2980         [Content Filtering] Load blocked pages more like other error pages are loaded
2981         https://bugs.webkit.org/show_bug.cgi?id=159485
2982         <rdar://problem/26014076>
2983
2984         Reviewed by Brady Eidson.
2985
2986         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2987         to a content filtering provisional navigation failure is ignored in preference of
2988         ContentFilter's own error page.
2989
2990         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2992         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2993         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2994         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2995         (loadAlternateTest):
2996         (TEST):
2997         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2998         (-[MockContentFilterEnabler initWithCoder:]):
2999         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3000         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3001         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3002         (TestWebKitAPI::loadAlternateTest):
3003         (TestWebKitAPI::TEST):
3004
3005 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3006
3007         Unreviewed, rolling out r202944.
3008         https://bugs.webkit.org/show_bug.cgi?id=159570
3009
3010         caused some tests to crash under GuardMalloc (Requested by
3011         estes on #webkit).
3012
3013         Reverted changeset:
3014
3015         "[Content Filtering] Load blocked pages more like other error
3016         pages are loaded"
3017         https://bugs.webkit.org/show_bug.cgi?id=159485
3018         http://trac.webkit.org/changeset/202944
3019
3020 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
3021
3022         Remove mrobinson from the MathML watchlist
3023         https://bugs.webkit.org/show_bug.cgi?id=159559
3024
3025         Reviewed by Philippe Normand.
3026
3027         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
3028
3029 2016-07-08  Brady Eidson  <beidson@apple.com>
3030
3031         Clearing LocalStorage doesn't also delete -wal and -shm files.
3032         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
3033
3034         Reviewed by Brent Fulgham.
3035         Also helpfully picked over by Andy "Never Forgets" Estes.
3036
3037         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3038         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
3039         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
3040
3041 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
3042
3043         Removed Qt leftovers from Tools.
3044         https://bugs.webkit.org/show_bug.cgi?id=159557
3045
3046         Reviewed by Csaba Osztrogonác.
3047
3048         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3049         Removed 'qt' platform config.
3050         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3051         Deleted non-functional e-mail address.
3052
3053 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3054
3055         Unreviewed, rolling out r202967.
3056         https://bugs.webkit.org/show_bug.cgi?id=159556
3057
3058         This patch caused crashes in https tests on Windows (Requested
3059         by perarne on #webkit).
3060
3061         Reverted changeset:
3062
3063         "[Win] The test http/tests/security/contentSecurityPolicy
3064         /upgrade-insecure-requests/basic-upgrade.https.html is
3065         failing."
3066         https://bugs.webkit.org/show_bug.cgi?id=159510
3067         http://trac.webkit.org/changeset/202967
3068
3069 2016-07-08  Youenn Fablet  <youenn@apple.com>
3070
3071         Generate WebCore builtin wrapper files
3072         https://bugs.webkit.org/show_bug.cgi?id=159461
3073
3074         Reviewed by Brian Burg.
3075
3076         * Scripts/webkitpy/codegen/main.py:
3077         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
3078         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
3079
3080 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
3081
3082         [EFL] Fix build when media-stream is enabled.
3083         https://bugs.webkit.org/show_bug.cgi?id=159206
3084
3085         Bump up the openwebrtc to find the correct package.
3086
3087         Reviewed by Gyuyoung Kim.
3088
3089         * efl/jhbuild.modules:
3090         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
3091
3092 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3093
3094         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
3095         https://bugs.webkit.org/show_bug.cgi?id=159510
3096
3097         Reviewed by Brent Fulgham.
3098
3099         Allow any https certificate when running tests.
3100
3101         * DumpRenderTree/win/DumpRenderTree.cpp:
3102         (runTest):
3103
3104 2016-07-07  Beth Dakin  <bdakin@apple.com>
3105
3106         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3107         https://bugs.webkit.org/show_bug.cgi?id=159532
3108         -and corresponding-
3109         rdar://problem/27177179
3110
3111         Reviewed by Tim Horton.
3112
3113         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
3114         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
3115
3116 2016-07-07  Andy Estes  <aestes@apple.com>
3117
3118         [Content Filtering] Load blocked pages more like other error pages are loaded
3119         https://bugs.webkit.org/show_bug.cgi?id=159485
3120         <rdar://problem/26014076>
3121
3122         Reviewed by Brady Eidson.
3123
3124         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3125         to a content filtering provisional navigation failure is ignored in preference of
3126         ContentFilter's own error page.
3127
3128         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3130         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3131         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3132         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3133         (loadAlternateTest):
3134         (TEST):
3135         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3136         (-[MockContentFilterEnabler initWithCoder:]):
3137         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3138         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3139         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3140         (TestWebKitAPI::loadAlternateTest):
3141         (TestWebKitAPI::TEST):
3142
3143 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3144
3145         Unreviewed: add myself to the reviewers list.
3146
3147         * Scripts/webkitpy/common/config/contributors.json:
3148
3149 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3150
3151         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
3152         https://bugs.webkit.org/show_bug.cgi?id=159509
3153
3154         Reviewed by Alex Christensen.
3155
3156         We should always insert the url in the url map when identifierForInitialRequest
3157         is called. Otherwise we can end up with identifiers not having an entry in the
3158         url map when urls are written to the test output file. 
3159
3160         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3161         (ResourceLoadDelegate::identifierForInitialRequest):
3162
3163 2016-07-06  Tim Horton  <timothy_horton@apple.com>
3164
3165         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3166         https://bugs.webkit.org/show_bug.cgi?id=159498
3167         <rdar://problem/26719903>
3168
3169         Reviewed by Sam Weinig.
3170
3171         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3172         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3173         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3174         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3175         (expectLinkCount):
3176         (TEST):
3177         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3178         when deciding what to linkify.
3179
3180 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3181
3182         Build fix - work around rdar://problem/27196668.
3183
3184         * LayoutTestRelay/Configurations/Base.xcconfig:
3185
3186 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3187
3188         Enhance Windows DRT implementation to support platform scroll wheel events.
3189         https://bugs.webkit.org/show_bug.cgi?id=36002
3190
3191         Reviewed by Brent Fulgham.
3192
3193         Implement function continuousMouseScrollBy in Windows event sender.
3194
3195         * DumpRenderTree/win/EventSender.cpp:
3196         (mouseScrollBy):
3197         (continuousMouseScrollBy):
3198
3199 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3200
3201         [Sierra] Rebaseline tests to use un-mocked system font metrics
3202         https://bugs.webkit.org/show_bug.cgi?id=159311
3203         <rdar://problem/24138411>
3204
3205         Reviewed in person by Alexey Proskuryakov.
3206
3207         Stop mocking the system font on Sierra.
3208
3209         * DumpRenderTree/mac/DumpRenderTree.mm:
3210         (setDefaultsToConsistentValuesForTesting):
3211         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3212         (WTR::InjectedBundle::platformInitialize):
3213
3214 2016-07-05  Brady Eidson  <beidson@apple.com>
3215
3216         Database process crashes deleting a corrupt SQLite database file (null deref).
3217         https://bugs.webkit.org/show_bug.cgi?id=155506.
3218
3219         Reviewed by Alex Christensen.
3220
3221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3222         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3223         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3224         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3225         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3226         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3227
3228 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3229
3230         run-webkit-tests should print more complete baseline search paths
3231         https://bugs.webkit.org/show_bug.cgi?id=159354
3232
3233         Reviewed by Daniel Bates.
3234
3235         run-webkit-tests used to only print directory names in baseline search paths.
3236         This was ok in basic usage, but quickly got confusing when using
3237         --additional-platform-directory flags.
3238
3239         * Scripts/webkitpy/layout_tests/views/printing.py:
3240         (Printer.print_config):
3241         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3242         (Testprinter.test_print_config):
3243         (Testprinter.test_print_one_line_summary):
3244
3245 2016-07-04  Brady Eidson  <beidson@apple.com>
3246
3247         WebProcesses don't handle DatabaseProcess going away uncleanly..
3248         https://bugs.webkit.org/show_bug.cgi?id=159371
3249
3250         Reviewed by Alex Christensen.
3251
3252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3253         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3254         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3255         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3256         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3257
3258 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3259
3260         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3261         https://bugs.webkit.org/show_bug.cgi?id=158141
3262
3263         Rubber-stamped by Michael Catanzaro.
3264
3265         Instead of checking for an specific Ubuntu version, query the apt
3266         database to see which version of PHP is available.
3267
3268         * efl/install-dependencies:
3269         * gtk/install-dependencies:
3270
3271 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3272
3273         webkit-patch failure-reason always raises TypeError
3274         https://bugs.webkit.org/show_bug.cgi?id=159394
3275
3276         Reviewed by Benjamin Poulain.
3277
3278         In r170637 (Bug 133067), the first and second arguments of
3279         pluralize were swapped.
3280
3281         * Scripts/webkitpy/tool/commands/queries.py:
3282         (FailureReason._builder_to_explain): Swap the first and second
3283         arguments of pluralize.
3284
3285 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3286
3287         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3288         https://bugs.webkit.org/show_bug.cgi?id=152486
3289
3290         Reviewed by Daniel Bates.
3291
3292         Add launch of web-platform-tests server by run-webkit-httpd.
3293         Add two options to disable starting httpd and web-platform-tests servers.
3294
3295         * Scripts/run-webkit-httpd:
3296         (parse_args):
3297         (main):
3298
3299 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3300
3301         REGRESSION(r189668): Notification tests are flakey
3302         https://bugs.webkit.org/show_bug.cgi?id=159375
3303         <rdar://problem/22760990>
3304
3305         Reviewed by Alexey Proskuryakov.
3306
3307         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3308         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3309         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3310         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3311
3312         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3313         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3314         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3315         global notification ID mapping, causing the wrong notification to be investigated.
3316
3317         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3318         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3319         notification is created or destroyed. However, because this object is implemented outside WebKit,
3320         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3321         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3322         WebNotificationProvider can properly map between the different IDs.
3323
3324         * WebKitTestRunner/TestController.cpp:
3325         (WTR::TestController::runTestingServerLoop):
3326         (WTR::TestController::simulateWebNotificationClick):
3327         * WebKitTestRunner/WebNotificationProvider.cpp:
3328         (WTR::WebNotificationProvider::showWebNotification):
3329         (WTR::removeGlobalIDFromIDMap):
3330         (WTR::WebNotificationProvider::closeWebNotification):
3331         (WTR::WebNotificationProvider::removeNotificationManager):
3332         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3333         (WTR::WebNotificationProvider::reset):
3334         * WebKitTestRunner/WebNotificationProvider.h:
3335
3336 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3337
3338         Simplify LayoutTestRelay
3339         https://bugs.webkit.org/show_bug.cgi?id=159353
3340
3341         Reviewed by Daniel Bates.
3342
3343         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3344         by name and runtime makes no sense.
3345         2. Removed code to create devices, webkitpy always does this in advance.
3346         3. Don't create copies of testing apps - we can install the same one into
3347         each simulator, now that we don't run multiple tester processes in a single simulator.
3348         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3349         5. Removed code that kept testing apps alive in the background.
3350         6. Slightly updated coding style in functions that I touched.
3351
3352         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3353         Updated for what we acually use at this point.
3354
3355         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3356         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3357         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3358         (-[LTRelayController ipcIdentifier]):
3359         (-[LTRelayController processName]):
3360         (-[LTRelayController didReceiveStdoutData:]):
3361         (-[LTRelayController didCrashWithMessage:]):
3362         (-[LTRelayController installApp]):
3363         (-[LTRelayController _environmentVariables]):
3364         (-[LTRelayController launchApp]):
3365         (-[LTRelayController start]):
3366         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3367         (-[LTRelayController uniqueAppPath]): Deleted.
3368         (-[LTRelayController uniqueAppURL]): Deleted.
3369         (-[LTRelayController uniqueAppIdentifier]): Deleted.
3370         (-[LTRelayController createUniqueApp]): Deleted.
3371         * LayoutTestRelay/LayoutTestRelay/main.m:
3372         (usage):
3373         (getRequiredStringArgument):
3374         (main):
3375         (getTestingSimDevice): Deleted.
3376         * Scripts/webkitpy/port/driver.py:
3377         (IOSSimulatorDriver.cmd_line):
3378         * WebKitTestRunner/ios/TestControllerIOS.mm:
3379         (WTR::TestController::platformInitialize):
3380         * WebKitTestRunner/ios/mainIOS.mm:
3381         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3382         * DumpRenderTree/mac/DumpRenderTree.mm:
3383         (dumpRenderTree):
3384         (-[DumpRenderTree applicationDidEnterBackground:]):
3385
3386 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
3387
3388         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3389         https://bugs.webkit.org/show_bug.cgi?id=159344
3390
3391         Reviewed by Alex Christensen.
3392
3393         * DumpRenderTree/CMakeLists.txt:
3394
3395 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3396
3397         Add a runtime flag for DOM iterators
3398         https://bugs.webkit.org/show_bug.cgi?id=159300
3399
3400         Reviewed by Alex Christensen.
3401
3402         * DumpRenderTree/mac/DumpRenderTree.mm:
3403         (resetWebPreferencesToConsistentValues):
3404         * DumpRenderTree/win/DumpRenderTree.cpp:
3405         (resetWebPreferencesToConsistentValues):
3406         * Scripts/webkitperl/FeatureList.pm:
3407         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3408         (WTR::InjectedBundle::beginTesting):
3409         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3410         (WTR::TestRunner::setDOMIteratorEnabled):
3411         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3412
3413 2016-06-30  Tina Liu  <iting_liu@apple.com>
3414
3415         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3416         https://bugs.webkit.org/show_bug.cgi?id=159326
3417
3418         Reviewed by Brady Eidson.
3419
3420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3421         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3422         (TestWebKitAPI::didFinishLoadForFrame):
3423         (TestWebKitAPI::didChangeBackForwardListForPage):
3424         (TestWebKitAPI::setPageLoaderClient):
3425         Set the page loader client and register for didFinishLoadForFrame and
3426         didChangeBackForwardList callbacks.
3427         (TestWebKitAPI::createSessionStateData):
3428         Load a webpage ("simple.html") and return the session state for this page.
3429         (TestWebKitAPI::TEST):
3430         Restore the page session state with that of "simple.html" without navigation.
3431         Verify that the committed URL is NULL since there's no navigation involved.
3432         Verify that the current item in the back forward list, which should be what
3433         we restored from the session state, has the expected URL.
3434
3435 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
3436
3437         Generators violate bytecode liveness validation
3438         https://bugs.webkit.org/show_bug.cgi?id=159279
3439
3440         Reviewed by Yusuke Suzuki.
3441         
3442         Add Basic to our test harness.
3443
3444         * Scripts/run-javascriptcore-tests:
3445         (runJSCStressTests):
3446
3447 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
3448
3449         [Win][Debug] Assertion fails in TestWTF.
3450         https://bugs.webkit.org/show_bug.cgi?id=159299
3451
3452         Reviewed by Alex Christensen.
3453
3454         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3455         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3456         the assertion failure. Since the variable is actually used, there is no need to use the
3457         UNUSED_PARAM macro.
3458
3459         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3460         (TestWebKitAPI::TEST):
3461
3462 2016-06-30  Youenn Fablet  <youennf@gmail.com>
3463
3464         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
3465         https://bugs.webkit.org/show_bug.cgi?id=159166
3466         <rdar://problem/27051759>
3467
3468         Reviewed by Alexey Proskuryakov.
3469
3470         Setting the certificate directory to the copied config.json.
3471
3472         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3473         (WebPlatformTestServer._copy_webkit_test_files):
3474
3475 2016-06-29  Mark Lam  <mark.lam@apple.com>
3476
3477         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
3478         https://bugs.webkit.org/show_bug.cgi?id=159274
3479
3480         Reviewed by Keith Miller.
3481
3482         * DumpRenderTree/mac/DumpRenderTree.mm:
3483         (DumpRenderTreeMain):
3484
3485 2016-06-29  Alex Christensen  <achristensen@webkit.org>
3486
3487         WKWebView should ask WKNavigationDelegate about bad ssl certificates
3488         https://bugs.webkit.org/show_bug.cgi?id=159176
3489
3490         Reviewed by Sam Weinig.
3491
3492         * MiniBrowser/mac/WK2BrowserWindowController.m:
3493         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3494         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3495         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3496
3497 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3498
3499         [GTK] Add missing install dependency after r202619
3500         https://bugs.webkit.org/show_bug.cgi?id=156716
3501
3502         Unreviewed.
3503
3504         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3505
3506 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3507
3508         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3509         https://bugs.webkit.org/show_bug.cgi?id=156716
3510
3511         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3512
3513         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3514         (parse_args):
3515         * Scripts/webkitpy/port/gtk.py:
3516         (GtkPort.__init__):
3517         (GtkPort._driver_class):
3518         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3519         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3520         platform directory for storing the wayland specific layout test results and expectations for ${port}.
3521         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3522         test expectations file on the GTK port when running the tests with the --wayland command line switch.
3523         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3524         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3525         (WestonDriver.check_driver):
3526         (WestonDriver.__init__):
3527         (WestonDriver._start):
3528         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3529         (WestonXvfbDriverDisplayTest):
3530         (WestonXvfbDriverDisplayTest.__init__):
3531         (WestonXvfbDriverDisplayTest._xvfb_run):
3532         (WestonDriverTest.make_driver):
3533         (WestonDriverTest.test_start):
3534         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3535         or to satisfy the pkg-config check of the new added modules in JHBuild.
3536         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3537         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3538         provided by the system are already new enough.
3539         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3540         It was the only way to get the software EGL rasterizer working without depending on user drivers.
3541         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3542         feature to avoid building libdrm when the one provided by the system is new enough.
3543         * gtk/jhbuildrc:
3544         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
3545         Xorg had no support for searching the DRI drivers on a custom path at runtime.
3546         This patch implements support for that reusing the same variable that we use with Mesa to set the
3547         custom path for the DRI drivers path.
3548
3549 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
3550
3551         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
3552         https://bugs.webkit.org/show_bug.cgi?id=159256
3553
3554         Reviewed by Philippe Normand.
3555
3556         We need the last fixes in the repository to make the scream queue
3557         work with apprtc.
3558
3559         * gtk/jhbuild.modules:
3560
3561 2016-06-28  Commit Queue  <commit-queue@webkit.org>
3562
3563         Unreviewed, rolling out r202580.
3564         https://bugs.webkit.org/show_bug.cgi?id=159245
3565
3566         Caused all WKTR tests to fail on GuardMalloc and Production
3567         only for unknown reasons, investigating offline. (Requested by
3568         brrian on #webkit).
3569
3570         Reverted changeset:
3571
3572         "RunLoop::Timer should use constructor templates instead of
3573         class templates"
3574         https://bugs.webkit.org/show_bug.cgi?id=159153
3575         http://trac.webkit.org/changeset/202580
3576
3577 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3578
3579         Use a regex to check if a test step is for JavaScriptCore
3580         https://bugs.webkit.org/show_bug.cgi?id=159224
3581
3582         Reviewed by Geoffrey Garen.
3583
3584         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3585         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
3586         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3587         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
3588         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3589         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
3590
3591 2016-06-28  Michael Saboff  <msaboff@apple.com>
3592
3593         btjs no longer accepts optional frame count argument
3594         https://bugs.webkit.org/show_bug.cgi?id=159235
3595
3596         Reviewed by Saam Barati.
3597
3598         Fix the detection of optional backtrace-depth parameter to use the length
3599         of the command.
3600
3601         * lldb/lldb_webkit.py:
3602         (btjs):
3603
3604 2016-06-28  Jon Lee  <jonlee@apple.com>
3605
3606         Update animometer.plan
3607
3608         Rubber-stamped by Said Abou-Hallawa.
3609
3610         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
3611
3612 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
3613
3614         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
3615
3616         * Scripts/run-javascriptcore-tests:
3617         (runJSCStressTests):
3618
3619 2016-06-28  Brian Burg  <bburg@apple.com>
3620
3621         RunLoop::Timer should use constructor templates instead of class templates
3622         https://bugs.webkit.org/show_bug.cgi?id=159153
3623
3624         Reviewed by Alex Christensen.
3625
3626         Remove the RunLoop::Timer class template argument, and pass its constructor
3627         a reference to `this` instead of a pointer to `this`.
3628
3629         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3630         (WTR::TestRunner::TestRunner):
3631         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3632         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3633         (TestWebKitAPI::TEST):
3634
3635 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3636
3637         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3638         https://bugs.webkit.org/show_bug.cgi?id=159199
3639
3640         Reviewed by Alexey Proskuryakov.
3641
3642         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
3643
3644         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3645         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3646         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
3647         an input element getting automatically focused on Mac.
3648
3649 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
3650
3651         [Win] Custom elements tests are failing.
3652         https://bugs.webkit.org/show_bug.cgi?id=159139
3653
3654         Reviewed by Alex Christensen.
3655
3656         Enable custom element API when running tests.
3657
3658         * DumpRenderTree/win/DumpRenderTree.cpp:
3659         (resetWebPreferencesToConsistentValues):
3660
3661 2016-06-27  Lucas Forschler  <lforschler@apple.com>
3662
3663         Test commit. Please ignore.
3664         
3665 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3666
3667         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
3668         https://bugs.webkit.org/show_bug.cgi?id=155073
3669
3670         Reviewed by Daniel Bates.
3671
3672         * Scripts/webkitperl/FeatureList.pm:
3673
3674 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
3675
3676         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3677         https://bugs.webkit.org/show_bug.cgi?id=159077
3678
3679         Reviewed by Tim Horton.
3680
3681         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
3682
3683         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
3684         which is necessary for UI-side compositing.
3685
3686         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
3687         seems to happen for some tests that call window.resizeTo().
3688
3689         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3690         (WTR::InjectedBundlePage::dump): Deleted.
3691         * WebKitTestRunner/TestInvocation.cpp:
3692         (WTR::TestInvocation::dumpResults):
3693         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3694         (WTR::createCGContextFromImage):
3695         (WTR::computeMD5HashStringForContext):
3696         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3697         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3698         (WTR::PlatformWebView::windowSnapshotImage):
3699
3700 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3701
3702         [EFL] Support to build on Debian linux
3703         https://bugs.webkit.org/show_bug.cgi?id=159123
3704
3705         Reviewed by Antonio Gomes.
3706
3707         * efl/install-dependencies: Install libgnutls28-dev.
3708
3709 2016-06-27  Alex Christensen  <achristensen@webkit.org>
3710
3711         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
3712         https://bugs.webkit.org/show_bug.cgi?id=159071
3713
3714         Reviewed by Brady Eidson.
3715
3716         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3717         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3718         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3719         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3720         (WTR::TestRunner::setAuthenticationUsername):
3721         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3722         * WebKitTestRunner/TestController.cpp:
3723         (WTR::TestController::TestController):
3724         (WTR::TestController::resetStateToConsistentValues):
3725         (WTR::TestController::didFinishNavigation):
3726         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3727         (WTR::TestController::didReceiveAuthenticationChallenge):
3728         (WTR::TestController::didCommitNavigation):
3729         * WebKitTestRunner/TestController.h:
3730         (WTR::TestController::setBlockAllPlugins):
3731         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3732         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
3733         (WTR::TestController::isCurrentInvocation):
3734         * WebKitTestRunner/TestInvocation.cpp:
3735         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3736         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
3737
3738 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
3739
3740         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
3741         https://bugs.webkit.org/show_bug.cgi?id=159129
3742
3743         Reviewed by Alex Christensen.
3744
3745         Implement the function mouseScrollBy in the Windows event sender.
3746
3747         * DumpRenderTree/win/EventSender.cpp:
3748         (mouseScrollBy):
3749         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3750
3751 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
3752
3753         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3754         https://bugs.webkit.org/show_bug.cgi?id=159104
3755
3756         Reviewed by Dan Bernstein.
3757         
3758         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
3759         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
3760
3761         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3762         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3763         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
3764
3765 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
3766
3767         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
3768         https://bugs.webkit.org/show_bug.cgi?id=159086
3769
3770         Reviewed by Alex Christensen.
3771
3772         Implement required wheel event function in event sender.
3773  
3774         * DumpRenderTree/win/EventSender.cpp:
3775         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3776
3777 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
3778
3779         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3780         https://bugs.webkit.org/show_bug.cgi?id=159104
3781
3782         Reviewed by Mark Lam.
3783         
3784         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
3785         WK.
3786
3787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3788
3789 2016-06-24  David Kilzer  <ddkilzer@apple.com>
3790
3791         parser_unittests.pl should not hardcode list of tests
3792         <https://webkit.org/b/159074>
3793
3794         Reviewed by Daniel Bates.
3795
3796         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3797         Update to read the list of tests from the 'resources' directory,
3798         and instead map file extensions to subroutine names.  Switch to
3799         use File::Basename::fileparse() to get basename and file
3800         extension for each test.
3801         (readTestFiles): Added.  Reads files from the directory passed
3802         in and ignores: hidden files, anything that isn't a plain file,
3803         and expected test results files.
3804
3805 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3806
3807         Fix Windows build.
3808
3809         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3810         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3811
3812 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3813
3814         [EFL] Change download path of libxslt
3815
3816         Unreviewed EFL build fix.
3817
3818         In Korea current download path can't be accessed. Change it.
3819
3820         * efl/jhbuild.modules:
3821
3822 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3823
3824         https://bugs.webkit.org/show_bug.cgi?id=159077
3825
3826         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
3827         snapshot the final state of the test in release builds. 
3828
3829         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3830         (WTR::InjectedBundlePage::dump):
3831
3832 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3833
3834         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
3835
3836         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3837         (createBitmapContextFromWebView):
3838         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3839         (WTR::PlatformWebView::windowSnapshotImage):
3840
3841 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3842
3843         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3844         https://bugs.webkit.org/show_bug.cgi?id=159077
3845
3846         Reviewed by Tim Horton.
3847
3848         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
3849         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
3850         thus enabling testing of more things.
3851
3852         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3853         (createBitmapContext): Moved to this file to share it.
3854         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3855         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3856         (createBitmapContextFromWebView):
3857         (BitmapContext::createFromUIImage): Deleted.
3858         (BitmapContext::pixelData): Deleted.
3859         (BitmapContext::BitmapContext): Deleted.
3860         (computeMD5HashStringForBitmapContext): Deleted.
3861         (dumpBitmap): Deleted.
3862         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
3863         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3864         (createPagedBitmapContext):
3865         (createBitmapContext): Deleted.
3866         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
3867         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3868         (WTR::InjectedBundlePage::dump): Deleted.
3869         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3870         (WTR::PlatformWebView::windowSnapshotImage):
3871
3872 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3873
3874         [jhbuild] Added libxslt module.
3875         https://bugs.webkit.org/show_bug.cgi?id=159034
3876
3877         Unreviewed, followup for r202373.
3878
3879         * efl/install-dependencies: Removed libxslt 
3880         * gtk/install-dependencies: Ditto.
3881
3882 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3883
3884         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
3885         https://bugs.webkit.org/show_bug.cgi?id=159050
3886
3887         Reviewed by Antonio Gomes.
3888
3889         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
3890
3891         * efl/jhbuild.modules:
3892         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3893         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3894
3895 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3896
3897         [jhbuild] Added libxslt module.
3898         https://bugs.webkit.org/show_bug.cgi?id=159034
3899
3900         Reviewed by Michael Catanzaro.
3901
3902         * efl/jhbuild.modules:
3903         * gtk/jhbuild.modules:
3904
3905 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3906
3907         [Win] Use Windows api function to find top level parent.
3908         https://bugs.webkit.org/show_bug.cgi?id=159021
3909
3910         Reviewed by Brent Fulgham.
3911
3912         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
3913  
3914         * DumpRenderTree/win/UIDelegate.cpp:
3915         (UIDelegate::runModal):
3916         (findTopLevelParent): Deleted.
3917         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3918         (PrintWebUIDelegate::runModal):
3919         (findTopLevelParent): Deleted.
3920
3921 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3922
3923         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
3924         https://bugs.webkit.org/show_bug.cgi?id=158934
3925
3926         Reviewed by Brent Fulgham.
3927
3928         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
3929
3930         * DumpRenderTree/win/TestRunnerWin.cpp:
3931         (TestRunner::clearAllDatabases):
3932
3933 2016-06-22  Saam Barati  <sbarati@apple.com>
3934
3935         run-javascriptcore-tests should have some environment variables for commonly used settings
3936         https://bugs.webkit.org/show_bug.cgi?id=159047
3937
3938         Reviewed by Keith Miller.
3939
3940         This patch adds three environment variables that run-javascriptcore-tests
3941         consults:
3942         - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
3943           determines if we should run the api tests or not.
3944         - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
3945           determines if we will perform a build or not before running the tests.
3946           to set the default should-build setting.
3947         - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
3948           a yaml file. If set, we will run the extra tests it refers to.
3949
3950         All the values in these environment variables will be overridden if an
3951         option is explicitly passed in. For example, the following will run
3952         the api tests:
3953         `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
3954
3955         * Scripts/run-javascriptcore-tests:
3956
3957 2016-06-22  Saam barati  <sbarati@apple.com>
3958
3959         TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
3960         https://bugs.webkit.org/show_bug.cgi?id=159037
3961         <rdar://problem/26935349>
3962
3963         Reviewed by Benjamin Poulain.
3964
3965         Run typeProfiler.yaml tests under an additional CJIT enabled mode.
3966
3967         * Scripts/run-jsc-stress-tests:
3968
3969 2016-06-22  Aakash Jain  <aakash_jain@apple.com>
3970
3971         Fix style issues in webkitpy
3972         https://bugs.webkit.org/show_bug.cgi?id=159019
3973
3974         Reviewed by Daniel Bates.
3975
3976         Fixed the formatting issues as reported by check-webkit-style in webkitpy.
3977         There is no functionality change.
3978         Only affected file names retained below for brevity.
3979
3980         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3981         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3982         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3983         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3984         * Scripts/webkitpy/benchmark_runner/utils.py:
3985         * Scripts/webkitpy/common/checkout/changelog.py:
3986         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3987         * Scripts/webkitpy/common/checkout/checkout.py:
3988         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3989         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3990         * Scripts/webkitpy/common/checkout/commitinfo.py:
3991         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3992         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3993         * Scripts/webkitpy/common/checkout/scm/scm.py:
3994         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3995         * Scripts/webkitpy/common/config/committers_unittest.py:
3996         * Scripts/webkitpy/common/config/irc.py:
3997         * Scripts/webkitpy/common/config/ports.py:
3998         * Scripts/webkitpy/common/config/ports_unittest.py:
3999         * Scripts/webkitpy/common/config/urls.py:
4000         * Scripts/webkitpy/common/host_mock.py:
4001         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4002         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4003         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4004         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
4005         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4006         * Scripts/webkitpy/common/net/credentials_unittest.py:
4007         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
4008         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
4009         * Scripts/webkitpy/common/net/statusserver.py:
4010         * Scripts/webkitpy/common/system/autoinstall.py:
4011         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
4012         * Scripts/webkitpy/common/system/executive.py:
4013         * Scripts/webkitpy/common/system/executive_mock.py:
4014         * Scripts/webkitpy/common/system/executive_unittest.py:
4015         * Scripts/webkitpy/common/system/filesystem_mock.py:
4016         * Scripts/webkitpy/common/system/filesystem_unittest.py:
4017         * Scripts/webkitpy/common/system/logutils_unittest.py:
4018         * Scripts/webkitpy/common/system/path.py:
4019         * Scripts/webkitpy/common/system/path_unittest.py:
4020         * Scripts/webkitpy/common/system/platforminfo.py:
4021         * Scripts/webkitpy/common/system/user.py:
4022         * Scripts/webkitpy/common/system/user_unittest.py:
4023         * Scripts/webkitpy/common/system/workspace_unittest.py:
4024         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
4025         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
4026         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
4027         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4028         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4029         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4030         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
4031         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
4032         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4033         * Scripts/webkitpy/layout_tests/models/test_failures.py:
4034         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
4035         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4036         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
4037         * Scripts/webkitpy/layout_tests/views/printing.py:
4038         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4039         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
4040         * Scripts/webkitpy/port/base_unittest.py:
4041         * Scripts/webkitpy/port/driver.py:
4042         * Scripts/webkitpy/port/driver_unittest.py:
4043         * Scripts/webkitpy/port/factory.py:
4044         * Scripts/webkitpy/port/gtk.py:
4045         * Scripts/webkitpy/port/server_process_unittest.py:
4046         * Scripts/webkitpy/port/test.py:
4047         * Scripts/webkitpy/port/win.py:
4048         * Scripts/webkitpy/style/checker.py:
4049         * Scripts/webkitpy/style/checkers/common_unittest.py:
4050         * Scripts/webkitpy/style/checkers/cpp.py:
4051         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4052         * Scripts/webkitpy/style/checkers/js.py:
4053         * Scripts/webkitpy/style/checkers/jsonchecker.py:
4054         * Scripts/webkitpy/style/checkers/png.py:
4055         * Scripts/webkitpy/style/checkers/text.py:
4056         * Scripts/webkitpy/style/checkers/text_unittest.py:
4057         * Scripts/webkitpy/style/error_handlers.py:
4058         * Scripts/webkitpy/style/filter.py:
4059         * Scripts/webkitpy/style/filter_unittest.py:
4060         * Scripts/webkitpy/style/optparser.py:
4061         * Scripts/webkitpy/style/optparser_unittest.py:
4062         * Scripts/webkitpy/test/main.py:
4063         * Scripts/webkitpy/w3c/test_converter.py:
4064         * Scripts/webkitpy/w3c/test_converter_unittest.py:
4065         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4066         * Scripts/webkitpy/xcode/simulator.py:
4067
4068 2016-06-22  Brady Eidson  <beidson@apple.com>
4069
4070         DatabaseProcess doesn't handle WebProcesses going away uncleanly.
4071         https://bugs.webkit.org/show_bug.cgi?id=158894
4072
4073         Reviewed by Alex Christensen.
4074
4075         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4076         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
4077         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
4078         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
4079
4080 2016-06-22  Jon Lee  <jonlee@apple.com>
4081
4082         Update animometer.plan
4083         https://bugs.webkit.org/show_bug.cgi?id=159012
4084
4085         Reviewed by Ryosuke Niwa.
4086
4087         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
4088
4089 2016-06-22  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4090
4091         W3C test importer should generate files to ignore by WebKit SCM
4092         https://bugs.webkit.org/show_bug.cgi?id=142743
4093
4094         Reviewed by Darin Adler.
4095
4096         TestDownloader generates the .gitignore file according submodules git repository information.
4097         TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.
4098
4099         * Scripts/webkitpy/w3c/test_downloader.py:
4100         (TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
4101         * Scripts/webkitpy/w3c/test_importer.py:
4102         (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
4103         (TestImporter):
4104         (TestImporter.write_init_py): Writing not empty __init__.py files.
4105         (TestImporter.import_tests): Using  of write_init_py. 
4106         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4107         (TestImporterTest.test_git_ignore_generation): Added .gitignore test.
4108         (TestImporterTest):
4109         (TestImporterTest.test_initpy_generation): Added __init__.py test.
4110
4111 2016-06-21  Sam Weinig  <sam@webkit.org>
4112
4113         WKWebView with no WKNavigationDelegate does not follow universal links
4114         <rdar://problem/24374110>
4115         https://bugs.webkit.org/show_bug.cgi?id=158997
4116
4117         Reviewed by Dan Bernstein.
4118
4119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4120         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
4121         Add a new test that shows that we have a default navigation delegate by swizzling
4122         -[NSWorkspace openURL:]. This will only be called if there is a default client.
4123
4124 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4125
4126         [Win] Implement modal dialog support in MiniBrowser.
4127         https://bugs.webkit.org/show_bug.cgi?id=158976
4128
4129         Reviewed by Brent Fulgham.
4130
4131         * MiniBrowser/win/PrintWebUIDelegate.cpp:
4132         (PrintWebUIDelegate::createWebViewWithRequest):
4133         (getHandleFromWebView):
4134         (PrintWebUIDelegate::webViewClose):
4135         (PrintWebUIDelegate::setFrame):
4136         (PrintWebUIDelegate::webViewFrame):
4137         (PrintWebUIDelegate::canRunModal):
4138         (findTopLevelParent):
4139         (PrintWebUIDelegate::runModal):
4140         (PrintWebUIDelegate::createModalDialog):
4141         * MiniBrowser/win/PrintWebUIDelegate.h:
4142         (PrintWebUIDelegate::webViewClose):
4143         (PrintWebUIDelegate::setFrame):
4144         (PrintWebUIDelegate::webViewFrame):
4145         (PrintWebUIDelegate::canRunModal):
4146         (PrintWebUIDelegate::runModal):
4147
4148 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4149
4150         window.showModalDialog doesn't work in DumpRenderTree on Windows
4151         https://bugs.webkit.org/show_bug.cgi?id=53675
4152
4153         Reviewed by Brent Fulgham.
4154
4155         Implement modal dialog support in DumpRenderTree.
4156
4157         * DumpRenderTree/win/UIDelegate.cpp:
4158         (UIDelegate::canRunModal):
4159         (getHandleFromWebView):
4160         (UIDelegate::createModalDialog):
4161         (findTopLevelParent):
4162         (UIDelegate::runModal):
4163         (UIDelegate::webViewClose):
4164         * DumpRenderTree/win/UIDelegate.h:
4165
4166 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
4167
4168         Fix formatting issues reported by check-webkit-style
4169         https://bugs.webkit.org/show_bug.cgi?id=159008
4170
4171         Reviewed by Alexey Proskuryakov.
4172
4173         Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
4174         There is no functionality change.
4175
4176         * Scripts/webkitpy/tool/bot/irc_command.py:
4177         (Restart.execute):
4178         (Rollout):
4179         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
4180         (IRCBotTest.test_exception_during_command):
4181         (IRCBotTest.test_exception_during_command.CommandWithException):
4182         (IRCBotTest.test_exception_during_command.CommandWithException.execute):
4183         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
4184         (test_missing_unit_test_results_path):
4185         (test_layout_test_results):
4186         * Scripts/webkitpy/tool/bot/queueengine.py:
4187         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
4188         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
4189         (AbstractSequencedCommand):
4190         (AbstractSequencedCommand.__init__):
4191         * Scripts/webkitpy/tool/commands/download.py:
4192         (Land):
4193         * Scripts/webkitpy/tool/commands/openbugs.py:
4194         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
4195         (OpenBugsTest):
4196         * Scripts/webkitpy/tool/commands/queries.py:
4197         (PatchesToCommitQueue):
4198         (PatchesToCommitQueue.__init__):
4199         (PatchesToCommitQueue._needs_commit_queue):
4200         * Scripts/webkitpy/tool/commands/queries_unittest.py:
4201         (PrintExpectationsTest.test_platform):
4202         (PrintBaselinesTest):
4203         (PrintBaselinesTest.setUp):
4204         * Scripts/webkitpy/tool/commands/queues.py:
4205         (AbstractQueue):
4206         (AbstractQueue.__init__):
4207         (AbstractQueue.execute):
4208         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4209         (test_auto_retry):
4210         * Scripts/webkitpy/tool/commands/rebaseline.py:
4211         (AbstractParallelRebaselineCommand._files_to_add):
4212         (AbstractParallelRebaselineCommand):
4213         (AbstractParallelRebaselineCommand._rebaseline):
4214         * Scripts/webkitpy/tool/commands/setupgitclone.py:
4215         (SetupGitClone):
4216         * Scripts/webkitpy/tool/commands/sheriffbot.py:
4217         * Scripts/webkitpy/tool/commands/stepsequence.py:
4218         * Scripts/webkitpy/tool/commands/upload.py:
4219         (PostCommits._comment_text_for_commit):
4220         (PostCommits):
4221         (PostCommits.execute):
4222         (MarkBugFixed):
4223         (MarkBugFixed.__init__):
4224         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4225         (UploadCommandsTest):
4226         (UploadCommandsTest.test_commit_message_for_current_diff):
4227         * Scripts/webkitpy/tool/grammar_unittest.py:
4228         (GrammarTest):
4229         (GrammarTest.test_join_with_separators):
4230         * Scripts/webkitpy/tool/multicommandtool.py:
4231         (HelpCommand.__init__):
4232         (HelpCommand):
4233         (HelpCommand._help_epilog):
4234         (HelpCommand._remove_help_options):
4235         (MultiCommandTool):
4236         (MultiCommandTool.__init__):
4237         (MultiCommandTool.main):
4238         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
4239         (TrivialCommand):
4240         (TrivialCommand.__init__):
4241         (MultiCommandToolTest):
4242         (MultiCommandToolTest._assert_tool_main_outputs):
4243         (MultiCommandToolTest.test_retry):
4244         (test_command_help):
4245         * Scripts/webkitpy/tool/steps/__init__.py:
4246         * Scripts/webkitpy/tool/steps/abstractstep.py:
4247         * Scripts/webkitpy/tool/steps/applypatch.py:
4248         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
4249         (ApplyPatchWithLocalCommit):
4250         (ApplyPatchWithLocalCommit.options):
4251         * Scripts/webkitpy/tool/steps/build.py:
4252         * Scripts/webkitpy/tool/steps/checkstyle.py:
4253         (CheckStyle):
4254         (CheckStyle.options):
4255         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4256         * Scripts/webkitpy/tool/steps/closebug.py:
4257         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
4258         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
4259         (CloseBugForLandDiffTest):
4260         (CloseBugForLandDiffTest.test_empty_state):
4261         * Scripts/webkitpy/tool/steps/closepatch.py:
4262         * Scripts/webkitpy/tool/steps/commit.py:
4263         (Commit.run):
4264         * Scripts/webkitpy/tool/steps/confirmdiff.py:
4265         * Scripts/webkitpy/tool/steps/editchangelog.py:
4266         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
4267         * Scripts/webkitpy/tool/steps/metastep.py:
4268         (MetaStep):
4269         (MetaStep.__init__):
4270         (MetaStep.run):
4271         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
4272   &