[iOS] WKWebView callout bar is missing Change Writing Direction item
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         [iOS] WKWebView callout bar is missing Change Writing Direction item
4         https://bugs.webkit.org/show_bug.cgi?id=190015
5         <rdar://problem/44810366>
6
7         Reviewed by Tim Horton.
8
9         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
10         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
11
12         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
13         (TestWebKitAPI::TEST):
14
15 2019-02-15  Chris Dumez  <cdumez@apple.com>
16
17         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
18         https://bugs.webkit.org/show_bug.cgi?id=194717
19         <rdar://problem/47884404>
20
21         Reviewed by Brady Eidson.
22
23         Add API test coverage.
24
25         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
26
27 2019-02-15  Youenn Fablet  <youenn@apple.com>
28
29         Make navigator.mediaDevices SecureContext
30         https://bugs.webkit.org/show_bug.cgi?id=194666
31
32         Reviewed by Eric Carlson.
33
34         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
35         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
36         (TEST_F):
37
38 2019-02-15  Brian Burg  <bburg@apple.com>
39
40         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
41         https://bugs.webkit.org/show_bug.cgi?id=194411
42         <rdar://problem/47787614>
43
44         Reviewed by Joseph Pecoraro.
45
46         Remove unnecessary soft linking macro usage.
47
48         * DumpRenderTree/mac/TestRunnerMac.mm:
49         (TestRunner::inspectorTestStubURL):
50         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
51         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
52         (WTR::TestRunner::inspectorTestStubURL):
53
54 2019-02-15  Commit Queue  <commit-queue@webkit.org>
55
56         Unreviewed, rolling out r241559 and r241566.
57         https://bugs.webkit.org/show_bug.cgi?id=194710
58
59         Causes layout test crashes under GuardMalloc (Requested by
60         ryanhaddad on #webkit).
61
62         Reverted changesets:
63
64         "[WTF] Add environment variable helpers"
65         https://bugs.webkit.org/show_bug.cgi?id=192405
66         https://trac.webkit.org/changeset/241559
67
68         "Unreviewed build fix for WinCairo Debug after r241559."
69         https://trac.webkit.org/changeset/241566
70
71 2019-02-15  Zalan Bujtas  <zalan@apple.com>
72
73         [LFC] Out-of-flow box is never a float box
74         https://bugs.webkit.org/show_bug.cgi?id=194704
75
76         Reviewed by Antti Koivisto.
77
78         * LayoutReloaded/misc/LFC-passing-tests.txt:
79
80 2019-02-10  Darin Adler  <darin@apple.com>
81
82         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
83         https://bugs.webkit.org/show_bug.cgi?id=194487
84
85         Reviewed by Daniel Bates.
86
87         * DumpRenderTree/win/DumpRenderTree.cpp:
88         (applicationId): Use makeString instead of String::format.
89         (main): Ditto.
90         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
91         (TestWebKitAPI::Util::createURLForResource): Ditto.
92         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
93         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
94
95         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
96         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
97         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
98         (WTR::createStringWithAttributes): Use appendLiteral.
99         (WTR::AccessibilityUIElement::helpText const): Ditto.
100         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
101         directly instead of using String::format.
102         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
103         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
104
105 2019-02-15  Truitt Savell  <tsavell@apple.com>
106
107         Unreviewed, rolling out r241564.
108
109         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
110
111         Reverted changeset:
112
113         "[Mac] WebInspectorUI.framework does not need to be soft-
114         linked anymore"
115         https://bugs.webkit.org/show_bug.cgi?id=194411
116         https://trac.webkit.org/changeset/241564
117
118 2019-02-15  Saam barati  <sbarati@apple.com>
119
120         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
121         https://bugs.webkit.org/show_bug.cgi?id=194036
122
123         Reviewed by Yusuke Suzuki.
124
125         * Scripts/run-jsc-stress-tests:
126
127 2019-02-14  Tim Horton  <timothy_horton@apple.com>
128
129         Fix the build.
130
131         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
132         (WTR::UIScriptController::drawSquareInEditableImage):
133         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
134         (TestWebKitAPI::drawSquareInEditableImage):
135
136 2019-02-14  Tim Horton  <timothy_horton@apple.com>
137
138         Fix the build.
139
140         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
141         (WTR::UIScriptController::drawSquareInEditableImage):
142         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
143         (TestWebKitAPI::drawSquareInEditableImage):
144
145 2019-02-14  Brian Burg  <bburg@apple.com>
146
147         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
148         https://bugs.webkit.org/show_bug.cgi?id=194411
149         <rdar://problem/47787614>
150
151         Reviewed by Joseph Pecoraro.
152
153         Remove unnecessary soft linking macro usage.
154
155         * DumpRenderTree/mac/TestRunnerMac.mm:
156         (TestRunner::inspectorTestStubURL):
157         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
158         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
159         (WTR::TestRunner::inspectorTestStubURL):
160
161 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
162
163         [ews-app] status bubble should fetch builder name info from BuilderMapping table
164         https://bugs.webkit.org/show_bug.cgi?id=194599
165
166         Reviewed by Lucas Forschler.
167
168         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
169         (StatusBubble._build_bubble):
170
171 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
172
173         [ews-app] Set Foreign Key in Django build model
174         https://bugs.webkit.org/show_bug.cgi?id=194667
175
176         Reviewed by Lucas Forschler.
177
178         * BuildSlaveSupport/ews-app/ews/models/build.py:
179         (Build):
180
181 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
182
183         [WTF] Add environment variable helpers
184         https://bugs.webkit.org/show_bug.cgi?id=192405
185
186         Reviewed by Michael Catanzaro.
187
188         * DumpRenderTree/mac/DumpRenderTree.mm:
189         (libraryPathForDumpRenderTree):
190         * DumpRenderTree/win/DumpRenderTree.cpp:
191         (libraryPathForDumpRenderTree):
192         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
193         (setUpIOSLayoutTestCommunication):
194         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
195         (TestWebKitAPI::strip):
196         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
197         (beforeAll):
198         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
199         (main):
200         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
201         (WebKitTestBus::run):
202         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
203         (WTR::getOutputDir):
204         (WTR::initializeFontConfigSetting):
205         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
206         (WTR::InjectedBundle::platformInitialize):
207         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
208         (WTR::topLevelPath):
209         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
210         (WTR::topLevelPath):
211         (WTR::getOutputDir):
212         (WTR::activateFonts):
213         * WebKitTestRunner/TestController.cpp:
214         (WTR::TestController::libraryPathForTesting):
215         (WTR::TestController::generateContextConfiguration const):
216         (WTR::TestController::generatePageConfiguration):
217         (WTR::TestController::decideDestinationWithSuggestedFilename):
218         (WTR::TestController::platformAdjustContext):
219         * WebKitTestRunner/TestController.h:
220         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
221         (WTR::TestController::cocoaPlatformInitialize):
222         (WTR::TestController::platformAdjustContext):
223         * WebKitTestRunner/gtk/main.cpp:
224         (main):
225         * WebKitTestRunner/mac/TestControllerMac.mm:
226         (WTR::TestController::configureContentExtensionForTest):
227         * WebKitTestRunner/wpe/main.cpp:
228         (main):
229         Utilize WTF::Environment where possible.
230
231 2019-02-14  Chris Dumez  <cdumez@apple.com>
232
233         [PSON] Introduce a WebContent Process cache
234         https://bugs.webkit.org/show_bug.cgi?id=194594
235         <rdar://problem/46793397>
236
237         Reviewed by Geoff Garen.
238
239         Update API tests to turn on the WebContent Process cache.
240
241         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
242
243 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
244
245         Unreviewed, build fix after r241480
246
247         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
248         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
249         (-[DragAndDropSimulator initWithWebView:]):
250
251 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
252
253         AX: ARIA Reflection was disabled in error
254         https://bugs.webkit.org/show_bug.cgi?id=194647
255         <rdar://problem/48068336>
256
257         Reviewed by Ryosuke Niwa.
258
259         Remove test override now that this feature should be enabled by default.
260
261         * WebKitTestRunner/TestController.cpp:
262         (WTR::TestController::resetPreferencesToConsistentValues):
263
264 2019-02-14  Commit Queue  <commit-queue@webkit.org>
265
266         Unreviewed, rolling out r241486.
267         https://bugs.webkit.org/show_bug.cgi?id=194655
268
269         causing API failures in builds (Requested by ShawnRoberts on
270         #webkit).
271
272         Reverted changeset:
273
274         "[Cocoa] Media elements will restart network buffering just
275         before suspending"
276         https://bugs.webkit.org/show_bug.cgi?id=193691
277         https://trac.webkit.org/changeset/241486
278
279 2019-02-14  Zalan Bujtas  <zalan@apple.com>
280
281         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
282         https://bugs.webkit.org/show_bug.cgi?id=194622
283
284         Reviewed by Antti Koivisto.
285
286         * LayoutReloaded/misc/LFC-passing-tests.txt:
287
288 2019-02-14  Zalan Bujtas  <zalan@apple.com>
289
290         [LFC] Shrink-to-fit-width should be constrained by min/max width
291         https://bugs.webkit.org/show_bug.cgi?id=194653
292
293         Reviewed by Antti Koivisto.
294
295         * LayoutReloaded/misc/LFC-passing-tests.txt:
296
297 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
298
299         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
300         https://bugs.webkit.org/show_bug.cgi?id=194641
301
302         Reviewed by Geoffrey Garen.
303
304         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
305         so that the test would fail without this fix.
306
307         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
308         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
309
310 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
311
312         [ews-app] Change log level for a log statement
313
314         Unreviewed minor fix.
315
316         * BuildSlaveSupport/ews-app/ews/models/patch.py:
317         (Patch.save_patch):
318
319 2019-02-13  Jer Noble  <jer.noble@apple.com>
320
321         [Cocoa] Media elements will restart network buffering just before suspending
322         https://bugs.webkit.org/show_bug.cgi?id=193691
323
324         Reviewed by Eric Carlson.
325
326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
327         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
328         (TEST):
329
330 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
331
332         [ews-app] Fetch builder id to name mapping
333         https://bugs.webkit.org/show_bug.cgi?id=194355
334
335         Reviewed by Lucas Forschler.
336
337         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
338         (Buildbot.get_builder_id_to_name_mapping):
339         (Buildbot._get_display_name_from_builder_name):
340
341 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
342
343         Further restricting webarchive loads
344         https://bugs.webkit.org/show_bug.cgi?id=194567
345         <rdar://problem/47610130>
346
347         Reviewed by Youenn Fablet.
348
349         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
350         navigations on drop.
351
352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
353         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
354         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
355         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
356         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
357         (TestWebKitAPI::TEST):
358         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
359         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
360         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
361         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
362         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
363         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
364         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
365
366 2019-02-13  John Wilander  <wilander@apple.com>
367
368         Store Ad Click Attribution requests in the network process
369         https://bugs.webkit.org/show_bug.cgi?id=194510
370         <rdar://problem/47650118>
371
372         Reviewed by Alex Christensen and Daniel Bates.
373
374         This patch adds two TestRunner functions:
375         - dumpAdClickAttribution()
376         - clearAdClickAttribution()
377
378         They call into the network process to dump and clear Ad Click
379         Attribution state, respectively.
380
381         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
382         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
383         (WTR::TestRunner::dumpAdClickAttribution):
384         (WTR::TestRunner::clearAdClickAttribution):
385         * WebKitTestRunner/InjectedBundle/TestRunner.h:
386         * WebKitTestRunner/TestController.cpp:
387         (WTR::TestController::resetStateToConsistentValues):
388         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
389         (WTR::adClickAttributionStringResultCallback):
390         (WTR::TestController::dumpAdClickAttribution):
391         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
392         (WTR::adClickAttributionVoidCallback):
393         (WTR::TestController::clearAdClickAttribution):
394         * WebKitTestRunner/TestController.h:
395         * WebKitTestRunner/TestInvocation.cpp:
396         (WTR::TestInvocation::dumpResults):
397         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
398         (WTR::TestInvocation::dumpAdClickAttribution):
399         * WebKitTestRunner/TestInvocation.h:
400
401 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
402
403         [ews-app] Generate status-bubble
404         https://bugs.webkit.org/show_bug.cgi?id=194572
405
406         Reviewed by Lucas Forschler.
407
408         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
409         (StatusBubble._build_bubble):
410         (StatusBubble._should_show_bubble_for):
411         (StatusBubble._build_bubbles_for_patch):
412
413 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
414
415         [ews-app] Add status bubble html template
416         https://bugs.webkit.org/show_bug.cgi?id=194571
417
418         Reviewed by Lucas Forschler.
419
420         * BuildSlaveSupport/ews-app/ews/templates: Added.
421         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
422
423 2019-02-12  Chris Dumez  <cdumez@apple.com>
424
425         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
426         https://bugs.webkit.org/show_bug.cgi?id=194568
427         <rdar://problem/47944490>
428
429         Reviewed by Ryosuke Niwa.
430
431         Add API test coverage.
432
433         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
434         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
435
436 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
437
438         webkitpy: Remove bug_dummy from parsed test expectations
439         https://bugs.webkit.org/show_bug.cgi?id=194562
440         <rdar://problem/47853999>
441
442         Reviewed by Lucas Forschler.
443
444         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
445         (TestExpectationParser):
446         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
447         skipped tests.
448         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
449
450 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
451
452         [ews-app] Add method to fetch patch
453         https://bugs.webkit.org/show_bug.cgi?id=194518
454
455         Reviewed by Lucas Forschler.
456
457         * BuildSlaveSupport/ews-app/ews/models/patch.py:
458         (Patch.get_patch):
459
460 2019-02-12  Zalan Bujtas  <zalan@apple.com>
461
462         [LFC] Expand tests coverage (60 new tests -> 860)
463
464         Unreviewed test gardening (run-singly, --child-processes=1).
465
466         * LayoutReloaded/misc/LFC-passing-tests.txt:
467
468 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
469
470         Allow pages to trigger programmatic paste from script on iOS
471         https://bugs.webkit.org/show_bug.cgi?id=194271
472         <rdar://problem/47808810>
473
474         Reviewed by Tim Horton.
475
476         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
477
478         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
479         (WTR::UIScriptController::platformSetDidShowMenuCallback):
480         (WTR::UIScriptController::platformSetDidHideMenuCallback):
481         (WTR::UIScriptController::rectForMenuAction const):
482
483         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
484         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
485         for when the menu is shown or hidden.
486
487         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
488         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
489         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
490         (WTR::UIScriptController::setDidShowMenuCallback):
491         (WTR::UIScriptController::didShowMenuCallback const):
492         (WTR::UIScriptController::setDidHideMenuCallback):
493         (WTR::UIScriptController::didHideMenuCallback const):
494         (WTR::UIScriptController::platformSetDidShowMenuCallback):
495         (WTR::UIScriptController::platformSetDidHideMenuCallback):
496         (WTR::UIScriptController::rectForMenuAction const):
497         * TestRunnerShared/UIScriptContext/UIScriptController.h:
498         * WebKitTestRunner/TestController.cpp:
499         (WTR::TestController::resetPreferencesToConsistentValues):
500         (WTR::updateTestOptionsFromTestHeader):
501         * WebKitTestRunner/TestOptions.h:
502
503         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
504         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
505
506         (WTR::TestOptions::hasSameInitializationOptions const):
507         * WebKitTestRunner/UIScriptControllerCocoa.mm:
508         (WTR::UIScriptController::calendarType const):
509         (WTR::UIScriptController::platformUndoManager const):
510         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
511         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
512         (-[TestRunnerWKWebView initWithFrame:configuration:]):
513         (-[TestRunnerWKWebView dealloc]):
514         (-[TestRunnerWKWebView _didShowMenu]):
515         (-[TestRunnerWKWebView _didHideMenu]):
516
517         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
518
519         * WebKitTestRunner/ios/TestControllerIOS.mm:
520         (WTR::handleMenuWillHideNotification):
521         (WTR::handleMenuDidHideNotification):
522         (WTR::TestController::platformInitialize):
523         (WTR::TestController::platformDestroy):
524         (WTR::TestController::platformResetStateToConsistentValues):
525
526         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
527         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
528
529         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
530         (WTR::forEachViewInHierarchy):
531         (WTR::findViewInHierarchyOfType):
532
533         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
534         functions that dig through a given view's hierarchy in search of a view of a given class.
535
536         (WTR::UIScriptController::selectionStartGrabberViewRect const):
537         (WTR::UIScriptController::selectionEndGrabberViewRect const):
538         (WTR::UIScriptController::selectionCaretViewRect const):
539         (WTR::UIScriptController::selectionRangeViewRects const):
540         (WTR::UIScriptController::platformSetDidShowMenuCallback):
541         (WTR::UIScriptController::platformSetDidHideMenuCallback):
542
543         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
544
545         (WTR::UIScriptController::rectForMenuAction const):
546
547         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
548         callout bar) whose label matches the given string.
549
550         (WTR::UIScriptController::platformContentView const):
551
552         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
553         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
554         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
555
556         (WTR::UIScriptController::platformUndoManager const): Deleted.
557         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
558         (WTR::UIScriptController::platformContentView const):
559         (WTR::UIScriptController::platformUndoManager const): Deleted.
560
561 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
562
563         webkitpy: No option to only show unexpected failures in results.html for iPad
564         https://bugs.webkit.org/show_bug.cgi?id=194554
565         <rdar://problem/47922442>
566
567         Rubber-stamped by Aakash Jain.
568
569         Just because a TestExpecations file does not exist for a specific platform does not mean that
570         TestExpecations are not being used, given that platforms inherit test expectations.
571
572         * Scripts/webkitpy/port/base.py:
573         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
574         * Scripts/webkitpy/port/base_unittest.py:
575         (PortTest.test_uses_test_expectations_file):
576
577 2019-02-12  Alex Christensen  <achristensen@webkit.org>
578
579         Remove setDefersLoading infrastructure from WebKit2
580         https://bugs.webkit.org/show_bug.cgi?id=194506
581
582         Reviewed by Brady Eidson.
583
584         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
585         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
586         (WTR::TestRunner::setDefersLoading): Deleted.
587         * WebKitTestRunner/InjectedBundle/TestRunner.h:
588
589 2019-02-12  Alex Christensen  <achristensen@webkit.org>
590
591         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
592         https://bugs.webkit.org/show_bug.cgi?id=194522
593         <rdar://problem/47789393>
594
595         Reviewed by Chris Dumez.
596
597         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
598         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
599         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
600         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
601
602 2019-02-12  Andy Estes  <aestes@apple.com>
603
604         [iOSMac] Enable Parental Controls Content Filtering
605         https://bugs.webkit.org/show_bug.cgi?id=194521
606         <rdar://39732376>
607
608         Reviewed by Tim Horton.
609
610         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
611
612 2019-02-12  Zalan Bujtas  <zalan@apple.com>
613
614         [LFC][IFC] Add intrinsic width support for float boxes.
615         https://bugs.webkit.org/show_bug.cgi?id=194528
616
617         Reviewed by Antti Koivisto.
618
619         Expand tests coverage (2 new tests -> 800).
620         (This is the correct test ordering --runs-singly --child-processes=1)
621
622         * LayoutReloaded/misc/LFC-passing-tests.txt:
623
624 2019-02-12  Rob Buis  <rbuis@igalia.com>
625
626         Implement serializing in MIME type parser
627         https://bugs.webkit.org/show_bug.cgi?id=193909
628
629         Reviewed by Darin Adler.
630
631         Add various tests involving upper case, non-ASCII, control/null characters,
632         various HTTP whitespace, single quotes and an unpaired surrogate.
633
634         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
635         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
636         (TestWebKitAPI::serializeIfValid):
637         (TestWebKitAPI::TEST):
638
639 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
640
641         [Cocoa] Ask platform for generic font family mappings
642         https://bugs.webkit.org/show_bug.cgi?id=187723
643         <rdar://problem/41892438>
644
645         Reviewed by Brent Fulgham.
646
647         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
648
649         * DumpRenderTree/mac/DumpRenderTree.mm:
650         (allowedFontFamilySet):
651         * WebKitTestRunner/mac/TestControllerMac.mm:
652         (WTR::allowedFontFamilySet):
653
654 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
655
656         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
657         https://bugs.webkit.org/show_bug.cgi?id=193622
658
659         Reviewed by Michael Catanzaro.
660
661         This adds support for loading content extension rule sets from the JSON files which
662         accompany the corresponding layout test, using the C API. The Cocoa specific parts
663         of WKTR for this could be removed, but that is left for a follow-up patch with
664         cleanups.
665
666         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
667         * WebKitTestRunner/TestController.cpp:
668         (WTR::testPath): Subtract one from the length when constructing the result std::string to
669         avoid having the null-terminator copied into the result.
670         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
671         part of the preparations to run a test.
672         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
673         (WTR::contentExtensionStoreCallback): Added.
674         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
675         used for content extensions test.
676         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
677         extensions and compiling the JSON rule set for tests involving content extensions.
678         (WTR::TestController::resetContentExtensions): Removes the content extension built for
679         testing and disables content extensions.
680         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
681         resetContentExtensions().
682         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
683         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
684         configureContentExtensionForTest(), and userContentController().
685
686 2019-02-11  Daniel Bates  <dabates@apple.com>
687
688         [iOS] Mouse/Touch/Pointer events are missing modifier keys
689         https://bugs.webkit.org/show_bug.cgi?id=191446
690         <rdar://problem/45929460>
691
692         Reviewed by Tim Horton.
693
694         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
695
696         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
697         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
698         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
699         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
700         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
701         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
702         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
703         * TestRunnerShared/UIScriptContext/UIScriptController.h:
704         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
705         (WTR::arrayLength):
706         (WTR::parseModifierArray):
707         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
708         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
709         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
710         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
711
712 2019-02-11  Commit Queue  <commit-queue@webkit.org>
713
714         Unreviewed, rolling out r241272 and r241276.
715         https://bugs.webkit.org/show_bug.cgi?id=194514
716
717         Broke the Apple Internal build and the fix requires human
718         intervention :( (Requested by dydz on #webkit).
719
720         Reverted changesets:
721
722         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
723         https://bugs.webkit.org/show_bug.cgi?id=191446
724         https://trac.webkit.org/changeset/241272
725
726         "Fix internal iOS build after r241272"
727         https://bugs.webkit.org/show_bug.cgi?id=191446
728         https://trac.webkit.org/changeset/241276
729
730 2019-02-11  Truitt Savell  <tsavell@apple.com>
731
732         Unreviewed, rolling out r241269.
733
734         Caused 5 layout tests crashes on Mac WK1
735
736         Reverted changeset:
737
738         "DumpRenderTree should report unknown options"
739         https://bugs.webkit.org/show_bug.cgi?id=191303
740         https://trac.webkit.org/changeset/241269
741
742 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
743
744         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
745         https://bugs.webkit.org/show_bug.cgi?id=194313
746
747         Reviewed by Tim Horton.
748
749         Add a helper to determine whether the web view is presenting modal UI.
750
751         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
752         (WTR::UIScriptController::isPresentingModally const):
753         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
754         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
755         (WTR::UIScriptController::isPresentingModally const):
756         * TestRunnerShared/UIScriptContext/UIScriptController.h:
757         * WebKitTestRunner/UIScriptControllerCocoa.mm:
758         (WTR::UIScriptController::calendarType const): Deleted.
759         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
760         (WTR::UIScriptController::isPresentingModally const):
761         (WTR::UIScriptController::calendarType const):
762         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
763         (WTR::UIScriptController::calendarType const):
764
765 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
766
767         GCHeapInspector: Show the retained sizes in more places
768         https://bugs.webkit.org/show_bug.cgi?id=194464
769
770         Reviewed by Simon Fraser.
771
772         * GCHeapInspector/gc-heap-inspector.html:
773         * GCHeapInspector/script/interface.js:
774         (HeapInspectorUtils.humanReadableSize):
775         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
776         (HeapInspectorUtils.spanForNode.span.span):
777         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
778         (HeapSnapshotInspector.prototype.buildRoots):
779
780 2019-02-11  Daniel Bates  <dabates@apple.com>
781
782         [iOS] Mouse/Touch/Pointer events are missing modifier keys
783         https://bugs.webkit.org/show_bug.cgi?id=191446
784         <rdar://problem/45929460>
785
786         Reviewed by Tim Horton.
787
788         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
789
790         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
791         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
792         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
793         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
794         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
795         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
796         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
797         * TestRunnerShared/UIScriptContext/UIScriptController.h:
798         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
799         (WTR::arrayLength):
800         (WTR::parseModifierArray):
801         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
802         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
803         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
804         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
805
806 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
807
808         DumpRenderTree should report unknown options
809         https://bugs.webkit.org/show_bug.cgi?id=191303
810
811         Reviewed by Frédéric Wang.
812
813         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
814         to report unknown options.
815         Added and assigned test options which are currently used in tests.
816
817         * DumpRenderTree/TestOptions.cpp:
818         (TestOptions::TestOptions):
819
820 2019-02-11  Truitt Savell  <tsavell@apple.com>
821
822         Unreviewed, rolling out r241229.
823
824         Revision broke internal builds for watchOS.
825
826         Reverted changeset:
827
828         "[Cocoa] Ask platform for generic font family mappings"
829         https://bugs.webkit.org/show_bug.cgi?id=187723
830         https://trac.webkit.org/changeset/241229
831
832 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
833
834         [WinCairo][MiniBrowser] Basic authentication always fails.
835         https://bugs.webkit.org/show_bug.cgi?id=194496
836
837         Reviewed by Don Olmstead.
838
839         * MiniBrowser/win/DialogHelper.h:
840         (Dialog::getText):
841
842 2019-02-11  Philippe Normand  <pnormand@igalia.com>
843
844         [GStreamer] GstMappedBuffer testsuite build fails
845         https://bugs.webkit.org/show_bug.cgi?id=194495
846
847         Reviewed by Carlos Garcia Campos.
848
849         Fix the build by explicitely adding the gstreamer1.0-audio include
850         directories to the include path.
851
852         * TestWebKitAPI/PlatformGTK.cmake:
853         * TestWebKitAPI/PlatformWPE.cmake:
854
855 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
856
857         [GTK][WPE] Add enable-javascript-markup setting
858         https://bugs.webkit.org/show_bug.cgi?id=193439
859
860         Reviewed by Michael Catanzaro.
861
862         Add test cases to check the new setting.
863
864         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
865         (testWebKitSettings):
866         (testWebKitSettingsJavaScriptMarkup):
867         (beforeAll):
868
869 2019-02-10  Darin Adler  <darin@apple.com>
870
871         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
872         https://bugs.webkit.org/show_bug.cgi?id=194485
873
874         Reviewed by Daniel Bates.
875
876         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
877
878 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
879
880         Add more tests for clampTo<>()
881         https://bugs.webkit.org/show_bug.cgi?id=194462
882
883         Reviewed by Geoffrey Garen.
884
885         Darin suggested to test the very last floating point number
886         at the boundaries when truncating to integer.
887         I added test for max/min and max-1/min-1.
888
889         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
890         (TestWebKitAPI::TEST):
891
892 2019-02-09  Darin Adler  <darin@apple.com>
893
894         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
895         https://bugs.webkit.org/show_bug.cgi?id=194021
896
897         Reviewed by Geoffrey Garen.
898
899         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
900         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
901         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
902
903 2019-02-09  Zalan Bujtas  <zalan@apple.com>
904
905         [LFC][IFC] Add intrinsic width support for basic inline containers
906         https://bugs.webkit.org/show_bug.cgi?id=194473
907
908         Reviewed by Antti Koivisto.
909
910         Expand tests coverage (11 new tests -> 798)
911
912         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
913
914 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
915
916         Fix MiniBrowser's entitlements
917         https://bugs.webkit.org/show_bug.cgi?id=192431
918
919         Reviewed by Joseph Pecoraro.
920
921         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
922         files, making it impossible to load any extension.
923
924         * MiniBrowser/MiniBrowser.entitlements:
925
926 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
927
928         [Cocoa] Ask platform for generic font family mappings
929         https://bugs.webkit.org/show_bug.cgi?id=187723
930         <rdar://problem/41892438>
931
932         Reviewed by Brent Fulgham.
933
934         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
935
936         * DumpRenderTree/mac/DumpRenderTree.mm:
937         (allowedFontFamilySet):
938         * WebKitTestRunner/mac/TestControllerMac.mm:
939         (WTR::allowedFontFamilySet):
940
941 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
942
943         [GTK] Implement back/forward touchpad gesture
944         https://bugs.webkit.org/show_bug.cgi?id=193919
945
946         Reviewed by Michael Catanzaro.
947
948         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
949         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
950
951 2019-02-08  Alex Christensen  <achristensen@webkit.org>
952
953         Add SPI to use networking daemon instead of XPC service
954         https://bugs.webkit.org/show_bug.cgi?id=194427
955
956         Reviewed by Geoffrey Garen
957
958         * MiniBrowser/MiniBrowser.entitlements:
959
960 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
961
962         [ews-build] Ensure that every builder in config.json has short name
963         https://bugs.webkit.org/show_bug.cgi?id=194461
964
965         Reviewed by Lucas Forschler.
966
967         * BuildSlaveSupport/ews-build/loadConfig.py:
968         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
969
970 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
971
972         [ews-build] Add short name to config.json
973         https://bugs.webkit.org/show_bug.cgi?id=194456
974
975         Reviewed by Lucas Forschler.
976
977         * BuildSlaveSupport/ews-build/config.json: Added short name.
978         * BuildSlaveSupport/ews-build/loadConfig.py:
979         (loadBuilderConfig): Set the short name as the builder description.
980
981 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
982
983         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
984         https://bugs.webkit.org/show_bug.cgi?id=194418
985
986         Reviewed by Lucas Forschler.
987
988         Do not include errors trying when finding crashlogs at the end of
989         a run-webkit-tests run since we don't process those errors.
990
991         * Scripts/webkitpy/port/darwin.py:
992         (DarwinPort._look_for_all_crash_logs_in_log_dir):
993         * Scripts/webkitpy/port/ios_device.py:
994         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
995         * Scripts/webkitpy/port/watch_device.py:
996         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
997
998 2019-02-08  Beth Dakin  <bdakin@apple.com>
999
1000         Add afterScreenUpdates to WKSnapshotConfiguration
1001         https://bugs.webkit.org/show_bug.cgi?id=194362
1002         -and corresponding-
1003         <rdar://problem/40655528> Please add an "after screen updates" property to 
1004         WKSnapshotConfiguration (to solve blank snapshots)
1005
1006         Reviewed by Tim Horton.
1007
1008         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1009         (TEST):
1010
1011 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1012
1013         clampTo(): do not convert the input to double when dealing with integers
1014         https://bugs.webkit.org/show_bug.cgi?id=194263
1015         <rdar://problem/47692312>
1016
1017         Reviewed by Darin Adler.
1018
1019         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1020         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1021         (TestWebKitAPI::testClampFloatingPointToInteger):
1022         (TestWebKitAPI::testClampSameSignIntegers):
1023         (TestWebKitAPI::testClampUnsignedToSigned):
1024         (TestWebKitAPI::testClampSignedToUnsigned):
1025
1026 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1027
1028         webkitpy: Respect --dedicated-simulators flag
1029         https://bugs.webkit.org/show_bug.cgi?id=194416
1030         <rdar://problem/47894722>
1031
1032         Reviewed by Lucas Forschler.
1033
1034         * Scripts/webkitpy/port/device_port.py:
1035         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1036         available devices can be safely ignored.
1037
1038 2019-02-07  Keith Rollin  <krollin@apple.com>
1039
1040         Remove extra copy of 100x100-red.tga
1041         https://bugs.webkit.org/show_bug.cgi?id=194371
1042         <rdar://problem/47873465>
1043
1044         Reviewed by Said Abou-Hallawa.
1045
1046         In order to help it pass its tests, Bug 194190 added a second copy of
1047         the file 100x100-red.tga. However, it turns out that this additional
1048         file wasn't actually needed, and that that sole previous copy was
1049         sufficient. At the same time, this second copy -- which was copied to
1050         the same location in the build output as the first copy -- now caused
1051         XCBuild to complain because there were two production rules for the
1052         same output file. Address this by removing the newly-added extra copy.
1053
1054         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1055         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1056
1057 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1058
1059         Deprecate WKBundlePageSetDefersLoading
1060         https://bugs.webkit.org/show_bug.cgi?id=191394
1061
1062         Reviewed by Dean Jackson.
1063
1064         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1065         (WTR::TestRunner::setDefersLoading):
1066
1067 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1068
1069         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1070         https://bugs.webkit.org/show_bug.cgi?id=194391
1071
1072         Reviewed by Antti Koivisto.
1073
1074         * LayoutReloaded/misc/LFC-passing-tests.txt:
1075
1076 2019-02-06  Keith Rollin  <krollin@apple.com>
1077
1078         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1079         https://bugs.webkit.org/show_bug.cgi?id=193975
1080         <rdar://problem/47643306>
1081
1082         Reviewed by Tim Horton.
1083
1084         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1085         the Info.plist file into the bundle. This step is not necessary as the
1086         implicit "bundle up all the build products into a framework" build
1087         phase does this already. Having the Copy Bundle Resources phase do
1088         this causes a conflict under XCBuild, which objects to two build
1089         phases producing the same file (Info.plist). Address this by removing
1090         Info.plist from the Copy Bundle Resources phase.
1091
1092         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1093
1094 2019-02-06  Keith Rollin  <krollin@apple.com>
1095
1096         Really enable the automatic checking and regenerations of .xcfilelists during builds
1097         https://bugs.webkit.org/show_bug.cgi?id=194357
1098         <rdar://problem/47861231>
1099
1100         Reviewed by Chris Dumez.
1101
1102         Bug 194124 was supposed to enable the automatic checking and
1103         regenerating of .xcfilelist files during the build. While related
1104         changes were included in that patch, the change to actually enable the
1105         operation somehow was omitted. This patch actually enables the
1106         operation. The check-xcfilelist.sh scripts now check
1107         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1108         from the checking.
1109
1110         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1111         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1112
1113 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1114
1115         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1116         <https://webkit.org/b/194286>
1117         <rdar://problem/47815558>
1118
1119         Reviewed by Alexey Proskuryakov.
1120
1121         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1122         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1123         WKRetainPtr<> to avoid leaking the WKDataRef.
1124
1125 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1126
1127         Unreviewed, fix a typo
1128
1129         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1130
1131 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1132
1133         [GTK][WPE] force libpsl build to use ICU in jhbuild
1134         https://bugs.webkit.org/show_bug.cgi?id=194288
1135
1136         Reviewed by Carlos Garcia Campos.
1137
1138         * gtk/jhbuild.modules:
1139         Require ICU for libpsl build in jhbuild, like done in WPE.
1140
1141 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1142
1143         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1144         https://bugs.webkit.org/show_bug.cgi?id=194209
1145
1146         Reviewed by Carlos Garcia Campos.
1147
1148         Enhance TestCookieManager to ensure this doesn't happen again.
1149
1150         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1151         (testCookieManagerPersistentStorage):
1152         (beforeAll):
1153
1154 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1155
1156         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1157         https://bugs.webkit.org/show_bug.cgi?id=194324
1158
1159         Reviewed by Andy Estes.
1160
1161         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1162         part of the name is already implicit, since this is in testing code in TestOptions.
1163
1164         * WebKitTestRunner/TestController.cpp:
1165         (WTR::TestController::generateContextConfiguration const):
1166         (WTR::updateTestOptionsFromTestHeader):
1167         * WebKitTestRunner/TestOptions.h:
1168         (WTR::TestOptions::hasSameInitializationOptions const):
1169
1170 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1171
1172         [ews-build] Allow * as platform for builders and workers
1173         https://bugs.webkit.org/show_bug.cgi?id=188533
1174
1175         Reviewed by Lucas Forschler.
1176
1177         * BuildSlaveSupport/ews-build/loadConfig.py:
1178         (checkWorkersAndBuildersForConsistency):
1179
1180 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1181
1182         [ews-build] Add few bots to config.json
1183         https://bugs.webkit.org/show_bug.cgi?id=194304
1184
1185         Reviewed by Lucas Forschler.
1186
1187         * BuildSlaveSupport/ews-build/config.json:
1188
1189 2019-02-05  Keith Rollin  <krollin@apple.com>
1190
1191         Enable the automatic checking and regenerations of .xcfilelists during builds
1192         https://bugs.webkit.org/show_bug.cgi?id=194124
1193         <rdar://problem/47721277>
1194
1195         Reviewed by Tim Horton.
1196
1197         Bug 193790 add a facility for checking -- during build time -- that
1198         any needed .xcfilelist files are up-to-date and for updating them if
1199         they are not. This facility was initially opt-in by setting
1200         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1201         the process seemed robust. Its now time to enable this facility and
1202         make it opt-out. If there is a need to disable this facility, set and
1203         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1204         running `make` or `build-webkit`, or before running Xcode from the
1205         command line.
1206
1207         Additionally, remove the step that generates a list of source files
1208         going into the UnifiedSources build step. It's only necessarily to
1209         specify Sources.txt and SourcesCocoa.txt as inputs.
1210
1211         * Scripts/generate-xcfilelists:
1212
1213 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1214
1215         [GTK][WPE] force libpsl build to use ICU in jhbuild
1216         https://bugs.webkit.org/show_bug.cgi?id=194288
1217
1218         Reviewed by Philippe Normand.
1219
1220         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1221         This can cause build failures if libidn is detected but libunistring is not available.
1222
1223         Make sure that ICU is used for runtime and builtin PSL data.
1224
1225         * gtk/jhbuild.modules:
1226         * wpe/jhbuild.modules:
1227
1228 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1229
1230         [ews-app] Modified timestamp should be updated on updating data
1231         https://bugs.webkit.org/show_bug.cgi?id=194295
1232
1233         Reviewed by Lucas Forschler.
1234
1235         * BuildSlaveSupport/ews-app/ews/models/build.py:
1236         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1237         * BuildSlaveSupport/ews-app/ews/models/step.py:
1238
1239 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1240
1241         Unreviewed, rolling out r240742.
1242
1243         Causes crashes on iOS simulator.
1244
1245         Reverted changeset:
1246
1247         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1248         not focused in a content-editable element"
1249         https://bugs.webkit.org/show_bug.cgi?id=192824
1250         https://trac.webkit.org/changeset/240742
1251
1252 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1253
1254         run-webkit-tests emits message "...running None" when running tests
1255         https://bugs.webkit.org/show_bug.cgi?id=194133
1256         <rdar://problem/47724738>
1257
1258         Reviewed by Lucas Forschler.
1259
1260         * Scripts/webkitpy/xcode/device_type.py:
1261         (DeviceType.__str__): Use both version mapping tables and use just the variant
1262         name if no version name is available.
1263         * Scripts/webkitpy/xcode/device_type_unittest.py:
1264         (DeviceTypeTest):
1265         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1266         an associated named.
1267
1268 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1269
1270         [WPE] require python3-setuptools for meson build in jhbuild
1271         https://bugs.webkit.org/show_bug.cgi?id=194287
1272
1273         Reviewed by Philippe Normand.
1274
1275         python3-setuptools is needed to build meson in jhbuild.
1276         It is already required by the GTK port.
1277
1278         * wpe/install-dependencies:
1279
1280 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1281
1282         [ews-app] Add method to save BuilderMapping to database
1283         https://bugs.webkit.org/show_bug.cgi?id=194264
1284
1285         Reviewed by Lucas Forschler.
1286
1287         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1288         (BuilderMapping.__str__):
1289         (BuilderMapping):
1290         (BuilderMapping.save_mapping):
1291         (BuilderMapping.update_mapping):
1292         (BuilderMapping.get_existing_mapping):
1293         (BuilderMapping.is_valid_mapping):
1294
1295 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1296
1297         [ews-app] Add timestamp fields for BuilderMappings
1298         https://bugs.webkit.org/show_bug.cgi?id=194266
1299
1300         Reviewed by Lucas Forschler.
1301
1302         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1303         (BuilderMapping):
1304
1305 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1306
1307         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1308         https://bugs.webkit.org/show_bug.cgi?id=174816
1309
1310         Reviewed by Michael Catanzaro.
1311
1312         Add tests for webkit_uri_for_display().
1313
1314         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1315         (testURIForDisplayUnaffected):
1316         (testURIForDisplayAffected):
1317         (beforeAll):
1318         (afterAll):
1319         * TestWebKitAPI/glib/CMakeLists.txt:
1320
1321 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1322
1323         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1324         https://bugs.webkit.org/show_bug.cgi?id=194158
1325         <rdar://problem/47737268>
1326
1327         Rubber-stamped by Aakash Jain.
1328
1329         * Scripts/webkitpy/port/device_port.py:
1330         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1331
1332 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1333
1334         [CG] Enable setAdditionalSupportedImageTypes for WK1
1335         https://bugs.webkit.org/show_bug.cgi?id=194190
1336
1337         Reviewed by Tim Horton.
1338
1339         Add a test similar to the one under WebKit Cocoa but make it create a
1340         WebView instead of a WKWebView.
1341
1342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1343         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1344         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1345         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1346         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1347         (TestWebKitAPI::runTest):
1348         (TestWebKitAPI::TEST):
1349
1350 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1351
1352         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1353         https://bugs.webkit.org/show_bug.cgi?id=194168
1354
1355         Reviewed by Simon Fraser.
1356
1357         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1358
1359         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1360         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1361         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1362         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1363         (TEST):
1364         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1365         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1366
1367 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1368
1369         REGRESSION (r237269): webkit-patch what-broke is broken 
1370         https://bugs.webkit.org/show_bug.cgi?id=193025
1371
1372         Reviewed by Aakash Jain.
1373
1374         * Scripts/webkitpy/common/host.py:
1375         (Host.buildbot):
1376         (Host.bugzilla): Renamed to 'buildbot'.
1377
1378 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1379
1380         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1381         https://bugs.webkit.org/show_bug.cgi?id=194207
1382
1383         Reviewed by Tim Horton.
1384
1385         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1386         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1387         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1388         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1389         start and delete forwards to remove the original attachment.
1390
1391         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1392         (TestWebKitAPI::TEST):
1393
1394 2019-02-04  Youenn Fablet  <youenn@apple.com>
1395
1396         Capture state should be managed consistently when doing process swapping
1397         https://bugs.webkit.org/show_bug.cgi?id=194122
1398         <rdar://problem/47609293>
1399
1400         Reviewed by Eric Carlson.
1401
1402         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1403         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1404         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1405         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1406         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1407         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1408         (WTR::TestRunner::isDoingMediaCapture const):
1409         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1410         * WebKitTestRunner/TestController.cpp:
1411         (WTR::TestController::isDoingMediaCapture const):
1412         * WebKitTestRunner/TestController.h:
1413         * WebKitTestRunner/TestInvocation.cpp:
1414         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1415         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1416         (WTR::TestController::isDoingMediaCapture const):
1417
1418 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1419
1420         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1421         https://bugs.webkit.org/show_bug.cgi?id=194142
1422
1423         Reviewed by Ross Kirsling.
1424
1425         There three 'separator' variables in TestController.cpp. Renamed
1426         it 'pathSeparator', and unified them.
1427
1428         * WebKitTestRunner/TestController.cpp:
1429         (WTR::TestController::generateContextConfiguration const):
1430         (WTR::createTestURL):
1431         (WTR::TestController::platformAdjustContext):
1432
1433 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1434
1435         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1436         https://bugs.webkit.org/show_bug.cgi?id=194198
1437
1438         Reviewed by Antti Koivisto.
1439
1440         No need to set the banner heights on navigation now, since Page stores them.
1441
1442         * MiniBrowser/mac/WK2BrowserWindowController.m:
1443         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1444
1445 2019-02-03  John Wilander  <wilander@apple.com>
1446
1447         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1448         https://bugs.webkit.org/show_bug.cgi?id=194104
1449         <rdar://problem/47649991>
1450
1451         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1452
1453         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1454         (TestWebKitAPI::TEST):
1455             Changed numeric types from unsigned short to uint32_t.
1456
1457 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1458
1459         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1460         <https://webkit.org/b/194178>
1461         <rdar://problem/47753473>
1462
1463         Reviewed by Alexey Proskuryakov.
1464
1465         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1466         (WTR::uninstallFakeHelvetica): Pass nullptr into
1467         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1468
1469 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1470
1471         [LFC] Initialize ICB's style with fixed width/height.
1472         https://bugs.webkit.org/show_bug.cgi?id=194188
1473
1474         Reviewed by Antti Koivisto.
1475
1476         * LayoutReloaded/misc/LFC-passing-tests.txt:
1477
1478 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1479
1480         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1481         https://bugs.webkit.org/show_bug.cgi?id=194185
1482
1483         Reviewed by Antti Koivisto.
1484
1485         * LayoutReloaded/misc/LFC-passing-tests.txt:
1486
1487 2018-12-16  Darin Adler  <darin@apple.com>
1488
1489         Convert additional String::format clients to alternative approaches
1490         https://bugs.webkit.org/show_bug.cgi?id=192746
1491
1492         Reviewed by Alexey Proskuryakov.
1493
1494         * WebKitTestRunner/TestController.cpp:
1495         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1496         as an intermediate in code that ultimately constructs a WTF::String.
1497         (WTR::userMediaOriginHash): Use makeString.
1498         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1499         (WTR::TestController::didPerformClientRedirect): Ditto.
1500         (WTR::TestController::didPerformServerRedirect): Ditto.
1501         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1502
1503 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1504
1505         [ews-build] Add unit test to verify builder keys
1506         https://bugs.webkit.org/show_bug.cgi?id=194152
1507
1508         Reviewed by Lucas Forschler.
1509
1510         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1511         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1512
1513 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1514
1515         [LFC] Expand tests coverage (12 new tests -> 787)
1516
1517         Unreviewed test gardening.
1518
1519         * LayoutReloaded/misc/LFC-passing-tests.txt:
1520
1521 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1522
1523         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1524         https://bugs.webkit.org/show_bug.cgi?id=194163
1525
1526         Reviewed by Simon Fraser.
1527
1528         775
1529
1530         * LayoutReloaded/misc/LFC-passing-tests.txt:
1531
1532 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1533
1534         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1535         https://bugs.webkit.org/show_bug.cgi?id=194140
1536         <rdar://problem/47728098>
1537
1538         Reviewed by Tim Horton.
1539
1540         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1541         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1542         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1543
1544         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1545         test to induce an IPC deadlock when presenting a modal alert during touch start.
1546
1547         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1548         * WebKitTestRunner/TestController.cpp:
1549         (WTR::runJavaScriptAlert):
1550
1551         Add a client callback function for running JavaScript alerts.
1552
1553         (WTR::TestController::createOtherPage):
1554         (WTR::TestController::generateContextConfiguration const):
1555
1556         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1557         the fix in this patch.
1558
1559         (WTR::TestController::createWebViewWithOptions):
1560
1561         Plumb TestOptions to generateContextConfiguration.
1562
1563         (WTR::TestController::resetPreferencesToConsistentValues):
1564         (WTR::TestController::resetStateToConsistentValues):
1565         (WTR::updateTestOptionsFromTestHeader):
1566         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1567         (WTR::TestController::handleJavaScriptAlert):
1568         * WebKitTestRunner/TestController.h:
1569         * WebKitTestRunner/TestInvocation.cpp:
1570         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1571         * WebKitTestRunner/TestOptions.h:
1572         (WTR::TestOptions::hasSameInitializationOptions const):
1573
1574 2019-02-01  Chris Dumez  <cdumez@apple.com>
1575
1576         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1577         https://bugs.webkit.org/show_bug.cgi?id=193740
1578         <rdar://problem/47527267>
1579
1580         Reviewed by Alex Christensen.
1581
1582         Add API test coverage.
1583
1584         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1585
1586 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1587
1588         [ews-app] Add display name field to BuilderMapping model
1589         https://bugs.webkit.org/show_bug.cgi?id=194153
1590
1591         Reviewed by Lucas Forschler.
1592
1593         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1594         (BuilderMapping):
1595
1596 2019-02-01  Youenn Fablet  <youenn@apple.com>
1597
1598         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1599         https://bugs.webkit.org/show_bug.cgi?id=194155
1600
1601         Reviewed by Eric Carlson.
1602
1603         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1604         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1605         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1606
1607 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1608
1609         [LFC] Adjust replaced element's intrinsic ratio
1610         https://bugs.webkit.org/show_bug.cgi?id=194154
1611
1612         Reviewed by Antti Koivisto.
1613
1614         761
1615
1616         * LayoutReloaded/misc/LFC-passing-tests.txt:
1617
1618 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1619
1620         [WPE] Show test results in minibrowser
1621         https://bugs.webkit.org/show_bug.cgi?id=194150
1622
1623         Reviewed by Žan Doberšek.
1624
1625         * Scripts/webkitpy/port/wpe.py:
1626         (WPEPort.show_results_html_file):
1627
1628 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1629
1630         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1631         https://bugs.webkit.org/show_bug.cgi?id=194151
1632
1633         Reviewed by Žan Doberšek.
1634
1635         ALT + <- go back
1636         ALT + -> go forward
1637
1638         * MiniBrowser/wpe/main.cpp:
1639         (main):
1640
1641 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1642
1643         [LFC] Set intrinsic size on Layout::Replaced
1644         https://bugs.webkit.org/show_bug.cgi?id=194139
1645
1646         Reviewed by Antti Koivisto.
1647
1648         744
1649
1650         * LayoutReloaded/misc/LFC-passing-tests.txt:
1651
1652 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1653
1654         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1655         https://bugs.webkit.org/show_bug.cgi?id=194146
1656
1657         Reviewed by Xabier Rodriguez-Calvar.
1658
1659         It allows to open relative paths.
1660
1661         * MiniBrowser/wpe/main.cpp:
1662         (main):
1663
1664 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1665
1666         Update flakiness dashboard configuration after recent queue changes
1667         https://bugs.webkit.org/show_bug.cgi?id=194127
1668
1669         Rubber-stamped by Aakash Jain.
1670
1671         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1672
1673         * TestResultServer/static-dashboards/builders.jsonp:
1674
1675 2019-01-31  Youenn Fablet  <youenn@apple.com>
1676
1677         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1678         https://bugs.webkit.org/show_bug.cgi?id=194106
1679         <rdar://problem/47676333>
1680
1681         Reviewed by Ryosuke Niwa.
1682
1683         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1684         (TestWebKitAPI::didFinishNavigation):
1685         (TestWebKitAPI::TEST):
1686         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1687
1688 2019-01-31  Chris Dumez  <cdumez@apple.com>
1689
1690         Page zoom level is lost after a process swap or a crash
1691         https://bugs.webkit.org/show_bug.cgi?id=194105
1692         <rdar://problem/47610781>
1693
1694         Reviewed by Alex Christensen.
1695
1696         Add API test coverage.
1697
1698         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1699         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1700
1701 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1702
1703         Revert r238819 which is unneeded and caused a performance regression.
1704         https://bugs.webkit.org/show_bug.cgi?id=192272
1705         <rdar://problem/46664625>
1706
1707         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1708         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1709         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1710
1711 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1712
1713         Formalize WebKitAdditions mechanism of LoadOptimizer
1714         https://bugs.webkit.org/show_bug.cgi?id=193886
1715         <rdar://problem/47696809>
1716
1717         Reviewed by Brent Fulgham.
1718
1719         * MiniBrowser/MiniBrowser.entitlements:
1720         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1721
1722 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1723
1724         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1725         https://bugs.webkit.org/show_bug.cgi?id=194090
1726
1727         Reviewed by Antti Koivisto.
1728
1729         * LayoutReloaded/misc/LFC-passing-tests.txt:
1730
1731 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1732
1733         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1734         https://bugs.webkit.org/show_bug.cgi?id=194074
1735
1736         Reviewed by Antti Koivisto.
1737
1738         * LayoutReloaded/misc/LFC-passing-tests.txt:
1739
1740 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1741
1742         [LFC][BFC] Add support for block level replaced box.
1743         https://bugs.webkit.org/show_bug.cgi?id=194071
1744
1745         Reviewed by Antti Koivisto.
1746
1747         * LayoutReloaded/misc/LFC-passing-tests.txt:
1748
1749 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1750
1751         Fix WebKitTestRunner's testPath with Windows full paths
1752         https://bugs.webkit.org/show_bug.cgi?id=194012
1753
1754         Reviewed by Alex Christensen.
1755
1756         updateTestOptionsFromTestHeader failed to open test files because
1757         testPath returned wrong file paths. It returned a path "/C:/..."
1758         if a URL "file:///C:/..." was given.
1759
1760         * WebKitTestRunner/TestController.cpp:
1761         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1762
1763 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1764
1765         [WPE] Bump font related dependencies to match the GTK+ port
1766         https://bugs.webkit.org/show_bug.cgi?id=194017
1767
1768         Reviewed by Žan Doberšek.
1769
1770         * wpe/jhbuild.modules:
1771         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1772         * wpe/patches/icudata-stdlibs.patch: Added.
1773
1774 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1775
1776         Enable swipe tests on iOS
1777         https://bugs.webkit.org/show_bug.cgi?id=194076
1778
1779         Reviewed by Geoffrey Garen.
1780
1781         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1782         it causes a debug assertion failure in runUIScript.
1783
1784         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1785         (WTR::UIScriptController::beginBackSwipe):
1786         (WTR::UIScriptController::completeBackSwipe):
1787
1788 2019-01-30  Keith Rollin  <krollin@apple.com>
1789
1790         Use correct printf format specifier
1791         https://bugs.webkit.org/show_bug.cgi?id=194062
1792         <rdar://problem/47686167>
1793
1794         Reviewed by Alexey Proskuryakov.
1795
1796         LayoutTestSpellChecker.mm is trying to format a variable of type
1797         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1798         actually an unsigned long long. Fix this by formatting with %llu.
1799
1800         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1801         (-[LayoutTestTextCheckingResult description]):
1802
1803 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1804
1805         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1806         https://bugs.webkit.org/show_bug.cgi?id=193979
1807
1808         Reviewed by Wenson Hsieh.
1809
1810         Fix the test for iOS. Make the test work with iOS UA string.
1811
1812         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1813
1814 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1815
1816         Replace High Sierra LLINT CLoop bot due to hardware failure
1817         https://bugs.webkit.org/show_bug.cgi?id=194066
1818
1819         Reviewed by Aakash Jain.
1820
1821         * BuildSlaveSupport/build.webkit.org-config/config.json:
1822
1823 2019-01-30  Keith Rollin  <krollin@apple.com>
1824
1825         [NSDragItem init] is unavailable
1826         https://bugs.webkit.org/show_bug.cgi?id=194059
1827         <rdar://problem/47685715>
1828
1829         Reviewed by Wenson Hsieh.
1830
1831         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1832         DumpRenderTree and TestWebKitAPI, which both try to create an
1833         NSDragItem in a manner that invokes this method. Address this by using
1834         -initWithPasteboardWriter instead.
1835
1836         Note that the parameter passed to initWithPasteboardWriter is likely
1837         incorrect. In both cases, the object passed does not conform to
1838         NSPasteboardWriting. However, with this fix, we're no worse off than
1839         before, and can now perform builds with newer compilers and SDKs until
1840         a real fix can be crafted. That work is tracked in
1841         https://bugs.webkit.org/show_bug.cgi?id=194060
1842
1843         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1844         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1845         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1846         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1847
1848 2019-01-30  Daniel Bates  <dabates@apple.com>
1849
1850         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1851         https://bugs.webkit.org/show_bug.cgi?id=192824
1852         <rdar://problem/47100332>
1853
1854         Reviewed by Wenson Hsieh.
1855
1856         Fix a bug where the wrong usage code was used for F13 thru F24.
1857
1858         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1859         (keyCodeForDOMFunctionKey):
1860
1861 2019-01-30  Chris Dumez  <cdumez@apple.com>
1862
1863         Regression(PSON) Load hang can occur on history navigation
1864         https://bugs.webkit.org/show_bug.cgi?id=194030
1865         <rdar://problem/47656939>
1866
1867         Reviewed by Antti Koivisto.
1868
1869         Add API test coverage.
1870
1871         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1872
1873 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1874
1875         [LFC] Expand tests coverage.
1876
1877         Unreviewed test gardening.
1878
1879         * LayoutReloaded/misc/LFC-passing-tests.txt:
1880
1881 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1882
1883         [Flatpak] Add openjpeg support
1884         https://bugs.webkit.org/show_bug.cgi?id=194019
1885
1886         Reviewed by Michael Catanzaro.
1887
1888         * flatpak/org.webkit.CommonModules.yaml:
1889
1890 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1891
1892         Unreviewed, rolling out r240708.
1893         https://bugs.webkit.org/show_bug.cgi?id=194022
1894
1895         It broke WPE build (Requested by KaL on #webkit).
1896
1897         Reverted changeset:
1898
1899         "[WPE] Bump font related dependencies to match the GTK+ port"
1900         https://bugs.webkit.org/show_bug.cgi?id=194017
1901         https://trac.webkit.org/changeset/240708
1902
1903 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1904
1905         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1906         https://bugs.webkit.org/show_bug.cgi?id=194001
1907
1908         Reviewed by Antti Koivisto.
1909
1910         * LayoutReloaded/misc/LFC-passing-tests.txt:
1911
1912 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1913
1914         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1915         https://bugs.webkit.org/show_bug.cgi?id=194020
1916
1917         Reviewed by Antti Koivisto.
1918
1919         * LayoutReloaded/misc/LFC-passing-tests.txt:
1920
1921 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1922
1923         AX: Support color well on iOS
1924         https://bugs.webkit.org/show_bug.cgi?id=194010
1925
1926         Reviewed by Joanmarie Diggs.
1927
1928         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1929         (WTR::AccessibilityUIElement::stringAttributeValue):
1930
1931 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1932
1933         [WPE] Bump font related dependencies to match the GTK+ port
1934         https://bugs.webkit.org/show_bug.cgi?id=194017
1935
1936         Reviewed by Žan Doberšek.
1937
1938         * wpe/jhbuild.modules:
1939         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1940         * wpe/patches/icudata-stdlibs.patch: Added.
1941
1942 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1943
1944         [Mac] Update window scale API usage
1945         https://bugs.webkit.org/show_bug.cgi?id=193991
1946         rdar://problem/47614795
1947
1948         Reviewed by Tim Horton.
1949
1950         * DumpRenderTree/mac/DumpRenderTree.mm:
1951         (changeWindowScaleIfNeeded):
1952         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1953         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1954         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1955
1956 2019-01-29  Chris Dumez  <cdumez@apple.com>
1957
1958         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1959         https://bugs.webkit.org/show_bug.cgi?id=193977
1960         <rdar://problem/47643716>
1961
1962         Reviewed by Geoff Garen.
1963
1964         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1965         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1966         to the previous provisional committing *before* we make the last load. 
1967
1968         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1969
1970 2019-01-29  Youenn Fablet  <youenn@apple.com>
1971
1972         Adopt new SPI to evaluate server certificate trust
1973         https://bugs.webkit.org/show_bug.cgi?id=193355
1974
1975         Reviewed by Alex Christensen.
1976
1977         Add infrastructure to handle HTTPS server trust evaluation testing.
1978
1979         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1980         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1981         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1982         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1983         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1984         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1985         * WebKitTestRunner/TestController.cpp:
1986         (WTR::TestController::resetPreferencesToConsistentValues):
1987         (WTR::TestController::didReceiveAuthenticationChallenge):
1988         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1989         * WebKitTestRunner/TestController.h:
1990         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1991         * WebKitTestRunner/TestInvocation.cpp:
1992         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1993         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1994         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1995
1996 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1997
1998         [ews-build] Add build step to print bot Configuration
1999         https://bugs.webkit.org/show_bug.cgi?id=193887
2000
2001         Reviewed by Lucas Forschler.
2002
2003         * BuildSlaveSupport/ews-build/steps.py:
2004         (PrintConfiguration): Build step to print configuration.
2005         * BuildSlaveSupport/ews-build/factories.py:
2006
2007 2019-01-29  Chris Dumez  <cdumez@apple.com>
2008
2009         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2010         https://bugs.webkit.org/show_bug.cgi?id=193967
2011         <rdar://problem/47635348>
2012
2013         Reviewed by Alex Christensen.
2014
2015         Add API test coverage.
2016
2017         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2018         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2019
2020 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2021
2022         [ews-app] Handle incoming results data
2023         https://bugs.webkit.org/show_bug.cgi?id=193973
2024
2025         Reviewed by Lucas Forschler.
2026
2027         * BuildSlaveSupport/ews-app/ews/views/results.py:
2028
2029 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2030
2031         [ews-app] Make the results url generic
2032         https://bugs.webkit.org/show_bug.cgi?id=193928
2033
2034         Reviewed by Lucas Forschler.
2035
2036         * BuildSlaveSupport/ews-app/ews/urls.py:
2037
2038 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2039
2040         [ews-build] Configure buildbot to send events to ews-app
2041         https://bugs.webkit.org/show_bug.cgi?id=193968
2042
2043         Reviewed by Lucas Forschler.
2044
2045         * BuildSlaveSupport/ews-build/events.py: Added.
2046         * BuildSlaveSupport/ews-build/master.cfg:
2047
2048 2019-01-29  Keith Rollin  <krollin@apple.com>
2049
2050         Add .xcfilelists to Run Script build phases
2051         https://bugs.webkit.org/show_bug.cgi?id=193792
2052         <rdar://problem/47201785>
2053
2054         Reviewed by Alex Christensen.
2055
2056         As part of supporting XCBuild, update the necessary Run Script build
2057         phases in their Xcode projects to refer to their associated
2058         .xcfilelist files.
2059
2060         Note that the addition of these files bumps the Xcode project version
2061         number to something that's Xcode 10 compatible. This change means that
2062         older versions of the Xcode IDE can't read these projects. Nor can it
2063         fully load workspaces that refer to these projects (the updated
2064         projects are shown as non-expandable placeholders). `xcodebuild` can
2065         still build these projects; it's just that the IDE can't open them.
2066
2067         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2068         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2069
2070 2019-01-29  John Wilander  <wilander@apple.com>
2071
2072         Add data abstraction and validation for Ad Click Attribution
2073         https://bugs.webkit.org/show_bug.cgi?id=193916
2074         <rdar://problem/47603481>
2075
2076         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2077
2078         Ad click attribution has two steps. First, the storage of an ad
2079         campaign ID for a click that takes the user to a destination
2080         site. Second, a conversion on the destination site that can be
2081         attributed to the ad click.
2082
2083         This patch adds a class that represents a request for ad click
2084         attribution. Validation makes sure that the bits of entropy
2085         reported through this mechanism is limited.
2086
2087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2088         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2089         (TestWebKitAPI::TEST):
2090
2091 2019-01-29  Chris Dumez  <cdumez@apple.com>
2092
2093         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2094         https://bugs.webkit.org/show_bug.cgi?id=193932
2095         <rdar://problem/47598947>
2096
2097         Reviewed by Brady Eidson.
2098
2099         Add API test coverage.
2100
2101         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2102
2103 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2104
2105         Adding new passing LFC tests.
2106
2107         Unreviewed test gardening.
2108
2109         * LayoutReloaded/misc/LFC-passing-tests.txt:
2110
2111 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2112
2113         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2114         https://bugs.webkit.org/show_bug.cgi?id=193964
2115
2116         Reviewed by Antti Koivisto.
2117
2118         * LayoutReloaded/misc/LFC-passing-tests.txt:
2119
2120 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2121
2122         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2123         https://bugs.webkit.org/show_bug.cgi?id=193954
2124
2125         Reviewed by Antti Koivisto.
2126
2127         * LayoutReloaded/misc/LFC-passing-tests.txt:
2128
2129 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2130
2131         WebDriver: add support for running subtests
2132         https://bugs.webkit.org/show_bug.cgi?id=193904
2133
2134         Reviewed by Michael Catanzaro.
2135
2136         pytest already supports it by passing test.py::subtest, so we can do the same.
2137
2138         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2139         (get_item_name): Made this global.
2140         (CollectRecorder.__init__): Receive the parameter to ignore.
2141         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2142         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2143         (collect): Add parameter to ignore.
2144         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2145         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2146         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2147         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2148         (WebDriverTestRunnerSelenium.run): Ditto.
2149         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2150         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2151         (WebDriverTestRunnerW3C.run): Ditto.
2152
2153 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2154
2155         User agent string override for navigator.userAgent should be site specific quirks
2156         https://bugs.webkit.org/show_bug.cgi?id=193950
2157
2158         Reviewed by Brent Fulgham.
2159
2160         Updated per the _WKWebsitePolicies rename.
2161
2162         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2163         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2164
2165 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2166
2167         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2168         https://bugs.webkit.org/show_bug.cgi?id=193941
2169
2170         Reviewed by Alex Christensen.
2171
2172         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2173         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2174         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2175         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2176         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2177         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2178         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2179         * TestWebKitAPI/Tests/WTF/Time.cpp:
2180         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2181         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2182         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2183         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2184
2185 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2186
2187         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2188
2189         * Scripts/webkitpy/common/config/contributors.json:
2190
2191 2019-01-28  Andy Estes  <aestes@apple.com>
2192
2193         [watchOS] Enable Parental Controls content filtering
2194         https://bugs.webkit.org/show_bug.cgi?id=193939
2195         <rdar://problem/46641912>
2196
2197         Reviewed by Ryosuke Niwa.
2198
2199         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2200
2201 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2202
2203         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2204         <https://webkit.org/b/193884>
2205
2206         Reviewed by Jiewen Tan.
2207
2208         * Scripts/webkitpy/style/checkers/cpp.py:
2209         (check_language): Add LocalAuthentication to
2210         `frameworks_with_soft_links`.
2211
2212 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2213
2214         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2215         https://bugs.webkit.org/show_bug.cgi?id=193891
2216
2217         Reviewed by Ross Kirsling.
2218
2219         There were three problems in window sizes of WebView and the host window.
2220         1. The sizes of pixel image output were incorrect.
2221         2. The host window is going to appear after window.resize was invoked.
2222         3. window.resize resized only the host window, not WebView.
2223
2224         This change solves them with a following approach.
2225         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2226         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2227            as well as DumpRenderTree in order to match the client area and the window area.
2228         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2229         d. PlatformWebView::setWindowFrame changes both window sizes.
2230         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2231
2232         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2233         (WTR::PlatformWebView::PlatformWebView): Create the host window
2234         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2235         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2236         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2237
2238 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2239
2240         [ews-app] Add method to save Step data to database
2241         https://bugs.webkit.org/show_bug.cgi?id=193890
2242
2243         Reviewed by Lucas Forschler.
2244
2245         * BuildSlaveSupport/ews-app/ews/models/step.py:
2246         (Step.save_step): Method to save step data.
2247         (Step.update_step): Method to update step data.
2248         (Step.get_existing_step): Method to fetch existing step from database.
2249         (Step.is_valid_result): Method to validate valid step result.
2250
2251 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2252
2253         [ews-app] Add method to save Build data to database
2254         https://bugs.webkit.org/show_bug.cgi?id=193735
2255
2256         Reviewed by Lucas Forschler.
2257
2258         * BuildSlaveSupport/ews-app/ews/models/build.py:
2259         (Build.save_build): Method to save build information to database.
2260         (Build.get_existing_build): Method to fetch existing build from database.
2261         (Build.is_valid_result): Method to validate build result.
2262         * BuildSlaveSupport/ews-app/ews/common/util.py:
2263         (is_valid_int_id): Method to validate valid id.
2264
2265 2019-01-28  Chris Dumez  <cdumez@apple.com>
2266
2267         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2268         https://bugs.webkit.org/show_bug.cgi?id=193915
2269         <rdar://problem/47560907>
2270
2271         Reviewed by Alex Christensen.
2272
2273         Add API test coverage.
2274
2275         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2276
2277 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2278
2279         [ews-app] Rename id variables
2280         https://bugs.webkit.org/show_bug.cgi?id=193883
2281
2282         Reviewed by Lucas Forschler.
2283
2284         * BuildSlaveSupport/ews-app/ews/models/build.py:
2285         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2286         * BuildSlaveSupport/ews-app/ews/models/step.py:
2287         * BuildSlaveSupport/ews-app/ews/urls.py:
2288         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2289         * BuildSlaveSupport/ews-app/ews/views/results.py:
2290         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2291
2292 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2293
2294         [ews-app] Allow certain fields to be empty
2295         https://bugs.webkit.org/show_bug.cgi?id=193892
2296
2297         Reviewed by Lucas Forschler.
2298
2299         * BuildSlaveSupport/ews-app/ews/models/build.py:
2300         * BuildSlaveSupport/ews-app/ews/models/step.py:
2301
2302 2019-01-28  Rob Buis  <rbuis@igalia.com>
2303
2304         Update MIME type parser
2305         https://bugs.webkit.org/show_bug.cgi?id=180526
2306
2307         Reviewed by Frédéric Wang.
2308
2309         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2310         (TestWebKitAPI::TEST):
2311
2312 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2313
2314         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2315         https://bugs.webkit.org/show_bug.cgi?id=193896
2316
2317         Reviewed by Antti Koivisto.
2318
2319         * LayoutReloaded/misc/LFC-passing-tests.txt:
2320
2321 2018-12-15  Darin Adler  <darin@apple.com>
2322
2323         Replace many uses of String::format with more type-safe alternatives
2324         https://bugs.webkit.org/show_bug.cgi?id=192742
2325
2326         Reviewed by Mark Lam.
2327
2328         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2329         (WTR::cacheTestRunnerCallback): Use makeString.
2330         * WebKitTestRunner/TestController.cpp:
2331         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2332         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2333
2334 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2335
2336         Use a load optimizer for some sites
2337         https://bugs.webkit.org/show_bug.cgi?id=193881
2338         <rdar://problem/46325455>
2339
2340         Reviewed by Brent Fulgham.
2341
2342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2343         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2344
2345 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2346
2347         AX: Introduce a static accessibility tree
2348         https://bugs.webkit.org/show_bug.cgi?id=193348
2349         <rdar://problem/47203295>
2350
2351         Reviewed by Ryosuke Niwa.
2352
2353         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2354
2355 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2356
2357         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2358         https://bugs.webkit.org/show_bug.cgi?id=193867
2359
2360         Reviewed by Antti Koivisto.
2361
2362         * LayoutReloaded/misc/LFC-passing-tests.txt:
2363
2364 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2365
2366         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2367         https://bugs.webkit.org/show_bug.cgi?id=193865
2368
2369         Reviewed by Antti Koivisto.
2370
2371         * LayoutReloaded/misc/LFC-passing-tests.txt:
2372
2373 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2374
2375         Need a mechanism to override navigator.userAgent
2376         https://bugs.webkit.org/show_bug.cgi?id=193762
2377         <rdar://problem/47504939>
2378
2379         Reviewed by Brent Fulgham.
2380
2381         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2382
2383         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2384         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2385         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2386
2387 2019-01-25  Dean Jackson  <dino@apple.com>
2388
2389         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2390         https://bugs.webkit.org/show_bug.cgi?id=193831
2391         <rdar://problem/47399263>
2392
2393         Reviewed by Chris Dumez.
2394
2395         Two new tests that exercise cross-origin and same-origin System
2396         Previews.
2397
2398         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2399
2400 2019-01-25  Keith Rollin  <krollin@apple.com>
2401
2402         Update Xcode projects with "Check .xcfilelists" build phase
2403         https://bugs.webkit.org/show_bug.cgi?id=193790
2404         <rdar://problem/47201374>
2405
2406         Reviewed by Alex Christensen.
2407
2408         Support for XCBuild includes specifying inputs and outputs to various
2409         Run Script build phases. These inputs and outputs are specified as
2410         .xcfilelist files. Once created, these .xcfilelist files need to be
2411         kept up-to-date. In order to check that they are up-to-date or not,
2412         add an Xcode build step that invokes an external script that performs
2413         the checking. If the .xcfilelists are found to be out-of-date, update
2414         them, halt the build, and instruct the developer to restart the build
2415         with up-to-date files.
2416
2417         At this time, the checking and regenerating is performed only if the
2418         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2419         who want to use this facility can set this variable and test out the
2420         checking/regenerating. Once it seems like there are no egregious
2421         issues that upset a developer's workflow, we'll unconditionally enable
2422         this facility.
2423
2424         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2425         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2426         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2427         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2428
2429 2019-01-25  Keith Rollin  <krollin@apple.com>
2430
2431         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2432         https://bugs.webkit.org/show_bug.cgi?id=193781
2433         <rdar://problem/47201153>
2434
2435         Reviewed by Alex Christensen.
2436
2437         Part of generating the .xcfilelists used as part of adopting XCBuild
2438         includes running `make DerivedSources.make` from a standalone script.
2439         It’s important for this invocation to have the same environment as
2440         when the actual build invokes `make DerivedSources.make`. If the
2441         environments are different, then the two invocations will provide
2442         different results. In order to get the same environment in the
2443         standalone script, have the script launch xcodebuild targeting the
2444         "Apply Configuration to XCFileLists" build target, which will then
2445         re-invoke our standalone script. The script is now running again, this
2446         time in an environment with all workspace, project, target, xcconfig
2447         and other environment variables established.
2448
2449         The "Apply Configuration to XCFileLists" build target accomplishes
2450         this task via a small embedded shell script that consists only of:
2451
2452             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2453
2454         The process that invokes "Apply Configuration to XCFileLists" first
2455         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2456         evaluated and exports it into the shell environment. When xcodebuild
2457         is invoked, it inherits the value of this variable and can `eval` the
2458         contents of that variable. Our external standalone script can then set
2459         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2460         of command-line parameters needed to restart itself in the appropriate
2461         state.
2462
2463         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2464         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2465
2466 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2467
2468         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2469         https://bugs.webkit.org/show_bug.cgi?id=193802
2470         <rdar://problem/46010580>
2471
2472         Reviewed by Andy Estes.
2473
2474         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2475         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2476         (TEST):
2477
2478 2019-01-25  Daniel Bates  <dabates@apple.com>
2479
2480         [iOS] uiController.keyDown() does not translate Control modified key
2481         https://bugs.webkit.org/show_bug.cgi?id=192898
2482
2483         Reviewed by Wenson Hsieh.
2484
2485         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2486         key translation, as applicable. Among other cases, key translation occurs when performing
2487         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2488         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2489         human pressing down and releasing key(s) using a hardware keyboard.
2490
2491         * WebKitTestRunner/ios/HIDEventGenerator.h:
2492         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2493         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2494
2495         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2496         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2497         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2498         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2499         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2500         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2501         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2502         (-[HIDEventGenerator longPress:completionBlock:]):
2503         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2504         Update code for above renaming.
2505
2506         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2507         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2508
2509         (-[HIDEventGenerator keyDown:]): Added.
2510         (-[HIDEventGenerator keyUp:]): Added.
2511         (-[HIDEventGenerator keyPress:completionBlock:]):
2512         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2513         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2514         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2515         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2516         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2517         (WTR::parseModifier): Deleted.
2518
2519 2019-01-25  Keith Rollin  <krollin@apple.com>
2520
2521         Complete the implementation of generate-xcfilelists
2522         https://bugs.webkit.org/show_bug.cgi?id=193782
2523
2524         Reviewed by Alex Christensen.
2525
2526         A preliminary version of generate-xcfilelists was added in r238008.
2527         This patch updates that script in order to:
2528
2529         - Support checking of .xcfilelists
2530         - Perform better execution of `make DerivedSources.make` by
2531           relaunching generate-xcfilelists under xcodebuild
2532         - Support incremental generation and checking of .xcfilelists
2533         - Support supplementary .xcfilelists files from WebKitAdditions
2534         - Support being wrapped by parallel version of generate-xcfilelists in
2535           Internal that adds support for (re)generating WebKit projects in
2536           that repo.
2537         - Support builds that have been performed in WebKitBuild as well as
2538           ~/Library/Developer/code/DerivedData
2539         - Increase robustness and debugging facilities.
2540
2541         * Scripts/generate-xcfilelists:
2542
2543 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2544
2545         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2546         https://bugs.webkit.org/show_bug.cgi?id=193297
2547         <rdar://problem/47158841>
2548
2549         Unreviewed test case fix.
2550
2551         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2552         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2553
2554         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2555         (TEST):
2556
2557 2019-01-25  Keith Rollin  <krollin@apple.com>
2558
2559         Update existing .xcfilelists
2560         https://bugs.webkit.org/show_bug.cgi?id=193791
2561         <rdar://problem/47201706>
2562
2563         Reviewed by Alex Christensen.
2564
2565         Many .xcfilelist files were added in r238824 in order to support
2566         XCBuild. Update these with recent changes to the set of build files
2567         and with the current generate-xcfilelist script.
2568
2569         * DumpRenderTree/DerivedSources-input.xcfilelist:
2570         * DumpRenderTree/DerivedSources-output.xcfilelist:
2571         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2572         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2573
2574 2019-01-25  Keith Rollin  <krollin@apple.com>
2575
2576         Fix missing dependencies in extract-dependencies-from-makefile
2577         https://bugs.webkit.org/show_bug.cgi?id=193783
2578         <rdar://problem/47201571>
2579
2580         Reviewed by Alex Christensen.
2581
2582         The extract-dependencies-from-makefile script generates .xcfilelists
2583         for XCBuild by invoking a makefile in --debug mode, parsing the
2584         dependency information in the output, and extracting information
2585         regarding targets and dependents. However, the way `make` emits this
2586         dependency information is not rigorous, and so we need to determine
2587         what lines to look for and parse by trial and error. This approach
2588         didn't coriginally atch all the information we needed to collect, so
2589         update the script to look for the additional lines we now know to look
2590         for.
2591
2592         * Scripts/extract-dependencies-from-makefile:
2593         (Parser):
2594         (Parser.addTarget):
2595         (Parser.addPrereq):
2596         (Parser.doParse):
2597
2598 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2599
2600         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2601         https://bugs.webkit.org/show_bug.cgi?id=193297
2602         <rdar://problem/47158841>
2603
2604         Reviewed by Alex Christensen.
2605
2606         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2607             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2608         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2609         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2610         activating the message used to trigger the callback when it is set.
2611
2612 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2613
2614         WKWebView.goBack should reload if there is a safe browsing warning
2615         https://bugs.webkit.org/show_bug.cgi?id=193805
2616         <rdar://problem/46908216>
2617
2618         Reviewed by Geoff Garen.
2619
2620         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2621         (+[Simple3LookupContext sharedLookupContext]):
2622         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2623         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2624         (TEST):
2625
2626 2019-01-25  Chris Dumez  <cdumez@apple.com>
2627
2628         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2629         https://bugs.webkit.org/show_bug.cgi?id=193788
2630         <rdar://problem/47531231>
2631
2632         Reviewed by Alex Christensen.
2633
2634         Add API test coverage.
2635
2636         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2637         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2638
2639 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2640
2641         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2642         https://bugs.webkit.org/show_bug.cgi?id=193771
2643
2644         Unreviewed infrastructure fix.
2645
2646         * Scripts/webkitpy/port/darwin.py:
2647         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2648
2649 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2650
2651         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2652
2653 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2654
2655         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2656
2657         * Scripts/webkitpy/common/config/contributors.json:
2658
2659 2019-01-25  Chris Dumez  <cdumez@apple.com>
2660
2661         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2662         https://bugs.webkit.org/show_bug.cgi?id=193779
2663         <rdar://problem/46170903>
2664
2665         Reviewed by Antti Koivisto.
2666
2667         Add API test that quickly navigates forward to a previous process without waiting for it to
2668         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2669         the process' previous page when reconnecting the it for the forward navigation.
2670
2671         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2672
2673 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2674
2675         Need a way for JavaScript (or bundle) code to participate in undo
2676         https://bugs.webkit.org/show_bug.cgi?id=190009
2677         <rdar://problem/44807048>
2678
2679         Reviewed by Ryosuke Niwa.
2680
2681         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2682         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2683
2684         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2685         (WTR::UIScriptController::lastUndoLabel const):
2686         (WTR::UIScriptController::firstRedoLabel const):
2687         (WTR::UIScriptController::platformUndoManager const):
2688         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2689         (WTR::UIScriptController::lastUndoLabel const):
2690         (WTR::UIScriptController::firstRedoLabel const):
2691         (WTR::UIScriptController::platformUndoManager const):
2692         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2693         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2694         (WTR::UIScriptController::lastUndoLabel const):
2695         (WTR::UIScriptController::firstRedoLabel const):
2696         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2697         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2698         (WTR::UIScriptController::lastUndoLabel const):
2699         (WTR::UIScriptController::firstRedoLabel const):
2700         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2701         (WTR::UIScriptController::platformUndoManager const):
2702         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2703         (WTR::UIScriptController::platformUndoManager const):
2704
2705 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2706
2707         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2708         https://bugs.webkit.org/show_bug.cgi?id=193824
2709
2710         Reviewed by Antti Koivisto.
2711
2712         * LayoutReloaded/misc/LFC-passing-tests.txt:
2713
2714 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2715
2716         Update macOS JSC bot configurations
2717         https://bugs.webkit.org/show_bug.cgi?id=193739
2718
2719         Reviewed by Alexey Proskuryakov.
2720
2721         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2722         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2723         (BubbleQueueServer): Move JSC EWS to Mojave section.
2724         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2725         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2726         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2727
2728 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2729
2730         [Win][WebKitTestRunner] Implement EventSenderProxy
2731         https://bugs.webkit.org/show_bug.cgi?id=193755
2732
2733         Reviewed by Don Olmstead.
2734
2735         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2736         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2737         (WTR::EventSenderProxy::dispatchMessage):
2738         (WTR::EventSenderProxy::EventSenderProxy):
2739         (WTR::EventSenderProxy::mouseDown):
2740         (WTR::EventSenderProxy::mouseUp):
2741         (WTR::EventSenderProxy::mouseMoveTo):
2742         (WTR::EventSenderProxy::mouseScrollBy):
2743         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2744
2745 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2746
2747         Unreviewed fix for API test failure after r240437.
2748
2749         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2750
2751         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2752
2753 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2754
2755         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2756         https://bugs.webkit.org/show_bug.cgi?id=193787
2757         <rdar://problem/47497634>
2758
2759         Reviewed by Alexey Proskuryakov.
2760
2761         * Scripts/webkitdirs.pm:
2762         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2763
2764 2019-01-24  Truitt Savell  <tsavell@apple.com>
2765
2766         Unreviewed, rolling out r240446.
2767
2768         Casued 5 API failures
2769
2770         Reverted changeset:
2771
2772         "Activate the WebResourceLoadStatisticsStore in the
2773         NetworkProcess and deactivate it in the UIProcess."
2774         https://bugs.webkit.org/show_bug.cgi?id=193297
2775         https://trac.webkit.org/changeset/240446
2776
2777 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2778
2779         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2780         https://bugs.webkit.org/show_bug.cgi?id=193741
2781         <rdar://problem/47135030>
2782
2783         Reviewed by Antti Koivisto and Simon Fraser.
2784
2785         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2786         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2787         (TestWebKitAPI::TEST):
2788
2789 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2790
2791         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2792         https://bugs.webkit.org/show_bug.cgi?id=193297
2793         <rdar://problem/47158841>
2794
2795         Reviewed by Alex Christensen.
2796
2797         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2798         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2799         activating the message used to trigger the callback when it is set.
2800
2801 2019-01-24  John Wilander  <wilander@apple.com>
2802
2803         Add Ad Click Attribution as an internal/experimental feature
2804         https://bugs.webkit.org/show_bug.cgi?id=193685
2805         <rdar://problem/47450399>
2806
2807         Reviewed by Brent Fulgham.
2808
2809         Added test option adClickAttributionEnabled.
2810
2811         * DumpRenderTree/TestOptions.cpp:
2812         (TestOptions::TestOptions):
2813         * DumpRenderTree/TestOptions.h:
2814         * DumpRenderTree/mac/DumpRenderTree.mm:
2815         (setWebPreferencesForTestOptions):
2816
2817 2019-01-24  Antti Koivisto  <antti@apple.com>
2818
2819         [PSON] Flash on back navigation on Mac
2820         https://bugs.webkit.org/show_bug.cgi?id=193716
2821         <rdar://problem/47148458>
2822
2823         Reviewed by Chris Dumez.
2824
2825         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2826
2827         Closing of the previous page is delayed so waiting for didFinishNavigation is
2828         not sufficient to guarantee we have received all the messages. Wait for them.
2829
2830 2019-01-24  Chris Dumez  <cdumez@apple.com>
2831
2832         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2833         https://bugs.webkit.org/show_bug.cgi?id=193761
2834         <rdar://problem/47456405>
2835
2836         Reviewed by Alex Christensen.
2837
2838         Add API test coverage.
2839
2840         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2841
2842 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2843
2844         webkitpy: Missing PID in crashlog name should not be fatal
2845         https://bugs.webkit.org/show_bug.cgi?id=193771
2846
2847         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2848         of raising an exception.
2849
2850         Reviewed by Lucas Forschler.
2851
2852         * Scripts/webkitpy/port/darwin.py:
2853         (DarwinPort._merge_crash_logs):
2854
2855 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2856
2857         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2858         https://bugs.webkit.org/show_bug.cgi?id=193746
2859
2860         Reviewed by Youenn Fablet.
2861
2862         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2863         so we'd best just not call it.
2864
2865         * Scripts/webkitpy/w3c/test_exporter.py:
2866         (WebPlatformTestExporter.create_branch_with_patch):
2867
2868 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2869
2870         Move FileSystem to WTF
2871         https://bugs.webkit.org/show_bug.cgi?id=193602
2872
2873         Reviewed by Yusuke Suzuki.
2874
2875         * DumpRenderTree/win/DumpRenderTree.cpp:
2876         * TestWebKitAPI/CMakeLists.txt:
2877         * TestWebKitAPI/PlatformGTK.cmake:
2878         * TestWebKitAPI/PlatformJSCOnly.cmake:
2879         * TestWebKitAPI/PlatformPlayStation.cmake:
2880         * TestWebKitAPI/PlatformWPE.cmake:
2881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2882         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2883         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2884         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2885         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2886         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2887         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2888         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2889         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2890         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2891
2892 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2893
2894         [WPE] Remove hard dependency on subprocess32 for the API tests
2895
2896         Rubber-stamped by Carlos Garcia Campos.
2897
2898         * glib/api_test_runner.py:
2899         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2900         its presence only when running WPEQt tests.
2901
2902 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2903
2904         [GLIB] Expose JavaScriptCore options in GLib public API
2905         https://bugs.webkit.org/show_bug.cgi?id=188742
2906
2907         Reviewed by Michael Catanzaro.
2908
2909         Add a test for the new API.
2910
2911         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2912         (testsJSCOptions):
2913         (main):
2914
2915 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2916
2917         [GTK][WPE] Support JPEG 2000 images
2918         https://bugs.webkit.org/show_bug.cgi?id=186272
2919
2920         Reviewed by Žan Doberšek.
2921
2922         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2923
2924         * gtk/jhbuild.modules:
2925         * wpe/jhbuild.modules:
2926
2927 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2928
2929         check-webkit-style should warn when using soft-linking macros in a header
2930         <https://webkit.org/b/193750>
2931
2932         Reviewed by Darin Adler.
2933
2934         * Scripts/webkitpy/style/checkers/cpp.py:
2935         (check_language): Add softlink/header check by refactoring the
2936         softlink/framework check.
2937         (CppChecker): Enable softlink/header check by default.
2938         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2939         (CppStyleTest.test_softlink_framework): Rename from
2940         CppStyleTest.test_softlink() and change test framework name in
2941         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2942         files. Set file_name for macros that only appear in headers.
2943         (CppStyleTest.test_softlink_header): Add tests for using
2944         soft-link macros in headers.
2945
2946 2019-01-23  Chris Dumez  <cdumez@apple.com>
2947
2948         Deprecate API to limit the maximum number of WebProcesses
2949         https://bugs.webkit.org/show_bug.cgi?id=193725
2950         <rdar://problem/47464879>
2951
2952         Reviewed by Geoff Garen.
2953
2954         Update existing API tests to stop using deprecated API.
2955
2956         * MiniBrowser/mac/AppDelegate.m:
2957         (defaultConfiguration):
2958         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2959         (TestWebKitAPI::TEST):
2960         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2961         (TestWebKitAPI::TEST):
2962         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2963         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2964         (TEST):
2965         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2966         (TEST):
2967
2968 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2969
2970         [ews-app] Rename ews model buildermappings to buildermapping
2971         https://bugs.webkit.org/show_bug.cgi?id=193729
2972
2973         Reviewed by Lucas Forschler.
2974
2975         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2976         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2977         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2978
2979 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2980
2981         [ews-app] Rename ews model steps to step
2982         https://bugs.webkit.org/show_bug.cgi?id=193697
2983
2984         Reviewed by Lucas Forschler.
2985
2986         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2987         (Step): Renamed Steps to Step.
2988
2989 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2990
2991         Clean up IndexedDB files between tests
2992         https://bugs.webkit.org/show_bug.cgi?id=192796
2993         <rdar://problem/46824999>
2994
2995         Reviewed by Geoffrey Garen.
2996
2997         * DumpRenderTree/mac/DumpRenderTree.mm:
2998         (runTest):
2999         * WebKitTestRunner/TestController.cpp:
3000         (WTR::TestController::resetStateToConsistentValues):
3001         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3002         (WTR::RemoveAllIndexedDatabasesCallback):
3003         (WTR::TestController::ClearIndexedDatabases):
3004         * WebKitTestRunner/TestController.h:
3005         * WebKitTestRunner/TestInvocation.cpp:
3006         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3007
3008 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3009
3010         [ews-app] Rename ews model Builds to Build
3011         https://bugs.webkit.org/show_bug.cgi?id=193695
3012
3013         Reviewed by Lucas Forschler.
3014
3015         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3016         (Build): Renamed Builds to Build.
3017
3018 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3019
3020         webkitpy: Wait longer when launching WebKitTestRunner
3021         https://bugs.webkit.org/show_bug.cgi?id=193734
3022
3023         Reviewed by Aakash Jain.
3024
3025         * Scripts/webkitpy/port/simulator_process.py:
3026         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3027
3028 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3029
3030         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3031         https://bugs.webkit.org/show_bug.cgi?id=193182
3032         <rdar://problem/47452154>
3033
3034         Reviewed by Tim Horton.
3035
3036         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3037         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3038         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3039
3040         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3041         preventing later tests from recognizing gestures.
3042
3043         * WebKitTestRunner/ios/TestControllerIOS.mm:
3044         (WTR::TestController::platformResetStateToConsistentValues):
3045
3046         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3047
3048 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3049
3050         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3051         https://bugs.webkit.org/show_bug.cgi?id=193722
3052         <rdar://problem/47481475>
3053
3054         Reviewed by Lucas Forschler.
3055
3056         iPhone and iPad ports should both use the iOS config.
3057
3058         * Scripts/webkitpy/port/ios_simulator.py:
3059         (IPhoneSimulatorPort.__init__):
3060         (IPadSimulatorPort.__init__):
3061
3062 2019-01-23  Rob Buis  <rbuis@igalia.com>
3063
3064         Update MIME type parser
3065         https://bugs.webkit.org/show_bug.cgi?id=180526
3066
3067         Reviewed by Frédéric Wang.
3068
3069         Add unit tests for both parse modes of ParsedContentType.
3070
3071         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3072         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3073         (TestWebKitAPI::TEST):
3074
3075 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3076
3077         [ews-app] fetch loop should not stop on network issues
3078         https://bugs.webkit.org/show_bug.cgi?id=193666
3079
3080         Reviewed by Lucas Forschler.
3081
3082         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3083         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3084
3085 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3086
3087         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3088         https://bugs.webkit.org/show_bug.cgi?id=189165
3089         <rdar://problem/47433765>
3090
3091         Reviewed by Tim Horton.
3092
3093         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3094         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3095         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3096         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3097         would make its way to the UI process by the time the layer tree commit is finished.
3098
3099         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3100         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3101         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3102         will fail because it asks for -_autofillContext too early.
3103
3104         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3105         is handled in the UI process.
3106
3107         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3108
3109         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3110         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3111         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3112         input session.
3113
3114         (-[AutofillTestView textInputHasAutofillContext]):
3115
3116         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3117
3118         * TestWebKitAPI/cocoa/TestWKWebView.h:
3119         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3120         (nextInputSessionChangeCount):
3121
3122         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3123         This includes changing the focused element from one to another.
3124
3125         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3126         (-[TestWKWebView didStartFormControlInteraction]):
3127         (-[TestWKWebView didEndFormControlInteraction]):
3128         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3129
3130         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3131         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3132         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3133         that doesn't require an input session to one that doesn't.
3134
3135 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3136
3137         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3138         <https://webkit.org/b/193676>
3139
3140         Reviewed by Alexey Proskuryakov.
3141
3142         * Scripts/webkitpy/style/checkers/cpp.py:
3143         (check_member_initialization_list):
3144         - Don't report missing whitespace around colon if the colon at
3145           the start of the line is formatted correctly.
3146         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3147         (WebKitStyleTest.test_member_initialization_list):
3148         - Add a test for a missing permutation of existing tests.
3149         - Add a test this false-positive.
3150         - Add blank lines between subtests to make them easier to read.
3151
3152 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3153
3154         [build.webkit.org] Unit-test failure after r237113
3155         https://bugs.webkit.org/show_bug.cgi?id=193669
3156
3157         Reviewed by Michael Catanzaro.
3158
3159         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3160         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3161         multiple or zero flags.
3162
3163 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3164
3165         Cache bytecode to disk
3166         https://bugs.webkit.org/show_bug.cgi?id=192782
3167         <rdar://problem/46084932>
3168
3169         Reviewed by Keith Miller.
3170
3171         Add test helper to execute bytecode-cache tests: it executes each test
3172         twice, the first with JSC_diskCachePath set to a temporary directory
3173         and second with JSC_forceDiskCache=true (in addition to the cache path)
3174         to guarantee that only the disk cache is being used and no new
3175         UnlinkedCodeBlocks are being created.
3176
3177         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3178         * Scripts/run-jsc-stress-tests:
3179
3180 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3181
3182         [css-logical] Implement flow-relative margin, padding and border shorthands
3183         https://bugs.webkit.org/show_bug.cgi?id=188697
3184
3185         Reviewed by Simon Fraser and Antti Koivisto.
3186
3187         * DumpRenderTree/TestOptions.cpp:
3188         (TestOptions::TestOptions):
3189         * DumpRenderTree/TestOptions.h:
3190         * DumpRenderTree/mac/DumpRenderTree.mm:
3191         (setWebPreferencesForTestOptions):
3192         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3193
3194         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3195         (JSONCSSPropertiesChecker.check_codegen_properties):
3196         Allow CSS property definitions to have a 'runtime-flag' parameter which
3197         disables the property when the specified runtime flag is disabled.
3198
3199 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3200
3201         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3202         https://bugs.webkit.org/show_bug.cgi?id=193643
3203
3204         Reviewed by Michael Catanzaro.
3205
3206         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3207         * wpe/jhbuild.modules: Ditto.
3208
3209 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3210
3211         [LFC][Floats] Take float top position into account when computing containing block height.
3212         https://bugs.webkit.org/show_bug.cgi?id=193655
3213
3214         Reviewed by Antti Koivisto.
3215
3216         * LayoutReloaded/misc/LFC-passing-tests.txt:
3217
3218 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3219
3220         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3221         <https://webkit.org/b/193645>
3222         <rdar://problem/47421574>
3223
3224         Reviewed by Alex Christensen.
3225
3226         - Now checks for local soft-linking of all frameworks that have
3227           their own *SoftLinking.{cpp,h,mm} files.
3228         - Changes softlink/uikit warning to softlink/framework.
3229
3230         * Scripts/webkitpy/style/checkers/cpp.py:
3231         (check_language):
3232         (CppChecker):
3233         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3234         (CppStyleTest):
3235
3236 2019-01-20  Saam Barati  <sbarati@apple.com>
3237
3238         Rollout r240210: It broke tests on iOS
3239         https://bugs.webkit.org/show_bug.cgi?id=193640
3240
3241         Unreviewed.
3242
3243         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3244         * Scripts/run-jsc-stress-tests:
3245
3246 2019-01-20  chris fleizach  <cfleizach@apple.com>
3247
3248         AX: Support returning relative frames for accessibility
3249         https://bugs.webkit.org/show_bug.cgi?id=193414
3250         <rdar://problem/47268501>
3251
3252         Reviewed by Zalan Bujtas.
3253
3254         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3255         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3256         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3257         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3258         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3259         (WTR::attributesOfElement):
3260         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3261
3262 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3263
3264         Unreviewed, add my new email address
3265
3266         * Scripts/webkitpy/common/config/contributors.json:
3267
3268 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3269
3270         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3271         https://bugs.webkit.org/show_bug.cgi?id=193617
3272
3273         Reviewed by Antti Koivisto.
3274
3275         * LayoutReloaded/misc/LFC-passing-tests.txt:
3276
3277 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3278
3279         Unreviewed, rolling out r240209.
3280
3281         Broke GTK/WPE injected bundle
3282
3283         Reverted changeset:
3284
3285         "AX: Support returning relative frames for accessibility"
3286         https://bugs.webkit.org/show_bug.cgi?id=193414
3287         https://trac.webkit.org/changeset/240209
3288
3289 2019-01-12  Dan Bernstein  <mitz@apple.com>
3290
3291         [Cocoa] Avoid importing directly from subumbrella frameworks
3292         https://bugs.webkit.org/show_bug.cgi?id=186016
3293         <rdar://problem/40591038>
3294
3295         Reviewed by Sam Weinig.
3296
3297         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3298           LaunchServices header.
3299         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3300           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3301         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3302           when using SDKs earlier than 10.13.
3303         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3304           and OTHER_CPLUSPLUSFLAGS.
3305         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3306           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3307         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3308           LaunchServices header.
3309
3310 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3311
3312         Cache bytecode to disk
3313         https://bugs.webkit.org/show_bug.cgi?id=192782
3314         <rdar://problem/46084932>
3315
3316         Reviewed by Keith Miller.
3317
3318         Add test helper to execute bytecode-cache tests: it executes each test
3319         twice, the first with JSC_diskCachePath set to a temporary directory
3320         and second with JSC_forceDiskCache=true (in addition to the cache path)
3321         to guarantee that only the disk cache is being used and no new
3322         UnlinkedCodeBlocks are being created.
3323
3324         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3325         * Scripts/run-jsc-stress-tests:
3326
3327 2019-01-20  chris fleizach  <cfleizach@apple.com>
3328
3329         AX: Support returning relative frames for accessibility
3330         https://bugs.webkit.org/show_bug.cgi?id=193414
3331         <rdar://problem/47268501>
3332
3333         Reviewed by Zalan Bujtas.
3334
3335         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3336         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3337         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3338         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3339         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3340         (WTR::attributesOfElement):
3341         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3342
3343 2019-01-20  Antoine Quint  <graouts@apple.com>
3344
3345         Add a POINTER_EVENTS feature flag
3346         https://bugs.webkit.org/show_bug.cgi?id=193577
3347         <rdar://problem/47408511>
3348
3349         Unreviewed. Also enable Pointer Events for iosmac.
3350
3351         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3352
3353 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3354
3355         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3356         https://bugs.webkit.org/show_bug.cgi?id=193613
3357
3358         Reviewed by Antti Koivisto.
3359
3360         * LayoutReloaded/misc/LFC-passing-tests.txt:
3361
3362 2019-01-19  Antoine Quint  <graouts@apple.com>
3363
3364         Add a POINTER_EVENTS feature flag
3365         https://bugs.webkit.org/show_bug.cgi?id=193577
3366
3367         Reviewed by Dean Jackson.
3368
3369         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3370
3371 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3372
3373         Disable the run-jsc-stress-test remote host key check [second round].
3374         https://bugs.webkit.org/show_bug.cgi?id=192988
3375
3376         Reviewed by Dewei Zhu.
3377
3378         * Scripts/run-jsc-stress-tests:
3379
3380 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3381
3382         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3383         https://bugs.webkit.org/show_bug.cgi?id=193597
3384
3385         Reviewed by Lucas Forschler.
3386
3387         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3388
3389 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3390
3391         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3392         https://bugs.webkit.org/show_bug.cgi?id=193595
3393
3394         Reviewed by Lucas Forschler.
3395
3396         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3397         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3398         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3399
3400 2019-01-18  Chris Dumez  <cdumez@apple.com>
3401
3402         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3403         https://bugs.webkit.org/show_bug.cgi?id=193588
3404         <rdar://problem/47131566>
3405
3406         Reviewed by Alex Christensen.
3407
3408         Add layout test coverage.
3409
3410         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3411
3412 2019-01-18  Jer Noble  <jer.noble@apple.com>
3413
3414         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3415         https://bugs.webkit.org/show_bug.cgi?id=189553
3416
3417         Reviewed by Tim Horton.
3418
3419         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3420
3421         * ContentExtensionTester/Configurations/Base.xcconfig:
3422         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3423         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3424         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3425         * ImageDiff/cg/Configurations/Base.xcconfig:
3426         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3427         * MiniBrowser/Configurations/Base.xcconfig:
3428         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3429         * MobileMiniBrowser/Configurations/Base.xcconfig:
3430         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3431         * Scripts/webkitpy/style/checker.py:
3432         (_all_categories):
3433         (FileType):
3434         (CheckerDispatcher._file_type):
3435         (CheckerDispatcher._create_checker):
3436         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3437         (SDKVariantChecker):
3438         (SDKVariantChecker.__init__):
3439         (SDKVariantChecker.check):
3440         * TestWebKitAPI/Configurations/Base.xcconfig:
3441         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3442         * WebEditingTester/Configurations/Base.xcconfig:
3443         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3444         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3445         * WebKitTestRunner/Configurations/Base.xcconfig:
3446         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3447         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3448         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3449
3450 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3451
3452         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3453         <https://webkit.org/b/193568>
3454         <rdar://problem/47381130>
3455
3456         Reviewed by Alex Christensen.
3457
3458         Make sure no one re-introduces UIKit soft-linking by adding a
3459         style rule.
3460
3461         * Scripts/webkitpy/style/checkers/cpp.py:
3462         (check_language): Add softlink/uikit check.
3463         (CppChecker): Enable softlink/uikit check.
3464         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3465         (CppStyleTest): Add test for softlink/uikit.
3466
3467 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3468
3469         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3470         https://bugs.webkit.org/show_bug.cgi?id=193584
3471
3472         Change "-dev" to "-devel".
3473
3474         Reviewed by Michael Catanzaro.
3475
3476         * gtk/install-dependencies:
3477
3478 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3479
3480         webkitpy: Add iPhone and iPad ports
3481         https://bugs.webkit.org/show_bug.cgi?id=193537
3482         <rdar://problem/47353390>
3483
3484         Reviewed by Lucas Forschler.
3485
3486         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3487         ports. Note that this separation is optional, the --ios-simulator command remains.
3488
3489         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3490         (RunTest.test_device_type_test_division): Drive-by fix.
3491         (RunTest.test_device_type_specific_listing): Ditto.
3492         (RunTest.test_ipad_test_division):
3493         (RunTest):
3494         (RunTest.test_ipad_listing):
3495         * Scripts/webkitpy/port/factory.py:
3496         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3497         (PortFactory):
3498         * Scripts/webkitpy/port/ios_simulator.py:
3499         (IPhoneSimulatorPort):
3500         (IPadSimulatorPort):
3501
3502 2019-01-18  Chris Dumez  <cdumez@apple.com>
3503
3504         Regression(PSON) Scroll position is not always restored properly when navigating back
3505         https://bugs.webkit.org/show_bug.cgi?id=193578
3506         <rdar://problem/47386331>
3507
3508         Reviewed by Tim Horton.
3509
3510         Add API test coverage.
3511
3512         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3513
3514 2019-01-18  Youenn Fablet  <youenn@apple.com>
3515
3516         Add a new SPI to request for cache storage quota increase
3517         https://bugs.webkit.org/show_bug.cgi?id=193323
3518
3519         Reviewed by Alex Christensen.
3520
3521         Implement WebsiteDataStore quota delegate to handle quota requests.
3522         By default, do not update quota.
3523         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3524
3525         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3526         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3527         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3528         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3529         * WebKitTestRunner/TestController.cpp:
3530         (WTR::TestController::allowCacheStorageQuotaIncrease):
3531         * WebKitTestRunner/TestController.h:
3532         * WebKitTestRunner/TestInvocation.cpp:
3533         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3534         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3535         (-[CacheStorageQuotaManager init]):
3536         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3537         (WTR::initializeWebViewConfiguration):
3538         (WTR::TestController::cocoaResetStateToConsistentValues):
3539         (WTR::TestController::allowCacheStorageQuotaIncrease):
3540
3541 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3542
3543         [ews-build] Pass owner to the triggered builds
3544         https://bugs.webkit.org/show_bug.cgi?id=193574
3545
3546         Reviewed by Lucas Forschler.
3547
3548         * BuildSlaveSupport/ews-build/factories.py:
3549         (BuildFactory.propertiesToPassToTriggers):
3550
3551 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3552
3553         [ews-app] Send patch author as a build property
3554         https://bugs.webkit.org/show_bug.cgi?id=193560
3555
3556         Reviewed by Lucas Forschler.
3557
3558         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3559         (BugzillaPatchFetcher.fetch):
3560
3561 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3562
3563         webkitpy: Implement device type specific expected results (Follow-up fix)
3564         https://bugs.webkit.org/show_bug.cgi?id=192162
3565         <rdar://problem/46345449>
3566
3567         Unreviewed infrastructure fix.
3568
3569         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3570         (Manager.run): Don't boot a device if no tests are available to run on it.
3571
3572 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3573
3574         webkitpy: Implement device type specific expected results (Follow-up fix)
3575         https://bugs.webkit.org/show_bug.cgi?id=192162
3576         <rdar://problem/46345449>
3577
3578         Unreviewed infrastructure fix.
3579
3580         * Scripts/webkitpy/api_tests/manager.py:
3581         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3582
3583 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3584
3585         webkitpy: Implement device type specific expected results (Part 2)
3586         https://bugs.webkit.org/show_bug.cgi?id=192162
3587         <rdar://problem/46345449>
3588
3589         Rubber-stamped by Aakash Jain.
3590
3591         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3592         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3593         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3594
3595         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3596         (LayoutTestFinder.find_tests): Pass device_type through.
3597         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3598         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3599         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3600         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3601         (Manager._collect_tests): Pass device type to test finder.
3602         (Manager._needs_web_platform_test):
3603         (Manager._prepare_lists): Index _expectations by device type.
3604         (Manager._test_input_for_file):
3605         (Manager._test_is_slow): Ditto.
3606         (Manager._test_should_dump_jsconsolelog_in_stderr):
3607         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3608         (Manager._get_test_inputs):
3609         (Manager._update_worker_count):
3610         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3611         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3612         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3613         the one which runs the test.
3614         (Manager._run_test_subset):
3615         (Manager._run_tests): Index _expectations by current_device_type.
3616         (Manager._print_expectation_line_for_test): Ditto.
3617         (Manager._print_expectations_for_subset): Ditto.
3618         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3619         Unlike run, this function will behave the same regardless of what devices are available.
3620         (Manager._custom_device_for_test): Deleted.
3621         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3622         (ManagerTest.test_uses_custom_device): Deleted.
3623         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3624         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3625         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3626         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3627         all of the expectations.
3628         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3629         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3630         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3631         (TestExpectations.__init__): Allow device_type to be passed through.
3632         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3633         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3634         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3635         (summarize_results):
3636         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3637         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3638         a test ran with, one must check all expectations to find the first non-skip expectation.
3639         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3640         (RunTest.test_device_type_test_division):
3641         (RunTest):
3642         (RunTest.test_device_type_specific_listing):
3643         * Scripts/webkitpy/port/base.py:
3644         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3645         (Port.supported_device_types): The result of this function will change based on what devices are available.
3646         * Scripts/webkitpy/port/device_port.py:
3647         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3648         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3649         can be used.
3650         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3651         any, or the DEFAULT_DEVICE_TYPES of the port.
3652         * Scripts/webkitpy/port/ios.py:
3653         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3654         * Scripts/webkitpy/port/ios_simulator.py:
3655         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3656         * Scripts/webkitpy/port/watch.py:
3657         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3658         * Scripts/webkitpy/port/watch_simulator.py:
3659         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3660         * Scripts/webkitpy/xcode/device_type.py:
3661         (DeviceType):
3662         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3663
3664 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3665
3666         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3667         https://bugs.webkit.org/show_bug.cgi?id=193575
3668
3669         Reviewed by Michael Catanzaro.
3670
3671         Allow the script to run without explicit port argument because
3672         it's specific to the WPE port anyway.
3673
3674         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3675         and simplify the rest of the code accordingly.
3676
3677 2019-01-18  Charlie Turner  <cturner@igalia.com>
3678
3679         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3680         https://bugs.webkit.org/show_bug.cgi?id=192229
3681
3682         Reviewed by Xabier Rodriguez-Calvar.
3683
3684         * MiniBrowser/wpe/main.cpp:
3685         (main): Enable encrypted-media by default.
3686
3687 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3688
3689         [Flatpak] Missing KeyboardInterrupt exception handler
3690         https://bugs.webkit.org/show_bug.cgi?id=193570
3691
3692         Reviewed by Michael Catanzaro.
3693
3694         * flatpak/flatpakutils.py:
3695         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3696
3697 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3698
3699         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3700         https://bugs.webkit.org/show_bug.cgi?id=193564
3701
3702         Reviewed by Antti Koivisto.
3703
3704         * LayoutReloaded/misc/LFC-passing-tests.txt:
3705
3706 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3707
3708         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3709         https://bugs.webkit.org/show_bug.cgi?id=193562
3710
3711         Reviewed by Antti Koivisto.
3712
3713         * LayoutReloaded/misc/LFC-passing-tests.txt:
3714
3715 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3716
3717         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3718         https://bugs.webkit.org/show_bug.cgi?id=193555
3719
3720         Reviewed by Antti Koivisto.
3721
3722         * LayoutReloaded/misc/LFC-passing-tests.txt:
3723
3724 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3725
3726         [WPE] Add Qt extension
3727         https://bugs.webkit.org/show_bug.cgi?id=191464
3728
3729         Reviewed by Carlos Garcia Campos.
3730
3731         MiniBrowser and API tests for the WPE Qt API. To run the
3732         MiniBrowser a new script is introduced. Example invocation:
3733
3734         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3735
3736         Also note-worthy is the introduction of the python2-subprocess32
3737         dependency to run the GLib API tests.
3738
3739         * MiniBrowser/wpe/CMakeLists.txt:
3740         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3741         * MiniBrowser/wpe/qt/main.cpp: Added.
3742         (main):
3743         * MiniBrowser/wpe/qt/main.qml: Added.
3744         * MiniBrowser/wpe/qt/qml.qrc: Added.
3745         * Scripts/run-gtk-tests:
3746         (GtkTestRunner.is_google_test):
3747         (GtkTestRunner):
3748         (GtkTestRunner.is_qt_test):
3749         * Scripts/run-qt-wpe-minibrowser: Added.
3750         * Scripts/run-wpe-tests:
3751         (WPETestRunner):
3752         (WPETestRunner.is_google_test):
3753         (WPETestRunner.is_qt_test):
3754         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3755         (TestLoad::main):
3756         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3757         (TestLoadHtml::main):
3758         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3759         (TestLoadRequest::main):
3760         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3761         (TestRunJavaScript::main):
3762         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3763         (waitForSignal):
3764         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3765         (LoadSpy::LoadSpy):
3766         (LoadSpy::~LoadSpy):
3767         (LoadSpy::onLoadingChanged):
3768         (LoadStartedCatcher::LoadStartedCatcher):
3769         (LoadStartedCatcher::~LoadStartedCatcher):
3770         (LoadStartedCatcher::onLoadingChanged):
3771         (waitForLoadSucceeded):
3772         (waitForLoadFailed):
3773         * TestWebKitAPI/glib/CMakeLists.txt:
3774         * flatpak/flatpakutils.py:
3775         (WebkitFlatpak.load_from_args):
3776         (WebkitFlatpak.__init__):
3777         (WebkitFlatpak.clean_args):
3778         (WebkitFlatpak.run_in_sandbox):
3779         * flatpak/org.webkit.CommonModules.yaml:
3780         * flatpak/org.webkit.WPE.yaml:
3781         * flatpak/org.webkit.WPEModules.yaml:
3782         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3783         * flatpak/org.webkit.WebKit.yaml:
3784         * glib/api_test_runner.py:
3785         (TestRunner._run_test_qt):
3786         (TestRunner.is_qt_test):
3787         (TestRunner._run_test):
3788
3789 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3790
3791         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3792         https://bugs.webkit.org/show_bug.cgi?id=193494
3793         <rdar://problem/46859627>
3794
3795         Reviewed by Simon Fraser and Tim Horton.
3796
3797         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3798         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3799
3800         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3801         (WTR::UIScriptController::contentOffsetX const):
3802         (WTR::UIScriptController::contentOffsetY const):
3803         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3804         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3805         (WTR::UIScriptController::contentOffsetX const):
3806         (WTR::UIScriptController::contentOffsetY const):
3807         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3808
3809         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3810
3811         * WebKitTestRunner/TestController.cpp:
3812         (WTR::updateTestOptionsFromTestHeader):
3813         * WebKitTestRunner/TestOptions.h:
3814         (WTR::TestOptions::hasSameInitializationOptions const):
3815         * WebKitTestRunner/ios/TestControllerIOS.mm:
3816         (WTR::TestController::platformResetStateToConsistentValues):
3817         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3818         (WTR::UIScriptController::contentOffsetX const):
3819         (WTR::UIScriptController::contentOffsetY const):
3820
3821 2019-01-17  Truitt Savell  <tsavell@apple.com>
3822
3823         Unreviewed, rolling out r240124.
3824
3825         This commit broke an internal build.
3826
3827         Reverted changeset:
3828
3829         "SDK_VARIANT build destinations should be separate from non-
3830         SDK_VARIANT builds"
3831         https://bugs.webkit.org/show_bug.cgi?id=189553
3832         https://trac.webkit.org/changeset/240124
3833
3834 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3835
3836         Fix string concatenation API test after r239920
3837         https://bugs.webkit.org/show_bug.cgi?id=193551
3838         <rdar://problem/47359304>
3839
3840         Reviewed by Youenn Fablet.
3841
3842         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3843         (TestWebKitAPI::TEST):
3844         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3845         in WebKit's build configuration like it apparently is on Linux.
3846
3847 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3848
3849         [ews-build] validate-patch should handle the case when bug_id is None
3850         https://bugs.webkit.org/show_bug.cgi?id=193547
3851
3852         Reviewed by Lucas Forschler.
3853
3854         * BuildSlaveSupport/ews-build/steps.py:
3855         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3856         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3857
3858 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3859
3860         [ews-build] Add patch author information in build
3861         https://bugs.webkit.org/show_bug.cgi?id=193465
3862
3863         Reviewed by Lucas Forschler.
3864
3865         * BuildSlaveSupport/ews-build/steps.py:
3866         (ValidatePatch._is_patch_obsolete):
3867
3868 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3869
3870         [ews-build] Pass bug_id to the triggered builds
3871         https://bugs.webkit.org/show_bug.cgi?id=193548
3872
3873         Reviewed by Lucas Forschler.
3874
3875         * BuildSlaveSupport/ews-build/factories.py:
3876         (BuildFactory.propertiesToPassToTriggers):
3877
3878 2019-01-17  Jer Noble  <jer.noble@apple.com>
3879
3880         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3881         https://bugs.webkit.org/show_bug.cgi?id=189553
3882
3883         Reviewed by Tim Horton.
3884
3885         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3886
3887         * ContentExtensionTester/Configurations/Base.xcconfig:
3888         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3889         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3890         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3891         * ImageDiff/cg/Configurations/Base.xcconfig:
3892         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3893         * MiniBrowser/Configurations/Base.xcconfig:
3894         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3895         * MobileMiniBrowser/Configurations/Base.xcconfig:
3896         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3897         * Scripts/webkitpy/style/checker.py:
3898         (_all_categories):
3899         (FileType):
3900         (CheckerDispatcher._file_type):
3901         (CheckerDispatcher._create_checker):
3902         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3903         (SDKVariantChecker):
3904         (SDKVariantChecker.__init__):
3905         (SDKVariantChecker.check):
3906         * TestWebKitAPI/Configurations/Base.xcconfig:
3907         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3908         * WebEditingTester/Configurations/Base.xcconfig:
3909         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3910         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3911         * WebKitTestRunner/Configurations/Base.xcconfig:
3912         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3913         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3914         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3915
3916 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3917
3918         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3919         https://bugs.webkit.org/show_bug.cgi?id=193534
3920
3921         Reviewed by Antti Koivisto.
3922
3923         * LayoutReloaded/misc/LFC-passing-tests.txt:
3924
3925 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3926
3927         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3928         https://bugs.webkit.org/show_bug.cgi?id=193528
3929
3930         Reviewed by Antti Koivisto.
3931
3932         * LayoutReloaded/misc/LFC-passing-tests.txt:
3933
3934 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3935
3936         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3937         https://bugs.webkit.org/show_bug.cgi?id=193520
3938
3939         Reviewed by Antti Koivisto.
3940
3941         * LayoutReloaded/misc/LFC-passing-tests.txt:
3942
3943 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3944
3945         [ews-build] unapply-patch step should not update source
3946         https://bugs.webkit.org/show_bug.cgi?id=193234
3947
3948         Reviewed by Lucas Forschler.
3949
3950         * BuildSlaveSupport/ews-build/steps.py:
3951         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3952         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3953
3954 2019-01-16  Youenn Fablet  <youenn@apple.com>
3955
3956         Add a new SPI for controlling getUserMedia
3957         https://bugs.webkit.org/show_bug.cgi?id=192793
3958
3959         Reviewed by Eric Carlson.
3960
3961         * MiniBrowser/mac/WK2BrowserWindowController.m:
3962         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3963         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3964         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3965         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3966         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3967         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3968         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3969         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3970         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3971         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3972         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3973         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3974         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3975         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3976
3977 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3978
3979         [LFC][BFC] Inflow non-replaced used width should not be negative.
3980         https://bugs.webkit.org/show_bug.cgi?id=193495
3981
3982         Reviewed by Antti Koivisto.
3983
3984         * LayoutReloaded/misc/LFC-passing-tests.txt:
3985
3986 2019-01-16  Chris Dumez  <cdumez@apple.com>
3987
3988         Regression(PSON) View becomes blank after click a cross-site download link
3989         https://bugs.webkit.org/show_bug.cgi?id=193361
3990         <rdar://problem/47099573>
3991
3992         Reviewed by Geoffrey Garen.
3993
3994         Add API test coverage.
3995
3996         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3997         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3998
3999 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4000
4001         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
4002         https://bugs.webkit.org/show_bug.cgi?id=193470
4003
4004         Reviewed by Antti Koivisto.
4005
4006         * LayoutReloaded/misc/LFC-passing-tests.txt:
4007
4008 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4009
4010         [LFC] Adjust margin box verification.
4011         https://bugs.webkit.org/show_bug.cgi?id=193482
4012
4013         Reviewed by Antti Koivisto.
4014
4015         * LayoutReloaded/misc/LFC-passing-tests.txt:
4016
4017 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
4018
4019         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
4020         https://bugs.webkit.org/show_bug.cgi?id=193451
4021
4022         Reviewed by Geoffrey Garen.
4023
4024         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
4025         (TEST):
4026         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4027         (runWebsiteDataStoreCustomPaths):
4028
4029 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4030
4031         webkitpy: Support boolean simctl isAvailable
4032         https://bugs.webkit.org/show_bug.cgi?id=193472
4033         <rdar://problem/47296150>
4034
4035         Reviewed by Ryosuke Niwa.
4036
4037         * Scripts/webkitpy/xcode/simulated_device.py:
4038         (SimulatedDeviceManager._create_runtimes):
4039         (SimulatedDeviceManager._create_device_with_runtime):
4040
4041 2019-01-15  Chris Dumez  <cdumez@apple.com>
4042
4043         Unreviewed, rolling out r239993, r239995, r239997, and
4044         r239999.
4045
4046         Caused assertions under
4047         ViewGestureController::disconnectFromProcess()
4048
4049         Reverted changesets:
4050
4051         "Regression(PSON) View becomes blank after click a cross-site
4052         download link"
4053         https://bugs.webkit.org/show_bug.cgi?id=193361
4054         https://trac.webkit.org/changeset/239993
4055
4056         "Unreviewed iOS build fix after r239993."
4057         https://trac.webkit.org/changeset/239995
4058
4059         "Fix iOS build after r239993"
4060         https://bugs.webkit.org/show_bug.cgi?id=193361
4061         https://trac.webkit.org/changeset/239997
4062
4063         "Unreviewed, revert part of r239997 as it is not needed to fix
4064         the build."
4065         https://trac.webkit.org/changeset/239999
4066
4067 2019-01-15  Tim Horton  <timothy_horton@apple.com>
4068
4069         Cannot tab out of WKWebView on macOS
4070         https://bugs.webkit.org/show_bug.cgi?id=161448
4071         <rdar://problem/28100085>
4072
4073         Reviewed by Dean Jackson.
4074
4075         Add a test that tabbing into and out of WKWebView works correctly.
4076
4077         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4078         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
4079         (WebKit2_CommandBackForwardTest::SetUp):
4080         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
4081         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
4082         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
4083         (-[FocusableView canBecomeKeyView]):
4084         (TEST):
4085         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
4086         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
4087         (-[OffscreenWindow initWithSize:]):
4088         (-[OffscreenWindow isKeyWindow]):
4089         (-[OffscreenWindow isVisible]):
4090         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4091         (TestWebKitAPI::PlatformWebView::initialize):
4092         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
4093         (-[ActiveOffscreenWindow isVisible]): Deleted.
4094         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
4095
4096 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
4097
4098         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
4099         https://bugs.webkit.org/show_bug.cgi?id=193459
4100
4101         Reviewed by Mark Lam.
4102
4103         * BuildSlaveSupport/build.webkit.org-config/steps.py:
4104         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
4105
4106 2019-01-15  Chris Dumez  <cdumez@apple.com>
4107
4108         Regression(PSON) View becomes blank after click a cross-site download link
4109         https://bugs.webkit.org/show_bug.cgi?id=193361
4110         <rdar://problem/47099573>
4111
4112         Reviewed by Geoff Garen.
4113
4114         Add API test coverage.
4115
4116         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4117         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4118
4119 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4120
4121         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
4122         https://bugs.webkit.org/show_bug.cgi?id=193448
4123
4124         Reviewed by Antti Koivisto.
4125
4126         * LayoutReloaded/misc/LFC-passing-tests.txt:
4127
4128 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4129
4130         webkitpy: Implement device type specific expected results (Part 1)
4131         https://bugs.webkit.org/show_bug.cgi?id=192162
4132
4133         Reviewed by Lucas Forschler.
4134
4135         Device type specific expected results covers two related ideas. The first (covered by this change)
4136         is where to search for -expected.* files. The second is which tests to run based on the
4137         TestExpectations.txt file.
4138
4139         After this change, the baseline search path will be determined by the type of device running a
4140         test. Device type will be passed into any function which picks a file based on the baseline search
4141         path.
4142
4143         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4144         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
4145         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4146         (Manager.run): Print baseline search path for each round of devices.
4147         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
4148         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
4149         (SingleTestRunner._expected_driver_output): Ditto.
4150         (SingleTestRunner._driver_input): Ditto.
4151         * Scripts/webkitpy/layout_tests/views/printing.py:
4152         (Printer.print_config): Move printing of baseline search path to a separate function.
4153         (Printer.print_baseline_search_path): Moved from Printer.print_config.
4154         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4155         (Testprinter.test_print_config):
4156         (Testprinter.test_print_baseline_search_path):
4157         * Scripts/webkitpy/port/base.py:
4158         (Port.baseline_search_path): Pass device_type through.
4159         (Port._expected_baselines_for_suffixes): Ditto.
4160         (Port.expected_baselines): Ditto.
4161         (Port.expected_filename): Ditto.
4162         (Port.expected_checksum): Ditto.
4163         (Port.expected_image): Ditto.
4164         (Port.expected_audio): Ditto.
4165         (Port.expected_text): Ditto.
4166         (Port.reference_files): Ditto.
4167         (Port.tests): Ditto.
4168         (Port._expanded_paths): Ditto.
4169         (Port.skipped_layout_tests): Ditto.
4170         (Port.expectations_dict): Ditto.
4171         (Port._port_specific_expectations_files): Ditto.
4172         (Port.expectations_files): Ditto.
4173         (Port.test_search_path): Ditto.
4174         (Port._tests_for_other_platforms): Ditto.
4175         * Scripts/webkitpy/port/base_unittest.py:
4176         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
4177         (PortTest.test_nonexistant_expectations): Ditto.
4178         (test_ref_tests_platform_directory): Ditto.
4179         * Scripts/webkitpy/port/darwin.py:
4180         (DarwinPort._port_specific_expectations_files): Accept device_type.
4181         * Scripts/webkitpy/port/driver.py:
4182         (DriverProxy):
4183         (DriverProxy.host): Expose _target_host for device_type information.
4184         * Scripts/webkitpy/port/gtk.py:
4185         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
4186         * Scripts/webkitpy/port/ios.py:
4187         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4188         * Scripts/webkitpy/port/mac.py:
4189         (MacPort. default_baseline_search_path): Ditto.
4190         * Scripts/webkitpy/port/port_testcase.py:
4191         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
4192         * Scripts/webkitpy/port/test.py:
4193         * Scripts/webkitpy/port/watch.py:
4194         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4195         * Scripts/webkitpy/port/win.py:
4196         (WinPort.test_search_path): Accept, but do not use, device_type.
4197         * Scripts/webkitpy/port/wpe.py:
4198         (WPEPort._port_specific_expectations_files): Ditto.
4199         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
4200         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
4201
4202 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4203
4204         [LFC] Use the containing block's padding box to position out-of-flow elements.
4205         https://bugs.webkit.org/show_bug.cgi?id=193431
4206
4207         Reviewed by Antti Koivisto.
4208
4209         * LayoutReloaded/misc/LFC-passing-tests.txt:
4210
4211 2019-01-14  Tim Horton  <timothy_horton@apple.com>
4212
4213         Move a test implementation file that got misplaced in the Xcode project
4214
4215         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4216
4217 2019-01-14  Commit Queue  <commit-queue@webkit.org>
4218
4219         Unreviewed, rolling out r239901, r239909, r239910, r239912,
4220         r239913, and r239914.
4221         https://bugs.webkit.org/show_bug.cgi?id=193407
4222
4223         These revisions caused an internal failure (Requested by
4224         Truitt on #webkit).
4225
4226         Reverted changesets:
4227
4228         "[Cocoa] Avoid importing directly from subumbrella frameworks"
4229         https://bugs.webkit.org/show_bug.cgi?id=186016
4230         https://trac.webkit.org/changeset/239901
4231
4232         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
4233         https://trac.webkit.org/changeset/239909
4234
4235         "Tried to fix the build."
4236         https://trac.webkit.org/changeset/239910
4237
4238         "Fixed iOS builds after r239910."
4239         https://trac.webkit.org/changeset/239912
4240
4241         "More build fixing."
4242         https://trac.webkit.org/changeset/239913
4243
4244         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
4245         https://trac.webkit.org/changeset/239914
4246
4247 2019-01-14  Mark Lam  <mark.lam@apple.com>
4248
4249         Re-enable ability to build --cloop builds.
4250         https://bugs.webkit.org/show_bug.cgi?id=192955
4251         <rdar://problem/46882363>
4252
4253         Reviewed by Saam barati and Keith Miller.
4254
4255         The --cloop build option was being ignored this whole time since r236381.
4256         This patch makes it possible to build CLoop builds again.
4257
4258         * Scripts/build-jsc:
4259         * Scripts/webkitperl/FeatureList.pm:
4260         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4261
4262 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4263
4264         webkitpy: Expose device_type from host-like objects
4265         https://bugs.webkit.org/show_bug.cgi?id=193406
4266         <rdar://problem/47262305>
4267
4268         Reviewed by Lucas Forschler.
4269
4270         Devices should expose device_type. As a result, all host objects should
4271         provide a device_type property, even if they do not yet define a device_type.
4272
4273         * Scripts/webkitpy/common/system/systemhost.py:
4274         (SystemHost):
4275         (SystemHost.device_type):
4276         * Scripts/webkitpy/common/system/systemhost_mock.py:
4277         (MockSystemHost):
4278         (MockSystemHost.device_type):
4279         * Scripts/webkitpy/port/device.py:
4280         (Device):
4281         (Device.device_type):
4282         * Scripts/webkitpy/xcode/simulated_device.py:
4283         (SimulatedDeviceManager._find_exisiting_device_for_request):
4284         (SimulatedDeviceManager._disambiguate_device_type):
4285         (SimulatedDeviceManager._does_fulfill_request):
4286         (SimulatedDeviceManager.device_count_for_type):
4287         (SimulatedDeviceManager.initialize_devices):
4288         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
4289         (test_available_devices):
4290         (test_swapping_devices):
4291
4292 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4293
4294         webkitpy: Support alternate simctl device list output (Follow-up fix)
4295         https://bugs.webkit.org/show_bug.cgi?id=193362
4296         <rdar://problem/47122965>
4297
4298         Rubber-stamped by Lucas Forschler.
4299
4300         * Scripts/webkitpy/xcode/simulated_device.py:
4301         (SimulatedDeviceManager.populate_available_devices):
4302
4303 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
4304
4305         [iOS] Expose SPI to access the current sentence boundary and selection state
4306         https://bugs.webkit.org/show_bug.cgi?id=193398
4307         <rdar://problem/45893108>
4308
4309         Reviewed by Dean Jackson.
4310
4311         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
4312         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
4313         expected.
4314
4315         * TestWebKitAPI/EditingTestHarness.h:
4316         * TestWebKitAPI/EditingTestHarness.mm:
4317         (-[EditingTestHarness moveBackward]):
4318         (-[EditingTestHarness moveForward]):
4319         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
4320
4321         Add a couple of new helper methods on EditingTestHarness.
4322
4323         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
4324         (-[SelectionChangeObserver initWithWebView:]):
4325         (-[SelectionChangeObserver webView]):
4326         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
4327         (-[SelectionChangeObserver currentSelectionAttributes]):
4328
4329 2019-01-14  Zalan Bujtas  <zalan@apple.com>
4330
4331         [LFC][BFC] Add basic box-sizing support.
4332         https://bugs.webkit.org/show_bug.cgi?id=193392
4333
4334         Reviewed by Antti Koivisto.