Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestR...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
2
3         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
4         https://bugs.webkit.org/show_bug.cgi?id=196635
5
6         Reviewed by Antti Koivisto.
7         
8         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
9         for a test to enable async frame scrolling via:
10             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
11         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
12         
13         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
14
15         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
16         (WTR::InjectedBundle::beginTesting):
17         * WebKitTestRunner/TestController.cpp:
18         (WTR::TestController::resetPreferencesToConsistentValues):
19
20 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
21
22         Use a correct LC_RPATH when building with ASan
23         https://bugs.webkit.org/show_bug.cgi?id=196576
24
25         Reviewed by David Kilzer.
26
27         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
28         so that ../Frameworks is checked. This is simpler and more reliable than updating
29         each SPC service xcconfig.
30
31 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
32
33         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
34         https://bugs.webkit.org/show_bug.cgi?id=196629
35
36         Reviewed by Lucas Forschler.
37
38         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
39
40 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
41
42         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
43         https://bugs.webkit.org/show_bug.cgi?id=196618
44
45         Reviewed by Lucas Forschler.
46
47         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
48         (StatusBubble): Added QUEUE_TRIGGERS.
49         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
50         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
51         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
52         its parent(builder).
53
54 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
55
56         [ews-app] Status-bubble steps are sometimes displayed in reverse order
57         https://bugs.webkit.org/show_bug.cgi?id=196625
58
59         Reviewed by Lucas Forschler.
60
61         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
62         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
63
64 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
65
66         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
67         https://bugs.webkit.org/show_bug.cgi?id=196630
68
69         Reviewed by Wenson Hsieh.
70
71         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
72
73 2019-04-04  Youenn Fablet  <youenn@apple.com>
74
75         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
76         https://bugs.webkit.org/show_bug.cgi?id=196543
77
78         Reviewed by Alex Christensen.
79
80         * WebKitTestRunner/TestController.cpp:
81         (WTR::TestController::generatePageConfiguration):
82
83 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
84
85         [ews-app] Status bubble should not display skipped buildbot steps
86         https://bugs.webkit.org/show_bug.cgi?id=196584
87
88         Reviewed by Lucas Forschler.
89
90         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
91
92 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
93
94         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
95         https://bugs.webkit.org/show_bug.cgi?id=196620
96
97         Reviewed by Lucas Forschler.
98
99         * BuildSlaveSupport/ews-app/ews/config.py:
100
101 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
102
103         [Win] DumpRenderTreeWatchDog.py is not checked into source
104         https://bugs.webkit.org/show_bug.cgi?id=196567
105         <rdar://problem/49525901>
106
107         Reviewed by Lucas Forschler.
108
109         This script is used on Win EWS bots to terminate hanging DRT processes.
110
111         * EWSTools/dumprendertreewatchdog.py: Added.
112
113 2019-04-04  Chris Dumez  <cdumez@apple.com>
114
115         Unreviewed, roll out r243858 which made tests time out.
116
117         Disable new API tests on Windows instead.
118
119         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
120         (TestWebKitAPI::TEST):
121
122 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
123
124         [ATK] Cleanup WebPageAccessibilityObjectAtk
125         https://bugs.webkit.org/show_bug.cgi?id=196537
126
127         Reviewed by Michael Catanzaro.
128
129         Also consider files under atk directories as exceptions for GObject conventions.
130
131         * Scripts/webkitpy/style/checkers/cpp.py:
132         (check_identifier_name_in_declaration):
133
134 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
135
136         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
137         https://bugs.webkit.org/show_bug.cgi?id=196588
138         <rdar://problem/49365787>
139
140         Unreviewed build fix for Windows port.
141
142         error C3861: 'kill': identifier not found
143
144         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
145         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
146
147 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
148
149         [ews-build] Cancel build and similar operations should have authentication
150         https://bugs.webkit.org/show_bug.cgi?id=196520
151
152         Reviewed by Dewei Zhu.
153
154         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
155         environment variables.
156
157 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
158
159         [ews-build] Do not trigger queues which are not in production yet
160         https://bugs.webkit.org/show_bug.cgi?id=196581
161
162         Reviewed by Dewei Zhu.
163
164         * BuildSlaveSupport/ews-build/config.json:
165
166 2019-04-03  Chris Dumez  <cdumez@apple.com>
167
168         Unreviewed, fix typo in the name of API test added in r243848.
169
170         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
171         (TestWebKitAPI::TEST):
172
173 2019-04-03  Chris Dumez  <cdumez@apple.com>
174
175         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
176         https://bugs.webkit.org/show_bug.cgi?id=196588
177         <rdar://problem/49365787>
178
179         Reviewed by Ryosuke Niwa.
180
181         Add API test coverage.
182
183         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
184         (TestWebKitAPI::nullJavaScriptCallback):
185         (TestWebKitAPI::didCrashCheckFrames):
186         (TestWebKitAPI::TEST):
187
188 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
189
190         run-webkit-tests: Upload test results (new results database)
191         https://bugs.webkit.org/show_bug.cgi?id=196577
192         <rdar://problem/34841155>
193
194         Reviewed by Lucas Forschler.
195
196         * Scripts/webkitpy/layout_tests/controllers/manager.py:
197         (Manager.run): Upload results after each device shard, since the configuration will be
198         different for each device.
199         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
200         uploaded to a results database.
201         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
202         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
203
204 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
205
206         -apple-trailing-word is needed for browser detection
207         https://bugs.webkit.org/show_bug.cgi?id=196575
208
209         Unreviewed.
210
211         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
212
213 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
214
215         [CMake][WTF] Mirror XCode header directories
216         https://bugs.webkit.org/show_bug.cgi?id=191662
217
218         Reviewed by Konstantin Tokarev.
219
220         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
221         builds.
222
223         * CMakeLists.txt:
224         * DumpRenderTree/CMakeLists.txt:
225         * DumpRenderTree/PlatformWin.cmake:
226         * MiniBrowser/win/CMakeLists.txt:
227         * TestWebKitAPI/CMakeLists.txt:
228         * TestWebKitAPI/PlatformWin.cmake:
229         * WebKitTestRunner/PlatformGTK.cmake:
230         * WebKitTestRunner/PlatformWin.cmake:
231
232 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
233
234         [ews-app] Status bubble should not display certain infrastructure status messages
235         https://bugs.webkit.org/show_bug.cgi?id=196550
236
237         Reviewed by Lucas Forschler.
238
239         Do not display the steps which are un-needed for end-user. This information is still avaiable
240         if the user click on the bubble and look at the Buildbot build.
241         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
242         (StatusBubble._steps_messages):
243         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
244
245 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
246
247         [ews-build] Use https for sending data to ews-app
248         https://bugs.webkit.org/show_bug.cgi?id=196492
249
250         Reviewed by Lucas Forschler.
251
252         * BuildSlaveSupport/ews-build/events.py:
253
254 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
255
256         Remove support for -apple-trailing-word
257         https://bugs.webkit.org/show_bug.cgi?id=196525
258
259         Reviewed by Zalan Bujtas.
260
261         This CSS property is nonstandard and not used.
262
263         * Scripts/webkitperl/FeatureList.pm:
264         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
265
266 2019-04-03  Youenn Fablet  <youenn@apple.com>
267
268         Add a test for DOMCache on multiple browsing in case of private browsing
269         https://bugs.webkit.org/show_bug.cgi?id=196524
270
271         Reviewed by Alex Christensen.
272
273         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
274         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
275
276 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
277
278         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
279         https://bugs.webkit.org/show_bug.cgi?id=196540
280
281         Reviewed by Aakash Jain.
282
283         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
284
285 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
286
287         Add plumbing for a compatibility mode preference in WebKit
288         https://bugs.webkit.org/show_bug.cgi?id=196005
289
290         Reviewed by Tim Horton.
291
292         Add new API tests.
293
294         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
295         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
296
297 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
298
299         [WPE][GTK] Update libsrtp dependency package for Debian
300         https://bugs.webkit.org/show_bug.cgi?id=196528
301
302         Reviewed by Frédéric Wang.
303
304         * gtk/install-dependencies:
305         * wpe/install-dependencies:
306
307 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
308
309         [WK2] Add support for Window's beforeprint / afterprint events
310         https://bugs.webkit.org/show_bug.cgi?id=196478
311         <rdar://problem/49535124>
312
313         Unreviewed build fix for MSVC.
314
315         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
316
317         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
318
319         * WebKitTestRunner/TestController.cpp:
320         (WTR::printFrame): Use int and float literals.
321
322 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
323
324         [ews-build] Reassign bots to queues
325
326         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
327
328 2019-04-02  Chris Dumez  <cdumez@apple.com>
329
330         [WK2] Add support for Window's beforeprint / afterprint events
331         https://bugs.webkit.org/show_bug.cgi?id=196478
332
333         Reviewed by Alex Christensen.
334
335         Add minimal implementation for printFrame in WebKitTestRunner.
336
337         * WebKitTestRunner/TestController.cpp:
338         (WTR::printFrame):
339         (WTR::TestController::createOtherPage):
340         (WTR::TestController::createWebViewWithOptions):
341
342 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
343
344         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
345         https://bugs.webkit.org/show_bug.cgi?id=196491
346
347         Reviewed by Lucas Forschler.
348
349         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
350
351 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
352
353         [ews-build] Configure buildbot try credentials in environment variables
354         https://bugs.webkit.org/show_bug.cgi?id=196501
355
356         Reviewed by Lucas Forschler.
357
358         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
359         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
360         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
361
362 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
363
364         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
365         https://bugs.webkit.org/show_bug.cgi?id=196496
366         <rdar://problem/49521634>
367
368         Reviewed by Chris Dumez.
369
370         Add new API tests (see WebKit ChangeLog for more detail).
371
372         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
373         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
374         (TEST):
375
376 2019-04-02  David Kilzer  <ddkilzer@apple.com>
377
378         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
379         <https://webkit.org/b/196499>
380
381         Reviewed by Alexey Proskuryakov.
382
383         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
384         ENABLE_ADDRESS_SANITIZER.
385
386 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
387
388         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
389         https://bugs.webkit.org/show_bug.cgi?id=182757
390
391         Reviewed by Don Olmstead.
392
393         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
394         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
395
396 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
397
398         run-api-tests: Upload test results
399         https://bugs.webkit.org/show_bug.cgi?id=196323
400         <rdar://problem/49356714>
401
402         Reviewed by Lucas Forschler.
403
404         * Scripts/webkitpy/api_tests/manager.py:
405         (Manager):
406         (Manager.run): Upload results to a results database.
407         * Scripts/webkitpy/api_tests/run_api_tests.py:
408         (parse_args): Add upload arguments.
409         * Scripts/webkitpy/port/base.py:
410         (Port):
411         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
412         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
413         with commits from any other associated repositories.
414         * Scripts/webkitpy/port/device.py:
415         (Device):
416         (Device.build_version): Access build_versoin of underlying platform device.
417         * Scripts/webkitpy/port/ios_simulator_unittest.py:
418         (IOSSimulatorTest):
419         (IOSSimulatorTest.test_configuration_for_upload):
420         * Scripts/webkitpy/port/device_port.py:
421         (DevicePort):
422         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
423         the same as the machine uploading results.
424         * Scripts/webkitpy/port/mac.py:
425         (MacPort):
426         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
427         * Scripts/webkitpy/port/mac_unittest.py:
428         (MacTest):
429         (MacTest.test_configuration_for_upload):
430         * Scripts/webkitpy/xcode/simulated_device.py:
431         (SimulatedDeviceManager._create_device_with_runtime):
432         (SimulatedDevice.__init__): Create simulated device with a build_version.
433         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
434         (test_existing_simulator):
435
436 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
437
438         Remove extra newline characters (Follow-up fix to r243707)
439
440         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
441
442 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
443
444         [ews-app] Use API_KEY to accept results data
445         https://bugs.webkit.org/show_bug.cgi?id=196461
446
447         Reviewed by Dewei Zhu.
448
449         * BuildSlaveSupport/ews-app/ews/views/results.py:
450         (Results.post): Validate EWS_API_KEY before accepting any data.
451         * BuildSlaveSupport/ews-build/events.py:
452         (Events.sendData): Send EWS_API_KEY if available along with event data.
453
454 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
455
456         Unable to copy and paste a PDF from Notes into Mail compose body
457         https://bugs.webkit.org/show_bug.cgi?id=196442
458         <rdar://problem/48573098>
459
460         Reviewed by Tim Horton.
461
462         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
463         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
464         to be specified on the item providers.
465
466         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
467         (TestWebKitAPI::mapItemForTesting):
468         (TestWebKitAPI::contactItemForTesting):
469
470 2019-04-01  Tim Horton  <timothy_horton@apple.com>
471
472         Make UIWKDocumentContext rects per-character instead of per-word
473         https://bugs.webkit.org/show_bug.cgi?id=196459
474
475         Reviewed by Wenson Hsieh.
476
477         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
478         (TEST):
479         Adjust test results due to switching to per-character rects.
480
481 2019-04-01  Chris Dumez  <cdumez@apple.com>
482
483         UIProcess crash when a prewarmed process is terminated
484         https://bugs.webkit.org/show_bug.cgi?id=196451
485         <rdar://problem/49245471>
486
487         Reviewed by Geoffrey Garen.
488
489         Add API test coverage.
490
491         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
492         (TEST):
493
494 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
495
496         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
497         https://bugs.webkit.org/show_bug.cgi?id=196449
498
499         Reviewed by Lucas Forschler.
500
501         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
502         (StatusBubble.get_os_details): Method to get OS and Xcode details.
503         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
504         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
505
506 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
507
508         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
509         https://bugs.webkit.org/show_bug.cgi?id=196444
510
511         Reviewed by Lucas Forschler.
512
513         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
514
515 2019-04-01  Alex Christensen  <achristensen@webkit.org>
516
517         Add SPI to canonicalize NSURLs with WTF::URL
518         https://bugs.webkit.org/show_bug.cgi?id=196415
519         <rdar://problem/44980271>
520
521         Reviewed by Darin Adler.
522
523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
524         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
525         (TestWebKitAPI::TEST):
526
527 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
528
529         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
530         https://bugs.webkit.org/show_bug.cgi?id=196441
531
532         Reviewed by Carlos Garcia Campos.
533
534         Don't cache the wpe_view_backend object that might not exist yet at the
535         time of EventSenderProxy constructor invocation, but instead retrieve
536         that object whenever it's required for event dispatching. This should
537         avoid crashes in this constructor now that it's invoked before any
538         PlatformWindow has been set up (as changed in r243496).
539
540         * WebKitTestRunner/EventSenderProxy.h:
541         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
542         (WTR::viewBackend):
543         (WTR::EventSenderProxy::EventSenderProxy):
544         (WTR::EventSenderProxy::mouseDown):
545         (WTR::EventSenderProxy::mouseUp):
546         (WTR::EventSenderProxy::mouseMoveTo):
547         (WTR::EventSenderProxy::mouseScrollBy):
548         (WTR::EventSenderProxy::keyDown):
549         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
550
551 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
552
553         [Win][WebKit] MiniBrowser should support high DPI display
554         https://bugs.webkit.org/show_bug.cgi?id=196391
555
556         Reviewed by Alex Christensen.
557
558         * MiniBrowser/win/WebKitBrowserWindow.cpp:
559         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
560         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
561         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
562
563 2019-03-31  Sam Weinig  <weinig@apple.com>
564
565         Remove more i386 specific configurations
566         https://bugs.webkit.org/show_bug.cgi?id=196430
567
568         Reviewed by Alexey Proskuryakov.
569
570         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
571         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
572
573 2019-03-31  Andy Estes  <aestes@apple.com>
574
575         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
576         https://bugs.webkit.org/show_bug.cgi?id=196433
577         <rdar://problem/49293305>
578
579         Reviewed by Tim Horton.
580
581         Enhanced API test coverage to include all navigation response policy decisions in both
582         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
583
584         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
585         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
586         (TestWebKitAPI::TEST):
587         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
588         (readFile):
589         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
590         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
591         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
592         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
593         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
594         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
595         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
596         (-[QuickLookDelegate _downloadDidStart:]):
597         (-[QuickLookDelegate _download:didReceiveResponse:]):
598         (-[QuickLookDelegate _download:didReceiveData:]):
599         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
600         (-[QuickLookDelegate _downloadDidFinish:]):
601         (-[QuickLookDelegate _download:didFailWithError:]):
602         (-[QuickLookDelegate _downloadDidCancel:]):
603         (-[QuickLookDelegate verifyDownload]):
604         (runTest):
605         (runTestDecideBeforeLoading):
606         (runTestDecideAfterLoading):
607         (TEST):
608         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
609         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
610         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
611         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
612         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
613         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
614         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
615         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
616         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
617         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
618         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
619         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
620         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
621         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
622
623 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
624
625         [CMake] add testdfg as target with build-jsc
626         https://bugs.webkit.org/show_bug.cgi?id=196393
627
628         Reviewed by Saam Barati.
629
630         Added testdfg as one of the targets to build when
631         using CMake.
632
633         * Scripts/build-jsc:
634
635 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
636
637         Delete WebMetal implementation in favor of WebGPU
638         https://bugs.webkit.org/show_bug.cgi?id=195418
639
640         Reviewed by Dean Jackson.
641
642         * DumpRenderTree/mac/DumpRenderTree.mm:
643         (enableExperimentalFeatures):
644         (resetWebPreferencesToConsistentValues):
645         * Scripts/webkitperl/FeatureList.pm:
646         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
648         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
649         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
650         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
651         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
652         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
653         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
654         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
655         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
656         (WTR::InjectedBundle::beginTesting):
657         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
658         (WTR::TestRunner::setWebMetalEnabled): Deleted.
659         * WebKitTestRunner/InjectedBundle/TestRunner.h:
660
661 2019-03-29  Chris Dumez  <cdumez@apple.com>
662
663         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
664         https://bugs.webkit.org/show_bug.cgi?id=196405
665         <rdar://problem/49428130>
666
667         Reviewed by Wenson Hsieh.
668
669         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
670         the popover presentation methods to be no-ops. Use this in the new test added in
671         r243523 so that we do not swizzle those methods for all tests. This is needed because
672         those WatchOS tests rely on the popover getting presented and interactive.
673
674         * WebKitTestRunner/TestController.cpp:
675         (WTR::updateTestOptionsFromTestHeader):
676         * WebKitTestRunner/TestController.h:
677         * WebKitTestRunner/TestOptions.h:
678         (WTR::TestOptions::hasSameInitializationOptions const):
679         * WebKitTestRunner/ios/TestControllerIOS.mm:
680         (WTR::TestController::platformInitialize):
681         (WTR::TestController::platformResetStateToConsistentValues):
682
683 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
684
685         [Curl] Add Server Trust Evaluation Support.
686         https://bugs.webkit.org/show_bug.cgi?id=191646
687
688         Reviewed by Fujii Hironori.
689
690         Implemented MiniBrowser UI for asking if user trusts the server.
691
692         * MiniBrowser/win/Common.cpp:
693         (askServerTrustEvaluation):
694         (replaceString):
695         * MiniBrowser/win/Common.h:
696         * MiniBrowser/win/MiniBrowserLib.rc:
697         * MiniBrowser/win/MiniBrowserLibResource.h:
698         * MiniBrowser/win/WebKitBrowserWindow.cpp:
699         (createPEMString):
700         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
701         (WebKitBrowserWindow::canTrustServerCertificate):
702         * MiniBrowser/win/WebKitBrowserWindow.h:
703
704 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
705
706         Implement ResizeObserver.
707         https://bugs.webkit.org/show_bug.cgi?id=157743
708
709         Reviewed by Simon Fraser.
710
711         Support resizeObserverEnabled webPreferences.
712
713         * DumpRenderTree/TestOptions.cpp:
714         (TestOptions::TestOptions):
715         * DumpRenderTree/TestOptions.h:
716         * DumpRenderTree/mac/DumpRenderTree.mm:
717         (setWebPreferencesForTestOptions):
718         * DumpRenderTree/win/DumpRenderTree.cpp:
719         (enableExperimentalFeatures):
720         * Scripts/webkitperl/FeatureList.pm:
721         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
722
723 2019-03-28  John Wilander  <wilander@apple.com>
724
725         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
726         https://bugs.webkit.org/show_bug.cgi?id=196281
727         <rdar://problem/48938748>
728
729         Reviewed by Alex Christensen.
730
731         This patch adds the function isStatisticsHasLocalStorage() to the
732         TestRunner. With it, the page can query the WebsiteDataStore in the
733         UI process to make sure that it sees LocalStorage.
734
735         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
736         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
737         (WTR::TestRunner::isStatisticsHasLocalStorage):
738         * WebKitTestRunner/InjectedBundle/TestRunner.h:
739         * WebKitTestRunner/TestController.cpp:
740         (WTR::TestController::isStatisticsHasLocalStorage):
741         * WebKitTestRunner/TestController.h:
742         * WebKitTestRunner/TestInvocation.cpp:
743         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
744
745 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
746
747         API::Data::createWithoutCopying should do a null check before calling CFRelease
748         https://bugs.webkit.org/show_bug.cgi?id=196276
749         <rdar://problem/48059859>
750
751         Reviewed by Alex Christensen.
752
753         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
754
755         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
756         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
757         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
758         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
759         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
760         (TestWebKitAPI::TEST):
761
762 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
763
764         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
765         https://bugs.webkit.org/show_bug.cgi?id=186276
766
767         Reviewed by Carlos Garcia Campos.
768
769         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
770         (webViewLoadChanged):
771         (testWebResourceGetDataError):
772         (testWebResourceGetDataEmpty):
773         (beforeAll):
774         (webViewloadChanged): Deleted.
775
776 2019-03-27  Andy Estes  <aestes@apple.com>
777
778         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
779         https://bugs.webkit.org/show_bug.cgi?id=196317
780
781         Reviewed by Dan Bernstein.
782
783         package-root copies built products into a staging directory using ditto(1), which does not
784         follow symbolic links as it traverses a directory. Now that the files in
785         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
786         itself, these become broken links when ditto'd into the staging directory.
787
788         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
789
790         * Scripts/package-root:
791
792 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
793
794         [ews-app] Update display text of Submit for ews analysis
795         https://bugs.webkit.org/show_bug.cgi?id=196309
796
797         Reviewed by Dewei Zhu.
798
799         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
800
801 2019-03-27  David Kilzer  <ddkilzer@apple.com>
802
803         run-webkit-tests should check for leaks in WebKit processes
804         <https://webkit.org/b/193772>
805         <rdar://problem/46526680>
806
807         Reviewed by Ryosuke Niwa.
808
809         This works by doing the following:
810         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
811           The list of child processes are returned one per line:
812           process.name: pid
813         - Run the "#LIST CHILD PROCESSES" command just before the
814           "#CHECK FOR WORLD LEAKS" command, and store the list of child
815           processes on the ServerProcess object.
816         - When the `--leaks` switch is handled, run check_for_leaks() on
817           each child process after the main test harness.
818
819         * DumpRenderTree/mac/DumpRenderTree.mm:
820         (handleControlCommand):
821         - Use strncmp() instead of strcmp().
822         - Add support for handling "#LIST CHILD PROCESSES" command.
823
824         * Scripts/webkitpy/port/base.py:
825         (Port.check_for_leaks):
826         * Scripts/webkitpy/port/darwin.py:
827         (DarwinPort.check_for_leaks):
828         - Rename redundant 'process_pid' argument to 'process_id'.
829
830         * Scripts/webkitpy/port/driver.py:
831         (Driver.do_post_tests_work):
832         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
833           longer the only command this sends to WebKitTestRunner.
834         - If the `--leaks` switch is present, send the
835           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
836           result using Port.set_webkit_processes().
837         (Driver._parse_child_processes_output):
838         - Add helper method to parse list of child process names and
839           process IDs returned from WebKitTestRunner.
840
841         * Scripts/webkitpy/port/ios_device.py:
842         (IOSDevicePort.check_for_leaks):
843         - Rename redundant 'process_pid' argument to 'process_id'.
844
845         * Scripts/webkitpy/port/leakdetector.py:
846         (LeakDetector._parse_leaks_output):
847         - Return early if there is no leaks_output.
848         (LeakDetector.check_for_leaks):
849         - Rename redundant 'process_pid' argument to 'process_id'.
850
851         * Scripts/webkitpy/port/server_process.py:
852         (ServerProcess.__init__):
853         (ServerProcess.child_processes):
854         (ServerProcess.set_child_processes):
855         - Add instance variable to Port to store list of child process
856           names and process IDs returned from WebKitTestRunner.
857         (ServerProcess._start):
858         - Clear self._child_processes.
859         (ServerProcess.stop):
860         - If self._child_processes is set, call
861           self._port.check_for_leaks() for each child process.
862
863         * Scripts/webkitpy/port/server_process_unittest.py:
864         (TrivialMockPort.check_for_leaks):
865         - Rename redundant 'process_pid' argument to 'process_id'.
866
867         * Scripts/webkitpy/port/simulator_process.py:
868         (SimulatorProcess.stop):
869         - If self._child_processes is set, call
870           self._port.check_for_leaks() for each child process.
871
872         * Scripts/webkitpy/port/watch_device.py:
873         (WatchDevicePort.check_for_leaks):
874         - Rename redundant 'process_pid' argument to 'process_id'.
875
876         * WebKitTestRunner/TestController.cpp:
877         (WTR::TestController::dumpResponse):
878         - Extract method from findAndDumpWorldLeaks() so that it may be
879           reused by findAndDumpWebKitProcessIdentifiers().
880         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
881         - Add method to output process name and process ID of both the
882           WebContent and Networking processes.
883         (WTR::TestController::findAndDumpWorldLeaks):
884         - Fix missing newline in output when there were no abandoned
885           documents.
886         - Call dumpResponse() for extracted code.
887         (WTR::TestController::handleControlCommand):
888         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
889         - Use strncmp() instead of strcmp().
890         - Call findAndDumpWebKitProcessIdentifiers() when
891           "#LIST CHILD PROCESSES" command is sent.
892         * WebKitTestRunner/TestController.h:
893         (WTR::TestController::dumpResponse):
894         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
895         - Declare methods.
896
897 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
898
899         Unreviewed. Add GLib API test cases after r243434.
900
901         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
902         (testWebViewActiveURI):
903         (serverCallback):
904         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
905         (sendRequestCallback):
906
907 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
908
909         Geolocation request not complete when watch request was started in a different web process
910         https://bugs.webkit.org/show_bug.cgi?id=195996
911
912         Reviewed by Alex Christensen.
913
914         Add a test case.
915
916         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
917         (TestWebKitAPI::runJavaScriptAlert):
918         (TestWebKitAPI::TEST):
919
920 2019-03-26  Keith Rollin  <krollin@apple.com>
921
922         Update the way generate-xcfilelists returns strings from functions
923         https://bugs.webkit.org/show_bug.cgi?id=195975
924         <rdar://problem/49040807>
925
926         Reviewed by Dean Jackson.
927
928         There are places where generate-xcfilelists executes assignments with
929         statements like:
930
931             FOO=$(some_function)
932
933         where "some_function" return a string by echoing it. E.g.
934
935             some_function()
936             {
937                 echo "Hello, World"
938             }
939
940         This is a common idiom, but it has a problem if "some_function" needs
941         to call "exit" in an attempt to halt the entire script right then and
942         there. Since "some_function" is called inside of $(), it's being
943         executed in a sub-shell. Calling exit in that sub-shell simply exits
944         that shell; it doesn't not exit the outer shell in which the main part
945         of the script is still running. As such, the main script keeps
946         executing when the intent was for the script to halt.
947
948         The solution to this is to use a different idiom for returning
949         strings. The one we now is to pass in the name of the variable to
950         receive the string result:
951
952             some_function()
953             {
954                 variable_name=$1
955                 eval $variable_name ="Hello, World"
956             }
957
958         The call site now looks like
959
960             some_function FOO
961
962         Because there's no invocation of a sub-shell, some_function can now
963         call "exit" if it wants to, and the entire script will exit at that
964         point.
965
966         * Scripts/generate-xcfilelists:
967
968 2019-03-26  Chris Dumez  <cdumez@apple.com>
969
970         Add basic layout test coverage for File Picker on iOS
971         https://bugs.webkit.org/show_bug.cgi?id=196265
972
973         Reviewed by Wenson Hsieh.
974
975         Add layout test infrastructure to test the file picker on iOS.
976
977         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
978         (WTR::UIScriptController::dismissFilePicker):
979         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
980         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
981         (WTR::UIScriptController::dismissFilePicker):
982         * TestRunnerShared/UIScriptContext/UIScriptController.h:
983         * WebKitTestRunner/TestController.cpp:
984         (WTR::TestController::createWebViewWithOptions):
985         (WTR::updateTestOptionsFromTestHeader):
986         * WebKitTestRunner/TestOptions.h:
987         (WTR::TestOptions::hasSameInitializationOptions const):
988         * WebKitTestRunner/ios/TestControllerIOS.mm:
989         (overridePresentViewController):
990         (WTR::TestController::platformInitialize):
991         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
992         (WTR::UIScriptController::dismissFilePicker):
993
994 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
995
996         Implement async paste method on UIWKInteractionViewProtocol
997         https://bugs.webkit.org/show_bug.cgi?id=196267
998         <rdar://problem/49236346>
999
1000         Reviewed by Tim Horton.
1001
1002         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1003         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1004         are now a part of all iOS 12 internal SDKs.
1005
1006         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1007
1008         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1009         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1010
1011         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1012         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1013         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1014         * TestWebKitAPI/ios/UIKitSPI.h:
1015
1016 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1017
1018         [ews-build] Use PostgreSQL for ews.webkit.org database
1019         https://bugs.webkit.org/show_bug.cgi?id=196270
1020
1021         Reviewed by Lucas Forschler.
1022
1023         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1024
1025 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1026
1027         [ews] Reset simctl states on reboot
1028         https://bugs.webkit.org/show_bug.cgi?id=196260
1029
1030         Rubber-stamped by Aakash Jain.
1031
1032         * EWSTools/start-queue-mac.sh:
1033
1034 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1035
1036         [ews-build] Use PostgreSQL for ews-build database
1037         https://bugs.webkit.org/show_bug.cgi?id=196229
1038
1039         Reviewed by Lucas Forschler.
1040
1041         * BuildSlaveSupport/ews-build/master.cfg:
1042
1043 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1044
1045         [ews-build] Get master_hostname dynamically in master.cfg
1046         https://bugs.webkit.org/show_bug.cgi?id=196255
1047
1048         Reviewed by Lucas Forschler.
1049
1050         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1051         send events data in test mode.
1052
1053 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1054
1055         [ews-app] Set db_constraint to False for Foreign Keys
1056         https://bugs.webkit.org/show_bug.cgi?id=196252
1057
1058         Reviewed by Lucas Forschler.
1059
1060         * BuildSlaveSupport/ews-app/ews/models/build.py:
1061         * BuildSlaveSupport/ews-app/ews/models/step.py:
1062
1063 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1064
1065         [ews-build] is_test_mode_enabled should default to True
1066         https://bugs.webkit.org/show_bug.cgi?id=196248
1067
1068         Reviewed by Lucas Forschler.
1069
1070         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1071
1072 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1073
1074         [ews-app] Add webkitperl to ENABLED_QUEUES
1075         https://bugs.webkit.org/show_bug.cgi?id=196253
1076
1077         Reviewed by Lucas Forschler.
1078
1079         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1080
1081 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1082
1083         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1084         https://bugs.webkit.org/show_bug.cgi?id=196211
1085         rdar://problem/49110552
1086
1087         Reviewed by Tim Horton.
1088
1089         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1090         Make sure that EventSenderProxy always exists when running tests. We used to create
1091         it when resetting before the first test, which is a bit too late.
1092
1093         * WebKitTestRunner/TestController.h:
1094         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1095         (WTR::TestController::platformCreateWebView):
1096         (WTR::TestController::platformCreateOtherPage):
1097         (WTR::TestController::finishCreatingPlatformWebView):
1098         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1099         (WTR::PlatformWebView::PlatformWebView):
1100         Moved some code that made NSWindow use NSEvent during web view creation. We may
1101         need to move more if some other case us found, but this is enough for now.
1102
1103 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1104
1105         Unreviewed. Fix typo in GLib geolocation API after r243285.
1106
1107         gelocation -> geolocation.
1108
1109         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1110         (testGeolocationManagerWatchPosition):
1111
1112 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1113
1114         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1115         https://bugs.webkit.org/show_bug.cgi?id=196213
1116
1117         Reviewed by Geoff Garen.
1118
1119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1120         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1121         (credentialWithIdentityAndKeychainPath):
1122         (-[ChallengeDelegate webView:didFinishNavigation:]):
1123         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1124         (TestWebKitAPI::TEST):
1125
1126 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1127
1128         Expected shouldn't assume its contained types are copyable
1129         https://bugs.webkit.org/show_bug.cgi?id=195986
1130
1131         Reviewed by JF Bastien.
1132
1133         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1134         (TestWebKitAPI::NonCopyable::operator== const):
1135         (TestWebKitAPI::NonCopyable::operator!= const):
1136         (TestWebKitAPI::TEST):
1137
1138 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1139
1140         Remove some now-unnecessary dynamic class lookup
1141         https://bugs.webkit.org/show_bug.cgi?id=196237
1142
1143         Reviewed by Simon Fraser.
1144
1145         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1146         (makeRequest):
1147         (TEST):
1148
1149 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1150
1151         Unreviewed, rolling out r243450.
1152
1153         AppleWin and WinCairo port builds get broken.
1154
1155         Reverted changeset:
1156
1157         "Add test for fix of #196095"
1158         https://bugs.webkit.org/show_bug.cgi?id=196097
1159         https://trac.webkit.org/changeset/243450
1160
1161 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1162
1163         Unreviewed, rolling out r243465.
1164         https://bugs.webkit.org/show_bug.cgi?id=196226
1165
1166         the test doesn't build (Requested by thorton on #webkit).
1167
1168         Reverted changeset:
1169
1170         "Do not terminate the NetworkProcess if a third party
1171         application sends a NSCredential with a SecIdentityRef"
1172         https://bugs.webkit.org/show_bug.cgi?id=196213
1173         https://trac.webkit.org/changeset/243465
1174
1175 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1176
1177         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1178         https://bugs.webkit.org/show_bug.cgi?id=196213
1179
1180         Reviewed by Geoff Garen.
1181
1182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1183         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1184         (credentialWithIdentityAndKeychainPath):
1185         (-[ChallengeDelegate webView:didFinishNavigation:]):
1186         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1187         (TestWebKitAPI::TEST):
1188
1189 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1190
1191         [ews-build] Gracefully handle missing patch_id in events
1192         https://bugs.webkit.org/show_bug.cgi?id=196216
1193
1194         Reviewed by Lucas Forschler.
1195
1196         * BuildSlaveSupport/ews-build/events.py:
1197
1198 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1199
1200         [ews-build] use lz4 compression for improving buildbot performance
1201         https://bugs.webkit.org/show_bug.cgi?id=196155
1202
1203         Reviewed by Lucas Forschler.
1204
1205         * BuildSlaveSupport/ews-build/master.cfg:
1206
1207 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1208
1209         Pull some API testing helper methods out of TestWKWebView
1210         https://bugs.webkit.org/show_bug.cgi?id=196212
1211
1212         Reviewed by Tim Horton.
1213
1214         Refactor some more API testing utility methods, so that they can be used in
1215         tests that do not use TestWKWebView.
1216
1217         * TestWebKitAPI/cocoa/TestWKWebView.h:
1218         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1219         (-[WKWebView loadTestPageNamed:]):
1220         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1221         (-[WKWebView synchronouslyLoadHTMLString:]):
1222         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1223         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1224         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1225         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1226         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1227
1228 2019-03-25  Jer Noble  <jer.noble@apple.com>
1229
1230         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1231         https://bugs.webkit.org/show_bug.cgi?id=196097
1232
1233         Reviewed by Eric Carlson.
1234
1235         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1236
1237         * DumpRenderTree/mac/DumpRenderTree.mm:
1238         (resetWebPreferencesToConsistentValues):
1239         * WebKitTestRunner/TestController.cpp:
1240         (WTR::TestController::resetPreferencesToConsistentValues):
1241
1242 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1243
1244         Pull IPadUserInterfaceSwizzler out into a separate header file
1245         https://bugs.webkit.org/show_bug.cgi?id=196193
1246
1247         Reviewed by Anders Carlsson.
1248
1249         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1250         be used in other API tests.
1251
1252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1253         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1254         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1255         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1256         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1257         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1258         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1259
1260 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1261
1262         Remove NavigatorContentUtils in WebCore/Modules
1263         https://bugs.webkit.org/show_bug.cgi?id=196070
1264
1265         Reviewed by Alex Christensen.
1266
1267         NavigatorContentUtils was to support the custom scheme spec [1].
1268         However, in WebKit side, no port has supported the feature in
1269         WebKit layer after EFL port was removed. So there has been the
1270         only IDL implementation of the NavigatorContentUtils in WebCore.
1271         So we don't need to keep the implementation in WebCore anymore.
1272
1273         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1274
1275         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1276
1277 2019-03-24  Andy Estes  <aestes@apple.com>
1278
1279         [watchOS] Remove unused Proximity Networking code
1280         https://bugs.webkit.org/show_bug.cgi?id=196188
1281
1282         Reviewed by Tim Horton.
1283
1284         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1285         (TEST):
1286
1287 2019-03-23  Keith Miller  <keith_miller@apple.com>
1288
1289         Refactor clz/ctz and fix getLSBSet.
1290         https://bugs.webkit.org/show_bug.cgi?id=196162
1291
1292         Reviewed by Saam Barati.
1293
1294         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1295
1296         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1297         (TestWebKitAPI::TEST):
1298
1299 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1300
1301         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1302         https://bugs.webkit.org/show_bug.cgi?id=196143
1303
1304         Reviewed by Michael Catanzaro.
1305
1306         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1307         directories.
1308
1309         * Scripts/webkitpy/style/checkers/cpp.py:
1310         (check_identifier_name_in_declaration):
1311         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1312         (WebKitStyleTest.test_names):
1313
1314 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1315
1316         [Flatpak] Manifest expanding fails for qt WPE extension
1317         https://bugs.webkit.org/show_bug.cgi?id=196148
1318
1319         Reviewed by Alex Christensen.
1320
1321         * flatpak/flatpakutils.py:
1322         (expand_submodules_recurse): The last recurse manifest expand
1323         iteration might lead to a single module so take it into account
1324         and don't try to recurse further.
1325
1326 2019-03-22  Chris Dumez  <cdumez@apple.com>
1327
1328         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1329         https://bugs.webkit.org/show_bug.cgi?id=195348
1330         <rdar://problem/48622090>
1331
1332         Reviewed by Alex Christensen.
1333
1334         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1335         to NO when test.options().shouldIgnoreMetaViewport is false.
1336
1337         * WebKitTestRunner/ios/TestControllerIOS.mm:
1338         (WTR::TestController::platformConfigureViewForTest):
1339
1340 2019-03-22  Chris Dumez  <cdumez@apple.com>
1341
1342         Prewarmed processes should be usable with any website data store
1343         https://bugs.webkit.org/show_bug.cgi?id=196104
1344
1345         Reviewed by Alex Christensen.
1346
1347         Add API test coverage.
1348
1349         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1350         (runInitialWarmedProcessUsedTest):
1351         (TEST):
1352
1353 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1354
1355         Back out local changes to Alex's Subversion working directory
1356
1357         They were accidentally committed.
1358
1359         * Scripts/webkitpy/common/system/abstractexecutive.py:
1360         (AbstractExecutive.wait_newest):
1361         * Scripts/webkitpy/common/system/executive.py:
1362         (Executive.running_pids):
1363         * Scripts/webkitpy/common/system/executive_mock.py:
1364         (MockExecutive.running_pids):
1365         * Scripts/webkitpy/common/system/executive_unittest.py:
1366         (ExecutiveTest.serial_test_running_pids):
1367         * Scripts/webkitpy/port/darwin.py:
1368         (DarwinPort.check_for_leaks):
1369         * Scripts/webkitpy/port/leakdetector.py:
1370         (LeakDetector.check_for_leaks):
1371         - This was the hack attached to Bug 193772.
1372
1373         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1374         (+[WebKitTestRunnerEvent mouseLocation]):
1375         - This works around a crash on an internal build.
1376
1377 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1378
1379         Fix the build after r243354
1380         https://bugs.webkit.org/show_bug.cgi?id=196138
1381         <rdar://problem/49145951>
1382
1383         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1384         (TEST):
1385         * TestWebKitAPI/ios/UIKitSPI.h:
1386
1387 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1388
1389         Adopt UIWKDocumentContext
1390         https://bugs.webkit.org/show_bug.cgi?id=196040
1391         <rdar://problem/48642440>
1392
1393         Reviewed by Ryosuke Niwa.
1394
1395         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1396         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1397         (makeRequest):
1398         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1399         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1400         (applyStyle):
1401         (TEST):
1402         Add tests for UIWKDocumentContext.
1403
1404         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1405         (TEST):
1406         (recursiveFindWKContentView): Deleted.
1407         * TestWebKitAPI/cocoa/TestWKWebView.h:
1408         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1409         (recursiveFindWKContentView):
1410         (-[TestWKWebView wkContentView]):
1411         * TestWebKitAPI/ios/UIKitSPI.h:
1412         Share the WKContentView finding code between tests.
1413
1414 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1415
1416         [iOS WK2] Turn on async overflow scrolling by default
1417         https://bugs.webkit.org/show_bug.cgi?id=196011
1418         rdar://problem/48453859
1419
1420         Reviewed by Antti Koivisto.
1421         
1422         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1423         since so many basic layout tests have different results when compositing is triggered for
1424         overflow.
1425         
1426         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1427
1428         * WebKitTestRunner/TestController.cpp:
1429         (WTR::TestController::resetPreferencesToConsistentValues):
1430
1431 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1432
1433         [ews-build] Retry API test in case of failures
1434         https://bugs.webkit.org/show_bug.cgi?id=196004
1435
1436         Reviewed by Lucas Forschler.
1437
1438         * BuildSlaveSupport/ews-build/steps.py:
1439         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1440         (CompileWebKitToT.doStepIf): Ditto.
1441         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1442         (ReRunAPITests): Re-run API tests.
1443         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1444         (RunAPITestsWithoutPatch): Run API tests without patch.
1445         (RunAPITestsWithoutPatch.doStepIf):
1446         (RunAPITestsWithoutPatch.hideStepIf):
1447         (RunAPITestsWithoutPatch.evaluateCommand):
1448         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1449         (AnalyzeAPITestsResults.start):
1450         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1451         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1452         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1453         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1454
1455 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1456
1457         [ews-build] Update queues configurations
1458         https://bugs.webkit.org/show_bug.cgi?id=196074
1459
1460         Reviewed by Dewei Zhu.
1461
1462         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1463         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1464
1465 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1466
1467         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1468         https://bugs.webkit.org/show_bug.cgi?id=195680
1469         <rdar://problem/48903534>
1470
1471         Unreviewed infrastructure fix.
1472
1473         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1474         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1475
1476 2019-03-21  Andy Estes  <aestes@apple.com>
1477
1478         [iOS] Apple Pay should be available in documents with no user agent scripts
1479         https://bugs.webkit.org/show_bug.cgi?id=196061
1480         <rdar://problem/48649391>
1481
1482         Reviewed by Brady Eidson.
1483
1484         Added API tests and related infrastructure.
1485
1486         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1487         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1488         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1489         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1490         (TestWebKitAPI::TEST):
1491         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1492         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1493         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1494         * TestWebKitAPI/cocoa/TestProtocol.mm:
1495         (-[TestProtocol startLoading]):
1496         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1497         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1498         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1499         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1500
1501 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1502
1503         REGRESSSION (r243297): webkitpy tests broken
1504         https://bugs.webkit.org/show_bug.cgi?id=196108
1505
1506         Reviewed by Aakash Jain.
1507
1508         r243297 updated contributors.json, which broke a few unit tests.
1509
1510         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1511         (IRCCommandTest.test_whois):
1512         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1513
1514 2019-03-21  Chris Dumez  <cdumez@apple.com>
1515
1516         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1517         https://bugs.webkit.org/show_bug.cgi?id=196041
1518         <rdar://problem/49083230>
1519
1520         Reviewed by Alex Christensen.
1521
1522         Add API test coverage.
1523
1524         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1525         (TEST):
1526
1527 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1528
1529         Add SPI to inform applications of WKContentRuleList actions
1530         https://bugs.webkit.org/show_bug.cgi?id=195965
1531         <rdar://problem/42664365>
1532
1533         Reviewed by Geoff Garen.
1534
1535         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1536         (TestWebKitAPI::allActionsForResourceLoad):
1537         (TestWebKitAPI::testRequest):
1538         (TestWebKitAPI::TEST_F):
1539         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1540         (Notification::description):
1541         (Notification::operator== const):
1542         (toVector):
1543         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1544         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1545         (makeContentRuleList):
1546         (TEST):
1547         (makeWarnContentRuleList): Deleted.
1548
1549 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1550
1551         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1552         https://bugs.webkit.org/show_bug.cgi?id=196088
1553
1554         Reviewed by Brian Burg.
1555
1556         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1557         Support checks when only one platform is specified. Also deprecate macosx() and
1558         force the use of macos() instead.
1559
1560         * Scripts/webkitpy/style/checkers/cpp.py:
1561         (check_min_versions_of_wk_api_available):
1562         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1563         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1564
1565 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1566
1567         Update status inactive committers' status to 'contributor'.
1568
1569         * Scripts/webkitpy/common/config/contributors.json:
1570
1571 2019-03-21  Xan Lopez  <xan@igalia.com>
1572
1573         [JSC][x86] Drop support for x87 floating point
1574         https://bugs.webkit.org/show_bug.cgi?id=194853
1575
1576         Reviewed by Don Olmstead.
1577
1578         Force SSE2 on x86/32bit builds.
1579
1580         * Scripts/webkitdirs.pm:
1581         (generateBuildSystemFromCMakeProject):
1582
1583 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1584
1585         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1586         https://bugs.webkit.org/show_bug.cgi?id=196073
1587
1588         Reviewed by Michael Catanzaro.
1589
1590         Add test cases to check functions and constructors with no arguments but receiving user data.
1591
1592         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1593         (checkUserData):
1594         (testJSCFunction):
1595         (fooCreateWithUserData):
1596         (testJSCClass):
1597
1598 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1599
1600         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1601
1602         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1603
1604         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1605
1606 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1607
1608         [GTK][WPE] Add API to provide geolocation information
1609         https://bugs.webkit.org/show_bug.cgi?id=195940
1610
1611         Reviewed by Michael Catanzaro.
1612
1613         Add a new test to check the new API.
1614
1615         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1616         (testGeolocationManagerCurrentPosition):
1617         (testGeolocationManagerWatchPosition):
1618         (beforeAll):
1619         (afterAll):
1620         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1621         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1622         (beforeAll): Ditto.
1623         * TestWebKitAPI/glib/CMakeLists.txt:
1624
1625 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1626
1627         [GLib] Returning G_TYPE_OBJECT from a method does not work
1628         https://bugs.webkit.org/show_bug.cgi?id=195574
1629
1630         Reviewed by Michael Catanzaro.
1631
1632         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1633
1634         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1635         (getGFile):
1636         (getParent):
1637         (createGString):
1638         (getGString):
1639         (getGStringCopyWillRaise):
1640         (getGStringCopy):
1641         (getGStringStr):
1642         (getGStringLen):
1643         (freeGString):
1644         (testJSCClass):
1645
1646 2019-03-20  Saam Barati  <sbarati@apple.com>
1647
1648         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1649         https://bugs.webkit.org/show_bug.cgi?id=195721
1650
1651         Reviewed by Filip Pizlo.
1652
1653         * Scripts/run-javascriptcore-tests:
1654
1655 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1656
1657         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1658         https://bugs.webkit.org/show_bug.cgi?id=196049
1659
1660         Reviewed by Tim Horton.
1661
1662         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1663         overflow scrolling in general, so rename it.
1664
1665         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1666
1667 2019-03-20  Daniel Bates  <dabates@apple.com>
1668
1669         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1670         https://bugs.webkit.org/show_bug.cgi?id=196031
1671         <rdar://problem/49078172>
1672
1673         Reviewed by Tim Horton.
1674
1675         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1676         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1677         same code path used when the Done button is pressed to dismiss the <select> picker.
1678
1679         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1680         (TestWebKitAPI::TEST):
1681
1682 2019-03-20  Chris Dumez  <cdumez@apple.com>
1683
1684         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1685         https://bugs.webkit.org/show_bug.cgi?id=196029
1686         <rdar://problem/48954651>
1687
1688         Reviewed by Tim Horton.
1689
1690         Add API test coverage.
1691
1692         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1693
1694 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1695
1696         [ews-build] Improve failure summary string for ApplyPatch step
1697         https://bugs.webkit.org/show_bug.cgi?id=195995
1698
1699         Reviewed by Alexey Proskuryakov.
1700
1701         * BuildSlaveSupport/ews-build/steps.py:
1702         (ApplyPatch.getResultSummary): Override getResultSummary.
1703
1704 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1705
1706         AX: Implement support for new meter ARIA role
1707         https://bugs.webkit.org/show_bug.cgi?id=195966
1708
1709         Reviewed by Chris Fleizach.
1710
1711         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1712         to AXLevelIndicator.
1713
1714         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1715
1716 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1717
1718         [WebAuthN] Implement FIDO AppID extension
1719         https://bugs.webkit.org/show_bug.cgi?id=143491
1720         <rdar://problem/48298273>
1721
1722         Reviewed by Brent Fulgham.
1723
1724         Add a test that covers the new flag of convertToU2fSignCommand.
1725
1726         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1727         (TestWebKitAPI::TEST):
1728         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1729         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1730         (TestWebKitAPI::TEST):
1731
1732 2019-03-19  Keith Rollin  <krollin@apple.com>
1733
1734         Add support for more platforms to generate-xcfilelists
1735         https://bugs.webkit.org/show_bug.cgi?id=195977
1736
1737         Reviewed by Alexey Proskuryakov.
1738
1739         generate-xcfilelists incorrectly complains when involved with building
1740         WebKit for iphonesimulator:
1741
1742             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1743             …
1744             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1745
1746         Address this by teaching generate-xcfilelists about more platforms.
1747
1748         * Scripts/generate-xcfilelists:
1749
1750 2019-03-19  John Wilander  <wilander@apple.com>
1751
1752         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1753         https://bugs.webkit.org/show_bug.cgi?id=195923
1754         <rdar://problem/49001272>
1755
1756         Reviewed by Alex Christensen.
1757
1758         This patch does the following to the TestRunner:
1759         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1760         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1761         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1762
1763         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1764         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1765         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1766         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1767         * WebKitTestRunner/TestController.cpp:
1768         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1769         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1770         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1771         * WebKitTestRunner/TestController.h:
1772         * WebKitTestRunner/TestInvocation.cpp:
1773         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1774
1775 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1776
1777         [CMake] Support more clang and gcc sanitizers
1778         https://bugs.webkit.org/show_bug.cgi?id=195956
1779
1780         Reviewed by Michael Catanzaro.
1781
1782         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1783
1784 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1785
1786         [ews-build] Improve summary for PrintConfiguration step
1787         https://bugs.webkit.org/show_bug.cgi?id=195945
1788
1789         Reviewed by Lucas Forschler.
1790
1791         * BuildSlaveSupport/ews-build/steps.py:
1792         (PrintConfiguration.getResultSummary): Override getResultSummary.
1793
1794 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1795
1796         [ews-build] Improve summary for CheckOutSource step
1797         https://bugs.webkit.org/show_bug.cgi?id=195963
1798
1799         Reviewed by Lucas Forschler.
1800
1801         * BuildSlaveSupport/ews-build/steps.py:
1802         (CheckOutSource.getResultSummary):
1803
1804 2019-03-19  Daniel Bates  <dabates@apple.com>
1805
1806         [iOS] Focus not preserved when switching between tabs
1807         https://bugs.webkit.org/show_bug.cgi?id=195820
1808         <rdar://problem/43614450>
1809
1810         Reviewed by Brent Fulgham.
1811
1812         Add tests to ensure that we restore focus when resigning and becoming first responder.
1813
1814         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1815         (TestWebKitAPI::TEST):
1816
1817 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1818
1819         Make WTFLogChannelState and WTFLogLevel enum classes
1820         https://bugs.webkit.org/show_bug.cgi?id=195904
1821
1822         Reviewed by Eric Carlson.
1823
1824         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1825         (TestWebKitAPI::TEST_F):
1826
1827 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1828
1829         [GStreamer][EME] Backported mssdemux protection data crash fix
1830         https://bugs.webkit.org/show_bug.cgi?id=195918
1831
1832         Reviewed by Philippe Normand.
1833
1834         * gstreamer/jhbuild.modules:
1835         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1836
1837 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1838
1839         Unreviewed, rolling out r243132.
1840
1841         Broke GTK build
1842
1843         Reverted changeset:
1844
1845         "Make WTFLogChannelState and WTFLogLevel enum classes"
1846         https://bugs.webkit.org/show_bug.cgi?id=195904
1847         https://trac.webkit.org/changeset/243132
1848
1849 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1850
1851         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1852
1853         * Scripts/webkitdirs.pm:
1854         (builtDylibPathForName): Adjust the shared library name that's changed
1855         with the API version bump in r243073.
1856
1857 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1858
1859         Make WTFLogChannelState and WTFLogLevel enum classes
1860         https://bugs.webkit.org/show_bug.cgi?id=195904
1861
1862         Reviewed by Eric Carlson.
1863
1864         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1865         (TestWebKitAPI::TEST_F):
1866
1867 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1868
1869         Disable flaky test added in r2431100
1870         https://webkit.org/b/195785
1871
1872         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1873         (TestWebKitAPI::TEST):
1874         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1875
1876 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1877
1878         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1879         https://bugs.webkit.org/show_bug.cgi?id=195916
1880
1881         Reviewed by Tim Horton.
1882
1883         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1884         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1885
1886 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1887
1888         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1889
1890         * Scripts/webkitpy/common/config/contributors.json:
1891
1892 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1893
1894         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1895         https://bugs.webkit.org/show_bug.cgi?id=195785
1896
1897         Reviewed by Geoffrey Garen.
1898
1899         * TestWebKitAPI/TCPServer.cpp: Added.
1900         (TestWebKitAPI::TCPServer::TCPServer):
1901         (TestWebKitAPI::TCPServer::~TCPServer):
1902         (TestWebKitAPI::TCPServer::socketBindListen):
1903         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1904         * TestWebKitAPI/TCPServer.h: Added.
1905         (TestWebKitAPI::TCPServer::port const):
1906         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1907         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1908         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1909         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1910         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1911         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1912         (TestWebKitAPI::respondSlowly):
1913         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1914         (TestWebKitAPI::downloadAtRate):
1915         (TestWebKitAPI::TEST):
1916
1917 2019-03-18  Saam Barati  <sbarati@apple.com>
1918
1919         Add a plan file for JetStream 2
1920         https://bugs.webkit.org/show_bug.cgi?id=190734
1921
1922         Reviewed by Mark Lam.
1923
1924         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1925
1926 2019-03-18  Chris Dumez  <cdumez@apple.com>
1927
1928         Delay WebProcess launch until a load is triggered in a Web view
1929         https://bugs.webkit.org/show_bug.cgi?id=195758
1930         <rdar://problem/48126013>
1931
1932         Reviewed by Geoff Garen.
1933
1934         Add API test coverage. Also update some existing API tests to not expect
1935         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1936
1937         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1938         (TestWebKitAPI::TEST):
1939         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1940         (TestWebKitAPI::TEST):
1941         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1942         (TEST):
1943         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1944         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1945         (TEST):
1946         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1947         (TEST):
1948         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1949
1950 2019-03-18  Xan Lopez  <xan@igalia.com>
1951
1952         [CMake] Prevent potential warning when determining $architecture
1953         https://bugs.webkit.org/show_bug.cgi?id=195891
1954
1955         Reviewed by Michael Catanzaro.
1956
1957         It's possible for generateBuildSystemForCMakeProject to be called
1958         before determineArchitecture() is ever called. This will make the
1959         first eq check with $architecture to be bogus (and print a
1960         warning). Change that to an eq check with architecture(), which
1961         implicitly calls determineArchitecture() if needed, and change all
1962         the other similar cases in the method in the same way to prevent
1963         future bugs like this one.
1964
1965         * Scripts/webkitdirs.pm:
1966         (generateBuildSystemFromCMakeProject):
1967
1968 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1969
1970         [WPE] Tarballs generated with “make dist” cannot build documentation
1971         https://bugs.webkit.org/show_bug.cgi?id=195885
1972
1973         Reviewed by Carlos Garcia Campos.
1974
1975         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1976
1977 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1978
1979         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1980         https://bugs.webkit.org/show_bug.cgi?id=195883
1981
1982         Reviewed by Carlos Garcia Campos.
1983
1984         * gtkdoc/gtkdoc.py:
1985         (GTKDoc._run_command): When commands fail to run, include the full command line for
1986         the program invocation and the output it has generated on the standard error stream.
1987
1988 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1989
1990         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1991         https://bugs.webkit.org/show_bug.cgi?id=195786
1992
1993         Reviewed by Philippe Normand.
1994
1995         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1996         * wpe/jhbuild.modules: Ditto.
1997
1998 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1999
2000         [ews-build] Don't run clean builds on EWS builders
2001         https://bugs.webkit.org/show_bug.cgi?id=195851
2002
2003         Reviewed by Geoffrey Garen.
2004
2005         * BuildSlaveSupport/ews-build/factories.py:
2006
2007 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2008
2009         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2010         https://bugs.webkit.org/show_bug.cgi?id=195849
2011
2012         Reviewed by Chris Dumez.
2013
2014         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2015
2016         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2017         (runWebsiteDataStoreCustomPaths):
2018
2019 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2020
2021         webkitpy: Upload test results
2022         https://bugs.webkit.org/show_bug.cgi?id=195755
2023         <rdar://problem/48896182>
2024
2025         Reviewed by Aakash Jain.
2026
2027         Establish a new format for uploading results that is not tied to layout tests, apply
2028         that format to webkitpy tests.
2029
2030         * Scripts/webkitpy/common/checkout/scm/git.py:
2031         (Git.native_branch): Return what branch the current checkout is on.
2032         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2033         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2034         * Scripts/webkitpy/common/checkout/scm/svn.py:
2035         (SVN.native_branch): Ditto.
2036         * Scripts/webkitpy/common/system/platforminfo.py:
2037         (PlatformInfo.build_version): Return a build version for Mac.
2038         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2039         (MockPlatformInfo.__init__):
2040         (MockPlatformInfo.build_version):
2041         * Scripts/webkitpy/results: Added.
2042         * Scripts/webkitpy/results/__init__.py: Added.
2043         * Scripts/webkitpy/results/options.py: Added.
2044         (upload_options): OptParse list for upload options.
2045         * Scripts/webkitpy/results/upload.py: Added.
2046         (Upload): Class which enforces the upload format expected by the results server.
2047         (Upload.Expectations):
2048         (Upload.create_configuration):
2049         (Upload.create_commit):
2050         (Upload.create_details):
2051         (Upload.create_run_stats):
2052         (Upload.create_test_result):
2053         (Upload.__init__):
2054         (Upload.Encoder): Encode Upload object as json.
2055         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2056         * Scripts/webkitpy/results/upload_unittest.py: Added.
2057         * Scripts/webkitpy/test/main.py:
2058         (Tester._parse_args): Add upload arguments.
2059         (Tester._run_tests): Allow results to be uploaded.
2060         * Scripts/webkitpy/test/runner.py:
2061         (Runner.__init__): Record which tests were run, rather than just counting them.
2062         (Runner.handle):
2063         * Scripts/webkitpy/test/runner_unittest.py:
2064         (RunnerTest.test_run):
2065         * Scripts/webkitpy/thirdparty/__init__.py:
2066         (AutoinstallImportHook.find_module): Add requests auto-install.
2067         (AutoinstallImportHook._install_requests):
2068         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2069         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2070
2071 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2072
2073         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2074         https://bugs.webkit.org/show_bug.cgi?id=195810
2075
2076         Reviewed by Tim Horton.
2077
2078         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2079         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2080         ending certain layout tests.
2081
2082         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2083         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2084         (-[TestRunnerWKWebView dealloc]):
2085         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2086
2087         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2088         helper method when destroying the web view, and when resetting state between tests.
2089
2090         * WebKitTestRunner/ios/TestControllerIOS.mm:
2091         (WTR::TestController::platformResetStateToConsistentValues):
2092
2093         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2094
2095 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2096
2097         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2098         https://bugs.webkit.org/show_bug.cgi?id=190350
2099         <rdar://problem/45089503>
2100
2101         Reviewed by Geoffrey Garen.
2102
2103         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2104         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2105         (TEST):
2106         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2107         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2108         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2109         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2110         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2111         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2112         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2113         (runTest):
2114         (createDirectories):
2115         (TEST):
2116         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2117         (TEST):
2118         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2119         (TEST):
2120
2121 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2122
2123         Add support to WebPage for getting the contents as an attributed string.
2124         https://bugs.webkit.org/show_bug.cgi?id=195636
2125         rdar://problem/45055697
2126
2127         Reviewed by Tim Horton.
2128
2129         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2130         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2131
2132 2019-03-15  Chris Dumez  <cdumez@apple.com>
2133
2134         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2135         https://bugs.webkit.org/show_bug.cgi?id=195747
2136
2137         Reviewed by Geoff Garen.
2138
2139         Add API test coverage.
2140
2141         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2142
2143 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2144
2145         Unreviewed, rolling out r242952.
2146
2147         Causing API failures on iOS Simulator
2148
2149         Reverted changeset:
2150
2151         "[PSON] Make sure the WebProcessCache is leverage when
2152         relaunching a process after termination"
2153         https://bugs.webkit.org/show_bug.cgi?id=195747
2154         https://trac.webkit.org/changeset/242952
2155
2156 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2157
2158         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2159         https://bugs.webkit.org/show_bug.cgi?id=195740
2160
2161         Reviewed by Ross Kirsling.
2162
2163         window.open doesn't work for WebKitBrowserWindow because it is not
2164         implemented yet.
2165
2166         1. Implemented createNewPage callback of WKPageUIClient.
2167         2. Changed MainWindow to take a BrowserWindow factory function
2168           instead of BrowserWindowType to be flexible to create
2169           BrowserWindow with extra settings.
2170         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2171           because it is not relevant with MainWindow anymore.
2172
2173         * MiniBrowser/win/Common.cpp:
2174         (parseCommandLine):
2175         * MiniBrowser/win/Common.h:
2176         (CommandLineOptions::CommandLineOptions):
2177         * MiniBrowser/win/MainWindow.cpp:
2178         (MainWindow::MainWindow):
2179         (MainWindow::create):
2180         (MainWindow::init):
2181         (MainWindow::WndProc):
2182         * MiniBrowser/win/MainWindow.h:
2183         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2184         (PrintWebUIDelegate::createWebViewWithRequest):
2185         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2186         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2187         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2188         (WebKitBrowserWindow::updateProxySettings):
2189         (WebKitBrowserWindow::createNewPage):
2190         * MiniBrowser/win/WebKitBrowserWindow.h:
2191         * MiniBrowser/win/WinMain.cpp:
2192         (wWinMain):
2193
2194 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2195
2196         Make it possible to test scrolling tree layer manipulation more easily
2197         https://bugs.webkit.org/show_bug.cgi?id=195780
2198
2199         Reviewed by Tim Horton.
2200         
2201         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2202         cuts off communication of scrolling tree scrolls back to the web process
2203         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2204         allows tests to trigger scrolls which run the scrolling tree layer positioning
2205         logic, but never get another commit from the web process that might mask
2206         scrolling tree bugs.
2207         
2208         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2209         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2210         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2211
2212         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2213         (WTR::UIScriptController::scrollUpdatesDisabled const):
2214         (WTR::UIScriptController::setScrollUpdatesDisabled):
2215         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2216         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2217         (WTR::UIScriptController::scrollUpdatesDisabled const):
2218         (WTR::UIScriptController::setScrollUpdatesDisabled):
2219         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2220         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2221         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2222         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2223         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2224         * WebKitTestRunner/ios/TestControllerIOS.mm:
2225         (WTR::TestController::platformResetStateToConsistentValues):
2226         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2227         (WTR::UIScriptController::scrollUpdatesDisabled const):
2228         (WTR::UIScriptController::setScrollUpdatesDisabled):
2229
2230 2019-03-14  Youenn Fablet  <youenn@apple.com>
2231
2232         Move IDB storage in private browsing mode to NetworkProcess
2233         https://bugs.webkit.org/show_bug.cgi?id=195602
2234
2235         Reviewed by Brady Eidson.
2236
2237         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2238         (TEST):
2239
2240 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2241
2242         [ews-build] Make descriptionDone messages more readable
2243         https://bugs.webkit.org/show_bug.cgi?id=195760
2244
2245         Reviewed by Lucas Forschler.
2246
2247         * BuildSlaveSupport/ews-build/steps.py:
2248         * BuildSlaveSupport/ews-build/steps_unittest.py:
2249
2250 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2251
2252         [ews-build] Generate status-bubble hover-over messages
2253         https://bugs.webkit.org/show_bug.cgi?id=195680
2254
2255         Reviewed by Lucas Forschler.
2256
2257         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2258         (StatusBubble):
2259         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2260         on hover-over.
2261         (StatusBubble._iso_time):
2262         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2263         hover-over message.
2264         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2265
2266 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2267
2268         [ews-app] Gracefully handle the case when state_string is None
2269         https://bugs.webkit.org/show_bug.cgi?id=195753
2270
2271         Reviewed by Lucas Forschler.
2272
2273         * BuildSlaveSupport/ews-app/ews/models/build.py:
2274         * BuildSlaveSupport/ews-app/ews/models/step.py:
2275
2276 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2277
2278         [ews-app] Status bubble display pending for currently running build step
2279         https://bugs.webkit.org/show_bug.cgi?id=195744
2280
2281         Reviewed by Lucas Forschler.
2282
2283         * BuildSlaveSupport/ews-build/events.py:
2284         (Events.stepStarted): If state_string is pending, replace it with step name.
2285
2286 2019-03-14  Chris Dumez  <cdumez@apple.com>
2287
2288         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2289         https://bugs.webkit.org/show_bug.cgi?id=195750
2290
2291         Reviewed by Geoffrey Garen.
2292
2293         Add API test coverage.
2294
2295         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2296         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2297         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2298         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2299
2300 2019-03-14  Chris Dumez  <cdumez@apple.com>
2301
2302         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2303         https://bugs.webkit.org/show_bug.cgi?id=195747
2304
2305         Reviewed by Geoff Garen.
2306
2307         Add API test coverage.
2308
2309         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2310
2311 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2312
2313         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2314         https://bugs.webkit.org/show_bug.cgi?id=195725
2315         <rdar://problem/48545062>
2316
2317         Reviewed by Tim Horton.
2318
2319         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2320         handler is nil.
2321
2322         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2323         (TestWebKitAPI::TEST):
2324
2325 2019-03-13  Sam Weinig  <sam@webkit.org>
2326
2327         Add utility function to allow easy reverse range-based iteration of a container
2328         https://bugs.webkit.org/show_bug.cgi?id=195542
2329
2330         Reviewed by Antti Koivisto.
2331
2332         * TestWebKitAPI/CMakeLists.txt:
2333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2334         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2335         (TestWebKitAPI::TEST):
2336         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2337
2338 2019-03-13  Chris Dumez  <cdumez@apple.com>
2339
2340         Use a ServiceWorker process per registrable domain
2341         https://bugs.webkit.org/show_bug.cgi?id=195649
2342
2343         Reviewed by Youenn Fablet.
2344
2345         Update API test coverage.
2346
2347         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2348
2349 2019-03-13  Chris Dumez  <cdumez@apple.com>
2350
2351         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2352         https://bugs.webkit.org/show_bug.cgi?id=195684
2353         <rdar://problem/48294714>
2354
2355         Reviewed by Antti Koivisto.
2356
2357         Add API test coverage.
2358
2359         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2360
2361 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2362
2363         [ews-app] Remove unused patch view
2364         https://bugs.webkit.org/show_bug.cgi?id=195669
2365
2366         Reviewed by Lucas Forschler.
2367
2368         * BuildSlaveSupport/ews-app/ews/urls.py:
2369         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2370
2371 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2372
2373         [ews-app] Use Buildbot result code variables
2374         https://bugs.webkit.org/show_bug.cgi?id=195668
2375
2376         Reviewed by Alexey Proskuryakov.
2377
2378         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2379         (Buildbot): Added Buildbot result code variables.
2380         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2381         (StatusBubble._build_bubble): Used Buildbot result code variables.
2382
2383 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2384
2385         [Flatpak] Expand submodule recursively
2386         https://bugs.webkit.org/show_bug.cgi?id=195672
2387
2388         Building WPE with flatpak was impossible without that as it was raising an exception.
2389         Also update wpebackend-fdo to match what is built in jhbuild
2390
2391         Reviewed by Philippe Normand.
2392
2393         * flatpak/flatpakutils.py:
2394         (expand_submodules_recurse):
2395         (expand_manifest):
2396         * flatpak/org.webkit.WPEModules.yaml:
2397
2398 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2399
2400         [ews-app] status bubble should be hidden for certain builds
2401         https://bugs.webkit.org/show_bug.cgi?id=194597
2402
2403         Reviewed by Dewei Zhu.
2404
2405         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2406         (StatusBubble._build_bubble):
2407         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2408         because the patch didn't have relevant changes.
2409         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2410         in production yet.
2411
2412 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2413
2414         [Win] Fix a slew of simple clang-cl warnings.
2415         https://bugs.webkit.org/show_bug.cgi?id=195652
2416
2417         Reviewed by Don Olmstead.
2418
2419         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2420         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2421
2422 2019-03-12  Justin Fan  <justin_fan@apple.com>
2423
2424         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2425         https://bugs.webkit.org/show_bug.cgi?id=195518
2426         <rdar://problem/46322356>
2427
2428         Reviewed by Myles C. Maxfield.
2429
2430         * DumpRenderTree/DerivedSources-input.xcfilelist:
2431         * DumpRenderTree/DerivedSources-output.xcfilelist:
2432
2433 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2434
2435         Unreviewed, rolling out r242825.
2436         https://bugs.webkit.org/show_bug.cgi?id=195648
2437
2438         "Broke webkitpy tests with my change to
2439         lldb_dump_class_layout.py" (Requested by rmorisset on
2440         #webkit).
2441
2442         Reverted changeset:
2443
2444         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2445         classes with suspicious padding"
2446         https://bugs.webkit.org/show_bug.cgi?id=195573
2447         https://trac.webkit.org/changeset/242825
2448
2449 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2450
2451         [ews-build] Show status bubbles while the patch is waiting in queue
2452         https://bugs.webkit.org/show_bug.cgi?id=195618
2453
2454         Reviewed by Lucas Forschler.
2455
2456         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2457         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2458         enabled in initial deployment.
2459         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2460         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2461         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2462         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2463         (StatusBubble._build_bubbles_for_patch):
2464
2465 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2466
2467         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2468         https://bugs.webkit.org/show_bug.cgi?id=195573
2469
2470         Reviewed by Simon Fraser.
2471
2472         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2473
2474         * Scripts/dump-class-layout:
2475         (main):
2476         * lldb/lldb_dump_class_layout.py:
2477         (ClassLayout.__init__):
2478         (ClassLayout._compute_padding_recursive):
2479         (LLDBDebuggerInstance.dump_layout_for_classname):
2480         (LLDBDebuggerInstance):
2481         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2482         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2483
2484 2019-03-12  Chris Dumez  <cdumez@apple.com>
2485
2486         Device Orientation access permission should be denied unless explicitly granted by the client
2487         https://bugs.webkit.org/show_bug.cgi?id=195625
2488
2489         Reviewed by Youenn Fablet.
2490
2491         add API test coverage.
2492
2493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2494         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2495         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2496         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2497         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2498         (runDeviceOrientationTest):
2499         (TEST):
2500         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2501         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2502
2503 2019-03-12  Jer Noble  <jer.noble@apple.com>
2504
2505         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2506         https://bugs.webkit.org/show_bug.cgi?id=195137
2507         <rdar://problem/48810307>
2508
2509         Reviewed by Eric Carlson.
2510
2511         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2512         (TestWebKitAPI::TEST):
2513
2514 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2515
2516         [ews-build] Change urls from uat to production
2517         https://bugs.webkit.org/show_bug.cgi?id=195566
2518
2519         Reviewed by Lucas Forschler.
2520
2521         * BuildSlaveSupport/ews-app/ews/config.py:
2522         * BuildSlaveSupport/ews-build/events.py:
2523         * BuildSlaveSupport/ews-build/steps.py:
2524
2525 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2526
2527         [ews-build] change max_builds for local-worker to 1
2528         https://bugs.webkit.org/show_bug.cgi?id=195568
2529
2530         Reviewed by Lucas Forschler.
2531
2532         * BuildSlaveSupport/ews-build/loadConfig.py:
2533
2534 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2535
2536         Fix the build
2537
2538         * TestRunnerShared/spi/PencilKitTestSPI.h:
2539         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2540
2541 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2542
2543         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2544         https://bugs.webkit.org/show_bug.cgi?id=194131
2545
2546         Reviewed by Michael Catanzaro.
2547
2548         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2549         (uriChanged):
2550         (testUnfinishedSubresourceLoad):
2551         (serverCallback):
2552         (beforeAll):
2553
2554 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2555
2556         WTF::Expected should use std::addressof instead of operator&
2557         https://bugs.webkit.org/show_bug.cgi?id=195604
2558
2559         Reviewed by Myles Maxfield.
2560
2561         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2562         (TestWebKitAPI::Unique::Unique):
2563         (TestWebKitAPI::Unique::operator&):
2564         (TestWebKitAPI::TEST):
2565
2566 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2567
2568         Add Optional to Forward.h.
2569         https://bugs.webkit.org/show_bug.cgi?id=195586
2570
2571         Reviewed by Darin Adler.
2572
2573         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2574         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2575         Remove unnecessary includes from headers.
2576
2577 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2578
2579         Add testing API to hit-test and scroll overflow scrollers
2580         https://bugs.webkit.org/show_bug.cgi?id=195278
2581
2582         Reviewed by Antti Koivisto.
2583         
2584         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2585         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2586         
2587         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2588
2589         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2590         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2591         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2592         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2593         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2594         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2595         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2596         (WTR::enclosingScrollViewIncludingSelf):
2597         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2598
2599 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2600
2601         API test WebKit.RequestTextInputContext fails on iOS
2602         https://bugs.webkit.org/show_bug.cgi?id=195585
2603
2604         Reviewed by Wenson Hsieh and Simon Fraser.
2605
2606         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2607         (applyStyle):
2608         (TEST):
2609         Add a viewport, so that the coordinates match up on iOS.
2610         Scroll by moving the UIScrollView's contentOffset.
2611
2612 2019-03-11  Chris Dumez  <cdumez@apple.com>
2613
2614         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2615         https://bugs.webkit.org/show_bug.cgi?id=195506
2616         <rdar://problem/48733477>
2617
2618         Reviewed by Alex Christensen.
2619
2620         Add API test coverage.
2621
2622         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2623
2624 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2625
2626         Adding myself to contributors.json
2627
2628         Unreviewed, addming myself to contributors.json .
2629
2630         * Scripts/webkitpy/common/config/contributors.json:
2631
2632 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2633
2634         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2635         https://bugs.webkit.org/show_bug.cgi?id=195511
2636         <rdar://problem/44873269>
2637
2638         Reviewed by Darin Adler.
2639
2640         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2641         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2642         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2643         (TEST_F):
2644
2645 2019-03-11  Chris Dumez  <cdumez@apple.com>
2646
2647         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2648         https://bugs.webkit.org/show_bug.cgi?id=195561
2649
2650         Reviewed by Youenn Fablet.
2651
2652         Make sure the JS in the test requests for permission to receive device orientation events.
2653
2654         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2655
2656 2019-03-11  Youenn Fablet  <youenn@apple.com>
2657
2658         Allow storage quota increase by default in WTR
2659         https://bugs.webkit.org/show_bug.cgi?id=195541
2660
2661         Reviewed by Geoffrey Garen.
2662
2663         Allow storage quota increase by default in WTR.
2664         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2665         Use this for tests that explicitly need cache increase.
2666
2667         Instead of increasing quota by 2, make sure the next request is
2668         granted by adding all given parameters.
2669
2670         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2671         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2672         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2673         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2674         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2675         * WebKitTestRunner/TestController.cpp:
2676         (WTR::TestController::setAllowStorageQuotaIncrease):
2677         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2678         * WebKitTestRunner/TestController.h:
2679         * WebKitTestRunner/TestInvocation.cpp:
2680         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2681         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2682         (WTR::TestController::cocoaResetStateToConsistentValues):
2683         (WTR::TestController::setAllowStorageQuotaIncrease):
2684         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2685         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2686         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2687
2688 2019-03-11  Xan Lopez  <xan@igalia.com>
2689
2690         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2691         https://bugs.webkit.org/show_bug.cgi?id=194147
2692
2693         Reviewed by Michael Saboff.
2694
2695         To make --32-bit work correctly on Linux/64bit we need to:
2696
2697         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2698         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2699         unfortunately CMake only allows us to do this during
2700         crosscompilation, which is overkill here.
2701         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2702         pkg-config detection module uses the x86 .pc files instead of the
2703         x86_64 ones.
2704         - Set the -m32 flags for the compiler.
2705
2706         * Scripts/webkitdirs.pm:
2707         (generateBuildSystemFromCMakeProject):
2708
2709 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2710
2711         Add MotionMark-1.1 plan file for run-benchmark script.
2712         https://bugs.webkit.org/show_bug.cgi?id=195481
2713
2714         Rubber-stamped by Darin Adler.
2715
2716         Run-benchmark script should support MontionMark-1.1.
2717
2718         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2719
2720 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2721
2722         [ews-app] Add support for submit-to-ews url
2723         https://bugs.webkit.org/show_bug.cgi?id=195477
2724
2725         Reviewed by Lucas Forschler.
2726
2727         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2728         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2729         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2730         * BuildSlaveSupport/ews-app/ews/urls.py:
2731         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2732
2733 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2734
2735         Unreviewed, rolling out r242688, r242643, r242624.
2736
2737         Caused multiple layout test failures and crashes on iOS and macOS.
2738
2739         Reverted changeset:
2740
2741         "requestAnimationFrame should execute before the next frame"
2742         https://bugs.webkit.org/show_bug.cgi?id=177484
2743         https://trac.webkit.org/changeset/242624/webkit
2744
2745         * Tracing/SystemTracePoints.plist:
2746
2747 2019-03-11  John Wilander  <wilander@apple.com>
2748
2749         Resource Load Statistics: Make it possible exclude localhost from classification
2750         https://bugs.webkit.org/show_bug.cgi?id=195474
2751         <rdar://problem/47520577>
2752
2753         Reviewed by Brent Fulgham.
2754
2755         This patch allows for localhost to be excluded from classification and
2756         treatment as a prevalent resource.
2757
2758         The WebKit Tools change adds a new function called
2759         testRunner.setStatisticsIsRunningTest() which can be used to control this
2760         behavior.
2761
2762         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2763         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2764         (WTR::TestRunner::setStatisticsIsRunningTest):
2765         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2766         * WebKitTestRunner/TestController.cpp:
2767         (WTR::TestController::setStatisticsIsRunningTest):
2768         * WebKitTestRunner/TestController.h:
2769         * WebKitTestRunner/TestInvocation.cpp:
2770         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2771
2772 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2773
2774         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2775         https://bugs.webkit.org/show_bug.cgi?id=195560
2776
2777         Reviewed by Lucas Forschler.
2778
2779         * BuildSlaveSupport/ews-build/master.cfg:
2780
2781 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2782
2783         Unreviewed, rolling out r242698.
2784
2785         API test crashes on bots.
2786
2787         Reverted changeset:
2788
2789         "Add a WKContentRuleList variant that uses copied memory
2790         instead of mmap'd shared memory for class A containerized
2791         apps"
2792         https://bugs.webkit.org/show_bug.cgi?id=195511
2793         https://trac.webkit.org/changeset/242698
2794
2795 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2796
2797         [WPE] Enable web process sandbox
2798         https://bugs.webkit.org/show_bug.cgi?id=195169
2799
2800         Reviewed by Daniel Bates.
2801
2802         * wpe/install-dependencies:
2803         * wpe/jhbuild.modules:
2804
2805 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2806
2807         [ews-app] Use port 17000 for worker communication
2808         https://bugs.webkit.org/show_bug.cgi?id=195558
2809
2810         Reviewed by Lucas Forschler.
2811
2812         * BuildSlaveSupport/ews-build/master.cfg:
2813
2814 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2815
2816         [ews-build] unit-tests fail when passwords.json is missing
2817         https://bugs.webkit.org/show_bug.cgi?id=195557
2818
2819         Reviewed by Lucas Forschler.
2820
2821         * BuildSlaveSupport/ews-build/loadConfig.py:
2822         (loadBuilderConfig):
2823         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2824         (ConfigDotJSONTest.test_configuration):
2825         * BuildSlaveSupport/ews-build/master.cfg:
2826
2827 2019-03-11  Truitt Savell  <tsavell@apple.com>
2828
2829         Unreviewed, rolling out r242702.
2830
2831         Broke High Sierra builders.
2832
2833         Reverted changeset:
2834
2835         "Add utility function to allow easy reverse range-based
2836         iteration of a container"
2837         https://bugs.webkit.org/show_bug.cgi?id=195542
2838         https://trac.webkit.org/changeset/242702
2839
2840 2019-03-11  Sam Weinig  <sam@webkit.org>
2841
2842         Add utility function to allow easy reverse range-based iteration of a container
2843         https://bugs.webkit.org/show_bug.cgi?id=195542
2844
2845         Reviewed by Antti Koivisto.
2846
2847         * TestWebKitAPI/CMakeLists.txt:
2848         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2849         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2850         (TestWebKitAPI::TEST):
2851         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2852
2853 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2854
2855         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2856         https://bugs.webkit.org/show_bug.cgi?id=195511
2857         <rdar://problem/44873269>
2858
2859         Reviewed by Darin Adler.
2860
2861         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2862         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2863         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2864         (TEST_F):
2865
2866 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2867
2868         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2869         https://bugs.webkit.org/show_bug.cgi?id=195499
2870
2871         Reviewed by Darin Adler.
2872
2873         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2874         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2875         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2876         (-[WKWebView synchronouslyFocusTextInputContext:]):
2877         (applyStyle):
2878         (applyIframe):
2879         (TEST):
2880         Add some tests for this SPI.
2881
2882 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2883
2884         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2885         https://bugs.webkit.org/show_bug.cgi?id=181151
2886
2887         Reviewed by Don Olmstead.
2888
2889         * TestWebKitAPI/CMakeLists.txt:
2890         * TestWebKitAPI/PlatformWin.cmake:
2891         Enable TestWTF RunLoop tests in all platforms.
2892
2893         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2894         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2895         (TestWebKitAPI::DerivedOneShotTimer::fired):
2896         (TestWebKitAPI::TEST):
2897         Only a few platforms support nested RunLoop.
2898
2899         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2900         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2901
2902 2019-03-10  David Quesada  <david_quesada@apple.com>
2903
2904         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2905         https://bugs.webkit.org/show_bug.cgi?id=152480
2906
2907         Reviewed by Chris Dumez.
2908
2909         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2910         there are no additional references to the process pool besides the one held by
2911         the download, waits for the download to finish (in the sense that the
2912         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2913         measure, also check that the process pool has been deallocated at the end of the
2914         test. The test wouldn't be meaningful if the process pool were still alive.
2915
2916         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2917         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2918         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2919             The download will be canceled because the delegate does not implement the
2920             method to decide the download's destination, so this is where we know the
2921             DownloadProxyMap is done with the DownloadProxy.
2922         (TEST):
2923
2924 2019-03-08  Chris Dumez  <cdumez@apple.com>
2925
2926         Add support for Device Orientation / Motion permission API
2927         https://bugs.webkit.org/show_bug.cgi?id=195329
2928         <rdar://problem/47645367>
2929
2930         Reviewed by Geoffrey Garen.
2931
2932         Add test infrastructure to help test the Device Orientation / Motion permission API.
2933
2934         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2935         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2936         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2937         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2938         * WebKitTestRunner/TestController.cpp:
2939         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2940         (WTR::TestController::createWebViewWithOptions):
2941         (WTR::TestController::resetStateToConsistentValues):
2942         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2943         * WebKitTestRunner/TestController.h:
2944         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2945         * WebKitTestRunner/TestInvocation.cpp:
2946         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2947
2948 2019-03-08  Saam barati  <sbarati@apple.com>
2949
2950         Add a compare-results script to compare benchmark results
2951         https://bugs.webkit.org/show_bug.cgi?id=195486
2952         <rdar://problem/48723397>
2953
2954         Reviewed by Geoffrey Garen.
2955
2956         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2957         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2958         to extend it to learn about our other benchmarks.
2959
2960         * Scripts/compare-results: Added.
2961         (readJSONFile):
2962         (detectJetStream2):
2963         (JetStream2Results):
2964         (detectSpeedometer2):
2965         (Speedometer2Results):
2966         (detectPLT5):
2967         (PLT5Results):
2968         (detectBenchmark):
2969         (biggerIsBetter):
2970         (ttest):
2971         (getOptions):
2972         (main):
2973
2974 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2975
2976         Ensure old tab state is cleared between iterations of run-benchmark
2977         https://bugs.webkit.org/show_bug.cgi?id=195393
2978         <rdar://problem/46885583>
2979
2980         Reviewed by Dewei Zhu.
2981
2982         a) ensure the default to restore state is not set
2983         b) terminate Safari correctly
2984         c) Set the system default to ignore Persistent State in Safari
2985
2986         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2987         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2988         (OSXBrowserDriver.prepare_env): 
2989         (OSXBrowserDriver.restore_env):
2990         (OSXBrowserDriver.close_browsers):
2991         (OSXBrowserDriver._terminate_processes):
2992         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2993         (OSXChromeDriver):
2994         (OSXChromeCanaryDriver):
2995         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2996         (OSXFirefoxDriver):
2997         (OSXFirefoxNightlyDriver):
2998         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2999         (OSXSafariDriver):
3000         (OSXSafariDriver.prepare_env):
3001
3002 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3003
3004         [GTK] Several InputMethodFilter tests are failing
3005         https://bugs.webkit.org/show_bug.cgi?id=195408
3006
3007         Reviewed by Carlos Garcia Campos.
3008
3009         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3010         Regressed in r241751.
3011         Hexadecimal values of keycodes are expressed now in upper letters.
3012         Composited characters should be cast to UTF8 strings.
3013
3014         (TestWebKitAPI::TEST):
3015
3016 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3017
3018         [GTK] Make Tools/gtkdoc python3 compatible
3019         https://bugs.webkit.org/show_bug.cgi?id=195359
3020
3021         Reviewed by Carlos Garcia Campos.
3022
3023         * gtkdoc/generate-gtkdoc:
3024         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3025         work with Python 2 and 3.
3026         (get_gtkdoc_module_paths):
3027         The iteritems() was removed in Python 3, so let's use items() that's
3028         available in Python 2 and 3.
3029         (get_generator_for_config):
3030         * gtkdoc/gtkdoc.py:
3031         (GTKDoc._run_command):
3032         The sys.stdout.write() is expecting str in Python 3 and not bytes
3033         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3034         for passing the bytes there.
3035
3036 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3037
3038         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3039         https://bugs.webkit.org/show_bug.cgi?id=195346
3040         <rdar://problem/48667048>
3041
3042         Unreviewed build fix for clang-cl.
3043
3044         * DumpRenderTree/win/DumpRenderTree.cpp:
3045         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3046
3047 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3048
3049         requestAnimationFrame should execute before the next frame
3050         https://bugs.webkit.org/show_bug.cgi?id=177484
3051
3052         Reviewed by Simon Fraser.
3053
3054         Add trace points for the page RenderingUpdate.
3055
3056         * Tracing/SystemTracePoints.plist:
3057
3058 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3059
3060         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3061         https://bugs.webkit.org/show_bug.cgi?id=195353
3062         <rdar://problem/48626394>
3063
3064         Reviewed by Simon Fraser.
3065
3066         * WebKitTestRunner/ios/TestControllerIOS.mm:
3067         (WTR::TestController::platformResetPreferencesToConsistentValues):
3068
3069 2019-03-07  John Wilander  <wilander@apple.com>
3070
3071         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3072         https://bugs.webkit.org/show_bug.cgi?id=195383
3073         <rdar://problem/48570136>
3074
3075         Reviewed by Brent Fulgham.
3076
3077         This patch adds test infrastructure to purge only script-accessible cookies,
3078         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3079
3080         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3081         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3082         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3083         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3084         * WebKitTestRunner/TestController.cpp:
3085         (WTR::TestController::statisticsDeleteCookiesForHost):
3086         * WebKitTestRunner/TestController.h:
3087         * WebKitTestRunner/TestInvocation.cpp:
3088         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3089
3090 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3091
3092         Unreviewed, rolling out r242354.
3093         https://bugs.webkit.org/show_bug.cgi?id=195402
3094
3095         breaks layout tests in all configurations (Requested by
3096         zdobersek on #webkit).
3097
3098         Reverted changeset:
3099
3100         "[WPE] Enable web process sandbox"
3101         https://bugs.webkit.org/show_bug.cgi?id=195169
3102         https://trac.webkit.org/changeset/242354
3103
3104 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3105
3106         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3107         https://bugs.webkit.org/show_bug.cgi?id=195346
3108
3109         Reviewed by Fujii Hironori.
3110
3111         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3112         (TestWebKitAPI::TEST):
3113         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3114
3115         * DumpRenderTree/win/DumpRenderTree.cpp:
3116         (findFontFallback):
3117         (addFontFallbackIfPresent):
3118         (removeFontFallbackIfPresent):
3119         (main):
3120         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3121         (TestWebKitAPI::Util::moduleDirectory):
3122         (TestWebKitAPI::Util::createInjectedBundlePath):
3123         Use wchar helpers as needed.
3124
3125 2019-03-06  Rob Buis  <rbuis@igalia.com>
3126
3127         Consider supporting the `referrerpolicy` attribute.
3128         https://bugs.webkit.org/show_bug.cgi?id=179053
3129
3130         Reviewed by Darin Adler.
3131
3132         Add a runtime flag for referrerpolicy attribute.
3133
3134         * DumpRenderTree/mac/DumpRenderTree.mm:
3135         (enableExperimentalFeatures):
3136
3137 2019-03-05  Daniel Bates  <dabates@apple.com>
3138
3139         Update expected API test result following r242379
3140         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3141
3142         Update expected x-coordinate of selection rect now that the left padding of
3143         a textarea is sized in ems (so dependent on the font size) just like the left
3144         padding of a text field.
3145
3146         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3147         (TestWebKitAPI::TEST):
3148
3149 2019-03-05  David Quesada  <david_quesada@apple.com>
3150
3151         [WK2] It should be possible to follow links with 'download' attributes
3152         https://bugs.webkit.org/show_bug.cgi?id=195145
3153         rdar://problem/48462642
3154
3155         Reviewed by Alex Christensen.
3156
3157         Add a unit test to verify that activating links with 'download' attributes now
3158         navigates to the linked resource, rather than starts downloading it. Add another
3159         to verify that it is still possible to explicitly download the link via the
3160         'Download' navigation action policy.
3161
3162         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3163         (-[DownloadAttributeTestDelegate init]):
3164         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3165         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3166         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3167         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3168         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3169         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3170         (TEST):
3171         * WebKitTestRunner/TestController.cpp:
3172         (WTR::TestController::decidePolicyForNavigationAction):
3173         * WebKitTestRunner/TestController.h:
3174
3175 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3176
3177         [Curl] Implement Cookie Accept Policy.
3178         https://bugs.webkit.org/show_bug.cgi?id=191645
3179
3180         Reviewed by Fujii Hironori.
3181
3182         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3183         (TestWebKitAPI::Curl::TEST_F):
3184
3185 2019-03-05  Youenn Fablet  <youenn@apple.com>
3186
3187         Rename requestCacheStorageSpace to requestStorageSpace
3188         https://bugs.webkit.org/show_bug.cgi?id=195282
3189
3190         Reviewed by Chris Dumez.
3191
3192         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3193         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3194         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3195
3196 2019-03-05  Brady Eidson  <beidson@apple.com>
3197
3198         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3199         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3200
3201         Reviewed by Tim Horton.
3202
3203         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3204         different directory into that same WKWebView should work.
3205
3206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3207         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3208
3209 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3210
3211         Add WeakHashSet
3212         https://bugs.webkit.org/show_bug.cgi?id=195152
3213
3214         Reviewed by Antti Koivisto.
3215
3216         Added tests for WeakHashSet.
3217
3218         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3219         (TestWebKitAPI::Base::Base): Moved.
3220         (TestWebKitAPI::Derived::foo): Moved.
3221         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3222         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3223         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3224         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3225
3226 2019-03-04  Chris Dumez  <cdumez@apple.com>
3227
3228         Do not share WebProcesses between private and regular sessions
3229         https://bugs.webkit.org/show_bug.cgi?id=195189
3230         <rdar://problem/48421064>
3231
3232         Reviewed by Alex Christensen.
3233
3234         Add API test coverage.
3235
3236         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3237         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3238
3239 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3240
3241         [WPE] Enable web process sandbox
3242         https://bugs.webkit.org/show_bug.cgi?id=195169
3243
3244         Reviewed by Daniel Bates.
3245
3246         * wpe/install-dependencies:
3247         * wpe/jhbuild.modules:
3248
3249 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3250
3251         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3252         https://bugs.webkit.org/show_bug.cgi?id=195206
3253
3254         Reviewed by Žan Doberšek.
3255
3256         Add a new test case.
3257
3258         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3259         (testJSCClass):
3260
3261 2019-03-04  Charlie Turner  <cturner@igalia.com>
3262
3263         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3264         https://bugs.webkit.org/show_bug.cgi?id=194898
3265
3266         Reviewed by Žan Doberšek.
3267
3268         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3269         a GCC extension that permits arithmetic on void* pointer. Inline
3270         the macro until this issue is fixed upstream.
3271
3272 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3273
3274         Rid the world of WK_API_ENABLED
3275         https://bugs.webkit.org/show_bug.cgi?id=195263
3276
3277         Reviewed by Dan Bernstein.
3278
3279         List of changed files elided because it's useless.
3280
3281 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3282
3283         Unreviewed follow-up to r242292.
3284
3285         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3286
3287         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3288         (TestWebKitAPI::testStrip): Renamed from strip.
3289         (TestWebKitAPI::TEST):
3290
3291 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3292
3293         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3294
3295         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3296         and bug #194272 for details.
3297
3298         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3299
3300 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3301
3302         Remove some more unused 32-bit code
3303         https://bugs.webkit.org/show_bug.cgi?id=195255
3304
3305         Reviewed by Darin Adler.
3306
3307         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3308         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3309         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3310         (NPP_New):
3311         (NPP_HandleEvent):
3312         (handleEventCarbon): Deleted.
3313
3314 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3315
3316         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3317
3318         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3319         (TestWebKitAPI::TEST):
3320
3321 2019-03-01  Darin Adler  <darin@apple.com>
3322
3323         Finish removing String::format
3324         https://bugs.webkit.org/show_bug.cgi?id=194893
3325
3326         Reviewed by Daniel Bates.
3327 '
3328         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3329
3330 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3331
3332         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3333         https://bugs.webkit.org/show_bug.cgi?id=195229
3334         <rdar://problem/48520362>
3335
3336         Reviewed by Chris Dumez.
3337
3338         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3339         (TEST):
3340
3341 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3342
3343         Add a system trace scope for event region building
3344         https://bugs.webkit.org/show_bug.cgi?id=195226
3345
3346         Reviewed by Jon Lee.
3347
3348         This trace scope measures the time spend converting element rects into Region objects,
3349         which can be large on some pages.
3350
3351         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3352
3353         * Tracing/SystemTracePoints.plist:
3354
3355 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3356
3357         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3358         https://bugs.webkit.org/show_bug.cgi?id=194612
3359
3360         Reviewed by Alex Christensen.
3361
3362         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3363         Just test the new string-processing function and don't touch the actual environment.
3364         (Test cases are all as before, but based on operator== instead of strcmp.)
3365
3366 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3367
3368         [ews-app] Update primary keys for handling multiple Buildbot instances
3369         https://bugs.webkit.org/show_bug.cgi?id=195120
3370
3371         Reviewed by Stephanie Lewis.
3372
3373         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3374         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3375         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3376
3377         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3378         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3379         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3380         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3381         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3382         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3383
3384 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3385
3386         [WinCairo] Enable service worker
3387         https://bugs.webkit.org/show_bug.cgi?id=188318
3388
3389         Reviewed by Youenn Fablet.
3390
3391         * DumpRenderTree/DumpRenderTreePrefix.h:
3392         * TestWebKitAPI/PlatformWin.cmake:
3393         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3394         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3395         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3396
3397 2019-03-01  Justin Fan  <justin_fan@apple.com>
3398
3399         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3400         https://bugs.webkit.org/show_bug.cgi?id=195191
3401
3402         Rubber-stamped by Dean Jackson.
3403
3404         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3405
3406         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3407
3408 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3409
3410         Unreviewed, fix lldb webkitpy tests
3411         https://bugs.webkit.org/show_bug.cgi?id=194375
3412
3413         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3414
3415         * lldb/lldb_webkit.py:
3416         (WTFStringImplProvider.is_8bit):
3417
3418 2019-02-28  David Quesada  <david_quesada@apple.com>
3419
3420         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3421         https://bugs.webkit.org/show_bug.cgi?id=195121
3422         rdar://problem/48450302
3423
3424         Reviewed by Alex Christensen.
3425
3426         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3427         configurations where the 'download' attribute is absent, blank, or populated
3428         with a filename, and where the anchor element is same-origin or cross-origin
3429         (meaning the 'download' attribute shouldn't be honored).
3430
3431         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3432         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3433         (-[NavigationActionTestDelegate init]):
3434         (-[NavigationActionTestDelegate navigationAction]):
3435         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3436         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3437         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3438         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3439         (TEST):
3440
3441 2019-02-28  Antoine Quint  <graouts@apple.com>
3442
3443         Enable the Pointer Events runtime flag by default
3444         https://bugs.webkit.org/show_bug.cgi?id=195156
3445
3446         Reviewed by Dean Jackson.
3447
3448         * DumpRenderTree/mac/DumpRenderTree.mm:
3449         (enableExperimentalFeatures):
3450
3451 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3452
3453         Several PasteImage API tests are flaky
3454         https://bugs.webkit.org/show_bug.cgi?id=195160
3455
3456         Reviewed by Tim Horton.
3457
3458         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3459         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3460         listening for a "load" event after image load is already complete.
3461
3462         To address this, make these tests first register a "load" event handler, then run script to insert an image
3463         element into the document, and finally wait until the load event is observed before checking image size.
3464
3465         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3466
3467 2019-02-28  Chris Dumez  <cdumez@apple.com>
3468
3469         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3470         https://bugs.webkit.org/show_bug.cgi?id=195107
3471
3472         Reviewed by Alex Christensen.
3473
3474         Give some time for the zoom level to get restored.
3475
3476         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3477
3478 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3479
3480         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3481         https://bugs.webkit.org/show_bug.cgi?id=194958
3482
3483         Reviewed by Geoffrey Garen.
3484
3485         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3486         (TEST):
3487
3488 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3489
3490         [ews-app] Update method to save build to handle builder_display_name
3491         https://bugs.webkit.org/show_bug.cgi?id=195047
3492
3493         Reviewed by Dewei Zhu.
3494
3495         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3496         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3497
3498 2019-02-28  Justin Fan  <justin_fan@apple.com>
3499
3500         [Web GPU] Enable Web GPU only on 64-bit
3501         https://bugs.webkit.org/show_bug.cgi?id=195139
3502
3503         Because Metal is only supported on 64 bit apps.
3504
3505         Unreviewed build fix.
3506
3507         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3508
3509 2019-02-27  Youenn Fablet  <youenn@apple.com>
3510
3511         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3512         https://bugs.webkit.org/show_bug.cgi?id=194959
3513
3514         Reviewed by Chris Dumez.
3515
3516         Spin loop until getting the condition to remove flakiness.
3517
3518         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3519
3520 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3521
3522         [ews-build] Buildbot should include builder_display_name in the build events
3523         https://bugs.webkit.org/show_bug.cgi?id=195045
3524
3525         Reviewed by Dewei Zhu.
3526
3527         * BuildSlaveSupport/ews-build/events.py:
3528         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3529         buildername to builder_name to be consistent in naming style.
3530         (Events.buildFinished): Ditto.
3531
3532 2019-02-27  Chris Dumez  <cdumez@apple.com>
3533
3534         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3535         https://bugs.webkit.org/show_bug.cgi?id=194480
3536
3537         Reviewed by Brady Eidson.
3538
3539         Update existing API test to make it more likely to reproduce the issue.
3540
3541         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3542
3543 2019-02-27  Brady Eidson  <beidson@apple.com>
3544
3545         Universal links from Google search results pages don't open the app.
3546         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3547
3548         Reviewed by Geoffrey Garen.
3549
3550         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3551         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3552         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3553         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3554
3555 2019-02-27  Chris Dumez  <cdumez@apple.com>
3556
3557         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3558         https://bugs.webkit.org/show_bug.cgi?id=195102
3559
3560         Reviewed by Geoffrey Garen.
3561
3562         If the number of processes is not yet what we expect, wait a bit and check again to give
3563         processes some time to exit.
3564
3565         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3566
3567 2019-02-27  Chris Dumez  <cdumez@apple.com>
3568
3569         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3570         https://bugs.webkit.org/show_bug.cgi?id=194545
3571
3572         Reviewed by Brady Eidson.
3573
3574         Make sure the test navigates forward and then back only once. Previously, navigating
3575         back would trigger a navigation again in a timer.
3576
3577         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3578
3579 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3580
3581         High Sierra Debug JSC test queue should use faster hardware
3582         https://bugs.webkit.org/show_bug.cgi?id=194603
3583
3584         Rubber-stamped by Alexey Proskuryakov.
3585
3586         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3587
3588         * BuildSlaveSupport/build.webkit.org-config/config.json:
3589         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3590         (BubbleQueueServer):
3591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3592         (WebKitBuildbot):
3593         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3594         * QueueStatusServer/config/queues.py:
3595         * Scripts/webkitpy/common/config/ews.json:
3596         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3597         (test_ews_name):
3598
3599 2019-02-27  John Wilander  <wilander@apple.com>
3600
3601         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3602         https://bugs.webkit.org/show_bug.cgi?id=195071
3603         <rdar://problem/48417690>
3604
3605         Reviewed by Alex Christensen and Brent Fulgham.
3606
3607         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3608         (TestWebKitAPI::createURL):
3609             Convenience function.
3610         (TestWebKitAPI::TEST):
3611             WebCore::AdClickAttribution now takes a URL when creating Source and
3612             Destination.
3613         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3614         (TestWebKitAPI::TEST):
3615             WebCore::AdClickAttribution now takes a URL when creating Source and
3616             Destination.
3617
3618 2019-02-27  Antoine Quint  <graouts@apple.com>
3619
3620         Support Pointer Events on macOS
3621         https://bugs.webkit.org/show_bug.cgi?id=195008
3622         <rdar://problem/47454419>
3623
3624         Reviewed by Dean Jackson.
3625
3626         * DumpRenderTree/mac/DumpRenderTree.mm:
3627         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3628         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3629
3630 2019-02-26  Mark Lam  <mark.lam@apple.com>
3631
3632         Remove remaining poisoning code.
3633         https://bugs.webkit.org/show_bug.cgi?id=194138
3634
3635         Reviewed by Saam Barati.
3636
3637         * TestWebKitAPI/CMakeLists.txt:
3638         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3639         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3640         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3641         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3642         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3643         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3644         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3645
3646 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3647
3648         Move ephemeral local storage from WebProcess to UIProcess
3649         https://bugs.webkit.org/show_bug.cgi?id=195074
3650         <rdar://problem/47937975>
3651
3652         Reviewed by Geoff Garen.
3653
3654         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3655
3656 2019-02-20  Jer Noble  <jer.noble@apple.com>
3657
3658         [Cocoa] Media elements will restart network buffering just before suspending
3659         https://bugs.webkit.org/show_bug.cgi?id=193691
3660
3661         Reviewed by Eric Carlson.
3662
3663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3664         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3665         (TEST):
3666
3667 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3668
3669         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3670         https://bugs.webkit.org/show_bug.cgi?id=191652
3671
3672         Reviewed by Alex Christensen.
3673
3674         Fix WinCairo MiniBrowser behavior of authentication dialog.
3675
3676         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3677         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3678
3679 2019-02-26  Youenn Fablet  <youenn@apple.com>
3680
3681         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3682         https://bugs.webkit.org/show_bug.cgi?id=195028
3683         <rdar://problem/48243733>
3684
3685         Reviewed by Eric Carlson.
3686
3687         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3688
3689 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3690
3691         [WPE] Add API for webview background color configuration
3692         https://bugs.webkit.org/show_bug.cgi?id=192305
3693
3694         Reviewed by Michael Catanzaro.
3695
3696         * MiniBrowser/wpe/main.cpp:
3697         (main): Add a new option to configure the webview background
3698         color. Example: --bg-color=transparent.
3699         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3700         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3701         (beforeAll): Ditto.
3702
3703 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3704
3705         scalableNativeWebpageParameters() is not preserved on new page navigation.
3706         https://bugs.webkit.org/show_bug.cgi?id=194892
3707         <rdar://problem/47538280>
3708
3709         Reviewed by Wenson Hsieh.
3710         
3711         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3712
3713         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3714         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3715         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3716         (WTR::UIScriptController::allowsViewportShrinkToFit):
3717         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3718         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3719         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3720         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3721         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3722         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3723
3724 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3725
3726         [ews-app] Add model for handling multiple Buildbot instances
3727         https://bugs.webkit.org/show_bug.cgi?id=194863
3728
3729         Reviewed by Stephanie Lewis.
3730
3731         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3732
3733 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3734
3735         [ews-app] Remove BuilderMapping table
3736         https://bugs.webkit.org/show_bug.cgi?id=194961
3737
3738         Reviewed by Stephanie Lewis.
3739
3740         Store builder name directly in build table, instead of having a separate
3741         table for it.
3742
3743         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3744         * BuildSlaveSupport/ews-app/ews/models/build.py:
3745         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3746         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3747
3748 2019-02-25  John Wilander  <wilander@apple.com>
3749
3750         Introduce and adopt new class RegistrableDomain for eTLD+1
3751         https://bugs.webkit.org/show_bug.cgi?id=194791
3752         <rdar://problem/48179240>
3753
3754         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3755
3756         This patch adds an API test and replaces two instances of
3757         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3758
3759         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3760         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3761         (TestWebKitAPI::TEST):
3762             Changed two strings to make sure the registrable domains are still considered
3763             invalid and pass the test.
3764         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3765         (TestWebKitAPI::TEST):
3766         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3767         (WTR::InjectedBundle::didReceiveMessageToPage):
3768
3769 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3770
3771         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3772         https://bugs.webkit.org/show_bug.cgi?id=195001
3773
3774         Reviewed by Carlos Garcia Campos.
3775
3776         API version 1.0 always includes the functionality previously guarded with
3777         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3778         unconditionally.
3779
3780         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3781         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3782         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3783         (WebViewTest::showInWindow): Ditto.
3784         (WebViewTest::hideView): Ditto.
3785         * wpe/backends/HeadlessViewBackend.cpp:
3786         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3787         * wpe/backends/ViewBackend.cpp:
3788         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3789         * wpe/backends/WindowViewBackend.cpp:
3790         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3791         WPE_BACKEND_CHECK_VERSION().
3792         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3793
3794 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3795
3796         [Flatpak] Add support for flatpak > 1.1.2
3797         https://bugs.webkit.org/show_bug.cgi?id=194088
3798
3799         Flatpak 1.2 is now out so we need to support that
3800         version now.
3801
3802         Reviewed by Michael Catanzaro.
3803
3804         * flatpak/flatpakutils.py:
3805         (check_flatpak):
3806         (FlatpakPackages.__init__):
3807         (FlatpakPackages.__detect_packages):
3808         (FlatpakPackages.__detect_packages.in):
3809         (FlatpakRepos.update):
3810
3811 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3812
3813         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3814         https://bugs.webkit.org/show_bug.cgi?id=194998
3815
3816         Reviewed by Carlos Garcia Campos.
3817
3818         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3819         to a Git checkout and using the latest commit containing various fixes
3820         and improvements.
3821
3822 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3823
3824         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3825         https://bugs.webkit.org/show_bug.cgi?id=194981
3826
3827         Reviewed by Žan Doberšek.
3828
3829         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3830         (TestWebKitAPI::TEST):
3831
3832 2019-02-23  Keith Miller  <keith_miller@apple.com>
3833
3834         Add new mac target numbers
3835         https://bugs.webkit.org/show_bug.cgi?id=194955
3836
3837         Reviewed by Tim Horton.
3838
3839         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3840         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3841         * MiniBrowser/Configurations/Base.xcconfig:
3842         * TestWebKitAPI/Configurations/Base.xcconfig:
3843         * WebKitTestRunner/Configurations/Base.xcconfig:
3844
3845 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3846
3847         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3848         https://bugs.webkit.org/show_bug.cgi?id=194846
3849
3850         Reviewed by Don Olmstead.
3851
3852         Added _search_paths() and _port_specific_expectations_files() for
3853         WinCairoPort.
3854
3855         * Scripts/webkitpy/port/win.py:
3856         (WinCairoPort.default_baseline_search_path):
3857         (WinCairoPort):
3858         (WinCairoPort._port_specific_expectations_files):
3859         (WinCairoPort._search_paths):
3860
3861 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3862
3863         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3864         https://bugs.webkit.org/show_bug.cgi?id=194963
3865
3866         Reviewed by Dean Jackson.
3867
3868         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3869         Do a `contains` check instead of `equals`, because in debug builds we
3870         put the GraphicsLayer pointer in a prefix.
3871
3872 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3873
3874         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3875         https://bugs.webkit.org/show_bug.cgi?id=194873
3876         <rdar://problem/46701974>
3877
3878         Reviewed by Tim Horton.
3879
3880         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3881
3882         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3883         (WTR::UIScriptController::menuRect const):
3884         (WTR::UIScriptController::isShowingMenu const):
3885         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3886         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3887         (WTR::UIScriptController::menuRect const):
3888
3889         Add a function to query the bounds of the callout menu in content coordinates.
3890
3891         (WTR::UIScriptController::isShowingMenu const):
3892
3893         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3894
3895         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3896         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3897         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3898         (WTR::UIScriptController::rectForMenuAction const):
3899         (WTR::UIScriptController::menuRect const):
3900         (WTR::UIScriptController::isShowingMenu const):
3901         (WTR::findViewInHierarchyOfType): Deleted.
3902
3903 2019-02-22  Chris Dumez  <cdumez@apple.com>
3904
3905         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3906         https://bugs.webkit.org/show_bug.cgi?id=194954
3907         <rdar://problem/48127957>
3908
3909         Reviewed by Alex Christensen.
3910
3911         Add API test coverage.
3912
3913         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3914         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3915         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3916         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3917
3918 2019-02-22  Chris Dumez  <cdumez@apple.com>
3919
3920         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3921         https://bugs.webkit.org/show_bug.cgi?id=194924
3922         <rdar://problem/48216125>
3923
3924         Reviewed by Geoffrey Garen.
3925
3926         Add API test coverage.
3927
3928         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3929
3930 2019-02-22  Chris Dumez  <cdumez@apple.com>
3931
3932         Unreviewed, disable API test added in r241928 on iOS.
3933
3934         The cache is not enabled on devices with less than 3GB of RAM.
3935
3936         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3937
3938 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3939
3940         Hardcode Visual Viewports on everywhere except iOS WK1
3941         https://bugs.webkit.org/show_bug.cgi?id=194928
3942
3943         Reviewed by Zalan Bujtas.
3944
3945         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3946         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3947         set it to false. The setting has shipped for several years and there's no need to turn
3948         it off now.
3949
3950         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3951         Visual Viewports are not enabled.
3952         
3953         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3954         that only runs in WK2
3955
3956         * MiniBrowser/mac/SettingsController.h:
3957         * MiniBrowser/mac/SettingsController.m:
3958         (-[SettingsController init]):
3959         (-[SettingsController _populateMenu]):
3960         (-[SettingsController validateMenuItem:]):
3961         (-[SettingsController visualViewportEnabled]): Deleted.
3962         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3963         * MiniBrowser/mac/WK1BrowserWindowController.m:
3964         (-[WK1BrowserWindowController didChangeSettings]):
3965         * MiniBrowser/mac/WK2BrowserWindowController.m:
3966         (-[WK2BrowserWindowController didChangeSettings]):
3967
3968 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3969
3970         Discard cached processes when clearing website data store
3971         https://bugs.webkit.org/show_bug.cgi?id=194894
3972
3973         Reviewed by Chris Dumez.
3974
3975         Added a test case.
3976
3977         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3978         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3979
3980 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3981
3982         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3983         https://bugs.webkit.org/show_bug.cgi?id=194914
3984         <rdar://problem/47586889>
3985
3986         Reviewed by Geoffrey Garen.
3987
3988         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3989         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3990         (TEST):
3991         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3992
3993 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3994
3995         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3996         <https://webkit.org/b/194761>
3997
3998         Reviewed by Myles Maxfield.
3999
4000         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4001         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4002         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4003         to use ARC-compliant cast.
4004         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4005         ARC-compliant cast.
4006         (WTR::installFakeHelvetica): Log `error` to console if
4007         CTFontManagerRegisterFontsForURL() fails, but only on supported
4008         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4009         Call CFRelease() on `error` to fix the leak.  Update to use
4010         ARC-compliant cast.
4011         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4012         cast.
4013
4014 2019-02-21  Chris Dumez  <cdumez@apple.com>
4015
4016         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4017         https://bugs.webkit.org/show_bug.cgi?id=194481
4018
4019         Reviewed by Alex Christensen.
4020
4021         Give the processes a chance to shutdown and wait until we reached the expected number
4022         of processes.
4023
4024         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4025
4026 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4027
4028         Fix the macOS build
4029
4030         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4031
4032 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4033
4034         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4035
4036         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4037         I am a backwards.
4038
4039 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4040
4041         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4042
4043         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4044         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4045         We could force on UI-side compositing, but I feel like the test might be more
4046         valuable exercising the normal path on each platform (though the original
4047         bug was also UI-side specific). Though we can't validate that the overlay
4048         layer was installed successfully, there are layout tests that do that.
4049
4050 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4051
4052         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4053         https://bugs.webkit.org/show_bug.cgi?id=194845
4054         <rdar://problem/47944579>
4055
4056         Reviewed by Antti Koivisto.
4057
4058         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4059         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4060
4061 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4062
4063         [LFC][Floats] Add support for placing formatting roots in-between floats.
4064         https://bugs.webkit.org/show_bug.cgi?id=194902
4065
4066         Reviewed by Antti Koivisto.
4067
4068         * LayoutReloaded/misc/LFC-passing-tests.txt:
4069
4070 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4071
4072         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4073         https://bugs.webkit.org/show_bug.cgi?id=194901
4074
4075         Unreviewed build fix.
4076
4077         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4078         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4079         WPEBackend-fdo-0.1 as library name.
4080
4081 2019-02-21  Rob Buis  <rbuis@igalia.com>
4082
4083         Update MIME type parser
4084         https://bugs.webkit.org/show_bug.cgi?id=180526
4085
4086         Reviewed by Darin Adler.
4087
4088         Add tests involving leading and trailing whitespace, non-token
4089         characters and quoted strings.
4090
4091         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4092         (TestWebKitAPI::TEST):
4093
4094 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4095
4096         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4097         https://bugs.webkit.org/show_bug.cgi?id=194884
4098
4099         Reviewed by Michael Catanzaro.
4100
4101         * PlatformWin.cmake:
4102
4103 2019-02-20  Chris Dumez  <cdumez@apple.com>
4104
4105         Add API test for <rdar://problem/47471222>
4106         https://bugs.webkit.org/show_bug.cgi?id=194847
4107
4108         Reviewed by Alex Christensen.
4109
4110         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4111
4112 2019-02-20  Chris Dumez  <cdumez@apple.com>
4113
4114         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4115         https://bugs.webkit.org/show_bug.cgi?id=194872
4116         <rdar://problem/47924500>
4117
4118         Reviewed by Alex Christensen.
4119
4120         Add API test coverage.
4121
4122         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4123
4124 2019-02-20  Jer Noble  <jer.noble@apple.com>
4125
4126         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4127         https://bugs.webkit.org/show_bug.cgi?id=191332
4128
4129         Reviewed by Dean Jackson.
4130
4131         * Scripts/git-is-in-range: Added.
4132
4133 2019-02-20  Andy Estes  <aestes@apple.com>
4134
4135         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4136         https://bugs.webkit.org/show_bug.cgi?id=194869
4137
4138         Rubber-stamped by Jer Noble.
4139
4140         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4141         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4142         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4143         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4145         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4146
4147 2019-02-20  Chris Dumez  <cdumez@apple.com>
4148
4149         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4150         https://bugs.webkit.org/show_bug.cgi?id=194857
4151         <rdar://problem/47759323>
4152
4153         Reviewed by Alex Christensen.
4154
4155         Add API test coverage.
4156
4157         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4158
4159 2019-02-20  Chris Dumez  <cdumez@apple.com>
4160
4161         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4162         https://bugs.webkit.org/show_bug.cgi?id=194829
4163         <rdar://problem/47889906>
4164
4165         Reviewed by Alexey Proskuryakov.
4166
4167         Every time the TestOptions were changing we were creating both a new Web view and
4168         a new WKContext, which would start a new Network process. In most cases, we only
4169         need to contruct a new Web view and we do can keep reusing the same WKContext.
4170         This patch implements this optimization and thus avoids spinning a lot of new
4171         Network processes while running the layout tests.
4172
4173         * WebKitTestRunner/TestController.cpp:
4174         (WTR::TestController::generateContextConfiguration const):
4175         (WTR::TestController::generatePageConfiguration):
4176         (WTR::TestController::createWebViewWithOptions):
4177         (WTR::TestController::resetPreferencesToConsistentValues):
4178         (WTR::updateTestOptionsFromTestHeader):
4179         * WebKitTestRunner/TestController.h:
4180         * WebKitTestRunner/TestOptions.h:
4181         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4182         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4183         (WTR::TestOptions::hasSameInitializationOptions const):
4184         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4185         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4186         (WTR::TestController::platformAddTestOptions const):
4187
4188 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4189
4190         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4191         https://bugs.webkit.org/show_bug.cgi?id=167941
4192
4193         Reviewed by Carlos Garcia Campos.
4194
4195         * MiniBrowser/gtk/main.c:
4196         (filterSavedCallback): Added.
4197         (main): Support loading a JSON rule set file for content filtering.
4198         * MiniBrowser/wpe/main.cpp:
4199         (filterSavedCallback): Added.
4200         (main): Support loading a JSON rule set file for content filtering.
4201         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4202         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4203         (WTF::derefGPtr): Ditto.
4204         (testEmptyStore):
4205         (testSaveInvalidFilter):
4206         (testSaveLoadFilter):
4207         (testSavedFilterIdentifierMatch):
4208         (testRemoveFilter):
4209         (testSaveMultipleFilters):
4210         (testSaveFilterFromFile):
4211         (testFilterPersistence):
4212         (beforeAll):
4213         (afterAll):
4214         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4215         (removeOldInjectedContentAndResetLists): Also reset content filters.
4216         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4217         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4218         the element affected by the style sheet.
4219         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4220         and returns it to be used by tests.
4221         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4222         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4223         (serverCallback): Add support for serving a CSS style sheet for testing.
4224         (beforeAll): Add call to testUserContentManagerContentFilter().
4225         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4226
4227 2019-02-19  Keith Rollin  <krollin@apple.com>
4228
4229         Add timing information to build output
4230         https://bugs.webkit.org/show_bug.cgi?id=194839
4231         <rdar://problem/48219609>
4232
4233         Reviewed by Alexey Proskuryakov.
4234
4235         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4236         emit each project's build time to its output. E.g.,
4237
4238             ** BUILD SUCCEEDED ** [0.132 sec]
4239
4240         * Scripts/webkitdirs.pm:
4241         (XcodeOptions):
4242
4243 2019-02-19  Truitt Savell  <tsavell@apple.com>
4244
4245         Unreviewed, rolling out r241784.
4246
4247         Broke all OpenSource builds.
4248
4249         Reverted changeset:
4250
4251         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4252         instances view"
4253         https://bugs.webkit.org/show_bug.cgi?id=172848
4254         https://trac.webkit.org/changeset/241784
4255
4256 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4257
4258         [LFC][Floats] Remove redundant intersecting logic
4259         https://bugs.webkit.org/show_bug.cgi?id=194804
4260
4261         Reviewed by Antti Koivisto.
4262
4263         * LayoutReloaded/misc/LFC-passing-tests.txt:
4264
4265 2019-02-19  Dean Jackson  <dino@apple.com>
4266
4267         Clean-up output from generate-xcfilelists so it can be filtered
4268         https://bugs.webkit.org/show_bug.cgi?id=194795
4269
4270         Reviewed by Joseph Pecoraro (and Keith Rollin).
4271
4272         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4273         make a slight tweak to filter-build-webkit so such lines are marked
4274         as plain.
4275
4276         * Scripts/filter-build-webkit:
4277         * Scripts/generate-xcfilelists:
4278
4279 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4280
4281         pytest is not correctly auto-installed
4282         https://bugs.webkit.org/show_bug.cgi?id=194707
4283
4284         Reviewed by Carlos Garcia Campos.
4285
4286         * Scripts/webkitpy/thirdparty/__init__.py:
4287         (AutoinstallImportHook._install_pytest):
4288
4289 2019-02-18  Chris Dumez  <cdumez@apple.com>
4290
4291         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4292         https://bugs.webkit.org/show_bug.cgi?id=194797
4293         <rdar://problem/48055151>
4294
4295         Reviewed by Geoffrey Garen.
4296
4297         Add API test coverage.
4298
4299         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4300
4301 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4302
4303         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4304         https://bugs.webkit.org/show_bug.cgi?id=194670
4305         <rdar://problem/39066529>
4306
4307         Reviewed by Tim Horton.
4308
4309         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4310         pasted in an editable area as attachment elements.
4311
4312         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4313         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4314         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4315         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4316         (TestWebKitAPI::TEST):
4317         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4318         (WTR::InjectedBundlePage::InjectedBundlePage):
4319
4320 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4321
4322         Fix API test after r241728
4323        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4324
4325         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4326         (TEST):
4327         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4328
4329 2019-02-18  Daniel Bates  <dabates@apple.com>
4330
4331         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4332         https://bugs.webkit.org/show_bug.cgi?id=192824
4333         <rdar://problem/47100332>
4334
4335         Reviewed by Wenson Hsieh.
4336
4337         Fix a bug where the wrong usage code was used for F13 thru F24.
4338
4339         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4340         (keyCodeForDOMFunctionKey):
4341
4342 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4343
4344         Bytecode cache should a have a boot-specific validation
4345         https://bugs.webkit.org/show_bug.cgi?id=194769
4346         <rdar://problem/48149509>
4347
4348         Reviewed by Keith Miller.
4349
4350         Add test for WTF::bootSessionUUIDString()
4351
4352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4353         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4354         (TEST):
4355
4356 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4357
4358         Disable safe browsing in WKWebView and remove its WKPreferences API
4359         https://bugs.webkit.org/show_bug.cgi?id=194723
4360         <rdar://problem/48122993>
4361
4362         Reviewed by Geoffrey Garen.
4363