Temporarily disable generate-xcfilelists
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-06  Keith Rollin  <krollin@apple.com>
2
3         Temporarily disable generate-xcfilelists
4         https://bugs.webkit.org/show_bug.cgi?id=197619
5         <rdar://problem/50507392>
6
7         Reviewed by Alex Christensen.
8
9         We need to perform a significant update to the generate-xcfilelist
10         scripts. This work involves coordinated work with another facility. If
11         the work does not occur in tandem, the build will be broken. To avoid
12         this, disable the invoking of the scripts during the transition. The
13         checking will be restored once the new scripts are in place.
14
15         * DumpRenderTree/Scripts/check-xcfilelists.sh:
16         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
17
18 2019-05-04  Alex Christensen  <achristensen@webkit.org>
19
20         Revert r244953 and r244954 because they broke internal builds.
21         https://bugs.webkit.org/show_bug.cgi?id=197534
22
23         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
24         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
25         * DumpRenderTree/mac/DumpRenderTree.mm:
26         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
27         * DumpRenderTree/mac/TestRunnerMac.mm:
28         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
29         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
30         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
31         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
32         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
33         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
34         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
35         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
36         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
37         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
38         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
39         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
40         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
41         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
42         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
43         * TestWebKitAPI/cocoa/TestWKWebView.mm:
44         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
45         * TestWebKitAPI/ios/UIKitSPI.h: Added.
46         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
47         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
48         * WebKitTestRunner/ios/HIDEventGenerator.h:
49         * WebKitTestRunner/ios/HIDEventGenerator.mm:
50         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
51         * WebKitTestRunner/ios/TestControllerIOS.mm:
52         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
53         * WebKitTestRunner/ios/mainIOS.mm:
54
55 2019-05-04  Alex Christensen  <achristensen@webkit.org>
56
57         Merge the three UIKitSPI.h files into a single one in PAL
58         https://bugs.webkit.org/show_bug.cgi?id=197534
59
60         Reviewed by Darin Adler.
61
62         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
63         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
64         * DumpRenderTree/mac/DumpRenderTree.mm:
65         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
66         * DumpRenderTree/mac/TestRunnerMac.mm:
67         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
68         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
69         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
70         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
71         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
72         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
73         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
74         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
75         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
76         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
77         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
78         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
79         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
80         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
81         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
82         * TestWebKitAPI/cocoa/TestWKWebView.mm:
83         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
84         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
85         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
86         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
87         * WebKitTestRunner/ios/HIDEventGenerator.h:
88         * WebKitTestRunner/ios/HIDEventGenerator.mm:
89         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
90         * WebKitTestRunner/ios/TestControllerIOS.mm:
91         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
92         * WebKitTestRunner/ios/mainIOS.mm:
93
94 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
95
96         Web Inspector: Provide UIString descriptions to improve localizations
97         https://bugs.webkit.org/show_bug.cgi?id=195132
98         <rdar://problem/48457817>
99
100         Reviewed by Devin Rousso.
101
102         Allow WI.UIString to take:
103         - WI.UIString(string, key, comment)
104         - WI.UIString(string, comment)
105         - WI.UIString(string)
106
107         * Scripts/extract-localizable-js-strings:
108
109 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
110
111         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
112         https://bugs.webkit.org/show_bug.cgi?id=197579
113
114         Reviewed by Tim Horton.
115
116         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
117         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
118         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
119         ensure that the the focused element has been blurred.
120
121         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
122
123 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
124
125         Add a tool to block spammer accounts
126         https://bugs.webkit.org/show_bug.cgi?id=197537
127
128         Reviewed by Darin Adler.
129
130         Usage: block-spammers email1 email2 ...
131
132         The tool finds and hides all bugs and comments from this account. Before any work
133         is done, these bugs and comments are displayed for confirmation.
134
135         * Scripts/block-spammers: Added.
136         (get_bugzilla_token):
137         (invalidate_bugzilla_token):
138         (get_user_info):
139         (get_user_info_self):
140         (can_use_this_tool):
141         (disable_user):
142         (get_bugs_created_by_user):
143         (get_bugs_commented_on_by_user):
144         (get_comments):
145         (hide_bug):
146         (hide_comments):
147         (ask_yes_no):
148         (sanitized_string):
149         (main):
150
151 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
152
153         run-apit-tests: Add --iterations and --repeat-each
154         https://bugs.webkit.org/show_bug.cgi?id=197563
155
156         Reviewed by Aakash Jain.
157
158         * Scripts/webkitpy/api_tests/manager.py:
159         (Manager.run): Add --iterations and --repeat-each/
160         * Scripts/webkitpy/api_tests/run_api_tests.py:
161         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
162
163 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
164
165         New EWS: Clicking on white bubble navigates to page with only bubbles
166         https://bugs.webkit.org/show_bug.cgi?id=197520
167
168         Reviewed by Lucas Forschler.
169
170         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
171
172 2019-05-03  Daniel Bates  <dabates@apple.com>
173
174         [lldb-webkit] Support adding pretty-printing for qualified types
175         https://bugs.webkit.org/show_bug.cgi?id=197518
176
177         Reviewed by Darin Adler.
178
179         Remove all "::"s from the name of the specified type when computing the name for the Python classes
180         that will provide summary and synthetic details as LLDB is not happy about registering such classes
181         when they contain :: in their name.
182
183         * lldb/lldb_webkit.py:
184         (addSummaryAndSyntheticFormattersForRawBitmaskType):
185
186 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
187
188         New EWS: patches on recently added queues listed as #1 for older bugs
189         https://bugs.webkit.org/show_bug.cgi?id=197496
190
191         Reviewed by Lucas Forschler.
192
193         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
194         (StatusBubble._build_bubble):
195         (StatusBubble._queue_position):
196
197 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
198
199         webkit-patch --no-review upload does not submit patch to New EWS
200         https://bugs.webkit.org/show_bug.cgi?id=197519
201         <rdar://problem/50424887>
202
203         Reviewed by Lucas Forschler.
204
205         * Scripts/webkitpy/tool/steps/submittoews.py:
206         (SubmitToEWS.run): Submit to both old and new EWS.
207         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
208         * Scripts/webkitpy/common/net/ewsserver.py: Added.
209         (EWSServer._server_url): Method to return server url.
210         (EWSServer._post_patch_to_ews): Method to post patch to ews.
211         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
212         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
213         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
214         * Scripts/webkitpy/common/net/statusserver_mock.py:
215         (MockStatusServer.submit_to_ews): Updated the log text.
216         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
217         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
218         * Scripts/webkitpy/tool/main.py:
219         (WebKitPatch.__init__): Initialize ews_server. 
220         * Scripts/webkitpy/tool/mocktool.py:
221         (MockTool.__init__): Ditto.
222
223 2019-05-03  Chris Dumez  <cdumez@apple.com>
224
225         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
226         https://bugs.webkit.org/show_bug.cgi?id=197574
227         <rdar://problem/50453181>
228
229         Reviewed by Tim Horton.
230
231         Add API test coverage.
232
233         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
234         (TEST):
235
236 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
237
238         [JSC] Generator CodeBlock generation should be idempotent
239         https://bugs.webkit.org/show_bug.cgi?id=197552
240
241         Reviewed by Keith Miller.
242
243         * Scripts/run-javascriptcore-tests:
244         (runJSCStressTests):
245         * Scripts/run-jsc-stress-tests:
246
247 2019-05-03  Commit Queue  <commit-queue@webkit.org>
248
249         Unreviewed, rolling out r244881.
250         https://bugs.webkit.org/show_bug.cgi?id=197559
251
252         Breaks compilation of jsconly on linux, breaking compilation
253         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
254         guijemont on #webkit).
255
256         Reverted changeset:
257
258         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
259         WEBKIT_COPY_FILES"
260         https://bugs.webkit.org/show_bug.cgi?id=197174
261         https://trac.webkit.org/changeset/244881
262
263 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
264
265         Unreviewed WPE build fix after r244898.
266
267         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
268         (WTR::TestController::abortModal): Add the missing (no-op) definition.
269
270 2019-05-02  Alex Christensen  <achristensen@webkit.org>
271
272         Mark U+01C0 as a homograph of U+006C
273         https://bugs.webkit.org/show_bug.cgi?id=197526
274         <rdar://problem/50301904>
275
276         Reviewed by Tim Horton.
277
278         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
279         (TestWebKitAPI::TEST):
280
281 2019-05-02  Chris Dumez  <cdumez@apple.com>
282
283         Add test coverage for <rdar://problem/49731231>
284         https://bugs.webkit.org/show_bug.cgi?id=196730
285         <rdar://problem/49731231>
286
287         Reviewed by Ryosuke Niwa.
288
289         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
290         to match DumpRenderTree.
291
292         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
293         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
294         (WTR::TestRunner::abortModal):
295         * WebKitTestRunner/InjectedBundle/TestRunner.h:
296         * WebKitTestRunner/TestController.cpp:
297         (WTR::TestController::runModal):
298         * WebKitTestRunner/TestController.h:
299         * WebKitTestRunner/TestInvocation.cpp:
300         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
301         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
302         (WTR::TestController::abortModal):
303         * WebKitTestRunner/ios/TestControllerIOS.mm:
304         (WTR::TestController::abortModal):
305         * WebKitTestRunner/mac/TestControllerMac.mm:
306         (WTR::TestController::abortModal):
307         * WebKitTestRunner/win/TestControllerWin.cpp:
308         (WTR::TestController::abortModal):
309
310 2019-05-02  Christopher Reid  <chris.reid@sony.com>
311
312         [CMake] Add support for LTO builds
313         https://bugs.webkit.org/show_bug.cgi?id=188986
314
315         Reviewed by Don Olmstead.
316
317         Add support to configure --lto-mode with cmake builds.
318
319         * Scripts/build-webkit:
320         * Scripts/webkitdirs.pm:
321         (generateBuildSystemFromCMakeProject):
322
323 2019-05-02  John Wilander  <wilander@apple.com>
324
325         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
326         https://bugs.webkit.org/show_bug.cgi?id=197521
327         <rdar://problem/49651503>
328
329         Reviewed by Brent Fulgham.
330
331         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
332         (TestWebKitAPI::TEST):
333            Added a test for host strings with leading dots since they are
334            often used for the domain attribute in cookies.
335
336 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
337
338         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
339         https://bugs.webkit.org/show_bug.cgi?id=197510
340
341         Reviewed by Alex Christensen.
342
343         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
344         (TestWebKitAPI::TEST):
345
346 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
347
348         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
349         https://bugs.webkit.org/show_bug.cgi?id=197174
350
351         Reviewed by Alex Christensen.
352
353         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
354
355         * TestWebKitAPI/PlatformGTK.cmake:
356         * TestWebKitAPI/PlatformWPE.cmake:
357
358 2019-05-02  Alex Christensen  <achristensen@webkit.org>
359
360         Build fix for internal branch.
361
362         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
363         RetainPtr.h was not explicitly included.
364
365 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
366
367         webkitpy: Ignore errors when shutting down an already shutdown simulator
368         <https://bugs.webkit.org/show_bug.cgi?id=197514>
369         <rdar://problem/50390247>
370
371         Reviewed by Lucas Forschler.
372
373         * Scripts/webkitpy/xcode/simulated_device.py:
374         (SimulatedDevice._shut_down):
375
376 2019-05-02  Frederic Wang  <fwang@igalia.com>
377
378         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
379         https://bugs.webkit.org/show_bug.cgi?id=196142
380
381         This patch introduces some experimental runtime flag to let users
382         disable MathML features that are removed from MathML Core [1]. For now,
383         these features are only disabled on GTK and WPE ports.
384
385         [1] https://mathml-refresh.github.io/mathml-core/
386
387         Reviewed by Rob Buis.
388
389         * DumpRenderTree/TestOptions.cpp:
390         (TestOptions::TestOptions):
391         * DumpRenderTree/TestOptions.h:
392         * DumpRenderTree/mac/DumpRenderTree.mm:
393         (setWebPreferencesForTestOptions):
394
395 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
396
397         TestWebKitAPI config.h should be aware of what suite is being built
398         https://bugs.webkit.org/show_bug.cgi?id=196583
399
400         Reviewed by Konstantin Tokarev.
401
402         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
403         benefit the macro defines BUILDING_* for the executable which allows the includes
404         of the config.h to be tailored to the test suite being built. Because of that the
405         dependencies of the Test* executable are specific to the test suite which may
406         speed up the build.
407
408         Some source files were including "PlatformUtilities.h" which includes WebKit headers
409         when "Utilities.h" is what was needed.
410
411         * TestWebKitAPI/CMakeLists.txt:
412         * TestWebKitAPI/PlatformGTK.cmake:
413         * TestWebKitAPI/PlatformJSCOnly.cmake:
414         * TestWebKitAPI/PlatformMac.cmake:
415         * TestWebKitAPI/PlatformPlayStation.cmake:
416         * TestWebKitAPI/PlatformUtilities.h:
417         * TestWebKitAPI/PlatformWPE.cmake:
418         * TestWebKitAPI/PlatformWin.cmake:
419         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
420         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
421         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
422         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
423         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
424         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
425         * TestWebKitAPI/config.h:
426
427 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
428
429         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
430         https://bugs.webkit.org/show_bug.cgi?id=181950
431         <rdar://problem/43357371>
432
433         Reviewed by Brent Fulgham.
434
435         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
436         (TestWebKitAPI::TEST_F):
437
438 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
439
440         Remove webkitpy and bindings EWS queues from dashboard
441         https://bugs.webkit.org/show_bug.cgi?id=197475
442
443         Reviewed by Alexey Proskuryakov.
444
445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
446
447 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
448
449         Remove webkitpy and bindings test queues from old EWS
450         https://bugs.webkit.org/show_bug.cgi?id=197468
451
452         Reviewed by Alexey Proskuryakov.
453
454         * QueueStatusServer/config/queues.py:
455
456 2019-04-30  Tim Horton  <timothy_horton@apple.com>
457
458         Fix the WebKitTestRunner build
459         https://bugs.webkit.org/show_bug.cgi?id=197449
460         <rdar://problem/50334169>
461
462         Reviewed by Alexey Proskuryakov.
463
464         * WebKitTestRunner/mac/EventSenderProxy.mm:
465         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
466         (WTR::EventSenderProxy::mouseForceChanged):
467         Use some SPI instead of IPI.
468
469 2019-04-30  Chris Dumez  <cdumez@apple.com>
470
471         Regression(PSON) URL scheme handlers can no longer respond asynchronously
472         https://bugs.webkit.org/show_bug.cgi?id=197426
473         <rdar://problem/50256169>
474
475         Reviewed by Brady Eidson.
476
477         Add API test coverage.
478
479         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
480         (-[PSONScheme setShouldRespondAsynchronously:]):
481         (-[PSONScheme webView:startURLSchemeTask:]):
482         (-[PSONScheme webView:stopURLSchemeTask:]):
483
484 2019-04-30  Chris Dumez  <cdumez@apple.com>
485
486         Unreviewed, rolling out r244802.
487
488         Caused an API test failure
489
490         Reverted changeset:
491
492         "Regression(PSON) URL scheme handlers can no longer respond
493         asynchronously"
494         https://bugs.webkit.org/show_bug.cgi?id=197426
495         https://trac.webkit.org/changeset/244802
496
497 2019-04-30  Chris Dumez  <cdumez@apple.com>
498
499         Regression(PSON) URL scheme handlers can no longer respond asynchronously
500         https://bugs.webkit.org/show_bug.cgi?id=197426
501         <rdar://problem/50256169>
502
503         Reviewed by Brady Eidson.
504
505         Add API test coverage.
506
507         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
508         (-[PSONScheme setShouldRespondAsynchronously:]):
509         (-[PSONScheme webView:startURLSchemeTask:]):
510         (-[PSONScheme webView:stopURLSchemeTask:]):
511
512 2019-04-30  Chris Dumez  <cdumez@apple.com>
513
514         Only use a related page's process if that page has not been closed yet
515         https://bugs.webkit.org/show_bug.cgi?id=197393
516         <rdar://problem/50302423>
517
518         Reviewed by Tim Horton.
519
520         Add API test coverage.
521
522         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
523
524 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
525
526         [ews-build] Enable Bindings tests queue on new EWS
527         https://bugs.webkit.org/show_bug.cgi?id=197424
528
529         Reviewed by Lucas Forschler.
530
531         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
532         (StatusBubble):
533         * BuildSlaveSupport/ews-build/config.json:
534
535 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
536
537         [ews-build] Configure ews151 for running various tests
538         https://bugs.webkit.org/show_bug.cgi?id=197419
539
540         Reviewed by Lucas Forschler.
541
542         * BuildSlaveSupport/ews-build/config.json:
543
544 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
545
546         [ews-build] Parse and display bindings test failures
547         https://bugs.webkit.org/show_bug.cgi?id=197423
548
549         Reviewed by Lucas Forschler.
550
551         * BuildSlaveSupport/ews-build/steps.py:
552         (RunBindingsTests.__init__): Set timeout of 5 minutes.
553         (RunBindingsTests.start): Initialize log_observer for json output.
554         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
555         (RunBindingsTests._addToLog): Method to add message to log.
556         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
557
558 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
559
560         Unreviewed. Add myself as a committer.
561
562         * Scripts/webkitpy/common/config/contributors.json:
563
564 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
565
566         [ews-build] Enable webkitpy queue on new EWS
567         https://bugs.webkit.org/show_bug.cgi?id=197396
568
569         Reviewed by Lucas Forschler.
570
571         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
572         (StatusBubble):
573         * BuildSlaveSupport/ews-build/config.json:
574
575 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
576
577         [ews-build] Parse and display webkitpy failures
578         https://bugs.webkit.org/show_bug.cgi?id=197395
579
580         Reviewed by Lucas Forschler.
581
582         * BuildSlaveSupport/ews-build/steps.py:
583         (RunWebKitPyTests.start): Initialize log_observer for json output.
584         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
585         (RunWebKitPyTests._addToLog): Method to add message to log.
586         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
587
588 2019-04-29  Alex Christensen  <achristensen@webkit.org>
589
590         <rdar://problem/50299396> Fix internal High Sierra build
591         https://bugs.webkit.org/show_bug.cgi?id=197388
592
593         * DumpRenderTree/mac/Configurations/Base.xcconfig:
594         * MiniBrowser/Configurations/Base.xcconfig:
595         * MobileMiniBrowser/Configurations/Base.xcconfig:
596         * TestWebKitAPI/Configurations/Base.xcconfig:
597         * WebKitTestRunner/Configurations/Base.xcconfig:
598
599 2019-04-29  Youenn Fablet  <youenn@apple.com>
600
601         Remove spurious GVA printf logging
602         https://bugs.webkit.org/show_bug.cgi?id=197368
603         <rdar://problem/35975256>
604
605         Reviewed by Alexey Proskuryakov.
606
607         * Scripts/webkitpy/port/mac.py:
608         (MacPort.logging_patterns_to_strip):
609
610 2019-04-29  Youenn Fablet  <youenn@apple.com>
611
612         getDisplayMedia should be called on user gesture
613         https://bugs.webkit.org/show_bug.cgi?id=197356
614         <rdar://problem/50296074>
615
616         Reviewed by Eric Carlson.
617
618         Update test configuration to inject internals
619         so that we can use it to simulate a user click to call getDisplayMedia.
620
621         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
622         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
623         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
624
625 2019-04-26  Stephanie Lewis  <slewis@apple.com>
626
627         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
628         https://bugs.webkit.org/show_bug.cgi?id=197339
629
630         Reviewed by Dewei Zhu.
631
632         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
633         test run for setup steps that are too expensive to do every iteration.
634
635         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
636         (BenchmarkRunner._run_benchmark):
637         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
638         (BrowserDriver):
639         (BrowserDriver.prepare_initial_env):
640         (BrowserDriver.restore_env_after_all_testing):
641         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
642         (LinuxBrowserDriver.prepare_initial_env):
643         (LinuxBrowserDriver.restore_env_after_all_testing):
644         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
645         (OSXBrowserDriver.prepare_initial_env):
646         (OSXBrowserDriver.restore_env_after_all_testing):
647
648 2019-04-28  Andy Estes  <aestes@apple.com>
649
650         Fix the watchOS engineering build.
651
652         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
653         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
654
655 2019-04-27  Chris Dumez  <cdumez@apple.com>
656
657         [WKTR] Move test timeout handling to the UIProcess
658         https://bugs.webkit.org/show_bug.cgi?id=197333
659
660         Reviewed by Darin Adler.
661
662         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
663         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
664         every WebContent process in the case of swapping.
665
666         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
667         would lead to crashes when firing the timer.
668
669         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
670         (WTR::InjectedBundle::didReceiveMessageToPage):
671         (WTR::InjectedBundle::done):
672         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
673         (WTR::InjectedBundle::shouldDumpPixels const):
674         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
675         (WTR::TestRunner::TestRunner):
676         (WTR::TestRunner::waitUntilDone):
677         (WTR::TestRunner::setWaitUntilDone):
678         * WebKitTestRunner/InjectedBundle/TestRunner.h:
679         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
680         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
681         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
682         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
683         * WebKitTestRunner/TestInvocation.cpp:
684         (WTR::TestInvocation::TestInvocation):
685         (WTR::TestInvocation::createTestSettingsDictionary):
686         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
687         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
688         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
689         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
690         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
691         (WTR::TestInvocation::setWaitUntilDone):
692         (WTR::TestInvocation::done):
693         * WebKitTestRunner/TestInvocation.h:
694
695 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
696
697         [JSC] linkPolymorphicCall now does GC
698         https://bugs.webkit.org/show_bug.cgi?id=197306
699
700         Reviewed by Saam Barati.
701
702         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
703         To add this test, we add `runWithoutBaseOption`.
704
705         * Scripts/run-jsc-stress-tests:
706
707 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
708
709         Update inactive reviewers' status to 'contributor'.
710
711         Accidentally skipped one at first.
712
713         * Scripts/webkitpy/common/config/contributors.json:
714
715 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
716
717         Update inactive reviewers' status to 'contributor'.
718
719         * Scripts/webkitpy/common/config/contributors.json: The change.
720
721         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
722         * Scripts/webkitpy/common/checkout/checkout_mock.py:
723         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
724         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
725         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
726         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
727         * Scripts/webkitpy/tool/commands/queries_unittest.py:
728         * Scripts/webkitpy/tool/commands/upload_unittest.py:
729         Sadly, regression tests operate on a crazy mix of mock and live data for
730         contributors.json. It would be a substantial project to mock all code paths,
731         so changing the tests instead.
732
733 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
734
735         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
736         https://bugs.webkit.org/show_bug.cgi?id=197171
737         <rdar://problem/47454979>
738
739         Reviewed by Youenn Fablet.
740
741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
742         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
743         (TestWebKitAPI::TEST):
744
745 2019-04-26  David Kilzer  <ddkilzer@apple.com>
746
747         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
748         <https://webkit.org/b/197314>
749         <rdar://problem/50245252>
750
751         Reviewed by Simon Fraser.
752
753         * WebKitTestRunner/UIScriptControllerCocoa.mm:
754         (WTR::UIScriptController::lastUndoLabel const):
755         (WTR::UIScriptController::firstRedoLabel const):
756         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
757
758         * WebKitTestRunner/ios/HIDEventGenerator.mm:
759         (-[HIDEventGenerator sendEventStream:completionBlock:]):
760         - Call -autorelease to fix leak of NSDictionary.
761
762         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
763         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
764         (WTR::UIScriptController::selectFormPopoverTitle const):
765         (WTR::UIScriptController::textContentType const):
766         (WTR::UIScriptController::formInputLabel const):
767         (WTR::UIScriptController::scrollingTreeAsText const):
768         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
769
770 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
771
772         webkitpy: Running a single test will always use the default device
773         https://bugs.webkit.org/show_bug.cgi?id=195472
774         <rdar://problem/48724825>
775
776         Reviewed by Lucas Forschler.
777
778         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
779         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
780         requested will be run regardless of what shard they are in.
781
782         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
783         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
784         * Scripts/webkitpy/layout_tests/controllers/manager.py:
785         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
786         on the default device type.
787         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
788         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
789         (RunTest.test_run_part): Ditto.
790
791 2019-04-26  Alex Christensen  <achristensen@webkit.org>
792
793         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
794         https://bugs.webkit.org/show_bug.cgi?id=197165
795
796         Reviewed by Youenn Fablet.
797
798         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
799
800 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
801
802         Replace iOS build queue hardware
803         https://bugs.webkit.org/show_bug.cgi?id=197312
804
805         Reviewed by Aakash Jain.
806
807         * BuildSlaveSupport/build.webkit.org-config/config.json:
808         Use newer hardware that supports macOS Mojave.
809
810 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
811
812         check-webkit-style complains the first block in while loop.
813         https://bugs.webkit.org/show_bug.cgi?id=197307
814
815         The style checker shouldn't complain about an open brace on
816         its own line if the last non-whitespace character on the previous
817         non-blank line is another open brace, because it's likely to
818         indicate the begining of a nested code block.
819
820         Reviewed by Alex Christensen.
821
822         * Scripts/webkitpy/style/checkers/cpp.py:
823         (check_braces):
824         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
825         (WebKitStyleTest.test_braces):
826
827 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
828
829         Stop IDB transactions to release locked database files when network process is ready to suspend
830         https://bugs.webkit.org/show_bug.cgi?id=196372
831         <rdar://problem/48930116>
832
833         Reviewed by Brady Eidson.
834
835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
836         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
837         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
838         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
839         (runTestAndCheckResult):
840         (keepNetworkProcessActive):
841         (TEST):
842
843 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
844
845         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
846         https://bugs.webkit.org/show_bug.cgi?id=188357
847         <rdar://problem/42986633>
848
849         Reviewed by Dean Jackson.
850
851         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
852         tests would fall into low memory mode and have different behavior.
853         
854         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
855         to Internals, so it's shared by DRT and WTR.
856         
857         We no longer need the WK2 C SPI glue.
858
859         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
860         (WTR::InjectedBundlePage::prepare):
861
862 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
863
864         webkitpy: Including skipped tests in the final count
865         https://bugs.webkit.org/show_bug.cgi?id=197298
866         <rdar://problem/49705424>
867
868         Reviewed by Lucas Forschler.
869
870         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
871         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
872
873 2019-04-25  Timothy Hatcher  <timothy@apple.com>
874
875         Disable date and time inputs on iOSMac.
876         https://bugs.webkit.org/show_bug.cgi?id=197287
877         rdar://problem/46794376
878
879         Reviewed by Wenson Hsieh.
880
881         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
882
883 2019-04-25  Alex Christensen  <achristensen@webkit.org>
884
885         Fix test-webkitpy after r244653
886         https://bugs.webkit.org/show_bug.cgi?id=197131
887
888         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
889         Also use C++17.
890
891 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
892
893         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
894         https://bugs.webkit.org/show_bug.cgi?id=196991
895         <rdar://problem/45507423>
896
897         Reviewed by Alex Christensen.
898
899         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
900         (-[NavigationTestDelegate init]):
901         (-[NavigationTestDelegate waitForDidFinishNavigation]):
902         (-[NavigationTestDelegate webView:didFinishNavigation:]):
903         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
904         (TestWebKitAPI::TEST):
905         (TEST): Deleted.
906
907 2019-04-25  Alex Christensen  <achristensen@webkit.org>
908
909         Revert some code accidentally committed with r244653
910         https://bugs.webkit.org/show_bug.cgi?id=197131
911
912         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
913         (TestWebKitAPI::TEST):
914
915 2019-04-25  Alex Christensen  <achristensen@webkit.org>
916
917         Start using C++17
918         https://bugs.webkit.org/show_bug.cgi?id=197131
919
920         Reviewed by Darin Adler.
921
922         * DumpRenderTree/mac/Configurations/Base.xcconfig:
923         * MiniBrowser/Configurations/Base.xcconfig:
924         * MobileMiniBrowser/Configurations/Base.xcconfig:
925         * TestWebKitAPI/Configurations/Base.xcconfig:
926         * WebKitTestRunner/Configurations/Base.xcconfig:
927
928 2019-04-25  Commit Queue  <commit-queue@webkit.org>
929
930         Unreviewed, rolling out r244627.
931         https://bugs.webkit.org/show_bug.cgi?id=197282
932
933         Causing internal build failures (Requested by ShawnRoberts on
934         #webkit).
935
936         Reverted changeset:
937
938         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
939         https://bugs.webkit.org/show_bug.cgi?id=197171
940         https://trac.webkit.org/changeset/244627
941
942 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
943
944         [GTK] Hardcoded text color in input fields
945         https://bugs.webkit.org/show_bug.cgi?id=126907
946
947         Reviewed by Michael Catanzaro.
948
949         Add dark-mode command line option to MiniBrowser.
950
951         * MiniBrowser/gtk/main.c:
952         (main):
953
954 2019-04-24  Zalan Bujtas  <zalan@apple.com>
955
956         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
957         https://bugs.webkit.org/show_bug.cgi?id=196948
958         <rdar://problem/49927131>
959
960         Reviewed by Tim Horton.
961
962         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
963         (TEST):
964         The expected order of incoming events is
965         1. didInvalidateIntrinsicContentSize
966         2. didFirstLayout
967         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
968         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
969         (and remember, all we care about is ordering).
970
971 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
972
973         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
974         https://bugs.webkit.org/show_bug.cgi?id=197171
975         <rdar://problem/47454979>
976
977         Reviewed by Youenn Fablet.
978
979         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
980         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
981         (TestWebKitAPI::TEST):
982
983 2019-04-24  Brady Eidson  <beidson@apple.com>
984
985         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
986         https://bugs.webkit.org/show_bug.cgi?id=191362
987
988         Reviewed by Alex Christensen.
989
990         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
991           from an XHR to a custom protocol.
992
993 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
994
995         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
996         https://bugs.webkit.org/show_bug.cgi?id=197273
997
998         Reviewed by Dean Jackson.
999
1000         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
1001         so that WebCoreTestSupport::resetInternalsObject() is always run.
1002
1003         * DumpRenderTree/mac/DumpRenderTree.mm:
1004         (resetWebViewToConsistentStateBeforeTesting):
1005         (runTest):
1006
1007 2019-04-24  John Wilander  <wilander@apple.com>
1008
1009         Age out unconverted Ad Click Attributions after one week.
1010         https://bugs.webkit.org/show_bug.cgi?id=197238
1011         <rdar://problem/50177349>
1012
1013         Reviewed by Chris Dumez.
1014
1015         This patch adds infrastructure to allow tests to expire all unconverted
1016         attributions early.
1017
1018         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1019         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1020         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
1021         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1022         * WebKitTestRunner/TestController.cpp:
1023         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
1024         * WebKitTestRunner/TestController.h:
1025         * WebKitTestRunner/TestInvocation.cpp:
1026         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1027
1028 2019-04-24  Chris Dumez  <cdumez@apple.com>
1029
1030         Fix flaky crashes in a couple of PSON API tests
1031         https://bugs.webkit.org/show_bug.cgi?id=197239
1032
1033         Reviewed by Tim Horton.
1034
1035         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
1036
1037         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1038
1039 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
1040
1041         Make it possible to control the renderTreeAsText output by setting options on testRunner
1042         https://bugs.webkit.org/show_bug.cgi?id=197133
1043
1044         Reviewed by Sam Weinig.
1045
1046         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
1047         that make sense in testing (those that don't dump unstable data like addresses), and plumb
1048         these flags through the various framework layers.
1049
1050         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
1051
1052         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
1053         and hand-code DumpRenderTree bindings.
1054
1055         Some cleanup of the TestRunners, using member initializers.
1056
1057         * DumpRenderTree/TestRunner.cpp:
1058         (TestRunner::TestRunner):
1059         (setRenderTreeDumpOptionsCallback):
1060         (TestRunner::staticFunctions):
1061         (TestRunner::setRenderTreeDumpOptions):
1062         * DumpRenderTree/TestRunner.h:
1063         (TestRunner::renderTreeDumpOptions const):
1064         * DumpRenderTree/mac/DumpRenderTree.mm:
1065         (dump):
1066         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1067         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1068         (WTR::InjectedBundlePage::dump):
1069         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1070         (WTR::TestRunner::TestRunner):
1071         (WTR::TestRunner::setRenderTreeDumpOptions):
1072         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1073         (WTR::TestRunner::renderTreeDumpOptions const):
1074
1075 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1076
1077         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
1078         https://bugs.webkit.org/show_bug.cgi?id=197078
1079         <rdar://problem/49564348>
1080
1081         Reviewed by Geoff Garen.
1082
1083         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1084         (TEST_F):
1085         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
1086         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
1087         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
1088
1089 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1090
1091         Add unit test for r239322
1092         https://bugs.webkit.org/show_bug.cgi?id=197236
1093
1094         Reviewed by Chris Dumez.
1095
1096         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
1097         May as well add the test infrastructure which was needed before and will be needed in the future.
1098
1099         * TestWebKitAPI/TCPServer.cpp:
1100         (TestWebKitAPI::TCPServer::TCPServer):
1101         * TestWebKitAPI/TCPServer.h:
1102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1103         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1104         (TestWebKitAPI::TEST):
1105         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1106         (TestWebKitAPI::downloadAtRate):
1107         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1108         (TEST):
1109         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
1110         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1111         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1112         (TestWebKitAPI::TEST):
1113         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1114         (TEST):
1115
1116 2019-04-24  Chris Dumez  <cdumez@apple.com>
1117
1118         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
1119         https://bugs.webkit.org/show_bug.cgi?id=197214
1120         <rdar://problem/49237544>
1121
1122         Reviewed by Alex Christensen.
1123
1124         Extend API test coverage.
1125
1126         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1127         (TEST):
1128
1129 2019-04-24  Philippe Normand  <pnormand@igalia.com>
1130
1131         [Build][GStreamer] Update to 1.16.0
1132         https://bugs.webkit.org/show_bug.cgi?id=197157
1133
1134         Reviewed by Xabier Rodriguez-Calvar.
1135
1136         The upstreamed patches were removed and a new one was added for a
1137         regression detected in the scaletempo GStreamer element. The GNOME
1138         Flatpak was migrated to 3.32 and I switched a few modules to Meson
1139         on the way, as it is the preferred build system now in GStreamer
1140         1.16.
1141
1142         * flatpak/files/httpd-autogen.sh:
1143         * flatpak/flatpakutils.py:
1144         (FlatpakPackage.install):
1145         (WebkitFlatpak.run_in_sandbox):
1146         * flatpak/org.webkit.CommonModules.yaml:
1147         * flatpak/org.webkit.WebKit.yaml:
1148         * gstreamer/jhbuild.modules:
1149         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
1150         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
1151         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
1152         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
1153         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
1154         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
1155         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
1156         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
1157         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
1158         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1159         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
1160         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1161         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
1162         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
1163         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
1164         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
1165         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
1166         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
1167         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
1168         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
1169         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
1170         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
1171
1172 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1173
1174         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
1175         https://bugs.webkit.org/show_bug.cgi?id=197156
1176
1177         Reviewed by Michael Catanzaro.
1178
1179         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
1180         support was added.
1181
1182         * MiniBrowser/gtk/BrowserTab.c:
1183         (browser_tab_set_background_color): Set the passed in color as web view background color.
1184         * MiniBrowser/gtk/BrowserTab.h:
1185         * MiniBrowser/gtk/BrowserWindow.c:
1186         (browser_window_init): Initialize backgroundColor.
1187         (browser_window_append_view): Call browser_tab_set_background_color().
1188         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
1189         are added.
1190         * MiniBrowser/gtk/main.c:
1191         (main): Call browser_window_set_background_color() before creating the tabs.
1192
1193 2019-04-23  John Wilander  <wilander@apple.com>
1194
1195         Move Ad Click Attribution from internal feature to experimental feature
1196         https://bugs.webkit.org/show_bug.cgi?id=197218
1197         <rdar://problem/47651691>
1198
1199         Reviewed by Brent Fulgham.
1200
1201         * DumpRenderTree/TestOptions.cpp:
1202         (TestOptions::TestOptions):
1203
1204 2019-04-23  Andy Estes  <aestes@apple.com>
1205
1206         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1207         https://bugs.webkit.org/show_bug.cgi?id=196749
1208         <rdar://problem/35773454>
1209
1210         Reviewed by Daniel Bates.
1211
1212         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1213
1214         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1215         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1216         (-[QuickLookDelegate webView:didFinishNavigation:]):
1217         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1218         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1219         (runTest):
1220         (runTestDecideBeforeLoading):
1221         (runTestDecideAfterLoading):
1222         (TEST):
1223
1224 2019-04-23  John Wilander  <wilander@apple.com>
1225
1226         Remove Ad Click Attribution data when removing website data
1227         https://bugs.webkit.org/show_bug.cgi?id=197215
1228         <rdar://problem/47668988>
1229
1230         Reviewed by Chris Dumez.
1231
1232         This patch adds test infrastructure to delete Ad Click Attribution data
1233         through WebsiteDataStore::removeData().
1234
1235         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1236         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1237         (WTR::TestRunner::clearAdClickAttribution):
1238         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1239         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1240         * WebKitTestRunner/TestController.cpp:
1241         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1242         * WebKitTestRunner/TestController.h:
1243         * WebKitTestRunner/TestInvocation.cpp:
1244         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1245
1246 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1247
1248         webkitpy: Kill unresponsive worker processes
1249         https://bugs.webkit.org/show_bug.cgi?id=197205
1250         <rdar://problem/50104388>
1251
1252         Reviewed by Lucas Forschler.
1253
1254         * Scripts/webkitpy/common/message_pool.py:
1255         (_MessagePool.__init__): Add close timeout.
1256         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1257
1258 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1259
1260         Add unit tests for WKWebView.serverTrust
1261         https://bugs.webkit.org/show_bug.cgi?id=197202
1262
1263         Reviewed by Youenn Fablet
1264
1265         * TestWebKitAPI/TCPServer.cpp:
1266         (TestWebKitAPI::deleter<BIO>::operator()):
1267         (TestWebKitAPI::deleter<SSL>::operator()):
1268         (TestWebKitAPI::deleter<X509>::operator()):
1269         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1270         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1271         (TestWebKitAPI::TCPServer::TCPServer):
1272         (TestWebKitAPI::TCPServer::listenForConnections):
1273         * TestWebKitAPI/TCPServer.h:
1274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1275         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1276         (TestWebKitAPI::TEST):
1277         (verifyCertificateAndPublicKey):
1278         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1279         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1280         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1281         (TestWebKitAPI::downloadAtRate):
1282         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1283         (TEST):
1284         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1285         (TEST):
1286
1287 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1288
1289         Unreviewed, rolling out r244556.
1290         https://bugs.webkit.org/show_bug.cgi?id=197212
1291
1292         Causing build failures on multiple builders (Requested by
1293         ShawnRoberts on #webkit).
1294
1295         Reverted changeset:
1296
1297         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1298         https://bugs.webkit.org/show_bug.cgi?id=197171
1299         https://trac.webkit.org/changeset/244556
1300
1301 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1302
1303         Fix iOS build.
1304         https://bugs.webkit.org/show_bug.cgi?id=195537
1305
1306         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1307         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1308         AdoptWK constructor is private now.  Use adoptWK instead.
1309
1310 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
1311
1312         Accessibility text search and selection API enhancements.
1313         https://bugs.webkit.org/show_bug.cgi?id=197095
1314         <rdar://problem/48181791>
1315
1316         Reviewed by Chris Fleizach.
1317
1318         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
1319
1320         * DumpRenderTree/AccessibilityTextMarker.h:
1321         * DumpRenderTree/AccessibilityUIElement.cpp:
1322         (searchTextWithCriteriaCallback):
1323         (AccessibilityUIElement::getJSClass):
1324         * DumpRenderTree/AccessibilityUIElement.h:
1325         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1326         (convertVectorToObjectArray):
1327         (convertNSArrayToVector):
1328         (searchTextParameterizedAttributeForCriteria):
1329         (AccessibilityUIElement::getLinkedUIElements):
1330         (AccessibilityUIElement::getDocumentLinks):
1331         (AccessibilityUIElement::getChildren):
1332         (AccessibilityUIElement::getChildrenWithRange):
1333         (AccessibilityUIElement::rowHeaders const):
1334         (AccessibilityUIElement::columnHeaders const):
1335         (AccessibilityUIElement::uiElementArrayAttributeValue const):
1336         (AccessibilityUIElement::searchTextWithCriteria):
1337         (AccessibilityUIElement::attributesOfColumnHeaders):
1338         (AccessibilityUIElement::attributesOfRowHeaders):
1339         (AccessibilityUIElement::attributesOfColumns):
1340         (AccessibilityUIElement::attributesOfRows):
1341         (AccessibilityUIElement::attributesOfVisibleCells):
1342         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1343         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1344         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1345         (WTR::convertVectorToObjectArray):
1346         (WTR::convertNSArrayToVector):
1347         (WTR::searchTextParameterizedAttributeForCriteria):
1348         (WTR::AccessibilityUIElement::getLinkedUIElements):
1349         (WTR::AccessibilityUIElement::getDocumentLinks):
1350         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1351         (WTR::AccessibilityUIElement::getChildren):
1352         (WTR::AccessibilityUIElement::getChildrenWithRange):
1353         (WTR::AccessibilityUIElement::rowHeaders const):
1354         (WTR::AccessibilityUIElement::columnHeaders const):
1355         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1356         (WTR::AccessibilityUIElement::searchTextWithCriteria):
1357         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1358         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1359         (WTR::AccessibilityUIElement::attributesOfColumns):
1360         (WTR::AccessibilityUIElement::attributesOfRows):
1361         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1362         (WTR::convertElementsToObjectArray): Deleted.
1363
1364 2019-04-23  Guy Lewin  <guy@lewin.co.il>
1365
1366         Multiple File Input Icon Set Regardless of File List
1367         https://bugs.webkit.org/show_bug.cgi?id=195537
1368
1369         Reviewed by Alexey Proskuryakov.
1370
1371         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
1372         display string in iOS file inputs
1373
1374         * DumpRenderTree/TestRunner.cpp:
1375         (SetOpenPanelFilesMediaIconCallback):
1376         (TestRunner::staticFunctions):
1377         (TestRunner::setOpenPanelFilesMediaIcon):
1378         * DumpRenderTree/TestRunner.h:
1379         (TestRunner::openPanelFilesMediaIcon const):
1380         * DumpRenderTree/mac/UIDelegate.mm:
1381         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1382         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1383         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1384         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1385         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1386         * WebKitTestRunner/TestController.cpp:
1387         (WTR::runOpenPanel):
1388         (WTR::TestController::resetStateToConsistentValues):
1389         * WebKitTestRunner/TestController.h:
1390         (WTR::TestController::openPanelFileURLsMediaIcon const):
1391         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
1392         * WebKitTestRunner/TestInvocation.cpp:
1393         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1394
1395 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
1396
1397         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1398         https://bugs.webkit.org/show_bug.cgi?id=197171
1399         <rdar://problem/47454979>
1400
1401         Reviewed by Youenn Fablet.
1402
1403         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1404         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1405         (TestWebKitAPI::TEST):
1406
1407 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1408
1409         [ews-build] Add unit tests for UnApplyPatchIfRequired
1410         https://bugs.webkit.org/show_bug.cgi?id=197197
1411
1412         Reviewed by Lucas Forschler.
1413
1414         * BuildSlaveSupport/ews-build/steps_unittest.py:
1415         (TestUnApplyPatchIfRequired):
1416         (TestUnApplyPatchIfRequired.test_success):
1417         (TestUnApplyPatchIfRequired.test_failure):
1418         (TestUnApplyPatchIfRequired.test_skip):
1419
1420 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1421
1422         [ews-build] Add unit tests for CleanWorkingDirectory
1423         https://bugs.webkit.org/show_bug.cgi?id=197195
1424
1425         Reviewed by Lucas Forschler.
1426
1427         * BuildSlaveSupport/ews-build/steps_unittest.py:
1428         (TestCleanWorkingDirectory):
1429         (TestCleanWorkingDirectory.test_success):
1430         (TestCleanWorkingDirectory.test_failure):
1431
1432 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1433
1434         [ews-build] Use explicit imports instead of wildcard imports
1435         https://bugs.webkit.org/show_bug.cgi?id=197194
1436
1437         Reviewed by Lucas Forschler.
1438
1439         * BuildSlaveSupport/ews-build/factories.py:
1440         * BuildSlaveSupport/ews-build/loadConfig.py:
1441         * BuildSlaveSupport/ews-build/steps_unittest.py:
1442
1443 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1444
1445         [ews-build] Add unit tests for DownloadBuiltProduct
1446         https://bugs.webkit.org/show_bug.cgi?id=197193
1447
1448         Reviewed by Lucas Forschler.
1449
1450         * BuildSlaveSupport/ews-build/steps_unittest.py:
1451         (TestDownloadBuiltProduct):
1452         (TestDownloadBuiltProduct.setUp):
1453         (TestDownloadBuiltProduct.tearDown):
1454         (TestDownloadBuiltProduct.test_success):
1455         (TestDownloadBuiltProduct.test_failure):
1456
1457 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1458
1459         [ews-app] Exception while loading status-bubble when no build step has started
1460         https://bugs.webkit.org/show_bug.cgi?id=196676
1461
1462         Reviewed by Lucas Forschler.
1463
1464         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1465         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1466
1467 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1468
1469         [PlayStation] Support running of JSC tests on remote playstation devices
1470         https://bugs.webkit.org/show_bug.cgi?id=197170
1471
1472         Reviewed by Ross Kirsling.
1473
1474         Script changes
1475
1476         * Scripts/run-javascriptcore-tests:
1477         (runJSCStressTests): Pass arguments for playstation to
1478         run-jsc-stress-tests
1479         * Scripts/run-jsc-stress-tests:
1480         Handle $hostOS=="playstation" for determineArchitecture, turning
1481         off $isFTLPlatform and runProfiler and defaulting test writer.
1482         * Scripts/webkitdirs.pm:
1483         (jscPath): PlayStation WebKit executables have .elf extension
1484         (executableProductDir): PlayStation builds on Windows hosts but
1485         uses bin directory rather than bin64/bin32 for executable output
1486         location.
1487         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1488
1489 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1490
1491         [CMake][Win] Use target oriented design for WebKit
1492         https://bugs.webkit.org/show_bug.cgi?id=197173
1493
1494         Reviewed by Alex Christensen.
1495
1496         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1497         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1498
1499 2019-04-23  Chris Dumez  <cdumez@apple.com>
1500
1501         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1502         https://bugs.webkit.org/show_bug.cgi?id=197097
1503         <rdar://problem/50048318>
1504
1505         Reviewed by Alex Christensen.
1506
1507         Add API test coverage.
1508
1509         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1510         (-[PSONScheme webView:startURLSchemeTask:]):
1511
1512 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1513
1514         [ATK] Implement AtkComponentIface scroll_to methods
1515         https://bugs.webkit.org/show_bug.cgi?id=196856
1516
1517         Reviewed by Michael Catanzaro.
1518
1519         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1520         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1521         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1522         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1523
1524 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1525
1526         [ews-build] Improve summary for UploadBuiltProduct step
1527         https://bugs.webkit.org/show_bug.cgi?id=197182
1528
1529         Reviewed by Lucas Forschler.
1530
1531         * BuildSlaveSupport/ews-build/steps.py:
1532         (UploadBuiltProduct): Added descriptionDone.
1533         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1534         * BuildSlaveSupport/ews-build/steps_unittest.py:
1535         (TestUploadBuiltProduct.test_success): Updated unit-test.
1536         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1537
1538 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1539
1540         [ews-build] Trigger queues only after uploading the archive
1541         https://bugs.webkit.org/show_bug.cgi?id=197180
1542
1543         Reviewed by Lucas Forschler.
1544
1545         * BuildSlaveSupport/ews-build/factories.py:
1546         (Factory.__init__):
1547         (BuildFactory.__init__): Remove trigger step from factories.
1548         (BuildFactory.propertiesToPassToTriggers): Deleted.
1549         * BuildSlaveSupport/ews-build/steps.py:
1550         (ConfigureBuild.__init__): Confiure triggers property.
1551         (Trigger): Step to trigger other queues.
1552         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1553         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1554
1555 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1556
1557         Deprecate WKContextCreateWithInjectedBundlePath
1558         https://bugs.webkit.org/show_bug.cgi?id=197169
1559
1560         Reviewed by Youenn Fablet.
1561
1562         * TestWebKitAPI/PlatformUtilities.cpp:
1563         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1564         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1565
1566 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1567
1568         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1569         https://bugs.webkit.org/show_bug.cgi?id=197093
1570         <rdar://problem/49708268>
1571
1572         Reviewed by Chris Dumez.
1573
1574         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1575         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1576         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1577         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1578         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1579
1580         * TestWebKitAPI/TCPServer.cpp:
1581         (TestWebKitAPI::TCPServer::TCPServer):
1582         (TestWebKitAPI::TCPServer::~TCPServer):
1583         (TestWebKitAPI::TCPServer::socketBindListen):
1584         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1585         * TestWebKitAPI/TCPServer.h:
1586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1587         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1588         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1589         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1590         (respondWithChallengeThenOK):
1591         (TestWebKitAPI::TEST):
1592         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1593         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1594         (TEST):
1595
1596 2019-04-22  Chris Dumez  <cdumez@apple.com>
1597
1598         Delayed WebProcessLaunch may break the _relatedWebView SPI
1599         https://bugs.webkit.org/show_bug.cgi?id=197160
1600
1601         Reviewed by Alex Christensen.
1602
1603         Add API test coverage.
1604
1605         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1606
1607 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1608
1609         Use curl to download packages for webkitpy autoinstaller
1610         https://bugs.webkit.org/show_bug.cgi?id=197164
1611
1612         Reviewed by Darin Adler.
1613
1614         * Scripts/webkitpy/common/system/autoinstall.py:
1615         (AutoInstaller._download): Use curl(1) to download packages necessary for
1616         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1617         errors which are not present when using curl(1).
1618
1619 2019-04-22  Chris Dumez  <cdumez@apple.com>
1620
1621         Unreviewed, rolling out r244502.
1622
1623         Caused crashes on the bots
1624
1625         Reverted changeset:
1626
1627         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1628         https://bugs.webkit.org/show_bug.cgi?id=197160
1629         https://trac.webkit.org/changeset/244502
1630
1631 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1632
1633         Unreviewed, rolling out r244437.
1634
1635         Still breaks internal tests.
1636
1637         Reverted changeset:
1638
1639         "InjectedBundle parameters often need initialization function
1640         called before unarchiving"
1641         https://bugs.webkit.org/show_bug.cgi?id=189709
1642         https://trac.webkit.org/changeset/244437
1643
1644 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1645
1646         [ews-build] Use singular verb in failure description in case of single api test failure
1647         https://bugs.webkit.org/show_bug.cgi?id=197013
1648
1649         Reviewed by Lucas Forschler.
1650
1651         * BuildSlaveSupport/ews-build/steps.py:
1652         (AnalyzeAPITestsResults.analyzeResults):
1653
1654 2019-04-22  Chris Dumez  <cdumez@apple.com>
1655
1656         Delayed WebProcessLaunch may break the _relatedWebView SPI
1657         https://bugs.webkit.org/show_bug.cgi?id=197160
1658
1659         Reviewed by Alex Christensen.
1660
1661         Add API test coverage.
1662
1663         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1664
1665 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1666
1667         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1668         https://bugs.webkit.org/show_bug.cgi?id=194630
1669
1670         Reviewed by Michael Catanzaro.
1671
1672         Return early from getAttributeSet() is passed in accessible is nullptr.
1673
1674         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1675
1676 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1677
1678         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1679         https://bugs.webkit.org/show_bug.cgi?id=197145
1680         <rdar://problem/50078170>
1681
1682         Reviewed by Darin Adler.
1683
1684         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1685         focus, or showing the font manager.
1686
1687         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1688         (TestWebKitAPI::TEST):
1689         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1690         (TEST):
1691         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1692         (TestWebKitAPI::TEST):
1693
1694 2019-04-21  Brian Burg  <bburg@apple.com>
1695
1696         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1697         https://bugs.webkit.org/show_bug.cgi?id=197125
1698         <rdar://problem/50061468>
1699
1700         Reviewed by Darin Adler.
1701
1702         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1703         using this class rather than making our own ./wpt serve invocation.
1704
1705         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1706         (WebDriverW3CWebServer):
1707         (WebDriverW3CWebServer.document_root): Expose this to clients.
1708         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1709
1710         (WebDriverW3CWebServer.__enter__):
1711         (WebDriverW3CWebServer.__exit__):
1712         Make it possible to use the web server with a 'with' statement.
1713
1714 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1715
1716         [CMake][Win] Use target oriented design for WebKitLegacy
1717         https://bugs.webkit.org/show_bug.cgi?id=197112
1718
1719         Reviewed by Konstantin Tokarev.
1720
1721         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1722
1723         * DumpRenderTree/CMakeLists.txt:
1724         * DumpRenderTree/PlatformWin.cmake:
1725         * DumpRenderTree/win/EventSender.cpp:
1726
1727 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1728
1729         Update text for old EWS submit button
1730         https://bugs.webkit.org/show_bug.cgi?id=197140
1731
1732         Reviewed by Alexey Proskuryakov.
1733
1734         * QueueStatusServer/templates/statusbubble.html:
1735
1736 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1737
1738         [ews-app] New EWS should poll bugzilla more frequently
1739         https://bugs.webkit.org/show_bug.cgi?id=197138
1740
1741         Reviewed by Alexey Proskuryakov.
1742
1743         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1744         (FetchLoop.__init__):
1745
1746 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1747
1748         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1749         https://bugs.webkit.org/show_bug.cgi?id=197139
1750
1751         Reviewed by Alexey Proskuryakov.
1752
1753         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1754         * QueueStatusServer/templates/statusbubble.html:
1755
1756 2019-04-20  Chris Dumez  <cdumez@apple.com>
1757
1758         Unreviewed, fix iOS build with recent SDKs.
1759
1760         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1761
1762 2019-04-19  Keith Miller  <keith_miller@apple.com>
1763
1764         Add script to merge run_benchmark jsons
1765         https://bugs.webkit.org/show_bug.cgi?id=197107
1766
1767         Reviewed by Michael Saboff.
1768
1769         The script basically recursively decends through all json objects until it gets
1770         to an array or JSON primitive and concats or takes the first value, respectively.
1771
1772         This patch also adds +x bits to the compare-results script so it
1773         can be run directly from the command line. I had to add a new line so that svn
1774         will accept the change... yay svn!
1775
1776         * Scripts/compare-results:
1777         * Scripts/merge-result-jsons: Added.
1778         (readJSONFile):
1779         (deepAppend):
1780         (mergeJSONs):
1781         (main):
1782
1783 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1784
1785         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1786         https://bugs.webkit.org/show_bug.cgi?id=197079
1787
1788         Reviewed by Darin Adler.
1789
1790         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1791
1792         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1793         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1794
1795 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1796
1797         Unreviewed, rolling out r244434.
1798         https://bugs.webkit.org/show_bug.cgi?id=197089
1799
1800         caused 1 API test failure (Requested by zalan on #webkit).
1801
1802         Reverted changeset:
1803
1804         "Regression (r244291): Broken API Test
1805         AutoLayoutRenderingProgressRelativeOrdering"
1806         https://bugs.webkit.org/show_bug.cgi?id=196948
1807         https://trac.webkit.org/changeset/244434
1808
1809 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1810
1811         Add new compatibility mode API on WKNavigation
1812         https://bugs.webkit.org/show_bug.cgi?id=197069
1813         <rdar://problem/50025800>
1814
1815         Reviewed by Tim Horton.
1816
1817         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1818
1819         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1820         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1821         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1822
1823 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1824
1825         [CMake] Make WebCore headers copies
1826         https://bugs.webkit.org/show_bug.cgi?id=182512
1827         <rdar://problem/37510435>
1828
1829         Reviewed by Alex Christensen.
1830
1831         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1832         ports.
1833
1834         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1835         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1836
1837         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1838         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1839         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1840         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1841         * TestWebKitAPI/CMakeLists.txt:
1842         * TestWebKitAPI/PlatformWin.cmake:
1843         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1844         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1845         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1846
1847 2019-04-18  Jer Noble  <jer.noble@apple.com>
1848
1849         Add support for parsing FairPlayStreaming PSSH boxes.
1850         https://bugs.webkit.org/show_bug.cgi?id=197064
1851
1852         Reviewed by Eric Carlson.
1853
1854         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1855         (TestWebKitAPI::TEST):
1856
1857 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1858
1859         InjectedBundle parameters often need initialization function called before unarchiving
1860         https://bugs.webkit.org/show_bug.cgi?id=189709
1861         <rdar://problem/44573653>
1862
1863         Reviewed by Ryosuke Niwa.
1864
1865         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1866         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1867
1868 2019-04-18  Zalan Bujtas  <zalan@apple.com>
1869
1870         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1871         https://bugs.webkit.org/show_bug.cgi?id=196948
1872         <rdar://problem/49927131>
1873
1874         Reviewed by Tim Horton.
1875
1876         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1877         (TEST): 
1878         The expected order of incoming events is
1879         1. didInvalidateIntrinsicContentSize
1880         2. didFirstLayout
1881         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1882         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1883         (and remember, all we care about is ordering).
1884
1885 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
1886
1887         Unreviewed, rolling out r244299.
1888
1889         Breaks internal tests.
1890
1891         Reverted changeset:
1892
1893         "InjectedBundle parameters often need initialization function
1894         called before unarchiving"
1895         https://bugs.webkit.org/show_bug.cgi?id=189709
1896         https://trac.webkit.org/changeset/244299
1897
1898 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
1899
1900         [WTF] StringBuilder should set correct m_is8Bit flag when merging
1901         https://bugs.webkit.org/show_bug.cgi?id=197053
1902
1903         Reviewed by Saam Barati.
1904
1905         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1906         (TestWebKitAPI::TEST):
1907
1908 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1909
1910         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
1911         https://bugs.webkit.org/show_bug.cgi?id=197028
1912         <rdar://problem/49985290>
1913
1914         Reviewed by Wenson Hsieh.
1915
1916         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1917         (TEST):
1918         Liberal application of waitForNextPresentationUpdate works around a race
1919         where if the page rapidly changes its viewport arguments (or an API client
1920         rapidly changes its viewport arguments), we'd get stuck thinking that the
1921         user had intentionally zoomed the page, and stop resetting the initial scale.
1922         This deserves a separate bug, but no need to keep the test failing while
1923         we think about it.
1924
1925 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1926
1927         REGRESSION (r241988): Switching tabs is slow
1928         https://bugs.webkit.org/show_bug.cgi?id=197037
1929         <rdar://problem/49951473>
1930
1931         Reviewed by Simon Fraser.
1932
1933         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1934         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
1935         (TEST):
1936         * TestWebKitAPI/cocoa/TestWKWebView.h:
1937         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1938         (-[TestWKWebView addToTestWindow]):
1939         Add a test that hangs without this fix.
1940
1941 2019-04-17  Truitt Savell  <tsavell@apple.com>
1942
1943         Unreviewed, rolling out r244400.
1944
1945         Caused testing to exit early with assertionon Debug WK2
1946
1947         Reverted changeset:
1948
1949         "UI↔Web deadlock when printing with a JavaScript alert
1950         visible"
1951         https://bugs.webkit.org/show_bug.cgi?id=196839
1952         https://trac.webkit.org/changeset/244400
1953
1954 2019-04-17  Brady Eidson  <beidson@apple.com>
1955
1956         Link clicks in PDFs shouldn't send referrer headers.
1957         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1958
1959         Reviewed by Tim Horton.
1960
1961         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1962         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1963         (putPDFBytesCallback):
1964         (emptyReleaseInfoCallback):
1965         (createPDFWithLinkToURL):
1966         (TEST):
1967
1968 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1969
1970         UI↔Web deadlock when printing with a JavaScript alert visible
1971         https://bugs.webkit.org/show_bug.cgi?id=196839
1972         <rdar://problem/49157642>
1973
1974         Reviewed by Andy Estes.
1975
1976         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1977         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1978         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1979         (TEST):
1980
1981 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1982
1983         WKRetainPtr's adoption constructor should be private
1984         https://bugs.webkit.org/show_bug.cgi?id=197019
1985
1986         Reviewed by Tim Horton.
1987
1988         * DumpRenderTree/mac/DumpRenderTree.mm:
1989         (dumpFramesAsText):
1990         * TestWebKitAPI/InjectedBundleController.cpp:
1991         (TestWebKitAPI::InjectedBundleController::initialize):
1992         * TestWebKitAPI/PlatformUtilities.cpp:
1993         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1994         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1995         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1996         (TestWebKitAPI::Util::toWK):
1997         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1998         (TestWebKitAPI::TEST):
1999         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2000         (TestWebKitAPI::TEST):
2001         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2002         (TestWebKitAPI::TEST):
2003         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2004         (TestWebKitAPI::TEST):
2005         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2006         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2007         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
2008         (TestWebKitAPI::TEST):
2009         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
2010         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2011         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2012         (TestWebKitAPI::TEST):
2013         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
2014         (TestWebKitAPI::TEST):
2015         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2016         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2017         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
2018         (TestWebKitAPI::TEST):
2019         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2020         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2021         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2022         (TestWebKitAPI::TEST):
2023         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2024         (TestWebKitAPI::TEST):
2025         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2026         (TestWebKitAPI::TEST):
2027         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2028         (TestWebKitAPI::TEST):
2029         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2030         (TestWebKitAPI::TEST):
2031         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2032         (TestWebKitAPI::TEST):
2033         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2034         (TestWebKitAPI::TEST):
2035         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
2036         (TestWebKitAPI::TEST):
2037         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2038         (TestWebKitAPI::TEST):
2039         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2040         (TestWebKitAPI::TEST):
2041         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2042         (TestWebKitAPI::TEST):
2043         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2044         (TestWebKitAPI::TEST):
2045         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2046         (TestWebKitAPI::TEST):
2047         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
2048         (TestWebKitAPI::TEST):
2049         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
2050         (TestWebKitAPI::TEST):
2051         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
2052         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2053         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
2054         (TestWebKitAPI::TEST):
2055         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
2056         (TestWebKitAPI::TEST):
2057         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
2058         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
2059         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
2060         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
2061         (TestWebKitAPI::TEST):
2062         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
2063         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
2064         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
2065         (TestWebKitAPI::TEST):
2066         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
2067         (TestWebKitAPI::TEST):
2068         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2069         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2070         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2071         (TestWebKitAPI::TEST):
2072         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2073         (TestWebKitAPI::loadAlternateHTMLString):
2074         (TestWebKitAPI::TEST):
2075         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
2076         (TestWebKitAPI::TEST):
2077         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2078         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2079         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2080         (TestWebKitAPI::buildAndPerformTest):
2081         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2082         (TestWebKitAPI::TEST):
2083         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
2084         (TestWebKitAPI::TEST):
2085         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
2086         (TestWebKitAPI::TEST):
2087         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2088         (TestWebKitAPI::TEST):
2089         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2090         (TestWebKitAPI::TEST):
2091         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2092         (TestWebKitAPI::TEST):
2093         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2094         (TestWebKitAPI::TEST):
2095         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2096         (TestWebKitAPI::TEST):
2097         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
2098         (TestWebKitAPI::TEST):
2099         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2100         (TestWebKitAPI::TEST):
2101         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2102         (TestWebKitAPI::TEST):
2103         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2104         (TestWebKitAPI::TEST):
2105         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2106         (TestWebKitAPI::TEST):
2107         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2108         (TestWebKitAPI::TEST):
2109         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2110         (TestWebKitAPI::TEST):
2111         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2112         (TestWebKitAPI::TEST):
2113         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2114         (TestWebKitAPI::TEST):
2115         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2116         (TestWebKitAPI::TEST):
2117         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2118         (TestWebKitAPI::TEST):
2119         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2120         (TestWebKitAPI::TEST):
2121         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
2122         (TestWebKitAPI::TEST):
2123         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
2124         (TestWebKitAPI::TEST):
2125         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2126         (TestWebKitAPI::TEST):
2127         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2128         (TestWebKitAPI::TEST):
2129         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2130         (TestWebKitAPI::TEST):
2131         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2132         (TestWebKitAPI::TEST):
2133         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2134         (TestWebKitAPI::TEST):
2135         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2136         (TestWebKitAPI::TEST):
2137         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2138         (TestWebKitAPI::TEST):
2139         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2140         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2141         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
2142         (TestWebKitAPI::TEST):
2143         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2144         (TestWebKitAPI::TEST):
2145         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
2146         (TestWebKitAPI::TEST):
2147         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
2148         (TestWebKitAPI::TEST):
2149         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2150         (TestWebKitAPI::TEST):
2151         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2152         (TestWebKitAPI::TEST):
2153         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
2154         (TestWebKitAPI::TEST):
2155         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2156         (TestWebKitAPI::TEST):
2157         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2158         (TestWebKitAPI::TEST):
2159         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2160         (TestWebKitAPI::TEST):
2161         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2162         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
2163         (TEST):
2164         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2165         (TEST):
2166         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2167         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2168         (TEST):
2169         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
2170         (TestWebKitAPI::TEST):
2171         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2172         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2173         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2174         (WTR::getMenuItemTitleCallback):
2175         (WTR::createMouseMessageBody):
2176         (WTR::EventSendingController::mouseDown):
2177         (WTR::EventSendingController::mouseUp):
2178         (WTR::EventSendingController::mouseMoveTo):
2179         (WTR::EventSendingController::mouseForceClick):
2180         (WTR::EventSendingController::startAndCancelMouseForceClick):
2181         (WTR::EventSendingController::mouseForceDown):
2182         (WTR::EventSendingController::mouseForceUp):
2183         (WTR::EventSendingController::mouseForceChanged):
2184         (WTR::EventSendingController::leapForward):
2185         (WTR::EventSendingController::scheduleAsynchronousClick):
2186         (WTR::createKeyDownMessageBody):
2187         (WTR::EventSendingController::keyDown):
2188         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2189         (WTR::EventSendingController::mouseScrollBy):
2190         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2191         (WTR::EventSendingController::continuousMouseScrollBy):
2192         (WTR::EventSendingController::addTouchPoint):
2193         (WTR::EventSendingController::updateTouchPoint):
2194         (WTR::EventSendingController::setTouchModifier):
2195         (WTR::EventSendingController::setTouchPointRadius):
2196         (WTR::EventSendingController::touchStart):
2197         (WTR::EventSendingController::touchMove):
2198         (WTR::EventSendingController::touchEnd):
2199         (WTR::EventSendingController::touchCancel):
2200         (WTR::EventSendingController::clearTouchPoints):
2201         (WTR::EventSendingController::releaseTouchPoint):
2202         (WTR::EventSendingController::cancelTouchPoint):
2203         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2204         (WTR::InjectedBundle::didCreatePage):
2205         (WTR::InjectedBundle::didReceiveMessage):
2206         (WTR::InjectedBundle::didReceiveMessageToPage):
2207         (WTR::InjectedBundle::booleanForKey):
2208         (WTR::InjectedBundle::done):
2209         (WTR::InjectedBundle::dumpToStdErr):
2210         (WTR::InjectedBundle::outputText):
2211         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2212         (WTR::InjectedBundle::postAddChromeInputField):
2213         (WTR::InjectedBundle::postRemoveChromeInputField):
2214         (WTR::InjectedBundle::postFocusWebView):
2215         (WTR::InjectedBundle::postSetBackingScaleFactor):
2216         (WTR::InjectedBundle::postSetWindowIsKey):
2217         (WTR::InjectedBundle::postSetViewSize):
2218         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2219         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2220         (WTR::InjectedBundle::setGeolocationPermission):
2221         (WTR::InjectedBundle::setMockGeolocationPosition):
2222         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2223         (WTR::InjectedBundle::isGeolocationProviderActive const):
2224         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2225         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2226         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2227         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2228         (WTR::InjectedBundle::setCustomPolicyDelegate):
2229         (WTR::InjectedBundle::setHidden):
2230         (WTR::InjectedBundle::setCacheModel):
2231         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2232         (WTR::InjectedBundle::processWorkQueue):
2233         (WTR::InjectedBundle::queueBackNavigation):
2234         (WTR::InjectedBundle::queueForwardNavigation):
2235         (WTR::InjectedBundle::queueLoad):
2236         (WTR::InjectedBundle::queueLoadHTMLString):
2237         (WTR::InjectedBundle::queueReload):
2238         (WTR::InjectedBundle::queueLoadingScript):
2239         (WTR::InjectedBundle::queueNonLoadingScript):
2240         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2241         (WTR::frameToStr):
2242         (WTR::InjectedBundlePage::InjectedBundlePage):
2243         (WTR::dumpFrameDescriptionSuitableForTestResult):
2244         (WTR::dumpFrameScrollPosition):
2245         (WTR::dumpDescendantFrameScrollPositions):
2246         (WTR::dumpFrameText):
2247         (WTR::dumpDescendantFramesText):
2248         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2249         (WTR::TestRunner::shouldDumpPixels const):
2250         (WTR::TestRunner::setDumpPixels):
2251         (WTR::TestRunner::whatToDump const):
2252         (WTR::TestRunner::setWhatToDump):
2253         (WTR::TestRunner::setWaitUntilDone):
2254         (WTR::TestRunner::shouldWaitUntilDone const):
2255         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2256         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2257         (WTR::TestRunner::clearAllDatabases):
2258         (WTR::TestRunner::setIDBPerOriginQuota):
2259         (WTR::TestRunner::originsWithApplicationCache):
2260         (WTR::TestRunner::setCanOpenWindows):
2261         (WTR::TestRunner::setXSSAuditorEnabled):
2262         (WTR::TestRunner::setMediaDevicesEnabled):
2263         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2264         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2265         (WTR::TestRunner::setCustomUserAgent):
2266         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2267         (WTR::TestRunner::setModernMediaControlsEnabled):
2268         (WTR::TestRunner::setWebGL2Enabled):
2269         (WTR::TestRunner::setWritableStreamAPIEnabled):
2270         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2271         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2272         (WTR::TestRunner::setAllowsAnySSLCertificate):
2273         (WTR::TestRunner::setPluginsEnabled):
2274         (WTR::TestRunner::setValueForUser):
2275         (WTR::TestRunner::setAudioResult):
2276         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2277         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2278         (WTR::TestRunner::setAlwaysAcceptCookies):
2279         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2280         (WTR::TestRunner::isDoingMediaCapture const):
2281         (WTR::TestRunner::queueLoad):
2282         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2283         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2284         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2285         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2286         (WTR::TestRunner::setAuthenticationUsername):
2287         (WTR::TestRunner::setAuthenticationPassword):
2288         (WTR::TestRunner::secureEventInputIsEnabled const):
2289         (WTR::TestRunner::setBlockAllPlugins):
2290         (WTR::TestRunner::setPluginSupportedMode):
2291         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2292         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2293         (WTR::TestRunner::setNavigationGesturesEnabled):
2294         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2295         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2296         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2297         (WTR::TestRunner::terminateNetworkProcess):
2298         (WTR::TestRunner::terminateServiceWorkerProcess):
2299         (WTR::TestRunner::runUIScript):
2300         (WTR::TestRunner::setStatisticsDebugMode):
2301         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2302         (WTR::TestRunner::setStatisticsLastSeen):
2303         (WTR::TestRunner::setStatisticsPrevalentResource):
2304         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2305         (WTR::TestRunner::dumpResourceLoadStatistics):
2306         (WTR::TestRunner::isStatisticsPrevalentResource):
2307         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
2308         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
2309         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
2310         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
2311         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2312         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2313         (WTR::TestRunner::setStatisticsGrandfathered):
2314         (WTR::TestRunner::isStatisticsGrandfathered):
2315         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2316         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2317         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2318         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
2319         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
2320         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
2321         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2322         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
2323         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2324         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2325         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2326         (WTR::TestRunner::statisticsSubmitTelemetry):
2327         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2328         (WTR::TestRunner::setStatisticsIsRunningTest):
2329         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2330         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2331         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2332         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2333         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2334         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2335         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2336         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2337         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2338         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2339         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
2340         (WTR::TestRunner::statisticsResetToConsistentState):
2341         (WTR::TestRunner::setStorageAccessAPIEnabled):
2342         (WTR::TestRunner::getAllStorageAccessEntries):
2343         (WTR::TestRunner::addMockMediaDevice):
2344         (WTR::TestRunner::clearMockMediaDevices):
2345         (WTR::TestRunner::removeMockMediaDevice):
2346         (WTR::TestRunner::resetMockMediaDevices):
2347         (WTR::TestRunner::connectMockGamepad):
2348         (WTR::TestRunner::disconnectMockGamepad):
2349         (WTR::TestRunner::setMockGamepadDetails):
2350         (WTR::TestRunner::setMockGamepadAxisValue):
2351         (WTR::TestRunner::setMockGamepadButtonValue):
2352         (WTR::TestRunner::removeAllSessionCredentials):
2353         (WTR::TestRunner::clearDOMCache):
2354         (WTR::TestRunner::clearDOMCaches):
2355         (WTR::TestRunner::hasDOMCache):
2356         (WTR::TestRunner::domCacheSize):
2357         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2358         (WTR::TestRunner::getApplicationManifestThen):
2359         (WTR::TestRunner::injectUserScript):
2360         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
2361         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2362         (WTR::TestRunner::addTestKeyToKeychain):
2363         (WTR::TestRunner::cleanUpKeychain):
2364         (WTR::TestRunner::keyExistsInKeychain):
2365         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2366         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2367         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2368         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2369         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2370         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2371         * WebKitTestRunner/TestController.cpp:
2372         (WTR::TestController::initialize):
2373         (WTR::parseStringTestHeaderValueAsRelativePath):
2374         (WTR::updateTestOptionsFromTestHeader):
2375         (WTR::TestController::runTest):
2376         (WTR::TestController::didReceiveLiveDocumentsList):
2377         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2378         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2379         (WTR::TestController::didFinishNavigation):
2380         (WTR::TestController::didReceiveAuthenticationChallenge):
2381         * WebKitTestRunner/TestInvocation.cpp:
2382         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2383         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2384         (WTR::TestInvocation::uiScriptDidComplete):
2385         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
2386         * WebKitTestRunner/WebNotificationProvider.cpp:
2387         (WTR::WebNotificationProvider::closeWebNotification):
2388         * WebKitTestRunner/WorkQueueManager.cpp:
2389         (WTR::ScriptItem::ScriptItem):
2390         (WTR::WorkQueueManager::queueLoad):
2391         (WTR::WorkQueueManager::queueLoadHTMLString):
2392
2393 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2394
2395         Add a comment to make my test from r244139 less mysterious.
2396         https://bugs.webkit.org/show_bug.cgi?id=196744
2397
2398         As suggested by Darin Adler.
2399
2400         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2401         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2402
2403 2019-04-17  Chris Dumez  <cdumez@apple.com>
2404
2405         Remember device orientation permission for the duration of the browsing session
2406         https://bugs.webkit.org/show_bug.cgi?id=196992
2407         <rdar://problem/49946067>
2408
2409         Reviewed by Alex Christensen.
2410
2411         Add API test coverage.
2412
2413         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2414         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2415         (TEST):
2416
2417 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
2418
2419         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
2420         https://bugs.webkit.org/show_bug.cgi?id=196675
2421
2422         Reviewed by Lucas Forschler.
2423
2424         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2425         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
2426
2427 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2428
2429         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
2430         https://bugs.webkit.org/show_bug.cgi?id=196919
2431         <rdar://problem/41630459>
2432
2433         Reviewed by Tim Horton.
2434
2435         Add iOS support for several new testing hooks. See below for more detail.
2436
2437         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2438         (WTR::UIScriptController::isDismissingMenu const):
2439
2440         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
2441         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
2442         by UIKit when dismissing the callout bar (i.e. UIMenuController).
2443
2444         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2445         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2446         (WTR::UIScriptController::isDismissingMenu const):
2447         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2448         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2449         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2450         (WTR::InjectedBundle::didReceiveMessageToPage):
2451         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2452         (WTR::TestRunner::setAllowedMenuActions):
2453
2454         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2455         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2456         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2457         against the name of the custom action.
2458
2459         (WTR::TestRunner::installCustomMenuAction):
2460
2461         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2462         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2463         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2464         triggered.
2465
2466         (WTR::TestRunner::performCustomMenuAction):
2467
2468         Invoked when the custom menu action is triggered.
2469
2470         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2471         * WebKitTestRunner/TestController.cpp:
2472         (WTR::TestController::installCustomMenuAction):
2473         (WTR::TestController::setAllowedMenuActions):
2474         * WebKitTestRunner/TestController.h:
2475         * WebKitTestRunner/TestInvocation.cpp:
2476         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2477         (WTR::TestInvocation::performCustomMenuAction):
2478
2479         Add plumbing to call back into the injected bundle when performing the custom action.
2480
2481         * WebKitTestRunner/TestInvocation.h:
2482         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2483         (WTR::TestController::installCustomMenuAction):
2484         (WTR::TestController::setAllowedMenuActions):
2485         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2486         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2487         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2488         (-[TestRunnerWKWebView becomeFirstResponder]):
2489         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2490
2491         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2492         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2493         in the Mail app on iOS.
2494
2495         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2496         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2497         (-[TestRunnerWKWebView resetCustomMenuAction]):
2498         (-[TestRunnerWKWebView performCustomAction:]):
2499         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2500         (-[TestRunnerWKWebView _willHideMenu]):
2501         (-[TestRunnerWKWebView _didHideMenu]):
2502         * WebKitTestRunner/ios/TestControllerIOS.mm:
2503         (WTR::TestController::platformResetStateToConsistentValues):
2504
2505         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2506         if specified.
2507
2508         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2509         (WTR::UIScriptController::isDismissingMenu const):
2510
2511 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2512
2513         Allow sharing from imageSheet on an image document
2514         https://bugs.webkit.org/show_bug.cgi?id=196891
2515         <rdar://problem/25377386>
2516
2517         Reviewed by Tim Horton.
2518
2519         Test to make sure that the correct imageURL is extracted from an image element.
2520
2521         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2522         (TestWebKitAPI::TEST):
2523
2524 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2525
2526         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2527         https://bugs.webkit.org/show_bug.cgi?id=196995
2528
2529         Reviewed by Brady Eidson.
2530
2531         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2532         (TEST):
2533
2534 2019-04-16  Chris Dumez  <cdumez@apple.com>
2535
2536         URL set by document.open() is not communicated to the UIProcess
2537         https://bugs.webkit.org/show_bug.cgi?id=196941
2538         <rdar://problem/49237544>
2539
2540         Reviewed by Geoff Garen.
2541
2542         Add API test coverage.
2543
2544         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2545         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2546         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2547         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2548         (TEST):
2549
2550 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2551
2552         Unreviewed, rolling out r244321.
2553         https://bugs.webkit.org/show_bug.cgi?id=196968
2554
2555         Causing all WK2 Debug builds to exit early after Assertion
2556         failures. (Requested by ShawnRoberts on #webkit).
2557
2558         Reverted changeset:
2559
2560         "URL set by document.open() is not communicated to the
2561         UIProcess"
2562         https://bugs.webkit.org/show_bug.cgi?id=196941
2563         https://trac.webkit.org/changeset/244321
2564
2565 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2566
2567         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2568         https://bugs.webkit.org/show_bug.cgi?id=196948
2569
2570         Reviewed by Zalan Bujtas.
2571
2572         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2573         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2574
2575 2019-04-15  Chris Dumez  <cdumez@apple.com>
2576
2577         URL set by document.open() is not communicated to the UIProcess
2578         https://bugs.webkit.org/show_bug.cgi?id=196941
2579         <rdar://problem/49237544>
2580
2581         Reviewed by Geoffrey Garen.
2582
2583         Add API test coverage.
2584
2585         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2586         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2587         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2588         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2589         (TEST):
2590
2591 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2592
2593         Using Tools/Scripts/clean-webkit should not install requests
2594         https://bugs.webkit.org/show_bug.cgi?id=196940
2595
2596         Reviewed by Lucas Forschler.
2597
2598         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2599         existing, depending on the path autoinstalled is run through.
2600         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2601         needed.
2602         (Port.configuration_for_upload):
2603         (Port.commits_for_upload):
2604
2605 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2606
2607         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2608         https://bugs.webkit.org/show_bug.cgi?id=196773
2609
2610         Reviewed by Jer Noble.
2611
2612         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2613         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2614         (TEST):
2615
2616 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2617
2618         ews-build should clearly indicate flaky test failures
2619         https://bugs.webkit.org/show_bug.cgi?id=196947
2620
2621         Reviewed by Lucas Forschler.
2622
2623         * BuildSlaveSupport/ews-build/steps.py:
2624         (AnalyzeAPITestsResults.analyzeResults):
2625
2626 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2627
2628         InjectedBundle parameters often need initialization function called before unarchiving
2629         https://bugs.webkit.org/show_bug.cgi?id=189709
2630         <rdar://problem/44573653>
2631
2632         Reviewed by Ryosuke Niwa.
2633
2634         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2635         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2636
2637 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2638
2639         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2640         https://bugs.webkit.org/show_bug.cgi?id=196681
2641
2642         Reviewed by Darin Adler.
2643
2644         Added tests.
2645
2646         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2647         (WTF_HashSet.RemoveIf):
2648         (WTF_HashSet.RemoveIfShrinkToBestSize):
2649
2650 2019-04-15  John Wilander  <wilander@apple.com>
2651
2652         Send delayed Ad Click Attribution conversion requests to the click source
2653         https://bugs.webkit.org/show_bug.cgi?id=196838
2654         <rdar://problem/47650157>
2655
2656         Reviewed by Chris Dumez and Youenn Fablet.
2657
2658         This patch adds test infrastructure to override the default behavior in
2659         WebKit::NetworkAdClickAttribution.
2660
2661         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2662         (TestWebKitAPI::TEST):
2663         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2664         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2665         (WTR::TestRunner::dumpAdClickAttribution):
2666         (WTR::TestRunner::clearAdClickAttribution):
2667         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2668         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2669         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2670         * WebKitTestRunner/TestController.cpp:
2671         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2672         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2673         * WebKitTestRunner/TestController.h:
2674         * WebKitTestRunner/TestInvocation.cpp:
2675         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2676
2677 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2678
2679         [ews-app] status-bubble should display position in queue
2680         https://bugs.webkit.org/show_bug.cgi?id=196607
2681
2682         Reviewed by Lucas Forschler.
2683
2684         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2685         (StatusBubble._build_bubble):
2686         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2687
2688 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2689
2690         [ews-build] Do not run clean build by default on EWS builders
2691         https://bugs.webkit.org/show_bug.cgi?id=196897
2692
2693         Reviewed by Lucas Forschler.
2694
2695         * BuildSlaveSupport/ews-build/steps.py:
2696         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2697         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2698         untracked directories like WebKitBuild).
2699         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2700         untracked files/directories (like WebKitBuild).
2701
2702 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2703
2704         TestRunner::notifyDone() should be safely reentrant
2705         https://bugs.webkit.org/show_bug.cgi?id=196898
2706
2707         Reviewed by Darin Adler.
2708
2709         It is currently possible that TestRunner::notifyDone() will call itself, since
2710         notifyDone() will force a repaint, which can start executing JavaScript, which
2711         may call notifyDone() again. This can lead to test failures and flakiness.
2712         Fix this by setting the m_waitToDump flag before calling the dump() method.
2713
2714         * DumpRenderTree/mac/TestRunnerMac.mm:
2715         (TestRunner::notifyDone):
2716         (TestRunner::forceImmediateCompletion):
2717         * DumpRenderTree/win/TestRunnerWin.cpp:
2718         (TestRunner::notifyDone):
2719         (TestRunner::forceImmediateCompletion):
2720
2721 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2722
2723         [GTK][WPE] Add enable-media websetting
2724         https://bugs.webkit.org/show_bug.cgi?id=196863
2725
2726         Reviewed by Michael Catanzaro.
2727
2728         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2729         (testWebKitSettings): Add test for the enable-media web-setting.
2730
2731 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2732
2733         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2734         https://bugs.webkit.org/show_bug.cgi?id=196905
2735         <rdar://problem/49886096>
2736
2737         Reviewed by Tim Horton.
2738
2739         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2740         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2741         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2742         delay timer, we end up with this sequence of events in the problematic (failure) case:
2743
2744         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2745             ...IPC from UI to web process...
2746         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2747             ...IPC from web to UI process...
2748         (c) [UI]    Invoke completion handler for script #1
2749         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2750             ...IPC from UI to web process...
2751         (e) [Web]   Evaluate script #2 in the web process
2752         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2753
2754         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2755         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2756         #2 is run in step (e).
2757
2758         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2759         the UI process by waiting on a script message posted by the web process, after attachment updates are
2760         dispatched.
2761
2762         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2763         (TestWebKitAPI::TEST):
2764
2765 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2766
2767         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2768         https://bugs.webkit.org/show_bug.cgi?id=196909
2769
2770         Reviewed by Wenson Hsieh.
2771
2772         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2773         (TestWebKitAPI::TEST):
2774
2775 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2776
2777         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2778         https://bugs.webkit.org/show_bug.cgi?id=196880
2779
2780         Reviewed by Yusuke Suzuki.
2781
2782         Add a new function for bytecode cache tests that does not forceDiskCache
2783         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2784         test added in this patch, since the code is invalid and therefore won't be
2785         cached. It should also be useful for tests that evaluate dynamically
2786         generated code.
2787
2788         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2789         * Scripts/run-jsc-stress-tests:
2790
2791 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2792
2793         Update AudioSession route sharing policy
2794         https://bugs.webkit.org/show_bug.cgi?id=196776
2795         <rdar://problem/46501611>
2796
2797         Reviewed by Jer Noble.
2798
2799         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2800         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2801         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2802         (TestWebKitAPI::TEST):
2803
2804 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2805
2806         [iOS] Software keyboard is shown too frequently on some websites
2807         https://bugs.webkit.org/show_bug.cgi?id=195856
2808         <rdar://problem/49191395>
2809
2810         Reviewed by Darin Adler.
2811
2812         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2813
2814         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2815         (WTR::UIScriptController::setHardwareKeyboardAttached):
2816         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2817         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2818         (WTR::UIScriptController::setHardwareKeyboardAttached):
2819         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2820         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2821
2822         Additionally link against GraphicsServices in WebKitTestRunner.
2823
2824         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2825         (WTR::TestController::platformResetStateToConsistentValues):
2826         (WTR::UIScriptController::setHardwareKeyboardAttached):
2827
2828 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2829
2830         [GTK][WPE] Fix pacman install-dependencies packages
2831         https://bugs.webkit.org/show_bug.cgi?id=196817
2832
2833         Reviewed by Žan Doberšek.
2834         
2835         python3-setuptools is called python-setuptools
2836         ruby-highline is only available on AUR
2837         libv4l-devel is incorporated in v4l-utils
2838
2839         * gtk/install-dependencies:
2840         * wpe/install-dependencies:
2841
2842 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2843
2844         [GTK] REGRESSION(r243860): Many tests failing
2845         https://bugs.webkit.org/show_bug.cgi?id=196791
2846
2847         Reviewed by Joanmarie Diggs.
2848
2849         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2850         multiple documents and check that accessibility hierarchy is updated after a navigation.
2851
2852         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2853         (loadChangedCallback):
2854         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2855         (AccessibilityTest::AccessibilityTest):
2856         (AccessibilityTest::~AccessibilityTest):
2857         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2858         (AccessibilityTest::findTestServerApplication):
2859         (AccessibilityTest::findDocumentWeb):
2860         (AccessibilityTest::findRootObject):
2861         (AccessibilityTest::waitUntilChildrenRemoved):
2862         (AccessibilityTest::ensureProxy):
2863         (testAtspiBasicHierarchy):
2864         (beforeAll):
2865         (afterAll):
2866
2867 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2868
2869         [ews-build] Handle bug titles with unicode characters
2870         https://bugs.webkit.org/show_bug.cgi?id=196802
2871
2872         Reviewed by Dewei Zhu.
2873
2874         * BuildSlaveSupport/ews-build/steps.py:
2875         (ValidatePatch._is_bug_closed):
2876
2877 2019-04-11  Michael Saboff  <msaboff@apple.com>
2878
2879         Improve the Inline Cache Stats code
2880         https://bugs.webkit.org/show_bug.cgi?id=196836
2881
2882         Reviewed by Saam Barati.
2883
2884         Added a new script to consolidate and arrange the output of --useICStats option.
2885
2886         This script merges the output from every group into one large table and sorts it from most common to
2887         least common.  It also counts the slow path GetById and PutById variants and then calculates the
2888         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
2889         Put together, this is useful to see what property accesses are not getting cached.
2890
2891         * Scripts/ic-stats.py: Added.
2892         (ICStats):
2893         (ICStats.__init__):
2894         (ICStats.parse):
2895         (ICStats.dumpStats):
2896         (usage):
2897
2898 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2899
2900         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
2901         https://bugs.webkit.org/show_bug.cgi?id=196809
2902         <rdar://49800762>
2903
2904         Reviewed by Brady Eidson.
2905
2906         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2907         (TEST):
2908
2909 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2910
2911         requestAnimationFrame should execute before the next frame
2912         https://bugs.webkit.org/show_bug.cgi?id=177484
2913
2914         Reviewed by Simon Fraser.
2915
2916         Add trace points for the page RenderingUpdate.
2917
2918         * Tracing/SystemTracePoints.plist:
2919
2920 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2921
2922         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
2923         https://bugs.webkit.org/show_bug.cgi?id=196760
2924
2925         Reviewed by Don Olmstead.
2926
2927         vswhere.exe has been bundled since Visual Studio 2017 version
2928         15.2. We shouldn't download vswhere.exe.
2929
2930         * Scripts/build-jsc: Do not call update-vswhere.py.
2931         * Scripts/build-webkit: Ditto.
2932         * Scripts/update-vswhere.py: Removed.
2933         * Scripts/webkitdirs.pm:
2934         (requireModulesForVSWhere): Deleted.
2935         (pickCurrentVisualStudioInstallation): Deleted.
2936         (visualStudioInstallDirVSWhere): Return the latest installed VS
2937         installation path by using the bundled vswhere.exe.
2938         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
2939         (visualStudioInstallDirFallback): Removed.
2940
2941 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2942
2943         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2944         https://bugs.webkit.org/show_bug.cgi?id=196780
2945
2946         Reviewed by Alexey Proskuryakov.
2947
2948         * BuildSlaveSupport/ews-build/steps.py:
2949         * BuildSlaveSupport/ews-build/steps_unittest.py:
2950
2951 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2952
2953         Add SPI WKNavigationResponse._downloadAttribute
2954         https://bugs.webkit.org/show_bug.cgi?id=196755
2955         <rdar://49587365>
2956
2957         Reviewed by Brady Eidson.
2958
2959         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2960         (-[NavigationResponseTestDelegate navigationResponse]):
2961         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2962         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2963         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2964         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2965         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2966         (readRequest):
2967         (writeResponse):
2968         (TEST):
2969
2970 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2971
2972         Add modern API for overriding the page's specified viewport configuration
2973         https://bugs.webkit.org/show_bug.cgi?id=167734
2974         <rdar://problem/30331795>
2975
2976         Reviewed by Simon Fraser.
2977
2978         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2979         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2980
2981 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2982
2983         Add support for incremental bytecode cache updates
2984         https://bugs.webkit.org/show_bug.cgi?id=195000
2985
2986         Reviewed by Filip Pizlo.
2987
2988         Exit when the initial run to generate bytecode fails.
2989
2990         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2991
2992 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2993
2994         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2995         https://bugs.webkit.org/show_bug.cgi?id=196744
2996         <rdar://49415309>
2997
2998         Reviewed by Chris Dumez.
2999
3000         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3001         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3002
3003 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3004
3005         Add a way to opt into modern compatibility mode in layout tests
3006         https://bugs.webkit.org/show_bug.cgi?id=196770
3007         <rdar://problem/49777550>
3008
3009         Reviewed by Antoine Quint.
3010
3011         Add a new test option to enable modern compatibility mode in layout tests.
3012
3013         * WebKitTestRunner/TestController.cpp:
3014         (WTR::updateTestOptionsFromTestHeader):
3015         * WebKitTestRunner/TestController.h:
3016         * WebKitTestRunner/TestOptions.h:
3017         (WTR::TestOptions::hasSameInitializationOptions const):
3018         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3019         (WTR::TestController::platformCreateWebView):
3020         (WTR::TestController::enableModernCompatibilityMode):
3021
3022 2019-04-10  Andy Estes  <aestes@apple.com>
3023
3024         Try to fix the 32-bit watchOS build.
3025
3026         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3027         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3028
3029 2019-04-10  Antoine Quint  <graouts@apple.com>
3030
3031         Enable Pointer Events on watchOS
3032         https://bugs.webkit.org/show_bug.cgi?id=196771
3033         <rdar://problem/49040909>
3034
3035         Reviewed by Dean Jackson.
3036
3037         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3038
3039 2019-04-10  Philippe Normand  <pnormand@igalia.com>
3040
3041         Unreviewed. Fix WPE accessibility tests after r244059.
3042
3043         We are failing to load the injected bundle due to undefined symbol
3044         AccessibilityUIElement::replaceTextInRange().
3045
3046         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
3047         (WTR::AccessibilityUIElement::replaceTextInRange):
3048
3049 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
3050
3051         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
3052         https://bugs.webkit.org/show_bug.cgi?id=196727
3053
3054         Reviewed by Fujii Hironori.
3055
3056         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3057         (WebKitBrowserWindow::create):
3058
3059 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
3060
3061         [ews-build] Add unit tests for PrintConfiguration
3062         https://bugs.webkit.org/show_bug.cgi?id=196752
3063
3064         Reviewed by Dewei Zhu.
3065
3066         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3067
3068 2019-04-09  Keith Rollin  <krollin@apple.com>
3069
3070         Unreviewed build maintenance -- update .xcfilelists.
3071
3072         * DumpRenderTree/DerivedSources-input.xcfilelist:
3073         * DumpRenderTree/DerivedSources-output.xcfilelist:
3074
3075 2019-04-09  Zalan Bujtas  <zalan@apple.com>
3076
3077         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
3078         https://bugs.webkit.org/show_bug.cgi?id=196743
3079         <rdar://problem/43897551>
3080
3081         Reviewed by Tim Horton.
3082
3083         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
3084         (TEST):
3085
3086 2019-04-09  Youenn Fablet  <youenn@apple.com>
3087
3088         Close service worker database on network process suspension
3089         https://bugs.webkit.org/show_bug.cgi?id=196623
3090         <rdar://problem/48930869>
3091
3092         Reviewed by Alex Christensen.
3093
3094         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3095
3096 2019-04-09  Daniel Bates  <dabates@apple.com>
3097
3098         [iPad] Should open popover when the spacebar is pressed
3099         https://bugs.webkit.org/show_bug.cgi?id=196360
3100         <rdar://problem/49389129>
3101
3102         Reviewed by Brent Fulgham.
3103
3104         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
3105
3106         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3107         (WTR::UIScriptController::isShowingPopover const): Added.
3108         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3109         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3110         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3111         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3112         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3113         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
3114         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
3115         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
3116         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
3117         (WTR::UIScriptController::isShowingPopover const): Added.
3118         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3119         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3120         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3121         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3122         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3123         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
3124         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
3125         (-[TestRunnerWKWebView _willPresentPopover]): Added.
3126         (-[TestRunnerWKWebView _didDismissPopover]): Added.
3127         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3128         (WTR::UIScriptController::isShowingPopover const): Added.
3129         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3130         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3131
3132 2019-04-09  Alex Christensen  <achristensen@webkit.org>
3133
3134         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3135         https://bugs.webkit.org/show_bug.cgi?id=196665
3136         <rdar://45115669>
3137
3138         Reviewed by Geoff Garen.
3139
3140         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3141         (goBack):
3142         (+[SimpleLookupContext sharedLookupContext]):
3143         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3144         (TEST):
3145         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3146         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3147
3148 2019-04-09  John Wilander  <wilander@apple.com>
3149
3150         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
3151         https://bugs.webkit.org/show_bug.cgi?id=196558
3152         <rdar://problem/47650245>
3153
3154         Reviewed by Youenn Fablet.
3155
3156         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3157         (TestWebKitAPI::TEST):
3158             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
3159
3160 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
3161
3162         [CMake] Apple builds should use ICU_INCLUDE_DIRS
3163         https://bugs.webkit.org/show_bug.cgi?id=196720
3164
3165         Reviewed by Konstantin Tokarev.
3166
3167         * TestWebKitAPI/PlatformMac.cmake:
3168
3169 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
3170
3171         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
3172         https://bugs.webkit.org/show_bug.cgi?id=196694
3173         <rdar://problem/48388734>
3174
3175         Rubber-stamped by Aakash Jain.
3176
3177         * Scripts/webkitpy/port/image_diff.py:
3178         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
3179         * Scripts/webkitpy/port/server_process.py:
3180         (ServerProcess.has_available_stdout): Check if stdout has data in it.
3181         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3182         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
3183         * Scripts/webkitpy/port/server_process_mock.py:
3184         (MockServerProcess.has_available_stdout):
3185         * Scripts/webkitpy/port/server_process_unittest.py:
3186         (TestServerProcess.serial_test_basic):
3187
3188 2019-04-09  Jer Noble  <jer.noble@apple.com>
3189
3190         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3191         https://bugs.webkit.org/show_bug.cgi?id=196097
3192
3193         Reviewed by Eric Carlson.
3194
3195         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3196
3197         * DumpRenderTree/mac/DumpRenderTree.mm:
3198         (resetWebPreferencesToConsistentValues):
3199         * WebKitTestRunner/TestController.cpp:
3200         (WTR::TestController::resetPreferencesToConsistentValues):
3201
3202 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
3203
3204         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
3205         https://bugs.webkit.org/show_bug.cgi?id=196690
3206
3207         Reviewed by Michael Catanzaro.
3208
3209         * QueueStatusServer/config/queues.py:
3210         * Scripts/webkitpy/common/config/ews.json:
3211         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3212         (test_ews_name):
3213
3214 2019-04-09  Chris Dumez  <cdumez@apple.com>
3215
3216         Loads using loadHTMLString() cause flashing when process-swapping
3217         https://bugs.webkit.org/show_bug.cgi?id=196714
3218         <rdar://problem/49637354>
3219
3220         Reviewed by Antti Koivisto.
3221
3222         Add API test coverage.
3223
3224         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3225
3226 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3227
3228         Unreviewed. Fix ATK accessibility tests after r244059.
3229
3230         We are failing to load the injected bundle due to undefined symbol
3231         AccessibilityUIElement::replaceTextInRange().
3232
3233         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3234         (WTR::AccessibilityUIElement::replaceTextInRange):
3235
3236 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3237
3238         AX: Support API: accessibilityReplaceRange:withText
3239         https://bugs.webkit.org/show_bug.cgi?id=196636
3240
3241         Unreviewed build fix for Windows port.
3242
3243         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3244         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
3245
3246 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
3247
3248         [CMake][WinCairo] Separate copied headers into different directories
3249         https://bugs.webkit.org/show_bug.cgi?id=196655
3250
3251         Reviewed by Michael Catanzaro.
3252
3253         * DumpRenderTree/CMakeLists.txt:
3254         * MiniBrowser/win/CMakeLists.txt:
3255         * TestWebKitAPI/CMakeLists.txt:
3256         * TestWebKitAPI/PlatformWin.cmake:
3257
3258 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
3259
3260         Log stack-trace for run-webkit-tests when interrupted
3261         https://bugs.webkit.org/show_bug.cgi?id=176393
3262         <rdar://problem/34262310>
3263
3264         Reviewed by Lucas Forschler.
3265
3266         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
3267         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
3268         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
3269         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
3270         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
3271         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3272         (main): Set handlers to log stack trace on interruption.
3273
3274 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3275
3276         AX: Support API: accessibilityReplaceRange:withText
3277         https://bugs.webkit.org/show_bug.cgi?id=196636
3278
3279         Unreviewed build fix for Windows port.
3280
3281         * DumpRenderTree/AccessibilityUIElement.cpp:
3282         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
3283
3284 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3285
3286         [ews-build] Scripts using Buildbot API have CORS error
3287         https://bugs.webkit.org/show_bug.cgi?id=196709
3288
3289         Reviewed by Alexey Proskuryakov.
3290
3291         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
3292
3293 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
3294
3295         AX: Support API: accessibilityReplaceRange:withText
3296         https://bugs.webkit.org/show_bug.cgi?id=196636
3297
3298         Reviewed by Daniel Bates.
3299
3300         * DumpRenderTree/AccessibilityUIElement.cpp:
3301         (replaceTextInRangeCallback):
3302         (AccessibilityUIElement::replaceTextInRange):
3303         (AccessibilityUIElement::getJSClass):
3304         * DumpRenderTree/AccessibilityUIElement.h:
3305         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3306         (AccessibilityUIElement::replaceTextInRange):
3307         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3308         (AccessibilityUIElement::replaceTextInRange):
3309         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3310         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3311         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3312         (WTR::AccessibilityUIElement::replaceTextInRange):
3313         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3314         (WTR::AccessibilityUIElement::replaceTextInRange):
3315
3316 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3317
3318         [iOS] Do not allow starting selection drags when selection views are not visible
3319         https://bugs.webkit.org/show_bug.cgi?id=196686
3320         <rdar://problem/49399192>
3321
3322         Reviewed by Tim Horton.
3323
3324         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
3325         also add some new API tests to cover scenarios where the web view is not first responder.
3326
3327         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3328         (TestWebKitAPI::TEST):
3329         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3330
3331         Add a switch to optionally make the web view first responder when starting the simulated drag.
3332
3333         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3334         (-[DragAndDropSimulator initWithWebView:]):
3335         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
3336
3337 2019-04-08  Justin Fan  <justin_fan@apple.com>
3338
3339         [Web GPU] Fix Web GPU experimental feature on iOS
3340         https://bugs.webkit.org/show_bug.cgi?id=196632
3341
3342         Reviewed by Myles C. Maxfield.
3343
3344         Properly make Web GPU available on iOS 11+.
3345
3346         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3347
3348 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3349
3350         [ews-build] Do not upload archive when Compile Fails
3351         https://bugs.webkit.org/show_bug.cgi?id=196674
3352
3353         Reviewed by Alexey Proskuryakov.
3354
3355         * BuildSlaveSupport/ews-build/factories.py:
3356         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
3357         * BuildSlaveSupport/ews-build/steps.py:
3358         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
3359         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
3360         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
3361
3362 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
3363
3364         Enable DFG on MIPS
3365         https://bugs.webkit.org/show_bug.cgi?id=196689
3366
3367         Reviewed by Žan Doberšek.
3368
3369         Since the bytecode change, we enabled the baseline JIT on mips in
3370         r240432, but DFG is still missing. With this change, all tests are
3371         passing on a ci20 board.
3372
3373         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
3374
3375 2019-04-08  Philippe Normand  <pnormand@igalia.com>
3376
3377         [Flatpak] Second run update-webkitwpe-flatpak fails
3378         https://bugs.webkit.org/show_bug.cgi?id=192702
3379
3380         Reviewed by Carlos Garcia Campos.
3381
3382         * flatpak/flatpakutils.py:
3383         (FlatpakObject.flatpak): Fix typo.
3384         (FlatpakPackage.install): When installing, also update to the configured remote commit.
3385         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
3386
3387 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
3388
3389         [GTK][WPE] outlook.live.com displays old-fashioned UI
3390         https://bugs.webkit.org/show_bug.cgi?id=196642
3391
3392         Reviewed by Carlos Garcia Campos.
3393
3394         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3395         (TestWebKitAPI::TEST): New Mac platform quirk test.
3396
3397 2019-04-07  Commit Queue  <commit-queue@webkit.org>
3398
3399         Unreviewed, rolling out r243956.
3400         https://bugs.webkit.org/show_bug.cgi?id=196688
3401
3402         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
3403         by aakashjain on #webkit).
3404
3405         Reverted changeset:
3406
3407         "Clicking "Go Back" from a safe browsing warning from an
3408         iframe should navigate the WKWebView back to the previous
3409         page"
3410         https://bugs.webkit.org/show_bug.cgi?id=196665
3411         https://trac.webkit.org/changeset/243956
3412
3413 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
3414
3415         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
3416         https://bugs.webkit.org/show_bug.cgi?id=196669
3417
3418         Reviewed by Geoffrey Garen.
3419
3420         Added three new unit tests for WeakHashSet.
3421
3422         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3423         (WTF_WeakPtr.WeakHashSetConstObjects):
3424         (WTF_WeakPtr.WeakHashSetComputesEmpty):
3425         (WTF_WeakPtr.WeakHashSetComputeSize):
3426
3427 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3428
3429         Hide next and previous form control buttons when WKWebView is editable
3430         https://bugs.webkit.org/show_bug.cgi?id=196672
3431         <rdar://problem/35625321>
3432
3433         Reviewed by Tim Horton.
3434
3435         Add a new API test.
3436
3437         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3438         (-[TestWKWebView lastTrailingBarButtonGroup]):
3439         (TestWebKitAPI::TEST):
3440         * TestWebKitAPI/ios/UIKitSPI.h:
3441
3442 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
3443
3444         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
3445         https://bugs.webkit.org/show_bug.cgi?id=196077
3446         <rdar://problem/49108202>
3447
3448         Reviewed by Chris Dumez.
3449
3450         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
3451         on new web view.
3452
3453         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3454
3455 2019-04-05  Saam Barati  <sbarati@apple.com>
3456
3457         Make compare-results understand MotionMark
3458         https://bugs.webkit.org/show_bug.cgi?id=196666
3459
3460         Reviewed by Yusuke Suzuki.
3461
3462         * Scripts/compare-results:
3463         (PLT5Results):
3464         (detectMotionMark):
3465         (detectMotionMark1_1):
3466         (motionMarkResults):
3467         (motionMark1_1Results):
3468         (detectBenchmark):
3469         (biggerIsBetter):
3470         (main):
3471
3472 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3473
3474         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3475         https://bugs.webkit.org/show_bug.cgi?id=196665
3476         <rdar://45115669>
3477
3478         Reviewed by Geoff Garen.
3479
3480         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3481         (goBack):
3482         (+[SimpleLookupContext sharedLookupContext]):
3483         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3484         (TEST):
3485         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3486         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3487
3488 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3489
3490         [ews-build] Add configuration and architecture for windows builders
3491         https://bugs.webkit.org/show_bug.cgi?id=196660
3492
3493         Reviewed by Lucas Forschler.
3494
3495         * BuildSlaveSupport/ews-build/config.json:
3496
3497 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3498
3499         webkitpy: Don't run subsequent rounds if interrupted
3500         https://bugs.webkit.org/show_bug.cgi?id=196646
3501
3502         Reviewed by Aakash Jain.
3503
3504         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3505         (Manager.run): Bail out if interrupted.
3506
3507 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3508
3509         Test sessionStorage in PSON private browsing mode
3510         https://bugs.webkit.org/show_bug.cgi?id=196561
3511
3512         Reviewed by Alex Christensen.
3513
3514         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3515
3516 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3517
3518         Unreviewed, rolling out r243833.
3519         https://bugs.webkit.org/show_bug.cgi?id=196645
3520
3521         This change breaks build of WPE and GTK ports (Requested by
3522         annulen on #webkit).
3523
3524         Reverted changeset:
3525
3526         "[CMake][WTF] Mirror XCode header directories"
3527         https://bugs.webkit.org/show_bug.cgi?id=191662
3528         https://trac.webkit.org/changeset/243833
3529
3530 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3531
3532         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3533         https://bugs.webkit.org/show_bug.cgi?id=196635
3534
3535         Reviewed by Antti Koivisto.
3536         
3537         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3538         for a test to enable async frame scrolling via:
3539             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3540         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3541         
3542         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3543
3544         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3545         (WTR::InjectedBundle::beginTesting):
3546         * WebKitTestRunner/TestController.cpp:
3547         (WTR::TestController::resetPreferencesToConsistentValues):
3548
3549 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3550
3551         Use a correct LC_RPATH when building with ASan
3552         https://bugs.webkit.org/show_bug.cgi?id=196576
3553
3554         Reviewed by David Kilzer.
3555
3556         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3557         so that ../Frameworks is checked. This is simpler and more reliable than updating
3558         each SPC service xcconfig.
3559
3560 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3561
3562         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3563         https://bugs.webkit.org/show_bug.cgi?id=196629
3564
3565         Reviewed by Lucas Forschler.
3566
3567         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3568
3569 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3570
3571         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3572         https://bugs.webkit.org/show_bug.cgi?id=196618
3573
3574         Reviewed by Lucas Forschler.
3575
3576         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3577         (StatusBubble): Added QUEUE_TRIGGERS.
3578         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3579         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3580         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
3581         its parent(builder).
3582
3583 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3584
3585         [ews-app] Status-bubble steps are sometimes displayed in reverse order
3586         https://bugs.webkit.org/show_bug.cgi?id=196625
3587
3588         Reviewed by Lucas Forschler.
3589
3590         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3591         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
3592
3593 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3594
3595         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
3596         https://bugs.webkit.org/show_bug.cgi?id=196630
3597
3598         Reviewed by Wenson Hsieh.
3599
3600         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3601
3602 2019-04-04  Youenn Fablet  <youenn@apple.com>
3603
3604         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
3605         https://bugs.webkit.org/show_bug.cgi?id=196543
3606
3607         Reviewed by Alex Christensen.
3608
3609         * WebKitTestRunner/TestController.cpp:
3610         (WTR::TestController::generatePageConfiguration):
3611
3612 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3613
3614         [ews-app] Status bubble should not display skipped buildbot steps
3615         https://bugs.webkit.org/show_bug.cgi?id=196584
3616
3617         Reviewed by Lucas Forschler.
3618
3619         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3620
3621 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3622
3623         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
3624         https://bugs.webkit.org/show_bug.cgi?id=196620
3625
3626         Reviewed by Lucas Forschler.
3627
3628         * BuildSlaveSupport/ews-app/ews/config.py:
3629
3630 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
3631
3632         [Win] DumpRenderTreeWatchDog.py is not checked into source
3633         https://bugs.webkit.org/show_bug.cgi?id=196567
3634         <rdar://problem/49525901>
3635
3636         Reviewed by Lucas Forschler.
3637
3638         This script is used on Win EWS bots to terminate hanging DRT processes.
3639
3640         * EWSTools/dumprendertreewatchdog.py: Added.
3641
3642 2019-04-04  Chris Dumez  <cdumez@apple.com>
3643
3644         Unreviewed, roll out r243858 which made tests time out.
3645
3646         Disable new API tests on Windows instead.
3647
3648         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3649         (TestWebKitAPI::TEST):
3650
3651 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3652
3653         [ATK] Cleanup WebPageAccessibilityObjectAtk
3654         https://bugs.webkit.org/show_bug.cgi?id=196537
3655
3656         Reviewed by Michael Catanzaro.
3657
3658         Also consider files under atk directories as exceptions for GObject conventions.
3659
3660         * Scripts/webkitpy/style/checkers/cpp.py:
3661         (check_identifier_name_in_declaration):
3662
3663 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3664
3665         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3666         https://bugs.webkit.org/show_bug.cgi?id=196588
3667         <rdar://problem/49365787>
3668
3669         Unreviewed build fix for Windows port.
3670
3671         error C3861: 'kill': identifier not found
3672
3673         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3674         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
3675
3676 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3677
3678         [ews-build] Cancel build and similar operations should have authentication
3679         https://bugs.webkit.org/show_bug.cgi?id=196520
3680
3681         Reviewed by Dewei Zhu.
3682
3683         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
3684         environment variables.
3685
3686 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3687
3688         [ews-build] Do not trigger queues which are not in production yet
3689         https://bugs.webkit.org/show_bug.cgi?id=196581
3690
3691         Reviewed by Dewei Zhu.
3692
3693         * BuildSlaveSupport/ews-build/config.json:
3694
3695 2019-04-03  Chris Dumez  <cdumez@apple.com>
3696
3697         Unreviewed, fix typo in the name of API test added in r243848.
3698
3699         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3700         (TestWebKitAPI::TEST):
3701
3702 2019-04-03  Chris Dumez  <cdumez@apple.com>
3703
3704         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3705         https://bugs.webkit.org/show_bug.cgi?id=196588
3706         <rdar://problem/49365787>
3707
3708         Reviewed by Ryosuke Niwa.
3709
3710         Add API test coverage.
3711
3712         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3713         (TestWebKitAPI::nullJavaScriptCallback):
3714         (TestWebKitAPI::didCrashCheckFrames):
3715         (TestWebKitAPI::TEST):
3716
3717 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3718
3719         run-webkit-tests: Upload test results (new results database)
3720         https://bugs.webkit.org/show_bug.cgi?id=196577
3721         <rdar://problem/34841155>
3722
3723         Reviewed by Lucas Forschler.
3724
3725         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3726         (Manager.run): Upload results after each device shard, since the configuration will be
3727         different for each device.
3728         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3729         uploaded to a results database.
3730         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3731         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3732
3733 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3734
3735         -apple-trailing-word is needed for browser detection
3736         https://bugs.webkit.org/show_bug.cgi?id=196575
3737
3738         Unreviewed.
3739
3740         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3741
3742 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3743
3744         [CMake][WTF] Mirror XCode header directories
3745         https://bugs.webkit.org/show_bug.cgi?id=191662
3746
3747         Reviewed by Konstantin Tokarev.
3748
3749         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3750         builds.
3751
3752         * CMakeLists.txt:
3753         * DumpRenderTree/CMakeLists.txt:
3754         * DumpRenderTree/PlatformWin.cmake:
3755         * MiniBrowser/win/CMakeLists.txt:
3756         * TestWebKitAPI/CMakeLists.txt:
3757         * TestWebKitAPI/PlatformWin.cmake:
3758         * WebKitTestRunner/PlatformGTK.cmake:
3759         * WebKitTestRunner/PlatformWin.cmake:
3760
3761 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3762
3763         [ews-app] Status bubble should not display certain infrastructure status messages
3764         https://bugs.webkit.org/show_bug.cgi?id=196550
3765
3766         Reviewed by Lucas Forschler.
3767
3768         Do not display the steps which are un-needed for end-user. This information is still avaiable
3769         if the user click on the bubble and look at the Buildbot build.
3770         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3771         (StatusBubble._steps_messages):
3772         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
3773
3774 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3775
3776         [ews-build] Use https for sending data to ews-app
3777         https://bugs.webkit.org/show_bug.cgi?id=196492
3778
3779         Reviewed by Lucas Forschler.
3780
3781         * BuildSlaveSupport/ews-build/events.py:
3782
3783 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3784
3785         Remove support for -apple-trailing-word
3786         https://bugs.webkit.org/show_bug.cgi?id=196525
3787
3788         Reviewed by Zalan Bujtas.
3789
3790         This CSS property is nonstandard and not used.
3791
3792         * Scripts/webkitperl/FeatureList.pm:
3793         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3794
3795 2019-04-03  Youenn Fablet  <youenn@apple.com>
3796
3797         Add a test for DOMCache on multiple browsing in case of private browsing
3798         https://bugs.webkit.org/show_bug.cgi?id=196524
3799
3800         Reviewed by Alex Christensen.
3801
3802         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3803         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
3804
3805 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3806
3807         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
3808         https://bugs.webkit.org/show_bug.cgi?id=196540
3809
3810         Reviewed by Aakash Jain.
3811
3812         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
3813
3814 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3815
3816         Add plumbing for a compatibility mode preference in WebKit
3817         https://bugs.webkit.org/show_bug.cgi?id=196005
3818
3819         Reviewed by Tim Horton.
3820
3821         Add new API tests.
3822
3823         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3824         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
3825
3826 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
3827
3828         [WPE][GTK] Update libsrtp dependency package for Debian
3829         https://bugs.webkit.org/show_bug.cgi?id=196528
3830
3831         Reviewed by Frédéric Wang.
3832
3833         * gtk/install-dependencies:
3834         * wpe/install-dependencies:
3835
3836 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3837
3838         [WK2] Add support for Window's beforeprint / afterprint events
3839         https://bugs.webkit.org/show_bug.cgi?id=196478
3840         <rdar://problem/49535124>
3841
3842         Unreviewed build fix for MSVC.
3843
3844         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
3845
3846         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
3847
3848         * WebKitTestRunner/TestController.cpp:
3849         (WTR::printFrame): Use int and float literals.
3850
3851 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3852
3853         [ews-build] Reassign bots to queues
3854
3855         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
3856
3857 2019-04-02  Chris Dumez  <cdumez@apple.com>
3858
3859         [WK2] Add support for Window's beforeprint / afterprint events
3860         https://bugs.webkit.org/show_bug.cgi?id=196478
3861
3862         Reviewed by Alex Christensen.
3863
3864         Add minimal implementation for printFrame in WebKitTestRunner.
3865
3866         * WebKitTestRunner/TestController.cpp:
3867         (WTR::printFrame):
3868         (WTR::TestController::createOtherPage):
3869         (WTR::TestController::createWebViewWithOptions):
3870
3871 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3872
3873         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
3874         https://bugs.webkit.org/show_bug.cgi?id=196491
3875
3876         Reviewed by Lucas Forschler.
3877
3878         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3879
3880 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3881
3882         [ews-build] Configure buildbot try credentials in environment variables
3883         https://bugs.webkit.org/show_bug.cgi?id=196501
3884
3885         Reviewed by Lucas Forschler.
3886
3887         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
3888         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
3889         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
3890
3891 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3892
3893         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
3894         https://bugs.webkit.org/show_bug.cgi?id=196496
3895         <rdar://problem/49521634>
3896
3897         Reviewed by Chris Dumez.
3898
3899         Add new API tests (see WebKit ChangeLog for more detail).
3900
3901         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3902         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3903         (TEST):
3904
3905 2019-04-02  David Kilzer  <ddkilzer@apple.com>
3906
3907         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
3908         <https://webkit.org/b/196499>
3909
3910         Reviewed by Alexey Proskuryakov.
3911
3912         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
3913         ENABLE_ADDRESS_SANITIZER.
3914
3915 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3916
3917         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
3918         https://bugs.webkit.org/show_bug.cgi?id=182757
3919
3920         Reviewed by Don Olmstead.
3921
3922         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
3923         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3924
3925 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
3926
3927         run-api-tests: Upload test results
3928         https://bugs.webkit.org/show_bug.cgi?id=196323
3929         <rdar://problem/49356714>
3930
3931         Reviewed by Lucas Forschler.
3932
3933         * Scripts/webkitpy/api_tests/manager.py:
3934         (Manager):
3935         (Manager.run): Upload results to a results database.
3936         * Scripts/webkitpy/api_tests/run_api_tests.py:
3937         (parse_args): Add upload arguments.
3938         * Scripts/webkitpy/port/base.py:
3939         (Port):
3940         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
3941         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
3942         with commits from any other associated repositories.
3943         * Scripts/webkitpy/port/device.py:
3944         (Device):
3945         (Device.build_version): Access build_versoin of underlying platform device.
3946         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3947         (IOSSimulatorTest):
3948         (IOSSimulatorTest.test_configuration_for_upload):
3949         * Scripts/webkitpy/port/device_port.py:
3950         (DevicePort):
3951         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
3952         the same as the machine uploading results.
3953         * Scripts/webkitpy/port/mac.py:
3954         (MacPort):
3955         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3956         * Scripts/webkitpy/port/mac_unittest.py:
3957         (MacTest):
3958         (MacTest.test_configuration_for_upload):
3959         * Scripts/webkitpy/xcode/simulated_device.py:
3960         (SimulatedDeviceManager._create_device_with_runtime):
3961         (SimulatedDevice.__init__): Create simulated device with a build_version.
3962         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3963         (test_existing_simulator):
3964
3965 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3966
3967         Remove extra newline characters (Follow-up fix to r243707)
3968
3969         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3970
3971 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3972
3973         [ews-app] Use API_KEY to accept results data
3974         https://bugs.webkit.org/show_bug.cgi?id=196461
3975
3976         Reviewed by Dewei Zhu.
3977
3978         * BuildSlaveSupport/ews-app/ews/views/results.py:
3979         (Results.post): Validate EWS_API_KEY before accepting any data.
3980         * BuildSlaveSupport/ews-build/events.py:
3981         (Events.sendData): Send EWS_API_KEY if available along with event data.
3982
3983 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3984
3985         Unable to copy and paste a PDF from Notes into Mail compose body
3986         https://bugs.webkit.org/show_bug.cgi?id=196442
3987         <rdar://problem/48573098>
3988
3989         Reviewed by Tim Horton.
3990
3991         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3992         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3993         to be specified on the item providers.
3994
3995         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3996         (TestWebKitAPI::mapItemForTesting):
3997         (TestWebKitAPI::contactItemForTesting):
3998
3999 2019-04-01  Tim Horton  <timothy_horton@apple.com>
4000
4001         Make UIWKDocumentContext rects per-character instead of per-word
4002         https://bugs.webkit.org/show_bug.cgi?id=196459
4003
4004         Reviewed by Wenson Hsieh.
4005
4006         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4007         (TEST):
4008         Adjust test results due to switching to per-character rects.
4009
4010 2019-04-01  Chris Dumez  <cdumez@apple.com>
4011
4012         UIProcess crash when a prewarmed process is terminated
4013         https://bugs.webkit.org/show_bug.cgi?id=196451
4014         <rdar://problem/49245471>
4015
4016         Reviewed by Geoffrey Garen.
4017
4018         Add API test coverage.
4019
4020         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
4021         (TEST):
4022
4023 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
4024
4025         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
4026         https://bugs.webkit.org/show_bug.cgi?id=196449
4027
4028         Reviewed by Lucas Forschler.
4029
4030         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4031         (StatusBubble.get_os_details): Method to get OS and Xcode details.
4032         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
4033         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
4034
4035 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
4036
4037         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
4038         https://bugs.webkit.org/show_bug.cgi?id=196444
4039
4040         Reviewed by Lucas Forschler.
4041
4042         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
4043
4044 2019-04-01  Alex Christensen  <achristensen@webkit.org>
4045
4046         Add SPI to canonicalize NSURLs with WTF::URL
4047         https://bugs.webkit.org/show_bug.cgi?id=196415
4048         <rdar://problem/44980271>
4049
4050         Reviewed by Darin Adler.
4051
4052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4053         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
4054         (TestWebKitAPI::TEST):
4055
4056 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
4057
4058         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
4059         https://bugs.webkit.org/show_bug.cgi?id=196441
4060
4061         Reviewed by Carlos Garcia Campos.
4062
4063         Don't cache the wpe_view_backend object that might not exist yet at the
4064         time of EventSenderProxy constructor invocation, but instead retrieve
4065         that object whenever it's required for event dispatching. This should
4066         avoid crashes in this constructor now that it's invoked before any
4067         PlatformWindow has been set up (as changed in r243496).
4068
4069         * WebKitTestRunner/EventSenderProxy.h:
4070         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
4071         (WTR::viewBackend):
4072         (WTR::EventSenderProxy::EventSenderProxy):
4073         (WTR::EventSenderProxy::mouseDown):
4074         (WTR::EventSenderProxy::mouseUp):
4075         (WTR::EventSenderProxy::mouseMoveTo):
4076         (WTR::EventSenderProxy::mouseScrollBy):
4077         (WTR::EventSenderProxy::keyDown):
4078         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
4079
4080 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
4081
4082         [Win][WebKit] MiniBrowser should support high DPI display
4083         https://bugs.webkit.org/show_bug.cgi?id=196391
4084
4085         Reviewed by Alex Christensen.
4086
4087         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4088         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
4089         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
4090         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
4091
4092 2019-03-31  Sam Weinig  <weinig@apple.com>
4093
4094         Remove more i386 specific configurations
4095         https://bugs.webkit.org/show_bug.cgi?id=196430
4096
4097         Reviewed by Alexey Proskuryakov.
4098
4099         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4100         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
4101
4102 2019-03-31  Andy Estes  <aestes@apple.com>
4103
4104         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
4105         https://bugs.webkit.org/show_bug.cgi?id=196433
4106         <rdar://problem/49293305>
4107
4108         Reviewed by Tim Horton.
4109
4110         Enhanced API test coverage to include all navigation response policy decisions in both
4111         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
4112
4113         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4114         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
4115         (TestWebKitAPI::TEST):
4116         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
4117         (readFile):
4118         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
4119         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
4120         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4121         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4122         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4123         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
4124         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
4125         (-[QuickLookDelegate _downloadDidStart:]):
4126         (-[QuickLookDelegate _download:didReceiveResponse:]):
4127         (-[QuickLookDelegate _download:didReceiveData:]):
4128         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4129         (-[QuickLookDelegate _downloadDidFinish:]):
4130         (-[QuickLookDelegate _download:didFailWithError:]):
4131         (-[QuickLookDelegate _downloadDidCancel:]):
4132         (-[QuickLookDelegate verifyDownload]):
4133         (runTest):
4134         (runTestDecideBeforeLoading):
4135         (runTestDecideAfterLoading):
4136         (TEST):
4137         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4138         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4139         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
4140         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
4141         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
4142         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
4143         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
4144         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
4145         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
4146         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
4147         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
4148         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
4149         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
4150         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
4151
4152 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
4153
4154         [CMake] add testdfg as target with build-jsc
4155         https://bugs.webkit.org/show_bug.cgi?id=196393
4156
4157         Reviewed by Saam Barati.
4158
4159         Added testdfg as one of the targets to build when
4160         using CMake.
4161
4162         * Scripts/build-jsc:
4163
4164 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
4165
4166         Delete WebMetal implementation in favor of WebGPU
4167         https://bugs.webkit.org/show_bug.cgi?id=195418
4168
4169         Reviewed by Dean Jackson.
4170
4171         * DumpRenderTree/mac/DumpRenderTree.mm:
4172         (enableExperimentalFeatures):
4173         (resetWebPreferencesToConsistentValues):
4174         * Scripts/webkitperl/FeatureList.pm:
4175         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4176         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4177         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
4178         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
4179         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
4180         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
4181         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
4182         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
4183         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
4184         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4185         (WTR::InjectedBundle::beginTesting):
4186         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4187         (WTR::TestRunner::setWebMetalEnabled): Deleted.
4188         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4189
4190 2019-03-29  Chris Dumez  <cdumez@apple.com>
4191
4192         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
4193         https://bugs.webkit.org/show_bug.cgi?id=196405
4194         <rdar://problem/49428130>
4195
4196         Reviewed by Wenson Hsieh.
4197
4198         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
4199         the popover presentation methods to be no-ops. Use this in the new test added in
4200         r243523 so that we do not swizzle those methods for all tests. This is needed because
4201         those WatchOS tests rely on the popover getting presented and interactive.
4202
4203         * WebKitTestRunner/TestController.cpp:
4204         (WTR::updateTestOptionsFromTestHeader):
4205         * WebKitTestRunner/TestController.h:
4206         * WebKitTestRunner/TestOptions.h:
4207         (WTR::TestOptions::hasSameInitializationOptions const):
4208         * WebKitTestRunner/ios/TestControllerIOS.mm:
4209         (WTR::TestController::platformInitialize):
4210         (WTR::TestController::platformResetStateToConsistentValues):
4211
4212 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
4213
4214         [Curl] Add Server Trust Evaluation Support.
4215         https://bugs.webkit.org/show_bug.cgi?id=191646
4216
4217         Reviewed by Fujii Hironori.
4218
4219         Implemented MiniBrowser UI for asking if user trusts the server.
4220
4221         * MiniBrowser/win/Common.cpp:
4222         (askServerTrustEvaluation):
4223         (replaceString):
4224         * MiniBrowser/win/Common.h:
4225         * MiniBrowser/win/MiniBrowserLib.rc:
4226         * MiniBrowser/win/MiniBrowserLibResource.h:
4227         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4228         (createPEMString):
4229         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4230         (WebKitBrowserWindow::canTrustServerCertificate):
4231         * MiniBrowser/win/WebKitBrowserWindow.h:
4232
4233 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
4234
4235         Implement ResizeObserver.
4236         https://bugs.webkit.org/show_bug.cgi?id=157743
4237
4238         Reviewed by Simon Fraser.
4239
4240         Support resizeObserverEnabled webPreferences.
4241
4242         * DumpRenderTree/TestOptions.cpp:
4243         (TestOptions::TestOptions):
4244         * DumpRenderTree/TestOptions.h:
4245         * DumpRenderTree/mac/DumpRenderTree.mm:
4246         (setWebPreferencesForTestOptions):
4247         * DumpRenderTree/win/DumpRenderTree.cpp:
4248         (enableExperimentalFeatures):
4249         * Scripts/webkitperl/FeatureList.pm:
4250         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4251
4252 2019-03-28  John Wilander  <wilander@apple.com>
4253
4254         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
4255         https://bugs.webkit.org/show_bug.cgi?id=196281
4256         <rdar://problem/48938748>
4257
4258         Reviewed by Alex Christensen.
4259
4260         This patch adds the function isStatisticsHasLocalStorage() to the
4261         TestRunner. With it, the page can query the WebsiteDataStore in the
4262         UI process to make sure that it sees LocalStorage.
4263
4264         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4265         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4266         (WTR::TestRunner::isStatisticsHasLocalStorage):
4267         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4268         * WebKitTestRunner/TestController.cpp:
4269         (WTR::TestController::isStatisticsHasLocalStorage):
4270         * WebKitTestRunner/TestController.h:
4271         * WebKitTestRunner/TestInvocation.cpp:
4272         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4273
4274 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
4275
4276         API::Data::createWithoutCopying should do a null check before calling CFRelease
4277         https://bugs.webkit.org/show_bug.cgi?id=196276
4278         <rdar://problem/48059859>
4279
4280         Reviewed by Alex Christensen.
4281
4282         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
4283
4284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4285         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
4286         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
4287         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
4288         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4289         (TestWebKitAPI::TEST):
4290
4291 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
4292
4293         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
4294         https://bugs.webkit.org/show_bug.cgi?id=186276
4295
4296         Reviewed by Carlos Garcia Campos.
4297
4298         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
4299         (webViewLoadChanged):
4300         (testWebResourceGetDataError):
4301         (testWebResourceGetDataEmpty):
4302         (beforeAll):
4303         (webViewloadChanged): Deleted.
4304
4305 2019-03-27  Andy Estes  <aestes@apple.com>
4306
4307         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
4308         https://bugs.webkit.org/show_bug.cgi?id=196317
4309
4310         Reviewed by Dan Bernstein.