[ews-app] Production and Development env should configure DEBUG appropriately
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] Production and Development env should configure DEBUG appropriately
4         https://bugs.webkit.org/show_bug.cgi?id=197700
5
6         Reviewed by Jonathan Bedard.
7
8         * BuildSlaveSupport/ews-app/ews-app/settings.py:
9
10 2019-05-09  Xan López  <xan@igalia.com>
11
12         [CMake] Detect SSE2 at compile time
13         https://bugs.webkit.org/show_bug.cgi?id=196488
14
15         Reviewed by Carlos Garcia Campos.
16
17         * Scripts/webkitdirs.pm:
18         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
19         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
20
21 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
22
23         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
24         https://bugs.webkit.org/show_bug.cgi?id=197697
25
26         Reviewed by Žan Doberšek.
27
28         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
29         * wpe/jhbuild.modules: Ditto.
30
31 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
32
33         Update ANGLE
34         https://bugs.webkit.org/show_bug.cgi?id=197676
35
36         Reviewed by Alex Christensen.
37
38         * TestWebKitAPI/PlatformWin.cmake:
39         Remove unnecessary library linkage.
40
41 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
42
43         [Win] build-webkit should be ready for Visual Studio 2019
44         https://bugs.webkit.org/show_bug.cgi?id=196622
45
46         Reviewed by Ross Kirsling.
47
48         1. Accommodated to the new msbuild.exe location of VS 2019.
49         2. Removed the hard coded "Visual Studio 15" generator.
50
51         build-webkit is going to choose a Visual Studio generator version
52         matching with the latest installed VS. If you invoke vcvars.bat
53         before build-webkit, it chooses the corresponding Visual Studio
54         generator version by cheking 'VisualStudioVersion' env var which
55         is set by vcvars.bat.
56
57         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
58         (msBuildPath): When looking for MSBuild, look in
59         "MSBuild\Current\bin" (the new expected location) and fallback
60         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
61         first location.
62         (msBuildInstallDir): Renamed to msBuildPath.
63         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
64         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
65
66 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
67
68         [PlayStation] Update port options
69         https://bugs.webkit.org/show_bug.cgi?id=197723
70
71         Reviewed by Ross Kirsling.
72
73         ICU headers were missing from TestWTF.
74
75         * TestWebKitAPI/PlatformPlayStation.cmake:
76
77 2019-05-08  Alex Christensen  <achristensen@webkit.org>
78
79         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
80         https://bugs.webkit.org/show_bug.cgi?id=197712
81         <rdar://problem/50429770>
82
83         Reviewed by Tim Horton.
84
85         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
86         (TestWebKitAPI::TEST):
87
88 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
89
90         Change my status to be a WebKit reviewer.
91
92         * Scripts/webkitpy/common/config/contributors.json:
93
94 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
95
96         Unreviewed, rolling out r244952.
97
98         Caused inspector to appear blank.
99
100         Reverted changeset:
101
102         "Web Inspector: Provide UIString descriptions to improve
103         localizations"
104         https://bugs.webkit.org/show_bug.cgi?id=195132
105         https://trac.webkit.org/changeset/244952
106
107 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
108
109         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
110         https://bugs.webkit.org/show_bug.cgi?id=197685
111
112         Reviewed by Alex Christensen.
113
114         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
115         completion. See LayoutTests/ChangeLog for more details.
116
117         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
118         (WTR::UIScriptController::platformClearAllCallbacks):
119
120 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
121
122         Unreviewed. Add myself as a committer.
123
124         * Scripts/webkitpy/common/config/contributors.json:
125
126 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
127
128         Unreviewed, rolling out r245038.
129
130         Breaks internal builds.
131
132         Reverted changeset:
133
134         "Add SPI to set a list of hosts to which to send custom header
135         fields cross-origin"
136         https://bugs.webkit.org/show_bug.cgi?id=197397
137         https://trac.webkit.org/changeset/245038
138
139 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
140
141         Unreviewed. Add myself as a committer.
142
143         * Scripts/webkitpy/common/config/contributors.json:
144
145 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
146
147         Define media buffering policy
148         https://bugs.webkit.org/show_bug.cgi?id=196979
149         <rdar://problem/28383861>
150
151         Reviewed by Jer Noble.
152
153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
154         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
155         (waitUntilBufferingPolicyIsEqualTo):
156         (TEST):
157
158 2019-05-07  Alex Christensen  <achristensen@webkit.org>
159
160         Add SPI to set a list of hosts to which to send custom header fields cross-origin
161         https://bugs.webkit.org/show_bug.cgi?id=197397
162
163         Reviewed by Geoff Garen.
164
165         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
166         (TEST):
167         (expectLegacyHeaders):
168         (expectHeaders):
169         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
170         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
171         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
172
173 2019-05-07  Keith Rollin  <krollin@apple.com>
174
175         Add option to build-webkit to control whether or not XCBuild is used
176         https://bugs.webkit.org/show_bug.cgi?id=197668
177         <rdar://problem/50549728>
178
179         Reviewed by Tim Horton.
180
181         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
182         Also update build-webkit and the makefiles with the foundation for
183         automatically using XCBuild when the conditions allow it. This latter
184         facility is currently turned off until Xcode fully supports building
185         WebKit with XCBuild.
186
187         * Scripts/build-webkit:
188         * Scripts/webkitdirs.pm:
189         (XcodeOptions):
190         (canUseXCBuild):
191
192 2019-05-07  Andy Estes  <aestes@apple.com>
193
194         run-bindings-tests should test global scope constructor generation
195         https://bugs.webkit.org/show_bug.cgi?id=197669
196
197         Reviewed by Alex Christensen.
198
199         * Scripts/webkitpy/bindings/main.py:
200         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
201         invoking preprocess-idls.pl.
202
203 2019-05-07  Youenn Fablet  <youenn@apple.com>
204
205         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
206         https://bugs.webkit.org/show_bug.cgi?id=195997
207         <rdar://problem/50509884>
208
209         Reviewed by Chris Dumez.
210
211         Spin test until successful.
212
213         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
214
215 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
216
217         [Flatpak] webkit-build fails due to missing GTK2 in build environment
218         https://bugs.webkit.org/show_bug.cgi?id=197352
219
220         Reviewed by Philippe Normand.
221
222         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
223         to build it ourselves on top in order to be able to build the GTK 2.x plugin
224         process.
225
226         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
227
228 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
229
230         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
231         https://bugs.webkit.org/show_bug.cgi?id=197644
232         <rdar://problem/50526364>
233
234         Reviewed by Tim Horton.
235
236         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
237
238         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
239         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
240         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
241         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
242
243 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
244
245         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
246         https://bugs.webkit.org/show_bug.cgi?id=197651
247
248         Reviewed by Žan Doberšek.
249
250         This is required since the process creation was delayed until something is loaded in the view.
251
252         * MiniBrowser/gtk/BrowserWindow.c:
253         (browser_window_get_or_create_web_view_for_automation):
254         * MiniBrowser/wpe/main.cpp:
255         (main):
256
257 2019-05-06  Tim Horton  <timothy_horton@apple.com>
258
259         _overrideViewportWithArguments does not work when called before loading
260         https://bugs.webkit.org/show_bug.cgi?id=197638
261         <rdar://problem/50505111>
262
263         Reviewed by Wenson Hsieh.
264
265         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
266         (TEST):
267
268 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
269
270         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
271         https://bugs.webkit.org/show_bug.cgi?id=197510
272
273         Reviewed by Alex Christensen.
274
275         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
276         (TestWebKitAPI::TEST):
277
278 2019-05-06  Keith Rollin  <krollin@apple.com>
279
280         Temporarily disable generate-xcfilelists
281         https://bugs.webkit.org/show_bug.cgi?id=197619
282         <rdar://problem/50507392>
283
284         Reviewed by Alex Christensen.
285
286         We need to perform a significant update to the generate-xcfilelist
287         scripts. This work involves coordinated work with another facility. If
288         the work does not occur in tandem, the build will be broken. To avoid
289         this, disable the invoking of the scripts during the transition. The
290         checking will be restored once the new scripts are in place.
291
292         * DumpRenderTree/Scripts/check-xcfilelists.sh:
293         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
294
295 2019-05-04  Alex Christensen  <achristensen@webkit.org>
296
297         Revert r244953 and r244954 because they broke internal builds.
298         https://bugs.webkit.org/show_bug.cgi?id=197534
299
300         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
301         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
302         * DumpRenderTree/mac/DumpRenderTree.mm:
303         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
304         * DumpRenderTree/mac/TestRunnerMac.mm:
305         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
306         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
307         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
308         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
309         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
310         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
311         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
312         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
313         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
314         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
315         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
316         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
317         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
318         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
319         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
320         * TestWebKitAPI/cocoa/TestWKWebView.mm:
321         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
322         * TestWebKitAPI/ios/UIKitSPI.h: Added.
323         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
324         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
325         * WebKitTestRunner/ios/HIDEventGenerator.h:
326         * WebKitTestRunner/ios/HIDEventGenerator.mm:
327         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
328         * WebKitTestRunner/ios/TestControllerIOS.mm:
329         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
330         * WebKitTestRunner/ios/mainIOS.mm:
331
332 2019-05-04  Alex Christensen  <achristensen@webkit.org>
333
334         Merge the three UIKitSPI.h files into a single one in PAL
335         https://bugs.webkit.org/show_bug.cgi?id=197534
336
337         Reviewed by Darin Adler.
338
339         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
340         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
341         * DumpRenderTree/mac/DumpRenderTree.mm:
342         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
343         * DumpRenderTree/mac/TestRunnerMac.mm:
344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
345         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
346         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
347         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
348         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
349         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
350         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
351         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
352         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
353         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
354         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
355         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
356         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
357         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
358         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
359         * TestWebKitAPI/cocoa/TestWKWebView.mm:
360         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
361         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
362         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
363         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
364         * WebKitTestRunner/ios/HIDEventGenerator.h:
365         * WebKitTestRunner/ios/HIDEventGenerator.mm:
366         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
367         * WebKitTestRunner/ios/TestControllerIOS.mm:
368         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
369         * WebKitTestRunner/ios/mainIOS.mm:
370
371 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
372
373         Web Inspector: Provide UIString descriptions to improve localizations
374         https://bugs.webkit.org/show_bug.cgi?id=195132
375         <rdar://problem/48457817>
376
377         Reviewed by Devin Rousso.
378
379         Allow WI.UIString to take:
380         - WI.UIString(string, key, comment)
381         - WI.UIString(string, comment)
382         - WI.UIString(string)
383
384         * Scripts/extract-localizable-js-strings:
385
386 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
387
388         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
389         https://bugs.webkit.org/show_bug.cgi?id=197579
390
391         Reviewed by Tim Horton.
392
393         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
394         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
395         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
396         ensure that the the focused element has been blurred.
397
398         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
399
400 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
401
402         Add a tool to block spammer accounts
403         https://bugs.webkit.org/show_bug.cgi?id=197537
404
405         Reviewed by Darin Adler.
406
407         Usage: block-spammers email1 email2 ...
408
409         The tool finds and hides all bugs and comments from this account. Before any work
410         is done, these bugs and comments are displayed for confirmation.
411
412         * Scripts/block-spammers: Added.
413         (get_bugzilla_token):
414         (invalidate_bugzilla_token):
415         (get_user_info):
416         (get_user_info_self):
417         (can_use_this_tool):
418         (disable_user):
419         (get_bugs_created_by_user):
420         (get_bugs_commented_on_by_user):
421         (get_comments):
422         (hide_bug):
423         (hide_comments):
424         (ask_yes_no):
425         (sanitized_string):
426         (main):
427
428 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
429
430         run-apit-tests: Add --iterations and --repeat-each
431         https://bugs.webkit.org/show_bug.cgi?id=197563
432
433         Reviewed by Aakash Jain.
434
435         * Scripts/webkitpy/api_tests/manager.py:
436         (Manager.run): Add --iterations and --repeat-each/
437         * Scripts/webkitpy/api_tests/run_api_tests.py:
438         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
439
440 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
441
442         New EWS: Clicking on white bubble navigates to page with only bubbles
443         https://bugs.webkit.org/show_bug.cgi?id=197520
444
445         Reviewed by Lucas Forschler.
446
447         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
448
449 2019-05-03  Daniel Bates  <dabates@apple.com>
450
451         [lldb-webkit] Support adding pretty-printing for qualified types
452         https://bugs.webkit.org/show_bug.cgi?id=197518
453
454         Reviewed by Darin Adler.
455
456         Remove all "::"s from the name of the specified type when computing the name for the Python classes
457         that will provide summary and synthetic details as LLDB is not happy about registering such classes
458         when they contain :: in their name.
459
460         * lldb/lldb_webkit.py:
461         (addSummaryAndSyntheticFormattersForRawBitmaskType):
462
463 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
464
465         New EWS: patches on recently added queues listed as #1 for older bugs
466         https://bugs.webkit.org/show_bug.cgi?id=197496
467
468         Reviewed by Lucas Forschler.
469
470         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
471         (StatusBubble._build_bubble):
472         (StatusBubble._queue_position):
473
474 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
475
476         webkit-patch --no-review upload does not submit patch to New EWS
477         https://bugs.webkit.org/show_bug.cgi?id=197519
478         <rdar://problem/50424887>
479
480         Reviewed by Lucas Forschler.
481
482         * Scripts/webkitpy/tool/steps/submittoews.py:
483         (SubmitToEWS.run): Submit to both old and new EWS.
484         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
485         * Scripts/webkitpy/common/net/ewsserver.py: Added.
486         (EWSServer._server_url): Method to return server url.
487         (EWSServer._post_patch_to_ews): Method to post patch to ews.
488         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
489         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
490         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
491         * Scripts/webkitpy/common/net/statusserver_mock.py:
492         (MockStatusServer.submit_to_ews): Updated the log text.
493         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
494         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
495         * Scripts/webkitpy/tool/main.py:
496         (WebKitPatch.__init__): Initialize ews_server. 
497         * Scripts/webkitpy/tool/mocktool.py:
498         (MockTool.__init__): Ditto.
499
500 2019-05-03  Chris Dumez  <cdumez@apple.com>
501
502         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
503         https://bugs.webkit.org/show_bug.cgi?id=197574
504         <rdar://problem/50453181>
505
506         Reviewed by Tim Horton.
507
508         Add API test coverage.
509
510         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
511         (TEST):
512
513 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
514
515         [JSC] Generator CodeBlock generation should be idempotent
516         https://bugs.webkit.org/show_bug.cgi?id=197552
517
518         Reviewed by Keith Miller.
519
520         * Scripts/run-javascriptcore-tests:
521         (runJSCStressTests):
522         * Scripts/run-jsc-stress-tests:
523
524 2019-05-03  Commit Queue  <commit-queue@webkit.org>
525
526         Unreviewed, rolling out r244881.
527         https://bugs.webkit.org/show_bug.cgi?id=197559
528
529         Breaks compilation of jsconly on linux, breaking compilation
530         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
531         guijemont on #webkit).
532
533         Reverted changeset:
534
535         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
536         WEBKIT_COPY_FILES"
537         https://bugs.webkit.org/show_bug.cgi?id=197174
538         https://trac.webkit.org/changeset/244881
539
540 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
541
542         Unreviewed WPE build fix after r244898.
543
544         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
545         (WTR::TestController::abortModal): Add the missing (no-op) definition.
546
547 2019-05-02  Alex Christensen  <achristensen@webkit.org>
548
549         Mark U+01C0 as a homograph of U+006C
550         https://bugs.webkit.org/show_bug.cgi?id=197526
551         <rdar://problem/50301904>
552
553         Reviewed by Tim Horton.
554
555         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
556         (TestWebKitAPI::TEST):
557
558 2019-05-02  Chris Dumez  <cdumez@apple.com>
559
560         Add test coverage for <rdar://problem/49731231>
561         https://bugs.webkit.org/show_bug.cgi?id=196730
562         <rdar://problem/49731231>
563
564         Reviewed by Ryosuke Niwa.
565
566         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
567         to match DumpRenderTree.
568
569         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
570         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
571         (WTR::TestRunner::abortModal):
572         * WebKitTestRunner/InjectedBundle/TestRunner.h:
573         * WebKitTestRunner/TestController.cpp:
574         (WTR::TestController::runModal):
575         * WebKitTestRunner/TestController.h:
576         * WebKitTestRunner/TestInvocation.cpp:
577         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
578         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
579         (WTR::TestController::abortModal):
580         * WebKitTestRunner/ios/TestControllerIOS.mm:
581         (WTR::TestController::abortModal):
582         * WebKitTestRunner/mac/TestControllerMac.mm:
583         (WTR::TestController::abortModal):
584         * WebKitTestRunner/win/TestControllerWin.cpp:
585         (WTR::TestController::abortModal):
586
587 2019-05-02  Christopher Reid  <chris.reid@sony.com>
588
589         [CMake] Add support for LTO builds
590         https://bugs.webkit.org/show_bug.cgi?id=188986
591
592         Reviewed by Don Olmstead.
593
594         Add support to configure --lto-mode with cmake builds.
595
596         * Scripts/build-webkit:
597         * Scripts/webkitdirs.pm:
598         (generateBuildSystemFromCMakeProject):
599
600 2019-05-02  John Wilander  <wilander@apple.com>
601
602         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
603         https://bugs.webkit.org/show_bug.cgi?id=197521
604         <rdar://problem/49651503>
605
606         Reviewed by Brent Fulgham.
607
608         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
609         (TestWebKitAPI::TEST):
610            Added a test for host strings with leading dots since they are
611            often used for the domain attribute in cookies.
612
613 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
614
615         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
616         https://bugs.webkit.org/show_bug.cgi?id=197510
617
618         Reviewed by Alex Christensen.
619
620         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
621         (TestWebKitAPI::TEST):
622
623 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
624
625         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
626         https://bugs.webkit.org/show_bug.cgi?id=197174
627
628         Reviewed by Alex Christensen.
629
630         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
631
632         * TestWebKitAPI/PlatformGTK.cmake:
633         * TestWebKitAPI/PlatformWPE.cmake:
634
635 2019-05-02  Alex Christensen  <achristensen@webkit.org>
636
637         Build fix for internal branch.
638
639         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
640         RetainPtr.h was not explicitly included.
641
642 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
643
644         webkitpy: Ignore errors when shutting down an already shutdown simulator
645         <https://bugs.webkit.org/show_bug.cgi?id=197514>
646         <rdar://problem/50390247>
647
648         Reviewed by Lucas Forschler.
649
650         * Scripts/webkitpy/xcode/simulated_device.py:
651         (SimulatedDevice._shut_down):
652
653 2019-05-02  Frederic Wang  <fwang@igalia.com>
654
655         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
656         https://bugs.webkit.org/show_bug.cgi?id=196142
657
658         This patch introduces some experimental runtime flag to let users
659         disable MathML features that are removed from MathML Core [1]. For now,
660         these features are only disabled on GTK and WPE ports.
661
662         [1] https://mathml-refresh.github.io/mathml-core/
663
664         Reviewed by Rob Buis.
665
666         * DumpRenderTree/TestOptions.cpp:
667         (TestOptions::TestOptions):
668         * DumpRenderTree/TestOptions.h:
669         * DumpRenderTree/mac/DumpRenderTree.mm:
670         (setWebPreferencesForTestOptions):
671
672 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
673
674         TestWebKitAPI config.h should be aware of what suite is being built
675         https://bugs.webkit.org/show_bug.cgi?id=196583
676
677         Reviewed by Konstantin Tokarev.
678
679         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
680         benefit the macro defines BUILDING_* for the executable which allows the includes
681         of the config.h to be tailored to the test suite being built. Because of that the
682         dependencies of the Test* executable are specific to the test suite which may
683         speed up the build.
684
685         Some source files were including "PlatformUtilities.h" which includes WebKit headers
686         when "Utilities.h" is what was needed.
687
688         * TestWebKitAPI/CMakeLists.txt:
689         * TestWebKitAPI/PlatformGTK.cmake:
690         * TestWebKitAPI/PlatformJSCOnly.cmake:
691         * TestWebKitAPI/PlatformMac.cmake:
692         * TestWebKitAPI/PlatformPlayStation.cmake:
693         * TestWebKitAPI/PlatformUtilities.h:
694         * TestWebKitAPI/PlatformWPE.cmake:
695         * TestWebKitAPI/PlatformWin.cmake:
696         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
697         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
698         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
699         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
700         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
701         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
702         * TestWebKitAPI/config.h:
703
704 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
705
706         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
707         https://bugs.webkit.org/show_bug.cgi?id=181950
708         <rdar://problem/43357371>
709
710         Reviewed by Brent Fulgham.
711
712         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
713         (TestWebKitAPI::TEST_F):
714
715 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
716
717         Remove webkitpy and bindings EWS queues from dashboard
718         https://bugs.webkit.org/show_bug.cgi?id=197475
719
720         Reviewed by Alexey Proskuryakov.
721
722         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
723
724 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
725
726         Remove webkitpy and bindings test queues from old EWS
727         https://bugs.webkit.org/show_bug.cgi?id=197468
728
729         Reviewed by Alexey Proskuryakov.
730
731         * QueueStatusServer/config/queues.py:
732
733 2019-04-30  Tim Horton  <timothy_horton@apple.com>
734
735         Fix the WebKitTestRunner build
736         https://bugs.webkit.org/show_bug.cgi?id=197449
737         <rdar://problem/50334169>
738
739         Reviewed by Alexey Proskuryakov.
740
741         * WebKitTestRunner/mac/EventSenderProxy.mm:
742         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
743         (WTR::EventSenderProxy::mouseForceChanged):
744         Use some SPI instead of IPI.
745
746 2019-04-30  Chris Dumez  <cdumez@apple.com>
747
748         Regression(PSON) URL scheme handlers can no longer respond asynchronously
749         https://bugs.webkit.org/show_bug.cgi?id=197426
750         <rdar://problem/50256169>
751
752         Reviewed by Brady Eidson.
753
754         Add API test coverage.
755
756         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
757         (-[PSONScheme setShouldRespondAsynchronously:]):
758         (-[PSONScheme webView:startURLSchemeTask:]):
759         (-[PSONScheme webView:stopURLSchemeTask:]):
760
761 2019-04-30  Chris Dumez  <cdumez@apple.com>
762
763         Unreviewed, rolling out r244802.
764
765         Caused an API test failure
766
767         Reverted changeset:
768
769         "Regression(PSON) URL scheme handlers can no longer respond
770         asynchronously"
771         https://bugs.webkit.org/show_bug.cgi?id=197426
772         https://trac.webkit.org/changeset/244802
773
774 2019-04-30  Chris Dumez  <cdumez@apple.com>
775
776         Regression(PSON) URL scheme handlers can no longer respond asynchronously
777         https://bugs.webkit.org/show_bug.cgi?id=197426
778         <rdar://problem/50256169>
779
780         Reviewed by Brady Eidson.
781
782         Add API test coverage.
783
784         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
785         (-[PSONScheme setShouldRespondAsynchronously:]):
786         (-[PSONScheme webView:startURLSchemeTask:]):
787         (-[PSONScheme webView:stopURLSchemeTask:]):
788
789 2019-04-30  Chris Dumez  <cdumez@apple.com>
790
791         Only use a related page's process if that page has not been closed yet
792         https://bugs.webkit.org/show_bug.cgi?id=197393
793         <rdar://problem/50302423>
794
795         Reviewed by Tim Horton.
796
797         Add API test coverage.
798
799         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
800
801 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
802
803         [ews-build] Enable Bindings tests queue on new EWS
804         https://bugs.webkit.org/show_bug.cgi?id=197424
805
806         Reviewed by Lucas Forschler.
807
808         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
809         (StatusBubble):
810         * BuildSlaveSupport/ews-build/config.json:
811
812 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
813
814         [ews-build] Configure ews151 for running various tests
815         https://bugs.webkit.org/show_bug.cgi?id=197419
816
817         Reviewed by Lucas Forschler.
818
819         * BuildSlaveSupport/ews-build/config.json:
820
821 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
822
823         [ews-build] Parse and display bindings test failures
824         https://bugs.webkit.org/show_bug.cgi?id=197423
825
826         Reviewed by Lucas Forschler.
827
828         * BuildSlaveSupport/ews-build/steps.py:
829         (RunBindingsTests.__init__): Set timeout of 5 minutes.
830         (RunBindingsTests.start): Initialize log_observer for json output.
831         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
832         (RunBindingsTests._addToLog): Method to add message to log.
833         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
834
835 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
836
837         Unreviewed. Add myself as a committer.
838
839         * Scripts/webkitpy/common/config/contributors.json:
840
841 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
842
843         [ews-build] Enable webkitpy queue on new EWS
844         https://bugs.webkit.org/show_bug.cgi?id=197396
845
846         Reviewed by Lucas Forschler.
847
848         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
849         (StatusBubble):
850         * BuildSlaveSupport/ews-build/config.json:
851
852 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
853
854         [ews-build] Parse and display webkitpy failures
855         https://bugs.webkit.org/show_bug.cgi?id=197395
856
857         Reviewed by Lucas Forschler.
858
859         * BuildSlaveSupport/ews-build/steps.py:
860         (RunWebKitPyTests.start): Initialize log_observer for json output.
861         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
862         (RunWebKitPyTests._addToLog): Method to add message to log.
863         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
864
865 2019-04-29  Alex Christensen  <achristensen@webkit.org>
866
867         <rdar://problem/50299396> Fix internal High Sierra build
868         https://bugs.webkit.org/show_bug.cgi?id=197388
869
870         * DumpRenderTree/mac/Configurations/Base.xcconfig:
871         * MiniBrowser/Configurations/Base.xcconfig:
872         * MobileMiniBrowser/Configurations/Base.xcconfig:
873         * TestWebKitAPI/Configurations/Base.xcconfig:
874         * WebKitTestRunner/Configurations/Base.xcconfig:
875
876 2019-04-29  Youenn Fablet  <youenn@apple.com>
877
878         Remove spurious GVA printf logging
879         https://bugs.webkit.org/show_bug.cgi?id=197368
880         <rdar://problem/35975256>
881
882         Reviewed by Alexey Proskuryakov.
883
884         * Scripts/webkitpy/port/mac.py:
885         (MacPort.logging_patterns_to_strip):
886
887 2019-04-29  Youenn Fablet  <youenn@apple.com>
888
889         getDisplayMedia should be called on user gesture
890         https://bugs.webkit.org/show_bug.cgi?id=197356
891         <rdar://problem/50296074>
892
893         Reviewed by Eric Carlson.
894
895         Update test configuration to inject internals
896         so that we can use it to simulate a user click to call getDisplayMedia.
897
898         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
899         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
900         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
901
902 2019-04-26  Stephanie Lewis  <slewis@apple.com>
903
904         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
905         https://bugs.webkit.org/show_bug.cgi?id=197339
906
907         Reviewed by Dewei Zhu.
908
909         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
910         test run for setup steps that are too expensive to do every iteration.
911
912         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
913         (BenchmarkRunner._run_benchmark):
914         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
915         (BrowserDriver):
916         (BrowserDriver.prepare_initial_env):
917         (BrowserDriver.restore_env_after_all_testing):
918         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
919         (LinuxBrowserDriver.prepare_initial_env):
920         (LinuxBrowserDriver.restore_env_after_all_testing):
921         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
922         (OSXBrowserDriver.prepare_initial_env):
923         (OSXBrowserDriver.restore_env_after_all_testing):
924
925 2019-04-28  Andy Estes  <aestes@apple.com>
926
927         Fix the watchOS engineering build.
928
929         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
930         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
931
932 2019-04-27  Chris Dumez  <cdumez@apple.com>
933
934         [WKTR] Move test timeout handling to the UIProcess
935         https://bugs.webkit.org/show_bug.cgi?id=197333
936
937         Reviewed by Darin Adler.
938
939         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
940         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
941         every WebContent process in the case of swapping.
942
943         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
944         would lead to crashes when firing the timer.
945
946         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
947         (WTR::InjectedBundle::didReceiveMessageToPage):
948         (WTR::InjectedBundle::done):
949         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
950         (WTR::InjectedBundle::shouldDumpPixels const):
951         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
952         (WTR::TestRunner::TestRunner):
953         (WTR::TestRunner::waitUntilDone):
954         (WTR::TestRunner::setWaitUntilDone):
955         * WebKitTestRunner/InjectedBundle/TestRunner.h:
956         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
957         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
958         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
959         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
960         * WebKitTestRunner/TestInvocation.cpp:
961         (WTR::TestInvocation::TestInvocation):
962         (WTR::TestInvocation::createTestSettingsDictionary):
963         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
964         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
965         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
966         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
967         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
968         (WTR::TestInvocation::setWaitUntilDone):
969         (WTR::TestInvocation::done):
970         * WebKitTestRunner/TestInvocation.h:
971
972 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
973
974         [JSC] linkPolymorphicCall now does GC
975         https://bugs.webkit.org/show_bug.cgi?id=197306
976
977         Reviewed by Saam Barati.
978
979         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
980         To add this test, we add `runWithoutBaseOption`.
981
982         * Scripts/run-jsc-stress-tests:
983
984 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
985
986         Update inactive reviewers' status to 'contributor'.
987
988         Accidentally skipped one at first.
989
990         * Scripts/webkitpy/common/config/contributors.json:
991
992 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
993
994         Update inactive reviewers' status to 'contributor'.
995
996         * Scripts/webkitpy/common/config/contributors.json: The change.
997
998         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
999         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1000         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1001         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1002         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1003         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1004         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1005         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1006         Sadly, regression tests operate on a crazy mix of mock and live data for
1007         contributors.json. It would be a substantial project to mock all code paths,
1008         so changing the tests instead.
1009
1010 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
1011
1012         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1013         https://bugs.webkit.org/show_bug.cgi?id=197171
1014         <rdar://problem/47454979>
1015
1016         Reviewed by Youenn Fablet.
1017
1018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1019         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1020         (TestWebKitAPI::TEST):
1021
1022 2019-04-26  David Kilzer  <ddkilzer@apple.com>
1023
1024         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
1025         <https://webkit.org/b/197314>
1026         <rdar://problem/50245252>
1027
1028         Reviewed by Simon Fraser.
1029
1030         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1031         (WTR::UIScriptController::lastUndoLabel const):
1032         (WTR::UIScriptController::firstRedoLabel const):
1033         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1034
1035         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1036         (-[HIDEventGenerator sendEventStream:completionBlock:]):
1037         - Call -autorelease to fix leak of NSDictionary.
1038
1039         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1040         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
1041         (WTR::UIScriptController::selectFormPopoverTitle const):
1042         (WTR::UIScriptController::textContentType const):
1043         (WTR::UIScriptController::formInputLabel const):
1044         (WTR::UIScriptController::scrollingTreeAsText const):
1045         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1046
1047 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
1048
1049         webkitpy: Running a single test will always use the default device
1050         https://bugs.webkit.org/show_bug.cgi?id=195472
1051         <rdar://problem/48724825>
1052
1053         Reviewed by Lucas Forschler.
1054
1055         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
1056         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
1057         requested will be run regardless of what shard they are in.
1058
1059         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1060         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
1061         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1062         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
1063         on the default device type.
1064         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1065         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
1066         (RunTest.test_run_part): Ditto.
1067
1068 2019-04-26  Alex Christensen  <achristensen@webkit.org>
1069
1070         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
1071         https://bugs.webkit.org/show_bug.cgi?id=197165
1072
1073         Reviewed by Youenn Fablet.
1074
1075         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1076
1077 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1078
1079         Replace iOS build queue hardware
1080         https://bugs.webkit.org/show_bug.cgi?id=197312
1081
1082         Reviewed by Aakash Jain.
1083
1084         * BuildSlaveSupport/build.webkit.org-config/config.json:
1085         Use newer hardware that supports macOS Mojave.
1086
1087 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
1088
1089         check-webkit-style complains the first block in while loop.
1090         https://bugs.webkit.org/show_bug.cgi?id=197307
1091
1092         The style checker shouldn't complain about an open brace on
1093         its own line if the last non-whitespace character on the previous
1094         non-blank line is another open brace, because it's likely to
1095         indicate the begining of a nested code block.
1096
1097         Reviewed by Alex Christensen.
1098
1099         * Scripts/webkitpy/style/checkers/cpp.py:
1100         (check_braces):
1101         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1102         (WebKitStyleTest.test_braces):
1103
1104 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
1105
1106         Stop IDB transactions to release locked database files when network process is ready to suspend
1107         https://bugs.webkit.org/show_bug.cgi?id=196372
1108         <rdar://problem/48930116>
1109
1110         Reviewed by Brady Eidson.
1111
1112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1113         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
1114         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
1115         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
1116         (runTestAndCheckResult):
1117         (keepNetworkProcessActive):
1118         (TEST):
1119
1120 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1121
1122         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
1123         https://bugs.webkit.org/show_bug.cgi?id=188357
1124         <rdar://problem/42986633>
1125
1126         Reviewed by Dean Jackson.
1127
1128         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
1129         tests would fall into low memory mode and have different behavior.
1130         
1131         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
1132         to Internals, so it's shared by DRT and WTR.
1133         
1134         We no longer need the WK2 C SPI glue.
1135
1136         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1137         (WTR::InjectedBundlePage::prepare):
1138
1139 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
1140
1141         webkitpy: Including skipped tests in the final count
1142         https://bugs.webkit.org/show_bug.cgi?id=197298
1143         <rdar://problem/49705424>
1144
1145         Reviewed by Lucas Forschler.
1146
1147         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1148         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
1149
1150 2019-04-25  Timothy Hatcher  <timothy@apple.com>
1151
1152         Disable date and time inputs on iOSMac.
1153         https://bugs.webkit.org/show_bug.cgi?id=197287
1154         rdar://problem/46794376
1155
1156         Reviewed by Wenson Hsieh.
1157
1158         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1159
1160 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1161
1162         Fix test-webkitpy after r244653
1163         https://bugs.webkit.org/show_bug.cgi?id=197131
1164
1165         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1166         Also use C++17.
1167
1168 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
1169
1170         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
1171         https://bugs.webkit.org/show_bug.cgi?id=196991
1172         <rdar://problem/45507423>
1173
1174         Reviewed by Alex Christensen.
1175
1176         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1177         (-[NavigationTestDelegate init]):
1178         (-[NavigationTestDelegate waitForDidFinishNavigation]):
1179         (-[NavigationTestDelegate webView:didFinishNavigation:]):
1180         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1181         (TestWebKitAPI::TEST):
1182         (TEST): Deleted.
1183
1184 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1185
1186         Revert some code accidentally committed with r244653
1187         https://bugs.webkit.org/show_bug.cgi?id=197131
1188
1189         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1190         (TestWebKitAPI::TEST):
1191
1192 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1193
1194         Start using C++17
1195         https://bugs.webkit.org/show_bug.cgi?id=197131
1196
1197         Reviewed by Darin Adler.
1198
1199         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1200         * MiniBrowser/Configurations/Base.xcconfig:
1201         * MobileMiniBrowser/Configurations/Base.xcconfig:
1202         * TestWebKitAPI/Configurations/Base.xcconfig:
1203         * WebKitTestRunner/Configurations/Base.xcconfig:
1204
1205 2019-04-25  Commit Queue  <commit-queue@webkit.org>
1206
1207         Unreviewed, rolling out r244627.
1208         https://bugs.webkit.org/show_bug.cgi?id=197282
1209
1210         Causing internal build failures (Requested by ShawnRoberts on
1211         #webkit).
1212
1213         Reverted changeset:
1214
1215         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1216         https://bugs.webkit.org/show_bug.cgi?id=197171
1217         https://trac.webkit.org/changeset/244627
1218
1219 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1220
1221         [GTK] Hardcoded text color in input fields
1222         https://bugs.webkit.org/show_bug.cgi?id=126907
1223
1224         Reviewed by Michael Catanzaro.
1225
1226         Add dark-mode command line option to MiniBrowser.
1227
1228         * MiniBrowser/gtk/main.c:
1229         (main):
1230
1231 2019-04-24  Zalan Bujtas  <zalan@apple.com>
1232
1233         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1234         https://bugs.webkit.org/show_bug.cgi?id=196948
1235         <rdar://problem/49927131>
1236
1237         Reviewed by Tim Horton.
1238
1239         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1240         (TEST):
1241         The expected order of incoming events is
1242         1. didInvalidateIntrinsicContentSize
1243         2. didFirstLayout
1244         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1245         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1246         (and remember, all we care about is ordering).
1247
1248 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
1249
1250         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1251         https://bugs.webkit.org/show_bug.cgi?id=197171
1252         <rdar://problem/47454979>
1253
1254         Reviewed by Youenn Fablet.
1255
1256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1257         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1258         (TestWebKitAPI::TEST):
1259
1260 2019-04-24  Brady Eidson  <beidson@apple.com>
1261
1262         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
1263         https://bugs.webkit.org/show_bug.cgi?id=191362
1264
1265         Reviewed by Alex Christensen.
1266
1267         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
1268           from an XHR to a custom protocol.
1269
1270 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1271
1272         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
1273         https://bugs.webkit.org/show_bug.cgi?id=197273
1274
1275         Reviewed by Dean Jackson.
1276
1277         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
1278         so that WebCoreTestSupport::resetInternalsObject() is always run.
1279
1280         * DumpRenderTree/mac/DumpRenderTree.mm:
1281         (resetWebViewToConsistentStateBeforeTesting):
1282         (runTest):
1283
1284 2019-04-24  John Wilander  <wilander@apple.com>
1285
1286         Age out unconverted Ad Click Attributions after one week.
1287         https://bugs.webkit.org/show_bug.cgi?id=197238
1288         <rdar://problem/50177349>
1289
1290         Reviewed by Chris Dumez.
1291
1292         This patch adds infrastructure to allow tests to expire all unconverted
1293         attributions early.
1294
1295         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1296         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1297         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
1298         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1299         * WebKitTestRunner/TestController.cpp:
1300         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
1301         * WebKitTestRunner/TestController.h:
1302         * WebKitTestRunner/TestInvocation.cpp:
1303         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1304
1305 2019-04-24  Chris Dumez  <cdumez@apple.com>
1306
1307         Fix flaky crashes in a couple of PSON API tests
1308         https://bugs.webkit.org/show_bug.cgi?id=197239
1309
1310         Reviewed by Tim Horton.
1311
1312         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
1313
1314         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1315
1316 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
1317
1318         Make it possible to control the renderTreeAsText output by setting options on testRunner
1319         https://bugs.webkit.org/show_bug.cgi?id=197133
1320
1321         Reviewed by Sam Weinig.
1322
1323         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
1324         that make sense in testing (those that don't dump unstable data like addresses), and plumb
1325         these flags through the various framework layers.
1326
1327         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
1328
1329         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
1330         and hand-code DumpRenderTree bindings.
1331
1332         Some cleanup of the TestRunners, using member initializers.
1333
1334         * DumpRenderTree/TestRunner.cpp:
1335         (TestRunner::TestRunner):
1336         (setRenderTreeDumpOptionsCallback):
1337         (TestRunner::staticFunctions):
1338         (TestRunner::setRenderTreeDumpOptions):
1339         * DumpRenderTree/TestRunner.h:
1340         (TestRunner::renderTreeDumpOptions const):
1341         * DumpRenderTree/mac/DumpRenderTree.mm:
1342         (dump):
1343         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1344         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1345         (WTR::InjectedBundlePage::dump):
1346         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1347         (WTR::TestRunner::TestRunner):
1348         (WTR::TestRunner::setRenderTreeDumpOptions):
1349         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1350         (WTR::TestRunner::renderTreeDumpOptions const):
1351
1352 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1353
1354         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
1355         https://bugs.webkit.org/show_bug.cgi?id=197078
1356         <rdar://problem/49564348>
1357
1358         Reviewed by Geoff Garen.
1359
1360         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1361         (TEST_F):
1362         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
1363         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
1364         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
1365
1366 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1367
1368         Add unit test for r239322
1369         https://bugs.webkit.org/show_bug.cgi?id=197236
1370
1371         Reviewed by Chris Dumez.
1372
1373         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
1374         May as well add the test infrastructure which was needed before and will be needed in the future.
1375
1376         * TestWebKitAPI/TCPServer.cpp:
1377         (TestWebKitAPI::TCPServer::TCPServer):
1378         * TestWebKitAPI/TCPServer.h:
1379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1380         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1381         (TestWebKitAPI::TEST):
1382         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1383         (TestWebKitAPI::downloadAtRate):
1384         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1385         (TEST):
1386         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
1387         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1388         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1389         (TestWebKitAPI::TEST):
1390         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1391         (TEST):
1392
1393 2019-04-24  Chris Dumez  <cdumez@apple.com>
1394
1395         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
1396         https://bugs.webkit.org/show_bug.cgi?id=197214
1397         <rdar://problem/49237544>
1398
1399         Reviewed by Alex Christensen.
1400
1401         Extend API test coverage.
1402
1403         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1404         (TEST):
1405
1406 2019-04-24  Philippe Normand  <pnormand@igalia.com>
1407
1408         [Build][GStreamer] Update to 1.16.0
1409         https://bugs.webkit.org/show_bug.cgi?id=197157
1410
1411         Reviewed by Xabier Rodriguez-Calvar.
1412
1413         The upstreamed patches were removed and a new one was added for a
1414         regression detected in the scaletempo GStreamer element. The GNOME
1415         Flatpak was migrated to 3.32 and I switched a few modules to Meson
1416         on the way, as it is the preferred build system now in GStreamer
1417         1.16.
1418
1419         * flatpak/files/httpd-autogen.sh:
1420         * flatpak/flatpakutils.py:
1421         (FlatpakPackage.install):
1422         (WebkitFlatpak.run_in_sandbox):
1423         * flatpak/org.webkit.CommonModules.yaml:
1424         * flatpak/org.webkit.WebKit.yaml:
1425         * gstreamer/jhbuild.modules:
1426         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
1427         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
1428         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
1429         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
1430         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
1431         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
1432         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
1433         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
1434         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
1435         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1436         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
1437         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1438         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
1439         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
1440         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
1441         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
1442         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
1443         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
1444         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
1445         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
1446         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
1447         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
1448
1449 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1450
1451         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
1452         https://bugs.webkit.org/show_bug.cgi?id=197156
1453
1454         Reviewed by Michael Catanzaro.
1455
1456         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
1457         support was added.
1458
1459         * MiniBrowser/gtk/BrowserTab.c:
1460         (browser_tab_set_background_color): Set the passed in color as web view background color.
1461         * MiniBrowser/gtk/BrowserTab.h:
1462         * MiniBrowser/gtk/BrowserWindow.c:
1463         (browser_window_init): Initialize backgroundColor.
1464         (browser_window_append_view): Call browser_tab_set_background_color().
1465         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
1466         are added.
1467         * MiniBrowser/gtk/main.c:
1468         (main): Call browser_window_set_background_color() before creating the tabs.
1469
1470 2019-04-23  John Wilander  <wilander@apple.com>
1471
1472         Move Ad Click Attribution from internal feature to experimental feature
1473         https://bugs.webkit.org/show_bug.cgi?id=197218
1474         <rdar://problem/47651691>
1475
1476         Reviewed by Brent Fulgham.
1477
1478         * DumpRenderTree/TestOptions.cpp:
1479         (TestOptions::TestOptions):
1480
1481 2019-04-23  Andy Estes  <aestes@apple.com>
1482
1483         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1484         https://bugs.webkit.org/show_bug.cgi?id=196749
1485         <rdar://problem/35773454>
1486
1487         Reviewed by Daniel Bates.
1488
1489         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1490
1491         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1492         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1493         (-[QuickLookDelegate webView:didFinishNavigation:]):
1494         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1495         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1496         (runTest):
1497         (runTestDecideBeforeLoading):
1498         (runTestDecideAfterLoading):
1499         (TEST):
1500
1501 2019-04-23  John Wilander  <wilander@apple.com>
1502
1503         Remove Ad Click Attribution data when removing website data
1504         https://bugs.webkit.org/show_bug.cgi?id=197215
1505         <rdar://problem/47668988>
1506
1507         Reviewed by Chris Dumez.
1508
1509         This patch adds test infrastructure to delete Ad Click Attribution data
1510         through WebsiteDataStore::removeData().
1511
1512         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1513         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1514         (WTR::TestRunner::clearAdClickAttribution):
1515         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1516         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1517         * WebKitTestRunner/TestController.cpp:
1518         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1519         * WebKitTestRunner/TestController.h:
1520         * WebKitTestRunner/TestInvocation.cpp:
1521         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1522
1523 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1524
1525         webkitpy: Kill unresponsive worker processes
1526         https://bugs.webkit.org/show_bug.cgi?id=197205
1527         <rdar://problem/50104388>
1528
1529         Reviewed by Lucas Forschler.
1530
1531         * Scripts/webkitpy/common/message_pool.py:
1532         (_MessagePool.__init__): Add close timeout.
1533         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1534
1535 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1536
1537         Add unit tests for WKWebView.serverTrust
1538         https://bugs.webkit.org/show_bug.cgi?id=197202
1539
1540         Reviewed by Youenn Fablet
1541
1542         * TestWebKitAPI/TCPServer.cpp:
1543         (TestWebKitAPI::deleter<BIO>::operator()):
1544         (TestWebKitAPI::deleter<SSL>::operator()):
1545         (TestWebKitAPI::deleter<X509>::operator()):
1546         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1547         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1548         (TestWebKitAPI::TCPServer::TCPServer):
1549         (TestWebKitAPI::TCPServer::listenForConnections):
1550         * TestWebKitAPI/TCPServer.h:
1551         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1552         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1553         (TestWebKitAPI::TEST):
1554         (verifyCertificateAndPublicKey):
1555         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1556         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1557         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1558         (TestWebKitAPI::downloadAtRate):
1559         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1560         (TEST):
1561         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1562         (TEST):
1563
1564 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1565
1566         Unreviewed, rolling out r244556.
1567         https://bugs.webkit.org/show_bug.cgi?id=197212
1568
1569         Causing build failures on multiple builders (Requested by
1570         ShawnRoberts on #webkit).
1571
1572         Reverted changeset:
1573
1574         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1575         https://bugs.webkit.org/show_bug.cgi?id=197171
1576         https://trac.webkit.org/changeset/244556
1577
1578 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1579
1580         Fix iOS build.
1581         https://bugs.webkit.org/show_bug.cgi?id=195537
1582
1583         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1584         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1585         AdoptWK constructor is private now.  Use adoptWK instead.
1586
1587 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
1588
1589         Accessibility text search and selection API enhancements.
1590         https://bugs.webkit.org/show_bug.cgi?id=197095
1591         <rdar://problem/48181791>
1592
1593         Reviewed by Chris Fleizach.
1594
1595         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
1596
1597         * DumpRenderTree/AccessibilityTextMarker.h:
1598         * DumpRenderTree/AccessibilityUIElement.cpp:
1599         (searchTextWithCriteriaCallback):
1600         (AccessibilityUIElement::getJSClass):
1601         * DumpRenderTree/AccessibilityUIElement.h:
1602         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1603         (convertVectorToObjectArray):
1604         (convertNSArrayToVector):
1605         (searchTextParameterizedAttributeForCriteria):
1606         (AccessibilityUIElement::getLinkedUIElements):
1607         (AccessibilityUIElement::getDocumentLinks):
1608         (AccessibilityUIElement::getChildren):
1609         (AccessibilityUIElement::getChildrenWithRange):
1610         (AccessibilityUIElement::rowHeaders const):
1611         (AccessibilityUIElement::columnHeaders const):
1612         (AccessibilityUIElement::uiElementArrayAttributeValue const):
1613         (AccessibilityUIElement::searchTextWithCriteria):
1614         (AccessibilityUIElement::attributesOfColumnHeaders):
1615         (AccessibilityUIElement::attributesOfRowHeaders):
1616         (AccessibilityUIElement::attributesOfColumns):
1617         (AccessibilityUIElement::attributesOfRows):
1618         (AccessibilityUIElement::attributesOfVisibleCells):
1619         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1620         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1621         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1622         (WTR::convertVectorToObjectArray):
1623         (WTR::convertNSArrayToVector):
1624         (WTR::searchTextParameterizedAttributeForCriteria):
1625         (WTR::AccessibilityUIElement::getLinkedUIElements):
1626         (WTR::AccessibilityUIElement::getDocumentLinks):
1627         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1628         (WTR::AccessibilityUIElement::getChildren):
1629         (WTR::AccessibilityUIElement::getChildrenWithRange):
1630         (WTR::AccessibilityUIElement::rowHeaders const):
1631         (WTR::AccessibilityUIElement::columnHeaders const):
1632         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1633         (WTR::AccessibilityUIElement::searchTextWithCriteria):
1634         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1635         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1636         (WTR::AccessibilityUIElement::attributesOfColumns):
1637         (WTR::AccessibilityUIElement::attributesOfRows):
1638         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1639         (WTR::convertElementsToObjectArray): Deleted.
1640
1641 2019-04-23  Guy Lewin  <guy@lewin.co.il>
1642
1643         Multiple File Input Icon Set Regardless of File List
1644         https://bugs.webkit.org/show_bug.cgi?id=195537
1645
1646         Reviewed by Alexey Proskuryakov.
1647
1648         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
1649         display string in iOS file inputs
1650
1651         * DumpRenderTree/TestRunner.cpp:
1652         (SetOpenPanelFilesMediaIconCallback):
1653         (TestRunner::staticFunctions):
1654         (TestRunner::setOpenPanelFilesMediaIcon):
1655         * DumpRenderTree/TestRunner.h:
1656         (TestRunner::openPanelFilesMediaIcon const):
1657         * DumpRenderTree/mac/UIDelegate.mm:
1658         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1659         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1660         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1661         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1662         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1663         * WebKitTestRunner/TestController.cpp:
1664         (WTR::runOpenPanel):
1665         (WTR::TestController::resetStateToConsistentValues):
1666         * WebKitTestRunner/TestController.h:
1667         (WTR::TestController::openPanelFileURLsMediaIcon const):
1668         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
1669         * WebKitTestRunner/TestInvocation.cpp:
1670         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1671
1672 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
1673
1674         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1675         https://bugs.webkit.org/show_bug.cgi?id=197171
1676         <rdar://problem/47454979>
1677
1678         Reviewed by Youenn Fablet.
1679
1680         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1681         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1682         (TestWebKitAPI::TEST):
1683
1684 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1685
1686         [ews-build] Add unit tests for UnApplyPatchIfRequired
1687         https://bugs.webkit.org/show_bug.cgi?id=197197
1688
1689         Reviewed by Lucas Forschler.
1690
1691         * BuildSlaveSupport/ews-build/steps_unittest.py:
1692         (TestUnApplyPatchIfRequired):
1693         (TestUnApplyPatchIfRequired.test_success):
1694         (TestUnApplyPatchIfRequired.test_failure):
1695         (TestUnApplyPatchIfRequired.test_skip):
1696
1697 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1698
1699         [ews-build] Add unit tests for CleanWorkingDirectory
1700         https://bugs.webkit.org/show_bug.cgi?id=197195
1701
1702         Reviewed by Lucas Forschler.
1703
1704         * BuildSlaveSupport/ews-build/steps_unittest.py:
1705         (TestCleanWorkingDirectory):
1706         (TestCleanWorkingDirectory.test_success):
1707         (TestCleanWorkingDirectory.test_failure):
1708
1709 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1710
1711         [ews-build] Use explicit imports instead of wildcard imports
1712         https://bugs.webkit.org/show_bug.cgi?id=197194
1713
1714         Reviewed by Lucas Forschler.
1715
1716         * BuildSlaveSupport/ews-build/factories.py:
1717         * BuildSlaveSupport/ews-build/loadConfig.py:
1718         * BuildSlaveSupport/ews-build/steps_unittest.py:
1719
1720 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1721
1722         [ews-build] Add unit tests for DownloadBuiltProduct
1723         https://bugs.webkit.org/show_bug.cgi?id=197193
1724
1725         Reviewed by Lucas Forschler.
1726
1727         * BuildSlaveSupport/ews-build/steps_unittest.py:
1728         (TestDownloadBuiltProduct):
1729         (TestDownloadBuiltProduct.setUp):
1730         (TestDownloadBuiltProduct.tearDown):
1731         (TestDownloadBuiltProduct.test_success):
1732         (TestDownloadBuiltProduct.test_failure):
1733
1734 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1735
1736         [ews-app] Exception while loading status-bubble when no build step has started
1737         https://bugs.webkit.org/show_bug.cgi?id=196676
1738
1739         Reviewed by Lucas Forschler.
1740
1741         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1742         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1743
1744 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1745
1746         [PlayStation] Support running of JSC tests on remote playstation devices
1747         https://bugs.webkit.org/show_bug.cgi?id=197170
1748
1749         Reviewed by Ross Kirsling.
1750
1751         Script changes
1752
1753         * Scripts/run-javascriptcore-tests:
1754         (runJSCStressTests): Pass arguments for playstation to
1755         run-jsc-stress-tests
1756         * Scripts/run-jsc-stress-tests:
1757         Handle $hostOS=="playstation" for determineArchitecture, turning
1758         off $isFTLPlatform and runProfiler and defaulting test writer.
1759         * Scripts/webkitdirs.pm:
1760         (jscPath): PlayStation WebKit executables have .elf extension
1761         (executableProductDir): PlayStation builds on Windows hosts but
1762         uses bin directory rather than bin64/bin32 for executable output
1763         location.
1764         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1765
1766 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1767
1768         [CMake][Win] Use target oriented design for WebKit
1769         https://bugs.webkit.org/show_bug.cgi?id=197173
1770
1771         Reviewed by Alex Christensen.
1772
1773         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1774         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1775
1776 2019-04-23  Chris Dumez  <cdumez@apple.com>
1777
1778         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1779         https://bugs.webkit.org/show_bug.cgi?id=197097
1780         <rdar://problem/50048318>
1781
1782         Reviewed by Alex Christensen.
1783
1784         Add API test coverage.
1785
1786         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1787         (-[PSONScheme webView:startURLSchemeTask:]):
1788
1789 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1790
1791         [ATK] Implement AtkComponentIface scroll_to methods
1792         https://bugs.webkit.org/show_bug.cgi?id=196856
1793
1794         Reviewed by Michael Catanzaro.
1795
1796         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1797         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1798         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1799         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1800
1801 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1802
1803         [ews-build] Improve summary for UploadBuiltProduct step
1804         https://bugs.webkit.org/show_bug.cgi?id=197182
1805
1806         Reviewed by Lucas Forschler.
1807
1808         * BuildSlaveSupport/ews-build/steps.py:
1809         (UploadBuiltProduct): Added descriptionDone.
1810         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1811         * BuildSlaveSupport/ews-build/steps_unittest.py:
1812         (TestUploadBuiltProduct.test_success): Updated unit-test.
1813         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1814
1815 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1816
1817         [ews-build] Trigger queues only after uploading the archive
1818         https://bugs.webkit.org/show_bug.cgi?id=197180
1819
1820         Reviewed by Lucas Forschler.
1821
1822         * BuildSlaveSupport/ews-build/factories.py:
1823         (Factory.__init__):
1824         (BuildFactory.__init__): Remove trigger step from factories.
1825         (BuildFactory.propertiesToPassToTriggers): Deleted.
1826         * BuildSlaveSupport/ews-build/steps.py:
1827         (ConfigureBuild.__init__): Confiure triggers property.
1828         (Trigger): Step to trigger other queues.
1829         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1830         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1831
1832 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1833
1834         Deprecate WKContextCreateWithInjectedBundlePath
1835         https://bugs.webkit.org/show_bug.cgi?id=197169
1836
1837         Reviewed by Youenn Fablet.
1838
1839         * TestWebKitAPI/PlatformUtilities.cpp:
1840         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1841         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1842
1843 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1844
1845         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1846         https://bugs.webkit.org/show_bug.cgi?id=197093
1847         <rdar://problem/49708268>
1848
1849         Reviewed by Chris Dumez.
1850
1851         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1852         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1853         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1854         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1855         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1856
1857         * TestWebKitAPI/TCPServer.cpp:
1858         (TestWebKitAPI::TCPServer::TCPServer):
1859         (TestWebKitAPI::TCPServer::~TCPServer):
1860         (TestWebKitAPI::TCPServer::socketBindListen):
1861         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1862         * TestWebKitAPI/TCPServer.h:
1863         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1864         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1865         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1866         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1867         (respondWithChallengeThenOK):
1868         (TestWebKitAPI::TEST):
1869         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1870         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1871         (TEST):
1872
1873 2019-04-22  Chris Dumez  <cdumez@apple.com>
1874
1875         Delayed WebProcessLaunch may break the _relatedWebView SPI
1876         https://bugs.webkit.org/show_bug.cgi?id=197160
1877
1878         Reviewed by Alex Christensen.
1879
1880         Add API test coverage.
1881
1882         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1883
1884 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1885
1886         Use curl to download packages for webkitpy autoinstaller
1887         https://bugs.webkit.org/show_bug.cgi?id=197164
1888
1889         Reviewed by Darin Adler.
1890
1891         * Scripts/webkitpy/common/system/autoinstall.py:
1892         (AutoInstaller._download): Use curl(1) to download packages necessary for
1893         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1894         errors which are not present when using curl(1).
1895
1896 2019-04-22  Chris Dumez  <cdumez@apple.com>
1897
1898         Unreviewed, rolling out r244502.
1899
1900         Caused crashes on the bots
1901
1902         Reverted changeset:
1903
1904         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1905         https://bugs.webkit.org/show_bug.cgi?id=197160
1906         https://trac.webkit.org/changeset/244502
1907
1908 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1909
1910         Unreviewed, rolling out r244437.
1911
1912         Still breaks internal tests.
1913
1914         Reverted changeset:
1915
1916         "InjectedBundle parameters often need initialization function
1917         called before unarchiving"
1918         https://bugs.webkit.org/show_bug.cgi?id=189709
1919         https://trac.webkit.org/changeset/244437
1920
1921 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1922
1923         [ews-build] Use singular verb in failure description in case of single api test failure
1924         https://bugs.webkit.org/show_bug.cgi?id=197013
1925
1926         Reviewed by Lucas Forschler.
1927
1928         * BuildSlaveSupport/ews-build/steps.py:
1929         (AnalyzeAPITestsResults.analyzeResults):
1930
1931 2019-04-22  Chris Dumez  <cdumez@apple.com>
1932
1933         Delayed WebProcessLaunch may break the _relatedWebView SPI
1934         https://bugs.webkit.org/show_bug.cgi?id=197160
1935
1936         Reviewed by Alex Christensen.
1937
1938         Add API test coverage.
1939
1940         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1941
1942 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1943
1944         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1945         https://bugs.webkit.org/show_bug.cgi?id=194630
1946
1947         Reviewed by Michael Catanzaro.
1948
1949         Return early from getAttributeSet() is passed in accessible is nullptr.
1950
1951         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1952
1953 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1954
1955         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1956         https://bugs.webkit.org/show_bug.cgi?id=197145
1957         <rdar://problem/50078170>
1958
1959         Reviewed by Darin Adler.
1960
1961         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1962         focus, or showing the font manager.
1963
1964         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1965         (TestWebKitAPI::TEST):
1966         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1967         (TEST):
1968         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1969         (TestWebKitAPI::TEST):
1970
1971 2019-04-21  Brian Burg  <bburg@apple.com>
1972
1973         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1974         https://bugs.webkit.org/show_bug.cgi?id=197125
1975         <rdar://problem/50061468>
1976
1977         Reviewed by Darin Adler.
1978
1979         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1980         using this class rather than making our own ./wpt serve invocation.
1981
1982         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1983         (WebDriverW3CWebServer):
1984         (WebDriverW3CWebServer.document_root): Expose this to clients.
1985         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1986
1987         (WebDriverW3CWebServer.__enter__):
1988         (WebDriverW3CWebServer.__exit__):
1989         Make it possible to use the web server with a 'with' statement.
1990
1991 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1992
1993         [CMake][Win] Use target oriented design for WebKitLegacy
1994         https://bugs.webkit.org/show_bug.cgi?id=197112
1995
1996         Reviewed by Konstantin Tokarev.
1997
1998         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1999
2000         * DumpRenderTree/CMakeLists.txt:
2001         * DumpRenderTree/PlatformWin.cmake:
2002         * DumpRenderTree/win/EventSender.cpp:
2003
2004 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2005
2006         Update text for old EWS submit button
2007         https://bugs.webkit.org/show_bug.cgi?id=197140
2008
2009         Reviewed by Alexey Proskuryakov.
2010
2011         * QueueStatusServer/templates/statusbubble.html:
2012
2013 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2014
2015         [ews-app] New EWS should poll bugzilla more frequently
2016         https://bugs.webkit.org/show_bug.cgi?id=197138
2017
2018         Reviewed by Alexey Proskuryakov.
2019
2020         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2021         (FetchLoop.__init__):
2022
2023 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2024
2025         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
2026         https://bugs.webkit.org/show_bug.cgi?id=197139
2027
2028         Reviewed by Alexey Proskuryakov.
2029
2030         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2031         * QueueStatusServer/templates/statusbubble.html:
2032
2033 2019-04-20  Chris Dumez  <cdumez@apple.com>
2034
2035         Unreviewed, fix iOS build with recent SDKs.
2036
2037         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2038
2039 2019-04-19  Keith Miller  <keith_miller@apple.com>
2040
2041         Add script to merge run_benchmark jsons
2042         https://bugs.webkit.org/show_bug.cgi?id=197107
2043
2044         Reviewed by Michael Saboff.
2045
2046         The script basically recursively decends through all json objects until it gets
2047         to an array or JSON primitive and concats or takes the first value, respectively.
2048
2049         This patch also adds +x bits to the compare-results script so it
2050         can be run directly from the command line. I had to add a new line so that svn
2051         will accept the change... yay svn!
2052
2053         * Scripts/compare-results:
2054         * Scripts/merge-result-jsons: Added.
2055         (readJSONFile):
2056         (deepAppend):
2057         (mergeJSONs):
2058         (main):
2059
2060 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
2061
2062         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
2063         https://bugs.webkit.org/show_bug.cgi?id=197079
2064
2065         Reviewed by Darin Adler.
2066
2067         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
2068
2069         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2070         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
2071
2072 2019-04-18  Commit Queue  <commit-queue@webkit.org>
2073
2074         Unreviewed, rolling out r244434.
2075         https://bugs.webkit.org/show_bug.cgi?id=197089
2076
2077         caused 1 API test failure (Requested by zalan on #webkit).
2078
2079         Reverted changeset:
2080
2081         "Regression (r244291): Broken API Test
2082         AutoLayoutRenderingProgressRelativeOrdering"
2083         https://bugs.webkit.org/show_bug.cgi?id=196948
2084         https://trac.webkit.org/changeset/244434
2085
2086 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2087
2088         Add new compatibility mode API on WKNavigation
2089         https://bugs.webkit.org/show_bug.cgi?id=197069
2090         <rdar://problem/50025800>
2091
2092         Reviewed by Tim Horton.
2093
2094         Add a block property for -didCommitNavigation to TestNavigationDelegate.
2095
2096         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2097         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2098         (-[TestNavigationDelegate webView:didCommitNavigation:]):
2099
2100 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
2101
2102         [CMake] Make WebCore headers copies
2103         https://bugs.webkit.org/show_bug.cgi?id=182512
2104         <rdar://problem/37510435>
2105
2106         Reviewed by Alex Christensen.
2107
2108         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
2109         ports.
2110
2111         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
2112         of WebCore headers using "*.h" were modified to <WebCore/*.h>
2113
2114         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2115         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
2116         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
2117         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
2118         * TestWebKitAPI/CMakeLists.txt:
2119         * TestWebKitAPI/PlatformWin.cmake:
2120         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2121         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
2122         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2123
2124 2019-04-18  Jer Noble  <jer.noble@apple.com>
2125
2126         Add support for parsing FairPlayStreaming PSSH boxes.
2127         https://bugs.webkit.org/show_bug.cgi?id=197064
2128
2129         Reviewed by Eric Carlson.
2130
2131         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2132         (TestWebKitAPI::TEST):
2133
2134 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
2135
2136         InjectedBundle parameters often need initialization function called before unarchiving
2137         https://bugs.webkit.org/show_bug.cgi?id=189709
2138         <rdar://problem/44573653>
2139
2140         Reviewed by Ryosuke Niwa.
2141
2142         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2143         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2144
2145 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2146
2147         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2148         https://bugs.webkit.org/show_bug.cgi?id=196948
2149         <rdar://problem/49927131>
2150
2151         Reviewed by Tim Horton.
2152
2153         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2154         (TEST): 
2155         The expected order of incoming events is
2156         1. didInvalidateIntrinsicContentSize
2157         2. didFirstLayout
2158         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2159         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2160         (and remember, all we care about is ordering).
2161
2162 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
2163
2164         Unreviewed, rolling out r244299.
2165
2166         Breaks internal tests.
2167
2168         Reverted changeset:
2169
2170         "InjectedBundle parameters often need initialization function
2171         called before unarchiving"
2172         https://bugs.webkit.org/show_bug.cgi?id=189709
2173         https://trac.webkit.org/changeset/244299
2174
2175 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2176
2177         [WTF] StringBuilder should set correct m_is8Bit flag when merging
2178         https://bugs.webkit.org/show_bug.cgi?id=197053
2179
2180         Reviewed by Saam Barati.
2181
2182         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2183         (TestWebKitAPI::TEST):
2184
2185 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2186
2187         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
2188         https://bugs.webkit.org/show_bug.cgi?id=197028
2189         <rdar://problem/49985290>
2190
2191         Reviewed by Wenson Hsieh.
2192
2193         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2194         (TEST):
2195         Liberal application of waitForNextPresentationUpdate works around a race
2196         where if the page rapidly changes its viewport arguments (or an API client
2197         rapidly changes its viewport arguments), we'd get stuck thinking that the
2198         user had intentionally zoomed the page, and stop resetting the initial scale.
2199         This deserves a separate bug, but no need to keep the test failing while
2200         we think about it.
2201
2202 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2203
2204         REGRESSION (r241988): Switching tabs is slow
2205         https://bugs.webkit.org/show_bug.cgi?id=197037
2206         <rdar://problem/49951473>
2207
2208         Reviewed by Simon Fraser.
2209
2210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2211         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
2212         (TEST):
2213         * TestWebKitAPI/cocoa/TestWKWebView.h:
2214         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2215         (-[TestWKWebView addToTestWindow]):
2216         Add a test that hangs without this fix.
2217
2218 2019-04-17  Truitt Savell  <tsavell@apple.com>
2219
2220         Unreviewed, rolling out r244400.
2221
2222         Caused testing to exit early with assertionon Debug WK2
2223
2224         Reverted changeset:
2225
2226         "UI↔Web deadlock when printing with a JavaScript alert
2227         visible"
2228         https://bugs.webkit.org/show_bug.cgi?id=196839
2229         https://trac.webkit.org/changeset/244400
2230
2231 2019-04-17  Brady Eidson  <beidson@apple.com>
2232
2233         Link clicks in PDFs shouldn't send referrer headers.
2234         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
2235
2236         Reviewed by Tim Horton.
2237
2238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2239         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
2240         (putPDFBytesCallback):
2241         (emptyReleaseInfoCallback):
2242         (createPDFWithLinkToURL):
2243         (TEST):
2244
2245 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2246
2247         UI↔Web deadlock when printing with a JavaScript alert visible
2248         https://bugs.webkit.org/show_bug.cgi?id=196839
2249         <rdar://problem/49157642>
2250
2251         Reviewed by Andy Estes.
2252
2253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2254         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
2255         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2256         (TEST):
2257
2258 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2259
2260         WKRetainPtr's adoption constructor should be private
2261         https://bugs.webkit.org/show_bug.cgi?id=197019
2262
2263         Reviewed by Tim Horton.
2264
2265         * DumpRenderTree/mac/DumpRenderTree.mm:
2266         (dumpFramesAsText):
2267         * TestWebKitAPI/InjectedBundleController.cpp:
2268         (TestWebKitAPI::InjectedBundleController::initialize):
2269         * TestWebKitAPI/PlatformUtilities.cpp:
2270         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2271         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
2272         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2273         (TestWebKitAPI::Util::toWK):
2274         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2275         (TestWebKitAPI::TEST):
2276         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2277         (TestWebKitAPI::TEST):
2278         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2279         (TestWebKitAPI::TEST):
2280         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2281         (TestWebKitAPI::TEST):
2282         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2283         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2284         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
2285         (TestWebKitAPI::TEST):
2286         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
2287         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2288         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2289         (TestWebKitAPI::TEST):
2290         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
2291         (TestWebKitAPI::TEST):
2292         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2293         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2294         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
2295         (TestWebKitAPI::TEST):
2296         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2297         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2298         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2299         (TestWebKitAPI::TEST):
2300         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2301         (TestWebKitAPI::TEST):
2302         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2303         (TestWebKitAPI::TEST):
2304         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2305         (TestWebKitAPI::TEST):
2306         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2307         (TestWebKitAPI::TEST):
2308         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2309         (TestWebKitAPI::TEST):
2310         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2311         (TestWebKitAPI::TEST):
2312         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
2313         (TestWebKitAPI::TEST):
2314         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2315         (TestWebKitAPI::TEST):
2316         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2317         (TestWebKitAPI::TEST):
2318         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2319         (TestWebKitAPI::TEST):
2320         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2321         (TestWebKitAPI::TEST):
2322         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2323         (TestWebKitAPI::TEST):
2324         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
2325         (TestWebKitAPI::TEST):
2326         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
2327         (TestWebKitAPI::TEST):
2328         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
2329         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2330         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
2331         (TestWebKitAPI::TEST):
2332         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
2333         (TestWebKitAPI::TEST):
2334         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
2335         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
2336         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
2337         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
2338         (TestWebKitAPI::TEST):
2339         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
2340         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
2341         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
2342         (TestWebKitAPI::TEST):
2343         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
2344         (TestWebKitAPI::TEST):
2345         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2346         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2347         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2348         (TestWebKitAPI::TEST):
2349         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2350         (TestWebKitAPI::loadAlternateHTMLString):
2351         (TestWebKitAPI::TEST):
2352         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
2353         (TestWebKitAPI::TEST):
2354         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2355         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2356         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2357         (TestWebKitAPI::buildAndPerformTest):
2358         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2359         (TestWebKitAPI::TEST):
2360         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
2361         (TestWebKitAPI::TEST):
2362         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
2363         (TestWebKitAPI::TEST):
2364         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2365         (TestWebKitAPI::TEST):
2366         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2367         (TestWebKitAPI::TEST):
2368         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2369         (TestWebKitAPI::TEST):
2370         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2371         (TestWebKitAPI::TEST):
2372         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2373         (TestWebKitAPI::TEST):
2374         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
2375         (TestWebKitAPI::TEST):
2376         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2377         (TestWebKitAPI::TEST):
2378         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2379         (TestWebKitAPI::TEST):
2380         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2381         (TestWebKitAPI::TEST):
2382         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2383         (TestWebKitAPI::TEST):
2384         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2385         (TestWebKitAPI::TEST):
2386         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2387         (TestWebKitAPI::TEST):
2388         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2389         (TestWebKitAPI::TEST):
2390         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2391         (TestWebKitAPI::TEST):
2392         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2393         (TestWebKitAPI::TEST):
2394         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2395         (TestWebKitAPI::TEST):
2396         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2397         (TestWebKitAPI::TEST):
2398         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
2399         (TestWebKitAPI::TEST):
2400         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
2401         (TestWebKitAPI::TEST):
2402         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2403         (TestWebKitAPI::TEST):
2404         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2405         (TestWebKitAPI::TEST):
2406         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2407         (TestWebKitAPI::TEST):
2408         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2409         (TestWebKitAPI::TEST):
2410         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2411         (TestWebKitAPI::TEST):
2412         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2413         (TestWebKitAPI::TEST):
2414         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2415         (TestWebKitAPI::TEST):
2416         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2417         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2418         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
2419         (TestWebKitAPI::TEST):
2420         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2421         (TestWebKitAPI::TEST):
2422         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
2423         (TestWebKitAPI::TEST):
2424         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
2425         (TestWebKitAPI::TEST):
2426         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2427         (TestWebKitAPI::TEST):
2428         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2429         (TestWebKitAPI::TEST):
2430         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
2431         (TestWebKitAPI::TEST):
2432         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2433         (TestWebKitAPI::TEST):
2434         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2435         (TestWebKitAPI::TEST):
2436         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2437         (TestWebKitAPI::TEST):
2438         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2439         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
2440         (TEST):
2441         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2442         (TEST):
2443         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2444         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2445         (TEST):
2446         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
2447         (TestWebKitAPI::TEST):
2448         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2449         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2450         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2451         (WTR::getMenuItemTitleCallback):
2452         (WTR::createMouseMessageBody):
2453         (WTR::EventSendingController::mouseDown):
2454         (WTR::EventSendingController::mouseUp):
2455         (WTR::EventSendingController::mouseMoveTo):
2456         (WTR::EventSendingController::mouseForceClick):
2457         (WTR::EventSendingController::startAndCancelMouseForceClick):
2458         (WTR::EventSendingController::mouseForceDown):
2459         (WTR::EventSendingController::mouseForceUp):
2460         (WTR::EventSendingController::mouseForceChanged):
2461         (WTR::EventSendingController::leapForward):
2462         (WTR::EventSendingController::scheduleAsynchronousClick):
2463         (WTR::createKeyDownMessageBody):
2464         (WTR::EventSendingController::keyDown):
2465         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2466         (WTR::EventSendingController::mouseScrollBy):
2467         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2468         (WTR::EventSendingController::continuousMouseScrollBy):
2469         (WTR::EventSendingController::addTouchPoint):
2470         (WTR::EventSendingController::updateTouchPoint):
2471         (WTR::EventSendingController::setTouchModifier):
2472         (WTR::EventSendingController::setTouchPointRadius):
2473         (WTR::EventSendingController::touchStart):
2474         (WTR::EventSendingController::touchMove):
2475         (WTR::EventSendingController::touchEnd):
2476         (WTR::EventSendingController::touchCancel):
2477         (WTR::EventSendingController::clearTouchPoints):
2478         (WTR::EventSendingController::releaseTouchPoint):
2479         (WTR::EventSendingController::cancelTouchPoint):
2480         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2481         (WTR::InjectedBundle::didCreatePage):
2482         (WTR::InjectedBundle::didReceiveMessage):
2483         (WTR::InjectedBundle::didReceiveMessageToPage):
2484         (WTR::InjectedBundle::booleanForKey):
2485         (WTR::InjectedBundle::done):
2486         (WTR::InjectedBundle::dumpToStdErr):
2487         (WTR::InjectedBundle::outputText):
2488         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2489         (WTR::InjectedBundle::postAddChromeInputField):
2490         (WTR::InjectedBundle::postRemoveChromeInputField):
2491         (WTR::InjectedBundle::postFocusWebView):
2492         (WTR::InjectedBundle::postSetBackingScaleFactor):
2493         (WTR::InjectedBundle::postSetWindowIsKey):
2494         (WTR::InjectedBundle::postSetViewSize):
2495         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2496         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2497         (WTR::InjectedBundle::setGeolocationPermission):
2498         (WTR::InjectedBundle::setMockGeolocationPosition):
2499         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2500         (WTR::InjectedBundle::isGeolocationProviderActive const):
2501         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2502         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2503         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2504         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2505         (WTR::InjectedBundle::setCustomPolicyDelegate):
2506         (WTR::InjectedBundle::setHidden):
2507         (WTR::InjectedBundle::setCacheModel):
2508         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2509         (WTR::InjectedBundle::processWorkQueue):
2510         (WTR::InjectedBundle::queueBackNavigation):
2511         (WTR::InjectedBundle::queueForwardNavigation):
2512         (WTR::InjectedBundle::queueLoad):
2513         (WTR::InjectedBundle::queueLoadHTMLString):
2514         (WTR::InjectedBundle::queueReload):
2515         (WTR::InjectedBundle::queueLoadingScript):
2516         (WTR::InjectedBundle::queueNonLoadingScript):
2517         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2518         (WTR::frameToStr):
2519         (WTR::InjectedBundlePage::InjectedBundlePage):
2520         (WTR::dumpFrameDescriptionSuitableForTestResult):
2521         (WTR::dumpFrameScrollPosition):
2522         (WTR::dumpDescendantFrameScrollPositions):
2523         (WTR::dumpFrameText):
2524         (WTR::dumpDescendantFramesText):
2525         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2526         (WTR::TestRunner::shouldDumpPixels const):
2527         (WTR::TestRunner::setDumpPixels):
2528         (WTR::TestRunner::whatToDump const):
2529         (WTR::TestRunner::setWhatToDump):
2530         (WTR::TestRunner::setWaitUntilDone):
2531         (WTR::TestRunner::shouldWaitUntilDone const):
2532         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2533         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2534         (WTR::TestRunner::clearAllDatabases):
2535         (WTR::TestRunner::setIDBPerOriginQuota):
2536         (WTR::TestRunner::originsWithApplicationCache):
2537         (WTR::TestRunner::setCanOpenWindows):
2538         (WTR::TestRunner::setXSSAuditorEnabled):
2539         (WTR::TestRunner::setMediaDevicesEnabled):
2540         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2541         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2542         (WTR::TestRunner::setCustomUserAgent):
2543         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2544         (WTR::TestRunner::setModernMediaControlsEnabled):
2545         (WTR::TestRunner::setWebGL2Enabled):
2546         (WTR::TestRunner::setWritableStreamAPIEnabled):
2547         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2548         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2549         (WTR::TestRunner::setAllowsAnySSLCertificate):
2550         (WTR::TestRunner::setPluginsEnabled):
2551         (WTR::TestRunner::setValueForUser):
2552         (WTR::TestRunner::setAudioResult):
2553         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2554         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2555         (WTR::TestRunner::setAlwaysAcceptCookies):
2556         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2557         (WTR::TestRunner::isDoingMediaCapture const):
2558         (WTR::TestRunner::queueLoad):
2559         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2560         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2561         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2562         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2563         (WTR::TestRunner::setAuthenticationUsername):
2564         (WTR::TestRunner::setAuthenticationPassword):
2565         (WTR::TestRunner::secureEventInputIsEnabled const):
2566         (WTR::TestRunner::setBlockAllPlugins):
2567         (WTR::TestRunner::setPluginSupportedMode):
2568         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2569         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2570         (WTR::TestRunner::setNavigationGesturesEnabled):
2571         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2572         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2573         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2574         (WTR::TestRunner::terminateNetworkProcess):
2575         (WTR::TestRunner::terminateServiceWorkerProcess):
2576         (WTR::TestRunner::runUIScript):
2577         (WTR::TestRunner::setStatisticsDebugMode):
2578         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2579         (WTR::TestRunner::setStatisticsLastSeen):
2580         (WTR::TestRunner::setStatisticsPrevalentResource):
2581         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2582         (WTR::TestRunner::dumpResourceLoadStatistics):
2583         (WTR::TestRunner::isStatisticsPrevalentResource):
2584         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
2585         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
2586         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
2587         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
2588         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2589         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2590         (WTR::TestRunner::setStatisticsGrandfathered):
2591         (WTR::TestRunner::isStatisticsGrandfathered):
2592         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2593         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2594         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2595         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
2596         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
2597         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
2598         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2599         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
2600         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2601         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2602         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2603         (WTR::TestRunner::statisticsSubmitTelemetry):
2604         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2605         (WTR::TestRunner::setStatisticsIsRunningTest):
2606         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2607         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2608         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2609         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2610         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2611         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2612         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2613         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2614         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2615         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2616         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
2617         (WTR::TestRunner::statisticsResetToConsistentState):
2618         (WTR::TestRunner::setStorageAccessAPIEnabled):
2619         (WTR::TestRunner::getAllStorageAccessEntries):
2620         (WTR::TestRunner::addMockMediaDevice):
2621         (WTR::TestRunner::clearMockMediaDevices):
2622         (WTR::TestRunner::removeMockMediaDevice):
2623         (WTR::TestRunner::resetMockMediaDevices):
2624         (WTR::TestRunner::connectMockGamepad):
2625         (WTR::TestRunner::disconnectMockGamepad):
2626         (WTR::TestRunner::setMockGamepadDetails):
2627         (WTR::TestRunner::setMockGamepadAxisValue):
2628         (WTR::TestRunner::setMockGamepadButtonValue):
2629         (WTR::TestRunner::removeAllSessionCredentials):
2630         (WTR::TestRunner::clearDOMCache):
2631         (WTR::TestRunner::clearDOMCaches):
2632         (WTR::TestRunner::hasDOMCache):
2633         (WTR::TestRunner::domCacheSize):
2634         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2635         (WTR::TestRunner::getApplicationManifestThen):
2636         (WTR::TestRunner::injectUserScript):
2637         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
2638         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2639         (WTR::TestRunner::addTestKeyToKeychain):
2640         (WTR::TestRunner::cleanUpKeychain):
2641         (WTR::TestRunner::keyExistsInKeychain):
2642         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2643         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2644         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2645         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2646         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2647         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2648         * WebKitTestRunner/TestController.cpp:
2649         (WTR::TestController::initialize):
2650         (WTR::parseStringTestHeaderValueAsRelativePath):
2651         (WTR::updateTestOptionsFromTestHeader):
2652         (WTR::TestController::runTest):
2653         (WTR::TestController::didReceiveLiveDocumentsList):
2654         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2655         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2656         (WTR::TestController::didFinishNavigation):
2657         (WTR::TestController::didReceiveAuthenticationChallenge):
2658         * WebKitTestRunner/TestInvocation.cpp:
2659         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2660         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2661         (WTR::TestInvocation::uiScriptDidComplete):
2662         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
2663         * WebKitTestRunner/WebNotificationProvider.cpp:
2664         (WTR::WebNotificationProvider::closeWebNotification):
2665         * WebKitTestRunner/WorkQueueManager.cpp:
2666         (WTR::ScriptItem::ScriptItem):
2667         (WTR::WorkQueueManager::queueLoad):
2668         (WTR::WorkQueueManager::queueLoadHTMLString):
2669
2670 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2671
2672         Add a comment to make my test from r244139 less mysterious.
2673         https://bugs.webkit.org/show_bug.cgi?id=196744
2674
2675         As suggested by Darin Adler.
2676
2677         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2678         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2679
2680 2019-04-17  Chris Dumez  <cdumez@apple.com>
2681
2682         Remember device orientation permission for the duration of the browsing session
2683         https://bugs.webkit.org/show_bug.cgi?id=196992
2684         <rdar://problem/49946067>
2685
2686         Reviewed by Alex Christensen.
2687
2688         Add API test coverage.
2689
2690         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2691         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2692         (TEST):
2693
2694 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
2695
2696         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
2697         https://bugs.webkit.org/show_bug.cgi?id=196675
2698
2699         Reviewed by Lucas Forschler.
2700
2701         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2702         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
2703
2704 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2705
2706         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
2707         https://bugs.webkit.org/show_bug.cgi?id=196919
2708         <rdar://problem/41630459>
2709
2710         Reviewed by Tim Horton.
2711
2712         Add iOS support for several new testing hooks. See below for more detail.
2713
2714         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2715         (WTR::UIScriptController::isDismissingMenu const):
2716
2717         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
2718         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
2719         by UIKit when dismissing the callout bar (i.e. UIMenuController).
2720
2721         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2722         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2723         (WTR::UIScriptController::isDismissingMenu const):
2724         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2725         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2726         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2727         (WTR::InjectedBundle::didReceiveMessageToPage):
2728         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2729         (WTR::TestRunner::setAllowedMenuActions):
2730
2731         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2732         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2733         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2734         against the name of the custom action.
2735
2736         (WTR::TestRunner::installCustomMenuAction):
2737
2738         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2739         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2740         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2741         triggered.
2742
2743         (WTR::TestRunner::performCustomMenuAction):
2744
2745         Invoked when the custom menu action is triggered.
2746
2747         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2748         * WebKitTestRunner/TestController.cpp:
2749         (WTR::TestController::installCustomMenuAction):
2750         (WTR::TestController::setAllowedMenuActions):
2751         * WebKitTestRunner/TestController.h:
2752         * WebKitTestRunner/TestInvocation.cpp:
2753         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2754         (WTR::TestInvocation::performCustomMenuAction):
2755
2756         Add plumbing to call back into the injected bundle when performing the custom action.
2757
2758         * WebKitTestRunner/TestInvocation.h:
2759         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2760         (WTR::TestController::installCustomMenuAction):
2761         (WTR::TestController::setAllowedMenuActions):
2762         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2763         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2764         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2765         (-[TestRunnerWKWebView becomeFirstResponder]):
2766         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2767
2768         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2769         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2770         in the Mail app on iOS.
2771
2772         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2773         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2774         (-[TestRunnerWKWebView resetCustomMenuAction]):
2775         (-[TestRunnerWKWebView performCustomAction:]):
2776         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2777         (-[TestRunnerWKWebView _willHideMenu]):
2778         (-[TestRunnerWKWebView _didHideMenu]):
2779         * WebKitTestRunner/ios/TestControllerIOS.mm:
2780         (WTR::TestController::platformResetStateToConsistentValues):
2781
2782         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2783         if specified.
2784
2785         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2786         (WTR::UIScriptController::isDismissingMenu const):
2787
2788 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2789
2790         Allow sharing from imageSheet on an image document
2791         https://bugs.webkit.org/show_bug.cgi?id=196891
2792         <rdar://problem/25377386>
2793
2794         Reviewed by Tim Horton.
2795
2796         Test to make sure that the correct imageURL is extracted from an image element.
2797
2798         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2799         (TestWebKitAPI::TEST):
2800
2801 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2802
2803         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2804         https://bugs.webkit.org/show_bug.cgi?id=196995
2805
2806         Reviewed by Brady Eidson.
2807
2808         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2809         (TEST):
2810
2811 2019-04-16  Chris Dumez  <cdumez@apple.com>
2812
2813         URL set by document.open() is not communicated to the UIProcess
2814         https://bugs.webkit.org/show_bug.cgi?id=196941
2815         <rdar://problem/49237544>
2816
2817         Reviewed by Geoff Garen.
2818
2819         Add API test coverage.
2820
2821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2822         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2823         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2824         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2825         (TEST):
2826
2827 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2828
2829         Unreviewed, rolling out r244321.
2830         https://bugs.webkit.org/show_bug.cgi?id=196968
2831
2832         Causing all WK2 Debug builds to exit early after Assertion
2833         failures. (Requested by ShawnRoberts on #webkit).
2834
2835         Reverted changeset:
2836
2837         "URL set by document.open() is not communicated to the
2838         UIProcess"
2839         https://bugs.webkit.org/show_bug.cgi?id=196941
2840         https://trac.webkit.org/changeset/244321
2841
2842 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2843
2844         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2845         https://bugs.webkit.org/show_bug.cgi?id=196948
2846
2847         Reviewed by Zalan Bujtas.
2848
2849         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2850         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2851
2852 2019-04-15  Chris Dumez  <cdumez@apple.com>
2853
2854         URL set by document.open() is not communicated to the UIProcess
2855         https://bugs.webkit.org/show_bug.cgi?id=196941
2856         <rdar://problem/49237544>
2857
2858         Reviewed by Geoffrey Garen.
2859
2860         Add API test coverage.
2861
2862         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2863         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2864         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2865         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2866         (TEST):
2867
2868 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2869
2870         Using Tools/Scripts/clean-webkit should not install requests
2871         https://bugs.webkit.org/show_bug.cgi?id=196940
2872
2873         Reviewed by Lucas Forschler.
2874
2875         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2876         existing, depending on the path autoinstalled is run through.
2877         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2878         needed.
2879         (Port.configuration_for_upload):
2880         (Port.commits_for_upload):
2881
2882 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2883
2884         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2885         https://bugs.webkit.org/show_bug.cgi?id=196773
2886
2887         Reviewed by Jer Noble.
2888
2889         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2890         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2891         (TEST):
2892
2893 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2894
2895         ews-build should clearly indicate flaky test failures
2896         https://bugs.webkit.org/show_bug.cgi?id=196947
2897
2898         Reviewed by Lucas Forschler.
2899
2900         * BuildSlaveSupport/ews-build/steps.py:
2901         (AnalyzeAPITestsResults.analyzeResults):
2902
2903 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2904
2905         InjectedBundle parameters often need initialization function called before unarchiving
2906         https://bugs.webkit.org/show_bug.cgi?id=189709
2907         <rdar://problem/44573653>
2908
2909         Reviewed by Ryosuke Niwa.
2910
2911         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2912         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2913
2914 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2915
2916         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2917         https://bugs.webkit.org/show_bug.cgi?id=196681
2918
2919         Reviewed by Darin Adler.
2920
2921         Added tests.
2922
2923         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2924         (WTF_HashSet.RemoveIf):
2925         (WTF_HashSet.RemoveIfShrinkToBestSize):
2926
2927 2019-04-15  John Wilander  <wilander@apple.com>
2928
2929         Send delayed Ad Click Attribution conversion requests to the click source
2930         https://bugs.webkit.org/show_bug.cgi?id=196838
2931         <rdar://problem/47650157>
2932
2933         Reviewed by Chris Dumez and Youenn Fablet.
2934
2935         This patch adds test infrastructure to override the default behavior in
2936         WebKit::NetworkAdClickAttribution.
2937
2938         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2939         (TestWebKitAPI::TEST):
2940         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2941         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2942         (WTR::TestRunner::dumpAdClickAttribution):
2943         (WTR::TestRunner::clearAdClickAttribution):
2944         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2945         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2946         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2947         * WebKitTestRunner/TestController.cpp:
2948         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2949         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2950         * WebKitTestRunner/TestController.h:
2951         * WebKitTestRunner/TestInvocation.cpp:
2952         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2953
2954 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2955
2956         [ews-app] status-bubble should display position in queue
2957         https://bugs.webkit.org/show_bug.cgi?id=196607
2958
2959         Reviewed by Lucas Forschler.
2960
2961         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2962         (StatusBubble._build_bubble):
2963         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2964
2965 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2966
2967         [ews-build] Do not run clean build by default on EWS builders
2968         https://bugs.webkit.org/show_bug.cgi?id=196897
2969
2970         Reviewed by Lucas Forschler.
2971
2972         * BuildSlaveSupport/ews-build/steps.py:
2973         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2974         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2975         untracked directories like WebKitBuild).
2976         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2977         untracked files/directories (like WebKitBuild).
2978
2979 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2980
2981         TestRunner::notifyDone() should be safely reentrant
2982         https://bugs.webkit.org/show_bug.cgi?id=196898
2983
2984         Reviewed by Darin Adler.
2985
2986         It is currently possible that TestRunner::notifyDone() will call itself, since
2987         notifyDone() will force a repaint, which can start executing JavaScript, which
2988         may call notifyDone() again. This can lead to test failures and flakiness.
2989         Fix this by setting the m_waitToDump flag before calling the dump() method.
2990
2991         * DumpRenderTree/mac/TestRunnerMac.mm:
2992         (TestRunner::notifyDone):
2993         (TestRunner::forceImmediateCompletion):
2994         * DumpRenderTree/win/TestRunnerWin.cpp:
2995         (TestRunner::notifyDone):
2996         (TestRunner::forceImmediateCompletion):
2997
2998 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2999
3000         [GTK][WPE] Add enable-media websetting
3001         https://bugs.webkit.org/show_bug.cgi?id=196863
3002
3003         Reviewed by Michael Catanzaro.
3004
3005         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3006         (testWebKitSettings): Add test for the enable-media web-setting.
3007
3008 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3009
3010         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
3011         https://bugs.webkit.org/show_bug.cgi?id=196905
3012         <rdar://problem/49886096>
3013
3014         Reviewed by Tim Horton.
3015
3016         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
3017         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
3018         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
3019         delay timer, we end up with this sequence of events in the problematic (failure) case:
3020
3021         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
3022             ...IPC from UI to web process...
3023         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
3024             ...IPC from web to UI process...
3025         (c) [UI]    Invoke completion handler for script #1
3026         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
3027             ...IPC from UI to web process...
3028         (e) [Web]   Evaluate script #2 in the web process
3029         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
3030
3031         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
3032         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
3033         #2 is run in step (e).
3034
3035         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
3036         the UI process by waiting on a script message posted by the web process, after attachment updates are
3037         dispatched.
3038
3039         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3040         (TestWebKitAPI::TEST):
3041
3042 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
3043
3044         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
3045         https://bugs.webkit.org/show_bug.cgi?id=196909
3046
3047         Reviewed by Wenson Hsieh.
3048
3049         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3050         (TestWebKitAPI::TEST):
3051
3052 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
3053
3054         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
3055         https://bugs.webkit.org/show_bug.cgi?id=196880
3056
3057         Reviewed by Yusuke Suzuki.
3058
3059         Add a new function for bytecode cache tests that does not forceDiskCache
3060         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
3061         test added in this patch, since the code is invalid and therefore won't be
3062         cached. It should also be useful for tests that evaluate dynamically
3063         generated code.
3064
3065         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3066         * Scripts/run-jsc-stress-tests:
3067
3068 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
3069
3070         Update AudioSession route sharing policy
3071         https://bugs.webkit.org/show_bug.cgi?id=196776
3072         <rdar://problem/46501611>
3073
3074         Reviewed by Jer Noble.
3075
3076         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3077         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
3078         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
3079         (TestWebKitAPI::TEST):
3080
3081 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3082
3083         [iOS] Software keyboard is shown too frequently on some websites
3084         https://bugs.webkit.org/show_bug.cgi?id=195856
3085         <rdar://problem/49191395>
3086
3087         Reviewed by Darin Adler.
3088
3089         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
3090
3091         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3092         (WTR::UIScriptController::setHardwareKeyboardAttached):
3093         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3094         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3095         (WTR::UIScriptController::setHardwareKeyboardAttached):
3096         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3097         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3098
3099         Additionally link against GraphicsServices in WebKitTestRunner.
3100
3101         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3102         (WTR::TestController::platformResetStateToConsistentValues):
3103         (WTR::UIScriptController::setHardwareKeyboardAttached):
3104
3105 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
3106
3107         [GTK][WPE] Fix pacman install-dependencies packages
3108         https://bugs.webkit.org/show_bug.cgi?id=196817
3109
3110         Reviewed by Žan Doberšek.
3111         
3112         python3-setuptools is called python-setuptools
3113         ruby-highline is only available on AUR
3114         libv4l-devel is incorporated in v4l-utils
3115
3116         * gtk/install-dependencies:
3117         * wpe/install-dependencies:
3118
3119 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3120
3121         [GTK] REGRESSION(r243860): Many tests failing
3122         https://bugs.webkit.org/show_bug.cgi?id=196791
3123
3124         Reviewed by Joanmarie Diggs.
3125
3126         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
3127         multiple documents and check that accessibility hierarchy is updated after a navigation.
3128
3129         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
3130         (loadChangedCallback):
3131         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3132         (AccessibilityTest::AccessibilityTest):
3133         (AccessibilityTest::~AccessibilityTest):
3134         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
3135         (AccessibilityTest::findTestServerApplication):
3136         (AccessibilityTest::findDocumentWeb):
3137         (AccessibilityTest::findRootObject):
3138         (AccessibilityTest::waitUntilChildrenRemoved):
3139         (AccessibilityTest::ensureProxy):
3140         (testAtspiBasicHierarchy):
3141         (beforeAll):
3142         (afterAll):
3143
3144 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
3145
3146         [ews-build] Handle bug titles with unicode characters
3147         https://bugs.webkit.org/show_bug.cgi?id=196802
3148
3149         Reviewed by Dewei Zhu.
3150
3151         * BuildSlaveSupport/ews-build/steps.py:
3152         (ValidatePatch._is_bug_closed):
3153
3154 2019-04-11  Michael Saboff  <msaboff@apple.com>
3155
3156         Improve the Inline Cache Stats code
3157         https://bugs.webkit.org/show_bug.cgi?id=196836
3158
3159         Reviewed by Saam Barati.
3160
3161         Added a new script to consolidate and arrange the output of --useICStats option.
3162
3163         This script merges the output from every group into one large table and sorts it from most common to
3164         least common.  It also counts the slow path GetById and PutById variants and then calculates the
3165         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
3166         Put together, this is useful to see what property accesses are not getting cached.
3167
3168         * Scripts/ic-stats.py: Added.
3169         (ICStats):
3170         (ICStats.__init__):
3171         (ICStats.parse):
3172         (ICStats.dumpStats):
3173         (usage):
3174
3175 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3176
3177         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
3178         https://bugs.webkit.org/show_bug.cgi?id=196809
3179         <rdar://49800762>
3180
3181         Reviewed by Brady Eidson.
3182
3183         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3184         (TEST):
3185
3186 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
3187
3188         requestAnimationFrame should execute before the next frame
3189         https://bugs.webkit.org/show_bug.cgi?id=177484
3190
3191         Reviewed by Simon Fraser.
3192
3193         Add trace points for the page RenderingUpdate.
3194
3195         * Tracing/SystemTracePoints.plist:
3196
3197 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3198
3199         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
3200         https://bugs.webkit.org/show_bug.cgi?id=196760
3201
3202         Reviewed by Don Olmstead.
3203
3204         vswhere.exe has been bundled since Visual Studio 2017 version
3205         15.2. We shouldn't download vswhere.exe.
3206
3207         * Scripts/build-jsc: Do not call update-vswhere.py.
3208         * Scripts/build-webkit: Ditto.
3209         * Scripts/update-vswhere.py: Removed.
3210         * Scripts/webkitdirs.pm:
3211         (requireModulesForVSWhere): Deleted.
3212         (pickCurrentVisualStudioInstallation): Deleted.
3213         (visualStudioInstallDirVSWhere): Return the latest installed VS
3214         installation path by using the bundled vswhere.exe.
3215         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
3216         (visualStudioInstallDirFallback): Removed.
3217
3218 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
3219
3220         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
3221         https://bugs.webkit.org/show_bug.cgi?id=196780
3222
3223         Reviewed by Alexey Proskuryakov.
3224
3225         * BuildSlaveSupport/ews-build/steps.py:
3226         * BuildSlaveSupport/ews-build/steps_unittest.py:
3227
3228 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3229
3230         Add SPI WKNavigationResponse._downloadAttribute
3231         https://bugs.webkit.org/show_bug.cgi?id=196755
3232         <rdar://49587365>
3233
3234         Reviewed by Brady Eidson.
3235
3236         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3237         (-[NavigationResponseTestDelegate navigationResponse]):
3238         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
3239         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
3240         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3241         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
3242         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3243         (readRequest):
3244         (writeResponse):
3245         (TEST):
3246
3247 2019-04-10  Tim Horton  <timothy_horton@apple.com>
3248
3249         Add modern API for overriding the page's specified viewport configuration
3250         https://bugs.webkit.org/show_bug.cgi?id=167734
3251         <rdar://problem/30331795>
3252
3253         Reviewed by Simon Fraser.
3254
3255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3256         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
3257
3258 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
3259
3260         Add support for incremental bytecode cache updates
3261         https://bugs.webkit.org/show_bug.cgi?id=195000
3262
3263         Reviewed by Filip Pizlo.
3264
3265         Exit when the initial run to generate bytecode fails.
3266
3267         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3268
3269 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3270
3271         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
3272         https://bugs.webkit.org/show_bug.cgi?id=196744
3273         <rdar://49415309>
3274
3275         Reviewed by Chris Dumez.
3276
3277         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3278         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3279
3280 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3281
3282         Add a way to opt into modern compatibility mode in layout tests
3283         https://bugs.webkit.org/show_bug.cgi?id=196770
3284         <rdar://problem/49777550>
3285
3286         Reviewed by Antoine Quint.
3287
3288         Add a new test option to enable modern compatibility mode in layout tests.
3289
3290         * WebKitTestRunner/TestController.cpp:
3291         (WTR::updateTestOptionsFromTestHeader):
3292         * WebKitTestRunner/TestController.h:
3293         * WebKitTestRunner/TestOptions.h:
3294         (WTR::TestOptions::hasSameInitializationOptions const):
3295         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3296         (WTR::TestController::platformCreateWebView):
3297         (WTR::TestController::enableModernCompatibilityMode):
3298
3299 2019-04-10  Andy Estes  <aestes@apple.com>
3300
3301         Try to fix the 32-bit watchOS build.
3302
3303         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3304         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3305
3306 2019-04-10  Antoine Quint  <graouts@apple.com>
3307
3308         Enable Pointer Events on watchOS
3309         https://bugs.webkit.org/show_bug.cgi?id=196771
3310         <rdar://problem/49040909>
3311
3312         Reviewed by Dean Jackson.
3313
3314         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3315
3316 2019-04-10  Philippe Normand  <pnormand@igalia.com>
3317
3318         Unreviewed. Fix WPE accessibility tests after r244059.
3319
3320         We are failing to load the injected bundle due to undefined symbol
3321         AccessibilityUIElement::replaceTextInRange().
3322
3323         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
3324         (WTR::AccessibilityUIElement::replaceTextInRange):
3325
3326 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
3327
3328         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
3329         https://bugs.webkit.org/show_bug.cgi?id=196727
3330
3331         Reviewed by Fujii Hironori.
3332
3333         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3334         (WebKitBrowserWindow::create):
3335
3336 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
3337
3338         [ews-build] Add unit tests for PrintConfiguration
3339         https://bugs.webkit.org/show_bug.cgi?id=196752
3340
3341         Reviewed by Dewei Zhu.
3342
3343         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3344
3345 2019-04-09  Keith Rollin  <krollin@apple.com>
3346
3347         Unreviewed build maintenance -- update .xcfilelists.
3348
3349         * DumpRenderTree/DerivedSources-input.xcfilelist:
3350         * DumpRenderTree/DerivedSources-output.xcfilelist:
3351
3352 2019-04-09  Zalan Bujtas  <zalan@apple.com>
3353
3354         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
3355         https://bugs.webkit.org/show_bug.cgi?id=196743
3356         <rdar://problem/43897551>
3357
3358         Reviewed by Tim Horton.
3359
3360         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
3361         (TEST):
3362
3363 2019-04-09  Youenn Fablet  <youenn@apple.com>
3364
3365         Close service worker database on network process suspension
3366         https://bugs.webkit.org/show_bug.cgi?id=196623
3367         <rdar://problem/48930869>
3368
3369         Reviewed by Alex Christensen.
3370
3371         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3372
3373 2019-04-09  Daniel Bates  <dabates@apple.com>
3374
3375         [iPad] Should open popover when the spacebar is pressed
3376         https://bugs.webkit.org/show_bug.cgi?id=196360
3377         <rdar://problem/49389129>
3378
3379         Reviewed by Brent Fulgham.
3380
3381         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
3382
3383         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3384         (WTR::UIScriptController::isShowingPopover const): Added.
3385         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3386         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3387         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3388         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3389         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3390         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
3391         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
3392         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
3393         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
3394         (WTR::UIScriptController::isShowingPopover const): Added.
3395         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3396         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3397         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3398         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3399         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3400         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
3401         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
3402         (-[TestRunnerWKWebView _willPresentPopover]): Added.
3403         (-[TestRunnerWKWebView _didDismissPopover]): Added.
3404         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3405         (WTR::UIScriptController::isShowingPopover const): Added.
3406         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3407         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3408
3409 2019-04-09  Alex Christensen  <achristensen@webkit.org>
3410
3411         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3412         https://bugs.webkit.org/show_bug.cgi?id=196665
3413         <rdar://45115669>
3414
3415         Reviewed by Geoff Garen.
3416
3417         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3418         (goBack):
3419         (+[SimpleLookupContext sharedLookupContext]):
3420         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3421         (TEST):
3422         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3423         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3424
3425 2019-04-09  John Wilander  <wilander@apple.com>
3426
3427         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
3428         https://bugs.webkit.org/show_bug.cgi?id=196558
3429         <rdar://problem/47650245>
3430
3431         Reviewed by Youenn Fablet.
3432
3433         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3434         (TestWebKitAPI::TEST):
3435             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
3436
3437 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
3438
3439         [CMake] Apple builds should use ICU_INCLUDE_DIRS
3440         https://bugs.webkit.org/show_bug.cgi?id=196720
3441
3442         Reviewed by Konstantin Tokarev.
3443
3444         * TestWebKitAPI/PlatformMac.cmake:
3445
3446 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
3447
3448         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
3449         https://bugs.webkit.org/show_bug.cgi?id=196694
3450         <rdar://problem/48388734>
3451
3452         Rubber-stamped by Aakash Jain.
3453
3454         * Scripts/webkitpy/port/image_diff.py:
3455         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
3456         * Scripts/webkitpy/port/server_process.py:
3457         (ServerProcess.has_available_stdout): Check if stdout has data in it.
3458         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3459         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
3460         * Scripts/webkitpy/port/server_process_mock.py:
3461         (MockServerProcess.has_available_stdout):
3462         * Scripts/webkitpy/port/server_process_unittest.py:
3463         (TestServerProcess.serial_test_basic):
3464
3465 2019-04-09  Jer Noble  <jer.noble@apple.com>
3466
3467         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3468         https://bugs.webkit.org/show_bug.cgi?id=196097
3469
3470         Reviewed by Eric Carlson.
3471
3472         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3473
3474         * DumpRenderTree/mac/DumpRenderTree.mm:
3475         (resetWebPreferencesToConsistentValues):
3476         * WebKitTestRunner/TestController.cpp:
3477         (WTR::TestController::resetPreferencesToConsistentValues):
3478
3479 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
3480
3481         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
3482         https://bugs.webkit.org/show_bug.cgi?id=196690
3483
3484         Reviewed by Michael Catanzaro.
3485
3486         * QueueStatusServer/config/queues.py:
3487         * Scripts/webkitpy/common/config/ews.json:
3488         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3489         (test_ews_name):
3490
3491 2019-04-09  Chris Dumez  <cdumez@apple.com>
3492
3493         Loads using loadHTMLString() cause flashing when process-swapping
3494         https://bugs.webkit.org/show_bug.cgi?id=196714
3495         <rdar://problem/49637354>
3496
3497         Reviewed by Antti Koivisto.
3498
3499         Add API test coverage.
3500
3501         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3502
3503 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3504
3505         Unreviewed. Fix ATK accessibility tests after r244059.
3506
3507         We are failing to load the injected bundle due to undefined symbol
3508         AccessibilityUIElement::replaceTextInRange().
3509
3510         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3511         (WTR::AccessibilityUIElement::replaceTextInRange):
3512
3513 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3514
3515         AX: Support API: accessibilityReplaceRange:withText
3516         https://bugs.webkit.org/show_bug.cgi?id=196636
3517
3518         Unreviewed build fix for Windows port.
3519
3520         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3521         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
3522
3523 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
3524
3525         [CMake][WinCairo] Separate copied headers into different directories
3526         https://bugs.webkit.org/show_bug.cgi?id=196655
3527
3528         Reviewed by Michael Catanzaro.
3529
3530         * DumpRenderTree/CMakeLists.txt:
3531         * MiniBrowser/win/CMakeLists.txt:
3532         * TestWebKitAPI/CMakeLists.txt:
3533         * TestWebKitAPI/PlatformWin.cmake:
3534
3535 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
3536
3537         Log stack-trace for run-webkit-tests when interrupted
3538         https://bugs.webkit.org/show_bug.cgi?id=176393
3539         <rdar://problem/34262310>
3540
3541         Reviewed by Lucas Forschler.
3542
3543         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
3544         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
3545         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
3546         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
3547         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
3548         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3549         (main): Set handlers to log stack trace on interruption.
3550
3551 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3552
3553         AX: Support API: accessibilityReplaceRange:withText
3554         https://bugs.webkit.org/show_bug.cgi?id=196636
3555
3556         Unreviewed build fix for Windows port.
3557
3558         * DumpRenderTree/AccessibilityUIElement.cpp:
3559         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
3560
3561 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3562
3563         [ews-build] Scripts using Buildbot API have CORS error
3564         https://bugs.webkit.org/show_bug.cgi?id=196709
3565
3566         Reviewed by Alexey Proskuryakov.
3567
3568         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
3569
3570 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
3571
3572         AX: Support API: accessibilityReplaceRange:withText
3573         https://bugs.webkit.org/show_bug.cgi?id=196636
3574
3575         Reviewed by Daniel Bates.
3576
3577         * DumpRenderTree/AccessibilityUIElement.cpp:
3578         (replaceTextInRangeCallback):
3579         (AccessibilityUIElement::replaceTextInRange):
3580         (AccessibilityUIElement::getJSClass):
3581         * DumpRenderTree/AccessibilityUIElement.h:
3582         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3583         (AccessibilityUIElement::replaceTextInRange):
3584         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3585         (AccessibilityUIElement::replaceTextInRange):
3586         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3587         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3588         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3589         (WTR::AccessibilityUIElement::replaceTextInRange):
3590         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3591         (WTR::AccessibilityUIElement::replaceTextInRange):
3592
3593 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3594
3595         [iOS] Do not allow starting selection drags when selection views are not visible
3596         https://bugs.webkit.org/show_bug.cgi?id=196686
3597         <rdar://problem/49399192>
3598
3599         Reviewed by Tim Horton.
3600
3601         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
3602         also add some new API tests to cover scenarios where the web view is not first responder.
3603
3604         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3605         (TestWebKitAPI::TEST):
3606         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3607
3608         Add a switch to optionally make the web view first responder when starting the simulated drag.
3609
3610         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3611         (-[DragAndDropSimulator initWithWebView:]):
3612         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
3613
3614 2019-04-08  Justin Fan  <justin_fan@apple.com>
3615
3616         [Web GPU] Fix Web GPU experimental feature on iOS
3617         https://bugs.webkit.org/show_bug.cgi?id=196632
3618
3619         Reviewed by Myles C. Maxfield.
3620
3621         Properly make Web GPU available on iOS 11+.
3622
3623         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3624
3625 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3626
3627         [ews-build] Do not upload archive when Compile Fails
3628         https://bugs.webkit.org/show_bug.cgi?id=196674
3629
3630         Reviewed by Alexey Proskuryakov.
3631
3632         * BuildSlaveSupport/ews-build/factories.py:
3633         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
3634         * BuildSlaveSupport/ews-build/steps.py:
3635         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
3636         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
3637         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
3638
3639 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
3640
3641         Enable DFG on MIPS
3642         https://bugs.webkit.org/show_bug.cgi?id=196689
3643
3644         Reviewed by Žan Doberšek.
3645
3646         Since the bytecode change, we enabled the baseline JIT on mips in
3647         r240432, but DFG is still missing. With this change, all tests are
3648         passing on a ci20 board.
3649
3650         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
3651
3652 2019-04-08  Philippe Normand  <pnormand@igalia.com>
3653
3654         [Flatpak] Second run update-webkitwpe-flatpak fails
3655         https://bugs.webkit.org/show_bug.cgi?id=192702
3656
3657         Reviewed by Carlos Garcia Campos.
3658
3659         * flatpak/flatpakutils.py:
3660         (FlatpakObject.flatpak): Fix typo.
3661         (FlatpakPackage.install): When installing, also update to the configured remote commit.
3662         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
3663
3664 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
3665
3666         [GTK][WPE] outlook.live.com displays old-fashioned UI
3667         https://bugs.webkit.org/show_bug.cgi?id=196642
3668
3669         Reviewed by Carlos Garcia Campos.
3670
3671         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3672         (TestWebKitAPI::TEST): New Mac platform quirk test.
3673
3674 2019-04-07  Commit Queue  <commit-queue@webkit.org>
3675
3676         Unreviewed, rolling out r243956.
3677         https://bugs.webkit.org/show_bug.cgi?id=196688
3678
3679         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
3680         by aakashjain on #webkit).
3681
3682         Reverted changeset:
3683
3684         "Clicking "Go Back" from a safe browsing warning from an
3685         iframe should navigate the WKWebView back to the previous
3686         page"
3687         https://bugs.webkit.org/show_bug.cgi?id=196665
3688         https://trac.webkit.org/changeset/243956
3689
3690 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
3691
3692         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
3693         https://bugs.webkit.org/show_bug.cgi?id=196669
3694
3695         Reviewed by Geoffrey Garen.
3696
3697         Added three new unit tests for WeakHashSet.
3698
3699         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3700         (WTF_WeakPtr.WeakHashSetConstObjects):
3701         (WTF_WeakPtr.WeakHashSetComputesEmpty):
3702         (WTF_WeakPtr.WeakHashSetComputeSize):
3703
3704 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3705
3706         Hide next and previous form control buttons when WKWebView is editable
3707         https://bugs.webkit.org/show_bug.cgi?id=196672
3708         <rdar://problem/35625321>
3709
3710         Reviewed by Tim Horton.
3711
3712         Add a new API test.
3713
3714         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3715         (-[TestWKWebView lastTrailingBarButtonGroup]):
3716         (TestWebKitAPI::TEST):
3717         * TestWebKitAPI/ios/UIKitSPI.h:
3718
3719 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
3720
3721         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
3722         https://bugs.webkit.org/show_bug.cgi?id=196077
3723         <rdar://problem/49108202>
3724
3725         Reviewed by Chris Dumez.
3726
3727         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
3728         on new web view.
3729
3730         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3731
3732 2019-04-05  Saam Barati  <sbarati@apple.com>
3733
3734         Make compare-results understand MotionMark
3735         https://bugs.webkit.org/show_bug.cgi?id=196666
3736
3737         Reviewed by Yusuke Suzuki.
3738
3739         * Scripts/compare-results:
3740         (PLT5Results):
3741         (detectMotionMark):
3742         (detectMotionMark1_1):
3743         (motionMarkResults):
3744         (motionMark1_1Results):
3745         (detectBenchmark):
3746         (biggerIsBetter):
3747         (main):
3748
3749 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3750
3751         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3752         https://bugs.webkit.org/show_bug.cgi?id=196665
3753         <rdar://45115669>
3754
3755         Reviewed by Geoff Garen.
3756
3757         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3758         (goBack):
3759         (+[SimpleLookupContext sharedLookupContext]):
3760         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3761         (TEST):
3762         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3763         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3764
3765 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3766
3767         [ews-build] Add configuration and architecture for windows builders
3768         https://bugs.webkit.org/show_bug.cgi?id=196660
3769
3770         Reviewed by Lucas Forschler.
3771
3772         * BuildSlaveSupport/ews-build/config.json:
3773
3774 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3775
3776         webkitpy: Don't run subsequent rounds if interrupted
3777         https://bugs.webkit.org/show_bug.cgi?id=196646
3778
3779         Reviewed by Aakash Jain.
3780
3781         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3782         (Manager.run): Bail out if interrupted.
3783
3784 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3785
3786         Test sessionStorage in PSON private browsing mode
3787         https://bugs.webkit.org/show_bug.cgi?id=196561
3788
3789         Reviewed by Alex Christensen.
3790
3791         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3792
3793 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3794
3795         Unreviewed, rolling out r243833.
3796         https://bugs.webkit.org/show_bug.cgi?id=196645
3797
3798         This change breaks build of WPE and GTK ports (Requested by
3799         annulen on #webkit).
3800
3801         Reverted changeset:
3802
3803         "[CMake][WTF] Mirror XCode header directories"
3804         https://bugs.webkit.org/show_bug.cgi?id=191662
3805         https://trac.webkit.org/changeset/243833
3806
3807 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3808
3809         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3810         https://bugs.webkit.org/show_bug.cgi?id=196635
3811
3812         Reviewed by Antti Koivisto.
3813         
3814         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3815         for a test to enable async frame scrolling via:
3816             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3817         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3818         
3819         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3820
3821         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3822         (WTR::InjectedBundle::beginTesting):
3823         * WebKitTestRunner/TestController.cpp:
3824         (WTR::TestController::resetPreferencesToConsistentValues):
3825
3826 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3827
3828         Use a correct LC_RPATH when building with ASan
3829         https://bugs.webkit.org/show_bug.cgi?id=196576
3830
3831         Reviewed by David Kilzer.
3832
3833         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3834         so that ../Frameworks is checked. This is simpler and more reliable than updating
3835         each SPC service xcconfig.
3836
3837 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3838
3839         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3840         https://bugs.webkit.org/show_bug.cgi?id=196629
3841
3842         Reviewed by Lucas Forschler.
3843
3844         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3845
3846 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3847
3848         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3849         https://bugs.webkit.org/show_bug.cgi?id=196618
3850
3851         Reviewed by Lucas Forschler.
3852
3853         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3854         (StatusBubble): Added QUEUE_TRIGGERS.
3855         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3856         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3857         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
3858         its parent(builder).
3859
3860 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3861
3862         [ews-app] Status-bubble steps are sometimes displayed in reverse order
3863         https://bugs.webkit.org/show_bug.cgi?id=196625
3864
3865         Reviewed by Lucas Forschler.
3866
3867         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3868         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
3869
3870 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3871
3872         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
3873         https://bugs.webkit.org/show_bug.cgi?id=196630
3874
3875         Reviewed by Wenson Hsieh.
3876
3877         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3878
3879 2019-04-04  Youenn Fablet  <youenn@apple.com>
3880
3881         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
3882         https://bugs.webkit.org/show_bug.cgi?id=196543
3883
3884         Reviewed by Alex Christensen.
3885
3886         * WebKitTestRunner/TestController.cpp:
3887         (WTR::TestController::generatePageConfiguration):
3888
3889 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3890
3891         [ews-app] Status bubble should not display skipped buildbot steps
3892         https://bugs.webkit.org/show_bug.cgi?id=196584
3893
3894         Reviewed by Lucas Forschler.
3895
3896         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3897
3898 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3899
3900         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
3901         https://bugs.webkit.org/show_bug.cgi?id=196620
3902
3903         Reviewed by Lucas Forschler.
3904
3905         * BuildSlaveSupport/ews-app/ews/config.py:
3906
3907 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
3908
3909         [Win] DumpRenderTreeWatchDog.py is not checked into source
3910         https://bugs.webkit.org/show_bug.cgi?id=196567
3911         <rdar://problem/49525901>
3912
3913         Reviewed by Lucas Forschler.
3914
3915         This script is used on Win EWS bots to terminate hanging DRT processes.
3916
3917         * EWSTools/dumprendertreewatchdog.py: Added.
3918
3919 2019-04-04  Chris Dumez  <cdumez@apple.com>
3920
3921         Unreviewed, roll out r243858 which made tests time out.
3922
3923         Disable new API tests on Windows instead.
3924
3925         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3926         (TestWebKitAPI::TEST):
3927
3928 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3929
3930         [ATK] Cleanup WebPageAccessibilityObjectAtk
3931         https://bugs.webkit.org/show_bug.cgi?id=196537
3932
3933         Reviewed by Michael Catanzaro.
3934
3935         Also consider files under atk directories as exceptions for GObject conventions.
3936
3937         * Scripts/webkitpy/style/checkers/cpp.py:
3938         (check_identifier_name_in_declaration):
3939
3940 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3941
3942         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3943         https://bugs.webkit.org/show_bug.cgi?id=196588
3944         <rdar://problem/49365787>
3945
3946         Unreviewed build fix for Windows port.
3947
3948         error C3861: 'kill': identifier not found
3949
3950         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3951         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
3952
3953 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3954
3955         [ews-build] Cancel build and similar operations should have authentication
3956         https://bugs.webkit.org/show_bug.cgi?id=196520
3957
3958         Reviewed by Dewei Zhu.
3959
3960         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
3961         environment variables.
3962
3963 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3964
3965         [ews-build] Do not trigger queues which are not in production yet
3966         https://bugs.webkit.org/show_bug.cgi?id=196581
3967
3968         Reviewed by Dewei Zhu.
3969
3970         * BuildSlaveSupport/ews-build/config.json:
3971
3972 2019-04-03  Chris Dumez  <cdumez@apple.com>
3973
3974         Unreviewed, fix typo in the name of API test added in r243848.
3975
3976         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3977         (TestWebKitAPI::TEST):
3978
3979 2019-04-03  Chris Dumez  <cdumez@apple.com>
3980
3981         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3982         https://bugs.webkit.org/show_bug.cgi?id=196588
3983         <rdar://problem/49365787>
3984
3985         Reviewed by Ryosuke Niwa.
3986
3987         Add API test coverage.
3988
3989         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3990         (TestWebKitAPI::nullJavaScriptCallback):
3991         (TestWebKitAPI::didCrashCheckFrames):
3992         (TestWebKitAPI::TEST):
3993
3994 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3995
3996         run-webkit-tests: Upload test results (new results database)
3997         https://bugs.webkit.org/show_bug.cgi?id=196577
3998         <rdar://problem/34841155>
3999
4000         Reviewed by Lucas Forschler.
4001
4002         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4003         (Manager.run): Upload results after each device shard, since the configuration will be
4004         different for each device.
4005         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
4006         uploaded to a results database.
4007         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4008         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
4009
4010 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
4011
4012         -apple-trailing-word is needed for browser detection
4013         https://bugs.webkit.org/show_bug.cgi?id=196575
4014
4015         Unreviewed.
4016
4017         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4018
4019 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
4020
4021         [CMake][WTF] Mirror XCode header directories
4022         https://bugs.webkit.org/show_bug.cgi?id=191662
4023
4024         Reviewed by Konstantin Tokarev.
4025
4026         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
4027         builds.
4028
4029         * CMakeLists.txt:
4030         * DumpRenderTree/CMakeLists.txt:
4031         * DumpRenderTree/PlatformWin.cmake:
4032         * MiniBrowser/win/CMakeLists.txt:
4033         * TestWebKitAPI/CMakeLists.txt:
4034         * TestWebKitAPI/PlatformWin.cmake:
4035         * WebKitTestRunner/PlatformGTK.cmake:
4036         * WebKitTestRunner/PlatformWin.cmake:
4037
4038 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4039
4040         [ews-app] Status bubble should not display certain infrastructure status messages
4041         https://bugs.webkit.org/show_bug.cgi?id=196550
4042
4043         Reviewed by Lucas Forschler.
4044
4045         Do not display the steps which are un-needed for end-user. This information is still avaiable
4046         if the user click on the bubble and look at the Buildbot build.
4047         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4048         (StatusBubble._steps_messages):
4049         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
4050
4051 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4052
4053         [ews-build] Use https for sending data to ews-app
4054         https://bugs.webkit.org/show_bug.cgi?id=196492
4055
4056         Reviewed by Lucas Forschler.
4057
4058         * BuildSlaveSupport/ews-build/events.py:
4059
4060 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
4061
4062         Remove support for -apple-trailing-word
4063         https://bugs.webkit.org/show_bug.cgi?id=196525
4064
4065         Reviewed by Zalan Bujtas.
4066
4067         This CSS property is nonstandard and not used.
4068
4069         * Scripts/webkitperl/FeatureList.pm:
4070         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4071
4072 2019-04-03  Youenn Fablet  <youenn@apple.com>
4073
4074         Add a test for DOMCache on multiple browsing in case of private browsing
4075         https://bugs.webkit.org/show_bug.cgi?id=196524
4076
4077         Reviewed by Alex Christensen.
4078
4079         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4080         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
4081
4082 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
4083
4084         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
4085         https://bugs.webkit.org/show_bug.cgi?id=196540
4086
4087         Reviewed by Aakash Jain.
4088
4089         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
4090
4091 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
4092
4093         Add plumbing for a compatibility mode preference in WebKit
4094         https://bugs.webkit.org/show_bug.cgi?id=196005
4095
4096         Reviewed by Tim Horton.
4097
4098         Add new API tests.
4099
4100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4101         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
4102
4103 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
4104
4105         [WPE][GTK] Update libsrtp dependency package for Debian
4106         https://bugs.webkit.org/show_bug.cgi?id=196528
4107
4108         Reviewed by Frédéric Wang.
4109
4110         * gtk/install-dependencies:
4111         * wpe/install-dependencies:
4112
4113 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
4114
4115         [WK2] Add support for Window's beforeprint / afterprint events
4116         https://bugs.webkit.org/show_bug.cgi?id=196478
4117         <rdar://problem/49535124>
4118
4119         Unreviewed build fix for MSVC.
4120
4121         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
4122
4123         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
4124
4125         * WebKitTestRunner/TestController.cpp:
4126         (WTR::printFrame): Use int and float literals.
4127
4128 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
4129
4130         [ews-build] Reassign bots to queues
4131
4132         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
4133
4134 2019-04-02  Chris Dumez  <cdumez@apple.com>
4135
4136         [WK2] Add support for Window's beforeprint / afterprint events
4137         https://bugs.webkit.org/show_bug.cgi?id=196478
4138
4139         Reviewed by Alex Christensen.
4140
4141         Add minimal implementation for printFrame in WebKitTestRunner.
4142
4143         * WebKitTestRunner/TestController.cpp:
4144         (WTR::printFrame):
4145         (WTR::TestController::createOtherPage):
4146         (WTR::TestController::createWebViewWithOptions):
4147
4148 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
4149
4150         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
4151         https://bugs.webkit.org/show_bug.cgi?id=196491
4152
4153         Reviewed by Lucas Forschler.
4154
4155         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4156
4157 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
4158
4159         [ews-build] Configure buildbot try credentials in environment variables
4160         https://bugs.webkit.org/show_bug.cgi?id=196501
4161
4162         Reviewed by Lucas Forschler.
4163
4164         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
4165         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
4166         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
4167
4168 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
4169
4170         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
4171         https://bugs.webkit.org/show_bug.cgi?id=196496
4172         <rdar://problem/49521634>
4173
4174         Reviewed by Chris Dumez.
4175
4176         Add new API tests (see WebKit ChangeLog for more detail).
4177
4178         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4179         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4180         (TEST):
4181
4182 2019-04-02  David Kilzer  <ddkilzer@apple.com>
4183
4184         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
4185         <https://webkit.org/b/196499>
4186
4187         Reviewed by Alexey Proskuryakov.
4188
4189         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
4190         ENABLE_ADDRESS_SANITIZER.
4191
4192 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
4193
4194         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
4195         https://bugs.webkit.org/show_bug.cgi?id=182757
4196
4197         Reviewed by Don Olmstead.
4198
4199         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
4200         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
4201
4202 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
4203
4204         run-api-tests: Upload test results
4205         https://bugs.webkit.org/show_bug.cgi?id=196323
4206         <rdar://problem/49356714>
4207
4208         Reviewed by Lucas Forschler.
4209
4210         * Scripts/webkitpy/api_tests/manager.py:
4211         (Manager):
4212         (Manager.run): Upload results to a results database.
4213         * Scripts/webkitpy/api_tests/run_api_tests.py:
4214         (parse_args): Add upload arguments.
4215         * Scripts/webkitpy/port/base.py:
4216         (Port):
4217         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
4218         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
4219         with commits from any other associated repositories.
4220         * Scripts/webkitpy/port/device.py:
4221         (Device):
4222         (Device.build_version): Access build_versoin of underlying platform device.
4223         * Scripts/webkitpy/port/ios_simulator_unittest.py:
4224         (IOSSimulatorTest):
4225         (IOSSimulatorTest.test_configuration_for_upload):
4226         * Scripts/webkitpy/port/device_port.py:
4227         (DevicePort):
4228         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
4229         the same as the machine uploading results.
4230         * Scripts/webkitpy/port/mac.py:
4231         (MacPort):
4232         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
4233         * Scripts/webkitpy/port/mac_unittest.py:
4234         (MacTest):
4235         (MacTest.test_configuration_for_upload):
4236         * Scripts/webkitpy/xcode/simulated_device.py:
4237         (SimulatedDeviceManager._create_device_with_runtime):
4238         (SimulatedDevice.__init__): Create simulated device with a build_version.
4239         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
4240         (test_existing_simulator):
4241
4242 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
4243
4244         Remove extra newline characters (Follow-up fix to r243707)
4245
4246         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4247
4248 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
4249
4250         [ews-app] Use API_KEY to accept results data
4251         https://bugs.webkit.org/show_bug.cgi?id=196461
4252
4253         Reviewed by Dewei Zhu.
4254
4255         * BuildSlaveSupport/ews-app/ews/views/results.py:
4256         (Results.post): Validate EWS_API_KEY before accepting any data.
4257         * BuildSlaveSupport/ews-build/events.py:
4258         (Events.sendData): Send EWS_API_KEY if available along with event data.
4259
4260 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
4261
4262         Unable to copy and paste a PDF from Notes into Mail compose body
4263         https://bugs.webkit.org/show_bug.cgi?id=196442
4264         <rdar://problem/48573098>
4265
4266         Reviewed by Tim Horton.
4267
4268         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
4269         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
4270         to be specified on the item providers.
4271
4272         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4273         (TestWebKitAPI::mapItemForTesting):
4274         (TestWebKitAPI::contactItemForTesting):
4275
4276 2019-04-01  Tim Horton  <timothy_horton@apple.com>
4277
4278         Make UIWKDocumentContext rects per-character instead of per-word
4279         https://bugs.webkit.org/show_bug.cgi?id=196459
4280
4281         Reviewed by Wenson Hsieh.
4282
4283         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4284         (TEST):
4285         Adjust test results due to switching to per-character rects.
4286
4287 2019-04-01  Chris Dumez  <cdumez@apple.com>
4288
4289         UIProcess crash when a prewarmed process is terminated
4290         https://bugs.webkit.org/show_bug.cgi?id=196451
4291         <rdar://problem/49245471>
4292
4293         Reviewed by Geoffrey Garen.
4294
4295         Add API test coverage.
4296
4297         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
4298         (TEST):
4299
4300 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
4301
4302         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
4303         https://bugs.webkit.org/show_bug.cgi?id=196449
4304
4305         Reviewed by Lucas Forschler.
4306
4307         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4308         (StatusBubble.get_os_details): Method to get OS and Xcode details.
4309         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
4310         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
4311
4312 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
4313
4314         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
4315         https://bugs.webkit.org/show_bug.cgi?id=196444
4316
4317         Reviewed by Lucas Forschler.
4318
4319         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
4320
4321 2019-04-01  Alex Christensen  <achristensen@webkit.org>
4322
4323         Add SPI to canonicalize NSURLs with WTF::URL
4324         https://bugs.webkit.org/show_bug.cgi?id=196415
4325         <rdar://problem/44980271>
4326
4327         Reviewed by Darin Adler.