[WPE] Add API for webview background color configuration
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-26  Philippe Normand  <pnormand@igalia.com>
2
3         [WPE] Add API for webview background color configuration
4         https://bugs.webkit.org/show_bug.cgi?id=192305
5
6         Reviewed by Michael Catanzaro.
7
8         * MiniBrowser/wpe/main.cpp:
9         (main): Add a new option to configure the webview background
10         color. Example: --bg-color=transparent.
11         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
12         (testWebViewBackgroundColor): Enable background color API tests for WPE.
13         (beforeAll): Ditto.
14
15 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
16
17         scalableNativeWebpageParameters() is not preserved on new page navigation.
18         https://bugs.webkit.org/show_bug.cgi?id=194892
19         <rdar://problem/47538280>
20
21         Reviewed by Wenson Hsieh.
22         
23         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
24
25         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
26         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
27         * DumpRenderTree/mac/UIScriptControllerMac.mm:
28         (WTR::UIScriptController::allowsViewportShrinkToFit):
29         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
30         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
31         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
32         * TestRunnerShared/UIScriptContext/UIScriptController.h:
33         * WebKitTestRunner/UIScriptControllerCocoa.mm:
34         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
35
36 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
37
38         [ews-app] Add model for handling multiple Buildbot instances
39         https://bugs.webkit.org/show_bug.cgi?id=194863
40
41         Reviewed by Stephanie Lewis.
42
43         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
44
45 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
46
47         [ews-app] Remove BuilderMapping table
48         https://bugs.webkit.org/show_bug.cgi?id=194961
49
50         Reviewed by Stephanie Lewis.
51
52         Store builder name directly in build table, instead of having a separate
53         table for it.
54
55         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
56         * BuildSlaveSupport/ews-app/ews/models/build.py:
57         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
58         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
59
60 2019-02-25  John Wilander  <wilander@apple.com>
61
62         Introduce and adopt new class RegistrableDomain for eTLD+1
63         https://bugs.webkit.org/show_bug.cgi?id=194791
64         <rdar://problem/48179240>
65
66         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
67
68         This patch adds an API test and replaces two instances of
69         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
70
71         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
72         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
73         (TestWebKitAPI::TEST):
74             Changed two strings to make sure the registrable domains are still considered
75             invalid and pass the test.
76         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
77         (TestWebKitAPI::TEST):
78         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
79         (WTR::InjectedBundle::didReceiveMessageToPage):
80
81 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
82
83         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
84         https://bugs.webkit.org/show_bug.cgi?id=195001
85
86         Reviewed by Carlos Garcia Campos.
87
88         API version 1.0 always includes the functionality previously guarded with
89         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
90         unconditionally.
91
92         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
93         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
94         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
95         (WebViewTest::showInWindow): Ditto.
96         (WebViewTest::hideView): Ditto.
97         * wpe/backends/HeadlessViewBackend.cpp:
98         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
99         * wpe/backends/ViewBackend.cpp:
100         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
101         * wpe/backends/WindowViewBackend.cpp:
102         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
103         WPE_BACKEND_CHECK_VERSION().
104         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
105
106 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
107
108         [Flatpak] Add support for flatpak > 1.1.2
109         https://bugs.webkit.org/show_bug.cgi?id=194088
110
111         Flatpak 1.2 is now out so we need to support that
112         version now.
113
114         Reviewed by Michael Catanzaro.
115
116         * flatpak/flatpakutils.py:
117         (check_flatpak):
118         (FlatpakPackages.__init__):
119         (FlatpakPackages.__detect_packages):
120         (FlatpakPackages.__detect_packages.in):
121         (FlatpakRepos.update):
122
123 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
124
125         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
126         https://bugs.webkit.org/show_bug.cgi?id=194998
127
128         Reviewed by Carlos Garcia Campos.
129
130         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
131         to a Git checkout and using the latest commit containing various fixes
132         and improvements.
133
134 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
135
136         [WPE][GTK] Remove user agent quirk for washingtonpost.com
137         https://bugs.webkit.org/show_bug.cgi?id=194981
138
139         Reviewed by Žan Doberšek.
140
141         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
142         (TestWebKitAPI::TEST):
143
144 2019-02-23  Keith Miller  <keith_miller@apple.com>
145
146         Add new mac target numbers
147         https://bugs.webkit.org/show_bug.cgi?id=194955
148
149         Reviewed by Tim Horton.
150
151         * DumpRenderTree/mac/Configurations/Base.xcconfig:
152         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
153         * MiniBrowser/Configurations/Base.xcconfig:
154         * TestWebKitAPI/Configurations/Base.xcconfig:
155         * WebKitTestRunner/Configurations/Base.xcconfig:
156
157 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
158
159         [WinCairo] Enable wk1/wk2 suffix for platform search path.
160         https://bugs.webkit.org/show_bug.cgi?id=194846
161
162         Reviewed by Don Olmstead.
163
164         Added _search_paths() and _port_specific_expectations_files() for
165         WinCairoPort.
166
167         * Scripts/webkitpy/port/win.py:
168         (WinCairoPort.default_baseline_search_path):
169         (WinCairoPort):
170         (WinCairoPort._port_specific_expectations_files):
171         (WinCairoPort._search_paths):
172
173 2019-02-22  Tim Horton  <timothy_horton@apple.com>
174
175         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
176         https://bugs.webkit.org/show_bug.cgi?id=194963
177
178         Reviewed by Dean Jackson.
179
180         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
181         Do a `contains` check instead of `equals`, because in debug builds we
182         put the GraphicsLayer pointer in a prefix.
183
184 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
185
186         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
187         https://bugs.webkit.org/show_bug.cgi?id=194873
188         <rdar://problem/46701974>
189
190         Reviewed by Tim Horton.
191
192         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
193
194         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
195         (WTR::UIScriptController::menuRect const):
196         (WTR::UIScriptController::isShowingMenu const):
197         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
198         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
199         (WTR::UIScriptController::menuRect const):
200
201         Add a function to query the bounds of the callout menu in content coordinates.
202
203         (WTR::UIScriptController::isShowingMenu const):
204
205         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
206
207         * TestRunnerShared/UIScriptContext/UIScriptController.h:
208         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
209         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
210         (WTR::UIScriptController::rectForMenuAction const):
211         (WTR::UIScriptController::menuRect const):
212         (WTR::UIScriptController::isShowingMenu const):
213         (WTR::findViewInHierarchyOfType): Deleted.
214
215 2019-02-22  Chris Dumez  <cdumez@apple.com>
216
217         Regression(PSON) Unable to preview password-protected documents on iCloud.com
218         https://bugs.webkit.org/show_bug.cgi?id=194954
219         <rdar://problem/48127957>
220
221         Reviewed by Alex Christensen.
222
223         Add API test coverage.
224
225         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
226         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
227         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
228         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
229
230 2019-02-22  Chris Dumez  <cdumez@apple.com>
231
232         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
233         https://bugs.webkit.org/show_bug.cgi?id=194924
234         <rdar://problem/48216125>
235
236         Reviewed by Geoffrey Garen.
237
238         Add API test coverage.
239
240         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
241
242 2019-02-22  Chris Dumez  <cdumez@apple.com>
243
244         Unreviewed, disable API test added in r241928 on iOS.
245
246         The cache is not enabled on devices with less than 3GB of RAM.
247
248         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
249
250 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
251
252         Hardcode Visual Viewports on everywhere except iOS WK1
253         https://bugs.webkit.org/show_bug.cgi?id=194928
254
255         Reviewed by Zalan Bujtas.
256
257         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
258         change the default value of the Setting to 'true', and hardcode WebView on iOS to
259         set it to false. The setting has shipped for several years and there's no need to turn
260         it off now.
261
262         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
263         Visual Viewports are not enabled.
264         
265         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
266         that only runs in WK2
267
268         * MiniBrowser/mac/SettingsController.h:
269         * MiniBrowser/mac/SettingsController.m:
270         (-[SettingsController init]):
271         (-[SettingsController _populateMenu]):
272         (-[SettingsController validateMenuItem:]):
273         (-[SettingsController visualViewportEnabled]): Deleted.
274         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
275         * MiniBrowser/mac/WK1BrowserWindowController.m:
276         (-[WK1BrowserWindowController didChangeSettings]):
277         * MiniBrowser/mac/WK2BrowserWindowController.m:
278         (-[WK2BrowserWindowController didChangeSettings]):
279
280 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
281
282         Discard cached processes when clearing website data store
283         https://bugs.webkit.org/show_bug.cgi?id=194894
284
285         Reviewed by Chris Dumez.
286
287         Added a test case.
288
289         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
290         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
291
292 2019-02-21  Alex Christensen  <achristensen@webkit.org>
293
294         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
295         https://bugs.webkit.org/show_bug.cgi?id=194914
296         <rdar://problem/47586889>
297
298         Reviewed by Geoffrey Garen.
299
300         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
301         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
302         (TEST):
303         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
304
305 2019-02-21  David Kilzer  <ddkilzer@apple.com>
306
307         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
308         <https://webkit.org/b/194761>
309
310         Reviewed by Myles Maxfield.
311
312         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
313         (WTR::activateSystemCoreWebFonts): Log `error` to console if
314         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
315         to use ARC-compliant cast.
316         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
317         ARC-compliant cast.
318         (WTR::installFakeHelvetica): Log `error` to console if
319         CTFontManagerRegisterFontsForURL() fails, but only on supported
320         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
321         Call CFRelease() on `error` to fix the leak.  Update to use
322         ARC-compliant cast.
323         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
324         cast.
325
326 2019-02-21  Chris Dumez  <cdumez@apple.com>
327
328         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
329         https://bugs.webkit.org/show_bug.cgi?id=194481
330
331         Reviewed by Alex Christensen.
332
333         Give the processes a chance to shutdown and wait until we reached the expected number
334         of processes.
335
336         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
337
338 2019-02-21  Tim Horton  <timothy_horton@apple.com>
339
340         Fix the macOS build
341
342         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
343
344 2019-02-21  Tim Horton  <timothy_horton@apple.com>
345
346         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
347
348         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
349         I am a backwards.
350
351 2019-02-21  Tim Horton  <timothy_horton@apple.com>
352
353         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
354
355         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
356         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
357         We could force on UI-side compositing, but I feel like the test might be more
358         valuable exercising the normal path on each platform (though the original
359         bug was also UI-side specific). Though we can't validate that the overlay
360         layer was installed successfully, there are layout tests that do that.
361
362 2019-02-21  Tim Horton  <timothy_horton@apple.com>
363
364         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
365         https://bugs.webkit.org/show_bug.cgi?id=194845
366         <rdar://problem/47944579>
367
368         Reviewed by Antti Koivisto.
369
370         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
371         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
372
373 2019-02-21  Zalan Bujtas  <zalan@apple.com>
374
375         [LFC][Floats] Add support for placing formatting roots in-between floats.
376         https://bugs.webkit.org/show_bug.cgi?id=194902
377
378         Reviewed by Antti Koivisto.
379
380         * LayoutReloaded/misc/LFC-passing-tests.txt:
381
382 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
383
384         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
385         https://bugs.webkit.org/show_bug.cgi?id=194901
386
387         Unreviewed build fix.
388
389         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
390         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
391         WPEBackend-fdo-0.1 as library name.
392
393 2019-02-21  Rob Buis  <rbuis@igalia.com>
394
395         Update MIME type parser
396         https://bugs.webkit.org/show_bug.cgi?id=180526
397
398         Reviewed by Darin Adler.
399
400         Add tests involving leading and trailing whitespace, non-token
401         characters and quoted strings.
402
403         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
404         (TestWebKitAPI::TEST):
405
406 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
407
408         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
409         https://bugs.webkit.org/show_bug.cgi?id=194884
410
411         Reviewed by Michael Catanzaro.
412
413         * PlatformWin.cmake:
414
415 2019-02-20  Chris Dumez  <cdumez@apple.com>
416
417         Add API test for <rdar://problem/47471222>
418         https://bugs.webkit.org/show_bug.cgi?id=194847
419
420         Reviewed by Alex Christensen.
421
422         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
423
424 2019-02-20  Chris Dumez  <cdumez@apple.com>
425
426         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
427         https://bugs.webkit.org/show_bug.cgi?id=194872
428         <rdar://problem/47924500>
429
430         Reviewed by Alex Christensen.
431
432         Add API test coverage.
433
434         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
435
436 2019-02-20  Jer Noble  <jer.noble@apple.com>
437
438         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
439         https://bugs.webkit.org/show_bug.cgi?id=191332
440
441         Reviewed by Dean Jackson.
442
443         * Scripts/git-is-in-range: Added.
444
445 2019-02-20  Andy Estes  <aestes@apple.com>
446
447         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
448         https://bugs.webkit.org/show_bug.cgi?id=194869
449
450         Rubber-stamped by Jer Noble.
451
452         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
453         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
454         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
455         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
457         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
458
459 2019-02-20  Chris Dumez  <cdumez@apple.com>
460
461         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
462         https://bugs.webkit.org/show_bug.cgi?id=194857
463         <rdar://problem/47759323>
464
465         Reviewed by Alex Christensen.
466
467         Add API test coverage.
468
469         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
470
471 2019-02-20  Chris Dumez  <cdumez@apple.com>
472
473         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
474         https://bugs.webkit.org/show_bug.cgi?id=194829
475         <rdar://problem/47889906>
476
477         Reviewed by Alexey Proskuryakov.
478
479         Every time the TestOptions were changing we were creating both a new Web view and
480         a new WKContext, which would start a new Network process. In most cases, we only
481         need to contruct a new Web view and we do can keep reusing the same WKContext.
482         This patch implements this optimization and thus avoids spinning a lot of new
483         Network processes while running the layout tests.
484
485         * WebKitTestRunner/TestController.cpp:
486         (WTR::TestController::generateContextConfiguration const):
487         (WTR::TestController::generatePageConfiguration):
488         (WTR::TestController::createWebViewWithOptions):
489         (WTR::TestController::resetPreferencesToConsistentValues):
490         (WTR::updateTestOptionsFromTestHeader):
491         * WebKitTestRunner/TestController.h:
492         * WebKitTestRunner/TestOptions.h:
493         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
494         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
495         (WTR::TestOptions::hasSameInitializationOptions const):
496         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
497         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
498         (WTR::TestController::platformAddTestOptions const):
499
500 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
501
502         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
503         https://bugs.webkit.org/show_bug.cgi?id=167941
504
505         Reviewed by Carlos Garcia Campos.
506
507         * MiniBrowser/gtk/main.c:
508         (filterSavedCallback): Added.
509         (main): Support loading a JSON rule set file for content filtering.
510         * MiniBrowser/wpe/main.cpp:
511         (filterSavedCallback): Added.
512         (main): Support loading a JSON rule set file for content filtering.
513         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
514         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
515         (WTF::derefGPtr): Ditto.
516         (testEmptyStore):
517         (testSaveInvalidFilter):
518         (testSaveLoadFilter):
519         (testSavedFilterIdentifierMatch):
520         (testRemoveFilter):
521         (testSaveMultipleFilters):
522         (testSaveFilterFromFile):
523         (testFilterPersistence):
524         (beforeAll):
525         (afterAll):
526         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
527         (removeOldInjectedContentAndResetLists): Also reset content filters.
528         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
529         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
530         the element affected by the style sheet.
531         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
532         and returns it to be used by tests.
533         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
534         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
535         (serverCallback): Add support for serving a CSS style sheet for testing.
536         (beforeAll): Add call to testUserContentManagerContentFilter().
537         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
538
539 2019-02-19  Keith Rollin  <krollin@apple.com>
540
541         Add timing information to build output
542         https://bugs.webkit.org/show_bug.cgi?id=194839
543         <rdar://problem/48219609>
544
545         Reviewed by Alexey Proskuryakov.
546
547         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
548         emit each project's build time to its output. E.g.,
549
550             ** BUILD SUCCEEDED ** [0.132 sec]
551
552         * Scripts/webkitdirs.pm:
553         (XcodeOptions):
554
555 2019-02-19  Truitt Savell  <tsavell@apple.com>
556
557         Unreviewed, rolling out r241784.
558
559         Broke all OpenSource builds.
560
561         Reverted changeset:
562
563         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
564         instances view"
565         https://bugs.webkit.org/show_bug.cgi?id=172848
566         https://trac.webkit.org/changeset/241784
567
568 2019-02-19  Zalan Bujtas  <zalan@apple.com>
569
570         [LFC][Floats] Remove redundant intersecting logic
571         https://bugs.webkit.org/show_bug.cgi?id=194804
572
573         Reviewed by Antti Koivisto.
574
575         * LayoutReloaded/misc/LFC-passing-tests.txt:
576
577 2019-02-19  Dean Jackson  <dino@apple.com>
578
579         Clean-up output from generate-xcfilelists so it can be filtered
580         https://bugs.webkit.org/show_bug.cgi?id=194795
581
582         Reviewed by Joseph Pecoraro (and Keith Rollin).
583
584         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
585         make a slight tweak to filter-build-webkit so such lines are marked
586         as plain.
587
588         * Scripts/filter-build-webkit:
589         * Scripts/generate-xcfilelists:
590
591 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
592
593         pytest is not correctly auto-installed
594         https://bugs.webkit.org/show_bug.cgi?id=194707
595
596         Reviewed by Carlos Garcia Campos.
597
598         * Scripts/webkitpy/thirdparty/__init__.py:
599         (AutoinstallImportHook._install_pytest):
600
601 2019-02-18  Chris Dumez  <cdumez@apple.com>
602
603         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
604         https://bugs.webkit.org/show_bug.cgi?id=194797
605         <rdar://problem/48055151>
606
607         Reviewed by Geoffrey Garen.
608
609         Add API test coverage.
610
611         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
612
613 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
614
615         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
616         https://bugs.webkit.org/show_bug.cgi?id=194670
617         <rdar://problem/39066529>
618
619         Reviewed by Tim Horton.
620
621         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
622         pasted in an editable area as attachment elements.
623
624         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
625         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
626         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
627         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
628         (TestWebKitAPI::TEST):
629         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
630         (WTR::InjectedBundlePage::InjectedBundlePage):
631
632 2019-02-18  Alex Christensen  <achristensen@webkit.org>
633
634         Fix API test after r241728
635        ​https://bugs.webkit.org/show_bug.cgi?id=194723
636
637         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
638         (TEST):
639         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
640
641 2019-02-18  Daniel Bates  <dabates@apple.com>
642
643         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
644         https://bugs.webkit.org/show_bug.cgi?id=192824
645         <rdar://problem/47100332>
646
647         Reviewed by Wenson Hsieh.
648
649         Fix a bug where the wrong usage code was used for F13 thru F24.
650
651         * WebKitTestRunner/ios/HIDEventGenerator.mm:
652         (keyCodeForDOMFunctionKey):
653
654 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
655
656         Bytecode cache should a have a boot-specific validation
657         https://bugs.webkit.org/show_bug.cgi?id=194769
658         <rdar://problem/48149509>
659
660         Reviewed by Keith Miller.
661
662         Add test for WTF::bootSessionUUIDString()
663
664         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
665         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
666         (TEST):
667
668 2019-02-18  Alex Christensen  <achristensen@webkit.org>
669
670         Disable safe browsing in WKWebView and remove its WKPreferences API
671         https://bugs.webkit.org/show_bug.cgi?id=194723
672         <rdar://problem/48122993>
673
674         Reviewed by Geoffrey Garen.
675
676         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
677         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
678         (TEST):
679         (safeBrowsingView):
680         Make tests use SPI instead of API.
681
682 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
683
684         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
685         https://bugs.webkit.org/show_bug.cgi?id=194586
686
687         Reviewed by Ross Kirsling.
688
689         * DumpRenderTree/win/DumpRenderTree.cpp:
690         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
691         * Scripts/webkitpy/port/driver.py:
692         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
693
694 2019-02-17  David Kilzer  <ddkilzer@apple.com>
695
696         Unreviewed, rolling out r241620.
697
698         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
699         (Requested by ddkilzer on #webkit.)
700
701         Reverted changeset:
702
703         "[WTF] Add environment variable helpers"
704         https://bugs.webkit.org/show_bug.cgi?id=192405
705         https://trac.webkit.org/changeset/241620
706
707 2019-02-16  Zalan Bujtas  <zalan@apple.com>
708
709         [LFC] RenderImage's default intrinsic size is 0.
710         https://bugs.webkit.org/show_bug.cgi?id=194745
711
712         Reviewed by Antti Koivisto.
713
714         * LayoutReloaded/misc/LFC-passing-tests.txt:
715
716 2019-02-16  Zalan Bujtas  <zalan@apple.com>
717
718         [LFC][BFC] Add support for block replaced intrinsic width.
719         https://bugs.webkit.org/show_bug.cgi?id=194705
720
721         Reviewed by Simon Fraser.
722
723         * LayoutReloaded/misc/LFC-passing-tests.txt:
724
725 2019-02-16  Zalan Bujtas  <zalan@apple.com>
726
727         [LFC] Apply min/max width constraints to preferred width computation
728         https://bugs.webkit.org/show_bug.cgi?id=194739
729
730         Reviewed by Simon Fraser.
731
732         * LayoutReloaded/misc/LFC-passing-tests.txt:
733
734 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
735
736         [WTF] Add environment variable helpers
737         https://bugs.webkit.org/show_bug.cgi?id=192405
738
739         Reviewed by Michael Catanzaro.
740
741         * DumpRenderTree/mac/DumpRenderTree.mm:
742         (libraryPathForDumpRenderTree):
743         * DumpRenderTree/win/DumpRenderTree.cpp:
744         (libraryPathForDumpRenderTree):
745         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
746         (setUpIOSLayoutTestCommunication):
747         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
748         (beforeAll):
749         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
750         (main):
751         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
752         (WebKitTestBus::run):
753         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
754         (WTR::getOutputDir):
755         (WTR::initializeFontConfigSetting):
756         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
757         (WTR::InjectedBundle::platformInitialize):
758         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
759         (WTR::topLevelPath):
760         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
761         (WTR::topLevelPath):
762         (WTR::getOutputDir):
763         (WTR::activateFonts):
764         * WebKitTestRunner/TestController.cpp:
765         (WTR::TestController::libraryPathForTesting):
766         (WTR::TestController::generateContextConfiguration const):
767         (WTR::TestController::generatePageConfiguration):
768         (WTR::TestController::decideDestinationWithSuggestedFilename):
769         (WTR::TestController::platformAdjustContext):
770         * WebKitTestRunner/TestController.h:
771         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
772         (WTR::TestController::cocoaPlatformInitialize):
773         (WTR::TestController::platformAdjustContext):
774         * WebKitTestRunner/gtk/main.cpp:
775         (main):
776         * WebKitTestRunner/mac/TestControllerMac.mm:
777         (WTR::TestController::configureContentExtensionForTest):
778         * WebKitTestRunner/wpe/main.cpp:
779         (main):
780         Utilize WTF::Environment where possible.
781
782 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
783
784         [iOS] WKWebView callout bar is missing Change Writing Direction item
785         https://bugs.webkit.org/show_bug.cgi?id=190015
786         <rdar://problem/44810366>
787
788         Reviewed by Tim Horton.
789
790         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
791         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
792
793         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
794         (TestWebKitAPI::TEST):
795
796 2019-02-15  Chris Dumez  <cdumez@apple.com>
797
798         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
799         https://bugs.webkit.org/show_bug.cgi?id=194717
800         <rdar://problem/47884404>
801
802         Reviewed by Brady Eidson.
803
804         Add API test coverage.
805
806         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
807
808 2019-02-15  Youenn Fablet  <youenn@apple.com>
809
810         Make navigator.mediaDevices SecureContext
811         https://bugs.webkit.org/show_bug.cgi?id=194666
812
813         Reviewed by Eric Carlson.
814
815         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
816         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
817         (TEST_F):
818
819 2019-02-15  Brian Burg  <bburg@apple.com>
820
821         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
822         https://bugs.webkit.org/show_bug.cgi?id=194411
823         <rdar://problem/47787614>
824
825         Reviewed by Joseph Pecoraro.
826
827         Remove unnecessary soft linking macro usage.
828
829         * DumpRenderTree/mac/TestRunnerMac.mm:
830         (TestRunner::inspectorTestStubURL):
831         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
832         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
833         (WTR::TestRunner::inspectorTestStubURL):
834
835 2019-02-15  Commit Queue  <commit-queue@webkit.org>
836
837         Unreviewed, rolling out r241559 and r241566.
838         https://bugs.webkit.org/show_bug.cgi?id=194710
839
840         Causes layout test crashes under GuardMalloc (Requested by
841         ryanhaddad on #webkit).
842
843         Reverted changesets:
844
845         "[WTF] Add environment variable helpers"
846         https://bugs.webkit.org/show_bug.cgi?id=192405
847         https://trac.webkit.org/changeset/241559
848
849         "Unreviewed build fix for WinCairo Debug after r241559."
850         https://trac.webkit.org/changeset/241566
851
852 2019-02-15  Zalan Bujtas  <zalan@apple.com>
853
854         [LFC] Out-of-flow box is never a float box
855         https://bugs.webkit.org/show_bug.cgi?id=194704
856
857         Reviewed by Antti Koivisto.
858
859         * LayoutReloaded/misc/LFC-passing-tests.txt:
860
861 2019-02-10  Darin Adler  <darin@apple.com>
862
863         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
864         https://bugs.webkit.org/show_bug.cgi?id=194487
865
866         Reviewed by Daniel Bates.
867
868         * DumpRenderTree/win/DumpRenderTree.cpp:
869         (applicationId): Use makeString instead of String::format.
870         (main): Ditto.
871         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
872         (TestWebKitAPI::Util::createURLForResource): Ditto.
873         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
874         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
875
876         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
877         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
878         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
879         (WTR::createStringWithAttributes): Use appendLiteral.
880         (WTR::AccessibilityUIElement::helpText const): Ditto.
881         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
882         directly instead of using String::format.
883         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
884         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
885
886 2019-02-15  Truitt Savell  <tsavell@apple.com>
887
888         Unreviewed, rolling out r241564.
889
890         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
891
892         Reverted changeset:
893
894         "[Mac] WebInspectorUI.framework does not need to be soft-
895         linked anymore"
896         https://bugs.webkit.org/show_bug.cgi?id=194411
897         https://trac.webkit.org/changeset/241564
898
899 2019-02-15  Saam barati  <sbarati@apple.com>
900
901         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
902         https://bugs.webkit.org/show_bug.cgi?id=194036
903
904         Reviewed by Yusuke Suzuki.
905
906         * Scripts/run-jsc-stress-tests:
907
908 2019-02-14  Tim Horton  <timothy_horton@apple.com>
909
910         Fix the build.
911
912         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
913         (WTR::UIScriptController::drawSquareInEditableImage):
914         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
915         (TestWebKitAPI::drawSquareInEditableImage):
916
917 2019-02-14  Tim Horton  <timothy_horton@apple.com>
918
919         Fix the build.
920
921         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
922         (WTR::UIScriptController::drawSquareInEditableImage):
923         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
924         (TestWebKitAPI::drawSquareInEditableImage):
925
926 2019-02-14  Brian Burg  <bburg@apple.com>
927
928         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
929         https://bugs.webkit.org/show_bug.cgi?id=194411
930         <rdar://problem/47787614>
931
932         Reviewed by Joseph Pecoraro.
933
934         Remove unnecessary soft linking macro usage.
935
936         * DumpRenderTree/mac/TestRunnerMac.mm:
937         (TestRunner::inspectorTestStubURL):
938         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
939         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
940         (WTR::TestRunner::inspectorTestStubURL):
941
942 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
943
944         [ews-app] status bubble should fetch builder name info from BuilderMapping table
945         https://bugs.webkit.org/show_bug.cgi?id=194599
946
947         Reviewed by Lucas Forschler.
948
949         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
950         (StatusBubble._build_bubble):
951
952 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
953
954         [ews-app] Set Foreign Key in Django build model
955         https://bugs.webkit.org/show_bug.cgi?id=194667
956
957         Reviewed by Lucas Forschler.
958
959         * BuildSlaveSupport/ews-app/ews/models/build.py:
960         (Build):
961
962 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
963
964         [WTF] Add environment variable helpers
965         https://bugs.webkit.org/show_bug.cgi?id=192405
966
967         Reviewed by Michael Catanzaro.
968
969         * DumpRenderTree/mac/DumpRenderTree.mm:
970         (libraryPathForDumpRenderTree):
971         * DumpRenderTree/win/DumpRenderTree.cpp:
972         (libraryPathForDumpRenderTree):
973         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
974         (setUpIOSLayoutTestCommunication):
975         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
976         (TestWebKitAPI::strip):
977         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
978         (beforeAll):
979         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
980         (main):
981         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
982         (WebKitTestBus::run):
983         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
984         (WTR::getOutputDir):
985         (WTR::initializeFontConfigSetting):
986         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
987         (WTR::InjectedBundle::platformInitialize):
988         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
989         (WTR::topLevelPath):
990         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
991         (WTR::topLevelPath):
992         (WTR::getOutputDir):
993         (WTR::activateFonts):
994         * WebKitTestRunner/TestController.cpp:
995         (WTR::TestController::libraryPathForTesting):
996         (WTR::TestController::generateContextConfiguration const):
997         (WTR::TestController::generatePageConfiguration):
998         (WTR::TestController::decideDestinationWithSuggestedFilename):
999         (WTR::TestController::platformAdjustContext):
1000         * WebKitTestRunner/TestController.h:
1001         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1002         (WTR::TestController::cocoaPlatformInitialize):
1003         (WTR::TestController::platformAdjustContext):
1004         * WebKitTestRunner/gtk/main.cpp:
1005         (main):
1006         * WebKitTestRunner/mac/TestControllerMac.mm:
1007         (WTR::TestController::configureContentExtensionForTest):
1008         * WebKitTestRunner/wpe/main.cpp:
1009         (main):
1010         Utilize WTF::Environment where possible.
1011
1012 2019-02-14  Chris Dumez  <cdumez@apple.com>
1013
1014         [PSON] Introduce a WebContent Process cache
1015         https://bugs.webkit.org/show_bug.cgi?id=194594
1016         <rdar://problem/46793397>
1017
1018         Reviewed by Geoff Garen.
1019
1020         Update API tests to turn on the WebContent Process cache.
1021
1022         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1023
1024 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1025
1026         Unreviewed, build fix after r241480
1027
1028         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1029         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1030         (-[DragAndDropSimulator initWithWebView:]):
1031
1032 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1033
1034         AX: ARIA Reflection was disabled in error
1035         https://bugs.webkit.org/show_bug.cgi?id=194647
1036         <rdar://problem/48068336>
1037
1038         Reviewed by Ryosuke Niwa.
1039
1040         Remove test override now that this feature should be enabled by default.
1041
1042         * WebKitTestRunner/TestController.cpp:
1043         (WTR::TestController::resetPreferencesToConsistentValues):
1044
1045 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1046
1047         Unreviewed, rolling out r241486.
1048         https://bugs.webkit.org/show_bug.cgi?id=194655
1049
1050         causing API failures in builds (Requested by ShawnRoberts on
1051         #webkit).
1052
1053         Reverted changeset:
1054
1055         "[Cocoa] Media elements will restart network buffering just
1056         before suspending"
1057         https://bugs.webkit.org/show_bug.cgi?id=193691
1058         https://trac.webkit.org/changeset/241486
1059
1060 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1061
1062         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1063         https://bugs.webkit.org/show_bug.cgi?id=194622
1064
1065         Reviewed by Antti Koivisto.
1066
1067         * LayoutReloaded/misc/LFC-passing-tests.txt:
1068
1069 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1070
1071         [LFC] Shrink-to-fit-width should be constrained by min/max width
1072         https://bugs.webkit.org/show_bug.cgi?id=194653
1073
1074         Reviewed by Antti Koivisto.
1075
1076         * LayoutReloaded/misc/LFC-passing-tests.txt:
1077
1078 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1079
1080         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1081         https://bugs.webkit.org/show_bug.cgi?id=194641
1082
1083         Reviewed by Geoffrey Garen.
1084
1085         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1086         so that the test would fail without this fix.
1087
1088         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1089         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1090
1091 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1092
1093         [ews-app] Change log level for a log statement
1094
1095         Unreviewed minor fix.
1096
1097         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1098         (Patch.save_patch):
1099
1100 2019-02-13  Jer Noble  <jer.noble@apple.com>
1101
1102         [Cocoa] Media elements will restart network buffering just before suspending
1103         https://bugs.webkit.org/show_bug.cgi?id=193691
1104
1105         Reviewed by Eric Carlson.
1106
1107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1108         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1109         (TEST):
1110
1111 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1112
1113         [ews-app] Fetch builder id to name mapping
1114         https://bugs.webkit.org/show_bug.cgi?id=194355
1115
1116         Reviewed by Lucas Forschler.
1117
1118         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1119         (Buildbot.get_builder_id_to_name_mapping):
1120         (Buildbot._get_display_name_from_builder_name):
1121
1122 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1123
1124         Further restricting webarchive loads
1125         https://bugs.webkit.org/show_bug.cgi?id=194567
1126         <rdar://problem/47610130>
1127
1128         Reviewed by Youenn Fablet.
1129
1130         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1131         navigations on drop.
1132
1133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1134         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1135         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1136         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1137         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1138         (TestWebKitAPI::TEST):
1139         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1140         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1141         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1142         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1143         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1144         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1145         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1146
1147 2019-02-13  John Wilander  <wilander@apple.com>
1148
1149         Store Ad Click Attribution requests in the network process
1150         https://bugs.webkit.org/show_bug.cgi?id=194510
1151         <rdar://problem/47650118>
1152
1153         Reviewed by Alex Christensen and Daniel Bates.
1154
1155         This patch adds two TestRunner functions:
1156         - dumpAdClickAttribution()
1157         - clearAdClickAttribution()
1158
1159         They call into the network process to dump and clear Ad Click
1160         Attribution state, respectively.
1161
1162         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1163         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1164         (WTR::TestRunner::dumpAdClickAttribution):
1165         (WTR::TestRunner::clearAdClickAttribution):
1166         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1167         * WebKitTestRunner/TestController.cpp:
1168         (WTR::TestController::resetStateToConsistentValues):
1169         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1170         (WTR::adClickAttributionStringResultCallback):
1171         (WTR::TestController::dumpAdClickAttribution):
1172         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1173         (WTR::adClickAttributionVoidCallback):
1174         (WTR::TestController::clearAdClickAttribution):
1175         * WebKitTestRunner/TestController.h:
1176         * WebKitTestRunner/TestInvocation.cpp:
1177         (WTR::TestInvocation::dumpResults):
1178         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1179         (WTR::TestInvocation::dumpAdClickAttribution):
1180         * WebKitTestRunner/TestInvocation.h:
1181
1182 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1183
1184         [ews-app] Generate status-bubble
1185         https://bugs.webkit.org/show_bug.cgi?id=194572
1186
1187         Reviewed by Lucas Forschler.
1188
1189         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1190         (StatusBubble._build_bubble):
1191         (StatusBubble._should_show_bubble_for):
1192         (StatusBubble._build_bubbles_for_patch):
1193
1194 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1195
1196         [ews-app] Add status bubble html template
1197         https://bugs.webkit.org/show_bug.cgi?id=194571
1198
1199         Reviewed by Lucas Forschler.
1200
1201         * BuildSlaveSupport/ews-app/ews/templates: Added.
1202         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1203
1204 2019-02-12  Chris Dumez  <cdumez@apple.com>
1205
1206         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1207         https://bugs.webkit.org/show_bug.cgi?id=194568
1208         <rdar://problem/47944490>
1209
1210         Reviewed by Ryosuke Niwa.
1211
1212         Add API test coverage.
1213
1214         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1215         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1216
1217 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1218
1219         webkitpy: Remove bug_dummy from parsed test expectations
1220         https://bugs.webkit.org/show_bug.cgi?id=194562
1221         <rdar://problem/47853999>
1222
1223         Reviewed by Lucas Forschler.
1224
1225         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1226         (TestExpectationParser):
1227         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1228         skipped tests.
1229         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1230
1231 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1232
1233         [ews-app] Add method to fetch patch
1234         https://bugs.webkit.org/show_bug.cgi?id=194518
1235
1236         Reviewed by Lucas Forschler.
1237
1238         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1239         (Patch.get_patch):
1240
1241 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1242
1243         [LFC] Expand tests coverage (60 new tests -> 860)
1244
1245         Unreviewed test gardening (run-singly, --child-processes=1).
1246
1247         * LayoutReloaded/misc/LFC-passing-tests.txt:
1248
1249 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1250
1251         Allow pages to trigger programmatic paste from script on iOS
1252         https://bugs.webkit.org/show_bug.cgi?id=194271
1253         <rdar://problem/47808810>
1254
1255         Reviewed by Tim Horton.
1256
1257         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1258
1259         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1260         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1261         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1262         (WTR::UIScriptController::rectForMenuAction const):
1263
1264         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1265         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1266         for when the menu is shown or hidden.
1267
1268         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1269         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1270         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1271         (WTR::UIScriptController::setDidShowMenuCallback):
1272         (WTR::UIScriptController::didShowMenuCallback const):
1273         (WTR::UIScriptController::setDidHideMenuCallback):
1274         (WTR::UIScriptController::didHideMenuCallback const):
1275         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1276         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1277         (WTR::UIScriptController::rectForMenuAction const):
1278         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1279         * WebKitTestRunner/TestController.cpp:
1280         (WTR::TestController::resetPreferencesToConsistentValues):
1281         (WTR::updateTestOptionsFromTestHeader):
1282         * WebKitTestRunner/TestOptions.h:
1283
1284         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1285         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1286
1287         (WTR::TestOptions::hasSameInitializationOptions const):
1288         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1289         (WTR::UIScriptController::calendarType const):
1290         (WTR::UIScriptController::platformUndoManager const):
1291         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1292         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1293         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1294         (-[TestRunnerWKWebView dealloc]):
1295         (-[TestRunnerWKWebView _didShowMenu]):
1296         (-[TestRunnerWKWebView _didHideMenu]):
1297
1298         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1299
1300         * WebKitTestRunner/ios/TestControllerIOS.mm:
1301         (WTR::handleMenuWillHideNotification):
1302         (WTR::handleMenuDidHideNotification):
1303         (WTR::TestController::platformInitialize):
1304         (WTR::TestController::platformDestroy):
1305         (WTR::TestController::platformResetStateToConsistentValues):
1306
1307         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1308         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1309
1310         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1311         (WTR::forEachViewInHierarchy):
1312         (WTR::findViewInHierarchyOfType):
1313
1314         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1315         functions that dig through a given view's hierarchy in search of a view of a given class.
1316
1317         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1318         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1319         (WTR::UIScriptController::selectionCaretViewRect const):
1320         (WTR::UIScriptController::selectionRangeViewRects const):
1321         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1322         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1323
1324         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1325
1326         (WTR::UIScriptController::rectForMenuAction const):
1327
1328         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1329         callout bar) whose label matches the given string.
1330
1331         (WTR::UIScriptController::platformContentView const):
1332
1333         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1334         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1335         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1336
1337         (WTR::UIScriptController::platformUndoManager const): Deleted.
1338         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1339         (WTR::UIScriptController::platformContentView const):
1340         (WTR::UIScriptController::platformUndoManager const): Deleted.
1341
1342 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1343
1344         webkitpy: No option to only show unexpected failures in results.html for iPad
1345         https://bugs.webkit.org/show_bug.cgi?id=194554
1346         <rdar://problem/47922442>
1347
1348         Rubber-stamped by Aakash Jain.
1349
1350         Just because a TestExpecations file does not exist for a specific platform does not mean that
1351         TestExpecations are not being used, given that platforms inherit test expectations.
1352
1353         * Scripts/webkitpy/port/base.py:
1354         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1355         * Scripts/webkitpy/port/base_unittest.py:
1356         (PortTest.test_uses_test_expectations_file):
1357
1358 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1359
1360         Remove setDefersLoading infrastructure from WebKit2
1361         https://bugs.webkit.org/show_bug.cgi?id=194506
1362
1363         Reviewed by Brady Eidson.
1364
1365         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1366         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1367         (WTR::TestRunner::setDefersLoading): Deleted.
1368         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1369
1370 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1371
1372         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1373         https://bugs.webkit.org/show_bug.cgi?id=194522
1374         <rdar://problem/47789393>
1375
1376         Reviewed by Chris Dumez.
1377
1378         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1379         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1380         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1381         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1382
1383 2019-02-12  Andy Estes  <aestes@apple.com>
1384
1385         [iOSMac] Enable Parental Controls Content Filtering
1386         https://bugs.webkit.org/show_bug.cgi?id=194521
1387         <rdar://39732376>
1388
1389         Reviewed by Tim Horton.
1390
1391         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1392
1393 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1394
1395         [LFC][IFC] Add intrinsic width support for float boxes.
1396         https://bugs.webkit.org/show_bug.cgi?id=194528
1397
1398         Reviewed by Antti Koivisto.
1399
1400         Expand tests coverage (2 new tests -> 800).
1401         (This is the correct test ordering --runs-singly --child-processes=1)
1402
1403         * LayoutReloaded/misc/LFC-passing-tests.txt:
1404
1405 2019-02-12  Rob Buis  <rbuis@igalia.com>
1406
1407         Implement serializing in MIME type parser
1408         https://bugs.webkit.org/show_bug.cgi?id=193909
1409
1410         Reviewed by Darin Adler.
1411
1412         Add various tests involving upper case, non-ASCII, control/null characters,
1413         various HTTP whitespace, single quotes and an unpaired surrogate.
1414
1415         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1416         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1417         (TestWebKitAPI::serializeIfValid):
1418         (TestWebKitAPI::TEST):
1419
1420 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1421
1422         [Cocoa] Ask platform for generic font family mappings
1423         https://bugs.webkit.org/show_bug.cgi?id=187723
1424         <rdar://problem/41892438>
1425
1426         Reviewed by Brent Fulgham.
1427
1428         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1429
1430         * DumpRenderTree/mac/DumpRenderTree.mm:
1431         (allowedFontFamilySet):
1432         * WebKitTestRunner/mac/TestControllerMac.mm:
1433         (WTR::allowedFontFamilySet):
1434
1435 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1436
1437         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1438         https://bugs.webkit.org/show_bug.cgi?id=193622
1439
1440         Reviewed by Michael Catanzaro.
1441
1442         This adds support for loading content extension rule sets from the JSON files which
1443         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1444         of WKTR for this could be removed, but that is left for a follow-up patch with
1445         cleanups.
1446
1447         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1448         * WebKitTestRunner/TestController.cpp:
1449         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1450         avoid having the null-terminator copied into the result.
1451         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1452         part of the preparations to run a test.
1453         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1454         (WTR::contentExtensionStoreCallback): Added.
1455         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1456         used for content extensions test.
1457         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1458         extensions and compiling the JSON rule set for tests involving content extensions.
1459         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1460         testing and disables content extensions.
1461         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1462         resetContentExtensions().
1463         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1464         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1465         configureContentExtensionForTest(), and userContentController().
1466
1467 2019-02-11  Daniel Bates  <dabates@apple.com>
1468
1469         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1470         https://bugs.webkit.org/show_bug.cgi?id=191446
1471         <rdar://problem/45929460>
1472
1473         Reviewed by Tim Horton.
1474
1475         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1476
1477         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1478         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1479         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1480         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1481         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1482         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1483         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1484         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1485         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1486         (WTR::arrayLength):
1487         (WTR::parseModifierArray):
1488         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1489         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1490         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1491         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1492
1493 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1494
1495         Unreviewed, rolling out r241272 and r241276.
1496         https://bugs.webkit.org/show_bug.cgi?id=194514
1497
1498         Broke the Apple Internal build and the fix requires human
1499         intervention :( (Requested by dydz on #webkit).
1500
1501         Reverted changesets:
1502
1503         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1504         https://bugs.webkit.org/show_bug.cgi?id=191446
1505         https://trac.webkit.org/changeset/241272
1506
1507         "Fix internal iOS build after r241272"
1508         https://bugs.webkit.org/show_bug.cgi?id=191446
1509         https://trac.webkit.org/changeset/241276
1510
1511 2019-02-11  Truitt Savell  <tsavell@apple.com>
1512
1513         Unreviewed, rolling out r241269.
1514
1515         Caused 5 layout tests crashes on Mac WK1
1516
1517         Reverted changeset:
1518
1519         "DumpRenderTree should report unknown options"
1520         https://bugs.webkit.org/show_bug.cgi?id=191303
1521         https://trac.webkit.org/changeset/241269
1522
1523 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1524
1525         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1526         https://bugs.webkit.org/show_bug.cgi?id=194313
1527
1528         Reviewed by Tim Horton.
1529
1530         Add a helper to determine whether the web view is presenting modal UI.
1531
1532         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1533         (WTR::UIScriptController::isPresentingModally const):
1534         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1535         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1536         (WTR::UIScriptController::isPresentingModally const):
1537         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1538         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1539         (WTR::UIScriptController::calendarType const): Deleted.
1540         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1541         (WTR::UIScriptController::isPresentingModally const):
1542         (WTR::UIScriptController::calendarType const):
1543         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1544         (WTR::UIScriptController::calendarType const):
1545
1546 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1547
1548         GCHeapInspector: Show the retained sizes in more places
1549         https://bugs.webkit.org/show_bug.cgi?id=194464
1550
1551         Reviewed by Simon Fraser.
1552
1553         * GCHeapInspector/gc-heap-inspector.html:
1554         * GCHeapInspector/script/interface.js:
1555         (HeapInspectorUtils.humanReadableSize):
1556         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1557         (HeapInspectorUtils.spanForNode.span.span):
1558         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1559         (HeapSnapshotInspector.prototype.buildRoots):
1560
1561 2019-02-11  Daniel Bates  <dabates@apple.com>
1562
1563         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1564         https://bugs.webkit.org/show_bug.cgi?id=191446
1565         <rdar://problem/45929460>
1566
1567         Reviewed by Tim Horton.
1568
1569         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1570
1571         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1572         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1573         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1574         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1575         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1576         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1577         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1578         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1579         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1580         (WTR::arrayLength):
1581         (WTR::parseModifierArray):
1582         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1583         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1584         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1585         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1586
1587 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1588
1589         DumpRenderTree should report unknown options
1590         https://bugs.webkit.org/show_bug.cgi?id=191303
1591
1592         Reviewed by Frédéric Wang.
1593
1594         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1595         to report unknown options.
1596         Added and assigned test options which are currently used in tests.
1597
1598         * DumpRenderTree/TestOptions.cpp:
1599         (TestOptions::TestOptions):
1600
1601 2019-02-11  Truitt Savell  <tsavell@apple.com>
1602
1603         Unreviewed, rolling out r241229.
1604
1605         Revision broke internal builds for watchOS.
1606
1607         Reverted changeset:
1608
1609         "[Cocoa] Ask platform for generic font family mappings"
1610         https://bugs.webkit.org/show_bug.cgi?id=187723
1611         https://trac.webkit.org/changeset/241229
1612
1613 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1614
1615         [WinCairo][MiniBrowser] Basic authentication always fails.
1616         https://bugs.webkit.org/show_bug.cgi?id=194496
1617
1618         Reviewed by Don Olmstead.
1619
1620         * MiniBrowser/win/DialogHelper.h:
1621         (Dialog::getText):
1622
1623 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1624
1625         [GStreamer] GstMappedBuffer testsuite build fails
1626         https://bugs.webkit.org/show_bug.cgi?id=194495
1627
1628         Reviewed by Carlos Garcia Campos.
1629
1630         Fix the build by explicitely adding the gstreamer1.0-audio include
1631         directories to the include path.
1632
1633         * TestWebKitAPI/PlatformGTK.cmake:
1634         * TestWebKitAPI/PlatformWPE.cmake:
1635
1636 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1637
1638         [GTK][WPE] Add enable-javascript-markup setting
1639         https://bugs.webkit.org/show_bug.cgi?id=193439
1640
1641         Reviewed by Michael Catanzaro.
1642
1643         Add test cases to check the new setting.
1644
1645         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1646         (testWebKitSettings):
1647         (testWebKitSettingsJavaScriptMarkup):
1648         (beforeAll):
1649
1650 2019-02-10  Darin Adler  <darin@apple.com>
1651
1652         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1653         https://bugs.webkit.org/show_bug.cgi?id=194485
1654
1655         Reviewed by Daniel Bates.
1656
1657         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1658
1659 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1660
1661         Add more tests for clampTo<>()
1662         https://bugs.webkit.org/show_bug.cgi?id=194462
1663
1664         Reviewed by Geoffrey Garen.
1665
1666         Darin suggested to test the very last floating point number
1667         at the boundaries when truncating to integer.
1668         I added test for max/min and max-1/min-1.
1669
1670         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1671         (TestWebKitAPI::TEST):
1672
1673 2019-02-09  Darin Adler  <darin@apple.com>
1674
1675         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1676         https://bugs.webkit.org/show_bug.cgi?id=194021
1677
1678         Reviewed by Geoffrey Garen.
1679
1680         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1681         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1682         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1683
1684 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1685
1686         [LFC][IFC] Add intrinsic width support for basic inline containers
1687         https://bugs.webkit.org/show_bug.cgi?id=194473
1688
1689         Reviewed by Antti Koivisto.
1690
1691         Expand tests coverage (11 new tests -> 798)
1692
1693         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1694
1695 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1696
1697         Fix MiniBrowser's entitlements
1698         https://bugs.webkit.org/show_bug.cgi?id=192431
1699
1700         Reviewed by Joseph Pecoraro.
1701
1702         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1703         files, making it impossible to load any extension.
1704
1705         * MiniBrowser/MiniBrowser.entitlements:
1706
1707 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1708
1709         [Cocoa] Ask platform for generic font family mappings
1710         https://bugs.webkit.org/show_bug.cgi?id=187723
1711         <rdar://problem/41892438>
1712
1713         Reviewed by Brent Fulgham.
1714
1715         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1716
1717         * DumpRenderTree/mac/DumpRenderTree.mm:
1718         (allowedFontFamilySet):
1719         * WebKitTestRunner/mac/TestControllerMac.mm:
1720         (WTR::allowedFontFamilySet):
1721
1722 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1723
1724         [GTK] Implement back/forward touchpad gesture
1725         https://bugs.webkit.org/show_bug.cgi?id=193919
1726
1727         Reviewed by Michael Catanzaro.
1728
1729         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1730         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1731
1732 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1733
1734         Add SPI to use networking daemon instead of XPC service
1735         https://bugs.webkit.org/show_bug.cgi?id=194427
1736
1737         Reviewed by Geoffrey Garen
1738
1739         * MiniBrowser/MiniBrowser.entitlements:
1740
1741 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1742
1743         [ews-build] Ensure that every builder in config.json has short name
1744         https://bugs.webkit.org/show_bug.cgi?id=194461
1745
1746         Reviewed by Lucas Forschler.
1747
1748         * BuildSlaveSupport/ews-build/loadConfig.py:
1749         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1750
1751 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1752
1753         [ews-build] Add short name to config.json
1754         https://bugs.webkit.org/show_bug.cgi?id=194456
1755
1756         Reviewed by Lucas Forschler.
1757
1758         * BuildSlaveSupport/ews-build/config.json: Added short name.
1759         * BuildSlaveSupport/ews-build/loadConfig.py:
1760         (loadBuilderConfig): Set the short name as the builder description.
1761
1762 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1763
1764         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1765         https://bugs.webkit.org/show_bug.cgi?id=194418
1766
1767         Reviewed by Lucas Forschler.
1768
1769         Do not include errors trying when finding crashlogs at the end of
1770         a run-webkit-tests run since we don't process those errors.
1771
1772         * Scripts/webkitpy/port/darwin.py:
1773         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1774         * Scripts/webkitpy/port/ios_device.py:
1775         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1776         * Scripts/webkitpy/port/watch_device.py:
1777         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1778
1779 2019-02-08  Beth Dakin  <bdakin@apple.com>
1780
1781         Add afterScreenUpdates to WKSnapshotConfiguration
1782         https://bugs.webkit.org/show_bug.cgi?id=194362
1783         -and corresponding-
1784         <rdar://problem/40655528> Please add an "after screen updates" property to 
1785         WKSnapshotConfiguration (to solve blank snapshots)
1786
1787         Reviewed by Tim Horton.
1788
1789         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1790         (TEST):
1791
1792 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1793
1794         clampTo(): do not convert the input to double when dealing with integers
1795         https://bugs.webkit.org/show_bug.cgi?id=194263
1796         <rdar://problem/47692312>
1797
1798         Reviewed by Darin Adler.
1799
1800         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1801         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1802         (TestWebKitAPI::testClampFloatingPointToInteger):
1803         (TestWebKitAPI::testClampSameSignIntegers):
1804         (TestWebKitAPI::testClampUnsignedToSigned):
1805         (TestWebKitAPI::testClampSignedToUnsigned):
1806
1807 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1808
1809         webkitpy: Respect --dedicated-simulators flag
1810         https://bugs.webkit.org/show_bug.cgi?id=194416
1811         <rdar://problem/47894722>
1812
1813         Reviewed by Lucas Forschler.
1814
1815         * Scripts/webkitpy/port/device_port.py:
1816         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1817         available devices can be safely ignored.
1818
1819 2019-02-07  Keith Rollin  <krollin@apple.com>
1820
1821         Remove extra copy of 100x100-red.tga
1822         https://bugs.webkit.org/show_bug.cgi?id=194371
1823         <rdar://problem/47873465>
1824
1825         Reviewed by Said Abou-Hallawa.
1826
1827         In order to help it pass its tests, Bug 194190 added a second copy of
1828         the file 100x100-red.tga. However, it turns out that this additional
1829         file wasn't actually needed, and that that sole previous copy was
1830         sufficient. At the same time, this second copy -- which was copied to
1831         the same location in the build output as the first copy -- now caused
1832         XCBuild to complain because there were two production rules for the
1833         same output file. Address this by removing the newly-added extra copy.
1834
1835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1836         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1837
1838 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1839
1840         Deprecate WKBundlePageSetDefersLoading
1841         https://bugs.webkit.org/show_bug.cgi?id=191394
1842
1843         Reviewed by Dean Jackson.
1844
1845         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1846         (WTR::TestRunner::setDefersLoading):
1847
1848 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1849
1850         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1851         https://bugs.webkit.org/show_bug.cgi?id=194391
1852
1853         Reviewed by Antti Koivisto.
1854
1855         * LayoutReloaded/misc/LFC-passing-tests.txt:
1856
1857 2019-02-06  Keith Rollin  <krollin@apple.com>
1858
1859         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1860         https://bugs.webkit.org/show_bug.cgi?id=193975
1861         <rdar://problem/47643306>
1862
1863         Reviewed by Tim Horton.
1864
1865         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1866         the Info.plist file into the bundle. This step is not necessary as the
1867         implicit "bundle up all the build products into a framework" build
1868         phase does this already. Having the Copy Bundle Resources phase do
1869         this causes a conflict under XCBuild, which objects to two build
1870         phases producing the same file (Info.plist). Address this by removing
1871         Info.plist from the Copy Bundle Resources phase.
1872
1873         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1874
1875 2019-02-06  Keith Rollin  <krollin@apple.com>
1876
1877         Really enable the automatic checking and regenerations of .xcfilelists during builds
1878         https://bugs.webkit.org/show_bug.cgi?id=194357
1879         <rdar://problem/47861231>
1880
1881         Reviewed by Chris Dumez.
1882
1883         Bug 194124 was supposed to enable the automatic checking and
1884         regenerating of .xcfilelist files during the build. While related
1885         changes were included in that patch, the change to actually enable the
1886         operation somehow was omitted. This patch actually enables the
1887         operation. The check-xcfilelist.sh scripts now check
1888         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1889         from the checking.
1890
1891         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1892         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1893
1894 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1895
1896         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1897         <https://webkit.org/b/194286>
1898         <rdar://problem/47815558>
1899
1900         Reviewed by Alexey Proskuryakov.
1901
1902         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1903         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1904         WKRetainPtr<> to avoid leaking the WKDataRef.
1905
1906 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1907
1908         Unreviewed, fix a typo
1909
1910         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1911
1912 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1913
1914         [GTK][WPE] force libpsl build to use ICU in jhbuild
1915         https://bugs.webkit.org/show_bug.cgi?id=194288
1916
1917         Reviewed by Carlos Garcia Campos.
1918
1919         * gtk/jhbuild.modules:
1920         Require ICU for libpsl build in jhbuild, like done in WPE.
1921
1922 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1923
1924         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1925         https://bugs.webkit.org/show_bug.cgi?id=194209
1926
1927         Reviewed by Carlos Garcia Campos.
1928
1929         Enhance TestCookieManager to ensure this doesn't happen again.
1930
1931         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1932         (testCookieManagerPersistentStorage):
1933         (beforeAll):
1934
1935 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1936
1937         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1938         https://bugs.webkit.org/show_bug.cgi?id=194324
1939
1940         Reviewed by Andy Estes.
1941
1942         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1943         part of the name is already implicit, since this is in testing code in TestOptions.
1944
1945         * WebKitTestRunner/TestController.cpp:
1946         (WTR::TestController::generateContextConfiguration const):
1947         (WTR::updateTestOptionsFromTestHeader):
1948         * WebKitTestRunner/TestOptions.h:
1949         (WTR::TestOptions::hasSameInitializationOptions const):
1950
1951 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1952
1953         [ews-build] Allow * as platform for builders and workers
1954         https://bugs.webkit.org/show_bug.cgi?id=188533
1955
1956         Reviewed by Lucas Forschler.
1957
1958         * BuildSlaveSupport/ews-build/loadConfig.py:
1959         (checkWorkersAndBuildersForConsistency):
1960
1961 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1962
1963         [ews-build] Add few bots to config.json
1964         https://bugs.webkit.org/show_bug.cgi?id=194304
1965
1966         Reviewed by Lucas Forschler.
1967
1968         * BuildSlaveSupport/ews-build/config.json:
1969
1970 2019-02-05  Keith Rollin  <krollin@apple.com>
1971
1972         Enable the automatic checking and regenerations of .xcfilelists during builds
1973         https://bugs.webkit.org/show_bug.cgi?id=194124
1974         <rdar://problem/47721277>
1975
1976         Reviewed by Tim Horton.
1977
1978         Bug 193790 add a facility for checking -- during build time -- that
1979         any needed .xcfilelist files are up-to-date and for updating them if
1980         they are not. This facility was initially opt-in by setting
1981         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1982         the process seemed robust. Its now time to enable this facility and
1983         make it opt-out. If there is a need to disable this facility, set and
1984         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1985         running `make` or `build-webkit`, or before running Xcode from the
1986         command line.
1987
1988         Additionally, remove the step that generates a list of source files
1989         going into the UnifiedSources build step. It's only necessarily to
1990         specify Sources.txt and SourcesCocoa.txt as inputs.
1991
1992         * Scripts/generate-xcfilelists:
1993
1994 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1995
1996         [GTK][WPE] force libpsl build to use ICU in jhbuild
1997         https://bugs.webkit.org/show_bug.cgi?id=194288
1998
1999         Reviewed by Philippe Normand.
2000
2001         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2002         This can cause build failures if libidn is detected but libunistring is not available.
2003
2004         Make sure that ICU is used for runtime and builtin PSL data.
2005
2006         * gtk/jhbuild.modules:
2007         * wpe/jhbuild.modules:
2008
2009 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2010
2011         [ews-app] Modified timestamp should be updated on updating data
2012         https://bugs.webkit.org/show_bug.cgi?id=194295
2013
2014         Reviewed by Lucas Forschler.
2015
2016         * BuildSlaveSupport/ews-app/ews/models/build.py:
2017         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2018         * BuildSlaveSupport/ews-app/ews/models/step.py:
2019
2020 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2021
2022         Unreviewed, rolling out r240742.
2023
2024         Causes crashes on iOS simulator.
2025
2026         Reverted changeset:
2027
2028         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2029         not focused in a content-editable element"
2030         https://bugs.webkit.org/show_bug.cgi?id=192824
2031         https://trac.webkit.org/changeset/240742
2032
2033 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2034
2035         run-webkit-tests emits message "...running None" when running tests
2036         https://bugs.webkit.org/show_bug.cgi?id=194133
2037         <rdar://problem/47724738>
2038
2039         Reviewed by Lucas Forschler.
2040
2041         * Scripts/webkitpy/xcode/device_type.py:
2042         (DeviceType.__str__): Use both version mapping tables and use just the variant
2043         name if no version name is available.
2044         * Scripts/webkitpy/xcode/device_type_unittest.py:
2045         (DeviceTypeTest):
2046         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2047         an associated named.
2048
2049 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2050
2051         [WPE] require python3-setuptools for meson build in jhbuild
2052         https://bugs.webkit.org/show_bug.cgi?id=194287
2053
2054         Reviewed by Philippe Normand.
2055
2056         python3-setuptools is needed to build meson in jhbuild.
2057         It is already required by the GTK port.
2058
2059         * wpe/install-dependencies:
2060
2061 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2062
2063         [ews-app] Add method to save BuilderMapping to database
2064         https://bugs.webkit.org/show_bug.cgi?id=194264
2065
2066         Reviewed by Lucas Forschler.
2067
2068         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2069         (BuilderMapping.__str__):
2070         (BuilderMapping):
2071         (BuilderMapping.save_mapping):
2072         (BuilderMapping.update_mapping):
2073         (BuilderMapping.get_existing_mapping):
2074         (BuilderMapping.is_valid_mapping):
2075
2076 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2077
2078         [ews-app] Add timestamp fields for BuilderMappings
2079         https://bugs.webkit.org/show_bug.cgi?id=194266
2080
2081         Reviewed by Lucas Forschler.
2082
2083         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2084         (BuilderMapping):
2085
2086 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2087
2088         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2089         https://bugs.webkit.org/show_bug.cgi?id=174816
2090
2091         Reviewed by Michael Catanzaro.
2092
2093         Add tests for webkit_uri_for_display().
2094
2095         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2096         (testURIForDisplayUnaffected):
2097         (testURIForDisplayAffected):
2098         (beforeAll):
2099         (afterAll):
2100         * TestWebKitAPI/glib/CMakeLists.txt:
2101
2102 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2103
2104         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2105         https://bugs.webkit.org/show_bug.cgi?id=194158
2106         <rdar://problem/47737268>
2107
2108         Rubber-stamped by Aakash Jain.
2109
2110         * Scripts/webkitpy/port/device_port.py:
2111         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2112
2113 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2114
2115         [CG] Enable setAdditionalSupportedImageTypes for WK1
2116         https://bugs.webkit.org/show_bug.cgi?id=194190
2117
2118         Reviewed by Tim Horton.
2119
2120         Add a test similar to the one under WebKit Cocoa but make it create a
2121         WebView instead of a WKWebView.
2122
2123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2124         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2125         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2126         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2127         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2128         (TestWebKitAPI::runTest):
2129         (TestWebKitAPI::TEST):
2130
2131 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2132
2133         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2134         https://bugs.webkit.org/show_bug.cgi?id=194168
2135
2136         Reviewed by Simon Fraser.
2137
2138         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2139
2140         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2141         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2142         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2143         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2144         (TEST):
2145         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2146         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2147
2148 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2149
2150         REGRESSION (r237269): webkit-patch what-broke is broken 
2151         https://bugs.webkit.org/show_bug.cgi?id=193025
2152
2153         Reviewed by Aakash Jain.
2154
2155         * Scripts/webkitpy/common/host.py:
2156         (Host.buildbot):
2157         (Host.bugzilla): Renamed to 'buildbot'.
2158
2159 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2160
2161         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2162         https://bugs.webkit.org/show_bug.cgi?id=194207
2163
2164         Reviewed by Tim Horton.
2165
2166         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2167         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2168         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2169         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2170         start and delete forwards to remove the original attachment.
2171
2172         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2173         (TestWebKitAPI::TEST):
2174
2175 2019-02-04  Youenn Fablet  <youenn@apple.com>
2176
2177         Capture state should be managed consistently when doing process swapping
2178         https://bugs.webkit.org/show_bug.cgi?id=194122
2179         <rdar://problem/47609293>
2180
2181         Reviewed by Eric Carlson.
2182
2183         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2184         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2185         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2186         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2187         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2188         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2189         (WTR::TestRunner::isDoingMediaCapture const):
2190         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2191         * WebKitTestRunner/TestController.cpp:
2192         (WTR::TestController::isDoingMediaCapture const):
2193         * WebKitTestRunner/TestController.h:
2194         * WebKitTestRunner/TestInvocation.cpp:
2195         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2196         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2197         (WTR::TestController::isDoingMediaCapture const):
2198
2199 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2200
2201         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2202         https://bugs.webkit.org/show_bug.cgi?id=194142
2203
2204         Reviewed by Ross Kirsling.
2205
2206         There three 'separator' variables in TestController.cpp. Renamed
2207         it 'pathSeparator', and unified them.
2208
2209         * WebKitTestRunner/TestController.cpp:
2210         (WTR::TestController::generateContextConfiguration const):
2211         (WTR::createTestURL):
2212         (WTR::TestController::platformAdjustContext):
2213
2214 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2215
2216         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2217         https://bugs.webkit.org/show_bug.cgi?id=194198
2218
2219         Reviewed by Antti Koivisto.
2220
2221         No need to set the banner heights on navigation now, since Page stores them.
2222
2223         * MiniBrowser/mac/WK2BrowserWindowController.m:
2224         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2225
2226 2019-02-03  John Wilander  <wilander@apple.com>
2227
2228         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2229         https://bugs.webkit.org/show_bug.cgi?id=194104
2230         <rdar://problem/47649991>
2231
2232         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2233
2234         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2235         (TestWebKitAPI::TEST):
2236             Changed numeric types from unsigned short to uint32_t.
2237
2238 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2239
2240         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2241         <https://webkit.org/b/194178>
2242         <rdar://problem/47753473>
2243
2244         Reviewed by Alexey Proskuryakov.
2245
2246         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2247         (WTR::uninstallFakeHelvetica): Pass nullptr into
2248         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2249
2250 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2251
2252         [LFC] Initialize ICB's style with fixed width/height.
2253         https://bugs.webkit.org/show_bug.cgi?id=194188
2254
2255         Reviewed by Antti Koivisto.
2256
2257         * LayoutReloaded/misc/LFC-passing-tests.txt:
2258
2259 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2260
2261         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2262         https://bugs.webkit.org/show_bug.cgi?id=194185
2263
2264         Reviewed by Antti Koivisto.
2265
2266         * LayoutReloaded/misc/LFC-passing-tests.txt:
2267
2268 2018-12-16  Darin Adler  <darin@apple.com>
2269
2270         Convert additional String::format clients to alternative approaches
2271         https://bugs.webkit.org/show_bug.cgi?id=192746
2272
2273         Reviewed by Alexey Proskuryakov.
2274
2275         * WebKitTestRunner/TestController.cpp:
2276         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2277         as an intermediate in code that ultimately constructs a WTF::String.
2278         (WTR::userMediaOriginHash): Use makeString.
2279         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2280         (WTR::TestController::didPerformClientRedirect): Ditto.
2281         (WTR::TestController::didPerformServerRedirect): Ditto.
2282         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2283
2284 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2285
2286         [ews-build] Add unit test to verify builder keys
2287         https://bugs.webkit.org/show_bug.cgi?id=194152
2288
2289         Reviewed by Lucas Forschler.
2290
2291         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2292         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2293
2294 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2295
2296         [LFC] Expand tests coverage (12 new tests -> 787)
2297
2298         Unreviewed test gardening.
2299
2300         * LayoutReloaded/misc/LFC-passing-tests.txt:
2301
2302 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2303
2304         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2305         https://bugs.webkit.org/show_bug.cgi?id=194163
2306
2307         Reviewed by Simon Fraser.
2308
2309         775
2310
2311         * LayoutReloaded/misc/LFC-passing-tests.txt:
2312
2313 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2314
2315         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2316         https://bugs.webkit.org/show_bug.cgi?id=194140
2317         <rdar://problem/47728098>
2318
2319         Reviewed by Tim Horton.
2320
2321         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2322         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2323         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2324
2325         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2326         test to induce an IPC deadlock when presenting a modal alert during touch start.
2327
2328         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2329         * WebKitTestRunner/TestController.cpp:
2330         (WTR::runJavaScriptAlert):
2331
2332         Add a client callback function for running JavaScript alerts.
2333
2334         (WTR::TestController::createOtherPage):
2335         (WTR::TestController::generateContextConfiguration const):
2336
2337         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2338         the fix in this patch.
2339
2340         (WTR::TestController::createWebViewWithOptions):
2341
2342         Plumb TestOptions to generateContextConfiguration.
2343
2344         (WTR::TestController::resetPreferencesToConsistentValues):
2345         (WTR::TestController::resetStateToConsistentValues):
2346         (WTR::updateTestOptionsFromTestHeader):
2347         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2348         (WTR::TestController::handleJavaScriptAlert):
2349         * WebKitTestRunner/TestController.h:
2350         * WebKitTestRunner/TestInvocation.cpp:
2351         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2352         * WebKitTestRunner/TestOptions.h:
2353         (WTR::TestOptions::hasSameInitializationOptions const):
2354
2355 2019-02-01  Chris Dumez  <cdumez@apple.com>
2356
2357         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2358         https://bugs.webkit.org/show_bug.cgi?id=193740
2359         <rdar://problem/47527267>
2360
2361         Reviewed by Alex Christensen.
2362
2363         Add API test coverage.
2364
2365         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2366
2367 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2368
2369         [ews-app] Add display name field to BuilderMapping model
2370         https://bugs.webkit.org/show_bug.cgi?id=194153
2371
2372         Reviewed by Lucas Forschler.
2373
2374         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2375         (BuilderMapping):
2376
2377 2019-02-01  Youenn Fablet  <youenn@apple.com>
2378
2379         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2380         https://bugs.webkit.org/show_bug.cgi?id=194155
2381
2382         Reviewed by Eric Carlson.
2383
2384         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2385         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2386         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2387
2388 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2389
2390         [LFC] Adjust replaced element's intrinsic ratio
2391         https://bugs.webkit.org/show_bug.cgi?id=194154
2392
2393         Reviewed by Antti Koivisto.
2394
2395         761
2396
2397         * LayoutReloaded/misc/LFC-passing-tests.txt:
2398
2399 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2400
2401         [WPE] Show test results in minibrowser
2402         https://bugs.webkit.org/show_bug.cgi?id=194150
2403
2404         Reviewed by Žan Doberšek.
2405
2406         * Scripts/webkitpy/port/wpe.py:
2407         (WPEPort.show_results_html_file):
2408
2409 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2410
2411         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2412         https://bugs.webkit.org/show_bug.cgi?id=194151
2413
2414         Reviewed by Žan Doberšek.
2415
2416         ALT + <- go back
2417         ALT + -> go forward
2418
2419         * MiniBrowser/wpe/main.cpp:
2420         (main):
2421
2422 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2423
2424         [LFC] Set intrinsic size on Layout::Replaced
2425         https://bugs.webkit.org/show_bug.cgi?id=194139
2426
2427         Reviewed by Antti Koivisto.
2428
2429         744
2430
2431         * LayoutReloaded/misc/LFC-passing-tests.txt:
2432
2433 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2434
2435         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2436         https://bugs.webkit.org/show_bug.cgi?id=194146
2437
2438         Reviewed by Xabier Rodriguez-Calvar.
2439
2440         It allows to open relative paths.
2441
2442         * MiniBrowser/wpe/main.cpp:
2443         (main):
2444
2445 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2446
2447         Update flakiness dashboard configuration after recent queue changes
2448         https://bugs.webkit.org/show_bug.cgi?id=194127
2449
2450         Rubber-stamped by Aakash Jain.
2451
2452         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2453
2454         * TestResultServer/static-dashboards/builders.jsonp:
2455
2456 2019-01-31  Youenn Fablet  <youenn@apple.com>
2457
2458         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2459         https://bugs.webkit.org/show_bug.cgi?id=194106
2460         <rdar://problem/47676333>
2461
2462         Reviewed by Ryosuke Niwa.
2463
2464         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2465         (TestWebKitAPI::didFinishNavigation):
2466         (TestWebKitAPI::TEST):
2467         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2468
2469 2019-01-31  Chris Dumez  <cdumez@apple.com>
2470
2471         Page zoom level is lost after a process swap or a crash
2472         https://bugs.webkit.org/show_bug.cgi?id=194105
2473         <rdar://problem/47610781>
2474
2475         Reviewed by Alex Christensen.
2476
2477         Add API test coverage.
2478
2479         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2480         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2481
2482 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2483
2484         Revert r238819 which is unneeded and caused a performance regression.
2485         https://bugs.webkit.org/show_bug.cgi?id=192272
2486         <rdar://problem/46664625>
2487
2488         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2489         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2490         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2491
2492 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2493
2494         Formalize WebKitAdditions mechanism of LoadOptimizer
2495         https://bugs.webkit.org/show_bug.cgi?id=193886
2496         <rdar://problem/47696809>
2497
2498         Reviewed by Brent Fulgham.
2499
2500         * MiniBrowser/MiniBrowser.entitlements:
2501         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2502
2503 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2504
2505         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2506         https://bugs.webkit.org/show_bug.cgi?id=194090
2507
2508         Reviewed by Antti Koivisto.
2509
2510         * LayoutReloaded/misc/LFC-passing-tests.txt:
2511
2512 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2513
2514         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2515         https://bugs.webkit.org/show_bug.cgi?id=194074
2516
2517         Reviewed by Antti Koivisto.
2518
2519         * LayoutReloaded/misc/LFC-passing-tests.txt:
2520
2521 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2522
2523         [LFC][BFC] Add support for block level replaced box.
2524         https://bugs.webkit.org/show_bug.cgi?id=194071
2525
2526         Reviewed by Antti Koivisto.
2527
2528         * LayoutReloaded/misc/LFC-passing-tests.txt:
2529
2530 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2531
2532         Fix WebKitTestRunner's testPath with Windows full paths
2533         https://bugs.webkit.org/show_bug.cgi?id=194012
2534
2535         Reviewed by Alex Christensen.
2536
2537         updateTestOptionsFromTestHeader failed to open test files because
2538         testPath returned wrong file paths. It returned a path "/C:/..."
2539         if a URL "file:///C:/..." was given.
2540
2541         * WebKitTestRunner/TestController.cpp:
2542         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2543
2544 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2545
2546         [WPE] Bump font related dependencies to match the GTK+ port
2547         https://bugs.webkit.org/show_bug.cgi?id=194017
2548
2549         Reviewed by Žan Doberšek.
2550
2551         * wpe/jhbuild.modules:
2552         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2553         * wpe/patches/icudata-stdlibs.patch: Added.
2554
2555 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2556
2557         Enable swipe tests on iOS
2558         https://bugs.webkit.org/show_bug.cgi?id=194076
2559
2560         Reviewed by Geoffrey Garen.
2561
2562         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2563         it causes a debug assertion failure in runUIScript.
2564
2565         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2566         (WTR::UIScriptController::beginBackSwipe):
2567         (WTR::UIScriptController::completeBackSwipe):
2568
2569 2019-01-30  Keith Rollin  <krollin@apple.com>
2570
2571         Use correct printf format specifier
2572         https://bugs.webkit.org/show_bug.cgi?id=194062
2573         <rdar://problem/47686167>
2574
2575         Reviewed by Alexey Proskuryakov.
2576
2577         LayoutTestSpellChecker.mm is trying to format a variable of type
2578         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2579         actually an unsigned long long. Fix this by formatting with %llu.
2580
2581         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2582         (-[LayoutTestTextCheckingResult description]):
2583
2584 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2585
2586         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2587         https://bugs.webkit.org/show_bug.cgi?id=193979
2588
2589         Reviewed by Wenson Hsieh.
2590
2591         Fix the test for iOS. Make the test work with iOS UA string.
2592
2593         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2594
2595 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2596
2597         Replace High Sierra LLINT CLoop bot due to hardware failure
2598         https://bugs.webkit.org/show_bug.cgi?id=194066
2599
2600         Reviewed by Aakash Jain.
2601
2602         * BuildSlaveSupport/build.webkit.org-config/config.json:
2603
2604 2019-01-30  Keith Rollin  <krollin@apple.com>
2605
2606         [NSDragItem init] is unavailable
2607         https://bugs.webkit.org/show_bug.cgi?id=194059
2608         <rdar://problem/47685715>
2609
2610         Reviewed by Wenson Hsieh.
2611
2612         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2613         DumpRenderTree and TestWebKitAPI, which both try to create an
2614         NSDragItem in a manner that invokes this method. Address this by using
2615         -initWithPasteboardWriter instead.
2616
2617         Note that the parameter passed to initWithPasteboardWriter is likely
2618         incorrect. In both cases, the object passed does not conform to
2619         NSPasteboardWriting. However, with this fix, we're no worse off than
2620         before, and can now perform builds with newer compilers and SDKs until
2621         a real fix can be crafted. That work is tracked in
2622         https://bugs.webkit.org/show_bug.cgi?id=194060
2623
2624         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2625         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2626         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2627         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2628
2629 2019-01-30  Daniel Bates  <dabates@apple.com>
2630
2631         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2632         https://bugs.webkit.org/show_bug.cgi?id=192824
2633         <rdar://problem/47100332>
2634
2635         Reviewed by Wenson Hsieh.
2636
2637         Fix a bug where the wrong usage code was used for F13 thru F24.
2638
2639         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2640         (keyCodeForDOMFunctionKey):
2641
2642 2019-01-30  Chris Dumez  <cdumez@apple.com>
2643
2644         Regression(PSON) Load hang can occur on history navigation
2645         https://bugs.webkit.org/show_bug.cgi?id=194030
2646         <rdar://problem/47656939>
2647
2648         Reviewed by Antti Koivisto.
2649
2650         Add API test coverage.
2651
2652         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2653
2654 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2655
2656         [LFC] Expand tests coverage.
2657
2658         Unreviewed test gardening.
2659
2660         * LayoutReloaded/misc/LFC-passing-tests.txt:
2661
2662 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2663
2664         [Flatpak] Add openjpeg support
2665         https://bugs.webkit.org/show_bug.cgi?id=194019
2666
2667         Reviewed by Michael Catanzaro.
2668
2669         * flatpak/org.webkit.CommonModules.yaml:
2670
2671 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2672
2673         Unreviewed, rolling out r240708.
2674         https://bugs.webkit.org/show_bug.cgi?id=194022
2675
2676         It broke WPE build (Requested by KaL on #webkit).
2677
2678         Reverted changeset:
2679
2680         "[WPE] Bump font related dependencies to match the GTK+ port"
2681         https://bugs.webkit.org/show_bug.cgi?id=194017
2682         https://trac.webkit.org/changeset/240708
2683
2684 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2685
2686         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2687         https://bugs.webkit.org/show_bug.cgi?id=194001
2688
2689         Reviewed by Antti Koivisto.
2690
2691         * LayoutReloaded/misc/LFC-passing-tests.txt:
2692
2693 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2694
2695         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2696         https://bugs.webkit.org/show_bug.cgi?id=194020
2697
2698         Reviewed by Antti Koivisto.
2699
2700         * LayoutReloaded/misc/LFC-passing-tests.txt:
2701
2702 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2703
2704         AX: Support color well on iOS
2705         https://bugs.webkit.org/show_bug.cgi?id=194010
2706
2707         Reviewed by Joanmarie Diggs.
2708
2709         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2710         (WTR::AccessibilityUIElement::stringAttributeValue):
2711
2712 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2713
2714         [WPE] Bump font related dependencies to match the GTK+ port
2715         https://bugs.webkit.org/show_bug.cgi?id=194017
2716
2717         Reviewed by Žan Doberšek.
2718
2719         * wpe/jhbuild.modules:
2720         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2721         * wpe/patches/icudata-stdlibs.patch: Added.
2722
2723 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2724
2725         [Mac] Update window scale API usage
2726         https://bugs.webkit.org/show_bug.cgi?id=193991
2727         rdar://problem/47614795
2728
2729         Reviewed by Tim Horton.
2730
2731         * DumpRenderTree/mac/DumpRenderTree.mm:
2732         (changeWindowScaleIfNeeded):
2733         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2734         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2735         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2736
2737 2019-01-29  Chris Dumez  <cdumez@apple.com>
2738
2739         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2740         https://bugs.webkit.org/show_bug.cgi?id=193977
2741         <rdar://problem/47643716>
2742
2743         Reviewed by Geoff Garen.
2744
2745         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2746         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2747         to the previous provisional committing *before* we make the last load. 
2748
2749         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2750
2751 2019-01-29  Youenn Fablet  <youenn@apple.com>
2752
2753         Adopt new SPI to evaluate server certificate trust
2754         https://bugs.webkit.org/show_bug.cgi?id=193355
2755
2756         Reviewed by Alex Christensen.
2757
2758         Add infrastructure to handle HTTPS server trust evaluation testing.
2759
2760         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2761         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2762         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2763         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2764         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2765         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2766         * WebKitTestRunner/TestController.cpp:
2767         (WTR::TestController::resetPreferencesToConsistentValues):
2768         (WTR::TestController::didReceiveAuthenticationChallenge):
2769         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2770         * WebKitTestRunner/TestController.h:
2771         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2772         * WebKitTestRunner/TestInvocation.cpp:
2773         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2774         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2775         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2776
2777 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2778
2779         [ews-build] Add build step to print bot Configuration
2780         https://bugs.webkit.org/show_bug.cgi?id=193887
2781
2782         Reviewed by Lucas Forschler.
2783
2784         * BuildSlaveSupport/ews-build/steps.py:
2785         (PrintConfiguration): Build step to print configuration.
2786         * BuildSlaveSupport/ews-build/factories.py:
2787
2788 2019-01-29  Chris Dumez  <cdumez@apple.com>
2789
2790         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2791         https://bugs.webkit.org/show_bug.cgi?id=193967
2792         <rdar://problem/47635348>
2793
2794         Reviewed by Alex Christensen.
2795
2796         Add API test coverage.
2797
2798         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2799         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2800
2801 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2802
2803         [ews-app] Handle incoming results data
2804         https://bugs.webkit.org/show_bug.cgi?id=193973
2805
2806         Reviewed by Lucas Forschler.
2807
2808         * BuildSlaveSupport/ews-app/ews/views/results.py:
2809
2810 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2811
2812         [ews-app] Make the results url generic
2813         https://bugs.webkit.org/show_bug.cgi?id=193928
2814
2815         Reviewed by Lucas Forschler.
2816
2817         * BuildSlaveSupport/ews-app/ews/urls.py:
2818
2819 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2820
2821         [ews-build] Configure buildbot to send events to ews-app
2822         https://bugs.webkit.org/show_bug.cgi?id=193968
2823
2824         Reviewed by Lucas Forschler.
2825
2826         * BuildSlaveSupport/ews-build/events.py: Added.
2827         * BuildSlaveSupport/ews-build/master.cfg:
2828
2829 2019-01-29  Keith Rollin  <krollin@apple.com>
2830
2831         Add .xcfilelists to Run Script build phases
2832         https://bugs.webkit.org/show_bug.cgi?id=193792
2833         <rdar://problem/47201785>
2834
2835         Reviewed by Alex Christensen.
2836
2837         As part of supporting XCBuild, update the necessary Run Script build
2838         phases in their Xcode projects to refer to their associated
2839         .xcfilelist files.
2840
2841         Note that the addition of these files bumps the Xcode project version
2842         number to something that's Xcode 10 compatible. This change means that
2843         older versions of the Xcode IDE can't read these projects. Nor can it
2844         fully load workspaces that refer to these projects (the updated
2845         projects are shown as non-expandable placeholders). `xcodebuild` can
2846         still build these projects; it's just that the IDE can't open them.
2847
2848         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2849         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2850
2851 2019-01-29  John Wilander  <wilander@apple.com>
2852
2853         Add data abstraction and validation for Ad Click Attribution
2854         https://bugs.webkit.org/show_bug.cgi?id=193916
2855         <rdar://problem/47603481>
2856
2857         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2858
2859         Ad click attribution has two steps. First, the storage of an ad
2860         campaign ID for a click that takes the user to a destination
2861         site. Second, a conversion on the destination site that can be
2862         attributed to the ad click.
2863
2864         This patch adds a class that represents a request for ad click
2865         attribution. Validation makes sure that the bits of entropy
2866         reported through this mechanism is limited.
2867
2868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2869         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2870         (TestWebKitAPI::TEST):
2871
2872 2019-01-29  Chris Dumez  <cdumez@apple.com>
2873
2874         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2875         https://bugs.webkit.org/show_bug.cgi?id=193932
2876         <rdar://problem/47598947>
2877
2878         Reviewed by Brady Eidson.
2879
2880         Add API test coverage.
2881
2882         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2883
2884 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2885
2886         Adding new passing LFC tests.
2887
2888         Unreviewed test gardening.
2889
2890         * LayoutReloaded/misc/LFC-passing-tests.txt:
2891
2892 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2893
2894         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2895         https://bugs.webkit.org/show_bug.cgi?id=193964
2896
2897         Reviewed by Antti Koivisto.
2898
2899         * LayoutReloaded/misc/LFC-passing-tests.txt:
2900
2901 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2902
2903         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2904         https://bugs.webkit.org/show_bug.cgi?id=193954
2905
2906         Reviewed by Antti Koivisto.
2907
2908         * LayoutReloaded/misc/LFC-passing-tests.txt:
2909
2910 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2911
2912         WebDriver: add support for running subtests
2913         https://bugs.webkit.org/show_bug.cgi?id=193904
2914
2915         Reviewed by Michael Catanzaro.
2916
2917         pytest already supports it by passing test.py::subtest, so we can do the same.
2918
2919         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2920         (get_item_name): Made this global.
2921         (CollectRecorder.__init__): Receive the parameter to ignore.
2922         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2923         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2924         (collect): Add parameter to ignore.
2925         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2926         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2927         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2928         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2929         (WebDriverTestRunnerSelenium.run): Ditto.
2930         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2931         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2932         (WebDriverTestRunnerW3C.run): Ditto.
2933
2934 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2935
2936         User agent string override for navigator.userAgent should be site specific quirks
2937         https://bugs.webkit.org/show_bug.cgi?id=193950
2938
2939         Reviewed by Brent Fulgham.
2940
2941         Updated per the _WKWebsitePolicies rename.
2942
2943         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2944         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2945
2946 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2947
2948         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2949         https://bugs.webkit.org/show_bug.cgi?id=193941
2950
2951         Reviewed by Alex Christensen.
2952
2953         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2954         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2955         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2956         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2957         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2958         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2959         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2960         * TestWebKitAPI/Tests/WTF/Time.cpp:
2961         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2962         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2963         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2964         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2965
2966 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2967
2968         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2969
2970         * Scripts/webkitpy/common/config/contributors.json:
2971
2972 2019-01-28  Andy Estes  <aestes@apple.com>
2973
2974         [watchOS] Enable Parental Controls content filtering
2975         https://bugs.webkit.org/show_bug.cgi?id=193939
2976         <rdar://problem/46641912>
2977
2978         Reviewed by Ryosuke Niwa.
2979
2980         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2981
2982 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2983
2984         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2985         <https://webkit.org/b/193884>
2986
2987         Reviewed by Jiewen Tan.
2988
2989         * Scripts/webkitpy/style/checkers/cpp.py:
2990         (check_language): Add LocalAuthentication to
2991         `frameworks_with_soft_links`.
2992
2993 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2994
2995         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2996         https://bugs.webkit.org/show_bug.cgi?id=193891
2997
2998         Reviewed by Ross Kirsling.
2999
3000         There were three problems in window sizes of WebView and the host window.
3001         1. The sizes of pixel image output were incorrect.
3002         2. The host window is going to appear after window.resize was invoked.
3003         3. window.resize resized only the host window, not WebView.
3004
3005         This change solves them with a following approach.
3006         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3007         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3008            as well as DumpRenderTree in order to match the client area and the window area.
3009         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3010         d. PlatformWebView::setWindowFrame changes both window sizes.
3011         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3012
3013         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3014         (WTR::PlatformWebView::PlatformWebView): Create the host window
3015         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3016         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3017         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3018
3019 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3020
3021         [ews-app] Add method to save Step data to database
3022         https://bugs.webkit.org/show_bug.cgi?id=193890
3023
3024         Reviewed by Lucas Forschler.
3025
3026         * BuildSlaveSupport/ews-app/ews/models/step.py:
3027         (Step.save_step): Method to save step data.
3028         (Step.update_step): Method to update step data.
3029         (Step.get_existing_step): Method to fetch existing step from database.
3030         (Step.is_valid_result): Method to validate valid step result.
3031
3032 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3033
3034         [ews-app] Add method to save Build data to database
3035         https://bugs.webkit.org/show_bug.cgi?id=193735
3036
3037         Reviewed by Lucas Forschler.
3038
3039         * BuildSlaveSupport/ews-app/ews/models/build.py:
3040         (Build.save_build): Method to save build information to database.
3041         (Build.get_existing_build): Method to fetch existing build from database.
3042         (Build.is_valid_result): Method to validate build result.
3043         * BuildSlaveSupport/ews-app/ews/common/util.py:
3044         (is_valid_int_id): Method to validate valid id.
3045
3046 2019-01-28  Chris Dumez  <cdumez@apple.com>
3047
3048         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3049         https://bugs.webkit.org/show_bug.cgi?id=193915
3050         <rdar://problem/47560907>
3051
3052         Reviewed by Alex Christensen.
3053
3054         Add API test coverage.
3055
3056         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3057
3058 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3059
3060         [ews-app] Rename id variables
3061         https://bugs.webkit.org/show_bug.cgi?id=193883
3062
3063         Reviewed by Lucas Forschler.
3064
3065         * BuildSlaveSupport/ews-app/ews/models/build.py:
3066         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3067         * BuildSlaveSupport/ews-app/ews/models/step.py:
3068         * BuildSlaveSupport/ews-app/ews/urls.py:
3069         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3070         * BuildSlaveSupport/ews-app/ews/views/results.py:
3071         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3072
3073 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3074
3075         [ews-app] Allow certain fields to be empty
3076         https://bugs.webkit.org/show_bug.cgi?id=193892
3077
3078         Reviewed by Lucas Forschler.
3079
3080         * BuildSlaveSupport/ews-app/ews/models/build.py:
3081         * BuildSlaveSupport/ews-app/ews/models/step.py:
3082
3083 2019-01-28  Rob Buis  <rbuis@igalia.com>
3084
3085         Update MIME type parser
3086         https://bugs.webkit.org/show_bug.cgi?id=180526
3087
3088         Reviewed by Frédéric Wang.
3089
3090         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3091         (TestWebKitAPI::TEST):
3092
3093 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3094
3095         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3096         https://bugs.webkit.org/show_bug.cgi?id=193896
3097
3098         Reviewed by Antti Koivisto.
3099
3100         * LayoutReloaded/misc/LFC-passing-tests.txt:
3101
3102 2018-12-15  Darin Adler  <darin@apple.com>
3103
3104         Replace many uses of String::format with more type-safe alternatives
3105         https://bugs.webkit.org/show_bug.cgi?id=192742
3106
3107         Reviewed by Mark Lam.
3108
3109         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3110         (WTR::cacheTestRunnerCallback): Use makeString.
3111         * WebKitTestRunner/TestController.cpp:
3112         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3113         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3114
3115 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3116
3117         Use a load optimizer for some sites
3118         https://bugs.webkit.org/show_bug.cgi?id=193881
3119         <rdar://problem/46325455>
3120
3121         Reviewed by Brent Fulgham.
3122
3123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3124         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3125
3126 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3127
3128         AX: Introduce a static accessibility tree
3129         https://bugs.webkit.org/show_bug.cgi?id=193348
3130         <rdar://problem/47203295>
3131
3132         Reviewed by Ryosuke Niwa.
3133
3134         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3135
3136 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3137
3138         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3139         https://bugs.webkit.org/show_bug.cgi?id=193867
3140
3141         Reviewed by Antti Koivisto.
3142
3143         * LayoutReloaded/misc/LFC-passing-tests.txt:
3144
3145 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3146
3147         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3148         https://bugs.webkit.org/show_bug.cgi?id=193865
3149
3150         Reviewed by Antti Koivisto.
3151
3152         * LayoutReloaded/misc/LFC-passing-tests.txt:
3153
3154 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3155
3156         Need a mechanism to override navigator.userAgent
3157         https://bugs.webkit.org/show_bug.cgi?id=193762
3158         <rdar://problem/47504939>
3159
3160         Reviewed by Brent Fulgham.
3161
3162         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3163
3164         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3165         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3166         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3167
3168 2019-01-25  Dean Jackson  <dino@apple.com>
3169
3170         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3171         https://bugs.webkit.org/show_bug.cgi?id=193831
3172         <rdar://problem/47399263>
3173
3174         Reviewed by Chris Dumez.
3175
3176         Two new tests that exercise cross-origin and same-origin System
3177         Previews.
3178
3179         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3180
3181 2019-01-25  Keith Rollin  <krollin@apple.com>
3182
3183         Update Xcode projects with "Check .xcfilelists" build phase
3184         https://bugs.webkit.org/show_bug.cgi?id=193790
3185         <rdar://problem/47201374>
3186
3187         Reviewed by Alex Christensen.
3188
3189         Support for XCBuild includes specifying inputs and outputs to various
3190         Run Script build phases. These inputs and outputs are specified as
3191         .xcfilelist files. Once created, these .xcfilelist files need to be
3192         kept up-to-date. In order to check that they are up-to-date or not,
3193         add an Xcode build step that invokes an external script that performs
3194         the checking. If the .xcfilelists are found to be out-of-date, update
3195         them, halt the build, and instruct the developer to restart the build
3196         with up-to-date files.
3197
3198         At this time, the checking and regenerating is performed only if the
3199         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3200         who want to use this facility can set this variable and test out the
3201         checking/regenerating. Once it seems like there are no egregious
3202         issues that upset a developer's workflow, we'll unconditionally enable
3203         this facility.
3204
3205         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3206         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3207         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3208         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3209
3210 2019-01-25  Keith Rollin  <krollin@apple.com>
3211
3212         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3213         https://bugs.webkit.org/show_bug.cgi?id=193781
3214         <rdar://problem/47201153>
3215
3216         Reviewed by Alex Christensen.
3217
3218         Part of generating the .xcfilelists used as part of adopting XCBuild
3219         includes running `make DerivedSources.make` from a standalone script.
3220         It’s important for this invocation to have the same environment as
3221         when the actual build invokes `make DerivedSources.make`. If the
3222         environments are different, then the two invocations will provide
3223         different results. In order to get the same environment in the
3224         standalone script, have the script launch xcodebuild targeting the
3225         "Apply Configuration to XCFileLists" build target, which will then
3226         re-invoke our standalone script. The script is now running again, this
3227         time in an environment with all workspace, project, target, xcconfig
3228         and other environment variables established.
3229
3230         The "Apply Configuration to XCFileLists" build target accomplishes
3231         this task via a small embedded shell script that consists only of:
3232
3233             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3234
3235         The process that invokes "Apply Configuration to XCFileLists" first
3236         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3237         evaluated and exports it into the shell environment. When xcodebuild
3238         is invoked, it inherits the value of this variable and can `eval` the
3239         contents of that variable. Our external standalone script can then set
3240         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3241         of command-line parameters needed to restart itself in the appropriate
3242         state.
3243
3244         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3245         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3246
3247 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3248
3249         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3250         https://bugs.webkit.org/show_bug.cgi?id=193802
3251         <rdar://problem/46010580>
3252
3253         Reviewed by Andy Estes.
3254
3255         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3256         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3257         (TEST):
3258
3259 2019-01-25  Daniel Bates  <dabates@apple.com>
3260
3261         [iOS] uiController.keyDown() does not translate Control modified key
3262         https://bugs.webkit.org/show_bug.cgi?id=192898
3263
3264         Reviewed by Wenson Hsieh.
3265
3266         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3267         key translation, as applicable. Among other cases, key translation occurs when performing
3268         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3269         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3270         human pressing down and releasing key(s) using a hardware keyboard.
3271
3272         * WebKitTestRunner/ios/HIDEventGenerator.h:
3273         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3274         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3275
3276         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3277         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3278         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3279         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3280         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3281         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3282         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3283         (-[HIDEventGenerator longPress:completionBlock:]):
3284         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3285         Update code for above renaming.
3286
3287         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3288         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3289
3290         (-[HIDEventGenerator keyDown:]): Added.
3291         (-[HIDEventGenerator keyUp:]): Added.
3292         (-[HIDEventGenerator keyPress:completionBlock:]):
3293         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3294         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3295         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3296         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3297         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3298         (WTR::parseModifier): Deleted.
3299
3300 2019-01-25  Keith Rollin  <krollin@apple.com>
3301
3302         Complete the implementation of generate-xcfilelists
3303         https://bugs.webkit.org/show_bug.cgi?id=193782
3304
3305         Reviewed by Alex Christensen.
3306
3307         A preliminary version of generate-xcfilelists was added in r238008.
3308         This patch updates that script in order to:
3309
3310         - Support checking of .xcfilelists
3311         - Perform better execution of `make DerivedSources.make` by
3312           relaunching generate-xcfilelists under xcodebuild
3313         - Support incremental generation and checking of .xcfilelists
3314         - Support supplementary .xcfilelists files from WebKitAdditions
3315         - Support being wrapped by parallel version of generate-xcfilelists in
3316           Internal that adds support for (re)generating WebKit projects in
3317           that repo.
3318         - Support builds that have been performed in WebKitBuild as well as
3319           ~/Library/Developer/code/DerivedData
3320         - Increase robustness and debugging facilities.
3321
3322         * Scripts/generate-xcfilelists:
3323
3324 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3325
3326         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3327         https://bugs.webkit.org/show_bug.cgi?id=193297
3328         <rdar://problem/47158841>
3329
3330         Unreviewed test case fix.
3331
3332         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3333         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3334
3335         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3336         (TEST):
3337
3338 2019-01-25  Keith Rollin  <krollin@apple.com>
3339
3340         Update existing .xcfilelists
3341         https://bugs.webkit.org/show_bug.cgi?id=193791
3342         <rdar://problem/47201706>
3343
3344         Reviewed by Alex Christensen.
3345
3346         Many .xcfilelist files were added in r238824 in order to support
3347         XCBuild. Update these with recent changes to the set of build files
3348         and with the current generate-xcfilelist script.
3349
3350         * DumpRenderTree/DerivedSources-input.xcfilelist:
3351         * DumpRenderTree/DerivedSources-output.xcfilelist:
3352         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3353         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3354
3355 2019-01-25  Keith Rollin  <krollin@apple.com>
3356
3357         Fix missing dependencies in extract-dependencies-from-makefile
3358         https://bugs.webkit.org/show_bug.cgi?id=193783
3359         <rdar://problem/47201571>
3360
3361         Reviewed by Alex Christensen.
3362
3363         The extract-dependencies-from-makefile script generates .xcfilelists
3364         for XCBuild by invoking a makefile in --debug mode, parsing the
3365         dependency information in the output, and extracting information
3366         regarding targets and dependents. However, the way `make` emits this
3367         dependency information is not rigorous, and so we need to determine
3368         what lines to look for and parse by trial and error. This approach
3369         didn't coriginally atch all the information we needed to collect, so
3370         update the script to look for the additional lines we now know to look
3371         for.
3372
3373         * Scripts/extract-dependencies-from-makefile:
3374         (Parser):
3375         (Parser.addTarget):
3376         (Parser.addPrereq):
3377         (Parser.doParse):
3378
3379 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3380
3381         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3382         https://bugs.webkit.org/show_bug.cgi?id=193297
3383         <rdar://problem/47158841>
3384
3385         Reviewed by Alex Christensen.
3386
3387         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3388             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3389         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3390         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3391         activating the message used to trigger the callback when it is set.
3392
3393 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3394
3395         WKWebView.goBack should reload if there is a safe browsing warning
3396         https://bugs.webkit.org/show_bug.cgi?id=193805
3397         <rdar://problem/46908216>
3398
3399         Reviewed by Geoff Garen.
3400
3401         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3402         (+[Simple3LookupContext sharedLookupContext]):
3403         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3404         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3405         (TEST):
3406
3407 2019-01-25  Chris Dumez  <cdumez@apple.com>
3408
3409         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3410         https://bugs.webkit.org/show_bug.cgi?id=193788
3411         <rdar://problem/47531231>
3412
3413         Reviewed by Alex Christensen.
3414
3415         Add API test coverage.
3416
3417         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3418         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3419
3420 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3421
3422         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3423         https://bugs.webkit.org/show_bug.cgi?id=193771
3424
3425         Unreviewed infrastructure fix.
3426
3427         * Scripts/webkitpy/port/darwin.py:
3428         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3429
3430 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3431
3432         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3433
3434 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3435
3436         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3437
3438         * Scripts/webkitpy/common/config/contributors.json:
3439
3440 2019-01-25  Chris Dumez  <cdumez@apple.com>
3441
3442         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3443         https://bugs.webkit.org/show_bug.cgi?id=193779
3444         <rdar://problem/46170903>
3445
3446         Reviewed by Antti Koivisto.
3447
3448         Add API test that quickly navigates forward to a previous process without waiting for it to
3449         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3450         the process' previous page when reconnecting the it for the forward navigation.
3451
3452         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3453
3454 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3455
3456         Need a way for JavaScript (or bundle) code to participate in undo
3457         https://bugs.webkit.org/show_bug.cgi?id=190009
3458         <rdar://problem/44807048>
3459
3460         Reviewed by Ryosuke Niwa.
3461
3462         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3463         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3464
3465         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3466         (WTR::UIScriptController::lastUndoLabel const):
3467         (WTR::UIScriptController::firstRedoLabel const):
3468         (WTR::UIScriptController::platformUndoManager const):
3469         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3470         (WTR::UIScriptController::lastUndoLabel const):
3471         (WTR::UIScriptController::firstRedoLabel const):
3472         (WTR::UIScriptController::platformUndoManager const):
3473         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3474         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3475         (WTR::UIScriptController::lastUndoLabel const):
3476         (WTR::UIScriptController::firstRedoLabel const):
3477         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3478         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3479         (WTR::UIScriptController::lastUndoLabel const):
3480         (WTR::UIScriptController::firstRedoLabel const):
3481         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3482         (WTR::UIScriptController::platformUndoManager const):
3483         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3484         (WTR::UIScriptController::platformUndoManager const):
3485
3486 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3487
3488         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3489         https://bugs.webkit.org/show_bug.cgi?id=193824
3490
3491         Reviewed by Antti Koivisto.
3492
3493         * LayoutReloaded/misc/LFC-passing-tests.txt:
3494
3495 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3496
3497         Update macOS JSC bot configurations
3498         https://bugs.webkit.org/show_bug.cgi?id=193739
3499
3500         Reviewed by Alexey Proskuryakov.
3501
3502         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3503         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3504         (BubbleQueueServer): Move JSC EWS to Mojave section.
3505         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3506         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3507         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3508
3509 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3510
3511         [Win][WebKitTestRunner] Implement EventSenderProxy
3512         https://bugs.webkit.org/show_bug.cgi?id=193755
3513
3514         Reviewed by Don Olmstead.
3515
3516         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3517         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3518         (WTR::EventSenderProxy::dispatchMessage):
3519         (WTR::EventSenderProxy::EventSenderProxy):
3520         (WTR::EventSenderProxy::mouseDown):
3521         (WTR::EventSenderProxy::mouseUp):
3522         (WTR::EventSenderProxy::mouseMoveTo):
3523         (WTR::EventSenderProxy::mouseScrollBy):
3524         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3525
3526 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3527
3528         Unreviewed fix for API test failure after r240437.
3529
3530         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3531
3532         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3533
3534 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3535
3536         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3537         https://bugs.webkit.org/show_bug.cgi?id=193787
3538         <rdar://problem/47497634>
3539
3540         Reviewed by Alexey Proskuryakov.
3541
3542         * Scripts/webkitdirs.pm:
3543         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3544
3545 2019-01-24  Truitt Savell  <tsavell@apple.com>
3546
3547         Unreviewed, rolling out r240446.
3548
3549         Casued 5 API failures
3550
3551         Reverted changeset:
3552
3553         "Activate the WebResourceLoadStatisticsStore in the
3554         NetworkProcess and deactivate it in the UIProcess."
3555         https://bugs.webkit.org/show_bug.cgi?id=193297
3556         https://trac.webkit.org/changeset/240446
3557
3558 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3559
3560         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3561         https://bugs.webkit.org/show_bug.cgi?id=193741
3562         <rdar://problem/47135030>
3563
3564         Reviewed by Antti Koivisto and Simon Fraser.
3565
3566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3567         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3568         (TestWebKitAPI::TEST):
3569
3570 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3571
3572         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3573         https://bugs.webkit.org/show_bug.cgi?id=193297
3574         <rdar://problem/47158841>
3575
3576         Reviewed by Alex Christensen.
3577
3578         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3579         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3580         activating the message used to trigger the callback when it is set.
3581
3582 2019-01-24  John Wilander  <wilander@apple.com>
3583
3584         Add Ad Click Attribution as an internal/experimental feature
3585         https://bugs.webkit.org/show_bug.cgi?id=193685
3586         <rdar://problem/47450399>
3587
3588         Reviewed by Brent Fulgham.
3589
3590         Added test option adClickAttributionEnabled.
3591
3592         * DumpRenderTree/TestOptions.cpp:
3593         (TestOptions::TestOptions):
3594         * DumpRenderTree/TestOptions.h:
3595         * DumpRenderTree/mac/DumpRenderTree.mm:
3596         (setWebPreferencesForTestOptions):
3597
3598 2019-01-24  Antti Koivisto  <antti@apple.com>
3599
3600         [PSON] Flash on back navigation on Mac
3601         https://bugs.webkit.org/show_bug.cgi?id=193716
3602         <rdar://problem/47148458>
3603
3604         Reviewed by Chris Dumez.
3605
3606         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3607
3608         Closing of the previous page is delayed so waiting for didFinishNavigation is
3609         not sufficient to guarantee we have received all the messages. Wait for them.
3610
3611 2019-01-24  Chris Dumez  <cdumez@apple.com>
3612
3613         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3614         https://bugs.webkit.org/show_bug.cgi?id=193761
3615         <rdar://problem/47456405>
3616
3617         Reviewed by Alex Christensen.
3618
3619         Add API test coverage.
3620
3621         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3622
3623 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3624
3625         webkitpy: Missing PID in crashlog name should not be fatal
3626         https://bugs.webkit.org/show_bug.cgi?id=193771
3627
3628         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3629         of raising an exception.
3630
3631         Reviewed by Lucas Forschler.
3632
3633         * Scripts/webkitpy/port/darwin.py:
3634         (DarwinPort._merge_crash_logs):
3635
3636 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3637
3638         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3639         https://bugs.webkit.org/show_bug.cgi?id=193746
3640
3641         Reviewed by Youenn Fablet.
3642
3643         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3644         so we'd best just not call it.
3645
3646         * Scripts/webkitpy/w3c/test_exporter.py:
3647         (WebPlatformTestExporter.create_branch_with_patch):
3648
3649 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3650
3651         Move FileSystem to WTF
3652         https://bugs.webkit.org/show_bug.cgi?id=193602
3653
3654         Reviewed by Yusuke Suzuki.
3655
3656         * DumpRenderTree/win/DumpRenderTree.cpp:
3657         * TestWebKitAPI/CMakeLists.txt:
3658         * TestWebKitAPI/PlatformGTK.cmake:
3659         * TestWebKitAPI/PlatformJSCOnly.cmake:
3660         * TestWebKitAPI/PlatformPlayStation.cmake:
3661         * TestWebKitAPI/PlatformWPE.cmake:
3662         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3663         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3664         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3665         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3666         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3667         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3668         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3669         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3670         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3671         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3672
3673 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3674
3675         [WPE] Remove hard dependency on subprocess32 for the API tests
3676
3677         Rubber-stamped by Carlos Garcia Campos.
3678
3679         * glib/api_test_runner.py:
3680         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3681         its presence only when running WPEQt tests.
3682
3683 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3684
3685         [GLIB] Expose JavaScriptCore options in GLib public API
3686         https://bugs.webkit.org/show_bug.cgi?id=188742
3687
3688         Reviewed by Michael Catanzaro.
3689
3690         Add a test for the new API.
3691
3692         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3693         (testsJSCOptions):
3694         (main):
3695
3696 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3697
3698         [GTK][WPE] Support JPEG 2000 images
3699         https://bugs.webkit.org/show_bug.cgi?id=186272
3700
3701         Reviewed by Žan Doberšek.
3702
3703         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3704
3705         * gtk/jhbuild.modules:
3706         * wpe/jhbuild.modules:
3707
3708 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3709
3710         check-webkit-style should warn when using soft-linking macros in a header
3711         <https://webkit.org/b/193750>
3712
3713         Reviewed by Darin Adler.
3714
3715         * Scripts/webkitpy/style/checkers/cpp.py:
3716         (check_language): Add softlink/header check by refactoring the
3717         softlink/framework check.
3718         (CppChecker): Enable softlink/header check by default.
3719         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3720         (CppStyleTest.test_softlink_framework): Rename from
3721         CppStyleTest.test_softlink() and change test framework name in
3722         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3723         files. Set file_name for macros that only appear in headers.
3724         (CppStyleTest.test_softlink_header): Add tests for using
3725         soft-link macros in headers.
3726
3727 2019-01-23  Chris Dumez  <cdumez@apple.com>
3728
3729         Deprecate API to limit the maximum number of WebProcesses
3730         https://bugs.webkit.org/show_bug.cgi?id=193725
3731         <rdar://problem/47464879>
3732
3733         Reviewed by Geoff Garen.
3734
3735         Update existing API tests to stop using deprecated API.
3736
3737         * MiniBrowser/mac/AppDelegate.m:
3738         (defaultConfiguration):
3739         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3740         (TestWebKitAPI::TEST):
3741         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3742         (TestWebKitAPI::TEST):
3743         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3744         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3745         (TEST):
3746         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3747         (TEST):
3748
3749 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3750
3751         [ews-app] Rename ews model buildermappings to buildermapping
3752         https://bugs.webkit.org/show_bug.cgi?id=193729
3753
3754         Reviewed by Lucas Forschler.
3755
3756         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3757         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3758         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3759
3760 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3761
3762         [ews-app] Rename ews model steps to step
3763         https://bugs.webkit.org/show_bug.cgi?id=193697
3764
3765         Reviewed by Lucas Forschler.
3766
3767         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3768         (Step): Renamed Steps to Step.
3769
3770 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3771
3772         Clean up IndexedDB files between tests
3773         https://bugs.webkit.org/show_bug.cgi?id=192796
3774         <rdar://problem/46824999>
3775
3776         Reviewed by Geoffrey Garen.
3777
3778         * DumpRenderTree/mac/DumpRenderTree.mm:
3779         (runTest):
3780         * WebKitTestRunner/TestController.cpp:
3781         (WTR::TestController::resetStateToConsistentValues):
3782         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3783         (WTR::RemoveAllIndexedDatabasesCallback):
3784         (WTR::TestController::ClearIndexedDatabases):
3785         * WebKitTestRunner/TestController.h:
3786         * WebKitTestRunner/TestInvocation.cpp:
3787         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3788
3789 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3790
3791         [ews-app] Rename ews model Builds to Build
3792         https://bugs.webkit.org/show_bug.cgi?id=193695
3793
3794         Reviewed by Lucas Forschler.
3795
3796         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3797         (Build): Renamed Builds to Build.
3798
3799 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3800
3801         webkitpy: Wait longer when launching WebKitTestRunner
3802         https://bugs.webkit.org/show_bug.cgi?id=193734
3803
3804         Reviewed by Aakash Jain.
3805
3806         * Scripts/webkitpy/port/simulator_process.py:
3807         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3808
3809 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3810
3811         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3812         https://bugs.webkit.org/show_bug.cgi?id=193182
3813         <rdar://problem/47452154>
3814
3815         Reviewed by Tim Horton.
3816
3817         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3818         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3819         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3820
3821         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3822         preventing later tests from recognizing gestures.
3823
3824         * WebKitTestRunner/ios/TestControllerIOS.mm:
3825         (WTR::TestController::platformResetStateToConsistentValues):
3826
3827         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3828
3829 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3830
3831         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3832         https://bugs.webkit.org/show_bug.cgi?id=193722
3833         <rdar://problem/47481475>
3834
3835         Reviewed by Lucas Forschler.
3836
3837         iPhone and iPad ports should both use the iOS config.
3838
3839         * Scripts/webkitpy/port/ios_simulator.py:
3840         (IPhoneSimulatorPort.__init__):
3841         (IPadSimulatorPort.__init__):
3842
3843 2019-01-23  Rob Buis  <rbuis@igalia.com>
3844
3845         Update MIME type parser
3846         https://bugs.webkit.org/show_bug.cgi?id=180526
3847
3848         Reviewed by Frédéric Wang.
3849
3850         Add unit tests for both parse modes of ParsedContentType.
3851
3852         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3853         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3854         (TestWebKitAPI::TEST):
3855
3856 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3857
3858         [ews-app] fetch loop should not stop on network issues
3859         https://bugs.webkit.org/show_bug.cgi?id=193666
3860
3861         Reviewed by Lucas Forschler.
3862
3863         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3864         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3865
3866 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3867
3868         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3869         https://bugs.webkit.org/show_bug.cgi?id=189165
3870         <rdar://problem/47433765>
3871
3872         Reviewed by Tim Horton.
3873
3874         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3875         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3876         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3877         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3878         would make its way to the UI process by the time the layer tree commit is finished.
3879
3880         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3881         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3882         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3883         will fail because it asks for -_autofillContext too early.
3884
3885         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3886         is handled in the UI process.
3887
3888         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3889
3890         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3891         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3892         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3893         input session.
3894
3895         (-[AutofillTestView textInputHasAutofillContext]):
3896
3897         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3898
3899         * TestWebKitAPI/cocoa/TestWKWebView.h:
3900         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3901         (nextInputSessionChangeCount):
3902
3903         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3904         This includes changing the focused element from one to another.
3905
3906         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3907         (-[TestWKWebView didStartFormControlInteraction]):
3908         (-[TestWKWebView didEndFormControlInteraction]):
3909         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3910
3911         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3912         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3913         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3914         that doesn't require an input session to one that doesn't.
3915
3916 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3917
3918         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3919         <https://webkit.org/b/193676>
3920
3921         Reviewed by Alexey Proskuryakov.
3922
3923         * Scripts/webkitpy/style/checkers/cpp.py:
3924         (check_member_initialization_list):
3925         - Don't report missing whitespace around colon if the colon at
3926           the start of the line is formatted correctly.
3927         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3928         (WebKitStyleTest.test_member_initialization_list):
3929         - Add a test for a missing permutation of existing tests.
3930         - Add a test this false-positive.
3931         - Add blank lines between subtests to make them easier to read.
3932
3933 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3934
3935         [build.webkit.org] Unit-test failure after r237113
3936         https://bugs.webkit.org/show_bug.cgi?id=193669
3937
3938         Reviewed by Michael Catanzaro.
3939
3940         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3941         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3942         multiple or zero flags.
3943
3944 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3945
3946         Cache bytecode to disk
3947         https://bugs.webkit.org/show_bug.cgi?id=192782
3948         <rdar://problem/46084932>
3949
3950         Reviewed by Keith Miller.
3951
3952         Add test helper to execute bytecode-cache tests: it executes each test
3953         twice, the first with JSC_diskCachePath set to a temporary directory
3954         and second with JSC_forceDiskCache=true (in addition to the cache path)
3955         to guarantee that only the disk cache is being used and no new
3956         UnlinkedCodeBlocks are being created.
3957
3958         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3959         * Scripts/run-jsc-stress-tests:
3960
3961 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3962
3963         [css-logical] Implement flow-relative margin, padding and border shorthands
3964         https://bugs.webkit.org/show_bug.cgi?id=188697
3965
3966         Reviewed by Simon Fraser and Antti Koivisto.
3967
3968         * DumpRenderTree/TestOptions.cpp:
3969         (TestOptions::TestOptions):
3970         * DumpRenderTree/TestOptions.h:
3971         * DumpRenderTree/mac/DumpRenderTree.mm:
3972         (setWebPreferencesForTestOptions):
3973         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3974
3975         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3976         (JSONCSSPropertiesChecker.check_codegen_properties):
3977         Allow CSS property definitions to have a 'runtime-flag' parameter which
3978         disables the property when the specified runtime flag is disabled.
3979
3980 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3981
3982         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3983         https://bugs.webkit.org/show_bug.cgi?id=193643
3984
3985         Reviewed by Michael Catanzaro.
3986
3987         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3988         * wpe/jhbuild.modules: Ditto.
3989
3990 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3991
3992         [LFC][Floats] Take float top position into account when computing containing block height.
3993         https://bugs.webkit.org/show_bug.cgi?id=193655
3994
3995         Reviewed by Antti Koivisto.
3996
3997         * LayoutReloaded/misc/LFC-passing-tests.txt:
3998
3999 2019-01-21  David Kilzer  <ddkilzer@apple.com>
4000
4001         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
4002         <https://webkit.org/b/193645>
4003         <rdar://problem/47421574>
4004
4005         Reviewed by Alex Christensen.
4006
4007         - Now checks for local soft-linking of all frameworks that have
4008           their own *SoftLinking.{cpp,h,mm} files.
4009         - Changes softlink/uikit warning to softlink/framework.
4010
4011         * Scripts/webkitpy/style/checkers/cpp.py:
4012         (check_language):
4013         (CppChecker):
4014         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4015         (CppStyleTest):
4016
4017 2019-01-20  Saam Barati  <sbarati@apple.com>
4018
4019         Rollout r240210: It broke tests on iOS
4020         https://bugs.webkit.org/show_bug.cgi?id=193640
4021
4022         Unreviewed.
4023
4024         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
4025         * Scripts/run-jsc-stress-tests:
4026
4027 2019-01-20  chris fleizach  <cfleizach@apple.com>
4028
4029         AX: Support returning relative frames for accessibility
4030         https://bugs.webkit.org/show_bug.cgi?id=193414
4031         <rdar://problem/47268501>
4032
4033         Reviewed by Zalan Bujtas.
4034
4035         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4036         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4037         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4038         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4039         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4040         (WTR::attributesOfElement):
4041         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4042
4043 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
4044
4045         Unreviewed, add my new email address
4046
4047         * Scripts/webkitpy/common/config/contributors.json:
4048
4049 2019-01-19  Zalan Bujtas  <zalan@apple.com>
4050
4051         [LFC][BFC] <body>'s overflow property value is propagated to viewport
4052         https://bugs.webkit.org/show_bug.cgi?id=193617
4053
4054         Reviewed by Antti Koivisto.
4055
4056         * LayoutReloaded/misc/LFC-passing-tests.txt:
4057
4058 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
4059
4060         Unreviewed, rolling out r240209.
4061
4062         Broke GTK/WPE injected bundle
4063
4064         Reverted changeset:
4065
4066         "AX: Support returning relative frames for accessibility"
4067         https://bugs.webkit.org/show_bug.cgi?id=193414
4068         https://trac.webkit.org/changeset/240209
4069
4070 2019-01-12  Dan Bernstein  <mitz@apple.com>
4071
4072         [Cocoa] Avoid importing directly from subumbrella frameworks
4073         https://bugs.webkit.org/show_bug.cgi?id=186016
4074         <rdar://problem/40591038>
4075
4076         Reviewed by Sam Weinig.
4077
4078         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4079           LaunchServices header.
4080         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4081           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4082         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4083           when using SDKs earlier than 10.13.
4084         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4085           and OTHER_CPLUSPLUSFLAGS.
4086         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4087           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4088         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4089           LaunchServices header.
4090
4091 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
4092
4093         Cache bytecode to disk
4094         https://bugs.webkit.org/show_bug.cgi?id=192782
4095         <rdar://problem/46084932>
4096
4097         Reviewed by Keith Miller.
4098
4099         Add test helper to execute bytecode-cache tests: it executes each test
4100         twice, the first with JSC_diskCachePath set to a temporary directory
4101         and second with JSC_forceDiskCache=true (in addition to the cache path)
4102         to guarantee that only the disk cache is being used and no new
4103         UnlinkedCodeBlocks are being created.
4104
4105         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
4106         * Scripts/run-jsc-stress-tests:
4107
4108 2019-01-20  chris fleizach  <cfleizach@apple.com>
4109
4110         AX: Support returning relative frames for accessibility
4111         https://bugs.webkit.org/show_bug.cgi?id=193414
4112         <rdar://problem/47268501>
4113
4114         Reviewed by Zalan Bujtas.
4115
4116         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4117         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4118         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4119         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4120         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4121         (WTR::attributesOfElement):
4122         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4123
4124 2019-01-20  Antoine Quint  <graouts@apple.com>
4125
4126         Add a POINTER_EVENTS feature flag
4127         https://bugs.webkit.org/show_bug.cgi?id=193577
4128         <rdar://problem/47408511>
4129
4130         Unreviewed. Also enable Pointer Events for iosmac.
4131
4132         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4133
4134 2019-01-19  Zalan Bujtas  <zalan@apple.com>
4135
4136         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
4137         https://bugs.webkit.org/show_bug.cgi?id=193613
4138
4139         Reviewed by Antti Koivisto.
4140
4141         * LayoutReloaded/misc/LFC-passing-tests.txt:
4142
4143 2019-01-19  Antoine Quint  <graouts@apple.com>
4144
4145         Add a POINTER_EVENTS feature flag
4146         https://bugs.webkit.org/show_bug.cgi?id=193577
4147
4148         Reviewed by Dean Jackson.
4149
4150         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4151
4152 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
4153
4154         Disable the run-jsc-stress-test remote host key check [second round].
4155         https://bugs.webkit.org/show_bug.cgi?id=192988
4156
4157         Reviewed by Dewei Zhu.
4158
4159         * Scripts/run-jsc-stress-tests:
4160
4161 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4162
4163         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
4164         https://bugs.webkit.org/show_bug.cgi?id=193597
4165
4166         Reviewed by Lucas Forschler.
4167
4168         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4169
4170 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4171
4172         [build.webkit.org] api tests failures are incorrectly named as unit test failures
4173         https://bugs.webkit.org/show_bug.cgi?id=193595
4174
4175         Reviewed by Lucas Forschler.
4176
4177         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
4178         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
4179         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
4180
4181 2019-01-18  Chris Dumez  <cdumez@apple.com>
4182
4183         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
4184         https://bugs.webkit.org/show_bug.cgi?id=193588
4185         <rdar://problem/47131566>
4186
4187         Reviewed by Alex Christensen.
4188
4189         Add layout test coverage.
4190
4191         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4192
4193 2019-01-18  Jer Noble  <jer.noble@apple.com>
4194
4195         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
4196         https://bugs.webkit.org/show_bug.cgi?id=189553
4197
4198         Reviewed by Tim Horton.
4199
4200         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
4201
4202         * ContentExtensionTester/Configurations/Base.xcconfig:
4203         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
4204         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4205         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
4206         * ImageDiff/cg/Configurations/Base.xcconfig:
4207         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
4208         * MiniBrowser/Configurations/Base.xcconfig:
4209         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4210         * MobileMiniBrowser/Configurations/Base.xcconfig:
4211         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4212         * Scripts/webkitpy/style/checker.py:
4213         (_all_categories):
4214         (FileType):
4215         (CheckerDispatcher._file_type):
4216         (CheckerDispatcher._create_checker):
4217         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
4218         (SDKVariantChecker):
4219         (SDKVariantChecker.__init__):
4220         (SDKVariantChecker.check):
4221         * TestWebKitAPI/Configurations/Base.xcconfig:
4222         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
4223         * WebEditingTester/Configurations/Base.xcconfig:
4224         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
4225         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
4226         * WebKitTestRunner/Configurations/Base.xcconfig:
4227         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
4228         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
4229         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
4230
4231 2019-01-18  David Kilzer  <ddkilzer@apple.com>
4232
4233         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
4234         <https://webkit.org/b/193568>
4235         <rdar://problem/47381130>
4236
4237         Reviewed by Alex Christensen.
4238
4239         Make sure no one re-introduces UIKit soft-linking by adding a
4240         style rule.
4241
4242         * Scripts/webkitpy/style/checkers/cpp.py:
4243         (check_language): Add softlink/uikit check.
4244         (CppChecker): Enable softlink/uikit check.
4245         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4246         (CppStyleTest): Add test for softlink/uikit.
4247
4248 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
4249
4250         [GTK] install-dependencies tool looks for libunistring-dev for dnf
4251         https://bugs.webkit.org/show_bug.cgi?id=193584
4252
4253         Change "-dev" to "-devel".
4254
4255         Reviewed by Michael Catanzaro.
4256
4257         * gtk/install-dependencies:
4258
4259 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4260
4261         webkitpy: Add iPhone and iPad ports
4262         https://bugs.webkit.org/show_bug.cgi?id=193537
4263         <rdar://problem/47353390>
4264
4265         Reviewed by Lucas Forschler.
4266
4267         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
4268         ports. Note that this separation is optional, the --ios-simulator command remains.
4269
4270         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4271         (RunTest.test_device_type_test_division): Drive-by fix.
4272         (RunTest.test_device_type_specific_listing): Ditto.
4273         (RunTest.test_ipad_test_division):
4274         (RunTest):
4275         (RunTest.test_ipad_listing):
4276         * Scripts/webkitpy/port/factory.py:
4277         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
4278         (PortFactory):
4279         * Scripts/webkitpy/port/ios_simulator.py:
4280         (IPhoneSimulatorPort):
4281         (IPadSimulatorPort):
4282
4283 2019-01-18  Chris Dumez  <cdumez@apple.com>
4284
4285         Regression(PSON) Scroll position is not always restored properly when navigating back
4286         https://bugs.webkit.org/show_bug.cgi?id=193578
4287         <rdar://problem/47386331>
4288
4289         Reviewed by Tim Horton.
4290
4291         Add API test coverage.
4292
4293         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4294
4295 2019-01-18  Youenn Fablet  <youenn@apple.com>
4296
4297         Add a new SPI to request for cache storage quota increase
4298         https://bugs.webkit.org/show_bug.cgi?id=193323
4299
4300         Reviewed by Alex Christensen.
4301
4302         Implement WebsiteDataStore quota delegate to handle quota requests.
4303         By default, do not update quota.
4304         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
4305
4306         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4307         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4308         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
4309         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4310         * WebKitTestRunner/TestController.cpp:
4311         (WTR::TestController::allowCacheStorageQuotaIncrease):
4312         * WebKitTestRunner/TestController.h:
4313         * WebKitTestRunner/TestInvocation.cpp:
4314         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4315         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4316         (-[CacheStorageQuotaManager init]):
4317         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4318         (WTR::initializeWebViewConfiguration):
4319         (WTR::TestController::cocoaResetStateToConsistentValues):
4320         (WTR::TestController::allowCacheStorageQuotaIncrease):
4321
4322 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4323
4324         [ews-build] Pass owner to the triggered builds
4325         https://bugs.webkit.org/show_bug.cgi?id=193574
4326
4327         Reviewed by Lucas Forschler.
4328
4329         * BuildSlaveSupport/ews-build/factories.py:
4330         (BuildFactory.propertiesToPassToTriggers):
4331
4332 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4333
4334         [ews-app] Send patch author as a build property
4335         https://bugs.webkit.org/show_bug.cgi?id=193560
4336
4337         Reviewed by Lucas Forschler.
4338
4339         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4340         (BugzillaPatchFetcher.fetch):
4341
4342 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4343
4344         webkitpy: Implement device type specific expected results (Follow-up fix)
4345         https://bugs.webkit.org/show_bug.cgi?id=192162
4346         <rdar://problem/46345449>
4347
4348         Unreviewed infrastructure fix.
4349
4350         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4351         (Manager.run): Don't boot a device if no tests are available to run on it.
4352
4353 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4354
4355         webkitpy: Implement device type specific expected results (Follow-up fix)
4356         https://bugs.webkit.org/show_bug.cgi?id=192162