Fix autoinstaller failing on autoinstall_everything
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
2
3         Fix autoinstaller failing on autoinstall_everything
4         https://bugs.webkit.org/show_bug.cgi?id=174830
5
6         Reviewed by Joseph Pecoraro.
7
8         * Scripts/webkitpy/thirdparty/__init__.py:
9         (AutoinstallImportHook.find_module):
10         (AutoinstallImportHook.install_chromedriver):
11         (AutoinstallImportHook.install_geckodriver):
12         (AutoinstallImportHook._install_chromedriver): Deleted.
13         (AutoinstallImportHook._install_geckodriver): Deleted.
14
15 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
16
17         Replace --runtime with something for both ios-simulator and ios-device
18         https://bugs.webkit.org/show_bug.cgi?id=173775
19         <rdar://problem/32952164>
20
21         Reviewed by Aakash Jain.
22
23         Add --version flag for both iOS simulator and iOS device.
24
25         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
26         (parse_args): Add --version flag and move --no-install.
27         * Scripts/webkitpy/port/factory.py:
28         (platform_options): Move --no-intall to run_webkit_tests.py.
29         * Scripts/webkitpy/port/ios.py:
30         (IOSPort):
31         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
32         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
33         * Scripts/webkitpy/port/ios_device.py:
34         (IOSDevicePort.ios_version): Consult --version flag before checking connected
35         devices for iOS version.
36         * Scripts/webkitpy/port/ios_device_unittest.py:
37         (IOSDeviceTest.make_port): Set --version option so that we can generate test
38         expectation paths without devices connected.
39         (IOSDeviceTest.test_additional_platform_directory): Deleted.
40         (IOSDeviceTest.test_baseline_searchpath): Deleted.
41         (IOSDeviceTest.test_expectations_ordering): Deleted.
42         * Scripts/webkitpy/port/ios_simulator.py:
43         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
44         flag to specify a runtime.
45         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
46         flag and then use the default runtime.
47
48 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
49
50         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
51         https://bugs.webkit.org/show_bug.cgi?id=174815
52
53         Reviewed by Carlos Alberto Lopez Perez.
54
55         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
56         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
57         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
58         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
59         think), probably because of a newer CMake version.
60
61         * CMakeLists.txt:
62         * TestWebKitAPI/CMakeLists.txt:
63         * TestWebKitAPI/PlatformGTK.cmake:
64
65 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
66
67         Fix BenchmarkRunner to only import selenium when needed
68         https://bugs.webkit.org/show_bug.cgi?id=174808
69
70         Reviewed by Stephanie Lewis.
71
72         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
73         (LinuxChromeDriver.launch_driver):
74         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
75         (LinuxFirefoxDriver.launch_driver):
76         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
77         (OSXChromeDriver.launch_driver):
78         (OSXChromeCanaryDriver.launch_driver):
79         (create_chrome_options):
80         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
81         (OSXFirefoxDriver.launch_driver):
82         (OSXFirefoxNightlyDriver.launch_driver):
83         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
84         (OSXSafariDriver.launch_driver):
85         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
86         (WebDriverBenchmarkRunner._run_one_test):
87
88 2017-07-23  Darin Adler  <darin@apple.com>
89
90         More NeverDestroyed and related cleanup
91         https://bugs.webkit.org/show_bug.cgi?id=174745
92
93         Reviewed by Alex Christensen.
94
95         * DumpRenderTree/JavaScriptThreading.cpp:
96         (javaScriptThreadsMutex): Use NeverDestroyed instead of
97         DEPRECATED_DEFINE_STATIC_LOCAL.
98         (javaScriptThreads): Ditto.
99
100 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
101
102         Subclass Benchmark Runner script for WebDriver support
103         https://bugs.webkit.org/show_bug.cgi?id=174390
104
105         Reviewed by Dewei Zhu, Stephanie Lewis.
106
107         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
108
109         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
110         (BenchmarkBuilder.__init__):
111         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
112         (BenchmarkRunner.__init__):
113         (BenchmarkRunner._find_plan_file):
114         (BenchmarkRunner._run_one_test.and):
115         (BenchmarkRunner.execute):
116         (BenchmarkRunner._get_result): Deleted.
117         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
118         (parse_args):
119         (start):
120         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
121         (WebDriverBenchmarkRunner):
122         (WebDriverBenchmarkRunner._get_result):
123         (WebDriverBenchmarkRunner._run_one_test):
124         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
125         (WebServerBenchmarkRunner):
126         (WebServerBenchmarkRunner.__init__):
127         (WebServerBenchmarkRunner._get_result):
128         (WebServerBenchmarkRunner._run_one_test):
129
130 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
131
132         Add BenchmarkRunner patches with WebDriver support for each testing plan
133         https://bugs.webkit.org/show_bug.cgi?id=174443
134
135         Reviewed by Dewei Zhu, Stephanie Lewis.
136
137         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
138         (BenchmarkBuilder.__enter__):
139         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
140         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
141         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
142         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
143         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
144         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
145         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
146         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
147         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
148         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
149         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
150         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
151         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
152         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
153         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
154         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
155         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
156         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
157         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
158         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
159         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
160         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
161         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
162         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
163         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
164         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
165         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
166         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
167         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
168         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
169         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
170         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
171         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
172
173 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
174
175         Add functions to autoinstaller needed for Benchmark Runner script
176         https://bugs.webkit.org/show_bug.cgi?id=174331
177
178         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
179
180         Adds autoinstaller functions to install selenium and webdriver binaries
181         which will be used by the browser driver part of Benchmark Runner.
182
183         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
184         (BrowserDriver.restore_env):
185         (BrowserDriver):
186         (BrowserDriver.get_webdriver_binary_path):
187         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
188         (LinuxChromeDriver.launch_driver):
189         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
190         (LinuxFirefoxDriver.launch_driver):
191         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
192         (OSXChromeDriver.launch_driver):
193         (OSXChromeCanaryDriver.launch_driver):
194         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
195         (OSXFirefoxDriver.launch_driver):
196         (OSXFirefoxNightlyDriver.launch_driver):
197         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
198         * Scripts/webkitpy/benchmark_runner/utils.py:
199         (get_driver_binary_path):
200         * Scripts/webkitpy/common/system/autoinstall.py:
201         (AutoInstaller._unzip):
202         * Scripts/webkitpy/thirdparty/__init__.py:
203         (AutoinstallImportHook.find_module):
204         (AutoinstallImportHook._install_selenium):
205         (AutoinstallImportHook):
206         (AutoinstallImportHook._install_chromedriver):
207         (AutoinstallImportHook._install_geckodriver):
208         (AutoinstallImportHook.get_latest_pypi_url):
209         (AutoinstallImportHook.install_binary):
210         (autoinstall_everything):
211         (get_driver_filename):
212         (get_os_info):
213
214 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
215
216         Add WebDriver support in browser driver part of BenchmarkRunner
217         https://bugs.webkit.org/show_bug.cgi?id=174445
218
219         Reviewed by Stephanie Lewis.
220
221         Adds a launch_driver function to each BrowserDriver subclass. This
222         function sets up the arguments for the webdriver and launches the
223         webdriver specific to that browser.
224
225         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
226         (BrowserDriver.launch_webdriver):
227         (BrowserDriver):
228         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
229         (LinuxBrowserDriver.launch_webdriver):
230         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
231         (LinuxChromeDriver.launch_url):
232         (LinuxChromeDriver):
233         (LinuxChromeDriver.launch_driver):
234         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
235         (EpiphanyBrowserDriver.launch_url):
236         (EpiphanyBrowserDriver):
237         (EpiphanyBrowserDriver.launch_driver):
238         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
239         (LinuxFirefoxDriver):
240         (LinuxFirefoxDriver.launch_url):
241         (LinuxFirefoxDriver.launch_driver):
242         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
243         (GTKMiniBrowserDriver.launch_url):
244         (GTKMiniBrowserDriver):
245         (GTKMiniBrowserDriver.launch_driver):
246         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
247         (OSXBrowserDriver._launch_webdriver):
248         (OSXBrowserDriver):
249         (OSXBrowserDriver._screen_size):
250         (OSXBrowserDriver._insert_url):
251         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
252         (OSXChromeDriver):
253         (OSXChromeDriver.launch_url):
254         (OSXChromeDriver.launch_driver):
255         (OSXChromeCanaryDriver):
256         (OSXChromeCanaryDriver.launch_url):
257         (OSXChromeCanaryDriver.launch_driver):
258         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
259         (OSXFirefoxDriver):
260         (OSXFirefoxDriver.launch_url):
261         (OSXFirefoxDriver.launch_driver):
262         (OSXFirefoxNightlyDriver):
263         (OSXFirefoxNightlyDriver.launch_url):
264         (OSXFirefoxNightlyDriver.launch_driver):
265         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
266         (OSXSafariDriver.launch_driver):
267
268 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
269
270         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
271         https://bugs.webkit.org/show_bug.cgi?id=174793
272
273         Reviewed by Tim Horton.
274
275         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
276         down. Without r219765, this test will dereference null and crash.
277
278         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
279         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
280         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
281         (TEST):
282
283 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
284
285         [Win] Implement Authentication dialog in MiniBrowser
286         https://bugs.webkit.org/show_bug.cgi?id=174662
287
288         Reviewed by Alex Christensen.
289
290         * MiniBrowser/win/Common.cpp:
291         (CustomUserAgent):
292         (DisplayAuthDialog):
293         (AuthDialogProc):
294         * MiniBrowser/win/MiniBrowserLib.rc:
295         * MiniBrowser/win/MiniBrowserLibResource.h:
296         * MiniBrowser/win/ResourceLoadDelegate.cpp:
297         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
298
299 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
300
301         Handle case where line_numbers is None instead of an array of line numbers
302         https://bugs.webkit.org/show_bug.cgi?id=174775
303
304         Reviewed by Aakash Jain.
305
306         Added files set line_numbers to None in process_file.
307
308         * Scripts/webkitpy/style/filereader.py:
309         (TextFileReader.process_file): Handle case where line_number is set to None.
310         * Scripts/webkitpy/style/main_unittest.py:
311         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
312
313 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
314
315         [WPE] Add libepoxy to the Jhbuild moduleset
316         https://bugs.webkit.org/show_bug.cgi?id=174711
317
318         Reviewed by Carlos Alberto Lopez Perez.
319
320         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
321
322 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
323
324         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
325         https://bugs.webkit.org/show_bug.cgi?id=174780
326
327         Reviewed by Carlos Garcia Campos.
328
329         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
330         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
331         in case the eglplatform.h header doesn't provide that macro. This replicates
332         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
333
334 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
335
336         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
337         https://bugs.webkit.org/show_bug.cgi?id=174758
338
339         Reviewed by Dan Bernstein.
340
341         Migrate position-information-related unit tests from the PositionInformationTests suite to
342         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
343
344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
345         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
346         (TestWebKitAPI::checkElementTypeAndBoundingRect):
347         (TestWebKitAPI::TEST):
348         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
349         * TestWebKitAPI/cocoa/TestWKWebView.h:
350         * TestWebKitAPI/cocoa/TestWKWebView.mm:
351         (-[TestWKWebView activatedElementAtPosition:]):
352
353 2017-07-22  Chris Dumez  <cdumez@apple.com>
354
355         REGRESSION(r204565): WKObject is broken
356         https://bugs.webkit.org/show_bug.cgi?id=174736
357         <rdar://problem/33246169>
358
359         Reviewed by Dan Bernstein.
360
361         Add API test that used to crash.
362
363         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
364         (TestWebKitAPI::TEST):
365
366 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
367
368         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
369         https://bugs.webkit.org/show_bug.cgi?id=174705
370
371         Reviewed by Mark Lam.
372
373         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
374         (TestWebKitAPI::testThreadGroup):
375         (TestWebKitAPI::TEST):
376
377 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
378
379         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
380         https://bugs.webkit.org/show_bug.cgi?id=174724
381
382         Reviewed by Aakash Jain.
383
384         * Scripts/webkitpy/port/ios_simulator.py:
385         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
386         simulator. Errors here should be treated the same as no simulators found.
387
388 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
389
390         [CMake] Add an option to stop build after generating project files
391         https://bugs.webkit.org/show_bug.cgi?id=174664
392
393         Reviewed by Konstantin Tokarev.
394
395         Add "--generate-project-only" to stop build after generating project files.
396
397         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
398         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
399         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
400         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
401         (isGenerateProjectOnly): ditto
402
403 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
404
405         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
406         https://bugs.webkit.org/show_bug.cgi?id=174501
407
408         Reviewed by Darin Adler.
409
410         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
411         (TestWebKitAPI::TEST):
412
413 2017-07-20  David Quesada  <david_quesada@apple.com>
414
415         Add SPI to notify WKNavigationDelegate about client redirects
416         https://bugs.webkit.org/show_bug.cgi?id=174680
417         rdar://problem/33184886
418
419         Reviewed by Brady Eidson.
420
421         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
422         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
423         (TEST):
424         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
425
426 2017-07-20  Brady Eidson  <beidson@apple.com>
427
428         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
429         https://bugs.webkit.org/show_bug.cgi?id=174685
430
431         Reviewed by Andy Estes.
432
433         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
434         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
435
436 2017-07-20  Brady Eidson  <beidson@apple.com>
437
438         Deprecate WebIconDatabase in WebKitLegacy/mac.
439         https://bugs.webkit.org/show_bug.cgi?id=174607
440
441         Reviewed by Alex Christensen.
442
443         * DumpRenderTree/mac/TestRunnerMac.mm:
444
445 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
446
447         lint-test-expectations should be run during style checking
448         https://bugs.webkit.org/show_bug.cgi?id=173559
449         <rdar://problem/32854941>
450
451         Reviewed by Aakash Jain.
452
453         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
454         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
455         prevents identifying errors on specific lines in a file.
456         * Scripts/webkitpy/style/main_unittest.py:
457         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
458         case where a linter error is in the file modified, but the line modified is not related to
459         the linter error.
460
461 2017-07-20  Brady Eidson  <beidson@apple.com>
462
463         Remove WebIconDatabase from WebKitLegacy/win.
464         https://bugs.webkit.org/show_bug.cgi?id=174608
465
466         Reviewed by Alex Christensen.
467
468         * DumpRenderTree/win/DumpRenderTree.cpp:
469         (main):
470         * DumpRenderTree/win/TestRunnerWin.cpp:
471         (TestRunner::setIconDatabaseEnabled):
472
473 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
474
475         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
476         https://bugs.webkit.org/show_bug.cgi?id=174671
477
478         Reviewed by Carlos Garcia Campos.
479
480         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
481         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
482         priority for this source in order to have it dispatched on the same
483         priority as the other WebKit-controlled GSource objects.
484
485 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
486
487         lint-test-expectations should be run during style checking
488         https://bugs.webkit.org/show_bug.cgi?id=173559
489         <rdar://problem/32854941>
490
491         Reviewed by Daniel Bates.
492
493         Follow up fix addressing style and a few minor bugs.
494
495         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
496         (TestExpectationParser.__init__): Use lambda x: x instead of str
497         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
498         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
499         reduce the calls of _shorten_filename, fix minor bug in appending the current
500         expectation's line number instead of the previous ones, clarify treatment of None
501         in file-to-line-number mapping.
502         (TestExpectations._report_warnings): Collapse call.
503         * Scripts/webkitpy/style/checkers/test_expectations.py:
504         (TestExpectationsChecker.lint_test_expectations):
505         * Scripts/webkitpy/style/filereader.py: Re-write comment.
506         (TextFileReader.process_file): Add comment explaining treatment of None in
507         file-to-line-number mapping.
508         (TextFileReader.delete_file): Collapse call.
509
510 2017-07-19  Chris Dumez  <cdumez@apple.com>
511
512         Unreviewed attempt to fix API test failure after r219663.
513
514         The test was hard-coding an exception string and the string has changed slightly
515         in r219663.
516
517         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
518         (TEST):
519
520 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
521
522         Don't write file URLs to iOS Pasteboard
523         https://bugs.webkit.org/show_bug.cgi?id=174647
524         <rdar://problem/33199730>
525
526         Reviewed by Wenson Hsieh.
527
528         Updating tests to reflect the lack of file URLs for images.
529
530         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
531         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
532         (checkEstimatedSize):
533         (TestWebKitAPI::TEST):
534
535 2017-07-19  Brady Eidson  <beidson@apple.com>
536
537         iBooks sometimes crashes when closing a book.
538         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
539
540         Reviewed by Oliver Hunt.
541
542         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
543         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
544         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
545         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
546         (TestWebKitAPI::TEST):
547
548         Add a "spin the runloop X number of times" utility:
549         * TestWebKitAPI/Utilities.h:
550         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
551         (TestWebKitAPI::Util::spinRunLoop):
552
553 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
554
555         lint-test-expectations should be run during style checking
556         https://bugs.webkit.org/show_bug.cgi?id=173559
557         <rdar://problem/32854941>
558
559         Reviewed by David Kilzer.
560
561         Running the test expectation linter requires reading both files and lines not in the
562         patch because, for example, deletion of a test can cause a lint failure even though
563         no test expectations where modified. This means that the linter will occasionally warn
564         about lines which were not changed in a given patch but whose error is related to a
565         change made in that patch.
566
567         * Scripts/webkitpy/common/system/filesystem_mock.py:
568         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
569         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
570         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
571         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
572         content, description of the error and the name of the associated test.
573         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
574         (TestExpectationParser.__init__): Pass shorten_filename function to
575         TestExpectationsParser to add a deleted file to the related_files dictionary.
576         (TestExpectationParser._check_test_exists): If the test does not exist, add the
577         missing path to the related_files dictionary.
578         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
579         files and line numbers related to this test expectation line. This will allow
580         tracking linter errors in the style checker occurring across multiple files.
581         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
582         lines to related_files dictionary.
583         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
584         (TestExpectations._report_warnings): Construct warning object instead of string
585         when adding to warnings list.
586         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
587         clean-up log.
588         * Scripts/webkitpy/style/checker.py:
589         (ProcessorBase.do_association_check): Add required function for processor classes.
590         (StyleProcessor):
591         (StyleProcessor.do_association_check): Run the TestExpectations linter when
592         checking for errors between associated files.
593         * Scripts/webkitpy/style/checkers/test_expectations.py:
594         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
595         (TestExpectationsChecker):
596         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
597         of modified files, the current working directory and the host, determine if the linter
598         warning is associated with the changes.
599         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
600         style checker.
601         * Scripts/webkitpy/style/filereader.py:
602         (TextFileReader):
603         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
604         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
605         (TextFileReader.process_file): Track both the number of files changed and which lines
606         in those files were changed.
607         (TextFileReader.do_association_check): Run the processor's association check on all
608         modified or deleted files processed by TextFileReader.
609         (TextFileReader.delete_file): Track deleted files in _files dictionary.
610         (TextFileReader.count_delete_only_file): Deleted.
611         * Scripts/webkitpy/style/filereader_unittest.py:
612         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
613         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
614         * Scripts/webkitpy/style/main.py:
615         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
616         explicitly run the association check on the file reader.
617         * Scripts/webkitpy/style/main_unittest.py:
618         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
619         embedded in the style checker.
620         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
621         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
622         construct the TextFileReader object with a StyleProcessor used to run style checks on
623         specific files.
624         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
625         testing the test expectation linter inside the style checker. This host must contain a
626         mock file system with the basic structure of test expectations.
627         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
628         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
629         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
630         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
631         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
632         * Scripts/webkitpy/style/patchreader.py:
633         (PatchReader.check): Specify which file was deleted, run the association check.
634         * Scripts/webkitpy/style/patchreader_unittest.py:
635         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
636         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
637         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
638
639 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
640
641         [WTF] Implement WTF::ThreadGroup
642         https://bugs.webkit.org/show_bug.cgi?id=174081
643
644         Reviewed by Mark Lam.
645
646         Add WTF::ThreadGroup tests.
647
648         * TestWebKitAPI/CMakeLists.txt:
649         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
650         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
651         (TestWebKitAPI::testThreadGroup):
652         (TestWebKitAPI::TEST):
653
654 2017-07-18  Andy Estes  <aestes@apple.com>
655
656         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
657         https://bugs.webkit.org/show_bug.cgi?id=174631
658
659         Reviewed by Tim Horton.
660
661         * DumpRenderTree/mac/Configurations/Base.xcconfig:
662         * MiniBrowser/Configurations/Base.xcconfig:
663         * MobileMiniBrowser/Configurations/Base.xcconfig:
664         * TestWebKitAPI/Configurations/Base.xcconfig:
665         * WebKitTestRunner/Configurations/Base.xcconfig:
666
667 2017-07-18  Andy Estes  <aestes@apple.com>
668
669         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
670         https://bugs.webkit.org/show_bug.cgi?id=174631
671
672         Reviewed by Sam Weinig.
673
674         * DumpRenderTree/mac/Configurations/Base.xcconfig:
675         * MiniBrowser/Configurations/Base.xcconfig:
676         * MobileMiniBrowser/Configurations/Base.xcconfig:
677         * TestWebKitAPI/Configurations/Base.xcconfig:
678         * WebKitTestRunner/Configurations/Base.xcconfig:
679
680 2017-07-18  Daniel Bates  <dabates@apple.com>
681
682         lldb: Add type summary for StringView
683         https://bugs.webkit.org/show_bug.cgi?id=174637
684
685         Reviewed by Sam Weinig.
686
687         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
688         StringView object will print output that has the form:
689
690             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
691               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
692               m_length = 2
693               m_is8Bit = true
694               m_underlyingString = 0x0000614000000a90
695             }
696
697         * lldb/lldb_webkit.py:
698         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
699         (WTFStringView_SummaryProvider):
700         (WTFStringViewProvider):
701         (WTFStringViewProvider.__init__):
702         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
703         (WTFStringViewProvider.get_length): Access field StringView.m_length.
704         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
705         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
706
707 2017-07-18  Andy Estes  <aestes@apple.com>
708
709         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
710         https://bugs.webkit.org/show_bug.cgi?id=174631
711
712         Reviewed by Dan Bernstein.
713
714         * DumpRenderTree/mac/Configurations/Base.xcconfig:
715         * MiniBrowser/Configurations/Base.xcconfig:
716         * MobileMiniBrowser/Configurations/Base.xcconfig:
717         * TestWebKitAPI/Configurations/Base.xcconfig:
718         * WebKitTestRunner/Configurations/Base.xcconfig:
719
720 2017-07-18  Devin Rousso  <drousso@apple.com>
721
722         Web Inspector: Add memoryCost to Inspector Protocol objects
723         https://bugs.webkit.org/show_bug.cgi?id=174478
724
725         Reviewed by Joseph Pecoraro.
726
727         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
728         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
729         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
730         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
731         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
732         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
733         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
734         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
735         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
736         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
737         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
738         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
739         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
740         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
741         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
742         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
743         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
744
745 2017-07-18  Andy Estes  <aestes@apple.com>
746
747         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
748         https://bugs.webkit.org/show_bug.cgi?id=174631
749
750         Reviewed by Darin Adler.
751
752         * DumpRenderTree/mac/Configurations/Base.xcconfig:
753         * MiniBrowser/Configurations/Base.xcconfig:
754         * MobileMiniBrowser/Configurations/Base.xcconfig:
755         * TestWebKitAPI/Configurations/Base.xcconfig:
756         * WebKitTestRunner/Configurations/Base.xcconfig:
757
758 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
759
760         Unreviewed, fix the iOS build.
761
762         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
763
764         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
765         (TestWebKitAPI::TEST):
766
767 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
768
769         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
770         https://bugs.webkit.org/show_bug.cgi?id=174585
771         <rdar://problem/33302541>
772
773         Reviewed by Tim Horton.
774
775         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
776         being dragged when initiating a drag.
777
778         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
779         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
780         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
781         (TestWebKitAPI::TEST):
782         * TestWebKitAPI/cocoa/TestWKWebView.h:
783
784         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
785
786         * TestWebKitAPI/cocoa/TestWKWebView.mm:
787         (-[TestWKWebView synchronouslyLoadHTMLString:]):
788
789 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
790
791         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
792         https://bugs.webkit.org/show_bug.cgi?id=174547
793
794         Reviewed by Alex Christensen.
795
796         * DumpRenderTree/PlatformWin.cmake:
797         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
798
799 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
800
801         Update style checker to deal with "final"
802         https://bugs.webkit.org/show_bug.cgi?id=174528
803
804         Reviewed by Alex Christensen.
805         
806         check-webkit-style shouldn't complain about an open brace to start a
807         line after a function definition with "final" or "const final".
808
809         * Scripts/webkitpy/style/checkers/cpp.py:
810         (check_braces):
811         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
812         (CppStyleTest.test_brace_at_begin_of_line):
813
814 2017-07-17  Alex Christensen  <achristensen@webkit.org>
815
816         Modernize content extension code
817         https://bugs.webkit.org/show_bug.cgi?id=174588
818
819         Reviewed by Sam Weinig.
820
821         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
822         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
823         (TestWebKitAPI::testRequest):
824         (TestWebKitAPI::makeBackend):
825         (TestWebKitAPI::TEST_F):
826
827 2017-07-17  Brady Eidson  <beidson@apple.com>
828
829         WKHTTPCookieStore observing only works on the default cookie store.
830         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
831
832         Reviewed by Sam Weinig.
833
834         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
835         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
836           called for the default store, a non-persistent store, and a custom store.
837         (TEST):
838
839 2017-07-16  Sam Weinig  <sam@webkit.org>
840
841         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
842         https://bugs.webkit.org/show_bug.cgi?id=174575
843
844         Reviewed by Brady Eidson.
845
846         * Scripts/svn-create-patch:
847         (findModificationType):
848         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
849         default value of "unknown".
850
851         (generateFileList):
852         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
853         for untracked, which matches our old behavior.
854
855 2017-07-17  Charlie Turner  <cturner@igalia.com>
856
857         Add some missing build dependencies on Fedora
858         https://bugs.webkit.org/show_bug.cgi?id=174578
859
860         Unreviewed dependency update.
861
862         * gtk/install-dependencies:
863
864 2017-07-16  Brady Eidson  <beidson@apple.com>
865
866         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
867         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
868
869         Reviewed by Tim Horton.
870
871         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
872         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
873         (TEST):
874
875 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
876
877         [GTK] Sort inspector GResource manifest to ensure reproducible builds
878         https://bugs.webkit.org/show_bug.cgi?id=174540
879
880         Reviewed by Michael Catanzaro.
881
882         * gtk/generate-inspector-gresource-manifest.py:
883         (get_filenames): sort list of input files
884
885 2017-07-15  Brady Eidson  <beidson@apple.com>
886
887         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
888         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
889
890         Reviewed by Tim Horton.
891
892         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
893         (TEST): Make this test more reliable by clearing everything beforehand.
894
895 2017-07-15  David Kilzer  <ddkilzer@apple.com>
896
897         Make it possible to extend check-webkit-style with Apple-internal checkers
898         <https://webkit.org/b/174464>
899         <rdar://problem/25564402>
900
901         Reviewed by Darin Adler.
902
903         * Scripts/webkitpy/style/checker.py: Import apple_additions.
904         (_all_categories): Add categories from apple_additions() if it
905         exists.
906         (CheckerDispatcher._create_checker): Create python checker
907         from apple_additions() if it exists.
908
909 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
910
911         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
912         https://bugs.webkit.org/show_bug.cgi?id=174539
913         <rdar://problem/33307395>
914
915         Reviewed by Darin Adler.
916
917         Adds a new unit test suite to cover action sheet popover presentation.
918
919         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
920         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
921         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
922         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
923
924         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
925
926         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
927         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
928
929         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
930
931         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
932         (TestWebKitAPI::TEST):
933
934 2017-07-15  Sam Weinig  <sam@webkit.org>
935
936         [Scripts] Make svn-create-patch work better when called in sub directories
937         https://bugs.webkit.org/show_bug.cgi?id=174551
938
939         Reviewed by Darin Adler.
940
941         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
942           by ensuring that the prefix is applied as is done in generateDiff.
943         - Silence output of explanatory lines from svn stat (" > move to ...")
944           that show up in STDERR when running svn-create-patch.
945         - Add verbose logging that I found useful while debugging this issue.
946
947         * Scripts/svn-create-patch:
948         (findBaseUrl):
949         (findMimeType):
950         (findSourceFileAndRevision):
951         (generateDiff):
952         (generateFileList):
953         (manufacturePatchForAdditionWithHistory):
954
955 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
956
957         Unreviewed build fix after r219537.
958
959         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
960
961 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
962
963         Add iOS 11 SPI
964         https://bugs.webkit.org/show_bug.cgi?id=174430
965         <rdar://problem/33269288>
966
967         Reviewed by Tim Horton.
968
969         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
970         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
971         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
972
973 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
974
975         Failing to install on iPad simulators
976         https://bugs.webkit.org/show_bug.cgi?id=174532
977         <rdar://problem/33328347>
978
979         Reviewed by Stephanie Lewis.
980
981         * Scripts/webkitpy/xcode/simulated_device.py:
982         (SimulatedDevice.install_app): Place install command in retry try-except block.
983
984 2017-07-14  Jeff Miller  <jeffm@apple.com>
985
986         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
987         https://bugs.webkit.org/show_bug.cgi?id=174524
988
989         Reviewed by Sam Weinig.
990
991         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
992         (TEST):
993         Renamed TestParameter to TestParameter1.
994         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
995
996         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
997         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
998         Observe changes for two bundle parameters.
999
1000         (-[BundleParametersPlugIn dealloc]):
1001         Remove observers for two bundle parameters.
1002
1003 2017-07-14  Commit Queue  <commit-queue@webkit.org>
1004
1005         Unreviewed, rolling out r219510.
1006         https://bugs.webkit.org/show_bug.cgi?id=174525
1007
1008         Need to revert length() == 0 check for null string (Requested
1009         by yusukesuzuki on #webkit).
1010
1011         Reverted changeset:
1012
1013         "[WTF] Newly added AtomicStringImpl should use BufferInternal
1014         static string if StringImpl is static"
1015         https://bugs.webkit.org/show_bug.cgi?id=174501
1016         http://trac.webkit.org/changeset/219510
1017
1018 2017-07-14  Jer Noble  <jer.noble@apple.com>
1019
1020         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
1021         https://bugs.webkit.org/show_bug.cgi?id=174514
1022
1023         Reviewed by Sam Weinig.
1024
1025         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
1026         (TestWebKitAPI::TEST_F):
1027
1028 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1029
1030         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1031         https://bugs.webkit.org/show_bug.cgi?id=174501
1032
1033         Reviewed by Darin Adler.
1034
1035         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1036         (TestWebKitAPI::TEST):
1037
1038 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1039
1040         Bring mac expectations in-line with other platforms
1041         https://bugs.webkit.org/show_bug.cgi?id=174472
1042         <rdar://problem/33297388>
1043
1044         Reviewed by David Kilzer.
1045
1046         The override order for Mac test expectations does not conform to the pattern used by iOS,
1047         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
1048
1049             platform/mac-wk2
1050             platform/wk2
1051             platform/mac-elcapitan
1052             platform/mac-sierra
1053             generic
1054
1055         After this change, El Capitan's baseline search path looks like this:
1056
1057             platform/mac-sierra-wk2
1058             platform/mac-sierra
1059             platform/mac-wk2
1060             platform/wk2
1061             generic
1062
1063         * Scripts/webkitpy/port/mac.py:
1064         (MacPort.__init__): If a specific version is specified in the port name, use that
1065         as the os version.
1066         (MacPort.default_baseline_search_path): Expectation search paths should work the
1067         same way they do on other ports. Port + version overrides port, port overrides generic
1068         and wk1/wk2 should override expectations for the two combined.
1069         * Scripts/webkitpy/port/mac_unittest.py:
1070         (MacTest.test_tests_for_other_platforms): Deleted.
1071         (MacTest._assert_search_path): Deleted.
1072         (MacTest.test_baseline_search_path): Deleted.
1073         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1074         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
1075         (test_rebaseline_test_and_print_scm_changes): Ditto.
1076         (test_rebaseline_and_copy_test): Ditto.
1077         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
1078         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
1079         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
1080
1081 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1082
1083         Fix style checker unit test
1084
1085         Unreviewed WebKit2 => WebKit fixup.
1086
1087         * Scripts/webkitpy/style/checker_unittest.py:
1088         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1089
1090 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1091
1092         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
1093
1094         Unreviewed build fix.
1095
1096         r219492 missed one hunk from its partial revert of r219489.
1097         This patch reverts that hunk.
1098
1099         * TestWebKitAPI/CMakeLists.txt:
1100
1101 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1102
1103         Use the old WebKit/WebKit2 targets for CMake builds.
1104
1105         Unreviewed build fix.
1106
1107         We can update the target names to match the Framework names in a future patch.
1108         This is a partial revert of r219489.
1109
1110         * TestWebKitAPI/CMakeLists.txt:
1111         WebKitLegacy => WebKit
1112         WebKit => WebKit2
1113
1114 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1115
1116         Fix TestWebKit API.
1117         https://bugs.webkit.org/show_bug.cgi?id=174164
1118         rdar://problem/33137595
1119
1120         Reviewed by Dan Bernstein.
1121
1122         * TestWebKitAPI/CMakeLists.txt:
1123         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1124         * TestWebKitAPI/PlatformGTK.cmake:
1125
1126 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1127
1128         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
1129         https://bugs.webkit.org/show_bug.cgi?id=174164
1130         rdar://problem/33137595
1131
1132         Reviewed by Dan Bernstein.
1133
1134         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1135         (ShouldBuildTest):
1136         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1137         * Scripts/build-webkit:
1138         * Scripts/do-file-rename:
1139         * Scripts/do-webcore-rename:
1140         * Scripts/update-webkit-localizable-strings:
1141         * Scripts/webkitpy/common/config/watchlist:
1142         * Scripts/webkitpy/style/checker.py:
1143         * Scripts/webkitpy/style/checkers/featuredefines.py:
1144         * gtk/make-dist.py:
1145         (ensure_version_if_possible):
1146         * gtk/manifest.txt.in:
1147
1148 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
1149
1150         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
1151         https://bugs.webkit.org/show_bug.cgi?id=174162
1152         rdar://problem/33137594
1153
1154         Reviewed by Dan Bernstein.
1155
1156         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
1157
1158         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1159         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1160         * EWSTools/configure-clang-linux.sh:
1161         * Scripts/build-webkit:
1162         * Scripts/do-file-rename:
1163         * Scripts/do-webcore-rename:
1164         * Scripts/update-webkit-localizable-strings:
1165         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1166         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1167         * Scripts/webkitpy/style/checkers/featuredefines.py:
1168         * gtk/manifest.txt.in:
1169
1170 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
1171
1172         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
1173         https://bugs.webkit.org/show_bug.cgi?id=174438
1174         <rdar://problem/33277112>
1175
1176         Reviewed by Aakash Jain.
1177
1178         Given a patch, this will convert the changes from the path to the new directory structure.
1179
1180         * Scripts/rebase-patch-after-webkit-move: Added.
1181         (append_source): Append 'Source' to the provided path.
1182         (is_editable_line): Return true if a line the script expects to modify.
1183         (needs_rebase): Return if a line needs to be rebased based on it's content.
1184         (rebase_line): Rebase the provided line.
1185         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
1186         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
1187         were provided.
1188
1189 2017-07-12  Nan Wang  <n_wang@apple.com>
1190
1191         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1192         https://bugs.webkit.org/show_bug.cgi?id=174393
1193         <rdar://problem/33248006>
1194
1195         Reviewed by Chris Fleizach.
1196
1197         * DumpRenderTree/AccessibilityUIElement.cpp:
1198         (textMarkerRangeMatchesTextNearMarkersCallback):
1199         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1200         (AccessibilityUIElement::getJSClass):
1201         * DumpRenderTree/AccessibilityUIElement.h:
1202         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1203         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1204         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1205         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1206         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1207         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1208         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1209         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1210
1211 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1212
1213         Unreviewed, rolling out r219409.
1214
1215         The revision caused the Windows builds to fail.
1216
1217         Reverted changeset:
1218
1219         "AX: [iOS] Implement a way to retrieve a text marker range
1220         with desired text that is closest to a position"
1221         https://bugs.webkit.org/show_bug.cgi?id=174393
1222         http://trac.webkit.org/changeset/219409
1223
1224 2017-07-12  Nan Wang  <n_wang@apple.com>
1225
1226         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1227         https://bugs.webkit.org/show_bug.cgi?id=174393
1228         <rdar://problem/33248006>
1229
1230         Reviewed by Chris Fleizach.
1231
1232         * DumpRenderTree/AccessibilityUIElement.cpp:
1233         (textMarkerRangeMatchesTextNearMarkersCallback):
1234         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1235         (AccessibilityUIElement::getJSClass):
1236         * DumpRenderTree/AccessibilityUIElement.h:
1237         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1238         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1239         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1240         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1241         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1242         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1243         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1244         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1245
1246 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
1247
1248         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
1249         https://bugs.webkit.org/show_bug.cgi?id=174197
1250
1251         Reviewed by Darin Adler.
1252
1253         This bit me the first time I tried to submit a patch to WebKit, and still I have
1254         to manually edit the ChangeLog every time I use the script.
1255
1256         This generates a more convenient and standard ChangeLog entry.
1257
1258         * Scripts/prepare-ChangeLog:
1259         (generateNewChangeLogs):
1260
1261 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1262
1263         Unreviewed, rolling out r219401.
1264
1265         This revision rolled out the previous patch, but after talking
1266         with reviewer, a rebaseline is what was needed.Rolling back in
1267         before rebaseline.
1268
1269         Reverted changeset:
1270
1271         "Unreviewed, rolling out r219379."
1272         https://bugs.webkit.org/show_bug.cgi?id=174400
1273         http://trac.webkit.org/changeset/219401
1274
1275 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1276
1277         Unreviewed, rolling out r219379.
1278
1279         This revision caused a consistent failure in the test
1280         fast/dom/Window/property-access-on-cached-window-after-frame-
1281         removed.html.
1282
1283         Reverted changeset:
1284
1285         "Remove NAVIGATOR_HWCONCURRENCY"
1286         https://bugs.webkit.org/show_bug.cgi?id=174400
1287         http://trac.webkit.org/changeset/219379
1288
1289 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1290
1291         [WPE] Use libepoxy
1292         https://bugs.webkit.org/show_bug.cgi?id=172104
1293
1294         Reviewed by Michael Catanzaro.
1295
1296         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
1297         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
1298
1299 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1300
1301         [GTK][WPE] Align Jhbuild patches for GStreamer packages
1302         https://bugs.webkit.org/show_bug.cgi?id=174363
1303
1304         Reviewed by Michael Catanzaro.
1305
1306         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
1307         between the GTK+ and WPE port. There's no reason for the two ports to apply
1308         different patches over same versions of GStreamer releases.
1309
1310         This aligns the two ports on this specific issue. Next we'll look into
1311         creating a single GStreamer-specific Jhbuild moduleset that will allow us
1312         to keep these patches in a single place, avoiding duplicate files.
1313
1314         * gtk/jhbuild.modules:
1315         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1316         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
1317         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1318         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
1319
1320 2017-07-11  Dean Jackson  <dino@apple.com>
1321
1322         Remove NAVIGATOR_HWCONCURRENCY
1323         https://bugs.webkit.org/show_bug.cgi?id=174400
1324
1325         Reviewed by Sam Weinig.
1326
1327         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1328
1329 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
1330
1331         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
1332         https://bugs.webkit.org/show_bug.cgi?id=174239
1333
1334         Reviewed by Brady Eidson.
1335
1336         Create windows with specific features set and make sure those are properly reflected in the
1337         WKWindowFeatures object.
1338
1339         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1340         (resetToConsistentState):
1341         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1342         (TEST):
1343
1344 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
1345
1346         Do not duplicate files when deleting directories with svn 1.9
1347         https://bugs.webkit.org/show_bug.cgi?id=174339
1348         <rdar://problem/33226781>
1349
1350         Reviewed by David Kilzer.
1351
1352         * Scripts/svn-create-patch:
1353         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
1354         (generateFileList): Determine which files are deleted because they are part of a
1355         directory being deleted.
1356
1357 2017-07-11  Dean Jackson  <dino@apple.com>
1358
1359         Rolling out r219372.
1360
1361         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1362
1363 2017-07-11  Dean Jackson  <dino@apple.com>
1364
1365         Remove NAVIGATOR_HWCONCURRENCY
1366         https://bugs.webkit.org/show_bug.cgi?id=174400
1367
1368         Reviewed by Sam Weinig.
1369
1370         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1371
1372 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1373
1374         Teach build workers to fetch archives from S3.
1375         https://bugs.webkit.org/show_bug.cgi?id=174384
1376
1377         Reviewed by Aakash Jain.
1378
1379         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1380         (DownloadBuiltProduct):
1381
1382 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1383
1384         Configure buildbot to transfer all archives to S3.
1385         Previously this was Mac only, but it's time to expand!
1386         https://bugs.webkit.org/show_bug.cgi?id=174378
1387         
1388         Reviewed by Aakash Jain.
1389
1390         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1391         (BuildFactory.__init__):
1392
1393 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
1394
1395         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
1396         https://bugs.webkit.org/show_bug.cgi?id=174350
1397
1398         Reviewed by Xabier Rodriguez-Calvar.
1399
1400         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
1401         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
1402         patches are removed. The patches for gst-plugins-good are updated, removing
1403         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
1404         rtpbin elements that will help with the EMEv3 development.
1405
1406         * wpe/jhbuild.modules:
1407         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1408         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1409         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
1410         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1411         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1412         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1413         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1414         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1415         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1416
1417 2017-07-10  John Wilander  <wilander@apple.com>
1418
1419         Resource Load Statistics: Prune statistics in orders of importance
1420         https://bugs.webkit.org/show_bug.cgi?id=174215
1421         <rdar://problem/33164403>
1422
1423         Reviewed by Chris Dumez.
1424
1425         Nest infrastructure. Adds these functions:
1426         1. testRunner.setStatisticsLastSeen()
1427         2. setStatisticsMaxStatisticsEntries()
1428         3. setStatisticsPruneEntriesDownTo()
1429
1430         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1431         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1432         (WTR::TestRunner::setStatisticsLastSeen):
1433         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1434         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1435         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1436         * WebKitTestRunner/TestController.cpp:
1437         (WTR::TestController::setStatisticsLastSeen):
1438         (WTR::TestController::setMaxStatisticsEntries):
1439         (WTR::TestController::setPruneEntriesDownTo):
1440         * WebKitTestRunner/TestController.h:
1441         * WebKitTestRunner/TestInvocation.cpp:
1442         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1443         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1444         (WTR::TestController::setStatisticsLastSeen):
1445         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1446         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1447
1448 2017-07-03  Brian Burg  <bburg@apple.com>
1449
1450         Web Replay: remove some unused code
1451         https://bugs.webkit.org/show_bug.cgi?id=173903
1452
1453         Rubber-stamped by Joseph Pecoraro.
1454
1455         * Scripts/run-input-generator-tests: Removed.
1456         * Scripts/webkitpy/replay/__init__.py: Removed.
1457         * Scripts/webkitpy/replay/main.py: Removed.
1458
1459 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
1460
1461         [WPE] Fix layout test baseline and TestExpectations hierarchy
1462         https://bugs.webkit.org/show_bug.cgi?id=174092
1463
1464         Reviewed by Michael Catanzaro.
1465
1466         Like for the GTK+ port, override the default_baseline_search_path() and
1467         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
1468         Both methods operate on a short list of search paths that defaults to 'wpe' and
1469         'wk2', along with any other user-specified platform directory.
1470
1471         The test_expectations_file_position() method is overridden for testing purposes,
1472         and relevant unit tests are added.
1473
1474         * Scripts/webkitpy/port/wpe.py:
1475         (WPEPort._search_paths):
1476         (WPEPort):
1477         (WPEPort.default_baseline_search_path):
1478         (WPEPort._port_specific_expectations_files):
1479         (WPEPort.test_expectations_file_position):
1480         * Scripts/webkitpy/port/wpe_unittest.py:
1481         (WPEPortTest.test_default_baseline_search_path):
1482         (WPEPortTest):
1483         (WPEPortTest.test_port_specific_expectations_files):
1484
1485 2017-07-10  Chris Dumez  <cdumez@apple.com>
1486
1487         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
1488         https://bugs.webkit.org/show_bug.cgi?id=174301
1489
1490         Reviewed by Brent Fulgham.
1491
1492         Rename some of the testRunner API for clarity and to better match what it calls
1493         internally.
1494
1495         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1496         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1497         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1498         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1499         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1500         * WebKitTestRunner/TestController.cpp:
1501         (WTR::TestController::statisticsUpdateCookiePartitioning):
1502         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1503         * WebKitTestRunner/TestController.h:
1504         * WebKitTestRunner/TestInvocation.cpp:
1505         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1506         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1507         (WTR::TestController::statisticsUpdateCookiePartitioning):
1508         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1509
1510 2017-07-10  Charlie Turner  <cturner@igalia.com>
1511
1512         [GStreamer] Live twitch.tv videos do not play
1513         https://bugs.webkit.org/show_bug.cgi?id=174222
1514
1515         Reviewed by Michael Catanzaro.
1516
1517         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
1518         fixes videos not playing on twitch.tv.
1519
1520         * gtk/jhbuild.modules:
1521
1522 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
1523
1524         Add WebGL2 configuration option to build-webkit
1525         https://bugs.webkit.org/show_bug.cgi?id=174251
1526
1527         Reviewed by Michael Catanzaro.
1528
1529         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
1530         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
1531         is marked as enabled for the Apple Cocoa ports.
1532
1533 2017-07-08  Chris Dumez  <cdumez@apple.com>
1534
1535         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
1536         https://bugs.webkit.org/show_bug.cgi?id=174290
1537
1538         Reviewed by Brent Fulgham.
1539
1540         Rename testRunner API to match the new internal API names.
1541
1542         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1543         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1544         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1545         (WTR::TestRunner::statisticsSubmitTelemetry):
1546         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1547         * WebKitTestRunner/TestController.cpp:
1548         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1549         (WTR::TestController::statisticsSubmitTelemetry):
1550         * WebKitTestRunner/TestController.h:
1551         * WebKitTestRunner/TestInvocation.cpp:
1552         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1553         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1554         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1555         (WTR::TestController::statisticsSubmitTelemetry):
1556
1557 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1558
1559         Drop NOSNIFF compile flag
1560         https://bugs.webkit.org/show_bug.cgi?id=174289
1561
1562         Reviewed by Michael Catanzaro.
1563
1564         * Scripts/webkitperl/FeatureList.pm:
1565         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1566
1567 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1568
1569         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
1570         https://bugs.webkit.org/show_bug.cgi?id=174219
1571         <rdar://problem/32083177>
1572
1573         Reviewed by Ryosuke Niwa.
1574
1575         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
1576         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
1577         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
1578         place.
1579
1580         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
1581         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
1582         no action is taken when dropping.
1583
1584         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
1585         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1586         (TestWebKitAPI::TEST):
1587         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1588         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1589         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
1590         (-[MockDragDropSession allowsMoveOperation]):
1591         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
1592         (-[MockDataInteractionSession initWithWindow:allowMove:]):
1593         (-[DataInteractionSimulator initWithWebView:]):
1594         (-[DataInteractionSimulator runFrom:to:]):
1595         (-[DataInteractionSimulator _advanceProgress]):
1596         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
1597         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
1598         (-[MockDataInteractionSession initWithWindow:]): Deleted.
1599
1600 2017-07-07  Commit Queue  <commit-queue@webkit.org>
1601
1602         Unreviewed, rolling out r219238, r219239, and r219241.
1603         https://bugs.webkit.org/show_bug.cgi?id=174265
1604
1605         "fast/workers/dedicated-worker-lifecycle.html is flaky"
1606         (Requested by yusukesuzuki on #webkit).
1607
1608         Reverted changesets:
1609
1610         "[WTF] Implement WTF::ThreadGroup"
1611         https://bugs.webkit.org/show_bug.cgi?id=174081
1612         http://trac.webkit.org/changeset/219238
1613
1614         "Unreviewed, build fix after r219238"
1615         https://bugs.webkit.org/show_bug.cgi?id=174081
1616         http://trac.webkit.org/changeset/219239
1617
1618         "Unreviewed, CLoop build fix after r219238"
1619         https://bugs.webkit.org/show_bug.cgi?id=174081
1620         http://trac.webkit.org/changeset/219241
1621
1622 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1623
1624         [GTK][WPE] Enable X-Content-Type-Options: nosniff
1625         https://bugs.webkit.org/show_bug.cgi?id=174250
1626
1627         Reviewed by Carlos Alberto Lopez Perez.
1628
1629         * Scripts/webkitperl/FeatureList.pm:
1630
1631 2017-07-07  Charlie Turner  <cturner@igalia.com>
1632         [GStreamer] vid.me videos do not play
1633         https://bugs.webkit.org/show_bug.cgi?id=172240
1634
1635         Reviewed by Xabier Rodriguez-Calvar.
1636
1637         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1638         have the existing libsoup build against GNOME to avoid header drift
1639         against GStreamer's linked Soup library.
1640
1641         * gtk/jhbuild.modules:
1642
1643 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1644
1645         Write a support script to enable buildbot to upload to S3
1646         https://bugs.webkit.org/show_bug.cgi?id=174196
1647         
1648         Reviewed by Stephanie Lewis.
1649
1650         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
1651         (uploadToS3):
1652         (archiveExists):
1653
1654 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1655
1656         Enabling uploading archives to S3.
1657         https://bugs.webkit.org/show_bug.cgi?id=174198
1658         
1659         Reviewed by Stephanie Lewis.
1660
1661         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1662         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1663         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1664         (TransferToS3): Transfer full and minified archives to S3
1665
1666 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1667
1668         [WTF] Implement WTF::ThreadGroup
1669         https://bugs.webkit.org/show_bug.cgi?id=174081
1670
1671         Reviewed by Mark Lam.
1672
1673         Add WTF::ThreadGroup tests.
1674
1675         * TestWebKitAPI/CMakeLists.txt:
1676         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1677         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1678         (TestWebKitAPI::TEST):
1679
1680 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1681
1682         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1683         https://bugs.webkit.org/show_bug.cgi?id=174150
1684
1685         Reviewed by Mark Lam.
1686
1687         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1688         (TestWebKitAPI::TEST):
1689         * TestWebKitAPI/TestsController.cpp:
1690         (TestWebKitAPI::TestsController::TestsController):
1691
1692 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1693
1694         Enabling uploading archives to S3.
1695         https://bugs.webkit.org/show_bug.cgi?id=174198
1696         
1697         Reviewed by Lucas Forschler.
1698
1699         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1700         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1701         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1702         (TransferToS3): Transfer full and minified archives to S3
1703
1704 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1705
1706         [GTK][WPE] kill-old-process should kill more webkit related process
1707         https://bugs.webkit.org/show_bug.cgi?id=174220
1708
1709         Reviewed by Michael Catanzaro.
1710
1711         Generate list of possible webkit-related process names and add
1712         them to the list of process to kill.
1713         Also update the possible system related process for GTK+/WPE.
1714
1715         * BuildSlaveSupport/kill-old-processes:
1716         (listAllWebKitPrograms):
1717         (main):
1718
1719 2017-07-06  Chris Dumez  <cdumez@apple.com>
1720
1721         FileMonitor should not be ref counted
1722         https://bugs.webkit.org/show_bug.cgi?id=174166
1723
1724         Reviewed by Brent Fulgham.
1725
1726         Update the API tests to reflect the API change.
1727
1728         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1729         (TestWebKitAPI::TEST_F):
1730
1731 2017-07-06  Commit Queue  <commit-queue@webkit.org>
1732
1733         Unreviewed, rolling out r219194.
1734         https://bugs.webkit.org/show_bug.cgi?id=174207
1735
1736         it broke some layout tests (Requested by clopez on #webkit).
1737
1738         Reverted changeset:
1739
1740         "[GStreamer] vid.me videos do not play"
1741         https://bugs.webkit.org/show_bug.cgi?id=172240
1742         http://trac.webkit.org/changeset/219194
1743
1744 2017-07-06  Matt Lewis  <jlewis3@apple.com>
1745
1746         Unreviewed, rolling out r219178.
1747
1748         This caused a consistent failure with the API test
1749         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
1750
1751         Reverted changeset:
1752
1753         "[WTF] Clean up StringStatics.cpp by using
1754         LazyNeverDestroyed<> for Atoms"
1755         https://bugs.webkit.org/show_bug.cgi?id=174150
1756         http://trac.webkit.org/changeset/219178
1757
1758 2017-07-06  Alicia Boya García  <aboya@igalia.com>
1759
1760         Add CWD to Perl library path (no longer the default since 5.26.0)
1761         https://bugs.webkit.org/show_bug.cgi?id=174200
1762
1763         Reviewed by Michael Catanzaro.
1764
1765         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1766         (SetupGitClone._get_username_and_email):
1767
1768 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1769
1770         Unreviewed, update my email address.
1771
1772         * Scripts/webkitpy/common/config/contributors.json:
1773
1774 2017-07-06  Charlie Turner  <cturner@igalia.com>
1775         [GStreamer] vid.me videos do not play
1776         https://bugs.webkit.org/show_bug.cgi?id=172240
1777
1778         Reviewed by Xabier Rodriguez-Calvar.
1779
1780         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1781         have the existing libsoup build against GNOME to avoid header drift
1782         against GStreamer's linked Soup library.
1783
1784         * gtk/jhbuild.modules:
1785
1786 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1787
1788         [WTF] Move SoftLinking.h into WTF
1789         https://bugs.webkit.org/show_bug.cgi?id=174000
1790
1791         Reviewed by Alex Christensen.
1792
1793         * DumpRenderTree/mac/TestRunnerMac.mm:
1794         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1795         (test_primary_header):
1796         (ErrorCollector.__init__): Deleted.
1797         (ErrorCollector.__call__): Deleted.
1798         (ErrorCollector.results): Deleted.
1799         (ErrorCollector.result_list): Deleted.
1800         (ErrorCollector.verify_all_categories_are_seen): Deleted.
1801         (MockIo.open): Deleted.
1802         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
1803         (CppFunctionsTest.test_create_acronym): Deleted.
1804         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
1805         (CppFunctionsTest.test_parameter): Deleted.
1806         (CppFunctionsTest.test_single_line_view): Deleted.
1807         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
1808         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
1809         (CppFunctionsTest.test_parameter_list): Deleted.
1810         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
1811         (CppStyleTestBase.process_file_data): Deleted.
1812         (CppStyleTestBase.perform_lint): Deleted.
1813         (CppStyleTestBase.perform_single_line_lint): Deleted.
1814         (CppStyleTestBase.perform_multi_line_lint): Deleted.
1815         (CppStyleTestBase.perform_language_rules_check): Deleted.
1816         (CppStyleTestBase.perform_function_lengths_check): Deleted.
1817         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
1818         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
1819         (CppStyleTestBase.perform_include_what_you_use): Deleted.
1820         (CppStyleTestBase.perform_header_guard_check): Deleted.
1821         (CppStyleTestBase.assert_lint): Deleted.
1822         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
1823         (CppStyleTestBase.assert_multi_line_lint): Deleted.
1824         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
1825         (CppStyleTestBase.assert_language_rules_check): Deleted.
1826         (CppStyleTestBase.assert_include_what_you_use): Deleted.
1827         (CppStyleTestBase.assert_header_guard): Deleted.
1828         (CppStyleTestBase.assert_blank_lines_check): Deleted.
1829         (CppStyleTestBase.assert_positions_equal): Deleted.
1830         (FunctionDetectionTest.test_basic_function_detection): Deleted.
1831         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
1832         (FunctionDetectionTest.test_pure_function_detection): Deleted.
1833         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
1834         (FunctionDetectionTest.test_ignore_macros): Deleted.
1835         (FunctionDetectionTest.test_non_functions): Deleted.
1836         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
1837         (FunctionDetectionTest.test_parameter_list): Deleted.
1838         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
1839         (CppStyleTest.test_asm_lines_ignored): Deleted.
1840         (CppStyleTest.test_get_line_width): Deleted.
1841         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
1842         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
1843         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
1844         (CppStyleTest.test_position): Deleted.
1845         (CppStyleTest.test_rfind_in_lines): Deleted.
1846         (CppStyleTest.test_close_expression): Deleted.
1847         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
1848         (CppStyleTest.test_cstyle_cast): Deleted.
1849         (CppStyleTest.test_runtime_casting): Deleted.
1850         (CppStyleTest.test_runtime_selfinit): Deleted.
1851         (CppStyleTest.test_runtime_rtti): Deleted.
1852         (CppStyleTest.test_static_cast_readability): Deleted.
1853         (CppStyleTest.test_check_for_unnamed_params): Deleted.
1854         (CppStyleTest.void): Deleted.
1855         (CppStyleTest.test_deprecated_cast): Deleted.
1856         (CppStyleTest.test_mock_method): Deleted.
1857         (CppStyleTest.test_sizeof_type): Deleted.
1858         (CppStyleTest.cases): Deleted.
1859         (CppStyleTest.for): Deleted.
1860         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
1861         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
1862         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
1863         (CppStyleTest.test_include_what_you_use): Deleted.
1864         (CppStyleTest.test_files_belong_to_same_module): Deleted.
1865         (CppStyleTest.test_cleanse_line): Deleted.
1866         (CppStyleTest.test_multi_line_comments): Deleted.
1867         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
1868         (CppStyleTest.test_multiline_strings): Deleted.
1869         (CppStyleTest.test_platformh_comments): Deleted.
1870         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
1871         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
1872         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
1873         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
1874         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
1875         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
1876         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
1877         (CppStyleTest.test_check_posix_threading): Deleted.
1878         (CppStyleTest.test_insecure_string_operations): Deleted.
1879         (CppStyleTest.test_format_strings): Deleted.
1880         (CppStyleTest.test_insecure_temp_file): Deleted.
1881         (CppStyleTest.test_variable_length_array_detection): Deleted.
1882         (CppStyleTest.test_braces): Deleted.
1883         (CppStyleTest.test_check_check): Deleted.
1884         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
1885         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
1886         (CppStyleTest.test_spacing_for_fncall): Deleted.
1887         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
1888         (CppStyleTest.test_spacing_before_braces): Deleted.
1889         (CppStyleTest.test_spacing_between_braces): Deleted.
1890         (CppStyleTest.test_spacing_before_brackets): Deleted.
1891         (CppStyleTest.test_cpp_lambda_functions): Deleted.
1892         (CppStyleTest.test_objective_c_block): Deleted.
1893         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
1894         (CppStyleTest.test_spacing_around_else): Deleted.
1895         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
1896         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
1897         (CppStyleTest.test_operator_methods): Deleted.
1898         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
1899         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
1900         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
1901         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
1902         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
1903         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
1904         (CppStyleTest.test_space_after_comment_marker): Deleted.
1905         (CppStyleTest.test_newline_at_eof): Deleted.
1906         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
1907         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
1908         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
1909         (CppStyleTest.test_invalid_utf8): Deleted.
1910         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
1911         (CppStyleTest.test_is_blank_line): Deleted.
1912         (CppStyleTest.test_blank_lines_check): Deleted.
1913         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
1914         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
1915         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
1916         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
1917         (CppStyleTest.test_comma): Deleted.
1918         (CppStyleTest.test_declaration): Deleted.
1919         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
1920         (CppStyleTest.test_indent): Deleted.
1921         (CppStyleTest.test_indent.Foo): Deleted.
1922         (CppStyleTest.test_not_alabel): Deleted.
1923         (CppStyleTest.test_tab): Deleted.
1924         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
1925         (CppStyleTest.test_build_class): Deleted.
1926         (CppStyleTest.test_build_class.definitions): Deleted.
1927         (CppStyleTest.test_build_class.Foo): Deleted.
1928         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
1929         (CppStyleTest.test_build_end_comment): Deleted.
1930         (CppStyleTest.test_build_forward_decl): Deleted.
1931         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
1932         (CppStyleTest.test_build_header_guard): Deleted.
1933         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
1934         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
1935         (CppStyleTest.test_build_printf_format): Deleted.
1936         (CppStyleTest.test_runtime_printf_format): Deleted.
1937         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
1938         (CppStyleTest.test_build_storage_class): Deleted.
1939         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
1940         (CppStyleTest.test_build_storage_class.declaration): Deleted.
1941         (CppStyleTest.test_build_storage_class.after): Deleted.
1942         (CppStyleTest.test_build_storage_class.is): Deleted.
1943         (CppStyleTest.test_legal_copyright): Deleted.
1944         (CppStyleTest.test_invalid_increment): Deleted.
1945         (CppStyleTest.test_enum_bitfields): Deleted.
1946         (CppStyleTest.test_plain_integral_bitfields): Deleted.
1947         (CleansedLinesTest.test_init_empty): Deleted.
1948         (CleansedLinesTest.test_collapse_strings): Deleted.
1949         (OrderOfIncludesTest.tearDown): Deleted.
1950         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
1951         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
1952         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
1953         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
1954         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
1955         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
1956         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
1957         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
1958         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
1959         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
1960         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
1961         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
1962         (OrderOfIncludesTest.test_primary_header): Deleted.
1963         (OrderOfIncludesTest.test_public_primary_header): Deleted.
1964         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
1965         (OrderOfIncludesTest.test_classify_include): Deleted.
1966         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
1967         (CheckForFunctionLengthsTest.tearDown): Deleted.
1968         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
1969         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
1970         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
1971         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
1972         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
1973         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
1974         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
1975         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
1976         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
1977         (CheckForFunctionLengthsTest.function_body): Deleted.
1978         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
1979         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
1980         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
1981         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
1982         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
1983         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
1984         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
1985         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
1986         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
1987         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
1988         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
1989         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
1990         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
1991         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
1992         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
1993         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
1994         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
1995         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
1996         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
1997         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
1998         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
1999         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
2000         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
2001         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
2002         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
2003         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
2004         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
2005         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
2006         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
2007         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
2008         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
2009         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
2010         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
2011         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
2012         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
2013         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
2014         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
2015         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
2016         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
2017         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
2018         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
2019         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
2020         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
2021         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
2022         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
2023         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
2024         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
2025         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
2026         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
2027         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
2028         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
2029         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
2030         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
2031         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
2032         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
2033         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
2034         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
2035         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
2036         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
2037         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
2038         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
2039         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
2040         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
2041         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
2042         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
2043         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
2044         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
2045         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
2046         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
2047         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
2048         (LeakyPatternTest.test_get_dc): Deleted.
2049         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
2050         (LeakyPatternTest.test_own_get_dc): Deleted.
2051         (LeakyPatternTest.test_create_dc): Deleted.
2052         (LeakyPatternTest.test_create_compatible_dc): Deleted.
2053         (WebKitStyleTest.test_indentation): Deleted.
2054         (WebKitStyleTest.test_indentation.Foo): Deleted.
2055         (WebKitStyleTest.test_indentation.Document): Deleted.
2056         (WebKitStyleTest.test_spacing): Deleted.
2057         (WebKitStyleTest.test_line_breaking): Deleted.
2058         (WebKitStyleTest.test_braces): Deleted.
2059         (WebKitStyleTest.test_braces.MyClass): Deleted.
2060         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
2061         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
2062         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
2063         (WebKitStyleTest.test_null_false_zero): Deleted.
2064         (WebKitStyleTest.test_directive_indentation): Deleted.
2065         (WebKitStyleTest.test_using_std): Deleted.
2066         (WebKitStyleTest.test_using_namespace): Deleted.
2067         (WebKitStyleTest.test_max_macro): Deleted.
2068         (WebKitStyleTest.test_min_macro): Deleted.
2069         (WebKitStyleTest.test_wtf_move): Deleted.
2070         (WebKitStyleTest.test_ctype_fucntion): Deleted.
2071         (WebKitStyleTest.test_names): Deleted.
2072         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
2073         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
2074         (WebKitStyleTest.test_names.declarations): Deleted.
2075         (WebKitStyleTest.test_names.struct): Deleted.
2076         (WebKitStyleTest.test_names.VectorType): Deleted.
2077         (WebKitStyleTest.test_parameter_names): Deleted.
2078         (WebKitStyleTest.test_comments): Deleted.
2079         (WebKitStyleTest.test_webkit_export_check): Deleted.
2080         (WebKitStyleTest.test_member_initialization_list): Deleted.
2081         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
2082         (WebKitStyleTest.test_other): Deleted.
2083         (CppCheckerTest.mock_handle_style_error): Deleted.
2084         (CppCheckerTest._checker): Deleted.
2085         (CppCheckerTest.test_init): Deleted.
2086         (CppCheckerTest.test_eq): Deleted.
2087         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
2088         (CppCheckerTest.test_ne): Deleted.
2089         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2090         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2091         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2092         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2093         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2094         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2095
2096 2017-07-05  Saam Barati  <sbarati@apple.com>
2097
2098         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2099         https://bugs.webkit.org/show_bug.cgi?id=174188
2100         <rdar://problem/30581423>
2101
2102         Reviewed by Mark Lam.
2103
2104         * Scripts/run-jsc-stress-tests:
2105
2106 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2107
2108         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2109         https://bugs.webkit.org/show_bug.cgi?id=174150
2110
2111         Reviewed by Mark Lam.
2112
2113         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2114         (TestWebKitAPI::TEST):
2115
2116 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2117
2118         Remove copy of ICU headers from WebKit
2119         https://bugs.webkit.org/show_bug.cgi?id=116407
2120
2121         Reviewed by Alex Christensen.
2122
2123         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2124         * TestWebKitAPI/Configurations/Base.xcconfig:
2125         * WebKitTestRunner/Configurations/Base.xcconfig:
2126
2127 2017-07-05  Chris Dumez  <cdumez@apple.com>
2128
2129         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
2130         https://bugs.webkit.org/show_bug.cgi?id=174163
2131         <rdar://problem/33067518>
2132
2133         Reviewed by Alex Christensen.
2134
2135         Add API test coverage.
2136
2137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2138         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
2139         (TEST):
2140
2141 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2142
2143         When dragging a selection, clearing the selection in dragstart should not crash the web process
2144         https://bugs.webkit.org/show_bug.cgi?id=174142
2145         <rdar://problem/33067501>
2146
2147         Reviewed by Tim Horton.
2148
2149         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
2150         drag is starting up.
2151
2152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2153         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
2154         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2155         (TestWebKitAPI::TEST):
2156
2157 2017-07-05  Daniel Bates  <dabates@apple.com>
2158
2159         Do not pass API::FrameInfo for source frame or clear out page of target frame on
2160         API navigation
2161         https://bugs.webkit.org/show_bug.cgi?id=174170
2162         <rdar://problem/33140328>
2163
2164         Reviewed by Brady Eidson.
2165
2166         Update tests as needed for the behavior change.
2167
2168         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
2169         (TEST):
2170
2171 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2172
2173         Add WebKitPrivateFrameworkStubs for iOS 11
2174         https://bugs.webkit.org/show_bug.cgi?id=173988
2175
2176         Reviewed by David Kilzer.
2177
2178         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
2179         should use the same directory for private framework stubs.
2180         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2181
2182 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
2183
2184         [MediaStream] Protect request and web view during gUM client callback
2185         https://bugs.webkit.org/show_bug.cgi?id=174096
2186         <rdar://problem/32833102>
2187
2188         Reviewed by Youenn Fablet.
2189
2190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2191         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2192
2193 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2194
2195         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
2196
2197         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2198
2199 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2200
2201         Unreviewed, rolling out r219128.
2202
2203         Spoke with engineer who originally submitted, Patch for APi
2204         test to follow.
2205
2206         Reverted changeset:
2207
2208         "Unreviewed, rolling out r219070."
2209         https://bugs.webkit.org/show_bug.cgi?id=174082
2210         http://trac.webkit.org/changeset/219128
2211
2212 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2213
2214         Unreviewed, rolling out r219070.
2215
2216         This revision caused consistent failures of the API test
2217         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
2218
2219         Reverted changeset:
2220
2221         "Pasting single words copied to UIPasteboard inserts URLs in
2222         editable areas"
2223         https://bugs.webkit.org/show_bug.cgi?id=174082
2224         http://trac.webkit.org/changeset/219070
2225
2226 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2227
2228         Remove unused EFL logo from bot watcher dashboard
2229         https://bugs.webkit.org/show_bug.cgi?id=174136
2230
2231         Reviewed by Alexey Proskuryakov.
2232
2233         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
2234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
2235
2236 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2237
2238         [GTK] Add more GTK bots to dashboard
2239         https://bugs.webkit.org/show_bug.cgi?id=174129
2240
2241         Reviewed by Carlos Alberto Lopez Perez.
2242
2243         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
2244         them.
2245
2246         This also changes the sort order to put WPE above GTK so that it's not buried under all the
2247         less-essential GTK bots.
2248
2249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2251         (WebKitBuildbot):
2252
2253 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2254
2255         [WPE] Add WPE to bot watcher dashboard
2256         https://bugs.webkit.org/show_bug.cgi?id=174119
2257
2258         Reviewed by Alexey Proskuryakov.
2259
2260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
2261         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
2262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
2263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2265         (WebKitBuildbot):
2266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2267         (table.queue-grid tr.platform.linux-wpe img.logo):
2268
2269 2017-07-03  Lucas Forschler  <lforschler@apple.com>
2270
2271         https://bugs.webkit.org/show_bug.cgi?id=174105
2272         
2273         Reviewed by Stephanie Lewis.
2274
2275         * BuildSlaveSupport/built-product-archive:
2276         (main): Add a -minify parser option
2277         (createZip): Pass along the optional Minify argument if requested
2278         (minifySource): This will trim down archives, logic limited to Mac platform.
2279
2280 2017-07-03  Matt Rajca  <mrajca@apple.com>
2281
2282         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
2283         https://bugs.webkit.org/show_bug.cgi?id=174103
2284
2285         Reviewed by Alex Christensen.
2286
2287         Added an API test.
2288
2289         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
2290         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2291         (TEST): Added test.
2292         * TestWebKitAPI/cocoa/TestWKWebView.h:
2293         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2294         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
2295
2296 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2297
2298         Unreviewed, rolling out r219103.
2299
2300         Caused multiple build failures.
2301
2302         Reverted changeset:
2303
2304         "Remove copy of ICU headers from WebKit"
2305         https://bugs.webkit.org/show_bug.cgi?id=116407
2306         http://trac.webkit.org/changeset/219103
2307
2308 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2309
2310         Remove copy of ICU headers from WebKit
2311         https://bugs.webkit.org/show_bug.cgi?id=116407
2312
2313         Reviewed by Alex Christensen.
2314
2315         Use WTF's copy of ICU headers.
2316
2317         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2318         * TestWebKitAPI/Configurations/Base.xcconfig:
2319         * WebKitTestRunner/Configurations/Base.xcconfig:
2320
2321 2017-07-03  Brady Eidson  <beidson@apple.com>
2322
2323         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2324         https://bugs.webkit.org/show_bug.cgi?id=174073
2325
2326         Reviewed by Andy Estes.
2327
2328         * DumpRenderTree/mac/TestRunnerMac.mm:
2329         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
2330
2331         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
2332         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2333
2334 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2335
2336         Unreviewed, rolling out r219083.
2337
2338         The revision caused an API failure on all testing platforms.
2339
2340         Reverted changeset:
2341
2342         "[MediaStream] Protect request and web view during gUM client
2343         callback"
2344         https://bugs.webkit.org/show_bug.cgi?id=174096
2345         http://trac.webkit.org/changeset/219083
2346
2347 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
2348
2349         webkitpy: Properly number duplicated crashlogs
2350         https://bugs.webkit.org/show_bug.cgi?id=172002
2351
2352         Reviewed by Aakash Jain.
2353
2354         * Scripts/webkitpy/common/system/crashlogs.py:
2355         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
2356         an increasing integer.
2357         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2358         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
2359         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
2360         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
2361
2362 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
2363
2364         WebContent processes crash when the network process crashes with pending connection requests
2365         https://bugs.webkit.org/show_bug.cgi?id=174065
2366         <rdar://problem/30359835>
2367
2368         Reviewed by Tim Horton.
2369
2370         Add a API to ensure UI process tries to relaunch a new network process when the network process
2371         crashes with pending network connection requests.
2372
2373         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2374         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
2375         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2376         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2377         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
2378
2379 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
2380
2381         [MediaStream] Protect request and web view during gUM client callback
2382         https://bugs.webkit.org/show_bug.cgi?id=174096
2383         <rdar://problem/32833102>
2384
2385         Reviewed by Youenn Fablet.
2386
2387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2388         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2389
2390 2017-07-03  Andy Estes  <aestes@apple.com>
2391
2392         [Xcode] Add an experimental setting to build with ccache
2393         https://bugs.webkit.org/show_bug.cgi?id=173875
2394
2395         Reviewed by Tim Horton.
2396
2397         On systems that already have ccache(1) installed, this patch adds experimental support for
2398         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
2399
2400         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
2401         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
2402         find the toolchain from which to run clang, and then invokes ccache with the required
2403         arguments.
2404
2405         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
2406         precompiled headers to work properly [1].
2407
2408         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
2409         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
2410         during linking.
2411         
2412         [1] https://ccache.samba.org/manual.html#_precompiled_headers
2413
2414         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2415         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2416         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2417         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2418         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
2419         * ccache/README.md: Added.
2420         * ccache/ccache-clang: Added.
2421         * ccache/ccache-clang++: Added.
2422         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
2423
2424 2017-07-03  Alex Christensen  <achristensen@webkit.org>
2425
2426         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2427         https://bugs.webkit.org/show_bug.cgi?id=174051
2428
2429         Reviewed by Tim Horton.
2430
2431         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2432         (TestWebKitAPI::TEST_F):
2433
2434 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2435
2436         Unreviewed, rolling out r219024.
2437
2438         This patch cause 3 didferent test to fail.
2439
2440         Reverted changeset:
2441
2442         "REGRESSION(r215096) Queries of URLs with non-special schemes
2443         should not percent-encode single quotes"
2444         https://bugs.webkit.org/show_bug.cgi?id=174051
2445         http://trac.webkit.org/changeset/219024
2446
2447 2017-07-03  Chris Dumez  <cdumez@apple.com>
2448
2449         Drop ResourceLoadStatisticsStore's statisticsLock
2450         https://bugs.webkit.org/show_bug.cgi?id=174080
2451
2452         Reviewed by Brent Fulgham.
2453
2454         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
2455
2456         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2457         (WTR::TestController::isStatisticsPrevalentResource):
2458         (WTR::TestController::isStatisticsHasHadUserInteraction):
2459         (WTR::TestController::isStatisticsGrandfathered):
2460
2461 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2462
2463         Pasting single words copied to UIPasteboard inserts URLs in editable areas
2464         https://bugs.webkit.org/show_bug.cgi?id=174082
2465         <rdar://problem/33046992>
2466
2467         Reviewed by Tim Horton.
2468
2469         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
2470
2471         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2472         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2473         (TestWebKitAPI::TEST):
2474
2475 2017-07-02  Brady Eidson  <beidson@apple.com>
2476
2477         Add API test for all parts of WebKit1 API related to favicons.
2478         https://bugs.webkit.org/show_bug.cgi?id=174069
2479
2480         Reviewed by Andy Estes.
2481
2482         These two API tests cover all WebKit1 API related to icons.
2483         
2484         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2485         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
2486         (mainResourceData):
2487         (defaultFaviconData):
2488         (customFaviconData):
2489         (imageFromData):
2490         (+[IconLoadingProtocol canInitWithRequest:]):
2491         (+[IconLoadingProtocol canonicalRequestForRequest:]):
2492         (-[IconLoadingProtocol startLoading]):
2493         (-[IconLoadingProtocol stopLoading]):
2494         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2495         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2496         (TestWebKitAPI::TEST):
2497
2498 2017-07-01  Dan Bernstein  <mitz@apple.com>
2499
2500         [iOS] Remove code only needed when building for iOS 9.x
2501         https://bugs.webkit.org/show_bug.cgi?id=174068
2502
2503         Reviewed by Tim Horton.
2504
2505         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2506         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2507         (WTR::initializeWebViewConfiguration):
2508         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2509         (-[HIDEventGenerator _createIOHIDEventType:]):
2510
2511 2017-07-01  Brady Eidson  <beidson@apple.com>
2512
2513         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
2514         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
2515
2516         Reviewed by Alex Christensen.
2517
2518         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2519
2520 2017-07-01  Dan Bernstein  <mitz@apple.com>
2521
2522         [macOS] Remove code only needed when building for OS X Yosemite
2523         https://bugs.webkit.org/show_bug.cgi?id=174067
2524
2525         Reviewed by Tim Horton.
2526
2527         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2528         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2529         * DumpRenderTree/mac/DumpRenderTree.mm:
2530         (setDefaultsToConsistentValuesForTesting):
2531         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2532         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2533         * MiniBrowser/Configurations/Base.xcconfig:
2534         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2535         * TestWebKitAPI/Configurations/Base.xcconfig:
2536         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2537         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2538         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2539         (TestWebKitAPI::TEST_F):
2540         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2541         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
2542         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2543         (TestWebKitAPI::TEST_F):
2544         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2545         (TestWebKitAPI::TEST):
2546         * WebKitTestRunner/Configurations/Base.xcconfig:
2547         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2548         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2549         (WTR::InjectedBundle::platformInitialize):
2550         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2551         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2552
2553 2017-07-01  Chris Dumez  <cdumez@apple.com>
2554
2555         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
2556         https://bugs.webkit.org/show_bug.cgi?id=174060
2557
2558         Reviewed by Brent Fulgham.
2559
2560         Port WebKitTestRunner over to the new Cocoa SPI.
2561
2562         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2563         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2564         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2565         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
2566         no-ops since this code runs in the WebContent process, not the
2567         UIProcess.
2568
2569         * WebKitTestRunner/TestController.cpp:
2570         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2571
2572 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2573
2574         Unreviewed mac build fix.
2575
2576         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2577         (TestWebKitAPI::TEST):
2578
2579 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2580
2581         Add API to get WKActivatedElementInfo
2582         https://bugs.webkit.org/show_bug.cgi?id=174001
2583         <rdar://problem/29165518>
2584         
2585         Tests for now SPI to get activatedElementInfo.
2586
2587         Reviewed by Tim Horton.
2588
2589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2590         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
2591         (TestWebKitAPI::TEST):
2592
2593 2017-06-30  Chris Dumez  <cdumez@apple.com>
2594
2595         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
2596         https://bugs.webkit.org/show_bug.cgi?id=174038
2597
2598         Reviewed by Brent Fulgham.
2599
2600         Fix typo in API name.
2601
2602         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2603         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2604         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2605         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2606         * WebKitTestRunner/TestController.cpp:
2607         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2608         * WebKitTestRunner/TestController.h:
2609         * WebKitTestRunner/TestInvocation.cpp:
2610         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2611
2612 2017-06-30  Alex Christensen  <achristensen@webkit.org>
2613
2614         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2615         https://bugs.webkit.org/show_bug.cgi?id=174051
2616         <rdar://problem/33002846>
2617
2618         Reviewed by Tim Horton.
2619
2620         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2621         (TestWebKitAPI::TEST_F):
2622
2623 2017-06-30  Daniel Bates  <dabates@apple.com>
2624
2625         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2626         https://bugs.webkit.org/show_bug.cgi?id=165160
2627         <rdar://problem/29451999>
2628
2629         Reviewed by Brady Eidson.
2630
2631         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
2632         for navigations and window creation.
2633
2634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2635         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
2636         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2637         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
2638         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2639         (TEST):
2640
2641 2017-06-29  Jer Noble  <jer.noble@apple.com>
2642
2643         Make Legacy EME API controlled by RuntimeEnabled setting.
2644         https://bugs.webkit.org/show_bug.cgi?id=173994
2645
2646         Reviewed by Sam Weinig.
2647
2648         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2649
2650 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2651
2652         Follow-up fix for r218996
2653
2654         Unreviewed infrastructure fix.
2655
2656         Repeated calls to 'ios_version' make the log noisy, memoize the function.
2657
2658         * Scripts/webkitpy/port/ios_simulator.py:
2659         (IOSSimulatorPort): Memoize ios_version().
2660
2661 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2662
2663         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
2664         https://bugs.webkit.org/show_bug.cgi?id=174017
2665         <rdar://problem/32959782>
2666
2667         Reviewed by Simon Fraser.
2668
2669         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
2670         changes, the caret would appear outside of the iframe.
2671
2672         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2673         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
2674         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2675         (checkDragCaretRectIsContainedInRect):
2676         (TestWebKitAPI::TEST):
2677         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2678         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2679         (-[DataInteractionSimulator _resetSimulatedState]):
2680         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2681         (-[DataInteractionSimulator _advanceProgress]):
2682         (-[DataInteractionSimulator lastKnownDragCaretRect]):
2683
2684 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2685
2686         Add support for different versions of iOS when loading test expectations
2687         https://bugs.webkit.org/show_bug.cgi?id=173774
2688         <rdar://problem/32951132>
2689
2690         Rubber-stamped by Aakash Jain.
2691
2692         When running layout tests, we should support multiple version of iOS the same way we do Mac.
2693
2694         * Scripts/webkitpy/port/ios.py:
2695         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
2696         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
2697         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
2698         * Scripts/webkitpy/port/ios_device.py:
2699         (IOSDevicePort.ios_version): Ask connected devices for implementation.
2700         * Scripts/webkitpy/port/ios_device_unittest.py:
2701         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
2702         (IOSDeviceTest.test_baseline_searchpath): Ditto.
2703         (IOSDeviceTest.test_expectations_ordering): Ditto.
2704         * Scripts/webkitpy/port/ios_simulator.py:
2705         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
2706         ask the platform.
2707
2708 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
2709
2710         Fontconfig build breaks with glibc 2.15+
2711         https://bugs.webkit.org/show_bug.cgi?id=174019
2712
2713         Reviewed by Carlos Alberto Lopez Perez.
2714
2715         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
2716
2717         * wpe/jhbuild.modules:
2718         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
2719
2720 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2721
2722         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
2723         https://bugs.webkit.org/show_bug.cgi?id=174010
2724         <rdar://problem/32597802>
2725
2726         Reviewed by Tim Horton.
2727
2728         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
2729         snapshot fails for any reason.
2730
2731         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2732         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
2733         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2734         (TestWebKitAPI::TEST):
2735
2736 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
2737
2738         AX: Cannot call setValue() on contenteditable or ARIA text controls
2739         https://bugs.webkit.org/show_bug.cgi?id=173520
2740
2741         Reviewed by Ryosuke Niwa.
2742
2743         Add setValue() method to WKTR (already existed in DRT).
2744
2745         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2746         (WTR::AccessibilityUIElement::setValue):
2747         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2748         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2749         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2750         (WTR::AccessibilityUIElement::setValue):
2751
2752 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
2753
2754         getBoundingClientRect returns wrong value for combination of page zoom and scroll
2755         https://bugs.webkit.org/show_bug.cgi?id=173841
2756         rdar://problem/32983841
2757
2758         Reviewed by Dean Jackson.
2759
2760         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
2761         always did text zooming.
2762
2763         * MiniBrowser/mac/WK1BrowserWindowController.m:
2764         (-[WK1BrowserWindowController zoomIn:]):
2765         (-[WK1BrowserWindowController zoomOut:]):
2766         (-[WK1BrowserWindowController canResetZoom]):
2767         (-[WK1BrowserWindowController resetZoom:]):
2768
2769 2017-06-29  John Wilander  <wilander@apple.com>
2770
2771         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
2772         https://bugs.webkit.org/show_bug.cgi?id=173940
2773         <rdar://problem/33018125>
2774
2775         Reviewed by Brent Fulgham.
2776
2777         This change allows the TestController to turn off
2778         regular resource load statistics telemetry submission
2779         and to manually control when telemetry is calculated
2780         and submitted.
2781
2782         * WebKitTestRunner/TestController.cpp:
2783         (WTR::TestController::initialize):
2784             Turns off automatic resource load statistics telemetry submission.
2785
2786 2017-06-29  Commit Queue  <commit-queue@webkit.org>
2787
2788         Unreviewed, rolling out r218512.
2789         https://bugs.webkit.org/show_bug.cgi?id=173981
2790
2791         "It changes the behavior of the JS API's JSEvaluateScript
2792         which breaks TurboTax" (Requested by saamyjoon on #webkit).
2793
2794         Reverted changeset:
2795
2796         "test262: Completion values for control flow do not match the
2797         spec"
2798         https://bugs.webkit.org/show_bug.cgi?id=171265
2799         http://trac.webkit.org/changeset/218512
2800
2801 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
2802
2803         Add WebKitSystemInterface for iOS 11
2804         https://bugs.webkit.org/show_bug.cgi?id=173936
2805
2806         Reviewed by Lucas Forschler.
2807
2808         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
2809
2810 2017-06-28  Keith Miller  <keith_miller@apple.com>
2811
2812         VMTraps has some races
2813         https://bugs.webkit.org/show_bug.cgi?id=173941
2814
2815         Reviewed by Michael Saboff.
2816
2817         Add new testing mode for testing the Watchdog with our stress
2818         tests.
2819
2820         * Scripts/run-jsc-stress-tests:
2821
2822 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2823
2824         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
2825         https://bugs.webkit.org/show_bug.cgi?id=173877
2826
2827         Reviewed by Brady Eidson.
2828
2829         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
2830         the next tests.
2831
2832         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2833         (testGetFavicon):
2834
2835 2017-06-28  Tim Horton  <timothy_horton@apple.com>
2836
2837         MobileSafari was constantly using 10-15% CPU viewing a PDF
2838         https://bugs.webkit.org/show_bug.cgi?id=173944
2839         <rdar://problem/33039910>
2840
2841         Reviewed by Simon Fraser.
2842
2843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2844         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2845         Add a test that we ever call the stable presentation update callback
2846         when we have a WKPDFView up, instead of infinitely looping.
2847
2848 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2849
2850         Prevent displaying URLs with small capital letters
2851         https://bugs.webkit.org/show_bug.cgi?id=173949
2852         <rdar://problem/32952058>
2853
2854         Reviewed by Brent Fulgham.
2855
2856         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2857         (TestWebKitAPI::TEST):
2858
2859 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2860
2861         Unreviewed test fix.
2862
2863         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
2864
2865         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
2866
2867 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2868
2869         Teach ResourceLoadStatistics to recognize changes in the file system
2870         https://bugs.webkit.org/show_bug.cgi?id=173800
2871         <rdar://problem/32937842>
2872
2873         Reviewed by Chris Dumez.
2874
2875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2876         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
2877         (TestWebKitAPI::FileMonitorTest::tempFilePath):
2878         (TestWebKitAPI::handleFileModification):
2879         (TestWebKitAPI::handleFileDeletion):
2880         (TestWebKitAPI::resetTestState):
2881         (TestWebKitAPI::TEST_F):
2882
2883 2017-06-28  Brady Eidson  <beidson@apple.com>
2884
2885         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
2886         https://bugs.webkit.org/show_bug.cgi?id=173874
2887
2888         Reviewed by Alex Christensen.
2889
2890         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2891
2892 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
2893
2894         Unreviewed, adding Don Olmstead to contributors.json
2895
2896         * Scripts/webkitpy/common/config/contributors.json:
2897
2898 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2899
2900         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
2901         https://bugs.webkit.org/show_bug.cgi?id=173886
2902         <rdar://problem/32543191>
2903
2904         Reviewed by Andy Estes.
2905
2906         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2907         (ParsedRange::ParsedRange):
2908         (-[TestSchemeHandler initWithVideoData:]):
2909         (-[TestSchemeHandler webView:startURLSchemeTask:]):
2910         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
2911         (TEST):
2912
2913 2017-06-27  JF Bastien  <jfbastien@apple.com>
2914
2915         WebAssembly: running out of executable memory should throw OoM
2916         https://bugs.webkit.org/show_bug.cgi?id=171537
2917         <rdar://problem/32963338>
2918
2919         Reviewed by Saam Barati.
2920
2921         * Scripts/run-jsc-stress-tests: add a configuration which runs the
2922         tests under limited executable memory and avoids non-WebAssembly
2923         code generation so that we more reliably run out of executable
2924         memory in WebAssembly.
2925
2926 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2927
2928         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
2929         https://bugs.webkit.org/show_bug.cgi?id=173854
2930         <rdar://problem/32236827>
2931
2932         Reviewed by Ryosuke Niwa and Tim Horton.
2933
2934         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
2935
2936         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2937         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
2938         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2939         (TestWebKitAPI::TEST):
2940
2941 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
2942
2943         [PAL] Add symbol export macros for PAL
2944         https://bugs.webkit.org/show_bug.cgi?id=171519
2945
2946         Reviewed by Konstantin Tokarev.
2947
2948         * DumpRenderTree/config.h:
2949         * TestWebKitAPI/CMakeLists.txt:
2950         * TestWebKitAPI/config.h:
2951         * WebKitTestRunner/config.h:
2952
2953 2017-06-27  John Wilander  <wilander@apple.com>
2954
2955         Resource Load Statistics: Add telemetry
2956         https://bugs.webkit.org/show_bug.cgi?id=173499
2957         <rdar://problem/32826094>
2958
2959         Reviewed by Brent Fulgham.
2960
2961         Adds three new testRunner functions:
2962         - installStatisticsDidRunTelemetryCallback()
2963         - statisticsFireTelemetryHandler()
2964         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
2965
2966         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2967         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2968         (WTR::InjectedBundle::didReceiveMessageToPage):
2969         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2970         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
2971         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
2972         (WTR::TestRunner::statisticsFireTelemetryHandler):
2973         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2974         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2975         * WebKitTestRunner/TestController.cpp:
2976         (WTR::TestController::resetStateToConsistentValues):
2977         (WTR::TestController::statisticsFireTelemetryHandler):
2978         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2979         * WebKitTestRunner/TestController.h:
2980         * WebKitTestRunner/TestInvocation.cpp:
2981         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2982
2983 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
2984
2985         Add missing includes to fix compilation error on FreeBSD
2986         https://bugs.webkit.org/show_bug.cgi?id=172919
2987
2988         Reviewed by Mark Lam.
2989
2990         * ImageDiff/cairo/PlatformImageCairo.cpp:
2991
2992 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
2993
2994         Unreviewed, rolling out r218783.
2995
2996         Causing accessibility/mac/setting-attributes-is-
2997         asynchronous.html to crash consistently on mac-wk2 Debug
2998
2999         Reverted changeset:
3000
3001         "AX: Cannot call setValue() on contenteditable or ARIA text
3002         controls"
3003         https://bugs.webkit.org/show_bug.cgi?id=173520
3004         http://trac.webkit.org/changeset/218783
3005
3006 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3007
3008         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
3009         https://bugs.webkit.org/show_bug.cgi?id=173825
3010
3011         Reviewed by Saam Barati.
3012
3013         * DumpRenderTree/JavaScriptThreading.cpp:
3014         (runJavaScriptThread):
3015         (startJavaScriptThreads):
3016         * DumpRenderTree/mac/DumpRenderTree.mm:
3017         (runThread):
3018         (runPthread):
3019         (testThreadIdentifierMap):
3020
3021 2017-06-26  David Kilzer  <ddkilzer@apple.com>
3022
3023         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
3024         <https://webkit.org/b/173837>
3025
3026         Reviewed by Geoffrey Garen.
3027
3028         The clang static analyzer can't reason about objects that are
3029         assigned to a delegate as +1 retained, and then released
3030         later in a different method when the delegate is cleared.
3031
3032         Instead, use a common idiom where the object setting the
3033         delegate retains it as an instance variable on initialization.
3034         Then the same object clears the delegate and releases its
3035         instance variable during teardown.
3036
3037         Also add EXPECT_TRUE() tests to make sure the delegate objects
3038         match before teardown.
3039
3040         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3041         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
3042         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
3043         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3044         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
3045         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
3046
3047 2017-06-26  David Kilzer  <ddkilzer@apple.com>
3048
3049         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
3050         <https://webkit.org/b/173836>
3051
3052         Reviewed by Brady Eidson.
3053
3054         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3055         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
3056         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
3057         objects in this test.
3058
3059 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
3060
3061         [ATK] Add support for aria-details and aria-errormessage
3062         https://bugs.webkit.org/show_bug.cgi?id=172588
3063
3064         Reviewed by Chris Fleizach.
3065
3066         Add additional methods to test ARIA properties which are exposed via
3067         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
3068         to versions which support the details and error-message relation types.
3069
3070         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3071         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3072         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3073         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3074         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3075         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3076         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3077         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3078         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3079         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3080         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3081         * gtk/jhbuild.modules:
3082
3083 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3084
3085         Unreviewed. Add libfii to GTK+ install dependencies script.
3086
3087         * gtk/install-dependencies:
3088
3089 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3090
3091         Unreviewed, rolling out r215190.
3092
3093         Broke product select element on GNOME Bugzilla
3094
3095         Reverted changeset:
3096
3097         "[GTK] Misplaced right click menu on web page due to
3098         deprecated gtk_menu_popup()"
3099         https://bugs.webkit.org/show_bug.cgi?id=170553
3100         http://trac.webkit.org/changeset/215190
3101
3102 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
3103
3104         Remove Reflect.enumerate
3105         https://bugs.webkit.org/show_bug.cgi?id=173806
3106
3107         Reviewed by Yusuke Suzuki.
3108
3109         * Scripts/run-jsc-stress-tests:
3110
3111 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
3112
3113         AX: Cannot call setValue() on contenteditable or ARIA text controls
3114         https://bugs.webkit.org/show_bug.cgi?id=173520
3115
3116         Reviewed by Ryosuke Niwa.
3117
3118         Add setValue() method to WKTR (already existed in DRT).
3119
3120         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3121         (WTR::AccessibilityUIElement::setValue):
3122         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3123         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3124         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3125         (WTR::AccessibilityUIElement::setValue):
3126
3127 2017-06-23  Keith Miller  <keith_miller@apple.com>
3128
3129         Switch VMTraps to use halt instructions rather than breakpoint instructions
3130         https://bugs.webkit.org/show_bug.cgi?id=173677
3131
3132         Reviewed by JF Bastien.
3133
3134         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3135         (TEST):
3136
3137 2017-06-23  Youenn Fablet  <youenn@apple.com>
3138
3139         Set getUserMedia permission to true by default on WTR
3140         https://bugs.webkit.org/show_bug.cgi?id=173610
3141
3142         Reviewed by Alex Christensen.
3143
3144         Adding a way to reset the getUserMedia permission to pending.
3145
3146         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3147         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3148         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
3149         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3150         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3151         (WTR::TestRunner::setUserMediaPermissionAsUnset):
3152         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3153         * WebKitTestRunner/TestController.cpp:
3154         (WTR::TestController::resetStateToConsistentValues):
3155         (WTR::TestController::setUserMediaPermissionAsUnset):
3156         * WebKitTestRunner/TestController.h:
3157         * WebKitTestRunner/TestInvocation.cpp:
3158         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3159
3160 2017-06-23  Alex Christensen  <achristensen@webkit.org>
3161
3162         Add SPI to WKURLSchemeTask for redirection
3163         https://bugs.webkit.org/show_bug.cgi?id=173730
3164
3165         Reviewed by Brady Eidson.
3166
3167         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3168         (-[SchemeHandler webView:startURLSchemeTask:]):
3169         (-[SchemeHandler webView:stopURLSchemeTask:]):
3170         (TEST):
3171         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
3172         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
3173         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
3174         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
3175         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
3176
3177 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3178
3179         [WPE] Use JSC API to send script messages from web extension in tests
3180         https://bugs.webkit.org/show_bug.cgi?id=173757
3181
3182         Reviewed by Žan Doberšek.
3183
3184         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
3185         to run postMessage().
3186
3187         Fixes: /wpe/WebKitSecurityManager/file-xhr
3188                /wpe/WebKitConsoleMessage/console-api
3189                /wpe/WebKitConsoleMessage/js-exception
3190                /wpe/WebKitConsoleMessage/network-error
3191                /wpe/WebKitConsoleMessage/security-error
3192
3193         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3194         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
3195         (beforeAll): Ditto.
3196         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3197         (testWebContextSecurityFileXHR): Ditto.
3198         (beforeAll): Ditto.
3199         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3200         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
3201         (pageCreatedCallback): Remove ifdefs.
3202
3203 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3204
3205         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
3206
3207         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
3208         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
3209         doesn't exist yet in WPE.
3210
3211         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3212         (testWebViewJavaScriptDialogs):
3213         (testWebViewWindowProperties):
3214
3215 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3216
3217         [GTK] Upgrade pixman and cairo in jhbuild
3218         https://bugs.webkit.org/show_bug.cgi?id=173710
3219
3220         Reviewed by Carlos Alberto Lopez Perez.
3221
3222         * gtk/jhbuild.modules:
3223
3224 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3225
3226         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
3227         https://bugs.webkit.org/show_bug.cgi?id=173711
3228
3229         Reviewed by Carlos Alberto Lopez Perez.
3230
3231         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
3232         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
3233
3234         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3235         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
3236
3237 2017-06-22  David Kilzer  <ddkilzer@apple.com>
3238
3239         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
3240         <https://webkit.org/b/173721>
3241
3242         Reviewed by Joseph Pecoraro.
3243
3244         Use RetainPtr<> to create NSMutableDictionary and NSNumber
3245         objects to fix leaks and to avoid the autoreleasepool.
3246
3247         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
3248         (TEST):
3249
3250 2017-06-22  Matt Lewis  <jlewis3@apple.com>
3251
3252         Unreviewed, rolling out r218633.
3253
3254         The test is failing frequently on Sierra Debug and Windows
3255
3256         Reverted changeset:
3257
3258         "AX: Cannot call setValue() on contenteditable or ARIA text
3259         controls"
3260         https://bugs.webkit.org/show_bug.cgi?id=173520
3261         http://trac.webkit.org/changeset/218633
3262
3263 2017-06-22  David Kilzer  <ddkilzer@apple.com>
3264
3265         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
3266         <https://webkit.org/b/173690>
3267
3268         Reviewed by Chris Dumez.
3269
3270         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
3271         ownership of malloc()-ed memory, then frees it when it's
3272         released.  These tests were passing global variables into the
3273         method, which is not malloc()-ed memory, which violates the API
3274         contract.
3275
3276         The fix is to switch to use
3277         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
3278         NO for the last argument.
3279
3280         Caught by the clang static analyzer.
3281
3282         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
3283         (TEST):
3284         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3285         (TEST):
3286
3287 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3288
3289         [GTK] Upgrade Harfbuzz to version 1.4.2
3290         https://bugs.webkit.org/show_bug.cgi?id=173592
3291
3292         Reviewed by Carlos Alberto Lopez Perez.
3293
3294         * gtk/jhbuild.modules:
3295
3296 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3297
3298         [WPE] Update WPEBackend-mesa
3299         https://bugs.webkit.org/show_bug.cgi?id=173705
3300
3301         Reviewed by Carlos Alberto Lopez Perez.
3302
3303         A crash has been fixed, needed for unit tests to work.
3304
3305         * wpe/jhbuild.modules:
3306
3307 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3308
3309         Remove unused coordinated graphics C API
3310         https://bugs.webkit.org/show_bug.cgi?id=173706
3311
3312         Reviewed by Žan Doberšek.
3313
3314         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
3315         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
3316         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
3317         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
3318         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
3319         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
3320
3321 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3322
3323         [WPE] Build glib API tests
3324         https://bugs.webkit.org/show_bug.cgi?id=173702
3325
3326         Reviewed by Žan Doberšek.
3327
3328         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
3329         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
3330         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
3331         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
3332         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
3333         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
3334         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
3335         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
3336         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
3337         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
3338         and implement the missing features.
3339
3340         * CMakeLists.txt:
3341         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
3342         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3343         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3344         (testAutomationSessionRequestSession):
3345         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3346         (testWebKitWebViewSessionState):
3347         (testWebKitWebViewSessionStateWithFormData):
3348         (testWebKitWebViewNavigationAfterSessionRestore):
3349         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3350         (beforeAll):
3351         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3352         (testCookieManagerEphemeral):
3353         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3354         (testBlobDownload):
3355         (beforeAll):
3356         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3357         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3358         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3359         (testProcessPerWebView):
3360         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3361         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3362         (testWebViewCreateNavigationData):
3363         (testWebViewJavaScriptDialogs):
3364         (testWebViewWindowProperties):
3365         (testWebViewMouseTarget):
3366         (testWebViewGeolocationPermissionRequests):
3367         (testWebViewUserMediaPermissionRequests):
3368         (testWebViewAudioOnlyUserMediaPermissionRequests):
3369         (testWebViewFileChooserRequest):
3370         (beforeAll):
3371         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3372         (beforeAll):
3373         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3374         (testPrivateBrowsing):
3375         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3376         (testFindControllerHide):
3377         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3378         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3379         (testWebKitSettings):
3380         (beforeAll):
3381         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3382         (testWebViewNewWithUserContentManager):
3383         (beforeAll):
3384         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3385         (testWebContextEphemeral):
3386         (testWebContextProxySettings):
3387         (beforeAll):
3388         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3389         (testWebViewWebContext):
3390         (testWebViewWebContextLifetime):
3391         (testWebViewEphemeral):
3392         (testWebViewSettings):
3393         (testWebViewCanShowMIMEType):
3394         (testWebViewPageVisibility):
3395         (testWebViewIsPlayingAudio):
3396         (beforeAll):
3397         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3398         (testWebsiteDataEphemeral):
3399         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3400         (documentLoadedCallback):
3401         (pageCreatedCallback):
3402         (methodCallCallback):
3403         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
3404         * TestWebKitAPI/glib/CMakeLists.txt:
3405         * TestWebKitAPI/glib/PlatformGTK.cmake:
3406         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3407         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3408         (main):
3409         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3410         (Test::adoptView):
3411         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3412         (WebKitTestBus::run):
3413         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3414         (WebViewTest::~WebViewTest):
3415         (WebViewTest::initializeWebView):
3416         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3417         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
3418         (WebViewTest::platformDestroy):
3419         (WebViewTest::platformInitializeWebView):
3420         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3421         (WebViewTest::resizeView):
3422         (WebViewTest::hideView):
3423         (parentWindowMapped):
3424         (WebViewTest::showInWindow):
3425         (WebViewTest::showInWindowAndWaitUntilMapped):
3426         (WebViewTest::mouseMoveTo):
3427         (WebViewTest::clickMouseButton):
3428         (WebViewTest::emitPopupMenuSignal):
3429         (WebViewTest::keyStroke):
3430         (WebViewTest::doMouseButtonEvent):
3431         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
3432         (WebViewTest::platformDestroy):
3433         (WebViewTest::platformInitializeWebView):
3434         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3435         (WebViewTest::resizeView):
3436         (WebViewTest::hideView):
3437         (WebViewTest::mouseMoveTo):
3438         (WebViewTest::clickMouseButton):
3439         (WebViewTest::keyStroke):
3440
3441 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3442
3443         [GTK] Move WebKit2 GLib API tests to glib directories
3444         https://bugs.webkit.org/show_bug.cgi?id=173642
3445
3446         Reviewed by Žan Doberšek.
3447
3448         * CMakeLists.txt:
3449         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
3450         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
3451         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
3452         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
3453         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
3454         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
3455         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
3456         (testWebKitConsoleMessageNetworkError):
3457         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
3458         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
3459         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
3460         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
3461         (testLoadFromGResource):
3462         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
3463         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
3464         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
3465         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
3466         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
3467         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
3468         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
3469         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
3470         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
3471         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
3472         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
3473         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
3474         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
3475         (testWebViewRunJavaScript):
3476         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
3477         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
3478         (registerGResource):
3479         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
3480         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
3481         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
3482         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
3483         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
3484         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
3485         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
3486         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
3487         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
3488         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
3489         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
3490         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
3491         * TestWebKitAPI/glib/CMakeLists.txt: Added.
3492         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
3493         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
3494         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
3495         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
3496         (registerGResource):
3497         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
3498         (Test::getResourcesDir):
3499         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
3500         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
3501         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
3502         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
3503         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
3504         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
3505
3506 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3507
3508         [WPE] Add initial web extensions API
3509         https://bugs.webkit.org/show_bug.cgi?id=173640
3510
3511         Reviewed by Žan Doberšek.
3512
3513         Add style checker exceptions for WPE web extensions API files.
3514
3515         * Scripts/webkitpy/style/checker.py:
3516
3517 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3518
3519         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
3520         https://bugs.webkit.org/show_bug.cgi?id=173659
3521         <rdar://problem/32879788>
3522
3523         Reviewed by Tim Horton.
3524
3525         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
3526
3527         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
3528
3529         Augment this test page to log dragend and dragstart events on the drag source as well.
3530
3531         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3532         (checkStringArraysAreEqual):
3533         (TestWebKitAPI::TEST):
3534
3535 2017-06-21  Antoine Quint  <graouts@apple.com>
3536
3537         Ensure DRT always logs rAF suspension debugging code
3538         https://bugs.webkit.org/show_bug.cgi?id=173681
3539
3540         Reviewed by Tim "Mr. T" Horton.
3541
3542         * DumpRenderTree/mac/DumpRenderTree.mm:
3543         (resetWebPreferencesToConsistentValues):
3544
3545 2017-06-21  Chris Dumez  <cdumez@apple.com>
3546
3547         Allow constructing a WTF:Function from a function pointer
3548         https://bugs.webkit.org/show_bug.cgi?id=173660
3549
3550         Reviewed by Alex Christensen.
3551
3552         Add API test coverage.
3553
3554         * TestWebKitAPI/Tests/WTF/Function.cpp:
3555         (TestWebKitAPI::returnThree):
3556         (TestWebKitAPI::returnFour):
3557         (TestWebKitAPI::returnPassedValue):
3558         (TestWebKitAPI::TEST):
3559
3560 2017-06-21  Antoine Quint  <graouts@apple.com>
3561
3562         Add logging to identify when the Page suspends scripted animations
3563         https://bugs.webkit.org/show_bug.cgi?id=173626
3564
3565         Reviewed by Tim Horton.
3566
3567         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
3568
3569         * DumpRenderTree/mac/DumpRenderTree.mm:
3570         (resetWebPreferencesToConsistentValues):
3571
3572 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
3573
3574         AX: Cannot call setValue() on contenteditable or ARIA text controls
3575         https://bugs.webkit.org/show_bug.cgi?id=173520
3576
3577         Reviewed by Ryosuke Niwa.
3578
3579         Add setValue() method to WKTR (already existed in DRT).
3580
3581         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3582         (WTR::AccessibilityUIElement::setValue):
3583         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3584         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3585         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3586         (WTR::AccessibilityUIElement::setValue):
3587
3588 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
3589
3590         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
3591         as one of the dependencies required to build the product.
3592
3593         Rubber-stamped by Carlos Garcia Campos.
3594
3595         * gtk/install-dependencies:
3596         * wpe/install-dependencies:
3597
3598 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
3599
3600         Disable font variations on macOS Sierra and iOS 10
3601         https://bugs.webkit.org/show_bug.cgi?id=173618
3602         <rdar://problem/32879164>
3603
3604         Reviewed by Jon Lee.
3605
3606         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3607
3608 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3609
3610         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
3611         https://bugs.webkit.org/show_bug.cgi?id=173578
3612         <rdar://problem/32825028>
3613
3614         Reviewed by Tim Horton.
3615
3616         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
3617         a custom popover does not cause dragging to fail when the popover is presented.
3618
3619         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3620         (-[DataInteractionSimulator _advanceProgress]):
3621
3622 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3623
3624         [WPE] Add initial implementation of glib API
3625         https://bugs.webkit.org/show_bug.cgi?id=173546
3626
3627         Reviewed by Žan Doberšek.
3628
3629         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
3630         include WPE glib API files.
3631
3632         * Scripts/webkitperl/FeatureList.pm:
3633         * Scripts/webkitpy/style/checker.py:
3634         * Scripts/webkitpy/style/checkers/cpp.py:
3635         (check_identifier_name_in_declaration):
3636
3637 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3638
3639         [GTK] Upgrade to ICU to version 57.1
3640         https://bugs.webkit.org/show_bug.cgi?id=173538
3641
3642         Reviewed by Žan Doberšek.
3643
3644         * gtk/jhbuild.modules:
3645
3646 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3647
3648         [GTK] Remove unneeded modules from the jhbuild
3649         https://bugs.webkit.org/show_bug.cgi?id=170540
3650
3651         Reviewed by Michael Catanzaro.
3652
3653         We are building libxslt and libffi that we don't really need to build from sources.
3654
3655         * gtk/jhbuild.modules:
3656
3657 2017-06-19  Frederic Wang  <fwang@igalia.com>
3658
3659         [Mac] Add an experimental feature setting for async frame scrolling
3660         https://bugs.webkit.org/show_bug.cgi?id=173359
3661
3662         Reviewed by Simon Fraser.
3663
3664         * DumpRenderTree/mac/DumpRenderTree.mm:
3665         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
3666         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
3667         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3668         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
3669
3670 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
3671
3672         Unreviewed, adding myself to contributors.json
3673
3674         * Scripts/webkitpy/common/config/contributors.json:
3675
3676 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
3677
3678         test262: Completion values for control flow do not match the spec
3679         https://bugs.webkit.org/show_bug.cgi?id=171265
3680
3681         Reviewed by Saam Barati.
3682
3683         * Scripts/run-jsc-stress-tests:
3684         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
3685
3686 2017-06-19  Zalan Bujtas  <zalan@apple.com>
3687
3688         Opening certain mails brings up a mail that grows indefinitely.
3689         https://bugs.webkit.org/show_bug.cgi?id=173562
3690         <rdar://problem/32766579>
3691
3692         Reviewed by Tim Horton.
3693
3694         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3695         (TEST):
3696
3697 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3698
3699         [iOS DnD] Support .zip archives for file uploads via drag and drop
3700         https://bugs.webkit.org/show_bug.cgi?id=173511
3701         <rdar://problem/32521025>
3702
3703         Reviewed by Tim Horton.
3704
3705         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
3706         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
3707
3708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3709         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
3710         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3711         (testZIPArchive):
3712         (TestWebKitAPI::TEST):
3713
3714 2017-06-18  Darin Adler  <darin@apple.com>
3715
3716         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
3717         https://bugs.webkit.org/show_bug.cgi?id=173526
3718
3719         Reviewed by Sam Weinig.
3720
3721         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
3722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3723
3724         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
3725         tests for assignment before destruction ones.
3726
3727         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
3728         as a function, so it can be used in WTF::Function tests.
3729
3730         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
3731         Added tests for swap and for assignment before deref.
3732
3733         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
3734         to inline everything. Also removed the unnecessary clearing of the log every time
3735         the DerivedRefLogger constructor is called.
3736         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
3737
3738         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
3739         Added tests for assignment before deref and similar for releaseNonNull.
3740
3741 2017-06-19  Sam Weinig  <sam@webkit.org>
3742
3743         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
3744         https://bugs.webkit.org/show_bug.cgi?id=173513
3745
3746         Reviewed by Alex Christensen.
3747
3748         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3749         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3750         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
3751
3752 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
3753
3754         [Win] fast/dom/assign-to-window-status.html is flaky.
3755         https://bugs.webkit.org/show_bug.cgi?id=173512
3756
3757         Reviewed by Alex Christensen.
3758
3759         We should not dump status callbacks when test is done.
3760
3761         * DumpRenderTree/win/UIDelegate.cpp:
3762         (UIDelegate::setStatusText):
3763
3764 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3765
3766         [WPE][JHBuild] Update WPEBackend-mesa
3767         https://bugs.webkit.org/show_bug.cgi?id=173433
3768
3769         Unreviewed.
3770
3771         Update WPEBackend-mesa back (like it was done originally in r218344)
3772         after fixing the issue with the DISPLAY environment variables that
3773         caused the crashes.
3774
3775         * wpe/jhbuild.modules:
3776
3777 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3778
3779         Rename unit test file after r218482
3780         https://bugs.webkit.org/show_bug.cgi?id=173483
3781
3782         Unreviewed.
3783
3784         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
3785
3786 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3787
3788         Unreviewed. Fix wrong style checker condition added in r218487.
3789
3790         * Scripts/webkitpy/style/checkers/cpp.py:
3791         (check_identifier_name_in_declaration):
3792
3793 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
3794
3795         Missing <functional> includes make builds fail with GCC 7.x
3796         https://bugs.webkit.org/show_bug.cgi?id=173544
3797
3798         Unreviewed gardening.
3799
3800         Fix compilation with GCC 7.
3801
3802         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3803         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3804
3805 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3806
3807         [GTK] Move GTK+ API files that could be shared to glib dirs
3808         https://bugs.webkit.org/show_bug.cgi?id=173545
3809
3810         Reviewed by Žan Doberšek.
3811
3812         Update paths of GTK+ API in watchlist and style checker.
3813
3814         * Scripts/webkitpy/common/config/watchlist:
3815         * Scripts/webkitpy/style/checker.py:
3816         * Scripts/webkitpy/style/checkers/cpp.py:
3817         (check_identifier_name_in_declaration):
3818
3819 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3820
3821         Port setup_environ_for_server should not set environment variables related with the driver.
3822         https://bugs.webkit.org/show_bug.cgi?id=173483
3823
3824         Reviewed by Carlos Garcia Campos.
3825
3826         The port setup_environ_for_server() should not set environment variables
3827         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
3828         This varibles should be only set on the driver setup_environ_for_test().
3829
3830         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
3831         into the test environment even when running the tests with a driver
3832         that is not the Xorg or Xvfb one.
3833
3834         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
3835         (Port.to.setup_environ_for_server):
3836         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
3837         (Driver._setup_environ_for_driver):
3838         * Scripts/webkitpy/port/driver_unittest.py:
3839         (DriverTest.test_setup_environ_for_test):
3840         (DriverTest):
3841         (DriverTest.test_setup_environ_base_vars):
3842         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
3843         (GtkPort.setup_environ_for_server):
3844         * Scripts/webkitpy/port/wayland_unittest.py: Added.
3845         (WaylandDriverTest):
3846         (WaylandDriverTest.make_driver):
3847         (WaylandDriverTest.make_environment):
3848         (WaylandDriverTest.test_checkdriver):
3849         (WaylandDriverTest.test_environment_needed_variables):
3850         (WaylandDriverTest.test_environment_forbidden_variables):
3851         (WaylandDriverTest.test_environment_optional_variables):
3852         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
3853         (WaylandDriver.check_driver):
3854         (WaylandDriver._setup_environ_for_test):
3855         * Scripts/webkitpy/port/xorgdriver.py:
3856         (XorgDriver.check_driver):
3857         (XorgDriver._setup_environ_for_test):
3858         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
3859         (XorgDriverTest):
3860         (XorgDriverTest.make_driver):
3861         (XorgDriverTest.make_environment):
3862         (XorgDriverTest.test_checkdriver):
3863         (XorgDriverTest.test_environment_needed_variables):
3864         (XorgDriverTest.test_environment_forbidden_variables):
3865         (XorgDriverTest.test_environment_optional_variables):
3866         * Scripts/webkitpy/port/xvfbdriver.py:
3867         (XvfbDriver._setup_environ_for_test):
3868         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3869         (XvfbDriverTest.assertDriverStartSuccessful):
3870
3871
3872 2017-05-14 Frederic Wang  <fwang@igalia.com>
3873
3874         Add heuristic to avoid flattening "fullscreen" iframes
3875         https://bugs.webkit.org/show_bug.cgi?id=171914
3876
3877         Reviewed by Simon Fraser.
3878
3879         * DumpRenderTree/mac/DumpRenderTree.mm:
3880         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
3881
3882 2017-06-18  Chris Dumez  <cdumez@apple.com>
3883
3884         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
3885         https://bugs.webkit.org/show_bug.cgi?id=173522
3886         <rdar://problem/31185739>
3887
3888         Reviewed by Darin Adler.
3889
3890         Add API test for re-entering Function's assignment operators.
3891
3892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3893         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
3894         (TestWebKitAPI::TestObject::TestObject):
3895         (TestWebKitAPI::TestObject::~TestObject):
3896         (TestWebKitAPI::TestObject::operator()):
3897         (TestWebKitAPI::TEST):
3898
3899 2017-06-16  Dan Bernstein  <mitz@apple.com>
3900
3901         [Cocoa] Some declarations have missing or incorrect availability attributes
3902         https://bugs.webkit.org/show_bug.cgi?id=173508
3903
3904         Reviewed by Tim Horton.
3905
3906         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
3907         (TestWebKitAPI::TEST): Updated for renames.
3908
3909 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3910
3911         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
3912         https://bugs.webkit.org/show_bug.cgi?id=173366
3913         <rdar://problem/32767014>
3914
3915         Reviewed by Tim Horton.
3916
3917         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
3918         change in behavior.
3919
3920         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3921         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3922         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
3923         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
3924         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
3925         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
3926         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
3927         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
3928         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
3929         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
3930         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
3931         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
3932         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
3933         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
3934         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3935         (-[MockDragDropSession initWithItems:location:window:]):
3936         (-[MockDragDropSession allowsMoveOperation]):
3937         (-[MockDragDropSession isRestrictedToDraggingApplication]):
3938         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
3939         (-[MockDragDropSession canLoadObjectsOfClass:]):
3940         (-[MockDragDropSession canLoadObjectsOfClasses:]):
3941         (-[MockDragDropSession items]):
3942         (-[MockDragDropSession setItems:]):
3943         (-[MockDragDropSession locationInView:]):
3944         (-[MockDataOperationSession initWithProviders:location:window:]):
3945         (-[MockDataOperationSession session]):
3946         (-[MockDataOperationSession isLocal]):
3947         (-[MockDataOperationSession progress]):
3948         (-[MockDataOperationSession setProgressIndicatorStyle:]):
3949         (-[MockDataOperationSession progressIndicatorStyle]):
3950         (-[MockDataOperationSession operationMask]):
3951         (-[MockDataOperationSession localDragSession]):
3952         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
3953         (-[MockDataOperationSession canCreateItemsOfClass:]):
3954         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
3955         (-[MockDataInteractionSession initWithWindow:]):
3956         (-[MockDataInteractionSession localOperationMask]):
3957         (-[MockDataInteractionSession externalOperationMask]):
3958         (-[MockDataInteractionSession session]):
3959         (-[DataInteractionSimulator _advanceProgress]):
3960
3961 2017-06-16  Alex Christensen  <achristensen@webkit.org>
3962
3963         Show punycode to user if a URL has dotless i or j followed by diacritic dot
3964         https://bugs.webkit.org/show_bug.cgi?id=173431
3965
3966         Reviewed by Darin Adler.
3967
3968         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3969         (TestWebKitAPI::TEST):
3970
3971 2017-06-16  Chris Dumez  <cdumez@apple.com>
3972
3973         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
3974         https://bugs.webkit.org/show_bug.cgi?id=173472
3975         <rdar://problem/28858817>
3976
3977         Reviewed by Brady Eidson.
3978
3979         Add API test coverage.
3980
3981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3982         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
3983         (TEST):
3984
3985 2017-06-16  Brady Eidson  <beidson@apple.com>
3986
3987         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
3988         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
3989
3990         Reviewed by Daniel Bates.
3991
3992         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
3993
3994 2017-06-16  Chris Dumez  <cdumez@apple.com>
3995
3996         DRT fails to reset page visibility between tests
3997         https://bugs.webkit.org/show_bug.cgi?id=173485
3998
3999         Reviewed by Alexey Proskuryakov.
4000
4001         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
4002         Fix this to address flakiness.
4003
4004         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
4005         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
4006         The test became flaky without the DRT change and was no longer flaky with the DRT
4007         change.
4008
4009         WebKitTestRunner already does this.
4010
4011         * DumpRenderTree/mac/DumpRenderTree.mm:
4012         (resetWebViewToConsistentStateBeforeTesting):
4013
4014 2017-06-16  Alex Christensen  <achristensen@webkit.org>
4015
4016         Implement basic authentication in MiniBrowser
4017         https://bugs.webkit.org/show_bug.cgi?id=173443
4018
4019         Reviewed by Tim Horton.
4020
4021         * MiniBrowser/mac/WK2BrowserWindowController.m:
4022         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
4023
4024 2017-06-16  Jer Noble  <jer.noble@apple.com>
4025
4026         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
4027         https://bugs.webkit.org/show_bug.cgi?id=173398
4028         <rdar://problem/32592961>
4029
4030         Reviewed by Eric Carlson.
4031
4032         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4033         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
4034         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
4035         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4036         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
4037         (TestWebKitAPI::TEST):
4038         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
4039
4040 2017-06-16  Matt Lewis  <jlewis3@apple.com>
4041
4042         Unreviewed, rolling out r218375.
4043
4044         The API test MediaStreamTrackDetached is still timing out
4045         after the patch
4046
4047         Reverted changeset:
4048
4049         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
4050         reports no recording to WebKit clients"
4051         https://bugs.webkit.org/show_bug.cgi?id=173398
4052         http://trac.webkit.org/changeset/218375
4053
4054 2017-06-15  Jer Noble  <jer.noble@apple.com>
4055
4056         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
4057         https://bugs.webkit.org/show_bug.cgi?id=173398
4058         <rdar://problem/32592961>
4059
4060         Reviewed by Eric Carlson.
4061
4062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4063         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
4064         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
4065         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4066         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
4067         (TestWebKitAPI::TEST):
4068         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
4069
4070 2017-06-15  Matt Lewis  <jlewis3@apple.com>
4071
4072         Unreviewed, rolling out r218365.
4073
4074         The revision caused API timeouts on all builds.
4075
4076         Reverted changeset:
4077
4078         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
4079         reports no recording to WebKit clients"
4080         https://bugs.webkit.org/show_bug.cgi?id=173398
4081         http://trac.webkit.org/changeset/218365
4082
4083 2017-06-15  Jer Noble  <jer.noble@apple.com>
4084
4085         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
4086         https://bugs.webkit.org/show_bug.cgi?id=173398
4087         <rdar://problem/32592961>
4088
4089         Reviewed by Eric Carlson.
4090
4091         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4092         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
4093         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
4094         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4095         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
4096         (TestWebKitAPI::TEST):
4097         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
4098
4099 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4100
4101         REGRESSION(r218344): [WPE] Thousands of layout test crashes
4102         https://bugs.webkit.org/show_bug.cgi?id=173433
4103
4104         Unreviewed.
4105
4106         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
4107
4108 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4109
4110         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
4111         https://bugs.webkit.org/show_bug.cgi?id=173061
4112
4113         Reviewed by Žan Doberšek.
4114
4115         Launch dyz <https://github.com/Igalia/dyz> with the script
4116         run-minibrowser for the wpe port. It is now built as part of the
4117         WPE dependencies with JHBuild.
4118
4119         * Scripts/run-minibrowser:
4120         * Scripts/webkitdirs.pm:
4121         (launcherPath):
4122         (launcherName):
4123         * wpe/install-dependencies: Luajit is needed for building dyz.
4124         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
4125
4126 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4127
4128         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
4129         https://bugs.webkit.org/show_bug.cgi?id=173338
4130         <rdar://problem/32777720>
4131
4132         Reviewed by Tim Horton.
4133
4134         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
4135         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
4136         these remaining items on drop.
4137
4138         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4139         (TestWebKitAPI::TEST):
4140         * TestWebKitAPI/ios/DataInteractionSimulator.h:
4141         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
4142
4143         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
4144
4145         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
4146
4147 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
4148
4149         [Win] Crash in accessibility layout test.
4150         https://bugs.webkit.org/show_bug.cgi?id=173401
4151
4152         Reviewed by Brent Fulgham.
4153
4154         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
4155         member will be automatically released when the _variant_t object goes out of scope if the vt member
4156         does not equal VT_UNKNOWN | VT_BYREF.
4157         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
4158
4159         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4160         (AccessibilityUIElement::titleUIElement):
4161
4162 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
4163
4164         [GTK] Add API to allow overriding popup menus
4165         https://bugs.webkit.org/show_bug.cgi?id=172905
4166
4167         Reviewed by Michael Catanzaro.
4168
4169         Add a unit test to check the new API.
4170
4171         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
4172         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
4173         (OptionMenuTest::OptionMenuTest):
4174         (OptionMenuTest::~OptionMenuTest):
4175         (OptionMenuTest::destroyMenu):
4176         (OptionMenuTest::showOptionMenuCallback):
4177         (OptionMenuTest::menuCloseCallback):
4178         (OptionMenuTest::showOptionMenu):
4179         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
4180         (OptionMenuTest::close):
4181         (OptionMenuTest::activateItem):
4182         (OptionMenuTest::selectItem):
4183         (testOptionMenuSimple):
4184         (testOptionMenuGroups):
4185         (testOptionMenuActivate):
4186         (testOptionMenuSelect):
4187         (beforeAll):
4188         (afterAll):
4189
4190 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
4191
4192         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
4193         https://bugs.webkit.org/show_bug.cgi?id=173399
4194
4195         Reviewed by Per Arne Vollan.
4196
4197         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
4198         Curl port needs to do nothing because libcurl doesn't have disk cache.
4199
4200         * DumpRenderTree/win/DumpRenderTree.cpp:
4201         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
4202         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
4203
4204 2017-06-14  Tomas Popela  <tpopela@redhat.com>
4205
4206         [GTK] integer expression expected if running Tools/gtk/install-dependencies
4207         https://bugs.webkit.org/show_bug.cgi?id=173356
4208
4209         Reviewed by Michael Catanzaro.
4210
4211         Use the correct operator to compare the strings.
4212
4213         * gtk/install-dependencies:
4214
4215 2017-06-14  Commit Queue  <commit-queue@webkit.org>
4216
4217         Unreviewed, rolling out r218285.
4218         https://bugs.webkit.org/show_bug.cgi?id=173391
4219
4220         API test fails on iOS (Requested by alexchristensen on
4221         #webkit).
4222
4223         Reverted changeset:
4224
4225         "Add SPI for immediate injection of user scripts"
4226         https://bugs.webkit.org/show_bug.cgi?id=173342
4227         http://trac.webkit.org/changeset/218285
4228
4229 2017-06-14  Chris Dumez  <cdumez@apple.com>
4230
4231         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
4232         https://bugs.webkit.org/show_bug.cgi?id=173384
4233         <rdar://problem/32723779>
4234
4235         Reviewed by Dan Bernstein.
4236
4237         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4238         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
4239         Add API test coverage.
4240
4241         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
4242         (TestWebKitAPI::Util::sleep):
4243         Update implementation of Util::sleep() so that we actually run the run loop.