Do not wait until requestPermission() is called to fire deviceorientation events...
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-10  Chris Dumez  <cdumez@apple.com>
2
3         Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
4         https://bugs.webkit.org/show_bug.cgi?id=197750
5
6         Reviewed by Geoffrey Garen.
7
8         Add API test coverage.
9
10         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
11         (TEST):
12
13 2019-05-10  Keith Miller  <keith_miller@apple.com>
14
15         Remove legacy test262 import script
16         https://bugs.webkit.org/show_bug.cgi?id=197788
17
18         Reviewed by Yusuke Suzuki.
19
20         import-test262-tests doesn't work anymore. We should be using test262-import instead.
21
22         * Scripts/import-test262-tests: Removed.
23
24 2019-05-10  Charlie Turner  <cturner@igalia.com>
25
26         [WPE] Forward libepoxy cflags
27         https://bugs.webkit.org/show_bug.cgi?id=197784
28
29         Reviewed by Žan Doberšek.
30
31         Patch by Zan Dobersek.
32
33         * wpe/backends/CMakeLists.txt: This is required to keep
34         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
35         up trying to include X11 headers even when they're not present in the
36         environment.
37
38 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
39
40         Fix a bunch of compiler warnings
41         https://bugs.webkit.org/show_bug.cgi?id=197785
42
43         Reviewed by Don Olmstead.
44
45         Add preprocessor guards to avoid -Wunused-function warnings.
46
47         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
48         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
49         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
50
51 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
52
53         [WPE][GTK] Add webkit_frame_get_id() API
54         https://bugs.webkit.org/show_bug.cgi?id=197270
55
56         Reviewed by Carlos Garcia Campos.
57
58         This was hard, but I added a test to verify that two different WebKitFrames of the same
59         WebKitWebPage return two different frame IDs.
60
61         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
62         (WebKitFrameTest::willSubmitFormCallback):
63         (WebKitFrameTest::testSubframe):
64         (registerTests):
65         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
66         (testWebKitFrameSubframe):
67         (beforeAll):
68         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
69         (willSubmitFormCallback):
70         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
71         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
72
73 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
74
75         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
76         https://bugs.webkit.org/show_bug.cgi?id=197271
77
78         Reviewed by Youenn Fablet.
79
80         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
81         (formControlsAssociatedForFrameCallback):
82         (pageCreatedCallback):
83         (formControlsAssociatedCallback): Deleted.
84
85 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
86
87         [Flatpak] Use the safe PyYAML loader if available
88         https://bugs.webkit.org/show_bug.cgi?id=197771
89
90         Reviewed by Philippe Normand.
91
92         * flatpak/flatpakutils.py:
93         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
94         still used as fallback when the former is not provided by the module.
95
96 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
97
98         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
99         https://bugs.webkit.org/show_bug.cgi?id=197734
100
101         Reviewed by Don Olmstead.
102
103         * Scripts/webkitpy/port/win.py:
104         (WinCairoPort._search_paths): Add 'wk2' and
105         additional_platform_directory to paths as well as other ports do.
106
107 2019-05-09  Daniel Bates  <dabates@apple.com>
108
109         [iOS] Numpad comma key has incorrect keyIdentifier property
110         https://bugs.webkit.org/show_bug.cgi?id=197753
111         <rdar://problem/50636274>
112
113         Reviewed by Brent Fulgham.
114
115         Recognize "numpadComma" and return the appropriate HID usage code.
116
117         * WebKitTestRunner/ios/HIDEventGenerator.mm:
118         (hidUsageCodeForCharacter):
119
120 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
121
122         Refine AudioSession route sharing policy
123         https://bugs.webkit.org/show_bug.cgi?id=197742
124         <rdar://problem/50590818>
125
126         Reviewed by Darin Adler.
127
128         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
129         (TestWebKitAPI::TEST):
130
131 2019-05-09  Alex Christensen  <achristensen@webkit.org>
132
133         Remove unnecessary test SPI after r244883
134         https://bugs.webkit.org/show_bug.cgi?id=197575
135
136         Reviewed by Tim Horton.
137
138         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
139         (TEST):
140         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
141         (TestWebKitAPI::TEST):
142
143 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
144
145         [ews-app] Add migrations file to repository
146         https://bugs.webkit.org/show_bug.cgi?id=197729
147
148         Reviewed by Jonathan Bedard.
149
150         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
151
152 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
153
154         [ews-build] Fix formatting issues and typos
155         https://bugs.webkit.org/show_bug.cgi?id=197737
156
157         Reviewed by Jonathan Bedard.
158
159         * BuildSlaveSupport/ews-build/steps.py:
160         (CompileWebKit.evaluateCommand): Removed extra empty line.
161         * BuildSlaveSupport/ews-build/steps_unittest.py:
162         (TestRunWebKitPerlTests): Fixed typo.
163         * BuildSlaveSupport/ews-app/ews/models/step.py:
164         (Step.save_step): Changed log level to info so that it is logged in production.
165
166 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
167
168         [ews-app] Production and Development env should configure DEBUG appropriately
169         https://bugs.webkit.org/show_bug.cgi?id=197700
170
171         Reviewed by Jonathan Bedard.
172
173         * BuildSlaveSupport/ews-app/ews-app/settings.py:
174
175 2019-05-09  Xan López  <xan@igalia.com>
176
177         [CMake] Detect SSE2 at compile time
178         https://bugs.webkit.org/show_bug.cgi?id=196488
179
180         Reviewed by Carlos Garcia Campos.
181
182         * Scripts/webkitdirs.pm:
183         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
184         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
185
186 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
187
188         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
189         https://bugs.webkit.org/show_bug.cgi?id=197697
190
191         Reviewed by Žan Doberšek.
192
193         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
194         * wpe/jhbuild.modules: Ditto.
195
196 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
197
198         Update ANGLE
199         https://bugs.webkit.org/show_bug.cgi?id=197676
200
201         Reviewed by Alex Christensen.
202
203         * TestWebKitAPI/PlatformWin.cmake:
204         Remove unnecessary library linkage.
205
206 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
207
208         [Win] build-webkit should be ready for Visual Studio 2019
209         https://bugs.webkit.org/show_bug.cgi?id=196622
210
211         Reviewed by Ross Kirsling.
212
213         1. Accommodated to the new msbuild.exe location of VS 2019.
214         2. Removed the hard coded "Visual Studio 15" generator.
215
216         build-webkit is going to choose a Visual Studio generator version
217         matching with the latest installed VS. If you invoke vcvars.bat
218         before build-webkit, it chooses the corresponding Visual Studio
219         generator version by cheking 'VisualStudioVersion' env var which
220         is set by vcvars.bat.
221
222         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
223         (msBuildPath): When looking for MSBuild, look in
224         "MSBuild\Current\bin" (the new expected location) and fallback
225         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
226         first location.
227         (msBuildInstallDir): Renamed to msBuildPath.
228         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
229         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
230
231 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
232
233         [PlayStation] Update port options
234         https://bugs.webkit.org/show_bug.cgi?id=197723
235
236         Reviewed by Ross Kirsling.
237
238         ICU headers were missing from TestWTF.
239
240         * TestWebKitAPI/PlatformPlayStation.cmake:
241
242 2019-05-08  Alex Christensen  <achristensen@webkit.org>
243
244         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
245         https://bugs.webkit.org/show_bug.cgi?id=197712
246         <rdar://problem/50429770>
247
248         Reviewed by Tim Horton.
249
250         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
251         (TestWebKitAPI::TEST):
252
253 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
254
255         Change my status to be a WebKit reviewer.
256
257         * Scripts/webkitpy/common/config/contributors.json:
258
259 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
260
261         Unreviewed, rolling out r244952.
262
263         Caused inspector to appear blank.
264
265         Reverted changeset:
266
267         "Web Inspector: Provide UIString descriptions to improve
268         localizations"
269         https://bugs.webkit.org/show_bug.cgi?id=195132
270         https://trac.webkit.org/changeset/244952
271
272 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
273
274         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
275         https://bugs.webkit.org/show_bug.cgi?id=197685
276
277         Reviewed by Alex Christensen.
278
279         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
280         completion. See LayoutTests/ChangeLog for more details.
281
282         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
283         (WTR::UIScriptController::platformClearAllCallbacks):
284
285 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
286
287         Unreviewed. Add myself as a committer.
288
289         * Scripts/webkitpy/common/config/contributors.json:
290
291 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
292
293         Unreviewed, rolling out r245038.
294
295         Breaks internal builds.
296
297         Reverted changeset:
298
299         "Add SPI to set a list of hosts to which to send custom header
300         fields cross-origin"
301         https://bugs.webkit.org/show_bug.cgi?id=197397
302         https://trac.webkit.org/changeset/245038
303
304 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
305
306         Unreviewed. Add myself as a committer.
307
308         * Scripts/webkitpy/common/config/contributors.json:
309
310 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
311
312         Define media buffering policy
313         https://bugs.webkit.org/show_bug.cgi?id=196979
314         <rdar://problem/28383861>
315
316         Reviewed by Jer Noble.
317
318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
319         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
320         (waitUntilBufferingPolicyIsEqualTo):
321         (TEST):
322
323 2019-05-07  Alex Christensen  <achristensen@webkit.org>
324
325         Add SPI to set a list of hosts to which to send custom header fields cross-origin
326         https://bugs.webkit.org/show_bug.cgi?id=197397
327
328         Reviewed by Geoff Garen.
329
330         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
331         (TEST):
332         (expectLegacyHeaders):
333         (expectHeaders):
334         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
335         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
336         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
337
338 2019-05-07  Keith Rollin  <krollin@apple.com>
339
340         Add option to build-webkit to control whether or not XCBuild is used
341         https://bugs.webkit.org/show_bug.cgi?id=197668
342         <rdar://problem/50549728>
343
344         Reviewed by Tim Horton.
345
346         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
347         Also update build-webkit and the makefiles with the foundation for
348         automatically using XCBuild when the conditions allow it. This latter
349         facility is currently turned off until Xcode fully supports building
350         WebKit with XCBuild.
351
352         * Scripts/build-webkit:
353         * Scripts/webkitdirs.pm:
354         (XcodeOptions):
355         (canUseXCBuild):
356
357 2019-05-07  Andy Estes  <aestes@apple.com>
358
359         run-bindings-tests should test global scope constructor generation
360         https://bugs.webkit.org/show_bug.cgi?id=197669
361
362         Reviewed by Alex Christensen.
363
364         * Scripts/webkitpy/bindings/main.py:
365         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
366         invoking preprocess-idls.pl.
367
368 2019-05-07  Youenn Fablet  <youenn@apple.com>
369
370         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
371         https://bugs.webkit.org/show_bug.cgi?id=195997
372         <rdar://problem/50509884>
373
374         Reviewed by Chris Dumez.
375
376         Spin test until successful.
377
378         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
379
380 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
381
382         [Flatpak] webkit-build fails due to missing GTK2 in build environment
383         https://bugs.webkit.org/show_bug.cgi?id=197352
384
385         Reviewed by Philippe Normand.
386
387         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
388         to build it ourselves on top in order to be able to build the GTK 2.x plugin
389         process.
390
391         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
392
393 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
394
395         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
396         https://bugs.webkit.org/show_bug.cgi?id=197644
397         <rdar://problem/50526364>
398
399         Reviewed by Tim Horton.
400
401         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
402
403         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
404         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
405         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
406         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
407
408 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
409
410         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
411         https://bugs.webkit.org/show_bug.cgi?id=197651
412
413         Reviewed by Žan Doberšek.
414
415         This is required since the process creation was delayed until something is loaded in the view.
416
417         * MiniBrowser/gtk/BrowserWindow.c:
418         (browser_window_get_or_create_web_view_for_automation):
419         * MiniBrowser/wpe/main.cpp:
420         (main):
421
422 2019-05-06  Tim Horton  <timothy_horton@apple.com>
423
424         _overrideViewportWithArguments does not work when called before loading
425         https://bugs.webkit.org/show_bug.cgi?id=197638
426         <rdar://problem/50505111>
427
428         Reviewed by Wenson Hsieh.
429
430         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
431         (TEST):
432
433 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
434
435         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
436         https://bugs.webkit.org/show_bug.cgi?id=197510
437
438         Reviewed by Alex Christensen.
439
440         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
441         (TestWebKitAPI::TEST):
442
443 2019-05-06  Keith Rollin  <krollin@apple.com>
444
445         Temporarily disable generate-xcfilelists
446         https://bugs.webkit.org/show_bug.cgi?id=197619
447         <rdar://problem/50507392>
448
449         Reviewed by Alex Christensen.
450
451         We need to perform a significant update to the generate-xcfilelist
452         scripts. This work involves coordinated work with another facility. If
453         the work does not occur in tandem, the build will be broken. To avoid
454         this, disable the invoking of the scripts during the transition. The
455         checking will be restored once the new scripts are in place.
456
457         * DumpRenderTree/Scripts/check-xcfilelists.sh:
458         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
459
460 2019-05-04  Alex Christensen  <achristensen@webkit.org>
461
462         Revert r244953 and r244954 because they broke internal builds.
463         https://bugs.webkit.org/show_bug.cgi?id=197534
464
465         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
466         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
467         * DumpRenderTree/mac/DumpRenderTree.mm:
468         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
469         * DumpRenderTree/mac/TestRunnerMac.mm:
470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
471         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
472         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
473         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
474         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
475         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
476         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
477         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
478         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
479         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
480         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
481         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
482         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
483         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
484         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
485         * TestWebKitAPI/cocoa/TestWKWebView.mm:
486         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
487         * TestWebKitAPI/ios/UIKitSPI.h: Added.
488         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
489         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
490         * WebKitTestRunner/ios/HIDEventGenerator.h:
491         * WebKitTestRunner/ios/HIDEventGenerator.mm:
492         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
493         * WebKitTestRunner/ios/TestControllerIOS.mm:
494         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
495         * WebKitTestRunner/ios/mainIOS.mm:
496
497 2019-05-04  Alex Christensen  <achristensen@webkit.org>
498
499         Merge the three UIKitSPI.h files into a single one in PAL
500         https://bugs.webkit.org/show_bug.cgi?id=197534
501
502         Reviewed by Darin Adler.
503
504         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
505         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
506         * DumpRenderTree/mac/DumpRenderTree.mm:
507         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
508         * DumpRenderTree/mac/TestRunnerMac.mm:
509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
510         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
511         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
512         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
513         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
514         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
515         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
516         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
517         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
518         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
519         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
520         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
521         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
522         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
523         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
524         * TestWebKitAPI/cocoa/TestWKWebView.mm:
525         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
526         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
527         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
528         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
529         * WebKitTestRunner/ios/HIDEventGenerator.h:
530         * WebKitTestRunner/ios/HIDEventGenerator.mm:
531         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
532         * WebKitTestRunner/ios/TestControllerIOS.mm:
533         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
534         * WebKitTestRunner/ios/mainIOS.mm:
535
536 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
537
538         Web Inspector: Provide UIString descriptions to improve localizations
539         https://bugs.webkit.org/show_bug.cgi?id=195132
540         <rdar://problem/48457817>
541
542         Reviewed by Devin Rousso.
543
544         Allow WI.UIString to take:
545         - WI.UIString(string, key, comment)
546         - WI.UIString(string, comment)
547         - WI.UIString(string)
548
549         * Scripts/extract-localizable-js-strings:
550
551 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
552
553         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
554         https://bugs.webkit.org/show_bug.cgi?id=197579
555
556         Reviewed by Tim Horton.
557
558         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
559         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
560         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
561         ensure that the the focused element has been blurred.
562
563         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
564
565 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
566
567         Add a tool to block spammer accounts
568         https://bugs.webkit.org/show_bug.cgi?id=197537
569
570         Reviewed by Darin Adler.
571
572         Usage: block-spammers email1 email2 ...
573
574         The tool finds and hides all bugs and comments from this account. Before any work
575         is done, these bugs and comments are displayed for confirmation.
576
577         * Scripts/block-spammers: Added.
578         (get_bugzilla_token):
579         (invalidate_bugzilla_token):
580         (get_user_info):
581         (get_user_info_self):
582         (can_use_this_tool):
583         (disable_user):
584         (get_bugs_created_by_user):
585         (get_bugs_commented_on_by_user):
586         (get_comments):
587         (hide_bug):
588         (hide_comments):
589         (ask_yes_no):
590         (sanitized_string):
591         (main):
592
593 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
594
595         run-apit-tests: Add --iterations and --repeat-each
596         https://bugs.webkit.org/show_bug.cgi?id=197563
597
598         Reviewed by Aakash Jain.
599
600         * Scripts/webkitpy/api_tests/manager.py:
601         (Manager.run): Add --iterations and --repeat-each/
602         * Scripts/webkitpy/api_tests/run_api_tests.py:
603         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
604
605 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
606
607         New EWS: Clicking on white bubble navigates to page with only bubbles
608         https://bugs.webkit.org/show_bug.cgi?id=197520
609
610         Reviewed by Lucas Forschler.
611
612         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
613
614 2019-05-03  Daniel Bates  <dabates@apple.com>
615
616         [lldb-webkit] Support adding pretty-printing for qualified types
617         https://bugs.webkit.org/show_bug.cgi?id=197518
618
619         Reviewed by Darin Adler.
620
621         Remove all "::"s from the name of the specified type when computing the name for the Python classes
622         that will provide summary and synthetic details as LLDB is not happy about registering such classes
623         when they contain :: in their name.
624
625         * lldb/lldb_webkit.py:
626         (addSummaryAndSyntheticFormattersForRawBitmaskType):
627
628 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
629
630         New EWS: patches on recently added queues listed as #1 for older bugs
631         https://bugs.webkit.org/show_bug.cgi?id=197496
632
633         Reviewed by Lucas Forschler.
634
635         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
636         (StatusBubble._build_bubble):
637         (StatusBubble._queue_position):
638
639 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
640
641         webkit-patch --no-review upload does not submit patch to New EWS
642         https://bugs.webkit.org/show_bug.cgi?id=197519
643         <rdar://problem/50424887>
644
645         Reviewed by Lucas Forschler.
646
647         * Scripts/webkitpy/tool/steps/submittoews.py:
648         (SubmitToEWS.run): Submit to both old and new EWS.
649         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
650         * Scripts/webkitpy/common/net/ewsserver.py: Added.
651         (EWSServer._server_url): Method to return server url.
652         (EWSServer._post_patch_to_ews): Method to post patch to ews.
653         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
654         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
655         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
656         * Scripts/webkitpy/common/net/statusserver_mock.py:
657         (MockStatusServer.submit_to_ews): Updated the log text.
658         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
659         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
660         * Scripts/webkitpy/tool/main.py:
661         (WebKitPatch.__init__): Initialize ews_server. 
662         * Scripts/webkitpy/tool/mocktool.py:
663         (MockTool.__init__): Ditto.
664
665 2019-05-03  Chris Dumez  <cdumez@apple.com>
666
667         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
668         https://bugs.webkit.org/show_bug.cgi?id=197574
669         <rdar://problem/50453181>
670
671         Reviewed by Tim Horton.
672
673         Add API test coverage.
674
675         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
676         (TEST):
677
678 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
679
680         [JSC] Generator CodeBlock generation should be idempotent
681         https://bugs.webkit.org/show_bug.cgi?id=197552
682
683         Reviewed by Keith Miller.
684
685         * Scripts/run-javascriptcore-tests:
686         (runJSCStressTests):
687         * Scripts/run-jsc-stress-tests:
688
689 2019-05-03  Commit Queue  <commit-queue@webkit.org>
690
691         Unreviewed, rolling out r244881.
692         https://bugs.webkit.org/show_bug.cgi?id=197559
693
694         Breaks compilation of jsconly on linux, breaking compilation
695         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
696         guijemont on #webkit).
697
698         Reverted changeset:
699
700         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
701         WEBKIT_COPY_FILES"
702         https://bugs.webkit.org/show_bug.cgi?id=197174
703         https://trac.webkit.org/changeset/244881
704
705 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
706
707         Unreviewed WPE build fix after r244898.
708
709         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
710         (WTR::TestController::abortModal): Add the missing (no-op) definition.
711
712 2019-05-02  Alex Christensen  <achristensen@webkit.org>
713
714         Mark U+01C0 as a homograph of U+006C
715         https://bugs.webkit.org/show_bug.cgi?id=197526
716         <rdar://problem/50301904>
717
718         Reviewed by Tim Horton.
719
720         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
721         (TestWebKitAPI::TEST):
722
723 2019-05-02  Chris Dumez  <cdumez@apple.com>
724
725         Add test coverage for <rdar://problem/49731231>
726         https://bugs.webkit.org/show_bug.cgi?id=196730
727         <rdar://problem/49731231>
728
729         Reviewed by Ryosuke Niwa.
730
731         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
732         to match DumpRenderTree.
733
734         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
735         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
736         (WTR::TestRunner::abortModal):
737         * WebKitTestRunner/InjectedBundle/TestRunner.h:
738         * WebKitTestRunner/TestController.cpp:
739         (WTR::TestController::runModal):
740         * WebKitTestRunner/TestController.h:
741         * WebKitTestRunner/TestInvocation.cpp:
742         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
743         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
744         (WTR::TestController::abortModal):
745         * WebKitTestRunner/ios/TestControllerIOS.mm:
746         (WTR::TestController::abortModal):
747         * WebKitTestRunner/mac/TestControllerMac.mm:
748         (WTR::TestController::abortModal):
749         * WebKitTestRunner/win/TestControllerWin.cpp:
750         (WTR::TestController::abortModal):
751
752 2019-05-02  Christopher Reid  <chris.reid@sony.com>
753
754         [CMake] Add support for LTO builds
755         https://bugs.webkit.org/show_bug.cgi?id=188986
756
757         Reviewed by Don Olmstead.
758
759         Add support to configure --lto-mode with cmake builds.
760
761         * Scripts/build-webkit:
762         * Scripts/webkitdirs.pm:
763         (generateBuildSystemFromCMakeProject):
764
765 2019-05-02  John Wilander  <wilander@apple.com>
766
767         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
768         https://bugs.webkit.org/show_bug.cgi?id=197521
769         <rdar://problem/49651503>
770
771         Reviewed by Brent Fulgham.
772
773         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
774         (TestWebKitAPI::TEST):
775            Added a test for host strings with leading dots since they are
776            often used for the domain attribute in cookies.
777
778 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
779
780         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
781         https://bugs.webkit.org/show_bug.cgi?id=197510
782
783         Reviewed by Alex Christensen.
784
785         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
786         (TestWebKitAPI::TEST):
787
788 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
789
790         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
791         https://bugs.webkit.org/show_bug.cgi?id=197174
792
793         Reviewed by Alex Christensen.
794
795         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
796
797         * TestWebKitAPI/PlatformGTK.cmake:
798         * TestWebKitAPI/PlatformWPE.cmake:
799
800 2019-05-02  Alex Christensen  <achristensen@webkit.org>
801
802         Build fix for internal branch.
803
804         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
805         RetainPtr.h was not explicitly included.
806
807 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
808
809         webkitpy: Ignore errors when shutting down an already shutdown simulator
810         <https://bugs.webkit.org/show_bug.cgi?id=197514>
811         <rdar://problem/50390247>
812
813         Reviewed by Lucas Forschler.
814
815         * Scripts/webkitpy/xcode/simulated_device.py:
816         (SimulatedDevice._shut_down):
817
818 2019-05-02  Frederic Wang  <fwang@igalia.com>
819
820         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
821         https://bugs.webkit.org/show_bug.cgi?id=196142
822
823         This patch introduces some experimental runtime flag to let users
824         disable MathML features that are removed from MathML Core [1]. For now,
825         these features are only disabled on GTK and WPE ports.
826
827         [1] https://mathml-refresh.github.io/mathml-core/
828
829         Reviewed by Rob Buis.
830
831         * DumpRenderTree/TestOptions.cpp:
832         (TestOptions::TestOptions):
833         * DumpRenderTree/TestOptions.h:
834         * DumpRenderTree/mac/DumpRenderTree.mm:
835         (setWebPreferencesForTestOptions):
836
837 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
838
839         TestWebKitAPI config.h should be aware of what suite is being built
840         https://bugs.webkit.org/show_bug.cgi?id=196583
841
842         Reviewed by Konstantin Tokarev.
843
844         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
845         benefit the macro defines BUILDING_* for the executable which allows the includes
846         of the config.h to be tailored to the test suite being built. Because of that the
847         dependencies of the Test* executable are specific to the test suite which may
848         speed up the build.
849
850         Some source files were including "PlatformUtilities.h" which includes WebKit headers
851         when "Utilities.h" is what was needed.
852
853         * TestWebKitAPI/CMakeLists.txt:
854         * TestWebKitAPI/PlatformGTK.cmake:
855         * TestWebKitAPI/PlatformJSCOnly.cmake:
856         * TestWebKitAPI/PlatformMac.cmake:
857         * TestWebKitAPI/PlatformPlayStation.cmake:
858         * TestWebKitAPI/PlatformUtilities.h:
859         * TestWebKitAPI/PlatformWPE.cmake:
860         * TestWebKitAPI/PlatformWin.cmake:
861         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
862         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
863         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
864         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
865         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
866         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
867         * TestWebKitAPI/config.h:
868
869 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
870
871         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
872         https://bugs.webkit.org/show_bug.cgi?id=181950
873         <rdar://problem/43357371>
874
875         Reviewed by Brent Fulgham.
876
877         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
878         (TestWebKitAPI::TEST_F):
879
880 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
881
882         Remove webkitpy and bindings EWS queues from dashboard
883         https://bugs.webkit.org/show_bug.cgi?id=197475
884
885         Reviewed by Alexey Proskuryakov.
886
887         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
888
889 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
890
891         Remove webkitpy and bindings test queues from old EWS
892         https://bugs.webkit.org/show_bug.cgi?id=197468
893
894         Reviewed by Alexey Proskuryakov.
895
896         * QueueStatusServer/config/queues.py:
897
898 2019-04-30  Tim Horton  <timothy_horton@apple.com>
899
900         Fix the WebKitTestRunner build
901         https://bugs.webkit.org/show_bug.cgi?id=197449
902         <rdar://problem/50334169>
903
904         Reviewed by Alexey Proskuryakov.
905
906         * WebKitTestRunner/mac/EventSenderProxy.mm:
907         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
908         (WTR::EventSenderProxy::mouseForceChanged):
909         Use some SPI instead of IPI.
910
911 2019-04-30  Chris Dumez  <cdumez@apple.com>
912
913         Regression(PSON) URL scheme handlers can no longer respond asynchronously
914         https://bugs.webkit.org/show_bug.cgi?id=197426
915         <rdar://problem/50256169>
916
917         Reviewed by Brady Eidson.
918
919         Add API test coverage.
920
921         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
922         (-[PSONScheme setShouldRespondAsynchronously:]):
923         (-[PSONScheme webView:startURLSchemeTask:]):
924         (-[PSONScheme webView:stopURLSchemeTask:]):
925
926 2019-04-30  Chris Dumez  <cdumez@apple.com>
927
928         Unreviewed, rolling out r244802.
929
930         Caused an API test failure
931
932         Reverted changeset:
933
934         "Regression(PSON) URL scheme handlers can no longer respond
935         asynchronously"
936         https://bugs.webkit.org/show_bug.cgi?id=197426
937         https://trac.webkit.org/changeset/244802
938
939 2019-04-30  Chris Dumez  <cdumez@apple.com>
940
941         Regression(PSON) URL scheme handlers can no longer respond asynchronously
942         https://bugs.webkit.org/show_bug.cgi?id=197426
943         <rdar://problem/50256169>
944
945         Reviewed by Brady Eidson.
946
947         Add API test coverage.
948
949         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
950         (-[PSONScheme setShouldRespondAsynchronously:]):
951         (-[PSONScheme webView:startURLSchemeTask:]):
952         (-[PSONScheme webView:stopURLSchemeTask:]):
953
954 2019-04-30  Chris Dumez  <cdumez@apple.com>
955
956         Only use a related page's process if that page has not been closed yet
957         https://bugs.webkit.org/show_bug.cgi?id=197393
958         <rdar://problem/50302423>
959
960         Reviewed by Tim Horton.
961
962         Add API test coverage.
963
964         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
965
966 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
967
968         [ews-build] Enable Bindings tests queue on new EWS
969         https://bugs.webkit.org/show_bug.cgi?id=197424
970
971         Reviewed by Lucas Forschler.
972
973         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
974         (StatusBubble):
975         * BuildSlaveSupport/ews-build/config.json:
976
977 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
978
979         [ews-build] Configure ews151 for running various tests
980         https://bugs.webkit.org/show_bug.cgi?id=197419
981
982         Reviewed by Lucas Forschler.
983
984         * BuildSlaveSupport/ews-build/config.json:
985
986 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
987
988         [ews-build] Parse and display bindings test failures
989         https://bugs.webkit.org/show_bug.cgi?id=197423
990
991         Reviewed by Lucas Forschler.
992
993         * BuildSlaveSupport/ews-build/steps.py:
994         (RunBindingsTests.__init__): Set timeout of 5 minutes.
995         (RunBindingsTests.start): Initialize log_observer for json output.
996         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
997         (RunBindingsTests._addToLog): Method to add message to log.
998         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
999
1000 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
1001
1002         Unreviewed. Add myself as a committer.
1003
1004         * Scripts/webkitpy/common/config/contributors.json:
1005
1006 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1007
1008         [ews-build] Enable webkitpy queue on new EWS
1009         https://bugs.webkit.org/show_bug.cgi?id=197396
1010
1011         Reviewed by Lucas Forschler.
1012
1013         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1014         (StatusBubble):
1015         * BuildSlaveSupport/ews-build/config.json:
1016
1017 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1018
1019         [ews-build] Parse and display webkitpy failures
1020         https://bugs.webkit.org/show_bug.cgi?id=197395
1021
1022         Reviewed by Lucas Forschler.
1023
1024         * BuildSlaveSupport/ews-build/steps.py:
1025         (RunWebKitPyTests.start): Initialize log_observer for json output.
1026         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
1027         (RunWebKitPyTests._addToLog): Method to add message to log.
1028         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1029
1030 2019-04-29  Alex Christensen  <achristensen@webkit.org>
1031
1032         <rdar://problem/50299396> Fix internal High Sierra build
1033         https://bugs.webkit.org/show_bug.cgi?id=197388
1034
1035         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1036         * MiniBrowser/Configurations/Base.xcconfig:
1037         * MobileMiniBrowser/Configurations/Base.xcconfig:
1038         * TestWebKitAPI/Configurations/Base.xcconfig:
1039         * WebKitTestRunner/Configurations/Base.xcconfig:
1040
1041 2019-04-29  Youenn Fablet  <youenn@apple.com>
1042
1043         Remove spurious GVA printf logging
1044         https://bugs.webkit.org/show_bug.cgi?id=197368
1045         <rdar://problem/35975256>
1046
1047         Reviewed by Alexey Proskuryakov.
1048
1049         * Scripts/webkitpy/port/mac.py:
1050         (MacPort.logging_patterns_to_strip):
1051
1052 2019-04-29  Youenn Fablet  <youenn@apple.com>
1053
1054         getDisplayMedia should be called on user gesture
1055         https://bugs.webkit.org/show_bug.cgi?id=197356
1056         <rdar://problem/50296074>
1057
1058         Reviewed by Eric Carlson.
1059
1060         Update test configuration to inject internals
1061         so that we can use it to simulate a user click to call getDisplayMedia.
1062
1063         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1064         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1065         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
1066
1067 2019-04-26  Stephanie Lewis  <slewis@apple.com>
1068
1069         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
1070         https://bugs.webkit.org/show_bug.cgi?id=197339
1071
1072         Reviewed by Dewei Zhu.
1073
1074         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
1075         test run for setup steps that are too expensive to do every iteration.
1076
1077         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1078         (BenchmarkRunner._run_benchmark):
1079         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1080         (BrowserDriver):
1081         (BrowserDriver.prepare_initial_env):
1082         (BrowserDriver.restore_env_after_all_testing):
1083         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1084         (LinuxBrowserDriver.prepare_initial_env):
1085         (LinuxBrowserDriver.restore_env_after_all_testing):
1086         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1087         (OSXBrowserDriver.prepare_initial_env):
1088         (OSXBrowserDriver.restore_env_after_all_testing):
1089
1090 2019-04-28  Andy Estes  <aestes@apple.com>
1091
1092         Fix the watchOS engineering build.
1093
1094         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1095         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
1096
1097 2019-04-27  Chris Dumez  <cdumez@apple.com>
1098
1099         [WKTR] Move test timeout handling to the UIProcess
1100         https://bugs.webkit.org/show_bug.cgi?id=197333
1101
1102         Reviewed by Darin Adler.
1103
1104         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
1105         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
1106         every WebContent process in the case of swapping.
1107
1108         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
1109         would lead to crashes when firing the timer.
1110
1111         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1112         (WTR::InjectedBundle::didReceiveMessageToPage):
1113         (WTR::InjectedBundle::done):
1114         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1115         (WTR::InjectedBundle::shouldDumpPixels const):
1116         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1117         (WTR::TestRunner::TestRunner):
1118         (WTR::TestRunner::waitUntilDone):
1119         (WTR::TestRunner::setWaitUntilDone):
1120         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1121         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1122         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1123         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1124         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1125         * WebKitTestRunner/TestInvocation.cpp:
1126         (WTR::TestInvocation::TestInvocation):
1127         (WTR::TestInvocation::createTestSettingsDictionary):
1128         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1129         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1130         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
1131         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
1132         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
1133         (WTR::TestInvocation::setWaitUntilDone):
1134         (WTR::TestInvocation::done):
1135         * WebKitTestRunner/TestInvocation.h:
1136
1137 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
1138
1139         [JSC] linkPolymorphicCall now does GC
1140         https://bugs.webkit.org/show_bug.cgi?id=197306
1141
1142         Reviewed by Saam Barati.
1143
1144         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
1145         To add this test, we add `runWithoutBaseOption`.
1146
1147         * Scripts/run-jsc-stress-tests:
1148
1149 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1150
1151         Update inactive reviewers' status to 'contributor'.
1152
1153         Accidentally skipped one at first.
1154
1155         * Scripts/webkitpy/common/config/contributors.json:
1156
1157 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1158
1159         Update inactive reviewers' status to 'contributor'.
1160
1161         * Scripts/webkitpy/common/config/contributors.json: The change.
1162
1163         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1164         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1165         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1166         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1167         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1168         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1169         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1170         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1171         Sadly, regression tests operate on a crazy mix of mock and live data for
1172         contributors.json. It would be a substantial project to mock all code paths,
1173         so changing the tests instead.
1174
1175 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
1176
1177         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1178         https://bugs.webkit.org/show_bug.cgi?id=197171
1179         <rdar://problem/47454979>
1180
1181         Reviewed by Youenn Fablet.
1182
1183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1184         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1185         (TestWebKitAPI::TEST):
1186
1187 2019-04-26  David Kilzer  <ddkilzer@apple.com>
1188
1189         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
1190         <https://webkit.org/b/197314>
1191         <rdar://problem/50245252>
1192
1193         Reviewed by Simon Fraser.
1194
1195         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1196         (WTR::UIScriptController::lastUndoLabel const):
1197         (WTR::UIScriptController::firstRedoLabel const):
1198         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1199
1200         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1201         (-[HIDEventGenerator sendEventStream:completionBlock:]):
1202         - Call -autorelease to fix leak of NSDictionary.
1203
1204         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1205         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
1206         (WTR::UIScriptController::selectFormPopoverTitle const):
1207         (WTR::UIScriptController::textContentType const):
1208         (WTR::UIScriptController::formInputLabel const):
1209         (WTR::UIScriptController::scrollingTreeAsText const):
1210         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1211
1212 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
1213
1214         webkitpy: Running a single test will always use the default device
1215         https://bugs.webkit.org/show_bug.cgi?id=195472
1216         <rdar://problem/48724825>
1217
1218         Reviewed by Lucas Forschler.
1219
1220         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
1221         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
1222         requested will be run regardless of what shard they are in.
1223
1224         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1225         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
1226         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1227         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
1228         on the default device type.
1229         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1230         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
1231         (RunTest.test_run_part): Ditto.
1232
1233 2019-04-26  Alex Christensen  <achristensen@webkit.org>
1234
1235         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
1236         https://bugs.webkit.org/show_bug.cgi?id=197165
1237
1238         Reviewed by Youenn Fablet.
1239
1240         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1241
1242 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1243
1244         Replace iOS build queue hardware
1245         https://bugs.webkit.org/show_bug.cgi?id=197312
1246
1247         Reviewed by Aakash Jain.
1248
1249         * BuildSlaveSupport/build.webkit.org-config/config.json:
1250         Use newer hardware that supports macOS Mojave.
1251
1252 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
1253
1254         check-webkit-style complains the first block in while loop.
1255         https://bugs.webkit.org/show_bug.cgi?id=197307
1256
1257         The style checker shouldn't complain about an open brace on
1258         its own line if the last non-whitespace character on the previous
1259         non-blank line is another open brace, because it's likely to
1260         indicate the begining of a nested code block.
1261
1262         Reviewed by Alex Christensen.
1263
1264         * Scripts/webkitpy/style/checkers/cpp.py:
1265         (check_braces):
1266         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1267         (WebKitStyleTest.test_braces):
1268
1269 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
1270
1271         Stop IDB transactions to release locked database files when network process is ready to suspend
1272         https://bugs.webkit.org/show_bug.cgi?id=196372
1273         <rdar://problem/48930116>
1274
1275         Reviewed by Brady Eidson.
1276
1277         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1278         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
1279         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
1280         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
1281         (runTestAndCheckResult):
1282         (keepNetworkProcessActive):
1283         (TEST):
1284
1285 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1286
1287         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
1288         https://bugs.webkit.org/show_bug.cgi?id=188357
1289         <rdar://problem/42986633>
1290
1291         Reviewed by Dean Jackson.
1292
1293         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
1294         tests would fall into low memory mode and have different behavior.
1295         
1296         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
1297         to Internals, so it's shared by DRT and WTR.
1298         
1299         We no longer need the WK2 C SPI glue.
1300
1301         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1302         (WTR::InjectedBundlePage::prepare):
1303
1304 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
1305
1306         webkitpy: Including skipped tests in the final count
1307         https://bugs.webkit.org/show_bug.cgi?id=197298
1308         <rdar://problem/49705424>
1309
1310         Reviewed by Lucas Forschler.
1311
1312         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1313         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
1314
1315 2019-04-25  Timothy Hatcher  <timothy@apple.com>
1316
1317         Disable date and time inputs on iOSMac.
1318         https://bugs.webkit.org/show_bug.cgi?id=197287
1319         rdar://problem/46794376
1320
1321         Reviewed by Wenson Hsieh.
1322
1323         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1324
1325 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1326
1327         Fix test-webkitpy after r244653
1328         https://bugs.webkit.org/show_bug.cgi?id=197131
1329
1330         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1331         Also use C++17.
1332
1333 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
1334
1335         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
1336         https://bugs.webkit.org/show_bug.cgi?id=196991
1337         <rdar://problem/45507423>
1338
1339         Reviewed by Alex Christensen.
1340
1341         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1342         (-[NavigationTestDelegate init]):
1343         (-[NavigationTestDelegate waitForDidFinishNavigation]):
1344         (-[NavigationTestDelegate webView:didFinishNavigation:]):
1345         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1346         (TestWebKitAPI::TEST):
1347         (TEST): Deleted.
1348
1349 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1350
1351         Revert some code accidentally committed with r244653
1352         https://bugs.webkit.org/show_bug.cgi?id=197131
1353
1354         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1355         (TestWebKitAPI::TEST):
1356
1357 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1358
1359         Start using C++17
1360         https://bugs.webkit.org/show_bug.cgi?id=197131
1361
1362         Reviewed by Darin Adler.
1363
1364         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1365         * MiniBrowser/Configurations/Base.xcconfig:
1366         * MobileMiniBrowser/Configurations/Base.xcconfig:
1367         * TestWebKitAPI/Configurations/Base.xcconfig:
1368         * WebKitTestRunner/Configurations/Base.xcconfig:
1369
1370 2019-04-25  Commit Queue  <commit-queue@webkit.org>
1371
1372         Unreviewed, rolling out r244627.
1373         https://bugs.webkit.org/show_bug.cgi?id=197282
1374
1375         Causing internal build failures (Requested by ShawnRoberts on
1376         #webkit).
1377
1378         Reverted changeset:
1379
1380         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1381         https://bugs.webkit.org/show_bug.cgi?id=197171
1382         https://trac.webkit.org/changeset/244627
1383
1384 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1385
1386         [GTK] Hardcoded text color in input fields
1387         https://bugs.webkit.org/show_bug.cgi?id=126907
1388
1389         Reviewed by Michael Catanzaro.
1390
1391         Add dark-mode command line option to MiniBrowser.
1392
1393         * MiniBrowser/gtk/main.c:
1394         (main):
1395
1396 2019-04-24  Zalan Bujtas  <zalan@apple.com>
1397
1398         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1399         https://bugs.webkit.org/show_bug.cgi?id=196948
1400         <rdar://problem/49927131>
1401
1402         Reviewed by Tim Horton.
1403
1404         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1405         (TEST):
1406         The expected order of incoming events is
1407         1. didInvalidateIntrinsicContentSize
1408         2. didFirstLayout
1409         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1410         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1411         (and remember, all we care about is ordering).
1412
1413 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
1414
1415         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1416         https://bugs.webkit.org/show_bug.cgi?id=197171
1417         <rdar://problem/47454979>
1418
1419         Reviewed by Youenn Fablet.
1420
1421         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1422         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1423         (TestWebKitAPI::TEST):
1424
1425 2019-04-24  Brady Eidson  <beidson@apple.com>
1426
1427         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
1428         https://bugs.webkit.org/show_bug.cgi?id=191362
1429
1430         Reviewed by Alex Christensen.
1431
1432         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
1433           from an XHR to a custom protocol.
1434
1435 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1436
1437         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
1438         https://bugs.webkit.org/show_bug.cgi?id=197273
1439
1440         Reviewed by Dean Jackson.
1441
1442         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
1443         so that WebCoreTestSupport::resetInternalsObject() is always run.
1444
1445         * DumpRenderTree/mac/DumpRenderTree.mm:
1446         (resetWebViewToConsistentStateBeforeTesting):
1447         (runTest):
1448
1449 2019-04-24  John Wilander  <wilander@apple.com>
1450
1451         Age out unconverted Ad Click Attributions after one week.
1452         https://bugs.webkit.org/show_bug.cgi?id=197238
1453         <rdar://problem/50177349>
1454
1455         Reviewed by Chris Dumez.
1456
1457         This patch adds infrastructure to allow tests to expire all unconverted
1458         attributions early.
1459
1460         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1461         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1462         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
1463         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1464         * WebKitTestRunner/TestController.cpp:
1465         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
1466         * WebKitTestRunner/TestController.h:
1467         * WebKitTestRunner/TestInvocation.cpp:
1468         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1469
1470 2019-04-24  Chris Dumez  <cdumez@apple.com>
1471
1472         Fix flaky crashes in a couple of PSON API tests
1473         https://bugs.webkit.org/show_bug.cgi?id=197239
1474
1475         Reviewed by Tim Horton.
1476
1477         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
1478
1479         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1480
1481 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
1482
1483         Make it possible to control the renderTreeAsText output by setting options on testRunner
1484         https://bugs.webkit.org/show_bug.cgi?id=197133
1485
1486         Reviewed by Sam Weinig.
1487
1488         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
1489         that make sense in testing (those that don't dump unstable data like addresses), and plumb
1490         these flags through the various framework layers.
1491
1492         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
1493
1494         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
1495         and hand-code DumpRenderTree bindings.
1496
1497         Some cleanup of the TestRunners, using member initializers.
1498
1499         * DumpRenderTree/TestRunner.cpp:
1500         (TestRunner::TestRunner):
1501         (setRenderTreeDumpOptionsCallback):
1502         (TestRunner::staticFunctions):
1503         (TestRunner::setRenderTreeDumpOptions):
1504         * DumpRenderTree/TestRunner.h:
1505         (TestRunner::renderTreeDumpOptions const):
1506         * DumpRenderTree/mac/DumpRenderTree.mm:
1507         (dump):
1508         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1509         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1510         (WTR::InjectedBundlePage::dump):
1511         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1512         (WTR::TestRunner::TestRunner):
1513         (WTR::TestRunner::setRenderTreeDumpOptions):
1514         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1515         (WTR::TestRunner::renderTreeDumpOptions const):
1516
1517 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1518
1519         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
1520         https://bugs.webkit.org/show_bug.cgi?id=197078
1521         <rdar://problem/49564348>
1522
1523         Reviewed by Geoff Garen.
1524
1525         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1526         (TEST_F):
1527         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
1528         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
1529         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
1530
1531 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1532
1533         Add unit test for r239322
1534         https://bugs.webkit.org/show_bug.cgi?id=197236
1535
1536         Reviewed by Chris Dumez.
1537
1538         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
1539         May as well add the test infrastructure which was needed before and will be needed in the future.
1540
1541         * TestWebKitAPI/TCPServer.cpp:
1542         (TestWebKitAPI::TCPServer::TCPServer):
1543         * TestWebKitAPI/TCPServer.h:
1544         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1545         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1546         (TestWebKitAPI::TEST):
1547         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1548         (TestWebKitAPI::downloadAtRate):
1549         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1550         (TEST):
1551         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
1552         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1553         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1554         (TestWebKitAPI::TEST):
1555         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1556         (TEST):
1557
1558 2019-04-24  Chris Dumez  <cdumez@apple.com>
1559
1560         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
1561         https://bugs.webkit.org/show_bug.cgi?id=197214
1562         <rdar://problem/49237544>
1563
1564         Reviewed by Alex Christensen.
1565
1566         Extend API test coverage.
1567
1568         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1569         (TEST):
1570
1571 2019-04-24  Philippe Normand  <pnormand@igalia.com>
1572
1573         [Build][GStreamer] Update to 1.16.0
1574         https://bugs.webkit.org/show_bug.cgi?id=197157
1575
1576         Reviewed by Xabier Rodriguez-Calvar.
1577
1578         The upstreamed patches were removed and a new one was added for a
1579         regression detected in the scaletempo GStreamer element. The GNOME
1580         Flatpak was migrated to 3.32 and I switched a few modules to Meson
1581         on the way, as it is the preferred build system now in GStreamer
1582         1.16.
1583
1584         * flatpak/files/httpd-autogen.sh:
1585         * flatpak/flatpakutils.py:
1586         (FlatpakPackage.install):
1587         (WebkitFlatpak.run_in_sandbox):
1588         * flatpak/org.webkit.CommonModules.yaml:
1589         * flatpak/org.webkit.WebKit.yaml:
1590         * gstreamer/jhbuild.modules:
1591         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
1592         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
1593         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
1594         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
1595         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
1596         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
1597         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
1598         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
1599         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
1600         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1601         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
1602         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1603         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
1604         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
1605         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
1606         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
1607         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
1608         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
1609         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
1610         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
1611         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
1612         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
1613
1614 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1615
1616         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
1617         https://bugs.webkit.org/show_bug.cgi?id=197156
1618
1619         Reviewed by Michael Catanzaro.
1620
1621         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
1622         support was added.
1623
1624         * MiniBrowser/gtk/BrowserTab.c:
1625         (browser_tab_set_background_color): Set the passed in color as web view background color.
1626         * MiniBrowser/gtk/BrowserTab.h:
1627         * MiniBrowser/gtk/BrowserWindow.c:
1628         (browser_window_init): Initialize backgroundColor.
1629         (browser_window_append_view): Call browser_tab_set_background_color().
1630         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
1631         are added.
1632         * MiniBrowser/gtk/main.c:
1633         (main): Call browser_window_set_background_color() before creating the tabs.
1634
1635 2019-04-23  John Wilander  <wilander@apple.com>
1636
1637         Move Ad Click Attribution from internal feature to experimental feature
1638         https://bugs.webkit.org/show_bug.cgi?id=197218
1639         <rdar://problem/47651691>
1640
1641         Reviewed by Brent Fulgham.
1642
1643         * DumpRenderTree/TestOptions.cpp:
1644         (TestOptions::TestOptions):
1645
1646 2019-04-23  Andy Estes  <aestes@apple.com>
1647
1648         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1649         https://bugs.webkit.org/show_bug.cgi?id=196749
1650         <rdar://problem/35773454>
1651
1652         Reviewed by Daniel Bates.
1653
1654         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1655
1656         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1657         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1658         (-[QuickLookDelegate webView:didFinishNavigation:]):
1659         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1660         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1661         (runTest):
1662         (runTestDecideBeforeLoading):
1663         (runTestDecideAfterLoading):
1664         (TEST):
1665
1666 2019-04-23  John Wilander  <wilander@apple.com>
1667
1668         Remove Ad Click Attribution data when removing website data
1669         https://bugs.webkit.org/show_bug.cgi?id=197215
1670         <rdar://problem/47668988>
1671
1672         Reviewed by Chris Dumez.
1673
1674         This patch adds test infrastructure to delete Ad Click Attribution data
1675         through WebsiteDataStore::removeData().
1676
1677         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1678         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1679         (WTR::TestRunner::clearAdClickAttribution):
1680         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1681         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1682         * WebKitTestRunner/TestController.cpp:
1683         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1684         * WebKitTestRunner/TestController.h:
1685         * WebKitTestRunner/TestInvocation.cpp:
1686         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1687
1688 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1689
1690         webkitpy: Kill unresponsive worker processes
1691         https://bugs.webkit.org/show_bug.cgi?id=197205
1692         <rdar://problem/50104388>
1693
1694         Reviewed by Lucas Forschler.
1695
1696         * Scripts/webkitpy/common/message_pool.py:
1697         (_MessagePool.__init__): Add close timeout.
1698         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1699
1700 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1701
1702         Add unit tests for WKWebView.serverTrust
1703         https://bugs.webkit.org/show_bug.cgi?id=197202
1704
1705         Reviewed by Youenn Fablet
1706
1707         * TestWebKitAPI/TCPServer.cpp:
1708         (TestWebKitAPI::deleter<BIO>::operator()):
1709         (TestWebKitAPI::deleter<SSL>::operator()):
1710         (TestWebKitAPI::deleter<X509>::operator()):
1711         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1712         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1713         (TestWebKitAPI::TCPServer::TCPServer):
1714         (TestWebKitAPI::TCPServer::listenForConnections):
1715         * TestWebKitAPI/TCPServer.h:
1716         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1717         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1718         (TestWebKitAPI::TEST):
1719         (verifyCertificateAndPublicKey):
1720         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1721         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1722         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1723         (TestWebKitAPI::downloadAtRate):
1724         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1725         (TEST):
1726         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1727         (TEST):
1728
1729 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1730
1731         Unreviewed, rolling out r244556.
1732         https://bugs.webkit.org/show_bug.cgi?id=197212
1733
1734         Causing build failures on multiple builders (Requested by
1735         ShawnRoberts on #webkit).
1736
1737         Reverted changeset:
1738
1739         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1740         https://bugs.webkit.org/show_bug.cgi?id=197171
1741         https://trac.webkit.org/changeset/244556
1742
1743 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1744
1745         Fix iOS build.
1746         https://bugs.webkit.org/show_bug.cgi?id=195537
1747
1748         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1749         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1750         AdoptWK constructor is private now.  Use adoptWK instead.
1751
1752 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
1753
1754         Accessibility text search and selection API enhancements.
1755         https://bugs.webkit.org/show_bug.cgi?id=197095
1756         <rdar://problem/48181791>
1757
1758         Reviewed by Chris Fleizach.
1759
1760         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
1761
1762         * DumpRenderTree/AccessibilityTextMarker.h:
1763         * DumpRenderTree/AccessibilityUIElement.cpp:
1764         (searchTextWithCriteriaCallback):
1765         (AccessibilityUIElement::getJSClass):
1766         * DumpRenderTree/AccessibilityUIElement.h:
1767         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1768         (convertVectorToObjectArray):
1769         (convertNSArrayToVector):
1770         (searchTextParameterizedAttributeForCriteria):
1771         (AccessibilityUIElement::getLinkedUIElements):
1772         (AccessibilityUIElement::getDocumentLinks):
1773         (AccessibilityUIElement::getChildren):
1774         (AccessibilityUIElement::getChildrenWithRange):
1775         (AccessibilityUIElement::rowHeaders const):
1776         (AccessibilityUIElement::columnHeaders const):
1777         (AccessibilityUIElement::uiElementArrayAttributeValue const):
1778         (AccessibilityUIElement::searchTextWithCriteria):
1779         (AccessibilityUIElement::attributesOfColumnHeaders):
1780         (AccessibilityUIElement::attributesOfRowHeaders):
1781         (AccessibilityUIElement::attributesOfColumns):
1782         (AccessibilityUIElement::attributesOfRows):
1783         (AccessibilityUIElement::attributesOfVisibleCells):
1784         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1785         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1786         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1787         (WTR::convertVectorToObjectArray):
1788         (WTR::convertNSArrayToVector):
1789         (WTR::searchTextParameterizedAttributeForCriteria):
1790         (WTR::AccessibilityUIElement::getLinkedUIElements):
1791         (WTR::AccessibilityUIElement::getDocumentLinks):
1792         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1793         (WTR::AccessibilityUIElement::getChildren):
1794         (WTR::AccessibilityUIElement::getChildrenWithRange):
1795         (WTR::AccessibilityUIElement::rowHeaders const):
1796         (WTR::AccessibilityUIElement::columnHeaders const):
1797         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1798         (WTR::AccessibilityUIElement::searchTextWithCriteria):
1799         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1800         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1801         (WTR::AccessibilityUIElement::attributesOfColumns):
1802         (WTR::AccessibilityUIElement::attributesOfRows):
1803         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1804         (WTR::convertElementsToObjectArray): Deleted.
1805
1806 2019-04-23  Guy Lewin  <guy@lewin.co.il>
1807
1808         Multiple File Input Icon Set Regardless of File List
1809         https://bugs.webkit.org/show_bug.cgi?id=195537
1810
1811         Reviewed by Alexey Proskuryakov.
1812
1813         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
1814         display string in iOS file inputs
1815
1816         * DumpRenderTree/TestRunner.cpp:
1817         (SetOpenPanelFilesMediaIconCallback):
1818         (TestRunner::staticFunctions):
1819         (TestRunner::setOpenPanelFilesMediaIcon):
1820         * DumpRenderTree/TestRunner.h:
1821         (TestRunner::openPanelFilesMediaIcon const):
1822         * DumpRenderTree/mac/UIDelegate.mm:
1823         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1824         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1825         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1826         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1827         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1828         * WebKitTestRunner/TestController.cpp:
1829         (WTR::runOpenPanel):
1830         (WTR::TestController::resetStateToConsistentValues):
1831         * WebKitTestRunner/TestController.h:
1832         (WTR::TestController::openPanelFileURLsMediaIcon const):
1833         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
1834         * WebKitTestRunner/TestInvocation.cpp:
1835         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1836
1837 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
1838
1839         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1840         https://bugs.webkit.org/show_bug.cgi?id=197171
1841         <rdar://problem/47454979>
1842
1843         Reviewed by Youenn Fablet.
1844
1845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1846         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1847         (TestWebKitAPI::TEST):
1848
1849 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1850
1851         [ews-build] Add unit tests for UnApplyPatchIfRequired
1852         https://bugs.webkit.org/show_bug.cgi?id=197197
1853
1854         Reviewed by Lucas Forschler.
1855
1856         * BuildSlaveSupport/ews-build/steps_unittest.py:
1857         (TestUnApplyPatchIfRequired):
1858         (TestUnApplyPatchIfRequired.test_success):
1859         (TestUnApplyPatchIfRequired.test_failure):
1860         (TestUnApplyPatchIfRequired.test_skip):
1861
1862 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1863
1864         [ews-build] Add unit tests for CleanWorkingDirectory
1865         https://bugs.webkit.org/show_bug.cgi?id=197195
1866
1867         Reviewed by Lucas Forschler.
1868
1869         * BuildSlaveSupport/ews-build/steps_unittest.py:
1870         (TestCleanWorkingDirectory):
1871         (TestCleanWorkingDirectory.test_success):
1872         (TestCleanWorkingDirectory.test_failure):
1873
1874 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1875
1876         [ews-build] Use explicit imports instead of wildcard imports
1877         https://bugs.webkit.org/show_bug.cgi?id=197194
1878
1879         Reviewed by Lucas Forschler.
1880
1881         * BuildSlaveSupport/ews-build/factories.py:
1882         * BuildSlaveSupport/ews-build/loadConfig.py:
1883         * BuildSlaveSupport/ews-build/steps_unittest.py:
1884
1885 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1886
1887         [ews-build] Add unit tests for DownloadBuiltProduct
1888         https://bugs.webkit.org/show_bug.cgi?id=197193
1889
1890         Reviewed by Lucas Forschler.
1891
1892         * BuildSlaveSupport/ews-build/steps_unittest.py:
1893         (TestDownloadBuiltProduct):
1894         (TestDownloadBuiltProduct.setUp):
1895         (TestDownloadBuiltProduct.tearDown):
1896         (TestDownloadBuiltProduct.test_success):
1897         (TestDownloadBuiltProduct.test_failure):
1898
1899 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1900
1901         [ews-app] Exception while loading status-bubble when no build step has started
1902         https://bugs.webkit.org/show_bug.cgi?id=196676
1903
1904         Reviewed by Lucas Forschler.
1905
1906         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1907         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1908
1909 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1910
1911         [PlayStation] Support running of JSC tests on remote playstation devices
1912         https://bugs.webkit.org/show_bug.cgi?id=197170
1913
1914         Reviewed by Ross Kirsling.
1915
1916         Script changes
1917
1918         * Scripts/run-javascriptcore-tests:
1919         (runJSCStressTests): Pass arguments for playstation to
1920         run-jsc-stress-tests
1921         * Scripts/run-jsc-stress-tests:
1922         Handle $hostOS=="playstation" for determineArchitecture, turning
1923         off $isFTLPlatform and runProfiler and defaulting test writer.
1924         * Scripts/webkitdirs.pm:
1925         (jscPath): PlayStation WebKit executables have .elf extension
1926         (executableProductDir): PlayStation builds on Windows hosts but
1927         uses bin directory rather than bin64/bin32 for executable output
1928         location.
1929         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1930
1931 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1932
1933         [CMake][Win] Use target oriented design for WebKit
1934         https://bugs.webkit.org/show_bug.cgi?id=197173
1935
1936         Reviewed by Alex Christensen.
1937
1938         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1939         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1940
1941 2019-04-23  Chris Dumez  <cdumez@apple.com>
1942
1943         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1944         https://bugs.webkit.org/show_bug.cgi?id=197097
1945         <rdar://problem/50048318>
1946
1947         Reviewed by Alex Christensen.
1948
1949         Add API test coverage.
1950
1951         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1952         (-[PSONScheme webView:startURLSchemeTask:]):
1953
1954 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1955
1956         [ATK] Implement AtkComponentIface scroll_to methods
1957         https://bugs.webkit.org/show_bug.cgi?id=196856
1958
1959         Reviewed by Michael Catanzaro.
1960
1961         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1962         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1963         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1964         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1965
1966 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1967
1968         [ews-build] Improve summary for UploadBuiltProduct step
1969         https://bugs.webkit.org/show_bug.cgi?id=197182
1970
1971         Reviewed by Lucas Forschler.
1972
1973         * BuildSlaveSupport/ews-build/steps.py:
1974         (UploadBuiltProduct): Added descriptionDone.
1975         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1976         * BuildSlaveSupport/ews-build/steps_unittest.py:
1977         (TestUploadBuiltProduct.test_success): Updated unit-test.
1978         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1979
1980 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1981
1982         [ews-build] Trigger queues only after uploading the archive
1983         https://bugs.webkit.org/show_bug.cgi?id=197180
1984
1985         Reviewed by Lucas Forschler.
1986
1987         * BuildSlaveSupport/ews-build/factories.py:
1988         (Factory.__init__):
1989         (BuildFactory.__init__): Remove trigger step from factories.
1990         (BuildFactory.propertiesToPassToTriggers): Deleted.
1991         * BuildSlaveSupport/ews-build/steps.py:
1992         (ConfigureBuild.__init__): Confiure triggers property.
1993         (Trigger): Step to trigger other queues.
1994         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1995         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1996
1997 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1998
1999         Deprecate WKContextCreateWithInjectedBundlePath
2000         https://bugs.webkit.org/show_bug.cgi?id=197169
2001
2002         Reviewed by Youenn Fablet.
2003
2004         * TestWebKitAPI/PlatformUtilities.cpp:
2005         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2006         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
2007
2008 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2009
2010         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
2011         https://bugs.webkit.org/show_bug.cgi?id=197093
2012         <rdar://problem/49708268>
2013
2014         Reviewed by Chris Dumez.
2015
2016         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
2017         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
2018         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
2019         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
2020         and one for loads without credentials, so there are two TCP connections to the same server in this test.
2021
2022         * TestWebKitAPI/TCPServer.cpp:
2023         (TestWebKitAPI::TCPServer::TCPServer):
2024         (TestWebKitAPI::TCPServer::~TCPServer):
2025         (TestWebKitAPI::TCPServer::socketBindListen):
2026         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
2027         * TestWebKitAPI/TCPServer.h:
2028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2029         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
2030         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2031         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2032         (respondWithChallengeThenOK):
2033         (TestWebKitAPI::TEST):
2034         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
2035         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2036         (TEST):
2037
2038 2019-04-22  Chris Dumez  <cdumez@apple.com>
2039
2040         Delayed WebProcessLaunch may break the _relatedWebView SPI
2041         https://bugs.webkit.org/show_bug.cgi?id=197160
2042
2043         Reviewed by Alex Christensen.
2044
2045         Add API test coverage.
2046
2047         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2048
2049 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
2050
2051         Use curl to download packages for webkitpy autoinstaller
2052         https://bugs.webkit.org/show_bug.cgi?id=197164
2053
2054         Reviewed by Darin Adler.
2055
2056         * Scripts/webkitpy/common/system/autoinstall.py:
2057         (AutoInstaller._download): Use curl(1) to download packages necessary for
2058         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
2059         errors which are not present when using curl(1).
2060
2061 2019-04-22  Chris Dumez  <cdumez@apple.com>
2062
2063         Unreviewed, rolling out r244502.
2064
2065         Caused crashes on the bots
2066
2067         Reverted changeset:
2068
2069         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
2070         https://bugs.webkit.org/show_bug.cgi?id=197160
2071         https://trac.webkit.org/changeset/244502
2072
2073 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
2074
2075         Unreviewed, rolling out r244437.
2076
2077         Still breaks internal tests.
2078
2079         Reverted changeset:
2080
2081         "InjectedBundle parameters often need initialization function
2082         called before unarchiving"
2083         https://bugs.webkit.org/show_bug.cgi?id=189709
2084         https://trac.webkit.org/changeset/244437
2085
2086 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2087
2088         [ews-build] Use singular verb in failure description in case of single api test failure
2089         https://bugs.webkit.org/show_bug.cgi?id=197013
2090
2091         Reviewed by Lucas Forschler.
2092
2093         * BuildSlaveSupport/ews-build/steps.py:
2094         (AnalyzeAPITestsResults.analyzeResults):
2095
2096 2019-04-22  Chris Dumez  <cdumez@apple.com>
2097
2098         Delayed WebProcessLaunch may break the _relatedWebView SPI
2099         https://bugs.webkit.org/show_bug.cgi?id=197160
2100
2101         Reviewed by Alex Christensen.
2102
2103         Add API test coverage.
2104
2105         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2106
2107 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2108
2109         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
2110         https://bugs.webkit.org/show_bug.cgi?id=194630
2111
2112         Reviewed by Michael Catanzaro.
2113
2114         Return early from getAttributeSet() is passed in accessible is nullptr.
2115
2116         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2117
2118 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2119
2120         Defer EditorState updates until the next layer tree flush in a few additional circumstances
2121         https://bugs.webkit.org/show_bug.cgi?id=197145
2122         <rdar://problem/50078170>
2123
2124         Reviewed by Darin Adler.
2125
2126         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
2127         focus, or showing the font manager.
2128
2129         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2130         (TestWebKitAPI::TEST):
2131         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2132         (TEST):
2133         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2134         (TestWebKitAPI::TEST):
2135
2136 2019-04-21  Brian Burg  <bburg@apple.com>
2137
2138         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
2139         https://bugs.webkit.org/show_bug.cgi?id=197125
2140         <rdar://problem/50061468>
2141
2142         Reviewed by Darin Adler.
2143
2144         Sometimes I want to run wptserve independently of tests. Make it easier to script that
2145         using this class rather than making our own ./wpt serve invocation.
2146
2147         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2148         (WebDriverW3CWebServer):
2149         (WebDriverW3CWebServer.document_root): Expose this to clients.
2150         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
2151
2152         (WebDriverW3CWebServer.__enter__):
2153         (WebDriverW3CWebServer.__exit__):
2154         Make it possible to use the web server with a 'with' statement.
2155
2156 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
2157
2158         [CMake][Win] Use target oriented design for WebKitLegacy
2159         https://bugs.webkit.org/show_bug.cgi?id=197112
2160
2161         Reviewed by Konstantin Tokarev.
2162
2163         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
2164
2165         * DumpRenderTree/CMakeLists.txt:
2166         * DumpRenderTree/PlatformWin.cmake:
2167         * DumpRenderTree/win/EventSender.cpp:
2168
2169 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2170
2171         Update text for old EWS submit button
2172         https://bugs.webkit.org/show_bug.cgi?id=197140
2173
2174         Reviewed by Alexey Proskuryakov.
2175
2176         * QueueStatusServer/templates/statusbubble.html:
2177
2178 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2179
2180         [ews-app] New EWS should poll bugzilla more frequently
2181         https://bugs.webkit.org/show_bug.cgi?id=197138
2182
2183         Reviewed by Alexey Proskuryakov.
2184
2185         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2186         (FetchLoop.__init__):
2187
2188 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2189
2190         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
2191         https://bugs.webkit.org/show_bug.cgi?id=197139
2192
2193         Reviewed by Alexey Proskuryakov.
2194
2195         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2196         * QueueStatusServer/templates/statusbubble.html:
2197
2198 2019-04-20  Chris Dumez  <cdumez@apple.com>
2199
2200         Unreviewed, fix iOS build with recent SDKs.
2201
2202         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2203
2204 2019-04-19  Keith Miller  <keith_miller@apple.com>
2205
2206         Add script to merge run_benchmark jsons
2207         https://bugs.webkit.org/show_bug.cgi?id=197107
2208
2209         Reviewed by Michael Saboff.
2210
2211         The script basically recursively decends through all json objects until it gets
2212         to an array or JSON primitive and concats or takes the first value, respectively.
2213
2214         This patch also adds +x bits to the compare-results script so it
2215         can be run directly from the command line. I had to add a new line so that svn
2216         will accept the change... yay svn!
2217
2218         * Scripts/compare-results:
2219         * Scripts/merge-result-jsons: Added.
2220         (readJSONFile):
2221         (deepAppend):
2222         (mergeJSONs):
2223         (main):
2224
2225 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
2226
2227         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
2228         https://bugs.webkit.org/show_bug.cgi?id=197079
2229
2230         Reviewed by Darin Adler.
2231
2232         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
2233
2234         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2235         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
2236
2237 2019-04-18  Commit Queue  <commit-queue@webkit.org>
2238
2239         Unreviewed, rolling out r244434.
2240         https://bugs.webkit.org/show_bug.cgi?id=197089
2241
2242         caused 1 API test failure (Requested by zalan on #webkit).
2243
2244         Reverted changeset:
2245
2246         "Regression (r244291): Broken API Test
2247         AutoLayoutRenderingProgressRelativeOrdering"
2248         https://bugs.webkit.org/show_bug.cgi?id=196948
2249         https://trac.webkit.org/changeset/244434
2250
2251 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2252
2253         Add new compatibility mode API on WKNavigation
2254         https://bugs.webkit.org/show_bug.cgi?id=197069
2255         <rdar://problem/50025800>
2256
2257         Reviewed by Tim Horton.
2258
2259         Add a block property for -didCommitNavigation to TestNavigationDelegate.
2260
2261         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2262         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2263         (-[TestNavigationDelegate webView:didCommitNavigation:]):
2264
2265 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
2266
2267         [CMake] Make WebCore headers copies
2268         https://bugs.webkit.org/show_bug.cgi?id=182512
2269         <rdar://problem/37510435>
2270
2271         Reviewed by Alex Christensen.
2272
2273         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
2274         ports.
2275
2276         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
2277         of WebCore headers using "*.h" were modified to <WebCore/*.h>
2278
2279         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2280         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
2281         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
2282         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
2283         * TestWebKitAPI/CMakeLists.txt:
2284         * TestWebKitAPI/PlatformWin.cmake:
2285         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2286         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
2287         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2288
2289 2019-04-18  Jer Noble  <jer.noble@apple.com>
2290
2291         Add support for parsing FairPlayStreaming PSSH boxes.
2292         https://bugs.webkit.org/show_bug.cgi?id=197064
2293
2294         Reviewed by Eric Carlson.
2295
2296         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2297         (TestWebKitAPI::TEST):
2298
2299 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
2300
2301         InjectedBundle parameters often need initialization function called before unarchiving
2302         https://bugs.webkit.org/show_bug.cgi?id=189709
2303         <rdar://problem/44573653>
2304
2305         Reviewed by Ryosuke Niwa.
2306
2307         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2308         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2309
2310 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2311
2312         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2313         https://bugs.webkit.org/show_bug.cgi?id=196948
2314         <rdar://problem/49927131>
2315
2316         Reviewed by Tim Horton.
2317
2318         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2319         (TEST): 
2320         The expected order of incoming events is
2321         1. didInvalidateIntrinsicContentSize
2322         2. didFirstLayout
2323         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2324         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2325         (and remember, all we care about is ordering).
2326
2327 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
2328
2329         Unreviewed, rolling out r244299.
2330
2331         Breaks internal tests.
2332
2333         Reverted changeset:
2334
2335         "InjectedBundle parameters often need initialization function
2336         called before unarchiving"
2337         https://bugs.webkit.org/show_bug.cgi?id=189709
2338         https://trac.webkit.org/changeset/244299
2339
2340 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2341
2342         [WTF] StringBuilder should set correct m_is8Bit flag when merging
2343         https://bugs.webkit.org/show_bug.cgi?id=197053
2344
2345         Reviewed by Saam Barati.
2346
2347         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2348         (TestWebKitAPI::TEST):
2349
2350 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2351
2352         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
2353         https://bugs.webkit.org/show_bug.cgi?id=197028
2354         <rdar://problem/49985290>
2355
2356         Reviewed by Wenson Hsieh.
2357
2358         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2359         (TEST):
2360         Liberal application of waitForNextPresentationUpdate works around a race
2361         where if the page rapidly changes its viewport arguments (or an API client
2362         rapidly changes its viewport arguments), we'd get stuck thinking that the
2363         user had intentionally zoomed the page, and stop resetting the initial scale.
2364         This deserves a separate bug, but no need to keep the test failing while
2365         we think about it.
2366
2367 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2368
2369         REGRESSION (r241988): Switching tabs is slow
2370         https://bugs.webkit.org/show_bug.cgi?id=197037
2371         <rdar://problem/49951473>
2372
2373         Reviewed by Simon Fraser.
2374
2375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2376         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
2377         (TEST):
2378         * TestWebKitAPI/cocoa/TestWKWebView.h:
2379         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2380         (-[TestWKWebView addToTestWindow]):
2381         Add a test that hangs without this fix.
2382
2383 2019-04-17  Truitt Savell  <tsavell@apple.com>
2384
2385         Unreviewed, rolling out r244400.
2386
2387         Caused testing to exit early with assertionon Debug WK2
2388
2389         Reverted changeset:
2390
2391         "UI↔Web deadlock when printing with a JavaScript alert
2392         visible"
2393         https://bugs.webkit.org/show_bug.cgi?id=196839
2394         https://trac.webkit.org/changeset/244400
2395
2396 2019-04-17  Brady Eidson  <beidson@apple.com>
2397
2398         Link clicks in PDFs shouldn't send referrer headers.
2399         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
2400
2401         Reviewed by Tim Horton.
2402
2403         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2404         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
2405         (putPDFBytesCallback):
2406         (emptyReleaseInfoCallback):
2407         (createPDFWithLinkToURL):
2408         (TEST):
2409
2410 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2411
2412         UI↔Web deadlock when printing with a JavaScript alert visible
2413         https://bugs.webkit.org/show_bug.cgi?id=196839
2414         <rdar://problem/49157642>
2415
2416         Reviewed by Andy Estes.
2417
2418         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2419         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
2420         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2421         (TEST):
2422
2423 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2424
2425         WKRetainPtr's adoption constructor should be private
2426         https://bugs.webkit.org/show_bug.cgi?id=197019
2427
2428         Reviewed by Tim Horton.
2429
2430         * DumpRenderTree/mac/DumpRenderTree.mm:
2431         (dumpFramesAsText):
2432         * TestWebKitAPI/InjectedBundleController.cpp:
2433         (TestWebKitAPI::InjectedBundleController::initialize):
2434         * TestWebKitAPI/PlatformUtilities.cpp:
2435         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2436         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
2437         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2438         (TestWebKitAPI::Util::toWK):
2439         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2440         (TestWebKitAPI::TEST):
2441         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2442         (TestWebKitAPI::TEST):
2443         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2444         (TestWebKitAPI::TEST):
2445         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2446         (TestWebKitAPI::TEST):
2447         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2448         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2449         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
2450         (TestWebKitAPI::TEST):
2451         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
2452         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2453         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2454         (TestWebKitAPI::TEST):
2455         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
2456         (TestWebKitAPI::TEST):
2457         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2458         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2459         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
2460         (TestWebKitAPI::TEST):
2461         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2462         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2463         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2464         (TestWebKitAPI::TEST):
2465         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2466         (TestWebKitAPI::TEST):
2467         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2468         (TestWebKitAPI::TEST):
2469         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2470         (TestWebKitAPI::TEST):
2471         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2472         (TestWebKitAPI::TEST):
2473         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2474         (TestWebKitAPI::TEST):
2475         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2476         (TestWebKitAPI::TEST):
2477         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
2478         (TestWebKitAPI::TEST):
2479         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2480         (TestWebKitAPI::TEST):
2481         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2482         (TestWebKitAPI::TEST):
2483         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2484         (TestWebKitAPI::TEST):
2485         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2486         (TestWebKitAPI::TEST):
2487         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2488         (TestWebKitAPI::TEST):
2489         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
2490         (TestWebKitAPI::TEST):
2491         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
2492         (TestWebKitAPI::TEST):
2493         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
2494         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2495         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
2496         (TestWebKitAPI::TEST):
2497         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
2498         (TestWebKitAPI::TEST):
2499         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
2500         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
2501         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
2502         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
2503         (TestWebKitAPI::TEST):
2504         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
2505         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
2506         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
2507         (TestWebKitAPI::TEST):
2508         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
2509         (TestWebKitAPI::TEST):
2510         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2511         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2512         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2513         (TestWebKitAPI::TEST):
2514         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2515         (TestWebKitAPI::loadAlternateHTMLString):
2516         (TestWebKitAPI::TEST):
2517         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
2518         (TestWebKitAPI::TEST):
2519         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2520         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2521         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2522         (TestWebKitAPI::buildAndPerformTest):
2523         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2524         (TestWebKitAPI::TEST):
2525         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
2526         (TestWebKitAPI::TEST):
2527         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
2528         (TestWebKitAPI::TEST):
2529         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2530         (TestWebKitAPI::TEST):
2531         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2532         (TestWebKitAPI::TEST):
2533         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2534         (TestWebKitAPI::TEST):
2535         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2536         (TestWebKitAPI::TEST):
2537         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2538         (TestWebKitAPI::TEST):
2539         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
2540         (TestWebKitAPI::TEST):
2541         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2542         (TestWebKitAPI::TEST):
2543         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2544         (TestWebKitAPI::TEST):
2545         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2546         (TestWebKitAPI::TEST):
2547         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2548         (TestWebKitAPI::TEST):
2549         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2550         (TestWebKitAPI::TEST):
2551         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2552         (TestWebKitAPI::TEST):
2553         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2554         (TestWebKitAPI::TEST):
2555         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2556         (TestWebKitAPI::TEST):
2557         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2558         (TestWebKitAPI::TEST):
2559         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2560         (TestWebKitAPI::TEST):
2561         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2562         (TestWebKitAPI::TEST):
2563         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
2564         (TestWebKitAPI::TEST):
2565         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
2566         (TestWebKitAPI::TEST):
2567         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2568         (TestWebKitAPI::TEST):
2569         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2570         (TestWebKitAPI::TEST):
2571         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2572         (TestWebKitAPI::TEST):
2573         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2574         (TestWebKitAPI::TEST):
2575         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2576         (TestWebKitAPI::TEST):
2577         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2578         (TestWebKitAPI::TEST):
2579         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2580         (TestWebKitAPI::TEST):
2581         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2582         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2583         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
2584         (TestWebKitAPI::TEST):
2585         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2586         (TestWebKitAPI::TEST):
2587         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
2588         (TestWebKitAPI::TEST):
2589         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
2590         (TestWebKitAPI::TEST):
2591         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2592         (TestWebKitAPI::TEST):
2593         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2594         (TestWebKitAPI::TEST):
2595         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
2596         (TestWebKitAPI::TEST):
2597         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2598         (TestWebKitAPI::TEST):
2599         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2600         (TestWebKitAPI::TEST):
2601         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2602         (TestWebKitAPI::TEST):
2603         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2604         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
2605         (TEST):
2606         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2607         (TEST):
2608         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2609         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2610         (TEST):
2611         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
2612         (TestWebKitAPI::TEST):
2613         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2614         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2615         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2616         (WTR::getMenuItemTitleCallback):
2617         (WTR::createMouseMessageBody):
2618         (WTR::EventSendingController::mouseDown):
2619         (WTR::EventSendingController::mouseUp):
2620         (WTR::EventSendingController::mouseMoveTo):
2621         (WTR::EventSendingController::mouseForceClick):
2622         (WTR::EventSendingController::startAndCancelMouseForceClick):
2623         (WTR::EventSendingController::mouseForceDown):
2624         (WTR::EventSendingController::mouseForceUp):
2625         (WTR::EventSendingController::mouseForceChanged):
2626         (WTR::EventSendingController::leapForward):
2627         (WTR::EventSendingController::scheduleAsynchronousClick):
2628         (WTR::createKeyDownMessageBody):
2629         (WTR::EventSendingController::keyDown):
2630         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2631         (WTR::EventSendingController::mouseScrollBy):
2632         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2633         (WTR::EventSendingController::continuousMouseScrollBy):
2634         (WTR::EventSendingController::addTouchPoint):
2635         (WTR::EventSendingController::updateTouchPoint):
2636         (WTR::EventSendingController::setTouchModifier):
2637         (WTR::EventSendingController::setTouchPointRadius):
2638         (WTR::EventSendingController::touchStart):
2639         (WTR::EventSendingController::touchMove):
2640         (WTR::EventSendingController::touchEnd):
2641         (WTR::EventSendingController::touchCancel):
2642         (WTR::EventSendingController::clearTouchPoints):
2643         (WTR::EventSendingController::releaseTouchPoint):
2644         (WTR::EventSendingController::cancelTouchPoint):
2645         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2646         (WTR::InjectedBundle::didCreatePage):
2647         (WTR::InjectedBundle::didReceiveMessage):
2648         (WTR::InjectedBundle::didReceiveMessageToPage):
2649         (WTR::InjectedBundle::booleanForKey):
2650         (WTR::InjectedBundle::done):
2651         (WTR::InjectedBundle::dumpToStdErr):
2652         (WTR::InjectedBundle::outputText):
2653         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2654         (WTR::InjectedBundle::postAddChromeInputField):
2655         (WTR::InjectedBundle::postRemoveChromeInputField):
2656         (WTR::InjectedBundle::postFocusWebView):
2657         (WTR::InjectedBundle::postSetBackingScaleFactor):
2658         (WTR::InjectedBundle::postSetWindowIsKey):
2659         (WTR::InjectedBundle::postSetViewSize):
2660         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2661         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2662         (WTR::InjectedBundle::setGeolocationPermission):
2663         (WTR::InjectedBundle::setMockGeolocationPosition):
2664         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2665         (WTR::InjectedBundle::isGeolocationProviderActive const):
2666         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2667         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2668         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2669         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2670         (WTR::InjectedBundle::setCustomPolicyDelegate):
2671         (WTR::InjectedBundle::setHidden):
2672         (WTR::InjectedBundle::setCacheModel):
2673         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2674         (WTR::InjectedBundle::processWorkQueue):
2675         (WTR::InjectedBundle::queueBackNavigation):
2676         (WTR::InjectedBundle::queueForwardNavigation):
2677         (WTR::InjectedBundle::queueLoad):
2678         (WTR::InjectedBundle::queueLoadHTMLString):
2679         (WTR::InjectedBundle::queueReload):
2680         (WTR::InjectedBundle::queueLoadingScript):
2681         (WTR::InjectedBundle::queueNonLoadingScript):
2682         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2683         (WTR::frameToStr):
2684         (WTR::InjectedBundlePage::InjectedBundlePage):
2685         (WTR::dumpFrameDescriptionSuitableForTestResult):
2686         (WTR::dumpFrameScrollPosition):
2687         (WTR::dumpDescendantFrameScrollPositions):
2688         (WTR::dumpFrameText):
2689         (WTR::dumpDescendantFramesText):
2690         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2691         (WTR::TestRunner::shouldDumpPixels const):
2692         (WTR::TestRunner::setDumpPixels):
2693         (WTR::TestRunner::whatToDump const):
2694         (WTR::TestRunner::setWhatToDump):
2695         (WTR::TestRunner::setWaitUntilDone):
2696         (WTR::TestRunner::shouldWaitUntilDone const):
2697         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2698         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2699         (WTR::TestRunner::clearAllDatabases):
2700         (WTR::TestRunner::setIDBPerOriginQuota):
2701         (WTR::TestRunner::originsWithApplicationCache):
2702         (WTR::TestRunner::setCanOpenWindows):
2703         (WTR::TestRunner::setXSSAuditorEnabled):
2704         (WTR::TestRunner::setMediaDevicesEnabled):
2705         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2706         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2707         (WTR::TestRunner::setCustomUserAgent):
2708         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2709         (WTR::TestRunner::setModernMediaControlsEnabled):
2710         (WTR::TestRunner::setWebGL2Enabled):
2711         (WTR::TestRunner::setWritableStreamAPIEnabled):
2712         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2713         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2714         (WTR::TestRunner::setAllowsAnySSLCertificate):
2715         (WTR::TestRunner::setPluginsEnabled):
2716         (WTR::TestRunner::setValueForUser):
2717         (WTR::TestRunner::setAudioResult):
2718         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2719         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2720         (WTR::TestRunner::setAlwaysAcceptCookies):
2721         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2722         (WTR::TestRunner::isDoingMediaCapture const):
2723         (WTR::TestRunner::queueLoad):
2724         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2725         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2726         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2727         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2728         (WTR::TestRunner::setAuthenticationUsername):
2729         (WTR::TestRunner::setAuthenticationPassword):
2730         (WTR::TestRunner::secureEventInputIsEnabled const):
2731         (WTR::TestRunner::setBlockAllPlugins):
2732         (WTR::TestRunner::setPluginSupportedMode):
2733         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2734         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2735         (WTR::TestRunner::setNavigationGesturesEnabled):
2736         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2737         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2738         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2739         (WTR::TestRunner::terminateNetworkProcess):
2740         (WTR::TestRunner::terminateServiceWorkerProcess):
2741         (WTR::TestRunner::runUIScript):
2742         (WTR::TestRunner::setStatisticsDebugMode):
2743         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2744         (WTR::TestRunner::setStatisticsLastSeen):
2745         (WTR::TestRunner::setStatisticsPrevalentResource):
2746         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2747         (WTR::TestRunner::dumpResourceLoadStatistics):
2748         (WTR::TestRunner::isStatisticsPrevalentResource):
2749         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
2750         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
2751         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
2752         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
2753         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2754         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2755         (WTR::TestRunner::setStatisticsGrandfathered):
2756         (WTR::TestRunner::isStatisticsGrandfathered):
2757         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2758         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2759         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2760         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
2761         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
2762         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
2763         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2764         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
2765         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2766         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2767         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2768         (WTR::TestRunner::statisticsSubmitTelemetry):
2769         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2770         (WTR::TestRunner::setStatisticsIsRunningTest):
2771         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2772         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2773         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2774         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2775         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2776         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2777         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2778         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2779         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2780         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2781         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
2782         (WTR::TestRunner::statisticsResetToConsistentState):
2783         (WTR::TestRunner::setStorageAccessAPIEnabled):
2784         (WTR::TestRunner::getAllStorageAccessEntries):
2785         (WTR::TestRunner::addMockMediaDevice):
2786         (WTR::TestRunner::clearMockMediaDevices):
2787         (WTR::TestRunner::removeMockMediaDevice):
2788         (WTR::TestRunner::resetMockMediaDevices):
2789         (WTR::TestRunner::connectMockGamepad):
2790         (WTR::TestRunner::disconnectMockGamepad):
2791         (WTR::TestRunner::setMockGamepadDetails):
2792         (WTR::TestRunner::setMockGamepadAxisValue):
2793         (WTR::TestRunner::setMockGamepadButtonValue):
2794         (WTR::TestRunner::removeAllSessionCredentials):
2795         (WTR::TestRunner::clearDOMCache):
2796         (WTR::TestRunner::clearDOMCaches):
2797         (WTR::TestRunner::hasDOMCache):
2798         (WTR::TestRunner::domCacheSize):
2799         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2800         (WTR::TestRunner::getApplicationManifestThen):
2801         (WTR::TestRunner::injectUserScript):
2802         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
2803         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2804         (WTR::TestRunner::addTestKeyToKeychain):
2805         (WTR::TestRunner::cleanUpKeychain):
2806         (WTR::TestRunner::keyExistsInKeychain):
2807         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2808         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2809         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2810         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2811         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2812         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2813         * WebKitTestRunner/TestController.cpp:
2814         (WTR::TestController::initialize):
2815         (WTR::parseStringTestHeaderValueAsRelativePath):
2816         (WTR::updateTestOptionsFromTestHeader):
2817         (WTR::TestController::runTest):
2818         (WTR::TestController::didReceiveLiveDocumentsList):
2819         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2820         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2821         (WTR::TestController::didFinishNavigation):
2822         (WTR::TestController::didReceiveAuthenticationChallenge):
2823         * WebKitTestRunner/TestInvocation.cpp:
2824         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2825         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2826         (WTR::TestInvocation::uiScriptDidComplete):
2827         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
2828         * WebKitTestRunner/WebNotificationProvider.cpp:
2829         (WTR::WebNotificationProvider::closeWebNotification):
2830         * WebKitTestRunner/WorkQueueManager.cpp:
2831         (WTR::ScriptItem::ScriptItem):
2832         (WTR::WorkQueueManager::queueLoad):
2833         (WTR::WorkQueueManager::queueLoadHTMLString):
2834
2835 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2836
2837         Add a comment to make my test from r244139 less mysterious.
2838         https://bugs.webkit.org/show_bug.cgi?id=196744
2839
2840         As suggested by Darin Adler.
2841
2842         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2843         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2844
2845 2019-04-17  Chris Dumez  <cdumez@apple.com>
2846
2847         Remember device orientation permission for the duration of the browsing session
2848         https://bugs.webkit.org/show_bug.cgi?id=196992
2849         <rdar://problem/49946067>
2850
2851         Reviewed by Alex Christensen.
2852
2853         Add API test coverage.
2854
2855         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2856         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2857         (TEST):
2858
2859 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
2860
2861         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
2862         https://bugs.webkit.org/show_bug.cgi?id=196675
2863
2864         Reviewed by Lucas Forschler.
2865
2866         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2867         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
2868
2869 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2870
2871         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
2872         https://bugs.webkit.org/show_bug.cgi?id=196919
2873         <rdar://problem/41630459>
2874
2875         Reviewed by Tim Horton.
2876
2877         Add iOS support for several new testing hooks. See below for more detail.
2878
2879         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2880         (WTR::UIScriptController::isDismissingMenu const):
2881
2882         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
2883         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
2884         by UIKit when dismissing the callout bar (i.e. UIMenuController).
2885
2886         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2887         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2888         (WTR::UIScriptController::isDismissingMenu const):
2889         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2890         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2891         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2892         (WTR::InjectedBundle::didReceiveMessageToPage):
2893         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2894         (WTR::TestRunner::setAllowedMenuActions):
2895
2896         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2897         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2898         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2899         against the name of the custom action.
2900
2901         (WTR::TestRunner::installCustomMenuAction):
2902
2903         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2904         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2905         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2906         triggered.
2907
2908         (WTR::TestRunner::performCustomMenuAction):
2909
2910         Invoked when the custom menu action is triggered.
2911
2912         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2913         * WebKitTestRunner/TestController.cpp:
2914         (WTR::TestController::installCustomMenuAction):
2915         (WTR::TestController::setAllowedMenuActions):
2916         * WebKitTestRunner/TestController.h:
2917         * WebKitTestRunner/TestInvocation.cpp:
2918         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2919         (WTR::TestInvocation::performCustomMenuAction):
2920
2921         Add plumbing to call back into the injected bundle when performing the custom action.
2922
2923         * WebKitTestRunner/TestInvocation.h:
2924         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2925         (WTR::TestController::installCustomMenuAction):
2926         (WTR::TestController::setAllowedMenuActions):
2927         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2928         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2929         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2930         (-[TestRunnerWKWebView becomeFirstResponder]):
2931         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2932
2933         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2934         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2935         in the Mail app on iOS.
2936
2937         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2938         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2939         (-[TestRunnerWKWebView resetCustomMenuAction]):
2940         (-[TestRunnerWKWebView performCustomAction:]):
2941         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2942         (-[TestRunnerWKWebView _willHideMenu]):
2943         (-[TestRunnerWKWebView _didHideMenu]):
2944         * WebKitTestRunner/ios/TestControllerIOS.mm:
2945         (WTR::TestController::platformResetStateToConsistentValues):
2946
2947         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2948         if specified.
2949
2950         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2951         (WTR::UIScriptController::isDismissingMenu const):
2952
2953 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2954
2955         Allow sharing from imageSheet on an image document
2956         https://bugs.webkit.org/show_bug.cgi?id=196891
2957         <rdar://problem/25377386>
2958
2959         Reviewed by Tim Horton.
2960
2961         Test to make sure that the correct imageURL is extracted from an image element.
2962
2963         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2964         (TestWebKitAPI::TEST):
2965
2966 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2967
2968         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2969         https://bugs.webkit.org/show_bug.cgi?id=196995
2970
2971         Reviewed by Brady Eidson.
2972
2973         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2974         (TEST):
2975
2976 2019-04-16  Chris Dumez  <cdumez@apple.com>
2977
2978         URL set by document.open() is not communicated to the UIProcess
2979         https://bugs.webkit.org/show_bug.cgi?id=196941
2980         <rdar://problem/49237544>
2981
2982         Reviewed by Geoff Garen.
2983
2984         Add API test coverage.
2985
2986         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2987         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2988         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2989         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2990         (TEST):
2991
2992 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2993
2994         Unreviewed, rolling out r244321.
2995         https://bugs.webkit.org/show_bug.cgi?id=196968
2996
2997         Causing all WK2 Debug builds to exit early after Assertion
2998         failures. (Requested by ShawnRoberts on #webkit).
2999
3000         Reverted changeset:
3001
3002         "URL set by document.open() is not communicated to the
3003         UIProcess"
3004         https://bugs.webkit.org/show_bug.cgi?id=196941
3005         https://trac.webkit.org/changeset/244321
3006
3007 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3008
3009         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
3010         https://bugs.webkit.org/show_bug.cgi?id=196948
3011
3012         Reviewed by Zalan Bujtas.
3013
3014         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3015         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
3016
3017 2019-04-15  Chris Dumez  <cdumez@apple.com>
3018
3019         URL set by document.open() is not communicated to the UIProcess
3020         https://bugs.webkit.org/show_bug.cgi?id=196941
3021         <rdar://problem/49237544>
3022
3023         Reviewed by Geoffrey Garen.
3024
3025         Add API test coverage.
3026
3027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3028         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3029         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3030         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3031         (TEST):
3032
3033 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
3034
3035         Using Tools/Scripts/clean-webkit should not install requests
3036         https://bugs.webkit.org/show_bug.cgi?id=196940
3037
3038         Reviewed by Lucas Forschler.
3039
3040         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
3041         existing, depending on the path autoinstalled is run through.
3042         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
3043         needed.
3044         (Port.configuration_for_upload):
3045         (Port.commits_for_upload):
3046
3047 2019-04-15  Alex Christensen  <achristensen@webkit.org>
3048
3049         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
3050         https://bugs.webkit.org/show_bug.cgi?id=196773
3051
3052         Reviewed by Jer Noble.
3053
3054         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
3055         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
3056         (TEST):
3057
3058 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3059
3060         ews-build should clearly indicate flaky test failures
3061         https://bugs.webkit.org/show_bug.cgi?id=196947
3062
3063         Reviewed by Lucas Forschler.
3064
3065         * BuildSlaveSupport/ews-build/steps.py:
3066         (AnalyzeAPITestsResults.analyzeResults):
3067
3068 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
3069
3070         InjectedBundle parameters often need initialization function called before unarchiving
3071         https://bugs.webkit.org/show_bug.cgi?id=189709
3072         <rdar://problem/44573653>
3073
3074         Reviewed by Ryosuke Niwa.
3075
3076         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
3077         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
3078
3079 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
3080
3081         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
3082         https://bugs.webkit.org/show_bug.cgi?id=196681
3083
3084         Reviewed by Darin Adler.
3085
3086         Added tests.
3087
3088         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3089         (WTF_HashSet.RemoveIf):
3090         (WTF_HashSet.RemoveIfShrinkToBestSize):
3091
3092 2019-04-15  John Wilander  <wilander@apple.com>
3093
3094         Send delayed Ad Click Attribution conversion requests to the click source
3095         https://bugs.webkit.org/show_bug.cgi?id=196838
3096         <rdar://problem/47650157>
3097
3098         Reviewed by Chris Dumez and Youenn Fablet.
3099
3100         This patch adds test infrastructure to override the default behavior in
3101         WebKit::NetworkAdClickAttribution.
3102
3103         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3104         (TestWebKitAPI::TEST):
3105         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3106         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3107         (WTR::TestRunner::dumpAdClickAttribution):
3108         (WTR::TestRunner::clearAdClickAttribution):
3109         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3110         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3111         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3112         * WebKitTestRunner/TestController.cpp:
3113         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
3114         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
3115         * WebKitTestRunner/TestController.h:
3116         * WebKitTestRunner/TestInvocation.cpp:
3117         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3118
3119 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3120
3121         [ews-app] status-bubble should display position in queue
3122         https://bugs.webkit.org/show_bug.cgi?id=196607
3123
3124         Reviewed by Lucas Forschler.
3125
3126         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3127         (StatusBubble._build_bubble):
3128         (StatusBubble._queue_position): Method to calculate patch's position in queue.
3129
3130 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3131
3132         [ews-build] Do not run clean build by default on EWS builders
3133         https://bugs.webkit.org/show_bug.cgi?id=196897
3134
3135         Reviewed by Lucas Forschler.
3136
3137         * BuildSlaveSupport/ews-build/steps.py:
3138         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
3139         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
3140         untracked directories like WebKitBuild).
3141         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
3142         untracked files/directories (like WebKitBuild).
3143
3144 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
3145
3146         TestRunner::notifyDone() should be safely reentrant
3147         https://bugs.webkit.org/show_bug.cgi?id=196898
3148
3149         Reviewed by Darin Adler.
3150
3151         It is currently possible that TestRunner::notifyDone() will call itself, since
3152         notifyDone() will force a repaint, which can start executing JavaScript, which
3153         may call notifyDone() again. This can lead to test failures and flakiness.
3154         Fix this by setting the m_waitToDump flag before calling the dump() method.
3155
3156         * DumpRenderTree/mac/TestRunnerMac.mm:
3157         (TestRunner::notifyDone):
3158         (TestRunner::forceImmediateCompletion):
3159         * DumpRenderTree/win/TestRunnerWin.cpp:
3160         (TestRunner::notifyDone):
3161         (TestRunner::forceImmediateCompletion):
3162
3163 2019-04-15  Philippe Normand  <pnormand@igalia.com>
3164
3165         [GTK][WPE] Add enable-media websetting
3166         https://bugs.webkit.org/show_bug.cgi?id=196863
3167
3168         Reviewed by Michael Catanzaro.
3169
3170         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3171         (testWebKitSettings): Add test for the enable-media web-setting.
3172
3173 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3174
3175         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
3176         https://bugs.webkit.org/show_bug.cgi?id=196905
3177         <rdar://problem/49886096>
3178
3179         Reviewed by Tim Horton.
3180
3181         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
3182         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
3183         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
3184         delay timer, we end up with this sequence of events in the problematic (failure) case:
3185
3186         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
3187             ...IPC from UI to web process...
3188         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
3189             ...IPC from web to UI process...
3190         (c) [UI]    Invoke completion handler for script #1
3191         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
3192             ...IPC from UI to web process...
3193         (e) [Web]   Evaluate script #2 in the web process
3194         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
3195
3196         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
3197         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
3198         #2 is run in step (e).
3199
3200         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
3201         the UI process by waiting on a script message posted by the web process, after attachment updates are
3202         dispatched.
3203
3204         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3205         (TestWebKitAPI::TEST):
3206
3207 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
3208
3209         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
3210         https://bugs.webkit.org/show_bug.cgi?id=196909
3211
3212         Reviewed by Wenson Hsieh.
3213
3214         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3215         (TestWebKitAPI::TEST):
3216
3217 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
3218
3219         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
3220         https://bugs.webkit.org/show_bug.cgi?id=196880
3221
3222         Reviewed by Yusuke Suzuki.
3223
3224         Add a new function for bytecode cache tests that does not forceDiskCache
3225         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
3226         test added in this patch, since the code is invalid and therefore won't be
3227         cached. It should also be useful for tests that evaluate dynamically
3228         generated code.
3229
3230         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3231         * Scripts/run-jsc-stress-tests:
3232
3233 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
3234
3235         Update AudioSession route sharing policy
3236         https://bugs.webkit.org/show_bug.cgi?id=196776
3237         <rdar://problem/46501611>
3238
3239         Reviewed by Jer Noble.
3240
3241         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3242         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
3243         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
3244         (TestWebKitAPI::TEST):
3245
3246 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3247
3248         [iOS] Software keyboard is shown too frequently on some websites
3249         https://bugs.webkit.org/show_bug.cgi?id=195856
3250         <rdar://problem/49191395>
3251
3252         Reviewed by Darin Adler.
3253
3254         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
3255
3256         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3257         (WTR::UIScriptController::setHardwareKeyboardAttached):
3258         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3259         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3260         (WTR::UIScriptController::setHardwareKeyboardAttached):
3261         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3262         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3263
3264         Additionally link against GraphicsServices in WebKitTestRunner.
3265
3266         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3267         (WTR::TestController::platformResetStateToConsistentValues):
3268         (WTR::UIScriptController::setHardwareKeyboardAttached):
3269
3270 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
3271
3272         [GTK][WPE] Fix pacman install-dependencies packages
3273         https://bugs.webkit.org/show_bug.cgi?id=196817
3274
3275         Reviewed by Žan Doberšek.
3276         
3277         python3-setuptools is called python-setuptools
3278         ruby-highline is only available on AUR
3279         libv4l-devel is incorporated in v4l-utils
3280
3281         * gtk/install-dependencies:
3282         * wpe/install-dependencies:
3283
3284 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3285
3286         [GTK] REGRESSION(r243860): Many tests failing
3287         https://bugs.webkit.org/show_bug.cgi?id=196791
3288
3289         Reviewed by Joanmarie Diggs.
3290
3291         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
3292         multiple documents and check that accessibility hierarchy is updated after a navigation.
3293
3294         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
3295         (loadChangedCallback):
3296         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3297         (AccessibilityTest::AccessibilityTest):
3298         (AccessibilityTest::~AccessibilityTest):
3299         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
3300         (AccessibilityTest::findTestServerApplication):
3301         (AccessibilityTest::findDocumentWeb):
3302         (AccessibilityTest::findRootObject):
3303         (AccessibilityTest::waitUntilChildrenRemoved):
3304         (AccessibilityTest::ensureProxy):
3305         (testAtspiBasicHierarchy):
3306         (beforeAll):
3307         (afterAll):
3308
3309 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
3310
3311         [ews-build] Handle bug titles with unicode characters
3312         https://bugs.webkit.org/show_bug.cgi?id=196802
3313
3314         Reviewed by Dewei Zhu.
3315
3316         * BuildSlaveSupport/ews-build/steps.py:
3317         (ValidatePatch._is_bug_closed):
3318
3319 2019-04-11  Michael Saboff  <msaboff@apple.com>
3320
3321         Improve the Inline Cache Stats code
3322         https://bugs.webkit.org/show_bug.cgi?id=196836
3323
3324         Reviewed by Saam Barati.
3325
3326         Added a new script to consolidate and arrange the output of --useICStats option.
3327
3328         This script merges the output from every group into one large table and sorts it from most common to
3329         least common.  It also counts the slow path GetById and PutById variants and then calculates the
3330         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
3331         Put together, this is useful to see what property accesses are not getting cached.
3332
3333         * Scripts/ic-stats.py: Added.
3334         (ICStats):
3335         (ICStats.__init__):
3336         (ICStats.parse):
3337         (ICStats.dumpStats):
3338         (usage):
3339
3340 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3341
3342         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
3343         https://bugs.webkit.org/show_bug.cgi?id=196809
3344         <rdar://49800762>
3345
3346         Reviewed by Brady Eidson.
3347
3348         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3349         (TEST):
3350
3351 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
3352
3353         requestAnimationFrame should execute before the next frame
3354         https://bugs.webkit.org/show_bug.cgi?id=177484
3355
3356         Reviewed by Simon Fraser.
3357
3358         Add trace points for the page RenderingUpdate.
3359
3360         * Tracing/SystemTracePoints.plist:
3361
3362 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3363
3364         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
3365         https://bugs.webkit.org/show_bug.cgi?id=196760
3366
3367         Reviewed by Don Olmstead.
3368
3369         vswhere.exe has been bundled since Visual Studio 2017 version
3370         15.2. We shouldn't download vswhere.exe.
3371
3372         * Scripts/build-jsc: Do not call update-vswhere.py.
3373         * Scripts/build-webkit: Ditto.
3374         * Scripts/update-vswhere.py: Removed.
3375         * Scripts/webkitdirs.pm:
3376         (requireModulesForVSWhere): Deleted.
3377         (pickCurrentVisualStudioInstallation): Deleted.
3378         (visualStudioInstallDirVSWhere): Return the latest installed VS
3379         installation path by using the bundled vswhere.exe.
3380         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
3381         (visualStudioInstallDirFallback): Removed.
3382
3383 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
3384
3385         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
3386         https://bugs.webkit.org/show_bug.cgi?id=196780
3387
3388         Reviewed by Alexey Proskuryakov.
3389
3390         * BuildSlaveSupport/ews-build/steps.py:
3391         * BuildSlaveSupport/ews-build/steps_unittest.py:
3392
3393 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3394
3395         Add SPI WKNavigationResponse._downloadAttribute
3396         https://bugs.webkit.org/show_bug.cgi?id=196755
3397         <rdar://49587365>
3398
3399         Reviewed by Brady Eidson.
3400
3401         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3402         (-[NavigationResponseTestDelegate navigationResponse]):
3403         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
3404         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
3405         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3406         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
3407         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3408         (readRequest):
3409         (writeResponse):
3410         (TEST):
3411
3412 2019-04-10  Tim Horton  <timothy_horton@apple.com>
3413
3414         Add modern API for overriding the page's specified viewport configuration
3415         https://bugs.webkit.org/show_bug.cgi?id=167734
3416         <rdar://problem/30331795>
3417
3418         Reviewed by Simon Fraser.
3419
3420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3421         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
3422
3423 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
3424
3425         Add support for incremental bytecode cache updates
3426         https://bugs.webkit.org/show_bug.cgi?id=195000
3427
3428         Reviewed by Filip Pizlo.
3429
3430         Exit when the initial run to generate bytecode fails.
3431
3432         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3433
3434 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3435
3436         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
3437         https://bugs.webkit.org/show_bug.cgi?id=196744
3438         <rdar://49415309>
3439
3440         Reviewed by Chris Dumez.
3441
3442         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3443         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3444
3445 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3446
3447         Add a way to opt into modern compatibility mode in layout tests
3448         https://bugs.webkit.org/show_bug.cgi?id=196770
3449         <rdar://problem/49777550>
3450
3451         Reviewed by Antoine Quint.
3452
3453         Add a new test option to enable modern compatibility mode in layout tests.
3454
3455         * WebKitTestRunner/TestController.cpp:
3456         (WTR::updateTestOptionsFromTestHeader):
3457         * WebKitTestRunner/TestController.h:
3458         * WebKitTestRunner/TestOptions.h:
3459         (WTR::TestOptions::hasSameInitializationOptions const):
3460         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3461         (WTR::TestController::platformCreateWebView):
3462         (WTR::TestController::enableModernCompatibilityMode):
3463
3464 2019-04-10  Andy Estes  <aestes@apple.com>
3465
3466         Try to fix the 32-bit watchOS build.
3467
3468         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3469         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3470
3471 2019-04-10  Antoine Quint  <graouts@apple.com>
3472
3473         Enable Pointer Events on watchOS
3474         https://bugs.webkit.org/show_bug.cgi?id=196771
3475         <rdar://problem/49040909>
3476
3477         Reviewed by Dean Jackson.
3478
3479         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3480
3481 2019-04-10  Philippe Normand  <pnormand@igalia.com>
3482
3483         Unreviewed. Fix WPE accessibility tests after r244059.
3484
3485         We are failing to load the injected bundle due to undefined symbol
3486         AccessibilityUIElement::replaceTextInRange().
3487
3488         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
3489         (WTR::AccessibilityUIElement::replaceTextInRange):
3490
3491 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
3492
3493         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
3494         https://bugs.webkit.org/show_bug.cgi?id=196727
3495
3496         Reviewed by Fujii Hironori.
3497
3498         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3499         (WebKitBrowserWindow::create):
3500
3501 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
3502
3503         [ews-build] Add unit tests for PrintConfiguration
3504         https://bugs.webkit.org/show_bug.cgi?id=196752
3505
3506         Reviewed by Dewei Zhu.
3507
3508         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3509
3510 2019-04-09  Keith Rollin  <krollin@apple.com>
3511
3512         Unreviewed build maintenance -- update .xcfilelists.
3513
3514         * DumpRenderTree/DerivedSources-input.xcfilelist:
3515         * DumpRenderTree/DerivedSources-output.xcfilelist:
3516
3517 2019-04-09  Zalan Bujtas  <zalan@apple.com>
3518
3519         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
3520         https://bugs.webkit.org/show_bug.cgi?id=196743
3521         <rdar://problem/43897551>
3522
3523         Reviewed by Tim Horton.
3524
3525         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
3526         (TEST):
3527
3528 2019-04-09  Youenn Fablet  <youenn@apple.com>
3529
3530         Close service worker database on network process suspension
3531         https://bugs.webkit.org/show_bug.cgi?id=196623
3532         <rdar://problem/48930869>
3533
3534         Reviewed by Alex Christensen.
3535
3536         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3537
3538 2019-04-09  Daniel Bates  <dabates@apple.com>
3539
3540         [iPad] Should open popover when the spacebar is pressed
3541         https://bugs.webkit.org/show_bug.cgi?id=196360
3542         <rdar://problem/49389129>
3543
3544         Reviewed by Brent Fulgham.
3545
3546         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
3547
3548         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3549         (WTR::UIScriptController::isShowingPopover const): Added.
3550         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3551         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3552         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3553         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3554         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3555         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
3556         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
3557         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
3558         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
3559         (WTR::UIScriptController::isShowingPopover const): Added.
3560         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3561         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3562         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3563         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3564         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3565         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
3566         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
3567         (-[TestRunnerWKWebView _willPresentPopover]): Added.
3568         (-[TestRunnerWKWebView _didDismissPopover]): Added.
3569         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3570         (WTR::UIScriptController::isShowingPopover const): Added.
3571         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3572         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3573
3574 2019-04-09  Alex Christensen  <achristensen@webkit.org>
3575
3576         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3577         https://bugs.webkit.org/show_bug.cgi?id=196665
3578         <rdar://45115669>
3579
3580         Reviewed by Geoff Garen.
3581
3582         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3583         (goBack):
3584         (+[SimpleLookupContext sharedLookupContext]):
3585         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3586         (TEST):
3587         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3588         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3589
3590 2019-04-09  John Wilander  <wilander@apple.com>
3591
3592         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
3593         https://bugs.webkit.org/show_bug.cgi?id=196558
3594         <rdar://problem/47650245>
3595
3596         Reviewed by Youenn Fablet.
3597
3598         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3599         (TestWebKitAPI::TEST):
3600             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
3601
3602 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
3603
3604         [CMake] Apple builds should use ICU_INCLUDE_DIRS
3605         https://bugs.webkit.org/show_bug.cgi?id=196720
3606
3607         Reviewed by Konstantin Tokarev.
3608
3609         * TestWebKitAPI/PlatformMac.cmake:
3610
3611 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
3612
3613         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
3614         https://bugs.webkit.org/show_bug.cgi?id=196694
3615         <rdar://problem/48388734>
3616
3617         Rubber-stamped by Aakash Jain.
3618
3619         * Scripts/webkitpy/port/image_diff.py:
3620         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
3621         * Scripts/webkitpy/port/server_process.py:
3622         (ServerProcess.has_available_stdout): Check if stdout has data in it.
3623         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3624         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
3625         * Scripts/webkitpy/port/server_process_mock.py:
3626         (MockServerProcess.has_available_stdout):
3627         * Scripts/webkitpy/port/server_process_unittest.py:
3628         (TestServerProcess.serial_test_basic):
3629
3630 2019-04-09  Jer Noble  <jer.noble@apple.com>
3631
3632         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3633         https://bugs.webkit.org/show_bug.cgi?id=196097
3634
3635         Reviewed by Eric Carlson.
3636
3637         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3638
3639         * DumpRenderTree/mac/DumpRenderTree.mm:
3640         (resetWebPreferencesToConsistentValues):
3641         * WebKitTestRunner/TestController.cpp:
3642         (WTR::TestController::resetPreferencesToConsistentValues):
3643
3644 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
3645
3646         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
3647         https://bugs.webkit.org/show_bug.cgi?id=196690
3648
3649         Reviewed by Michael Catanzaro.
3650
3651         * QueueStatusServer/config/queues.py:
3652         * Scripts/webkitpy/common/config/ews.json:
3653         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3654         (test_ews_name):
3655
3656 2019-04-09  Chris Dumez  <cdumez@apple.com>
3657
3658         Loads using loadHTMLString() cause flashing when process-swapping
3659         https://bugs.webkit.org/show_bug.cgi?id=196714
3660         <rdar://problem/49637354>
3661
3662         Reviewed by Antti Koivisto.
3663
3664         Add API test coverage.
3665
3666         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3667
3668 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3669
3670         Unreviewed. Fix ATK accessibility tests after r244059.
3671
3672         We are failing to load the injected bundle due to undefined symbol
3673         AccessibilityUIElement::replaceTextInRange().
3674
3675         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3676         (WTR::AccessibilityUIElement::replaceTextInRange):
3677
3678 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3679
3680         AX: Support API: accessibilityReplaceRange:withText
3681         https://bugs.webkit.org/show_bug.cgi?id=196636
3682
3683         Unreviewed build fix for Windows port.
3684
3685         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3686         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
3687
3688 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
3689
3690         [CMake][WinCairo] Separate copied headers into different directories
3691         https://bugs.webkit.org/show_bug.cgi?id=196655
3692
3693         Reviewed by Michael Catanzaro.
3694
3695         * DumpRenderTree/CMakeLists.txt:
3696         * MiniBrowser/win/CMakeLists.txt:
3697         * TestWebKitAPI/CMakeLists.txt:
3698         * TestWebKitAPI/PlatformWin.cmake:
3699
3700 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
3701
3702         Log stack-trace for run-webkit-tests when interrupted
3703         https://bugs.webkit.org/show_bug.cgi?id=176393
3704         <rdar://problem/34262310>
3705
3706         Reviewed by Lucas Forschler.
3707
3708         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
3709         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
3710         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
3711         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
3712         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
3713         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3714         (main): Set handlers to log stack trace on interruption.
3715
3716 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3717
3718         AX: Support API: accessibilityReplaceRange:withText
3719         https://bugs.webkit.org/show_bug.cgi?id=196636
3720
3721         Unreviewed build fix for Windows port.
3722
3723         * DumpRenderTree/AccessibilityUIElement.cpp:
3724         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
3725
3726 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3727
3728         [ews-build] Scripts using Buildbot API have CORS error
3729         https://bugs.webkit.org/show_bug.cgi?id=196709
3730
3731         Reviewed by Alexey Proskuryakov.
3732
3733         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
3734
3735 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
3736
3737         AX: Support API: accessibilityReplaceRange:withText
3738         https://bugs.webkit.org/show_bug.cgi?id=196636
3739
3740         Reviewed by Daniel Bates.
3741
3742         * DumpRenderTree/AccessibilityUIElement.cpp:
3743         (replaceTextInRangeCallback):
3744         (AccessibilityUIElement::replaceTextInRange):
3745         (AccessibilityUIElement::getJSClass):
3746         * DumpRenderTree/AccessibilityUIElement.h:
3747         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3748         (AccessibilityUIElement::replaceTextInRange):
3749         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3750         (AccessibilityUIElement::replaceTextInRange):
3751         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3752         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3753         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3754         (WTR::AccessibilityUIElement::replaceTextInRange):
3755         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3756         (WTR::AccessibilityUIElement::replaceTextInRange):
3757
3758 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3759
3760         [iOS] Do not allow starting selection drags when selection views are not visible
3761         https://bugs.webkit.org/show_bug.cgi?id=196686
3762         <rdar://problem/49399192>
3763
3764         Reviewed by Tim Horton.
3765
3766         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
3767         also add some new API tests to cover scenarios where the web view is not first responder.
3768
3769         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3770         (TestWebKitAPI::TEST):
3771         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3772
3773         Add a switch to optionally make the web view first responder when starting the simulated drag.
3774
3775         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3776         (-[DragAndDropSimulator initWithWebView:]):
3777         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
3778
3779 2019-04-08  Justin Fan  <justin_fan@apple.com>
3780
3781         [Web GPU] Fix Web GPU experimental feature on iOS
3782         https://bugs.webkit.org/show_bug.cgi?id=196632
3783
3784         Reviewed by Myles C. Maxfield.
3785
3786         Properly make Web GPU available on iOS 11+.
3787
3788         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3789
3790 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3791
3792         [ews-build] Do not upload archive when Compile Fails
3793         https://bugs.webkit.org/show_bug.cgi?id=196674
3794
3795         Reviewed by Alexey Proskuryakov.
3796
3797         * BuildSlaveSupport/ews-build/factories.py:
3798         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
3799         * BuildSlaveSupport/ews-build/steps.py:
3800         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
3801         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
3802         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
3803
3804 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
3805
3806         Enable DFG on MIPS
3807         https://bugs.webkit.org/show_bug.cgi?id=196689
3808
3809         Reviewed by Žan Doberšek.
3810
3811         Since the bytecode change, we enabled the baseline JIT on mips in
3812         r240432, but DFG is still missing. With this change, all tests are
3813         passing on a ci20 board.
3814
3815         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
3816
3817 2019-04-08  Philippe Normand  <pnormand@igalia.com>
3818
3819         [Flatpak] Second run update-webkitwpe-flatpak fails
3820         https://bugs.webkit.org/show_bug.cgi?id=192702
3821
3822         Reviewed by Carlos Garcia Campos.
3823
3824         * flatpak/flatpakutils.py:
3825         (FlatpakObject.flatpak): Fix typo.
3826         (FlatpakPackage.install): When installing, also update to the configured remote commit.
3827         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
3828
3829 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
3830
3831         [GTK][WPE] outlook.live.com displays old-fashioned UI
3832         https://bugs.webkit.org/show_bug.cgi?id=196642
3833
3834         Reviewed by Carlos Garcia Campos.
3835
3836         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3837         (TestWebKitAPI::TEST): New Mac platform quirk test.
3838
3839 2019-04-07  Commit Queue  <commit-queue@webkit.org>
3840
3841         Unreviewed, rolling out r243956.
3842         https://bugs.webkit.org/show_bug.cgi?id=196688
3843
3844         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
3845         by aakashjain on #webkit).
3846
3847         Reverted changeset:
3848
3849         "Clicking "Go Back" from a safe browsing warning from an
3850         iframe should navigate the WKWebView back to the previous
3851         page"
3852         https://bugs.webkit.org/show_bug.cgi?id=196665
3853         https://trac.webkit.org/changeset/243956
3854
3855 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
3856
3857         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
3858         https://bugs.webkit.org/show_bug.cgi?id=196669
3859
3860         Reviewed by Geoffrey Garen.
3861
3862         Added three new unit tests for WeakHashSet.
3863
3864         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3865         (WTF_WeakPtr.WeakHashSetConstObjects):
3866         (WTF_WeakPtr.WeakHashSetComputesEmpty):
3867         (WTF_WeakPtr.WeakHashSetComputeSize):
3868
3869 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3870
3871         Hide next and previous form control buttons when WKWebView is editable
3872         https://bugs.webkit.org/show_bug.cgi?id=196672
3873         <rdar://problem/35625321>
3874
3875         Reviewed by Tim Horton.
3876
3877         Add a new API test.
3878
3879         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3880         (-[TestWKWebView lastTrailingBarButtonGroup]):
3881         (TestWebKitAPI::TEST):
3882         * TestWebKitAPI/ios/UIKitSPI.h:
3883
3884 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
3885
3886         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
3887         https://bugs.webkit.org/show_bug.cgi?id=196077
3888         <rdar://problem/49108202>
3889
3890         Reviewed by Chris Dumez.
3891
3892         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
3893         on new web view.
3894
3895         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3896
3897 2019-04-05  Saam Barati  <sbarati@apple.com>
3898
3899         Make compare-results understand MotionMark
3900         https://bugs.webkit.org/show_bug.cgi?id=196666
3901
3902         Reviewed by Yusuke Suzuki.
3903
3904         * Scripts/compare-results:
3905         (PLT5Results):
3906         (detectMotionMark):
3907         (detectMotionMark1_1):
3908         (motionMarkResults):
3909         (motionMark1_1Results):
3910         (detectBenchmark):
3911         (biggerIsBetter):
3912         (main):
3913
3914 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3915
3916         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3917         https://bugs.webkit.org/show_bug.cgi?id=196665
3918         <rdar://45115669>
3919
3920         Reviewed by Geoff Garen.
3921
3922         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3923         (goBack):
3924         (+[SimpleLookupContext sharedLookupContext]):
3925         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3926         (TEST):
3927         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3928         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3929
3930 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3931
3932         [ews-build] Add configuration and architecture for windows builders
3933         https://bugs.webkit.org/show_bug.cgi?id=196660
3934
3935         Reviewed by Lucas Forschler.
3936
3937         * BuildSlaveSupport/ews-build/config.json:
3938
3939 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3940
3941         webkitpy: Don't run subsequent rounds if interrupted
3942         https://bugs.webkit.org/show_bug.cgi?id=196646
3943
3944         Reviewed by Aakash Jain.
3945
3946         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3947         (Manager.run): Bail out if interrupted.
3948
3949 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3950
3951         Test sessionStorage in PSON private browsing mode
3952         https://bugs.webkit.org/show_bug.cgi?id=196561
3953
3954         Reviewed by Alex Christensen.
3955
3956         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3957
3958 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3959
3960         Unreviewed, rolling out r243833.
3961         https://bugs.webkit.org/show_bug.cgi?id=196645
3962
3963         This change breaks build of WPE and GTK ports (Requested by
3964         annulen on #webkit).
3965
3966         Reverted changeset:
3967
3968         "[CMake][WTF] Mirror XCode header directories"
3969         https://bugs.webkit.org/show_bug.cgi?id=191662
3970         https://trac.webkit.org/changeset/243833
3971
3972 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3973
3974         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3975         https://bugs.webkit.org/show_bug.cgi?id=196635
3976
3977         Reviewed by Antti Koivisto.
3978         
3979         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3980         for a test to enable async frame scrolling via:
3981             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3982         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3983         
3984         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3985
3986         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3987         (WTR::InjectedBundle::beginTesting):
3988         * WebKitTestRunner/TestController.cpp:
3989         (WTR::TestController::resetPreferencesToConsistentValues):
3990
3991 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3992
3993         Use a correct LC_RPATH when building with ASan
3994         https://bugs.webkit.org/show_bug.cgi?id=196576
3995
3996         Reviewed by David Kilzer.
3997
3998         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3999         so that ../Frameworks is checked. This is simpler and more reliable than updating
4000         each SPC service xcconfig.
4001
4002 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4003
4004         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
4005         https://bugs.webkit.org/show_bug.cgi?id=196629
4006
4007         Reviewed by Lucas Forschler.
4008
4009         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4010
4011 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4012
4013         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
4014         https://bugs.webkit.org/show_bug.cgi?id=196618
4015
4016         Reviewed by Lucas Forschler.
4017
4018         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4019         (StatusBubble): Added QUEUE_TRIGGERS.
4020         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
4021         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
4022         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
4023         its parent(builder).
4024
4025 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4026
4027         [ews-app] Status-bubble steps are sometimes displayed in reverse order
4028         https://bugs.webkit.org/show_bug.cgi?id=196625
4029
4030         Reviewed by Lucas Forschler.
4031
4032         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4033         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
4034
4035 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4036
4037         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
4038         https://bugs.webkit.org/show_bug.cgi?id=196630
4039
4040         Reviewed by Wenson Hsieh.
4041
4042         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4043
4044 2019-04-04  Youenn Fablet  <youenn@apple.com>
4045
4046         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
4047         https://bugs.webkit.org/show_bug.cgi?id=196543
4048
4049         Reviewed by Alex Christensen.
4050
4051         * WebKitTestRunner/TestController.cpp:
4052         (WTR::TestController::generatePageConfiguration):
4053
4054 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4055
4056         [ews-app] Status bubble should not display skipped buildbot steps
4057         https://bugs.webkit.org/show_bug.cgi?id=196584
4058
4059         Reviewed by Lucas Forschler.
4060
4061         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4062
4063 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4064
4065         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
4066         https://bugs.webkit.org/show_bug.cgi?id=196620
4067
4068         Reviewed by Lucas Forschler.
4069
4070         * BuildSlaveSupport/ews-app/ews/config.py:
4071
4072 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
4073
4074         [Win] DumpRenderTreeWatchDog.py is not checked into source
4075         https://bugs.webkit.org/show_bug.cgi?id=196567
4076         <rdar://problem/49525901>
4077
4078         Reviewed by Lucas Forschler.
4079
4080         This script is used on Win EWS bots to terminate hanging DRT processes.
4081
4082         * EWSTools/dumprendertreewatchdog.py: Added.
4083
4084 2019-04-04  Chris Dumez  <cdumez@apple.com>
4085
4086         Unreviewed, roll out r243858 which made tests time out.
4087
4088         Disable new API tests on Windows instead.
4089
4090         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4091         (TestWebKitAPI::TEST):
4092
4093 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4094
4095         [ATK] Cleanup WebPageAccessibilityObjectAtk
4096         https://bugs.webkit.org/show_bug.cgi?id=196537
4097
4098         Reviewed by Michael Catanzaro.
4099
4100         Also consider files under atk directories as exceptions for GObject conventions.
4101
4102         * Scripts/webkitpy/style/checkers/cpp.py:
4103         (check_identifier_name_in_declaration):
4104
4105 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
4106
4107         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
4108         https://bugs.webkit.org/show_bug.cgi?id=196588
4109         <rdar://problem/49365787>
4110
4111         Unreviewed build fix for Windows port.
4112
4113         error C3861: 'kill': identifier not found
4114
4115         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4116         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
4117
4118 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4119
4120         [ews-build] Cancel build and similar operations should have authentication
4121         https://bugs.webkit.org/show_bug.cgi?id=196520
4122
4123         Reviewed by Dewei Zhu.
4124
4125         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
4126         environment variables.
4127
4128 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4129
4130         [ews-build] Do not trigger queues which are not in production yet
4131         https://bugs.webkit.org/show_bug.cgi?id=196581
4132
4133         Reviewed by Dewei Zhu.
4134
4135         * BuildSlaveSupport/ews-build/config.json:
4136
4137 2019-04-03  Chris Dumez  <cdumez@apple.com>
4138
4139         Unreviewed, fix typo in the name of API test added in r243848.
4140
4141         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4142         (TestWebKitAPI::TEST):
4143
4144 2019-04-03  Chris Dumez  <cdumez@apple.com>
4145
4146         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
4147         https://bugs.webkit.org/show_bug.cgi?id=196588
4148         <rdar://problem/49365787>
4149
4150         Reviewed by Ryosuke Niwa.
4151
4152         Add API test coverage.
4153
4154         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4155         (TestWebKitAPI::nullJavaScriptCallback):
4156         (TestWebKitAPI::didCrashCheckFrames):
4157         (TestWebKitAPI::TEST):
4158
4159 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
4160
4161         run-webkit-tests: Upload test results (new results database)
4162         https://bugs.webkit.org/show_bug.cgi?id=196577
4163         <rdar://problem/34841155>
4164
4165         Reviewed by Lucas Forschler.
4166
4167         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4168         (Manager.run): Upload results after each device shard, since the configuration will be
4169         different for each device.
4170         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
4171         uploaded to a results database.
4172         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4173         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
4174
4175 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
4176
4177         -apple-trailing-word is needed for browser detection
4178         https://bugs.webkit.org/show_bug.cgi?id=196575
4179
4180         Unreviewed.
4181
4182         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4183
4184 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
4185
4186         [CMake][WTF] Mirror XCode header directories
4187         https://bugs.webkit.org/show_bug.cgi?id=191662
4188
4189         Reviewed by Konstantin Tokarev.
4190
4191         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
4192         builds.
4193
4194         * CMakeLists.txt:
4195         * DumpRenderTree/CMakeLists.txt:
4196         * DumpRenderTree/PlatformWin.cmake:
4197         * MiniBrowser/win/CMakeLists.txt:
4198         * TestWebKitAPI/CMakeLists.txt:
4199         * TestWebKitAPI/PlatformWin.cmake:
4200         * WebKitTestRunner/PlatformGTK.cmake:
4201         * WebKitTestRunner/PlatformWin.cmake:
4202
4203 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4204
4205         [ews-app] Status bubble should not display certain infrastructure status messages
4206         https://bugs.webkit.org/show_bug.cgi?id=196550
4207
4208         Reviewed by Lucas Forschler.
4209
4210         Do not display the steps which are un-needed for end-user. This information is still avaiable
4211         if the user click on the bubble and look at the Buildbot build.
4212         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4213         (StatusBubble._steps_messages):
4214         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
4215
4216 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4217
4218         [ews-build] Use https for sending data to ews-app
4219         https://bugs.webkit.org/show_bug.cgi?id=196492
4220
4221         Reviewed by Lucas Forschler.
4222
4223         * BuildSlaveSupport/ews-build/events.py:
4224
4225 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
4226
4227         Remove support for -apple-trailing-word
4228         https://bugs.webkit.org/show_bug.cgi?id=196525
4229
4230         Reviewed by Zalan Bujtas.
4231
4232         This CSS property is nonstandard and not used.
4233
4234         * Scripts/webkitperl/FeatureList.pm:
4235         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4236
4237 2019-04-03  Youenn Fablet  <youenn@apple.com>
4238
4239         Add a test for DOMCache on multiple browsing in case of private browsing
4240         https://bugs.webkit.org/show_bug.cgi?id=196524
4241
4242         Reviewed by Alex Christensen.
4243
4244         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4245         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
4246
4247 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
4248
4249         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
4250         https://bugs.webkit.org/show_bug.cgi?id=196540
4251
4252         Reviewed by Aakash Jain.
4253
4254         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
4255
4256 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
4257
4258         Add plumbing for a compatibility mode preference in WebKit
4259         https://bugs.webkit.org/show_bug.cgi?id=196005
4260
4261         Reviewed by Tim Horton.
4262
4263         Add new API tests.
4264
4265         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4266         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
4267
4268 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
4269
4270         [WPE][GTK] Update libsrtp dependency package for Debian
4271         https://bugs.webkit.org/show_bug.cgi?id=196528
4272
4273         Reviewed by Frédéric Wang.
4274
4275         * gtk/install-dependencies:
4276         * wpe/install-dependencies:
4277
4278 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
4279
4280         [WK2] Add support for Window's beforeprint / afterprint events
4281         https://bugs.webkit.org/show_bug.cgi?id=196478
4282         <rdar://problem/49535124>
4283
4284         Unreviewed build fix for MSVC.
4285
4286         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
4287
4288         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
4289
4290         * WebKitTestRunner/TestController.cpp:
4291         (WTR::printFrame): Use int and float literals.
4292
4293 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
4294
4295         [ews-build] Reassign bots to queues
4296
4297         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
4298
4299 2019-04-02  Chris Dumez  <cdumez@apple.com>
4300
4301         [WK2] Add support for Window's beforeprint / afterprint events
4302         https://bugs.webkit.org/show_bug.cgi?id=196478
4303
4304         Reviewed by Alex Christensen.
4305
4306         Add minimal implementation for printFrame in WebKitTestRunner.
4307
4308         * WebKitTestRunner/TestController.cpp:
4309         (WTR::printFrame):
4310         (WTR::TestController::createOtherPage):
4311         (WTR::TestController::createWebViewWithOptions):
4312
4313 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
4314
4315         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
4316         https://bugs.webkit.org/show_bug.cgi?id=196491
4317
4318         Reviewed by Lucas Forschler.
4319
4320         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4321
4322 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
4323
4324         [ews-build] Configure buildbot try credentials in environment variables
4325         https://bugs.webkit.org/show_bug.cgi?id=196501
4326
4327         Reviewed by Lucas Forschler.
4328
4329         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
4330         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
4331         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
4332