[ews-build] Use singular verb in failure description in case of single api test failure
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Use singular verb in failure description in case of single api test failure
4         https://bugs.webkit.org/show_bug.cgi?id=197013
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-build/steps.py:
9         (AnalyzeAPITestsResults.analyzeResults):
10
11 2019-04-22  Chris Dumez  <cdumez@apple.com>
12
13         Delayed WebProcessLaunch may break the _relatedWebView SPI
14         https://bugs.webkit.org/show_bug.cgi?id=197160
15
16         Reviewed by Alex Christensen.
17
18         Add API test coverage.
19
20         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
21
22 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
23
24         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
25         https://bugs.webkit.org/show_bug.cgi?id=194630
26
27         Reviewed by Michael Catanzaro.
28
29         Return early from getAttributeSet() is passed in accessible is nullptr.
30
31         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
32
33 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
34
35         Defer EditorState updates until the next layer tree flush in a few additional circumstances
36         https://bugs.webkit.org/show_bug.cgi?id=197145
37         <rdar://problem/50078170>
38
39         Reviewed by Darin Adler.
40
41         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
42         focus, or showing the font manager.
43
44         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
45         (TestWebKitAPI::TEST):
46         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
47         (TEST):
48         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
49         (TestWebKitAPI::TEST):
50
51 2019-04-21  Brian Burg  <bburg@apple.com>
52
53         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
54         https://bugs.webkit.org/show_bug.cgi?id=197125
55         <rdar://problem/50061468>
56
57         Reviewed by Darin Adler.
58
59         Sometimes I want to run wptserve independently of tests. Make it easier to script that
60         using this class rather than making our own ./wpt serve invocation.
61
62         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
63         (WebDriverW3CWebServer):
64         (WebDriverW3CWebServer.document_root): Expose this to clients.
65         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
66
67         (WebDriverW3CWebServer.__enter__):
68         (WebDriverW3CWebServer.__exit__):
69         Make it possible to use the web server with a 'with' statement.
70
71 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
72
73         [CMake][Win] Use target oriented design for WebKitLegacy
74         https://bugs.webkit.org/show_bug.cgi?id=197112
75
76         Reviewed by Konstantin Tokarev.
77
78         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
79
80         * DumpRenderTree/CMakeLists.txt:
81         * DumpRenderTree/PlatformWin.cmake:
82         * DumpRenderTree/win/EventSender.cpp:
83
84 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
85
86         Update text for old EWS submit button
87         https://bugs.webkit.org/show_bug.cgi?id=197140
88
89         Reviewed by Alexey Proskuryakov.
90
91         * QueueStatusServer/templates/statusbubble.html:
92
93 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
94
95         [ews-app] New EWS should poll bugzilla more frequently
96         https://bugs.webkit.org/show_bug.cgi?id=197138
97
98         Reviewed by Alexey Proskuryakov.
99
100         * BuildSlaveSupport/ews-app/ews/fetcher.py:
101         (FetchLoop.__init__):
102
103 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
104
105         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
106         https://bugs.webkit.org/show_bug.cgi?id=197139
107
108         Reviewed by Alexey Proskuryakov.
109
110         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
111         * QueueStatusServer/templates/statusbubble.html:
112
113 2019-04-20  Chris Dumez  <cdumez@apple.com>
114
115         Unreviewed, fix iOS build with recent SDKs.
116
117         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
118
119 2019-04-19  Keith Miller  <keith_miller@apple.com>
120
121         Add script to merge run_benchmark jsons
122         https://bugs.webkit.org/show_bug.cgi?id=197107
123
124         Reviewed by Michael Saboff.
125
126         The script basically recursively decends through all json objects until it gets
127         to an array or JSON primitive and concats or takes the first value, respectively.
128
129         This patch also adds +x bits to the compare-results script so it
130         can be run directly from the command line. I had to add a new line so that svn
131         will accept the change... yay svn!
132
133         * Scripts/compare-results:
134         * Scripts/merge-result-jsons: Added.
135         (readJSONFile):
136         (deepAppend):
137         (mergeJSONs):
138         (main):
139
140 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
141
142         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
143         https://bugs.webkit.org/show_bug.cgi?id=197079
144
145         Reviewed by Darin Adler.
146
147         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
148
149         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
150         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
151
152 2019-04-18  Commit Queue  <commit-queue@webkit.org>
153
154         Unreviewed, rolling out r244434.
155         https://bugs.webkit.org/show_bug.cgi?id=197089
156
157         caused 1 API test failure (Requested by zalan on #webkit).
158
159         Reverted changeset:
160
161         "Regression (r244291): Broken API Test
162         AutoLayoutRenderingProgressRelativeOrdering"
163         https://bugs.webkit.org/show_bug.cgi?id=196948
164         https://trac.webkit.org/changeset/244434
165
166 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
167
168         Add new compatibility mode API on WKNavigation
169         https://bugs.webkit.org/show_bug.cgi?id=197069
170         <rdar://problem/50025800>
171
172         Reviewed by Tim Horton.
173
174         Add a block property for -didCommitNavigation to TestNavigationDelegate.
175
176         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
177         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
178         (-[TestNavigationDelegate webView:didCommitNavigation:]):
179
180 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
181
182         [CMake] Make WebCore headers copies
183         https://bugs.webkit.org/show_bug.cgi?id=182512
184         <rdar://problem/37510435>
185
186         Reviewed by Alex Christensen.
187
188         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
189         ports.
190
191         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
192         of WebCore headers using "*.h" were modified to <WebCore/*.h>
193
194         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
195         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
196         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
197         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
198         * TestWebKitAPI/CMakeLists.txt:
199         * TestWebKitAPI/PlatformWin.cmake:
200         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
201         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
202         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
203
204 2019-04-18  Jer Noble  <jer.noble@apple.com>
205
206         Add support for parsing FairPlayStreaming PSSH boxes.
207         https://bugs.webkit.org/show_bug.cgi?id=197064
208
209         Reviewed by Eric Carlson.
210
211         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
212         (TestWebKitAPI::TEST):
213
214 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
215
216         InjectedBundle parameters often need initialization function called before unarchiving
217         https://bugs.webkit.org/show_bug.cgi?id=189709
218         <rdar://problem/44573653>
219
220         Reviewed by Ryosuke Niwa.
221
222         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
223         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
224
225 2019-04-18  Zalan Bujtas  <zalan@apple.com>
226
227         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
228         https://bugs.webkit.org/show_bug.cgi?id=196948
229         <rdar://problem/49927131>
230
231         Reviewed by Tim Horton.
232
233         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
234         (TEST): 
235         The expected order of incoming events is
236         1. didInvalidateIntrinsicContentSize
237         2. didFirstLayout
238         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
239         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
240         (and remember, all we care about is ordering).
241
242 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
243
244         Unreviewed, rolling out r244299.
245
246         Breaks internal tests.
247
248         Reverted changeset:
249
250         "InjectedBundle parameters often need initialization function
251         called before unarchiving"
252         https://bugs.webkit.org/show_bug.cgi?id=189709
253         https://trac.webkit.org/changeset/244299
254
255 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
256
257         [WTF] StringBuilder should set correct m_is8Bit flag when merging
258         https://bugs.webkit.org/show_bug.cgi?id=197053
259
260         Reviewed by Saam Barati.
261
262         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
263         (TestWebKitAPI::TEST):
264
265 2019-04-17  Tim Horton  <timothy_horton@apple.com>
266
267         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
268         https://bugs.webkit.org/show_bug.cgi?id=197028
269         <rdar://problem/49985290>
270
271         Reviewed by Wenson Hsieh.
272
273         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
274         (TEST):
275         Liberal application of waitForNextPresentationUpdate works around a race
276         where if the page rapidly changes its viewport arguments (or an API client
277         rapidly changes its viewport arguments), we'd get stuck thinking that the
278         user had intentionally zoomed the page, and stop resetting the initial scale.
279         This deserves a separate bug, but no need to keep the test failing while
280         we think about it.
281
282 2019-04-17  Tim Horton  <timothy_horton@apple.com>
283
284         REGRESSION (r241988): Switching tabs is slow
285         https://bugs.webkit.org/show_bug.cgi?id=197037
286         <rdar://problem/49951473>
287
288         Reviewed by Simon Fraser.
289
290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
291         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
292         (TEST):
293         * TestWebKitAPI/cocoa/TestWKWebView.h:
294         * TestWebKitAPI/cocoa/TestWKWebView.mm:
295         (-[TestWKWebView addToTestWindow]):
296         Add a test that hangs without this fix.
297
298 2019-04-17  Truitt Savell  <tsavell@apple.com>
299
300         Unreviewed, rolling out r244400.
301
302         Caused testing to exit early with assertionon Debug WK2
303
304         Reverted changeset:
305
306         "UI↔Web deadlock when printing with a JavaScript alert
307         visible"
308         https://bugs.webkit.org/show_bug.cgi?id=196839
309         https://trac.webkit.org/changeset/244400
310
311 2019-04-17  Brady Eidson  <beidson@apple.com>
312
313         Link clicks in PDFs shouldn't send referrer headers.
314         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
315
316         Reviewed by Tim Horton.
317
318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
319         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
320         (putPDFBytesCallback):
321         (emptyReleaseInfoCallback):
322         (createPDFWithLinkToURL):
323         (TEST):
324
325 2019-04-17  Tim Horton  <timothy_horton@apple.com>
326
327         UI↔Web deadlock when printing with a JavaScript alert visible
328         https://bugs.webkit.org/show_bug.cgi?id=196839
329         <rdar://problem/49157642>
330
331         Reviewed by Andy Estes.
332
333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
334         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
335         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
336         (TEST):
337
338 2019-04-17  Alex Christensen  <achristensen@webkit.org>
339
340         WKRetainPtr's adoption constructor should be private
341         https://bugs.webkit.org/show_bug.cgi?id=197019
342
343         Reviewed by Tim Horton.
344
345         * DumpRenderTree/mac/DumpRenderTree.mm:
346         (dumpFramesAsText):
347         * TestWebKitAPI/InjectedBundleController.cpp:
348         (TestWebKitAPI::InjectedBundleController::initialize):
349         * TestWebKitAPI/PlatformUtilities.cpp:
350         (TestWebKitAPI::Util::createContextWithInjectedBundle):
351         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
352         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
353         (TestWebKitAPI::Util::toWK):
354         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
355         (TestWebKitAPI::TEST):
356         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
357         (TestWebKitAPI::TEST):
358         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
359         (TestWebKitAPI::TEST):
360         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
361         (TestWebKitAPI::TEST):
362         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
363         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
364         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
365         (TestWebKitAPI::TEST):
366         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
367         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
368         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
369         (TestWebKitAPI::TEST):
370         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
371         (TestWebKitAPI::TEST):
372         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
373         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
374         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
375         (TestWebKitAPI::TEST):
376         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
377         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
378         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
379         (TestWebKitAPI::TEST):
380         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
381         (TestWebKitAPI::TEST):
382         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
383         (TestWebKitAPI::TEST):
384         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
385         (TestWebKitAPI::TEST):
386         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
387         (TestWebKitAPI::TEST):
388         * TestWebKitAPI/Tests/WebKit/Find.cpp:
389         (TestWebKitAPI::TEST):
390         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
391         (TestWebKitAPI::TEST):
392         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
393         (TestWebKitAPI::TEST):
394         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
395         (TestWebKitAPI::TEST):
396         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
397         (TestWebKitAPI::TEST):
398         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
399         (TestWebKitAPI::TEST):
400         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
401         (TestWebKitAPI::TEST):
402         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
403         (TestWebKitAPI::TEST):
404         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
405         (TestWebKitAPI::TEST):
406         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
407         (TestWebKitAPI::TEST):
408         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
409         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
410         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
411         (TestWebKitAPI::TEST):
412         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
413         (TestWebKitAPI::TEST):
414         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
415         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
416         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
417         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
418         (TestWebKitAPI::TEST):
419         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
420         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
421         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
422         (TestWebKitAPI::TEST):
423         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
424         (TestWebKitAPI::TEST):
425         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
426         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
427         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
428         (TestWebKitAPI::TEST):
429         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
430         (TestWebKitAPI::loadAlternateHTMLString):
431         (TestWebKitAPI::TEST):
432         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
433         (TestWebKitAPI::TEST):
434         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
435         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
436         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
437         (TestWebKitAPI::buildAndPerformTest):
438         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
439         (TestWebKitAPI::TEST):
440         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
441         (TestWebKitAPI::TEST):
442         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
443         (TestWebKitAPI::TEST):
444         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
445         (TestWebKitAPI::TEST):
446         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
447         (TestWebKitAPI::TEST):
448         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
449         (TestWebKitAPI::TEST):
450         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
451         (TestWebKitAPI::TEST):
452         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
453         (TestWebKitAPI::TEST):
454         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
455         (TestWebKitAPI::TEST):
456         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
457         (TestWebKitAPI::TEST):
458         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
459         (TestWebKitAPI::TEST):
460         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
461         (TestWebKitAPI::TEST):
462         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
463         (TestWebKitAPI::TEST):
464         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
465         (TestWebKitAPI::TEST):
466         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
467         (TestWebKitAPI::TEST):
468         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
469         (TestWebKitAPI::TEST):
470         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
471         (TestWebKitAPI::TEST):
472         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
473         (TestWebKitAPI::TEST):
474         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
475         (TestWebKitAPI::TEST):
476         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
477         (TestWebKitAPI::TEST):
478         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
479         (TestWebKitAPI::TEST):
480         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
481         (TestWebKitAPI::TEST):
482         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
483         (TestWebKitAPI::TEST):
484         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
485         (TestWebKitAPI::TEST):
486         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
487         (TestWebKitAPI::TEST):
488         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
489         (TestWebKitAPI::TEST):
490         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
491         (TestWebKitAPI::TEST):
492         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
493         (TestWebKitAPI::TEST):
494         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
495         (TestWebKitAPI::TEST):
496         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
497         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
498         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
499         (TestWebKitAPI::TEST):
500         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
501         (TestWebKitAPI::TEST):
502         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
503         (TestWebKitAPI::TEST):
504         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
505         (TestWebKitAPI::TEST):
506         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
507         (TestWebKitAPI::TEST):
508         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
509         (TestWebKitAPI::TEST):
510         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
511         (TestWebKitAPI::TEST):
512         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
513         (TestWebKitAPI::TEST):
514         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
515         (TestWebKitAPI::TEST):
516         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
517         (TestWebKitAPI::TEST):
518         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
519         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
520         (TEST):
521         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
522         (TEST):
523         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
524         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
525         (TEST):
526         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
527         (TestWebKitAPI::TEST):
528         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
529         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
530         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
531         (WTR::getMenuItemTitleCallback):
532         (WTR::createMouseMessageBody):
533         (WTR::EventSendingController::mouseDown):
534         (WTR::EventSendingController::mouseUp):
535         (WTR::EventSendingController::mouseMoveTo):
536         (WTR::EventSendingController::mouseForceClick):
537         (WTR::EventSendingController::startAndCancelMouseForceClick):
538         (WTR::EventSendingController::mouseForceDown):
539         (WTR::EventSendingController::mouseForceUp):
540         (WTR::EventSendingController::mouseForceChanged):
541         (WTR::EventSendingController::leapForward):
542         (WTR::EventSendingController::scheduleAsynchronousClick):
543         (WTR::createKeyDownMessageBody):
544         (WTR::EventSendingController::keyDown):
545         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
546         (WTR::EventSendingController::mouseScrollBy):
547         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
548         (WTR::EventSendingController::continuousMouseScrollBy):
549         (WTR::EventSendingController::addTouchPoint):
550         (WTR::EventSendingController::updateTouchPoint):
551         (WTR::EventSendingController::setTouchModifier):
552         (WTR::EventSendingController::setTouchPointRadius):
553         (WTR::EventSendingController::touchStart):
554         (WTR::EventSendingController::touchMove):
555         (WTR::EventSendingController::touchEnd):
556         (WTR::EventSendingController::touchCancel):
557         (WTR::EventSendingController::clearTouchPoints):
558         (WTR::EventSendingController::releaseTouchPoint):
559         (WTR::EventSendingController::cancelTouchPoint):
560         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
561         (WTR::InjectedBundle::didCreatePage):
562         (WTR::InjectedBundle::didReceiveMessage):
563         (WTR::InjectedBundle::didReceiveMessageToPage):
564         (WTR::InjectedBundle::booleanForKey):
565         (WTR::InjectedBundle::done):
566         (WTR::InjectedBundle::dumpToStdErr):
567         (WTR::InjectedBundle::outputText):
568         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
569         (WTR::InjectedBundle::postAddChromeInputField):
570         (WTR::InjectedBundle::postRemoveChromeInputField):
571         (WTR::InjectedBundle::postFocusWebView):
572         (WTR::InjectedBundle::postSetBackingScaleFactor):
573         (WTR::InjectedBundle::postSetWindowIsKey):
574         (WTR::InjectedBundle::postSetViewSize):
575         (WTR::InjectedBundle::postSimulateWebNotificationClick):
576         (WTR::InjectedBundle::postSetAddsVisitedLinks):
577         (WTR::InjectedBundle::setGeolocationPermission):
578         (WTR::InjectedBundle::setMockGeolocationPosition):
579         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
580         (WTR::InjectedBundle::isGeolocationProviderActive const):
581         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
582         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
583         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
584         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
585         (WTR::InjectedBundle::setCustomPolicyDelegate):
586         (WTR::InjectedBundle::setHidden):
587         (WTR::InjectedBundle::setCacheModel):
588         (WTR::InjectedBundle::shouldProcessWorkQueue const):
589         (WTR::InjectedBundle::processWorkQueue):
590         (WTR::InjectedBundle::queueBackNavigation):
591         (WTR::InjectedBundle::queueForwardNavigation):
592         (WTR::InjectedBundle::queueLoad):
593         (WTR::InjectedBundle::queueLoadHTMLString):
594         (WTR::InjectedBundle::queueReload):
595         (WTR::InjectedBundle::queueLoadingScript):
596         (WTR::InjectedBundle::queueNonLoadingScript):
597         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
598         (WTR::frameToStr):
599         (WTR::InjectedBundlePage::InjectedBundlePage):
600         (WTR::dumpFrameDescriptionSuitableForTestResult):
601         (WTR::dumpFrameScrollPosition):
602         (WTR::dumpDescendantFrameScrollPositions):
603         (WTR::dumpFrameText):
604         (WTR::dumpDescendantFramesText):
605         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
606         (WTR::TestRunner::shouldDumpPixels const):
607         (WTR::TestRunner::setDumpPixels):
608         (WTR::TestRunner::whatToDump const):
609         (WTR::TestRunner::setWhatToDump):
610         (WTR::TestRunner::setWaitUntilDone):
611         (WTR::TestRunner::shouldWaitUntilDone const):
612         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
613         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
614         (WTR::TestRunner::clearAllDatabases):
615         (WTR::TestRunner::setIDBPerOriginQuota):
616         (WTR::TestRunner::originsWithApplicationCache):
617         (WTR::TestRunner::setCanOpenWindows):
618         (WTR::TestRunner::setXSSAuditorEnabled):
619         (WTR::TestRunner::setMediaDevicesEnabled):
620         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
621         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
622         (WTR::TestRunner::setCustomUserAgent):
623         (WTR::TestRunner::setWebAPIStatisticsEnabled):
624         (WTR::TestRunner::setModernMediaControlsEnabled):
625         (WTR::TestRunner::setWebGL2Enabled):
626         (WTR::TestRunner::setWritableStreamAPIEnabled):
627         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
628         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
629         (WTR::TestRunner::setAllowsAnySSLCertificate):
630         (WTR::TestRunner::setPluginsEnabled):
631         (WTR::TestRunner::setValueForUser):
632         (WTR::TestRunner::setAudioResult):
633         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
634         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
635         (WTR::TestRunner::setAlwaysAcceptCookies):
636         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
637         (WTR::TestRunner::isDoingMediaCapture const):
638         (WTR::TestRunner::queueLoad):
639         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
640         (WTR::TestRunner::setHandlesAuthenticationChallenges):
641         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
642         (WTR::TestRunner::setShouldLogDownloadCallbacks):
643         (WTR::TestRunner::setAuthenticationUsername):
644         (WTR::TestRunner::setAuthenticationPassword):
645         (WTR::TestRunner::secureEventInputIsEnabled const):
646         (WTR::TestRunner::setBlockAllPlugins):
647         (WTR::TestRunner::setPluginSupportedMode):
648         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
649         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
650         (WTR::TestRunner::setNavigationGesturesEnabled):
651         (WTR::TestRunner::setIgnoresViewportScaleLimits):
652         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
653         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
654         (WTR::TestRunner::terminateNetworkProcess):
655         (WTR::TestRunner::terminateServiceWorkerProcess):
656         (WTR::TestRunner::runUIScript):
657         (WTR::TestRunner::setStatisticsDebugMode):
658         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
659         (WTR::TestRunner::setStatisticsLastSeen):
660         (WTR::TestRunner::setStatisticsPrevalentResource):
661         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
662         (WTR::TestRunner::dumpResourceLoadStatistics):
663         (WTR::TestRunner::isStatisticsPrevalentResource):
664         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
665         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
666         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
667         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
668         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
669         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
670         (WTR::TestRunner::setStatisticsGrandfathered):
671         (WTR::TestRunner::isStatisticsGrandfathered):
672         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
673         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
674         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
675         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
676         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
677         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
678         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
679         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
680         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
681         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
682         (WTR::TestRunner::statisticsUpdateCookieBlocking):
683         (WTR::TestRunner::statisticsSubmitTelemetry):
684         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
685         (WTR::TestRunner::setStatisticsIsRunningTest):
686         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
687         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
688         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
689         (WTR::TestRunner::setStatisticsGrandfatheringTime):
690         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
691         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
692         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
693         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
694         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
695         (WTR::TestRunner::statisticsDeleteCookiesForHost):
696         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
697         (WTR::TestRunner::statisticsResetToConsistentState):
698         (WTR::TestRunner::setStorageAccessAPIEnabled):
699         (WTR::TestRunner::getAllStorageAccessEntries):
700         (WTR::TestRunner::addMockMediaDevice):
701         (WTR::TestRunner::clearMockMediaDevices):
702         (WTR::TestRunner::removeMockMediaDevice):
703         (WTR::TestRunner::resetMockMediaDevices):
704         (WTR::TestRunner::connectMockGamepad):
705         (WTR::TestRunner::disconnectMockGamepad):
706         (WTR::TestRunner::setMockGamepadDetails):
707         (WTR::TestRunner::setMockGamepadAxisValue):
708         (WTR::TestRunner::setMockGamepadButtonValue):
709         (WTR::TestRunner::removeAllSessionCredentials):
710         (WTR::TestRunner::clearDOMCache):
711         (WTR::TestRunner::clearDOMCaches):
712         (WTR::TestRunner::hasDOMCache):
713         (WTR::TestRunner::domCacheSize):
714         (WTR::TestRunner::setAllowStorageQuotaIncrease):
715         (WTR::TestRunner::getApplicationManifestThen):
716         (WTR::TestRunner::injectUserScript):
717         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
718         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
719         (WTR::TestRunner::addTestKeyToKeychain):
720         (WTR::TestRunner::cleanUpKeychain):
721         (WTR::TestRunner::keyExistsInKeychain):
722         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
723         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
724         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
725         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
726         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
727         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
728         * WebKitTestRunner/TestController.cpp:
729         (WTR::TestController::initialize):
730         (WTR::parseStringTestHeaderValueAsRelativePath):
731         (WTR::updateTestOptionsFromTestHeader):
732         (WTR::TestController::runTest):
733         (WTR::TestController::didReceiveLiveDocumentsList):
734         (WTR::TestController::didReceiveMessageFromInjectedBundle):
735         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
736         (WTR::TestController::didFinishNavigation):
737         (WTR::TestController::didReceiveAuthenticationChallenge):
738         * WebKitTestRunner/TestInvocation.cpp:
739         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
740         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
741         (WTR::TestInvocation::uiScriptDidComplete):
742         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
743         * WebKitTestRunner/WebNotificationProvider.cpp:
744         (WTR::WebNotificationProvider::closeWebNotification):
745         * WebKitTestRunner/WorkQueueManager.cpp:
746         (WTR::ScriptItem::ScriptItem):
747         (WTR::WorkQueueManager::queueLoad):
748         (WTR::WorkQueueManager::queueLoadHTMLString):
749
750 2019-04-17  Alex Christensen  <achristensen@webkit.org>
751
752         Add a comment to make my test from r244139 less mysterious.
753         https://bugs.webkit.org/show_bug.cgi?id=196744
754
755         As suggested by Darin Adler.
756
757         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
758         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
759
760 2019-04-17  Chris Dumez  <cdumez@apple.com>
761
762         Remember device orientation permission for the duration of the browsing session
763         https://bugs.webkit.org/show_bug.cgi?id=196992
764         <rdar://problem/49946067>
765
766         Reviewed by Alex Christensen.
767
768         Add API test coverage.
769
770         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
771         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
772         (TEST):
773
774 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
775
776         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
777         https://bugs.webkit.org/show_bug.cgi?id=196675
778
779         Reviewed by Lucas Forschler.
780
781         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
782         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
783
784 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
785
786         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
787         https://bugs.webkit.org/show_bug.cgi?id=196919
788         <rdar://problem/41630459>
789
790         Reviewed by Tim Horton.
791
792         Add iOS support for several new testing hooks. See below for more detail.
793
794         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
795         (WTR::UIScriptController::isDismissingMenu const):
796
797         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
798         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
799         by UIKit when dismissing the callout bar (i.e. UIMenuController).
800
801         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
802         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
803         (WTR::UIScriptController::isDismissingMenu const):
804         * TestRunnerShared/UIScriptContext/UIScriptController.h:
805         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
806         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
807         (WTR::InjectedBundle::didReceiveMessageToPage):
808         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
809         (WTR::TestRunner::setAllowedMenuActions):
810
811         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
812         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
813         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
814         against the name of the custom action.
815
816         (WTR::TestRunner::installCustomMenuAction):
817
818         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
819         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
820         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
821         triggered.
822
823         (WTR::TestRunner::performCustomMenuAction):
824
825         Invoked when the custom menu action is triggered.
826
827         * WebKitTestRunner/InjectedBundle/TestRunner.h:
828         * WebKitTestRunner/TestController.cpp:
829         (WTR::TestController::installCustomMenuAction):
830         (WTR::TestController::setAllowedMenuActions):
831         * WebKitTestRunner/TestController.h:
832         * WebKitTestRunner/TestInvocation.cpp:
833         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
834         (WTR::TestInvocation::performCustomMenuAction):
835
836         Add plumbing to call back into the injected bundle when performing the custom action.
837
838         * WebKitTestRunner/TestInvocation.h:
839         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
840         (WTR::TestController::installCustomMenuAction):
841         (WTR::TestController::setAllowedMenuActions):
842         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
843         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
844         (-[TestRunnerWKWebView initWithFrame:configuration:]):
845         (-[TestRunnerWKWebView becomeFirstResponder]):
846         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
847
848         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
849         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
850         in the Mail app on iOS.
851
852         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
853         (-[TestRunnerWKWebView setAllowedMenuActions:]):
854         (-[TestRunnerWKWebView resetCustomMenuAction]):
855         (-[TestRunnerWKWebView performCustomAction:]):
856         (-[TestRunnerWKWebView canPerformAction:withSender:]):
857         (-[TestRunnerWKWebView _willHideMenu]):
858         (-[TestRunnerWKWebView _didHideMenu]):
859         * WebKitTestRunner/ios/TestControllerIOS.mm:
860         (WTR::TestController::platformResetStateToConsistentValues):
861
862         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
863         if specified.
864
865         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
866         (WTR::UIScriptController::isDismissingMenu const):
867
868 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
869
870         Allow sharing from imageSheet on an image document
871         https://bugs.webkit.org/show_bug.cgi?id=196891
872         <rdar://problem/25377386>
873
874         Reviewed by Tim Horton.
875
876         Test to make sure that the correct imageURL is extracted from an image element.
877
878         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
879         (TestWebKitAPI::TEST):
880
881 2019-04-16  Alex Christensen  <achristensen@webkit.org>
882
883         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
884         https://bugs.webkit.org/show_bug.cgi?id=196995
885
886         Reviewed by Brady Eidson.
887
888         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
889         (TEST):
890
891 2019-04-16  Chris Dumez  <cdumez@apple.com>
892
893         URL set by document.open() is not communicated to the UIProcess
894         https://bugs.webkit.org/show_bug.cgi?id=196941
895         <rdar://problem/49237544>
896
897         Reviewed by Geoff Garen.
898
899         Add API test coverage.
900
901         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
902         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
903         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
904         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
905         (TEST):
906
907 2019-04-16  Commit Queue  <commit-queue@webkit.org>
908
909         Unreviewed, rolling out r244321.
910         https://bugs.webkit.org/show_bug.cgi?id=196968
911
912         Causing all WK2 Debug builds to exit early after Assertion
913         failures. (Requested by ShawnRoberts on #webkit).
914
915         Reverted changeset:
916
917         "URL set by document.open() is not communicated to the
918         UIProcess"
919         https://bugs.webkit.org/show_bug.cgi?id=196941
920         https://trac.webkit.org/changeset/244321
921
922 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
923
924         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
925         https://bugs.webkit.org/show_bug.cgi?id=196948
926
927         Reviewed by Zalan Bujtas.
928
929         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
930         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
931
932 2019-04-15  Chris Dumez  <cdumez@apple.com>
933
934         URL set by document.open() is not communicated to the UIProcess
935         https://bugs.webkit.org/show_bug.cgi?id=196941
936         <rdar://problem/49237544>
937
938         Reviewed by Geoffrey Garen.
939
940         Add API test coverage.
941
942         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
943         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
944         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
945         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
946         (TEST):
947
948 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
949
950         Using Tools/Scripts/clean-webkit should not install requests
951         https://bugs.webkit.org/show_bug.cgi?id=196940
952
953         Reviewed by Lucas Forschler.
954
955         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
956         existing, depending on the path autoinstalled is run through.
957         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
958         needed.
959         (Port.configuration_for_upload):
960         (Port.commits_for_upload):
961
962 2019-04-15  Alex Christensen  <achristensen@webkit.org>
963
964         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
965         https://bugs.webkit.org/show_bug.cgi?id=196773
966
967         Reviewed by Jer Noble.
968
969         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
970         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
971         (TEST):
972
973 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
974
975         ews-build should clearly indicate flaky test failures
976         https://bugs.webkit.org/show_bug.cgi?id=196947
977
978         Reviewed by Lucas Forschler.
979
980         * BuildSlaveSupport/ews-build/steps.py:
981         (AnalyzeAPITestsResults.analyzeResults):
982
983 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
984
985         InjectedBundle parameters often need initialization function called before unarchiving
986         https://bugs.webkit.org/show_bug.cgi?id=189709
987         <rdar://problem/44573653>
988
989         Reviewed by Ryosuke Niwa.
990
991         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
992         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
993
994 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
995
996         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
997         https://bugs.webkit.org/show_bug.cgi?id=196681
998
999         Reviewed by Darin Adler.
1000
1001         Added tests.
1002
1003         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1004         (WTF_HashSet.RemoveIf):
1005         (WTF_HashSet.RemoveIfShrinkToBestSize):
1006
1007 2019-04-15  John Wilander  <wilander@apple.com>
1008
1009         Send delayed Ad Click Attribution conversion requests to the click source
1010         https://bugs.webkit.org/show_bug.cgi?id=196838
1011         <rdar://problem/47650157>
1012
1013         Reviewed by Chris Dumez and Youenn Fablet.
1014
1015         This patch adds test infrastructure to override the default behavior in
1016         WebKit::NetworkAdClickAttribution.
1017
1018         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1019         (TestWebKitAPI::TEST):
1020         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1021         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1022         (WTR::TestRunner::dumpAdClickAttribution):
1023         (WTR::TestRunner::clearAdClickAttribution):
1024         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1025         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1026         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1027         * WebKitTestRunner/TestController.cpp:
1028         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
1029         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
1030         * WebKitTestRunner/TestController.h:
1031         * WebKitTestRunner/TestInvocation.cpp:
1032         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1033
1034 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1035
1036         [ews-app] status-bubble should display position in queue
1037         https://bugs.webkit.org/show_bug.cgi?id=196607
1038
1039         Reviewed by Lucas Forschler.
1040
1041         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1042         (StatusBubble._build_bubble):
1043         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1044
1045 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1046
1047         [ews-build] Do not run clean build by default on EWS builders
1048         https://bugs.webkit.org/show_bug.cgi?id=196897
1049
1050         Reviewed by Lucas Forschler.
1051
1052         * BuildSlaveSupport/ews-build/steps.py:
1053         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1054         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1055         untracked directories like WebKitBuild).
1056         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1057         untracked files/directories (like WebKitBuild).
1058
1059 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1060
1061         TestRunner::notifyDone() should be safely reentrant
1062         https://bugs.webkit.org/show_bug.cgi?id=196898
1063
1064         Reviewed by Darin Adler.
1065
1066         It is currently possible that TestRunner::notifyDone() will call itself, since
1067         notifyDone() will force a repaint, which can start executing JavaScript, which
1068         may call notifyDone() again. This can lead to test failures and flakiness.
1069         Fix this by setting the m_waitToDump flag before calling the dump() method.
1070
1071         * DumpRenderTree/mac/TestRunnerMac.mm:
1072         (TestRunner::notifyDone):
1073         (TestRunner::forceImmediateCompletion):
1074         * DumpRenderTree/win/TestRunnerWin.cpp:
1075         (TestRunner::notifyDone):
1076         (TestRunner::forceImmediateCompletion):
1077
1078 2019-04-15  Philippe Normand  <pnormand@igalia.com>
1079
1080         [GTK][WPE] Add enable-media websetting
1081         https://bugs.webkit.org/show_bug.cgi?id=196863
1082
1083         Reviewed by Michael Catanzaro.
1084
1085         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1086         (testWebKitSettings): Add test for the enable-media web-setting.
1087
1088 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1089
1090         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1091         https://bugs.webkit.org/show_bug.cgi?id=196905
1092         <rdar://problem/49886096>
1093
1094         Reviewed by Tim Horton.
1095
1096         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1097         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1098         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1099         delay timer, we end up with this sequence of events in the problematic (failure) case:
1100
1101         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1102             ...IPC from UI to web process...
1103         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1104             ...IPC from web to UI process...
1105         (c) [UI]    Invoke completion handler for script #1
1106         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1107             ...IPC from UI to web process...
1108         (e) [Web]   Evaluate script #2 in the web process
1109         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1110
1111         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1112         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1113         #2 is run in step (e).
1114
1115         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1116         the UI process by waiting on a script message posted by the web process, after attachment updates are
1117         dispatched.
1118
1119         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1120         (TestWebKitAPI::TEST):
1121
1122 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1123
1124         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1125         https://bugs.webkit.org/show_bug.cgi?id=196909
1126
1127         Reviewed by Wenson Hsieh.
1128
1129         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1130         (TestWebKitAPI::TEST):
1131
1132 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1133
1134         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1135         https://bugs.webkit.org/show_bug.cgi?id=196880
1136
1137         Reviewed by Yusuke Suzuki.
1138
1139         Add a new function for bytecode cache tests that does not forceDiskCache
1140         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1141         test added in this patch, since the code is invalid and therefore won't be
1142         cached. It should also be useful for tests that evaluate dynamically
1143         generated code.
1144
1145         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1146         * Scripts/run-jsc-stress-tests:
1147
1148 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1149
1150         Update AudioSession route sharing policy
1151         https://bugs.webkit.org/show_bug.cgi?id=196776
1152         <rdar://problem/46501611>
1153
1154         Reviewed by Jer Noble.
1155
1156         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1157         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1158         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1159         (TestWebKitAPI::TEST):
1160
1161 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1162
1163         [iOS] Software keyboard is shown too frequently on some websites
1164         https://bugs.webkit.org/show_bug.cgi?id=195856
1165         <rdar://problem/49191395>
1166
1167         Reviewed by Darin Adler.
1168
1169         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1170
1171         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1172         (WTR::UIScriptController::setHardwareKeyboardAttached):
1173         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1174         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1175         (WTR::UIScriptController::setHardwareKeyboardAttached):
1176         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1177         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1178
1179         Additionally link against GraphicsServices in WebKitTestRunner.
1180
1181         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1182         (WTR::TestController::platformResetStateToConsistentValues):
1183         (WTR::UIScriptController::setHardwareKeyboardAttached):
1184
1185 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1186
1187         [GTK][WPE] Fix pacman install-dependencies packages
1188         https://bugs.webkit.org/show_bug.cgi?id=196817
1189
1190         Reviewed by Žan Doberšek.
1191         
1192         python3-setuptools is called python-setuptools
1193         ruby-highline is only available on AUR
1194         libv4l-devel is incorporated in v4l-utils
1195
1196         * gtk/install-dependencies:
1197         * wpe/install-dependencies:
1198
1199 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1200
1201         [GTK] REGRESSION(r243860): Many tests failing
1202         https://bugs.webkit.org/show_bug.cgi?id=196791
1203
1204         Reviewed by Joanmarie Diggs.
1205
1206         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1207         multiple documents and check that accessibility hierarchy is updated after a navigation.
1208
1209         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1210         (loadChangedCallback):
1211         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1212         (AccessibilityTest::AccessibilityTest):
1213         (AccessibilityTest::~AccessibilityTest):
1214         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1215         (AccessibilityTest::findTestServerApplication):
1216         (AccessibilityTest::findDocumentWeb):
1217         (AccessibilityTest::findRootObject):
1218         (AccessibilityTest::waitUntilChildrenRemoved):
1219         (AccessibilityTest::ensureProxy):
1220         (testAtspiBasicHierarchy):
1221         (beforeAll):
1222         (afterAll):
1223
1224 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1225
1226         [ews-build] Handle bug titles with unicode characters
1227         https://bugs.webkit.org/show_bug.cgi?id=196802
1228
1229         Reviewed by Dewei Zhu.
1230
1231         * BuildSlaveSupport/ews-build/steps.py:
1232         (ValidatePatch._is_bug_closed):
1233
1234 2019-04-11  Michael Saboff  <msaboff@apple.com>
1235
1236         Improve the Inline Cache Stats code
1237         https://bugs.webkit.org/show_bug.cgi?id=196836
1238
1239         Reviewed by Saam Barati.
1240
1241         Added a new script to consolidate and arrange the output of --useICStats option.
1242
1243         This script merges the output from every group into one large table and sorts it from most common to
1244         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1245         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1246         Put together, this is useful to see what property accesses are not getting cached.
1247
1248         * Scripts/ic-stats.py: Added.
1249         (ICStats):
1250         (ICStats.__init__):
1251         (ICStats.parse):
1252         (ICStats.dumpStats):
1253         (usage):
1254
1255 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1256
1257         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1258         https://bugs.webkit.org/show_bug.cgi?id=196809
1259         <rdar://49800762>
1260
1261         Reviewed by Brady Eidson.
1262
1263         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1264         (TEST):
1265
1266 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1267
1268         requestAnimationFrame should execute before the next frame
1269         https://bugs.webkit.org/show_bug.cgi?id=177484
1270
1271         Reviewed by Simon Fraser.
1272
1273         Add trace points for the page RenderingUpdate.
1274
1275         * Tracing/SystemTracePoints.plist:
1276
1277 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1278
1279         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1280         https://bugs.webkit.org/show_bug.cgi?id=196760
1281
1282         Reviewed by Don Olmstead.
1283
1284         vswhere.exe has been bundled since Visual Studio 2017 version
1285         15.2. We shouldn't download vswhere.exe.
1286
1287         * Scripts/build-jsc: Do not call update-vswhere.py.
1288         * Scripts/build-webkit: Ditto.
1289         * Scripts/update-vswhere.py: Removed.
1290         * Scripts/webkitdirs.pm:
1291         (requireModulesForVSWhere): Deleted.
1292         (pickCurrentVisualStudioInstallation): Deleted.
1293         (visualStudioInstallDirVSWhere): Return the latest installed VS
1294         installation path by using the bundled vswhere.exe.
1295         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1296         (visualStudioInstallDirFallback): Removed.
1297
1298 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1299
1300         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1301         https://bugs.webkit.org/show_bug.cgi?id=196780
1302
1303         Reviewed by Alexey Proskuryakov.
1304
1305         * BuildSlaveSupport/ews-build/steps.py:
1306         * BuildSlaveSupport/ews-build/steps_unittest.py:
1307
1308 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1309
1310         Add SPI WKNavigationResponse._downloadAttribute
1311         https://bugs.webkit.org/show_bug.cgi?id=196755
1312         <rdar://49587365>
1313
1314         Reviewed by Brady Eidson.
1315
1316         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1317         (-[NavigationResponseTestDelegate navigationResponse]):
1318         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1319         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1320         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1321         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1322         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1323         (readRequest):
1324         (writeResponse):
1325         (TEST):
1326
1327 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1328
1329         Add modern API for overriding the page's specified viewport configuration
1330         https://bugs.webkit.org/show_bug.cgi?id=167734
1331         <rdar://problem/30331795>
1332
1333         Reviewed by Simon Fraser.
1334
1335         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1336         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1337
1338 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1339
1340         Add support for incremental bytecode cache updates
1341         https://bugs.webkit.org/show_bug.cgi?id=195000
1342
1343         Reviewed by Filip Pizlo.
1344
1345         Exit when the initial run to generate bytecode fails.
1346
1347         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1348
1349 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1350
1351         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1352         https://bugs.webkit.org/show_bug.cgi?id=196744
1353         <rdar://49415309>
1354
1355         Reviewed by Chris Dumez.
1356
1357         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1358         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1359
1360 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1361
1362         Add a way to opt into modern compatibility mode in layout tests
1363         https://bugs.webkit.org/show_bug.cgi?id=196770
1364         <rdar://problem/49777550>
1365
1366         Reviewed by Antoine Quint.
1367
1368         Add a new test option to enable modern compatibility mode in layout tests.
1369
1370         * WebKitTestRunner/TestController.cpp:
1371         (WTR::updateTestOptionsFromTestHeader):
1372         * WebKitTestRunner/TestController.h:
1373         * WebKitTestRunner/TestOptions.h:
1374         (WTR::TestOptions::hasSameInitializationOptions const):
1375         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1376         (WTR::TestController::platformCreateWebView):
1377         (WTR::TestController::enableModernCompatibilityMode):
1378
1379 2019-04-10  Andy Estes  <aestes@apple.com>
1380
1381         Try to fix the 32-bit watchOS build.
1382
1383         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1384         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1385
1386 2019-04-10  Antoine Quint  <graouts@apple.com>
1387
1388         Enable Pointer Events on watchOS
1389         https://bugs.webkit.org/show_bug.cgi?id=196771
1390         <rdar://problem/49040909>
1391
1392         Reviewed by Dean Jackson.
1393
1394         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1395
1396 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1397
1398         Unreviewed. Fix WPE accessibility tests after r244059.
1399
1400         We are failing to load the injected bundle due to undefined symbol
1401         AccessibilityUIElement::replaceTextInRange().
1402
1403         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1404         (WTR::AccessibilityUIElement::replaceTextInRange):
1405
1406 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1407
1408         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1409         https://bugs.webkit.org/show_bug.cgi?id=196727
1410
1411         Reviewed by Fujii Hironori.
1412
1413         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1414         (WebKitBrowserWindow::create):
1415
1416 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1417
1418         [ews-build] Add unit tests for PrintConfiguration
1419         https://bugs.webkit.org/show_bug.cgi?id=196752
1420
1421         Reviewed by Dewei Zhu.
1422
1423         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1424
1425 2019-04-09  Keith Rollin  <krollin@apple.com>
1426
1427         Unreviewed build maintenance -- update .xcfilelists.
1428
1429         * DumpRenderTree/DerivedSources-input.xcfilelist:
1430         * DumpRenderTree/DerivedSources-output.xcfilelist:
1431
1432 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1433
1434         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1435         https://bugs.webkit.org/show_bug.cgi?id=196743
1436         <rdar://problem/43897551>
1437
1438         Reviewed by Tim Horton.
1439
1440         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1441         (TEST):
1442
1443 2019-04-09  Youenn Fablet  <youenn@apple.com>
1444
1445         Close service worker database on network process suspension
1446         https://bugs.webkit.org/show_bug.cgi?id=196623
1447         <rdar://problem/48930869>
1448
1449         Reviewed by Alex Christensen.
1450
1451         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1452
1453 2019-04-09  Daniel Bates  <dabates@apple.com>
1454
1455         [iPad] Should open popover when the spacebar is pressed
1456         https://bugs.webkit.org/show_bug.cgi?id=196360
1457         <rdar://problem/49389129>
1458
1459         Reviewed by Brent Fulgham.
1460
1461         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1462
1463         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1464         (WTR::UIScriptController::isShowingPopover const): Added.
1465         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1466         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1467         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1468         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1469         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1470         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1471         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1472         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1473         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1474         (WTR::UIScriptController::isShowingPopover const): Added.
1475         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1476         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1477         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1478         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1479         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1480         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1481         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1482         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1483         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1484         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1485         (WTR::UIScriptController::isShowingPopover const): Added.
1486         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1487         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1488
1489 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1490
1491         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1492         https://bugs.webkit.org/show_bug.cgi?id=196665
1493         <rdar://45115669>
1494
1495         Reviewed by Geoff Garen.
1496
1497         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1498         (goBack):
1499         (+[SimpleLookupContext sharedLookupContext]):
1500         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1501         (TEST):
1502         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1503         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1504
1505 2019-04-09  John Wilander  <wilander@apple.com>
1506
1507         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1508         https://bugs.webkit.org/show_bug.cgi?id=196558
1509         <rdar://problem/47650245>
1510
1511         Reviewed by Youenn Fablet.
1512
1513         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1514         (TestWebKitAPI::TEST):
1515             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1516
1517 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1518
1519         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1520         https://bugs.webkit.org/show_bug.cgi?id=196720
1521
1522         Reviewed by Konstantin Tokarev.
1523
1524         * TestWebKitAPI/PlatformMac.cmake:
1525
1526 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1527
1528         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1529         https://bugs.webkit.org/show_bug.cgi?id=196694
1530         <rdar://problem/48388734>
1531
1532         Rubber-stamped by Aakash Jain.
1533
1534         * Scripts/webkitpy/port/image_diff.py:
1535         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1536         * Scripts/webkitpy/port/server_process.py:
1537         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1538         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1539         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1540         * Scripts/webkitpy/port/server_process_mock.py:
1541         (MockServerProcess.has_available_stdout):
1542         * Scripts/webkitpy/port/server_process_unittest.py:
1543         (TestServerProcess.serial_test_basic):
1544
1545 2019-04-09  Jer Noble  <jer.noble@apple.com>
1546
1547         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1548         https://bugs.webkit.org/show_bug.cgi?id=196097
1549
1550         Reviewed by Eric Carlson.
1551
1552         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1553
1554         * DumpRenderTree/mac/DumpRenderTree.mm:
1555         (resetWebPreferencesToConsistentValues):
1556         * WebKitTestRunner/TestController.cpp:
1557         (WTR::TestController::resetPreferencesToConsistentValues):
1558
1559 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1560
1561         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1562         https://bugs.webkit.org/show_bug.cgi?id=196690
1563
1564         Reviewed by Michael Catanzaro.
1565
1566         * QueueStatusServer/config/queues.py:
1567         * Scripts/webkitpy/common/config/ews.json:
1568         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1569         (test_ews_name):
1570
1571 2019-04-09  Chris Dumez  <cdumez@apple.com>
1572
1573         Loads using loadHTMLString() cause flashing when process-swapping
1574         https://bugs.webkit.org/show_bug.cgi?id=196714
1575         <rdar://problem/49637354>
1576
1577         Reviewed by Antti Koivisto.
1578
1579         Add API test coverage.
1580
1581         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1582
1583 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1584
1585         Unreviewed. Fix ATK accessibility tests after r244059.
1586
1587         We are failing to load the injected bundle due to undefined symbol
1588         AccessibilityUIElement::replaceTextInRange().
1589
1590         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1591         (WTR::AccessibilityUIElement::replaceTextInRange):
1592
1593 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1594
1595         AX: Support API: accessibilityReplaceRange:withText
1596         https://bugs.webkit.org/show_bug.cgi?id=196636
1597
1598         Unreviewed build fix for Windows port.
1599
1600         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1601         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1602
1603 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1604
1605         [CMake][WinCairo] Separate copied headers into different directories
1606         https://bugs.webkit.org/show_bug.cgi?id=196655
1607
1608         Reviewed by Michael Catanzaro.
1609
1610         * DumpRenderTree/CMakeLists.txt:
1611         * MiniBrowser/win/CMakeLists.txt:
1612         * TestWebKitAPI/CMakeLists.txt:
1613         * TestWebKitAPI/PlatformWin.cmake:
1614
1615 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1616
1617         Log stack-trace for run-webkit-tests when interrupted
1618         https://bugs.webkit.org/show_bug.cgi?id=176393
1619         <rdar://problem/34262310>
1620
1621         Reviewed by Lucas Forschler.
1622
1623         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1624         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1625         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1626         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1627         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1628         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1629         (main): Set handlers to log stack trace on interruption.
1630
1631 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1632
1633         AX: Support API: accessibilityReplaceRange:withText
1634         https://bugs.webkit.org/show_bug.cgi?id=196636
1635
1636         Unreviewed build fix for Windows port.
1637
1638         * DumpRenderTree/AccessibilityUIElement.cpp:
1639         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1640
1641 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1642
1643         [ews-build] Scripts using Buildbot API have CORS error
1644         https://bugs.webkit.org/show_bug.cgi?id=196709
1645
1646         Reviewed by Alexey Proskuryakov.
1647
1648         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1649
1650 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1651
1652         AX: Support API: accessibilityReplaceRange:withText
1653         https://bugs.webkit.org/show_bug.cgi?id=196636
1654
1655         Reviewed by Daniel Bates.
1656
1657         * DumpRenderTree/AccessibilityUIElement.cpp:
1658         (replaceTextInRangeCallback):
1659         (AccessibilityUIElement::replaceTextInRange):
1660         (AccessibilityUIElement::getJSClass):
1661         * DumpRenderTree/AccessibilityUIElement.h:
1662         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1663         (AccessibilityUIElement::replaceTextInRange):
1664         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1665         (AccessibilityUIElement::replaceTextInRange):
1666         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1667         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1668         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1669         (WTR::AccessibilityUIElement::replaceTextInRange):
1670         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1671         (WTR::AccessibilityUIElement::replaceTextInRange):
1672
1673 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1674
1675         [iOS] Do not allow starting selection drags when selection views are not visible
1676         https://bugs.webkit.org/show_bug.cgi?id=196686
1677         <rdar://problem/49399192>
1678
1679         Reviewed by Tim Horton.
1680
1681         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1682         also add some new API tests to cover scenarios where the web view is not first responder.
1683
1684         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1685         (TestWebKitAPI::TEST):
1686         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1687
1688         Add a switch to optionally make the web view first responder when starting the simulated drag.
1689
1690         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1691         (-[DragAndDropSimulator initWithWebView:]):
1692         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1693
1694 2019-04-08  Justin Fan  <justin_fan@apple.com>
1695
1696         [Web GPU] Fix Web GPU experimental feature on iOS
1697         https://bugs.webkit.org/show_bug.cgi?id=196632
1698
1699         Reviewed by Myles C. Maxfield.
1700
1701         Properly make Web GPU available on iOS 11+.
1702
1703         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1704
1705 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1706
1707         [ews-build] Do not upload archive when Compile Fails
1708         https://bugs.webkit.org/show_bug.cgi?id=196674
1709
1710         Reviewed by Alexey Proskuryakov.
1711
1712         * BuildSlaveSupport/ews-build/factories.py:
1713         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1714         * BuildSlaveSupport/ews-build/steps.py:
1715         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1716         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1717         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1718
1719 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1720
1721         Enable DFG on MIPS
1722         https://bugs.webkit.org/show_bug.cgi?id=196689
1723
1724         Reviewed by Žan Doberšek.
1725
1726         Since the bytecode change, we enabled the baseline JIT on mips in
1727         r240432, but DFG is still missing. With this change, all tests are
1728         passing on a ci20 board.
1729
1730         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1731
1732 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1733
1734         [Flatpak] Second run update-webkitwpe-flatpak fails
1735         https://bugs.webkit.org/show_bug.cgi?id=192702
1736
1737         Reviewed by Carlos Garcia Campos.
1738
1739         * flatpak/flatpakutils.py:
1740         (FlatpakObject.flatpak): Fix typo.
1741         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1742         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1743
1744 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1745
1746         [GTK][WPE] outlook.live.com displays old-fashioned UI
1747         https://bugs.webkit.org/show_bug.cgi?id=196642
1748
1749         Reviewed by Carlos Garcia Campos.
1750
1751         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1752         (TestWebKitAPI::TEST): New Mac platform quirk test.
1753
1754 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1755
1756         Unreviewed, rolling out r243956.
1757         https://bugs.webkit.org/show_bug.cgi?id=196688
1758
1759         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1760         by aakashjain on #webkit).
1761
1762         Reverted changeset:
1763
1764         "Clicking "Go Back" from a safe browsing warning from an
1765         iframe should navigate the WKWebView back to the previous
1766         page"
1767         https://bugs.webkit.org/show_bug.cgi?id=196665
1768         https://trac.webkit.org/changeset/243956
1769
1770 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1771
1772         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1773         https://bugs.webkit.org/show_bug.cgi?id=196669
1774
1775         Reviewed by Geoffrey Garen.
1776
1777         Added three new unit tests for WeakHashSet.
1778
1779         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1780         (WTF_WeakPtr.WeakHashSetConstObjects):
1781         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1782         (WTF_WeakPtr.WeakHashSetComputeSize):
1783
1784 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1785
1786         Hide next and previous form control buttons when WKWebView is editable
1787         https://bugs.webkit.org/show_bug.cgi?id=196672
1788         <rdar://problem/35625321>
1789
1790         Reviewed by Tim Horton.
1791
1792         Add a new API test.
1793
1794         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1795         (-[TestWKWebView lastTrailingBarButtonGroup]):
1796         (TestWebKitAPI::TEST):
1797         * TestWebKitAPI/ios/UIKitSPI.h:
1798
1799 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1800
1801         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1802         https://bugs.webkit.org/show_bug.cgi?id=196077
1803         <rdar://problem/49108202>
1804
1805         Reviewed by Chris Dumez.
1806
1807         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1808         on new web view.
1809
1810         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1811
1812 2019-04-05  Saam Barati  <sbarati@apple.com>
1813
1814         Make compare-results understand MotionMark
1815         https://bugs.webkit.org/show_bug.cgi?id=196666
1816
1817         Reviewed by Yusuke Suzuki.
1818
1819         * Scripts/compare-results:
1820         (PLT5Results):
1821         (detectMotionMark):
1822         (detectMotionMark1_1):
1823         (motionMarkResults):
1824         (motionMark1_1Results):
1825         (detectBenchmark):
1826         (biggerIsBetter):
1827         (main):
1828
1829 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1830
1831         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1832         https://bugs.webkit.org/show_bug.cgi?id=196665
1833         <rdar://45115669>
1834
1835         Reviewed by Geoff Garen.
1836
1837         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1838         (goBack):
1839         (+[SimpleLookupContext sharedLookupContext]):
1840         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1841         (TEST):
1842         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1843         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1844
1845 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1846
1847         [ews-build] Add configuration and architecture for windows builders
1848         https://bugs.webkit.org/show_bug.cgi?id=196660
1849
1850         Reviewed by Lucas Forschler.
1851
1852         * BuildSlaveSupport/ews-build/config.json:
1853
1854 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1855
1856         webkitpy: Don't run subsequent rounds if interrupted
1857         https://bugs.webkit.org/show_bug.cgi?id=196646
1858
1859         Reviewed by Aakash Jain.
1860
1861         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1862         (Manager.run): Bail out if interrupted.
1863
1864 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1865
1866         Test sessionStorage in PSON private browsing mode
1867         https://bugs.webkit.org/show_bug.cgi?id=196561
1868
1869         Reviewed by Alex Christensen.
1870
1871         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1872
1873 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1874
1875         Unreviewed, rolling out r243833.
1876         https://bugs.webkit.org/show_bug.cgi?id=196645
1877
1878         This change breaks build of WPE and GTK ports (Requested by
1879         annulen on #webkit).
1880
1881         Reverted changeset:
1882
1883         "[CMake][WTF] Mirror XCode header directories"
1884         https://bugs.webkit.org/show_bug.cgi?id=191662
1885         https://trac.webkit.org/changeset/243833
1886
1887 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1888
1889         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1890         https://bugs.webkit.org/show_bug.cgi?id=196635
1891
1892         Reviewed by Antti Koivisto.
1893         
1894         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1895         for a test to enable async frame scrolling via:
1896             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1897         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1898         
1899         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1900
1901         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1902         (WTR::InjectedBundle::beginTesting):
1903         * WebKitTestRunner/TestController.cpp:
1904         (WTR::TestController::resetPreferencesToConsistentValues):
1905
1906 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1907
1908         Use a correct LC_RPATH when building with ASan
1909         https://bugs.webkit.org/show_bug.cgi?id=196576
1910
1911         Reviewed by David Kilzer.
1912
1913         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1914         so that ../Frameworks is checked. This is simpler and more reliable than updating
1915         each SPC service xcconfig.
1916
1917 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1918
1919         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1920         https://bugs.webkit.org/show_bug.cgi?id=196629
1921
1922         Reviewed by Lucas Forschler.
1923
1924         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1925
1926 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1927
1928         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1929         https://bugs.webkit.org/show_bug.cgi?id=196618
1930
1931         Reviewed by Lucas Forschler.
1932
1933         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1934         (StatusBubble): Added QUEUE_TRIGGERS.
1935         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1936         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1937         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1938         its parent(builder).
1939
1940 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1941
1942         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1943         https://bugs.webkit.org/show_bug.cgi?id=196625
1944
1945         Reviewed by Lucas Forschler.
1946
1947         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1948         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1949
1950 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1951
1952         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1953         https://bugs.webkit.org/show_bug.cgi?id=196630
1954
1955         Reviewed by Wenson Hsieh.
1956
1957         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1958
1959 2019-04-04  Youenn Fablet  <youenn@apple.com>
1960
1961         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1962         https://bugs.webkit.org/show_bug.cgi?id=196543
1963
1964         Reviewed by Alex Christensen.
1965
1966         * WebKitTestRunner/TestController.cpp:
1967         (WTR::TestController::generatePageConfiguration):
1968
1969 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1970
1971         [ews-app] Status bubble should not display skipped buildbot steps
1972         https://bugs.webkit.org/show_bug.cgi?id=196584
1973
1974         Reviewed by Lucas Forschler.
1975
1976         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1977
1978 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1979
1980         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1981         https://bugs.webkit.org/show_bug.cgi?id=196620
1982
1983         Reviewed by Lucas Forschler.
1984
1985         * BuildSlaveSupport/ews-app/ews/config.py:
1986
1987 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1988
1989         [Win] DumpRenderTreeWatchDog.py is not checked into source
1990         https://bugs.webkit.org/show_bug.cgi?id=196567
1991         <rdar://problem/49525901>
1992
1993         Reviewed by Lucas Forschler.
1994
1995         This script is used on Win EWS bots to terminate hanging DRT processes.
1996
1997         * EWSTools/dumprendertreewatchdog.py: Added.
1998
1999 2019-04-04  Chris Dumez  <cdumez@apple.com>
2000
2001         Unreviewed, roll out r243858 which made tests time out.
2002
2003         Disable new API tests on Windows instead.
2004
2005         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2006         (TestWebKitAPI::TEST):
2007
2008 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2009
2010         [ATK] Cleanup WebPageAccessibilityObjectAtk
2011         https://bugs.webkit.org/show_bug.cgi?id=196537
2012
2013         Reviewed by Michael Catanzaro.
2014
2015         Also consider files under atk directories as exceptions for GObject conventions.
2016
2017         * Scripts/webkitpy/style/checkers/cpp.py:
2018         (check_identifier_name_in_declaration):
2019
2020 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2021
2022         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2023         https://bugs.webkit.org/show_bug.cgi?id=196588
2024         <rdar://problem/49365787>
2025
2026         Unreviewed build fix for Windows port.
2027
2028         error C3861: 'kill': identifier not found
2029
2030         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2031         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2032
2033 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2034
2035         [ews-build] Cancel build and similar operations should have authentication
2036         https://bugs.webkit.org/show_bug.cgi?id=196520
2037
2038         Reviewed by Dewei Zhu.
2039
2040         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2041         environment variables.
2042
2043 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2044
2045         [ews-build] Do not trigger queues which are not in production yet
2046         https://bugs.webkit.org/show_bug.cgi?id=196581
2047
2048         Reviewed by Dewei Zhu.
2049
2050         * BuildSlaveSupport/ews-build/config.json:
2051
2052 2019-04-03  Chris Dumez  <cdumez@apple.com>
2053
2054         Unreviewed, fix typo in the name of API test added in r243848.
2055
2056         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2057         (TestWebKitAPI::TEST):
2058
2059 2019-04-03  Chris Dumez  <cdumez@apple.com>
2060
2061         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2062         https://bugs.webkit.org/show_bug.cgi?id=196588
2063         <rdar://problem/49365787>
2064
2065         Reviewed by Ryosuke Niwa.
2066
2067         Add API test coverage.
2068
2069         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2070         (TestWebKitAPI::nullJavaScriptCallback):
2071         (TestWebKitAPI::didCrashCheckFrames):
2072         (TestWebKitAPI::TEST):
2073
2074 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2075
2076         run-webkit-tests: Upload test results (new results database)
2077         https://bugs.webkit.org/show_bug.cgi?id=196577
2078         <rdar://problem/34841155>
2079
2080         Reviewed by Lucas Forschler.
2081
2082         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2083         (Manager.run): Upload results after each device shard, since the configuration will be
2084         different for each device.
2085         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2086         uploaded to a results database.
2087         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2088         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2089
2090 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2091
2092         -apple-trailing-word is needed for browser detection
2093         https://bugs.webkit.org/show_bug.cgi?id=196575
2094
2095         Unreviewed.
2096
2097         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2098
2099 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2100
2101         [CMake][WTF] Mirror XCode header directories
2102         https://bugs.webkit.org/show_bug.cgi?id=191662
2103
2104         Reviewed by Konstantin Tokarev.
2105
2106         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2107         builds.
2108
2109         * CMakeLists.txt:
2110         * DumpRenderTree/CMakeLists.txt:
2111         * DumpRenderTree/PlatformWin.cmake:
2112         * MiniBrowser/win/CMakeLists.txt:
2113         * TestWebKitAPI/CMakeLists.txt:
2114         * TestWebKitAPI/PlatformWin.cmake:
2115         * WebKitTestRunner/PlatformGTK.cmake:
2116         * WebKitTestRunner/PlatformWin.cmake:
2117
2118 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2119
2120         [ews-app] Status bubble should not display certain infrastructure status messages
2121         https://bugs.webkit.org/show_bug.cgi?id=196550
2122
2123         Reviewed by Lucas Forschler.
2124
2125         Do not display the steps which are un-needed for end-user. This information is still avaiable
2126         if the user click on the bubble and look at the Buildbot build.
2127         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2128         (StatusBubble._steps_messages):
2129         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2130
2131 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2132
2133         [ews-build] Use https for sending data to ews-app
2134         https://bugs.webkit.org/show_bug.cgi?id=196492
2135
2136         Reviewed by Lucas Forschler.
2137
2138         * BuildSlaveSupport/ews-build/events.py:
2139
2140 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2141
2142         Remove support for -apple-trailing-word
2143         https://bugs.webkit.org/show_bug.cgi?id=196525
2144
2145         Reviewed by Zalan Bujtas.
2146
2147         This CSS property is nonstandard and not used.
2148
2149         * Scripts/webkitperl/FeatureList.pm:
2150         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2151
2152 2019-04-03  Youenn Fablet  <youenn@apple.com>
2153
2154         Add a test for DOMCache on multiple browsing in case of private browsing
2155         https://bugs.webkit.org/show_bug.cgi?id=196524
2156
2157         Reviewed by Alex Christensen.
2158
2159         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2160         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2161
2162 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2163
2164         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2165         https://bugs.webkit.org/show_bug.cgi?id=196540
2166
2167         Reviewed by Aakash Jain.
2168
2169         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2170
2171 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2172
2173         Add plumbing for a compatibility mode preference in WebKit
2174         https://bugs.webkit.org/show_bug.cgi?id=196005
2175
2176         Reviewed by Tim Horton.
2177
2178         Add new API tests.
2179
2180         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2181         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2182
2183 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2184
2185         [WPE][GTK] Update libsrtp dependency package for Debian
2186         https://bugs.webkit.org/show_bug.cgi?id=196528
2187
2188         Reviewed by Frédéric Wang.
2189
2190         * gtk/install-dependencies:
2191         * wpe/install-dependencies:
2192
2193 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2194
2195         [WK2] Add support for Window's beforeprint / afterprint events
2196         https://bugs.webkit.org/show_bug.cgi?id=196478
2197         <rdar://problem/49535124>
2198
2199         Unreviewed build fix for MSVC.
2200
2201         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2202
2203         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2204
2205         * WebKitTestRunner/TestController.cpp:
2206         (WTR::printFrame): Use int and float literals.
2207
2208 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2209
2210         [ews-build] Reassign bots to queues
2211
2212         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2213
2214 2019-04-02  Chris Dumez  <cdumez@apple.com>
2215
2216         [WK2] Add support for Window's beforeprint / afterprint events
2217         https://bugs.webkit.org/show_bug.cgi?id=196478
2218
2219         Reviewed by Alex Christensen.
2220
2221         Add minimal implementation for printFrame in WebKitTestRunner.
2222
2223         * WebKitTestRunner/TestController.cpp:
2224         (WTR::printFrame):
2225         (WTR::TestController::createOtherPage):
2226         (WTR::TestController::createWebViewWithOptions):
2227
2228 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2229
2230         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2231         https://bugs.webkit.org/show_bug.cgi?id=196491
2232
2233         Reviewed by Lucas Forschler.
2234
2235         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2236
2237 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2238
2239         [ews-build] Configure buildbot try credentials in environment variables
2240         https://bugs.webkit.org/show_bug.cgi?id=196501
2241
2242         Reviewed by Lucas Forschler.
2243
2244         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2245         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2246         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2247
2248 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2249
2250         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2251         https://bugs.webkit.org/show_bug.cgi?id=196496
2252         <rdar://problem/49521634>
2253
2254         Reviewed by Chris Dumez.
2255
2256         Add new API tests (see WebKit ChangeLog for more detail).
2257
2258         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2259         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2260         (TEST):
2261
2262 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2263
2264         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2265         <https://webkit.org/b/196499>
2266
2267         Reviewed by Alexey Proskuryakov.
2268
2269         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2270         ENABLE_ADDRESS_SANITIZER.
2271
2272 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2273
2274         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2275         https://bugs.webkit.org/show_bug.cgi?id=182757
2276
2277         Reviewed by Don Olmstead.
2278
2279         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2280         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2281
2282 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2283
2284         run-api-tests: Upload test results
2285         https://bugs.webkit.org/show_bug.cgi?id=196323
2286         <rdar://problem/49356714>
2287
2288         Reviewed by Lucas Forschler.
2289
2290         * Scripts/webkitpy/api_tests/manager.py:
2291         (Manager):
2292         (Manager.run): Upload results to a results database.
2293         * Scripts/webkitpy/api_tests/run_api_tests.py:
2294         (parse_args): Add upload arguments.
2295         * Scripts/webkitpy/port/base.py:
2296         (Port):
2297         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2298         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2299         with commits from any other associated repositories.
2300         * Scripts/webkitpy/port/device.py:
2301         (Device):
2302         (Device.build_version): Access build_versoin of underlying platform device.
2303         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2304         (IOSSimulatorTest):
2305         (IOSSimulatorTest.test_configuration_for_upload):
2306         * Scripts/webkitpy/port/device_port.py:
2307         (DevicePort):
2308         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2309         the same as the machine uploading results.
2310         * Scripts/webkitpy/port/mac.py:
2311         (MacPort):
2312         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2313         * Scripts/webkitpy/port/mac_unittest.py:
2314         (MacTest):
2315         (MacTest.test_configuration_for_upload):
2316         * Scripts/webkitpy/xcode/simulated_device.py:
2317         (SimulatedDeviceManager._create_device_with_runtime):
2318         (SimulatedDevice.__init__): Create simulated device with a build_version.
2319         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2320         (test_existing_simulator):
2321
2322 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2323
2324         Remove extra newline characters (Follow-up fix to r243707)
2325
2326         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2327
2328 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2329
2330         [ews-app] Use API_KEY to accept results data
2331         https://bugs.webkit.org/show_bug.cgi?id=196461
2332
2333         Reviewed by Dewei Zhu.
2334
2335         * BuildSlaveSupport/ews-app/ews/views/results.py:
2336         (Results.post): Validate EWS_API_KEY before accepting any data.
2337         * BuildSlaveSupport/ews-build/events.py:
2338         (Events.sendData): Send EWS_API_KEY if available along with event data.
2339
2340 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2341
2342         Unable to copy and paste a PDF from Notes into Mail compose body
2343         https://bugs.webkit.org/show_bug.cgi?id=196442
2344         <rdar://problem/48573098>
2345
2346         Reviewed by Tim Horton.
2347
2348         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2349         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2350         to be specified on the item providers.
2351
2352         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2353         (TestWebKitAPI::mapItemForTesting):
2354         (TestWebKitAPI::contactItemForTesting):
2355
2356 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2357
2358         Make UIWKDocumentContext rects per-character instead of per-word
2359         https://bugs.webkit.org/show_bug.cgi?id=196459
2360
2361         Reviewed by Wenson Hsieh.
2362
2363         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2364         (TEST):
2365         Adjust test results due to switching to per-character rects.
2366
2367 2019-04-01  Chris Dumez  <cdumez@apple.com>
2368
2369         UIProcess crash when a prewarmed process is terminated
2370         https://bugs.webkit.org/show_bug.cgi?id=196451
2371         <rdar://problem/49245471>
2372
2373         Reviewed by Geoffrey Garen.
2374
2375         Add API test coverage.
2376
2377         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2378         (TEST):
2379
2380 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2381
2382         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2383         https://bugs.webkit.org/show_bug.cgi?id=196449
2384
2385         Reviewed by Lucas Forschler.
2386
2387         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2388         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2389         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2390         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2391
2392 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2393
2394         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2395         https://bugs.webkit.org/show_bug.cgi?id=196444
2396
2397         Reviewed by Lucas Forschler.
2398
2399         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2400
2401 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2402
2403         Add SPI to canonicalize NSURLs with WTF::URL
2404         https://bugs.webkit.org/show_bug.cgi?id=196415
2405         <rdar://problem/44980271>
2406
2407         Reviewed by Darin Adler.
2408
2409         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2410         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2411         (TestWebKitAPI::TEST):
2412
2413 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2414
2415         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2416         https://bugs.webkit.org/show_bug.cgi?id=196441
2417
2418         Reviewed by Carlos Garcia Campos.
2419
2420         Don't cache the wpe_view_backend object that might not exist yet at the
2421         time of EventSenderProxy constructor invocation, but instead retrieve
2422         that object whenever it's required for event dispatching. This should
2423         avoid crashes in this constructor now that it's invoked before any
2424         PlatformWindow has been set up (as changed in r243496).
2425
2426         * WebKitTestRunner/EventSenderProxy.h:
2427         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2428         (WTR::viewBackend):
2429         (WTR::EventSenderProxy::EventSenderProxy):
2430         (WTR::EventSenderProxy::mouseDown):
2431         (WTR::EventSenderProxy::mouseUp):
2432         (WTR::EventSenderProxy::mouseMoveTo):
2433         (WTR::EventSenderProxy::mouseScrollBy):
2434         (WTR::EventSenderProxy::keyDown):
2435         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2436
2437 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2438
2439         [Win][WebKit] MiniBrowser should support high DPI display
2440         https://bugs.webkit.org/show_bug.cgi?id=196391
2441
2442         Reviewed by Alex Christensen.
2443
2444         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2445         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2446         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2447         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2448
2449 2019-03-31  Sam Weinig  <weinig@apple.com>
2450
2451         Remove more i386 specific configurations
2452         https://bugs.webkit.org/show_bug.cgi?id=196430
2453
2454         Reviewed by Alexey Proskuryakov.
2455
2456         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2457         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2458
2459 2019-03-31  Andy Estes  <aestes@apple.com>
2460
2461         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2462         https://bugs.webkit.org/show_bug.cgi?id=196433
2463         <rdar://problem/49293305>
2464
2465         Reviewed by Tim Horton.
2466
2467         Enhanced API test coverage to include all navigation response policy decisions in both
2468         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2469
2470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2471         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2472         (TestWebKitAPI::TEST):
2473         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2474         (readFile):
2475         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2476         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2477         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2478         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2479         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2480         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2481         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2482         (-[QuickLookDelegate _downloadDidStart:]):
2483         (-[QuickLookDelegate _download:didReceiveResponse:]):
2484         (-[QuickLookDelegate _download:didReceiveData:]):
2485         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2486         (-[QuickLookDelegate _downloadDidFinish:]):
2487         (-[QuickLookDelegate _download:didFailWithError:]):
2488         (-[QuickLookDelegate _downloadDidCancel:]):
2489         (-[QuickLookDelegate verifyDownload]):
2490         (runTest):
2491         (runTestDecideBeforeLoading):
2492         (runTestDecideAfterLoading):
2493         (TEST):
2494         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2495         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2496         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2497         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2498         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2499         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2500         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2501         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2502         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2503         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2504         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2505         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2506         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2507         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2508
2509 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2510
2511         [CMake] add testdfg as target with build-jsc
2512         https://bugs.webkit.org/show_bug.cgi?id=196393
2513
2514         Reviewed by Saam Barati.
2515
2516         Added testdfg as one of the targets to build when
2517         using CMake.
2518
2519         * Scripts/build-jsc:
2520
2521 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2522
2523         Delete WebMetal implementation in favor of WebGPU
2524         https://bugs.webkit.org/show_bug.cgi?id=195418
2525
2526         Reviewed by Dean Jackson.
2527
2528         * DumpRenderTree/mac/DumpRenderTree.mm:
2529         (enableExperimentalFeatures):
2530         (resetWebPreferencesToConsistentValues):
2531         * Scripts/webkitperl/FeatureList.pm:
2532         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2533         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2534         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2535         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2536         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2537         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2538         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2539         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2540         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2541         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2542         (WTR::InjectedBundle::beginTesting):
2543         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2544         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2545         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2546
2547 2019-03-29  Chris Dumez  <cdumez@apple.com>
2548
2549         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2550         https://bugs.webkit.org/show_bug.cgi?id=196405
2551         <rdar://problem/49428130>
2552
2553         Reviewed by Wenson Hsieh.
2554
2555         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2556         the popover presentation methods to be no-ops. Use this in the new test added in
2557         r243523 so that we do not swizzle those methods for all tests. This is needed because
2558         those WatchOS tests rely on the popover getting presented and interactive.
2559
2560         * WebKitTestRunner/TestController.cpp:
2561         (WTR::updateTestOptionsFromTestHeader):
2562         * WebKitTestRunner/TestController.h:
2563         * WebKitTestRunner/TestOptions.h:
2564         (WTR::TestOptions::hasSameInitializationOptions const):
2565         * WebKitTestRunner/ios/TestControllerIOS.mm:
2566         (WTR::TestController::platformInitialize):
2567         (WTR::TestController::platformResetStateToConsistentValues):
2568
2569 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2570
2571         [Curl] Add Server Trust Evaluation Support.
2572         https://bugs.webkit.org/show_bug.cgi?id=191646
2573
2574         Reviewed by Fujii Hironori.
2575
2576         Implemented MiniBrowser UI for asking if user trusts the server.
2577
2578         * MiniBrowser/win/Common.cpp:
2579         (askServerTrustEvaluation):
2580         (replaceString):
2581         * MiniBrowser/win/Common.h:
2582         * MiniBrowser/win/MiniBrowserLib.rc:
2583         * MiniBrowser/win/MiniBrowserLibResource.h:
2584         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2585         (createPEMString):
2586         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2587         (WebKitBrowserWindow::canTrustServerCertificate):
2588         * MiniBrowser/win/WebKitBrowserWindow.h:
2589
2590 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2591
2592         Implement ResizeObserver.
2593         https://bugs.webkit.org/show_bug.cgi?id=157743
2594
2595         Reviewed by Simon Fraser.
2596
2597         Support resizeObserverEnabled webPreferences.
2598
2599         * DumpRenderTree/TestOptions.cpp:
2600         (TestOptions::TestOptions):
2601         * DumpRenderTree/TestOptions.h:
2602         * DumpRenderTree/mac/DumpRenderTree.mm:
2603         (setWebPreferencesForTestOptions):
2604         * DumpRenderTree/win/DumpRenderTree.cpp:
2605         (enableExperimentalFeatures):
2606         * Scripts/webkitperl/FeatureList.pm:
2607         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2608
2609 2019-03-28  John Wilander  <wilander@apple.com>
2610
2611         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2612         https://bugs.webkit.org/show_bug.cgi?id=196281
2613         <rdar://problem/48938748>
2614
2615         Reviewed by Alex Christensen.
2616
2617         This patch adds the function isStatisticsHasLocalStorage() to the
2618         TestRunner. With it, the page can query the WebsiteDataStore in the
2619         UI process to make sure that it sees LocalStorage.
2620
2621         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2622         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2623         (WTR::TestRunner::isStatisticsHasLocalStorage):
2624         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2625         * WebKitTestRunner/TestController.cpp:
2626         (WTR::TestController::isStatisticsHasLocalStorage):
2627         * WebKitTestRunner/TestController.h:
2628         * WebKitTestRunner/TestInvocation.cpp:
2629         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2630
2631 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2632
2633         API::Data::createWithoutCopying should do a null check before calling CFRelease
2634         https://bugs.webkit.org/show_bug.cgi?id=196276
2635         <rdar://problem/48059859>
2636
2637         Reviewed by Alex Christensen.
2638
2639         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2640
2641         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2642         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2643         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2644         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2645         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2646         (TestWebKitAPI::TEST):
2647
2648 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2649
2650         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2651         https://bugs.webkit.org/show_bug.cgi?id=186276
2652
2653         Reviewed by Carlos Garcia Campos.
2654
2655         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2656         (webViewLoadChanged):
2657         (testWebResourceGetDataError):
2658         (testWebResourceGetDataEmpty):
2659         (beforeAll):
2660         (webViewloadChanged): Deleted.
2661
2662 2019-03-27  Andy Estes  <aestes@apple.com>
2663
2664         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2665         https://bugs.webkit.org/show_bug.cgi?id=196317
2666
2667         Reviewed by Dan Bernstein.
2668
2669         package-root copies built products into a staging directory using ditto(1), which does not
2670         follow symbolic links as it traverses a directory. Now that the files in
2671         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2672         itself, these become broken links when ditto'd into the staging directory.
2673
2674         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2675
2676         * Scripts/package-root:
2677
2678 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2679
2680         [ews-app] Update display text of Submit for ews analysis
2681         https://bugs.webkit.org/show_bug.cgi?id=196309
2682
2683         Reviewed by Dewei Zhu.
2684
2685         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2686
2687 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2688
2689         run-webkit-tests should check for leaks in WebKit processes
2690         <https://webkit.org/b/193772>
2691         <rdar://problem/46526680>
2692
2693         Reviewed by Ryosuke Niwa.
2694
2695         This works by doing the following:
2696         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2697           The list of child processes are returned one per line:
2698           process.name: pid
2699         - Run the "#LIST CHILD PROCESSES" command just before the
2700           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2701           processes on the ServerProcess object.
2702         - When the `--leaks` switch is handled, run check_for_leaks() on
2703           each child process after the main test harness.
2704
2705         * DumpRenderTree/mac/DumpRenderTree.mm:
2706         (handleControlCommand):
2707         - Use strncmp() instead of strcmp().
2708         - Add support for handling "#LIST CHILD PROCESSES" command.
2709
2710         * Scripts/webkitpy/port/base.py:
2711         (Port.check_for_leaks):
2712         * Scripts/webkitpy/port/darwin.py:
2713         (DarwinPort.check_for_leaks):
2714         - Rename redundant 'process_pid' argument to 'process_id'.
2715
2716         * Scripts/webkitpy/port/driver.py:
2717         (Driver.do_post_tests_work):
2718         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2719           longer the only command this sends to WebKitTestRunner.
2720         - If the `--leaks` switch is present, send the
2721           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2722           result using Port.set_webkit_processes().
2723         (Driver._parse_child_processes_output):
2724         - Add helper method to parse list of child process names and
2725           process IDs returned from WebKitTestRunner.
2726
2727         * Scripts/webkitpy/port/ios_device.py:
2728         (IOSDevicePort.check_for_leaks):
2729         - Rename redundant 'process_pid' argument to 'process_id'.
2730
2731         * Scripts/webkitpy/port/leakdetector.py:
2732         (LeakDetector._parse_leaks_output):
2733         - Return early if there is no leaks_output.
2734         (LeakDetector.check_for_leaks):
2735         - Rename redundant 'process_pid' argument to 'process_id'.
2736
2737         * Scripts/webkitpy/port/server_process.py:
2738         (ServerProcess.__init__):
2739         (ServerProcess.child_processes):
2740         (ServerProcess.set_child_processes):
2741         - Add instance variable to Port to store list of child process
2742           names and process IDs returned from WebKitTestRunner.
2743         (ServerProcess._start):
2744         - Clear self._child_processes.
2745         (ServerProcess.stop):
2746         - If self._child_processes is set, call
2747           self._port.check_for_leaks() for each child process.
2748
2749         * Scripts/webkitpy/port/server_process_unittest.py:
2750         (TrivialMockPort.check_for_leaks):
2751         - Rename redundant 'process_pid' argument to 'process_id'.
2752
2753         * Scripts/webkitpy/port/simulator_process.py:
2754         (SimulatorProcess.stop):
2755         - If self._child_processes is set, call
2756           self._port.check_for_leaks() for each child process.
2757
2758         * Scripts/webkitpy/port/watch_device.py:
2759         (WatchDevicePort.check_for_leaks):
2760         - Rename redundant 'process_pid' argument to 'process_id'.
2761
2762         * WebKitTestRunner/TestController.cpp:
2763         (WTR::TestController::dumpResponse):
2764         - Extract method from findAndDumpWorldLeaks() so that it may be
2765           reused by findAndDumpWebKitProcessIdentifiers().
2766         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2767         - Add method to output process name and process ID of both the
2768           WebContent and Networking processes.
2769         (WTR::TestController::findAndDumpWorldLeaks):
2770         - Fix missing newline in output when there were no abandoned
2771           documents.
2772         - Call dumpResponse() for extracted code.
2773         (WTR::TestController::handleControlCommand):
2774         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2775         - Use strncmp() instead of strcmp().
2776         - Call findAndDumpWebKitProcessIdentifiers() when
2777           "#LIST CHILD PROCESSES" command is sent.
2778         * WebKitTestRunner/TestController.h:
2779         (WTR::TestController::dumpResponse):
2780         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2781         - Declare methods.
2782
2783 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2784
2785         Unreviewed. Add GLib API test cases after r243434.
2786
2787         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2788         (testWebViewActiveURI):
2789         (serverCallback):
2790         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2791         (sendRequestCallback):
2792
2793 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2794
2795         Geolocation request not complete when watch request was started in a different web process
2796         https://bugs.webkit.org/show_bug.cgi?id=195996
2797
2798         Reviewed by Alex Christensen.
2799
2800         Add a test case.
2801
2802         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2803         (TestWebKitAPI::runJavaScriptAlert):
2804         (TestWebKitAPI::TEST):
2805
2806 2019-03-26  Keith Rollin  <krollin@apple.com>
2807
2808         Update the way generate-xcfilelists returns strings from functions
2809         https://bugs.webkit.org/show_bug.cgi?id=195975
2810         <rdar://problem/49040807>
2811
2812         Reviewed by Dean Jackson.
2813
2814         There are places where generate-xcfilelists executes assignments with
2815         statements like:
2816
2817             FOO=$(some_function)
2818
2819         where "some_function" return a string by echoing it. E.g.
2820
2821             some_function()
2822             {
2823                 echo "Hello, World"
2824             }
2825
2826         This is a common idiom, but it has a problem if "some_function" needs
2827         to call "exit" in an attempt to halt the entire script right then and
2828         there. Since "some_function" is called inside of $(), it's being
2829         executed in a sub-shell. Calling exit in that sub-shell simply exits
2830         that shell; it doesn't not exit the outer shell in which the main part
2831         of the script is still running. As such, the main script keeps
2832         executing when the intent was for the script to halt.
2833
2834         The solution to this is to use a different idiom for returning
2835         strings. The one we now is to pass in the name of the variable to
2836         receive the string result:
2837
2838             some_function()
2839             {
2840                 variable_name=$1
2841                 eval $variable_name ="Hello, World"
2842             }
2843
2844         The call site now looks like
2845
2846             some_function FOO
2847
2848         Because there's no invocation of a sub-shell, some_function can now
2849         call "exit" if it wants to, and the entire script will exit at that
2850         point.
2851
2852         * Scripts/generate-xcfilelists:
2853
2854 2019-03-26  Chris Dumez  <cdumez@apple.com>
2855
2856         Add basic layout test coverage for File Picker on iOS
2857         https://bugs.webkit.org/show_bug.cgi?id=196265
2858
2859         Reviewed by Wenson Hsieh.
2860
2861         Add layout test infrastructure to test the file picker on iOS.
2862
2863         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2864         (WTR::UIScriptController::dismissFilePicker):
2865         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2866         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2867         (WTR::UIScriptController::dismissFilePicker):
2868         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2869         * WebKitTestRunner/TestController.cpp:
2870         (WTR::TestController::createWebViewWithOptions):
2871         (WTR::updateTestOptionsFromTestHeader):
2872         * WebKitTestRunner/TestOptions.h:
2873         (WTR::TestOptions::hasSameInitializationOptions const):
2874         * WebKitTestRunner/ios/TestControllerIOS.mm:
2875         (overridePresentViewController):
2876         (WTR::TestController::platformInitialize):
2877         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2878         (WTR::UIScriptController::dismissFilePicker):
2879
2880 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2881
2882         Implement async paste method on UIWKInteractionViewProtocol
2883         https://bugs.webkit.org/show_bug.cgi?id=196267
2884         <rdar://problem/49236346>
2885
2886         Reviewed by Tim Horton.
2887
2888         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2889         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2890         are now a part of all iOS 12 internal SDKs.
2891
2892         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2893
2894         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2895         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2896
2897         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2898         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2899         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2900         * TestWebKitAPI/ios/UIKitSPI.h:
2901
2902 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2903
2904         [ews-build] Use PostgreSQL for ews.webkit.org database
2905         https://bugs.webkit.org/show_bug.cgi?id=196270
2906
2907         Reviewed by Lucas Forschler.
2908
2909         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2910
2911 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2912
2913         [ews] Reset simctl states on reboot
2914         https://bugs.webkit.org/show_bug.cgi?id=196260
2915
2916         Rubber-stamped by Aakash Jain.
2917
2918         * EWSTools/start-queue-mac.sh:
2919
2920 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2921
2922         [ews-build] Use PostgreSQL for ews-build database
2923         https://bugs.webkit.org/show_bug.cgi?id=196229
2924
2925         Reviewed by Lucas Forschler.
2926
2927         * BuildSlaveSupport/ews-build/master.cfg:
2928
2929 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2930
2931         [ews-build] Get master_hostname dynamically in master.cfg
2932         https://bugs.webkit.org/show_bug.cgi?id=196255
2933
2934         Reviewed by Lucas Forschler.
2935
2936         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2937         send events data in test mode.
2938
2939 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2940
2941         [ews-app] Set db_constraint to False for Foreign Keys
2942         https://bugs.webkit.org/show_bug.cgi?id=196252
2943
2944         Reviewed by Lucas Forschler.
2945
2946         * BuildSlaveSupport/ews-app/ews/models/build.py:
2947         * BuildSlaveSupport/ews-app/ews/models/step.py:
2948
2949 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2950
2951         [ews-build] is_test_mode_enabled should default to True
2952         https://bugs.webkit.org/show_bug.cgi?id=196248
2953
2954         Reviewed by Lucas Forschler.
2955
2956         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2957
2958 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2959
2960         [ews-app] Add webkitperl to ENABLED_QUEUES
2961         https://bugs.webkit.org/show_bug.cgi?id=196253
2962
2963         Reviewed by Lucas Forschler.
2964
2965         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2966
2967 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2968
2969         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2970         https://bugs.webkit.org/show_bug.cgi?id=196211
2971         rdar://problem/49110552
2972
2973         Reviewed by Tim Horton.
2974
2975         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2976         Make sure that EventSenderProxy always exists when running tests. We used to create
2977         it when resetting before the first test, which is a bit too late.
2978
2979         * WebKitTestRunner/TestController.h:
2980         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2981         (WTR::TestController::platformCreateWebView):
2982         (WTR::TestController::platformCreateOtherPage):
2983         (WTR::TestController::finishCreatingPlatformWebView):
2984         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2985         (WTR::PlatformWebView::PlatformWebView):
2986         Moved some code that made NSWindow use NSEvent during web view creation. We may
2987         need to move more if some other case us found, but this is enough for now.
2988
2989 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2990
2991         Unreviewed. Fix typo in GLib geolocation API after r243285.
2992
2993         gelocation -> geolocation.
2994
2995         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2996         (testGeolocationManagerWatchPosition):
2997
2998 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2999
3000         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3001         https://bugs.webkit.org/show_bug.cgi?id=196213
3002
3003         Reviewed by Geoff Garen.
3004
3005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3006         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3007         (credentialWithIdentityAndKeychainPath):
3008         (-[ChallengeDelegate webView:didFinishNavigation:]):
3009         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3010         (TestWebKitAPI::TEST):
3011
3012 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3013
3014         Expected shouldn't assume its contained types are copyable
3015         https://bugs.webkit.org/show_bug.cgi?id=195986
3016
3017         Reviewed by JF Bastien.
3018
3019         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3020         (TestWebKitAPI::NonCopyable::operator== const):
3021         (TestWebKitAPI::NonCopyable::operator!= const):
3022         (TestWebKitAPI::TEST):
3023
3024 2019-03-25  Tim Horton  <timothy_horton@apple.com>
3025
3026         Remove some now-unnecessary dynamic class lookup
3027         https://bugs.webkit.org/show_bug.cgi?id=196237
3028
3029         Reviewed by Simon Fraser.
3030
3031         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3032         (makeRequest):
3033         (TEST):
3034
3035 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
3036
3037         Unreviewed, rolling out r243450.
3038
3039         AppleWin and WinCairo port builds get broken.
3040
3041         Reverted changeset:
3042
3043         "Add test for fix of #196095"
3044         https://bugs.webkit.org/show_bug.cgi?id=196097
3045         https://trac.webkit.org/changeset/243450
3046
3047 2019-03-25  Commit Queue  <commit-queue@webkit.org>
3048
3049         Unreviewed, rolling out r243465.
3050         https://bugs.webkit.org/show_bug.cgi?id=196226
3051
3052         the test doesn't build (Requested by thorton on #webkit).
3053
3054         Reverted changeset:
3055
3056         "Do not terminate the NetworkProcess if a third party
3057         application sends a NSCredential with a SecIdentityRef"
3058         https://bugs.webkit.org/show_bug.cgi?id=196213
3059         https://trac.webkit.org/changeset/243465
3060
3061 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3062
3063         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3064         https://bugs.webkit.org/show_bug.cgi?id=196213
3065
3066         Reviewed by Geoff Garen.
3067
3068         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3069         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3070         (credentialWithIdentityAndKeychainPath):
3071         (-[ChallengeDelegate webView:didFinishNavigation:]):
3072         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3073         (TestWebKitAPI::TEST):
3074
3075 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3076
3077         [ews-build] Gracefully handle missing patch_id in events
3078         https://bugs.webkit.org/show_bug.cgi?id=196216
3079
3080         Reviewed by Lucas Forschler.
3081
3082         * BuildSlaveSupport/ews-build/events.py:
3083
3084 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3085
3086         [ews-build] use lz4 compression for improving buildbot performance
3087         https://bugs.webkit.org/show_bug.cgi?id=196155
3088
3089         Reviewed by Lucas Forschler.
3090
3091         * BuildSlaveSupport/ews-build/master.cfg:
3092
3093 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3094
3095         Pull some API testing helper methods out of TestWKWebView
3096         https://bugs.webkit.org/show_bug.cgi?id=196212
3097
3098         Reviewed by Tim Horton.
3099
3100         Refactor some more API testing utility methods, so that they can be used in
3101         tests that do not use TestWKWebView.
3102
3103         * TestWebKitAPI/cocoa/TestWKWebView.h:
3104         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3105         (-[WKWebView loadTestPageNamed:]):
3106         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
3107         (-[WKWebView synchronouslyLoadHTMLString:]):
3108         (-[WKWebView synchronouslyLoadTestPageNamed:]):
3109         (-[TestWKWebView loadTestPageNamed:]): Deleted.
3110         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
3111         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
3112         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
3113
3114 2019-03-25  Jer Noble  <jer.noble@apple.com>
3115
3116         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3117         https://bugs.webkit.org/show_bug.cgi?id=196097
3118
3119         Reviewed by Eric Carlson.
3120
3121         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3122
3123         * DumpRenderTree/mac/DumpRenderTree.mm:
3124         (resetWebPreferencesToConsistentValues):
3125         * WebKitTestRunner/TestController.cpp:
3126         (WTR::TestController::resetPreferencesToConsistentValues):
3127
3128 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3129
3130         Pull IPadUserInterfaceSwizzler out into a separate header file
3131         https://bugs.webkit.org/show_bug.cgi?id=196193
3132
3133         Reviewed by Anders Carlsson.
3134
3135         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
3136         be used in other API tests.
3137
3138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3139         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3140         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
3141         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
3142         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
3143         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3144         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3145
3146 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3147
3148         Remove NavigatorContentUtils in WebCore/Modules
3149         https://bugs.webkit.org/show_bug.cgi?id=196070
3150
3151         Reviewed by Alex Christensen.
3152
3153         NavigatorContentUtils was to support the custom scheme spec [1].
3154         However, in WebKit side, no port has supported the feature in
3155         WebKit layer after EFL port was removed. So there has been the
3156         only IDL implementation of the NavigatorContentUtils in WebCore.
3157         So we don't need to keep the implementation in WebCore anymore.
3158
3159         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
3160
3161         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3162
3163 2019-03-24  Andy Estes  <aestes@apple.com>
3164
3165         [watchOS] Remove unused Proximity Networking code
3166         https://bugs.webkit.org/show_bug.cgi?id=196188
3167
3168         Reviewed by Tim Horton.
3169
3170         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3171         (TEST):
3172
3173 2019-03-23  Keith Miller  <keith_miller@apple.com>
3174
3175         Refactor clz/ctz and fix getLSBSet.
3176         https://bugs.webkit.org/show_bug.cgi?id=196162
3177
3178         Reviewed by Saam Barati.
3179
3180         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3181
3182         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3183         (TestWebKitAPI::TEST):
3184
3185 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3186
3187         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3188         https://bugs.webkit.org/show_bug.cgi?id=196143
3189
3190         Reviewed by Michael Catanzaro.
3191
3192         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3193         directories.
3194
3195         * Scripts/webkitpy/style/checkers/cpp.py:
3196         (check_identifier_name_in_declaration):
3197         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3198         (WebKitStyleTest.test_names):
3199
3200 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3201
3202         [Flatpak] Manifest expanding fails for qt WPE extension
3203         https://bugs.webkit.org/show_bug.cgi?id=196148
3204
3205         Reviewed by Alex Christensen.
3206
3207         * flatpak/flatpakutils.py:
3208         (expand_submodules_recurse): The last recurse manifest expand
3209         iteration might lead to a single module so take it into account
3210         and don't try to recurse further.
3211
3212 2019-03-22  Chris Dumez  <cdumez@apple.com>
3213
3214         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3215         https://bugs.webkit.org/show_bug.cgi?id=195348
3216         <rdar://problem/48622090>
3217
3218         Reviewed by Alex Christensen.
3219
3220         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3221         to NO when test.options().shouldIgnoreMetaViewport is false.
3222
3223         * WebKitTestRunner/ios/TestControllerIOS.mm:
3224         (WTR::TestController::platformConfigureViewForTest):
3225
3226 2019-03-22  Chris Dumez  <cdumez@apple.com>
3227
3228         Prewarmed processes should be usable with any website data store
3229         https://bugs.webkit.org/show_bug.cgi?id=196104
3230
3231         Reviewed by Alex Christensen.
3232
3233         Add API test coverage.
3234
3235         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3236         (runInitialWarmedProcessUsedTest):
3237         (TEST):
3238
3239 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3240
3241         Back out local changes to Alex's Subversion working directory
3242
3243         They were accidentally committed.
3244
3245         * Scripts/webkitpy/common/system/abstractexecutive.py:
3246         (AbstractExecutive.wait_newest):
3247         * Scripts/webkitpy/common/system/executive.py:
3248         (Executive.running_pids):
3249         * Scripts/webkitpy/common/system/executive_mock.py:
3250         (MockExecutive.running_pids):
3251         * Scripts/webkitpy/common/system/executive_unittest.py:
3252         (ExecutiveTest.serial_test_running_pids):
3253         * Scripts/webkitpy/port/darwin.py:
3254         (DarwinPort.check_for_leaks):
3255         * Scripts/webkitpy/port/leakdetector.py:
3256         (LeakDetector.check_for_leaks):
3257         - This was the hack attached to Bug 193772.
3258
3259         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3260         (+[WebKitTestRunnerEvent mouseLocation]):
3261         - This works around a crash on an internal build.
3262
3263 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3264
3265         Fix the build after r243354
3266         https://bugs.webkit.org/show_bug.cgi?id=196138
3267         <rdar://problem/49145951>
3268
3269         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3270         (TEST):
3271         * TestWebKitAPI/ios/UIKitSPI.h:
3272
3273 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3274
3275         Adopt UIWKDocumentContext
3276         https://bugs.webkit.org/show_bug.cgi?id=196040
3277         <rdar://problem/48642440>
3278
3279         Reviewed by Ryosuke Niwa.
3280
3281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3282         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3283         (makeRequest):
3284         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3285         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3286         (applyStyle):
3287         (TEST):
3288         Add tests for UIWKDocumentContext.
3289
3290         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3291         (TEST):
3292         (recursiveFindWKContentView): Deleted.
3293         * TestWebKitAPI/cocoa/TestWKWebView.h:
3294         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3295         (recursiveFindWKContentView):
3296         (-[TestWKWebView wkContentView]):
3297         * TestWebKitAPI/ios/UIKitSPI.h:
3298         Share the WKContentView finding code between tests.
3299
3300 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3301
3302         [iOS WK2] Turn on async overflow scrolling by default
3303         https://bugs.webkit.org/show_bug.cgi?id=196011
3304         rdar://problem/48453859
3305
3306         Reviewed by Antti Koivisto.
3307         
3308         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3309         since so many basic layout tests have different results when compositing is triggered for
3310         overflow.
3311         
3312         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3313
3314         * WebKitTestRunner/TestController.cpp:
3315         (WTR::TestController::resetPreferencesToConsistentValues):
3316
3317 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3318
3319         [ews-build] Retry API test in case of failures
3320         https://bugs.webkit.org/show_bug.cgi?id=196004
3321
3322         Reviewed by Lucas Forschler.
3323
3324         * BuildSlaveSupport/ews-build/steps.py:
3325         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3326         (CompileWebKitToT.doStepIf): Ditto.
3327         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3328         (ReRunAPITests): Re-run API tests.
3329         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3330         (RunAPITestsWithoutPatch): Run API tests without patch.
3331         (RunAPITestsWithoutPatch.doStepIf):
3332         (RunAPITestsWithoutPatch.hideStepIf):
3333         (RunAPITestsWithoutPatch.evaluateCommand):
3334         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3335         (AnalyzeAPITestsResults.start):
3336         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3337         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3338         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3339         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3340
3341 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3342
3343         [ews-build] Update queues configurations
3344         https://bugs.webkit.org/show_bug.cgi?id=196074
3345
3346         Reviewed by Dewei Zhu.
3347
3348         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3349         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3350
3351 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3352
3353         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3354         https://bugs.webkit.org/show_bug.cgi?id=195680
3355         <rdar://problem/48903534>
3356
3357         Unreviewed infrastructure fix.
3358
3359         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3360         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3361
3362 2019-03-21  Andy Estes  <aestes@apple.com>
3363
3364         [iOS] Apple Pay should be available in documents with no user agent scripts
3365         https://bugs.webkit.org/show_bug.cgi?id=196061
3366         <rdar://problem/48649391>
3367
3368         Reviewed by Brady Eidson.
3369
3370         Added API tests and related infrastructure.
3371
3372         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3373         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3374         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3375         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3376         (TestWebKitAPI::TEST):
3377         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3378         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3379         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3380         * TestWebKitAPI/cocoa/TestProtocol.mm:
3381         (-[TestProtocol startLoading]):
3382         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3383         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3384         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3385         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3386
3387 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3388
3389         REGRESSSION (r243297): webkitpy tests broken
3390         https://bugs.webkit.org/show_bug.cgi?id=196108
3391
3392         Reviewed by Aakash Jain.
3393
3394         r243297 updated contributors.json, which broke a few unit tests.
3395
3396         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3397         (IRCCommandTest.test_whois):
3398         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3399
3400 2019-03-21  Chris Dumez  <cdumez@apple.com>
3401
3402         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3403         https://bugs.webkit.org/show_bug.cgi?id=196041
3404         <rdar://problem/49083230>
3405
3406         Reviewed by Alex Christensen.
3407
3408         Add API test coverage.
3409
3410         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3411         (TEST):
3412
3413 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3414
3415         Add SPI to inform applications of WKContentRuleList actions
3416         https://bugs.webkit.org/show_bug.cgi?id=195965
3417         <rdar://problem/42664365>
3418
3419         Reviewed by Geoff Garen.
3420
3421         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3422         (TestWebKitAPI::allActionsForResourceLoad):
3423         (TestWebKitAPI::testRequest):
3424         (TestWebKitAPI::TEST_F):
3425         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3426         (Notification::description):
3427         (Notification::operator== const):
3428         (toVector):
3429         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3430         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3431         (makeContentRuleList):
3432         (TEST):
3433         (makeWarnContentRuleList): Deleted.
3434
3435 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3436
3437         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3438         https://bugs.webkit.org/show_bug.cgi?id=196088
3439
3440         Reviewed by Brian Burg.
3441
3442         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3443         Support checks when only one platform is specified. Also deprecate macosx() and
3444         force the use of macos() instead.
3445
3446         * Scripts/webkitpy/style/checkers/cpp.py:
3447         (check_min_versions_of_wk_api_available):
3448         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3449         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3450
3451 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3452
3453         Update status inactive committers' status to 'contributor'.
3454
3455         * Scripts/webkitpy/common/config/contributors.json:
3456
3457 2019-03-21  Xan Lopez  <xan@igalia.com>
3458
3459         [JSC][x86] Drop support for x87 floating point
3460         https://bugs.webkit.org/show_bug.cgi?id=194853
3461
3462         Reviewed by Don Olmstead.
3463
3464         Force SSE2 on x86/32bit builds.
3465
3466         * Scripts/webkitdirs.pm:
3467         (generateBuildSystemFromCMakeProject):
3468
3469 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3470
3471         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3472         https://bugs.webkit.org/show_bug.cgi?id=196073
3473
3474         Reviewed by Michael Catanzaro.
3475
3476         Add test cases to check functions and constructors with no arguments but receiving user data.
3477
3478         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3479         (checkUserData):
3480         (testJSCFunction):
3481         (fooCreateWithUserData):
3482         (testJSCClass):
3483
3484 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3485
3486         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3487
3488         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3489
3490         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3491
3492 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3493
3494         [GTK][WPE] Add API to provide geolocation information
3495         https://bugs.webkit.org/show_bug.cgi?id=195940
3496
3497         Reviewed by Michael Catanzaro.
3498
3499         Add a new test to check the new API.
3500
3501         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3502         (testGeolocationManagerCurrentPosition):
3503         (testGeolocationManagerWatchPosition):
3504         (beforeAll):
3505         (afterAll):
3506         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3507         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3508         (beforeAll): Ditto.
3509         * TestWebKitAPI/glib/CMakeLists.txt:
3510
3511 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3512
3513         [GLib] Returning G_TYPE_OBJECT from a method does not work
3514         https://bugs.webkit.org/show_bug.cgi?id=195574
3515
3516         Reviewed by Michael Catanzaro.
3517
3518         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3519
3520         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3521         (getGFile):
3522         (getParent):
3523         (createGString):
3524         (getGString):
3525         (getGStringCopyWillRaise):
3526         (getGStringCopy):
3527         (getGStringStr):
3528         (getGStringLen):
3529         (freeGString):
3530         (testJSCClass):
3531
3532 2019-03-20  Saam Barati  <sbarati@apple.com>
3533
3534         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3535         https://bugs.webkit.org/show_bug.cgi?id=195721
3536
3537         Reviewed by Filip Pizlo.
3538
3539         * Scripts/run-javascriptcore-tests:
3540
3541 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3542
3543         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3544         https://bugs.webkit.org/show_bug.cgi?id=196049
3545
3546         Reviewed by Tim Horton.
3547
3548         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3549         overflow scrolling in general, so rename it.
3550
3551         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3552
3553 2019-03-20  Daniel Bates  <dabates@apple.com>
3554
3555         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3556         https://bugs.webkit.org/show_bug.cgi?id=196031
3557         <rdar://problem/49078172>
3558
3559         Reviewed by Tim Horton.
3560
3561         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3562         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3563         same code path used when the Done button is pressed to dismiss the <select> picker.
3564
3565         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3566         (TestWebKitAPI::TEST):
3567
3568 2019-03-20  Chris Dumez  <cdumez@apple.com>
3569
3570         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3571         https://bugs.webkit.org/show_bug.cgi?id=196029
3572         <rdar://problem/48954651>
3573
3574         Reviewed by Tim Horton.
3575
3576         Add API test coverage.
3577
3578         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3579
3580 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3581
3582         [ews-build] Improve failure summary string for ApplyPatch step
3583         https://bugs.webkit.org/show_bug.cgi?id=195995
3584
3585         Reviewed by Alexey Proskuryakov.
3586
3587         * BuildSlaveSupport/ews-build/steps.py:
3588         (ApplyPatch.getResultSummary): Override getResultSummary.
3589
3590 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3591
3592         AX: Implement support for new meter ARIA role
3593         https://bugs.webkit.org/show_bug.cgi?id=195966
3594
3595         Reviewed by Chris Fleizach.
3596
3597         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3598         to AXLevelIndicator.
3599
3600         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3601
3602 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3603
3604         [WebAuthN] Implement FIDO AppID extension
3605         https://bugs.webkit.org/show_bug.cgi?id=143491
3606         <rdar://problem/48298273>
3607
3608         Reviewed by Brent Fulgham.
3609
3610         Add a test that covers the new flag of convertToU2fSignCommand.
3611
3612         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3613         (TestWebKitAPI::TEST):
3614         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3615         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3616         (TestWebKitAPI::TEST):
3617
3618 2019-03-19  Keith Rollin  <krollin@apple.com>
3619
3620         Add support for more platforms to generate-xcfilelists
3621         https://bugs.webkit.org/show_bug.cgi?id=195977
3622
3623         Reviewed by Alexey Proskuryakov.
3624
3625         generate-xcfilelists incorrectly complains when involved with building
3626         WebKit for iphonesimulator:
3627
3628             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3629             …
3630             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3631
3632         Address this by teaching generate-xcfilelists about more platforms.
3633
3634         * Scripts/generate-xcfilelists:
3635
3636 2019-03-19  John Wilander  <wilander@apple.com>
3637
3638         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3639         https://bugs.webkit.org/show_bug.cgi?id=195923
3640         <rdar://problem/49001272>
3641
3642         Reviewed by Alex Christensen.
3643
3644         This patch does the following to the TestRunner:
3645         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3646         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3647         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3648
3649         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3650         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3651         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3652         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3653         * WebKitTestRunner/TestController.cpp:
3654         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3655         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3656         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3657         * WebKitTestRunner/TestController.h:
3658         * WebKitTestRunner/TestInvocation.cpp:
3659         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3660
3661 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3662
3663         [CMake] Support more clang and gcc sanitizers
3664         https://bugs.webkit.org/show_bug.cgi?id=195956
3665
3666         Reviewed by Michael Catanzaro.
3667
3668         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3669
3670 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3671
3672         [ews-build] Improve summary for PrintConfiguration step
3673         https://bugs.webkit.org/show_bug.cgi?id=195945
3674
3675         Reviewed by Lucas Forschler.
3676
3677         * BuildSlaveSupport/ews-build/steps.py:
3678         (PrintConfiguration.getResultSummary): Override getResultSummary.
3679
3680 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3681
3682         [ews-build] Improve summary for CheckOutSource step
3683         https://bugs.webkit.org/show_bug.cgi?id=195963
3684
3685         Reviewed by Lucas Forschler.
3686
3687         * BuildSlaveSupport/ews-build/steps.py:
3688         (CheckOutSource.getResultSummary):
3689
3690 2019-03-19  Daniel Bates  <dabates@apple.com>
3691
3692         [iOS] Focus not preserved when switching between tabs
3693         https://bugs.webkit.org/show_bug.cgi?id=195820
3694         <rdar://problem/43614450>
3695
3696         Reviewed by Brent Fulgham.
3697
3698         Add tests to ensure that we restore focus when resigning and becoming first responder.
3699
3700         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3701         (TestWebKitAPI::TEST):
3702
3703 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3704
3705         Make WTFLogChannelState and WTFLogLevel enum classes
3706         https://bugs.webkit.org/show_bug.cgi?id=195904
3707
3708         Reviewed by Eric Carlson.
3709
3710         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3711         (TestWebKitAPI::TEST_F):
3712
3713 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3714
3715         [GStreamer][EME] Backported mssdemux protection data crash fix
3716         https://bugs.webkit.org/show_bug.cgi?id=195918
3717
3718         Reviewed by Philippe Normand.
3719
3720         * gstreamer/jhbuild.modules:
3721         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3722
3723 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3724
3725         Unreviewed, rolling out r243132.
3726
3727         Broke GTK build
3728
3729         Reverted changeset:
3730
3731         "Make WTFLogChannelState and WTFLogLevel enum classes"
3732         https://bugs.webkit.org/show_bug.cgi?id=195904
3733         https://trac.webkit.org/changeset/243132
3734
3735 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3736
3737         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3738
3739         * Scripts/webkitdirs.pm:
3740         (builtDylibPathForName): Adjust the shared library name that's changed
3741         with the API version bump in r243073.
3742
3743 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3744
3745         Make WTFLogChannelState and WTFLogLevel enum classes
3746         https://bugs.webkit.org/show_bug.cgi?id=195904
3747
3748         Reviewed by Eric Carlson.
3749
3750         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3751         (TestWebKitAPI::TEST_F):
3752
3753 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3754
3755         Disable flaky test added in r2431100
3756         https://webkit.org/b/195785
3757
3758         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3759         (TestWebKitAPI::TEST):
3760         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3761
3762 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3763
3764         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3765         https://bugs.webkit.org/show_bug.cgi?id=195916
3766
3767         Reviewed by Tim Horton.
3768
3769         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3770         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3771
3772 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3773
3774         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3775
3776         * Scripts/webkitpy/common/config/contributors.json:
3777
3778 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3779
3780         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3781         https://bugs.webkit.org/show_bug.cgi?id=195785
3782
3783         Reviewed by Geoffrey Garen.
3784
3785         * TestWebKitAPI/TCPServer.cpp: Added.
3786         (TestWebKitAPI::TCPServer::TCPServer):
3787         (TestWebKitAPI::TCPServer::~TCPServer):
3788         (TestWebKitAPI::TCPServer::socketBindListen):
3789         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3790         * TestWebKitAPI/TCPServer.h: Added.
3791         (TestWebKitAPI::TCPServer::port const):
3792         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3793         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3794         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3795         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3796         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3797         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3798         (TestWebKitAPI::respondSlowly):
3799         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3800         (TestWebKitAPI::downloadAtRate):
3801         (TestWebKitAPI::TEST):
3802
3803 2019-03-18  Saam Barati  <sbarati@apple.com>
3804
3805         Add a plan file for JetStream 2
3806         https://bugs.webkit.org/show_bug.cgi?id=190734
3807
3808         Reviewed by Mark Lam.
3809
3810         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3811
3812 2019-03-18  Chris Dumez  <cdumez@apple.com>
3813
3814         Delay WebProcess launch until a load is triggered in a Web view
3815         https://bugs.webkit.org/show_bug.cgi?id=195758
3816         <rdar://problem/48126013>
3817
3818         Reviewed by Geoff Garen.
3819
3820         Add API test coverage. Also update some existing API tests to not expect
3821         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3822
3823         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3824         (TestWebKitAPI::TEST):
3825         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3826         (TestWebKitAPI::TEST):
3827         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3828         (TEST):
3829         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3830         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3831         (TEST):
3832         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3833         (TEST):
3834         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3835
3836 2019-03-18  Xan Lopez  <xan@igalia.com>
3837
3838         [CMake] Prevent potential warning when determining $architecture
3839         https://bugs.webkit.org/show_bug.cgi?id=195891
3840
3841         Reviewed by Michael Catanzaro.
3842
3843         It's possible for generateBuildSystemForCMakeProject to be called
3844         before determineArchitecture() is ever called. This will make the
3845         first eq check with $architecture to be bogus (and print a
3846         warning). Change that to an eq check with architecture(), which
3847         implicitly calls determineArchitecture() if needed, and change all
3848         the other similar cases in the method in the same way to prevent
3849         future bugs like this one.
3850
3851         * Scripts/webkitdirs.pm:
3852         (generateBuildSystemFromCMakeProject):
3853
3854 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3855
3856         [WPE] Tarballs generated with “make dist” cannot build documentation
3857         https://bugs.webkit.org/show_bug.cgi?id=195885
3858
3859         Reviewed by Carlos Garcia Campos.
3860
3861         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3862
3863 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3864
3865         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3866         https://bugs.webkit.org/show_bug.cgi?id=195883
3867
3868         Reviewed by Carlos Garcia Campos.
3869
3870         * gtkdoc/gtkdoc.py:
3871         (GTKDoc._run_command): When commands fail to run, include the full command line for
3872         the program invocation and the output it has generated on the standard error stream.
3873
3874 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3875
3876         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3877         https://bugs.webkit.org/show_bug.cgi?id=195786
3878
3879         Reviewed by Philippe Normand.
3880
3881         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3882         * wpe/jhbuild.modules: Ditto.
3883
3884 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3885
3886         [ews-build] Don't run clean builds on EWS builders
3887         https://bugs.webkit.org/show_bug.cgi?id=195851
3888
3889         Reviewed by Geoffrey Garen.
3890
3891         * BuildSlaveSupport/ews-build/factories.py:
3892
3893 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3894
3895         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3896         https://bugs.webkit.org/show_bug.cgi?id=195849
3897
3898         Reviewed by Chris Dumez.
3899
3900         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3901
3902         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3903         (runWebsiteDataStoreCustomPaths):
3904
3905 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3906
3907         webkitpy: Upload test results
3908         https://bugs.webkit.org/show_bug.cgi?id=195755
3909         <rdar://problem/48896182>
3910
3911         Reviewed by Aakash Jain.
3912
3913         Establish a new format for uploading results that is not tied to layout tests, apply
3914         that format to webkitpy tests.
3915
3916         * Scripts/webkitpy/common/checkout/scm/git.py:
3917         (Git.native_branch): Return what branch the current checkout is on.
3918         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3919         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3920         * Scripts/webkitpy/common/checkout/scm/svn.py:
3921         (SVN.native_branch): Ditto.
3922         * Scripts/webkitpy/common/system/platforminfo.py:
3923         (PlatformInfo.build_version): Return a build version for Mac.
3924         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3925         (MockPlatformInfo.__init__):
3926         (MockPlatformInfo.build_version):
3927         * Scripts/webkitpy/results: Added.
3928         * Scripts/webkitpy/results/__init__.py: Added.
3929         * Scripts/webkitpy/results/options.py: Added.
3930         (upload_options): OptParse list for upload options.
3931         * Scripts/webkitpy/results/upload.py: Added.
3932         (Upload): Class which enforces the upload format expected by the results server.
3933         (Upload.Expectations):
3934         (Upload.create_configuration):
3935         (Upload.create_commit):
3936         (Upload.create_details):
3937         (Upload.create_run_stats):
3938         (Upload.create_test_result):
3939         (Upload.__init__):
3940         (Upload.Encoder): Encode Upload object as json.
3941         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3942         * Scripts/webkitpy/results/upload_unittest.py: Added.
3943         * Scripts/webkitpy/test/main.py:
3944         (Tester._parse_args): Add upload arguments.
3945         (Tester._run_tests): Allow results to be uploaded.
3946         * Scripts/webkitpy/test/runner.py:
3947         (Runner.__init__): Record which tests were run, rather than just counting them.
3948         (Runner.handle):
3949         * Scripts/webkitpy/test/runner_unittest.py:
3950         (RunnerTest.test_run):
3951         * Scripts/webkitpy/thirdparty/__init__.py:
3952         (AutoinstallImportHook.find_module): Add requests auto-install.
3953         (AutoinstallImportHook._install_requests):
3954         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3955         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3956
3957 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3958
3959         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3960         https://bugs.webkit.org/show_bug.cgi?id=195810
3961
3962         Reviewed by Tim Horton.
3963
3964         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3965         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3966         ending certain layout tests.
3967
3968         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3969         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3970         (-[TestRunnerWKWebView dealloc]):
3971         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3972
3973         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3974         helper method when destroying the web view, and when resetting state between tests.
3975
3976         * WebKitTestRunner/ios/TestControllerIOS.mm:
3977         (WTR::TestController::platformResetStateToConsistentValues):
3978
3979         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3980
3981 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3982
3983         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3984         https://bugs.webkit.org/show_bug.cgi?id=190350
3985         <rdar://problem/45089503>
3986
3987         Reviewed by Geoffrey Garen.
3988
3989         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3990         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3991         (TEST):
3992         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3993         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3994         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3995         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3996         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3997         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3998         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3999         (runTest):
4000         (createDirectories):
4001         (TEST):
4002         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
4003         (TEST):
4004         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
4005         (TEST):
4006
4007 2019-03-15  Timothy Hatcher  <timothy@apple.com>
4008
4009         Add support to WebPage for getting the contents as an attributed string.
4010         https://bugs.webkit.org/show_bug.cgi?id=195636
4011         rdar://problem/45055697
4012
4013         Reviewed by Tim Horton.
4014
4015         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
4016         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
4017
4018 2019-03-15  Chris Dumez  <cdumez@apple.com>
4019
4020         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
4021         https://bugs.webkit.org/show_bug.cgi?id=195747
4022
4023         Reviewed by Geoff Garen.
4024
4025         Add API test coverage.
4026
4027         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4028
4029 2019-03-15  Shawn Roberts  <sroberts@apple.com>
4030
4031         Unreviewed, rolling out r242952.
4032
4033         Causing API failures on iOS Simulator
4034
4035         Reverted changeset:
4036
4037         "[PSON] Make sure the WebProcessCache is leverage when
4038         relaunching a process after termination"
4039         https://bugs.webkit.org/show_bug.cgi?id=195747
4040         https://trac.webkit.org/changeset/242952
4041
4042 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
4043
4044         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
4045         https://bugs.webkit.org/show_bug.cgi?id=195740
4046
4047         Reviewed by Ross Kirsling.
4048
4049         window.open doesn't work for WebKitBrowserWindow because it is not
4050         implemented yet.
4051
4052         1. Implemented createNewPage callback of WKPageUIClient.
4053         2. Changed MainWindow to take a BrowserWindow factory function
4054           instead of BrowserWindowType to be flexible to create
4055           BrowserWindow with extra settings.
4056         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
4057           because it is not relevant with MainWindow anymore.
4058
4059         * MiniBrowser/win/Common.cpp:
4060         (parseCommandLine):
4061         * MiniBrowser/win/Common.h:
4062         (CommandLineOptions::CommandLineOptions):
4063         * MiniBrowser/win/MainWindow.cpp:
4064         (MainWindow::MainWindow):
4065         (MainWindow::create):
4066         (MainWindow::init):
4067         (MainWindow::WndProc):
4068         * MiniBrowser/win/MainWindow.h:
4069         * MiniBrowser/win/PrintWebUIDelegate.cpp:
4070         (PrintWebUIDelegate::createWebViewWithRequest):
4071         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4072         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
4073         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
4074         (WebKitBrowserWindow::updateProxySettings):
4075         (WebKitBrowserWindow::createNewPage):
4076         * MiniBrowser/win/WebKitBrowserWindow.h:
4077         * MiniBrowser/win/WinMain.cpp:
4078         (wWinMain):
4079
4080 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
4081
4082         Make it possible to test scrolling tree layer manipulation more easily
4083         https://bugs.webkit.org/show_bug.cgi?id=195780
4084
4085         Reviewed by Tim Horton.
4086         
4087         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
4088         cuts off communication of scrolling tree scrolls back to the web process
4089         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
4090         allows tests to trigger scrolls which run the scrolling tree layer positioning
4091         logic, but never get another commit from the web process that might mask
4092         scrolling tree bugs.
4093         
4094         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
4095         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
4096         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
4097
4098         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4099         (WTR::UIScriptController::scrollUpdatesDisabled const):
4100         (WTR::UIScriptController::setScrollUpdatesDisabled):
4101         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4102         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4103         (WTR::UIScriptController::scrollUpdatesDisabled const):
4104         (WTR::UIScriptController::setScrollUpdatesDisabled):
4105         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4106         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4107         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4108         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
4109         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
4110         * WebKitTestRunner/ios/TestControllerIOS.mm:
4111         (WTR::TestController::platformResetStateToConsistentValues):
4112         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4113         (WTR::UIScriptController::scrollUpdatesDisabled const):
4114         (WTR::UIScriptController::setScrollUpdatesDisabled):
4115
4116 2019-03-14  Youenn Fablet  <youenn@apple.com>
4117
4118         Move IDB storage in private browsing mode to NetworkProcess
4119         https://bugs.webkit.org/show_bug.cgi?id=195602
4120
4121         Reviewed by Brady Eidson.
4122
4123         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
4124         (TEST):
4125
4126 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4127
4128         [ews-build] Make descriptionDone messages more readable
4129         https://bugs.webkit.org/show_bug.cgi?id=195760
4130
4131         Reviewed by Lucas Forschler.
4132
4133         * BuildSlaveSupport/ews-build/steps.py:
4134         * BuildSlaveSupport/ews-build/steps_unittest.py:
4135
4136 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4137
4138         [ews-build] Generate status-bubble hover-over messages
4139         https://bugs.webkit.org/show_bug.cgi?id=195680
4140
4141         Reviewed by Lucas Forschler.
4142
4143         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4144         (StatusBubble):
4145         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
4146         on hover-over.
4147         (StatusBubble._iso_time):
4148         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
4149         hover-over message.
4150         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
4151
4152 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4153
4154         [ews-app] Gracefully handle the case when state_string is None
4155         https://bugs.webkit.org/show_bug.cgi?id=195753
4156
4157         Reviewed by Lucas Forschler.
4158
4159         * BuildSlaveSupport/ews-app/ews/models/build.py:
4160         * BuildSlaveSupport/ews-app/ews/models/step.py:
4161
4162 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4163
4164         [ews-app] Status bubble display pending for currently running build step
4165         https://bugs.webkit.org/show_bug.cgi?id=195744
4166
4167         Reviewed by Lucas Forschler.
4168
4169         * BuildSlaveSupport/ews-build/events.py:
4170         (Events.stepStarted): If state_string is pending, replace it with step name.
4171
4172 2019-03-14  Chris Dumez  <cdumez@apple.com>
4173
4174         Add WebsitePolicy for the client to specify the device orientation & motion access policy
4175         https://bugs.webkit.org/show_bug.cgi?id=195750
4176
4177         Reviewed by Geoffrey Garen.
4178
4179         Add API test coverage.
4180
4181         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4182         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
4183         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4184         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4185
4186 2019-03-14  Chris Dumez  <cdumez@apple.com>
4187
4188         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
4189         https://bugs.webkit.org/show_bug.cgi?id=195747
4190
4191         Reviewed by Geoff Garen.
4192
4193         Add API test coverage.
4194
4195         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4196
4197 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4198
4199         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
4200         https://bugs.webkit.org/show_bug.cgi?id=195725
4201         <rdar://problem/48545062>
4202
4203         Reviewed by Tim Horton.
4204
4205         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
4206         handler is nil.
4207
4208         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4209         (TestWebKitAPI::TEST):
4210
4211 2019-03-13  Sam Weinig  <sam@webkit.org>
4212
4213         Add utility function to allow easy reverse range-based iteration of a container
4214         https://bugs.webkit.org/show_bug.cgi?id=195542
4215
4216         Reviewed by Antti Koivisto.
4217
4218         * TestWebKitAPI/CMakeLists.txt:
4219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4220         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
4221         (TestWebKitAPI::TEST):
4222         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
4223
4224 2019-03-13  Chris Dumez  <cdumez@apple.com>
4225
4226         Use a ServiceWorker process per registrable domain
4227         https://bugs.webkit.org/show_bug.cgi?id=195649
4228
4229         Reviewed by Youenn Fablet.
4230
4231         Update API test coverage.
4232
4233         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4234
4235 2019-03-13  Chris Dumez  <cdumez@apple.com>
4236
4237         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
4238         https://bugs.webkit.org/show_bug.cgi?id=195684
4239         <rdar://problem/48294714>
4240
4241         Reviewed by Antti Koivisto.
4242
4243         Add API test coverage.
4244
4245         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4246
4247 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4248
4249         [ews-app] Remove unused patch view
4250         https://bugs.webkit.org/show_bug.cgi?id=195669
4251
4252         Reviewed by Lucas Forschler.
4253
4254         * BuildSlaveSupport/ews-app/ews/urls.py:
4255         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
4256
4257 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4258
4259         [ews-app] Use Buildbot result code variables
4260         https://bugs.webkit.org/show_bug.cgi?id=195668
4261
4262         Reviewed by Alexey Proskuryakov.
4263
4264         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
4265         (Buildbot): Added Buildbot result code variables.
4266         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4267         (StatusBubble._build_bubble): Used Buildbot result code variables.
4268
4269 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
4270
4271         [Flatpak] Expand submodule recursively
4272         https://bugs.webkit.org/show_bug.cgi?id=195672
4273
4274         Building WPE with flatpak was impossible without that as it was raising an exception.
4275         Also update wpebackend-fdo to match what is built in jhbuild
4276
4277         Reviewed by Philippe Normand.
4278
4279         * flatpak/flatpakutils.py:
4280         (expand_submodules_recurse):
4281         (expand_manifest):
4282         * flatpak/org.webkit.WPEModules.yaml:
4283
4284 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4285
4286         [ews-app] status bubble should be hidden for certain builds
4287         https://bugs.webkit.org/show_bug.cgi?id=194597
4288
4289         Reviewed by Dewei Zhu.
4290
4291         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4292         (StatusBubble._build_bubble):
4293         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
4294         because the patch didn't have relevant changes.
4295         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
4296         in production yet.
4297
4298 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
4299
4300         [Win] Fix a slew of simple clang-cl warnings.
4301         https://bugs.webkit.org/show_bug.cgi?id=195652
4302
4303         Reviewed by Don Olmstead.
4304
4305         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4306         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
4307
4308 2019-03-12  Justin Fan  <justin_fan@apple.com>
4309
4310         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
4311         https://bugs.webkit.org/show_bug.cgi?id=195518
4312         <rdar://problem/46322356>
4313
4314         Reviewed by Myles C. Maxfield.
4315
4316         * DumpRenderTree/DerivedSources-input.xcfilelist:
4317         * DumpRenderTree/DerivedSources-output.xcfilelist:
4318
4319 2019-03-12  Commit Queue  <commit-queue@webkit.org>
4320
4321         Unreviewed, rolling out r242825.
4322         https://bugs.webkit.org/show_bug.cgi?id=195648
4323
4324