High Sierra Debug JSC test queue should use faster hardware
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
2
3         High Sierra Debug JSC test queue should use faster hardware
4         https://bugs.webkit.org/show_bug.cgi?id=194603
5
6         Rubber-stamped by Alexey Proskuryakov.
7
8         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
9
10         * BuildSlaveSupport/build.webkit.org-config/config.json:
11         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
12         (BubbleQueueServer):
13         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
14         (WebKitBuildbot):
15         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
16         * QueueStatusServer/config/queues.py:
17         * Scripts/webkitpy/common/config/ews.json:
18         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
19         (test_ews_name):
20
21 2019-02-27  John Wilander  <wilander@apple.com>
22
23         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
24         https://bugs.webkit.org/show_bug.cgi?id=195071
25         <rdar://problem/48417690>
26
27         Reviewed by Alex Christensen and Brent Fulgham.
28
29         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
30         (TestWebKitAPI::createURL):
31             Convenience function.
32         (TestWebKitAPI::TEST):
33             WebCore::AdClickAttribution now takes a URL when creating Source and
34             Destination.
35         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
36         (TestWebKitAPI::TEST):
37             WebCore::AdClickAttribution now takes a URL when creating Source and
38             Destination.
39
40 2019-02-27  Antoine Quint  <graouts@apple.com>
41
42         Support Pointer Events on macOS
43         https://bugs.webkit.org/show_bug.cgi?id=195008
44         <rdar://problem/47454419>
45
46         Reviewed by Dean Jackson.
47
48         * DumpRenderTree/mac/DumpRenderTree.mm:
49         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
50         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
51
52 2019-02-26  Mark Lam  <mark.lam@apple.com>
53
54         Remove remaining poisoning code.
55         https://bugs.webkit.org/show_bug.cgi?id=194138
56
57         Reviewed by Saam Barati.
58
59         * TestWebKitAPI/CMakeLists.txt:
60         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
61         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
62         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
63         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
64         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
65         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
66         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
67
68 2019-02-26  Alex Christensen  <achristensen@webkit.org>
69
70         Move ephemeral local storage from WebProcess to UIProcess
71         https://bugs.webkit.org/show_bug.cgi?id=195074
72         <rdar://problem/47937975>
73
74         Reviewed by Geoff Garen.
75
76         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
77
78 2019-02-20  Jer Noble  <jer.noble@apple.com>
79
80         [Cocoa] Media elements will restart network buffering just before suspending
81         https://bugs.webkit.org/show_bug.cgi?id=193691
82
83         Reviewed by Eric Carlson.
84
85         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
86         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
87         (TEST):
88
89 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
90
91         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
92         https://bugs.webkit.org/show_bug.cgi?id=191652
93
94         Reviewed by Alex Christensen.
95
96         Fix WinCairo MiniBrowser behavior of authentication dialog.
97
98         * MiniBrowser/win/WebKitBrowserWindow.cpp:
99         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
100
101 2019-02-26  Youenn Fablet  <youenn@apple.com>
102
103         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
104         https://bugs.webkit.org/show_bug.cgi?id=195028
105         <rdar://problem/48243733>
106
107         Reviewed by Eric Carlson.
108
109         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
110
111 2019-02-26  Philippe Normand  <pnormand@igalia.com>
112
113         [WPE] Add API for webview background color configuration
114         https://bugs.webkit.org/show_bug.cgi?id=192305
115
116         Reviewed by Michael Catanzaro.
117
118         * MiniBrowser/wpe/main.cpp:
119         (main): Add a new option to configure the webview background
120         color. Example: --bg-color=transparent.
121         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
122         (testWebViewBackgroundColor): Enable background color API tests for WPE.
123         (beforeAll): Ditto.
124
125 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
126
127         scalableNativeWebpageParameters() is not preserved on new page navigation.
128         https://bugs.webkit.org/show_bug.cgi?id=194892
129         <rdar://problem/47538280>
130
131         Reviewed by Wenson Hsieh.
132         
133         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
134
135         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
136         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
137         * DumpRenderTree/mac/UIScriptControllerMac.mm:
138         (WTR::UIScriptController::allowsViewportShrinkToFit):
139         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
140         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
141         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
142         * TestRunnerShared/UIScriptContext/UIScriptController.h:
143         * WebKitTestRunner/UIScriptControllerCocoa.mm:
144         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
145
146 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
147
148         [ews-app] Add model for handling multiple Buildbot instances
149         https://bugs.webkit.org/show_bug.cgi?id=194863
150
151         Reviewed by Stephanie Lewis.
152
153         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
154
155 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
156
157         [ews-app] Remove BuilderMapping table
158         https://bugs.webkit.org/show_bug.cgi?id=194961
159
160         Reviewed by Stephanie Lewis.
161
162         Store builder name directly in build table, instead of having a separate
163         table for it.
164
165         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
166         * BuildSlaveSupport/ews-app/ews/models/build.py:
167         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
168         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
169
170 2019-02-25  John Wilander  <wilander@apple.com>
171
172         Introduce and adopt new class RegistrableDomain for eTLD+1
173         https://bugs.webkit.org/show_bug.cgi?id=194791
174         <rdar://problem/48179240>
175
176         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
177
178         This patch adds an API test and replaces two instances of
179         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
180
181         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
182         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
183         (TestWebKitAPI::TEST):
184             Changed two strings to make sure the registrable domains are still considered
185             invalid and pass the test.
186         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
187         (TestWebKitAPI::TEST):
188         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
189         (WTR::InjectedBundle::didReceiveMessageToPage):
190
191 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
192
193         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
194         https://bugs.webkit.org/show_bug.cgi?id=195001
195
196         Reviewed by Carlos Garcia Campos.
197
198         API version 1.0 always includes the functionality previously guarded with
199         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
200         unconditionally.
201
202         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
203         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
204         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
205         (WebViewTest::showInWindow): Ditto.
206         (WebViewTest::hideView): Ditto.
207         * wpe/backends/HeadlessViewBackend.cpp:
208         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
209         * wpe/backends/ViewBackend.cpp:
210         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
211         * wpe/backends/WindowViewBackend.cpp:
212         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
213         WPE_BACKEND_CHECK_VERSION().
214         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
215
216 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
217
218         [Flatpak] Add support for flatpak > 1.1.2
219         https://bugs.webkit.org/show_bug.cgi?id=194088
220
221         Flatpak 1.2 is now out so we need to support that
222         version now.
223
224         Reviewed by Michael Catanzaro.
225
226         * flatpak/flatpakutils.py:
227         (check_flatpak):
228         (FlatpakPackages.__init__):
229         (FlatpakPackages.__detect_packages):
230         (FlatpakPackages.__detect_packages.in):
231         (FlatpakRepos.update):
232
233 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
234
235         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
236         https://bugs.webkit.org/show_bug.cgi?id=194998
237
238         Reviewed by Carlos Garcia Campos.
239
240         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
241         to a Git checkout and using the latest commit containing various fixes
242         and improvements.
243
244 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
245
246         [WPE][GTK] Remove user agent quirk for washingtonpost.com
247         https://bugs.webkit.org/show_bug.cgi?id=194981
248
249         Reviewed by Žan Doberšek.
250
251         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
252         (TestWebKitAPI::TEST):
253
254 2019-02-23  Keith Miller  <keith_miller@apple.com>
255
256         Add new mac target numbers
257         https://bugs.webkit.org/show_bug.cgi?id=194955
258
259         Reviewed by Tim Horton.
260
261         * DumpRenderTree/mac/Configurations/Base.xcconfig:
262         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
263         * MiniBrowser/Configurations/Base.xcconfig:
264         * TestWebKitAPI/Configurations/Base.xcconfig:
265         * WebKitTestRunner/Configurations/Base.xcconfig:
266
267 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
268
269         [WinCairo] Enable wk1/wk2 suffix for platform search path.
270         https://bugs.webkit.org/show_bug.cgi?id=194846
271
272         Reviewed by Don Olmstead.
273
274         Added _search_paths() and _port_specific_expectations_files() for
275         WinCairoPort.
276
277         * Scripts/webkitpy/port/win.py:
278         (WinCairoPort.default_baseline_search_path):
279         (WinCairoPort):
280         (WinCairoPort._port_specific_expectations_files):
281         (WinCairoPort._search_paths):
282
283 2019-02-22  Tim Horton  <timothy_horton@apple.com>
284
285         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
286         https://bugs.webkit.org/show_bug.cgi?id=194963
287
288         Reviewed by Dean Jackson.
289
290         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
291         Do a `contains` check instead of `equals`, because in debug builds we
292         put the GraphicsLayer pointer in a prefix.
293
294 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
295
296         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
297         https://bugs.webkit.org/show_bug.cgi?id=194873
298         <rdar://problem/46701974>
299
300         Reviewed by Tim Horton.
301
302         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
303
304         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
305         (WTR::UIScriptController::menuRect const):
306         (WTR::UIScriptController::isShowingMenu const):
307         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
308         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
309         (WTR::UIScriptController::menuRect const):
310
311         Add a function to query the bounds of the callout menu in content coordinates.
312
313         (WTR::UIScriptController::isShowingMenu const):
314
315         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
316
317         * TestRunnerShared/UIScriptContext/UIScriptController.h:
318         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
319         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
320         (WTR::UIScriptController::rectForMenuAction const):
321         (WTR::UIScriptController::menuRect const):
322         (WTR::UIScriptController::isShowingMenu const):
323         (WTR::findViewInHierarchyOfType): Deleted.
324
325 2019-02-22  Chris Dumez  <cdumez@apple.com>
326
327         Regression(PSON) Unable to preview password-protected documents on iCloud.com
328         https://bugs.webkit.org/show_bug.cgi?id=194954
329         <rdar://problem/48127957>
330
331         Reviewed by Alex Christensen.
332
333         Add API test coverage.
334
335         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
336         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
337         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
338         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
339
340 2019-02-22  Chris Dumez  <cdumez@apple.com>
341
342         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
343         https://bugs.webkit.org/show_bug.cgi?id=194924
344         <rdar://problem/48216125>
345
346         Reviewed by Geoffrey Garen.
347
348         Add API test coverage.
349
350         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
351
352 2019-02-22  Chris Dumez  <cdumez@apple.com>
353
354         Unreviewed, disable API test added in r241928 on iOS.
355
356         The cache is not enabled on devices with less than 3GB of RAM.
357
358         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
359
360 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
361
362         Hardcode Visual Viewports on everywhere except iOS WK1
363         https://bugs.webkit.org/show_bug.cgi?id=194928
364
365         Reviewed by Zalan Bujtas.
366
367         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
368         change the default value of the Setting to 'true', and hardcode WebView on iOS to
369         set it to false. The setting has shipped for several years and there's no need to turn
370         it off now.
371
372         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
373         Visual Viewports are not enabled.
374         
375         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
376         that only runs in WK2
377
378         * MiniBrowser/mac/SettingsController.h:
379         * MiniBrowser/mac/SettingsController.m:
380         (-[SettingsController init]):
381         (-[SettingsController _populateMenu]):
382         (-[SettingsController validateMenuItem:]):
383         (-[SettingsController visualViewportEnabled]): Deleted.
384         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
385         * MiniBrowser/mac/WK1BrowserWindowController.m:
386         (-[WK1BrowserWindowController didChangeSettings]):
387         * MiniBrowser/mac/WK2BrowserWindowController.m:
388         (-[WK2BrowserWindowController didChangeSettings]):
389
390 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
391
392         Discard cached processes when clearing website data store
393         https://bugs.webkit.org/show_bug.cgi?id=194894
394
395         Reviewed by Chris Dumez.
396
397         Added a test case.
398
399         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
400         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
401
402 2019-02-21  Alex Christensen  <achristensen@webkit.org>
403
404         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
405         https://bugs.webkit.org/show_bug.cgi?id=194914
406         <rdar://problem/47586889>
407
408         Reviewed by Geoffrey Garen.
409
410         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
411         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
412         (TEST):
413         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
414
415 2019-02-21  David Kilzer  <ddkilzer@apple.com>
416
417         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
418         <https://webkit.org/b/194761>
419
420         Reviewed by Myles Maxfield.
421
422         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
423         (WTR::activateSystemCoreWebFonts): Log `error` to console if
424         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
425         to use ARC-compliant cast.
426         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
427         ARC-compliant cast.
428         (WTR::installFakeHelvetica): Log `error` to console if
429         CTFontManagerRegisterFontsForURL() fails, but only on supported
430         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
431         Call CFRelease() on `error` to fix the leak.  Update to use
432         ARC-compliant cast.
433         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
434         cast.
435
436 2019-02-21  Chris Dumez  <cdumez@apple.com>
437
438         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
439         https://bugs.webkit.org/show_bug.cgi?id=194481
440
441         Reviewed by Alex Christensen.
442
443         Give the processes a chance to shutdown and wait until we reached the expected number
444         of processes.
445
446         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
447
448 2019-02-21  Tim Horton  <timothy_horton@apple.com>
449
450         Fix the macOS build
451
452         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
453
454 2019-02-21  Tim Horton  <timothy_horton@apple.com>
455
456         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
457
458         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
459         I am a backwards.
460
461 2019-02-21  Tim Horton  <timothy_horton@apple.com>
462
463         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
464
465         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
466         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
467         We could force on UI-side compositing, but I feel like the test might be more
468         valuable exercising the normal path on each platform (though the original
469         bug was also UI-side specific). Though we can't validate that the overlay
470         layer was installed successfully, there are layout tests that do that.
471
472 2019-02-21  Tim Horton  <timothy_horton@apple.com>
473
474         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
475         https://bugs.webkit.org/show_bug.cgi?id=194845
476         <rdar://problem/47944579>
477
478         Reviewed by Antti Koivisto.
479
480         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
481         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
482
483 2019-02-21  Zalan Bujtas  <zalan@apple.com>
484
485         [LFC][Floats] Add support for placing formatting roots in-between floats.
486         https://bugs.webkit.org/show_bug.cgi?id=194902
487
488         Reviewed by Antti Koivisto.
489
490         * LayoutReloaded/misc/LFC-passing-tests.txt:
491
492 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
493
494         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
495         https://bugs.webkit.org/show_bug.cgi?id=194901
496
497         Unreviewed build fix.
498
499         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
500         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
501         WPEBackend-fdo-0.1 as library name.
502
503 2019-02-21  Rob Buis  <rbuis@igalia.com>
504
505         Update MIME type parser
506         https://bugs.webkit.org/show_bug.cgi?id=180526
507
508         Reviewed by Darin Adler.
509
510         Add tests involving leading and trailing whitespace, non-token
511         characters and quoted strings.
512
513         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
514         (TestWebKitAPI::TEST):
515
516 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
517
518         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
519         https://bugs.webkit.org/show_bug.cgi?id=194884
520
521         Reviewed by Michael Catanzaro.
522
523         * PlatformWin.cmake:
524
525 2019-02-20  Chris Dumez  <cdumez@apple.com>
526
527         Add API test for <rdar://problem/47471222>
528         https://bugs.webkit.org/show_bug.cgi?id=194847
529
530         Reviewed by Alex Christensen.
531
532         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
533
534 2019-02-20  Chris Dumez  <cdumez@apple.com>
535
536         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
537         https://bugs.webkit.org/show_bug.cgi?id=194872
538         <rdar://problem/47924500>
539
540         Reviewed by Alex Christensen.
541
542         Add API test coverage.
543
544         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
545
546 2019-02-20  Jer Noble  <jer.noble@apple.com>
547
548         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
549         https://bugs.webkit.org/show_bug.cgi?id=191332
550
551         Reviewed by Dean Jackson.
552
553         * Scripts/git-is-in-range: Added.
554
555 2019-02-20  Andy Estes  <aestes@apple.com>
556
557         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
558         https://bugs.webkit.org/show_bug.cgi?id=194869
559
560         Rubber-stamped by Jer Noble.
561
562         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
563         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
564         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
565         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
567         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
568
569 2019-02-20  Chris Dumez  <cdumez@apple.com>
570
571         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
572         https://bugs.webkit.org/show_bug.cgi?id=194857
573         <rdar://problem/47759323>
574
575         Reviewed by Alex Christensen.
576
577         Add API test coverage.
578
579         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
580
581 2019-02-20  Chris Dumez  <cdumez@apple.com>
582
583         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
584         https://bugs.webkit.org/show_bug.cgi?id=194829
585         <rdar://problem/47889906>
586
587         Reviewed by Alexey Proskuryakov.
588
589         Every time the TestOptions were changing we were creating both a new Web view and
590         a new WKContext, which would start a new Network process. In most cases, we only
591         need to contruct a new Web view and we do can keep reusing the same WKContext.
592         This patch implements this optimization and thus avoids spinning a lot of new
593         Network processes while running the layout tests.
594
595         * WebKitTestRunner/TestController.cpp:
596         (WTR::TestController::generateContextConfiguration const):
597         (WTR::TestController::generatePageConfiguration):
598         (WTR::TestController::createWebViewWithOptions):
599         (WTR::TestController::resetPreferencesToConsistentValues):
600         (WTR::updateTestOptionsFromTestHeader):
601         * WebKitTestRunner/TestController.h:
602         * WebKitTestRunner/TestOptions.h:
603         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
604         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
605         (WTR::TestOptions::hasSameInitializationOptions const):
606         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
607         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
608         (WTR::TestController::platformAddTestOptions const):
609
610 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
611
612         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
613         https://bugs.webkit.org/show_bug.cgi?id=167941
614
615         Reviewed by Carlos Garcia Campos.
616
617         * MiniBrowser/gtk/main.c:
618         (filterSavedCallback): Added.
619         (main): Support loading a JSON rule set file for content filtering.
620         * MiniBrowser/wpe/main.cpp:
621         (filterSavedCallback): Added.
622         (main): Support loading a JSON rule set file for content filtering.
623         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
624         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
625         (WTF::derefGPtr): Ditto.
626         (testEmptyStore):
627         (testSaveInvalidFilter):
628         (testSaveLoadFilter):
629         (testSavedFilterIdentifierMatch):
630         (testRemoveFilter):
631         (testSaveMultipleFilters):
632         (testSaveFilterFromFile):
633         (testFilterPersistence):
634         (beforeAll):
635         (afterAll):
636         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
637         (removeOldInjectedContentAndResetLists): Also reset content filters.
638         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
639         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
640         the element affected by the style sheet.
641         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
642         and returns it to be used by tests.
643         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
644         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
645         (serverCallback): Add support for serving a CSS style sheet for testing.
646         (beforeAll): Add call to testUserContentManagerContentFilter().
647         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
648
649 2019-02-19  Keith Rollin  <krollin@apple.com>
650
651         Add timing information to build output
652         https://bugs.webkit.org/show_bug.cgi?id=194839
653         <rdar://problem/48219609>
654
655         Reviewed by Alexey Proskuryakov.
656
657         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
658         emit each project's build time to its output. E.g.,
659
660             ** BUILD SUCCEEDED ** [0.132 sec]
661
662         * Scripts/webkitdirs.pm:
663         (XcodeOptions):
664
665 2019-02-19  Truitt Savell  <tsavell@apple.com>
666
667         Unreviewed, rolling out r241784.
668
669         Broke all OpenSource builds.
670
671         Reverted changeset:
672
673         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
674         instances view"
675         https://bugs.webkit.org/show_bug.cgi?id=172848
676         https://trac.webkit.org/changeset/241784
677
678 2019-02-19  Zalan Bujtas  <zalan@apple.com>
679
680         [LFC][Floats] Remove redundant intersecting logic
681         https://bugs.webkit.org/show_bug.cgi?id=194804
682
683         Reviewed by Antti Koivisto.
684
685         * LayoutReloaded/misc/LFC-passing-tests.txt:
686
687 2019-02-19  Dean Jackson  <dino@apple.com>
688
689         Clean-up output from generate-xcfilelists so it can be filtered
690         https://bugs.webkit.org/show_bug.cgi?id=194795
691
692         Reviewed by Joseph Pecoraro (and Keith Rollin).
693
694         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
695         make a slight tweak to filter-build-webkit so such lines are marked
696         as plain.
697
698         * Scripts/filter-build-webkit:
699         * Scripts/generate-xcfilelists:
700
701 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
702
703         pytest is not correctly auto-installed
704         https://bugs.webkit.org/show_bug.cgi?id=194707
705
706         Reviewed by Carlos Garcia Campos.
707
708         * Scripts/webkitpy/thirdparty/__init__.py:
709         (AutoinstallImportHook._install_pytest):
710
711 2019-02-18  Chris Dumez  <cdumez@apple.com>
712
713         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
714         https://bugs.webkit.org/show_bug.cgi?id=194797
715         <rdar://problem/48055151>
716
717         Reviewed by Geoffrey Garen.
718
719         Add API test coverage.
720
721         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
722
723 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
724
725         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
726         https://bugs.webkit.org/show_bug.cgi?id=194670
727         <rdar://problem/39066529>
728
729         Reviewed by Tim Horton.
730
731         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
732         pasted in an editable area as attachment elements.
733
734         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
735         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
736         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
737         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
738         (TestWebKitAPI::TEST):
739         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
740         (WTR::InjectedBundlePage::InjectedBundlePage):
741
742 2019-02-18  Alex Christensen  <achristensen@webkit.org>
743
744         Fix API test after r241728
745        ​https://bugs.webkit.org/show_bug.cgi?id=194723
746
747         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
748         (TEST):
749         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
750
751 2019-02-18  Daniel Bates  <dabates@apple.com>
752
753         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
754         https://bugs.webkit.org/show_bug.cgi?id=192824
755         <rdar://problem/47100332>
756
757         Reviewed by Wenson Hsieh.
758
759         Fix a bug where the wrong usage code was used for F13 thru F24.
760
761         * WebKitTestRunner/ios/HIDEventGenerator.mm:
762         (keyCodeForDOMFunctionKey):
763
764 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
765
766         Bytecode cache should a have a boot-specific validation
767         https://bugs.webkit.org/show_bug.cgi?id=194769
768         <rdar://problem/48149509>
769
770         Reviewed by Keith Miller.
771
772         Add test for WTF::bootSessionUUIDString()
773
774         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
775         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
776         (TEST):
777
778 2019-02-18  Alex Christensen  <achristensen@webkit.org>
779
780         Disable safe browsing in WKWebView and remove its WKPreferences API
781         https://bugs.webkit.org/show_bug.cgi?id=194723
782         <rdar://problem/48122993>
783
784         Reviewed by Geoffrey Garen.
785
786         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
787         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
788         (TEST):
789         (safeBrowsingView):
790         Make tests use SPI instead of API.
791
792 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
793
794         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
795         https://bugs.webkit.org/show_bug.cgi?id=194586
796
797         Reviewed by Ross Kirsling.
798
799         * DumpRenderTree/win/DumpRenderTree.cpp:
800         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
801         * Scripts/webkitpy/port/driver.py:
802         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
803
804 2019-02-17  David Kilzer  <ddkilzer@apple.com>
805
806         Unreviewed, rolling out r241620.
807
808         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
809         (Requested by ddkilzer on #webkit.)
810
811         Reverted changeset:
812
813         "[WTF] Add environment variable helpers"
814         https://bugs.webkit.org/show_bug.cgi?id=192405
815         https://trac.webkit.org/changeset/241620
816
817 2019-02-16  Zalan Bujtas  <zalan@apple.com>
818
819         [LFC] RenderImage's default intrinsic size is 0.
820         https://bugs.webkit.org/show_bug.cgi?id=194745
821
822         Reviewed by Antti Koivisto.
823
824         * LayoutReloaded/misc/LFC-passing-tests.txt:
825
826 2019-02-16  Zalan Bujtas  <zalan@apple.com>
827
828         [LFC][BFC] Add support for block replaced intrinsic width.
829         https://bugs.webkit.org/show_bug.cgi?id=194705
830
831         Reviewed by Simon Fraser.
832
833         * LayoutReloaded/misc/LFC-passing-tests.txt:
834
835 2019-02-16  Zalan Bujtas  <zalan@apple.com>
836
837         [LFC] Apply min/max width constraints to preferred width computation
838         https://bugs.webkit.org/show_bug.cgi?id=194739
839
840         Reviewed by Simon Fraser.
841
842         * LayoutReloaded/misc/LFC-passing-tests.txt:
843
844 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
845
846         [WTF] Add environment variable helpers
847         https://bugs.webkit.org/show_bug.cgi?id=192405
848
849         Reviewed by Michael Catanzaro.
850
851         * DumpRenderTree/mac/DumpRenderTree.mm:
852         (libraryPathForDumpRenderTree):
853         * DumpRenderTree/win/DumpRenderTree.cpp:
854         (libraryPathForDumpRenderTree):
855         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
856         (setUpIOSLayoutTestCommunication):
857         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
858         (beforeAll):
859         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
860         (main):
861         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
862         (WebKitTestBus::run):
863         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
864         (WTR::getOutputDir):
865         (WTR::initializeFontConfigSetting):
866         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
867         (WTR::InjectedBundle::platformInitialize):
868         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
869         (WTR::topLevelPath):
870         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
871         (WTR::topLevelPath):
872         (WTR::getOutputDir):
873         (WTR::activateFonts):
874         * WebKitTestRunner/TestController.cpp:
875         (WTR::TestController::libraryPathForTesting):
876         (WTR::TestController::generateContextConfiguration const):
877         (WTR::TestController::generatePageConfiguration):
878         (WTR::TestController::decideDestinationWithSuggestedFilename):
879         (WTR::TestController::platformAdjustContext):
880         * WebKitTestRunner/TestController.h:
881         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
882         (WTR::TestController::cocoaPlatformInitialize):
883         (WTR::TestController::platformAdjustContext):
884         * WebKitTestRunner/gtk/main.cpp:
885         (main):
886         * WebKitTestRunner/mac/TestControllerMac.mm:
887         (WTR::TestController::configureContentExtensionForTest):
888         * WebKitTestRunner/wpe/main.cpp:
889         (main):
890         Utilize WTF::Environment where possible.
891
892 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
893
894         [iOS] WKWebView callout bar is missing Change Writing Direction item
895         https://bugs.webkit.org/show_bug.cgi?id=190015
896         <rdar://problem/44810366>
897
898         Reviewed by Tim Horton.
899
900         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
901         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
902
903         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
904         (TestWebKitAPI::TEST):
905
906 2019-02-15  Chris Dumez  <cdumez@apple.com>
907
908         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
909         https://bugs.webkit.org/show_bug.cgi?id=194717
910         <rdar://problem/47884404>
911
912         Reviewed by Brady Eidson.
913
914         Add API test coverage.
915
916         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
917
918 2019-02-15  Youenn Fablet  <youenn@apple.com>
919
920         Make navigator.mediaDevices SecureContext
921         https://bugs.webkit.org/show_bug.cgi?id=194666
922
923         Reviewed by Eric Carlson.
924
925         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
926         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
927         (TEST_F):
928
929 2019-02-15  Brian Burg  <bburg@apple.com>
930
931         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
932         https://bugs.webkit.org/show_bug.cgi?id=194411
933         <rdar://problem/47787614>
934
935         Reviewed by Joseph Pecoraro.
936
937         Remove unnecessary soft linking macro usage.
938
939         * DumpRenderTree/mac/TestRunnerMac.mm:
940         (TestRunner::inspectorTestStubURL):
941         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
942         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
943         (WTR::TestRunner::inspectorTestStubURL):
944
945 2019-02-15  Commit Queue  <commit-queue@webkit.org>
946
947         Unreviewed, rolling out r241559 and r241566.
948         https://bugs.webkit.org/show_bug.cgi?id=194710
949
950         Causes layout test crashes under GuardMalloc (Requested by
951         ryanhaddad on #webkit).
952
953         Reverted changesets:
954
955         "[WTF] Add environment variable helpers"
956         https://bugs.webkit.org/show_bug.cgi?id=192405
957         https://trac.webkit.org/changeset/241559
958
959         "Unreviewed build fix for WinCairo Debug after r241559."
960         https://trac.webkit.org/changeset/241566
961
962 2019-02-15  Zalan Bujtas  <zalan@apple.com>
963
964         [LFC] Out-of-flow box is never a float box
965         https://bugs.webkit.org/show_bug.cgi?id=194704
966
967         Reviewed by Antti Koivisto.
968
969         * LayoutReloaded/misc/LFC-passing-tests.txt:
970
971 2019-02-10  Darin Adler  <darin@apple.com>
972
973         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
974         https://bugs.webkit.org/show_bug.cgi?id=194487
975
976         Reviewed by Daniel Bates.
977
978         * DumpRenderTree/win/DumpRenderTree.cpp:
979         (applicationId): Use makeString instead of String::format.
980         (main): Ditto.
981         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
982         (TestWebKitAPI::Util::createURLForResource): Ditto.
983         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
984         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
985
986         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
987         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
988         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
989         (WTR::createStringWithAttributes): Use appendLiteral.
990         (WTR::AccessibilityUIElement::helpText const): Ditto.
991         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
992         directly instead of using String::format.
993         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
994         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
995
996 2019-02-15  Truitt Savell  <tsavell@apple.com>
997
998         Unreviewed, rolling out r241564.
999
1000         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1001
1002         Reverted changeset:
1003
1004         "[Mac] WebInspectorUI.framework does not need to be soft-
1005         linked anymore"
1006         https://bugs.webkit.org/show_bug.cgi?id=194411
1007         https://trac.webkit.org/changeset/241564
1008
1009 2019-02-15  Saam barati  <sbarati@apple.com>
1010
1011         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1012         https://bugs.webkit.org/show_bug.cgi?id=194036
1013
1014         Reviewed by Yusuke Suzuki.
1015
1016         * Scripts/run-jsc-stress-tests:
1017
1018 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1019
1020         Fix the build.
1021
1022         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1023         (WTR::UIScriptController::drawSquareInEditableImage):
1024         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1025         (TestWebKitAPI::drawSquareInEditableImage):
1026
1027 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1028
1029         Fix the build.
1030
1031         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1032         (WTR::UIScriptController::drawSquareInEditableImage):
1033         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1034         (TestWebKitAPI::drawSquareInEditableImage):
1035
1036 2019-02-14  Brian Burg  <bburg@apple.com>
1037
1038         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1039         https://bugs.webkit.org/show_bug.cgi?id=194411
1040         <rdar://problem/47787614>
1041
1042         Reviewed by Joseph Pecoraro.
1043
1044         Remove unnecessary soft linking macro usage.
1045
1046         * DumpRenderTree/mac/TestRunnerMac.mm:
1047         (TestRunner::inspectorTestStubURL):
1048         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1049         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1050         (WTR::TestRunner::inspectorTestStubURL):
1051
1052 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1053
1054         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1055         https://bugs.webkit.org/show_bug.cgi?id=194599
1056
1057         Reviewed by Lucas Forschler.
1058
1059         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1060         (StatusBubble._build_bubble):
1061
1062 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1063
1064         [ews-app] Set Foreign Key in Django build model
1065         https://bugs.webkit.org/show_bug.cgi?id=194667
1066
1067         Reviewed by Lucas Forschler.
1068
1069         * BuildSlaveSupport/ews-app/ews/models/build.py:
1070         (Build):
1071
1072 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1073
1074         [WTF] Add environment variable helpers
1075         https://bugs.webkit.org/show_bug.cgi?id=192405
1076
1077         Reviewed by Michael Catanzaro.
1078
1079         * DumpRenderTree/mac/DumpRenderTree.mm:
1080         (libraryPathForDumpRenderTree):
1081         * DumpRenderTree/win/DumpRenderTree.cpp:
1082         (libraryPathForDumpRenderTree):
1083         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1084         (setUpIOSLayoutTestCommunication):
1085         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1086         (TestWebKitAPI::strip):
1087         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1088         (beforeAll):
1089         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1090         (main):
1091         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1092         (WebKitTestBus::run):
1093         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1094         (WTR::getOutputDir):
1095         (WTR::initializeFontConfigSetting):
1096         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1097         (WTR::InjectedBundle::platformInitialize):
1098         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1099         (WTR::topLevelPath):
1100         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1101         (WTR::topLevelPath):
1102         (WTR::getOutputDir):
1103         (WTR::activateFonts):
1104         * WebKitTestRunner/TestController.cpp:
1105         (WTR::TestController::libraryPathForTesting):
1106         (WTR::TestController::generateContextConfiguration const):
1107         (WTR::TestController::generatePageConfiguration):
1108         (WTR::TestController::decideDestinationWithSuggestedFilename):
1109         (WTR::TestController::platformAdjustContext):
1110         * WebKitTestRunner/TestController.h:
1111         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1112         (WTR::TestController::cocoaPlatformInitialize):
1113         (WTR::TestController::platformAdjustContext):
1114         * WebKitTestRunner/gtk/main.cpp:
1115         (main):
1116         * WebKitTestRunner/mac/TestControllerMac.mm:
1117         (WTR::TestController::configureContentExtensionForTest):
1118         * WebKitTestRunner/wpe/main.cpp:
1119         (main):
1120         Utilize WTF::Environment where possible.
1121
1122 2019-02-14  Chris Dumez  <cdumez@apple.com>
1123
1124         [PSON] Introduce a WebContent Process cache
1125         https://bugs.webkit.org/show_bug.cgi?id=194594
1126         <rdar://problem/46793397>
1127
1128         Reviewed by Geoff Garen.
1129
1130         Update API tests to turn on the WebContent Process cache.
1131
1132         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1133
1134 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1135
1136         Unreviewed, build fix after r241480
1137
1138         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1139         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1140         (-[DragAndDropSimulator initWithWebView:]):
1141
1142 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1143
1144         AX: ARIA Reflection was disabled in error
1145         https://bugs.webkit.org/show_bug.cgi?id=194647
1146         <rdar://problem/48068336>
1147
1148         Reviewed by Ryosuke Niwa.
1149
1150         Remove test override now that this feature should be enabled by default.
1151
1152         * WebKitTestRunner/TestController.cpp:
1153         (WTR::TestController::resetPreferencesToConsistentValues):
1154
1155 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1156
1157         Unreviewed, rolling out r241486.
1158         https://bugs.webkit.org/show_bug.cgi?id=194655
1159
1160         causing API failures in builds (Requested by ShawnRoberts on
1161         #webkit).
1162
1163         Reverted changeset:
1164
1165         "[Cocoa] Media elements will restart network buffering just
1166         before suspending"
1167         https://bugs.webkit.org/show_bug.cgi?id=193691
1168         https://trac.webkit.org/changeset/241486
1169
1170 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1171
1172         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1173         https://bugs.webkit.org/show_bug.cgi?id=194622
1174
1175         Reviewed by Antti Koivisto.
1176
1177         * LayoutReloaded/misc/LFC-passing-tests.txt:
1178
1179 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1180
1181         [LFC] Shrink-to-fit-width should be constrained by min/max width
1182         https://bugs.webkit.org/show_bug.cgi?id=194653
1183
1184         Reviewed by Antti Koivisto.
1185
1186         * LayoutReloaded/misc/LFC-passing-tests.txt:
1187
1188 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1189
1190         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1191         https://bugs.webkit.org/show_bug.cgi?id=194641
1192
1193         Reviewed by Geoffrey Garen.
1194
1195         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1196         so that the test would fail without this fix.
1197
1198         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1199         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1200
1201 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1202
1203         [ews-app] Change log level for a log statement
1204
1205         Unreviewed minor fix.
1206
1207         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1208         (Patch.save_patch):
1209
1210 2019-02-13  Jer Noble  <jer.noble@apple.com>
1211
1212         [Cocoa] Media elements will restart network buffering just before suspending
1213         https://bugs.webkit.org/show_bug.cgi?id=193691
1214
1215         Reviewed by Eric Carlson.
1216
1217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1218         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1219         (TEST):
1220
1221 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1222
1223         [ews-app] Fetch builder id to name mapping
1224         https://bugs.webkit.org/show_bug.cgi?id=194355
1225
1226         Reviewed by Lucas Forschler.
1227
1228         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1229         (Buildbot.get_builder_id_to_name_mapping):
1230         (Buildbot._get_display_name_from_builder_name):
1231
1232 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1233
1234         Further restricting webarchive loads
1235         https://bugs.webkit.org/show_bug.cgi?id=194567
1236         <rdar://problem/47610130>
1237
1238         Reviewed by Youenn Fablet.
1239
1240         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1241         navigations on drop.
1242
1243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1244         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1245         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1246         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1247         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1248         (TestWebKitAPI::TEST):
1249         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1250         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1251         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1252         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1253         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1254         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1255         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1256
1257 2019-02-13  John Wilander  <wilander@apple.com>
1258
1259         Store Ad Click Attribution requests in the network process
1260         https://bugs.webkit.org/show_bug.cgi?id=194510
1261         <rdar://problem/47650118>
1262
1263         Reviewed by Alex Christensen and Daniel Bates.
1264
1265         This patch adds two TestRunner functions:
1266         - dumpAdClickAttribution()
1267         - clearAdClickAttribution()
1268
1269         They call into the network process to dump and clear Ad Click
1270         Attribution state, respectively.
1271
1272         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1273         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1274         (WTR::TestRunner::dumpAdClickAttribution):
1275         (WTR::TestRunner::clearAdClickAttribution):
1276         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1277         * WebKitTestRunner/TestController.cpp:
1278         (WTR::TestController::resetStateToConsistentValues):
1279         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1280         (WTR::adClickAttributionStringResultCallback):
1281         (WTR::TestController::dumpAdClickAttribution):
1282         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1283         (WTR::adClickAttributionVoidCallback):
1284         (WTR::TestController::clearAdClickAttribution):
1285         * WebKitTestRunner/TestController.h:
1286         * WebKitTestRunner/TestInvocation.cpp:
1287         (WTR::TestInvocation::dumpResults):
1288         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1289         (WTR::TestInvocation::dumpAdClickAttribution):
1290         * WebKitTestRunner/TestInvocation.h:
1291
1292 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1293
1294         [ews-app] Generate status-bubble
1295         https://bugs.webkit.org/show_bug.cgi?id=194572
1296
1297         Reviewed by Lucas Forschler.
1298
1299         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1300         (StatusBubble._build_bubble):
1301         (StatusBubble._should_show_bubble_for):
1302         (StatusBubble._build_bubbles_for_patch):
1303
1304 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1305
1306         [ews-app] Add status bubble html template
1307         https://bugs.webkit.org/show_bug.cgi?id=194571
1308
1309         Reviewed by Lucas Forschler.
1310
1311         * BuildSlaveSupport/ews-app/ews/templates: Added.
1312         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1313
1314 2019-02-12  Chris Dumez  <cdumez@apple.com>
1315
1316         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1317         https://bugs.webkit.org/show_bug.cgi?id=194568
1318         <rdar://problem/47944490>
1319
1320         Reviewed by Ryosuke Niwa.
1321
1322         Add API test coverage.
1323
1324         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1325         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1326
1327 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1328
1329         webkitpy: Remove bug_dummy from parsed test expectations
1330         https://bugs.webkit.org/show_bug.cgi?id=194562
1331         <rdar://problem/47853999>
1332
1333         Reviewed by Lucas Forschler.
1334
1335         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1336         (TestExpectationParser):
1337         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1338         skipped tests.
1339         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1340
1341 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1342
1343         [ews-app] Add method to fetch patch
1344         https://bugs.webkit.org/show_bug.cgi?id=194518
1345
1346         Reviewed by Lucas Forschler.
1347
1348         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1349         (Patch.get_patch):
1350
1351 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1352
1353         [LFC] Expand tests coverage (60 new tests -> 860)
1354
1355         Unreviewed test gardening (run-singly, --child-processes=1).
1356
1357         * LayoutReloaded/misc/LFC-passing-tests.txt:
1358
1359 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1360
1361         Allow pages to trigger programmatic paste from script on iOS
1362         https://bugs.webkit.org/show_bug.cgi?id=194271
1363         <rdar://problem/47808810>
1364
1365         Reviewed by Tim Horton.
1366
1367         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1368
1369         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1370         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1371         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1372         (WTR::UIScriptController::rectForMenuAction const):
1373
1374         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1375         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1376         for when the menu is shown or hidden.
1377
1378         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1379         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1380         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1381         (WTR::UIScriptController::setDidShowMenuCallback):
1382         (WTR::UIScriptController::didShowMenuCallback const):
1383         (WTR::UIScriptController::setDidHideMenuCallback):
1384         (WTR::UIScriptController::didHideMenuCallback const):
1385         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1386         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1387         (WTR::UIScriptController::rectForMenuAction const):
1388         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1389         * WebKitTestRunner/TestController.cpp:
1390         (WTR::TestController::resetPreferencesToConsistentValues):
1391         (WTR::updateTestOptionsFromTestHeader):
1392         * WebKitTestRunner/TestOptions.h:
1393
1394         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1395         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1396
1397         (WTR::TestOptions::hasSameInitializationOptions const):
1398         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1399         (WTR::UIScriptController::calendarType const):
1400         (WTR::UIScriptController::platformUndoManager const):
1401         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1402         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1403         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1404         (-[TestRunnerWKWebView dealloc]):
1405         (-[TestRunnerWKWebView _didShowMenu]):
1406         (-[TestRunnerWKWebView _didHideMenu]):
1407
1408         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1409
1410         * WebKitTestRunner/ios/TestControllerIOS.mm:
1411         (WTR::handleMenuWillHideNotification):
1412         (WTR::handleMenuDidHideNotification):
1413         (WTR::TestController::platformInitialize):
1414         (WTR::TestController::platformDestroy):
1415         (WTR::TestController::platformResetStateToConsistentValues):
1416
1417         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1418         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1419
1420         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1421         (WTR::forEachViewInHierarchy):
1422         (WTR::findViewInHierarchyOfType):
1423
1424         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1425         functions that dig through a given view's hierarchy in search of a view of a given class.
1426
1427         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1428         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1429         (WTR::UIScriptController::selectionCaretViewRect const):
1430         (WTR::UIScriptController::selectionRangeViewRects const):
1431         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1432         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1433
1434         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1435
1436         (WTR::UIScriptController::rectForMenuAction const):
1437
1438         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1439         callout bar) whose label matches the given string.
1440
1441         (WTR::UIScriptController::platformContentView const):
1442
1443         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1444         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1445         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1446
1447         (WTR::UIScriptController::platformUndoManager const): Deleted.
1448         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1449         (WTR::UIScriptController::platformContentView const):
1450         (WTR::UIScriptController::platformUndoManager const): Deleted.
1451
1452 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1453
1454         webkitpy: No option to only show unexpected failures in results.html for iPad
1455         https://bugs.webkit.org/show_bug.cgi?id=194554
1456         <rdar://problem/47922442>
1457
1458         Rubber-stamped by Aakash Jain.
1459
1460         Just because a TestExpecations file does not exist for a specific platform does not mean that
1461         TestExpecations are not being used, given that platforms inherit test expectations.
1462
1463         * Scripts/webkitpy/port/base.py:
1464         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1465         * Scripts/webkitpy/port/base_unittest.py:
1466         (PortTest.test_uses_test_expectations_file):
1467
1468 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1469
1470         Remove setDefersLoading infrastructure from WebKit2
1471         https://bugs.webkit.org/show_bug.cgi?id=194506
1472
1473         Reviewed by Brady Eidson.
1474
1475         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1476         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1477         (WTR::TestRunner::setDefersLoading): Deleted.
1478         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1479
1480 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1481
1482         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1483         https://bugs.webkit.org/show_bug.cgi?id=194522
1484         <rdar://problem/47789393>
1485
1486         Reviewed by Chris Dumez.
1487
1488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1489         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1490         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1491         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1492
1493 2019-02-12  Andy Estes  <aestes@apple.com>
1494
1495         [iOSMac] Enable Parental Controls Content Filtering
1496         https://bugs.webkit.org/show_bug.cgi?id=194521
1497         <rdar://39732376>
1498
1499         Reviewed by Tim Horton.
1500
1501         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1502
1503 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1504
1505         [LFC][IFC] Add intrinsic width support for float boxes.
1506         https://bugs.webkit.org/show_bug.cgi?id=194528
1507
1508         Reviewed by Antti Koivisto.
1509
1510         Expand tests coverage (2 new tests -> 800).
1511         (This is the correct test ordering --runs-singly --child-processes=1)
1512
1513         * LayoutReloaded/misc/LFC-passing-tests.txt:
1514
1515 2019-02-12  Rob Buis  <rbuis@igalia.com>
1516
1517         Implement serializing in MIME type parser
1518         https://bugs.webkit.org/show_bug.cgi?id=193909
1519
1520         Reviewed by Darin Adler.
1521
1522         Add various tests involving upper case, non-ASCII, control/null characters,
1523         various HTTP whitespace, single quotes and an unpaired surrogate.
1524
1525         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1526         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1527         (TestWebKitAPI::serializeIfValid):
1528         (TestWebKitAPI::TEST):
1529
1530 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1531
1532         [Cocoa] Ask platform for generic font family mappings
1533         https://bugs.webkit.org/show_bug.cgi?id=187723
1534         <rdar://problem/41892438>
1535
1536         Reviewed by Brent Fulgham.
1537
1538         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1539
1540         * DumpRenderTree/mac/DumpRenderTree.mm:
1541         (allowedFontFamilySet):
1542         * WebKitTestRunner/mac/TestControllerMac.mm:
1543         (WTR::allowedFontFamilySet):
1544
1545 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1546
1547         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1548         https://bugs.webkit.org/show_bug.cgi?id=193622
1549
1550         Reviewed by Michael Catanzaro.
1551
1552         This adds support for loading content extension rule sets from the JSON files which
1553         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1554         of WKTR for this could be removed, but that is left for a follow-up patch with
1555         cleanups.
1556
1557         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1558         * WebKitTestRunner/TestController.cpp:
1559         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1560         avoid having the null-terminator copied into the result.
1561         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1562         part of the preparations to run a test.
1563         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1564         (WTR::contentExtensionStoreCallback): Added.
1565         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1566         used for content extensions test.
1567         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1568         extensions and compiling the JSON rule set for tests involving content extensions.
1569         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1570         testing and disables content extensions.
1571         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1572         resetContentExtensions().
1573         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1574         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1575         configureContentExtensionForTest(), and userContentController().
1576
1577 2019-02-11  Daniel Bates  <dabates@apple.com>
1578
1579         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1580         https://bugs.webkit.org/show_bug.cgi?id=191446
1581         <rdar://problem/45929460>
1582
1583         Reviewed by Tim Horton.
1584
1585         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1586
1587         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1588         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1589         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1590         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1591         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1592         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1593         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1594         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1595         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1596         (WTR::arrayLength):
1597         (WTR::parseModifierArray):
1598         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1599         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1600         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1601         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1602
1603 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1604
1605         Unreviewed, rolling out r241272 and r241276.
1606         https://bugs.webkit.org/show_bug.cgi?id=194514
1607
1608         Broke the Apple Internal build and the fix requires human
1609         intervention :( (Requested by dydz on #webkit).
1610
1611         Reverted changesets:
1612
1613         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1614         https://bugs.webkit.org/show_bug.cgi?id=191446
1615         https://trac.webkit.org/changeset/241272
1616
1617         "Fix internal iOS build after r241272"
1618         https://bugs.webkit.org/show_bug.cgi?id=191446
1619         https://trac.webkit.org/changeset/241276
1620
1621 2019-02-11  Truitt Savell  <tsavell@apple.com>
1622
1623         Unreviewed, rolling out r241269.
1624
1625         Caused 5 layout tests crashes on Mac WK1
1626
1627         Reverted changeset:
1628
1629         "DumpRenderTree should report unknown options"
1630         https://bugs.webkit.org/show_bug.cgi?id=191303
1631         https://trac.webkit.org/changeset/241269
1632
1633 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1634
1635         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1636         https://bugs.webkit.org/show_bug.cgi?id=194313
1637
1638         Reviewed by Tim Horton.
1639
1640         Add a helper to determine whether the web view is presenting modal UI.
1641
1642         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1643         (WTR::UIScriptController::isPresentingModally const):
1644         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1645         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1646         (WTR::UIScriptController::isPresentingModally const):
1647         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1648         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1649         (WTR::UIScriptController::calendarType const): Deleted.
1650         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1651         (WTR::UIScriptController::isPresentingModally const):
1652         (WTR::UIScriptController::calendarType const):
1653         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1654         (WTR::UIScriptController::calendarType const):
1655
1656 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1657
1658         GCHeapInspector: Show the retained sizes in more places
1659         https://bugs.webkit.org/show_bug.cgi?id=194464
1660
1661         Reviewed by Simon Fraser.
1662
1663         * GCHeapInspector/gc-heap-inspector.html:
1664         * GCHeapInspector/script/interface.js:
1665         (HeapInspectorUtils.humanReadableSize):
1666         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1667         (HeapInspectorUtils.spanForNode.span.span):
1668         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1669         (HeapSnapshotInspector.prototype.buildRoots):
1670
1671 2019-02-11  Daniel Bates  <dabates@apple.com>
1672
1673         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1674         https://bugs.webkit.org/show_bug.cgi?id=191446
1675         <rdar://problem/45929460>
1676
1677         Reviewed by Tim Horton.
1678
1679         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1680
1681         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1682         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1683         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1684         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1685         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1686         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1687         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1688         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1689         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1690         (WTR::arrayLength):
1691         (WTR::parseModifierArray):
1692         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1693         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1694         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1695         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1696
1697 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1698
1699         DumpRenderTree should report unknown options
1700         https://bugs.webkit.org/show_bug.cgi?id=191303
1701
1702         Reviewed by Frédéric Wang.
1703
1704         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1705         to report unknown options.
1706         Added and assigned test options which are currently used in tests.
1707
1708         * DumpRenderTree/TestOptions.cpp:
1709         (TestOptions::TestOptions):
1710
1711 2019-02-11  Truitt Savell  <tsavell@apple.com>
1712
1713         Unreviewed, rolling out r241229.
1714
1715         Revision broke internal builds for watchOS.
1716
1717         Reverted changeset:
1718
1719         "[Cocoa] Ask platform for generic font family mappings"
1720         https://bugs.webkit.org/show_bug.cgi?id=187723
1721         https://trac.webkit.org/changeset/241229
1722
1723 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1724
1725         [WinCairo][MiniBrowser] Basic authentication always fails.
1726         https://bugs.webkit.org/show_bug.cgi?id=194496
1727
1728         Reviewed by Don Olmstead.
1729
1730         * MiniBrowser/win/DialogHelper.h:
1731         (Dialog::getText):
1732
1733 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1734
1735         [GStreamer] GstMappedBuffer testsuite build fails
1736         https://bugs.webkit.org/show_bug.cgi?id=194495
1737
1738         Reviewed by Carlos Garcia Campos.
1739
1740         Fix the build by explicitely adding the gstreamer1.0-audio include
1741         directories to the include path.
1742
1743         * TestWebKitAPI/PlatformGTK.cmake:
1744         * TestWebKitAPI/PlatformWPE.cmake:
1745
1746 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1747
1748         [GTK][WPE] Add enable-javascript-markup setting
1749         https://bugs.webkit.org/show_bug.cgi?id=193439
1750
1751         Reviewed by Michael Catanzaro.
1752
1753         Add test cases to check the new setting.
1754
1755         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1756         (testWebKitSettings):
1757         (testWebKitSettingsJavaScriptMarkup):
1758         (beforeAll):
1759
1760 2019-02-10  Darin Adler  <darin@apple.com>
1761
1762         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1763         https://bugs.webkit.org/show_bug.cgi?id=194485
1764
1765         Reviewed by Daniel Bates.
1766
1767         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1768
1769 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1770
1771         Add more tests for clampTo<>()
1772         https://bugs.webkit.org/show_bug.cgi?id=194462
1773
1774         Reviewed by Geoffrey Garen.
1775
1776         Darin suggested to test the very last floating point number
1777         at the boundaries when truncating to integer.
1778         I added test for max/min and max-1/min-1.
1779
1780         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1781         (TestWebKitAPI::TEST):
1782
1783 2019-02-09  Darin Adler  <darin@apple.com>
1784
1785         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1786         https://bugs.webkit.org/show_bug.cgi?id=194021
1787
1788         Reviewed by Geoffrey Garen.
1789
1790         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1791         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1792         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1793
1794 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1795
1796         [LFC][IFC] Add intrinsic width support for basic inline containers
1797         https://bugs.webkit.org/show_bug.cgi?id=194473
1798
1799         Reviewed by Antti Koivisto.
1800
1801         Expand tests coverage (11 new tests -> 798)
1802
1803         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1804
1805 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1806
1807         Fix MiniBrowser's entitlements
1808         https://bugs.webkit.org/show_bug.cgi?id=192431
1809
1810         Reviewed by Joseph Pecoraro.
1811
1812         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1813         files, making it impossible to load any extension.
1814
1815         * MiniBrowser/MiniBrowser.entitlements:
1816
1817 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1818
1819         [Cocoa] Ask platform for generic font family mappings
1820         https://bugs.webkit.org/show_bug.cgi?id=187723
1821         <rdar://problem/41892438>
1822
1823         Reviewed by Brent Fulgham.
1824
1825         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1826
1827         * DumpRenderTree/mac/DumpRenderTree.mm:
1828         (allowedFontFamilySet):
1829         * WebKitTestRunner/mac/TestControllerMac.mm:
1830         (WTR::allowedFontFamilySet):
1831
1832 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1833
1834         [GTK] Implement back/forward touchpad gesture
1835         https://bugs.webkit.org/show_bug.cgi?id=193919
1836
1837         Reviewed by Michael Catanzaro.
1838
1839         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1840         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1841
1842 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1843
1844         Add SPI to use networking daemon instead of XPC service
1845         https://bugs.webkit.org/show_bug.cgi?id=194427
1846
1847         Reviewed by Geoffrey Garen
1848
1849         * MiniBrowser/MiniBrowser.entitlements:
1850
1851 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1852
1853         [ews-build] Ensure that every builder in config.json has short name
1854         https://bugs.webkit.org/show_bug.cgi?id=194461
1855
1856         Reviewed by Lucas Forschler.
1857
1858         * BuildSlaveSupport/ews-build/loadConfig.py:
1859         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1860
1861 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1862
1863         [ews-build] Add short name to config.json
1864         https://bugs.webkit.org/show_bug.cgi?id=194456
1865
1866         Reviewed by Lucas Forschler.
1867
1868         * BuildSlaveSupport/ews-build/config.json: Added short name.
1869         * BuildSlaveSupport/ews-build/loadConfig.py:
1870         (loadBuilderConfig): Set the short name as the builder description.
1871
1872 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1873
1874         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1875         https://bugs.webkit.org/show_bug.cgi?id=194418
1876
1877         Reviewed by Lucas Forschler.
1878
1879         Do not include errors trying when finding crashlogs at the end of
1880         a run-webkit-tests run since we don't process those errors.
1881
1882         * Scripts/webkitpy/port/darwin.py:
1883         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1884         * Scripts/webkitpy/port/ios_device.py:
1885         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1886         * Scripts/webkitpy/port/watch_device.py:
1887         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1888
1889 2019-02-08  Beth Dakin  <bdakin@apple.com>
1890
1891         Add afterScreenUpdates to WKSnapshotConfiguration
1892         https://bugs.webkit.org/show_bug.cgi?id=194362
1893         -and corresponding-
1894         <rdar://problem/40655528> Please add an "after screen updates" property to 
1895         WKSnapshotConfiguration (to solve blank snapshots)
1896
1897         Reviewed by Tim Horton.
1898
1899         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1900         (TEST):
1901
1902 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1903
1904         clampTo(): do not convert the input to double when dealing with integers
1905         https://bugs.webkit.org/show_bug.cgi?id=194263
1906         <rdar://problem/47692312>
1907
1908         Reviewed by Darin Adler.
1909
1910         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1911         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1912         (TestWebKitAPI::testClampFloatingPointToInteger):
1913         (TestWebKitAPI::testClampSameSignIntegers):
1914         (TestWebKitAPI::testClampUnsignedToSigned):
1915         (TestWebKitAPI::testClampSignedToUnsigned):
1916
1917 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1918
1919         webkitpy: Respect --dedicated-simulators flag
1920         https://bugs.webkit.org/show_bug.cgi?id=194416
1921         <rdar://problem/47894722>
1922
1923         Reviewed by Lucas Forschler.
1924
1925         * Scripts/webkitpy/port/device_port.py:
1926         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1927         available devices can be safely ignored.
1928
1929 2019-02-07  Keith Rollin  <krollin@apple.com>
1930
1931         Remove extra copy of 100x100-red.tga
1932         https://bugs.webkit.org/show_bug.cgi?id=194371
1933         <rdar://problem/47873465>
1934
1935         Reviewed by Said Abou-Hallawa.
1936
1937         In order to help it pass its tests, Bug 194190 added a second copy of
1938         the file 100x100-red.tga. However, it turns out that this additional
1939         file wasn't actually needed, and that that sole previous copy was
1940         sufficient. At the same time, this second copy -- which was copied to
1941         the same location in the build output as the first copy -- now caused
1942         XCBuild to complain because there were two production rules for the
1943         same output file. Address this by removing the newly-added extra copy.
1944
1945         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1946         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1947
1948 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1949
1950         Deprecate WKBundlePageSetDefersLoading
1951         https://bugs.webkit.org/show_bug.cgi?id=191394
1952
1953         Reviewed by Dean Jackson.
1954
1955         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1956         (WTR::TestRunner::setDefersLoading):
1957
1958 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1959
1960         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1961         https://bugs.webkit.org/show_bug.cgi?id=194391
1962
1963         Reviewed by Antti Koivisto.
1964
1965         * LayoutReloaded/misc/LFC-passing-tests.txt:
1966
1967 2019-02-06  Keith Rollin  <krollin@apple.com>
1968
1969         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1970         https://bugs.webkit.org/show_bug.cgi?id=193975
1971         <rdar://problem/47643306>
1972
1973         Reviewed by Tim Horton.
1974
1975         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1976         the Info.plist file into the bundle. This step is not necessary as the
1977         implicit "bundle up all the build products into a framework" build
1978         phase does this already. Having the Copy Bundle Resources phase do
1979         this causes a conflict under XCBuild, which objects to two build
1980         phases producing the same file (Info.plist). Address this by removing
1981         Info.plist from the Copy Bundle Resources phase.
1982
1983         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1984
1985 2019-02-06  Keith Rollin  <krollin@apple.com>
1986
1987         Really enable the automatic checking and regenerations of .xcfilelists during builds
1988         https://bugs.webkit.org/show_bug.cgi?id=194357
1989         <rdar://problem/47861231>
1990
1991         Reviewed by Chris Dumez.
1992
1993         Bug 194124 was supposed to enable the automatic checking and
1994         regenerating of .xcfilelist files during the build. While related
1995         changes were included in that patch, the change to actually enable the
1996         operation somehow was omitted. This patch actually enables the
1997         operation. The check-xcfilelist.sh scripts now check
1998         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1999         from the checking.
2000
2001         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2002         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2003
2004 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2005
2006         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2007         <https://webkit.org/b/194286>
2008         <rdar://problem/47815558>
2009
2010         Reviewed by Alexey Proskuryakov.
2011
2012         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2013         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2014         WKRetainPtr<> to avoid leaking the WKDataRef.
2015
2016 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2017
2018         Unreviewed, fix a typo
2019
2020         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2021
2022 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2023
2024         [GTK][WPE] force libpsl build to use ICU in jhbuild
2025         https://bugs.webkit.org/show_bug.cgi?id=194288
2026
2027         Reviewed by Carlos Garcia Campos.
2028
2029         * gtk/jhbuild.modules:
2030         Require ICU for libpsl build in jhbuild, like done in WPE.
2031
2032 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2033
2034         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2035         https://bugs.webkit.org/show_bug.cgi?id=194209
2036
2037         Reviewed by Carlos Garcia Campos.
2038
2039         Enhance TestCookieManager to ensure this doesn't happen again.
2040
2041         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2042         (testCookieManagerPersistentStorage):
2043         (beforeAll):
2044
2045 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2046
2047         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2048         https://bugs.webkit.org/show_bug.cgi?id=194324
2049
2050         Reviewed by Andy Estes.
2051
2052         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2053         part of the name is already implicit, since this is in testing code in TestOptions.
2054
2055         * WebKitTestRunner/TestController.cpp:
2056         (WTR::TestController::generateContextConfiguration const):
2057         (WTR::updateTestOptionsFromTestHeader):
2058         * WebKitTestRunner/TestOptions.h:
2059         (WTR::TestOptions::hasSameInitializationOptions const):
2060
2061 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2062
2063         [ews-build] Allow * as platform for builders and workers
2064         https://bugs.webkit.org/show_bug.cgi?id=188533
2065
2066         Reviewed by Lucas Forschler.
2067
2068         * BuildSlaveSupport/ews-build/loadConfig.py:
2069         (checkWorkersAndBuildersForConsistency):
2070
2071 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2072
2073         [ews-build] Add few bots to config.json
2074         https://bugs.webkit.org/show_bug.cgi?id=194304
2075
2076         Reviewed by Lucas Forschler.
2077
2078         * BuildSlaveSupport/ews-build/config.json:
2079
2080 2019-02-05  Keith Rollin  <krollin@apple.com>
2081
2082         Enable the automatic checking and regenerations of .xcfilelists during builds
2083         https://bugs.webkit.org/show_bug.cgi?id=194124
2084         <rdar://problem/47721277>
2085
2086         Reviewed by Tim Horton.
2087
2088         Bug 193790 add a facility for checking -- during build time -- that
2089         any needed .xcfilelist files are up-to-date and for updating them if
2090         they are not. This facility was initially opt-in by setting
2091         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2092         the process seemed robust. Its now time to enable this facility and
2093         make it opt-out. If there is a need to disable this facility, set and
2094         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2095         running `make` or `build-webkit`, or before running Xcode from the
2096         command line.
2097
2098         Additionally, remove the step that generates a list of source files
2099         going into the UnifiedSources build step. It's only necessarily to
2100         specify Sources.txt and SourcesCocoa.txt as inputs.
2101
2102         * Scripts/generate-xcfilelists:
2103
2104 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2105
2106         [GTK][WPE] force libpsl build to use ICU in jhbuild
2107         https://bugs.webkit.org/show_bug.cgi?id=194288
2108
2109         Reviewed by Philippe Normand.
2110
2111         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2112         This can cause build failures if libidn is detected but libunistring is not available.
2113
2114         Make sure that ICU is used for runtime and builtin PSL data.
2115
2116         * gtk/jhbuild.modules:
2117         * wpe/jhbuild.modules:
2118
2119 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2120
2121         [ews-app] Modified timestamp should be updated on updating data
2122         https://bugs.webkit.org/show_bug.cgi?id=194295
2123
2124         Reviewed by Lucas Forschler.
2125
2126         * BuildSlaveSupport/ews-app/ews/models/build.py:
2127         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2128         * BuildSlaveSupport/ews-app/ews/models/step.py:
2129
2130 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2131
2132         Unreviewed, rolling out r240742.
2133
2134         Causes crashes on iOS simulator.
2135
2136         Reverted changeset:
2137
2138         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2139         not focused in a content-editable element"
2140         https://bugs.webkit.org/show_bug.cgi?id=192824
2141         https://trac.webkit.org/changeset/240742
2142
2143 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2144
2145         run-webkit-tests emits message "...running None" when running tests
2146         https://bugs.webkit.org/show_bug.cgi?id=194133
2147         <rdar://problem/47724738>
2148
2149         Reviewed by Lucas Forschler.
2150
2151         * Scripts/webkitpy/xcode/device_type.py:
2152         (DeviceType.__str__): Use both version mapping tables and use just the variant
2153         name if no version name is available.
2154         * Scripts/webkitpy/xcode/device_type_unittest.py:
2155         (DeviceTypeTest):
2156         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2157         an associated named.
2158
2159 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2160
2161         [WPE] require python3-setuptools for meson build in jhbuild
2162         https://bugs.webkit.org/show_bug.cgi?id=194287
2163
2164         Reviewed by Philippe Normand.
2165
2166         python3-setuptools is needed to build meson in jhbuild.
2167         It is already required by the GTK port.
2168
2169         * wpe/install-dependencies:
2170
2171 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2172
2173         [ews-app] Add method to save BuilderMapping to database
2174         https://bugs.webkit.org/show_bug.cgi?id=194264
2175
2176         Reviewed by Lucas Forschler.
2177
2178         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2179         (BuilderMapping.__str__):
2180         (BuilderMapping):
2181         (BuilderMapping.save_mapping):
2182         (BuilderMapping.update_mapping):
2183         (BuilderMapping.get_existing_mapping):
2184         (BuilderMapping.is_valid_mapping):
2185
2186 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2187
2188         [ews-app] Add timestamp fields for BuilderMappings
2189         https://bugs.webkit.org/show_bug.cgi?id=194266
2190
2191         Reviewed by Lucas Forschler.
2192
2193         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2194         (BuilderMapping):
2195
2196 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2197
2198         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2199         https://bugs.webkit.org/show_bug.cgi?id=174816
2200
2201         Reviewed by Michael Catanzaro.
2202
2203         Add tests for webkit_uri_for_display().
2204
2205         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2206         (testURIForDisplayUnaffected):
2207         (testURIForDisplayAffected):
2208         (beforeAll):
2209         (afterAll):
2210         * TestWebKitAPI/glib/CMakeLists.txt:
2211
2212 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2213
2214         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2215         https://bugs.webkit.org/show_bug.cgi?id=194158
2216         <rdar://problem/47737268>
2217
2218         Rubber-stamped by Aakash Jain.
2219
2220         * Scripts/webkitpy/port/device_port.py:
2221         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2222
2223 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2224
2225         [CG] Enable setAdditionalSupportedImageTypes for WK1
2226         https://bugs.webkit.org/show_bug.cgi?id=194190
2227
2228         Reviewed by Tim Horton.
2229
2230         Add a test similar to the one under WebKit Cocoa but make it create a
2231         WebView instead of a WKWebView.
2232
2233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2234         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2235         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2236         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2237         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2238         (TestWebKitAPI::runTest):
2239         (TestWebKitAPI::TEST):
2240
2241 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2242
2243         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2244         https://bugs.webkit.org/show_bug.cgi?id=194168
2245
2246         Reviewed by Simon Fraser.
2247
2248         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2249
2250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2251         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2252         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2253         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2254         (TEST):
2255         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2256         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2257
2258 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2259
2260         REGRESSION (r237269): webkit-patch what-broke is broken 
2261         https://bugs.webkit.org/show_bug.cgi?id=193025
2262
2263         Reviewed by Aakash Jain.
2264
2265         * Scripts/webkitpy/common/host.py:
2266         (Host.buildbot):
2267         (Host.bugzilla): Renamed to 'buildbot'.
2268
2269 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2270
2271         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2272         https://bugs.webkit.org/show_bug.cgi?id=194207
2273
2274         Reviewed by Tim Horton.
2275
2276         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2277         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2278         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2279         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2280         start and delete forwards to remove the original attachment.
2281
2282         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2283         (TestWebKitAPI::TEST):
2284
2285 2019-02-04  Youenn Fablet  <youenn@apple.com>
2286
2287         Capture state should be managed consistently when doing process swapping
2288         https://bugs.webkit.org/show_bug.cgi?id=194122
2289         <rdar://problem/47609293>
2290
2291         Reviewed by Eric Carlson.
2292
2293         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2294         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2295         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2296         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2297         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2298         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2299         (WTR::TestRunner::isDoingMediaCapture const):
2300         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2301         * WebKitTestRunner/TestController.cpp:
2302         (WTR::TestController::isDoingMediaCapture const):
2303         * WebKitTestRunner/TestController.h:
2304         * WebKitTestRunner/TestInvocation.cpp:
2305         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2306         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2307         (WTR::TestController::isDoingMediaCapture const):
2308
2309 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2310
2311         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2312         https://bugs.webkit.org/show_bug.cgi?id=194142
2313
2314         Reviewed by Ross Kirsling.
2315
2316         There three 'separator' variables in TestController.cpp. Renamed
2317         it 'pathSeparator', and unified them.
2318
2319         * WebKitTestRunner/TestController.cpp:
2320         (WTR::TestController::generateContextConfiguration const):
2321         (WTR::createTestURL):
2322         (WTR::TestController::platformAdjustContext):
2323
2324 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2325
2326         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2327         https://bugs.webkit.org/show_bug.cgi?id=194198
2328
2329         Reviewed by Antti Koivisto.
2330
2331         No need to set the banner heights on navigation now, since Page stores them.
2332
2333         * MiniBrowser/mac/WK2BrowserWindowController.m:
2334         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2335
2336 2019-02-03  John Wilander  <wilander@apple.com>
2337
2338         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2339         https://bugs.webkit.org/show_bug.cgi?id=194104
2340         <rdar://problem/47649991>
2341
2342         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2343
2344         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2345         (TestWebKitAPI::TEST):
2346             Changed numeric types from unsigned short to uint32_t.
2347
2348 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2349
2350         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2351         <https://webkit.org/b/194178>
2352         <rdar://problem/47753473>
2353
2354         Reviewed by Alexey Proskuryakov.
2355
2356         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2357         (WTR::uninstallFakeHelvetica): Pass nullptr into
2358         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2359
2360 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2361
2362         [LFC] Initialize ICB's style with fixed width/height.
2363         https://bugs.webkit.org/show_bug.cgi?id=194188
2364
2365         Reviewed by Antti Koivisto.
2366
2367         * LayoutReloaded/misc/LFC-passing-tests.txt:
2368
2369 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2370
2371         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2372         https://bugs.webkit.org/show_bug.cgi?id=194185
2373
2374         Reviewed by Antti Koivisto.
2375
2376         * LayoutReloaded/misc/LFC-passing-tests.txt:
2377
2378 2018-12-16  Darin Adler  <darin@apple.com>
2379
2380         Convert additional String::format clients to alternative approaches
2381         https://bugs.webkit.org/show_bug.cgi?id=192746
2382
2383         Reviewed by Alexey Proskuryakov.
2384
2385         * WebKitTestRunner/TestController.cpp:
2386         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2387         as an intermediate in code that ultimately constructs a WTF::String.
2388         (WTR::userMediaOriginHash): Use makeString.
2389         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2390         (WTR::TestController::didPerformClientRedirect): Ditto.
2391         (WTR::TestController::didPerformServerRedirect): Ditto.
2392         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2393
2394 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2395
2396         [ews-build] Add unit test to verify builder keys
2397         https://bugs.webkit.org/show_bug.cgi?id=194152
2398
2399         Reviewed by Lucas Forschler.
2400
2401         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2402         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2403
2404 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2405
2406         [LFC] Expand tests coverage (12 new tests -> 787)
2407
2408         Unreviewed test gardening.
2409
2410         * LayoutReloaded/misc/LFC-passing-tests.txt:
2411
2412 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2413
2414         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2415         https://bugs.webkit.org/show_bug.cgi?id=194163
2416
2417         Reviewed by Simon Fraser.
2418
2419         775
2420
2421         * LayoutReloaded/misc/LFC-passing-tests.txt:
2422
2423 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2424
2425         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2426         https://bugs.webkit.org/show_bug.cgi?id=194140
2427         <rdar://problem/47728098>
2428
2429         Reviewed by Tim Horton.
2430
2431         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2432         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2433         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2434
2435         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2436         test to induce an IPC deadlock when presenting a modal alert during touch start.
2437
2438         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2439         * WebKitTestRunner/TestController.cpp:
2440         (WTR::runJavaScriptAlert):
2441
2442         Add a client callback function for running JavaScript alerts.
2443
2444         (WTR::TestController::createOtherPage):
2445         (WTR::TestController::generateContextConfiguration const):
2446
2447         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2448         the fix in this patch.
2449
2450         (WTR::TestController::createWebViewWithOptions):
2451
2452         Plumb TestOptions to generateContextConfiguration.
2453
2454         (WTR::TestController::resetPreferencesToConsistentValues):
2455         (WTR::TestController::resetStateToConsistentValues):
2456         (WTR::updateTestOptionsFromTestHeader):
2457         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2458         (WTR::TestController::handleJavaScriptAlert):
2459         * WebKitTestRunner/TestController.h:
2460         * WebKitTestRunner/TestInvocation.cpp:
2461         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2462         * WebKitTestRunner/TestOptions.h:
2463         (WTR::TestOptions::hasSameInitializationOptions const):
2464
2465 2019-02-01  Chris Dumez  <cdumez@apple.com>
2466
2467         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2468         https://bugs.webkit.org/show_bug.cgi?id=193740
2469         <rdar://problem/47527267>
2470
2471         Reviewed by Alex Christensen.
2472
2473         Add API test coverage.
2474
2475         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2476
2477 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2478
2479         [ews-app] Add display name field to BuilderMapping model
2480         https://bugs.webkit.org/show_bug.cgi?id=194153
2481
2482         Reviewed by Lucas Forschler.
2483
2484         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2485         (BuilderMapping):
2486
2487 2019-02-01  Youenn Fablet  <youenn@apple.com>
2488
2489         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2490         https://bugs.webkit.org/show_bug.cgi?id=194155
2491
2492         Reviewed by Eric Carlson.
2493
2494         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2495         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2496         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2497
2498 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2499
2500         [LFC] Adjust replaced element's intrinsic ratio
2501         https://bugs.webkit.org/show_bug.cgi?id=194154
2502
2503         Reviewed by Antti Koivisto.
2504
2505         761
2506
2507         * LayoutReloaded/misc/LFC-passing-tests.txt:
2508
2509 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2510
2511         [WPE] Show test results in minibrowser
2512         https://bugs.webkit.org/show_bug.cgi?id=194150
2513
2514         Reviewed by Žan Doberšek.
2515
2516         * Scripts/webkitpy/port/wpe.py:
2517         (WPEPort.show_results_html_file):
2518
2519 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2520
2521         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2522         https://bugs.webkit.org/show_bug.cgi?id=194151
2523
2524         Reviewed by Žan Doberšek.
2525
2526         ALT + <- go back
2527         ALT + -> go forward
2528
2529         * MiniBrowser/wpe/main.cpp:
2530         (main):
2531
2532 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2533
2534         [LFC] Set intrinsic size on Layout::Replaced
2535         https://bugs.webkit.org/show_bug.cgi?id=194139
2536
2537         Reviewed by Antti Koivisto.
2538
2539         744
2540
2541         * LayoutReloaded/misc/LFC-passing-tests.txt:
2542
2543 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2544
2545         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2546         https://bugs.webkit.org/show_bug.cgi?id=194146
2547
2548         Reviewed by Xabier Rodriguez-Calvar.
2549
2550         It allows to open relative paths.
2551
2552         * MiniBrowser/wpe/main.cpp:
2553         (main):
2554
2555 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2556
2557         Update flakiness dashboard configuration after recent queue changes
2558         https://bugs.webkit.org/show_bug.cgi?id=194127
2559
2560         Rubber-stamped by Aakash Jain.
2561
2562         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2563
2564         * TestResultServer/static-dashboards/builders.jsonp:
2565
2566 2019-01-31  Youenn Fablet  <youenn@apple.com>
2567
2568         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2569         https://bugs.webkit.org/show_bug.cgi?id=194106
2570         <rdar://problem/47676333>
2571
2572         Reviewed by Ryosuke Niwa.
2573
2574         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2575         (TestWebKitAPI::didFinishNavigation):
2576         (TestWebKitAPI::TEST):
2577         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2578
2579 2019-01-31  Chris Dumez  <cdumez@apple.com>
2580
2581         Page zoom level is lost after a process swap or a crash
2582         https://bugs.webkit.org/show_bug.cgi?id=194105
2583         <rdar://problem/47610781>
2584
2585         Reviewed by Alex Christensen.
2586
2587         Add API test coverage.
2588
2589         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2590         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2591
2592 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2593
2594         Revert r238819 which is unneeded and caused a performance regression.
2595         https://bugs.webkit.org/show_bug.cgi?id=192272
2596         <rdar://problem/46664625>
2597
2598         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2599         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2600         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2601
2602 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2603
2604         Formalize WebKitAdditions mechanism of LoadOptimizer
2605         https://bugs.webkit.org/show_bug.cgi?id=193886
2606         <rdar://problem/47696809>
2607
2608         Reviewed by Brent Fulgham.
2609
2610         * MiniBrowser/MiniBrowser.entitlements:
2611         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2612
2613 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2614
2615         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2616         https://bugs.webkit.org/show_bug.cgi?id=194090
2617
2618         Reviewed by Antti Koivisto.
2619
2620         * LayoutReloaded/misc/LFC-passing-tests.txt:
2621
2622 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2623
2624         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2625         https://bugs.webkit.org/show_bug.cgi?id=194074
2626
2627         Reviewed by Antti Koivisto.
2628
2629         * LayoutReloaded/misc/LFC-passing-tests.txt:
2630
2631 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2632
2633         [LFC][BFC] Add support for block level replaced box.
2634         https://bugs.webkit.org/show_bug.cgi?id=194071
2635
2636         Reviewed by Antti Koivisto.
2637
2638         * LayoutReloaded/misc/LFC-passing-tests.txt:
2639
2640 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2641
2642         Fix WebKitTestRunner's testPath with Windows full paths
2643         https://bugs.webkit.org/show_bug.cgi?id=194012
2644
2645         Reviewed by Alex Christensen.
2646
2647         updateTestOptionsFromTestHeader failed to open test files because
2648         testPath returned wrong file paths. It returned a path "/C:/..."
2649         if a URL "file:///C:/..." was given.
2650
2651         * WebKitTestRunner/TestController.cpp:
2652         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2653
2654 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2655
2656         [WPE] Bump font related dependencies to match the GTK+ port
2657         https://bugs.webkit.org/show_bug.cgi?id=194017
2658
2659         Reviewed by Žan Doberšek.
2660
2661         * wpe/jhbuild.modules:
2662         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2663         * wpe/patches/icudata-stdlibs.patch: Added.
2664
2665 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2666
2667         Enable swipe tests on iOS
2668         https://bugs.webkit.org/show_bug.cgi?id=194076
2669
2670         Reviewed by Geoffrey Garen.
2671
2672         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2673         it causes a debug assertion failure in runUIScript.
2674
2675         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2676         (WTR::UIScriptController::beginBackSwipe):
2677         (WTR::UIScriptController::completeBackSwipe):
2678
2679 2019-01-30  Keith Rollin  <krollin@apple.com>
2680
2681         Use correct printf format specifier
2682         https://bugs.webkit.org/show_bug.cgi?id=194062
2683         <rdar://problem/47686167>
2684
2685         Reviewed by Alexey Proskuryakov.
2686
2687         LayoutTestSpellChecker.mm is trying to format a variable of type
2688         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2689         actually an unsigned long long. Fix this by formatting with %llu.
2690
2691         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2692         (-[LayoutTestTextCheckingResult description]):
2693
2694 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2695
2696         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2697         https://bugs.webkit.org/show_bug.cgi?id=193979
2698
2699         Reviewed by Wenson Hsieh.
2700
2701         Fix the test for iOS. Make the test work with iOS UA string.
2702
2703         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2704
2705 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2706
2707         Replace High Sierra LLINT CLoop bot due to hardware failure
2708         https://bugs.webkit.org/show_bug.cgi?id=194066
2709
2710         Reviewed by Aakash Jain.
2711
2712         * BuildSlaveSupport/build.webkit.org-config/config.json:
2713
2714 2019-01-30  Keith Rollin  <krollin@apple.com>
2715
2716         [NSDragItem init] is unavailable
2717         https://bugs.webkit.org/show_bug.cgi?id=194059
2718         <rdar://problem/47685715>
2719
2720         Reviewed by Wenson Hsieh.
2721
2722         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2723         DumpRenderTree and TestWebKitAPI, which both try to create an
2724         NSDragItem in a manner that invokes this method. Address this by using
2725         -initWithPasteboardWriter instead.
2726
2727         Note that the parameter passed to initWithPasteboardWriter is likely
2728         incorrect. In both cases, the object passed does not conform to
2729         NSPasteboardWriting. However, with this fix, we're no worse off than
2730         before, and can now perform builds with newer compilers and SDKs until
2731         a real fix can be crafted. That work is tracked in
2732         https://bugs.webkit.org/show_bug.cgi?id=194060
2733
2734         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2735         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2736         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2737         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2738
2739 2019-01-30  Daniel Bates  <dabates@apple.com>
2740
2741         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2742         https://bugs.webkit.org/show_bug.cgi?id=192824
2743         <rdar://problem/47100332>
2744
2745         Reviewed by Wenson Hsieh.
2746
2747         Fix a bug where the wrong usage code was used for F13 thru F24.
2748
2749         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2750         (keyCodeForDOMFunctionKey):
2751
2752 2019-01-30  Chris Dumez  <cdumez@apple.com>
2753
2754         Regression(PSON) Load hang can occur on history navigation
2755         https://bugs.webkit.org/show_bug.cgi?id=194030
2756         <rdar://problem/47656939>
2757
2758         Reviewed by Antti Koivisto.
2759
2760         Add API test coverage.
2761
2762         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2763
2764 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2765
2766         [LFC] Expand tests coverage.
2767
2768         Unreviewed test gardening.
2769
2770         * LayoutReloaded/misc/LFC-passing-tests.txt:
2771
2772 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2773
2774         [Flatpak] Add openjpeg support
2775         https://bugs.webkit.org/show_bug.cgi?id=194019
2776
2777         Reviewed by Michael Catanzaro.
2778
2779         * flatpak/org.webkit.CommonModules.yaml:
2780
2781 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2782
2783         Unreviewed, rolling out r240708.
2784         https://bugs.webkit.org/show_bug.cgi?id=194022
2785
2786         It broke WPE build (Requested by KaL on #webkit).
2787
2788         Reverted changeset:
2789
2790         "[WPE] Bump font related dependencies to match the GTK+ port"
2791         https://bugs.webkit.org/show_bug.cgi?id=194017
2792         https://trac.webkit.org/changeset/240708
2793
2794 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2795
2796         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2797         https://bugs.webkit.org/show_bug.cgi?id=194001
2798
2799         Reviewed by Antti Koivisto.
2800
2801         * LayoutReloaded/misc/LFC-passing-tests.txt:
2802
2803 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2804
2805         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2806         https://bugs.webkit.org/show_bug.cgi?id=194020
2807
2808         Reviewed by Antti Koivisto.
2809
2810         * LayoutReloaded/misc/LFC-passing-tests.txt:
2811
2812 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2813
2814         AX: Support color well on iOS
2815         https://bugs.webkit.org/show_bug.cgi?id=194010
2816
2817         Reviewed by Joanmarie Diggs.
2818
2819         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2820         (WTR::AccessibilityUIElement::stringAttributeValue):
2821
2822 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2823
2824         [WPE] Bump font related dependencies to match the GTK+ port
2825         https://bugs.webkit.org/show_bug.cgi?id=194017
2826
2827         Reviewed by Žan Doberšek.
2828
2829         * wpe/jhbuild.modules:
2830         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2831         * wpe/patches/icudata-stdlibs.patch: Added.
2832
2833 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2834
2835         [Mac] Update window scale API usage
2836         https://bugs.webkit.org/show_bug.cgi?id=193991
2837         rdar://problem/47614795
2838
2839         Reviewed by Tim Horton.
2840
2841         * DumpRenderTree/mac/DumpRenderTree.mm:
2842         (changeWindowScaleIfNeeded):
2843         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2844         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2845         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2846
2847 2019-01-29  Chris Dumez  <cdumez@apple.com>
2848
2849         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2850         https://bugs.webkit.org/show_bug.cgi?id=193977
2851         <rdar://problem/47643716>
2852
2853         Reviewed by Geoff Garen.
2854
2855         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2856         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2857         to the previous provisional committing *before* we make the last load. 
2858
2859         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2860
2861 2019-01-29  Youenn Fablet  <youenn@apple.com>
2862
2863         Adopt new SPI to evaluate server certificate trust
2864         https://bugs.webkit.org/show_bug.cgi?id=193355
2865
2866         Reviewed by Alex Christensen.
2867
2868         Add infrastructure to handle HTTPS server trust evaluation testing.
2869
2870         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2871         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2872         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2873         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2874         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2875         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2876         * WebKitTestRunner/TestController.cpp:
2877         (WTR::TestController::resetPreferencesToConsistentValues):
2878         (WTR::TestController::didReceiveAuthenticationChallenge):
2879         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2880         * WebKitTestRunner/TestController.h:
2881         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2882         * WebKitTestRunner/TestInvocation.cpp:
2883         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2884         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2885         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2886
2887 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2888
2889         [ews-build] Add build step to print bot Configuration
2890         https://bugs.webkit.org/show_bug.cgi?id=193887
2891
2892         Reviewed by Lucas Forschler.
2893
2894         * BuildSlaveSupport/ews-build/steps.py:
2895         (PrintConfiguration): Build step to print configuration.
2896         * BuildSlaveSupport/ews-build/factories.py:
2897
2898 2019-01-29  Chris Dumez  <cdumez@apple.com>
2899
2900         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2901         https://bugs.webkit.org/show_bug.cgi?id=193967
2902         <rdar://problem/47635348>
2903
2904         Reviewed by Alex Christensen.
2905
2906         Add API test coverage.
2907
2908         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2909         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2910
2911 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2912
2913         [ews-app] Handle incoming results data
2914         https://bugs.webkit.org/show_bug.cgi?id=193973
2915
2916         Reviewed by Lucas Forschler.
2917
2918         * BuildSlaveSupport/ews-app/ews/views/results.py:
2919
2920 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2921
2922         [ews-app] Make the results url generic
2923         https://bugs.webkit.org/show_bug.cgi?id=193928
2924
2925         Reviewed by Lucas Forschler.
2926
2927         * BuildSlaveSupport/ews-app/ews/urls.py:
2928
2929 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2930
2931         [ews-build] Configure buildbot to send events to ews-app
2932         https://bugs.webkit.org/show_bug.cgi?id=193968
2933
2934         Reviewed by Lucas Forschler.
2935
2936         * BuildSlaveSupport/ews-build/events.py: Added.
2937         * BuildSlaveSupport/ews-build/master.cfg:
2938
2939 2019-01-29  Keith Rollin  <krollin@apple.com>
2940
2941         Add .xcfilelists to Run Script build phases
2942         https://bugs.webkit.org/show_bug.cgi?id=193792
2943         <rdar://problem/47201785>
2944
2945         Reviewed by Alex Christensen.
2946
2947         As part of supporting XCBuild, update the necessary Run Script build
2948         phases in their Xcode projects to refer to their associated
2949         .xcfilelist files.
2950
2951         Note that the addition of these files bumps the Xcode project version
2952         number to something that's Xcode 10 compatible. This change means that
2953         older versions of the Xcode IDE can't read these projects. Nor can it
2954         fully load workspaces that refer to these projects (the updated
2955         projects are shown as non-expandable placeholders). `xcodebuild` can
2956         still build these projects; it's just that the IDE can't open them.
2957
2958         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2959         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2960
2961 2019-01-29  John Wilander  <wilander@apple.com>
2962
2963         Add data abstraction and validation for Ad Click Attribution
2964         https://bugs.webkit.org/show_bug.cgi?id=193916
2965         <rdar://problem/47603481>
2966
2967         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2968
2969         Ad click attribution has two steps. First, the storage of an ad
2970         campaign ID for a click that takes the user to a destination
2971         site. Second, a conversion on the destination site that can be
2972         attributed to the ad click.
2973
2974         This patch adds a class that represents a request for ad click
2975         attribution. Validation makes sure that the bits of entropy
2976         reported through this mechanism is limited.
2977
2978         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2979         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2980         (TestWebKitAPI::TEST):
2981
2982 2019-01-29  Chris Dumez  <cdumez@apple.com>
2983
2984         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2985         https://bugs.webkit.org/show_bug.cgi?id=193932
2986         <rdar://problem/47598947>
2987
2988         Reviewed by Brady Eidson.
2989
2990         Add API test coverage.
2991
2992         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2993
2994 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2995
2996         Adding new passing LFC tests.
2997
2998         Unreviewed test gardening.
2999
3000         * LayoutReloaded/misc/LFC-passing-tests.txt:
3001
3002 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3003
3004         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3005         https://bugs.webkit.org/show_bug.cgi?id=193964
3006
3007         Reviewed by Antti Koivisto.
3008
3009         * LayoutReloaded/misc/LFC-passing-tests.txt:
3010
3011 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3012
3013         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3014         https://bugs.webkit.org/show_bug.cgi?id=193954
3015
3016         Reviewed by Antti Koivisto.
3017
3018         * LayoutReloaded/misc/LFC-passing-tests.txt:
3019
3020 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3021
3022         WebDriver: add support for running subtests
3023         https://bugs.webkit.org/show_bug.cgi?id=193904
3024
3025         Reviewed by Michael Catanzaro.
3026
3027         pytest already supports it by passing test.py::subtest, so we can do the same.
3028
3029         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3030         (get_item_name): Made this global.
3031         (CollectRecorder.__init__): Receive the parameter to ignore.
3032         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3033         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3034         (collect): Add parameter to ignore.
3035         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3036         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3037         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3038         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3039         (WebDriverTestRunnerSelenium.run): Ditto.
3040         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3041         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3042         (WebDriverTestRunnerW3C.run): Ditto.
3043
3044 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3045
3046         User agent string override for navigator.userAgent should be site specific quirks
3047         https://bugs.webkit.org/show_bug.cgi?id=193950
3048
3049         Reviewed by Brent Fulgham.
3050
3051         Updated per the _WKWebsitePolicies rename.
3052
3053         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3054         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3055
3056 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3057
3058         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3059         https://bugs.webkit.org/show_bug.cgi?id=193941
3060
3061         Reviewed by Alex Christensen.
3062
3063         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3064         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3065         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3066         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3067         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3068         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3069         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3070         * TestWebKitAPI/Tests/WTF/Time.cpp:
3071         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3072         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3073         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3074         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3075
3076 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3077
3078         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3079
3080         * Scripts/webkitpy/common/config/contributors.json:
3081
3082 2019-01-28  Andy Estes  <aestes@apple.com>
3083
3084         [watchOS] Enable Parental Controls content filtering
3085         https://bugs.webkit.org/show_bug.cgi?id=193939
3086         <rdar://problem/46641912>
3087
3088         Reviewed by Ryosuke Niwa.
3089
3090         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3091
3092 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3093
3094         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3095         <https://webkit.org/b/193884>
3096
3097         Reviewed by Jiewen Tan.
3098
3099         * Scripts/webkitpy/style/checkers/cpp.py:
3100         (check_language): Add LocalAuthentication to
3101         `frameworks_with_soft_links`.
3102
3103 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3104
3105         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3106         https://bugs.webkit.org/show_bug.cgi?id=193891
3107
3108         Reviewed by Ross Kirsling.
3109
3110         There were three problems in window sizes of WebView and the host window.
3111         1. The sizes of pixel image output were incorrect.
3112         2. The host window is going to appear after window.resize was invoked.
3113         3. window.resize resized only the host window, not WebView.
3114
3115         This change solves them with a following approach.
3116         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3117         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3118            as well as DumpRenderTree in order to match the client area and the window area.
3119         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3120         d. PlatformWebView::setWindowFrame changes both window sizes.
3121         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3122
3123         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3124         (WTR::PlatformWebView::PlatformWebView): Create the host window
3125         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3126         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3127         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3128
3129 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3130
3131         [ews-app] Add method to save Step data to database
3132         https://bugs.webkit.org/show_bug.cgi?id=193890
3133
3134         Reviewed by Lucas Forschler.
3135
3136         * BuildSlaveSupport/ews-app/ews/models/step.py:
3137         (Step.save_step): Method to save step data.
3138         (Step.update_step): Method to update step data.
3139         (Step.get_existing_step): Method to fetch existing step from database.
3140         (Step.is_valid_result): Method to validate valid step result.
3141
3142 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3143
3144         [ews-app] Add method to save Build data to database
3145         https://bugs.webkit.org/show_bug.cgi?id=193735
3146
3147         Reviewed by Lucas Forschler.
3148
3149         * BuildSlaveSupport/ews-app/ews/models/build.py:
3150         (Build.save_build): Method to save build information to database.
3151         (Build.get_existing_build): Method to fetch existing build from database.
3152         (Build.is_valid_result): Method to validate build result.
3153         * BuildSlaveSupport/ews-app/ews/common/util.py:
3154         (is_valid_int_id): Method to validate valid id.
3155
3156 2019-01-28  Chris Dumez  <cdumez@apple.com>
3157
3158         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3159         https://bugs.webkit.org/show_bug.cgi?id=193915
3160         <rdar://problem/47560907>
3161
3162         Reviewed by Alex Christensen.
3163
3164         Add API test coverage.
3165
3166         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3167
3168 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3169
3170         [ews-app] Rename id variables
3171         https://bugs.webkit.org/show_bug.cgi?id=193883
3172
3173         Reviewed by Lucas Forschler.
3174
3175         * BuildSlaveSupport/ews-app/ews/models/build.py:
3176         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3177         * BuildSlaveSupport/ews-app/ews/models/step.py:
3178         * BuildSlaveSupport/ews-app/ews/urls.py:
3179         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3180         * BuildSlaveSupport/ews-app/ews/views/results.py:
3181         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3182
3183 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3184
3185         [ews-app] Allow certain fields to be empty
3186         https://bugs.webkit.org/show_bug.cgi?id=193892
3187
3188         Reviewed by Lucas Forschler.
3189
3190         * BuildSlaveSupport/ews-app/ews/models/build.py:
3191         * BuildSlaveSupport/ews-app/ews/models/step.py:
3192
3193 2019-01-28  Rob Buis  <rbuis@igalia.com>
3194
3195         Update MIME type parser
3196         https://bugs.webkit.org/show_bug.cgi?id=180526
3197
3198         Reviewed by Frédéric Wang.
3199
3200         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3201         (TestWebKitAPI::TEST):
3202
3203 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3204
3205         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3206         https://bugs.webkit.org/show_bug.cgi?id=193896
3207
3208         Reviewed by Antti Koivisto.
3209
3210         * LayoutReloaded/misc/LFC-passing-tests.txt:
3211
3212 2018-12-15  Darin Adler  <darin@apple.com>
3213
3214         Replace many uses of String::format with more type-safe alternatives
3215         https://bugs.webkit.org/show_bug.cgi?id=192742
3216
3217         Reviewed by Mark Lam.
3218
3219         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3220         (WTR::cacheTestRunnerCallback): Use makeString.
3221         * WebKitTestRunner/TestController.cpp:
3222         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3223         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3224
3225 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3226
3227         Use a load optimizer for some sites
3228         https://bugs.webkit.org/show_bug.cgi?id=193881
3229         <rdar://problem/46325455>
3230
3231         Reviewed by Brent Fulgham.
3232
3233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3234         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3235
3236 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3237
3238         AX: Introduce a static accessibility tree
3239         https://bugs.webkit.org/show_bug.cgi?id=193348
3240         <rdar://problem/47203295>
3241
3242         Reviewed by Ryosuke Niwa.
3243
3244         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3245
3246 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3247
3248         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3249         https://bugs.webkit.org/show_bug.cgi?id=193867
3250
3251         Reviewed by Antti Koivisto.
3252
3253         * LayoutReloaded/misc/LFC-passing-tests.txt:
3254
3255 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3256
3257         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3258         https://bugs.webkit.org/show_bug.cgi?id=193865
3259
3260         Reviewed by Antti Koivisto.
3261
3262         * LayoutReloaded/misc/LFC-passing-tests.txt:
3263
3264 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3265
3266         Need a mechanism to override navigator.userAgent
3267         https://bugs.webkit.org/show_bug.cgi?id=193762
3268         <rdar://problem/47504939>
3269
3270         Reviewed by Brent Fulgham.
3271
3272         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3273
3274         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3275         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3276         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3277
3278 2019-01-25  Dean Jackson  <dino@apple.com>
3279
3280         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3281         https://bugs.webkit.org/show_bug.cgi?id=193831
3282         <rdar://problem/47399263>
3283
3284         Reviewed by Chris Dumez.
3285
3286         Two new tests that exercise cross-origin and same-origin System
3287         Previews.
3288
3289         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3290
3291 2019-01-25  Keith Rollin  <krollin@apple.com>
3292
3293         Update Xcode projects with "Check .xcfilelists" build phase
3294         https://bugs.webkit.org/show_bug.cgi?id=193790
3295         <rdar://problem/47201374>
3296
3297         Reviewed by Alex Christensen.
3298
3299         Support for XCBuild includes specifying inputs and outputs to various
3300         Run Script build phases. These inputs and outputs are specified as
3301         .xcfilelist files. Once created, these .xcfilelist files need to be
3302         kept up-to-date. In order to check that they are up-to-date or not,
3303         add an Xcode build step that invokes an external script that performs
3304         the checking. If the .xcfilelists are found to be out-of-date, update
3305         them, halt the build, and instruct the developer to restart the build
3306         with up-to-date files.
3307
3308         At this time, the checking and regenerating is performed only if the
3309         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3310         who want to use this facility can set this variable and test out the
3311         checking/regenerating. Once it seems like there are no egregious
3312         issues that upset a developer's workflow, we'll unconditionally enable
3313         this facility.
3314
3315         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3316         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3317         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3318         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3319
3320 2019-01-25  Keith Rollin  <krollin@apple.com>
3321
3322         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3323         https://bugs.webkit.org/show_bug.cgi?id=193781
3324         <rdar://problem/47201153>
3325
3326         Reviewed by Alex Christensen.
3327
3328         Part of generating the .xcfilelists used as part of adopting XCBuild
3329         includes running `make DerivedSources.make` from a standalone script.
3330         It’s important for this invocation to have the same environment as
3331         when the actual build invokes `make DerivedSources.make`. If the
3332         environments are different, then the two invocations will provide
3333         different results. In order to get the same environment in the
3334         standalone script, have the script launch xcodebuild targeting the
3335         "Apply Configuration to XCFileLists" build target, which will then
3336         re-invoke our standalone script. The script is now running again, this
3337         time in an environment with all workspace, project, target, xcconfig
3338         and other environment variables established.
3339
3340         The "Apply Configuration to XCFileLists" build target accomplishes
3341         this task via a small embedded shell script that consists only of:
3342
3343             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3344
3345         The process that invokes "Apply Configuration to XCFileLists" first
3346         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3347         evaluated and exports it into the shell environment. When xcodebuild
3348         is invoked, it inherits the value of this variable and can `eval` the
3349         contents of that variable. Our external standalone script can then set
3350         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3351         of command-line parameters needed to restart itself in the appropriate
3352         state.
3353
3354         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3355         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3356
3357 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3358
3359         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3360         https://bugs.webkit.org/show_bug.cgi?id=193802
3361         <rdar://problem/46010580>
3362
3363         Reviewed by Andy Estes.
3364
3365         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3366         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3367         (TEST):
3368
3369 2019-01-25  Daniel Bates  <dabates@apple.com>
3370
3371         [iOS] uiController.keyDown() does not translate Control modified key
3372         https://bugs.webkit.org/show_bug.cgi?id=192898
3373
3374         Reviewed by Wenson Hsieh.
3375
3376         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3377         key translation, as applicable. Among other cases, key translation occurs when performing
3378         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3379         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3380         human pressing down and releasing key(s) using a hardware keyboard.
3381
3382         * WebKitTestRunner/ios/HIDEventGenerator.h:
3383         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3384         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3385
3386         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3387         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3388         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3389         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3390         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3391         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3392         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3393         (-[HIDEventGenerator longPress:completionBlock:]):
3394         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3395         Update code for above renaming.
3396
3397         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3398         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3399
3400         (-[HIDEventGenerator keyDown:]): Added.
3401         (-[HIDEventGenerator keyUp:]): Added.
3402         (-[HIDEventGenerator keyPress:completionBlock:]):
3403         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3404         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3405         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3406         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3407         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3408         (WTR::parseModifier): Deleted.
3409
3410 2019-01-25  Keith Rollin  <krollin@apple.com>
3411
3412         Complete the implementation of generate-xcfilelists
3413         https://bugs.webkit.org/show_bug.cgi?id=193782
3414
3415         Reviewed by Alex Christensen.
3416
3417         A preliminary version of generate-xcfilelists was added in r238008.
3418         This patch updates that script in order to:
3419
3420         - Support checking of .xcfilelists
3421         - Perform better execution of `make DerivedSources.make` by
3422           relaunching generate-xcfilelists under xcodebuild
3423         - Support incremental generation and checking of .xcfilelists
3424         - Support supplementary .xcfilelists files from WebKitAdditions
3425         - Support being wrapped by parallel version of generate-xcfilelists in
3426           Internal that adds support for (re)generating WebKit projects in
3427           that repo.
3428         - Support builds that have been performed in WebKitBuild as well as
3429           ~/Library/Developer/code/DerivedData
3430         - Increase robustness and debugging facilities.
3431
3432         * Scripts/generate-xcfilelists:
3433
3434 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3435
3436         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3437         https://bugs.webkit.org/show_bug.cgi?id=193297
3438         <rdar://problem/47158841>
3439
3440         Unreviewed test case fix.
3441
3442         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3443         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3444
3445         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3446         (TEST):
3447
3448 2019-01-25  Keith Rollin  <krollin@apple.com>
3449
3450         Update existing .xcfilelists
3451         https://bugs.webkit.org/show_bug.cgi?id=193791
3452         <rdar://problem/47201706>
3453
3454         Reviewed by Alex Christensen.
3455
3456         Many .xcfilelist files were added in r238824 in order to support
3457         XCBuild. Update these with recent changes to the set of build files
3458         and with the current generate-xcfilelist script.
3459
3460         * DumpRenderTree/DerivedSources-input.xcfilelist:
3461         * DumpRenderTree/DerivedSources-output.xcfilelist:
3462         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3463         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3464
3465 2019-01-25  Keith Rollin  <krollin@apple.com>
3466
3467         Fix missing dependencies in extract-dependencies-from-makefile
3468         https://bugs.webkit.org/show_bug.cgi?id=193783
3469         <rdar://problem/47201571>
3470
3471         Reviewed by Alex Christensen.
3472
3473         The extract-dependencies-from-makefile script generates .xcfilelists
3474         for XCBuild by invoking a makefile in --debug mode, parsing the
3475         dependency information in the output, and extracting information
3476         regarding targets and dependents. However, the way `make` emits this
3477         dependency information is not rigorous, and so we need to determine
3478         what lines to look for and parse by trial and error. This approach
3479         didn't coriginally atch all the information we needed to collect, so
3480         update the script to look for the additional lines we now know to look
3481         for.
3482
3483         * Scripts/extract-dependencies-from-makefile:
3484         (Parser):
3485         (Parser.addTarget):
3486         (Parser.addPrereq):
3487         (Parser.doParse):
3488
3489 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3490
3491         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3492         https://bugs.webkit.org/show_bug.cgi?id=193297
3493         <rdar://problem/47158841>
3494
3495         Reviewed by Alex Christensen.
3496
3497         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3498             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3499         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3500         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3501         activating the message used to trigger the callback when it is set.
3502
3503 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3504
3505         WKWebView.goBack should reload if there is a safe browsing warning
3506         https://bugs.webkit.org/show_bug.cgi?id=193805
3507         <rdar://problem/46908216>
3508
3509         Reviewed by Geoff Garen.
3510
3511         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3512         (+[Simple3LookupContext sharedLookupContext]):
3513         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3514         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3515         (TEST):
3516
3517 2019-01-25  Chris Dumez  <cdumez@apple.com>
3518
3519         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3520         https://bugs.webkit.org/show_bug.cgi?id=193788
3521         <rdar://problem/47531231>
3522
3523         Reviewed by Alex Christensen.
3524
3525         Add API test coverage.
3526
3527         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3528         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3529
3530 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3531
3532         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3533         https://bugs.webkit.org/show_bug.cgi?id=193771
3534
3535         Unreviewed infrastructure fix.
3536
3537         * Scripts/webkitpy/port/darwin.py:
3538         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3539
3540 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3541
3542         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3543
3544 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3545
3546         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3547
3548         * Scripts/webkitpy/common/config/contributors.json:
3549
3550 2019-01-25  Chris Dumez  <cdumez@apple.com>
3551
3552         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3553         https://bugs.webkit.org/show_bug.cgi?id=193779
3554         <rdar://problem/46170903>
3555
3556         Reviewed by Antti Koivisto.
3557
3558         Add API test that quickly navigates forward to a previous process without waiting for it to
3559         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3560         the process' previous page when reconnecting the it for the forward navigation.
3561
3562         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3563
3564 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3565
3566         Need a way for JavaScript (or bundle) code to participate in undo
3567         https://bugs.webkit.org/show_bug.cgi?id=190009
3568         <rdar://problem/44807048>
3569
3570         Reviewed by Ryosuke Niwa.
3571
3572         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3573         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3574
3575         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3576         (WTR::UIScriptController::lastUndoLabel const):
3577         (WTR::UIScriptController::firstRedoLabel const):
3578         (WTR::UIScriptController::platformUndoManager const):
3579         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3580         (WTR::UIScriptController::lastUndoLabel const):
3581         (WTR::UIScriptController::firstRedoLabel const):
3582         (WTR::UIScriptController::platformUndoManager const):
3583         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3584         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3585         (WTR::UIScriptController::lastUndoLabel const):
3586         (WTR::UIScriptController::firstRedoLabel const):
3587         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3588         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3589         (WTR::UIScriptController::lastUndoLabel const):
3590         (WTR::UIScriptController::firstRedoLabel const):
3591         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3592         (WTR::UIScriptController::platformUndoManager const):
3593         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3594         (WTR::UIScriptController::platformUndoManager const):
3595
3596 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3597
3598         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3599         https://bugs.webkit.org/show_bug.cgi?id=193824
3600
3601         Reviewed by Antti Koivisto.
3602
3603         * LayoutReloaded/misc/LFC-passing-tests.txt:
3604
3605 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3606
3607         Update macOS JSC bot configurations
3608         https://bugs.webkit.org/show_bug.cgi?id=193739
3609
3610         Reviewed by Alexey Proskuryakov.
3611
3612         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3613         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3614         (BubbleQueueServer): Move JSC EWS to Mojave section.
3615         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3616         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3617         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3618
3619 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3620
3621         [Win][WebKitTestRunner] Implement EventSenderProxy
3622         https://bugs.webkit.org/show_bug.cgi?id=193755
3623
3624         Reviewed by Don Olmstead.
3625
3626         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3627         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3628         (WTR::EventSenderProxy::dispatchMessage):
3629         (WTR::EventSenderProxy::EventSenderProxy):
3630         (WTR::EventSenderProxy::mouseDown):
3631         (WTR::EventSenderProxy::mouseUp):
3632         (WTR::EventSenderProxy::mouseMoveTo):
3633         (WTR::EventSenderProxy::mouseScrollBy):
3634         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3635
3636 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3637
3638         Unreviewed fix for API test failure after r240437.
3639
3640         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3641
3642         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3643
3644 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3645
3646         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3647         https://bugs.webkit.org/show_bug.cgi?id=193787
3648         <rdar://problem/47497634>
3649
3650         Reviewed by Alexey Proskuryakov.
3651
3652         * Scripts/webkitdirs.pm:
3653         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3654
3655 2019-01-24  Truitt Savell  <tsavell@apple.com>
3656
3657         Unreviewed, rolling out r240446.
3658
3659         Casued 5 API failures
3660
3661         Reverted changeset:
3662
3663         "Activate the WebResourceLoadStatisticsStore in the
3664         NetworkProcess and deactivate it in the UIProcess."
3665         https://bugs.webkit.org/show_bug.cgi?id=193297
3666         https://trac.webkit.org/changeset/240446
3667
3668 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3669
3670         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3671         https://bugs.webkit.org/show_bug.cgi?id=193741
3672         <rdar://problem/47135030>
3673
3674         Reviewed by Antti Koivisto and Simon Fraser.
3675
3676         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3677         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3678         (TestWebKitAPI::TEST):
3679
3680 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3681
3682         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3683         https://bugs.webkit.org/show_bug.cgi?id=193297
3684         <rdar://problem/47158841>
3685
3686         Reviewed by Alex Christensen.
3687
3688         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3689         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3690         activating the message used to trigger the callback when it is set.
3691
3692 2019-01-24  John Wilander  <wilander@apple.com>
3693
3694         Add Ad Click Attribution as an internal/experimental feature
3695         https://bugs.webkit.org/show_bug.cgi?id=193685
3696         <rdar://problem/47450399>
3697
3698         Reviewed by Brent Fulgham.
3699
3700         Added test option adClickAttributionEnabled.
3701
3702         * DumpRenderTree/TestOptions.cpp:
3703         (TestOptions::TestOptions):
3704         * DumpRenderTree/TestOptions.h:
3705         * DumpRenderTree/mac/DumpRenderTree.mm:
3706         (setWebPreferencesForTestOptions):
3707
3708 2019-01-24  Antti Koivisto  <antti@apple.com>
3709
3710         [PSON] Flash on back navigation on Mac
3711         https://bugs.webkit.org/show_bug.cgi?id=193716
3712         <rdar://problem/47148458>
3713
3714         Reviewed by Chris Dumez.
3715
3716         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3717
3718         Closing of the previous page is delayed so waiting for didFinishNavigation is
3719         not sufficient to guarantee we have received all the messages. Wait for them.
3720
3721 2019-01-24  Chris Dumez  <cdumez@apple.com>
3722
3723         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3724         https://bugs.webkit.org/show_bug.cgi?id=193761
3725         <rdar://problem/47456405>
3726
3727         Reviewed by Alex Christensen.
3728
3729         Add API test coverage.
3730
3731         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3732
3733 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3734
3735         webkitpy: Missing PID in crashlog name should not be fatal
3736         https://bugs.webkit.org/show_bug.cgi?id=193771
3737
3738         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3739         of raising an exception.
3740
3741         Reviewed by Lucas Forschler.
3742
3743         * Scripts/webkitpy/port/darwin.py:
3744         (DarwinPort._merge_crash_logs):
3745
3746 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3747
3748         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3749         https://bugs.webkit.org/show_bug.cgi?id=193746
3750
3751         Reviewed by Youenn Fablet.
3752
3753         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3754         so we'd best just not call it.
3755
3756         * Scripts/webkitpy/w3c/test_exporter.py:
3757         (WebPlatformTestExporter.create_branch_with_patch):
3758
3759 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3760
3761         Move FileSystem to WTF
3762         https://bugs.webkit.org/show_bug.cgi?id=193602
3763
3764         Reviewed by Yusuke Suzuki.
3765
3766         * DumpRenderTree/win/DumpRenderTree.cpp:
3767         * TestWebKitAPI/CMakeLists.txt:
3768         * TestWebKitAPI/PlatformGTK.cmake:
3769         * TestWebKitAPI/PlatformJSCOnly.cmake:
3770         * TestWebKitAPI/PlatformPlayStation.cmake:
3771         * TestWebKitAPI/PlatformWPE.cmake:
3772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3773         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3774         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3775         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3776         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3777         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3778         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3779         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3780         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3781         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3782
3783 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3784
3785         [WPE] Remove hard dependency on subprocess32 for the API tests
3786
3787         Rubber-stamped by Carlos Garcia Campos.
3788
3789         * glib/api_test_runner.py:
3790         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3791         its presence only when running WPEQt tests.
3792
3793 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3794
3795         [GLIB] Expose JavaScriptCore options in GLib public API
3796         https://bugs.webkit.org/show_bug.cgi?id=188742
3797
3798         Reviewed by Michael Catanzaro.
3799
3800         Add a test for the new API.
3801
3802         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3803         (testsJSCOptions):
3804         (main):
3805
3806 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3807
3808         [GTK][WPE] Support JPEG 2000 images
3809         https://bugs.webkit.org/show_bug.cgi?id=186272
3810
3811         Reviewed by Žan Doberšek.
3812
3813         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3814
3815         * gtk/jhbuild.modules:
3816         * wpe/jhbuild.modules:
3817
3818 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3819
3820         check-webkit-style should warn when using soft-linking macros in a header
3821         <https://webkit.org/b/193750>
3822
3823         Reviewed by Darin Adler.
3824
3825         * Scripts/webkitpy/style/checkers/cpp.py:
3826         (check_language): Add softlink/header check by refactoring the
3827         softlink/framework check.
3828         (CppChecker): Enable softlink/header check by default.
3829         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3830         (CppStyleTest.test_softlink_framework): Rename from
3831         CppStyleTest.test_softlink() and change test framework name in
3832         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3833         files. Set file_name for macros that only appear in headers.
3834         (CppStyleTest.test_softlink_header): Add tests for using
3835         soft-link macros in headers.
3836
3837 2019-01-23  Chris Dumez  <cdumez@apple.com>
3838
3839         Deprecate API to limit the maximum number of WebProcesses
3840         https://bugs.webkit.org/show_bug.cgi?id=193725
3841         <rdar://problem/47464879>
3842
3843         Reviewed by Geoff Garen.
3844
3845         Update existing API tests to stop using deprecated API.
3846
3847         * MiniBrowser/mac/AppDelegate.m:
3848         (defaultConfiguration):
3849         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3850         (TestWebKitAPI::TEST):
3851         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3852         (TestWebKitAPI::TEST):
3853         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3854         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3855         (TEST):
3856         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3857         (TEST):
3858
3859 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3860
3861         [ews-app] Rename ews model buildermappings to buildermapping
3862         https://bugs.webkit.org/show_bug.cgi?id=193729
3863
3864         Reviewed by Lucas Forschler.
3865
3866         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3867         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3868         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3869
3870 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3871
3872         [ews-app] Rename ews model steps to step
3873         https://bugs.webkit.org/show_bug.cgi?id=193697
3874
3875         Reviewed by Lucas Forschler.
3876
3877         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3878         (Step): Renamed Steps to Step.
3879
3880 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3881
3882         Clean up IndexedDB files between tests
3883         https://bugs.webkit.org/show_bug.cgi?id=192796
3884         <rdar://problem/46824999>
3885
3886         Reviewed by Geoffrey Garen.
3887
3888         * DumpRenderTree/mac/DumpRenderTree.mm:
3889         (runTest):
3890         * WebKitTestRunner/TestController.cpp:
3891         (WTR::TestController::resetStateToConsistentValues):
3892         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3893         (WTR::RemoveAllIndexedDatabasesCallback):
3894         (WTR::TestController::ClearIndexedDatabases):
3895         * WebKitTestRunner/TestController.h:
3896         * WebKitTestRunner/TestInvocation.cpp:
3897         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3898
3899 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3900
3901         [ews-app] Rename ews model Builds to Build
3902         https://bugs.webkit.org/show_bug.cgi?id=193695
3903
3904         Reviewed by Lucas Forschler.
3905
3906         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3907         (Build): Renamed Builds to Build.
3908
3909 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3910
3911         webkitpy: Wait longer when launching WebKitTestRunner
3912         https://bugs.webkit.org/show_bug.cgi?id=193734
3913
3914         Reviewed by Aakash Jain.
3915
3916         * Scripts/webkitpy/port/simulator_process.py:
3917         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3918
3919 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3920
3921         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3922         https://bugs.webkit.org/show_bug.cgi?id=193182
3923         <rdar://problem/47452154>
3924
3925         Reviewed by Tim Horton.
3926
3927         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3928         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3929         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3930
3931         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3932         preventing later tests from recognizing gestures.
3933
3934         * WebKitTestRunner/ios/TestControllerIOS.mm:
3935         (WTR::TestController::platformResetStateToConsistentValues):
3936
3937         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3938
3939 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3940
3941         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3942         https://bugs.webkit.org/show_bug.cgi?id=193722
3943         <rdar://problem/47481475>
3944
3945         Reviewed by Lucas Forschler.
3946
3947         iPhone and iPad ports should both use the iOS config.
3948
3949         * Scripts/webkitpy/port/ios_simulator.py:
3950         (IPhoneSimulatorPort.__init__):
3951         (IPadSimulatorPort.__init__):
3952
3953 2019-01-23  Rob Buis  <rbuis@igalia.com>
3954
3955         Update MIME type parser
3956         https://bugs.webkit.org/show_bug.cgi?id=180526
3957
3958         Reviewed by Frédéric Wang.
3959
3960         Add unit tests for both parse modes of ParsedContentType.
3961
3962         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3963         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3964         (TestWebKitAPI::TEST):
3965
3966 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3967
3968         [ews-app] fetch loop should not stop on network issues
3969         https://bugs.webkit.org/show_bug.cgi?id=193666
3970
3971         Reviewed by Lucas Forschler.
3972
3973         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3974         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3975
3976 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3977
3978         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3979         https://bugs.webkit.org/show_bug.cgi?id=189165
3980         <rdar://problem/47433765>
3981
3982         Reviewed by Tim Horton.
3983
3984         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3985         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3986         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3987         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3988         would make its way to the UI process by the time the layer tree commit is finished.
3989
3990         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3991         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3992         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3993         will fail because it asks for -_autofillContext too early.
3994
3995         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3996         is handled in the UI process.
3997
3998         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3999
4000         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
4001         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
4002         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
4003         input session.
4004
4005         (-[AutofillTestView textInputHasAutofillContext]):
4006
4007         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
4008
4009         * TestWebKitAPI/cocoa/TestWKWebView.h:
4010         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4011         (nextInputSessionChangeCount):
4012
4013         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
4014         This includes changing the focused element from one to another.
4015
4016         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
4017         (-[TestWKWebView didStartFormControlInteraction]):
4018         (-[TestWKWebView didEndFormControlInteraction]):
4019         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
4020
4021         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
4022         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
4023         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
4024         that doesn't require an input session to one that doesn't.
4025
4026 2019-01-22  David Kilzer  <ddkilzer@apple.com>
4027
4028         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
4029         <https://webkit.org/b/193676>
4030
4031         Reviewed by Alexey Proskuryakov.
4032
4033         * Scripts/webkitpy/style/checkers/cpp.py:
4034         (check_member_initialization_list):
4035         - Don't report missing whitespace around colon if the colon at
4036           the start of the line is formatted correctly.
4037         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4038         (WebKitStyleTest.test_member_initialization_list):
4039         - Add a test for a missing permutation of existing tests.
4040         - Add a test this false-positive.
4041         - Add blank lines between subtests to make them easier to read.
4042
4043 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
4044
4045         [build.webkit.org] Unit-test failure after r237113
4046         https://bugs.webkit.org/show_bug.cgi?id=193669
4047
4048         Reviewed by Michael Catanzaro.
4049
4050         * BuildSlaveSupport/build.webkit.org-config/factories.py:
4051         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
4052         multiple or zero flags.
4053
4054 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
4055
4056         Cache bytecode to disk
4057         https://bugs.webkit.org/show_bug.cgi?id=192782
4058         <rdar://problem/46084932>
4059
4060         Reviewed by Keith Miller.
4061
4062         Add test helper to execute bytecode-cache tests: it executes each test
4063         twice, the first with JSC_diskCachePath set to a temporary directory
4064         and second with JSC_forceDiskCache=true (in addition to the cache path)
4065         to guarantee that only the disk cache is being used and no new
4066         UnlinkedCodeBlocks are being created.
4067
4068         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
4069         * Scripts/run-jsc-stress-tests:
4070
4071 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
4072
4073         [css-logical] Implement flow-relative margin, padding and border shorthands
4074         https://bugs.webkit.org/show_bug.cgi?id=188697
4075
4076         Reviewed by Simon Fraser and Antti Koivisto.
4077
4078         * DumpRenderTree/TestOptions.cpp:
4079         (TestOptions::TestOptions):
4080         * DumpRenderTree/TestOptions.h:
4081         * DumpRenderTree/mac/DumpRenderTree.mm:
4082         (setWebPreferencesForTestOptions):
4083         Allow tests to enable the CSSLogicalEnabled flag in WK1.
4084
4085         * Scripts/webkitpy/style/checkers/jsonchecker.py:
4086         (JSONCSSPropertiesChecker.check_codegen_properties):
4087         Allow CSS property definitions to have a 'runtime-flag' parameter which
4088         disables the property when the specified runtime flag is disabled.
4089
4090 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
4091
4092         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
4093         https://bugs.webkit.org/show_bug.cgi?id=193643
4094
4095         Reviewed by Michael Catanzaro.
4096
4097         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
4098         * wpe/jhbuild.modules: Ditto.
4099
4100 2019-01-21  Zalan Bujtas  <zalan@apple.com>
4101
4102         [LFC][Floats] Take float top position into account when computing containing block height.
4103         https://bugs.webkit.org/show_bug.cgi?id=193655
4104
4105         Reviewed by Antti Koivisto.
4106
4107         * LayoutReloaded/misc/LFC-passing-tests.txt:
4108
4109 2019-01-21  David Kilzer  <ddkilzer@apple.com>
4110
4111         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
4112         <https://webkit.org/b/193645>
4113         <rdar://problem/47421574>
4114
4115         Reviewed by Alex Christensen.
4116
4117         - Now checks for local soft-linking of all frameworks that have
4118           their own *SoftLinking.{cpp,h,mm} files.
4119         - Changes softlink/uikit warning to softlink/framework.
4120
4121         * Scripts/webkitpy/style/checkers/cpp.py:
4122         (check_language):
4123         (CppChecker):
4124         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4125         (CppStyleTest):
4126
4127 2019-01-20  Saam Barati  <sbarati@apple.com>
4128
4129         Rollout r240210: It broke tests on iOS
4130         https://bugs.webkit.org/show_bug.cgi?id=193640
4131
4132         Unreviewed.
4133
4134         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
4135         * Scripts/run-jsc-stress-tests:
4136
4137 2019-01-20  chris fleizach  <cfleizach@apple.com>
4138
4139         AX: Support returning relative frames for accessibility
4140         https://bugs.webkit.org/show_bug.cgi?id=193414
4141         <rdar://problem/47268501>
4142
4143         Reviewed by Zalan Bujtas.
4144
4145         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4146         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4147         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4148         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4149         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4150         (WTR::attributesOfElement):
4151         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4152
4153 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
4154
4155         Unreviewed, add my new email address
4156
4157         * Scripts/webkitpy/common/config/contributors.json:
4158
4159 2019-01-19  Zalan Bujtas  <zalan@apple.com>
4160
4161         [LFC][BFC] <body>'s overflow property value is propagated to viewport
4162         https://bugs.webkit.org/show_bug.cgi?id=193617
4163
4164         Reviewed by Antti Koivisto.
4165
4166         * LayoutReloaded/misc/LFC-passing-tests.txt:
4167
4168 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
4169
4170         Unreviewed, rolling out r240209.
4171
4172         Broke GTK/WPE injected bundle
4173
4174         Reverted changeset:
4175
4176         "AX: Support returning relative frames for accessibility"
4177         https://bugs.webkit.org/show_bug.cgi?id=193414
4178         https://trac.webkit.org/changeset/240209
4179
4180 2019-01-12  Dan Bernstein  <mitz@apple.com>
4181
4182         [Cocoa] Avoid importing directly from subumbrella frameworks
4183         https://bugs.webkit.org/show_bug.cgi?id=186016
4184         <rdar://problem/40591038>
4185
4186         Reviewed by Sam Weinig.
4187
4188         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4189           LaunchServices header.
4190         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4191           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4192         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4193           when using SDKs earlier than 10.13.
4194         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4195           and OTHER_CPLUSPLUSFLAGS.
4196         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4197           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4198         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4199           LaunchServices header.
4200
4201 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
4202
4203         Cache bytecode to disk
4204         https://bugs.webkit.org/show_bug.cgi?id=192782
4205         <rdar://problem/46084932>
4206
4207         Reviewed by Keith Miller.
4208
4209         Add test helper to execute bytecode-cache tests: it executes each test
4210         twice, the first with JSC_diskCachePath set to a temporary directory
4211         and second with JSC_forceDiskCache=true (in addition to the cache path)
4212         to guarantee that only the disk cache is being used and no new
4213         UnlinkedCodeBlocks are being created.
4214
4215         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
4216         * Scripts/run-jsc-stress-tests:
4217
4218 2019-01-20  chris fleizach  <cfleizach@apple.com>
4219
4220         AX: Support returning relative frames for accessibility
4221         https://bugs.webkit.org/show_bug.cgi?id=193414
4222         <rdar://problem/47268501>
4223
4224         Reviewed by Zalan Bujtas.
4225
4226         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4227         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4228         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4229         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4230         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4231         (WTR::attributesOfElement):
4232         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4233
4234 2019-01-20  Antoine Quint  <graouts@apple.com>
4235
4236         Add a POINTER_EVENTS feature flag
4237         https://bugs.webkit.org/show_bug.cgi?id=193577
4238         <rdar://problem/47408511>
4239
4240         Unreviewed. Also enable Pointer Events for iosmac.
4241
4242         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4243
4244 2019-01-19  Zalan Bujtas  <zalan@apple.com>
4245
4246         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
4247         https://bugs.webkit.org/show_bug.cgi?id=193613
4248
4249         Reviewed by Antti Koivisto.
4250
4251         * LayoutReloaded/misc/LFC-passing-tests.txt:
4252
4253 2019-01-19  Antoine Quint  <graouts@apple.com>
4254
4255         Add a POINTER_EVENTS feature flag
4256         https://bugs.webkit.org/show_bug.cgi?id=193577
4257
4258         Reviewed by Dean Jackson.
4259
4260         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4261
4262 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
4263
4264         Disable the run-jsc-stress-test remote host key check [second round].
4265         https://bugs.webkit.org/show_bug.cgi?id=192988
4266
4267         Reviewed by Dewei Zhu.
4268
4269         * Scripts/run-jsc-stress-tests:
4270
4271 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4272
4273         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
4274         https://bugs.webkit.org/show_bug.cgi?id=193597
4275
4276         Reviewed by Lucas Forschler.
4277
4278         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4279
4280 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4281
4282         [build.webkit.org] api tests failures are incorrectly named as unit test failures
4283         https://bugs.webkit.org/show_bug.cgi?id=193595
4284
4285         Reviewed by Lucas Forschler.
4286
4287         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
4288         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
4289         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
4290
4291 2019-01-18  Chris Dumez  <cdumez@apple.com>
4292
4293         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
4294         https://bugs.webkit.org/show_bug.cgi?id=193588
4295         <rdar://problem/47131566>
4296
4297         Reviewed by Alex Christensen.
4298
4299         Add layout test coverage.
4300
4301         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4302
4303 2019-01-18  Jer Noble  <jer.noble@apple.com>
4304
4305         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
4306         https://bugs.webkit.org/show_bug.cgi?id=189553
4307
4308         Reviewed by Tim Horton.
4309
4310         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
4311
4312         * ContentExtensionTester/Configurations/Base.xcconfig:
4313         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
4314         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4315         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
4316         * ImageDiff/cg/Configurations/Base.xcconfig:
4317         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
4318         * MiniBrowser/Configurations/Base.xcconfig:
4319         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4320         * MobileMiniBrowser/Configurations/Base.xcconfig:
4321         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4322         * Scripts/webkitpy/style/checker.py:
4323         (_all_categories):
4324         (FileType):
4325         (CheckerDispatcher._file_type):
4326         (CheckerDispatcher._create_checker):
4327         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
4328         (SDKVariantChecker):
4329         (SDKVariantChecker.__init__):
4330         (SDKVariantChecker.check):
4331         * TestWebKitAPI/Configurations/Base.xcconfig:
4332         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
4333         * WebEditingTester/Configurations/Base.xcconfig:
4334         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
4335         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
4336         * WebKitTestRunner/Configurations/Base.xcconfig:
4337         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
4338         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
4339         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
4340
4341 2019-01-18  David Kilzer  <ddkilzer@apple.com>
4342
4343         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
4344         <https://webkit.org/b/193568>
4345         <rdar://problem/47381130>
4346
4347         Reviewed by Alex Christensen.
4348
4349         Make sure no one re-introduces UIKit soft-linking by adding a
4350         style rule.
4351
4352         * Scripts/webkitpy/style/checkers/cpp.py:
4353         (check_language): Add softlink/uikit check.
4354         (CppChecker): Enable softlink/uikit check.
4355         * Scripts/webkitpy/style/checkers/cpp_unittest.py: