False crashes in fast/text/emoji-gender-* tests
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
2
3         False crashes in fast/text/emoji-gender-* tests
4         https://bugs.webkit.org/show_bug.cgi?id=160779
5
6         Reviewed by Alexey Proskuryakov.
7
8         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
9
10         * Scripts/webkitpy/port/driver.py:
11         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
12         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
13         * Scripts/webkitpy/port/server_process.py:
14         (ServerProcess.write): Allow caller to disable crash flag on exception.
15
16 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
17
18         webkitpy error in TestRunResults.merge()
19         https://bugs.webkit.org/show_bug.cgi?id=160882
20
21         Reviewed by Daniel Bates.
22         
23         The argument to TestRunResults.merge() can be None if there are no device-specifc
24         initial results or retry results in Manager.run(), so just return early in that case.
25
26         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
27         (TestRunResults.merge):
28
29 2016-08-15  Sam Weinig  <sam@webkit.org>
30
31         Speed up compile times by not including wtf/Variant.h so much
32         https://bugs.webkit.org/show_bug.cgi?id=160847
33
34         Reviewed by Alex Christensen and Saam Barati.
35
36         * TestWebKitAPI/Tests/WTF/Variant.cpp:
37         (TestWebKitAPI::TEST):
38         Explicitly use std::experimental::variant.
39
40 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
41
42         Allow a port to run tests with a custom device setup
43         https://bugs.webkit.org/show_bug.cgi?id=160833
44
45         Reviewed by Daniel Bates.
46
47         These changes allow the IOSSimulator port to run tests in iPad mode.
48
49         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
50         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
51         a custom device will be collected into a set, and run in that device's environment after
52         the other tests have run.
53
54         * Scripts/webkitpy/layout_tests/controllers/manager.py:
55         (Manager._custom_device_for_test): If the test contains a directory matching a
56         custom device suffix, return that custom device.
57         (Manager._set_up_run): Push the custom device class, if any, into options so
58         that the Worker can get to it.
59         (Manager.run): Go through the list of tests, and break it down into device-generic
60         tests, and tests for each device class. _run_test_subset is then called for
61         each collection of tests, and the results merged.
62         (Manager._run_test_subset): Some lines unwrapped.
63         (Manager._end_test_run):
64         (Manager._run_tests):
65         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
66         (SingleTestRunner.__init__): Unwrapped a line.
67         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
68         (TestRunResults.merge): Add this function to merge TestRunResults
69         * Scripts/webkitpy/layout_tests/views/printing.py:
70         (Printer.print_workers_and_shards): Print the custom device, if any.
71         * Scripts/webkitpy/port/base.py:
72         (Port): Base port has empty array of custom devices.
73         (Port.setup_test_run): Add device_class argument.
74         * Scripts/webkitpy/port/driver.py:
75         (DriverInput.__repr__):
76         (Driver.check_driver.implementation):
77         * Scripts/webkitpy/port/efl.py:
78         (EflPort.setup_test_run):
79         * Scripts/webkitpy/port/gtk.py:
80         (GtkPort.setup_test_run):
81         * Scripts/webkitpy/port/ios.py:
82         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
83         (IOSSimulatorPort.__init__):
84         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
85         based on the custom device class.
86         (IOSSimulatorPort._set_device_class):
87         (IOSSimulatorPort._create_simulators): Factor some code into this function.
88         (IOSSimulatorPort.setup_test_run):
89         (IOSSimulatorPort.testing_device):
90         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
91         seemed wrong for this function. That was moved to setup_test_run().
92         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
93         but this happened too early, before we knew which kind of devices to create. Devices
94         are now created in setup_test_run().
95         * Scripts/webkitpy/port/win.py:
96         (WinPort.setup_test_run):
97
98 2016-08-15  Daniel Bates  <dabates@apple.com>
99
100         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
101         private frameworks and libraries
102         https://bugs.webkit.org/show_bug.cgi?id=155931
103         <rdar://problem/25807989>
104
105         Reviewed by Dan Bernstein.
106
107         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
108         where X is the major version of the active iOS SDK.
109
110         * DumpRenderTree/mac/Configurations/Base.xcconfig:
111         * WebKitTestRunner/Configurations/Base.xcconfig:
112
113 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
114
115         Add a setting and preferences to enable visual viewport mode
116         https://bugs.webkit.org/show_bug.cgi?id=160843
117
118         Reviewed by Sam Weinig.
119         
120         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
121
122         * MiniBrowser/mac/SettingsController.h:
123         * MiniBrowser/mac/SettingsController.m:
124         (-[SettingsController _populateMenu]):
125         (-[SettingsController validateMenuItem:]):
126         (-[SettingsController visualViewportEnabled]):
127         (-[SettingsController toggleVisualViewportEnabled:]):
128         * MiniBrowser/mac/WK1BrowserWindowController.m:
129         (-[WK1BrowserWindowController didChangeSettings]):
130         * MiniBrowser/mac/WK2BrowserWindowController.m:
131         (-[WK2BrowserWindowController didChangeSettings]):
132
133 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
134
135         Allow using make-dist with non-GTK ports
136         https://bugs.webkit.org/show_bug.cgi?id=160842
137
138         Reviewed by Michael Catanzaro.
139
140         This patch adds support for setting base name of tarball and argument
141         passed to cmake's -DPORT= via command line arguments.
142
143         * gtk/make-dist.py:
144         (Distcheck.configure):
145         (Distcheck.check):
146         (get_tarball_root_and_output_filename_from_arguments):
147
148 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
149
150         [GTK] Install script lacks gstreamer related dependencies
151         https://bugs.webkit.org/show_bug.cgi?id=160814
152
153         Reviewed by Carlos Garcia Campos.
154
155         * gtk/install-dependencies: Fedora case had already listed this dependencies,
156         but both Arch and Debian/Ubuntu were missing them.
157
158 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
159
160         make-dist.py should not allow unknown rules in manifest
161         https://bugs.webkit.org/show_bug.cgi?id=160841
162
163         Reviewed by Carlos Garcia Campos.
164
165         * gtk/make-dist.py:
166         (Manifest.process_line):
167
168 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
169
170         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
171         https://bugs.webkit.org/show_bug.cgi?id=160809
172
173         Reviewed by Carlos Garcia Campos.
174
175         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
176         case, and use it also for the new package names of libpng and libgeoclue.
177         * gtk/install-dependencies: Ditto.
178
179 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
180
181         Skip to check directories existence in build-webkit
182         https://bugs.webkit.org/show_bug.cgi?id=160691
183
184         Reviewed by Alex Christensen.
185
186         CMake checks if directories are there itself. So CMake ports
187         don't need to check it in the build-webkit script.
188
189         * Scripts/build-webkit:
190         * Scripts/webkitdirs.pm:
191         (determineSourceDir):
192         (isCMakeBuild):
193
194 2016-08-12  Alex Christensen  <achristensen@webkit.org>
195
196         Make URLParser work with URLs missing URL parts
197         https://bugs.webkit.org/show_bug.cgi?id=160824
198
199         Reviewed by Brady Eidson.
200
201         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
202         (TestWebKitAPI::s):
203         (TestWebKitAPI::checkURL):
204         (TestWebKitAPI::TEST_F):
205         (TestWebKitAPI::eq): Deleted.
206
207 2016-08-12  John Wilander  <wilander@apple.com>
208
209         Add HashCountedSet API tests to TestWTFLibrary target
210         https://bugs.webkit.org/show_bug.cgi?id=160815
211
212         Reviewed by Alex Christensen.
213
214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
215             Added HashCountedSet.cpp and sorted the file reference section
216             according to UNIX sort.
217
218 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
219
220         run-benchmark should run JetStream 1.1 instead of 1.0.1
221         https://bugs.webkit.org/show_bug.cgi?id=160816
222
223         Reviewed by Filip Pizlo.
224
225         Use the latest JetStream 1.1 in run-benchmark.
226
227         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
228         (BenchmarkBuilder.__exit__):
229         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
230         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
231         change to JetStream directory.
232
233 2016-08-12  Alex Christensen  <achristensen@webkit.org>
234
235         Initial URLParser implementation
236         https://bugs.webkit.org/show_bug.cgi?id=160811
237
238         Reviewed by Brady Eidson.
239
240         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
241         (TestWebKitAPI::eq):
242         (TestWebKitAPI::checkURL):
243         (TestWebKitAPI::TEST_F):
244
245 2016-08-12  Brady Eidson  <beidson@apple.com>
246
247         Fix the 32-bit Mac build after:
248         Add WK2 ExperimentalFeature support to MiniBrowser
249         https://bugs.webkit.org/show_bug.cgi?id=160788
250
251         Unreviewed.
252
253         Sprinkle "#if WK_API_ENABLED"s liberally.
254         
255         * MiniBrowser/mac/AppDelegate.m:
256         (defaultConfiguration):
257         * MiniBrowser/mac/SettingsController.m:
258         (-[SettingsController _populateMenu]):
259         (-[SettingsController validateMenuItem:]):
260
261 2016-08-12  Philippe Normand  <pnormand@igalia.com>
262
263         [GStreamer][OWR] Video rendering fixes
264         https://bugs.webkit.org/show_bug.cgi?id=160764
265
266         Reviewed by Xabier Rodriguez-Calvar.
267
268         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
269
270 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
271
272         Add missing return statement in convertFast function added in r204376.
273
274         Unreviewed.
275
276         * Scripts/webkitpy/common/system/path.py:
277         (_CygPath.convertFast):
278
279 2016-08-11  Brady Eidson  <beidson@apple.com>
280
281         Add WK2 ExperimentalFeature support to MiniBrowser.
282         https://bugs.webkit.org/show_bug.cgi?id=160788
283
284         Reviewed by Alex Christensen.
285
286         * MiniBrowser/mac/AppDelegate.h:
287         * MiniBrowser/mac/AppDelegate.m:
288         (defaultConfiguration):
289         (defaultPreferences):
290         
291         * MiniBrowser/mac/SettingsController.m:
292         (-[SettingsController _populateMenu]):
293         (-[SettingsController validateMenuItem:]):
294         (-[SettingsController toggleExperimentalFeature:]):
295
296 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
297
298         Keep EWS logs for longer
299         https://bugs.webkit.org/show_bug.cgi?id=160776
300
301         Reviewed by Daniel Bates.
302
303         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
304
305 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
306
307         iOS DRT/WTR project cleanup
308         https://bugs.webkit.org/show_bug.cgi?id=160778
309
310         Reviewed by Tim Horton.
311
312         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
313
314         Remove AppDelegate.* which were unused.
315
316         Exclude ios/Launch.storyboard on more platforms.
317
318         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
319         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
320         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
321         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
322         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
323         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
324         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
325
326 2016-08-11  Alex Christensen  <achristensen@webkit.org>
327
328         Fix Yosemite bots' cookie accept policies after r204365.
329         https://bugs.webkit.org/show_bug.cgi?id=160758
330
331         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
332         (TEST):
333         This makes the test fully clean up after itself.
334
335 2016-08-11  Alex Christensen  <achristensen@webkit.org>
336
337         Fix Yosemite bots' cookie accept policies after r204365.
338         https://bugs.webkit.org/show_bug.cgi?id=160758
339
340         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
341         (TEST):
342         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
343         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
344         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
345         causing any problems because there are no other API tests that do anything with cookies.
346         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
347         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
348         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
349
350 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
351
352         EWS should check if the patch is still valid before executing every major step
353         https://bugs.webkit.org/show_bug.cgi?id=160739
354         rdar://problem/27768813
355
356         Reviewed by Alexey Proskuryakov.
357
358         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
359         (CommitQueueTask.run): validate method is now executed in base class.
360         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
361         (EarlyWarningSystemTask.run): validate method is now executed in base class.
362         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
363         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
364         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
365         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
366         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
367         * Scripts/webkitpy/tool/commands/perfalizer.py:
368         (PerfalizerTask.validate): Added.
369         * Scripts/webkitpy/tool/commands/queues_unittest.py:
370         (test_manual_reject_during_processing): Updated test case.
371
372 2016-08-11  Alex Christensen  <achristensen@webkit.org>
373
374         Add URLParser stub
375         https://bugs.webkit.org/show_bug.cgi?id=160770
376
377         Reviewed by Sam Weinig.
378
379         * TestWebKitAPI/PlatformGTK.cmake:
380         * TestWebKitAPI/PlatformWin.cmake:
381         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
382         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
383         (TestWebKitAPI::TEST_F):
384
385 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
386
387         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
388         https://bugs.webkit.org/show_bug.cgi?id=160761
389
390         Reviewed by Tim Horton.
391
392         Give iOS DRT a Launch storyboard.
393
394         Have it use a UIViewController so future forms testing works correctly.
395
396         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
397         can run in iPad mode.
398
399         Remove empty InfoPlist.strings files.
400
401         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
402         * DumpRenderTree/ios/Info.plist:
403         * DumpRenderTree/ios/Launch.storyboard: Added.
404         * DumpRenderTree/mac/DumpRenderTree.mm:
405         (createWebViewAndOffscreenWindow):
406         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
407         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
408         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
409         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
410
411 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
412
413         [Win] Unable to reliably run tests in parallel
414         https://bugs.webkit.org/show_bug.cgi?id=140914
415
416         Reviewed by Brent Fulgham.
417
418         The cygpath utility function can fail badly when running with multiple DumpRenderTree
419         processes. We can use string replacement to convert the Cygwin path to a Windows path
420         instead.
421
422         * Scripts/webkitpy/common/system/path.py:
423         (cygpathFast):
424         * Scripts/webkitpy/port/driver.py:
425         (Driver._command_from_driver_input):
426
427 2016-08-10  Alex Christensen  <achristensen@webkit.org>
428
429         Fix crash when changing cookie accept policy after r204327
430         https://bugs.webkit.org/show_bug.cgi?id=160758
431
432         Reviewed by Simon Fraser.
433
434         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
435         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
436         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
437         (TEST):
438         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
439
440 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
441
442         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
443         https://bugs.webkit.org/show_bug.cgi?id=160757
444
445         Reviewed by Tim Horton.
446
447         When programmatically creating the test UIWindow, make a root UIViewController and parent
448         the WKWebView in its view. This makes the app more like a normal UIKit application.
449         
450         Move the WKWebView down 20px to avoid the status bar.
451         
452         Give the UIWindow a gray background so it's obvious where the window and view positioned.
453
454         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
455         
456         Remove duplicate references to Launch.storyboard.
457
458         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
459         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
460         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
461         (-[AppDelegate applicationWillResignActive:]): Deleted.
462         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
463         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
464         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
465         (-[AppDelegate applicationWillTerminate:]): Deleted.
466         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
467         (WTR::viewRectForWindowRect):
468         (WTR::PlatformWebView::PlatformWebView):
469         (WTR::PlatformWebView::setWindowFrame):
470
471 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
472
473         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
474         https://bugs.webkit.org/show_bug.cgi?id=160748
475
476         Reviewed by Tim Horton.
477         
478         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
479         opens the door for tests using other device sizes.
480
481         * WebKitTestRunner/ios/TestControllerIOS.mm:
482         (WTR::TestController::platformConfigureViewForTest):
483
484 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
485
486         Sort the feature flags in the FEATURE_DEFINES lines
487         https://bugs.webkit.org/show_bug.cgi?id=160742
488
489         Reviewed by Anders Carlsson.
490         
491         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
492
493 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
494
495         Logging and other minor improvements to iOS webkitpy
496         https://bugs.webkit.org/show_bug.cgi?id=160722
497
498         Reviewed by Dan Bates.
499
500         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
501         to make it easier to debug launching issues.
502
503         Have reset_preferences() reset the device, rather than just nuking the data
504         directory (which broke some versions of the simulator).
505
506         Make the Simulator.app launch in the background with open -g.
507
508         Wait for the simulator device to be in a known state in some more places.
509
510         * Scripts/webkitpy/port/ios.py:
511         (IOSSimulatorPort.setup_test_run):
512         (IOSSimulatorPort._quit_ios_simulator):
513         (IOSSimulatorPort.clean_up_test_run):
514         (IOSSimulatorPort.setup_environ_for_server):
515         (IOSSimulatorPort.reset_preferences):
516         * Scripts/webkitpy/xcode/simulator.py:
517         (Device.create):
518         (Device.delete):
519         (Device):
520         (Device.reset):
521         (Simulator.wait_until_device_is_booted):
522         (Simulator.wait_until_device_is_in_state):
523         (Simulator):
524         (Simulator.delete_device):
525         (Simulator.reset_device):
526         (Simulator.lookup_or_create_device):
527
528 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
529
530         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
531         https://bugs.webkit.org/show_bug.cgi?id=160697
532
533         Reviewed by Antonio Gomes.
534
535         * Scripts/webkitpy/port/base.py:
536         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
537         list of environment variables to copy.
538
539 2016-08-09  George Ruan  <gruan@apple.com>
540
541         Implement functionality of media capture on iOS
542         https://bugs.webkit.org/show_bug.cgi?id=158945
543         <rdar://problem/26893343>
544
545         Reviewed by Tim Horton.
546
547         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
548         Capture feature on iOS.
549
550 2016-08-09  Saam Barati  <sbarati@apple.com>
551
552         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
553         https://bugs.webkit.org/show_bug.cgi?id=160671
554         <rdar://problem/27756112>
555
556         Reviewed by Mark Lam.
557
558         * Scripts/run-jsc-stress-tests:
559
560 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
561
562         Make directory reading code in iOSSimulatorDevices() more strict
563         https://bugs.webkit.org/show_bug.cgi?id=160702
564
565         Reviewed by Tim Horton.
566
567         * Scripts/webkitdirs.pm:
568         (iOSSimulatorDevices):
569
570 2016-08-06  Sam Weinig  <sam@webkit.org>
571
572         Replace NodeOrString with std::variant<RefPtr<Node>, String>
573         https://bugs.webkit.org/show_bug.cgi?id=160638
574
575         Reviewed by Anders Carlsson.
576
577         * TestWebKitAPI/CMakeLists.txt:
578         * TestWebKitAPI/Tests/WTF/Variant.cpp:
579         Add additional tests for the initial state of std::variant and using
580         makeVisitor for visiting.
581
582 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
583
584         EWS logging should ensure the logging to file is stopped on queue termination
585         https://bugs.webkit.org/show_bug.cgi?id=160698
586         rdar://problem/24464570
587
588         Reviewed by Daniel Bates.
589
590         * Scripts/webkitpy/tool/bot/queueengine.py:
591         (QueueEngine._stopping): Stop logging to file on queue termination.
592         (QueueEngine._begin_logging): Configure the Python logger to log to file.
593         * Scripts/webkitpy/common/system/logutils.py:
594         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
595         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
596         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
597         * Scripts/webkitpy/tool/commands/queues.py:
598         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
599         (AbstractQueue.queue_log_path): Same.
600         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
601         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
602         which moved to QueueEngine now.
603         (PatchProcessingQueue.__init__): Same.
604         (CommitQueue.__init__): Same.
605         (AbstractReviewQueue.__init__): Same.
606         (StyleQueue.__init__): Same.
607         * Scripts/webkitpy/tool/commands/queues_unittest.py:
608         (TestCommitQueue): Removed host parameter.
609         (TestCommitQueue.__init__): Same.
610         (AbstractPatchQueueTest.test_next_patch): Same.
611         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
612         (test_commit_queue_failure): Same.
613         (mock_run_webkit_patch):
614         (MockCommitQueueTask.results_from_patch_test_run): Same.
615         (test_rollout_lands): Same.
616         (test_non_valid_patch): Same.
617         (test_auto_retry): Same.
618         (test_style_queue_with_watch_list_exception): Same.
619         (TestQueue.__init__): Deleted.
620         (TestReviewQueue.__init__): Deleted.
621         (TestFeederQueue.__init__): Deleted.
622
623 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
624
625         webkit-gtk tarball fails to build due to missing files
626         https://bugs.webkit.org/show_bug.cgi?id=160684
627
628         Reviewed by Alex Christensen.
629
630         * gtk/manifest.txt.in: Added back spi directories.
631
632 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
633
634         [GTK] Build the jhbuild with -O2 optimization level by default
635         https://bugs.webkit.org/show_bug.cgi?id=160544
636
637         Reviewed by Michael Catanzaro.
638
639         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
640         which don't increases the required disk space significatively and
641         provides better debug information than no passing it.
642
643 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
644
645         Allow more --cmakeargs option in build-jsc and build-webkit
646         https://bugs.webkit.org/show_bug.cgi?id=160340
647
648         Reviewed by Michael Catanzaro.
649
650         * Scripts/build-jsc:
651         * Scripts/build-webkit:
652
653 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
654
655         Do not check if WebKitLibraries folder exists on EFL and GTK
656         https://bugs.webkit.org/show_bug.cgi?id=160659
657
658         Reviewed by Csaba Osztrogonác.
659
660         Though WebKitLibraries is only needed by mac and win ports,
661         EFL and GTK ports have checked whether it exists.
662
663         * Scripts/build-webkit:
664
665 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
666
667         Some EWS console logs doesn't go to log file
668         https://bugs.webkit.org/show_bug.cgi?id=160585
669         rdar://problem/24464570
670
671         Reviewed by Daniel Bates.
672
673         * Scripts/webkitpy/common/system/logutils.py:
674         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
675         any possible overwriting.
676         * Scripts/webkitpy/common/system/filesystem.py:
677         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
678         * Scripts/webkitpy/common/system/filesystem_mock.py:
679         (MockFileSystem.open_text_file_for_writing): Same.
680         * Scripts/webkitpy/common/system/filesystem_unittest.py:
681         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
682         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
683         * Scripts/webkitpy/tool/commands/queues.py:
684         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
685         This will ensure that all the sub-modules inside webkitpy will log to file.
686
687 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
688
689         Have the iOS platform interit from the Apple platform in webkitpy
690         https://bugs.webkit.org/show_bug.cgi?id=160672
691
692         Reviewed by Dan Bates.
693         
694         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
695         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
696         ApplePort.
697         
698         Since WinPort also inherits from ApplePort, it needs to stub out some things
699         that are unavailable on Windows (leaks, sampling).
700         
701         Some SnowLeopard-related code and the associated test were removed.
702
703         * Scripts/webkitpy/port/apple.py:
704         (ApplePort.__init__):
705         (ApplePort):
706         (ApplePort._make_leak_detector):
707         (ApplePort.default_timeout_ms):
708         (ApplePort.supports_per_test_timeout):
709         (ApplePort.should_retry_crashes):
710         (ApplePort._generate_all_test_configurations):
711         (ApplePort.check_for_leaks):
712         (ApplePort.print_leaks_summary):
713         (ApplePort._path_to_webcore_library):
714         (ApplePort.show_results_html_file):
715         (ApplePort._merge_crash_logs):
716         (ApplePort._look_for_all_crash_logs_in_log_dir):
717         (ApplePort._get_crash_log):
718         (ApplePort.look_for_new_crash_logs):
719         (ApplePort.sample_process):
720         (ApplePort.sample_file_path):
721         (ApplePort.look_for_new_samples):
722         (ApplePort._path_to_helper):
723         (ApplePort.determine_full_port_name): Deleted.
724         * Scripts/webkitpy/port/ios.py:
725         (IOSSimulatorPort):
726         (IOSSimulatorPort.__init__):
727         (IOSSimulatorPort.default_timeout_ms): Deleted.
728         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
729         (IOSSimulatorPort.should_retry_crashes): Deleted.
730         (IOSSimulatorPort.check_for_leaks): Deleted.
731         (IOSSimulatorPort.print_leaks_summary): Deleted.
732         (IOSSimulatorPort._path_to_webcore_library): Deleted.
733         (IOSSimulatorPort.show_results_html_file): Deleted.
734         (IOSSimulatorPort.sample_file_path): Deleted.
735         (IOSSimulatorPort._merge_crash_logs): Deleted.
736         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
737         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
738         (IOSSimulatorPort.look_for_new_samples): Deleted.
739         (IOSSimulatorPort.sample_process): Deleted.
740         (IOSSimulatorPort._path_to_helper): Deleted.
741         (IOSSimulatorPort.make_command): Deleted.
742         * Scripts/webkitpy/port/mac.py:
743         (MacPort.__init__):
744         (MacPort.make_command):
745         (MacPort._build_java_test_support):
746         (MacPort): Deleted.
747         (MacPort.default_timeout_ms): Deleted.
748         (MacPort.supports_per_test_timeout): Deleted.
749         (MacPort.should_retry_crashes): Deleted.
750         (MacPort.default_child_processes): Deleted.
751         (MacPort.check_for_leaks): Deleted.
752         (MacPort.print_leaks_summary): Deleted.
753         (MacPort._path_to_webcore_library): Deleted.
754         (MacPort.show_results_html_file): Deleted.
755         (MacPort.sample_file_path): Deleted.
756         (MacPort._merge_crash_logs): Deleted.
757         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
758         (MacPort.look_for_new_crash_logs): Deleted.
759         (MacPort.look_for_new_samples): Deleted.
760         (MacPort.sample_process): Deleted.
761         (MacPort._path_to_helper): Deleted.
762         * Scripts/webkitpy/port/mac_unittest.py:
763         (MacTest.test_default_child_processes): Deleted.
764         * Scripts/webkitpy/port/win.py:
765         (WinPort.look_for_new_samples):
766         (WinPort):
767         (WinPort.sample_process):
768         (WinPort._make_leak_detector):
769         (WinPort.check_for_leaks):
770         (WinPort.print_leaks_summary):
771         (WinPort._path_to_webcore_library):
772
773 2016-08-08  Matt Baker  <mattbaker@apple.com>
774
775         Unreviewed: moved myself to the reviewers list.
776
777         * Scripts/webkitpy/common/config/contributors.json:
778
779 2016-08-08  Chris Dumez  <cdumez@apple.com>
780
781         Update API tests in mac/SetDocumentURI.mm after r204247
782         https://bugs.webkit.org/show_bug.cgi?id=160660
783
784         Reviewed by Alex Christensen.
785
786         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
787         (TestWebKitAPI::TEST):
788
789 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
790
791         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
792         https://bugs.webkit.org/show_bug.cgi?id=159827
793
794         Reviewed by Daniel Bates.
795
796         This change was spurred by a process hang which occurred between tests and did
797         not produce a meaningful crashlog.
798
799         * Scripts/webkitpy/port/driver.py:
800         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
801
802          * Scripts/webkitpy/port/ios.py:
803         (IOSSimulatorPort):
804         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
805         * Scripts/webkitpy/port/mac.py:
806         (MacPort):
807         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
808
809         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
810         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
811
812         * WebKitTestRunner/TestController.h:
813         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
814         * WebKitTestRunner/TestInvocation.cpp:
815         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
816
817 2016-08-07  Dan Bernstein  <mitz@apple.com>
818
819         [Cocoa] Reply block leaks if the remote object doesn’t call it
820         https://bugs.webkit.org/show_bug.cgi?id=160642
821
822         Reviewed by Sam Weinig.
823
824         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
825         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
826         (TEST): Added a test case that checks that the reply block is released even when it’s not
827           called.
828         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
829         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
830           calling the completion handler.
831
832 2016-08-07  Chris Dumez  <cdumez@apple.com>
833
834         Write API test to cover crash fix in r204135
835         https://bugs.webkit.org/show_bug.cgi?id=160587
836
837         Reviewed by Darin Adler.
838
839         Add API test to cover crash fix in r204135. This reproduces the crash
840         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
841         callback.
842
843         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
844         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
845         (TEST):
846
847 2016-08-06  Chris Dumez  <cdumez@apple.com>
848
849         Unreviewed, rolling out r204226.
850
851         Broke some API tests
852
853         Reverted changeset:
854
855         "Write API test to cover crash fix in r204135"
856         https://bugs.webkit.org/show_bug.cgi?id=160587
857         http://trac.webkit.org/changeset/204226
858
859 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
860
861         EWS Style Queue fails to process patches which fails validation
862         https://bugs.webkit.org/show_bug.cgi?id=160632
863
864         Reviewed by Alexey Proskuryakov.
865
866         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
867         (StyleQueueTask.validate): Add more information about validation failure.
868         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
869         * Scripts/webkitpy/tool/commands/queues_unittest.py:
870         (test_non_valid_patch): Add a unit test to test the above code path.
871
872 2016-08-06  Sam Weinig  <sam@webkit.org>
873
874         WTF needs a variant implementation
875         https://bugs.webkit.org/show_bug.cgi?id=160618
876
877         Reviewed by Darin Adler.
878
879         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
880         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
881         Add tests for the variant implementation.
882
883 2016-08-06  Chris Dumez  <cdumez@apple.com>
884
885         Write API test to cover crash fix in r204135
886         https://bugs.webkit.org/show_bug.cgi?id=160587
887
888         Reviewed by Darin Adler.
889
890         Add API test to cover crash fix in r204135. This reproduces the crash
891         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
892         callback.
893
894         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
895         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
896         (TEST):
897
898 2016-08-05  Tim Horton  <timothy_horton@apple.com>
899
900         run-api-tests should use a headed simulator
901         https://bugs.webkit.org/show_bug.cgi?id=160611
902
903         Reviewed by Sam Weinig.
904
905         CADisplayLink doesn't work in a headless simulator, but is
906         vital for the proper functioning of WebKit2 painting on iOS.
907         So, we should not use a headless simulator.
908
909         * Scripts/run-api-tests:
910         Launch a simulator app, don't just boot the simulator.
911
912         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
913         Re-enable a test that works now.
914
915 2016-08-05  Dan Bernstein  <mitz@apple.com>
916
917         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
918         https://bugs.webkit.org/show_bug.cgi?id=160589
919
920         Reviewed by Tim Horton.
921
922         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
923         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
924           blocks, which wasn’t caught because the test wasn’t run correctly.
925         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
926         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
927           added a test that sends over an NSRange.
928         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
929         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
930           handler with the range‘s location and length.
931
932 2016-08-05  Enrica Casucci  <enrica@apple.com>
933
934         Fixing tests failing after r204175.
935
936         Unreviewed.
937
938         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
939
940 2016-08-05  Enrica Casucci  <enrica@apple.com>
941
942         Build fix after 204053.
943
944         Unreviewed.
945
946         * TestWebKitAPI/Configurations/Base.xcconfig:
947         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
948         (-[MockContentFilterEnabler initWithCoder:]):
949         (-[MockContentFilterEnabler dealloc]):
950
951 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
952
953         Print test name in "Last character read from DRT..." error message.
954         https://bugs.webkit.org/show_bug.cgi?id=160559
955
956         Reviewed by Michael Catanzaro.
957
958         * Scripts/webkitpy/port/driver.py:
959         (Driver.run_test):
960         (Driver._read_first_block):
961         (Driver._read_optional_image_block):
962         (Driver._read_block):
963         * Scripts/webkitpy/port/driver_unittest.py:
964         (DriverTest.test_read_block):
965         (DriverTest.test_read_binary_block):
966         (DriverTest.test_read_base64_block):
967
968 2016-08-05  Commit Queue  <commit-queue@webkit.org>
969
970         Unreviewed, rolling out r204123.
971         https://bugs.webkit.org/show_bug.cgi?id=160597
972
973         Caused layout test timeouts on Windows. (Requested by perarne
974         on #webkit).
975
976         Reverted changeset:
977
978         "[Win] Unable to reliably run tests in parallel"
979         https://bugs.webkit.org/show_bug.cgi?id=140914
980         http://trac.webkit.org/changeset/204123
981
982 2016-08-04  Saam Barati  <sbarati@apple.com>
983
984         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
985         https://bugs.webkit.org/show_bug.cgi?id=151241
986
987         Reviewed by Benjamin Poulain.
988
989         * Scripts/run-jsc-stress-tests:
990
991 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
992
993         UI improvements to Flakiness Dashboard.
994         https://bugs.webkit.org/show_bug.cgi?id=153295
995
996         Reviewed by Alexey Proskuryakov.
997
998         * TestResultServer/static-dashboards/flakiness_dashboard.css:
999         (td.options-container): Center text in most fields.
1000         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1001         (createBugHTML): Text/Grammar updates.
1002         (tableHeaders): Ditto.
1003         (htmlForSingleTestRow): Ditto.
1004         (headerForTestTableHtml): Ditto.
1005         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1006         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1007
1008 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1009
1010         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1011         https://bugs.webkit.org/show_bug.cgi?id=160518
1012
1013         Reviewed by Michael Catanzaro.
1014
1015         * Scripts/webkitpy/thirdparty/__init__.py:
1016         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1017         * gtk/install-dependencies:
1018
1019 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1020
1021         Optimize bot watcher's dashboard a little
1022         https://bugs.webkit.org/show_bug.cgi?id=160515
1023         rdar://problem/26096900
1024
1025         Reviewed by Lucas Forschler.
1026
1027         Made re-sorting after loading an iteration more efficient.
1028
1029         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1030         (BuildbotIteration.prototype._updateWithData):
1031         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1032         (BuildbotQueue.prototype.updateIterationPosition):
1033
1034 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1035
1036         [Win] Unable to reliably run tests in parallel
1037         https://bugs.webkit.org/show_bug.cgi?id=140914
1038
1039         Reviewed by Brent Fulgham.
1040
1041         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1042         processes. We can use string replacement to convert the Cygwin path to a Windows path
1043         instead.
1044  
1045         * Scripts/webkitpy/common/system/path.py:
1046         (cygpathFast):
1047         * Scripts/webkitpy/port/driver.py:
1048         (Driver._command_from_driver_input):
1049
1050 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1051
1052         Document instructions for increasing process and file limits
1053         https://bugs.webkit.org/show_bug.cgi?id=160528
1054         rdar://problem/24777576
1055
1056         Reviewed by Alexey Proskuryakov.
1057
1058         * Scripts/webkitpy/port/ios.py:
1059         (IOSSimulatorPort.default_child_processes):
1060
1061 2016-08-03  Anders Carlsson  <andersca@apple.com>
1062
1063         Remove the Objective-C bindings generator
1064         https://bugs.webkit.org/show_bug.cgi?id=160526
1065
1066         Reviewed by Sam Weinig.
1067
1068         * Scripts/run-bindings-tests:
1069         Update test.
1070
1071 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1072
1073         Revise a TestWebKitAPI comment to mention the actual underlying problem
1074
1075         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1076         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1077
1078 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1079
1080         Benchmark test content-animation timeouts always
1081         https://bugs.webkit.org/show_bug.cgi?id=160057
1082
1083         Reviewed by Simon Fraser.
1084
1085         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1086         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1087         (start):
1088
1089 2016-08-02  Nan Wang  <n_wang@apple.com>
1090
1091         AX: Simulated touch events are not working on iOS
1092         https://bugs.webkit.org/show_bug.cgi?id=160395
1093         <rdar://problem/27633597>
1094
1095         Reviewed by Chris Fleizach.
1096
1097         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1098         (WTR::AccessibilityUIElement::press):
1099         (WTR::AccessibilityUIElement::setSelectedChild):
1100
1101 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1102
1103         run-javascriptcore-tests should accept multiple --extra-tests
1104         https://bugs.webkit.org/show_bug.cgi?id=160486
1105
1106         Reviewed by Saam Barati.
1107         
1108         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1109         test suites. This does it by using GetOpt::Long's array support.
1110
1111         * Scripts/run-javascriptcore-tests:
1112         (runJSCStressTests):
1113
1114 2016-08-02  Enrica Casucci  <enrica@apple.com>
1115
1116         Allow building with content filtering disabled.
1117         https://bugs.webkit.org/show_bug.cgi?id=160454
1118
1119         Reviewed by Simon Fraser.
1120
1121         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1122
1123 2016-08-02  Brady Eidson  <beidson@apple.com>
1124
1125         Removing IndexedDB WebsiteData can fail for some users.
1126         https://bugs.webkit.org/show_bug.cgi?id=160463
1127
1128         Reviewed by Alex Christensen.
1129
1130         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1131
1132 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1133
1134         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1135         https://bugs.webkit.org/show_bug.cgi?id=160437
1136         <rdar://problem/27578272>
1137
1138         Reviewed by Brady Eidson.
1139
1140         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1141         (-[DownloadDelegate _download:didReceiveResponse:]):
1142         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1143         (runTest):
1144         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1145
1146 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1147
1148         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1149         https://bugs.webkit.org/show_bug.cgi?id=160414
1150
1151         Reviewed by Michael Catanzaro.
1152
1153         * Scripts/webkitpy/port/linux_get_crash_log.py:
1154         (GDBCrashLogGenerator._wait_for_corefile):
1155
1156 2016-08-01  Youenn Fablet  <youenn@apple.com>
1157
1158         Make wpt server generate its certificates in layout test results folder
1159         https://bugs.webkit.org/show_bug.cgi?id=160422
1160
1161         Reviewed by Chris Dumez.
1162
1163         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1164         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1165
1166 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1167
1168         Function Call on NULL Object
1169         https://bugs.webkit.org/show_bug.cgi?id=160325
1170
1171         Reviewed by Darin Adler.
1172
1173         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1174         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1175         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1176
1177 2016-08-01  Keith Miller  <keith_miller@apple.com>
1178
1179         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1180         https://bugs.webkit.org/show_bug.cgi?id=160372
1181
1182         Rubber stamped by Geoffrey Garen.
1183
1184         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1185         a new top level directory, JSTests. Having the tests in the Source directory
1186         was both confusing an inconvenient for people that just want to checkout the
1187         source code of WebKit. Since there is no other obvious place to put all the
1188         JavaScript tests a new top level directory seemed the most sensible.
1189
1190         * Scripts/import-test262-tests:
1191         * Scripts/run-javascriptcore-tests:
1192         * Scripts/update-javascriptcore-test-res:
1193
1194 2016-07-31  Nan Wang  <n_wang@apple.com>
1195
1196         AX: Add a check for touch event listener on iOS accessibility object
1197         https://bugs.webkit.org/show_bug.cgi?id=160388
1198
1199         Reviewed by Chris Fleizach.
1200
1201         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1202         (AccessibilityUIElement::boolAttributeValue):
1203         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1204         (WTR::AccessibilityUIElement::boolAttributeValue):
1205
1206 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1207
1208         Unreviewed: add myself to the reviewers list.
1209
1210         * Scripts/webkitpy/common/config/contributors.json:
1211
1212 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1213
1214         Undo r203939, and copy over a rule that clips the logos.
1215
1216         Sierra wasn't the only logo without transparency.
1217
1218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1221
1222 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1223
1224         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1225         https://bugs.webkit.org/show_bug.cgi?id=160377
1226
1227         Reviewed by Brian Weinstein.
1228
1229         Update assets to remove the white background and use a transparent background instead.
1230
1231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1232         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1233
1234 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1235
1236         Ignore most check-webkit-style checks for ANGLE project
1237         <https://webkit.org/b/160333>
1238
1239         Reviewed by Daniel Bates.
1240
1241         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1242         - No tabs.
1243         - No spaces at the end of lines.
1244         - No carriage returns (DOS line endings).
1245
1246 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1247
1248         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1249         https://bugs.webkit.org/show_bug.cgi?id=160360
1250         <rdar://problem/27179484>
1251
1252         Reviewed by Myles C. Maxfield.
1253
1254         Adds two tests verifying that videos may be considered main content as long as they
1255         are large enough and cover a majority of the mainframe's viewport.
1256
1257         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1258         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1259         (TestWebKitAPI::TEST):
1260         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1261         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1262
1263 2016-07-29  Mark Lam  <mark.lam@apple.com>
1264
1265         Gardening: removed unused variable.
1266
1267         Not reviewed.
1268
1269         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1270         (TestWebKitAPI::TEST):
1271
1272 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1273
1274         Add TestWebKitAPI support for interacting with media controls
1275         https://bugs.webkit.org/show_bug.cgi?id=160342
1276         <rdar://problem/27610246>
1277
1278         Reviewed by Beth Dakin.
1279
1280         Adds support for testing interaction with some media controls, as well as a basic test
1281         verifying that media control teardown after interaction does not result in a crash.
1282
1283         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1284         (-[WKWebView mouseDownAtPoint:]):
1285         (-[WKWebView performAfterLoading:]):
1286         (TestWebKitAPI::TEST):
1287
1288 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1289
1290         Crash Log Clobbering on Unbound Crashes
1291         https://bugs.webkit.org/show_bug.cgi?id=160198
1292         <rdar://problem/27472618>
1293
1294         Reviewed by Alexey Proskuryakov.
1295
1296         * Scripts/webkitpy/common/system/crashlogs.py:
1297         (CrashLogs): Fix header order.
1298         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1299         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1300
1301 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1302
1303         Update for contributors.json
1304         https://bugs.webkit.org/show_bug.cgi?id=160294
1305
1306         * Scripts/webkitpy/common/config/contributors.json:
1307
1308 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1309
1310         Remove deprecated SPI for video inline / fullscreen controls
1311         https://bugs.webkit.org/show_bug.cgi?id=160318
1312
1313         Reviewed by Tim Horton.
1314
1315         * DumpRenderTree/mac/DumpRenderTree.mm:
1316         (setDefaultsToConsistentValuesForTesting): Deleted.
1317         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1318         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1319         * WebKitTestRunner/TestController.cpp:
1320         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1321         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1322         (WTR::initializeWebViewConfiguration): Deleted.
1323
1324 2016-07-28  Daniel Bates  <dabates@apple.com>
1325
1326         [iOS] TestWebKitAPI bundle targets are not code signed
1327         https://bugs.webkit.org/show_bug.cgi?id=160328
1328         <rdar://problem/27409246>
1329
1330         Reviewed by Andy Estes.
1331
1332         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1333         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1334         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1335
1336         * TestWebKitAPI/Configurations/Base.xcconfig:
1337
1338 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1339
1340         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1341
1342         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1343         (animatedResizeWebView):
1344         (TEST):
1345         This test times out only when run in the WebKit Testing simulator environment,
1346         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1347
1348 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1349
1350         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1351         https://bugs.webkit.org/show_bug.cgi?id=160289
1352         <rdar://problem/27553464>
1353
1354         Reviewed by Simon Fraser.
1355
1356         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1357         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1358         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1359         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1360         (-[AnimatedResizeWebView _endAnimatedResize]):
1361         (animatedResizeWebView):
1362         (TEST):
1363         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1364         Add two tests that ensure that hidden-content and animated resizes
1365         don't cause unnecessary synchronous waits. Only the hidden-content
1366         one fails before my patch, but it seemed reasonable to add both anyway.
1367
1368 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1369
1370         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1371         <https://webkit.org/b/83342>
1372
1373         Reviewed by Ryosuke Niwa.
1374
1375         * Scripts/webkitpy/common/checkout/scm/git.py:
1376         (Git.revisions_changing_file): Remove code to raise an exception
1377         when the file doesn't exist.  If a file was moved or renamed,
1378         then this caused the script to terminate, which was very
1379         frustrating when you wanted a list of reviewers.
1380         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1381         (SCMTest._shared_test_revisions_changing_file): Update test
1382         expectation to return an empty list of revisions.
1383         (test_create_patch_is_full_patch): Drive-by fix when running all
1384         webkitpy tests (including scm tests).
1385         * Scripts/webkitpy/common/checkout/scm/svn.py:
1386         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1387         return an empty array of revisions if this occurs.
1388
1389 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1390
1391         EWS error message "Error: * did not process patch" should include explanation
1392         https://bugs.webkit.org/show_bug.cgi?id=159903
1393         <rdar://problem/27410788>
1394
1395         Reviewed by Alexey Proskuryakov.
1396
1397         * QueueStatusServer/handlers/statusbubble.py:
1398         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1399         is not processed.
1400         * QueueStatusServer/handlers/processingtimesjson.py:
1401         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1402         of the code.
1403         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1404         (CommitQueueTask.validate): Add more information about validation failure.
1405         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1406         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1407         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1408         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1409         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1410         (PatchIsNotValid.__init__): Add the failure_message argument.
1411         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1412         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1413         failure details.
1414         * Scripts/webkitpy/tool/commands/queues.py:
1415         (CommitQueue.process_work_item): Same.
1416         (StyleQueue.review_patch): Same.
1417         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1418         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1419
1420 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1421
1422         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1423         https://bugs.webkit.org/show_bug.cgi?id=160262
1424
1425         Reviewed by Daniel Bates.
1426
1427         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1428         (-[LTRelayController installApp]):
1429
1430 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1431
1432         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1433         https://bugs.webkit.org/show_bug.cgi?id=160225
1434
1435         Reviewed by Alexey Proskuryakov.
1436
1437         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1438
1439 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1440
1441         [GTK] Fix some video/canvas tests that should be passing
1442         https://bugs.webkit.org/show_bug.cgi?id=160023
1443
1444         Reviewed by Carlos Garcia Campos.
1445
1446         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1447         EFL or GTK platforms.
1448
1449         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1450         (WTR::TestController::platformConfigureViewForTest):
1451         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1452         (WTR::TestController::platformConfigureViewForTest):
1453
1454 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1455
1456         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1457         https://bugs.webkit.org/show_bug.cgi?id=160247
1458
1459         Reviewed by Michael Catanzaro.
1460
1461         * BuildSlaveSupport/built-product-archive:
1462         (createZip):
1463         (dirContainsdwo):
1464         (archiveBuiltProduct):
1465
1466 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1467
1468         Fix tests after r203743.
1469         https://bugs.webkit.org/show_bug.cgi?id=156947
1470
1471         * WebKitTestRunner/TestController.cpp:
1472         (WTR::TestController::resetStateToConsistentValues):
1473         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1474
1475 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1476
1477         [iPhone] Playing a video on tudou.com plays only sound, no video
1478         https://bugs.webkit.org/show_bug.cgi?id=160178
1479         <rdar://problem/27535468>
1480
1481         Reviewed by Dan Bernstein.
1482
1483         * DumpRenderTree/mac/DumpRenderTree.mm:
1484         (setDefaultsToConsistentValuesForTesting):
1485         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1486         (RequiresUserActionForPlaybackTest::SetUp):
1487         * WebKitTestRunner/TestController.cpp:
1488         (WTR::TestController::resetPreferencesToConsistentValues):
1489         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1490         (WTR::initializeWebViewConfiguration):
1491
1492 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1493
1494         Allow LOG macros to be used outside the namespace, and other logging cleanup
1495         https://bugs.webkit.org/show_bug.cgi?id=160216
1496
1497         Reviewed by Anders Carlsson.
1498         
1499         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1500
1501         * DumpRenderTree/TestRunner.cpp:
1502         * DumpRenderTree/mac/DumpRenderTree.mm:
1503         (resetWebViewToConsistentStateBeforeTesting):
1504
1505 2016-07-26  David Kilzer <ddkilzer@apple.com>
1506
1507         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1508         https://bugs.webkit.org/show_bug.cgi?id=156947
1509         <rdar://problem/23325160>
1510
1511         Reviewed by Alex Christensen.
1512
1513         * DumpRenderTree/TestRunner.cpp:
1514         (TestRunner::TestRunner):
1515         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1516         * DumpRenderTree/TestRunner.h:
1517         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1518         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1519         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1520         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1521         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1522         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1523         (WTR::TestRunner::queueNonLoadingScript):
1524         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1525         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1526         * WebKitTestRunner/TestController.cpp:
1527         (WTR::TestController::didReceiveAuthenticationChallenge):
1528         * WebKitTestRunner/TestController.h:
1529         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1530         * WebKitTestRunner/TestInvocation.cpp:
1531         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1532         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1533
1534 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1535
1536         check-for-exit-time-destructors should be usable outside Xcode
1537         <https://webkit.org/b/160195>
1538
1539         Reviewed by Darin Adler.
1540
1541         * Scripts/check-for-exit-time-destructors: Update to parse
1542         -h|--help switch, or to take one argument to a binary to check
1543         for exit time destructors on the command-line.  The clang
1544         compiler will find these at compile-time with the
1545         -Wexit-time-destructors switch, but this script will check for
1546         them after-the-fact.
1547
1548 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1549
1550         Test svn.webkit.org functionality after maintenance.
1551
1552 2016-07-25  Brady Eidson  <beidson@apple.com>
1553
1554         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1555         https://bugs.webkit.org/show_bug.cgi?id=153783
1556
1557         Reviewed by Alex Christensen.
1558
1559         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
1560         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1561         
1562         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1563         
1564         Change the relevant API tests to make sure this continues to be no longer required.
1565
1566         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1567         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1568         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1569         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1570         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1571         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1572
1573 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1574
1575         Media controls should not be displayed for a video until it starts playing
1576         https://bugs.webkit.org/show_bug.cgi?id=160092
1577         <rdar://problem/26986673>
1578
1579         Reviewed by Beth Dakin.
1580
1581         Verify that multiple videos do or don't show the media controller depending on whether videos
1582         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1583         passing because we were always showing media controls for large videos with audio, even if they
1584         had not played back yet. This change ensures that large videos with audio show media controls
1585         only after they begin to play back, and not by virtue of being large enough for main content.
1586
1587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1588         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1589         (TestWebKitAPI::TEST):
1590         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1591         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1592         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1593
1594 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1595
1596         Media controls on apple.com don't disappear when movie finishes playing
1597         https://bugs.webkit.org/show_bug.cgi?id=160068
1598         <rdar://problem/26668526>
1599
1600         Reviewed by Darin Adler.
1601
1602         Adds new API tests. Please see WebCore ChangeLog for more details.
1603
1604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1605         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1606         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1607         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1608         (TestWebKitAPI::TEST):
1609         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1610         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1611         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1612         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1613         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1614
1615 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1616
1617         Unreviewed, fix test-webkitpy after r203674.
1618
1619         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1620         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1621
1622 2016-07-24  Philippe Normand  <pnormand@igalia.com>
1623
1624         Unreviewed, forgot to commit this file in r203674.
1625
1626         * Scripts/process-linux-coredump: Added.
1627         (main):
1628
1629 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1630
1631         Improve GDB backtrace generation for GTK/EFL
1632         https://bugs.webkit.org/show_bug.cgi?id=128928
1633
1634         Reviewed by Carlos Garcia Campos.
1635
1636         The PID of the crashed process is now correctly supplied to the
1637         crash log reporter. The kernel core_pattern needs to be updated
1638         after this change to something like:
1639
1640         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1641
1642         * Scripts/process-linux-coredump: Added.
1643         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1644         * Scripts/webkitpy/port/efl.py:
1645         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1646         * Scripts/webkitpy/port/gtk.py:
1647         (GtkPort._get_crash_log): Ditto.
1648         * Scripts/webkitpy/port/linux_get_crash_log.py:
1649         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1650         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1651         (GDBCrashLogGenerator): Deleted.
1652         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1653         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
1654         * WebKitTestRunner/TestController.cpp:
1655         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
1656         (WTR::TestController::databaseProcessDidCrash): Ditto.
1657         (WTR::TestController::processDidCrash): Ditto.
1658
1659 2016-07-23  Youenn Fablet  <youenn@apple.com>
1660
1661         WPT stash server should be kept running when launching wpt server
1662         https://bugs.webkit.org/show_bug.cgi?id=160052
1663
1664         Reviewed by Sam Weinig.
1665
1666         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1667         (main): waiting to read stdin while stash server is started.
1668
1669 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1670
1671         Media controls should be displayed for media in media documents
1672         https://bugs.webkit.org/show_bug.cgi?id=160104
1673         <rdar://problem/27438936>
1674
1675         Reviewed by Myles C. Maxfield.
1676
1677         Verifies that even a small video with audio in a media document gets media controls.
1678
1679         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1680         (TestWebKitAPI::TEST):
1681
1682 2016-07-22  Michael Saboff  <msaboff@apple.com>
1683
1684         REGRESSION(203616): no FTL testing was inadvertently removed
1685         https://bugs.webkit.org/show_bug.cgi?id=160100
1686
1687         Rubber-stamped by Filip Pizlo.
1688
1689         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
1690         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
1691         logic for the runLayout and runNoisy variants to match the run test logic,
1692         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
1693         enabled platforms.
1694
1695         * Scripts/run-jsc-stress-tests:
1696
1697 2016-07-22  Brady Eidson  <beidson@apple.com>
1698
1699         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
1700         https://bugs.webkit.org/show_bug.cgi?id=160089
1701
1702         Reviewed by Darin Adler.
1703
1704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1705         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
1706         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
1707
1708 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
1709
1710         [GTK] Improved exclusion patterns in make-dist.py manifest.
1711         https://bugs.webkit.org/show_bug.cgi?id=160094
1712
1713         Reviewed by Michael Catanzaro.
1714
1715         * gtk/manifest.txt.in:
1716         Exclude Platform*.cmake files for more ports.
1717         Removed obsolete .gyp and .pro.user patterns.
1718         Exclude 'Configurations' and 'spi' directories.
1719         Exclude CMakeLists.txt.user (Qt Creator IDE).
1720
1721 2016-07-22  Michael Saboff  <msaboff@apple.com>
1722
1723         Don't run FTL related JSC stress tests on non-FTL platforms
1724         https://bugs.webkit.org/show_bug.cgi?id=160033
1725
1726         Reviewed by Mark Lam.
1727
1728         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
1729         Refactored several of the runXXX test methods to always runXXXDefault and made those
1730         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
1731         doesn't cause a problem.
1732
1733         * Scripts/run-jsc-stress-tests:
1734
1735 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
1736
1737         IWebView::mainFrame crashes if called after IWebView::close
1738         https://bugs.webkit.org/show_bug.cgi?id=32868
1739
1740         Reviewed by Brent Fulgham.
1741
1742         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1743         (TestWebKitAPI::TEST_F): Added test.
1744
1745 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1746
1747         [GTK] Enable threaded compositor by default
1748         https://bugs.webkit.org/show_bug.cgi?id=160079
1749
1750         Reviewed by Žan Doberšek.
1751
1752         * Scripts/webkitperl/FeatureList.pm:
1753
1754 2016-07-22  Youenn Fablet  <youenn@apple.com>
1755
1756         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
1757         https://bugs.webkit.org/show_bug.cgi?id=159921
1758
1759         Reviewed by Brian Burg.
1760
1761         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
1762
1763         * Scripts/webkitpy/codegen/main.py:
1764         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
1765         (BuiltinsGeneratorTests):
1766         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
1767         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
1768         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
1769         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
1770
1771 2016-07-21  Dan Bernstein  <mitz@apple.com>
1772
1773         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
1774         https://bugs.webkit.org/show_bug.cgi?id=160072
1775
1776         Reviewed by Andy Estes.
1777
1778         * Scripts/webkitdirs.pm:
1779         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
1780           for old Xcode versions.
1781         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
1782           to readXcodeUserDefault.
1783         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
1784           debugger.
1785         (determineDebugger): Ditto.
1786         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
1787           7.0.
1788         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
1789           switches.
1790         (execMacWebKitAppForDebugging): Removed support for GDB.
1791
1792 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1793
1794         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
1795         https://bugs.webkit.org/show_bug.cgi?id=160066
1796
1797         Reviewed by Dean Jackson.
1798
1799         * DumpRenderTree/mac/DumpRenderTree.mm:
1800         (setDefaultsToConsistentValuesForTesting): Deleted.
1801         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1802         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1803         * WebKitTestRunner/TestController.cpp:
1804         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1805         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1806         (WTR::initializeWebViewConfiguration): Deleted.
1807
1808 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
1809
1810         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
1811         https://bugs.webkit.org/show_bug.cgi?id=159980
1812         rdar://problem/27450825
1813
1814         Reviewed by Dan Bernstein.
1815
1816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1817         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
1818         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
1819         when our delegate has hit -dealloc.
1820         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
1821         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
1822         will not be messaged.
1823
1824 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1825
1826         Follow-up patch to r203520
1827         https://bugs.webkit.org/show_bug.cgi?id=159967
1828         <rdar://problem/26964090>
1829
1830         Unreviewed.
1831
1832         * DumpRenderTree/mac/DumpRenderTree.mm:
1833         (setDefaultsToConsistentValuesForTesting):
1834         * WebKitTestRunner/TestController.cpp:
1835         (WTR::TestController::resetPreferencesToConsistentValues):
1836
1837 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1838
1839         [iPhone] Playing a video on tudou.com plays only sound, no video
1840         https://bugs.webkit.org/show_bug.cgi?id=159967
1841         <rdar://problem/26964090>
1842
1843         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
1844
1845         Migrate tests to use new SPI.
1846
1847         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1848         (RequiresUserActionForPlaybackTest::SetUp):
1849         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1850         (WTR::initializeWebViewConfiguration):
1851
1852 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
1853
1854         Clarify testing mode names in run-jsc-stress-tests
1855         https://bugs.webkit.org/show_bug.cgi?id=160021
1856
1857         Reviewed by Mark Lam.
1858
1859         Default should mean really default, not default with disabled FTL, renamed
1860         - runMozillaTestDefault to runMozillaTestNoFTL
1861         - runMozillaTestDefaultFTL to runMozillaTestDefault
1862         - runDefault to runNoFTL
1863         - runDefaultFTL to runDefault
1864         - runLayoutTestDefault to runLayoutTestNoFTL
1865         - runLayoutTestDefaultFTL to runLayoutTestDefault
1866         - runNoisyTestDefault to runNoisyTestNoFTL
1867         - runNoisyTestDefaultFTL to runNoisyTestDefault
1868
1869         * Scripts/run-jsc-stress-tests:
1870
1871 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
1872
1873         WebBackForwardList's currentIndex could get out of bounds when filtering items.
1874         https://bugs.webkit.org/show_bug.cgi?id=159986
1875
1876         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
1877         to 0.
1878
1879         Reviewed by Dan Bernstein.
1880
1881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1882         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
1883         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
1884         (TEST):
1885
1886 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1887
1888         [GTK] Web view background colors don't work in accelerated compositing mode
1889         https://bugs.webkit.org/show_bug.cgi?id=159455
1890
1891         Reviewed by Michael Catanzaro.
1892
1893         Set always RGBA visual to the view widget when setting a background color.
1894
1895         * MiniBrowser/gtk/BrowserWindow.c:
1896         (browser_window_set_background_color):
1897
1898 2016-07-20  Youenn Fablet  <youenn@apple.com>
1899
1900         Bots should run built-ins generator tests
1901         https://bugs.webkit.org/show_bug.cgi?id=159971
1902
1903         Reviewed by Alexey Proskuryakov.
1904
1905         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1906         (RunBuiltinsTests): New step to run built-in generator tests.
1907         (TestFactory.__init__): Adding an additional step for bultin generator tests.
1908         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
1909         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
1910
1911 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1912
1913         Revert temporary fix r203417
1914         https://bugs.webkit.org/show_bug.cgi?id=160001
1915
1916         Reviewed by Alexey Proskuryakov.
1917
1918         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
1919
1920 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1921
1922         REGRESSION(r148588): ews classes might get garbage collected
1923         https://bugs.webkit.org/show_bug.cgi?id=159990
1924
1925         Reviewed by Ryosuke Niwa.
1926
1927         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
1928         in a variable so that they do not get garbage collected.
1929
1930 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
1931
1932         Add API test for layout constraints after exit fullscreen
1933         https://bugs.webkit.org/show_bug.cgi?id=159900
1934
1935         Reviewed by Jon Lee.
1936
1937         Added Fullscreen.LaytoutConstraints API test. 
1938         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
1939
1940         This test compares layout constraints on the web view before and after fullscreen to make sure 
1941         they are preserved.
1942
1943         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
1944         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
1945         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1946         (TestWebKitAPI::TEST):
1947
1948 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
1949
1950         Disable two failing API tests.
1951
1952         Unreviewed test gardening.
1953
1954         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
1955         (TestWebKitAPI::TEST):
1956
1957 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1958
1959         Unreviewed iOS build fix.
1960
1961         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
1962
1963 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1964
1965         Media controls don't appear when pausing a small autoplaying video
1966         https://bugs.webkit.org/show_bug.cgi?id=159972
1967         <rdar://problem/27180657>
1968
1969         Reviewed by Beth Dakin.
1970
1971         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
1972         for simulating basic user interaction in VideoControlsManager.
1973
1974         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1975         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1976         (-[WKWebView mouseDownAtPoint:]):
1977         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
1978         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
1979         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
1980         (TestWebKitAPI::TEST):
1981         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
1982
1983 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
1984
1985         [Win] MathML fonts are not found.
1986         https://bugs.webkit.org/show_bug.cgi?id=159920
1987
1988         Reviewed by Alex Christensen.
1989
1990         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
1991         for a specific registry key value.
1992
1993         * Scripts/webkitdirs.pm:
1994         (fontExists):
1995
1996 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
1997
1998         Improve prepare-ChangeLog for @media blocks
1999         https://bugs.webkit.org/show_bug.cgi?id=159907
2000
2001         Reviewed by Timothy Hatcher.
2002
2003         * Scripts/prepare-ChangeLog:
2004         (get_selector_line_ranges_for_css):
2005         Get a range for @media blocks just like a selector.
2006             Start Line = line with '{'
2007             End line = line with '}'
2008             Name = "@media ..."
2009
2010         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2011         Improved error messages for unbalanced portions.
2012
2013         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2014         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2015         (.media-query::before):
2016         (@media only screen and (max-width: 980px)):
2017         (.media-query a):
2018         (@media (-webkit-min-device-pixel-ratio: 2)):
2019         (.both a):
2020         (.both b):
2021         (.media-query b):
2022         (.media-query::after):
2023
2024 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2025
2026         Fix expectedFailErrorHandler in run-jsc-stress-tests
2027         https://bugs.webkit.org/show_bug.cgi?id=159811
2028
2029         Reviewed by Yusuke Suzuki.
2030
2031         * Scripts/run-jsc-stress-tests:
2032
2033 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2034
2035         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2036
2037         * TestWebKitAPI/PlatformMac.cmake:
2038
2039 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2040
2041         The default testing mode should not involve disabling the FTL JIT
2042         https://bugs.webkit.org/show_bug.cgi?id=159929
2043
2044         Rubber stamped by Mark Lam and Saam Barati.
2045         
2046         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2047         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2048         FTL was not the default. You had to enable it with an option.
2049         
2050         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2051         all of the major ports. This has become a serious pain. For example, it's useful to be able
2052         to say that a test should only run in the default config that is representative of what a
2053         normal user would see if they ran JSC. Clearly, this would be a config that does not
2054         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2055         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2056         
2057         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2058         try to fix it, because:
2059         
2060         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2061           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2062           doesn't do anything. The code is not really structured to allow this.
2063         
2064         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2065           disabled in testing. On the other hand there are already build bots that do FTL tests
2066           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2067           preserving this broken feature, we should create something that (a) acknowledges the fact
2068           that the FTL is the default on those platforms that support it and (b) avoids running
2069           no-ftl tests on precisely those platforms that don't have FTL.
2070         
2071         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2072           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2073           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2074           pretending that the FTL JIT is not the default just because some bots used that as an
2075           optimization.
2076         
2077         This change allows me to speed up some debug tests and paint some bots green.
2078
2079         * Scripts/run-javascriptcore-tests:
2080         (runJSCStressTests):
2081         * Scripts/run-jsc-stress-tests:
2082
2083 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2084
2085         Fix API test after r203426.
2086         https://bugs.webkit.org/show_bug.cgi?id=159949
2087
2088         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2089         (TEST):
2090         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2091         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2092
2093 2016-07-19  Andy Estes  <aestes@apple.com>
2094
2095         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2096         https://bugs.webkit.org/show_bug.cgi?id=159956
2097
2098         Reviewed by Dan Bernstein.
2099
2100         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2101         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2102         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2103         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2104
2105 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2106
2107         Add regression test for r203392
2108         https://bugs.webkit.org/show_bug.cgi?id=159949
2109
2110         Reviewed by Brady Eidson.
2111
2112         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2113         (fileSize):
2114         (swizzledBundleIdentifierWebBookmarksD):
2115         (defaultApplicationCacheDirectory):
2116         (TEST):
2117         (swizzledBundleIdentifierMobileSafari): Deleted.
2118         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2119         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2120         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2121
2122 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2123
2124         Add regression test for r203392
2125         https://bugs.webkit.org/show_bug.cgi?id=159949
2126
2127         Reviewed by Brady Eidson.
2128
2129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2130         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2131         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2132         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2133         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2134         (TEST):
2135         (fileSize):
2136         (swizzledBundleIdentifierMobileSafari):
2137         (swizzledBundleIdentifierWebBookmarksD):
2138         (defaultApplicationCacheDirectory):
2139         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2140         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2141         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2142         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2143
2144 2016-07-19  Keith Miller  <keith_miller@apple.com>
2145
2146         Test262 should have a file with the revision and url
2147         https://bugs.webkit.org/show_bug.cgi?id=159937
2148
2149         Reviewed by Mark Lam.
2150
2151         The import script should update the information from
2152         the path to the test262 repository it gets.
2153
2154         * Scripts/import-test262-tests:
2155
2156 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2157
2158         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2159         To be deleted once the root cause is found and addressed.
2160
2161         * EWSTools/start-queue-mac.sh:
2162
2163 2016-07-19  Frederic Wang  <fwang@igalia.com>
2164
2165         [win] Fixup the register name for STIX Math and Latin Modern Math
2166
2167         Unreviewed follow-up of r203406
2168
2169         * Scripts/webkitdirs.pm:
2170         (checkInstalledTools):
2171
2172 2016-07-19  Frederic Wang  <fwang@igalia.com>
2173
2174         [win] Update the list of MathML fonts
2175         https://bugs.webkit.org/show_bug.cgi?id=156838
2176
2177         The set of recommended math fonts is now described at
2178         https://trac.webkit.org/wiki/MathML/Fonts
2179         We update the Perl script to use the latest list of fonts.
2180
2181         Reviewed by Brent Fulgham.
2182
2183         * Scripts/webkitdirs.pm:
2184         (checkInstalledTools):
2185
2186 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2187
2188         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2189         https://bugs.webkit.org/show_bug.cgi?id=159342
2190
2191         Reviewed by Darin Adler.
2192
2193         Implement required functions in event sender.
2194
2195         * DumpRenderTree/PlatformWin.cmake:
2196         * DumpRenderTree/win/EventSender.cpp:
2197         (monitorWheelEvents): Added.
2198         (callAfterScrollingCompletes): Added.
2199
2200 2016-07-19  Youenn Fablet  <youenn@apple.com>
2201
2202         Add new aliases to http test server
2203         https://bugs.webkit.org/show_bug.cgi?id=159878
2204
2205         Reviewed by Darin Adler.
2206
2207         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2208         Adding explicitly these links to perl script.
2209         Extracting default alias in an aliases.json file.
2210         Reading that file from python scripts to initialize aliases from that file.
2211
2212         Python script changes covered by unit tests and changed layout test.
2213
2214         * Scripts/webkitperl/httpd.pm:
2215         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2216         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2217         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2218         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2219         Adding -c directives for each alias.
2220         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2221         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2222         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2223         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2224         Adding alias directive for each alias.
2225         (Lighttpd._prepare_config):
2226         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2227         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2228         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2229         layout tests directory.
2230         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2231         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2232         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2233
2234 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2235
2236         EWS console logs doesn't go to log file
2237         https://bugs.webkit.org/show_bug.cgi?id=159539
2238         <rdar://problem/24464570>
2239
2240         Reviewed by David Kilzer.
2241
2242         * Scripts/webkitpy/common/system/logutils.py:
2243         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2244         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2245         to filesystem. It also supports passing MockFilesystem.
2246         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2247         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2248         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2249         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2250         (_test_ews): Same.
2251         * Scripts/webkitpy/tool/commands/queues.py:
2252         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2253         (AbstractQueue._log_directory): Using filesystem object instead of os.
2254         (AbstractQueue.queue_log_path): Same.
2255         (AbstractQueue.__init__): Passed host parameter.
2256         (PatchProcessingQueue.__init__): Same.
2257         (CommitQueue.__init__): Same.
2258         (AbstractReviewQueue.__init__): Same.
2259         (StyleQueue.__init__): Same.
2260         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2261         (TestCommitQueue): Passed MockHost() as host.
2262         (TestCommitQueue.__init__): Same.
2263         (TestQueue.__init__): Same.
2264         (TestReviewQueue.__init__): Same.
2265         (TestFeederQueue.__init__): Same.
2266         (AbstractPatchQueueTest.test_next_patch): Same.
2267         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2268         (test_commit_queue_failure): Same.
2269         (MockCommitQueueTask.results_from_patch_test_run): Same.
2270         (test_rollout_lands): Same.
2271         (test_non_valid_patch): Same.
2272         (test_auto_retry): Same.
2273         (test_style_queue_with_watch_list_exception): Same.
2274
2275 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2276
2277         WTF::Lock should be fair eventually
2278         https://bugs.webkit.org/show_bug.cgi?id=159384
2279
2280         Reviewed by Geoffrey Garen.
2281
2282         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2283
2284 2016-07-17  Sam Weinig  <sam@webkit.org>
2285
2286         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2287         <rdar://problem/26554137>
2288         https://bugs.webkit.org/show_bug.cgi?id=159856
2289
2290         Reviewed by Dan Bernstein.
2291
2292         * MiniBrowser/mac/WK2BrowserWindowController.m:
2293         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2294         Add basic window.open implementation.
2295
2296         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2297         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2298         to open a single non-web URL, all others are dropped.
2299
2300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2301         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2302         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2303         Add API for the new SPI.
2304
2305 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2306
2307         [JSC] Enable test262 module tests
2308         https://bugs.webkit.org/show_bug.cgi?id=159854
2309
2310         Reviewed by Saam Barati.
2311
2312         Use --module-file instead.
2313
2314         * Scripts/run-jsc-stress-tests:
2315
2316 2016-07-16  Chris Dumez  <cdumez@apple.com>
2317
2318         Unreviewed, rolling out r203318.
2319
2320         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2321         SunSpider)
2322
2323         Reverted changeset:
2324
2325         "[JSC] Change some parameters based on a random search"
2326         https://bugs.webkit.org/show_bug.cgi?id=158514
2327         http://trac.webkit.org/changeset/203318
2328
2329 2016-07-16  Chris Dumez  <cdumez@apple.com>
2330
2331         Add move constructor / assignment operator to ListHashSet
2332         https://bugs.webkit.org/show_bug.cgi?id=159837
2333
2334         Reviewed by Darin Adler.
2335
2336         Add API tests.
2337
2338         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2339         (TestWebKitAPI::TEST):
2340
2341 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2342
2343         [JSC] Change some parameters based on a random search
2344         https://bugs.webkit.org/show_bug.cgi?id=158514
2345
2346         Reviewed by Saam Barati.
2347
2348         * Scripts/run-jsc-stress-tests:
2349
2350 2016-07-15  Jon Davis  <jond@apple.com>
2351
2352         Changed the start page URL for WebKit Nightly builds.
2353         https://bugs.webkit.org/show_bug.cgi?id=159816
2354
2355         Reviewed by Timothy Hatcher.
2356
2357         * WebKitLauncher/start.html:
2358
2359 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2360
2361         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2362         https://bugs.webkit.org/show_bug.cgi?id=159414
2363
2364         Reviewed by Brent Fulgham.
2365
2366         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2367         when the HDC parameter is invalid.
2368
2369         * TestWebKitAPI/PlatformWin.cmake:
2370         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2371         (TestWebKitAPI::TEST):
2372
2373 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2374
2375         [GTK] Add basic tabs support to MiniBrowser
2376         https://bugs.webkit.org/show_bug.cgi?id=159803
2377
2378         Reviewed by Sergio Villar Senin.
2379
2380         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2381         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2382
2383         * MiniBrowser/gtk/BrowserTab.c: Added.
2384         (titleChanged):
2385         (isLoadingChanged):
2386         (decidePolicy):
2387         (removeChildIfInfoBar):
2388         (loadChanged):
2389         (createInfoBarQuestionMessage):
2390         (tlsErrorsDialogResponse):
2391         (loadFailedWithTLSerrors):
2392         (permissionRequestDialogResponse):
2393         (decidePermissionRequest):
2394         (colorChooserRGBAChanged):
2395         (popoverColorClosed):
2396         (colorChooserRequestFinished):
2397         (runColorChooserCallback):
2398         (inspectorOpenedInWindow):
2399         (inspectorClosed):
2400         (browserTabSetProperty):
2401         (browserTabFinalize):
2402         (browser_tab_init):
2403         (browserTabConstructed):
2404         (browser_tab_class_init):
2405         (getInternalURI):
2406         (browser_tab_new):
2407         (browser_tab_get_web_view):
2408         (browser_tab_load_uri):
2409         (browser_tab_get_title_widget):
2410         (browser_tab_set_status_text):
2411         (browser_tab_toggle_inspector):
2412         (browser_tab_start_search):
2413         (browser_tab_stop_search):
2414         (browser_tab_add_accelerators):
2415         (fullScreenMessageTimeoutCallback):
2416         (browser_tab_enter_fullscreen):
2417         (browser_tab_leave_fullscreen):
2418         * MiniBrowser/gtk/BrowserTab.h: Added.
2419         * MiniBrowser/gtk/BrowserWindow.c:
2420         (getExternalURI):
2421         (browserWindowSetStatusText):
2422         (reloadOrStopCallback):
2423         (goBackCallback):
2424         (goForwardCallback):
2425         (settingsCallback):
2426         (webViewURIChanged):
2427         (browserWindowHistoryItemActivated):
2428         (browserWindowUpdateNavigationActions):
2429         (webViewCreate):
2430         (webViewEnterFullScreen):
2431         (webViewLeaveFullScreen):
2432         (webViewDecidePolicy):
2433         (browserWindowCanZoomIn):
2434         (browserWindowCanZoomOut):
2435         (browserWindowZoomIn):
2436         (browserWindowZoomOut):
2437         (scrollEventCallback):
2438         (faviconChanged):
2439         (webViewIsLoadingChanged):
2440         (defaultZoomCallback):
2441         (searchCallback):
2442         (newTabCallback):
2443         (toggleWebInspector):
2444         (reloadPage):
2445         (reloadPageIgnoringCache):
2446         (stopPageLoad):
2447         (loadHomePage):
2448         (editingCommandCallback):
2449         (insertImageCommandCallback):
2450         (insertLinkCommandCallback):
2451         (browserWindowSetupEditorToolbar):
2452         (browserWindowSwitchTab):
2453         (browserWindowTabAddedOrRemoved):
2454         (browser_window_init):
2455         (browserWindowConstructed):
2456         (browserWindowSaveSession):
2457         (browserWindowDeleteEvent):
2458         (browser_window_new):
2459         (browser_window_append_view):
2460         (browser_window_load_uri):
2461         (browser_window_load_session):
2462         (browser_window_set_background_color):
2463         (resetStatusText): Deleted.
2464         (activateUriEntryCallback): Deleted.
2465         (webViewTitleChanged): Deleted.
2466         (resetEntryProgress): Deleted.
2467         (browserWindowCreateBackForwardMenu): Deleted.
2468         (webViewReadyToShow): Deleted.
2469         (webViewLoadFailed): Deleted.
2470         (webViewMouseTargetChanged): Deleted.
2471         (browserWindowUpdateZoomActions): Deleted.
2472         (webViewZoomLevelChanged): Deleted.
2473         (updateUriEntryIcon): Deleted.
2474         (zoomInCallback): Deleted.
2475         (zoomOutCallback): Deleted.
2476         (toggleFullScreen): Deleted.
2477         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2478         (browserWindowFinalize): Deleted.
2479         (browser_window_class_init): Deleted.
2480         * MiniBrowser/gtk/BrowserWindow.h:
2481         * MiniBrowser/gtk/CMakeLists.txt:
2482         * MiniBrowser/gtk/main.c:
2483         (createBrowserTab):
2484         (aboutURISchemeRequestCallback):
2485         (main):
2486         (parseBackgroundColor): Deleted.
2487
2488 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2489
2490         Allow RefPtrs of const RefCounted types
2491         https://bugs.webkit.org/show_bug.cgi?id=158269
2492
2493         Reviewed by Anders Carlsson.
2494
2495         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2496         (TestWebKitAPI::TEST):
2497         (TestWebKitAPI::ConstRefCounted::create):
2498         (TestWebKitAPI::returnConstRefCountedRef):
2499         (TestWebKitAPI::returnRefCountedRef):
2500
2501 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2502
2503         Test WTF.StringViewIterators is crashing since r203119
2504         https://bugs.webkit.org/show_bug.cgi?id=159710
2505
2506         Reviewed by Darin Adler.
2507
2508         There are two problems in the test case added in r203119. First is that it's testing
2509         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2510         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2511         const reference to the string view member of the deleted CodePoints object.
2512
2513         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2514         (TestWebKitAPI::TEST):
2515
2516 2016-07-13  Daniel Bates  <dabates@apple.com>
2517
2518         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2519         https://bugs.webkit.org/show_bug.cgi?id=159738
2520         <rdar://problem/27304649>
2521
2522         Reviewed by Dan Bernstein.
2523
2524         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2525         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2526         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2527         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2528
2529         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2530         * WebKitTestRunner/ios/TestControllerIOS.mm:
2531         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2532         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2533
2534 2016-07-13  Beth Dakin  <bdakin@apple.com>
2535
2536         Attempted build fix.
2537
2538         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2539
2540 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2541
2542         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2543         https://bugs.webkit.org/show_bug.cgi?id=159686
2544
2545         Reviewed by Chris Dumez.
2546
2547         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2548
2549         * WebKitTestRunner/TestController.cpp:
2550         (WTR::runOpenPanel):
2551         (WTR::TestController::createOtherPage):
2552         (WTR::TestController::createWebViewWithOptions):
2553
2554 2016-07-13  Beth Dakin  <bdakin@apple.com>
2555
2556         Add more candidate tests
2557         https://bugs.webkit.org/show_bug.cgi?id=159730
2558
2559         Reviewed by Tim Horton.
2560
2561         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
2562         two new tests to that file.
2563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2564         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2565         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2566         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2567         (TestWebKitAPI::TEST):
2568         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2569
2570 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2571
2572         AX: [ATK] spinbutton-crash.html fails
2573         https://bugs.webkit.org/show_bug.cgi?id=159723
2574
2575         Reviewed by Chris Fleizach.
2576
2577         Implement support for AXDecrementButton and AXIncrementButton in
2578         ATK's AccessibilityUIElement::uiElementAttributeValue().
2579
2580         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2581         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2582
2583 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2584
2585         [EFL] [GTK] Enable back crypto subtle on development builds.
2586         https://bugs.webkit.org/show_bug.cgi?id=159260
2587
2588         Reviewed by Carlos Garcia Campos.
2589
2590         * Scripts/webkitperl/FeatureList.pm:
2591
2592 2016-07-12  Mark Lam  <mark.lam@apple.com>
2593
2594         We should use different stack limits for stack checks from JS and host code.
2595         https://bugs.webkit.org/show_bug.cgi?id=159442
2596         <rdar://problem/26889188>
2597
2598         Reviewed by Geoffrey Garen.
2599
2600         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2601         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
2602         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
2603         order to keep the js/regress-139548.html test happy with this patch.
2604
2605         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2606         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
2607
2608         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2609         (-[LTRelayController _environmentVariables]):
2610         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2611         (main):
2612
2613 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
2614
2615         platformUserPreferredLanguages on Mac should not try to put the region into the language
2616         https://bugs.webkit.org/show_bug.cgi?id=159693
2617
2618         Rubber stamped by Alexey Proskuryakov.
2619         
2620         Revert the test change in r200105.
2621
2622         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2623         (TestWebKitAPI::languageForSystemLanguage):
2624
2625 2016-07-12  Chris Dumez  <cdumez@apple.com>
2626
2627         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2628         https://bugs.webkit.org/show_bug.cgi?id=159663
2629         <rdar://problem/18995873>
2630
2631         Reviewed by Benjamin Poulain.
2632
2633         Add API test coverage.
2634
2635         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2636         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2637         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2638         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2639         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2640         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2641         (TEST):
2642
2643 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
2644
2645         Relax ordering requirements on StringView::CodePoints iterator
2646         https://bugs.webkit.org/show_bug.cgi?id=159609
2647
2648         Reviewed by Darin Adler.
2649
2650         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2651         (TestWebKitAPI::TEST):
2652
2653 2016-07-12  Youenn Fablet  <youenn@apple.com>
2654
2655         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
2656         https://bugs.webkit.org/show_bug.cgi?id=159564
2657
2658         Reviewed by Brian Burg.
2659
2660         * Scripts/webkitpy/codegen/main.py:
2661         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
2662
2663 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2664
2665         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2666         https://bugs.webkit.org/show_bug.cgi?id=159671
2667
2668         Reviewed by Csaba Osztrogonác.
2669
2670         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2671         https://bugs.webkit.org/show_bug.cgi?id=89235
2672
2673         So this guard can be removed in build scripts.
2674
2675         * Scripts/webkitperl/FeatureList.pm:
2676         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2677
2678 2016-07-11  Jason Marcell  <jmarcell@apple.com>
2679
2680         SVN.create_patch should find svn-create-patch relative to the WebKit root.
2681         https://bugs.webkit.org/show_bug.cgi?id=159652
2682
2683         Reviewed by Daniel Bates.
2684
2685         * Scripts/webkitpy/common/checkout/scm/svn.py:
2686         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
2687
2688 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2689
2690         Implement grapheme cluster iterator on StringView
2691         https://bugs.webkit.org/show_bug.cgi?id=159598
2692
2693         Reviewed by Anders Carlsson.
2694
2695         This is in preparation for honoring the second argument to FontFaceSet.load().
2696
2697         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2698         (TestWebKitAPI::compareLoopIterations):
2699         (TestWebKitAPI::TEST):
2700
2701 2016-07-11  Nan Wang  <n_wang@apple.com>
2702
2703         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
2704         https://bugs.webkit.org/show_bug.cgi?id=158364
2705
2706         Reviewed by Anders Carlsson.
2707
2708         Added a function in TestRunner so that we can toggle the ignoring viewport
2709         scale limits setting. Also added a test option for that in order to change the 
2710         configuration of the webview in test.
2711
2712         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2713         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2714         (WTR::TestRunner::setNavigationGesturesEnabled):
2715         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2716         (WTR::nextUIScriptCallbackID):
2717         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2718         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2719         * WebKitTestRunner/TestController.cpp:
2720         (WTR::TestController::resetStateToConsistentValues):
2721         (WTR::updateTestOptionsFromTestHeader):
2722         (WTR::TestController::setNavigationGesturesEnabled):
2723         (WTR::TestController::setIgnoresViewportScaleLimits):
2724         (WTR::TestController::platformWillRunTest):
2725         * WebKitTestRunner/TestController.h:
2726         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2727         * WebKitTestRunner/TestInvocation.cpp:
2728         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2729         * WebKitTestRunner/TestOptions.h:
2730         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2731         (WTR::TestController::platformCreateWebView):
2732
2733 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
2734
2735         [GTK] install-dependencies should not install packages built by jhbuild.
2736         https://bugs.webkit.org/show_bug.cgi?id=159628
2737
2738         Reviewed by Michael Catanzaro.
2739
2740         * gtk/install-dependencies:
2741         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
2742
2743 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
2744
2745         System proxy settings not used when building deps with jhbuild
2746         https://bugs.webkit.org/show_bug.cgi?id=159567
2747
2748         Reviewed by Michael Catanzaro.
2749
2750         This adds the gsettings-desktop-schemas-devel build dep to enable
2751         the libgiognomeproxy.so gio module in glib-networking, which uses
2752         GSettings on org.gnome.system.proxy.
2753         This is needed to query system proxy settings for Gnome desktops.
2754
2755         dconf can be manually added to jhbuild to build the
2756         libdconfsettings.so gio module for GSettings, so that
2757         libgiognomeproxy.so can access system settings.
2758           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
2759
2760         As an alternative to dconf settings, this commit also adds the
2761         libproxy-devel build dep to enable the libgiolibproxy.so module in
2762         glib-networking (suggested by Fujii Hironori).
2763
2764         It is useful to read proxy settings from environment variables.
2765         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
2766         environment variable to force using the envvar module in libproxy.
2767
2768         * gtk/install-dependencies:
2769
2770 2016-07-11  Mark Lam  <mark.lam@apple.com>
2771
2772         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
2773         https://bugs.webkit.org/show_bug.cgi?id=159524
2774
2775         Reviewed by Michael Saboff.
2776
2777         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
2778         Also fixed up some tests to behave better to work with this new limit.  This
2779         should make stack overflow tests complete sooner.
2780
2781         * Scripts/run-jsc-stress-tests:
2782         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2783         (main):
2784
2785 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2786
2787         [GTK] Whitespace fixes in install-dependencies script
2788
2789         Unreviewed.
2790
2791         * gtk/install-dependencies:
2792
2793 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2794
2795         [GTK] Install missing Fedora dependencies
2796
2797         Unreviewed.
2798
2799         * gtk/install-dependencies:
2800
2801 2016-07-09  Dan Bernstein  <mitz@apple.com>
2802
2803         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
2804         https://bugs.webkit.org/show_bug.cgi?id=159600
2805
2806         Reviewed by Daniel Bates.
2807
2808         * Scripts/git-add-reviewer:
2809         Added the -s|--rubber-stamp option.
2810         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
2811           new option.
2812
2813 2016-07-08  Andy Estes  <aestes@apple.com>
2814
2815         [Content Filtering] Load blocked pages more like other error pages are loaded
2816         https://bugs.webkit.org/show_bug.cgi?id=159485
2817         <rdar://problem/26014076>
2818
2819         Reviewed by Brady Eidson.
2820
2821         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2822         to a content filtering provisional navigation failure is ignored in preference of
2823         ContentFilter's own error page.
2824
2825         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2826         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2827         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2828         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2829         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2830         (loadAlternateTest):
2831         (TEST):
2832         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2833         (-[MockContentFilterEnabler initWithCoder:]):
2834         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2835         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2836         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2837         (TestWebKitAPI::loadAlternateTest):
2838         (TestWebKitAPI::TEST):
2839
2840 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2841
2842         Unreviewed, rolling out r202944.
2843         https://bugs.webkit.org/show_bug.cgi?id=159570
2844
2845         caused some tests to crash under GuardMalloc (Requested by
2846         estes on #webkit).
2847
2848         Reverted changeset:
2849
2850         "[Content Filtering] Load blocked pages more like other error
2851         pages are loaded"
2852         https://bugs.webkit.org/show_bug.cgi?id=159485
2853         http://trac.webkit.org/changeset/202944
2854
2855 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
2856
2857         Remove mrobinson from the MathML watchlist
2858         https://bugs.webkit.org/show_bug.cgi?id=159559
2859
2860         Reviewed by Philippe Normand.
2861
2862         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
2863
2864 2016-07-08  Brady Eidson  <beidson@apple.com>
2865
2866         Clearing LocalStorage doesn't also delete -wal and -shm files.
2867         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
2868
2869         Reviewed by Brent Fulgham.
2870         Also helpfully picked over by Andy "Never Forgets" Estes.
2871
2872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2873         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
2874         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
2875
2876 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
2877
2878         Removed Qt leftovers from Tools.
2879         https://bugs.webkit.org/show_bug.cgi?id=159557
2880
2881         Reviewed by Csaba Osztrogonác.
2882
2883         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2884         Removed 'qt' platform config.
2885         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2886         Deleted non-functional e-mail address.
2887
2888 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2889
2890         Unreviewed, rolling out r202967.
2891         https://bugs.webkit.org/show_bug.cgi?id=159556
2892
2893         This patch caused crashes in https tests on Windows (Requested
2894         by perarne on #webkit).
2895
2896         Reverted changeset:
2897
2898         "[Win] The test http/tests/security/contentSecurityPolicy
2899         /upgrade-insecure-requests/basic-upgrade.https.html is
2900         failing."
2901         https://bugs.webkit.org/show_bug.cgi?id=159510
2902         http://trac.webkit.org/changeset/202967
2903
2904 2016-07-08  Youenn Fablet  <youenn@apple.com>
2905
2906         Generate WebCore builtin wrapper files
2907         https://bugs.webkit.org/show_bug.cgi?id=159461
2908
2909         Reviewed by Brian Burg.
2910
2911         * Scripts/webkitpy/codegen/main.py:
2912         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
2913         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
2914
2915 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
2916
2917         [EFL] Fix build when media-stream is enabled.
2918         https://bugs.webkit.org/show_bug.cgi?id=159206
2919
2920         Bump up the openwebrtc to find the correct package.
2921
2922         Reviewed by Gyuyoung Kim.
2923
2924         * efl/jhbuild.modules:
2925         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
2926
2927 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2928
2929         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
2930         https://bugs.webkit.org/show_bug.cgi?id=159510
2931
2932         Reviewed by Brent Fulgham.
2933
2934         Allow any https certificate when running tests.
2935
2936         * DumpRenderTree/win/DumpRenderTree.cpp:
2937         (runTest):
2938
2939 2016-07-07  Beth Dakin  <bdakin@apple.com>
2940
2941         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
2942         https://bugs.webkit.org/show_bug.cgi?id=159532
2943         -and corresponding-
2944         rdar://problem/27177179
2945
2946         Reviewed by Tim Horton.
2947
2948         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
2949         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
2950
2951 2016-07-07  Andy Estes  <aestes@apple.com>
2952
2953         [Content Filtering] Load blocked pages more like other error pages are loaded
2954         https://bugs.webkit.org/show_bug.cgi?id=159485
2955         <rdar://problem/26014076>
2956
2957         Reviewed by Brady Eidson.
2958
2959         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2960         to a content filtering provisional navigation failure is ignored in preference of
2961         ContentFilter's own error page.
2962
2963         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2964         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2965         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2966         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2967         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2968         (loadAlternateTest):
2969         (TEST):
2970         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2971         (-[MockContentFilterEnabler initWithCoder:]):
2972         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2973         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2974         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2975         (TestWebKitAPI::loadAlternateTest):
2976         (TestWebKitAPI::TEST):
2977
2978 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2979
2980         Unreviewed: add myself to the reviewers list.
2981
2982         * Scripts/webkitpy/common/config/contributors.json:
2983
2984 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2985
2986         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
2987         https://bugs.webkit.org/show_bug.cgi?id=159509
2988
2989         Reviewed by Alex Christensen.
2990
2991         We should always insert the url in the url map when identifierForInitialRequest
2992         is called. Otherwise we can end up with identifiers not having an entry in the
2993         url map when urls are written to the test output file. 
2994
2995         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2996         (ResourceLoadDelegate::identifierForInitialRequest):
2997
2998 2016-07-06  Tim Horton  <timothy_horton@apple.com>
2999
3000         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3001         https://bugs.webkit.org/show_bug.cgi?id=159498
3002         <rdar://problem/26719903>
3003
3004         Reviewed by Sam Weinig.
3005
3006         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3007         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3008         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3009         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3010         (expectLinkCount):
3011         (TEST):
3012         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3013         when deciding what to linkify.
3014
3015 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3016
3017         Build fix - work around rdar://problem/27196668.
3018
3019         * LayoutTestRelay/Configurations/Base.xcconfig:
3020
3021 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3022
3023         Enhance Windows DRT implementation to support platform scroll wheel events.
3024         https://bugs.webkit.org/show_bug.cgi?id=36002
3025
3026         Reviewed by Brent Fulgham.
3027
3028         Implement function continuousMouseScrollBy in Windows event sender.
3029
3030         * DumpRenderTree/win/EventSender.cpp:
3031         (mouseScrollBy):
3032         (continuousMouseScrollBy):
3033
3034 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3035
3036         [Sierra] Rebaseline tests to use un-mocked system font metrics
3037         https://bugs.webkit.org/show_bug.cgi?id=159311
3038         <rdar://problem/24138411>
3039
3040         Reviewed in person by Alexey Proskuryakov.
3041
3042         Stop mocking the system font on Sierra.
3043
3044         * DumpRenderTree/mac/DumpRenderTree.mm:
3045         (setDefaultsToConsistentValuesForTesting):
3046         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3047         (WTR::InjectedBundle::platformInitialize):
3048
3049 2016-07-05  Brady Eidson  <beidson@apple.com>
3050
3051         Database process crashes deleting a corrupt SQLite database file (null deref).
3052         https://bugs.webkit.org/show_bug.cgi?id=155506.
3053
3054         Reviewed by Alex Christensen.
3055
3056         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3057         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3058         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3059         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3060         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3061         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3062
3063 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3064
3065         run-webkit-tests should print more complete baseline search paths
3066         https://bugs.webkit.org/show_bug.cgi?id=159354
3067
3068         Reviewed by Daniel Bates.
3069
3070         run-webkit-tests used to only print directory names in baseline search paths.
3071         This was ok in basic usage, but quickly got confusing when using
3072         --additional-platform-directory flags.
3073
3074         * Scripts/webkitpy/layout_tests/views/printing.py:
3075         (Printer.print_config):
3076         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3077         (Testprinter.test_print_config):
3078         (Testprinter.test_print_one_line_summary):
3079
3080 2016-07-04  Brady Eidson  <beidson@apple.com>
3081
3082         WebProcesses don't handle DatabaseProcess going away uncleanly..
3083         https://bugs.webkit.org/show_bug.cgi?id=159371
3084
3085         Reviewed by Alex Christensen.
3086
3087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3088         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3089         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3090         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3091         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3092
3093 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3094
3095         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3096         https://bugs.webkit.org/show_bug.cgi?id=158141
3097
3098         Rubber-stamped by Michael Catanzaro.
3099
3100         Instead of checking for an specific Ubuntu version, query the apt
3101         database to see which version of PHP is available.
3102
3103         * efl/install-dependencies:
3104         * gtk/install-dependencies:
3105
3106 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3107
3108         webkit-patch failure-reason always raises TypeError
3109         https://bugs.webkit.org/show_bug.cgi?id=159394
3110
3111         Reviewed by Benjamin Poulain.
3112
3113         In r170637 (Bug 133067), the first and second arguments of
3114         pluralize were swapped.
3115
3116         * Scripts/webkitpy/tool/commands/queries.py:
3117         (FailureReason._builder_to_explain): Swap the first and second
3118         arguments of pluralize.
3119
3120 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3121
3122         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3123         https://bugs.webkit.org/show_bug.cgi?id=152486
3124
3125         Reviewed by Daniel Bates.
3126
3127         Add launch of web-platform-tests server by run-webkit-httpd.
3128         Add two options to disable starting httpd and web-platform-tests servers.
3129
3130         * Scripts/run-webkit-httpd:
3131         (parse_args):
3132         (main):
3133
3134 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3135
3136         REGRESSION(r189668): Notification tests are flakey
3137         https://bugs.webkit.org/show_bug.cgi?id=159375
3138         <rdar://problem/22760990>
3139
3140         Reviewed by Alexey Proskuryakov.
3141
3142         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3143         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3144         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3145         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3146
3147         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3148         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3149         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3150         global notification ID mapping, causing the wrong notification to be investigated.
3151
3152         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3153         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3154         notification is created or destroyed. However, because this object is implemented outside WebKit,
3155         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3156         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3157         WebNotificationProvider can properly map between the different IDs.
3158
3159         * WebKitTestRunner/TestController.cpp:
3160         (WTR::TestController::runTestingServerLoop):
3161         (WTR::TestController::simulateWebNotificationClick):
3162         * WebKitTestRunner/WebNotificationProvider.cpp:
3163         (WTR::WebNotificationProvider::showWebNotification):
3164         (WTR::removeGlobalIDFromIDMap):
3165         (WTR::WebNotificationProvider::closeWebNotification):
3166         (WTR::WebNotificationProvider::removeNotificationManager):
3167         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3168         (WTR::WebNotificationProvider::reset):
3169         * WebKitTestRunner/WebNotificationProvider.h:
3170
3171 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3172
3173         Simplify LayoutTestRelay
3174         https://bugs.webkit.org/show_bug.cgi?id=159353
3175
3176         Reviewed by Daniel Bates.
3177
3178         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3179         by name and runtime makes no sense.
3180         2. Removed code to create devices, webkitpy always does this in advance.
3181         3. Don't create copies of testing apps - we can install the same one into
3182         each simulator, now that we don't run multiple tester processes in a single simulator.
3183         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3184         5. Removed code that kept testing apps alive in the background.
3185         6. Slightly updated coding style in functions that I touched.
3186
3187         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3188         Updated for what we acually use at this point.
3189
3190         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3191         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3192         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3193         (-[LTRelayController ipcIdentifier]):
3194         (-[LTRelayController processName]):
3195         (-[LTRelayController didReceiveStdoutData:]):
3196         (-[LTRelayController didCrashWithMessage:]):
3197         (-[LTRelayController installApp]):
3198         (-[LTRelayController _environmentVariables]):
3199         (-[LTRelayController launchApp]):
3200         (-[LTRelayController start]):
3201         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3202         (-[LTRelayController uniqueAppPath]): Deleted.
3203         (-[LTRelayController uniqueAppURL]): Deleted.
3204         (-[LTRelayController uniqueAppIdentifier]): Deleted.
3205         (-[LTRelayController createUniqueApp]): Deleted.
3206         * LayoutTestRelay/LayoutTestRelay/main.m:
3207         (usage):
3208         (getRequiredStringArgument):
3209         (main):
3210         (getTestingSimDevice): Deleted.
3211         * Scripts/webkitpy/port/driver.py:
3212         (IOSSimulatorDriver.cmd_line):
3213         * WebKitTestRunner/ios/TestControllerIOS.mm:
3214         (WTR::TestController::platformInitialize):
3215         * WebKitTestRunner/ios/mainIOS.mm:
3216         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3217         * DumpRenderTree/mac/DumpRenderTree.mm:
3218         (dumpRenderTree):
3219         (-[DumpRenderTree applicationDidEnterBackground:]):
3220
3221 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
3222
3223         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3224         https://bugs.webkit.org/show_bug.cgi?id=159344
3225
3226         Reviewed by Alex Christensen.
3227
3228         * DumpRenderTree/CMakeLists.txt:
3229
3230 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3231
3232         Add a runtime flag for DOM iterators
3233         https://bugs.webkit.org/show_bug.cgi?id=159300
3234
3235         Reviewed by Alex Christensen.
3236
3237         * DumpRenderTree/mac/DumpRenderTree.mm:
3238         (resetWebPreferencesToConsistentValues):
3239         * DumpRenderTree/win/DumpRenderTree.cpp:
3240         (resetWebPreferencesToConsistentValues):
3241         * Scripts/webkitperl/FeatureList.pm:
3242         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3243         (WTR::InjectedBundle::beginTesting):
3244         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3245         (WTR::TestRunner::setDOMIteratorEnabled):
3246         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3247
3248 2016-06-30  Tina Liu  <iting_liu@apple.com>
3249
3250         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3251         https://bugs.webkit.org/show_bug.cgi?id=159326
3252
3253         Reviewed by Brady Eidson.
3254
3255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3256         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3257         (TestWebKitAPI::didFinishLoadForFrame):
3258         (TestWebKitAPI::didChangeBackForwardListForPage):
3259         (TestWebKitAPI::setPageLoaderClient):
3260         Set the page loader client and register for didFinishLoadForFrame and
3261         didChangeBackForwardList callbacks.
3262         (TestWebKitAPI::createSessionStateData):
3263         Load a webpage ("simple.html") and return the session state for this page.
3264         (TestWebKitAPI::TEST):
3265         Restore the page session state with that of "simple.html" without navigation.
3266         Verify that the committed URL is NULL since there's no navigation involved.
3267         Verify that the current item in the back forward list, which should be what
3268         we restored from the session state, has the expected URL.
3269
3270 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
3271
3272         Generators violate bytecode liveness validation
3273         https://bugs.webkit.org/show_bug.cgi?id=159279
3274
3275         Reviewed by Yusuke Suzuki.
3276         
3277         Add Basic to our test harness.
3278
3279         * Scripts/run-javascriptcore-tests:
3280         (runJSCStressTests):
3281
3282 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
3283
3284         [Win][Debug] Assertion fails in TestWTF.
3285         https://bugs.webkit.org/show_bug.cgi?id=159299
3286
3287         Reviewed by Alex Christensen.
3288
3289         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3290         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3291         the assertion failure. Since the variable is actually used, there is no need to use the
3292         UNUSED_PARAM macro.
3293
3294         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3295         (TestWebKitAPI::TEST):
3296
3297 2016-06-30  Youenn Fablet  <youennf@gmail.com>
3298
3299         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
3300         https://bugs.webkit.org/show_bug.cgi?id=159166
3301         <rdar://problem/27051759>
3302
3303         Reviewed by Alexey Proskuryakov.
3304
3305         Setting the certificate directory to the copied config.json.
3306
3307         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3308         (WebPlatformTestServer._copy_webkit_test_files):
3309
3310 2016-06-29  Mark Lam  <mark.lam@apple.com>
3311
3312         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
3313         https://bugs.webkit.org/show_bug.cgi?id=159274
3314
3315         Reviewed by Keith Miller.
3316
3317         * DumpRenderTree/mac/DumpRenderTree.mm:
3318         (DumpRenderTreeMain):
3319
3320 2016-06-29  Alex Christensen  <achristensen@webkit.org>
3321
3322         WKWebView should ask WKNavigationDelegate about bad ssl certificates
3323         https://bugs.webkit.org/show_bug.cgi?id=159176
3324
3325         Reviewed by Sam Weinig.
3326
3327         * MiniBrowser/mac/WK2BrowserWindowController.m:
3328         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3329         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3330         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3331
3332 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3333
3334         [GTK] Add missing install dependency after r202619
3335         https://bugs.webkit.org/show_bug.cgi?id=156716
3336
3337         Unreviewed.
3338
3339         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3340
3341 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3342
3343         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3344         https://bugs.webkit.org/show_bug.cgi?id=156716
3345
3346         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3347
3348         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3349         (parse_args):
3350         * Scripts/webkitpy/port/gtk.py:
3351         (GtkPort.__init__):
3352         (GtkPort._driver_class):
3353         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3354         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3355         platform directory for storing the wayland specific layout test results and expectations for ${port}.
3356         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3357         test expectations file on the GTK port when running the tests with the --wayland command line switch.
3358         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3359         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3360         (WestonDriver.check_driver):
3361         (WestonDriver.__init__):
3362         (WestonDriver._start):
3363         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3364         (WestonXvfbDriverDisplayTest):
3365         (WestonXvfbDriverDisplayTest.__init__):
3366         (WestonXvfbDriverDisplayTest._xvfb_run):
3367         (WestonDriverTest.make_driver):
3368         (WestonDriverTest.test_start):
3369         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3370         or to satisfy the pkg-config check of the new added modules in JHBuild.
3371         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3372         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3373         provided by the system are already new enough.
3374         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3375         It was the only way to get the software EGL rasterizer working without depending on user drivers.
3376         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3377         feature to avoid building libdrm when the one provided by the system is new enough.
3378         * gtk/jhbuildrc:
3379         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
3380         Xorg had no support for searching the DRI drivers on a custom path at runtime.
3381         This patch implements support for that reusing the same variable that we use with Mesa to set the
3382         custom path for the DRI drivers path.
3383
3384 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
3385
3386         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
3387         https://bugs.webkit.org/show_bug.cgi?id=159256
3388
3389         Reviewed by Philippe Normand.
3390
3391         We need the last fixes in the repository to make the scream queue
3392         work with apprtc.
3393
3394         * gtk/jhbuild.modules:
3395
3396 2016-06-28  Commit Queue  <commit-queue@webkit.org>
3397
3398         Unreviewed, rolling out r202580.
3399         https://bugs.webkit.org/show_bug.cgi?id=159245
3400
3401         Caused all WKTR tests to fail on GuardMalloc and Production
3402         only for unknown reasons, investigating offline. (Requested by
3403         brrian on #webkit).
3404
3405         Reverted changeset:
3406
3407         "RunLoop::Timer should use constructor templates instead of
3408         class templates"
3409         https://bugs.webkit.org/show_bug.cgi?id=159153
3410         http://trac.webkit.org/changeset/202580
3411
3412 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3413
3414         Use a regex to check if a test step is for JavaScriptCore
3415         https://bugs.webkit.org/show_bug.cgi?id=159224
3416
3417         Reviewed by Geoffrey Garen.
3418
3419         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3420         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
3421         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3422         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
3423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3424         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
3425
3426 2016-06-28  Michael Saboff  <msaboff@apple.com>
3427
3428         btjs no longer accepts optional frame count argument
3429         https://bugs.webkit.org/show_bug.cgi?id=159235
3430
3431         Reviewed by Saam Barati.
3432
3433         Fix the detection of optional backtrace-depth parameter to use the length
3434         of the command.
3435
3436         * lldb/lldb_webkit.py:
3437         (btjs):
3438
3439 2016-06-28  Jon Lee  <jonlee@apple.com>
3440
3441         Update animometer.plan
3442
3443         Rubber-stamped by Said Abou-Hallawa.
3444
3445         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
3446
3447 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
3448
3449         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
3450
3451         * Scripts/run-javascriptcore-tests:
3452         (runJSCStressTests):
3453
3454 2016-06-28  Brian Burg  <bburg@apple.com>
3455
3456         RunLoop::Timer should use constructor templates instead of class templates
3457         https://bugs.webkit.org/show_bug.cgi?id=159153
3458
3459         Reviewed by Alex Christensen.
3460
3461         Remove the RunLoop::Timer class template argument, and pass its constructor
3462         a reference to `this` instead of a pointer to `this`.
3463
3464         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3465         (WTR::TestRunner::TestRunner):
3466         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3467         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3468         (TestWebKitAPI::TEST):
3469
3470 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3471
3472         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3473         https://bugs.webkit.org/show_bug.cgi?id=159199
3474
3475         Reviewed by Alexey Proskuryakov.
3476
3477         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
3478
3479         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3480         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3481         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
3482         an input element getting automatically focused on Mac.
3483
3484 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
3485
3486         [Win] Custom elements tests are failing.
3487         https://bugs.webkit.org/show_bug.cgi?id=159139
3488
3489         Reviewed by Alex Christensen.
3490
3491         Enable custom element API when running tests.
3492
3493         * DumpRenderTree/win/DumpRenderTree.cpp:
3494         (resetWebPreferencesToConsistentValues):
3495
3496 2016-06-27  Lucas Forschler  <lforschler@apple.com>
3497
3498         Test commit. Please ignore.
3499         
3500 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3501
3502         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
3503         https://bugs.webkit.org/show_bug.cgi?id=155073
3504
3505         Reviewed by Daniel Bates.
3506
3507         * Scripts/webkitperl/FeatureList.pm:
3508
3509 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
3510
3511         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3512         https://bugs.webkit.org/show_bug.cgi?id=159077
3513
3514         Reviewed by Tim Horton.
3515
3516         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
3517
3518         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
3519         which is necessary for UI-side compositing.
3520
3521         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
3522         seems to happen for some tests that call window.resizeTo().
3523
3524         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3525         (WTR::InjectedBundlePage::dump): Deleted.
3526         * WebKitTestRunner/TestInvocation.cpp:
3527         (WTR::TestInvocation::dumpResults):
3528         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3529         (WTR::createCGContextFromImage):
3530         (WTR::computeMD5HashStringForContext):
3531         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3532         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3533         (WTR::PlatformWebView::windowSnapshotImage):
3534
3535 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3536
3537         [EFL] Support to build on Debian linux
3538         https://bugs.webkit.org/show_bug.cgi?id=159123
3539
3540         Reviewed by Antonio Gomes.
3541
3542         * efl/install-dependencies: Install libgnutls28-dev.
3543
3544 2016-06-27  Alex Christensen  <achristensen@webkit.org>
3545
3546         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
3547         https://bugs.webkit.org/show_bug.cgi?id=159071
3548
3549         Reviewed by Brady Eidson.
3550
3551         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3552         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3553         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3554         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3555         (WTR::TestRunner::setAuthenticationUsername):
3556         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3557         * WebKitTestRunner/TestController.cpp:
3558         (WTR::TestController::TestController):
3559         (WTR::TestController::resetStateToConsistentValues):
3560         (WTR::TestController::didFinishNavigation):
3561         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3562         (WTR::TestController::didReceiveAuthenticationChallenge):
3563         (WTR::TestController::didCommitNavigation):
3564         * WebKitTestRunner/TestController.h:
3565         (WTR::TestController::setBlockAllPlugins):
3566         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3567         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
3568         (WTR::TestController::isCurrentInvocation):
3569         * WebKitTestRunner/TestInvocation.cpp:
3570         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3571         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
3572
3573 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
3574
3575         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
3576         https://bugs.webkit.org/show_bug.cgi?id=159129
3577
3578         Reviewed by Alex Christensen.
3579
3580         Implement the function mouseScrollBy in the Windows event sender.
3581
3582         * DumpRenderTree/win/EventSender.cpp:
3583         (mouseScrollBy):
3584         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3585
3586 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
3587
3588         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3589         https://bugs.webkit.org/show_bug.cgi?id=159104
3590
3591         Reviewed by Dan Bernstein.
3592         
3593         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
3594         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
3595
3596         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3597         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
3599
3600 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
3601
3602         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
3603         https://bugs.webkit.org/show_bug.cgi?id=159086
3604
3605         Reviewed by Alex Christensen.
3606
3607         Implement required wheel event function in event sender.
3608  
3609         * DumpRenderTree/win/EventSender.cpp:
3610         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3611
3612 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
3613
3614         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3615         https://bugs.webkit.org/show_bug.cgi?id=159104
3616
3617         Reviewed by Mark Lam.
3618         
3619         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
3620         WK.
3621
3622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3623
3624 2016-06-24  David Kilzer  <ddkilzer@apple.com>
3625
3626         parser_unittests.pl should not hardcode list of tests
3627         <https://webkit.org/b/159074>
3628
3629         Reviewed by Daniel Bates.
3630
3631         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3632         Update to read the list of tests from the 'resources' directory,
3633         and instead map file extensions to subroutine names.  Switch to
3634         use File::Basename::fileparse() to get basename and file
3635         extension for each test.
3636         (readTestFiles): Added.  Reads files from the directory passed
3637         in and ignores: hidden files, anything that isn't a plain file,
3638         and expected test results files.
3639
3640 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3641
3642         Fix Windows build.
3643
3644         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3645         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3646
3647 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3648
3649         [EFL] Change download path of libxslt
3650
3651         Unreviewed EFL build fix.
3652
3653         In Korea current download path can't be accessed. Change it.
3654
3655         * efl/jhbuild.modules:
3656
3657 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3658
3659         https://bugs.webkit.org/show_bug.cgi?id=159077
3660
3661         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
3662         snapshot the final state of the test in release builds. 
3663
3664         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3665         (WTR::InjectedBundlePage::dump):
3666
3667 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3668
3669         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
3670
3671         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3672         (createBitmapContextFromWebView):
3673         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3674         (WTR::PlatformWebView::windowSnapshotImage):
3675
3676 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3677
3678         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3679         https://bugs.webkit.org/show_bug.cgi?id=159077
3680
3681         Reviewed by Tim Horton.
3682
3683         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
3684         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
3685         thus enabling testing of more things.
3686
3687         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3688         (createBitmapContext): Moved to this file to share it.
3689         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3690         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3691         (createBitmapContextFromWebView):
3692         (BitmapContext::createFromUIImage): Deleted.
3693         (BitmapContext::pixelData): Deleted.
3694         (BitmapContext::BitmapContext): Deleted.
3695         (computeMD5HashStringForBitmapContext): Deleted.
3696         (dumpBitmap): Deleted.
3697         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
3698         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3699         (createPagedBitmapContext):
3700         (createBitmapContext): Deleted.
3701         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
3702         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3703         (WTR::InjectedBundlePage::dump): Deleted.
3704         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3705         (WTR::PlatformWebView::windowSnapshotImage):
3706
3707 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3708
3709         [jhbuild] Added libxslt module.
3710         https://bugs.webkit.org/show_bug.cgi?id=159034
3711
3712         Unreviewed, followup for r202373.
3713
3714         * efl/install-dependencies: Removed libxslt 
3715         * gtk/install-dependencies: Ditto.
3716
3717 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3718
3719         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
3720         https://bugs.webkit.org/show_bug.cgi?id=159050
3721
3722         Reviewed by Antonio Gomes.
3723
3724         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
3725
3726         * efl/jhbuild.modules:
3727         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3728         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3729
3730 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3731
3732         [jhbuild] Added libxslt module.
3733         https://bugs.webkit.org/show_bug.cgi?id=159034
3734
3735         Reviewed by Michael Catanzaro.
3736
3737         * efl/jhbuild.modules:
3738         * gtk/jhbuild.modules:
3739
3740 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3741
3742         [Win] Use Windows api function to find top level parent.
3743         https://bugs.webkit.org/show_bug.cgi?id=159021
3744
3745         Reviewed by Brent Fulgham.
3746
3747         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
3748  
3749         * DumpRenderTree/win/UIDelegate.cpp:
3750         (UIDelegate::runModal):
3751         (findTopLevelParent): Deleted.
3752         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3753         (PrintWebUIDelegate::runModal):
3754         (findTopLevelParent): Deleted.
3755
3756 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3757
3758         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
3759         https://bugs.webkit.org/show_bug.cgi?id=158934
3760
3761         Reviewed by Brent Fulgham.
3762
3763         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
3764
3765         * DumpRenderTree/win/TestRunnerWin.cpp:
3766         (TestRunner::clearAllDatabases):
3767
3768 2016-06-22  Saam Barati  <sbarati@apple.com>
3769
3770         run-javascriptcore-tests should have some environment variables for commonly used settings
3771         https://bugs.webkit.org/show_bug.cgi?id=159047
3772
3773         Reviewed by Keith Miller.
3774
3775         This patch adds three environment variables that run-javascriptcore-tests
3776         consults:
3777         - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
3778           determines if we should run the api tests or not.
3779         - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
3780           determines if we will perform a build or not before running the tests.
3781           to set the default should-build setting.
3782         - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
3783           a yaml file. If set, we will run the extra tests it refers to.
3784
3785         All the values in these environment variables will be overridden if an
3786         option is explicitly passed in. For example, the following will run
3787         the api tests:
3788         `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
3789
3790         * Scripts/run-javascriptcore-tests:
3791
3792 2016-06-22  Saam barati  <sbarati@apple.com>
3793
3794         TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
3795         https://bugs.webkit.org/show_bug.cgi?id=159037
3796         <rdar://problem/26935349>
3797
3798         Reviewed by Benjamin Poulain.
3799
3800         Run typeProfiler.yaml tests under an additional CJIT enabled mode.
3801
3802         * Scripts/run-jsc-stress-tests:
3803
3804 2016-06-22  Aakash Jain  <aakash_jain@apple.com>
3805
3806         Fix style issues in webkitpy
3807         https://bugs.webkit.org/show_bug.cgi?id=159019
3808
3809         Reviewed by Daniel Bates.
3810
3811         Fixed the formatting issues as reported by check-webkit-style in webkitpy.
3812         There is no functionality change.
3813         Only affected file names retained below for brevity.
3814
3815         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3816         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3817         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3818         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3819         * Scripts/webkitpy/benchmark_runner/utils.py:
3820         * Scripts/webkitpy/common/checkout/changelog.py:
3821         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3822         * Scripts/webkitpy/common/checkout/checkout.py:
3823         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3824         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3825         * Scripts/webkitpy/common/checkout/commitinfo.py:
3826         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3827         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3828         * Scripts/webkitpy/common/checkout/scm/scm.py:
3829         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3830         * Scripts/webkitpy/common/config/committers_unittest.py:
3831         * Scripts/webkitpy/common/config/irc.py:
3832         * Scripts/webkitpy/common/config/ports.py:
3833         * Scripts/webkitpy/common/config/ports_unittest.py:
3834         * Scripts/webkitpy/common/config/urls.py:
3835         * Scripts/webkitpy/common/host_mock.py:
3836         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3837         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3838         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3839         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3840         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3841         * Scripts/webkitpy/common/net/credentials_unittest.py:
3842         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
3843         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3844         * Scripts/webkitpy/common/net/statusserver.py:
3845         * Scripts/webkitpy/common/system/autoinstall.py:
3846         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3847         * Scripts/webkitpy/common/system/executive.py:
3848         * Scripts/webkitpy/common/system/executive_mock.py:
3849         * Scripts/webkitpy/common/system/executive_unittest.py:
3850         * Scripts/webkitpy/common/system/filesystem_mock.py:
3851         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3852         * Scripts/webkitpy/common/system/logutils_unittest.py:
3853         * Scripts/webkitpy/common/system/path.py:
3854         * Scripts/webkitpy/common/system/path_unittest.py:
3855         * Scripts/webkitpy/common/system/platforminfo.py:
3856         * Scripts/webkitpy/common/system/user.py:
3857         * Scripts/webkitpy/common/system/user_unittest.py:
3858         * Scripts/webkitpy/common/system/workspace_unittest.py:
3859         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
3860         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
3861         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3862         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3863         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3864         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3865         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3866         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3867         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3868         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3869         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3870         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3871         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3872         * Scripts/webkitpy/layout_tests/views/printing.py:
3873         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3874         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3875         * Scripts/webkitpy/port/base_unittest.py:
3876         * Scripts/webkitpy/port/driver.py:
3877         * Scripts/webkitpy/port/driver_unittest.py:
3878         * Scripts/webkitpy/port/factory.py:
3879         * Scripts/webkitpy/port/gtk.py:
3880         * Scripts/webkitpy/port/server_process_unittest.py:
3881         * Scripts/webkitpy/port/test.py:
3882         * Scripts/webkitpy/port/win.py:
3883         * Scripts/webkitpy/style/checker.py:
3884         * Scripts/webkitpy/style/checkers/common_unittest.py:
3885         * Scripts/webkitpy/style/checkers/cpp.py:
3886         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3887         * Scripts/webkitpy/style/checkers/js.py:
3888         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3889         * Scripts/webkitpy/style/checkers/png.py:
3890         * Scripts/webkitpy/style/checkers/text.py:
3891         * Scripts/webkitpy/style/checkers/text_unittest.py:
3892         * Scripts/webkitpy/style/error_handlers.py:
3893         * Scripts/webkitpy/style/filter.py:
3894         * Scripts/webkitpy/style/filter_unittest.py:
3895         * Scripts/webkitpy/style/optparser.py:
3896         * Scripts/webkitpy/style/optparser_unittest.py:
3897         * Scripts/webkitpy/test/main.py:
3898         * Scripts/webkitpy/w3c/test_converter.py:
3899         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3900         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3901         * Scripts/webkitpy/xcode/simulator.py:
3902
3903 2016-06-22  Brady Eidson  <beidson@apple.com>
3904
3905         DatabaseProcess doesn't handle WebProcesses going away uncleanly.
3906         https://bugs.webkit.org/show_bug.cgi?id=158894
3907
3908         Reviewed by Alex Christensen.
3909
3910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3911         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
3912         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
3913         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3914
3915 2016-06-22  Jon Lee  <jonlee@apple.com>
3916
3917         Update animometer.plan
3918         https://bugs.webkit.org/show_bug.cgi?id=159012
3919
3920         Reviewed by Ryosuke Niwa.
3921
3922         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
3923
3924 2016-06-22  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3925
3926         W3C test importer should generate files to ignore by WebKit SCM
3927         https://bugs.webkit.org/show_bug.cgi?id=142743
3928
3929         Reviewed by Darin Adler.
3930
3931         TestDownloader generates the .gitignore file according submodules git repository information.
3932         TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.
3933
3934         * Scripts/webkitpy/w3c/test_downloader.py:
3935         (TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
3936         * Scripts/webkitpy/w3c/test_importer.py:
3937         (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
3938         (TestImporter):
3939         (TestImporter.write_init_py): Writing not empty __init__.py files.
3940         (TestImporter.import_tests): Using  of write_init_py. 
3941         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3942         (TestImporterTest.test_git_ignore_generation): Added .gitignore test.
3943         (TestImporterTest):
3944         (TestImporterTest.test_initpy_generation): Added __init__.py test.
3945
3946 2016-06-21  Sam Weinig  <sam@webkit.org>
3947
3948         WKWebView with no WKNavigationDelegate does not follow universal links
3949         <rdar://problem/24374110>
3950         https://bugs.webkit.org/show_bug.cgi?id=158997
3951
3952         Reviewed by Dan Bernstein.
3953
3954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3955         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
3956         Add a new test that shows that we have a default navigation delegate by swizzling
3957         -[NSWorkspace openURL:]. This will only be called if there is a default client.
3958
3959 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3960
3961         [Win] Implement modal dialog support in MiniBrowser.
3962         https://bugs.webkit.org/show_bug.cgi?id=158976
3963
3964         Reviewed by Brent Fulgham.
3965
3966         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3967         (PrintWebUIDelegate::createWebViewWithRequest):
3968         (getHandleFromWebView):
3969         (PrintWebUIDelegate::webViewClose):
3970         (PrintWebUIDelegate::setFrame):
3971         (PrintWebUIDelegate::webViewFrame):
3972         (PrintWebUIDelegate::canRunModal):
3973         (findTopLevelParent):
3974         (PrintWebUIDelegate::runModal):
3975         (PrintWebUIDelegate::createModalDialog):
3976         * MiniBrowser/win/PrintWebUIDelegate.h:
3977         (PrintWebUIDelegate::webViewClose):
3978         (PrintWebUIDelegate::setFrame):
3979         (PrintWebUIDelegate::webViewFrame):
3980         (PrintWebUIDelegate::canRunModal):
3981         (PrintWebUIDelegate::runModal):
3982
3983 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3984
3985         window.showModalDialog doesn't work in DumpRenderTree on Windows
3986         https://bugs.webkit.org/show_bug.cgi?id=53675
3987
3988         Reviewed by Brent Fulgham.
3989
3990         Implement modal dialog support in DumpRenderTree.
3991
3992         * DumpRenderTree/win/UIDelegate.cpp:
3993         (UIDelegate::canRunModal):
3994         (getHandleFromWebView):
3995         (UIDelegate::createModalDialog):
3996         (findTopLevelParent):
3997         (UIDelegate::runModal):
3998         (UIDelegate::webViewClose):
3999         * DumpRenderTree/win/UIDelegate.h:
4000
4001 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
4002
4003         Fix formatting issues reported by check-webkit-style
4004         https://bugs.webkit.org/show_bug.cgi?id=159008
4005
4006         Reviewed by Alexey Proskuryakov.
4007
4008         Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
4009         There is no functionality change.
4010
4011         * Scripts/webkitpy/tool/bot/irc_command.py:
4012         (Restart.execute):
4013         (Rollout):
4014         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
4015         (IRCBotTest.test_exception_during_command):
4016         (IRCBotTest.test_exception_during_command.CommandWithException):
4017         (IRCBotTest.test_exception_during_command.CommandWithException.execute):
4018         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
4019         (test_missing_unit_test_results_path):
4020         (test_layout_test_results):
4021         * Scripts/webkitpy/tool/bot/queueengine.py:
4022         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
4023         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
4024         (AbstractSequencedCommand):
4025         (AbstractSequencedCommand.__init__):
4026         * Scripts/webkitpy/tool/commands/download.py:
4027         (Land):
4028         * Scripts/webkitpy/tool/commands/openbugs.py:
4029         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
4030         (OpenBugsTest):
4031         * Scripts/webkitpy/tool/commands/queries.py:
4032         (PatchesToCommitQueue):
4033         (PatchesToCommitQueue.__init__):
4034         (PatchesToCommitQueue._needs_commit_queue):
4035         * Scripts/webkitpy/tool/commands/queries_unittest.py:
4036         (PrintExpectationsTest.test_platform):
4037         (PrintBaselinesTest):
4038         (PrintBaselinesTest.setUp):
4039         * Scripts/webkitpy/tool/commands/queues.py:
4040         (AbstractQueue):
4041         (AbstractQueue.__init__):
4042         (AbstractQueue.execute):
4043         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4044         (test_auto_retry):
4045         * Scripts/webkitpy/tool/commands/rebaseline.py:
4046         (AbstractParallelRebaselineCommand._files_to_add):
4047         (AbstractParallelRebaselineCommand):
4048         (AbstractParallelRebaselineCommand._rebaseline):
4049         * Scripts/webkitpy/tool/commands/setupgitclone.py:
4050         (SetupGitClone):
4051         * Scripts/webkitpy/tool/commands/sheriffbot.py:
4052         * Scripts/webkitpy/tool/commands/stepsequence.py:
4053         * Scripts/webkitpy/tool/commands/upload.py:
4054         (PostCommits._comment_text_for_commit):
4055         (PostCommits):
4056         (PostCommits.execute):
4057         (MarkBugFixed):
4058         (MarkBugFixed.__init__):
4059         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4060         (UploadCommandsTest):
4061         (UploadCommandsTest.test_commit_message_for_current_diff):
4062         * Scripts/webkitpy/tool/grammar_unittest.py:
4063         (GrammarTest):
4064         (GrammarTest.test_join_with_separators):
4065         * Scripts/webkitpy/tool/multicommandtool.py:
4066         (HelpCommand.__init__):
4067         (HelpCommand):
4068         (HelpCommand._help_epilog):
4069         (HelpCommand._remove_help_options):
4070         (MultiCommandTool):
4071         (MultiCommandTool.__init__):
4072         (MultiCommandTool.main):
4073         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
4074         (TrivialCommand):
4075         (TrivialCommand.__init__):
4076         (MultiCommandToolTest):
4077         (MultiCommandToolTest._assert_tool_main_outputs):
4078         (MultiCommandToolTest.test_retry):
4079         (test_command_help):
4080         * Scripts/webkitpy/tool/steps/__init__.py:
4081         * Scripts/webkitpy/tool/steps/abstractstep.py:
4082         * Scripts/webkitpy/tool/steps/applypatch.py:
4083         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
4084         (ApplyPatchWithLocalCommit):
4085         (ApplyPatchWithLocalCommit.options):
4086         * Scripts/webkitpy/tool/steps/build.py:
4087         * Scripts/webkitpy/tool/steps/checkstyle.py:
4088         (CheckStyle):
4089         (CheckStyle.options):
4090         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4091         * Scripts/webkitpy/tool/steps/closebug.py:
4092         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
4093         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
4094         (CloseBugForLandDiffTest):
4095         (CloseBugForLandDiffTest.test_empty_state):
4096         * Scripts/webkitpy/tool/steps/closepatch.py:
4097         * Scripts/webkitpy/tool/steps/commit.py:
4098         (Commit.run):
4099         * Scripts/webkitpy/tool/steps/confirmdiff.py:
4100         * Scripts/webkitpy/tool/steps/editchangelog.py:
4101         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
4102         * Scripts/webkitpy/tool/steps/metastep.py:
4103         (MetaStep):
4104         (MetaStep.__init__):
4105         (MetaStep.run):
4106         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
4107         * Scripts/webkitpy/tool/steps/options.py:
4108         (Options):
4109         * Scripts/webkitpy/tool/steps/postdiff.py:
4110         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
4111         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
4112         * Scripts/webkitpy/tool/steps/preparechangelog.py:
4113         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
4114         (PrepareChangeLogTest):
4115         (PrepareChangeLogTest.test_resolve_existing_entry):
4116         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4117         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
4118         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
4119         * Scripts/webkitpy/tool/steps/revertrevision.py:
4120         * Scripts/webkitpy/tool/steps/runtests.py:
4121         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4122         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4123         (StepsTest):
4124         (StepsTest._step_options):
4125         * Scripts/webkitpy/tool/steps/update.py:
4126         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
4127         (UpdateChangeLogsWithReviewerTest):
4128         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
4129         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
4130         * Scripts/webkitpy/tool/steps/validatereviewer.py:
4131
4132 2016-06-21  Chris Dumez  <cdumez@apple.com>
4133
4134         Unreviewed, rolling out r202296.
4135
4136         Broke basic browsing in Safari
4137
4138         Reverted changeset:
4139
4140         "WKWebView with no WKNavigationDelegate does not follow
4141         universal links"
4142         https://bugs.webkit.org/show_bug.cgi?id=158997
4143         http://trac.webkit.org/changeset/202296
4144
4145 2016-06-21  Anders Carlsson  <andersca@apple.com>
4146
4147         Fix build.
4148
4149         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4150
4151 2016-06-21  Anders Carlsson  <andersca@apple.com>
4152
4153         Begin moving the Apple Pay code to the open source repository
4154         https://bugs.webkit.org/show_bug.cgi?id=158998
4155
4156         Reviewed by Tim Horton.
4157
4158         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4159         Add ENABLE_APPLE_PAY.
4160
4161 2016-06-21  Said Abou-Hallawa  <sabouhallawa@apple,com>
4162
4163         Add system tracing points for requestAnimationFrame() workflow
4164         https://bugs.webkit.org/show_bug.cgi?id=158723
4165
4166         Reviewed by Simon Fraser.
4167
4168         Add new plist entries to be used by kdebug_trace() viewing tools.
4169
4170         * Tracing/SystemTracePoints.plist:
4171
4172 2016-06-21  Sam Weinig  <sam@webkit.org>
4173
4174         WKWebView with no WKNavigationDelegate does not follow universal links
4175         <rdar://problem/24374110>
4176         https://bugs.webkit.org/show_bug.cgi?id=158997
4177
4178         Reviewed by Dan Bernstein.
4179
4180         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4181         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
4182         Add a new test that shows that we have a default navigation delegate by swizzling
4183         -[NSWorkspace openURL:]. This will only be called if there is a default client.
4184
4185 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
4186
4187         run-javascriptcore-tests should have flag to skip mozilla tests
4188         https://bugs.webkit.org/show_bug.cgi?id=158963
4189         rdar://problem/25838924
4190
4191         Reviewed by Alexey Proskuryakov.
4192
4193         * Scripts/run-javascriptcore-tests:
4194         (runJSCStressTests): Added flag to skip mozilla tests.
4195
4196 2016-06-20  Commit Queue  <commit-queue@webkit.org>
4197
4198         Unreviewed, rolling out r202136.
4199         https://bugs.webkit.org/show_bug.cgi?id=158932
4200
4201         JSBench wasn't regressed by r202002 and r202111 on iOS after
4202         all (Requested by rniwa_ on #webkit).
4203
4204         Reverted changeset:
4205
4206         "Unreviewed, rolling out r202002 and r202111."
4207         https://bugs.webkit.org/show_bug.cgi?id=158638
4208         http://trac.webkit.org/changeset/202136
4209
4210 2016-06-20  Keith Rollin  <krollin@apple.com>
4211
4212         Remove RefPtr::release() and change calls sites to use WTFMove()
4213         https://bugs.webkit.org/show_bug.cgi?id=158369
4214
4215         Reviewed by Chris Dumez.
4216
4217         RefPtr::release() releases its managed pointer awkwardly. It's more
4218         direct and clearer to use WTFMove to transfer ownership of the managed
4219         pointer.
4220
4221         As part of this cleanup, also change a lot of explicit data types to
4222         'auto'.
4223
4224         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
4225         (createBitmapContextFromWebView):
4226         (createPagedBitmapContext):
4227         * DumpRenderTree/mac/TestRunnerMac.mm:
4228         (TestRunner::setMockGeolocationPosition):
4229         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
4230         (TestWebKitAPI::TEST):
4231         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4232         (TestWebKitAPI::TEST):
4233
4234 2016-06-20  Tim Horton  <timothy_horton@apple.com>
4235
4236         Add a API test for *DeferringViewInWindowChanges as fixed in r202230
4237         https://bugs.webkit.org/show_bug.cgi?id=158947
4238
4239         Reviewed by Simon Fraser.
4240
4241         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4242         * TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Added.
4243         (TestWebKitAPI::didFinishLoadForFrame):
4244         (TestWebKitAPI::setPageLoaderClient):
4245         (TestWebKitAPI::TEST):
4246         Add a test ensuring that in-window state changes are deferred when using
4247         the SPI for deferring them, as fixed in r202230.
4248
4249 2016-06-20  Fujii Hironori  <Hironori.Fujii@sony.com>
4250
4251         WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE"
4252         https://bugs.webkit.org/show_bug.cgi?id=158931
4253
4254         Reviewed by Alexey Proskuryakov.
4255
4256         * WebKitTestRunner/TestInvocation.cpp:
4257         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Appended missing \n at the end of line.
4258
4259 2016-06-17  Alexey Proskuryakov  <ap@apple.com>
4260
4261         Add test expectations for macOS Sierra
4262         https://bugs.webkit.org/show_bug.cgi?id=158903
4263
4264         Reviewed by Alex Christensen.
4265
4266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png: Added.
4267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png: Added.
4268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4270         Added dashboard support.
4271
4272         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
4273         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
4274         Trigger the right build queues on check-in.
4275
4276         * Scripts/webkitpy/common/system/platforminfo.py:
4277         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
4278         * Scripts/webkitpy/layout_t