Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset...
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-09  Glenn Adams  <glenn@skynav.com>
2
3         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
4
5         Unreviewed.
6
7         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
8         (RunTest.test_build_check):
9
10 2013-04-09  Glenn Adams  <glenn@skynav.com>
11
12         [webkitpy] Remove chromium ports.
13         https://bugs.webkit.org/show_bug.cgi?id=114326
14
15         Reviewed by Dirk Pranke.
16
17         As a side effect, also:
18
19         - remove chromium builders from webkitpy.layout_tests.port.builders
20         - remove chromium builders from rebaseline
21         - rewrite chromium dependent tests in rebaseline_unittest
22         - remove chromium platform from garden-o-matic
23         - select apple platform as default platform in garden-o-matic
24         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
25
26         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
27         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
28         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
29         (BaselineOptimizerTest.test_move_baselines):
30         (BaselineOptimizerTest.test_efl):
31         (BaselineOptimizerTest.test_no_add_mac_future):
32         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
33         (BaselineOptimizerTest.test_common_directory_includes_root):
34         (BaselineOptimizerTest.test_complex_shadowing):
35         (BaselineOptimizerTest.test_virtual_ports_filtered):
36         * Scripts/webkitpy/layout_tests/port/builders.py:
37         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
38         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
39         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
40         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
41         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
42         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
43         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
44         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
45         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
46         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
47         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
48         * Scripts/webkitpy/layout_tests/port/factory.py:
49         (platform_options):
50         (PortFactory):
51         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
52         (FactoryTest.test_qt):
53         (FactoryTest.test_get_from_builder_name):
54         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
55         (RunTest.test_build_check):
56         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
57         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
58         * Scripts/webkitpy/tool/commands/rebaseline.py:
59         (Rebaseline._builders_to_pull_from):
60         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
61         (_BaseTestCase):
62         (_BaseTestCase.setUp):
63         (TestRebaselineTest.setUp):
64         (TestRebaselineTest.test_baseline_directory):
65         (test_rebaseline_updates_expectations_file):
66         (test_rebaseline_does_not_include_overrides):
67         (test_rebaseline_test):
68         (test_rebaseline_test_and_print_scm_changes):
69         (test_rebaseline_and_copy_test):
70         (test_rebaseline_and_copy_test_no_existing_result):
71         (test_rebaseline_and_copy_test_with_lion_result):
72         (test_rebaseline_and_copy_no_overwrite_test):
73         (TestRebaselineExpectations.test_rebaseline_expectations):
74
75 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
76
77         newcommitbot (WKR) requires a subversion checkout
78         https://bugs.webkit.org/show_bug.cgi?id=114309
79
80         Reviewed by Benjamin Poulain.
81
82         Directly talk to the subversion server instead of relying on a local checkout.
83         This allows us to run WKR off of a git clone.
84
85         * Scripts/webkitpy/tool/commands/newcommitbot.py:
86         (NewCommitBot.next_work_item):
87         (NewCommitBot.process_work_item):
88
89 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
90
91         webkitbot refers to sheriffbot in help
92         https://bugs.webkit.org/show_bug.cgi?id=114307
93
94         Reviewed by Benjamin Poulain.
95
96         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
97
98         * Scripts/webkitpy/tool/bot/irc_command.py:
99         (Help):
100         (Help.execute):
101         (RollChromiumDEPS.execute):
102         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
103         (IRCBotTest.test_help):
104         * Scripts/webkitpy/tool/bot/sheriff.py:
105         (Sheriff.name):
106
107 2013-04-06  Roger Fong  <roger_fong@apple.com>
108
109         Kill old processes between runs on WinEWS bots.
110         Temporarily disable tests to let bots catch up again.
111
112         * EWSTools/start-queue-win.sh:
113         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
114         (WinEWS):
115
116 2013-04-09  Glenn Adams  <glenn@skynav.com>
117
118         [webkitpy] Remove chromium deprecated port support.
119         https://bugs.webkit.org/show_bug.cgi?id=114228
120
121         Reviewed by Ryosuke Niwa.
122
123         * Scripts/webkitpy/common/config/ports.py:
124         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
125         (ChromiumPort): Removed.
126         (ChromiumAndroidPort): Removed.
127         (ChromiumXVFBPort): Removed.
128         * Scripts/webkitpy/common/config/ports_unittest.py:
129         (DeprecatedPortTest.test_chromium_port): Removed.
130         (DeprecatedPortTest.test_chromium_android_port): Removed.
131         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
132         * Scripts/webkitpy/tool/steps/update_unittest.py:
133         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
134         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
135
136 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
137
138         AX: The bounding paths should be made available through accessibility
139         https://bugs.webkit.org/show_bug.cgi?id=113817
140
141         Reviewed by David Kilzer.
142
143         Add a pathDescription property for testing so that it's possible
144         to verify that a path is being returned correctly.
145
146         * DumpRenderTree/AccessibilityUIElement.cpp:
147         (getPathDescriptionCallback):
148         (AccessibilityUIElement::pathDescription):
149         (AccessibilityUIElement::getJSClass):
150         * DumpRenderTree/AccessibilityUIElement.h:
151         (AccessibilityUIElement):
152         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
153         (_CGPathEnumerationIteration):
154         (AccessibilityUIElement::pathDescription):
155         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
156         (AccessibilityUIElement::pathDescription):
157         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
158         (WTR::AccessibilityUIElement::pathDescription):
159         (WTR):
160         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
161         (AccessibilityUIElement):
162         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
163         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
164         (WTR::AccessibilityUIElement::pathDescription):
165         (WTR):
166
167 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
168
169         [EFL] Declare TEST_THEME_DIR in a single place.
170         https://bugs.webkit.org/show_bug.cgi?id=114285
171
172         Reviewed by Anders Carlsson.
173
174         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
175
176         * DumpRenderTree/efl/CMakeLists.txt:
177         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
178         (DumpRenderTreeChrome::createView):
179         (DumpRenderTreeChrome::createInspectorView):
180         (DumpRenderTreeChrome::initialize):
181         (DumpRenderTreeChrome::onDownloadRequest):
182         * EWebLauncher/CMakeLists.txt:
183         * EWebLauncher/main.c:
184         (findThemePath):
185         * EWebLauncher/url_bar.c:
186         (url_bar_add):
187         * MiniBrowser/efl/CMakeLists.txt:
188         * MiniBrowser/efl/main.c:
189         (window_create):
190         * TestWebKitAPI/PlatformEfl.cmake:
191         * TestWebKitAPI/efl/PlatformWebView.cpp:
192         (TestWebKitAPI::PlatformWebView::PlatformWebView):
193         * WebKitTestRunner/PlatformEfl.cmake:
194         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
195         (WTR::PlatformWebView::PlatformWebView):
196
197 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
198
199         [GTK][AC] upversion of clutter and its dependecy
200         https://bugs.webkit.org/show_bug.cgi?id=114016
201
202         Reviewed by Gustavo Noronha Silva.
203
204         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
205
206         * gtk/jhbuild-optional.modules:
207
208 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
209
210         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
211         https://bugs.webkit.org/show_bug.cgi?id=89875
212
213         Reviewed by Maciej Stachowiak.
214
215         Add unit tests to verify if the handling of the open, openat, creat syscall
216         is being done right. We check if the Read/Write/ReadAndWrite permissions
217         are respected, if the canonical path is being resolved and if
218         the permissions are falling back to the topmost parent directory with a
219         policy set when the directory being opened has no policy.
220
221         We also test if any attempt of blocking SIGSYS is silently ignored.
222         SIGSYS cannot be blocked because in it's handler is where we hook
223         syscalls to the broker process.
224
225         Also added libseccomp to EFL's jhbuild to make the life of developers
226         willing to help easier.
227
228         * Scripts/webkitperl/FeatureList.pm:
229         * TestWebKitAPI/PlatformEfl.cmake:
230         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
231         (TestWebKitAPI):
232         (SeccompEnvironment):
233         (TestWebKitAPI::SeccompEnvironment::SetUp):
234         (TestWebKitAPI::SeccompEnvironment::TearDown):
235         (TestWebKitAPI::dummyHandler):
236         (TestWebKitAPI::TEST):
237         (TestWebKitAPI::stressTest):
238         * efl/jhbuild.modules:
239         * qmake/mkspecs/features/features.pri:
240
241 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
242
243         REGRESSION: Autocorrection doesn't work in DumpRenderTree
244         https://bugs.webkit.org/show_bug.cgi?id=113846
245
246         Reviewed by Alexey Proskuryakov.
247
248         The problem was that we were replacing NSSpellCheck's dictionary with our own
249         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
250
251         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
252         and "would" respectively in DumpRenderTree.
253
254         * DumpRenderTree/mac/DumpRenderTree.mm:
255         (resetDefaultsToConsistentValues):
256
257 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
258
259         Remove the gyp files for Tools
260         https://bugs.webkit.org/show_bug.cgi?id=114248
261
262         Reviewed by Ryosuke Niwa.
263
264         * DumpRenderTree/DumpRenderTree.gyp: Removed.
265         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
266         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
267         * DumpRenderTree/DumpRenderTree.gypi: Removed.
268         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
269         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
270         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
271         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
272
273 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
274
275         WKR (new-commit-bot) is too slow
276         https://bugs.webkit.org/show_bug.cgi?id=110087
277
278         Reviewed by Geoffrey Garen.
279
280         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
281         Just run "svn log -r <revision>" instead to cut down the delay.
282
283         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
284
285         * Scripts/webkitpy/tool/commands/newcommitbot.py:
286         (NewCommitBot):
287         (NewCommitBot.next_work_item):
288         (NewCommitBot._is_empty_log):
289         (NewCommitBot._update_checkout):
290
291 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
292
293         Build fix. Can't remove appendCustomBuildFlags.
294
295         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
296         (appendCustomBuildFlags):
297
298 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
299
300         Remove Chromium builders from build.webkit.org
301         https://bugs.webkit.org/show_bug.cgi?id=113990
302
303         Reviewed by Benjamin Poulain.
304
305         Removed.
306
307         * BuildSlaveSupport/build.webkit.org-config/config.json:
308         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
309         (InstallGtkDependencies):
310         (RunUnitTests.start):
311         (RunWebKit2Tests.start):
312         (Factory.__init__):
313         (unitTestsSupported):
314         (TestFactory.__init__):
315         (BuildAndTestFactory.__init__):
316         (BuildAndPerfTestFactory.__init__):
317         (BuildAndPerfTestWebKit2Factory.__init__):
318         (DownloadAndPerfTestFactory.__init__):
319         (loadBuilderConfig):
320         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
321
322 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
323
324         Remove HTML Notification
325         https://bugs.webkit.org/show_bug.cgi?id=114231
326
327         Reviewed by Ryosuke Niwa.
328
329         * qmake/mkspecs/features/features.pri:
330
331 2013-04-08  Glenn Adams  <glenn@skynav.com>
332
333         Remove chromium EWS support, and fix broken test.
334         https://bugs.webkit.org/show_bug.cgi?id=114221
335
336         Reviewed by Ryosuke Niwa.
337
338         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
339         (AbstractChromiumEWS): Removed.
340         (ChromiumLinuxEWS): Removed.
341         (ChromiumLinuxDebugEWS): Removed.
342         (ChromiumWindowsEWS): Removed.
343         (ChromiumAndroidEWS): Removed.
344         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
345         (EarlyWarningSystemTest): Fix misspelled class name.
346         (test_ewses): Fix entry point name to ensure test is run.
347
348 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
349
350         [WIN] Remove WebKit2 source code
351         https://bugs.webkit.org/show_bug.cgi?id=114096
352
353         Reviewed by Anders Carlsson.
354
355         Remove the windows specific parts of the MiniBrowser.
356
357         * MiniBrowser/MiniBrowser.vcproj: Removed.
358         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
359         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
360         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
361         * MiniBrowser/win/BrowserView.cpp: Removed.
362         * MiniBrowser/win/BrowserView.h: Removed.
363         * MiniBrowser/win/BrowserWindow.cpp: Removed.
364         * MiniBrowser/win/BrowserWindow.h: Removed.
365         * MiniBrowser/win/MiniBrowser.cpp: Removed.
366         * MiniBrowser/win/MiniBrowser.h: Removed.
367         * MiniBrowser/win/MiniBrowser.rc: Removed.
368         * MiniBrowser/win/main.cpp: Removed.
369         * MiniBrowser/win/resource.h: Removed.
370         * MiniBrowser/win/stdafx.cpp: Removed.
371         * MiniBrowser/win/stdafx.h: Removed.
372
373 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
374
375         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
376
377         * Scripts/webkitpy/common/config/irc.py:
378
379 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
380
381         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
382         https://bugs.webkit.org/show_bug.cgi?id=113139
383
384         Reviewed by Anders Carlsson.
385
386         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
387         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
388         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
389         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
390         (ToStringAndValueOfObject):
391         (ToStringAndValueOfObject::ToStringAndValueOfObject):
392         (ScriptableObject):
393         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
394         (ToStringAndValueOfObject::ScriptableObject::invoke):
395         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
396         (ToStringAndValueOfObject::NPP_GetValue):
397         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
398         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
399         * GNUmakefile.am:
400
401 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
402
403         [GTK] Bump gnome-themes-standard to 3.6.0
404         https://bugs.webkit.org/show_bug.cgi?id=114155
405
406         Reviewed by Martin Robinson.
407
408         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
409         dependency of gnome-themes-standard accordingly.
410
411 2013-04-08  David Levin  <levin@chromium.org>
412
413         Remove my watchlist entries.
414         https://bugs.webkit.org/show_bug.cgi?id=114180
415
416         Reviewed by Adam Barth.
417
418         * Scripts/webkitpy/common/config/committers.py:
419         * Scripts/webkitpy/common/config/watchlist:
420
421 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
422
423         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
424         https://bugs.webkit.org/show_bug.cgi?id=114161
425
426         Reviewed by Gyuyoung Kim.
427
428         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
429         as it is crashing due to Bug 111074.
430
431         * TestWebKitAPI/PlatformEfl.cmake:
432
433 2013-04-07  David Kilzer  <ddkilzer@apple.com>
434
435         Remove the rest of SVG_DOM_OBJC_BINDINGS
436         <http://webkit.org/b/114112>
437
438         Reviewed by Geoffrey Garen.
439
440         * Scripts/webkitperl/FeatureList.pm:
441         - Remove --svg-dom-objc-bindings switch.
442         * qmake/mkspecs/features/features.pri:
443         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
444
445 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
446
447         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
448         https://bugs.webkit.org/show_bug.cgi?id=114089
449
450         Reviewed by Chris Fleizach.
451
452         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
453         * DumpRenderTree/AccessibilityController.cpp:
454         * DumpRenderTree/AccessibilityUIElement.cpp:
455         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
456         (DumpRenderTreeChrome::DumpRenderTreeChrome):
457         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
458         (DumpRenderTreeChrome):
459
460 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
461
462         Build fix after r147857, remove remaining USE(JSC) guards.
463
464         Unreviewed.
465
466         * DumpRenderTree/config.h:
467         * TestWebKitAPI/config.h:
468         * WebKitTestRunner/config.h:
469
470 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
471
472         Rename sheriffbot to webkitbot
473         https://bugs.webkit.org/show_bug.cgi?id=114109
474
475         Reviewed by Benjamin Poulain.
476
477         Renamed since sheriffbot will be used in Blink.
478
479         * Scripts/webkitpy/tool/commands/sheriffbot.py:
480         (SheriffBot):
481         (SheriffBot.begin_work_queue):
482
483 2013-04-06  Oliver Hunt  <oliver@apple.com>
484
485         Unify the many and varied stack trace mechanisms, and make the result sane.
486         https://bugs.webkit.org/show_bug.cgi?id=114072
487
488         Reviewed by Filip Pizlo.
489
490         The commandline jsc executable no longer requires arguments, so
491         I've made run-jsc work without them.
492
493         * Scripts/run-jsc:
494
495 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
496
497         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
498         https://bugs.webkit.org/show_bug.cgi?id=114086
499
500         Reviewed by Tim Horton.
501
502         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
503
504 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
505
506         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
507         https://bugs.webkit.org/show_bug.cgi?id=114083
508
509         Reviewed by Ryosuke Niwa.
510
511         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
512         in TestWebKitAPI and WebKitTestRunner.
513
514         * TestWebKitAPI/config.h:
515         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
516         (TestWebKitAPI::InjectedBundleController::platformInitialize):
517         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
518         (WTR::InjectedBundle::platformInitialize):
519
520 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
521
522         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
523         https://bugs.webkit.org/show_bug.cgi?id=114094
524
525         Reviewed by Anders Carlsson.
526
527         * Scripts/run-jsc:
528
529 2013-04-05  Ojan Vafai  <ojan@chromium.org>
530
531         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
532         https://bugs.webkit.org/show_bug.cgi?id=114080
533
534         Reviewed by Ryosuke Niwa.
535
536         This way, the WebKit and Blink dashboard code can change as appropriate without
537         needing to consider the other project's needs. This still doesn't update the
538         buildbots to upload to the new location, or the dashboard code to pull the
539         results.json files from the new location, but it at least allows for changing the
540         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
541
542         * TestResultServer/app.yaml:
543
544 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
545
546         Re-enable testing on the commit queue
547         https://bugs.webkit.org/show_bug.cgi?id=114078
548
549         Reviewed by Darin Adler.
550
551         Re-enabled the feature and the associated tests.
552
553         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
554         (CommitQueueTask.run):
555         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
556         (CommitQueueTaskTest._run_through_task):
557         * Scripts/webkitpy/tool/commands/queues_unittest.py:
558         (CommitQueueTest._mock_test_result):
559
560 2013-04-05  Oliver Hunt  <oliver@apple.com>
561
562         Unify the many and varied stack trace mechanisms, and make the result sane.
563         https://bugs.webkit.org/show_bug.cgi?id=114072
564
565         Reviewed by Filip Pizlo.
566
567         The commandline jsc executable no longer requires arguments, so
568         I've made run-jsc work without them.
569
570         * Scripts/run-jsc:
571
572 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
573
574         AX: Make SVG Group containers accessible elements
575         https://bugs.webkit.org/show_bug.cgi?id=113939
576
577         Reviewed by Simon Fraser.
578
579         Implement axController.elementAtPoint for iOS.
580         Implement a correct version of clickPoint for iOS.
581
582         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
583         (AccessibilityController::elementAtPoint):
584         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
585         (AccessibilityUIElement::clickPointX):
586         (AccessibilityUIElement::clickPointY):
587
588 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
589
590         Unreviewed, rolling out r147773 and r147774.
591         http://trac.webkit.org/changeset/147773
592         http://trac.webkit.org/changeset/147774
593         https://bugs.webkit.org/show_bug.cgi?id=114056
594
595         Causing some exceptions on AppEngine I don't understand
596         (Requested by rniwa on #webkit).
597
598         * QueueStatusServer/config/queues.py:
599         * QueueStatusServer/model/queues.py:
600         (Queue.short_name):
601         (Queue.display_name):
602         * QueueStatusServer/model/queues_unittest.py:
603         (QueueTest.test_short_name):
604         (QueueTest.test_display_name):
605         (QueueTest.test_name_with_underscores):
606
607 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
608
609         Fixed run-bindings-tests by removing V8
610         https://bugs.webkit.org/show_bug.cgi?id=114053
611
612         Reviewed by Benjamin Poulain.
613
614         * Scripts/run-bindings-tests:
615         (main):
616
617 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
618
619         Build fix.
620
621         * QueueStatusServer/model/queues.py:
622         (Queue.short_name):
623         (Queue.display_name):
624
625 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
626
627         Remove Chromium EWS bots from the queue status server
628         https://bugs.webkit.org/show_bug.cgi?id=113988
629
630         Reviewed by Benjamin Poulain.
631
632         Removed Chromium EWS bots.
633
634         * QueueStatusServer/config/queues.py:
635         * QueueStatusServer/model/queues.py:
636         (Queue.short_name):
637         (Queue.display_name):
638         * QueueStatusServer/model/queues_unittest.py:
639         (QueueTest.test_short_name):
640         (QueueTest.test_display_name):
641         (QueueTest.test_name_with_underscores):
642
643 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
644
645         [EFL] Enable indexed database
646         https://bugs.webkit.org/show_bug.cgi?id=107248
647
648         Reviewed by Alexis Menard.
649
650         * Scripts/webkitperl/FeatureList.pm:
651
652 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
653
654         Remove vestiges of Chromium bits from watchlists.
655         https://bugs.webkit.org/show_bug.cgi?id=114047
656
657         Reviewed by Ryosuke Niwa.
658
659         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
660
661 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
662
663         Add James Craig to the contributors list.
664
665         * Scripts/webkitpy/common/config/committers.py:
666
667 2013-04-04  Kent Tamura  <tkent@chromium.org>
668
669         Remove ChromiumPublicApi pattern, and cc/message rules for it.
670
671         * Scripts/webkitpy/common/config/watchlist:
672
673 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
674
675         Temporarily disable the Python unittests broken by the commit queue not running layout tests
676         https://bugs.webkit.org/show_bug.cgi?id=113997
677
678         Reviewed by Ryosuke Niwa.
679
680         Disable the tests until Ryosuke gets the time and hardware to have
681         a testing commit-queue.
682
683         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
684         (CommitQueueTaskTest):
685         * Scripts/webkitpy/tool/commands/queues_unittest.py:
686         (CommitQueueTest):
687
688 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
689
690         Remove Chromium builders from build.webkit.org
691         https://bugs.webkit.org/show_bug.cgi?id=113990
692
693         Reviewed by Benjamin Poulain.
694
695         Land the part to disable triggering of Chromium builders first so that we may start
696         deleting more Chromium code that breaks the update step.
697
698         * BuildSlaveSupport/build.webkit.org-config/config.json:
699
700 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
701
702         Remove Chromium's DumpRenderTree
703         https://bugs.webkit.org/show_bug.cgi?id=113989
704
705         Reviewed by Kent Tamura.
706
707         On second thought, let's not go to Camelot. It is a silly place.
708
709         * DumpRenderTree/mac/DumpRenderTree.mm:
710         (resetDefaultsToConsistentValues):
711
712 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
713
714         Nixed the defunct chromium folder from DumpRenderTree
715         https://bugs.webkit.org/show_bug.cgi?id=113993
716
717         Reviewed by Ryosuke Niwa.
718
719         * DumpRenderTree/chromium: Removed.
720         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
721         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
722         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
723         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
724         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
725         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
726         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
727         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
728         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
729         * DumpRenderTree/chromium/MockPlatform.h: Removed.
730         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
731         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
732         * DumpRenderTree/chromium/Task.cpp: Removed.
733         * DumpRenderTree/chromium/Task.h: Removed.
734         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
735         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
736         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
737         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
738         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
739         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
740         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
741         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
742         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
743         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
744         * DumpRenderTree/chromium/TestRunner: Removed.
745         * DumpRenderTree/chromium/TestRunner/public: Removed.
746         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
747         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
748         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
749         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
750         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
751         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
752         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
753         * DumpRenderTree/chromium/TestRunner/src: Removed.
754         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
755         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
756         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
757         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
758         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
759         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
760         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
761         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
762         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
763         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
764         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
765         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
766         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
767         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
768         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
769         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
770         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
771         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
772         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
773         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
774         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
775         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
776         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
777         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
778         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
779         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
780         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
781         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
782         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
783         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
784         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
785         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
786         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
787         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
788         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
789         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
790         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
791         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
792         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
793         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
794         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
795         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
796         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
797         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
798         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
799         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
800         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
801         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
802         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
803         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
804         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
805         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
806         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
807         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
808         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
809         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
810         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
811         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
812         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
813         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
814         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
815         * DumpRenderTree/chromium/TestShell.cpp: Removed.
816         * DumpRenderTree/chromium/TestShell.h: Removed.
817         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
818         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
819         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
820         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
821         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
822         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
823         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
824         * DumpRenderTree/chromium/WebViewHost.h: Removed.
825         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
826         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
827         * DumpRenderTree/chromium/config.h: Removed.
828         * DumpRenderTree/chromium/fonts.conf: Removed.
829
830 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
831
832         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
833
834         Rubber stamped by Benjamin Poulain.
835
836         * RebaselineQueueServer: Removed.
837         * RebaselineQueueServer/app.yaml: Removed.
838         * RebaselineQueueServer/handlers: Removed.
839         * RebaselineQueueServer/handlers/__init__.py: Removed.
840         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
841         * RebaselineQueueServer/handlers/pages.py: Removed.
842         * RebaselineQueueServer/index.yaml: Removed.
843         * RebaselineQueueServer/main.py: Removed.
844         * RebaselineQueueServer/model: Removed.
845         * RebaselineQueueServer/model/__init__.py: Removed.
846         * RebaselineQueueServer/model/queueentry.py: Removed.
847         * RebaselineQueueServer/static: Removed.
848         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
849         * RebaselineQueueServer/static/styles.css: Removed.
850         * RebaselineQueueServer/templates: Removed.
851         * RebaselineQueueServer/templates/builder-picker.html: Removed.
852         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
853         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
854         * RebaselineQueueServer/templates/home.html: Removed.
855
856 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
857
858         Fix setup-commit-queue and temporarily disable testing on commit-queue
859         https://bugs.webkit.org/show_bug.cgi?id=113979
860
861         Reviewed by Benjamin Poulain.
862
863         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
864         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
865
866         * EWSTools/setup-commit-queue.sh:
867         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
868         (CommitQueueTask.run):
869
870 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
871
872         temporarily make flakiness dashboard work again webkit.org bots
873         https://bugs.webkit.org/show_bug.cgi?id=113972
874
875         Reviewed by Ojan Vafai.
876
877         This patch disables the chromium.org layout test bots TestExpectations
878         parsing temporarily until we can work out the right way to split into
879         two instances for webkit.org and chromium.org and figure out which
880         code to delete where :).
881
882         * TestResultServer/static-dashboards/flakiness_dashboard.js:
883
884 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
885
886         Fix webkitpy tests after r147678.
887
888         * Scripts/webkitpy/tool/commands/queues_unittest.py:
889         (CommitQueueTest.test_commit_queue):
890         (test_manual_reject_during_processing):
891
892 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
893
894         The commit queue should use Mac MountainLion port
895         https://bugs.webkit.org/show_bug.cgi?id=113971
896
897         Reviewed by Lucas Forschler.
898
899         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
900         * Scripts/webkitpy/tool/commands/queues.py:
901         (CommitQueue):
902
903 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
904
905         turn off running tests on chromium linux EWS bots
906         https://bugs.webkit.org/show_bug.cgi?id=113959
907
908         Reviewed by Geoffrey Garen.
909
910         Now that the Chromium port is no longer being maintained
911         there's little point in running the tests. Soon we should
912         just shut this bot off altogether.
913
914         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
915         (ChromiumLinuxEWS):
916
917 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
918
919         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
920
921         * Scripts/webkitpy/common/config/watchlist:
922
923 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
924
925         Indentation fix to get webkit-patch working again after r147625
926
927         Unreviewed.
928
929         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
930         (MacEWS):
931         (MacWK2EWS):
932
933 2013-04-04  Lucas Forschler  <lforschler@apple.com>
934
935         Turn tests back on for Mac WK1/WK2 EWS.
936         
937         Unreviewed.
938         
939         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
940         (MacEWS):
941         (MacWK2EWS):
942
943 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
944
945         [GTK][WK2] MiniBrowser custom URI scheme support
946         https://bugs.webkit.org/show_bug.cgi?id=112419
947
948         Reviewed by Carlos Garcia Campos.
949
950         Add support for about URIs in MiniBrowser. An example about page is show
951         with URI "about:minibrowser", the rest of the cases it will show a
952         proper message explaining that the about page didn't exist.
953
954         Internally it uses "minibrowser-about" prefix instead of "about", but
955         from the user point of view it works with "about" prefix.
956
957         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
958         (getInternalURI): Method to convert URIs from "about" prefix to
959         "minibrowser-about".
960         (getExternalURI): Opposite method.
961         (webViewURIChanged): Use "about" prefix to show the URI to users.
962         (webViewEnterFullScreen): Ditto.
963         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
964         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
965         (aboutURISchemeRequestCallback): Callback to manage about calls.
966         (main): Register the URI scheme to manage about URIs.
967
968 2013-04-03  Roger Fong  <roger_fong@apple.com>
969
970         Re-enable WinEWS tests.
971
972         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
973         (WinEWS):
974
975 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
976
977         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
978         https://bugs.webkit.org/show_bug.cgi?id=113883
979
980         Reviewed by Martin Robinson.
981
982         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
983         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
984         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
985
986 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
987
988         [GTK] Include Pango in jhbuild-optional.modules
989         https://bugs.webkit.org/show_bug.cgi?id=113878
990
991         Reviewed by Martin Robinson.
992
993         Since r147547 Pango 1.32.0 is required. Including the module in the
994         JHBuild optional moduleset.
995
996         * gtk/jhbuild-optional.modules: Add Pango module.
997
998 2013-04-03  Zeno Albisser  <zeno@webkit.org>
999
1000         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1001         https://bugs.webkit.org/show_bug.cgi?id=113864
1002
1003         Moving setDefersLoading from TestRunnerQt to TestRunner
1004         requires access to the non-Qt TestRunner.
1005         As long as we instantiate both TestRunner and TestRunnerQt,
1006         we need a separate getter for the non-Qt TestRunner instance.
1007
1008         Reviewed by Simon Hausmann.
1009
1010         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1011         (WebPage::resetSettings):
1012         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1013         (DumpRenderTree::jscTestRunner):
1014         * DumpRenderTree/qt/TestRunnerQt.cpp:
1015         (TestRunner::setDefersLoading):
1016             Moving setDefersLoading from TestRunnerQt
1017             to TestRunner.
1018         * DumpRenderTree/qt/TestRunnerQt.h:
1019         (TestRunnerQt):
1020
1021 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1022
1023         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1024         https://bugs.webkit.org/show_bug.cgi?id=104779
1025
1026         Reviewed by Carlos Garcia Campos.
1027
1028         * Scripts/run-gtk-tests:
1029         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1030         passing in current trunk.
1031
1032 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1033
1034         Fix HAVE(QTTESTSUPPORT) logic
1035
1036         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1037         resulting in HAVE(QTTESTSUPPORT) never being true.
1038         Move that logic down in sanitizeFeatures.
1039
1040         Rubber-stamped by Tor Arne Vestbø.
1041
1042         * qmake/mkspecs/features/features.prf:
1043
1044 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1045
1046         [GTK] Bump required versions of some dependencies
1047         https://bugs.webkit.org/show_bug.cgi?id=113282
1048
1049         Reviewed by Martin Robinson.
1050
1051         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1052
1053 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1054
1055         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1056         https://bugs.webkit.org/show_bug.cgi?id=113809
1057
1058         Reviewed by Philippe Normand.
1059
1060         Newer Linux kernels have removed some deprecated macros from v4l2
1061         headers, causing gst-plugins-good's build to break. We don't need it
1062         right now, so just disable it.
1063
1064         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1065
1066 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1067
1068         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1069         https://bugs.webkit.org/show_bug.cgi?id=113535
1070
1071         Reviewed by Simon Hausmann.
1072
1073         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1074
1075         * qmake/mkspecs/features/features.prf:
1076
1077 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1078
1079         [Qt] Move logic of simple forwarding functions to TestRunner.
1080         https://bugs.webkit.org/show_bug.cgi?id=113863
1081
1082         Reviewed by Simon Hausmann.
1083
1084         * DumpRenderTree/qt/TestRunnerQt.cpp:
1085         (TestRunner::setTextDirection):
1086         (TestRunner::goBack):
1087         (TestRunner::evaluateScriptInIsolatedWorld):
1088         (TestRunner::addUserStyleSheet):
1089         * DumpRenderTree/qt/TestRunnerQt.h:
1090         (TestRunnerQt):
1091
1092 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1093
1094         [Qt] Disable media support using QuickTime if deployment target != SDK
1095
1096         We link to a single libWebKitSystemInterface static lib, so unless the
1097         deployment target matches the SDK let's not pretend like we'll be able
1098         to run on anything lower than the SDK version.
1099
1100         Reviewed by Simon Hausmann.
1101
1102         * qmake/mkspecs/features/features.prf:
1103
1104 2013-04-02  James Craig  <james@cookiecrook.com>
1105
1106         AXRoleDescripton for DL is "list"; should be "description list"
1107         https://bugs.webkit.org/show_bug.cgi?id=111665
1108
1109         Reviewed by Chris Fleizach.
1110
1111         Defining the role and description strings.
1112
1113         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1114
1115 2013-04-02  Roger Fong  <roger_fong@apple.com>
1116
1117         Unreviewed. Disable running tests on Win EWS queue.
1118
1119         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1120         (WinEWS):
1121
1122 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1123
1124         Disable running tests on the MAC WK2 EWS queue.
1125         
1126         Unreviewed.
1127         
1128         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1129         (MacWK2EWS):
1130
1131 2013-04-02  Julie Parent  <jparent@chromium.org>
1132
1133         Dashboard refactor: Move dashboard specific history related features to History.
1134         https://bugs.webkit.org/show_bug.cgi?id=113717
1135
1136         Reviewed by Ojan Vafai.
1137         
1138         Each dashboard now creates its own History object, with a custom
1139         configuration. This changes from just overriding global functions
1140         to passing in callbacks for generatePage, handleValidHashParameter,
1141         and handleQueryParameterChange. Same with passing in defaultStateValues
1142         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1143         variables.
1144         
1145         All functions related to these features are now (mostly) private
1146         function on History. 
1147         
1148         Loader no longer needs a loadingComplete callback, since it can just
1149         initialize the history object itself.
1150
1151         * TestResultServer/static-dashboards/aggregate_results.js:
1152         (handleValidHashParameter):
1153         * TestResultServer/static-dashboards/dashboard_base.js:
1154         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1155         (generatePage):
1156         (.switch.return):
1157         (handleQueryParameterChange):
1158         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1159         (resetGlobals):
1160         * TestResultServer/static-dashboards/history.js:
1161         (.):
1162         * TestResultServer/static-dashboards/loader.js:
1163         (.):
1164         * TestResultServer/static-dashboards/loader_unittests.js:
1165         * TestResultServer/static-dashboards/timeline_explorer.js:
1166         (generatePage):
1167         (initCurrentBuilderTestResults):
1168         * TestResultServer/static-dashboards/treemap.js:
1169         (generatePage):
1170         (.switch.return):
1171         (handleQueryParameterChange):
1172
1173 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1174
1175         Unreviewed, rolling out r147401.
1176         http://trac.webkit.org/changeset/147401
1177         https://bugs.webkit.org/show_bug.cgi?id=113767
1178
1179         The patch makes it extremely hard to set up the dependencies
1180         properly on the GTK builders (Requested by zdobersek on
1181         #webkit).
1182
1183         * gtk/jhbuild.modules:
1184
1185 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1186
1187         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1188         https://bugs.webkit.org/show_bug.cgi?id=113382
1189
1190         Reviewed by Gyuyoung Kim.
1191
1192         Do not show the empty tooltip box if the text is null.
1193
1194         * MiniBrowser/efl/main.c:
1195         (popup_menu_populate):
1196
1197 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1198
1199         [GTK] Bump required versions of some dependencies
1200         https://bugs.webkit.org/show_bug.cgi?id=113282
1201
1202         Reviewed by Martin Robinson.
1203
1204         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1205
1206 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1207
1208         Unreviewed, rolling out r147319.
1209         http://trac.webkit.org/changeset/147319
1210         https://bugs.webkit.org/show_bug.cgi?id=113707
1211
1212         The unit test is still failing on the buildbot (Requested by
1213         zdobersek on #webkit).
1214
1215         * Scripts/run-gtk-tests:
1216         (TestRunner):
1217
1218 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1219
1220         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1221         https://bugs.webkit.org/show_bug.cgi?id=104779
1222
1223         Reviewed by Carlos Garcia Campos.
1224
1225         * Scripts/run-gtk-tests:
1226         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1227         passing in current trunk.
1228
1229 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1230
1231         Unreviewed, rolling out r147289.
1232         http://trac.webkit.org/changeset/147289
1233         https://bugs.webkit.org/show_bug.cgi?id=113678
1234
1235         broke Win7 (dbg) build (Requested by shinyak|gardener on
1236         #webkit).
1237
1238         * DumpRenderTree/DumpRenderTree.gypi:
1239         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1240         (WebTestRunner):
1241         (WebUserMediaClientMock):
1242         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1243         (WebTestRunner::WebUserMediaClientMock::taskList):
1244         * Scripts/webkitpy/style/checkers/cpp.py:
1245         (check_function_definition):
1246
1247 2013-03-31  Adam Barth  <abarth@webkit.org>
1248
1249         configure-svn-config.sh fails
1250         https://codereview.chromium.org/13392007/
1251
1252         Reviewed by Eric Seidel.
1253
1254         This script was trying to use "svn checkout" to dowload a file from
1255         svn.webkit.org, but "svn checkout" only works with directories.
1256         Instead, we should use "svn export".
1257
1258         * EWSTools/configure-svn-config.sh:
1259
1260 2013-03-31  Wei Jia  <wjia@chromium.org>
1261
1262         Allow WebUserMediaClientMock to be used by client
1263         https://bugs.webkit.org/show_bug.cgi?id=113633
1264
1265         Reviewed by Adam Barth.
1266
1267         Export WebUserMediaClientMock.
1268         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1269
1270         * DumpRenderTree/DumpRenderTree.gypi:
1271         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1272         (WebUserMediaClientMock):
1273         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1274         * Scripts/webkitpy/style/checkers/cpp.py:
1275         (check_function_definition):
1276
1277 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1278
1279         Expose FeatureObserver data to WebKit clients
1280         https://bugs.webkit.org/show_bug.cgi?id=113613
1281
1282         Reviewed by Sam Weinig.
1283
1284         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1285         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1286
1287 2013-03-29  Greg Hughes  <ghughes@apple.com>
1288
1289         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1290         https://bugs.webkit.org/show_bug.cgi?id=112276
1291
1292         Reviewed by Chris Fleizach.
1293
1294         Added support to test accessibility search predicates with multiple keys.  
1295
1296         * DumpRenderTree/AccessibilityUIElement.cpp:
1297         (uiElementForSearchPredicateCallback):
1298         * DumpRenderTree/AccessibilityUIElement.h:
1299         (AccessibilityUIElement):
1300         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1301         (AccessibilityUIElement::uiElementForSearchPredicate):
1302         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1303         (AccessibilityUIElement::uiElementForSearchPredicate):
1304         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1305         (AccessibilityUIElement::uiElementForSearchPredicate):
1306         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1307         (AccessibilityUIElement::uiElementForSearchPredicate):
1308         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1309         (AccessibilityUIElement::uiElementForSearchPredicate):
1310         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1311         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1312         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1313         (AccessibilityUIElement):
1314         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1315         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1316         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1317         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1318         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1319
1320 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1321
1322         Fix a typo in r147147 to fix Mac EWS.
1323
1324         * Scripts/webkitpy/tool/commands/queues.py:
1325         (PatchProcessingQueue._new_port_name_from_old):
1326
1327 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1328
1329         [EFL] Build break with latest EFL libraries after r146265
1330         https://bugs.webkit.org/show_bug.cgi?id=113558
1331
1332         Unreviewed build fix.
1333
1334         * TestWebKitAPI/PlatformWebView.h:
1335         * WebKitTestRunner/PlatformWebView.h:
1336
1337 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1338
1339         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1340
1341         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1342         in libgcrypt build.
1343
1344 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1345
1346         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1347
1348         Unreviewed.
1349
1350         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1351         (MacEWS):
1352
1353 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1354
1355         Use the right OS name on Mac EWS instead of mac-future.
1356
1357         Rubber-stamped by Dirk Pranke.
1358
1359         * Scripts/webkitpy/tool/commands/queues.py:
1360         (PatchProcessingQueue._new_port_name_from_old):
1361         (PatchProcessingQueue.begin_work_queue):
1362         (PatchProcessingQueue._upload_results_archive_for_patch):
1363
1364 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1365
1366         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1367         https://bugs.webkit.org/show_bug.cgi?id=112546
1368
1369         Reviewed by Martin Robinson.
1370
1371         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1372         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1373
1374 2013-03-28  Ming Xie  <mxie@blackberry.com>
1375
1376         [BlackBerry] Committer Email Updates
1377         https://bugs.webkit.org/show_bug.cgi?id=113435
1378
1379         Reviewed by Rob Buis.
1380
1381         Add the @blackberry.com email address for all our BlackBerry
1382         WebKit committers. This is the first step for our email address
1383         migration.
1384
1385         * Scripts/webkitpy/common/config/committers.py:
1386
1387 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1388
1389         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1390         https://bugs.webkit.org/show_bug.cgi?id=113508
1391
1392         Reviewed by Martin Robinson.
1393
1394         Prevent the GStreamer plugin scanner to load system-wide
1395         plugins. Only the ones built in JHBuild should be loaded and used
1396         at runtime.
1397
1398         * efl/jhbuildrc:
1399         * gtk/jhbuildrc:
1400
1401 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1402
1403         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1404         https://bugs.webkit.org/show_bug.cgi?id=113386
1405
1406         Reviewed by Carlos Garcia Campos.
1407
1408         * Scripts/webkitdirs.pm:
1409         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1410         version to 3.0. Reflect this change so the builtDylibPathForName
1411         function doesn't fail to report the library as found.
1412
1413 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1414
1415         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1416         https://bugs.webkit.org/show_bug.cgi?id=113484
1417
1418         Unreviewed build fix.
1419
1420         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1421
1422         * TestWebKitAPI/CMakeLists.txt:
1423         * WebKitTestRunner/CMakeLists.txt:
1424
1425 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1426
1427         Revision for the internal jhbuild is too old
1428         https://bugs.webkit.org/show_bug.cgi?id=113324
1429
1430         Reviewed by Martin Robinson.
1431
1432         Update the minimum required version to a point where jhbuild won't
1433         fail installing packages when trying to remove a symlink to a directory.
1434
1435         * jhbuild/jhbuild-wrapper: Updated revision.
1436
1437 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1438
1439         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1440         https://bugs.webkit.org/show_bug.cgi?id=113203
1441
1442         Reviewed by Philippe Normand.
1443
1444         We build our libsoup without GNOME support. gst-plugins-good does separate
1445         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1446         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1447         build failures as the headers of those diverge. We do not use souphttpsrc, so
1448         disable it when building gst-plugins-good.
1449
1450         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1451
1452 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1453
1454         Build fix after r146852. Please another reference to the Lion leaks builder.
1455
1456         * BuildSlaveSupport/build.webkit.org-config/config.json:
1457
1458 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1459
1460         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1461         https://bugs.webkit.org/show_bug.cgi?id=113421
1462
1463         Reviewed by Dirk Pranke.
1464
1465         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1466         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1467         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1468         in the GTK-specific TestExpectations files.
1469
1470         To avoid this only enable the warnings only when not using WKTR.
1471
1472         * Scripts/webkitpy/layout_tests/port/gtk.py:
1473         (GtkPort.warn_if_bug_missing_in_test_expectations):
1474
1475 2013-03-27  Antti Koivisto  <antti@apple.com>
1476
1477         Fix Zalan's email.
1478
1479         * Scripts/webkitpy/common/config/committers.py:
1480
1481 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1482
1483         master.cfg cleanup
1484         https://bugs.webkit.org/show_bug.cgi?id=113195
1485
1486         Reviewed by Ryosuke Niwa.
1487
1488         * BuildSlaveSupport/build.webkit.org-config/config.json:
1489         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1490
1491 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1492
1493         master.cfg fine-tuning for Qt Mountain Lion Release bot
1494         https://bugs.webkit.org/show_bug.cgi?id=113191
1495
1496         Reviewed by Ryosuke Niwa.
1497
1498         * BuildSlaveSupport/build.webkit.org-config/config.json:
1499           - Rename the slave due to its location change.
1500           - Update the platform of the slave.
1501         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1502         (RunQtAPITests): Enable running WK2 API tests on Qt.
1503         (RunQtAPITests.start):
1504         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1505         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1506
1507 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1508
1509         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1510         https://bugs.webkit.org/show_bug.cgi?id=113403
1511
1512         Reviewed by Kenneth Rohde Christiansen.
1513
1514         As of Evas 1.7.5, when Wayland is detected on the system, support for
1515         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1516         The code, however, seems to depend on a few other flags which must be
1517         explicitly enabled.
1518
1519         If those additional GL-related options are passed, we end up
1520         having issues on the WebKit side, so disable Wayland support for
1521         now.
1522
1523         * efl/jhbuild.modules:
1524
1525 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1526
1527         Unreviewed, rolling out r146864.
1528         http://trac.webkit.org/changeset/146864
1529         https://bugs.webkit.org/show_bug.cgi?id=113391
1530
1531         causes crashes on Wk2 EFL release bot (Requested by drott on
1532         #webkit).
1533
1534         * Scripts/webkitperl/FeatureList.pm:
1535
1536 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1537
1538         [jhbuild] Correctly specify an alternate number of make jobs.
1539         https://bugs.webkit.org/show_bug.cgi?id=113396
1540
1541         Reviewed by Philippe Normand.
1542
1543         So far, we were using the `MAKEFLAGS' environment variable to pass the
1544         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1545         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1546
1547         We now behave more closely to the rest of the WebKit tools by first
1548         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1549         not set, just letting jhbuild itself figure out how many jobs to use.
1550
1551         * efl/jhbuildrc:
1552         * gtk/jhbuildrc:
1553
1554 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1555
1556         [Qt] Remove Qt specific WorkQueueItem definitions.
1557         https://bugs.webkit.org/show_bug.cgi?id=112891
1558
1559         This patch is preparation work for removing
1560         WorkQueue related code from TestRunnerQt and
1561         replacing it with generic TestRunner code.
1562
1563         Reviewed by Benjamin Poulain.
1564
1565         * DumpRenderTree/qt/TestRunnerQt.cpp:
1566         (TestRunnerQt::queueBackNavigation):
1567         (TestRunnerQt::queueForwardNavigation):
1568         (TestRunnerQt::queueLoadHTMLString):
1569         (TestRunnerQt::queueReload):
1570         (TestRunnerQt::queueLoadingScript):
1571         (TestRunnerQt::queueNonLoadingScript):
1572         (TestRunner::queueLoad):
1573         * DumpRenderTree/qt/TestRunnerQt.h:
1574         (TestRunnerQt):
1575         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1576         (LoadItem::invoke):
1577         (LoadHTMLStringItem::invoke):
1578         (LoadAlternateHTMLStringItem::invoke):
1579         (ReloadItem::invoke):
1580         (ScriptItem::invoke):
1581         (BackForwardItem::invoke):
1582         * DumpRenderTree/qt/WorkQueueItemQt.h:
1583         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1584         (LoadAlternateHTMLStringItem):
1585
1586 2013-03-26  Julie Parent  <jparent@chromium.org>
1587
1588         Flakiness dashboard: simplify logic around which tests to show.
1589         https://bugs.webkit.org/show_bug.cgi?id=113250
1590
1591         Reviewed by Ojan Vafai.
1592         
1593         The different filters for showing results are only used for layout
1594         tests, otherwise, we show everything.
1595         
1596         Change the defaults to false (what layout tests used), and only
1597         look at the values when viewing layout tests.
1598
1599         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1600         (htmlForTestsWithExpectationsButNoFailures):
1601         (shouldHideTest):
1602
1603 2013-03-26  Isaac Levy  <ilevy@google.com>
1604
1605         Update bots on test-results.appspot
1606         https://bugs.webkit.org/show_bug.cgi?id=113333
1607
1608         Reviewed by Ojan Vafai.
1609
1610         * TestResultServer/static-dashboards/builders.jsonp:
1611
1612 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1613
1614         Unreviewed GTK gardening.
1615
1616         * Scripts/run-gtk-tests:
1617         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1618
1619 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1620
1621         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1622         https://bugs.webkit.org/show_bug.cgi?id=113287
1623
1624         Reviewed by Jocelyn Turcotte.
1625
1626         * Scripts/run-qtwebkit-tests:
1627         (Options.__init__):
1628
1629 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1630
1631         [EFL] Enable IndexedDB by default
1632         https://bugs.webkit.org/show_bug.cgi?id=107248
1633
1634         Reviewed by Laszlo Gombos.
1635
1636         * Scripts/webkitperl/FeatureList.pm:
1637         Enable IndexedDB by default on EFL.
1638
1639 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1640
1641         Sheriffbot should explain rollout failures in a human readable form.
1642         https://bugs.webkit.org/show_bug.cgi?id=107092
1643
1644         Reviewed by Ryosuke Niwa.
1645
1646         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1647
1648         * Scripts/webkitpy/tool/bot/irc_command.py:
1649         (Rollout._check_diff_failure):
1650         (Rollout.execute):
1651         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1652         (IRCCommandTest.test_rollout):
1653
1654 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1655
1656         Unreviewed GTK gardening.
1657
1658         * Scripts/run-gtk-tests:
1659         (TestRunner): Skipping a failing unit test after r146518.
1660
1661 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1662
1663         Remove Lion leaks builder
1664         https://bugs.webkit.org/show_bug.cgi?id=113252
1665
1666         Reviewed by Andreas Kling.
1667
1668         Removed.
1669
1670         * BuildSlaveSupport/build.webkit.org-config/config.json:
1671
1672 2013-03-25  Kent Tamura  <tkent@chromium.org>
1673
1674         Rename ENABLE_INPUT_TYPE_DATETIME
1675         https://bugs.webkit.org/show_bug.cgi?id=113254
1676
1677         Reviewed by Kentaro Hara.
1678
1679         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1680         Actually I'd like to remove the code, but we shouldn't remove it yet
1681         because we shipped products with it on some platforms.
1682
1683         * Scripts/webkitperl/FeatureList.pm:
1684         * qmake/mkspecs/features/features.pri:
1685
1686 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1687
1688         Remove one more line that was intended to be removed in r146657.
1689
1690         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1691         (summarize_results):
1692
1693 2013-03-25  Roger Fong  <roger_fong@apple.com>
1694
1695         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1696         Re-enable WinEWS tests.
1697
1698         * Scripts/webkitpy/common/config/ports.py:
1699         (WinPort.run_bindings_tests_command):
1700         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1701         (WinEWS):
1702
1703 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1704
1705         Unreviewed, rolling out r146793.
1706         http://trac.webkit.org/changeset/146793
1707         https://bugs.webkit.org/show_bug.cgi?id=113248
1708
1709         Fix did not work (Requested by rfong on #webkit).
1710
1711         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1712         (WinEWS):
1713
1714 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1715
1716         REGRESSION(r146657): Test failures reported incorrectly
1717         https://bugs.webkit.org/show_bug.cgi?id=113223
1718
1719         Reviewed by Dirk Pranke.
1720
1721         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1722
1723         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1724         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1725
1726         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1727         (Manager.run):
1728
1729         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1730         (RunDetails.__init__):
1731         (summarize_results): Remove the line I intended to remove in r146657.
1732
1733         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1734         (logging_run): Return details instead of the exit code.
1735         (run_and_capture): Ditto.
1736
1737         (RunTest.test_full_results_html):
1738         (RunTest.test_hung_thread):
1739         (RunTest.test_no_tests_found):
1740         (RunTest.test_no_tests_found_2):
1741         (RunTest.test_repeat_each_iterations_num_tests):
1742         (RunTest.test_run_singly_actually_runs_tests):
1743         (RunTest.test_test_list):
1744         (RunTest.test_missing_and_unexpected_results):
1745         (RunTest.test_pixel_test_directories):
1746         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1747         (RunTest.test_crash_with_stderr):
1748         (RunTest.test_no_image_failure_with_image_diff):
1749         (RunTest.test_crash_log):
1750         (RunTest.test_exit_after_n_failures_upload):
1751         (RunTest.test_results_directory_absolute):
1752         (RunTest.test_results_directory_relative):
1753         (RunTest.test_retrying_and_flaky_tests):
1754         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1755         (RunTest.test_retrying_uses_retries_directory):
1756         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1757         (RunTest.test_output_diffs):
1758         (EndToEndTest.test_reftest_with_two_notrefs):
1759         (RebaselineTest.test_reset_results):
1760         (RebaselineTest.test_missing_results):
1761         (RebaselineTest.test_new_baseline):
1762
1763         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1764         (BuildBotPrinter.print_results):
1765         (BuildBotPrinter.print_unexpected_results):
1766         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1767         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1768
1769 2013-03-25  Julie Parent  <jparent@chromium.org>
1770
1771         Dashboard refactor: Move cross dashboard history related code into history.js.
1772         https://bugs.webkit.org/show_bug.cgi?id=113104
1773
1774         Reviewed by Ojan Vafai.
1775
1776         All functions relating to cross dashboard behavior move from being
1777         globals to methods on the history.History object. Names stay the same,
1778         except many are made private, ones that should have been constants now
1779         are, and the long standing TODO to change "currentState" to 
1780         dashboardSpecificState is done.
1781         
1782         We now create a global history object in dashboard_base, as an 
1783         intermediate measure.  Once the dashboard specific code is
1784         added to history, each DB will need to create its own, and this
1785         global will be eliminated.
1786         
1787         * TestResultServer/static-dashboards/aggregate_results.js:
1788         (handleValidHashParameter):
1789         (htmlForBuilder):
1790         (rawValuesHTML):
1791         * TestResultServer/static-dashboards/dashboard_base.js:
1792         (parseDashboardSpecificParameters):
1793         (defaultValue):
1794         (currentBuilderGroupCategory):
1795         (currentBuilderGroupName):
1796         (handleLocationChange):
1797         (expectationsMap):
1798         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1799         (generatePage):
1800         (.switch.return):
1801         (platformAndBuildType):
1802         (individualTests):
1803         (substringList):
1804         (processMissingAndExtraExpectations):
1805         (pathToFailureLog):
1806         (showPopupForBuild):
1807         (htmlForTestsWithExpectationsButNoFailures):
1808         (shouldHideTest):
1809         (isCrossBuilderView):
1810         (tableHeaders):
1811         (htmlForSingleTestRow):
1812         (htmlForTableColumnHeader):
1813         (generatePageForExpectationsUpdate):
1814         (handleUpdate):
1815         (nextUpdate):
1816         (setUpdateIndex):
1817         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1818         (.appendExpectationsItem):
1819         (loadExpectations):
1820         (.dummyNode.onload):
1821         (loadExpectationsLayoutTests):
1822         (appendExpectations):
1823         (htmlForNavBar):
1824         (checkBoxToToggleState):
1825         (linkHTMLToToggleState):
1826         (generatePageForBuilder):
1827         (isInvalidKeyForCrossBuilderView):
1828         (handleQueryParameterChange):
1829         (showLegend):
1830         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1831         (resetGlobals):
1832         (test):
1833         * TestResultServer/static-dashboards/history.js:
1834         (.):
1835         * TestResultServer/static-dashboards/history_unittests.js:
1836         * TestResultServer/static-dashboards/loader.js:
1837         (.):
1838         * TestResultServer/static-dashboards/loader_unittests.js:
1839         * TestResultServer/static-dashboards/timeline_explorer.js:
1840         (generatePage):
1841         (initCurrentBuilderTestResults):
1842         (selectBuild):
1843         (showResultsDelta):
1844         * TestResultServer/static-dashboards/treemap.js:
1845         (generatePage):
1846         (.switch.return):
1847         (handleFocus):
1848         * TestResultServer/static-dashboards/ui.js:
1849
1850 2013-03-25  Roger Fong  <roger_fong@apple.com>
1851
1852         Unreviewed. Enable WinEWS tests again.
1853
1854         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1855         (WinEWS):
1856
1857 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1858
1859         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1860         https://bugs.webkit.org/show_bug.cgi?id=112166
1861
1862         HarfBuzz 0.9.14 merged my patch for icu detection without
1863         pkg-config files, as needed by for example Ubuntu 12.04.
1864         This obsoletes our local workaround. Removed it for GTK and EFL.
1865
1866         Reviewed by Martin Robinson.
1867
1868         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1869         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1870         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1871         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1872
1873 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1874
1875         Unreviewed.  Move self from contributor to committer list.
1876
1877         * Scripts/webkitpy/common/config/committers.py:
1878
1879 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1880
1881         EWS should use a human readable port name when uploading layout test archives
1882         https://bugs.webkit.org/show_bug.cgi?id=113099
1883
1884         Reviewed by Dirk Pranke.
1885
1886         Use new port's object's name() method to report human readable port names.
1887         This will also help us resolving the bug to apply layout test results posted by EWS.
1888
1889         * Scripts/webkitpy/tool/bot/botinfo.py:
1890         (BotInfo.__init__): Take port's name.
1891         (BotInfo.summary_text):
1892
1893         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1894         (BotInfoTest.test_summary_text):
1895
1896         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1897         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1898
1899         * Scripts/webkitpy/tool/commands/queues.py:
1900         (PatchProcessingQueue.__init__): Initialize self._port.
1901         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1902         and use that for the attachment filename and the comment posted.
1903
1904         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1905         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1906         "mac-snowleopard" as expected for TestPort.
1907
1908 2013-03-22  Roger Fong  <roger_fong@apple.com>
1909
1910         Unreviewed. Turn off EWS test on Win again.
1911         The battle continues.
1912
1913         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1914         (WinEWS):
1915
1916 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1917
1918         NRWT: Enable pixel tests when retrying tests
1919         https://bugs.webkit.org/show_bug.cgi?id=112898
1920
1921         Reviewed by Dirk Pranke.
1922
1923         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1924         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1925         if we've forced pixel tests in the retry.
1926         (Manager._run_tests):
1927         (Manager._clean_up_run): Fixed the capitalizations.
1928         (Manager._force_pixel_tests_if_needed): Added.
1929
1930         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1931         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1932         'image_diff_percent' if it doesn't already exist.
1933
1934         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1935         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1936         treat this as a regular regression instead of a flakiness.
1937
1938         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1939         run had image diffs.
1940
1941         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1942         (summarized_results):
1943
1944         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1945         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1946         Also removed some dead code.
1947
1948         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1949         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1950         is set and pixel_tests_enabled is set to false.
1951         (EndToEndTest.test_reftest_with_two_notrefs):
1952
1953 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1954
1955         Make it possible to run layout tests on Retina MBP
1956         https://bugs.webkit.org/show_bug.cgi?id=93673
1957
1958         Reviewed by Ryosuke Niwa.
1959
1960         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1961         windows on 2x machines still run at 1x.
1962
1963         * DumpRenderTree/mac/DumpRenderTree.mm:
1964         (createWebViewAndOffscreenWindow):
1965         Reset the window resolution to 1x on creation.
1966         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
1967         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1968         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
1969         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1970         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
1971         (WTR::PlatformWebView::PlatformWebView):
1972         Add NSWindow details, reset the window resolution to 1x on creation.
1973
1974 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1975
1976         Leak bots shouldn't build
1977         https://bugs.webkit.org/show_bug.cgi?id=112774
1978
1979         Reviewed by Simon Fraser.
1980
1981         Since leak bots use regular debug builds, there is no need to build on these bots.
1982         Simply downloading builds will dramatically improve the cycle time of these bots.
1983
1984         * BuildSlaveSupport/build.webkit.org-config/config.json:
1985         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1986         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
1987         TestFactory instead of BuildAndTestFactory.
1988
1989 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1990
1991         [Qt] Fix the TestWebKitAPI build
1992         https://bugs.webkit.org/show_bug.cgi?id=113044
1993
1994         Reviewed by Tor Arne Vestbø.
1995
1996         The generate-forwarding-headers script would only be run
1997         after the targets in InjectedBundle.pri since the second
1998         addStrictSubdirOrderBetween call in
1999         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2000         the derived_sources -> injected_bundle order in SUBDIRS.
2001
2002         Fix it by only moving the dependent target at the end of
2003         SUBDIRS, don't touch its dependency.
2004
2005         * qmake/mkspecs/features/functions.prf:
2006
2007 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2008
2009         [EFL][WK2] View is not focused when fullscreen mode toggled
2010         https://bugs.webkit.org/show_bug.cgi?id=113009
2011
2012         Reviewed by Laszlo Gombos.
2013
2014         Set focus on view when fullscreen mode enabled/disabled
2015         by FullScreen API.
2016
2017         * MiniBrowser/efl/main.c:
2018         (on_fullscreen_accept):
2019         (on_fullscreen_deny):
2020
2021 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2022
2023         nrwt is no longer saving retry results in the retries/ subdirectory
2024         https://bugs.webkit.org/show_bug.cgi?id=112995
2025
2026         Reviewed by Ojan Vafai.
2027
2028         I think this has been broken a long time, unfortunately. This
2029         patch should fix that.
2030
2031         In order to do so, I had to pass the directory to use from
2032         the Worker object through the SingleTestWriter to the
2033         TestResultWriter. While I was plumbing that through, I rationalized
2034         the order of the parameter arguments a bit ...
2035
2036         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2037         (Worker._run_single_test):
2038         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2039         (run_single_test):
2040         (SingleTestRunner.__init__):
2041         (SingleTestRunner._run_compare_test):
2042         (SingleTestRunner._run_rebaseline):
2043         (SingleTestRunner._run_reftest):
2044         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2045         (write_test_result):
2046         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2047         (TestResultWriterTest.test_reftest_diff_image):
2048         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2049         (RunTest.test_retrying_uses_retries_directory):
2050
2051 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2052
2053         JSC profiler should have an at-a-glance report of the success of DFG optimization
2054         https://bugs.webkit.org/show_bug.cgi?id=112988
2055
2056         Reviewed by Geoffrey Garen.
2057
2058         * Scripts/display-profiler-output:
2059
2060 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2061
2062         [chromium] Linux ASAN WebKit canary is running out of memory
2063         https://bugs.webkit.org/show_bug.cgi?id=112978
2064
2065         Reviewed by Tony Chang.
2066
2067         Running the AddressSanitizer on a crash takes a lot of
2068         memory, so we should serialize access to it to avoid running
2069         out of memory on a machine.
2070
2071         * Scripts/webkitpy/layout_tests/port/chromium.py:
2072         (ChromiumPort._get_crash_log):
2073         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2074         (HttpLock.__init__):
2075         (HttpLock.wait_for_httpd_lock):
2076
2077 2013-03-21  Min Qin  <qinmin@chromium.org>
2078
2079         Cleanup android media layout test code
2080         https://bugs.webkit.org/show_bug.cgi?id=112944
2081
2082         Reviewed by Adam Barth.
2083
2084         Chromium change: https://codereview.chromium.org/12892010/
2085         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2086         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2087         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2088         Instead, we should switch to use content shell for layout tests.
2089
2090         * DumpRenderTree/chromium/TestShell.cpp:
2091         (TestShell::resetTestController):
2092
2093 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2094
2095         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2096         https://bugs.webkit.org/show_bug.cgi?id=112953
2097
2098         Reviewed by Tony Chang.
2099
2100         When I created the DumpRenderTree_resources target in r144863 I
2101         forgot to declare the needed dependencies on the other resource
2102         targets. Due to a quirk of ordering, this appears to have been fine
2103         w/ ninja but not w/ Xcode (which is still being used on the chromium
2104         mac valgrind bots). Declaring the dependencies fixes the build
2105         failures.
2106
2107         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2108
2109 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2110
2111         [WinCairo] Correct assert in Empty BitmapImage Test.
2112         https://bugs.webkit.org/show_bug.cgi?id=112934
2113
2114         Reviewed by Tim Horton.
2115
2116         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2117         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2118         to avoid ref counting assertion when leaving test scope.
2119
2120 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2121
2122         [GTK] generate-feature-defines-files is incompatible with Python3
2123         https://bugs.webkit.org/show_bug.cgi?id=112956
2124
2125         Reviewed by Martin Robinson.
2126
2127         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2128         method on the dictionary objects when iterating through said dictionaries.
2129
2130         * gtk/generate-feature-defines-files:
2131         (write_feature_defines_header):
2132         (write_flattened_feature_defines_file):
2133
2134 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2135
2136         kill-old-processes spits out error messages on Mac
2137         https://bugs.webkit.org/show_bug.cgi?id=112878
2138
2139         Reviewed by Jessie Berlin.
2140
2141         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2142         included in the list of options grep --help shows.
2143
2144         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2145
2146         * BuildSlaveSupport/kill-old-processes:
2147         (main):
2148
2149 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2150
2151         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2152         https://bugs.webkit.org/show_bug.cgi?id=112597
2153
2154         Reviewed by Xan Lopez.
2155
2156         These were introduced for the Chromium port in r105295. We need
2157         dummy implementations in order to compile the BlackBerry port.
2158
2159         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2160         (AccessibilityUIElement::scrollToMakeVisible):
2161         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2162         (AccessibilityUIElement::scrollToGlobalPoint):
2163
2164 2013-03-21  Roger Fong  <roger_fong@apple.com>
2165
2166         Re-enable WinEWS tests following r146376.
2167
2168         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2169         (WinEWS):
2170
2171 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2172
2173         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2174
2175         * Scripts/webkitpy/common/config/committers.py:
2176
2177 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2178
2179         [GTK] Missing atk in install-dependencies script
2180         https://bugs.webkit.org/show_bug.cgi?id=112272
2181
2182         Reviewed by Gustavo Noronha Silva.
2183
2184         * gtk/install-dependencies: Add missing atk dependency.
2185
2186 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2187
2188         [GTK] Missing backslash in install-dependencies script
2189         https://bugs.webkit.org/show_bug.cgi?id=112907
2190
2191         Reviewed by Philippe Normand.
2192
2193         * gtk/install-dependencies: Add missing backslash to dependencies
2194         list.
2195
2196 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2197
2198         EWS bots have stopped uploading results to bugzilla
2199         https://bugs.webkit.org/show_bug.cgi?id=101091
2200
2201         Reviewed by Adam Barth.
2202
2203         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2204         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2205         this relative file path resoled to a file inside a non-existent directory for "zip".
2206
2207         Fixed the bug by resolving both test results directory and zip archive paths in
2208         LayoutTestResultsReader.archive.
2209
2210         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2211         in the future.
2212
2213         * Scripts/webkitpy/common/system/filesystem_mock.py:
2214         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2215
2216         * Scripts/webkitpy/common/system/workspace.py:
2217         (Workspace.create_zip): Log the source path when "zip" failed.
2218
2219         * Scripts/webkitpy/common/system/workspace_mock.py:
2220         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2221
2222         * Scripts/webkitpy/common/system/workspace_unittest.py:
2223         (WorkspaceTest.test_create_zip_exception): Test that.
2224
2225         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2226         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2227         This is the actual bug fix.
2228
2229         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2230         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2231
2232 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2233
2234         [chromium] move WebThemeEngine implementations to TestRunner library
2235         https://bugs.webkit.org/show_bug.cgi?id=112751
2236
2237         Reviewed by Adam Barth.
2238
2239         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2240         * DumpRenderTree/DumpRenderTree.gypi:
2241         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2242         (WebKit):
2243         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2244         (WebTestRunner::TestInterfaces::themeEngine):
2245         (WebTestRunner):
2246         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2247         (WebKit):
2248         (TestInterfaces):
2249         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2250         (WebTestRunner::WebTestInterfaces::themeEngine):
2251         (WebTestRunner):
2252         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2253         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2254         (WebTestRunner):
2255         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2256         (WebTestRunner::WebTestThemeControlWin::box):
2257         (WebTestRunner::WebTestThemeControlWin::line):
2258         (WebTestRunner::WebTestThemeControlWin::triangle):
2259         (WebTestRunner::WebTestThemeControlWin::roundRect):
2260         (WebTestRunner::WebTestThemeControlWin::oval):
2261         (WebTestRunner::WebTestThemeControlWin::circle):
2262         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2263         (WebTestRunner::WebTestThemeControlWin::markState):
2264         (WebTestRunner::WebTestThemeControlWin::draw):
2265         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2266         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2267         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2268         (WebTestRunner):
2269         (WebTestThemeControlWin):
2270         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2271         (WebTestRunner):
2272         (WebTestThemeEngineMac):
2273         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2274         (+[FakeActiveWindow alwaysActiveWindow]):
2275         (+[FakeActiveWindow alwaysInactiveWindow]):
2276         (-[FakeActiveWindow initWithActiveControls:]):
2277         (-[FakeActiveWindow _hasActiveControls]):
2278         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2279         (WebTestRunner):
2280         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2281         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2282         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2283         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2284         (WebTestRunner):
2285         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2286         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2287         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2288         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2289         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2290         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2291         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2292         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2293         (WebTestRunner::WebTestThemeEngineWin::getSize):
2294         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2295         (WebTestRunner):
2296         (WebTestThemeEngineWin):
2297         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2298         * DumpRenderTree/chromium/TestShell.cpp:
2299         (TestShell::initialize):
2300         * DumpRenderTree/chromium/TestShell.h:
2301         (WebKit):
2302         * DumpRenderTree/chromium/TestShellMac.mm:
2303         (platformInit):
2304         * DumpRenderTree/chromium/TestShellWin.cpp:
2305         (platformInit):
2306         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2307
2308 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2309
2310         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2311
2312         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2313         New property sheet that does not link against CoreFoundation and
2314         CFNetwork.
2315         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2316         Use new TestWebKitAPICommonWinCairo property sheet.
2317         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2318         Ditto.
2319
2320 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2321
2322         [WinCairo] Unreviewed build fix for VS2010.
2323
2324         Had to add WinCairo-specific property sheets to deal with some
2325         library and path differences with the main Apple port.
2326
2327         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2328         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2329         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2330         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2331         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2332         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2333
2334 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2335
2336         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2337         https://bugs.webkit.org/show_bug.cgi?id=112849
2338
2339         Reviewed by Sam Weinig.
2340
2341         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2342         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2343         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2344
2345 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2346
2347         [WinCairo] Build WebKit Tools under VS2010
2348         https://bugs.webkit.org/show_bug.cgi?id=112821
2349
2350         Reviewed by Tim Horton.
2351
2352         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2353         Add WinCairo-specific build target.
2354         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2355         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2356         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2357         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2358         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2359         Add WinCairo-specific build target.
2360         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2361         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2362         Add WinCairo-specific build target.
2363         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2364         WinCairo-specific build target.
2365         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2366         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2367         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2368         specific build target.
2369         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2370         WinCairo-specific build target.
2371         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2372         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2373         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2374
2375 2013-03-20  Roger Fong  <roger_fong@apple.com>
2376
2377         API test gardening AppleWin port.
2378
2379         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2380
2381         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2382         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2383
2384 2013-03-20  Roger Fong  <roger_fong@apple.com>
2385
2386         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2387
2388         * EWSTools/start-queue-win.sh:
2389
2390 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2391
2392         Unreviewed, add myself to committers.py.
2393
2394 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2395
2396         Unreviewed. Adding another email for me.
2397
2398         * Scripts/webkitpy/common/config/committers.py:
2399
2400 2013-03-20  Justin Novosad  <junov@google.com>
2401
2402         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2403         https://bugs.webkit.org/show_bug.cgi?id=112605
2404
2405         Reviewed by James Robinson.
2406
2407         Deleting all the code that was used for propagating and supporting
2408         the Chromium setting for disabling deferred 2d canvas rendering.
2409
2410         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2411         (main):
2412         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2413         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2414         (WebTestRunner::WebPreferences::reset):
2415         (WebTestRunner::WebPreferences::applyTo):
2416         * DumpRenderTree/chromium/TestShell.cpp:
2417         (TestShell::TestShell):
2418         (TestShell::resetWebSettings):
2419         (TestShell::runFileTest):
2420         * DumpRenderTree/chromium/TestShell.h:
2421         (TestShell):
2422
2423 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2424
2425         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2426         https://bugs.webkit.org/show_bug.cgi?id=112699.
2427
2428         Reviewed by Adam Barth.
2429
2430         * Scripts/webkitpy/layout_tests/port/qt.py:
2431         (QtPort._search_paths):
2432         (QtPort._port_specific_expectations_files):
2433         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2434         (QtPortTest):
2435         (QtPortTest._assert_search_path):
2436         (QtPortTest._assert_expectations_files):
2437
2438 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2439
2440         [Qt] Enable kerning by default
2441         https://bugs.webkit.org/show_bug.cgi?id=112704
2442
2443         Reviewed by Jocelyn Turcotte.
2444
2445         Disable kerning by default, since some reference test expectations
2446         expect kerning to be default off.
2447
2448         * DumpRenderTree/qt/TestRunnerQt.cpp:
2449         (TestRunnerQt::reset):
2450         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2451         (WTR::activateFonts):
2452
2453 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2454
2455         [Qt] Remove empty function stubs from TestRunnerQt.
2456         https://bugs.webkit.org/show_bug.cgi?id=112799
2457
2458         We are reducing the code in TestRunnerQt step by step,
2459         in order to finally replace all of it with the generic
2460         TestRunner implementation.
2461         This patch removes several simple function stubs that
2462         currently do not implement any actual functionality.
2463
2464         Reviewed by Kenneth Rohde Christiansen.
2465
2466         * DumpRenderTree/qt/TestRunnerQt.cpp:
2467         * DumpRenderTree/qt/TestRunnerQt.h:
2468         (TestRunnerQt):
2469
2470 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2471
2472         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2473         https://bugs.webkit.org/show_bug.cgi?id=112687
2474
2475         Reviewed by Kenneth Rohde Christiansen.
2476
2477         Hide the SearchBar by default on window creation.
2478
2479         * MiniBrowser/efl/main.c:
2480         (window_create):
2481
2482 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2483
2484         Unreviewed, rolling out r146304.
2485         http://trac.webkit.org/changeset/146304
2486         https://bugs.webkit.org/show_bug.cgi?id=112788
2487
2488         to many expectations to update (Requested by antonm on
2489         #webkit).
2490
2491         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2492         * DumpRenderTree/DumpRenderTree.gypi:
2493         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2494         (WebKit):
2495         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2496         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2497         (TestInterfaces):
2498         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2499         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2500         * DumpRenderTree/chromium/TestShell.cpp:
2501         (TestShell::initialize):
2502         * DumpRenderTree/chromium/TestShell.h:
2503         (WebKit):
2504         * DumpRenderTree/chromium/TestShellMac.mm:
2505         (platformInit):
2506         * DumpRenderTree/chromium/TestShellWin.cpp:
2507         (platformInit):
2508         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2509         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2510         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2511         (WebThemeControlDRTWin::box):
2512         (WebThemeControlDRTWin::line):
2513         (WebThemeControlDRTWin::triangle):
2514         (WebThemeControlDRTWin::roundRect):
2515         (WebThemeControlDRTWin::oval):
2516         (WebThemeControlDRTWin::circle):
2517         (WebThemeControlDRTWin::nestedBoxes):
2518         (WebThemeControlDRTWin::markState):
2519         (WebThemeControlDRTWin::draw):
2520         (WebThemeControlDRTWin::drawTextField):
2521         (WebThemeControlDRTWin::drawProgressBar):
2522         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2523         (WebThemeControlDRTWin):
2524         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2525         (WebThemeEngineDRTMac):
2526         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2527         (+[FakeActiveWindow alwaysActiveWindow]):
2528         (+[FakeActiveWindow alwaysInactiveWindow]):
2529         (-[FakeActiveWindow initWithActiveControls:]):
2530         (-[FakeActiveWindow _hasActiveControls]):
2531         (WebThemeEngineDRTMac::paintScrollbarThumb):
2532         (stateToHIEnableState):
2533         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2534         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2535         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2536         (webRectToSkIRect):
2537         (drawControl):
2538         (drawTextField):
2539         (drawProgressBar):
2540         (WebThemeEngineDRTWin::paintButton):
2541         (WebThemeEngineDRTWin::paintMenuList):
2542         (WebThemeEngineDRTWin::paintScrollbarArrow):
2543         (WebThemeEngineDRTWin::paintScrollbarThumb):
2544         (WebThemeEngineDRTWin::paintScrollbarTrack):
2545         (WebThemeEngineDRTWin::paintSpinButton):
2546         (WebThemeEngineDRTWin::paintTextField):
2547         (WebThemeEngineDRTWin::paintTrackbar):
2548         (WebThemeEngineDRTWin::paintProgressBar):
2549         (WebThemeEngineDRTWin::getSize):
2550         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2551         (WebThemeEngineDRTWin):
2552         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2553
2554 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2555
2556         [Qt] Support -webkit-font-smoothing
2557         https://bugs.webkit.org/show_bug.cgi?id=106009
2558
2559         Reviewed by Jocelyn Turcotte.
2560
2561         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2562
2563         * DumpRenderTree/qt/TestRunnerQt.cpp:
2564         (TestRunnerQt::reset):
2565
2566 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2567
2568         [GTK] accessibility/aria-scrollbar-role.html is failing
2569         https://bugs.webkit.org/show_bug.cgi?id=98358
2570
2571         Reviewed by Martin Robinson.
2572
2573         Adds support for checking accessibility object's orientation.
2574         Orientation is checked by retrieving proper state of accessibility object.
2575
2576         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2577         (checkElementState):
2578         (AccessibilityUIElement::orientation):
2579         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2580         (WTR::AccessibilityUIElement::orientation):
2581
2582 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2583
2584         [chromium] move WebThemeEngine implementations to TestRunner library
2585         https://bugs.webkit.org/show_bug.cgi?id=112751
2586
2587         Reviewed by Adam Barth.
2588
2589         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2590         * DumpRenderTree/DumpRenderTree.gypi:
2591         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2592         (WebKit):
2593         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2594         (WebTestRunner::TestInterfaces::themeEngine):
2595         (WebTestRunner):
2596         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2597         (WebKit):
2598         (TestInterfaces):
2599         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2600         (WebTestRunner::WebTestInterfaces::themeEngine):
2601         (WebTestRunner):
2602         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2603         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2604         (WebTestRunner):
2605         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2606         (WebTestRunner::WebTestThemeControlWin::box):
2607         (WebTestRunner::WebTestThemeControlWin::line):
2608         (WebTestRunner::WebTestThemeControlWin::triangle):
2609         (WebTestRunner::WebTestThemeControlWin::roundRect):
2610         (WebTestRunner::WebTestThemeControlWin::oval):
2611         (WebTestRunner::WebTestThemeControlWin::circle):
2612         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2613         (WebTestRunner::WebTestThemeControlWin::markState):
2614         (WebTestRunner::WebTestThemeControlWin::draw):
2615         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2616         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2617         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2618         (WebTestRunner):
2619         (WebTestThemeControlWin):
2620         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2621         (WebTestRunner):
2622         (WebTestThemeEngineMac):
2623         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2624         (+[FakeActiveWindow alwaysActiveWindow]):
2625         (+[FakeActiveWindow alwaysInactiveWindow]):
2626         (-[FakeActiveWindow initWithActiveControls:]):
2627         (-[FakeActiveWindow _hasActiveControls]):
2628         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2629         (WebTestRunner):
2630         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2631         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2632         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2633         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2634         (WebTestRunner):
2635         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2636         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2637         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2638         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2639         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2640         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2641         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2642         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2643         (WebTestRunner::WebTestThemeEngineWin::getSize):
2644         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2645         (WebTestRunner):
2646         (WebTestThemeEngineWin):
2647         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2648         * DumpRenderTree/chromium/TestShell.cpp:
2649         (TestShell::initialize):
2650         * DumpRenderTree/chromium/TestShell.h:
2651         (WebKit):
2652         * DumpRenderTree/chromium/TestShellMac.mm:
2653         (platformInit):
2654         * DumpRenderTree/chromium/TestShellWin.cpp:
2655         (platformInit):
2656         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2657
2658 2013-03-19  Tony Chang  <tony@chromium.org>
2659
2660         Move testRunner.setTouchDragDropEnabled to internals.settings
2661         https://bugs.webkit.org/show_bug.cgi?id=112739
2662
2663         Reviewed by Adam Barth.
2664
2665         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2666         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2667         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2668         (TestRunner): Remove unnecessary code.
2669         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2670         (WebTestRunner::WebPreferences::reset):
2671         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2672
2673 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2674
2675         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2676         https://bugs.webkit.org/show_bug.cgi?id=112754
2677
2678         Reviewed by Darin Fisher.
2679
2680         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2681         now that it's always defined.
2682
2683         * DumpRenderTree/chromium/WebViewHost.cpp:
2684         * DumpRenderTree/chromium/WebViewHost.h:
2685         (WebViewHost):
2686
2687 2013-03-19  Kenneth Russell  <kbr@google.com>
2688
2689         Unreviewed, rolling out r146290.
2690         http://trac.webkit.org/changeset/146290
2691         https://bugs.webkit.org/show_bug.cgi?id=112751
2692
2693         Broke Chromium Mac build.
2694
2695         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2696         * DumpRenderTree/DumpRenderTree.gypi:
2697         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2698         (WebKit):
2699         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2700         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2701         (TestInterfaces):
2702         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2703         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2704         * DumpRenderTree/chromium/TestShell.cpp:
2705         (TestShell::initialize):
2706         * DumpRenderTree/chromium/TestShell.h:
2707         (WebKit):
2708         * DumpRenderTree/chromium/TestShellMac.mm:
2709         (platformInit):
2710         * DumpRenderTree/chromium/TestShellWin.cpp:
2711         (platformInit):
2712         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2713         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2714         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2715         (WebThemeControlDRTWin::box):
2716         (WebThemeControlDRTWin::line):
2717         (WebThemeControlDRTWin::triangle):
2718         (WebThemeControlDRTWin::roundRect):
2719         (WebThemeControlDRTWin::oval):
2720         (WebThemeControlDRTWin::circle):
2721         (WebThemeControlDRTWin::nestedBoxes):
2722         (WebThemeControlDRTWin::markState):
2723         (WebThemeControlDRTWin::draw):
2724         (WebThemeControlDRTWin::drawTextField):
2725         (WebThemeControlDRTWin::drawProgressBar):
2726         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2727         (WebThemeControlDRTWin):
2728         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2729         (WebThemeEngineDRTMac):
2730         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2731         (+[FakeActiveWindow alwaysActiveWindow]):
2732         (+[FakeActiveWindow alwaysInactiveWindow]):
2733         (-[FakeActiveWindow initWithActiveControls:]):
2734         (-[FakeActiveWindow _hasActiveControls]):
2735         (WebThemeEngineDRTMac::paintScrollbarThumb):
2736         (stateToHIEnableState):
2737         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2738         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2739         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2740         (webRectToSkIRect):
2741         (drawControl):
2742         (drawTextField):
2743         (drawProgressBar):
2744         (WebThemeEngineDRTWin::paintButton):
2745         (WebThemeEngineDRTWin::paintMenuList):
2746         (WebThemeEngineDRTWin::paintScrollbarArrow):
2747         (WebThemeEngineDRTWin::paintScrollbarThumb):
2748         (WebThemeEngineDRTWin::paintScrollbarTrack):
2749         (WebThemeEngineDRTWin::paintSpinButton):
2750         (WebThemeEngineDRTWin::paintTextField):
2751         (WebThemeEngineDRTWin::paintTrackbar):
2752         (WebThemeEngineDRTWin::paintProgressBar):
2753         (WebThemeEngineDRTWin::getSize):
2754         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2755         (WebThemeEngineDRTWin):
2756         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2757
2758 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2759
2760         [EFL] canvas-fallback-content.html is failing
2761         https://bugs.webkit.org/show_bug.cgi?id=111998
2762
2763         Reviewed by Chris Fleizach.
2764
2765         Adds support for getting platform name.
2766
2767         * DumpRenderTree/TestRunner.cpp:
2768         (TestRunner::staticValues):
2769         * DumpRenderTree/TestRunner.h:
2770         (TestRunner):
2771         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2772         (TestRunner::platformName):
2773
2774 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2775
2776         [chromium] move WebThemeEngine implementations to TestRunner library
2777         https://bugs.webkit.org/show_bug.cgi?id=112751
2778
2779         Reviewed by Adam Barth.
2780
2781         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2782         * DumpRenderTree/DumpRenderTree.gypi:
2783         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2784         (WebKit):
2785         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2786         (WebTestRunner::TestInterfaces::themeEngine):
2787         (WebTestRunner):
2788         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2789         (WebKit):
2790         (TestInterfaces):
2791         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2792         (WebTestRunner::WebTestInterfaces::themeEngine):
2793         (WebTestRunner):
2794         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2795         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2796         (WebTestRunner):
2797         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2798         (WebTestRunner::WebTestThemeControlWin::box):
2799         (WebTestRunner::WebTestThemeControlWin::line):
2800         (WebTestRunner::WebTestThemeControlWin::triangle):
2801         (WebTestRunner::WebTestThemeControlWin::roundRect):
2802         (WebTestRunner::WebTestThemeControlWin::oval):
2803         (WebTestRunner::WebTestThemeControlWin::circle):
2804         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2805         (WebTestRunner::WebTestThemeControlWin::markState):
2806         (WebTestRunner::WebTestThemeControlWin::draw):
2807         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2808         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2809         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2810         (WebTestRunner):
2811         (WebTestThemeControlWin):
2812         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2813         (WebTestRunner):
2814         (WebTestThemeEngineMac):
2815         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2816         (+[FakeActiveWindow alwaysActiveWindow]):
2817         (+[FakeActiveWindow alwaysInactiveWindow]):
2818         (-[FakeActiveWindow initWithActiveControls:]):
2819         (-[FakeActiveWindow _hasActiveControls]):
2820         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2821         (WebTestRunner):
2822         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2823         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2824         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2825         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2826         (WebTestRunner):
2827         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2828         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2829         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2830         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2831         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2832         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2833         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2834         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2835         (WebTestRunner::WebTestThemeEngineWin::getSize):
2836         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2837         (WebTestRunner):
2838         (WebTestThemeEngineWin):
2839         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2840         * DumpRenderTree/chromium/TestShell.cpp:
2841         (TestShell::initialize):
2842         * DumpRenderTree/chromium/TestShell.h:
2843         (WebKit):
2844         * DumpRenderTree/chromium/TestShellMac.mm:
2845         (platformInit):
2846         * DumpRenderTree/chromium/TestShellWin.cpp:
2847         (platformInit):
2848         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2849
2850 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2851
2852         [EFL][WK2] Separate WebView further from EwkView
2853         https://bugs.webkit.org/show_bug.cgi?id=111591
2854
2855         Reviewed by Caio Marcelo de Oliveira Filho.
2856
2857         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2858         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2859         since we can afford it having EWKViewGetWKView() private API to access WKView.
2860
2861         * TestWebKitAPI/PlatformWebView.h:
2862         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2863         (TestWebKitAPI::TEST):
2864         * TestWebKitAPI/efl/PlatformWebView.cpp:
2865         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2866         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2867         (TestWebKitAPI::PlatformWebView::resizeTo):
2868         (TestWebKitAPI::PlatformWebView::page):
2869         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2870         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2871         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2872         * WebKitTestRunner/PlatformWebView.h:
2873         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2874         (WTR::EventSenderProxy::dispatchEvent):
2875         (WTR::EventSenderProxy::keyDown):
2876         (WTR::EventSenderProxy::sendTouchEvent):
2877         (WTR::EventSenderProxy::setTouchModifier):
2878         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2879         (WTR::PlatformWebView::PlatformWebView):
2880         (WTR::PlatformWebView::~PlatformWebView):
2881         (WTR::PlatformWebView::resizeTo):
2882         (WTR::PlatformWebView::page):
2883         (WTR::PlatformWebView::focus):
2884         (WTR::PlatformWebView::windowSnapshotImage):
2885
2886 2013-03-19  Roger Fong  <roger_fong@apple.com>
2887
2888         Changes to VS2010 project files should only trigger builds on Windows bots.
2889         https://bugs.webkit.org/show_bug.cgi?id=112731
2890
2891         Reviewed by Timothy Horton.
2892
2893         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2894         (_should_file_trigger_build):
2895
2896 2013-03-19  Roger Fong  <roger_fong@apple.com>
2897
2898         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2899
2900         * Scripts/webkitpy/tool/steps/runtests.py:
2901         (RunTests.run):
2902         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2903         (RunTestsTest.test_webkit_run_unit_tests):
2904
2905 2013-03-19  Julie Parent  <jparent@chromium.org>
2906
2907         Dashboards: Introduce history namespace and unit tests.
2908         https://bugs.webkit.org/show_bug.cgi?id=112645
2909
2910         Reviewed by Ojan Vafai.
2911         
2912         Laying the framework for introducing the new history object and
2913         namespace.  This moves only static functions into the history
2914         namespace, and moves corresponding unit tests into seperate
2915         unit test file.
2916
2917         * TestResultServer/static-dashboards/aggregate_results.html:
2918         * TestResultServer/static-dashboards/dashboard_base.js:
2919         (parseCrossDashboardParameters):
2920         (parseDashboardSpecificParameters):
2921         (parseParameters):
2922         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2923         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2924         (.switch.return):
2925         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2926         * TestResultServer/static-dashboards/history.js: Added.
2927         * TestResultServer/static-dashboards/history_unittests.js: Added.
2928         * TestResultServer/static-dashboards/loader.js:
2929         (.):
2930         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2931         * TestResultServer/static-dashboards/run-unittests.html:
2932         * TestResultServer/static-dashboards/timeline_explorer.html:
2933         * TestResultServer/static-dashboards/timeline_explorer.js:
2934         * TestResultServer/static-dashboards/treemap.html:
2935         * TestResultServer/static-dashboards/treemap.js:
2936         (.switch.return):
2937         * TestResultServer/static-dashboards/ui.js:
2938
2939 2013-03-19  Daniel Bates  <dbates@webkit.org>
2940
2941         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2942         https://bugs.webkit.org/show_bug.cgi?id=112732
2943
2944         Reviewed by Eric Seidel.
2945
2946         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2947         of an existing file cannot be applied.
2948
2949         In particular, svn-{apply, unapply} compensate for differences in line endings
2950         by converting the line endings in a diff to match the line endings in the target
2951         file. The diff(1) command precedes the last line of a diff that adds a newline
2952         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2953         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2954         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2955         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2956         the newline characters in this special character sequence to match the line endings
2957         in the target file.
2958
2959         * Scripts/VCSUtils.pm:
2960         (parseDiff):
2961         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2962         Added tests:
2963             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2964             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2965             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2966             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2967         (escapeNewLineCharacters): Added.
2968         (toMacLineEndings): Added.
2969
2970 2013-03-19  James Robinson  <jamesr@chromium.org>
2971
2972         [chromium] Remove compositor settings that don't go through WebKit
2973         https://bugs.webkit.org/show_bug.cgi?id=112718
2974
2975         Reviewed by Adam Barth.
2976
2977         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2978         (main):
2979         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2980         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2981         (WebTestRunner::WebPreferences::reset):
2982         (WebTestRunner::WebPreferences::applyTo):
2983         * DumpRenderTree/chromium/TestShell.cpp:
2984         (TestShell::TestShell):
2985         (TestShell::resetWebSettings):
2986         * DumpRenderTree/chromium/TestShell.h:
2987         (TestShell):
2988
2989 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
2990
2991         Unreviewed, rolling out r146101.
2992         https://bugs.webkit.org/show_bug.cgi?id=111884
2993
2994         re-enable custom freetype on asan; this needs to be on
2995         now that the bot is running lucid.
2996
2997         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2998
2999 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3000
3001         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3002         https://bugs.webkit.org/show_bug.cgi?id=112365
3003
3004         Reviewed by Benjamin Poulain.
3005
3006         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3007         harcoding it in wtf/Platform.h
3008
3009         * Scripts/webkitperl/FeatureList.pm:
3010
3011 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3012
3013         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3014         https://bugs.webkit.org/show_bug.cgi?id=94782
3015
3016         Based on patch by Csaba Osztrogonác.
3017         Reviewed by Jocelyn Turcotte.
3018
3019         The diff image is generated with bright red indicating errors, but letting the base image
3020         shine through so the context of the error-pixel can be identified.
3021
3022         * DumpRenderTree/qt/ImageDiff.cpp:
3023         (main):
3024
3025 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3026
3027         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3028
3029         Rubber-stamped by Csaba Osztrogonác.
3030
3031         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3032         since the latter might not cover the former.
3033
3034         * QtTestBrowser/launcherwindow.cpp:
3035         (LauncherWindow::print):
3036
3037 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3038
3039         Style tweeks to default.css.
3040         
3041         Rubber-stamped by David Kilzer.
3042         
3043         Give visited links a different color to other links, so you can
3044         see which builds you've viewed.
3045         
3046         Make the <small> text less tiny.
3047
3048         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3049         (small):
3050         (a:link,a:visited,a:active):
3051         (a:visited):
3052
3053 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3054
3055         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3056         https://bugs.webkit.org/show_bug.cgi?id=112494
3057
3058         Reviewed by Dirk Pranke.
3059
3060         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3061         Also merged two pairs of methods to cleanup the code.
3062
3063         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3064         (PerfTestsRunner.run): Merged _upload_and_show_results.
3065         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3066
3067 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3068
3069         [chromium] build xdisplaycheck when building DRT
3070         https://bugs.webkit.org/show_bug.cgi?id=112636
3071
3072         Reviewed by Tony Chang.
3073
3074         It appears that we need xdisplaycheck to be built in order for
3075         Xvfb to be started correctly on the bots, and DRT was missing
3076         a dependency on it. This may be the cause of the ASAN bot not
3077         starting up properly (it only builds DRT).
3078
3079         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3080
3081 2013-03-18  David Levin  <levin@chromium.org>
3082
3083         Implement icon change notification dump for Chromium's test shell.
3084         https://bugs.webkit.org/show_bug.cgi?id=112614
3085
3086         This was previously implemented for some other platforms in r58111
3087         and r116547.
3088
3089         In r122806, fast/dom/icon-url-property.html stopped using it, but
3090         it is useful for tests, so I plan to re-add it to that test again.
3091
3092         Reviewed by Jochen Eisinger.
3093
3094         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3095         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3096          icon change notifications from WebKit may be logged in test output.
3097         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3098         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3099         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3100         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3101         (WebTestRunner):
3102         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3103         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3104         (TestRunner):
3105         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3106         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3107         (WebTestRunner):
3108         * DumpRenderTree/chromium/WebViewHost.cpp:
3109         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3110         * DumpRenderTree/chromium/WebViewHost.h:
3111         (WebViewHost):
3112
3113 2013-03-18  Julie Parent  <jparent@chromium.org>
3114
3115         Cleanup: Move js for treemap and aggregate_results into own js files.
3116         https://bugs.webkit.org/show_bug.cgi?id=112618
3117
3118         Reviewed by Dirk Pranke.
3119         
3120         No functional changes, just moving the code into separate js file
3121         rather than inlined in the html, so we can test it, make it more
3122         modular, etc.  Other dashboard types are already done this way.
3123
3124         * TestResultServer/static-dashboards/aggregate_results.html:
3125         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3126         (generatePage):
3127         (handleValidHashParameter):
3128         (htmlForBuilder):
3129         (rawValuesHTML):
3130         (chartHTML):
3131         (filteredValues):
3132         (chart):
3133         (htmlForRevisionRows):
3134         (wrapHTMLInTable):
3135         (htmlForSummaryTable):
3136         (valuesPerExpectation):
3137         (htmlForTestType):
3138         (htmlForTableRow):
3139         (extendedEncode):
3140         * TestResultServer/static-dashboards/treemap.html:
3141         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3142         (humanReadableTime):
3143         (convertToWebTreemapFormat):
3144         (reverseSortByAverage):
3145         (generatePage):
3146         (focusPath):
3147         (.switch.return):
3148         (handleQueryParameterChange):
3149         (extractName):
3150         (fullName):
3151         (handleFocus.):
3152         (handleFocus):
3153
3154 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3155
3156         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3157         https://bugs.webkit.org/show_bug.cgi?id=112622
3158
3159         Reviewed by Dirk Pranke.
3160
3161         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3162         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3163
3164 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3165
3166         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3167         https://bugs.webkit.org/show_bug.cgi?id=112619
3168
3169         Reviewed by Dirk Pranke.
3170
3171         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3172         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3173
3174         * Scripts/webkitpy/layout_tests/port/gtk.py:
3175         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3176         Port._webkit_baseline_path method.
3177         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3178         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3179         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3180         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3181         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3182         that are expected based on the builder name.
3183
3184 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3185
3186         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3187         https://bugs.webkit.org/show_bug.cgi?id=112571
3188
3189         Reviewed by Adam Barth.
3190
3191         Update function declarations for new WebFileSystemType enum. (All
3192         changes are behind an #ifdef so we can sync required changes in embedders.)
3193
3194         * DumpRenderTree/chromium/WebViewHost.cpp:
3195         (WebViewHost::openFileSystem):
3196         (WebViewHost::deleteFileSystem):
3197         * DumpRenderTree/chromium/WebViewHost.h:
3198         (WebViewHost):
3199
3200 2013-03-18  Julie Parent  <jparent@chromium.org>
3201
3202         Cleanup: Move timeline_exporer js out of html file into js.
3203         https://bugs.webkit.org/show_bug.cgi?id=112188
3204
3205         Reviewed by Dirk Pranke.
3206         
3207         Moves the javascript out of the html file and into a new js file.
3208         This follows the format of flakiness_dashboard.{html|js}.
3209         
3210         Also moves code from dashboard_base that is used only by this one
3211         dashboard, and makes it private to the dashboard.
3212
3213         * TestResultServer/static-dashboards/dashboard_base.js:
3214         * TestResultServer/static-dashboards/timeline_explorer.html:
3215         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3216         (generatePage):
3217         (initCurrentBuilderTestResults):
3218         (shouldShowWebKitRevisionsOnly):
3219         (updateTimelineForBuilder.):
3220         (updateTimelineForBuilder):
3221         (selectBuild):
3222         (updateBuildIndicator):
3223         (.addRow):
3224         (.addNumberRow):
3225         (.inspectorNode.getElementsByTagName.0.onclick):
3226         (.inspectorNode.getElementsByTagName.1.onclick):
3227         (.inspectorNode.getElementsByTagName.2.onclick):
3228         (updateBuildInspector):
3229         (showResultsDelta):
3230         (decompressResults.addFlakyDelta):
3231         (decompressResults):
3232
3233 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3234
3235         Unreviewed, rolling out r145272.
3236         http://trac.webkit.org/changeset/145272
3237         https://bugs.webkit.org/show_bug.cgi?id=111884
3238
3239         Turns out the ASAN build is still broken; possibly there's
3240         something still setting LD_LIBRARY_PATH, or possibly there's
3241         something else wrong. In the meantime, we need it to work again.
3242
3243         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3244
3245 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3246
3247         delete-stale-build-files is too aggressive
3248         https://bugs.webkit.org/show_bug.cgi?id=112595
3249
3250         Reviewed by Tim Horton.
3251
3252         It appears that whitelisting file extensions to keep is not a good idea.
3253         Blacklist files to delete instead, and only delete .o files for now.
3254         We can add more file extensions as needed.
3255
3256         * BuildSlaveSupport/delete-stale-build-files:
3257
3258 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3259
3260         Disable accessibility notifications after each test
3261         https://bugs.webkit.org/show_bug.cgi?id=112579
3262
3263         Reviewed by Tim Horton.
3264         
3265         In WebKitTestRunner, if any tests triggered accessibility notifications,
3266         the global notification handler would thereafter be active, and fire
3267         notifications for all subsequent tests.
3268         
3269         Fix by implementing AccessibilityController::resetToConsistentState() for
3270         Mac, and using it to clear the global notification handler.
3271
3272         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3273         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3274         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3275         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3276         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3277         (e.g. because of -autorelease).
3278         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3279         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3280         if there is one.
3281         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3282         Add -stopObserving
3283         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3284         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3285         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3286         center.
3287
3288 2013-03-18  Dana Jansens  <danakj@chromium.org>
3289
3290         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3291         https://bugs.webkit.org/show_bug.cgi?id=112392
3292
3293         Reviewed by James Robinson.
3294
3295         Removes the command line flag option from DRT.
3296
3297         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3298         (main):
3299
3300 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3301
3302         [GTK] plugins/plugin-clip-subframe.html is failing
3303         https://bugs.webkit.org/show_bug.cgi?id=112570
3304
3305         Reviewed by Martin Robinson.
3306
3307         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3308
3309 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3310
3311         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3312         https://bugs.webkit.org/show_bug.cgi?id=112442
3313
3314         Reviewed by Gustavo Noronha Silva.
3315
3316         * GtkLauncher/main.c:
3317         (reloadCb):
3318         (createToolbar):
3319         (createWindow):
3320
3321 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3322
3323         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3324         https://bugs.webkit.org/show_bug.cgi?id=112205
3325
3326         Disable this API test until Geoff can fix it.
3327
3328         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3329         (TestWebKitAPI::TEST):
3330
3331 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3332
3333         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3334         https://bugs.webkit.org/show_bug.cgi?id=112478
3335
3336         Reviewed by Tony Chang.
3337
3338         There is nothing that ensures that the log messages from the plugin
3339         come in before the layout test finished loading.
3340
3341         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3342         (PassDifferentNPPStruct::NPP_SetWindow):
3343         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3344         (NPP_SetWindow):
3345
3346 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3347
3348         Have the mac port support per_test_timeout in webkitpy
3349         https://bugs.webkit.org/show_bug.cgi?id=112466
3350
3351         Reviewed by Dirk Pranke.
3352         
3353         Both WTR and DRT handle --timeout arguments, so we can
3354         have the scripts pass the timeout values down to the tools.
3355
3356         * Scripts/webkitpy/layout_tests/port/mac.py:
3357         (MacPort.supports_per_test_timeout):
3358
3359 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3360
3361         Remove setAsynchronousSpellCheckingEnabled from test runners
3362         https://bugs.webkit.org/show_bug.cgi?id=112362
3363
3364         Reviewed by Tony Chang.
3365
3366         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3367         in internals.settings, so all ports can share it.
3368
3369         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3370         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3371         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3372         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3373         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3374         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3375         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3376         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3377         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3378         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3379         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3380         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3381
3382 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3383
3384         Fix the stupid unit tests.
3385
3386         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3387         (test_sample_process):
3388
3389 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3390
3391         Collect samples for unresponsive web processes
3392         https://bugs.webkit.org/show_bug.cgi?id=112409
3393
3394         Reviewed by Tim Horton.
3395         
3396         When we detect that a subprocess was unresponsive, run the 'sample'
3397         tool on that process, for the Mac port.
3398         
3399         The sample will be linked to from the results.html page, next
3400         to the crash log link.
3401
3402         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3403         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3404         look for samples on disk.
3405         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3406         (TestResultWriter):
3407         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3408         -sample.txt files, and have it copy their contents to a new file
3409         next to the test that spawned them (as we do for crash logs).
3410         * Scripts/webkitpy/layout_tests/port/base.py:
3411         (Port.look_for_new_samples): Base class does nothing for sampling.
3412         * Scripts/webkitpy/layout_tests/port/driver.py:
3413         (Driver._check_for_driver_crash): Kick off a sample if we detected
3414         that the subprocess was unresponsive.
3415         * Scripts/webkitpy/layout_tests/port/mac.py:
3416         (MacPort.sample_file_path): Utility to generate the file path
3417         to the generated sample files at the top level of layout-test-results.
3418         (MacPort.look_for_new_crash_logs): Fix typo
3419         (MacPort.look_for_new_samples): New function to find sample files.
3420         (MacPort.sample_process): Use the utility function to get the file path.
3421
3422 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3423
3424         [Qt] Remove simple getters and setters from TestRunnerQt
3425         https://bugs.webkit.org/show_bug.cgi?id=112343
3426
3427         Reviewed by Benjamin Poulain.
3428
3429         The removed functions and boolean members
3430         are being replaced by the implementations in the
3431         generic TestRunner.h.
3432
3433         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3434         (DumpRenderTree::dumpFrameScrollPosition):
3435         (DumpRenderTree::dumpFramesAsText):
3436         (DumpRenderTree::dump):
3437         (DumpRenderTree::titleChanged):
3438         (DumpRenderTree::dumpDatabaseQuota):
3439         (DumpRenderTree::dumpApplicationCacheQuota):
3440         (DumpRenderTree::statusBarMessage):
3441         (DumpRenderTree::createWindow):
3442         * DumpRenderTree/qt/TestRunnerQt.cpp:
3443         (TestRunnerQt::reset):
3444         * DumpRenderTree/qt/TestRunnerQt.h:
3445         (TestRunnerQt):
3446
3447 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3448
3449         Update the link on build.webkit.org to refer to perf.webkit.org
3450         https://bugs.webkit.org/show_bug.cgi?id=112416
3451
3452         Reviewed by Philip Rogers.
3453
3454         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3455
3456         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3457
3458 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3459
3460         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3461         https://bugs.webkit.org/show_bug.cgi?id=112394
3462
3463         Reviewed by Philippe Normand.
3464
3465         * GtkLauncher/main.c:
3466         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3467
3468 2013-03-14  Andreas Kling  <akling@apple.com>
3469
3470         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3471         <http://webkit.org/b/111815>
3472         <rdar://problem/13380145>
3473
3474         Reviewed by Anders Carlsson.
3475
3476         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3477         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3478         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3479
3480         * WebKitTestRunner/PlatformWebView.h:
3481         (PlatformWebView):
3482         * WebKitTestRunner/TestController.cpp:
3483         (WTR::TestController::createOtherPage):
3484         (WTR::TestController::createWebViewWithOptions):
3485         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3486         (WTR::PlatformWebView::didInitializeClients):
3487
3488 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3489
3490         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3491         https://bugs.webkit.org/show_bug.cgi?id=112122
3492
3493         Reviewed by Kenneth Rohde Christiansen.
3494
3495         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3496
3497         * MiniBrowser/efl/main.c:
3498         (_Browser_Window):
3499         (search_box_show):
3500         (search_box_hide):
3501         (on_key_down):
3502         (on_url_changed):
3503         (on_search_field_aborted):
3504         (on_search_field_activated):
3505         (on_search_field_clicked):
3506         (on_search_backward_button_clicked):
3507         (on_search_forward_button_clicked):
3508         (window_create):
3509
3510 2013-03-14  Julie Parent  <jparent@chromium.org>
3511
3512         Cleanup: Remove g_resourceLoader.
3513         https://bugs.webkit.org/show_bug.cgi?id=112305
3514
3515         Reviewed by Dirk Pranke.
3516         
3517         Removing another global.
3518         
3519         Now, each dashboard creates its own loader, rather than having
3520         a general global one.
3521         
3522         Remove usage of g_resourceLoader.isLoadingComplete from 
3523         handleLocationChange by ensuring that handleLocationChange is
3524         never called before the loader is done.  It was called in two
3525         places before: 1 was from the callback when the loader is done,
3526         so that was obviously true, and the other was from onhashchange,
3527         where it would just return rather than running.  Instead, lets
3528         only register the onhashchange handler once the loader is
3529         setup, so the check is no longer necessary.
3530         
3531         Remove isLoadingComplete since it is now unused.
3532         
3533         Callback for loader is now initializeHistory, rather than just
3534         handleLocationChange which will set up the hashchange handler now.
3535         This will all eventually be moving to a new History object.
3536
3537         * TestResultServer/static-dashboards/aggregate_results.html:
3538         * TestResultServer/static-dashboards/dashboard_base.js:
3539         (handleLocationChange):
3540         (intializeHistory):
3541         (decompressResults):
3542         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3543         (generatePage):
3544         * TestResultServer/static-dashboards/loader.js:
3545         (.):
3546         * TestResultServer/static-dashboards/loader_unittests.js:
3547         * TestResultServer/static-dashboards/timeline_explorer.html:
3548         * TestResultServer/static-dashboards/treemap.html:
3549
3550 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3551
3552         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3553         https://bugs.webkit.org/show_bug.cgi?id=109404
3554
3555         Reviewed by Tony Chang.
3556
3557         Removes all the code related to smartInsertDeleteEnabled and
3558         selectTrailingWhitespaceEnabled settings as they will be managed from
3559         internals from now on.
3560
3561         * DumpRenderTree/TestRunner.cpp:
3562         (TestRunner::staticFunctions):
3563         * DumpRenderTree/TestRunner.h:
3564         (TestRunner):
3565         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3566         (WebKit):
3567         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3568         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3569         (DumpRenderTree):
3570         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3571         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3572         (WebTestRunner::WebTestProxy::didStopLoading):
3573         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3574         (WebTestRunner::TestRunner::TestRunner):
3575         (WebTestRunner::TestRunner::reset):
3576         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3577         (TestRunner):
3578         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3579         (WebTestRunner::WebPreferences::applyTo): Set default values for
3580         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3581         Chromium DRT default values are different from Chromium browser.
3582         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3583         * DumpRenderTree/chromium/WebViewHost.cpp:
3584         * DumpRenderTree/chromium/WebViewHost.h:
3585         (WebViewHost):
3586         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3587         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3588         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3589         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3590         (resetDefaultsToConsistentValues):
3591         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3592         * DumpRenderTree/mac/DumpRenderTree.mm:
3593         (resetWebViewToConsistentStateBeforeTesting):
3594         * DumpRenderTree/mac/TestRunnerMac.mm:
3595         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3596         (WebCore::WebPage::resetSettings):
3597         * DumpRenderTree/qt/TestRunnerQt.cpp:
3598         * DumpRenderTree/qt/TestRunnerQt.h:
3599         (TestRunnerQt):
3600         * DumpRenderTree/win/DumpRenderTree.cpp:
3601         (resetWebViewToConsistentStateBeforeTesting):
3602         * DumpRenderTree/win/TestRunnerWin.cpp:
3603         * DumpRenderTree/wx/TestRunnerWx.cpp:
3604
3605 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3606
3607         [Qt] Disable DRT on Windows
3608
3609         Reviewed by Jocelyn Turcotte.
3610
3611         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3612
3613         * qmake/mkspecs/features/configure.prf:
3614
3615 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3616
3617         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
3618         https://bugs.webkit.org/show_bug.cgi?id=110728
3619
3620         Reviewed by Gyuyoung Kim.
3621
3622         Use the page group to create the view object.
3623
3624         * MiniBrowser/efl/main.c:
3625         (window_create):
3626
3627 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3628
3629         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
3630
3631         Reviewed by Tor Arne Vestbø.
3632
3633         The mock versions of these web facing features should be instantiated when
3634         running in DumpRenderTree only. In order for them to work, no extra Qt modules
3635         such as QtLocation are actually needed.
3636
3637         This patch decouples enabling device orientation/motion and geolocation from
3638         the underlying Qt modules and makes them available in developer builds
3639         (!production_build) and backed by mock backends when running in drt.
3640
3641         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
3642         developers the web facing features are always enabled (although requests will
3643         time out) and the mock backends are enabled inside DRT, allowing for the layout
3644         tests to run with less dependencies.
3645
3646         In addition this also enables the mock device motion client, which was
3647         previously never instantiated.
3648
3649         * qmake/mkspecs/features/features.prf:
3650
3651 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3652
3653         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
3654         https://bugs.webkit.org/show_bug.cgi?id=112340
3655
3656         Reviewed by Simon Hausmann.
3657
3658         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3659         (DumpRenderTree::dump):
3660             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
3661         (DumpRenderTree::dumpApplicationCacheQuota):
3662         * DumpRenderTree/qt/TestRunnerQt.cpp:
3663         (TestRunnerQt::reset):
3664         * DumpRenderTree/qt/TestRunnerQt.h:
3665         (TestRunnerQt):
3666
3667 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3668
3669         [Qt] Port DRT to use TestRunner::dumpAsText()
3670         https://bugs.webkit.org/show_bug.cgi?id=112260
3671
3672         Reviewed by Benjamin Poulain.
3673
3674         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3675         (WebCore::DumpRenderTree::open):
3676         (WebCore::methodNameStringForFailedTest):
3677             Change parameter from type TestRunnerQt* to TestRunner*.
3678         (WebCore::DumpRenderTree::dump):
3679             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3680             Instead we should rely on TestRunner::generatePixelResults().
3681         * DumpRenderTree/qt/TestRunnerQt.cpp:
3682         (TestRunnerQt::reset):
3683         * DumpRenderTree/qt/TestRunnerQt.h:
3684         (TestRunnerQt):
3685
3686 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3687
3688         Implement FontLoader interface
3689         https://bugs.webkit.org/show_bug.cgi?id=98395
3690
3691         Reviewed by Eric Seidel.
3692
3693         Enable FontLoadEvents runtime flag for TestShell.
3694
3695         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3696         (WebTestRunner::TestInterfaces::TestInterfaces):
3697
3698 2013-03-13  Julie Parent  <jparent@chromium.org>
3699
3700         CLeanup: remove unnecessary call to parseParameters.
3701         https://bugs.webkit.org/show_bug.cgi?id=112309
3702
3703         Reviewed by Ojan Vafai.
3704         
3705         We call parseCrossDashboardParameters when the dashboard initially
3706         loads to set the state required for loadBuildersList, and then we
3707         call it again once we are fully done with loading, so there is no
3708         reason to call it in the middle of the loading process here.
3709
3710         * TestResultServer/static-dashboards/loader.js:
3711         (.):
3712
3713 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3714
3715         Unreviewed. Now I'm a reviewer :)
3716
3717         * Scripts/webkitpy/common/config/committers.py:
3718
3719 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3720
3721         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3722         https://bugs.webkit.org/show_bug.cgi?id=112277
3723
3724         Reviewed by Adam Barth.
3725
3726         * Scripts/webkitperl/FeatureList.pm:
3727         * qmake/mkspecs/features/features.pri:
3728
3729 2013-03-13  Adam Barth  <abarth@webkit.org>
3730
3731         run-perf-tests should support content_shell
3732         https://bugs.webkit.org/show_bug.cgi?id=112291
3733
3734         Reviewed by Eric Seidel.
3735
3736         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3737         (PerfTestsRunner._parse_args):
3738
3739 2013-03-13  Oliver Hunt  <oliver@apple.com>
3740
3741         Simplify Checked<> multiplication
3742         https://bugs.webkit.org/show_bug.cgi?id=112286
3743
3744         Reviewed by James Robinson.
3745
3746         Add tests for multiplication by zero and max to ensure we don't
3747         mess them up should we ever make changes to Checked<> in future.
3748
3749         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3750         (TestWebKitAPI):
3751
3752 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3753
3754         [Qt] Unreviewed prospective Windows build fix
3755
3756         Do the usual thing, include the moc generated code in the .cpp file instead
3757         of compiling it standalone, to ensure that config.h is included, too, and
3758         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3759
3760         * DumpRenderTree/qt/EventSenderQt.cpp:
3761
3762 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3763
3764         [Qt] Port TestRunner::findString to shared interface
3765         https://bugs.webkit.org/show_bug.cgi?id=112147
3766
3767         Reviewed by Jocelyn Turcotte.
3768
3769         This patch also removes DumpRenderTree and some other helper classes from
3770         the WebCore namespace, to which they do not really belong.
3771
3772         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3773         (main):
3774         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3775         (DumpRenderTree::DumpRenderTree):
3776         (DumpRenderTree::~DumpRenderTree):
3777         (DumpRenderTree::instance):
3778         (DumpRenderTree::setShouldTimeout):
3779         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3780         (DumpRenderTree):
3781         * DumpRenderTree/qt/EventSenderQt.cpp:
3782         (EventSender::contextClick):
3783         (EventSender::sendEvent):
3784         (EventSender::postEvent):
3785         * DumpRenderTree/qt/EventSenderQt.h:
3786         (EventSender::isGraphicsBased):
3787         * DumpRenderTree/qt/TestRunnerQt.cpp:
3788         (TestRunnerQt::TestRunnerQt):
3789         (TestRunner::findString):
3790         (TestRunnerQt::setMockDeviceOrientation):
3791         (TestRunnerQt::setGeolocationPermission):
3792         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3793         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3794         (TestRunnerQt::setMockGeolocationPosition):
3795         * DumpRenderTree/qt/TestRunnerQt.h:
3796         (TestRunnerQt):
3797
3798 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3799
3800         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3801         https://bugs.webkit.org/show_bug.cgi?id=112129
3802
3803         Reviewed by Adam Barth.
3804
3805         Following Chromium
3806         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3807         this is being renamed to better explain what it does.
3808
3809         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3810
3811 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3812
3813         [Qt] Unreviewed trivial typo fix
3814
3815         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3816         TextRunner.h. Thanks Zeno :)
3817
3818 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3819
3820         [Qt] Prepare DRT for transition to shared TestRunner interface
3821         https://bugs.webkit.org/show_bug.cgi?id=112144
3822
3823         Reviewed by Benjamin Poulain.
3824
3825         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3826         the JSC C API based one.
3827
3828         This is impplemented by instantiating the QObject based testRunner in
3829         the global object, then instantiating the JSC C based TestRunner
3830         separately and placing it "behind" the QObject based testRunner through
3831         injection of the individual functions through proxies. (prototype
3832         chaining doesn't work due to the this object and Function.prototype.bind
3833         doesn't work due to the native function)
3834
3835         This allows for porting over method by method by removing the method
3836         from the QObject TestRunnerQt and implementing it in the JSC C based
3837         TestRunner.
3838
3839         In order for this to link and run dummy implementations of all the
3840         necessary TestRunner functions are provided.
3841
3842         * DumpRenderTree/qt/DumpRenderTree.pro:
3843         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3844         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3845         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3846         (WebCore::DumpRenderTree::initJSObjects):
3847         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3848         (DumpRenderTree):
3849         * DumpRenderTree/qt/TestRunnerQt.cpp:
3850         (TestRunner::~TestRunner):
3851         (TestRunner::addDisallowedURL):
3852         (TestRunner::queueLoad):
3853         (TestRunner::removeAllVisitedLinks):
3854         (TestRunner::setAcceptsEditing):
3855         (TestRunner::simulateLegacyWebNotificationClick):
3856         (TestRunner::setWindowIsKey):
3857         (TestRunner::setAlwaysAcceptCookies):
3858         (TestRunner::addOriginAccessWhitelistEntry):
3859         (TestRunner::setWebViewEditable):
3860         (TestRunner::clearAllApplicationCaches):
3861         (TestRunner::setTextDirection):
3862         (TestRunner::notifyDone):
3863         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3864         (TestRunner::overridePreference):
3865         (TestRunner::pathToLocalResource):
3866         (TestRunner::removeAllWebNotificationPermissions):
3867         (TestRunner::simulateWebNotificationClick):
3868         (TestRunner::closeIdleLocalStorageDatabases):
3869         (TestRunner::focusWebView):
3870         (TestRunner::setBackingScaleFactor):
3871         (TestRunner::removeChromeInputField):
3872         (TestRunner::addChromeInputField):
3873         (TestRunner::originsWithLocalStorage):
3874         (TestRunner::deleteAllLocalStorage):
3875         (TestRunner::deleteLocalStorageForOrigin):
3876         (TestRunner::observeStorageTrackerNotifications):
3877         (TestRunner::syncLocalStorage):
3878         (TestRunner::windowCount):
3879         (TestRunner::setWaitToDump):
3880         (TestRunner::waitForPolicyDelegate):
3881         (TestRunner::webHistoryItemCount):
3882         (TestRunner::showWebInspector):
3883         (TestRunner::closeWebInspector):
3884         (TestRunner::evaluateInWebInspector):
3885         (TestRunner::setSerializeHTTPLoads):
3886         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3887         (TestRunner::setCustomPolicyDelegate):
3888         (TestRunner::setDatabaseQuota):
3889         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3890         (TestRunner::resetPageVisibility):
3891         (TestRunner::keepWebHistory):
3892         (TestRunner::goBack):
3893         (TestRunner::originsWithApplicationCache):
3894         (TestRunner::applicationCacheDiskUsageForOrigin):
3895         (TestRunner::display):
3896         (TestRunner::dispatchPendingLoadRequests):
3897         (TestRunner::clearPersistentUserStyleSheet):
3898         (TestRunner::callShouldCloseOnWebView):
3899         (TestRunner::copyDecodedHostName):
3900         (TestRunner::clearBackForwardList):
3901         (TestRunner::clearAllDatabases):
3902         (TestRunner::clearApplicationCacheForOrigin):
3903         (TestRunner::apiTestGoToCurrentBackForwardItem):
3904         (TestRunner::authenticateSession):
3905         (TestRunner::abortModal):
3906         (TestRunner::setStorageDatabaseIdleInterval):
3907         (TestRunner::setAsynchronousSpellCheckingEnabled):
3908         (TestRunner::setXSSAuditorEnabled):
3909         (TestRunner::setSpatialNavigationEnabled):
3910         (TestRunner::setScrollbarPolicy):
3911         (TestRunner::setJavaScriptCanAccessClipboard):
3912         (TestRunner::setAutomaticLinkDetectionEnabled):
3913         (TestRunner::setUserStyleSheetEnabled):
3914         (TestRunner::setUserStyleSheetLocation):
3915         (TestRunner::setUseDashboardCompatibilityMode):
3916         (TestRunner::setTabKeyCyclesThroughElements):
3917         (TestRunner::setSmartInsertDeleteEnabled):
3918         (TestRunner::setSelectTrailingWhitespaceEnabled):
3919         (TestRunner::setPrivateBrowsingEnabled):
3920         (TestRunner::setPluginsEnabled):
3921         (TestRunner::setPopupBlockingEnabled):
3922         (TestRunner::setMockSpeechInputDumpRect):
3923         (TestRunner::setPersistentUserStyleSheetLocation):
3924         (TestRunner::setMockGeolocationPosition):
3925         (TestRunner::setMockGeolocationPositionUnavailableError):
3926         (TestRunner::setMockDeviceOrientation):
3927         (TestRunner::setMainFrameIsFirstResponder):
3928         (TestRunner::setIconDatabaseEnabled):
3929         (TestRunner::setGeolocationPermission):
3930         (TestRunner::setDefersLoading):
3931         (TestRunner::setCacheModel):
3932         (TestRunner::setAuthorAndUserStylesEnabled):
3933         (TestRunner::setAllowFileAccessFromFileURLs):
3934         (TestRunner::setAppCacheMaximumSize):
3935         (TestRunner::setAllowUniversalAccessFromFileURLs):
3936         (TestRunner::setApplicationCacheOriginQuota):
3937         (TestRunner::denyWebNotificationPermission):
3938         (TestRunner::grantWebNotificationPermission):
3939         (TestRunner::setValueForUser):
3940         (TestRunner::setViewModeMediaFeature):
3941         (TestRunner::setPageVisibility):
3942         (TestRunner::addMockSpeechInputResult):
3943         (TestRunner::removeOriginAccessWhitelistEntry):
3944         (TestRunner::addUserScript):
3945         (TestRunner::isCommandEnabled):
3946         (TestRunner::evaluateScriptInIsolatedWorld):
3947         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3948         (TestRunner::copyEncodedHostName):
3949         (TestRunner::addUserStyleSheet):
3950         (TestRunner::findString):
3951         (TestRunner::execCommand):
3952         (TestRunner::localStorageDiskUsageForOrigin):
3953
3954 2013-03-12  Julie Parent  <jparent@chromium.org>
3955
3956         Cleanup: Move flatten-trie to loader.
3957         https://bugs.webkit.org/show_bug.cgi?id=112196
3958
3959         Reviewed by Dirk Pranke.
3960
3961         flatten-trie is used only by the loader, so move it there and make it
3962         private, rather than global in dashbaord_base. Moved the corresponding
3963         unit test from flakiness_dashboard_unittests to loader_unittests.
3964         
3965         * TestResultServer/static-dashboards/dashboard_base.js:
3966         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3967         * TestResultServer/static-dashboards/loader.js:
3968         (.):
3969         * TestResultServer/static-dashboards/loader_unittests.js:
3970
3971 2013-03-12  Oliver Hunt  <oliver@apple.com>
3972
3973         Unbreak api tests
3974
3975         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3976         (TestWebKitAPI):
3977
3978 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3979
3980         Unreviewed, disabling tests for Win EWS.
3981
3982         win-ews obviously cannot keep up with running tests, it's >300 behind.
3983         Probably doesn't help that its (likely) running tests serially.
3984
3985         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3986         (WinEWS):
3987
3988 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3989
3990         Add a --build-directory argument to delete-stale-build-files
3991         https://bugs.webkit.org/show_bug.cgi?id=112198
3992
3993         Reviewed by Ryosuke Niwa.
3994
3995         * BuildSlaveSupport/delete-stale-build-files:
3996         (main): Add --build-directory argument.
3997
3998 2013-03-12  Oliver Hunt  <oliver@apple.com>
3999
4000         Appease MSVC
4001
4002         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4003         (TestWebKitAPI):
4004
4005 2013-03-12  Oliver Hunt  <oliver@apple.com>
4006
4007         Add more Checked<> tests
4008         https://bugs.webkit.org/show_bug.cgi?id=112190
4009
4010         Reviewed by Geoffrey Garen.
4011
4012         Tests!
4013
4014         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4015         (TestWebKitAPI):
4016
4017 2013-03-12  Julie Parent  <jparent@chromium.org>
4018
4019         Cleanup: Move loading complete function into callback, rather than global.
4020         https://bugs.webkit.org/show_bug.cgi?id=112167
4021
4022         Reviewed by Dirk Pranke.
4023         
4024         Stop calling global functions, pass in proper handler to Loader
4025         constructor. Note that the callback is optional, as tests, and
4026         some potential dashboards, do not need one.
4027
4028         * TestResultServer/static-dashboards/dashboard_base.js:
4029         * TestResultServer/static-dashboards/loader.js:
4030         (.):
4031         * TestResultServer/static-dashboards/loader_unittests.js:
4032
4033 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4034
4035         [EFL][WK2] Add popup menu support to MiniBrowser
4036         https://bugs.webkit.org/show_bug.cgi?id=108934
4037
4038         Reviewed by Kenneth Rohde Christiansen.
4039
4040         Implement popup menu support in MiniBrowser by handling popup_menu_show
4041         and popup_menu_hide smart functions on the view and using the Ewk popup
4042         menu API.
4043
4044         * MiniBrowser/efl/main.c:
4045         (_Browser_Window):
4046         (on_popup_menu_discarded):
4047         (on_popup_menu_item_clicked):
4048         (popup_menu_populate):
4049         (on_popup_menu_show):
4050         (on_popup_menu_hide):
4051         (window_create): Use calloc() instead of malloc() to allocate memory for
4052         Browser_Window. This makes sure all the structs members are initialized
4053         to 0 (such as the new elm_popup_menu pointer).
4054
4055 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
4056
4057         [GTK] Set up the libPlatformGtk.la library
4058         https://bugs.webkit.org/show_bug.cgi?id=111738
4059
4060         Reviewed by Martin Robinson.
4061
4062         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
4063         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
4064         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
4065
4066 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
4067
4068         [GTK] Enable Web Audio in development builds
4069         https://bugs.webkit.org/show_bug.cgi?id=111831
4070
4071         Reviewed by Philippe Normand.
4072
4073         Web Audio is already quite well supported on the GTK port but still has a few issues
4074         that must be addressed before it is enabled by default. Despite that it should be enabled
4075         in development builds just so we are up-to-date with future feature infrastructure changes.
4076         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
4077         that's an obvious goal before enabling the feature in release builds.
4078
4079         * Scripts/webkitperl/FeatureList.pm:
4080
4081 2013-03-11  Andreas Kling  <akling@apple.com>
4082
4083         [Mac][WK1] Add support for alert() in MiniBrowser.
4084         <http://webkit.org/b/112090>
4085
4086         Reviewed by Anders Carlsson.
4087
4088         * MiniBrowser/mac/WK1BrowserWindowController.m:
4089         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
4090
4091 2013-03-11  Julie Parent  <jparent@chromium.org>
4092
4093         Dashboard cleanup: Create ui.Errors
4094         https://bugs.webkit.org/show_bug.cgi?id=111785
4095
4096         Reviewed by Ojan Vafai.
4097         
4098         Create ui.Errors for handling errors the dashboards
4099         encounter. Loader now has a Error object that it can add to,
4100         and individual dashboards can show errors when desired.
4101         Currently, only flakiness_db shows errors, but this is 
4102         generic and there is no reason why other dbs wouldn't want to
4103         show errors.
4104
4105         * TestResultServer/static-dashboards/dashboard_base.js:
4106         (resourceLoadingComplete):
4107         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4108         (generatePage):
4109         * TestResultServer/static-dashboards/loader.js:
4110         (.):
4111         * TestResultServer/static-dashboards/ui.js:
4112         (.):
4113
4114 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
4115
4116         Some StringHasher tests are broken because of missing null termination
4117         https://bugs.webkit.org/show_bug.cgi?id=111284
4118
4119         Reviewed by Darin Adler.
4120
4121         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
4122         (TestWebKitAPI): Added null termination since C strings are null-terminated.
4123         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
4124         the bug caught by it is now fixed.
4125
4126 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
4127
4128         Unreviewed, rolling out r145200.
4129         http://trac.webkit.org/changeset/145200
4130         https://bugs.webkit.org/show_bug.cgi?id=112063
4131
4132         Broke a couple of unit tests (Requested by zdobersek on
4133         #webkit).
4134
4135         * Scripts/webkitperl/FeatureList.pm:
4136
4137 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
4138
4139         [GTK] WebKit2-only build fails
4140         https://bugs.webkit.org/show_bug.cgi?id=112033
4141
4142         Reviewed by Gustavo Noronha Silva.
4143
4144         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
4145         generic part, WebKit1-specific part and WebKit2-specific part.
4146         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
4147         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
4148         directly.
4149
4150 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
4151
4152         Adding myself to the committers list.
4153
4154         Unreviewed.
4155
4156         * Scripts/webkitpy/common/config/committers.py:
4157
4158 2013-03-11  Jeff Rogers  <jrogers@rim.com>
4159
4160         [BlackBerry] Disable MathML support
4161         https://bugs.webkit.org/show_bug.cgi?id=111929
4162
4163         Reviewed by Rob Buis.
4164
4165         * Scripts/webkitperl/FeatureList.pm:
4166
4167 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4168
4169         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
4170         https://bugs.webkit.org/show_bug.cgi?id=111970
4171
4172         Reviewed by Chris Fleizach.
4173
4174         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
4175         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
4176         undefined symbol.
4177
4178         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4179         (WTR::AccessibilityUIElement::supportedActions):
4180         (WTR):
4181
4182 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
4183
4184         [chromium] Android apk targets should depend directly on Java library targets
4185         https://bugs.webkit.org/show_bug.cgi?id=111746
4186
4187         Reviewed by Eric Seidel.
4188
4189         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4190         Make DumpRenderTree_apk depend directly on base_java and net_java.
4191         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
4192         Make TestWebKitAPI_apk depend directly on base_java.
4193
4194 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
4195
4196         [chromium] remove obsolete user gesture methods from WebFrame
4197         https://bugs.webkit.org/show_bug.cgi?id=111696
4198
4199         Reviewed by Adam Barth.
4200
4201         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
4202         (WebTestRunner::TestPlugin::handleInputEvent):
4203         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4204
4205 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
4206
4207         Unreviewed, add myself to commiters.py.
4208
4209         * Scripts/webkitpy/common/config/committers.py:
4210
4211 2013-03-08  Julie Parent  <jparent@chromium.org>
4212
4213         Cleanup: Remove dead code.
4214         https://bugs.webkit.org/show_bug.cgi?id=111900
4215
4216         Reviewed by Dirk Pranke.
4217         
4218         Treemap overrides a global function that used to be in 
4219         dashboard_base, but was removed months ago in
4220         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
4221         no caller. 
4222
4223         * TestResultServer/static-dashboards/treemap.html:
4224
4225 2013-03-08  Harald Alvestrand  <hta@chromium.org>
4226
4227         Implemented new API for RTCStatsReport object.
4228         https://bugs.webkit.org/show_bug.cgi?id=110333
4229
4230         Reviewed by Adam Barth.
4231
4232         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
4233         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
4234
4235 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
4236
4237         [chromium] use custom freetype on linux asan builds again
4238         https://bugs.webkit.org/show_bug.cgi?id=111884
4239
4240         Reviewed by Tony Chang.
4241
4242         We no longer need the workaround after chromium r186540.
4243
4244         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4245
4246 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
4247
4248         Warning about the user not having edit rights on Bugzilla is confusing new contributors
4249         https://bugs.webkit.org/show_bug.cgi?id=111798
4250
4251         Reviewed by Dirk Pranke.
4252
4253         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
4254
4255         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4256
4257 2013-03-08  James Robinson  <jamesr@chromium.org>
4258
4259         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
4260         https://bugs.webkit.org/show_bug.cgi?id=111632
4261
4262         Reviewed by Adrienne Walker.
4263
4264         * DumpRenderTree/chromium/WebViewHost.cpp:
4265         (WebViewHost::initializeLayerTreeView):
4266         * DumpRenderTree/chromium/WebViewHost.h:
4267         (WebViewHost):
4268
4269 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
4270
4271         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
4272         https://bugs.webkit.org/show_bug.cgi?id=111297
4273
4274         Reviewed by Kenneth Rohde Christiansen.
4275
4276         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4277         (WTR::TestRunner::setViewModeMediaFeature):
4278
4279 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
4280
4281         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
4282         https://bugs.webkit.org/show_bug.cgi?id=111814
4283
4284         Reviewed by Ryosuke Niwa.
4285
4286         Add the needed supportedActions() attribute to WKTestRunner.
4287
4288         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4289         (WTR::AccessibilityUIElement::supportedActions):
4290         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4291         (AccessibilityUIElement):
4292         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: