[Qt] Add eventSender.gestureTap
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2
3         [Qt] Add eventSender.gestureTap
4         https://bugs.webkit.org/show_bug.cgi?id=66173
5
6         Reviewed by Kenneth Rohde Christiansen.
7
8         Implement support for sending raw QGesture events.
9
10         * DumpRenderTree/qt/EventSenderQt.cpp:
11         (EventSender::EventSender):
12         (EventSender::gestureTap):
13         * DumpRenderTree/qt/EventSenderQt.h:
14         (EventSender):
15
16 2012-09-19  Sheriff Bot  <webkit.review.bot@gmail.com>
17
18         Unreviewed, rolling out r129007.
19         http://trac.webkit.org/changeset/129007
20         https://bugs.webkit.org/show_bug.cgi?id=97172
21
22         It broke the build on the Qt bots (Requested by Ossy on
23         #webkit).
24
25         * qmake/config.tests/gccdepends/empty.cpp:
26         * qmake/config.tests/gccdepends/gccdepends.pro:
27         * qmake/mkspecs/features/default_pre.prf:
28
29 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
30
31         run-perf-tests should record indivisual value instead of statistics
32         https://bugs.webkit.org/show_bug.cgi?id=97155
33
34         Reviewed by Hajime Morita.
35
36         Parse the list of indivisual value reported by tests and include them as "values".
37         We strip "values" from the output JSON when uploading it to the perf-o-matic
38         since it doesn't know how to parse "values" or ignore it.
39
40         * Scripts/webkitpy/performance_tests/perftest.py:
41         (PerfTest):
42         (PerfTest.parse_output): Parse and report "values".
43         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
44         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
45         (MainTest.test_parse_output):
46         (MainTest.test_parse_output_with_failing_line):
47         (TestPageLoadingPerfTest.test_run):
48         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
49         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
50         until we update perf-o-matic.
51         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
52         (test_run_memory_test):
53         (test_run_with_json_output):
54         (test_run_with_description):
55         (test_run_with_slave_config_json):
56         (test_run_with_multiple_repositories):
57
58 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
59
60         Fix regex groups for bug matching in flakiness dashboard.
61         https://bugs.webkit.org/show_bug.cgi?id=97152
62
63         Unreviewed, build fix.
64
65         * TestResultServer/static-dashboards/flakiness_dashboard.js:
66         (htmlForBugs):
67
68 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
69
70         nrwt: print unexpected results using new TestExpectations syntax
71         https://bugs.webkit.org/show_bug.cgi?id=97159
72
73         Unreviewed, build fix.
74
75         Change new-run-webkit-tests to print out failures using the new
76         syntax when there are unexpected results, e.g.:
77
78         52 tests ran as expected, 19 didn't:
79
80
81         Regressions: Unexpected failures : (2)
82           failures/flaky/text.html [ Failure ]
83           failures/unexpected/text-image-checksum.html [ Failure ]
84
85         and so forth
86
87         * Scripts/webkitpy/layout_tests/views/printing.py:
88         (Printer._print_unexpected_results):
89
90 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
91
92         update flakiness dashboard after cutover to new test expectations syntax
93         https://bugs.webkit.org/show_bug.cgi?id=97152
94
95         Unreviewed, build fix.
96
97         Handle (??) the new Bug notations as well. Hopefully we don't
98         still need the old ones.
99
100         * TestResultServer/static-dashboards/flakiness_dashboard.js:
101         (filterBugs):
102         (htmlForBugs):
103         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
104
105 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
106
107         update flakiness dashboard after cutover to new test expectations syntax
108         https://bugs.webkit.org/show_bug.cgi?id=97152
109
110         Reviewed by Ryosuke Niwa.
111
112         This change clones the TestExpectation parsing state machine
113         from python into javascript.
114
115         * TestResultServer/static-dashboards/flakiness_dashboard.js:
116         (parsedExpectations.lines.forEach):
117         (parsedExpectations):
118         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
119
120 2012-09-19  Dana Jansens  <danakj@chromium.org>
121
122         Add backer@chromium.org as contributor
123         https://bugs.webkit.org/show_bug.cgi?id=97150
124
125         * Scripts/webkitpy/common/config/committers.py:
126
127 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
128
129         fix MISSING after TestExpectations conversion
130         https://bugs.webkit.org/show_bug.cgi?id=97148
131
132         Unreviewed, expectations change / build fix.
133
134         * Scripts/convert-test-expectations:
135         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
136         (TestExpectationParser):
137
138 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
139
140         nrwt: convert chromium TestExpectations to the new syntax
141         https://bugs.webkit.org/show_bug.cgi?id=97139
142
143         Reviewed by Ryosuke Niwa.
144     
145         Add in a file temporarily that does the conversion of
146         test expectations formats
147
148         * Tools/Scripts/convert-test-expectations: Added.
149
150 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
151
152         REGRESSION: run-perf-tests no longer reports the total test time
153         https://bugs.webkit.org/show_bug.cgi?id=97138
154
155         Reviewed by Tony Chang.
156
157         Report the finished time as a info-level log as opposed to a debug level log.
158
159         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
160         (PerfTestsRunner._run_single_test):
161         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
162         (MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
163         (test_run_test_pause_before_testing):
164         (test_run_test_set_for_parser_tests):
165         (test_run_memory_test):
166         (_test_run_with_json_output):
167
168 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
169
170         Support new TestExpectations format alongside old one
171         https://bugs.webkit.org/show_bug.cgi?id=96588
172
173         Reviewed by Ojan Vafai.
174
175         This patch adds support for actually reading in lines formatted
176         in the new style, and when we re-serialize/write out the file,
177         all lines will be written in the new style. Note that reading in
178         the old style is still supported, and no updates are being made
179         to the actual TestExpectations files as part of this change.
180
181         This change updates most but not all of the unit tests to use
182         the new syntax. I will update the rest when (or before where
183         possible) I drop support for the old format.
184
185         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
186         (TestExpectationParser):
187         (TestExpectationParser._tokenize_line):
188         (TestExpectationParser._tokenize_line_using_new_format):
189         (TestExpectationLine.to_string):
190         (TestExpectationLine._format_line):
191         (TestExpectations):
192         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
193         (test_parse_warning):
194         (SkippedTests.test_skipped_entry_dont_exist):
195         (NewExpectationSyntaxTests.test_warnings):
196         (RemoveConfigurationsTest.test_remove):
197         (test_remove_line):
198         (RebaseliningTest.test_remove):
199         (RebaseliningTest.test_no_get_rebaselining_failures):
200         (TestExpectationParserTests.test_tokenize_blank):
201         (TestExpectationParserTests.test_tokenize_extra_colon):
202         (TestExpectationParserTests.test_tokenize_missing_equal):
203         (TestExpectationParserTests.test_tokenize_extra_equal):
204         (TestExpectationSerializationTests.test_unparsed_to_string):
205         (TestExpectationSerializationTests.test_unparsed_list_to_string):
206         (TestExpectationSerializationTests.test_parsed_to_string):
207         (TestExpectationSerializationTests.test_format_line):
208         (TestExpectationSerializationTests.test_string_roundtrip):
209         (TestExpectationSerializationTests.test_list_roundtrip):
210         (TestExpectationSerializationTests.test_reconstitute_only_these):
211         (TestExpectationSerializationTests.test_string_whitespace_stripping):
212         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
213         (LintTest.test_lint_test_files__errors):
214         * Scripts/webkitpy/tool/commands/queries_unittest.py:
215         (PrintExpectationsTest.test_basic):
216         (PrintExpectationsTest.test_multiple):
217         (PrintExpectationsTest.test_full):
218         (PrintExpectationsTest.test_exclude):
219         * Scripts/webkitpy/tool/commands/rebaseline.py:
220         (RebaselineExpectations.execute):
221         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
222         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
223         (test_rebaseline_updates_expectations_file):
224         (test_rebaseline_does_not_include_overrides):
225         (test_rebaseline_expectations_noop):
226         (test_overrides_are_included_correctly):
227
228 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
229
230         implement first part of support for the new TestExpectations syntax
231         https://bugs.webkit.org/show_bug.cgi?id=96569
232
233         Reviewed by Ryosuke Niwa.
234
235         This patch implements support for parsing a line of the new
236         format for the TestExpectations file and converting it back into
237         the old format for compatibility. This routine is not yet used
238         by anything.
239
240         The new format is documented at:
241           http://trac.webkit.org/wiki/TestExpectations
242
243         but, in short:
244
245           [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]
246
247         - Comments are indicated with "#" instead of "//"
248         - If no expectations are specified we default to Skip for
249           compatibility with the Skipped files (these two changes make
250           Skipped files a subset of TestExpectations files)
251
252         - All of the tokens are now CamelCase instead of ALLCAPS.
253         - FAIL -> Failure
254         - IMAGE -> ImageOnlyFailure
255         - WONTFIX -> WontFix
256         - modifiers refer to just the platforms and configurations
257           (release/debug) that the line applies to.
258         - WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
259           expectations
260         - expectations will typically be written out in lexicographic order
261         - We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
262           instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.
263
264         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
265         (TestExpectationParser):
266         (TestExpectationParser._tokenize_line_using_new_format):
267         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
268         (NewExpectationSyntaxTests):
269         (NewExpectationSyntaxTests.assert_exp):
270         (NewExpectationSyntaxTests.test_bare_name):
271         (NewExpectationSyntaxTests.test_bare_name_and_bugs):
272         (NewExpectationSyntaxTests.test_comments):
273         (NewExpectationSyntaxTests.test_config_modifiers):
274         (NewExpectationSyntaxTests.test_unknown_config):
275         (NewExpectationSyntaxTests.test_unknown_expectation):
276         (NewExpectationSyntaxTests.test_skip):
277         (NewExpectationSyntaxTests.test_slow):
278         (NewExpectationSyntaxTests.test_wontfix):
279         (NewExpectationSyntaxTests.test_blank_line):
280         (NewExpectationSyntaxTests.test_warnings):
281
282 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
283
284         nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
285         https://bugs.webkit.org/show_bug.cgi?id=96845
286
287         Reviewed by Ojan Vafai.
288
289         In preparation for the new TestExpectations syntax, we replace
290         all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
291         make switching to the new syntax lossless (i.e., we lose
292         information now, not then).
293
294         Note that we can still parse in results.json files that have the
295         old data for backwards compatibility.
296         
297
298         * Scripts/webkitpy/common/net/resultsjsonparser.py:
299         (JSONTestResult._failure_types_from_actual_result):
300         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
301         (ResultsJSONParserTest):
302         (test_basic):
303         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
304         (ResultSummaryTest.test_summarized_results_wontfix):
305         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
306         (JSONLayoutResultsGenerator):
307         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
308         (TestExpectations):
309         (TestExpectations.remove_pixel_failures):
310         (TestExpectations.has_pixel_failures):
311         (TestExpectations.suffixes_for_expectations):
312         (TestExpectations.get_rebaselining_failures):
313         (TestExpectations.remove_configuration_from_test):
314         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
315         (assert_bad_expectations):
316         (BasicTests):
317         (BasicTests.test_basic):
318         (MiscTests):
319         (MiscTests.test_multiple_results):
320         (MiscTests.test_result_was_expected):
321         (MiscTests.test_remove_pixel_failures):
322         (MiscTests.test_suffixes_for_expectations):
323         (test_get_expectations_string):
324         (test_parse_warning):
325         (test_error_on_different_platform):
326         (test_error_on_different_build_type):
327         (test_overrides):
328         (test_overrides__directory):
329         (test_overrides__duplicate):
330         (test_pixel_tests_flag):
331         (test_more_specific_override_resets_skip):
332         (SkippedTests.test_skipped_file_overrides_expectations):
333         (SkippedTests.test_skipped_dir_overrides_expectations):
334         (SkippedTests.test_skipped_file_overrides_overrides):
335         (SkippedTests.test_skipped_dir_overrides_overrides):
336         (ExpectationSyntaxTests.test_missing_colon):
337         (ExpectationSyntaxTests.test_too_many_equals_signs):
338         (SemanticTests.test_bug_format):
339         (SemanticTests.test_bad_bugid):
340         (SemanticTests.test_missing_bugid):
341         (SemanticTests.test_rebaseline):
342         (test_missing_file):
343         (test_more_modifiers):
344         (test_order_in_file):
345         (test_macro_overrides):
346         (RemoveConfigurationsTest.test_remove):
347         (test_remove_line):
348         (RebaseliningTest.test_remove):
349         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
350         * Scripts/webkitpy/layout_tests/models/test_failures.py:
351         (determine_result_type):
352         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
353         (test_test_expectations):
354         * Scripts/webkitpy/layout_tests/port/test.py:
355         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
356         (MainTest.test_missing_and_unexpected_results):
357         (MainTest.test_retrying_and_flaky_tests):
358         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
359         (TestExpectationsTestCase.test_valid_expectations):
360         * Scripts/webkitpy/tool/commands/queries_unittest.py:
361         (PrintExpectationsTest.test_basic):
362         (PrintExpectationsTest.test_multiple):
363         (PrintExpectationsTest.test_full):
364         (PrintExpectationsTest.test_exclude):
365         (PrintExpectationsTest.test_csv):
366         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
367         (test_rebaseline_does_not_include_overrides):
368         (test_overrides_are_included_correctly):
369
370 2012-09-19  Dominic Mazzoni  <dmazzoni@google.com>
371
372         AX: A few control types are returning the wrong answer for isReadOnly
373         https://bugs.webkit.org/show_bug.cgi?id=96735
374
375         Reviewed by Chris Fleizach.
376
377         Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.
378
379         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
380         (AccessibilityUIElement::AccessibilityUIElement):
381         (AccessibilityUIElement::isReadOnlyGetterCallback):
382         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
383         (AccessibilityUIElement):
384
385 2012-09-19  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
386
387         [WTR] Memory leaks in TestRunner::deliverWebIntent()
388         https://bugs.webkit.org/show_bug.cgi?id=97111
389
390         Reviewed by Kenneth Rohde Christiansen.
391
392         Fix memory leaks in deliverWebIntent() by adopting strings
393         created with WKStringCreateWithUTF8CString().
394
395         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
396         (WTR::TestRunner::deliverWebIntent):
397
398 2012-09-19  Simon Hausmann  <simon.hausmann@digia.com>
399
400         [Qt] Fix incremental builds with all-in-one-files and gccdepends
401
402         Reviewed by Tor Arne Vestbø.
403
404         Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
405         are not only created for header files but also for .cpp files. AllInOne.cpp files
406         include other .cpp files, and when those are removed we need those dummy rules to
407         avoid a "No rule to make Foo.cpp required by AllInOne.o" error.
408
409         * qmake/config.tests/gccdepends/empty.cpp:
410         (main):
411         * qmake/config.tests/gccdepends/gccdepends.pro:
412         * qmake/mkspecs/features/default_pre.prf:
413
414 2012-09-19  Rick Byers  <rbyers@chromium.org>
415
416         Do touch adjustment on GestureTapDown
417         https://bugs.webkit.org/show_bug.cgi?id=96677
418
419         Reviewed by Antonio Gomes.
420
421         Allow radius to be set for GestureTapDown events.
422         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
423         (EventSender::gestureEvent):
424
425 2012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
426
427         [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
428         https://bugs.webkit.org/show_bug.cgi?id=97100
429
430         Reviewed by Gyuyoung Kim.
431
432         EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
433         preference, in order to match WebKitTestRunner functionality.
434
435         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
436         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
437         * DumpRenderTree/efl/TestRunnerEfl.cpp:
438         (TestRunner::overridePreference):
439
440 2012-09-18  Kangil Han  <kangil.han@samsung.com>
441
442         [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
443         https://bugs.webkit.org/show_bug.cgi?id=96181
444
445         Reviewed by Daniel Bates.
446
447         This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
448
449         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
450         (new):
451         (_parseLicenseBlock):
452         (_parseLicenseBlockFromFile):
453         (_defaultLicenseBlock):
454         (_licenseBlock):
455         (_generateHeaderFile):
456         (_generateImplementationFile):
457
458 2012-09-18  Byungwoo Lee  <bw80.lee@samsung.com>
459
460         Title string should be changed when document.title is set to ''.
461         https://bugs.webkit.org/show_bug.cgi?id=96793
462
463         Reviewed by Kenneth Rohde Christiansen.
464
465         Change dump format of dumpTitleChanges more understandable.
466         Uses single quotation marks for the title string.
467
468         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
469         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
470         * DumpRenderTree/chromium/WebViewHost.cpp:
471         (WebViewHost::didReceiveTitle):
472         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
473         (DumpRenderTreeChrome::onFrameTitleChanged):
474         * DumpRenderTree/gtk/DumpRenderTree.cpp:
475         (webViewTitleChanged):
476         * DumpRenderTree/mac/FrameLoadDelegate.mm:
477         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
478         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
479         (WebCore::DumpRenderTree::titleChanged):
480         * DumpRenderTree/win/FrameLoadDelegate.cpp:
481         (FrameLoadDelegate::didReceiveTitle):
482         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
483         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
484         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
485         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
486
487 2012-09-18  Szilard Ledan  <szledan@inf.u-szeged.hu>
488
489         EWS shouldn't sleep if there are new patches in its queue
490         https://bugs.webkit.org/show_bug.cgi?id=83038
491
492         Reviewed by Eric Seidel.
493
494         EWS tries to process a security patch. Of course it can't, because the EWS isn't
495         the member of the security group. But the problem is that after it can't process
496         the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
497         and push the security patch to the end of the queue.
498         Now it stays in the loop until it finds a patch or the queue gets empty.
499
500         * Scripts/webkitpy/tool/commands/queues.py:
501         (AbstractPatchQueue._next_patch):
502         * Scripts/webkitpy/tool/commands/queues_unittest.py:
503         (AbstractPatchQueueTest.test_next_patch):
504
505 2012-09-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
506
507         [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
508         https://bugs.webkit.org/show_bug.cgi?id=97014
509
510         Reviewed by Kenneth Rohde Christiansen.
511
512         According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
513         be used for literals rather than WTF::StringBuilder::append().
514
515         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
516         (WTR::InjectedBundle::booleanForKey):
517
518 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
519
520         Update my e-mail address.
521
522         * Scripts/webkitpy/common/config/committers.py:
523
524 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
525
526         Update my e-mail address.
527
528         Unreviewed.
529
530         * Scripts/webkitpy/common/config/committers.py:
531
532 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
533
534         [Qt] qt_webkit.pri should not be listed in Tools.pro
535
536         Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
537
538         Since r128751 the module pri file is auto-generated
539         but it was still listed in OTHER_FILES.
540
541         * Tools.pro: Remove unneeded line.
542
543 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
544
545         [Qt] Fix build with some versions of the gold linker
546
547         Reviewed by Tor Arne Vestbø.
548
549         Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
550         Instead run a compile/link test first to see if it works.
551
552         * qmake/config.tests/gnuld/gnuld.pro: Added.
553         * qmake/config.tests/gnuld/main.cpp: Added.
554         (main):
555         * qmake/mkspecs/features/unix/default_post.prf:
556
557 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
558
559         [Qt] Remove forced use of gold.
560
561         Reviewed by Tor Arne Vestbø.
562
563         The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
564         modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
565         often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
566
567         * qmake/mkspecs/features/unix/default_post.prf:
568
569 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
570
571         [Qt] Prospective Qt/Windows cross-compiling fix
572
573         Reviewed by Tor Arne Vestbø.
574
575         The win32 scope is not set when cross-compiling from Linux to Windows.
576
577         * qmake/mkspecs/features/functions.prf:
578
579 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
580
581         [EFL] Remove background view on EWebLauncher and MiniBrowser
582         https://bugs.webkit.org/show_bug.cgi?id=96905
583
584         Reviewed by Gyuyoung Kim.
585
586         The size of webview was changed after adding url bar.
587         And the background view is not necessary anymore, since it was used for debugging back in the day.
588
589         * EWebLauncher/main.c:
590         (_ELauncher):
591         (on_ecore_evas_resize):
592         (browserCreate):
593         * MiniBrowser/efl/main.c:
594         (_MiniBrowser):
595         (on_ecore_evas_resize):
596         (browserCreate):
597
598 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
599
600         [GTK] run-webkit-tests unable to find TestExpectations for WK2
601         https://bugs.webkit.org/show_bug.cgi?id=96998
602
603         Reviewed by Philippe Normand.
604
605         We should look for TestExpectations files in all the locations where
606         we currently look for Skipped files. This will allow
607         run-webkit-tests to look for TestExpectations files in
608         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
609
610         * Scripts/webkitpy/layout_tests/port/gtk.py:
611         (GtkPort.expectations_files):
612
613 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
614
615         [Qt] Fix build without the QtQuick module
616
617         Reviewed by Simon Hausmann.
618
619         * qmake/mkspecs/features/features.prf:
620
621 2012-09-18  Stephanie Lewis  <slewis@apple.com>
622
623         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
624
625         Unreviewed.
626
627         * DumpRenderTree/mac/DumpRenderTree.mm:
628         (poseAsClass):
629
630 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
631
632         Unreviewed update of email addresses for Berlin QtWebKit office.
633
634         * Scripts/webkitpy/common/config/committers.py:
635
636 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
637
638         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
639         https://bugs.webkit.org/show_bug.cgi?id=96899
640
641         Reviewed by Martin Robinson.
642
643         When overriding the 'WebKitDisplayImageKey' preference, use the
644         'auto-load-images' property of WebKitWebSettings as the property which
645         should be updated with the corresponding preference value.
646
647         * DumpRenderTree/gtk/DumpRenderTree.cpp:
648         (resetDefaultsToConsistentValues):
649         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
650         (TestRunner::overridePreference):
651
652 2012-09-17  Pratik Solanki  <psolanki@apple.com>
653
654         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
655         https://bugs.webkit.org/show_bug.cgi?id=96973
656
657         Reviewed by Dan Bernstein.
658
659         * DumpRenderTree/mac/Configurations/Base.xcconfig:
660         * WebKitTestRunner/Configurations/Base.xcconfig:
661         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
662
663 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
664
665         nrwt: remove "unexpected EOF" warnings
666         https://bugs.webkit.org/show_bug.cgi?id=96970
667
668         Reviewed by Ojan Vafai.
669
670         After debugging this a bit, it looks like there aren't any cases
671         that I can reproduce where a read() of zero indicates something
672         actually wrong; either it is a prelude to a crash, or a false
673         negative. So, I'm removing these warnings and adding a comment.
674
675         * Scripts/webkitpy/layout_tests/port/server_process.py:
676         (ServerProcess._wait_for_data_and_update_buffers_using_select):
677
678 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
679
680         [chromium] ASAN bot is crashing at the end of the run
681         https://bugs.webkit.org/show_bug.cgi?id=96967
682
683         Reviewed by Abhishek Arya.
684
685         The ASAN bot is crashing attempting to decode some output into
686         UTF-8; there's no reason to do this, so let's not do this and
687         see if something else is going on as well.
688
689         * Scripts/webkitpy/layout_tests/port/chromium.py:
690         (ChromiumPort._get_crash_log):
691
692 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
693
694         nrwt: --results-directory isn't getting printed properly
695         https://bugs.webkit.org/show_bug.cgi?id=96965
696
697         Reviewed by Ojan Vafai.
698
699         options.results_directory isn't actually initialized with the
700         default values until after we call print_config(), so this
701         changes things to print the value directly.
702
703         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
704         (run):
705         * Scripts/webkitpy/layout_tests/views/printing.py:
706         (Printer.print_config):
707         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
708         (Testprinter.test_print_config):
709
710 2012-09-17  Rob Buis  <rbuis@rim.com>
711
712         [BlackBerry] Enable VIDEO_TRACK
713         https://bugs.webkit.org/show_bug.cgi?id=96949
714
715         Reviewed by Antonio Gomes.
716
717         * Scripts/webkitperl/FeatureList.pm:
718
719 2012-09-17  Rick Byers  <rbyers@chromium.org>
720
721         Add handling of new GestureTapCancel in DRT
722
723         https://bugs.webkit.org/show_bug.cgi?id=96183
724
725         Reviewed by Antonio Gomes.
726
727         * DumpRenderTree/chromium/TestWebPlugin.cpp:
728         (TestWebPlugin::handleInputEvent):
729         * DumpRenderTree/chromium/EventSender.cpp:
730         (EventSender::gestureTapCancel):
731
732 2012-09-17  Philip Rogers  <pdr@google.com>
733
734         Teach style checker about preprocessor directive indentation rules
735         https://bugs.webkit.org/show_bug.cgi?id=96874
736
737         Reviewed by Adam Barth.
738
739         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
740         This is not explicit in our style guide but is generally followed in our code.
741         Searching for violations in our codebase shows these are rarely indented:
742             #include - indented in 6 files
743             #ifdef - indented in 0 files
744             #ifndef - indented in 1 file
745             #define - indented in 11 files
746             #if - indented in 7 files
747
748         * Scripts/webkitpy/style/checkers/cpp.py:
749         (check_directive_indentation):
750
751             This is the simple test where we look for spaces followed by a #.
752
753         (check_style):
754         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
755
756             A few tests needed to be modified because they had unintentionally indented
757             preprocessor directives.
758
759         (CppStyleTest.test_build_class.Foo):
760         (CppStyleTest.test_build_class):
761         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
762         (WebKitStyleTest.test_line_breaking):
763         (WebKitStyleTest.test_directive_indentation):
764
765 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
766
767         [Qt] Auto-generate the module pri file for QtWebKit
768
769         Reviewed by Simon Hausmann.
770
771         * qmake/qt_webkit.pri: Removed.
772
773 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
774
775         nrwt: --additional-platform-dir is broken on chromium ports
776         https://bugs.webkit.org/show_bug.cgi?id=96840
777
778         Reviewed by Ojan Vafai.
779
780         Looks like I broke this when cleaning things up as part of
781         adding ML support. Fixing and adding a test.
782
783         * Scripts/webkitpy/layout_tests/port/chromium.py:
784         (ChromiumPort.default_baseline_search_path):
785         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
786         (ChromiumAndroidPort.default_baseline_search_path):
787         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
788         (ChromiumLinuxPort.default_baseline_search_path):
789         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
790         (ChromiumMacPort.__init__):
791         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
792         (ChromiumWinPort.setup_environ_for_server):
793         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
794         (test_check_build):
795         (test_additional_platform_directory):
796
797 2012-09-13  Stephanie Lewis  <slewis@apple.com>
798
799         mac-future ignores previous platform TestExpectations.
800         https://bugs.webkit.org/show_bug.cgi?id=96718.
801
802         Reviewed by Dirk Pranke.
803
804         TestExpectations match an expectation's configuraton against a list of configurations that are 
805         valid for that port.  That list does not contain mac-future so none of the expectations can be
806         applied.
807
808         * Scripts/webkitpy/layout_tests/port/apple.py:
809         (ApplePort._generate_all_test_configurations):
810
811 2012-09-14  Adam Barth  <abarth@webkit.org>
812
813         Remove webkitPostMessage
814         https://bugs.webkit.org/show_bug.cgi?id=96577
815
816         Reviewed by Ojan Vafai.
817
818         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
819
820         * Scripts/webkitperl/FeatureList.pm:
821         * qmake/mkspecs/features/features.pri:
822
823 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
824
825         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
826         https://bugs.webkit.org/show_bug.cgi?id=96817
827
828         Reviewed by Kenneth Rohde Christiansen.
829
830         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
831         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
832         got overlooked when adding logging elsewhere.
833
834 2012-09-14  Peter Beverloo  <peter@chromium.org>
835
836         [Chromium] Build fix for DumpRenderTree following r128628
837         https://bugs.webkit.org/show_bug.cgi?id=96808
838
839         Reviewed by Tony Chang.
840
841         When building DumpRenderTree from the Chromium project, a compile error
842         shows up because including the header ForwardIOStreamsAndroid.h cannot
843         be located. TestWebKitAPI does this correctly.
844
845         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
846
847 2012-09-14  Dana Jansens  <danakj@chromium.org>
848
849         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
850         https://bugs.webkit.org/show_bug.cgi?id=96805
851
852         Reviewed by Dirk Pranke.
853
854         * Scripts/webkitpy/common/config/committers.py:
855         * Scripts/webkitpy/common/config/watchlist:
856
857 2012-09-14  Peter Beverloo  <peter@chromium.org>
858
859         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
860         https://bugs.webkit.org/show_bug.cgi?id=96687
861
862         Reviewed by Tony Chang.
863
864         Android's DumpRenderTree currently supports these arguments, implemented
865         as part of TestShellAndroid:
866         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
867
868         They're used by the layout test runner to get the STDOUT and STDERR while
869         a layout test run is in process, which is a safer alternative to parsing
870         all the logcat output manually. The implementation can be seen here:
871         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
872
873         This patch generalizes parsing of and applying the effects of these arguments
874         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
875         After this patch, this will make it possible to pull out the output-reading
876         code from Android's layout test port and generalize it so it can be re-used
877         in the new test-runner for the other two test suites.
878
879         This has no effect when compiling and running these tests as part of Chromium
880         code, which has a much more advanced test-runner that does parse complete log
881         output, but also directly depends on code licensed under Apache 2.
882
883         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
884         * DumpRenderTree/chromium/TestShellAndroid.cpp:
885         (platformInit):
886         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
887
888 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
889
890         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
891         https://bugs.webkit.org/show_bug.cgi?id=96656
892
893         Reviewed by Adam Barth.
894
895         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
896         macros in 1 line.
897
898         * Scripts/webkitpy/style/checkers/cpp.py:
899         (check_style.definitions):
900         (check_style): Add rule.
901         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
902         (WebKitStyleTest.test_line_breaking): Add unittest.
903
904 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
905
906         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
907         https://bugs.webkit.org/show_bug.cgi?id=57570
908
909         Reviewed by Kenneth Rohde Christiansen.
910
911         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
912         and dump the information expected by the test cases.
913
914         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
915         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
916         (WTR::InjectedBundle::beginTesting): Explicitly set the default
917         database quota.
918         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
919         (WTR::securityOriginToStr): New convenience function to convert
920         a security origin to the string expected in test results.
921         (WTR):
922         (WTR::InjectedBundlePage::InjectedBundlePage):
923         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
924         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
925         refactoring to share code with didExceedDatabaseQuota.
926         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
927         (InjectedBundlePage):
928         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
929         (WTR::TestRunner::TestRunner):
930         * WebKitTestRunner/InjectedBundle/TestRunner.h:
931         (WTR::TestRunner::dumpDatabaseCallbacks):
932         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
933         (TestRunner):
934
935 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
936
937         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
938
939         Rubber-stamped by Simon Hausmann.
940
941         * qmake/mkspecs/features/default_post.prf:
942
943 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
944
945         [Qt] Remove old cruft from the qmake build system
946
947         Rubber-stamped by Simon Hausmann.
948
949         * DumpRenderTree/qt/DumpRenderTree.pro:
950         * qmake/mkspecs/features/default_post.prf:
951
952 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
953
954         [Qt] Enable force_static_libs_as_shared for development
955
956         Not enabled for buildbots or production-builds (part of Qt5)
957
958         Reviewed by Simon Hausmann.
959
960         * qmake/mkspecs/features/default_post.prf:
961
962 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
963
964         [Qt] Make force_static_libs_as_shared work on Mac OS
965
966         We had to move a few LIBS += around that were in the wrong place,
967         and not caught when everything was just linked into the final
968         QtWebKit library.
969
970         Reviewed by Simon Hausmann.
971
972         * qmake/mkspecs/features/default_post.prf:
973         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
974
975 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
976
977         [Qt] Fix build of WTR on Windows
978
979         Reviewed by Tor Arne Vestbø.
980
981         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
982         With qmake's unix makefile generator as well as with the MingW generator,
983         the directory where the pro file lives (WTR/) is automatically added to
984         the include search path, but not so with MSVC. Instead of relying on qmake's
985         implicit feature here, add WTR/ explicitly to the include search path.
986
987         * WebKitTestRunner/Target.pri:
988
989 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
990
991         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
992         https://bugs.webkit.org/show_bug.cgi?id=42691
993
994         Reviewed by Kenneth Rohde Christiansen.
995
996         Add implementation for testrunner.setStopProvisionalFrameLoads()
997         in WebKitTestRunner.
998
999         Original patch by Alexey Proskuryakov.
1000
1001         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1002         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1003         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1004         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1005         (WTR::TestRunner::TestRunner):
1006         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1007         (TestRunner):
1008         (WTR::TestRunner::setStopProvisionalFrameLoads):
1009         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
1010
1011 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1012
1013         [Qt] Fix handling of debug/release/debug_and_release/build_all
1014
1015         We now pick up the defaults from Qt, in default_pre (CONFIG already
1016         contains the appropriate values for debug and release). We then let
1017         the command line arguments to qmake, or the project files themselves,
1018         override the configuration, and finally we sanitize the configuration
1019         in default_post.
1020
1021         Reviewed by Simon Hausmann.
1022
1023         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1024         * Scripts/webkitdirs.pm:
1025         (buildQMakeProjects):
1026         * qmake/mkspecs/features/default_post.prf:
1027         * qmake/mkspecs/features/default_pre.prf:
1028         * qmake/mkspecs/features/mac/default_pre.prf:
1029
1030 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1031
1032         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
1033         https://bugs.webkit.org/show_bug.cgi?id=42687
1034
1035         Reviewed by Kenneth Rohde Christiansen.
1036
1037         Implement testRunner.setTabKeyCyclesThroughElements for
1038         WebKitTestRunner.
1039
1040         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1041         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1042         (WTR::InjectedBundle::beginTesting):
1043         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1044         (WTR::TestRunner::setTabKeyCyclesThroughElements):
1045         (WTR):
1046         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1047         (TestRunner):
1048
1049 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1050
1051         EventSendingController::keyDown does not support non-array modifier arguments
1052         https://bugs.webkit.org/show_bug.cgi?id=96727
1053
1054         Reviewed by Kenneth Rohde Christiansen.
1055
1056         Add support for handling a string as modifier argument to
1057         EventSendingController::keyDown.
1058
1059         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1060         (WTR::parseModifierArray):
1061
1062 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1063
1064         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
1065         https://bugs.webkit.org/show_bug.cgi?id=42546
1066
1067         Reviewed by Kenneth Rohde Christiansen.
1068
1069         Exported TestRunner::setCustomPolicyDelegate() method.
1070         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
1071
1072         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1073         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1074         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1075
1076 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
1077
1078         [GTK] Clear application cache between tests in DumpRenderTree
1079         https://bugs.webkit.org/show_bug.cgi?id=96543
1080
1081         Reviewed by Philippe Normand.
1082
1083         Call the new DumpRenderTreeSupportGtk method to clear application cache
1084         after each test in DumpRenderTree.
1085
1086         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1087         as well. It's now being set in XvfbDriver._start so that each driver is assigned
1088         a cache directory that's constructed out of the driver's name and its worker
1089         number. These directories are located in the layout tests results directory.
1090         At least on the builders this ensures a driver-specific empty cache directory
1091         with each test run.
1092
1093         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1094         (runTest):
1095         * Scripts/webkitpy/layout_tests/port/gtk.py:
1096         (GtkPort.setup_environ_for_server):
1097         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1098         (XvfbDriver._start):
1099
1100 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
1101
1102         [Qt] Fix linking on Windows
1103
1104         Reviewed by Tor Arne Vestbø.
1105
1106         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
1107         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
1108         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
1109         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
1110
1111         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
1112         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
1113         after the module. Therefore QT did never contain webkit anymore and we always passed
1114         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
1115
1116         This patch introduces a creating_module configuration that is used to
1117         scope the qt/pkgconfig sanitization.
1118
1119         * qmake/mkspecs/features/default_post.prf:
1120
1121 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1122
1123         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
1124         https://bugs.webkit.org/show_bug.cgi?id=96740
1125
1126         Reviewed by Kenneth Rohde Christiansen.
1127
1128         Dump information expected by the test cases about the following
1129         frame load callbacks:
1130         "didDisplayInsecureContentForFrame"
1131         "didRunInsecureContentForFrame"
1132         "didDetectXSSForFrame"
1133
1134         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1135         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
1136         as expected by test results by calling pathSuitableForTestResult() instead
1137         of printing raw URL.
1138         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
1139         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
1140         (WTR::InjectedBundlePage::didDetectXSSForFrame):
1141
1142 2012-09-14  Peter Beverloo  <peter@chromium.org>
1143
1144         The runtime/unsigned category should be valid in the cpp style-checker.
1145         https://bugs.webkit.org/show_bug.cgi?id=96748
1146
1147         Reviewed by Csaba Osztrogonác.
1148
1149         This is causing the webkitpy tests to fail because it's not listed in the
1150         category array. Furthermore, change an "int" to "long" because it's
1151         throwing a double error in one of the earlier asserts.
1152
1153         * Scripts/webkitpy/style/checkers/cpp.py:
1154         (CppChecker):
1155         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1156         (WebKitStyleTest.test_names):
1157
1158 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1159
1160         Evas_Object* is a ref'ed structure, so tread it as such
1161         https://bugs.webkit.org/show_bug.cgi?id=96659
1162
1163         Reviewed by Adam Barth.
1164
1165         Replace OwnPtr<Evas_Object> with RefPtr.
1166
1167         * DumpRenderTree/efl/ImageDiff.cpp:
1168         (calculateDifference):
1169         (printImageDifferences):
1170         (readImageFromStdin):
1171         (main):
1172
1173 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1174
1175         Unreviewed, rolling out r128507.
1176         http://trac.webkit.org/changeset/128507
1177         https://bugs.webkit.org/show_bug.cgi?id=96659
1178
1179         Revert. r128507 makes too many crashes in EFL layout test bots.
1180
1181         * DumpRenderTree/efl/ImageDiff.cpp:
1182         (calculateDifference):
1183         (printImageDifferences):
1184         (readImageFromStdin):
1185         (main):
1186
1187 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
1188
1189         Make compile with both OS(WINCE) and PLATFORM(QT) support
1190         https://bugs.webkit.org/show_bug.cgi?id=95536
1191
1192         Reviewed by Simon Hausmann.
1193
1194         Fix wince support in qmake files
1195
1196         * Tools.pro:
1197         * qmake/mkspecs/features/configure.prf:
1198         * qmake/mkspecs/features/default_post.prf:
1199         * qmake/mkspecs/features/features.prf:
1200         * qmake/mkspecs/features/functions.prf:
1201
1202 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
1203
1204         [WK2] Add color picker API support for WebKit2
1205         https://bugs.webkit.org/show_bug.cgi?id=95058
1206
1207         Reviewed by Gyuyoung Kim.
1208
1209         Initialization code for color picker callbacks in UI client.
1210
1211         * MiniBrowser/mac/BrowserWindowController.m:
1212         (-[BrowserWindowController awakeFromNib]):
1213         * MiniBrowser/win/BrowserView.cpp:
1214         (BrowserView::create):
1215         * WebKitTestRunner/TestController.cpp:
1216         (WTR::TestController::createOtherPage):
1217         (WTR::TestController::initialize):
1218
1219 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
1220
1221         Upgrade yutak to reviewer
1222         https://bugs.webkit.org/show_bug.cgi?id=96721
1223
1224         Reviewed by Kent Tamura.
1225
1226         * Scripts/webkitpy/common/config/committers.py:
1227
1228 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1229
1230         Make the style checker report usage of "unsigned int"
1231         https://bugs.webkit.org/show_bug.cgi?id=96693
1232
1233         Reviewed by Dirk Pranke.
1234
1235         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
1236
1237         * Scripts/webkitpy/style/checkers/cpp.py:
1238         (check_language):
1239
1240 2012-09-13  Philip Rogers  <pdr@google.com>
1241
1242         Add gender-neutral form of webkit-patch land-cowboy
1243         https://bugs.webkit.org/show_bug.cgi?id=96709
1244
1245         Reviewed by Adam Barth.
1246
1247         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
1248
1249         * Scripts/webkitpy/tool/commands/download.py:
1250         (LandCowhand):
1251
1252 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
1253
1254         [EFL] Remove some parameters in browserCreate()
1255         https://bugs.webkit.org/show_bug.cgi?id=96499
1256
1257         Reviewed by Kenneth Rohde Christiansen.
1258
1259         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
1260         And I have moved some parameters into User_Arguments.
1261
1262         * EWebLauncher/main.c:
1263         (_User_Arguments):
1264         (_ELauncher):
1265         (on_key_down):
1266         (browserCreate):
1267         (findThemePath):
1268         (parseUserArguments):
1269         (main):
1270
1271 2012-09-13  Mark Lam  <mark.lam@apple.com>
1272
1273         Unreviewed. Adding myself to the committers list.
1274
1275         * Scripts/webkitpy/common/config/committers.py:
1276
1277 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1278
1279         run-perf-tests output cryptic error when the config file is missing.
1280         https://bugs.webkit.org/show_bug.cgi?id=96453
1281
1282         Reviewed by Tony Chang.
1283
1284         Add a special error message when a configuration file is missing.
1285
1286         Also update the help message of --source-json-path to signify the fact it specifies
1287         the configuration file on performance tests bots.
1288
1289         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1290         (PerfTestsRunner._parse_args):
1291         (PerfTestsRunner._generate_and_show_results):
1292         (PerfTestsRunner._merge_slave_config_json):
1293         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1294         (_test_run_with_json_output): Make upload to fail by default and assert the result
1295         in the function so that we can return logs instead.
1296         (_test_run_with_json_output.mock_upload_json):
1297         (test_run_with_json_output):
1298         (test_run_with_description):
1299         (test_run_respects_no_results):
1300         (test_run_with_slave_config_json):
1301         (test_run_with_bad_slave_config_json):
1302         (test_run_with_multiple_repositories):
1303
1304 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1305
1306         Evas_Object* is a ref'ed structure, so tread it as such
1307         https://bugs.webkit.org/show_bug.cgi?id=96659
1308
1309         Reviewed by Adam Barth.
1310
1311         Replace OwnPtr<Evas_Object> with RefPtr.
1312
1313         * DumpRenderTree/efl/ImageDiff.cpp:
1314         (calculateDifference):
1315         (printImageDifferences):
1316         (readImageFromStdin):
1317         (main):
1318
1319 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1320
1321         One more unreviewed trivial fix after r128399.
1322
1323         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
1324
1325 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1326
1327         Unreviewed trivial fix after r128399.
1328
1329         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
1330         (getLatestSVNRevision):
1331         (waitForSVNRevision):
1332
1333 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1334
1335         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
1336         https://bugs.webkit.org/show_bug.cgi?id=96366
1337
1338         Reviewed by Anders Carlsson.
1339
1340         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
1341         by calling shouldClose() on the FrameLoader.
1342
1343         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1344         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1345         (WTR::TestRunner::callShouldCloseOnWebView):
1346         (WTR):
1347         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1348         (TestRunner):
1349
1350 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1351
1352         Unreviewed, rolling out r128453.
1353         http://trac.webkit.org/changeset/128453
1354         https://bugs.webkit.org/show_bug.cgi?id=96681
1355
1356         Having tests use the same appcache directory leads to timeouts
1357         (Requested by zdobersek on #webkit).
1358
1359         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1360         (runTest):
1361         * Scripts/webkitpy/layout_tests/port/gtk.py:
1362         (GtkPort.setup_environ_for_server):
1363
1364 2012-09-13  James Robinson  <jamesr@chromium.org>
1365
1366         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
1367         https://bugs.webkit.org/show_bug.cgi?id=96678
1368
1369         Reviewed by Dirk Pranke.
1370
1371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1372         (.):
1373
1374 2012-09-13  Rob Buis  <rbuis@rim.com>
1375
1376         Unreviewed changes to watchlist.
1377
1378         - Add myself to BlackBerry bugs
1379
1380         * Scripts/webkitpy/common/config/watchlist:
1381
1382 2012-09-13  Stephen Chenney  <schenney@chromium.org>
1383
1384         Add an SVG entry to the watchlist
1385
1386         Unreviewed config change.
1387
1388         * Scripts/webkitpy/common/config/watchlist:
1389         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
1390         - Added myself and pdr as watchers
1391
1392 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1393
1394         [Qt] Make WebKit2 work on Windows with Qt 5
1395         https://bugs.webkit.org/show_bug.cgi?id=76776
1396
1397         Reviewed by Tor Arne Vestbø.
1398
1399         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
1400         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
1401         that for the GL TextureMapper (it's only built when that feature is set).
1402
1403         * qmake/mkspecs/features/configure.prf:
1404
1405 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1406
1407         [Qt] Ensure that QT is finalized before loading qt_module.prf
1408
1409         As qt_module.prf does dependency tracking based on the content of the
1410         QT variable. The intermediate WebKit modules modify the variable in
1411         their .pri files, so we have to ensure we've loaded all the modules
1412         before loading qt_module.
1413
1414         Reviewed by Tor Arne Vestbø.
1415         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
1416
1417         * qmake/mkspecs/features/default_post.prf:
1418         * qmake/mkspecs/features/webkit_modules.prf: Added.
1419
1420 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1421
1422         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
1423         https://bugs.webkit.org/show_bug.cgi?id=96633
1424
1425         Reviewed by Csaba Osztrogonác.
1426
1427         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
1428         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
1429         It's the usual problem and the usual solution is to rename one of the conflicting files.
1430         This patch chooses to rename DRT instead of WTR and MBR.
1431
1432         Fixed include order at the same time to match style guide.
1433
1434         * DumpRenderTree/qt/DumpRenderTree.pro:
1435         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
1436         (messageHandler):
1437         (isOption):
1438         (takeOptionValue):
1439         (printUsage):
1440         (main):
1441
1442 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1443
1444         The Script run-launcher should support -2 in combination with --efl
1445         https://bugs.webkit.org/show_bug.cgi?id=96639
1446
1447         Reviewed by Simon Hausmann.
1448
1449         Support running the MiniBrowser then supplied -2 as argument.
1450
1451         * Scripts/run-launcher:
1452
1453 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1454
1455         Unreviewed, add my Intel email address to the list.
1456
1457         * Scripts/webkitpy/common/config/committers.py:
1458
1459 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1460
1461         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
1462
1463         Reviewed by Ossy.
1464
1465         * qmake/mkspecs/features/default_post.prf:
1466
1467 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1468
1469         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
1470         https://bugs.webkit.org/show_bug.cgi?id=82294
1471
1472         Reviewed by Gyuyoung Kim.
1473
1474         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
1475
1476         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1477         (TestRunner::layerTreeAsText):
1478
1479 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1480
1481         [GTK] Clear application cache between tests in DumpRenderTree
1482         https://bugs.webkit.org/show_bug.cgi?id=96543
1483
1484         Reviewed by Philippe Normand.
1485
1486         Call the new DumpRenderTreeSupportGtk method to clear application cache
1487         after each test.
1488
1489         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1490         as well. Currently it points to a subdirectory in the layout tests results
1491         directory. At least on the builders this ensures an empty cache directory
1492         with each test run.
1493
1494         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1495         (runTest):
1496         * Scripts/webkitpy/layout_tests/port/gtk.py:
1497         (GtkPort.setup_environ_for_server):
1498
1499 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1500
1501         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
1502
1503         Unless it's actually a dependency of the public QtWebKit API.
1504
1505         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
1506         files with their _PRIVATE equivivalent, but that's likely to break when
1507         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
1508         clean up the variables in default_post.
1509
1510         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
1511         longer needed, as it was a workaround for the intermediate libraries ending
1512         up in the prl file. And, since CONFIG -= staticlib was there to support
1513         the explicitlib option, we can remove that too (as well as the exception
1514         for gprof, since it would be empty). If gprof needs tweaks to always link
1515         statically they should go in gprof.prf.
1516
1517         Reviewed by Simon Hausmann.
1518
1519         * qmake/mkspecs/features/default_post.prf:
1520         * qmake/mkspecs/features/functions.prf:
1521
1522 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
1523
1524         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
1525         https://bugs.webkit.org/show_bug.cgi?id=96632
1526
1527         Reviewed by Carlos Garcia Campos.
1528
1529         Fix this by using atk_object_get_n_accessible_children instead of
1530         calling getChildren() from childCount.
1531
1532         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
1533         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
1534         loop by using atk_object_get_n_accessible_children().
1535
1536 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1537
1538         [Qt][Win] Enable USE(3D_GRAPHICS)
1539         https://bugs.webkit.org/show_bug.cgi?id=90879
1540
1541         Reviewed by Kenneth Rohde Christiansen.
1542
1543         Enable it on Windows as well as on QNX (bug fixed).
1544
1545         * qmake/mkspecs/features/features.prf:
1546
1547 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1548
1549         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
1550         https://bugs.webkit.org/show_bug.cgi?id=96359
1551
1552         Reviewed by Tor Arne Vestbø.
1553
1554         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
1555         lexer. The only viable alternative I could find on Windows that provides
1556         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
1557         so let's use that one instead.
1558
1559         * Scripts/webkitdirs.pm:
1560         (checkRequiredSystemConfig):
1561         * qmake/mkspecs/features/default_pre.prf:
1562
1563 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1564
1565         [Qt] Add configuration for production builds
1566         https://bugs.webkit.org/show_bug.cgi?id=96607
1567
1568         Reviewed by Kenneth Rohde Christiansen.
1569
1570         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
1571         and enable all-in-one-files optimizations.
1572
1573         * qmake/mkspecs/features/production_build.prf: Added.
1574
1575 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1576
1577         [Qt] GStreamer detection does not work when cross-compiling
1578         https://bugs.webkit.org/show_bug.cgi?id=96608
1579
1580         Reviewed by Kenneth Rohde Christiansen.
1581
1582         When cross-compiling it is not safe to just use system(pkg-config),
1583         because there is a high probability that it will find packages in the
1584         host system instead of in the target one. Instead use qmake's new
1585         packagesExist() function that takes care of this delicate aspect of
1586         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
1587         PKG_CONFIG_LIBDIR accordingly.
1588
1589         * qmake/mkspecs/features/features.prf:
1590
1591 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
1592
1593         [WK2][WTR] More efficient string handling in InjectedBundlePage
1594         https://bugs.webkit.org/show_bug.cgi?id=96609
1595
1596         Reviewed by Kenneth Rohde Christiansen.
1597
1598         Update StringBuilder usage in InjectedBundlePage to follow
1599         the latest recommandations for efficient string handling:
1600         http://trac.webkit.org/wiki/EfficientStrings
1601
1602         This involves using appendLiteral() or appendNumber()
1603         instead of append() whenever possible.
1604
1605         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1606         (WTR::dumpPath):
1607         (WTR::rangeToStr):
1608         (WTR::styleDecToStr):
1609         (WTR::frameToStr):
1610         (WTR::dumpResourceURL):
1611         (WTR):
1612         (WTR::dumpFrameDescriptionSuitableForTestResult):
1613         (WTR::dumpRequestDescriptionSuitableForTestResult):
1614         (WTR::dumpResponseDescriptionSuitableForTestResult):
1615         (WTR::dumpErrorDescriptionSuitableForTestResult):
1616         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1617         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1618         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1619         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1620         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1621         (WTR::InjectedBundlePage::didFinishProgress):
1622         (WTR::dumpFrameScrollPosition):
1623         (WTR::dumpFrameText):
1624         (WTR::dumpDescendantFramesText):
1625         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1626         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1627         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1628         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1629         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1630         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1631         (WTR::InjectedBundlePage::willSendRequestForFrame):
1632         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1633         (WTR::InjectedBundlePage::didFinishLoadForResource):
1634         (WTR::InjectedBundlePage::didFailLoadForResource):
1635         (WTR::InjectedBundlePage::shouldCacheResponse):
1636         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1637         (WTR::InjectedBundlePage::willAddMessageToConsole):
1638         (WTR::InjectedBundlePage::willSetStatusbarText):
1639         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1640         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1641         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1642         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1643         (WTR::InjectedBundlePage::shouldBeginEditing):
1644         (WTR::InjectedBundlePage::shouldEndEditing):
1645         (WTR::InjectedBundlePage::shouldInsertNode):
1646         (WTR::InjectedBundlePage::shouldInsertText):
1647         (WTR::InjectedBundlePage::shouldDeleteRange):
1648         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1649         (WTR::InjectedBundlePage::shouldApplyStyle):
1650         (WTR::InjectedBundlePage::didBeginEditing):
1651         (WTR::InjectedBundlePage::didEndEditing):
1652         (WTR::InjectedBundlePage::didChange):
1653         (WTR::InjectedBundlePage::didChangeSelection):
1654         (WTR::InjectedBundlePage::supportsFullScreen):
1655         (WTR::InjectedBundlePage::enterFullScreenForElement):
1656         (WTR::InjectedBundlePage::exitFullScreenForElement):
1657         (WTR::InjectedBundlePage::beganEnterFullScreen):
1658         (WTR::InjectedBundlePage::beganExitFullScreen):
1659         (WTR::InjectedBundlePage::closeFullScreen):
1660         (WTR::dumpBackForwardListItem):
1661         (WTR::InjectedBundlePage::dumpBackForwardList):
1662
1663 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1664
1665         [Qt][WK2] Memory leaks in Qt's TestRunner
1666         https://bugs.webkit.org/show_bug.cgi?id=96603
1667
1668         Reviewed by Csaba Osztrogonác.
1669
1670         Fix memory leaks in Qt's TestRunner code by adopting WKString
1671         created with WKStringCreateWithUTF8CString().
1672
1673         * WebKitTestRunner/qt/TestControllerQt.cpp:
1674         (WTR::TestController::initializeInjectedBundlePath):
1675         (WTR::TestController::initializeTestPluginDirectory):
1676
1677 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1678
1679         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
1680         https://bugs.webkit.org/show_bug.cgi?id=96506
1681
1682         Reviewed by Dirk Pranke.
1683
1684         Lower the timeout value to 6 seconds for release configuration and 12 seconds
1685         for debug configuration. These are the same values the Chromium port uses.
1686
1687         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
1688         the layout tests under WebKit2 generally) requires more attention and gardening
1689         than what the current effort produces.
1690
1691         The unit test is updated as well to test these changes.
1692
1693         * Scripts/webkitpy/layout_tests/port/gtk.py:
1694         (GtkPort.default_timeout_ms):
1695         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1696         (GtkPortTest.test_default_timeout_ms):
1697         (GtkPortTest.assertLinesEqual):
1698
1699 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
1700
1701         Add SVN mirror handling feature to build.webkit.org
1702         https://bugs.webkit.org/show_bug.cgi?id=85887
1703
1704         Reviewed by Dirk Pranke.
1705
1706         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
1707         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1708         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
1709         (ConfigureBuild.start):
1710         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
1711         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
1712         (Factory.__init__):
1713         (BuildFactory.__init__):
1714         (TestFactory.__init__):
1715         (BuildAndTestFactory.__init__):
1716         (BuildAndPerfTestFactory.__init__):
1717         (BuildAndPerfTestWebKit2Factory.__init__):
1718         (DownloadAndPerfTestFactory.__init__):
1719         (DownloadAndPerfTestWebKit2Factory.__init__):
1720         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
1721         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1722         (SVNMirrorTest):
1723         (SVNMirrorTest.setUp): Load config.json once at startup.
1724         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
1725         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
1726         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
1727         (getLatestSVNRevision): Get the latest SVN revison from the given server.
1728         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
1729                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
1730
1731 2012-09-12  Kangil Han  <kangil.han@samsung.com>
1732
1733         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
1734         https://bugs.webkit.org/show_bug.cgi?id=81606
1735
1736         Reviewed by Tim Horton.
1737
1738         6 seconds is harsh for some jquery test cases.
1739         Therefore, adjust the value to match DumpRenderTree.
1740
1741         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1742         (WTR):
1743
1744 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
1745
1746         [EFL] Support download attribute feature
1747         https://bugs.webkit.org/show_bug.cgi?id=96462
1748
1749         Reviewed by Gyuyoung Kim.
1750
1751         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
1752         and add "download,request" callback to the DumpRenderTree for EFL.
1753
1754         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1755         (DumpRenderTreeChrome::createView):
1756         (DumpRenderTreeChrome::onDownloadRequest):
1757         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1758         (DumpRenderTreeChrome):
1759         * Scripts/webkitperl/FeatureList.pm:
1760
1761 2012-09-12  Stephanie Lewis  <slewis@apple.com>
1762
1763         Reduce parallism on the wk2 testers.
1764         https://bugs.webkit.org/show_bug.cgi?id=95906
1765
1766         Reviewed by Dirk Pranke.
1767
1768         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
1769         resource contention.  Reducing the number of processes alleviates the issue.  
1770
1771         Starting by reducing 25%.
1772
1773         * Scripts/webkitpy/layout_tests/port/mac.py:
1774         (MacPort.default_child_processes):
1775
1776 2012-09-12  Brady Eidson  <beidson@apple.com>
1777
1778         Assert in NetscapePlugin::destroy() with async plugin init
1779         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
1780
1781         Reviewed by Anders Carlsson.
1782
1783         Expose NPN_Invoke to plug-in tests:
1784         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1785         (PluginTest::NPN_Invoke):
1786         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1787         (PluginTest):
1788
1789         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
1790         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
1791         (InvokeDestroysPluginWithinNPP_New):
1792         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
1793         (InvokeDestroysPluginWithinNPP_New::NPP_New):
1794         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1795
1796 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1797
1798         refactor TestExpectations tokenization slightly in preparation for the new syntax
1799         https://bugs.webkit.org/show_bug.cgi?id=96564
1800
1801         Reviewed by Ojan Vafai.
1802
1803         This change changes how we will tokenize/lex the
1804         TestExpectations files, in preparation for supporting both the
1805         old syntax and the new one. This change by itself should be a
1806         no-op.
1807
1808         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1809         (TestExpectationParser._tokenize_line):
1810         (TestExpectationParser):
1811         (TestExpectationParser._tokenize_line_using_old_format):
1812         (TestExpectationParser._tokenize_line_using_new_format):
1813
1814 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1815
1816         remove unused testexpectations editing code from webkitpy, garden-o-matic
1817         https://bugs.webkit.org/show_bug.cgi?id=96562
1818
1819         Reviewed by Adam Barth.
1820
1821         This code was prototyped but never fully realized. Removing
1822         until it reanimates :).
1823
1824         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1825         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1826         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
1827         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
1828         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1829         (BuildCoverageExtrapolator.extrapolate_test_configurations):
1830         (GardeningHTTPRequestHandler._run_webkit_patch):
1831         (GardeningHTTPRequestHandler.ping):
1832         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1833         (BuildCoverageExtrapolatorTest.test_extrapolate):
1834         (GardeningServerTest.test_rebaseline_new_port):
1835
1836 2012-09-12  Lucas Forschler  <lforschler@apple.com>
1837
1838         Remove unused bot, apple-xserve-1.
1839         https://bugs.webkit.org/show_bug.cgi?id=96570
1840         
1841         Reviewed by Stephanie Lewis.
1842
1843         * BuildSlaveSupport/build.webkit.org-config/config.json:
1844
1845 2012-09-12  Xan Lopez  <xlopez@igalia.com>
1846
1847         [GTK] We attempt to rebase documentation even if it's not present
1848         https://bugs.webkit.org/show_bug.cgi?id=96553
1849
1850         Reviewed by Martin Robinson.
1851
1852         Do not make the documentation rebase step fatal. This allows make
1853         install to succeed when there's no documentation generated.
1854
1855         * gtk/generate-gtkdoc:
1856
1857 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1858
1859         Respect WEBKITOUTPUTDIR when running EFL tests
1860         https://bugs.webkit.org/show_bug.cgi?id=96528
1861
1862         Reviewed by Dirk Pranke.
1863
1864         Expose user set WEBKITOUTPUTDIR to the web process.
1865
1866         * Scripts/webkitpy/layout_tests/port/driver.py:
1867         (Driver._start): Add WEBKITOUTPUTDIR to the environment
1868         of the web process and its potential jhbuild wrapper.
1869
1870 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1871
1872         webkitdirs: fix uname version handling for cygwin
1873         https://bugs.webkit.org/show_bug.cgi?id=96436
1874
1875         Reviewed by Jon Honeycutt.
1876
1877         Newer versions of cygwin embed an additional version string
1878         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
1879         Update the code to handle that.
1880
1881         * Scripts/webkitdirs.pm:
1882         (setupAppleWinEnv):
1883
1884 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1885
1886         Regression(r128338): Broke Windows build
1887         https://bugs.webkit.org/show_bug.cgi?id=96537
1888
1889         Unreviewed build fix.
1890
1891         Fix Apple-Win build by allocating array dynamically
1892         since its size is not constant.
1893
1894         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1895         (WTR::stringArrayToJS):
1896
1897 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
1898
1899         [chromium] Add a virtual test suite for fast/hidpi
1900         https://bugs.webkit.org/show_bug.cgi?id=90192
1901
1902         Reviewed by Dirk Pranke.
1903
1904         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
1905         on the hardware accelerated path as the software path.
1906
1907         * DumpRenderTree/chromium/WebPreferences.cpp:
1908         (WebPreferences::applyTo):
1909         * Scripts/webkitpy/layout_tests/port/chromium.py:
1910         (ChromiumPort.virtual_test_suites):
1911
1912 2012-09-12  Adam Klein  <adamk@chromium.org>
1913
1914         [chromium] Add content_browsertests to the flakiness dashboard
1915         https://bugs.webkit.org/show_bug.cgi?id=96535
1916
1917         Reviewed by Ojan Vafai.
1918
1919         * TestResultServer/static-dashboards/dashboard_base.js:
1920
1921 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1922
1923         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
1924         https://bugs.webkit.org/show_bug.cgi?id=96496
1925
1926         Reviewed by Kenneth Rohde Christiansen.
1927
1928         Add implementation for originsWithApplicationCache to
1929         WebKitTestRunner.
1930
1931         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1932         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1933         (WTR::stringArrayToJS):
1934         (WTR):
1935         (WTR::TestRunner::originsWithApplicationCache):
1936         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1937         (TestRunner):
1938
1939 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1940
1941         Fix Qt/Windows build with Python3
1942         https://bugs.webkit.org/show_bug.cgi?id=96473
1943
1944         Reviewed by Csaba Osztrogonác.
1945
1946         In Python 3 print is a real function, so we must use parentheses around
1947         the function parameters. This is backwards compatible with Python 2.
1948
1949         * Scripts/generate-win32-export-forwards:
1950
1951 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1952
1953         Unreviewed trivial build fix for Qt/Windows after bug #96358.
1954
1955         As pointed out by Kevin, we should inject the "set PATH=..." statement
1956         to add the GnuWin32 directory only if that directory actually exists.
1957
1958         * qmake/mkspecs/features/default_post.prf:
1959
1960 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1961
1962         [EFL] [WK2] Memory leaks in TestControllerEfl
1963         https://bugs.webkit.org/show_bug.cgi?id=96525
1964
1965         Reviewed by Kenneth Rohde Christiansen.
1966
1967         Fix memory leaks in EFL's TestRunner code by adopting an allocation
1968         of WKString created with WKStringCreateWithUTF8CString().
1969
1970         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1971         (WTR::TestController::initializeInjectedBundlePath):
1972         (WTR::TestController::initializeTestPluginDirectory):
1973
1974 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1975
1976         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1977         https://bugs.webkit.org/show_bug.cgi?id=96374
1978
1979         Reviewed by Kenneth Rohde Christiansen.
1980
1981         Implement support for dumpApplicationCacheDelegateCallbacks
1982         and disallowIncreaseForApplicationCacheQuota in
1983         WebKitTestRunner and properly dump the information
1984         expected by the tests.
1985
1986         If the application cache quota is reached for a given
1987         security origin, WebKitTestRunner will reset the quota
1988         to its default value, unless intructed not to via
1989         disallowIncreaseForApplicationCacheQuota().
1990
1991         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1992         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1993         (WTR::InjectedBundlePage::InjectedBundlePage):
1994         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1995         (WTR):
1996         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1997         (InjectedBundlePage):
1998         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1999         (WTR::TestRunner::TestRunner):
2000         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
2001         (WTR):
2002         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2003         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
2004         (TestRunner):
2005         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
2006         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
2007
2008 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
2009
2010         [chromium] remove deprecated and unused sets import from chromium_android driver
2011         https://bugs.webkit.org/show_bug.cgi?id=96485
2012
2013         Reviewed by Dirk Pranke.
2014
2015         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2016
2017 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
2018
2019         Flakiness dashboard doesn't recognize new Chromium Android test builder
2020         https://bugs.webkit.org/show_bug.cgi?id=96523
2021
2022         Reviewed by Ojan Vafai.
2023
2024         Properly return 'ANDROID' as the Chromium platform for Android builders.
2025
2026         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2027         (chromiumPlatform):
2028         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2029         (test):
2030
2031 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2032
2033         [Qt] Build on Windows requires bison/flex in PATH
2034         https://bugs.webkit.org/show_bug.cgi?id=96358
2035
2036         Reviewed by Tor Arne Vestbø.
2037
2038         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
2039         and Linux that is rarely a problem given how easily available the tools are. On Windows however
2040         a separate installation of various GNU tools is required as the operating system doesn't come with
2041         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
2042         the gnuwin32 directory of the qt5.git top-level repository.
2043
2044         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
2045
2046         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
2047         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
2048         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
2049         updated with the new tool.
2050
2051         * Scripts/webkitdirs.pm:
2052         (checkRequiredSystemConfig):
2053         * qmake/mkspecs/features/default_post.prf:
2054
2055 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2056
2057         [Qt] Update build-jsc after r128174
2058
2059         Reviewed by Ossy.
2060
2061         * Scripts/build-jsc:
2062
2063 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2064
2065         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
2066
2067         By hard-coding the names of the targets we defined we ended up just
2068         redefining the previous target when using addStrictSubdirOrderBetween
2069         more than once in a single project file.
2070
2071         We now embed the two base targets into the target names.
2072
2073         Reviewed by Simon Hausmann.
2074
2075         * qmake/mkspecs/features/functions.prf:
2076
2077 2012-09-12  Philippe Liard  <pliard@google.com>
2078
2079         Depend on {base,net} GYP targets rather than {base,net}_java.
2080         https://bugs.webkit.org/show_bug.cgi?id=95690
2081
2082         Reviewed by Adam Barth.
2083
2084         {base,net}_java became 'private' targets on the Chromium side that
2085         clients should not depend on (see
2086         https://chromiumcodereview.appspot.com/10913083/).
2087         This removes a bunch of trailing white spaces additionally in
2088         TestWebkitAPI.gyp (which includes non-trailing white space changes).
2089
2090         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2091         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2092
2093 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2094
2095         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
2096         https://bugs.webkit.org/show_bug.cgi?id=96494
2097
2098         Reviewed by Tor Arne Vestbø.
2099
2100         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
2101         plugin process feature if we don't have NPAPI.
2102
2103         * qmake/mkspecs/features/features.prf:
2104
2105 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2106
2107         Unreviewed, rolling out r128280.
2108         http://trac.webkit.org/changeset/128280
2109         https://bugs.webkit.org/show_bug.cgi?id=96498
2110
2111         it broke compilation on windows debug bot (Requested by loislo
2112         on #webkit).
2113
2114         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2115         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2116         (WTR::InjectedBundlePage::InjectedBundlePage):
2117         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2118         (InjectedBundlePage):
2119         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2120         (WTR::TestRunner::TestRunner):
2121         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2122         (TestRunner):
2123
2124 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2125
2126         [Qt] Make it possible to build with "make release" and "make debug" on Windows
2127         https://bugs.webkit.org/show_bug.cgi?id=96488
2128
2129         Reviewed by Tor Arne Vestbø.
2130
2131         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
2132         because there are no such targets. We want the generated sources to be independent from release
2133         or debug build configurations, so it is sufficient to provide fake debug and release targets that
2134         redirect to the same general-purpose target (first) of creating the derived sources.
2135
2136         * qmake/mkspecs/features/default_post.prf:
2137
2138 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2139
2140         [EFL] Make DumpRenderTree smarter at finding the fonts
2141         http://webkit.org/b/96281
2142
2143         Reviewed by Gyuyoung Kim.
2144
2145         Respect WEBKITOUTPUTDIR and expand the font dir from it.
2146         Use CString consistently.
2147
2148         * DumpRenderTree/efl/FontManagement.cpp:
2149         (buildPath):
2150         (getCoreFontFiles):
2151         (addFontDirectory):
2152         (addFontFiles):
2153         (getCustomBuildDir):
2154         (getPlatformFontsPath):
2155         (addFontsToEnvironment):
2156
2157 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2158
2159         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
2160         https://bugs.webkit.org/show_bug.cgi?id=96374
2161
2162         Reviewed by Kenneth Rohde Christiansen.
2163
2164         Implement support for dumpApplicationCacheDelegateCallbacks
2165         and disallowIncreaseForApplicationCacheQuota in
2166         WebKitTestRunner and properly dump the information
2167         expected by the tests.
2168
2169         If the application cache quota is reached for a given
2170         security origin, WebKitTestRunner will reset the quota
2171         to its default value, unless intructed not to via
2172         disallowIncreaseForApplicationCacheQuota().
2173
2174         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2175         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2176         (WTR::InjectedBundlePage::InjectedBundlePage):
2177         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2178         (WTR):
2179         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2180         (InjectedBundlePage):
2181         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2182         (WTR::TestRunner::TestRunner):
2183         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
2184         (WTR):
2185         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2186         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
2187         (TestRunner):
2188         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
2189         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
2190
2191 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2192
2193         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
2194         https://bugs.webkit.org/show_bug.cgi?id=96388
2195
2196         Reviewed by Kenneth Rohde Christiansen.
2197
2198         Exported TestRunner.workerThreadCount as readonly attribute.
2199
2200         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2201         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
2202         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
2203         (WTR):
2204         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
2205         (TestRunner):
2206
2207 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
2208
2209         [chromium] Consume a user gesture when creating a new view.
2210         https://bugs.webkit.org/show_bug.cgi?id=96373
2211
2212         Reviewed by Adam Barth.
2213
2214         * DumpRenderTree/chromium/WebViewHost.cpp:
2215         (WebViewHost::createView):
2216
2217 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2218
2219         [WK2][WTR] Some of TestRunner special options are not reset before testing
2220         https://bugs.webkit.org/show_bug.cgi?id=96384
2221
2222         Reviewed by Kenneth Rohde Christiansen.
2223
2224         Now values of the following special options are reset:
2225         void setAcceptsEditing(in boolean value);
2226         void setCloseRemainingWindowsWhenComplete(in boolean value);
2227         void setXSSAuditorEnabled(in boolean value);
2228         void setAllowFileAccessFromFileURLs(in boolean value);
2229         void setPluginsEnabled(in boolean value);
2230         void setPopupBlockingEnabled(in boolean value);
2231
2232         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2233         (WTR::InjectedBundle::beginTesting):
2234
2235 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
2236
2237         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
2238         https://bugs.webkit.org/show_bug.cgi?id=96273
2239
2240         Reviewed by Gyuyoung Kim.
2241
2242         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
2243         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
2244
2245         * WebKitTestRunner/CMakeLists.txt:
2246
2247 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
2248
2249         [chromium] rename webkit_resources
2250         https://bugs.webkit.org/show_bug.cgi?id=95874
2251
2252         Reviewed by James Robinson.
2253
2254         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2255
2256 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
2257
2258         [chromium] don't include content shell builders in the garden-o-matic view
2259         https://bugs.webkit.org/show_bug.cgi?id=96418
2260
2261         Reviewed by James Robinson.
2262
2263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2264
2265 2012-09-11  Adam Klein  <adamk@chromium.org>
2266
2267         Garden-o-matic should ignore a wider variety of warnings in buildbot json
2268         https://bugs.webkit.org/show_bug.cgi?id=96411
2269
2270         Reviewed by Adam Barth.
2271
2272         Previously only the exact string "warning" was treated as a warning
2273         result. This patch treats any string with "warning" as a substring
2274         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
2275
2276         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2277         (.):
2278         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2279
2280 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
2281
2282         Restore original value of mock scrollbars enabled in InternalSettings
2283         https://bugs.webkit.org/show_bug.cgi?id=87680
2284
2285         Reviewed by Adam Barth.
2286
2287         Added backup support for mock scrollbars state in
2288         InternalSettings::Backup, and removed support for these
2289         from Qt's DumpRenderTree.
2290
2291         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2292         (WebCore::WebPage::resetSettings):
2293         * DumpRenderTree/qt/TestRunnerQt.cpp:
2294         (TestRunner::setFrameFlatteningEnabled):
2295         * DumpRenderTree/qt/TestRunnerQt.h:
2296         (TestRunner):
2297
2298 2012-09-11  Dan Bernstein  <mitz@apple.com>
2299
2300         Fixed a bug where kill-old-processes failed to kill clang++.
2301
2302         Rubber-stamped by Alexey Proskuryakov.
2303
2304         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
2305         where it is passed as a regular expression to killall.
2306
2307 2012-09-11  Philippe Liard  <pliard@google.com>
2308
2309         Make sure that md5sum is not setup on non-Chromium Android platforms.
2310         https://bugs.webkit.org/show_bug.cgi?id=96393
2311
2312         Reviewed by Adam Barth.
2313
2314         Previously md5sum was setup in ChromiumAndroidDriver's constructor
2315         which is also invoked on non-Chromium Android platforms. The following patch
2316         moves this logic to _startup_test() which is guaranteed to be invoked
2317         only on Android.
2318
2319         This also updates the prompt unit test in chromium_android_unittest.py.
2320
2321         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2322         (ChromiumAndroidDriver.__init__):
2323         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
2324         (ChromiumAndroidDriver._setup_test):
2325
2326 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
2327
2328         [EFL] Rewrite the EFL-related Find modules
2329         https://bugs.webkit.org/show_bug.cgi?id=95237
2330
2331         Reviewed by Kenneth Rohde Christiansen.
2332
2333         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
2334         property and include all the Enlightenment Foundation Libraries
2335         required by the target.
2336         * EWebLauncher/CMakeLists.txt: Ditto.
2337         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2338         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
2339         now that they are not added implicitly.
2340         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
2341         property.
2342         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
2343         property and include all the Enlightenment Foundation Libraries
2344         required by the target.
2345
2346 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2347
2348         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
2349         https://bugs.webkit.org/show_bug.cgi?id=96379
2350
2351         Reviewed by Kenneth Rohde Christiansen.
2352
2353         Add implementation for setApplicationCacheOriginQuota
2354         to WebKitTestRunner.
2355
2356         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2357         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2358         (WTR::TestRunner::setApplicationCacheOriginQuota):
2359         (WTR):
2360         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2361         (TestRunner):
2362
2363 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
2364
2365         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
2366         https://bugs.webkit.org/show_bug.cgi?id=91988
2367
2368         Reviewed by Kenneth Rohde Christiansen.
2369
2370         Regular key events generated by Qt for the tab key fill both
2371         keyCode and keyText, so we should do the same for our fake events.
2372
2373         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2374         (WTR::EventSenderProxy::keyDown):
2375
2376 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2377
2378         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
2379         https://bugs.webkit.org/show_bug.cgi?id=96269
2380
2381         Reviewed by Kenneth Rohde Christiansen.
2382
2383         Exported missing testRunner.setSpatialNavigationEnabled() method.
2384
2385         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2386         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2387         (WTR::InjectedBundle::beginTesting):
2388         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2389         (WTR::TestRunner::setSpatialNavigationEnabled):
2390         (WTR):
2391         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2392         (TestRunner):
2393
2394 2012-09-11  Philippe Liard  <pliard@chromium.org>
2395
2396         Support LayoutTests on non-rooted devices for Chromium Android.
2397         https://bugs.webkit.org/show_bug.cgi?id=95346
2398
2399         Reviewed by Dirk Pranke.
2400
2401         We were requiring root permissions to sync resource files with the
2402         device by comparing host and device files' timestamp after we
2403         synchronized the device and host clocks.
2404         We now rely on md5sum provided by Chromium to handle data files
2405         synchronization.
2406
2407         * Scripts/webkitpy/layout_tests/port/chromium.py:
2408         (ChromiumPort._check_driver_build_up_to_date):
2409         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2410         (ChromiumAndroidDriver.__init__):
2411         (ChromiumAndroidDriver._setup_test):
2412         (ChromiumAndroidDriver._push_executable):
2413         (ChromiumAndroidDriver._push_test_resources):
2414         (ChromiumAndroidDriver._read_prompt):
2415
2416 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2417
2418         [Qt] Fix output paths on Windows
2419
2420         Reviewed by Tor Arne Vestbø.
2421
2422         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
2423         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
2424         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
2425         incorrect here and instead for the calculation we should use forward slashes.
2426
2427         * qmake/mkspecs/features/default_pre.prf:
2428
2429 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2430
2431         [Qt] Fix passing of defines from the build system
2432
2433         We explicitly have to pass -DENABLE_FOO=0 for every single feature
2434         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
2435         will add it's own defaults if the features are not defined.
2436
2437         At some point we might want to run a configure-test to inspect what
2438         Platform.h will do, so we can sync up the build system's view of
2439         the feature-defines with the compile-time situation.
2440
2441         Reviewed by Simon Hausmann.
2442
2443         * qmake/mkspecs/features/functions.prf:
2444
2445 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2446
2447         [Qt] Fix --qt option to build-webkit
2448
2449         Reviewed by Ossy.
2450
2451         * Scripts/webkitdirs.pm:
2452         (buildQMakeProjects):
2453
2454 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2455
2456         [Qt] Add a configure step to the Qt build system
2457
2458         This allows building the Qt port using just 'qmake WebKit.pro'. Using
2459         the build-webkit script is still supported, and will add slightly more
2460         logic to the build, such as detecting the need for clean or incremental
2461         builds.
2462
2463         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
2464         all things related to configuring the build, such as use/have/enable flags,
2465         and these are translated to defines in default_post. Project files should
2466         no longer check contains(DEFINES,...) to detect features, but use the new
2467         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
2468         options have been translated into WEBKIT_CONFIG options as well, and can
2469         be checked using build?().
2470
2471         Reviewed by Simon Hausmann.
2472
2473         * DumpRenderTree/qt/DumpRenderTree.pro:
2474         * MiniBrowser/qt/MiniBrowser.pro:
2475         * QtTestBrowser/QtTestBrowser.pro:
2476         * Scripts/build-webkit:
2477         * Scripts/webkitdirs.pm:
2478         (qtFeatureDefaults):
2479         (buildQMakeProjects):
2480         * Tools.pro:
2481         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2482         * WebKitTestRunner/InjectedBundle/Target.pri:
2483         * WebKitTestRunner/Target.pri:
2484         * qmake/.qmake.cache: Added.
2485         * qmake/configure.pri: Removed.
2486         * qmake/configure.pro: Removed.
2487         * qmake/dump-features: Added.
2488         * qmake/mkspecs/features/configure.prf: Added.
2489         * qmake/mkspecs/features/default_post.prf:
2490         * qmake/mkspecs/features/default_pre.prf:
2491         * qmake/mkspecs/features/features.prf:
2492         * qmake/mkspecs/features/features.pri:
2493         * qmake/mkspecs/features/functions.prf:
2494         * qmake/mkspecs/features/gprof.prf:
2495         * qmake/mkspecs/features/mac/default_pre.prf:
2496         * qmake/mkspecs/features/win32/default_pre.prf:
2497
2498 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2499
2500         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
2501         https://bugs.webkit.org/show_bug.cgi?id=96372
2502
2503         Reviewed by Kenneth Rohde Christiansen.
2504
2505         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
2506
2507         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2508         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2509         (WTR::TestRunner::clearApplicationCacheForOrigin):
2510         (WTR):
2511         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2512         (TestRunner):
2513
2514 2012-09-11  Peter Beverloo  <peter@chromium.org>
2515
2516         Don't ignore .pak files when making an archive for Android
2517         https://bugs.webkit.org/show_bug.cgi?id=96375
2518
2519         Reviewed by Jochen Eisinger.
2520
2521         The .pak files do need to be pushed to the device, which is currently
2522         preventing the layout test runner from correctly pushing all files.
2523
2524         * BuildSlaveSupport/built-product-archive:
2525         (archiveBuiltProduct):
2526
2527 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2528
2529         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
2530         https://bugs.webkit.org/show_bug.cgi?id=96256
2531
2532         Reviewed by Kenneth Rohde Christiansen.
2533
2534         Exported TestRunner::setMinimumTimerInterval() method.
2535
2536         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2537         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2538         (WTR::InjectedBundle::beginTesting):
2539         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2540         (WTR::TestRunner::setMinimumTimerInterval):
2541         (WTR):
2542         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2543         (TestRunner):
2544
2545 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
2546
2547         MediaStream API: add RTCPeerConnection::onnegotiationneeded
2548         https://bugs.webkit.org/show_bug.cgi?id=96097
2549
2550         Reviewed by Adam Barth.
2551
2552         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2553         (MockWebRTCPeerConnectionHandler::addStream):
2554         (MockWebRTCPeerConnectionHandler::removeStream):
2555
2556 2012-09-11  Peter Beverloo  <peter@chromium.org>
2557
2558         Recognize the "--chromium-android" argument in run-webkit-tests
2559         https://bugs.webkit.org/show_bug.cgi?id=96369
2560
2561         Reviewed by Jochen Eisinger.
2562
2563         Chromium for the Android platform cannot determine the platform based on
2564         the host itself, so we'll use the --chromium-android argument as the build
2565         master passes to run-webkit-tests. Make sure the layout test runner
2566         can pick the right port when doing so.
2567
2568         * Scripts/run-webkit-tests:
2569         * Scripts/webkitpy/layout_tests/port/factory.py:
2570         (port_options):
2571
2572 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2573
2574         [QT] Fix build with newer qmake from Qt 5
2575
2576         Rubber-stamped by Tor Arne Vestbø.
2577
2578         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
2579         it with the use of QT_HOST_DATA/mkspecs.
2580         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
2581
2582         * Scripts/webkitdirs.pm:
2583         (builtDylibPathForName):
2584         (qtMakeCommand):
2585
2586 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2587
2588         [Qt] Remove Qt 4 syncqt, no longer needed
2589
2590         Reviewed by Simon Hausmann.
2591
2592         * qmake/syncqt-4.8: Removed.
2593
2594 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
2595
2596         [Qt][WK2] Fix the build with recent Qt5
2597         https://bugs.webkit.org/show_bug.cgi?id=96283
2598
2599         Reviewed by Simon Hausmann.
2600
2601         We should not use deprecated Qt API because doing that results
2602         in build failure since all the deprecated API was disabled
2603         in qtbase (https://codereview.qt-project.org/#change,24890).
2604
2605         * DumpRenderTree/qt/main.cpp:
2606         (main):
2607         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2608         (MiniBrowserApplication::notify):
2609         * MiniBrowser/qt/raw/View.cpp:
2610         (View::exposeEvent):
2611         (main):
2612
2613 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2614
2615         WTR needs an implementation of applicationCacheDiskUsageForOrigin
2616         https://bugs.webkit.org/show_bug.cgi?id=87188
2617
2618         Reviewed by Kenneth Rohde Christiansen.
2619
2620         Add implementation for applicationCacheDiskUsageForOrigin()
2621         in WebKitTestRunner.
2622
2623         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2624         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2625         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
2626         (WTR):
2627         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2628         (TestRunner):
2629
2630 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
2631
2632         Properly expose <legend> elements to ATs
2633         https://bugs.webkit.org/show_bug.cgi?id=84137
2634
2635         Reviewed by Chris Fleizach.
2636
2637         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
2638         the expected platform role, ATK_ROLE_LABEL. Also established the needed
2639         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
2640
2641         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2642         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
2643
2644 2012-09-10  Jer Noble  <jer.noble@apple.com>
2645
2646         Unreviewed; rolling out r128081.
2647         http://trac.webkit.org/changeset/128081
2648         https://bugs.webkit.org/show_bug.cgi?id=96134
2649
2650         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
2651
2652         * DumpRenderTree/TestRunner.cpp:
2653         (TestRunner::TestRunner):
2654         (TestRunner::staticFunctions):
2655         * DumpRenderTree/TestRunner.h:
2656         (TestRunner):
2657         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2658         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2659         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2660         (WTR::InjectedBundlePage::InjectedBundlePage):
2661         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2662         (InjectedBundlePage):
2663         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2664         (WTR::TestRunner::TestRunner):
2665         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2666         (TestRunner):
2667
2668 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2669
2670         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
2671         https://bugs.webkit.org/show_bug.cgi?id=96205
2672
2673         Reviewed by Tony Chang.
2674
2675         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
2676         internally, which means that it would support only 1 TestExpectations file per port. This
2677         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
2678         and efl-wk1 -> efl).
2679
2680         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
2681         instead so that all the ports TestExpectations are recognized. The ports are also
2682         constructed twice, with "webkit_test_runner" option set to True and False so that we
2683         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
2684
2685         * Scripts/webkitpy/style/checkers/test_expectations.py:
2686         (TestExpectationsChecker._determine_port_from_expectations_path):
2687         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
2688         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2689
2690 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
2691
2692         [WTR] Generated source files should include config.h
2693         https://bugs.webkit.org/show_bug.cgi?id=96254
2694
2695         Reviewed by Benjamin Poulain.
2696
2697         Current coding style has encouraged to include config.h at the first position,
2698         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
2699         this rule.
2700         Therefore, this patch added it.
2701
2702         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2703         (_generateImplementationFile):
2704
2705 2012-09-10  Rick Byers  <rbyers@chromium.org>
2706
2707         Add handling of new GestureTapCancel in DRT
2708         
2709         https://bugs.webkit.org/show_bug.cgi?id=96183
2710
2711         Reviewed by Adam Barth.
2712
2713         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2714         (TestWebPlugin::handleInputEvent):
2715
2716 2012-09-10  Brady Eidson  <beidson@apple.com>
2717
2718         Javascript in foreground tabs should not wait synchronously for plug-ins to load
2719         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
2720
2721         Reviewed by Geoff Garen.
2722
2723         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
2724
2725         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
2726         (PluginObject):
2727         (SlowNPPNew::PluginObject::PluginObject):
2728         (SlowNPPNew::PluginObject::~PluginObject):
2729         (SlowNPPNew::PluginObject::hasProperty):
2730         (SlowNPPNew::PluginObject::getProperty):
2731         (SlowNPPNew::NPP_GetValue):
2732         (SlowNPPNew):
2733
2734 2012-09-10  Tim Horton  <timothy_horton@apple.com>
2735
2736         WKTR often reports an unresponsive WebProcess on Mac bots
2737         https://bugs.webkit.org/show_bug.cgi?id=95906
2738
2739         Reviewed by Dan Bernstein.
2740
2741         Attempt to work around resource contention issues by increasing the NRWT
2742         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
2743
2744         * Scripts/webkitpy/layout_tests/port/base.py:
2745         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
2746         * WebKitTestRunner/TestController.cpp:
2747         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
2748
2749 2012-09-07  Jer Noble  <jer.noble@apple.com>
2750
2751         <audio> and <video> should send Do Not Track when appropriate
2752         https://bugs.webkit.org/show_bug.cgi?id=96134
2753
2754         Reviewed by Eric Carlson.
2755
2756         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
2757         WTR. Add FrameLoaderClient client methods for retrieving that value.
2758
2759         * DumpRenderTree/TestRunner.cpp:
2760         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
2761         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
2762         * DumpRenderTree/TestRunner.h:
2763         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
2764         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2765         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2766         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
2767             Pass the question on to the TestRunner.
2768         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2769         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2770         (WTR::InjectedBundlePage::InjectedBundlePage):
2771             Add the setShouldSendDoNotTrackHTTPHeader client function.
2772         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
2773             Pass the question on to the TestRunner.
2774         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2775         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2776         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2777         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2778         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
2779
2780 2012-09-10  Ojan Vafai  <ojan@chromium.org>
2781
2782         Make EFL bots work on the flakiness dashboard
2783         https://bugs.webkit.org/show_bug.cgi?id=96164
2784
2785         Reviewed by Tony Chang.
2786
2787         Also, update outdated unittests that had started failing.
2788
2789         * TestResultServer/static-dashboards/builders.js:
2790         (isWebkitTestRunner):
2791         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2792         (nonChromiumPlatform):
2793         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2794         (test):
2795
2796 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
2797
2798         [chromium] MediaStream API: Remove the Descriptor postfix
2799         https://bugs.webkit.org/show_bug.cgi?id=96268
2800
2801         Reviewed by Adam Barth.
2802
2803         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
2804         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
2805
2806         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2807         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2808         (MockWebRTCPeerConnectionHandler::createOffer):
2809         (MockWebRTCPeerConnectionHandler::createAnswer):
2810         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2811         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2812         (MockWebRTCPeerConnectionHandler::localDescription):
2813         (MockWebRTCPeerConnectionHandler::remoteDescription):
2814         (MockWebRTCPeerConnectionHandler::addICECandidate):
2815         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2816         (MockWebRTCPeerConnectionHandler):
2817
2818 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
2819
2820         [Gtk] failure to build jhbuild dependencies with cups 1.6
2821         https://bugs.webkit.org/show_bug.cgi?id=95991
2822
2823         Reviewed by Gustavo Noronha Silva.
2824
2825         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
2826         building with cups >= 1.6 [GNOME #670373].
2827
2828         * gtk/jhbuild.modules:
2829
2830 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2831
2832         [EFL][DRT] Encoding issue in printed console messages
2833         https://bugs.webkit.org/show_bug.cgi?id=96263
2834
2835         Reviewed by Kenneth Rohde Christiansen.
2836
2837         Correctly handle CONSOLE messages that contain non-ascii
2838         characters in EFL's DRT. We need to use String::fromUTF8()
2839         to construct a WTF::String from a raw string.
2840
2841         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2842         (onConsoleMessage):
2843
2844 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2845
2846         [WK2][WTR] User style sheet location should be reset before each test
2847         https://bugs.webkit.org/show_bug.cgi?id=96262
2848
2849         Reviewed by Kenneth Rohde Christiansen.
2850
2851         User style sheet location is reset before each test now.
2852
2853         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2854         (WTR::InjectedBundle::beginTesting):
2855
2856 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
2857
2858         Fix build of WTR with Qt on Windows
2859         https://bugs.webkit.org/show_bug.cgi?id=96249
2860
2861         Reviewed by Kenneth Rohde Christiansen.
2862
2863         Windows loves to define min and max as macros, which beautifully
2864         clashes in many places where min and max are used as variable or method
2865         names. It can be convinced not to do this when min and max are already
2866         define as macros (expanding to themselves). We have this kind of
2867         workaround in config.h files all over WebKit and as it turns out when
2868         building WTR with Qt on Windows we do end up with such a clash. Therefore
2869         we need the same workaround.
2870
2871         * WebKitTestRunner/config.h:
2872
2873 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2874
2875         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
2876         https://bugs.webkit.org/show_bug.cgi?id=95936
2877
2878         Reviewed by Kenneth Rohde Christiansen.
2879
2880         Enable interactive form validation setting in WebKitTestRunner as
2881         we are currently doing in DumpRenderTree. This is needed for some
2882         tests to pass.
2883
2884         * WebKitTestRunner/TestController.cpp:
2885         (WTR::TestController::resetStateToConsistentValues):
2886
2887 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
2888
2889         Clean up the code in XvfbDriver
2890         https://bugs.webkit.org/show_bug.cgi?id=96202
2891
2892         Reviewed by Philippe Normand.
2893
2894         Changes:
2895         - Remove unneeded imports,
2896         - assign the _lock_file member variable when the display number is determined,
2897         - no need for parentheses around a single string format argument,
2898         - use FileSystem.exists method when checking if lock file is present as it
2899         makes the intention much more clearer.
2900
2901         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2902         (XvfbDriver._start):
2903         (XvfbDriver.stop):
2904
2905 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
2906
2907         Make the String initialization on the function side of String::number()
2908         https://bugs.webkit.org/show_bug.cgi?id=95940
2909
2910         Reviewed by Benjamin Poulain.
2911
2912         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2913         (testBoundaries):
2914         (testNumbers):
2915
2916 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
2917
2918         [WK2] expose element rect for color input type
2919         https://bugs.webkit.org/show_bug.cgi?id=91664
2920
2921         Reviewed by Simon Hausmann.
2922
2923         Update the QML logic in MiniBrowser to take advantage of this.
2924         The picker size is now hardcoded and we try to place it below the
2925         input element if possible.
2926
2927         * MiniBrowser/qt/qml/ColorChooser.qml:
2928
2929 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
2930
2931         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
2932         https://bugs.webkit.org/show_bug.cgi?id=95329
2933
2934         Reviewed by Kenneth Rohde Christiansen.
2935
2936         Explicitely disable TabToLinks setting in WebKitTestRunner.
2937         Tests override the "WebKitTabToLinksPreferenceKey" preference
2938         to enable it.
2939
2940         * WebKitTestRunner/TestController.cpp:
2941         (WTR::TestController::resetStateToConsistentValues):
2942
2943 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
2944
2945         webkit.py gdb pretty printer can't print CString
2946         https://bugs.webkit.org/show_bug.cgi?id=96068
2947
2948         Reviewed by Tony Chang.
2949
2950         Update WTFCStringPrinter to follow r126191.
2951
2952         * gdb/webkit.py:
2953         (WTFCStringPrinter.to_string):
2954
2955 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
2956
2957         Rename the ustring() accessor to string()
2958         https://bugs.webkit.org/show_bug.cgi?id=95919
2959
2960         Reviewed by Geoffrey Garen.
2961
2962         Update EFL's DRT.
2963
2964         Fix some string conversion that have been made useless
2965         with recent changes.
2966
2967         * DumpRenderTree/efl/EventSender.cpp:
2968         (keyPadNameFromJSValue):
2969         (keyNameFromJSValue):
2970         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2971         (TestRunner::queueLoad):
2972         (TestRunner::addOriginAccessWhitelistEntry):
2973         (TestRunner::removeOriginAccessWhitelistEntry):
2974         (TestRunner::setUserStyleSheetLocation):
2975         (TestRunner::setValueForUser):
2976         (TestRunner::elementDoesAutoCompleteForElementWithId):
2977         (TestRunner::execCommand):
2978         (TestRunner::findString):
2979         (TestRunner::isCommandEnabled):
2980         (TestRunner::clearApplicationCacheForOrigin):
2981         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2982         (TestRunner::pauseAnimationAtTimeOnElementWithId):
2983         (TestRunner::pauseTransitionAtTimeOnElementWithId):
2984         (toInt):
2985         (TestRunner::overridePreference):
2986         (TestRunner::addUserScript):
2987         (TestRunner::addUserStyleSheet):
2988         (TestRunner::evaluateInWebInspector):
2989         (TestRunner::evaluateScriptInIsolatedWorld):
2990         (TestRunner::setTextDirection):
2991         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2992         (LoadItem::invoke):
2993         (LoadHTMLStringItem::invoke):
2994         (ScriptItem::invoke):
2995
2996 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
2997
2998         Extend third-party storage blocking API to optionally allow blocking all storage
2999         https://bugs.webkit.org/show_bug.cgi?id=95915
3000
3001         Reviewed by Brady Eidson.
3002
3003         Modified API test to use new revised API.
3004
3005         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3006         (TestWebKitAPI::TEST):
3007
3008 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
3009
3010         AX: WebCore accessibility roles should be cross-platform
3011         https://bugs.webkit.org/show_bug.cgi?id=94870
3012
3013         Reviewed by Chris Fleizach.
3014
3015         Add debug strings to Chromium for new accessibility roles.
3016
3017         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3018         (roleToString):
3019
3020 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
3021
3022         AX: Chromium needs access to canvasHasFallbackContent
3023         https://bugs.webkit.org/show_bug.cgi?id=96124
3024
3025         Reviewed by Chris Fleizach.
3026
3027         Distinguish between canvas roles with and without fallback
3028         content on Chromium.
3029
3030         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3031         (getRole):
3032
3033 2012-09-07  Ojan Vafai  <ojan@chromium.org>
3034
3035         Handle non-existant TestExpectations files gracefully
3036         https://bugs.webkit.org/show_bug.cgi?id=96149
3037
3038         Reviewed by Eric Seidel.
3039
3040         Even when we get rid of Skipped files, we shouldn't have each port
3041         require a TestExpectations file for each platform if it doesn't
3042         need one.
3043
3044         * Scripts/webkitpy/layout_tests/port/base.py:
3045         (Port.expectations_dict):
3046         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3047         (PortTest.test_nonexistant_expectations):
3048
3049 2012-09-07  Tony Chang  <tony@chromium.org>
3050
3051         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
3052         https://bugs.webkit.org/show_bug.cgi?id=96136
3053
3054         Reviewed by Ojan Vafai.
3055
3056         When we renamed the file to TestExpectations, it was no longer considered a text file so
3057         it was no longer being checked. Since then, test_expectations_overrides() has been removed
3058         from the port object, so I've removed that from the check. I'm not sure what it was
3059         supposed to do.
3060
3061         * Scripts/webkitpy/style/checker.py:
3062         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
3063         * Scripts/webkitpy/style/checkers/test_expectations.py:
3064         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
3065         (TestExpectationsChecker.check): Remove overrides param.
3066         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3067         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
3068
3069 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3070
3071         [EFL] Use same default minimum logical font size in DRT and WTR
3072         https://bugs.webkit.org/show_bug.cgi?id=96116
3073
3074         Reviewed by Martin Robinson.
3075
3076         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3077         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
3078         logical font size to 9 to match the value used in WTR.
3079         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3080         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
3081         logical font size to 9 (default value in WK2)
3082
3083 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
3084
3085         MediaStream API: add RTCPeerConnection::createAnswer
3086         https://bugs.webkit.org/show_bug.cgi?id=96092
3087
3088         Reviewed by Adam Barth.
3089
3090         Expanding and enhancing MockWebRTCPeerConnectionHandler.
3091
3092         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3093         (MockWebRTCPeerConnectionHandler::createOffer):
3094         (MockWebRTCPeerConnectionHandler::createAnswer):
3095         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3096         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3097         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3098         (MockWebRTCPeerConnectionHandler):
3099
3100 2012-09-07  Dean Jackson  <dino@apple.com>
3101
3102         Unreviewed changes to watchlist.
3103
3104         - Add new WebGL and Filters definitions
3105         - Add myself to OpenGL bugs
3106
3107         * Scripts/webkitpy/common/config/watchlist:
3108
3109 2012-09-07  Peter Beverloo  <peter@chromium.org>
3110
3111         Actually trigger the Android Tester
3112         https://bugs.webkit.org/show_bug.cgi?id=96118
3113
3114         Reviewed by Adam Barth.
3115
3116         * BuildSlaveSupport/build.webkit.org-config/config.json:
3117
3118 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
3119
3120         New time input needs accessibility
3121         https://bugs.webkit.org/show_bug.cgi?id=96032
3122
3123         Reviewed by Chris Fleizach.
3124
3125         Add support for valueDescription for testing.
3126
3127         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3128         (getValueDescription):
3129         (AccessibilityUIElement::AccessibilityUIElement):
3130         (AccessibilityUIElement::valueDescriptionGetterCallback):
3131         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
3132         (AccessibilityUIElement):
3133
3134 2012-09-07  Peter Beverloo  <peter@chromium.org>
3135
3136         Add the google-android-tests build slave to the master's config
3137         https://bugs.webkit.org/show_bug.cgi?id=96113
3138
3139         Reviewed by Csaba Osztrogonác.
3140
3141         * BuildSlaveSupport/build.webkit.org-config/config.json:
3142
3143 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3144
3145         [WK2] [EFL] Set theme for WebKit2 API test runner
3146         https://bugs.webkit.org/show_bug.cgi?id=96100
3147
3148         Reviewed by Kenneth Rohde Christiansen.
3149
3150         Set the theme generated by the build for the WebKit2 API test runner.
3151
3152         * TestWebKitAPI/PlatformEfl.cmake:
3153         * TestWebKitAPI/efl/PlatformWebView.cpp:
3154         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3155
3156 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
3157
3158         Unreviewed. Add Gábor Ballabás as contributor.
3159
3160         * Scripts/webkitpy/common/config/committers.py:
3161
3162 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
3163
3164         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
3165         https://bugs.webkit.org/show_bug.cgi?id=96078
3166
3167         Reviewed by Tor Arne Vestbø.
3168
3169         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
3170
3171         * qmake/mkspecs/features/default_pre.prf:
3172
3173 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3174
3175         [EFL] Add TestExpectations file for efl-wk1
3176         https://bugs.webkit.org/show_bug.cgi?id=96019
3177
3178         Reviewed by Gyuyoung Kim.
3179
3180         Update TestExpectations cascading for EFL port
3181         so that we use efl-wk1 -> efl search paths
3182         for WebKit1 EFL.
3183
3184         * Scripts/webkitpy/layout_tests/port/efl.py:
3185         (EflPort._search_paths):
3186
3187 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
3188
3189         [NRWT] XvfbDriver should stop the Xvfb more aggressively
3190         https://bugs.webkit.org/show_bug.cgi?id=95097
3191
3192         Reviewed by Dirk Pranke.
3193
3194         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
3195         terminating the process does not always work as expected, leading to timeouts
3196         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
3197         as it's not removed by the killed Xvfb process.
3198
3199         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
3200         is tested in different circumstances - whether pixel tests are enabled or not,
3201         with an arbitrary worker number or with an Xorg process already running on the system.
3202         The stopping of the driver is tested by checking that the Xvfb process is truly killed
3203         and then set to None.
3204
3205         * BuildSlaveSupport/kill-old-processes:
3206         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
3207         is left running, potentially clogging up a display at a certain position.
3208         * Scripts/webkitpy/common/system/executive_mock.py:
3209         (MockExecutive.__init__):
3210         The _running_pids is now a dictionary with process names as keys and pids
3211         as values.
3212         (MockExecutive.check_running_pid):
3213         Check whether the passed-in pid is in the _running_pids dictionary's values.
3214         (MockExecutive):
3215         (MockExecutive.running_pids):
3216         This method returns the list of all the process pids of which the name passes
3217         through the process_name_filter.
3218         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3219         Use the Executive object of the port's host to check for running pids and open
3220         new subprocesses or kill them throughout the class.
3221         (XvfbDriver._start):
3222         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
3223         start the server process after it's created.
3224         (XvfbDriver.stop):
3225         Now kills the Xvfb process instead of terminating it and waiting for it to close.
3226         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
3227         (XvfbDriverTest):
3228         (XvfbDriverTest.make_driver):
3229         (XvfbDriverTest.assertDriverStartSuccessful):
3230         (XvfbDriverTest.test_start_no_pixel_tests):
3231         (XvfbDriverTest.test_start_pixel_tests):
3232         (XvfbDriverTest.test_start_arbitrary_worker_number):
3233         (XvfbDriverTest.test_start_existing_xorg_process):
3234         (XvfbDriverTest.test_stop):
3235         (XvfbDriverTest.test_stop.FakeXvfbProcess):
3236
3237 2012-09-06  Peter Beverloo  <peter@chromium.org>
3238
3239         Introduce the Chromium Android Release (Tests) bot
3240         https://bugs.webkit.org/show_bug.cgi?id=95980
3241
3242         Reviewed by Adam Barth.
3243
3244         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
3245         which will be running layout tests on actual Android devices. Right now,
3246         four Galaxy Nexus phones are attached.
3247
3248         * BuildSlaveSupport/build.webkit.org-config/config.json:
3249
3250 2012-09-06  James Robinson  <jamesr@chromium.org>
3251
3252         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
3253         https://bugs.webkit.org/show_bug.cgi?id=96007
3254
3255         Reviewed by Adrienne Walker.
3256
3257         Fixes initialization / settings code to use WebCompositorSupport.
3258
3259         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3260         (main):
3261         * DumpRenderTree/chromium/TestShell.cpp:
3262         (TestShell::initialize):
3263         (TestShell::setPerTilePaintingEnabled):
3264
3265 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3266
3267         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
3268         https://bugs.webkit.org/show_bug.cgi?id=95995
3269
3270         Reviewed by Kenneth Rohde Christiansen.
3271
3272         Provide proper implementation for PlatformWebView::windowFrame()
3273         in EFL's WebKitTestRunner.
3274
3275         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3276         (WTR::PlatformWebView::windowFrame):
3277
3278 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
3279
3280         Fix WTF.Lrint on 32-bit platforms
3281         https://bugs.webkit.org/show_bug.cgi?id=96003
3282
3283         Reviewed by Benjamin Poulain.
3284
3285         Fixed failing WTF.Lrint test on 32-bit platforms.
3286
3287         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3288         (TestWebKitAPI::TEST):
3289
3290 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
3291
3292         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3293         https://bugs.webkit.org/show_bug.cgi?id=95839
3294
3295         Reviewed by Adam Barth.
3296
3297         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3298         up the task definitions a bit. There was no need to have them in the header file.
3299
3300         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3301         (RTCSessionDescriptionRequestSuccededTask):
3302         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3303         (RTCSessionDescriptionRequestFailedTask):
3304         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3305         (RTCVoidRequestTask):
3306         (RTCVoidRequestTask::RTCVoidRequestTask):
3307         (MockWebRTCPeerConnectionHandler::createOffer):
3308         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3309         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3310         (MockWebRTCPeerConnectionHandler::localDescription):
3311         (MockWebRTCPeerConnectionHandler::remoteDescription):
3312         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3313         (MockWebRTCPeerConnectionHandler):
3314
3315 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3316
3317         [Qt] Fix build on Mac OS X 10.6
3318         https://bugs.webkit.org/show_bug.cgi?id=95200
3319
3320         Reviewed by Tor Arne Vestbø.
3321
3322         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
3323         10.7 and newer.
3324
3325         * qmake/mkspecs/features/features.prf:
3326
3327 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3328
3329         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
3330         https://bugs.webkit.org/show_bug.cgi?id=95973
3331
3332         Reviewed by Kenneth Rohde Christiansen.
3333
3334         Correctly map "addSelectionKey" to "Control" modifier
3335         in WKTR's EventSender on other OSes than Mac OS X,
3336         instead of mapping it to the "Meta" modifier.
3337
3338         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3339         (WTR::parseModifier):
3340
3341 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
3342
3343         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
3344         https://bugs.webkit.org/show_bug.cgi?id=95710
3345
3346         Reviewed by Dirk Pranke.
3347
3348         The stdout / stderr output can be None so make sure
3349         we won't raise an exception in this case.
3350
3351         * Scripts/webkitpy/layout_tests/port/driver.py:
3352         (Driver.run_test):
3353
3354 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3355
3356         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
3357         https://bugs.webkit.org/show_bug.cgi?id=95849
3358
3359         Reviewed by Kenneth Rohde Christiansen.
3360
3361         Sanitize URLs passed by the user as program
3362         argument or typed in the URL bar in order to
3363         be more tolerant.
3364
3365         * EWebLauncher/CMakeLists.txt:
3366         * EWebLauncher/main.c:
3367         (main):
3368         * EWebLauncher/url_bar.c:
3369         (_url_bar_url_get_with_protocol):
3370         (on_urlbar_key_down):
3371         * EWebLauncher/url_utils.c: Added.
3372         (has_scheme):
3373         (url_from_user_input): Add utility function to construct a
3374         URL from user input.
3375         * EWebLauncher/url_utils.h: Added.
3376         * MiniBrowser/efl/CMakeLists.txt:
3377         * MiniBrowser/efl/main.c:
3378         (main):
3379
3380 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3381
3382         [Qt] Various small Windows / MSVC build fixes
3383         https://bugs.webkit.org/show_bug.cgi?id=95934
3384
3385         Reviewed by Kenneth Rohde Christiansen.
3386
3387         setFocus takes a boolean as argument: Don't try to implicitly convert
3388         an enum to a boolean, MSVC doesn't like that. The intent here is to
3389         enable focus, so just pass true.
3390
3391         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3392         (WTR::PlatformWebView::focus):
3393
3394 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3395
3396         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
3397         https://bugs.webkit.org/show_bug.cgi?id=95965
3398
3399         Reviewed by Tor Arne Vestbø.
3400
3401         Add ANGLE as a static library module to the Qt WebKit build system.
3402
3403         * qmake/mkspecs/features/default_post.prf:
3404         * qmake/mkspecs/modules/angle.prf: Added.
3405
3406 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
3407
3408         [WK2] Make [Qt]ViewportHandler cross platform
3409         https://bugs.webkit.org/show_bug.cgi?id=91257
3410
3411         Reviewed by Kenneth Rohde Christiansen.
3412
3413         Remove initial scale from viewport info item since it is
3414         set to -1 after applied thus it does not hold any valuable
3415         information.
3416
3417         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3418
3419 2012-09-05  Tony Chang  <tony@chromium.org>
3420
3421         [chromium] Remove dependency on webkit_user_agent
3422         https://bugs.webkit.org/show_bug.cgi?id=95886
3423
3424         Reviewed by Adam Barth.
3425
3426         The code isn't used by DumpRenderTree.
3427
3428         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3429
3430 2012-09-05  Rick Byers  <rbyers@chromium.org>
3431
3432         Update chromium DumpRenderTree for new WebGestureEvent fields
3433         https://bugs.webkit.org/show_bug.cgi?id=95573
3434
3435         Reviewed by James Robinson.
3436
3437         Update EventSender to write gesture details into the appropriate
3438         type-specific WebGestureEvent fields.
3439         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
3440         (EventSender::gestureEvent):
3441         (EventSender::gestureFlingStart):
3442
3443 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
3444
3445         NRWT lies about the number of tests that it's skipping when used with --repeat-each
3446         https://bugs.webkit.org/show_bug.cgi?id=95789
3447
3448         Reviewed by Ojan Vafai.
3449
3450         Fix miscalculation in log message.
3451
3452         * Scripts/webkitpy/layout_tests/views/printing.py:
3453         (Printer.print_found):
3454
3455 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
3456
3457         Unreviewed, rolling out r127612, r127660, and r127664.
3458         http://trac.webkit.org/changeset/127612
3459         http://trac.webkit.org/changeset/127660
3460         http://trac.webkit.org/changeset/127664
3461         https://bugs.webkit.org/show_bug.cgi?id=95920
3462
3463         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3464         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3465         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3466         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3467         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3468         (MockWebRTCPeerConnectionHandler::createOffer):
3469         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3470         (MockWebRTCPeerConnectionHandler):
3471         (SuccessCallbackTask):
3472         (FailureCallbackTask):
3473
3474 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3475
3476         Ignore-metrics includes scroll offsets.
3477         https://bugs.webkit.org/show_bug.cgi?id=95845
3478
3479         Reviewed by Dirk Pranke.
3480
3481         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
3482
3483         * Scripts/old-run-webkit-tests:
3484         (stripMetrics):
3485         * Scripts/webkitpy/layout_tests/port/driver.py:
3486         (DriverOutput):
3487
3488 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
3489
3490         Unreviewed test fix.
3491
3492         Including a plugin source file into the build that was added in r127595.
3493
3494         * GNUmakefile.am:
3495
3496 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
3497
3498         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3499         https://bugs.webkit.org/show_bug.cgi?id=95839
3500
3501         Reviewed by Adam Barth.
3502
3503         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3504         up the task definitions a bit. There was no need to have them in the header file.
3505
3506         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3507         (RTCSessionDescriptionRequestSuccededTask):
3508         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3509         (RTCSessionDescriptionRequestFailedTask):
3510         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3511         (RTCVoidRequestTask):
3512         (RTCVoidRequestTask::RTCVoidRequestTask):
3513         (MockWebRTCPeerConnectionHandler::createOffer):
3514         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3515         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3516         (MockWebRTCPeerConnectionHandler::localDescription):
3517         (MockWebRTCPeerConnectionHandler::remoteDescription):
3518         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3519         (MockWebRTCPeerConnectionHandler):
3520
3521 2012-09-05  Kangil Han  <kangil.han@samsung.com>
3522
3523         [EFL] Remove '+=' usage in String
3524         https://bugs.webkit.org/show_bug.cgi?id=95808
3525
3526         Reviewed by Benjamin Poulain.
3527
3528         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
3529
3530         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3531         (descriptionSuitableForTestResult):
3532
3533 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3534
3535         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
3536         https://bugs.webkit.org/show_bug.cgi?id=95842
3537
3538         Reviewed by Kenneth Rohde Christiansen.
3539
3540         Provide proper implementation for TestRunner::pathToLocalResource()
3541         in EFL WKTR, identical to the one for DumpRenderTree.
3542
3543         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
3544         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
3545         are found my WebKitTestRunner.
3546
3547         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3548         (WTR::TestRunner::pathToLocalResource):
3549
3550 2012-09-05  Brady Eidson  <beidson@apple.com>
3551
3552         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
3553         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
3554
3555         Reviewed by Andy Estes.
3556
3557         Add a plug-in that always fails to initialize:
3558         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
3559         (NPPNewFails):
3560         (NPPNewFails::NPPNewFails):
3561         (NPPNewFails::NPP_New):
3562
3563         Add it to all the project files:
3564         * DumpRenderTree/DumpRenderTree.gypi:
3565         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3566         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3567         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3568         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3569
3570 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3571
3572         [Qt] Fix makefile race condition between derived sources and target
3573
3574         r121966 removed too much of the old qmake logic, including the rule
3575         that ensured that qmake_all would not trigger dual runs of qmake --
3576         one of the derived sources -qmake-all rule, and one for making the
3577         derived sources.
3578
3579         We now follow a similar pattern as before, by introducing a custom
3580         target that explicitly depends on the derived sources' qmake-all before
3581         doing a manual run of make. That ensures a single qmake run for the derived
3582         sources.
3583
3584         https://bugs.webkit.org/show_bug.cgi?id=93847
3585
3586         Reviewed by Csaba Osztrogonác.
3587
3588         * qmake/mkspecs/features/functions.prf:
3589
3590 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3591
3592         WKTR doesn't implement dumpWillCacheResponse()
3593         https://bugs.webkit.org/show_bug.cgi?id=94607
3594
3595         Reviewed by Kenneth Rohde Christiansen.
3596
3597         Define shouldCacheResponse() callback in resource
3598         load client and provide implementation for
3599         dumpWillCacheResponse() in WebKitTestRunner.
3600
3601         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3602         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3603         (WTR::InjectedBundlePage::InjectedBundlePage):
3604         (WTR::InjectedBundlePage::shouldCacheResponse):
3605         (WTR):
3606         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3607         (InjectedBundlePage):
3608         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3609         (WTR::TestRunner::TestRunner):
3610         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3611         (WTR::TestRunner::dumpWillCacheResponse):
3612         (WTR::TestRunner::shouldDumpWillCacheResponse):
3613         (TestRunner):
3614
3615 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3616
3617         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
3618         https://bugs.webkit.org/show_bug.cgi?id=92735
3619
3620         Reviewed by Hajime Morita.
3621
3622         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
3623
3624         * DumpRenderTree/TestRunner.cpp:
3625         (TestRunner::staticFunctions):
3626         * DumpRenderTree/TestRunner.h:
3627         (TestRunner):
3628         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3629         (TestRunner::addUserStyleSheet):
3630         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3631         (DRTTestRunner::DRTTestRunner):
3632         (DRTTestRunner::hasCustomPageSizeStyle):
3633         * DumpRenderTree/chromium/DRTTestRunner.h:
3634         (DRTTestRunner):
3635         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3636         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3637         * DumpRenderTree/mac/TestRunnerMac.mm:
3638         * DumpRenderTree/qt/TestRunnerQt.cpp:
3639         (TestRunner::evaluateScriptInIsolatedWorld):
3640         * DumpRenderTree/qt/TestRunnerQt.h:
3641         (TestRunner):
3642         * DumpRenderTree/win/TestRunnerWin.cpp:
3643         * DumpRenderTree/wx/TestRunnerWx.cpp:
3644         (TestRunner::abortModal):
3645         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3646         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3647         (WTR):
3648         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3649         (TestRunner):
3650
3651 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
3652
3653         [Qt] Automate the use of AllInOne files in the Qt build
3654         https://bugs.webkit.org/show_bug.cgi?id=95837
3655
3656         Reviewed by Tor Arne Vestbø.
3657
3658         New feature file that implements the all-in-one file automation by
3659         adding the requested all-in-one files to SOURCES and removing the files
3660         it includes from SOURCES.
3661
3662         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
3663
3664 2012-09-04  Tim Horton  <timothy_horton@apple.com>
3665
3666         Have NRWT log more output when crash logs are missing
3667         https://bugs.webkit.org/show_bug.cgi?id=95814
3668
3669         Reviewed by Dan Bernstein.
3670
3671         Log the stderr and stdout of the test, in order to provide slightly more
3672         context when the WebProcess times out while running tests.
3673
3674         * Scripts/webkitpy/layout_tests/port/driver.py:
3675         (Driver.run_test):
3676
3677 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3678
3679         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
3680         https://bugs.webkit.org/show_bug.cgi?id=95770
3681
3682         Reviewed by Adam Barth.
3683
3684         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3685         (ChromiumAndroidDriver.__init__):
3686         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
3687         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
3688         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
3689         (ChromiumAndroidDriver._push_executable):
3690         (ChromiumAndroidDriver._push_fonts):
3691         (ChromiumAndroidDriver._push_test_resources):
3692         (ChromiumAndroidDriver._run_adb_command):
3693         (ChromiumAndroidDriver._get_last_stacktrace):
3694         (ChromiumAndroidDriver._get_crash_log):
3695         (ChromiumAndroidDriver._start):
3696         (ChromiumAndroidDriver._start_once):
3697         (ChromiumAndroidDriver._start_once.deadlock_detector):
3698         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3699         (ChromiumAndroidDriverTest.test_get_crash_log):
3700
3701 2012-09-04  Satish Sampath  <satish@chromium.org>
3702
3703         Run git commands within the checkout directory
3704         https://bugs.webkit.org/show_bug.cgi?id=95742
3705
3706         Reviewed by Eric Seidel.
3707
3708         git commands run from scm/git.py are sometimes run with cwd set to the
3709         checkout_root and other times with whatever directory was the default cwd.
3710         Instead all these should run with the checkout root set as the cwd
3711         (except where we explicitly need a different path)
3712
3713         * Scripts/webkitpy/common/checkout/scm/git.py:
3714         (Git._run_git):
3715         (Git.find_checkout_root):
3716         (Git.discard_local_commits):
3717         (Git.local_commits):
3718         (Git.working_directory_is_clean):
3719         (Git.clean_working_directory):
3720         (Git.add_list):
3721         (Git.delete_list):
3722         (Git.exists):
3723         (Git._current_branch):
3724         (Git._changes_files_for_commit):
3725         (Git.revisions_changing_file):
3726         (Git.svn_revision):
3727         (Git._run_git_svn_find_rev):
3728         (Git.contents_at_revision):
3729         (Git.diff_for_file):
3730         (Git.show_head):
3731         (Git.committer_email_for_revision):
3732         (Git.apply_reverse_diff):
3733         (Git.revert_files):
3734         (Git.commit_with_message):
3735         (Git._commit_on_branch):
3736         (Git.svn_commit_log):
3737         (Git.last_svn_commit_log):
3738         (Git.svn_blame):
3739         (Git._branch_ref_exists):
3740         (Git.delete_branch):
3741         (Git.remote_merge_base):
3742         (Git.commit_locally_with_message):
3743         (Git.push_local_commits_to_server):
3744         (Git.commit_ids_from_commitish_arguments):
3745         (Git.commit_message_for_local_commit):
3746         (Git.files_changed_summary_for_commit):
3747
3748 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3749
3750         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
3751         https://bugs.webkit.org/show_bug.cgi?id=95734
3752
3753         Reviewed by Adam Barth.
3754
3755         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3756         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3757         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3758         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3759         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3760         (MockWebRTCPeerConnectionHandler::createOffer):
3761         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3762         (MockWebRTCPeerConnectionHandler):
3763         (MockWebRTCPeerConnectionHandler::taskList):
3764         (SuccessCallbackTask):
3765         (FailureCallbackTask):
3766
3767 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3768
3769         [Chromium-Android] Output time and thread info in crash log
3770         https://bugs.webkit.org/show_bug.cgi?id=95768
3771
3772         Reviewed by Adam Barth.
3773
3774         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3775         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
3776
3777 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3778
3779         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
3780         https://bugs.webkit.org/show_bug.cgi?id=95721
3781
3782         Reviewed by Adam Barth.
3783
3784         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
3785         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
3786         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
3787         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
3788         (MockWebMediaStreamCenter):
3789
3790 2012-09-04  Tony Chang  <tony@chromium.org>
3791
3792         Elide test names when running new-run-webkit-tests
3793         https://bugs.webkit.org/show_bug.cgi?id=95626
3794
3795         Reviewed by Dirk Pranke.
3796
3797         When the test name exceeds the number of terminal columns, it leaves
3798         text on the screen. Avoid this by eliding the test name when running
3799         tests. This is similar to what ninja does when compiling.
3800
3801         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3802         (MeteredStream):
3803         (MeteredStream.number_of_columns): Helper method to get number of
3804         terminal columns. Won't work on Win32 python, but meh.
3805         * Scripts/webkitpy/layout_tests/views/printing.py:
3806         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
3807         because stderr appears to be ascii only.
3808         (Printer.print_started_test): Route through _test_status_line.
3809         (Printer.print_finished_test): Route through _test_status_line.
3810         (Printer._print_test_trace): Route through _test_status_line.
3811         (Printer._print_baseline): Route through _test_status_line.
3812         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3813         (test_test_status_line): Test for _test_status_line.
3814
3815 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
3816
3817         [GTK] Print API missing documentation when generating gtkdoc
3818         https://bugs.webkit.org/show_bug.cgi?id=95703
3819
3820         Reviewed by Carlos Garcia Campos.
3821
3822         Print out API missing documentation when generating gtkdoc. This makes it
3823         easier to fix documentation errors.
3824
3825         * gtk/generate-gtkdoc:
3826         (print_missing_api): Added.
3827         (generate_doc): Inline the rebase step, since it now reports an error
3828         when you try to rebase without generating documentation first.
3829         * gtk/gtkdoc.py:
3830         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
3831         generating documentation first to enable a small cleanup at the caller.
3832         (GTKDoc.api_missing_documentation): Added.
3833
3834 2012-09-04  Vincent Scheib  <scheib@chromium.org>
3835
3836         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
3837         https://bugs.webkit.org/show_bug.cgi?id=95628
3838
3839         Reviewed by James Robinson.
3840
3841         Future tests need the ability to respond asynchronously that
3842         pointer lock requests have been accepted or rejected. This patch
3843         adds the following:
3844             testRunner.setPointerLockWillRespondAsynchronously();
3845             testRunner.didAcquirePointerLock();
3846             testRunner.didNotAcquirePointerLock();
3847
3848         Tested in existing test:
3849             pointerlockchange-pointerlockerror-events.html
3850
3851         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3852         (DRTTestRunner::DRTTestRunner):
3853         (DRTTestRunner::didAcquirePointerLock):
3854         (DRTTestRunner::didNotAcquirePointerLock):
3855         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
3856         * DumpRenderTree/chromium/DRTTestRunner.h:
3857         (DRTTestRunner):
3858         * DumpRenderTree/chromium/WebViewHost.cpp:
3859         (WebViewHost::requestPointerLock):
3860         (WebViewHost::didAcquirePointerLock):
3861         (WebViewHost::didNotAcquirePointerLock):
3862         * DumpRenderTree/chromium/WebViewHost.h:
3863         (WebViewHost):
3864         (WebViewHost::setPointerLockWillRespondAsynchronously):
3865
3866 2012-09-04  Ojan Vafai  <ojan@chromium.org>
3867
3868         Move content shell bots to their own builder group
3869         https://bugs.webkit.org/show_bug.cgi?id=95765
3870
3871         Reviewed by Adam Barth.
3872
3873         In their current state of instability, they add too much noise. Once they get more stable,
3874         we can add them back to the regular group or just have them replace the other bots.
3875
3876         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
3877
3878         * TestResultServer/static-dashboards/builders.js:
3879         (isWebkitTestRunner):
3880         (isChromiumContentShellTestRunner):
3881         (isChromiumWebkitTipOfTreeTestRunner):
3882         (loadBuildersList):
3883
3884 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
3885
3886         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
3887         https://bugs.webkit.org/show_bug.cgi?id=95689
3888
3889         Reviewed by Kenneth Rohde Christiansen.
3890
3891         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
3892         So, there are bugs that key events are always generated in url bar although
3893         the user clicked the web view.
3894
3895         This patch recovers the focus of the web view when left button is pressed and
3896         adds for MiniBrowser to toggle the focus when middle button is pressed
3897         like EWebLauncher already did.
3898
3899         * EWebLauncher/main.c:
3900         (on_mouse_down):
3901         * MiniBrowser/efl/main.c:
3902         (on_mouse_down):
3903         (browserCreate):
3904
3905 2012-09-03  Tao Bai  <michaelbai@chromium.org>
3906
3907         Added ANDROID_GDBSERVER definition for Ant
3908         https://bugs.webkit.org/show_bug.cgi?id=95265
3909
3910         Reviewed by Adam Barth.
3911
3912         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
3913         is only used for finding the gdbserver.
3914
3915         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3916         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3917
3918 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
3919
3920         MediaStream API: Add Ice-related functionality to RTCPeerConnection
3921         https://bugs.webkit.org/show_bug.cgi?id=95565
3922
3923         Reviewed by Adam Barth.
3924
3925         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3926         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3927         (MockWebRTCPeerConnectionHandler::updateICE):
3928         (MockWebRTCPeerConnectionHandler::addICECandidate):
3929         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3930         (MockWebRTCPeerConnectionHandler):
3931
3932 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
3933
3934         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
3935         https://bugs.webkit.org/show_bug.cgi?id=95670
3936
3937         Reviewed by Kenneth Rohde Christiansen.
3938
3939         Fix layout issues related to the URL bar in Minibrowser
3940         and EWebLauncher when the window is resized.
3941
3942         The URL bar was not resized accordingly and the Web
3943         page was moved behing the URL bar, hiding part of it.
3944
3945         * EWebLauncher/main.c:
3946         (on_ecore_evas_resize):
3947         (closeWindow):
3948         * EWebLauncher/url_bar.c:
3949         (url_bar_width_set):
3950         (url_bar_add):
3951         * EWebLauncher/url_bar.h:
3952         * MiniBrowser/efl/main.c:
3953         (on_ecore_evas_resize):
3954         (main):
3955
3956 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
3957
3958         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
3959         https://bugs.webkit.org/show_bug.cgi?id=95605
3960
3961         Reviewed by Dirk Pranke.
3962
3963         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
3964
3965         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3966         (ChromiumAndroidPort.check_sys_deps):
3967         (ChromiumAndroidPort.expectations_files):
3968         (ChromiumAndroidPort.clean_up_test_run):
3969
3970 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
3971
3972         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
3973         https://bugs.webkit.org/show_bug.cgi?id=95180
3974
3975         Reviewed by Chris Fleizach.
3976
3977         The bug that was fixed stood in the way of fully implementing stringValue().
3978         Testing that the bug is fixed requires stringValue() to be fully implemented
3979         and object replacement characters to be printable.
3980
3981         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3982         (replaceCharactersForResults): New method which turns object replacement
3983         characters into "<obj>" so that the characters can be properly shown in
3984         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
3985         accessible text of a single object in the accessible tree doesn't mess up
3986         the readibility of the results.
3987         (AccessibilityUIElement::stringValue): Remove the code that immediately
3988         returned upon encountering an object of ATK_ROLE_PANEL and call the new
3989         replaceCharactersForResults() prior to returning the accessible string
3990         value.
3991
3992 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
3993
3994         MediaStream API: Add MediaStream management to RTCPeerConnection
3995         https://bugs.webkit.org/show_bug.cgi?id=95543
3996
3997         Reviewed by Adam Barth.
3998
3999         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
4000
4001         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4002         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
4003         (MockWebRTCPeerConnectionHandler::addStream):
4004         (MockWebRTCPeerConnectionHandler::removeStream):
4005         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
4006         (MockWebRTCPeerConnectionHandler):
4007
4008 2012-08-31  Tony Chang  <tony@chromium.org>
4009
4010         Remove ENABLE_CSS3_FLEXBOX compile time flag
4011         https://bugs.webkit.org/show_bug.cgi?id=95382
4012
4013         Reviewed by Ojan Vafai.
4014
4015         Everyone is already enabling this by default and the spec has stablized.
4016
4017         * Scripts/webkitperl/FeatureList.pm:
4018         * qmake/mkspecs/features/features.pri:
4019
4020 2012-08-31  Pratik Solanki  <psolanki@apple.com>
4021
4022         objc_msgSend and IMP should be cast appropriately before using
4023         https://bugs.webkit.org/show_bug.cgi?id=95242
4024
4025         Reviewed by Benjamin Poulain.
4026
4027         Fix for older compilers. Pass id as the return type to the template
4028         instead of relying on default type.
4029
4030         * DumpRenderTree/mac/DumpRenderTree.mm:
4031         (drt_NSFontManager_availableFontFamilies):
4032         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
4033         (WTR::wtr_NSFontManager_availableFontFamilies):
4034
4035 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
4036
4037         nrwt: use scm instead of calling svn directly to get the revision in json results generator
4038         https://bugs.webkit.org/show_bug.cgi?id=89616
4039
4040         Reviewed by Eric Seidel.
4041
4042         Add the new 'executive' optional function argument to the SCM.in_working_directory
4043         class method. This way we get to reuse an Executive instance which is necessary in testing
4044         when we're operating with a mock version of the object.
4045
4046         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
4047         the SCMDetector with the generator's FileSystem and Executive instances.
4048
4049         * Scripts/webkitpy/common/checkout/scm/detection.py:
4050         (SCMDetector.detect_scm_system):
4051         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
4052         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
4053         Executive output and test it against expected output.
4054         * Scripts/webkitpy/common/checkout/scm/git.py:
4055         (Git.in_working_directory):
4056         * Scripts/webkitpy/common/checkout/scm/scm.py:
4057         (SCM.in_working_directory):
4058         * Scripts/webkitpy/common/checkout/scm/svn.py:
4059         (SVN.in_working_directory):
4060         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4061         (JSONResultsGeneratorBase.__init__):
4062         (JSONResultsGeneratorBase._get_svn_revision):
4063
4064 2012-08-31  Jon Lee  <jonlee@apple.com>
4065
4066         [Tests] Add basic tests to http/tests/notifications
4067         https://bugs.webkit.org/show_bug.cgi?id=95493
4068         <rdar://problem/12209303>
4069
4070         Reviewed by Alexey Proskuryakov.
4071
4072         Add permission request support for WTR.
4073
4074         * WebKitTestRunner/TestController.cpp:
4075         (WTR::TestController::initialize):
4076         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
4077         * WebKitTestRunner/TestController.h:
4078         (TestController):
4079
4080 2012-08-31  Jon Lee  <jonlee@apple.com>
4081
4082         [DRT] Make simulating a web click on a notification a queued task
4083         https://bugs.webkit.org/show_bug.cgi?id=95546
4084         <rdar://problem/12214170>
4085
4086         Reviewed by Alexey Proskuryakov.
4087
4088         Making the web click happen asynchronously better mimics user interaction with the platform.
4089
4090         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
4091         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
4092         not set.
4093         * DumpRenderTree/mac/DumpRenderTree.mm:
4094         (dump): Assert that the flag is not set.
4095         * DumpRenderTree/mac/TestRunnerMac.mm:
4096         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
4097         notification. In the case where the block gets executed after the flag has been unset, we avoid
4098         performing the click.
4099
4100 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
4101
4102         [Qt] ImageDiff output is not in the expected form if image dimensions differ
4103         https://bugs.webkit.org/show_bug.cgi?id=95575
4104
4105         Reviewed by Csaba Osztrogonác.
4106
4107         Output 100% difference in the case of differing image dimensions so
4108         the test harness knows that we won't produce any output further.
4109         This matches the behavior of other ports.
4110
4111         * DumpRenderTree/qt/ImageDiff.cpp:
4112         (main):
4113
4114 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
4115
4116         Unreviewed, rolling out r127261.
4117         http://trac.webkit.org/changeset/127261
4118         https://bugs.webkit.org/show_bug.cgi?id=95572
4119
4120         This patch depends on other build fixes (see blockers of bug
4121         95466) which should land first (Requested by milian on
4122         #webkit).
4123
4124         * qmake/mkspecs/features/features.prf:
4125
4126 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
4127
4128         [Qt] Support WebKit2/QML on QNX
4129         https://bugs.webkit.org/show_bug.cgi?id=95466
4130
4131         Reviewed by Noam Rosenthal.
4132
4133         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
4134         this should finally work now.
4135
4136         * qmake/mkspecs/features/features.prf:
4137
4138 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
4139
4140         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
4141         https://bugs.webkit.org/show_bug.cgi?id=95400
4142
4143         Reviewed by Dirk Pranke.
4144
4145         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
4146
4147         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4148         (ChromiumAndroidPort.skipped_layout_tests):
4149
4150 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
4151
4152         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
4153         https://bugs.webkit.org/show_bug.cgi?id=95499
4154
4155         Unreviewed. One more fix to avoid trying to run the empty string.
4156
4157         * Scripts/webkitdirs.pm:
4158         (buildAutotoolsProject):
4159
4160 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
4161
4162         Unreviewed, rolling out r127171.
4163         http://trac.webkit.org/changeset/127171
4164         https://bugs.webkit.org/show_bug.cgi?id=95505
4165
4166         testRunner does not need dumpWebNotificationCallbacks().
4167         (Requested by jonlee on #webkit).
4168
4169         * DumpRenderTree/TestRunner.cpp:
4170         (TestRunner::TestRunner):
4171         (TestRunner::staticFunctions):
4172         * DumpRenderTree/TestRunner.h:
4173         (TestRunner):
4174         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
4175         (-[MockWebNotificationProvider webView:didShowNotification:]):
4176         (-[MockWebNotificationProvider webView:didClickNotification:]):
4177         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
4178         * DumpRenderTree/mac/UIDelegate.mm:
4179         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
4180
4181 2012-08-30  Pratik Solanki  <psolanki@apple.com>
4182
4183         objc_msgSend and IMP should be cast appropriately before using
4184         https://bugs.webkit.org/show_bug.cgi?id=95242
4185
4186         Reviewed by Benjamin Poulain.
4187
4188         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
4189         to a function pointer with right types when calling objc_msgSend and an
4190         IMP method directly.
4191
4192         * DumpRenderTree/mac/DumpRenderTree.mm:
4193         (drt_NSFontManager_availableFontFamilies):
4194         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
4195         (WTR::wtr_NSFontManager_availableFontFamilies):
4196
4197 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
4198
4199         Replace JSC::UString by WTF::String
4200         https://bugs.webkit.org/show_bug.cgi?id=95271
4201
4202         Reviewed by Geoffrey Garen.
4203
4204         Get rid of UString.
4205
4206         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
4207         * gdb/webkit.py:
4208         (WTFStringPrinter.to_string):
4209         (JSCIdentifierPrinter.to_string):
4210         (JSCJSStringPrinter.to_string):
4211         (add_pretty_printers):
4212
4213 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
4214
4215         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
4216         https://bugs.webkit.org/show_bug.cgi?id=95495
4217
4218         Reviewed by Ojan Vafai.
4219
4220         This is a follow-on to bug 95370 that adds in support for
4221         platform/wk2/TestExpectations and
4222         platform/{mac,win}-$version/TestExpectations.
4223
4224         * Scripts/webkitpy/layout_tests/port/apple.py:
4225         (ApplePort.expectations_files):
4226         * Scripts/webkitpy/layout_tests/port/base.py:
4227         (Port._skipped_file_search_paths):
4228         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4229         (MacTest.test_expectations_files):
4230         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
4231         (MockDRTPortTest.make_port):
4232         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4233         (WinPortTest.test_expectations_files):
4234
4235 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
4236
4237         executive.run_in_parallel() hangs if given nothing to do
4238         https://bugs.webkit.org/show_bug.cgi?id=95387
4239
4240         Reviewed by Ojan Vafai.
4241
4242         Check to make sure that Executive.run_in_parallel() requires
4243         a non-empty list of commands to execute; passing an empty list
4244         seems surely like a programming error.
4245
4246         * Scripts/webkitpy/common/system/executive.py:
4247         (Executive.run_in_parallel):
4248         * Scripts/webkitpy/common/system/executive_unittest.py:
4249         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
4250
4251 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
4252
4253         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
4254         https://bugs.webkit.org/show_bug.cgi?id=94746
4255
4256         Reviewed by Ojan Vafai.
4257
4258         Add an assertion to diff_image() to check that we are passing
4259         tolerance=0 explicitly when diffing ref test results.
4260
4261         * Scripts/webkitpy/layout_tests/port/test.py:
4262         (TestPort.diff_image):
4263
4264 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
4265
4266         NRWT should look in mac-wk2 for a TestExpecations file
4267         https://bugs.webkit.org/show_bug.cgi?id=95370
4268
4269         Reviewed by Ojan Vafai.
4270
4271         Adds support for mac-wk2 and win-wk2 to expectations_files()
4272         for the apple mac and apple win ports.
4273         
4274         * Scripts/webkitpy/layout_tests/port/apple.py:
4275         (ApplePort.expectations_files):
4276         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4277         (MacTest.test_expectations_files):
4278         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4279         (WinTest.test_expectations_files):
4280         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4281         (PortTestCase.test_expectations_files):
4282
4283 2012-08-30  Jon Lee  <jonlee@apple.com>
4284
4285         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
4286         https://bugs.webkit.org/show_bug.cgi?id=95232
4287         <rdar://problem/12190776>
4288
4289         Reviewed by Alexey Proskuryakov.
4290
4291         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
4292
4293         * DumpRenderTree/TestRunner.cpp:
4294         (TestRunner::TestRunner):
4295         (dumpWebNotificationCallbacksCallback):
4296         (TestRunner::staticFunctions):
4297         * DumpRenderTree/TestRunner.h:
4298         (TestRunner):
4299         (TestRunner::dumpWebNotificationCallbacks):
4300         (TestRunner::setDumpWebNotificationCallbacks):
4301         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
4302         (-[WebNotification _drt_descriptionSuitableForTestResult]):
4303         (-[MockWebNotificationProvider webView:didShowNotification:]):
4304         (-[MockWebNotificationProvider webView:didClickNotification:]):
4305         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
4306         * DumpRenderTree/mac/UIDelegate.mm:
4307         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
4308
4309 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
4310
4311         MediaStream API: Introduce MediaConstraints
4312         https://bugs.webkit.org/show_bug.cgi?id=95198
4313
4314         Reviewed by Adam Barth.
4315
4316         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
4317
4318         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4319         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
4320         (isSupportedConstraint):
4321         (isValidConstraint):
4322         (MockWebRTCPeerConnectionHandler::initialize):
4323         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
4324         (MockWebRTCPeerConnectionHandler):
4325
4326 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4327
4328         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
4329         https://bugs.webkit.org/show_bug.cgi?id=95454
4330
4331         Reviewed by Kenneth Rohde Christiansen.
4332
4333         Added didReceiveServerRedirectForProvisionalLoadForFrame dum