REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
4         https://bugs.webkit.org/show_bug.cgi?id=194630
5
6         Reviewed by Michael Catanzaro.
7
8         Return early from getAttributeSet() is passed in accessible is nullptr.
9
10         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
11
12 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
13
14         Defer EditorState updates until the next layer tree flush in a few additional circumstances
15         https://bugs.webkit.org/show_bug.cgi?id=197145
16         <rdar://problem/50078170>
17
18         Reviewed by Darin Adler.
19
20         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
21         focus, or showing the font manager.
22
23         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
24         (TestWebKitAPI::TEST):
25         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
26         (TEST):
27         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
28         (TestWebKitAPI::TEST):
29
30 2019-04-21  Brian Burg  <bburg@apple.com>
31
32         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
33         https://bugs.webkit.org/show_bug.cgi?id=197125
34         <rdar://problem/50061468>
35
36         Reviewed by Darin Adler.
37
38         Sometimes I want to run wptserve independently of tests. Make it easier to script that
39         using this class rather than making our own ./wpt serve invocation.
40
41         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
42         (WebDriverW3CWebServer):
43         (WebDriverW3CWebServer.document_root): Expose this to clients.
44         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
45
46         (WebDriverW3CWebServer.__enter__):
47         (WebDriverW3CWebServer.__exit__):
48         Make it possible to use the web server with a 'with' statement.
49
50 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
51
52         [CMake][Win] Use target oriented design for WebKitLegacy
53         https://bugs.webkit.org/show_bug.cgi?id=197112
54
55         Reviewed by Konstantin Tokarev.
56
57         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
58
59         * DumpRenderTree/CMakeLists.txt:
60         * DumpRenderTree/PlatformWin.cmake:
61         * DumpRenderTree/win/EventSender.cpp:
62
63 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
64
65         Update text for old EWS submit button
66         https://bugs.webkit.org/show_bug.cgi?id=197140
67
68         Reviewed by Alexey Proskuryakov.
69
70         * QueueStatusServer/templates/statusbubble.html:
71
72 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
73
74         [ews-app] New EWS should poll bugzilla more frequently
75         https://bugs.webkit.org/show_bug.cgi?id=197138
76
77         Reviewed by Alexey Proskuryakov.
78
79         * BuildSlaveSupport/ews-app/ews/fetcher.py:
80         (FetchLoop.__init__):
81
82 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
83
84         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
85         https://bugs.webkit.org/show_bug.cgi?id=197139
86
87         Reviewed by Alexey Proskuryakov.
88
89         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
90         * QueueStatusServer/templates/statusbubble.html:
91
92 2019-04-20  Chris Dumez  <cdumez@apple.com>
93
94         Unreviewed, fix iOS build with recent SDKs.
95
96         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
97
98 2019-04-19  Keith Miller  <keith_miller@apple.com>
99
100         Add script to merge run_benchmark jsons
101         https://bugs.webkit.org/show_bug.cgi?id=197107
102
103         Reviewed by Michael Saboff.
104
105         The script basically recursively decends through all json objects until it gets
106         to an array or JSON primitive and concats or takes the first value, respectively.
107
108         This patch also adds +x bits to the compare-results script so it
109         can be run directly from the command line. I had to add a new line so that svn
110         will accept the change... yay svn!
111
112         * Scripts/compare-results:
113         * Scripts/merge-result-jsons: Added.
114         (readJSONFile):
115         (deepAppend):
116         (mergeJSONs):
117         (main):
118
119 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
120
121         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
122         https://bugs.webkit.org/show_bug.cgi?id=197079
123
124         Reviewed by Darin Adler.
125
126         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
127
128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
129         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
130
131 2019-04-18  Commit Queue  <commit-queue@webkit.org>
132
133         Unreviewed, rolling out r244434.
134         https://bugs.webkit.org/show_bug.cgi?id=197089
135
136         caused 1 API test failure (Requested by zalan on #webkit).
137
138         Reverted changeset:
139
140         "Regression (r244291): Broken API Test
141         AutoLayoutRenderingProgressRelativeOrdering"
142         https://bugs.webkit.org/show_bug.cgi?id=196948
143         https://trac.webkit.org/changeset/244434
144
145 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
146
147         Add new compatibility mode API on WKNavigation
148         https://bugs.webkit.org/show_bug.cgi?id=197069
149         <rdar://problem/50025800>
150
151         Reviewed by Tim Horton.
152
153         Add a block property for -didCommitNavigation to TestNavigationDelegate.
154
155         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
156         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
157         (-[TestNavigationDelegate webView:didCommitNavigation:]):
158
159 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
160
161         [CMake] Make WebCore headers copies
162         https://bugs.webkit.org/show_bug.cgi?id=182512
163         <rdar://problem/37510435>
164
165         Reviewed by Alex Christensen.
166
167         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
168         ports.
169
170         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
171         of WebCore headers using "*.h" were modified to <WebCore/*.h>
172
173         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
174         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
175         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
176         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
177         * TestWebKitAPI/CMakeLists.txt:
178         * TestWebKitAPI/PlatformWin.cmake:
179         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
180         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
181         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
182
183 2019-04-18  Jer Noble  <jer.noble@apple.com>
184
185         Add support for parsing FairPlayStreaming PSSH boxes.
186         https://bugs.webkit.org/show_bug.cgi?id=197064
187
188         Reviewed by Eric Carlson.
189
190         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
191         (TestWebKitAPI::TEST):
192
193 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
194
195         InjectedBundle parameters often need initialization function called before unarchiving
196         https://bugs.webkit.org/show_bug.cgi?id=189709
197         <rdar://problem/44573653>
198
199         Reviewed by Ryosuke Niwa.
200
201         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
202         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
203
204 2019-04-18  Zalan Bujtas  <zalan@apple.com>
205
206         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
207         https://bugs.webkit.org/show_bug.cgi?id=196948
208         <rdar://problem/49927131>
209
210         Reviewed by Tim Horton.
211
212         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
213         (TEST): 
214         The expected order of incoming events is
215         1. didInvalidateIntrinsicContentSize
216         2. didFirstLayout
217         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
218         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
219         (and remember, all we care about is ordering).
220
221 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
222
223         Unreviewed, rolling out r244299.
224
225         Breaks internal tests.
226
227         Reverted changeset:
228
229         "InjectedBundle parameters often need initialization function
230         called before unarchiving"
231         https://bugs.webkit.org/show_bug.cgi?id=189709
232         https://trac.webkit.org/changeset/244299
233
234 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
235
236         [WTF] StringBuilder should set correct m_is8Bit flag when merging
237         https://bugs.webkit.org/show_bug.cgi?id=197053
238
239         Reviewed by Saam Barati.
240
241         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
242         (TestWebKitAPI::TEST):
243
244 2019-04-17  Tim Horton  <timothy_horton@apple.com>
245
246         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
247         https://bugs.webkit.org/show_bug.cgi?id=197028
248         <rdar://problem/49985290>
249
250         Reviewed by Wenson Hsieh.
251
252         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
253         (TEST):
254         Liberal application of waitForNextPresentationUpdate works around a race
255         where if the page rapidly changes its viewport arguments (or an API client
256         rapidly changes its viewport arguments), we'd get stuck thinking that the
257         user had intentionally zoomed the page, and stop resetting the initial scale.
258         This deserves a separate bug, but no need to keep the test failing while
259         we think about it.
260
261 2019-04-17  Tim Horton  <timothy_horton@apple.com>
262
263         REGRESSION (r241988): Switching tabs is slow
264         https://bugs.webkit.org/show_bug.cgi?id=197037
265         <rdar://problem/49951473>
266
267         Reviewed by Simon Fraser.
268
269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
270         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
271         (TEST):
272         * TestWebKitAPI/cocoa/TestWKWebView.h:
273         * TestWebKitAPI/cocoa/TestWKWebView.mm:
274         (-[TestWKWebView addToTestWindow]):
275         Add a test that hangs without this fix.
276
277 2019-04-17  Truitt Savell  <tsavell@apple.com>
278
279         Unreviewed, rolling out r244400.
280
281         Caused testing to exit early with assertionon Debug WK2
282
283         Reverted changeset:
284
285         "UI↔Web deadlock when printing with a JavaScript alert
286         visible"
287         https://bugs.webkit.org/show_bug.cgi?id=196839
288         https://trac.webkit.org/changeset/244400
289
290 2019-04-17  Brady Eidson  <beidson@apple.com>
291
292         Link clicks in PDFs shouldn't send referrer headers.
293         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
294
295         Reviewed by Tim Horton.
296
297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
298         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
299         (putPDFBytesCallback):
300         (emptyReleaseInfoCallback):
301         (createPDFWithLinkToURL):
302         (TEST):
303
304 2019-04-17  Tim Horton  <timothy_horton@apple.com>
305
306         UI↔Web deadlock when printing with a JavaScript alert visible
307         https://bugs.webkit.org/show_bug.cgi?id=196839
308         <rdar://problem/49157642>
309
310         Reviewed by Andy Estes.
311
312         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
313         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
314         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
315         (TEST):
316
317 2019-04-17  Alex Christensen  <achristensen@webkit.org>
318
319         WKRetainPtr's adoption constructor should be private
320         https://bugs.webkit.org/show_bug.cgi?id=197019
321
322         Reviewed by Tim Horton.
323
324         * DumpRenderTree/mac/DumpRenderTree.mm:
325         (dumpFramesAsText):
326         * TestWebKitAPI/InjectedBundleController.cpp:
327         (TestWebKitAPI::InjectedBundleController::initialize):
328         * TestWebKitAPI/PlatformUtilities.cpp:
329         (TestWebKitAPI::Util::createContextWithInjectedBundle):
330         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
331         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
332         (TestWebKitAPI::Util::toWK):
333         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
334         (TestWebKitAPI::TEST):
335         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
336         (TestWebKitAPI::TEST):
337         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
338         (TestWebKitAPI::TEST):
339         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
340         (TestWebKitAPI::TEST):
341         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
342         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
343         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
344         (TestWebKitAPI::TEST):
345         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
346         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
347         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
348         (TestWebKitAPI::TEST):
349         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
350         (TestWebKitAPI::TEST):
351         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
352         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
353         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
354         (TestWebKitAPI::TEST):
355         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
356         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
357         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
358         (TestWebKitAPI::TEST):
359         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
360         (TestWebKitAPI::TEST):
361         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
362         (TestWebKitAPI::TEST):
363         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
364         (TestWebKitAPI::TEST):
365         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
366         (TestWebKitAPI::TEST):
367         * TestWebKitAPI/Tests/WebKit/Find.cpp:
368         (TestWebKitAPI::TEST):
369         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
370         (TestWebKitAPI::TEST):
371         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
372         (TestWebKitAPI::TEST):
373         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
374         (TestWebKitAPI::TEST):
375         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
376         (TestWebKitAPI::TEST):
377         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
378         (TestWebKitAPI::TEST):
379         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
380         (TestWebKitAPI::TEST):
381         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
382         (TestWebKitAPI::TEST):
383         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
384         (TestWebKitAPI::TEST):
385         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
386         (TestWebKitAPI::TEST):
387         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
388         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
389         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
390         (TestWebKitAPI::TEST):
391         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
392         (TestWebKitAPI::TEST):
393         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
394         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
395         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
396         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
397         (TestWebKitAPI::TEST):
398         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
399         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
400         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
401         (TestWebKitAPI::TEST):
402         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
403         (TestWebKitAPI::TEST):
404         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
405         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
406         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
407         (TestWebKitAPI::TEST):
408         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
409         (TestWebKitAPI::loadAlternateHTMLString):
410         (TestWebKitAPI::TEST):
411         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
412         (TestWebKitAPI::TEST):
413         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
414         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
415         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
416         (TestWebKitAPI::buildAndPerformTest):
417         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
418         (TestWebKitAPI::TEST):
419         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
420         (TestWebKitAPI::TEST):
421         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
422         (TestWebKitAPI::TEST):
423         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
424         (TestWebKitAPI::TEST):
425         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
426         (TestWebKitAPI::TEST):
427         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
428         (TestWebKitAPI::TEST):
429         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
430         (TestWebKitAPI::TEST):
431         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
432         (TestWebKitAPI::TEST):
433         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
434         (TestWebKitAPI::TEST):
435         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
436         (TestWebKitAPI::TEST):
437         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
438         (TestWebKitAPI::TEST):
439         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
440         (TestWebKitAPI::TEST):
441         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
442         (TestWebKitAPI::TEST):
443         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
444         (TestWebKitAPI::TEST):
445         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
446         (TestWebKitAPI::TEST):
447         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
448         (TestWebKitAPI::TEST):
449         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
450         (TestWebKitAPI::TEST):
451         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
452         (TestWebKitAPI::TEST):
453         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
454         (TestWebKitAPI::TEST):
455         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
456         (TestWebKitAPI::TEST):
457         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
458         (TestWebKitAPI::TEST):
459         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
460         (TestWebKitAPI::TEST):
461         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
462         (TestWebKitAPI::TEST):
463         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
464         (TestWebKitAPI::TEST):
465         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
466         (TestWebKitAPI::TEST):
467         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
468         (TestWebKitAPI::TEST):
469         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
470         (TestWebKitAPI::TEST):
471         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
472         (TestWebKitAPI::TEST):
473         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
474         (TestWebKitAPI::TEST):
475         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
476         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
477         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
478         (TestWebKitAPI::TEST):
479         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
480         (TestWebKitAPI::TEST):
481         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
482         (TestWebKitAPI::TEST):
483         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
484         (TestWebKitAPI::TEST):
485         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
486         (TestWebKitAPI::TEST):
487         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
488         (TestWebKitAPI::TEST):
489         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
490         (TestWebKitAPI::TEST):
491         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
492         (TestWebKitAPI::TEST):
493         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
494         (TestWebKitAPI::TEST):
495         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
496         (TestWebKitAPI::TEST):
497         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
498         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
499         (TEST):
500         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
501         (TEST):
502         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
503         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
504         (TEST):
505         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
506         (TestWebKitAPI::TEST):
507         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
508         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
509         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
510         (WTR::getMenuItemTitleCallback):
511         (WTR::createMouseMessageBody):
512         (WTR::EventSendingController::mouseDown):
513         (WTR::EventSendingController::mouseUp):
514         (WTR::EventSendingController::mouseMoveTo):
515         (WTR::EventSendingController::mouseForceClick):
516         (WTR::EventSendingController::startAndCancelMouseForceClick):
517         (WTR::EventSendingController::mouseForceDown):
518         (WTR::EventSendingController::mouseForceUp):
519         (WTR::EventSendingController::mouseForceChanged):
520         (WTR::EventSendingController::leapForward):
521         (WTR::EventSendingController::scheduleAsynchronousClick):
522         (WTR::createKeyDownMessageBody):
523         (WTR::EventSendingController::keyDown):
524         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
525         (WTR::EventSendingController::mouseScrollBy):
526         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
527         (WTR::EventSendingController::continuousMouseScrollBy):
528         (WTR::EventSendingController::addTouchPoint):
529         (WTR::EventSendingController::updateTouchPoint):
530         (WTR::EventSendingController::setTouchModifier):
531         (WTR::EventSendingController::setTouchPointRadius):
532         (WTR::EventSendingController::touchStart):
533         (WTR::EventSendingController::touchMove):
534         (WTR::EventSendingController::touchEnd):
535         (WTR::EventSendingController::touchCancel):
536         (WTR::EventSendingController::clearTouchPoints):
537         (WTR::EventSendingController::releaseTouchPoint):
538         (WTR::EventSendingController::cancelTouchPoint):
539         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
540         (WTR::InjectedBundle::didCreatePage):
541         (WTR::InjectedBundle::didReceiveMessage):
542         (WTR::InjectedBundle::didReceiveMessageToPage):
543         (WTR::InjectedBundle::booleanForKey):
544         (WTR::InjectedBundle::done):
545         (WTR::InjectedBundle::dumpToStdErr):
546         (WTR::InjectedBundle::outputText):
547         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
548         (WTR::InjectedBundle::postAddChromeInputField):
549         (WTR::InjectedBundle::postRemoveChromeInputField):
550         (WTR::InjectedBundle::postFocusWebView):
551         (WTR::InjectedBundle::postSetBackingScaleFactor):
552         (WTR::InjectedBundle::postSetWindowIsKey):
553         (WTR::InjectedBundle::postSetViewSize):
554         (WTR::InjectedBundle::postSimulateWebNotificationClick):
555         (WTR::InjectedBundle::postSetAddsVisitedLinks):
556         (WTR::InjectedBundle::setGeolocationPermission):
557         (WTR::InjectedBundle::setMockGeolocationPosition):
558         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
559         (WTR::InjectedBundle::isGeolocationProviderActive const):
560         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
561         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
562         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
563         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
564         (WTR::InjectedBundle::setCustomPolicyDelegate):
565         (WTR::InjectedBundle::setHidden):
566         (WTR::InjectedBundle::setCacheModel):
567         (WTR::InjectedBundle::shouldProcessWorkQueue const):
568         (WTR::InjectedBundle::processWorkQueue):
569         (WTR::InjectedBundle::queueBackNavigation):
570         (WTR::InjectedBundle::queueForwardNavigation):
571         (WTR::InjectedBundle::queueLoad):
572         (WTR::InjectedBundle::queueLoadHTMLString):
573         (WTR::InjectedBundle::queueReload):
574         (WTR::InjectedBundle::queueLoadingScript):
575         (WTR::InjectedBundle::queueNonLoadingScript):
576         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
577         (WTR::frameToStr):
578         (WTR::InjectedBundlePage::InjectedBundlePage):
579         (WTR::dumpFrameDescriptionSuitableForTestResult):
580         (WTR::dumpFrameScrollPosition):
581         (WTR::dumpDescendantFrameScrollPositions):
582         (WTR::dumpFrameText):
583         (WTR::dumpDescendantFramesText):
584         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
585         (WTR::TestRunner::shouldDumpPixels const):
586         (WTR::TestRunner::setDumpPixels):
587         (WTR::TestRunner::whatToDump const):
588         (WTR::TestRunner::setWhatToDump):
589         (WTR::TestRunner::setWaitUntilDone):
590         (WTR::TestRunner::shouldWaitUntilDone const):
591         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
592         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
593         (WTR::TestRunner::clearAllDatabases):
594         (WTR::TestRunner::setIDBPerOriginQuota):
595         (WTR::TestRunner::originsWithApplicationCache):
596         (WTR::TestRunner::setCanOpenWindows):
597         (WTR::TestRunner::setXSSAuditorEnabled):
598         (WTR::TestRunner::setMediaDevicesEnabled):
599         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
600         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
601         (WTR::TestRunner::setCustomUserAgent):
602         (WTR::TestRunner::setWebAPIStatisticsEnabled):
603         (WTR::TestRunner::setModernMediaControlsEnabled):
604         (WTR::TestRunner::setWebGL2Enabled):
605         (WTR::TestRunner::setWritableStreamAPIEnabled):
606         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
607         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
608         (WTR::TestRunner::setAllowsAnySSLCertificate):
609         (WTR::TestRunner::setPluginsEnabled):
610         (WTR::TestRunner::setValueForUser):
611         (WTR::TestRunner::setAudioResult):
612         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
613         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
614         (WTR::TestRunner::setAlwaysAcceptCookies):
615         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
616         (WTR::TestRunner::isDoingMediaCapture const):
617         (WTR::TestRunner::queueLoad):
618         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
619         (WTR::TestRunner::setHandlesAuthenticationChallenges):
620         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
621         (WTR::TestRunner::setShouldLogDownloadCallbacks):
622         (WTR::TestRunner::setAuthenticationUsername):
623         (WTR::TestRunner::setAuthenticationPassword):
624         (WTR::TestRunner::secureEventInputIsEnabled const):
625         (WTR::TestRunner::setBlockAllPlugins):
626         (WTR::TestRunner::setPluginSupportedMode):
627         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
628         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
629         (WTR::TestRunner::setNavigationGesturesEnabled):
630         (WTR::TestRunner::setIgnoresViewportScaleLimits):
631         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
632         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
633         (WTR::TestRunner::terminateNetworkProcess):
634         (WTR::TestRunner::terminateServiceWorkerProcess):
635         (WTR::TestRunner::runUIScript):
636         (WTR::TestRunner::setStatisticsDebugMode):
637         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
638         (WTR::TestRunner::setStatisticsLastSeen):
639         (WTR::TestRunner::setStatisticsPrevalentResource):
640         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
641         (WTR::TestRunner::dumpResourceLoadStatistics):
642         (WTR::TestRunner::isStatisticsPrevalentResource):
643         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
644         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
645         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
646         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
647         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
648         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
649         (WTR::TestRunner::setStatisticsGrandfathered):
650         (WTR::TestRunner::isStatisticsGrandfathered):
651         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
652         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
653         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
654         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
655         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
656         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
657         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
658         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
659         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
660         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
661         (WTR::TestRunner::statisticsUpdateCookieBlocking):
662         (WTR::TestRunner::statisticsSubmitTelemetry):
663         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
664         (WTR::TestRunner::setStatisticsIsRunningTest):
665         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
666         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
667         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
668         (WTR::TestRunner::setStatisticsGrandfatheringTime):
669         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
670         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
671         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
672         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
673         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
674         (WTR::TestRunner::statisticsDeleteCookiesForHost):
675         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
676         (WTR::TestRunner::statisticsResetToConsistentState):
677         (WTR::TestRunner::setStorageAccessAPIEnabled):
678         (WTR::TestRunner::getAllStorageAccessEntries):
679         (WTR::TestRunner::addMockMediaDevice):
680         (WTR::TestRunner::clearMockMediaDevices):
681         (WTR::TestRunner::removeMockMediaDevice):
682         (WTR::TestRunner::resetMockMediaDevices):
683         (WTR::TestRunner::connectMockGamepad):
684         (WTR::TestRunner::disconnectMockGamepad):
685         (WTR::TestRunner::setMockGamepadDetails):
686         (WTR::TestRunner::setMockGamepadAxisValue):
687         (WTR::TestRunner::setMockGamepadButtonValue):
688         (WTR::TestRunner::removeAllSessionCredentials):
689         (WTR::TestRunner::clearDOMCache):
690         (WTR::TestRunner::clearDOMCaches):
691         (WTR::TestRunner::hasDOMCache):
692         (WTR::TestRunner::domCacheSize):
693         (WTR::TestRunner::setAllowStorageQuotaIncrease):
694         (WTR::TestRunner::getApplicationManifestThen):
695         (WTR::TestRunner::injectUserScript):
696         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
697         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
698         (WTR::TestRunner::addTestKeyToKeychain):
699         (WTR::TestRunner::cleanUpKeychain):
700         (WTR::TestRunner::keyExistsInKeychain):
701         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
702         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
703         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
704         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
705         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
706         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
707         * WebKitTestRunner/TestController.cpp:
708         (WTR::TestController::initialize):
709         (WTR::parseStringTestHeaderValueAsRelativePath):
710         (WTR::updateTestOptionsFromTestHeader):
711         (WTR::TestController::runTest):
712         (WTR::TestController::didReceiveLiveDocumentsList):
713         (WTR::TestController::didReceiveMessageFromInjectedBundle):
714         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
715         (WTR::TestController::didFinishNavigation):
716         (WTR::TestController::didReceiveAuthenticationChallenge):
717         * WebKitTestRunner/TestInvocation.cpp:
718         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
719         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
720         (WTR::TestInvocation::uiScriptDidComplete):
721         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
722         * WebKitTestRunner/WebNotificationProvider.cpp:
723         (WTR::WebNotificationProvider::closeWebNotification):
724         * WebKitTestRunner/WorkQueueManager.cpp:
725         (WTR::ScriptItem::ScriptItem):
726         (WTR::WorkQueueManager::queueLoad):
727         (WTR::WorkQueueManager::queueLoadHTMLString):
728
729 2019-04-17  Alex Christensen  <achristensen@webkit.org>
730
731         Add a comment to make my test from r244139 less mysterious.
732         https://bugs.webkit.org/show_bug.cgi?id=196744
733
734         As suggested by Darin Adler.
735
736         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
737         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
738
739 2019-04-17  Chris Dumez  <cdumez@apple.com>
740
741         Remember device orientation permission for the duration of the browsing session
742         https://bugs.webkit.org/show_bug.cgi?id=196992
743         <rdar://problem/49946067>
744
745         Reviewed by Alex Christensen.
746
747         Add API test coverage.
748
749         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
750         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
751         (TEST):
752
753 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
754
755         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
756         https://bugs.webkit.org/show_bug.cgi?id=196675
757
758         Reviewed by Lucas Forschler.
759
760         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
761         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
762
763 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
764
765         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
766         https://bugs.webkit.org/show_bug.cgi?id=196919
767         <rdar://problem/41630459>
768
769         Reviewed by Tim Horton.
770
771         Add iOS support for several new testing hooks. See below for more detail.
772
773         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
774         (WTR::UIScriptController::isDismissingMenu const):
775
776         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
777         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
778         by UIKit when dismissing the callout bar (i.e. UIMenuController).
779
780         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
781         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
782         (WTR::UIScriptController::isDismissingMenu const):
783         * TestRunnerShared/UIScriptContext/UIScriptController.h:
784         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
785         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
786         (WTR::InjectedBundle::didReceiveMessageToPage):
787         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
788         (WTR::TestRunner::setAllowedMenuActions):
789
790         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
791         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
792         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
793         against the name of the custom action.
794
795         (WTR::TestRunner::installCustomMenuAction):
796
797         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
798         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
799         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
800         triggered.
801
802         (WTR::TestRunner::performCustomMenuAction):
803
804         Invoked when the custom menu action is triggered.
805
806         * WebKitTestRunner/InjectedBundle/TestRunner.h:
807         * WebKitTestRunner/TestController.cpp:
808         (WTR::TestController::installCustomMenuAction):
809         (WTR::TestController::setAllowedMenuActions):
810         * WebKitTestRunner/TestController.h:
811         * WebKitTestRunner/TestInvocation.cpp:
812         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
813         (WTR::TestInvocation::performCustomMenuAction):
814
815         Add plumbing to call back into the injected bundle when performing the custom action.
816
817         * WebKitTestRunner/TestInvocation.h:
818         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
819         (WTR::TestController::installCustomMenuAction):
820         (WTR::TestController::setAllowedMenuActions):
821         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
822         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
823         (-[TestRunnerWKWebView initWithFrame:configuration:]):
824         (-[TestRunnerWKWebView becomeFirstResponder]):
825         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
826
827         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
828         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
829         in the Mail app on iOS.
830
831         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
832         (-[TestRunnerWKWebView setAllowedMenuActions:]):
833         (-[TestRunnerWKWebView resetCustomMenuAction]):
834         (-[TestRunnerWKWebView performCustomAction:]):
835         (-[TestRunnerWKWebView canPerformAction:withSender:]):
836         (-[TestRunnerWKWebView _willHideMenu]):
837         (-[TestRunnerWKWebView _didHideMenu]):
838         * WebKitTestRunner/ios/TestControllerIOS.mm:
839         (WTR::TestController::platformResetStateToConsistentValues):
840
841         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
842         if specified.
843
844         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
845         (WTR::UIScriptController::isDismissingMenu const):
846
847 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
848
849         Allow sharing from imageSheet on an image document
850         https://bugs.webkit.org/show_bug.cgi?id=196891
851         <rdar://problem/25377386>
852
853         Reviewed by Tim Horton.
854
855         Test to make sure that the correct imageURL is extracted from an image element.
856
857         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
858         (TestWebKitAPI::TEST):
859
860 2019-04-16  Alex Christensen  <achristensen@webkit.org>
861
862         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
863         https://bugs.webkit.org/show_bug.cgi?id=196995
864
865         Reviewed by Brady Eidson.
866
867         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
868         (TEST):
869
870 2019-04-16  Chris Dumez  <cdumez@apple.com>
871
872         URL set by document.open() is not communicated to the UIProcess
873         https://bugs.webkit.org/show_bug.cgi?id=196941
874         <rdar://problem/49237544>
875
876         Reviewed by Geoff Garen.
877
878         Add API test coverage.
879
880         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
881         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
882         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
883         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
884         (TEST):
885
886 2019-04-16  Commit Queue  <commit-queue@webkit.org>
887
888         Unreviewed, rolling out r244321.
889         https://bugs.webkit.org/show_bug.cgi?id=196968
890
891         Causing all WK2 Debug builds to exit early after Assertion
892         failures. (Requested by ShawnRoberts on #webkit).
893
894         Reverted changeset:
895
896         "URL set by document.open() is not communicated to the
897         UIProcess"
898         https://bugs.webkit.org/show_bug.cgi?id=196941
899         https://trac.webkit.org/changeset/244321
900
901 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
902
903         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
904         https://bugs.webkit.org/show_bug.cgi?id=196948
905
906         Reviewed by Zalan Bujtas.
907
908         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
909         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
910
911 2019-04-15  Chris Dumez  <cdumez@apple.com>
912
913         URL set by document.open() is not communicated to the UIProcess
914         https://bugs.webkit.org/show_bug.cgi?id=196941
915         <rdar://problem/49237544>
916
917         Reviewed by Geoffrey Garen.
918
919         Add API test coverage.
920
921         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
922         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
923         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
924         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
925         (TEST):
926
927 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
928
929         Using Tools/Scripts/clean-webkit should not install requests
930         https://bugs.webkit.org/show_bug.cgi?id=196940
931
932         Reviewed by Lucas Forschler.
933
934         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
935         existing, depending on the path autoinstalled is run through.
936         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
937         needed.
938         (Port.configuration_for_upload):
939         (Port.commits_for_upload):
940
941 2019-04-15  Alex Christensen  <achristensen@webkit.org>
942
943         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
944         https://bugs.webkit.org/show_bug.cgi?id=196773
945
946         Reviewed by Jer Noble.
947
948         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
949         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
950         (TEST):
951
952 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
953
954         ews-build should clearly indicate flaky test failures
955         https://bugs.webkit.org/show_bug.cgi?id=196947
956
957         Reviewed by Lucas Forschler.
958
959         * BuildSlaveSupport/ews-build/steps.py:
960         (AnalyzeAPITestsResults.analyzeResults):
961
962 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
963
964         InjectedBundle parameters often need initialization function called before unarchiving
965         https://bugs.webkit.org/show_bug.cgi?id=189709
966         <rdar://problem/44573653>
967
968         Reviewed by Ryosuke Niwa.
969
970         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
971         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
972
973 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
974
975         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
976         https://bugs.webkit.org/show_bug.cgi?id=196681
977
978         Reviewed by Darin Adler.
979
980         Added tests.
981
982         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
983         (WTF_HashSet.RemoveIf):
984         (WTF_HashSet.RemoveIfShrinkToBestSize):
985
986 2019-04-15  John Wilander  <wilander@apple.com>
987
988         Send delayed Ad Click Attribution conversion requests to the click source
989         https://bugs.webkit.org/show_bug.cgi?id=196838
990         <rdar://problem/47650157>
991
992         Reviewed by Chris Dumez and Youenn Fablet.
993
994         This patch adds test infrastructure to override the default behavior in
995         WebKit::NetworkAdClickAttribution.
996
997         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
998         (TestWebKitAPI::TEST):
999         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1000         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1001         (WTR::TestRunner::dumpAdClickAttribution):
1002         (WTR::TestRunner::clearAdClickAttribution):
1003         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1004         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1005         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1006         * WebKitTestRunner/TestController.cpp:
1007         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
1008         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
1009         * WebKitTestRunner/TestController.h:
1010         * WebKitTestRunner/TestInvocation.cpp:
1011         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1012
1013 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1014
1015         [ews-app] status-bubble should display position in queue
1016         https://bugs.webkit.org/show_bug.cgi?id=196607
1017
1018         Reviewed by Lucas Forschler.
1019
1020         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1021         (StatusBubble._build_bubble):
1022         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1023
1024 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1025
1026         [ews-build] Do not run clean build by default on EWS builders
1027         https://bugs.webkit.org/show_bug.cgi?id=196897
1028
1029         Reviewed by Lucas Forschler.
1030
1031         * BuildSlaveSupport/ews-build/steps.py:
1032         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1033         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1034         untracked directories like WebKitBuild).
1035         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1036         untracked files/directories (like WebKitBuild).
1037
1038 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1039
1040         TestRunner::notifyDone() should be safely reentrant
1041         https://bugs.webkit.org/show_bug.cgi?id=196898
1042
1043         Reviewed by Darin Adler.
1044
1045         It is currently possible that TestRunner::notifyDone() will call itself, since
1046         notifyDone() will force a repaint, which can start executing JavaScript, which
1047         may call notifyDone() again. This can lead to test failures and flakiness.
1048         Fix this by setting the m_waitToDump flag before calling the dump() method.
1049
1050         * DumpRenderTree/mac/TestRunnerMac.mm:
1051         (TestRunner::notifyDone):
1052         (TestRunner::forceImmediateCompletion):
1053         * DumpRenderTree/win/TestRunnerWin.cpp:
1054         (TestRunner::notifyDone):
1055         (TestRunner::forceImmediateCompletion):
1056
1057 2019-04-15  Philippe Normand  <pnormand@igalia.com>
1058
1059         [GTK][WPE] Add enable-media websetting
1060         https://bugs.webkit.org/show_bug.cgi?id=196863
1061
1062         Reviewed by Michael Catanzaro.
1063
1064         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1065         (testWebKitSettings): Add test for the enable-media web-setting.
1066
1067 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1068
1069         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1070         https://bugs.webkit.org/show_bug.cgi?id=196905
1071         <rdar://problem/49886096>
1072
1073         Reviewed by Tim Horton.
1074
1075         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1076         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1077         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1078         delay timer, we end up with this sequence of events in the problematic (failure) case:
1079
1080         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1081             ...IPC from UI to web process...
1082         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1083             ...IPC from web to UI process...
1084         (c) [UI]    Invoke completion handler for script #1
1085         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1086             ...IPC from UI to web process...
1087         (e) [Web]   Evaluate script #2 in the web process
1088         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1089
1090         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1091         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1092         #2 is run in step (e).
1093
1094         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1095         the UI process by waiting on a script message posted by the web process, after attachment updates are
1096         dispatched.
1097
1098         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1099         (TestWebKitAPI::TEST):
1100
1101 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1102
1103         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1104         https://bugs.webkit.org/show_bug.cgi?id=196909
1105
1106         Reviewed by Wenson Hsieh.
1107
1108         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1109         (TestWebKitAPI::TEST):
1110
1111 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1112
1113         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1114         https://bugs.webkit.org/show_bug.cgi?id=196880
1115
1116         Reviewed by Yusuke Suzuki.
1117
1118         Add a new function for bytecode cache tests that does not forceDiskCache
1119         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1120         test added in this patch, since the code is invalid and therefore won't be
1121         cached. It should also be useful for tests that evaluate dynamically
1122         generated code.
1123
1124         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1125         * Scripts/run-jsc-stress-tests:
1126
1127 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1128
1129         Update AudioSession route sharing policy
1130         https://bugs.webkit.org/show_bug.cgi?id=196776
1131         <rdar://problem/46501611>
1132
1133         Reviewed by Jer Noble.
1134
1135         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1136         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1137         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1138         (TestWebKitAPI::TEST):
1139
1140 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1141
1142         [iOS] Software keyboard is shown too frequently on some websites
1143         https://bugs.webkit.org/show_bug.cgi?id=195856
1144         <rdar://problem/49191395>
1145
1146         Reviewed by Darin Adler.
1147
1148         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1149
1150         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1151         (WTR::UIScriptController::setHardwareKeyboardAttached):
1152         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1153         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1154         (WTR::UIScriptController::setHardwareKeyboardAttached):
1155         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1156         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1157
1158         Additionally link against GraphicsServices in WebKitTestRunner.
1159
1160         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1161         (WTR::TestController::platformResetStateToConsistentValues):
1162         (WTR::UIScriptController::setHardwareKeyboardAttached):
1163
1164 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1165
1166         [GTK][WPE] Fix pacman install-dependencies packages
1167         https://bugs.webkit.org/show_bug.cgi?id=196817
1168
1169         Reviewed by Žan Doberšek.
1170         
1171         python3-setuptools is called python-setuptools
1172         ruby-highline is only available on AUR
1173         libv4l-devel is incorporated in v4l-utils
1174
1175         * gtk/install-dependencies:
1176         * wpe/install-dependencies:
1177
1178 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1179
1180         [GTK] REGRESSION(r243860): Many tests failing
1181         https://bugs.webkit.org/show_bug.cgi?id=196791
1182
1183         Reviewed by Joanmarie Diggs.
1184
1185         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1186         multiple documents and check that accessibility hierarchy is updated after a navigation.
1187
1188         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1189         (loadChangedCallback):
1190         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1191         (AccessibilityTest::AccessibilityTest):
1192         (AccessibilityTest::~AccessibilityTest):
1193         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1194         (AccessibilityTest::findTestServerApplication):
1195         (AccessibilityTest::findDocumentWeb):
1196         (AccessibilityTest::findRootObject):
1197         (AccessibilityTest::waitUntilChildrenRemoved):
1198         (AccessibilityTest::ensureProxy):
1199         (testAtspiBasicHierarchy):
1200         (beforeAll):
1201         (afterAll):
1202
1203 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1204
1205         [ews-build] Handle bug titles with unicode characters
1206         https://bugs.webkit.org/show_bug.cgi?id=196802
1207
1208         Reviewed by Dewei Zhu.
1209
1210         * BuildSlaveSupport/ews-build/steps.py:
1211         (ValidatePatch._is_bug_closed):
1212
1213 2019-04-11  Michael Saboff  <msaboff@apple.com>
1214
1215         Improve the Inline Cache Stats code
1216         https://bugs.webkit.org/show_bug.cgi?id=196836
1217
1218         Reviewed by Saam Barati.
1219
1220         Added a new script to consolidate and arrange the output of --useICStats option.
1221
1222         This script merges the output from every group into one large table and sorts it from most common to
1223         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1224         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1225         Put together, this is useful to see what property accesses are not getting cached.
1226
1227         * Scripts/ic-stats.py: Added.
1228         (ICStats):
1229         (ICStats.__init__):
1230         (ICStats.parse):
1231         (ICStats.dumpStats):
1232         (usage):
1233
1234 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1235
1236         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1237         https://bugs.webkit.org/show_bug.cgi?id=196809
1238         <rdar://49800762>
1239
1240         Reviewed by Brady Eidson.
1241
1242         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1243         (TEST):
1244
1245 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1246
1247         requestAnimationFrame should execute before the next frame
1248         https://bugs.webkit.org/show_bug.cgi?id=177484
1249
1250         Reviewed by Simon Fraser.
1251
1252         Add trace points for the page RenderingUpdate.
1253
1254         * Tracing/SystemTracePoints.plist:
1255
1256 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1257
1258         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1259         https://bugs.webkit.org/show_bug.cgi?id=196760
1260
1261         Reviewed by Don Olmstead.
1262
1263         vswhere.exe has been bundled since Visual Studio 2017 version
1264         15.2. We shouldn't download vswhere.exe.
1265
1266         * Scripts/build-jsc: Do not call update-vswhere.py.
1267         * Scripts/build-webkit: Ditto.
1268         * Scripts/update-vswhere.py: Removed.
1269         * Scripts/webkitdirs.pm:
1270         (requireModulesForVSWhere): Deleted.
1271         (pickCurrentVisualStudioInstallation): Deleted.
1272         (visualStudioInstallDirVSWhere): Return the latest installed VS
1273         installation path by using the bundled vswhere.exe.
1274         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1275         (visualStudioInstallDirFallback): Removed.
1276
1277 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1278
1279         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1280         https://bugs.webkit.org/show_bug.cgi?id=196780
1281
1282         Reviewed by Alexey Proskuryakov.
1283
1284         * BuildSlaveSupport/ews-build/steps.py:
1285         * BuildSlaveSupport/ews-build/steps_unittest.py:
1286
1287 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1288
1289         Add SPI WKNavigationResponse._downloadAttribute
1290         https://bugs.webkit.org/show_bug.cgi?id=196755
1291         <rdar://49587365>
1292
1293         Reviewed by Brady Eidson.
1294
1295         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1296         (-[NavigationResponseTestDelegate navigationResponse]):
1297         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1298         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1299         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1300         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1301         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1302         (readRequest):
1303         (writeResponse):
1304         (TEST):
1305
1306 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1307
1308         Add modern API for overriding the page's specified viewport configuration
1309         https://bugs.webkit.org/show_bug.cgi?id=167734
1310         <rdar://problem/30331795>
1311
1312         Reviewed by Simon Fraser.
1313
1314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1315         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1316
1317 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1318
1319         Add support for incremental bytecode cache updates
1320         https://bugs.webkit.org/show_bug.cgi?id=195000
1321
1322         Reviewed by Filip Pizlo.
1323
1324         Exit when the initial run to generate bytecode fails.
1325
1326         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1327
1328 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1329
1330         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1331         https://bugs.webkit.org/show_bug.cgi?id=196744
1332         <rdar://49415309>
1333
1334         Reviewed by Chris Dumez.
1335
1336         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1337         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1338
1339 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1340
1341         Add a way to opt into modern compatibility mode in layout tests
1342         https://bugs.webkit.org/show_bug.cgi?id=196770
1343         <rdar://problem/49777550>
1344
1345         Reviewed by Antoine Quint.
1346
1347         Add a new test option to enable modern compatibility mode in layout tests.
1348
1349         * WebKitTestRunner/TestController.cpp:
1350         (WTR::updateTestOptionsFromTestHeader):
1351         * WebKitTestRunner/TestController.h:
1352         * WebKitTestRunner/TestOptions.h:
1353         (WTR::TestOptions::hasSameInitializationOptions const):
1354         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1355         (WTR::TestController::platformCreateWebView):
1356         (WTR::TestController::enableModernCompatibilityMode):
1357
1358 2019-04-10  Andy Estes  <aestes@apple.com>
1359
1360         Try to fix the 32-bit watchOS build.
1361
1362         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1363         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1364
1365 2019-04-10  Antoine Quint  <graouts@apple.com>
1366
1367         Enable Pointer Events on watchOS
1368         https://bugs.webkit.org/show_bug.cgi?id=196771
1369         <rdar://problem/49040909>
1370
1371         Reviewed by Dean Jackson.
1372
1373         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1374
1375 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1376
1377         Unreviewed. Fix WPE accessibility tests after r244059.
1378
1379         We are failing to load the injected bundle due to undefined symbol
1380         AccessibilityUIElement::replaceTextInRange().
1381
1382         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1383         (WTR::AccessibilityUIElement::replaceTextInRange):
1384
1385 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1386
1387         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1388         https://bugs.webkit.org/show_bug.cgi?id=196727
1389
1390         Reviewed by Fujii Hironori.
1391
1392         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1393         (WebKitBrowserWindow::create):
1394
1395 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1396
1397         [ews-build] Add unit tests for PrintConfiguration
1398         https://bugs.webkit.org/show_bug.cgi?id=196752
1399
1400         Reviewed by Dewei Zhu.
1401
1402         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1403
1404 2019-04-09  Keith Rollin  <krollin@apple.com>
1405
1406         Unreviewed build maintenance -- update .xcfilelists.
1407
1408         * DumpRenderTree/DerivedSources-input.xcfilelist:
1409         * DumpRenderTree/DerivedSources-output.xcfilelist:
1410
1411 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1412
1413         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1414         https://bugs.webkit.org/show_bug.cgi?id=196743
1415         <rdar://problem/43897551>
1416
1417         Reviewed by Tim Horton.
1418
1419         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1420         (TEST):
1421
1422 2019-04-09  Youenn Fablet  <youenn@apple.com>
1423
1424         Close service worker database on network process suspension
1425         https://bugs.webkit.org/show_bug.cgi?id=196623
1426         <rdar://problem/48930869>
1427
1428         Reviewed by Alex Christensen.
1429
1430         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1431
1432 2019-04-09  Daniel Bates  <dabates@apple.com>
1433
1434         [iPad] Should open popover when the spacebar is pressed
1435         https://bugs.webkit.org/show_bug.cgi?id=196360
1436         <rdar://problem/49389129>
1437
1438         Reviewed by Brent Fulgham.
1439
1440         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1441
1442         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1443         (WTR::UIScriptController::isShowingPopover const): Added.
1444         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1445         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1446         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1447         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1448         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1449         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1450         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1451         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1452         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1453         (WTR::UIScriptController::isShowingPopover const): Added.
1454         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1455         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1456         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1457         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1458         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1459         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1460         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1461         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1462         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1463         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1464         (WTR::UIScriptController::isShowingPopover const): Added.
1465         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1466         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1467
1468 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1469
1470         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1471         https://bugs.webkit.org/show_bug.cgi?id=196665
1472         <rdar://45115669>
1473
1474         Reviewed by Geoff Garen.
1475
1476         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1477         (goBack):
1478         (+[SimpleLookupContext sharedLookupContext]):
1479         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1480         (TEST):
1481         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1482         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1483
1484 2019-04-09  John Wilander  <wilander@apple.com>
1485
1486         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1487         https://bugs.webkit.org/show_bug.cgi?id=196558
1488         <rdar://problem/47650245>
1489
1490         Reviewed by Youenn Fablet.
1491
1492         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1493         (TestWebKitAPI::TEST):
1494             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1495
1496 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1497
1498         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1499         https://bugs.webkit.org/show_bug.cgi?id=196720
1500
1501         Reviewed by Konstantin Tokarev.
1502
1503         * TestWebKitAPI/PlatformMac.cmake:
1504
1505 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1506
1507         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1508         https://bugs.webkit.org/show_bug.cgi?id=196694
1509         <rdar://problem/48388734>
1510
1511         Rubber-stamped by Aakash Jain.
1512
1513         * Scripts/webkitpy/port/image_diff.py:
1514         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1515         * Scripts/webkitpy/port/server_process.py:
1516         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1517         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1518         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1519         * Scripts/webkitpy/port/server_process_mock.py:
1520         (MockServerProcess.has_available_stdout):
1521         * Scripts/webkitpy/port/server_process_unittest.py:
1522         (TestServerProcess.serial_test_basic):
1523
1524 2019-04-09  Jer Noble  <jer.noble@apple.com>
1525
1526         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1527         https://bugs.webkit.org/show_bug.cgi?id=196097
1528
1529         Reviewed by Eric Carlson.
1530
1531         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1532
1533         * DumpRenderTree/mac/DumpRenderTree.mm:
1534         (resetWebPreferencesToConsistentValues):
1535         * WebKitTestRunner/TestController.cpp:
1536         (WTR::TestController::resetPreferencesToConsistentValues):
1537
1538 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1539
1540         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1541         https://bugs.webkit.org/show_bug.cgi?id=196690
1542
1543         Reviewed by Michael Catanzaro.
1544
1545         * QueueStatusServer/config/queues.py:
1546         * Scripts/webkitpy/common/config/ews.json:
1547         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1548         (test_ews_name):
1549
1550 2019-04-09  Chris Dumez  <cdumez@apple.com>
1551
1552         Loads using loadHTMLString() cause flashing when process-swapping
1553         https://bugs.webkit.org/show_bug.cgi?id=196714
1554         <rdar://problem/49637354>
1555
1556         Reviewed by Antti Koivisto.
1557
1558         Add API test coverage.
1559
1560         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1561
1562 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1563
1564         Unreviewed. Fix ATK accessibility tests after r244059.
1565
1566         We are failing to load the injected bundle due to undefined symbol
1567         AccessibilityUIElement::replaceTextInRange().
1568
1569         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1570         (WTR::AccessibilityUIElement::replaceTextInRange):
1571
1572 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1573
1574         AX: Support API: accessibilityReplaceRange:withText
1575         https://bugs.webkit.org/show_bug.cgi?id=196636
1576
1577         Unreviewed build fix for Windows port.
1578
1579         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1580         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1581
1582 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1583
1584         [CMake][WinCairo] Separate copied headers into different directories
1585         https://bugs.webkit.org/show_bug.cgi?id=196655
1586
1587         Reviewed by Michael Catanzaro.
1588
1589         * DumpRenderTree/CMakeLists.txt:
1590         * MiniBrowser/win/CMakeLists.txt:
1591         * TestWebKitAPI/CMakeLists.txt:
1592         * TestWebKitAPI/PlatformWin.cmake:
1593
1594 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1595
1596         Log stack-trace for run-webkit-tests when interrupted
1597         https://bugs.webkit.org/show_bug.cgi?id=176393
1598         <rdar://problem/34262310>
1599
1600         Reviewed by Lucas Forschler.
1601
1602         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1603         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1604         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1605         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1606         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1607         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1608         (main): Set handlers to log stack trace on interruption.
1609
1610 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1611
1612         AX: Support API: accessibilityReplaceRange:withText
1613         https://bugs.webkit.org/show_bug.cgi?id=196636
1614
1615         Unreviewed build fix for Windows port.
1616
1617         * DumpRenderTree/AccessibilityUIElement.cpp:
1618         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1619
1620 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1621
1622         [ews-build] Scripts using Buildbot API have CORS error
1623         https://bugs.webkit.org/show_bug.cgi?id=196709
1624
1625         Reviewed by Alexey Proskuryakov.
1626
1627         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1628
1629 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1630
1631         AX: Support API: accessibilityReplaceRange:withText
1632         https://bugs.webkit.org/show_bug.cgi?id=196636
1633
1634         Reviewed by Daniel Bates.
1635
1636         * DumpRenderTree/AccessibilityUIElement.cpp:
1637         (replaceTextInRangeCallback):
1638         (AccessibilityUIElement::replaceTextInRange):
1639         (AccessibilityUIElement::getJSClass):
1640         * DumpRenderTree/AccessibilityUIElement.h:
1641         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1642         (AccessibilityUIElement::replaceTextInRange):
1643         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1644         (AccessibilityUIElement::replaceTextInRange):
1645         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1646         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1647         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1648         (WTR::AccessibilityUIElement::replaceTextInRange):
1649         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1650         (WTR::AccessibilityUIElement::replaceTextInRange):
1651
1652 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1653
1654         [iOS] Do not allow starting selection drags when selection views are not visible
1655         https://bugs.webkit.org/show_bug.cgi?id=196686
1656         <rdar://problem/49399192>
1657
1658         Reviewed by Tim Horton.
1659
1660         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1661         also add some new API tests to cover scenarios where the web view is not first responder.
1662
1663         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1664         (TestWebKitAPI::TEST):
1665         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1666
1667         Add a switch to optionally make the web view first responder when starting the simulated drag.
1668
1669         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1670         (-[DragAndDropSimulator initWithWebView:]):
1671         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1672
1673 2019-04-08  Justin Fan  <justin_fan@apple.com>
1674
1675         [Web GPU] Fix Web GPU experimental feature on iOS
1676         https://bugs.webkit.org/show_bug.cgi?id=196632
1677
1678         Reviewed by Myles C. Maxfield.
1679
1680         Properly make Web GPU available on iOS 11+.
1681
1682         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1683
1684 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1685
1686         [ews-build] Do not upload archive when Compile Fails
1687         https://bugs.webkit.org/show_bug.cgi?id=196674
1688
1689         Reviewed by Alexey Proskuryakov.
1690
1691         * BuildSlaveSupport/ews-build/factories.py:
1692         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1693         * BuildSlaveSupport/ews-build/steps.py:
1694         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1695         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1696         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1697
1698 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1699
1700         Enable DFG on MIPS
1701         https://bugs.webkit.org/show_bug.cgi?id=196689
1702
1703         Reviewed by Žan Doberšek.
1704
1705         Since the bytecode change, we enabled the baseline JIT on mips in
1706         r240432, but DFG is still missing. With this change, all tests are
1707         passing on a ci20 board.
1708
1709         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1710
1711 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1712
1713         [Flatpak] Second run update-webkitwpe-flatpak fails
1714         https://bugs.webkit.org/show_bug.cgi?id=192702
1715
1716         Reviewed by Carlos Garcia Campos.
1717
1718         * flatpak/flatpakutils.py:
1719         (FlatpakObject.flatpak): Fix typo.
1720         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1721         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1722
1723 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1724
1725         [GTK][WPE] outlook.live.com displays old-fashioned UI
1726         https://bugs.webkit.org/show_bug.cgi?id=196642
1727
1728         Reviewed by Carlos Garcia Campos.
1729
1730         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1731         (TestWebKitAPI::TEST): New Mac platform quirk test.
1732
1733 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1734
1735         Unreviewed, rolling out r243956.
1736         https://bugs.webkit.org/show_bug.cgi?id=196688
1737
1738         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1739         by aakashjain on #webkit).
1740
1741         Reverted changeset:
1742
1743         "Clicking "Go Back" from a safe browsing warning from an
1744         iframe should navigate the WKWebView back to the previous
1745         page"
1746         https://bugs.webkit.org/show_bug.cgi?id=196665
1747         https://trac.webkit.org/changeset/243956
1748
1749 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1750
1751         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1752         https://bugs.webkit.org/show_bug.cgi?id=196669
1753
1754         Reviewed by Geoffrey Garen.
1755
1756         Added three new unit tests for WeakHashSet.
1757
1758         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1759         (WTF_WeakPtr.WeakHashSetConstObjects):
1760         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1761         (WTF_WeakPtr.WeakHashSetComputeSize):
1762
1763 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1764
1765         Hide next and previous form control buttons when WKWebView is editable
1766         https://bugs.webkit.org/show_bug.cgi?id=196672
1767         <rdar://problem/35625321>
1768
1769         Reviewed by Tim Horton.
1770
1771         Add a new API test.
1772
1773         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1774         (-[TestWKWebView lastTrailingBarButtonGroup]):
1775         (TestWebKitAPI::TEST):
1776         * TestWebKitAPI/ios/UIKitSPI.h:
1777
1778 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1779
1780         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1781         https://bugs.webkit.org/show_bug.cgi?id=196077
1782         <rdar://problem/49108202>
1783
1784         Reviewed by Chris Dumez.
1785
1786         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1787         on new web view.
1788
1789         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1790
1791 2019-04-05  Saam Barati  <sbarati@apple.com>
1792
1793         Make compare-results understand MotionMark
1794         https://bugs.webkit.org/show_bug.cgi?id=196666
1795
1796         Reviewed by Yusuke Suzuki.
1797
1798         * Scripts/compare-results:
1799         (PLT5Results):
1800         (detectMotionMark):
1801         (detectMotionMark1_1):
1802         (motionMarkResults):
1803         (motionMark1_1Results):
1804         (detectBenchmark):
1805         (biggerIsBetter):
1806         (main):
1807
1808 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1809
1810         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1811         https://bugs.webkit.org/show_bug.cgi?id=196665
1812         <rdar://45115669>
1813
1814         Reviewed by Geoff Garen.
1815
1816         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1817         (goBack):
1818         (+[SimpleLookupContext sharedLookupContext]):
1819         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1820         (TEST):
1821         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1822         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1823
1824 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1825
1826         [ews-build] Add configuration and architecture for windows builders
1827         https://bugs.webkit.org/show_bug.cgi?id=196660
1828
1829         Reviewed by Lucas Forschler.
1830
1831         * BuildSlaveSupport/ews-build/config.json:
1832
1833 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1834
1835         webkitpy: Don't run subsequent rounds if interrupted
1836         https://bugs.webkit.org/show_bug.cgi?id=196646
1837
1838         Reviewed by Aakash Jain.
1839
1840         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1841         (Manager.run): Bail out if interrupted.
1842
1843 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1844
1845         Test sessionStorage in PSON private browsing mode
1846         https://bugs.webkit.org/show_bug.cgi?id=196561
1847
1848         Reviewed by Alex Christensen.
1849
1850         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1851
1852 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1853
1854         Unreviewed, rolling out r243833.
1855         https://bugs.webkit.org/show_bug.cgi?id=196645
1856
1857         This change breaks build of WPE and GTK ports (Requested by
1858         annulen on #webkit).
1859
1860         Reverted changeset:
1861
1862         "[CMake][WTF] Mirror XCode header directories"
1863         https://bugs.webkit.org/show_bug.cgi?id=191662
1864         https://trac.webkit.org/changeset/243833
1865
1866 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1867
1868         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1869         https://bugs.webkit.org/show_bug.cgi?id=196635
1870
1871         Reviewed by Antti Koivisto.
1872         
1873         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1874         for a test to enable async frame scrolling via:
1875             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1876         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1877         
1878         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1879
1880         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1881         (WTR::InjectedBundle::beginTesting):
1882         * WebKitTestRunner/TestController.cpp:
1883         (WTR::TestController::resetPreferencesToConsistentValues):
1884
1885 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1886
1887         Use a correct LC_RPATH when building with ASan
1888         https://bugs.webkit.org/show_bug.cgi?id=196576
1889
1890         Reviewed by David Kilzer.
1891
1892         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1893         so that ../Frameworks is checked. This is simpler and more reliable than updating
1894         each SPC service xcconfig.
1895
1896 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1897
1898         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1899         https://bugs.webkit.org/show_bug.cgi?id=196629
1900
1901         Reviewed by Lucas Forschler.
1902
1903         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1904
1905 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1906
1907         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1908         https://bugs.webkit.org/show_bug.cgi?id=196618
1909
1910         Reviewed by Lucas Forschler.
1911
1912         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1913         (StatusBubble): Added QUEUE_TRIGGERS.
1914         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1915         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1916         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1917         its parent(builder).
1918
1919 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1920
1921         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1922         https://bugs.webkit.org/show_bug.cgi?id=196625
1923
1924         Reviewed by Lucas Forschler.
1925
1926         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1927         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1928
1929 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1930
1931         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1932         https://bugs.webkit.org/show_bug.cgi?id=196630
1933
1934         Reviewed by Wenson Hsieh.
1935
1936         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1937
1938 2019-04-04  Youenn Fablet  <youenn@apple.com>
1939
1940         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1941         https://bugs.webkit.org/show_bug.cgi?id=196543
1942
1943         Reviewed by Alex Christensen.
1944
1945         * WebKitTestRunner/TestController.cpp:
1946         (WTR::TestController::generatePageConfiguration):
1947
1948 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1949
1950         [ews-app] Status bubble should not display skipped buildbot steps
1951         https://bugs.webkit.org/show_bug.cgi?id=196584
1952
1953         Reviewed by Lucas Forschler.
1954
1955         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1956
1957 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1958
1959         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1960         https://bugs.webkit.org/show_bug.cgi?id=196620
1961
1962         Reviewed by Lucas Forschler.
1963
1964         * BuildSlaveSupport/ews-app/ews/config.py:
1965
1966 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1967
1968         [Win] DumpRenderTreeWatchDog.py is not checked into source
1969         https://bugs.webkit.org/show_bug.cgi?id=196567
1970         <rdar://problem/49525901>
1971
1972         Reviewed by Lucas Forschler.
1973
1974         This script is used on Win EWS bots to terminate hanging DRT processes.
1975
1976         * EWSTools/dumprendertreewatchdog.py: Added.
1977
1978 2019-04-04  Chris Dumez  <cdumez@apple.com>
1979
1980         Unreviewed, roll out r243858 which made tests time out.
1981
1982         Disable new API tests on Windows instead.
1983
1984         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1985         (TestWebKitAPI::TEST):
1986
1987 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1988
1989         [ATK] Cleanup WebPageAccessibilityObjectAtk
1990         https://bugs.webkit.org/show_bug.cgi?id=196537
1991
1992         Reviewed by Michael Catanzaro.
1993
1994         Also consider files under atk directories as exceptions for GObject conventions.
1995
1996         * Scripts/webkitpy/style/checkers/cpp.py:
1997         (check_identifier_name_in_declaration):
1998
1999 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2000
2001         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2002         https://bugs.webkit.org/show_bug.cgi?id=196588
2003         <rdar://problem/49365787>
2004
2005         Unreviewed build fix for Windows port.
2006
2007         error C3861: 'kill': identifier not found
2008
2009         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2010         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2011
2012 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2013
2014         [ews-build] Cancel build and similar operations should have authentication
2015         https://bugs.webkit.org/show_bug.cgi?id=196520
2016
2017         Reviewed by Dewei Zhu.
2018
2019         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2020         environment variables.
2021
2022 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2023
2024         [ews-build] Do not trigger queues which are not in production yet
2025         https://bugs.webkit.org/show_bug.cgi?id=196581
2026
2027         Reviewed by Dewei Zhu.
2028
2029         * BuildSlaveSupport/ews-build/config.json:
2030
2031 2019-04-03  Chris Dumez  <cdumez@apple.com>
2032
2033         Unreviewed, fix typo in the name of API test added in r243848.
2034
2035         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2036         (TestWebKitAPI::TEST):
2037
2038 2019-04-03  Chris Dumez  <cdumez@apple.com>
2039
2040         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2041         https://bugs.webkit.org/show_bug.cgi?id=196588
2042         <rdar://problem/49365787>
2043
2044         Reviewed by Ryosuke Niwa.
2045
2046         Add API test coverage.
2047
2048         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2049         (TestWebKitAPI::nullJavaScriptCallback):
2050         (TestWebKitAPI::didCrashCheckFrames):
2051         (TestWebKitAPI::TEST):
2052
2053 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2054
2055         run-webkit-tests: Upload test results (new results database)
2056         https://bugs.webkit.org/show_bug.cgi?id=196577
2057         <rdar://problem/34841155>
2058
2059         Reviewed by Lucas Forschler.
2060
2061         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2062         (Manager.run): Upload results after each device shard, since the configuration will be
2063         different for each device.
2064         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2065         uploaded to a results database.
2066         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2067         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2068
2069 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2070
2071         -apple-trailing-word is needed for browser detection
2072         https://bugs.webkit.org/show_bug.cgi?id=196575
2073
2074         Unreviewed.
2075
2076         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2077
2078 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2079
2080         [CMake][WTF] Mirror XCode header directories
2081         https://bugs.webkit.org/show_bug.cgi?id=191662
2082
2083         Reviewed by Konstantin Tokarev.
2084
2085         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2086         builds.
2087
2088         * CMakeLists.txt:
2089         * DumpRenderTree/CMakeLists.txt:
2090         * DumpRenderTree/PlatformWin.cmake:
2091         * MiniBrowser/win/CMakeLists.txt:
2092         * TestWebKitAPI/CMakeLists.txt:
2093         * TestWebKitAPI/PlatformWin.cmake:
2094         * WebKitTestRunner/PlatformGTK.cmake:
2095         * WebKitTestRunner/PlatformWin.cmake:
2096
2097 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2098
2099         [ews-app] Status bubble should not display certain infrastructure status messages
2100         https://bugs.webkit.org/show_bug.cgi?id=196550
2101
2102         Reviewed by Lucas Forschler.
2103
2104         Do not display the steps which are un-needed for end-user. This information is still avaiable
2105         if the user click on the bubble and look at the Buildbot build.
2106         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2107         (StatusBubble._steps_messages):
2108         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2109
2110 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2111
2112         [ews-build] Use https for sending data to ews-app
2113         https://bugs.webkit.org/show_bug.cgi?id=196492
2114
2115         Reviewed by Lucas Forschler.
2116
2117         * BuildSlaveSupport/ews-build/events.py:
2118
2119 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2120
2121         Remove support for -apple-trailing-word
2122         https://bugs.webkit.org/show_bug.cgi?id=196525
2123
2124         Reviewed by Zalan Bujtas.
2125
2126         This CSS property is nonstandard and not used.
2127
2128         * Scripts/webkitperl/FeatureList.pm:
2129         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2130
2131 2019-04-03  Youenn Fablet  <youenn@apple.com>
2132
2133         Add a test for DOMCache on multiple browsing in case of private browsing
2134         https://bugs.webkit.org/show_bug.cgi?id=196524
2135
2136         Reviewed by Alex Christensen.
2137
2138         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2139         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2140
2141 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2142
2143         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2144         https://bugs.webkit.org/show_bug.cgi?id=196540
2145
2146         Reviewed by Aakash Jain.
2147
2148         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2149
2150 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2151
2152         Add plumbing for a compatibility mode preference in WebKit
2153         https://bugs.webkit.org/show_bug.cgi?id=196005
2154
2155         Reviewed by Tim Horton.
2156
2157         Add new API tests.
2158
2159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2160         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2161
2162 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2163
2164         [WPE][GTK] Update libsrtp dependency package for Debian
2165         https://bugs.webkit.org/show_bug.cgi?id=196528
2166
2167         Reviewed by Frédéric Wang.
2168
2169         * gtk/install-dependencies:
2170         * wpe/install-dependencies:
2171
2172 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2173
2174         [WK2] Add support for Window's beforeprint / afterprint events
2175         https://bugs.webkit.org/show_bug.cgi?id=196478
2176         <rdar://problem/49535124>
2177
2178         Unreviewed build fix for MSVC.
2179
2180         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2181
2182         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2183
2184         * WebKitTestRunner/TestController.cpp:
2185         (WTR::printFrame): Use int and float literals.
2186
2187 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2188
2189         [ews-build] Reassign bots to queues
2190
2191         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2192
2193 2019-04-02  Chris Dumez  <cdumez@apple.com>
2194
2195         [WK2] Add support for Window's beforeprint / afterprint events
2196         https://bugs.webkit.org/show_bug.cgi?id=196478
2197
2198         Reviewed by Alex Christensen.
2199
2200         Add minimal implementation for printFrame in WebKitTestRunner.
2201
2202         * WebKitTestRunner/TestController.cpp:
2203         (WTR::printFrame):
2204         (WTR::TestController::createOtherPage):
2205         (WTR::TestController::createWebViewWithOptions):
2206
2207 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2208
2209         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2210         https://bugs.webkit.org/show_bug.cgi?id=196491
2211
2212         Reviewed by Lucas Forschler.
2213
2214         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2215
2216 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2217
2218         [ews-build] Configure buildbot try credentials in environment variables
2219         https://bugs.webkit.org/show_bug.cgi?id=196501
2220
2221         Reviewed by Lucas Forschler.
2222
2223         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2224         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2225         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2226
2227 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2228
2229         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2230         https://bugs.webkit.org/show_bug.cgi?id=196496
2231         <rdar://problem/49521634>
2232
2233         Reviewed by Chris Dumez.
2234
2235         Add new API tests (see WebKit ChangeLog for more detail).
2236
2237         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2238         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2239         (TEST):
2240
2241 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2242
2243         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2244         <https://webkit.org/b/196499>
2245
2246         Reviewed by Alexey Proskuryakov.
2247
2248         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2249         ENABLE_ADDRESS_SANITIZER.
2250
2251 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2252
2253         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2254         https://bugs.webkit.org/show_bug.cgi?id=182757
2255
2256         Reviewed by Don Olmstead.
2257
2258         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2259         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2260
2261 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2262
2263         run-api-tests: Upload test results
2264         https://bugs.webkit.org/show_bug.cgi?id=196323
2265         <rdar://problem/49356714>
2266
2267         Reviewed by Lucas Forschler.
2268
2269         * Scripts/webkitpy/api_tests/manager.py:
2270         (Manager):
2271         (Manager.run): Upload results to a results database.
2272         * Scripts/webkitpy/api_tests/run_api_tests.py:
2273         (parse_args): Add upload arguments.
2274         * Scripts/webkitpy/port/base.py:
2275         (Port):
2276         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2277         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2278         with commits from any other associated repositories.
2279         * Scripts/webkitpy/port/device.py:
2280         (Device):
2281         (Device.build_version): Access build_versoin of underlying platform device.
2282         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2283         (IOSSimulatorTest):
2284         (IOSSimulatorTest.test_configuration_for_upload):
2285         * Scripts/webkitpy/port/device_port.py:
2286         (DevicePort):
2287         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2288         the same as the machine uploading results.
2289         * Scripts/webkitpy/port/mac.py:
2290         (MacPort):
2291         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2292         * Scripts/webkitpy/port/mac_unittest.py:
2293         (MacTest):
2294         (MacTest.test_configuration_for_upload):
2295         * Scripts/webkitpy/xcode/simulated_device.py:
2296         (SimulatedDeviceManager._create_device_with_runtime):
2297         (SimulatedDevice.__init__): Create simulated device with a build_version.
2298         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2299         (test_existing_simulator):
2300
2301 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2302
2303         Remove extra newline characters (Follow-up fix to r243707)
2304
2305         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2306
2307 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2308
2309         [ews-app] Use API_KEY to accept results data
2310         https://bugs.webkit.org/show_bug.cgi?id=196461
2311
2312         Reviewed by Dewei Zhu.
2313
2314         * BuildSlaveSupport/ews-app/ews/views/results.py:
2315         (Results.post): Validate EWS_API_KEY before accepting any data.
2316         * BuildSlaveSupport/ews-build/events.py:
2317         (Events.sendData): Send EWS_API_KEY if available along with event data.
2318
2319 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2320
2321         Unable to copy and paste a PDF from Notes into Mail compose body
2322         https://bugs.webkit.org/show_bug.cgi?id=196442
2323         <rdar://problem/48573098>
2324
2325         Reviewed by Tim Horton.
2326
2327         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2328         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2329         to be specified on the item providers.
2330
2331         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2332         (TestWebKitAPI::mapItemForTesting):
2333         (TestWebKitAPI::contactItemForTesting):
2334
2335 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2336
2337         Make UIWKDocumentContext rects per-character instead of per-word
2338         https://bugs.webkit.org/show_bug.cgi?id=196459
2339
2340         Reviewed by Wenson Hsieh.
2341
2342         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2343         (TEST):
2344         Adjust test results due to switching to per-character rects.
2345
2346 2019-04-01  Chris Dumez  <cdumez@apple.com>
2347
2348         UIProcess crash when a prewarmed process is terminated
2349         https://bugs.webkit.org/show_bug.cgi?id=196451
2350         <rdar://problem/49245471>
2351
2352         Reviewed by Geoffrey Garen.
2353
2354         Add API test coverage.
2355
2356         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2357         (TEST):
2358
2359 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2360
2361         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2362         https://bugs.webkit.org/show_bug.cgi?id=196449
2363
2364         Reviewed by Lucas Forschler.
2365
2366         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2367         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2368         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2369         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2370
2371 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2372
2373         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2374         https://bugs.webkit.org/show_bug.cgi?id=196444
2375
2376         Reviewed by Lucas Forschler.
2377
2378         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2379
2380 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2381
2382         Add SPI to canonicalize NSURLs with WTF::URL
2383         https://bugs.webkit.org/show_bug.cgi?id=196415
2384         <rdar://problem/44980271>
2385
2386         Reviewed by Darin Adler.
2387
2388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2389         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2390         (TestWebKitAPI::TEST):
2391
2392 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2393
2394         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2395         https://bugs.webkit.org/show_bug.cgi?id=196441
2396
2397         Reviewed by Carlos Garcia Campos.
2398
2399         Don't cache the wpe_view_backend object that might not exist yet at the
2400         time of EventSenderProxy constructor invocation, but instead retrieve
2401         that object whenever it's required for event dispatching. This should
2402         avoid crashes in this constructor now that it's invoked before any
2403         PlatformWindow has been set up (as changed in r243496).
2404
2405         * WebKitTestRunner/EventSenderProxy.h:
2406         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2407         (WTR::viewBackend):
2408         (WTR::EventSenderProxy::EventSenderProxy):
2409         (WTR::EventSenderProxy::mouseDown):
2410         (WTR::EventSenderProxy::mouseUp):
2411         (WTR::EventSenderProxy::mouseMoveTo):
2412         (WTR::EventSenderProxy::mouseScrollBy):
2413         (WTR::EventSenderProxy::keyDown):
2414         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2415
2416 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2417
2418         [Win][WebKit] MiniBrowser should support high DPI display
2419         https://bugs.webkit.org/show_bug.cgi?id=196391
2420
2421         Reviewed by Alex Christensen.
2422
2423         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2424         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2425         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2426         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2427
2428 2019-03-31  Sam Weinig  <weinig@apple.com>
2429
2430         Remove more i386 specific configurations
2431         https://bugs.webkit.org/show_bug.cgi?id=196430
2432
2433         Reviewed by Alexey Proskuryakov.
2434
2435         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2436         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2437
2438 2019-03-31  Andy Estes  <aestes@apple.com>
2439
2440         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2441         https://bugs.webkit.org/show_bug.cgi?id=196433
2442         <rdar://problem/49293305>
2443
2444         Reviewed by Tim Horton.
2445
2446         Enhanced API test coverage to include all navigation response policy decisions in both
2447         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2448
2449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2450         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2451         (TestWebKitAPI::TEST):
2452         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2453         (readFile):
2454         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2455         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2456         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2457         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2458         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2459         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2460         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2461         (-[QuickLookDelegate _downloadDidStart:]):
2462         (-[QuickLookDelegate _download:didReceiveResponse:]):
2463         (-[QuickLookDelegate _download:didReceiveData:]):
2464         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2465         (-[QuickLookDelegate _downloadDidFinish:]):
2466         (-[QuickLookDelegate _download:didFailWithError:]):
2467         (-[QuickLookDelegate _downloadDidCancel:]):
2468         (-[QuickLookDelegate verifyDownload]):
2469         (runTest):
2470         (runTestDecideBeforeLoading):
2471         (runTestDecideAfterLoading):
2472         (TEST):
2473         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2474         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2475         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2476         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2477         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2478         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2479         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2480         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2481         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2482         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2483         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2484         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2485         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2486         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2487
2488 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2489
2490         [CMake] add testdfg as target with build-jsc
2491         https://bugs.webkit.org/show_bug.cgi?id=196393
2492
2493         Reviewed by Saam Barati.
2494
2495         Added testdfg as one of the targets to build when
2496         using CMake.
2497
2498         * Scripts/build-jsc:
2499
2500 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2501
2502         Delete WebMetal implementation in favor of WebGPU
2503         https://bugs.webkit.org/show_bug.cgi?id=195418
2504
2505         Reviewed by Dean Jackson.
2506
2507         * DumpRenderTree/mac/DumpRenderTree.mm:
2508         (enableExperimentalFeatures):
2509         (resetWebPreferencesToConsistentValues):
2510         * Scripts/webkitperl/FeatureList.pm:
2511         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2513         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2514         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2515         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2516         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2517         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2518         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2519         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2520         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2521         (WTR::InjectedBundle::beginTesting):
2522         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2523         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2524         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2525
2526 2019-03-29  Chris Dumez  <cdumez@apple.com>
2527
2528         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2529         https://bugs.webkit.org/show_bug.cgi?id=196405
2530         <rdar://problem/49428130>
2531
2532         Reviewed by Wenson Hsieh.
2533
2534         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2535         the popover presentation methods to be no-ops. Use this in the new test added in
2536         r243523 so that we do not swizzle those methods for all tests. This is needed because
2537         those WatchOS tests rely on the popover getting presented and interactive.
2538
2539         * WebKitTestRunner/TestController.cpp:
2540         (WTR::updateTestOptionsFromTestHeader):
2541         * WebKitTestRunner/TestController.h:
2542         * WebKitTestRunner/TestOptions.h:
2543         (WTR::TestOptions::hasSameInitializationOptions const):
2544         * WebKitTestRunner/ios/TestControllerIOS.mm:
2545         (WTR::TestController::platformInitialize):
2546         (WTR::TestController::platformResetStateToConsistentValues):
2547
2548 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2549
2550         [Curl] Add Server Trust Evaluation Support.
2551         https://bugs.webkit.org/show_bug.cgi?id=191646
2552
2553         Reviewed by Fujii Hironori.
2554
2555         Implemented MiniBrowser UI for asking if user trusts the server.
2556
2557         * MiniBrowser/win/Common.cpp:
2558         (askServerTrustEvaluation):
2559         (replaceString):
2560         * MiniBrowser/win/Common.h:
2561         * MiniBrowser/win/MiniBrowserLib.rc:
2562         * MiniBrowser/win/MiniBrowserLibResource.h:
2563         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2564         (createPEMString):
2565         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2566         (WebKitBrowserWindow::canTrustServerCertificate):
2567         * MiniBrowser/win/WebKitBrowserWindow.h:
2568
2569 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2570
2571         Implement ResizeObserver.
2572         https://bugs.webkit.org/show_bug.cgi?id=157743
2573
2574         Reviewed by Simon Fraser.
2575
2576         Support resizeObserverEnabled webPreferences.
2577
2578         * DumpRenderTree/TestOptions.cpp:
2579         (TestOptions::TestOptions):
2580         * DumpRenderTree/TestOptions.h:
2581         * DumpRenderTree/mac/DumpRenderTree.mm:
2582         (setWebPreferencesForTestOptions):
2583         * DumpRenderTree/win/DumpRenderTree.cpp:
2584         (enableExperimentalFeatures):
2585         * Scripts/webkitperl/FeatureList.pm:
2586         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2587
2588 2019-03-28  John Wilander  <wilander@apple.com>
2589
2590         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2591         https://bugs.webkit.org/show_bug.cgi?id=196281
2592         <rdar://problem/48938748>
2593
2594         Reviewed by Alex Christensen.
2595
2596         This patch adds the function isStatisticsHasLocalStorage() to the
2597         TestRunner. With it, the page can query the WebsiteDataStore in the
2598         UI process to make sure that it sees LocalStorage.
2599
2600         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2601         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2602         (WTR::TestRunner::isStatisticsHasLocalStorage):
2603         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2604         * WebKitTestRunner/TestController.cpp:
2605         (WTR::TestController::isStatisticsHasLocalStorage):
2606         * WebKitTestRunner/TestController.h:
2607         * WebKitTestRunner/TestInvocation.cpp:
2608         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2609
2610 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2611
2612         API::Data::createWithoutCopying should do a null check before calling CFRelease
2613         https://bugs.webkit.org/show_bug.cgi?id=196276
2614         <rdar://problem/48059859>
2615
2616         Reviewed by Alex Christensen.
2617
2618         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2619
2620         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2621         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2622         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2623         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2624         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2625         (TestWebKitAPI::TEST):
2626
2627 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2628
2629         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2630         https://bugs.webkit.org/show_bug.cgi?id=186276
2631
2632         Reviewed by Carlos Garcia Campos.
2633
2634         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2635         (webViewLoadChanged):
2636         (testWebResourceGetDataError):
2637         (testWebResourceGetDataEmpty):
2638         (beforeAll):
2639         (webViewloadChanged): Deleted.
2640
2641 2019-03-27  Andy Estes  <aestes@apple.com>
2642
2643         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2644         https://bugs.webkit.org/show_bug.cgi?id=196317
2645
2646         Reviewed by Dan Bernstein.
2647
2648         package-root copies built products into a staging directory using ditto(1), which does not
2649         follow symbolic links as it traverses a directory. Now that the files in
2650         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2651         itself, these become broken links when ditto'd into the staging directory.
2652
2653         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2654
2655         * Scripts/package-root:
2656
2657 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2658
2659         [ews-app] Update display text of Submit for ews analysis
2660         https://bugs.webkit.org/show_bug.cgi?id=196309
2661
2662         Reviewed by Dewei Zhu.
2663
2664         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2665
2666 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2667
2668         run-webkit-tests should check for leaks in WebKit processes
2669         <https://webkit.org/b/193772>
2670         <rdar://problem/46526680>
2671
2672         Reviewed by Ryosuke Niwa.
2673
2674         This works by doing the following:
2675         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2676           The list of child processes are returned one per line:
2677           process.name: pid
2678         - Run the "#LIST CHILD PROCESSES" command just before the
2679           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2680           processes on the ServerProcess object.
2681         - When the `--leaks` switch is handled, run check_for_leaks() on
2682           each child process after the main test harness.
2683
2684         * DumpRenderTree/mac/DumpRenderTree.mm:
2685         (handleControlCommand):
2686         - Use strncmp() instead of strcmp().
2687         - Add support for handling "#LIST CHILD PROCESSES" command.
2688
2689         * Scripts/webkitpy/port/base.py:
2690         (Port.check_for_leaks):
2691         * Scripts/webkitpy/port/darwin.py:
2692         (DarwinPort.check_for_leaks):
2693         - Rename redundant 'process_pid' argument to 'process_id'.
2694
2695         * Scripts/webkitpy/port/driver.py:
2696         (Driver.do_post_tests_work):
2697         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2698           longer the only command this sends to WebKitTestRunner.
2699         - If the `--leaks` switch is present, send the
2700           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2701           result using Port.set_webkit_processes().
2702         (Driver._parse_child_processes_output):
2703         - Add helper method to parse list of child process names and
2704           process IDs returned from WebKitTestRunner.
2705
2706         * Scripts/webkitpy/port/ios_device.py:
2707         (IOSDevicePort.check_for_leaks):
2708         - Rename redundant 'process_pid' argument to 'process_id'.
2709
2710         * Scripts/webkitpy/port/leakdetector.py:
2711         (LeakDetector._parse_leaks_output):
2712         - Return early if there is no leaks_output.
2713         (LeakDetector.check_for_leaks):
2714         - Rename redundant 'process_pid' argument to 'process_id'.
2715
2716         * Scripts/webkitpy/port/server_process.py:
2717         (ServerProcess.__init__):
2718         (ServerProcess.child_processes):
2719         (ServerProcess.set_child_processes):
2720         - Add instance variable to Port to store list of child process
2721           names and process IDs returned from WebKitTestRunner.
2722         (ServerProcess._start):
2723         - Clear self._child_processes.
2724         (ServerProcess.stop):
2725         - If self._child_processes is set, call
2726           self._port.check_for_leaks() for each child process.
2727
2728         * Scripts/webkitpy/port/server_process_unittest.py:
2729         (TrivialMockPort.check_for_leaks):
2730         - Rename redundant 'process_pid' argument to 'process_id'.
2731
2732         * Scripts/webkitpy/port/simulator_process.py:
2733         (SimulatorProcess.stop):
2734         - If self._child_processes is set, call
2735           self._port.check_for_leaks() for each child process.
2736
2737         * Scripts/webkitpy/port/watch_device.py:
2738         (WatchDevicePort.check_for_leaks):
2739         - Rename redundant 'process_pid' argument to 'process_id'.
2740
2741         * WebKitTestRunner/TestController.cpp:
2742         (WTR::TestController::dumpResponse):
2743         - Extract method from findAndDumpWorldLeaks() so that it may be
2744           reused by findAndDumpWebKitProcessIdentifiers().
2745         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2746         - Add method to output process name and process ID of both the
2747           WebContent and Networking processes.
2748         (WTR::TestController::findAndDumpWorldLeaks):
2749         - Fix missing newline in output when there were no abandoned
2750           documents.
2751         - Call dumpResponse() for extracted code.
2752         (WTR::TestController::handleControlCommand):
2753         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2754         - Use strncmp() instead of strcmp().
2755         - Call findAndDumpWebKitProcessIdentifiers() when
2756           "#LIST CHILD PROCESSES" command is sent.
2757         * WebKitTestRunner/TestController.h:
2758         (WTR::TestController::dumpResponse):
2759         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2760         - Declare methods.
2761
2762 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2763
2764         Unreviewed. Add GLib API test cases after r243434.
2765
2766         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2767         (testWebViewActiveURI):
2768         (serverCallback):
2769         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2770         (sendRequestCallback):
2771
2772 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2773
2774         Geolocation request not complete when watch request was started in a different web process
2775         https://bugs.webkit.org/show_bug.cgi?id=195996
2776
2777         Reviewed by Alex Christensen.
2778
2779         Add a test case.
2780
2781         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2782         (TestWebKitAPI::runJavaScriptAlert):
2783         (TestWebKitAPI::TEST):
2784
2785 2019-03-26  Keith Rollin  <krollin@apple.com>
2786
2787         Update the way generate-xcfilelists returns strings from functions
2788         https://bugs.webkit.org/show_bug.cgi?id=195975
2789         <rdar://problem/49040807>
2790
2791         Reviewed by Dean Jackson.
2792
2793         There are places where generate-xcfilelists executes assignments with
2794         statements like:
2795
2796             FOO=$(some_function)
2797
2798         where "some_function" return a string by echoing it. E.g.
2799
2800             some_function()
2801             {
2802                 echo "Hello, World"
2803             }
2804
2805         This is a common idiom, but it has a problem if "some_function" needs
2806         to call "exit" in an attempt to halt the entire script right then and
2807         there. Since "some_function" is called inside of $(), it's being
2808         executed in a sub-shell. Calling exit in that sub-shell simply exits
2809         that shell; it doesn't not exit the outer shell in which the main part
2810         of the script is still running. As such, the main script keeps
2811         executing when the intent was for the script to halt.
2812
2813         The solution to this is to use a different idiom for returning
2814         strings. The one we now is to pass in the name of the variable to
2815         receive the string result:
2816
2817             some_function()
2818             {
2819                 variable_name=$1
2820                 eval $variable_name ="Hello, World"
2821             }
2822
2823         The call site now looks like
2824
2825             some_function FOO
2826
2827         Because there's no invocation of a sub-shell, some_function can now
2828         call "exit" if it wants to, and the entire script will exit at that
2829         point.
2830
2831         * Scripts/generate-xcfilelists:
2832
2833 2019-03-26  Chris Dumez  <cdumez@apple.com>
2834
2835         Add basic layout test coverage for File Picker on iOS
2836         https://bugs.webkit.org/show_bug.cgi?id=196265
2837
2838         Reviewed by Wenson Hsieh.
2839
2840         Add layout test infrastructure to test the file picker on iOS.
2841
2842         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2843         (WTR::UIScriptController::dismissFilePicker):
2844         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2845         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2846         (WTR::UIScriptController::dismissFilePicker):
2847         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2848         * WebKitTestRunner/TestController.cpp:
2849         (WTR::TestController::createWebViewWithOptions):
2850         (WTR::updateTestOptionsFromTestHeader):
2851         * WebKitTestRunner/TestOptions.h:
2852         (WTR::TestOptions::hasSameInitializationOptions const):
2853         * WebKitTestRunner/ios/TestControllerIOS.mm:
2854         (overridePresentViewController):
2855         (WTR::TestController::platformInitialize):
2856         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2857         (WTR::UIScriptController::dismissFilePicker):
2858
2859 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2860
2861         Implement async paste method on UIWKInteractionViewProtocol
2862         https://bugs.webkit.org/show_bug.cgi?id=196267
2863         <rdar://problem/49236346>
2864
2865         Reviewed by Tim Horton.
2866
2867         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2868         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2869         are now a part of all iOS 12 internal SDKs.
2870
2871         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2872
2873         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2874         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2875
2876         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2877         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2878         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2879         * TestWebKitAPI/ios/UIKitSPI.h:
2880
2881 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2882
2883         [ews-build] Use PostgreSQL for ews.webkit.org database
2884         https://bugs.webkit.org/show_bug.cgi?id=196270
2885
2886         Reviewed by Lucas Forschler.
2887
2888         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2889
2890 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2891
2892         [ews] Reset simctl states on reboot
2893         https://bugs.webkit.org/show_bug.cgi?id=196260
2894
2895         Rubber-stamped by Aakash Jain.
2896
2897         * EWSTools/start-queue-mac.sh:
2898
2899 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2900
2901         [ews-build] Use PostgreSQL for ews-build database
2902         https://bugs.webkit.org/show_bug.cgi?id=196229
2903
2904         Reviewed by Lucas Forschler.
2905
2906         * BuildSlaveSupport/ews-build/master.cfg:
2907
2908 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2909
2910         [ews-build] Get master_hostname dynamically in master.cfg
2911         https://bugs.webkit.org/show_bug.cgi?id=196255
2912
2913         Reviewed by Lucas Forschler.
2914
2915         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2916         send events data in test mode.
2917
2918 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2919
2920         [ews-app] Set db_constraint to False for Foreign Keys
2921         https://bugs.webkit.org/show_bug.cgi?id=196252
2922
2923         Reviewed by Lucas Forschler.
2924
2925         * BuildSlaveSupport/ews-app/ews/models/build.py:
2926         * BuildSlaveSupport/ews-app/ews/models/step.py:
2927
2928 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2929
2930         [ews-build] is_test_mode_enabled should default to True
2931         https://bugs.webkit.org/show_bug.cgi?id=196248
2932
2933         Reviewed by Lucas Forschler.
2934
2935         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2936
2937 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2938
2939         [ews-app] Add webkitperl to ENABLED_QUEUES
2940         https://bugs.webkit.org/show_bug.cgi?id=196253
2941
2942         Reviewed by Lucas Forschler.
2943
2944         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2945
2946 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2947
2948         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2949         https://bugs.webkit.org/show_bug.cgi?id=196211
2950         rdar://problem/49110552
2951
2952         Reviewed by Tim Horton.
2953
2954         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2955         Make sure that EventSenderProxy always exists when running tests. We used to create
2956         it when resetting before the first test, which is a bit too late.
2957
2958         * WebKitTestRunner/TestController.h:
2959         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2960         (WTR::TestController::platformCreateWebView):
2961         (WTR::TestController::platformCreateOtherPage):
2962         (WTR::TestController::finishCreatingPlatformWebView):
2963         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2964         (WTR::PlatformWebView::PlatformWebView):
2965         Moved some code that made NSWindow use NSEvent during web view creation. We may
2966         need to move more if some other case us found, but this is enough for now.
2967
2968 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2969
2970         Unreviewed. Fix typo in GLib geolocation API after r243285.
2971
2972         gelocation -> geolocation.
2973
2974         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2975         (testGeolocationManagerWatchPosition):
2976
2977 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2978
2979         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2980         https://bugs.webkit.org/show_bug.cgi?id=196213
2981
2982         Reviewed by Geoff Garen.
2983
2984         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2985         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2986         (credentialWithIdentityAndKeychainPath):
2987         (-[ChallengeDelegate webView:didFinishNavigation:]):
2988         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2989         (TestWebKitAPI::TEST):
2990
2991 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2992
2993         Expected shouldn't assume its contained types are copyable
2994         https://bugs.webkit.org/show_bug.cgi?id=195986
2995
2996         Reviewed by JF Bastien.
2997
2998         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2999         (TestWebKitAPI::NonCopyable::operator== const):
3000         (TestWebKitAPI::NonCopyable::operator!= const):
3001         (TestWebKitAPI::TEST):
3002
3003 2019-03-25  Tim Horton  <timothy_horton@apple.com>
3004
3005         Remove some now-unnecessary dynamic class lookup
3006         https://bugs.webkit.org/show_bug.cgi?id=196237
3007
3008         Reviewed by Simon Fraser.
3009
3010         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3011         (makeRequest):
3012         (TEST):
3013
3014 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
3015
3016         Unreviewed, rolling out r243450.
3017
3018         AppleWin and WinCairo port builds get broken.
3019
3020         Reverted changeset:
3021
3022         "Add test for fix of #196095"
3023         https://bugs.webkit.org/show_bug.cgi?id=196097
3024         https://trac.webkit.org/changeset/243450
3025
3026 2019-03-25  Commit Queue  <commit-queue@webkit.org>
3027
3028         Unreviewed, rolling out r243465.
3029         https://bugs.webkit.org/show_bug.cgi?id=196226
3030
3031         the test doesn't build (Requested by thorton on #webkit).
3032
3033         Reverted changeset:
3034
3035         "Do not terminate the NetworkProcess if a third party
3036         application sends a NSCredential with a SecIdentityRef"
3037         https://bugs.webkit.org/show_bug.cgi?id=196213
3038         https://trac.webkit.org/changeset/243465
3039
3040 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3041
3042         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3043         https://bugs.webkit.org/show_bug.cgi?id=196213
3044
3045         Reviewed by Geoff Garen.
3046
3047         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3048         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3049         (credentialWithIdentityAndKeychainPath):
3050         (-[ChallengeDelegate webView:didFinishNavigation:]):
3051         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3052         (TestWebKitAPI::TEST):
3053
3054 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3055
3056         [ews-build] Gracefully handle missing patch_id in events
3057         https://bugs.webkit.org/show_bug.cgi?id=196216
3058
3059         Reviewed by Lucas Forschler.
3060
3061         * BuildSlaveSupport/ews-build/events.py:
3062
3063 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3064
3065         [ews-build] use lz4 compression for improving buildbot performance
3066         https://bugs.webkit.org/show_bug.cgi?id=196155
3067
3068         Reviewed by Lucas Forschler.
3069
3070         * BuildSlaveSupport/ews-build/master.cfg:
3071
3072 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3073
3074         Pull some API testing helper methods out of TestWKWebView
3075         https://bugs.webkit.org/show_bug.cgi?id=196212
3076
3077         Reviewed by Tim Horton.
3078
3079         Refactor some more API testing utility methods, so that they can be used in
3080         tests that do not use TestWKWebView.
3081
3082         * TestWebKitAPI/cocoa/TestWKWebView.h:
3083         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3084         (-[WKWebView loadTestPageNamed:]):
3085         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
3086         (-[WKWebView synchronouslyLoadHTMLString:]):
3087         (-[WKWebView synchronouslyLoadTestPageNamed:]):
3088         (-[TestWKWebView loadTestPageNamed:]): Deleted.
3089         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
3090         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
3091         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
3092
3093 2019-03-25  Jer Noble  <jer.noble@apple.com>
3094
3095         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3096         https://bugs.webkit.org/show_bug.cgi?id=196097
3097
3098         Reviewed by Eric Carlson.
3099
3100         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3101
3102         * DumpRenderTree/mac/DumpRenderTree.mm:
3103         (resetWebPreferencesToConsistentValues):
3104         * WebKitTestRunner/TestController.cpp:
3105         (WTR::TestController::resetPreferencesToConsistentValues):
3106
3107 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3108
3109         Pull IPadUserInterfaceSwizzler out into a separate header file
3110         https://bugs.webkit.org/show_bug.cgi?id=196193
3111
3112         Reviewed by Anders Carlsson.
3113
3114         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
3115         be used in other API tests.
3116
3117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3118         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3119         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
3120         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
3121         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
3122         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3123         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3124
3125 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3126
3127         Remove NavigatorContentUtils in WebCore/Modules
3128         https://bugs.webkit.org/show_bug.cgi?id=196070
3129
3130         Reviewed by Alex Christensen.
3131
3132         NavigatorContentUtils was to support the custom scheme spec [1].
3133         However, in WebKit side, no port has supported the feature in
3134         WebKit layer after EFL port was removed. So there has been the
3135         only IDL implementation of the NavigatorContentUtils in WebCore.
3136         So we don't need to keep the implementation in WebCore anymore.
3137
3138         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
3139
3140         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3141
3142 2019-03-24  Andy Estes  <aestes@apple.com>
3143
3144         [watchOS] Remove unused Proximity Networking code
3145         https://bugs.webkit.org/show_bug.cgi?id=196188
3146
3147         Reviewed by Tim Horton.
3148
3149         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3150         (TEST):
3151
3152 2019-03-23  Keith Miller  <keith_miller@apple.com>
3153
3154         Refactor clz/ctz and fix getLSBSet.
3155         https://bugs.webkit.org/show_bug.cgi?id=196162
3156
3157         Reviewed by Saam Barati.
3158
3159         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3160
3161         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3162         (TestWebKitAPI::TEST):
3163
3164 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3165
3166         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3167         https://bugs.webkit.org/show_bug.cgi?id=196143
3168
3169         Reviewed by Michael Catanzaro.
3170
3171         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3172         directories.
3173
3174         * Scripts/webkitpy/style/checkers/cpp.py:
3175         (check_identifier_name_in_declaration):
3176         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3177         (WebKitStyleTest.test_names):
3178
3179 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3180
3181         [Flatpak] Manifest expanding fails for qt WPE extension
3182         https://bugs.webkit.org/show_bug.cgi?id=196148
3183
3184         Reviewed by Alex Christensen.
3185
3186         * flatpak/flatpakutils.py:
3187         (expand_submodules_recurse): The last recurse manifest expand
3188         iteration might lead to a single module so take it into account
3189         and don't try to recurse further.
3190
3191 2019-03-22  Chris Dumez  <cdumez@apple.com>
3192
3193         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3194         https://bugs.webkit.org/show_bug.cgi?id=195348
3195         <rdar://problem/48622090>
3196
3197         Reviewed by Alex Christensen.
3198
3199         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3200         to NO when test.options().shouldIgnoreMetaViewport is false.
3201
3202         * WebKitTestRunner/ios/TestControllerIOS.mm:
3203         (WTR::TestController::platformConfigureViewForTest):
3204
3205 2019-03-22  Chris Dumez  <cdumez@apple.com>
3206
3207         Prewarmed processes should be usable with any website data store
3208         https://bugs.webkit.org/show_bug.cgi?id=196104
3209
3210         Reviewed by Alex Christensen.
3211
3212         Add API test coverage.
3213
3214         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3215         (runInitialWarmedProcessUsedTest):
3216         (TEST):
3217
3218 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3219
3220         Back out local changes to Alex's Subversion working directory
3221
3222         They were accidentally committed.
3223
3224         * Scripts/webkitpy/common/system/abstractexecutive.py:
3225         (AbstractExecutive.wait_newest):
3226         * Scripts/webkitpy/common/system/executive.py:
3227         (Executive.running_pids):
3228         * Scripts/webkitpy/common/system/executive_mock.py:
3229         (MockExecutive.running_pids):
3230         * Scripts/webkitpy/common/system/executive_unittest.py:
3231         (ExecutiveTest.serial_test_running_pids):
3232         * Scripts/webkitpy/port/darwin.py:
3233         (DarwinPort.check_for_leaks):
3234         * Scripts/webkitpy/port/leakdetector.py:
3235         (LeakDetector.check_for_leaks):
3236         - This was the hack attached to Bug 193772.
3237
3238         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3239         (+[WebKitTestRunnerEvent mouseLocation]):
3240         - This works around a crash on an internal build.
3241
3242 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3243
3244         Fix the build after r243354
3245         https://bugs.webkit.org/show_bug.cgi?id=196138
3246         <rdar://problem/49145951>
3247
3248         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3249         (TEST):
3250         * TestWebKitAPI/ios/UIKitSPI.h:
3251
3252 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3253
3254         Adopt UIWKDocumentContext
3255         https://bugs.webkit.org/show_bug.cgi?id=196040
3256         <rdar://problem/48642440>
3257
3258         Reviewed by Ryosuke Niwa.
3259
3260         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3261         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3262         (makeRequest):
3263         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3264         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3265         (applyStyle):
3266         (TEST):
3267         Add tests for UIWKDocumentContext.
3268
3269         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3270         (TEST):
3271         (recursiveFindWKContentView): Deleted.
3272         * TestWebKitAPI/cocoa/TestWKWebView.h:
3273         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3274         (recursiveFindWKContentView):
3275         (-[TestWKWebView wkContentView]):
3276         * TestWebKitAPI/ios/UIKitSPI.h:
3277         Share the WKContentView finding code between tests.
3278
3279 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3280
3281         [iOS WK2] Turn on async overflow scrolling by default
3282         https://bugs.webkit.org/show_bug.cgi?id=196011
3283         rdar://problem/48453859
3284
3285         Reviewed by Antti Koivisto.
3286         
3287         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3288         since so many basic layout tests have different results when compositing is triggered for
3289         overflow.
3290         
3291         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3292
3293         * WebKitTestRunner/TestController.cpp:
3294         (WTR::TestController::resetPreferencesToConsistentValues):
3295
3296 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3297
3298         [ews-build] Retry API test in case of failures
3299         https://bugs.webkit.org/show_bug.cgi?id=196004
3300
3301         Reviewed by Lucas Forschler.
3302
3303         * BuildSlaveSupport/ews-build/steps.py:
3304         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3305         (CompileWebKitToT.doStepIf): Ditto.
3306         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3307         (ReRunAPITests): Re-run API tests.
3308         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3309         (RunAPITestsWithoutPatch): Run API tests without patch.
3310         (RunAPITestsWithoutPatch.doStepIf):
3311         (RunAPITestsWithoutPatch.hideStepIf):
3312         (RunAPITestsWithoutPatch.evaluateCommand):
3313         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3314         (AnalyzeAPITestsResults.start):
3315         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3316         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3317         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3318         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3319
3320 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3321
3322         [ews-build] Update queues configurations
3323         https://bugs.webkit.org/show_bug.cgi?id=196074
3324
3325         Reviewed by Dewei Zhu.
3326
3327         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3328         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3329
3330 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3331
3332         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3333         https://bugs.webkit.org/show_bug.cgi?id=195680
3334         <rdar://problem/48903534>
3335
3336         Unreviewed infrastructure fix.
3337
3338         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3339         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3340
3341 2019-03-21  Andy Estes  <aestes@apple.com>
3342
3343         [iOS] Apple Pay should be available in documents with no user agent scripts
3344         https://bugs.webkit.org/show_bug.cgi?id=196061
3345         <rdar://problem/48649391>
3346
3347         Reviewed by Brady Eidson.
3348
3349         Added API tests and related infrastructure.
3350
3351         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3352         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3353         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3354         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3355         (TestWebKitAPI::TEST):
3356         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3357         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3358         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3359         * TestWebKitAPI/cocoa/TestProtocol.mm:
3360         (-[TestProtocol startLoading]):
3361         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3362         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3363         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3364         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3365
3366 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3367
3368         REGRESSSION (r243297): webkitpy tests broken
3369         https://bugs.webkit.org/show_bug.cgi?id=196108
3370
3371         Reviewed by Aakash Jain.
3372
3373         r243297 updated contributors.json, which broke a few unit tests.
3374
3375         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3376         (IRCCommandTest.test_whois):
3377         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3378
3379 2019-03-21  Chris Dumez  <cdumez@apple.com>
3380
3381         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3382         https://bugs.webkit.org/show_bug.cgi?id=196041
3383         <rdar://problem/49083230>
3384
3385         Reviewed by Alex Christensen.
3386
3387         Add API test coverage.
3388
3389         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3390         (TEST):
3391
3392 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3393
3394         Add SPI to inform applications of WKContentRuleList actions
3395         https://bugs.webkit.org/show_bug.cgi?id=195965
3396         <rdar://problem/42664365>
3397
3398         Reviewed by Geoff Garen.
3399
3400         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3401         (TestWebKitAPI::allActionsForResourceLoad):
3402         (TestWebKitAPI::testRequest):
3403         (TestWebKitAPI::TEST_F):
3404         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3405         (Notification::description):
3406         (Notification::operator== const):
3407         (toVector):
3408         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3409         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3410         (makeContentRuleList):
3411         (TEST):
3412         (makeWarnContentRuleList): Deleted.
3413
3414 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3415
3416         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3417         https://bugs.webkit.org/show_bug.cgi?id=196088
3418
3419         Reviewed by Brian Burg.
3420
3421         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3422         Support checks when only one platform is specified. Also deprecate macosx() and
3423         force the use of macos() instead.
3424
3425         * Scripts/webkitpy/style/checkers/cpp.py:
3426         (check_min_versions_of_wk_api_available):
3427         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3428         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3429
3430 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3431
3432         Update status inactive committers' status to 'contributor'.
3433
3434         * Scripts/webkitpy/common/config/contributors.json:
3435
3436 2019-03-21  Xan Lopez  <xan@igalia.com>
3437
3438         [JSC][x86] Drop support for x87 floating point
3439         https://bugs.webkit.org/show_bug.cgi?id=194853
3440
3441         Reviewed by Don Olmstead.
3442
3443         Force SSE2 on x86/32bit builds.
3444
3445         * Scripts/webkitdirs.pm:
3446         (generateBuildSystemFromCMakeProject):
3447
3448 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3449
3450         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3451         https://bugs.webkit.org/show_bug.cgi?id=196073
3452
3453         Reviewed by Michael Catanzaro.
3454
3455         Add test cases to check functions and constructors with no arguments but receiving user data.
3456
3457         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3458         (checkUserData):
3459         (testJSCFunction):
3460         (fooCreateWithUserData):
3461         (testJSCClass):
3462
3463 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3464
3465         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3466
3467         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3468
3469         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3470
3471 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3472
3473         [GTK][WPE] Add API to provide geolocation information
3474         https://bugs.webkit.org/show_bug.cgi?id=195940
3475
3476         Reviewed by Michael Catanzaro.
3477
3478         Add a new test to check the new API.
3479
3480         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3481         (testGeolocationManagerCurrentPosition):
3482         (testGeolocationManagerWatchPosition):
3483         (beforeAll):
3484         (afterAll):
3485         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3486         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3487         (beforeAll): Ditto.
3488         * TestWebKitAPI/glib/CMakeLists.txt:
3489
3490 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3491
3492         [GLib] Returning G_TYPE_OBJECT from a method does not work
3493         https://bugs.webkit.org/show_bug.cgi?id=195574
3494
3495         Reviewed by Michael Catanzaro.
3496
3497         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3498
3499         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3500         (getGFile):
3501         (getParent):
3502         (createGString):
3503         (getGString):
3504         (getGStringCopyWillRaise):
3505         (getGStringCopy):
3506         (getGStringStr):
3507         (getGStringLen):
3508         (freeGString):
3509         (testJSCClass):
3510
3511 2019-03-20  Saam Barati  <sbarati@apple.com>
3512
3513         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3514         https://bugs.webkit.org/show_bug.cgi?id=195721
3515
3516         Reviewed by Filip Pizlo.
3517
3518         * Scripts/run-javascriptcore-tests:
3519
3520 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3521
3522         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3523         https://bugs.webkit.org/show_bug.cgi?id=196049
3524
3525         Reviewed by Tim Horton.
3526
3527         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3528         overflow scrolling in general, so rename it.
3529
3530         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3531
3532 2019-03-20  Daniel Bates  <dabates@apple.com>
3533
3534         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3535         https://bugs.webkit.org/show_bug.cgi?id=196031
3536         <rdar://problem/49078172>
3537
3538         Reviewed by Tim Horton.
3539
3540         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3541         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3542         same code path used when the Done button is pressed to dismiss the <select> picker.
3543
3544         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3545         (TestWebKitAPI::TEST):
3546
3547 2019-03-20  Chris Dumez  <cdumez@apple.com>
3548
3549         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3550         https://bugs.webkit.org/show_bug.cgi?id=196029
3551         <rdar://problem/48954651>
3552
3553         Reviewed by Tim Horton.
3554
3555         Add API test coverage.
3556
3557         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3558
3559 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3560
3561         [ews-build] Improve failure summary string for ApplyPatch step
3562         https://bugs.webkit.org/show_bug.cgi?id=195995
3563
3564         Reviewed by Alexey Proskuryakov.
3565
3566         * BuildSlaveSupport/ews-build/steps.py:
3567         (ApplyPatch.getResultSummary): Override getResultSummary.
3568
3569 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3570
3571         AX: Implement support for new meter ARIA role
3572         https://bugs.webkit.org/show_bug.cgi?id=195966
3573
3574         Reviewed by Chris Fleizach.
3575
3576         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3577         to AXLevelIndicator.
3578
3579         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3580
3581 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3582
3583         [WebAuthN] Implement FIDO AppID extension
3584         https://bugs.webkit.org/show_bug.cgi?id=143491
3585         <rdar://problem/48298273>
3586
3587         Reviewed by Brent Fulgham.
3588
3589         Add a test that covers the new flag of convertToU2fSignCommand.
3590
3591         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3592         (TestWebKitAPI::TEST):
3593         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3594         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3595         (TestWebKitAPI::TEST):
3596
3597 2019-03-19  Keith Rollin  <krollin@apple.com>
3598
3599         Add support for more platforms to generate-xcfilelists
3600         https://bugs.webkit.org/show_bug.cgi?id=195977
3601
3602         Reviewed by Alexey Proskuryakov.
3603
3604         generate-xcfilelists incorrectly complains when involved with building
3605         WebKit for iphonesimulator:
3606
3607             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3608             …
3609             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3610
3611         Address this by teaching generate-xcfilelists about more platforms.
3612
3613         * Scripts/generate-xcfilelists:
3614
3615 2019-03-19  John Wilander  <wilander@apple.com>
3616
3617         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3618         https://bugs.webkit.org/show_bug.cgi?id=195923
3619         <rdar://problem/49001272>
3620
3621         Reviewed by Alex Christensen.
3622
3623         This patch does the following to the TestRunner:
3624         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3625         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3626         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3627
3628         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3629         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3630         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3631         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3632         * WebKitTestRunner/TestController.cpp:
3633         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3634         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3635         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3636         * WebKitTestRunner/TestController.h:
3637         * WebKitTestRunner/TestInvocation.cpp:
3638         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3639
3640 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3641
3642         [CMake] Support more clang and gcc sanitizers
3643         https://bugs.webkit.org/show_bug.cgi?id=195956
3644
3645         Reviewed by Michael Catanzaro.
3646
3647         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3648
3649 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3650
3651         [ews-build] Improve summary for PrintConfiguration step
3652         https://bugs.webkit.org/show_bug.cgi?id=195945
3653
3654         Reviewed by Lucas Forschler.
3655
3656         * BuildSlaveSupport/ews-build/steps.py:
3657         (PrintConfiguration.getResultSummary): Override getResultSummary.
3658
3659 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3660
3661         [ews-build] Improve summary for CheckOutSource step
3662         https://bugs.webkit.org/show_bug.cgi?id=195963
3663
3664         Reviewed by Lucas Forschler.
3665
3666         * BuildSlaveSupport/ews-build/steps.py:
3667         (CheckOutSource.getResultSummary):
3668
3669 2019-03-19  Daniel Bates  <dabates@apple.com>
3670
3671         [iOS] Focus not preserved when switching between tabs
3672         https://bugs.webkit.org/show_bug.cgi?id=195820
3673         <rdar://problem/43614450>
3674
3675         Reviewed by Brent Fulgham.
3676
3677         Add tests to ensure that we restore focus when resigning and becoming first responder.
3678
3679         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3680         (TestWebKitAPI::TEST):
3681
3682 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3683
3684         Make WTFLogChannelState and WTFLogLevel enum classes
3685         https://bugs.webkit.org/show_bug.cgi?id=195904
3686
3687         Reviewed by Eric Carlson.
3688
3689         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3690         (TestWebKitAPI::TEST_F):
3691
3692 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3693
3694         [GStreamer][EME] Backported mssdemux protection data crash fix
3695         https://bugs.webkit.org/show_bug.cgi?id=195918
3696
3697         Reviewed by Philippe Normand.
3698
3699         * gstreamer/jhbuild.modules:
3700         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3701
3702 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3703
3704         Unreviewed, rolling out r243132.
3705
3706         Broke GTK build
3707
3708         Reverted changeset:
3709
3710         "Make WTFLogChannelState and WTFLogLevel enum classes"
3711         https://bugs.webkit.org/show_bug.cgi?id=195904
3712         https://trac.webkit.org/changeset/243132
3713
3714 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3715
3716         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3717
3718         * Scripts/webkitdirs.pm:
3719         (builtDylibPathForName): Adjust the shared library name that's changed
3720         with the API version bump in r243073.
3721
3722 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3723
3724         Make WTFLogChannelState and WTFLogLevel enum classes
3725         https://bugs.webkit.org/show_bug.cgi?id=195904
3726
3727         Reviewed by Eric Carlson.
3728
3729         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3730         (TestWebKitAPI::TEST_F):
3731
3732 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3733
3734         Disable flaky test added in r2431100
3735         https://webkit.org/b/195785
3736
3737         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3738         (TestWebKitAPI::TEST):
3739         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3740
3741 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3742
3743         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3744         https://bugs.webkit.org/show_bug.cgi?id=195916
3745
3746         Reviewed by Tim Horton.
3747
3748         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3749         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3750
3751 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3752
3753         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3754
3755         * Scripts/webkitpy/common/config/contributors.json:
3756
3757 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3758
3759         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3760         https://bugs.webkit.org/show_bug.cgi?id=195785
3761
3762         Reviewed by Geoffrey Garen.
3763
3764         * TestWebKitAPI/TCPServer.cpp: Added.
3765         (TestWebKitAPI::TCPServer::TCPServer):
3766         (TestWebKitAPI::TCPServer::~TCPServer):
3767         (TestWebKitAPI::TCPServer::socketBindListen):
3768         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3769         * TestWebKitAPI/TCPServer.h: Added.
3770         (TestWebKitAPI::TCPServer::port const):
3771         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3772         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3773         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3774         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3775         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3776         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3777         (TestWebKitAPI::respondSlowly):
3778         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3779         (TestWebKitAPI::downloadAtRate):
3780         (TestWebKitAPI::TEST):
3781
3782 2019-03-18  Saam Barati  <sbarati@apple.com>
3783
3784         Add a plan file for JetStream 2
3785         https://bugs.webkit.org/show_bug.cgi?id=190734
3786
3787         Reviewed by Mark Lam.
3788
3789         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3790
3791 2019-03-18  Chris Dumez  <cdumez@apple.com>
3792
3793         Delay WebProcess launch until a load is triggered in a Web view
3794         https://bugs.webkit.org/show_bug.cgi?id=195758
3795         <rdar://problem/48126013>
3796
3797         Reviewed by Geoff Garen.
3798
3799         Add API test coverage. Also update some existing API tests to not expect
3800         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3801
3802         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3803         (TestWebKitAPI::TEST):
3804         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3805         (TestWebKitAPI::TEST):
3806         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3807         (TEST):
3808         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3809         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3810         (TEST):
3811         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3812         (TEST):
3813         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3814
3815 2019-03-18  Xan Lopez  <xan@igalia.com>
3816
3817         [CMake] Prevent potential warning when determining $architecture
3818         https://bugs.webkit.org/show_bug.cgi?id=195891
3819
3820         Reviewed by Michael Catanzaro.
3821
3822         It's possible for generateBuildSystemForCMakeProject to be called
3823         before determineArchitecture() is ever called. This will make the
3824         first eq check with $architecture to be bogus (and print a
3825         warning). Change that to an eq check with architecture(), which
3826         implicitly calls determineArchitecture() if needed, and change all
3827         the other similar cases in the method in the same way to prevent
3828         future bugs like this one.
3829
3830         * Scripts/webkitdirs.pm:
3831         (generateBuildSystemFromCMakeProject):
3832
3833 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3834
3835         [WPE] Tarballs generated with “make dist” cannot build documentation
3836         https://bugs.webkit.org/show_bug.cgi?id=195885
3837
3838         Reviewed by Carlos Garcia Campos.
3839
3840         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3841
3842 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3843
3844         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3845         https://bugs.webkit.org/show_bug.cgi?id=195883
3846
3847         Reviewed by Carlos Garcia Campos.
3848
3849         * gtkdoc/gtkdoc.py:
3850         (GTKDoc._run_command): When commands fail to run, include the full command line for
3851         the program invocation and the output it has generated on the standard error stream.
3852
3853 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3854
3855         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3856         https://bugs.webkit.org/show_bug.cgi?id=195786
3857
3858         Reviewed by Philippe Normand.
3859
3860         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3861         * wpe/jhbuild.modules: Ditto.
3862
3863 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3864
3865         [ews-build] Don't run clean builds on EWS builders
3866         https://bugs.webkit.org/show_bug.cgi?id=195851
3867
3868         Reviewed by Geoffrey Garen.
3869
3870         * BuildSlaveSupport/ews-build/factories.py:
3871
3872 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3873
3874         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3875         https://bugs.webkit.org/show_bug.cgi?id=195849
3876
3877         Reviewed by Chris Dumez.
3878
3879         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3880
3881         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3882         (runWebsiteDataStoreCustomPaths):
3883
3884 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3885
3886         webkitpy: Upload test results
3887         https://bugs.webkit.org/show_bug.cgi?id=195755
3888         <rdar://problem/48896182>
3889
3890         Reviewed by Aakash Jain.
3891
3892         Establish a new format for uploading results that is not tied to layout tests, apply
3893         that format to webkitpy tests.
3894
3895         * Scripts/webkitpy/common/checkout/scm/git.py:
3896         (Git.native_branch): Return what branch the current checkout is on.
3897         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3898         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3899         * Scripts/webkitpy/common/checkout/scm/svn.py:
3900         (SVN.native_branch): Ditto.
3901         * Scripts/webkitpy/common/system/platforminfo.py:
3902         (PlatformInfo.build_version): Return a build version for Mac.
3903         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3904         (MockPlatformInfo.__init__):
3905         (MockPlatformInfo.build_version):
3906         * Scripts/webkitpy/results: Added.
3907         * Scripts/webkitpy/results/__init__.py: Added.
3908         * Scripts/webkitpy/results/options.py: Added.
3909         (upload_options): OptParse list for upload options.
3910         * Scripts/webkitpy/results/upload.py: Added.
3911         (Upload): Class which enforces the upload format expected by the results server.
3912         (Upload.Expectations):
3913         (Upload.create_configuration):
3914         (Upload.create_commit):
3915         (Upload.create_details):
3916         (Upload.create_run_stats):
3917         (Upload.create_test_result):
3918         (Upload.__init__):
3919         (Upload.Encoder): Encode Upload object as json.
3920         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3921         * Scripts/webkitpy/results/upload_unittest.py: Added.
3922         * Scripts/webkitpy/test/main.py:
3923         (Tester._parse_args): Add upload arguments.
3924         (Tester._run_tests): Allow results to be uploaded.
3925         * Scripts/webkitpy/test/runner.py:
3926         (Runner.__init__): Record which tests were run, rather than just counting them.
3927         (Runner.handle):
3928         * Scripts/webkitpy/test/runner_unittest.py:
3929         (RunnerTest.test_run):
3930         * Scripts/webkitpy/thirdparty/__init__.py:
3931         (AutoinstallImportHook.find_module): Add requests auto-install.
3932         (AutoinstallImportHook._install_requests):
3933         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3934         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3935
3936 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3937
3938         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3939         https://bugs.webkit.org/show_bug.cgi?id=195810
3940
3941         Reviewed by Tim Horton.
3942
3943         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3944         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3945         ending certain layout tests.
3946
3947         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3948         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3949         (-[TestRunnerWKWebView dealloc]):
3950         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3951
3952         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3953         helper method when destroying the web view, and when resetting state between tests.
3954
3955         * WebKitTestRunner/ios/TestControllerIOS.mm:
3956         (WTR::TestController::platformResetStateToConsistentValues):
3957
3958         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3959
3960 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3961
3962         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3963         https://bugs.webkit.org/show_bug.cgi?id=190350
3964         <rdar://problem/45089503>
3965
3966         Reviewed by Geoffrey Garen.
3967
3968         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3969         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3970         (TEST):
3971         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3972         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3973         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3974         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3975         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3976         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3977         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3978         (runTest):
3979         (createDirectories):
3980         (TEST):
3981         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3982         (TEST):
3983         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3984         (TEST):
3985
3986 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3987
3988         Add support to WebPage for getting the contents as an attributed string.
3989         https://bugs.webkit.org/show_bug.cgi?id=195636
3990         rdar://problem/45055697
3991
3992         Reviewed by Tim Horton.
3993
3994         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3995         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3996
3997 2019-03-15  Chris Dumez  <cdumez@apple.com>
3998
3999         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
4000         https://bugs.webkit.org/show_bug.cgi?id=195747
4001
4002         Reviewed by Geoff Garen.
4003
4004         Add API test coverage.
4005
4006         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4007
4008 2019-03-15  Shawn Roberts  <sroberts@apple.com>
4009
4010         Unreviewed, rolling out r242952.
4011
4012         Causing API failures on iOS Simulator
4013
4014         Reverted changeset:
4015
4016         "[PSON] Make sure the WebProcessCache is leverage when
4017         relaunching a process after termination"
4018         https://bugs.webkit.org/show_bug.cgi?id=195747
4019         https://trac.webkit.org/changeset/242952
4020
4021 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
4022
4023         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
4024         https://bugs.webkit.org/show_bug.cgi?id=195740
4025
4026         Reviewed by Ross Kirsling.
4027
4028         window.open doesn't work for WebKitBrowserWindow because it is not
4029         implemented yet.
4030
4031         1. Implemented createNewPage callback of WKPageUIClient.
4032         2. Changed MainWindow to take a BrowserWindow factory function
4033           instead of BrowserWindowType to be flexible to create
4034           BrowserWindow with extra settings.
4035         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
4036           because it is not relevant with MainWindow anymore.
4037
4038         * MiniBrowser/win/Common.cpp:
4039         (parseCommandLine):
4040         * MiniBrowser/win/Common.h:
4041         (CommandLineOptions::CommandLineOptions):
4042         * MiniBrowser/win/MainWindow.cpp:
4043         (MainWindow::MainWindow):
4044         (MainWindow::create):
4045         (MainWindow::init):
4046         (MainWindow::WndProc):
4047         * MiniBrowser/win/MainWindow.h:
4048         * MiniBrowser/win/PrintWebUIDelegate.cpp:
4049         (PrintWebUIDelegate::createWebViewWithRequest):
4050         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4051         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
4052         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
4053         (WebKitBrowserWindow::updateProxySettings):
4054         (WebKitBrowserWindow::createNewPage):
4055         * MiniBrowser/win/WebKitBrowserWindow.h:
4056         * MiniBrowser/win/WinMain.cpp:
4057         (wWinMain):
4058
4059 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
4060
4061         Make it possible to test scrolling tree layer manipulation more easily
4062         https://bugs.webkit.org/show_bug.cgi?id=195780
4063
4064         Reviewed by Tim Horton.
4065         
4066         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
4067         cuts off communication of scrolling tree scrolls back to the web process
4068         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
4069         allows tests to trigger scrolls which run the scrolling tree layer positioning
4070         logic, but never get another commit from the web process that might mask
4071         scrolling tree bugs.
4072         
4073         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
4074         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
4075         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
4076
4077         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4078         (WTR::UIScriptController::scrollUpdatesDisabled const):
4079         (WTR::UIScriptController::setScrollUpdatesDisabled):
4080         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4081         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4082         (WTR::UIScriptController::scrollUpdatesDisabled const):
4083         (WTR::UIScriptController::setScrollUpdatesDisabled):
4084         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4085         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4086         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4087         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
4088         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
4089         * WebKitTestRunner/ios/TestControllerIOS.mm:
4090         (WTR::TestController::platformResetStateToConsistentValues):
4091         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4092         (WTR::UIScriptController::scrollUpdatesDisabled const):
4093         (WTR::UIScriptController::setScrollUpdatesDisabled):
4094
4095 2019-03-14  Youenn Fablet  <youenn@apple.com>
4096
4097         Move IDB storage in private browsing mode to NetworkProcess
4098         https://bugs.webkit.org/show_bug.cgi?id=195602
4099
4100         Reviewed by Brady Eidson.
4101
4102         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
4103         (TEST):
4104
4105 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4106
4107         [ews-build] Make descriptionDone messages more readable
4108         https://bugs.webkit.org/show_bug.cgi?id=195760
4109
4110         Reviewed by Lucas Forschler.
4111
4112         * BuildSlaveSupport/ews-build/steps.py:
4113         * BuildSlaveSupport/ews-build/steps_unittest.py:
4114
4115 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4116
4117         [ews-build] Generate status-bubble hover-over messages
4118         https://bugs.webkit.org/show_bug.cgi?id=195680
4119
4120         Reviewed by Lucas Forschler.
4121
4122         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4123         (StatusBubble):
4124         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
4125         on hover-over.
4126         (StatusBubble._iso_time):
4127         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
4128         hover-over message.
4129         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
4130
4131 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4132
4133         [ews-app] Gracefully handle the case when state_string is None
4134         https://bugs.webkit.org/show_bug.cgi?id=195753
4135
4136         Reviewed by Lucas Forschler.
4137
4138         * BuildSlaveSupport/ews-app/ews/models/build.py:
4139         * BuildSlaveSupport/ews-app/ews/models/step.py:
4140
4141 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4142
4143         [ews-app] Status bubble display pending for currently running build step
4144         https://bugs.webkit.org/show_bug.cgi?id=195744
4145
4146         Reviewed by Lucas Forschler.
4147
4148         * BuildSlaveSupport/ews-build/events.py:
4149         (Events.stepStarted): If state_string is pending, replace it with step name.
4150
4151 2019-03-14  Chris Dumez  <cdumez@apple.com>
4152
4153         Add WebsitePolicy for the client to specify the device orientation & motion access policy
4154         https://bugs.webkit.org/show_bug.cgi?id=195750
4155
4156         Reviewed by Geoffrey Garen.
4157
4158         Add API test coverage.
4159
4160         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4161         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
4162         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4163         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4164
4165 2019-03-14  Chris Dumez  <cdumez@apple.com>
4166
4167         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
4168         https://bugs.webkit.org/show_bug.cgi?id=195747
4169
4170         Reviewed by Geoff Garen.
4171
4172         Add API test coverage.
4173
4174         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4175
4176 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4177
4178         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
4179         https://bugs.webkit.org/show_bug.cgi?id=195725
4180         <rdar://problem/48545062>
4181
4182         Reviewed by Tim Horton.
4183
4184         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
4185         handler is nil.
4186
4187         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4188         (TestWebKitAPI::TEST):
4189
4190 2019-03-13  Sam Weinig  <sam@webkit.org>
4191
4192         Add utility function to allow easy reverse range-based iteration of a container
4193         https://bugs.webkit.org/show_bug.cgi?id=195542
4194
4195         Reviewed by Antti Koivisto.
4196
4197         * TestWebKitAPI/CMakeLists.txt:
4198         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4199         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
4200         (TestWebKitAPI::TEST):
4201         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
4202
4203 2019-03-13  Chris Dumez  <cdumez@apple.com>
4204
4205         Use a ServiceWorker process per registrable domain
4206         https://bugs.webkit.org/show_bug.cgi?id=195649
4207
4208         Reviewed by Youenn Fablet.
4209
4210         Update API test coverage.
4211
4212         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4213
4214 2019-03-13  Chris Dumez  <cdumez@apple.com>
4215
4216         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
4217         https://bugs.webkit.org/show_bug.cgi?id=195684
4218         <rdar://problem/48294714>
4219
4220         Reviewed by Antti Koivisto.
4221
4222         Add API test coverage.
4223
4224         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4225
4226 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4227
4228         [ews-app] Remove unused patch view
4229         https://bugs.webkit.org/show_bug.cgi?id=195669
4230
4231         Reviewed by Lucas Forschler.
4232
4233         * BuildSlaveSupport/ews-app/ews/urls.py:
4234         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
4235
4236 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4237
4238         [ews-app] Use Buildbot result code variables
4239         https://bugs.webkit.org/show_bug.cgi?id=195668
4240
4241         Reviewed by Alexey Proskuryakov.
4242
4243         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
4244         (Buildbot): Added Buildbot result code variables.
4245         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4246         (StatusBubble._build_bubble): Used Buildbot result code variables.
4247
4248 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
4249
4250         [Flatpak] Expand submodule recursively
4251         https://bugs.webkit.org/show_bug.cgi?id=195672
4252
4253         Building WPE with flatpak was impossible without that as it was raising an exception.
4254         Also update wpebackend-fdo to match what is built in jhbuild
4255
4256         Reviewed by Philippe Normand.
4257
4258         * flatpak/flatpakutils.py:
4259         (expand_submodules_recurse):
4260         (expand_manifest):
4261         * flatpak/org.webkit.WPEModules.yaml:
4262
4263 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4264
4265         [ews-app] status bubble should be hidden for certain builds
4266         https://bugs.webkit.org/show_bug.cgi?id=194597
4267
4268         Reviewed by Dewei Zhu.
4269
4270         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4271         (StatusBubble._build_bubble):
4272         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
4273         because the patch didn't have relevant changes.
4274         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
4275         in production yet.
4276
4277 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
4278
4279         [Win] Fix a slew of simple clang-cl warnings.
4280         https://bugs.webkit.org/show_bug.cgi?id=195652
4281
4282         Reviewed by Don Olmstead.
4283
4284         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4285         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
4286
4287 2019-03-12  Justin Fan  <justin_fan@apple.com>
4288
4289         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
4290         https://bugs.webkit.org/show_bug.cgi?id=195518
4291         <rdar://problem/46322356>
4292
4293         Reviewed by Myles C. Maxfield.
4294
4295         * DumpRenderTree/DerivedSources-input.xcfilelist:
4296         * DumpRenderTree/DerivedSources-output.xcfilelist:
4297
4298 2019-03-12  Commit Queue  <commit-queue@webkit.org>
4299
4300         Unreviewed, rolling out r242825.
4301         https://bugs.webkit.org/show_bug.cgi?id=195648
4302
4303         "Broke webkitpy tests with my change to
4304         lldb_dump_class_layout.py" (Requested by rmorisset on
4305         #webkit).
4306
4307         Reverted changeset:
4308
4309         "Alter Tools/Scripts/dump-class-layout to be able to dump all
4310         classes with suspicious padding"
4311         https://bugs.webkit.org/show_bug.cgi?id=195573
4312         https://trac.webkit.org/changeset/242825
4313
4314 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4315
4316         [ews-build] Show status bubbles while the patch is waiting in queue
4317         https://bugs.webkit.org/show_bug.cgi?id=195618
4318
4319         Reviewed by Lucas Forschler.
4320
4321         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4322         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are