Unreviewed, add my new email address
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2
3         Unreviewed, add my new email address
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2019-01-19  Zalan Bujtas  <zalan@apple.com>
8
9         [LFC][BFC] <body>'s overflow property value is propagated to viewport
10         https://bugs.webkit.org/show_bug.cgi?id=193617
11
12         Reviewed by Antti Koivisto.
13
14         * LayoutReloaded/misc/LFC-passing-tests.txt:
15
16 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
17
18         Unreviewed, rolling out r240209.
19
20         Broke GTK/WPE injected bundle
21
22         Reverted changeset:
23
24         "AX: Support returning relative frames for accessibility"
25         https://bugs.webkit.org/show_bug.cgi?id=193414
26         https://trac.webkit.org/changeset/240209
27
28 2019-01-12  Dan Bernstein  <mitz@apple.com>
29
30         [Cocoa] Avoid importing directly from subumbrella frameworks
31         https://bugs.webkit.org/show_bug.cgi?id=186016
32         <rdar://problem/40591038>
33
34         Reviewed by Sam Weinig.
35
36         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
37           LaunchServices header.
38         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
39           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
40         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
41           when using SDKs earlier than 10.13.
42         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
43           and OTHER_CPLUSPLUSFLAGS.
44         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
45           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
46         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
47           LaunchServices header.
48
49 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
50
51         Cache bytecode to disk
52         https://bugs.webkit.org/show_bug.cgi?id=192782
53         <rdar://problem/46084932>
54
55         Reviewed by Keith Miller.
56
57         Add test helper to execute bytecode-cache tests: it executes each test
58         twice, the first with JSC_diskCachePath set to a temporary directory
59         and second with JSC_forceDiskCache=true (in addition to the cache path)
60         to guarantee that only the disk cache is being used and no new
61         UnlinkedCodeBlocks are being created.
62
63         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
64         * Scripts/run-jsc-stress-tests:
65
66 2019-01-20  chris fleizach  <cfleizach@apple.com>
67
68         AX: Support returning relative frames for accessibility
69         https://bugs.webkit.org/show_bug.cgi?id=193414
70         <rdar://problem/47268501>
71
72         Reviewed by Zalan Bujtas.
73
74         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
75         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
76         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
77         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
78         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
79         (WTR::attributesOfElement):
80         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
81
82 2019-01-20  Antoine Quint  <graouts@apple.com>
83
84         Add a POINTER_EVENTS feature flag
85         https://bugs.webkit.org/show_bug.cgi?id=193577
86         <rdar://problem/47408511>
87
88         Unreviewed. Also enable Pointer Events for iosmac.
89
90         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
91
92 2019-01-19  Zalan Bujtas  <zalan@apple.com>
93
94         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
95         https://bugs.webkit.org/show_bug.cgi?id=193613
96
97         Reviewed by Antti Koivisto.
98
99         * LayoutReloaded/misc/LFC-passing-tests.txt:
100
101 2019-01-19  Antoine Quint  <graouts@apple.com>
102
103         Add a POINTER_EVENTS feature flag
104         https://bugs.webkit.org/show_bug.cgi?id=193577
105
106         Reviewed by Dean Jackson.
107
108         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
109
110 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
111
112         Disable the run-jsc-stress-test remote host key check [second round].
113         https://bugs.webkit.org/show_bug.cgi?id=192988
114
115         Reviewed by Dewei Zhu.
116
117         * Scripts/run-jsc-stress-tests:
118
119 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
120
121         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
122         https://bugs.webkit.org/show_bug.cgi?id=193597
123
124         Reviewed by Lucas Forschler.
125
126         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
127
128 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
129
130         [build.webkit.org] api tests failures are incorrectly named as unit test failures
131         https://bugs.webkit.org/show_bug.cgi?id=193595
132
133         Reviewed by Lucas Forschler.
134
135         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
136         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
137         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
138
139 2019-01-18  Chris Dumez  <cdumez@apple.com>
140
141         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
142         https://bugs.webkit.org/show_bug.cgi?id=193588
143         <rdar://problem/47131566>
144
145         Reviewed by Alex Christensen.
146
147         Add layout test coverage.
148
149         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
150
151 2019-01-18  Jer Noble  <jer.noble@apple.com>
152
153         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
154         https://bugs.webkit.org/show_bug.cgi?id=189553
155
156         Reviewed by Tim Horton.
157
158         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
159
160         * ContentExtensionTester/Configurations/Base.xcconfig:
161         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
162         * DumpRenderTree/mac/Configurations/Base.xcconfig:
163         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
164         * ImageDiff/cg/Configurations/Base.xcconfig:
165         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
166         * MiniBrowser/Configurations/Base.xcconfig:
167         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
168         * MobileMiniBrowser/Configurations/Base.xcconfig:
169         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
170         * Scripts/webkitpy/style/checker.py:
171         (_all_categories):
172         (FileType):
173         (CheckerDispatcher._file_type):
174         (CheckerDispatcher._create_checker):
175         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
176         (SDKVariantChecker):
177         (SDKVariantChecker.__init__):
178         (SDKVariantChecker.check):
179         * TestWebKitAPI/Configurations/Base.xcconfig:
180         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
181         * WebEditingTester/Configurations/Base.xcconfig:
182         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
183         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
184         * WebKitTestRunner/Configurations/Base.xcconfig:
185         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
186         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
187         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
188
189 2019-01-18  David Kilzer  <ddkilzer@apple.com>
190
191         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
192         <https://webkit.org/b/193568>
193         <rdar://problem/47381130>
194
195         Reviewed by Alex Christensen.
196
197         Make sure no one re-introduces UIKit soft-linking by adding a
198         style rule.
199
200         * Scripts/webkitpy/style/checkers/cpp.py:
201         (check_language): Add softlink/uikit check.
202         (CppChecker): Enable softlink/uikit check.
203         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
204         (CppStyleTest): Add test for softlink/uikit.
205
206 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
207
208         [GTK] install-dependencies tool looks for libunistring-dev for dnf
209         https://bugs.webkit.org/show_bug.cgi?id=193584
210
211         Change "-dev" to "-devel".
212
213         Reviewed by Michael Catanzaro.
214
215         * gtk/install-dependencies:
216
217 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
218
219         webkitpy: Add iPhone and iPad ports
220         https://bugs.webkit.org/show_bug.cgi?id=193537
221         <rdar://problem/47353390>
222
223         Reviewed by Lucas Forschler.
224
225         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
226         ports. Note that this separation is optional, the --ios-simulator command remains.
227
228         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
229         (RunTest.test_device_type_test_division): Drive-by fix.
230         (RunTest.test_device_type_specific_listing): Ditto.
231         (RunTest.test_ipad_test_division):
232         (RunTest):
233         (RunTest.test_ipad_listing):
234         * Scripts/webkitpy/port/factory.py:
235         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
236         (PortFactory):
237         * Scripts/webkitpy/port/ios_simulator.py:
238         (IPhoneSimulatorPort):
239         (IPadSimulatorPort):
240
241 2019-01-18  Chris Dumez  <cdumez@apple.com>
242
243         Regression(PSON) Scroll position is not always restored properly when navigating back
244         https://bugs.webkit.org/show_bug.cgi?id=193578
245         <rdar://problem/47386331>
246
247         Reviewed by Tim Horton.
248
249         Add API test coverage.
250
251         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
252
253 2019-01-18  Youenn Fablet  <youenn@apple.com>
254
255         Add a new SPI to request for cache storage quota increase
256         https://bugs.webkit.org/show_bug.cgi?id=193323
257
258         Reviewed by Alex Christensen.
259
260         Implement WebsiteDataStore quota delegate to handle quota requests.
261         By default, do not update quota.
262         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
263
264         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
265         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
266         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
267         * WebKitTestRunner/InjectedBundle/TestRunner.h:
268         * WebKitTestRunner/TestController.cpp:
269         (WTR::TestController::allowCacheStorageQuotaIncrease):
270         * WebKitTestRunner/TestController.h:
271         * WebKitTestRunner/TestInvocation.cpp:
272         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
273         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
274         (-[CacheStorageQuotaManager init]):
275         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
276         (WTR::initializeWebViewConfiguration):
277         (WTR::TestController::cocoaResetStateToConsistentValues):
278         (WTR::TestController::allowCacheStorageQuotaIncrease):
279
280 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
281
282         [ews-build] Pass owner to the triggered builds
283         https://bugs.webkit.org/show_bug.cgi?id=193574
284
285         Reviewed by Lucas Forschler.
286
287         * BuildSlaveSupport/ews-build/factories.py:
288         (BuildFactory.propertiesToPassToTriggers):
289
290 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
291
292         [ews-app] Send patch author as a build property
293         https://bugs.webkit.org/show_bug.cgi?id=193560
294
295         Reviewed by Lucas Forschler.
296
297         * BuildSlaveSupport/ews-app/ews/fetcher.py:
298         (BugzillaPatchFetcher.fetch):
299
300 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
301
302         webkitpy: Implement device type specific expected results (Follow-up fix)
303         https://bugs.webkit.org/show_bug.cgi?id=192162
304         <rdar://problem/46345449>
305
306         Unreviewed infrastructure fix.
307
308         * Scripts/webkitpy/layout_tests/controllers/manager.py:
309         (Manager.run): Don't boot a device if no tests are available to run on it.
310
311 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
312
313         webkitpy: Implement device type specific expected results (Follow-up fix)
314         https://bugs.webkit.org/show_bug.cgi?id=192162
315         <rdar://problem/46345449>
316
317         Unreviewed infrastructure fix.
318
319         * Scripts/webkitpy/api_tests/manager.py:
320         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
321
322 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
323
324         webkitpy: Implement device type specific expected results (Part 2)
325         https://bugs.webkit.org/show_bug.cgi?id=192162
326         <rdar://problem/46345449>
327
328         Rubber-stamped by Aakash Jain.
329
330         This change uses device_type to select a different set of TestExpectation files based on the type of device running
331         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
332         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
333
334         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
335         (LayoutTestFinder.find_tests): Pass device_type through.
336         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
337         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
338         * Scripts/webkitpy/layout_tests/controllers/manager.py:
339         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
340         (Manager._collect_tests): Pass device type to test finder.
341         (Manager._needs_web_platform_test):
342         (Manager._prepare_lists): Index _expectations by device type.
343         (Manager._test_input_for_file):
344         (Manager._test_is_slow): Ditto.
345         (Manager._test_should_dump_jsconsolelog_in_stderr):
346         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
347         (Manager._get_test_inputs):
348         (Manager._update_worker_count):
349         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
350         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
351         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
352         the one which runs the test.
353         (Manager._run_test_subset):
354         (Manager._run_tests): Index _expectations by current_device_type.
355         (Manager._print_expectation_line_for_test): Ditto.
356         (Manager._print_expectations_for_subset): Ditto.
357         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
358         Unlike run, this function will behave the same regardless of what devices are available.
359         (Manager._custom_device_for_test): Deleted.
360         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
361         (ManagerTest.test_uses_custom_device): Deleted.
362         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
363         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
364         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
365         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
366         all of the expectations.
367         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
368         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
369         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
370         (TestExpectations.__init__): Allow device_type to be passed through.
371         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
372         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
373         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
374         (summarize_results):
375         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
376         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
377         a test ran with, one must check all expectations to find the first non-skip expectation.
378         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
379         (RunTest.test_device_type_test_division):
380         (RunTest):
381         (RunTest.test_device_type_specific_listing):
382         * Scripts/webkitpy/port/base.py:
383         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
384         (Port.supported_device_types): The result of this function will change based on what devices are available.
385         * Scripts/webkitpy/port/device_port.py:
386         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
387         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
388         can be used.
389         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
390         any, or the DEFAULT_DEVICE_TYPES of the port.
391         * Scripts/webkitpy/port/ios.py:
392         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
393         * Scripts/webkitpy/port/ios_simulator.py:
394         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
395         * Scripts/webkitpy/port/watch.py:
396         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
397         * Scripts/webkitpy/port/watch_simulator.py:
398         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
399         * Scripts/webkitpy/xcode/device_type.py:
400         (DeviceType):
401         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
402
403 2019-01-18  Philippe Normand  <pnormand@igalia.com>
404
405         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
406         https://bugs.webkit.org/show_bug.cgi?id=193575
407
408         Reviewed by Michael Catanzaro.
409
410         Allow the script to run without explicit port argument because
411         it's specific to the WPE port anyway.
412
413         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
414         and simplify the rest of the code accordingly.
415
416 2019-01-18  Charlie Turner  <cturner@igalia.com>
417
418         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
419         https://bugs.webkit.org/show_bug.cgi?id=192229
420
421         Reviewed by Xabier Rodriguez-Calvar.
422
423         * MiniBrowser/wpe/main.cpp:
424         (main): Enable encrypted-media by default.
425
426 2019-01-18  Philippe Normand  <pnormand@igalia.com>
427
428         [Flatpak] Missing KeyboardInterrupt exception handler
429         https://bugs.webkit.org/show_bug.cgi?id=193570
430
431         Reviewed by Michael Catanzaro.
432
433         * flatpak/flatpakutils.py:
434         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
435
436 2019-01-18  Zalan Bujtas  <zalan@apple.com>
437
438         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
439         https://bugs.webkit.org/show_bug.cgi?id=193564
440
441         Reviewed by Antti Koivisto.
442
443         * LayoutReloaded/misc/LFC-passing-tests.txt:
444
445 2019-01-18  Zalan Bujtas  <zalan@apple.com>
446
447         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
448         https://bugs.webkit.org/show_bug.cgi?id=193562
449
450         Reviewed by Antti Koivisto.
451
452         * LayoutReloaded/misc/LFC-passing-tests.txt:
453
454 2019-01-18  Zalan Bujtas  <zalan@apple.com>
455
456         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
457         https://bugs.webkit.org/show_bug.cgi?id=193555
458
459         Reviewed by Antti Koivisto.
460
461         * LayoutReloaded/misc/LFC-passing-tests.txt:
462
463 2019-01-18  Philippe Normand  <pnormand@igalia.com>
464
465         [WPE] Add Qt extension
466         https://bugs.webkit.org/show_bug.cgi?id=191464
467
468         Reviewed by Carlos Garcia Campos.
469
470         MiniBrowser and API tests for the WPE Qt API. To run the
471         MiniBrowser a new script is introduced. Example invocation:
472
473         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
474
475         Also note-worthy is the introduction of the python2-subprocess32
476         dependency to run the GLib API tests.
477
478         * MiniBrowser/wpe/CMakeLists.txt:
479         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
480         * MiniBrowser/wpe/qt/main.cpp: Added.
481         (main):
482         * MiniBrowser/wpe/qt/main.qml: Added.
483         * MiniBrowser/wpe/qt/qml.qrc: Added.
484         * Scripts/run-gtk-tests:
485         (GtkTestRunner.is_google_test):
486         (GtkTestRunner):
487         (GtkTestRunner.is_qt_test):
488         * Scripts/run-qt-wpe-minibrowser: Added.
489         * Scripts/run-wpe-tests:
490         (WPETestRunner):
491         (WPETestRunner.is_google_test):
492         (WPETestRunner.is_qt_test):
493         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
494         (TestLoad::main):
495         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
496         (TestLoadHtml::main):
497         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
498         (TestLoadRequest::main):
499         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
500         (TestRunJavaScript::main):
501         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
502         (waitForSignal):
503         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
504         (LoadSpy::LoadSpy):
505         (LoadSpy::~LoadSpy):
506         (LoadSpy::onLoadingChanged):
507         (LoadStartedCatcher::LoadStartedCatcher):
508         (LoadStartedCatcher::~LoadStartedCatcher):
509         (LoadStartedCatcher::onLoadingChanged):
510         (waitForLoadSucceeded):
511         (waitForLoadFailed):
512         * TestWebKitAPI/glib/CMakeLists.txt:
513         * flatpak/flatpakutils.py:
514         (WebkitFlatpak.load_from_args):
515         (WebkitFlatpak.__init__):
516         (WebkitFlatpak.clean_args):
517         (WebkitFlatpak.run_in_sandbox):
518         * flatpak/org.webkit.CommonModules.yaml:
519         * flatpak/org.webkit.WPE.yaml:
520         * flatpak/org.webkit.WPEModules.yaml:
521         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
522         * flatpak/org.webkit.WebKit.yaml:
523         * glib/api_test_runner.py:
524         (TestRunner._run_test_qt):
525         (TestRunner.is_qt_test):
526         (TestRunner._run_test):
527
528 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
529
530         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
531         https://bugs.webkit.org/show_bug.cgi?id=193494
532         <rdar://problem/46859627>
533
534         Reviewed by Simon Fraser and Tim Horton.
535
536         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
537         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
538
539         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
540         (WTR::UIScriptController::contentOffsetX const):
541         (WTR::UIScriptController::contentOffsetY const):
542         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
543         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
544         (WTR::UIScriptController::contentOffsetX const):
545         (WTR::UIScriptController::contentOffsetY const):
546         * TestRunnerShared/UIScriptContext/UIScriptController.h:
547
548         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
549
550         * WebKitTestRunner/TestController.cpp:
551         (WTR::updateTestOptionsFromTestHeader):
552         * WebKitTestRunner/TestOptions.h:
553         (WTR::TestOptions::hasSameInitializationOptions const):
554         * WebKitTestRunner/ios/TestControllerIOS.mm:
555         (WTR::TestController::platformResetStateToConsistentValues):
556         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
557         (WTR::UIScriptController::contentOffsetX const):
558         (WTR::UIScriptController::contentOffsetY const):
559
560 2019-01-17  Truitt Savell  <tsavell@apple.com>
561
562         Unreviewed, rolling out r240124.
563
564         This commit broke an internal build.
565
566         Reverted changeset:
567
568         "SDK_VARIANT build destinations should be separate from non-
569         SDK_VARIANT builds"
570         https://bugs.webkit.org/show_bug.cgi?id=189553
571         https://trac.webkit.org/changeset/240124
572
573 2019-01-17  Alex Christensen  <achristensen@webkit.org>
574
575         Fix string concatenation API test after r239920
576         https://bugs.webkit.org/show_bug.cgi?id=193551
577         <rdar://problem/47359304>
578
579         Reviewed by Youenn Fablet.
580
581         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
582         (TestWebKitAPI::TEST):
583         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
584         in WebKit's build configuration like it apparently is on Linux.
585
586 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
587
588         [ews-build] validate-patch should handle the case when bug_id is None
589         https://bugs.webkit.org/show_bug.cgi?id=193547
590
591         Reviewed by Lucas Forschler.
592
593         * BuildSlaveSupport/ews-build/steps.py:
594         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
595         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
596
597 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
598
599         [ews-build] Add patch author information in build
600         https://bugs.webkit.org/show_bug.cgi?id=193465
601
602         Reviewed by Lucas Forschler.
603
604         * BuildSlaveSupport/ews-build/steps.py:
605         (ValidatePatch._is_patch_obsolete):
606
607 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
608
609         [ews-build] Pass bug_id to the triggered builds
610         https://bugs.webkit.org/show_bug.cgi?id=193548
611
612         Reviewed by Lucas Forschler.
613
614         * BuildSlaveSupport/ews-build/factories.py:
615         (BuildFactory.propertiesToPassToTriggers):
616
617 2019-01-17  Jer Noble  <jer.noble@apple.com>
618
619         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
620         https://bugs.webkit.org/show_bug.cgi?id=189553
621
622         Reviewed by Tim Horton.
623
624         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
625
626         * ContentExtensionTester/Configurations/Base.xcconfig:
627         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
628         * DumpRenderTree/mac/Configurations/Base.xcconfig:
629         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
630         * ImageDiff/cg/Configurations/Base.xcconfig:
631         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
632         * MiniBrowser/Configurations/Base.xcconfig:
633         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
634         * MobileMiniBrowser/Configurations/Base.xcconfig:
635         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
636         * Scripts/webkitpy/style/checker.py:
637         (_all_categories):
638         (FileType):
639         (CheckerDispatcher._file_type):
640         (CheckerDispatcher._create_checker):
641         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
642         (SDKVariantChecker):
643         (SDKVariantChecker.__init__):
644         (SDKVariantChecker.check):
645         * TestWebKitAPI/Configurations/Base.xcconfig:
646         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
647         * WebEditingTester/Configurations/Base.xcconfig:
648         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
649         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
650         * WebKitTestRunner/Configurations/Base.xcconfig:
651         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
652         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
653         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
654
655 2019-01-17  Zalan Bujtas  <zalan@apple.com>
656
657         [LFC][BFC] An element with transform is a containing block for positioned descendants.
658         https://bugs.webkit.org/show_bug.cgi?id=193534
659
660         Reviewed by Antti Koivisto.
661
662         * LayoutReloaded/misc/LFC-passing-tests.txt:
663
664 2019-01-17  Zalan Bujtas  <zalan@apple.com>
665
666         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
667         https://bugs.webkit.org/show_bug.cgi?id=193528
668
669         Reviewed by Antti Koivisto.
670
671         * LayoutReloaded/misc/LFC-passing-tests.txt:
672
673 2019-01-17  Zalan Bujtas  <zalan@apple.com>
674
675         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
676         https://bugs.webkit.org/show_bug.cgi?id=193520
677
678         Reviewed by Antti Koivisto.
679
680         * LayoutReloaded/misc/LFC-passing-tests.txt:
681
682 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
683
684         [ews-build] unapply-patch step should not update source
685         https://bugs.webkit.org/show_bug.cgi?id=193234
686
687         Reviewed by Lucas Forschler.
688
689         * BuildSlaveSupport/ews-build/steps.py:
690         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
691         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
692
693 2019-01-16  Youenn Fablet  <youenn@apple.com>
694
695         Add a new SPI for controlling getUserMedia
696         https://bugs.webkit.org/show_bug.cgi?id=192793
697
698         Reviewed by Eric Carlson.
699
700         * MiniBrowser/mac/WK2BrowserWindowController.m:
701         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
702         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
703         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
704         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
705         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
706         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
707         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
708         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
709         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
710         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
711         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
712         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
713         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
714         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
715
716 2019-01-16  Zalan Bujtas  <zalan@apple.com>
717
718         [LFC][BFC] Inflow non-replaced used width should not be negative.
719         https://bugs.webkit.org/show_bug.cgi?id=193495
720
721         Reviewed by Antti Koivisto.
722
723         * LayoutReloaded/misc/LFC-passing-tests.txt:
724
725 2019-01-16  Chris Dumez  <cdumez@apple.com>
726
727         Regression(PSON) View becomes blank after click a cross-site download link
728         https://bugs.webkit.org/show_bug.cgi?id=193361
729         <rdar://problem/47099573>
730
731         Reviewed by Geoffrey Garen.
732
733         Add API test coverage.
734
735         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
736         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
737
738 2019-01-16  Zalan Bujtas  <zalan@apple.com>
739
740         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
741         https://bugs.webkit.org/show_bug.cgi?id=193470
742
743         Reviewed by Antti Koivisto.
744
745         * LayoutReloaded/misc/LFC-passing-tests.txt:
746
747 2019-01-16  Zalan Bujtas  <zalan@apple.com>
748
749         [LFC] Adjust margin box verification.
750         https://bugs.webkit.org/show_bug.cgi?id=193482
751
752         Reviewed by Antti Koivisto.
753
754         * LayoutReloaded/misc/LFC-passing-tests.txt:
755
756 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
757
758         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
759         https://bugs.webkit.org/show_bug.cgi?id=193451
760
761         Reviewed by Geoffrey Garen.
762
763         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
764         (TEST):
765         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
766         (runWebsiteDataStoreCustomPaths):
767
768 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
769
770         webkitpy: Support boolean simctl isAvailable
771         https://bugs.webkit.org/show_bug.cgi?id=193472
772         <rdar://problem/47296150>
773
774         Reviewed by Ryosuke Niwa.
775
776         * Scripts/webkitpy/xcode/simulated_device.py:
777         (SimulatedDeviceManager._create_runtimes):
778         (SimulatedDeviceManager._create_device_with_runtime):
779
780 2019-01-15  Chris Dumez  <cdumez@apple.com>
781
782         Unreviewed, rolling out r239993, r239995, r239997, and
783         r239999.
784
785         Caused assertions under
786         ViewGestureController::disconnectFromProcess()
787
788         Reverted changesets:
789
790         "Regression(PSON) View becomes blank after click a cross-site
791         download link"
792         https://bugs.webkit.org/show_bug.cgi?id=193361
793         https://trac.webkit.org/changeset/239993
794
795         "Unreviewed iOS build fix after r239993."
796         https://trac.webkit.org/changeset/239995
797
798         "Fix iOS build after r239993"
799         https://bugs.webkit.org/show_bug.cgi?id=193361
800         https://trac.webkit.org/changeset/239997
801
802         "Unreviewed, revert part of r239997 as it is not needed to fix
803         the build."
804         https://trac.webkit.org/changeset/239999
805
806 2019-01-15  Tim Horton  <timothy_horton@apple.com>
807
808         Cannot tab out of WKWebView on macOS
809         https://bugs.webkit.org/show_bug.cgi?id=161448
810         <rdar://problem/28100085>
811
812         Reviewed by Dean Jackson.
813
814         Add a test that tabbing into and out of WKWebView works correctly.
815
816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
817         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
818         (WebKit2_CommandBackForwardTest::SetUp):
819         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
820         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
821         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
822         (-[FocusableView canBecomeKeyView]):
823         (TEST):
824         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
825         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
826         (-[OffscreenWindow initWithSize:]):
827         (-[OffscreenWindow isKeyWindow]):
828         (-[OffscreenWindow isVisible]):
829         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
830         (TestWebKitAPI::PlatformWebView::initialize):
831         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
832         (-[ActiveOffscreenWindow isVisible]): Deleted.
833         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
834
835 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
836
837         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
838         https://bugs.webkit.org/show_bug.cgi?id=193459
839
840         Reviewed by Mark Lam.
841
842         * BuildSlaveSupport/build.webkit.org-config/steps.py:
843         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
844
845 2019-01-15  Chris Dumez  <cdumez@apple.com>
846
847         Regression(PSON) View becomes blank after click a cross-site download link
848         https://bugs.webkit.org/show_bug.cgi?id=193361
849         <rdar://problem/47099573>
850
851         Reviewed by Geoff Garen.
852
853         Add API test coverage.
854
855         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
856         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
857
858 2019-01-15  Zalan Bujtas  <zalan@apple.com>
859
860         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
861         https://bugs.webkit.org/show_bug.cgi?id=193448
862
863         Reviewed by Antti Koivisto.
864
865         * LayoutReloaded/misc/LFC-passing-tests.txt:
866
867 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
868
869         webkitpy: Implement device type specific expected results (Part 1)
870         https://bugs.webkit.org/show_bug.cgi?id=192162
871
872         Reviewed by Lucas Forschler.
873
874         Device type specific expected results covers two related ideas. The first (covered by this change)
875         is where to search for -expected.* files. The second is which tests to run based on the
876         TestExpectations.txt file.
877
878         After this change, the baseline search path will be determined by the type of device running a
879         test. Device type will be passed into any function which picks a file based on the baseline search
880         path.
881
882         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
883         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
884         * Scripts/webkitpy/layout_tests/controllers/manager.py:
885         (Manager.run): Print baseline search path for each round of devices.
886         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
887         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
888         (SingleTestRunner._expected_driver_output): Ditto.
889         (SingleTestRunner._driver_input): Ditto.
890         * Scripts/webkitpy/layout_tests/views/printing.py:
891         (Printer.print_config): Move printing of baseline search path to a separate function.
892         (Printer.print_baseline_search_path): Moved from Printer.print_config.
893         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
894         (Testprinter.test_print_config):
895         (Testprinter.test_print_baseline_search_path):
896         * Scripts/webkitpy/port/base.py:
897         (Port.baseline_search_path): Pass device_type through.
898         (Port._expected_baselines_for_suffixes): Ditto.
899         (Port.expected_baselines): Ditto.
900         (Port.expected_filename): Ditto.
901         (Port.expected_checksum): Ditto.
902         (Port.expected_image): Ditto.
903         (Port.expected_audio): Ditto.
904         (Port.expected_text): Ditto.
905         (Port.reference_files): Ditto.
906         (Port.tests): Ditto.
907         (Port._expanded_paths): Ditto.
908         (Port.skipped_layout_tests): Ditto.
909         (Port.expectations_dict): Ditto.
910         (Port._port_specific_expectations_files): Ditto.
911         (Port.expectations_files): Ditto.
912         (Port.test_search_path): Ditto.
913         (Port._tests_for_other_platforms): Ditto.
914         * Scripts/webkitpy/port/base_unittest.py:
915         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
916         (PortTest.test_nonexistant_expectations): Ditto.
917         (test_ref_tests_platform_directory): Ditto.
918         * Scripts/webkitpy/port/darwin.py:
919         (DarwinPort._port_specific_expectations_files): Accept device_type.
920         * Scripts/webkitpy/port/driver.py:
921         (DriverProxy):
922         (DriverProxy.host): Expose _target_host for device_type information.
923         * Scripts/webkitpy/port/gtk.py:
924         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
925         * Scripts/webkitpy/port/ios.py:
926         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
927         * Scripts/webkitpy/port/mac.py:
928         (MacPort. default_baseline_search_path): Ditto.
929         * Scripts/webkitpy/port/port_testcase.py:
930         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
931         * Scripts/webkitpy/port/test.py:
932         * Scripts/webkitpy/port/watch.py:
933         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
934         * Scripts/webkitpy/port/win.py:
935         (WinPort.test_search_path): Accept, but do not use, device_type.
936         * Scripts/webkitpy/port/wpe.py:
937         (WPEPort._port_specific_expectations_files): Ditto.
938         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
939         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
940
941 2019-01-15  Zalan Bujtas  <zalan@apple.com>
942
943         [LFC] Use the containing block's padding box to position out-of-flow elements.
944         https://bugs.webkit.org/show_bug.cgi?id=193431
945
946         Reviewed by Antti Koivisto.
947
948         * LayoutReloaded/misc/LFC-passing-tests.txt:
949
950 2019-01-14  Tim Horton  <timothy_horton@apple.com>
951
952         Move a test implementation file that got misplaced in the Xcode project
953
954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
955
956 2019-01-14  Commit Queue  <commit-queue@webkit.org>
957
958         Unreviewed, rolling out r239901, r239909, r239910, r239912,
959         r239913, and r239914.
960         https://bugs.webkit.org/show_bug.cgi?id=193407
961
962         These revisions caused an internal failure (Requested by
963         Truitt on #webkit).
964
965         Reverted changesets:
966
967         "[Cocoa] Avoid importing directly from subumbrella frameworks"
968         https://bugs.webkit.org/show_bug.cgi?id=186016
969         https://trac.webkit.org/changeset/239901
970
971         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
972         https://trac.webkit.org/changeset/239909
973
974         "Tried to fix the build."
975         https://trac.webkit.org/changeset/239910
976
977         "Fixed iOS builds after r239910."
978         https://trac.webkit.org/changeset/239912
979
980         "More build fixing."
981         https://trac.webkit.org/changeset/239913
982
983         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
984         https://trac.webkit.org/changeset/239914
985
986 2019-01-14  Mark Lam  <mark.lam@apple.com>
987
988         Re-enable ability to build --cloop builds.
989         https://bugs.webkit.org/show_bug.cgi?id=192955
990         <rdar://problem/46882363>
991
992         Reviewed by Saam barati and Keith Miller.
993
994         The --cloop build option was being ignored this whole time since r236381.
995         This patch makes it possible to build CLoop builds again.
996
997         * Scripts/build-jsc:
998         * Scripts/webkitperl/FeatureList.pm:
999         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1000
1001 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1002
1003         webkitpy: Expose device_type from host-like objects
1004         https://bugs.webkit.org/show_bug.cgi?id=193406
1005         <rdar://problem/47262305>
1006
1007         Reviewed by Lucas Forschler.
1008
1009         Devices should expose device_type. As a result, all host objects should
1010         provide a device_type property, even if they do not yet define a device_type.
1011
1012         * Scripts/webkitpy/common/system/systemhost.py:
1013         (SystemHost):
1014         (SystemHost.device_type):
1015         * Scripts/webkitpy/common/system/systemhost_mock.py:
1016         (MockSystemHost):
1017         (MockSystemHost.device_type):
1018         * Scripts/webkitpy/port/device.py:
1019         (Device):
1020         (Device.device_type):
1021         * Scripts/webkitpy/xcode/simulated_device.py:
1022         (SimulatedDeviceManager._find_exisiting_device_for_request):
1023         (SimulatedDeviceManager._disambiguate_device_type):
1024         (SimulatedDeviceManager._does_fulfill_request):
1025         (SimulatedDeviceManager.device_count_for_type):
1026         (SimulatedDeviceManager.initialize_devices):
1027         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1028         (test_available_devices):
1029         (test_swapping_devices):
1030
1031 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1032
1033         webkitpy: Support alternate simctl device list output (Follow-up fix)
1034         https://bugs.webkit.org/show_bug.cgi?id=193362
1035         <rdar://problem/47122965>
1036
1037         Rubber-stamped by Lucas Forschler.
1038
1039         * Scripts/webkitpy/xcode/simulated_device.py:
1040         (SimulatedDeviceManager.populate_available_devices):
1041
1042 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1043
1044         [iOS] Expose SPI to access the current sentence boundary and selection state
1045         https://bugs.webkit.org/show_bug.cgi?id=193398
1046         <rdar://problem/45893108>
1047
1048         Reviewed by Dean Jackson.
1049
1050         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
1051         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
1052         expected.
1053
1054         * TestWebKitAPI/EditingTestHarness.h:
1055         * TestWebKitAPI/EditingTestHarness.mm:
1056         (-[EditingTestHarness moveBackward]):
1057         (-[EditingTestHarness moveForward]):
1058         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
1059
1060         Add a couple of new helper methods on EditingTestHarness.
1061
1062         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1063         (-[SelectionChangeObserver initWithWebView:]):
1064         (-[SelectionChangeObserver webView]):
1065         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
1066         (-[SelectionChangeObserver currentSelectionAttributes]):
1067
1068 2019-01-14  Zalan Bujtas  <zalan@apple.com>
1069
1070         [LFC][BFC] Add basic box-sizing support.
1071         https://bugs.webkit.org/show_bug.cgi?id=193392
1072
1073         Reviewed by Antti Koivisto.
1074
1075         * LayoutReloaded/misc/LFC-passing-tests.txt:
1076
1077 2019-01-14  Charlie Turner  <cturner@igalia.com>
1078
1079         [WPE] API test gardening
1080         https://bugs.webkit.org/show_bug.cgi?id=193319
1081
1082         Reviewed by Michael Catanzaro.
1083
1084         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
1085         passing tests.
1086
1087 2019-01-14  Charlie Turner  <cturner@igalia.com>
1088
1089         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
1090         https://bugs.webkit.org/show_bug.cgi?id=192977
1091
1092         Reviewed by Carlos Garcia Campos.
1093
1094         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
1095         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1096         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
1097         (TestWebKitAPI::GStreamerTest::SetUp):
1098         (TestWebKitAPI::GStreamerTest::TearDown):
1099         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
1100         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
1101         (TestWebKitAPI::TEST_F):
1102
1103 2019-01-14  Charlie Turner  <cturner@igalia.com>
1104
1105         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
1106         https://bugs.webkit.org/show_bug.cgi?id=193332
1107
1108         Reviewed by Michael Catanzaro.
1109
1110         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
1111         defined as a char16_t, which changed in ICU 59, the
1112         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
1113         unsigned short. This test is relying on the behaviour that
1114         UChar=unsigned short, which doesn't hold across platforms and ICU
1115         library versions. The full fix would be a special syntax for
1116         literal characters so that these ambiguities do not arise. That
1117         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
1118         (TestWebKitAPI::TEST):
1119
1120 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1121
1122         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
1123
1124         * Scripts/make-dist:
1125         (Distcheck.configure):
1126
1127 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
1128
1129         [ews-build] Update macOS queue configurations
1130         https://bugs.webkit.org/show_bug.cgi?id=193365
1131         <rdar://problem/47221073>
1132
1133         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
1134
1135         * BuildSlaveSupport/ews-build/config.json:
1136
1137 2019-01-13  Zalan Bujtas  <zalan@apple.com>
1138
1139         [LFC] Adjust assert for statically positioned fixed elements
1140         https://bugs.webkit.org/show_bug.cgi?id=193385
1141
1142         Reviewed by Antti Koivisto.
1143
1144         * LayoutReloaded/misc/LFC-passing-tests.txt:
1145
1146 2019-01-13  Philippe Normand  <pnormand@igalia.com>
1147
1148         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
1149         https://bugs.webkit.org/show_bug.cgi?id=193387
1150
1151         Reviewed by Carlos Garcia Campos.
1152
1153         * MiniBrowser/wpe/main.cpp:
1154         (main):
1155
1156 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1157
1158         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1159         https://bugs.webkit.org/show_bug.cgi?id=191655
1160         rdar://problem/46074680
1161
1162         Reviewed by Megan Gardner.
1163
1164         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1165         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1166
1167 2019-01-12  Dan Bernstein  <mitz@apple.com>
1168
1169         [Cocoa] Avoid importing directly from subumbrella frameworks
1170         https://bugs.webkit.org/show_bug.cgi?id=186016
1171         <rdar://problem/40591038>
1172
1173         Reviewed by Sam Weinig.
1174
1175         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1176           LaunchServices header.
1177         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1178           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1179         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1180           when using SDKs earlier than 10.13.
1181         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1182           and OTHER_CPLUSPLUSFLAGS.
1183         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1184           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1185         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1186           LaunchServices header.
1187
1188 2019-01-11  John Wilander  <wilander@apple.com>
1189
1190         Compile out Web API Statistics Collection
1191         https://bugs.webkit.org/show_bug.cgi?id=193370
1192         <rdar://problem/45388584>
1193
1194         Reviewed by Brent Fulgham.
1195
1196         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1197             Defined ENABLE_WEB_API_STATISTICS, off by default.
1198
1199 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1200
1201         [WPE] Add gtk-doc
1202         https://bugs.webkit.org/show_bug.cgi?id=178900
1203
1204         Reviewed by Michael Catanzaro.
1205
1206         Add Tools/gtkdoc to manifest.txt.in files.
1207         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
1208
1209         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
1210         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
1211
1212 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1213
1214         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
1215         https://bugs.webkit.org/show_bug.cgi?id=193364
1216         <rdar://problem/47214117>
1217
1218         Reviewed by Tim Horton.
1219
1220         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
1221         precise, whereas dragging near the middle of the textarea does.
1222
1223         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1224         (TestWebKitAPI::TEST):
1225
1226 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1227
1228         webkitpy: Support alternate simctl device list output
1229         https://bugs.webkit.org/show_bug.cgi?id=193362
1230         <rdar://problem/47122965>
1231
1232         Reviewed by Lucas Forschler.
1233
1234         * Scripts/webkitpy/xcode/simulated_device.py:
1235         (SimulatedDeviceManager.populate_available_devices):
1236
1237 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
1238
1239         [ews-build] Update macOS queue configurations
1240         https://bugs.webkit.org/show_bug.cgi?id=193365
1241
1242         Reviewed by Lucas Forschler.
1243
1244         * BuildSlaveSupport/ews-build/config.json:
1245
1246 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1247
1248         webkitpy: Incorporate device type into baseline search path
1249         https://bugs.webkit.org/show_bug.cgi?id=193356
1250         <rdar://problem/47215515>
1251
1252         Reviewed by Lucas Forschler.
1253
1254         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
1255
1256         * Scripts/webkitpy/port/base.py:
1257         (Port.default_baseline_search_path): Allow device type to be passed in.
1258         * Scripts/webkitpy/port/gtk.py:
1259         (GtkPort.default_baseline_search_path): Ignore device type.
1260         * Scripts/webkitpy/port/ios.py:
1261         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
1262         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
1263         * Scripts/webkitpy/port/ios_device_unittest.py:
1264         (IOSDeviceTest):
1265         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1266         (IOSSimulatorTest):
1267         * Scripts/webkitpy/port/mac.py:
1268         (MacPort.default_baseline_search_path): Ignore device type.
1269         * Scripts/webkitpy/port/watch.py:
1270         (WatchPort.default_baseline_search_path): Ditto.
1271         * Scripts/webkitpy/port/win.py:
1272         (WinPort.default_baseline_search_path): Ditto.
1273         (WinCairoPort.default_baseline_search_path): Ditto.
1274         * Scripts/webkitpy/port/wpe.py:
1275         (WPEPort.default_baseline_search_path): Ditto.
1276
1277 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1278
1279         webkitpy: Print abbreviated baseline search path that includes only folders that exist
1280         https://bugs.webkit.org/show_bug.cgi?id=193352
1281         <rdar://problem/47210736>
1282
1283         Reviewed by Lucas Forschler.
1284
1285         * Scripts/webkitpy/layout_tests/views/printing.py:
1286         (Printer.print_config): Print list on only baseline search paths which exist. 
1287         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1288         (Testprinter.test_print_config):
1289
1290 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
1291
1292         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
1293         https://bugs.webkit.org/show_bug.cgi?id=193340
1294
1295         Reviewed by David Kilzer.
1296
1297         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1298         (WTR::InjectedBundle::didReceiveMessageToPage):
1299         Pull the strings out into a WKRetainPtr.
1300
1301         * WebKitTestRunner/WebNotificationProvider.cpp:
1302         (WTR::WebNotificationProvider::closeWebNotification):
1303         Adopt the created value into the WKRetainPtr.
1304
1305         * WebKitTestRunner/mac/TestControllerMac.mm:
1306         (WTR::generateWhitelist):
1307         Immediately adopt a created value to avoid potential mistakes.
1308
1309 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
1310
1311         Enable DFG on ARM/Linux again
1312         https://bugs.webkit.org/show_bug.cgi?id=192496
1313
1314         Reviewed by Yusuke Suzuki.
1315
1316         After changing the bytecode format DFG was disabled on all 32-bit
1317         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1318         on ARM by default.
1319
1320         * Scripts/run-jsc-stress-tests:
1321
1322 2019-01-11  Timothy Hatcher  <timothy@apple.com>
1323
1324         Unreviewed, fix #ifdef in API test added in r239851.
1325         https://bugs.webkit.org/show_bug.cgi?id=193327
1326         rdar://problem/47093222
1327
1328         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1329
1330 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1331
1332         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
1333         https://bugs.webkit.org/show_bug.cgi?id=193109
1334         <rdar://problem/44807048>
1335
1336         Reviewed by Ryosuke Niwa.
1337
1338         Introduce and respect a test option to enable the UndoManager API.
1339
1340         * WebKitTestRunner/TestController.cpp:
1341         (WTR::updateTestOptionsFromTestHeader):
1342         * WebKitTestRunner/TestOptions.h:
1343         (WTR::TestOptions::hasSameInitializationOptions const):
1344         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1345         (WTR::TestController::platformCreateWebView):
1346
1347 2019-01-11  Zalan Bujtas  <zalan@apple.com>
1348
1349         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
1350         https://bugs.webkit.org/show_bug.cgi?id=193346
1351
1352         Reviewed by Antti Koivisto.
1353
1354         * LayoutReloaded/misc/LFC-passing-tests.txt:
1355
1356 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1357
1358         Unreviewed, fix typo that breaks dashboard link.
1359
1360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1361         (WebKitBuildbot):
1362
1363 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1364
1365         Update macOS queue configurations
1366         https://bugs.webkit.org/show_bug.cgi?id=193329
1367
1368         Reviewed by Alexey Proskuryakov.
1369
1370         * BuildSlaveSupport/build.webkit.org-config/config.json:
1371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1372         (BubbleQueueServer):
1373         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1374         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1375         (WebKitBuildbot):
1376         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1377         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
1378         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1379
1380 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1381
1382         MiniBrowser should be able to navigate to about:blank
1383         https://bugs.webkit.org/show_bug.cgi?id=193345
1384
1385         Reviewed by Simon Fraser.
1386
1387         * MiniBrowser/mac/BrowserWindowController.m:
1388         (-[BrowserWindowController addProtocolIfNecessary:]):
1389         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
1390
1391         * MiniBrowser/mac/WK1BrowserWindowController.m:
1392         (-[WK1BrowserWindowController fetch:]):
1393         * MiniBrowser/mac/WK2BrowserWindowController.m:
1394         (-[WK2BrowserWindowController fetch:]):
1395         Clean up the code that uses this to match style.
1396
1397 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1398
1399         Remove MiniBrowser custom "Process Swap" menu item which does not work
1400         https://bugs.webkit.org/show_bug.cgi?id=193344
1401
1402         Reviewed by Simon Fraser.
1403
1404         There is a menu item under the Experimental menu that does work.
1405
1406         * MiniBrowser/mac/AppDelegate.m:
1407         (defaultConfiguration):
1408         * MiniBrowser/mac/SettingsController.h:
1409         * MiniBrowser/mac/SettingsController.m:
1410         (-[SettingsController _populateMenu]):
1411         (-[SettingsController validateMenuItem:]):
1412         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
1413         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
1414
1415 2019-01-10  Timothy Hatcher  <timothy@apple.com>
1416
1417         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
1418         https://bugs.webkit.org/show_bug.cgi?id=193327
1419         rdar://problem/47093222
1420
1421         Reviewed by Tim Horton.
1422
1423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1424         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
1425         (TestWebKitAPI::didFinishNavigation):
1426         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1427         (TestWebKitAPI::TEST):
1428         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
1429         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
1430         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
1431         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
1432         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
1433
1434 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1435
1436         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
1437         https://bugs.webkit.org/show_bug.cgi?id=193338
1438         <rdar://problem/46664774>
1439
1440         Reviewed by David Kilzer.
1441
1442         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1443         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1444
1445 2019-01-10  Commit Queue  <commit-queue@webkit.org>
1446
1447         Unreviewed, rolling out r239825.
1448         https://bugs.webkit.org/show_bug.cgi?id=193330
1449
1450         Broke tests on armv7/linux bots (Requested by guijemont on
1451         #webkit).
1452
1453         Reverted changeset:
1454
1455         "Enable DFG on ARM/Linux again"
1456         https://bugs.webkit.org/show_bug.cgi?id=192496
1457         https://trac.webkit.org/changeset/239825
1458
1459 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
1460
1461         Disable the run-jsc-stress-test remote host key check.
1462         https://bugs.webkit.org/show_bug.cgi?id=192988
1463
1464         Reviewed by Alexey Proskuryakov.
1465
1466         * Scripts/run-jsc-stress-tests:
1467
1468 2019-01-10  John Wilander  <wilander@apple.com>
1469
1470         Override the session configuration for cookieAcceptPolicy
1471         https://bugs.webkit.org/show_bug.cgi?id=190925
1472         <rdar://problem/45497382>
1473
1474         Reviewed by Alexey Proskuryakov and Alex Christensen.
1475
1476         Test infrastructure for setting a first-party-only cookie policy.
1477
1478         * DumpRenderTree/TestRunner.cpp:
1479         (setOnlyAcceptFirstPartyCookiesCallback):
1480         (TestRunner::staticFunctions):
1481         * DumpRenderTree/TestRunner.h:
1482         * DumpRenderTree/mac/TestRunnerMac.mm:
1483         (TestRunner::setOnlyAcceptFirstPartyCookies):
1484         * DumpRenderTree/win/TestRunnerWin.cpp:
1485         (TestRunner::setOnlyAcceptFirstPartyCookies):
1486         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1487         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1488         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1489         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1490         * WebKitTestRunner/TestInvocation.cpp:
1491         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1492
1493 2019-01-09  Matt Rajca  <mrajca@apple.com>
1494
1495         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
1496         https://bugs.webkit.org/show_bug.cgi?id=193301
1497
1498         Reviewed by Jer Noble.
1499         
1500         Added API tests.
1501
1502         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1503         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1504         (TEST):
1505         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
1506
1507 2019-01-10  Zalan Bujtas  <zalan@apple.com>
1508
1509         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
1510         https://bugs.webkit.org/show_bug.cgi?id=193310
1511
1512         Reviewed by Antti Koivisto.
1513
1514         * LayoutReloaded/misc/LFC-passing-tests.txt:
1515
1516 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
1517
1518         Enable DFG on ARM/Linux again
1519         https://bugs.webkit.org/show_bug.cgi?id=192496
1520
1521         Reviewed by Yusuke Suzuki.
1522
1523         After changing the bytecode format DFG was disabled on all 32-bit
1524         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1525         on ARM by default.
1526
1527         * Scripts/run-jsc-stress-tests:
1528
1529 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1530
1531         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
1532         https://bugs.webkit.org/show_bug.cgi?id=193271
1533
1534         Reviewed by Brent Fulgham.
1535
1536         BSTR is a special data structure created by SysAllocString, not a
1537         wchar_t null-terminated string.
1538
1539         * DumpRenderTree/win/TestRunnerWin.cpp:
1540         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
1541         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1542         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
1543         BSTR from wide string literals.
1544
1545 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
1546
1547         Tweak wording for build/version_check style checker error
1548         https://bugs.webkit.org/show_bug.cgi?id=193256
1549
1550         Reviewed by Tim Horton.
1551
1552         * Scripts/webkitpy/style/checkers/cpp.py:
1553         (check_os_version_checks):
1554         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1555         (WebKitStyleTest.test_os_version_checks):
1556
1557 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1558
1559         [ews-build] Add link to bug along with bug title
1560         https://bugs.webkit.org/show_bug.cgi?id=193293
1561
1562         Reviewed by Lucas Forschler.
1563
1564         * BuildSlaveSupport/ews-build/steps.py:
1565         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
1566         (ConfigureBuild.add_bug_id_url): Deleted.
1567         (ConfigureBuild.getBugURL): Deleted.
1568
1569 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1570
1571         [ews-build] Use https for ews-build server
1572         https://bugs.webkit.org/show_bug.cgi?id=193193
1573
1574         Reviewed by Lucas Forschler.
1575
1576         * BuildSlaveSupport/ews-build/steps.py:
1577
1578 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1579
1580         [ews-build] Parse and display number of style failures
1581         https://bugs.webkit.org/show_bug.cgi?id=193280
1582
1583         Reviewed by Lucas Forschler.
1584
1585         * BuildSlaveSupport/ews-build/steps.py:
1586         (CheckStyle): Use TestWithFailureCount as base class.
1587         (CheckStyle.countFailures): Count the number of style failures.
1588
1589 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1590
1591         [ews-build] use patch_id instead of ewspatchid
1592         https://bugs.webkit.org/show_bug.cgi?id=193235
1593
1594         Reviewed by Lucas Forschler.
1595
1596         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
1597         * BuildSlaveSupport/ews-build/steps.py: Ditto.
1598         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
1599
1600 2019-01-09  Zalan Bujtas  <zalan@apple.com>
1601
1602         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
1603         https://bugs.webkit.org/show_bug.cgi?id=192625
1604
1605         Reviewed by Antti Koivisto.
1606
1607         * LayoutReloaded/misc/LFC-passing-tests.txt:
1608
1609 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1610
1611         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
1612         https://bugs.webkit.org/show_bug.cgi?id=192841
1613
1614         Reviewed by Carlos Garcia Campos.
1615
1616         There are separate g_assert_*() macros for use in tests, which we use inconsistently
1617         currently. Use them always. We'll get nicer error messages now when tests fail, and the
1618         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
1619
1620         Note that the documentation of g_assert() says that it is not to be used when writing tests.
1621
1622         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1623         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
1624         (WebKitWebEditorTest::testSelectionChanged):
1625         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1626         (WebKitFrameTest::testMainFrame):
1627         (WebKitFrameTest::testURI):
1628         (WebKitFrameTest::testJavaScriptContext):
1629         (WebKitFrameTest::testJavaScriptValues):
1630         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1631         (testWebViewAuthenticationRequest):
1632         (testWebViewAuthenticationLoadCancelled):
1633         (testWebViewAuthenticationFailure):
1634         (testWebViewAuthenticationStorage):
1635         (ProxyAuthenticationTest::ProxyAuthenticationTest):
1636         (testWebViewAuthenticationProxy):
1637         (testWebViewAuthenticationProxyHTTPS):
1638         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1639         (testAutomationSessionRequestSession):
1640         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
1641         (testBackForwardListNavigation):
1642         (testWebKitWebViewSessionState):
1643         (testWebKitWebViewSessionStateWithFormData):
1644         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1645         (ConsoleMessageTest::consoleMessageReceivedCallback):
1646         (testWebKitConsoleMessageConsoleAPI):
1647         (testWebKitConsoleMessageJavaScriptException):
1648         (testWebKitConsoleMessageNetworkError):
1649         (testWebKitConsoleMessageSecurityError):
1650         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1651         (testCookieManagerAcceptPolicy):
1652         (testCookieManagerCookiesChanged):
1653         (testCookieManagerPersistentStorage):
1654         (testCookieManagerPersistentStorageDeleteAll):
1655         (testCookieManagerEphemeral):
1656         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
1657         (testWebKitDOMElementAutoFill):
1658         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1659         (downloadLocalFileSuccessfully):
1660         (createFileAtDestination):
1661         (testDownloadOverwriteDestinationDisallowed):
1662         (testDownloadLocalFileError):
1663         (testDownloadRemoteFile):
1664         (testDownloadRemoteFileError):
1665         (testWebViewDownloadURI):
1666         (testPolicyResponseDownload):
1667         (testPolicyResponseDownloadCancel):
1668         (testDownloadMIMEType):
1669         (contextMenuCallback):
1670         (testContextMenuDownloadActions):
1671         (testBlobDownload):
1672         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
1673         (testWebKitWebEditorSelectionChanged):
1674         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1675         (testWebKitFrameMainFrame):
1676         (testWebKitFrameURI):
1677         (testWebKitFrameJavaScriptContext):
1678         (testWebKitFrameJavaScriptValues):
1679         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1680         (LoadStopTrackingTest::loadFailed):
1681         (testWebViewTitle):
1682         (testURIRequestHTTPHeaders):
1683         (testURIRequestHTTPMethod):
1684         (testURIResponseHTTPHeaders):
1685         (testRedirectToDataURI):
1686         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1687         (testProcessPerWebView):
1688         (testWebProcessLimit):
1689         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1690         (testWebViewResources):
1691         (testWebResourceLoading):
1692         (testWebResourceSuggestedFilename):
1693         (testWebResourceGetData):
1694         (testWebResourceGetDataError):
1695         (testWebViewResourcesHistoryCache):
1696         (testWebResourceSendRequest):
1697         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1698         (testSSL):
1699         (testInsecureContent):
1700         (testTLSErrorsPolicy):
1701         (testTLSErrorsRedirect):
1702         (testTLSErrorsHTTPAuth):
1703         (testLoadFailedWithTLSErrors):
1704         (testSubresourceLoadFailedWithTLSErrors):
1705         (httpsServerCallback):
1706         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1707         (testWebViewCreateNavigationData):
1708         (testWebViewJavaScriptDialogs):
1709         (testWebViewWindowProperties):
1710         (testWebViewMouseTarget):
1711         (testWebViewFileChooserRequest):
1712         (testWebViewColorChooserRequest):
1713         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1714         (testWebExtensionGetTitle):
1715         (testDocumentLoadedSignal):
1716         (testWebKitWebViewProcessCrashed):
1717         (testWebExtensionWindowObjectCleared):
1718         (testWebExtensionIsolatedWorld):
1719         (permissionRequestCallback):
1720         (didAssociateFormControlsCallback):
1721         (testWebExtensionFormControlsAssociated):
1722         (FormSubmissionTest::FormSubmissionTest):
1723         (FormSubmissionTest::testFormSubmissionResult):
1724         (testWebExtensionFormSubmissionSteps):
1725         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1726         (testNotInitialized):
1727         (testClearDatabase):
1728         (testPrivateBrowsing):
1729         (testGetFavicon):
1730         (testWebViewFavicon):
1731         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
1732         (testFindControllerTextFound):
1733         (testFindControllerTextNotFound):
1734         (testFindControllerMatchCount):
1735         (testFindControllerMaxMatchCount):
1736         (testFindControllerNext):
1737         (testFindControllerPrevious):
1738         (testFindControllerCountedMatches):
1739         (testFindControllerOptions):
1740         (testFindControllerHide):
1741         (testFindControllerInstance):
1742         (testFindControllerGetters):
1743         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
1744         (testNavigationPolicy):
1745         (testResponsePolicy):
1746         (testNewWindowPolicy):
1747         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
1748         (testSecurityOriginBasicConstructor):
1749         (testSecurityOriginURIConstructor):
1750         (testSecurityOriginDefaultPort):
1751         (testSecurityOriginFileURI):
1752         (testOpaqueSecurityOrigin):
1753         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1754         (testWebKitSettings):
1755         (testWebKitSettingsNewWithSettings):
1756         (testWebKitSettingsUserAgent):
1757         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1758         (testWebViewNewWithUserContentManager):
1759         (isStyleSheetInjectedForURLAtPath):
1760         (isScriptInjectedForURLAtPath):
1761         (testUserContentManagerInjectedStyleSheet):
1762         (testUserContentManagerInjectedScript):
1763         (UserScriptMessageTest::scriptMessageReceived):
1764         (UserScriptMessageTest::waitUntilMessageReceived):
1765         (UserScriptMessageTest::runJavaScriptFinished):
1766         (testUserContentManagerScriptMessageReceived):
1767         (testUserContentManagerScriptMessageInWorldReceived):
1768         (testUserContentManagerScriptMessageFromDOMBindings):
1769         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1770         (testWebContextDefault):
1771         (testWebContextEphemeral):
1772         (testWebContextGetPlugins):
1773         (testWebContextURIScheme):
1774         (testWebContextSpellChecker):
1775         (testWebContextLanguages):
1776         (consoleMessageReceivedCallback):
1777         (testWebContextSecurityFileXHR):
1778         (ProxyTest::ProxyTest):
1779         (testWebContextProxySettings):
1780         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1781         (testWebViewWebContext):
1782         (testWebViewWebBackend):
1783         (testWebViewEphemeral):
1784         (testWebViewCustomCharset):
1785         (testWebViewSettings):
1786         (testWebViewRunJavaScript):
1787         (testWebViewCanShowMIMEType):
1788         (testWebViewSubmitForm):
1789         (testWebViewSave):
1790         (testWebViewPageVisibility):
1791         (testWebViewSnapshot):
1792         (testWebViewNotification):
1793         (testWebViewNotificationInitialPermissionAllowed):
1794         (testWebViewNotificationInitialPermissionDisallowed):
1795         (testWebViewIsPlayingAudio):
1796         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1797         (WebsiteDataTest::WebsiteDataTest):
1798         (WebsiteDataTest::remove):
1799         (WebsiteDataTest::clear):
1800         (testWebsiteDataConfiguration):
1801         (testWebsiteDataEphemeral):
1802         (testWebsiteDataCache):
1803         (testWebsiteDataStorage):
1804         (testWebsiteDataDatabases):
1805         (testWebsiteDataAppcache):
1806         (testWebsiteDataCookies):
1807         (testWebsiteDataDeviceIdHashSalt):
1808         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1809         (emitDocumentLoaded):
1810         (emitURIChanged):
1811         (sendRequestCallback):
1812         (contextMenuCallback):
1813         (consoleMessageSentCallback):
1814         (emitFormControlsAssociated):
1815         (formControlsAssociatedCallback):
1816         (emitFormSubmissionEvent):
1817         (willSubmitFormCallback):
1818         (windowObjectCleared):
1819         (methodCallCallback):
1820         (registerGResource):
1821         (webkit_web_extension_initialize_with_user_data):
1822         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
1823         (checkLeaks):
1824         (WebProcessTest::create):
1825         (runTest):
1826         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
1827         (AutocleanupsTest::testWebProcessAutocleanups):
1828         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
1829         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
1830         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
1831         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
1832         (WebKitDOMDOMWindowTest::testSignals):
1833         (WebKitDOMDOMWindowTest::testDispatchEvent):
1834         (WebKitDOMDOMWindowTest::testGetComputedStyle):
1835         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
1836         (WebKitDOMNodeFilterTest::testTreeWalker):
1837         (WebKitDOMNodeFilterTest::testNodeIterator):
1838         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
1839         (WebKitDOMNodeTest::testHierarchyNavigation):
1840         (WebKitDOMNodeTest::testInsertion):
1841         (WebKitDOMNodeTest::testTagNamesNodeList):
1842         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1843         (WebKitDOMNodeTest::testDOMCache):
1844         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
1845         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
1846         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1847         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1848         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
1849         (testUIProcessAutocleanups):
1850         (testWebProcessAutocleanups):
1851         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1852         (testContextMenuPopulateMenu):
1853         (testContextMenuDismissed):
1854         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
1855         (testWebKitDOMClientRectDivBoundingClientRectPosition):
1856         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
1857         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
1858         (testWebKitDOMDOMWindowSignals):
1859         (testWebKitDOMDOMWindowDispatchEvent):
1860         (testWebKitDOMDOMWindowGetComputedStyle):
1861         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
1862         (testWebKitDOMNodeHierarchyNavigation):
1863         (testWebKitDOMNodeInsertion):
1864         (testWebKitDOMNodeTagNamesNodeList):
1865         (testWebKitDOMNodeTagNamesHTMLCollection):
1866         (testWebKitDOMObjectCache):
1867         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
1868         (testWebKitDOMNodeFilterTreeWalker):
1869         (testWebKitDOMNodeFilterNodeIterator):
1870         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
1871         (testWebKitDOMXPathNSResolverNative):
1872         (testWebKitDOMXPathNSResolverCustom):
1873         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
1874         (testInspectorDefault):
1875         (testInspectorManualAttachDetach):
1876         (testInspectorCustomContainerDestroyed):
1877         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
1878         (startTestServer):
1879         (testInspectorServerPageList):
1880         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
1881         (OptionMenuTest::showOptionMenuCallback):
1882         (OptionMenuTest::menuCloseCallback):
1883         (OptionMenuTest::close):
1884         (OptionMenuTest::activateItem):
1885         (OptionMenuTest::selectItem):
1886         (testOptionMenuSimple):
1887         (testOptionMenuGroups):
1888         (testOptionMenuActivate):
1889         (testOptionMenuSelect):
1890         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
1891         (testPrintOperationPrintSettings):
1892         (webViewPrintCallback):
1893         (testPrintOperationPrint):
1894         (testPrintCustomWidget):
1895         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1896         (checkAtspiAccessible):
1897         (testAtspiBasicHierarchy):
1898         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
1899         (testWebKitCheckVersion):
1900         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
1901         (testWebViewEditorCutCopyPasteNonEditable):
1902         (testWebViewEditorCutCopyPasteEditable):
1903         (testWebViewEditorSelectAllNonEditable):
1904         (testWebViewEditorSelectAllEditable):
1905         (loadContentsAndTryToCutSelection):
1906         (testWebViewEditorNonEditable):
1907         (testWebViewEditorEditable):
1908         (testWebViewEditorEditorStateTypingAttributes):
1909         (testWebViewEditorInsertImage):
1910         (testWebViewEditorCreateLink):
1911         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1912         (loadChangedCallback):
1913         (loadFailedCallback):
1914         (loadFailedWithTLSErrorsCallback):
1915         (LoadTrackingTest::LoadTrackingTest):
1916         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1917         (registerGResource):
1918         (removeNonEmptyDirectory):
1919         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1920         (Test::adoptView):
1921         (Test::~Test):
1922         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1923         (WebKitTestBus::getOrCreateConnection):
1924         (WebKitTestBus::createProxy):
1925         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
1926         (WebKitTestServer::getWebSocketURIForPath const):
1927         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1928         (WebViewTest::initializeWebView):
1929         (WebViewTest::loadURI):
1930         (WebViewTest::loadHtml):
1931         (WebViewTest::loadPlainText):
1932         (WebViewTest::loadBytes):
1933         (WebViewTest::loadRequest):
1934         (WebViewTest::loadAlternateHTML):
1935         (WebViewTest::goBack):
1936         (WebViewTest::goForward):
1937         (WebViewTest::goToBackForwardListItem):
1938         (resourceGetDataCallback):
1939         (WebViewTest::mainResourceData):
1940         (WebViewTest::javascriptResultToCString):
1941         (WebViewTest::javascriptResultToNumber):
1942         (WebViewTest::javascriptResultToBoolean):
1943         (WebViewTest::javascriptResultIsNull):
1944         (WebViewTest::javascriptResultIsUndefined):
1945         (onSnapshotReady):
1946         (WebViewTest::runWebProcessTest):
1947         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
1948         (WebViewTest::platformInitializeWebView):
1949         (WebViewTest::showInWindow):
1950         (WebViewTest::showInWindowAndWaitUntilMapped):
1951         (WebViewTest::mouseMoveTo):
1952         (WebViewTest::emitPopupMenuSignal):
1953         (WebViewTest::keyStroke):
1954         (WebViewTest::doMouseButtonEvent):
1955
1956 2019-01-09  Philippe Normand  <pnormand@igalia.com>
1957
1958         [WPE] API tests can't run in flatpak environment
1959         https://bugs.webkit.org/show_bug.cgi?id=193242
1960
1961         Reviewed by Michael Catanzaro.
1962
1963         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
1964         flatpakutils so that it knows which port it's dealing with.
1965         * glib/common.py: Remove build_dir globals so that subsequent
1966         calls actually take args into account.
1967         (library_build_path):
1968         (binary_build_path):
1969
1970 2019-01-08  Dean Jackson  <dino@apple.com>
1971
1972         Blob references for System Previews don't get a correct file extension
1973         https://bugs.webkit.org/show_bug.cgi?id=193268
1974         <rdar://problem/47133037>
1975
1976         Reviewed by Tim Horton.
1977
1978         New test that a Blob download of a USDZ file gets named correctly.
1979
1980         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1981         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1982         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1983         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
1984         (TEST):
1985         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
1986
1987 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
1988
1989         [WebAuthN] Support U2F HID Authenticators on macOS
1990         https://bugs.webkit.org/show_bug.cgi?id=191535
1991         <rdar://problem/47102027>
1992
1993         Reviewed by Brent Fulgham.
1994
1995         This patch:
1996         1) adds support for U2F mocking mechanism;
1997         2) updates tests to reflect U2fCommandConstructor changes.
1998
1999         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2000         (TestWebKitAPI::TEST):
2001         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2002         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2003         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2004
2005 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2006
2007         [iOS] Dispatch a synthetic mousedown event prior to starting drags
2008         https://bugs.webkit.org/show_bug.cgi?id=193229
2009         <rdar://problem/46717097>
2010
2011         Reviewed by Tim Horton.
2012
2013         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
2014         prevents a drag from starting.
2015
2016         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2017         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
2018
2019         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
2020
2021 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
2022   
2023         Layout test will generate a perf metric file to results dir.
2024         https://bugs.webkit.org/show_bug.cgi?id=192030
2025         <rdar://problem/32779516>
2026
2027         Reviewed by Aakash Jain.
2028
2029         Layout test running time will be collected to a perf metric file.
2030         For now, instead of outputing running time of all tests (which is huge),
2031         we aggregate them by test directories which are at most two level deep. 
2032
2033         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2034         (Manager._end_test_run):
2035         (Manager._output_perf_metrics):
2036         (Manager._print_expectation_line_for_test):
2037         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2038         (add_test_perf_metric):
2039         (test_perf_metrics):
2040         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2041         (JSONGeneratorTest.test_test_timings_trie):
2042         (JSONGeneratorTest):
2043         (JSONGeneratorTest.test_test_perf_metrics):
2044         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2045         (RebaselineTest.test_reset_results):
2046         (RebaselineTest.test_missing_results):
2047         (RebaselineTest.test_new_baseline):
2048
2049 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
2050
2051         [WPE][GTK] Add php-json to install-dependencies
2052         https://bugs.webkit.org/show_bug.cgi?id=193233
2053
2054         Reviewed by Michael Catanzaro.
2055
2056         * gtk/install-dependencies:
2057         * wpe/install-dependencies:
2058
2059 2019-01-08  Chris Dumez  <cdumez@apple.com>
2060
2061         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
2062         https://bugs.webkit.org/show_bug.cgi?id=193224
2063         <rdar://problem/47097726>
2064
2065         Reviewed by Alex Christensen.
2066
2067         Add API test coverage.
2068
2069         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2070
2071 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2072
2073         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
2074         <https://webkit.org/b/193222>
2075         <rdar://problem/46862309>
2076
2077         Reviewed by Joseph Pecoraro.
2078
2079         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2080         (WTR::executeCallback): Fix camel case of variable name.
2081         (WTR::EventSendingController::callAfterScrollingCompletes): If
2082         WKBundlePageRegisterScrollOperationCompletionCallback() returns
2083         false, make sure to release the ScrollCompletionCallbackData
2084         object.  This fixes the leak.
2085
2086 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2087
2088         [Win] EWS: wincairo-ews cannot apply a patch with *.png
2089         https://bugs.webkit.org/show_bug.cgi?id=193044
2090
2091         Reviewed by Daniel Bates.
2092
2093         WinCairo EWS bots are using Windows Perl. Binary files should be
2094         opened as binary mode.
2095
2096         * Scripts/svn-apply:
2097         (handleGitBinaryChange): Use 'binmode' for binary file handles.
2098
2099 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
2100
2101         [CMake] Add ENABLE_CSS_TYPED_OM option
2102         https://bugs.webkit.org/show_bug.cgi?id=193216
2103
2104         Reviewed by Michael Catanzaro.
2105
2106         * Scripts/webkitperl/FeatureList.pm:
2107
2108 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2109
2110         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
2111         <https://webkit.org/b/193056>
2112
2113         Reviewed by Alex Christensen.
2114
2115         * Scripts/webkitpy/style/checker.py:
2116         - Ignore use of new runtime/retainptr check in
2117           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
2118           contains tests to ensure RetainPtr<NSObject *> is compatible
2119           with RetainPtr<NSObject>.
2120
2121         * Scripts/webkitpy/style/checkers/cpp.py:
2122         (check_language):
2123         (CppChecker):
2124         - Add checker for use of '*' in RetainPtr<> type.  A for loop
2125           was used instead of a single regex so that angle brackets
2126           could be matched up when checking the type contained within
2127           the RetainPtr<> type.
2128
2129         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2130         (CppStyleTest):
2131         - Add unit test for new runtime/retainptr check.
2132
2133         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
2134         * TestWebKitAPI/EditingTestHarness.h:
2135         - Remove '*' from RetainPtr<> type.
2136
2137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2138         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
2139           regressed in r201938.
2140
2141         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2142         (TestWebKitAPI::TEST):
2143         - Update tests to match RetainPtr.mm tests (except for the
2144           `*SimilarNSType` tests since there is no CF equivalent of
2145           RetainPtr<NSString> and RetainPtr<NSString *>).
2146
2147         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2148         (TestWebKitAPI::TEST):
2149         - Update tests to:
2150           - Not conflict by name with equivalent CF tests in
2151             RetainPtr.cpp.
2152           - Add test cases for RetainPtr<NSObject>,
2153             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
2154           - Add `*SimilarNSType` tests for converting between
2155             RetainPtr<NSObject> and RetainPtr<NSObject *>.
2156           - Change `0` to `nil` as appropriate.
2157           - Re-alphabetize the tests by name.
2158           - Add Optional<RetainPtr<>> tests.
2159           - Add retainPtr() tests.
2160
2161         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2162         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2163         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
2164         (TEST):
2165         - Remove '*' from RetainPtr<> type.
2166
2167         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
2168         (TEST(WebKit, JITEnabled)):
2169         - Add missing WTFMove().  Apparently a temporary was being
2170           created before in the argument list due to mismatched
2171           RetainPtr<> types.
2172
2173         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2174         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2175         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
2176         (TestWebKitAPI::TEST):
2177         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2178         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2179         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2180         (WTR::resourcesDirectoryURL):
2181         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2182         (WTR::InjectedBundle::platformInitialize):
2183         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2184         - Remove '*' from RetainPtr<> type.
2185
2186 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
2187
2188         A MediaTime timescale must never be zero
2189         https://bugs.webkit.org/show_bug.cgi?id=193156
2190         <rdar://problem/32504501>
2191
2192         Reviewed by Jer Noble.
2193
2194         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2195         (TestWebKitAPI::TEST): Add tests for zero timescale.
2196
2197 2019-01-07  Youenn Fablet  <youenn@apple.com>
2198
2199         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
2200         https://bugs.webkit.org/show_bug.cgi?id=193175
2201
2202         Reviewed by Chris Dumez.
2203
2204         Updated API test as we bumped the SW schema to version 4.
2205
2206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2207         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
2208         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2209         (TEST):
2210
2211 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2212
2213         [Win][Clang] Fix compilation warnings of MiniBrowser
2214         https://bugs.webkit.org/show_bug.cgi?id=193029
2215
2216         Reviewed by Ross Kirsling.
2217
2218         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
2219         and m_URLBarFont. Reorder member variables to fix -Wreorder
2220         warning.
2221         * MiniBrowser/win/PageLoadTestClient.cpp:
2222         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
2223         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
2224         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
2225         m_currentURLIndex.
2226         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2227         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
2228         navigationClient with '{ }' to fix the missing field warning.
2229         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2230         (initDocStruct): Changed the argument type docname to const.
2231
2232 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
2233
2234         [WebAuthN] Import U2F command/response converters from Chromium
2235         https://bugs.webkit.org/show_bug.cgi?id=193150
2236         <rdar://problem/47054028>
2237
2238         Reviewed by Brent Fulgham.
2239
2240         Adds API tests.
2241
2242         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2243         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2244         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
2245         (TestWebKitAPI::getTestAuthenticatorDataBytes):
2246         (TestWebKitAPI::getTestAttestationObjectBytes):
2247         (TestWebKitAPI::getTestSignResponse):
2248         (TestWebKitAPI::getTestU2fRegisterResponse):
2249         (TestWebKitAPI::TEST):
2250         (TestWebKitAPI::convertToVector): Deleted.
2251         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2252         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
2253         (TestWebKitAPI::constructMakeCredentialRequest):
2254         (TestWebKitAPI::constructGetAssertionRequest):
2255         (TestWebKitAPI::TEST):
2256
2257 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
2258
2259         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
2260         https://bugs.webkit.org/show_bug.cgi?id=193136
2261
2262         Reviewed by Michael Catanzaro.
2263
2264         * gtk/install-dependencies:
2265         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
2266         they are needed by update-webkitgtk-libs.
2267
2268 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
2269
2270         Unreviewed follow-up fix to r239650
2271         https://bugs.webkit.org/show_bug.cgi?id=193140
2272         <rdar://problem/47063037>
2273
2274         Typecast patch_id to string.
2275
2276         * BuildSlaveSupport/ews-build/steps.py:
2277         (ValidatePatch._is_patch_obsolete):
2278
2279 2019-01-04  Daniel Bates  <dabates@apple.com>
2280
2281         [lldb-webkit]: Add support for pretty-printing raw bitmask types
2282         https://bugs.webkit.org/show_bug.cgi?id=193024
2283
2284         Reviewed by Jer Noble.
2285
2286         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
2287         for the bitmask type WebEventFlags as an example.
2288
2289         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
2290         that can be used to register summary and synthetic child formatters for a bitmask type.
2291         For example, consider the following enum and bitmask typedefs:
2292
2293         typedef enum {
2294             A = 1 << 0,
2295             B = 1 << 1,
2296             C = 1 << 2,
2297         } SpecialFlagValues;
2298         typedef unsigned SpecialFlags;
2299
2300         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
2301         __lldb_init_module():
2302
2303             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
2304                     1 << 0: "A",
2305                     1 << 1: "B",
2306                     1 << 2: "C",
2307             })
2308
2309         * lldb/lldb_webkit.py:
2310         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2311         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
2312         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
2313         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
2314         A convenience function to dynamically creaste a synthetic formatter class and summary
2315         string function for the specified bitmask type and enumerator value to name map. This
2316         function register the dynamically created class and function with LLDB.
2317
2318         (__lldb_init_module):
2319         (FlagEnumerationProvider):
2320         (FlagEnumerationProvider._enumerator_value_to_name_map):
2321         (FlagEnumerationProvider._bitmask):
2322         (FlagEnumerationProvider._update):
2323         (FlagEnumerationProvider.has_children):
2324         (FlagEnumerationProvider.num_children):
2325         (FlagEnumerationProvider.get_child_index):
2326         (FlagEnumerationProvider.get_child_at_index):
2327         (FlagEnumerationProvider.update):
2328         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
2329
2330         (WTFOptionSetProvider):
2331         (WTFOptionSetProvider._enumerator_value_to_name_map):
2332         (WTFOptionSetProvider._bitmask):
2333         (WTFOptionSetProvider._update):
2334         Write in terms of the base class.
2335
2336         (RawBitmaskProviderBase):
2337         (RawBitmaskProviderBase._enumerator_value_to_name_map):
2338         (RawBitmaskProviderBase._bitmask):
2339         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
2340         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
2341         {
2342             1 << 0: "A",
2343             1 << 1: "B",
2344             1 << 2: "C",
2345         }
2346         It is not necessary to instantiate such a derived class directory. Instead use the convenience
2347         function addSummaryAndSyntheticFormattersForRawBitmaskType.
2348
2349         (WTFOptionSetProvider.has_children): Deleted.
2350         (WTFOptionSetProvider.num_children): Deleted.
2351         (WTFOptionSetProvider.get_child_index): Deleted.
2352         (WTFOptionSetProvider.get_child_at_index): Deleted.
2353         (WTFOptionSetProvider.update): Deleted.
2354
2355 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2356
2357         [ews-build] Add build step to validate the patch before processing it
2358         https://bugs.webkit.org/show_bug.cgi?id=193140
2359
2360         Reviewed by Lucas Forschler.
2361
2362         * BuildSlaveSupport/ews-build/factories.py:
2363         (Factory.__init__): Added ValidatePatch step.
2364         * BuildSlaveSupport/ews-build/steps.py:
2365         (ValidatePatch):
2366         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
2367         (ValidatePatch.get_patch_json): Get patch json data.
2368         (ValidatePatch.get_bug_json): Get bug json data.
2369         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
2370         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
2371         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
2372         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
2373         (ValidatePatch.skip_build): Skip the build.
2374         (ValidatePatch.start):
2375
2376 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2377
2378         Progress towards fixing Mac CMake build
2379         https://bugs.webkit.org/show_bug.cgi?id=193105
2380
2381         Reviewed by Don Olmstead.
2382
2383         * TestWebKitAPI/PlatformMac.cmake:
2384
2385 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2386
2387         Fix API test after r239631
2388         https://bugs.webkit.org/show_bug.cgi?id=193118
2389
2390         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2391         (TestWebKitAPI::TEST):
2392         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
2393         Do the same thing via the API to fix the test.
2394
2395 2019-01-04  Jer Noble  <jer.noble@apple.com>
2396
2397         [WebKitLegacy] Media playback pauses on scroll
2398         https://bugs.webkit.org/show_bug.cgi?id=192829
2399
2400         Reviewed by Eric Carlson.
2401
2402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2403         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
2404         (TestWebKitAPI::TEST):
2405         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
2406         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
2407         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
2408         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
2409         (TestWebKitAPI::TEST):
2410
2411 2019-01-04  Chris Dumez  <cdumez@apple.com>
2412
2413         Add support for toggling device orientation API support per site
2414         https://bugs.webkit.org/show_bug.cgi?id=193143
2415         <rdar://problem/46605724>
2416
2417         Reviewed by Alex Christensen.
2418
2419         Add API test coverage.
2420
2421         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2422         (-[DataMappingSchemeHandler setTaskHandler:]):
2423         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
2424         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
2425         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2426         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
2427
2428 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2429
2430         [ews-build] use svn-apply script to apply the patches
2431         https://bugs.webkit.org/show_bug.cgi?id=193138
2432
2433         Reviewed by Lucas Forschler.
2434
2435         * BuildSlaveSupport/ews-build/factories.py:
2436         (Factory.__init__): Add the ApplyPatch step.
2437         * BuildSlaveSupport/ews-build/steps.py:
2438         (CheckOutSource): Added step name.
2439         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
2440         (ApplyPatch): Build step to apply patch using svn-apply script.
2441         (UnApplyPatchIfRequired):
2442         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
2443
2444 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2445
2446         Deprecate WKContextCreate
2447         https://bugs.webkit.org/show_bug.cgi?id=193118
2448
2449         Reviewed by Brady Eidson.
2450
2451         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2452         (WebKitBrowserWindow::WebKitBrowserWindow):
2453         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
2454         (TestWebKitAPI::TEST):
2455         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2456         (TestWebKitAPI::TEST):
2457         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2458         (TestWebKitAPI::TEST):
2459         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
2460         (TestWebKitAPI::TEST):
2461         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
2462         (TestWebKitAPI::TEST):
2463         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2464         (TestWebKitAPI::TEST):
2465         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2466         (TestWebKitAPI::TEST):
2467         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2468         (TestWebKitAPI::TEST):
2469         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2470         (TestWebKitAPI::TEST):
2471         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2472         (TestWebKitAPI::TEST):
2473         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2474         (TestWebKitAPI::TEST):
2475         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2476         (TestWebKitAPI::TEST):
2477         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2478         (TestWebKitAPI::TEST):
2479         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2480         (TestWebKitAPI::TEST):
2481         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2482         (TestWebKitAPI::TEST):
2483         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2484         (TestWebKitAPI::TEST):
2485         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2486         (TestWebKitAPI::TEST):
2487         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2488         (TestWebKitAPI::TEST):
2489         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2490         (TestWebKitAPI::loadAlternateHTMLString):
2491         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2492         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2493         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2494         (TestWebKitAPI::buildAndPerformTest):
2495         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2496         (TestWebKitAPI::TEST):
2497         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
2498         (TestWebKitAPI::TEST):
2499         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
2500         (TestWebKitAPI::TEST):
2501         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2502         (TestWebKitAPI::TEST):
2503         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2504         (TestWebKitAPI::TEST):
2505         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2506         (TestWebKitAPI::TEST):
2507         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2508         (TestWebKitAPI::TEST):
2509         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2510         (TestWebKitAPI::TEST):
2511         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2512         (TestWebKitAPI::TEST):
2513         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2514         (TestWebKitAPI::TEST):
2515         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2516         (TestWebKitAPI::TEST):
2517         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2518         (TestWebKitAPI::TEST):
2519         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2520         (TestWebKitAPI::TEST):
2521         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2522         (TestWebKitAPI::TEST):
2523         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2524         (TestWebKitAPI::TEST):
2525         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2526         (TestWebKitAPI::TEST):
2527         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2528         (TestWebKitAPI::TEST):
2529         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2530         (TestWebKitAPI::TEST):
2531         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
2532         (TestWebKitAPI::TEST):
2533         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2534         (TestWebKitAPI::TEST):
2535         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2536         (TestWebKitAPI::TEST):
2537         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2538         (TestWebKitAPI::TEST):
2539         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2540         (TestWebKitAPI::TEST):
2541         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
2542         (TestWebKitAPI::TEST):
2543         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2544         (TestWebKitAPI::TEST):
2545         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2546         (TestWebKitAPI::TEST):
2547         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2548         (WebKit2_CommandBackForwardTestWKView::SetUp):
2549         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2550         (TestWebKitAPI::TEST):
2551         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2552         (TestWebKitAPI::TEST):
2553         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
2554         (TestWebKitAPI::TEST):
2555         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2556         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2557
2558 2019-01-03  Matt Rajca  <mrajca@apple.com>
2559
2560         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
2561         https://bugs.webkit.org/show_bug.cgi?id=193128
2562         rdar://34554231
2563
2564         Reviewed by Jer Noble.
2565
2566         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
2567         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
2568         event along with a flag that indicates whether or not autoplay was actually prevented.
2569
2570         Tests: existing API tests were updated to reflect the new names. New API tests
2571         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
2572
2573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2574         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
2575         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2576         (TEST):
2577         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
2578         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
2579
2580 2019-01-04  Chris Dumez  <cdumez@apple.com>
2581
2582         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
2583         https://bugs.webkit.org/show_bug.cgi?id=193120
2584
2585         Reviewed by Alex Christensen.
2586
2587         Add API test coverage.
2588
2589         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2590
2591 2019-01-04  Chris Dumez  <cdumez@apple.com>
2592
2593         Crash under WebProcessPool::addSuspendedPage()
2594         https://bugs.webkit.org/show_bug.cgi?id=193110
2595
2596         Reviewed by Youenn Fablet.
2597
2598         Add API test coverage.
2599
2600         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2601
2602 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2603
2604         [ews-build] Check patch relevance before applying the patch
2605         https://bugs.webkit.org/show_bug.cgi?id=193102
2606
2607         Reviewed by Lucas Forschler.
2608
2609         * BuildSlaveSupport/ews-build/factories.py:
2610         (Factory.__init__): Moved CheckPatchRelevance step to base class.
2611
2612 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2613
2614         [ews-build] Check patch relevance step should print patch id
2615         https://bugs.webkit.org/show_bug.cgi?id=193137
2616
2617         Reviewed by Lucas Forschler.
2618
2619         * BuildSlaveSupport/ews-build/steps.py:
2620         (CheckPatchRelevance.start): Update the status to include patch id.
2621
2622 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
2623
2624         webkitpy: Increase simulator teardown timeout
2625         https://bugs.webkit.org/show_bug.cgi?id=193141
2626         <rdar://problem/46174217>
2627
2628         Rubber-stamped by Aakash Jain.
2629
2630         * Scripts/webkitpy/xcode/simulated_device.py:
2631         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
2632
2633 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
2634
2635         test262-runner misbehaves when test file YAML has a trailing space
2636         https://bugs.webkit.org/show_bug.cgi?id=193053
2637
2638         Reviewed by Yusuke Suzuki.
2639
2640         * Scripts/test262/Runner.pm:
2641         (parseData):
2642         Accept trailing space when parsing a test file's YAML block.
2643
2644 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2645
2646         UserMedia test should use WKPageNavigationClient
2647         https://bugs.webkit.org/show_bug.cgi?id=192913
2648
2649         Reviewed by Youenn Fablet.
2650
2651         The test currently uses the deprecated WKPageLoaderClient. It should use
2652         WKPageNavigationClient instead, which provides the same callback under a similar name.
2653
2654         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2655         (TestWebKitAPI::TEST):
2656
2657 2019-01-02  Alex Christensen  <achristensen@webkit.org>
2658
2659         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
2660         https://bugs.webkit.org/show_bug.cgi?id=192944
2661
2662         Reviewed by Tim Horton.
2663
2664         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2665         (TestWebKitAPI::TEST):
2666
2667 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2668
2669         Add support for using the current text selection as the find string on iOS
2670         https://bugs.webkit.org/show_bug.cgi?id=193034
2671         <rdar://problem/45138739>
2672
2673         Reviewed by Tim Horton.
2674
2675         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
2676         _setStringForFind) works as expected.
2677
2678         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2679         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
2680
2681 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
2682
2683         [ews-build] Use git on OpenSource EWS bots
2684         https://bugs.webkit.org/show_bug.cgi?id=193092
2685
2686         Reviewed by Lucas Forschler.
2687
2688         * BuildSlaveSupport/ews-build/steps.py:
2689         (CheckOutSource): Use git instead of svn.
2690         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
2691
2692 2019-01-02  Daniel Bates  <dabates@apple.com>
2693
2694         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
2695         https://bugs.webkit.org/show_bug.cgi?id=193023
2696
2697         Reviewed by Simon Fraser.
2698
2699         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
2700         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
2701         enumerator values. We should just remove this code.
2702
2703         * lldb/lldb_webkit.py:
2704         (WTFOptionSetProvider.has_children):
2705         (WTFOptionSetProvider.num_children):
2706         (WTFOptionSetProvider.get_child_index):
2707         (WTFOptionSetProvider.get_child_at_index):
2708
2709 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2710
2711         .ycm_extra_conf.py should handle XXXInlines.h
2712         https://bugs.webkit.org/show_bug.cgi?id=193055
2713
2714         Reviewed by Carlos Garcia Campos.
2715
2716         compile_commands.json database only records flags and options for cpp source files.
2717         So, when we open headers, this database does not have any information for that.
2718         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
2719         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
2720         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
2721         we attempt to find XXX.cpp and use the configuration if it exists.
2722
2723         * gtk/ycm_extra_conf.py:
2724         (getImplementationFilename):
2725         (FlagsForFile):
2726
2727 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2728
2729         Unreviewed. Support PHP 7.3 in Debian.
2730
2731         Add 7.3 to the list of php versions supported in Debian.
2732
2733         * Scripts/webkitpy/port/base.py:
2734         (Port._debian_php_version):
2735
2736 2018-12-27  Alex Christensen  <achristensen@webkit.org>
2737
2738         Resurrect Mac CMake build
2739         https://bugs.webkit.org/show_bug.cgi?id=192658
2740
2741         Reviewed by Yusuke Suzuki.
2742
2743         * DumpRenderTree/PlatformMac.cmake:
2744         * MiniBrowser/mac/CMakeLists.txt:
2745         * TestWebKitAPI/PlatformMac.cmake:
2746
2747 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
2748
2749         [Tools] Remove references to Bison and Flex
2750         https://bugs.webkit.org/show_bug.cgi?id=193033
2751
2752         Reviewed by Michael Catanzaro.
2753
2754         The Bison and Flex tools are not needed anymore since r209883.
2755
2756         * CygwinDownloader/cygwin-downloader.py:
2757         * EWSTools/ubuntu-ews-packages:
2758         * Scripts/filter-build-webkit:
2759         (shouldIgnoreLine):
2760         * gtk/install-dependencies:
2761         * wpe/install-dependencies:
2762
2763 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2764
2765         WebDriver: warn about non existing tests when parsing expectations
2766         https://bugs.webkit.org/show_bug.cgi?id=192979
2767
2768         Reviewed by Michael Catanzaro.
2769
2770         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
2771         renamed.
2772
2773         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2774         (WebDriverTestRunner.__init__):
2775
2776 2018-12-21  Chris Dumez  <cdumez@apple.com>
2777
2778         navigator.userAgent in service workers does not reflect customUserAgent set by client
2779         https://bugs.webkit.org/show_bug.cgi?id=192951
2780
2781         Reviewed by Youenn Fablet.
2782
2783         Extend API test coverage.
2784
2785         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2786         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
2787         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2788         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
2789         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2790
2791 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2792
2793         [WebAuthN] userPresence should always be true
2794         https://bugs.webkit.org/show_bug.cgi?id=192835
2795         <rdar://problem/46538788>
2796
2797         Reviewed by Brent Fulgham.
2798
2799         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2800         (TestWebKitAPI::TEST):
2801
2802 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
2803
2804         Add support to run-benchmark to use non-default copies of the browser apps
2805         https://bugs.webkit.org/show_bug.cgi?id=192905
2806         rdar://problem/46845840
2807
2808         Reviewed by Dewei Zhu.
2809         
2810         Add support for a --browser-path argument to run-benchmark, which allows you to use
2811         a custom app bundle for a given browser (only implemented for Safari at present).
2812
2813         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2814         (BenchmarkRunner.__init__):
2815         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2816         (BrowserDriver.__init__):
2817         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2818         (BrowserDriverFactory.create):
2819         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2820         (OSXBrowserDriver._launch_process):
2821         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
2822         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
2823         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2824         (OSXChromeCanaryDriver.launch_url):
2825         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2826         (OSXFirefoxNightlyDriver.launch_url):
2827         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2828         (OSXSafariDriver.__init__):
2829         (OSXSafariDriver.launch_url):
2830         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2831         (parse_args):
2832         (run_benchmark_plan):
2833         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
2834         (WebServerBenchmarkRunner.__init__):
2835         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
2836         (FakeBenchmarkRunner.__init__):
2837
2838 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2839
2840         [WebAuthN] Import an APDU coder from Chromium
2841         https://bugs.webkit.org/show_bug.cgi?id=192949
2842         <rdar://problem/46879933>
2843
2844         Reviewed by Brent Fulgham.
2845
2846         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2847         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
2848         (TestWebKitAPI::TEST):
2849
2850 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2851
2852         Setting the file wrapper and content type of an attachment to a PDF should update its image
2853         https://bugs.webkit.org/show_bug.cgi?id=192984
2854         <rdar://problem/46798028>
2855
2856         Reviewed by Tim Horton.
2857
2858         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
2859         PDF data correctly updates the image element.
2860
2861         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2862
2863 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2864
2865         Add JSCOnly to bot dashboard
2866         https://bugs.webkit.org/show_bug.cgi?id=192964
2867
2868         Reviewed by Alexey Proskuryakov.
2869
2870         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
2871         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
2872         useful if they were not so secret, so add them.
2873
2874         There appear to be no build-only bots, so the first column is blank. And of course there are
2875         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
2876         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
2877         and there's plenty of room in the final column for all the bots.
2878
2879         I had a hard time picking a logo to use, because the JavaScript language does not have an
2880         official logo. But I believe I've found one that will be satisfactory.
2881
2882         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
2883
2884         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
2885         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
2886         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2887         (BubbleQueueServer):
2888         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2889         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2890         (WebKitBuildbot):
2891         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2892         (table.queue-grid tr.platform.linux-jsconly img.logo):
2893
2894 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
2895
2896         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
2897         https://bugs.webkit.org/show_bug.cgi?id=192821
2898
2899         Reviewed by Chris Dumez.
2900
2901         * DumpRenderTree/mac/DumpRenderTree.mm:
2902         (createWebViewAndOffscreenWindow):
2903         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2904
2905 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2906
2907         [Win][Clang] Fix compilation warnings of DumpRenderTree
2908         https://bugs.webkit.org/show_bug.cgi?id=192924
2909
2910         Reviewed by Alex Christensen.
2911
2912         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
2913         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2914         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
2915         * DumpRenderTree/win/DumpRenderTree.cpp:
2916         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
2917         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
2918         object to the argument of setDefaultTextEncodingName instead of a
2919         const string literal.
2920         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
2921         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
2922         (setCacheFolder): Deleted.
2923         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
2924         * DumpRenderTree/win/EditingDelegate.cpp:
2925         (dump): Use %d for int.
2926         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
2927         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2928         (BSTRFromString): Deleted unused function.
2929         * DumpRenderTree/win/TestRunnerWin.cpp:
2930         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
2931         the arguemnt of setQuota instead of const string literal.
2932         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2933         (jsStringRefToWString): Deleted unused function.
2934
2935 2018-12-20  Chris Dumez  <cdumez@apple.com>
2936
2937         Add API test coverage for customUserAgent client setting and service workers
2938         https://bugs.webkit.org/show_bug.cgi?id=192952
2939
2940         Reviewed by Alex Christensen.
2941
2942         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2943         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
2944         (-[SWSchemes webView:startURLSchemeTask:]):
2945         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2946         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2947
2948 2018-12-20  Chris Dumez  <cdumez@apple.com>
2949
2950         Use Optional::hasValue() instead of Optional::has_value()
2951         https://bugs.webkit.org/show_bug.cgi?id=192948
2952
2953         Reviewed by Tim Horton.
2954
2955         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
2956         (TestWebKitAPI::TEST):
2957         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
2958         (TestWebKitAPI::TEST):
2959         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2960         (TestWebKitAPI::TEST_F):
2961
2962 2018-12-20  Chris Dumez  <cdumez@apple.com>
2963
2964         Add style script rule to check for uses of std::optional<>
2965         https://bugs.webkit.org/show_bug.cgi?id=192931
2966
2967         Reviewed by Tim Horton.
2968
2969         * Scripts/webkitpy/style/checkers/cpp.py:
2970         (check_wtf_optional):
2971         (check_style):
2972
2973 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
2974
2975         [WebAuthN] Add a runtime flag for local authenticator
2976         https://bugs.webkit.org/show_bug.cgi?id=192792
2977         <rdar://problem/46798738>
2978
2979         Reviewed by Brent Fulgham.
2980
2981         * DumpRenderTree/TestOptions.cpp:
2982         (TestOptions::TestOptions):
2983         * DumpRenderTree/TestOptions.h:
2984         * DumpRenderTree/mac/DumpRenderTree.mm:
2985         (enableExperimentalFeatures):
2986         (setWebPreferencesForTestOptions):
2987         * WebKitTestRunner/TestController.cpp:
2988         (WTR::TestController::resetPreferencesToConsistentValues):
2989         (WTR::updateTestOptionsFromTestHeader):
2990         * WebKitTestRunner/TestOptions.h:
2991         (WTR::TestOptions::hasSameInitializationOptions const):
2992
2993 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
2994
2995         webkitpy: Autoinstall package URLs have changed
2996         https://bugs.webkit.org/show_bug.cgi?id=192909
2997         <rdar://problem/46860359>
2998
2999         Rubber-stamped by Alexey Proskuryakov.
3000
3001         PyPi urls have been moved around, we need to update our auto-installed packages.
3002
3003         We should check for Selenium before asking PyPi for the latest version.
3004
3005         * Scripts/webkitpy/thirdparty/__init__.py:
3006         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
3007         (AutoinstallImportHook._install_keyring): Ditto.
3008         (AutoinstallImportHook._install_pep8): Ditto.
3009         (AutoinstallImportHook._install_mozlog): Ditto.
3010         (AutoinstallImportHook._install_mozprocess): Ditto.
3011         (AutoinstallImportHook._install_pytest_timeout): Ditto.
3012         (AutoinstallImportHook._install_pytest): Ditto.
3013         (AutoinstallImportHook._install_pylint): Ditto.
3014         (AutoinstallImportHook._install_buildbot): Ditto.
3015         (AutoinstallImportHook._install_coverage): Ditto.
3016         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
3017         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
3018         for new Selenium if the installed version isn't sufficient.
3019         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
3020
3021 2018-12-20  Chris Dumez  <cdumez@apple.com>
3022
3023         Use Optional::valueOr() instead of Optional::value_or()
3024         https://bugs.webkit.org/show_bug.cgi?id=192933
3025
3026         Reviewed by Geoffrey Garen.
3027
3028         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3029         (TestWebKitAPI::checkURL):
3030         (TestWebKitAPI::checkRelativeURL):
3031         (TestWebKitAPI::checkURLDifferences):
3032         (TestWebKitAPI::checkRelativeURLDifferences):
3033         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
3034         (TestWebKitAPI::checkURL):
3035
3036 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
3037
3038         Unreviewed, rolling out r239417.
3039
3040         Introduced two API test failures on macOS.
3041
3042         Reverted changeset:
3043
3044         "<rdar://problem/46194315> macOS: WebKit1 does not handle
3045         occlusion changes"
3046         https://bugs.webkit.org/show_bug.cgi?id=192821
3047         https://trac.webkit.org/changeset/239417
3048
3049 2018-12-20  Devin Rousso  <drousso@apple.com>
3050
3051         Web Inspector: UIString should take an optional key and description to aid localization
3052         https://bugs.webkit.org/show_bug.cgi?id=153962
3053         <rdar://problem/24542505>
3054
3055         Reviewed by Brian Burg.
3056
3057         * Scripts/extract-localizable-js-strings:
3058
3059 2018-12-20  Tim Horton  <timothy_horton@apple.com>
3060
3061         Unparented WKWebView can't retrieve main resource data for a main frame plugin
3062         https://bugs.webkit.org/show_bug.cgi?id=192923
3063         <rdar://problem/46859068>
3064
3065         Reviewed by Wenson Hsieh.
3066
3067         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3068         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
3069         Add a test ensuring that both parented and unparented WKWebViews can
3070         retrieve main resource data when loading a PDF.
3071
3072 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3073
3074         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
3075         https://bugs.webkit.org/show_bug.cgi?id=192852
3076
3077         Reviewed by Michael Catanzaro.
3078
3079         EmojiOne font was replaced by Noto Color Emoji.
3080
3081         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
3082         * gtk/jhbuild.modules:
3083         * wpe/jhbuild.modules:
3084
3085 2018-12-19  Chris Dumez  <cdumez@apple.com>
3086
3087         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
3088         https://bugs.webkit.org/show_bug.cgi?id=192728
3089         <rdar://problem/46746779>
3090
3091         Reviewed by Geoff Garen.
3092
3093         * DumpRenderTree/*:
3094         * MiniBrowser/*:
3095         * TestRunnerShared/*:
3096         * TestWebKitAPI/*:
3097         * WebGPUAPIStructure/*:
3098         * WebKitTestRunner/*:
3099
3100 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
3101
3102         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3103         https://bugs.webkit.org/show_bug.cgi?id=192821
3104
3105         Reviewed by Chris Dumez.
3106
3107         * DumpRenderTree/mac/DumpRenderTree.mm:
3108         (createWebViewAndOffscreenWindow):
3109
3110 2018-12-19  Alex Christensen  <achristensen@webkit.org>
3111
3112         Navigations away from the SafeBrowsing interstitial show a flash of old content
3113         https://bugs.webkit.org/show_bug.cgi?id=192676
3114
3115         Reviewed by Chris Dumez.
3116
3117         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3118         (safeBrowsingView):
3119         (TEST):
3120         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3121
3122 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
3123
3124         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
3125         https://bugs.webkit.org/show_bug.cgi?id=192855
3126
3127         Reviewed by Michael Catanzaro.
3128
3129         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3130         (WTR::TestController::notifyDone): Use the WPE implementation.
3131         (WTR::TestController::platformRunUntil): Use the WPE implementation.
3132         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
3133         (WTR::TestController::platformRunUntil): Honor the condition flag.
3134
3135 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
3136
3137         Allow clients to set the navigator platform
3138         https://bugs.webkit.org/show_bug.cgi?id=192735
3139
3140         Reviewed by Tim Horton.
3141
3142         Add a test for setting a custom navigator platform.
3143
3144         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3145         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3146         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
3147
3148 2018-12-19  Truitt Savell  <tsavell@apple.com>
3149
3150         Unreviewed, rolling out r239358.
3151
3152         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
3153         crash on Debug bots
3154
3155         Reverted changeset:
3156
3157         "Clean up IndexedDB files between tests"
3158         https://bugs.webkit.org/show_bug.cgi?id=192796
3159         https://trac.webkit.org/changeset/239358
3160
3161 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3162
3163         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
3164         https://bugs.webkit.org/show_bug.cgi?id=192842
3165         <rdar://problem/46823586>
3166
3167         Reviewed by Tim Horton.
3168
3169         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
3170         item provider when dragging a rich text selection.
3171
3172         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3173
3174 2018-12-18  David Quesada  <david_quesada@apple.com>
3175
3176         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
3177         https://bugs.webkit.org/show_bug.cgi?id=192810
3178         <rdar://problem/46812536>
3179
3180         Reviewed by Alex Christensen.
3181
3182         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3183         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3184             After releasing our reference to the web view, wait until the next turn of the runloop
3185             before checking that the originatingWebView has been zeroed, since the web view might
3186             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
3187             testing general memory management of WKWebViews, only that _WKDownload does not retain
3188             its web view via the 'originatingWebView' property.
3189
3190 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
3191
3192         Clean up IndexedDB files between tests
3193         https://bugs.webkit.org/show_bug.cgi?id=192796
3194
3195         Reviewed by Geoffrey Garen.
3196
3197         * DumpRenderTree/mac/DumpRenderTree.mm:
3198         (runTest):
3199         * WebKitTestRunner/TestController.cpp:
3200         (WTR::TestController::resetStateToConsistentValues):
3201         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3202         (WTR::RemoveAllIndexedDatabasesCallback):
3203         (WTR::TestController::ClearIndexedDatabases):
3204         * WebKitTestRunner/TestController.h:
3205
3206 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3207
3208         Fix API test introduced in r239339 on iOS.
3209         https://bugs.webkit.org/show_bug.cgi?id=192675
3210
3211         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3212         (TEST):
3213         The iOS implementation of the safe browsing warning is a little different.
3214         It does some element creation when it is added to the window so it knows how big it is.
3215         To test these elements, we need to simulate adding it to the window.
3216         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
3217
3218 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
3219
3220         webkitpy: Ignore device type for test when using --force
3221         https://bugs.webkit.org/show_bug.cgi?id=192786
3222         <rdar://problem/46794894>
3223
3224         Reviewed by Daniel Bates.
3225
3226         It is sometimes the case that a contributor will wish to run a test on a specific device,
3227         despite expectations which indicate a test should not be run on that device.
3228
3229         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3230         (parse_args):
3231         * Scripts/webkitpy/port/device_port.py:
3232         (DevicePort.default_child_processes): Strip device type information when using --force.
3233         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
3234
3235 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3236
3237         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
3238         https://bugs.webkit.org/show_bug.cgi?id=192675
3239
3240         Reviewed by Geoffrey Garen.
3241
3242         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3243         (goBack):
3244         (TEST):
3245         (visitUnsafeSite):
3246         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
3247         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3248
3249 2018-12-18  Chris Dumez  <cdumez@apple.com>
3250
3251         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
3252         https://bugs.webkit.org/show_bug.cgi?id=192772
3253
3254         Reviewed by Antti Koivisto.
3255
3256         Add API test coverage.
3257
3258         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3259
3260 2018-12-18  Philippe Normand  <pnormand@igalia.com>
3261
3262         Unreviewed, JHBuild GTK build fix attempt
3263
3264         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
3265         There's no ninja module either, it should be provided by the
3266         host system.
3267
3268 2018-12-17  Chris Dumez  <cdumez@apple.com>
3269
3270         Allow passing nil as session state to [WKWebView _restoreSessionState:]
3271         https://bugs.webkit.org/show_bug.cgi?id=192789
3272         <rdar://problem/46755277>
3273
3274         Reviewed by Alex Christensen.
3275
3276         Add API test coverage.
3277
3278         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3279         (TEST):
3280
3281 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
3282
3283         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
3284         https://bugs.webkit.org/show_bug.cgi?id=192780
3285         rdar://problem/43394387
3286
3287         Reviewed by Tim Horton.
3288
3289         No need to set "AppleFontSmoothing" defaults for WK2.
3290
3291         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3292         (WTR::InjectedBundle::platformInitialize):
3293
3294 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
3295
3296         webkitpy: Handle case where stdout and stderr don't accept unicode
3297         https://bugs.webkit.org/show_bug.cgi?id=192775
3298         <rdar://problem/46497303>
3299
3300         Reviewed by Stephanie Lewis.
3301
3302         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3303         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
3304         characters with '?'.
3305         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3306         (RegularTest.test_stream_with_encoding):
3307
3308 2018-12-17  Daniel Bates  <dabates@apple.com>
3309
3310         Support concatenating StringView with other string types
3311         https://bugs.webkit.org/show_bug.cgi?id=177566
3312
3313         Reviewed by Darin Adler.
3314
3315         Add some tests to ensure we do not regress the number of allocations needed when performing
3316         string concatenation with string views.
3317
3318         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3319         (TestWebKitAPI::TEST):
3320
3321 2018-12-17  Commit Queue  <commit-queue@webkit.org>
3322
3323         Unreviewed, rolling out r239265 and r239274.
3324         https://bugs.webkit.org/show_bug.cgi?id=192765
3325
3326         unorm_normalize is deprecated, and broke an internal build
3327         (Requested by Truitt on #webkit).
3328
3329         Reverted changesets:
3330
3331         "[GTK][WPE] Need a function to convert internal URI to display
3332         ("pretty") URI"
3333         https://bugs.webkit.org/show_bug.cgi?id=174816
3334         https://trac.webkit.org/changeset/239265
3335
3336         "Fix the Apple Internal Mac build with a newer SDK"
3337         https://trac.webkit.org/changeset/239274
3338
3339 2018-12-17  Daniel Bates  <dabates@apple.com>
3340
3341         Implement UIScriptController::toggleCapsLock() for iOS
3342         https://bugs.webkit.org/show_bug.cgi?id=191815
3343
3344         Reviewed by Andy Estes.
3345
3346         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
3347
3348         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3349         * WebKitTestRunner/TestController.cpp:
3350         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
3351         before running a test. This ensures that the caps lock state does not persist between
3352         tests should a test enable caps lock and not disable it.
3353         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3354         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
3355         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3356         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
3357         create the event. Also substituted NSString* for const String& as the data type for the first
3358         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
3359         below.
3360         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
3361         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
3362
3363 2018-12-17  Daniel Bates  <dabates@apple.com>
3364
3365         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
3366         https://bugs.webkit.org/show_bug.cgi?id=192633
3367
3368         Reviewed by Wenson Hsieh.
3369
3370         Update code to use the modern initializer.
3371
3372         * DumpRenderTree/mac/EventSendingController.mm:
3373         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3374
3375 2018-12-17  Matt Lewis  <jlewis3@apple.com>
3376
3377         Unreviewed, rolling out r239254.
3378
3379         This broke the Windows 10 Debug build
3380
3381         Reverted changeset:
3382
3383         "Replace many uses of String::format with more type-safe
3384         alternatives"
3385         https://bugs.webkit.org/show_bug.cgi?id=192742
3386         https://trac.webkit.org/changeset/239254
3387
3388 2018-12-17  David Kilzer  <ddkilzer@apple.com>
3389
3390         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
3391         <https://webkit.org/b/192751>
3392         <rdar://problem/46771623>
3393
3394         Reviewed by Daniel Bates.
3395
3396         Change loop variables to const references to avoid unnecessary
3397         copies.
3398
3399         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
3400         (-[LocalPasteboard pasteboardItems]):
3401
3402 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
3403
3404         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3405         https://bugs.webkit.org/show_bug.cgi?id=174816
3406
3407         Reviewed by Michael Catanzaro.
3408
3409         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
3410
3411         * TestWebKitAPI/CMakeLists.txt:
3412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3413         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
3414         (TestWebKitAPI::TEST):
3415         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3416         (testURIForDisplayUnaffected):
3417         (testURIForDisplayAffected):
3418         (beforeAll):
3419         (afterAll):
3420         * TestWebKitAPI/glib/CMakeLists.txt:
3421
3422 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3423
3424         [WPE] Add API to notify about frame displayed view backend callback
3425         https://bugs.webkit.org/show_bug.cgi?id=192224
3426
3427         Reviewed by Michael Catanzaro.
3428
3429         Add a test case to check the new API.
3430
3431         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3432         (testWebViewFrameDisplayed):
3433         (beforeAll):
3434         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
3435
3436 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
3437
3438         Unreviewed build fix after r239253
3439
3440         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
3441
3442 2018-12-15  Darin Adler  <darin@apple.com>
3443
3444         Use warning-ignoring macros more consistently and simply
3445         https://bugs.webkit.org/show_bug.cgi?id=192743
3446
3447         Reviewed by Mark Lam.
3448
3449         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3450         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
3451         * DumpRenderTree/mac/TextInputControllerMac.m:
3452         (-[TextInputController interpretKeyEvents:withSender:]): Use
3453         IGNORE_WARNINGS_BEGIN/END.
3454         * WebKitTestRunner/mac/EventSenderProxy.mm:
3455         (WTR::EventSenderProxy::mouseForceClick): Use
3456         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
3457         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
3458         (WTR::EventSenderProxy::mouseForceDown): Ditto.
3459         (WTR::EventSenderProxy::mouseForceUp): Ditto.
3460         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
3461
3462 2018-12-15  Darin Adler  <darin@apple.com>
3463
3464         Replace many uses of String::format with more type-safe alternatives
3465         https://bugs.webkit.org/show_bug.cgi?id=192742
3466
3467         Reviewed by Mark Lam.
3468
3469         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3470         (WTR::cacheTestRunnerCallback): Use makeString.
3471         * WebKitTestRunner/TestController.cpp:
3472         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3473         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3474
3475 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
3476
3477         [WPE][GTK] Add libpsl to JHBuild module sets
3478         https://bugs.webkit.org/show_bug.cgi?id=192740
3479
3480         Reviewed by Michael Catanzaro.
3481
3482         * gtk/jhbuild.modules: Add libpsl module.
3483         * wpe/jhbuild.modules: Ditto.
3484
3485 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
3486
3487         Add a style checker rule for Xcode version macros use
3488         https://bugs.webkit.org/show_bug.cgi?id=192703
3489
3490         Reviewed by Alex Christensen.
3491
3492         * Scripts/webkitpy/style/checkers/cpp.py:
3493         (check_os_version_checks):
3494         (process_line):
3495         (CppChecker):
3496         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3497         (WebKitStyleTest.test_os_version_checks):
3498
3499 2018-12-14  Chris Dumez  <cdumez@apple.com>
3500
3501         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
3502         https://bugs.webkit.org/show_bug.cgi?id=192704
3503
3504         Reviewed by Geoffrey Garen.
3505
3506         Extend existing API test to reproduce the problem.
3507
3508         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3509
3510 2018-12-14  Chris Dumez  <cdumez@apple.com>
3511
3512         [PSON] WebsitePolicies are lost on process-swap
3513         https://bugs.webkit.org/show_bug.cgi?id=192694
3514         <rdar://problem/46715748>
3515
3516         Reviewed by Brady Eidson.
3517
3518         Extend existing API test to reproduce the issue.
3519
3520         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3521
3522 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
3523
3524         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
3525         https://bugs.webkit.org/show_bug.cgi?id=192678
3526
3527         Reviewed by Carlos Garcia Campos.
3528
3529         Update our ancient versions of libsoup and glib-networking.
3530
3531         * gtk/install-dependencies:
3532         * gtk/jhbuild.modules:
3533         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
3534         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
3535         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
3536         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
3537         * wpe/install-dependencies:
3538         * wpe/jhbuild.modules:
3539         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
3540
3541 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3542
3543         [WPE] Use new view state API from libwpe
3544         https://bugs.webkit.org/show_bug.cgi?id=191906
3545
3546         Reviewed by Žan Doberšek.
3547
3548         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3549         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
3550         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3551         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
3552         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3553         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3554         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
3555         wpe_view_activity_state_focused state flags.
3556         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
3557         * wpe/backends/HeadlessViewBackend.cpp:
3558         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
3559         * wpe/backends/WindowViewBackend.cpp:
3560         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
3561         received in configure callback.
3562         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
3563
3564 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
3565
3566         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
3567         https://bugs.webkit.org/show_bug.cgi?id=192688
3568
3569         Reviewed by Ross Kirsling.
3570
3571         * win/DLLLauncher/DLLLauncherMain.cpp:
3572         (copyEnvironmentVariable): Moved.
3573         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
3574         (applePathFromRegistry): Ditto.
3575         (appleApplicationSupportDirectory): Ditto.
3576         (prependPath): Ditto.
3577
3578 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
3579
3580         Unreviewed. Changed my status to a reviewer.
3581
3582         * Scripts/webkitpy/common/config/contributors.json:
3583
3584 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3585
3586         [iOS] Support dropping contact card data (public.vcard) in editable content
3587         https://bugs.webkit.org/show_bug.cgi?id=192570
3588         <rdar://problem/35626913>
3589
3590         Reviewed by Tim Horton.
3591
3592         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3593
3594         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
3595         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
3596         additionally inserts a link).
3597
3598         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3599         (TestWebKitAPI::createMapItemForTesting):
3600         (TestWebKitAPI::createContactItemForTesting):
3601
3602         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
3603         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
3604         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
3605         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
3606         files.
3607
3608 2018-12-13  Ross Kirsling  <ross.kirsling@sony.com>
3609
3610         Unreviewed -- update my status to "reviewer".
3611
3612         * Scripts/webkitpy/common/config/contributors.json:
3613
3614 2018-12-13  Youenn Fablet  <youenn@apple.com>
3615
3616         On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
3617         https://bugs.webkit.org/show_bug.cgi?id=192657
3618
3619         Reviewed by Eric Carlson.
3620
3621         Add a test that loads a page registering ondevicechange,
3622         load another page in the same process, closes the first page.
3623         Ensure that the process does not crash in that case.
3624
3625         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3626         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3627         (TestWebKitAPI::TEST):
3628         (TestWebKitAPI::didCrashCallback):
3629         * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
3630
3631 2018-12-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3632
3633         [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
3634         https://bugs.webkit.org/show_bug.cgi?id=192643
3635
3636         Reviewed by Philippe Normand.
3637
3638         This problem happens with Arch Linux users which have libfdk-2.0.0
3639         installed (which is anybody with gst-plugins-bad 1.14.4 installed).
3640
3641         The problem has already been solved upstream at
3642         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
3643
3644         Adding patches while this problem is not in a release yet.
3645
3646         * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
3647         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
3648         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
3649
3650 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3651
3652         [FreeType] Add initial implementation of variation fonts
3653         https://bugs.webkit.org/show_bug.cgi?id=192151
3654
3655         Reviewed by Michael Catanzaro.
3656
3657         Add cairo patch to avoid crashes.
3658
3659         * gtk/jhbuild.modules:
3660         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3661
3662 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
3663
3664         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
3665         https://bugs.webkit.org/show_bug.cgi?id=192618
3666
3667         Reviewed by Alex Christensen.
3668
3669         * DumpRenderTree/win/DRTDataObject.cpp:
3670         * DumpRenderTree/win/DRTDataObject.h:
3671         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3672         * DumpRenderTree/win/DRTDropSource.h:
3673         * DumpRenderTree/win/EditingDelegate.h:
3674         * DumpRenderTree/win/PolicyDelegate.h:
3675         * DumpRenderTree/win/UIDelegate.h:
3676
3677 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
3678
3679         Make TextInputController.legacyAttributedString take DOM nodes and offsets
3680         https://bugs.webkit.org/show_bug.cgi?id=192653
3681
3682         Reviewed by Wenson Hsieh.
3683
3684         Updated TextInputController.legacyAttributedString to take DOM nodes and offsets instead of
3685         a DOM Range object in preparation to add layout tests for HTMLConverter which crosses
3686         shadow boundaries.
3687
3688         * DumpRenderTree/mac/TextInputControllerMac.m:
3689         (+[TextInputController isSelectorExcludedFromWebScript:]): Updated the selector signature.
3690         (+[TextInputController webScriptNameForSelector:]): Ditto.
3691         (-[TextInputController legacyAttributedString:offset:to:offset:]): Made this function take
3692         start node and offset then end node and offset pairs.
3693
3694 2018-12-12  Alex Christensen  <achristensen@webkit.org>
3695
3696         Implement safe browsing in WebKit on WatchOS
3697         https://bugs.webkit.org/show_bug.cgi?id=192641
3698         <rdar://problem/46376188>
3699
3700         Reviewed by Geoff Garen.
3701
3702         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3703         (-[SafeBrowsingNavigationDelegate _webViewDidShowSafeBrowsingWarning:]):
3704         (safeBrowsingView):
3705         Add a test that the new delegate callback is called.
3706
3707 2018-12-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3708
3709         Unreviewed manual rollout of r239100-r239102 and r239116
3710         https://bugs.webkit.org/show_bug.cgi?id=192151
3711         <rdar://problem/46655586>
3712
3713         * gtk/jhbuild.modules:
3714         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Removed.
3715
3716 2018-12-12  Commit Queue  <commit-queue@webkit.org>
3717
3718         Unreviewed, rolling out r239103.
3719         https://bugs.webkit.org/show_bug.cgi?id=192627
3720
3721         It broke the built because it depends on another patch that
3722         didn't land yet (Requested by KaL on #webkit).
3723
3724         Reverted changeset:
3725
3726         "[WPE] Add API to notify about frame displayed view backend
3727         callback"
3728         https://bugs.webkit.org/show_bug.cgi?id=192224
3729         https://trac.webkit.org/changeset/239103
3730
3731 2018-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3732
3733         [WPE] Add API to notify about frame displayed view backend callback
3734         https://bugs.webkit.org/show_bug.cgi?id=192224
3735
3736         Reviewed by Michael Catanzaro.
3737
3738         Add a test case to check the new API.
3739
3740         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3741         (testWebViewFrameDisplayed):
3742         (beforeAll):
3743
3744 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3745
3746         [FreeType] Add initial implementation of variation fonts
3747         https://bugs.webkit.org/show_bug.cgi?id=192151
3748
3749         Reviewed by Michael Catanzaro.
3750
3751         Add cairo patch to avoid crashes.
3752
3753         * gtk/jhbuild.modules:
3754         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3755
3756 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
3757
3758         Implement feature flag for CSS Typed OM
3759         https://bugs.webkit.org/show_bug.cgi?id=192610
3760
3761         Reviewed by Ryosuke Niwa.
3762
3763         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3764
3765 2018-12-11  Chris Dumez  <cdumez@apple.com>
3766
3767         Unreviewed, fix bad check in API test added in r239080.
3768
3769         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3770
3771 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
3772
3773         [Win][Clang] Fix warning -Wmissing-field-initializers
3774         https://bugs.webkit.org/show_bug.cgi?id=192584
3775
3776         Reviewed by Yusuke Suzuki.
3777
3778         Initialize a struct with '{ }' instead of '= {0}'.
3779
3780         * DumpRenderTree/win/DumpRenderTree.cpp:
3781         (runTest):
3782         * DumpRenderTree/win/EventSender.cpp:
3783         (makeMsg):
3784         (replaySavedEvents):
3785         (beginDragWithFilesCallback):
3786         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3787         (createBitmapContextFromWebView):
3788         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3789         (updateMenuItemForHistoryItem):
3790         * MiniBrowser/win/WinMain.cpp:
3791         (wWinMain):
3792         * TestWebKitAPI/win/HostWindow.cpp:
3793         (TestWebKitAPI::HostWindow::clientRect const):
3794         (TestWebKitAPI::HostWindow::registerWindowClass):
3795         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3796         (TestWebKitAPI::PlatformWebView::registerWindowClass):
3797         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3798         (WTR::registerWindowClass):
3799         (WTR::PlatformWebView::windowFrame):
3800         (WTR::PlatformWebView::windowSnapshotImage):
3801
3802 2018-12-11  Chris Dumez  <cdumez@apple.com>
3803
3804         PSON logic gets confused by concurrent decidePolicyForNavigationAction requests
3805         https://bugs.webkit.org/show_bug.cgi?id=192482
3806         <rdar://problem/46470145>
3807
3808         Reviewed by Antti Koivisto.
3809
3810         Add API test coverage.
3811
3812         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3813
3814 2018-12-11  Andy Estes  <aestes@apple.com>
3815
3816         Introduce makeBlockPtr for lambdas
3817         https://bugs.webkit.org/show_bug.cgi?id=192594
3818
3819         Reviewed by Alex Christensen.
3820
3821         Adopted makeBlockPtr and added API tests.
3822
3823         * DumpRenderTree/TestRunner.cpp:
3824         (TestRunner::callUIScriptCallback):
3825         * TestWebKitAPI/Tests/WTF/BlockPtr.mm:
3826         (TestWebKitAPI::TEST):
3827         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3828         (-[DownloadProgressTestRunner init]):
3829         (-[DownloadProgressTestRunner subscribeAndWaitForProgress]):
3830
3831 2018-12-11  Chris Dumez  <cdumez@apple.com>
3832
3833         REGRESSION (r238764-238783): TestWTF.WTF.StringOperators is failing
3834         https://bugs.webkit.org/show_bug.cgi?id=192361
3835         <rdar://problem/46524903>
3836
3837         Reviewed by Alex Christensen.
3838
3839         Compile StringOperators.cpp with -O1 optimization level instead of -Os. This
3840         fixes the failures for me locally.
3841
3842         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3843
3844 2018-12-11  Philippe Normand  <pnormand@igalia.com>
3845
3846         Unreviewed, WPE build fix after r239028
3847
3848         The FLATPAK_USER_DIR env var is not set early enough, leading to:
3849
3850         Traceback (most recent call last):
3851         File "/home/phil/WebKit/Tools/Scripts/webkit-flatpak", line 28, in <module>
3852           sys.exit(WebkitFlatpak.load_from_args().run())
3853         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 761, in run
3854           if not self.clean_args():
3855         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 574, in clean_args
3856           _log.debug("Using flatpak user dir: %s" % os.environ["FLATPAK_USER_DIR"])
3857         File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__
3858           raise KeyError(key)
3859         KeyError: 'FLATPAK_USER_DIR'
3860
3861         * flatpak/flatpakutils.py:
3862         (WebkitFlatpak.clean_args):
3863
3864 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3865
3866         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
3867         https://bugs.webkit.org/show_bug.cgi?id=192573
3868
3869         Reviewed by Simon Fraser.
3870
3871         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3872
3873 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3874
3875         [CMake] Add ENABLE_RESOURCE_LOAD_STATISTICS to WebKitFeatures.cmake
3876         https://bugs.webkit.org/show_bug.cgi?id=192574
3877
3878         Reviewed by Michael Catanzaro.
3879
3880         * Scripts/webkitperl/FeatureList.pm:
3881
3882 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3883
3884         Sync FeatureList.pm
3885         https://bugs.webkit.org/show_bug.cgi?id=192565
3886
3887         Reviewed by Michael Catanzaro.
3888
3889         * Scripts/webkitperl/FeatureList.pm:
3890
3891 2018-12-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3892
3893         [iOS] Unable to upload data that conforms to "public.item" but not "public.content"
3894         https://bugs.webkit.org/show_bug.cgi?id=192555
3895         <rdar://problem/35204990>
3896
3897         Reviewed by Tim Horton.
3898
3899         Add a test to verify that `.p12` files may be uploaded as files via drag and drop. "com.rsa.pkcs-12" is an
3900         example of a data type that conforms to "public.item", but not "public.content"; before this patch, we would
3901         only support uploading "public.content", so files such as these would not be accepted when dropping into file
3902         inputs, or be exposed as files on DataTransfer.
3903
3904         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3905         (TestWebKitAPI::TEST):
3906
3907 2018-12-10  David Kilzer  <ddkilzer@apple.com>
3908
3909         Injected bundle for WebKitTestRunner leaks WKTypeRef objects
3910         <https://webkit.org/b/192481>
3911         <rdar://problem/46539059>
3912
3913         Follow-up to address Darin's feedback.
3914
3915         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3916         (WTR::TestRunner::shouldDumpPixels const):
3917         (WTR::TestRunner::whatToDump const):
3918         (WTR::TestRunner::shouldWaitUntilDone const):
3919         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
3920         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
3921         (WTR::TestRunner::secureEventInputIsEnabled const):
3922         (WTR::TestRunner::isStatisticsPrevalentResource):
3923         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
3924         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
3925         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
3926         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
3927         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
3928         (WTR::TestRunner::isStatisticsGrandfathered):
3929         (WTR::TestRunner::hasDOMCache):
3930         (WTR::TestRunner::keyExistsInKeychain):
3931
3932 2018-12-10  Jonathan Bedard  <jbedard@apple.com>
3933
3934         webkitpy: Ref tests don't respect platform specific expectations
3935         https://bugs.webkit.org/show_bug.cgi?id=192515
3936         <rdar://problem/46564839>
3937
3938         Reviewed by Lucas Forschler.
3939
3940         * Scripts/webkitpy/port/base.py:
3941         (Port._expected_baselines_for_suffixes): Accept multiple suffixes so ref tests can use this function.
3942         (Port.expected_baselines): Move implementation to _expected_baselines_for_suffixes.
3943         (Port.expected_filename): Remove irrelevant FIXME, code clean-up.
3944         (Port.reference_files): Instead of just searching a single directory, use _expected_baselines_for_suffixes to
3945         search all platform expectations as well.
3946         * Scripts/webkitpy/port/base_unittest.py:
3947         (test_ref_tests_platform_directory):
3948
3949 2018-12-10  Chris Dumez  <cdumez@apple.com>
3950
3951         Add SPI to allow the client to set the user-agent at main frame level, from the UIProcess
3952         https://bugs.webkit.org/show_bug.cgi?id=192509
3953         <rdar://problem/46500832>
3954
3955         Reviewed by Alex Christensen.
3956
3957         Add API test coverage.
3958
3959         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3960         (-[DataMappingSchemeHandler addMappingFromURLString:toData:]):
3961         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3962         (-[DataMappingSchemeHandler webView:stopURLSchemeTask:]):
3963         (-[CustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3964         (-[CustomUserAgentDelegate webView:didFinishNavigation:]):
3965
3966 2018-12-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3967
3968         [iOS] Caret is obscured by finger when dragging over an editable element
3969         https://bugs.webkit.org/show_bug.cgi?id=192499
3970         <rdar://problem/46570101>
3971
3972         Reviewed by Tim Horton.
3973
3974         Augment some existing API tests to check that the `precise` flag is either on or off on `UIDropProposal`.
3975
3976         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3977         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3978         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3979         (-[DragAndDropSimulator _resetSimulatedState]):
3980         (-[DragAndDropSimulator lastKnownDropProposal]):
3981
3982         Rename `currentDropProposal` to `lastKnownDropProposal`, and expose it as a readonly property.
3983
3984         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
3985         (-[DragAndDropSimulator _advanceProgress]):
3986         (-[DragAndDropSimulator setShowCustomActionSheetBlock:]):
3987         (-[DragAndDropSimulator showCustomActionSheetBlock]):
3988         (-[DragAndDropSimulator setConvertItemProvidersBlock:]):
3989         (-[DragAndDropSimulator convertItemProvidersBlock]):
3990         (-[DragAndDropSimulator setOverridePerformDropBlock:]):
3991         (-[DragAndDropSimulator overridePerformDropBlock]):
3992         (-[DragAndDropSimulator setOverrideDragUpdateBlock:]):
3993         (-[DragAndDropSimulator overrideDragUpdateBlock]):
3994         (-[DragAndDropSimulator setDropCompletionBlock:]):
3995         (-[DragAndDropSimulator dropCompletionBlock]):
3996
3997         Refactor these properties to return and take normal Objective-C blocks, rather than `BlockPtr`s. However, use
3998         `BlockPtr` instance variables to manage the lifetimes of these blocks.
3999
4000         (-[DragAndDropSimulator _webView:willUpdateDropProposalToProposal:forSession:]):
4001         (-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]): Deleted.
4002
4003         Update this to use the new WebKit delegate hook for overriding the drop proposal.
4004
4005 2018-12-10  Michael Catanzaro  <mcatanzaro@igalia.com>
4006
4007         [WPE][GTK] run-minibrowser improperly creates webkit-flatpak environment
4008         https://bugs.webkit.org/show_bug.cgi?id=190241
4009
4010         Reviewed by Carlos Garcia Campos.
4011
4012         run-minibrowser calls into webkit-flatpak to check if a flatpak environment is available.
4013         Currently this actually creates the directories needed for the flatpak environment. Fix it.
4014
4015         * flatpak/flatpakutils.py:
4016         (WebkitFlatpak.clean_args):
4017         (WebkitFlatpak.run):
4018
4019 2018-12-10  Michael Catanzaro  <mcatanzaro@igalia.com>
4020
4021         [GTK] Don't use the slice allocator
4022         https://bugs.webkit.org/show_bug.cgi?id=192360
4023
4024         Reviewed by Carlos Garcia Campos.
4025
4026         * MiniBrowser/gtk/main.c:
4027         (aboutDataRequestFree):
4028         (aboutDataRequestNew):
4029
4030 2018-12-10  Tim Horton  <timothy_horton@apple.com>
4031
4032         WKWebView should support custom tintColor
4033         https://bugs.webkit.org/show_bug.cgi?id=192518
4034         <rdar://problem/37243261>
4035
4036         Reviewed by Wenson Hsieh.
4037
4038         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
4039         (TestWebKitAPI::TEST):
4040         Add a test that tintColor affects UITextInputTraits' interaction colors.
4041
4042 2018-12-09  Wenson Hsieh  <wenson_hsieh@apple.com>
4043
4044         [iOS] DragAndDropTests.RespectsExternalSourceFidelityRankings is flaky
4045         https://bugs.webkit.org/show_bug.cgi?id=192524
4046
4047         Reviewed by Ryosuke Niwa.
4048
4049         This test started failing on certain builds of iOS where UIKit now attempts to reveal the selection by scrolling
4050         (see <rdar://problem/28300343>). This API test simulates two drops from external sources, both from the point
4051         (300, 400) to (100, 300) in window coordinates. On these aforementioned builds of iOS, what happens is that the
4052         first drop inserts text that overflows the editable region by an enormous amount, which creates an extremely
4053         wide selection rect and increases the width of the document; revealing this selection causes the web view to
4054         scroll horizontally, such that the second attempt to simulate a drag from (300, 400) to (100, 300) fails, since
4055         these window coordinates no longer correspond to the drop destination element in the document.
4056
4057         To fix this test, we simply mark the drop destination as `overflow: hidden` to ensure that we don't try and
4058         scroll horizontally after the first drop.
4059
4060         * TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html:
4061
4062 2018-12-08  Daniel Bates  <dabates@apple.com>
4063
4064         Fix lldb_webkit.py following r238771
4065         (https://bugs.webkit.org/show_bug.cgi?id=190234)
4066
4067         Substitute WTFURLProvider for WebCoreURLProvider in one call site that was inadvertently
4068         missed in r238771.
4069
4070         * lldb/lldb_webkit.py:
4071         (WebCoreDocumentProvider.url):
4072
4073 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4074
4075         [ews-build] check-patch-relevance failure should not mark the overall build as failure
4076         https://bugs.webkit.org/show_bug.cgi?id=192510
4077
4078         Reviewed by Lucas Forschler.
4079
4080         * BuildSlaveSupport/ews-build/steps.py:
4081         (CheckPatchRelevance.start):
4082
4083 2018-12-07  Chris Dumez  <cdumez@apple.com>
4084
4085         ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
4086         https://bugs.webkit.org/show_bug.cgi?id=192362
4087         <rdar://problem/46460360>
4088
4089         Reviewed by Ryosuke Niwa.
4090
4091         Move the call to _setCookieAcceptPolicy *after* we've constructed a WKWebView and thus
4092         *after* we know for sure we have a network process to communicate the policy to.
4093         This should address the failures on iOS.
4094
4095         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4096
4097 2018-12-07  Jiewen Tan  <jiewen_tan@apple.com>
4098
4099         Add keychain access entitlement to WebKitTestRunnerApp
4100         https://bugs.webkit.org/show_bug.cgi?id=192489
4101         <rdar://problem/45057952>
4102
4103         Reviewed by Alexey Proskuryakov.
4104
4105         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
4106
4107 2018-12-07  Saam Barati  <sbarati@apple.com>
4108
4109         WKWebProcessPlugInLoadDelegate should have API for saying which rendering events it wants to listen for
4110         https://bugs.webkit.org/show_bug.cgi?id=192473
4111
4112         Reviewed by Andy Estes.
4113
4114         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4115         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgress.mm: Added.
4116         (-[DidFirstMeaningfulPaintRemoteObject didFirstMeaningfulPaint]):
4117         (TEST):
4118         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressPlugIn.mm: Added.
4119         (-[RenderingProgressPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4120         (-[RenderingProgressPlugIn webProcessPlugInBrowserContextControllerRenderingProgressEvents:]):
4121         (-[RenderingProgressPlugIn webProcessPlugInBrowserContextController:renderingProgressDidChange:]):
4122         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressProtocol.h: Added.
4123
4124 2018-12-07  Jonathan Bedard  <jbedard@apple.com>
4125
4126         REGRESSION: run-webkit-tests may fail when using booted simulators (Follow-up fix)
4127         https://bugs.webkit.org/show_bug.cgi?id=192470
4128         <rdar://problem/46532001>
4129
4130         Unreviewed infrastructure fix.
4131
4132         * Scripts/webkitpy/port/device_port.py:
4133         (DevicePort.setup_test_run): Check that the number of initialized devices matches the
4134         number of child processes.
4135
4136 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4137
4138         [ews-app] Send bug id as a build property
4139         https://bugs.webkit.org/show_bug.cgi?id=192494
4140
4141         Reviewed by Lucas Forschler.
4142
4143         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4144         (BugzillaPatchFetcher.fetch):
4145
4146 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4147
4148         [ews-build] Builds should have a link to patch and bug
4149         https://bugs.webkit.org/show_bug.cgi?id=192492
4150
4151         Reviewed by Lucas Forschler.
4152
4153         * BuildSlaveSupport/ews-build/steps.py:
4154         (ConfigureBuild.add_patch_id_url): Method to add Patch URL.
4155         (ConfigureBuild.add_bug_id_url): Method to add Bug URL.
4156         (ConfigureBuild.getPatchURL): Method to get Patch URL.
4157         (ConfigureBuild.getBugURL): Method to get Bug URL.
4158
4159 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4160
4161         [ews-app] Configure logfile for ews-app logs
4162         https://bugs.webkit.org/show_bug.cgi?id=192493
4163
4164         Reviewed by Lucas Forschler.
4165
4166         * BuildSlaveSupport/ews-app/ews/__init__.py:
4167
4168 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4169
4170         Style queue exception on some security bugs
4171         https://bugs.webkit.org/show_bug.cgi?id=190793
4172
4173         Reviewed by Lucas Forschler.
4174
4175         * Scripts/webkitpy/tool/steps/applywatchlist.py:
4176         (ApplyWatchList.run):
4177
4178 2018-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
4179
4180         [Attachment Support] Cloned attachment elements lose their unique identifiers
4181         https://bugs.webkit.org/show_bug.cgi?id=192483
4182
4183         Reviewed by Tim Horton.
4184
4185         Introduce a new API test.
4186
4187         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4188         (TestWebKitAPI::TEST):
4189
4190 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
4191
4192         Consecutive DumpRenderTree crashes are happening again on WinCairo BuildBots since r238903
4193         https://bugs.webkit.org/show_bug.cgi?id=192486
4194
4195         Unreviewed infrastructure fix.
4196
4197         WinCairo bots define WEBKIT_TEST_CHILD_PROCESSES to run less processes due to RAM restrictions.
4198
4199         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4200         (_set_up_derived_options):
4201
4202 2018-12-06  David Kilzer  <ddkilzer@apple.com>
4203
4204         Injected bundle for WebKitTestRunner leaks WKTypeRef objects
4205         <https://webkit.org/b/192481>
4206         <rdar://problem/46539059>
4207
4208         Reviewed by Simon Fraser.
4209
4210         This patch:
4211         - Fixes leaks in various injected bundle methods that return +1
4212           retained WKTypeRef objects via pointer.
4213         - Asserts the returned object is the expected WKTypeRef.
4214         - Replaces 0 with nullptr in many places.
4215
4216         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4217         (WTR::InjectedBundle::didCreatePage):
4218         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4219         (WTR::TestRunner::shouldDumpPixels const):
4220         (WTR::TestRunner::whatToDump const):
4221         (WTR::TestRunner::shouldWaitUntilDone const):
4222         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
4223         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
4224         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
4225         (WTR::TestRunner::secureEventInputIsEnabled const):
4226         (WTR::TestRunner::isStatisticsPrevalentResource):
4227         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
4228         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
4229         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
4230         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
4231         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
4232         (WTR::TestRunner::isStatisticsGrandfathered):
4233         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
4234         (WTR::TestRunner::statisticsUpdateCookieBlocking):
4235         (WTR::TestRunner::statisticsSubmitTelemetry):
4236         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
4237         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
4238         (WTR::TestRunner::statisticsResetToConsistentState):
4239         (WTR::TestRunner::getAllStorageAccessEntries):
4240         (WTR::TestRunner::hasDOMCache):
4241         (WTR::TestRunner::domCacheSize):
4242         (WTR::TestRunner::injectUserScript):
4243         (WTR::TestRunner::keyExistsInKeychain):
4244
4245 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
4246
4247         REGRESSION: run-webkit-tests may fail when using booted simulators
4248         https://bugs.webkit.org/show_bug.cgi?id=192470
4249         <rdar://problem/46532001>
4250
4251         Reviewed by Lucas Forschler.
4252
4253         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4254         (Manager.run): Logging uses the number of child processes to print out information about how efficiently tests
4255         were sharded after the fact. This number is the most meaningful if it is the maximum number of child processes used.
4256         * Scripts/webkitpy/port/base.py:
4257         (Port.max_child_processes): By default, Ports do not support running on any specific kind of device.
4258         * Scripts/webkitpy/port/device_port.py:
4259         (DevicePort.default_child_processes): Rather than using the currently initialized devices as a proxy for how many
4260         child processes are being used, check the device manager every time. Regardless of which devices are attached or
4261         available, iOS cannot boot watchOS devices and vice-versa. dedicated_simulators is not a known argument to
4262         device_count_for_type, use use_booted_simulator instead.
4263         (DevicePort.max_child_processes): Simulators can boot more devices than what is specified by device_count_for_type,
4264         but, if no devices are available, then max_child_processes should return 0 even for simulators.
4265         * Scripts/webkitpy/port/ios_device_unittest.py:
4266         (IOSDeviceTest):
4267         (IOSDeviceTest.test_max_child_processes):
4268         * Scripts/webkitpy/port/ios_simulator_unittest.py:
4269         (IOSSimulatorTest):
4270         (IOSSimulatorTest.test_max_child_processes):
4271         * Scripts/webkitpy/port/port_testcase.py:
4272         (PortTestCase):
4273         (PortTestCase.test_max_child_processes):
4274         * Scripts/webkitpy/port/watch_simulator_unittest.py:
4275         (WatchSimulatorTest):
4276         (WatchSimulatorTest.test_max_child_processes):
4277
4278 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
4279
4280         webkitpy: Ignore case when comparing device types (Follow-up fix)
4281         https://bugs.webkit.org/show_bug.cgi?id=192409
4282         <rdar://problem/46491558>
4283
4284         Unreviewed typo fix.
4285
4286         * Scripts/webkitpy/xcode/device_type_unittest.py:
4287         (DeviceTypeTest.test_comparison_lower_case):
4288         (DeviceTypeTest.test_comparsion_lower_case): Deleted.
4289
4290 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
4291
4292         webkitpy: Create device given lower-case DeviceType
4293         <https://bugs.webkit.org/show_bug.cgi?id=192472>
4294         <rdar://problem/46532650>
4295
4296         Reviewed by Lucas Forschler.
4297