[GTK] Implement back/forward touchpad gesture
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2
3         [GTK] Implement back/forward touchpad gesture
4         https://bugs.webkit.org/show_bug.cgi?id=193919
5
6         Reviewed by Michael Catanzaro.
7
8         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
9         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
10
11 2019-02-08  Alex Christensen  <achristensen@webkit.org>
12
13         Add SPI to use networking daemon instead of XPC service
14         https://bugs.webkit.org/show_bug.cgi?id=194427
15
16         Reviewed by Geoffrey Garen
17
18         * MiniBrowser/MiniBrowser.entitlements:
19
20 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
21
22         [ews-build] Ensure that every builder in config.json has short name
23         https://bugs.webkit.org/show_bug.cgi?id=194461
24
25         Reviewed by Lucas Forschler.
26
27         * BuildSlaveSupport/ews-build/loadConfig.py:
28         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
29
30 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
31
32         [ews-build] Add short name to config.json
33         https://bugs.webkit.org/show_bug.cgi?id=194456
34
35         Reviewed by Lucas Forschler.
36
37         * BuildSlaveSupport/ews-build/config.json: Added short name.
38         * BuildSlaveSupport/ews-build/loadConfig.py:
39         (loadBuilderConfig): Set the short name as the builder description.
40
41 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
42
43         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
44         https://bugs.webkit.org/show_bug.cgi?id=194418
45
46         Reviewed by Lucas Forschler.
47
48         Do not include errors trying when finding crashlogs at the end of
49         a run-webkit-tests run since we don't process those errors.
50
51         * Scripts/webkitpy/port/darwin.py:
52         (DarwinPort._look_for_all_crash_logs_in_log_dir):
53         * Scripts/webkitpy/port/ios_device.py:
54         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
55         * Scripts/webkitpy/port/watch_device.py:
56         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
57
58 2019-02-08  Beth Dakin  <bdakin@apple.com>
59
60         Add afterScreenUpdates to WKSnapshotConfiguration
61         https://bugs.webkit.org/show_bug.cgi?id=194362
62         -and corresponding-
63         <rdar://problem/40655528> Please add an "after screen updates" property to 
64         WKSnapshotConfiguration (to solve blank snapshots)
65
66         Reviewed by Tim Horton.
67
68         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
69         (TEST):
70
71 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
72
73         clampTo(): do not convert the input to double when dealing with integers
74         https://bugs.webkit.org/show_bug.cgi?id=194263
75         <rdar://problem/47692312>
76
77         Reviewed by Darin Adler.
78
79         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
80         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
81         (TestWebKitAPI::testClampFloatingPointToInteger):
82         (TestWebKitAPI::testClampSameSignIntegers):
83         (TestWebKitAPI::testClampUnsignedToSigned):
84         (TestWebKitAPI::testClampSignedToUnsigned):
85
86 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
87
88         webkitpy: Respect --dedicated-simulators flag
89         https://bugs.webkit.org/show_bug.cgi?id=194416
90         <rdar://problem/47894722>
91
92         Reviewed by Lucas Forschler.
93
94         * Scripts/webkitpy/port/device_port.py:
95         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
96         available devices can be safely ignored.
97
98 2019-02-07  Keith Rollin  <krollin@apple.com>
99
100         Remove extra copy of 100x100-red.tga
101         https://bugs.webkit.org/show_bug.cgi?id=194371
102         <rdar://problem/47873465>
103
104         Reviewed by Said Abou-Hallawa.
105
106         In order to help it pass its tests, Bug 194190 added a second copy of
107         the file 100x100-red.tga. However, it turns out that this additional
108         file wasn't actually needed, and that that sole previous copy was
109         sufficient. At the same time, this second copy -- which was copied to
110         the same location in the build output as the first copy -- now caused
111         XCBuild to complain because there were two production rules for the
112         same output file. Address this by removing the newly-added extra copy.
113
114         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
115         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
116
117 2019-02-07  Alex Christensen  <achristensen@webkit.org>
118
119         Deprecate WKBundlePageSetDefersLoading
120         https://bugs.webkit.org/show_bug.cgi?id=191394
121
122         Reviewed by Dean Jackson.
123
124         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
125         (WTR::TestRunner::setDefersLoading):
126
127 2019-02-07  Zalan Bujtas  <zalan@apple.com>
128
129         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
130         https://bugs.webkit.org/show_bug.cgi?id=194391
131
132         Reviewed by Antti Koivisto.
133
134         * LayoutReloaded/misc/LFC-passing-tests.txt:
135
136 2019-02-06  Keith Rollin  <krollin@apple.com>
137
138         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
139         https://bugs.webkit.org/show_bug.cgi?id=193975
140         <rdar://problem/47643306>
141
142         Reviewed by Tim Horton.
143
144         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
145         the Info.plist file into the bundle. This step is not necessary as the
146         implicit "bundle up all the build products into a framework" build
147         phase does this already. Having the Copy Bundle Resources phase do
148         this causes a conflict under XCBuild, which objects to two build
149         phases producing the same file (Info.plist). Address this by removing
150         Info.plist from the Copy Bundle Resources phase.
151
152         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
153
154 2019-02-06  Keith Rollin  <krollin@apple.com>
155
156         Really enable the automatic checking and regenerations of .xcfilelists during builds
157         https://bugs.webkit.org/show_bug.cgi?id=194357
158         <rdar://problem/47861231>
159
160         Reviewed by Chris Dumez.
161
162         Bug 194124 was supposed to enable the automatic checking and
163         regenerating of .xcfilelist files during the build. While related
164         changes were included in that patch, the change to actually enable the
165         operation somehow was omitted. This patch actually enables the
166         operation. The check-xcfilelist.sh scripts now check
167         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
168         from the checking.
169
170         * DumpRenderTree/Scripts/check-xcfilelists.sh:
171         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
172
173 2019-02-06  David Kilzer  <ddkilzer@apple.com>
174
175         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
176         <https://webkit.org/b/194286>
177         <rdar://problem/47815558>
178
179         Reviewed by Alexey Proskuryakov.
180
181         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
182         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
183         WKRetainPtr<> to avoid leaking the WKDataRef.
184
185 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
186
187         Unreviewed, fix a typo
188
189         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
190
191 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
192
193         [GTK][WPE] force libpsl build to use ICU in jhbuild
194         https://bugs.webkit.org/show_bug.cgi?id=194288
195
196         Reviewed by Carlos Garcia Campos.
197
198         * gtk/jhbuild.modules:
199         Require ICU for libpsl build in jhbuild, like done in WPE.
200
201 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
202
203         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
204         https://bugs.webkit.org/show_bug.cgi?id=194209
205
206         Reviewed by Carlos Garcia Campos.
207
208         Enhance TestCookieManager to ensure this doesn't happen again.
209
210         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
211         (testCookieManagerPersistentStorage):
212         (beforeAll):
213
214 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
215
216         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
217         https://bugs.webkit.org/show_bug.cgi?id=194324
218
219         Reviewed by Andy Estes.
220
221         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
222         part of the name is already implicit, since this is in testing code in TestOptions.
223
224         * WebKitTestRunner/TestController.cpp:
225         (WTR::TestController::generateContextConfiguration const):
226         (WTR::updateTestOptionsFromTestHeader):
227         * WebKitTestRunner/TestOptions.h:
228         (WTR::TestOptions::hasSameInitializationOptions const):
229
230 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
231
232         [ews-build] Allow * as platform for builders and workers
233         https://bugs.webkit.org/show_bug.cgi?id=188533
234
235         Reviewed by Lucas Forschler.
236
237         * BuildSlaveSupport/ews-build/loadConfig.py:
238         (checkWorkersAndBuildersForConsistency):
239
240 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
241
242         [ews-build] Add few bots to config.json
243         https://bugs.webkit.org/show_bug.cgi?id=194304
244
245         Reviewed by Lucas Forschler.
246
247         * BuildSlaveSupport/ews-build/config.json:
248
249 2019-02-05  Keith Rollin  <krollin@apple.com>
250
251         Enable the automatic checking and regenerations of .xcfilelists during builds
252         https://bugs.webkit.org/show_bug.cgi?id=194124
253         <rdar://problem/47721277>
254
255         Reviewed by Tim Horton.
256
257         Bug 193790 add a facility for checking -- during build time -- that
258         any needed .xcfilelist files are up-to-date and for updating them if
259         they are not. This facility was initially opt-in by setting
260         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
261         the process seemed robust. Its now time to enable this facility and
262         make it opt-out. If there is a need to disable this facility, set and
263         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
264         running `make` or `build-webkit`, or before running Xcode from the
265         command line.
266
267         Additionally, remove the step that generates a list of source files
268         going into the UnifiedSources build step. It's only necessarily to
269         specify Sources.txt and SourcesCocoa.txt as inputs.
270
271         * Scripts/generate-xcfilelists:
272
273 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
274
275         [GTK][WPE] force libpsl build to use ICU in jhbuild
276         https://bugs.webkit.org/show_bug.cgi?id=194288
277
278         Reviewed by Philippe Normand.
279
280         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
281         This can cause build failures if libidn is detected but libunistring is not available.
282
283         Make sure that ICU is used for runtime and builtin PSL data.
284
285         * gtk/jhbuild.modules:
286         * wpe/jhbuild.modules:
287
288 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
289
290         [ews-app] Modified timestamp should be updated on updating data
291         https://bugs.webkit.org/show_bug.cgi?id=194295
292
293         Reviewed by Lucas Forschler.
294
295         * BuildSlaveSupport/ews-app/ews/models/build.py:
296         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
297         * BuildSlaveSupport/ews-app/ews/models/step.py:
298
299 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
300
301         Unreviewed, rolling out r240742.
302
303         Causes crashes on iOS simulator.
304
305         Reverted changeset:
306
307         "[iOS] Keyups for non-modifier keys identified as "Dead" when
308         not focused in a content-editable element"
309         https://bugs.webkit.org/show_bug.cgi?id=192824
310         https://trac.webkit.org/changeset/240742
311
312 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
313
314         run-webkit-tests emits message "...running None" when running tests
315         https://bugs.webkit.org/show_bug.cgi?id=194133
316         <rdar://problem/47724738>
317
318         Reviewed by Lucas Forschler.
319
320         * Scripts/webkitpy/xcode/device_type.py:
321         (DeviceType.__str__): Use both version mapping tables and use just the variant
322         name if no version name is available.
323         * Scripts/webkitpy/xcode/device_type_unittest.py:
324         (DeviceTypeTest):
325         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
326         an associated named.
327
328 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
329
330         [WPE] require python3-setuptools for meson build in jhbuild
331         https://bugs.webkit.org/show_bug.cgi?id=194287
332
333         Reviewed by Philippe Normand.
334
335         python3-setuptools is needed to build meson in jhbuild.
336         It is already required by the GTK port.
337
338         * wpe/install-dependencies:
339
340 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
341
342         [ews-app] Add method to save BuilderMapping to database
343         https://bugs.webkit.org/show_bug.cgi?id=194264
344
345         Reviewed by Lucas Forschler.
346
347         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
348         (BuilderMapping.__str__):
349         (BuilderMapping):
350         (BuilderMapping.save_mapping):
351         (BuilderMapping.update_mapping):
352         (BuilderMapping.get_existing_mapping):
353         (BuilderMapping.is_valid_mapping):
354
355 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
356
357         [ews-app] Add timestamp fields for BuilderMappings
358         https://bugs.webkit.org/show_bug.cgi?id=194266
359
360         Reviewed by Lucas Forschler.
361
362         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
363         (BuilderMapping):
364
365 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
366
367         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
368         https://bugs.webkit.org/show_bug.cgi?id=174816
369
370         Reviewed by Michael Catanzaro.
371
372         Add tests for webkit_uri_for_display().
373
374         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
375         (testURIForDisplayUnaffected):
376         (testURIForDisplayAffected):
377         (beforeAll):
378         (afterAll):
379         * TestWebKitAPI/glib/CMakeLists.txt:
380
381 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
382
383         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
384         https://bugs.webkit.org/show_bug.cgi?id=194158
385         <rdar://problem/47737268>
386
387         Rubber-stamped by Aakash Jain.
388
389         * Scripts/webkitpy/port/device_port.py:
390         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
391
392 2019-02-04  Said Abou-Hallawa  <said@apple.com>
393
394         [CG] Enable setAdditionalSupportedImageTypes for WK1
395         https://bugs.webkit.org/show_bug.cgi?id=194190
396
397         Reviewed by Tim Horton.
398
399         Add a test similar to the one under WebKit Cocoa but make it create a
400         WebView instead of a WKWebView.
401
402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
403         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
404         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
405         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
406         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
407         (TestWebKitAPI::runTest):
408         (TestWebKitAPI::TEST):
409
410 2019-02-04  Zalan Bujtas  <zalan@apple.com>
411
412         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
413         https://bugs.webkit.org/show_bug.cgi?id=194168
414
415         Reviewed by Simon Fraser.
416
417         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
418
419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
420         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
421         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
422         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
423         (TEST):
424         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
425         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
426
427 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
428
429         REGRESSION (r237269): webkit-patch what-broke is broken 
430         https://bugs.webkit.org/show_bug.cgi?id=193025
431
432         Reviewed by Aakash Jain.
433
434         * Scripts/webkitpy/common/host.py:
435         (Host.buildbot):
436         (Host.bugzilla): Renamed to 'buildbot'.
437
438 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
439
440         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
441         https://bugs.webkit.org/show_bug.cgi?id=194207
442
443         Reviewed by Tim Horton.
444
445         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
446         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
447         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
448         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
449         start and delete forwards to remove the original attachment.
450
451         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
452         (TestWebKitAPI::TEST):
453
454 2019-02-04  Youenn Fablet  <youenn@apple.com>
455
456         Capture state should be managed consistently when doing process swapping
457         https://bugs.webkit.org/show_bug.cgi?id=194122
458         <rdar://problem/47609293>
459
460         Reviewed by Eric Carlson.
461
462         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
463         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
464         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
465         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
466         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
467         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
468         (WTR::TestRunner::isDoingMediaCapture const):
469         * WebKitTestRunner/InjectedBundle/TestRunner.h:
470         * WebKitTestRunner/TestController.cpp:
471         (WTR::TestController::isDoingMediaCapture const):
472         * WebKitTestRunner/TestController.h:
473         * WebKitTestRunner/TestInvocation.cpp:
474         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
475         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
476         (WTR::TestController::isDoingMediaCapture const):
477
478 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
479
480         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
481         https://bugs.webkit.org/show_bug.cgi?id=194142
482
483         Reviewed by Ross Kirsling.
484
485         There three 'separator' variables in TestController.cpp. Renamed
486         it 'pathSeparator', and unified them.
487
488         * WebKitTestRunner/TestController.cpp:
489         (WTR::TestController::generateContextConfiguration const):
490         (WTR::createTestURL):
491         (WTR::TestController::platformAdjustContext):
492
493 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
494
495         Make setNeedsLayout on the root more explicitly about triggering its side-effects
496         https://bugs.webkit.org/show_bug.cgi?id=194198
497
498         Reviewed by Antti Koivisto.
499
500         No need to set the banner heights on navigation now, since Page stores them.
501
502         * MiniBrowser/mac/WK2BrowserWindowController.m:
503         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
504
505 2019-02-03  John Wilander  <wilander@apple.com>
506
507         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
508         https://bugs.webkit.org/show_bug.cgi?id=194104
509         <rdar://problem/47649991>
510
511         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
512
513         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
514         (TestWebKitAPI::TEST):
515             Changed numeric types from unsigned short to uint32_t.
516
517 2019-02-02  David Kilzer  <ddkilzer@apple.com>
518
519         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
520         <https://webkit.org/b/194178>
521         <rdar://problem/47753473>
522
523         Reviewed by Alexey Proskuryakov.
524
525         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
526         (WTR::uninstallFakeHelvetica): Pass nullptr into
527         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
528
529 2019-02-02  Zalan Bujtas  <zalan@apple.com>
530
531         [LFC] Initialize ICB's style with fixed width/height.
532         https://bugs.webkit.org/show_bug.cgi?id=194188
533
534         Reviewed by Antti Koivisto.
535
536         * LayoutReloaded/misc/LFC-passing-tests.txt:
537
538 2019-02-02  Zalan Bujtas  <zalan@apple.com>
539
540         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
541         https://bugs.webkit.org/show_bug.cgi?id=194185
542
543         Reviewed by Antti Koivisto.
544
545         * LayoutReloaded/misc/LFC-passing-tests.txt:
546
547 2018-12-16  Darin Adler  <darin@apple.com>
548
549         Convert additional String::format clients to alternative approaches
550         https://bugs.webkit.org/show_bug.cgi?id=192746
551
552         Reviewed by Alexey Proskuryakov.
553
554         * WebKitTestRunner/TestController.cpp:
555         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
556         as an intermediate in code that ultimately constructs a WTF::String.
557         (WTR::userMediaOriginHash): Use makeString.
558         (WTR::TestController::didNavigateWithNavigationData): More of the same.
559         (WTR::TestController::didPerformClientRedirect): Ditto.
560         (WTR::TestController::didPerformServerRedirect): Ditto.
561         (WTR::TestController::didUpdateHistoryTitle): Ditto.
562
563 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
564
565         [ews-build] Add unit test to verify builder keys
566         https://bugs.webkit.org/show_bug.cgi?id=194152
567
568         Reviewed by Lucas Forschler.
569
570         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
571         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
572
573 2019-02-01  Zalan Bujtas  <zalan@apple.com>
574
575         [LFC] Expand tests coverage (12 new tests -> 787)
576
577         Unreviewed test gardening.
578
579         * LayoutReloaded/misc/LFC-passing-tests.txt:
580
581 2019-02-01  Zalan Bujtas  <zalan@apple.com>
582
583         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
584         https://bugs.webkit.org/show_bug.cgi?id=194163
585
586         Reviewed by Simon Fraser.
587
588         775
589
590         * LayoutReloaded/misc/LFC-passing-tests.txt:
591
592 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
593
594         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
595         https://bugs.webkit.org/show_bug.cgi?id=194140
596         <rdar://problem/47728098>
597
598         Reviewed by Tim Horton.
599
600         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
601         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
602         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
603
604         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
605         test to induce an IPC deadlock when presenting a modal alert during touch start.
606
607         * WebKitTestRunner/InjectedBundle/TestRunner.h:
608         * WebKitTestRunner/TestController.cpp:
609         (WTR::runJavaScriptAlert):
610
611         Add a client callback function for running JavaScript alerts.
612
613         (WTR::TestController::createOtherPage):
614         (WTR::TestController::generateContextConfiguration const):
615
616         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
617         the fix in this patch.
618
619         (WTR::TestController::createWebViewWithOptions):
620
621         Plumb TestOptions to generateContextConfiguration.
622
623         (WTR::TestController::resetPreferencesToConsistentValues):
624         (WTR::TestController::resetStateToConsistentValues):
625         (WTR::updateTestOptionsFromTestHeader):
626         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
627         (WTR::TestController::handleJavaScriptAlert):
628         * WebKitTestRunner/TestController.h:
629         * WebKitTestRunner/TestInvocation.cpp:
630         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
631         * WebKitTestRunner/TestOptions.h:
632         (WTR::TestOptions::hasSameInitializationOptions const):
633
634 2019-02-01  Chris Dumez  <cdumez@apple.com>
635
636         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
637         https://bugs.webkit.org/show_bug.cgi?id=193740
638         <rdar://problem/47527267>
639
640         Reviewed by Alex Christensen.
641
642         Add API test coverage.
643
644         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
645
646 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
647
648         [ews-app] Add display name field to BuilderMapping model
649         https://bugs.webkit.org/show_bug.cgi?id=194153
650
651         Reviewed by Lucas Forschler.
652
653         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
654         (BuilderMapping):
655
656 2019-02-01  Youenn Fablet  <youenn@apple.com>
657
658         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
659         https://bugs.webkit.org/show_bug.cgi?id=194155
660
661         Reviewed by Eric Carlson.
662
663         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
664         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
665         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
666
667 2019-02-01  Zalan Bujtas  <zalan@apple.com>
668
669         [LFC] Adjust replaced element's intrinsic ratio
670         https://bugs.webkit.org/show_bug.cgi?id=194154
671
672         Reviewed by Antti Koivisto.
673
674         761
675
676         * LayoutReloaded/misc/LFC-passing-tests.txt:
677
678 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
679
680         [WPE] Show test results in minibrowser
681         https://bugs.webkit.org/show_bug.cgi?id=194150
682
683         Reviewed by Žan Doberšek.
684
685         * Scripts/webkitpy/port/wpe.py:
686         (WPEPort.show_results_html_file):
687
688 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
689
690         [WPE] MiniBrowser: add ky bindings for back/forward navigation
691         https://bugs.webkit.org/show_bug.cgi?id=194151
692
693         Reviewed by Žan Doberšek.
694
695         ALT + <- go back
696         ALT + -> go forward
697
698         * MiniBrowser/wpe/main.cpp:
699         (main):
700
701 2019-02-01  Zalan Bujtas  <zalan@apple.com>
702
703         [LFC] Set intrinsic size on Layout::Replaced
704         https://bugs.webkit.org/show_bug.cgi?id=194139
705
706         Reviewed by Antti Koivisto.
707
708         744
709
710         * LayoutReloaded/misc/LFC-passing-tests.txt:
711
712 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
713
714         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
715         https://bugs.webkit.org/show_bug.cgi?id=194146
716
717         Reviewed by Xabier Rodriguez-Calvar.
718
719         It allows to open relative paths.
720
721         * MiniBrowser/wpe/main.cpp:
722         (main):
723
724 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
725
726         Update flakiness dashboard configuration after recent queue changes
727         https://bugs.webkit.org/show_bug.cgi?id=194127
728
729         Rubber-stamped by Aakash Jain.
730
731         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
732
733         * TestResultServer/static-dashboards/builders.jsonp:
734
735 2019-01-31  Youenn Fablet  <youenn@apple.com>
736
737         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
738         https://bugs.webkit.org/show_bug.cgi?id=194106
739         <rdar://problem/47676333>
740
741         Reviewed by Ryosuke Niwa.
742
743         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
744         (TestWebKitAPI::didFinishNavigation):
745         (TestWebKitAPI::TEST):
746         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
747
748 2019-01-31  Chris Dumez  <cdumez@apple.com>
749
750         Page zoom level is lost after a process swap or a crash
751         https://bugs.webkit.org/show_bug.cgi?id=194105
752         <rdar://problem/47610781>
753
754         Reviewed by Alex Christensen.
755
756         Add API test coverage.
757
758         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
759         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
760
761 2019-01-31  Alex Christensen  <achristensen@webkit.org>
762
763         Revert r238819 which is unneeded and caused a performance regression.
764         https://bugs.webkit.org/show_bug.cgi?id=192272
765         <rdar://problem/46664625>
766
767         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
768         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
769         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
770
771 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
772
773         Formalize WebKitAdditions mechanism of LoadOptimizer
774         https://bugs.webkit.org/show_bug.cgi?id=193886
775         <rdar://problem/47696809>
776
777         Reviewed by Brent Fulgham.
778
779         * MiniBrowser/MiniBrowser.entitlements:
780         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
781
782 2019-01-31  Zalan Bujtas  <zalan@apple.com>
783
784         [LFC] Margin before/after/start/end initial value is 0 and not auto.
785         https://bugs.webkit.org/show_bug.cgi?id=194090
786
787         Reviewed by Antti Koivisto.
788
789         * LayoutReloaded/misc/LFC-passing-tests.txt:
790
791 2019-01-31  Zalan Bujtas  <zalan@apple.com>
792
793         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
794         https://bugs.webkit.org/show_bug.cgi?id=194074
795
796         Reviewed by Antti Koivisto.
797
798         * LayoutReloaded/misc/LFC-passing-tests.txt:
799
800 2019-01-31  Zalan Bujtas  <zalan@apple.com>
801
802         [LFC][BFC] Add support for block level replaced box.
803         https://bugs.webkit.org/show_bug.cgi?id=194071
804
805         Reviewed by Antti Koivisto.
806
807         * LayoutReloaded/misc/LFC-passing-tests.txt:
808
809 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
810
811         Fix WebKitTestRunner's testPath with Windows full paths
812         https://bugs.webkit.org/show_bug.cgi?id=194012
813
814         Reviewed by Alex Christensen.
815
816         updateTestOptionsFromTestHeader failed to open test files because
817         testPath returned wrong file paths. It returned a path "/C:/..."
818         if a URL "file:///C:/..." was given.
819
820         * WebKitTestRunner/TestController.cpp:
821         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
822
823 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
824
825         [WPE] Bump font related dependencies to match the GTK+ port
826         https://bugs.webkit.org/show_bug.cgi?id=194017
827
828         Reviewed by Žan Doberšek.
829
830         * wpe/jhbuild.modules:
831         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
832         * wpe/patches/icudata-stdlibs.patch: Added.
833
834 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
835
836         Enable swipe tests on iOS
837         https://bugs.webkit.org/show_bug.cgi?id=194076
838
839         Reviewed by Geoffrey Garen.
840
841         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
842         it causes a debug assertion failure in runUIScript.
843
844         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
845         (WTR::UIScriptController::beginBackSwipe):
846         (WTR::UIScriptController::completeBackSwipe):
847
848 2019-01-30  Keith Rollin  <krollin@apple.com>
849
850         Use correct printf format specifier
851         https://bugs.webkit.org/show_bug.cgi?id=194062
852         <rdar://problem/47686167>
853
854         Reviewed by Alexey Proskuryakov.
855
856         LayoutTestSpellChecker.mm is trying to format a variable of type
857         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
858         actually an unsigned long long. Fix this by formatting with %llu.
859
860         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
861         (-[LayoutTestTextCheckingResult description]):
862
863 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
864
865         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
866         https://bugs.webkit.org/show_bug.cgi?id=193979
867
868         Reviewed by Wenson Hsieh.
869
870         Fix the test for iOS. Make the test work with iOS UA string.
871
872         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
873
874 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
875
876         Replace High Sierra LLINT CLoop bot due to hardware failure
877         https://bugs.webkit.org/show_bug.cgi?id=194066
878
879         Reviewed by Aakash Jain.
880
881         * BuildSlaveSupport/build.webkit.org-config/config.json:
882
883 2019-01-30  Keith Rollin  <krollin@apple.com>
884
885         [NSDragItem init] is unavailable
886         https://bugs.webkit.org/show_bug.cgi?id=194059
887         <rdar://problem/47685715>
888
889         Reviewed by Wenson Hsieh.
890
891         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
892         DumpRenderTree and TestWebKitAPI, which both try to create an
893         NSDragItem in a manner that invokes this method. Address this by using
894         -initWithPasteboardWriter instead.
895
896         Note that the parameter passed to initWithPasteboardWriter is likely
897         incorrect. In both cases, the object passed does not conform to
898         NSPasteboardWriting. However, with this fix, we're no worse off than
899         before, and can now perform builds with newer compilers and SDKs until
900         a real fix can be crafted. That work is tracked in
901         https://bugs.webkit.org/show_bug.cgi?id=194060
902
903         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
904         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
905         * TestWebKitAPI/mac/TestDraggingInfo.mm:
906         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
907
908 2019-01-30  Daniel Bates  <dabates@apple.com>
909
910         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
911         https://bugs.webkit.org/show_bug.cgi?id=192824
912         <rdar://problem/47100332>
913
914         Reviewed by Wenson Hsieh.
915
916         Fix a bug where the wrong usage code was used for F13 thru F24.
917
918         * WebKitTestRunner/ios/HIDEventGenerator.mm:
919         (keyCodeForDOMFunctionKey):
920
921 2019-01-30  Chris Dumez  <cdumez@apple.com>
922
923         Regression(PSON) Load hang can occur on history navigation
924         https://bugs.webkit.org/show_bug.cgi?id=194030
925         <rdar://problem/47656939>
926
927         Reviewed by Antti Koivisto.
928
929         Add API test coverage.
930
931         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
932
933 2019-01-30  Zalan Bujtas  <zalan@apple.com>
934
935         [LFC] Expand tests coverage.
936
937         Unreviewed test gardening.
938
939         * LayoutReloaded/misc/LFC-passing-tests.txt:
940
941 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
942
943         [Flatpak] Add openjpeg support
944         https://bugs.webkit.org/show_bug.cgi?id=194019
945
946         Reviewed by Michael Catanzaro.
947
948         * flatpak/org.webkit.CommonModules.yaml:
949
950 2019-01-30  Commit Queue  <commit-queue@webkit.org>
951
952         Unreviewed, rolling out r240708.
953         https://bugs.webkit.org/show_bug.cgi?id=194022
954
955         It broke WPE build (Requested by KaL on #webkit).
956
957         Reverted changeset:
958
959         "[WPE] Bump font related dependencies to match the GTK+ port"
960         https://bugs.webkit.org/show_bug.cgi?id=194017
961         https://trac.webkit.org/changeset/240708
962
963 2019-01-30  Zalan Bujtas  <zalan@apple.com>
964
965         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
966         https://bugs.webkit.org/show_bug.cgi?id=194001
967
968         Reviewed by Antti Koivisto.
969
970         * LayoutReloaded/misc/LFC-passing-tests.txt:
971
972 2019-01-30  Zalan Bujtas  <zalan@apple.com>
973
974         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
975         https://bugs.webkit.org/show_bug.cgi?id=194020
976
977         Reviewed by Antti Koivisto.
978
979         * LayoutReloaded/misc/LFC-passing-tests.txt:
980
981 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
982
983         AX: Support color well on iOS
984         https://bugs.webkit.org/show_bug.cgi?id=194010
985
986         Reviewed by Joanmarie Diggs.
987
988         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
989         (WTR::AccessibilityUIElement::stringAttributeValue):
990
991 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
992
993         [WPE] Bump font related dependencies to match the GTK+ port
994         https://bugs.webkit.org/show_bug.cgi?id=194017
995
996         Reviewed by Žan Doberšek.
997
998         * wpe/jhbuild.modules:
999         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1000         * wpe/patches/icudata-stdlibs.patch: Added.
1001
1002 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1003
1004         [Mac] Update window scale API usage
1005         https://bugs.webkit.org/show_bug.cgi?id=193991
1006         rdar://problem/47614795
1007
1008         Reviewed by Tim Horton.
1009
1010         * DumpRenderTree/mac/DumpRenderTree.mm:
1011         (changeWindowScaleIfNeeded):
1012         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1013         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1014         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1015
1016 2019-01-29  Chris Dumez  <cdumez@apple.com>
1017
1018         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1019         https://bugs.webkit.org/show_bug.cgi?id=193977
1020         <rdar://problem/47643716>
1021
1022         Reviewed by Geoff Garen.
1023
1024         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1025         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1026         to the previous provisional committing *before* we make the last load. 
1027
1028         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1029
1030 2019-01-29  Youenn Fablet  <youenn@apple.com>
1031
1032         Adopt new SPI to evaluate server certificate trust
1033         https://bugs.webkit.org/show_bug.cgi?id=193355
1034
1035         Reviewed by Alex Christensen.
1036
1037         Add infrastructure to handle HTTPS server trust evaluation testing.
1038
1039         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1040         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1041         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1042         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1043         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1044         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1045         * WebKitTestRunner/TestController.cpp:
1046         (WTR::TestController::resetPreferencesToConsistentValues):
1047         (WTR::TestController::didReceiveAuthenticationChallenge):
1048         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1049         * WebKitTestRunner/TestController.h:
1050         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1051         * WebKitTestRunner/TestInvocation.cpp:
1052         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1053         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1054         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1055
1056 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1057
1058         [ews-build] Add build step to print bot Configuration
1059         https://bugs.webkit.org/show_bug.cgi?id=193887
1060
1061         Reviewed by Lucas Forschler.
1062
1063         * BuildSlaveSupport/ews-build/steps.py:
1064         (PrintConfiguration): Build step to print configuration.
1065         * BuildSlaveSupport/ews-build/factories.py:
1066
1067 2019-01-29  Chris Dumez  <cdumez@apple.com>
1068
1069         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1070         https://bugs.webkit.org/show_bug.cgi?id=193967
1071         <rdar://problem/47635348>
1072
1073         Reviewed by Alex Christensen.
1074
1075         Add API test coverage.
1076
1077         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1078         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1079
1080 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1081
1082         [ews-app] Handle incoming results data
1083         https://bugs.webkit.org/show_bug.cgi?id=193973
1084
1085         Reviewed by Lucas Forschler.
1086
1087         * BuildSlaveSupport/ews-app/ews/views/results.py:
1088
1089 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1090
1091         [ews-app] Make the results url generic
1092         https://bugs.webkit.org/show_bug.cgi?id=193928
1093
1094         Reviewed by Lucas Forschler.
1095
1096         * BuildSlaveSupport/ews-app/ews/urls.py:
1097
1098 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1099
1100         [ews-build] Configure buildbot to send events to ews-app
1101         https://bugs.webkit.org/show_bug.cgi?id=193968
1102
1103         Reviewed by Lucas Forschler.
1104
1105         * BuildSlaveSupport/ews-build/events.py: Added.
1106         * BuildSlaveSupport/ews-build/master.cfg:
1107
1108 2019-01-29  Keith Rollin  <krollin@apple.com>
1109
1110         Add .xcfilelists to Run Script build phases
1111         https://bugs.webkit.org/show_bug.cgi?id=193792
1112         <rdar://problem/47201785>
1113
1114         Reviewed by Alex Christensen.
1115
1116         As part of supporting XCBuild, update the necessary Run Script build
1117         phases in their Xcode projects to refer to their associated
1118         .xcfilelist files.
1119
1120         Note that the addition of these files bumps the Xcode project version
1121         number to something that's Xcode 10 compatible. This change means that
1122         older versions of the Xcode IDE can't read these projects. Nor can it
1123         fully load workspaces that refer to these projects (the updated
1124         projects are shown as non-expandable placeholders). `xcodebuild` can
1125         still build these projects; it's just that the IDE can't open them.
1126
1127         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1128         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1129
1130 2019-01-29  John Wilander  <wilander@apple.com>
1131
1132         Add data abstraction and validation for Ad Click Attribution
1133         https://bugs.webkit.org/show_bug.cgi?id=193916
1134         <rdar://problem/47603481>
1135
1136         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1137
1138         Ad click attribution has two steps. First, the storage of an ad
1139         campaign ID for a click that takes the user to a destination
1140         site. Second, a conversion on the destination site that can be
1141         attributed to the ad click.
1142
1143         This patch adds a class that represents a request for ad click
1144         attribution. Validation makes sure that the bits of entropy
1145         reported through this mechanism is limited.
1146
1147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1148         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1149         (TestWebKitAPI::TEST):
1150
1151 2019-01-29  Chris Dumez  <cdumez@apple.com>
1152
1153         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1154         https://bugs.webkit.org/show_bug.cgi?id=193932
1155         <rdar://problem/47598947>
1156
1157         Reviewed by Brady Eidson.
1158
1159         Add API test coverage.
1160
1161         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1162
1163 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1164
1165         Adding new passing LFC tests.
1166
1167         Unreviewed test gardening.
1168
1169         * LayoutReloaded/misc/LFC-passing-tests.txt:
1170
1171 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1172
1173         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1174         https://bugs.webkit.org/show_bug.cgi?id=193964
1175
1176         Reviewed by Antti Koivisto.
1177
1178         * LayoutReloaded/misc/LFC-passing-tests.txt:
1179
1180 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1181
1182         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1183         https://bugs.webkit.org/show_bug.cgi?id=193954
1184
1185         Reviewed by Antti Koivisto.
1186
1187         * LayoutReloaded/misc/LFC-passing-tests.txt:
1188
1189 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1190
1191         WebDriver: add support for running subtests
1192         https://bugs.webkit.org/show_bug.cgi?id=193904
1193
1194         Reviewed by Michael Catanzaro.
1195
1196         pytest already supports it by passing test.py::subtest, so we can do the same.
1197
1198         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1199         (get_item_name): Made this global.
1200         (CollectRecorder.__init__): Receive the parameter to ignore.
1201         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1202         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1203         (collect): Add parameter to ignore.
1204         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1205         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1206         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1207         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1208         (WebDriverTestRunnerSelenium.run): Ditto.
1209         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1210         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1211         (WebDriverTestRunnerW3C.run): Ditto.
1212
1213 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1214
1215         User agent string override for navigator.userAgent should be site specific quirks
1216         https://bugs.webkit.org/show_bug.cgi?id=193950
1217
1218         Reviewed by Brent Fulgham.
1219
1220         Updated per the _WKWebsitePolicies rename.
1221
1222         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1223         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1224
1225 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1226
1227         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1228         https://bugs.webkit.org/show_bug.cgi?id=193941
1229
1230         Reviewed by Alex Christensen.
1231
1232         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1233         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1234         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1235         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1236         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1237         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1238         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1239         * TestWebKitAPI/Tests/WTF/Time.cpp:
1240         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1241         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1242         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1243         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1244
1245 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1246
1247         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1248
1249         * Scripts/webkitpy/common/config/contributors.json:
1250
1251 2019-01-28  Andy Estes  <aestes@apple.com>
1252
1253         [watchOS] Enable Parental Controls content filtering
1254         https://bugs.webkit.org/show_bug.cgi?id=193939
1255         <rdar://problem/46641912>
1256
1257         Reviewed by Ryosuke Niwa.
1258
1259         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1260
1261 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1262
1263         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1264         <https://webkit.org/b/193884>
1265
1266         Reviewed by Jiewen Tan.
1267
1268         * Scripts/webkitpy/style/checkers/cpp.py:
1269         (check_language): Add LocalAuthentication to
1270         `frameworks_with_soft_links`.
1271
1272 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1273
1274         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1275         https://bugs.webkit.org/show_bug.cgi?id=193891
1276
1277         Reviewed by Ross Kirsling.
1278
1279         There were three problems in window sizes of WebView and the host window.
1280         1. The sizes of pixel image output were incorrect.
1281         2. The host window is going to appear after window.resize was invoked.
1282         3. window.resize resized only the host window, not WebView.
1283
1284         This change solves them with a following approach.
1285         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1286         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1287            as well as DumpRenderTree in order to match the client area and the window area.
1288         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1289         d. PlatformWebView::setWindowFrame changes both window sizes.
1290         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1291
1292         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1293         (WTR::PlatformWebView::PlatformWebView): Create the host window
1294         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1295         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1296         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1297
1298 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1299
1300         [ews-app] Add method to save Step data to database
1301         https://bugs.webkit.org/show_bug.cgi?id=193890
1302
1303         Reviewed by Lucas Forschler.
1304
1305         * BuildSlaveSupport/ews-app/ews/models/step.py:
1306         (Step.save_step): Method to save step data.
1307         (Step.update_step): Method to update step data.
1308         (Step.get_existing_step): Method to fetch existing step from database.
1309         (Step.is_valid_result): Method to validate valid step result.
1310
1311 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1312
1313         [ews-app] Add method to save Build data to database
1314         https://bugs.webkit.org/show_bug.cgi?id=193735
1315
1316         Reviewed by Lucas Forschler.
1317
1318         * BuildSlaveSupport/ews-app/ews/models/build.py:
1319         (Build.save_build): Method to save build information to database.
1320         (Build.get_existing_build): Method to fetch existing build from database.
1321         (Build.is_valid_result): Method to validate build result.
1322         * BuildSlaveSupport/ews-app/ews/common/util.py:
1323         (is_valid_int_id): Method to validate valid id.
1324
1325 2019-01-28  Chris Dumez  <cdumez@apple.com>
1326
1327         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1328         https://bugs.webkit.org/show_bug.cgi?id=193915
1329         <rdar://problem/47560907>
1330
1331         Reviewed by Alex Christensen.
1332
1333         Add API test coverage.
1334
1335         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1336
1337 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1338
1339         [ews-app] Rename id variables
1340         https://bugs.webkit.org/show_bug.cgi?id=193883
1341
1342         Reviewed by Lucas Forschler.
1343
1344         * BuildSlaveSupport/ews-app/ews/models/build.py:
1345         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1346         * BuildSlaveSupport/ews-app/ews/models/step.py:
1347         * BuildSlaveSupport/ews-app/ews/urls.py:
1348         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1349         * BuildSlaveSupport/ews-app/ews/views/results.py:
1350         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1351
1352 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1353
1354         [ews-app] Allow certain fields to be empty
1355         https://bugs.webkit.org/show_bug.cgi?id=193892
1356
1357         Reviewed by Lucas Forschler.
1358
1359         * BuildSlaveSupport/ews-app/ews/models/build.py:
1360         * BuildSlaveSupport/ews-app/ews/models/step.py:
1361
1362 2019-01-28  Rob Buis  <rbuis@igalia.com>
1363
1364         Update MIME type parser
1365         https://bugs.webkit.org/show_bug.cgi?id=180526
1366
1367         Reviewed by Frédéric Wang.
1368
1369         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1370         (TestWebKitAPI::TEST):
1371
1372 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1373
1374         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1375         https://bugs.webkit.org/show_bug.cgi?id=193896
1376
1377         Reviewed by Antti Koivisto.
1378
1379         * LayoutReloaded/misc/LFC-passing-tests.txt:
1380
1381 2018-12-15  Darin Adler  <darin@apple.com>
1382
1383         Replace many uses of String::format with more type-safe alternatives
1384         https://bugs.webkit.org/show_bug.cgi?id=192742
1385
1386         Reviewed by Mark Lam.
1387
1388         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1389         (WTR::cacheTestRunnerCallback): Use makeString.
1390         * WebKitTestRunner/TestController.cpp:
1391         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1392         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1393
1394 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1395
1396         Use a load optimizer for some sites
1397         https://bugs.webkit.org/show_bug.cgi?id=193881
1398         <rdar://problem/46325455>
1399
1400         Reviewed by Brent Fulgham.
1401
1402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1403         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1404
1405 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1406
1407         AX: Introduce a static accessibility tree
1408         https://bugs.webkit.org/show_bug.cgi?id=193348
1409         <rdar://problem/47203295>
1410
1411         Reviewed by Ryosuke Niwa.
1412
1413         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1414
1415 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1416
1417         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1418         https://bugs.webkit.org/show_bug.cgi?id=193867
1419
1420         Reviewed by Antti Koivisto.
1421
1422         * LayoutReloaded/misc/LFC-passing-tests.txt:
1423
1424 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1425
1426         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1427         https://bugs.webkit.org/show_bug.cgi?id=193865
1428
1429         Reviewed by Antti Koivisto.
1430
1431         * LayoutReloaded/misc/LFC-passing-tests.txt:
1432
1433 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1434
1435         Need a mechanism to override navigator.userAgent
1436         https://bugs.webkit.org/show_bug.cgi?id=193762
1437         <rdar://problem/47504939>
1438
1439         Reviewed by Brent Fulgham.
1440
1441         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1442
1443         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1444         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1445         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1446
1447 2019-01-25  Dean Jackson  <dino@apple.com>
1448
1449         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1450         https://bugs.webkit.org/show_bug.cgi?id=193831
1451         <rdar://problem/47399263>
1452
1453         Reviewed by Chris Dumez.
1454
1455         Two new tests that exercise cross-origin and same-origin System
1456         Previews.
1457
1458         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1459
1460 2019-01-25  Keith Rollin  <krollin@apple.com>
1461
1462         Update Xcode projects with "Check .xcfilelists" build phase
1463         https://bugs.webkit.org/show_bug.cgi?id=193790
1464         <rdar://problem/47201374>
1465
1466         Reviewed by Alex Christensen.
1467
1468         Support for XCBuild includes specifying inputs and outputs to various
1469         Run Script build phases. These inputs and outputs are specified as
1470         .xcfilelist files. Once created, these .xcfilelist files need to be
1471         kept up-to-date. In order to check that they are up-to-date or not,
1472         add an Xcode build step that invokes an external script that performs
1473         the checking. If the .xcfilelists are found to be out-of-date, update
1474         them, halt the build, and instruct the developer to restart the build
1475         with up-to-date files.
1476
1477         At this time, the checking and regenerating is performed only if the
1478         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1479         who want to use this facility can set this variable and test out the
1480         checking/regenerating. Once it seems like there are no egregious
1481         issues that upset a developer's workflow, we'll unconditionally enable
1482         this facility.
1483
1484         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1485         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1486         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1487         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1488
1489 2019-01-25  Keith Rollin  <krollin@apple.com>
1490
1491         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1492         https://bugs.webkit.org/show_bug.cgi?id=193781
1493         <rdar://problem/47201153>
1494
1495         Reviewed by Alex Christensen.
1496
1497         Part of generating the .xcfilelists used as part of adopting XCBuild
1498         includes running `make DerivedSources.make` from a standalone script.
1499         It’s important for this invocation to have the same environment as
1500         when the actual build invokes `make DerivedSources.make`. If the
1501         environments are different, then the two invocations will provide
1502         different results. In order to get the same environment in the
1503         standalone script, have the script launch xcodebuild targeting the
1504         "Apply Configuration to XCFileLists" build target, which will then
1505         re-invoke our standalone script. The script is now running again, this
1506         time in an environment with all workspace, project, target, xcconfig
1507         and other environment variables established.
1508
1509         The "Apply Configuration to XCFileLists" build target accomplishes
1510         this task via a small embedded shell script that consists only of:
1511
1512             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1513
1514         The process that invokes "Apply Configuration to XCFileLists" first
1515         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1516         evaluated and exports it into the shell environment. When xcodebuild
1517         is invoked, it inherits the value of this variable and can `eval` the
1518         contents of that variable. Our external standalone script can then set
1519         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1520         of command-line parameters needed to restart itself in the appropriate
1521         state.
1522
1523         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1524         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1525
1526 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1527
1528         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1529         https://bugs.webkit.org/show_bug.cgi?id=193802
1530         <rdar://problem/46010580>
1531
1532         Reviewed by Andy Estes.
1533
1534         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1535         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1536         (TEST):
1537
1538 2019-01-25  Daniel Bates  <dabates@apple.com>
1539
1540         [iOS] uiController.keyDown() does not translate Control modified key
1541         https://bugs.webkit.org/show_bug.cgi?id=192898
1542
1543         Reviewed by Wenson Hsieh.
1544
1545         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1546         key translation, as applicable. Among other cases, key translation occurs when performing
1547         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1548         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1549         human pressing down and releasing key(s) using a hardware keyboard.
1550
1551         * WebKitTestRunner/ios/HIDEventGenerator.h:
1552         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1553         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1554
1555         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1556         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1557         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1558         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1559         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1560         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1561         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1562         (-[HIDEventGenerator longPress:completionBlock:]):
1563         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1564         Update code for above renaming.
1565
1566         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1567         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1568
1569         (-[HIDEventGenerator keyDown:]): Added.
1570         (-[HIDEventGenerator keyUp:]): Added.
1571         (-[HIDEventGenerator keyPress:completionBlock:]):
1572         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1573         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1574         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1575         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1576         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1577         (WTR::parseModifier): Deleted.
1578
1579 2019-01-25  Keith Rollin  <krollin@apple.com>
1580
1581         Complete the implementation of generate-xcfilelists
1582         https://bugs.webkit.org/show_bug.cgi?id=193782
1583
1584         Reviewed by Alex Christensen.
1585
1586         A preliminary version of generate-xcfilelists was added in r238008.
1587         This patch updates that script in order to:
1588
1589         - Support checking of .xcfilelists
1590         - Perform better execution of `make DerivedSources.make` by
1591           relaunching generate-xcfilelists under xcodebuild
1592         - Support incremental generation and checking of .xcfilelists
1593         - Support supplementary .xcfilelists files from WebKitAdditions
1594         - Support being wrapped by parallel version of generate-xcfilelists in
1595           Internal that adds support for (re)generating WebKit projects in
1596           that repo.
1597         - Support builds that have been performed in WebKitBuild as well as
1598           ~/Library/Developer/code/DerivedData
1599         - Increase robustness and debugging facilities.
1600
1601         * Scripts/generate-xcfilelists:
1602
1603 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1604
1605         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1606         https://bugs.webkit.org/show_bug.cgi?id=193297
1607         <rdar://problem/47158841>
1608
1609         Unreviewed test case fix.
1610
1611         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1612         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1613
1614         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1615         (TEST):
1616
1617 2019-01-25  Keith Rollin  <krollin@apple.com>
1618
1619         Update existing .xcfilelists
1620         https://bugs.webkit.org/show_bug.cgi?id=193791
1621         <rdar://problem/47201706>
1622
1623         Reviewed by Alex Christensen.
1624
1625         Many .xcfilelist files were added in r238824 in order to support
1626         XCBuild. Update these with recent changes to the set of build files
1627         and with the current generate-xcfilelist script.
1628
1629         * DumpRenderTree/DerivedSources-input.xcfilelist:
1630         * DumpRenderTree/DerivedSources-output.xcfilelist:
1631         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1632         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1633
1634 2019-01-25  Keith Rollin  <krollin@apple.com>
1635
1636         Fix missing dependencies in extract-dependencies-from-makefile
1637         https://bugs.webkit.org/show_bug.cgi?id=193783
1638         <rdar://problem/47201571>
1639
1640         Reviewed by Alex Christensen.
1641
1642         The extract-dependencies-from-makefile script generates .xcfilelists
1643         for XCBuild by invoking a makefile in --debug mode, parsing the
1644         dependency information in the output, and extracting information
1645         regarding targets and dependents. However, the way `make` emits this
1646         dependency information is not rigorous, and so we need to determine
1647         what lines to look for and parse by trial and error. This approach
1648         didn't coriginally atch all the information we needed to collect, so
1649         update the script to look for the additional lines we now know to look
1650         for.
1651
1652         * Scripts/extract-dependencies-from-makefile:
1653         (Parser):
1654         (Parser.addTarget):
1655         (Parser.addPrereq):
1656         (Parser.doParse):
1657
1658 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1659
1660         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1661         https://bugs.webkit.org/show_bug.cgi?id=193297
1662         <rdar://problem/47158841>
1663
1664         Reviewed by Alex Christensen.
1665
1666         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1667             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1668         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1669         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1670         activating the message used to trigger the callback when it is set.
1671
1672 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1673
1674         WKWebView.goBack should reload if there is a safe browsing warning
1675         https://bugs.webkit.org/show_bug.cgi?id=193805
1676         <rdar://problem/46908216>
1677
1678         Reviewed by Geoff Garen.
1679
1680         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1681         (+[Simple3LookupContext sharedLookupContext]):
1682         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1683         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1684         (TEST):
1685
1686 2019-01-25  Chris Dumez  <cdumez@apple.com>
1687
1688         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1689         https://bugs.webkit.org/show_bug.cgi?id=193788
1690         <rdar://problem/47531231>
1691
1692         Reviewed by Alex Christensen.
1693
1694         Add API test coverage.
1695
1696         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1697         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1698
1699 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1700
1701         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1702         https://bugs.webkit.org/show_bug.cgi?id=193771
1703
1704         Unreviewed infrastructure fix.
1705
1706         * Scripts/webkitpy/port/darwin.py:
1707         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1708
1709 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1710
1711         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1712
1713 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1714
1715         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1716
1717         * Scripts/webkitpy/common/config/contributors.json:
1718
1719 2019-01-25  Chris Dumez  <cdumez@apple.com>
1720
1721         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1722         https://bugs.webkit.org/show_bug.cgi?id=193779
1723         <rdar://problem/46170903>
1724
1725         Reviewed by Antti Koivisto.
1726
1727         Add API test that quickly navigates forward to a previous process without waiting for it to
1728         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1729         the process' previous page when reconnecting the it for the forward navigation.
1730
1731         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1732
1733 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1734
1735         Need a way for JavaScript (or bundle) code to participate in undo
1736         https://bugs.webkit.org/show_bug.cgi?id=190009
1737         <rdar://problem/44807048>
1738
1739         Reviewed by Ryosuke Niwa.
1740
1741         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1742         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1743
1744         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1745         (WTR::UIScriptController::lastUndoLabel const):
1746         (WTR::UIScriptController::firstRedoLabel const):
1747         (WTR::UIScriptController::platformUndoManager const):
1748         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1749         (WTR::UIScriptController::lastUndoLabel const):
1750         (WTR::UIScriptController::firstRedoLabel const):
1751         (WTR::UIScriptController::platformUndoManager const):
1752         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1753         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1754         (WTR::UIScriptController::lastUndoLabel const):
1755         (WTR::UIScriptController::firstRedoLabel const):
1756         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1757         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1758         (WTR::UIScriptController::lastUndoLabel const):
1759         (WTR::UIScriptController::firstRedoLabel const):
1760         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1761         (WTR::UIScriptController::platformUndoManager const):
1762         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1763         (WTR::UIScriptController::platformUndoManager const):
1764
1765 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1766
1767         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1768         https://bugs.webkit.org/show_bug.cgi?id=193824
1769
1770         Reviewed by Antti Koivisto.
1771
1772         * LayoutReloaded/misc/LFC-passing-tests.txt:
1773
1774 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1775
1776         Update macOS JSC bot configurations
1777         https://bugs.webkit.org/show_bug.cgi?id=193739
1778
1779         Reviewed by Alexey Proskuryakov.
1780
1781         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1782         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1783         (BubbleQueueServer): Move JSC EWS to Mojave section.
1784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1785         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1786         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1787
1788 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1789
1790         [Win][WebKitTestRunner] Implement EventSenderProxy
1791         https://bugs.webkit.org/show_bug.cgi?id=193755
1792
1793         Reviewed by Don Olmstead.
1794
1795         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1796         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1797         (WTR::EventSenderProxy::dispatchMessage):
1798         (WTR::EventSenderProxy::EventSenderProxy):
1799         (WTR::EventSenderProxy::mouseDown):
1800         (WTR::EventSenderProxy::mouseUp):
1801         (WTR::EventSenderProxy::mouseMoveTo):
1802         (WTR::EventSenderProxy::mouseScrollBy):
1803         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1804
1805 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1806
1807         Unreviewed fix for API test failure after r240437.
1808
1809         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1810
1811         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1812
1813 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1814
1815         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1816         https://bugs.webkit.org/show_bug.cgi?id=193787
1817         <rdar://problem/47497634>
1818
1819         Reviewed by Alexey Proskuryakov.
1820
1821         * Scripts/webkitdirs.pm:
1822         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1823
1824 2019-01-24  Truitt Savell  <tsavell@apple.com>
1825
1826         Unreviewed, rolling out r240446.
1827
1828         Casued 5 API failures
1829
1830         Reverted changeset:
1831
1832         "Activate the WebResourceLoadStatisticsStore in the
1833         NetworkProcess and deactivate it in the UIProcess."
1834         https://bugs.webkit.org/show_bug.cgi?id=193297
1835         https://trac.webkit.org/changeset/240446
1836
1837 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1838
1839         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1840         https://bugs.webkit.org/show_bug.cgi?id=193741
1841         <rdar://problem/47135030>
1842
1843         Reviewed by Antti Koivisto and Simon Fraser.
1844
1845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1846         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1847         (TestWebKitAPI::TEST):
1848
1849 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1850
1851         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1852         https://bugs.webkit.org/show_bug.cgi?id=193297
1853         <rdar://problem/47158841>
1854
1855         Reviewed by Alex Christensen.
1856
1857         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1858         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1859         activating the message used to trigger the callback when it is set.
1860
1861 2019-01-24  John Wilander  <wilander@apple.com>
1862
1863         Add Ad Click Attribution as an internal/experimental feature
1864         https://bugs.webkit.org/show_bug.cgi?id=193685
1865         <rdar://problem/47450399>
1866
1867         Reviewed by Brent Fulgham.
1868
1869         Added test option adClickAttributionEnabled.
1870
1871         * DumpRenderTree/TestOptions.cpp:
1872         (TestOptions::TestOptions):
1873         * DumpRenderTree/TestOptions.h:
1874         * DumpRenderTree/mac/DumpRenderTree.mm:
1875         (setWebPreferencesForTestOptions):
1876
1877 2019-01-24  Antti Koivisto  <antti@apple.com>
1878
1879         [PSON] Flash on back navigation on Mac
1880         https://bugs.webkit.org/show_bug.cgi?id=193716
1881         <rdar://problem/47148458>
1882
1883         Reviewed by Chris Dumez.
1884
1885         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1886
1887         Closing of the previous page is delayed so waiting for didFinishNavigation is
1888         not sufficient to guarantee we have received all the messages. Wait for them.
1889
1890 2019-01-24  Chris Dumez  <cdumez@apple.com>
1891
1892         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1893         https://bugs.webkit.org/show_bug.cgi?id=193761
1894         <rdar://problem/47456405>
1895
1896         Reviewed by Alex Christensen.
1897
1898         Add API test coverage.
1899
1900         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1901
1902 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1903
1904         webkitpy: Missing PID in crashlog name should not be fatal
1905         https://bugs.webkit.org/show_bug.cgi?id=193771
1906
1907         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1908         of raising an exception.
1909
1910         Reviewed by Lucas Forschler.
1911
1912         * Scripts/webkitpy/port/darwin.py:
1913         (DarwinPort._merge_crash_logs):
1914
1915 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1916
1917         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1918         https://bugs.webkit.org/show_bug.cgi?id=193746
1919
1920         Reviewed by Youenn Fablet.
1921
1922         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1923         so we'd best just not call it.
1924
1925         * Scripts/webkitpy/w3c/test_exporter.py:
1926         (WebPlatformTestExporter.create_branch_with_patch):
1927
1928 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1929
1930         Move FileSystem to WTF
1931         https://bugs.webkit.org/show_bug.cgi?id=193602
1932
1933         Reviewed by Yusuke Suzuki.
1934
1935         * DumpRenderTree/win/DumpRenderTree.cpp:
1936         * TestWebKitAPI/CMakeLists.txt:
1937         * TestWebKitAPI/PlatformGTK.cmake:
1938         * TestWebKitAPI/PlatformJSCOnly.cmake:
1939         * TestWebKitAPI/PlatformPlayStation.cmake:
1940         * TestWebKitAPI/PlatformWPE.cmake:
1941         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1942         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1943         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1944         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1945         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1946         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1947         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1948         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1949         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1950         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1951
1952 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1953
1954         [WPE] Remove hard dependency on subprocess32 for the API tests
1955
1956         Rubber-stamped by Carlos Garcia Campos.
1957
1958         * glib/api_test_runner.py:
1959         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1960         its presence only when running WPEQt tests.
1961
1962 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1963
1964         [GLIB] Expose JavaScriptCore options in GLib public API
1965         https://bugs.webkit.org/show_bug.cgi?id=188742
1966
1967         Reviewed by Michael Catanzaro.
1968
1969         Add a test for the new API.
1970
1971         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1972         (testsJSCOptions):
1973         (main):
1974
1975 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1976
1977         [GTK][WPE] Support JPEG 2000 images
1978         https://bugs.webkit.org/show_bug.cgi?id=186272
1979
1980         Reviewed by Žan Doberšek.
1981
1982         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
1983
1984         * gtk/jhbuild.modules:
1985         * wpe/jhbuild.modules:
1986
1987 2019-01-23  David Kilzer  <ddkilzer@apple.com>
1988
1989         check-webkit-style should warn when using soft-linking macros in a header
1990         <https://webkit.org/b/193750>
1991
1992         Reviewed by Darin Adler.
1993
1994         * Scripts/webkitpy/style/checkers/cpp.py:
1995         (check_language): Add softlink/header check by refactoring the
1996         softlink/framework check.
1997         (CppChecker): Enable softlink/header check by default.
1998         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1999         (CppStyleTest.test_softlink_framework): Rename from
2000         CppStyleTest.test_softlink() and change test framework name in
2001         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2002         files. Set file_name for macros that only appear in headers.
2003         (CppStyleTest.test_softlink_header): Add tests for using
2004         soft-link macros in headers.
2005
2006 2019-01-23  Chris Dumez  <cdumez@apple.com>
2007
2008         Deprecate API to limit the maximum number of WebProcesses
2009         https://bugs.webkit.org/show_bug.cgi?id=193725
2010         <rdar://problem/47464879>
2011
2012         Reviewed by Geoff Garen.
2013
2014         Update existing API tests to stop using deprecated API.
2015
2016         * MiniBrowser/mac/AppDelegate.m:
2017         (defaultConfiguration):
2018         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2019         (TestWebKitAPI::TEST):
2020         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2021         (TestWebKitAPI::TEST):
2022         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2023         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2024         (TEST):
2025         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2026         (TEST):
2027
2028 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2029
2030         [ews-app] Rename ews model buildermappings to buildermapping
2031         https://bugs.webkit.org/show_bug.cgi?id=193729
2032
2033         Reviewed by Lucas Forschler.
2034
2035         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2036         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2037         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2038
2039 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2040
2041         [ews-app] Rename ews model steps to step
2042         https://bugs.webkit.org/show_bug.cgi?id=193697
2043
2044         Reviewed by Lucas Forschler.
2045
2046         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2047         (Step): Renamed Steps to Step.
2048
2049 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2050
2051         Clean up IndexedDB files between tests
2052         https://bugs.webkit.org/show_bug.cgi?id=192796
2053         <rdar://problem/46824999>
2054
2055         Reviewed by Geoffrey Garen.
2056
2057         * DumpRenderTree/mac/DumpRenderTree.mm:
2058         (runTest):
2059         * WebKitTestRunner/TestController.cpp:
2060         (WTR::TestController::resetStateToConsistentValues):
2061         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2062         (WTR::RemoveAllIndexedDatabasesCallback):
2063         (WTR::TestController::ClearIndexedDatabases):
2064         * WebKitTestRunner/TestController.h:
2065         * WebKitTestRunner/TestInvocation.cpp:
2066         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2067
2068 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2069
2070         [ews-app] Rename ews model Builds to Build
2071         https://bugs.webkit.org/show_bug.cgi?id=193695
2072
2073         Reviewed by Lucas Forschler.
2074
2075         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2076         (Build): Renamed Builds to Build.
2077
2078 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2079
2080         webkitpy: Wait longer when launching WebKitTestRunner
2081         https://bugs.webkit.org/show_bug.cgi?id=193734
2082
2083         Reviewed by Aakash Jain.
2084
2085         * Scripts/webkitpy/port/simulator_process.py:
2086         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2087
2088 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2089
2090         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2091         https://bugs.webkit.org/show_bug.cgi?id=193182
2092         <rdar://problem/47452154>
2093
2094         Reviewed by Tim Horton.
2095
2096         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2097         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2098         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2099
2100         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2101         preventing later tests from recognizing gestures.
2102
2103         * WebKitTestRunner/ios/TestControllerIOS.mm:
2104         (WTR::TestController::platformResetStateToConsistentValues):
2105
2106         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2107
2108 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2109
2110         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2111         https://bugs.webkit.org/show_bug.cgi?id=193722
2112         <rdar://problem/47481475>
2113
2114         Reviewed by Lucas Forschler.
2115
2116         iPhone and iPad ports should both use the iOS config.
2117
2118         * Scripts/webkitpy/port/ios_simulator.py:
2119         (IPhoneSimulatorPort.__init__):
2120         (IPadSimulatorPort.__init__):
2121
2122 2019-01-23  Rob Buis  <rbuis@igalia.com>
2123
2124         Update MIME type parser
2125         https://bugs.webkit.org/show_bug.cgi?id=180526
2126
2127         Reviewed by Frédéric Wang.
2128
2129         Add unit tests for both parse modes of ParsedContentType.
2130
2131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2132         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2133         (TestWebKitAPI::TEST):
2134
2135 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2136
2137         [ews-app] fetch loop should not stop on network issues
2138         https://bugs.webkit.org/show_bug.cgi?id=193666
2139
2140         Reviewed by Lucas Forschler.
2141
2142         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2143         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2144
2145 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2146
2147         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2148         https://bugs.webkit.org/show_bug.cgi?id=189165
2149         <rdar://problem/47433765>
2150
2151         Reviewed by Tim Horton.
2152
2153         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2154         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2155         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2156         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2157         would make its way to the UI process by the time the layer tree commit is finished.
2158
2159         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2160         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2161         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2162         will fail because it asks for -_autofillContext too early.
2163
2164         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2165         is handled in the UI process.
2166
2167         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2168
2169         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2170         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2171         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2172         input session.
2173
2174         (-[AutofillTestView textInputHasAutofillContext]):
2175
2176         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2177
2178         * TestWebKitAPI/cocoa/TestWKWebView.h:
2179         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2180         (nextInputSessionChangeCount):
2181
2182         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2183         This includes changing the focused element from one to another.
2184
2185         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2186         (-[TestWKWebView didStartFormControlInteraction]):
2187         (-[TestWKWebView didEndFormControlInteraction]):
2188         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2189
2190         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2191         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2192         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2193         that doesn't require an input session to one that doesn't.
2194
2195 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2196
2197         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2198         <https://webkit.org/b/193676>
2199
2200         Reviewed by Alexey Proskuryakov.
2201
2202         * Scripts/webkitpy/style/checkers/cpp.py:
2203         (check_member_initialization_list):
2204         - Don't report missing whitespace around colon if the colon at
2205           the start of the line is formatted correctly.
2206         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2207         (WebKitStyleTest.test_member_initialization_list):
2208         - Add a test for a missing permutation of existing tests.
2209         - Add a test this false-positive.
2210         - Add blank lines between subtests to make them easier to read.
2211
2212 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2213
2214         [build.webkit.org] Unit-test failure after r237113
2215         https://bugs.webkit.org/show_bug.cgi?id=193669
2216
2217         Reviewed by Michael Catanzaro.
2218
2219         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2220         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2221         multiple or zero flags.
2222
2223 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2224
2225         Cache bytecode to disk
2226         https://bugs.webkit.org/show_bug.cgi?id=192782
2227         <rdar://problem/46084932>
2228
2229         Reviewed by Keith Miller.
2230
2231         Add test helper to execute bytecode-cache tests: it executes each test
2232         twice, the first with JSC_diskCachePath set to a temporary directory
2233         and second with JSC_forceDiskCache=true (in addition to the cache path)
2234         to guarantee that only the disk cache is being used and no new
2235         UnlinkedCodeBlocks are being created.
2236
2237         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2238         * Scripts/run-jsc-stress-tests:
2239
2240 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2241
2242         [css-logical] Implement flow-relative margin, padding and border shorthands
2243         https://bugs.webkit.org/show_bug.cgi?id=188697
2244
2245         Reviewed by Simon Fraser and Antti Koivisto.
2246
2247         * DumpRenderTree/TestOptions.cpp:
2248         (TestOptions::TestOptions):
2249         * DumpRenderTree/TestOptions.h:
2250         * DumpRenderTree/mac/DumpRenderTree.mm:
2251         (setWebPreferencesForTestOptions):
2252         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2253
2254         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2255         (JSONCSSPropertiesChecker.check_codegen_properties):
2256         Allow CSS property definitions to have a 'runtime-flag' parameter which
2257         disables the property when the specified runtime flag is disabled.
2258
2259 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2260
2261         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2262         https://bugs.webkit.org/show_bug.cgi?id=193643
2263
2264         Reviewed by Michael Catanzaro.
2265
2266         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2267         * wpe/jhbuild.modules: Ditto.
2268
2269 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2270
2271         [LFC][Floats] Take float top position into account when computing containing block height.
2272         https://bugs.webkit.org/show_bug.cgi?id=193655
2273
2274         Reviewed by Antti Koivisto.
2275
2276         * LayoutReloaded/misc/LFC-passing-tests.txt:
2277
2278 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2279
2280         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2281         <https://webkit.org/b/193645>
2282         <rdar://problem/47421574>
2283
2284         Reviewed by Alex Christensen.
2285
2286         - Now checks for local soft-linking of all frameworks that have
2287           their own *SoftLinking.{cpp,h,mm} files.
2288         - Changes softlink/uikit warning to softlink/framework.
2289
2290         * Scripts/webkitpy/style/checkers/cpp.py:
2291         (check_language):
2292         (CppChecker):
2293         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2294         (CppStyleTest):
2295
2296 2019-01-20  Saam Barati  <sbarati@apple.com>
2297
2298         Rollout r240210: It broke tests on iOS
2299         https://bugs.webkit.org/show_bug.cgi?id=193640
2300
2301         Unreviewed.
2302
2303         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2304         * Scripts/run-jsc-stress-tests:
2305
2306 2019-01-20  chris fleizach  <cfleizach@apple.com>
2307
2308         AX: Support returning relative frames for accessibility
2309         https://bugs.webkit.org/show_bug.cgi?id=193414
2310         <rdar://problem/47268501>
2311
2312         Reviewed by Zalan Bujtas.
2313
2314         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2315         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2316         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2317         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2318         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2319         (WTR::attributesOfElement):
2320         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2321
2322 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2323
2324         Unreviewed, add my new email address
2325
2326         * Scripts/webkitpy/common/config/contributors.json:
2327
2328 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2329
2330         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2331         https://bugs.webkit.org/show_bug.cgi?id=193617
2332
2333         Reviewed by Antti Koivisto.
2334
2335         * LayoutReloaded/misc/LFC-passing-tests.txt:
2336
2337 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2338
2339         Unreviewed, rolling out r240209.
2340
2341         Broke GTK/WPE injected bundle
2342
2343         Reverted changeset:
2344
2345         "AX: Support returning relative frames for accessibility"
2346         https://bugs.webkit.org/show_bug.cgi?id=193414
2347         https://trac.webkit.org/changeset/240209
2348
2349 2019-01-12  Dan Bernstein  <mitz@apple.com>
2350
2351         [Cocoa] Avoid importing directly from subumbrella frameworks
2352         https://bugs.webkit.org/show_bug.cgi?id=186016
2353         <rdar://problem/40591038>
2354
2355         Reviewed by Sam Weinig.
2356
2357         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2358           LaunchServices header.
2359         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2360           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2361         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2362           when using SDKs earlier than 10.13.
2363         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2364           and OTHER_CPLUSPLUSFLAGS.
2365         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2366           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2367         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2368           LaunchServices header.
2369
2370 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2371
2372         Cache bytecode to disk
2373         https://bugs.webkit.org/show_bug.cgi?id=192782
2374         <rdar://problem/46084932>
2375
2376         Reviewed by Keith Miller.
2377
2378         Add test helper to execute bytecode-cache tests: it executes each test
2379         twice, the first with JSC_diskCachePath set to a temporary directory
2380         and second with JSC_forceDiskCache=true (in addition to the cache path)
2381         to guarantee that only the disk cache is being used and no new
2382         UnlinkedCodeBlocks are being created.
2383
2384         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2385         * Scripts/run-jsc-stress-tests:
2386
2387 2019-01-20  chris fleizach  <cfleizach@apple.com>
2388
2389         AX: Support returning relative frames for accessibility
2390         https://bugs.webkit.org/show_bug.cgi?id=193414
2391         <rdar://problem/47268501>
2392
2393         Reviewed by Zalan Bujtas.
2394
2395         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2396         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2397         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2398         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2399         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2400         (WTR::attributesOfElement):
2401         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2402
2403 2019-01-20  Antoine Quint  <graouts@apple.com>
2404
2405         Add a POINTER_EVENTS feature flag
2406         https://bugs.webkit.org/show_bug.cgi?id=193577
2407         <rdar://problem/47408511>
2408
2409         Unreviewed. Also enable Pointer Events for iosmac.
2410
2411         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2412
2413 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2414
2415         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2416         https://bugs.webkit.org/show_bug.cgi?id=193613
2417
2418         Reviewed by Antti Koivisto.
2419
2420         * LayoutReloaded/misc/LFC-passing-tests.txt:
2421
2422 2019-01-19  Antoine Quint  <graouts@apple.com>
2423
2424         Add a POINTER_EVENTS feature flag
2425         https://bugs.webkit.org/show_bug.cgi?id=193577
2426
2427         Reviewed by Dean Jackson.
2428
2429         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2430
2431 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2432
2433         Disable the run-jsc-stress-test remote host key check [second round].
2434         https://bugs.webkit.org/show_bug.cgi?id=192988
2435
2436         Reviewed by Dewei Zhu.
2437
2438         * Scripts/run-jsc-stress-tests:
2439
2440 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2441
2442         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2443         https://bugs.webkit.org/show_bug.cgi?id=193597
2444
2445         Reviewed by Lucas Forschler.
2446
2447         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2448
2449 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2450
2451         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2452         https://bugs.webkit.org/show_bug.cgi?id=193595
2453
2454         Reviewed by Lucas Forschler.
2455
2456         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2457         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2458         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2459
2460 2019-01-18  Chris Dumez  <cdumez@apple.com>
2461
2462         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2463         https://bugs.webkit.org/show_bug.cgi?id=193588
2464         <rdar://problem/47131566>
2465
2466         Reviewed by Alex Christensen.
2467
2468         Add layout test coverage.
2469
2470         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2471
2472 2019-01-18  Jer Noble  <jer.noble@apple.com>
2473
2474         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2475         https://bugs.webkit.org/show_bug.cgi?id=189553
2476
2477         Reviewed by Tim Horton.
2478
2479         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2480
2481         * ContentExtensionTester/Configurations/Base.xcconfig:
2482         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2483         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2484         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2485         * ImageDiff/cg/Configurations/Base.xcconfig:
2486         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2487         * MiniBrowser/Configurations/Base.xcconfig:
2488         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2489         * MobileMiniBrowser/Configurations/Base.xcconfig:
2490         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2491         * Scripts/webkitpy/style/checker.py:
2492         (_all_categories):
2493         (FileType):
2494         (CheckerDispatcher._file_type):
2495         (CheckerDispatcher._create_checker):
2496         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2497         (SDKVariantChecker):
2498         (SDKVariantChecker.__init__):
2499         (SDKVariantChecker.check):
2500         * TestWebKitAPI/Configurations/Base.xcconfig:
2501         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2502         * WebEditingTester/Configurations/Base.xcconfig:
2503         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2504         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2505         * WebKitTestRunner/Configurations/Base.xcconfig:
2506         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2507         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2508         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2509
2510 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2511
2512         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2513         <https://webkit.org/b/193568>
2514         <rdar://problem/47381130>
2515
2516         Reviewed by Alex Christensen.
2517
2518         Make sure no one re-introduces UIKit soft-linking by adding a
2519         style rule.
2520
2521         * Scripts/webkitpy/style/checkers/cpp.py:
2522         (check_language): Add softlink/uikit check.
2523         (CppChecker): Enable softlink/uikit check.
2524         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2525         (CppStyleTest): Add test for softlink/uikit.
2526
2527 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2528
2529         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2530         https://bugs.webkit.org/show_bug.cgi?id=193584
2531
2532         Change "-dev" to "-devel".
2533
2534         Reviewed by Michael Catanzaro.
2535
2536         * gtk/install-dependencies:
2537
2538 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2539
2540         webkitpy: Add iPhone and iPad ports
2541         https://bugs.webkit.org/show_bug.cgi?id=193537
2542         <rdar://problem/47353390>
2543
2544         Reviewed by Lucas Forschler.
2545
2546         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2547         ports. Note that this separation is optional, the --ios-simulator command remains.
2548
2549         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2550         (RunTest.test_device_type_test_division): Drive-by fix.
2551         (RunTest.test_device_type_specific_listing): Ditto.
2552         (RunTest.test_ipad_test_division):
2553         (RunTest):
2554         (RunTest.test_ipad_listing):
2555         * Scripts/webkitpy/port/factory.py:
2556         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2557         (PortFactory):
2558         * Scripts/webkitpy/port/ios_simulator.py:
2559         (IPhoneSimulatorPort):
2560         (IPadSimulatorPort):
2561
2562 2019-01-18  Chris Dumez  <cdumez@apple.com>
2563
2564         Regression(PSON) Scroll position is not always restored properly when navigating back
2565         https://bugs.webkit.org/show_bug.cgi?id=193578
2566         <rdar://problem/47386331>
2567
2568         Reviewed by Tim Horton.
2569
2570         Add API test coverage.
2571
2572         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2573
2574 2019-01-18  Youenn Fablet  <youenn@apple.com>
2575
2576         Add a new SPI to request for cache storage quota increase
2577         https://bugs.webkit.org/show_bug.cgi?id=193323
2578
2579         Reviewed by Alex Christensen.
2580
2581         Implement WebsiteDataStore quota delegate to handle quota requests.
2582         By default, do not update quota.
2583         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2584
2585         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2586         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2587         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2588         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2589         * WebKitTestRunner/TestController.cpp:
2590         (WTR::TestController::allowCacheStorageQuotaIncrease):
2591         * WebKitTestRunner/TestController.h:
2592         * WebKitTestRunner/TestInvocation.cpp:
2593         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2594         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2595         (-[CacheStorageQuotaManager init]):
2596         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2597         (WTR::initializeWebViewConfiguration):
2598         (WTR::TestController::cocoaResetStateToConsistentValues):
2599         (WTR::TestController::allowCacheStorageQuotaIncrease):
2600
2601 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2602
2603         [ews-build] Pass owner to the triggered builds
2604         https://bugs.webkit.org/show_bug.cgi?id=193574
2605
2606         Reviewed by Lucas Forschler.
2607
2608         * BuildSlaveSupport/ews-build/factories.py:
2609         (BuildFactory.propertiesToPassToTriggers):
2610
2611 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2612
2613         [ews-app] Send patch author as a build property
2614         https://bugs.webkit.org/show_bug.cgi?id=193560
2615
2616         Reviewed by Lucas Forschler.
2617
2618         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2619         (BugzillaPatchFetcher.fetch):
2620
2621 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2622
2623         webkitpy: Implement device type specific expected results (Follow-up fix)
2624         https://bugs.webkit.org/show_bug.cgi?id=192162
2625         <rdar://problem/46345449>
2626
2627         Unreviewed infrastructure fix.
2628
2629         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2630         (Manager.run): Don't boot a device if no tests are available to run on it.
2631
2632 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2633
2634         webkitpy: Implement device type specific expected results (Follow-up fix)
2635         https://bugs.webkit.org/show_bug.cgi?id=192162
2636         <rdar://problem/46345449>
2637
2638         Unreviewed infrastructure fix.
2639
2640         * Scripts/webkitpy/api_tests/manager.py:
2641         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2642
2643 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2644
2645         webkitpy: Implement device type specific expected results (Part 2)
2646         https://bugs.webkit.org/show_bug.cgi?id=192162
2647         <rdar://problem/46345449>
2648
2649         Rubber-stamped by Aakash Jain.
2650
2651         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2652         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2653         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2654
2655         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2656         (LayoutTestFinder.find_tests): Pass device_type through.
2657         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2658         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2659         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2660         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2661         (Manager._collect_tests): Pass device type to test finder.
2662         (Manager._needs_web_platform_test):
2663         (Manager._prepare_lists): Index _expectations by device type.
2664         (Manager._test_input_for_file):
2665         (Manager._test_is_slow): Ditto.
2666         (Manager._test_should_dump_jsconsolelog_in_stderr):
2667         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2668         (Manager._get_test_inputs):
2669         (Manager._update_worker_count):
2670         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2671         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2672         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2673         the one which runs the test.
2674         (Manager._run_test_subset):
2675         (Manager._run_tests): Index _expectations by current_device_type.
2676         (Manager._print_expectation_line_for_test): Ditto.
2677         (Manager._print_expectations_for_subset): Ditto.
2678         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2679         Unlike run, this function will behave the same regardless of what devices are available.
2680         (Manager._custom_device_for_test): Deleted.
2681         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2682         (ManagerTest.test_uses_custom_device): Deleted.
2683         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2684         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2685         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2686         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2687         all of the expectations.
2688         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2689         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2690         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2691         (TestExpectations.__init__): Allow device_type to be passed through.
2692         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2693         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2694         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2695         (summarize_results):
2696         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2697         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2698         a test ran with, one must check all expectations to find the first non-skip expectation.
2699         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2700         (RunTest.test_device_type_test_division):
2701         (RunTest):
2702         (RunTest.test_device_type_specific_listing):
2703         * Scripts/webkitpy/port/base.py:
2704         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2705         (Port.supported_device_types): The result of this function will change based on what devices are available.
2706         * Scripts/webkitpy/port/device_port.py:
2707         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2708         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2709         can be used.
2710         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2711         any, or the DEFAULT_DEVICE_TYPES of the port.
2712         * Scripts/webkitpy/port/ios.py:
2713         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2714         * Scripts/webkitpy/port/ios_simulator.py:
2715         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2716         * Scripts/webkitpy/port/watch.py:
2717         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2718         * Scripts/webkitpy/port/watch_simulator.py:
2719         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2720         * Scripts/webkitpy/xcode/device_type.py:
2721         (DeviceType):
2722         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2723
2724 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2725
2726         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2727         https://bugs.webkit.org/show_bug.cgi?id=193575
2728
2729         Reviewed by Michael Catanzaro.
2730
2731         Allow the script to run without explicit port argument because
2732         it's specific to the WPE port anyway.
2733
2734         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2735         and simplify the rest of the code accordingly.
2736
2737 2019-01-18  Charlie Turner  <cturner@igalia.com>
2738
2739         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2740         https://bugs.webkit.org/show_bug.cgi?id=192229
2741
2742         Reviewed by Xabier Rodriguez-Calvar.
2743
2744         * MiniBrowser/wpe/main.cpp:
2745         (main): Enable encrypted-media by default.
2746
2747 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2748
2749         [Flatpak] Missing KeyboardInterrupt exception handler
2750         https://bugs.webkit.org/show_bug.cgi?id=193570
2751
2752         Reviewed by Michael Catanzaro.
2753
2754         * flatpak/flatpakutils.py:
2755         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2756
2757 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2758
2759         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2760         https://bugs.webkit.org/show_bug.cgi?id=193564
2761
2762         Reviewed by Antti Koivisto.
2763
2764         * LayoutReloaded/misc/LFC-passing-tests.txt:
2765
2766 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2767
2768         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2769         https://bugs.webkit.org/show_bug.cgi?id=193562
2770
2771         Reviewed by Antti Koivisto.
2772
2773         * LayoutReloaded/misc/LFC-passing-tests.txt:
2774
2775 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2776
2777         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2778         https://bugs.webkit.org/show_bug.cgi?id=193555
2779
2780         Reviewed by Antti Koivisto.
2781
2782         * LayoutReloaded/misc/LFC-passing-tests.txt:
2783
2784 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2785
2786         [WPE] Add Qt extension
2787         https://bugs.webkit.org/show_bug.cgi?id=191464
2788
2789         Reviewed by Carlos Garcia Campos.
2790
2791         MiniBrowser and API tests for the WPE Qt API. To run the
2792         MiniBrowser a new script is introduced. Example invocation:
2793
2794         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2795
2796         Also note-worthy is the introduction of the python2-subprocess32
2797         dependency to run the GLib API tests.
2798
2799         * MiniBrowser/wpe/CMakeLists.txt:
2800         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2801         * MiniBrowser/wpe/qt/main.cpp: Added.
2802         (main):
2803         * MiniBrowser/wpe/qt/main.qml: Added.
2804         * MiniBrowser/wpe/qt/qml.qrc: Added.
2805         * Scripts/run-gtk-tests:
2806         (GtkTestRunner.is_google_test):
2807         (GtkTestRunner):
2808         (GtkTestRunner.is_qt_test):
2809         * Scripts/run-qt-wpe-minibrowser: Added.
2810         * Scripts/run-wpe-tests:
2811         (WPETestRunner):
2812         (WPETestRunner.is_google_test):
2813         (WPETestRunner.is_qt_test):
2814         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2815         (TestLoad::main):
2816         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2817         (TestLoadHtml::main):
2818         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2819         (TestLoadRequest::main):
2820         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2821         (TestRunJavaScript::main):
2822         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2823         (waitForSignal):
2824         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2825         (LoadSpy::LoadSpy):
2826         (LoadSpy::~LoadSpy):
2827         (LoadSpy::onLoadingChanged):
2828         (LoadStartedCatcher::LoadStartedCatcher):
2829         (LoadStartedCatcher::~LoadStartedCatcher):
2830         (LoadStartedCatcher::onLoadingChanged):
2831         (waitForLoadSucceeded):
2832         (waitForLoadFailed):
2833         * TestWebKitAPI/glib/CMakeLists.txt:
2834         * flatpak/flatpakutils.py:
2835         (WebkitFlatpak.load_from_args):
2836         (WebkitFlatpak.__init__):
2837         (WebkitFlatpak.clean_args):
2838         (WebkitFlatpak.run_in_sandbox):
2839         * flatpak/org.webkit.CommonModules.yaml:
2840         * flatpak/org.webkit.WPE.yaml:
2841         * flatpak/org.webkit.WPEModules.yaml:
2842         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2843         * flatpak/org.webkit.WebKit.yaml:
2844         * glib/api_test_runner.py:
2845         (TestRunner._run_test_qt):
2846         (TestRunner.is_qt_test):
2847         (TestRunner._run_test):
2848
2849 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2850
2851         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2852         https://bugs.webkit.org/show_bug.cgi?id=193494
2853         <rdar://problem/46859627>
2854
2855         Reviewed by Simon Fraser and Tim Horton.
2856
2857         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2858         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2859
2860         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2861         (WTR::UIScriptController::contentOffsetX const):
2862         (WTR::UIScriptController::contentOffsetY const):
2863         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2864         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2865         (WTR::UIScriptController::contentOffsetX const):
2866         (WTR::UIScriptController::contentOffsetY const):
2867         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2868
2869         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2870
2871         * WebKitTestRunner/TestController.cpp:
2872         (WTR::updateTestOptionsFromTestHeader):
2873         * WebKitTestRunner/TestOptions.h:
2874         (WTR::TestOptions::hasSameInitializationOptions const):
2875         * WebKitTestRunner/ios/TestControllerIOS.mm:
2876         (WTR::TestController::platformResetStateToConsistentValues):
2877         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2878         (WTR::UIScriptController::contentOffsetX const):
2879         (WTR::UIScriptController::contentOffsetY const):
2880
2881 2019-01-17  Truitt Savell  <tsavell@apple.com>
2882
2883         Unreviewed, rolling out r240124.
2884
2885         This commit broke an internal build.
2886
2887         Reverted changeset:
2888
2889         "SDK_VARIANT build destinations should be separate from non-
2890         SDK_VARIANT builds"
2891         https://bugs.webkit.org/show_bug.cgi?id=189553
2892         https://trac.webkit.org/changeset/240124
2893
2894 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2895
2896         Fix string concatenation API test after r239920
2897         https://bugs.webkit.org/show_bug.cgi?id=193551
2898         <rdar://problem/47359304>
2899
2900         Reviewed by Youenn Fablet.
2901
2902         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2903         (TestWebKitAPI::TEST):
2904         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2905         in WebKit's build configuration like it apparently is on Linux.
2906
2907 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2908
2909         [ews-build] validate-patch should handle the case when bug_id is None
2910         https://bugs.webkit.org/show_bug.cgi?id=193547
2911
2912         Reviewed by Lucas Forschler.
2913
2914         * BuildSlaveSupport/ews-build/steps.py:
2915         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2916         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2917
2918 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2919
2920         [ews-build] Add patch author information in build
2921         https://bugs.webkit.org/show_bug.cgi?id=193465
2922
2923         Reviewed by Lucas Forschler.
2924
2925         * BuildSlaveSupport/ews-build/steps.py:
2926         (ValidatePatch._is_patch_obsolete):
2927
2928 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2929
2930         [ews-build] Pass bug_id to the triggered builds
2931         https://bugs.webkit.org/show_bug.cgi?id=193548
2932
2933         Reviewed by Lucas Forschler.
2934
2935         * BuildSlaveSupport/ews-build/factories.py:
2936         (BuildFactory.propertiesToPassToTriggers):
2937
2938 2019-01-17  Jer Noble  <jer.noble@apple.com>
2939
2940         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2941         https://bugs.webkit.org/show_bug.cgi?id=189553
2942
2943         Reviewed by Tim Horton.
2944
2945         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2946
2947         * ContentExtensionTester/Configurations/Base.xcconfig:
2948         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2949         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2950         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2951         * ImageDiff/cg/Configurations/Base.xcconfig:
2952         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2953         * MiniBrowser/Configurations/Base.xcconfig:
2954         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2955         * MobileMiniBrowser/Configurations/Base.xcconfig:
2956         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2957         * Scripts/webkitpy/style/checker.py:
2958         (_all_categories):
2959         (FileType):
2960         (CheckerDispatcher._file_type):
2961         (CheckerDispatcher._create_checker):
2962         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2963         (SDKVariantChecker):
2964         (SDKVariantChecker.__init__):
2965         (SDKVariantChecker.check):
2966         * TestWebKitAPI/Configurations/Base.xcconfig:
2967         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2968         * WebEditingTester/Configurations/Base.xcconfig:
2969         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2970         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2971         * WebKitTestRunner/Configurations/Base.xcconfig:
2972         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2973         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2974         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2975
2976 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2977
2978         [LFC][BFC] An element with transform is a containing block for positioned descendants.
2979         https://bugs.webkit.org/show_bug.cgi?id=193534
2980
2981         Reviewed by Antti Koivisto.
2982
2983         * LayoutReloaded/misc/LFC-passing-tests.txt:
2984
2985 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2986
2987         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
2988         https://bugs.webkit.org/show_bug.cgi?id=193528
2989
2990         Reviewed by Antti Koivisto.
2991
2992         * LayoutReloaded/misc/LFC-passing-tests.txt:
2993
2994 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2995
2996         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
2997         https://bugs.webkit.org/show_bug.cgi?id=193520
2998
2999         Reviewed by Antti Koivisto.
3000
3001         * LayoutReloaded/misc/LFC-passing-tests.txt:
3002
3003 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3004
3005         [ews-build] unapply-patch step should not update source
3006         https://bugs.webkit.org/show_bug.cgi?id=193234
3007
3008         Reviewed by Lucas Forschler.
3009
3010         * BuildSlaveSupport/ews-build/steps.py:
3011         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3012         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3013
3014 2019-01-16  Youenn Fablet  <youenn@apple.com>
3015
3016         Add a new SPI for controlling getUserMedia
3017         https://bugs.webkit.org/show_bug.cgi?id=192793
3018
3019         Reviewed by Eric Carlson.
3020
3021         * MiniBrowser/mac/WK2BrowserWindowController.m:
3022         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3023         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3024         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3025         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3026         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3027         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3028         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3029         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3030         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3031         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3032         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3033         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3034         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3035         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3036
3037 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3038
3039         [LFC][BFC] Inflow non-replaced used width should not be negative.
3040         https://bugs.webkit.org/show_bug.cgi?id=193495
3041
3042         Reviewed by Antti Koivisto.
3043
3044         * LayoutReloaded/misc/LFC-passing-tests.txt:
3045
3046 2019-01-16  Chris Dumez  <cdumez@apple.com>
3047
3048         Regression(PSON) View becomes blank after click a cross-site download link
3049         https://bugs.webkit.org/show_bug.cgi?id=193361
3050         <rdar://problem/47099573>
3051
3052         Reviewed by Geoffrey Garen.
3053
3054         Add API test coverage.
3055
3056         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3057         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3058
3059 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3060
3061         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3062         https://bugs.webkit.org/show_bug.cgi?id=193470
3063
3064         Reviewed by Antti Koivisto.
3065
3066         * LayoutReloaded/misc/LFC-passing-tests.txt:
3067
3068 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3069
3070         [LFC] Adjust margin box verification.
3071         https://bugs.webkit.org/show_bug.cgi?id=193482
3072
3073         Reviewed by Antti Koivisto.
3074
3075         * LayoutReloaded/misc/LFC-passing-tests.txt:
3076
3077 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3078
3079         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3080         https://bugs.webkit.org/show_bug.cgi?id=193451
3081
3082         Reviewed by Geoffrey Garen.
3083
3084         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3085         (TEST):
3086         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3087         (runWebsiteDataStoreCustomPaths):
3088
3089 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3090
3091         webkitpy: Support boolean simctl isAvailable
3092         https://bugs.webkit.org/show_bug.cgi?id=193472
3093         <rdar://problem/47296150>
3094
3095         Reviewed by Ryosuke Niwa.
3096
3097         * Scripts/webkitpy/xcode/simulated_device.py:
3098         (SimulatedDeviceManager._create_runtimes):
3099         (SimulatedDeviceManager._create_device_with_runtime):
3100
3101 2019-01-15  Chris Dumez  <cdumez@apple.com>
3102
3103         Unreviewed, rolling out r239993, r239995, r239997, and
3104         r239999.
3105
3106         Caused assertions under
3107         ViewGestureController::disconnectFromProcess()
3108
3109         Reverted changesets:
3110
3111         "Regression(PSON) View becomes blank after click a cross-site
3112         download link"
3113         https://bugs.webkit.org/show_bug.cgi?id=193361
3114         https://trac.webkit.org/changeset/239993
3115
3116         "Unreviewed iOS build fix after r239993."
3117         https://trac.webkit.org/changeset/239995
3118
3119         "Fix iOS build after r239993"
3120         https://bugs.webkit.org/show_bug.cgi?id=193361
3121         https://trac.webkit.org/changeset/239997
3122
3123         "Unreviewed, revert part of r239997 as it is not needed to fix
3124         the build."
3125         https://trac.webkit.org/changeset/239999
3126
3127 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3128
3129         Cannot tab out of WKWebView on macOS
3130         https://bugs.webkit.org/show_bug.cgi?id=161448
3131         <rdar://problem/28100085>
3132
3133         Reviewed by Dean Jackson.
3134
3135         Add a test that tabbing into and out of WKWebView works correctly.
3136
3137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3138         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3139         (WebKit2_CommandBackForwardTest::SetUp):
3140         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3141         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3142         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3143         (-[FocusableView canBecomeKeyView]):
3144         (TEST):
3145         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3146         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3147         (-[OffscreenWindow initWithSize:]):
3148         (-[OffscreenWindow isKeyWindow]):
3149         (-[OffscreenWindow isVisible]):
3150         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3151         (TestWebKitAPI::PlatformWebView::initialize):
3152         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3153         (-[ActiveOffscreenWindow isVisible]): Deleted.
3154         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3155
3156 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3157
3158         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3159         https://bugs.webkit.org/show_bug.cgi?id=193459
3160
3161         Reviewed by Mark Lam.
3162
3163         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3164         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3165
3166 2019-01-15  Chris Dumez  <cdumez@apple.com>
3167
3168         Regression(PSON) View becomes blank after click a cross-site download link
3169         https://bugs.webkit.org/show_bug.cgi?id=193361
3170         <rdar://problem/47099573>
3171
3172         Reviewed by Geoff Garen.
3173
3174         Add API test coverage.
3175
3176         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3177         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3178
3179 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3180
3181         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3182         https://bugs.webkit.org/show_bug.cgi?id=193448
3183
3184         Reviewed by Antti Koivisto.
3185
3186         * LayoutReloaded/misc/LFC-passing-tests.txt:
3187
3188 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3189
3190         webkitpy: Implement device type specific expected results (Part 1)
3191         https://bugs.webkit.org/show_bug.cgi?id=192162
3192
3193         Reviewed by Lucas Forschler.
3194
3195         Device type specific expected results covers two related ideas. The first (covered by this change)
3196         is where to search for -expected.* files. The second is which tests to run based on the
3197         TestExpectations.txt file.
3198
3199         After this change, the baseline search path will be determined by the type of device running a
3200         test. Device type will be passed into any function which picks a file based on the baseline search
3201         path.
3202
3203         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3204         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3205         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3206         (Manager.run): Print baseline search path for each round of devices.
3207         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3208         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3209         (SingleTestRunner._expected_driver_output): Ditto.
3210         (SingleTestRunner._driver_input): Ditto.
3211         * Scripts/webkitpy/layout_tests/views/printing.py:
3212         (Printer.print_config): Move printing of baseline search path to a separate function.
3213         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3214         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3215         (Testprinter.test_print_config):
3216         (Testprinter.test_print_baseline_search_path):
3217         * Scripts/webkitpy/port/base.py:
3218         (Port.baseline_search_path): Pass device_type through.
3219         (Port._expected_baselines_for_suffixes): Ditto.
3220         (Port.expected_baselines): Ditto.
3221         (Port.expected_filename): Ditto.
3222         (Port.expected_checksum): Ditto.
3223         (Port.expected_image): Ditto.
3224         (Port.expected_audio): Ditto.
3225         (Port.expected_text): Ditto.
3226         (Port.reference_files): Ditto.
3227         (Port.tests): Ditto.
3228         (Port._expanded_paths): Ditto.
3229         (Port.skipped_layout_tests): Ditto.
3230         (Port.expectations_dict): Ditto.
3231         (Port._port_specific_expectations_files): Ditto.
3232         (Port.expectations_files): Ditto.
3233         (Port.test_search_path): Ditto.
3234         (Port._tests_for_other_platforms): Ditto.
3235         * Scripts/webkitpy/port/base_unittest.py:
3236         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3237         (PortTest.test_nonexistant_expectations): Ditto.
3238         (test_ref_tests_platform_directory): Ditto.
3239         * Scripts/webkitpy/port/darwin.py:
3240         (DarwinPort._port_specific_expectations_files): Accept device_type.
3241         * Scripts/webkitpy/port/driver.py:
3242         (DriverProxy):
3243         (DriverProxy.host): Expose _target_host for device_type information.
3244         * Scripts/webkitpy/port/gtk.py:
3245         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3246         * Scripts/webkitpy/port/ios.py:
3247         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3248         * Scripts/webkitpy/port/mac.py:
3249         (MacPort. default_baseline_search_path): Ditto.
3250         * Scripts/webkitpy/port/port_testcase.py:
3251         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3252         * Scripts/webkitpy/port/test.py:
3253         * Scripts/webkitpy/port/watch.py:
3254         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3255         * Scripts/webkitpy/port/win.py:
3256         (WinPort.test_search_path): Accept, but do not use, device_type.
3257         * Scripts/webkitpy/port/wpe.py:
3258         (WPEPort._port_specific_expectations_files): Ditto.
3259         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3260         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3261
3262 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3263
3264         [LFC] Use the containing block's padding box to position out-of-flow elements.
3265         https://bugs.webkit.org/show_bug.cgi?id=193431
3266
3267         Reviewed by Antti Koivisto.
3268
3269         * LayoutReloaded/misc/LFC-passing-tests.txt:
3270
3271 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3272
3273         Move a test implementation file that got misplaced in the Xcode project
3274
3275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3276
3277 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3278
3279         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3280         r239913, and r239914.
3281         https://bugs.webkit.org/show_bug.cgi?id=193407
3282
3283         These revisions caused an internal failure (Requested by
3284         Truitt on #webkit).
3285
3286         Reverted changesets:
3287
3288         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3289         https://bugs.webkit.org/show_bug.cgi?id=186016
3290         https://trac.webkit.org/changeset/239901
3291
3292         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3293         https://trac.webkit.org/changeset/239909
3294
3295         "Tried to fix the build."
3296         https://trac.webkit.org/changeset/239910
3297
3298         "Fixed iOS builds after r239910."
3299         https://trac.webkit.org/changeset/239912
3300
3301         "More build fixing."
3302         https://trac.webkit.org/changeset/239913
3303
3304         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3305         https://trac.webkit.org/changeset/239914
3306
3307 2019-01-14  Mark Lam  <mark.lam@apple.com>
3308
3309         Re-enable ability to build --cloop builds.
3310         https://bugs.webkit.org/show_bug.cgi?id=192955
3311         <rdar://problem/46882363>
3312
3313         Reviewed by Saam barati and Keith Miller.
3314
3315         The --cloop build option was being ignored this whole time since r236381.
3316         This patch makes it possible to build CLoop builds again.
3317
3318         * Scripts/build-jsc:
3319         * Scripts/webkitperl/FeatureList.pm:
3320         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3321
3322 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3323
3324         webkitpy: Expose device_type from host-like objects
3325         https://bugs.webkit.org/show_bug.cgi?id=193406
3326         <rdar://problem/47262305>
3327
3328         Reviewed by Lucas Forschler.
3329
3330         Devices should expose device_type. As a result, all host objects should
3331         provide a device_type property, even if they do not yet define a device_type.
3332
3333         * Scripts/webkitpy/common/system/systemhost.py:
3334         (SystemHost):
3335         (SystemHost.device_type):
3336         * Scripts/webkitpy/common/system/systemhost_mock.py:
3337         (MockSystemHost):
3338         (MockSystemHost.device_type):
3339         * Scripts/webkitpy/port/device.py:
3340         (Device):
3341         (Device.device_type):
3342         * Scripts/webkitpy/xcode/simulated_device.py:
3343         (SimulatedDeviceManager._find_exisiting_device_for_request):
3344         (SimulatedDeviceManager._disambiguate_device_type):
3345         (SimulatedDeviceManager._does_fulfill_request):
3346         (SimulatedDeviceManager.device_count_for_type):
3347         (SimulatedDeviceManager.initialize_devices):
3348         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3349         (test_available_devices):
3350         (test_swapping_devices):
3351
3352 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3353
3354         webkitpy: Support alternate simctl device list output (Follow-up fix)
3355         https://bugs.webkit.org/show_bug.cgi?id=193362
3356         <rdar://problem/47122965>
3357
3358         Rubber-stamped by Lucas Forschler.
3359
3360         * Scripts/webkitpy/xcode/simulated_device.py:
3361         (SimulatedDeviceManager.populate_available_devices):
3362
3363 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3364
3365         [iOS] Expose SPI to access the current sentence boundary and selection state
3366         https://bugs.webkit.org/show_bug.cgi?id=193398
3367         <rdar://problem/45893108>
3368
3369         Reviewed by Dean Jackson.
3370
3371         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3372         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3373         expected.
3374
3375         * TestWebKitAPI/EditingTestHarness.h:
3376         * TestWebKitAPI/EditingTestHarness.mm:
3377         (-[EditingTestHarness moveBackward]):
3378         (-[EditingTestHarness moveForward]):
3379         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3380
3381         Add a couple of new helper methods on EditingTestHarness.
3382
3383         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3384         (-[SelectionChangeObserver initWithWebView:]):
3385         (-[SelectionChangeObserver webView]):
3386         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3387         (-[SelectionChangeObserver currentSelectionAttributes]):
3388
3389 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3390
3391         [LFC][BFC] Add basic box-sizing support.
3392         https://bugs.webkit.org/show_bug.cgi?id=193392
3393
3394         Reviewed by Antti Koivisto.
3395
3396         * LayoutReloaded/misc/LFC-passing-tests.txt:
3397
3398 2019-01-14  Charlie Turner  <cturner@igalia.com>
3399
3400         [WPE] API test gardening
3401         https://bugs.webkit.org/show_bug.cgi?id=193319
3402
3403         Reviewed by Michael Catanzaro.
3404
3405         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3406         passing tests.
3407
3408 2019-01-14  Charlie Turner  <cturner@igalia.com>
3409
3410         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3411         https://bugs.webkit.org/show_bug.cgi?id=192977
3412
3413         Reviewed by Carlos Garcia Campos.
3414
3415         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3416         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3417         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3418         (TestWebKitAPI::GStreamerTest::SetUp):
3419         (TestWebKitAPI::GStreamerTest::TearDown):
3420         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3421         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3422         (TestWebKitAPI::TEST_F):
3423
3424 2019-01-14  Charlie Turner  <cturner@igalia.com>
3425
3426         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3427         https://bugs.webkit.org/show_bug.cgi?id=193332
3428
3429         Reviewed by Michael Catanzaro.
3430
3431         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3432         defined as a char16_t, which changed in ICU 59, the
3433         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3434         unsigned short. This test is relying on the behaviour that
3435         UChar=unsigned short, which doesn't hold across platforms and ICU
3436         library versions. The full fix would be a special syntax for
3437         literal characters so that these ambiguities do not arise. That
3438         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3439         (TestWebKitAPI::TEST):
3440
3441 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3442
3443         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3444
3445         * Scripts/make-dist:
3446         (Distcheck.configure):
3447
3448 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3449
3450         [ews-build] Update macOS queue configurations
3451         https://bugs.webkit.org/show_bug.cgi?id=193365
3452         <rdar://problem/47221073>
3453
3454         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3455
3456         * BuildSlaveSupport/ews-build/config.json:
3457
3458 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3459
3460         [LFC] Adjust assert for statically positioned fixed elements
3461         https://bugs.webkit.org/show_bug.cgi?id=193385
3462
3463         Reviewed by Antti Koivisto.
3464
3465         * LayoutReloaded/misc/LFC-passing-tests.txt:
3466
3467 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3468
3469         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3470         https://bugs.webkit.org/show_bug.cgi?id=193387
3471
3472         Reviewed by Carlos Garcia Campos.
3473
3474         * MiniBrowser/wpe/main.cpp:
3475         (main):
3476
3477 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3478
3479         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3480         https://bugs.webkit.org/show_bug.cgi?id=191655
3481         rdar://problem/46074680
3482
3483         Reviewed by Megan Gardner.
3484
3485         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3486         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3487
3488 2019-01-12  Dan Bernstein  <mitz@apple.com>
3489
3490         [Cocoa] Avoid importing directly from subumbrella frameworks
3491         https://bugs.webkit.org/show_bug.cgi?id=186016
3492         <rdar://problem/40591038>
3493
3494         Reviewed by Sam Weinig.
3495
3496         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3497           LaunchServices header.
3498         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3499           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3500         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3501           when using SDKs earlier than 10.13.
3502         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3503           and OTHER_CPLUSPLUSFLAGS.
3504         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3505           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3506         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3507           LaunchServices header.
3508
3509 2019-01-11  John Wilander  <wilander@apple.com>
3510
3511         Compile out Web API Statistics Collection
3512         https://bugs.webkit.org/show_bug.cgi?id=193370
3513         <rdar://problem/45388584>
3514
3515         Reviewed by Brent Fulgham.
3516
3517         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3518             Defined ENABLE_WEB_API_STATISTICS, off by default.
3519
3520 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3521
3522         [WPE] Add gtk-doc
3523         https://bugs.webkit.org/show_bug.cgi?id=178900
3524
3525         Reviewed by Michael Catanzaro.
3526
3527         Add Tools/gtkdoc to manifest.txt.in files.
3528         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3529
3530         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3531         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3532
3533 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3534
3535         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3536         https://bugs.webkit.org/show_bug.cgi?id=193364
3537         <rdar://problem/47214117>
3538
3539         Reviewed by Tim Horton.
3540
3541         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3542         precise, whereas dragging near the middle of the textarea does.
3543
3544         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3545         (TestWebKitAPI::TEST):
3546
3547 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3548
3549         webkitpy: Support alternate simctl device list output
3550         https://bugs.webkit.org/show_bug.cgi?id=193362
3551         <rdar://problem/47122965>
3552
3553         Reviewed by Lucas Forschler.
3554
3555         * Scripts/webkitpy/xcode/simulated_device.py:
3556         (SimulatedDeviceManager.populate_available_devices):
3557
3558 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3559
3560         [ews-build] Update macOS queue configurations
3561         https://bugs.webkit.org/show_bug.cgi?id=193365
3562
3563         Reviewed by Lucas Forschler.
3564
3565         * BuildSlaveSupport/ews-build/config.json:
3566
3567 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3568
3569         webkitpy: Incorporate device type into baseline search path
3570         https://bugs.webkit.org/show_bug.cgi?id=193356
3571         <rdar://problem/47215515>
3572
3573         Reviewed by Lucas Forschler.
3574
3575         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3576
3577         * Scripts/webkitpy/port/base.py:
3578         (Port.default_baseline_search_path): Allow device type to be passed in.
3579         * Scripts/webkitpy/port/gtk.py:
3580         (GtkPort.default_baseline_search_path): Ignore device type.
3581         * Scripts/webkitpy/port/ios.py:
3582         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3583         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3584         * Scripts/webkitpy/port/ios_device_unittest.py:
3585         (IOSDeviceTest):
3586         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3587         (IOSSimulatorTest):
3588         * Scripts/webkitpy/port/mac.py:
3589         (MacPort.default_baseline_search_path): Ignore device type.
3590         * Scripts/webkitpy/port/watch.py:
3591         (WatchPort.default_baseline_search_path): Ditto.
3592         * Scripts/webkitpy/port/win.py:
3593         (WinPort.default_baseline_search_path): Ditto.
3594         (WinCairoPort.default_baseline_search_path): Ditto.
3595         * Scripts/webkitpy/port/wpe.py:
3596         (WPEPort.default_baseline_search_path): Ditto.
3597
3598 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3599
3600         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3601         https://bugs.webkit.org/show_bug.cgi?id=193352
3602         <rdar://problem/47210736>
3603
3604         Reviewed by Lucas Forschler.
3605
3606         * Scripts/webkitpy/layout_tests/views/printing.py:
3607         (Printer.print_config): Print list on only baseline search paths which exist. 
3608         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3609         (Testprinter.test_print_config):
3610
3611 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3612
3613         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3614         https://bugs.webkit.org/show_bug.cgi?id=193340
3615
3616         Reviewed by David Kilzer.
3617
3618         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3619         (WTR::InjectedBundle::didReceiveMessageToPage):
3620         Pull the strings out into a WKRetainPtr.
3621
3622         * WebKitTestRunner/WebNotificationProvider.cpp:
3623         (WTR::WebNotificationProvider::closeWebNotification):
3624         Adopt the created value into the WKRetainPtr.
3625
3626         * WebKitTestRunner/mac/TestControllerMac.mm:
3627         (WTR::generateWhitelist):
3628         Immediately adopt a created value to avoid potential mistakes.
3629
3630 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3631
3632         Enable DFG on ARM/Linux again
3633         https://bugs.webkit.org/show_bug.cgi?id=192496
3634
3635         Reviewed by Yusuke Suzuki.
3636
3637         After changing the bytecode format DFG was disabled on all 32-bit
3638         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3639         on ARM by default.
3640
3641         * Scripts/run-jsc-stress-tests:
3642
3643 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3644
3645         Unreviewed, fix #ifdef in API test added in r239851.
3646         https://bugs.webkit.org/show_bug.cgi?id=193327
3647         rdar://problem/47093222
3648
3649         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3650
3651 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3652
3653         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3654         https://bugs.webkit.org/show_bug.cgi?id=193109
3655         <rdar://problem/44807048>
3656
3657         Reviewed by Ryosuke Niwa.
3658
3659         Introduce and respect a test option to enable the UndoManager API.
3660
3661         * WebKitTestRunner/TestController.cpp:
3662         (WTR::updateTestOptionsFromTestHeader):
3663         * WebKitTestRunner/TestOptions.h:
3664         (WTR::TestOptions::hasSameInitializationOptions const):
3665         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3666         (WTR::TestController::platformCreateWebView):
3667
3668 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3669
3670         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3671         https://bugs.webkit.org/show_bug.cgi?id=193346
3672
3673         Reviewed by Antti Koivisto.
3674
3675         * LayoutReloaded/misc/LFC-passing-tests.txt:
3676
3677 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3678
3679         Unreviewed, fix typo that breaks dashboard link.
3680
3681         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3682         (WebKitBuildbot):
3683
3684 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3685
3686         Update macOS queue configurations
3687         https://bugs.webkit.org/show_bug.cgi?id=193329
3688
3689         Reviewed by Alexey Proskuryakov.
3690
3691         * BuildSlaveSupport/build.webkit.org-config/config.json:
3692         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3693         (BubbleQueueServer):
3694         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3695         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3696         (WebKitBuildbot):
3697         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3698         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3699         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3700
3701 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3702
3703         MiniBrowser should be able to navigate to about:blank
3704         https://bugs.webkit.org/show_bug.cgi?id=193345
3705
3706         Reviewed by Simon Fraser.
3707
3708         * MiniBrowser/mac/BrowserWindowController.m:
3709         (-[BrowserWindowController addProtocolIfNecessary:]):
3710         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3711
3712         * MiniBrowser/mac/WK1BrowserWindowController.m:
3713         (-[WK1BrowserWindowController fetch:]):
3714         * MiniBrowser/mac/WK2BrowserWindowController.m:
3715         (-[WK2BrowserWindowController fetch:]):
3716         Clean up the code that uses this to match style.
3717
3718 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3719
3720         Remove MiniBrowser custom "Process Swap" menu item which does not work
3721         https://bugs.webkit.org/show_bug.cgi?id=193344
3722
3723         Reviewed by Simon Fraser.
3724
3725         There is a menu item under the Experimental menu that does work.
3726
3727         * MiniBrowser/mac/AppDelegate.m:
3728         (defaultConfiguration):
3729         * MiniBrowser/mac/SettingsController.h:
3730         * MiniBrowser/mac/SettingsController.m:
3731         (-[SettingsController _populateMenu]):
3732         (-[SettingsController validateMenuItem:]):
3733         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3734         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3735
3736 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3737
3738         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3739         https://bugs.webkit.org/show_bug.cgi?id=193327
3740         rdar://problem/47093222
3741
3742         Reviewed by Tim Horton.
3743
3744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3745         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3746         (TestWebKitAPI::didFinishNavigation):
3747         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3748         (TestWebKitAPI::TEST):
3749         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3750         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3751         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3752         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3753         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3754
3755 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3756
3757         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3758         https://bugs.webkit.org/show_bug.cgi?id=193338
3759         <rdar://problem/46664774>
3760
3761         Reviewed by David Kilzer.
3762
3763         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3764         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3765
3766 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3767
3768         Unreviewed, rolling out r239825.
3769         https://bugs.webkit.org/show_bug.cgi?id=193330
3770
3771         Broke tests on armv7/linux bots (Requested by guijemont on
3772         #webkit).
3773
3774         Reverted changeset:
3775
3776         "Enable DFG on ARM/Linux again"
3777         https://bugs.webkit.org/show_bug.cgi?id=192496
3778         https://trac.webkit.org/changeset/239825
3779
3780 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3781
3782         Disable the run-jsc-stress-test remote host key check.
3783         https://bugs.webkit.org/show_bug.cgi?id=192988
3784
3785         Reviewed by Alexey Proskuryakov.
3786
3787         * Scripts/run-jsc-stress-tests:
3788
3789 2019-01-10  John Wilander  <wilander@apple.com>
3790
3791         Override the session configuration for cookieAcceptPolicy
3792         https://bugs.webkit.org/show_bug.cgi?id=190925
3793         <rdar://problem/45497382>
3794
3795         Reviewed by Alexey Proskuryakov and Alex Christensen.
3796
3797         Test infrastructure for setting a first-party-only cookie policy.
3798
3799         * DumpRenderTree/TestRunner.cpp:
3800         (setOnlyAcceptFirstPartyCookiesCallback):
3801         (TestRunner::staticFunctions):
3802         * DumpRenderTree/TestRunner.h:
3803         * DumpRenderTree/mac/TestRunnerMac.mm:
3804         (TestRunner::setOnlyAcceptFirstPartyCookies):
3805         * DumpRenderTree/win/TestRunnerWin.cpp:
3806         (TestRunner::setOnlyAcceptFirstPartyCookies):
3807         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3808         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3809         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3810         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3811         * WebKitTestRunner/TestInvocation.cpp:
3812         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3813
3814 2019-01-09  Matt Rajca  <mrajca@apple.com>
3815
3816         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
3817         https://bugs.webkit.org/show_bug.cgi?id=193301
3818
3819         Reviewed by Jer Noble.
3820         
3821         Added API tests.
3822
3823         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3824         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3825         (TEST):
3826         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
3827
3828 2019-01-10  Zalan Bujtas  <zalan@apple.com>
3829
3830         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
3831         https://bugs.webkit.org/show_bug.cgi?id=193310
3832
3833         Reviewed by Antti Koivisto.
3834
3835         * LayoutReloaded/misc/LFC-passing-tests.txt:
3836
3837 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
3838
3839         Enable DFG on ARM/Linux again
3840         https://bugs.webkit.org/show_bug.cgi?id=192496
3841
3842         Reviewed by Yusuke Suzuki.
3843
3844         After changing the bytecode format DFG was disabled on all 32-bit
3845         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3846         on ARM by default.
3847
3848         * Scripts/run-jsc-stress-tests:
3849
3850 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3851
3852         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
3853         https://bugs.webkit.org/show_bug.cgi?id=193271
3854
3855         Reviewed by Brent Fulgham.
3856
3857         BSTR is a special data structure created by SysAllocString, not a
3858         wchar_t null-terminated string.
3859
3860         * DumpRenderTree/win/TestRunnerWin.cpp:
3861         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
3862         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3863         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
3864         BSTR from wide string literals.
3865
3866 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
3867
3868         Tweak wording for build/version_check style checker error
3869         https://bugs.webkit.org/show_bug.cgi?id=193256
3870
3871         Reviewed by Tim Horton.
3872
3873         * Scripts/webkitpy/style/checkers/cpp.py:
3874         (check_os_version_checks):
3875         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3876         (WebKitStyleTest.test_os_version_checks):
3877
3878 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3879
3880         [ews-build] Add link to bug along with bug title
3881         https://bugs.webkit.org/show_bug.cgi?id=193293
3882
3883         Reviewed by Lucas Forschler.
3884
3885         * BuildSlaveSupport/ews-build/steps.py:
3886         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
3887         (ConfigureBuild.add_bug_id_url): Deleted.
3888         (ConfigureBuild.getBugURL): Deleted.
3889
3890 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3891
3892         [ews-build] Use https for ews-build server
3893         https://bugs.webkit.org/show_bug.cgi?id=193193
3894
3895         Reviewed by Lucas Forschler.
3896
3897         * BuildSlaveSupport/ews-build/steps.py:
3898
3899 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3900
3901         [ews-build] Parse and display number of style failures
3902         https://bugs.webkit.org/show_bug.cgi?id=193280
3903
3904         Reviewed by Lucas Forschler.
3905
3906         * BuildSlaveSupport/ews-build/steps.py:
3907         (CheckStyle): Use TestWithFailureCount as base class.
3908         (CheckStyle.countFailures): Count the number of style failures.
3909
3910 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3911
3912         [ews-build] use patch_id instead of ewspatchid
3913         https://bugs.webkit.org/show_bug.cgi?id=193235
3914
3915         Reviewed by Lucas Forschler.
3916
3917         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
3918         * BuildSlaveSupport/ews-build/steps.py: Ditto.
3919         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
3920
3921 2019-01-09  Zalan Bujtas  <zalan@apple.com>
3922
3923         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
3924         https://bugs.webkit.org/show_bug.cgi?id=192625
3925
3926         Reviewed by Antti Koivisto.
3927
3928         * LayoutReloaded/misc/LFC-passing-tests.txt:
3929
3930 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3931
3932         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
3933         https://bugs.webkit.org/show_bug.cgi?id=192841
3934
3935         Reviewed by Carlos Garcia Campos.
3936
3937         There are separate g_assert_*() macros for use in tests, which we use inconsistently
3938         currently. Use them always. We'll get nicer error messages now when tests fail, and the
3939         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
3940
3941         Note that the documentation of g_assert() says that it is not to be used when writing tests.
3942
3943         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3944         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3945         (WebKitWebEditorTest::testSelectionChanged):
3946         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3947         (WebKitFrameTest::testMainFrame):
3948         (WebKitFrameTest::testURI):
3949         (WebKitFrameTest::testJavaScriptContext):
3950         (WebKitFrameTest::testJavaScriptValues):
3951         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3952         (testWebViewAuthenticationRequest):
3953         (testWebViewAuthenticationLoadCancelled):
3954         (testWebViewAuthenticationFailure):
3955         (testWebViewAuthenticationStorage):
3956         (ProxyAuthenticationTest::ProxyAuthenticationTest):
3957         (testWebViewAuthenticationProxy):
3958         (testWebViewAuthenticationProxyHTTPS):
3959         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3960         (testAutomationSessionRequestSession):
3961         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3962         (testBackForwardListNavigation):
3963         (testWebKitWebViewSessionState):
3964         (testWebKitWebViewSessionStateWithFormData):
3965         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3966         (ConsoleMessageTest::consoleMessageReceivedCallback):
3967         (testWebKitConsoleMessageConsoleAPI):
3968         (testWebKitConsoleMessageJavaScriptException):
3969         (testWebKitConsoleMessageNetworkError):
3970         (testWebKitConsoleMessageSecurityError):
3971         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3972         (testCookieManagerAcceptPolicy):
3973         (testCookieManagerCookiesChanged):
3974         (testCookieManagerPersistentStorage):
3975         (testCookieManagerPersistentStorageDeleteAll):
3976         (testCookieManagerEphemeral):
3977         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
3978         (testWebKitDOMElementAutoFill):
3979         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3980         (downloadLocalFileSuccessfully):
3981         (createFileAtDestination):
3982         (testDownloadOverwriteDestinationDisallowed):
3983         (testDownloadLocalFileError):
3984         (testDownloadRemoteFile):
3985         (testDownloadRemoteFileError):
3986         (testWebViewDownloadURI):
3987         (testPolicyResponseDownload):
3988         (testPolicyResponseDownloadCancel):
3989         (testDownloadMIMEType):
3990         (contextMenuCallback):
3991         (testContextMenuDownloadActions):
3992         (testBlobDownload):
3993         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
3994         (testWebKitWebEditorSelectionChanged):
3995         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3996         (testWebKitFrameMainFrame):
3997         (testWebKitFrameURI):
3998         (testWebKitFrameJavaScriptContext):
3999         (testWebKitFrameJavaScriptValues):
4000         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4001         (LoadStopTrackingTest::loadFailed):
4002         (testWebViewTitle):
4003         (testURIRequestHTTPHeaders):
4004         (testURIRequestHTTPMethod):
4005         (testURIResponseHTTPHeaders):
4006         (testRedirectToDataURI):
4007         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
4008         (testProcessPerWebView):
4009         (testWebProcessLimit):
4010         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
4011         (testWebViewResources):
4012         (testWebResourceLoading):
4013         (testWebResourceSuggestedFilename):
4014         (testWebResourceGetData):
4015         (testWebResourceGetDataError):
4016         (testWebViewResourcesHistoryCache):
4017         (testWebResourceSendRequest):
4018         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
4019         (testSSL):
4020         (testInsecureContent):
4021         (testTLSErrorsPolicy):
4022         (testTLSErrorsRedirect):
4023         (testTLSErrorsHTTPAuth):
4024         (testLoadFailedWithTLSErrors):
4025         (testSubresourceLoadFailedWithTLSErrors):
4026         (httpsServerCallback):
4027         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
4028         (testWebViewCreateNavigationData):
4029         (testWebViewJavaScriptDialogs):
4030         (testWebViewWindowProperties):
4031         (testWebViewMouseTarget):
4032         (testWebViewFileChooserRequest):
4033         (testWebViewColorChooserRequest):
4034         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
4035         (testWebExtensionGetTitle):
4036         (testDocumentLoadedSignal):
4037         (testWebKitWebViewProcessCrashed):
4038         (testWebExtensionWindowObjectCleared):
4039         (testWebExtensionIsolatedWorld):
4040         (permissionRequestCallback):
4041         (didAssociateFormControlsCallback):
4042         (testWebExtensionFormControlsAssociated):
4043         (FormSubmissionTest::FormSubmissionTest):
4044         (FormSubmissionTest::testFormSubmissionResult):
4045         (testWebExtensionFormSubmissionSteps):
4046         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
4047         (testNotInitialized):
4048         (testClearDatabase):
4049         (testPrivateBrowsing):
4050         (testGetFavicon):
4051         (testWebViewFavicon):
4052         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
4053         (testFindControllerTextFound):
4054         (testFindControllerTextNotFound):
4055         (testFindControllerMatchCount):
4056         (testFindControllerMaxMatchCount):
4057         (testFindControllerNext):
4058         (testFindControllerPrevious):
4059         (testFindControllerCountedMatches):
4060         (testFindControllerOptions):
4061         (testFindControllerHide):
4062         (testFindControllerInstance):
4063         (testFindControllerGetters):
4064         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
4065         (testNavigationPolicy):
4066         (testResponsePolicy):
4067         (testNewWindowPolicy):
4068         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
4069         (testSecurityOriginBasicConstructor):
4070         (testSecurityOriginURIConstructor):
4071         (testSecurityOriginDefaultPort):
4072         (testSecurityOriginFileURI):
4073         (testOpaqueSecurityOrigin):
4074         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
4075         (testWebKitSettings):
4076         (testWebKitSettingsNewWithSettings):
4077         (testWebKitSettingsUserAgent):
4078         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4079         (testWebViewNewWithUserContentManager):
4080         (isStyleSheetInjectedForURLAtPath):
4081         (isScriptInjectedForURLAtPath):
4082         (testUserContentManagerInjectedStyleSheet):
4083         (testUserContentManagerInjectedScript):
4084         (UserScriptMessageTest::scriptMessageReceived):
4085         (UserScriptMessageTest::waitUntilMessageReceived):
4086         (UserScriptMessageTest::runJavaScriptFinished):
4087         (testUserContentManagerScriptMessageReceived):
4088         (testUserContentManagerScriptMessageInWorldReceived):
4089         (testUserContentManagerScriptMessageFromDOMBindings):
4090         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
4091         (testWebContextDefault):
4092         (testWebContextEphemeral):
4093         (testWebContextGetPlugins):
4094         (testWebContextURIScheme):
4095         (testWebContextSpellChecker):
4096         (testWebContextLanguages):
4097         (consoleMessageReceivedCallback):
4098         (testWebContextSecurityFileXHR):
4099         (ProxyTest::ProxyTest):
4100         (testWebContextProxySettings):
4101         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4102         (testWebViewWebContext):
4103         (testWebViewWebBackend):
4104         (testWebViewEphemeral):
4105         (testWebViewCustomCharset):
4106         (testWebViewSettings):
4107         (testWebViewRunJavaScript):
4108         (testWebViewCanShowMIMEType):
4109         (testWebViewSubmitForm):
4110         (testWebViewSave):
4111         (testWebViewPageVisibility):
4112         (testWebViewSnapshot):
4113         (testWebViewNotification):
4114         (testWebViewNotificationInitialPermissionAllowed):
4115         (testWebViewNotificationInitialPermissionDisallowed):
4116         (testWebViewIsPlayingAudio):
4117         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
4118         (WebsiteDataTest::WebsiteDataTest):
4119         (WebsiteDataTest::remove):
4120         (WebsiteDataTest::clear):
4121         (testWebsiteDataConfiguration):
4122         (testWebsiteDataEphemeral):
4123         (testWebsiteDataCache):
4124         (testWebsiteDataStorage):
4125         (testWebsiteDataDatabases):
4126         (testWebsiteDataAppcache):
4127         (testWebsiteDataCookies):
4128         (testWebsiteDataDeviceIdHashSalt):
4129         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
4130         (emitDocumentLoaded):
4131         (emitURIChanged):
4132         (sendRequestCallback):
4133         (contextMenuCallback):
4134         (consoleMessageSentCallback):
4135         (emitFormControlsAssociated):
4136         (formControlsAssociatedCallback):
4137         (emitFormSubmissionEvent):
4138         (willSubmitFormCallback):
4139         (windowObjectCleared):
4140         (methodCallCallback):
4141         (registerGResource):
4142         (webkit_web_extension_initialize_with_user_data):
4143         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
4144         (checkLeaks):
4145         (WebProcessTest::create):
4146         (runTest):
4147         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
4148         (AutocleanupsTest::testWebProcessAutocleanups):
4149         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
4150         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
4151         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
4152         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
4153         (WebKitDOMDOMWindowTest::testSignals):
4154         (WebKitDOMDOMWindowTest::testDispatchEvent):
4155         (WebKitDOMDOMWindowTest::testGetComputedStyle):
4156         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
4157         (WebKitDOMNodeFilterTest::testTreeWalker):
4158         (WebKitDOMNodeFilterTest::testNodeIterator):
4159         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
4160         (WebKitDOMNodeTest::testHierarchyNavigation):
4161         (WebKitDOMNodeTest::testInsertion):
4162         (WebKitDOMNodeTest::testTagNamesNodeList):
4163         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
4164         (WebKitDOMNodeTest::testDOMCache):
4165         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
4166         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
4167         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
4168         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
4169         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
4170         (testUIProcessAutocleanups):
4171         (testWebProcessAutocleanups):
4172         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
4173         (testContextMenuPopulateMenu):
4174         (testContextMenuDismissed):
4175         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
4176         (testWebKitDOMClientRectDivBoundingClientRectPosition):
4177         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
4178         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
4179         (testWebKitDOMDOMWindowSignals):
4180         (testWebKitDOMDOMWindowDispatchEvent):
4181         (testWebKitDOMDOMWindowGetComputedStyle):
4182         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
4183         (testWebKitDOMNodeHierarchyNavigation):
4184         (testWebKitDOMNodeInsertion):
4185         (testWebKitDOMNodeTagNamesNodeList):
4186         (testWebKitDOMNodeTagNamesHTMLCollection):
4187         (testWebKitDOMObjectCache):
4188         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
4189         (testWebKitDOMNodeFilterTreeWalker):
4190         (testWebKitDOMNodeFilterNodeIterator):
4191         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
4192         (testWebKitDOMXPathNSResolverNative):
4193         (testWebKitDOMXPathNSResolverCustom):
4194         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
4195         (testInspectorDefault):
4196         (testInspectorManualAttachDetach):
4197         (testInspectorCustomContainerDestroyed):
4198         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
4199         (startTestServer):
4200         (testInspectorServerPageList):
4201         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
4202         (OptionMenuTest::showOptionMenuCallback):
4203         (OptionMenuTest::menuCloseCallback):
4204         (OptionMenuTest::close):
4205         (OptionMenuTest::activateItem):
4206         (OptionMenuTest::selectItem):
4207         (testOptionMenuSimple):
4208         (testOptionMenuGroups):
4209         (testOptionMenuActivate):
4210         (testOptionMenuSelect):
4211         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
4212         (testPrintOperationPrintSettings):
4213         (webViewPrintCallback):
4214         (testPrintOperationPrint):
4215         (testPrintCustomWidget):
4216         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
4217         (checkAtspiAccessible):
4218         (testAtspiBasicHierarchy):
4219         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
4220         (testWebKitCheckVersion):
4221         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
4222         (testWebViewEditorCutCopyPasteNonEditable):
4223         (testWebViewEditorCutCopyPasteEditable):
4224         (testWebViewEditorSelectAllNonEditable):
4225         (testWebViewEditorSelectAllEditable):
4226         (loadContentsAndTryToCutSelection):
4227         (testWebViewEditorNonEditable):
4228         (testWebViewEditorEditable):
4229         (testWebViewEditorEditorStateTypingAttributes):
4230         (testWebViewEditorInsertImage):
4231         (testWebViewEditorCreateLink):
4232         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
4233         (loadChangedCallback):
4234         (loadFailedCallback):
4235         (loadFailedWithTLSErrorsCallback):
4236         (LoadTrackingTest::LoadTrackingTest):
4237         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4238         (registerGResource):
4239         (removeNonEmptyDirectory):
4240         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4241         (Test::adoptView):
4242         (Test::~Test):
4243         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4244         (WebKitTestBus::getOrCreateConnection):
4245         (WebKitTestBus::createProxy):
4246         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
4247         (WebKitTestServer::getWebSocketURIForPath const):
4248         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
4249         (WebViewTest::initializeWebView):
4250         (WebViewTest::loadURI):
4251         (WebViewTest::loadHtml):
4252         (WebViewTest::loadPlainText):
4253         (WebViewTest::loadBytes):
4254         (WebViewTest::loadRequest):
4255         (WebViewTest::loadAlternateHTML):
4256         (WebViewTest::goBack):
4257         (WebViewTest::goForward):
4258         (WebViewTest::goToBackForwardListItem):
4259         (resourceGetDataCallback):
4260         (WebViewTest::mainResourceData):
4261         (WebViewTest::javascriptResultToCString):
4262         (WebViewTest::javascriptResultToNumber):
4263         (WebViewTest::javascriptResultToBoolean):
4264         (WebViewTest::javascriptResultIsNull):
4265         (WebViewTest::javascriptResultIsUndefined):
4266         (onSnapshotReady):
4267         (WebViewTest::runWebProcessTest):
4268         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
4269         (WebViewTest::platformInitializeWebView):
4270         (WebViewTest::showInWindow):
4271         (WebViewTest::showInWindowAndWaitUntilMapped):
4272         (WebViewTest::mouseMoveTo):
4273         (WebViewTest::emitPopupMenuSignal):
4274         (WebViewTest::keyStroke):
4275         (WebViewTest::doMouseButtonEvent):
4276
4277 2019-01-09  Philippe Normand  <pnormand@igalia.com>
4278
4279         [WPE] API tests can't run in flatpak environment
4280         https://bugs.webkit.org/show_bug.cgi?id=193242
4281
4282         Reviewed by Michael Catanzaro.
4283
4284         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
4285         flatpakutils so that it knows which port it's dealing with.
4286         * glib/common.py: Remove build_dir globals so that subsequent
4287         calls actually take args into account.
4288         (library_build_path):
4289         (binary_build_path):
4290
4291 2019-01-08  Dean Jackson  <dino@apple.com>
4292
4293         Blob references for System Previews don't get a correct file extension
4294         https://bugs.webkit.org/show_bug.cgi?id=193268
4295         <rdar://problem/47133037>
4296
4297         Reviewed by Tim Horton.
4298
4299         New test that a Blob download of a USDZ file gets named correctly.
4300
4301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4302         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4303         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4304         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
4305         (TEST):
4306         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
4307
4308 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
4309
4310         [WebAuthN] Support U2F HID Authenticators on macOS
4311         https://bugs.webkit.org/show_bug.cgi?id=191535
4312         <rdar://problem/47102027>
4313
4314         Reviewed by Brent Fulgham.
4315
4316         This patch:
4317         1) adds support for U2F mocking mechanism;
4318         2) updates tests to reflect U2fCommandConstructor changes.
4319
4320         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
4321         (TestWebKitAPI::TEST):
4322         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
4323         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4324         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
4325
4326 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
4327