Fix MiniBrowser's entitlements
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2
3         Fix MiniBrowser's entitlements
4         https://bugs.webkit.org/show_bug.cgi?id=192431
5
6         Reviewed by Joseph Pecoraro.
7
8         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
9         files, making it impossible to load any extension.
10
11         * MiniBrowser/MiniBrowser.entitlements:
12
13 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
14
15         [Cocoa] Ask platform for generic font family mappings
16         https://bugs.webkit.org/show_bug.cgi?id=187723
17         <rdar://problem/41892438>
18
19         Reviewed by Brent Fulgham.
20
21         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
22
23         * DumpRenderTree/mac/DumpRenderTree.mm:
24         (allowedFontFamilySet):
25         * WebKitTestRunner/mac/TestControllerMac.mm:
26         (WTR::allowedFontFamilySet):
27
28 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
29
30         [GTK] Implement back/forward touchpad gesture
31         https://bugs.webkit.org/show_bug.cgi?id=193919
32
33         Reviewed by Michael Catanzaro.
34
35         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
36         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
37
38 2019-02-08  Alex Christensen  <achristensen@webkit.org>
39
40         Add SPI to use networking daemon instead of XPC service
41         https://bugs.webkit.org/show_bug.cgi?id=194427
42
43         Reviewed by Geoffrey Garen
44
45         * MiniBrowser/MiniBrowser.entitlements:
46
47 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
48
49         [ews-build] Ensure that every builder in config.json has short name
50         https://bugs.webkit.org/show_bug.cgi?id=194461
51
52         Reviewed by Lucas Forschler.
53
54         * BuildSlaveSupport/ews-build/loadConfig.py:
55         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
56
57 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
58
59         [ews-build] Add short name to config.json
60         https://bugs.webkit.org/show_bug.cgi?id=194456
61
62         Reviewed by Lucas Forschler.
63
64         * BuildSlaveSupport/ews-build/config.json: Added short name.
65         * BuildSlaveSupport/ews-build/loadConfig.py:
66         (loadBuilderConfig): Set the short name as the builder description.
67
68 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
69
70         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
71         https://bugs.webkit.org/show_bug.cgi?id=194418
72
73         Reviewed by Lucas Forschler.
74
75         Do not include errors trying when finding crashlogs at the end of
76         a run-webkit-tests run since we don't process those errors.
77
78         * Scripts/webkitpy/port/darwin.py:
79         (DarwinPort._look_for_all_crash_logs_in_log_dir):
80         * Scripts/webkitpy/port/ios_device.py:
81         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
82         * Scripts/webkitpy/port/watch_device.py:
83         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
84
85 2019-02-08  Beth Dakin  <bdakin@apple.com>
86
87         Add afterScreenUpdates to WKSnapshotConfiguration
88         https://bugs.webkit.org/show_bug.cgi?id=194362
89         -and corresponding-
90         <rdar://problem/40655528> Please add an "after screen updates" property to 
91         WKSnapshotConfiguration (to solve blank snapshots)
92
93         Reviewed by Tim Horton.
94
95         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
96         (TEST):
97
98 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
99
100         clampTo(): do not convert the input to double when dealing with integers
101         https://bugs.webkit.org/show_bug.cgi?id=194263
102         <rdar://problem/47692312>
103
104         Reviewed by Darin Adler.
105
106         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
107         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
108         (TestWebKitAPI::testClampFloatingPointToInteger):
109         (TestWebKitAPI::testClampSameSignIntegers):
110         (TestWebKitAPI::testClampUnsignedToSigned):
111         (TestWebKitAPI::testClampSignedToUnsigned):
112
113 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
114
115         webkitpy: Respect --dedicated-simulators flag
116         https://bugs.webkit.org/show_bug.cgi?id=194416
117         <rdar://problem/47894722>
118
119         Reviewed by Lucas Forschler.
120
121         * Scripts/webkitpy/port/device_port.py:
122         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
123         available devices can be safely ignored.
124
125 2019-02-07  Keith Rollin  <krollin@apple.com>
126
127         Remove extra copy of 100x100-red.tga
128         https://bugs.webkit.org/show_bug.cgi?id=194371
129         <rdar://problem/47873465>
130
131         Reviewed by Said Abou-Hallawa.
132
133         In order to help it pass its tests, Bug 194190 added a second copy of
134         the file 100x100-red.tga. However, it turns out that this additional
135         file wasn't actually needed, and that that sole previous copy was
136         sufficient. At the same time, this second copy -- which was copied to
137         the same location in the build output as the first copy -- now caused
138         XCBuild to complain because there were two production rules for the
139         same output file. Address this by removing the newly-added extra copy.
140
141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
142         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
143
144 2019-02-07  Alex Christensen  <achristensen@webkit.org>
145
146         Deprecate WKBundlePageSetDefersLoading
147         https://bugs.webkit.org/show_bug.cgi?id=191394
148
149         Reviewed by Dean Jackson.
150
151         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
152         (WTR::TestRunner::setDefersLoading):
153
154 2019-02-07  Zalan Bujtas  <zalan@apple.com>
155
156         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
157         https://bugs.webkit.org/show_bug.cgi?id=194391
158
159         Reviewed by Antti Koivisto.
160
161         * LayoutReloaded/misc/LFC-passing-tests.txt:
162
163 2019-02-06  Keith Rollin  <krollin@apple.com>
164
165         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
166         https://bugs.webkit.org/show_bug.cgi?id=193975
167         <rdar://problem/47643306>
168
169         Reviewed by Tim Horton.
170
171         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
172         the Info.plist file into the bundle. This step is not necessary as the
173         implicit "bundle up all the build products into a framework" build
174         phase does this already. Having the Copy Bundle Resources phase do
175         this causes a conflict under XCBuild, which objects to two build
176         phases producing the same file (Info.plist). Address this by removing
177         Info.plist from the Copy Bundle Resources phase.
178
179         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
180
181 2019-02-06  Keith Rollin  <krollin@apple.com>
182
183         Really enable the automatic checking and regenerations of .xcfilelists during builds
184         https://bugs.webkit.org/show_bug.cgi?id=194357
185         <rdar://problem/47861231>
186
187         Reviewed by Chris Dumez.
188
189         Bug 194124 was supposed to enable the automatic checking and
190         regenerating of .xcfilelist files during the build. While related
191         changes were included in that patch, the change to actually enable the
192         operation somehow was omitted. This patch actually enables the
193         operation. The check-xcfilelist.sh scripts now check
194         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
195         from the checking.
196
197         * DumpRenderTree/Scripts/check-xcfilelists.sh:
198         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
199
200 2019-02-06  David Kilzer  <ddkilzer@apple.com>
201
202         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
203         <https://webkit.org/b/194286>
204         <rdar://problem/47815558>
205
206         Reviewed by Alexey Proskuryakov.
207
208         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
209         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
210         WKRetainPtr<> to avoid leaking the WKDataRef.
211
212 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
213
214         Unreviewed, fix a typo
215
216         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
217
218 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
219
220         [GTK][WPE] force libpsl build to use ICU in jhbuild
221         https://bugs.webkit.org/show_bug.cgi?id=194288
222
223         Reviewed by Carlos Garcia Campos.
224
225         * gtk/jhbuild.modules:
226         Require ICU for libpsl build in jhbuild, like done in WPE.
227
228 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
229
230         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
231         https://bugs.webkit.org/show_bug.cgi?id=194209
232
233         Reviewed by Carlos Garcia Campos.
234
235         Enhance TestCookieManager to ensure this doesn't happen again.
236
237         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
238         (testCookieManagerPersistentStorage):
239         (beforeAll):
240
241 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
242
243         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
244         https://bugs.webkit.org/show_bug.cgi?id=194324
245
246         Reviewed by Andy Estes.
247
248         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
249         part of the name is already implicit, since this is in testing code in TestOptions.
250
251         * WebKitTestRunner/TestController.cpp:
252         (WTR::TestController::generateContextConfiguration const):
253         (WTR::updateTestOptionsFromTestHeader):
254         * WebKitTestRunner/TestOptions.h:
255         (WTR::TestOptions::hasSameInitializationOptions const):
256
257 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
258
259         [ews-build] Allow * as platform for builders and workers
260         https://bugs.webkit.org/show_bug.cgi?id=188533
261
262         Reviewed by Lucas Forschler.
263
264         * BuildSlaveSupport/ews-build/loadConfig.py:
265         (checkWorkersAndBuildersForConsistency):
266
267 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
268
269         [ews-build] Add few bots to config.json
270         https://bugs.webkit.org/show_bug.cgi?id=194304
271
272         Reviewed by Lucas Forschler.
273
274         * BuildSlaveSupport/ews-build/config.json:
275
276 2019-02-05  Keith Rollin  <krollin@apple.com>
277
278         Enable the automatic checking and regenerations of .xcfilelists during builds
279         https://bugs.webkit.org/show_bug.cgi?id=194124
280         <rdar://problem/47721277>
281
282         Reviewed by Tim Horton.
283
284         Bug 193790 add a facility for checking -- during build time -- that
285         any needed .xcfilelist files are up-to-date and for updating them if
286         they are not. This facility was initially opt-in by setting
287         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
288         the process seemed robust. Its now time to enable this facility and
289         make it opt-out. If there is a need to disable this facility, set and
290         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
291         running `make` or `build-webkit`, or before running Xcode from the
292         command line.
293
294         Additionally, remove the step that generates a list of source files
295         going into the UnifiedSources build step. It's only necessarily to
296         specify Sources.txt and SourcesCocoa.txt as inputs.
297
298         * Scripts/generate-xcfilelists:
299
300 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
301
302         [GTK][WPE] force libpsl build to use ICU in jhbuild
303         https://bugs.webkit.org/show_bug.cgi?id=194288
304
305         Reviewed by Philippe Normand.
306
307         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
308         This can cause build failures if libidn is detected but libunistring is not available.
309
310         Make sure that ICU is used for runtime and builtin PSL data.
311
312         * gtk/jhbuild.modules:
313         * wpe/jhbuild.modules:
314
315 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
316
317         [ews-app] Modified timestamp should be updated on updating data
318         https://bugs.webkit.org/show_bug.cgi?id=194295
319
320         Reviewed by Lucas Forschler.
321
322         * BuildSlaveSupport/ews-app/ews/models/build.py:
323         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
324         * BuildSlaveSupport/ews-app/ews/models/step.py:
325
326 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
327
328         Unreviewed, rolling out r240742.
329
330         Causes crashes on iOS simulator.
331
332         Reverted changeset:
333
334         "[iOS] Keyups for non-modifier keys identified as "Dead" when
335         not focused in a content-editable element"
336         https://bugs.webkit.org/show_bug.cgi?id=192824
337         https://trac.webkit.org/changeset/240742
338
339 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
340
341         run-webkit-tests emits message "...running None" when running tests
342         https://bugs.webkit.org/show_bug.cgi?id=194133
343         <rdar://problem/47724738>
344
345         Reviewed by Lucas Forschler.
346
347         * Scripts/webkitpy/xcode/device_type.py:
348         (DeviceType.__str__): Use both version mapping tables and use just the variant
349         name if no version name is available.
350         * Scripts/webkitpy/xcode/device_type_unittest.py:
351         (DeviceTypeTest):
352         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
353         an associated named.
354
355 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
356
357         [WPE] require python3-setuptools for meson build in jhbuild
358         https://bugs.webkit.org/show_bug.cgi?id=194287
359
360         Reviewed by Philippe Normand.
361
362         python3-setuptools is needed to build meson in jhbuild.
363         It is already required by the GTK port.
364
365         * wpe/install-dependencies:
366
367 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
368
369         [ews-app] Add method to save BuilderMapping to database
370         https://bugs.webkit.org/show_bug.cgi?id=194264
371
372         Reviewed by Lucas Forschler.
373
374         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
375         (BuilderMapping.__str__):
376         (BuilderMapping):
377         (BuilderMapping.save_mapping):
378         (BuilderMapping.update_mapping):
379         (BuilderMapping.get_existing_mapping):
380         (BuilderMapping.is_valid_mapping):
381
382 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
383
384         [ews-app] Add timestamp fields for BuilderMappings
385         https://bugs.webkit.org/show_bug.cgi?id=194266
386
387         Reviewed by Lucas Forschler.
388
389         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
390         (BuilderMapping):
391
392 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
393
394         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
395         https://bugs.webkit.org/show_bug.cgi?id=174816
396
397         Reviewed by Michael Catanzaro.
398
399         Add tests for webkit_uri_for_display().
400
401         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
402         (testURIForDisplayUnaffected):
403         (testURIForDisplayAffected):
404         (beforeAll):
405         (afterAll):
406         * TestWebKitAPI/glib/CMakeLists.txt:
407
408 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
409
410         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
411         https://bugs.webkit.org/show_bug.cgi?id=194158
412         <rdar://problem/47737268>
413
414         Rubber-stamped by Aakash Jain.
415
416         * Scripts/webkitpy/port/device_port.py:
417         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
418
419 2019-02-04  Said Abou-Hallawa  <said@apple.com>
420
421         [CG] Enable setAdditionalSupportedImageTypes for WK1
422         https://bugs.webkit.org/show_bug.cgi?id=194190
423
424         Reviewed by Tim Horton.
425
426         Add a test similar to the one under WebKit Cocoa but make it create a
427         WebView instead of a WKWebView.
428
429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
430         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
431         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
432         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
433         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
434         (TestWebKitAPI::runTest):
435         (TestWebKitAPI::TEST):
436
437 2019-02-04  Zalan Bujtas  <zalan@apple.com>
438
439         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
440         https://bugs.webkit.org/show_bug.cgi?id=194168
441
442         Reviewed by Simon Fraser.
443
444         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
445
446         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
447         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
448         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
449         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
450         (TEST):
451         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
452         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
453
454 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
455
456         REGRESSION (r237269): webkit-patch what-broke is broken 
457         https://bugs.webkit.org/show_bug.cgi?id=193025
458
459         Reviewed by Aakash Jain.
460
461         * Scripts/webkitpy/common/host.py:
462         (Host.buildbot):
463         (Host.bugzilla): Renamed to 'buildbot'.
464
465 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
466
467         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
468         https://bugs.webkit.org/show_bug.cgi?id=194207
469
470         Reviewed by Tim Horton.
471
472         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
473         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
474         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
475         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
476         start and delete forwards to remove the original attachment.
477
478         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
479         (TestWebKitAPI::TEST):
480
481 2019-02-04  Youenn Fablet  <youenn@apple.com>
482
483         Capture state should be managed consistently when doing process swapping
484         https://bugs.webkit.org/show_bug.cgi?id=194122
485         <rdar://problem/47609293>
486
487         Reviewed by Eric Carlson.
488
489         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
490         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
491         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
492         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
493         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
494         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
495         (WTR::TestRunner::isDoingMediaCapture const):
496         * WebKitTestRunner/InjectedBundle/TestRunner.h:
497         * WebKitTestRunner/TestController.cpp:
498         (WTR::TestController::isDoingMediaCapture const):
499         * WebKitTestRunner/TestController.h:
500         * WebKitTestRunner/TestInvocation.cpp:
501         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
502         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
503         (WTR::TestController::isDoingMediaCapture const):
504
505 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
506
507         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
508         https://bugs.webkit.org/show_bug.cgi?id=194142
509
510         Reviewed by Ross Kirsling.
511
512         There three 'separator' variables in TestController.cpp. Renamed
513         it 'pathSeparator', and unified them.
514
515         * WebKitTestRunner/TestController.cpp:
516         (WTR::TestController::generateContextConfiguration const):
517         (WTR::createTestURL):
518         (WTR::TestController::platformAdjustContext):
519
520 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
521
522         Make setNeedsLayout on the root more explicitly about triggering its side-effects
523         https://bugs.webkit.org/show_bug.cgi?id=194198
524
525         Reviewed by Antti Koivisto.
526
527         No need to set the banner heights on navigation now, since Page stores them.
528
529         * MiniBrowser/mac/WK2BrowserWindowController.m:
530         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
531
532 2019-02-03  John Wilander  <wilander@apple.com>
533
534         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
535         https://bugs.webkit.org/show_bug.cgi?id=194104
536         <rdar://problem/47649991>
537
538         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
539
540         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
541         (TestWebKitAPI::TEST):
542             Changed numeric types from unsigned short to uint32_t.
543
544 2019-02-02  David Kilzer  <ddkilzer@apple.com>
545
546         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
547         <https://webkit.org/b/194178>
548         <rdar://problem/47753473>
549
550         Reviewed by Alexey Proskuryakov.
551
552         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
553         (WTR::uninstallFakeHelvetica): Pass nullptr into
554         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
555
556 2019-02-02  Zalan Bujtas  <zalan@apple.com>
557
558         [LFC] Initialize ICB's style with fixed width/height.
559         https://bugs.webkit.org/show_bug.cgi?id=194188
560
561         Reviewed by Antti Koivisto.
562
563         * LayoutReloaded/misc/LFC-passing-tests.txt:
564
565 2019-02-02  Zalan Bujtas  <zalan@apple.com>
566
567         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
568         https://bugs.webkit.org/show_bug.cgi?id=194185
569
570         Reviewed by Antti Koivisto.
571
572         * LayoutReloaded/misc/LFC-passing-tests.txt:
573
574 2018-12-16  Darin Adler  <darin@apple.com>
575
576         Convert additional String::format clients to alternative approaches
577         https://bugs.webkit.org/show_bug.cgi?id=192746
578
579         Reviewed by Alexey Proskuryakov.
580
581         * WebKitTestRunner/TestController.cpp:
582         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
583         as an intermediate in code that ultimately constructs a WTF::String.
584         (WTR::userMediaOriginHash): Use makeString.
585         (WTR::TestController::didNavigateWithNavigationData): More of the same.
586         (WTR::TestController::didPerformClientRedirect): Ditto.
587         (WTR::TestController::didPerformServerRedirect): Ditto.
588         (WTR::TestController::didUpdateHistoryTitle): Ditto.
589
590 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
591
592         [ews-build] Add unit test to verify builder keys
593         https://bugs.webkit.org/show_bug.cgi?id=194152
594
595         Reviewed by Lucas Forschler.
596
597         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
598         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
599
600 2019-02-01  Zalan Bujtas  <zalan@apple.com>
601
602         [LFC] Expand tests coverage (12 new tests -> 787)
603
604         Unreviewed test gardening.
605
606         * LayoutReloaded/misc/LFC-passing-tests.txt:
607
608 2019-02-01  Zalan Bujtas  <zalan@apple.com>
609
610         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
611         https://bugs.webkit.org/show_bug.cgi?id=194163
612
613         Reviewed by Simon Fraser.
614
615         775
616
617         * LayoutReloaded/misc/LFC-passing-tests.txt:
618
619 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
620
621         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
622         https://bugs.webkit.org/show_bug.cgi?id=194140
623         <rdar://problem/47728098>
624
625         Reviewed by Tim Horton.
626
627         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
628         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
629         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
630
631         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
632         test to induce an IPC deadlock when presenting a modal alert during touch start.
633
634         * WebKitTestRunner/InjectedBundle/TestRunner.h:
635         * WebKitTestRunner/TestController.cpp:
636         (WTR::runJavaScriptAlert):
637
638         Add a client callback function for running JavaScript alerts.
639
640         (WTR::TestController::createOtherPage):
641         (WTR::TestController::generateContextConfiguration const):
642
643         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
644         the fix in this patch.
645
646         (WTR::TestController::createWebViewWithOptions):
647
648         Plumb TestOptions to generateContextConfiguration.
649
650         (WTR::TestController::resetPreferencesToConsistentValues):
651         (WTR::TestController::resetStateToConsistentValues):
652         (WTR::updateTestOptionsFromTestHeader):
653         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
654         (WTR::TestController::handleJavaScriptAlert):
655         * WebKitTestRunner/TestController.h:
656         * WebKitTestRunner/TestInvocation.cpp:
657         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
658         * WebKitTestRunner/TestOptions.h:
659         (WTR::TestOptions::hasSameInitializationOptions const):
660
661 2019-02-01  Chris Dumez  <cdumez@apple.com>
662
663         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
664         https://bugs.webkit.org/show_bug.cgi?id=193740
665         <rdar://problem/47527267>
666
667         Reviewed by Alex Christensen.
668
669         Add API test coverage.
670
671         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
672
673 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
674
675         [ews-app] Add display name field to BuilderMapping model
676         https://bugs.webkit.org/show_bug.cgi?id=194153
677
678         Reviewed by Lucas Forschler.
679
680         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
681         (BuilderMapping):
682
683 2019-02-01  Youenn Fablet  <youenn@apple.com>
684
685         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
686         https://bugs.webkit.org/show_bug.cgi?id=194155
687
688         Reviewed by Eric Carlson.
689
690         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
691         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
692         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
693
694 2019-02-01  Zalan Bujtas  <zalan@apple.com>
695
696         [LFC] Adjust replaced element's intrinsic ratio
697         https://bugs.webkit.org/show_bug.cgi?id=194154
698
699         Reviewed by Antti Koivisto.
700
701         761
702
703         * LayoutReloaded/misc/LFC-passing-tests.txt:
704
705 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
706
707         [WPE] Show test results in minibrowser
708         https://bugs.webkit.org/show_bug.cgi?id=194150
709
710         Reviewed by Žan Doberšek.
711
712         * Scripts/webkitpy/port/wpe.py:
713         (WPEPort.show_results_html_file):
714
715 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
716
717         [WPE] MiniBrowser: add ky bindings for back/forward navigation
718         https://bugs.webkit.org/show_bug.cgi?id=194151
719
720         Reviewed by Žan Doberšek.
721
722         ALT + <- go back
723         ALT + -> go forward
724
725         * MiniBrowser/wpe/main.cpp:
726         (main):
727
728 2019-02-01  Zalan Bujtas  <zalan@apple.com>
729
730         [LFC] Set intrinsic size on Layout::Replaced
731         https://bugs.webkit.org/show_bug.cgi?id=194139
732
733         Reviewed by Antti Koivisto.
734
735         744
736
737         * LayoutReloaded/misc/LFC-passing-tests.txt:
738
739 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
740
741         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
742         https://bugs.webkit.org/show_bug.cgi?id=194146
743
744         Reviewed by Xabier Rodriguez-Calvar.
745
746         It allows to open relative paths.
747
748         * MiniBrowser/wpe/main.cpp:
749         (main):
750
751 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
752
753         Update flakiness dashboard configuration after recent queue changes
754         https://bugs.webkit.org/show_bug.cgi?id=194127
755
756         Rubber-stamped by Aakash Jain.
757
758         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
759
760         * TestResultServer/static-dashboards/builders.jsonp:
761
762 2019-01-31  Youenn Fablet  <youenn@apple.com>
763
764         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
765         https://bugs.webkit.org/show_bug.cgi?id=194106
766         <rdar://problem/47676333>
767
768         Reviewed by Ryosuke Niwa.
769
770         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
771         (TestWebKitAPI::didFinishNavigation):
772         (TestWebKitAPI::TEST):
773         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
774
775 2019-01-31  Chris Dumez  <cdumez@apple.com>
776
777         Page zoom level is lost after a process swap or a crash
778         https://bugs.webkit.org/show_bug.cgi?id=194105
779         <rdar://problem/47610781>
780
781         Reviewed by Alex Christensen.
782
783         Add API test coverage.
784
785         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
786         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
787
788 2019-01-31  Alex Christensen  <achristensen@webkit.org>
789
790         Revert r238819 which is unneeded and caused a performance regression.
791         https://bugs.webkit.org/show_bug.cgi?id=192272
792         <rdar://problem/46664625>
793
794         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
795         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
796         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
797
798 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
799
800         Formalize WebKitAdditions mechanism of LoadOptimizer
801         https://bugs.webkit.org/show_bug.cgi?id=193886
802         <rdar://problem/47696809>
803
804         Reviewed by Brent Fulgham.
805
806         * MiniBrowser/MiniBrowser.entitlements:
807         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
808
809 2019-01-31  Zalan Bujtas  <zalan@apple.com>
810
811         [LFC] Margin before/after/start/end initial value is 0 and not auto.
812         https://bugs.webkit.org/show_bug.cgi?id=194090
813
814         Reviewed by Antti Koivisto.
815
816         * LayoutReloaded/misc/LFC-passing-tests.txt:
817
818 2019-01-31  Zalan Bujtas  <zalan@apple.com>
819
820         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
821         https://bugs.webkit.org/show_bug.cgi?id=194074
822
823         Reviewed by Antti Koivisto.
824
825         * LayoutReloaded/misc/LFC-passing-tests.txt:
826
827 2019-01-31  Zalan Bujtas  <zalan@apple.com>
828
829         [LFC][BFC] Add support for block level replaced box.
830         https://bugs.webkit.org/show_bug.cgi?id=194071
831
832         Reviewed by Antti Koivisto.
833
834         * LayoutReloaded/misc/LFC-passing-tests.txt:
835
836 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
837
838         Fix WebKitTestRunner's testPath with Windows full paths
839         https://bugs.webkit.org/show_bug.cgi?id=194012
840
841         Reviewed by Alex Christensen.
842
843         updateTestOptionsFromTestHeader failed to open test files because
844         testPath returned wrong file paths. It returned a path "/C:/..."
845         if a URL "file:///C:/..." was given.
846
847         * WebKitTestRunner/TestController.cpp:
848         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
849
850 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
851
852         [WPE] Bump font related dependencies to match the GTK+ port
853         https://bugs.webkit.org/show_bug.cgi?id=194017
854
855         Reviewed by Žan Doberšek.
856
857         * wpe/jhbuild.modules:
858         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
859         * wpe/patches/icudata-stdlibs.patch: Added.
860
861 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
862
863         Enable swipe tests on iOS
864         https://bugs.webkit.org/show_bug.cgi?id=194076
865
866         Reviewed by Geoffrey Garen.
867
868         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
869         it causes a debug assertion failure in runUIScript.
870
871         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
872         (WTR::UIScriptController::beginBackSwipe):
873         (WTR::UIScriptController::completeBackSwipe):
874
875 2019-01-30  Keith Rollin  <krollin@apple.com>
876
877         Use correct printf format specifier
878         https://bugs.webkit.org/show_bug.cgi?id=194062
879         <rdar://problem/47686167>
880
881         Reviewed by Alexey Proskuryakov.
882
883         LayoutTestSpellChecker.mm is trying to format a variable of type
884         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
885         actually an unsigned long long. Fix this by formatting with %llu.
886
887         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
888         (-[LayoutTestTextCheckingResult description]):
889
890 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
891
892         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
893         https://bugs.webkit.org/show_bug.cgi?id=193979
894
895         Reviewed by Wenson Hsieh.
896
897         Fix the test for iOS. Make the test work with iOS UA string.
898
899         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
900
901 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
902
903         Replace High Sierra LLINT CLoop bot due to hardware failure
904         https://bugs.webkit.org/show_bug.cgi?id=194066
905
906         Reviewed by Aakash Jain.
907
908         * BuildSlaveSupport/build.webkit.org-config/config.json:
909
910 2019-01-30  Keith Rollin  <krollin@apple.com>
911
912         [NSDragItem init] is unavailable
913         https://bugs.webkit.org/show_bug.cgi?id=194059
914         <rdar://problem/47685715>
915
916         Reviewed by Wenson Hsieh.
917
918         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
919         DumpRenderTree and TestWebKitAPI, which both try to create an
920         NSDragItem in a manner that invokes this method. Address this by using
921         -initWithPasteboardWriter instead.
922
923         Note that the parameter passed to initWithPasteboardWriter is likely
924         incorrect. In both cases, the object passed does not conform to
925         NSPasteboardWriting. However, with this fix, we're no worse off than
926         before, and can now perform builds with newer compilers and SDKs until
927         a real fix can be crafted. That work is tracked in
928         https://bugs.webkit.org/show_bug.cgi?id=194060
929
930         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
931         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
932         * TestWebKitAPI/mac/TestDraggingInfo.mm:
933         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
934
935 2019-01-30  Daniel Bates  <dabates@apple.com>
936
937         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
938         https://bugs.webkit.org/show_bug.cgi?id=192824
939         <rdar://problem/47100332>
940
941         Reviewed by Wenson Hsieh.
942
943         Fix a bug where the wrong usage code was used for F13 thru F24.
944
945         * WebKitTestRunner/ios/HIDEventGenerator.mm:
946         (keyCodeForDOMFunctionKey):
947
948 2019-01-30  Chris Dumez  <cdumez@apple.com>
949
950         Regression(PSON) Load hang can occur on history navigation
951         https://bugs.webkit.org/show_bug.cgi?id=194030
952         <rdar://problem/47656939>
953
954         Reviewed by Antti Koivisto.
955
956         Add API test coverage.
957
958         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
959
960 2019-01-30  Zalan Bujtas  <zalan@apple.com>
961
962         [LFC] Expand tests coverage.
963
964         Unreviewed test gardening.
965
966         * LayoutReloaded/misc/LFC-passing-tests.txt:
967
968 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
969
970         [Flatpak] Add openjpeg support
971         https://bugs.webkit.org/show_bug.cgi?id=194019
972
973         Reviewed by Michael Catanzaro.
974
975         * flatpak/org.webkit.CommonModules.yaml:
976
977 2019-01-30  Commit Queue  <commit-queue@webkit.org>
978
979         Unreviewed, rolling out r240708.
980         https://bugs.webkit.org/show_bug.cgi?id=194022
981
982         It broke WPE build (Requested by KaL on #webkit).
983
984         Reverted changeset:
985
986         "[WPE] Bump font related dependencies to match the GTK+ port"
987         https://bugs.webkit.org/show_bug.cgi?id=194017
988         https://trac.webkit.org/changeset/240708
989
990 2019-01-30  Zalan Bujtas  <zalan@apple.com>
991
992         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
993         https://bugs.webkit.org/show_bug.cgi?id=194001
994
995         Reviewed by Antti Koivisto.
996
997         * LayoutReloaded/misc/LFC-passing-tests.txt:
998
999 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1000
1001         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1002         https://bugs.webkit.org/show_bug.cgi?id=194020
1003
1004         Reviewed by Antti Koivisto.
1005
1006         * LayoutReloaded/misc/LFC-passing-tests.txt:
1007
1008 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1009
1010         AX: Support color well on iOS
1011         https://bugs.webkit.org/show_bug.cgi?id=194010
1012
1013         Reviewed by Joanmarie Diggs.
1014
1015         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1016         (WTR::AccessibilityUIElement::stringAttributeValue):
1017
1018 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1019
1020         [WPE] Bump font related dependencies to match the GTK+ port
1021         https://bugs.webkit.org/show_bug.cgi?id=194017
1022
1023         Reviewed by Žan Doberšek.
1024
1025         * wpe/jhbuild.modules:
1026         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1027         * wpe/patches/icudata-stdlibs.patch: Added.
1028
1029 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1030
1031         [Mac] Update window scale API usage
1032         https://bugs.webkit.org/show_bug.cgi?id=193991
1033         rdar://problem/47614795
1034
1035         Reviewed by Tim Horton.
1036
1037         * DumpRenderTree/mac/DumpRenderTree.mm:
1038         (changeWindowScaleIfNeeded):
1039         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1040         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1041         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1042
1043 2019-01-29  Chris Dumez  <cdumez@apple.com>
1044
1045         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1046         https://bugs.webkit.org/show_bug.cgi?id=193977
1047         <rdar://problem/47643716>
1048
1049         Reviewed by Geoff Garen.
1050
1051         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1052         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1053         to the previous provisional committing *before* we make the last load. 
1054
1055         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1056
1057 2019-01-29  Youenn Fablet  <youenn@apple.com>
1058
1059         Adopt new SPI to evaluate server certificate trust
1060         https://bugs.webkit.org/show_bug.cgi?id=193355
1061
1062         Reviewed by Alex Christensen.
1063
1064         Add infrastructure to handle HTTPS server trust evaluation testing.
1065
1066         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1067         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1068         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1069         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1070         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1071         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1072         * WebKitTestRunner/TestController.cpp:
1073         (WTR::TestController::resetPreferencesToConsistentValues):
1074         (WTR::TestController::didReceiveAuthenticationChallenge):
1075         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1076         * WebKitTestRunner/TestController.h:
1077         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1078         * WebKitTestRunner/TestInvocation.cpp:
1079         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1080         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1081         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1082
1083 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1084
1085         [ews-build] Add build step to print bot Configuration
1086         https://bugs.webkit.org/show_bug.cgi?id=193887
1087
1088         Reviewed by Lucas Forschler.
1089
1090         * BuildSlaveSupport/ews-build/steps.py:
1091         (PrintConfiguration): Build step to print configuration.
1092         * BuildSlaveSupport/ews-build/factories.py:
1093
1094 2019-01-29  Chris Dumez  <cdumez@apple.com>
1095
1096         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1097         https://bugs.webkit.org/show_bug.cgi?id=193967
1098         <rdar://problem/47635348>
1099
1100         Reviewed by Alex Christensen.
1101
1102         Add API test coverage.
1103
1104         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1105         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1106
1107 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1108
1109         [ews-app] Handle incoming results data
1110         https://bugs.webkit.org/show_bug.cgi?id=193973
1111
1112         Reviewed by Lucas Forschler.
1113
1114         * BuildSlaveSupport/ews-app/ews/views/results.py:
1115
1116 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1117
1118         [ews-app] Make the results url generic
1119         https://bugs.webkit.org/show_bug.cgi?id=193928
1120
1121         Reviewed by Lucas Forschler.
1122
1123         * BuildSlaveSupport/ews-app/ews/urls.py:
1124
1125 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1126
1127         [ews-build] Configure buildbot to send events to ews-app
1128         https://bugs.webkit.org/show_bug.cgi?id=193968
1129
1130         Reviewed by Lucas Forschler.
1131
1132         * BuildSlaveSupport/ews-build/events.py: Added.
1133         * BuildSlaveSupport/ews-build/master.cfg:
1134
1135 2019-01-29  Keith Rollin  <krollin@apple.com>
1136
1137         Add .xcfilelists to Run Script build phases
1138         https://bugs.webkit.org/show_bug.cgi?id=193792
1139         <rdar://problem/47201785>
1140
1141         Reviewed by Alex Christensen.
1142
1143         As part of supporting XCBuild, update the necessary Run Script build
1144         phases in their Xcode projects to refer to their associated
1145         .xcfilelist files.
1146
1147         Note that the addition of these files bumps the Xcode project version
1148         number to something that's Xcode 10 compatible. This change means that
1149         older versions of the Xcode IDE can't read these projects. Nor can it
1150         fully load workspaces that refer to these projects (the updated
1151         projects are shown as non-expandable placeholders). `xcodebuild` can
1152         still build these projects; it's just that the IDE can't open them.
1153
1154         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1155         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1156
1157 2019-01-29  John Wilander  <wilander@apple.com>
1158
1159         Add data abstraction and validation for Ad Click Attribution
1160         https://bugs.webkit.org/show_bug.cgi?id=193916
1161         <rdar://problem/47603481>
1162
1163         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1164
1165         Ad click attribution has two steps. First, the storage of an ad
1166         campaign ID for a click that takes the user to a destination
1167         site. Second, a conversion on the destination site that can be
1168         attributed to the ad click.
1169
1170         This patch adds a class that represents a request for ad click
1171         attribution. Validation makes sure that the bits of entropy
1172         reported through this mechanism is limited.
1173
1174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1175         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1176         (TestWebKitAPI::TEST):
1177
1178 2019-01-29  Chris Dumez  <cdumez@apple.com>
1179
1180         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1181         https://bugs.webkit.org/show_bug.cgi?id=193932
1182         <rdar://problem/47598947>
1183
1184         Reviewed by Brady Eidson.
1185
1186         Add API test coverage.
1187
1188         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1189
1190 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1191
1192         Adding new passing LFC tests.
1193
1194         Unreviewed test gardening.
1195
1196         * LayoutReloaded/misc/LFC-passing-tests.txt:
1197
1198 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1199
1200         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1201         https://bugs.webkit.org/show_bug.cgi?id=193964
1202
1203         Reviewed by Antti Koivisto.
1204
1205         * LayoutReloaded/misc/LFC-passing-tests.txt:
1206
1207 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1208
1209         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1210         https://bugs.webkit.org/show_bug.cgi?id=193954
1211
1212         Reviewed by Antti Koivisto.
1213
1214         * LayoutReloaded/misc/LFC-passing-tests.txt:
1215
1216 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1217
1218         WebDriver: add support for running subtests
1219         https://bugs.webkit.org/show_bug.cgi?id=193904
1220
1221         Reviewed by Michael Catanzaro.
1222
1223         pytest already supports it by passing test.py::subtest, so we can do the same.
1224
1225         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1226         (get_item_name): Made this global.
1227         (CollectRecorder.__init__): Receive the parameter to ignore.
1228         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1229         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1230         (collect): Add parameter to ignore.
1231         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1232         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1233         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1234         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1235         (WebDriverTestRunnerSelenium.run): Ditto.
1236         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1237         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1238         (WebDriverTestRunnerW3C.run): Ditto.
1239
1240 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1241
1242         User agent string override for navigator.userAgent should be site specific quirks
1243         https://bugs.webkit.org/show_bug.cgi?id=193950
1244
1245         Reviewed by Brent Fulgham.
1246
1247         Updated per the _WKWebsitePolicies rename.
1248
1249         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1250         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1251
1252 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1253
1254         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1255         https://bugs.webkit.org/show_bug.cgi?id=193941
1256
1257         Reviewed by Alex Christensen.
1258
1259         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1260         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1261         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1262         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1263         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1264         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1265         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1266         * TestWebKitAPI/Tests/WTF/Time.cpp:
1267         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1268         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1269         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1270         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1271
1272 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1273
1274         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1275
1276         * Scripts/webkitpy/common/config/contributors.json:
1277
1278 2019-01-28  Andy Estes  <aestes@apple.com>
1279
1280         [watchOS] Enable Parental Controls content filtering
1281         https://bugs.webkit.org/show_bug.cgi?id=193939
1282         <rdar://problem/46641912>
1283
1284         Reviewed by Ryosuke Niwa.
1285
1286         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1287
1288 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1289
1290         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1291         <https://webkit.org/b/193884>
1292
1293         Reviewed by Jiewen Tan.
1294
1295         * Scripts/webkitpy/style/checkers/cpp.py:
1296         (check_language): Add LocalAuthentication to
1297         `frameworks_with_soft_links`.
1298
1299 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1300
1301         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1302         https://bugs.webkit.org/show_bug.cgi?id=193891
1303
1304         Reviewed by Ross Kirsling.
1305
1306         There were three problems in window sizes of WebView and the host window.
1307         1. The sizes of pixel image output were incorrect.
1308         2. The host window is going to appear after window.resize was invoked.
1309         3. window.resize resized only the host window, not WebView.
1310
1311         This change solves them with a following approach.
1312         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1313         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1314            as well as DumpRenderTree in order to match the client area and the window area.
1315         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1316         d. PlatformWebView::setWindowFrame changes both window sizes.
1317         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1318
1319         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1320         (WTR::PlatformWebView::PlatformWebView): Create the host window
1321         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1322         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1323         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1324
1325 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1326
1327         [ews-app] Add method to save Step data to database
1328         https://bugs.webkit.org/show_bug.cgi?id=193890
1329
1330         Reviewed by Lucas Forschler.
1331
1332         * BuildSlaveSupport/ews-app/ews/models/step.py:
1333         (Step.save_step): Method to save step data.
1334         (Step.update_step): Method to update step data.
1335         (Step.get_existing_step): Method to fetch existing step from database.
1336         (Step.is_valid_result): Method to validate valid step result.
1337
1338 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1339
1340         [ews-app] Add method to save Build data to database
1341         https://bugs.webkit.org/show_bug.cgi?id=193735
1342
1343         Reviewed by Lucas Forschler.
1344
1345         * BuildSlaveSupport/ews-app/ews/models/build.py:
1346         (Build.save_build): Method to save build information to database.
1347         (Build.get_existing_build): Method to fetch existing build from database.
1348         (Build.is_valid_result): Method to validate build result.
1349         * BuildSlaveSupport/ews-app/ews/common/util.py:
1350         (is_valid_int_id): Method to validate valid id.
1351
1352 2019-01-28  Chris Dumez  <cdumez@apple.com>
1353
1354         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1355         https://bugs.webkit.org/show_bug.cgi?id=193915
1356         <rdar://problem/47560907>
1357
1358         Reviewed by Alex Christensen.
1359
1360         Add API test coverage.
1361
1362         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1363
1364 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1365
1366         [ews-app] Rename id variables
1367         https://bugs.webkit.org/show_bug.cgi?id=193883
1368
1369         Reviewed by Lucas Forschler.
1370
1371         * BuildSlaveSupport/ews-app/ews/models/build.py:
1372         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1373         * BuildSlaveSupport/ews-app/ews/models/step.py:
1374         * BuildSlaveSupport/ews-app/ews/urls.py:
1375         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1376         * BuildSlaveSupport/ews-app/ews/views/results.py:
1377         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1378
1379 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1380
1381         [ews-app] Allow certain fields to be empty
1382         https://bugs.webkit.org/show_bug.cgi?id=193892
1383
1384         Reviewed by Lucas Forschler.
1385
1386         * BuildSlaveSupport/ews-app/ews/models/build.py:
1387         * BuildSlaveSupport/ews-app/ews/models/step.py:
1388
1389 2019-01-28  Rob Buis  <rbuis@igalia.com>
1390
1391         Update MIME type parser
1392         https://bugs.webkit.org/show_bug.cgi?id=180526
1393
1394         Reviewed by Frédéric Wang.
1395
1396         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1397         (TestWebKitAPI::TEST):
1398
1399 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1400
1401         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1402         https://bugs.webkit.org/show_bug.cgi?id=193896
1403
1404         Reviewed by Antti Koivisto.
1405
1406         * LayoutReloaded/misc/LFC-passing-tests.txt:
1407
1408 2018-12-15  Darin Adler  <darin@apple.com>
1409
1410         Replace many uses of String::format with more type-safe alternatives
1411         https://bugs.webkit.org/show_bug.cgi?id=192742
1412
1413         Reviewed by Mark Lam.
1414
1415         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1416         (WTR::cacheTestRunnerCallback): Use makeString.
1417         * WebKitTestRunner/TestController.cpp:
1418         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1419         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1420
1421 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1422
1423         Use a load optimizer for some sites
1424         https://bugs.webkit.org/show_bug.cgi?id=193881
1425         <rdar://problem/46325455>
1426
1427         Reviewed by Brent Fulgham.
1428
1429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1430         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1431
1432 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1433
1434         AX: Introduce a static accessibility tree
1435         https://bugs.webkit.org/show_bug.cgi?id=193348
1436         <rdar://problem/47203295>
1437
1438         Reviewed by Ryosuke Niwa.
1439
1440         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1441
1442 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1443
1444         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1445         https://bugs.webkit.org/show_bug.cgi?id=193867
1446
1447         Reviewed by Antti Koivisto.
1448
1449         * LayoutReloaded/misc/LFC-passing-tests.txt:
1450
1451 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1452
1453         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1454         https://bugs.webkit.org/show_bug.cgi?id=193865
1455
1456         Reviewed by Antti Koivisto.
1457
1458         * LayoutReloaded/misc/LFC-passing-tests.txt:
1459
1460 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1461
1462         Need a mechanism to override navigator.userAgent
1463         https://bugs.webkit.org/show_bug.cgi?id=193762
1464         <rdar://problem/47504939>
1465
1466         Reviewed by Brent Fulgham.
1467
1468         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1469
1470         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1471         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1472         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1473
1474 2019-01-25  Dean Jackson  <dino@apple.com>
1475
1476         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1477         https://bugs.webkit.org/show_bug.cgi?id=193831
1478         <rdar://problem/47399263>
1479
1480         Reviewed by Chris Dumez.
1481
1482         Two new tests that exercise cross-origin and same-origin System
1483         Previews.
1484
1485         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1486
1487 2019-01-25  Keith Rollin  <krollin@apple.com>
1488
1489         Update Xcode projects with "Check .xcfilelists" build phase
1490         https://bugs.webkit.org/show_bug.cgi?id=193790
1491         <rdar://problem/47201374>
1492
1493         Reviewed by Alex Christensen.
1494
1495         Support for XCBuild includes specifying inputs and outputs to various
1496         Run Script build phases. These inputs and outputs are specified as
1497         .xcfilelist files. Once created, these .xcfilelist files need to be
1498         kept up-to-date. In order to check that they are up-to-date or not,
1499         add an Xcode build step that invokes an external script that performs
1500         the checking. If the .xcfilelists are found to be out-of-date, update
1501         them, halt the build, and instruct the developer to restart the build
1502         with up-to-date files.
1503
1504         At this time, the checking and regenerating is performed only if the
1505         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1506         who want to use this facility can set this variable and test out the
1507         checking/regenerating. Once it seems like there are no egregious
1508         issues that upset a developer's workflow, we'll unconditionally enable
1509         this facility.
1510
1511         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1512         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1513         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1514         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1515
1516 2019-01-25  Keith Rollin  <krollin@apple.com>
1517
1518         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1519         https://bugs.webkit.org/show_bug.cgi?id=193781
1520         <rdar://problem/47201153>
1521
1522         Reviewed by Alex Christensen.
1523
1524         Part of generating the .xcfilelists used as part of adopting XCBuild
1525         includes running `make DerivedSources.make` from a standalone script.
1526         It’s important for this invocation to have the same environment as
1527         when the actual build invokes `make DerivedSources.make`. If the
1528         environments are different, then the two invocations will provide
1529         different results. In order to get the same environment in the
1530         standalone script, have the script launch xcodebuild targeting the
1531         "Apply Configuration to XCFileLists" build target, which will then
1532         re-invoke our standalone script. The script is now running again, this
1533         time in an environment with all workspace, project, target, xcconfig
1534         and other environment variables established.
1535
1536         The "Apply Configuration to XCFileLists" build target accomplishes
1537         this task via a small embedded shell script that consists only of:
1538
1539             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1540
1541         The process that invokes "Apply Configuration to XCFileLists" first
1542         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1543         evaluated and exports it into the shell environment. When xcodebuild
1544         is invoked, it inherits the value of this variable and can `eval` the
1545         contents of that variable. Our external standalone script can then set
1546         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1547         of command-line parameters needed to restart itself in the appropriate
1548         state.
1549
1550         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1551         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1552
1553 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1554
1555         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1556         https://bugs.webkit.org/show_bug.cgi?id=193802
1557         <rdar://problem/46010580>
1558
1559         Reviewed by Andy Estes.
1560
1561         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1562         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1563         (TEST):
1564
1565 2019-01-25  Daniel Bates  <dabates@apple.com>
1566
1567         [iOS] uiController.keyDown() does not translate Control modified key
1568         https://bugs.webkit.org/show_bug.cgi?id=192898
1569
1570         Reviewed by Wenson Hsieh.
1571
1572         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1573         key translation, as applicable. Among other cases, key translation occurs when performing
1574         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1575         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1576         human pressing down and releasing key(s) using a hardware keyboard.
1577
1578         * WebKitTestRunner/ios/HIDEventGenerator.h:
1579         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1580         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1581
1582         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1583         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1584         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1585         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1586         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1587         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1588         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1589         (-[HIDEventGenerator longPress:completionBlock:]):
1590         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1591         Update code for above renaming.
1592
1593         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1594         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1595
1596         (-[HIDEventGenerator keyDown:]): Added.
1597         (-[HIDEventGenerator keyUp:]): Added.
1598         (-[HIDEventGenerator keyPress:completionBlock:]):
1599         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1600         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1601         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1602         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1603         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1604         (WTR::parseModifier): Deleted.
1605
1606 2019-01-25  Keith Rollin  <krollin@apple.com>
1607
1608         Complete the implementation of generate-xcfilelists
1609         https://bugs.webkit.org/show_bug.cgi?id=193782
1610
1611         Reviewed by Alex Christensen.
1612
1613         A preliminary version of generate-xcfilelists was added in r238008.
1614         This patch updates that script in order to:
1615
1616         - Support checking of .xcfilelists
1617         - Perform better execution of `make DerivedSources.make` by
1618           relaunching generate-xcfilelists under xcodebuild
1619         - Support incremental generation and checking of .xcfilelists
1620         - Support supplementary .xcfilelists files from WebKitAdditions
1621         - Support being wrapped by parallel version of generate-xcfilelists in
1622           Internal that adds support for (re)generating WebKit projects in
1623           that repo.
1624         - Support builds that have been performed in WebKitBuild as well as
1625           ~/Library/Developer/code/DerivedData
1626         - Increase robustness and debugging facilities.
1627
1628         * Scripts/generate-xcfilelists:
1629
1630 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1631
1632         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1633         https://bugs.webkit.org/show_bug.cgi?id=193297
1634         <rdar://problem/47158841>
1635
1636         Unreviewed test case fix.
1637
1638         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1639         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1640
1641         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1642         (TEST):
1643
1644 2019-01-25  Keith Rollin  <krollin@apple.com>
1645
1646         Update existing .xcfilelists
1647         https://bugs.webkit.org/show_bug.cgi?id=193791
1648         <rdar://problem/47201706>
1649
1650         Reviewed by Alex Christensen.
1651
1652         Many .xcfilelist files were added in r238824 in order to support
1653         XCBuild. Update these with recent changes to the set of build files
1654         and with the current generate-xcfilelist script.
1655
1656         * DumpRenderTree/DerivedSources-input.xcfilelist:
1657         * DumpRenderTree/DerivedSources-output.xcfilelist:
1658         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1659         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1660
1661 2019-01-25  Keith Rollin  <krollin@apple.com>
1662
1663         Fix missing dependencies in extract-dependencies-from-makefile
1664         https://bugs.webkit.org/show_bug.cgi?id=193783
1665         <rdar://problem/47201571>
1666
1667         Reviewed by Alex Christensen.
1668
1669         The extract-dependencies-from-makefile script generates .xcfilelists
1670         for XCBuild by invoking a makefile in --debug mode, parsing the
1671         dependency information in the output, and extracting information
1672         regarding targets and dependents. However, the way `make` emits this
1673         dependency information is not rigorous, and so we need to determine
1674         what lines to look for and parse by trial and error. This approach
1675         didn't coriginally atch all the information we needed to collect, so
1676         update the script to look for the additional lines we now know to look
1677         for.
1678
1679         * Scripts/extract-dependencies-from-makefile:
1680         (Parser):
1681         (Parser.addTarget):
1682         (Parser.addPrereq):
1683         (Parser.doParse):
1684
1685 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1686
1687         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1688         https://bugs.webkit.org/show_bug.cgi?id=193297
1689         <rdar://problem/47158841>
1690
1691         Reviewed by Alex Christensen.
1692
1693         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1694             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1695         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1696         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1697         activating the message used to trigger the callback when it is set.
1698
1699 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1700
1701         WKWebView.goBack should reload if there is a safe browsing warning
1702         https://bugs.webkit.org/show_bug.cgi?id=193805
1703         <rdar://problem/46908216>
1704
1705         Reviewed by Geoff Garen.
1706
1707         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1708         (+[Simple3LookupContext sharedLookupContext]):
1709         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1710         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1711         (TEST):
1712
1713 2019-01-25  Chris Dumez  <cdumez@apple.com>
1714
1715         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1716         https://bugs.webkit.org/show_bug.cgi?id=193788
1717         <rdar://problem/47531231>
1718
1719         Reviewed by Alex Christensen.
1720
1721         Add API test coverage.
1722
1723         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1724         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1725
1726 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1727
1728         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1729         https://bugs.webkit.org/show_bug.cgi?id=193771
1730
1731         Unreviewed infrastructure fix.
1732
1733         * Scripts/webkitpy/port/darwin.py:
1734         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1735
1736 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1737
1738         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1739
1740 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1741
1742         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1743
1744         * Scripts/webkitpy/common/config/contributors.json:
1745
1746 2019-01-25  Chris Dumez  <cdumez@apple.com>
1747
1748         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1749         https://bugs.webkit.org/show_bug.cgi?id=193779
1750         <rdar://problem/46170903>
1751
1752         Reviewed by Antti Koivisto.
1753
1754         Add API test that quickly navigates forward to a previous process without waiting for it to
1755         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1756         the process' previous page when reconnecting the it for the forward navigation.
1757
1758         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1759
1760 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1761
1762         Need a way for JavaScript (or bundle) code to participate in undo
1763         https://bugs.webkit.org/show_bug.cgi?id=190009
1764         <rdar://problem/44807048>
1765
1766         Reviewed by Ryosuke Niwa.
1767
1768         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1769         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1770
1771         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1772         (WTR::UIScriptController::lastUndoLabel const):
1773         (WTR::UIScriptController::firstRedoLabel const):
1774         (WTR::UIScriptController::platformUndoManager const):
1775         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1776         (WTR::UIScriptController::lastUndoLabel const):
1777         (WTR::UIScriptController::firstRedoLabel const):
1778         (WTR::UIScriptController::platformUndoManager const):
1779         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1780         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1781         (WTR::UIScriptController::lastUndoLabel const):
1782         (WTR::UIScriptController::firstRedoLabel const):
1783         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1784         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1785         (WTR::UIScriptController::lastUndoLabel const):
1786         (WTR::UIScriptController::firstRedoLabel const):
1787         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1788         (WTR::UIScriptController::platformUndoManager const):
1789         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1790         (WTR::UIScriptController::platformUndoManager const):
1791
1792 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1793
1794         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1795         https://bugs.webkit.org/show_bug.cgi?id=193824
1796
1797         Reviewed by Antti Koivisto.
1798
1799         * LayoutReloaded/misc/LFC-passing-tests.txt:
1800
1801 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1802
1803         Update macOS JSC bot configurations
1804         https://bugs.webkit.org/show_bug.cgi?id=193739
1805
1806         Reviewed by Alexey Proskuryakov.
1807
1808         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1810         (BubbleQueueServer): Move JSC EWS to Mojave section.
1811         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1812         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1813         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1814
1815 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1816
1817         [Win][WebKitTestRunner] Implement EventSenderProxy
1818         https://bugs.webkit.org/show_bug.cgi?id=193755
1819
1820         Reviewed by Don Olmstead.
1821
1822         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1823         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1824         (WTR::EventSenderProxy::dispatchMessage):
1825         (WTR::EventSenderProxy::EventSenderProxy):
1826         (WTR::EventSenderProxy::mouseDown):
1827         (WTR::EventSenderProxy::mouseUp):
1828         (WTR::EventSenderProxy::mouseMoveTo):
1829         (WTR::EventSenderProxy::mouseScrollBy):
1830         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1831
1832 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1833
1834         Unreviewed fix for API test failure after r240437.
1835
1836         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1837
1838         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1839
1840 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1841
1842         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1843         https://bugs.webkit.org/show_bug.cgi?id=193787
1844         <rdar://problem/47497634>
1845
1846         Reviewed by Alexey Proskuryakov.
1847
1848         * Scripts/webkitdirs.pm:
1849         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1850
1851 2019-01-24  Truitt Savell  <tsavell@apple.com>
1852
1853         Unreviewed, rolling out r240446.
1854
1855         Casued 5 API failures
1856
1857         Reverted changeset:
1858
1859         "Activate the WebResourceLoadStatisticsStore in the
1860         NetworkProcess and deactivate it in the UIProcess."
1861         https://bugs.webkit.org/show_bug.cgi?id=193297
1862         https://trac.webkit.org/changeset/240446
1863
1864 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1865
1866         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1867         https://bugs.webkit.org/show_bug.cgi?id=193741
1868         <rdar://problem/47135030>
1869
1870         Reviewed by Antti Koivisto and Simon Fraser.
1871
1872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1873         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1874         (TestWebKitAPI::TEST):
1875
1876 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1877
1878         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1879         https://bugs.webkit.org/show_bug.cgi?id=193297
1880         <rdar://problem/47158841>
1881
1882         Reviewed by Alex Christensen.
1883
1884         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1885         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1886         activating the message used to trigger the callback when it is set.
1887
1888 2019-01-24  John Wilander  <wilander@apple.com>
1889
1890         Add Ad Click Attribution as an internal/experimental feature
1891         https://bugs.webkit.org/show_bug.cgi?id=193685
1892         <rdar://problem/47450399>
1893
1894         Reviewed by Brent Fulgham.
1895
1896         Added test option adClickAttributionEnabled.
1897
1898         * DumpRenderTree/TestOptions.cpp:
1899         (TestOptions::TestOptions):
1900         * DumpRenderTree/TestOptions.h:
1901         * DumpRenderTree/mac/DumpRenderTree.mm:
1902         (setWebPreferencesForTestOptions):
1903
1904 2019-01-24  Antti Koivisto  <antti@apple.com>
1905
1906         [PSON] Flash on back navigation on Mac
1907         https://bugs.webkit.org/show_bug.cgi?id=193716
1908         <rdar://problem/47148458>
1909
1910         Reviewed by Chris Dumez.
1911
1912         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1913
1914         Closing of the previous page is delayed so waiting for didFinishNavigation is
1915         not sufficient to guarantee we have received all the messages. Wait for them.
1916
1917 2019-01-24  Chris Dumez  <cdumez@apple.com>
1918
1919         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1920         https://bugs.webkit.org/show_bug.cgi?id=193761
1921         <rdar://problem/47456405>
1922
1923         Reviewed by Alex Christensen.
1924
1925         Add API test coverage.
1926
1927         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1928
1929 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1930
1931         webkitpy: Missing PID in crashlog name should not be fatal
1932         https://bugs.webkit.org/show_bug.cgi?id=193771
1933
1934         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1935         of raising an exception.
1936
1937         Reviewed by Lucas Forschler.
1938
1939         * Scripts/webkitpy/port/darwin.py:
1940         (DarwinPort._merge_crash_logs):
1941
1942 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1943
1944         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1945         https://bugs.webkit.org/show_bug.cgi?id=193746
1946
1947         Reviewed by Youenn Fablet.
1948
1949         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1950         so we'd best just not call it.
1951
1952         * Scripts/webkitpy/w3c/test_exporter.py:
1953         (WebPlatformTestExporter.create_branch_with_patch):
1954
1955 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1956
1957         Move FileSystem to WTF
1958         https://bugs.webkit.org/show_bug.cgi?id=193602
1959
1960         Reviewed by Yusuke Suzuki.
1961
1962         * DumpRenderTree/win/DumpRenderTree.cpp:
1963         * TestWebKitAPI/CMakeLists.txt:
1964         * TestWebKitAPI/PlatformGTK.cmake:
1965         * TestWebKitAPI/PlatformJSCOnly.cmake:
1966         * TestWebKitAPI/PlatformPlayStation.cmake:
1967         * TestWebKitAPI/PlatformWPE.cmake:
1968         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1969         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1970         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1971         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1972         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1973         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1974         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1975         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1976         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1977         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1978
1979 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1980
1981         [WPE] Remove hard dependency on subprocess32 for the API tests
1982
1983         Rubber-stamped by Carlos Garcia Campos.
1984
1985         * glib/api_test_runner.py:
1986         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1987         its presence only when running WPEQt tests.
1988
1989 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1990
1991         [GLIB] Expose JavaScriptCore options in GLib public API
1992         https://bugs.webkit.org/show_bug.cgi?id=188742
1993
1994         Reviewed by Michael Catanzaro.
1995
1996         Add a test for the new API.
1997
1998         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1999         (testsJSCOptions):
2000         (main):
2001
2002 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2003
2004         [GTK][WPE] Support JPEG 2000 images
2005         https://bugs.webkit.org/show_bug.cgi?id=186272
2006
2007         Reviewed by Žan Doberšek.
2008
2009         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2010
2011         * gtk/jhbuild.modules:
2012         * wpe/jhbuild.modules:
2013
2014 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2015
2016         check-webkit-style should warn when using soft-linking macros in a header
2017         <https://webkit.org/b/193750>
2018
2019         Reviewed by Darin Adler.
2020
2021         * Scripts/webkitpy/style/checkers/cpp.py:
2022         (check_language): Add softlink/header check by refactoring the
2023         softlink/framework check.
2024         (CppChecker): Enable softlink/header check by default.
2025         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2026         (CppStyleTest.test_softlink_framework): Rename from
2027         CppStyleTest.test_softlink() and change test framework name in
2028         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2029         files. Set file_name for macros that only appear in headers.
2030         (CppStyleTest.test_softlink_header): Add tests for using
2031         soft-link macros in headers.
2032
2033 2019-01-23  Chris Dumez  <cdumez@apple.com>
2034
2035         Deprecate API to limit the maximum number of WebProcesses
2036         https://bugs.webkit.org/show_bug.cgi?id=193725
2037         <rdar://problem/47464879>
2038
2039         Reviewed by Geoff Garen.
2040
2041         Update existing API tests to stop using deprecated API.
2042
2043         * MiniBrowser/mac/AppDelegate.m:
2044         (defaultConfiguration):
2045         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2046         (TestWebKitAPI::TEST):
2047         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2048         (TestWebKitAPI::TEST):
2049         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2050         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2051         (TEST):
2052         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2053         (TEST):
2054
2055 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2056
2057         [ews-app] Rename ews model buildermappings to buildermapping
2058         https://bugs.webkit.org/show_bug.cgi?id=193729
2059
2060         Reviewed by Lucas Forschler.
2061
2062         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2063         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2064         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2065
2066 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2067
2068         [ews-app] Rename ews model steps to step
2069         https://bugs.webkit.org/show_bug.cgi?id=193697
2070
2071         Reviewed by Lucas Forschler.
2072
2073         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2074         (Step): Renamed Steps to Step.
2075
2076 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2077
2078         Clean up IndexedDB files between tests
2079         https://bugs.webkit.org/show_bug.cgi?id=192796
2080         <rdar://problem/46824999>
2081
2082         Reviewed by Geoffrey Garen.
2083
2084         * DumpRenderTree/mac/DumpRenderTree.mm:
2085         (runTest):
2086         * WebKitTestRunner/TestController.cpp:
2087         (WTR::TestController::resetStateToConsistentValues):
2088         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2089         (WTR::RemoveAllIndexedDatabasesCallback):
2090         (WTR::TestController::ClearIndexedDatabases):
2091         * WebKitTestRunner/TestController.h:
2092         * WebKitTestRunner/TestInvocation.cpp:
2093         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2094
2095 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2096
2097         [ews-app] Rename ews model Builds to Build
2098         https://bugs.webkit.org/show_bug.cgi?id=193695
2099
2100         Reviewed by Lucas Forschler.
2101
2102         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2103         (Build): Renamed Builds to Build.
2104
2105 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2106
2107         webkitpy: Wait longer when launching WebKitTestRunner
2108         https://bugs.webkit.org/show_bug.cgi?id=193734
2109
2110         Reviewed by Aakash Jain.
2111
2112         * Scripts/webkitpy/port/simulator_process.py:
2113         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2114
2115 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2116
2117         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2118         https://bugs.webkit.org/show_bug.cgi?id=193182
2119         <rdar://problem/47452154>
2120
2121         Reviewed by Tim Horton.
2122
2123         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2124         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2125         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2126
2127         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2128         preventing later tests from recognizing gestures.
2129
2130         * WebKitTestRunner/ios/TestControllerIOS.mm:
2131         (WTR::TestController::platformResetStateToConsistentValues):
2132
2133         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2134
2135 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2136
2137         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2138         https://bugs.webkit.org/show_bug.cgi?id=193722
2139         <rdar://problem/47481475>
2140
2141         Reviewed by Lucas Forschler.
2142
2143         iPhone and iPad ports should both use the iOS config.
2144
2145         * Scripts/webkitpy/port/ios_simulator.py:
2146         (IPhoneSimulatorPort.__init__):
2147         (IPadSimulatorPort.__init__):
2148
2149 2019-01-23  Rob Buis  <rbuis@igalia.com>
2150
2151         Update MIME type parser
2152         https://bugs.webkit.org/show_bug.cgi?id=180526
2153
2154         Reviewed by Frédéric Wang.
2155
2156         Add unit tests for both parse modes of ParsedContentType.
2157
2158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2159         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2160         (TestWebKitAPI::TEST):
2161
2162 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2163
2164         [ews-app] fetch loop should not stop on network issues
2165         https://bugs.webkit.org/show_bug.cgi?id=193666
2166
2167         Reviewed by Lucas Forschler.
2168
2169         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2170         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2171
2172 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2173
2174         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2175         https://bugs.webkit.org/show_bug.cgi?id=189165
2176         <rdar://problem/47433765>
2177
2178         Reviewed by Tim Horton.
2179
2180         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2181         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2182         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2183         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2184         would make its way to the UI process by the time the layer tree commit is finished.
2185
2186         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2187         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2188         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2189         will fail because it asks for -_autofillContext too early.
2190
2191         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2192         is handled in the UI process.
2193
2194         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2195
2196         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2197         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2198         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2199         input session.
2200
2201         (-[AutofillTestView textInputHasAutofillContext]):
2202
2203         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2204
2205         * TestWebKitAPI/cocoa/TestWKWebView.h:
2206         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2207         (nextInputSessionChangeCount):
2208
2209         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2210         This includes changing the focused element from one to another.
2211
2212         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2213         (-[TestWKWebView didStartFormControlInteraction]):
2214         (-[TestWKWebView didEndFormControlInteraction]):
2215         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2216
2217         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2218         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2219         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2220         that doesn't require an input session to one that doesn't.
2221
2222 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2223
2224         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2225         <https://webkit.org/b/193676>
2226
2227         Reviewed by Alexey Proskuryakov.
2228
2229         * Scripts/webkitpy/style/checkers/cpp.py:
2230         (check_member_initialization_list):
2231         - Don't report missing whitespace around colon if the colon at
2232           the start of the line is formatted correctly.
2233         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2234         (WebKitStyleTest.test_member_initialization_list):
2235         - Add a test for a missing permutation of existing tests.
2236         - Add a test this false-positive.
2237         - Add blank lines between subtests to make them easier to read.
2238
2239 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2240
2241         [build.webkit.org] Unit-test failure after r237113
2242         https://bugs.webkit.org/show_bug.cgi?id=193669
2243
2244         Reviewed by Michael Catanzaro.
2245
2246         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2247         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2248         multiple or zero flags.
2249
2250 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2251
2252         Cache bytecode to disk
2253         https://bugs.webkit.org/show_bug.cgi?id=192782
2254         <rdar://problem/46084932>
2255
2256         Reviewed by Keith Miller.
2257
2258         Add test helper to execute bytecode-cache tests: it executes each test
2259         twice, the first with JSC_diskCachePath set to a temporary directory
2260         and second with JSC_forceDiskCache=true (in addition to the cache path)
2261         to guarantee that only the disk cache is being used and no new
2262         UnlinkedCodeBlocks are being created.
2263
2264         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2265         * Scripts/run-jsc-stress-tests:
2266
2267 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2268
2269         [css-logical] Implement flow-relative margin, padding and border shorthands
2270         https://bugs.webkit.org/show_bug.cgi?id=188697
2271
2272         Reviewed by Simon Fraser and Antti Koivisto.
2273
2274         * DumpRenderTree/TestOptions.cpp:
2275         (TestOptions::TestOptions):
2276         * DumpRenderTree/TestOptions.h:
2277         * DumpRenderTree/mac/DumpRenderTree.mm:
2278         (setWebPreferencesForTestOptions):
2279         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2280
2281         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2282         (JSONCSSPropertiesChecker.check_codegen_properties):
2283         Allow CSS property definitions to have a 'runtime-flag' parameter which
2284         disables the property when the specified runtime flag is disabled.
2285
2286 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2287
2288         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2289         https://bugs.webkit.org/show_bug.cgi?id=193643
2290
2291         Reviewed by Michael Catanzaro.
2292
2293         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2294         * wpe/jhbuild.modules: Ditto.
2295
2296 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2297
2298         [LFC][Floats] Take float top position into account when computing containing block height.
2299         https://bugs.webkit.org/show_bug.cgi?id=193655
2300
2301         Reviewed by Antti Koivisto.
2302
2303         * LayoutReloaded/misc/LFC-passing-tests.txt:
2304
2305 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2306
2307         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2308         <https://webkit.org/b/193645>
2309         <rdar://problem/47421574>
2310
2311         Reviewed by Alex Christensen.
2312
2313         - Now checks for local soft-linking of all frameworks that have
2314           their own *SoftLinking.{cpp,h,mm} files.
2315         - Changes softlink/uikit warning to softlink/framework.
2316
2317         * Scripts/webkitpy/style/checkers/cpp.py:
2318         (check_language):
2319         (CppChecker):
2320         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2321         (CppStyleTest):
2322
2323 2019-01-20  Saam Barati  <sbarati@apple.com>
2324
2325         Rollout r240210: It broke tests on iOS
2326         https://bugs.webkit.org/show_bug.cgi?id=193640
2327
2328         Unreviewed.
2329
2330         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2331         * Scripts/run-jsc-stress-tests:
2332
2333 2019-01-20  chris fleizach  <cfleizach@apple.com>
2334
2335         AX: Support returning relative frames for accessibility
2336         https://bugs.webkit.org/show_bug.cgi?id=193414
2337         <rdar://problem/47268501>
2338
2339         Reviewed by Zalan Bujtas.
2340
2341         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2342         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2343         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2344         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2345         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2346         (WTR::attributesOfElement):
2347         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2348
2349 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2350
2351         Unreviewed, add my new email address
2352
2353         * Scripts/webkitpy/common/config/contributors.json:
2354
2355 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2356
2357         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2358         https://bugs.webkit.org/show_bug.cgi?id=193617
2359
2360         Reviewed by Antti Koivisto.
2361
2362         * LayoutReloaded/misc/LFC-passing-tests.txt:
2363
2364 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2365
2366         Unreviewed, rolling out r240209.
2367
2368         Broke GTK/WPE injected bundle
2369
2370         Reverted changeset:
2371
2372         "AX: Support returning relative frames for accessibility"
2373         https://bugs.webkit.org/show_bug.cgi?id=193414
2374         https://trac.webkit.org/changeset/240209
2375
2376 2019-01-12  Dan Bernstein  <mitz@apple.com>
2377
2378         [Cocoa] Avoid importing directly from subumbrella frameworks
2379         https://bugs.webkit.org/show_bug.cgi?id=186016
2380         <rdar://problem/40591038>
2381
2382         Reviewed by Sam Weinig.
2383
2384         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2385           LaunchServices header.
2386         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2387           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2388         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2389           when using SDKs earlier than 10.13.
2390         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2391           and OTHER_CPLUSPLUSFLAGS.
2392         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2393           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2394         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2395           LaunchServices header.
2396
2397 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2398
2399         Cache bytecode to disk
2400         https://bugs.webkit.org/show_bug.cgi?id=192782
2401         <rdar://problem/46084932>
2402
2403         Reviewed by Keith Miller.
2404
2405         Add test helper to execute bytecode-cache tests: it executes each test
2406         twice, the first with JSC_diskCachePath set to a temporary directory
2407         and second with JSC_forceDiskCache=true (in addition to the cache path)
2408         to guarantee that only the disk cache is being used and no new
2409         UnlinkedCodeBlocks are being created.
2410
2411         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2412         * Scripts/run-jsc-stress-tests:
2413
2414 2019-01-20  chris fleizach  <cfleizach@apple.com>
2415
2416         AX: Support returning relative frames for accessibility
2417         https://bugs.webkit.org/show_bug.cgi?id=193414
2418         <rdar://problem/47268501>
2419
2420         Reviewed by Zalan Bujtas.
2421
2422         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2423         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2424         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2425         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2426         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2427         (WTR::attributesOfElement):
2428         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2429
2430 2019-01-20  Antoine Quint  <graouts@apple.com>
2431
2432         Add a POINTER_EVENTS feature flag
2433         https://bugs.webkit.org/show_bug.cgi?id=193577
2434         <rdar://problem/47408511>
2435
2436         Unreviewed. Also enable Pointer Events for iosmac.
2437
2438         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2439
2440 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2441
2442         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2443         https://bugs.webkit.org/show_bug.cgi?id=193613
2444
2445         Reviewed by Antti Koivisto.
2446
2447         * LayoutReloaded/misc/LFC-passing-tests.txt:
2448
2449 2019-01-19  Antoine Quint  <graouts@apple.com>
2450
2451         Add a POINTER_EVENTS feature flag
2452         https://bugs.webkit.org/show_bug.cgi?id=193577
2453
2454         Reviewed by Dean Jackson.
2455
2456         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2457
2458 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2459
2460         Disable the run-jsc-stress-test remote host key check [second round].
2461         https://bugs.webkit.org/show_bug.cgi?id=192988
2462
2463         Reviewed by Dewei Zhu.
2464
2465         * Scripts/run-jsc-stress-tests:
2466
2467 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2468
2469         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2470         https://bugs.webkit.org/show_bug.cgi?id=193597
2471
2472         Reviewed by Lucas Forschler.
2473
2474         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2475
2476 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2477
2478         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2479         https://bugs.webkit.org/show_bug.cgi?id=193595
2480
2481         Reviewed by Lucas Forschler.
2482
2483         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2484         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2485         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2486
2487 2019-01-18  Chris Dumez  <cdumez@apple.com>
2488
2489         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2490         https://bugs.webkit.org/show_bug.cgi?id=193588
2491         <rdar://problem/47131566>
2492
2493         Reviewed by Alex Christensen.
2494
2495         Add layout test coverage.
2496
2497         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2498
2499 2019-01-18  Jer Noble  <jer.noble@apple.com>
2500
2501         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2502         https://bugs.webkit.org/show_bug.cgi?id=189553
2503
2504         Reviewed by Tim Horton.
2505
2506         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2507
2508         * ContentExtensionTester/Configurations/Base.xcconfig:
2509         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2510         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2511         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2512         * ImageDiff/cg/Configurations/Base.xcconfig:
2513         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2514         * MiniBrowser/Configurations/Base.xcconfig:
2515         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2516         * MobileMiniBrowser/Configurations/Base.xcconfig:
2517         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2518         * Scripts/webkitpy/style/checker.py:
2519         (_all_categories):
2520         (FileType):
2521         (CheckerDispatcher._file_type):
2522         (CheckerDispatcher._create_checker):
2523         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2524         (SDKVariantChecker):
2525         (SDKVariantChecker.__init__):
2526         (SDKVariantChecker.check):
2527         * TestWebKitAPI/Configurations/Base.xcconfig:
2528         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2529         * WebEditingTester/Configurations/Base.xcconfig:
2530         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2531         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2532         * WebKitTestRunner/Configurations/Base.xcconfig:
2533         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2534         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2535         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2536
2537 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2538
2539         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2540         <https://webkit.org/b/193568>
2541         <rdar://problem/47381130>
2542
2543         Reviewed by Alex Christensen.
2544
2545         Make sure no one re-introduces UIKit soft-linking by adding a
2546         style rule.
2547
2548         * Scripts/webkitpy/style/checkers/cpp.py:
2549         (check_language): Add softlink/uikit check.
2550         (CppChecker): Enable softlink/uikit check.
2551         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2552         (CppStyleTest): Add test for softlink/uikit.
2553
2554 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2555
2556         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2557         https://bugs.webkit.org/show_bug.cgi?id=193584
2558
2559         Change "-dev" to "-devel".
2560
2561         Reviewed by Michael Catanzaro.
2562
2563         * gtk/install-dependencies:
2564
2565 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2566
2567         webkitpy: Add iPhone and iPad ports
2568         https://bugs.webkit.org/show_bug.cgi?id=193537
2569         <rdar://problem/47353390>
2570
2571         Reviewed by Lucas Forschler.
2572
2573         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2574         ports. Note that this separation is optional, the --ios-simulator command remains.
2575
2576         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2577         (RunTest.test_device_type_test_division): Drive-by fix.
2578         (RunTest.test_device_type_specific_listing): Ditto.
2579         (RunTest.test_ipad_test_division):
2580         (RunTest):
2581         (RunTest.test_ipad_listing):
2582         * Scripts/webkitpy/port/factory.py:
2583         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2584         (PortFactory):
2585         * Scripts/webkitpy/port/ios_simulator.py:
2586         (IPhoneSimulatorPort):
2587         (IPadSimulatorPort):
2588
2589 2019-01-18  Chris Dumez  <cdumez@apple.com>
2590
2591         Regression(PSON) Scroll position is not always restored properly when navigating back
2592         https://bugs.webkit.org/show_bug.cgi?id=193578
2593         <rdar://problem/47386331>
2594
2595         Reviewed by Tim Horton.
2596
2597         Add API test coverage.
2598
2599         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2600
2601 2019-01-18  Youenn Fablet  <youenn@apple.com>
2602
2603         Add a new SPI to request for cache storage quota increase
2604         https://bugs.webkit.org/show_bug.cgi?id=193323
2605
2606         Reviewed by Alex Christensen.
2607
2608         Implement WebsiteDataStore quota delegate to handle quota requests.
2609         By default, do not update quota.
2610         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2611
2612         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2613         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2614         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2615         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2616         * WebKitTestRunner/TestController.cpp:
2617         (WTR::TestController::allowCacheStorageQuotaIncrease):
2618         * WebKitTestRunner/TestController.h:
2619         * WebKitTestRunner/TestInvocation.cpp:
2620         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2621         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2622         (-[CacheStorageQuotaManager init]):
2623         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2624         (WTR::initializeWebViewConfiguration):
2625         (WTR::TestController::cocoaResetStateToConsistentValues):
2626         (WTR::TestController::allowCacheStorageQuotaIncrease):
2627
2628 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2629
2630         [ews-build] Pass owner to the triggered builds
2631         https://bugs.webkit.org/show_bug.cgi?id=193574
2632
2633         Reviewed by Lucas Forschler.
2634
2635         * BuildSlaveSupport/ews-build/factories.py:
2636         (BuildFactory.propertiesToPassToTriggers):
2637
2638 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2639
2640         [ews-app] Send patch author as a build property
2641         https://bugs.webkit.org/show_bug.cgi?id=193560
2642
2643         Reviewed by Lucas Forschler.
2644
2645         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2646         (BugzillaPatchFetcher.fetch):
2647
2648 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2649
2650         webkitpy: Implement device type specific expected results (Follow-up fix)
2651         https://bugs.webkit.org/show_bug.cgi?id=192162
2652         <rdar://problem/46345449>
2653
2654         Unreviewed infrastructure fix.
2655
2656         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2657         (Manager.run): Don't boot a device if no tests are available to run on it.
2658
2659 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2660
2661         webkitpy: Implement device type specific expected results (Follow-up fix)
2662         https://bugs.webkit.org/show_bug.cgi?id=192162
2663         <rdar://problem/46345449>
2664
2665         Unreviewed infrastructure fix.
2666
2667         * Scripts/webkitpy/api_tests/manager.py:
2668         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2669
2670 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2671
2672         webkitpy: Implement device type specific expected results (Part 2)
2673         https://bugs.webkit.org/show_bug.cgi?id=192162
2674         <rdar://problem/46345449>
2675
2676         Rubber-stamped by Aakash Jain.
2677
2678         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2679         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2680         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2681
2682         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2683         (LayoutTestFinder.find_tests): Pass device_type through.
2684         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2685         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2686         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2687         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2688         (Manager._collect_tests): Pass device type to test finder.
2689         (Manager._needs_web_platform_test):
2690         (Manager._prepare_lists): Index _expectations by device type.
2691         (Manager._test_input_for_file):
2692         (Manager._test_is_slow): Ditto.
2693         (Manager._test_should_dump_jsconsolelog_in_stderr):
2694         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2695         (Manager._get_test_inputs):
2696         (Manager._update_worker_count):
2697         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2698         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2699         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2700         the one which runs the test.
2701         (Manager._run_test_subset):
2702         (Manager._run_tests): Index _expectations by current_device_type.
2703         (Manager._print_expectation_line_for_test): Ditto.
2704         (Manager._print_expectations_for_subset): Ditto.
2705         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2706         Unlike run, this function will behave the same regardless of what devices are available.
2707         (Manager._custom_device_for_test): Deleted.
2708         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2709         (ManagerTest.test_uses_custom_device): Deleted.
2710         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2711         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2712         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2713         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2714         all of the expectations.
2715         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2716         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2717         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2718         (TestExpectations.__init__): Allow device_type to be passed through.
2719         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2720         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2721         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2722         (summarize_results):
2723         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2724         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2725         a test ran with, one must check all expectations to find the first non-skip expectation.
2726         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2727         (RunTest.test_device_type_test_division):
2728         (RunTest):
2729         (RunTest.test_device_type_specific_listing):
2730         * Scripts/webkitpy/port/base.py:
2731         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2732         (Port.supported_device_types): The result of this function will change based on what devices are available.
2733         * Scripts/webkitpy/port/device_port.py:
2734         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2735         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2736         can be used.
2737         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2738         any, or the DEFAULT_DEVICE_TYPES of the port.
2739         * Scripts/webkitpy/port/ios.py:
2740         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2741         * Scripts/webkitpy/port/ios_simulator.py:
2742         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2743         * Scripts/webkitpy/port/watch.py:
2744         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2745         * Scripts/webkitpy/port/watch_simulator.py:
2746         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2747         * Scripts/webkitpy/xcode/device_type.py:
2748         (DeviceType):
2749         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2750
2751 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2752
2753         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2754         https://bugs.webkit.org/show_bug.cgi?id=193575
2755
2756         Reviewed by Michael Catanzaro.
2757
2758         Allow the script to run without explicit port argument because
2759         it's specific to the WPE port anyway.
2760
2761         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2762         and simplify the rest of the code accordingly.
2763
2764 2019-01-18  Charlie Turner  <cturner@igalia.com>
2765
2766         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2767         https://bugs.webkit.org/show_bug.cgi?id=192229
2768
2769         Reviewed by Xabier Rodriguez-Calvar.
2770
2771         * MiniBrowser/wpe/main.cpp:
2772         (main): Enable encrypted-media by default.
2773
2774 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2775
2776         [Flatpak] Missing KeyboardInterrupt exception handler
2777         https://bugs.webkit.org/show_bug.cgi?id=193570
2778
2779         Reviewed by Michael Catanzaro.
2780
2781         * flatpak/flatpakutils.py:
2782         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2783
2784 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2785
2786         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2787         https://bugs.webkit.org/show_bug.cgi?id=193564
2788
2789         Reviewed by Antti Koivisto.
2790
2791         * LayoutReloaded/misc/LFC-passing-tests.txt:
2792
2793 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2794
2795         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2796         https://bugs.webkit.org/show_bug.cgi?id=193562
2797
2798         Reviewed by Antti Koivisto.
2799
2800         * LayoutReloaded/misc/LFC-passing-tests.txt:
2801
2802 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2803
2804         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2805         https://bugs.webkit.org/show_bug.cgi?id=193555
2806
2807         Reviewed by Antti Koivisto.
2808
2809         * LayoutReloaded/misc/LFC-passing-tests.txt:
2810
2811 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2812
2813         [WPE] Add Qt extension
2814         https://bugs.webkit.org/show_bug.cgi?id=191464
2815
2816         Reviewed by Carlos Garcia Campos.
2817
2818         MiniBrowser and API tests for the WPE Qt API. To run the
2819         MiniBrowser a new script is introduced. Example invocation:
2820
2821         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2822
2823         Also note-worthy is the introduction of the python2-subprocess32
2824         dependency to run the GLib API tests.
2825
2826         * MiniBrowser/wpe/CMakeLists.txt:
2827         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2828         * MiniBrowser/wpe/qt/main.cpp: Added.
2829         (main):
2830         * MiniBrowser/wpe/qt/main.qml: Added.
2831         * MiniBrowser/wpe/qt/qml.qrc: Added.
2832         * Scripts/run-gtk-tests:
2833         (GtkTestRunner.is_google_test):
2834         (GtkTestRunner):
2835         (GtkTestRunner.is_qt_test):
2836         * Scripts/run-qt-wpe-minibrowser: Added.
2837         * Scripts/run-wpe-tests:
2838         (WPETestRunner):
2839         (WPETestRunner.is_google_test):
2840         (WPETestRunner.is_qt_test):
2841         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2842         (TestLoad::main):
2843         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2844         (TestLoadHtml::main):
2845         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2846         (TestLoadRequest::main):
2847         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2848         (TestRunJavaScript::main):
2849         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2850         (waitForSignal):
2851         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2852         (LoadSpy::LoadSpy):
2853         (LoadSpy::~LoadSpy):
2854         (LoadSpy::onLoadingChanged):
2855         (LoadStartedCatcher::LoadStartedCatcher):
2856         (LoadStartedCatcher::~LoadStartedCatcher):
2857         (LoadStartedCatcher::onLoadingChanged):
2858         (waitForLoadSucceeded):
2859         (waitForLoadFailed):
2860         * TestWebKitAPI/glib/CMakeLists.txt:
2861         * flatpak/flatpakutils.py:
2862         (WebkitFlatpak.load_from_args):
2863         (WebkitFlatpak.__init__):
2864         (WebkitFlatpak.clean_args):
2865         (WebkitFlatpak.run_in_sandbox):
2866         * flatpak/org.webkit.CommonModules.yaml:
2867         * flatpak/org.webkit.WPE.yaml:
2868         * flatpak/org.webkit.WPEModules.yaml:
2869         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2870         * flatpak/org.webkit.WebKit.yaml:
2871         * glib/api_test_runner.py:
2872         (TestRunner._run_test_qt):
2873         (TestRunner.is_qt_test):
2874         (TestRunner._run_test):
2875
2876 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2877
2878         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2879         https://bugs.webkit.org/show_bug.cgi?id=193494
2880         <rdar://problem/46859627>
2881
2882         Reviewed by Simon Fraser and Tim Horton.
2883
2884         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2885         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2886
2887         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2888         (WTR::UIScriptController::contentOffsetX const):
2889         (WTR::UIScriptController::contentOffsetY const):
2890         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2891         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2892         (WTR::UIScriptController::contentOffsetX const):
2893         (WTR::UIScriptController::contentOffsetY const):
2894         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2895
2896         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2897
2898         * WebKitTestRunner/TestController.cpp:
2899         (WTR::updateTestOptionsFromTestHeader):
2900         * WebKitTestRunner/TestOptions.h:
2901         (WTR::TestOptions::hasSameInitializationOptions const):
2902         * WebKitTestRunner/ios/TestControllerIOS.mm:
2903         (WTR::TestController::platformResetStateToConsistentValues):
2904         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2905         (WTR::UIScriptController::contentOffsetX const):
2906         (WTR::UIScriptController::contentOffsetY const):
2907
2908 2019-01-17  Truitt Savell  <tsavell@apple.com>
2909
2910         Unreviewed, rolling out r240124.
2911
2912         This commit broke an internal build.
2913
2914         Reverted changeset:
2915
2916         "SDK_VARIANT build destinations should be separate from non-
2917         SDK_VARIANT builds"
2918         https://bugs.webkit.org/show_bug.cgi?id=189553
2919         https://trac.webkit.org/changeset/240124
2920
2921 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2922
2923         Fix string concatenation API test after r239920
2924         https://bugs.webkit.org/show_bug.cgi?id=193551
2925         <rdar://problem/47359304>
2926
2927         Reviewed by Youenn Fablet.
2928
2929         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2930         (TestWebKitAPI::TEST):
2931         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2932         in WebKit's build configuration like it apparently is on Linux.
2933
2934 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2935
2936         [ews-build] validate-patch should handle the case when bug_id is None
2937         https://bugs.webkit.org/show_bug.cgi?id=193547
2938
2939         Reviewed by Lucas Forschler.
2940
2941         * BuildSlaveSupport/ews-build/steps.py:
2942         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2943         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2944
2945 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2946
2947         [ews-build] Add patch author information in build
2948         https://bugs.webkit.org/show_bug.cgi?id=193465
2949
2950         Reviewed by Lucas Forschler.
2951
2952         * BuildSlaveSupport/ews-build/steps.py:
2953         (ValidatePatch._is_patch_obsolete):
2954
2955 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2956
2957         [ews-build] Pass bug_id to the triggered builds
2958         https://bugs.webkit.org/show_bug.cgi?id=193548
2959
2960         Reviewed by Lucas Forschler.
2961
2962         * BuildSlaveSupport/ews-build/factories.py:
2963         (BuildFactory.propertiesToPassToTriggers):
2964
2965 2019-01-17  Jer Noble  <jer.noble@apple.com>
2966
2967         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2968         https://bugs.webkit.org/show_bug.cgi?id=189553
2969
2970         Reviewed by Tim Horton.
2971
2972         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2973
2974         * ContentExtensionTester/Configurations/Base.xcconfig:
2975         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2976         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2977         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2978         * ImageDiff/cg/Configurations/Base.xcconfig:
2979         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2980         * MiniBrowser/Configurations/Base.xcconfig:
2981         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2982         * MobileMiniBrowser/Configurations/Base.xcconfig:
2983         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2984         * Scripts/webkitpy/style/checker.py:
2985         (_all_categories):
2986         (FileType):
2987         (CheckerDispatcher._file_type):
2988         (CheckerDispatcher._create_checker):
2989         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2990         (SDKVariantChecker):
2991         (SDKVariantChecker.__init__):
2992         (SDKVariantChecker.check):
2993         * TestWebKitAPI/Configurations/Base.xcconfig:
2994         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2995         * WebEditingTester/Configurations/Base.xcconfig:
2996         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2997         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2998         * WebKitTestRunner/Configurations/Base.xcconfig:
2999         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3000         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3001         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3002
3003 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3004
3005         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3006         https://bugs.webkit.org/show_bug.cgi?id=193534
3007
3008         Reviewed by Antti Koivisto.
3009
3010         * LayoutReloaded/misc/LFC-passing-tests.txt:
3011
3012 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3013
3014         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3015         https://bugs.webkit.org/show_bug.cgi?id=193528
3016
3017         Reviewed by Antti Koivisto.
3018
3019         * LayoutReloaded/misc/LFC-passing-tests.txt:
3020
3021 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3022
3023         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3024         https://bugs.webkit.org/show_bug.cgi?id=193520
3025
3026         Reviewed by Antti Koivisto.
3027
3028         * LayoutReloaded/misc/LFC-passing-tests.txt:
3029
3030 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3031
3032         [ews-build] unapply-patch step should not update source
3033         https://bugs.webkit.org/show_bug.cgi?id=193234
3034
3035         Reviewed by Lucas Forschler.
3036
3037         * BuildSlaveSupport/ews-build/steps.py:
3038         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3039         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3040
3041 2019-01-16  Youenn Fablet  <youenn@apple.com>
3042
3043         Add a new SPI for controlling getUserMedia
3044         https://bugs.webkit.org/show_bug.cgi?id=192793
3045
3046         Reviewed by Eric Carlson.
3047
3048         * MiniBrowser/mac/WK2BrowserWindowController.m:
3049         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3050         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3051         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3052         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3053         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3054         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3055         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3056         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3057         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3058         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3059         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3060         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3061         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3062         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3063
3064 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3065
3066         [LFC][BFC] Inflow non-replaced used width should not be negative.
3067         https://bugs.webkit.org/show_bug.cgi?id=193495
3068
3069         Reviewed by Antti Koivisto.
3070
3071         * LayoutReloaded/misc/LFC-passing-tests.txt:
3072
3073 2019-01-16  Chris Dumez  <cdumez@apple.com>
3074
3075         Regression(PSON) View becomes blank after click a cross-site download link
3076         https://bugs.webkit.org/show_bug.cgi?id=193361
3077         <rdar://problem/47099573>
3078
3079         Reviewed by Geoffrey Garen.
3080
3081         Add API test coverage.
3082
3083         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3084         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3085
3086 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3087
3088         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3089         https://bugs.webkit.org/show_bug.cgi?id=193470
3090
3091         Reviewed by Antti Koivisto.
3092
3093         * LayoutReloaded/misc/LFC-passing-tests.txt:
3094
3095 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3096
3097         [LFC] Adjust margin box verification.
3098         https://bugs.webkit.org/show_bug.cgi?id=193482
3099
3100         Reviewed by Antti Koivisto.
3101
3102         * LayoutReloaded/misc/LFC-passing-tests.txt:
3103
3104 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3105
3106         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3107         https://bugs.webkit.org/show_bug.cgi?id=193451
3108
3109         Reviewed by Geoffrey Garen.
3110
3111         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3112         (TEST):
3113         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3114         (runWebsiteDataStoreCustomPaths):
3115
3116 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3117
3118         webkitpy: Support boolean simctl isAvailable
3119         https://bugs.webkit.org/show_bug.cgi?id=193472
3120         <rdar://problem/47296150>
3121
3122         Reviewed by Ryosuke Niwa.
3123
3124         * Scripts/webkitpy/xcode/simulated_device.py:
3125         (SimulatedDeviceManager._create_runtimes):
3126         (SimulatedDeviceManager._create_device_with_runtime):
3127
3128 2019-01-15  Chris Dumez  <cdumez@apple.com>
3129
3130         Unreviewed, rolling out r239993, r239995, r239997, and
3131         r239999.
3132
3133         Caused assertions under
3134         ViewGestureController::disconnectFromProcess()
3135
3136         Reverted changesets:
3137
3138         "Regression(PSON) View becomes blank after click a cross-site
3139         download link"
3140         https://bugs.webkit.org/show_bug.cgi?id=193361
3141         https://trac.webkit.org/changeset/239993
3142
3143         "Unreviewed iOS build fix after r239993."
3144         https://trac.webkit.org/changeset/239995
3145
3146         "Fix iOS build after r239993"
3147         https://bugs.webkit.org/show_bug.cgi?id=193361
3148         https://trac.webkit.org/changeset/239997
3149
3150         "Unreviewed, revert part of r239997 as it is not needed to fix
3151         the build."
3152         https://trac.webkit.org/changeset/239999
3153
3154 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3155
3156         Cannot tab out of WKWebView on macOS
3157         https://bugs.webkit.org/show_bug.cgi?id=161448
3158         <rdar://problem/28100085>
3159
3160         Reviewed by Dean Jackson.
3161
3162         Add a test that tabbing into and out of WKWebView works correctly.
3163
3164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3165         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3166         (WebKit2_CommandBackForwardTest::SetUp):
3167         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3168         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3169         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3170         (-[FocusableView canBecomeKeyView]):
3171         (TEST):
3172         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3173         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3174         (-[OffscreenWindow initWithSize:]):
3175         (-[OffscreenWindow isKeyWindow]):
3176         (-[OffscreenWindow isVisible]):
3177         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3178         (TestWebKitAPI::PlatformWebView::initialize):
3179         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3180         (-[ActiveOffscreenWindow isVisible]): Deleted.
3181         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3182
3183 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3184
3185         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3186         https://bugs.webkit.org/show_bug.cgi?id=193459
3187
3188         Reviewed by Mark Lam.
3189
3190         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3191         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3192
3193 2019-01-15  Chris Dumez  <cdumez@apple.com>
3194
3195         Regression(PSON) View becomes blank after click a cross-site download link
3196         https://bugs.webkit.org/show_bug.cgi?id=193361
3197         <rdar://problem/47099573>
3198
3199         Reviewed by Geoff Garen.
3200
3201         Add API test coverage.
3202
3203         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3204         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3205
3206 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3207
3208         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3209         https://bugs.webkit.org/show_bug.cgi?id=193448
3210
3211         Reviewed by Antti Koivisto.
3212
3213         * LayoutReloaded/misc/LFC-passing-tests.txt:
3214
3215 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3216
3217         webkitpy: Implement device type specific expected results (Part 1)
3218         https://bugs.webkit.org/show_bug.cgi?id=192162
3219
3220         Reviewed by Lucas Forschler.
3221
3222         Device type specific expected results covers two related ideas. The first (covered by this change)
3223         is where to search for -expected.* files. The second is which tests to run based on the
3224         TestExpectations.txt file.
3225
3226         After this change, the baseline search path will be determined by the type of device running a
3227         test. Device type will be passed into any function which picks a file based on the baseline search
3228         path.
3229
3230         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3231         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3232         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3233         (Manager.run): Print baseline search path for each round of devices.
3234         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3235         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3236         (SingleTestRunner._expected_driver_output): Ditto.
3237         (SingleTestRunner._driver_input): Ditto.
3238         * Scripts/webkitpy/layout_tests/views/printing.py:
3239         (Printer.print_config): Move printing of baseline search path to a separate function.
3240         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3241         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3242         (Testprinter.test_print_config):
3243         (Testprinter.test_print_baseline_search_path):
3244         * Scripts/webkitpy/port/base.py:
3245         (Port.baseline_search_path): Pass device_type through.
3246         (Port._expected_baselines_for_suffixes): Ditto.
3247         (Port.expected_baselines): Ditto.
3248         (Port.expected_filename): Ditto.
3249         (Port.expected_checksum): Ditto.
3250         (Port.expected_image): Ditto.
3251         (Port.expected_audio): Ditto.
3252         (Port.expected_text): Ditto.
3253         (Port.reference_files): Ditto.
3254         (Port.tests): Ditto.
3255         (Port._expanded_paths): Ditto.
3256         (Port.skipped_layout_tests): Ditto.
3257         (Port.expectations_dict): Ditto.
3258         (Port._port_specific_expectations_files): Ditto.
3259         (Port.expectations_files): Ditto.
3260         (Port.test_search_path): Ditto.
3261         (Port._tests_for_other_platforms): Ditto.
3262         * Scripts/webkitpy/port/base_unittest.py:
3263         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3264         (PortTest.test_nonexistant_expectations): Ditto.
3265         (test_ref_tests_platform_directory): Ditto.
3266         * Scripts/webkitpy/port/darwin.py:
3267         (DarwinPort._port_specific_expectations_files): Accept device_type.
3268         * Scripts/webkitpy/port/driver.py:
3269         (DriverProxy):
3270         (DriverProxy.host): Expose _target_host for device_type information.
3271         * Scripts/webkitpy/port/gtk.py:
3272         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3273         * Scripts/webkitpy/port/ios.py:
3274         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3275         * Scripts/webkitpy/port/mac.py:
3276         (MacPort. default_baseline_search_path): Ditto.
3277         * Scripts/webkitpy/port/port_testcase.py:
3278         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3279         * Scripts/webkitpy/port/test.py:
3280         * Scripts/webkitpy/port/watch.py:
3281         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3282         * Scripts/webkitpy/port/win.py:
3283         (WinPort.test_search_path): Accept, but do not use, device_type.
3284         * Scripts/webkitpy/port/wpe.py:
3285         (WPEPort._port_specific_expectations_files): Ditto.
3286         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3287         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3288
3289 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3290
3291         [LFC] Use the containing block's padding box to position out-of-flow elements.
3292         https://bugs.webkit.org/show_bug.cgi?id=193431
3293
3294         Reviewed by Antti Koivisto.
3295
3296         * LayoutReloaded/misc/LFC-passing-tests.txt:
3297
3298 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3299
3300         Move a test implementation file that got misplaced in the Xcode project
3301
3302         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3303
3304 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3305
3306         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3307         r239913, and r239914.
3308         https://bugs.webkit.org/show_bug.cgi?id=193407
3309
3310         These revisions caused an internal failure (Requested by
3311         Truitt on #webkit).
3312
3313         Reverted changesets:
3314
3315         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3316         https://bugs.webkit.org/show_bug.cgi?id=186016
3317         https://trac.webkit.org/changeset/239901
3318
3319         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3320         https://trac.webkit.org/changeset/239909
3321
3322         "Tried to fix the build."
3323         https://trac.webkit.org/changeset/239910
3324
3325         "Fixed iOS builds after r239910."
3326         https://trac.webkit.org/changeset/239912
3327
3328         "More build fixing."
3329         https://trac.webkit.org/changeset/239913
3330
3331         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3332         https://trac.webkit.org/changeset/239914
3333
3334 2019-01-14  Mark Lam  <mark.lam@apple.com>
3335
3336         Re-enable ability to build --cloop builds.
3337         https://bugs.webkit.org/show_bug.cgi?id=192955
3338         <rdar://problem/46882363>
3339
3340         Reviewed by Saam barati and Keith Miller.
3341
3342         The --cloop build option was being ignored this whole time since r236381.
3343         This patch makes it possible to build CLoop builds again.
3344
3345         * Scripts/build-jsc:
3346         * Scripts/webkitperl/FeatureList.pm:
3347         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3348
3349 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3350
3351         webkitpy: Expose device_type from host-like objects
3352         https://bugs.webkit.org/show_bug.cgi?id=193406
3353         <rdar://problem/47262305>
3354
3355         Reviewed by Lucas Forschler.
3356
3357         Devices should expose device_type. As a result, all host objects should
3358         provide a device_type property, even if they do not yet define a device_type.
3359
3360         * Scripts/webkitpy/common/system/systemhost.py:
3361         (SystemHost):
3362         (SystemHost.device_type):
3363         * Scripts/webkitpy/common/system/systemhost_mock.py:
3364         (MockSystemHost):
3365         (MockSystemHost.device_type):
3366         * Scripts/webkitpy/port/device.py:
3367         (Device):
3368         (Device.device_type):
3369         * Scripts/webkitpy/xcode/simulated_device.py:
3370         (SimulatedDeviceManager._find_exisiting_device_for_request):
3371         (SimulatedDeviceManager._disambiguate_device_type):
3372         (SimulatedDeviceManager._does_fulfill_request):
3373         (SimulatedDeviceManager.device_count_for_type):
3374         (SimulatedDeviceManager.initialize_devices):
3375         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3376         (test_available_devices):
3377         (test_swapping_devices):
3378
3379 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3380
3381         webkitpy: Support alternate simctl device list output (Follow-up fix)
3382         https://bugs.webkit.org/show_bug.cgi?id=193362
3383         <rdar://problem/47122965>
3384
3385         Rubber-stamped by Lucas Forschler.
3386
3387         * Scripts/webkitpy/xcode/simulated_device.py:
3388         (SimulatedDeviceManager.populate_available_devices):
3389
3390 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3391
3392         [iOS] Expose SPI to access the current sentence boundary and selection state
3393         https://bugs.webkit.org/show_bug.cgi?id=193398
3394         <rdar://problem/45893108>
3395
3396         Reviewed by Dean Jackson.
3397
3398         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3399         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3400         expected.
3401
3402         * TestWebKitAPI/EditingTestHarness.h:
3403         * TestWebKitAPI/EditingTestHarness.mm:
3404         (-[EditingTestHarness moveBackward]):
3405         (-[EditingTestHarness moveForward]):
3406         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3407
3408         Add a couple of new helper methods on EditingTestHarness.
3409
3410         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3411         (-[SelectionChangeObserver initWithWebView:]):
3412         (-[SelectionChangeObserver webView]):
3413         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3414         (-[SelectionChangeObserver currentSelectionAttributes]):
3415
3416 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3417
3418         [LFC][BFC] Add basic box-sizing support.
3419         https://bugs.webkit.org/show_bug.cgi?id=193392
3420
3421         Reviewed by Antti Koivisto.
3422
3423         * LayoutReloaded/misc/LFC-passing-tests.txt:
3424
3425 2019-01-14  Charlie Turner  <cturner@igalia.com>
3426
3427         [WPE] API test gardening
3428         https://bugs.webkit.org/show_bug.cgi?id=193319
3429
3430         Reviewed by Michael Catanzaro.
3431
3432         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3433         passing tests.
3434
3435 2019-01-14  Charlie Turner  <cturner@igalia.com>
3436
3437         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3438         https://bugs.webkit.org/show_bug.cgi?id=192977
3439
3440         Reviewed by Carlos Garcia Campos.
3441
3442         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3443         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3444         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3445         (TestWebKitAPI::GStreamerTest::SetUp):
3446         (TestWebKitAPI::GStreamerTest::TearDown):
3447         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3448         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3449         (TestWebKitAPI::TEST_F):
3450
3451 2019-01-14  Charlie Turner  <cturner@igalia.com>
3452
3453         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3454         https://bugs.webkit.org/show_bug.cgi?id=193332
3455
3456         Reviewed by Michael Catanzaro.
3457
3458         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3459         defined as a char16_t, which changed in ICU 59, the
3460         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3461         unsigned short. This test is relying on the behaviour that
3462         UChar=unsigned short, which doesn't hold across platforms and ICU
3463         library versions. The full fix would be a special syntax for
3464         literal characters so that these ambiguities do not arise. That
3465         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3466         (TestWebKitAPI::TEST):
3467
3468 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3469
3470         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3471
3472         * Scripts/make-dist:
3473         (Distcheck.configure):
3474
3475 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3476
3477         [ews-build] Update macOS queue configurations
3478         https://bugs.webkit.org/show_bug.cgi?id=193365
3479         <rdar://problem/47221073>
3480
3481         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3482
3483         * BuildSlaveSupport/ews-build/config.json:
3484
3485 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3486
3487         [LFC] Adjust assert for statically positioned fixed elements
3488         https://bugs.webkit.org/show_bug.cgi?id=193385
3489
3490         Reviewed by Antti Koivisto.
3491
3492         * LayoutReloaded/misc/LFC-passing-tests.txt:
3493
3494 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3495
3496         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3497         https://bugs.webkit.org/show_bug.cgi?id=193387
3498
3499         Reviewed by Carlos Garcia Campos.
3500
3501         * MiniBrowser/wpe/main.cpp:
3502         (main):
3503
3504 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3505
3506         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3507         https://bugs.webkit.org/show_bug.cgi?id=191655
3508         rdar://problem/46074680
3509
3510         Reviewed by Megan Gardner.
3511
3512         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3513         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3514
3515 2019-01-12  Dan Bernstein  <mitz@apple.com>
3516
3517         [Cocoa] Avoid importing directly from subumbrella frameworks
3518         https://bugs.webkit.org/show_bug.cgi?id=186016
3519         <rdar://problem/40591038>
3520
3521         Reviewed by Sam Weinig.
3522
3523         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3524           LaunchServices header.
3525         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3526           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3527         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3528           when using SDKs earlier than 10.13.
3529         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3530           and OTHER_CPLUSPLUSFLAGS.
3531         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3532           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3533         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3534           LaunchServices header.
3535
3536 2019-01-11  John Wilander  <wilander@apple.com>
3537
3538         Compile out Web API Statistics Collection
3539         https://bugs.webkit.org/show_bug.cgi?id=193370
3540         <rdar://problem/45388584>
3541
3542         Reviewed by Brent Fulgham.
3543
3544         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3545             Defined ENABLE_WEB_API_STATISTICS, off by default.
3546
3547 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3548
3549         [WPE] Add gtk-doc
3550         https://bugs.webkit.org/show_bug.cgi?id=178900
3551
3552         Reviewed by Michael Catanzaro.
3553
3554         Add Tools/gtkdoc to manifest.txt.in files.
3555         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3556
3557         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3558         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3559
3560 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3561
3562         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3563         https://bugs.webkit.org/show_bug.cgi?id=193364
3564         <rdar://problem/47214117>
3565
3566         Reviewed by Tim Horton.
3567
3568         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3569         precise, whereas dragging near the middle of the textarea does.
3570
3571         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3572         (TestWebKitAPI::TEST):
3573
3574 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3575
3576         webkitpy: Support alternate simctl device list output
3577         https://bugs.webkit.org/show_bug.cgi?id=193362
3578         <rdar://problem/47122965>
3579
3580         Reviewed by Lucas Forschler.
3581
3582         * Scripts/webkitpy/xcode/simulated_device.py:
3583         (SimulatedDeviceManager.populate_available_devices):
3584
3585 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3586
3587         [ews-build] Update macOS queue configurations
3588         https://bugs.webkit.org/show_bug.cgi?id=193365
3589
3590         Reviewed by Lucas Forschler.
3591
3592         * BuildSlaveSupport/ews-build/config.json:
3593
3594 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3595
3596         webkitpy: Incorporate device type into baseline search path
3597         https://bugs.webkit.org/show_bug.cgi?id=193356
3598         <rdar://problem/47215515>
3599
3600         Reviewed by Lucas Forschler.
3601
3602         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3603
3604         * Scripts/webkitpy/port/base.py:
3605         (Port.default_baseline_search_path): Allow device type to be passed in.
3606         * Scripts/webkitpy/port/gtk.py:
3607         (GtkPort.default_baseline_search_path): Ignore device type.
3608         * Scripts/webkitpy/port/ios.py:
3609         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3610         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3611         * Scripts/webkitpy/port/ios_device_unittest.py:
3612         (IOSDeviceTest):
3613         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3614         (IOSSimulatorTest):
3615         * Scripts/webkitpy/port/mac.py:
3616         (MacPort.default_baseline_search_path): Ignore device type.
3617         * Scripts/webkitpy/port/watch.py:
3618         (WatchPort.default_baseline_search_path): Ditto.
3619         * Scripts/webkitpy/port/win.py:
3620         (WinPort.default_baseline_search_path): Ditto.
3621         (WinCairoPort.default_baseline_search_path): Ditto.
3622         * Scripts/webkitpy/port/wpe.py:
3623         (WPEPort.default_baseline_search_path): Ditto.
3624
3625 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3626
3627         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3628         https://bugs.webkit.org/show_bug.cgi?id=193352
3629         <rdar://problem/47210736>
3630
3631         Reviewed by Lucas Forschler.
3632
3633         * Scripts/webkitpy/layout_tests/views/printing.py:
3634         (Printer.print_config): Print list on only baseline search paths which exist. 
3635         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3636         (Testprinter.test_print_config):
3637
3638 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3639
3640         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3641         https://bugs.webkit.org/show_bug.cgi?id=193340
3642
3643         Reviewed by David Kilzer.
3644
3645         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3646         (WTR::InjectedBundle::didReceiveMessageToPage):
3647         Pull the strings out into a WKRetainPtr.
3648
3649         * WebKitTestRunner/WebNotificationProvider.cpp:
3650         (WTR::WebNotificationProvider::closeWebNotification):
3651         Adopt the created value into the WKRetainPtr.
3652
3653         * WebKitTestRunner/mac/TestControllerMac.mm:
3654         (WTR::generateWhitelist):
3655         Immediately adopt a created value to avoid potential mistakes.
3656
3657 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3658
3659         Enable DFG on ARM/Linux again
3660         https://bugs.webkit.org/show_bug.cgi?id=192496
3661
3662         Reviewed by Yusuke Suzuki.
3663
3664         After changing the bytecode format DFG was disabled on all 32-bit
3665         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3666         on ARM by default.
3667
3668         * Scripts/run-jsc-stress-tests:
3669
3670 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3671
3672         Unreviewed, fix #ifdef in API test added in r239851.
3673         https://bugs.webkit.org/show_bug.cgi?id=193327
3674         rdar://problem/47093222
3675
3676         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3677
3678 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3679
3680         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3681         https://bugs.webkit.org/show_bug.cgi?id=193109
3682         <rdar://problem/44807048>
3683
3684         Reviewed by Ryosuke Niwa.
3685
3686         Introduce and respect a test option to enable the UndoManager API.
3687
3688         * WebKitTestRunner/TestController.cpp:
3689         (WTR::updateTestOptionsFromTestHeader):
3690         * WebKitTestRunner/TestOptions.h:
3691         (WTR::TestOptions::hasSameInitializationOptions const):
3692         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3693         (WTR::TestController::platformCreateWebView):
3694
3695 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3696
3697         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3698         https://bugs.webkit.org/show_bug.cgi?id=193346
3699
3700         Reviewed by Antti Koivisto.
3701
3702         * LayoutReloaded/misc/LFC-passing-tests.txt:
3703
3704 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3705
3706         Unreviewed, fix typo that breaks dashboard link.
3707
3708         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3709         (WebKitBuildbot):
3710
3711 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3712
3713         Update macOS queue configurations
3714         https://bugs.webkit.org/show_bug.cgi?id=193329
3715
3716         Reviewed by Alexey Proskuryakov.
3717
3718         * BuildSlaveSupport/build.webkit.org-config/config.json:
3719         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3720         (BubbleQueueServer):
3721         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3722         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3723         (WebKitBuildbot):
3724         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3725         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3726         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3727
3728 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3729
3730         MiniBrowser should be able to navigate to about:blank
3731         https://bugs.webkit.org/show_bug.cgi?id=193345
3732
3733         Reviewed by Simon Fraser.
3734
3735         * MiniBrowser/mac/BrowserWindowController.m:
3736         (-[BrowserWindowController addProtocolIfNecessary:]):
3737         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3738
3739         * MiniBrowser/mac/WK1BrowserWindowController.m:
3740         (-[WK1BrowserWindowController fetch:]):
3741         * MiniBrowser/mac/WK2BrowserWindowController.m:
3742         (-[WK2BrowserWindowController fetch:]):
3743         Clean up the code that uses this to match style.
3744
3745 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3746
3747         Remove MiniBrowser custom "Process Swap" menu item which does not work
3748         https://bugs.webkit.org/show_bug.cgi?id=193344
3749
3750         Reviewed by Simon Fraser.
3751
3752         There is a menu item under the Experimental menu that does work.
3753
3754         * MiniBrowser/mac/AppDelegate.m:
3755         (defaultConfiguration):
3756         * MiniBrowser/mac/SettingsController.h:
3757         * MiniBrowser/mac/SettingsController.m:
3758         (-[SettingsController _populateMenu]):
3759         (-[SettingsController validateMenuItem:]):
3760         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3761         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3762
3763 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3764
3765         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3766         https://bugs.webkit.org/show_bug.cgi?id=193327
3767         rdar://problem/47093222
3768
3769         Reviewed by Tim Horton.
3770
3771         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3772         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3773         (TestWebKitAPI::didFinishNavigation):
3774         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3775         (TestWebKitAPI::TEST):
3776         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3777         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3778         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3779         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3780         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3781
3782 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3783
3784         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3785         https://bugs.webkit.org/show_bug.cgi?id=193338
3786         <rdar://problem/46664774>
3787
3788         Reviewed by David Kilzer.
3789
3790         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3791         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3792
3793 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3794
3795         Unreviewed, rolling out r239825.
3796         https://bugs.webkit.org/show_bug.cgi?id=193330
3797
3798         Broke tests on armv7/linux bots (Requested by guijemont on
3799         #webkit).
3800
3801         Reverted changeset:
3802
3803         "Enable DFG on ARM/Linux again"
3804         https://bugs.webkit.org/show_bug.cgi?id=192496
3805         https://trac.webkit.org/changeset/239825
3806
3807 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3808
3809         Disable the run-jsc-stress-test remote host key check.
3810         https://bugs.webkit.org/show_bug.cgi?id=192988
3811
3812         Reviewed by Alexey Proskuryakov.
3813
3814         * Scripts/run-jsc-stress-tests:
3815
3816 2019-01-10  John Wilander  <wilander@apple.com>
3817
3818         Override the session configuration for cookieAcceptPolicy
3819         https://bugs.webkit.org/show_bug.cgi?id=190925
3820         <rdar://problem/45497382>
3821
3822         Reviewed by Alexey Proskuryakov and Alex Christensen.
3823
3824         Test infrastructure for setting a first-party-only cookie policy.
3825
3826         * DumpRenderTree/TestRunner.cpp:
3827         (setOnlyAcceptFirstPartyCookiesCallback):
3828         (TestRunner::staticFunctions):
3829         * DumpRenderTree/TestRunner.h:
3830         * DumpRenderTree/mac/TestRunnerMac.mm:
3831         (TestRunner::setOnlyAcceptFirstPartyCookies):
3832         * DumpRenderTree/win/TestRunnerWin.cpp:
3833         (TestRunner::setOnlyAcceptFirstPartyCookies):
3834         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3835         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3836         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3837         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3838         * WebKitTestRunner/TestInvocation.cpp:
3839         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3840
3841 2019-01-09  Matt Rajca  <mrajca@apple.com>
3842
3843         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
3844         https://bugs.webkit.org/show_bug.cgi?id=193301
3845
3846         Reviewed by Jer Noble.
3847         
3848         Added API tests.
3849
3850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3851         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3852         (TEST):
3853         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
3854
3855 2019-01-10  Zalan Bujtas  <zalan@apple.com>
3856
3857         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
3858         https://bugs.webkit.org/show_bug.cgi?id=193310
3859
3860         Reviewed by Antti Koivisto.
3861
3862         * LayoutReloaded/misc/LFC-passing-tests.txt:
3863
3864 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
3865
3866         Enable DFG on ARM/Linux again
3867         https://bugs.webkit.org/show_bug.cgi?id=192496
3868
3869         Reviewed by Yusuke Suzuki.
3870
3871         After changing the bytecode format DFG was disabled on all 32-bit
3872         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3873         on ARM by default.
3874
3875         * Scripts/run-jsc-stress-tests:
3876
3877 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3878
3879         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
3880         https://bugs.webkit.org/show_bug.cgi?id=193271
3881
3882         Reviewed by Brent Fulgham.
3883
3884         BSTR is a special data structure created by SysAllocString, not a
3885         wchar_t null-terminated string.
3886
3887         * DumpRenderTree/win/TestRunnerWin.cpp:
3888         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
3889         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3890         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
3891         BSTR from wide string literals.
3892
3893 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
3894
3895         Tweak wording for build/version_check style checker error
3896         https://bugs.webkit.org/show_bug.cgi?id=193256
3897
3898         Reviewed by Tim Horton.
3899
3900         * Scripts/webkitpy/style/checkers/cpp.py:
3901         (check_os_version_checks):
3902         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3903         (WebKitStyleTest.test_os_version_checks):
3904
3905 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3906
3907         [ews-build] Add link to bug along with bug title
3908         https://bugs.webkit.org/show_bug.cgi?id=193293
3909
3910         Reviewed by Lucas Forschler.
3911
3912         * BuildSlaveSupport/ews-build/steps.py:
3913         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
3914         (ConfigureBuild.add_bug_id_url): Deleted.
3915         (ConfigureBuild.getBugURL): Deleted.
3916
3917 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3918
3919         [ews-build] Use https for ews-build server
3920         https://bugs.webkit.org/show_bug.cgi?id=193193
3921
3922         Reviewed by Lucas Forschler.
3923
3924         * BuildSlaveSupport/ews-build/steps.py:
3925
3926 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3927
3928         [ews-build] Parse and display number of style failures
3929         https://bugs.webkit.org/show_bug.cgi?id=193280
3930
3931         Reviewed by Lucas Forschler.
3932
3933         * BuildSlaveSupport/ews-build/steps.py:
3934         (CheckStyle): Use TestWithFailureCount as base class.
3935         (CheckStyle.countFailures): Count the number of style failures.
3936
3937 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3938
3939         [ews-build] use patch_id instead of ewspatchid
3940         https://bugs.webkit.org/show_bug.cgi?id=193235
3941
3942         Reviewed by Lucas Forschler.
3943
3944         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
3945         * BuildSlaveSupport/ews-build/steps.py: Ditto.
3946         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
3947
3948 2019-01-09  Zalan Bujtas  <zalan@apple.com>
3949
3950         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
3951         https://bugs.webkit.org/show_bug.cgi?id=192625
3952
3953         Reviewed by Antti Koivisto.
3954
3955         * LayoutReloaded/misc/LFC-passing-tests.txt:
3956
3957 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3958
3959         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
3960         https://bugs.webkit.org/show_bug.cgi?id=192841
3961
3962         Reviewed by Carlos Garcia Campos.
3963
3964         There are separate g_assert_*() macros for use in tests, which we use inconsistently
3965         currently. Use them always. We'll get nicer error messages now when tests fail, and the
3966         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
3967
3968         Note that the documentation of g_assert() says that it is not to be used when writing tests.
3969
3970         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3971         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3972         (WebKitWebEditorTest::testSelectionChanged):
3973         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3974         (WebKitFrameTest::testMainFrame):
3975         (WebKitFrameTest::testURI):
3976         (WebKitFrameTest::testJavaScriptContext):
3977         (WebKitFrameTest::testJavaScriptValues):
3978         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3979         (testWebViewAuthenticationRequest):
3980         (testWebViewAuthenticationLoadCancelled):
3981         (testWebViewAuthenticationFailure):
3982         (testWebViewAuthenticationStorage):
3983         (ProxyAuthenticationTest::ProxyAuthenticationTest):
3984         (testWebViewAuthenticationProxy):
3985         (testWebViewAuthenticationProxyHTTPS):
3986         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3987         (testAutomationSessionRequestSession):
3988         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3989         (testBackForwardListNavigation):
3990         (testWebKitWebViewSessionState):
3991         (testWebKitWebViewSessionStateWithFormData):
3992         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3993         (ConsoleMessageTest::consoleMessageReceivedCallback):
3994         (testWebKitConsoleMessageConsoleAPI):
3995         (testWebKitConsoleMessageJavaScriptException):
3996         (testWebKitConsoleMessageNetworkError):
3997         (testWebKitConsoleMessageSecurityError):
3998         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3999         (testCookieManagerAcceptPolicy):
4000         (testCookieManagerCookiesChanged):
4001         (testCookieManagerPersistentStorage):
4002         (testCookieManagerPersistentStorageDeleteAll):
4003         (testCookieManagerEphemeral):
4004         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
4005         (testWebKitDOMElementAutoFill):
4006         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
4007         (downloadLocalFileSuccessfully):
4008         (createFileAtDestination):
4009         (testDownloadOverwriteDestinationDisallowed):
4010         (testDownloadLocalFileError):
4011         (testDownloadRemoteFile):
4012         (testDownloadRemoteFileError):
4013         (testWebViewDownloadURI):
4014         (testPolicyResponseDownload):
4015         (testPolicyResponseDownloadCancel):
4016         (testDownloadMIMEType):
4017         (contextMenuCallback):
4018         (testContextMenuDownloadActions):
4019         (testBlobDownload):
4020         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
4021         (testWebKitWebEditorSelectionChanged):
4022         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
4023         (testWebKitFrameMainFrame):
4024         (testWebKitFrameURI):
4025         (testWebKitFrameJavaScriptContext):
4026         (testWebKitFrameJavaScriptValues):
4027         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4028         (LoadStopTrackingTest::loadFailed):
4029         (testWebViewTitle):
4030         (testURIRequestHTTPHeaders):
4031         (testURIRequestHTTPMethod):
4032         (testURIResponseHTTPHeaders):
4033         (testRedirectToDataURI):
4034         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
4035         (testProcessPerWebView):
4036         (testWebProcessLimit):
4037         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
4038         (testWebViewResources):
4039         (testWebResourceLoading):
4040         (testWebResourceSuggestedFilename):
4041         (testWebResourceGetData):
4042         (testWebResourceGetDataError):
4043         (testWebViewResourcesHistoryCache):
4044         (testWebResourceSendRequest):
4045         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
4046         (testSSL):
4047         (testInsecureContent):
4048         (testTLSErrorsPolicy):
4049         (testTLSErrorsRedirect):
4050         (testTLSErrorsHTTPAuth):
4051         (testLoadFailedWithTLSErrors):
4052         (testSubresourceLoadFailedWithTLSErrors):
4053         (httpsServerCallback):
4054         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
4055         (testWebViewCreateNavigationData):
4056         (testWebViewJavaScriptDialogs):
4057         (testWebViewWindowProperties):
4058         (testWebViewMouseTarget):
4059         (testWebViewFileChooserRequest):
4060         (testWebViewColorChooserRequest):
4061         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
4062         (testWebExtensionGetTitle):
4063         (testDocumentLoadedSignal):
4064         (testWebKitWebViewProcessCrashed):
4065         (testWebExtensionWindowObjectCleared):
4066         (testWebExtensionIsolatedWorld):
4067         (permissionRequestCallback):
4068         (didAssociateFormControlsCallback):
4069         (testWebExtensionFormControlsAssociated):
4070         (FormSubmissionTest::FormSubmissionTest):
4071         (FormSubmissionTest::testFormSubmissionResult):
4072         (testWebExtensionFormSubmissionSteps):
4073         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
4074         (testNotInitialized):
4075         (testClearDatabase):
4076         (testPrivateBrowsing):
4077         (testGetFavicon):
4078         (testWebViewFavicon):
4079         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
4080         (testFindControllerTextFound):
4081         (testFindControllerTextNotFound):
4082         (testFindControllerMatchCount):
4083         (testFindControllerMaxMatchCount):
4084         (testFindControllerNext):
4085         (testFindControllerPrevious):
4086         (testFindControllerCountedMatches):
4087         (testFindControllerOptions):
4088         (testFindControllerHide):
4089         (testFindControllerInstance):
4090         (testFindControllerGetters):
4091         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
4092         (testNavigationPolicy):
4093         (testResponsePolicy):
4094         (testNewWindowPolicy):
4095         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
4096         (testSecurityOriginBasicConstructor):
4097         (testSecurityOriginURIConstructor):
4098         (testSecurityOriginDefaultPort):
4099         (testSecurityOriginFileURI):
4100         (testOpaqueSecurityOrigin):
4101         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
4102         (testWebKitSettings):
4103         (testWebKitSettingsNewWithSettings):
4104         (testWebKitSettingsUserAgent):
4105         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4106         (testWebViewNewWithUserContentManager):
4107         (isStyleSheetInjectedForURLAtPath):
4108         (isScriptInjectedForURLAtPath):
4109         (testUserContentManagerInjectedStyleSheet):
4110         (testUserContentManagerInjectedScript):
4111         (UserScriptMessageTest::scriptMessageReceived):
4112         (UserScriptMessageTest::waitUntilMessageReceived):
4113         (UserScriptMessageTest::runJavaScriptFinished):
4114         (testUserContentManagerScriptMessageReceived):
4115         (testUserContentManagerScriptMessageInWorldReceived):
4116         (testUserContentManagerScriptMessageFromDOMBindings):
4117         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
4118         (testWebContextDefault):
4119         (testWebContextEphemeral):
4120         (testWebContextGetPlugins):
4121         (testWebContextURIScheme):
4122         (testWebContextSpellChecker):
4123         (testWebContextLanguages):
4124         (consoleMessageReceivedCallback):
4125         (testWebContextSecurityFileXHR):
4126         (ProxyTest::ProxyTest):
4127         (testWebContextProxySettings):
4128         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4129         (testWebViewWebContext):
4130         (testWebViewWebBackend):
4131         (testWebViewEphemeral):
4132         (testWebViewCustomCharset):
4133         (testWebViewSettings):
4134         (testWebViewRunJavaScript):
4135         (testWebViewCanShowMIMEType):
4136         (testWebViewSubmitForm):
4137         (testWebViewSave):
4138         (testWebViewPageVisibility):
4139         (testWebViewSnapshot):
4140         (testWebViewNotification):
4141         (testWebViewNotificationInitialPermissionAllowed):
4142         (testWebViewNotificationInitialPermissionDisallowed):
4143         (testWebViewIsPlayingAudio):
4144         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
4145         (WebsiteDataTest::WebsiteDataTest):
4146         (WebsiteDataTest::remove):
4147         (WebsiteDataTest::clear):
4148         (testWebsiteDataConfiguration):
4149         (testWebsiteDataEphemeral):
4150         (testWebsiteDataCache):
4151         (testWebsiteDataStorage):
4152         (testWebsiteDataDatabases):
4153         (testWebsiteDataAppcache):
4154         (testWebsiteDataCookies):
4155         (testWebsiteDataDeviceIdHashSalt):
4156         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
4157         (emitDocumentLoaded):
4158         (emitURIChanged):
4159         (sendRequestCallback):
4160         (contextMenuCallback):
4161         (consoleMessageSentCallback):
4162         (emitFormControlsAssociated):
4163         (formControlsAssociatedCallback):
4164         (emitFormSubmissionEvent):
4165         (willSubmitFormCallback):
4166         (windowObjectCleared):
4167         (methodCallCallback):
4168         (registerGResource):
4169         (webkit_web_extension_initialize_with_user_data):
4170         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
4171         (checkLeaks):
4172         (WebProcessTest::create):
4173         (runTest):
4174         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
4175         (AutocleanupsTest::testWebProcessAutocleanups):
4176         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
4177         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
4178         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
4179         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
4180         (WebKitDOMDOMWindowTest::testSignals):
4181         (WebKitDOMDOMWindowTest::testDispatchEvent):
4182         (WebKitDOMDOMWindowTest::testGetComputedStyle):
4183         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
4184         (WebKitDOMNodeFilterTest::testTreeWalker):
4185         (WebKitDOMNodeFilterTest::testNodeIterator):
4186         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
4187         (WebKitDOMNodeTest::testHierarchyNavigation):
4188         (WebKitDOMNodeTest::testInsertion):
4189         (WebKitDOMNodeTest::testTagNamesNodeList):
4190         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
4191         (WebKitDOMNodeTest::testDOMCache):
4192         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
4193         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
4194         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
4195         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
4196         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
4197         (testUIProcessAutocleanups):
4198         (testWebProcessAutocleanups):
4199         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
4200         (testContextMenuPopulateMenu):
4201         (testContextMenuDismissed):
4202         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
4203         (testWebKitDOMClientRectDivBoundingClientRectPosition):
4204         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
4205         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
4206         (testWebKitDOMDOMWindowSignals):
4207         (testWebKitDOMDOMWindowDispatchEvent):
4208         (testWebKitDOMDOMWindowGetComputedStyle):
4209         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
4210         (testWebKitDOMNodeHierarchyNavigation):
4211         (testWebKitDOMNodeInsertion):
4212         (testWebKitDOMNodeTagNamesNodeList):
4213         (testWebKitDOMNodeTagNamesHTMLCollection):
4214         (testWebKitDOMObjectCache):
4215         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
4216         (testWebKitDOMNodeFilterTreeWalker):
4217         (testWebKitDOMNodeFilterNodeIterator):
4218         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
4219         (testWebKitDOMXPathNSResolverNative):
4220         (testWebKitDOMXPathNSResolverCustom):
4221         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
4222         (testInspectorDefault):
4223         (testInspectorManualAttachDetach):
4224         (testInspectorCustomContainerDestroyed):
4225         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
4226         (startTestServer):
4227         (testInspectorServerPageList):
4228         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
4229         (OptionMenuTest::showOptionMenuCallback):
4230         (OptionMenuTest::menuCloseCallback):
4231         (OptionMenuTest::close):
4232         (OptionMenuTest::activateItem):
4233         (OptionMenuTest::selectItem):
4234         (testOptionMenuSimple):
4235         (testOptionMenuGroups):
4236         (testOptionMenuActivate):
4237         (testOptionMenuSelect):
4238         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
4239         (testPrintOperationPrintSettings):
4240         (webViewPrintCallback):
4241         (testPrintOperationPrint):
4242         (testPrintCustomWidget):
4243         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
4244         (checkAtspiAccessible):
4245         (testAtspiBasicHierarchy):
4246         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
4247         (testWebKitCheckVersion):
4248         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
4249         (testWebViewEditorCutCopyPasteNonEditable):
4250         (testWebViewEditorCutCopyPasteEditable):
4251         (testWebViewEditorSelectAllNonEditable):
4252         (testWebViewEditorSelectAllEditable):
4253         (loadContentsAndTryToCutSelection):
4254         (testWebViewEditorNonEditable):
4255         (testWebViewEditorEditable):
4256         (testWebViewEditorEditorStateTypingAttributes):
4257         (testWebViewEditorInsertImage):
4258         (testWebViewEditorCreateLink):
4259         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
4260         (loadChangedCallback):
4261         (loadFailedCallback):
4262         (loadFailedWithTLSErrorsCallback):
4263         (LoadTrackingTest::LoadTrackingTest):
4264         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4265         (registerGResource):
4266         (removeNonEmptyDirectory):
4267         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4268         (Test::adoptView):
4269         (Test::~Test):
4270         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4271         (WebKitTestBus::getOrCreateConnection):
4272         (WebKitTestBus::createProxy):
4273         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
4274         (WebKitTestServer::getWebSocketURIForPath const):
4275         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
4276         (WebViewTest::initializeWebView):
4277         (WebViewTest::loadURI):
4278         (WebViewTest::loadHtml):
4279         (WebViewTest::loadPlainText):
4280         (WebViewTest::loadBytes):
4281         (WebViewTest::loadRequest):
4282         (WebViewTest::loadAlternateHTML):
4283         (WebViewTest::goBack):
4284         (WebViewTest::goForward):
4285         (WebViewTest::goToBackForwardListItem):
4286         (resourceGetDataCallback):
4287         (WebViewTest::mainResourceData):
4288         (WebViewTest::javascriptResultToCString):
4289         (WebViewTest::javascriptResultToNumber):
4290         (WebViewTest::javascriptResultToBoolean):
4291         (WebViewTest::javascriptResultIsNull):
4292         (WebViewTest::javascriptResultIsUndefined):
4293         (onSnapshotReady):
4294         (WebViewTest::runWebProcessTest):
4295         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
4296         (WebViewTest::platformInitializeWebView):
4297         (WebViewTest::showInWindow):
4298         (WebViewTest::showInWindowAndWaitUntilMapped):
4299         (WebViewTest::mouseMoveTo):
4300         (WebViewTest::emitPopupMenuSignal):
4301         (WebViewTest::keyStroke):
4302         (WebViewTest::doMouseButtonEvent):
4303
4304 2019-01-09  Philippe Normand  <pnormand@igalia.com>
4305
4306         [WPE] API tests can't run in flatpak environment
4307         https://bugs.webkit.org/show_bug.cgi?id=193242
4308
4309         Reviewed by Michael Catanzaro.
4310
4311         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
4312         flatpakutils so that it knows which port it's dealing with.
4313         * glib/common.py: Remove build_dir globals so that subsequent
4314         calls actually take args into account.
4315         (library_build_path):
4316         (binary_build_path):
4317
4318 2019-01-08  Dean Jackson  <dino@apple.com>
4319
4320         Blob references for System Previews don't get a correct file extension
4321         https://bugs.webkit.org/show_bug.cgi?id=193268
4322         <rdar://problem/47133037>
4323
4324         Reviewed by Tim Horton.
4325
4326         New test that a Blob download of a USDZ file gets named correctly.
4327
4328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: