Close service worker database on network process suspension
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-09  Youenn Fablet  <youenn@apple.com>
2
3         Close service worker database on network process suspension
4         https://bugs.webkit.org/show_bug.cgi?id=196623
5         <rdar://problem/48930869>
6
7         Reviewed by Alex Christensen.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
10
11 2019-04-09  Daniel Bates  <dabates@apple.com>
12
13         [iPad] Should open popover when the spacebar is pressed
14         https://bugs.webkit.org/show_bug.cgi?id=196360
15         <rdar://problem/49389129>
16
17         Reviewed by Brent Fulgham.
18
19         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
20
21         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
22         (WTR::UIScriptController::isShowingPopover const): Added.
23         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
24         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
25         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
26         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
27         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
28         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
29         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
30         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
31         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
32         (WTR::UIScriptController::isShowingPopover const): Added.
33         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
34         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
35         * TestRunnerShared/UIScriptContext/UIScriptController.h:
36         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
37         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
38         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
39         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
40         (-[TestRunnerWKWebView _willPresentPopover]): Added.
41         (-[TestRunnerWKWebView _didDismissPopover]): Added.
42         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
43         (WTR::UIScriptController::isShowingPopover const): Added.
44         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
45         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
46
47 2019-04-09  Alex Christensen  <achristensen@webkit.org>
48
49         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
50         https://bugs.webkit.org/show_bug.cgi?id=196665
51         <rdar://45115669>
52
53         Reviewed by Geoff Garen.
54
55         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
56         (goBack):
57         (+[SimpleLookupContext sharedLookupContext]):
58         (-[SimpleLookupContext lookUpURL:completionHandler:]):
59         (TEST):
60         (+[Simple3LookupContext sharedLookupContext]): Deleted.
61         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
62
63 2019-04-09  John Wilander  <wilander@apple.com>
64
65         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
66         https://bugs.webkit.org/show_bug.cgi?id=196558
67         <rdar://problem/47650245>
68
69         Reviewed by Youenn Fablet.
70
71         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
72         (TestWebKitAPI::TEST):
73             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
74
75 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
76
77         [CMake] Apple builds should use ICU_INCLUDE_DIRS
78         https://bugs.webkit.org/show_bug.cgi?id=196720
79
80         Reviewed by Konstantin Tokarev.
81
82         * TestWebKitAPI/PlatformMac.cmake:
83
84 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
85
86         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
87         https://bugs.webkit.org/show_bug.cgi?id=196694
88         <rdar://problem/48388734>
89
90         Rubber-stamped by Aakash Jain.
91
92         * Scripts/webkitpy/port/image_diff.py:
93         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
94         * Scripts/webkitpy/port/server_process.py:
95         (ServerProcess.has_available_stdout): Check if stdout has data in it.
96         (ServerProcess._wait_for_data_and_update_buffers_using_select):
97         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
98         * Scripts/webkitpy/port/server_process_mock.py:
99         (MockServerProcess.has_available_stdout):
100         * Scripts/webkitpy/port/server_process_unittest.py:
101         (TestServerProcess.serial_test_basic):
102
103 2019-04-09  Jer Noble  <jer.noble@apple.com>
104
105         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
106         https://bugs.webkit.org/show_bug.cgi?id=196097
107
108         Reviewed by Eric Carlson.
109
110         Drive-by bug fix: allow tests to play audio without a user gesture by default.
111
112         * DumpRenderTree/mac/DumpRenderTree.mm:
113         (resetWebPreferencesToConsistentValues):
114         * WebKitTestRunner/TestController.cpp:
115         (WTR::TestController::resetPreferencesToConsistentValues):
116
117 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
118
119         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
120         https://bugs.webkit.org/show_bug.cgi?id=196690
121
122         Reviewed by Michael Catanzaro.
123
124         * QueueStatusServer/config/queues.py:
125         * Scripts/webkitpy/common/config/ews.json:
126         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
127         (test_ews_name):
128
129 2019-04-09  Chris Dumez  <cdumez@apple.com>
130
131         Loads using loadHTMLString() cause flashing when process-swapping
132         https://bugs.webkit.org/show_bug.cgi?id=196714
133         <rdar://problem/49637354>
134
135         Reviewed by Antti Koivisto.
136
137         Add API test coverage.
138
139         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
140
141 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
142
143         Unreviewed. Fix ATK accessibility tests after r244059.
144
145         We are failing to load the injected bundle due to undefined symbol
146         AccessibilityUIElement::replaceTextInRange().
147
148         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
149         (WTR::AccessibilityUIElement::replaceTextInRange):
150
151 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
152
153         AX: Support API: accessibilityReplaceRange:withText
154         https://bugs.webkit.org/show_bug.cgi?id=196636
155
156         Unreviewed build fix for Windows port.
157
158         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
159         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
160
161 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
162
163         [CMake][WinCairo] Separate copied headers into different directories
164         https://bugs.webkit.org/show_bug.cgi?id=196655
165
166         Reviewed by Michael Catanzaro.
167
168         * DumpRenderTree/CMakeLists.txt:
169         * MiniBrowser/win/CMakeLists.txt:
170         * TestWebKitAPI/CMakeLists.txt:
171         * TestWebKitAPI/PlatformWin.cmake:
172
173 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
174
175         Log stack-trace for run-webkit-tests when interrupted
176         https://bugs.webkit.org/show_bug.cgi?id=176393
177         <rdar://problem/34262310>
178
179         Reviewed by Lucas Forschler.
180
181         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
182         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
183         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
184         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
185         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
186         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
187         (main): Set handlers to log stack trace on interruption.
188
189 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
190
191         AX: Support API: accessibilityReplaceRange:withText
192         https://bugs.webkit.org/show_bug.cgi?id=196636
193
194         Unreviewed build fix for Windows port.
195
196         * DumpRenderTree/AccessibilityUIElement.cpp:
197         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
198
199 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
200
201         [ews-build] Scripts using Buildbot API have CORS error
202         https://bugs.webkit.org/show_bug.cgi?id=196709
203
204         Reviewed by Alexey Proskuryakov.
205
206         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
207
208 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
209
210         AX: Support API: accessibilityReplaceRange:withText
211         https://bugs.webkit.org/show_bug.cgi?id=196636
212
213         Reviewed by Daniel Bates.
214
215         * DumpRenderTree/AccessibilityUIElement.cpp:
216         (replaceTextInRangeCallback):
217         (AccessibilityUIElement::replaceTextInRange):
218         (AccessibilityUIElement::getJSClass):
219         * DumpRenderTree/AccessibilityUIElement.h:
220         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
221         (AccessibilityUIElement::replaceTextInRange):
222         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
223         (AccessibilityUIElement::replaceTextInRange):
224         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
225         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
226         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
227         (WTR::AccessibilityUIElement::replaceTextInRange):
228         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
229         (WTR::AccessibilityUIElement::replaceTextInRange):
230
231 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
232
233         [iOS] Do not allow starting selection drags when selection views are not visible
234         https://bugs.webkit.org/show_bug.cgi?id=196686
235         <rdar://problem/49399192>
236
237         Reviewed by Tim Horton.
238
239         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
240         also add some new API tests to cover scenarios where the web view is not first responder.
241
242         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
243         (TestWebKitAPI::TEST):
244         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
245
246         Add a switch to optionally make the web view first responder when starting the simulated drag.
247
248         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
249         (-[DragAndDropSimulator initWithWebView:]):
250         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
251
252 2019-04-08  Justin Fan  <justin_fan@apple.com>
253
254         [Web GPU] Fix Web GPU experimental feature on iOS
255         https://bugs.webkit.org/show_bug.cgi?id=196632
256
257         Reviewed by Myles C. Maxfield.
258
259         Properly make Web GPU available on iOS 11+.
260
261         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
262
263 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
264
265         [ews-build] Do not upload archive when Compile Fails
266         https://bugs.webkit.org/show_bug.cgi?id=196674
267
268         Reviewed by Alexey Proskuryakov.
269
270         * BuildSlaveSupport/ews-build/factories.py:
271         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
272         * BuildSlaveSupport/ews-build/steps.py:
273         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
274         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
275         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
276
277 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
278
279         Enable DFG on MIPS
280         https://bugs.webkit.org/show_bug.cgi?id=196689
281
282         Reviewed by Žan Doberšek.
283
284         Since the bytecode change, we enabled the baseline JIT on mips in
285         r240432, but DFG is still missing. With this change, all tests are
286         passing on a ci20 board.
287
288         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
289
290 2019-04-08  Philippe Normand  <pnormand@igalia.com>
291
292         [Flatpak] Second run update-webkitwpe-flatpak fails
293         https://bugs.webkit.org/show_bug.cgi?id=192702
294
295         Reviewed by Carlos Garcia Campos.
296
297         * flatpak/flatpakutils.py:
298         (FlatpakObject.flatpak): Fix typo.
299         (FlatpakPackage.install): When installing, also update to the configured remote commit.
300         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
301
302 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
303
304         [GTK][WPE] outlook.live.com displays old-fashioned UI
305         https://bugs.webkit.org/show_bug.cgi?id=196642
306
307         Reviewed by Carlos Garcia Campos.
308
309         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
310         (TestWebKitAPI::TEST): New Mac platform quirk test.
311
312 2019-04-07  Commit Queue  <commit-queue@webkit.org>
313
314         Unreviewed, rolling out r243956.
315         https://bugs.webkit.org/show_bug.cgi?id=196688
316
317         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
318         by aakashjain on #webkit).
319
320         Reverted changeset:
321
322         "Clicking "Go Back" from a safe browsing warning from an
323         iframe should navigate the WKWebView back to the previous
324         page"
325         https://bugs.webkit.org/show_bug.cgi?id=196665
326         https://trac.webkit.org/changeset/243956
327
328 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
329
330         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
331         https://bugs.webkit.org/show_bug.cgi?id=196669
332
333         Reviewed by Geoffrey Garen.
334
335         Added three new unit tests for WeakHashSet.
336
337         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
338         (WTF_WeakPtr.WeakHashSetConstObjects):
339         (WTF_WeakPtr.WeakHashSetComputesEmpty):
340         (WTF_WeakPtr.WeakHashSetComputeSize):
341
342 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
343
344         Hide next and previous form control buttons when WKWebView is editable
345         https://bugs.webkit.org/show_bug.cgi?id=196672
346         <rdar://problem/35625321>
347
348         Reviewed by Tim Horton.
349
350         Add a new API test.
351
352         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
353         (-[TestWKWebView lastTrailingBarButtonGroup]):
354         (TestWebKitAPI::TEST):
355         * TestWebKitAPI/ios/UIKitSPI.h:
356
357 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
358
359         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
360         https://bugs.webkit.org/show_bug.cgi?id=196077
361         <rdar://problem/49108202>
362
363         Reviewed by Chris Dumez.
364
365         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
366         on new web view.
367
368         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
369
370 2019-04-05  Saam Barati  <sbarati@apple.com>
371
372         Make compare-results understand MotionMark
373         https://bugs.webkit.org/show_bug.cgi?id=196666
374
375         Reviewed by Yusuke Suzuki.
376
377         * Scripts/compare-results:
378         (PLT5Results):
379         (detectMotionMark):
380         (detectMotionMark1_1):
381         (motionMarkResults):
382         (motionMark1_1Results):
383         (detectBenchmark):
384         (biggerIsBetter):
385         (main):
386
387 2019-04-05  Alex Christensen  <achristensen@webkit.org>
388
389         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
390         https://bugs.webkit.org/show_bug.cgi?id=196665
391         <rdar://45115669>
392
393         Reviewed by Geoff Garen.
394
395         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
396         (goBack):
397         (+[SimpleLookupContext sharedLookupContext]):
398         (-[SimpleLookupContext lookUpURL:completionHandler:]):
399         (TEST):
400         (+[Simple3LookupContext sharedLookupContext]): Deleted.
401         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
402
403 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
404
405         [ews-build] Add configuration and architecture for windows builders
406         https://bugs.webkit.org/show_bug.cgi?id=196660
407
408         Reviewed by Lucas Forschler.
409
410         * BuildSlaveSupport/ews-build/config.json:
411
412 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
413
414         webkitpy: Don't run subsequent rounds if interrupted
415         https://bugs.webkit.org/show_bug.cgi?id=196646
416
417         Reviewed by Aakash Jain.
418
419         * Scripts/webkitpy/layout_tests/controllers/manager.py:
420         (Manager.run): Bail out if interrupted.
421
422 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
423
424         Test sessionStorage in PSON private browsing mode
425         https://bugs.webkit.org/show_bug.cgi?id=196561
426
427         Reviewed by Alex Christensen.
428
429         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
430
431 2019-04-05  Commit Queue  <commit-queue@webkit.org>
432
433         Unreviewed, rolling out r243833.
434         https://bugs.webkit.org/show_bug.cgi?id=196645
435
436         This change breaks build of WPE and GTK ports (Requested by
437         annulen on #webkit).
438
439         Reverted changeset:
440
441         "[CMake][WTF] Mirror XCode header directories"
442         https://bugs.webkit.org/show_bug.cgi?id=191662
443         https://trac.webkit.org/changeset/243833
444
445 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
446
447         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
448         https://bugs.webkit.org/show_bug.cgi?id=196635
449
450         Reviewed by Antti Koivisto.
451         
452         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
453         for a test to enable async frame scrolling via:
454             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
455         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
456         
457         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
458
459         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
460         (WTR::InjectedBundle::beginTesting):
461         * WebKitTestRunner/TestController.cpp:
462         (WTR::TestController::resetPreferencesToConsistentValues):
463
464 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
465
466         Use a correct LC_RPATH when building with ASan
467         https://bugs.webkit.org/show_bug.cgi?id=196576
468
469         Reviewed by David Kilzer.
470
471         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
472         so that ../Frameworks is checked. This is simpler and more reliable than updating
473         each SPC service xcconfig.
474
475 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
476
477         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
478         https://bugs.webkit.org/show_bug.cgi?id=196629
479
480         Reviewed by Lucas Forschler.
481
482         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
483
484 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
485
486         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
487         https://bugs.webkit.org/show_bug.cgi?id=196618
488
489         Reviewed by Lucas Forschler.
490
491         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
492         (StatusBubble): Added QUEUE_TRIGGERS.
493         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
494         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
495         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
496         its parent(builder).
497
498 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
499
500         [ews-app] Status-bubble steps are sometimes displayed in reverse order
501         https://bugs.webkit.org/show_bug.cgi?id=196625
502
503         Reviewed by Lucas Forschler.
504
505         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
506         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
507
508 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
509
510         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
511         https://bugs.webkit.org/show_bug.cgi?id=196630
512
513         Reviewed by Wenson Hsieh.
514
515         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
516
517 2019-04-04  Youenn Fablet  <youenn@apple.com>
518
519         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
520         https://bugs.webkit.org/show_bug.cgi?id=196543
521
522         Reviewed by Alex Christensen.
523
524         * WebKitTestRunner/TestController.cpp:
525         (WTR::TestController::generatePageConfiguration):
526
527 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
528
529         [ews-app] Status bubble should not display skipped buildbot steps
530         https://bugs.webkit.org/show_bug.cgi?id=196584
531
532         Reviewed by Lucas Forschler.
533
534         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
535
536 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
537
538         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
539         https://bugs.webkit.org/show_bug.cgi?id=196620
540
541         Reviewed by Lucas Forschler.
542
543         * BuildSlaveSupport/ews-app/ews/config.py:
544
545 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
546
547         [Win] DumpRenderTreeWatchDog.py is not checked into source
548         https://bugs.webkit.org/show_bug.cgi?id=196567
549         <rdar://problem/49525901>
550
551         Reviewed by Lucas Forschler.
552
553         This script is used on Win EWS bots to terminate hanging DRT processes.
554
555         * EWSTools/dumprendertreewatchdog.py: Added.
556
557 2019-04-04  Chris Dumez  <cdumez@apple.com>
558
559         Unreviewed, roll out r243858 which made tests time out.
560
561         Disable new API tests on Windows instead.
562
563         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
564         (TestWebKitAPI::TEST):
565
566 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
567
568         [ATK] Cleanup WebPageAccessibilityObjectAtk
569         https://bugs.webkit.org/show_bug.cgi?id=196537
570
571         Reviewed by Michael Catanzaro.
572
573         Also consider files under atk directories as exceptions for GObject conventions.
574
575         * Scripts/webkitpy/style/checkers/cpp.py:
576         (check_identifier_name_in_declaration):
577
578 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
579
580         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
581         https://bugs.webkit.org/show_bug.cgi?id=196588
582         <rdar://problem/49365787>
583
584         Unreviewed build fix for Windows port.
585
586         error C3861: 'kill': identifier not found
587
588         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
589         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
590
591 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
592
593         [ews-build] Cancel build and similar operations should have authentication
594         https://bugs.webkit.org/show_bug.cgi?id=196520
595
596         Reviewed by Dewei Zhu.
597
598         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
599         environment variables.
600
601 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
602
603         [ews-build] Do not trigger queues which are not in production yet
604         https://bugs.webkit.org/show_bug.cgi?id=196581
605
606         Reviewed by Dewei Zhu.
607
608         * BuildSlaveSupport/ews-build/config.json:
609
610 2019-04-03  Chris Dumez  <cdumez@apple.com>
611
612         Unreviewed, fix typo in the name of API test added in r243848.
613
614         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
615         (TestWebKitAPI::TEST):
616
617 2019-04-03  Chris Dumez  <cdumez@apple.com>
618
619         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
620         https://bugs.webkit.org/show_bug.cgi?id=196588
621         <rdar://problem/49365787>
622
623         Reviewed by Ryosuke Niwa.
624
625         Add API test coverage.
626
627         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
628         (TestWebKitAPI::nullJavaScriptCallback):
629         (TestWebKitAPI::didCrashCheckFrames):
630         (TestWebKitAPI::TEST):
631
632 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
633
634         run-webkit-tests: Upload test results (new results database)
635         https://bugs.webkit.org/show_bug.cgi?id=196577
636         <rdar://problem/34841155>
637
638         Reviewed by Lucas Forschler.
639
640         * Scripts/webkitpy/layout_tests/controllers/manager.py:
641         (Manager.run): Upload results after each device shard, since the configuration will be
642         different for each device.
643         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
644         uploaded to a results database.
645         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
646         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
647
648 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
649
650         -apple-trailing-word is needed for browser detection
651         https://bugs.webkit.org/show_bug.cgi?id=196575
652
653         Unreviewed.
654
655         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
656
657 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
658
659         [CMake][WTF] Mirror XCode header directories
660         https://bugs.webkit.org/show_bug.cgi?id=191662
661
662         Reviewed by Konstantin Tokarev.
663
664         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
665         builds.
666
667         * CMakeLists.txt:
668         * DumpRenderTree/CMakeLists.txt:
669         * DumpRenderTree/PlatformWin.cmake:
670         * MiniBrowser/win/CMakeLists.txt:
671         * TestWebKitAPI/CMakeLists.txt:
672         * TestWebKitAPI/PlatformWin.cmake:
673         * WebKitTestRunner/PlatformGTK.cmake:
674         * WebKitTestRunner/PlatformWin.cmake:
675
676 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
677
678         [ews-app] Status bubble should not display certain infrastructure status messages
679         https://bugs.webkit.org/show_bug.cgi?id=196550
680
681         Reviewed by Lucas Forschler.
682
683         Do not display the steps which are un-needed for end-user. This information is still avaiable
684         if the user click on the bubble and look at the Buildbot build.
685         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
686         (StatusBubble._steps_messages):
687         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
688
689 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
690
691         [ews-build] Use https for sending data to ews-app
692         https://bugs.webkit.org/show_bug.cgi?id=196492
693
694         Reviewed by Lucas Forschler.
695
696         * BuildSlaveSupport/ews-build/events.py:
697
698 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
699
700         Remove support for -apple-trailing-word
701         https://bugs.webkit.org/show_bug.cgi?id=196525
702
703         Reviewed by Zalan Bujtas.
704
705         This CSS property is nonstandard and not used.
706
707         * Scripts/webkitperl/FeatureList.pm:
708         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
709
710 2019-04-03  Youenn Fablet  <youenn@apple.com>
711
712         Add a test for DOMCache on multiple browsing in case of private browsing
713         https://bugs.webkit.org/show_bug.cgi?id=196524
714
715         Reviewed by Alex Christensen.
716
717         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
718         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
719
720 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
721
722         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
723         https://bugs.webkit.org/show_bug.cgi?id=196540
724
725         Reviewed by Aakash Jain.
726
727         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
728
729 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
730
731         Add plumbing for a compatibility mode preference in WebKit
732         https://bugs.webkit.org/show_bug.cgi?id=196005
733
734         Reviewed by Tim Horton.
735
736         Add new API tests.
737
738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
739         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
740
741 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
742
743         [WPE][GTK] Update libsrtp dependency package for Debian
744         https://bugs.webkit.org/show_bug.cgi?id=196528
745
746         Reviewed by Frédéric Wang.
747
748         * gtk/install-dependencies:
749         * wpe/install-dependencies:
750
751 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
752
753         [WK2] Add support for Window's beforeprint / afterprint events
754         https://bugs.webkit.org/show_bug.cgi?id=196478
755         <rdar://problem/49535124>
756
757         Unreviewed build fix for MSVC.
758
759         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
760
761         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
762
763         * WebKitTestRunner/TestController.cpp:
764         (WTR::printFrame): Use int and float literals.
765
766 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
767
768         [ews-build] Reassign bots to queues
769
770         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
771
772 2019-04-02  Chris Dumez  <cdumez@apple.com>
773
774         [WK2] Add support for Window's beforeprint / afterprint events
775         https://bugs.webkit.org/show_bug.cgi?id=196478
776
777         Reviewed by Alex Christensen.
778
779         Add minimal implementation for printFrame in WebKitTestRunner.
780
781         * WebKitTestRunner/TestController.cpp:
782         (WTR::printFrame):
783         (WTR::TestController::createOtherPage):
784         (WTR::TestController::createWebViewWithOptions):
785
786 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
787
788         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
789         https://bugs.webkit.org/show_bug.cgi?id=196491
790
791         Reviewed by Lucas Forschler.
792
793         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
794
795 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
796
797         [ews-build] Configure buildbot try credentials in environment variables
798         https://bugs.webkit.org/show_bug.cgi?id=196501
799
800         Reviewed by Lucas Forschler.
801
802         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
803         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
804         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
805
806 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
807
808         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
809         https://bugs.webkit.org/show_bug.cgi?id=196496
810         <rdar://problem/49521634>
811
812         Reviewed by Chris Dumez.
813
814         Add new API tests (see WebKit ChangeLog for more detail).
815
816         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
817         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
818         (TEST):
819
820 2019-04-02  David Kilzer  <ddkilzer@apple.com>
821
822         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
823         <https://webkit.org/b/196499>
824
825         Reviewed by Alexey Proskuryakov.
826
827         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
828         ENABLE_ADDRESS_SANITIZER.
829
830 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
831
832         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
833         https://bugs.webkit.org/show_bug.cgi?id=182757
834
835         Reviewed by Don Olmstead.
836
837         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
838         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
839
840 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
841
842         run-api-tests: Upload test results
843         https://bugs.webkit.org/show_bug.cgi?id=196323
844         <rdar://problem/49356714>
845
846         Reviewed by Lucas Forschler.
847
848         * Scripts/webkitpy/api_tests/manager.py:
849         (Manager):
850         (Manager.run): Upload results to a results database.
851         * Scripts/webkitpy/api_tests/run_api_tests.py:
852         (parse_args): Add upload arguments.
853         * Scripts/webkitpy/port/base.py:
854         (Port):
855         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
856         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
857         with commits from any other associated repositories.
858         * Scripts/webkitpy/port/device.py:
859         (Device):
860         (Device.build_version): Access build_versoin of underlying platform device.
861         * Scripts/webkitpy/port/ios_simulator_unittest.py:
862         (IOSSimulatorTest):
863         (IOSSimulatorTest.test_configuration_for_upload):
864         * Scripts/webkitpy/port/device_port.py:
865         (DevicePort):
866         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
867         the same as the machine uploading results.
868         * Scripts/webkitpy/port/mac.py:
869         (MacPort):
870         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
871         * Scripts/webkitpy/port/mac_unittest.py:
872         (MacTest):
873         (MacTest.test_configuration_for_upload):
874         * Scripts/webkitpy/xcode/simulated_device.py:
875         (SimulatedDeviceManager._create_device_with_runtime):
876         (SimulatedDevice.__init__): Create simulated device with a build_version.
877         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
878         (test_existing_simulator):
879
880 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
881
882         Remove extra newline characters (Follow-up fix to r243707)
883
884         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
885
886 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
887
888         [ews-app] Use API_KEY to accept results data
889         https://bugs.webkit.org/show_bug.cgi?id=196461
890
891         Reviewed by Dewei Zhu.
892
893         * BuildSlaveSupport/ews-app/ews/views/results.py:
894         (Results.post): Validate EWS_API_KEY before accepting any data.
895         * BuildSlaveSupport/ews-build/events.py:
896         (Events.sendData): Send EWS_API_KEY if available along with event data.
897
898 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
899
900         Unable to copy and paste a PDF from Notes into Mail compose body
901         https://bugs.webkit.org/show_bug.cgi?id=196442
902         <rdar://problem/48573098>
903
904         Reviewed by Tim Horton.
905
906         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
907         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
908         to be specified on the item providers.
909
910         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
911         (TestWebKitAPI::mapItemForTesting):
912         (TestWebKitAPI::contactItemForTesting):
913
914 2019-04-01  Tim Horton  <timothy_horton@apple.com>
915
916         Make UIWKDocumentContext rects per-character instead of per-word
917         https://bugs.webkit.org/show_bug.cgi?id=196459
918
919         Reviewed by Wenson Hsieh.
920
921         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
922         (TEST):
923         Adjust test results due to switching to per-character rects.
924
925 2019-04-01  Chris Dumez  <cdumez@apple.com>
926
927         UIProcess crash when a prewarmed process is terminated
928         https://bugs.webkit.org/show_bug.cgi?id=196451
929         <rdar://problem/49245471>
930
931         Reviewed by Geoffrey Garen.
932
933         Add API test coverage.
934
935         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
936         (TEST):
937
938 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
939
940         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
941         https://bugs.webkit.org/show_bug.cgi?id=196449
942
943         Reviewed by Lucas Forschler.
944
945         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
946         (StatusBubble.get_os_details): Method to get OS and Xcode details.
947         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
948         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
949
950 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
951
952         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
953         https://bugs.webkit.org/show_bug.cgi?id=196444
954
955         Reviewed by Lucas Forschler.
956
957         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
958
959 2019-04-01  Alex Christensen  <achristensen@webkit.org>
960
961         Add SPI to canonicalize NSURLs with WTF::URL
962         https://bugs.webkit.org/show_bug.cgi?id=196415
963         <rdar://problem/44980271>
964
965         Reviewed by Darin Adler.
966
967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
968         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
969         (TestWebKitAPI::TEST):
970
971 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
972
973         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
974         https://bugs.webkit.org/show_bug.cgi?id=196441
975
976         Reviewed by Carlos Garcia Campos.
977
978         Don't cache the wpe_view_backend object that might not exist yet at the
979         time of EventSenderProxy constructor invocation, but instead retrieve
980         that object whenever it's required for event dispatching. This should
981         avoid crashes in this constructor now that it's invoked before any
982         PlatformWindow has been set up (as changed in r243496).
983
984         * WebKitTestRunner/EventSenderProxy.h:
985         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
986         (WTR::viewBackend):
987         (WTR::EventSenderProxy::EventSenderProxy):
988         (WTR::EventSenderProxy::mouseDown):
989         (WTR::EventSenderProxy::mouseUp):
990         (WTR::EventSenderProxy::mouseMoveTo):
991         (WTR::EventSenderProxy::mouseScrollBy):
992         (WTR::EventSenderProxy::keyDown):
993         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
994
995 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
996
997         [Win][WebKit] MiniBrowser should support high DPI display
998         https://bugs.webkit.org/show_bug.cgi?id=196391
999
1000         Reviewed by Alex Christensen.
1001
1002         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1003         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1004         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1005         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1006
1007 2019-03-31  Sam Weinig  <weinig@apple.com>
1008
1009         Remove more i386 specific configurations
1010         https://bugs.webkit.org/show_bug.cgi?id=196430
1011
1012         Reviewed by Alexey Proskuryakov.
1013
1014         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1015         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1016
1017 2019-03-31  Andy Estes  <aestes@apple.com>
1018
1019         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1020         https://bugs.webkit.org/show_bug.cgi?id=196433
1021         <rdar://problem/49293305>
1022
1023         Reviewed by Tim Horton.
1024
1025         Enhanced API test coverage to include all navigation response policy decisions in both
1026         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1027
1028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1029         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1030         (TestWebKitAPI::TEST):
1031         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1032         (readFile):
1033         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1034         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1035         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1036         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1037         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1038         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1039         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1040         (-[QuickLookDelegate _downloadDidStart:]):
1041         (-[QuickLookDelegate _download:didReceiveResponse:]):
1042         (-[QuickLookDelegate _download:didReceiveData:]):
1043         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1044         (-[QuickLookDelegate _downloadDidFinish:]):
1045         (-[QuickLookDelegate _download:didFailWithError:]):
1046         (-[QuickLookDelegate _downloadDidCancel:]):
1047         (-[QuickLookDelegate verifyDownload]):
1048         (runTest):
1049         (runTestDecideBeforeLoading):
1050         (runTestDecideAfterLoading):
1051         (TEST):
1052         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1053         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1054         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1055         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1056         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1057         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1058         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1059         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1060         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1061         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1062         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1063         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1064         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1065         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1066
1067 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1068
1069         [CMake] add testdfg as target with build-jsc
1070         https://bugs.webkit.org/show_bug.cgi?id=196393
1071
1072         Reviewed by Saam Barati.
1073
1074         Added testdfg as one of the targets to build when
1075         using CMake.
1076
1077         * Scripts/build-jsc:
1078
1079 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1080
1081         Delete WebMetal implementation in favor of WebGPU
1082         https://bugs.webkit.org/show_bug.cgi?id=195418
1083
1084         Reviewed by Dean Jackson.
1085
1086         * DumpRenderTree/mac/DumpRenderTree.mm:
1087         (enableExperimentalFeatures):
1088         (resetWebPreferencesToConsistentValues):
1089         * Scripts/webkitperl/FeatureList.pm:
1090         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1091         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1092         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1093         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1094         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1095         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1096         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1097         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1098         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1099         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1100         (WTR::InjectedBundle::beginTesting):
1101         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1102         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1103         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1104
1105 2019-03-29  Chris Dumez  <cdumez@apple.com>
1106
1107         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1108         https://bugs.webkit.org/show_bug.cgi?id=196405
1109         <rdar://problem/49428130>
1110
1111         Reviewed by Wenson Hsieh.
1112
1113         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1114         the popover presentation methods to be no-ops. Use this in the new test added in
1115         r243523 so that we do not swizzle those methods for all tests. This is needed because
1116         those WatchOS tests rely on the popover getting presented and interactive.
1117
1118         * WebKitTestRunner/TestController.cpp:
1119         (WTR::updateTestOptionsFromTestHeader):
1120         * WebKitTestRunner/TestController.h:
1121         * WebKitTestRunner/TestOptions.h:
1122         (WTR::TestOptions::hasSameInitializationOptions const):
1123         * WebKitTestRunner/ios/TestControllerIOS.mm:
1124         (WTR::TestController::platformInitialize):
1125         (WTR::TestController::platformResetStateToConsistentValues):
1126
1127 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1128
1129         [Curl] Add Server Trust Evaluation Support.
1130         https://bugs.webkit.org/show_bug.cgi?id=191646
1131
1132         Reviewed by Fujii Hironori.
1133
1134         Implemented MiniBrowser UI for asking if user trusts the server.
1135
1136         * MiniBrowser/win/Common.cpp:
1137         (askServerTrustEvaluation):
1138         (replaceString):
1139         * MiniBrowser/win/Common.h:
1140         * MiniBrowser/win/MiniBrowserLib.rc:
1141         * MiniBrowser/win/MiniBrowserLibResource.h:
1142         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1143         (createPEMString):
1144         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1145         (WebKitBrowserWindow::canTrustServerCertificate):
1146         * MiniBrowser/win/WebKitBrowserWindow.h:
1147
1148 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1149
1150         Implement ResizeObserver.
1151         https://bugs.webkit.org/show_bug.cgi?id=157743
1152
1153         Reviewed by Simon Fraser.
1154
1155         Support resizeObserverEnabled webPreferences.
1156
1157         * DumpRenderTree/TestOptions.cpp:
1158         (TestOptions::TestOptions):
1159         * DumpRenderTree/TestOptions.h:
1160         * DumpRenderTree/mac/DumpRenderTree.mm:
1161         (setWebPreferencesForTestOptions):
1162         * DumpRenderTree/win/DumpRenderTree.cpp:
1163         (enableExperimentalFeatures):
1164         * Scripts/webkitperl/FeatureList.pm:
1165         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1166
1167 2019-03-28  John Wilander  <wilander@apple.com>
1168
1169         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1170         https://bugs.webkit.org/show_bug.cgi?id=196281
1171         <rdar://problem/48938748>
1172
1173         Reviewed by Alex Christensen.
1174
1175         This patch adds the function isStatisticsHasLocalStorage() to the
1176         TestRunner. With it, the page can query the WebsiteDataStore in the
1177         UI process to make sure that it sees LocalStorage.
1178
1179         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1180         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1181         (WTR::TestRunner::isStatisticsHasLocalStorage):
1182         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1183         * WebKitTestRunner/TestController.cpp:
1184         (WTR::TestController::isStatisticsHasLocalStorage):
1185         * WebKitTestRunner/TestController.h:
1186         * WebKitTestRunner/TestInvocation.cpp:
1187         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1188
1189 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1190
1191         API::Data::createWithoutCopying should do a null check before calling CFRelease
1192         https://bugs.webkit.org/show_bug.cgi?id=196276
1193         <rdar://problem/48059859>
1194
1195         Reviewed by Alex Christensen.
1196
1197         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1198
1199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1200         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1201         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1202         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1203         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1204         (TestWebKitAPI::TEST):
1205
1206 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1207
1208         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1209         https://bugs.webkit.org/show_bug.cgi?id=186276
1210
1211         Reviewed by Carlos Garcia Campos.
1212
1213         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1214         (webViewLoadChanged):
1215         (testWebResourceGetDataError):
1216         (testWebResourceGetDataEmpty):
1217         (beforeAll):
1218         (webViewloadChanged): Deleted.
1219
1220 2019-03-27  Andy Estes  <aestes@apple.com>
1221
1222         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1223         https://bugs.webkit.org/show_bug.cgi?id=196317
1224
1225         Reviewed by Dan Bernstein.
1226
1227         package-root copies built products into a staging directory using ditto(1), which does not
1228         follow symbolic links as it traverses a directory. Now that the files in
1229         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1230         itself, these become broken links when ditto'd into the staging directory.
1231
1232         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1233
1234         * Scripts/package-root:
1235
1236 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1237
1238         [ews-app] Update display text of Submit for ews analysis
1239         https://bugs.webkit.org/show_bug.cgi?id=196309
1240
1241         Reviewed by Dewei Zhu.
1242
1243         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1244
1245 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1246
1247         run-webkit-tests should check for leaks in WebKit processes
1248         <https://webkit.org/b/193772>
1249         <rdar://problem/46526680>
1250
1251         Reviewed by Ryosuke Niwa.
1252
1253         This works by doing the following:
1254         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1255           The list of child processes are returned one per line:
1256           process.name: pid
1257         - Run the "#LIST CHILD PROCESSES" command just before the
1258           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1259           processes on the ServerProcess object.
1260         - When the `--leaks` switch is handled, run check_for_leaks() on
1261           each child process after the main test harness.
1262
1263         * DumpRenderTree/mac/DumpRenderTree.mm:
1264         (handleControlCommand):
1265         - Use strncmp() instead of strcmp().
1266         - Add support for handling "#LIST CHILD PROCESSES" command.
1267
1268         * Scripts/webkitpy/port/base.py:
1269         (Port.check_for_leaks):
1270         * Scripts/webkitpy/port/darwin.py:
1271         (DarwinPort.check_for_leaks):
1272         - Rename redundant 'process_pid' argument to 'process_id'.
1273
1274         * Scripts/webkitpy/port/driver.py:
1275         (Driver.do_post_tests_work):
1276         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1277           longer the only command this sends to WebKitTestRunner.
1278         - If the `--leaks` switch is present, send the
1279           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1280           result using Port.set_webkit_processes().
1281         (Driver._parse_child_processes_output):
1282         - Add helper method to parse list of child process names and
1283           process IDs returned from WebKitTestRunner.
1284
1285         * Scripts/webkitpy/port/ios_device.py:
1286         (IOSDevicePort.check_for_leaks):
1287         - Rename redundant 'process_pid' argument to 'process_id'.
1288
1289         * Scripts/webkitpy/port/leakdetector.py:
1290         (LeakDetector._parse_leaks_output):
1291         - Return early if there is no leaks_output.
1292         (LeakDetector.check_for_leaks):
1293         - Rename redundant 'process_pid' argument to 'process_id'.
1294
1295         * Scripts/webkitpy/port/server_process.py:
1296         (ServerProcess.__init__):
1297         (ServerProcess.child_processes):
1298         (ServerProcess.set_child_processes):
1299         - Add instance variable to Port to store list of child process
1300           names and process IDs returned from WebKitTestRunner.
1301         (ServerProcess._start):
1302         - Clear self._child_processes.
1303         (ServerProcess.stop):
1304         - If self._child_processes is set, call
1305           self._port.check_for_leaks() for each child process.
1306
1307         * Scripts/webkitpy/port/server_process_unittest.py:
1308         (TrivialMockPort.check_for_leaks):
1309         - Rename redundant 'process_pid' argument to 'process_id'.
1310
1311         * Scripts/webkitpy/port/simulator_process.py:
1312         (SimulatorProcess.stop):
1313         - If self._child_processes is set, call
1314           self._port.check_for_leaks() for each child process.
1315
1316         * Scripts/webkitpy/port/watch_device.py:
1317         (WatchDevicePort.check_for_leaks):
1318         - Rename redundant 'process_pid' argument to 'process_id'.
1319
1320         * WebKitTestRunner/TestController.cpp:
1321         (WTR::TestController::dumpResponse):
1322         - Extract method from findAndDumpWorldLeaks() so that it may be
1323           reused by findAndDumpWebKitProcessIdentifiers().
1324         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1325         - Add method to output process name and process ID of both the
1326           WebContent and Networking processes.
1327         (WTR::TestController::findAndDumpWorldLeaks):
1328         - Fix missing newline in output when there were no abandoned
1329           documents.
1330         - Call dumpResponse() for extracted code.
1331         (WTR::TestController::handleControlCommand):
1332         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1333         - Use strncmp() instead of strcmp().
1334         - Call findAndDumpWebKitProcessIdentifiers() when
1335           "#LIST CHILD PROCESSES" command is sent.
1336         * WebKitTestRunner/TestController.h:
1337         (WTR::TestController::dumpResponse):
1338         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1339         - Declare methods.
1340
1341 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1342
1343         Unreviewed. Add GLib API test cases after r243434.
1344
1345         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1346         (testWebViewActiveURI):
1347         (serverCallback):
1348         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1349         (sendRequestCallback):
1350
1351 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1352
1353         Geolocation request not complete when watch request was started in a different web process
1354         https://bugs.webkit.org/show_bug.cgi?id=195996
1355
1356         Reviewed by Alex Christensen.
1357
1358         Add a test case.
1359
1360         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1361         (TestWebKitAPI::runJavaScriptAlert):
1362         (TestWebKitAPI::TEST):
1363
1364 2019-03-26  Keith Rollin  <krollin@apple.com>
1365
1366         Update the way generate-xcfilelists returns strings from functions
1367         https://bugs.webkit.org/show_bug.cgi?id=195975
1368         <rdar://problem/49040807>
1369
1370         Reviewed by Dean Jackson.
1371
1372         There are places where generate-xcfilelists executes assignments with
1373         statements like:
1374
1375             FOO=$(some_function)
1376
1377         where "some_function" return a string by echoing it. E.g.
1378
1379             some_function()
1380             {
1381                 echo "Hello, World"
1382             }
1383
1384         This is a common idiom, but it has a problem if "some_function" needs
1385         to call "exit" in an attempt to halt the entire script right then and
1386         there. Since "some_function" is called inside of $(), it's being
1387         executed in a sub-shell. Calling exit in that sub-shell simply exits
1388         that shell; it doesn't not exit the outer shell in which the main part
1389         of the script is still running. As such, the main script keeps
1390         executing when the intent was for the script to halt.
1391
1392         The solution to this is to use a different idiom for returning
1393         strings. The one we now is to pass in the name of the variable to
1394         receive the string result:
1395
1396             some_function()
1397             {
1398                 variable_name=$1
1399                 eval $variable_name ="Hello, World"
1400             }
1401
1402         The call site now looks like
1403
1404             some_function FOO
1405
1406         Because there's no invocation of a sub-shell, some_function can now
1407         call "exit" if it wants to, and the entire script will exit at that
1408         point.
1409
1410         * Scripts/generate-xcfilelists:
1411
1412 2019-03-26  Chris Dumez  <cdumez@apple.com>
1413
1414         Add basic layout test coverage for File Picker on iOS
1415         https://bugs.webkit.org/show_bug.cgi?id=196265
1416
1417         Reviewed by Wenson Hsieh.
1418
1419         Add layout test infrastructure to test the file picker on iOS.
1420
1421         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1422         (WTR::UIScriptController::dismissFilePicker):
1423         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1424         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1425         (WTR::UIScriptController::dismissFilePicker):
1426         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1427         * WebKitTestRunner/TestController.cpp:
1428         (WTR::TestController::createWebViewWithOptions):
1429         (WTR::updateTestOptionsFromTestHeader):
1430         * WebKitTestRunner/TestOptions.h:
1431         (WTR::TestOptions::hasSameInitializationOptions const):
1432         * WebKitTestRunner/ios/TestControllerIOS.mm:
1433         (overridePresentViewController):
1434         (WTR::TestController::platformInitialize):
1435         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1436         (WTR::UIScriptController::dismissFilePicker):
1437
1438 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1439
1440         Implement async paste method on UIWKInteractionViewProtocol
1441         https://bugs.webkit.org/show_bug.cgi?id=196267
1442         <rdar://problem/49236346>
1443
1444         Reviewed by Tim Horton.
1445
1446         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1447         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1448         are now a part of all iOS 12 internal SDKs.
1449
1450         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1451
1452         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1453         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1454
1455         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1456         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1457         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1458         * TestWebKitAPI/ios/UIKitSPI.h:
1459
1460 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1461
1462         [ews-build] Use PostgreSQL for ews.webkit.org database
1463         https://bugs.webkit.org/show_bug.cgi?id=196270
1464
1465         Reviewed by Lucas Forschler.
1466
1467         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1468
1469 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1470
1471         [ews] Reset simctl states on reboot
1472         https://bugs.webkit.org/show_bug.cgi?id=196260
1473
1474         Rubber-stamped by Aakash Jain.
1475
1476         * EWSTools/start-queue-mac.sh:
1477
1478 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1479
1480         [ews-build] Use PostgreSQL for ews-build database
1481         https://bugs.webkit.org/show_bug.cgi?id=196229
1482
1483         Reviewed by Lucas Forschler.
1484
1485         * BuildSlaveSupport/ews-build/master.cfg:
1486
1487 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1488
1489         [ews-build] Get master_hostname dynamically in master.cfg
1490         https://bugs.webkit.org/show_bug.cgi?id=196255
1491
1492         Reviewed by Lucas Forschler.
1493
1494         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1495         send events data in test mode.
1496
1497 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1498
1499         [ews-app] Set db_constraint to False for Foreign Keys
1500         https://bugs.webkit.org/show_bug.cgi?id=196252
1501
1502         Reviewed by Lucas Forschler.
1503
1504         * BuildSlaveSupport/ews-app/ews/models/build.py:
1505         * BuildSlaveSupport/ews-app/ews/models/step.py:
1506
1507 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1508
1509         [ews-build] is_test_mode_enabled should default to True
1510         https://bugs.webkit.org/show_bug.cgi?id=196248
1511
1512         Reviewed by Lucas Forschler.
1513
1514         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1515
1516 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1517
1518         [ews-app] Add webkitperl to ENABLED_QUEUES
1519         https://bugs.webkit.org/show_bug.cgi?id=196253
1520
1521         Reviewed by Lucas Forschler.
1522
1523         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1524
1525 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1526
1527         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1528         https://bugs.webkit.org/show_bug.cgi?id=196211
1529         rdar://problem/49110552
1530
1531         Reviewed by Tim Horton.
1532
1533         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1534         Make sure that EventSenderProxy always exists when running tests. We used to create
1535         it when resetting before the first test, which is a bit too late.
1536
1537         * WebKitTestRunner/TestController.h:
1538         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1539         (WTR::TestController::platformCreateWebView):
1540         (WTR::TestController::platformCreateOtherPage):
1541         (WTR::TestController::finishCreatingPlatformWebView):
1542         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1543         (WTR::PlatformWebView::PlatformWebView):
1544         Moved some code that made NSWindow use NSEvent during web view creation. We may
1545         need to move more if some other case us found, but this is enough for now.
1546
1547 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1548
1549         Unreviewed. Fix typo in GLib geolocation API after r243285.
1550
1551         gelocation -> geolocation.
1552
1553         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1554         (testGeolocationManagerWatchPosition):
1555
1556 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1557
1558         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1559         https://bugs.webkit.org/show_bug.cgi?id=196213
1560
1561         Reviewed by Geoff Garen.
1562
1563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1564         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1565         (credentialWithIdentityAndKeychainPath):
1566         (-[ChallengeDelegate webView:didFinishNavigation:]):
1567         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1568         (TestWebKitAPI::TEST):
1569
1570 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1571
1572         Expected shouldn't assume its contained types are copyable
1573         https://bugs.webkit.org/show_bug.cgi?id=195986
1574
1575         Reviewed by JF Bastien.
1576
1577         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1578         (TestWebKitAPI::NonCopyable::operator== const):
1579         (TestWebKitAPI::NonCopyable::operator!= const):
1580         (TestWebKitAPI::TEST):
1581
1582 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1583
1584         Remove some now-unnecessary dynamic class lookup
1585         https://bugs.webkit.org/show_bug.cgi?id=196237
1586
1587         Reviewed by Simon Fraser.
1588
1589         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1590         (makeRequest):
1591         (TEST):
1592
1593 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1594
1595         Unreviewed, rolling out r243450.
1596
1597         AppleWin and WinCairo port builds get broken.
1598
1599         Reverted changeset:
1600
1601         "Add test for fix of #196095"
1602         https://bugs.webkit.org/show_bug.cgi?id=196097
1603         https://trac.webkit.org/changeset/243450
1604
1605 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1606
1607         Unreviewed, rolling out r243465.
1608         https://bugs.webkit.org/show_bug.cgi?id=196226
1609
1610         the test doesn't build (Requested by thorton on #webkit).
1611
1612         Reverted changeset:
1613
1614         "Do not terminate the NetworkProcess if a third party
1615         application sends a NSCredential with a SecIdentityRef"
1616         https://bugs.webkit.org/show_bug.cgi?id=196213
1617         https://trac.webkit.org/changeset/243465
1618
1619 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1620
1621         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1622         https://bugs.webkit.org/show_bug.cgi?id=196213
1623
1624         Reviewed by Geoff Garen.
1625
1626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1627         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1628         (credentialWithIdentityAndKeychainPath):
1629         (-[ChallengeDelegate webView:didFinishNavigation:]):
1630         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1631         (TestWebKitAPI::TEST):
1632
1633 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1634
1635         [ews-build] Gracefully handle missing patch_id in events
1636         https://bugs.webkit.org/show_bug.cgi?id=196216
1637
1638         Reviewed by Lucas Forschler.
1639
1640         * BuildSlaveSupport/ews-build/events.py:
1641
1642 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1643
1644         [ews-build] use lz4 compression for improving buildbot performance
1645         https://bugs.webkit.org/show_bug.cgi?id=196155
1646
1647         Reviewed by Lucas Forschler.
1648
1649         * BuildSlaveSupport/ews-build/master.cfg:
1650
1651 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1652
1653         Pull some API testing helper methods out of TestWKWebView
1654         https://bugs.webkit.org/show_bug.cgi?id=196212
1655
1656         Reviewed by Tim Horton.
1657
1658         Refactor some more API testing utility methods, so that they can be used in
1659         tests that do not use TestWKWebView.
1660
1661         * TestWebKitAPI/cocoa/TestWKWebView.h:
1662         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1663         (-[WKWebView loadTestPageNamed:]):
1664         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1665         (-[WKWebView synchronouslyLoadHTMLString:]):
1666         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1667         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1668         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1669         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1670         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1671
1672 2019-03-25  Jer Noble  <jer.noble@apple.com>
1673
1674         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1675         https://bugs.webkit.org/show_bug.cgi?id=196097
1676
1677         Reviewed by Eric Carlson.
1678
1679         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1680
1681         * DumpRenderTree/mac/DumpRenderTree.mm:
1682         (resetWebPreferencesToConsistentValues):
1683         * WebKitTestRunner/TestController.cpp:
1684         (WTR::TestController::resetPreferencesToConsistentValues):
1685
1686 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1687
1688         Pull IPadUserInterfaceSwizzler out into a separate header file
1689         https://bugs.webkit.org/show_bug.cgi?id=196193
1690
1691         Reviewed by Anders Carlsson.
1692
1693         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1694         be used in other API tests.
1695
1696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1697         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1698         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1699         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1700         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1701         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1702         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1703
1704 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1705
1706         Remove NavigatorContentUtils in WebCore/Modules
1707         https://bugs.webkit.org/show_bug.cgi?id=196070
1708
1709         Reviewed by Alex Christensen.
1710
1711         NavigatorContentUtils was to support the custom scheme spec [1].
1712         However, in WebKit side, no port has supported the feature in
1713         WebKit layer after EFL port was removed. So there has been the
1714         only IDL implementation of the NavigatorContentUtils in WebCore.
1715         So we don't need to keep the implementation in WebCore anymore.
1716
1717         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1718
1719         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1720
1721 2019-03-24  Andy Estes  <aestes@apple.com>
1722
1723         [watchOS] Remove unused Proximity Networking code
1724         https://bugs.webkit.org/show_bug.cgi?id=196188
1725
1726         Reviewed by Tim Horton.
1727
1728         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1729         (TEST):
1730
1731 2019-03-23  Keith Miller  <keith_miller@apple.com>
1732
1733         Refactor clz/ctz and fix getLSBSet.
1734         https://bugs.webkit.org/show_bug.cgi?id=196162
1735
1736         Reviewed by Saam Barati.
1737
1738         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1739
1740         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1741         (TestWebKitAPI::TEST):
1742
1743 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1744
1745         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1746         https://bugs.webkit.org/show_bug.cgi?id=196143
1747
1748         Reviewed by Michael Catanzaro.
1749
1750         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1751         directories.
1752
1753         * Scripts/webkitpy/style/checkers/cpp.py:
1754         (check_identifier_name_in_declaration):
1755         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1756         (WebKitStyleTest.test_names):
1757
1758 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1759
1760         [Flatpak] Manifest expanding fails for qt WPE extension
1761         https://bugs.webkit.org/show_bug.cgi?id=196148
1762
1763         Reviewed by Alex Christensen.
1764
1765         * flatpak/flatpakutils.py:
1766         (expand_submodules_recurse): The last recurse manifest expand
1767         iteration might lead to a single module so take it into account
1768         and don't try to recurse further.
1769
1770 2019-03-22  Chris Dumez  <cdumez@apple.com>
1771
1772         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1773         https://bugs.webkit.org/show_bug.cgi?id=195348
1774         <rdar://problem/48622090>
1775
1776         Reviewed by Alex Christensen.
1777
1778         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1779         to NO when test.options().shouldIgnoreMetaViewport is false.
1780
1781         * WebKitTestRunner/ios/TestControllerIOS.mm:
1782         (WTR::TestController::platformConfigureViewForTest):
1783
1784 2019-03-22  Chris Dumez  <cdumez@apple.com>
1785
1786         Prewarmed processes should be usable with any website data store
1787         https://bugs.webkit.org/show_bug.cgi?id=196104
1788
1789         Reviewed by Alex Christensen.
1790
1791         Add API test coverage.
1792
1793         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1794         (runInitialWarmedProcessUsedTest):
1795         (TEST):
1796
1797 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1798
1799         Back out local changes to Alex's Subversion working directory
1800
1801         They were accidentally committed.
1802
1803         * Scripts/webkitpy/common/system/abstractexecutive.py:
1804         (AbstractExecutive.wait_newest):
1805         * Scripts/webkitpy/common/system/executive.py:
1806         (Executive.running_pids):
1807         * Scripts/webkitpy/common/system/executive_mock.py:
1808         (MockExecutive.running_pids):
1809         * Scripts/webkitpy/common/system/executive_unittest.py:
1810         (ExecutiveTest.serial_test_running_pids):
1811         * Scripts/webkitpy/port/darwin.py:
1812         (DarwinPort.check_for_leaks):
1813         * Scripts/webkitpy/port/leakdetector.py:
1814         (LeakDetector.check_for_leaks):
1815         - This was the hack attached to Bug 193772.
1816
1817         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1818         (+[WebKitTestRunnerEvent mouseLocation]):
1819         - This works around a crash on an internal build.
1820
1821 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1822
1823         Fix the build after r243354
1824         https://bugs.webkit.org/show_bug.cgi?id=196138
1825         <rdar://problem/49145951>
1826
1827         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1828         (TEST):
1829         * TestWebKitAPI/ios/UIKitSPI.h:
1830
1831 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1832
1833         Adopt UIWKDocumentContext
1834         https://bugs.webkit.org/show_bug.cgi?id=196040
1835         <rdar://problem/48642440>
1836
1837         Reviewed by Ryosuke Niwa.
1838
1839         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1840         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1841         (makeRequest):
1842         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1843         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1844         (applyStyle):
1845         (TEST):
1846         Add tests for UIWKDocumentContext.
1847
1848         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1849         (TEST):
1850         (recursiveFindWKContentView): Deleted.
1851         * TestWebKitAPI/cocoa/TestWKWebView.h:
1852         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1853         (recursiveFindWKContentView):
1854         (-[TestWKWebView wkContentView]):
1855         * TestWebKitAPI/ios/UIKitSPI.h:
1856         Share the WKContentView finding code between tests.
1857
1858 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1859
1860         [iOS WK2] Turn on async overflow scrolling by default
1861         https://bugs.webkit.org/show_bug.cgi?id=196011
1862         rdar://problem/48453859
1863
1864         Reviewed by Antti Koivisto.
1865         
1866         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1867         since so many basic layout tests have different results when compositing is triggered for
1868         overflow.
1869         
1870         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1871
1872         * WebKitTestRunner/TestController.cpp:
1873         (WTR::TestController::resetPreferencesToConsistentValues):
1874
1875 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1876
1877         [ews-build] Retry API test in case of failures
1878         https://bugs.webkit.org/show_bug.cgi?id=196004
1879
1880         Reviewed by Lucas Forschler.
1881
1882         * BuildSlaveSupport/ews-build/steps.py:
1883         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1884         (CompileWebKitToT.doStepIf): Ditto.
1885         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1886         (ReRunAPITests): Re-run API tests.
1887         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1888         (RunAPITestsWithoutPatch): Run API tests without patch.
1889         (RunAPITestsWithoutPatch.doStepIf):
1890         (RunAPITestsWithoutPatch.hideStepIf):
1891         (RunAPITestsWithoutPatch.evaluateCommand):
1892         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1893         (AnalyzeAPITestsResults.start):
1894         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1895         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1896         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1897         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1898
1899 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1900
1901         [ews-build] Update queues configurations
1902         https://bugs.webkit.org/show_bug.cgi?id=196074
1903
1904         Reviewed by Dewei Zhu.
1905
1906         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1907         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1908
1909 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1910
1911         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1912         https://bugs.webkit.org/show_bug.cgi?id=195680
1913         <rdar://problem/48903534>
1914
1915         Unreviewed infrastructure fix.
1916
1917         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1918         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1919
1920 2019-03-21  Andy Estes  <aestes@apple.com>
1921
1922         [iOS] Apple Pay should be available in documents with no user agent scripts
1923         https://bugs.webkit.org/show_bug.cgi?id=196061
1924         <rdar://problem/48649391>
1925
1926         Reviewed by Brady Eidson.
1927
1928         Added API tests and related infrastructure.
1929
1930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1931         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1932         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1933         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1934         (TestWebKitAPI::TEST):
1935         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1936         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1937         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1938         * TestWebKitAPI/cocoa/TestProtocol.mm:
1939         (-[TestProtocol startLoading]):
1940         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1941         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1942         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1943         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1944
1945 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1946
1947         REGRESSSION (r243297): webkitpy tests broken
1948         https://bugs.webkit.org/show_bug.cgi?id=196108
1949
1950         Reviewed by Aakash Jain.
1951
1952         r243297 updated contributors.json, which broke a few unit tests.
1953
1954         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1955         (IRCCommandTest.test_whois):
1956         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1957
1958 2019-03-21  Chris Dumez  <cdumez@apple.com>
1959
1960         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1961         https://bugs.webkit.org/show_bug.cgi?id=196041
1962         <rdar://problem/49083230>
1963
1964         Reviewed by Alex Christensen.
1965
1966         Add API test coverage.
1967
1968         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1969         (TEST):
1970
1971 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1972
1973         Add SPI to inform applications of WKContentRuleList actions
1974         https://bugs.webkit.org/show_bug.cgi?id=195965
1975         <rdar://problem/42664365>
1976
1977         Reviewed by Geoff Garen.
1978
1979         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1980         (TestWebKitAPI::allActionsForResourceLoad):
1981         (TestWebKitAPI::testRequest):
1982         (TestWebKitAPI::TEST_F):
1983         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1984         (Notification::description):
1985         (Notification::operator== const):
1986         (toVector):
1987         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1988         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1989         (makeContentRuleList):
1990         (TEST):
1991         (makeWarnContentRuleList): Deleted.
1992
1993 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1994
1995         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1996         https://bugs.webkit.org/show_bug.cgi?id=196088
1997
1998         Reviewed by Brian Burg.
1999
2000         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2001         Support checks when only one platform is specified. Also deprecate macosx() and
2002         force the use of macos() instead.
2003
2004         * Scripts/webkitpy/style/checkers/cpp.py:
2005         (check_min_versions_of_wk_api_available):
2006         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2007         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2008
2009 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2010
2011         Update status inactive committers' status to 'contributor'.
2012
2013         * Scripts/webkitpy/common/config/contributors.json:
2014
2015 2019-03-21  Xan Lopez  <xan@igalia.com>
2016
2017         [JSC][x86] Drop support for x87 floating point
2018         https://bugs.webkit.org/show_bug.cgi?id=194853
2019
2020         Reviewed by Don Olmstead.
2021
2022         Force SSE2 on x86/32bit builds.
2023
2024         * Scripts/webkitdirs.pm:
2025         (generateBuildSystemFromCMakeProject):
2026
2027 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2028
2029         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2030         https://bugs.webkit.org/show_bug.cgi?id=196073
2031
2032         Reviewed by Michael Catanzaro.
2033
2034         Add test cases to check functions and constructors with no arguments but receiving user data.
2035
2036         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2037         (checkUserData):
2038         (testJSCFunction):
2039         (fooCreateWithUserData):
2040         (testJSCClass):
2041
2042 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2043
2044         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2045
2046         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2047
2048         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2049
2050 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2051
2052         [GTK][WPE] Add API to provide geolocation information
2053         https://bugs.webkit.org/show_bug.cgi?id=195940
2054
2055         Reviewed by Michael Catanzaro.
2056
2057         Add a new test to check the new API.
2058
2059         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2060         (testGeolocationManagerCurrentPosition):
2061         (testGeolocationManagerWatchPosition):
2062         (beforeAll):
2063         (afterAll):
2064         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2065         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2066         (beforeAll): Ditto.
2067         * TestWebKitAPI/glib/CMakeLists.txt:
2068
2069 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2070
2071         [GLib] Returning G_TYPE_OBJECT from a method does not work
2072         https://bugs.webkit.org/show_bug.cgi?id=195574
2073
2074         Reviewed by Michael Catanzaro.
2075
2076         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2077
2078         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2079         (getGFile):
2080         (getParent):
2081         (createGString):
2082         (getGString):
2083         (getGStringCopyWillRaise):
2084         (getGStringCopy):
2085         (getGStringStr):
2086         (getGStringLen):
2087         (freeGString):
2088         (testJSCClass):
2089
2090 2019-03-20  Saam Barati  <sbarati@apple.com>
2091
2092         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2093         https://bugs.webkit.org/show_bug.cgi?id=195721
2094
2095         Reviewed by Filip Pizlo.
2096
2097         * Scripts/run-javascriptcore-tests:
2098
2099 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2100
2101         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2102         https://bugs.webkit.org/show_bug.cgi?id=196049
2103
2104         Reviewed by Tim Horton.
2105
2106         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2107         overflow scrolling in general, so rename it.
2108
2109         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2110
2111 2019-03-20  Daniel Bates  <dabates@apple.com>
2112
2113         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2114         https://bugs.webkit.org/show_bug.cgi?id=196031
2115         <rdar://problem/49078172>
2116
2117         Reviewed by Tim Horton.
2118
2119         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2120         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2121         same code path used when the Done button is pressed to dismiss the <select> picker.
2122
2123         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2124         (TestWebKitAPI::TEST):
2125
2126 2019-03-20  Chris Dumez  <cdumez@apple.com>
2127
2128         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2129         https://bugs.webkit.org/show_bug.cgi?id=196029
2130         <rdar://problem/48954651>
2131
2132         Reviewed by Tim Horton.
2133
2134         Add API test coverage.
2135
2136         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2137
2138 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2139
2140         [ews-build] Improve failure summary string for ApplyPatch step
2141         https://bugs.webkit.org/show_bug.cgi?id=195995
2142
2143         Reviewed by Alexey Proskuryakov.
2144
2145         * BuildSlaveSupport/ews-build/steps.py:
2146         (ApplyPatch.getResultSummary): Override getResultSummary.
2147
2148 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2149
2150         AX: Implement support for new meter ARIA role
2151         https://bugs.webkit.org/show_bug.cgi?id=195966
2152
2153         Reviewed by Chris Fleizach.
2154
2155         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2156         to AXLevelIndicator.
2157
2158         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2159
2160 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2161
2162         [WebAuthN] Implement FIDO AppID extension
2163         https://bugs.webkit.org/show_bug.cgi?id=143491
2164         <rdar://problem/48298273>
2165
2166         Reviewed by Brent Fulgham.
2167
2168         Add a test that covers the new flag of convertToU2fSignCommand.
2169
2170         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2171         (TestWebKitAPI::TEST):
2172         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2173         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2174         (TestWebKitAPI::TEST):
2175
2176 2019-03-19  Keith Rollin  <krollin@apple.com>
2177
2178         Add support for more platforms to generate-xcfilelists
2179         https://bugs.webkit.org/show_bug.cgi?id=195977
2180
2181         Reviewed by Alexey Proskuryakov.
2182
2183         generate-xcfilelists incorrectly complains when involved with building
2184         WebKit for iphonesimulator:
2185
2186             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2187             …
2188             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2189
2190         Address this by teaching generate-xcfilelists about more platforms.
2191
2192         * Scripts/generate-xcfilelists:
2193
2194 2019-03-19  John Wilander  <wilander@apple.com>
2195
2196         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2197         https://bugs.webkit.org/show_bug.cgi?id=195923
2198         <rdar://problem/49001272>
2199
2200         Reviewed by Alex Christensen.
2201
2202         This patch does the following to the TestRunner:
2203         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2204         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2205         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2206
2207         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2208         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2209         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2210         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2211         * WebKitTestRunner/TestController.cpp:
2212         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2213         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2214         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2215         * WebKitTestRunner/TestController.h:
2216         * WebKitTestRunner/TestInvocation.cpp:
2217         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2218
2219 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2220
2221         [CMake] Support more clang and gcc sanitizers
2222         https://bugs.webkit.org/show_bug.cgi?id=195956
2223
2224         Reviewed by Michael Catanzaro.
2225
2226         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2227
2228 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2229
2230         [ews-build] Improve summary for PrintConfiguration step
2231         https://bugs.webkit.org/show_bug.cgi?id=195945
2232
2233         Reviewed by Lucas Forschler.
2234
2235         * BuildSlaveSupport/ews-build/steps.py:
2236         (PrintConfiguration.getResultSummary): Override getResultSummary.
2237
2238 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2239
2240         [ews-build] Improve summary for CheckOutSource step
2241         https://bugs.webkit.org/show_bug.cgi?id=195963
2242
2243         Reviewed by Lucas Forschler.
2244
2245         * BuildSlaveSupport/ews-build/steps.py:
2246         (CheckOutSource.getResultSummary):
2247
2248 2019-03-19  Daniel Bates  <dabates@apple.com>
2249
2250         [iOS] Focus not preserved when switching between tabs
2251         https://bugs.webkit.org/show_bug.cgi?id=195820
2252         <rdar://problem/43614450>
2253
2254         Reviewed by Brent Fulgham.
2255
2256         Add tests to ensure that we restore focus when resigning and becoming first responder.
2257
2258         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2259         (TestWebKitAPI::TEST):
2260
2261 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2262
2263         Make WTFLogChannelState and WTFLogLevel enum classes
2264         https://bugs.webkit.org/show_bug.cgi?id=195904
2265
2266         Reviewed by Eric Carlson.
2267
2268         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2269         (TestWebKitAPI::TEST_F):
2270
2271 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2272
2273         [GStreamer][EME] Backported mssdemux protection data crash fix
2274         https://bugs.webkit.org/show_bug.cgi?id=195918
2275
2276         Reviewed by Philippe Normand.
2277
2278         * gstreamer/jhbuild.modules:
2279         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2280
2281 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2282
2283         Unreviewed, rolling out r243132.
2284
2285         Broke GTK build
2286
2287         Reverted changeset:
2288
2289         "Make WTFLogChannelState and WTFLogLevel enum classes"
2290         https://bugs.webkit.org/show_bug.cgi?id=195904
2291         https://trac.webkit.org/changeset/243132
2292
2293 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2294
2295         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2296
2297         * Scripts/webkitdirs.pm:
2298         (builtDylibPathForName): Adjust the shared library name that's changed
2299         with the API version bump in r243073.
2300
2301 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2302
2303         Make WTFLogChannelState and WTFLogLevel enum classes
2304         https://bugs.webkit.org/show_bug.cgi?id=195904
2305
2306         Reviewed by Eric Carlson.
2307
2308         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2309         (TestWebKitAPI::TEST_F):
2310
2311 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2312
2313         Disable flaky test added in r2431100
2314         https://webkit.org/b/195785
2315
2316         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2317         (TestWebKitAPI::TEST):
2318         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2319
2320 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2321
2322         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2323         https://bugs.webkit.org/show_bug.cgi?id=195916
2324
2325         Reviewed by Tim Horton.
2326
2327         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2328         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2329
2330 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2331
2332         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2333
2334         * Scripts/webkitpy/common/config/contributors.json:
2335
2336 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2337
2338         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2339         https://bugs.webkit.org/show_bug.cgi?id=195785
2340
2341         Reviewed by Geoffrey Garen.
2342
2343         * TestWebKitAPI/TCPServer.cpp: Added.
2344         (TestWebKitAPI::TCPServer::TCPServer):
2345         (TestWebKitAPI::TCPServer::~TCPServer):
2346         (TestWebKitAPI::TCPServer::socketBindListen):
2347         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2348         * TestWebKitAPI/TCPServer.h: Added.
2349         (TestWebKitAPI::TCPServer::port const):
2350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2351         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2352         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2353         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2354         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2355         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2356         (TestWebKitAPI::respondSlowly):
2357         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2358         (TestWebKitAPI::downloadAtRate):
2359         (TestWebKitAPI::TEST):
2360
2361 2019-03-18  Saam Barati  <sbarati@apple.com>
2362
2363         Add a plan file for JetStream 2
2364         https://bugs.webkit.org/show_bug.cgi?id=190734
2365
2366         Reviewed by Mark Lam.
2367
2368         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2369
2370 2019-03-18  Chris Dumez  <cdumez@apple.com>
2371
2372         Delay WebProcess launch until a load is triggered in a Web view
2373         https://bugs.webkit.org/show_bug.cgi?id=195758
2374         <rdar://problem/48126013>
2375
2376         Reviewed by Geoff Garen.
2377
2378         Add API test coverage. Also update some existing API tests to not expect
2379         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2380
2381         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2382         (TestWebKitAPI::TEST):
2383         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2384         (TestWebKitAPI::TEST):
2385         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2386         (TEST):
2387         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2388         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2389         (TEST):
2390         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2391         (TEST):
2392         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2393
2394 2019-03-18  Xan Lopez  <xan@igalia.com>
2395
2396         [CMake] Prevent potential warning when determining $architecture
2397         https://bugs.webkit.org/show_bug.cgi?id=195891
2398
2399         Reviewed by Michael Catanzaro.
2400
2401         It's possible for generateBuildSystemForCMakeProject to be called
2402         before determineArchitecture() is ever called. This will make the
2403         first eq check with $architecture to be bogus (and print a
2404         warning). Change that to an eq check with architecture(), which
2405         implicitly calls determineArchitecture() if needed, and change all
2406         the other similar cases in the method in the same way to prevent
2407         future bugs like this one.
2408
2409         * Scripts/webkitdirs.pm:
2410         (generateBuildSystemFromCMakeProject):
2411
2412 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2413
2414         [WPE] Tarballs generated with “make dist” cannot build documentation
2415         https://bugs.webkit.org/show_bug.cgi?id=195885
2416
2417         Reviewed by Carlos Garcia Campos.
2418
2419         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2420
2421 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2422
2423         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2424         https://bugs.webkit.org/show_bug.cgi?id=195883
2425
2426         Reviewed by Carlos Garcia Campos.
2427
2428         * gtkdoc/gtkdoc.py:
2429         (GTKDoc._run_command): When commands fail to run, include the full command line for
2430         the program invocation and the output it has generated on the standard error stream.
2431
2432 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2433
2434         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2435         https://bugs.webkit.org/show_bug.cgi?id=195786
2436
2437         Reviewed by Philippe Normand.
2438
2439         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2440         * wpe/jhbuild.modules: Ditto.
2441
2442 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2443
2444         [ews-build] Don't run clean builds on EWS builders
2445         https://bugs.webkit.org/show_bug.cgi?id=195851
2446
2447         Reviewed by Geoffrey Garen.
2448
2449         * BuildSlaveSupport/ews-build/factories.py:
2450
2451 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2452
2453         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2454         https://bugs.webkit.org/show_bug.cgi?id=195849
2455
2456         Reviewed by Chris Dumez.
2457
2458         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2459
2460         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2461         (runWebsiteDataStoreCustomPaths):
2462
2463 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2464
2465         webkitpy: Upload test results
2466         https://bugs.webkit.org/show_bug.cgi?id=195755
2467         <rdar://problem/48896182>
2468
2469         Reviewed by Aakash Jain.
2470
2471         Establish a new format for uploading results that is not tied to layout tests, apply
2472         that format to webkitpy tests.
2473
2474         * Scripts/webkitpy/common/checkout/scm/git.py:
2475         (Git.native_branch): Return what branch the current checkout is on.
2476         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2477         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2478         * Scripts/webkitpy/common/checkout/scm/svn.py:
2479         (SVN.native_branch): Ditto.
2480         * Scripts/webkitpy/common/system/platforminfo.py:
2481         (PlatformInfo.build_version): Return a build version for Mac.
2482         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2483         (MockPlatformInfo.__init__):
2484         (MockPlatformInfo.build_version):
2485         * Scripts/webkitpy/results: Added.
2486         * Scripts/webkitpy/results/__init__.py: Added.
2487         * Scripts/webkitpy/results/options.py: Added.
2488         (upload_options): OptParse list for upload options.
2489         * Scripts/webkitpy/results/upload.py: Added.
2490         (Upload): Class which enforces the upload format expected by the results server.
2491         (Upload.Expectations):
2492         (Upload.create_configuration):
2493         (Upload.create_commit):
2494         (Upload.create_details):
2495         (Upload.create_run_stats):
2496         (Upload.create_test_result):
2497         (Upload.__init__):
2498         (Upload.Encoder): Encode Upload object as json.
2499         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2500         * Scripts/webkitpy/results/upload_unittest.py: Added.
2501         * Scripts/webkitpy/test/main.py:
2502         (Tester._parse_args): Add upload arguments.
2503         (Tester._run_tests): Allow results to be uploaded.
2504         * Scripts/webkitpy/test/runner.py:
2505         (Runner.__init__): Record which tests were run, rather than just counting them.
2506         (Runner.handle):
2507         * Scripts/webkitpy/test/runner_unittest.py:
2508         (RunnerTest.test_run):
2509         * Scripts/webkitpy/thirdparty/__init__.py:
2510         (AutoinstallImportHook.find_module): Add requests auto-install.
2511         (AutoinstallImportHook._install_requests):
2512         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2513         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2514
2515 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2516
2517         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2518         https://bugs.webkit.org/show_bug.cgi?id=195810
2519
2520         Reviewed by Tim Horton.
2521
2522         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2523         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2524         ending certain layout tests.
2525
2526         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2527         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2528         (-[TestRunnerWKWebView dealloc]):
2529         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2530
2531         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2532         helper method when destroying the web view, and when resetting state between tests.
2533
2534         * WebKitTestRunner/ios/TestControllerIOS.mm:
2535         (WTR::TestController::platformResetStateToConsistentValues):
2536
2537         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2538
2539 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2540
2541         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2542         https://bugs.webkit.org/show_bug.cgi?id=190350
2543         <rdar://problem/45089503>
2544
2545         Reviewed by Geoffrey Garen.
2546
2547         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2548         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2549         (TEST):
2550         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2551         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2552         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2553         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2554         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2555         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2556         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2557         (runTest):
2558         (createDirectories):
2559         (TEST):
2560         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2561         (TEST):
2562         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2563         (TEST):
2564
2565 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2566
2567         Add support to WebPage for getting the contents as an attributed string.
2568         https://bugs.webkit.org/show_bug.cgi?id=195636
2569         rdar://problem/45055697
2570
2571         Reviewed by Tim Horton.
2572
2573         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2574         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2575
2576 2019-03-15  Chris Dumez  <cdumez@apple.com>
2577
2578         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2579         https://bugs.webkit.org/show_bug.cgi?id=195747
2580
2581         Reviewed by Geoff Garen.
2582
2583         Add API test coverage.
2584
2585         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2586
2587 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2588
2589         Unreviewed, rolling out r242952.
2590
2591         Causing API failures on iOS Simulator
2592
2593         Reverted changeset:
2594
2595         "[PSON] Make sure the WebProcessCache is leverage when
2596         relaunching a process after termination"
2597         https://bugs.webkit.org/show_bug.cgi?id=195747
2598         https://trac.webkit.org/changeset/242952
2599
2600 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2601
2602         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2603         https://bugs.webkit.org/show_bug.cgi?id=195740
2604
2605         Reviewed by Ross Kirsling.
2606
2607         window.open doesn't work for WebKitBrowserWindow because it is not
2608         implemented yet.
2609
2610         1. Implemented createNewPage callback of WKPageUIClient.
2611         2. Changed MainWindow to take a BrowserWindow factory function
2612           instead of BrowserWindowType to be flexible to create
2613           BrowserWindow with extra settings.
2614         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2615           because it is not relevant with MainWindow anymore.
2616
2617         * MiniBrowser/win/Common.cpp:
2618         (parseCommandLine):
2619         * MiniBrowser/win/Common.h:
2620         (CommandLineOptions::CommandLineOptions):
2621         * MiniBrowser/win/MainWindow.cpp:
2622         (MainWindow::MainWindow):
2623         (MainWindow::create):
2624         (MainWindow::init):
2625         (MainWindow::WndProc):
2626         * MiniBrowser/win/MainWindow.h:
2627         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2628         (PrintWebUIDelegate::createWebViewWithRequest):
2629         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2630         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2631         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2632         (WebKitBrowserWindow::updateProxySettings):
2633         (WebKitBrowserWindow::createNewPage):
2634         * MiniBrowser/win/WebKitBrowserWindow.h:
2635         * MiniBrowser/win/WinMain.cpp:
2636         (wWinMain):
2637
2638 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2639
2640         Make it possible to test scrolling tree layer manipulation more easily
2641         https://bugs.webkit.org/show_bug.cgi?id=195780
2642
2643         Reviewed by Tim Horton.
2644         
2645         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2646         cuts off communication of scrolling tree scrolls back to the web process
2647         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2648         allows tests to trigger scrolls which run the scrolling tree layer positioning
2649         logic, but never get another commit from the web process that might mask
2650         scrolling tree bugs.
2651         
2652         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2653         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2654         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2655
2656         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2657         (WTR::UIScriptController::scrollUpdatesDisabled const):
2658         (WTR::UIScriptController::setScrollUpdatesDisabled):
2659         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2660         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2661         (WTR::UIScriptController::scrollUpdatesDisabled const):
2662         (WTR::UIScriptController::setScrollUpdatesDisabled):
2663         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2664         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2665         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2666         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2667         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2668         * WebKitTestRunner/ios/TestControllerIOS.mm:
2669         (WTR::TestController::platformResetStateToConsistentValues):
2670         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2671         (WTR::UIScriptController::scrollUpdatesDisabled const):
2672         (WTR::UIScriptController::setScrollUpdatesDisabled):
2673
2674 2019-03-14  Youenn Fablet  <youenn@apple.com>
2675
2676         Move IDB storage in private browsing mode to NetworkProcess
2677         https://bugs.webkit.org/show_bug.cgi?id=195602
2678
2679         Reviewed by Brady Eidson.
2680
2681         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2682         (TEST):
2683
2684 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2685
2686         [ews-build] Make descriptionDone messages more readable
2687         https://bugs.webkit.org/show_bug.cgi?id=195760
2688
2689         Reviewed by Lucas Forschler.
2690
2691         * BuildSlaveSupport/ews-build/steps.py:
2692         * BuildSlaveSupport/ews-build/steps_unittest.py:
2693
2694 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2695
2696         [ews-build] Generate status-bubble hover-over messages
2697         https://bugs.webkit.org/show_bug.cgi?id=195680
2698
2699         Reviewed by Lucas Forschler.
2700
2701         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2702         (StatusBubble):
2703         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2704         on hover-over.
2705         (StatusBubble._iso_time):
2706         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2707         hover-over message.
2708         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2709
2710 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2711
2712         [ews-app] Gracefully handle the case when state_string is None
2713         https://bugs.webkit.org/show_bug.cgi?id=195753
2714
2715         Reviewed by Lucas Forschler.
2716
2717         * BuildSlaveSupport/ews-app/ews/models/build.py:
2718         * BuildSlaveSupport/ews-app/ews/models/step.py:
2719
2720 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2721
2722         [ews-app] Status bubble display pending for currently running build step
2723         https://bugs.webkit.org/show_bug.cgi?id=195744
2724
2725         Reviewed by Lucas Forschler.
2726
2727         * BuildSlaveSupport/ews-build/events.py:
2728         (Events.stepStarted): If state_string is pending, replace it with step name.
2729
2730 2019-03-14  Chris Dumez  <cdumez@apple.com>
2731
2732         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2733         https://bugs.webkit.org/show_bug.cgi?id=195750
2734
2735         Reviewed by Geoffrey Garen.
2736
2737         Add API test coverage.
2738
2739         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2740         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2741         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2742         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2743
2744 2019-03-14  Chris Dumez  <cdumez@apple.com>
2745
2746         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2747         https://bugs.webkit.org/show_bug.cgi?id=195747
2748
2749         Reviewed by Geoff Garen.
2750
2751         Add API test coverage.
2752
2753         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2754
2755 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2756
2757         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2758         https://bugs.webkit.org/show_bug.cgi?id=195725
2759         <rdar://problem/48545062>
2760
2761         Reviewed by Tim Horton.
2762
2763         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2764         handler is nil.
2765
2766         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2767         (TestWebKitAPI::TEST):
2768
2769 2019-03-13  Sam Weinig  <sam@webkit.org>
2770
2771         Add utility function to allow easy reverse range-based iteration of a container
2772         https://bugs.webkit.org/show_bug.cgi?id=195542
2773
2774         Reviewed by Antti Koivisto.
2775
2776         * TestWebKitAPI/CMakeLists.txt:
2777         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2778         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2779         (TestWebKitAPI::TEST):
2780         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2781
2782 2019-03-13  Chris Dumez  <cdumez@apple.com>
2783
2784         Use a ServiceWorker process per registrable domain
2785         https://bugs.webkit.org/show_bug.cgi?id=195649
2786
2787         Reviewed by Youenn Fablet.
2788
2789         Update API test coverage.
2790
2791         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2792
2793 2019-03-13  Chris Dumez  <cdumez@apple.com>
2794
2795         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2796         https://bugs.webkit.org/show_bug.cgi?id=195684
2797         <rdar://problem/48294714>
2798
2799         Reviewed by Antti Koivisto.
2800
2801         Add API test coverage.
2802
2803         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2804
2805 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2806
2807         [ews-app] Remove unused patch view
2808         https://bugs.webkit.org/show_bug.cgi?id=195669
2809
2810         Reviewed by Lucas Forschler.
2811
2812         * BuildSlaveSupport/ews-app/ews/urls.py:
2813         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2814
2815 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2816
2817         [ews-app] Use Buildbot result code variables
2818         https://bugs.webkit.org/show_bug.cgi?id=195668
2819
2820         Reviewed by Alexey Proskuryakov.
2821
2822         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2823         (Buildbot): Added Buildbot result code variables.
2824         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2825         (StatusBubble._build_bubble): Used Buildbot result code variables.
2826
2827 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2828
2829         [Flatpak] Expand submodule recursively
2830         https://bugs.webkit.org/show_bug.cgi?id=195672
2831
2832         Building WPE with flatpak was impossible without that as it was raising an exception.
2833         Also update wpebackend-fdo to match what is built in jhbuild
2834
2835         Reviewed by Philippe Normand.
2836
2837         * flatpak/flatpakutils.py:
2838         (expand_submodules_recurse):
2839         (expand_manifest):
2840         * flatpak/org.webkit.WPEModules.yaml:
2841
2842 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2843
2844         [ews-app] status bubble should be hidden for certain builds
2845         https://bugs.webkit.org/show_bug.cgi?id=194597
2846
2847         Reviewed by Dewei Zhu.
2848
2849         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2850         (StatusBubble._build_bubble):
2851         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2852         because the patch didn't have relevant changes.
2853         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2854         in production yet.
2855
2856 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2857
2858         [Win] Fix a slew of simple clang-cl warnings.
2859         https://bugs.webkit.org/show_bug.cgi?id=195652
2860
2861         Reviewed by Don Olmstead.
2862
2863         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2864         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2865
2866 2019-03-12  Justin Fan  <justin_fan@apple.com>
2867
2868         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2869         https://bugs.webkit.org/show_bug.cgi?id=195518
2870         <rdar://problem/46322356>
2871
2872         Reviewed by Myles C. Maxfield.
2873
2874         * DumpRenderTree/DerivedSources-input.xcfilelist:
2875         * DumpRenderTree/DerivedSources-output.xcfilelist:
2876
2877 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2878
2879         Unreviewed, rolling out r242825.
2880         https://bugs.webkit.org/show_bug.cgi?id=195648
2881
2882         "Broke webkitpy tests with my change to
2883         lldb_dump_class_layout.py" (Requested by rmorisset on
2884         #webkit).
2885
2886         Reverted changeset:
2887
2888         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2889         classes with suspicious padding"
2890         https://bugs.webkit.org/show_bug.cgi?id=195573
2891         https://trac.webkit.org/changeset/242825
2892
2893 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2894
2895         [ews-build] Show status bubbles while the patch is waiting in queue
2896         https://bugs.webkit.org/show_bug.cgi?id=195618
2897
2898         Reviewed by Lucas Forschler.
2899
2900         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2901         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2902         enabled in initial deployment.
2903         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2904         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2905         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2906         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2907         (StatusBubble._build_bubbles_for_patch):
2908
2909 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2910
2911         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2912         https://bugs.webkit.org/show_bug.cgi?id=195573
2913
2914         Reviewed by Simon Fraser.
2915
2916         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2917
2918         * Scripts/dump-class-layout:
2919         (main):
2920         * lldb/lldb_dump_class_layout.py:
2921         (ClassLayout.__init__):
2922         (ClassLayout._compute_padding_recursive):
2923         (LLDBDebuggerInstance.dump_layout_for_classname):
2924         (LLDBDebuggerInstance):
2925         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2926         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2927
2928 2019-03-12  Chris Dumez  <cdumez@apple.com>
2929
2930         Device Orientation access permission should be denied unless explicitly granted by the client
2931         https://bugs.webkit.org/show_bug.cgi?id=195625
2932
2933         Reviewed by Youenn Fablet.
2934
2935         add API test coverage.
2936
2937         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2938         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2939         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2940         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2941         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2942         (runDeviceOrientationTest):
2943         (TEST):
2944         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2945         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2946
2947 2019-03-12  Jer Noble  <jer.noble@apple.com>
2948
2949         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2950         https://bugs.webkit.org/show_bug.cgi?id=195137
2951         <rdar://problem/48810307>
2952
2953         Reviewed by Eric Carlson.
2954
2955         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2956         (TestWebKitAPI::TEST):
2957
2958 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2959
2960         [ews-build] Change urls from uat to production
2961         https://bugs.webkit.org/show_bug.cgi?id=195566
2962
2963         Reviewed by Lucas Forschler.
2964
2965         * BuildSlaveSupport/ews-app/ews/config.py:
2966         * BuildSlaveSupport/ews-build/events.py:
2967         * BuildSlaveSupport/ews-build/steps.py:
2968
2969 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2970
2971         [ews-build] change max_builds for local-worker to 1
2972         https://bugs.webkit.org/show_bug.cgi?id=195568
2973
2974         Reviewed by Lucas Forschler.
2975
2976         * BuildSlaveSupport/ews-build/loadConfig.py:
2977
2978 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2979
2980         Fix the build
2981
2982         * TestRunnerShared/spi/PencilKitTestSPI.h:
2983         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2984
2985 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2986
2987         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2988         https://bugs.webkit.org/show_bug.cgi?id=194131
2989
2990         Reviewed by Michael Catanzaro.
2991
2992         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2993         (uriChanged):
2994         (testUnfinishedSubresourceLoad):
2995         (serverCallback):
2996         (beforeAll):
2997
2998 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2999
3000         WTF::Expected should use std::addressof instead of operator&
3001         https://bugs.webkit.org/show_bug.cgi?id=195604
3002
3003         Reviewed by Myles Maxfield.
3004
3005         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3006         (TestWebKitAPI::Unique::Unique):
3007         (TestWebKitAPI::Unique::operator&):
3008         (TestWebKitAPI::TEST):
3009
3010 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3011
3012         Add Optional to Forward.h.
3013         https://bugs.webkit.org/show_bug.cgi?id=195586
3014
3015         Reviewed by Darin Adler.
3016
3017         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3018         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3019         Remove unnecessary includes from headers.
3020
3021 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3022
3023         Add testing API to hit-test and scroll overflow scrollers
3024         https://bugs.webkit.org/show_bug.cgi?id=195278
3025
3026         Reviewed by Antti Koivisto.
3027         
3028         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3029         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3030         
3031         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3032
3033         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3034         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3035         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3036         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3037         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3038         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3039         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3040         (WTR::enclosingScrollViewIncludingSelf):
3041         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3042
3043 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3044
3045         API test WebKit.RequestTextInputContext fails on iOS
3046         https://bugs.webkit.org/show_bug.cgi?id=195585
3047
3048         Reviewed by Wenson Hsieh and Simon Fraser.
3049
3050         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3051         (applyStyle):
3052         (TEST):
3053         Add a viewport, so that the coordinates match up on iOS.
3054         Scroll by moving the UIScrollView's contentOffset.
3055
3056 2019-03-11  Chris Dumez  <cdumez@apple.com>
3057
3058         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3059         https://bugs.webkit.org/show_bug.cgi?id=195506
3060         <rdar://problem/48733477>
3061
3062         Reviewed by Alex Christensen.
3063
3064         Add API test coverage.
3065
3066         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3067
3068 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3069
3070         Adding myself to contributors.json
3071
3072         Unreviewed, addming myself to contributors.json .
3073
3074         * Scripts/webkitpy/common/config/contributors.json:
3075
3076 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3077
3078         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3079         https://bugs.webkit.org/show_bug.cgi?id=195511
3080         <rdar://problem/44873269>
3081
3082         Reviewed by Darin Adler.
3083
3084         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3085         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3086         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3087         (TEST_F):
3088
3089 2019-03-11  Chris Dumez  <cdumez@apple.com>
3090
3091         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3092         https://bugs.webkit.org/show_bug.cgi?id=195561
3093
3094         Reviewed by Youenn Fablet.
3095
3096         Make sure the JS in the test requests for permission to receive device orientation events.
3097
3098         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3099
3100 2019-03-11  Youenn Fablet  <youenn@apple.com>
3101
3102         Allow storage quota increase by default in WTR
3103         https://bugs.webkit.org/show_bug.cgi?id=195541
3104
3105         Reviewed by Geoffrey Garen.
3106
3107         Allow storage quota increase by default in WTR.
3108         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3109         Use this for tests that explicitly need cache increase.
3110
3111         Instead of increasing quota by 2, make sure the next request is
3112         granted by adding all given parameters.
3113
3114         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3115         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3116         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3117         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3118         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3119         * WebKitTestRunner/TestController.cpp:
3120         (WTR::TestController::setAllowStorageQuotaIncrease):
3121         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3122         * WebKitTestRunner/TestController.h:
3123         * WebKitTestRunner/TestInvocation.cpp:
3124         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3125         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3126         (WTR::TestController::cocoaResetStateToConsistentValues):
3127         (WTR::TestController::setAllowStorageQuotaIncrease):
3128         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3129         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3130         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3131
3132 2019-03-11  Xan Lopez  <xan@igalia.com>
3133
3134         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3135         https://bugs.webkit.org/show_bug.cgi?id=194147
3136
3137         Reviewed by Michael Saboff.
3138
3139         To make --32-bit work correctly on Linux/64bit we need to:
3140
3141         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3142         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3143         unfortunately CMake only allows us to do this during
3144         crosscompilation, which is overkill here.
3145         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3146         pkg-config detection module uses the x86 .pc files instead of the
3147         x86_64 ones.
3148         - Set the -m32 flags for the compiler.
3149
3150         * Scripts/webkitdirs.pm:
3151         (generateBuildSystemFromCMakeProject):
3152
3153 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3154
3155         Add MotionMark-1.1 plan file for run-benchmark script.
3156         https://bugs.webkit.org/show_bug.cgi?id=195481
3157
3158         Rubber-stamped by Darin Adler.
3159
3160         Run-benchmark script should support MontionMark-1.1.
3161
3162         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3163
3164 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3165
3166         [ews-app] Add support for submit-to-ews url
3167         https://bugs.webkit.org/show_bug.cgi?id=195477
3168
3169         Reviewed by Lucas Forschler.
3170
3171         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3172         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3173         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3174         * BuildSlaveSupport/ews-app/ews/urls.py:
3175         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3176
3177 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3178
3179         Unreviewed, rolling out r242688, r242643, r242624.
3180
3181         Caused multiple layout test failures and crashes on iOS and macOS.
3182
3183         Reverted changeset:
3184
3185         "requestAnimationFrame should execute before the next frame"
3186         https://bugs.webkit.org/show_bug.cgi?id=177484
3187         https://trac.webkit.org/changeset/242624/webkit
3188
3189         * Tracing/SystemTracePoints.plist:
3190
3191 2019-03-11  John Wilander  <wilander@apple.com>
3192
3193         Resource Load Statistics: Make it possible exclude localhost from classification
3194         https://bugs.webkit.org/show_bug.cgi?id=195474
3195         <rdar://problem/47520577>
3196
3197         Reviewed by Brent Fulgham.
3198
3199         This patch allows for localhost to be excluded from classification and
3200         treatment as a prevalent resource.
3201
3202         The WebKit Tools change adds a new function called
3203         testRunner.setStatisticsIsRunningTest() which can be used to control this
3204         behavior.
3205
3206         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3207         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3208         (WTR::TestRunner::setStatisticsIsRunningTest):
3209         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3210         * WebKitTestRunner/TestController.cpp:
3211         (WTR::TestController::setStatisticsIsRunningTest):
3212         * WebKitTestRunner/TestController.h:
3213         * WebKitTestRunner/TestInvocation.cpp:
3214         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3215
3216 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3217
3218         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3219         https://bugs.webkit.org/show_bug.cgi?id=195560
3220
3221         Reviewed by Lucas Forschler.
3222
3223         * BuildSlaveSupport/ews-build/master.cfg:
3224
3225 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3226
3227         Unreviewed, rolling out r242698.
3228
3229         API test crashes on bots.
3230
3231         Reverted changeset:
3232
3233         "Add a WKContentRuleList variant that uses copied memory
3234         instead of mmap'd shared memory for class A containerized
3235         apps"
3236         https://bugs.webkit.org/show_bug.cgi?id=195511
3237         https://trac.webkit.org/changeset/242698
3238
3239 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3240
3241         [WPE] Enable web process sandbox
3242         https://bugs.webkit.org/show_bug.cgi?id=195169
3243
3244         Reviewed by Daniel Bates.
3245
3246         * wpe/install-dependencies:
3247         * wpe/jhbuild.modules:
3248
3249 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3250
3251         [ews-app] Use port 17000 for worker communication
3252         https://bugs.webkit.org/show_bug.cgi?id=195558
3253
3254         Reviewed by Lucas Forschler.
3255
3256         * BuildSlaveSupport/ews-build/master.cfg:
3257
3258 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3259
3260         [ews-build] unit-tests fail when passwords.json is missing
3261         https://bugs.webkit.org/show_bug.cgi?id=195557
3262
3263         Reviewed by Lucas Forschler.
3264
3265         * BuildSlaveSupport/ews-build/loadConfig.py:
3266         (loadBuilderConfig):
3267         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3268         (ConfigDotJSONTest.test_configuration):
3269         * BuildSlaveSupport/ews-build/master.cfg:
3270
3271 2019-03-11  Truitt Savell  <tsavell@apple.com>
3272
3273         Unreviewed, rolling out r242702.
3274
3275         Broke High Sierra builders.
3276
3277         Reverted changeset:
3278
3279         "Add utility function to allow easy reverse range-based
3280         iteration of a container"
3281         https://bugs.webkit.org/show_bug.cgi?id=195542
3282         https://trac.webkit.org/changeset/242702
3283
3284 2019-03-11  Sam Weinig  <sam@webkit.org>
3285
3286         Add utility function to allow easy reverse range-based iteration of a container
3287         https://bugs.webkit.org/show_bug.cgi?id=195542
3288
3289         Reviewed by Antti Koivisto.
3290
3291         * TestWebKitAPI/CMakeLists.txt:
3292         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3293         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3294         (TestWebKitAPI::TEST):
3295         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3296
3297 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3298
3299         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3300         https://bugs.webkit.org/show_bug.cgi?id=195511
3301         <rdar://problem/44873269>
3302
3303         Reviewed by Darin Adler.
3304
3305         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3306         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3307         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3308         (TEST_F):
3309
3310 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3311
3312         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3313         https://bugs.webkit.org/show_bug.cgi?id=195499
3314
3315         Reviewed by Darin Adler.
3316
3317         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3318         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3319         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3320         (-[WKWebView synchronouslyFocusTextInputContext:]):
3321         (applyStyle):
3322         (applyIframe):
3323         (TEST):
3324         Add some tests for this SPI.
3325
3326 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3327
3328         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3329         https://bugs.webkit.org/show_bug.cgi?id=181151
3330
3331         Reviewed by Don Olmstead.
3332
3333         * TestWebKitAPI/CMakeLists.txt:
3334         * TestWebKitAPI/PlatformWin.cmake:
3335         Enable TestWTF RunLoop tests in all platforms.
3336
3337         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3338         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3339         (TestWebKitAPI::DerivedOneShotTimer::fired):
3340         (TestWebKitAPI::TEST):
3341         Only a few platforms support nested RunLoop.
3342
3343         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3344         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3345
3346 2019-03-10  David Quesada  <david_quesada@apple.com>
3347
3348         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3349         https://bugs.webkit.org/show_bug.cgi?id=152480
3350
3351         Reviewed by Chris Dumez.
3352
3353         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3354         there are no additional references to the process pool besides the one held by
3355         the download, waits for the download to finish (in the sense that the
3356         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3357         measure, also check that the process pool has been deallocated at the end of the
3358         test. The test wouldn't be meaningful if the process pool were still alive.
3359
3360         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3361         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3362         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3363             The download will be canceled because the delegate does not implement the
3364             method to decide the download's destination, so this is where we know the
3365             DownloadProxyMap is done with the DownloadProxy.
3366         (TEST):
3367
3368 2019-03-08  Chris Dumez  <cdumez@apple.com>
3369
3370         Add support for Device Orientation / Motion permission API
3371         https://bugs.webkit.org/show_bug.cgi?id=195329
3372         <rdar://problem/47645367>
3373
3374         Reviewed by Geoffrey Garen.
3375
3376         Add test infrastructure to help test the Device Orientation / Motion permission API.
3377
3378         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3379         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3380         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3381         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3382         * WebKitTestRunner/TestController.cpp:
3383         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3384         (WTR::TestController::createWebViewWithOptions):
3385         (WTR::TestController::resetStateToConsistentValues):
3386         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3387         * WebKitTestRunner/TestController.h:
3388         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3389         * WebKitTestRunner/TestInvocation.cpp:
3390         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3391
3392 2019-03-08  Saam barati  <sbarati@apple.com>
3393
3394         Add a compare-results script to compare benchmark results
3395         https://bugs.webkit.org/show_bug.cgi?id=195486
3396         <rdar://problem/48723397>
3397
3398         Reviewed by Geoffrey Garen.
3399
3400         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3401         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3402         to extend it to learn about our other benchmarks.
3403
3404         * Scripts/compare-results: Added.
3405         (readJSONFile):
3406         (detectJetStream2):
3407         (JetStream2Results):
3408         (detectSpeedometer2):
3409         (Speedometer2Results):
3410         (detectPLT5):
3411         (PLT5Results):
3412         (detectBenchmark):
3413         (biggerIsBetter):
3414         (ttest):
3415         (getOptions):
3416         (main):
3417
3418 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3419
3420         Ensure old tab state is cleared between iterations of run-benchmark
3421         https://bugs.webkit.org/show_bug.cgi?id=195393
3422         <rdar://problem/46885583>
3423
3424         Reviewed by Dewei Zhu.
3425
3426         a) ensure the default to restore state is not set
3427         b) terminate Safari correctly
3428         c) Set the system default to ignore Persistent State in Safari
3429
3430         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3431         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3432         (OSXBrowserDriver.prepare_env): 
3433         (OSXBrowserDriver.restore_env):
3434         (OSXBrowserDriver.close_browsers):
3435         (OSXBrowserDriver._terminate_processes):
3436         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3437         (OSXChromeDriver):
3438         (OSXChromeCanaryDriver):
3439         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3440         (OSXFirefoxDriver):
3441         (OSXFirefoxNightlyDriver):
3442         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3443         (OSXSafariDriver):
3444         (OSXSafariDriver.prepare_env):
3445
3446 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3447
3448         [GTK] Several InputMethodFilter tests are failing
3449         https://bugs.webkit.org/show_bug.cgi?id=195408
3450
3451         Reviewed by Carlos Garcia Campos.
3452
3453         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3454         Regressed in r241751.
3455         Hexadecimal values of keycodes are expressed now in upper letters.
3456         Composited characters should be cast to UTF8 strings.
3457
3458         (TestWebKitAPI::TEST):
3459
3460 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3461
3462         [GTK] Make Tools/gtkdoc python3 compatible
3463         https://bugs.webkit.org/show_bug.cgi?id=195359
3464
3465         Reviewed by Carlos Garcia Campos.
3466
3467         * gtkdoc/generate-gtkdoc:
3468         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3469         work with Python 2 and 3.
3470         (get_gtkdoc_module_paths):
3471         The iteritems() was removed in Python 3, so let's use items() that's
3472         available in Python 2 and 3.
3473         (get_generator_for_config):
3474         * gtkdoc/gtkdoc.py:
3475         (GTKDoc._run_command):
3476         The sys.stdout.write() is expecting str in Python 3 and not bytes
3477         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3478         for passing the bytes there.
3479
3480 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3481
3482         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3483         https://bugs.webkit.org/show_bug.cgi?id=195346
3484         <rdar://problem/48667048>
3485
3486         Unreviewed build fix for clang-cl.
3487
3488         * DumpRenderTree/win/DumpRenderTree.cpp:
3489         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3490
3491 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3492
3493         requestAnimationFrame should execute before the next frame
3494         https://bugs.webkit.org/show_bug.cgi?id=177484
3495
3496         Reviewed by Simon Fraser.
3497
3498         Add trace points for the page RenderingUpdate.
3499
3500         * Tracing/SystemTracePoints.plist:
3501
3502 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3503
3504         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3505         https://bugs.webkit.org/show_bug.cgi?id=195353
3506         <rdar://problem/48626394>
3507
3508         Reviewed by Simon Fraser.
3509
3510         * WebKitTestRunner/ios/TestControllerIOS.mm:
3511         (WTR::TestController::platformResetPreferencesToConsistentValues):
3512
3513 2019-03-07  John Wilander  <wilander@apple.com>
3514
3515         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3516         https://bugs.webkit.org/show_bug.cgi?id=195383
3517         <rdar://problem/48570136>
3518
3519         Reviewed by Brent Fulgham.
3520
3521         This patch adds test infrastructure to purge only script-accessible cookies,
3522         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3523
3524         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3525         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3526         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3527         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3528         * WebKitTestRunner/TestController.cpp:
3529         (WTR::TestController::statisticsDeleteCookiesForHost):
3530         * WebKitTestRunner/TestController.h:
3531         * WebKitTestRunner/TestInvocation.cpp:
3532         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3533
3534 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3535
3536         Unreviewed, rolling out r242354.
3537         https://bugs.webkit.org/show_bug.cgi?id=195402
3538
3539         breaks layout tests in all configurations (Requested by
3540         zdobersek on #webkit).
3541
3542         Reverted changeset:
3543
3544         "[WPE] Enable web process sandbox"
3545         https://bugs.webkit.org/show_bug.cgi?id=195169
3546         https://trac.webkit.org/changeset/242354
3547
3548 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3549
3550         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3551         https://bugs.webkit.org/show_bug.cgi?id=195346
3552
3553         Reviewed by Fujii Hironori.
3554
3555         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3556         (TestWebKitAPI::TEST):
3557         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3558
3559         * DumpRenderTree/win/DumpRenderTree.cpp:
3560         (findFontFallback):
3561         (addFontFallbackIfPresent):
3562         (removeFontFallbackIfPresent):
3563         (main):
3564         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3565         (TestWebKitAPI::Util::moduleDirectory):
3566         (TestWebKitAPI::Util::createInjectedBundlePath):
3567         Use wchar helpers as needed.
3568
3569 2019-03-06  Rob Buis  <rbuis@igalia.com>
3570
3571         Consider supporting the `referrerpolicy` attribute.
3572         https://bugs.webkit.org/show_bug.cgi?id=179053
3573
3574         Reviewed by Darin Adler.
3575
3576         Add a runtime flag for referrerpolicy attribute.
3577
3578         * DumpRenderTree/mac/DumpRenderTree.mm:
3579         (enableExperimentalFeatures):
3580
3581 2019-03-05  Daniel Bates  <dabates@apple.com>
3582
3583         Update expected API test result following r242379
3584         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3585
3586         Update expected x-coordinate of selection rect now that the left padding of
3587         a textarea is sized in ems (so dependent on the font size) just like the left
3588         padding of a text field.
3589
3590         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3591         (TestWebKitAPI::TEST):
3592
3593 2019-03-05  David Quesada  <david_quesada@apple.com>
3594
3595         [WK2] It should be possible to follow links with 'download' attributes
3596         https://bugs.webkit.org/show_bug.cgi?id=195145
3597         rdar://problem/48462642
3598
3599         Reviewed by Alex Christensen.
3600
3601         Add a unit test to verify that activating links with 'download' attributes now
3602         navigates to the linked resource, rather than starts downloading it. Add another
3603         to verify that it is still possible to explicitly download the link via the
3604         'Download' navigation action policy.
3605
3606         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3607         (-[DownloadAttributeTestDelegate init]):
3608         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3609         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3610         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3611         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3612         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3613         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3614         (TEST):
3615         * WebKitTestRunner/TestController.cpp:
3616         (WTR::TestController::decidePolicyForNavigationAction):
3617         * WebKitTestRunner/TestController.h:
3618
3619 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3620
3621         [Curl] Implement Cookie Accept Policy.
3622         https://bugs.webkit.org/show_bug.cgi?id=191645
3623
3624         Reviewed by Fujii Hironori.
3625
3626         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3627         (TestWebKitAPI::Curl::TEST_F):
3628
3629 2019-03-05  Youenn Fablet  <youenn@apple.com>
3630
3631         Rename requestCacheStorageSpace to requestStorageSpace
3632         https://bugs.webkit.org/show_bug.cgi?id=195282
3633
3634         Reviewed by Chris Dumez.
3635
3636         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3637         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3638         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3639
3640 2019-03-05  Brady Eidson  <beidson@apple.com>
3641
3642         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3643         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3644
3645         Reviewed by Tim Horton.
3646
3647         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3648         different directory into that same WKWebView should work.
3649
3650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3651         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3652
3653 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3654
3655         Add WeakHashSet
3656         https://bugs.webkit.org/show_bug.cgi?id=195152
3657
3658         Reviewed by Antti Koivisto.
3659
3660         Added tests for WeakHashSet.
3661
3662         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3663         (TestWebKitAPI::Base::Base): Moved.
3664         (TestWebKitAPI::Derived::foo): Moved.
3665         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3666         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3667         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3668         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3669
3670 2019-03-04  Chris Dumez  <cdumez@apple.com>
3671
3672         Do not share WebProcesses between private and regular sessions
3673         https://bugs.webkit.org/show_bug.cgi?id=195189
3674         <rdar://problem/48421064>
3675
3676         Reviewed by Alex Christensen.
3677
3678         Add API test coverage.
3679
3680         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3681         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3682
3683 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3684
3685         [WPE] Enable web process sandbox
3686         https://bugs.webkit.org/show_bug.cgi?id=195169
3687
3688         Reviewed by Daniel Bates.
3689
3690         * wpe/install-dependencies:
3691         * wpe/jhbuild.modules:
3692
3693 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3694
3695         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3696         https://bugs.webkit.org/show_bug.cgi?id=195206
3697
3698         Reviewed by Žan Doberšek.
3699
3700         Add a new test case.
3701
3702         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3703         (testJSCClass):
3704
3705 2019-03-04  Charlie Turner  <cturner@igalia.com>
3706
3707         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3708         https://bugs.webkit.org/show_bug.cgi?id=194898
3709
3710         Reviewed by Žan Doberšek.
3711
3712         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3713         a GCC extension that permits arithmetic on void* pointer. Inline
3714         the macro until this issue is fixed upstream.
3715
3716 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3717
3718         Rid the world of WK_API_ENABLED
3719         https://bugs.webkit.org/show_bug.cgi?id=195263
3720
3721         Reviewed by Dan Bernstein.
3722
3723         List of changed files elided because it's useless.
3724
3725 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3726
3727         Unreviewed follow-up to r242292.
3728
3729         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3730
3731         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3732         (TestWebKitAPI::testStrip): Renamed from strip.
3733         (TestWebKitAPI::TEST):
3734
3735 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3736
3737         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3738
3739         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3740         and bug #194272 for details.
3741
3742         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3743
3744 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3745
3746         Remove some more unused 32-bit code
3747         https://bugs.webkit.org/show_bug.cgi?id=195255
3748
3749         Reviewed by Darin Adler.
3750
3751         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3752         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3753         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3754         (NPP_New):
3755         (NPP_HandleEvent):
3756         (handleEventCarbon): Deleted.
3757
3758 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3759
3760         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3761
3762         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3763         (TestWebKitAPI::TEST):
3764
3765 2019-03-01  Darin Adler  <darin@apple.com>
3766
3767         Finish removing String::format
3768         https://bugs.webkit.org/show_bug.cgi?id=194893
3769
3770         Reviewed by Daniel Bates.
3771 '
3772         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3773
3774 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3775
3776         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3777         https://bugs.webkit.org/show_bug.cgi?id=195229
3778         <rdar://problem/48520362>
3779
3780         Reviewed by Chris Dumez.
3781
3782         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3783         (TEST):
3784
3785 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3786
3787         Add a system trace scope for event region building
3788         https://bugs.webkit.org/show_bug.cgi?id=195226
3789
3790         Reviewed by Jon Lee.
3791
3792         This trace scope measures the time spend converting element rects into Region objects,
3793         which can be large on some pages.
3794
3795         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3796
3797         * Tracing/SystemTracePoints.plist:
3798
3799 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3800
3801         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3802         https://bugs.webkit.org/show_bug.cgi?id=194612
3803
3804         Reviewed by Alex Christensen.
3805
3806         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3807         Just test the new string-processing function and don't touch the actual environment.
3808         (Test cases are all as before, but based on operator== instead of strcmp.)
3809
3810 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3811
3812         [ews-app] Update primary keys for handling multiple Buildbot instances
3813         https://bugs.webkit.org/show_bug.cgi?id=195120
3814
3815         Reviewed by Stephanie Lewis.
3816
3817         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3818         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3819         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3820
3821         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3822         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3823         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3824         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3825         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3826         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3827
3828 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3829
3830         [WinCairo] Enable service worker
3831         https://bugs.webkit.org/show_bug.cgi?id=188318
3832
3833         Reviewed by Youenn Fablet.
3834
3835         * DumpRenderTree/DumpRenderTreePrefix.h:
3836         * TestWebKitAPI/PlatformWin.cmake:
3837         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3838         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3839         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3840
3841 2019-03-01  Justin Fan  <justin_fan@apple.com>
3842
3843         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3844         https://bugs.webkit.org/show_bug.cgi?id=195191
3845
3846         Rubber-stamped by Dean Jackson.
3847
3848         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3849
3850         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3851
3852 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3853
3854         Unreviewed, fix lldb webkitpy tests
3855         https://bugs.webkit.org/show_bug.cgi?id=194375
3856
3857         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3858
3859         * lldb/lldb_webkit.py:
3860         (WTFStringImplProvider.is_8bit):
3861
3862 2019-02-28  David Quesada  <david_quesada@apple.com>
3863
3864         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3865         https://bugs.webkit.org/show_bug.cgi?id=195121
3866         rdar://problem/48450302
3867
3868         Reviewed by Alex Christensen.
3869
3870         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3871         configurations where the 'download' attribute is absent, blank, or populated
3872         with a filename, and where the anchor element is same-origin or cross-origin
3873         (meaning the 'download' attribute shouldn't be honored).
3874
3875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3876         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3877         (-[NavigationActionTestDelegate init]):
3878         (-[NavigationActionTestDelegate navigationAction]):
3879         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3880         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3881         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3882         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3883         (TEST):
3884
3885 2019-02-28  Antoine Quint  <graouts@apple.com>
3886
3887         Enable the Pointer Events runtime flag by default
3888         https://bugs.webkit.org/show_bug.cgi?id=195156
3889
3890         Reviewed by Dean Jackson.
3891
3892         * DumpRenderTree/mac/DumpRenderTree.mm:
3893         (enableExperimentalFeatures):
3894
3895 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3896
3897         Several PasteImage API tests are flaky
3898         https://bugs.webkit.org/show_bug.cgi?id=195160
3899
3900         Reviewed by Tim Horton.
3901
3902         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3903         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3904         listening for a "load" event after image load is already complete.
3905
3906         To address this, make these tests first register a "load" event handler, then run script to insert an image
3907         element into the document, and finally wait until the load event is observed before checking image size.
3908
3909         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3910
3911 2019-02-28  Chris Dumez  <cdumez@apple.com>
3912
3913         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3914         https://bugs.webkit.org/show_bug.cgi?id=195107
3915
3916         Reviewed by Alex Christensen.
3917
3918         Give some time for the zoom level to get restored.
3919
3920         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3921
3922 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3923
3924         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3925         https://bugs.webkit.org/show_bug.cgi?id=194958
3926
3927         Reviewed by Geoffrey Garen.
3928
3929         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3930         (TEST):
3931
3932 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3933
3934         [ews-app] Update method to save build to handle builder_display_name
3935         https://bugs.webkit.org/show_bug.cgi?id=195047
3936
3937         Reviewed by Dewei Zhu.
3938
3939         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3940         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3941
3942 2019-02-28  Justin Fan  <justin_fan@apple.com>
3943
3944         [Web GPU] Enable Web GPU only on 64-bit
3945         https://bugs.webkit.org/show_bug.cgi?id=195139
3946
3947         Because Metal is only supported on 64 bit apps.
3948
3949         Unreviewed build fix.
3950
3951         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3952
3953 2019-02-27  Youenn Fablet  <youenn@apple.com>
3954
3955         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3956         https://bugs.webkit.org/show_bug.cgi?id=194959
3957
3958         Reviewed by Chris Dumez.
3959
3960         Spin loop until getting the condition to remove flakiness.
3961
3962         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3963
3964 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3965
3966         [ews-build] Buildbot should include builder_display_name in the build events
3967         https://bugs.webkit.org/show_bug.cgi?id=195045
3968
3969         Reviewed by Dewei Zhu.
3970
3971         * BuildSlaveSupport/ews-build/events.py:
3972         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3973         buildername to builder_name to be consistent in naming style.
3974         (Events.buildFinished): Ditto.
3975
3976 2019-02-27  Chris Dumez  <cdumez@apple.com>
3977
3978         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3979         https://bugs.webkit.org/show_bug.cgi?id=194480
3980
3981         Reviewed by Brady Eidson.
3982
3983         Update existing API test to make it more likely to reproduce the issue.
3984
3985         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3986
3987 2019-02-27  Brady Eidson  <beidson@apple.com>
3988
3989         Universal links from Google search results pages don't open the app.
3990         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3991
3992         Reviewed by Geoffrey Garen.
3993
3994         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3995         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3996         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3997         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3998
3999 2019-02-27  Chris Dumez  <cdumez@apple.com>
4000
4001         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4002         https://bugs.webkit.org/show_bug.cgi?id=195102
4003
4004         Reviewed by Geoffrey Garen.
4005
4006         If the number of processes is not yet what we expect, wait a bit and check again to give
4007         processes some time to exit.
4008
4009         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4010
4011 2019-02-27  Chris Dumez  <cdumez@apple.com>
4012
4013         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4014         https://bugs.webkit.org/show_bug.cgi?id=194545
4015
4016         Reviewed by Brady Eidson.
4017
4018         Make sure the test navigates forward and then back only once. Previously, navigating
4019         back would trigger a navigation again in a timer.
4020
4021         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4022
4023 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4024
4025         High Sierra Debug JSC test queue should use faster hardware
4026         https://bugs.webkit.org/show_bug.cgi?id=194603
4027
4028         Rubber-stamped by Alexey Proskuryakov.
4029
4030         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4031
4032         * BuildSlaveSupport/build.webkit.org-config/config.json:
4033         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4034         (BubbleQueueServer):
4035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4036         (WebKitBuildbot):
4037         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4038         * QueueStatusServer/config/queues.py:
4039         * Scripts/webkitpy/common/config/ews.json:
4040         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4041         (test_ews_name):
4042
4043 2019-02-27  John Wilander  <wilander@apple.com>
4044
4045         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4046         https://bugs.webkit.org/show_bug.cgi?id=195071
4047         <rdar://problem/48417690>
4048
4049         Reviewed by Alex Christensen and Brent Fulgham.
4050
4051         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4052         (TestWebKitAPI::createURL):
4053             Convenience function.
4054         (TestWebKitAPI::TEST):
4055             WebCore::AdClickAttribution now takes a URL when creating Source and
4056             Destination.
4057         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4058         (TestWebKitAPI::TEST):
4059             WebCore::AdClickAttribution now takes a URL when creating Source and
4060             Destination.
4061
4062 2019-02-27  Antoine Quint  <graouts@apple.com>
4063
4064         Support Pointer Events on macOS
4065         https://bugs.webkit.org/show_bug.cgi?id=195008
4066         <rdar://problem/47454419>
4067
4068         Reviewed by Dean Jackson.
4069
4070         * DumpRenderTree/mac/DumpRenderTree.mm:
4071         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4072         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4073
4074 2019-02-26  Mark Lam  <mark.lam@apple.com>
4075
4076         Remove remaining poisoning code.
4077         https://bugs.webkit.org/show_bug.cgi?id=194138
4078
4079         Reviewed by Saam Barati.
4080
4081         * TestWebKitAPI/CMakeLists.txt:
4082         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4083         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4084         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4085         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4086         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4087         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4088         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4089
4090 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4091
4092         Move ephemeral local storage from WebProcess to UIProcess
4093         https://bugs.webkit.org/show_bug.cgi?id=195074
4094         <rdar://problem/47937975>
4095
4096         Reviewed by Geoff Garen.
4097
4098         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4099
4100 2019-02-20  Jer Noble  <jer.noble@apple.com>
4101
4102         [Cocoa] Media elements will restart network buffering just before suspending
4103         https://bugs.webkit.org/show_bug.cgi?id=193691
4104
4105         Reviewed by Eric Carlson.
4106
4107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4108         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4109         (TEST):
4110
4111 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4112
4113         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4114         https://bugs.webkit.org/show_bug.cgi?id=191652
4115
4116         Reviewed by Alex Christensen.
4117
4118         Fix WinCairo MiniBrowser behavior of authentication dialog.
4119
4120         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4121         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4122
4123 2019-02-26  Youenn Fablet  <youenn@apple.com>
4124
4125         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4126         https://bugs.webkit.org/show_bug.cgi?id=195028
4127         <rdar://problem/48243733>
4128
4129         Reviewed by Eric Carlson.
4130
4131         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4132
4133 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4134
4135         [WPE] Add API for webview background color configuration
4136         https://bugs.webkit.org/show_bug.cgi?id=192305
4137
4138         Reviewed by Michael Catanzaro.
4139
4140         * MiniBrowser/wpe/main.cpp:
4141         (main): Add a new option to configure the webview background
4142         color. Example: --bg-color=transparent.
4143         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4144         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4145         (beforeAll): Ditto.
4146
4147 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4148
4149         scalableNativeWebpageParameters() is not preserved on new page navigation.
4150         https://bugs.webkit.org/show_bug.cgi?id=194892
4151         <rdar://problem/47538280>
4152
4153         Reviewed by Wenson Hsieh.
4154         
4155         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4156
4157         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4158         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4159         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4160         (WTR::UIScriptController::allowsViewportShrinkToFit):
4161         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4162         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4163         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4164         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4165         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4166         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4167
4168 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4169
4170         [ews-app] Add model for handling multiple Buildbot instances
4171         https://bugs.webkit.org/show_bug.cgi?id=194863
4172
4173         Reviewed by Stephanie Lewis.
4174
4175         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4176
4177 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4178
4179         [ews-app] Remove BuilderMapping table
4180         https://bugs.webkit.org/show_bug.cgi?id=194961
4181
4182         Reviewed by Stephanie Lewis.
4183
4184         Store builder name directly in build table, instead of having a separate
4185         table for it.
4186
4187         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4188         * BuildSlaveSupport/ews-app/ews/models/build.py:
4189         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4190         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4191
4192 2019-02-25  John Wilander  <wilander@apple.com>
4193
4194         Introduce and adopt new class RegistrableDomain for eTLD+1
4195         https://bugs.webkit.org/show_bug.cgi?id=194791
4196         <rdar://problem/48179240>
4197
4198         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4199
4200         This patch adds an API test and replaces two instances of
4201         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4202
4203         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4204         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4205         (TestWebKitAPI::TEST):
4206             Changed two strings to make sure the registrable domains are still considered
4207             invalid and pass the test.
4208         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4209         (TestWebKitAPI::TEST):
4210         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4211         (WTR::InjectedBundle::didReceiveMessageToPage):
4212
4213 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4214
4215         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4216         https://bugs.webkit.org/show_bug.cgi?id=195001
4217
4218         Reviewed by Carlos Garcia Campos.
4219
4220         API version 1.0 always includes the functionality previously guarded with
4221         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4222         unconditionally.
4223
4224         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4225         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4226         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4227         (WebViewTest::showInWindow): Ditto.
4228         (WebViewTest::hideView): Ditto.
4229         * wpe/backends/HeadlessViewBackend.cpp:
4230         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4231         * wpe/backends/ViewBackend.cpp:
4232         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4233         * wpe/backends/WindowViewBackend.cpp:
4234         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4235         WPE_BACKEND_CHECK_VERSION().
4236         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4237
4238 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4239
4240         [Flatpak] Add support for flatpak > 1.1.2
4241         https://bugs.webkit.org/show_bug.cgi?id=194088
4242
4243         Flatpak 1.2 is now out so we need to support that
4244         version now.
4245
4246         Reviewed by Michael Catanzaro.
4247
4248         * flatpak/flatpakutils.py:
4249         (check_flatpak):
4250         (FlatpakPackages.__init__):
4251         (FlatpakPackages.__detect_packages):
4252         (FlatpakPackages.__detect_packages.in):
4253         (FlatpakRepos.update):
4254
4255 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4256
4257         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4258         https://bugs.webkit.org/show_bug.cgi?id=194998
4259
4260         Reviewed by Carlos Garcia Campos.
4261
4262         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4263         to a Git checkout and using the latest commit containing various fixes
4264         and improvements.
4265
4266 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4267
4268         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4269         https://bugs.webkit.org/show_bug.cgi?id=194981
4270
4271         Reviewed by Žan Doberšek.
4272
4273         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4274         (TestWebKitAPI::TEST):
4275
4276 2019-02-23  Keith Miller  <keith_miller@apple.com>
4277
4278         Add new mac target numbers
4279         https://bugs.webkit.org/show_bug.cgi?id=194955
4280
4281         Reviewed by Tim Horton.
4282
4283         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4284         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4285         * MiniBrowser/Configurations/Base.xcconfig:
4286         * TestWebKitAPI/Configurations/Base.xcconfig:
4287         * WebKitTestRunner/Configurations/Base.xcconfig:
4288
4289 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4290
4291         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4292         https://bugs.webkit.org/show_bug.cgi?id=194846
4293
4294         Reviewed by Don Olmstead.
4295
4296         Added _search_paths() and _port_specific_expectations_files() for
4297         WinCairoPort.
4298
4299         * Scripts/webkitpy/port/win.py:
4300         (WinCairoPort.default_baseline_search_path):
4301         (WinCairoPort):
4302         (WinCairoPort._port_specific_expectations_files):
4303         (WinCairoPort._search_paths):
4304
4305 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4306
4307         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4308         https://bugs.webkit.org/show_bug.cgi?id=194963
4309
4310         Reviewed by Dean Jackson.
4311
4312         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4313         Do a `contains` check instead of `equals`, because in debug builds we
4314         put the GraphicsLayer pointer in a prefix.
4315
4316 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4317
4318         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4319         https://bugs.webkit.org/show_bug.cgi?id=194873
4320         <rdar://problem/46701974>
4321
4322         Reviewed by Tim Horton.
4323
4324         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4325
4326         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4327         (WTR::UIScriptController::menuRect const):
4328         (WTR::UIScriptController::isShowingMenu const):
4329         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4330         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4331         (WTR::UIScriptController::menuRect const):
4332
4333         Add a function to query the bounds of the callout menu in content coordinates.
4334
4335         (WTR::UIScriptController::isShowingMenu const):
4336
4337         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4338
4339         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4340         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4341         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4342         (WTR::UIScriptController::rectForMenuAction const):
4343         (WTR::UIScriptController::menuRect const):
4344         (WTR::UIScriptController::isShowingMenu const):
4345         (WTR::findViewInHierarchyOfType): Deleted.
4346
4347 2019-02-22  Chris Dumez  <cdumez@apple.com>
4348
4349         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4350         https://bugs.webkit.org/show_bug.cgi?id=194954
4351         <rdar://problem/48127957>
4352
4353         Reviewed by Alex Christensen.
4354
4355         Add API test coverage.
4356
4357         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4358         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4359         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4360         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4361
4362 2019-02-22  Chris Dumez  <cdumez@apple.com>
4363
4364         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4365         https://bugs.webkit.org/show_bug.cgi?id=194924
4366      &n