API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
4         https://bugs.webkit.org/show_bug.cgi?id=196905
5         <rdar://problem/49886096>
6
7         Reviewed by Tim Horton.
8
9         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
10         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
11         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
12         delay timer, we end up with this sequence of events in the problematic (failure) case:
13
14         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
15             ...IPC from UI to web process...
16         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
17             ...IPC from web to UI process...
18         (c) [UI]    Invoke completion handler for script #1
19         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
20             ...IPC from UI to web process...
21         (e) [Web]   Evaluate script #2 in the web process
22         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
23
24         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
25         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
26         #2 is run in step (e).
27
28         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
29         the UI process by waiting on a script message posted by the web process, after attachment updates are
30         dispatched.
31
32         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
33         (TestWebKitAPI::TEST):
34
35 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
36
37         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
38         https://bugs.webkit.org/show_bug.cgi?id=196909
39
40         Reviewed by Wenson Hsieh.
41
42         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
43         (TestWebKitAPI::TEST):
44
45 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
46
47         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
48         https://bugs.webkit.org/show_bug.cgi?id=196880
49
50         Reviewed by Yusuke Suzuki.
51
52         Add a new function for bytecode cache tests that does not forceDiskCache
53         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
54         test added in this patch, since the code is invalid and therefore won't be
55         cached. It should also be useful for tests that evaluate dynamically
56         generated code.
57
58         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
59         * Scripts/run-jsc-stress-tests:
60
61 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
62
63         Update AudioSession route sharing policy
64         https://bugs.webkit.org/show_bug.cgi?id=196776
65         <rdar://problem/46501611>
66
67         Reviewed by Jer Noble.
68
69         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
70         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
71         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
72         (TestWebKitAPI::TEST):
73
74 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
75
76         [iOS] Software keyboard is shown too frequently on some websites
77         https://bugs.webkit.org/show_bug.cgi?id=195856
78         <rdar://problem/49191395>
79
80         Reviewed by Darin Adler.
81
82         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
83
84         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
85         (WTR::UIScriptController::setHardwareKeyboardAttached):
86         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
87         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
88         (WTR::UIScriptController::setHardwareKeyboardAttached):
89         * TestRunnerShared/UIScriptContext/UIScriptController.h:
90         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
91
92         Additionally link against GraphicsServices in WebKitTestRunner.
93
94         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
95         (WTR::TestController::platformResetStateToConsistentValues):
96         (WTR::UIScriptController::setHardwareKeyboardAttached):
97
98 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
99
100         [GTK][WPE] Fix pacman install-dependencies packages
101         https://bugs.webkit.org/show_bug.cgi?id=196817
102
103         Reviewed by Žan Doberšek.
104         
105         python3-setuptools is called python-setuptools
106         ruby-highline is only available on AUR
107         libv4l-devel is incorporated in v4l-utils
108
109         * gtk/install-dependencies:
110         * wpe/install-dependencies:
111
112 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
113
114         [GTK] REGRESSION(r243860): Many tests failing
115         https://bugs.webkit.org/show_bug.cgi?id=196791
116
117         Reviewed by Joanmarie Diggs.
118
119         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
120         multiple documents and check that accessibility hierarchy is updated after a navigation.
121
122         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
123         (loadChangedCallback):
124         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
125         (AccessibilityTest::AccessibilityTest):
126         (AccessibilityTest::~AccessibilityTest):
127         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
128         (AccessibilityTest::findTestServerApplication):
129         (AccessibilityTest::findDocumentWeb):
130         (AccessibilityTest::findRootObject):
131         (AccessibilityTest::waitUntilChildrenRemoved):
132         (AccessibilityTest::ensureProxy):
133         (testAtspiBasicHierarchy):
134         (beforeAll):
135         (afterAll):
136
137 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
138
139         [ews-build] Handle bug titles with unicode characters
140         https://bugs.webkit.org/show_bug.cgi?id=196802
141
142         Reviewed by Dewei Zhu.
143
144         * BuildSlaveSupport/ews-build/steps.py:
145         (ValidatePatch._is_bug_closed):
146
147 2019-04-11  Michael Saboff  <msaboff@apple.com>
148
149         Improve the Inline Cache Stats code
150         https://bugs.webkit.org/show_bug.cgi?id=196836
151
152         Reviewed by Saam Barati.
153
154         Added a new script to consolidate and arrange the output of --useICStats option.
155
156         This script merges the output from every group into one large table and sorts it from most common to
157         least common.  It also counts the slow path GetById and PutById variants and then calculates the
158         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
159         Put together, this is useful to see what property accesses are not getting cached.
160
161         * Scripts/ic-stats.py: Added.
162         (ICStats):
163         (ICStats.__init__):
164         (ICStats.parse):
165         (ICStats.dumpStats):
166         (usage):
167
168 2019-04-10  Alex Christensen  <achristensen@webkit.org>
169
170         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
171         https://bugs.webkit.org/show_bug.cgi?id=196809
172         <rdar://49800762>
173
174         Reviewed by Brady Eidson.
175
176         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
177         (TEST):
178
179 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
180
181         requestAnimationFrame should execute before the next frame
182         https://bugs.webkit.org/show_bug.cgi?id=177484
183
184         Reviewed by Simon Fraser.
185
186         Add trace points for the page RenderingUpdate.
187
188         * Tracing/SystemTracePoints.plist:
189
190 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
191
192         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
193         https://bugs.webkit.org/show_bug.cgi?id=196760
194
195         Reviewed by Don Olmstead.
196
197         vswhere.exe has been bundled since Visual Studio 2017 version
198         15.2. We shouldn't download vswhere.exe.
199
200         * Scripts/build-jsc: Do not call update-vswhere.py.
201         * Scripts/build-webkit: Ditto.
202         * Scripts/update-vswhere.py: Removed.
203         * Scripts/webkitdirs.pm:
204         (requireModulesForVSWhere): Deleted.
205         (pickCurrentVisualStudioInstallation): Deleted.
206         (visualStudioInstallDirVSWhere): Return the latest installed VS
207         installation path by using the bundled vswhere.exe.
208         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
209         (visualStudioInstallDirFallback): Removed.
210
211 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
212
213         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
214         https://bugs.webkit.org/show_bug.cgi?id=196780
215
216         Reviewed by Alexey Proskuryakov.
217
218         * BuildSlaveSupport/ews-build/steps.py:
219         * BuildSlaveSupport/ews-build/steps_unittest.py:
220
221 2019-04-10  Alex Christensen  <achristensen@webkit.org>
222
223         Add SPI WKNavigationResponse._downloadAttribute
224         https://bugs.webkit.org/show_bug.cgi?id=196755
225         <rdar://49587365>
226
227         Reviewed by Brady Eidson.
228
229         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
230         (-[NavigationResponseTestDelegate navigationResponse]):
231         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
232         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
233         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
234         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
235         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
236         (readRequest):
237         (writeResponse):
238         (TEST):
239
240 2019-04-10  Tim Horton  <timothy_horton@apple.com>
241
242         Add modern API for overriding the page's specified viewport configuration
243         https://bugs.webkit.org/show_bug.cgi?id=167734
244         <rdar://problem/30331795>
245
246         Reviewed by Simon Fraser.
247
248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
249         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
250
251 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
252
253         Add support for incremental bytecode cache updates
254         https://bugs.webkit.org/show_bug.cgi?id=195000
255
256         Reviewed by Filip Pizlo.
257
258         Exit when the initial run to generate bytecode fails.
259
260         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
261
262 2019-04-10  Alex Christensen  <achristensen@webkit.org>
263
264         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
265         https://bugs.webkit.org/show_bug.cgi?id=196744
266         <rdar://49415309>
267
268         Reviewed by Chris Dumez.
269
270         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
271         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
272
273 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
274
275         Add a way to opt into modern compatibility mode in layout tests
276         https://bugs.webkit.org/show_bug.cgi?id=196770
277         <rdar://problem/49777550>
278
279         Reviewed by Antoine Quint.
280
281         Add a new test option to enable modern compatibility mode in layout tests.
282
283         * WebKitTestRunner/TestController.cpp:
284         (WTR::updateTestOptionsFromTestHeader):
285         * WebKitTestRunner/TestController.h:
286         * WebKitTestRunner/TestOptions.h:
287         (WTR::TestOptions::hasSameInitializationOptions const):
288         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
289         (WTR::TestController::platformCreateWebView):
290         (WTR::TestController::enableModernCompatibilityMode):
291
292 2019-04-10  Andy Estes  <aestes@apple.com>
293
294         Try to fix the 32-bit watchOS build.
295
296         * TestWebKitAPI/cocoa/TestWKWebView.mm:
297         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
298
299 2019-04-10  Antoine Quint  <graouts@apple.com>
300
301         Enable Pointer Events on watchOS
302         https://bugs.webkit.org/show_bug.cgi?id=196771
303         <rdar://problem/49040909>
304
305         Reviewed by Dean Jackson.
306
307         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
308
309 2019-04-10  Philippe Normand  <pnormand@igalia.com>
310
311         Unreviewed. Fix WPE accessibility tests after r244059.
312
313         We are failing to load the injected bundle due to undefined symbol
314         AccessibilityUIElement::replaceTextInRange().
315
316         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
317         (WTR::AccessibilityUIElement::replaceTextInRange):
318
319 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
320
321         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
322         https://bugs.webkit.org/show_bug.cgi?id=196727
323
324         Reviewed by Fujii Hironori.
325
326         * MiniBrowser/win/WebKitBrowserWindow.cpp:
327         (WebKitBrowserWindow::create):
328
329 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
330
331         [ews-build] Add unit tests for PrintConfiguration
332         https://bugs.webkit.org/show_bug.cgi?id=196752
333
334         Reviewed by Dewei Zhu.
335
336         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
337
338 2019-04-09  Keith Rollin  <krollin@apple.com>
339
340         Unreviewed build maintenance -- update .xcfilelists.
341
342         * DumpRenderTree/DerivedSources-input.xcfilelist:
343         * DumpRenderTree/DerivedSources-output.xcfilelist:
344
345 2019-04-09  Zalan Bujtas  <zalan@apple.com>
346
347         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
348         https://bugs.webkit.org/show_bug.cgi?id=196743
349         <rdar://problem/43897551>
350
351         Reviewed by Tim Horton.
352
353         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
354         (TEST):
355
356 2019-04-09  Youenn Fablet  <youenn@apple.com>
357
358         Close service worker database on network process suspension
359         https://bugs.webkit.org/show_bug.cgi?id=196623
360         <rdar://problem/48930869>
361
362         Reviewed by Alex Christensen.
363
364         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
365
366 2019-04-09  Daniel Bates  <dabates@apple.com>
367
368         [iPad] Should open popover when the spacebar is pressed
369         https://bugs.webkit.org/show_bug.cgi?id=196360
370         <rdar://problem/49389129>
371
372         Reviewed by Brent Fulgham.
373
374         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
375
376         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
377         (WTR::UIScriptController::isShowingPopover const): Added.
378         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
379         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
380         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
381         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
382         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
383         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
384         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
385         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
386         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
387         (WTR::UIScriptController::isShowingPopover const): Added.
388         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
389         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
390         * TestRunnerShared/UIScriptContext/UIScriptController.h:
391         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
392         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
393         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
394         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
395         (-[TestRunnerWKWebView _willPresentPopover]): Added.
396         (-[TestRunnerWKWebView _didDismissPopover]): Added.
397         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
398         (WTR::UIScriptController::isShowingPopover const): Added.
399         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
400         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
401
402 2019-04-09  Alex Christensen  <achristensen@webkit.org>
403
404         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
405         https://bugs.webkit.org/show_bug.cgi?id=196665
406         <rdar://45115669>
407
408         Reviewed by Geoff Garen.
409
410         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
411         (goBack):
412         (+[SimpleLookupContext sharedLookupContext]):
413         (-[SimpleLookupContext lookUpURL:completionHandler:]):
414         (TEST):
415         (+[Simple3LookupContext sharedLookupContext]): Deleted.
416         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
417
418 2019-04-09  John Wilander  <wilander@apple.com>
419
420         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
421         https://bugs.webkit.org/show_bug.cgi?id=196558
422         <rdar://problem/47650245>
423
424         Reviewed by Youenn Fablet.
425
426         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
427         (TestWebKitAPI::TEST):
428             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
429
430 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
431
432         [CMake] Apple builds should use ICU_INCLUDE_DIRS
433         https://bugs.webkit.org/show_bug.cgi?id=196720
434
435         Reviewed by Konstantin Tokarev.
436
437         * TestWebKitAPI/PlatformMac.cmake:
438
439 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
440
441         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
442         https://bugs.webkit.org/show_bug.cgi?id=196694
443         <rdar://problem/48388734>
444
445         Rubber-stamped by Aakash Jain.
446
447         * Scripts/webkitpy/port/image_diff.py:
448         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
449         * Scripts/webkitpy/port/server_process.py:
450         (ServerProcess.has_available_stdout): Check if stdout has data in it.
451         (ServerProcess._wait_for_data_and_update_buffers_using_select):
452         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
453         * Scripts/webkitpy/port/server_process_mock.py:
454         (MockServerProcess.has_available_stdout):
455         * Scripts/webkitpy/port/server_process_unittest.py:
456         (TestServerProcess.serial_test_basic):
457
458 2019-04-09  Jer Noble  <jer.noble@apple.com>
459
460         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
461         https://bugs.webkit.org/show_bug.cgi?id=196097
462
463         Reviewed by Eric Carlson.
464
465         Drive-by bug fix: allow tests to play audio without a user gesture by default.
466
467         * DumpRenderTree/mac/DumpRenderTree.mm:
468         (resetWebPreferencesToConsistentValues):
469         * WebKitTestRunner/TestController.cpp:
470         (WTR::TestController::resetPreferencesToConsistentValues):
471
472 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
473
474         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
475         https://bugs.webkit.org/show_bug.cgi?id=196690
476
477         Reviewed by Michael Catanzaro.
478
479         * QueueStatusServer/config/queues.py:
480         * Scripts/webkitpy/common/config/ews.json:
481         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
482         (test_ews_name):
483
484 2019-04-09  Chris Dumez  <cdumez@apple.com>
485
486         Loads using loadHTMLString() cause flashing when process-swapping
487         https://bugs.webkit.org/show_bug.cgi?id=196714
488         <rdar://problem/49637354>
489
490         Reviewed by Antti Koivisto.
491
492         Add API test coverage.
493
494         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
495
496 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
497
498         Unreviewed. Fix ATK accessibility tests after r244059.
499
500         We are failing to load the injected bundle due to undefined symbol
501         AccessibilityUIElement::replaceTextInRange().
502
503         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
504         (WTR::AccessibilityUIElement::replaceTextInRange):
505
506 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
507
508         AX: Support API: accessibilityReplaceRange:withText
509         https://bugs.webkit.org/show_bug.cgi?id=196636
510
511         Unreviewed build fix for Windows port.
512
513         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
514         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
515
516 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
517
518         [CMake][WinCairo] Separate copied headers into different directories
519         https://bugs.webkit.org/show_bug.cgi?id=196655
520
521         Reviewed by Michael Catanzaro.
522
523         * DumpRenderTree/CMakeLists.txt:
524         * MiniBrowser/win/CMakeLists.txt:
525         * TestWebKitAPI/CMakeLists.txt:
526         * TestWebKitAPI/PlatformWin.cmake:
527
528 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
529
530         Log stack-trace for run-webkit-tests when interrupted
531         https://bugs.webkit.org/show_bug.cgi?id=176393
532         <rdar://problem/34262310>
533
534         Reviewed by Lucas Forschler.
535
536         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
537         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
538         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
539         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
540         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
541         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
542         (main): Set handlers to log stack trace on interruption.
543
544 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
545
546         AX: Support API: accessibilityReplaceRange:withText
547         https://bugs.webkit.org/show_bug.cgi?id=196636
548
549         Unreviewed build fix for Windows port.
550
551         * DumpRenderTree/AccessibilityUIElement.cpp:
552         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
553
554 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
555
556         [ews-build] Scripts using Buildbot API have CORS error
557         https://bugs.webkit.org/show_bug.cgi?id=196709
558
559         Reviewed by Alexey Proskuryakov.
560
561         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
562
563 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
564
565         AX: Support API: accessibilityReplaceRange:withText
566         https://bugs.webkit.org/show_bug.cgi?id=196636
567
568         Reviewed by Daniel Bates.
569
570         * DumpRenderTree/AccessibilityUIElement.cpp:
571         (replaceTextInRangeCallback):
572         (AccessibilityUIElement::replaceTextInRange):
573         (AccessibilityUIElement::getJSClass):
574         * DumpRenderTree/AccessibilityUIElement.h:
575         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
576         (AccessibilityUIElement::replaceTextInRange):
577         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
578         (AccessibilityUIElement::replaceTextInRange):
579         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
580         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
581         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
582         (WTR::AccessibilityUIElement::replaceTextInRange):
583         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
584         (WTR::AccessibilityUIElement::replaceTextInRange):
585
586 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
587
588         [iOS] Do not allow starting selection drags when selection views are not visible
589         https://bugs.webkit.org/show_bug.cgi?id=196686
590         <rdar://problem/49399192>
591
592         Reviewed by Tim Horton.
593
594         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
595         also add some new API tests to cover scenarios where the web view is not first responder.
596
597         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
598         (TestWebKitAPI::TEST):
599         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
600
601         Add a switch to optionally make the web view first responder when starting the simulated drag.
602
603         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
604         (-[DragAndDropSimulator initWithWebView:]):
605         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
606
607 2019-04-08  Justin Fan  <justin_fan@apple.com>
608
609         [Web GPU] Fix Web GPU experimental feature on iOS
610         https://bugs.webkit.org/show_bug.cgi?id=196632
611
612         Reviewed by Myles C. Maxfield.
613
614         Properly make Web GPU available on iOS 11+.
615
616         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
617
618 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
619
620         [ews-build] Do not upload archive when Compile Fails
621         https://bugs.webkit.org/show_bug.cgi?id=196674
622
623         Reviewed by Alexey Proskuryakov.
624
625         * BuildSlaveSupport/ews-build/factories.py:
626         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
627         * BuildSlaveSupport/ews-build/steps.py:
628         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
629         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
630         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
631
632 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
633
634         Enable DFG on MIPS
635         https://bugs.webkit.org/show_bug.cgi?id=196689
636
637         Reviewed by Žan Doberšek.
638
639         Since the bytecode change, we enabled the baseline JIT on mips in
640         r240432, but DFG is still missing. With this change, all tests are
641         passing on a ci20 board.
642
643         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
644
645 2019-04-08  Philippe Normand  <pnormand@igalia.com>
646
647         [Flatpak] Second run update-webkitwpe-flatpak fails
648         https://bugs.webkit.org/show_bug.cgi?id=192702
649
650         Reviewed by Carlos Garcia Campos.
651
652         * flatpak/flatpakutils.py:
653         (FlatpakObject.flatpak): Fix typo.
654         (FlatpakPackage.install): When installing, also update to the configured remote commit.
655         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
656
657 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
658
659         [GTK][WPE] outlook.live.com displays old-fashioned UI
660         https://bugs.webkit.org/show_bug.cgi?id=196642
661
662         Reviewed by Carlos Garcia Campos.
663
664         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
665         (TestWebKitAPI::TEST): New Mac platform quirk test.
666
667 2019-04-07  Commit Queue  <commit-queue@webkit.org>
668
669         Unreviewed, rolling out r243956.
670         https://bugs.webkit.org/show_bug.cgi?id=196688
671
672         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
673         by aakashjain on #webkit).
674
675         Reverted changeset:
676
677         "Clicking "Go Back" from a safe browsing warning from an
678         iframe should navigate the WKWebView back to the previous
679         page"
680         https://bugs.webkit.org/show_bug.cgi?id=196665
681         https://trac.webkit.org/changeset/243956
682
683 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
684
685         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
686         https://bugs.webkit.org/show_bug.cgi?id=196669
687
688         Reviewed by Geoffrey Garen.
689
690         Added three new unit tests for WeakHashSet.
691
692         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
693         (WTF_WeakPtr.WeakHashSetConstObjects):
694         (WTF_WeakPtr.WeakHashSetComputesEmpty):
695         (WTF_WeakPtr.WeakHashSetComputeSize):
696
697 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
698
699         Hide next and previous form control buttons when WKWebView is editable
700         https://bugs.webkit.org/show_bug.cgi?id=196672
701         <rdar://problem/35625321>
702
703         Reviewed by Tim Horton.
704
705         Add a new API test.
706
707         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
708         (-[TestWKWebView lastTrailingBarButtonGroup]):
709         (TestWebKitAPI::TEST):
710         * TestWebKitAPI/ios/UIKitSPI.h:
711
712 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
713
714         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
715         https://bugs.webkit.org/show_bug.cgi?id=196077
716         <rdar://problem/49108202>
717
718         Reviewed by Chris Dumez.
719
720         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
721         on new web view.
722
723         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
724
725 2019-04-05  Saam Barati  <sbarati@apple.com>
726
727         Make compare-results understand MotionMark
728         https://bugs.webkit.org/show_bug.cgi?id=196666
729
730         Reviewed by Yusuke Suzuki.
731
732         * Scripts/compare-results:
733         (PLT5Results):
734         (detectMotionMark):
735         (detectMotionMark1_1):
736         (motionMarkResults):
737         (motionMark1_1Results):
738         (detectBenchmark):
739         (biggerIsBetter):
740         (main):
741
742 2019-04-05  Alex Christensen  <achristensen@webkit.org>
743
744         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
745         https://bugs.webkit.org/show_bug.cgi?id=196665
746         <rdar://45115669>
747
748         Reviewed by Geoff Garen.
749
750         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
751         (goBack):
752         (+[SimpleLookupContext sharedLookupContext]):
753         (-[SimpleLookupContext lookUpURL:completionHandler:]):
754         (TEST):
755         (+[Simple3LookupContext sharedLookupContext]): Deleted.
756         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
757
758 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
759
760         [ews-build] Add configuration and architecture for windows builders
761         https://bugs.webkit.org/show_bug.cgi?id=196660
762
763         Reviewed by Lucas Forschler.
764
765         * BuildSlaveSupport/ews-build/config.json:
766
767 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
768
769         webkitpy: Don't run subsequent rounds if interrupted
770         https://bugs.webkit.org/show_bug.cgi?id=196646
771
772         Reviewed by Aakash Jain.
773
774         * Scripts/webkitpy/layout_tests/controllers/manager.py:
775         (Manager.run): Bail out if interrupted.
776
777 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
778
779         Test sessionStorage in PSON private browsing mode
780         https://bugs.webkit.org/show_bug.cgi?id=196561
781
782         Reviewed by Alex Christensen.
783
784         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
785
786 2019-04-05  Commit Queue  <commit-queue@webkit.org>
787
788         Unreviewed, rolling out r243833.
789         https://bugs.webkit.org/show_bug.cgi?id=196645
790
791         This change breaks build of WPE and GTK ports (Requested by
792         annulen on #webkit).
793
794         Reverted changeset:
795
796         "[CMake][WTF] Mirror XCode header directories"
797         https://bugs.webkit.org/show_bug.cgi?id=191662
798         https://trac.webkit.org/changeset/243833
799
800 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
801
802         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
803         https://bugs.webkit.org/show_bug.cgi?id=196635
804
805         Reviewed by Antti Koivisto.
806         
807         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
808         for a test to enable async frame scrolling via:
809             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
810         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
811         
812         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
813
814         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
815         (WTR::InjectedBundle::beginTesting):
816         * WebKitTestRunner/TestController.cpp:
817         (WTR::TestController::resetPreferencesToConsistentValues):
818
819 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
820
821         Use a correct LC_RPATH when building with ASan
822         https://bugs.webkit.org/show_bug.cgi?id=196576
823
824         Reviewed by David Kilzer.
825
826         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
827         so that ../Frameworks is checked. This is simpler and more reliable than updating
828         each SPC service xcconfig.
829
830 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
831
832         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
833         https://bugs.webkit.org/show_bug.cgi?id=196629
834
835         Reviewed by Lucas Forschler.
836
837         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
838
839 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
840
841         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
842         https://bugs.webkit.org/show_bug.cgi?id=196618
843
844         Reviewed by Lucas Forschler.
845
846         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
847         (StatusBubble): Added QUEUE_TRIGGERS.
848         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
849         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
850         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
851         its parent(builder).
852
853 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
854
855         [ews-app] Status-bubble steps are sometimes displayed in reverse order
856         https://bugs.webkit.org/show_bug.cgi?id=196625
857
858         Reviewed by Lucas Forschler.
859
860         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
861         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
862
863 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
864
865         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
866         https://bugs.webkit.org/show_bug.cgi?id=196630
867
868         Reviewed by Wenson Hsieh.
869
870         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
871
872 2019-04-04  Youenn Fablet  <youenn@apple.com>
873
874         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
875         https://bugs.webkit.org/show_bug.cgi?id=196543
876
877         Reviewed by Alex Christensen.
878
879         * WebKitTestRunner/TestController.cpp:
880         (WTR::TestController::generatePageConfiguration):
881
882 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
883
884         [ews-app] Status bubble should not display skipped buildbot steps
885         https://bugs.webkit.org/show_bug.cgi?id=196584
886
887         Reviewed by Lucas Forschler.
888
889         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
890
891 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
892
893         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
894         https://bugs.webkit.org/show_bug.cgi?id=196620
895
896         Reviewed by Lucas Forschler.
897
898         * BuildSlaveSupport/ews-app/ews/config.py:
899
900 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
901
902         [Win] DumpRenderTreeWatchDog.py is not checked into source
903         https://bugs.webkit.org/show_bug.cgi?id=196567
904         <rdar://problem/49525901>
905
906         Reviewed by Lucas Forschler.
907
908         This script is used on Win EWS bots to terminate hanging DRT processes.
909
910         * EWSTools/dumprendertreewatchdog.py: Added.
911
912 2019-04-04  Chris Dumez  <cdumez@apple.com>
913
914         Unreviewed, roll out r243858 which made tests time out.
915
916         Disable new API tests on Windows instead.
917
918         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
919         (TestWebKitAPI::TEST):
920
921 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
922
923         [ATK] Cleanup WebPageAccessibilityObjectAtk
924         https://bugs.webkit.org/show_bug.cgi?id=196537
925
926         Reviewed by Michael Catanzaro.
927
928         Also consider files under atk directories as exceptions for GObject conventions.
929
930         * Scripts/webkitpy/style/checkers/cpp.py:
931         (check_identifier_name_in_declaration):
932
933 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
934
935         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
936         https://bugs.webkit.org/show_bug.cgi?id=196588
937         <rdar://problem/49365787>
938
939         Unreviewed build fix for Windows port.
940
941         error C3861: 'kill': identifier not found
942
943         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
944         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
945
946 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
947
948         [ews-build] Cancel build and similar operations should have authentication
949         https://bugs.webkit.org/show_bug.cgi?id=196520
950
951         Reviewed by Dewei Zhu.
952
953         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
954         environment variables.
955
956 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
957
958         [ews-build] Do not trigger queues which are not in production yet
959         https://bugs.webkit.org/show_bug.cgi?id=196581
960
961         Reviewed by Dewei Zhu.
962
963         * BuildSlaveSupport/ews-build/config.json:
964
965 2019-04-03  Chris Dumez  <cdumez@apple.com>
966
967         Unreviewed, fix typo in the name of API test added in r243848.
968
969         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
970         (TestWebKitAPI::TEST):
971
972 2019-04-03  Chris Dumez  <cdumez@apple.com>
973
974         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
975         https://bugs.webkit.org/show_bug.cgi?id=196588
976         <rdar://problem/49365787>
977
978         Reviewed by Ryosuke Niwa.
979
980         Add API test coverage.
981
982         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
983         (TestWebKitAPI::nullJavaScriptCallback):
984         (TestWebKitAPI::didCrashCheckFrames):
985         (TestWebKitAPI::TEST):
986
987 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
988
989         run-webkit-tests: Upload test results (new results database)
990         https://bugs.webkit.org/show_bug.cgi?id=196577
991         <rdar://problem/34841155>
992
993         Reviewed by Lucas Forschler.
994
995         * Scripts/webkitpy/layout_tests/controllers/manager.py:
996         (Manager.run): Upload results after each device shard, since the configuration will be
997         different for each device.
998         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
999         uploaded to a results database.
1000         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1001         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1002
1003 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1004
1005         -apple-trailing-word is needed for browser detection
1006         https://bugs.webkit.org/show_bug.cgi?id=196575
1007
1008         Unreviewed.
1009
1010         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1011
1012 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1013
1014         [CMake][WTF] Mirror XCode header directories
1015         https://bugs.webkit.org/show_bug.cgi?id=191662
1016
1017         Reviewed by Konstantin Tokarev.
1018
1019         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1020         builds.
1021
1022         * CMakeLists.txt:
1023         * DumpRenderTree/CMakeLists.txt:
1024         * DumpRenderTree/PlatformWin.cmake:
1025         * MiniBrowser/win/CMakeLists.txt:
1026         * TestWebKitAPI/CMakeLists.txt:
1027         * TestWebKitAPI/PlatformWin.cmake:
1028         * WebKitTestRunner/PlatformGTK.cmake:
1029         * WebKitTestRunner/PlatformWin.cmake:
1030
1031 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1032
1033         [ews-app] Status bubble should not display certain infrastructure status messages
1034         https://bugs.webkit.org/show_bug.cgi?id=196550
1035
1036         Reviewed by Lucas Forschler.
1037
1038         Do not display the steps which are un-needed for end-user. This information is still avaiable
1039         if the user click on the bubble and look at the Buildbot build.
1040         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1041         (StatusBubble._steps_messages):
1042         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1043
1044 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1045
1046         [ews-build] Use https for sending data to ews-app
1047         https://bugs.webkit.org/show_bug.cgi?id=196492
1048
1049         Reviewed by Lucas Forschler.
1050
1051         * BuildSlaveSupport/ews-build/events.py:
1052
1053 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1054
1055         Remove support for -apple-trailing-word
1056         https://bugs.webkit.org/show_bug.cgi?id=196525
1057
1058         Reviewed by Zalan Bujtas.
1059
1060         This CSS property is nonstandard and not used.
1061
1062         * Scripts/webkitperl/FeatureList.pm:
1063         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1064
1065 2019-04-03  Youenn Fablet  <youenn@apple.com>
1066
1067         Add a test for DOMCache on multiple browsing in case of private browsing
1068         https://bugs.webkit.org/show_bug.cgi?id=196524
1069
1070         Reviewed by Alex Christensen.
1071
1072         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1073         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1074
1075 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1076
1077         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1078         https://bugs.webkit.org/show_bug.cgi?id=196540
1079
1080         Reviewed by Aakash Jain.
1081
1082         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1083
1084 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1085
1086         Add plumbing for a compatibility mode preference in WebKit
1087         https://bugs.webkit.org/show_bug.cgi?id=196005
1088
1089         Reviewed by Tim Horton.
1090
1091         Add new API tests.
1092
1093         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1094         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1095
1096 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1097
1098         [WPE][GTK] Update libsrtp dependency package for Debian
1099         https://bugs.webkit.org/show_bug.cgi?id=196528
1100
1101         Reviewed by Frédéric Wang.
1102
1103         * gtk/install-dependencies:
1104         * wpe/install-dependencies:
1105
1106 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1107
1108         [WK2] Add support for Window's beforeprint / afterprint events
1109         https://bugs.webkit.org/show_bug.cgi?id=196478
1110         <rdar://problem/49535124>
1111
1112         Unreviewed build fix for MSVC.
1113
1114         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1115
1116         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1117
1118         * WebKitTestRunner/TestController.cpp:
1119         (WTR::printFrame): Use int and float literals.
1120
1121 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1122
1123         [ews-build] Reassign bots to queues
1124
1125         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1126
1127 2019-04-02  Chris Dumez  <cdumez@apple.com>
1128
1129         [WK2] Add support for Window's beforeprint / afterprint events
1130         https://bugs.webkit.org/show_bug.cgi?id=196478
1131
1132         Reviewed by Alex Christensen.
1133
1134         Add minimal implementation for printFrame in WebKitTestRunner.
1135
1136         * WebKitTestRunner/TestController.cpp:
1137         (WTR::printFrame):
1138         (WTR::TestController::createOtherPage):
1139         (WTR::TestController::createWebViewWithOptions):
1140
1141 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1142
1143         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1144         https://bugs.webkit.org/show_bug.cgi?id=196491
1145
1146         Reviewed by Lucas Forschler.
1147
1148         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1149
1150 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1151
1152         [ews-build] Configure buildbot try credentials in environment variables
1153         https://bugs.webkit.org/show_bug.cgi?id=196501
1154
1155         Reviewed by Lucas Forschler.
1156
1157         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1158         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1159         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1160
1161 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1162
1163         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1164         https://bugs.webkit.org/show_bug.cgi?id=196496
1165         <rdar://problem/49521634>
1166
1167         Reviewed by Chris Dumez.
1168
1169         Add new API tests (see WebKit ChangeLog for more detail).
1170
1171         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1172         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1173         (TEST):
1174
1175 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1176
1177         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1178         <https://webkit.org/b/196499>
1179
1180         Reviewed by Alexey Proskuryakov.
1181
1182         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1183         ENABLE_ADDRESS_SANITIZER.
1184
1185 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1186
1187         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1188         https://bugs.webkit.org/show_bug.cgi?id=182757
1189
1190         Reviewed by Don Olmstead.
1191
1192         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1193         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1194
1195 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1196
1197         run-api-tests: Upload test results
1198         https://bugs.webkit.org/show_bug.cgi?id=196323
1199         <rdar://problem/49356714>
1200
1201         Reviewed by Lucas Forschler.
1202
1203         * Scripts/webkitpy/api_tests/manager.py:
1204         (Manager):
1205         (Manager.run): Upload results to a results database.
1206         * Scripts/webkitpy/api_tests/run_api_tests.py:
1207         (parse_args): Add upload arguments.
1208         * Scripts/webkitpy/port/base.py:
1209         (Port):
1210         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1211         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1212         with commits from any other associated repositories.
1213         * Scripts/webkitpy/port/device.py:
1214         (Device):
1215         (Device.build_version): Access build_versoin of underlying platform device.
1216         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1217         (IOSSimulatorTest):
1218         (IOSSimulatorTest.test_configuration_for_upload):
1219         * Scripts/webkitpy/port/device_port.py:
1220         (DevicePort):
1221         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1222         the same as the machine uploading results.
1223         * Scripts/webkitpy/port/mac.py:
1224         (MacPort):
1225         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1226         * Scripts/webkitpy/port/mac_unittest.py:
1227         (MacTest):
1228         (MacTest.test_configuration_for_upload):
1229         * Scripts/webkitpy/xcode/simulated_device.py:
1230         (SimulatedDeviceManager._create_device_with_runtime):
1231         (SimulatedDevice.__init__): Create simulated device with a build_version.
1232         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1233         (test_existing_simulator):
1234
1235 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1236
1237         Remove extra newline characters (Follow-up fix to r243707)
1238
1239         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1240
1241 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1242
1243         [ews-app] Use API_KEY to accept results data
1244         https://bugs.webkit.org/show_bug.cgi?id=196461
1245
1246         Reviewed by Dewei Zhu.
1247
1248         * BuildSlaveSupport/ews-app/ews/views/results.py:
1249         (Results.post): Validate EWS_API_KEY before accepting any data.
1250         * BuildSlaveSupport/ews-build/events.py:
1251         (Events.sendData): Send EWS_API_KEY if available along with event data.
1252
1253 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1254
1255         Unable to copy and paste a PDF from Notes into Mail compose body
1256         https://bugs.webkit.org/show_bug.cgi?id=196442
1257         <rdar://problem/48573098>
1258
1259         Reviewed by Tim Horton.
1260
1261         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1262         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1263         to be specified on the item providers.
1264
1265         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1266         (TestWebKitAPI::mapItemForTesting):
1267         (TestWebKitAPI::contactItemForTesting):
1268
1269 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1270
1271         Make UIWKDocumentContext rects per-character instead of per-word
1272         https://bugs.webkit.org/show_bug.cgi?id=196459
1273
1274         Reviewed by Wenson Hsieh.
1275
1276         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1277         (TEST):
1278         Adjust test results due to switching to per-character rects.
1279
1280 2019-04-01  Chris Dumez  <cdumez@apple.com>
1281
1282         UIProcess crash when a prewarmed process is terminated
1283         https://bugs.webkit.org/show_bug.cgi?id=196451
1284         <rdar://problem/49245471>
1285
1286         Reviewed by Geoffrey Garen.
1287
1288         Add API test coverage.
1289
1290         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1291         (TEST):
1292
1293 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1294
1295         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1296         https://bugs.webkit.org/show_bug.cgi?id=196449
1297
1298         Reviewed by Lucas Forschler.
1299
1300         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1301         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1302         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1303         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1304
1305 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1306
1307         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1308         https://bugs.webkit.org/show_bug.cgi?id=196444
1309
1310         Reviewed by Lucas Forschler.
1311
1312         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1313
1314 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1315
1316         Add SPI to canonicalize NSURLs with WTF::URL
1317         https://bugs.webkit.org/show_bug.cgi?id=196415
1318         <rdar://problem/44980271>
1319
1320         Reviewed by Darin Adler.
1321
1322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1323         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1324         (TestWebKitAPI::TEST):
1325
1326 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1327
1328         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1329         https://bugs.webkit.org/show_bug.cgi?id=196441
1330
1331         Reviewed by Carlos Garcia Campos.
1332
1333         Don't cache the wpe_view_backend object that might not exist yet at the
1334         time of EventSenderProxy constructor invocation, but instead retrieve
1335         that object whenever it's required for event dispatching. This should
1336         avoid crashes in this constructor now that it's invoked before any
1337         PlatformWindow has been set up (as changed in r243496).
1338
1339         * WebKitTestRunner/EventSenderProxy.h:
1340         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1341         (WTR::viewBackend):
1342         (WTR::EventSenderProxy::EventSenderProxy):
1343         (WTR::EventSenderProxy::mouseDown):
1344         (WTR::EventSenderProxy::mouseUp):
1345         (WTR::EventSenderProxy::mouseMoveTo):
1346         (WTR::EventSenderProxy::mouseScrollBy):
1347         (WTR::EventSenderProxy::keyDown):
1348         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1349
1350 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1351
1352         [Win][WebKit] MiniBrowser should support high DPI display
1353         https://bugs.webkit.org/show_bug.cgi?id=196391
1354
1355         Reviewed by Alex Christensen.
1356
1357         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1358         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1359         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1360         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1361
1362 2019-03-31  Sam Weinig  <weinig@apple.com>
1363
1364         Remove more i386 specific configurations
1365         https://bugs.webkit.org/show_bug.cgi?id=196430
1366
1367         Reviewed by Alexey Proskuryakov.
1368
1369         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1370         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1371
1372 2019-03-31  Andy Estes  <aestes@apple.com>
1373
1374         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1375         https://bugs.webkit.org/show_bug.cgi?id=196433
1376         <rdar://problem/49293305>
1377
1378         Reviewed by Tim Horton.
1379
1380         Enhanced API test coverage to include all navigation response policy decisions in both
1381         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1382
1383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1384         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1385         (TestWebKitAPI::TEST):
1386         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1387         (readFile):
1388         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1389         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1390         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1391         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1392         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1393         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1394         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1395         (-[QuickLookDelegate _downloadDidStart:]):
1396         (-[QuickLookDelegate _download:didReceiveResponse:]):
1397         (-[QuickLookDelegate _download:didReceiveData:]):
1398         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1399         (-[QuickLookDelegate _downloadDidFinish:]):
1400         (-[QuickLookDelegate _download:didFailWithError:]):
1401         (-[QuickLookDelegate _downloadDidCancel:]):
1402         (-[QuickLookDelegate verifyDownload]):
1403         (runTest):
1404         (runTestDecideBeforeLoading):
1405         (runTestDecideAfterLoading):
1406         (TEST):
1407         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1408         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1409         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1410         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1411         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1412         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1413         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1414         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1415         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1416         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1417         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1418         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1419         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1420         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1421
1422 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1423
1424         [CMake] add testdfg as target with build-jsc
1425         https://bugs.webkit.org/show_bug.cgi?id=196393
1426
1427         Reviewed by Saam Barati.
1428
1429         Added testdfg as one of the targets to build when
1430         using CMake.
1431
1432         * Scripts/build-jsc:
1433
1434 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1435
1436         Delete WebMetal implementation in favor of WebGPU
1437         https://bugs.webkit.org/show_bug.cgi?id=195418
1438
1439         Reviewed by Dean Jackson.
1440
1441         * DumpRenderTree/mac/DumpRenderTree.mm:
1442         (enableExperimentalFeatures):
1443         (resetWebPreferencesToConsistentValues):
1444         * Scripts/webkitperl/FeatureList.pm:
1445         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1446         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1447         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1448         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1449         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1450         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1451         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1452         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1453         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1454         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1455         (WTR::InjectedBundle::beginTesting):
1456         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1457         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1458         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1459
1460 2019-03-29  Chris Dumez  <cdumez@apple.com>
1461
1462         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1463         https://bugs.webkit.org/show_bug.cgi?id=196405
1464         <rdar://problem/49428130>
1465
1466         Reviewed by Wenson Hsieh.
1467
1468         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1469         the popover presentation methods to be no-ops. Use this in the new test added in
1470         r243523 so that we do not swizzle those methods for all tests. This is needed because
1471         those WatchOS tests rely on the popover getting presented and interactive.
1472
1473         * WebKitTestRunner/TestController.cpp:
1474         (WTR::updateTestOptionsFromTestHeader):
1475         * WebKitTestRunner/TestController.h:
1476         * WebKitTestRunner/TestOptions.h:
1477         (WTR::TestOptions::hasSameInitializationOptions const):
1478         * WebKitTestRunner/ios/TestControllerIOS.mm:
1479         (WTR::TestController::platformInitialize):
1480         (WTR::TestController::platformResetStateToConsistentValues):
1481
1482 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1483
1484         [Curl] Add Server Trust Evaluation Support.
1485         https://bugs.webkit.org/show_bug.cgi?id=191646
1486
1487         Reviewed by Fujii Hironori.
1488
1489         Implemented MiniBrowser UI for asking if user trusts the server.
1490
1491         * MiniBrowser/win/Common.cpp:
1492         (askServerTrustEvaluation):
1493         (replaceString):
1494         * MiniBrowser/win/Common.h:
1495         * MiniBrowser/win/MiniBrowserLib.rc:
1496         * MiniBrowser/win/MiniBrowserLibResource.h:
1497         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1498         (createPEMString):
1499         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1500         (WebKitBrowserWindow::canTrustServerCertificate):
1501         * MiniBrowser/win/WebKitBrowserWindow.h:
1502
1503 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1504
1505         Implement ResizeObserver.
1506         https://bugs.webkit.org/show_bug.cgi?id=157743
1507
1508         Reviewed by Simon Fraser.
1509
1510         Support resizeObserverEnabled webPreferences.
1511
1512         * DumpRenderTree/TestOptions.cpp:
1513         (TestOptions::TestOptions):
1514         * DumpRenderTree/TestOptions.h:
1515         * DumpRenderTree/mac/DumpRenderTree.mm:
1516         (setWebPreferencesForTestOptions):
1517         * DumpRenderTree/win/DumpRenderTree.cpp:
1518         (enableExperimentalFeatures):
1519         * Scripts/webkitperl/FeatureList.pm:
1520         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1521
1522 2019-03-28  John Wilander  <wilander@apple.com>
1523
1524         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1525         https://bugs.webkit.org/show_bug.cgi?id=196281
1526         <rdar://problem/48938748>
1527
1528         Reviewed by Alex Christensen.
1529
1530         This patch adds the function isStatisticsHasLocalStorage() to the
1531         TestRunner. With it, the page can query the WebsiteDataStore in the
1532         UI process to make sure that it sees LocalStorage.
1533
1534         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1535         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1536         (WTR::TestRunner::isStatisticsHasLocalStorage):
1537         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1538         * WebKitTestRunner/TestController.cpp:
1539         (WTR::TestController::isStatisticsHasLocalStorage):
1540         * WebKitTestRunner/TestController.h:
1541         * WebKitTestRunner/TestInvocation.cpp:
1542         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1543
1544 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1545
1546         API::Data::createWithoutCopying should do a null check before calling CFRelease
1547         https://bugs.webkit.org/show_bug.cgi?id=196276
1548         <rdar://problem/48059859>
1549
1550         Reviewed by Alex Christensen.
1551
1552         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1553
1554         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1555         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1556         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1557         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1558         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1559         (TestWebKitAPI::TEST):
1560
1561 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1562
1563         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1564         https://bugs.webkit.org/show_bug.cgi?id=186276
1565
1566         Reviewed by Carlos Garcia Campos.
1567
1568         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1569         (webViewLoadChanged):
1570         (testWebResourceGetDataError):
1571         (testWebResourceGetDataEmpty):
1572         (beforeAll):
1573         (webViewloadChanged): Deleted.
1574
1575 2019-03-27  Andy Estes  <aestes@apple.com>
1576
1577         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1578         https://bugs.webkit.org/show_bug.cgi?id=196317
1579
1580         Reviewed by Dan Bernstein.
1581
1582         package-root copies built products into a staging directory using ditto(1), which does not
1583         follow symbolic links as it traverses a directory. Now that the files in
1584         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1585         itself, these become broken links when ditto'd into the staging directory.
1586
1587         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1588
1589         * Scripts/package-root:
1590
1591 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1592
1593         [ews-app] Update display text of Submit for ews analysis
1594         https://bugs.webkit.org/show_bug.cgi?id=196309
1595
1596         Reviewed by Dewei Zhu.
1597
1598         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1599
1600 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1601
1602         run-webkit-tests should check for leaks in WebKit processes
1603         <https://webkit.org/b/193772>
1604         <rdar://problem/46526680>
1605
1606         Reviewed by Ryosuke Niwa.
1607
1608         This works by doing the following:
1609         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1610           The list of child processes are returned one per line:
1611           process.name: pid
1612         - Run the "#LIST CHILD PROCESSES" command just before the
1613           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1614           processes on the ServerProcess object.
1615         - When the `--leaks` switch is handled, run check_for_leaks() on
1616           each child process after the main test harness.
1617
1618         * DumpRenderTree/mac/DumpRenderTree.mm:
1619         (handleControlCommand):
1620         - Use strncmp() instead of strcmp().
1621         - Add support for handling "#LIST CHILD PROCESSES" command.
1622
1623         * Scripts/webkitpy/port/base.py:
1624         (Port.check_for_leaks):
1625         * Scripts/webkitpy/port/darwin.py:
1626         (DarwinPort.check_for_leaks):
1627         - Rename redundant 'process_pid' argument to 'process_id'.
1628
1629         * Scripts/webkitpy/port/driver.py:
1630         (Driver.do_post_tests_work):
1631         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1632           longer the only command this sends to WebKitTestRunner.
1633         - If the `--leaks` switch is present, send the
1634           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1635           result using Port.set_webkit_processes().
1636         (Driver._parse_child_processes_output):
1637         - Add helper method to parse list of child process names and
1638           process IDs returned from WebKitTestRunner.
1639
1640         * Scripts/webkitpy/port/ios_device.py:
1641         (IOSDevicePort.check_for_leaks):
1642         - Rename redundant 'process_pid' argument to 'process_id'.
1643
1644         * Scripts/webkitpy/port/leakdetector.py:
1645         (LeakDetector._parse_leaks_output):
1646         - Return early if there is no leaks_output.
1647         (LeakDetector.check_for_leaks):
1648         - Rename redundant 'process_pid' argument to 'process_id'.
1649
1650         * Scripts/webkitpy/port/server_process.py:
1651         (ServerProcess.__init__):
1652         (ServerProcess.child_processes):
1653         (ServerProcess.set_child_processes):
1654         - Add instance variable to Port to store list of child process
1655           names and process IDs returned from WebKitTestRunner.
1656         (ServerProcess._start):
1657         - Clear self._child_processes.
1658         (ServerProcess.stop):
1659         - If self._child_processes is set, call
1660           self._port.check_for_leaks() for each child process.
1661
1662         * Scripts/webkitpy/port/server_process_unittest.py:
1663         (TrivialMockPort.check_for_leaks):
1664         - Rename redundant 'process_pid' argument to 'process_id'.
1665
1666         * Scripts/webkitpy/port/simulator_process.py:
1667         (SimulatorProcess.stop):
1668         - If self._child_processes is set, call
1669           self._port.check_for_leaks() for each child process.
1670
1671         * Scripts/webkitpy/port/watch_device.py:
1672         (WatchDevicePort.check_for_leaks):
1673         - Rename redundant 'process_pid' argument to 'process_id'.
1674
1675         * WebKitTestRunner/TestController.cpp:
1676         (WTR::TestController::dumpResponse):
1677         - Extract method from findAndDumpWorldLeaks() so that it may be
1678           reused by findAndDumpWebKitProcessIdentifiers().
1679         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1680         - Add method to output process name and process ID of both the
1681           WebContent and Networking processes.
1682         (WTR::TestController::findAndDumpWorldLeaks):
1683         - Fix missing newline in output when there were no abandoned
1684           documents.
1685         - Call dumpResponse() for extracted code.
1686         (WTR::TestController::handleControlCommand):
1687         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1688         - Use strncmp() instead of strcmp().
1689         - Call findAndDumpWebKitProcessIdentifiers() when
1690           "#LIST CHILD PROCESSES" command is sent.
1691         * WebKitTestRunner/TestController.h:
1692         (WTR::TestController::dumpResponse):
1693         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1694         - Declare methods.
1695
1696 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1697
1698         Unreviewed. Add GLib API test cases after r243434.
1699
1700         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1701         (testWebViewActiveURI):
1702         (serverCallback):
1703         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1704         (sendRequestCallback):
1705
1706 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1707
1708         Geolocation request not complete when watch request was started in a different web process
1709         https://bugs.webkit.org/show_bug.cgi?id=195996
1710
1711         Reviewed by Alex Christensen.
1712
1713         Add a test case.
1714
1715         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1716         (TestWebKitAPI::runJavaScriptAlert):
1717         (TestWebKitAPI::TEST):
1718
1719 2019-03-26  Keith Rollin  <krollin@apple.com>
1720
1721         Update the way generate-xcfilelists returns strings from functions
1722         https://bugs.webkit.org/show_bug.cgi?id=195975
1723         <rdar://problem/49040807>
1724
1725         Reviewed by Dean Jackson.
1726
1727         There are places where generate-xcfilelists executes assignments with
1728         statements like:
1729
1730             FOO=$(some_function)
1731
1732         where "some_function" return a string by echoing it. E.g.
1733
1734             some_function()
1735             {
1736                 echo "Hello, World"
1737             }
1738
1739         This is a common idiom, but it has a problem if "some_function" needs
1740         to call "exit" in an attempt to halt the entire script right then and
1741         there. Since "some_function" is called inside of $(), it's being
1742         executed in a sub-shell. Calling exit in that sub-shell simply exits
1743         that shell; it doesn't not exit the outer shell in which the main part
1744         of the script is still running. As such, the main script keeps
1745         executing when the intent was for the script to halt.
1746
1747         The solution to this is to use a different idiom for returning
1748         strings. The one we now is to pass in the name of the variable to
1749         receive the string result:
1750
1751             some_function()
1752             {
1753                 variable_name=$1
1754                 eval $variable_name ="Hello, World"
1755             }
1756
1757         The call site now looks like
1758
1759             some_function FOO
1760
1761         Because there's no invocation of a sub-shell, some_function can now
1762         call "exit" if it wants to, and the entire script will exit at that
1763         point.
1764
1765         * Scripts/generate-xcfilelists:
1766
1767 2019-03-26  Chris Dumez  <cdumez@apple.com>
1768
1769         Add basic layout test coverage for File Picker on iOS
1770         https://bugs.webkit.org/show_bug.cgi?id=196265
1771
1772         Reviewed by Wenson Hsieh.
1773
1774         Add layout test infrastructure to test the file picker on iOS.
1775
1776         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1777         (WTR::UIScriptController::dismissFilePicker):
1778         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1779         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1780         (WTR::UIScriptController::dismissFilePicker):
1781         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1782         * WebKitTestRunner/TestController.cpp:
1783         (WTR::TestController::createWebViewWithOptions):
1784         (WTR::updateTestOptionsFromTestHeader):
1785         * WebKitTestRunner/TestOptions.h:
1786         (WTR::TestOptions::hasSameInitializationOptions const):
1787         * WebKitTestRunner/ios/TestControllerIOS.mm:
1788         (overridePresentViewController):
1789         (WTR::TestController::platformInitialize):
1790         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1791         (WTR::UIScriptController::dismissFilePicker):
1792
1793 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1794
1795         Implement async paste method on UIWKInteractionViewProtocol
1796         https://bugs.webkit.org/show_bug.cgi?id=196267
1797         <rdar://problem/49236346>
1798
1799         Reviewed by Tim Horton.
1800
1801         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1802         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1803         are now a part of all iOS 12 internal SDKs.
1804
1805         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1806
1807         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1808         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1809
1810         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1811         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1812         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1813         * TestWebKitAPI/ios/UIKitSPI.h:
1814
1815 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1816
1817         [ews-build] Use PostgreSQL for ews.webkit.org database
1818         https://bugs.webkit.org/show_bug.cgi?id=196270
1819
1820         Reviewed by Lucas Forschler.
1821
1822         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1823
1824 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1825
1826         [ews] Reset simctl states on reboot
1827         https://bugs.webkit.org/show_bug.cgi?id=196260
1828
1829         Rubber-stamped by Aakash Jain.
1830
1831         * EWSTools/start-queue-mac.sh:
1832
1833 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1834
1835         [ews-build] Use PostgreSQL for ews-build database
1836         https://bugs.webkit.org/show_bug.cgi?id=196229
1837
1838         Reviewed by Lucas Forschler.
1839
1840         * BuildSlaveSupport/ews-build/master.cfg:
1841
1842 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1843
1844         [ews-build] Get master_hostname dynamically in master.cfg
1845         https://bugs.webkit.org/show_bug.cgi?id=196255
1846
1847         Reviewed by Lucas Forschler.
1848
1849         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1850         send events data in test mode.
1851
1852 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1853
1854         [ews-app] Set db_constraint to False for Foreign Keys
1855         https://bugs.webkit.org/show_bug.cgi?id=196252
1856
1857         Reviewed by Lucas Forschler.
1858
1859         * BuildSlaveSupport/ews-app/ews/models/build.py:
1860         * BuildSlaveSupport/ews-app/ews/models/step.py:
1861
1862 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1863
1864         [ews-build] is_test_mode_enabled should default to True
1865         https://bugs.webkit.org/show_bug.cgi?id=196248
1866
1867         Reviewed by Lucas Forschler.
1868
1869         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1870
1871 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1872
1873         [ews-app] Add webkitperl to ENABLED_QUEUES
1874         https://bugs.webkit.org/show_bug.cgi?id=196253
1875
1876         Reviewed by Lucas Forschler.
1877
1878         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1879
1880 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1881
1882         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1883         https://bugs.webkit.org/show_bug.cgi?id=196211
1884         rdar://problem/49110552
1885
1886         Reviewed by Tim Horton.
1887
1888         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1889         Make sure that EventSenderProxy always exists when running tests. We used to create
1890         it when resetting before the first test, which is a bit too late.
1891
1892         * WebKitTestRunner/TestController.h:
1893         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1894         (WTR::TestController::platformCreateWebView):
1895         (WTR::TestController::platformCreateOtherPage):
1896         (WTR::TestController::finishCreatingPlatformWebView):
1897         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1898         (WTR::PlatformWebView::PlatformWebView):
1899         Moved some code that made NSWindow use NSEvent during web view creation. We may
1900         need to move more if some other case us found, but this is enough for now.
1901
1902 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1903
1904         Unreviewed. Fix typo in GLib geolocation API after r243285.
1905
1906         gelocation -> geolocation.
1907
1908         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1909         (testGeolocationManagerWatchPosition):
1910
1911 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1912
1913         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1914         https://bugs.webkit.org/show_bug.cgi?id=196213
1915
1916         Reviewed by Geoff Garen.
1917
1918         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1919         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1920         (credentialWithIdentityAndKeychainPath):
1921         (-[ChallengeDelegate webView:didFinishNavigation:]):
1922         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1923         (TestWebKitAPI::TEST):
1924
1925 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1926
1927         Expected shouldn't assume its contained types are copyable
1928         https://bugs.webkit.org/show_bug.cgi?id=195986
1929
1930         Reviewed by JF Bastien.
1931
1932         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1933         (TestWebKitAPI::NonCopyable::operator== const):
1934         (TestWebKitAPI::NonCopyable::operator!= const):
1935         (TestWebKitAPI::TEST):
1936
1937 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1938
1939         Remove some now-unnecessary dynamic class lookup
1940         https://bugs.webkit.org/show_bug.cgi?id=196237
1941
1942         Reviewed by Simon Fraser.
1943
1944         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1945         (makeRequest):
1946         (TEST):
1947
1948 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1949
1950         Unreviewed, rolling out r243450.
1951
1952         AppleWin and WinCairo port builds get broken.
1953
1954         Reverted changeset:
1955
1956         "Add test for fix of #196095"
1957         https://bugs.webkit.org/show_bug.cgi?id=196097
1958         https://trac.webkit.org/changeset/243450
1959
1960 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1961
1962         Unreviewed, rolling out r243465.
1963         https://bugs.webkit.org/show_bug.cgi?id=196226
1964
1965         the test doesn't build (Requested by thorton on #webkit).
1966
1967         Reverted changeset:
1968
1969         "Do not terminate the NetworkProcess if a third party
1970         application sends a NSCredential with a SecIdentityRef"
1971         https://bugs.webkit.org/show_bug.cgi?id=196213
1972         https://trac.webkit.org/changeset/243465
1973
1974 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1975
1976         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1977         https://bugs.webkit.org/show_bug.cgi?id=196213
1978
1979         Reviewed by Geoff Garen.
1980
1981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1982         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1983         (credentialWithIdentityAndKeychainPath):
1984         (-[ChallengeDelegate webView:didFinishNavigation:]):
1985         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1986         (TestWebKitAPI::TEST):
1987
1988 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1989
1990         [ews-build] Gracefully handle missing patch_id in events
1991         https://bugs.webkit.org/show_bug.cgi?id=196216
1992
1993         Reviewed by Lucas Forschler.
1994
1995         * BuildSlaveSupport/ews-build/events.py:
1996
1997 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1998
1999         [ews-build] use lz4 compression for improving buildbot performance
2000         https://bugs.webkit.org/show_bug.cgi?id=196155
2001
2002         Reviewed by Lucas Forschler.
2003
2004         * BuildSlaveSupport/ews-build/master.cfg:
2005
2006 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2007
2008         Pull some API testing helper methods out of TestWKWebView
2009         https://bugs.webkit.org/show_bug.cgi?id=196212
2010
2011         Reviewed by Tim Horton.
2012
2013         Refactor some more API testing utility methods, so that they can be used in
2014         tests that do not use TestWKWebView.
2015
2016         * TestWebKitAPI/cocoa/TestWKWebView.h:
2017         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2018         (-[WKWebView loadTestPageNamed:]):
2019         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2020         (-[WKWebView synchronouslyLoadHTMLString:]):
2021         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2022         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2023         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2024         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2025         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2026
2027 2019-03-25  Jer Noble  <jer.noble@apple.com>
2028
2029         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2030         https://bugs.webkit.org/show_bug.cgi?id=196097
2031
2032         Reviewed by Eric Carlson.
2033
2034         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2035
2036         * DumpRenderTree/mac/DumpRenderTree.mm:
2037         (resetWebPreferencesToConsistentValues):
2038         * WebKitTestRunner/TestController.cpp:
2039         (WTR::TestController::resetPreferencesToConsistentValues):
2040
2041 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2042
2043         Pull IPadUserInterfaceSwizzler out into a separate header file
2044         https://bugs.webkit.org/show_bug.cgi?id=196193
2045
2046         Reviewed by Anders Carlsson.
2047
2048         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2049         be used in other API tests.
2050
2051         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2052         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2053         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2054         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2055         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2056         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2057         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2058
2059 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2060
2061         Remove NavigatorContentUtils in WebCore/Modules
2062         https://bugs.webkit.org/show_bug.cgi?id=196070
2063
2064         Reviewed by Alex Christensen.
2065
2066         NavigatorContentUtils was to support the custom scheme spec [1].
2067         However, in WebKit side, no port has supported the feature in
2068         WebKit layer after EFL port was removed. So there has been the
2069         only IDL implementation of the NavigatorContentUtils in WebCore.
2070         So we don't need to keep the implementation in WebCore anymore.
2071
2072         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2073
2074         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2075
2076 2019-03-24  Andy Estes  <aestes@apple.com>
2077
2078         [watchOS] Remove unused Proximity Networking code
2079         https://bugs.webkit.org/show_bug.cgi?id=196188
2080
2081         Reviewed by Tim Horton.
2082
2083         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2084         (TEST):
2085
2086 2019-03-23  Keith Miller  <keith_miller@apple.com>
2087
2088         Refactor clz/ctz and fix getLSBSet.
2089         https://bugs.webkit.org/show_bug.cgi?id=196162
2090
2091         Reviewed by Saam Barati.
2092
2093         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2094
2095         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2096         (TestWebKitAPI::TEST):
2097
2098 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2099
2100         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2101         https://bugs.webkit.org/show_bug.cgi?id=196143
2102
2103         Reviewed by Michael Catanzaro.
2104
2105         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2106         directories.
2107
2108         * Scripts/webkitpy/style/checkers/cpp.py:
2109         (check_identifier_name_in_declaration):
2110         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2111         (WebKitStyleTest.test_names):
2112
2113 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2114
2115         [Flatpak] Manifest expanding fails for qt WPE extension
2116         https://bugs.webkit.org/show_bug.cgi?id=196148
2117
2118         Reviewed by Alex Christensen.
2119
2120         * flatpak/flatpakutils.py:
2121         (expand_submodules_recurse): The last recurse manifest expand
2122         iteration might lead to a single module so take it into account
2123         and don't try to recurse further.
2124
2125 2019-03-22  Chris Dumez  <cdumez@apple.com>
2126
2127         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2128         https://bugs.webkit.org/show_bug.cgi?id=195348
2129         <rdar://problem/48622090>
2130
2131         Reviewed by Alex Christensen.
2132
2133         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2134         to NO when test.options().shouldIgnoreMetaViewport is false.
2135
2136         * WebKitTestRunner/ios/TestControllerIOS.mm:
2137         (WTR::TestController::platformConfigureViewForTest):
2138
2139 2019-03-22  Chris Dumez  <cdumez@apple.com>
2140
2141         Prewarmed processes should be usable with any website data store
2142         https://bugs.webkit.org/show_bug.cgi?id=196104
2143
2144         Reviewed by Alex Christensen.
2145
2146         Add API test coverage.
2147
2148         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2149         (runInitialWarmedProcessUsedTest):
2150         (TEST):
2151
2152 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2153
2154         Back out local changes to Alex's Subversion working directory
2155
2156         They were accidentally committed.
2157
2158         * Scripts/webkitpy/common/system/abstractexecutive.py:
2159         (AbstractExecutive.wait_newest):
2160         * Scripts/webkitpy/common/system/executive.py:
2161         (Executive.running_pids):
2162         * Scripts/webkitpy/common/system/executive_mock.py:
2163         (MockExecutive.running_pids):
2164         * Scripts/webkitpy/common/system/executive_unittest.py:
2165         (ExecutiveTest.serial_test_running_pids):
2166         * Scripts/webkitpy/port/darwin.py:
2167         (DarwinPort.check_for_leaks):
2168         * Scripts/webkitpy/port/leakdetector.py:
2169         (LeakDetector.check_for_leaks):
2170         - This was the hack attached to Bug 193772.
2171
2172         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2173         (+[WebKitTestRunnerEvent mouseLocation]):
2174         - This works around a crash on an internal build.
2175
2176 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2177
2178         Fix the build after r243354
2179         https://bugs.webkit.org/show_bug.cgi?id=196138
2180         <rdar://problem/49145951>
2181
2182         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2183         (TEST):
2184         * TestWebKitAPI/ios/UIKitSPI.h:
2185
2186 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2187
2188         Adopt UIWKDocumentContext
2189         https://bugs.webkit.org/show_bug.cgi?id=196040
2190         <rdar://problem/48642440>
2191
2192         Reviewed by Ryosuke Niwa.
2193
2194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2195         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2196         (makeRequest):
2197         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2198         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2199         (applyStyle):
2200         (TEST):
2201         Add tests for UIWKDocumentContext.
2202
2203         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2204         (TEST):
2205         (recursiveFindWKContentView): Deleted.
2206         * TestWebKitAPI/cocoa/TestWKWebView.h:
2207         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2208         (recursiveFindWKContentView):
2209         (-[TestWKWebView wkContentView]):
2210         * TestWebKitAPI/ios/UIKitSPI.h:
2211         Share the WKContentView finding code between tests.
2212
2213 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2214
2215         [iOS WK2] Turn on async overflow scrolling by default
2216         https://bugs.webkit.org/show_bug.cgi?id=196011
2217         rdar://problem/48453859
2218
2219         Reviewed by Antti Koivisto.
2220         
2221         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2222         since so many basic layout tests have different results when compositing is triggered for
2223         overflow.
2224         
2225         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2226
2227         * WebKitTestRunner/TestController.cpp:
2228         (WTR::TestController::resetPreferencesToConsistentValues):
2229
2230 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2231
2232         [ews-build] Retry API test in case of failures
2233         https://bugs.webkit.org/show_bug.cgi?id=196004
2234
2235         Reviewed by Lucas Forschler.
2236
2237         * BuildSlaveSupport/ews-build/steps.py:
2238         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2239         (CompileWebKitToT.doStepIf): Ditto.
2240         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2241         (ReRunAPITests): Re-run API tests.
2242         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2243         (RunAPITestsWithoutPatch): Run API tests without patch.
2244         (RunAPITestsWithoutPatch.doStepIf):
2245         (RunAPITestsWithoutPatch.hideStepIf):
2246         (RunAPITestsWithoutPatch.evaluateCommand):
2247         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2248         (AnalyzeAPITestsResults.start):
2249         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2250         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2251         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2252         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2253
2254 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2255
2256         [ews-build] Update queues configurations
2257         https://bugs.webkit.org/show_bug.cgi?id=196074
2258
2259         Reviewed by Dewei Zhu.
2260
2261         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2262         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2263
2264 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2265
2266         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2267         https://bugs.webkit.org/show_bug.cgi?id=195680
2268         <rdar://problem/48903534>
2269
2270         Unreviewed infrastructure fix.
2271
2272         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2273         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2274
2275 2019-03-21  Andy Estes  <aestes@apple.com>
2276
2277         [iOS] Apple Pay should be available in documents with no user agent scripts
2278         https://bugs.webkit.org/show_bug.cgi?id=196061
2279         <rdar://problem/48649391>
2280
2281         Reviewed by Brady Eidson.
2282
2283         Added API tests and related infrastructure.
2284
2285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2286         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2287         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2288         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2289         (TestWebKitAPI::TEST):
2290         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2291         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2292         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2293         * TestWebKitAPI/cocoa/TestProtocol.mm:
2294         (-[TestProtocol startLoading]):
2295         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2296         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2297         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2298         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2299
2300 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2301
2302         REGRESSSION (r243297): webkitpy tests broken
2303         https://bugs.webkit.org/show_bug.cgi?id=196108
2304
2305         Reviewed by Aakash Jain.
2306
2307         r243297 updated contributors.json, which broke a few unit tests.
2308
2309         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2310         (IRCCommandTest.test_whois):
2311         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2312
2313 2019-03-21  Chris Dumez  <cdumez@apple.com>
2314
2315         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2316         https://bugs.webkit.org/show_bug.cgi?id=196041
2317         <rdar://problem/49083230>
2318
2319         Reviewed by Alex Christensen.
2320
2321         Add API test coverage.
2322
2323         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2324         (TEST):
2325
2326 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2327
2328         Add SPI to inform applications of WKContentRuleList actions
2329         https://bugs.webkit.org/show_bug.cgi?id=195965
2330         <rdar://problem/42664365>
2331
2332         Reviewed by Geoff Garen.
2333
2334         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2335         (TestWebKitAPI::allActionsForResourceLoad):
2336         (TestWebKitAPI::testRequest):
2337         (TestWebKitAPI::TEST_F):
2338         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2339         (Notification::description):
2340         (Notification::operator== const):
2341         (toVector):
2342         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2343         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2344         (makeContentRuleList):
2345         (TEST):
2346         (makeWarnContentRuleList): Deleted.
2347
2348 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2349
2350         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2351         https://bugs.webkit.org/show_bug.cgi?id=196088
2352
2353         Reviewed by Brian Burg.
2354
2355         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2356         Support checks when only one platform is specified. Also deprecate macosx() and
2357         force the use of macos() instead.
2358
2359         * Scripts/webkitpy/style/checkers/cpp.py:
2360         (check_min_versions_of_wk_api_available):
2361         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2362         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2363
2364 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2365
2366         Update status inactive committers' status to 'contributor'.
2367
2368         * Scripts/webkitpy/common/config/contributors.json:
2369
2370 2019-03-21  Xan Lopez  <xan@igalia.com>
2371
2372         [JSC][x86] Drop support for x87 floating point
2373         https://bugs.webkit.org/show_bug.cgi?id=194853
2374
2375         Reviewed by Don Olmstead.
2376
2377         Force SSE2 on x86/32bit builds.
2378
2379         * Scripts/webkitdirs.pm:
2380         (generateBuildSystemFromCMakeProject):
2381
2382 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2383
2384         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2385         https://bugs.webkit.org/show_bug.cgi?id=196073
2386
2387         Reviewed by Michael Catanzaro.
2388
2389         Add test cases to check functions and constructors with no arguments but receiving user data.
2390
2391         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2392         (checkUserData):
2393         (testJSCFunction):
2394         (fooCreateWithUserData):
2395         (testJSCClass):
2396
2397 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2398
2399         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2400
2401         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2402
2403         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2404
2405 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2406
2407         [GTK][WPE] Add API to provide geolocation information
2408         https://bugs.webkit.org/show_bug.cgi?id=195940
2409
2410         Reviewed by Michael Catanzaro.
2411
2412         Add a new test to check the new API.
2413
2414         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2415         (testGeolocationManagerCurrentPosition):
2416         (testGeolocationManagerWatchPosition):
2417         (beforeAll):
2418         (afterAll):
2419         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2420         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2421         (beforeAll): Ditto.
2422         * TestWebKitAPI/glib/CMakeLists.txt:
2423
2424 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2425
2426         [GLib] Returning G_TYPE_OBJECT from a method does not work
2427         https://bugs.webkit.org/show_bug.cgi?id=195574
2428
2429         Reviewed by Michael Catanzaro.
2430
2431         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2432
2433         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2434         (getGFile):
2435         (getParent):
2436         (createGString):
2437         (getGString):
2438         (getGStringCopyWillRaise):
2439         (getGStringCopy):
2440         (getGStringStr):
2441         (getGStringLen):
2442         (freeGString):
2443         (testJSCClass):
2444
2445 2019-03-20  Saam Barati  <sbarati@apple.com>
2446
2447         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2448         https://bugs.webkit.org/show_bug.cgi?id=195721
2449
2450         Reviewed by Filip Pizlo.
2451
2452         * Scripts/run-javascriptcore-tests:
2453
2454 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2455
2456         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2457         https://bugs.webkit.org/show_bug.cgi?id=196049
2458
2459         Reviewed by Tim Horton.
2460
2461         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2462         overflow scrolling in general, so rename it.
2463
2464         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2465
2466 2019-03-20  Daniel Bates  <dabates@apple.com>
2467
2468         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2469         https://bugs.webkit.org/show_bug.cgi?id=196031
2470         <rdar://problem/49078172>
2471
2472         Reviewed by Tim Horton.
2473
2474         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2475         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2476         same code path used when the Done button is pressed to dismiss the <select> picker.
2477
2478         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2479         (TestWebKitAPI::TEST):
2480
2481 2019-03-20  Chris Dumez  <cdumez@apple.com>
2482
2483         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2484         https://bugs.webkit.org/show_bug.cgi?id=196029
2485         <rdar://problem/48954651>
2486
2487         Reviewed by Tim Horton.
2488
2489         Add API test coverage.
2490
2491         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2492
2493 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2494
2495         [ews-build] Improve failure summary string for ApplyPatch step
2496         https://bugs.webkit.org/show_bug.cgi?id=195995
2497
2498         Reviewed by Alexey Proskuryakov.
2499
2500         * BuildSlaveSupport/ews-build/steps.py:
2501         (ApplyPatch.getResultSummary): Override getResultSummary.
2502
2503 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2504
2505         AX: Implement support for new meter ARIA role
2506         https://bugs.webkit.org/show_bug.cgi?id=195966
2507
2508         Reviewed by Chris Fleizach.
2509
2510         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2511         to AXLevelIndicator.
2512
2513         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2514
2515 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2516
2517         [WebAuthN] Implement FIDO AppID extension
2518         https://bugs.webkit.org/show_bug.cgi?id=143491
2519         <rdar://problem/48298273>
2520
2521         Reviewed by Brent Fulgham.
2522
2523         Add a test that covers the new flag of convertToU2fSignCommand.
2524
2525         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2526         (TestWebKitAPI::TEST):
2527         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2528         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2529         (TestWebKitAPI::TEST):
2530
2531 2019-03-19  Keith Rollin  <krollin@apple.com>
2532
2533         Add support for more platforms to generate-xcfilelists
2534         https://bugs.webkit.org/show_bug.cgi?id=195977
2535
2536         Reviewed by Alexey Proskuryakov.
2537
2538         generate-xcfilelists incorrectly complains when involved with building
2539         WebKit for iphonesimulator:
2540
2541             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2542             …
2543             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2544
2545         Address this by teaching generate-xcfilelists about more platforms.
2546
2547         * Scripts/generate-xcfilelists:
2548
2549 2019-03-19  John Wilander  <wilander@apple.com>
2550
2551         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2552         https://bugs.webkit.org/show_bug.cgi?id=195923
2553         <rdar://problem/49001272>
2554
2555         Reviewed by Alex Christensen.
2556
2557         This patch does the following to the TestRunner:
2558         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2559         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2560         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2561
2562         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2563         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2564         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2565         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2566         * WebKitTestRunner/TestController.cpp:
2567         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2568         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2569         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2570         * WebKitTestRunner/TestController.h:
2571         * WebKitTestRunner/TestInvocation.cpp:
2572         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2573
2574 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2575
2576         [CMake] Support more clang and gcc sanitizers
2577         https://bugs.webkit.org/show_bug.cgi?id=195956
2578
2579         Reviewed by Michael Catanzaro.
2580
2581         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2582
2583 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2584
2585         [ews-build] Improve summary for PrintConfiguration step
2586         https://bugs.webkit.org/show_bug.cgi?id=195945
2587
2588         Reviewed by Lucas Forschler.
2589
2590         * BuildSlaveSupport/ews-build/steps.py:
2591         (PrintConfiguration.getResultSummary): Override getResultSummary.
2592
2593 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2594
2595         [ews-build] Improve summary for CheckOutSource step
2596         https://bugs.webkit.org/show_bug.cgi?id=195963
2597
2598         Reviewed by Lucas Forschler.
2599
2600         * BuildSlaveSupport/ews-build/steps.py:
2601         (CheckOutSource.getResultSummary):
2602
2603 2019-03-19  Daniel Bates  <dabates@apple.com>
2604
2605         [iOS] Focus not preserved when switching between tabs
2606         https://bugs.webkit.org/show_bug.cgi?id=195820
2607         <rdar://problem/43614450>
2608
2609         Reviewed by Brent Fulgham.
2610
2611         Add tests to ensure that we restore focus when resigning and becoming first responder.
2612
2613         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2614         (TestWebKitAPI::TEST):
2615
2616 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2617
2618         Make WTFLogChannelState and WTFLogLevel enum classes
2619         https://bugs.webkit.org/show_bug.cgi?id=195904
2620
2621         Reviewed by Eric Carlson.
2622
2623         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2624         (TestWebKitAPI::TEST_F):
2625
2626 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2627
2628         [GStreamer][EME] Backported mssdemux protection data crash fix
2629         https://bugs.webkit.org/show_bug.cgi?id=195918
2630
2631         Reviewed by Philippe Normand.
2632
2633         * gstreamer/jhbuild.modules:
2634         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2635
2636 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2637
2638         Unreviewed, rolling out r243132.
2639
2640         Broke GTK build
2641
2642         Reverted changeset:
2643
2644         "Make WTFLogChannelState and WTFLogLevel enum classes"
2645         https://bugs.webkit.org/show_bug.cgi?id=195904
2646         https://trac.webkit.org/changeset/243132
2647
2648 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2649
2650         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2651
2652         * Scripts/webkitdirs.pm:
2653         (builtDylibPathForName): Adjust the shared library name that's changed
2654         with the API version bump in r243073.
2655
2656 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2657
2658         Make WTFLogChannelState and WTFLogLevel enum classes
2659         https://bugs.webkit.org/show_bug.cgi?id=195904
2660
2661         Reviewed by Eric Carlson.
2662
2663         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2664         (TestWebKitAPI::TEST_F):
2665
2666 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2667
2668         Disable flaky test added in r2431100
2669         https://webkit.org/b/195785
2670
2671         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2672         (TestWebKitAPI::TEST):
2673         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2674
2675 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2676
2677         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2678         https://bugs.webkit.org/show_bug.cgi?id=195916
2679
2680         Reviewed by Tim Horton.
2681
2682         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2683         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2684
2685 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2686
2687         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2688
2689         * Scripts/webkitpy/common/config/contributors.json:
2690
2691 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2692
2693         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2694         https://bugs.webkit.org/show_bug.cgi?id=195785
2695
2696         Reviewed by Geoffrey Garen.
2697
2698         * TestWebKitAPI/TCPServer.cpp: Added.
2699         (TestWebKitAPI::TCPServer::TCPServer):
2700         (TestWebKitAPI::TCPServer::~TCPServer):
2701         (TestWebKitAPI::TCPServer::socketBindListen):
2702         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2703         * TestWebKitAPI/TCPServer.h: Added.
2704         (TestWebKitAPI::TCPServer::port const):
2705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2706         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2707         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2708         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2709         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2710         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2711         (TestWebKitAPI::respondSlowly):
2712         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2713         (TestWebKitAPI::downloadAtRate):
2714         (TestWebKitAPI::TEST):
2715
2716 2019-03-18  Saam Barati  <sbarati@apple.com>
2717
2718         Add a plan file for JetStream 2
2719         https://bugs.webkit.org/show_bug.cgi?id=190734
2720
2721         Reviewed by Mark Lam.
2722
2723         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2724
2725 2019-03-18  Chris Dumez  <cdumez@apple.com>
2726
2727         Delay WebProcess launch until a load is triggered in a Web view
2728         https://bugs.webkit.org/show_bug.cgi?id=195758
2729         <rdar://problem/48126013>
2730
2731         Reviewed by Geoff Garen.
2732
2733         Add API test coverage. Also update some existing API tests to not expect
2734         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2735
2736         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2737         (TestWebKitAPI::TEST):
2738         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2739         (TestWebKitAPI::TEST):
2740         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2741         (TEST):
2742         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2743         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2744         (TEST):
2745         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2746         (TEST):
2747         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2748
2749 2019-03-18  Xan Lopez  <xan@igalia.com>
2750
2751         [CMake] Prevent potential warning when determining $architecture
2752         https://bugs.webkit.org/show_bug.cgi?id=195891
2753
2754         Reviewed by Michael Catanzaro.
2755
2756         It's possible for generateBuildSystemForCMakeProject to be called
2757         before determineArchitecture() is ever called. This will make the
2758         first eq check with $architecture to be bogus (and print a
2759         warning). Change that to an eq check with architecture(), which
2760         implicitly calls determineArchitecture() if needed, and change all
2761         the other similar cases in the method in the same way to prevent
2762         future bugs like this one.
2763
2764         * Scripts/webkitdirs.pm:
2765         (generateBuildSystemFromCMakeProject):
2766
2767 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2768
2769         [WPE] Tarballs generated with “make dist” cannot build documentation
2770         https://bugs.webkit.org/show_bug.cgi?id=195885
2771
2772         Reviewed by Carlos Garcia Campos.
2773
2774         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2775
2776 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2777
2778         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2779         https://bugs.webkit.org/show_bug.cgi?id=195883
2780
2781         Reviewed by Carlos Garcia Campos.
2782
2783         * gtkdoc/gtkdoc.py:
2784         (GTKDoc._run_command): When commands fail to run, include the full command line for
2785         the program invocation and the output it has generated on the standard error stream.
2786
2787 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2788
2789         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2790         https://bugs.webkit.org/show_bug.cgi?id=195786
2791
2792         Reviewed by Philippe Normand.
2793
2794         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2795         * wpe/jhbuild.modules: Ditto.
2796
2797 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2798
2799         [ews-build] Don't run clean builds on EWS builders
2800         https://bugs.webkit.org/show_bug.cgi?id=195851
2801
2802         Reviewed by Geoffrey Garen.
2803
2804         * BuildSlaveSupport/ews-build/factories.py:
2805
2806 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2807
2808         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2809         https://bugs.webkit.org/show_bug.cgi?id=195849
2810
2811         Reviewed by Chris Dumez.
2812
2813         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2814
2815         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2816         (runWebsiteDataStoreCustomPaths):
2817
2818 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2819
2820         webkitpy: Upload test results
2821         https://bugs.webkit.org/show_bug.cgi?id=195755
2822         <rdar://problem/48896182>
2823
2824         Reviewed by Aakash Jain.
2825
2826         Establish a new format for uploading results that is not tied to layout tests, apply
2827         that format to webkitpy tests.
2828
2829         * Scripts/webkitpy/common/checkout/scm/git.py:
2830         (Git.native_branch): Return what branch the current checkout is on.
2831         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2832         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2833         * Scripts/webkitpy/common/checkout/scm/svn.py:
2834         (SVN.native_branch): Ditto.
2835         * Scripts/webkitpy/common/system/platforminfo.py:
2836         (PlatformInfo.build_version): Return a build version for Mac.
2837         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2838         (MockPlatformInfo.__init__):
2839         (MockPlatformInfo.build_version):
2840         * Scripts/webkitpy/results: Added.
2841         * Scripts/webkitpy/results/__init__.py: Added.
2842         * Scripts/webkitpy/results/options.py: Added.
2843         (upload_options): OptParse list for upload options.
2844         * Scripts/webkitpy/results/upload.py: Added.
2845         (Upload): Class which enforces the upload format expected by the results server.
2846         (Upload.Expectations):
2847         (Upload.create_configuration):
2848         (Upload.create_commit):
2849         (Upload.create_details):
2850         (Upload.create_run_stats):
2851         (Upload.create_test_result):
2852         (Upload.__init__):
2853         (Upload.Encoder): Encode Upload object as json.
2854         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2855         * Scripts/webkitpy/results/upload_unittest.py: Added.
2856         * Scripts/webkitpy/test/main.py:
2857         (Tester._parse_args): Add upload arguments.
2858         (Tester._run_tests): Allow results to be uploaded.
2859         * Scripts/webkitpy/test/runner.py:
2860         (Runner.__init__): Record which tests were run, rather than just counting them.
2861         (Runner.handle):
2862         * Scripts/webkitpy/test/runner_unittest.py:
2863         (RunnerTest.test_run):
2864         * Scripts/webkitpy/thirdparty/__init__.py:
2865         (AutoinstallImportHook.find_module): Add requests auto-install.
2866         (AutoinstallImportHook._install_requests):
2867         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2868         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2869
2870 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2871
2872         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2873         https://bugs.webkit.org/show_bug.cgi?id=195810
2874
2875         Reviewed by Tim Horton.
2876
2877         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2878         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2879         ending certain layout tests.
2880
2881         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2882         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2883         (-[TestRunnerWKWebView dealloc]):
2884         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2885
2886         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2887         helper method when destroying the web view, and when resetting state between tests.
2888
2889         * WebKitTestRunner/ios/TestControllerIOS.mm:
2890         (WTR::TestController::platformResetStateToConsistentValues):
2891
2892         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2893
2894 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2895
2896         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2897         https://bugs.webkit.org/show_bug.cgi?id=190350
2898         <rdar://problem/45089503>
2899
2900         Reviewed by Geoffrey Garen.
2901
2902         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2903         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2904         (TEST):
2905         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2906         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2907         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2908         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2909         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2910         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2911         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2912         (runTest):
2913         (createDirectories):
2914         (TEST):
2915         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2916         (TEST):
2917         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2918         (TEST):
2919
2920 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2921
2922         Add support to WebPage for getting the contents as an attributed string.
2923         https://bugs.webkit.org/show_bug.cgi?id=195636
2924         rdar://problem/45055697
2925
2926         Reviewed by Tim Horton.
2927
2928         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2929         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2930
2931 2019-03-15  Chris Dumez  <cdumez@apple.com>
2932
2933         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2934         https://bugs.webkit.org/show_bug.cgi?id=195747
2935
2936         Reviewed by Geoff Garen.
2937
2938         Add API test coverage.
2939
2940         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2941
2942 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2943
2944         Unreviewed, rolling out r242952.
2945
2946         Causing API failures on iOS Simulator
2947
2948         Reverted changeset:
2949
2950         "[PSON] Make sure the WebProcessCache is leverage when
2951         relaunching a process after termination"
2952         https://bugs.webkit.org/show_bug.cgi?id=195747
2953         https://trac.webkit.org/changeset/242952
2954
2955 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2956
2957         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2958         https://bugs.webkit.org/show_bug.cgi?id=195740
2959
2960         Reviewed by Ross Kirsling.
2961
2962         window.open doesn't work for WebKitBrowserWindow because it is not
2963         implemented yet.
2964
2965         1. Implemented createNewPage callback of WKPageUIClient.
2966         2. Changed MainWindow to take a BrowserWindow factory function
2967           instead of BrowserWindowType to be flexible to create
2968           BrowserWindow with extra settings.
2969         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2970           because it is not relevant with MainWindow anymore.
2971
2972         * MiniBrowser/win/Common.cpp:
2973         (parseCommandLine):
2974         * MiniBrowser/win/Common.h:
2975         (CommandLineOptions::CommandLineOptions):
2976         * MiniBrowser/win/MainWindow.cpp:
2977         (MainWindow::MainWindow):
2978         (MainWindow::create):
2979         (MainWindow::init):
2980         (MainWindow::WndProc):
2981         * MiniBrowser/win/MainWindow.h:
2982         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2983         (PrintWebUIDelegate::createWebViewWithRequest):
2984         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2985         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2986         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2987         (WebKitBrowserWindow::updateProxySettings):
2988         (WebKitBrowserWindow::createNewPage):
2989         * MiniBrowser/win/WebKitBrowserWindow.h:
2990         * MiniBrowser/win/WinMain.cpp:
2991         (wWinMain):
2992
2993 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2994
2995         Make it possible to test scrolling tree layer manipulation more easily
2996         https://bugs.webkit.org/show_bug.cgi?id=195780
2997
2998         Reviewed by Tim Horton.
2999         
3000         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3001         cuts off communication of scrolling tree scrolls back to the web process
3002         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3003         allows tests to trigger scrolls which run the scrolling tree layer positioning
3004         logic, but never get another commit from the web process that might mask
3005         scrolling tree bugs.
3006         
3007         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3008         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3009         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3010
3011         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3012         (WTR::UIScriptController::scrollUpdatesDisabled const):
3013         (WTR::UIScriptController::setScrollUpdatesDisabled):
3014         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3015         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3016         (WTR::UIScriptController::scrollUpdatesDisabled const):
3017         (WTR::UIScriptController::setScrollUpdatesDisabled):
3018         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3019         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3020         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3021         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3022         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3023         * WebKitTestRunner/ios/TestControllerIOS.mm:
3024         (WTR::TestController::platformResetStateToConsistentValues):
3025         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3026         (WTR::UIScriptController::scrollUpdatesDisabled const):
3027         (WTR::UIScriptController::setScrollUpdatesDisabled):
3028
3029 2019-03-14  Youenn Fablet  <youenn@apple.com>
3030
3031         Move IDB storage in private browsing mode to NetworkProcess
3032         https://bugs.webkit.org/show_bug.cgi?id=195602
3033
3034         Reviewed by Brady Eidson.
3035
3036         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3037         (TEST):
3038
3039 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3040
3041         [ews-build] Make descriptionDone messages more readable
3042         https://bugs.webkit.org/show_bug.cgi?id=195760
3043
3044         Reviewed by Lucas Forschler.
3045
3046         * BuildSlaveSupport/ews-build/steps.py:
3047         * BuildSlaveSupport/ews-build/steps_unittest.py:
3048
3049 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3050
3051         [ews-build] Generate status-bubble hover-over messages
3052         https://bugs.webkit.org/show_bug.cgi?id=195680
3053
3054         Reviewed by Lucas Forschler.
3055
3056         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3057         (StatusBubble):
3058         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3059         on hover-over.
3060         (StatusBubble._iso_time):
3061         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3062         hover-over message.
3063         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3064
3065 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3066
3067         [ews-app] Gracefully handle the case when state_string is None
3068         https://bugs.webkit.org/show_bug.cgi?id=195753
3069
3070         Reviewed by Lucas Forschler.
3071
3072         * BuildSlaveSupport/ews-app/ews/models/build.py:
3073         * BuildSlaveSupport/ews-app/ews/models/step.py:
3074
3075 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3076
3077         [ews-app] Status bubble display pending for currently running build step
3078         https://bugs.webkit.org/show_bug.cgi?id=195744
3079
3080         Reviewed by Lucas Forschler.
3081
3082         * BuildSlaveSupport/ews-build/events.py:
3083         (Events.stepStarted): If state_string is pending, replace it with step name.
3084
3085 2019-03-14  Chris Dumez  <cdumez@apple.com>
3086
3087         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3088         https://bugs.webkit.org/show_bug.cgi?id=195750
3089
3090         Reviewed by Geoffrey Garen.
3091
3092         Add API test coverage.
3093
3094         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3095         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3096         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3097         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3098
3099 2019-03-14  Chris Dumez  <cdumez@apple.com>
3100
3101         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3102         https://bugs.webkit.org/show_bug.cgi?id=195747
3103
3104         Reviewed by Geoff Garen.
3105
3106         Add API test coverage.
3107
3108         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3109
3110 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3111
3112         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3113         https://bugs.webkit.org/show_bug.cgi?id=195725
3114         <rdar://problem/48545062>
3115
3116         Reviewed by Tim Horton.
3117
3118         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3119         handler is nil.
3120
3121         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3122         (TestWebKitAPI::TEST):
3123
3124 2019-03-13  Sam Weinig  <sam@webkit.org>
3125
3126         Add utility function to allow easy reverse range-based iteration of a container
3127         https://bugs.webkit.org/show_bug.cgi?id=195542
3128
3129         Reviewed by Antti Koivisto.
3130
3131         * TestWebKitAPI/CMakeLists.txt:
3132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3133         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3134         (TestWebKitAPI::TEST):
3135         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3136
3137 2019-03-13  Chris Dumez  <cdumez@apple.com>
3138
3139         Use a ServiceWorker process per registrable domain
3140         https://bugs.webkit.org/show_bug.cgi?id=195649
3141
3142         Reviewed by Youenn Fablet.
3143
3144         Update API test coverage.
3145
3146         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3147
3148 2019-03-13  Chris Dumez  <cdumez@apple.com>
3149
3150         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3151         https://bugs.webkit.org/show_bug.cgi?id=195684
3152         <rdar://problem/48294714>
3153
3154         Reviewed by Antti Koivisto.
3155
3156         Add API test coverage.
3157
3158         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3159
3160 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3161
3162         [ews-app] Remove unused patch view
3163         https://bugs.webkit.org/show_bug.cgi?id=195669
3164
3165         Reviewed by Lucas Forschler.
3166
3167         * BuildSlaveSupport/ews-app/ews/urls.py:
3168         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3169
3170 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3171
3172         [ews-app] Use Buildbot result code variables
3173         https://bugs.webkit.org/show_bug.cgi?id=195668
3174
3175         Reviewed by Alexey Proskuryakov.
3176
3177         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3178         (Buildbot): Added Buildbot result code variables.
3179         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3180         (StatusBubble._build_bubble): Used Buildbot result code variables.
3181
3182 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3183
3184         [Flatpak] Expand submodule recursively
3185         https://bugs.webkit.org/show_bug.cgi?id=195672
3186
3187         Building WPE with flatpak was impossible without that as it was raising an exception.
3188         Also update wpebackend-fdo to match what is built in jhbuild
3189
3190         Reviewed by Philippe Normand.
3191
3192         * flatpak/flatpakutils.py:
3193         (expand_submodules_recurse):
3194         (expand_manifest):
3195         * flatpak/org.webkit.WPEModules.yaml:
3196
3197 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3198
3199         [ews-app] status bubble should be hidden for certain builds
3200         https://bugs.webkit.org/show_bug.cgi?id=194597
3201
3202         Reviewed by Dewei Zhu.
3203
3204         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3205         (StatusBubble._build_bubble):
3206         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3207         because the patch didn't have relevant changes.
3208         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3209         in production yet.
3210
3211 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3212
3213         [Win] Fix a slew of simple clang-cl warnings.
3214         https://bugs.webkit.org/show_bug.cgi?id=195652
3215
3216         Reviewed by Don Olmstead.
3217
3218         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3219         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3220
3221 2019-03-12  Justin Fan  <justin_fan@apple.com>
3222
3223         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3224         https://bugs.webkit.org/show_bug.cgi?id=195518
3225         <rdar://problem/46322356>
3226
3227         Reviewed by Myles C. Maxfield.
3228
3229         * DumpRenderTree/DerivedSources-input.xcfilelist:
3230         * DumpRenderTree/DerivedSources-output.xcfilelist:
3231
3232 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3233
3234         Unreviewed, rolling out r242825.
3235         https://bugs.webkit.org/show_bug.cgi?id=195648
3236
3237         "Broke webkitpy tests with my change to
3238         lldb_dump_class_layout.py" (Requested by rmorisset on
3239         #webkit).
3240
3241         Reverted changeset:
3242
3243         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3244         classes with suspicious padding"
3245         https://bugs.webkit.org/show_bug.cgi?id=195573
3246         https://trac.webkit.org/changeset/242825
3247
3248 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3249
3250         [ews-build] Show status bubbles while the patch is waiting in queue
3251         https://bugs.webkit.org/show_bug.cgi?id=195618
3252
3253         Reviewed by Lucas Forschler.
3254
3255         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3256         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3257         enabled in initial deployment.
3258         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3259         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3260         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3261         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3262         (StatusBubble._build_bubbles_for_patch):
3263
3264 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3265
3266         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3267         https://bugs.webkit.org/show_bug.cgi?id=195573
3268
3269         Reviewed by Simon Fraser.
3270
3271         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3272
3273         * Scripts/dump-class-layout:
3274         (main):
3275         * lldb/lldb_dump_class_layout.py:
3276         (ClassLayout.__init__):
3277         (ClassLayout._compute_padding_recursive):
3278         (LLDBDebuggerInstance.dump_layout_for_classname):
3279         (LLDBDebuggerInstance):
3280         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3281         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3282
3283 2019-03-12  Chris Dumez  <cdumez@apple.com>
3284
3285         Device Orientation access permission should be denied unless explicitly granted by the client
3286         https://bugs.webkit.org/show_bug.cgi?id=195625
3287
3288         Reviewed by Youenn Fablet.
3289
3290         add API test coverage.
3291
3292         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3293         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3294         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3295         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3296         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3297         (runDeviceOrientationTest):
3298         (TEST):
3299         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3300         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3301
3302 2019-03-12  Jer Noble  <jer.noble@apple.com>
3303
3304         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3305         https://bugs.webkit.org/show_bug.cgi?id=195137
3306         <rdar://problem/48810307>
3307
3308         Reviewed by Eric Carlson.
3309
3310         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3311         (TestWebKitAPI::TEST):
3312
3313 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3314
3315         [ews-build] Change urls from uat to production
3316         https://bugs.webkit.org/show_bug.cgi?id=195566
3317
3318         Reviewed by Lucas Forschler.
3319
3320         * BuildSlaveSupport/ews-app/ews/config.py:
3321         * BuildSlaveSupport/ews-build/events.py:
3322         * BuildSlaveSupport/ews-build/steps.py:
3323
3324 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3325
3326         [ews-build] change max_builds for local-worker to 1
3327         https://bugs.webkit.org/show_bug.cgi?id=195568
3328
3329         Reviewed by Lucas Forschler.
3330
3331         * BuildSlaveSupport/ews-build/loadConfig.py:
3332
3333 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3334
3335         Fix the build
3336
3337         * TestRunnerShared/spi/PencilKitTestSPI.h:
3338         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3339
3340 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3341
3342         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3343         https://bugs.webkit.org/show_bug.cgi?id=194131
3344
3345         Reviewed by Michael Catanzaro.
3346
3347         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3348         (uriChanged):
3349         (testUnfinishedSubresourceLoad):
3350         (serverCallback):
3351         (beforeAll):
3352
3353 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3354
3355         WTF::Expected should use std::addressof instead of operator&
3356         https://bugs.webkit.org/show_bug.cgi?id=195604
3357
3358         Reviewed by Myles Maxfield.
3359
3360         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3361         (TestWebKitAPI::Unique::Unique):
3362         (TestWebKitAPI::Unique::operator&):
3363         (TestWebKitAPI::TEST):
3364
3365 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3366
3367         Add Optional to Forward.h.
3368         https://bugs.webkit.org/show_bug.cgi?id=195586
3369
3370         Reviewed by Darin Adler.
3371
3372         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3373         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3374         Remove unnecessary includes from headers.
3375
3376 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3377
3378         Add testing API to hit-test and scroll overflow scrollers
3379         https://bugs.webkit.org/show_bug.cgi?id=195278
3380
3381         Reviewed by Antti Koivisto.
3382         
3383         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3384         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3385         
3386         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3387
3388         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3389         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3390         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3391         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3392         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3393         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3394         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3395         (WTR::enclosingScrollViewIncludingSelf):
3396         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3397
3398 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3399
3400         API test WebKit.RequestTextInputContext fails on iOS
3401         https://bugs.webkit.org/show_bug.cgi?id=195585
3402
3403         Reviewed by Wenson Hsieh and Simon Fraser.
3404
3405         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3406         (applyStyle):
3407         (TEST):
3408         Add a viewport, so that the coordinates match up on iOS.
3409         Scroll by moving the UIScrollView's contentOffset.
3410
3411 2019-03-11  Chris Dumez  <cdumez@apple.com>
3412
3413         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3414         https://bugs.webkit.org/show_bug.cgi?id=195506
3415         <rdar://problem/48733477>
3416
3417         Reviewed by Alex Christensen.
3418
3419         Add API test coverage.
3420
3421         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3422
3423 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3424
3425         Adding myself to contributors.json
3426
3427         Unreviewed, addming myself to contributors.json .
3428
3429         * Scripts/webkitpy/common/config/contributors.json:
3430
3431 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3432
3433         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3434         https://bugs.webkit.org/show_bug.cgi?id=195511
3435         <rdar://problem/44873269>
3436
3437         Reviewed by Darin Adler.
3438
3439         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3440         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3441         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3442         (TEST_F):
3443
3444 2019-03-11  Chris Dumez  <cdumez@apple.com>
3445
3446         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3447         https://bugs.webkit.org/show_bug.cgi?id=195561
3448
3449         Reviewed by Youenn Fablet.
3450
3451         Make sure the JS in the test requests for permission to receive device orientation events.
3452
3453         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3454
3455 2019-03-11  Youenn Fablet  <youenn@apple.com>
3456
3457         Allow storage quota increase by default in WTR
3458         https://bugs.webkit.org/show_bug.cgi?id=195541
3459
3460         Reviewed by Geoffrey Garen.
3461
3462         Allow storage quota increase by default in WTR.
3463         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3464         Use this for tests that explicitly need cache increase.
3465
3466         Instead of increasing quota by 2, make sure the next request is
3467         granted by adding all given parameters.
3468
3469         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3470         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3471         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3472         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3473         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3474         * WebKitTestRunner/TestController.cpp:
3475         (WTR::TestController::setAllowStorageQuotaIncrease):
3476         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3477         * WebKitTestRunner/TestController.h:
3478         * WebKitTestRunner/TestInvocation.cpp:
3479         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3480         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3481         (WTR::TestController::cocoaResetStateToConsistentValues):
3482         (WTR::TestController::setAllowStorageQuotaIncrease):
3483         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3484         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3485         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3486
3487 2019-03-11  Xan Lopez  <xan@igalia.com>
3488
3489         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3490         https://bugs.webkit.org/show_bug.cgi?id=194147
3491
3492         Reviewed by Michael Saboff.
3493
3494         To make --32-bit work correctly on Linux/64bit we need to:
3495
3496         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3497         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3498         unfortunately CMake only allows us to do this during
3499         crosscompilation, which is overkill here.
3500         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3501         pkg-config detection module uses the x86 .pc files instead of the
3502         x86_64 ones.
3503         - Set the -m32 flags for the compiler.
3504
3505         * Scripts/webkitdirs.pm:
3506         (generateBuildSystemFromCMakeProject):
3507
3508 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3509
3510         Add MotionMark-1.1 plan file for run-benchmark script.
3511         https://bugs.webkit.org/show_bug.cgi?id=195481
3512
3513         Rubber-stamped by Darin Adler.
3514
3515         Run-benchmark script should support MontionMark-1.1.
3516
3517         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3518
3519 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3520
3521         [ews-app] Add support for submit-to-ews url
3522         https://bugs.webkit.org/show_bug.cgi?id=195477
3523
3524         Reviewed by Lucas Forschler.
3525
3526         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3527         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3528         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3529         * BuildSlaveSupport/ews-app/ews/urls.py:
3530         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3531
3532 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3533
3534         Unreviewed, rolling out r242688, r242643, r242624.
3535
3536         Caused multiple layout test failures and crashes on iOS and macOS.
3537
3538         Reverted changeset:
3539
3540         "requestAnimationFrame should execute before the next frame"
3541         https://bugs.webkit.org/show_bug.cgi?id=177484
3542         https://trac.webkit.org/changeset/242624/webkit
3543
3544         * Tracing/SystemTracePoints.plist:
3545
3546 2019-03-11  John Wilander  <wilander@apple.com>
3547
3548         Resource Load Statistics: Make it possible exclude localhost from classification
3549         https://bugs.webkit.org/show_bug.cgi?id=195474
3550         <rdar://problem/47520577>
3551
3552         Reviewed by Brent Fulgham.
3553
3554         This patch allows for localhost to be excluded from classification and
3555         treatment as a prevalent resource.
3556
3557         The WebKit Tools change adds a new function called
3558         testRunner.setStatisticsIsRunningTest() which can be used to control this
3559         behavior.
3560
3561         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3562         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3563         (WTR::TestRunner::setStatisticsIsRunningTest):
3564         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3565         * WebKitTestRunner/TestController.cpp:
3566         (WTR::TestController::setStatisticsIsRunningTest):
3567         * WebKitTestRunner/TestController.h:
3568         * WebKitTestRunner/TestInvocation.cpp:
3569         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3570
3571 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3572
3573         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3574         https://bugs.webkit.org/show_bug.cgi?id=195560
3575
3576         Reviewed by Lucas Forschler.
3577
3578         * BuildSlaveSupport/ews-build/master.cfg:
3579
3580 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3581
3582         Unreviewed, rolling out r242698.
3583
3584         API test crashes on bots.
3585
3586         Reverted changeset:
3587
3588         "Add a WKContentRuleList variant that uses copied memory
3589         instead of mmap'd shared memory for class A containerized
3590         apps"
3591         https://bugs.webkit.org/show_bug.cgi?id=195511
3592         https://trac.webkit.org/changeset/242698
3593
3594 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3595
3596         [WPE] Enable web process sandbox
3597         https://bugs.webkit.org/show_bug.cgi?id=195169
3598
3599         Reviewed by Daniel Bates.
3600
3601         * wpe/install-dependencies:
3602         * wpe/jhbuild.modules:
3603
3604 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3605
3606         [ews-app] Use port 17000 for worker communication
3607         https://bugs.webkit.org/show_bug.cgi?id=195558
3608
3609         Reviewed by Lucas Forschler.
3610
3611         * BuildSlaveSupport/ews-build/master.cfg:
3612
3613 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3614
3615         [ews-build] unit-tests fail when passwords.json is missing
3616         https://bugs.webkit.org/show_bug.cgi?id=195557
3617
3618         Reviewed by Lucas Forschler.
3619
3620         * BuildSlaveSupport/ews-build/loadConfig.py:
3621         (loadBuilderConfig):
3622         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3623         (ConfigDotJSONTest.test_configuration):
3624         * BuildSlaveSupport/ews-build/master.cfg:
3625
3626 2019-03-11  Truitt Savell  <tsavell@apple.com>
3627
3628         Unreviewed, rolling out r242702.
3629
3630         Broke High Sierra builders.
3631
3632         Reverted changeset:
3633
3634         "Add utility function to allow easy reverse range-based
3635         iteration of a container"
3636         https://bugs.webkit.org/show_bug.cgi?id=195542
3637         https://trac.webkit.org/changeset/242702
3638
3639 2019-03-11  Sam Weinig  <sam@webkit.org>
3640
3641         Add utility function to allow easy reverse range-based iteration of a container
3642         https://bugs.webkit.org/show_bug.cgi?id=195542
3643
3644         Reviewed by Antti Koivisto.
3645
3646         * TestWebKitAPI/CMakeLists.txt:
3647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3648         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3649         (TestWebKitAPI::TEST):
3650         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3651
3652 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3653
3654         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3655         https://bugs.webkit.org/show_bug.cgi?id=195511
3656         <rdar://problem/44873269>
3657
3658         Reviewed by Darin Adler.
3659
3660         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3661         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3662         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3663         (TEST_F):
3664
3665 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3666
3667         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3668         https://bugs.webkit.org/show_bug.cgi?id=195499
3669
3670         Reviewed by Darin Adler.
3671
3672         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3673         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3674         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3675         (-[WKWebView synchronouslyFocusTextInputContext:]):
3676         (applyStyle):
3677         (applyIframe):
3678         (TEST):
3679         Add some tests for this SPI.
3680
3681 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3682
3683         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3684         https://bugs.webkit.org/show_bug.cgi?id=181151
3685
3686         Reviewed by Don Olmstead.
3687
3688         * TestWebKitAPI/CMakeLists.txt:
3689         * TestWebKitAPI/PlatformWin.cmake:
3690         Enable TestWTF RunLoop tests in all platforms.
3691
3692         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3693         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3694         (TestWebKitAPI::DerivedOneShotTimer::fired):
3695         (TestWebKitAPI::TEST):
3696         Only a few platforms support nested RunLoop.
3697
3698         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3699         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3700
3701 2019-03-10  David Quesada  <david_quesada@apple.com>
3702
3703         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3704         https://bugs.webkit.org/show_bug.cgi?id=152480
3705
3706         Reviewed by Chris Dumez.
3707
3708         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3709         there are no additional references to the process pool besides the one held by
3710         the download, waits for the download to finish (in the sense that the
3711         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3712         measure, also check that the process pool has been deallocated at the end of the
3713         test. The test wouldn't be meaningful if the process pool were still alive.
3714
3715         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3716         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3717         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3718             The download will be canceled because the delegate does not implement the
3719             method to decide the download's destination, so this is where we know the
3720             DownloadProxyMap is done with the DownloadProxy.
3721         (TEST):
3722
3723 2019-03-08  Chris Dumez  <cdumez@apple.com>
3724
3725         Add support for Device Orientation / Motion permission API
3726         https://bugs.webkit.org/show_bug.cgi?id=195329
3727         <rdar://problem/47645367>
3728
3729         Reviewed by Geoffrey Garen.
3730
3731         Add test infrastructure to help test the Device Orientation / Motion permission API.
3732
3733         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3734         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3735         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3736         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3737         * WebKitTestRunner/TestController.cpp:
3738         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3739         (WTR::TestController::createWebViewWithOptions):
3740         (WTR::TestController::resetStateToConsistentValues):
3741         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3742         * WebKitTestRunner/TestController.h:
3743         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3744         * WebKitTestRunner/TestInvocation.cpp:
3745         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3746
3747 2019-03-08  Saam barati  <sbarati@apple.com>
3748
3749         Add a compare-results script to compare benchmark results
3750         https://bugs.webkit.org/show_bug.cgi?id=195486
3751         <rdar://problem/48723397>
3752
3753         Reviewed by Geoffrey Garen.
3754
3755         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3756         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3757         to extend it to learn about our other benchmarks.
3758
3759         * Scripts/compare-results: Added.
3760         (readJSONFile):
3761         (detectJetStream2):
3762         (JetStream2Results):
3763         (detectSpeedometer2):
3764         (Speedometer2Results):
3765         (detectPLT5):
3766         (PLT5Results):
3767         (detectBenchmark):
3768         (biggerIsBetter):
3769         (ttest):
3770         (getOptions):
3771         (main):
3772
3773 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3774
3775         Ensure old tab state is cleared between iterations of run-benchmark
3776         https://bugs.webkit.org/show_bug.cgi?id=195393
3777         <rdar://problem/46885583>
3778
3779         Reviewed by Dewei Zhu.
3780
3781         a) ensure the default to restore state is not set
3782         b) terminate Safari correctly
3783         c) Set the system default to ignore Persistent State in Safari
3784
3785         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3786         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3787         (OSXBrowserDriver.prepare_env): 
3788         (OSXBrowserDriver.restore_env):
3789         (OSXBrowserDriver.close_browsers):
3790         (OSXBrowserDriver._terminate_processes):
3791         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3792         (OSXChromeDriver):
3793         (OSXChromeCanaryDriver):
3794         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3795         (OSXFirefoxDriver):
3796         (OSXFirefoxNightlyDriver):
3797         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3798         (OSXSafariDriver):
3799         (OSXSafariDriver.prepare_env):
3800
3801 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3802
3803         [GTK] Several InputMethodFilter tests are failing
3804         https://bugs.webkit.org/show_bug.cgi?id=195408
3805
3806         Reviewed by Carlos Garcia Campos.
3807
3808         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3809         Regressed in r241751.
3810         Hexadecimal values of keycodes are expressed now in upper letters.
3811         Composited characters should be cast to UTF8 strings.
3812
3813         (TestWebKitAPI::TEST):
3814
3815 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3816
3817         [GTK] Make Tools/gtkdoc python3 compatible
3818         https://bugs.webkit.org/show_bug.cgi?id=195359
3819
3820         Reviewed by Carlos Garcia Campos.
3821
3822         * gtkdoc/generate-gtkdoc:
3823         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3824         work with Python 2 and 3.
3825         (get_gtkdoc_module_paths):
3826         The iteritems() was removed in Python 3, so let's use items() that's
3827         available in Python 2 and 3.
3828         (get_generator_for_config):
3829         * gtkdoc/gtkdoc.py:
3830         (GTKDoc._run_command):
3831         The sys.stdout.write() is expecting str in Python 3 and not bytes
3832         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3833         for passing the bytes there.
3834
3835 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3836
3837         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3838         https://bugs.webkit.org/show_bug.cgi?id=195346
3839         <rdar://problem/48667048>
3840
3841         Unreviewed build fix for clang-cl.
3842
3843         * DumpRenderTree/win/DumpRenderTree.cpp:
3844         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3845
3846 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3847
3848         requestAnimationFrame should execute before the next frame
3849         https://bugs.webkit.org/show_bug.cgi?id=177484
3850
3851         Reviewed by Simon Fraser.
3852
3853         Add trace points for the page RenderingUpdate.
3854
3855         * Tracing/SystemTracePoints.plist:
3856
3857 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3858
3859         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3860         https://bugs.webkit.org/show_bug.cgi?id=195353
3861         <rdar://problem/48626394>
3862
3863         Reviewed by Simon Fraser.
3864
3865         * WebKitTestRunner/ios/TestControllerIOS.mm:
3866         (WTR::TestController::platformResetPreferencesToConsistentValues):
3867
3868 2019-03-07  John Wilander  <wilander@apple.com>
3869
3870         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3871         https://bugs.webkit.org/show_bug.cgi?id=195383
3872         <rdar://problem/48570136>
3873
3874         Reviewed by Brent Fulgham.
3875
3876         This patch adds test infrastructure to purge only script-accessible cookies,
3877         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3878
3879         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3880         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3881         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3882         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3883         * WebKitTestRunner/TestController.cpp:
3884         (WTR::TestController::statisticsDeleteCookiesForHost):
3885         * WebKitTestRunner/TestController.h:
3886         * WebKitTestRunner/TestInvocation.cpp:
3887         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3888
3889 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3890
3891         Unreviewed, rolling out r242354.
3892         https://bugs.webkit.org/show_bug.cgi?id=195402
3893
3894         breaks layout tests in all configurations (Requested by
3895         zdobersek on #webkit).
3896
3897         Reverted changeset:
3898
3899         "[WPE] Enable web process sandbox"
3900         https://bugs.webkit.org/show_bug.cgi?id=195169
3901         https://trac.webkit.org/changeset/242354
3902
3903 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3904
3905         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3906         https://bugs.webkit.org/show_bug.cgi?id=195346
3907
3908         Reviewed by Fujii Hironori.
3909
3910         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3911         (TestWebKitAPI::TEST):
3912         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3913
3914         * DumpRenderTree/win/DumpRenderTree.cpp:
3915         (findFontFallback):
3916         (addFontFallbackIfPresent):
3917         (removeFontFallbackIfPresent):
3918         (main):
3919         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3920         (TestWebKitAPI::Util::moduleDirectory):
3921         (TestWebKitAPI::Util::createInjectedBundlePath):
3922         Use wchar helpers as needed.
3923
3924 2019-03-06  Rob Buis  <rbuis@igalia.com>
3925
3926         Consider supporting the `referrerpolicy` attribute.
3927         https://bugs.webkit.org/show_bug.cgi?id=179053
3928
3929         Reviewed by Darin Adler.
3930
3931         Add a runtime flag for referrerpolicy attribute.
3932
3933         * DumpRenderTree/mac/DumpRenderTree.mm:
3934         (enableExperimentalFeatures):
3935
3936 2019-03-05  Daniel Bates  <dabates@apple.com>
3937
3938         Update expected API test result following r242379
3939         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3940
3941         Update expected x-coordinate of selection rect now that the left padding of
3942         a textarea is sized in ems (so dependent on the font size) just like the left
3943         padding of a text field.
3944
3945         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3946         (TestWebKitAPI::TEST):
3947
3948 2019-03-05  David Quesada  <david_quesada@apple.com>
3949
3950         [WK2] It should be possible to follow links with 'download' attributes
3951         https://bugs.webkit.org/show_bug.cgi?id=195145
3952         rdar://problem/48462642
3953
3954         Reviewed by Alex Christensen.
3955
3956         Add a unit test to verify that activating links with 'download' attributes now
3957         navigates to the linked resource, rather than starts downloading it. Add another
3958         to verify that it is still possible to explicitly download the link via the
3959         'Download' navigation action policy.
3960
3961         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3962         (-[DownloadAttributeTestDelegate init]):
3963         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3964         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3965         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3966         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3967         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3968         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3969         (TEST):
3970         * WebKitTestRunner/TestController.cpp:
3971         (WTR::TestController::decidePolicyForNavigationAction):
3972         * WebKitTestRunner/TestController.h:
3973
3974 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3975
3976         [Curl] Implement Cookie Accept Policy.
3977         https://bugs.webkit.org/show_bug.cgi?id=191645
3978
3979         Reviewed by Fujii Hironori.
3980
3981         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3982         (TestWebKitAPI::Curl::TEST_F):
3983
3984 2019-03-05  Youenn Fablet  <youenn@apple.com>
3985
3986         Rename requestCacheStorageSpace to requestStorageSpace
3987         https://bugs.webkit.org/show_bug.cgi?id=195282
3988
3989         Reviewed by Chris Dumez.
3990
3991         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3992         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3993         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3994
3995 2019-03-05  Brady Eidson  <beidson@apple.com>
3996
3997         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3998         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3999
4000         Reviewed by Tim Horton.
4001
4002         Loading a file: URL into a WKWebView and then loading another file: url from a completely
4003         different directory into that same WKWebView should work.
4004
4005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4006         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
4007
4008 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
4009
4010         Add WeakHashSet
4011         https://bugs.webkit.org/show_bug.cgi?id=195152
4012
4013         Reviewed by Antti Koivisto.
4014
4015         Added tests for WeakHashSet.
4016
4017         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4018         (TestWebKitAPI::Base::Base): Moved.
4019         (TestWebKitAPI::Derived::foo): Moved.
4020         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
4021         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
4022         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
4023         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
4024
4025 2019-03-04  Chris Dumez  <cdumez@apple.com>
4026
4027         Do not share WebProcesses between private and regular sessions
4028         https://bugs.webkit.org/show_bug.cgi?id=195189
4029         <rdar://problem/48421064>
4030
4031         Reviewed by Alex Christensen.
4032
4033         Add API test coverage.
4034
4035         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4036         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4037
4038 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
4039
4040         [WPE] Enable web process sandbox
4041         https://bugs.webkit.org/show_bug.cgi?id=195169
4042
4043         Reviewed by Daniel Bates.
4044
4045         * wpe/install-dependencies:
4046         * wpe/jhbuild.modules:
4047
4048 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4049
4050         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
4051         https://bugs.webkit.org/show_bug.cgi?id=195206
4052
4053         Reviewed by Žan Doberšek.
4054
4055         Add a new test case.
4056
4057         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4058         (testJSCClass):
4059
4060 2019-03-04  Charlie Turner  <cturner@igalia.com>
4061
4062         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
4063         https://bugs.webkit.org/show_bug.cgi?id=194898
4064
4065         Reviewed by Žan Doberšek.
4066
4067         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
4068         a GCC extension that permits arithmetic on void* pointer. Inline
4069         the macro until this issue is fixed upstream.
4070
4071 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4072
4073         Rid the world of WK_API_ENABLED
4074         https://bugs.webkit.org/show_bug.cgi?id=195263
4075
4076         Reviewed by Dan Bernstein.
4077
4078         List of changed files elided because it's useless.
4079
4080 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4081
4082         Unreviewed follow-up to r242292.
4083
4084         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4085
4086         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4087         (TestWebKitAPI::testStrip): Renamed from strip.
4088         (TestWebKitAPI::TEST):
4089
4090 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4091
4092         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4093
4094         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4095         and bug #194272 for details.
4096
4097         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4098
4099 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4100
4101         Remove some more unused 32-bit code
4102         https://bugs.webkit.org/show_bug.cgi?id=195255
4103
4104         Reviewed by Darin Adler.
4105
4106         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4107         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4108         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4109         (NPP_New):
4110         (NPP_HandleEvent):
4111         (handleEventCarbon): Deleted.
4112
4113 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4114
4115         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4116
4117         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4118         (TestWebKitAPI::TEST):
4119
4120 2019-03-01  Darin Adler  <darin@apple.com>
4121
4122         Finish removing String::format
4123         https://bugs.webkit.org/show_bug.cgi?id=194893
4124
4125         Reviewed by Daniel Bates.
4126 '
4127         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4128
4129 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4130
4131         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4132         https://bugs.webkit.org/show_bug.cgi?id=195229
4133         <rdar://problem/48520362>
4134
4135         Reviewed by Chris Dumez.
4136
4137         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4138         (TEST):
4139
4140 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4141
4142         Add a system trace scope for event region building
4143         https://bugs.webkit.org/show_bug.cgi?id=195226
4144
4145         Reviewed by Jon Lee.
4146
4147         This trace scope measures the time spend converting element rects into Region objects,
4148         which can be large on some pages.
4149
4150         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4151
4152         * Tracing/SystemTracePoints.plist:
4153
4154 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4155
4156         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4157         https://bugs.webkit.org/show_bug.cgi?id=194612
4158
4159         Reviewed by Alex Christensen.
4160
4161         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4162         Just test the new string-processing function and don't touch the actual environment.
4163         (Test cases are all as before, but based on operator== instead of strcmp.)
4164
4165 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4166
4167         [ews-app] Update primary keys for handling multiple Buildbot instances
4168         https://bugs.webkit.org/show_bug.cgi?id=195120
4169
4170         Reviewed by Stephanie Lewis.
4171
4172         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4173         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4174         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4175
4176         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4177         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4178         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4179         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4180         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4181         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4182
4183 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4184
4185         [WinCairo] Enable service worker
4186         https://bugs.webkit.org/show_bug.cgi?id=188318
4187
4188         Reviewed by Youenn Fablet.
4189
4190         * DumpRenderTree/DumpRenderTreePrefix.h:
4191         * TestWebKitAPI/PlatformWin.cmake:
4192         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4193         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4194         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4195
4196 2019-03-01  Justin Fan  <justin_fan@apple.com>
4197
4198         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4199         https://bugs.webkit.org/show_bug.cgi?id=195191
4200
4201         Rubber-stamped by Dean Jackson.
4202
4203         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4204
4205         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4206
4207 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4208
4209         Unreviewed, fix lldb webkitpy tests
4210         https://bugs.webkit.org/show_bug.cgi?id=194375
4211
4212         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4213
4214         * lldb/lldb_webkit.py:
4215         (WTFStringImplProvider.is_8bit):
4216
4217 2019-02-28  David Quesada  <david_quesada@apple.com>
4218
4219         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4220         https://bugs.webkit.org/show_bug.cgi?id=195121
4221         rdar://problem/48450302
4222
4223         Reviewed by Alex Christensen.
4224
4225         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4226         configurations where the 'download' attribute is absent, blank, or populated
4227         with a filename, and where the anchor element is same-origin or cross-origin
4228         (meaning the 'download' attribute shouldn't be honored).
4229
4230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4231         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4232         (-[NavigationActionTestDelegate init]):
4233         (-[NavigationActionTestDelegate navigationAction]):
4234         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4235         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4236         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4237         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4238         (TEST):
4239
4240 2019-02-28  Antoine Quint  <graouts@apple.com>
4241
4242         Enable the Pointer Events runtime flag by default
4243         https://bugs.webkit.org/show_bug.cgi?id=195156
4244
4245         Reviewed by Dean Jackson.
4246
4247         * DumpRenderTree/mac/DumpRenderTree.mm:
4248         (enableExperimentalFeatures):
4249
4250 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4251
4252         Several PasteImage API tests are flaky
4253         https://bugs.webkit.org/show_bug.cgi?id=195160
4254
4255         Reviewed by Tim Horton.
4256
4257         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4258         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4259         listening for a "load" event after image load is already complete.
4260
4261         To address this, make these tests first register a "load" event handler, then run script to insert an image
4262         element into the document, and finally wait until the load event is observed before checking image size.
4263
4264         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4265
4266 2019-02-28  Chris Dumez  <cdumez@apple.com>
4267
4268         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4269         https://bugs.webkit.org/show_bug.cgi?id=195107
4270
4271         Reviewed by Alex Christensen.
4272
4273         Give some time for the zoom level to get restored.
4274
4275         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4276
4277 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4278
4279         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4280         https://bugs.webkit.org/show_bug.cgi?id=194958
4281
4282         Reviewed by Geoffrey Garen.
4283
4284         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4285         (TEST):
4286
4287 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4288
4289         [ews-app] Update method to save build to handle builder_display_name
4290         https://bugs.webkit.org/show_bug.cgi?id=195047
4291
4292         Reviewed by Dewei Zhu.
4293
4294         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4295         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4296
4297 2019-02-28  Justin Fan  <justin_fan@apple.com>
4298
4299         [Web GPU] Enable Web GPU only on 64-bit
4300         https://bugs.webkit.org/show_bug.cgi?id=195139
4301
4302         Because Metal is only supported on 64 bit apps.
4303
4304         Unreviewed build fix.
4305
4306         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4307
4308 2019-02-27  Youenn Fablet  <youenn@apple.com>
4309
4310         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4311         https://bugs.webkit.org/show_bug.cgi?id=194959
4312
4313         Reviewed by Chris Dumez.
4314
4315         Spin loop until getting the condition to remove flakiness.
4316
4317         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4318
4319 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4320
4321         [ews-build] Buildbot should include builder_display_name in the build events
4322         https://bugs.webkit.org/show_bug.cgi?id=195045
4323
4324         Reviewed by Dewei Zhu.
4325
4326         * BuildSlaveSupport/ews-build/events.py:
4327         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4328         buildername to builder_name to be consistent in naming style.
4329         (Events.buildFinished): Ditto.
4330
4331 2019-02-27  Chris Dumez  <cdumez@apple.com>
4332
4333         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4334         https://bugs.webkit.org/show_bug.cgi?id=194480
4335
4336         Reviewed by Brady Eidson.
4337
4338         Update existing API test to make it more likely to reproduce the issue.
4339
4340         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4341
4342 2019-02-27  Brady Eidson  <beidson@apple.com>
4343
4344         Universal links from Google search results pages don't open the app.
4345         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4346
4347         Reviewed by Geoffrey Garen.
4348
4349         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4350         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4351         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4352         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4353
4354 2019-02-27  Chris Dumez  <cdumez@apple.com>
4355
4356         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4357         https://bugs.webkit.org/show_bug.cgi?id=195102
4358
4359         Reviewed by Geoffrey Garen.
4360
4361         If the number of processes is not yet what we expect, wait a bit and check again to give
4362         processes some time to exit.
4363
4364         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: