Unreviewed build-fix after r212297.
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
2
3         Unreviewed build-fix after r212297.
4
5         * Scripts/webkitpy/port/simulator_process.py:
6         (SimulatorProcess.stop): Should return value of the ServerProcess's stop.
7
8 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
9
10         [CMake] build-webkit should allow building with the default cmake configuration
11         https://bugs.webkit.org/show_bug.cgi?id=168323
12
13         Reviewed by Michael Catanzaro.
14
15         Add a --default-cmake-features switch that makes the script pass
16         no value for any of the features defined by build-webkit, that
17         way the default values from the port cmake config will be used.
18
19         * Scripts/build-webkit:
20         (cMakeArgsFromFeatures):
21
22 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
23
24         Unreviewed build-fix after r212297.
25
26         * Scripts/webkitpy/port/simulator_process.py:
27         (SimulatorProcess.stop): Handle case where there is no process to kill.
28
29 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
30
31         [CMake] build-webkit should print the cmake command executed
32         https://bugs.webkit.org/show_bug.cgi?id=168318
33
34         Reviewed by Michael Catanzaro.
35
36         Run the cmake commands to configure or start the build through
37         a wrapper that prints the command before executing it.
38
39         * Scripts/webkitdirs.pm:
40         (systemVerbose):
41         (generateBuildSystemFromCMakeProject):
42         (buildCMakeGeneratedProject):
43         (cleanCMakeGeneratedProject):
44
45 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
46
47         run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
48         https://bugs.webkit.org/show_bug.cgi?id=168150
49
50         Reviewed by Alexey Proskuryakov.
51
52         * Scripts/webkitpy/port/simulator_process.py:
53         (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
54         (SimulatorProcess._kill): Move closing of app into stop().
55         * Scripts/webkitpy/xcode/simulator.py:
56         (Device.launch_app):
57         (Device.terminate_app): Deleted.
58
59 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
60
61         REGRESSION(r212192): [GTK] Broke downloads API tests
62         https://bugs.webkit.org/show_bug.cgi?id=168193
63
64         Unreviewed. Update test expectations after r212192.
65
66         The suggested filename now includes a file extensions if the MIME type is known.
67
68         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
69         (testDownloadRemoteFile):
70         (testDownloadMIMEType):
71
72 2017-02-14  Commit Queue  <commit-queue@webkit.org>
73
74         Unreviewed, rolling out r212237.
75         https://bugs.webkit.org/show_bug.cgi?id=168298
76
77         This was a wrong fix (Requested by rniwa on #webkit).
78
79         Reverted changeset:
80
81         "Nwtr unexpectedly passes mismatch ref test if the hashes
82         doesn't match but no diff"
83         https://bugs.webkit.org/show_bug.cgi?id=168221
84         http://trac.webkit.org/changeset/212237
85
86 2017-02-13  Alex Christensen  <achristensen@webkit.org>
87
88         URLs with an invalid IPv4 address should be invalid
89         https://bugs.webkit.org/show_bug.cgi?id=168260
90
91         Reviewed by Tim Horton.
92
93         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
94         (TestWebKitAPI::TEST_F):
95         Update tests to reflect new correct behavior.
96
97 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
98
99         [WinCairo] Add Build Slave
100         https://bugs.webkit.org/show_bug.cgi?id=168263
101
102         Reviewed by Lucas Forschler.
103
104         * BuildSlaveSupport/build.webkit.org-config/config.json:
105
106 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
107
108         Fix the build after r212254
109
110         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
111         (-[DataInteractionSimulator _currentLocation]):
112
113 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
114
115         [WK2] Add test infrastructure and unit tests for data interaction
116         https://bugs.webkit.org/show_bug.cgi?id=168159
117         <rdar://problem/30477634>
118
119         Reviewed by Tim Horton.
120
121         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
122         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
123         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
124         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
125         gesture has already been recognized) at regular intervals over the course of the test.
126
127         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
128         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
129         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
130         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
131
132         New test pages for data interaction.
133
134         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
135         (TestWebKitAPI::runTestsExpectingToObserveEvents):
136         (TestWebKitAPI::TEST):
137         * TestWebKitAPI/cocoa/TestWKWebView.mm:
138         (-[TestWKWebView stringByEvaluatingJavaScript:]):
139         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
140         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
141         (-[MockLongPressGestureRecognizer initWithWindow:]):
142         (-[MockLongPressGestureRecognizer locationInView:]):
143         (-[MockLongPressGestureRecognizer state]):
144         (-[MockLongPressGestureRecognizer numberOfTouches]):
145         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
146         (-[DataInteractionSimulator dealloc]):
147         (-[DataInteractionSimulator run]):
148
149         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
150         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
151         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
152
153         (-[DataInteractionSimulator _advanceProgress]):
154
155         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
156         completed, and calls _finishDataInteraction when progress is at 1.
157
158         (-[DataInteractionSimulator _finishDataInteraction]):
159         (-[DataInteractionSimulator _currentLocation]):
160         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
161         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
162         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
163         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
164         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
165
166 2017-02-13  Alex Christensen  <achristensen@webkit.org>
167
168         Percent should be allowed in non-special URL hosts
169         https://bugs.webkit.org/show_bug.cgi?id=168255
170
171         Reviewed by Tim Horton.
172
173         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
174         (TestWebKitAPI::TEST_F):
175
176 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
177
178         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
179         https://bugs.webkit.org/show_bug.cgi?id=168221
180
181         Reviewed by Ryosuke Niwa.
182
183         There is a logic error in comparing mismatch ref test images. In
184         mismatch ref tests, it should be failed if two images has no diff.
185         But, if the hashes are different, nwtr unexpectedly pass the
186         mismatch ref test.
187
188         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
189         (SingleTestRunner._compare_output_with_reference): Fail the
190         mismatch ref test if hashes of two images are equal. Invoke
191         ImageDiff if the hashes don't match.
192
193 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
194
195         Update custom line breaking iterators to the latest version of Unicode
196         https://bugs.webkit.org/show_bug.cgi?id=168182
197
198         Reviewed by Zalan Bujtas.
199
200         Treat the system's ICU as the source of truth to compare breaking positions against.
201
202         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
203         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
204         (generateJavaScriptForTest):
205         (breakingLocationsFromICU):
206         (testAFewStrings):
207         (TEST):
208         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
209         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
210
211 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
212
213         [GTK] Several failing WebViewEditor API tests
214         https://bugs.webkit.org/show_bug.cgi?id=161608
215
216         Reviewed by Carlos Garcia Campos.
217
218         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
219         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
220         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
221         except the first one, which is still broken due to unrelated bug #151654.
222
223         * Scripts/run-gtk-tests:
224         (TestRunner):
225         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
226
227 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
228
229         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
230
231         * Scripts/run-gtk-tests:
232         (TestRunner):
233
234 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
235
236         Unreviewed, skip flaky form-controls-associated-signal test
237
238         * Scripts/run-gtk-tests:
239         (TestRunner):
240
241 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
242
243         [GTK] Handle caps lock indicator in event modifiers
244         https://bugs.webkit.org/show_bug.cgi?id=168186
245
246         Reviewed by Michael Catanzaro.
247
248         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
249         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
250
251 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
252
253         MiniBrowser WK1 fails to update URL for within-page navigations
254         https://bugs.webkit.org/show_bug.cgi?id=168173
255
256         Reviewed by Tim Horton.
257         
258         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
259         anchors updates the URL field.
260
261         * MiniBrowser/mac/WK1BrowserWindowController.m:
262         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
263
264 2017-02-10  John Wilander  <wilander@apple.com>
265
266         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
267         https://bugs.webkit.org/show_bug.cgi?id=167474
268         <rdar://problem/24681808>
269         <rdar://problem/24703286>
270         <rdar://problem/30290270>
271
272         This patch adds test infrastructure to allow testing 
273         of the various rules in place for data records removal.
274
275         Reviewed by Andy Estes.
276
277         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
278         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
279         (WTR::InjectedBundle::didReceiveMessageToPage):
280             Callback mechanism to tell pages that a website data store
281             scan has happened.
282         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
283         (WTR::TestRunner::setStatisticsPrevalentResource):
284         (WTR::TestRunner::isStatisticsPrevalentResource):
285         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
286         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
287         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
288         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
289         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
290         (WTR::TestRunner::statisticsFireDataModificationHandler):
291         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
292         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
293         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
294         (WTR::TestRunner::statisticsResetToConsistentState):
295         * WebKitTestRunner/InjectedBundle/TestRunner.h:
296         * WebKitTestRunner/TestController.cpp:
297         (WTR::TestController::setStatisticsPrevalentResource):
298         (WTR::TestController::isStatisticsPrevalentResource):
299         (WTR::TestController::setStatisticsHasHadUserInteraction):
300         (WTR::TestController::isStatisticsHasHadUserInteraction):
301         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
302         (WTR::TestController::statisticsFireDataModificationHandler):
303         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
304         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
305         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
306         (WTR::TestController::statisticsResetToConsistentState):
307         * WebKitTestRunner/TestController.h:
308             These are all configuration and test functions.
309         * WebKitTestRunner/TestInvocation.cpp:
310         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
311
312 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
313
314         REGRESSION(r182916) run-perf-tests never timeouts
315         https://bugs.webkit.org/show_bug.cgi?id=167626
316
317         Reviewed by Ryosuke Niwa.
318
319         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
320         was beeing ignored because the driver was created with no_timeout=True
321         unconditionally.
322         This adds a new parameter --no-timeout (disabled by default), that
323         allows to use the driver with the expected timeout values.
324         It also passes --no-timeout to DRT/WTR to ensure that timeouts
325         are always controlled by the Python Driver.
326
327         * Scripts/webkitpy/performance_tests/perftest.py:
328         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
329         (PerfTest.run): Disabling timeout should be done when the Driver is created.
330         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
331         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
332         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
333         (_run_tests_set): Pass the no-timeout parameter.
334         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
335         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
336         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
337         (MainTest.test_parse_args): Test that the argument no-timeout.
338
339 2017-02-10  Daniel Bates  <dabates@apple.com>
340
341         Detach frame from document when entering page cache
342         https://bugs.webkit.org/show_bug.cgi?id=166774
343         <rdar://problem/29904368>
344
345         Reviewed by Chris Dumez.
346
347         * DumpRenderTree/mac/DumpRenderTree.mm:
348         (resetWebPreferencesToConsistentValues):
349         * DumpRenderTree/win/DumpRenderTree.cpp:
350         (resetWebPreferencesToConsistentValues):
351         * WebKitTestRunner/TestController.cpp:
352         (WTR::TestController::resetPreferencesToConsistentValues):
353
354 2017-02-10  Tim Horton  <timothy_horton@apple.com>
355
356         Infinite UI process hang under ensurePositionInformationIsUpToDate
357         https://bugs.webkit.org/show_bug.cgi?id=168154
358         <rdar://problem/30428673>
359
360         Reviewed by Simon Fraser.
361
362         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
363         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
364         (recursiveFindHighlightLongPressRecognizer):
365         (TEST):
366         Add a somewhat nasty test that does an async interaction information update, but
367         kills the Web process before it arrives, and then does a sync interaction
368         information update, which will wait for the oustanding async interaction
369         information update if we still think it's coming. Before the patch, this
370         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
371
372 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
373
374         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
375         https://bugs.webkit.org/show_bug.cgi?id=168127
376         rdar://problem/30467120
377
378         Reviewed by Tim Horton.
379
380         Reparent the web view before we try to fetch it via:
381             [[[window contentView] subviews] objectAtIndex:0];
382         which would throw an exception if the test unparented it.
383
384         * DumpRenderTree/mac/DumpRenderTree.mm:
385         (resetWebViewToConsistentStateBeforeTesting):
386         (runTest):
387
388 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
389
390         [Resource Timing] Enable Resource Timing by default in Tests
391         https://bugs.webkit.org/show_bug.cgi?id=168145
392
393         Reviewed by Ryosuke Niwa.
394
395         * DumpRenderTree/mac/DumpRenderTree.mm:
396         (resetWebPreferencesToConsistentValues):
397         * DumpRenderTree/win/DumpRenderTree.cpp:
398         (resetWebPreferencesToConsistentValues):
399         * WebKitTestRunner/TestController.cpp:
400         (WTR::TestController::resetPreferencesToConsistentValues):
401
402 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
403
404         Removing LayoutTestRelay
405         https://bugs.webkit.org/show_bug.cgi?id=165927
406
407         Reviewed by Daniel Bates.
408         Part 2
409
410         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
411         simulators through simctl (iOS 10 and later), use this functionality instead.
412
413         * BuildSlaveSupport/built-product-archive:
414         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
415         Added a FIXME that we will need to implement similar archiving machinery once we build
416         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
417         * BuildSlaveSupport/kill-old-processes:
418         (main): Remove LayoutTestRelay from list of processes.
419         * LayoutTestRelay: Removed LayoutTestRelay.
420         * Makefile:
421         * Scripts/build-layouttestrelay: Removed.
422         * Scripts/build-webkit: Removed LayoutTestRelay references.
423
424 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
425
426         [WebCrypto] Add WebCryptoAPI to watchlist
427         https://bugs.webkit.org/show_bug.cgi?id=168138
428
429         Reviewed by Youenn Fablet.
430
431         * Scripts/webkitpy/common/config/watchlist:
432
433 2017-02-10  Brady Eidson  <beidson@apple.com>
434
435         Replace all WebKit Library Version checks in WK2 with SDK version checks.
436         https://bugs.webkit.org/show_bug.cgi?id=168124
437
438         Reviewed by Geoffrey Garen.
439
440         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
441         
442         * MiniBrowser/mac/main.m:
443         (main):
444         * MobileMiniBrowser/MobileMiniBrowser/main.m:
445         (main):
446         * TestWebKitAPI/ios/mainIOS.mm:
447         (main):
448         * TestWebKitAPI/mac/mainMac.mm:
449         (main):
450         * WebKitTestRunner/ios/mainIOS.mm:
451         (main):
452         * WebKitTestRunner/mac/main.mm:
453         (setDefaultsToConsistentValuesForTesting):
454
455 2017-02-10  Alex Christensen  <achristensen@webkit.org>
456
457         Fix El Capitan build.
458
459         * Scripts/build-webkit:
460         Don't build libwebrtc anywhere for now.
461
462 2017-02-10  Andy Estes  <aestes@apple.com>
463
464         Move two MiniBrowserBundle settings out of the .pbxproj
465         https://bugs.webkit.org/show_bug.cgi?id=168106
466
467         Reviewed by Tim Horton.
468
469         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
470         the project file. This removes the project file override.
471
472         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
473
474         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
475         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
476
477 2017-02-10  Alex Christensen  <achristensen@webkit.org>
478
479         Fix 32-and-64-bit build on El Capitan.
480
481         * Scripts/build-webkit:
482         Somebody's building with something like this:
483         build-webkit ARCHS="i386 x86_64"
484         We want this to also not build libwebrtc for now.
485
486 2017-02-10  Alex Christensen  <achristensen@webkit.org>
487
488         Fix 32-bit build on El Capitan.
489
490         * Scripts/build-webkit:
491         The bot uses ARCHS=i386 instead of --32-bit.
492         This is a hack, but it should fix the bot until I can do a better fix in the morning.
493
494 2017-02-10  Alex Christensen  <achristensen@webkit.org>
495
496         Fix 32-bit build on El Capitan.
497
498         * Scripts/build-webkit:
499         Don't build i386 libwebrtc.
500
501 2017-02-09  Alex Christensen  <achristensen@webkit.org>
502
503         Unreviewed, rolling out r212040.
504
505         Broke build.  I'm not surprised
506
507         Reverted changeset:
508
509         "[WebRTC][Mac] Activate libwebrtc"
510         https://bugs.webkit.org/show_bug.cgi?id=167293
511         http://trac.webkit.org/changeset/212040
512
513 2017-02-09  Alex Christensen  <achristensen@webkit.org>
514
515         Build libwebrtc on bots without using it yet
516         https://bugs.webkit.org/show_bug.cgi?id=168062
517
518         Reviewed by Brent Fulgham.
519
520         * Scripts/build-webkit:
521
522 2017-02-09  Alex Christensen  <achristensen@webkit.org>
523
524         Don't build libwebrtc.
525
526         * Scripts/build-webkit:
527         Not ready yet.  It broke El Capitan and iOS.
528
529 2017-02-09  Alex Christensen  <achristensen@webkit.org>
530
531         Build libwebrtc on bots without using it yet
532         https://bugs.webkit.org/show_bug.cgi?id=168062
533
534         Reviewed by Brent Fulgham.
535
536         * Scripts/build-webkit:
537
538 2017-02-09  Alex Christensen  <achristensen@webkit.org>
539
540         Rename isAppleMacWebKit to isAppleCocoaWebKit
541         https://bugs.webkit.org/show_bug.cgi?id=168075
542
543         Reviewed by Geoffrey Garen.
544
545         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
546
547         * Scripts/build-api-tests:
548         * Scripts/build-dumprendertree:
549         * Scripts/build-jsc:
550         (buildMyProject):
551         * Scripts/build-layouttestrelay:
552         * Scripts/build-webkit:
553         * Scripts/build-webkittestrunner:
554         * Scripts/run-api-tests:
555         (isSupportedPlatform):
556         (runTest):
557         (listAllTests):
558         (prepareEnvironmentForRunningTestTool):
559         * Scripts/run-content-extension-tester:
560         * Scripts/run-javascriptcore-tests:
561         * Scripts/run-minibrowser:
562         * Scripts/show-pretty-diff:
563         * Scripts/webkitdirs.pm:
564         (determineBaseProductDir):
565         (determineArchitecture):
566         (determinePassedArchitecture):
567         (safariPath):
568         (builtDylibPathForName):
569         (checkFrameworks):
570         (isAppleWebKit):
571         (isAppleCocoaWebKit):
572         (determineNmPath):
573         (launcherName):
574         (wrapperPrefixIfNeeded):
575         (isCMakeBuild):
576         (mobileSafariBundle):
577         (debugSafari):
578         (runSafari):
579         (runMiniBrowser):
580         (debugMiniBrowser):
581         (runWebKitTestRunner):
582         (debugWebKitTestRunner):
583         (isAppleMacWebKit): Deleted.
584         * Scripts/webkitperl/FeatureList.pm:
585
586 2017-02-09  Alex Christensen  <achristensen@webkit.org>
587
588         Revert r211991
589         https://bugs.webkit.org/show_bug.cgi?id=168062
590
591         * Scripts/build-webkit:
592         Not quite ready yet.
593
594 2017-02-09  Alex Christensen  <achristensen@webkit.org>
595
596         Build libwebrtc on bots without using it yet
597         https://bugs.webkit.org/show_bug.cgi?id=168062
598
599         Reviewed by Brent Fulgham.
600
601         * Scripts/build-webkit:
602         Build libwebrtc on Mac when we build ANGLE.
603
604 2017-02-09  Youenn Fablet  <youenn@apple.com>
605
606         Improve W3C importer command line options
607         https://bugs.webkit.org/show_bug.cgi?id=167448
608
609         Reviewed by Ryosuke Niwa.
610
611         Making the list of test paths to import the main arguments of the script.
612         Allow passing the source directory to import as a -s option.
613         Adding a warning when given test paths are skipped by default in ImportExpectations.
614
615         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
616         Link conversion rules do not change when imported tests are downloaded by the script.
617
618         * Scripts/webkitpy/w3c/test_importer.py:
619         (main):
620         (parse_args):
621         (TestImporter.__init__):
622         (TestImporter.do_import):
623         (TestImporter):
624         (TestImporter.check_imported_expectations):
625
626 2017-02-08  Chris Dumez  <cdumez@apple.com>
627
628         Update web-platform-tests resources
629         https://bugs.webkit.org/show_bug.cgi?id=168026
630
631         Reviewed by Youenn Fablet.
632
633         Stop copying testharness.js from resources/ to web-platform-tests/resources.
634
635         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
636         (WebPlatformTestServer._copy_webkit_test_files):
637
638 2017-02-08  Andy Estes  <aestes@apple.com>
639
640         Custom protocols should not continue loading after a network process crash
641         https://bugs.webkit.org/show_bug.cgi?id=168028
642         <rdar://problem/27607520>
643
644         Reviewed by Brady Eidson.
645
646         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
647         (processGroup):
648         (-[CloseWhileStartingProtocol startLoading]):
649         (-[CloseWhileStartingProtocol stopLoading]):
650         (TestWebKitAPI::runTest):
651         (TestWebKitAPI::TEST):
652
653 2017-02-08  Dan Bernstein  <mitz@apple.com>
654
655         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
656         https://bugs.webkit.org/show_bug.cgi?id=168031
657
658         Reviewed by Tim Horton.
659
660         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
661         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
662         (TEST):
663         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
664         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
665
666 2017-02-08  Chris Dumez  <cdumez@apple.com>
667
668         Use smaller tiles in windows that are not active to facilitate App Napping
669         https://bugs.webkit.org/show_bug.cgi?id=167997
670         <rdar://problem/30358835>
671
672         Reviewed by Simon Fraser.
673
674         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
675         (WTR::PlatformWebView::setWindowIsKey):
676         Actually update windowIsKey state of NSWindow so the WebView
677         properly updates its activity state.
678
679 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
680
681         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
682         https://bugs.webkit.org/show_bug.cgi?id=167942
683         <rdar://problem/30315079>
684
685         Reviewed by Tim Horton.
686
687         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
688         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
689         contenteditable in these cases.
690
691         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
692         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
693         performDragOperation:) directly.
694
695         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
696         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
697         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
698         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
699         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
700         (-[DragSource draggingSourceOperationMaskForLocal:]):
701         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
702         (-[DragInfo lastMousePosition]):
703         (-[DragInfo setLastMousePosition:]):
704         (-[DragInfo draggingDestinationWindow]):
705         (-[DragInfo draggingSourceOperationMask]):
706         (-[DragInfo draggingLocation]):
707         (-[DragInfo draggedImageLocation]):
708         (-[DragInfo draggedImage]):
709         (-[DragInfo draggingPasteboard]):
710         (-[DragInfo draggingSource]):
711         (-[DragInfo draggingSequenceNumber]):
712         (-[DragInfo slideDraggedImageTo:]):
713         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
714         (-[DragInfo draggingFormation]):
715         (-[DragInfo setDraggingFormation:]):
716         (-[DragInfo animatesToDestination]):
717         (-[DragInfo setAnimatesToDestination:]):
718         (-[DragInfo numberOfValidItemsForDrop]):
719         (-[DragInfo setNumberOfValidItemsForDrop:]):
720         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
721         (-[DragInfo springLoadingHighlight]):
722         (-[DragInfo resetSpringLoading]):
723         (TestWebKitAPI::getTestImage):
724         (TestWebKitAPI::webViewAfterPerformingDragOperation):
725         (TestWebKitAPI::TEST):
726         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
727
728 2017-02-08  Jer Noble  <jer.noble@apple.com>
729
730         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
731         https://bugs.webkit.org/show_bug.cgi?id=168007
732
733         Reviewed by Alex Christensen.
734
735         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
736         (didFinishLoadForFrame):
737         (TestWebKitAPI::TEST):
738
739 2017-02-08  Commit Queue  <commit-queue@webkit.org>
740
741         Unreviewed, rolling out r211873.
742         https://bugs.webkit.org/show_bug.cgi?id=168001
743
744         It's in jhbuild for consistent layout tests (Requested by
745         mcatanzaro on #webkit).
746
747         Reverted changeset:
748
749         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
750         https://bugs.webkit.org/show_bug.cgi?id=167993
751         http://trac.webkit.org/changeset/211873
752
753 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
754
755         [GTK] Add icu packages to Tools/gtk/install-dependencies
756         https://bugs.webkit.org/show_bug.cgi?id=167993
757
758         Reviewed by Michael Catanzaro.
759
760         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
761         depending in the GNU/Linux distribution)
762
763 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
764
765         Update flakiness dashboard configuration.
766         https://bugs.webkit.org/show_bug.cgi?id=167957
767
768         Reviewed by Alexey Proskuryakov.
769
770         * TestResultServer/static-dashboards/builders.jsonp:
771
772 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
773
774         Replace a bot that has an incorrect configuration.
775         https://bugs.webkit.org/show_bug.cgi?id=167747
776
777         Rubber-stamped by Alexey Proskuryakov.
778
779         * BuildSlaveSupport/build.webkit.org-config/config.json:
780
781 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
782
783         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
784         https://bugs.webkit.org/show_bug.cgi?id=167927
785
786         Reviewed by Brent Fulgham.
787
788         Enable ComplexTextController API tests on the Win and GTK ports.
789
790         * TestWebKitAPI/PlatformGTK.cmake:
791         * TestWebKitAPI/PlatformWin.cmake:
792
793 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
794
795         File index appended to previous file in svn-create-patch with SVN 1.9
796         https://bugs.webkit.org/show_bug.cgi?id=167903
797         <rdar://problem/30387395>
798
799         Reviewed by Daniel Bates.
800
801         * Scripts/VCSUtils.pm:
802         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
803         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
804         trailing newline character from the expected result before comparing it to the actual result.
805
806 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
807
808         [webkitdirs] remove unused host_processor variable in determineArchitecture()
809         https://bugs.webkit.org/show_bug.cgi?id=167936
810
811         Reviewed by Michael Catanzaro.
812
813         * Scripts/webkitdirs.pm:
814         (determineArchitecture):
815         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
816         since r195083.
817
818 2017-02-07  Youenn Fablet  <youenn@apple.com>
819
820         Use a JSON file to define which WPT files/folders to import
821         https://bugs.webkit.org/show_bug.cgi?id=167923
822
823         Reviewed by Alex Christensen.
824
825         * Scripts/webkitpy/w3c/test_downloader.py:
826         (TestDownloader.__init__):
827         (TestDownloader._init_paths_from_expectations):
828         * Scripts/webkitpy/w3c/test_importer.py:
829         (parse_args):
830         * Scripts/webkitpy/w3c/test_importer_unittest.py:
831
832 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
833
834         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
835         https://bugs.webkit.org/show_bug.cgi?id=167916
836
837         Reviewed by Carlos Garcia Campos.
838
839         URL of mesa-11.0.6.tar.xz has been moved.
840
841         * gtk/jhbuild.modules: Fix the module path.
842
843 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
844
845         Static Analyzer: Address some leaks in MiniBrowser
846         https://bugs.webkit.org/show_bug.cgi?id=167897
847
848         Reviewed by Alexey Proskuryakov.
849
850         * MiniBrowser/mac/BrowserWindowController.m:
851         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
852         * MiniBrowser/mac/ExtensionManagerWindowController.m:
853         (-[ExtensionManagerWindowController add:]):
854         (-[ExtensionManagerWindowController remove:]):
855         * MiniBrowser/mac/SettingsController.m:
856         (-[SettingsController _populateMenu]):
857         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
858         Address obvious leaks caught by the static analyzer.
859
860 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
861
862         Migrate ComplexTextController to use platform-independent types
863         https://bugs.webkit.org/show_bug.cgi?id=167833
864
865         Reviewed by Brent Fulgham.
866
867         Migrate tests away from platform-dependent types.
868
869         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
870         (TestWebKitAPI::TEST_F):
871
872 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
873
874         Correct File Path Handling in SecurityOrigin and FileSystem
875         https://bugs.webkit.org/show_bug.cgi?id=167894
876         <rdar://problem/30380080>
877
878         Reviewed by Alexey Proskuryakov.
879
880         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
881         and perform same-volume checks using filesystem-compatible paths.        
882         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
883         filesystem paths, and perform validation of same-volume checks.
884         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
885         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
886         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
887         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
888
889 2017-02-06  Jer Noble  <jer.noble@apple.com>
890
891         Playback stalls when a SourceBuffer append causes frame eviction
892         https://bugs.webkit.org/show_bug.cgi?id=167834
893
894         Reviewed by Eric Carlson.
895
896         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
897         for the WTF::MediaTime class.
898
899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
900         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
901         (TestWebKitAPI::TEST):
902         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
903         (WTF::operator<<):
904         (TestWebKitAPI::TestSample::create):
905         (TestWebKitAPI::TestSample::TestSample):
906         (TestWebKitAPI::TEST_F):
907
908 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
909
910         Change capitalization in platform name after r211735.
911
912         Unreviewed dashboard fix.
913
914         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
915         (WebKitBuildbot):
916
917 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
918
919         Move the Leaks bot to Sierra
920         https://bugs.webkit.org/show_bug.cgi?id=167886
921
922         Reviewed by Daniel Bates.
923
924         * BuildSlaveSupport/build.webkit.org-config/config.json:
925         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
926         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
927         (LeaksViewer._displayURLPrompt):
928         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
929         (WebKitBuildbot):
930
931 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
932
933         Prevent app crash on launch during simctl install workaround
934         https://bugs.webkit.org/show_bug.cgi?id=167685
935
936         Reviewed by Daniel Bates.
937
938         * Scripts/webkitpy/port/simulator_process.py:
939         (SimulatorProcess.__init__): Pass environment to install.
940         * Scripts/webkitpy/xcode/simulator.py:
941         (Device.install_app): Accept environment, pass environment to launch.
942
943 2017-02-06  Alex Christensen  <achristensen@webkit.org>
944
945         Rebase API tests after r211638
946         https://bugs.webkit.org/show_bug.cgi?id=167779
947
948         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
949         (TestWebKitAPI::TEST_F):
950         URLs with non-special schemes and characters like % in the host now fail to parse,
951         more like their special counterparts and according to spec.
952
953 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
954
955         Unreviewed trivial fix after r211697.
956         https://bugs.webkit.org/show_bug.cgi?id=167863
957
958         * Scripts/run-javascriptcore-tests:
959         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
960
961 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
962
963         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
964         https://bugs.webkit.org/show_bug.cgi?id=167850
965
966         Reviewed by Tim Horton.
967
968         * DumpRenderTree/TestRunner.cpp:
969         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
970
971 2017-02-04  Andreas Kling  <akling@apple.com>
972
973         Plug some leaks in TestController and UIScriptContext.
974         <https://webkit.org/b/167839>
975
976         Reviewed by Alexey Proskuryakov.
977
978         Fix a couple of the leaks seen on the leaks bot.
979
980         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
981         (UIScriptContext::runUIScript):
982         * WebKitTestRunner/TestController.cpp:
983         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
984         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
985
986 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
987
988         WK1 mouse events are missing movementX and movementY for pointerlock.
989         https://bugs.webkit.org/show_bug.cgi?id=167775
990         rdar://problem/30343810
991
992         Reviewed by Alexey Proskuryakov.
993
994         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
995
996         * DumpRenderTree/mac/EventSendingController.mm:
997         (-[EventSendingController mouseMoveToX:Y:]):
998         * WebKitTestRunner/mac/EventSenderProxy.mm:
999         (WTR::EventSenderProxy::mouseMoveTo):
1000
1001 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
1002
1003         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
1004         https://bugs.webkit.org/show_bug.cgi?id=167774
1005
1006         Reviewed by Tim Horton.
1007
1008         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
1009         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
1010         web process are async, so the callback fires after the web process gets the new state.
1011
1012         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1013         (WTR::UIScriptController::removeViewFromWindow):
1014         (WTR::UIScriptController::addViewToWindow):
1015         * DumpRenderTree/mac/DumpRenderTree.mm:
1016         (createWebViewAndOffscreenWindow):
1017         (resetWebViewToConsistentStateBeforeTesting):
1018         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1019         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1020         (WTR::UIScriptController::removeViewFromWindow):
1021         (WTR::UIScriptController::addViewToWindow):
1022         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1023         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1024         (WTR::UIScriptController::removeViewFromWindow):
1025         (WTR::UIScriptController::addViewToWindow):
1026         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1027         * WebKitTestRunner/PlatformWebView.h:
1028         * WebKitTestRunner/TestController.cpp:
1029         (WTR::TestController::resetStateToConsistentValues):
1030         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1031         (WTR::PlatformWebView::removeFromWindow):
1032         (WTR::PlatformWebView::addToWindow):
1033         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1034         (WTR::UIScriptController::removeViewFromWindow):
1035         (WTR::UIScriptController::addViewToWindow):
1036         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1037         (WTR::PlatformWebView::removeFromWindow):
1038         (WTR::PlatformWebView::addToWindow):
1039         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1040         (WTR::UIScriptController::removeViewFromWindow):
1041         (WTR::UIScriptController::addViewToWindow):
1042
1043 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
1044
1045         Remove check for SkipSafariExecutableEntitlementChecks
1046         https://bugs.webkit.org/show_bug.cgi?id=167762
1047
1048         Reviewed by Dan Bernstein.
1049
1050         Follow-up fix: don't break internal behavior.
1051
1052         * Scripts/webkitdirs.pm:
1053         (safariPath):
1054         (executableHasEntitlements): Deleted.
1055         (safariPathFromSafariBundle): Deleted.
1056         (installedSafariPath): Deleted.
1057
1058 2017-02-03  Daniel Bates  <dabates@apple.com>
1059
1060         [Mac][WK2] Add SPI to override the Content Security Policy of a page
1061         https://bugs.webkit.org/show_bug.cgi?id=167810
1062         <rdar://problem/30102568>
1063
1064         Reviewed by Anders Carlsson.
1065
1066         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
1067
1068         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1069         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
1070         (TEST):
1071         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
1072         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
1073         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
1074         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
1075
1076 2017-02-02  Alex Christensen  <achristensen@webkit.org>
1077
1078         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
1079         https://bugs.webkit.org/show_bug.cgi?id=167773
1080         <rdar://problem/30221102>
1081
1082         Reviewed by Ryosuke Niwa.
1083
1084         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1085         (TestWebKitAPI::TEST_F):
1086
1087 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
1088
1089         Remove check for SkipSafariExecutableEntitlementChecks
1090         https://bugs.webkit.org/show_bug.cgi?id=167762
1091         rdar://problem/22480673
1092
1093         Reviewed by Dan Bernstein.
1094
1095         * Scripts/webkitdirs.pm:
1096         (safariPathFromSafariBundle):
1097         (skipSafariExecutableEntitlementChecks): Deleted.
1098
1099 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
1100
1101         Undefined subroutine in svn-create-patch
1102         https://bugs.webkit.org/show_bug.cgi?id=167742
1103
1104         Unreviewed build-fix after r211543.
1105
1106         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
1107
1108 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1109
1110         Unreviewed. Fix jhbuild dependencies build.
1111
1112         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1113         Patch updated.
1114
1115 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1116
1117         [EME][GStreamer] Fixed decryptor selection
1118         https://bugs.webkit.org/show_bug.cgi?id=167588
1119
1120         Reviewed by Žan Doberšek.
1121
1122         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
1123
1124         * gtk/jhbuild.modules: Added patches to gstreamer and
1125         gst-plugins-good packages.
1126         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1127         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1128
1129 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
1130
1131         Make run-benchmark script supports 'config' key in test plan.
1132         https://bugs.webkit.org/show_bug.cgi?id=167715
1133
1134         Reviewed by Ryosuke Niwa.
1135
1136         Add support for 'config' key in test paln.
1137         'config' key is a dictionary that specifies environment configurations while test is running.
1138         Specifies orientation to be portrait in MotionMark benchmark.
1139
1140         * Scripts/webkitpy/benchmark_runner/README.md:
1141         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1142         (BenchmarkRunner.__init__):
1143         (BenchmarkRunner._run_benchmark):
1144         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1145         (BrowserDriver.prepare_env):
1146         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1147         (LinuxBrowserDriver.prepare_env):
1148         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1149         (OSXBrowserDriver.prepare_env):
1150         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1151         (OSXSafariDriver.prepare_env):
1152         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1153
1154 2017-02-01  Daniel Bates  <dabates@apple.com>
1155
1156         REGRESSION (r210820): svn-create-patch does not emit property change only diff
1157         https://bugs.webkit.org/show_bug.cgi?id=167169
1158
1159         Reviewed by David Kilzer.
1160
1161         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
1162         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
1163         header from the output of "svn diff" on a file that was copied or moved.
1164
1165         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
1166         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
1167         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
1168         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
1169         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
1170         of a file with only a property change also does not contain any chunk range lines. Therefore
1171         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
1172         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
1173         we should directly test for the presence of a leading SVN diff header with an empty body and
1174         remove such lines from the diff.
1175
1176         * Scripts/VCSUtils.pm:
1177         (fixSVNPatchForAdditionWithHistory): Added.
1178         * Scripts/svn-create-patch:
1179         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
1180         we have a non empty patch for an added file with history (i.e. a copied or moved file).
1181         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
1182
1183 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
1184
1185         [Mac] Update CARingBuffer class
1186         https://bugs.webkit.org/show_bug.cgi?id=167656
1187
1188         Reviewed by Jer Noble.
1189
1190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1191         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
1192         (TestWebKitAPI::CARingBufferTest::SetUp):
1193         (TestWebKitAPI::CARingBufferTest::setup):
1194         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
1195         (TestWebKitAPI::CARingBufferTest::description):
1196         (TestWebKitAPI::CARingBufferTest::bufferList):
1197         (TestWebKitAPI::CARingBufferTest::ringBuffer):
1198         (TestWebKitAPI::CARingBufferTest::capacity):
1199         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
1200         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
1201         (TestWebKitAPI::TEST_F):
1202         (TestWebKitAPI::MixingTest::run):
1203
1204 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
1205
1206         [Mac] TestWebKitAPI includes system frameworks incorrectly
1207         https://bugs.webkit.org/show_bug.cgi?id=167703
1208         rdar://problem/30301498
1209
1210         Reviewed by Ryosuke Niwa.
1211
1212         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
1213         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
1214
1215         Also, reduced the number of subframework search paths, looks like we only need one now.
1216
1217         * TestWebKitAPI/Configurations/Base.xcconfig:
1218
1219 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
1220
1221         Correct "filesHaveSameVolume" predicate
1222         https://bugs.webkit.org/show_bug.cgi?id=167696
1223         <rdar://problem/30298722>
1224
1225         Reviewed by David Kilzer.
1226
1227         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
1228         percent-escaped path inputs.
1229
1230         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
1231         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
1232         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
1233         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
1234         (TestWebKitAPI::TEST_F):
1235
1236 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1237
1238         Unreviewed. Fix coding style in MiniBrowser
1239
1240         * MiniBrowser/gtk/BrowserWindow.c:
1241         (editingCommandCallback):
1242         (insertImageCommandCallback):
1243         (insertLinkCommandCallback):
1244
1245 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1246
1247         [GTK] Add an API to add a custom tab into the print dialog
1248         https://bugs.webkit.org/show_bug.cgi?id=151998
1249
1250         Reviewed by Carlos Garcia Campos.
1251
1252         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
1253         that is testing a newly added API.
1254
1255         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1256         (testPrintCustomWidget):
1257         (beforeAll):
1258
1259 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
1260
1261         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
1262         https://bugs.webkit.org/show_bug.cgi?id=166529
1263
1264         Reviewed by Xabier Rodriguez-Calvar.
1265
1266         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
1267         New patch version accepted in GStreamer upstream.
1268
1269 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1270
1271         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
1272         https://bugs.webkit.org/show_bug.cgi?id=167498
1273
1274         Reviewed by Carlos Garcia Campos.
1275
1276         Depending on the distro version you can need either libxfont1-dev
1277         or libfont-dev to build with jhbuild.
1278
1279         * gtk/install-dependencies:
1280
1281 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1282
1283         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
1284         https://bugs.webkit.org/show_bug.cgi?id=167594
1285
1286         Unreviewed test gardening.
1287
1288         Disabling this test while we investigate the cause of a timeout on ios-simulator.
1289
1290         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1291         (TEST):
1292
1293 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
1294
1295         Move slow-running microbenchmarks out of JSTests/microbenchmarks
1296         https://bugs.webkit.org/show_bug.cgi?id=167676
1297
1298         Reviewed by Saam Barati.
1299
1300         * Scripts/run-javascriptcore-tests:
1301         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
1302
1303 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
1304
1305         Make Dump Render Tree not crash
1306         https://bugs.webkit.org/show_bug.cgi?id=167667
1307
1308         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
1309         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
1310         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
1311         This does not fix any tests, it just fixes the crash.
1312         
1313         Reviewed by Simon Fraser.
1314
1315         * DumpRenderTree/TestRunner.cpp:
1316         (TestRunner::callUIScriptCallback):
1317
1318 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1319
1320         Workaround for simctl install failing to report install failure
1321         https://bugs.webkit.org/show_bug.cgi?id=167654
1322
1323         Reviewed by Daniel Bates.
1324
1325         simctl install will sometimes report success even though install has failed.
1326         To workaround this bug, we attempt an app launch after install to ensure
1327         install has succeeded.
1328
1329         * Scripts/webkitpy/xcode/simulator.py:
1330         (Device.install_app): Attempt app launch after install, retry install if launch fails.
1331         (Device.launch_app): Correct comment.
1332
1333 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1334
1335         Unreviewed webkitpy fix after r211405.
1336
1337         * Scripts/webkitpy/xcode/simulator.py:
1338         (Device.launch_app): Remove @staticmethod on _log_debug_error.
1339
1340 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1341
1342         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
1343
1344         * gtk/manifest.txt.in:
1345
1346 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
1347
1348         AX: enable search predication for iOS
1349         https://bugs.webkit.org/show_bug.cgi?id=167558
1350         <rdar://problem/30251367>
1351
1352         Reviewed by Joanmarie Diggs.
1353
1354         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1355         (AccessibilityUIElement::uiElementForSearchPredicate):
1356         * DumpRenderTree/mac/AccessibilityCommonMac.h:
1357         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1358         (searchPredicateParameterizedAttributeForSearchCriteria):
1359         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1360         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1361         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1362         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1363         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1364         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
1365         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1366         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1367         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1368         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1369         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1370
1371 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1372
1373         Workaround for simctl launch bug
1374         https://bugs.webkit.org/show_bug.cgi?id=167613
1375
1376         Reviewed by Daniel Bates.
1377
1378         simctl launch will sometimes fail because of a race condition when many
1379         simulators are being run simultaneously. These failures will always have
1380         an exit code of 1. This change attempts to launch an app multiple times
1381         before reporting a failure to workaround this bug.
1382
1383         * Scripts/webkitpy/xcode/simulator.py:
1384         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
1385
1386 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
1387
1388         Commit queue fails to look at real name aliases for the reviewer
1389         https://bugs.webkit.org/show_bug.cgi?id=167422
1390
1391         Reviewed by Joseph Pecoraro.
1392
1393         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1394         (test_has_valid_reviewer): Added tests.
1395
1396         * Scripts/webkitpy/common/config/committers.py:
1397         (CommitterList._name_to_contributor_map):
1398         Made _name_to_contributor_map include alias names.
1399
1400         * Scripts/webkitpy/common/config/committers_unittest.py:
1401         (CommittersTest.test_contributors_by_fuzzy_match):
1402         Removed subtests that are now obsolete, as these matches are strict. It is not
1403         obvious if distance based fuzzy matching for names is useful at all, but we can
1404         look into that some other time.
1405
1406 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
1407
1408         QueueStatusServer should have an explicit timeout for _fetch_url
1409         https://bugs.webkit.org/show_bug.cgi?id=167467
1410
1411         Reviewed by Alexey Proskuryakov.
1412
1413         * Scripts/webkitpy/common/net/statusserver.py:
1414         (StatusServer._fetch_url): Add an explicit timeout of 300s.
1415
1416 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
1417
1418         Add support for Trac instances that host multiple projects.
1419         https://bugs.webkit.org/show_bug.cgi?id=167524
1420
1421         Reviewed by Alexey Proskuryakov.
1422
1423         When multiple projects are hosted on a single Trac instance, the current
1424         behavior will retrieve changesets from all tracked projects.
1425         This patch teaches Trac.js to get project-specific changesets from Trac.
1426         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
1427         when querying the Trac timeline.
1428
1429         To tell Trac to be aware of multi-project instances we leverage the 
1430         `options` parameter when creating a new instance: 
1431
1432             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
1433
1434         If this option is not provided, the original behaviour will prevail.
1435         Additionally, add corresponding tests.
1436
1437         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1438         (Trac): Reason about new optional parameter 'projectIdentifier'.
1439         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
1440         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
1441         replace default parameter `changeset=on` with `repo-projectname=on`.
1442         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
1443         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1444         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
1445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1446         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
1447         Add the following tests:
1448             test("revisionURL")
1449             test("revisionURL with Trac Identifier")
1450             test("_xmlTimelineURL")
1451             test("_xmlTimelineURL with Trac Identifier")
1452         (this.view._latestProductiveIteration): Fix missing ';'.
1453
1454 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
1455
1456         Correct spacing regression on inter-element complex path shaping on some fonts
1457         https://bugs.webkit.org/show_bug.cgi?id=166013
1458
1459         Reviewed by Simon Fraser.
1460
1461         Unskip existing tests and make some new tests:
1462         - Testing complex text with no origins
1463         - Testing initial expansions
1464         - Testing the sign of vertical advances
1465
1466         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1467         (TestWebKitAPI::TEST_F):
1468
1469 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1470
1471         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1472         https://bugs.webkit.org/show_bug.cgi?id=167596
1473
1474         Reviewed by Daniel Bates.
1475
1476         We avoid needing a thin directory by invoking the zip program with
1477         the list of directories from the build directory to be zipped,
1478         and by using the zip feature to exclude files matching a pattern.
1479
1480         * BuildSlaveSupport/built-product-archive:
1481         (copyBuildFiles):
1482         (createZipFromList):
1483         (archiveBuiltProduct):
1484
1485 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1486
1487         Use simctl instead of LayoutTestRelay
1488         https://bugs.webkit.org/show_bug.cgi?id=165927
1489
1490         Reviewed by Daniel Bates.
1491
1492         Part 1
1493
1494         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1495         simulators through simctl (iOS 10 and later), use this functionality instead.
1496
1497         * Scripts/webkitpy/port/base.py:
1498         (Port.__init__): Added _test_runner_process_constructor.
1499         * Scripts/webkitpy/port/darwin.py:
1500         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1501         * Scripts/webkitpy/port/driver.py:
1502         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1503         (IOSSimulatorDriver): Deleted.
1504         * Scripts/webkitpy/port/driver_unittest.py:
1505         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1506         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1507         (DriverTest.test_start_actually_starts): Ditto.
1508         * Scripts/webkitpy/port/ios.py:
1509         (IOSSimulatorPort): Remove relay_name.
1510         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1511         (IOSSimulatorPort._create_simulators): Formatting change.
1512         (IOSSimulatorPort.relay_path): Deleted.
1513         (IOSSimulatorPort._check_relay): Deleted.
1514         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1515         (IOSSimulatorPort._build_relay): Deleted.
1516         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1517         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1518         * Scripts/webkitpy/port/ios_unittest.py:
1519         (iosTest.test_32bit): Update test.
1520         (iosTest.test_64bit): Update test.
1521         * Scripts/webkitpy/port/server_process.py:
1522         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1523         (ServerProcess._set_file_nonblocking): Added to share common code.
1524         * Scripts/webkitpy/port/server_process_mock.py:
1525         (MockServerProcess.__init__): Added argument worker_number.
1526         * Scripts/webkitpy/port/simulator_process.py: Added.
1527         (SimulatorProcess): Added.
1528         (SimulatorProcess.Popen): Added.
1529         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1530         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1531         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1532         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1533         (SimulatorProcess._reset): Added. Unlink fifos.
1534         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1535         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1536         * Scripts/webkitpy/xcode/simulator.py:
1537         (Device.__init__): Accept host to run install/launch/terminate.
1538         (Device.install_app): Install app to target Device.
1539         (Device.launch_app): Launch app on target Device.
1540         (Device.terminate_app): Shutdown app on target Device.
1541         (Simulator._parse_devices): Pass host to Device.
1542
1543 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1544
1545         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1546         https://bugs.webkit.org/show_bug.cgi?id=167411
1547
1548         Reviewed by Michael Catanzaro.
1549
1550         Disable the ARM iwMMXt fast path for pixman, because it triggers
1551         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1552
1553         * gtk/jhbuild.modules:
1554
1555 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1556
1557         [GTK] Add API to handle the accelerated compositing policy
1558         https://bugs.webkit.org/show_bug.cgi?id=167509
1559
1560         Reviewed by Michael Catanzaro.
1561
1562         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1563         as a special case. Also add test cases to the get/set API.
1564
1565         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1566         (hardwareAccelerationPolicyToString):
1567         (stringToHardwareAccelerationPolicy):
1568         (cellRendererChanged):
1569         (browserSettingsDialogConstructed):
1570         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1571         (testWebKitSettings):
1572
1573 2017-01-29  Andy Estes  <aestes@apple.com>
1574
1575         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1576         https://bugs.webkit.org/show_bug.cgi?id=167563
1577         <rdar://problem/30253207>
1578
1579         Reviewed by Andreas Kling.
1580
1581         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1582         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1583         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1584         (runTest):
1585         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1586         (TEST):
1587
1588 2017-01-29  Dan Bernstein  <mitz@apple.com>
1589
1590         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
1591         https://bugs.webkit.org/show_bug.cgi?id=167565
1592
1593         Reviewed by Sam Weinig.
1594
1595         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1596         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
1597         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
1598         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
1599         (TEST):
1600         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
1601         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1602         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1603         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
1604
1605 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1606
1607         Add Link Preload as an off-by-default experimental feature menu item.
1608         https://bugs.webkit.org/show_bug.cgi?id=167201
1609
1610         Reviewed by Ryosuke Niwa.
1611
1612         * DumpRenderTree/mac/DumpRenderTree.mm:
1613         (resetWebPreferencesToConsistentValues):
1614         * DumpRenderTree/win/DumpRenderTree.cpp:
1615         (resetWebPreferencesToConsistentValues):
1616
1617 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1618
1619         Add User Timing Experimental Feature
1620         https://bugs.webkit.org/show_bug.cgi?id=167542
1621         <rdar://problem/22746307>
1622
1623         Reviewed by Ryosuke Niwa.
1624
1625         * DumpRenderTree/mac/DumpRenderTree.mm:
1626         (enableExperimentalFeatures):
1627         (resetWebPreferencesToConsistentValues):
1628         * DumpRenderTree/win/DumpRenderTree.cpp:
1629         (enableExperimentalFeatures):
1630
1631 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1632
1633         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
1634         https://bugs.webkit.org/show_bug.cgi?id=167519
1635
1636         Reviewed by Ryosuke Niwa.
1637
1638         * QueueStatusServer/templates/statusbubble.html:
1639         To measure the bubbleContainer's width, it must not be wrapping based
1640         on its parent container. So when measuring the width temporarily set
1641         the parent to a very large width so as to not artificially wrap us.
1642         Restore the parent's width after measuring.
1643
1644 2017-01-27  Andy Estes  <aestes@apple.com>
1645
1646         [iOS] Add a test for _WKNSFileManagerExtras
1647         https://bugs.webkit.org/show_bug.cgi?id=167478
1648
1649         Reviewed by Andreas Kling.
1650
1651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1652         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
1653         (expectAttributes):
1654         (TEST):
1655
1656 2017-01-27  Keith Miller  <keith_miller@apple.com>
1657
1658         run-benchmarks should make sure it passes the test url to the right application
1659         https://bugs.webkit.org/show_bug.cgi?id=167533
1660
1661         Reviewed by Joseph Pecoraro.
1662
1663         This fixes an issue when trying to run-benchmark script with the
1664         system default browser set to STP. Previously, it would run
1665         the test in STP rather than the provided build. Now, it should run
1666         in the provided build.
1667
1668         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1669         (OSXSafariDriver.launch_url):
1670
1671 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1672
1673         [Cocoa] Prepare ComplexTextController for unit testing
1674         https://bugs.webkit.org/show_bug.cgi?id=167493
1675
1676         Reviewed by Simon Fraser.
1677
1678         Addressing post-review comments from Simon Fraser.
1679
1680         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1681         (TestWebKitAPI::TEST_F):
1682
1683 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1684
1685         [Cocoa] Prepare ComplexTextController for unit testing
1686         https://bugs.webkit.org/show_bug.cgi?id=167493
1687
1688         Reviewed by Dean Jackson.
1689
1690         Create four unit tests.
1691
1692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1693         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
1694         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
1695         (TestWebKitAPI::TEST_F):
1696
1697 2017-01-26  Chris Dumez  <cdumez@apple.com>
1698
1699         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1700         https://bugs.webkit.org/show_bug.cgi?id=167421
1701         <rdar://problem/30188490>
1702
1703         Reviewed by Darin Adler.
1704
1705         Add a new setting allowing layout tests to enable PageCache in a window
1706         that has an opener, for convenience.
1707
1708         * DumpRenderTree/mac/DumpRenderTree.mm:
1709         (resetWebPreferencesToConsistentValues):
1710         * DumpRenderTree/win/DumpRenderTree.cpp:
1711         (resetWebPreferencesToConsistentValues):
1712         * WebKitTestRunner/TestController.cpp:
1713         (WTR::TestController::resetPreferencesToConsistentValues):
1714
1715 2017-01-26  Keith Miller  <keith_miller@apple.com>
1716
1717         classInfo should take a VM so it is not materialized from the object on each call
1718         https://bugs.webkit.org/show_bug.cgi?id=167424
1719
1720         Rubber Stamped by Michael Saboff.
1721
1722         Previously, classInfo() would get the VM from the target's
1723         MarkedBlock.  Most callers already have a VM on hand, so it is
1724         wasteful to compute the VM from the marked block every time. This
1725         patch refactors some of the most common callers of classInfo(),
1726         jsDynamicCast and inherits to take a VM as well.
1727
1728         * DumpRenderTree/TestRunner.cpp:
1729         (setAudioResultCallback):
1730
1731 2017-01-26  Jer Noble  <jer.noble@apple.com>
1732
1733         Autoplay muted videos stop playback of any streaming app in the background
1734         https://bugs.webkit.org/show_bug.cgi?id=163993
1735         <rdar://problem/29020431>
1736
1737         Reviewed by Eric Carlson.
1738
1739         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1740         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1741         (TestWebKitAPI::TEST):
1742         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
1743
1744 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
1745
1746         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
1747         https://bugs.webkit.org/show_bug.cgi?id=167466
1748
1749         Unreviewed test gardening.
1750
1751         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1752         (TEST):
1753
1754 2017-01-26  Matt Rajca  <mrajca@apple.com>
1755
1756         Notify clients when the user plays media otherwise prevented from autoplaying
1757         https://bugs.webkit.org/show_bug.cgi?id=167390
1758
1759         Reviewed by Alex Christensen.
1760
1761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1762         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1763         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1764         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1765         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1766         (TEST):
1767         * TestWebKitAPI/cocoa/TestWKWebView.h:
1768         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1769         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1770         (-[TestWKWebView waitForLoad]):
1771         (-[TestWKWebView mouseUpAtPoint:]):
1772         * WebKitTestRunner/TestController.cpp:
1773         (WTR::TestController::createOtherPage):
1774         (WTR::TestController::createWebViewWithOptions):
1775
1776 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1777
1778         Crash when setting custom scale factor.
1779         https://bugs.webkit.org/show_bug.cgi?id=167369
1780
1781         Reviewed by Sam Weinig.
1782
1783         Added API test.
1784
1785         * TestWebKitAPI/PlatformWin.cmake:
1786         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1787         (TestWebKitAPI::WebKitCreateInstance):
1788         (TestWebKitAPI::ScaleWebView::SetUp):
1789         (TestWebKitAPI::ScaleWebView::TearDown):
1790         (TestWebKitAPI::TEST_F):
1791
1792 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1793
1794         run-benchmark nests MotionMark results by the suite name twice
1795         https://bugs.webkit.org/show_bug.cgi?id=164948
1796
1797         Reviewed by Said Abou-Hallawa.
1798
1799         Use a single level MotionMark now that this is the name of the benchmark,
1800         and we no longer have tests that aren't part of the MotionMark suite.
1801
1802         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1803
1804 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1805
1806         Unreviewed, rolling out r211193.
1807
1808         This change broke internal builds.
1809
1810         Reverted changeset:
1811
1812         "Notify clients when the user plays media otherwise prevented
1813         from autoplaying"
1814         https://bugs.webkit.org/show_bug.cgi?id=167390
1815         http://trac.webkit.org/changeset/211193
1816
1817 2017-01-25  Matt Rajca  <mrajca@apple.com>
1818
1819         Notify clients when the user plays media otherwise prevented from autoplaying
1820         https://bugs.webkit.org/show_bug.cgi?id=167390
1821
1822         Reviewed by Alex Christensen.
1823
1824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1825         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1826         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1827         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1828         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1829         (TEST):
1830         * TestWebKitAPI/cocoa/TestWKWebView.h:
1831         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1832         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1833         (-[TestWKWebView waitForLoad]):
1834         (-[TestWKWebView mouseUpAtPoint:]):
1835         * WebKitTestRunner/TestController.cpp:
1836         (WTR::TestController::createOtherPage):
1837         (WTR::TestController::createWebViewWithOptions):
1838
1839 2017-01-25  Matt Rajca  <mrajca@apple.com>
1840
1841         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1842         https://bugs.webkit.org/show_bug.cgi?id=167385
1843
1844         Reviewed by Alex Christensen.
1845
1846         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1847         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1848         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1849         (TEST): Allow inline (rather than full screen) media playback on iOS.
1850
1851 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1852
1853         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1854         https://bugs.webkit.org/show_bug.cgi?id=167414
1855
1856         Reviewed by Michael Catanzaro.
1857
1858         Add a test case to check ephemeral web views don't write favicons to the database.
1859
1860         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1861         (ephemeralViewLoadChanged):
1862         (testPrivateBrowsing):
1863         (testFaviconDatabase):
1864
1865 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1866
1867         [GTK] Add a private browsing mode to MiniBrowser
1868         https://bugs.webkit.org/show_bug.cgi?id=167413
1869
1870         Reviewed by Michael Catanzaro.
1871
1872         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1873         private windows, even on non-private instances.
1874
1875         * MiniBrowser/gtk/BrowserWindow.c:
1876         (webViewTitleChanged): Add [Private] to title window for private windows.
1877         (webViewCreate): Pass web context to browser_window_new.
1878         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1879         (browserWindowFinalize): Disconnect web context signal handlers.
1880         (browser_window_init): Add shortcut for opening private window.
1881         (browser_window_new): It now receives the context and connect to download-started here.
1882         (browser_window_get_web_context): Return the context.
1883         * MiniBrowser/gtk/BrowserWindow.h:
1884         * MiniBrowser/gtk/main.c:
1885         (createBrowserTab): Create the web view for the window web context.
1886         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1887         (aboutDataHandleRequest): Ditto.
1888         (aboutURISchemeRequestCallback): Ditto.
1889         (main): Create ephemeral web context if private command line option is used.
1890
1891 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1892
1893         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1894         https://bugs.webkit.org/show_bug.cgi?id=167409
1895
1896         Reviewed by Antti Koivisto.
1897
1898         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1899         as well as tests for the newly added matchingElementInFlatTree.
1900
1901         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1902         (TestWebKitAPI::runJavaScriptAlert):
1903         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1904         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1905         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1906
1907 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1908
1909         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1910         https://bugs.webkit.org/show_bug.cgi?id=167370
1911
1912         Reviewed by Michael Catanzaro.
1913
1914         Add several test cases of ephemeral web views.
1915
1916         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1917         (testWebViewAuthenticationStorage):
1918         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1919         (ephemeralViewloadChanged):
1920         (testCookieManagerEphemeral):
1921         (beforeAll):
1922         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1923         (testWebKitSettings):
1924         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1925         (testWebContextEphemeral):
1926         (ephemeralViewloadChanged):
1927         (testWebContextProxySettings):
1928         (beforeAll):
1929         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1930         (ephemeralViewloadChanged):
1931         (testWebViewEphemeral):
1932         (beforeAll):
1933         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1934         (ephemeralViewloadChanged):
1935         (testWebsiteDataEphemeral):
1936         (beforeAll):
1937
1938 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1939
1940         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1941         https://bugs.webkit.org/show_bug.cgi?id=167402
1942
1943         Reviewed by Ryosuke Niwa.
1944
1945         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1946         (TestWebKitAPI::TEST):
1947
1948 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1949
1950         Add simple line layout toggle to MiniBrowser
1951         https://bugs.webkit.org/show_bug.cgi?id=167405
1952
1953         Reviewed by Andreas Kling.
1954
1955         * MiniBrowser/mac/SettingsController.h:
1956         * MiniBrowser/mac/SettingsController.m:
1957         (-[SettingsController _populateMenu]):
1958         (-[SettingsController validateMenuItem:]):
1959         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1960         (-[SettingsController simpleLineLayoutEnabled]):
1961         * MiniBrowser/mac/WK1BrowserWindowController.m:
1962         (-[WK1BrowserWindowController didChangeSettings]):
1963         * MiniBrowser/mac/WK2BrowserWindowController.m:
1964         (-[WK2BrowserWindowController didChangeSettings]):
1965
1966 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1967
1968         WKR does not include my nick when commit-queue lands my patch
1969         https://bugs.webkit.org/show_bug.cgi?id=167388
1970
1971         Reviewed by Ryosuke Niwa.
1972
1973         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1974         (NewCommitBot._summarize_commit_log):
1975         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1976         Perform nickname insertion before grabbing "Patch by" details.
1977         This way we can include the nickname with the full name.
1978
1979 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1980
1981         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1982         https://bugs.webkit.org/show_bug.cgi?id=167394
1983
1984         Reviewed by Ryosuke Niwa.
1985
1986         * Scripts/webkitperl/FeatureList.pm:
1987         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1988
1989 2017-01-24  Youenn Fablet  <youenn@apple.com>
1990
1991         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1992         https://bugs.webkit.org/show_bug.cgi?id=167353
1993
1994         Reviewed by Alex Christensen.
1995
1996         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1997         (CMakeGenerator.initialize_targets):
1998
1999 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2000
2001         WKR should not confuse Miguel Gomez with Andres Gomez
2002         https://bugs.webkit.org/show_bug.cgi?id=167389
2003
2004         Reviewed by Lucas Forschler.
2005
2006         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
2007         "mAndres Gomez". Fix this.
2008
2009         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2010         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
2011         space on each side of the email address, so expect both spaces to be there before
2012         considering the email for replacement.
2013         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
2014
2015 2017-01-24  Matt Rajca  <mrajca@apple.com>
2016
2017         Pass down website autoplay policies to media elements
2018         https://bugs.webkit.org/show_bug.cgi?id=167355
2019
2020         Reviewed by Alex Christensen.
2021
2022         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2023         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
2024         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
2025         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
2026         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2027         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2028         (TEST):
2029
2030 2017-01-24  Nan Wang  <n_wang@apple.com>
2031
2032         AX: Speak Selection does not work in an iframe
2033         https://bugs.webkit.org/show_bug.cgi?id=166794
2034         <rdar://problem/29913013>
2035
2036         Reviewed by Chris Fleizach.
2037
2038         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2039         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2040         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2041         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2042         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2043         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2044         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2045         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2046         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2047         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2048         (-[TestRunnerWKWebView dealloc]):
2049         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
2050         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
2051         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2052         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2053         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2054
2055 2017-01-24  Daniel Bates  <dabates@apple.com>
2056
2057         StringView.split() should use an iterator design pattern instead of allocating a Vector
2058         https://bugs.webkit.org/show_bug.cgi?id=163225
2059
2060         Reviewed by Darin Adler.
2061
2062         Add unit tests for StringView.split().
2063
2064         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2065         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
2066         used in the StringView.split() unit tests.
2067         (TestWebKitAPI::stringViewFromUTF8): Ditto.
2068         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
2069         object to a Vector of String objects.
2070         (TestWebKitAPI::TEST): Added the following tests:
2071             - WTF.StringViewSplitEmptyAndNullStrings
2072             - WTF.StringViewSplitBasic
2073             - WTF.StringViewSplitWithConsecutiveSeparators
2074
2075 2017-01-23  Anders Carlsson  <andersca@apple.com>
2076
2077         The Score Esports crashes on launch
2078         https://bugs.webkit.org/show_bug.cgi?id=167338
2079         rdar://problem/29948645
2080
2081         Reviewed by Dan Bernstein.
2082
2083         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2084         (TestWebKitAPI::TEST):
2085         Add a test.
2086
2087 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2088
2089         [GTK] Add API to WebKitWebsiteDataManager to handle website data
2090         https://bugs.webkit.org/show_bug.cgi?id=146589
2091
2092         Reviewed by Michael Catanzaro.
2093
2094         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
2095         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
2096
2097         * MiniBrowser/gtk/BrowserWindow.c:
2098         (webViewDecidePolicy):
2099         (newTabCallback):
2100         * MiniBrowser/gtk/main.c:
2101         (createBrowserTab):
2102         (aboutDataRequestFree):
2103         (aboutDataRequestNew):
2104         (aboutDataRequestForView):
2105         (websiteDataRemovedCallback):
2106         (websiteDataClearedCallback):
2107         (aboutDataScriptMessageReceivedCallback):
2108         (domainListFree):
2109         (aboutDataFillTable):
2110         (gotWebsiteDataCallback):
2111         (aboutDataHandleRequest):
2112         (aboutURISchemeRequestCallback):
2113         (main):
2114         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2115         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2116         (serverCallback):
2117         (beforeAll):
2118         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
2119         (serverCallback):
2120         (WebsiteDataTest::WebsiteDataTest):
2121         (WebsiteDataTest::~WebsiteDataTest):
2122         (WebsiteDataTest::fetch):
2123         (WebsiteDataTest::remove):
2124         (WebsiteDataTest::clear):
2125         (testWebsiteDataConfiguration):
2126         (testWebsiteDataCache):
2127         (testWebsiteDataStorage):
2128         (testWebsiteDataDatabases):
2129         (testWebsiteDataAppcache):
2130         (beforeAll):
2131         (afterAll):
2132
2133 2017-01-23  Commit Queue  <commit-queue@webkit.org>
2134
2135         Unreviewed, rolling out r211062.
2136         https://bugs.webkit.org/show_bug.cgi?id=167354
2137
2138         broke API tests (Requested by alexchristensen on #webkit).
2139
2140         Reverted changeset:
2141
2142         "Pass down website autoplay policies to media elements"
2143         https://bugs.webkit.org/show_bug.cgi?id=167132
2144         http://trac.webkit.org/changeset/211062
2145
2146 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2147
2148         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
2149         https://bugs.webkit.org/show_bug.cgi?id=167330
2150
2151         Reviewed by Tim Horton.
2152
2153         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2154         (TestWebKitAPI::TEST_F):
2155
2156 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2157
2158         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
2159         https://bugs.webkit.org/show_bug.cgi?id=167317
2160
2161         Reviewed by Sam Weinig.
2162
2163         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2164         (TestWebKitAPI::TEST_F):
2165
2166 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
2167
2168         svn-create-patch should emit properties when files are moved or copied
2169         https://bugs.webkit.org/show_bug.cgi?id=167264
2170
2171         Reviewed by Daniel Bates.
2172
2173         * Scripts/svn-create-patch:
2174         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
2175
2176 2017-01-23  Youenn Fablet  <youenn@apple.com>
2177
2178         [WebRTC] Filter libwebrtc link flags
2179         https://bugs.webkit.org/show_bug.cgi?id=167287
2180
2181         Reviewed by Alex Christensen.
2182
2183         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2184         (CMakeGenerator._compute_link_flags):
2185         (CMakeGenerator._compute_link_flags.keep_flag):
2186         (CMakeGenerator._generate_compile_target_options):
2187
2188 2017-01-23  Youenn Fablet  <youennf@gmail.com>
2189
2190         [WebRTC] Make VP8 optional in libwebrtc
2191         https://bugs.webkit.org/show_bug.cgi?id=167257
2192
2193         Reviewed by Darin Adler.
2194
2195         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2196         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
2197
2198 2017-01-23  Jer Noble  <jer.noble@apple.com>
2199
2200         Video details does not apear and missing scrubber in Control Center
2201         https://bugs.webkit.org/show_bug.cgi?id=167233
2202
2203         Reviewed by Alex Christensen.
2204
2205         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
2206         NowPlayingControlTests for iOS.
2207
2208         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2209         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2210         (-[NowPlayingTestWebView setWindowVisible:]):
2211         (TestWebKitAPI::TEST):
2212         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
2213         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2214         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2215         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
2216         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
2217         (SOFT_LINK_CLASS):
2218         (-[TestMessageHandler addMessage:withHandler:]):
2219         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
2220         (__simulated_forceClickAssociatedEventsMask):
2221         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
2222         (-[TestWKWebViewHostWindow isKeyWindow]):
2223         (-[TestWKWebViewHostWindow makeKeyWindow]):
2224         (-[TestWKWebViewHostWindow resignKeyWindow]):
2225         (-[TestWKWebView initWithFrame:]):
2226         (-[TestWKWebView initWithFrame:configuration:]):
2227         (-[TestWKWebView _setUpTestWindow:]):
2228         (-[TestWKWebView performAfterReceivingMessage:action:]):
2229         (-[TestWKWebView loadTestPageNamed:]):
2230         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
2231         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2232         (-[TestWKWebView waitForMessage:]):
2233         (-[TestWKWebView performAfterLoading:]):
2234         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2235         (-[TestWKWebView typeCharacter:]):
2236
2237 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2238
2239         Unreviewed. Bring back gtk-doc error messages after r209981.
2240
2241         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
2242         impossible to know what's wrong.
2243
2244         * gtk/gtkdoc.py:
2245         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
2246
2247 2017-01-20  Youenn Fablet  <youennf@gmail.com>
2248
2249         [WebRTC] Update build system to make G711 optional in libwebrtc
2250         https://bugs.webkit.org/show_bug.cgi?id=167256
2251
2252         Reviewed by Alex Christensen.
2253
2254         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2255         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
2256
2257 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2258
2259         Cleanup RuntimeEnabledFeatures
2260         https://bugs.webkit.org/show_bug.cgi?id=167228
2261
2262         Reviewed by Simon Fraser.
2263
2264         * DumpRenderTree/mac/DumpRenderTree.mm:
2265         (enableExperimentalFeatures):
2266         (resetWebPreferencesToConsistentValues):
2267         (setWebPreferencesForTestOptions):
2268         (resetWebViewToConsistentStateBeforeTesting):
2269         * DumpRenderTree/win/DumpRenderTree.cpp:
2270         (enableExperimentalFeatures):
2271         (resetWebPreferencesToConsistentValues):
2272         More closely match WebKitTestRunner initialization of preferences
2273         for experimental features.
2274
2275 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2276
2277         Build Fix for Windows DumpRenderTree after r210976
2278         https://bugs.webkit.org/show_bug.cgi?id=167115
2279
2280         * DumpRenderTree/win/DumpRenderTree.cpp:
2281         (resetWebPreferencesToConsistentValues):
2282
2283 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2284
2285         Remove outdated ENABLE(CSP_NEXT) build flag
2286         https://bugs.webkit.org/show_bug.cgi?id=167252
2287
2288         Reviewed by Brent Fulgham.
2289
2290         * Scripts/webkitperl/FeatureList.pm:
2291         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2292
2293 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2294
2295         Build Fix for Windows DumpRenderTree after r210976
2296
2297         * DumpRenderTree/win/DumpRenderTree.cpp:
2298         (resetWebPreferencesToConsistentValues):
2299
2300 2017-01-20  Antoine Quint  <graouts@apple.com>
2301
2302         Web Animations should be off by default and enabled as an experimental feature
2303         https://bugs.webkit.org/show_bug.cgi?id=167115
2304         <rdar://problem/30048963>
2305
2306         Reviewed by Joseph Pecoraro.
2307
2308         Turn Web Animations on in DRT.
2309
2310         * DumpRenderTree/mac/DumpRenderTree.mm:
2311         (resetWebPreferencesToConsistentValues):
2312         * DumpRenderTree/win/DumpRenderTree.cpp:
2313         (resetWebPreferencesToConsistentValues):
2314
2315 2017-01-20  Youenn Fablet  <youenn@apple.com>
2316
2317         [WebRTC] Add libwebrtc build infrastructure
2318         https://bugs.webkit.org/show_bug.cgi?id=167207
2319
2320         Reviewed by Alex Christensen.
2321
2322         Adding a script doing the libwebrtc project json to CMake file conversion.
2323
2324         * Scripts/generate-libwebrtc-cmake: Added.
2325         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
2326         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
2327
2328 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2329
2330         Mini Browser: Show tooltip for Experimental Features
2331         https://bugs.webkit.org/show_bug.cgi?id=167225
2332
2333         Reviewed by Alex Christensen.
2334
2335         * MiniBrowser/mac/SettingsController.m:
2336         (-[SettingsController _populateMenu]):
2337         Include the full details string as a tooltip.
2338
2339 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
2340
2341         [Win] Test output results should not be written twice.
2342         https://bugs.webkit.org/show_bug.cgi?id=167197
2343
2344         Reviewed by Brent Fulgham.
2345
2346         Prevent test output from being written twice by returning early from
2347         the dump() function, if it already has been called.
2348         This patch also adds a missing newline to a test output line. 
2349         
2350         * DumpRenderTree/win/DumpRenderTree.cpp:
2351         (dump):
2352
2353 2017-01-20  Antoine Quint  <graouts@apple.com>
2354
2355         [Modern Media Controls] Turn modern media controls on by default
2356         https://bugs.webkit.org/show_bug.cgi?id=165668
2357
2358         Reviewed by Dean Jackson.
2359
2360         Enabled modern media controls by default in test runners.
2361
2362         * DumpRenderTree/TestOptions.h:
2363         * WebKitTestRunner/TestOptions.h:
2364
2365 2017-01-19  Chris Dumez  <cdumez@apple.com>
2366
2367         iterable<> should be enabled on WK1
2368         https://bugs.webkit.org/show_bug.cgi?id=167221
2369         <rdar://problem/30108531>
2370
2371         Reviewed by Youenn Fablet.
2372
2373         * DumpRenderTree/mac/DumpRenderTree.mm:
2374         (resetWebPreferencesToConsistentValues):
2375         * DumpRenderTree/win/DumpRenderTree.cpp:
2376         (resetWebPreferencesToConsistentValues):
2377         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2378         (WTR::InjectedBundle::beginTesting):
2379         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2380         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
2381         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2382
2383 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
2384
2385         Ensure status server logs go to log file
2386         https://bugs.webkit.org/show_bug.cgi?id=167210
2387
2388         Reviewed by Alexey Proskuryakov.
2389
2390         * Scripts/webkitpy/common/net/statusserver.py:
2391         (StatusServer.next_work_item): Change log level from debug to info in
2392         order to facilitate deubgging issues.
2393         (StatusServer.update_work_items): Same.
2394
2395 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
2396
2397         Additional selection tests and interpolation fix
2398         https://bugs.webkit.org/show_bug.cgi?id=167171
2399
2400         Reviewed by Simon Fraser.
2401
2402         We weren't adding the final event when interpolating event streams.
2403
2404         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2405         (-[HIDEventGenerator interpolatedEvents:]):
2406
2407 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2408
2409         [Cocoa] Variation fonts are erroneously disabled on iOS
2410         https://bugs.webkit.org/show_bug.cgi?id=167172
2411
2412         Reviewed by Simon Fraser.
2413
2414         OpenSource builders don't seem to understand sdk=embedded*.
2415
2416         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2417
2418 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2419
2420         Unreviewed. Fix GTK+ unit tests failing since r210531.
2421
2422         Avoid using paths to files that don't actually exist.
2423
2424         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2425         (testWebKitConsoleMessageNetworkError):
2426         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2427         (testContextMenuDefaultMenu):
2428         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
2429         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
2430         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
2431
2432 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2433
2434         [GTK] Provide API to set proxy settings
2435         https://bugs.webkit.org/show_bug.cgi?id=128674
2436
2437         Reviewed by Michael Catanzaro.
2438
2439         Add tests for new proxy settings API.
2440
2441         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2442         (serverCallback):
2443         (ProxyTest::ProxyTest):
2444         (ProxyTest::~ProxyTest):
2445         (ProxyTest::loadURIAndGetMainResourceData):
2446         (ProxyTest::proxyServerPortAsString):
2447         (testWebContextProxySettings):
2448         (beforeAll):
2449
2450 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2451
2452         Add back my old email address so old commits will still match it.
2453
2454         * Scripts/webkitpy/common/config/contributors.json:
2455
2456 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2457
2458         Remove my old email address from contributors.json and watchlist.
2459
2460         * Scripts/validate-committer-lists:
2461         (CommitterListFromGit): Change the mapping to the correct email.
2462         * Scripts/webkitpy/common/config/contributors.json:
2463         * Scripts/webkitpy/common/config/watchlist:
2464
2465 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2466
2467         Unreviewed, rolling out r210848.
2468
2469         This change introduced media-related LayoutTest failures and
2470         crashes on macOS.
2471
2472         Reverted changeset:
2473
2474         "[Modern Media Controls] Turn modern media controls on by
2475         default"
2476         https://bugs.webkit.org/show_bug.cgi?id=165668
2477         http://trac.webkit.org/changeset/210848
2478
2479 2017-01-18  Andreas Kling  <akling@apple.com>
2480
2481         Document::securityOrigin() should return a reference.
2482         <https://webkit.org/b/167124>
2483
2484         Reviewed by Sam Weinig.
2485
2486         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2487         (TestWebKitAPI::TEST_F):
2488
2489 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2490
2491         [Win] Clipboard tests are flaky.
2492         https://bugs.webkit.org/show_bug.cgi?id=167088
2493
2494         Reviewed by Brent Fulgham.
2495
2496         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2497         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2498
2499         * DumpRenderTree/win/DumpRenderTree.cpp:
2500         (main):
2501
2502 2017-01-18  Antoine Quint  <graouts@apple.com>
2503
2504         [Modern Media Controls] Turn modern media controls on by default
2505         https://bugs.webkit.org/show_bug.cgi?id=165668
2506
2507         Reviewed by Dean Jackson.
2508
2509         Enabled modern media controls by default in test runners. 
2510
2511         * DumpRenderTree/TestOptions.h:
2512         * WebKitTestRunner/TestOptions.h:
2513
2514 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2515
2516         Unreviewed, rolling out r210834
2517         https://bugs.webkit.org/show_bug.cgi?id=165668
2518
2519         It introduced dozens of test timeouts.
2520
2521         Reverted changeset:
2522         "[Modern Media Controls] Turn modern media controls on by default"
2523         https://bugs.webkit.org/show_bug.cgi?id=165668
2524         http://trac.webkit.org/changeset/210834
2525
2526 2017-01-17  Antoine Quint  <graouts@apple.com>
2527
2528         [Modern Media Controls] Turn modern media controls on by default
2529         https://bugs.webkit.org/show_bug.cgi?id=165668
2530
2531         Reviewed by Dean Jackson.
2532
2533         Enabled modern media controls by default in test runners. 
2534
2535         * DumpRenderTree/TestOptions.h:
2536         * WebKitTestRunner/TestOptions.h:
2537
2538 2017-01-17  Chris Dumez  <cdumez@apple.com>
2539
2540         Document title changed twice when setting document.title
2541         https://bugs.webkit.org/show_bug.cgi?id=167065
2542
2543         Reviewed by Darin Adler.
2544
2545         Add WebKit2GTK API test that was written by Michael Catanzaro.
2546
2547         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2548         (testWebViewTitleChange):
2549         (beforeAll):
2550
2551 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2552
2553         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2554         https://bugs.webkit.org/show_bug.cgi?id=116551
2555         <rdar://problem/13949830>
2556
2557         Reviewed by Alex Christensen.
2558
2559         * Scripts/webkitperl/FeatureList.pm:
2560         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2561         that is part of the existing WEB_TIMING feature.
2562
2563         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2564
2565 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
2566
2567         'webkit-patch post' no longer works with moved/copied files
2568         https://bugs.webkit.org/show_bug.cgi?id=166914
2569         <rdar://problem/29979707>
2570
2571         Reviewed by Daniel Bates.
2572
2573         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
2574         file outputs only the "Index:" line with an empty body.  This workaround
2575         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
2576         public email list tracking this bug is below.
2577         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
2578         
2579
2580         * Scripts/svn-create-patch:
2581         (generateDiff): Ignore an "Index:" line with an empty body.
2582
2583 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2584
2585         Remove the REQUEST_ANIMATION_FRAME flag
2586         https://bugs.webkit.org/show_bug.cgi?id=156980
2587         <rdar://problem/25906849>
2588
2589         Reviewed by Simon Fraser.
2590
2591         * Scripts/webkitperl/FeatureList.pm:
2592         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2593
2594 2017-01-15  Sam Weinig  <sam@webkit.org>
2595
2596         Add the ability to use numbers in makeString()
2597         https://bugs.webkit.org/show_bug.cgi?id=167087
2598
2599         Reviewed by Darin Adler.
2600
2601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2602         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
2603         Add tests for StringConcatenate, focusing on new numeric additions.
2604
2605 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2606
2607         Unreviewed, remove stale comment.
2608
2609         This test was fixed by r163173.
2610
2611         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2612
2613 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2614
2615         Annotate large string tests with largeHeap
2616         https://bugs.webkit.org/show_bug.cgi?id=167054
2617
2618         Reviewed by Filip Pizlo.
2619
2620         * Scripts/run-javascriptcore-tests:
2621         * Scripts/run-jsc-stress-tests:
2622
2623 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
2624
2625         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
2626         https://bugs.webkit.org/show_bug.cgi?id=167043
2627
2628         Reviewed by Darin Adler.
2629
2630         * Scripts/webkitperl/FeatureList.pm:
2631
2632 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2633
2634         Remove ENABLE(DETAILS_ELEMENT) guards
2635         https://bugs.webkit.org/show_bug.cgi?id=167042
2636
2637         Reviewed by Alex Christensen.
2638
2639         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2640
2641 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
2642
2643         26 MotionMark performance tests failing
2644         https://bugs.webkit.org/show_bug.cgi?id=166854
2645
2646         Reviewed by Ryosuke Niwa.
2647
2648         Unrelated change. This is the last place that we need to rename Animometer
2649         to MotionMark.
2650
2651         * Scripts/webkitpy/common/config/watchlist:
2652
2653 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2654
2655         run-jsc-benchmarks' echo should have -e option
2656         https://bugs.webkit.org/show_bug.cgi?id=167009
2657
2658         Reviewed by Sam Weinig.
2659
2660         echo requires `-e` option to use escape sequence.
2661         Without it, in some environment (in my Fedora 25), the escape sequence is not
2662         recognized and just dumped as `\c` etc.
2663
2664         * Scripts/run-jsc-benchmarks:
2665
2666 2017-01-12  Chris Dumez  <cdumez@apple.com>
2667
2668         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2669         https://bugs.webkit.org/show_bug.cgi?id=166995
2670
2671         Reviewed by Jer Noble.
2672
2673         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2674         as some people are having trouble building without it.
2675
2676         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2677
2678 2017-01-12  Sam Weinig  <sam@webkit.org>
2679
2680         Add the ability to filter the set of bindings tests you want to run
2681         https://bugs.webkit.org/show_bug.cgi?id=166977
2682
2683         Reviewed by Tim Horton.
2684
2685         Allows doing things like:
2686             run-bindings-tests TestObj* TestCEReactions*
2687         
2688         to run only those tests that match the patterns.
2689
2690         * Scripts/run-bindings-tests:
2691         (main):
2692         Switch to using optparse and pass the remaining args as the filters.
2693
2694         * Scripts/webkitpy/bindings/main.py:
2695         (BindingsTests.__init__):
2696         Store the pattens.
2697
2698         (BindingsTests.test_matches_patterns):
2699         Add helper predicate to determine if a test should be run. When no
2700         patterns are present, all tests should run.
2701
2702         (BindingsTests.run_tests):
2703         Filter tests using the passed in patterns.
2704
2705 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
2706
2707         Followup fix after r210503.
2708         https://bugs.webkit.org/show_bug.cgi?id=166887
2709
2710         Reviewed by Alex Christensen.
2711
2712         After <http://trac.webkit.org/changeset/210503>, test results are written to a
2713         duplicated file handle on Windows. This patch fixes the remaining call sites.
2714
2715         * DumpRenderTree/PixelDumpSupport.cpp:
2716         * DumpRenderTree/TestRunner.cpp:
2717         (TestRunner::waitToDumpWatchdogTimerFired):
2718         * DumpRenderTree/TestRunner.h:
2719         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2720         * DumpRenderTree/win/DumpRenderTree.cpp:
2721         * DumpRenderTree/win/DumpRenderTreeWin.h:
2722         * DumpRenderTree/win/TestRunnerWin.cpp:
2723         (TestRunner::setSpellCheckerLoggingEnabled):
2724
2725 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
2726
2727         Add committer status for Megan
2728         https://bugs.webkit.org/show_bug.cgi?id=166954
2729
2730         Reviewed by Tim Horton.
2731
2732         Add committer status for Megan Gardner
2733
2734         * Scripts/webkitpy/common/config/contributors.json:
2735
2736 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2737
2738         Unreviewed test fix after r210599.
2739
2740         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2741         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
2742
2743 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2744
2745         Unreviewed build fix after r210599.
2746
2747         Add missing files.
2748
2749         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2750         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2751
2752 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2753
2754         File scheme should not allow access of a resource on a different volume.
2755         https://bugs.webkit.org/show_bug.cgi?id=158552
2756         <rdar://problem/15307582>
2757
2758         Reviewed by Alex Christensen.
2759
2760         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2761         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2762         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2763
2764 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2765
2766         Unreviewed, rolling out r210571.
2767
2768         This change broke the 32-bit macOS build and caused LayoutTest
2769         failures.
2770
2771         Reverted changeset:
2772
2773         "File scheme should not allow access of a resource on a
2774         different volume."
2775         https://bugs.webkit.org/show_bug.cgi?id=158552
2776         http://trac.webkit.org/changeset/210571
2777
2778 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2779
2780         [GTK] install-dependencies script misses gdb
2781         https://bugs.webkit.org/show_bug.cgi?id=166917
2782
2783         Reviewed by Michael Catanzaro.
2784
2785         gdb is needed for generating the crash logs.
2786
2787         * gtk/install-dependencies:
2788
2789 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2790
2791         [GTK] No way for applications to set notification permissions without waiting for permission request
2792         https://bugs.webkit.org/show_bug.cgi?id=163366
2793
2794         Reviewed by Carlos Garcia Campos.
2795
2796         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2797         (testWebViewNotification):
2798         (setInitialNotificationPermissionsAllowedCallback):
2799         (setInitialNotificationPermissionsDisallowedCallback):
2800         (testWebViewNotificationInitialPermissionAllowed):
2801         (testWebViewNotificationInitialPermissionDisallowed):
2802         (beforeAll):
2803         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2804         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2805         (WebViewTest::WebViewTest):
2806         (WebViewTest::initializeWebView):
2807         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2808
2809 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2810
2811         MobileMiniBrowser tests don't work by default
2812         https://bugs.webkit.org/show_bug.cgi?id=166910
2813
2814         Reviewed by Alex Christensen.
2815
2816         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2817         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2818
2819 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2820
2821         File scheme should not allow access of a resource on a different volume.
2822         https://bugs.webkit.org/show_bug.cgi?id=158552
2823         <rdar://problem/15307582>
2824
2825         Reviewed by Alex Christensen.
2826
2827         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2828         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2829         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2830
2831 2017-01-10  Mark Lam  <mark.lam@apple.com>
2832
2833         Reverting run-jsc-stress-tests' $buildType to use string values.
2834         https://bugs.webkit.org/show_bug.cgi?id=166912
2835
2836         Rubber stamped by Filip Pizlo.
2837
2838         This is so that we can test for it in the tests e.g.
2839         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2840
2841         * Scripts/run-jsc-stress-tests:
2842
2843 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2844
2845         Temporarily add back the file removed in r210463 to unbreak internal bots.
2846
2847         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2848
2849 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2850
2851         svn-apply failed to apply a patch (deleting file with svn property)
2852         https://bugs.webkit.org/show_bug.cgi?id=165953
2853
2854         Reviewed by Daniel Bates.
2855
2856         * Scripts/VCSUtils.pm:
2857         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2858         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2859
2860 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2861
2862         Update flakiness dashboard configuration.
2863         https://bugs.webkit.org/show_bug.cgi?id=166869
2864
2865         Reviewed by Alexey Proskuryakov.
2866
2867         * TestResultServer/static-dashboards/builders.jsonp:
2868         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2869
2870 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2871
2872         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2873         https://bugs.webkit.org/show_bug.cgi?id=165232
2874
2875         Unreviewed follow-up patch after r210539 and r210523.
2876
2877         Instead of using that environment variable, the argument
2878         --display-server=xorg should be passed now.
2879
2880         The GTK+ performance bot was the only bot using this, and is
2881         already passing --display-server=xorg after r210539.
2882
2883         * Scripts/webkitpy/port/gtk.py:
2884         (GtkPort._driver_class):
2885
2886 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2887
2888         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2889         https://bugs.webkit.org/show_bug.cgi?id=166872
2890
2891         Reviewed by Michael Catanzaro.
2892
2893         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2894         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2895         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2896         The step RunWebKitTests already has support for it.
2897
2898         * BuildSlaveSupport/build.webkit.org-config/config.json:
2899         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2900         (RunGtkAPITests.start):
2901         (RunAndUploadPerfTests.start):
2902         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2903
2904 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2905
2906         Unreviewed, rolling out r210531.
2907
2908         This change broke the 32-bit macOS build and caused LayoutTest
2909         failures.
2910
2911         Reverted changeset:
2912
2913         "File scheme should not allow access of a resource on a
2914         different volume."
2915         https://bugs.webkit.org/show_bug.cgi?id=158552
2916         http://trac.webkit.org/changeset/210531
2917
2918 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2919
2920         File scheme should not allow access of a resource on a different volume.
2921         https://bugs.webkit.org/show_bug.cgi?id=158552
2922         <rdar://problem/15307582>
2923
2924         Reviewed by Alex Christensen.
2925
2926         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2927         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2928         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2929
2930 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2931
2932         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2933         https://bugs.webkit.org/show_bug.cgi?id=165232
2934
2935         Reviewed by Michael Catanzaro.
2936
2937         Add a new WaylandDriver to run the tests in the user current wayland session.
2938
2939         Also merge all the configuration options for selecting the display server inside one
2940         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2941
2942         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2943
2944         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2945         (TestRunner._create_driver):
2946         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2947         (parse_args):
2948         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2949         (PerfTestsRunner._parse_args):
2950         * Scripts/webkitpy/port/gtk.py:
2951         (GtkPort.__init__):
2952         (GtkPort._driver_class):
2953         (GtkPort._search_paths):
2954         * Scripts/webkitpy/port/waylanddriver.py: Added.
2955         (WaylandDriver):
2956         (WaylandDriver.check_driver):
2957         (WaylandDriver._setup_environ_for_test):
2958         (WaylandDriver._start):
2959
2960 2017-01-09  Andy Estes  <aestes@apple.com>
2961
2962         [QuickLook] Add a layout test for webkit.org/b/135651
2963         https://bugs.webkit.org/show_bug.cgi?id=166855
2964
2965         Reviewed by Andreas Kling.
2966
2967         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2968         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2969         errors with code WebKitErrorCannotShowURL.
2970         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2971         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2972         not specific to WebKit2 error codes.
2973
2974 2017-01-09  Antoine Quint  <graouts@apple.com>
2975
2976         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2977         https://bugs.webkit.org/show_bug.cgi?id=166837
2978
2979         Reviewed by Alex Christensen.
2980
2981         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2982         the provided value when trying to determine the path to the test file. Failing
2983         that, we use the computed URL or the raw path provided to cover all cases.
2984         
2985         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2986         by applying this patch and seeing the number test failures dramatically reduced
2987         with WK1 due to the option to turn modern media controls off for older media controls
2988         tests.
2989
2990         * DumpRenderTree/DumpRenderTree.h:
2991         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2992         (parseInputLine):
2993         * DumpRenderTree/TestOptions.h:
2994         * DumpRenderTree/TestOptions.mm:
2995         (TestOptions::TestOptions):
2996         * DumpRenderTree/mac/DumpRenderTree.mm:
2997         (runTest):
2998
2999 2017-01-09  Milan Crha  <mcrha@redhat.com>
3000
3001         prepare-ChangeLog: Correct help string for --style option
3002         https://bugs.webkit.org/show_bug.cgi?id=166725
3003
3004         Reviewed by Alexey Proskuryakov.
3005
3006         * Scripts/prepare-ChangeLog:
3007         (main):
3008
3009 2017-01-09  Lucas Forschler  <lforschler@apple.com>
3010
3011         https://bugs.webkit.org/show_bug.cgi?id=166839
3012         Add php7 support for macOS.
3013         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
3014
3015         Reviewed by Alexey Proskuryakov.
3016
3017         * Scripts/webkitpy/port/base.py:
3018         (Port._is_darwin_php_version_7):
3019         (Port._debian_php_version):
3020         (Port):
3021         (Port._darwin_php_version):
3022         (Port._apache_config_file_name_for_platform):
3023
3024 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3025
3026         [GTK] Should support key and code properties on keyboard events
3027         https://bugs.webkit.org/show_bug.cgi?id=166759
3028
3029         Reviewed by Carlos Garcia Campos.
3030
3031         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3032         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
3033         on tests.
3034
3035 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
3036
3037         [Win] Some tests are flaky because certain DLLs are writing to stdout.
3038         https://bugs.webkit.org/show_bug.cgi?id=166760
3039
3040         Reviewed by Darin Adler.
3041
3042         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
3043         We can work around that by duplicating and redirecting stdout.
3044
3045         * DumpRenderTree/PixelDumpSupport.cpp:
3046         (dumpWebViewAsPixelsAndCompareWithExpected):
3047         (printPNG):
3048         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3049         (logEventProc):
3050         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3051         (DRTDesktopNotificationPresenter::showDesktopNotification):
3052         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
3053         (DRTDesktopNotificationPresenter::requestNotificationPermission):
3054         * DumpRenderTree/win/DumpRenderTree.cpp:
3055         (dumpFrameScrollPosition):
3056         (dumpHistoryItem):
3057         (dumpBackForwardList):
3058         (dump):
3059         (runTest):
3060         (main):
3061         * DumpRenderTree/win/DumpRenderTreeWin.h:
3062         * DumpRenderTree/win/EditingDelegate.cpp:
3063         (EditingDelegate::shouldBeginEditingInDOMRange):
3064         (EditingDelegate::shouldEndEditingInDOMRange):
3065         (EditingDelegate::shouldInsertNode):
3066         (EditingDelegate::shouldInsertText):
3067         (EditingDelegate::shouldDeleteDOMRange):
3068         (EditingDelegate::shouldChangeSelectedDOMRange):
3069         (EditingDelegate::shouldApplyStyle):
3070         (EditingDelegate::shouldChangeTypingStyle):
3071         (EditingDelegate::doPlatformCommand):
3072         (EditingDelegate::webViewDidBeginEditing):
3073         (EditingDelegate::webViewDidChange):
3074         (EditingDelegate::webViewDidEndEditing):
3075         (EditingDelegate::webViewDidChangeTypingStyle):
3076         (EditingDelegate::webViewDidChangeSelection):
3077         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3078         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3079         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
3080         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
3081         (FrameLoadDelegate::didFailProvisionalLoadWithError):
3082         (FrameLoadDelegate::didCommitLoadForFrame):
3083         (FrameLoadDelegate::didReceiveTitle):
3084         (FrameLoadDelegate::didFinishLoadForFrame):
3085         (FrameLoadDelegate::didFailLoadWithError):
3086         (FrameLoadDelegate::willPerformClientRedirectToURL):
3087         (FrameLoadDelegate::didCancelClientRedirectForFrame):
3088         (FrameLoadDelegate::windowScriptObjectAvailable):
3089         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3090         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
3091         (FrameLoadDelegate::didDisplayInsecureContent):
3092         (FrameLoadDelegate::didRunInsecureContent):
3093         (FrameLoadDelegate::webViewProgressFinishedNotification):
3094         * DumpRenderTree/win/HistoryDelegate.cpp:
3095         (HistoryDelegate::didNavigateWithNavigationData):
3096         (HistoryDelegate::didPerformClientRedirectFromURL):
3097         (HistoryDelegate::didPerformServerRedirectFromURL):
3098         (HistoryDelegate::updateHistoryTitle):
3099         (HistoryDelegate::populateVisitedLinksForWebView):
3100         * DumpRenderTree/win/PolicyDelegate.cpp:
3101         (PolicyDelegate::decidePolicyForNavigationAction):
3102         (PolicyDelegate::unableToImplementPolicyWithError):
3103         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3104         (ResourceLoadDelegate::willSendRequest):
3105         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3106         (ResourceLoadDelegate::didReceiveResponse):
3107         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3108         (ResourceLoadDelegate::didFailLoadingWithError):
3109         * DumpRenderTree/win/TestRunnerWin.cpp:
3110         (TestRunner::addDisallowedURL):
3111         (TestRunner::originsWithApplicationCache):
3112         (TestRunner::setStorageDatabaseIdleInterval):
3113         (TestRunner::closeIdleLocalStorageDatabases):
3114         (TestRunner::copyDecodedHostName):
3115         (TestRunner::copyEncodedHostName):
3116         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3117         (TestRunner::isGeolocationProviderActive):
3118         (TestRunner::pathToLocalResource):
3119         (TestRunner::setMockDeviceOrientation):
3120         (TestRunner::setMockGeolocationPosition):
3121         (TestRunner::setMockGeolocationPositionUnavailableError):
3122         (TestRunner::setSpatialNavigationEnabled):
3123         (TestRunner::setAutomaticLinkDetectionEnabled):
3124         (TestRunner::isCommandEnabled):
3125         (TestRunner::authenticateSession):
3126         (TestRunner::addChromeInputField):
3127         (TestRunner::removeChromeInputField):
3128         (TestRunner::focusWebView):
3129         (TestRunner::grantWebNotificationPermission):
3130         (TestRunner::denyWebNotificationPermission):
3131         (TestRunner::removeAllWebNotificationPermissions):
3132         (TestRunner::simulateWebNotificationClick):
3133         (TestRunner::imageCountInGeneralPasteboard):
3134         * DumpRenderTree/win/UIDelegate.cpp:
3135         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3136         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3137         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3138         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3139         (UIDelegate::webViewAddMessageToConsole):
3140         (UIDelegate::exceededDatabaseQuota):
3141         (UIDelegate::setStatusText):
3142         (UIDelegate::didPressMissingPluginButton):
3143
3144 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3145
3146         Add a setting to create editable MiniBrowser windows by default
3147         https://bugs.webkit.org/show_bug.cgi?id=166806
3148
3149         Reviewed by Beth Dakin.
3150
3151         * MiniBrowser/mac/AppDelegate.m:
3152         (-[BrowserAppDelegate createBrowserWindowController:]):
3153         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3154         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3155         * MiniBrowser/mac/SettingsController.h:
3156         * MiniBrowser/mac/SettingsController.m:
3157         (-[SettingsController _populateMenu]):
3158         (-[SettingsController validateMenuItem:]):
3159         (-[SettingsController toggleCreateEditorByDefault:]):
3160         (-[SettingsController createEditorByDefault]):
3161         Add a setting and update the key equivalents accordingly.
3162         Also make sure to make the right kind of window on launch.
3163
3164 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3165
3166         Fix the 32-bit build.
3167
3168         * MiniBrowser/mac/BrowserWindowController.h:
3169         * MiniBrowser/mac/BrowserWindowController.m:
3170
3171 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3172
3173         Fix the 32-bit build.
3174
3175         * MiniBrowser/mac/BrowserWindowController.m:
3176
3177 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3178
3179         Make it possible to drop HTML files on the MiniBrowser icon
3180         https://bugs.webkit.org/show_bug.cgi?id=166802
3181
3182         Reviewed by Simon Fraser.
3183
3184         * MiniBrowser/mac/AppDelegate.m:
3185         (-[BrowserAppDelegate application:openFile:]):
3186         * MiniBrowser/mac/Info.plist:
3187         If you're using an editable window, the usual trick of dropping on the
3188         window doesn't work anymore (it makes an <attachment> instead).
3189
3190 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3191
3192         MiniBrowser window gets smaller each time it is instantiated
3193         https://bugs.webkit.org/show_bug.cgi?id=166807
3194
3195         Reviewed by Andy Estes.
3196
3197         * MiniBrowser/mac/BrowserWindowController.m:
3198         (-[BrowserWindowController windowDidLoad]):
3199         * MiniBrowser/mac/BrowserWindow.xib:
3200         Turn on full-window content view support with IB, instead of waiting
3201         until after the views have been loaded. This seems to resolve the
3202         longstanding ever-shrinking-window problem.
3203
3204 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3205
3206         Add indent/outdent items to MiniBrowser's new format menu
3207         https://bugs.webkit.org/show_bug.cgi?id=166805
3208
3209         Reviewed by Dan Bernstein.
3210
3211         * MiniBrowser/mac/MainMenu.xib:
3212
3213 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3214
3215         Add a stock Format menu to MiniBrowser
3216         https://bugs.webkit.org/show_bug.cgi?id=166804
3217
3218         Reviewed by Andy Estes.
3219
3220         * MiniBrowser/mac/MainMenu.xib:
3221         Many of the features automatically work with editable web views.
3222         However, this seems to expose a bug where none of the font-related features
3223         (Cmd-B, for example) work until the first time the font panel is shown,
3224         per process, which will need to be investigated separately.
3225
3226 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3227
3228         Remove unused applicationWillTerminate methods from MiniBrowser
3229         https://bugs.webkit.org/show_bug.cgi?id=166803
3230
3231         Reviewed by Andy Estes.
3232
3233         * MiniBrowser/mac/AppDelegate.m:
3234         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
3235         * MiniBrowser/mac/BrowserWindowController.h:
3236         * MiniBrowser/mac/BrowserWindowController.m:
3237         (-[BrowserWindowController applicationTerminating]): Deleted.
3238         * MiniBrowser/mac/WK1BrowserWindowController.m:
3239         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
3240         * MiniBrowser/mac/WK2BrowserWindowController.m:
3241         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
3242
3243 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3244
3245         Add the ability to create empty contentEditable windows in MiniBrowser
3246         https://bugs.webkit.org/show_bug.cgi?id=166801
3247
3248         Reviewed by Wenson Hsieh.
3249
3250         * MiniBrowser/mac/AppDelegate.h:
3251         * MiniBrowser/mac/AppDelegate.m:
3252         (-[BrowserAppDelegate createBrowserWindowController:]):
3253         (-[BrowserAppDelegate newWindow:]):
3254         (-[BrowserAppDelegate newEditorWindow:]):
3255         (-[BrowserAppDelegate openDocument:]):
3256         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3257         * MiniBrowser/mac/BrowserWindowController.h:
3258         * MiniBrowser/mac/BrowserWindowController.m:
3259         (-[BrowserWindowController loadHTMLString:]):
3260         (-[BrowserWindowController toggleEditable:]):
3261         * MiniBrowser/mac/MainMenu.xib:
3262         * MiniBrowser/mac/WK1BrowserWindowController.m:
3263         (-[WK1BrowserWindowController awakeFromNib]):
3264         (-[WK1BrowserWindowController loadHTMLString:]):
3265         (-[WK1BrowserWindowController validateMenuItem:]):
3266         (-[WK1BrowserWindowController setEditable:]):
3267         (-[WK1BrowserWindowController updateTitle:]):
3268         * MiniBrowser/mac/WK2BrowserWindowController.m:
3269         (-[WK2BrowserWindowController awakeFromNib]):
3270         (-[WK2BrowserWindowController validateMenuItem:]):
3271         (-[WK2BrowserWindowController setEditable:]):
3272         (-[WK2BrowserWindowController updateTitle:]):
3273         (-[WK2BrowserWindowController loadHTMLString:]):
3274         Merge more functionality from WebEditingTester.
3275         Add two menu items for creating empty editable WebKit1/2 windows.
3276         Add a menu item to the Edit menu to toggle editability on any window.
3277
3278 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3279
3280         Implement find-in-page in MiniBrowser
3281         https://bugs.webkit.org/show_bug.cgi?id=166799
3282
3283         Reviewed by Andy Estes.
3284
3285         * MiniBrowser/mac/BrowserWindow.xib:
3286         * MiniBrowser/mac/BrowserWindowController.h:
3287         * MiniBrowser/mac/BrowserWindowController.m:
3288         (-[BrowserWindowController find:]): Deleted.
3289         * MiniBrowser/mac/MainMenu.xib:
3290         * MiniBrowser/mac/WK1BrowserWindowController.m:
3291         (-[WK1BrowserWindowController toggleShrinkToFit:]):
3292         (-[WK1BrowserWindowController find:]): Deleted.
3293         * MiniBrowser/mac/WK2BrowserWindowController.m:
3294         (-[WK2BrowserWindowController awakeFromNib]):
3295         (-[WK2BrowserWindowController dealloc]):
3296         (-[WK2BrowserWindowController validateMenuItem:]):
3297         (-[WK2BrowserWindowController performTextFinderAction:]):
3298         (-[WK2BrowserWindowController findBarView]):
3299         (-[WK2BrowserWindowController setFindBarView:]):
3300         (-[WK2BrowserWindowController isFindBarVisible]):
3301         (-[WK2BrowserWindowController setFindBarVisible:]):
3302         (-[WK2BrowserWindowController contentView]):
3303         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
3304         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
3305         (-[WK2BrowserWindowController find:]): Deleted.
3306         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
3307         protocol. At first glance, it's pretty broken, but vaguely works.
3308
3309 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3310
3311         Share the implementation of MiniBrowser view hiding functionality
3312         https://bugs.webkit.org/show_bug.cgi?id=166800
3313
3314         Reviewed by Andy Estes.
3315
3316         * MiniBrowser/mac/BrowserWindowController.m:
3317         (-[BrowserWindowController showHideWebView:]):
3318         (-[BrowserWindowController removeReinsertWebView:]):
3319         * MiniBrowser/mac/WK1BrowserWindowController.m:
3320         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
3321         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
3322         * MiniBrowser/mac/WK2BrowserWindowController.m:
3323         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
3324         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
3325         Move the implementation of these two things to the shared superclass,
3326         since they don't depend on WebKit-specific things.
3327         Also, there was no reason to retain the (WK)WebView while it was unparented,
3328         as the BrowserWindowController maintains a reference the entire time.
3329
3330 2017-01-06  Andy Estes  <aestes@apple.com>
3331
3332         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
3333         https://bugs.webkit.org/show_bug.cgi?id=166789
3334
3335         Reviewed by Alex Christensen.
3336
3337         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3338         * DumpRenderTree/PlatformMac.cmake:
3339         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
3340         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
3341         * DumpRenderTree/mac/DumpRenderTree.mm:
3342         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3343         createXMLStringFromWebArchiveData().
3344         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
3345         * WebKitTestRunner/Configurations/Base.xcconfig:
3346         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
3347         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3348         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3349         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3350         createXMLStringFromWebArchiveData().
3351         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
3352         * WebKitTestRunner/PlatformMac.cmake:
3353         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3354         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
3355
3356 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3357
3358         Minor cleanups to IndentOutdentCommand and related code
3359         https://bugs.webkit.org/show_bug.cgi?id=166791
3360
3361         Reviewed by Simon Fraser.
3362
3363         * WebEditingTester/EditingOperations.m:
3364         (editingOperations):
3365         Add the outdent operation to WebEditingTester.
3366
3367 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3368
3369         Create a plan and a patch files for MotionMark and delete the Animometer's ones
3370         https://bugs.webkit.org/show_bug.cgi?id=166785
3371
3372         Reviewed by Ryosuke Niwa.
3373
3374         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3375         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
3376
3377 2017-01-06  Antoine Quint  <graouts@apple.com>
3378
3379         Support webkit-test-runner key-value pairs in http tests
3380         https://bugs.webkit.org/show_bug.cgi?id=149812
3381
3382         Reviewed by Alex Christensen.
3383
3384         We pass the absolute path for a test through to WKTR so that we can parse
3385         tests that are running as URLs for webkit-test-runner options.
3386
3387         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3388         (parseInputLine):
3389
3390         Explicitly skip the --absolute-path option in DRT or else we'd crash.
3391
3392         * Scripts/webkitpy/port/driver.py:
3393         (Driver._command_from_driver_input):
3394
3395         Pass the absolute path to the file through the CLI.
3396
3397         * WebKitTestRunner/TestController.cpp:
3398         (WTR::updateTestOptionsFromTestHeader):
3399         (WTR::TestController::testOptionsForTest):
3400         (WTR::parseInputLine):
3401         (WTR::TestController::runTest):
3402         * WebKitTestRunner/TestController.h:
3403
3404 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3405
3406         Warning about unconnectable outlets when opening a MiniBrowser window
3407         https://bugs.webkit.org/show_bug.cgi?id=166756
3408
3409         Reviewed by Dan Bernstein.
3410
3411         * MiniBrowser/mac/BrowserWindow.xib:
3412         When launching MiniBrowser, it says:
3413         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
3414             (MBToolbarItem): missing setter or instance variable
3415         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
3416             (NSButtonCell): missing setter or instance variable.
3417
3418         It looks like someone added the connection from the share button
3419         to the BrowserWindowController three times; only one of the connections
3420         is valid. Remove the other two.
3421
3422 2017-01-05  Keith Rollin  <krollin@apple.com>
3423
3424         Add WebCore::URL::protocolHostAndPort
3425         https://bugs.webkit.org/show_bug.cgi?id=166426
3426
3427         Reviewed by Alex Christensen.
3428
3429         Add test for protocolHostAndPort.
3430
3431         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3432         (TestWebKitAPI::TEST_F):
3433
3434 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
3435
3436         [Win] Archive test result is failing.
3437         https://bugs.webkit.org/show_bug.cgi?id=166720
3438
3439         Reviewed by Alex Christensen.
3440
3441         Deleting the layout test result folder is sometimes failing
3442         on Windows. This is not a critical error.
3443
3444         * BuildSlaveSupport/test-result-archive:
3445         (archiveTestResults):
3446
3447 2017-01-04  Tomas Popela  <tpopela@redhat.com>
3448
3449         [GTK] Minibrowser: Add printing support
3450         https://bugs.webkit.org/show_bug.cgi?id=165298
3451
3452         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
3453         an error during the print, it's printed on the console.
3454
3455         Reviewed by Michael Catanzaro.
3456
3457         * MiniBrowser/gtk/BrowserWindow.c:
3458         (webKitPrintOperationFailedCallback):
3459         (printPage):
3460         (browser_window_init):
3461
3462 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
3463
3464         [css-grid] Fix crash clamping grid lines
3465         https://bugs.webkit.org/show_bug.cgi?id=166637
3466
3467         Reviewed by Darin Adler.
3468
3469         Creates new unit test to verify that the maximum tracks limit
3470         is used in GridPosition too.
3471
3472         * TestWebKitAPI/PlatformEfl.cmake:
3473         * TestWebKitAPI/PlatformGTK.cmake:
3474         * TestWebKitAPI/PlatformWin.cmake:
3475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3476         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
3477         (TestWebKitAPI::TEST):
3478
3479 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3480
3481         Move editing history scripts to WebCore PrivateHeaders
3482         https://bugs.webkit.org/show_bug.cgi?id=166709
3483         <rdar://problem/29876612>
3484
3485         Reviewed by Dan Bernstein.
3486
3487         Update references to editing script files in WebCore that were moved.
3488
3489         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
3490
3491 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3492
3493         Unreviewed, build fix after r210313 part 2
3494         https://bugs.webkit.org/show_bug.cgi?id=166676
3495
3496         Add 'U' suffix.
3497
3498         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3499         (TestWebKitAPI::TEST):
3500         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3501         (TestWebKitAPI::TEST):
3502
3503 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3504
3505         Limit thread name appropriately
3506         https://bugs.webkit.org/show_bug.cgi?id=166676
3507
3508         Reviewed by Sam Weinig.
3509
3510         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3511         (TestWebKitAPI::TEST):
3512         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3513         (TestWebKitAPI::TEST):
3514
3515 2017-01-04  Andy Estes  <aestes@apple.com>
3516
3517         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
3518         https://bugs.webkit.org/show_bug.cgi?id=166696
3519
3520         Reviewed by Tim Horton.
3521
3522         * TestWebKitAPI/PlatformGTK.cmake:
3523         * TestWebKitAPI/PlatformWin.cmake:
3524         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3525         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
3526         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
3527         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
3528         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
3529         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
3530         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
3531
3532 2017-01-03  Brian Burg  <bburg@apple.com>
3533
3534         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
3535         https://bugs.webkit.org/show_bug.cgi?id=166003
3536         <rdar://problem/28718990>
3537
3538         Reviewed by Joseph Pecoraro.
3539
3540         Teach run-inspector-generator-tests to generate test output using the platform name
3541         derived from the directory that the test is in. For example, tests in the /generic/
3542         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
3543
3544         * Scripts/webkitpy/inspector/main.py:
3545         (InspectorGeneratorTests.generate_from_json):
3546         (InspectorGeneratorTests.run_tests):
3547         (InspectorGeneratorTests.main):
3548
3549 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3550
3551         Unreviewed cmake buildfix after r210266.
3552
3553         * DumpRenderTree/PlatformMac.cmake:
3554
3555 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3556
3557         Provide a setting for clients to always prefer low-power WebGL
3558         https://bugs.webkit.org/show_bug.cgi?id=166675
3559         <rdar://problem/29834093>
3560
3561         Reviewed by Dan Bernstein.
3562
3563         * MiniBrowser/mac/Info.plist:
3564         Have MiniBrowser claim to be a modern app that supports
3565         automatic graphics switching. WebKit needs to support automatic
3566         graphics switching, so our test app might as well. Without this
3567         Info.plist parameter, this change has no effect, and bringing up
3568         a WebGL context still brings up the discrete GPU (also true of the
3569         existing web-exposed preferLowPowerToHighPerformance API).
3570
3571 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3572
3573         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
3574         https://bugs.webkit.org/show_bug.cgi?id=166645
3575
3576         Reviewed by Carlos Garcia Campos.
3577
3578         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3579         (TestWebKitAPI::TEST):
3580
3581 2017-01-03  Andy Estes  <aestes@apple.com>
3582
3583         Place all the Cocoa WebCore API tests in the same directory
3584         https://bugs.webkit.org/show_bug.cgi?id=166673
3585
3586         Reviewed by Michael Catanzaro.
3587
3588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3589         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
3590         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
3591         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
3592
3593 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3594
3595         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3596         https://bugs.webkit.org/show_bug.cgi?id=166450
3597         <rdar://problem/29447824>
3598
3599         Reviewed by Darin Adler.
3600
3601         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3602         * DumpRenderTree/TestRunner.cpp:
3603         (TestRunner::staticFunctions):
3604         * DumpRenderTree/mac/TestRunnerMac.mm:
3605         (setSpellCheckerLoggingEnabledCallback):
3606         * DumpRenderTree/win/TestRunnerWin.cpp:
3607         (setSpellCheckerLoggingEnabledCallback):
3608         * DumpRenderTree/mac/DumpRenderTree.mm:
3609         (resetWebViewToConsistentStateBeforeTesting):
3610         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
3611         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
3612         (stringForCorrectionResponse):
3613         (drt_NSSpellChecker_recordResponseToCorrection):
3614         (swizzleNSSpellCheckerMethodsIfNeeded):
3615         (setSpellCheckerLoggingEnabled):
3616         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
3617         set to true, logs to stdout (which ends up in the test result) whenever
3618         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3619         is called, and then calls the original method. It is reset to false between tests.
3620
3621 2017-01-03  Sam Weinig  <sam@webkit.org>
3622
3623         Make WTF::Expected support Ref template parameters
3624         https://bugs.webkit.org/show_bug.cgi?id=166662
3625
3626         Reviewed by Alex Christensen.
3627
3628         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3629         (TestWebKitAPI::TEST):
3630         Add tests for using Ref with Expected.
3631
3632 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3633
3634         [GTK] Expose WebKitSecurityOrigin API
3635         https://bugs.webkit.org/show_bug.cgi?id=166632
3636
3637         Reviewed by Carlos Garcia Campos.
3638
3639         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3640         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
3641         (testSecurityOriginBasicConstructor):
3642         (testSecurityOriginURIConstructor):
3643         (testSecurityOriginDefaultPort):
3644         (testSecurityOriginFileURI):
3645         (testSecurityOriginDataURI):
3646         (beforeAll):
3647         (afterAll):
3648
3649 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3650
3651         [GTK] HTTP auth layout tests are flaky
3652         https://bugs.webkit.org/show_bug.cgi?id=158919
3653
3654         Reviewed by Michael Catanzaro.
3655
3656         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
3657         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
3658         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
3659         missing valac in the bots.
3660
3661 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3662
3663         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
3664         https://bugs.webkit.org/show_bug.cgi?id=165797
3665
3666         Reviewed by Michael Catanzaro.
3667
3668         Move directory ruleset after all exclude rules of Source rulset.
3669
3670         * gtk/manifest.txt.in:
3671
3672 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3673
3674         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
3675         https://bugs.webkit.org/show_bug.cgi?id=166636
3676
3677         Reviewed by Darin Adler.
3678
3679         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3680         (TestWebKitAPI::TEST):
3681
3682 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
3683
3684         [GTK] WebCore/CSSParser unit test is not being built
3685         https://bugs.webkit.org/show_bug.cgi?id=166492
3686
3687         Reviewed by Michael Catanzaro.
3688
3689         This test was introduced in r175930, but we were not building
3690         it on GTK+ port since r176015.
3691         This patch marks the test to be built again on GTK+.
3692         JFTR, the test is passing right now.
3693
3694         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
3695         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
3696
3697 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
3698
3699         AX: Expose block quote level to iOS API
3700         https://bugs.webkit.org/show_bug.cgi?id=166629
3701         <rdar://problem/29834793>
3702
3703         Reviewed by Darin Adler.
3704
3705         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3706         (AccessibilityUIElement::numberAttributeValue):
3707         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3708         (WTR::AccessibilityUIElement::numberAttributeValue):
3709
3710 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
3711
3712         SecurityOrigin::create triplet constructor does not canonicalize port
3713         https://bugs.webkit.org/show_bug.cgi?id=166624
3714
3715         Reviewed by Daniel Bates.
3716
3717         * TestWebKitAPI/PlatformGTK.cmake:
3718         * TestWebKitAPI/PlatformWin.cmake:
3719         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3720         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
3721         (TestWebKitAPI::SecurityOriginTest::SetUp):
3722         (TestWebKitAPI::TEST_F):
3723
3724 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3725
3726         [GTK] Improve user agent construction
3727         https://bugs.webkit.org/show_bug.cgi?id=142074
3728
3729         Reviewed by Carlos Garcia Campos.
3730
3731         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3732         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3733         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3734         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3735         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3736         (TestWebKitAPI::TEST):
3737
3738 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3739
3740         [GTK] Improve user agent construction
3741         https://bugs.webkit.org/show_bug.cgi?id=142074
3742
3743         Reviewed by Carlos Garcia Campos.
3744
3745         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3746         (TestWebKitAPI::TEST):
3747
3748 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
3749
3750         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
3751         https://bugs.webkit.org/show_bug.cgi?id=166472
3752         rdar://problem/29675551
3753
3754         Reviewed by Tim Horton.
3755
3756         These changes are necessary to allow the mouse to leave the WTR window while
3757         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
3758         (which DRT does); we'd always go through mouseMoved, which hits an early return
3759         in WebViewImpl::mouseMoved() when the point is outside the view.
3760
3761         * WebKitTestRunner/mac/EventSenderProxy.mm:
3762         (WTR::EventSenderProxy::mouseMoveTo):
3763
3764 2016-12-23  Andy Estes  <aestes@apple.com>
3765
3766         [iOS] Fix some crashing webarchive tests
3767         https://bugs.webkit.org/show_bug.cgi?id=166470
3768
3769         Reviewed by Andreas Kling.
3770
3771         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
3772         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
3773         so this change uses that on both platforms.
3774
3775         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
3776         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
3777         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
3778         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
3779         * WebKitTestRunner/PlatformMac.cmake:
3780         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3781         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3782
3783 2016-12-22  Saam Barati  <sbarati@apple.com>
3784
3785         WebAssembly: Silence the output of the spec-tests
3786         https://bugs.webkit.org/show_bug.cgi?id=166417
3787
3788         Reviewed by Mark Lam.
3789
3790         * Scripts/run-jsc-stress-tests:
3791
3792 2016-12-22  Zhuo Li  <zachli@apple.com>
3793
3794         [Cocoa] SPI for setloadsImagesAutomatically.
3795         https://bugs.webkit.org/show_bug.cgi?id=166401.
3796
3797         Reviewed by Darin Adler.
3798
3799         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3800         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3801         _loadsImagesAutomatically returns YES.
3802
3803 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3804
3805         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3806         https://bugs.webkit.org/show_bug.cgi?id=161328
3807         <rdar://problem/28475977>
3808
3809         Reviewed by Darin Adler.
3810
3811         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3812         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3813         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3814         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3815         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3816         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3817         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3818         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3819         we finish running a test and before we load the next test.
3820
3821         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3822         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3823         previous test started zooming and then finished before zooming completed. Since this happens before the next
3824         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3825
3826         * WebKitTestRunner/ios/TestControllerIOS.mm:
3827         (WTR::TestController::platformResetStateToConsistentValues):
3828
3829 2016-12-22  Jer Noble  <jer.noble@apple.com>
3830
3831         Muted media element playback should not interrupt other audio playback
3832         https://bugs.webkit.org/show_bug.cgi?id=166347
3833
3834         Reviewed by Eric Carlson.
3835
3836         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3837         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3838         (TestWebKitAPI::TEST):
3839         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3840
3841 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3842
3843         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3844         https://bugs.webkit.org/show_bug.cgi?id=166346
3845
3846         Reviewed by Carlos Garcia Campos.
3847
3848         Enable WebRTC by default to simplify testing.
3849
3850         * MiniBrowser/gtk/main.c:
3851         (main):
3852
3853 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3854
3855         REGRESSION: API test failure: WKWebView.LocalStorageClear
3856         https://bugs.webkit.org/show_bug.cgi?id=166032
3857         <rdar://problem/29758423>
3858
3859         Reviewed by Simon Fraser.
3860
3861         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3862         to ensure that the view is destroyed before the callback fires.
3863
3864         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3865         (TEST):
3866
3867 2016-12-21  Saam Barati  <sbarati@apple.com>
3868
3869         WebAssembly: Import spec tests
3870         https://bugs.webkit.org/show_bug.cgi?id=166395
3871
3872         Rubber stamped by Keith Miller.
3873
3874         * Scripts/run-jsc-stress-tests:
3875
3876 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3877
3878         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3879         https://bugs.webkit.org/show_bug.cgi?id=166033
3880         <rdar://problem/29758428>
3881
3882         Reviewed by Simon Fraser.
3883
3884         Add an @autoreleasepool around the code that allocates the WKWebView, 
3885         so that it can be destroyed by removing the last reference in _downloadDidStart.
3886
3887         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3888         (TEST):
3889
3890 2016-12-21  Daniel Bates  <dabates@apple.com>
3891
3892         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3893         https://bugs.webkit.org/show_bug.cgi?id=166356
3894
3895         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3896         as a means to allow a test to explicit allow an embedding client to open a new windows
3897         such that the default behavior is for the embedding client to forbid such an action.
3898         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3899         it is currently skipped on WebKit2 because questions were raised in the patch for
3900         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3901         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3902         this test.
3903
3904         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3905         (WTR::TestRunner::setCanOpenWindows):
3906
3907 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3908
3909         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3910         https://bugs.webkit.org/show_bug.cgi?id=166031
3911
3912         Reviewed by Tim Horton.
3913         
3914         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3915         to ensure that the view is destroyed before the callback fires.
3916
3917         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3918
3919 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3920
3921         Throw Exception when test doesn't clean up HID Events properly
3922         https://bugs.webkit.org/show_bug.cgi?id=166271
3923
3924         Reviewed by Simon Fraser.
3925
3926         Add in a check when UIScriptController is deleted to make sure that the HID event
3927         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3928         the program to crash without any good information. Crashes are race-y, and will still
3929         happen with malformed test, but the information will be much more helpful. 
3930
3931         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3932         (WTR::UIScriptController::checkForClean):
3933         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3934         (UIScriptContext::~UIScriptContext):
3935         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3936         (WTR::UIScriptController::checkForClean):
3937         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3938         * WebKitTestRunner/ios/HIDEventGenerator.h:
3939         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3940         (-[HIDEventGenerator checkHIDCallbacksClear]):
3941         * WebKitTestRunner/ios/TestControllerIOS.mm:
3942         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3943         (WTR::UIScriptController::checkForClean):
3944
3945 2016-12-20  Andy Estes  <aestes@apple.com>
3946
3947         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3948         https://bugs.webkit.org/show_bug.cgi?id=165992
3949
3950         Reviewed by Brady Eidson.
3951
3952         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3953         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3954         (expectException):
3955         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3956         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3957         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3958         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3959         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3960         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3961         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3962         (TEST):
3963         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3964
3965 2016-12-20  Dean Jackson  <dino@apple.com>
3966
3967         Remove INDIE_UI
3968         https://bugs.webkit.org/show_bug.cgi?id=165881
3969         <rdar://problem/29672532>
3970
3971         Reviewed by Simon Fraser.
3972
3973         The Indie UI work has been discontinued.
3974
3975         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3976
3977 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3978
3979         [ES6] Enable ES6 Modules
3980         https://bugs.webkit.org/show_bug.cgi?id=165849
3981
3982         Reviewed by Geoffrey Garen.
3983
3984         * DumpRenderTree/mac/DumpRenderTree.mm:
3985         (resetWebPreferencesToConsistentValues):
3986         * DumpRenderTree/win/DumpRenderTree.cpp:
3987         (resetWebPreferencesToConsistentValues):
3988         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3989         (WTR::InjectedBundle::beginTesting):
3990         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3991         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3992         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3993
3994 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3995
3996         Repurpose bots and clean up dashboard.
3997         https://bugs.webkit.org/show_bug.cgi?id=166045
3998
3999         Reviewed by Lucas Forschler.
4000
4001         * BuildSlaveSupport/build.webkit.org-config/config.json:
4002         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4003         (BubbleQueueServer):
4004         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4005         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4006         (WebKitBuildbot):
4007         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4008         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
4009
4010 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
4011
4012         [CMake] TestWebKitAPIBase links to itself
4013         https://bugs.webkit.org/show_bug.cgi?id=165985
4014
4015         Reviewed by Alex Christensen.
4016
4017         Fix CMake warning about a target linking to itself, which makes no sense.
4018
4019         * TestWebKitAPI/CMakeLists.txt:
4020
4021 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
4022
4023         [GTK] GtkDoc build should be quieter
4024         https://bugs.webkit.org/show_bug.cgi?id=165994
4025
4026         Reviewed by Carlos Garcia Campos.
4027
4028         Make it not print by default.
4029
4030         * gtk/generate-gtkdoc:
4031         (get_generator_for_config):
4032         (generate_doc):
4033         * gtk/gtkdoc.py:
4034         (GTKDoc._run_command):
4035         (GTKDoc._copy_doc_files_to_output_dir):
4036
4037 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
4038
4039         Expose a way for MiniBrowser to simulate header and footer banners
4040         https://bugs.webkit.org/show_bug.cgi?id=166005
4041
4042         Reviewed by Wenson Hsieh.
4043         
4044         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
4045         banners. This only works in WebKit2.
4046         
4047         We need to reset these on each navigation, since newly created FrameViews
4048         don't re-fetch the header and footer height stored on Page.
4049         
4050         Also fix the signature of webView:didFinishNavigation: to follow API changes,
4051         as well as fixing webViewWebContentProcessDidTerminate:
4052
4053         * MiniBrowser/mac/SettingsController.h:
4054         * MiniBrowser/mac/SettingsController.m:
4055         (-[SettingsController _populateMenu]):
4056         (-[SettingsController validateMenuItem:]):
4057         (-[SettingsController toggleReserveSpaceForBanners:]):
4058         (-[SettingsController isSpaceReservedForBanners]):
4059         * MiniBrowser/mac/WK2BrowserWindowController.m:
4060         (-[WK2BrowserWindowController didChangeSettings]):
4061         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
4062         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
4063         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
4064         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
4065
4066 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
4067
4068         Fix iOS test results after r209967.
4069         
4070         Subtracting out the status bar height was erroneously happening for all tests,
4071         not just for flexible viewport tests.
4072         
4073         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
4074
4075         * WebKitTestRunner/PlatformWebView.h:
4076         * WebKitTestRunner/TestController.cpp:
4077         (WTR::TestController::resetStateToConsistentValues):
4078         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4079         (WTR::PlatformWebView::resizeTo):
4080         (WTR::PlatformWebView::setWindowFrame):
4081         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4082         (WTR::PlatformWebView::resizeTo):
4083         (WTR::PlatformWebView::setWindowFrame):
4084         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4085         (WTR::PlatformWebView::resizeTo):
4086         (WTR::PlatformWebView::setWindowFrame):
4087         * WebKitTestRunner/ios/TestControllerIOS.mm:
4088         (WTR::TestController::platformConfigureViewForTest):
4089         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4090         (WTR::PlatformWebView::resizeTo):
4091         (WTR::PlatformWebView::setWindowFrame):
4092
4093 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
4094
4095         [EFL] bump EFL version to 1.18.4
4096         https://bugs.webkit.org/show_bug.cgi?id=166004
4097
4098         Reviewed by Gyuyoung Kim.
4099
4100         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
4101
4102 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
4103
4104         Visual viewports: bottom fixed elements disappear behind the keyboard
4105         https://bugs.webkit.org/show_bug.cgi?id=165983
4106         <rdar://problem/29409852>
4107
4108         Reviewed by Simon Fraser.
4109
4110         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
4111         the keyboard when it is up.
4112
4113         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4114         (WTR::UIScriptController::inputViewBounds):
4115         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4116         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4117         (WTR::UIScriptController::inputViewBounds):
4118         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4119         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4120         (WTR::viewRectForWindowRect):
4121
4122         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
4123         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
4124         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
4125
4126         (WTR::PlatformWebView::PlatformWebView):
4127         (WTR::PlatformWebView::setWindowFrame):
4128         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4129         (WTR::UIScriptController::inputViewBounds):
4130
4131 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
4132
4133         Deleting a character converted from pinyin after an image causes a Safari crash
4134         https://bugs.webkit.org/show_bug.cgi?id=165839
4135         <rdar://problem/27951933>
4136
4137         Reviewed by Wenson Hsieh.
4138
4139         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
4140         while the proposed range contains an image. This should not cause a WebProcess to crash
4141         or send an invalid message to the UIProcess.
4142
4143         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4144         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
4145         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
4146         (TestWebKitAPI::didFinishLoadForFrame):
4147         (TestWebKitAPI::processDidCrash):
4148         (TestWebKitAPI::invalidMessageFunction):
4149         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
4150
4151 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
4152
4153         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
4154         https://bugs.webkit.org/show_bug.cgi?id=165767
4155         <rdar://problem/29602382>
4156
4157         Reviewed by Simon Fraser.
4158
4159         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
4160         WebKit2 ChangeLog for more details.
4161
4162         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4163         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4164         (WTR::UIScriptController::textSelectionCaretRect):
4165         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4166         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4167         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4168         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4169         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4170         (WTR::UIScriptController::textSelectionCaretRect):
4171         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4172         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4173         (-[TestRunnerWKWebView _setStableStateOverride:]):
4174
4175         Force the WKWebView to update its visible content rects when changing the stable state override.
4176
4177         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4178         (WTR::toNSDictionary):
4179         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4180         (WTR::UIScriptController::selectionRangeViewRects):
4181         (WTR::UIScriptController::textSelectionCaretRect):
4182         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4183         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4184
4185 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
4186
4187         Arguments called in wrong order
4188         https://bugs.webkit.org/show_bug.cgi?id=165923
4189
4190         Reviewed by Simon Fraser.
4191
4192         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
4193         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
4194
4195         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
4196         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
4197         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
4198
4199 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
4200
4201         [EFL] Disable non-srcdir builds for failing libraries
4202         https://bugs.webkit.org/show_bug.cgi?id=165896
4203
4204         Reviewed by Gyuyoung Kim.
4205
4206         * efl/jhbuild.modules: Set non srcdir builds to no
4207
4208 2016-12-15  Daniel Bates  <dabates@apple.com>
4209
4210         check-style should not complain about code in icu directories
4211         https://bugs.webkit.org/show_bug.cgi?id=53929
4212
4213         Reviewed by Darin Adler.
4214
4215         Skip style checking of imported ICU headers to avoid a deluge of style issues
4216         as they do not conform to the WebKit Code Style guideline. We want to preserve
4217         the formatting of these headers so as to make it straightforward to merge
4218         changes to them, if necessary.
4219
4220         * Scripts/webkitpy/style/checker.py:
4221
4222 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
4223
4224         Move JSC testers from Yosemite to Sierra
4225         https://bugs.webkit.org/show_bug.cgi?id=165925
4226
4227         Reviewed by Lucas Forschler.
4228
4229         * BuildSlaveSupport/build.webkit.org-config/config.json:
4230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4231         (WebKitBuildbot):
4232
4233 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
4234
4235         Add coordinate space to event streams and streamline tests
4236         https://bugs.webkit.org/show_bug.cgi?id=165119
4237
4238         Reviewed by Simon Fraser.
4239
4240         Update event streams to allow for both content and global coordinate space.
4241         Update example script to more accurately show all the available options.
4242
4243         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4244         * WebKitTestRunner/ios/HIDEventGenerator.h:
4245         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4246         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4247         (WTR::convertCoordinates):
4248         (WTR::UIScriptController::sendEventStream):
4249
4250 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
4251
4252         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
4253         https://bugs.webkit.org/show_bug.cgi?id=165855
4254
4255         Reviewed by Philippe Normand.
4256
4257         GStreamer's autogen.sh enables gtk-doc always so we end up building
4258         docs even if we disable them. Use the configure script instead, since
4259         we build from packages and these include it already.
4260
4261         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
4262         upstream gstreamer packages.
4263
4264 2016-12-15  Alex Christensen  <achristensen@webkit.org>
4265
4266         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
4267         https://bugs.webkit.org/show_bug.cgi?id=165885
4268         <rdar://problem/29476917>
4269
4270         Reviewed by Darin Adler.
4271
4272         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4273         (TestWebKitAPI::utf16String): Deleted.
4274         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
4275         (TestWebKitAPI::TEST_F):
4276         * TestWebKitAPI/WTFStringUtilities.h:
4277         (utf16String):
4278         Moved from URLParser to share with other tests.
4279
4280 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
4281
4282         iOS: An element with tabindex is not focusable unless there is no mouse event handler
4283         https://bugs.webkit.org/show_bug.cgi?id=165843
4284
4285         Reviewed by Antti Koivisto.
4286
4287         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
4288         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
4289         and DumpRenderTree's runUIScript would hit an assertion :(
4290
4291         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4292         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4293         (WTR::TestRunner::isWebKit2):
4294
4295 2016-12-14  Brady Eidson  <beidson@apple.com>
4296
4297         IndexedDB 2.0: Massively speedup IDBIndex.get().
4298         https://bugs.webkit.org/show_bug.cgi?id=165802
4299
4300         Reviewed by Alex Christensen.
4301
4302         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4303         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
4304         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
4305         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
4306         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
4307
4308 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4309
4310         [GTK][EFL] Update the JHBuild version.
4311         https://bugs.webkit.org/show_bug.cgi?id=165838
4312
4313         Reviewed by Michael Catanzaro.
4314
4315         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the