Remove the rebaseline queue server since nobody except maybe one person from Google...
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
4
5         Rubber stamped by Benjamin Poulain.
6
7         * RebaselineQueueServer: Removed.
8         * RebaselineQueueServer/app.yaml: Removed.
9         * RebaselineQueueServer/handlers: Removed.
10         * RebaselineQueueServer/handlers/__init__.py: Removed.
11         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
12         * RebaselineQueueServer/handlers/pages.py: Removed.
13         * RebaselineQueueServer/index.yaml: Removed.
14         * RebaselineQueueServer/main.py: Removed.
15         * RebaselineQueueServer/model: Removed.
16         * RebaselineQueueServer/model/__init__.py: Removed.
17         * RebaselineQueueServer/model/queueentry.py: Removed.
18         * RebaselineQueueServer/static: Removed.
19         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
20         * RebaselineQueueServer/static/styles.css: Removed.
21         * RebaselineQueueServer/templates: Removed.
22         * RebaselineQueueServer/templates/builder-picker.html: Removed.
23         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
24         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
25         * RebaselineQueueServer/templates/home.html: Removed.
26
27 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
28
29         Fix setup-commit-queue and temporarily disable testing on commit-queue
30         https://bugs.webkit.org/show_bug.cgi?id=113979
31
32         Reviewed by Benjamin Poulain.
33
34         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
35         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
36
37         * EWSTools/setup-commit-queue.sh:
38         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
39         (CommitQueueTask.run):
40
41 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
42
43         temporarily make flakiness dashboard work again webkit.org bots
44         https://bugs.webkit.org/show_bug.cgi?id=113972
45
46         Reviewed by Ojan Vafai.
47
48         This patch disables the chromium.org layout test bots TestExpectations
49         parsing temporarily until we can work out the right way to split into
50         two instances for webkit.org and chromium.org and figure out which
51         code to delete where :).
52
53         * TestResultServer/static-dashboards/flakiness_dashboard.js:
54
55 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
56
57         Fix webkitpy tests after r147678.
58
59         * Scripts/webkitpy/tool/commands/queues_unittest.py:
60         (CommitQueueTest.test_commit_queue):
61         (test_manual_reject_during_processing):
62
63 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
64
65         The commit queue should use Mac MountainLion port
66         https://bugs.webkit.org/show_bug.cgi?id=113971
67
68         Reviewed by Lucas Forschler.
69
70         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
71         * Scripts/webkitpy/tool/commands/queues.py:
72         (CommitQueue):
73
74 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
75
76         turn off running tests on chromium linux EWS bots
77         https://bugs.webkit.org/show_bug.cgi?id=113959
78
79         Reviewed by Geoffrey Garen.
80
81         Now that the Chromium port is no longer being maintained
82         there's little point in running the tests. Soon we should
83         just shut this bot off altogether.
84
85         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
86         (ChromiumLinuxEWS):
87
88 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
89
90         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
91
92         * Scripts/webkitpy/common/config/watchlist:
93
94 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
95
96         Indentation fix to get webkit-patch working again after r147625
97
98         Unreviewed.
99
100         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
101         (MacEWS):
102         (MacWK2EWS):
103
104 2013-04-04  Lucas Forschler  <lforschler@apple.com>
105
106         Turn tests back on for Mac WK1/WK2 EWS.
107         
108         Unreviewed.
109         
110         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
111         (MacEWS):
112         (MacWK2EWS):
113
114 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
115
116         [GTK][WK2] MiniBrowser custom URI scheme support
117         https://bugs.webkit.org/show_bug.cgi?id=112419
118
119         Reviewed by Carlos Garcia Campos.
120
121         Add support for about URIs in MiniBrowser. An example about page is show
122         with URI "about:minibrowser", the rest of the cases it will show a
123         proper message explaining that the about page didn't exist.
124
125         Internally it uses "minibrowser-about" prefix instead of "about", but
126         from the user point of view it works with "about" prefix.
127
128         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
129         (getInternalURI): Method to convert URIs from "about" prefix to
130         "minibrowser-about".
131         (getExternalURI): Opposite method.
132         (webViewURIChanged): Use "about" prefix to show the URI to users.
133         (webViewEnterFullScreen): Ditto.
134         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
135         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
136         (aboutURISchemeRequestCallback): Callback to manage about calls.
137         (main): Register the URI scheme to manage about URIs.
138
139 2013-04-03  Roger Fong  <roger_fong@apple.com>
140
141         Re-enable WinEWS tests.
142
143         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
144         (WinEWS):
145
146 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
147
148         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
149         https://bugs.webkit.org/show_bug.cgi?id=113883
150
151         Reviewed by Martin Robinson.
152
153         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
154         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
155         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
156
157 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
158
159         [GTK] Include Pango in jhbuild-optional.modules
160         https://bugs.webkit.org/show_bug.cgi?id=113878
161
162         Reviewed by Martin Robinson.
163
164         Since r147547 Pango 1.32.0 is required. Including the module in the
165         JHBuild optional moduleset.
166
167         * gtk/jhbuild-optional.modules: Add Pango module.
168
169 2013-04-03  Zeno Albisser  <zeno@webkit.org>
170
171         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
172         https://bugs.webkit.org/show_bug.cgi?id=113864
173
174         Moving setDefersLoading from TestRunnerQt to TestRunner
175         requires access to the non-Qt TestRunner.
176         As long as we instantiate both TestRunner and TestRunnerQt,
177         we need a separate getter for the non-Qt TestRunner instance.
178
179         Reviewed by Simon Hausmann.
180
181         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
182         (WebPage::resetSettings):
183         * DumpRenderTree/qt/DumpRenderTreeQt.h:
184         (DumpRenderTree::jscTestRunner):
185         * DumpRenderTree/qt/TestRunnerQt.cpp:
186         (TestRunner::setDefersLoading):
187             Moving setDefersLoading from TestRunnerQt
188             to TestRunner.
189         * DumpRenderTree/qt/TestRunnerQt.h:
190         (TestRunnerQt):
191
192 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
193
194         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
195         https://bugs.webkit.org/show_bug.cgi?id=104779
196
197         Reviewed by Carlos Garcia Campos.
198
199         * Scripts/run-gtk-tests:
200         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
201         passing in current trunk.
202
203 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
204
205         Fix HAVE(QTTESTSUPPORT) logic
206
207         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
208         resulting in HAVE(QTTESTSUPPORT) never being true.
209         Move that logic down in sanitizeFeatures.
210
211         Rubber-stamped by Tor Arne Vestbø.
212
213         * qmake/mkspecs/features/features.prf:
214
215 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
216
217         [GTK] Bump required versions of some dependencies
218         https://bugs.webkit.org/show_bug.cgi?id=113282
219
220         Reviewed by Martin Robinson.
221
222         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
223
224 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
225
226         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
227         https://bugs.webkit.org/show_bug.cgi?id=113809
228
229         Reviewed by Philippe Normand.
230
231         Newer Linux kernels have removed some deprecated macros from v4l2
232         headers, causing gst-plugins-good's build to break. We don't need it
233         right now, so just disable it.
234
235         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
236
237 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
238
239         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
240         https://bugs.webkit.org/show_bug.cgi?id=113535
241
242         Reviewed by Simon Hausmann.
243
244         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
245
246         * qmake/mkspecs/features/features.prf:
247
248 2013-04-03  Zeno Albisser  <zeno@webkit.org>
249
250         [Qt] Move logic of simple forwarding functions to TestRunner.
251         https://bugs.webkit.org/show_bug.cgi?id=113863
252
253         Reviewed by Simon Hausmann.
254
255         * DumpRenderTree/qt/TestRunnerQt.cpp:
256         (TestRunner::setTextDirection):
257         (TestRunner::goBack):
258         (TestRunner::evaluateScriptInIsolatedWorld):
259         (TestRunner::addUserStyleSheet):
260         * DumpRenderTree/qt/TestRunnerQt.h:
261         (TestRunnerQt):
262
263 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
264
265         [Qt] Disable media support using QuickTime if deployment target != SDK
266
267         We link to a single libWebKitSystemInterface static lib, so unless the
268         deployment target matches the SDK let's not pretend like we'll be able
269         to run on anything lower than the SDK version.
270
271         Reviewed by Simon Hausmann.
272
273         * qmake/mkspecs/features/features.prf:
274
275 2013-04-02  James Craig  <james@cookiecrook.com>
276
277         AXRoleDescripton for DL is "list"; should be "description list"
278         https://bugs.webkit.org/show_bug.cgi?id=111665
279
280         Reviewed by Chris Fleizach.
281
282         Defining the role and description strings.
283
284         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
285
286 2013-04-02  Roger Fong  <roger_fong@apple.com>
287
288         Unreviewed. Disable running tests on Win EWS queue.
289
290         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
291         (WinEWS):
292
293 2013-04-02  Lucas Forschler  <lforschler@apple.com>
294
295         Disable running tests on the MAC WK2 EWS queue.
296         
297         Unreviewed.
298         
299         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
300         (MacWK2EWS):
301
302 2013-04-02  Julie Parent  <jparent@chromium.org>
303
304         Dashboard refactor: Move dashboard specific history related features to History.
305         https://bugs.webkit.org/show_bug.cgi?id=113717
306
307         Reviewed by Ojan Vafai.
308         
309         Each dashboard now creates its own History object, with a custom
310         configuration. This changes from just overriding global functions
311         to passing in callbacks for generatePage, handleValidHashParameter,
312         and handleQueryParameterChange. Same with passing in defaultStateValues
313         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
314         variables.
315         
316         All functions related to these features are now (mostly) private
317         function on History. 
318         
319         Loader no longer needs a loadingComplete callback, since it can just
320         initialize the history object itself.
321
322         * TestResultServer/static-dashboards/aggregate_results.js:
323         (handleValidHashParameter):
324         * TestResultServer/static-dashboards/dashboard_base.js:
325         * TestResultServer/static-dashboards/flakiness_dashboard.js:
326         (generatePage):
327         (.switch.return):
328         (handleQueryParameterChange):
329         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
330         (resetGlobals):
331         * TestResultServer/static-dashboards/history.js:
332         (.):
333         * TestResultServer/static-dashboards/loader.js:
334         (.):
335         * TestResultServer/static-dashboards/loader_unittests.js:
336         * TestResultServer/static-dashboards/timeline_explorer.js:
337         (generatePage):
338         (initCurrentBuilderTestResults):
339         * TestResultServer/static-dashboards/treemap.js:
340         (generatePage):
341         (.switch.return):
342         (handleQueryParameterChange):
343
344 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
345
346         Unreviewed, rolling out r147401.
347         http://trac.webkit.org/changeset/147401
348         https://bugs.webkit.org/show_bug.cgi?id=113767
349
350         The patch makes it extremely hard to set up the dependencies
351         properly on the GTK builders (Requested by zdobersek on
352         #webkit).
353
354         * gtk/jhbuild.modules:
355
356 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
357
358         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
359         https://bugs.webkit.org/show_bug.cgi?id=113382
360
361         Reviewed by Gyuyoung Kim.
362
363         Do not show the empty tooltip box if the text is null.
364
365         * MiniBrowser/efl/main.c:
366         (popup_menu_populate):
367
368 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
369
370         [GTK] Bump required versions of some dependencies
371         https://bugs.webkit.org/show_bug.cgi?id=113282
372
373         Reviewed by Martin Robinson.
374
375         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
376
377 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
378
379         Unreviewed, rolling out r147319.
380         http://trac.webkit.org/changeset/147319
381         https://bugs.webkit.org/show_bug.cgi?id=113707
382
383         The unit test is still failing on the buildbot (Requested by
384         zdobersek on #webkit).
385
386         * Scripts/run-gtk-tests:
387         (TestRunner):
388
389 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
390
391         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
392         https://bugs.webkit.org/show_bug.cgi?id=104779
393
394         Reviewed by Carlos Garcia Campos.
395
396         * Scripts/run-gtk-tests:
397         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
398         passing in current trunk.
399
400 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
401
402         Unreviewed, rolling out r147289.
403         http://trac.webkit.org/changeset/147289
404         https://bugs.webkit.org/show_bug.cgi?id=113678
405
406         broke Win7 (dbg) build (Requested by shinyak|gardener on
407         #webkit).
408
409         * DumpRenderTree/DumpRenderTree.gypi:
410         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
411         (WebTestRunner):
412         (WebUserMediaClientMock):
413         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
414         (WebTestRunner::WebUserMediaClientMock::taskList):
415         * Scripts/webkitpy/style/checkers/cpp.py:
416         (check_function_definition):
417
418 2013-03-31  Adam Barth  <abarth@webkit.org>
419
420         configure-svn-config.sh fails
421         https://codereview.chromium.org/13392007/
422
423         Reviewed by Eric Seidel.
424
425         This script was trying to use "svn checkout" to dowload a file from
426         svn.webkit.org, but "svn checkout" only works with directories.
427         Instead, we should use "svn export".
428
429         * EWSTools/configure-svn-config.sh:
430
431 2013-03-31  Wei Jia  <wjia@chromium.org>
432
433         Allow WebUserMediaClientMock to be used by client
434         https://bugs.webkit.org/show_bug.cgi?id=113633
435
436         Reviewed by Adam Barth.
437
438         Export WebUserMediaClientMock.
439         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
440
441         * DumpRenderTree/DumpRenderTree.gypi:
442         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
443         (WebUserMediaClientMock):
444         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
445         * Scripts/webkitpy/style/checkers/cpp.py:
446         (check_function_definition):
447
448 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
449
450         Expose FeatureObserver data to WebKit clients
451         https://bugs.webkit.org/show_bug.cgi?id=113613
452
453         Reviewed by Sam Weinig.
454
455         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
456         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
457
458 2013-03-29  Greg Hughes  <ghughes@apple.com>
459
460         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
461         https://bugs.webkit.org/show_bug.cgi?id=112276
462
463         Reviewed by Chris Fleizach.
464
465         Added support to test accessibility search predicates with multiple keys.  
466
467         * DumpRenderTree/AccessibilityUIElement.cpp:
468         (uiElementForSearchPredicateCallback):
469         * DumpRenderTree/AccessibilityUIElement.h:
470         (AccessibilityUIElement):
471         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
472         (AccessibilityUIElement::uiElementForSearchPredicate):
473         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
474         (AccessibilityUIElement::uiElementForSearchPredicate):
475         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
476         (AccessibilityUIElement::uiElementForSearchPredicate):
477         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
478         (AccessibilityUIElement::uiElementForSearchPredicate):
479         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
480         (AccessibilityUIElement::uiElementForSearchPredicate):
481         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
482         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
483         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
484         (AccessibilityUIElement):
485         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
486         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
487         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
488         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
489         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
490
491 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
492
493         Fix a typo in r147147 to fix Mac EWS.
494
495         * Scripts/webkitpy/tool/commands/queues.py:
496         (PatchProcessingQueue._new_port_name_from_old):
497
498 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
499
500         [EFL] Build break with latest EFL libraries after r146265
501         https://bugs.webkit.org/show_bug.cgi?id=113558
502
503         Unreviewed build fix.
504
505         * TestWebKitAPI/PlatformWebView.h:
506         * WebKitTestRunner/PlatformWebView.h:
507
508 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
509
510         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
511
512         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
513         in libgcrypt build.
514
515 2013-03-28  Lucas Forschler  <lforschler@apple.com>
516
517         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
518
519         Unreviewed.
520
521         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
522         (MacEWS):
523
524 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
525
526         Use the right OS name on Mac EWS instead of mac-future.
527
528         Rubber-stamped by Dirk Pranke.
529
530         * Scripts/webkitpy/tool/commands/queues.py:
531         (PatchProcessingQueue._new_port_name_from_old):
532         (PatchProcessingQueue.begin_work_queue):
533         (PatchProcessingQueue._upload_results_archive_for_patch):
534
535 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
536
537         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
538         https://bugs.webkit.org/show_bug.cgi?id=112546
539
540         Reviewed by Martin Robinson.
541
542         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
543         moved back to Source/WebCore/platform. Fix an indentation issue as well.
544
545 2013-03-28  Ming Xie  <mxie@blackberry.com>
546
547         [BlackBerry] Committer Email Updates
548         https://bugs.webkit.org/show_bug.cgi?id=113435
549
550         Reviewed by Rob Buis.
551
552         Add the @blackberry.com email address for all our BlackBerry
553         WebKit committers. This is the first step for our email address
554         migration.
555
556         * Scripts/webkitpy/common/config/committers.py:
557
558 2013-03-28  Philippe Normand  <pnormand@igalia.com>
559
560         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
561         https://bugs.webkit.org/show_bug.cgi?id=113508
562
563         Reviewed by Martin Robinson.
564
565         Prevent the GStreamer plugin scanner to load system-wide
566         plugins. Only the ones built in JHBuild should be loaded and used
567         at runtime.
568
569         * efl/jhbuildrc:
570         * gtk/jhbuildrc:
571
572 2013-03-27  Philippe Normand  <pnormand@igalia.com>
573
574         [GTK] run-launcher --gtk -2 fails on a WK2-only build
575         https://bugs.webkit.org/show_bug.cgi?id=113386
576
577         Reviewed by Carlos Garcia Campos.
578
579         * Scripts/webkitdirs.pm:
580         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
581         version to 3.0. Reflect this change so the builtDylibPathForName
582         function doesn't fail to report the library as found.
583
584 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
585
586         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
587         https://bugs.webkit.org/show_bug.cgi?id=113484
588
589         Unreviewed build fix.
590
591         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
592
593         * TestWebKitAPI/CMakeLists.txt:
594         * WebKitTestRunner/CMakeLists.txt:
595
596 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
597
598         Revision for the internal jhbuild is too old
599         https://bugs.webkit.org/show_bug.cgi?id=113324
600
601         Reviewed by Martin Robinson.
602
603         Update the minimum required version to a point where jhbuild won't
604         fail installing packages when trying to remove a symlink to a directory.
605
606         * jhbuild/jhbuild-wrapper: Updated revision.
607
608 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
609
610         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
611         https://bugs.webkit.org/show_bug.cgi?id=113203
612
613         Reviewed by Philippe Normand.
614
615         We build our libsoup without GNOME support. gst-plugins-good does separate
616         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
617         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
618         build failures as the headers of those diverge. We do not use souphttpsrc, so
619         disable it when building gst-plugins-good.
620
621         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
622
623 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
624
625         Build fix after r146852. Please another reference to the Lion leaks builder.
626
627         * BuildSlaveSupport/build.webkit.org-config/config.json:
628
629 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
630
631         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
632         https://bugs.webkit.org/show_bug.cgi?id=113421
633
634         Reviewed by Dirk Pranke.
635
636         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
637         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
638         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
639         in the GTK-specific TestExpectations files.
640
641         To avoid this only enable the warnings only when not using WKTR.
642
643         * Scripts/webkitpy/layout_tests/port/gtk.py:
644         (GtkPort.warn_if_bug_missing_in_test_expectations):
645
646 2013-03-27  Antti Koivisto  <antti@apple.com>
647
648         Fix Zalan's email.
649
650         * Scripts/webkitpy/common/config/committers.py:
651
652 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
653
654         master.cfg cleanup
655         https://bugs.webkit.org/show_bug.cgi?id=113195
656
657         Reviewed by Ryosuke Niwa.
658
659         * BuildSlaveSupport/build.webkit.org-config/config.json:
660         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
661
662 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
663
664         master.cfg fine-tuning for Qt Mountain Lion Release bot
665         https://bugs.webkit.org/show_bug.cgi?id=113191
666
667         Reviewed by Ryosuke Niwa.
668
669         * BuildSlaveSupport/build.webkit.org-config/config.json:
670           - Rename the slave due to its location change.
671           - Update the platform of the slave.
672         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
673         (RunQtAPITests): Enable running WK2 API tests on Qt.
674         (RunQtAPITests.start):
675         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
676         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
677
678 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
679
680         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
681         https://bugs.webkit.org/show_bug.cgi?id=113403
682
683         Reviewed by Kenneth Rohde Christiansen.
684
685         As of Evas 1.7.5, when Wayland is detected on the system, support for
686         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
687         The code, however, seems to depend on a few other flags which must be
688         explicitly enabled.
689
690         If those additional GL-related options are passed, we end up
691         having issues on the WebKit side, so disable Wayland support for
692         now.
693
694         * efl/jhbuild.modules:
695
696 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
697
698         Unreviewed, rolling out r146864.
699         http://trac.webkit.org/changeset/146864
700         https://bugs.webkit.org/show_bug.cgi?id=113391
701
702         causes crashes on Wk2 EFL release bot (Requested by drott on
703         #webkit).
704
705         * Scripts/webkitperl/FeatureList.pm:
706
707 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
708
709         [jhbuild] Correctly specify an alternate number of make jobs.
710         https://bugs.webkit.org/show_bug.cgi?id=113396
711
712         Reviewed by Philippe Normand.
713
714         So far, we were using the `MAKEFLAGS' environment variable to pass the
715         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
716         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
717
718         We now behave more closely to the rest of the WebKit tools by first
719         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
720         not set, just letting jhbuild itself figure out how many jobs to use.
721
722         * efl/jhbuildrc:
723         * gtk/jhbuildrc:
724
725 2013-03-27  Zeno Albisser  <zeno@webkit.org>
726
727         [Qt] Remove Qt specific WorkQueueItem definitions.
728         https://bugs.webkit.org/show_bug.cgi?id=112891
729
730         This patch is preparation work for removing
731         WorkQueue related code from TestRunnerQt and
732         replacing it with generic TestRunner code.
733
734         Reviewed by Benjamin Poulain.
735
736         * DumpRenderTree/qt/TestRunnerQt.cpp:
737         (TestRunnerQt::queueBackNavigation):
738         (TestRunnerQt::queueForwardNavigation):
739         (TestRunnerQt::queueLoadHTMLString):
740         (TestRunnerQt::queueReload):
741         (TestRunnerQt::queueLoadingScript):
742         (TestRunnerQt::queueNonLoadingScript):
743         (TestRunner::queueLoad):
744         * DumpRenderTree/qt/TestRunnerQt.h:
745         (TestRunnerQt):
746         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
747         (LoadItem::invoke):
748         (LoadHTMLStringItem::invoke):
749         (LoadAlternateHTMLStringItem::invoke):
750         (ReloadItem::invoke):
751         (ScriptItem::invoke):
752         (BackForwardItem::invoke):
753         * DumpRenderTree/qt/WorkQueueItemQt.h:
754         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
755         (LoadAlternateHTMLStringItem):
756
757 2013-03-26  Julie Parent  <jparent@chromium.org>
758
759         Flakiness dashboard: simplify logic around which tests to show.
760         https://bugs.webkit.org/show_bug.cgi?id=113250
761
762         Reviewed by Ojan Vafai.
763         
764         The different filters for showing results are only used for layout
765         tests, otherwise, we show everything.
766         
767         Change the defaults to false (what layout tests used), and only
768         look at the values when viewing layout tests.
769
770         * TestResultServer/static-dashboards/flakiness_dashboard.js:
771         (htmlForTestsWithExpectationsButNoFailures):
772         (shouldHideTest):
773
774 2013-03-26  Isaac Levy  <ilevy@google.com>
775
776         Update bots on test-results.appspot
777         https://bugs.webkit.org/show_bug.cgi?id=113333
778
779         Reviewed by Ojan Vafai.
780
781         * TestResultServer/static-dashboards/builders.jsonp:
782
783 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
784
785         Unreviewed GTK gardening.
786
787         * Scripts/run-gtk-tests:
788         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
789
790 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
791
792         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
793         https://bugs.webkit.org/show_bug.cgi?id=113287
794
795         Reviewed by Jocelyn Turcotte.
796
797         * Scripts/run-qtwebkit-tests:
798         (Options.__init__):
799
800 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
801
802         [EFL] Enable IndexedDB by default
803         https://bugs.webkit.org/show_bug.cgi?id=107248
804
805         Reviewed by Laszlo Gombos.
806
807         * Scripts/webkitperl/FeatureList.pm:
808         Enable IndexedDB by default on EFL.
809
810 2013-03-26  Alan Cutter  <alancutter@chromium.org>
811
812         Sheriffbot should explain rollout failures in a human readable form.
813         https://bugs.webkit.org/show_bug.cgi?id=107092
814
815         Reviewed by Ryosuke Niwa.
816
817         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
818
819         * Scripts/webkitpy/tool/bot/irc_command.py:
820         (Rollout._check_diff_failure):
821         (Rollout.execute):
822         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
823         (IRCCommandTest.test_rollout):
824
825 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
826
827         Unreviewed GTK gardening.
828
829         * Scripts/run-gtk-tests:
830         (TestRunner): Skipping a failing unit test after r146518.
831
832 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
833
834         Remove Lion leaks builder
835         https://bugs.webkit.org/show_bug.cgi?id=113252
836
837         Reviewed by Andreas Kling.
838
839         Removed.
840
841         * BuildSlaveSupport/build.webkit.org-config/config.json:
842
843 2013-03-25  Kent Tamura  <tkent@chromium.org>
844
845         Rename ENABLE_INPUT_TYPE_DATETIME
846         https://bugs.webkit.org/show_bug.cgi?id=113254
847
848         Reviewed by Kentaro Hara.
849
850         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
851         Actually I'd like to remove the code, but we shouldn't remove it yet
852         because we shipped products with it on some platforms.
853
854         * Scripts/webkitperl/FeatureList.pm:
855         * qmake/mkspecs/features/features.pri:
856
857 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
858
859         Remove one more line that was intended to be removed in r146657.
860
861         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
862         (summarize_results):
863
864 2013-03-25  Roger Fong  <roger_fong@apple.com>
865
866         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
867         Re-enable WinEWS tests.
868
869         * Scripts/webkitpy/common/config/ports.py:
870         (WinPort.run_bindings_tests_command):
871         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
872         (WinEWS):
873
874 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
875
876         Unreviewed, rolling out r146793.
877         http://trac.webkit.org/changeset/146793
878         https://bugs.webkit.org/show_bug.cgi?id=113248
879
880         Fix did not work (Requested by rfong on #webkit).
881
882         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
883         (WinEWS):
884
885 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
886
887         REGRESSION(r146657): Test failures reported incorrectly
888         https://bugs.webkit.org/show_bug.cgi?id=113223
889
890         Reviewed by Dirk Pranke.
891
892         The bug was caused by BuildBotPrinter not taking the new behavior into account.
893
894         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
895         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
896
897         * Scripts/webkitpy/layout_tests/controllers/manager.py:
898         (Manager.run):
899
900         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
901         (RunDetails.__init__):
902         (summarize_results): Remove the line I intended to remove in r146657.
903
904         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
905         (logging_run): Return details instead of the exit code.
906         (run_and_capture): Ditto.
907
908         (RunTest.test_full_results_html):
909         (RunTest.test_hung_thread):
910         (RunTest.test_no_tests_found):
911         (RunTest.test_no_tests_found_2):
912         (RunTest.test_repeat_each_iterations_num_tests):
913         (RunTest.test_run_singly_actually_runs_tests):
914         (RunTest.test_test_list):
915         (RunTest.test_missing_and_unexpected_results):
916         (RunTest.test_pixel_test_directories):
917         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
918         (RunTest.test_crash_with_stderr):
919         (RunTest.test_no_image_failure_with_image_diff):
920         (RunTest.test_crash_log):
921         (RunTest.test_exit_after_n_failures_upload):
922         (RunTest.test_results_directory_absolute):
923         (RunTest.test_results_directory_relative):
924         (RunTest.test_retrying_and_flaky_tests):
925         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
926         (RunTest.test_retrying_uses_retries_directory):
927         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
928         (RunTest.test_output_diffs):
929         (EndToEndTest.test_reftest_with_two_notrefs):
930         (RebaselineTest.test_reset_results):
931         (RebaselineTest.test_missing_results):
932         (RebaselineTest.test_new_baseline):
933
934         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
935         (BuildBotPrinter.print_results):
936         (BuildBotPrinter.print_unexpected_results):
937         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
938         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
939
940 2013-03-25  Julie Parent  <jparent@chromium.org>
941
942         Dashboard refactor: Move cross dashboard history related code into history.js.
943         https://bugs.webkit.org/show_bug.cgi?id=113104
944
945         Reviewed by Ojan Vafai.
946
947         All functions relating to cross dashboard behavior move from being
948         globals to methods on the history.History object. Names stay the same,
949         except many are made private, ones that should have been constants now
950         are, and the long standing TODO to change "currentState" to 
951         dashboardSpecificState is done.
952         
953         We now create a global history object in dashboard_base, as an 
954         intermediate measure.  Once the dashboard specific code is
955         added to history, each DB will need to create its own, and this
956         global will be eliminated.
957         
958         * TestResultServer/static-dashboards/aggregate_results.js:
959         (handleValidHashParameter):
960         (htmlForBuilder):
961         (rawValuesHTML):
962         * TestResultServer/static-dashboards/dashboard_base.js:
963         (parseDashboardSpecificParameters):
964         (defaultValue):
965         (currentBuilderGroupCategory):
966         (currentBuilderGroupName):
967         (handleLocationChange):
968         (expectationsMap):
969         * TestResultServer/static-dashboards/flakiness_dashboard.js:
970         (generatePage):
971         (.switch.return):
972         (platformAndBuildType):
973         (individualTests):
974         (substringList):
975         (processMissingAndExtraExpectations):
976         (pathToFailureLog):
977         (showPopupForBuild):
978         (htmlForTestsWithExpectationsButNoFailures):
979         (shouldHideTest):
980         (isCrossBuilderView):
981         (tableHeaders):
982         (htmlForSingleTestRow):
983         (htmlForTableColumnHeader):
984         (generatePageForExpectationsUpdate):
985         (handleUpdate):
986         (nextUpdate):
987         (setUpdateIndex):
988         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
989         (.appendExpectationsItem):
990         (loadExpectations):
991         (.dummyNode.onload):
992         (loadExpectationsLayoutTests):
993         (appendExpectations):
994         (htmlForNavBar):
995         (checkBoxToToggleState):
996         (linkHTMLToToggleState):
997         (generatePageForBuilder):
998         (isInvalidKeyForCrossBuilderView):
999         (handleQueryParameterChange):
1000         (showLegend):
1001         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1002         (resetGlobals):
1003         (test):
1004         * TestResultServer/static-dashboards/history.js:
1005         (.):
1006         * TestResultServer/static-dashboards/history_unittests.js:
1007         * TestResultServer/static-dashboards/loader.js:
1008         (.):
1009         * TestResultServer/static-dashboards/loader_unittests.js:
1010         * TestResultServer/static-dashboards/timeline_explorer.js:
1011         (generatePage):
1012         (initCurrentBuilderTestResults):
1013         (selectBuild):
1014         (showResultsDelta):
1015         * TestResultServer/static-dashboards/treemap.js:
1016         (generatePage):
1017         (.switch.return):
1018         (handleFocus):
1019         * TestResultServer/static-dashboards/ui.js:
1020
1021 2013-03-25  Roger Fong  <roger_fong@apple.com>
1022
1023         Unreviewed. Enable WinEWS tests again.
1024
1025         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1026         (WinEWS):
1027
1028 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1029
1030         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1031         https://bugs.webkit.org/show_bug.cgi?id=112166
1032
1033         HarfBuzz 0.9.14 merged my patch for icu detection without
1034         pkg-config files, as needed by for example Ubuntu 12.04.
1035         This obsoletes our local workaround. Removed it for GTK and EFL.
1036
1037         Reviewed by Martin Robinson.
1038
1039         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1040         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1041         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1042         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1043
1044 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1045
1046         Unreviewed.  Move self from contributor to committer list.
1047
1048         * Scripts/webkitpy/common/config/committers.py:
1049
1050 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1051
1052         EWS should use a human readable port name when uploading layout test archives
1053         https://bugs.webkit.org/show_bug.cgi?id=113099
1054
1055         Reviewed by Dirk Pranke.
1056
1057         Use new port's object's name() method to report human readable port names.
1058         This will also help us resolving the bug to apply layout test results posted by EWS.
1059
1060         * Scripts/webkitpy/tool/bot/botinfo.py:
1061         (BotInfo.__init__): Take port's name.
1062         (BotInfo.summary_text):
1063
1064         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1065         (BotInfoTest.test_summary_text):
1066
1067         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1068         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1069
1070         * Scripts/webkitpy/tool/commands/queues.py:
1071         (PatchProcessingQueue.__init__): Initialize self._port.
1072         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1073         and use that for the attachment filename and the comment posted.
1074
1075         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1076         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1077         "mac-snowleopard" as expected for TestPort.
1078
1079 2013-03-22  Roger Fong  <roger_fong@apple.com>
1080
1081         Unreviewed. Turn off EWS test on Win again.
1082         The battle continues.
1083
1084         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1085         (WinEWS):
1086
1087 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1088
1089         NRWT: Enable pixel tests when retrying tests
1090         https://bugs.webkit.org/show_bug.cgi?id=112898
1091
1092         Reviewed by Dirk Pranke.
1093
1094         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1095         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1096         if we've forced pixel tests in the retry.
1097         (Manager._run_tests):
1098         (Manager._clean_up_run): Fixed the capitalizations.
1099         (Manager._force_pixel_tests_if_needed): Added.
1100
1101         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1102         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1103         'image_diff_percent' if it doesn't already exist.
1104
1105         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1106         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1107         treat this as a regular regression instead of a flakiness.
1108
1109         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1110         run had image diffs.
1111
1112         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1113         (summarized_results):
1114
1115         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1116         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1117         Also removed some dead code.
1118
1119         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1120         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1121         is set and pixel_tests_enabled is set to false.
1122         (EndToEndTest.test_reftest_with_two_notrefs):
1123
1124 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1125
1126         Make it possible to run layout tests on Retina MBP
1127         https://bugs.webkit.org/show_bug.cgi?id=93673
1128
1129         Reviewed by Ryosuke Niwa.
1130
1131         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1132         windows on 2x machines still run at 1x.
1133
1134         * DumpRenderTree/mac/DumpRenderTree.mm:
1135         (createWebViewAndOffscreenWindow):
1136         Reset the window resolution to 1x on creation.
1137         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
1138         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1139         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
1140         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1141         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
1142         (WTR::PlatformWebView::PlatformWebView):
1143         Add NSWindow details, reset the window resolution to 1x on creation.
1144
1145 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1146
1147         Leak bots shouldn't build
1148         https://bugs.webkit.org/show_bug.cgi?id=112774
1149
1150         Reviewed by Simon Fraser.
1151
1152         Since leak bots use regular debug builds, there is no need to build on these bots.
1153         Simply downloading builds will dramatically improve the cycle time of these bots.
1154
1155         * BuildSlaveSupport/build.webkit.org-config/config.json:
1156         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1157         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
1158         TestFactory instead of BuildAndTestFactory.
1159
1160 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1161
1162         [Qt] Fix the TestWebKitAPI build
1163         https://bugs.webkit.org/show_bug.cgi?id=113044
1164
1165         Reviewed by Tor Arne Vestbø.
1166
1167         The generate-forwarding-headers script would only be run
1168         after the targets in InjectedBundle.pri since the second
1169         addStrictSubdirOrderBetween call in
1170         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
1171         the derived_sources -> injected_bundle order in SUBDIRS.
1172
1173         Fix it by only moving the dependent target at the end of
1174         SUBDIRS, don't touch its dependency.
1175
1176         * qmake/mkspecs/features/functions.prf:
1177
1178 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1179
1180         [EFL][WK2] View is not focused when fullscreen mode toggled
1181         https://bugs.webkit.org/show_bug.cgi?id=113009
1182
1183         Reviewed by Laszlo Gombos.
1184
1185         Set focus on view when fullscreen mode enabled/disabled
1186         by FullScreen API.
1187
1188         * MiniBrowser/efl/main.c:
1189         (on_fullscreen_accept):
1190         (on_fullscreen_deny):
1191
1192 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1193
1194         nrwt is no longer saving retry results in the retries/ subdirectory
1195         https://bugs.webkit.org/show_bug.cgi?id=112995
1196
1197         Reviewed by Ojan Vafai.
1198
1199         I think this has been broken a long time, unfortunately. This
1200         patch should fix that.
1201
1202         In order to do so, I had to pass the directory to use from
1203         the Worker object through the SingleTestWriter to the
1204         TestResultWriter. While I was plumbing that through, I rationalized
1205         the order of the parameter arguments a bit ...
1206
1207         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1208         (Worker._run_single_test):
1209         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1210         (run_single_test):
1211         (SingleTestRunner.__init__):
1212         (SingleTestRunner._run_compare_test):
1213         (SingleTestRunner._run_rebaseline):
1214         (SingleTestRunner._run_reftest):
1215         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1216         (write_test_result):
1217         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1218         (TestResultWriterTest.test_reftest_diff_image):
1219         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1220         (RunTest.test_retrying_uses_retries_directory):
1221
1222 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
1223
1224         JSC profiler should have an at-a-glance report of the success of DFG optimization
1225         https://bugs.webkit.org/show_bug.cgi?id=112988
1226
1227         Reviewed by Geoffrey Garen.
1228
1229         * Scripts/display-profiler-output:
1230
1231 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1232
1233         [chromium] Linux ASAN WebKit canary is running out of memory
1234         https://bugs.webkit.org/show_bug.cgi?id=112978
1235
1236         Reviewed by Tony Chang.
1237
1238         Running the AddressSanitizer on a crash takes a lot of
1239         memory, so we should serialize access to it to avoid running
1240         out of memory on a machine.
1241
1242         * Scripts/webkitpy/layout_tests/port/chromium.py:
1243         (ChromiumPort._get_crash_log):
1244         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1245         (HttpLock.__init__):
1246         (HttpLock.wait_for_httpd_lock):
1247
1248 2013-03-21  Min Qin  <qinmin@chromium.org>
1249
1250         Cleanup android media layout test code
1251         https://bugs.webkit.org/show_bug.cgi?id=112944
1252
1253         Reviewed by Adam Barth.
1254
1255         Chromium change: https://codereview.chromium.org/12892010/
1256         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
1257         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
1258         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
1259         Instead, we should switch to use content shell for layout tests.
1260
1261         * DumpRenderTree/chromium/TestShell.cpp:
1262         (TestShell::resetTestController):
1263
1264 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1265
1266         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
1267         https://bugs.webkit.org/show_bug.cgi?id=112953
1268
1269         Reviewed by Tony Chang.
1270
1271         When I created the DumpRenderTree_resources target in r144863 I
1272         forgot to declare the needed dependencies on the other resource
1273         targets. Due to a quirk of ordering, this appears to have been fine
1274         w/ ninja but not w/ Xcode (which is still being used on the chromium
1275         mac valgrind bots). Declaring the dependencies fixes the build
1276         failures.
1277
1278         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1279
1280 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
1281
1282         [WinCairo] Correct assert in Empty BitmapImage Test.
1283         https://bugs.webkit.org/show_bug.cgi?id=112934
1284
1285         Reviewed by Tim Horton.
1286
1287         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1288         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
1289         to avoid ref counting assertion when leaving test scope.
1290
1291 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
1292
1293         [GTK] generate-feature-defines-files is incompatible with Python3
1294         https://bugs.webkit.org/show_bug.cgi?id=112956
1295
1296         Reviewed by Martin Robinson.
1297
1298         Make the generate-feature-defines-files compatible with Python3 by calling the items()
1299         method on the dictionary objects when iterating through said dictionaries.
1300
1301         * gtk/generate-feature-defines-files:
1302         (write_feature_defines_header):
1303         (write_flattened_feature_defines_file):
1304
1305 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1306
1307         kill-old-processes spits out error messages on Mac
1308         https://bugs.webkit.org/show_bug.cgi?id=112878
1309
1310         Reviewed by Jessie Berlin.
1311
1312         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
1313         included in the list of options grep --help shows.
1314
1315         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
1316
1317         * BuildSlaveSupport/kill-old-processes:
1318         (main):
1319
1320 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
1321
1322         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
1323         https://bugs.webkit.org/show_bug.cgi?id=112597
1324
1325         Reviewed by Xan Lopez.
1326
1327         These were introduced for the Chromium port in r105295. We need
1328         dummy implementations in order to compile the BlackBerry port.
1329
1330         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1331         (AccessibilityUIElement::scrollToMakeVisible):
1332         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1333         (AccessibilityUIElement::scrollToGlobalPoint):
1334
1335 2013-03-21  Roger Fong  <roger_fong@apple.com>
1336
1337         Re-enable WinEWS tests following r146376.
1338
1339         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1340         (WinEWS):
1341
1342 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
1343
1344         Unreviewed. Add Bem Jones-Bey to the list of contributors.
1345
1346         * Scripts/webkitpy/common/config/committers.py:
1347
1348 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1349
1350         [GTK] Missing atk in install-dependencies script
1351         https://bugs.webkit.org/show_bug.cgi?id=112272
1352
1353         Reviewed by Gustavo Noronha Silva.
1354
1355         * gtk/install-dependencies: Add missing atk dependency.
1356
1357 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1358
1359         [GTK] Missing backslash in install-dependencies script
1360         https://bugs.webkit.org/show_bug.cgi?id=112907
1361
1362         Reviewed by Philippe Normand.
1363
1364         * gtk/install-dependencies: Add missing backslash to dependencies
1365         list.
1366
1367 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1368
1369         EWS bots have stopped uploading results to bugzilla
1370         https://bugs.webkit.org/show_bug.cgi?id=101091
1371
1372         Reviewed by Adam Barth.
1373
1374         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
1375         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
1376         this relative file path resoled to a file inside a non-existent directory for "zip".
1377
1378         Fixed the bug by resolving both test results directory and zip archive paths in
1379         LayoutTestResultsReader.archive.
1380
1381         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
1382         in the future.
1383
1384         * Scripts/webkitpy/common/system/filesystem_mock.py:
1385         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
1386
1387         * Scripts/webkitpy/common/system/workspace.py:
1388         (Workspace.create_zip): Log the source path when "zip" failed.
1389
1390         * Scripts/webkitpy/common/system/workspace_mock.py:
1391         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
1392
1393         * Scripts/webkitpy/common/system/workspace_unittest.py:
1394         (WorkspaceTest.test_create_zip_exception): Test that.
1395
1396         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1397         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
1398         This is the actual bug fix.
1399
1400         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1401         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
1402
1403 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
1404
1405         [chromium] move WebThemeEngine implementations to TestRunner library
1406         https://bugs.webkit.org/show_bug.cgi?id=112751
1407
1408         Reviewed by Adam Barth.
1409
1410         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1411         * DumpRenderTree/DumpRenderTree.gypi:
1412         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1413         (WebKit):
1414         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1415         (WebTestRunner::TestInterfaces::themeEngine):
1416         (WebTestRunner):
1417         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1418         (WebKit):
1419         (TestInterfaces):
1420         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1421         (WebTestRunner::WebTestInterfaces::themeEngine):
1422         (WebTestRunner):
1423         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1424         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1425         (WebTestRunner):
1426         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1427         (WebTestRunner::WebTestThemeControlWin::box):
1428         (WebTestRunner::WebTestThemeControlWin::line):
1429         (WebTestRunner::WebTestThemeControlWin::triangle):
1430         (WebTestRunner::WebTestThemeControlWin::roundRect):
1431         (WebTestRunner::WebTestThemeControlWin::oval):
1432         (WebTestRunner::WebTestThemeControlWin::circle):
1433         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1434         (WebTestRunner::WebTestThemeControlWin::markState):
1435         (WebTestRunner::WebTestThemeControlWin::draw):
1436         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1437         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1438         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1439         (WebTestRunner):
1440         (WebTestThemeControlWin):
1441         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1442         (WebTestRunner):
1443         (WebTestThemeEngineMac):
1444         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1445         (+[FakeActiveWindow alwaysActiveWindow]):
1446         (+[FakeActiveWindow alwaysInactiveWindow]):
1447         (-[FakeActiveWindow initWithActiveControls:]):
1448         (-[FakeActiveWindow _hasActiveControls]):
1449         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1450         (WebTestRunner):
1451         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1452         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1453         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1454         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1455         (WebTestRunner):
1456         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1457         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1458         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1459         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1460         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1461         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1462         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1463         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1464         (WebTestRunner::WebTestThemeEngineWin::getSize):
1465         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1466         (WebTestRunner):
1467         (WebTestThemeEngineWin):
1468         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1469         * DumpRenderTree/chromium/TestShell.cpp:
1470         (TestShell::initialize):
1471         * DumpRenderTree/chromium/TestShell.h:
1472         (WebKit):
1473         * DumpRenderTree/chromium/TestShellMac.mm:
1474         (platformInit):
1475         * DumpRenderTree/chromium/TestShellWin.cpp:
1476         (platformInit):
1477         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1478
1479 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1480
1481         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
1482
1483         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
1484         New property sheet that does not link against CoreFoundation and
1485         CFNetwork.
1486         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1487         Use new TestWebKitAPICommonWinCairo property sheet.
1488         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1489         Ditto.
1490
1491 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1492
1493         [WinCairo] Unreviewed build fix for VS2010.
1494
1495         Had to add WinCairo-specific property sheets to deal with some
1496         library and path differences with the main Apple port.
1497
1498         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1499         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1500         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1501         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
1502         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
1503         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
1504
1505 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
1506
1507         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
1508         https://bugs.webkit.org/show_bug.cgi?id=112849
1509
1510         Reviewed by Sam Weinig.
1511
1512         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1513         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1514         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1515
1516 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1517
1518         [WinCairo] Build WebKit Tools under VS2010
1519         https://bugs.webkit.org/show_bug.cgi?id=112821
1520
1521         Reviewed by Tim Horton.
1522
1523         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1524         Add WinCairo-specific build target.
1525         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
1526         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
1527         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
1528         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
1529         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1530         Add WinCairo-specific build target.
1531         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1532         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1533         Add WinCairo-specific build target.
1534         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
1535         WinCairo-specific build target.
1536         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
1537         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
1538         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
1539         specific build target.
1540         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
1541         WinCairo-specific build target.
1542         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
1543         * win/record-memory/record-memoryDebugWinCairo.props: Added.
1544         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
1545
1546 2013-03-20  Roger Fong  <roger_fong@apple.com>
1547
1548         API test gardening AppleWin port.
1549
1550         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
1551
1552         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1553         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1554
1555 2013-03-20  Roger Fong  <roger_fong@apple.com>
1556
1557         Test fix for Win EWS bots, catch various errors and restart script if necessary.
1558
1559         * EWSTools/start-queue-win.sh:
1560
1561 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
1562
1563         Unreviewed, add myself to committers.py.
1564
1565 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1566
1567         Unreviewed. Adding another email for me.
1568
1569         * Scripts/webkitpy/common/config/committers.py:
1570
1571 2013-03-20  Justin Novosad  <junov@google.com>
1572
1573         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
1574         https://bugs.webkit.org/show_bug.cgi?id=112605
1575
1576         Reviewed by James Robinson.
1577
1578         Deleting all the code that was used for propagating and supporting
1579         the Chromium setting for disabling deferred 2d canvas rendering.
1580
1581         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1582         (main):
1583         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1584         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1585         (WebTestRunner::WebPreferences::reset):
1586         (WebTestRunner::WebPreferences::applyTo):
1587         * DumpRenderTree/chromium/TestShell.cpp:
1588         (TestShell::TestShell):
1589         (TestShell::resetWebSettings):
1590         (TestShell::runFileTest):
1591         * DumpRenderTree/chromium/TestShell.h:
1592         (TestShell):
1593
1594 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
1595
1596         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
1597         https://bugs.webkit.org/show_bug.cgi?id=112699.
1598
1599         Reviewed by Adam Barth.
1600
1601         * Scripts/webkitpy/layout_tests/port/qt.py:
1602         (QtPort._search_paths):
1603         (QtPort._port_specific_expectations_files):
1604         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1605         (QtPortTest):
1606         (QtPortTest._assert_search_path):
1607         (QtPortTest._assert_expectations_files):
1608
1609 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1610
1611         [Qt] Enable kerning by default
1612         https://bugs.webkit.org/show_bug.cgi?id=112704
1613
1614         Reviewed by Jocelyn Turcotte.
1615
1616         Disable kerning by default, since some reference test expectations
1617         expect kerning to be default off.
1618
1619         * DumpRenderTree/qt/TestRunnerQt.cpp:
1620         (TestRunnerQt::reset):
1621         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1622         (WTR::activateFonts):
1623
1624 2013-03-20  Zeno Albisser  <zeno@webkit.org>
1625
1626         [Qt] Remove empty function stubs from TestRunnerQt.
1627         https://bugs.webkit.org/show_bug.cgi?id=112799
1628
1629         We are reducing the code in TestRunnerQt step by step,
1630         in order to finally replace all of it with the generic
1631         TestRunner implementation.
1632         This patch removes several simple function stubs that
1633         currently do not implement any actual functionality.
1634
1635         Reviewed by Kenneth Rohde Christiansen.
1636
1637         * DumpRenderTree/qt/TestRunnerQt.cpp:
1638         * DumpRenderTree/qt/TestRunnerQt.h:
1639         (TestRunnerQt):
1640
1641 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1642
1643         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
1644         https://bugs.webkit.org/show_bug.cgi?id=112687
1645
1646         Reviewed by Kenneth Rohde Christiansen.
1647
1648         Hide the SearchBar by default on window creation.
1649
1650         * MiniBrowser/efl/main.c:
1651         (window_create):
1652
1653 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1654
1655         Unreviewed, rolling out r146304.
1656         http://trac.webkit.org/changeset/146304
1657         https://bugs.webkit.org/show_bug.cgi?id=112788
1658
1659         to many expectations to update (Requested by antonm on
1660         #webkit).
1661
1662         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1663         * DumpRenderTree/DumpRenderTree.gypi:
1664         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1665         (WebKit):
1666         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1667         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1668         (TestInterfaces):
1669         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1670         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1671         * DumpRenderTree/chromium/TestShell.cpp:
1672         (TestShell::initialize):
1673         * DumpRenderTree/chromium/TestShell.h:
1674         (WebKit):
1675         * DumpRenderTree/chromium/TestShellMac.mm:
1676         (platformInit):
1677         * DumpRenderTree/chromium/TestShellWin.cpp:
1678         (platformInit):
1679         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1680         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1681         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1682         (WebThemeControlDRTWin::box):
1683         (WebThemeControlDRTWin::line):
1684         (WebThemeControlDRTWin::triangle):
1685         (WebThemeControlDRTWin::roundRect):
1686         (WebThemeControlDRTWin::oval):
1687         (WebThemeControlDRTWin::circle):
1688         (WebThemeControlDRTWin::nestedBoxes):
1689         (WebThemeControlDRTWin::markState):
1690         (WebThemeControlDRTWin::draw):
1691         (WebThemeControlDRTWin::drawTextField):
1692         (WebThemeControlDRTWin::drawProgressBar):
1693         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1694         (WebThemeControlDRTWin):
1695         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1696         (WebThemeEngineDRTMac):
1697         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1698         (+[FakeActiveWindow alwaysActiveWindow]):
1699         (+[FakeActiveWindow alwaysInactiveWindow]):
1700         (-[FakeActiveWindow initWithActiveControls:]):
1701         (-[FakeActiveWindow _hasActiveControls]):
1702         (WebThemeEngineDRTMac::paintScrollbarThumb):
1703         (stateToHIEnableState):
1704         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1705         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1706         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
1707         (webRectToSkIRect):
1708         (drawControl):
1709         (drawTextField):
1710         (drawProgressBar):
1711         (WebThemeEngineDRTWin::paintButton):
1712         (WebThemeEngineDRTWin::paintMenuList):
1713         (WebThemeEngineDRTWin::paintScrollbarArrow):
1714         (WebThemeEngineDRTWin::paintScrollbarThumb):
1715         (WebThemeEngineDRTWin::paintScrollbarTrack):
1716         (WebThemeEngineDRTWin::paintSpinButton):
1717         (WebThemeEngineDRTWin::paintTextField):
1718         (WebThemeEngineDRTWin::paintTrackbar):
1719         (WebThemeEngineDRTWin::paintProgressBar):
1720         (WebThemeEngineDRTWin::getSize):
1721         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
1722         (WebThemeEngineDRTWin):
1723         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1724
1725 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1726
1727         [Qt] Support -webkit-font-smoothing
1728         https://bugs.webkit.org/show_bug.cgi?id=106009
1729
1730         Reviewed by Jocelyn Turcotte.
1731
1732         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
1733
1734         * DumpRenderTree/qt/TestRunnerQt.cpp:
1735         (TestRunnerQt::reset):
1736
1737 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
1738
1739         [GTK] accessibility/aria-scrollbar-role.html is failing
1740         https://bugs.webkit.org/show_bug.cgi?id=98358
1741
1742         Reviewed by Martin Robinson.
1743
1744         Adds support for checking accessibility object's orientation.
1745         Orientation is checked by retrieving proper state of accessibility object.
1746
1747         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1748         (checkElementState):
1749         (AccessibilityUIElement::orientation):
1750         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1751         (WTR::AccessibilityUIElement::orientation):
1752
1753 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
1754
1755         [chromium] move WebThemeEngine implementations to TestRunner library
1756         https://bugs.webkit.org/show_bug.cgi?id=112751
1757
1758         Reviewed by Adam Barth.
1759
1760         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1761         * DumpRenderTree/DumpRenderTree.gypi:
1762         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1763         (WebKit):
1764         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1765         (WebTestRunner::TestInterfaces::themeEngine):
1766         (WebTestRunner):
1767         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1768         (WebKit):
1769         (TestInterfaces):
1770         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1771         (WebTestRunner::WebTestInterfaces::themeEngine):
1772         (WebTestRunner):
1773         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1774         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1775         (WebTestRunner):
1776         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1777         (WebTestRunner::WebTestThemeControlWin::box):
1778         (WebTestRunner::WebTestThemeControlWin::line):
1779         (WebTestRunner::WebTestThemeControlWin::triangle):
1780         (WebTestRunner::WebTestThemeControlWin::roundRect):
1781         (WebTestRunner::WebTestThemeControlWin::oval):
1782         (WebTestRunner::WebTestThemeControlWin::circle):
1783         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1784         (WebTestRunner::WebTestThemeControlWin::markState):
1785         (WebTestRunner::WebTestThemeControlWin::draw):
1786         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1787         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1788         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1789         (WebTestRunner):
1790         (WebTestThemeControlWin):
1791         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1792         (WebTestRunner):
1793         (WebTestThemeEngineMac):
1794         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1795         (+[FakeActiveWindow alwaysActiveWindow]):
1796         (+[FakeActiveWindow alwaysInactiveWindow]):
1797         (-[FakeActiveWindow initWithActiveControls:]):
1798         (-[FakeActiveWindow _hasActiveControls]):
1799         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1800         (WebTestRunner):
1801         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1802         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1803         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1804         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1805         (WebTestRunner):
1806         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1807         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1808         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1809         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1810         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1811         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1812         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1813         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1814         (WebTestRunner::WebTestThemeEngineWin::getSize):
1815         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1816         (WebTestRunner):
1817         (WebTestThemeEngineWin):
1818         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1819         * DumpRenderTree/chromium/TestShell.cpp:
1820         (TestShell::initialize):
1821         * DumpRenderTree/chromium/TestShell.h:
1822         (WebKit):
1823         * DumpRenderTree/chromium/TestShellMac.mm:
1824         (platformInit):
1825         * DumpRenderTree/chromium/TestShellWin.cpp:
1826         (platformInit):
1827         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1828
1829 2013-03-19  Tony Chang  <tony@chromium.org>
1830
1831         Move testRunner.setTouchDragDropEnabled to internals.settings
1832         https://bugs.webkit.org/show_bug.cgi?id=112739
1833
1834         Reviewed by Adam Barth.
1835
1836         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1837         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
1838         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1839         (TestRunner): Remove unnecessary code.
1840         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1841         (WebTestRunner::WebPreferences::reset):
1842         (WebTestRunner::WebPreferences::applyTo): Always set to false.
1843
1844 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
1845
1846         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
1847         https://bugs.webkit.org/show_bug.cgi?id=112754
1848
1849         Reviewed by Darin Fisher.
1850
1851         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
1852         now that it's always defined.
1853
1854         * DumpRenderTree/chromium/WebViewHost.cpp:
1855         * DumpRenderTree/chromium/WebViewHost.h:
1856         (WebViewHost):
1857
1858 2013-03-19  Kenneth Russell  <kbr@google.com>
1859
1860         Unreviewed, rolling out r146290.
1861         http://trac.webkit.org/changeset/146290
1862         https://bugs.webkit.org/show_bug.cgi?id=112751
1863
1864         Broke Chromium Mac build.
1865
1866         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1867         * DumpRenderTree/DumpRenderTree.gypi:
1868         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1869         (WebKit):
1870         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1871         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1872         (TestInterfaces):
1873         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1874         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1875         * DumpRenderTree/chromium/TestShell.cpp:
1876         (TestShell::initialize):
1877         * DumpRenderTree/chromium/TestShell.h:
1878         (WebKit):
1879         * DumpRenderTree/chromium/TestShellMac.mm:
1880         (platformInit):
1881         * DumpRenderTree/chromium/TestShellWin.cpp:
1882         (platformInit):
1883         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1884         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1885         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1886         (WebThemeControlDRTWin::box):
1887         (WebThemeControlDRTWin::line):
1888         (WebThemeControlDRTWin::triangle):
1889         (WebThemeControlDRTWin::roundRect):
1890         (WebThemeControlDRTWin::oval):
1891         (WebThemeControlDRTWin::circle):
1892         (WebThemeControlDRTWin::nestedBoxes):
1893         (WebThemeControlDRTWin::markState):
1894         (WebThemeControlDRTWin::draw):
1895         (WebThemeControlDRTWin::drawTextField):
1896         (WebThemeControlDRTWin::drawProgressBar):
1897         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1898         (WebThemeControlDRTWin):
1899         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1900         (WebThemeEngineDRTMac):
1901         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1902         (+[FakeActiveWindow alwaysActiveWindow]):
1903         (+[FakeActiveWindow alwaysInactiveWindow]):
1904         (-[FakeActiveWindow initWithActiveControls:]):
1905         (-[FakeActiveWindow _hasActiveControls]):
1906         (WebThemeEngineDRTMac::paintScrollbarThumb):
1907         (stateToHIEnableState):
1908         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1909         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1910         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
1911         (webRectToSkIRect):
1912         (drawControl):
1913         (drawTextField):
1914         (drawProgressBar):
1915         (WebThemeEngineDRTWin::paintButton):
1916         (WebThemeEngineDRTWin::paintMenuList):
1917         (WebThemeEngineDRTWin::paintScrollbarArrow):
1918         (WebThemeEngineDRTWin::paintScrollbarThumb):
1919         (WebThemeEngineDRTWin::paintScrollbarTrack):
1920         (WebThemeEngineDRTWin::paintSpinButton):
1921         (WebThemeEngineDRTWin::paintTextField):
1922         (WebThemeEngineDRTWin::paintTrackbar):
1923         (WebThemeEngineDRTWin::paintProgressBar):
1924         (WebThemeEngineDRTWin::getSize):
1925         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
1926         (WebThemeEngineDRTWin):
1927         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1928
1929 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
1930
1931         [EFL] canvas-fallback-content.html is failing
1932         https://bugs.webkit.org/show_bug.cgi?id=111998
1933
1934         Reviewed by Chris Fleizach.
1935
1936         Adds support for getting platform name.
1937
1938         * DumpRenderTree/TestRunner.cpp:
1939         (TestRunner::staticValues):
1940         * DumpRenderTree/TestRunner.h:
1941         (TestRunner):
1942         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1943         (TestRunner::platformName):
1944
1945 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
1946
1947         [chromium] move WebThemeEngine implementations to TestRunner library
1948         https://bugs.webkit.org/show_bug.cgi?id=112751
1949
1950         Reviewed by Adam Barth.
1951
1952         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1953         * DumpRenderTree/DumpRenderTree.gypi:
1954         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1955         (WebKit):
1956         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1957         (WebTestRunner::TestInterfaces::themeEngine):
1958         (WebTestRunner):
1959         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1960         (WebKit):
1961         (TestInterfaces):
1962         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1963         (WebTestRunner::WebTestInterfaces::themeEngine):
1964         (WebTestRunner):
1965         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1966         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1967         (WebTestRunner):
1968         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1969         (WebTestRunner::WebTestThemeControlWin::box):
1970         (WebTestRunner::WebTestThemeControlWin::line):
1971         (WebTestRunner::WebTestThemeControlWin::triangle):
1972         (WebTestRunner::WebTestThemeControlWin::roundRect):
1973         (WebTestRunner::WebTestThemeControlWin::oval):
1974         (WebTestRunner::WebTestThemeControlWin::circle):
1975         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1976         (WebTestRunner::WebTestThemeControlWin::markState):
1977         (WebTestRunner::WebTestThemeControlWin::draw):
1978         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1979         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1980         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1981         (WebTestRunner):
1982         (WebTestThemeControlWin):
1983         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1984         (WebTestRunner):
1985         (WebTestThemeEngineMac):
1986         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1987         (+[FakeActiveWindow alwaysActiveWindow]):
1988         (+[FakeActiveWindow alwaysInactiveWindow]):
1989         (-[FakeActiveWindow initWithActiveControls:]):
1990         (-[FakeActiveWindow _hasActiveControls]):
1991         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1992         (WebTestRunner):
1993         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1994         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1995         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1996         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1997         (WebTestRunner):
1998         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1999         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2000         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2001         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2002         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2003         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2004         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2005         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2006         (WebTestRunner::WebTestThemeEngineWin::getSize):
2007         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2008         (WebTestRunner):
2009         (WebTestThemeEngineWin):
2010         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2011         * DumpRenderTree/chromium/TestShell.cpp:
2012         (TestShell::initialize):
2013         * DumpRenderTree/chromium/TestShell.h:
2014         (WebKit):
2015         * DumpRenderTree/chromium/TestShellMac.mm:
2016         (platformInit):
2017         * DumpRenderTree/chromium/TestShellWin.cpp:
2018         (platformInit):
2019         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2020
2021 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2022
2023         [EFL][WK2] Separate WebView further from EwkView
2024         https://bugs.webkit.org/show_bug.cgi?id=111591
2025
2026         Reviewed by Caio Marcelo de Oliveira Filho.
2027
2028         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2029         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2030         since we can afford it having EWKViewGetWKView() private API to access WKView.
2031
2032         * TestWebKitAPI/PlatformWebView.h:
2033         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2034         (TestWebKitAPI::TEST):
2035         * TestWebKitAPI/efl/PlatformWebView.cpp:
2036         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2037         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2038         (TestWebKitAPI::PlatformWebView::resizeTo):
2039         (TestWebKitAPI::PlatformWebView::page):
2040         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2041         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2042         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2043         * WebKitTestRunner/PlatformWebView.h:
2044         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2045         (WTR::EventSenderProxy::dispatchEvent):
2046         (WTR::EventSenderProxy::keyDown):
2047         (WTR::EventSenderProxy::sendTouchEvent):
2048         (WTR::EventSenderProxy::setTouchModifier):
2049         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2050         (WTR::PlatformWebView::PlatformWebView):
2051         (WTR::PlatformWebView::~PlatformWebView):
2052         (WTR::PlatformWebView::resizeTo):
2053         (WTR::PlatformWebView::page):
2054         (WTR::PlatformWebView::focus):
2055         (WTR::PlatformWebView::windowSnapshotImage):
2056
2057 2013-03-19  Roger Fong  <roger_fong@apple.com>
2058
2059         Changes to VS2010 project files should only trigger builds on Windows bots.
2060         https://bugs.webkit.org/show_bug.cgi?id=112731
2061
2062         Reviewed by Timothy Horton.
2063
2064         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2065         (_should_file_trigger_build):
2066
2067 2013-03-19  Roger Fong  <roger_fong@apple.com>
2068
2069         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2070
2071         * Scripts/webkitpy/tool/steps/runtests.py:
2072         (RunTests.run):
2073         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2074         (RunTestsTest.test_webkit_run_unit_tests):
2075
2076 2013-03-19  Julie Parent  <jparent@chromium.org>
2077
2078         Dashboards: Introduce history namespace and unit tests.
2079         https://bugs.webkit.org/show_bug.cgi?id=112645
2080
2081         Reviewed by Ojan Vafai.
2082         
2083         Laying the framework for introducing the new history object and
2084         namespace.  This moves only static functions into the history
2085         namespace, and moves corresponding unit tests into seperate
2086         unit test file.
2087
2088         * TestResultServer/static-dashboards/aggregate_results.html:
2089         * TestResultServer/static-dashboards/dashboard_base.js:
2090         (parseCrossDashboardParameters):
2091         (parseDashboardSpecificParameters):
2092         (parseParameters):
2093         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2094         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2095         (.switch.return):
2096         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2097         * TestResultServer/static-dashboards/history.js: Added.
2098         * TestResultServer/static-dashboards/history_unittests.js: Added.
2099         * TestResultServer/static-dashboards/loader.js:
2100         (.):
2101         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2102         * TestResultServer/static-dashboards/run-unittests.html:
2103         * TestResultServer/static-dashboards/timeline_explorer.html:
2104         * TestResultServer/static-dashboards/timeline_explorer.js:
2105         * TestResultServer/static-dashboards/treemap.html:
2106         * TestResultServer/static-dashboards/treemap.js:
2107         (.switch.return):
2108         * TestResultServer/static-dashboards/ui.js:
2109
2110 2013-03-19  Daniel Bates  <dbates@webkit.org>
2111
2112         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2113         https://bugs.webkit.org/show_bug.cgi?id=112732
2114
2115         Reviewed by Eric Seidel.
2116
2117         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2118         of an existing file cannot be applied.
2119
2120         In particular, svn-{apply, unapply} compensate for differences in line endings
2121         by converting the line endings in a diff to match the line endings in the target
2122         file. The diff(1) command precedes the last line of a diff that adds a newline
2123         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2124         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2125         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2126         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2127         the newline characters in this special character sequence to match the line endings
2128         in the target file.
2129
2130         * Scripts/VCSUtils.pm:
2131         (parseDiff):
2132         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2133         Added tests:
2134             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2135             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2136             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2137             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2138         (escapeNewLineCharacters): Added.
2139         (toMacLineEndings): Added.
2140
2141 2013-03-19  James Robinson  <jamesr@chromium.org>
2142
2143         [chromium] Remove compositor settings that don't go through WebKit
2144         https://bugs.webkit.org/show_bug.cgi?id=112718
2145
2146         Reviewed by Adam Barth.
2147
2148         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2149         (main):
2150         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2151         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2152         (WebTestRunner::WebPreferences::reset):
2153         (WebTestRunner::WebPreferences::applyTo):
2154         * DumpRenderTree/chromium/TestShell.cpp:
2155         (TestShell::TestShell):
2156         (TestShell::resetWebSettings):
2157         * DumpRenderTree/chromium/TestShell.h:
2158         (TestShell):
2159
2160 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
2161
2162         Unreviewed, rolling out r146101.
2163         https://bugs.webkit.org/show_bug.cgi?id=111884
2164
2165         re-enable custom freetype on asan; this needs to be on
2166         now that the bot is running lucid.
2167
2168         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2169
2170 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
2171
2172         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
2173         https://bugs.webkit.org/show_bug.cgi?id=112365
2174
2175         Reviewed by Benjamin Poulain.
2176
2177         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
2178         harcoding it in wtf/Platform.h
2179
2180         * Scripts/webkitperl/FeatureList.pm:
2181
2182 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2183
2184         [Qt] Make ImageDiff similar to Chromium's ImageDiff
2185         https://bugs.webkit.org/show_bug.cgi?id=94782
2186
2187         Based on patch by Csaba Osztrogonác.
2188         Reviewed by Jocelyn Turcotte.
2189
2190         The diff image is generated with bright red indicating errors, but letting the base image
2191         shine through so the context of the error-pixel can be identified.
2192
2193         * DumpRenderTree/qt/ImageDiff.cpp:
2194         (main):
2195
2196 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
2197
2198         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
2199
2200         Rubber-stamped by Csaba Osztrogonác.
2201
2202         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
2203         since the latter might not cover the former.
2204
2205         * QtTestBrowser/launcherwindow.cpp:
2206         (LauncherWindow::print):
2207
2208 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2209
2210         Style tweeks to default.css.
2211         
2212         Rubber-stamped by David Kilzer.
2213         
2214         Give visited links a different color to other links, so you can
2215         see which builds you've viewed.
2216         
2217         Make the <small> text less tiny.
2218
2219         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2220         (small):
2221         (a:link,a:visited,a:active):
2222         (a:visited):
2223
2224 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2225
2226         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
2227         https://bugs.webkit.org/show_bug.cgi?id=112494
2228
2229         Reviewed by Dirk Pranke.
2230
2231         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
2232         Also merged two pairs of methods to cleanup the code.
2233
2234         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2235         (PerfTestsRunner.run): Merged _upload_and_show_results.
2236         (PerfTestsRunner._generate_results): Merged _generate_output_files.
2237
2238 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2239
2240         [chromium] build xdisplaycheck when building DRT
2241         https://bugs.webkit.org/show_bug.cgi?id=112636
2242
2243         Reviewed by Tony Chang.
2244
2245         It appears that we need xdisplaycheck to be built in order for
2246         Xvfb to be started correctly on the bots, and DRT was missing
2247         a dependency on it. This may be the cause of the ASAN bot not
2248         starting up properly (it only builds DRT).
2249
2250         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2251
2252 2013-03-18  David Levin  <levin@chromium.org>
2253
2254         Implement icon change notification dump for Chromium's test shell.
2255         https://bugs.webkit.org/show_bug.cgi?id=112614
2256
2257         This was previously implemented for some other platforms in r58111
2258         and r116547.
2259
2260         In r122806, fast/dom/icon-url-property.html stopped using it, but
2261         it is useful for tests, so I plan to re-add it to that test again.
2262
2263         Reviewed by Jochen Eisinger.
2264
2265         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2266         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
2267          icon change notifications from WebKit may be logged in test output.
2268         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2269         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
2270         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
2271         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
2272         (WebTestRunner):
2273         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
2274         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2275         (TestRunner):
2276         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2277         (WebTestRunner::WebTestProxyBase::didChangeIcon):
2278         (WebTestRunner):
2279         * DumpRenderTree/chromium/WebViewHost.cpp:
2280         (WebViewHost::didChangeIcon): Add the output about changing the icon.
2281         * DumpRenderTree/chromium/WebViewHost.h:
2282         (WebViewHost):
2283
2284 2013-03-18  Julie Parent  <jparent@chromium.org>
2285
2286         Cleanup: Move js for treemap and aggregate_results into own js files.
2287         https://bugs.webkit.org/show_bug.cgi?id=112618
2288
2289         Reviewed by Dirk Pranke.
2290         
2291         No functional changes, just moving the code into separate js file
2292         rather than inlined in the html, so we can test it, make it more
2293         modular, etc.  Other dashboard types are already done this way.
2294
2295         * TestResultServer/static-dashboards/aggregate_results.html:
2296         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
2297         (generatePage):
2298         (handleValidHashParameter):
2299         (htmlForBuilder):
2300         (rawValuesHTML):
2301         (chartHTML):
2302         (filteredValues):
2303         (chart):
2304         (htmlForRevisionRows):
2305         (wrapHTMLInTable):
2306         (htmlForSummaryTable):
2307         (valuesPerExpectation):
2308         (htmlForTestType):
2309         (htmlForTableRow):
2310         (extendedEncode):
2311         * TestResultServer/static-dashboards/treemap.html:
2312         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
2313         (humanReadableTime):
2314         (convertToWebTreemapFormat):
2315         (reverseSortByAverage):
2316         (generatePage):
2317         (focusPath):
2318         (.switch.return):
2319         (handleQueryParameterChange):
2320         (extractName):
2321         (fullName):
2322         (handleFocus.):
2323         (handleFocus):
2324
2325 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2326
2327         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
2328         https://bugs.webkit.org/show_bug.cgi?id=112622
2329
2330         Reviewed by Dirk Pranke.
2331
2332         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2333         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
2334
2335 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2336
2337         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
2338         https://bugs.webkit.org/show_bug.cgi?id=112619
2339
2340         Reviewed by Dirk Pranke.
2341
2342         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
2343         directory and then fall back to the generic LayoutTests/platform/gtk directory.
2344
2345         * Scripts/webkitpy/layout_tests/port/gtk.py:
2346         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
2347         Port._webkit_baseline_path method.
2348         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2349         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
2350         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
2351         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2352         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
2353         that are expected based on the builder name.
2354
2355 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
2356
2357         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
2358         https://bugs.webkit.org/show_bug.cgi?id=112571
2359
2360         Reviewed by Adam Barth.
2361
2362         Update function declarations for new WebFileSystemType enum. (All
2363         changes are behind an #ifdef so we can sync required changes in embedders.)
2364
2365         * DumpRenderTree/chromium/WebViewHost.cpp:
2366         (WebViewHost::openFileSystem):
2367         (WebViewHost::deleteFileSystem):
2368         * DumpRenderTree/chromium/WebViewHost.h:
2369         (WebViewHost):
2370
2371 2013-03-18  Julie Parent  <jparent@chromium.org>
2372
2373         Cleanup: Move timeline_exporer js out of html file into js.
2374         https://bugs.webkit.org/show_bug.cgi?id=112188
2375
2376         Reviewed by Dirk Pranke.
2377         
2378         Moves the javascript out of the html file and into a new js file.
2379         This follows the format of flakiness_dashboard.{html|js}.
2380         
2381         Also moves code from dashboard_base that is used only by this one
2382         dashboard, and makes it private to the dashboard.
2383
2384         * TestResultServer/static-dashboards/dashboard_base.js:
2385         * TestResultServer/static-dashboards/timeline_explorer.html:
2386         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
2387         (generatePage):
2388         (initCurrentBuilderTestResults):
2389         (shouldShowWebKitRevisionsOnly):
2390         (updateTimelineForBuilder.):
2391         (updateTimelineForBuilder):
2392         (selectBuild):
2393         (updateBuildIndicator):
2394         (.addRow):
2395         (.addNumberRow):
2396         (.inspectorNode.getElementsByTagName.0.onclick):
2397         (.inspectorNode.getElementsByTagName.1.onclick):
2398         (.inspectorNode.getElementsByTagName.2.onclick):
2399         (updateBuildInspector):
2400         (showResultsDelta):
2401         (decompressResults.addFlakyDelta):
2402         (decompressResults):
2403
2404 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2405
2406         Unreviewed, rolling out r145272.
2407         http://trac.webkit.org/changeset/145272
2408         https://bugs.webkit.org/show_bug.cgi?id=111884
2409
2410         Turns out the ASAN build is still broken; possibly there's
2411         something still setting LD_LIBRARY_PATH, or possibly there's
2412         something else wrong. In the meantime, we need it to work again.
2413
2414         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2415
2416 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2417
2418         delete-stale-build-files is too aggressive
2419         https://bugs.webkit.org/show_bug.cgi?id=112595
2420
2421         Reviewed by Tim Horton.
2422
2423         It appears that whitelisting file extensions to keep is not a good idea.
2424         Blacklist files to delete instead, and only delete .o files for now.
2425         We can add more file extensions as needed.
2426
2427         * BuildSlaveSupport/delete-stale-build-files:
2428
2429 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2430
2431         Disable accessibility notifications after each test
2432         https://bugs.webkit.org/show_bug.cgi?id=112579
2433
2434         Reviewed by Tim Horton.
2435         
2436         In WebKitTestRunner, if any tests triggered accessibility notifications,
2437         the global notification handler would thereafter be active, and fire
2438         notifications for all subsequent tests.
2439         
2440         Fix by implementing AccessibilityController::resetToConsistentState() for
2441         Mac, and using it to clear the global notification handler.
2442
2443         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2444         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2445         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
2446         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
2447         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
2448         (e.g. because of -autorelease).
2449         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
2450         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
2451         if there is one.
2452         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
2453         Add -stopObserving
2454         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2455         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
2456         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
2457         center.
2458
2459 2013-03-18  Dana Jansens  <danakj@chromium.org>
2460
2461         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
2462         https://bugs.webkit.org/show_bug.cgi?id=112392
2463
2464         Reviewed by James Robinson.
2465
2466         Removes the command line flag option from DRT.
2467
2468         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2469         (main):
2470
2471 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2472
2473         [GTK] plugins/plugin-clip-subframe.html is failing
2474         https://bugs.webkit.org/show_bug.cgi?id=112570
2475
2476         Reviewed by Martin Robinson.
2477
2478         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
2479
2480 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
2481
2482         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
2483         https://bugs.webkit.org/show_bug.cgi?id=112442
2484
2485         Reviewed by Gustavo Noronha Silva.
2486
2487         * GtkLauncher/main.c:
2488         (reloadCb):
2489         (createToolbar):
2490         (createWindow):
2491
2492 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2493
2494         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
2495         https://bugs.webkit.org/show_bug.cgi?id=112205
2496
2497         Disable this API test until Geoff can fix it.
2498
2499         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2500         (TestWebKitAPI::TEST):
2501
2502 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
2503
2504         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2505         https://bugs.webkit.org/show_bug.cgi?id=112478
2506
2507         Reviewed by Tony Chang.
2508
2509         There is nothing that ensures that the log messages from the plugin
2510         come in before the layout test finished loading.
2511
2512         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2513         (PassDifferentNPPStruct::NPP_SetWindow):
2514         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2515         (NPP_SetWindow):
2516
2517 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2518
2519         Have the mac port support per_test_timeout in webkitpy
2520         https://bugs.webkit.org/show_bug.cgi?id=112466
2521
2522         Reviewed by Dirk Pranke.
2523         
2524         Both WTR and DRT handle --timeout arguments, so we can
2525         have the scripts pass the timeout values down to the tools.
2526
2527         * Scripts/webkitpy/layout_tests/port/mac.py:
2528         (MacPort.supports_per_test_timeout):
2529
2530 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
2531
2532         Remove setAsynchronousSpellCheckingEnabled from test runners
2533         https://bugs.webkit.org/show_bug.cgi?id=112362
2534
2535         Reviewed by Tony Chang.
2536
2537         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
2538         in internals.settings, so all ports can share it.
2539
2540         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2541         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2542         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2543         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2544         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2545         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2546         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2547         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
2548         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2549         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
2550         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2551         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2552
2553 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2554
2555         Fix the stupid unit tests.
2556
2557         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2558         (test_sample_process):
2559
2560 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
2561
2562         Collect samples for unresponsive web processes
2563         https://bugs.webkit.org/show_bug.cgi?id=112409
2564
2565         Reviewed by Tim Horton.
2566         
2567         When we detect that a subprocess was unresponsive, run the 'sample'
2568         tool on that process, for the Mac port.
2569         
2570         The sample will be linked to from the results.html page, next
2571         to the crash log link.
2572
2573         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2574         (Manager._look_for_new_crash_logs): Before looking for crash logs,
2575         look for samples on disk.
2576         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2577         (TestResultWriter):
2578         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
2579         -sample.txt files, and have it copy their contents to a new file
2580         next to the test that spawned them (as we do for crash logs).
2581         * Scripts/webkitpy/layout_tests/port/base.py:
2582         (Port.look_for_new_samples): Base class does nothing for sampling.
2583         * Scripts/webkitpy/layout_tests/port/driver.py:
2584         (Driver._check_for_driver_crash): Kick off a sample if we detected
2585         that the subprocess was unresponsive.
2586         * Scripts/webkitpy/layout_tests/port/mac.py:
2587         (MacPort.sample_file_path): Utility to generate the file path
2588         to the generated sample files at the top level of layout-test-results.
2589         (MacPort.look_for_new_crash_logs): Fix typo
2590         (MacPort.look_for_new_samples): New function to find sample files.
2591         (MacPort.sample_process): Use the utility function to get the file path.
2592
2593 2013-03-15  Zeno Albisser  <zeno@webkit.org>
2594
2595         [Qt] Remove simple getters and setters from TestRunnerQt
2596         https://bugs.webkit.org/show_bug.cgi?id=112343
2597
2598         Reviewed by Benjamin Poulain.
2599
2600         The removed functions and boolean members
2601         are being replaced by the implementations in the
2602         generic TestRunner.h.
2603
2604         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2605         (DumpRenderTree::dumpFrameScrollPosition):
2606         (DumpRenderTree::dumpFramesAsText):
2607         (DumpRenderTree::dump):
2608         (DumpRenderTree::titleChanged):
2609         (DumpRenderTree::dumpDatabaseQuota):
2610         (DumpRenderTree::dumpApplicationCacheQuota):
2611         (DumpRenderTree::statusBarMessage):
2612         (DumpRenderTree::createWindow):
2613         * DumpRenderTree/qt/TestRunnerQt.cpp:
2614         (TestRunnerQt::reset):
2615         * DumpRenderTree/qt/TestRunnerQt.h:
2616         (TestRunnerQt):
2617
2618 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
2619
2620         Update the link on build.webkit.org to refer to perf.webkit.org
2621         https://bugs.webkit.org/show_bug.cgi?id=112416
2622
2623         Reviewed by Philip Rogers.
2624
2625         Updated the link. Also updated the template to use HTML5 DOCTYPE.
2626
2627         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2628
2629 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
2630
2631         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
2632         https://bugs.webkit.org/show_bug.cgi?id=112394
2633
2634         Reviewed by Philippe Normand.
2635
2636         * GtkLauncher/main.c:
2637         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
2638
2639 2013-03-14  Andreas Kling  <akling@apple.com>
2640
2641         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
2642         <http://webkit.org/b/111815>
2643         <rdar://problem/13380145>
2644
2645         Reviewed by Anders Carlsson.
2646
2647         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
2648         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
2649         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
2650
2651         * WebKitTestRunner/PlatformWebView.h:
2652         (PlatformWebView):
2653         * WebKitTestRunner/TestController.cpp:
2654         (WTR::TestController::createOtherPage):
2655         (WTR::TestController::createWebViewWithOptions):
2656         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2657         (WTR::PlatformWebView::didInitializeClients):
2658
2659 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2660
2661         [EFL][MiniBrowser] Add a search field to the MiniBrowser
2662         https://bugs.webkit.org/show_bug.cgi?id=112122
2663
2664         Reviewed by Kenneth Rohde Christiansen.
2665
2666         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
2667
2668         * MiniBrowser/efl/main.c:
2669         (_Browser_Window):
2670         (search_box_show):
2671         (search_box_hide):
2672         (on_key_down):
2673         (on_url_changed):
2674         (on_search_field_aborted):
2675         (on_search_field_activated):
2676         (on_search_field_clicked):
2677         (on_search_backward_button_clicked):
2678         (on_search_forward_button_clicked):
2679         (window_create):
2680
2681 2013-03-14  Julie Parent  <jparent@chromium.org>
2682
2683         Cleanup: Remove g_resourceLoader.
2684         https://bugs.webkit.org/show_bug.cgi?id=112305
2685
2686         Reviewed by Dirk Pranke.
2687         
2688         Removing another global.
2689         
2690         Now, each dashboard creates its own loader, rather than having
2691         a general global one.
2692         
2693         Remove usage of g_resourceLoader.isLoadingComplete from 
2694         handleLocationChange by ensuring that handleLocationChange is
2695         never called before the loader is done.  It was called in two
2696         places before: 1 was from the callback when the loader is done,
2697         so that was obviously true, and the other was from onhashchange,
2698         where it would just return rather than running.  Instead, lets
2699         only register the onhashchange handler once the loader is
2700         setup, so the check is no longer necessary.
2701         
2702         Remove isLoadingComplete since it is now unused.
2703         
2704         Callback for loader is now initializeHistory, rather than just
2705         handleLocationChange which will set up the hashchange handler now.
2706         This will all eventually be moving to a new History object.
2707
2708         * TestResultServer/static-dashboards/aggregate_results.html:
2709         * TestResultServer/static-dashboards/dashboard_base.js:
2710         (handleLocationChange):
2711         (intializeHistory):
2712         (decompressResults):
2713         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2714         (generatePage):
2715         * TestResultServer/static-dashboards/loader.js:
2716         (.):
2717         * TestResultServer/static-dashboards/loader_unittests.js:
2718         * TestResultServer/static-dashboards/timeline_explorer.html:
2719         * TestResultServer/static-dashboards/treemap.html:
2720
2721 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
2722
2723         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
2724         https://bugs.webkit.org/show_bug.cgi?id=109404
2725
2726         Reviewed by Tony Chang.
2727
2728         Removes all the code related to smartInsertDeleteEnabled and
2729         selectTrailingWhitespaceEnabled settings as they will be managed from
2730         internals from now on.
2731
2732         * DumpRenderTree/TestRunner.cpp:
2733         (TestRunner::staticFunctions):
2734         * DumpRenderTree/TestRunner.h:
2735         (TestRunner):
2736         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2737         (WebKit):
2738         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2739         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2740         (DumpRenderTree):
2741         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2742         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2743         (WebTestRunner::WebTestProxy::didStopLoading):
2744         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2745         (WebTestRunner::TestRunner::TestRunner):
2746         (WebTestRunner::TestRunner::reset):
2747         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2748         (TestRunner):
2749         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2750         (WebTestRunner::WebPreferences::applyTo): Set default values for
2751         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
2752         Chromium DRT default values are different from Chromium browser.
2753         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2754         * DumpRenderTree/chromium/WebViewHost.cpp:
2755         * DumpRenderTree/chromium/WebViewHost.h:
2756         (WebViewHost):
2757         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2758         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2759         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2760         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2761         (resetDefaultsToConsistentValues):
2762         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2763         * DumpRenderTree/mac/DumpRenderTree.mm:
2764         (resetWebViewToConsistentStateBeforeTesting):
2765         * DumpRenderTree/mac/TestRunnerMac.mm:
2766         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2767         (WebCore::WebPage::resetSettings):
2768         * DumpRenderTree/qt/TestRunnerQt.cpp:
2769         * DumpRenderTree/qt/TestRunnerQt.h:
2770         (TestRunnerQt):
2771         * DumpRenderTree/win/DumpRenderTree.cpp:
2772         (resetWebViewToConsistentStateBeforeTesting):
2773         * DumpRenderTree/win/TestRunnerWin.cpp:
2774         * DumpRenderTree/wx/TestRunnerWx.cpp:
2775
2776 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2777
2778         [Qt] Disable DRT on Windows
2779
2780         Reviewed by Jocelyn Turcotte.
2781
2782         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
2783
2784         * qmake/mkspecs/features/configure.prf:
2785
2786 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2787
2788         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
2789         https://bugs.webkit.org/show_bug.cgi?id=110728
2790
2791         Reviewed by Gyuyoung Kim.
2792
2793         Use the page group to create the view object.
2794
2795         * MiniBrowser/efl/main.c:
2796         (window_create):
2797
2798 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2799
2800         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
2801
2802         Reviewed by Tor Arne Vestbø.
2803
2804         The mock versions of these web facing features should be instantiated when
2805         running in DumpRenderTree only. In order for them to work, no extra Qt modules
2806         such as QtLocation are actually needed.
2807
2808         This patch decouples enabling device orientation/motion and geolocation from
2809         the underlying Qt modules and makes them available in developer builds
2810         (!production_build) and backed by mock backends when running in drt.
2811
2812         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
2813         developers the web facing features are always enabled (although requests will
2814         time out) and the mock backends are enabled inside DRT, allowing for the layout
2815         tests to run with less dependencies.
2816
2817         In addition this also enables the mock device motion client, which was
2818         previously never instantiated.
2819
2820         * qmake/mkspecs/features/features.prf:
2821
2822 2013-03-14  Zeno Albisser  <zeno@webkit.org>
2823
2824         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
2825         https://bugs.webkit.org/show_bug.cgi?id=112340
2826
2827         Reviewed by Simon Hausmann.
2828
2829         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2830         (DumpRenderTree::dump):
2831             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
2832         (DumpRenderTree::dumpApplicationCacheQuota):
2833         * DumpRenderTree/qt/TestRunnerQt.cpp:
2834         (TestRunnerQt::reset):
2835         * DumpRenderTree/qt/TestRunnerQt.h:
2836         (TestRunnerQt):
2837
2838 2013-03-14  Zeno Albisser  <zeno@webkit.org>
2839
2840         [Qt] Port DRT to use TestRunner::dumpAsText()
2841         https://bugs.webkit.org/show_bug.cgi?id=112260
2842
2843         Reviewed by Benjamin Poulain.
2844
2845         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2846         (WebCore::DumpRenderTree::open):
2847         (WebCore::methodNameStringForFailedTest):
2848             Change parameter from type TestRunnerQt* to TestRunner*.
2849         (WebCore::DumpRenderTree::dump):
2850             TestRunnerQt::shouldDumpPixels() always returned true in our case.
2851             Instead we should rely on TestRunner::generatePixelResults().
2852         * DumpRenderTree/qt/TestRunnerQt.cpp:
2853         (TestRunnerQt::reset):
2854         * DumpRenderTree/qt/TestRunnerQt.h:
2855         (TestRunnerQt):
2856
2857 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
2858
2859         Implement FontLoader interface
2860         https://bugs.webkit.org/show_bug.cgi?id=98395
2861
2862         Reviewed by Eric Seidel.
2863
2864         Enable FontLoadEvents runtime flag for TestShell.
2865
2866         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2867         (WebTestRunner::TestInterfaces::TestInterfaces):
2868
2869 2013-03-13  Julie Parent  <jparent@chromium.org>
2870
2871         CLeanup: remove unnecessary call to parseParameters.
2872         https://bugs.webkit.org/show_bug.cgi?id=112309
2873
2874         Reviewed by Ojan Vafai.
2875         
2876         We call parseCrossDashboardParameters when the dashboard initially
2877         loads to set the state required for loadBuildersList, and then we
2878         call it again once we are fully done with loading, so there is no
2879         reason to call it in the middle of the loading process here.
2880
2881         * TestResultServer/static-dashboards/loader.js:
2882         (.):
2883
2884 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
2885
2886         Unreviewed. Now I'm a reviewer :)
2887
2888         * Scripts/webkitpy/common/config/committers.py:
2889
2890 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
2891
2892         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
2893         https://bugs.webkit.org/show_bug.cgi?id=112277
2894
2895         Reviewed by Adam Barth.
2896
2897         * Scripts/webkitperl/FeatureList.pm:
2898         * qmake/mkspecs/features/features.pri:
2899
2900 2013-03-13  Adam Barth  <abarth@webkit.org>
2901
2902         run-perf-tests should support content_shell
2903         https://bugs.webkit.org/show_bug.cgi?id=112291
2904
2905         Reviewed by Eric Seidel.
2906
2907         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2908         (PerfTestsRunner._parse_args):
2909
2910 2013-03-13  Oliver Hunt  <oliver@apple.com>
2911
2912         Simplify Checked<> multiplication
2913         https://bugs.webkit.org/show_bug.cgi?id=112286
2914
2915         Reviewed by James Robinson.
2916
2917         Add tests for multiplication by zero and max to ensure we don't
2918         mess them up should we ever make changes to Checked<> in future.
2919
2920         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2921         (TestWebKitAPI):
2922
2923 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2924
2925         [Qt] Unreviewed prospective Windows build fix
2926
2927         Do the usual thing, include the moc generated code in the .cpp file instead
2928         of compiling it standalone, to ensure that config.h is included, too, and
2929         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
2930
2931         * DumpRenderTree/qt/EventSenderQt.cpp:
2932
2933 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2934
2935         [Qt] Port TestRunner::findString to shared interface
2936         https://bugs.webkit.org/show_bug.cgi?id=112147
2937
2938         Reviewed by Jocelyn Turcotte.
2939
2940         This patch also removes DumpRenderTree and some other helper classes from
2941         the WebCore namespace, to which they do not really belong.
2942
2943         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2944         (main):
2945         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2946         (DumpRenderTree::DumpRenderTree):
2947         (DumpRenderTree::~DumpRenderTree):
2948         (DumpRenderTree::instance):
2949         (DumpRenderTree::setShouldTimeout):
2950         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2951         (DumpRenderTree):
2952         * DumpRenderTree/qt/EventSenderQt.cpp:
2953         (EventSender::contextClick):
2954         (EventSender::sendEvent):
2955         (EventSender::postEvent):
2956         * DumpRenderTree/qt/EventSenderQt.h:
2957         (EventSender::isGraphicsBased):
2958         * DumpRenderTree/qt/TestRunnerQt.cpp:
2959         (TestRunnerQt::TestRunnerQt):
2960         (TestRunner::findString):
2961         (TestRunnerQt::setMockDeviceOrientation):
2962         (TestRunnerQt::setGeolocationPermission):
2963         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
2964         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
2965         (TestRunnerQt::setMockGeolocationPosition):
2966         * DumpRenderTree/qt/TestRunnerQt.h:
2967         (TestRunnerQt):
2968
2969 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
2970
2971         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
2972         https://bugs.webkit.org/show_bug.cgi?id=112129
2973
2974         Reviewed by Adam Barth.
2975
2976         Following Chromium
2977         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
2978         this is being renamed to better explain what it does.
2979
2980         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2981
2982 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2983
2984         [Qt] Unreviewed trivial typo fix
2985
2986         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
2987         TextRunner.h. Thanks Zeno :)
2988
2989 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
2990
2991         [Qt] Prepare DRT for transition to shared TestRunner interface
2992         https://bugs.webkit.org/show_bug.cgi?id=112144
2993
2994         Reviewed by Benjamin Poulain.
2995
2996         Prepare Qt's DRT for a transition from the QObject based TestRunner to
2997         the JSC C API based one.
2998
2999         This is impplemented by instantiating the QObject based testRunner in
3000         the global object, then instantiating the JSC C based TestRunner
3001         separately and placing it "behind" the QObject based testRunner through
3002         injection of the individual functions through proxies. (prototype
3003         chaining doesn't work due to the this object and Function.prototype.bind
3004         doesn't work due to the native function)
3005
3006         This allows for porting over method by method by removing the method
3007         from the QObject TestRunnerQt and implementing it in the JSC C based
3008         TestRunner.
3009
3010         In order for this to link and run dummy implementations of all the
3011         necessary TestRunner functions are provided.
3012
3013         * DumpRenderTree/qt/DumpRenderTree.pro:
3014         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3015         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3016         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3017         (WebCore::DumpRenderTree::initJSObjects):
3018         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3019         (DumpRenderTree):
3020         * DumpRenderTree/qt/TestRunnerQt.cpp:
3021         (TestRunner::~TestRunner):
3022         (TestRunner::addDisallowedURL):
3023         (TestRunner::queueLoad):
3024         (TestRunner::removeAllVisitedLinks):
3025         (TestRunner::setAcceptsEditing):
3026         (TestRunner::simulateLegacyWebNotificationClick):
3027         (TestRunner::setWindowIsKey):
3028         (TestRunner::setAlwaysAcceptCookies):
3029         (TestRunner::addOriginAccessWhitelistEntry):
3030         (TestRunner::setWebViewEditable):
3031         (TestRunner::clearAllApplicationCaches):
3032         (TestRunner::setTextDirection):
3033         (TestRunner::notifyDone):
3034         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3035         (TestRunner::overridePreference):
3036         (TestRunner::pathToLocalResource):
3037         (TestRunner::removeAllWebNotificationPermissions):
3038         (TestRunner::simulateWebNotificationClick):
3039         (TestRunner::closeIdleLocalStorageDatabases):
3040         (TestRunner::focusWebView):
3041         (TestRunner::setBackingScaleFactor):
3042         (TestRunner::removeChromeInputField):
3043         (TestRunner::addChromeInputField):
3044         (TestRunner::originsWithLocalStorage):
3045         (TestRunner::deleteAllLocalStorage):
3046         (TestRunner::deleteLocalStorageForOrigin):
3047         (TestRunner::observeStorageTrackerNotifications):
3048         (TestRunner::syncLocalStorage):
3049         (TestRunner::windowCount):
3050         (TestRunner::setWaitToDump):
3051         (TestRunner::waitForPolicyDelegate):
3052         (TestRunner::webHistoryItemCount):
3053         (TestRunner::showWebInspector):
3054         (TestRunner::closeWebInspector):
3055         (TestRunner::evaluateInWebInspector):
3056         (TestRunner::setSerializeHTTPLoads):
3057         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3058         (TestRunner::setCustomPolicyDelegate):
3059         (TestRunner::setDatabaseQuota):
3060         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3061         (TestRunner::resetPageVisibility):
3062         (TestRunner::keepWebHistory):
3063         (TestRunner::goBack):
3064         (TestRunner::originsWithApplicationCache):
3065         (TestRunner::applicationCacheDiskUsageForOrigin):
3066         (TestRunner::display):
3067         (TestRunner::dispatchPendingLoadRequests):
3068         (TestRunner::clearPersistentUserStyleSheet):
3069         (TestRunner::callShouldCloseOnWebView):
3070         (TestRunner::copyDecodedHostName):
3071         (TestRunner::clearBackForwardList):
3072         (TestRunner::clearAllDatabases):
3073         (TestRunner::clearApplicationCacheForOrigin):
3074         (TestRunner::apiTestGoToCurrentBackForwardItem):
3075         (TestRunner::authenticateSession):
3076         (TestRunner::abortModal):
3077         (TestRunner::setStorageDatabaseIdleInterval):
3078         (TestRunner::setAsynchronousSpellCheckingEnabled):
3079         (TestRunner::setXSSAuditorEnabled):
3080         (TestRunner::setSpatialNavigationEnabled):
3081         (TestRunner::setScrollbarPolicy):
3082         (TestRunner::setJavaScriptCanAccessClipboard):
3083         (TestRunner::setAutomaticLinkDetectionEnabled):
3084         (TestRunner::setUserStyleSheetEnabled):
3085         (TestRunner::setUserStyleSheetLocation):
3086         (TestRunner::setUseDashboardCompatibilityMode):
3087         (TestRunner::setTabKeyCyclesThroughElements):
3088         (TestRunner::setSmartInsertDeleteEnabled):
3089         (TestRunner::setSelectTrailingWhitespaceEnabled):
3090         (TestRunner::setPrivateBrowsingEnabled):
3091         (TestRunner::setPluginsEnabled):
3092         (TestRunner::setPopupBlockingEnabled):
3093         (TestRunner::setMockSpeechInputDumpRect):
3094         (TestRunner::setPersistentUserStyleSheetLocation):
3095         (TestRunner::setMockGeolocationPosition):
3096         (TestRunner::setMockGeolocationPositionUnavailableError):
3097         (TestRunner::setMockDeviceOrientation):
3098         (TestRunner::setMainFrameIsFirstResponder):
3099         (TestRunner::setIconDatabaseEnabled):
3100         (TestRunner::setGeolocationPermission):
3101         (TestRunner::setDefersLoading):
3102         (TestRunner::setCacheModel):
3103         (TestRunner::setAuthorAndUserStylesEnabled):
3104         (TestRunner::setAllowFileAccessFromFileURLs):
3105         (TestRunner::setAppCacheMaximumSize):
3106         (TestRunner::setAllowUniversalAccessFromFileURLs):
3107         (TestRunner::setApplicationCacheOriginQuota):
3108         (TestRunner::denyWebNotificationPermission):
3109         (TestRunner::grantWebNotificationPermission):
3110         (TestRunner::setValueForUser):
3111         (TestRunner::setViewModeMediaFeature):
3112         (TestRunner::setPageVisibility):
3113         (TestRunner::addMockSpeechInputResult):
3114         (TestRunner::removeOriginAccessWhitelistEntry):
3115         (TestRunner::addUserScript):
3116         (TestRunner::isCommandEnabled):
3117         (TestRunner::evaluateScriptInIsolatedWorld):
3118         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3119         (TestRunner::copyEncodedHostName):
3120         (TestRunner::addUserStyleSheet):
3121         (TestRunner::findString):
3122         (TestRunner::execCommand):
3123         (TestRunner::localStorageDiskUsageForOrigin):
3124
3125 2013-03-12  Julie Parent  <jparent@chromium.org>
3126
3127         Cleanup: Move flatten-trie to loader.
3128         https://bugs.webkit.org/show_bug.cgi?id=112196
3129
3130         Reviewed by Dirk Pranke.
3131
3132         flatten-trie is used only by the loader, so move it there and make it
3133         private, rather than global in dashbaord_base. Moved the corresponding
3134         unit test from flakiness_dashboard_unittests to loader_unittests.
3135         
3136         * TestResultServer/static-dashboards/dashboard_base.js:
3137         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3138         * TestResultServer/static-dashboards/loader.js:
3139         (.):
3140         * TestResultServer/static-dashboards/loader_unittests.js:
3141
3142 2013-03-12  Oliver Hunt  <oliver@apple.com>
3143
3144         Unbreak api tests
3145
3146         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3147         (TestWebKitAPI):
3148
3149 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3150
3151         Unreviewed, disabling tests for Win EWS.
3152
3153         win-ews obviously cannot keep up with running tests, it's >300 behind.
3154         Probably doesn't help that its (likely) running tests serially.
3155
3156         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3157         (WinEWS):
3158
3159 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3160
3161         Add a --build-directory argument to delete-stale-build-files
3162         https://bugs.webkit.org/show_bug.cgi?id=112198
3163
3164         Reviewed by Ryosuke Niwa.
3165
3166         * BuildSlaveSupport/delete-stale-build-files:
3167         (main): Add --build-directory argument.
3168
3169 2013-03-12  Oliver Hunt  <oliver@apple.com>
3170
3171         Appease MSVC
3172
3173         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3174         (TestWebKitAPI):
3175
3176 2013-03-12  Oliver Hunt  <oliver@apple.com>
3177
3178         Add more Checked<> tests
3179         https://bugs.webkit.org/show_bug.cgi?id=112190
3180
3181         Reviewed by Geoffrey Garen.
3182
3183         Tests!
3184
3185         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3186         (TestWebKitAPI):
3187
3188 2013-03-12  Julie Parent  <jparent@chromium.org>
3189
3190         Cleanup: Move loading complete function into callback, rather than global.
3191         https://bugs.webkit.org/show_bug.cgi?id=112167
3192
3193         Reviewed by Dirk Pranke.
3194         
3195         Stop calling global functions, pass in proper handler to Loader
3196         constructor. Note that the callback is optional, as tests, and
3197         some potential dashboards, do not need one.
3198
3199         * TestResultServer/static-dashboards/dashboard_base.js:
3200         * TestResultServer/static-dashboards/loader.js:
3201         (.):
3202         * TestResultServer/static-dashboards/loader_unittests.js:
3203
3204 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3205
3206         [EFL][WK2] Add popup menu support to MiniBrowser
3207         https://bugs.webkit.org/show_bug.cgi?id=108934
3208
3209         Reviewed by Kenneth Rohde Christiansen.
3210
3211         Implement popup menu support in MiniBrowser by handling popup_menu_show
3212         and popup_menu_hide smart functions on the view and using the Ewk popup
3213         menu API.
3214
3215         * MiniBrowser/efl/main.c:
3216         (_Browser_Window):
3217         (on_popup_menu_discarded):
3218         (on_popup_menu_item_clicked):
3219         (popup_menu_populate):
3220         (on_popup_menu_show):
3221         (on_popup_menu_hide):
3222         (window_create): Use calloc() instead of malloc() to allocate memory for
3223         Browser_Window. This makes sure all the structs members are initialized
3224         to 0 (such as the new elm_popup_menu pointer).
3225
3226 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3227
3228         [GTK] Set up the libPlatformGtk.la library
3229         https://bugs.webkit.org/show_bug.cgi?id=111738
3230
3231         Reviewed by Martin Robinson.
3232
3233         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3234         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
3235         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3236
3237 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3238
3239         [GTK] Enable Web Audio in development builds
3240         https://bugs.webkit.org/show_bug.cgi?id=111831
3241
3242         Reviewed by Philippe Normand.
3243
3244         Web Audio is already quite well supported on the GTK port but still has a few issues
3245         that must be addressed before it is enabled by default. Despite that it should be enabled
3246         in development builds just so we are up-to-date with future feature infrastructure changes.
3247         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3248         that's an obvious goal before enabling the feature in release builds.
3249
3250         * Scripts/webkitperl/FeatureList.pm:
3251
3252 2013-03-11  Andreas Kling  <akling@apple.com>
3253
3254         [Mac][WK1] Add support for alert() in MiniBrowser.
3255         <http://webkit.org/b/112090>
3256
3257         Reviewed by Anders Carlsson.
3258
3259         * MiniBrowser/mac/WK1BrowserWindowController.m:
3260         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3261
3262 2013-03-11  Julie Parent  <jparent@chromium.org>
3263
3264         Dashboard cleanup: Create ui.Errors
3265         https://bugs.webkit.org/show_bug.cgi?id=111785
3266
3267         Reviewed by Ojan Vafai.
3268         
3269         Create ui.Errors for handling errors the dashboards
3270         encounter. Loader now has a Error object that it can add to,
3271         and individual dashboards can show errors when desired.
3272         Currently, only flakiness_db shows errors, but this is 
3273         generic and there is no reason why other dbs wouldn't want to
3274         show errors.
3275
3276         * TestResultServer/static-dashboards/dashboard_base.js:
3277         (resourceLoadingComplete):
3278         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3279         (generatePage):
3280         * TestResultServer/static-dashboards/loader.js:
3281         (.):
3282         * TestResultServer/static-dashboards/ui.js:
3283         (.):
3284
3285 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
3286
3287         Some StringHasher tests are broken because of missing null termination
3288         https://bugs.webkit.org/show_bug.cgi?id=111284
3289
3290         Reviewed by Darin Adler.
3291
3292         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3293         (TestWebKitAPI): Added null termination since C strings are null-terminated.
3294         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
3295         the bug caught by it is now fixed.
3296
3297 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3298
3299         Unreviewed, rolling out r145200.
3300         http://trac.webkit.org/changeset/145200
3301         https://bugs.webkit.org/show_bug.cgi?id=112063
3302
3303         Broke a couple of unit tests (Requested by zdobersek on
3304         #webkit).
3305
3306         * Scripts/webkitperl/FeatureList.pm:
3307
3308 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
3309
3310         [GTK] WebKit2-only build fails
3311         https://bugs.webkit.org/show_bug.cgi?id=112033
3312
3313         Reviewed by Gustavo Noronha Silva.
3314
3315         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
3316         generic part, WebKit1-specific part and WebKit2-specific part.
3317         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
3318         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
3319         directly.
3320
3321 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
3322
3323         Adding myself to the committers list.
3324
3325         Unreviewed.
3326
3327         * Scripts/webkitpy/common/config/committers.py:
3328
3329 2013-03-11  Jeff Rogers  <jrogers@rim.com>
3330
3331         [BlackBerry] Disable MathML support
3332         https://bugs.webkit.org/show_bug.cgi?id=111929
3333
3334         Reviewed by Rob Buis.
3335
3336         * Scripts/webkitperl/FeatureList.pm:
3337
3338 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3339
3340         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
3341         https://bugs.webkit.org/show_bug.cgi?id=111970
3342
3343         Reviewed by Chris Fleizach.
3344
3345         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
3346         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
3347         undefined symbol.
3348
3349         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3350         (WTR::AccessibilityUIElement::supportedActions):
3351         (WTR):
3352
3353 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
3354
3355         [chromium] Android apk targets should depend directly on Java library targets
3356         https://bugs.webkit.org/show_bug.cgi?id=111746
3357
3358         Reviewed by Eric Seidel.
3359
3360         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3361         Make DumpRenderTree_apk depend directly on base_java and net_java.
3362         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3363         Make TestWebKitAPI_apk depend directly on base_java.
3364
3365 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
3366
3367         [chromium] remove obsolete user gesture methods from WebFrame
3368         https://bugs.webkit.org/show_bug.cgi?id=111696
3369
3370         Reviewed by Adam Barth.
3371
3372         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3373         (WebTestRunner::TestPlugin::handleInputEvent):
3374         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3375
3376 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
3377
3378         Unreviewed, add myself to commiters.py.
3379
3380         * Scripts/webkitpy/common/config/committers.py:
3381
3382 2013-03-08  Julie Parent  <jparent@chromium.org>
3383
3384         Cleanup: Remove dead code.
3385         https://bugs.webkit.org/show_bug.cgi?id=111900
3386
3387         Reviewed by Dirk Pranke.
3388         
3389         Treemap overrides a global function that used to be in 
3390         dashboard_base, but was removed months ago in
3391         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
3392         no caller. 
3393
3394         * TestResultServer/static-dashboards/treemap.html:
3395
3396 2013-03-08  Harald Alvestrand  <hta@chromium.org>
3397
3398         Implemented new API for RTCStatsReport object.
3399         https://bugs.webkit.org/show_bug.cgi?id=110333
3400
3401         Reviewed by Adam Barth.
3402
3403         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3404         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
3405
3406 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
3407
3408         [chromium] use custom freetype on linux asan builds again
3409         https://bugs.webkit.org/show_bug.cgi?id=111884
3410
3411         Reviewed by Tony Chang.
3412
3413         We no longer need the workaround after chromium r186540.
3414
3415         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3416
3417 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
3418
3419         Warning about the user not having edit rights on Bugzilla is confusing new contributors
3420         https://bugs.webkit.org/show_bug.cgi?id=111798
3421
3422         Reviewed by Dirk Pranke.
3423
3424         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
3425
3426         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3427
3428 2013-03-08  James Robinson  <jamesr@chromium.org>
3429
3430         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
3431         https://bugs.webkit.org/show_bug.cgi?id=111632
3432
3433         Reviewed by Adrienne Walker.
3434
3435         * DumpRenderTree/chromium/WebViewHost.cpp:
3436         (WebViewHost::initializeLayerTreeView):
3437         * DumpRenderTree/chromium/WebViewHost.h:
3438         (WebViewHost):
3439
3440 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
3441
3442         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
3443         https://bugs.webkit.org/show_bug.cgi?id=111297
3444
3445         Reviewed by Kenneth Rohde Christiansen.
3446
3447         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3448         (WTR::TestRunner::setViewModeMediaFeature):
3449
3450 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
3451
3452         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
3453         https://bugs.webkit.org/show_bug.cgi?id=111814
3454
3455         Reviewed by Ryosuke Niwa.
3456
3457         Add the needed supportedActions() attribute to WKTestRunner.
3458
3459         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3460         (WTR::AccessibilityUIElement::supportedActions):
3461         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3462         (AccessibilityUIElement):
3463         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3464         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3465         (WTR::AccessibilityUIElement::supportedActions):
3466
3467 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3468
3469         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
3470         https://bugs.webkit.org/show_bug.cgi?id=111851
3471
3472         Reviewed by Kenneth Rohde Christiansen.
3473
3474         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3475         (TestWebKitAPI::TEST):
3476
3477             Fixed WKURLRef instance leaking.
3478
3479 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3480
3481         [EFL] [WK2] Some authentication tests fail in WebKit2
3482         https://bugs.webkit.org/show_bug.cgi?id=106407
3483
3484         Reviewed by Kenneth Rohde Christiansen.
3485
3486         Add patch from upstream for libsoup 2.40 to fix several authentication
3487         test cases.
3488
3489         * efl/jhbuild.modules:
3490         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
3491
3492 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
3493
3494         [GTK] Enable Web Audio in development builds
3495         https://bugs.webkit.org/show_bug.cgi?id=111831
3496
3497         Reviewed by Philippe Normand.
3498
3499         Web Audio is already quite well supported on the GTK port but still has a few issues
3500         that must be addressed before it is enabled by default. Despite that it should be enabled
3501         in development builds just so we are up-to-date with future feature infrastructure changes.
3502         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3503         that's an obvious goal before enabling the feature in release builds.
3504
3505         * Scripts/webkitperl/FeatureList.pm:
3506
3507 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3508
3509         [chromium] delay clearing the TestRunners until the main view was deleted
3510         https://bugs.webkit.org/show_bug.cgi?id=111823
3511
3512         Reviewed by Eric Seidel.
3513
3514         During WebViewHost::shutdown, we navigate the WebView to about:blank.
3515         This may call into the test runners which assume that the delegate is
3516         always non-NULL.
3517
3518         * DumpRenderTree/chromium/TestShell.cpp:
3519         (TestShell::~TestShell):
3520
3521 2013-03-07  Alan Cutter  <alancutter@chromium.org>
3522
3523         Sheriffbot whois command can't search by full name
3524         https://bugs.webkit.org/show_bug.cgi?id=111825
3525
3526         Reviewed by Eric Seidel.
3527
3528         Allowed multiple arguments to Sheriffbot's whois command.
3529         Updated test expectations.
3530
3531         * Scripts/webkitpy/tool/bot/irc_command.py:
3532         (Whois.execute):
3533         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3534         (IRCCommandTest.test_whois):
3535
3536 2013-03-07  Nils Barth  <nbarth@chromium.org>
3537
3538         Add Nils Barth and Koji Hara to committers.py
3539         https://bugs.webkit.org/show_bug.cgi?id=111806
3540
3541         Reviewed by Eric Seidel.
3542
3543         * Scripts/webkitpy/common/config/committers.py:
3544
3545 2013-03-07  Glenn Adams  <glenn@skynav.com>
3546
3547         run-pert-tests should have a --test-runner-count option
3548         https://bugs.webkit.org/show_bug.cgi?id=111726
3549
3550         Reviewed by Ryosuke Niwa.
3551
3552         Add --test-runner-count option to run-perf-tests, with default value of 4.
3553         This option allows command line configuration of the number of times to invoke
3554         the test runner (serially, not in parallel) when running a specific test in
3555         a test set.
3556
3557         * Scripts/webkitpy/performance_tests/perftest.py:
3558         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
3559         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
3560         (PerfTest.run): Rename process_run_count to test_runner_count.
3561         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
3562         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
3563         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
3564         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
3565         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3566         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
3567         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
3568         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3569         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
3570         (MainTest.test_run_with_repeat):
3571         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
3572         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3573         (MainTest.test_default_args): Add test for default option argument values.
3574         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
3575
3576 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
3577
3578         Add myself to reviewers.py
3579         https://bugs.webkit.org/show_bug.cgi?id=111757
3580
3581         Reviewed by Eric Seidel.
3582
3583         * Scripts/webkitpy/common/config/committers.py:
3584
3585 2013-03-07  Glenn Adams  <glenn@skynav.com>
3586
3587         run-perf-tests should have a --repeat option
3588         https://bugs.webkit.org/show_bug.cgi?id=100030
3589
3590         Reviewed by Ryosuke Niwa.
3591
3592         Add --repeat option to run-perf-tests, with default value of 1. When greater
3593         than 1, runs test set specified number of times. Note that multiple runs are
3594         not aggregated for statistical purposes.
3595
3596         Incidentally fixed typo: s/suceeds/succeeds/.
3597
3598         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3599         (PerfTestsRunner._parse_args): Add repeat option.
3600         (PerfTestsRunner.run): Add outer repeat loop.
3601         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
3602         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
3603         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3604         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
3605         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
3606         (MainTest.test_run_with_json_output): Fix typo.
3607         (MainTest.test_run_with_description): Fix typo.
3608         (MainTest.test_run_respects_no_results): Fix typo.
3609         (MainTest.test_run_with_slave_config_json): Fix typo.
3610         (MainTest.test_run_with_multiple_repositories): Fix typo.
3611         (MainTest.test_run_with_upload_json): Fix typo.
3612         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
3613         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
3614         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3615         (MainTest.test_parse_args): Add test for repeat option parsing.
3616
3617 2013-03-07  Julie Parent  <jparent@chromium.org>
3618
3619         showAllRuns checkbox no longer works on the stats dashboard
3620         https://bugs.webkit.org/show_bug.cgi?id=111673
3621
3622         Reviewed by Ojan Vafai.
3623
3624         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
3625         so we were trying to index into an undefined object.
3626         
3627         * TestResultServer/static-dashboards/dashboard_base.js:
3628         (invalidateQueryParameters):
3629
3630 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
3631
3632         [Chromium] Update #include for WebStorageNamespace.h
3633         https://bugs.webkit.org/show_bug.cgi?id=111748
3634
3635         Reviewed by Adam Barth.
3636
3637         In anticipation of removing
3638         WK/chromium/public/WebStorageNamespace.h (once downstream
3639         references have been updated)
3640
3641         * DumpRenderTree/chromium/WebViewHost.cpp:
3642
3643 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3644
3645         run-perf-tests fails due to svn_revision not working on a pure git clone
3646         https://bugs.webkit.org/show_bug.cgi?id=110839
3647
3648         Reviewed by Ryosuke Niwa.
3649
3650         Previously we would call git svn find-rev to look up the commit for
3651         a given revision, and that'll hang in a pure git checkout.
3652
3653         This patch changes the way we look up svn revisions in a git
3654         repository to use git log --grep 'git-svn-id', which is much faster
3655         than grepping ourselves. It also renames timestamp_of_latest_commit()
3656         to timestamp_of_revision() in order to accurately reflect what
3657         the method is doing. Note that this patch only changes the logic
3658         inside latest_revision() and svn_revision(). I'll file a separate
3659         bug to change git_commit_from_svn_revision().
3660
3661         This patch also contains some fixes to unit tests that had bit-rotted
3662         or were otherwise fragile, so that test-webkitpy --all would pass
3663         cleanly, and a fix to outputcapture so that
3664         test-webkitpy -p would work correctly again.
3665
3666         * Scripts/webkitpy/common/checkout/scm/git.py:
3667         (Git.svn_revision):
3668         (Git.timestamp_of_revision):
3669         * Scripts/webkitpy/common/checkout/scm/scm.py:
3670         (SCM.svn_revision):
3671         (SCM.timestamp_of_revision):
3672         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3673         (MockSCM.timestamp_of_revision):
3674         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3675         (_shared_test_commit_with_message):
3676         (test_commit_without_authorization):
3677         (test_timestamp_of_revision):
3678         * Scripts/webkitpy/common/checkout/scm/svn.py:
3679         (SVN.timestamp_of_revision):
3680         * Scripts/webkitpy/common/system/outputcapture.py:
3681           Importing unittest2 directly may not be safe if this module is
3682           imported before the autoinstaller gets a chance to set things up
3683           properly. We don't actually need unittest2 here.
3684         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3685         (PerfTestsRunner._generate_results_dict):
3686
3687 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3688
3689         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
3690         https://bugs.webkit.org/show_bug.cgi?id=111756
3691
3692         Reviewed by Kenneth Rohde Christiansen.
3693
3694         Bump libsoup to v2.40.3 to fix the regressions introduced by
3695         previous v2.40.0 bump.
3696
3697         * efl/jhbuild.modules:
3698
3699 2013-03-07  Roger Fong  <roger_fong@apple.com>
3700
3701         Re-enable Win EWS tests.
3702
3703         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3704         (WinEWS):
3705
3706 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3707
3708         [nrwt] handle corrupt http server pid files cleanly
3709         https://bugs.webkit.org/show_bug.cgi?id=111628
3710
3711         Reviewed by Eric Seidel.
3712
3713         If the pid file from a previous http server is corrupt for some
3714         reason, NRWT will just raise errors and not clean it up or recover.
3715         This patch fixes that to at least delete the pid file and
3716         not throw; not that we may still have stale http servers left on
3717         the system, since there's no way to know which pid to kill if
3718         the file was corrupted.
3719
3720         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3721         (HttpServerBase.start):
3722         (HttpServerBase.stop):
3723         (HttpServerBase._remove_pid_file):
3724         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
3725         (TestHttpServerBase):
3726         (TestHttpServerBase.test_corrupt_pid_file):
3727
3728 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
3729
3730         AX: Can't activate links with VoiceOver in Safari
3731         https://bugs.webkit.org/show_bug.cgi?id=111755
3732
3733         Reviewed by Tim Horton.
3734
3735         * DumpRenderTree/AccessibilityUIElement.cpp:
3736         (supportedActionsCallback):
3737         (AccessibilityUIElement::getJSClass):
3738         * DumpRenderTree/AccessibilityUIElement.h:
3739         (AccessibilityUIElement):
3740         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3741         (AccessibilityUIElement::supportedActions):
3742
3743 2013-03-07  Roger Fong  <roger_fong@apple.com>
3744
3745         Windows debug layout tests are crashing like crazy again.
3746         Disable tests on Win EWS bots temporarily.
3747
3748         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3749         (WinEWS):
3750
3751 2013-03-07  Roger Fong  <roger_fong@apple.com>
3752
3753         Make EWS bots build and test in release.
3754
3755         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3756         (WinEWS):
3757         * Scripts/webkitpy/tool/steps/runtests.py:
3758         (RunTests.run):
3759
3760 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3761
3762         [chromium] don't track the top loading frame if no layout test is currently running
3763         https://bugs.webkit.org/show_bug.cgi?id=111716
3764
3765         Reviewed by Kentaro Hara.
3766
3767         In DRT, we synchronously stop the test and start loading the next test
3768         URL. However, in content_shell, this happens asynchronously. It's
3769         important that the top loading frame is not changed due to stray
3770         navigation events before the next test starts.
3771
3772         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3773         (WebTestRunner::TestRunner::setTopLoadingFrame):
3774
3775 2013-03-06  Julie Parent  <jparent@chromium.org>
3776
3777         Dashboard cleanup: Move all dashboard ui related code into ui.js.
3778         https://bugs.webkit.org/show_bug.cgi?id=111621
3779
3780         Reviewed by Ojan Vafai.
3781         
3782         Creates ui.js, a package for the common UI code the various
3783         dashboards use. HTML generation is now in the ui.html namespace
3784         and popup handling is in ui.popup.
3785         Also moves the event listening for popups to ui.popup.show and
3786         removes it on ui.popup.hid rather than having listener always
3787         around.
3788
3789         * TestResultServer/static-dashboards/aggregate_results.html:
3790         * TestResultServer/static-dashboards/dashboard_base.js:
3791         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3792         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3793         (showPopupForBuild):
3794         (htmlForNavBar):
3795         (generatePageForIndividualTests.if):
3796         (generatePageForIndividualTests):
3797         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
3798         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3799         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3800         * TestResultServer/static-dashboards/run-unittests.html:
3801         * TestResultServer/static-dashboards/timeline_explorer.html:
3802         * TestResultServer/static-dashboards/treemap.html:
3803         * TestResultServer/static-dashboards/ui.js: Added.
3804         (.):
3805
3806 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
3807
3808         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
3809         https://bugs.webkit.org/show_bug.cgi?id=110584
3810
3811         Reviewed by Gyuyoung Kim.
3812
3813         Adds missing implementation of AccessibilityControllerEfl
3814         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
3815         so that it can make accessibilityController as a js object.
3816
3817         * DumpRenderTree/AccessibilityController.h:
3818         (AccessibilityController):
3819         * DumpRenderTree/AccessibilityUIElement.h:
3820         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3821         (AccessibilityController::childElementById): Moved declaration to base class.
3822         Implementation can be shared among other ports.
3823         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
3824         (AccessibilityController::focusedElement):
3825         (AccessibilityController::rootElement):
3826         (AccessibilityController::accessibleElementById):
3827         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
3828         (AccessibilityUIElement::helpText):
3829         * DumpRenderTree/efl/CMakeLists.txt:
3830         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3831         (DumpRenderTreeChrome::DumpRenderTreeChrome):
3832         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3833         (DumpRenderTreeChrome::onWindowObjectCleared):
3834         (DumpRenderTreeChrome::accessibilityController):
3835         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3836         (DumpRenderTreeChrome):
3837         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3838
3839 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
3840
3841         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
3842         https://bugs.webkit.org/show_bug.cgi?id=42696
3843
3844         Reviewed by Andreas Kling.
3845
3846         * DumpRenderTree/TestRunner.cpp:
3847         (TestRunner::staticFunctions):
3848         * DumpRenderTree/TestRunner.h:
3849         (TestRunner):
3850         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3851         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3852         (WebTestRunner::TestRunner::TestRunner):
3853         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3854         (TestRunner):
3855         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3856         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3857         * DumpRenderTree/mac/TestRunnerMac.mm:
3858         * DumpRenderTree/qt/TestRunnerQt.cpp:
3859         * DumpRenderTree/qt/TestRunnerQt.h:
3860         (TestRunnerQt):
3861         * DumpRenderTree/win/TestRunnerWin.cpp:
3862         * DumpRenderTree/wx/TestRunnerWx.cpp:
3863
3864 2013-03-06  Roger Fong  <roger_fong@apple.com>
3865
3866         Re-enable WinEWS test and decrease iterations before clean build back to 10.
3867
3868         * EWSTools/start-queue-win.sh:
3869         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3870         (WinEWS):
3871
3872 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
3873
3874         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
3875         https://bugs.webkit.org/show_bug.cgi?id=82866
3876
3877         Reviewed by Martin Robinson.
3878
3879         * Scripts/run-gtk-tests:
3880         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
3881         it is passing now.
3882
3883 2013-03-06  Julie Parent  <jparent@chromium.org>
3884
3885         Dashboard cleanup: remove dashboard time logging.
3886         https://bugs.webkit.org/show_bug.cgi?id=111608
3887
3888         Reviewed by Dirk Pranke.
3889
3890         Remove logTime.  It was never accurate, and the dev tools
3891         have better ways to measure this if anyone cares to look
3892         into dashboard perf.
3893         
3894         * TestResultServer/static-dashboards/dashboard_base.js:
3895         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3896         (processTestRunsForBuilder):
3897         (appendHTML):
3898
3899 2013-03-06  Tony Chang  <tony@chromium.org>
3900
3901         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3902         https://bugs.webkit.org/show_bug.cgi?id=111509
3903
3904         Reviewed by Dirk Pranke.
3905
3906         Add DumpRenderTree.pak to DumpRenderTree.app again.
3907
3908         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3909
3910 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
3911
3912         [chromium] introduce WebUserGestureIndicator
3913         https://bugs.webkit.org/show_bug.cgi?id=111531
3914
3915         Reviewed by Adam Barth.
3916
3917         * DumpRenderTree/chromium/WebViewHost.cpp:
3918         (WebViewHost::createView):
3919
3920 2013-03-06  Alan Cutter  <alancutter@chromium.org>
3921
3922         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
3923         https://bugs.webkit.org/show_bug.cgi?id=73482
3924
3925         Reviewed by Ryosuke Niwa.
3926
3927         Added input checking to the UpdateChromiumDEPS step.
3928         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
3929
3930         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
3931         (RollChromiumDEPS):
3932         (RollChromiumDEPS._parse_args):
3933         (RollChromiumDEPS.execute):
3934         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
3935         (IRCCommandTest.test_roll_chromium_deps):
3936         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
3937         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
3938         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
3939         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
3940         (UpdateChromiumDEPS._fetch_last_known_good_revision):
3941         (UpdateChromiumDEPS):
3942         (UpdateChromiumDEPS._parse_revision_number):
3943         (UpdateChromiumDEPS._validate_revisions):
3944         (UpdateChromiumDEPS.run):
3945         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
3946         (UpdateChromiumDEPSTest):
3947         (UpdateChromiumDEPSTest.test_parse_revision_number):
3948         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
3949         (RollChromiumDEPS):
3950         (PostChromiumDEPSRoll):
3951
3952 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
3953
3954         [Qt][MiniBrowser] Touch mocking broken for chained getures
3955         https://bugs.webkit.org/show_bug.cgi?id=111430
3956
3957         Reviewed by Jocelyn Turcotte.
3958
3959         Make it possible again to use touch mocking to test gesture chains
3960         like pan->pinch->pan->pinch without lifting the primary "finger".
3961         For this to work we need to track the pressed mouse buttons and
3962         only synthesize touch release events when the ctrl key is released
3963         if no mouse button is pressed. Else the pressed mouse button(s)
3964         should result in a stationary touch point in a touch update event.
3965         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
3966         to check for the state of the ctrl key modifier instead of getting
3967         it from the mouse events.
3968
3969         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3970         (MiniBrowserApplication::MiniBrowserApplication):
3971         (MiniBrowserApplication::notify):
3972
3973 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3974
3975         [chromium] don't use custom freetype on linux asan for now
3976         https://bugs.webkit.org/show_bug.cgi?id=111516
3977
3978         Unreviewed, build fix.
3979
3980         Turns out the custom lib is getting picked up by other binaries
3981         on our bot, which is bad.
3982
3983         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3984
3985 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3986
3987         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3988         https://bugs.webkit.org/show_bug.cgi?id=111509
3989
3990         Unreviewed, build fix.
3991
3992         Actually comment out the flag :(.
3993
3994         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3995
3996 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3997
3998         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3999         https://bugs.webkit.org/show_bug.cgi?id=111509
4000
4001         Unreviewed, build fix.
4002
4003         r144863 appears to have broken the xcode build; I'm temporarily
4004         trying this instead, and if this doesn't work, I'll revert the
4005         other changes.
4006
4007         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4008
4009 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4010
4011         [chromium] build a DumpRenderTree.pak even on windows
4012         https://bugs.webkit.org/show_bug.cgi?id=111504
4013
4014         Reviewed by Tony Chang.
4015
4016         The Chromium Aura build uses the default theme to draw
4017         controls, and that theme requires the ui ResourceBundle
4018         to be initialized. On every other platform, we build
4019         a DumpRenderTree.pak that works for this, but on Windows we
4020         still compile the resources directly into DRT. As a first step,
4021         let's build the pak file. I will then need to land a patch
4022         in Chromium to actually load it. Then I can go back and move
4023         the resources over to just use the .pak file and no longer need
4024         the .rc's.
4025
4026         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4027
4028 2013-03-05  Julie Parent  <jparent@chromium.org>
4029         Dashboard cleanup: move string utilities into their own namespace.
4030         
4031         https://bugs.webkit.org/show_bug.cgi?id=111485
4032
4033         Reviewed by Ojan Vafai.
4034         
4035         One of many pieces to clean up dashboard_base.
4036         
4037         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
4038
4039         * TestResultServer/static-dashboards/aggregate_results.html:
4040         * TestResultServer/static-dashboards/dashboard_base.js:
4041         (isTreeMap):
4042         (isFlakinessDashboard):
4043         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4044         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4045         (determineWKPlatform):
4046         (chromiumPlatform):
4047         (platformAndBuildType):
4048         (substringList):
4049         (individualTestsForSubstringList):
4050         (filterBugs):
4051         (populateExpectationsData):
4052         (processMissingTestsWithExpectations):
4053         (processMissingAndExtraExpectations):
4054         (htmlForSingleTestRow):
4055         (.dummyNode.onload):
4056         (expectationsTitle):
4057         * TestResultServer/static-dashboards/run-embedded-unittests.html:
4058         * TestResultServer/static-dashboards/run-unittests.html:
4059         * TestResultServer/static-dashboards/string.js: Added.
4060         * TestResultServer/static-dashboards/timeline_explorer.html:
4061         * TestResultServer/static-dashboards/treemap.html:
4062
4063 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
4064
4065         [EFL] Build break with latest EFL libraries
4066         https://bugs.webkit.org/show_bug.cgi?id=111028
4067
4068         Reviewed by Dirk Pranke.
4069
4070         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
4071         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
4072         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
4073
4074 2013-03-05  Roger Fong  <roger_fong@apple.com>
4075
4076         Increase number of WinEWS iterations to 20.
4077         Don't reboot after each iteration set.
4078         Make EWS bots just build temporarily so that the queue catches up again.
4079
4080         * EWSTools/start-queue-win.sh:
4081         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4082         (WinEWS):
4083
4084 2013-03-04  James Robinson  <jamesr@chromium.org>
4085
4086         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
4087         https://bugs.webkit.org/show_bug.cgi?id=111386
4088
4089         Reviewed by Adrienne Walker.
4090
4091         * DumpRenderTree/chromium/TestShell.cpp:
4092         (TestShell::initialize):
4093
4094 2013-03-05  Min Qin  <qinmin@chromium.org>
4095
4096         Copy dictionary to the external storage before running layout test on android
4097         https://bugs.webkit.org/show_bug.cgi?id=111480
4098
4099         Reviewed by Adam Barth.
4100
4101         TestWebKitPlatformSupport now needs to read an external dictionary file.
4102         This file does not exist on the device. We need to copy it before running layout tests.
4103
4104         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4105         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
4106         (ChromiumAndroidDriver._push_platform_resources):
4107
4108 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4109
4110         [chromium] DRT crashes in an Aura/Win build
4111         https://bugs.webkit.org/show_bug.cgi?id=111394
4112
4113         Reviewed by Tony Chang.
4114
4115         When building (and running) with use_aura=1, we assume that
4116         we're using the default theme engine, but DRT creates the
4117         DRTWin theme engine and overwrites the default, leading to crashes
4118         in basically every test from the mismatch.
4119
4120         This fix gets us down to at least "lots of crashes" :).
4121
4122         * DumpRenderTree/chromium/TestShellWin.cpp:
4123         (platformInit):
4124
4125 2013-03-05  Eric Seidel  <eric@webkit.org>
4126
4127         Add html-parser-threaded perf test now that the threaded parser is enabled by default
4128         https://bugs.webkit.org/show_bug.cgi?id=111200
4129
4130         Reviewed by Ryosuke Niwa.
4131
4132         Had to teach run-perf-tests to ignore one more warning.
4133
4134         * Scripts/webkitpy/performance_tests/perftest.py:
4135         (PerfTest):
4136
4137 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
4138
4139         Update list of builders for test results server
4140         https://bugs.webkit.org/show_bug.cgi?id=111166
4141
4142         Reviewed by Ojan Vafai.
4143
4144         * TestResultServer/static-dashboards/builders.jsonp:
4145
4146 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
4147
4148         [GTK] Move basic dependency installation to a script
4149         https://bugs.webkit.org/show_bug.cgi?id=110692
4150
4151         Reviewed by Gustavo Noronha Silva.
4152
4153         * gtk/install-dependencies: Added. A Script which installs all dependencies
4154         necessary for building for Debian-based distributions and Fedora.
4155
4156 2013-03-05  James Robinson  <jamesr@chromium.org>
4157
4158         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
4159         https://bugs.webkit.org/show_bug.cgi?id=111440
4160
4161         Reviewed by Adrienne Walker.
4162
4163         Remove unnecessary WebCompositorSupport::shutdown call
4164
4165         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4166         (main):
4167
4168 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
4169
4170         Unreviewed build fix.
4171
4172         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
4173
4174 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
4175
4176         [Qt][MiniBrowser] Improve the update of touch indicators
4177         https://bugs.webkit.org/show_bug.cgi?id=111429
4178
4179         Reviewed by Jocelyn Turcotte.
4180
4181         MiniBrowserApplication::sendTouchEvent sends an empty list
4182         to BrowserWindow::updateVisualMockTouchPoints if the control
4183         button is released, in which case the touch indicators should
4184         be hidden so that we never end up with a leftover indicator
4185         sticking on the screen.
4186         This patch also simplifies the lookup of the indicator items by
4187         replacing the findChild search in the item tree with a QHash
4188         that stores the touch ID's and the pointers to the corresponding
4189         indicator items.
4190
4191         * MiniBrowser/qt/BrowserWindow.cpp:
4192         (BrowserWindow::updateVisualMockTouchPoints):
4193         * MiniBrowser/qt/BrowserWindow.h:
4194         (BrowserWindow):
4195
4196 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
4197
4198         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
4199         https://bugs.webkit.org/show_bug.cgi?id=81042
4200
4201         Reviewed by Enrica Casucci.
4202
4203         Add setAsynchronousSpellCheckingEnabled implementation for
4204         WebKitTestRunner to have the possibility to test asynchronous
4205         spell checking implementation from bug 109577.
4206
4207         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4208         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4209         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
4210         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4211         * WebKitTestRunner/TestController.cpp:
4212         (WTR::TestController::resetStateToConsistentValues):
4213
4214 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
4215
4216         MediaStream API: Add the getStreamById method on RTCPeerConnection
4217         https://bugs.webkit.org/show_bug.cgi?id=111311
4218
4219         Reviewed by Adam Barth.
4220
4221         Changing mocks to be more realistic.
4222
4223         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
4224         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
4225         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
4226         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
4227         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
4228
4229 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
4230
4231         Add content shell bots to garden-o-matic for general failurse
4232         https://bugs.webkit.org/show_bug.cgi?id=111168
4233
4234         Reviewed by Adam Barth.
4235
4236         All but the WebKit (Content Shell) Android bot is stable enough. While
4237         they're not green yet, there must not be any non-layout test failures on
4238         them.
4239
4240         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4241         (.):
4242
4243 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
4244
4245         [chromium] remove deprecated WebTestRunner::setFocus API
4246         https://bugs.webkit.org/show_bug.cgi?id=111354
4247
4248         Reviewed by James Robinson.
4249
4250         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
4251         (WebTestDelegate):
4252
4253 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
4254
4255         Run the bindings generation tests on EWS and CQ bots
4256         https://bugs.webkit.org/show_bug.cgi?id=111358
4257
4258         Reviewed by Adam Barth.
4259
4260         The tests are super fast and not flaky.
4261
4262         * Scripts/webkitpy/common/config/ports.py:
4263         (DeprecatedPort.run_bindings_tests_command):
4264         * Scripts/webkitpy/common/config/ports_mock.py:
4265         (MockPort.run_webkit_tests_command):
4266         (MockPort):
4267         (MockPort.run_bindings_tests_command):
4268         * Scripts/webkitpy/tool/commands/download_unittest.py:
4269         * Scripts/webkitpy/tool/steps/runtests.py:
4270         (RunTests.run):
4271         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4272         (RunTestsTest.test_webkit_run_unit_tests):
4273         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4274
4275 2013-03-04  Eric Seidel  <eric@webkit.org>
4276
4277         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
4278         https://bugs.webkit.org/show_bug.cgi?id=111384
4279
4280         Reviewed by Ryosuke Niwa.
4281
4282         Sometimes I want to know why various LayoutTests are slow
4283         without having to convert them into PerformanceTests in order
4284         to use our fancy profiling.  The Driver already knows how to
4285         do the right thing, we just need to expose the options to the user.
4286
4287         Handling of these options is already unittested in the perftests_unittest.
4288
4289         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4290         (parse_args):
4291
4292 2013-03-04  Alan Cutter  <alancutter@chromium.org>