[GTK] Include a crash-fixing patch for the at-spi2-atk dependency
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
2
3         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
4         https://bugs.webkit.org/show_bug.cgi?id=114365
5
6         Reviewed by Martin Robinson.
7
8         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
9         The patch addresses crashes in the tally_event_reply method. It is already committed into the
10         at-spi2-atk source tree and will be available with the next stable release, after which the
11         patch should be removed and the dependency version bumped.
12
13         * gtk/jhbuild.modules:
14         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
15
16 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
17
18         [WinCairo] Unreviewed build fix. Correct DropBox download link.
19
20         * Scripts/update-webkit-wincairo-libs: Revise download URL to
21         match change in DropBox server behavior.
22
23 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
24
25         Removed an annoying message from svn-create-patch
26         https://bugs.webkit.org/show_bug.cgi?id=114332
27
28         Reviewed by Alexey Proskuryakov.
29
30         I see this message basically every time I write a patch, so it must not
31         be true.
32
33         * Scripts/svn-create-patch:
34         (generateDiff):
35
36 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
37
38         [GTK] Add support for Page Visibility
39         https://bugs.webkit.org/show_bug.cgi?id=97324
40
41         Reviewed by Sam Weinig.
42
43         Implemented test runner API for page visibility layout tests.
44
45         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
46         (TestRunner::resetPageVisibility):
47         (TestRunner::setPageVisibility):
48         * Scripts/webkitperl/FeatureList.pm:
49
50 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
51
52         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
53         https://bugs.webkit.org/show_bug.cgi?id=114342
54
55         Reviewed by Gyuyoung Kim.
56
57         Commit 148033 only added an implementation for the Mac port, which made
58         other ports fail most tests since loading the injected bundle failed
59         with a missing symbol.
60
61         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
62         (WTR::AccessibilityUIElement::pathDescription):
63
64 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
65
66         [EFL] Add spell checking option to MiniBrowser
67         https://bugs.webkit.org/show_bug.cgi?id=114282
68
69         Reviewed by Ryosuke Niwa.
70
71         Spell checking is enabled by adding a flag (t/text-checking)
72         with launching MiniBrowser.
73
74         * MiniBrowser/efl/main.c:
75         (window_create):
76         (elm_main):
77
78 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
79
80         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
81         https://bugs.webkit.org/show_bug.cgi?id=113281
82
83         Reviewed by Darin Adler.
84
85         * Scripts/run-gtk-tests:
86         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
87
88 2013-04-09  Glenn Adams  <glenn@skynav.com>
89
90         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
91
92         Unreviewed.
93
94         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
95         (RunTest.test_build_check):
96
97 2013-04-09  Glenn Adams  <glenn@skynav.com>
98
99         [webkitpy] Remove chromium ports.
100         https://bugs.webkit.org/show_bug.cgi?id=114326
101
102         Reviewed by Dirk Pranke.
103
104         As a side effect, also:
105
106         - remove chromium builders from webkitpy.layout_tests.port.builders
107         - remove chromium builders from rebaseline
108         - rewrite chromium dependent tests in rebaseline_unittest
109         - remove chromium platform from garden-o-matic
110         - select apple platform as default platform in garden-o-matic
111         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
112
113         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
114         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
115         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
116         (BaselineOptimizerTest.test_move_baselines):
117         (BaselineOptimizerTest.test_efl):
118         (BaselineOptimizerTest.test_no_add_mac_future):
119         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
120         (BaselineOptimizerTest.test_common_directory_includes_root):
121         (BaselineOptimizerTest.test_complex_shadowing):
122         (BaselineOptimizerTest.test_virtual_ports_filtered):
123         * Scripts/webkitpy/layout_tests/port/builders.py:
124         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
125         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
126         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
127         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
128         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
129         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
130         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
131         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
132         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
133         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
134         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
135         * Scripts/webkitpy/layout_tests/port/factory.py:
136         (platform_options):
137         (PortFactory):
138         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
139         (FactoryTest.test_qt):
140         (FactoryTest.test_get_from_builder_name):
141         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
142         (RunTest.test_build_check):
143         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
144         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
145         * Scripts/webkitpy/tool/commands/rebaseline.py:
146         (Rebaseline._builders_to_pull_from):
147         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
148         (_BaseTestCase):
149         (_BaseTestCase.setUp):
150         (TestRebaselineTest.setUp):
151         (TestRebaselineTest.test_baseline_directory):
152         (test_rebaseline_updates_expectations_file):
153         (test_rebaseline_does_not_include_overrides):
154         (test_rebaseline_test):
155         (test_rebaseline_test_and_print_scm_changes):
156         (test_rebaseline_and_copy_test):
157         (test_rebaseline_and_copy_test_no_existing_result):
158         (test_rebaseline_and_copy_test_with_lion_result):
159         (test_rebaseline_and_copy_no_overwrite_test):
160         (TestRebaselineExpectations.test_rebaseline_expectations):
161
162 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
163
164         newcommitbot (WKR) requires a subversion checkout
165         https://bugs.webkit.org/show_bug.cgi?id=114309
166
167         Reviewed by Benjamin Poulain.
168
169         Directly talk to the subversion server instead of relying on a local checkout.
170         This allows us to run WKR off of a git clone.
171
172         * Scripts/webkitpy/tool/commands/newcommitbot.py:
173         (NewCommitBot.next_work_item):
174         (NewCommitBot.process_work_item):
175
176 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
177
178         webkitbot refers to sheriffbot in help
179         https://bugs.webkit.org/show_bug.cgi?id=114307
180
181         Reviewed by Benjamin Poulain.
182
183         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
184
185         * Scripts/webkitpy/tool/bot/irc_command.py:
186         (Help):
187         (Help.execute):
188         (RollChromiumDEPS.execute):
189         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
190         (IRCBotTest.test_help):
191         * Scripts/webkitpy/tool/bot/sheriff.py:
192         (Sheriff.name):
193
194 2013-04-06  Roger Fong  <roger_fong@apple.com>
195
196         Kill old processes between runs on WinEWS bots.
197         Temporarily disable tests to let bots catch up again.
198
199         * EWSTools/start-queue-win.sh:
200         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
201         (WinEWS):
202
203 2013-04-09  Glenn Adams  <glenn@skynav.com>
204
205         [webkitpy] Remove chromium deprecated port support.
206         https://bugs.webkit.org/show_bug.cgi?id=114228
207
208         Reviewed by Ryosuke Niwa.
209
210         * Scripts/webkitpy/common/config/ports.py:
211         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
212         (ChromiumPort): Removed.
213         (ChromiumAndroidPort): Removed.
214         (ChromiumXVFBPort): Removed.
215         * Scripts/webkitpy/common/config/ports_unittest.py:
216         (DeprecatedPortTest.test_chromium_port): Removed.
217         (DeprecatedPortTest.test_chromium_android_port): Removed.
218         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
219         * Scripts/webkitpy/tool/steps/update_unittest.py:
220         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
221         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
222
223 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
224
225         AX: The bounding paths should be made available through accessibility
226         https://bugs.webkit.org/show_bug.cgi?id=113817
227
228         Reviewed by David Kilzer.
229
230         Add a pathDescription property for testing so that it's possible
231         to verify that a path is being returned correctly.
232
233         * DumpRenderTree/AccessibilityUIElement.cpp:
234         (getPathDescriptionCallback):
235         (AccessibilityUIElement::pathDescription):
236         (AccessibilityUIElement::getJSClass):
237         * DumpRenderTree/AccessibilityUIElement.h:
238         (AccessibilityUIElement):
239         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
240         (_CGPathEnumerationIteration):
241         (AccessibilityUIElement::pathDescription):
242         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
243         (AccessibilityUIElement::pathDescription):
244         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
245         (WTR::AccessibilityUIElement::pathDescription):
246         (WTR):
247         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
248         (AccessibilityUIElement):
249         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
250         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
251         (WTR::AccessibilityUIElement::pathDescription):
252         (WTR):
253
254 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
255
256         [EFL] Declare TEST_THEME_DIR in a single place.
257         https://bugs.webkit.org/show_bug.cgi?id=114285
258
259         Reviewed by Anders Carlsson.
260
261         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
262
263         * DumpRenderTree/efl/CMakeLists.txt:
264         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
265         (DumpRenderTreeChrome::createView):
266         (DumpRenderTreeChrome::createInspectorView):
267         (DumpRenderTreeChrome::initialize):
268         (DumpRenderTreeChrome::onDownloadRequest):
269         * EWebLauncher/CMakeLists.txt:
270         * EWebLauncher/main.c:
271         (findThemePath):
272         * EWebLauncher/url_bar.c:
273         (url_bar_add):
274         * MiniBrowser/efl/CMakeLists.txt:
275         * MiniBrowser/efl/main.c:
276         (window_create):
277         * TestWebKitAPI/PlatformEfl.cmake:
278         * TestWebKitAPI/efl/PlatformWebView.cpp:
279         (TestWebKitAPI::PlatformWebView::PlatformWebView):
280         * WebKitTestRunner/PlatformEfl.cmake:
281         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
282         (WTR::PlatformWebView::PlatformWebView):
283
284 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
285
286         [GTK][AC] upversion of clutter and its dependecy
287         https://bugs.webkit.org/show_bug.cgi?id=114016
288
289         Reviewed by Gustavo Noronha Silva.
290
291         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
292
293         * gtk/jhbuild-optional.modules:
294
295 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
296
297         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
298         https://bugs.webkit.org/show_bug.cgi?id=89875
299
300         Reviewed by Maciej Stachowiak.
301
302         Add unit tests to verify if the handling of the open, openat, creat syscall
303         is being done right. We check if the Read/Write/ReadAndWrite permissions
304         are respected, if the canonical path is being resolved and if
305         the permissions are falling back to the topmost parent directory with a
306         policy set when the directory being opened has no policy.
307
308         We also test if any attempt of blocking SIGSYS is silently ignored.
309         SIGSYS cannot be blocked because in it's handler is where we hook
310         syscalls to the broker process.
311
312         Also added libseccomp to EFL's jhbuild to make the life of developers
313         willing to help easier.
314
315         * Scripts/webkitperl/FeatureList.pm:
316         * TestWebKitAPI/PlatformEfl.cmake:
317         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
318         (TestWebKitAPI):
319         (SeccompEnvironment):
320         (TestWebKitAPI::SeccompEnvironment::SetUp):
321         (TestWebKitAPI::SeccompEnvironment::TearDown):
322         (TestWebKitAPI::dummyHandler):
323         (TestWebKitAPI::TEST):
324         (TestWebKitAPI::stressTest):
325         * efl/jhbuild.modules:
326         * qmake/mkspecs/features/features.pri:
327
328 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
329
330         REGRESSION: Autocorrection doesn't work in DumpRenderTree
331         https://bugs.webkit.org/show_bug.cgi?id=113846
332
333         Reviewed by Alexey Proskuryakov.
334
335         The problem was that we were replacing NSSpellCheck's dictionary with our own
336         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
337
338         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
339         and "would" respectively in DumpRenderTree.
340
341         * DumpRenderTree/mac/DumpRenderTree.mm:
342         (resetDefaultsToConsistentValues):
343
344 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
345
346         Remove the gyp files for Tools
347         https://bugs.webkit.org/show_bug.cgi?id=114248
348
349         Reviewed by Ryosuke Niwa.
350
351         * DumpRenderTree/DumpRenderTree.gyp: Removed.
352         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
353         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
354         * DumpRenderTree/DumpRenderTree.gypi: Removed.
355         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
356         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
357         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
358         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
359
360 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
361
362         WKR (new-commit-bot) is too slow
363         https://bugs.webkit.org/show_bug.cgi?id=110087
364
365         Reviewed by Geoffrey Garen.
366
367         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
368         Just run "svn log -r <revision>" instead to cut down the delay.
369
370         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
371
372         * Scripts/webkitpy/tool/commands/newcommitbot.py:
373         (NewCommitBot):
374         (NewCommitBot.next_work_item):
375         (NewCommitBot._is_empty_log):
376         (NewCommitBot._update_checkout):
377
378 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
379
380         Build fix. Can't remove appendCustomBuildFlags.
381
382         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
383         (appendCustomBuildFlags):
384
385 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
386
387         Remove Chromium builders from build.webkit.org
388         https://bugs.webkit.org/show_bug.cgi?id=113990
389
390         Reviewed by Benjamin Poulain.
391
392         Removed.
393
394         * BuildSlaveSupport/build.webkit.org-config/config.json:
395         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
396         (InstallGtkDependencies):
397         (RunUnitTests.start):
398         (RunWebKit2Tests.start):
399         (Factory.__init__):
400         (unitTestsSupported):
401         (TestFactory.__init__):
402         (BuildAndTestFactory.__init__):
403         (BuildAndPerfTestFactory.__init__):
404         (BuildAndPerfTestWebKit2Factory.__init__):
405         (DownloadAndPerfTestFactory.__init__):
406         (loadBuilderConfig):
407         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
408
409 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
410
411         Remove HTML Notification
412         https://bugs.webkit.org/show_bug.cgi?id=114231
413
414         Reviewed by Ryosuke Niwa.
415
416         * qmake/mkspecs/features/features.pri:
417
418 2013-04-08  Glenn Adams  <glenn@skynav.com>
419
420         Remove chromium EWS support, and fix broken test.
421         https://bugs.webkit.org/show_bug.cgi?id=114221
422
423         Reviewed by Ryosuke Niwa.
424
425         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
426         (AbstractChromiumEWS): Removed.
427         (ChromiumLinuxEWS): Removed.
428         (ChromiumLinuxDebugEWS): Removed.
429         (ChromiumWindowsEWS): Removed.
430         (ChromiumAndroidEWS): Removed.
431         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
432         (EarlyWarningSystemTest): Fix misspelled class name.
433         (test_ewses): Fix entry point name to ensure test is run.
434
435 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
436
437         [WIN] Remove WebKit2 source code
438         https://bugs.webkit.org/show_bug.cgi?id=114096
439
440         Reviewed by Anders Carlsson.
441
442         Remove the windows specific parts of the MiniBrowser.
443
444         * MiniBrowser/MiniBrowser.vcproj: Removed.
445         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
446         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
447         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
448         * MiniBrowser/win/BrowserView.cpp: Removed.
449         * MiniBrowser/win/BrowserView.h: Removed.
450         * MiniBrowser/win/BrowserWindow.cpp: Removed.
451         * MiniBrowser/win/BrowserWindow.h: Removed.
452         * MiniBrowser/win/MiniBrowser.cpp: Removed.
453         * MiniBrowser/win/MiniBrowser.h: Removed.
454         * MiniBrowser/win/MiniBrowser.rc: Removed.
455         * MiniBrowser/win/main.cpp: Removed.
456         * MiniBrowser/win/resource.h: Removed.
457         * MiniBrowser/win/stdafx.cpp: Removed.
458         * MiniBrowser/win/stdafx.h: Removed.
459
460 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
461
462         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
463
464         * Scripts/webkitpy/common/config/irc.py:
465
466 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
467
468         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
469         https://bugs.webkit.org/show_bug.cgi?id=113139
470
471         Reviewed by Anders Carlsson.
472
473         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
474         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
475         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
476         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
477         (ToStringAndValueOfObject):
478         (ToStringAndValueOfObject::ToStringAndValueOfObject):
479         (ScriptableObject):
480         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
481         (ToStringAndValueOfObject::ScriptableObject::invoke):
482         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
483         (ToStringAndValueOfObject::NPP_GetValue):
484         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
485         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
486         * GNUmakefile.am:
487
488 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
489
490         [GTK] Bump gnome-themes-standard to 3.6.0
491         https://bugs.webkit.org/show_bug.cgi?id=114155
492
493         Reviewed by Martin Robinson.
494
495         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
496         dependency of gnome-themes-standard accordingly.
497
498 2013-04-08  David Levin  <levin@chromium.org>
499
500         Remove my watchlist entries.
501         https://bugs.webkit.org/show_bug.cgi?id=114180
502
503         Reviewed by Adam Barth.
504
505         * Scripts/webkitpy/common/config/committers.py:
506         * Scripts/webkitpy/common/config/watchlist:
507
508 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
509
510         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
511         https://bugs.webkit.org/show_bug.cgi?id=114161
512
513         Reviewed by Gyuyoung Kim.
514
515         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
516         as it is crashing due to Bug 111074.
517
518         * TestWebKitAPI/PlatformEfl.cmake:
519
520 2013-04-07  David Kilzer  <ddkilzer@apple.com>
521
522         Remove the rest of SVG_DOM_OBJC_BINDINGS
523         <http://webkit.org/b/114112>
524
525         Reviewed by Geoffrey Garen.
526
527         * Scripts/webkitperl/FeatureList.pm:
528         - Remove --svg-dom-objc-bindings switch.
529         * qmake/mkspecs/features/features.pri:
530         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
531
532 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
533
534         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
535         https://bugs.webkit.org/show_bug.cgi?id=114089
536
537         Reviewed by Chris Fleizach.
538
539         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
540         * DumpRenderTree/AccessibilityController.cpp:
541         * DumpRenderTree/AccessibilityUIElement.cpp:
542         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
543         (DumpRenderTreeChrome::DumpRenderTreeChrome):
544         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
545         (DumpRenderTreeChrome):
546
547 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
548
549         Build fix after r147857, remove remaining USE(JSC) guards.
550
551         Unreviewed.
552
553         * DumpRenderTree/config.h:
554         * TestWebKitAPI/config.h:
555         * WebKitTestRunner/config.h:
556
557 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
558
559         Rename sheriffbot to webkitbot
560         https://bugs.webkit.org/show_bug.cgi?id=114109
561
562         Reviewed by Benjamin Poulain.
563
564         Renamed since sheriffbot will be used in Blink.
565
566         * Scripts/webkitpy/tool/commands/sheriffbot.py:
567         (SheriffBot):
568         (SheriffBot.begin_work_queue):
569
570 2013-04-06  Oliver Hunt  <oliver@apple.com>
571
572         Unify the many and varied stack trace mechanisms, and make the result sane.
573         https://bugs.webkit.org/show_bug.cgi?id=114072
574
575         Reviewed by Filip Pizlo.
576
577         The commandline jsc executable no longer requires arguments, so
578         I've made run-jsc work without them.
579
580         * Scripts/run-jsc:
581
582 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
583
584         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
585         https://bugs.webkit.org/show_bug.cgi?id=114086
586
587         Reviewed by Tim Horton.
588
589         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
590
591 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
592
593         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
594         https://bugs.webkit.org/show_bug.cgi?id=114083
595
596         Reviewed by Ryosuke Niwa.
597
598         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
599         in TestWebKitAPI and WebKitTestRunner.
600
601         * TestWebKitAPI/config.h:
602         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
603         (TestWebKitAPI::InjectedBundleController::platformInitialize):
604         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
605         (WTR::InjectedBundle::platformInitialize):
606
607 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
608
609         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
610         https://bugs.webkit.org/show_bug.cgi?id=114094
611
612         Reviewed by Anders Carlsson.
613
614         * Scripts/run-jsc:
615
616 2013-04-05  Ojan Vafai  <ojan@chromium.org>
617
618         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
619         https://bugs.webkit.org/show_bug.cgi?id=114080
620
621         Reviewed by Ryosuke Niwa.
622
623         This way, the WebKit and Blink dashboard code can change as appropriate without
624         needing to consider the other project's needs. This still doesn't update the
625         buildbots to upload to the new location, or the dashboard code to pull the
626         results.json files from the new location, but it at least allows for changing the
627         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
628
629         * TestResultServer/app.yaml:
630
631 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
632
633         Re-enable testing on the commit queue
634         https://bugs.webkit.org/show_bug.cgi?id=114078
635
636         Reviewed by Darin Adler.
637
638         Re-enabled the feature and the associated tests.
639
640         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
641         (CommitQueueTask.run):
642         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
643         (CommitQueueTaskTest._run_through_task):
644         * Scripts/webkitpy/tool/commands/queues_unittest.py:
645         (CommitQueueTest._mock_test_result):
646
647 2013-04-05  Oliver Hunt  <oliver@apple.com>
648
649         Unify the many and varied stack trace mechanisms, and make the result sane.
650         https://bugs.webkit.org/show_bug.cgi?id=114072
651
652         Reviewed by Filip Pizlo.
653
654         The commandline jsc executable no longer requires arguments, so
655         I've made run-jsc work without them.
656
657         * Scripts/run-jsc:
658
659 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
660
661         AX: Make SVG Group containers accessible elements
662         https://bugs.webkit.org/show_bug.cgi?id=113939
663
664         Reviewed by Simon Fraser.
665
666         Implement axController.elementAtPoint for iOS.
667         Implement a correct version of clickPoint for iOS.
668
669         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
670         (AccessibilityController::elementAtPoint):
671         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
672         (AccessibilityUIElement::clickPointX):
673         (AccessibilityUIElement::clickPointY):
674
675 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
676
677         Unreviewed, rolling out r147773 and r147774.
678         http://trac.webkit.org/changeset/147773
679         http://trac.webkit.org/changeset/147774
680         https://bugs.webkit.org/show_bug.cgi?id=114056
681
682         Causing some exceptions on AppEngine I don't understand
683         (Requested by rniwa on #webkit).
684
685         * QueueStatusServer/config/queues.py:
686         * QueueStatusServer/model/queues.py:
687         (Queue.short_name):
688         (Queue.display_name):
689         * QueueStatusServer/model/queues_unittest.py:
690         (QueueTest.test_short_name):
691         (QueueTest.test_display_name):
692         (QueueTest.test_name_with_underscores):
693
694 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
695
696         Fixed run-bindings-tests by removing V8
697         https://bugs.webkit.org/show_bug.cgi?id=114053
698
699         Reviewed by Benjamin Poulain.
700
701         * Scripts/run-bindings-tests:
702         (main):
703
704 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
705
706         Build fix.
707
708         * QueueStatusServer/model/queues.py:
709         (Queue.short_name):
710         (Queue.display_name):
711
712 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
713
714         Remove Chromium EWS bots from the queue status server
715         https://bugs.webkit.org/show_bug.cgi?id=113988
716
717         Reviewed by Benjamin Poulain.
718
719         Removed Chromium EWS bots.
720
721         * QueueStatusServer/config/queues.py:
722         * QueueStatusServer/model/queues.py:
723         (Queue.short_name):
724         (Queue.display_name):
725         * QueueStatusServer/model/queues_unittest.py:
726         (QueueTest.test_short_name):
727         (QueueTest.test_display_name):
728         (QueueTest.test_name_with_underscores):
729
730 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
731
732         [EFL] Enable indexed database
733         https://bugs.webkit.org/show_bug.cgi?id=107248
734
735         Reviewed by Alexis Menard.
736
737         * Scripts/webkitperl/FeatureList.pm:
738
739 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
740
741         Remove vestiges of Chromium bits from watchlists.
742         https://bugs.webkit.org/show_bug.cgi?id=114047
743
744         Reviewed by Ryosuke Niwa.
745
746         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
747
748 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
749
750         Add James Craig to the contributors list.
751
752         * Scripts/webkitpy/common/config/committers.py:
753
754 2013-04-04  Kent Tamura  <tkent@chromium.org>
755
756         Remove ChromiumPublicApi pattern, and cc/message rules for it.
757
758         * Scripts/webkitpy/common/config/watchlist:
759
760 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
761
762         Temporarily disable the Python unittests broken by the commit queue not running layout tests
763         https://bugs.webkit.org/show_bug.cgi?id=113997
764
765         Reviewed by Ryosuke Niwa.
766
767         Disable the tests until Ryosuke gets the time and hardware to have
768         a testing commit-queue.
769
770         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
771         (CommitQueueTaskTest):
772         * Scripts/webkitpy/tool/commands/queues_unittest.py:
773         (CommitQueueTest):
774
775 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
776
777         Remove Chromium builders from build.webkit.org
778         https://bugs.webkit.org/show_bug.cgi?id=113990
779
780         Reviewed by Benjamin Poulain.
781
782         Land the part to disable triggering of Chromium builders first so that we may start
783         deleting more Chromium code that breaks the update step.
784
785         * BuildSlaveSupport/build.webkit.org-config/config.json:
786
787 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
788
789         Remove Chromium's DumpRenderTree
790         https://bugs.webkit.org/show_bug.cgi?id=113989
791
792         Reviewed by Kent Tamura.
793
794         On second thought, let's not go to Camelot. It is a silly place.
795
796         * DumpRenderTree/mac/DumpRenderTree.mm:
797         (resetDefaultsToConsistentValues):
798
799 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
800
801         Nixed the defunct chromium folder from DumpRenderTree
802         https://bugs.webkit.org/show_bug.cgi?id=113993
803
804         Reviewed by Ryosuke Niwa.
805
806         * DumpRenderTree/chromium: Removed.
807         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
808         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
809         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
810         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
811         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
812         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
813         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
814         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
815         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
816         * DumpRenderTree/chromium/MockPlatform.h: Removed.
817         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
818         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
819         * DumpRenderTree/chromium/Task.cpp: Removed.
820         * DumpRenderTree/chromium/Task.h: Removed.
821         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
822         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
823         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
824         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
825         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
826         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
827         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
828         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
829         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
830         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
831         * DumpRenderTree/chromium/TestRunner: Removed.
832         * DumpRenderTree/chromium/TestRunner/public: Removed.
833         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
834         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
835         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
836         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
837         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
838         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
839         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
840         * DumpRenderTree/chromium/TestRunner/src: Removed.
841         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
842         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
843         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
844         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
845         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
846         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
847         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
848         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
849         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
850         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
851         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
852         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
853         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
854         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
855         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
856         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
857         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
858         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
859         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
860         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
861         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
862         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
863         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
864         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
865         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
866         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
867         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
868         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
869         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
870         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
871         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
872         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
873         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
874         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
875         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
876         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
877         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
878         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
879         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
880         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
881         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
882         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
883         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
884         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
885         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
886         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
887         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
888         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
889         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
890         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
891         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
892         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
893         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
894         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
895         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
896         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
897         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
898         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
899         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
900         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
901         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
902         * DumpRenderTree/chromium/TestShell.cpp: Removed.
903         * DumpRenderTree/chromium/TestShell.h: Removed.
904         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
905         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
906         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
907         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
908         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
909         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
910         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
911         * DumpRenderTree/chromium/WebViewHost.h: Removed.
912         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
913         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
914         * DumpRenderTree/chromium/config.h: Removed.
915         * DumpRenderTree/chromium/fonts.conf: Removed.
916
917 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
918
919         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
920
921         Rubber stamped by Benjamin Poulain.
922
923         * RebaselineQueueServer: Removed.
924         * RebaselineQueueServer/app.yaml: Removed.
925         * RebaselineQueueServer/handlers: Removed.
926         * RebaselineQueueServer/handlers/__init__.py: Removed.
927         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
928         * RebaselineQueueServer/handlers/pages.py: Removed.
929         * RebaselineQueueServer/index.yaml: Removed.
930         * RebaselineQueueServer/main.py: Removed.
931         * RebaselineQueueServer/model: Removed.
932         * RebaselineQueueServer/model/__init__.py: Removed.
933         * RebaselineQueueServer/model/queueentry.py: Removed.
934         * RebaselineQueueServer/static: Removed.
935         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
936         * RebaselineQueueServer/static/styles.css: Removed.
937         * RebaselineQueueServer/templates: Removed.
938         * RebaselineQueueServer/templates/builder-picker.html: Removed.
939         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
940         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
941         * RebaselineQueueServer/templates/home.html: Removed.
942
943 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
944
945         Fix setup-commit-queue and temporarily disable testing on commit-queue
946         https://bugs.webkit.org/show_bug.cgi?id=113979
947
948         Reviewed by Benjamin Poulain.
949
950         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
951         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
952
953         * EWSTools/setup-commit-queue.sh:
954         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
955         (CommitQueueTask.run):
956
957 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
958
959         temporarily make flakiness dashboard work again webkit.org bots
960         https://bugs.webkit.org/show_bug.cgi?id=113972
961
962         Reviewed by Ojan Vafai.
963
964         This patch disables the chromium.org layout test bots TestExpectations
965         parsing temporarily until we can work out the right way to split into
966         two instances for webkit.org and chromium.org and figure out which
967         code to delete where :).
968
969         * TestResultServer/static-dashboards/flakiness_dashboard.js:
970
971 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
972
973         Fix webkitpy tests after r147678.
974
975         * Scripts/webkitpy/tool/commands/queues_unittest.py:
976         (CommitQueueTest.test_commit_queue):
977         (test_manual_reject_during_processing):
978
979 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
980
981         The commit queue should use Mac MountainLion port
982         https://bugs.webkit.org/show_bug.cgi?id=113971
983
984         Reviewed by Lucas Forschler.
985
986         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
987         * Scripts/webkitpy/tool/commands/queues.py:
988         (CommitQueue):
989
990 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
991
992         turn off running tests on chromium linux EWS bots
993         https://bugs.webkit.org/show_bug.cgi?id=113959
994
995         Reviewed by Geoffrey Garen.
996
997         Now that the Chromium port is no longer being maintained
998         there's little point in running the tests. Soon we should
999         just shut this bot off altogether.
1000
1001         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1002         (ChromiumLinuxEWS):
1003
1004 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1005
1006         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1007
1008         * Scripts/webkitpy/common/config/watchlist:
1009
1010 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1011
1012         Indentation fix to get webkit-patch working again after r147625
1013
1014         Unreviewed.
1015
1016         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1017         (MacEWS):
1018         (MacWK2EWS):
1019
1020 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1021
1022         Turn tests back on for Mac WK1/WK2 EWS.
1023         
1024         Unreviewed.
1025         
1026         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1027         (MacEWS):
1028         (MacWK2EWS):
1029
1030 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1031
1032         [GTK][WK2] MiniBrowser custom URI scheme support
1033         https://bugs.webkit.org/show_bug.cgi?id=112419
1034
1035         Reviewed by Carlos Garcia Campos.
1036
1037         Add support for about URIs in MiniBrowser. An example about page is show
1038         with URI "about:minibrowser", the rest of the cases it will show a
1039         proper message explaining that the about page didn't exist.
1040
1041         Internally it uses "minibrowser-about" prefix instead of "about", but
1042         from the user point of view it works with "about" prefix.
1043
1044         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1045         (getInternalURI): Method to convert URIs from "about" prefix to
1046         "minibrowser-about".
1047         (getExternalURI): Opposite method.
1048         (webViewURIChanged): Use "about" prefix to show the URI to users.
1049         (webViewEnterFullScreen): Ditto.
1050         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1051         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1052         (aboutURISchemeRequestCallback): Callback to manage about calls.
1053         (main): Register the URI scheme to manage about URIs.
1054
1055 2013-04-03  Roger Fong  <roger_fong@apple.com>
1056
1057         Re-enable WinEWS tests.
1058
1059         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1060         (WinEWS):
1061
1062 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1063
1064         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1065         https://bugs.webkit.org/show_bug.cgi?id=113883
1066
1067         Reviewed by Martin Robinson.
1068
1069         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1070         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1071         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1072
1073 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1074
1075         [GTK] Include Pango in jhbuild-optional.modules
1076         https://bugs.webkit.org/show_bug.cgi?id=113878
1077
1078         Reviewed by Martin Robinson.
1079
1080         Since r147547 Pango 1.32.0 is required. Including the module in the
1081         JHBuild optional moduleset.
1082
1083         * gtk/jhbuild-optional.modules: Add Pango module.
1084
1085 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1086
1087         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1088         https://bugs.webkit.org/show_bug.cgi?id=113864
1089
1090         Moving setDefersLoading from TestRunnerQt to TestRunner
1091         requires access to the non-Qt TestRunner.
1092         As long as we instantiate both TestRunner and TestRunnerQt,
1093         we need a separate getter for the non-Qt TestRunner instance.
1094
1095         Reviewed by Simon Hausmann.
1096
1097         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1098         (WebPage::resetSettings):
1099         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1100         (DumpRenderTree::jscTestRunner):
1101         * DumpRenderTree/qt/TestRunnerQt.cpp:
1102         (TestRunner::setDefersLoading):
1103             Moving setDefersLoading from TestRunnerQt
1104             to TestRunner.
1105         * DumpRenderTree/qt/TestRunnerQt.h:
1106         (TestRunnerQt):
1107
1108 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1109
1110         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1111         https://bugs.webkit.org/show_bug.cgi?id=104779
1112
1113         Reviewed by Carlos Garcia Campos.
1114
1115         * Scripts/run-gtk-tests:
1116         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1117         passing in current trunk.
1118
1119 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1120
1121         Fix HAVE(QTTESTSUPPORT) logic
1122
1123         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1124         resulting in HAVE(QTTESTSUPPORT) never being true.
1125         Move that logic down in sanitizeFeatures.
1126
1127         Rubber-stamped by Tor Arne Vestbø.
1128
1129         * qmake/mkspecs/features/features.prf:
1130
1131 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1132
1133         [GTK] Bump required versions of some dependencies
1134         https://bugs.webkit.org/show_bug.cgi?id=113282
1135
1136         Reviewed by Martin Robinson.
1137
1138         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1139
1140 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1141
1142         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1143         https://bugs.webkit.org/show_bug.cgi?id=113809
1144
1145         Reviewed by Philippe Normand.
1146
1147         Newer Linux kernels have removed some deprecated macros from v4l2
1148         headers, causing gst-plugins-good's build to break. We don't need it
1149         right now, so just disable it.
1150
1151         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1152
1153 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1154
1155         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1156         https://bugs.webkit.org/show_bug.cgi?id=113535
1157
1158         Reviewed by Simon Hausmann.
1159
1160         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1161
1162         * qmake/mkspecs/features/features.prf:
1163
1164 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1165
1166         [Qt] Move logic of simple forwarding functions to TestRunner.
1167         https://bugs.webkit.org/show_bug.cgi?id=113863
1168
1169         Reviewed by Simon Hausmann.
1170
1171         * DumpRenderTree/qt/TestRunnerQt.cpp:
1172         (TestRunner::setTextDirection):
1173         (TestRunner::goBack):
1174         (TestRunner::evaluateScriptInIsolatedWorld):
1175         (TestRunner::addUserStyleSheet):
1176         * DumpRenderTree/qt/TestRunnerQt.h:
1177         (TestRunnerQt):
1178
1179 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1180
1181         [Qt] Disable media support using QuickTime if deployment target != SDK
1182
1183         We link to a single libWebKitSystemInterface static lib, so unless the
1184         deployment target matches the SDK let's not pretend like we'll be able
1185         to run on anything lower than the SDK version.
1186
1187         Reviewed by Simon Hausmann.
1188
1189         * qmake/mkspecs/features/features.prf:
1190
1191 2013-04-02  James Craig  <james@cookiecrook.com>
1192
1193         AXRoleDescripton for DL is "list"; should be "description list"
1194         https://bugs.webkit.org/show_bug.cgi?id=111665
1195
1196         Reviewed by Chris Fleizach.
1197
1198         Defining the role and description strings.
1199
1200         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1201
1202 2013-04-02  Roger Fong  <roger_fong@apple.com>
1203
1204         Unreviewed. Disable running tests on Win EWS queue.
1205
1206         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1207         (WinEWS):
1208
1209 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1210
1211         Disable running tests on the MAC WK2 EWS queue.
1212         
1213         Unreviewed.
1214         
1215         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1216         (MacWK2EWS):
1217
1218 2013-04-02  Julie Parent  <jparent@chromium.org>
1219
1220         Dashboard refactor: Move dashboard specific history related features to History.
1221         https://bugs.webkit.org/show_bug.cgi?id=113717
1222
1223         Reviewed by Ojan Vafai.
1224         
1225         Each dashboard now creates its own History object, with a custom
1226         configuration. This changes from just overriding global functions
1227         to passing in callbacks for generatePage, handleValidHashParameter,
1228         and handleQueryParameterChange. Same with passing in defaultStateValues
1229         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1230         variables.
1231         
1232         All functions related to these features are now (mostly) private
1233         function on History. 
1234         
1235         Loader no longer needs a loadingComplete callback, since it can just
1236         initialize the history object itself.
1237
1238         * TestResultServer/static-dashboards/aggregate_results.js:
1239         (handleValidHashParameter):
1240         * TestResultServer/static-dashboards/dashboard_base.js:
1241         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1242         (generatePage):
1243         (.switch.return):
1244         (handleQueryParameterChange):
1245         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1246         (resetGlobals):
1247         * TestResultServer/static-dashboards/history.js:
1248         (.):
1249         * TestResultServer/static-dashboards/loader.js:
1250         (.):
1251         * TestResultServer/static-dashboards/loader_unittests.js:
1252         * TestResultServer/static-dashboards/timeline_explorer.js:
1253         (generatePage):
1254         (initCurrentBuilderTestResults):
1255         * TestResultServer/static-dashboards/treemap.js:
1256         (generatePage):
1257         (.switch.return):
1258         (handleQueryParameterChange):
1259
1260 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1261
1262         Unreviewed, rolling out r147401.
1263         http://trac.webkit.org/changeset/147401
1264         https://bugs.webkit.org/show_bug.cgi?id=113767
1265
1266         The patch makes it extremely hard to set up the dependencies
1267         properly on the GTK builders (Requested by zdobersek on
1268         #webkit).
1269
1270         * gtk/jhbuild.modules:
1271
1272 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1273
1274         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1275         https://bugs.webkit.org/show_bug.cgi?id=113382
1276
1277         Reviewed by Gyuyoung Kim.
1278
1279         Do not show the empty tooltip box if the text is null.
1280
1281         * MiniBrowser/efl/main.c:
1282         (popup_menu_populate):
1283
1284 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1285
1286         [GTK] Bump required versions of some dependencies
1287         https://bugs.webkit.org/show_bug.cgi?id=113282
1288
1289         Reviewed by Martin Robinson.
1290
1291         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1292
1293 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1294
1295         Unreviewed, rolling out r147319.
1296         http://trac.webkit.org/changeset/147319
1297         https://bugs.webkit.org/show_bug.cgi?id=113707
1298
1299         The unit test is still failing on the buildbot (Requested by
1300         zdobersek on #webkit).
1301
1302         * Scripts/run-gtk-tests:
1303         (TestRunner):
1304
1305 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1306
1307         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1308         https://bugs.webkit.org/show_bug.cgi?id=104779
1309
1310         Reviewed by Carlos Garcia Campos.
1311
1312         * Scripts/run-gtk-tests:
1313         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1314         passing in current trunk.
1315
1316 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1317
1318         Unreviewed, rolling out r147289.
1319         http://trac.webkit.org/changeset/147289
1320         https://bugs.webkit.org/show_bug.cgi?id=113678
1321
1322         broke Win7 (dbg) build (Requested by shinyak|gardener on
1323         #webkit).
1324
1325         * DumpRenderTree/DumpRenderTree.gypi:
1326         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1327         (WebTestRunner):
1328         (WebUserMediaClientMock):
1329         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1330         (WebTestRunner::WebUserMediaClientMock::taskList):
1331         * Scripts/webkitpy/style/checkers/cpp.py:
1332         (check_function_definition):
1333
1334 2013-03-31  Adam Barth  <abarth@webkit.org>
1335
1336         configure-svn-config.sh fails
1337         https://codereview.chromium.org/13392007/
1338
1339         Reviewed by Eric Seidel.
1340
1341         This script was trying to use "svn checkout" to dowload a file from
1342         svn.webkit.org, but "svn checkout" only works with directories.
1343         Instead, we should use "svn export".
1344
1345         * EWSTools/configure-svn-config.sh:
1346
1347 2013-03-31  Wei Jia  <wjia@chromium.org>
1348
1349         Allow WebUserMediaClientMock to be used by client
1350         https://bugs.webkit.org/show_bug.cgi?id=113633
1351
1352         Reviewed by Adam Barth.
1353
1354         Export WebUserMediaClientMock.
1355         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1356
1357         * DumpRenderTree/DumpRenderTree.gypi:
1358         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1359         (WebUserMediaClientMock):
1360         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1361         * Scripts/webkitpy/style/checkers/cpp.py:
1362         (check_function_definition):
1363
1364 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1365
1366         Expose FeatureObserver data to WebKit clients
1367         https://bugs.webkit.org/show_bug.cgi?id=113613
1368
1369         Reviewed by Sam Weinig.
1370
1371         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1372         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1373
1374 2013-03-29  Greg Hughes  <ghughes@apple.com>
1375
1376         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1377         https://bugs.webkit.org/show_bug.cgi?id=112276
1378
1379         Reviewed by Chris Fleizach.
1380
1381         Added support to test accessibility search predicates with multiple keys.  
1382
1383         * DumpRenderTree/AccessibilityUIElement.cpp:
1384         (uiElementForSearchPredicateCallback):
1385         * DumpRenderTree/AccessibilityUIElement.h:
1386         (AccessibilityUIElement):
1387         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1388         (AccessibilityUIElement::uiElementForSearchPredicate):
1389         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1390         (AccessibilityUIElement::uiElementForSearchPredicate):
1391         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1392         (AccessibilityUIElement::uiElementForSearchPredicate):
1393         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1394         (AccessibilityUIElement::uiElementForSearchPredicate):
1395         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1396         (AccessibilityUIElement::uiElementForSearchPredicate):
1397         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1398         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1399         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1400         (AccessibilityUIElement):
1401         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1402         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1403         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1404         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1405         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1406
1407 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1408
1409         Fix a typo in r147147 to fix Mac EWS.
1410
1411         * Scripts/webkitpy/tool/commands/queues.py:
1412         (PatchProcessingQueue._new_port_name_from_old):
1413
1414 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1415
1416         [EFL] Build break with latest EFL libraries after r146265
1417         https://bugs.webkit.org/show_bug.cgi?id=113558
1418
1419         Unreviewed build fix.
1420
1421         * TestWebKitAPI/PlatformWebView.h:
1422         * WebKitTestRunner/PlatformWebView.h:
1423
1424 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1425
1426         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1427
1428         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1429         in libgcrypt build.
1430
1431 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1432
1433         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1434
1435         Unreviewed.
1436
1437         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1438         (MacEWS):
1439
1440 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1441
1442         Use the right OS name on Mac EWS instead of mac-future.
1443
1444         Rubber-stamped by Dirk Pranke.
1445
1446         * Scripts/webkitpy/tool/commands/queues.py:
1447         (PatchProcessingQueue._new_port_name_from_old):
1448         (PatchProcessingQueue.begin_work_queue):
1449         (PatchProcessingQueue._upload_results_archive_for_patch):
1450
1451 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1452
1453         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1454         https://bugs.webkit.org/show_bug.cgi?id=112546
1455
1456         Reviewed by Martin Robinson.
1457
1458         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1459         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1460
1461 2013-03-28  Ming Xie  <mxie@blackberry.com>
1462
1463         [BlackBerry] Committer Email Updates
1464         https://bugs.webkit.org/show_bug.cgi?id=113435
1465
1466         Reviewed by Rob Buis.
1467
1468         Add the @blackberry.com email address for all our BlackBerry
1469         WebKit committers. This is the first step for our email address
1470         migration.
1471
1472         * Scripts/webkitpy/common/config/committers.py:
1473
1474 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1475
1476         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1477         https://bugs.webkit.org/show_bug.cgi?id=113508
1478
1479         Reviewed by Martin Robinson.
1480
1481         Prevent the GStreamer plugin scanner to load system-wide
1482         plugins. Only the ones built in JHBuild should be loaded and used
1483         at runtime.
1484
1485         * efl/jhbuildrc:
1486         * gtk/jhbuildrc:
1487
1488 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1489
1490         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1491         https://bugs.webkit.org/show_bug.cgi?id=113386
1492
1493         Reviewed by Carlos Garcia Campos.
1494
1495         * Scripts/webkitdirs.pm:
1496         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1497         version to 3.0. Reflect this change so the builtDylibPathForName
1498         function doesn't fail to report the library as found.
1499
1500 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1501
1502         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1503         https://bugs.webkit.org/show_bug.cgi?id=113484
1504
1505         Unreviewed build fix.
1506
1507         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1508
1509         * TestWebKitAPI/CMakeLists.txt:
1510         * WebKitTestRunner/CMakeLists.txt:
1511
1512 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1513
1514         Revision for the internal jhbuild is too old
1515         https://bugs.webkit.org/show_bug.cgi?id=113324
1516
1517         Reviewed by Martin Robinson.
1518
1519         Update the minimum required version to a point where jhbuild won't
1520         fail installing packages when trying to remove a symlink to a directory.
1521
1522         * jhbuild/jhbuild-wrapper: Updated revision.
1523
1524 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1525
1526         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1527         https://bugs.webkit.org/show_bug.cgi?id=113203
1528
1529         Reviewed by Philippe Normand.
1530
1531         We build our libsoup without GNOME support. gst-plugins-good does separate
1532         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1533         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1534         build failures as the headers of those diverge. We do not use souphttpsrc, so
1535         disable it when building gst-plugins-good.
1536
1537         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1538
1539 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1540
1541         Build fix after r146852. Please another reference to the Lion leaks builder.
1542
1543         * BuildSlaveSupport/build.webkit.org-config/config.json:
1544
1545 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1546
1547         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1548         https://bugs.webkit.org/show_bug.cgi?id=113421
1549
1550         Reviewed by Dirk Pranke.
1551
1552         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1553         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1554         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1555         in the GTK-specific TestExpectations files.
1556
1557         To avoid this only enable the warnings only when not using WKTR.
1558
1559         * Scripts/webkitpy/layout_tests/port/gtk.py:
1560         (GtkPort.warn_if_bug_missing_in_test_expectations):
1561
1562 2013-03-27  Antti Koivisto  <antti@apple.com>
1563
1564         Fix Zalan's email.
1565
1566         * Scripts/webkitpy/common/config/committers.py:
1567
1568 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1569
1570         master.cfg cleanup
1571         https://bugs.webkit.org/show_bug.cgi?id=113195
1572
1573         Reviewed by Ryosuke Niwa.
1574
1575         * BuildSlaveSupport/build.webkit.org-config/config.json:
1576         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1577
1578 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1579
1580         master.cfg fine-tuning for Qt Mountain Lion Release bot
1581         https://bugs.webkit.org/show_bug.cgi?id=113191
1582
1583         Reviewed by Ryosuke Niwa.
1584
1585         * BuildSlaveSupport/build.webkit.org-config/config.json:
1586           - Rename the slave due to its location change.
1587           - Update the platform of the slave.
1588         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1589         (RunQtAPITests): Enable running WK2 API tests on Qt.
1590         (RunQtAPITests.start):
1591         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1592         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1593
1594 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1595
1596         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1597         https://bugs.webkit.org/show_bug.cgi?id=113403
1598
1599         Reviewed by Kenneth Rohde Christiansen.
1600
1601         As of Evas 1.7.5, when Wayland is detected on the system, support for
1602         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1603         The code, however, seems to depend on a few other flags which must be
1604         explicitly enabled.
1605
1606         If those additional GL-related options are passed, we end up
1607         having issues on the WebKit side, so disable Wayland support for
1608         now.
1609
1610         * efl/jhbuild.modules:
1611
1612 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1613
1614         Unreviewed, rolling out r146864.
1615         http://trac.webkit.org/changeset/146864
1616         https://bugs.webkit.org/show_bug.cgi?id=113391
1617
1618         causes crashes on Wk2 EFL release bot (Requested by drott on
1619         #webkit).
1620
1621         * Scripts/webkitperl/FeatureList.pm:
1622
1623 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1624
1625         [jhbuild] Correctly specify an alternate number of make jobs.
1626         https://bugs.webkit.org/show_bug.cgi?id=113396
1627
1628         Reviewed by Philippe Normand.
1629
1630         So far, we were using the `MAKEFLAGS' environment variable to pass the
1631         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1632         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1633
1634         We now behave more closely to the rest of the WebKit tools by first
1635         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1636         not set, just letting jhbuild itself figure out how many jobs to use.
1637
1638         * efl/jhbuildrc:
1639         * gtk/jhbuildrc:
1640
1641 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1642
1643         [Qt] Remove Qt specific WorkQueueItem definitions.
1644         https://bugs.webkit.org/show_bug.cgi?id=112891
1645
1646         This patch is preparation work for removing
1647         WorkQueue related code from TestRunnerQt and
1648         replacing it with generic TestRunner code.
1649
1650         Reviewed by Benjamin Poulain.
1651
1652         * DumpRenderTree/qt/TestRunnerQt.cpp:
1653         (TestRunnerQt::queueBackNavigation):
1654         (TestRunnerQt::queueForwardNavigation):
1655         (TestRunnerQt::queueLoadHTMLString):
1656         (TestRunnerQt::queueReload):
1657         (TestRunnerQt::queueLoadingScript):
1658         (TestRunnerQt::queueNonLoadingScript):
1659         (TestRunner::queueLoad):
1660         * DumpRenderTree/qt/TestRunnerQt.h:
1661         (TestRunnerQt):
1662         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1663         (LoadItem::invoke):
1664         (LoadHTMLStringItem::invoke):
1665         (LoadAlternateHTMLStringItem::invoke):
1666         (ReloadItem::invoke):
1667         (ScriptItem::invoke):
1668         (BackForwardItem::invoke):
1669         * DumpRenderTree/qt/WorkQueueItemQt.h:
1670         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1671         (LoadAlternateHTMLStringItem):
1672
1673 2013-03-26  Julie Parent  <jparent@chromium.org>
1674
1675         Flakiness dashboard: simplify logic around which tests to show.
1676         https://bugs.webkit.org/show_bug.cgi?id=113250
1677
1678         Reviewed by Ojan Vafai.
1679         
1680         The different filters for showing results are only used for layout
1681         tests, otherwise, we show everything.
1682         
1683         Change the defaults to false (what layout tests used), and only
1684         look at the values when viewing layout tests.
1685
1686         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1687         (htmlForTestsWithExpectationsButNoFailures):
1688         (shouldHideTest):
1689
1690 2013-03-26  Isaac Levy  <ilevy@google.com>
1691
1692         Update bots on test-results.appspot
1693         https://bugs.webkit.org/show_bug.cgi?id=113333
1694
1695         Reviewed by Ojan Vafai.
1696
1697         * TestResultServer/static-dashboards/builders.jsonp:
1698
1699 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1700
1701         Unreviewed GTK gardening.
1702
1703         * Scripts/run-gtk-tests:
1704         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1705
1706 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1707
1708         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1709         https://bugs.webkit.org/show_bug.cgi?id=113287
1710
1711         Reviewed by Jocelyn Turcotte.
1712
1713         * Scripts/run-qtwebkit-tests:
1714         (Options.__init__):
1715
1716 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1717
1718         [EFL] Enable IndexedDB by default
1719         https://bugs.webkit.org/show_bug.cgi?id=107248
1720
1721         Reviewed by Laszlo Gombos.
1722
1723         * Scripts/webkitperl/FeatureList.pm:
1724         Enable IndexedDB by default on EFL.
1725
1726 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1727
1728         Sheriffbot should explain rollout failures in a human readable form.
1729         https://bugs.webkit.org/show_bug.cgi?id=107092
1730
1731         Reviewed by Ryosuke Niwa.
1732
1733         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1734
1735         * Scripts/webkitpy/tool/bot/irc_command.py:
1736         (Rollout._check_diff_failure):
1737         (Rollout.execute):
1738         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1739         (IRCCommandTest.test_rollout):
1740
1741 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1742
1743         Unreviewed GTK gardening.
1744
1745         * Scripts/run-gtk-tests:
1746         (TestRunner): Skipping a failing unit test after r146518.
1747
1748 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1749
1750         Remove Lion leaks builder
1751         https://bugs.webkit.org/show_bug.cgi?id=113252
1752
1753         Reviewed by Andreas Kling.
1754
1755         Removed.
1756
1757         * BuildSlaveSupport/build.webkit.org-config/config.json:
1758
1759 2013-03-25  Kent Tamura  <tkent@chromium.org>
1760
1761         Rename ENABLE_INPUT_TYPE_DATETIME
1762         https://bugs.webkit.org/show_bug.cgi?id=113254
1763
1764         Reviewed by Kentaro Hara.
1765
1766         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1767         Actually I'd like to remove the code, but we shouldn't remove it yet
1768         because we shipped products with it on some platforms.
1769
1770         * Scripts/webkitperl/FeatureList.pm:
1771         * qmake/mkspecs/features/features.pri:
1772
1773 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1774
1775         Remove one more line that was intended to be removed in r146657.
1776
1777         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1778         (summarize_results):
1779
1780 2013-03-25  Roger Fong  <roger_fong@apple.com>
1781
1782         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1783         Re-enable WinEWS tests.
1784
1785         * Scripts/webkitpy/common/config/ports.py:
1786         (WinPort.run_bindings_tests_command):
1787         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1788         (WinEWS):
1789
1790 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1791
1792         Unreviewed, rolling out r146793.
1793         http://trac.webkit.org/changeset/146793
1794         https://bugs.webkit.org/show_bug.cgi?id=113248
1795
1796         Fix did not work (Requested by rfong on #webkit).
1797
1798         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1799         (WinEWS):
1800
1801 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1802
1803         REGRESSION(r146657): Test failures reported incorrectly
1804         https://bugs.webkit.org/show_bug.cgi?id=113223
1805
1806         Reviewed by Dirk Pranke.
1807
1808         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1809
1810         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1811         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1812
1813         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1814         (Manager.run):
1815
1816         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1817         (RunDetails.__init__):
1818         (summarize_results): Remove the line I intended to remove in r146657.
1819
1820         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1821         (logging_run): Return details instead of the exit code.
1822         (run_and_capture): Ditto.
1823
1824         (RunTest.test_full_results_html):
1825         (RunTest.test_hung_thread):
1826         (RunTest.test_no_tests_found):
1827         (RunTest.test_no_tests_found_2):
1828         (RunTest.test_repeat_each_iterations_num_tests):
1829         (RunTest.test_run_singly_actually_runs_tests):
1830         (RunTest.test_test_list):
1831         (RunTest.test_missing_and_unexpected_results):
1832         (RunTest.test_pixel_test_directories):
1833         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1834         (RunTest.test_crash_with_stderr):
1835         (RunTest.test_no_image_failure_with_image_diff):
1836         (RunTest.test_crash_log):
1837         (RunTest.test_exit_after_n_failures_upload):
1838         (RunTest.test_results_directory_absolute):
1839         (RunTest.test_results_directory_relative):
1840         (RunTest.test_retrying_and_flaky_tests):
1841         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1842         (RunTest.test_retrying_uses_retries_directory):
1843         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1844         (RunTest.test_output_diffs):
1845         (EndToEndTest.test_reftest_with_two_notrefs):
1846         (RebaselineTest.test_reset_results):
1847         (RebaselineTest.test_missing_results):
1848         (RebaselineTest.test_new_baseline):
1849
1850         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1851         (BuildBotPrinter.print_results):
1852         (BuildBotPrinter.print_unexpected_results):
1853         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1854         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1855
1856 2013-03-25  Julie Parent  <jparent@chromium.org>
1857
1858         Dashboard refactor: Move cross dashboard history related code into history.js.
1859         https://bugs.webkit.org/show_bug.cgi?id=113104
1860
1861         Reviewed by Ojan Vafai.
1862
1863         All functions relating to cross dashboard behavior move from being
1864         globals to methods on the history.History object. Names stay the same,
1865         except many are made private, ones that should have been constants now
1866         are, and the long standing TODO to change "currentState" to 
1867         dashboardSpecificState is done.
1868         
1869         We now create a global history object in dashboard_base, as an 
1870         intermediate measure.  Once the dashboard specific code is
1871         added to history, each DB will need to create its own, and this
1872         global will be eliminated.
1873         
1874         * TestResultServer/static-dashboards/aggregate_results.js:
1875         (handleValidHashParameter):
1876         (htmlForBuilder):
1877         (rawValuesHTML):
1878         * TestResultServer/static-dashboards/dashboard_base.js:
1879         (parseDashboardSpecificParameters):
1880         (defaultValue):
1881         (currentBuilderGroupCategory):
1882         (currentBuilderGroupName):
1883         (handleLocationChange):
1884         (expectationsMap):
1885         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1886         (generatePage):
1887         (.switch.return):
1888         (platformAndBuildType):
1889         (individualTests):
1890         (substringList):
1891         (processMissingAndExtraExpectations):
1892         (pathToFailureLog):
1893         (showPopupForBuild):
1894         (htmlForTestsWithExpectationsButNoFailures):
1895         (shouldHideTest):
1896         (isCrossBuilderView):
1897         (tableHeaders):
1898         (htmlForSingleTestRow):
1899         (htmlForTableColumnHeader):
1900         (generatePageForExpectationsUpdate):
1901         (handleUpdate):
1902         (nextUpdate):
1903         (setUpdateIndex):
1904         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1905         (.appendExpectationsItem):
1906         (loadExpectations):
1907         (.dummyNode.onload):
1908         (loadExpectationsLayoutTests):
1909         (appendExpectations):
1910         (htmlForNavBar):
1911         (checkBoxToToggleState):
1912         (linkHTMLToToggleState):
1913         (generatePageForBuilder):
1914         (isInvalidKeyForCrossBuilderView):
1915         (handleQueryParameterChange):
1916         (showLegend):
1917         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1918         (resetGlobals):
1919         (test):
1920         * TestResultServer/static-dashboards/history.js:
1921         (.):
1922         * TestResultServer/static-dashboards/history_unittests.js:
1923         * TestResultServer/static-dashboards/loader.js:
1924         (.):
1925         * TestResultServer/static-dashboards/loader_unittests.js:
1926         * TestResultServer/static-dashboards/timeline_explorer.js:
1927         (generatePage):
1928         (initCurrentBuilderTestResults):
1929         (selectBuild):
1930         (showResultsDelta):
1931         * TestResultServer/static-dashboards/treemap.js:
1932         (generatePage):
1933         (.switch.return):
1934         (handleFocus):
1935         * TestResultServer/static-dashboards/ui.js:
1936
1937 2013-03-25  Roger Fong  <roger_fong@apple.com>
1938
1939         Unreviewed. Enable WinEWS tests again.
1940
1941         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1942         (WinEWS):
1943
1944 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1945
1946         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1947         https://bugs.webkit.org/show_bug.cgi?id=112166
1948
1949         HarfBuzz 0.9.14 merged my patch for icu detection without
1950         pkg-config files, as needed by for example Ubuntu 12.04.
1951         This obsoletes our local workaround. Removed it for GTK and EFL.
1952
1953         Reviewed by Martin Robinson.
1954
1955         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1956         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1957         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1958         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1959
1960 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1961
1962         Unreviewed.  Move self from contributor to committer list.
1963
1964         * Scripts/webkitpy/common/config/committers.py:
1965
1966 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1967
1968         EWS should use a human readable port name when uploading layout test archives
1969         https://bugs.webkit.org/show_bug.cgi?id=113099
1970
1971         Reviewed by Dirk Pranke.
1972
1973         Use new port's object's name() method to report human readable port names.
1974         This will also help us resolving the bug to apply layout test results posted by EWS.
1975
1976         * Scripts/webkitpy/tool/bot/botinfo.py:
1977         (BotInfo.__init__): Take port's name.
1978         (BotInfo.summary_text):
1979
1980         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1981         (BotInfoTest.test_summary_text):
1982
1983         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1984         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1985
1986         * Scripts/webkitpy/tool/commands/queues.py:
1987         (PatchProcessingQueue.__init__): Initialize self._port.
1988         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1989         and use that for the attachment filename and the comment posted.
1990
1991         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1992         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1993         "mac-snowleopard" as expected for TestPort.
1994
1995 2013-03-22  Roger Fong  <roger_fong@apple.com>
1996
1997         Unreviewed. Turn off EWS test on Win again.
1998         The battle continues.
1999
2000         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2001         (WinEWS):
2002
2003 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2004
2005         NRWT: Enable pixel tests when retrying tests
2006         https://bugs.webkit.org/show_bug.cgi?id=112898
2007
2008         Reviewed by Dirk Pranke.
2009
2010         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2011         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2012         if we've forced pixel tests in the retry.
2013         (Manager._run_tests):
2014         (Manager._clean_up_run): Fixed the capitalizations.
2015         (Manager._force_pixel_tests_if_needed): Added.
2016
2017         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2018         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2019         'image_diff_percent' if it doesn't already exist.
2020
2021         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2022         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2023         treat this as a regular regression instead of a flakiness.
2024
2025         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2026         run had image diffs.
2027
2028         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2029         (summarized_results):
2030
2031         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2032         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2033         Also removed some dead code.
2034
2035         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2036         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2037         is set and pixel_tests_enabled is set to false.
2038         (EndToEndTest.test_reftest_with_two_notrefs):
2039
2040 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2041
2042         Make it possible to run layout tests on Retina MBP
2043         https://bugs.webkit.org/show_bug.cgi?id=93673
2044
2045         Reviewed by Ryosuke Niwa.
2046
2047         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2048         windows on 2x machines still run at 1x.
2049
2050         * DumpRenderTree/mac/DumpRenderTree.mm:
2051         (createWebViewAndOffscreenWindow):
2052         Reset the window resolution to 1x on creation.
2053         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2054         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2055         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2056         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2057         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2058         (WTR::PlatformWebView::PlatformWebView):
2059         Add NSWindow details, reset the window resolution to 1x on creation.
2060
2061 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2062
2063         Leak bots shouldn't build
2064         https://bugs.webkit.org/show_bug.cgi?id=112774
2065
2066         Reviewed by Simon Fraser.
2067
2068         Since leak bots use regular debug builds, there is no need to build on these bots.
2069         Simply downloading builds will dramatically improve the cycle time of these bots.
2070
2071         * BuildSlaveSupport/build.webkit.org-config/config.json:
2072         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2073         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2074         TestFactory instead of BuildAndTestFactory.
2075
2076 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2077
2078         [Qt] Fix the TestWebKitAPI build
2079         https://bugs.webkit.org/show_bug.cgi?id=113044
2080
2081         Reviewed by Tor Arne Vestbø.
2082
2083         The generate-forwarding-headers script would only be run
2084         after the targets in InjectedBundle.pri since the second
2085         addStrictSubdirOrderBetween call in
2086         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2087         the derived_sources -> injected_bundle order in SUBDIRS.
2088
2089         Fix it by only moving the dependent target at the end of
2090         SUBDIRS, don't touch its dependency.
2091
2092         * qmake/mkspecs/features/functions.prf:
2093
2094 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2095
2096         [EFL][WK2] View is not focused when fullscreen mode toggled
2097         https://bugs.webkit.org/show_bug.cgi?id=113009
2098
2099         Reviewed by Laszlo Gombos.
2100
2101         Set focus on view when fullscreen mode enabled/disabled
2102         by FullScreen API.
2103
2104         * MiniBrowser/efl/main.c:
2105         (on_fullscreen_accept):
2106         (on_fullscreen_deny):
2107
2108 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2109
2110         nrwt is no longer saving retry results in the retries/ subdirectory
2111         https://bugs.webkit.org/show_bug.cgi?id=112995
2112
2113         Reviewed by Ojan Vafai.
2114
2115         I think this has been broken a long time, unfortunately. This
2116         patch should fix that.
2117
2118         In order to do so, I had to pass the directory to use from
2119         the Worker object through the SingleTestWriter to the
2120         TestResultWriter. While I was plumbing that through, I rationalized
2121         the order of the parameter arguments a bit ...
2122
2123         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2124         (Worker._run_single_test):
2125         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2126         (run_single_test):
2127         (SingleTestRunner.__init__):
2128         (SingleTestRunner._run_compare_test):
2129         (SingleTestRunner._run_rebaseline):
2130         (SingleTestRunner._run_reftest):
2131         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2132         (write_test_result):
2133         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2134         (TestResultWriterTest.test_reftest_diff_image):
2135         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2136         (RunTest.test_retrying_uses_retries_directory):
2137
2138 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2139
2140         JSC profiler should have an at-a-glance report of the success of DFG optimization
2141         https://bugs.webkit.org/show_bug.cgi?id=112988
2142
2143         Reviewed by Geoffrey Garen.
2144
2145         * Scripts/display-profiler-output:
2146
2147 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2148
2149         [chromium] Linux ASAN WebKit canary is running out of memory
2150         https://bugs.webkit.org/show_bug.cgi?id=112978
2151
2152         Reviewed by Tony Chang.
2153
2154         Running the AddressSanitizer on a crash takes a lot of
2155         memory, so we should serialize access to it to avoid running
2156         out of memory on a machine.
2157
2158         * Scripts/webkitpy/layout_tests/port/chromium.py:
2159         (ChromiumPort._get_crash_log):
2160         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2161         (HttpLock.__init__):
2162         (HttpLock.wait_for_httpd_lock):
2163
2164 2013-03-21  Min Qin  <qinmin@chromium.org>
2165
2166         Cleanup android media layout test code
2167         https://bugs.webkit.org/show_bug.cgi?id=112944
2168
2169         Reviewed by Adam Barth.
2170
2171         Chromium change: https://codereview.chromium.org/12892010/
2172         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2173         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2174         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2175         Instead, we should switch to use content shell for layout tests.
2176
2177         * DumpRenderTree/chromium/TestShell.cpp:
2178         (TestShell::resetTestController):
2179
2180 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2181
2182         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2183         https://bugs.webkit.org/show_bug.cgi?id=112953
2184
2185         Reviewed by Tony Chang.
2186
2187         When I created the DumpRenderTree_resources target in r144863 I
2188         forgot to declare the needed dependencies on the other resource
2189         targets. Due to a quirk of ordering, this appears to have been fine
2190         w/ ninja but not w/ Xcode (which is still being used on the chromium
2191         mac valgrind bots). Declaring the dependencies fixes the build
2192         failures.
2193
2194         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2195
2196 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2197
2198         [WinCairo] Correct assert in Empty BitmapImage Test.
2199         https://bugs.webkit.org/show_bug.cgi?id=112934
2200
2201         Reviewed by Tim Horton.
2202
2203         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2204         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2205         to avoid ref counting assertion when leaving test scope.
2206
2207 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2208
2209         [GTK] generate-feature-defines-files is incompatible with Python3
2210         https://bugs.webkit.org/show_bug.cgi?id=112956
2211
2212         Reviewed by Martin Robinson.
2213
2214         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2215         method on the dictionary objects when iterating through said dictionaries.
2216
2217         * gtk/generate-feature-defines-files:
2218         (write_feature_defines_header):
2219         (write_flattened_feature_defines_file):
2220
2221 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2222
2223         kill-old-processes spits out error messages on Mac
2224         https://bugs.webkit.org/show_bug.cgi?id=112878
2225
2226         Reviewed by Jessie Berlin.
2227
2228         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2229         included in the list of options grep --help shows.
2230
2231         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2232
2233         * BuildSlaveSupport/kill-old-processes:
2234         (main):
2235
2236 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2237
2238         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2239         https://bugs.webkit.org/show_bug.cgi?id=112597
2240
2241         Reviewed by Xan Lopez.
2242
2243         These were introduced for the Chromium port in r105295. We need
2244         dummy implementations in order to compile the BlackBerry port.
2245
2246         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2247         (AccessibilityUIElement::scrollToMakeVisible):
2248         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2249         (AccessibilityUIElement::scrollToGlobalPoint):
2250
2251 2013-03-21  Roger Fong  <roger_fong@apple.com>
2252
2253         Re-enable WinEWS tests following r146376.
2254
2255         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2256         (WinEWS):
2257
2258 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2259
2260         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2261
2262         * Scripts/webkitpy/common/config/committers.py:
2263
2264 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2265
2266         [GTK] Missing atk in install-dependencies script
2267         https://bugs.webkit.org/show_bug.cgi?id=112272
2268
2269         Reviewed by Gustavo Noronha Silva.
2270
2271         * gtk/install-dependencies: Add missing atk dependency.
2272
2273 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2274
2275         [GTK] Missing backslash in install-dependencies script
2276         https://bugs.webkit.org/show_bug.cgi?id=112907
2277
2278         Reviewed by Philippe Normand.
2279
2280         * gtk/install-dependencies: Add missing backslash to dependencies
2281         list.
2282
2283 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2284
2285         EWS bots have stopped uploading results to bugzilla
2286         https://bugs.webkit.org/show_bug.cgi?id=101091
2287
2288         Reviewed by Adam Barth.
2289
2290         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2291         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2292         this relative file path resoled to a file inside a non-existent directory for "zip".
2293
2294         Fixed the bug by resolving both test results directory and zip archive paths in
2295         LayoutTestResultsReader.archive.
2296
2297         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2298         in the future.
2299
2300         * Scripts/webkitpy/common/system/filesystem_mock.py:
2301         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2302
2303         * Scripts/webkitpy/common/system/workspace.py:
2304         (Workspace.create_zip): Log the source path when "zip" failed.
2305
2306         * Scripts/webkitpy/common/system/workspace_mock.py:
2307         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2308
2309         * Scripts/webkitpy/common/system/workspace_unittest.py:
2310         (WorkspaceTest.test_create_zip_exception): Test that.
2311
2312         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2313         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2314         This is the actual bug fix.
2315
2316         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2317         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2318
2319 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2320
2321         [chromium] move WebThemeEngine implementations to TestRunner library
2322         https://bugs.webkit.org/show_bug.cgi?id=112751
2323
2324         Reviewed by Adam Barth.
2325
2326         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2327         * DumpRenderTree/DumpRenderTree.gypi:
2328         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2329         (WebKit):
2330         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2331         (WebTestRunner::TestInterfaces::themeEngine):
2332         (WebTestRunner):
2333         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2334         (WebKit):
2335         (TestInterfaces):
2336         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2337         (WebTestRunner::WebTestInterfaces::themeEngine):
2338         (WebTestRunner):
2339         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2340         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2341         (WebTestRunner):
2342         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2343         (WebTestRunner::WebTestThemeControlWin::box):
2344         (WebTestRunner::WebTestThemeControlWin::line):
2345         (WebTestRunner::WebTestThemeControlWin::triangle):
2346         (WebTestRunner::WebTestThemeControlWin::roundRect):
2347         (WebTestRunner::WebTestThemeControlWin::oval):
2348         (WebTestRunner::WebTestThemeControlWin::circle):
2349         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2350         (WebTestRunner::WebTestThemeControlWin::markState):
2351         (WebTestRunner::WebTestThemeControlWin::draw):
2352         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2353         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2354         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2355         (WebTestRunner):
2356         (WebTestThemeControlWin):
2357         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2358         (WebTestRunner):
2359         (WebTestThemeEngineMac):
2360         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2361         (+[FakeActiveWindow alwaysActiveWindow]):
2362         (+[FakeActiveWindow alwaysInactiveWindow]):
2363         (-[FakeActiveWindow initWithActiveControls:]):
2364         (-[FakeActiveWindow _hasActiveControls]):
2365         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2366         (WebTestRunner):
2367         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2368         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2369         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2370         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2371         (WebTestRunner):
2372         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2373         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2374         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2375         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2376         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2377         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2378         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2379         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2380         (WebTestRunner::WebTestThemeEngineWin::getSize):
2381         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2382         (WebTestRunner):
2383         (WebTestThemeEngineWin):
2384         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2385         * DumpRenderTree/chromium/TestShell.cpp:
2386         (TestShell::initialize):
2387         * DumpRenderTree/chromium/TestShell.h:
2388         (WebKit):
2389         * DumpRenderTree/chromium/TestShellMac.mm:
2390         (platformInit):
2391         * DumpRenderTree/chromium/TestShellWin.cpp:
2392         (platformInit):
2393         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2394
2395 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2396
2397         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2398
2399         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2400         New property sheet that does not link against CoreFoundation and
2401         CFNetwork.
2402         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2403         Use new TestWebKitAPICommonWinCairo property sheet.
2404         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2405         Ditto.
2406
2407 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2408
2409         [WinCairo] Unreviewed build fix for VS2010.
2410
2411         Had to add WinCairo-specific property sheets to deal with some
2412         library and path differences with the main Apple port.
2413
2414         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2415         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2416         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2417         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2418         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2419         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2420
2421 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2422
2423         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2424         https://bugs.webkit.org/show_bug.cgi?id=112849
2425
2426         Reviewed by Sam Weinig.
2427
2428         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2429         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2430         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2431
2432 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2433
2434         [WinCairo] Build WebKit Tools under VS2010
2435         https://bugs.webkit.org/show_bug.cgi?id=112821
2436
2437         Reviewed by Tim Horton.
2438
2439         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2440         Add WinCairo-specific build target.
2441         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2442         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2443         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2444         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2445         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2446         Add WinCairo-specific build target.
2447         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2448         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2449         Add WinCairo-specific build target.
2450         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2451         WinCairo-specific build target.
2452         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2453         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2454         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2455         specific build target.
2456         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2457         WinCairo-specific build target.
2458         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2459         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2460         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2461
2462 2013-03-20  Roger Fong  <roger_fong@apple.com>
2463
2464         API test gardening AppleWin port.
2465
2466         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2467
2468         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2469         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2470
2471 2013-03-20  Roger Fong  <roger_fong@apple.com>
2472
2473         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2474
2475         * EWSTools/start-queue-win.sh:
2476
2477 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2478
2479         Unreviewed, add myself to committers.py.
2480
2481 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2482
2483         Unreviewed. Adding another email for me.
2484
2485         * Scripts/webkitpy/common/config/committers.py:
2486
2487 2013-03-20  Justin Novosad  <junov@google.com>
2488
2489         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2490         https://bugs.webkit.org/show_bug.cgi?id=112605
2491
2492         Reviewed by James Robinson.
2493
2494         Deleting all the code that was used for propagating and supporting
2495         the Chromium setting for disabling deferred 2d canvas rendering.
2496
2497         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2498         (main):
2499         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2500         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2501         (WebTestRunner::WebPreferences::reset):
2502         (WebTestRunner::WebPreferences::applyTo):
2503         * DumpRenderTree/chromium/TestShell.cpp:
2504         (TestShell::TestShell):
2505         (TestShell::resetWebSettings):
2506         (TestShell::runFileTest):
2507         * DumpRenderTree/chromium/TestShell.h:
2508         (TestShell):
2509
2510 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2511
2512         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2513         https://bugs.webkit.org/show_bug.cgi?id=112699.
2514
2515         Reviewed by Adam Barth.
2516
2517         * Scripts/webkitpy/layout_tests/port/qt.py:
2518         (QtPort._search_paths):
2519         (QtPort._port_specific_expectations_files):
2520         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2521         (QtPortTest):
2522         (QtPortTest._assert_search_path):
2523         (QtPortTest._assert_expectations_files):
2524
2525 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2526
2527         [Qt] Enable kerning by default
2528         https://bugs.webkit.org/show_bug.cgi?id=112704
2529
2530         Reviewed by Jocelyn Turcotte.
2531
2532         Disable kerning by default, since some reference test expectations
2533         expect kerning to be default off.
2534
2535         * DumpRenderTree/qt/TestRunnerQt.cpp:
2536         (TestRunnerQt::reset):
2537         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2538         (WTR::activateFonts):
2539
2540 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2541
2542         [Qt] Remove empty function stubs from TestRunnerQt.
2543         https://bugs.webkit.org/show_bug.cgi?id=112799
2544
2545         We are reducing the code in TestRunnerQt step by step,
2546         in order to finally replace all of it with the generic
2547         TestRunner implementation.
2548         This patch removes several simple function stubs that
2549         currently do not implement any actual functionality.
2550
2551         Reviewed by Kenneth Rohde Christiansen.
2552
2553         * DumpRenderTree/qt/TestRunnerQt.cpp:
2554         * DumpRenderTree/qt/TestRunnerQt.h:
2555         (TestRunnerQt):
2556
2557 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2558
2559         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2560         https://bugs.webkit.org/show_bug.cgi?id=112687
2561
2562         Reviewed by Kenneth Rohde Christiansen.
2563
2564         Hide the SearchBar by default on window creation.
2565
2566         * MiniBrowser/efl/main.c:
2567         (window_create):
2568
2569 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2570
2571         Unreviewed, rolling out r146304.
2572         http://trac.webkit.org/changeset/146304
2573         https://bugs.webkit.org/show_bug.cgi?id=112788
2574
2575         to many expectations to update (Requested by antonm on
2576         #webkit).
2577
2578         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2579         * DumpRenderTree/DumpRenderTree.gypi:
2580         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2581         (WebKit):
2582         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2583         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2584         (TestInterfaces):
2585         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2586         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2587         * DumpRenderTree/chromium/TestShell.cpp:
2588         (TestShell::initialize):
2589         * DumpRenderTree/chromium/TestShell.h:
2590         (WebKit):
2591         * DumpRenderTree/chromium/TestShellMac.mm:
2592         (platformInit):
2593         * DumpRenderTree/chromium/TestShellWin.cpp:
2594         (platformInit):
2595         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2596         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2597         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2598         (WebThemeControlDRTWin::box):
2599         (WebThemeControlDRTWin::line):
2600         (WebThemeControlDRTWin::triangle):
2601         (WebThemeControlDRTWin::roundRect):
2602         (WebThemeControlDRTWin::oval):
2603         (WebThemeControlDRTWin::circle):
2604         (WebThemeControlDRTWin::nestedBoxes):
2605         (WebThemeControlDRTWin::markState):
2606         (WebThemeControlDRTWin::draw):
2607         (WebThemeControlDRTWin::drawTextField):
2608         (WebThemeControlDRTWin::drawProgressBar):
2609         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2610         (WebThemeControlDRTWin):
2611         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2612         (WebThemeEngineDRTMac):
2613         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2614         (+[FakeActiveWindow alwaysActiveWindow]):
2615         (+[FakeActiveWindow alwaysInactiveWindow]):
2616         (-[FakeActiveWindow initWithActiveControls:]):
2617         (-[FakeActiveWindow _hasActiveControls]):
2618         (WebThemeEngineDRTMac::paintScrollbarThumb):
2619         (stateToHIEnableState):
2620         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2621         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2622         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2623         (webRectToSkIRect):
2624         (drawControl):
2625         (drawTextField):
2626         (drawProgressBar):
2627         (WebThemeEngineDRTWin::paintButton):
2628         (WebThemeEngineDRTWin::paintMenuList):
2629         (WebThemeEngineDRTWin::paintScrollbarArrow):
2630         (WebThemeEngineDRTWin::paintScrollbarThumb):
2631         (WebThemeEngineDRTWin::paintScrollbarTrack):
2632         (WebThemeEngineDRTWin::paintSpinButton):
2633         (WebThemeEngineDRTWin::paintTextField):
2634         (WebThemeEngineDRTWin::paintTrackbar):
2635         (WebThemeEngineDRTWin::paintProgressBar):
2636         (WebThemeEngineDRTWin::getSize):
2637         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2638         (WebThemeEngineDRTWin):
2639         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2640
2641 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2642
2643         [Qt] Support -webkit-font-smoothing
2644         https://bugs.webkit.org/show_bug.cgi?id=106009
2645
2646         Reviewed by Jocelyn Turcotte.
2647
2648         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2649
2650         * DumpRenderTree/qt/TestRunnerQt.cpp:
2651         (TestRunnerQt::reset):
2652
2653 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2654
2655         [GTK] accessibility/aria-scrollbar-role.html is failing
2656         https://bugs.webkit.org/show_bug.cgi?id=98358
2657
2658         Reviewed by Martin Robinson.
2659
2660         Adds support for checking accessibility object's orientation.
2661         Orientation is checked by retrieving proper state of accessibility object.
2662
2663         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2664         (checkElementState):
2665         (AccessibilityUIElement::orientation):
2666         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2667         (WTR::AccessibilityUIElement::orientation):
2668
2669 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2670
2671         [chromium] move WebThemeEngine implementations to TestRunner library
2672         https://bugs.webkit.org/show_bug.cgi?id=112751
2673
2674         Reviewed by Adam Barth.
2675
2676         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2677         * DumpRenderTree/DumpRenderTree.gypi:
2678         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2679         (WebKit):
2680         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2681         (WebTestRunner::TestInterfaces::themeEngine):
2682         (WebTestRunner):
2683         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2684         (WebKit):
2685         (TestInterfaces):
2686         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2687         (WebTestRunner::WebTestInterfaces::themeEngine):
2688         (WebTestRunner):
2689         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2690         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2691         (WebTestRunner):
2692         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2693         (WebTestRunner::WebTestThemeControlWin::box):
2694         (WebTestRunner::WebTestThemeControlWin::line):
2695         (WebTestRunner::WebTestThemeControlWin::triangle):
2696         (WebTestRunner::WebTestThemeControlWin::roundRect):
2697         (WebTestRunner::WebTestThemeControlWin::oval):
2698         (WebTestRunner::WebTestThemeControlWin::circle):
2699         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2700         (WebTestRunner::WebTestThemeControlWin::markState):
2701         (WebTestRunner::WebTestThemeControlWin::draw):
2702         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2703         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2704         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2705         (WebTestRunner):
2706         (WebTestThemeControlWin):
2707         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2708         (WebTestRunner):
2709         (WebTestThemeEngineMac):
2710         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2711         (+[FakeActiveWindow alwaysActiveWindow]):
2712         (+[FakeActiveWindow alwaysInactiveWindow]):
2713         (-[FakeActiveWindow initWithActiveControls:]):
2714         (-[FakeActiveWindow _hasActiveControls]):
2715         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2716         (WebTestRunner):
2717         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2718         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2719         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2720         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2721         (WebTestRunner):
2722         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2723         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2724         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2725         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2726         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2727         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2728         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2729         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2730         (WebTestRunner::WebTestThemeEngineWin::getSize):
2731         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2732         (WebTestRunner):
2733         (WebTestThemeEngineWin):
2734         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2735         * DumpRenderTree/chromium/TestShell.cpp:
2736         (TestShell::initialize):
2737         * DumpRenderTree/chromium/TestShell.h:
2738         (WebKit):
2739         * DumpRenderTree/chromium/TestShellMac.mm:
2740         (platformInit):
2741         * DumpRenderTree/chromium/TestShellWin.cpp:
2742         (platformInit):
2743         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2744
2745 2013-03-19  Tony Chang  <tony@chromium.org>
2746
2747         Move testRunner.setTouchDragDropEnabled to internals.settings
2748         https://bugs.webkit.org/show_bug.cgi?id=112739
2749
2750         Reviewed by Adam Barth.
2751
2752         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2753         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2754         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2755         (TestRunner): Remove unnecessary code.
2756         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2757         (WebTestRunner::WebPreferences::reset):
2758         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2759
2760 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2761
2762         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2763         https://bugs.webkit.org/show_bug.cgi?id=112754
2764
2765         Reviewed by Darin Fisher.
2766
2767         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2768         now that it's always defined.
2769
2770         * DumpRenderTree/chromium/WebViewHost.cpp:
2771         * DumpRenderTree/chromium/WebViewHost.h:
2772         (WebViewHost):
2773
2774 2013-03-19  Kenneth Russell  <kbr@google.com>
2775
2776         Unreviewed, rolling out r146290.
2777         http://trac.webkit.org/changeset/146290
2778         https://bugs.webkit.org/show_bug.cgi?id=112751
2779
2780         Broke Chromium Mac build.
2781
2782         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2783         * DumpRenderTree/DumpRenderTree.gypi:
2784         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2785         (WebKit):
2786         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2787         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2788         (TestInterfaces):
2789         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2790         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2791         * DumpRenderTree/chromium/TestShell.cpp:
2792         (TestShell::initialize):
2793         * DumpRenderTree/chromium/TestShell.h:
2794         (WebKit):
2795         * DumpRenderTree/chromium/TestShellMac.mm:
2796         (platformInit):
2797         * DumpRenderTree/chromium/TestShellWin.cpp:
2798         (platformInit):
2799         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2800         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2801         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2802         (WebThemeControlDRTWin::box):
2803         (WebThemeControlDRTWin::line):
2804         (WebThemeControlDRTWin::triangle):
2805         (WebThemeControlDRTWin::roundRect):
2806         (WebThemeControlDRTWin::oval):
2807         (WebThemeControlDRTWin::circle):
2808         (WebThemeControlDRTWin::nestedBoxes):
2809         (WebThemeControlDRTWin::markState):
2810         (WebThemeControlDRTWin::draw):
2811         (WebThemeControlDRTWin::drawTextField):
2812         (WebThemeControlDRTWin::drawProgressBar):
2813         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2814         (WebThemeControlDRTWin):
2815         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2816         (WebThemeEngineDRTMac):
2817         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2818         (+[FakeActiveWindow alwaysActiveWindow]):
2819         (+[FakeActiveWindow alwaysInactiveWindow]):
2820         (-[FakeActiveWindow initWithActiveControls:]):
2821         (-[FakeActiveWindow _hasActiveControls]):
2822         (WebThemeEngineDRTMac::paintScrollbarThumb):
2823         (stateToHIEnableState):
2824         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2825         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2826         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2827         (webRectToSkIRect):
2828         (drawControl):
2829         (drawTextField):
2830         (drawProgressBar):
2831         (WebThemeEngineDRTWin::paintButton):
2832         (WebThemeEngineDRTWin::paintMenuList):
2833         (WebThemeEngineDRTWin::paintScrollbarArrow):
2834         (WebThemeEngineDRTWin::paintScrollbarThumb):
2835         (WebThemeEngineDRTWin::paintScrollbarTrack):
2836         (WebThemeEngineDRTWin::paintSpinButton):
2837         (WebThemeEngineDRTWin::paintTextField):
2838         (WebThemeEngineDRTWin::paintTrackbar):
2839         (WebThemeEngineDRTWin::paintProgressBar):
2840         (WebThemeEngineDRTWin::getSize):
2841         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2842         (WebThemeEngineDRTWin):
2843         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2844
2845 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2846
2847         [EFL] canvas-fallback-content.html is failing
2848         https://bugs.webkit.org/show_bug.cgi?id=111998
2849
2850         Reviewed by Chris Fleizach.
2851
2852         Adds support for getting platform name.
2853
2854         * DumpRenderTree/TestRunner.cpp:
2855         (TestRunner::staticValues):
2856         * DumpRenderTree/TestRunner.h:
2857         (TestRunner):
2858         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2859         (TestRunner::platformName):
2860
2861 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2862
2863         [chromium] move WebThemeEngine implementations to TestRunner library
2864         https://bugs.webkit.org/show_bug.cgi?id=112751
2865
2866         Reviewed by Adam Barth.
2867
2868         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2869         * DumpRenderTree/DumpRenderTree.gypi:
2870         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2871         (WebKit):
2872         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2873         (WebTestRunner::TestInterfaces::themeEngine):
2874         (WebTestRunner):
2875         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2876         (WebKit):
2877         (TestInterfaces):
2878         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2879         (WebTestRunner::WebTestInterfaces::themeEngine):
2880         (WebTestRunner):
2881         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2882         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2883         (WebTestRunner):
2884         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2885         (WebTestRunner::WebTestThemeControlWin::box):
2886         (WebTestRunner::WebTestThemeControlWin::line):
2887         (WebTestRunner::WebTestThemeControlWin::triangle):
2888         (WebTestRunner::WebTestThemeControlWin::roundRect):
2889         (WebTestRunner::WebTestThemeControlWin::oval):
2890         (WebTestRunner::WebTestThemeControlWin::circle):
2891         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2892         (WebTestRunner::WebTestThemeControlWin::markState):
2893         (WebTestRunner::WebTestThemeControlWin::draw):
2894         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2895         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2896         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2897         (WebTestRunner):
2898         (WebTestThemeControlWin):
2899         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2900         (WebTestRunner):
2901         (WebTestThemeEngineMac):
2902         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2903         (+[FakeActiveWindow alwaysActiveWindow]):
2904         (+[FakeActiveWindow alwaysInactiveWindow]):
2905         (-[FakeActiveWindow initWithActiveControls:]):
2906         (-[FakeActiveWindow _hasActiveControls]):
2907         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2908         (WebTestRunner):
2909         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2910         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2911         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2912         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2913         (WebTestRunner):
2914         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2915         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2916         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2917         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2918         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2919         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2920         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2921         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2922         (WebTestRunner::WebTestThemeEngineWin::getSize):
2923         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2924         (WebTestRunner):
2925         (WebTestThemeEngineWin):
2926         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2927         * DumpRenderTree/chromium/TestShell.cpp:
2928         (TestShell::initialize):
2929         * DumpRenderTree/chromium/TestShell.h:
2930         (WebKit):
2931         * DumpRenderTree/chromium/TestShellMac.mm:
2932         (platformInit):
2933         * DumpRenderTree/chromium/TestShellWin.cpp:
2934         (platformInit):
2935         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2936
2937 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2938
2939         [EFL][WK2] Separate WebView further from EwkView
2940         https://bugs.webkit.org/show_bug.cgi?id=111591
2941
2942         Reviewed by Caio Marcelo de Oliveira Filho.
2943
2944         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2945         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2946         since we can afford it having EWKViewGetWKView() private API to access WKView.
2947
2948         * TestWebKitAPI/PlatformWebView.h:
2949         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2950         (TestWebKitAPI::TEST):
2951         * TestWebKitAPI/efl/PlatformWebView.cpp:
2952         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2953         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2954         (TestWebKitAPI::PlatformWebView::resizeTo):
2955         (TestWebKitAPI::PlatformWebView::page):
2956         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2957         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2958         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2959         * WebKitTestRunner/PlatformWebView.h:
2960         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2961         (WTR::EventSenderProxy::dispatchEvent):
2962         (WTR::EventSenderProxy::keyDown):
2963         (WTR::EventSenderProxy::sendTouchEvent):
2964         (WTR::EventSenderProxy::setTouchModifier):
2965         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2966         (WTR::PlatformWebView::PlatformWebView):
2967         (WTR::PlatformWebView::~PlatformWebView):
2968         (WTR::PlatformWebView::resizeTo):
2969         (WTR::PlatformWebView::page):
2970         (WTR::PlatformWebView::focus):
2971         (WTR::PlatformWebView::windowSnapshotImage):
2972
2973 2013-03-19  Roger Fong  <roger_fong@apple.com>
2974
2975         Changes to VS2010 project files should only trigger builds on Windows bots.
2976         https://bugs.webkit.org/show_bug.cgi?id=112731
2977
2978         Reviewed by Timothy Horton.
2979
2980         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2981         (_should_file_trigger_build):
2982
2983 2013-03-19  Roger Fong  <roger_fong@apple.com>
2984
2985         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2986
2987         * Scripts/webkitpy/tool/steps/runtests.py:
2988         (RunTests.run):
2989         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2990         (RunTestsTest.test_webkit_run_unit_tests):
2991
2992 2013-03-19  Julie Parent  <jparent@chromium.org>
2993
2994         Dashboards: Introduce history namespace and unit tests.
2995         https://bugs.webkit.org/show_bug.cgi?id=112645
2996
2997         Reviewed by Ojan Vafai.
2998         
2999         Laying the framework for introducing the new history object and
3000         namespace.  This moves only static functions into the history
3001         namespace, and moves corresponding unit tests into seperate
3002         unit test file.
3003
3004         * TestResultServer/static-dashboards/aggregate_results.html:
3005         * TestResultServer/static-dashboards/dashboard_base.js:
3006         (parseCrossDashboardParameters):
3007         (parseDashboardSpecificParameters):
3008         (parseParameters):
3009         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3010         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3011         (.switch.return):
3012         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3013         * TestResultServer/static-dashboards/history.js: Added.
3014         * TestResultServer/static-dashboards/history_unittests.js: Added.
3015         * TestResultServer/static-dashboards/loader.js:
3016         (.):
3017         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3018         * TestResultServer/static-dashboards/run-unittests.html:
3019         * TestResultServer/static-dashboards/timeline_explorer.html:
3020         * TestResultServer/static-dashboards/timeline_explorer.js:
3021         * TestResultServer/static-dashboards/treemap.html:
3022         * TestResultServer/static-dashboards/treemap.js:
3023         (.switch.return):
3024         * TestResultServer/static-dashboards/ui.js:
3025
3026 2013-03-19  Daniel Bates  <dbates@webkit.org>
3027
3028         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3029         https://bugs.webkit.org/show_bug.cgi?id=112732
3030
3031         Reviewed by Eric Seidel.
3032
3033         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3034         of an existing file cannot be applied.
3035
3036         In particular, svn-{apply, unapply} compensate for differences in line endings
3037         by converting the line endings in a diff to match the line endings in the target
3038         file. The diff(1) command precedes the last line of a diff that adds a newline
3039         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3040         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3041         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3042         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3043         the newline characters in this special character sequence to match the line endings
3044         in the target file.
3045
3046         * Scripts/VCSUtils.pm:
3047         (parseDiff):
3048         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3049         Added tests:
3050             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3051             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3052             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3053             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3054         (escapeNewLineCharacters): Added.
3055         (toMacLineEndings): Added.
3056
3057 2013-03-19  James Robinson  <jamesr@chromium.org>
3058
3059         [chromium] Remove compositor settings that don't go through WebKit
3060         https://bugs.webkit.org/show_bug.cgi?id=112718
3061
3062         Reviewed by Adam Barth.
3063
3064         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3065         (main):
3066         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3067         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3068         (WebTestRunner::WebPreferences::reset):
3069         (WebTestRunner::WebPreferences::applyTo):
3070         * DumpRenderTree/chromium/TestShell.cpp:
3071         (TestShell::TestShell):
3072         (TestShell::resetWebSettings):
3073         * DumpRenderTree/chromium/TestShell.h:
3074         (TestShell):
3075
3076 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3077
3078         Unreviewed, rolling out r146101.
3079         https://bugs.webkit.org/show_bug.cgi?id=111884
3080
3081         re-enable custom freetype on asan; this needs to be on
3082         now that the bot is running lucid.
3083
3084         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3085
3086 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3087
3088         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3089         https://bugs.webkit.org/show_bug.cgi?id=112365
3090
3091         Reviewed by Benjamin Poulain.
3092
3093         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3094         harcoding it in wtf/Platform.h
3095
3096         * Scripts/webkitperl/FeatureList.pm:
3097
3098 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3099
3100         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3101         https://bugs.webkit.org/show_bug.cgi?id=94782
3102
3103         Based on patch by Csaba Osztrogonác.
3104         Reviewed by Jocelyn Turcotte.
3105
3106         The diff image is generated with bright red indicating errors, but letting the base image
3107         shine through so the context of the error-pixel can be identified.
3108
3109         * DumpRenderTree/qt/ImageDiff.cpp:
3110         (main):
3111
3112 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3113
3114         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3115
3116         Rubber-stamped by Csaba Osztrogonác.
3117
3118         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3119         since the latter might not cover the former.
3120
3121         * QtTestBrowser/launcherwindow.cpp:
3122         (LauncherWindow::print):
3123
3124 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3125
3126         Style tweeks to default.css.
3127         
3128         Rubber-stamped by David Kilzer.
3129         
3130         Give visited links a different color to other links, so you can
3131         see which builds you've viewed.
3132         
3133         Make the <small> text less tiny.
3134
3135         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3136         (small):
3137         (a:link,a:visited,a:active):
3138         (a:visited):
3139
3140 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3141
3142         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3143         https://bugs.webkit.org/show_bug.cgi?id=112494
3144
3145         Reviewed by Dirk Pranke.
3146
3147         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3148         Also merged two pairs of methods to cleanup the code.
3149
3150         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3151         (PerfTestsRunner.run): Merged _upload_and_show_results.
3152         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3153
3154 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3155
3156         [chromium] build xdisplaycheck when building DRT
3157         https://bugs.webkit.org/show_bug.cgi?id=112636
3158
3159         Reviewed by Tony Chang.
3160
3161         It appears that we need xdisplaycheck to be built in order for
3162         Xvfb to be started correctly on the bots, and DRT was missing
3163         a dependency on it. This may be the cause of the ASAN bot not
3164         starting up properly (it only builds DRT).
3165
3166         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3167
3168 2013-03-18  David Levin  <levin@chromium.org>
3169
3170         Implement icon change notification dump for Chromium's test shell.
3171         https://bugs.webkit.org/show_bug.cgi?id=112614
3172
3173         This was previously implemented for some other platforms in r58111
3174         and r116547.
3175
3176         In r122806, fast/dom/icon-url-property.html stopped using it, but
3177         it is useful for tests, so I plan to re-add it to that test again.
3178
3179         Reviewed by Jochen Eisinger.
3180
3181         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3182         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3183          icon change notifications from WebKit may be logged in test output.
3184         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3185         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3186         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3187         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3188         (WebTestRunner):
3189         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3190         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3191         (TestRunner):
3192         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3193         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3194         (WebTestRunner):
3195         * DumpRenderTree/chromium/WebViewHost.cpp:
3196         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3197         * DumpRenderTree/chromium/WebViewHost.h:
3198         (WebViewHost):
3199
3200 2013-03-18  Julie Parent  <jparent@chromium.org>
3201
3202         Cleanup: Move js for treemap and aggregate_results into own js files.
3203         https://bugs.webkit.org/show_bug.cgi?id=112618
3204
3205         Reviewed by Dirk Pranke.
3206         
3207         No functional changes, just moving the code into separate js file
3208         rather than inlined in the html, so we can test it, make it more
3209         modular, etc.  Other dashboard types are already done this way.
3210
3211         * TestResultServer/static-dashboards/aggregate_results.html:
3212         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3213         (generatePage):
3214         (handleValidHashParameter):
3215         (htmlForBuilder):
3216         (rawValuesHTML):
3217         (chartHTML):
3218         (filteredValues):
3219         (chart):
3220         (htmlForRevisionRows):
3221         (wrapHTMLInTable):
3222         (htmlForSummaryTable):
3223         (valuesPerExpectation):
3224         (htmlForTestType):
3225         (htmlForTableRow):
3226         (extendedEncode):
3227         * TestResultServer/static-dashboards/treemap.html:
3228         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3229         (humanReadableTime):
3230         (convertToWebTreemapFormat):
3231         (reverseSortByAverage):
3232         (generatePage):
3233         (focusPath):
3234         (.switch.return):
3235         (handleQueryParameterChange):
3236         (extractName):
3237         (fullName):
3238         (handleFocus.):
3239         (handleFocus):
3240
3241 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3242
3243         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3244         https://bugs.webkit.org/show_bug.cgi?id=112622
3245
3246         Reviewed by Dirk Pranke.
3247
3248         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3249         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3250
3251 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3252
3253         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3254         https://bugs.webkit.org/show_bug.cgi?id=112619
3255
3256         Reviewed by Dirk Pranke.
3257
3258         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3259         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3260
3261         * Scripts/webkitpy/layout_tests/port/gtk.py:
3262         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3263         Port._webkit_baseline_path method.
3264         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3265         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3266         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3267         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3268         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3269         that are expected based on the builder name.
3270
3271 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3272
3273         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3274         https://bugs.webkit.org/show_bug.cgi?id=112571
3275
3276         Reviewed by Adam Barth.
3277
3278         Update function declarations for new WebFileSystemType enum. (All
3279         changes are behind an #ifdef so we can sync required changes in embedders.)
3280
3281         * DumpRenderTree/chromium/WebViewHost.cpp:
3282         (WebViewHost::openFileSystem):
3283         (WebViewHost::deleteFileSystem):
3284         * DumpRenderTree/chromium/WebViewHost.h:
3285         (WebViewHost):
3286
3287 2013-03-18  Julie Parent  <jparent@chromium.org>
3288
3289         Cleanup: Move timeline_exporer js out of html file into js.
3290         https://bugs.webkit.org/show_bug.cgi?id=112188
3291
3292         Reviewed by Dirk Pranke.
3293         
3294         Moves the javascript out of the html file and into a new js file.
3295         This follows the format of flakiness_dashboard.{html|js}.
3296         
3297         Also moves code from dashboard_base that is used only by this one
3298         dashboard, and makes it private to the dashboard.
3299
3300         * TestResultServer/static-dashboards/dashboard_base.js:
3301         * TestResultServer/static-dashboards/timeline_explorer.html:
3302         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3303         (generatePage):
3304         (initCurrentBuilderTestResults):
3305         (shouldShowWebKitRevisionsOnly):
3306         (updateTimelineForBuilder.):
3307         (updateTimelineForBuilder):
3308         (selectBuild):
3309         (updateBuildIndicator):
3310         (.addRow):
3311         (.addNumberRow):
3312         (.inspectorNode.getElementsByTagName.0.onclick):
3313         (.inspectorNode.getElementsByTagName.1.onclick):
3314         (.inspectorNode.getElementsByTagName.2.onclick):
3315         (updateBuildInspector):
3316         (showResultsDelta):
3317         (decompressResults.addFlakyDelta):
3318         (decompressResults):
3319
3320 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3321
3322         Unreviewed, rolling out r145272.
3323         http://trac.webkit.org/changeset/145272
3324         https://bugs.webkit.org/show_bug.cgi?id=111884
3325
3326         Turns out the ASAN build is still broken; possibly there's
3327         something still setting LD_LIBRARY_PATH, or possibly there's
3328         something else wrong. In the meantime, we need it to work again.
3329
3330         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3331
3332 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3333
3334         delete-stale-build-files is too aggressive
3335         https://bugs.webkit.org/show_bug.cgi?id=112595
3336
3337         Reviewed by Tim Horton.
3338
3339         It appears that whitelisting file extensions to keep is not a good idea.
3340         Blacklist files to delete instead, and only delete .o files for now.
3341         We can add more file extensions as needed.
3342
3343         * BuildSlaveSupport/delete-stale-build-files:
3344
3345 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3346
3347         Disable accessibility notifications after each test
3348         https://bugs.webkit.org/show_bug.cgi?id=112579
3349
3350         Reviewed by Tim Horton.
3351         
3352         In WebKitTestRunner, if any tests triggered accessibility notifications,
3353         the global notification handler would thereafter be active, and fire
3354         notifications for all subsequent tests.
3355         
3356         Fix by implementing AccessibilityController::resetToConsistentState() for
3357         Mac, and using it to clear the global notification handler.
3358
3359         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3360         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3361         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3362         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3363         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3364         (e.g. because of -autorelease).
3365         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3366         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3367         if there is one.
3368         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3369         Add -stopObserving
3370         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3371         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3372         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3373         center.
3374
3375 2013-03-18  Dana Jansens  <danakj@chromium.org>
3376
3377         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3378         https://bugs.webkit.org/show_bug.cgi?id=112392
3379
3380         Reviewed by James Robinson.
3381
3382         Removes the command line flag option from DRT.
3383
3384         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3385         (main):
3386
3387 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3388
3389         [GTK] plugins/plugin-clip-subframe.html is failing
3390         https://bugs.webkit.org/show_bug.cgi?id=112570
3391
3392         Reviewed by Martin Robinson.
3393
3394         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3395
3396 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3397
3398         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3399         https://bugs.webkit.org/show_bug.cgi?id=112442
3400
3401         Reviewed by Gustavo Noronha Silva.
3402
3403         * GtkLauncher/main.c:
3404         (reloadCb):
3405         (createToolbar):
3406         (createWindow):
3407
3408 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3409
3410         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3411         https://bugs.webkit.org/show_bug.cgi?id=112205
3412
3413         Disable this API test until Geoff can fix it.
3414
3415         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3416         (TestWebKitAPI::TEST):
3417
3418 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3419
3420         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3421         https://bugs.webkit.org/show_bug.cgi?id=112478
3422
3423         Reviewed by Tony Chang.
3424
3425         There is nothing that ensures that the log messages from the plugin
3426         come in before the layout test finished loading.
3427
3428         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3429         (PassDifferentNPPStruct::NPP_SetWindow):
3430         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3431         (NPP_SetWindow):
3432
3433 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3434
3435         Have the mac port support per_test_timeout in webkitpy
3436         https://bugs.webkit.org/show_bug.cgi?id=112466
3437
3438         Reviewed by Dirk Pranke.
3439         
3440         Both WTR and DRT handle --timeout arguments, so we can
3441         have the scripts pass the timeout values down to the tools.
3442
3443         * Scripts/webkitpy/layout_tests/port/mac.py:
3444         (MacPort.supports_per_test_timeout):
3445
3446 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3447
3448         Remove setAsynchronousSpellCheckingEnabled from test runners
3449         https://bugs.webkit.org/show_bug.cgi?id=112362
3450
3451         Reviewed by Tony Chang.
3452
3453         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3454         in internals.settings, so all ports can share it.
3455
3456         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3457         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3458         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3459         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3460         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3461         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3462         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3463         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3464         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3465         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3466         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3467         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3468
3469 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3470
3471         Fix the stupid unit tests.
3472
3473         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3474         (test_sample_process):
3475
3476 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3477
3478         Collect samples for unresponsive web processes
3479         https://bugs.webkit.org/show_bug.cgi?id=112409
3480
3481         Reviewed by Tim Horton.
3482         
3483         When we detect that a subprocess was unresponsive, run the 'sample'
3484         tool on that process, for the Mac port.
3485         
3486         The sample will be linked to from the results.html page, next
3487         to the crash log link.
3488
3489         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3490         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3491         look for samples on disk.
3492         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3493         (TestResultWriter):
3494         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3495         -sample.txt files, and have it copy their contents to a new file
3496         next to the test that spawned them (as we do for crash logs).
3497         * Scripts/webkitpy/layout_tests/port/base.py:
3498         (Port.look_for_new_samples): Base class does nothing for sampling.
3499         * Scripts/webkitpy/layout_tests/port/driver.py:
3500         (Driver._check_for_driver_crash): Kick off a sample if we detected
3501         that the subprocess was unresponsive.
3502         * Scripts/webkitpy/layout_tests/port/mac.py:
3503         (MacPort.sample_file_path): Utility to generate the file path
3504         to the generated sample files at the top level of layout-test-results.
3505         (MacPort.look_for_new_crash_logs): Fix typo
3506         (MacPort.look_for_new_samples): New function to find sample files.
3507         (MacPort.sample_process): Use the utility function to get the file path.
3508
3509 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3510
3511         [Qt] Remove simple getters and setters from TestRunnerQt
3512         https://bugs.webkit.org/show_bug.cgi?id=112343
3513
3514         Reviewed by Benjamin Poulain.
3515
3516         The removed functions and boolean members
3517         are being replaced by the implementations in the
3518         generic TestRunner.h.
3519
3520         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3521         (DumpRenderTree::dumpFrameScrollPosition):
3522         (DumpRenderTree::dumpFramesAsText):
3523         (DumpRenderTree::dump):
3524         (DumpRenderTree::titleChanged):
3525         (DumpRenderTree::dumpDatabaseQuota):
3526         (DumpRenderTree::dumpApplicationCacheQuota):
3527         (DumpRenderTree::statusBarMessage):
3528         (DumpRenderTree::createWindow):
3529         * DumpRenderTree/qt/TestRunnerQt.cpp:
3530         (TestRunnerQt::reset):
3531         * DumpRenderTree/qt/TestRunnerQt.h:
3532         (TestRunnerQt):
3533
3534 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3535
3536         Update the link on build.webkit.org to refer to perf.webkit.org
3537         https://bugs.webkit.org/show_bug.cgi?id=112416
3538
3539         Reviewed by Philip Rogers.
3540
3541         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3542
3543         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3544
3545 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3546
3547         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3548         https://bugs.webkit.org/show_bug.cgi?id=112394
3549
3550         Reviewed by Philippe Normand.
3551
3552         * GtkLauncher/main.c:
3553         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3554
3555 2013-03-14  Andreas Kling  <akling@apple.com>
3556
3557         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3558         <http://webkit.org/b/111815>
3559         <rdar://problem/13380145>
3560
3561         Reviewed by Anders Carlsson.
3562
3563         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3564         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3565         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3566
3567         * WebKitTestRunner/PlatformWebView.h:
3568         (PlatformWebView):
3569         * WebKitTestRunner/TestController.cpp:
3570         (WTR::TestController::createOtherPage):
3571         (WTR::TestController::createWebViewWithOptions):
3572         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3573         (WTR::PlatformWebView::didInitializeClients):
3574
3575 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3576
3577         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3578         https://bugs.webkit.org/show_bug.cgi?id=112122
3579
3580         Reviewed by Kenneth Rohde Christiansen.
3581
3582         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3583
3584         * MiniBrowser/efl/main.c:
3585         (_Browser_Window):
3586         (search_box_show):
3587         (search_box_hide):
3588         (on_key_down):
3589         (on_url_changed):
3590         (on_search_field_aborted):
3591         (on_search_field_activated):
3592         (on_search_field_clicked):
3593         (on_search_backward_button_clicked):
3594         (on_search_forward_button_clicked):
3595         (window_create):
3596
3597 2013-03-14  Julie Parent  <jparent@chromium.org>
3598
3599         Cleanup: Remove g_resourceLoader.
3600         https://bugs.webkit.org/show_bug.cgi?id=112305
3601
3602         Reviewed by Dirk Pranke.
3603         
3604         Removing another global.
3605         
3606         Now, each dashboard creates its own loader, rather than having
3607         a general global one.
3608         
3609         Remove usage of g_resourceLoader.isLoadingComplete from 
3610         handleLocationChange by ensuring that handleLocationChange is
3611         never called before the loader is done.  It was called in two
3612         places before: 1 was from the callback when the loader is done,
3613         so that was obviously true, and the other was from onhashchange,
3614         where it would just return rather than running.  Instead, lets
3615         only register the onhashchange handler once the loader is
3616         setup, so the check is no longer necessary.
3617         
3618         Remove isLoadingComplete since it is now unused.
3619         
3620         Callback for loader is now initializeHistory, rather than just
3621         handleLocationChange which will set up the hashchange handler now.
3622         This will all eventually be moving to a new History object.
3623
3624         * TestResultServer/static-dashboards/aggregate_results.html:
3625         * TestResultServer/static-dashboards/dashboard_base.js:
3626         (handleLocationChange):
3627         (intializeHistory):
3628         (decompressResults):
3629         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3630         (generatePage):
3631         * TestResultServer/static-dashboards/loader.js:
3632         (.):
3633         * TestResultServer/static-dashboards/loader_unittests.js:
3634         * TestResultServer/static-dashboards/timeline_explorer.html:
3635         * TestResultServer/static-dashboards/treemap.html:
3636
3637 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3638
3639         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3640         https://bugs.webkit.org/show_bug.cgi?id=109404
3641
3642         Reviewed by Tony Chang.
3643
3644         Removes all the code related to smartInsertDeleteEnabled and
3645         selectTrailingWhitespaceEnabled settings as they will be managed from
3646         internals from now on.
3647
3648         * DumpRenderTree/TestRunner.cpp:
3649         (TestRunner::staticFunctions):
3650         * DumpRenderTree/TestRunner.h:
3651         (TestRunner):
3652         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3653         (WebKit):
3654         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3655         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3656         (DumpRenderTree):
3657         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3658         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3659         (WebTestRunner::WebTestProxy::didStopLoading):
3660         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3661         (WebTestRunner::TestRunner::TestRunner):
3662         (WebTestRunner::TestRunner::reset):
3663         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3664         (TestRunner):
3665         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3666         (WebTestRunner::WebPreferences::applyTo): Set default values for
3667         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3668         Chromium DRT default values are different from Chromium browser.
3669         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3670         * DumpRenderTree/chromium/WebViewHost.cpp:
3671         * DumpRenderTree/chromium/WebViewHost.h:
3672         (WebViewHost):
3673         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3674         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3675         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3676         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3677         (resetDefaultsToConsistentValues):
3678         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3679         * DumpRenderTree/mac/DumpRenderTree.mm:
3680         (resetWebViewToConsistentStateBeforeTesting):
3681         * DumpRenderTree/mac/TestRunnerMac.mm:
3682         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3683         (WebCore::WebPage::resetSettings):
3684         * DumpRenderTree/qt/TestRunnerQt.cpp:
3685         * DumpRenderTree/qt/TestRunnerQt.h:
3686         (TestRunnerQt):
3687         * DumpRenderTree/win/DumpRenderTree.cpp:
3688         (resetWebViewToConsistentStateBeforeTesting):
3689         * DumpRenderTree/win/TestRunnerWin.cpp:
3690         * DumpRenderTree/wx/TestRunnerWx.cpp:
3691
3692 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3693
3694         [Qt] Disable DRT on Windows
3695
3696         Reviewed by Jocelyn Turcotte.
3697
3698         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3699
3700         * qmake/mkspecs/features/configure.prf:
3701
3702 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3703
3704         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
3705         https://bugs.webkit.org/show_bug.cgi?id=110728
3706
3707         Reviewed by Gyuyoung Kim.
3708
3709         Use the page group to create the view object.
3710
3711         * MiniBrowser/efl/main.c:
3712         (window_create):
3713
3714 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3715
3716         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
3717
3718         Reviewed by Tor Arne Vestbø.
3719
3720         The mock versions of these web facing features should be instantiated when
3721         running in DumpRenderTree only. In order for them to work, no extra Qt modules
3722         such as QtLocation are actually needed.
3723
3724         This patch decouples enabling device orientation/motion and geolocation from
3725         the underlying Qt modules and makes them available in developer builds
3726         (!production_build) and backed by mock backends when running in drt.
3727
3728         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
3729         developers the web facing features are always enabled (although requests will
3730         time out) and the mock backends are enabled inside DRT, allowing for the layout
3731         tests to run with less dependencies.
3732
3733         In addition this also enables the mock device motion client, which was
3734         previously never instantiated.
3735
3736         * qmake/mkspecs/features/features.prf:
3737
3738 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3739
3740         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
3741         https://bugs.webkit.org/show_bug.cgi?id=112340
3742
3743         Reviewed by Simon Hausmann.
3744
3745         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3746         (DumpRenderTree::dump):
3747             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
3748         (DumpRenderTree::dumpApplicationCacheQuota):
3749         * DumpRenderTree/qt/TestRunnerQt.cpp:
3750         (TestRunnerQt::reset):
3751         * DumpRenderTree/qt/TestRunnerQt.h:
3752         (TestRunnerQt):
3753
3754 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3755
3756         [Qt] Port DRT to use TestRunner::dumpAsText()
3757         https://bugs.webkit.org/show_bug.cgi?id=112260
3758
3759         Reviewed by Benjamin Poulain.
3760
3761         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3762         (WebCore::DumpRenderTree::open):
3763         (WebCore::methodNameStringForFailedTest):
3764             Change parameter from type TestRunnerQt* to TestRunner*.
3765         (WebCore::DumpRenderTree::dump):
3766             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3767             Instead we should rely on TestRunner::generatePixelResults().
3768         * DumpRenderTree/qt/TestRunnerQt.cpp:
3769         (TestRunnerQt::reset):
3770         * DumpRenderTree/qt/TestRunnerQt.h:
3771         (TestRunnerQt):
3772
3773 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3774
3775         Implement FontLoader interface
3776         https://bugs.webkit.org/show_bug.cgi?id=98395
3777
3778         Reviewed by Eric Seidel.
3779
3780         Enable FontLoadEvents runtime flag for TestShell.
3781
3782         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3783         (WebTestRunner::TestInterfaces::TestInterfaces):
3784
3785 2013-03-13  Julie Parent  <jparent@chromium.org>
3786
3787         CLeanup: remove unnecessary call to parseParameters.
3788         https://bugs.webkit.org/show_bug.cgi?id=112309
3789
3790         Reviewed by Ojan Vafai.
3791         
3792         We call parseCrossDashboardParameters when the dashboard initially
3793         loads to set the state required for loadBuildersList, and then we
3794         call it again once we are fully done with loading, so there is no
3795         reason to call it in the middle of the loading process here.
3796
3797         * TestResultServer/static-dashboards/loader.js:
3798         (.):
3799
3800 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3801
3802         Unreviewed. Now I'm a reviewer :)
3803
3804         * Scripts/webkitpy/common/config/committers.py:
3805
3806 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3807
3808         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3809         https://bugs.webkit.org/show_bug.cgi?id=112277
3810
3811         Reviewed by Adam Barth.
3812
3813         * Scripts/webkitperl/FeatureList.pm:
3814         * qmake/mkspecs/features/features.pri:
3815
3816 2013-03-13  Adam Barth  <abarth@webkit.org>
3817
3818         run-perf-tests should support content_shell
3819         https://bugs.webkit.org/show_bug.cgi?id=112291
3820
3821         Reviewed by Eric Seidel.
3822
3823         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3824         (PerfTestsRunner._parse_args):
3825
3826 2013-03-13  Oliver Hunt  <oliver@apple.com>
3827
3828         Simplify Checked<> multiplication
3829         https://bugs.webkit.org/show_bug.cgi?id=112286
3830
3831         Reviewed by James Robinson.
3832
3833         Add tests for multiplication by zero and max to ensure we don't
3834         mess them up should we ever make changes to Checked<> in future.
3835
3836         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3837         (TestWebKitAPI):
3838
3839 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3840
3841         [Qt] Unreviewed prospective Windows build fix
3842
3843         Do the usual thing, include the moc generated code in the .cpp file instead
3844         of compiling it standalone, to ensure that config.h is included, too, and
3845         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3846
3847         * DumpRenderTree/qt/EventSenderQt.cpp:
3848
3849 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3850
3851         [Qt] Port TestRunner::findString to shared interface
3852         https://bugs.webkit.org/show_bug.cgi?id=112147
3853
3854         Reviewed by Jocelyn Turcotte.
3855
3856         This patch also removes DumpRenderTree and some other helper classes from
3857         the WebCore namespace, to which they do not really belong.
3858
3859         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3860         (main):
3861         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3862         (DumpRenderTree::DumpRenderTree):
3863         (DumpRenderTree::~DumpRenderTree):
3864         (DumpRenderTree::instance):
3865         (DumpRenderTree::setShouldTimeout):
3866         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3867         (DumpRenderTree):
3868         * DumpRenderTree/qt/EventSenderQt.cpp:
3869         (EventSender::contextClick):
3870         (EventSender::sendEvent):
3871         (EventSender::postEvent):
3872         * DumpRenderTree/qt/EventSenderQt.h:
3873         (EventSender::isGraphicsBased):
3874         * DumpRenderTree/qt/TestRunnerQt.cpp:
3875         (TestRunnerQt::TestRunnerQt):
3876         (TestRunner::findString):
3877         (TestRunnerQt::setMockDeviceOrientation):
3878         (TestRunnerQt::setGeolocationPermission):
3879         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3880         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3881         (TestRunnerQt::setMockGeolocationPosition):
3882         * DumpRenderTree/qt/TestRunnerQt.h:
3883         (TestRunnerQt):
3884
3885 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3886
3887         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3888         https://bugs.webkit.org/show_bug.cgi?id=112129
3889
3890         Reviewed by Adam Barth.
3891
3892         Following Chromium
3893         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3894         this is being renamed to better explain what it does.
3895
3896         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3897
3898 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3899
3900         [Qt] Unreviewed trivial typo fix
3901
3902         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3903         TextRunner.h. Thanks Zeno :)
3904
3905 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3906
3907         [Qt] Prepare DRT for transition to shared TestRunner interface
3908         https://bugs.webkit.org/show_bug.cgi?id=112144
3909
3910         Reviewed by Benjamin Poulain.
3911
3912         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3913         the JSC C API based one.
3914
3915         This is impplemented by instantiating the QObject based testRunner in
3916         the global object, then instantiating the JSC C based TestRunner
3917         separately and placing it "behind" the QObject based testRunner through
3918         injection of the individual functions through proxies. (prototype
3919         chaining doesn't work due to the this object and Function.prototype.bind
3920         doesn't work due to the native function)
3921
3922         This allows for porting over method by method by removing the method
3923         from the QObject TestRunnerQt and implementing it in the JSC C based
3924         TestRunner.
3925
3926         In order for this to link and run dummy implementations of all the
3927         necessary TestRunner functions are provided.
3928
3929         * DumpRenderTree/qt/DumpRenderTree.pro:
3930         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3931         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3932         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3933         (WebCore::DumpRenderTree::initJSObjects):
3934         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3935         (DumpRenderTree):
3936         * DumpRenderTree/qt/TestRunnerQt.cpp:
3937         (TestRunner::~TestRunner):
3938         (TestRunner::addDisallowedURL):
3939         (TestRunner::queueLoad):
3940         (TestRunner::removeAllVisitedLinks):
3941         (TestRunner::setAcceptsEditing):
3942         (TestRunner::simulateLegacyWebNotificationClick):
3943         (TestRunner::setWindowIsKey):
3944         (TestRunner::setAlwaysAcceptCookies):
3945         (TestRunner::addOriginAccessWhitelistEntry):
3946         (TestRunner::setWebViewEditable):
3947         (TestRunner::clearAllApplicationCaches):
3948         (TestRunner::setTextDirection):
3949         (TestRunner::notifyDone):
3950         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3951         (TestRunner::overridePreference):
3952         (TestRunner::pathToLocalResource):
3953         (TestRunner::removeAllWebNotificationPermissions):
3954         (TestRunner::simulateWebNotificationClick):
3955         (TestRunner::closeIdleLocalStorageDatabases):
3956         (TestRunner::focusWebView):
3957         (TestRunner::setBackingScaleFactor):
3958         (TestRunner::removeChromeInputField):
3959         (TestRunner::addChromeInputField):
3960         (TestRunner::originsWithLocalStorage):
3961         (TestRunner::deleteAllLocalStorage):
3962         (TestRunner::deleteLocalStorageForOrigin):
3963         (TestRunner::observeStorageTrackerNotifications):
3964         (TestRunner::syncLocalStorage):
3965         (TestRunner::windowCount):
3966         (TestRunner::setWaitToDump):
3967         (TestRunner::waitForPolicyDelegate):
3968         (TestRunner::webHistoryItemCount):
3969         (TestRunner::showWebInspector):
3970         (TestRunner::closeWebInspector):
3971         (TestRunner::evaluateInWebInspector):
3972         (TestRunner::setSerializeHTTPLoads):
3973         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3974         (TestRunner::setCustomPolicyDelegate):
3975         (TestRunner::setDatabaseQuota):
3976         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3977         (TestRunner::resetPageVisibility):
3978         (TestRunner::keepWebHistory):
3979         (TestRunner::goBack):
3980         (TestRunner::originsWithApplicationCache):
3981         (TestRunner::applicationCacheDiskUsageForOrigin):
3982         (TestRunner::display):
3983         (TestRunner::dispatchPendingLoadRequests):
3984         (TestRunner::clearPersistentUserStyleSheet):
3985         (TestRunner::callShouldCloseOnWebView):
3986         (TestRunner::copyDecodedHostName):
3987         (TestRunner::clearBackForwardList):
3988         (TestRunner::clearAllDatabases):
3989         (TestRunner::clearApplicationCacheForOrigin):
3990         (TestRunner::apiTestGoToCurrentBackForwardItem):
3991         (TestRunner::authenticateSession):
3992         (TestRunner::abortModal):
3993         (TestRunner::setStorageDatabaseIdleInterval):
3994         (TestRunner::setAsynchronousSpellCheckingEnabled):
3995         (TestRunner::setXSSAuditorEnabled):
3996         (TestRunner::setSpatialNavigationEnabled):
3997         (TestRunner::setScrollbarPolicy):
3998         (TestRunner::setJavaScriptCanAccessClipboard):
3999         (TestRunner::setAutomaticLinkDetectionEnabled):
4000         (TestRunner::setUserStyleSheetEnabled):
4001         (TestRunner::setUserStyleSheetLocation):
4002         (TestRunner::setUseDashboardCompatibilityMode):
4003         (TestRunner::setTabKeyCyclesThroughElements):
4004         (TestRunner::setSmartInsertDeleteEnabled):
4005         (TestRunner::setSelectTrailingWhitespaceEnabled):
4006         (TestRunner::setPrivateBrowsingEnabled):
4007         (TestRunner::setPluginsEnabled):
4008         (TestRunner::setPopupBlockingEnabled):
4009         (TestRunner::setMockSpeechInputDumpRect):
4010         (TestRunner::setPersistentUserStyleSheetLocation):
4011         (TestRunner::setMockGeolocationPosition):
4012         (TestRunner::setMockGeolocationPositionUnavailableError):
4013         (TestRunner::setMockDeviceOrientation):
4014         (TestRunner::setMainFrameIsFirstResponder):
4015         (TestRunner::setIconDatabaseEnabled):
4016         (TestRunner::setGeolocationPermission):
4017         (TestRunner::setDefersLoading):
4018         (TestRunner::setCacheModel):
4019         (TestRunner::setAuthorAndUserStylesEnabled):
4020         (TestRunner::setAllowFileAccessFromFileURLs):
4021         (TestRunner::setAppCacheMaximumSize):
4022         (TestRunner::setAllowUniversalAccessFromFileURLs):
4023         (TestRunner::setApplicationCacheOriginQuota):
4024         (TestRunner::denyWebNotificationPermission):
4025         (TestRunner::grantWebNotificationPermission):
4026         (TestRunner::setValueForUser):
4027         (TestRunner::setViewModeMediaFeature):
4028         (TestRunner::setPageVisibility):
4029         (TestRunner::addMockSpeechInputResult):
4030         (TestRunner::removeOriginAccessWhitelistEntry):
4031         (TestRunner::addUserScript):
4032         (TestRunner::isCommandEnabled):
4033         (TestRunner::evaluateScriptInIsolatedWorld):
4034         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
4035         (TestRunner::copyEncodedHostName):
4036         (TestRunner::addUserStyleSheet):
4037         (TestRunner::findString):
4038         (TestRunner::execCommand):
4039         (TestRunner::localStorageDiskUsageForOrigin):
4040
4041 2013-03-12  Julie Parent  <jparent@chromium.org>
4042
4043         Cleanup: Move flatten-trie to loader.
4044         https://bugs.webkit.org/show_bug.cgi?id=112196
4045
4046         Reviewed by Dirk Pranke.
4047
4048         flatten-trie is used only by the loader, so move it there and make it
4049         private, rather than global in dashbaord_base. Moved the corresponding
4050         unit test from flakiness_dashboard_unittests to loader_unittests.
4051         
4052         * TestResultServer/static-dashboards/dashboard_base.js:
4053         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4054         * TestResultServer/static-dashboards/loader.js:
4055         (.):
4056         * TestResultServer/static-dashboards/loader_unittests.js:
4057
4058 2013-03-12  Oliver Hunt  <oliver@apple.com>
4059
4060         Unbreak api tests
4061
4062         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4063         (TestWebKitAPI):
4064
4065 2013-03-12  Tim Horton  <timothy_horton@apple.com>
4066
4067         Unreviewed, disabling tests for Win EWS.
4068
4069         win-ews obviously cannot keep up with running tests, it's >300 behind.
4070         Probably doesn't help that its (likely) running tests serially.
4071
4072         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4073         (WinEWS):
4074
4075 2013-03-12  Tim Horton  <timothy_horton@apple.com>
4076
4077         Add a --build-directory argument to delete-stale-build-files
4078         https://bugs.webkit.org/show_bug.cgi?id=112198
4079
4080         Reviewed by Ryosuke Niwa.
4081
4082         * BuildSlaveSupport/delete-stale-build-files:
4083         (main): Add --build-directory argument.
4084
4085 2013-03-12  Oliver Hunt  <oliver@apple.com>
4086
4087         Appease MSVC
4088
4089         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4090         (TestWebKitAPI):
4091
4092 2013-03-12  Oliver Hunt  <oliver@apple.com>
4093
4094         Add more Checked<> tests
4095         https://bugs.webkit.org/show_bug.cgi?id=112190
4096
4097         Reviewed by Geoffrey Garen.
4098
4099         Tests!
4100
4101         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4102         (TestWebKitAPI):
4103
4104 2013-03-12  Julie Parent  <jparent@chromium.org>
4105
4106         Cleanup: Move loading complete function into callback, rather than global.
4107         https://bugs.webkit.org/show_bug.cgi?id=112167
4108
4109         Reviewed by Dirk Pranke.
4110         
4111         Stop calling global functions, pass in proper handler to Loader
4112         constructor. Note that the callback is optional, as tests, and
4113         some potential dashboards, do not need one.
4114
4115         * TestResultServer/static-dashboards/dashboard_base.js:
4116         * TestResultServer/static-dashboards/loader.js:
4117         (.):
4118         * TestResultServer/static-dashboards/loader_unittests.js:
4119
4120 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4121
4122         [EFL][WK2] Add popup menu support to MiniBrowser
4123         https://bugs.webkit.org/show_bug.cgi?id=108934
4124
4125         Reviewed by Kenneth Rohde Christiansen.
4126
4127         Implement popup menu support in MiniBrowser by handling popup_menu_show
4128         and popup_menu_hide smart functions on the view and using the Ewk popup
4129         menu API.
4130
4131         * MiniBrowser/efl/main.c:
4132         (_Browser_Window):
4133         (on_popup_menu_discarded):
4134         (on_popup_menu_item_clicked):
4135         (popup_menu_populate):
4136         (on_popup_menu_show):
4137         (on_popup_menu_hide):
4138         (window_create): Use calloc() instead of malloc() to allocate memory for
4139         Browser_Window. This makes sure all the structs members are initialized
4140         to 0 (such as the new elm_popup_menu pointer).
4141
4142 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
4143
4144         [GTK] Set up the libPlatformGtk.la library
4145         https://bugs.webkit.org/show_bug.cgi?id=111738
4146
4147         Reviewed by Martin Robinson.
4148
4149         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
4150         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
4151         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
4152
4153 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
4154
4155         [GTK] Enable Web Audio in development builds
4156         https://bugs.webkit.org/show_bug.cgi?id=111831
4157
4158         Reviewed by Philippe Normand.
4159
4160         Web Audio is already quite well supported on the GTK port but still has a few issues
4161         that must be addressed before it is enabled by default. Despite that it should be enabled
4162         in development builds just so we are up-to-date with future feature infrastructure changes.
4163         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
4164         that's an obvious goal before enabling the feature in release builds.
4165
4166         * Scripts/webkitperl/FeatureList.pm:
4167
4168 2013-03-11  Andreas Kling  <akling@apple.com>
4169
4170         [Mac][WK1] Add support for alert() in MiniBrowser.
4171         <http://webkit.org/b/112090>
4172
4173         Reviewed by Anders Carlsson.
4174
4175         * MiniBrowser/mac/WK1BrowserWindowController.m:
4176         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
4177
4178 2013-03-11  Julie Parent  <jparent@chromium.org>
4179
4180         Dashboard cleanup: Create ui.Errors
4181         https://bugs.webkit.org/show_bug.cgi?id=111785
4182
4183         Reviewed by Ojan Vafai.
4184         
4185         Create ui.Errors for handling errors the dashboards
4186         encounter. Loader now has a Error object that it can add to,
4187         and individual dashboards can show errors when desired.
4188         Currently, only flakiness_db shows errors, but this is 
4189         generic and there is no reason why other dbs wouldn't want to
4190         show errors.
4191
4192         * TestResultServer/static-dashboards/dashboard_base.js:
4193         (resourceLoadingComplete):
4194         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4195         (generatePage):
4196         * TestResultServer/static-dashboards/loader.js:
4197         (.):
4198         * TestResultServer/static-dashboards/ui.js:
4199         (.):
4200
4201 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
4202
4203         Some StringHasher tests are broken because of missing null termination
4204         https://bugs.webkit.org/show_bug.cgi?id=111284
4205
4206         Reviewed by Darin Adler.
4207
4208         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
4209         (TestWebKitAPI): Added null termination since C strings are null-terminated.
4210         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
4211         the bug caught by it is now fixed.
4212
4213 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
4214
4215         Unreviewed, rolling out r145200.
4216         http://trac.webkit.org/changeset/145200
4217         https://bugs.webkit.org/show_bug.cgi?id=112063
4218
4219         Broke a couple of unit tests (Requested by zdobersek on
4220         #webkit).
4221
4222         * Scripts/webkitperl/FeatureList.pm:
4223
4224 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
4225
4226         [GTK] WebKit2-only build fails
4227         https://bugs.webkit.org/show_bug.cgi?id=112033
4228
4229         Reviewed by Gustavo Noronha Silva.
4230
4231         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
4232         generic part, WebKit1-specific part and WebKit2-specific part.
4233         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
4234         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
4235         directly.
4236
4237 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
4238
4239         Adding myself to the committers list.
4240
4241         Unreviewed.
4242
4243         * Scripts/webkitpy/common/config/committers.py:
4244
4245 2013-03-11  Jeff Rogers  <jrogers@rim.com>
4246
4247         [BlackBerry] Disable MathML support
4248         https://bugs.webkit.org/show_bug.cgi?id=111929
4249
4250         Reviewed by Rob Buis.
4251
4252         * Scripts/webkitperl/FeatureList.pm:
4253
4254 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4255
4256         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
4257         https://bugs.webkit.org/show_bug.cgi?id=111970
4258
4259         Reviewed by Chris Fleizach.
4260
4261         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
4262         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
4263         undefined symbol.
4264
4265         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4266         (WTR::AccessibilityUIElement::supportedActions):
4267         (WTR):
4268
4269 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
4270
4271         [chromium] Android apk targets should depend directly on Java library targets
4272         https://bugs.webkit.org/show_bug.cgi?id=111746
4273
4274         Reviewed by Eric Seidel.
4275
4276         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4277         Make DumpRenderTree_apk depend directly on base_java and net_java.
4278         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
4279         Make TestWebKitAPI_apk depend directly on base_java.
4280
4281 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
4282
4283         [chromium] remove obsolete user gesture methods from WebFrame
4284         https://bugs.webkit.org/show_bug.cgi?id=111696
4285
4286         Reviewed by Adam Barth.
4287
4288         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
4289         (WebTestRunner::TestPlugin::handleInputEvent):
4290         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: