[Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2
3         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
4         https://bugs.webkit.org/show_bug.cgi?id=196760
5
6         Reviewed by Don Olmstead.
7
8         vswhere.exe has been bundled since Visual Studio 2017 version
9         15.2. We shouldn't download vswhere.exe.
10
11         * Scripts/build-jsc: Do not call update-vswhere.py.
12         * Scripts/build-webkit: Ditto.
13         * Scripts/update-vswhere.py: Removed.
14         * Scripts/webkitdirs.pm:
15         (requireModulesForVSWhere): Deleted.
16         (pickCurrentVisualStudioInstallation): Deleted.
17         (visualStudioInstallDirVSWhere): Return the latest installed VS
18         installation path by using the bundled vswhere.exe.
19         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
20         (visualStudioInstallDirFallback): Removed.
21
22 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
23
24         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
25         https://bugs.webkit.org/show_bug.cgi?id=196780
26
27         Reviewed by Alexey Proskuryakov.
28
29         * BuildSlaveSupport/ews-build/steps.py:
30         * BuildSlaveSupport/ews-build/steps_unittest.py:
31
32 2019-04-10  Alex Christensen  <achristensen@webkit.org>
33
34         Add SPI WKNavigationResponse._downloadAttribute
35         https://bugs.webkit.org/show_bug.cgi?id=196755
36         <rdar://49587365>
37
38         Reviewed by Brady Eidson.
39
40         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
41         (-[NavigationResponseTestDelegate navigationResponse]):
42         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
43         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
44         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
45         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
46         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
47         (readRequest):
48         (writeResponse):
49         (TEST):
50
51 2019-04-10  Tim Horton  <timothy_horton@apple.com>
52
53         Add modern API for overriding the page's specified viewport configuration
54         https://bugs.webkit.org/show_bug.cgi?id=167734
55         <rdar://problem/30331795>
56
57         Reviewed by Simon Fraser.
58
59         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
60         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
61
62 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
63
64         Add support for incremental bytecode cache updates
65         https://bugs.webkit.org/show_bug.cgi?id=195000
66
67         Reviewed by Filip Pizlo.
68
69         Exit when the initial run to generate bytecode fails.
70
71         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
72
73 2019-04-10  Alex Christensen  <achristensen@webkit.org>
74
75         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
76         https://bugs.webkit.org/show_bug.cgi?id=196744
77         <rdar://49415309>
78
79         Reviewed by Chris Dumez.
80
81         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
82         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
83
84 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
85
86         Add a way to opt into modern compatibility mode in layout tests
87         https://bugs.webkit.org/show_bug.cgi?id=196770
88         <rdar://problem/49777550>
89
90         Reviewed by Antoine Quint.
91
92         Add a new test option to enable modern compatibility mode in layout tests.
93
94         * WebKitTestRunner/TestController.cpp:
95         (WTR::updateTestOptionsFromTestHeader):
96         * WebKitTestRunner/TestController.h:
97         * WebKitTestRunner/TestOptions.h:
98         (WTR::TestOptions::hasSameInitializationOptions const):
99         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
100         (WTR::TestController::platformCreateWebView):
101         (WTR::TestController::enableModernCompatibilityMode):
102
103 2019-04-10  Andy Estes  <aestes@apple.com>
104
105         Try to fix the 32-bit watchOS build.
106
107         * TestWebKitAPI/cocoa/TestWKWebView.mm:
108         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
109
110 2019-04-10  Antoine Quint  <graouts@apple.com>
111
112         Enable Pointer Events on watchOS
113         https://bugs.webkit.org/show_bug.cgi?id=196771
114         <rdar://problem/49040909>
115
116         Reviewed by Dean Jackson.
117
118         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
119
120 2019-04-10  Philippe Normand  <pnormand@igalia.com>
121
122         Unreviewed. Fix WPE accessibility tests after r244059.
123
124         We are failing to load the injected bundle due to undefined symbol
125         AccessibilityUIElement::replaceTextInRange().
126
127         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
128         (WTR::AccessibilityUIElement::replaceTextInRange):
129
130 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
131
132         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
133         https://bugs.webkit.org/show_bug.cgi?id=196727
134
135         Reviewed by Fujii Hironori.
136
137         * MiniBrowser/win/WebKitBrowserWindow.cpp:
138         (WebKitBrowserWindow::create):
139
140 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
141
142         [ews-build] Add unit tests for PrintConfiguration
143         https://bugs.webkit.org/show_bug.cgi?id=196752
144
145         Reviewed by Dewei Zhu.
146
147         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
148
149 2019-04-09  Keith Rollin  <krollin@apple.com>
150
151         Unreviewed build maintenance -- update .xcfilelists.
152
153         * DumpRenderTree/DerivedSources-input.xcfilelist:
154         * DumpRenderTree/DerivedSources-output.xcfilelist:
155
156 2019-04-09  Zalan Bujtas  <zalan@apple.com>
157
158         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
159         https://bugs.webkit.org/show_bug.cgi?id=196743
160         <rdar://problem/43897551>
161
162         Reviewed by Tim Horton.
163
164         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
165         (TEST):
166
167 2019-04-09  Youenn Fablet  <youenn@apple.com>
168
169         Close service worker database on network process suspension
170         https://bugs.webkit.org/show_bug.cgi?id=196623
171         <rdar://problem/48930869>
172
173         Reviewed by Alex Christensen.
174
175         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
176
177 2019-04-09  Daniel Bates  <dabates@apple.com>
178
179         [iPad] Should open popover when the spacebar is pressed
180         https://bugs.webkit.org/show_bug.cgi?id=196360
181         <rdar://problem/49389129>
182
183         Reviewed by Brent Fulgham.
184
185         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
186
187         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
188         (WTR::UIScriptController::isShowingPopover const): Added.
189         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
190         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
191         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
192         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
193         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
194         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
195         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
196         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
197         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
198         (WTR::UIScriptController::isShowingPopover const): Added.
199         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
200         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
201         * TestRunnerShared/UIScriptContext/UIScriptController.h:
202         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
203         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
204         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
205         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
206         (-[TestRunnerWKWebView _willPresentPopover]): Added.
207         (-[TestRunnerWKWebView _didDismissPopover]): Added.
208         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
209         (WTR::UIScriptController::isShowingPopover const): Added.
210         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
211         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
212
213 2019-04-09  Alex Christensen  <achristensen@webkit.org>
214
215         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
216         https://bugs.webkit.org/show_bug.cgi?id=196665
217         <rdar://45115669>
218
219         Reviewed by Geoff Garen.
220
221         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
222         (goBack):
223         (+[SimpleLookupContext sharedLookupContext]):
224         (-[SimpleLookupContext lookUpURL:completionHandler:]):
225         (TEST):
226         (+[Simple3LookupContext sharedLookupContext]): Deleted.
227         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
228
229 2019-04-09  John Wilander  <wilander@apple.com>
230
231         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
232         https://bugs.webkit.org/show_bug.cgi?id=196558
233         <rdar://problem/47650245>
234
235         Reviewed by Youenn Fablet.
236
237         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
238         (TestWebKitAPI::TEST):
239             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
240
241 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
242
243         [CMake] Apple builds should use ICU_INCLUDE_DIRS
244         https://bugs.webkit.org/show_bug.cgi?id=196720
245
246         Reviewed by Konstantin Tokarev.
247
248         * TestWebKitAPI/PlatformMac.cmake:
249
250 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
251
252         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
253         https://bugs.webkit.org/show_bug.cgi?id=196694
254         <rdar://problem/48388734>
255
256         Rubber-stamped by Aakash Jain.
257
258         * Scripts/webkitpy/port/image_diff.py:
259         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
260         * Scripts/webkitpy/port/server_process.py:
261         (ServerProcess.has_available_stdout): Check if stdout has data in it.
262         (ServerProcess._wait_for_data_and_update_buffers_using_select):
263         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
264         * Scripts/webkitpy/port/server_process_mock.py:
265         (MockServerProcess.has_available_stdout):
266         * Scripts/webkitpy/port/server_process_unittest.py:
267         (TestServerProcess.serial_test_basic):
268
269 2019-04-09  Jer Noble  <jer.noble@apple.com>
270
271         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
272         https://bugs.webkit.org/show_bug.cgi?id=196097
273
274         Reviewed by Eric Carlson.
275
276         Drive-by bug fix: allow tests to play audio without a user gesture by default.
277
278         * DumpRenderTree/mac/DumpRenderTree.mm:
279         (resetWebPreferencesToConsistentValues):
280         * WebKitTestRunner/TestController.cpp:
281         (WTR::TestController::resetPreferencesToConsistentValues):
282
283 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
284
285         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
286         https://bugs.webkit.org/show_bug.cgi?id=196690
287
288         Reviewed by Michael Catanzaro.
289
290         * QueueStatusServer/config/queues.py:
291         * Scripts/webkitpy/common/config/ews.json:
292         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
293         (test_ews_name):
294
295 2019-04-09  Chris Dumez  <cdumez@apple.com>
296
297         Loads using loadHTMLString() cause flashing when process-swapping
298         https://bugs.webkit.org/show_bug.cgi?id=196714
299         <rdar://problem/49637354>
300
301         Reviewed by Antti Koivisto.
302
303         Add API test coverage.
304
305         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
306
307 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
308
309         Unreviewed. Fix ATK accessibility tests after r244059.
310
311         We are failing to load the injected bundle due to undefined symbol
312         AccessibilityUIElement::replaceTextInRange().
313
314         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
315         (WTR::AccessibilityUIElement::replaceTextInRange):
316
317 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
318
319         AX: Support API: accessibilityReplaceRange:withText
320         https://bugs.webkit.org/show_bug.cgi?id=196636
321
322         Unreviewed build fix for Windows port.
323
324         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
325         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
326
327 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
328
329         [CMake][WinCairo] Separate copied headers into different directories
330         https://bugs.webkit.org/show_bug.cgi?id=196655
331
332         Reviewed by Michael Catanzaro.
333
334         * DumpRenderTree/CMakeLists.txt:
335         * MiniBrowser/win/CMakeLists.txt:
336         * TestWebKitAPI/CMakeLists.txt:
337         * TestWebKitAPI/PlatformWin.cmake:
338
339 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
340
341         Log stack-trace for run-webkit-tests when interrupted
342         https://bugs.webkit.org/show_bug.cgi?id=176393
343         <rdar://problem/34262310>
344
345         Reviewed by Lucas Forschler.
346
347         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
348         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
349         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
350         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
351         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
352         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
353         (main): Set handlers to log stack trace on interruption.
354
355 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
356
357         AX: Support API: accessibilityReplaceRange:withText
358         https://bugs.webkit.org/show_bug.cgi?id=196636
359
360         Unreviewed build fix for Windows port.
361
362         * DumpRenderTree/AccessibilityUIElement.cpp:
363         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
364
365 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
366
367         [ews-build] Scripts using Buildbot API have CORS error
368         https://bugs.webkit.org/show_bug.cgi?id=196709
369
370         Reviewed by Alexey Proskuryakov.
371
372         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
373
374 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
375
376         AX: Support API: accessibilityReplaceRange:withText
377         https://bugs.webkit.org/show_bug.cgi?id=196636
378
379         Reviewed by Daniel Bates.
380
381         * DumpRenderTree/AccessibilityUIElement.cpp:
382         (replaceTextInRangeCallback):
383         (AccessibilityUIElement::replaceTextInRange):
384         (AccessibilityUIElement::getJSClass):
385         * DumpRenderTree/AccessibilityUIElement.h:
386         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
387         (AccessibilityUIElement::replaceTextInRange):
388         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
389         (AccessibilityUIElement::replaceTextInRange):
390         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
391         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
392         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
393         (WTR::AccessibilityUIElement::replaceTextInRange):
394         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
395         (WTR::AccessibilityUIElement::replaceTextInRange):
396
397 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
398
399         [iOS] Do not allow starting selection drags when selection views are not visible
400         https://bugs.webkit.org/show_bug.cgi?id=196686
401         <rdar://problem/49399192>
402
403         Reviewed by Tim Horton.
404
405         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
406         also add some new API tests to cover scenarios where the web view is not first responder.
407
408         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
409         (TestWebKitAPI::TEST):
410         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
411
412         Add a switch to optionally make the web view first responder when starting the simulated drag.
413
414         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
415         (-[DragAndDropSimulator initWithWebView:]):
416         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
417
418 2019-04-08  Justin Fan  <justin_fan@apple.com>
419
420         [Web GPU] Fix Web GPU experimental feature on iOS
421         https://bugs.webkit.org/show_bug.cgi?id=196632
422
423         Reviewed by Myles C. Maxfield.
424
425         Properly make Web GPU available on iOS 11+.
426
427         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
428
429 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
430
431         [ews-build] Do not upload archive when Compile Fails
432         https://bugs.webkit.org/show_bug.cgi?id=196674
433
434         Reviewed by Alexey Proskuryakov.
435
436         * BuildSlaveSupport/ews-build/factories.py:
437         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
438         * BuildSlaveSupport/ews-build/steps.py:
439         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
440         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
441         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
442
443 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
444
445         Enable DFG on MIPS
446         https://bugs.webkit.org/show_bug.cgi?id=196689
447
448         Reviewed by Žan Doberšek.
449
450         Since the bytecode change, we enabled the baseline JIT on mips in
451         r240432, but DFG is still missing. With this change, all tests are
452         passing on a ci20 board.
453
454         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
455
456 2019-04-08  Philippe Normand  <pnormand@igalia.com>
457
458         [Flatpak] Second run update-webkitwpe-flatpak fails
459         https://bugs.webkit.org/show_bug.cgi?id=192702
460
461         Reviewed by Carlos Garcia Campos.
462
463         * flatpak/flatpakutils.py:
464         (FlatpakObject.flatpak): Fix typo.
465         (FlatpakPackage.install): When installing, also update to the configured remote commit.
466         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
467
468 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
469
470         [GTK][WPE] outlook.live.com displays old-fashioned UI
471         https://bugs.webkit.org/show_bug.cgi?id=196642
472
473         Reviewed by Carlos Garcia Campos.
474
475         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
476         (TestWebKitAPI::TEST): New Mac platform quirk test.
477
478 2019-04-07  Commit Queue  <commit-queue@webkit.org>
479
480         Unreviewed, rolling out r243956.
481         https://bugs.webkit.org/show_bug.cgi?id=196688
482
483         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
484         by aakashjain on #webkit).
485
486         Reverted changeset:
487
488         "Clicking "Go Back" from a safe browsing warning from an
489         iframe should navigate the WKWebView back to the previous
490         page"
491         https://bugs.webkit.org/show_bug.cgi?id=196665
492         https://trac.webkit.org/changeset/243956
493
494 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
495
496         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
497         https://bugs.webkit.org/show_bug.cgi?id=196669
498
499         Reviewed by Geoffrey Garen.
500
501         Added three new unit tests for WeakHashSet.
502
503         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
504         (WTF_WeakPtr.WeakHashSetConstObjects):
505         (WTF_WeakPtr.WeakHashSetComputesEmpty):
506         (WTF_WeakPtr.WeakHashSetComputeSize):
507
508 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
509
510         Hide next and previous form control buttons when WKWebView is editable
511         https://bugs.webkit.org/show_bug.cgi?id=196672
512         <rdar://problem/35625321>
513
514         Reviewed by Tim Horton.
515
516         Add a new API test.
517
518         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
519         (-[TestWKWebView lastTrailingBarButtonGroup]):
520         (TestWebKitAPI::TEST):
521         * TestWebKitAPI/ios/UIKitSPI.h:
522
523 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
524
525         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
526         https://bugs.webkit.org/show_bug.cgi?id=196077
527         <rdar://problem/49108202>
528
529         Reviewed by Chris Dumez.
530
531         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
532         on new web view.
533
534         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
535
536 2019-04-05  Saam Barati  <sbarati@apple.com>
537
538         Make compare-results understand MotionMark
539         https://bugs.webkit.org/show_bug.cgi?id=196666
540
541         Reviewed by Yusuke Suzuki.
542
543         * Scripts/compare-results:
544         (PLT5Results):
545         (detectMotionMark):
546         (detectMotionMark1_1):
547         (motionMarkResults):
548         (motionMark1_1Results):
549         (detectBenchmark):
550         (biggerIsBetter):
551         (main):
552
553 2019-04-05  Alex Christensen  <achristensen@webkit.org>
554
555         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
556         https://bugs.webkit.org/show_bug.cgi?id=196665
557         <rdar://45115669>
558
559         Reviewed by Geoff Garen.
560
561         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
562         (goBack):
563         (+[SimpleLookupContext sharedLookupContext]):
564         (-[SimpleLookupContext lookUpURL:completionHandler:]):
565         (TEST):
566         (+[Simple3LookupContext sharedLookupContext]): Deleted.
567         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
568
569 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
570
571         [ews-build] Add configuration and architecture for windows builders
572         https://bugs.webkit.org/show_bug.cgi?id=196660
573
574         Reviewed by Lucas Forschler.
575
576         * BuildSlaveSupport/ews-build/config.json:
577
578 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
579
580         webkitpy: Don't run subsequent rounds if interrupted
581         https://bugs.webkit.org/show_bug.cgi?id=196646
582
583         Reviewed by Aakash Jain.
584
585         * Scripts/webkitpy/layout_tests/controllers/manager.py:
586         (Manager.run): Bail out if interrupted.
587
588 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
589
590         Test sessionStorage in PSON private browsing mode
591         https://bugs.webkit.org/show_bug.cgi?id=196561
592
593         Reviewed by Alex Christensen.
594
595         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
596
597 2019-04-05  Commit Queue  <commit-queue@webkit.org>
598
599         Unreviewed, rolling out r243833.
600         https://bugs.webkit.org/show_bug.cgi?id=196645
601
602         This change breaks build of WPE and GTK ports (Requested by
603         annulen on #webkit).
604
605         Reverted changeset:
606
607         "[CMake][WTF] Mirror XCode header directories"
608         https://bugs.webkit.org/show_bug.cgi?id=191662
609         https://trac.webkit.org/changeset/243833
610
611 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
612
613         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
614         https://bugs.webkit.org/show_bug.cgi?id=196635
615
616         Reviewed by Antti Koivisto.
617         
618         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
619         for a test to enable async frame scrolling via:
620             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
621         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
622         
623         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
624
625         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
626         (WTR::InjectedBundle::beginTesting):
627         * WebKitTestRunner/TestController.cpp:
628         (WTR::TestController::resetPreferencesToConsistentValues):
629
630 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
631
632         Use a correct LC_RPATH when building with ASan
633         https://bugs.webkit.org/show_bug.cgi?id=196576
634
635         Reviewed by David Kilzer.
636
637         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
638         so that ../Frameworks is checked. This is simpler and more reliable than updating
639         each SPC service xcconfig.
640
641 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
642
643         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
644         https://bugs.webkit.org/show_bug.cgi?id=196629
645
646         Reviewed by Lucas Forschler.
647
648         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
649
650 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
651
652         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
653         https://bugs.webkit.org/show_bug.cgi?id=196618
654
655         Reviewed by Lucas Forschler.
656
657         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
658         (StatusBubble): Added QUEUE_TRIGGERS.
659         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
660         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
661         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
662         its parent(builder).
663
664 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
665
666         [ews-app] Status-bubble steps are sometimes displayed in reverse order
667         https://bugs.webkit.org/show_bug.cgi?id=196625
668
669         Reviewed by Lucas Forschler.
670
671         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
672         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
673
674 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
675
676         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
677         https://bugs.webkit.org/show_bug.cgi?id=196630
678
679         Reviewed by Wenson Hsieh.
680
681         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
682
683 2019-04-04  Youenn Fablet  <youenn@apple.com>
684
685         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
686         https://bugs.webkit.org/show_bug.cgi?id=196543
687
688         Reviewed by Alex Christensen.
689
690         * WebKitTestRunner/TestController.cpp:
691         (WTR::TestController::generatePageConfiguration):
692
693 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
694
695         [ews-app] Status bubble should not display skipped buildbot steps
696         https://bugs.webkit.org/show_bug.cgi?id=196584
697
698         Reviewed by Lucas Forschler.
699
700         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
701
702 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
703
704         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
705         https://bugs.webkit.org/show_bug.cgi?id=196620
706
707         Reviewed by Lucas Forschler.
708
709         * BuildSlaveSupport/ews-app/ews/config.py:
710
711 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
712
713         [Win] DumpRenderTreeWatchDog.py is not checked into source
714         https://bugs.webkit.org/show_bug.cgi?id=196567
715         <rdar://problem/49525901>
716
717         Reviewed by Lucas Forschler.
718
719         This script is used on Win EWS bots to terminate hanging DRT processes.
720
721         * EWSTools/dumprendertreewatchdog.py: Added.
722
723 2019-04-04  Chris Dumez  <cdumez@apple.com>
724
725         Unreviewed, roll out r243858 which made tests time out.
726
727         Disable new API tests on Windows instead.
728
729         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
730         (TestWebKitAPI::TEST):
731
732 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
733
734         [ATK] Cleanup WebPageAccessibilityObjectAtk
735         https://bugs.webkit.org/show_bug.cgi?id=196537
736
737         Reviewed by Michael Catanzaro.
738
739         Also consider files under atk directories as exceptions for GObject conventions.
740
741         * Scripts/webkitpy/style/checkers/cpp.py:
742         (check_identifier_name_in_declaration):
743
744 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
745
746         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
747         https://bugs.webkit.org/show_bug.cgi?id=196588
748         <rdar://problem/49365787>
749
750         Unreviewed build fix for Windows port.
751
752         error C3861: 'kill': identifier not found
753
754         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
755         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
756
757 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
758
759         [ews-build] Cancel build and similar operations should have authentication
760         https://bugs.webkit.org/show_bug.cgi?id=196520
761
762         Reviewed by Dewei Zhu.
763
764         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
765         environment variables.
766
767 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
768
769         [ews-build] Do not trigger queues which are not in production yet
770         https://bugs.webkit.org/show_bug.cgi?id=196581
771
772         Reviewed by Dewei Zhu.
773
774         * BuildSlaveSupport/ews-build/config.json:
775
776 2019-04-03  Chris Dumez  <cdumez@apple.com>
777
778         Unreviewed, fix typo in the name of API test added in r243848.
779
780         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
781         (TestWebKitAPI::TEST):
782
783 2019-04-03  Chris Dumez  <cdumez@apple.com>
784
785         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
786         https://bugs.webkit.org/show_bug.cgi?id=196588
787         <rdar://problem/49365787>
788
789         Reviewed by Ryosuke Niwa.
790
791         Add API test coverage.
792
793         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
794         (TestWebKitAPI::nullJavaScriptCallback):
795         (TestWebKitAPI::didCrashCheckFrames):
796         (TestWebKitAPI::TEST):
797
798 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
799
800         run-webkit-tests: Upload test results (new results database)
801         https://bugs.webkit.org/show_bug.cgi?id=196577
802         <rdar://problem/34841155>
803
804         Reviewed by Lucas Forschler.
805
806         * Scripts/webkitpy/layout_tests/controllers/manager.py:
807         (Manager.run): Upload results after each device shard, since the configuration will be
808         different for each device.
809         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
810         uploaded to a results database.
811         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
812         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
813
814 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
815
816         -apple-trailing-word is needed for browser detection
817         https://bugs.webkit.org/show_bug.cgi?id=196575
818
819         Unreviewed.
820
821         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
822
823 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
824
825         [CMake][WTF] Mirror XCode header directories
826         https://bugs.webkit.org/show_bug.cgi?id=191662
827
828         Reviewed by Konstantin Tokarev.
829
830         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
831         builds.
832
833         * CMakeLists.txt:
834         * DumpRenderTree/CMakeLists.txt:
835         * DumpRenderTree/PlatformWin.cmake:
836         * MiniBrowser/win/CMakeLists.txt:
837         * TestWebKitAPI/CMakeLists.txt:
838         * TestWebKitAPI/PlatformWin.cmake:
839         * WebKitTestRunner/PlatformGTK.cmake:
840         * WebKitTestRunner/PlatformWin.cmake:
841
842 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
843
844         [ews-app] Status bubble should not display certain infrastructure status messages
845         https://bugs.webkit.org/show_bug.cgi?id=196550
846
847         Reviewed by Lucas Forschler.
848
849         Do not display the steps which are un-needed for end-user. This information is still avaiable
850         if the user click on the bubble and look at the Buildbot build.
851         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
852         (StatusBubble._steps_messages):
853         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
854
855 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
856
857         [ews-build] Use https for sending data to ews-app
858         https://bugs.webkit.org/show_bug.cgi?id=196492
859
860         Reviewed by Lucas Forschler.
861
862         * BuildSlaveSupport/ews-build/events.py:
863
864 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
865
866         Remove support for -apple-trailing-word
867         https://bugs.webkit.org/show_bug.cgi?id=196525
868
869         Reviewed by Zalan Bujtas.
870
871         This CSS property is nonstandard and not used.
872
873         * Scripts/webkitperl/FeatureList.pm:
874         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
875
876 2019-04-03  Youenn Fablet  <youenn@apple.com>
877
878         Add a test for DOMCache on multiple browsing in case of private browsing
879         https://bugs.webkit.org/show_bug.cgi?id=196524
880
881         Reviewed by Alex Christensen.
882
883         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
884         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
885
886 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
887
888         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
889         https://bugs.webkit.org/show_bug.cgi?id=196540
890
891         Reviewed by Aakash Jain.
892
893         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
894
895 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
896
897         Add plumbing for a compatibility mode preference in WebKit
898         https://bugs.webkit.org/show_bug.cgi?id=196005
899
900         Reviewed by Tim Horton.
901
902         Add new API tests.
903
904         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
905         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
906
907 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
908
909         [WPE][GTK] Update libsrtp dependency package for Debian
910         https://bugs.webkit.org/show_bug.cgi?id=196528
911
912         Reviewed by Frédéric Wang.
913
914         * gtk/install-dependencies:
915         * wpe/install-dependencies:
916
917 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
918
919         [WK2] Add support for Window's beforeprint / afterprint events
920         https://bugs.webkit.org/show_bug.cgi?id=196478
921         <rdar://problem/49535124>
922
923         Unreviewed build fix for MSVC.
924
925         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
926
927         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
928
929         * WebKitTestRunner/TestController.cpp:
930         (WTR::printFrame): Use int and float literals.
931
932 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
933
934         [ews-build] Reassign bots to queues
935
936         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
937
938 2019-04-02  Chris Dumez  <cdumez@apple.com>
939
940         [WK2] Add support for Window's beforeprint / afterprint events
941         https://bugs.webkit.org/show_bug.cgi?id=196478
942
943         Reviewed by Alex Christensen.
944
945         Add minimal implementation for printFrame in WebKitTestRunner.
946
947         * WebKitTestRunner/TestController.cpp:
948         (WTR::printFrame):
949         (WTR::TestController::createOtherPage):
950         (WTR::TestController::createWebViewWithOptions):
951
952 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
953
954         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
955         https://bugs.webkit.org/show_bug.cgi?id=196491
956
957         Reviewed by Lucas Forschler.
958
959         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
960
961 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
962
963         [ews-build] Configure buildbot try credentials in environment variables
964         https://bugs.webkit.org/show_bug.cgi?id=196501
965
966         Reviewed by Lucas Forschler.
967
968         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
969         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
970         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
971
972 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
973
974         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
975         https://bugs.webkit.org/show_bug.cgi?id=196496
976         <rdar://problem/49521634>
977
978         Reviewed by Chris Dumez.
979
980         Add new API tests (see WebKit ChangeLog for more detail).
981
982         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
983         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
984         (TEST):
985
986 2019-04-02  David Kilzer  <ddkilzer@apple.com>
987
988         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
989         <https://webkit.org/b/196499>
990
991         Reviewed by Alexey Proskuryakov.
992
993         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
994         ENABLE_ADDRESS_SANITIZER.
995
996 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
997
998         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
999         https://bugs.webkit.org/show_bug.cgi?id=182757
1000
1001         Reviewed by Don Olmstead.
1002
1003         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1004         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1005
1006 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1007
1008         run-api-tests: Upload test results
1009         https://bugs.webkit.org/show_bug.cgi?id=196323
1010         <rdar://problem/49356714>
1011
1012         Reviewed by Lucas Forschler.
1013
1014         * Scripts/webkitpy/api_tests/manager.py:
1015         (Manager):
1016         (Manager.run): Upload results to a results database.
1017         * Scripts/webkitpy/api_tests/run_api_tests.py:
1018         (parse_args): Add upload arguments.
1019         * Scripts/webkitpy/port/base.py:
1020         (Port):
1021         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1022         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1023         with commits from any other associated repositories.
1024         * Scripts/webkitpy/port/device.py:
1025         (Device):
1026         (Device.build_version): Access build_versoin of underlying platform device.
1027         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1028         (IOSSimulatorTest):
1029         (IOSSimulatorTest.test_configuration_for_upload):
1030         * Scripts/webkitpy/port/device_port.py:
1031         (DevicePort):
1032         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1033         the same as the machine uploading results.
1034         * Scripts/webkitpy/port/mac.py:
1035         (MacPort):
1036         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1037         * Scripts/webkitpy/port/mac_unittest.py:
1038         (MacTest):
1039         (MacTest.test_configuration_for_upload):
1040         * Scripts/webkitpy/xcode/simulated_device.py:
1041         (SimulatedDeviceManager._create_device_with_runtime):
1042         (SimulatedDevice.__init__): Create simulated device with a build_version.
1043         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1044         (test_existing_simulator):
1045
1046 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1047
1048         Remove extra newline characters (Follow-up fix to r243707)
1049
1050         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1051
1052 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1053
1054         [ews-app] Use API_KEY to accept results data
1055         https://bugs.webkit.org/show_bug.cgi?id=196461
1056
1057         Reviewed by Dewei Zhu.
1058
1059         * BuildSlaveSupport/ews-app/ews/views/results.py:
1060         (Results.post): Validate EWS_API_KEY before accepting any data.
1061         * BuildSlaveSupport/ews-build/events.py:
1062         (Events.sendData): Send EWS_API_KEY if available along with event data.
1063
1064 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1065
1066         Unable to copy and paste a PDF from Notes into Mail compose body
1067         https://bugs.webkit.org/show_bug.cgi?id=196442
1068         <rdar://problem/48573098>
1069
1070         Reviewed by Tim Horton.
1071
1072         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1073         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1074         to be specified on the item providers.
1075
1076         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1077         (TestWebKitAPI::mapItemForTesting):
1078         (TestWebKitAPI::contactItemForTesting):
1079
1080 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1081
1082         Make UIWKDocumentContext rects per-character instead of per-word
1083         https://bugs.webkit.org/show_bug.cgi?id=196459
1084
1085         Reviewed by Wenson Hsieh.
1086
1087         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1088         (TEST):
1089         Adjust test results due to switching to per-character rects.
1090
1091 2019-04-01  Chris Dumez  <cdumez@apple.com>
1092
1093         UIProcess crash when a prewarmed process is terminated
1094         https://bugs.webkit.org/show_bug.cgi?id=196451
1095         <rdar://problem/49245471>
1096
1097         Reviewed by Geoffrey Garen.
1098
1099         Add API test coverage.
1100
1101         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1102         (TEST):
1103
1104 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1105
1106         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1107         https://bugs.webkit.org/show_bug.cgi?id=196449
1108
1109         Reviewed by Lucas Forschler.
1110
1111         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1112         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1113         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1114         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1115
1116 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1117
1118         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1119         https://bugs.webkit.org/show_bug.cgi?id=196444
1120
1121         Reviewed by Lucas Forschler.
1122
1123         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1124
1125 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1126
1127         Add SPI to canonicalize NSURLs with WTF::URL
1128         https://bugs.webkit.org/show_bug.cgi?id=196415
1129         <rdar://problem/44980271>
1130
1131         Reviewed by Darin Adler.
1132
1133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1134         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1135         (TestWebKitAPI::TEST):
1136
1137 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1138
1139         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1140         https://bugs.webkit.org/show_bug.cgi?id=196441
1141
1142         Reviewed by Carlos Garcia Campos.
1143
1144         Don't cache the wpe_view_backend object that might not exist yet at the
1145         time of EventSenderProxy constructor invocation, but instead retrieve
1146         that object whenever it's required for event dispatching. This should
1147         avoid crashes in this constructor now that it's invoked before any
1148         PlatformWindow has been set up (as changed in r243496).
1149
1150         * WebKitTestRunner/EventSenderProxy.h:
1151         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1152         (WTR::viewBackend):
1153         (WTR::EventSenderProxy::EventSenderProxy):
1154         (WTR::EventSenderProxy::mouseDown):
1155         (WTR::EventSenderProxy::mouseUp):
1156         (WTR::EventSenderProxy::mouseMoveTo):
1157         (WTR::EventSenderProxy::mouseScrollBy):
1158         (WTR::EventSenderProxy::keyDown):
1159         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1160
1161 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1162
1163         [Win][WebKit] MiniBrowser should support high DPI display
1164         https://bugs.webkit.org/show_bug.cgi?id=196391
1165
1166         Reviewed by Alex Christensen.
1167
1168         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1169         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1170         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1171         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1172
1173 2019-03-31  Sam Weinig  <weinig@apple.com>
1174
1175         Remove more i386 specific configurations
1176         https://bugs.webkit.org/show_bug.cgi?id=196430
1177
1178         Reviewed by Alexey Proskuryakov.
1179
1180         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1181         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1182
1183 2019-03-31  Andy Estes  <aestes@apple.com>
1184
1185         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1186         https://bugs.webkit.org/show_bug.cgi?id=196433
1187         <rdar://problem/49293305>
1188
1189         Reviewed by Tim Horton.
1190
1191         Enhanced API test coverage to include all navigation response policy decisions in both
1192         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1193
1194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1195         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1196         (TestWebKitAPI::TEST):
1197         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1198         (readFile):
1199         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1200         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1201         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1202         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1203         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1204         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1205         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1206         (-[QuickLookDelegate _downloadDidStart:]):
1207         (-[QuickLookDelegate _download:didReceiveResponse:]):
1208         (-[QuickLookDelegate _download:didReceiveData:]):
1209         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1210         (-[QuickLookDelegate _downloadDidFinish:]):
1211         (-[QuickLookDelegate _download:didFailWithError:]):
1212         (-[QuickLookDelegate _downloadDidCancel:]):
1213         (-[QuickLookDelegate verifyDownload]):
1214         (runTest):
1215         (runTestDecideBeforeLoading):
1216         (runTestDecideAfterLoading):
1217         (TEST):
1218         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1219         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1220         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1221         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1222         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1223         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1224         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1225         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1226         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1227         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1228         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1229         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1230         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1231         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1232
1233 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1234
1235         [CMake] add testdfg as target with build-jsc
1236         https://bugs.webkit.org/show_bug.cgi?id=196393
1237
1238         Reviewed by Saam Barati.
1239
1240         Added testdfg as one of the targets to build when
1241         using CMake.
1242
1243         * Scripts/build-jsc:
1244
1245 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1246
1247         Delete WebMetal implementation in favor of WebGPU
1248         https://bugs.webkit.org/show_bug.cgi?id=195418
1249
1250         Reviewed by Dean Jackson.
1251
1252         * DumpRenderTree/mac/DumpRenderTree.mm:
1253         (enableExperimentalFeatures):
1254         (resetWebPreferencesToConsistentValues):
1255         * Scripts/webkitperl/FeatureList.pm:
1256         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1257         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1258         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1259         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1260         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1261         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1262         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1263         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1264         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1265         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1266         (WTR::InjectedBundle::beginTesting):
1267         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1268         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1269         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1270
1271 2019-03-29  Chris Dumez  <cdumez@apple.com>
1272
1273         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1274         https://bugs.webkit.org/show_bug.cgi?id=196405
1275         <rdar://problem/49428130>
1276
1277         Reviewed by Wenson Hsieh.
1278
1279         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1280         the popover presentation methods to be no-ops. Use this in the new test added in
1281         r243523 so that we do not swizzle those methods for all tests. This is needed because
1282         those WatchOS tests rely on the popover getting presented and interactive.
1283
1284         * WebKitTestRunner/TestController.cpp:
1285         (WTR::updateTestOptionsFromTestHeader):
1286         * WebKitTestRunner/TestController.h:
1287         * WebKitTestRunner/TestOptions.h:
1288         (WTR::TestOptions::hasSameInitializationOptions const):
1289         * WebKitTestRunner/ios/TestControllerIOS.mm:
1290         (WTR::TestController::platformInitialize):
1291         (WTR::TestController::platformResetStateToConsistentValues):
1292
1293 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1294
1295         [Curl] Add Server Trust Evaluation Support.
1296         https://bugs.webkit.org/show_bug.cgi?id=191646
1297
1298         Reviewed by Fujii Hironori.
1299
1300         Implemented MiniBrowser UI for asking if user trusts the server.
1301
1302         * MiniBrowser/win/Common.cpp:
1303         (askServerTrustEvaluation):
1304         (replaceString):
1305         * MiniBrowser/win/Common.h:
1306         * MiniBrowser/win/MiniBrowserLib.rc:
1307         * MiniBrowser/win/MiniBrowserLibResource.h:
1308         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1309         (createPEMString):
1310         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1311         (WebKitBrowserWindow::canTrustServerCertificate):
1312         * MiniBrowser/win/WebKitBrowserWindow.h:
1313
1314 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1315
1316         Implement ResizeObserver.
1317         https://bugs.webkit.org/show_bug.cgi?id=157743
1318
1319         Reviewed by Simon Fraser.
1320
1321         Support resizeObserverEnabled webPreferences.
1322
1323         * DumpRenderTree/TestOptions.cpp:
1324         (TestOptions::TestOptions):
1325         * DumpRenderTree/TestOptions.h:
1326         * DumpRenderTree/mac/DumpRenderTree.mm:
1327         (setWebPreferencesForTestOptions):
1328         * DumpRenderTree/win/DumpRenderTree.cpp:
1329         (enableExperimentalFeatures):
1330         * Scripts/webkitperl/FeatureList.pm:
1331         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1332
1333 2019-03-28  John Wilander  <wilander@apple.com>
1334
1335         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1336         https://bugs.webkit.org/show_bug.cgi?id=196281
1337         <rdar://problem/48938748>
1338
1339         Reviewed by Alex Christensen.
1340
1341         This patch adds the function isStatisticsHasLocalStorage() to the
1342         TestRunner. With it, the page can query the WebsiteDataStore in the
1343         UI process to make sure that it sees LocalStorage.
1344
1345         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1346         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1347         (WTR::TestRunner::isStatisticsHasLocalStorage):
1348         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1349         * WebKitTestRunner/TestController.cpp:
1350         (WTR::TestController::isStatisticsHasLocalStorage):
1351         * WebKitTestRunner/TestController.h:
1352         * WebKitTestRunner/TestInvocation.cpp:
1353         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1354
1355 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1356
1357         API::Data::createWithoutCopying should do a null check before calling CFRelease
1358         https://bugs.webkit.org/show_bug.cgi?id=196276
1359         <rdar://problem/48059859>
1360
1361         Reviewed by Alex Christensen.
1362
1363         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1364
1365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1366         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1367         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1368         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1369         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1370         (TestWebKitAPI::TEST):
1371
1372 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1373
1374         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1375         https://bugs.webkit.org/show_bug.cgi?id=186276
1376
1377         Reviewed by Carlos Garcia Campos.
1378
1379         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1380         (webViewLoadChanged):
1381         (testWebResourceGetDataError):
1382         (testWebResourceGetDataEmpty):
1383         (beforeAll):
1384         (webViewloadChanged): Deleted.
1385
1386 2019-03-27  Andy Estes  <aestes@apple.com>
1387
1388         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1389         https://bugs.webkit.org/show_bug.cgi?id=196317
1390
1391         Reviewed by Dan Bernstein.
1392
1393         package-root copies built products into a staging directory using ditto(1), which does not
1394         follow symbolic links as it traverses a directory. Now that the files in
1395         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1396         itself, these become broken links when ditto'd into the staging directory.
1397
1398         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1399
1400         * Scripts/package-root:
1401
1402 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1403
1404         [ews-app] Update display text of Submit for ews analysis
1405         https://bugs.webkit.org/show_bug.cgi?id=196309
1406
1407         Reviewed by Dewei Zhu.
1408
1409         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1410
1411 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1412
1413         run-webkit-tests should check for leaks in WebKit processes
1414         <https://webkit.org/b/193772>
1415         <rdar://problem/46526680>
1416
1417         Reviewed by Ryosuke Niwa.
1418
1419         This works by doing the following:
1420         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1421           The list of child processes are returned one per line:
1422           process.name: pid
1423         - Run the "#LIST CHILD PROCESSES" command just before the
1424           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1425           processes on the ServerProcess object.
1426         - When the `--leaks` switch is handled, run check_for_leaks() on
1427           each child process after the main test harness.
1428
1429         * DumpRenderTree/mac/DumpRenderTree.mm:
1430         (handleControlCommand):
1431         - Use strncmp() instead of strcmp().
1432         - Add support for handling "#LIST CHILD PROCESSES" command.
1433
1434         * Scripts/webkitpy/port/base.py:
1435         (Port.check_for_leaks):
1436         * Scripts/webkitpy/port/darwin.py:
1437         (DarwinPort.check_for_leaks):
1438         - Rename redundant 'process_pid' argument to 'process_id'.
1439
1440         * Scripts/webkitpy/port/driver.py:
1441         (Driver.do_post_tests_work):
1442         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1443           longer the only command this sends to WebKitTestRunner.
1444         - If the `--leaks` switch is present, send the
1445           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1446           result using Port.set_webkit_processes().
1447         (Driver._parse_child_processes_output):
1448         - Add helper method to parse list of child process names and
1449           process IDs returned from WebKitTestRunner.
1450
1451         * Scripts/webkitpy/port/ios_device.py:
1452         (IOSDevicePort.check_for_leaks):
1453         - Rename redundant 'process_pid' argument to 'process_id'.
1454
1455         * Scripts/webkitpy/port/leakdetector.py:
1456         (LeakDetector._parse_leaks_output):
1457         - Return early if there is no leaks_output.
1458         (LeakDetector.check_for_leaks):
1459         - Rename redundant 'process_pid' argument to 'process_id'.
1460
1461         * Scripts/webkitpy/port/server_process.py:
1462         (ServerProcess.__init__):
1463         (ServerProcess.child_processes):
1464         (ServerProcess.set_child_processes):
1465         - Add instance variable to Port to store list of child process
1466           names and process IDs returned from WebKitTestRunner.
1467         (ServerProcess._start):
1468         - Clear self._child_processes.
1469         (ServerProcess.stop):
1470         - If self._child_processes is set, call
1471           self._port.check_for_leaks() for each child process.
1472
1473         * Scripts/webkitpy/port/server_process_unittest.py:
1474         (TrivialMockPort.check_for_leaks):
1475         - Rename redundant 'process_pid' argument to 'process_id'.
1476
1477         * Scripts/webkitpy/port/simulator_process.py:
1478         (SimulatorProcess.stop):
1479         - If self._child_processes is set, call
1480           self._port.check_for_leaks() for each child process.
1481
1482         * Scripts/webkitpy/port/watch_device.py:
1483         (WatchDevicePort.check_for_leaks):
1484         - Rename redundant 'process_pid' argument to 'process_id'.
1485
1486         * WebKitTestRunner/TestController.cpp:
1487         (WTR::TestController::dumpResponse):
1488         - Extract method from findAndDumpWorldLeaks() so that it may be
1489           reused by findAndDumpWebKitProcessIdentifiers().
1490         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1491         - Add method to output process name and process ID of both the
1492           WebContent and Networking processes.
1493         (WTR::TestController::findAndDumpWorldLeaks):
1494         - Fix missing newline in output when there were no abandoned
1495           documents.
1496         - Call dumpResponse() for extracted code.
1497         (WTR::TestController::handleControlCommand):
1498         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1499         - Use strncmp() instead of strcmp().
1500         - Call findAndDumpWebKitProcessIdentifiers() when
1501           "#LIST CHILD PROCESSES" command is sent.
1502         * WebKitTestRunner/TestController.h:
1503         (WTR::TestController::dumpResponse):
1504         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1505         - Declare methods.
1506
1507 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1508
1509         Unreviewed. Add GLib API test cases after r243434.
1510
1511         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1512         (testWebViewActiveURI):
1513         (serverCallback):
1514         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1515         (sendRequestCallback):
1516
1517 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1518
1519         Geolocation request not complete when watch request was started in a different web process
1520         https://bugs.webkit.org/show_bug.cgi?id=195996
1521
1522         Reviewed by Alex Christensen.
1523
1524         Add a test case.
1525
1526         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1527         (TestWebKitAPI::runJavaScriptAlert):
1528         (TestWebKitAPI::TEST):
1529
1530 2019-03-26  Keith Rollin  <krollin@apple.com>
1531
1532         Update the way generate-xcfilelists returns strings from functions
1533         https://bugs.webkit.org/show_bug.cgi?id=195975
1534         <rdar://problem/49040807>
1535
1536         Reviewed by Dean Jackson.
1537
1538         There are places where generate-xcfilelists executes assignments with
1539         statements like:
1540
1541             FOO=$(some_function)
1542
1543         where "some_function" return a string by echoing it. E.g.
1544
1545             some_function()
1546             {
1547                 echo "Hello, World"
1548             }
1549
1550         This is a common idiom, but it has a problem if "some_function" needs
1551         to call "exit" in an attempt to halt the entire script right then and
1552         there. Since "some_function" is called inside of $(), it's being
1553         executed in a sub-shell. Calling exit in that sub-shell simply exits
1554         that shell; it doesn't not exit the outer shell in which the main part
1555         of the script is still running. As such, the main script keeps
1556         executing when the intent was for the script to halt.
1557
1558         The solution to this is to use a different idiom for returning
1559         strings. The one we now is to pass in the name of the variable to
1560         receive the string result:
1561
1562             some_function()
1563             {
1564                 variable_name=$1
1565                 eval $variable_name ="Hello, World"
1566             }
1567
1568         The call site now looks like
1569
1570             some_function FOO
1571
1572         Because there's no invocation of a sub-shell, some_function can now
1573         call "exit" if it wants to, and the entire script will exit at that
1574         point.
1575
1576         * Scripts/generate-xcfilelists:
1577
1578 2019-03-26  Chris Dumez  <cdumez@apple.com>
1579
1580         Add basic layout test coverage for File Picker on iOS
1581         https://bugs.webkit.org/show_bug.cgi?id=196265
1582
1583         Reviewed by Wenson Hsieh.
1584
1585         Add layout test infrastructure to test the file picker on iOS.
1586
1587         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1588         (WTR::UIScriptController::dismissFilePicker):
1589         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1590         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1591         (WTR::UIScriptController::dismissFilePicker):
1592         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1593         * WebKitTestRunner/TestController.cpp:
1594         (WTR::TestController::createWebViewWithOptions):
1595         (WTR::updateTestOptionsFromTestHeader):
1596         * WebKitTestRunner/TestOptions.h:
1597         (WTR::TestOptions::hasSameInitializationOptions const):
1598         * WebKitTestRunner/ios/TestControllerIOS.mm:
1599         (overridePresentViewController):
1600         (WTR::TestController::platformInitialize):
1601         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1602         (WTR::UIScriptController::dismissFilePicker):
1603
1604 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1605
1606         Implement async paste method on UIWKInteractionViewProtocol
1607         https://bugs.webkit.org/show_bug.cgi?id=196267
1608         <rdar://problem/49236346>
1609
1610         Reviewed by Tim Horton.
1611
1612         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1613         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1614         are now a part of all iOS 12 internal SDKs.
1615
1616         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1617
1618         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1619         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1620
1621         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1622         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1623         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1624         * TestWebKitAPI/ios/UIKitSPI.h:
1625
1626 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1627
1628         [ews-build] Use PostgreSQL for ews.webkit.org database
1629         https://bugs.webkit.org/show_bug.cgi?id=196270
1630
1631         Reviewed by Lucas Forschler.
1632
1633         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1634
1635 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1636
1637         [ews] Reset simctl states on reboot
1638         https://bugs.webkit.org/show_bug.cgi?id=196260
1639
1640         Rubber-stamped by Aakash Jain.
1641
1642         * EWSTools/start-queue-mac.sh:
1643
1644 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1645
1646         [ews-build] Use PostgreSQL for ews-build database
1647         https://bugs.webkit.org/show_bug.cgi?id=196229
1648
1649         Reviewed by Lucas Forschler.
1650
1651         * BuildSlaveSupport/ews-build/master.cfg:
1652
1653 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1654
1655         [ews-build] Get master_hostname dynamically in master.cfg
1656         https://bugs.webkit.org/show_bug.cgi?id=196255
1657
1658         Reviewed by Lucas Forschler.
1659
1660         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1661         send events data in test mode.
1662
1663 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1664
1665         [ews-app] Set db_constraint to False for Foreign Keys
1666         https://bugs.webkit.org/show_bug.cgi?id=196252
1667
1668         Reviewed by Lucas Forschler.
1669
1670         * BuildSlaveSupport/ews-app/ews/models/build.py:
1671         * BuildSlaveSupport/ews-app/ews/models/step.py:
1672
1673 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1674
1675         [ews-build] is_test_mode_enabled should default to True
1676         https://bugs.webkit.org/show_bug.cgi?id=196248
1677
1678         Reviewed by Lucas Forschler.
1679
1680         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1681
1682 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1683
1684         [ews-app] Add webkitperl to ENABLED_QUEUES
1685         https://bugs.webkit.org/show_bug.cgi?id=196253
1686
1687         Reviewed by Lucas Forschler.
1688
1689         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1690
1691 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1692
1693         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1694         https://bugs.webkit.org/show_bug.cgi?id=196211
1695         rdar://problem/49110552
1696
1697         Reviewed by Tim Horton.
1698
1699         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1700         Make sure that EventSenderProxy always exists when running tests. We used to create
1701         it when resetting before the first test, which is a bit too late.
1702
1703         * WebKitTestRunner/TestController.h:
1704         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1705         (WTR::TestController::platformCreateWebView):
1706         (WTR::TestController::platformCreateOtherPage):
1707         (WTR::TestController::finishCreatingPlatformWebView):
1708         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1709         (WTR::PlatformWebView::PlatformWebView):
1710         Moved some code that made NSWindow use NSEvent during web view creation. We may
1711         need to move more if some other case us found, but this is enough for now.
1712
1713 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1714
1715         Unreviewed. Fix typo in GLib geolocation API after r243285.
1716
1717         gelocation -> geolocation.
1718
1719         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1720         (testGeolocationManagerWatchPosition):
1721
1722 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1723
1724         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1725         https://bugs.webkit.org/show_bug.cgi?id=196213
1726
1727         Reviewed by Geoff Garen.
1728
1729         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1730         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1731         (credentialWithIdentityAndKeychainPath):
1732         (-[ChallengeDelegate webView:didFinishNavigation:]):
1733         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1734         (TestWebKitAPI::TEST):
1735
1736 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1737
1738         Expected shouldn't assume its contained types are copyable
1739         https://bugs.webkit.org/show_bug.cgi?id=195986
1740
1741         Reviewed by JF Bastien.
1742
1743         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1744         (TestWebKitAPI::NonCopyable::operator== const):
1745         (TestWebKitAPI::NonCopyable::operator!= const):
1746         (TestWebKitAPI::TEST):
1747
1748 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1749
1750         Remove some now-unnecessary dynamic class lookup
1751         https://bugs.webkit.org/show_bug.cgi?id=196237
1752
1753         Reviewed by Simon Fraser.
1754
1755         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1756         (makeRequest):
1757         (TEST):
1758
1759 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1760
1761         Unreviewed, rolling out r243450.
1762
1763         AppleWin and WinCairo port builds get broken.
1764
1765         Reverted changeset:
1766
1767         "Add test for fix of #196095"
1768         https://bugs.webkit.org/show_bug.cgi?id=196097
1769         https://trac.webkit.org/changeset/243450
1770
1771 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1772
1773         Unreviewed, rolling out r243465.
1774         https://bugs.webkit.org/show_bug.cgi?id=196226
1775
1776         the test doesn't build (Requested by thorton on #webkit).
1777
1778         Reverted changeset:
1779
1780         "Do not terminate the NetworkProcess if a third party
1781         application sends a NSCredential with a SecIdentityRef"
1782         https://bugs.webkit.org/show_bug.cgi?id=196213
1783         https://trac.webkit.org/changeset/243465
1784
1785 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1786
1787         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1788         https://bugs.webkit.org/show_bug.cgi?id=196213
1789
1790         Reviewed by Geoff Garen.
1791
1792         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1793         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1794         (credentialWithIdentityAndKeychainPath):
1795         (-[ChallengeDelegate webView:didFinishNavigation:]):
1796         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1797         (TestWebKitAPI::TEST):
1798
1799 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1800
1801         [ews-build] Gracefully handle missing patch_id in events
1802         https://bugs.webkit.org/show_bug.cgi?id=196216
1803
1804         Reviewed by Lucas Forschler.
1805
1806         * BuildSlaveSupport/ews-build/events.py:
1807
1808 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1809
1810         [ews-build] use lz4 compression for improving buildbot performance
1811         https://bugs.webkit.org/show_bug.cgi?id=196155
1812
1813         Reviewed by Lucas Forschler.
1814
1815         * BuildSlaveSupport/ews-build/master.cfg:
1816
1817 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1818
1819         Pull some API testing helper methods out of TestWKWebView
1820         https://bugs.webkit.org/show_bug.cgi?id=196212
1821
1822         Reviewed by Tim Horton.
1823
1824         Refactor some more API testing utility methods, so that they can be used in
1825         tests that do not use TestWKWebView.
1826
1827         * TestWebKitAPI/cocoa/TestWKWebView.h:
1828         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1829         (-[WKWebView loadTestPageNamed:]):
1830         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1831         (-[WKWebView synchronouslyLoadHTMLString:]):
1832         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1833         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1834         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1835         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1836         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1837
1838 2019-03-25  Jer Noble  <jer.noble@apple.com>
1839
1840         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1841         https://bugs.webkit.org/show_bug.cgi?id=196097
1842
1843         Reviewed by Eric Carlson.
1844
1845         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1846
1847         * DumpRenderTree/mac/DumpRenderTree.mm:
1848         (resetWebPreferencesToConsistentValues):
1849         * WebKitTestRunner/TestController.cpp:
1850         (WTR::TestController::resetPreferencesToConsistentValues):
1851
1852 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1853
1854         Pull IPadUserInterfaceSwizzler out into a separate header file
1855         https://bugs.webkit.org/show_bug.cgi?id=196193
1856
1857         Reviewed by Anders Carlsson.
1858
1859         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1860         be used in other API tests.
1861
1862         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1863         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1864         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1865         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1866         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1867         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1868         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1869
1870 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1871
1872         Remove NavigatorContentUtils in WebCore/Modules
1873         https://bugs.webkit.org/show_bug.cgi?id=196070
1874
1875         Reviewed by Alex Christensen.
1876
1877         NavigatorContentUtils was to support the custom scheme spec [1].
1878         However, in WebKit side, no port has supported the feature in
1879         WebKit layer after EFL port was removed. So there has been the
1880         only IDL implementation of the NavigatorContentUtils in WebCore.
1881         So we don't need to keep the implementation in WebCore anymore.
1882
1883         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1884
1885         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1886
1887 2019-03-24  Andy Estes  <aestes@apple.com>
1888
1889         [watchOS] Remove unused Proximity Networking code
1890         https://bugs.webkit.org/show_bug.cgi?id=196188
1891
1892         Reviewed by Tim Horton.
1893
1894         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1895         (TEST):
1896
1897 2019-03-23  Keith Miller  <keith_miller@apple.com>
1898
1899         Refactor clz/ctz and fix getLSBSet.
1900         https://bugs.webkit.org/show_bug.cgi?id=196162
1901
1902         Reviewed by Saam Barati.
1903
1904         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1905
1906         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1907         (TestWebKitAPI::TEST):
1908
1909 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1910
1911         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1912         https://bugs.webkit.org/show_bug.cgi?id=196143
1913
1914         Reviewed by Michael Catanzaro.
1915
1916         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1917         directories.
1918
1919         * Scripts/webkitpy/style/checkers/cpp.py:
1920         (check_identifier_name_in_declaration):
1921         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1922         (WebKitStyleTest.test_names):
1923
1924 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1925
1926         [Flatpak] Manifest expanding fails for qt WPE extension
1927         https://bugs.webkit.org/show_bug.cgi?id=196148
1928
1929         Reviewed by Alex Christensen.
1930
1931         * flatpak/flatpakutils.py:
1932         (expand_submodules_recurse): The last recurse manifest expand
1933         iteration might lead to a single module so take it into account
1934         and don't try to recurse further.
1935
1936 2019-03-22  Chris Dumez  <cdumez@apple.com>
1937
1938         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1939         https://bugs.webkit.org/show_bug.cgi?id=195348
1940         <rdar://problem/48622090>
1941
1942         Reviewed by Alex Christensen.
1943
1944         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1945         to NO when test.options().shouldIgnoreMetaViewport is false.
1946
1947         * WebKitTestRunner/ios/TestControllerIOS.mm:
1948         (WTR::TestController::platformConfigureViewForTest):
1949
1950 2019-03-22  Chris Dumez  <cdumez@apple.com>
1951
1952         Prewarmed processes should be usable with any website data store
1953         https://bugs.webkit.org/show_bug.cgi?id=196104
1954
1955         Reviewed by Alex Christensen.
1956
1957         Add API test coverage.
1958
1959         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1960         (runInitialWarmedProcessUsedTest):
1961         (TEST):
1962
1963 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1964
1965         Back out local changes to Alex's Subversion working directory
1966
1967         They were accidentally committed.
1968
1969         * Scripts/webkitpy/common/system/abstractexecutive.py:
1970         (AbstractExecutive.wait_newest):
1971         * Scripts/webkitpy/common/system/executive.py:
1972         (Executive.running_pids):
1973         * Scripts/webkitpy/common/system/executive_mock.py:
1974         (MockExecutive.running_pids):
1975         * Scripts/webkitpy/common/system/executive_unittest.py:
1976         (ExecutiveTest.serial_test_running_pids):
1977         * Scripts/webkitpy/port/darwin.py:
1978         (DarwinPort.check_for_leaks):
1979         * Scripts/webkitpy/port/leakdetector.py:
1980         (LeakDetector.check_for_leaks):
1981         - This was the hack attached to Bug 193772.
1982
1983         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1984         (+[WebKitTestRunnerEvent mouseLocation]):
1985         - This works around a crash on an internal build.
1986
1987 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1988
1989         Fix the build after r243354
1990         https://bugs.webkit.org/show_bug.cgi?id=196138
1991         <rdar://problem/49145951>
1992
1993         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1994         (TEST):
1995         * TestWebKitAPI/ios/UIKitSPI.h:
1996
1997 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1998
1999         Adopt UIWKDocumentContext
2000         https://bugs.webkit.org/show_bug.cgi?id=196040
2001         <rdar://problem/48642440>
2002
2003         Reviewed by Ryosuke Niwa.
2004
2005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2006         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2007         (makeRequest):
2008         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2009         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2010         (applyStyle):
2011         (TEST):
2012         Add tests for UIWKDocumentContext.
2013
2014         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2015         (TEST):
2016         (recursiveFindWKContentView): Deleted.
2017         * TestWebKitAPI/cocoa/TestWKWebView.h:
2018         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2019         (recursiveFindWKContentView):
2020         (-[TestWKWebView wkContentView]):
2021         * TestWebKitAPI/ios/UIKitSPI.h:
2022         Share the WKContentView finding code between tests.
2023
2024 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2025
2026         [iOS WK2] Turn on async overflow scrolling by default
2027         https://bugs.webkit.org/show_bug.cgi?id=196011
2028         rdar://problem/48453859
2029
2030         Reviewed by Antti Koivisto.
2031         
2032         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2033         since so many basic layout tests have different results when compositing is triggered for
2034         overflow.
2035         
2036         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2037
2038         * WebKitTestRunner/TestController.cpp:
2039         (WTR::TestController::resetPreferencesToConsistentValues):
2040
2041 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2042
2043         [ews-build] Retry API test in case of failures
2044         https://bugs.webkit.org/show_bug.cgi?id=196004
2045
2046         Reviewed by Lucas Forschler.
2047
2048         * BuildSlaveSupport/ews-build/steps.py:
2049         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2050         (CompileWebKitToT.doStepIf): Ditto.
2051         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2052         (ReRunAPITests): Re-run API tests.
2053         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2054         (RunAPITestsWithoutPatch): Run API tests without patch.
2055         (RunAPITestsWithoutPatch.doStepIf):
2056         (RunAPITestsWithoutPatch.hideStepIf):
2057         (RunAPITestsWithoutPatch.evaluateCommand):
2058         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2059         (AnalyzeAPITestsResults.start):
2060         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2061         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2062         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2063         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2064
2065 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2066
2067         [ews-build] Update queues configurations
2068         https://bugs.webkit.org/show_bug.cgi?id=196074
2069
2070         Reviewed by Dewei Zhu.
2071
2072         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2073         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2074
2075 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2076
2077         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2078         https://bugs.webkit.org/show_bug.cgi?id=195680
2079         <rdar://problem/48903534>
2080
2081         Unreviewed infrastructure fix.
2082
2083         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2084         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2085
2086 2019-03-21  Andy Estes  <aestes@apple.com>
2087
2088         [iOS] Apple Pay should be available in documents with no user agent scripts
2089         https://bugs.webkit.org/show_bug.cgi?id=196061
2090         <rdar://problem/48649391>
2091
2092         Reviewed by Brady Eidson.
2093
2094         Added API tests and related infrastructure.
2095
2096         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2097         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2098         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2099         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2100         (TestWebKitAPI::TEST):
2101         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2102         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2103         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2104         * TestWebKitAPI/cocoa/TestProtocol.mm:
2105         (-[TestProtocol startLoading]):
2106         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2107         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2108         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2109         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2110
2111 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2112
2113         REGRESSSION (r243297): webkitpy tests broken
2114         https://bugs.webkit.org/show_bug.cgi?id=196108
2115
2116         Reviewed by Aakash Jain.
2117
2118         r243297 updated contributors.json, which broke a few unit tests.
2119
2120         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2121         (IRCCommandTest.test_whois):
2122         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2123
2124 2019-03-21  Chris Dumez  <cdumez@apple.com>
2125
2126         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2127         https://bugs.webkit.org/show_bug.cgi?id=196041
2128         <rdar://problem/49083230>
2129
2130         Reviewed by Alex Christensen.
2131
2132         Add API test coverage.
2133
2134         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2135         (TEST):
2136
2137 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2138
2139         Add SPI to inform applications of WKContentRuleList actions
2140         https://bugs.webkit.org/show_bug.cgi?id=195965
2141         <rdar://problem/42664365>
2142
2143         Reviewed by Geoff Garen.
2144
2145         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2146         (TestWebKitAPI::allActionsForResourceLoad):
2147         (TestWebKitAPI::testRequest):
2148         (TestWebKitAPI::TEST_F):
2149         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2150         (Notification::description):
2151         (Notification::operator== const):
2152         (toVector):
2153         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2154         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2155         (makeContentRuleList):
2156         (TEST):
2157         (makeWarnContentRuleList): Deleted.
2158
2159 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2160
2161         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2162         https://bugs.webkit.org/show_bug.cgi?id=196088
2163
2164         Reviewed by Brian Burg.
2165
2166         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2167         Support checks when only one platform is specified. Also deprecate macosx() and
2168         force the use of macos() instead.
2169
2170         * Scripts/webkitpy/style/checkers/cpp.py:
2171         (check_min_versions_of_wk_api_available):
2172         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2173         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2174
2175 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2176
2177         Update status inactive committers' status to 'contributor'.
2178
2179         * Scripts/webkitpy/common/config/contributors.json:
2180
2181 2019-03-21  Xan Lopez  <xan@igalia.com>
2182
2183         [JSC][x86] Drop support for x87 floating point
2184         https://bugs.webkit.org/show_bug.cgi?id=194853
2185
2186         Reviewed by Don Olmstead.
2187
2188         Force SSE2 on x86/32bit builds.
2189
2190         * Scripts/webkitdirs.pm:
2191         (generateBuildSystemFromCMakeProject):
2192
2193 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2194
2195         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2196         https://bugs.webkit.org/show_bug.cgi?id=196073
2197
2198         Reviewed by Michael Catanzaro.
2199
2200         Add test cases to check functions and constructors with no arguments but receiving user data.
2201
2202         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2203         (checkUserData):
2204         (testJSCFunction):
2205         (fooCreateWithUserData):
2206         (testJSCClass):
2207
2208 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2209
2210         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2211
2212         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2213
2214         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2215
2216 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2217
2218         [GTK][WPE] Add API to provide geolocation information
2219         https://bugs.webkit.org/show_bug.cgi?id=195940
2220
2221         Reviewed by Michael Catanzaro.
2222
2223         Add a new test to check the new API.
2224
2225         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2226         (testGeolocationManagerCurrentPosition):
2227         (testGeolocationManagerWatchPosition):
2228         (beforeAll):
2229         (afterAll):
2230         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2231         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2232         (beforeAll): Ditto.
2233         * TestWebKitAPI/glib/CMakeLists.txt:
2234
2235 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2236
2237         [GLib] Returning G_TYPE_OBJECT from a method does not work
2238         https://bugs.webkit.org/show_bug.cgi?id=195574
2239
2240         Reviewed by Michael Catanzaro.
2241
2242         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2243
2244         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2245         (getGFile):
2246         (getParent):
2247         (createGString):
2248         (getGString):
2249         (getGStringCopyWillRaise):
2250         (getGStringCopy):
2251         (getGStringStr):
2252         (getGStringLen):
2253         (freeGString):
2254         (testJSCClass):
2255
2256 2019-03-20  Saam Barati  <sbarati@apple.com>
2257
2258         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2259         https://bugs.webkit.org/show_bug.cgi?id=195721
2260
2261         Reviewed by Filip Pizlo.
2262
2263         * Scripts/run-javascriptcore-tests:
2264
2265 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2266
2267         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2268         https://bugs.webkit.org/show_bug.cgi?id=196049
2269
2270         Reviewed by Tim Horton.
2271
2272         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2273         overflow scrolling in general, so rename it.
2274
2275         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2276
2277 2019-03-20  Daniel Bates  <dabates@apple.com>
2278
2279         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2280         https://bugs.webkit.org/show_bug.cgi?id=196031
2281         <rdar://problem/49078172>
2282
2283         Reviewed by Tim Horton.
2284
2285         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2286         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2287         same code path used when the Done button is pressed to dismiss the <select> picker.
2288
2289         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2290         (TestWebKitAPI::TEST):
2291
2292 2019-03-20  Chris Dumez  <cdumez@apple.com>
2293
2294         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2295         https://bugs.webkit.org/show_bug.cgi?id=196029
2296         <rdar://problem/48954651>
2297
2298         Reviewed by Tim Horton.
2299
2300         Add API test coverage.
2301
2302         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2303
2304 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2305
2306         [ews-build] Improve failure summary string for ApplyPatch step
2307         https://bugs.webkit.org/show_bug.cgi?id=195995
2308
2309         Reviewed by Alexey Proskuryakov.
2310
2311         * BuildSlaveSupport/ews-build/steps.py:
2312         (ApplyPatch.getResultSummary): Override getResultSummary.
2313
2314 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2315
2316         AX: Implement support for new meter ARIA role
2317         https://bugs.webkit.org/show_bug.cgi?id=195966
2318
2319         Reviewed by Chris Fleizach.
2320
2321         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2322         to AXLevelIndicator.
2323
2324         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2325
2326 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2327
2328         [WebAuthN] Implement FIDO AppID extension
2329         https://bugs.webkit.org/show_bug.cgi?id=143491
2330         <rdar://problem/48298273>
2331
2332         Reviewed by Brent Fulgham.
2333
2334         Add a test that covers the new flag of convertToU2fSignCommand.
2335
2336         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2337         (TestWebKitAPI::TEST):
2338         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2339         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2340         (TestWebKitAPI::TEST):
2341
2342 2019-03-19  Keith Rollin  <krollin@apple.com>
2343
2344         Add support for more platforms to generate-xcfilelists
2345         https://bugs.webkit.org/show_bug.cgi?id=195977
2346
2347         Reviewed by Alexey Proskuryakov.
2348
2349         generate-xcfilelists incorrectly complains when involved with building
2350         WebKit for iphonesimulator:
2351
2352             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2353             …
2354             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2355
2356         Address this by teaching generate-xcfilelists about more platforms.
2357
2358         * Scripts/generate-xcfilelists:
2359
2360 2019-03-19  John Wilander  <wilander@apple.com>
2361
2362         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2363         https://bugs.webkit.org/show_bug.cgi?id=195923
2364         <rdar://problem/49001272>
2365
2366         Reviewed by Alex Christensen.
2367
2368         This patch does the following to the TestRunner:
2369         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2370         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2371         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2372
2373         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2374         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2375         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2376         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2377         * WebKitTestRunner/TestController.cpp:
2378         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2379         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2380         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2381         * WebKitTestRunner/TestController.h:
2382         * WebKitTestRunner/TestInvocation.cpp:
2383         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2384
2385 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2386
2387         [CMake] Support more clang and gcc sanitizers
2388         https://bugs.webkit.org/show_bug.cgi?id=195956
2389
2390         Reviewed by Michael Catanzaro.
2391
2392         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2393
2394 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2395
2396         [ews-build] Improve summary for PrintConfiguration step
2397         https://bugs.webkit.org/show_bug.cgi?id=195945
2398
2399         Reviewed by Lucas Forschler.
2400
2401         * BuildSlaveSupport/ews-build/steps.py:
2402         (PrintConfiguration.getResultSummary): Override getResultSummary.
2403
2404 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2405
2406         [ews-build] Improve summary for CheckOutSource step
2407         https://bugs.webkit.org/show_bug.cgi?id=195963
2408
2409         Reviewed by Lucas Forschler.
2410
2411         * BuildSlaveSupport/ews-build/steps.py:
2412         (CheckOutSource.getResultSummary):
2413
2414 2019-03-19  Daniel Bates  <dabates@apple.com>
2415
2416         [iOS] Focus not preserved when switching between tabs
2417         https://bugs.webkit.org/show_bug.cgi?id=195820
2418         <rdar://problem/43614450>
2419
2420         Reviewed by Brent Fulgham.
2421
2422         Add tests to ensure that we restore focus when resigning and becoming first responder.
2423
2424         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2425         (TestWebKitAPI::TEST):
2426
2427 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2428
2429         Make WTFLogChannelState and WTFLogLevel enum classes
2430         https://bugs.webkit.org/show_bug.cgi?id=195904
2431
2432         Reviewed by Eric Carlson.
2433
2434         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2435         (TestWebKitAPI::TEST_F):
2436
2437 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2438
2439         [GStreamer][EME] Backported mssdemux protection data crash fix
2440         https://bugs.webkit.org/show_bug.cgi?id=195918
2441
2442         Reviewed by Philippe Normand.
2443
2444         * gstreamer/jhbuild.modules:
2445         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2446
2447 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2448
2449         Unreviewed, rolling out r243132.
2450
2451         Broke GTK build
2452
2453         Reverted changeset:
2454
2455         "Make WTFLogChannelState and WTFLogLevel enum classes"
2456         https://bugs.webkit.org/show_bug.cgi?id=195904
2457         https://trac.webkit.org/changeset/243132
2458
2459 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2460
2461         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2462
2463         * Scripts/webkitdirs.pm:
2464         (builtDylibPathForName): Adjust the shared library name that's changed
2465         with the API version bump in r243073.
2466
2467 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2468
2469         Make WTFLogChannelState and WTFLogLevel enum classes
2470         https://bugs.webkit.org/show_bug.cgi?id=195904
2471
2472         Reviewed by Eric Carlson.
2473
2474         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2475         (TestWebKitAPI::TEST_F):
2476
2477 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2478
2479         Disable flaky test added in r2431100
2480         https://webkit.org/b/195785
2481
2482         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2483         (TestWebKitAPI::TEST):
2484         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2485
2486 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2487
2488         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2489         https://bugs.webkit.org/show_bug.cgi?id=195916
2490
2491         Reviewed by Tim Horton.
2492
2493         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2494         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2495
2496 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2497
2498         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2499
2500         * Scripts/webkitpy/common/config/contributors.json:
2501
2502 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2503
2504         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2505         https://bugs.webkit.org/show_bug.cgi?id=195785
2506
2507         Reviewed by Geoffrey Garen.
2508
2509         * TestWebKitAPI/TCPServer.cpp: Added.
2510         (TestWebKitAPI::TCPServer::TCPServer):
2511         (TestWebKitAPI::TCPServer::~TCPServer):
2512         (TestWebKitAPI::TCPServer::socketBindListen):
2513         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2514         * TestWebKitAPI/TCPServer.h: Added.
2515         (TestWebKitAPI::TCPServer::port const):
2516         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2517         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2518         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2519         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2520         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2521         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2522         (TestWebKitAPI::respondSlowly):
2523         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2524         (TestWebKitAPI::downloadAtRate):
2525         (TestWebKitAPI::TEST):
2526
2527 2019-03-18  Saam Barati  <sbarati@apple.com>
2528
2529         Add a plan file for JetStream 2
2530         https://bugs.webkit.org/show_bug.cgi?id=190734
2531
2532         Reviewed by Mark Lam.
2533
2534         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2535
2536 2019-03-18  Chris Dumez  <cdumez@apple.com>
2537
2538         Delay WebProcess launch until a load is triggered in a Web view
2539         https://bugs.webkit.org/show_bug.cgi?id=195758
2540         <rdar://problem/48126013>
2541
2542         Reviewed by Geoff Garen.
2543
2544         Add API test coverage. Also update some existing API tests to not expect
2545         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2546
2547         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2548         (TestWebKitAPI::TEST):
2549         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2550         (TestWebKitAPI::TEST):
2551         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2552         (TEST):
2553         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2554         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2555         (TEST):
2556         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2557         (TEST):
2558         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2559
2560 2019-03-18  Xan Lopez  <xan@igalia.com>
2561
2562         [CMake] Prevent potential warning when determining $architecture
2563         https://bugs.webkit.org/show_bug.cgi?id=195891
2564
2565         Reviewed by Michael Catanzaro.
2566
2567         It's possible for generateBuildSystemForCMakeProject to be called
2568         before determineArchitecture() is ever called. This will make the
2569         first eq check with $architecture to be bogus (and print a
2570         warning). Change that to an eq check with architecture(), which
2571         implicitly calls determineArchitecture() if needed, and change all
2572         the other similar cases in the method in the same way to prevent
2573         future bugs like this one.
2574
2575         * Scripts/webkitdirs.pm:
2576         (generateBuildSystemFromCMakeProject):
2577
2578 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2579
2580         [WPE] Tarballs generated with “make dist” cannot build documentation
2581         https://bugs.webkit.org/show_bug.cgi?id=195885
2582
2583         Reviewed by Carlos Garcia Campos.
2584
2585         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2586
2587 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2588
2589         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2590         https://bugs.webkit.org/show_bug.cgi?id=195883
2591
2592         Reviewed by Carlos Garcia Campos.
2593
2594         * gtkdoc/gtkdoc.py:
2595         (GTKDoc._run_command): When commands fail to run, include the full command line for
2596         the program invocation and the output it has generated on the standard error stream.
2597
2598 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2599
2600         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2601         https://bugs.webkit.org/show_bug.cgi?id=195786
2602
2603         Reviewed by Philippe Normand.
2604
2605         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2606         * wpe/jhbuild.modules: Ditto.
2607
2608 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2609
2610         [ews-build] Don't run clean builds on EWS builders
2611         https://bugs.webkit.org/show_bug.cgi?id=195851
2612
2613         Reviewed by Geoffrey Garen.
2614
2615         * BuildSlaveSupport/ews-build/factories.py:
2616
2617 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2618
2619         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2620         https://bugs.webkit.org/show_bug.cgi?id=195849
2621
2622         Reviewed by Chris Dumez.
2623
2624         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2625
2626         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2627         (runWebsiteDataStoreCustomPaths):
2628
2629 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2630
2631         webkitpy: Upload test results
2632         https://bugs.webkit.org/show_bug.cgi?id=195755
2633         <rdar://problem/48896182>
2634
2635         Reviewed by Aakash Jain.
2636
2637         Establish a new format for uploading results that is not tied to layout tests, apply
2638         that format to webkitpy tests.
2639
2640         * Scripts/webkitpy/common/checkout/scm/git.py:
2641         (Git.native_branch): Return what branch the current checkout is on.
2642         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2643         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2644         * Scripts/webkitpy/common/checkout/scm/svn.py:
2645         (SVN.native_branch): Ditto.
2646         * Scripts/webkitpy/common/system/platforminfo.py:
2647         (PlatformInfo.build_version): Return a build version for Mac.
2648         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2649         (MockPlatformInfo.__init__):
2650         (MockPlatformInfo.build_version):
2651         * Scripts/webkitpy/results: Added.
2652         * Scripts/webkitpy/results/__init__.py: Added.
2653         * Scripts/webkitpy/results/options.py: Added.
2654         (upload_options): OptParse list for upload options.
2655         * Scripts/webkitpy/results/upload.py: Added.
2656         (Upload): Class which enforces the upload format expected by the results server.
2657         (Upload.Expectations):
2658         (Upload.create_configuration):
2659         (Upload.create_commit):
2660         (Upload.create_details):
2661         (Upload.create_run_stats):
2662         (Upload.create_test_result):
2663         (Upload.__init__):
2664         (Upload.Encoder): Encode Upload object as json.
2665         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2666         * Scripts/webkitpy/results/upload_unittest.py: Added.
2667         * Scripts/webkitpy/test/main.py:
2668         (Tester._parse_args): Add upload arguments.
2669         (Tester._run_tests): Allow results to be uploaded.
2670         * Scripts/webkitpy/test/runner.py:
2671         (Runner.__init__): Record which tests were run, rather than just counting them.
2672         (Runner.handle):
2673         * Scripts/webkitpy/test/runner_unittest.py:
2674         (RunnerTest.test_run):
2675         * Scripts/webkitpy/thirdparty/__init__.py:
2676         (AutoinstallImportHook.find_module): Add requests auto-install.
2677         (AutoinstallImportHook._install_requests):
2678         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2679         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2680
2681 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2682
2683         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2684         https://bugs.webkit.org/show_bug.cgi?id=195810
2685
2686         Reviewed by Tim Horton.
2687
2688         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2689         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2690         ending certain layout tests.
2691
2692         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2693         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2694         (-[TestRunnerWKWebView dealloc]):
2695         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2696
2697         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2698         helper method when destroying the web view, and when resetting state between tests.
2699
2700         * WebKitTestRunner/ios/TestControllerIOS.mm:
2701         (WTR::TestController::platformResetStateToConsistentValues):
2702
2703         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2704
2705 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2706
2707         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2708         https://bugs.webkit.org/show_bug.cgi?id=190350
2709         <rdar://problem/45089503>
2710
2711         Reviewed by Geoffrey Garen.
2712
2713         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2714         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2715         (TEST):
2716         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2717         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2718         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2719         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2720         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2721         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2722         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2723         (runTest):
2724         (createDirectories):
2725         (TEST):
2726         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2727         (TEST):
2728         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2729         (TEST):
2730
2731 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2732
2733         Add support to WebPage for getting the contents as an attributed string.
2734         https://bugs.webkit.org/show_bug.cgi?id=195636
2735         rdar://problem/45055697
2736
2737         Reviewed by Tim Horton.
2738
2739         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2740         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2741
2742 2019-03-15  Chris Dumez  <cdumez@apple.com>
2743
2744         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2745         https://bugs.webkit.org/show_bug.cgi?id=195747
2746
2747         Reviewed by Geoff Garen.
2748
2749         Add API test coverage.
2750
2751         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2752
2753 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2754
2755         Unreviewed, rolling out r242952.
2756
2757         Causing API failures on iOS Simulator
2758
2759         Reverted changeset:
2760
2761         "[PSON] Make sure the WebProcessCache is leverage when
2762         relaunching a process after termination"
2763         https://bugs.webkit.org/show_bug.cgi?id=195747
2764         https://trac.webkit.org/changeset/242952
2765
2766 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2767
2768         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2769         https://bugs.webkit.org/show_bug.cgi?id=195740
2770
2771         Reviewed by Ross Kirsling.
2772
2773         window.open doesn't work for WebKitBrowserWindow because it is not
2774         implemented yet.
2775
2776         1. Implemented createNewPage callback of WKPageUIClient.
2777         2. Changed MainWindow to take a BrowserWindow factory function
2778           instead of BrowserWindowType to be flexible to create
2779           BrowserWindow with extra settings.
2780         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2781           because it is not relevant with MainWindow anymore.
2782
2783         * MiniBrowser/win/Common.cpp:
2784         (parseCommandLine):
2785         * MiniBrowser/win/Common.h:
2786         (CommandLineOptions::CommandLineOptions):
2787         * MiniBrowser/win/MainWindow.cpp:
2788         (MainWindow::MainWindow):
2789         (MainWindow::create):
2790         (MainWindow::init):
2791         (MainWindow::WndProc):
2792         * MiniBrowser/win/MainWindow.h:
2793         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2794         (PrintWebUIDelegate::createWebViewWithRequest):
2795         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2796         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2797         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2798         (WebKitBrowserWindow::updateProxySettings):
2799         (WebKitBrowserWindow::createNewPage):
2800         * MiniBrowser/win/WebKitBrowserWindow.h:
2801         * MiniBrowser/win/WinMain.cpp:
2802         (wWinMain):
2803
2804 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2805
2806         Make it possible to test scrolling tree layer manipulation more easily
2807         https://bugs.webkit.org/show_bug.cgi?id=195780
2808
2809         Reviewed by Tim Horton.
2810         
2811         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2812         cuts off communication of scrolling tree scrolls back to the web process
2813         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2814         allows tests to trigger scrolls which run the scrolling tree layer positioning
2815         logic, but never get another commit from the web process that might mask
2816         scrolling tree bugs.
2817         
2818         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2819         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2820         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2821
2822         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2823         (WTR::UIScriptController::scrollUpdatesDisabled const):
2824         (WTR::UIScriptController::setScrollUpdatesDisabled):
2825         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2826         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2827         (WTR::UIScriptController::scrollUpdatesDisabled const):
2828         (WTR::UIScriptController::setScrollUpdatesDisabled):
2829         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2830         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2831         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2832         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2833         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2834         * WebKitTestRunner/ios/TestControllerIOS.mm:
2835         (WTR::TestController::platformResetStateToConsistentValues):
2836         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2837         (WTR::UIScriptController::scrollUpdatesDisabled const):
2838         (WTR::UIScriptController::setScrollUpdatesDisabled):
2839
2840 2019-03-14  Youenn Fablet  <youenn@apple.com>
2841
2842         Move IDB storage in private browsing mode to NetworkProcess
2843         https://bugs.webkit.org/show_bug.cgi?id=195602
2844
2845         Reviewed by Brady Eidson.
2846
2847         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2848         (TEST):
2849
2850 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2851
2852         [ews-build] Make descriptionDone messages more readable
2853         https://bugs.webkit.org/show_bug.cgi?id=195760
2854
2855         Reviewed by Lucas Forschler.
2856
2857         * BuildSlaveSupport/ews-build/steps.py:
2858         * BuildSlaveSupport/ews-build/steps_unittest.py:
2859
2860 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2861
2862         [ews-build] Generate status-bubble hover-over messages
2863         https://bugs.webkit.org/show_bug.cgi?id=195680
2864
2865         Reviewed by Lucas Forschler.
2866
2867         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2868         (StatusBubble):
2869         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2870         on hover-over.
2871         (StatusBubble._iso_time):
2872         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2873         hover-over message.
2874         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2875
2876 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2877
2878         [ews-app] Gracefully handle the case when state_string is None
2879         https://bugs.webkit.org/show_bug.cgi?id=195753
2880
2881         Reviewed by Lucas Forschler.
2882
2883         * BuildSlaveSupport/ews-app/ews/models/build.py:
2884         * BuildSlaveSupport/ews-app/ews/models/step.py:
2885
2886 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2887
2888         [ews-app] Status bubble display pending for currently running build step
2889         https://bugs.webkit.org/show_bug.cgi?id=195744
2890
2891         Reviewed by Lucas Forschler.
2892
2893         * BuildSlaveSupport/ews-build/events.py:
2894         (Events.stepStarted): If state_string is pending, replace it with step name.
2895
2896 2019-03-14  Chris Dumez  <cdumez@apple.com>
2897
2898         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2899         https://bugs.webkit.org/show_bug.cgi?id=195750
2900
2901         Reviewed by Geoffrey Garen.
2902
2903         Add API test coverage.
2904
2905         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2906         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2907         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2908         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2909
2910 2019-03-14  Chris Dumez  <cdumez@apple.com>
2911
2912         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2913         https://bugs.webkit.org/show_bug.cgi?id=195747
2914
2915         Reviewed by Geoff Garen.
2916
2917         Add API test coverage.
2918
2919         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2920
2921 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2922
2923         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2924         https://bugs.webkit.org/show_bug.cgi?id=195725
2925         <rdar://problem/48545062>
2926
2927         Reviewed by Tim Horton.
2928
2929         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2930         handler is nil.
2931
2932         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2933         (TestWebKitAPI::TEST):
2934
2935 2019-03-13  Sam Weinig  <sam@webkit.org>
2936
2937         Add utility function to allow easy reverse range-based iteration of a container
2938         https://bugs.webkit.org/show_bug.cgi?id=195542
2939
2940         Reviewed by Antti Koivisto.
2941
2942         * TestWebKitAPI/CMakeLists.txt:
2943         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2944         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2945         (TestWebKitAPI::TEST):
2946         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2947
2948 2019-03-13  Chris Dumez  <cdumez@apple.com>
2949
2950         Use a ServiceWorker process per registrable domain
2951         https://bugs.webkit.org/show_bug.cgi?id=195649
2952
2953         Reviewed by Youenn Fablet.
2954
2955         Update API test coverage.
2956
2957         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2958
2959 2019-03-13  Chris Dumez  <cdumez@apple.com>
2960
2961         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2962         https://bugs.webkit.org/show_bug.cgi?id=195684
2963         <rdar://problem/48294714>
2964
2965         Reviewed by Antti Koivisto.
2966
2967         Add API test coverage.
2968
2969         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2970
2971 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2972
2973         [ews-app] Remove unused patch view
2974         https://bugs.webkit.org/show_bug.cgi?id=195669
2975
2976         Reviewed by Lucas Forschler.
2977
2978         * BuildSlaveSupport/ews-app/ews/urls.py:
2979         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2980
2981 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2982
2983         [ews-app] Use Buildbot result code variables
2984         https://bugs.webkit.org/show_bug.cgi?id=195668
2985
2986         Reviewed by Alexey Proskuryakov.
2987
2988         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2989         (Buildbot): Added Buildbot result code variables.
2990         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2991         (StatusBubble._build_bubble): Used Buildbot result code variables.
2992
2993 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2994
2995         [Flatpak] Expand submodule recursively
2996         https://bugs.webkit.org/show_bug.cgi?id=195672
2997
2998         Building WPE with flatpak was impossible without that as it was raising an exception.
2999         Also update wpebackend-fdo to match what is built in jhbuild
3000
3001         Reviewed by Philippe Normand.
3002
3003         * flatpak/flatpakutils.py:
3004         (expand_submodules_recurse):
3005         (expand_manifest):
3006         * flatpak/org.webkit.WPEModules.yaml:
3007
3008 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3009
3010         [ews-app] status bubble should be hidden for certain builds
3011         https://bugs.webkit.org/show_bug.cgi?id=194597
3012
3013         Reviewed by Dewei Zhu.
3014
3015         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3016         (StatusBubble._build_bubble):
3017         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3018         because the patch didn't have relevant changes.
3019         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3020         in production yet.
3021
3022 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3023
3024         [Win] Fix a slew of simple clang-cl warnings.
3025         https://bugs.webkit.org/show_bug.cgi?id=195652
3026
3027         Reviewed by Don Olmstead.
3028
3029         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3030         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3031
3032 2019-03-12  Justin Fan  <justin_fan@apple.com>
3033
3034         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3035         https://bugs.webkit.org/show_bug.cgi?id=195518
3036         <rdar://problem/46322356>
3037
3038         Reviewed by Myles C. Maxfield.
3039
3040         * DumpRenderTree/DerivedSources-input.xcfilelist:
3041         * DumpRenderTree/DerivedSources-output.xcfilelist:
3042
3043 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3044
3045         Unreviewed, rolling out r242825.
3046         https://bugs.webkit.org/show_bug.cgi?id=195648
3047
3048         "Broke webkitpy tests with my change to
3049         lldb_dump_class_layout.py" (Requested by rmorisset on
3050         #webkit).
3051
3052         Reverted changeset:
3053
3054         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3055         classes with suspicious padding"
3056         https://bugs.webkit.org/show_bug.cgi?id=195573
3057         https://trac.webkit.org/changeset/242825
3058
3059 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3060
3061         [ews-build] Show status bubbles while the patch is waiting in queue
3062         https://bugs.webkit.org/show_bug.cgi?id=195618
3063
3064         Reviewed by Lucas Forschler.
3065
3066         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3067         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3068         enabled in initial deployment.
3069         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3070         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3071         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3072         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3073         (StatusBubble._build_bubbles_for_patch):
3074
3075 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3076
3077         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3078         https://bugs.webkit.org/show_bug.cgi?id=195573
3079
3080         Reviewed by Simon Fraser.
3081
3082         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3083
3084         * Scripts/dump-class-layout:
3085         (main):
3086         * lldb/lldb_dump_class_layout.py:
3087         (ClassLayout.__init__):
3088         (ClassLayout._compute_padding_recursive):
3089         (LLDBDebuggerInstance.dump_layout_for_classname):
3090         (LLDBDebuggerInstance):
3091         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3092         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3093
3094 2019-03-12  Chris Dumez  <cdumez@apple.com>
3095
3096         Device Orientation access permission should be denied unless explicitly granted by the client
3097         https://bugs.webkit.org/show_bug.cgi?id=195625
3098
3099         Reviewed by Youenn Fablet.
3100
3101         add API test coverage.
3102
3103         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3104         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3105         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3106         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3107         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3108         (runDeviceOrientationTest):
3109         (TEST):
3110         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3111         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3112
3113 2019-03-12  Jer Noble  <jer.noble@apple.com>
3114
3115         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3116         https://bugs.webkit.org/show_bug.cgi?id=195137
3117         <rdar://problem/48810307>
3118
3119         Reviewed by Eric Carlson.
3120
3121         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3122         (TestWebKitAPI::TEST):
3123
3124 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3125
3126         [ews-build] Change urls from uat to production
3127         https://bugs.webkit.org/show_bug.cgi?id=195566
3128
3129         Reviewed by Lucas Forschler.
3130
3131         * BuildSlaveSupport/ews-app/ews/config.py:
3132         * BuildSlaveSupport/ews-build/events.py:
3133         * BuildSlaveSupport/ews-build/steps.py:
3134
3135 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3136
3137         [ews-build] change max_builds for local-worker to 1
3138         https://bugs.webkit.org/show_bug.cgi?id=195568
3139
3140         Reviewed by Lucas Forschler.
3141
3142         * BuildSlaveSupport/ews-build/loadConfig.py:
3143
3144 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3145
3146         Fix the build
3147
3148         * TestRunnerShared/spi/PencilKitTestSPI.h:
3149         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3150
3151 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3152
3153         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3154         https://bugs.webkit.org/show_bug.cgi?id=194131
3155
3156         Reviewed by Michael Catanzaro.
3157
3158         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3159         (uriChanged):
3160         (testUnfinishedSubresourceLoad):
3161         (serverCallback):
3162         (beforeAll):
3163
3164 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3165
3166         WTF::Expected should use std::addressof instead of operator&
3167         https://bugs.webkit.org/show_bug.cgi?id=195604
3168
3169         Reviewed by Myles Maxfield.
3170
3171         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3172         (TestWebKitAPI::Unique::Unique):
3173         (TestWebKitAPI::Unique::operator&):
3174         (TestWebKitAPI::TEST):
3175
3176 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3177
3178         Add Optional to Forward.h.
3179         https://bugs.webkit.org/show_bug.cgi?id=195586
3180
3181         Reviewed by Darin Adler.
3182
3183         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3184         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3185         Remove unnecessary includes from headers.
3186
3187 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3188
3189         Add testing API to hit-test and scroll overflow scrollers
3190         https://bugs.webkit.org/show_bug.cgi?id=195278
3191
3192         Reviewed by Antti Koivisto.
3193         
3194         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3195         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3196         
3197         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3198
3199         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3200         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3201         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3202         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3203         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3204         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3205         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3206         (WTR::enclosingScrollViewIncludingSelf):
3207         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3208
3209 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3210
3211         API test WebKit.RequestTextInputContext fails on iOS
3212         https://bugs.webkit.org/show_bug.cgi?id=195585
3213
3214         Reviewed by Wenson Hsieh and Simon Fraser.
3215
3216         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3217         (applyStyle):
3218         (TEST):
3219         Add a viewport, so that the coordinates match up on iOS.
3220         Scroll by moving the UIScrollView's contentOffset.
3221
3222 2019-03-11  Chris Dumez  <cdumez@apple.com>
3223
3224         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3225         https://bugs.webkit.org/show_bug.cgi?id=195506
3226         <rdar://problem/48733477>
3227
3228         Reviewed by Alex Christensen.
3229
3230         Add API test coverage.
3231
3232         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3233
3234 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3235
3236         Adding myself to contributors.json
3237
3238         Unreviewed, addming myself to contributors.json .
3239
3240         * Scripts/webkitpy/common/config/contributors.json:
3241
3242 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3243
3244         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3245         https://bugs.webkit.org/show_bug.cgi?id=195511
3246         <rdar://problem/44873269>
3247
3248         Reviewed by Darin Adler.
3249
3250         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3251         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3252         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3253         (TEST_F):
3254
3255 2019-03-11  Chris Dumez  <cdumez@apple.com>
3256
3257         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3258         https://bugs.webkit.org/show_bug.cgi?id=195561
3259
3260         Reviewed by Youenn Fablet.
3261
3262         Make sure the JS in the test requests for permission to receive device orientation events.
3263
3264         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3265
3266 2019-03-11  Youenn Fablet  <youenn@apple.com>
3267
3268         Allow storage quota increase by default in WTR
3269         https://bugs.webkit.org/show_bug.cgi?id=195541
3270
3271         Reviewed by Geoffrey Garen.
3272
3273         Allow storage quota increase by default in WTR.
3274         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3275         Use this for tests that explicitly need cache increase.
3276
3277         Instead of increasing quota by 2, make sure the next request is
3278         granted by adding all given parameters.
3279
3280         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3281         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3282         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3283         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3284         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3285         * WebKitTestRunner/TestController.cpp:
3286         (WTR::TestController::setAllowStorageQuotaIncrease):
3287         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3288         * WebKitTestRunner/TestController.h:
3289         * WebKitTestRunner/TestInvocation.cpp:
3290         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3291         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3292         (WTR::TestController::cocoaResetStateToConsistentValues):
3293         (WTR::TestController::setAllowStorageQuotaIncrease):
3294         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3295         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3296         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3297
3298 2019-03-11  Xan Lopez  <xan@igalia.com>
3299
3300         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3301         https://bugs.webkit.org/show_bug.cgi?id=194147
3302
3303         Reviewed by Michael Saboff.
3304
3305         To make --32-bit work correctly on Linux/64bit we need to:
3306
3307         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3308         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3309         unfortunately CMake only allows us to do this during
3310         crosscompilation, which is overkill here.
3311         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3312         pkg-config detection module uses the x86 .pc files instead of the
3313         x86_64 ones.
3314         - Set the -m32 flags for the compiler.
3315
3316         * Scripts/webkitdirs.pm:
3317         (generateBuildSystemFromCMakeProject):
3318
3319 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3320
3321         Add MotionMark-1.1 plan file for run-benchmark script.
3322         https://bugs.webkit.org/show_bug.cgi?id=195481
3323
3324         Rubber-stamped by Darin Adler.
3325
3326         Run-benchmark script should support MontionMark-1.1.
3327
3328         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3329
3330 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3331
3332         [ews-app] Add support for submit-to-ews url
3333         https://bugs.webkit.org/show_bug.cgi?id=195477
3334
3335         Reviewed by Lucas Forschler.
3336
3337         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3338         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3339         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3340         * BuildSlaveSupport/ews-app/ews/urls.py:
3341         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3342
3343 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3344
3345         Unreviewed, rolling out r242688, r242643, r242624.
3346
3347         Caused multiple layout test failures and crashes on iOS and macOS.
3348
3349         Reverted changeset:
3350
3351         "requestAnimationFrame should execute before the next frame"
3352         https://bugs.webkit.org/show_bug.cgi?id=177484
3353         https://trac.webkit.org/changeset/242624/webkit
3354
3355         * Tracing/SystemTracePoints.plist:
3356
3357 2019-03-11  John Wilander  <wilander@apple.com>
3358
3359         Resource Load Statistics: Make it possible exclude localhost from classification
3360         https://bugs.webkit.org/show_bug.cgi?id=195474
3361         <rdar://problem/47520577>
3362
3363         Reviewed by Brent Fulgham.
3364
3365         This patch allows for localhost to be excluded from classification and
3366         treatment as a prevalent resource.
3367
3368         The WebKit Tools change adds a new function called
3369         testRunner.setStatisticsIsRunningTest() which can be used to control this
3370         behavior.
3371
3372         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3373         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3374         (WTR::TestRunner::setStatisticsIsRunningTest):
3375         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3376         * WebKitTestRunner/TestController.cpp:
3377         (WTR::TestController::setStatisticsIsRunningTest):
3378         * WebKitTestRunner/TestController.h:
3379         * WebKitTestRunner/TestInvocation.cpp:
3380         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3381
3382 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3383
3384         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3385         https://bugs.webkit.org/show_bug.cgi?id=195560
3386
3387         Reviewed by Lucas Forschler.
3388
3389         * BuildSlaveSupport/ews-build/master.cfg:
3390
3391 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3392
3393         Unreviewed, rolling out r242698.
3394
3395         API test crashes on bots.
3396
3397         Reverted changeset:
3398
3399         "Add a WKContentRuleList variant that uses copied memory
3400         instead of mmap'd shared memory for class A containerized
3401         apps"
3402         https://bugs.webkit.org/show_bug.cgi?id=195511
3403         https://trac.webkit.org/changeset/242698
3404
3405 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3406
3407         [WPE] Enable web process sandbox
3408         https://bugs.webkit.org/show_bug.cgi?id=195169
3409
3410         Reviewed by Daniel Bates.
3411
3412         * wpe/install-dependencies:
3413         * wpe/jhbuild.modules:
3414
3415 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3416
3417         [ews-app] Use port 17000 for worker communication
3418         https://bugs.webkit.org/show_bug.cgi?id=195558
3419
3420         Reviewed by Lucas Forschler.
3421
3422         * BuildSlaveSupport/ews-build/master.cfg:
3423
3424 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3425
3426         [ews-build] unit-tests fail when passwords.json is missing
3427         https://bugs.webkit.org/show_bug.cgi?id=195557
3428
3429         Reviewed by Lucas Forschler.
3430
3431         * BuildSlaveSupport/ews-build/loadConfig.py:
3432         (loadBuilderConfig):
3433         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3434         (ConfigDotJSONTest.test_configuration):
3435         * BuildSlaveSupport/ews-build/master.cfg:
3436
3437 2019-03-11  Truitt Savell  <tsavell@apple.com>
3438
3439         Unreviewed, rolling out r242702.
3440
3441         Broke High Sierra builders.
3442
3443         Reverted changeset:
3444
3445         "Add utility function to allow easy reverse range-based
3446         iteration of a container"
3447         https://bugs.webkit.org/show_bug.cgi?id=195542
3448         https://trac.webkit.org/changeset/242702
3449
3450 2019-03-11  Sam Weinig  <sam@webkit.org>
3451
3452         Add utility function to allow easy reverse range-based iteration of a container
3453         https://bugs.webkit.org/show_bug.cgi?id=195542
3454
3455         Reviewed by Antti Koivisto.
3456
3457         * TestWebKitAPI/CMakeLists.txt:
3458         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3459         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3460         (TestWebKitAPI::TEST):
3461         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3462
3463 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3464
3465         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3466         https://bugs.webkit.org/show_bug.cgi?id=195511
3467         <rdar://problem/44873269>
3468
3469         Reviewed by Darin Adler.
3470
3471         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3472         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3473         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3474         (TEST_F):
3475
3476 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3477
3478         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3479         https://bugs.webkit.org/show_bug.cgi?id=195499
3480
3481         Reviewed by Darin Adler.
3482
3483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3484         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3485         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3486         (-[WKWebView synchronouslyFocusTextInputContext:]):
3487         (applyStyle):
3488         (applyIframe):
3489         (TEST):
3490         Add some tests for this SPI.
3491
3492 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3493
3494         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3495         https://bugs.webkit.org/show_bug.cgi?id=181151
3496
3497         Reviewed by Don Olmstead.
3498
3499         * TestWebKitAPI/CMakeLists.txt:
3500         * TestWebKitAPI/PlatformWin.cmake:
3501         Enable TestWTF RunLoop tests in all platforms.
3502
3503         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3504         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3505         (TestWebKitAPI::DerivedOneShotTimer::fired):
3506         (TestWebKitAPI::TEST):
3507         Only a few platforms support nested RunLoop.
3508
3509         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3510         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3511
3512 2019-03-10  David Quesada  <david_quesada@apple.com>
3513
3514         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3515         https://bugs.webkit.org/show_bug.cgi?id=152480
3516
3517         Reviewed by Chris Dumez.
3518
3519         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3520         there are no additional references to the process pool besides the one held by
3521         the download, waits for the download to finish (in the sense that the
3522         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3523         measure, also check that the process pool has been deallocated at the end of the
3524         test. The test wouldn't be meaningful if the process pool were still alive.
3525
3526         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3527         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3528         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3529             The download will be canceled because the delegate does not implement the
3530             method to decide the download's destination, so this is where we know the
3531             DownloadProxyMap is done with the DownloadProxy.
3532         (TEST):
3533
3534 2019-03-08  Chris Dumez  <cdumez@apple.com>
3535
3536         Add support for Device Orientation / Motion permission API
3537         https://bugs.webkit.org/show_bug.cgi?id=195329
3538         <rdar://problem/47645367>
3539
3540         Reviewed by Geoffrey Garen.
3541
3542         Add test infrastructure to help test the Device Orientation / Motion permission API.
3543
3544         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3545         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3546         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3547         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3548         * WebKitTestRunner/TestController.cpp:
3549         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3550         (WTR::TestController::createWebViewWithOptions):
3551         (WTR::TestController::resetStateToConsistentValues):
3552         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3553         * WebKitTestRunner/TestController.h:
3554         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3555         * WebKitTestRunner/TestInvocation.cpp:
3556         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3557
3558 2019-03-08  Saam barati  <sbarati@apple.com>
3559
3560         Add a compare-results script to compare benchmark results
3561         https://bugs.webkit.org/show_bug.cgi?id=195486
3562         <rdar://problem/48723397>
3563
3564         Reviewed by Geoffrey Garen.
3565
3566         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3567         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3568         to extend it to learn about our other benchmarks.
3569
3570         * Scripts/compare-results: Added.
3571         (readJSONFile):
3572         (detectJetStream2):
3573         (JetStream2Results):
3574         (detectSpeedometer2):
3575         (Speedometer2Results):
3576         (detectPLT5):
3577         (PLT5Results):
3578         (detectBenchmark):
3579         (biggerIsBetter):
3580         (ttest):
3581         (getOptions):
3582         (main):
3583
3584 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3585
3586         Ensure old tab state is cleared between iterations of run-benchmark
3587         https://bugs.webkit.org/show_bug.cgi?id=195393
3588         <rdar://problem/46885583>
3589
3590         Reviewed by Dewei Zhu.
3591
3592         a) ensure the default to restore state is not set
3593         b) terminate Safari correctly
3594         c) Set the system default to ignore Persistent State in Safari
3595
3596         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3597         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3598         (OSXBrowserDriver.prepare_env): 
3599         (OSXBrowserDriver.restore_env):
3600         (OSXBrowserDriver.close_browsers):
3601         (OSXBrowserDriver._terminate_processes):
3602         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3603         (OSXChromeDriver):
3604         (OSXChromeCanaryDriver):
3605         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3606         (OSXFirefoxDriver):
3607         (OSXFirefoxNightlyDriver):
3608         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3609         (OSXSafariDriver):
3610         (OSXSafariDriver.prepare_env):
3611
3612 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3613
3614         [GTK] Several InputMethodFilter tests are failing
3615         https://bugs.webkit.org/show_bug.cgi?id=195408
3616
3617         Reviewed by Carlos Garcia Campos.
3618
3619         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3620         Regressed in r241751.
3621         Hexadecimal values of keycodes are expressed now in upper letters.
3622         Composited characters should be cast to UTF8 strings.
3623
3624         (TestWebKitAPI::TEST):
3625
3626 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3627
3628         [GTK] Make Tools/gtkdoc python3 compatible
3629         https://bugs.webkit.org/show_bug.cgi?id=195359
3630
3631         Reviewed by Carlos Garcia Campos.
3632
3633         * gtkdoc/generate-gtkdoc:
3634         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3635         work with Python 2 and 3.
3636         (get_gtkdoc_module_paths):
3637         The iteritems() was removed in Python 3, so let's use items() that's
3638         available in Python 2 and 3.
3639         (get_generator_for_config):
3640         * gtkdoc/gtkdoc.py:
3641         (GTKDoc._run_command):
3642         The sys.stdout.write() is expecting str in Python 3 and not bytes
3643         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3644         for passing the bytes there.
3645
3646 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3647
3648         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3649         https://bugs.webkit.org/show_bug.cgi?id=195346
3650         <rdar://problem/48667048>
3651
3652         Unreviewed build fix for clang-cl.
3653
3654         * DumpRenderTree/win/DumpRenderTree.cpp:
3655         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3656
3657 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3658
3659         requestAnimationFrame should execute before the next frame
3660         https://bugs.webkit.org/show_bug.cgi?id=177484
3661
3662         Reviewed by Simon Fraser.
3663
3664         Add trace points for the page RenderingUpdate.
3665
3666         * Tracing/SystemTracePoints.plist:
3667
3668 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3669
3670         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3671         https://bugs.webkit.org/show_bug.cgi?id=195353
3672         <rdar://problem/48626394>
3673
3674         Reviewed by Simon Fraser.
3675
3676         * WebKitTestRunner/ios/TestControllerIOS.mm:
3677         (WTR::TestController::platformResetPreferencesToConsistentValues):
3678
3679 2019-03-07  John Wilander  <wilander@apple.com>
3680
3681         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3682         https://bugs.webkit.org/show_bug.cgi?id=195383
3683         <rdar://problem/48570136>
3684
3685         Reviewed by Brent Fulgham.
3686
3687         This patch adds test infrastructure to purge only script-accessible cookies,
3688         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3689
3690         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3691         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3692         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3693         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3694         * WebKitTestRunner/TestController.cpp:
3695         (WTR::TestController::statisticsDeleteCookiesForHost):
3696         * WebKitTestRunner/TestController.h:
3697         * WebKitTestRunner/TestInvocation.cpp:
3698         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3699
3700 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3701
3702         Unreviewed, rolling out r242354.
3703         https://bugs.webkit.org/show_bug.cgi?id=195402
3704
3705         breaks layout tests in all configurations (Requested by
3706         zdobersek on #webkit).
3707
3708         Reverted changeset:
3709
3710         "[WPE] Enable web process sandbox"
3711         https://bugs.webkit.org/show_bug.cgi?id=195169
3712         https://trac.webkit.org/changeset/242354
3713
3714 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3715
3716         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3717         https://bugs.webkit.org/show_bug.cgi?id=195346
3718
3719         Reviewed by Fujii Hironori.
3720
3721         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3722         (TestWebKitAPI::TEST):
3723         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3724
3725         * DumpRenderTree/win/DumpRenderTree.cpp:
3726         (findFontFallback):
3727         (addFontFallbackIfPresent):
3728         (removeFontFallbackIfPresent):
3729         (main):
3730         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3731         (TestWebKitAPI::Util::moduleDirectory):
3732         (TestWebKitAPI::Util::createInjectedBundlePath):
3733         Use wchar helpers as needed.
3734
3735 2019-03-06  Rob Buis  <rbuis@igalia.com>
3736
3737         Consider supporting the `referrerpolicy` attribute.
3738         https://bugs.webkit.org/show_bug.cgi?id=179053
3739
3740         Reviewed by Darin Adler.
3741
3742         Add a runtime flag for referrerpolicy attribute.
3743
3744         * DumpRenderTree/mac/DumpRenderTree.mm:
3745         (enableExperimentalFeatures):
3746
3747 2019-03-05  Daniel Bates  <dabates@apple.com>
3748
3749         Update expected API test result following r242379
3750         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3751
3752         Update expected x-coordinate of selection rect now that the left padding of
3753         a textarea is sized in ems (so dependent on the font size) just like the left
3754         padding of a text field.
3755
3756         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3757         (TestWebKitAPI::TEST):
3758
3759 2019-03-05  David Quesada  <david_quesada@apple.com>
3760
3761         [WK2] It should be possible to follow links with 'download' attributes
3762         https://bugs.webkit.org/show_bug.cgi?id=195145
3763         rdar://problem/48462642
3764
3765         Reviewed by Alex Christensen.
3766
3767         Add a unit test to verify that activating links with 'download' attributes now
3768         navigates to the linked resource, rather than starts downloading it. Add another
3769         to verify that it is still possible to explicitly download the link via the
3770         'Download' navigation action policy.
3771
3772         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3773         (-[DownloadAttributeTestDelegate init]):
3774         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3775         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3776         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3777         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3778         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3779         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3780         (TEST):
3781         * WebKitTestRunner/TestController.cpp:
3782         (WTR::TestController::decidePolicyForNavigationAction):
3783         * WebKitTestRunner/TestController.h:
3784
3785 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3786
3787         [Curl] Implement Cookie Accept Policy.
3788         https://bugs.webkit.org/show_bug.cgi?id=191645
3789
3790         Reviewed by Fujii Hironori.
3791
3792         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3793         (TestWebKitAPI::Curl::TEST_F):
3794
3795 2019-03-05  Youenn Fablet  <youenn@apple.com>
3796
3797         Rename requestCacheStorageSpace to requestStorageSpace
3798         https://bugs.webkit.org/show_bug.cgi?id=195282
3799
3800         Reviewed by Chris Dumez.
3801
3802         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3803         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3804         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3805
3806 2019-03-05  Brady Eidson  <beidson@apple.com>
3807
3808         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3809         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3810
3811         Reviewed by Tim Horton.
3812
3813         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3814         different directory into that same WKWebView should work.
3815
3816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3817         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3818
3819 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3820
3821         Add WeakHashSet
3822         https://bugs.webkit.org/show_bug.cgi?id=195152
3823
3824         Reviewed by Antti Koivisto.
3825
3826         Added tests for WeakHashSet.
3827
3828         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3829         (TestWebKitAPI::Base::Base): Moved.
3830         (TestWebKitAPI::Derived::foo): Moved.
3831         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3832         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3833         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3834         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3835
3836 2019-03-04  Chris Dumez  <cdumez@apple.com>
3837
3838         Do not share WebProcesses between private and regular sessions
3839         https://bugs.webkit.org/show_bug.cgi?id=195189
3840         <rdar://problem/48421064>
3841
3842         Reviewed by Alex Christensen.
3843
3844         Add API test coverage.
3845
3846         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3847         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3848
3849 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3850
3851         [WPE] Enable web process sandbox
3852         https://bugs.webkit.org/show_bug.cgi?id=195169
3853
3854         Reviewed by Daniel Bates.
3855
3856         * wpe/install-dependencies:
3857         * wpe/jhbuild.modules:
3858
3859 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3860
3861         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3862         https://bugs.webkit.org/show_bug.cgi?id=195206
3863
3864         Reviewed by Žan Doberšek.
3865
3866         Add a new test case.
3867
3868         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3869         (testJSCClass):
3870
3871 2019-03-04  Charlie Turner  <cturner@igalia.com>
3872
3873         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3874         https://bugs.webkit.org/show_bug.cgi?id=194898
3875
3876         Reviewed by Žan Doberšek.
3877
3878         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3879         a GCC extension that permits arithmetic on void* pointer. Inline
3880         the macro until this issue is fixed upstream.
3881
3882 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3883
3884         Rid the world of WK_API_ENABLED
3885         https://bugs.webkit.org/show_bug.cgi?id=195263
3886
3887         Reviewed by Dan Bernstein.
3888
3889         List of changed files elided because it's useless.
3890
3891 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3892
3893         Unreviewed follow-up to r242292.
3894
3895         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3896
3897         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3898         (TestWebKitAPI::testStrip): Renamed from strip.
3899         (TestWebKitAPI::TEST):
3900
3901 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3902
3903         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3904
3905         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3906         and bug #194272 for details.
3907
3908         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3909
3910 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3911
3912         Remove some more unused 32-bit code
3913         https://bugs.webkit.org/show_bug.cgi?id=195255
3914
3915         Reviewed by Darin Adler.
3916
3917         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3918         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3919         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3920         (NPP_New):
3921         (NPP_HandleEvent):
3922         (handleEventCarbon): Deleted.
3923
3924 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3925
3926         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3927
3928         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3929         (TestWebKitAPI::TEST):
3930
3931 2019-03-01  Darin Adler  <darin@apple.com>
3932
3933         Finish removing String::format
3934         https://bugs.webkit.org/show_bug.cgi?id=194893
3935
3936         Reviewed by Daniel Bates.
3937 '
3938         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3939
3940 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3941
3942         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3943         https://bugs.webkit.org/show_bug.cgi?id=195229
3944         <rdar://problem/48520362>
3945
3946         Reviewed by Chris Dumez.
3947
3948         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3949         (TEST):
3950
3951 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3952
3953         Add a system trace scope for event region building
3954         https://bugs.webkit.org/show_bug.cgi?id=195226
3955
3956         Reviewed by Jon Lee.
3957
3958         This trace scope measures the time spend converting element rects into Region objects,
3959         which can be large on some pages.
3960
3961         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3962
3963         * Tracing/SystemTracePoints.plist:
3964
3965 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3966
3967         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3968         https://bugs.webkit.org/show_bug.cgi?id=194612
3969
3970         Reviewed by Alex Christensen.
3971
3972         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3973         Just test the new string-processing function and don't touch the actual environment.
3974         (Test cases are all as before, but based on operator== instead of strcmp.)
3975
3976 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3977
3978         [ews-app] Update primary keys for handling multiple Buildbot instances
3979         https://bugs.webkit.org/show_bug.cgi?id=195120
3980
3981         Reviewed by Stephanie Lewis.
3982
3983         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3984         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3985         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3986
3987         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3988         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3989         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3990         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3991         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3992         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3993
3994 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3995
3996         [WinCairo] Enable service worker
3997         https://bugs.webkit.org/show_bug.cgi?id=188318
3998
3999         Reviewed by Youenn Fablet.
4000
4001         * DumpRenderTree/DumpRenderTreePrefix.h:
4002         * TestWebKitAPI/PlatformWin.cmake:
4003         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4004         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4005         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4006
4007 2019-03-01  Justin Fan  <justin_fan@apple.com>
4008
4009         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4010         https://bugs.webkit.org/show_bug.cgi?id=195191
4011
4012         Rubber-stamped by Dean Jackson.
4013
4014         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4015
4016         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4017
4018 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4019
4020         Unreviewed, fix lldb webkitpy tests
4021         https://bugs.webkit.org/show_bug.cgi?id=194375
4022
4023         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4024
4025         * lldb/lldb_webkit.py:
4026         (WTFStringImplProvider.is_8bit):
4027
4028 2019-02-28  David Quesada  <david_quesada@apple.com>
4029
4030         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4031         https://bugs.webkit.org/show_bug.cgi?id=195121
4032         rdar://problem/48450302
4033
4034         Reviewed by Alex Christensen.
4035
4036         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4037         configurations where the 'download' attribute is absent, blank, or populated
4038         with a filename, and where the anchor element is same-origin or cross-origin
4039         (meaning the 'download' attribute shouldn't be honored).
4040
4041         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4042         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4043         (-[NavigationActionTestDelegate init]):
4044         (-[NavigationActionTestDelegate navigationAction]):
4045         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4046         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4047         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4048         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4049         (TEST):
4050
4051 2019-02-28  Antoine Quint  <graouts@apple.com>
4052
4053         Enable the Pointer Events runtime flag by default
4054         https://bugs.webkit.org/show_bug.cgi?id=195156
4055
4056         Reviewed by Dean Jackson.
4057
4058         * DumpRenderTree/mac/DumpRenderTree.mm:
4059         (enableExperimentalFeatures):
4060
4061 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4062
4063         Several PasteImage API tests are flaky
4064         https://bugs.webkit.org/show_bug.cgi?id=195160
4065
4066         Reviewed by Tim Horton.
4067
4068         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4069         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4070         listening for a "load" event after image load is already complete.
4071
4072         To address this, make these tests first register a "load" event handler, then run script to insert an image
4073         element into the document, and finally wait until the load event is observed before checking image size.
4074
4075         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4076
4077 2019-02-28  Chris Dumez  <cdumez@apple.com>
4078
4079         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4080         https://bugs.webkit.org/show_bug.cgi?id=195107
4081
4082         Reviewed by Alex Christensen.
4083
4084         Give some time for the zoom level to get restored.
4085
4086         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4087
4088 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4089
4090         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4091         https://bugs.webkit.org/show_bug.cgi?id=194958
4092
4093         Reviewed by Geoffrey Garen.
4094
4095         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4096         (TEST):
4097
4098 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4099
4100         [ews-app] Update method to save build to handle builder_display_name
4101         https://bugs.webkit.org/show_bug.cgi?id=195047
4102
4103         Reviewed by Dewei Zhu.
4104
4105         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4106         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4107
4108 2019-02-28  Justin Fan  <justin_fan@apple.com>
4109
4110         [Web GPU] Enable Web GPU only on 64-bit
4111         https://bugs.webkit.org/show_bug.cgi?id=195139
4112
4113         Because Metal is only supported on 64 bit apps.
4114
4115         Unreviewed build fix.
4116
4117         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4118
4119 2019-02-27  Youenn Fablet  <youenn@apple.com>
4120
4121         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4122         https://bugs.webkit.org/show_bug.cgi?id=194959
4123
4124         Reviewed by Chris Dumez.
4125
4126         Spin loop until getting the condition to remove flakiness.
4127
4128         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4129
4130 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4131
4132         [ews-build] Buildbot should include builder_display_name in the build events
4133         https://bugs.webkit.org/show_bug.cgi?id=195045
4134
4135         Reviewed by Dewei Zhu.
4136
4137         * BuildSlaveSupport/ews-build/events.py:
4138         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4139         buildername to builder_name to be consistent in naming style.
4140         (Events.buildFinished): Ditto.
4141
4142 2019-02-27  Chris Dumez  <cdumez@apple.com>
4143
4144         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4145         https://bugs.webkit.org/show_bug.cgi?id=194480
4146
4147         Reviewed by Brady Eidson.
4148
4149         Update existing API test to make it more likely to reproduce the issue.
4150
4151         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4152
4153 2019-02-27  Brady Eidson  <beidson@apple.com>
4154
4155         Universal links from Google search results pages don't open the app.
4156         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4157
4158         Reviewed by Geoffrey Garen.
4159
4160         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4161         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4162         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4163         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4164
4165 2019-02-27  Chris Dumez  <cdumez@apple.com>
4166
4167         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4168         https://bugs.webkit.org/show_bug.cgi?id=195102
4169
4170         Reviewed by Geoffrey Garen.
4171
4172         If the number of processes is not yet what we expect, wait a bit and check again to give
4173         processes some time to exit.
4174
4175         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4176
4177 2019-02-27  Chris Dumez  <cdumez@apple.com>
4178
4179         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4180         https://bugs.webkit.org/show_bug.cgi?id=194545
4181
4182         Reviewed by Brady Eidson.
4183
4184         Make sure the test navigates forward and then back only once. Previously, navigating
4185         back would trigger a navigation again in a timer.
4186
4187         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4188
4189 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4190
4191         High Sierra Debug JSC test queue should use faster hardware
4192         https://bugs.webkit.org/show_bug.cgi?id=194603
4193
4194         Rubber-stamped by Alexey Proskuryakov.
4195
4196         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4197
4198         * BuildSlaveSupport/build.webkit.org-config/config.json:
4199         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4200         (BubbleQueueServer):
4201         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4202         (WebKitBuildbot):
4203         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4204         * QueueStatusServer/config/queues.py:
4205         * Scripts/webkitpy/common/config/ews.json:
4206         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4207         (test_ews_name):
4208
4209 2019-02-27  John Wilander  <wilander@apple.com>
4210
4211         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4212         https://bugs.webkit.org/show_bug.cgi?id=195071
4213         <rdar://problem/48417690>
4214
4215         Reviewed by Alex Christensen and Brent Fulgham.
4216
4217         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4218         (TestWebKitAPI::createURL):
4219             Convenience function.
4220         (TestWebKitAPI::TEST):
4221             WebCore::AdClickAttribution now takes a URL when creating Source and
4222             Destination.
4223         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4224         (TestWebKitAPI::TEST):
4225             WebCore::AdClickAttribution now takes a URL when creating Source and
4226             Destination.
4227
4228 2019-02-27  Antoine Quint  <graouts@apple.com>
4229
4230         Support Pointer Events on macOS
4231         https://bugs.webkit.org/show_bug.cgi?id=195008
4232         <rdar://problem/47454419>
4233
4234         Reviewed by Dean Jackson.
4235
4236         * DumpRenderTree/mac/DumpRenderTree.mm:
4237         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4238         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4239
4240 2019-02-26  Mark Lam  <mark.lam@apple.com>
4241
4242         Remove remaining poisoning code.
4243         https://bugs.webkit.org/show_bug.cgi?id=194138
4244
4245         Reviewed by Saam Barati.
4246
4247         * TestWebKitAPI/CMakeLists.txt:
4248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4249         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4250         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4251         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4252         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4253         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4254         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4255
4256 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4257
4258         Move ephemeral local storage from WebProcess to UIProcess
4259         https://bugs.webkit.org/show_bug.cgi?id=195074
4260         <rdar://problem/47937975>
4261
4262         Reviewed by Geoff Garen.
4263
4264         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4265
4266 2019-02-20  Jer Noble  <jer.noble@apple.com>
4267
4268         [Cocoa] Media elements will restart network buffering just before suspending
4269         https://bugs.webkit.org/show_bug.cgi?id=193691
4270
4271         Reviewed by Eric Carlson.
4272
4273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4274         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4275         (TEST):
4276
4277 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4278
4279         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4280         https://bugs.webkit.org/show_bug.cgi?id=191652
4281
4282         Reviewed by Alex Christensen.
4283
4284         Fix WinCairo MiniBrowser behavior of authentication dialog.
4285
4286         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4287         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4288
4289 2019-02-26  Youenn Fablet  <youenn@apple.com>
4290
4291         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4292         https://bugs.webkit.org/show_bug.cgi?id=195028
4293         <rdar://problem/48243733>
4294
4295         Reviewed by Eric Carlson.
4296
4297         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4298
4299 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4300
4301         [WPE] Add API for webview background color configuration
4302         https://bugs.webkit.org/show_bug.cgi?id=192305
4303
4304         Reviewed by Michael Catanzaro.
4305
4306         * MiniBrowser/wpe/main.cpp:
4307         (main): Add a new option to configure the webview background
4308         color. Example: --bg-color=transparent.
4309         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4310         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4311         (beforeAll): Ditto.
4312
4313 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4314
4315         scalableNativeWebpageParameters() is not preserved on new page navigation.
4316         https://bugs.webkit.org/show_bug.cgi?id=194892
4317         <rdar://problem/47538280>
4318
4319         Reviewed by Wenson Hsieh.
4320         
4321         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4322
4323         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4324         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4325         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4326         (WTR::UIScriptController::allowsViewportShrinkToFit):
4327         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4328         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4329         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4330         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4331         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4332         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4333
4334 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4335
4336         [ews-app] Add model for handling multiple Buildbot instances
4337         https://bugs.webkit.org/show_bug.cgi?id=194863
4338
4339         Reviewed by Stephanie Lewis.
4340
4341         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4342
4343 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4344
4345         [ews-app] Remove BuilderMapping table
4346         https://bugs.webkit.org/show_bug.cgi?id=194961
4347
4348         Reviewed by Stephanie Lewis.
4349
4350         Store builder name directly in build table, instead of having a separate
4351         table for it.
4352
4353         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4354         * BuildSlaveSupport/ews-app/ews/models/build.py:
4355         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4356         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4357
4358 2019-02-25  John Wilander  <wilander@apple.com>
4359
4360         Introduce and adopt new class RegistrableDomain for eTLD+1
4361         https://bugs.webkit.org/show_bug.cgi?id=194791
4362         <rdar://problem/48179240>
4363
4364         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4365
4366         This patch adds an API test and replaces two instances of
4367         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4368
4369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4370         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4371