Unreviewed, add myself to the committers list.
[WebKit-https.git] / Tools / ChangeLog
1 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
2
3         Unreviewed, add myself to the committers list.
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
8
9         [GTK] jquery.min.js violates DFSG
10         https://bugs.webkit.org/show_bug.cgi?id=152428
11
12         Reviewed by Joseph Pecoraro.
13
14         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
15         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
16
17         * gtk/manifest.txt.in:
18
19 2015-12-19  Dan Bernstein  <mitz@apple.com>
20
21         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
22         https://bugs.webkit.org/show_bug.cgi?id=152462
23
24         Reviewed by Alexey Proskuryakov.
25
26         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
27           OS X 10.9:
28
29         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
30         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
31         * MiniBrowser/Configurations/DebugRelease.xcconfig:
32         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
33         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
34
35         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
36           never getting compiled:
37
38         * DumpRenderTree/mac/TextInputController.m:
39         * MiniBrowser/mac/BrowserWindowController.m:
40         * TestWebKitAPI/Tests/mac/AttributedString.mm:
41         * WebKitTestRunner/mac/EventSenderProxy.mm:
42
43 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
44
45         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
46
47         This is to make it easy to CC it on Bugzilla.
48
49         * Scripts/webkitpy/common/config/contributors.json:
50
51 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
52
53         Pasteboard get messed up after running kill-old-processes
54         https://bugs.webkit.org/show_bug.cgi?id=152426
55
56         Reviewed by Alexey Proskuryakov.
57
58         * BuildSlaveSupport/kill-old-processes:
59         (main): Do not kill pasteboard anymore.
60
61 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
62
63         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
64         https://bugs.webkit.org/show_bug.cgi?id=152157
65         <rdar://problem/23851817>
66
67         Reviewed by Alexey Proskuryakov.
68
69         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
70         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
71         * Scripts/webkitpy/layout_tests/controllers/manager.py:
72         (Manager._get_test_inputs): Common method to calculate test_inputs.
73         (Manager._update_worker_count): Calculate and update required number of workers.
74
75 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
76
77         run-webkit-tests fails to delete Simulator device during cleanup
78         https://bugs.webkit.org/show_bug.cgi?id=152363
79
80         Reviewed by Alexey Proskuryakov.
81
82         * Scripts/webkitpy/xcode/simulator.py:
83         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
84
85 2015-12-16  Tim Horton  <timothy_horton@apple.com>
86
87         [mac-wk2] fast/events force click tests crashing
88         https://bugs.webkit.org/show_bug.cgi?id=152339
89
90         Reviewed by Beth Dakin.
91
92         * WebKitTestRunner/mac/EventSenderProxy.mm:
93         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
94         Set the NSEvent's _type member in addition to overriding -type,
95         because there are assertions in touch event handling code that depend on it.
96
97 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
98
99         Enforce temporarily bots to sync WebKit and WPT testharness.js
100         https://bugs.webkit.org/show_bug.cgi?id=152334
101
102         Reviewed by Darin Adler.
103
104         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
105         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
106
107 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
108
109         [Fetch API] Add fetch API compile time flag
110         https://bugs.webkit.org/show_bug.cgi?id=152254
111
112         Reviewed by Darin Adler.
113
114         * Scripts/webkitperl/FeatureList.pm:
115
116 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
117
118         Unreviewed.
119
120         Added files that have impact in building Streams API to the watchlist.
121
122         * Scripts/webkitpy/common/config/watchlist:
123
124 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
125
126         Unreviewed.
127
128         Added imported tests to Streams API watchlist.
129
130         * Scripts/webkitpy/common/config/watchlist:
131
132 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
133
134         Remove default copy of wpt testharness.js when launching wpt server
135         https://bugs.webkit.org/show_bug.cgi?id=152298
136
137         Reviewed by Darin Adler.
138
139         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
140         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
141
142 2015-12-15  David Kilzer  <ddkilzer@apple.com>
143
144         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
145         <http://webkit.org/b/152314>
146
147         Reviewed by Daniel Bates.
148
149         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
150         code path to exit immediately when calling main().
151         Unfortunately, DumpRenderTreeMain.mm was used for both
152         DumpRenderTree command-line binary and DumpRenderTree.app, which
153         meant that the app would exit immediately with no error code
154         when run!
155
156         The workaround is to introduce a separate source file called
157         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
158         already does.
159
160         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
161         DumpRenderTreeAppMain.mm to the project.  Make it the only
162         compiled source for the DumpRenderTree.app target.
163         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
164         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
165         case someone tries mistakenly to use the app.
166         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
167         Link to JavaScriptCore.framework on iOS for the assert.
168         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
169         Link to JavaScriptCore.framework on OS X for the assert.  Remove
170         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
171         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
172         (main): Add assert for iOS so that a crash occurs if someone
173         tries to run the wrong command.
174
175 2015-12-14  Tim Horton  <timothy_horton@apple.com>
176
177         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
178         https://bugs.webkit.org/show_bug.cgi?id=152266
179         <rdar://problem/22092676>
180
181         Reviewed by Simon Fraser.
182
183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
184         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
185         Add a test that crashed before this change, and doesn't crash after.
186
187 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
188
189         AX: iOS: Text field variations do not have the correct traits
190         https://bugs.webkit.org/show_bug.cgi?id=152237
191
192         Reviewed by Mario Sanchez Prada.
193
194         Add iOS calls for determing if an object is a search field or a text area.
195
196         * DumpRenderTree/AccessibilityUIElement.cpp:
197         (getIsSearchFieldCallback):
198         (getIsTextAreaCallback):
199         (stringForSelectionCallback):
200         (AccessibilityUIElement::getJSClass):
201         * DumpRenderTree/AccessibilityUIElement.h:
202         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
203         (AccessibilityUIElement::identifier):
204         (AccessibilityUIElement::isTextArea):
205         (AccessibilityUIElement::isSearchField):
206         (AccessibilityUIElement::traits):
207         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
208         (WTR::AccessibilityUIElement::scrollPageRight):
209         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
210         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
211         (WTR::AccessibilityUIElement::isSearchField):
212         (WTR::AccessibilityUIElement::isTextArea):
213         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
214         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
215         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
216         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
217         (WTR::AccessibilityUIElement::isTextArea):
218         (WTR::AccessibilityUIElement::isSearchField):
219         (WTR::AccessibilityUIElement::rowCount):
220
221 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
222
223         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
224         https://bugs.webkit.org/show_bug.cgi?id=152252
225
226         Reviewed by Sergio Villar Senin.
227
228         * gtk/install-dependencies: Add libtool-bin to the list of packages required
229         for building the JHBuild on Debian systems.
230
231 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
232
233         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
234         https://bugs.webkit.org/show_bug.cgi?id=152156
235
236         Reviewed by Dan Bernstein.
237
238         Our frameworks should appropriately prefix all ObjC classes,
239         not just external symbols.
240
241         * Scripts/check-for-inappropriate-objc-class-names:
242         Remove the -g switch to check all ObjC class names.
243
244 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
245
246         [MediaStream] Expose media capture devices persistent permissions to WebCore
247         https://bugs.webkit.org/show_bug.cgi?id=152087
248
249         Add support for the new user media permission checker page UI client method.
250
251         Reviewed by Chris Dumez.
252
253         * WebKitTestRunner/TestController.cpp:
254         (WTR::decidePolicyForUserMediaPermissionRequest):
255         (WTR::checkUserMediaPermissionForOrigin):
256         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
257         (WTR::TestController::createWebViewWithOptions): Ditto.
258         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
259         (WTR::originUserVisibleName): New, create a string for the origin.
260         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
261           according to the state of the origin permission map.
262         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
263           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
264         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
265           origin permission map.
266         * WebKitTestRunner/TestController.h:
267
268 2015-12-10  Alex Christensen  <achristensen@webkit.org>
269
270         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
271         https://bugs.webkit.org/show_bug.cgi?id=152022
272         rdar://problem/23763584
273
274         Reviewed by Darin Adler.
275
276         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
277         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
278         (WTR::InjectedBundlePage::willSendRequestForFrame):
279         * WebKitTestRunner/InjectedBundle/TestRunner.h:
280         (WTR::TestRunner::setWillSendRequestReturnsNull):
281         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
282         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
283         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
284         (WTR::TestRunner::willSendRequestHTTPBody):
285         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
286
287 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
288
289         Remove additional simulator checks before running layout-tests
290         https://bugs.webkit.org/show_bug.cgi?id=152146
291
292         Reviewed by Darin Adler.
293
294         * Scripts/webkitpy/port/ios.py:
295         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
296         * Scripts/webkitpy/xcode/simulator.py:
297         (Simulator._boot_and_shutdown_simulator_device): Deleted.
298         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
299
300 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
301
302         Run atleast one simulator even if max process limit is low
303         https://bugs.webkit.org/show_bug.cgi?id=152081
304         <rdar://problem/23819694>
305
306         Reviewed by Alexey Proskuryakov.
307
308 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
309
310         [GTK] Crash in WebProcess when loading large content with custom URI schemes
311         https://bugs.webkit.org/show_bug.cgi?id=144262
312
313         Reviewed by Carlos Garcia Campos.
314
315         Added new unit test to check the additional scenarios we now
316         handle for custom URI schemes.
317
318         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
319         (generateHTMLContent): New helper function to generate big enough content.
320         (testWebContextURIScheme): New unit test.
321
322 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
323
324         [EFL] Fix unhandled web process message when launching MiniBrowser
325         https://bugs.webkit.org/show_bug.cgi?id=152048
326
327         Reviewed by Gyuyoung Kim.
328
329         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
330         (TestWebKitAPI::TEST):
331
332 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
333
334         [GTK] Add API to handle beforeunload events
335         https://bugs.webkit.org/show_bug.cgi?id=139090
336
337         Reviewed by Gustavo Noronha Silva.
338
339         * MiniBrowser/gtk/BrowserWindow.c:
340         (browserWindowConstructed):
341         (browserWindowDeleteEvent):
342         (browser_window_class_init):
343         Handle delete-event to prevent the window from being closed when
344         the page has beforeunload handlers. Use
345         webkit_web_view_try_close() when the window is requested to be
346         closed.
347         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
348         (testWebViewJavaScriptDialogs):
349         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
350         script dialog type.
351
352 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
353
354         Refactored initialization code in LoadTrackingTest.
355
356         Rubber-stamped by Carlos Garcia Campos.
357
358         Small refactoring to make sure that the state of a LoadTrackingTest
359         gets properly reset before loading new web content.
360
361         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
362         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
363         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
364         functions and reset the remaining local variables.
365         (LoadTrackingTest::loadURI): Call reset();
366         (LoadTrackingTest::loadHtml): Ditto.
367         (LoadTrackingTest::loadPlainText): Ditto.
368         (LoadTrackingTest::loadBytes): Ditto.
369         (LoadTrackingTest::loadRequest): Ditto.
370         (LoadTrackingTest::reload): Ditto.
371         (LoadTrackingTest::goBack): Ditto.
372         (LoadTrackingTest::goForward): Ditto.
373
374 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
375
376         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
377         https://bugs.webkit.org/show_bug.cgi?id=151942
378
379         Reviewed by Darin Adler.
380
381         * MiniBrowser/efl/main.c:
382         (window_create): Enable offline web application cache feature on MiniBrowser.
383         (elm_main):
384
385 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
386
387         https://bugs.webkit.org/show_bug.cgi?id=151243
388         <rdar://problem/22955197>
389
390         Reviewed by Alexey Proskuryakov.
391
392         * LayoutTestRelay/LayoutTestRelay/main.m:
393         (getTestingSimDevice): Use separate testing device for each worker.
394         * Scripts/webkitpy/layout_tests/controllers/manager.py:
395         (Manager.run): Perform cleanup even if setup fails.
396         * Scripts/webkitpy/port/ios.py:
397         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
398         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
399         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
400         (IOSSimulatorPort._quit_ios_simulator): Same
401         (IOSSimulatorPort.clean_up_test_run): Same
402         (IOSSimulatorPort.check_sys_deps): Same
403         (IOSSimulatorPort.testing_device): Same
404         (IOSSimulatorPort.reset_preferences): Same
405         (IOSSimulatorPort.get_simulator_path): Return simulator path.
406         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
407         * Scripts/webkitpy/xcode/simulator.py:
408         (Device.delete): Delete the simulator device.
409         (Simulator.delete_device): Same
410         (Simulator.wait_until_device_is_booted): Wait for device booting.
411
412 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
413
414         [EFL] Add API to provide preferences before creating ewk_view
415         https://bugs.webkit.org/show_bug.cgi?id=151587
416
417         Reviewed by Gyuyoung Kim.
418
419         * MiniBrowser/efl/main.c:
420         (on_key_down):
421         (quit):
422         (window_create):
423         Moved settings related code to configuration() not to update settings
424         whenever ewk_view is created.
425         (configuration):
426         (elm_main):
427
428 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
429
430         Unreviewed. Fix GTK+ API tests after r193639.
431
432         The new jhbuild version needs some more variables ot be present in
433         the builtin dict, even if they are set to None.
434
435         * jhbuild/jhbuildutils.py:
436         (enter_jhbuild_environment_if_available):
437
438 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
439
440         [GTK] Notify WebCore when notification is clicked
441         https://bugs.webkit.org/show_bug.cgi?id=151951
442
443         Reviewed by Carlos Garcia Campos.
444
445         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
446         (testWebViewNotification): test the new API.
447
448 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
449
450         'jhbuild build' should fail immediately when building any module fails
451         https://bugs.webkit.org/show_bug.cgi?id=145697
452
453         Reviewed by Carlos Garcia Campos.
454
455         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
456         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
457         Everything is placed under lib instead of lib64 now.
458         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
459         --exit-on-error when running 'jhbuild build'.
460         * jhbuild/jhbuildrc_common.py:
461         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
462         jhbuild should be able to handle these for us without breaking things....
463
464 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
465
466         Add support to import w3c tests from a repository with a different root that the main repo dir
467         https://bugs.webkit.org/show_bug.cgi?id=151751
468
469         Reviewed by Ryosuke Niwa and Youenn Fablet.
470
471         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
472         in a different directory than the repository root.
473
474         This patch introduces a new parameter tests_directory that we will use as root directory to search for
475         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
476         requires having the copy_path lists including tuples of origin and destination directories.
477
478         * Scripts/webkitpy/w3c/test_downloader.py:
479         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
480         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
481         * Scripts/webkitpy/w3c/test_importer_unittest.py:
482         (TestImporterTest.test_tests_directory): Test.
483
484 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
485
486         Mock TestRepositories in W3C importer tests
487         https://bugs.webkit.org/show_bug.cgi?id=151938
488
489         Reviewed by Youenn Fablet.
490
491         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
492         is because the test repository method reading the file was using the filesystem directly instead of taking the
493         host one. This patch changes that.
494
495         * Scripts/webkitpy/w3c/test_downloader.py:
496         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
497         default one.
498         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
499         * Scripts/webkitpy/w3c/test_importer_unittest.py:
500         (TestImporterTest.test_harnesslinks_conversion):
501         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
502
503 2015-12-07  David Kilzer  <ddkilzer@apple.com>
504
505         TestNetscapePlugIn: Address review comment on 193607
506         <http://webkit.org/b/151881>
507
508         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
509         (testSetStatus): Initializing std::unique_ptr<char[]> with
510         nullptr is redundant.
511
512 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
513
514         [GTK] Add webkit_uri_request_get_http_method
515         https://bugs.webkit.org/show_bug.cgi?id=151601
516
517         Reviewed by Martin Robinson.
518
519         Add test case to check HTTP method of WebKitURIRequest.
520
521         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
522         (testURIRequestHTTPMethod):
523         (serverCallback):
524         (beforeAll):
525         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
526         (sendRequestCallback):
527
528 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
529
530         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
531         https://bugs.webkit.org/show_bug.cgi?id=79918
532
533         Reviewed by Gustavo Noronha Silva.
534
535         Add unit tests to check the different console messages.
536
537         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
538         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
539         (ConsoleMessageTest::ConsoleMessage::operator==):
540         (ConsoleMessageTest::consoleMessageReceivedCallback):
541         (ConsoleMessageTest::ConsoleMessageTest):
542         (ConsoleMessageTest::~ConsoleMessageTest):
543         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
544         (testWebKitConsoleMessageConsoleAPI):
545         (testWebKitConsoleMessageJavaScriptException):
546         (testWebKitConsoleMessageNetworkError):
547         (testWebKitConsoleMessageSecurityError):
548         (beforeAll):
549         (afterAll):
550         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
551         (consoleMessageSentCallback):
552         (pageCreatedCallback):
553
554 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
555
556         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
557         https://bugs.webkit.org/show_bug.cgi?id=151934
558
559         Reviewed by Csaba Osztrogonác.
560
561         * MiniBrowser/efl/main.c:
562         (on_window_deletion): Revert the changes of r192767.
563
564 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
565
566         [GTK] update-webkitgtk-libs cannot build mesa
567         https://bugs.webkit.org/show_bug.cgi?id=151535
568
569         Reviewed by Martin Robinson.
570
571         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
572         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
573         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
574         does not have a stable API and we cannot expect mesa to be buildable unless we control the
575         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
576         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
577
578         * gtk/jhbuild.modules:
579
580 2015-12-07  Philippe Normand  <pnormand@igalia.com>
581
582         [GTK][Mac] libWebExtensionTest link error
583         https://bugs.webkit.org/show_bug.cgi?id=150802
584
585         Reviewed by Carlos Garcia Campos.
586
587         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
588
589 2015-12-06  David Kilzer  <ddkilzer@apple.com>
590
591         TestNetscapePlugIn: Fix leaks found by static analyzer
592         <http://webkit.org/b/151881>
593
594         Reviewed by Darin Adler.
595
596         Fixes the following leaks found by the static analyzer:
597             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
598                     return false;
599                            ^~~~~
600             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
601                     return false;
602                            ^~~~~
603             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
604                     return false;
605                            ^~~~~
606
607         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
608         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
609         early return if allocation fails.
610         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
611         Make sure to call fclose() on filehandle, even for an early
612         return.
613         (testSetStatus): Switch to using std::unique_ptr<char[]>.
614
615 2015-12-05  David Kilzer  <ddkilzer@apple.com>
616
617         prepare-ChangeLog: Fix some warning messages when using svn
618         <http://webkit.org/b/151914>
619
620         Reviewed by Daniel Bates.
621
622         * Scripts/prepare-ChangeLog:
623         (generateFunctionLists): Simplify logic so that we never call
624         normalizePath() with an undefined value.
625         (attributeCommand): Quote $subPath for the shell so that we
626         don't try to run "svn propget" on invalid paths.
627
628 2015-12-04  David Kilzer  <ddkilzer@apple.com>
629
630         TestNetscapePlugIn: Fix remaining static analyzer warnings
631         <http://webkit.org/b/151888>
632
633         Reviewed by Alexey Proskuryakov.
634
635         Fixes the following static analyzer warnings:
636             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
637                     CRASH();
638                     ^~~~~~~
639             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
640                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
641                 ^~~~~~~~~~~~~~~~
642             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
643                 return obj->pluginTest->NPP_SetWindow(window);
644                        ^~~~~~~~~~~~~~~
645             2 warnings generated.
646
647         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
648         (CRASH): Use __builtin_trap() for gcc/clang.
649         (NPP_SetWindow): Add early return if obj is nullptr.
650
651 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
652
653         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
654         https://bugs.webkit.org/show_bug.cgi?id=151797
655
656         Reviewed by Martin Robinson.
657
658         Since we switched to use the network process to run the unit tests
659         the test /webkit2/WebKitWebResource/get-data sometimes fails and
660         sometimes passes. We are now also getting the notification for the
661         css image. Since we wait for 3 resources, sometimes the css image
662         is loaded before and then checkResourceData is called for it, but
663         not handled. When the css image is the last one loaded the test
664         passes. So, we just need to wait for the 4 resources.
665
666         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
667         (testWebResourceGetData):
668
669 2015-12-03  David Kilzer  <ddkilzer@apple.com>
670
671         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
672         <http://webkit.org/b/151845>
673
674         Reviewed by Simon Fraser.
675
676         Fixes the following static analyzer warning:
677             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
678                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
679                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
680
681         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
682         (createBitmapContext): Free 'buffer' after using it in logging
683         to fix the use-after-free.  Assign a value of nullptr to buffer
684         so we don't return with it set to a freed address.
685
686 2015-12-03  Jer Noble  <jer.noble@apple.com>
687
688         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
689         https://bugs.webkit.org/show_bug.cgi?id=151830
690
691         Reviewed by Anders Carlsson.
692
693         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
694
695         * DumpRenderTree/mac/DumpRenderTree.mm:
696         (resetWebPreferencesToConsistentValues):
697         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
698         (WTR::initializeWebViewConfiguration):
699
700 2015-12-03  Anders Carlsson  <andersca@apple.com>
701
702         Remove Objective-C GC support
703         https://bugs.webkit.org/show_bug.cgi?id=151819
704         rdar://problem/23746991
705
706         Reviewed by Dan Bernstein.
707
708         * asan/asan.xcconfig:
709
710 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
711
712         Allow nil for unspecified benchmark pathes
713         https://bugs.webkit.org/show_bug.cgi?id=151784
714
715         Reviewed by Filip Pizlo.
716
717         `Pathname.new(nil)` will raise an error.
718         Only generate Pathname if the benchmark path is specified.
719
720         * Scripts/run-jsc-benchmarks:
721
722 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
723
724         [Win] Run non-http tests without Cygwin
725         https://bugs.webkit.org/show_bug.cgi?id=151721
726
727         Reviewed by Andy Estes.
728
729         Support native 32-bit and 64-bit Python (and Perl) builds
730         for running tests:
731
732         1. Use "startswith('win')", rather than "== 'win32'" to support
733         various Windows build types.
734         2. Supply full path for some native Windows utilities, since the
735         path environment does not always have the specified, and they are
736         guaranteed to exist in those specific locations.
737         3. Make sure native Windows Python test runs pass proper environment
738         variables to run programs.
739         4. Append 'exe' suffix when running Windows executables.
740         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
741         command doesn't exist.
742         
743         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
744         the current Perl executable, rather than requiring a new path search.
745         * Scripts/webkitpy/common/find_files_unittest.py:
746         (TestWinNormalize.test_win): Use startswith('win').
747         * Scripts/webkitpy/common/prettypatch_unittest.py:
748         (test_pretty_diff_encodings): Ditto.
749         * Scripts/webkitpy/common/system/executive.py:
750         (Executive._should_close_fds): Ditto.
751         (Executive.shell_command_for_script): Use startswith('win').
752         (Executive.kill_process): Use full path to killall executable.
753         (Executive.check_running_pid): Use startswith('win').
754         (Executive.running_pids): Ditto.
755         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
756         running under native Windows Python.
757         (Executive._child_process_encoding): Use startswith('win').
758         (Executive._should_encode_child_process_arguments): Ditto.
759         (Executive.popen): Recognize proper script engine on Windows, since it
760         does not support the shebang syntax.
761         (Executive.run_in_parallel): Use startswith('win').
762         * Scripts/webkitpy/common/system/executive_unittest.py:
763         (never_ending_command): Ditto.
764         (ExecutiveTest.test_run_command_with_unicode): Ditto.
765         (ExecutiveTest.serial_test_kill_process): Ditto.
766         (ExecutiveTest.serial_test_kill_all): Ditto.
767         (ExecutiveTest.serial_test_check_running_pid): Ditto.
768         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
769         (main): Ditto.
770         * Scripts/webkitpy/common/system/file_lock.py:
771         (FileLock._create_lock): Ditto.
772         (FileLock._remove_lock): Ditto.
773         * Scripts/webkitpy/common/system/filesystem_unittest.py:
774         (RealFileSystemTest.test_chdir): Ditto.
775         (RealFileSystemTest.test_chdir__notexists): Ditto.
776         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
777         * Scripts/webkitpy/common/system/path_unittest.py:
778         (AbspathTest.test_abspath_to_uri_win): Ditto.
779         * Scripts/webkitpy/common/system/platforminfo.py:
780         (PlatformInfo._determine_os_name): Ditto.
781         * Scripts/webkitpy/common/system/user.py: Ditto.
782         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
783         (ManagerTest.integration_test_needs_servers): Ditto.
784         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
785         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
786         driver letters.
787         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
788         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
789         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
790         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
791         (HttpServerBase._check_that_all_ports_are_available): Ditto.
792         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
793         (TestHttpServer.test_start_cmd): Ditto.
794         * Scripts/webkitpy/port/base.py:
795         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
796         and 'SYSTEMROOT' in environment passed to test runners.
797         (Port._apache_config_file_name_for_platform): Use startswith('win').
798         (Port._build_path): Ditto.
799         (Port._path_to_driver): Include 'exe' suffix when running under native
800         Windows.
801         * Scripts/webkitpy/port/driver.py:
802         (Driver._setup_environ_for_driver): Explicitly make some environment
803         variables strings.
804         * Scripts/webkitpy/port/server_process.py:
805         (ServerProcess.__init__): Use startswith('win').
806         * Scripts/webkitpy/port/win.py:
807         (WinPort): Use the win32 registry utilities on Windows, and appropriate
808         registry key formats.
809         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
810         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
811         and regtool on Cygwin.
812         (WinPort.write_registry_value): Ditto.
813         (WinPort.setup_crash_log_saving): Ditto.
814         (WinPort.restore_crash_log_saving): Ditto.
815         (WinPort.prevent_error_dialogs): Ditto.
816         (WinPort.allow_error_dialogs): Ditto.
817         (WinPort.find_system_pid): Revise to use Windows management
818         infrastructure on native Windows, continue using 'ps' on Cygwin.
819         (WinPort.read_registry_string): Deleted.
820         (WinPort.write_registry_string): Deleted.
821         * Scripts/webkitpy/test/main.py:
822         (main): Use startswith('win').
823         (Tester._parse_args): Ditto.
824
825 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
826
827         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
828         https://bugs.webkit.org/show_bug.cgi?id=150792
829
830         Reviewed by Saam Barati.
831
832         * Scripts/webkitperl/FeatureList.pm:
833
834 2015-12-01  Commit Queue  <commit-queue@webkit.org>
835
836         Unreviewed, rolling out r192914.
837         https://bugs.webkit.org/show_bug.cgi?id=151734
838
839         JSC tests for this change are failing on 32 and 64-bit bots
840         (Requested by ryanhaddad on #webkit).
841
842         Reverted changeset:
843
844         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
845         enable this feature"
846         https://bugs.webkit.org/show_bug.cgi?id=150792
847         http://trac.webkit.org/changeset/192914
848
849 2015-12-01  David Kilzer  <ddkilzer@apple.com>
850
851         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
852         <http://webkit.org/b/151726>
853
854         Reviewed by Simon Fraser.
855
856         * WebKitTestRunner/mac/EventSenderProxy.mm:
857         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
858         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
859
860 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
861
862         Give String and AtomicString an existingHash() function
863         https://bugs.webkit.org/show_bug.cgi?id=151717
864
865         Reviewed by Andreas Kling.
866
867         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
868         (TestWebKitAPI::TEST):
869         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
870         (TestWebKitAPI::TEST):
871
872 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
873
874         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
875         https://bugs.webkit.org/show_bug.cgi?id=150792
876
877         Reviewed by Saam Barati.
878
879         * Scripts/webkitperl/FeatureList.pm:
880
881 2015-12-01  Sam Weinig  <sam@webkit.org>
882
883         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
884         <rdar://problem/23320863>
885         https://bugs.webkit.org/show_bug.cgi?id=151708
886
887         Reviewed by Anders Carlsson.
888
889         * WebKitTestRunner/TestController.cpp:
890         (WTR::TestController::createOtherPage):
891         (WTR::TestController::createWebViewWithOptions):
892         Update for new WKPageUIClient.
893
894 2015-12-01  Anders Carlsson  <andersca@apple.com>
895
896         Remove WebKit2.framework
897         https://bugs.webkit.org/show_bug.cgi?id=151715
898
899         Reviewed by Dan Bernstein.
900
901         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
902         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
903         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
904         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
905         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
906         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
907         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
908
909 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
910
911         Unreviewed common typo fix "occurance" => "occurrence".
912
913         * Scripts/webkitpy/tool/commands/queries.py:
914         (FindFlakyTests._print_statistics):
915
916 2015-11-30  Alex Christensen  <achristensen@webkit.org>
917
918         Make ProcessModel always MultipleSecondaryProcesses
919         https://bugs.webkit.org/show_bug.cgi?id=151662
920
921         Reviewed by Antti Koivisto.
922
923         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
924         (TestWebKitAPI::TEST):
925         * WebKitTestRunner/TestController.cpp:
926         (WTR::TestController::generatePageConfiguration):
927
928 2015-11-30  Alex Christensen  <achristensen@webkit.org>
929
930         Make usesNetworkProcess always true
931         https://bugs.webkit.org/show_bug.cgi?id=151580
932
933         Reviewed by Darin Adler.
934
935         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
936         (TestWebKitAPI::TEST):
937         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
938         (TestWebKitAPI::TEST):
939         * WebKitTestRunner/TestController.cpp:
940         (WTR::TestController::generatePageConfiguration):
941
942 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
943
944         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
945
946         Add a way to skip unit tests only for Debug or Release builds and
947         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
948
949         * Scripts/run-gtk-tests:
950         (SkippedTest):
951         (SkippedTest.__init__):
952         (SkippedTest.__str__):
953         (SkippedTest.skip_entire_suite):
954         (SkippedTest.skip_for_build_type):
955         (TestRunner):
956         (TestRunner.__init__):
957
958 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
959
960         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
961
962         It's an assert hit because we are reloading a view loaded with
963         HTML data which is not supported. Use loadURI instead.
964
965         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
966         (testWebViewCustomCharset):
967
968 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
969
970         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
971         https://bugs.webkit.org/show_bug.cgi?id=151633
972
973         Reviewed by Csaba Osztrogonác.
974
975         * TestWebKitAPI/PlatformGTK.cmake:
976         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
977
978 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
979
980         [GTK] Remove the remaining uses of GMainLoopSource
981         https://bugs.webkit.org/show_bug.cgi?id=151632
982
983         Reviewed by Žan Doberšek.
984
985         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
986         (testWebViewSyncRequestOnMaxConns):
987         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
988         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
989         (WTR::TestRunner::TestRunner):
990         * WebKitTestRunner/InjectedBundle/TestRunner.h:
991         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
992         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
993         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
994         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
995         (WTR::timeoutSource):
996         (WTR::TestController::notifyDone):
997         (WTR::TestController::platformRunUntil):
998
999 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1000
1001         [cmake] Add testb3 to the build system
1002         https://bugs.webkit.org/show_bug.cgi?id=151619
1003
1004         Reviewed by Gyuyoung Kim.
1005
1006         * Scripts/build-jsc:
1007
1008 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1009
1010         [jhbuild] Fix pixman build with clang
1011         https://bugs.webkit.org/show_bug.cgi?id=151441
1012
1013         Reviewed by Carlos Garcia Campos.
1014
1015         * efl/jhbuild.modules:
1016         * gtk/jhbuild.modules:
1017
1018 2015-11-26  David Kilzer  <ddkilzer@apple.com>
1019
1020         Extract prependToEnvironmentVariableList
1021         <http://webkit.org/b/151536>
1022
1023         Reviewed by Daniel Bates.
1024
1025         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1026                webkitdirs_unittest/prependToEnvironmentVariableList.pl
1027
1028         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
1029         and prependToEnvironmentVariableList.
1030         (appendToEnvironmentVariableList): Simplify variable name.
1031         Switch to use $Config{path_sep}.
1032         (prependToEnvironmentVariableList): Add new method.
1033         (setupMacWebKitEnvironment): Switch to use
1034         prependToEnvironmentVariableList().
1035         (setupIOSWebKitEnvironment): Ditto.
1036
1037         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
1038         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
1039
1040 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1041
1042         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1043         https://bugs.webkit.org/show_bug.cgi?id=151567
1044
1045         Reviewed by Darin Adler.
1046
1047         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1048         (on_window_deletion):
1049
1050 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1051
1052         [GTK] Use the network process unconditionally
1053         https://bugs.webkit.org/show_bug.cgi?id=151541
1054
1055         Reviewed by Alex Christensen.
1056
1057         Fix TestInspectorServer test. Do not assume we already have the
1058         title we want when the page has been loaded, since the title is
1059         changed afterwards. So, check if the title has already been set,
1060         and if not wait for it.
1061
1062         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1063         (openRemoteDebuggingSession):
1064
1065 2015-11-23  Alex Christensen  <achristensen@webkit.org>
1066
1067         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
1068         https://bugs.webkit.org/show_bug.cgi?id=151532
1069
1070         Reviewed by Benjamin Poulain.
1071
1072         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1073         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1074         (TestWebKitAPI::TEST):
1075         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1076         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
1077         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
1078         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
1079         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
1080         so it was calling a function on a test object that had gone out of scope.
1081         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
1082         but that will become the default soon and that call will be removed.
1083
1084 2015-11-22  David Kilzer  <ddkilzer@apple.com>
1085
1086         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
1087         <http://webkit.org/b/151542>
1088
1089         Reviewed by Daniel Bates.
1090
1091         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1092         (base_url): Use the Port object (already passed in) to give us
1093         the path to the LayoutTests directory, which already checks for a
1094         --layout-tests-directory command-line switch.
1095         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
1096         argument since we can get this from the Port object already
1097         passed in via Port.results_directory().  Also switch to use
1098         Port.layout_tests_dir() to get the LayoutTests directory.
1099
1100         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1101         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
1102         Add test case for custom LayoutTests directory.
1103         (TestWebPlatformTestServer.test_previously_spawned_instance):
1104         Update Port object to set mock results directory as if it was
1105         set on the command-line.  Remove unneeded argument from
1106         WebPlatformTestServer constructor.
1107         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
1108
1109         * Scripts/webkitpy/port/base.py:
1110         (Port.to.start_web_platform_test_server): Remove unneeded
1111         argument from WebPlatformTestServer constuctor.
1112
1113 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1114
1115         [GTK] Some unit tests fail when using the network process
1116         https://bugs.webkit.org/show_bug.cgi?id=151490
1117
1118         Reviewed by Martin Robinson.
1119
1120         Run the soup server in a separate thread in TestResources test to
1121         avoid deadlocks.
1122
1123         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
1124         /webkit2/WebKitWebResource/get-data when using the network process.
1125
1126         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1127         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
1128         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1129         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
1130         present, create a WorkQueue to run the server.
1131         (WebKitTestServer::run): Run the server in the work queue if it
1132         has been created.
1133         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1134         type into server options as flags.
1135
1136 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1137
1138         [GTK] ImageDiff should normalize the diff image
1139         https://bugs.webkit.org/show_bug.cgi?id=151261
1140
1141         Reviewed by Sergio Villar Senin.
1142
1143         * ImageDiff/gtk/ImageDiff.cpp:
1144         (readPixbufFromStdin): Fix memory leak.
1145         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
1146         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
1147
1148 == Rolled over to ChangeLog-2015-11-21 ==