Enable DFG on MIPS
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2
3         Enable DFG on MIPS
4         https://bugs.webkit.org/show_bug.cgi?id=196689
5
6         Reviewed by Žan Doberšek.
7
8         Since the bytecode change, we enabled the baseline JIT on mips in
9         r240432, but DFG is still missing. With this change, all tests are
10         passing on a ci20 board.
11
12         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
13
14 2019-04-08  Philippe Normand  <pnormand@igalia.com>
15
16         [Flatpak] Second run update-webkitwpe-flatpak fails
17         https://bugs.webkit.org/show_bug.cgi?id=192702
18
19         Reviewed by Carlos Garcia Campos.
20
21         * flatpak/flatpakutils.py:
22         (FlatpakObject.flatpak): Fix typo.
23         (FlatpakPackage.install): When installing, also update to the configured remote commit.
24         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
25
26 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
27
28         [GTK][WPE] outlook.live.com displays old-fashioned UI
29         https://bugs.webkit.org/show_bug.cgi?id=196642
30
31         Reviewed by Carlos Garcia Campos.
32
33         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
34         (TestWebKitAPI::TEST): New Mac platform quirk test.
35
36 2019-04-07  Commit Queue  <commit-queue@webkit.org>
37
38         Unreviewed, rolling out r243956.
39         https://bugs.webkit.org/show_bug.cgi?id=196688
40
41         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
42         by aakashjain on #webkit).
43
44         Reverted changeset:
45
46         "Clicking "Go Back" from a safe browsing warning from an
47         iframe should navigate the WKWebView back to the previous
48         page"
49         https://bugs.webkit.org/show_bug.cgi?id=196665
50         https://trac.webkit.org/changeset/243956
51
52 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
53
54         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
55         https://bugs.webkit.org/show_bug.cgi?id=196669
56
57         Reviewed by Geoffrey Garen.
58
59         Added three new unit tests for WeakHashSet.
60
61         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
62         (WTF_WeakPtr.WeakHashSetConstObjects):
63         (WTF_WeakPtr.WeakHashSetComputesEmpty):
64         (WTF_WeakPtr.WeakHashSetComputeSize):
65
66 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
67
68         Hide next and previous form control buttons when WKWebView is editable
69         https://bugs.webkit.org/show_bug.cgi?id=196672
70         <rdar://problem/35625321>
71
72         Reviewed by Tim Horton.
73
74         Add a new API test.
75
76         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
77         (-[TestWKWebView lastTrailingBarButtonGroup]):
78         (TestWebKitAPI::TEST):
79         * TestWebKitAPI/ios/UIKitSPI.h:
80
81 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
82
83         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
84         https://bugs.webkit.org/show_bug.cgi?id=196077
85         <rdar://problem/49108202>
86
87         Reviewed by Chris Dumez.
88
89         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
90         on new web view.
91
92         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
93
94 2019-04-05  Saam Barati  <sbarati@apple.com>
95
96         Make compare-results understand MotionMark
97         https://bugs.webkit.org/show_bug.cgi?id=196666
98
99         Reviewed by Yusuke Suzuki.
100
101         * Scripts/compare-results:
102         (PLT5Results):
103         (detectMotionMark):
104         (detectMotionMark1_1):
105         (motionMarkResults):
106         (motionMark1_1Results):
107         (detectBenchmark):
108         (biggerIsBetter):
109         (main):
110
111 2019-04-05  Alex Christensen  <achristensen@webkit.org>
112
113         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
114         https://bugs.webkit.org/show_bug.cgi?id=196665
115         <rdar://45115669>
116
117         Reviewed by Geoff Garen.
118
119         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
120         (goBack):
121         (+[SimpleLookupContext sharedLookupContext]):
122         (-[SimpleLookupContext lookUpURL:completionHandler:]):
123         (TEST):
124         (+[Simple3LookupContext sharedLookupContext]): Deleted.
125         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
126
127 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
128
129         [ews-build] Add configuration and architecture for windows builders
130         https://bugs.webkit.org/show_bug.cgi?id=196660
131
132         Reviewed by Lucas Forschler.
133
134         * BuildSlaveSupport/ews-build/config.json:
135
136 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
137
138         webkitpy: Don't run subsequent rounds if interrupted
139         https://bugs.webkit.org/show_bug.cgi?id=196646
140
141         Reviewed by Aakash Jain.
142
143         * Scripts/webkitpy/layout_tests/controllers/manager.py:
144         (Manager.run): Bail out if interrupted.
145
146 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
147
148         Test sessionStorage in PSON private browsing mode
149         https://bugs.webkit.org/show_bug.cgi?id=196561
150
151         Reviewed by Alex Christensen.
152
153         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
154
155 2019-04-05  Commit Queue  <commit-queue@webkit.org>
156
157         Unreviewed, rolling out r243833.
158         https://bugs.webkit.org/show_bug.cgi?id=196645
159
160         This change breaks build of WPE and GTK ports (Requested by
161         annulen on #webkit).
162
163         Reverted changeset:
164
165         "[CMake][WTF] Mirror XCode header directories"
166         https://bugs.webkit.org/show_bug.cgi?id=191662
167         https://trac.webkit.org/changeset/243833
168
169 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
170
171         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
172         https://bugs.webkit.org/show_bug.cgi?id=196635
173
174         Reviewed by Antti Koivisto.
175         
176         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
177         for a test to enable async frame scrolling via:
178             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
179         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
180         
181         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
182
183         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
184         (WTR::InjectedBundle::beginTesting):
185         * WebKitTestRunner/TestController.cpp:
186         (WTR::TestController::resetPreferencesToConsistentValues):
187
188 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
189
190         Use a correct LC_RPATH when building with ASan
191         https://bugs.webkit.org/show_bug.cgi?id=196576
192
193         Reviewed by David Kilzer.
194
195         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
196         so that ../Frameworks is checked. This is simpler and more reliable than updating
197         each SPC service xcconfig.
198
199 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
200
201         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
202         https://bugs.webkit.org/show_bug.cgi?id=196629
203
204         Reviewed by Lucas Forschler.
205
206         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
207
208 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
209
210         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
211         https://bugs.webkit.org/show_bug.cgi?id=196618
212
213         Reviewed by Lucas Forschler.
214
215         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
216         (StatusBubble): Added QUEUE_TRIGGERS.
217         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
218         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
219         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
220         its parent(builder).
221
222 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
223
224         [ews-app] Status-bubble steps are sometimes displayed in reverse order
225         https://bugs.webkit.org/show_bug.cgi?id=196625
226
227         Reviewed by Lucas Forschler.
228
229         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
230         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
231
232 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
233
234         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
235         https://bugs.webkit.org/show_bug.cgi?id=196630
236
237         Reviewed by Wenson Hsieh.
238
239         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
240
241 2019-04-04  Youenn Fablet  <youenn@apple.com>
242
243         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
244         https://bugs.webkit.org/show_bug.cgi?id=196543
245
246         Reviewed by Alex Christensen.
247
248         * WebKitTestRunner/TestController.cpp:
249         (WTR::TestController::generatePageConfiguration):
250
251 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
252
253         [ews-app] Status bubble should not display skipped buildbot steps
254         https://bugs.webkit.org/show_bug.cgi?id=196584
255
256         Reviewed by Lucas Forschler.
257
258         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
259
260 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
261
262         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
263         https://bugs.webkit.org/show_bug.cgi?id=196620
264
265         Reviewed by Lucas Forschler.
266
267         * BuildSlaveSupport/ews-app/ews/config.py:
268
269 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
270
271         [Win] DumpRenderTreeWatchDog.py is not checked into source
272         https://bugs.webkit.org/show_bug.cgi?id=196567
273         <rdar://problem/49525901>
274
275         Reviewed by Lucas Forschler.
276
277         This script is used on Win EWS bots to terminate hanging DRT processes.
278
279         * EWSTools/dumprendertreewatchdog.py: Added.
280
281 2019-04-04  Chris Dumez  <cdumez@apple.com>
282
283         Unreviewed, roll out r243858 which made tests time out.
284
285         Disable new API tests on Windows instead.
286
287         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
288         (TestWebKitAPI::TEST):
289
290 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
291
292         [ATK] Cleanup WebPageAccessibilityObjectAtk
293         https://bugs.webkit.org/show_bug.cgi?id=196537
294
295         Reviewed by Michael Catanzaro.
296
297         Also consider files under atk directories as exceptions for GObject conventions.
298
299         * Scripts/webkitpy/style/checkers/cpp.py:
300         (check_identifier_name_in_declaration):
301
302 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
303
304         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
305         https://bugs.webkit.org/show_bug.cgi?id=196588
306         <rdar://problem/49365787>
307
308         Unreviewed build fix for Windows port.
309
310         error C3861: 'kill': identifier not found
311
312         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
313         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
314
315 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
316
317         [ews-build] Cancel build and similar operations should have authentication
318         https://bugs.webkit.org/show_bug.cgi?id=196520
319
320         Reviewed by Dewei Zhu.
321
322         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
323         environment variables.
324
325 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
326
327         [ews-build] Do not trigger queues which are not in production yet
328         https://bugs.webkit.org/show_bug.cgi?id=196581
329
330         Reviewed by Dewei Zhu.
331
332         * BuildSlaveSupport/ews-build/config.json:
333
334 2019-04-03  Chris Dumez  <cdumez@apple.com>
335
336         Unreviewed, fix typo in the name of API test added in r243848.
337
338         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
339         (TestWebKitAPI::TEST):
340
341 2019-04-03  Chris Dumez  <cdumez@apple.com>
342
343         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
344         https://bugs.webkit.org/show_bug.cgi?id=196588
345         <rdar://problem/49365787>
346
347         Reviewed by Ryosuke Niwa.
348
349         Add API test coverage.
350
351         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
352         (TestWebKitAPI::nullJavaScriptCallback):
353         (TestWebKitAPI::didCrashCheckFrames):
354         (TestWebKitAPI::TEST):
355
356 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
357
358         run-webkit-tests: Upload test results (new results database)
359         https://bugs.webkit.org/show_bug.cgi?id=196577
360         <rdar://problem/34841155>
361
362         Reviewed by Lucas Forschler.
363
364         * Scripts/webkitpy/layout_tests/controllers/manager.py:
365         (Manager.run): Upload results after each device shard, since the configuration will be
366         different for each device.
367         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
368         uploaded to a results database.
369         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
370         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
371
372 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
373
374         -apple-trailing-word is needed for browser detection
375         https://bugs.webkit.org/show_bug.cgi?id=196575
376
377         Unreviewed.
378
379         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
380
381 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
382
383         [CMake][WTF] Mirror XCode header directories
384         https://bugs.webkit.org/show_bug.cgi?id=191662
385
386         Reviewed by Konstantin Tokarev.
387
388         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
389         builds.
390
391         * CMakeLists.txt:
392         * DumpRenderTree/CMakeLists.txt:
393         * DumpRenderTree/PlatformWin.cmake:
394         * MiniBrowser/win/CMakeLists.txt:
395         * TestWebKitAPI/CMakeLists.txt:
396         * TestWebKitAPI/PlatformWin.cmake:
397         * WebKitTestRunner/PlatformGTK.cmake:
398         * WebKitTestRunner/PlatformWin.cmake:
399
400 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
401
402         [ews-app] Status bubble should not display certain infrastructure status messages
403         https://bugs.webkit.org/show_bug.cgi?id=196550
404
405         Reviewed by Lucas Forschler.
406
407         Do not display the steps which are un-needed for end-user. This information is still avaiable
408         if the user click on the bubble and look at the Buildbot build.
409         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
410         (StatusBubble._steps_messages):
411         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
412
413 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
414
415         [ews-build] Use https for sending data to ews-app
416         https://bugs.webkit.org/show_bug.cgi?id=196492
417
418         Reviewed by Lucas Forschler.
419
420         * BuildSlaveSupport/ews-build/events.py:
421
422 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
423
424         Remove support for -apple-trailing-word
425         https://bugs.webkit.org/show_bug.cgi?id=196525
426
427         Reviewed by Zalan Bujtas.
428
429         This CSS property is nonstandard and not used.
430
431         * Scripts/webkitperl/FeatureList.pm:
432         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
433
434 2019-04-03  Youenn Fablet  <youenn@apple.com>
435
436         Add a test for DOMCache on multiple browsing in case of private browsing
437         https://bugs.webkit.org/show_bug.cgi?id=196524
438
439         Reviewed by Alex Christensen.
440
441         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
442         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
443
444 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
445
446         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
447         https://bugs.webkit.org/show_bug.cgi?id=196540
448
449         Reviewed by Aakash Jain.
450
451         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
452
453 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
454
455         Add plumbing for a compatibility mode preference in WebKit
456         https://bugs.webkit.org/show_bug.cgi?id=196005
457
458         Reviewed by Tim Horton.
459
460         Add new API tests.
461
462         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
463         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
464
465 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
466
467         [WPE][GTK] Update libsrtp dependency package for Debian
468         https://bugs.webkit.org/show_bug.cgi?id=196528
469
470         Reviewed by Frédéric Wang.
471
472         * gtk/install-dependencies:
473         * wpe/install-dependencies:
474
475 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
476
477         [WK2] Add support for Window's beforeprint / afterprint events
478         https://bugs.webkit.org/show_bug.cgi?id=196478
479         <rdar://problem/49535124>
480
481         Unreviewed build fix for MSVC.
482
483         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
484
485         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
486
487         * WebKitTestRunner/TestController.cpp:
488         (WTR::printFrame): Use int and float literals.
489
490 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
491
492         [ews-build] Reassign bots to queues
493
494         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
495
496 2019-04-02  Chris Dumez  <cdumez@apple.com>
497
498         [WK2] Add support for Window's beforeprint / afterprint events
499         https://bugs.webkit.org/show_bug.cgi?id=196478
500
501         Reviewed by Alex Christensen.
502
503         Add minimal implementation for printFrame in WebKitTestRunner.
504
505         * WebKitTestRunner/TestController.cpp:
506         (WTR::printFrame):
507         (WTR::TestController::createOtherPage):
508         (WTR::TestController::createWebViewWithOptions):
509
510 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
511
512         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
513         https://bugs.webkit.org/show_bug.cgi?id=196491
514
515         Reviewed by Lucas Forschler.
516
517         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
518
519 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
520
521         [ews-build] Configure buildbot try credentials in environment variables
522         https://bugs.webkit.org/show_bug.cgi?id=196501
523
524         Reviewed by Lucas Forschler.
525
526         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
527         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
528         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
529
530 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
531
532         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
533         https://bugs.webkit.org/show_bug.cgi?id=196496
534         <rdar://problem/49521634>
535
536         Reviewed by Chris Dumez.
537
538         Add new API tests (see WebKit ChangeLog for more detail).
539
540         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
541         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
542         (TEST):
543
544 2019-04-02  David Kilzer  <ddkilzer@apple.com>
545
546         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
547         <https://webkit.org/b/196499>
548
549         Reviewed by Alexey Proskuryakov.
550
551         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
552         ENABLE_ADDRESS_SANITIZER.
553
554 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
555
556         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
557         https://bugs.webkit.org/show_bug.cgi?id=182757
558
559         Reviewed by Don Olmstead.
560
561         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
562         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
563
564 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
565
566         run-api-tests: Upload test results
567         https://bugs.webkit.org/show_bug.cgi?id=196323
568         <rdar://problem/49356714>
569
570         Reviewed by Lucas Forschler.
571
572         * Scripts/webkitpy/api_tests/manager.py:
573         (Manager):
574         (Manager.run): Upload results to a results database.
575         * Scripts/webkitpy/api_tests/run_api_tests.py:
576         (parse_args): Add upload arguments.
577         * Scripts/webkitpy/port/base.py:
578         (Port):
579         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
580         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
581         with commits from any other associated repositories.
582         * Scripts/webkitpy/port/device.py:
583         (Device):
584         (Device.build_version): Access build_versoin of underlying platform device.
585         * Scripts/webkitpy/port/ios_simulator_unittest.py:
586         (IOSSimulatorTest):
587         (IOSSimulatorTest.test_configuration_for_upload):
588         * Scripts/webkitpy/port/device_port.py:
589         (DevicePort):
590         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
591         the same as the machine uploading results.
592         * Scripts/webkitpy/port/mac.py:
593         (MacPort):
594         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
595         * Scripts/webkitpy/port/mac_unittest.py:
596         (MacTest):
597         (MacTest.test_configuration_for_upload):
598         * Scripts/webkitpy/xcode/simulated_device.py:
599         (SimulatedDeviceManager._create_device_with_runtime):
600         (SimulatedDevice.__init__): Create simulated device with a build_version.
601         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
602         (test_existing_simulator):
603
604 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
605
606         Remove extra newline characters (Follow-up fix to r243707)
607
608         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
609
610 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
611
612         [ews-app] Use API_KEY to accept results data
613         https://bugs.webkit.org/show_bug.cgi?id=196461
614
615         Reviewed by Dewei Zhu.
616
617         * BuildSlaveSupport/ews-app/ews/views/results.py:
618         (Results.post): Validate EWS_API_KEY before accepting any data.
619         * BuildSlaveSupport/ews-build/events.py:
620         (Events.sendData): Send EWS_API_KEY if available along with event data.
621
622 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
623
624         Unable to copy and paste a PDF from Notes into Mail compose body
625         https://bugs.webkit.org/show_bug.cgi?id=196442
626         <rdar://problem/48573098>
627
628         Reviewed by Tim Horton.
629
630         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
631         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
632         to be specified on the item providers.
633
634         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
635         (TestWebKitAPI::mapItemForTesting):
636         (TestWebKitAPI::contactItemForTesting):
637
638 2019-04-01  Tim Horton  <timothy_horton@apple.com>
639
640         Make UIWKDocumentContext rects per-character instead of per-word
641         https://bugs.webkit.org/show_bug.cgi?id=196459
642
643         Reviewed by Wenson Hsieh.
644
645         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
646         (TEST):
647         Adjust test results due to switching to per-character rects.
648
649 2019-04-01  Chris Dumez  <cdumez@apple.com>
650
651         UIProcess crash when a prewarmed process is terminated
652         https://bugs.webkit.org/show_bug.cgi?id=196451
653         <rdar://problem/49245471>
654
655         Reviewed by Geoffrey Garen.
656
657         Add API test coverage.
658
659         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
660         (TEST):
661
662 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
663
664         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
665         https://bugs.webkit.org/show_bug.cgi?id=196449
666
667         Reviewed by Lucas Forschler.
668
669         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
670         (StatusBubble.get_os_details): Method to get OS and Xcode details.
671         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
672         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
673
674 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
675
676         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
677         https://bugs.webkit.org/show_bug.cgi?id=196444
678
679         Reviewed by Lucas Forschler.
680
681         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
682
683 2019-04-01  Alex Christensen  <achristensen@webkit.org>
684
685         Add SPI to canonicalize NSURLs with WTF::URL
686         https://bugs.webkit.org/show_bug.cgi?id=196415
687         <rdar://problem/44980271>
688
689         Reviewed by Darin Adler.
690
691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
692         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
693         (TestWebKitAPI::TEST):
694
695 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
696
697         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
698         https://bugs.webkit.org/show_bug.cgi?id=196441
699
700         Reviewed by Carlos Garcia Campos.
701
702         Don't cache the wpe_view_backend object that might not exist yet at the
703         time of EventSenderProxy constructor invocation, but instead retrieve
704         that object whenever it's required for event dispatching. This should
705         avoid crashes in this constructor now that it's invoked before any
706         PlatformWindow has been set up (as changed in r243496).
707
708         * WebKitTestRunner/EventSenderProxy.h:
709         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
710         (WTR::viewBackend):
711         (WTR::EventSenderProxy::EventSenderProxy):
712         (WTR::EventSenderProxy::mouseDown):
713         (WTR::EventSenderProxy::mouseUp):
714         (WTR::EventSenderProxy::mouseMoveTo):
715         (WTR::EventSenderProxy::mouseScrollBy):
716         (WTR::EventSenderProxy::keyDown):
717         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
718
719 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
720
721         [Win][WebKit] MiniBrowser should support high DPI display
722         https://bugs.webkit.org/show_bug.cgi?id=196391
723
724         Reviewed by Alex Christensen.
725
726         * MiniBrowser/win/WebKitBrowserWindow.cpp:
727         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
728         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
729         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
730
731 2019-03-31  Sam Weinig  <weinig@apple.com>
732
733         Remove more i386 specific configurations
734         https://bugs.webkit.org/show_bug.cgi?id=196430
735
736         Reviewed by Alexey Proskuryakov.
737
738         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
739         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
740
741 2019-03-31  Andy Estes  <aestes@apple.com>
742
743         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
744         https://bugs.webkit.org/show_bug.cgi?id=196433
745         <rdar://problem/49293305>
746
747         Reviewed by Tim Horton.
748
749         Enhanced API test coverage to include all navigation response policy decisions in both
750         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
751
752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
753         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
754         (TestWebKitAPI::TEST):
755         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
756         (readFile):
757         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
758         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
759         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
760         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
761         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
762         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
763         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
764         (-[QuickLookDelegate _downloadDidStart:]):
765         (-[QuickLookDelegate _download:didReceiveResponse:]):
766         (-[QuickLookDelegate _download:didReceiveData:]):
767         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
768         (-[QuickLookDelegate _downloadDidFinish:]):
769         (-[QuickLookDelegate _download:didFailWithError:]):
770         (-[QuickLookDelegate _downloadDidCancel:]):
771         (-[QuickLookDelegate verifyDownload]):
772         (runTest):
773         (runTestDecideBeforeLoading):
774         (runTestDecideAfterLoading):
775         (TEST):
776         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
777         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
778         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
779         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
780         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
781         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
782         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
783         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
784         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
785         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
786         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
787         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
788         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
789         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
790
791 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
792
793         [CMake] add testdfg as target with build-jsc
794         https://bugs.webkit.org/show_bug.cgi?id=196393
795
796         Reviewed by Saam Barati.
797
798         Added testdfg as one of the targets to build when
799         using CMake.
800
801         * Scripts/build-jsc:
802
803 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
804
805         Delete WebMetal implementation in favor of WebGPU
806         https://bugs.webkit.org/show_bug.cgi?id=195418
807
808         Reviewed by Dean Jackson.
809
810         * DumpRenderTree/mac/DumpRenderTree.mm:
811         (enableExperimentalFeatures):
812         (resetWebPreferencesToConsistentValues):
813         * Scripts/webkitperl/FeatureList.pm:
814         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
815         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
816         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
817         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
818         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
819         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
820         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
821         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
822         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
823         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
824         (WTR::InjectedBundle::beginTesting):
825         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
826         (WTR::TestRunner::setWebMetalEnabled): Deleted.
827         * WebKitTestRunner/InjectedBundle/TestRunner.h:
828
829 2019-03-29  Chris Dumez  <cdumez@apple.com>
830
831         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
832         https://bugs.webkit.org/show_bug.cgi?id=196405
833         <rdar://problem/49428130>
834
835         Reviewed by Wenson Hsieh.
836
837         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
838         the popover presentation methods to be no-ops. Use this in the new test added in
839         r243523 so that we do not swizzle those methods for all tests. This is needed because
840         those WatchOS tests rely on the popover getting presented and interactive.
841
842         * WebKitTestRunner/TestController.cpp:
843         (WTR::updateTestOptionsFromTestHeader):
844         * WebKitTestRunner/TestController.h:
845         * WebKitTestRunner/TestOptions.h:
846         (WTR::TestOptions::hasSameInitializationOptions const):
847         * WebKitTestRunner/ios/TestControllerIOS.mm:
848         (WTR::TestController::platformInitialize):
849         (WTR::TestController::platformResetStateToConsistentValues):
850
851 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
852
853         [Curl] Add Server Trust Evaluation Support.
854         https://bugs.webkit.org/show_bug.cgi?id=191646
855
856         Reviewed by Fujii Hironori.
857
858         Implemented MiniBrowser UI for asking if user trusts the server.
859
860         * MiniBrowser/win/Common.cpp:
861         (askServerTrustEvaluation):
862         (replaceString):
863         * MiniBrowser/win/Common.h:
864         * MiniBrowser/win/MiniBrowserLib.rc:
865         * MiniBrowser/win/MiniBrowserLibResource.h:
866         * MiniBrowser/win/WebKitBrowserWindow.cpp:
867         (createPEMString):
868         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
869         (WebKitBrowserWindow::canTrustServerCertificate):
870         * MiniBrowser/win/WebKitBrowserWindow.h:
871
872 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
873
874         Implement ResizeObserver.
875         https://bugs.webkit.org/show_bug.cgi?id=157743
876
877         Reviewed by Simon Fraser.
878
879         Support resizeObserverEnabled webPreferences.
880
881         * DumpRenderTree/TestOptions.cpp:
882         (TestOptions::TestOptions):
883         * DumpRenderTree/TestOptions.h:
884         * DumpRenderTree/mac/DumpRenderTree.mm:
885         (setWebPreferencesForTestOptions):
886         * DumpRenderTree/win/DumpRenderTree.cpp:
887         (enableExperimentalFeatures):
888         * Scripts/webkitperl/FeatureList.pm:
889         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
890
891 2019-03-28  John Wilander  <wilander@apple.com>
892
893         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
894         https://bugs.webkit.org/show_bug.cgi?id=196281
895         <rdar://problem/48938748>
896
897         Reviewed by Alex Christensen.
898
899         This patch adds the function isStatisticsHasLocalStorage() to the
900         TestRunner. With it, the page can query the WebsiteDataStore in the
901         UI process to make sure that it sees LocalStorage.
902
903         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
904         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
905         (WTR::TestRunner::isStatisticsHasLocalStorage):
906         * WebKitTestRunner/InjectedBundle/TestRunner.h:
907         * WebKitTestRunner/TestController.cpp:
908         (WTR::TestController::isStatisticsHasLocalStorage):
909         * WebKitTestRunner/TestController.h:
910         * WebKitTestRunner/TestInvocation.cpp:
911         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
912
913 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
914
915         API::Data::createWithoutCopying should do a null check before calling CFRelease
916         https://bugs.webkit.org/show_bug.cgi?id=196276
917         <rdar://problem/48059859>
918
919         Reviewed by Alex Christensen.
920
921         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
922
923         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
924         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
925         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
926         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
927         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
928         (TestWebKitAPI::TEST):
929
930 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
931
932         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
933         https://bugs.webkit.org/show_bug.cgi?id=186276
934
935         Reviewed by Carlos Garcia Campos.
936
937         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
938         (webViewLoadChanged):
939         (testWebResourceGetDataError):
940         (testWebResourceGetDataEmpty):
941         (beforeAll):
942         (webViewloadChanged): Deleted.
943
944 2019-03-27  Andy Estes  <aestes@apple.com>
945
946         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
947         https://bugs.webkit.org/show_bug.cgi?id=196317
948
949         Reviewed by Dan Bernstein.
950
951         package-root copies built products into a staging directory using ditto(1), which does not
952         follow symbolic links as it traverses a directory. Now that the files in
953         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
954         itself, these become broken links when ditto'd into the staging directory.
955
956         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
957
958         * Scripts/package-root:
959
960 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
961
962         [ews-app] Update display text of Submit for ews analysis
963         https://bugs.webkit.org/show_bug.cgi?id=196309
964
965         Reviewed by Dewei Zhu.
966
967         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
968
969 2019-03-27  David Kilzer  <ddkilzer@apple.com>
970
971         run-webkit-tests should check for leaks in WebKit processes
972         <https://webkit.org/b/193772>
973         <rdar://problem/46526680>
974
975         Reviewed by Ryosuke Niwa.
976
977         This works by doing the following:
978         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
979           The list of child processes are returned one per line:
980           process.name: pid
981         - Run the "#LIST CHILD PROCESSES" command just before the
982           "#CHECK FOR WORLD LEAKS" command, and store the list of child
983           processes on the ServerProcess object.
984         - When the `--leaks` switch is handled, run check_for_leaks() on
985           each child process after the main test harness.
986
987         * DumpRenderTree/mac/DumpRenderTree.mm:
988         (handleControlCommand):
989         - Use strncmp() instead of strcmp().
990         - Add support for handling "#LIST CHILD PROCESSES" command.
991
992         * Scripts/webkitpy/port/base.py:
993         (Port.check_for_leaks):
994         * Scripts/webkitpy/port/darwin.py:
995         (DarwinPort.check_for_leaks):
996         - Rename redundant 'process_pid' argument to 'process_id'.
997
998         * Scripts/webkitpy/port/driver.py:
999         (Driver.do_post_tests_work):
1000         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1001           longer the only command this sends to WebKitTestRunner.
1002         - If the `--leaks` switch is present, send the
1003           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1004           result using Port.set_webkit_processes().
1005         (Driver._parse_child_processes_output):
1006         - Add helper method to parse list of child process names and
1007           process IDs returned from WebKitTestRunner.
1008
1009         * Scripts/webkitpy/port/ios_device.py:
1010         (IOSDevicePort.check_for_leaks):
1011         - Rename redundant 'process_pid' argument to 'process_id'.
1012
1013         * Scripts/webkitpy/port/leakdetector.py:
1014         (LeakDetector._parse_leaks_output):
1015         - Return early if there is no leaks_output.
1016         (LeakDetector.check_for_leaks):
1017         - Rename redundant 'process_pid' argument to 'process_id'.
1018
1019         * Scripts/webkitpy/port/server_process.py:
1020         (ServerProcess.__init__):
1021         (ServerProcess.child_processes):
1022         (ServerProcess.set_child_processes):
1023         - Add instance variable to Port to store list of child process
1024           names and process IDs returned from WebKitTestRunner.
1025         (ServerProcess._start):
1026         - Clear self._child_processes.
1027         (ServerProcess.stop):
1028         - If self._child_processes is set, call
1029           self._port.check_for_leaks() for each child process.
1030
1031         * Scripts/webkitpy/port/server_process_unittest.py:
1032         (TrivialMockPort.check_for_leaks):
1033         - Rename redundant 'process_pid' argument to 'process_id'.
1034
1035         * Scripts/webkitpy/port/simulator_process.py:
1036         (SimulatorProcess.stop):
1037         - If self._child_processes is set, call
1038           self._port.check_for_leaks() for each child process.
1039
1040         * Scripts/webkitpy/port/watch_device.py:
1041         (WatchDevicePort.check_for_leaks):
1042         - Rename redundant 'process_pid' argument to 'process_id'.
1043
1044         * WebKitTestRunner/TestController.cpp:
1045         (WTR::TestController::dumpResponse):
1046         - Extract method from findAndDumpWorldLeaks() so that it may be
1047           reused by findAndDumpWebKitProcessIdentifiers().
1048         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1049         - Add method to output process name and process ID of both the
1050           WebContent and Networking processes.
1051         (WTR::TestController::findAndDumpWorldLeaks):
1052         - Fix missing newline in output when there were no abandoned
1053           documents.
1054         - Call dumpResponse() for extracted code.
1055         (WTR::TestController::handleControlCommand):
1056         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1057         - Use strncmp() instead of strcmp().
1058         - Call findAndDumpWebKitProcessIdentifiers() when
1059           "#LIST CHILD PROCESSES" command is sent.
1060         * WebKitTestRunner/TestController.h:
1061         (WTR::TestController::dumpResponse):
1062         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1063         - Declare methods.
1064
1065 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1066
1067         Unreviewed. Add GLib API test cases after r243434.
1068
1069         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1070         (testWebViewActiveURI):
1071         (serverCallback):
1072         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1073         (sendRequestCallback):
1074
1075 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1076
1077         Geolocation request not complete when watch request was started in a different web process
1078         https://bugs.webkit.org/show_bug.cgi?id=195996
1079
1080         Reviewed by Alex Christensen.
1081
1082         Add a test case.
1083
1084         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1085         (TestWebKitAPI::runJavaScriptAlert):
1086         (TestWebKitAPI::TEST):
1087
1088 2019-03-26  Keith Rollin  <krollin@apple.com>
1089
1090         Update the way generate-xcfilelists returns strings from functions
1091         https://bugs.webkit.org/show_bug.cgi?id=195975
1092         <rdar://problem/49040807>
1093
1094         Reviewed by Dean Jackson.
1095
1096         There are places where generate-xcfilelists executes assignments with
1097         statements like:
1098
1099             FOO=$(some_function)
1100
1101         where "some_function" return a string by echoing it. E.g.
1102
1103             some_function()
1104             {
1105                 echo "Hello, World"
1106             }
1107
1108         This is a common idiom, but it has a problem if "some_function" needs
1109         to call "exit" in an attempt to halt the entire script right then and
1110         there. Since "some_function" is called inside of $(), it's being
1111         executed in a sub-shell. Calling exit in that sub-shell simply exits
1112         that shell; it doesn't not exit the outer shell in which the main part
1113         of the script is still running. As such, the main script keeps
1114         executing when the intent was for the script to halt.
1115
1116         The solution to this is to use a different idiom for returning
1117         strings. The one we now is to pass in the name of the variable to
1118         receive the string result:
1119
1120             some_function()
1121             {
1122                 variable_name=$1
1123                 eval $variable_name ="Hello, World"
1124             }
1125
1126         The call site now looks like
1127
1128             some_function FOO
1129
1130         Because there's no invocation of a sub-shell, some_function can now
1131         call "exit" if it wants to, and the entire script will exit at that
1132         point.
1133
1134         * Scripts/generate-xcfilelists:
1135
1136 2019-03-26  Chris Dumez  <cdumez@apple.com>
1137
1138         Add basic layout test coverage for File Picker on iOS
1139         https://bugs.webkit.org/show_bug.cgi?id=196265
1140
1141         Reviewed by Wenson Hsieh.
1142
1143         Add layout test infrastructure to test the file picker on iOS.
1144
1145         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1146         (WTR::UIScriptController::dismissFilePicker):
1147         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1148         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1149         (WTR::UIScriptController::dismissFilePicker):
1150         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1151         * WebKitTestRunner/TestController.cpp:
1152         (WTR::TestController::createWebViewWithOptions):
1153         (WTR::updateTestOptionsFromTestHeader):
1154         * WebKitTestRunner/TestOptions.h:
1155         (WTR::TestOptions::hasSameInitializationOptions const):
1156         * WebKitTestRunner/ios/TestControllerIOS.mm:
1157         (overridePresentViewController):
1158         (WTR::TestController::platformInitialize):
1159         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1160         (WTR::UIScriptController::dismissFilePicker):
1161
1162 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1163
1164         Implement async paste method on UIWKInteractionViewProtocol
1165         https://bugs.webkit.org/show_bug.cgi?id=196267
1166         <rdar://problem/49236346>
1167
1168         Reviewed by Tim Horton.
1169
1170         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1171         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1172         are now a part of all iOS 12 internal SDKs.
1173
1174         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1175
1176         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1177         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1178
1179         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1180         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1181         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1182         * TestWebKitAPI/ios/UIKitSPI.h:
1183
1184 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1185
1186         [ews-build] Use PostgreSQL for ews.webkit.org database
1187         https://bugs.webkit.org/show_bug.cgi?id=196270
1188
1189         Reviewed by Lucas Forschler.
1190
1191         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1192
1193 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1194
1195         [ews] Reset simctl states on reboot
1196         https://bugs.webkit.org/show_bug.cgi?id=196260
1197
1198         Rubber-stamped by Aakash Jain.
1199
1200         * EWSTools/start-queue-mac.sh:
1201
1202 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1203
1204         [ews-build] Use PostgreSQL for ews-build database
1205         https://bugs.webkit.org/show_bug.cgi?id=196229
1206
1207         Reviewed by Lucas Forschler.
1208
1209         * BuildSlaveSupport/ews-build/master.cfg:
1210
1211 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1212
1213         [ews-build] Get master_hostname dynamically in master.cfg
1214         https://bugs.webkit.org/show_bug.cgi?id=196255
1215
1216         Reviewed by Lucas Forschler.
1217
1218         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1219         send events data in test mode.
1220
1221 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1222
1223         [ews-app] Set db_constraint to False for Foreign Keys
1224         https://bugs.webkit.org/show_bug.cgi?id=196252
1225
1226         Reviewed by Lucas Forschler.
1227
1228         * BuildSlaveSupport/ews-app/ews/models/build.py:
1229         * BuildSlaveSupport/ews-app/ews/models/step.py:
1230
1231 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1232
1233         [ews-build] is_test_mode_enabled should default to True
1234         https://bugs.webkit.org/show_bug.cgi?id=196248
1235
1236         Reviewed by Lucas Forschler.
1237
1238         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1239
1240 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1241
1242         [ews-app] Add webkitperl to ENABLED_QUEUES
1243         https://bugs.webkit.org/show_bug.cgi?id=196253
1244
1245         Reviewed by Lucas Forschler.
1246
1247         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1248
1249 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1250
1251         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1252         https://bugs.webkit.org/show_bug.cgi?id=196211
1253         rdar://problem/49110552
1254
1255         Reviewed by Tim Horton.
1256
1257         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1258         Make sure that EventSenderProxy always exists when running tests. We used to create
1259         it when resetting before the first test, which is a bit too late.
1260
1261         * WebKitTestRunner/TestController.h:
1262         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1263         (WTR::TestController::platformCreateWebView):
1264         (WTR::TestController::platformCreateOtherPage):
1265         (WTR::TestController::finishCreatingPlatformWebView):
1266         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1267         (WTR::PlatformWebView::PlatformWebView):
1268         Moved some code that made NSWindow use NSEvent during web view creation. We may
1269         need to move more if some other case us found, but this is enough for now.
1270
1271 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1272
1273         Unreviewed. Fix typo in GLib geolocation API after r243285.
1274
1275         gelocation -> geolocation.
1276
1277         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1278         (testGeolocationManagerWatchPosition):
1279
1280 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1281
1282         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1283         https://bugs.webkit.org/show_bug.cgi?id=196213
1284
1285         Reviewed by Geoff Garen.
1286
1287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1288         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1289         (credentialWithIdentityAndKeychainPath):
1290         (-[ChallengeDelegate webView:didFinishNavigation:]):
1291         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1292         (TestWebKitAPI::TEST):
1293
1294 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1295
1296         Expected shouldn't assume its contained types are copyable
1297         https://bugs.webkit.org/show_bug.cgi?id=195986
1298
1299         Reviewed by JF Bastien.
1300
1301         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1302         (TestWebKitAPI::NonCopyable::operator== const):
1303         (TestWebKitAPI::NonCopyable::operator!= const):
1304         (TestWebKitAPI::TEST):
1305
1306 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1307
1308         Remove some now-unnecessary dynamic class lookup
1309         https://bugs.webkit.org/show_bug.cgi?id=196237
1310
1311         Reviewed by Simon Fraser.
1312
1313         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1314         (makeRequest):
1315         (TEST):
1316
1317 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1318
1319         Unreviewed, rolling out r243450.
1320
1321         AppleWin and WinCairo port builds get broken.
1322
1323         Reverted changeset:
1324
1325         "Add test for fix of #196095"
1326         https://bugs.webkit.org/show_bug.cgi?id=196097
1327         https://trac.webkit.org/changeset/243450
1328
1329 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1330
1331         Unreviewed, rolling out r243465.
1332         https://bugs.webkit.org/show_bug.cgi?id=196226
1333
1334         the test doesn't build (Requested by thorton on #webkit).
1335
1336         Reverted changeset:
1337
1338         "Do not terminate the NetworkProcess if a third party
1339         application sends a NSCredential with a SecIdentityRef"
1340         https://bugs.webkit.org/show_bug.cgi?id=196213
1341         https://trac.webkit.org/changeset/243465
1342
1343 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1344
1345         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1346         https://bugs.webkit.org/show_bug.cgi?id=196213
1347
1348         Reviewed by Geoff Garen.
1349
1350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1351         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1352         (credentialWithIdentityAndKeychainPath):
1353         (-[ChallengeDelegate webView:didFinishNavigation:]):
1354         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1355         (TestWebKitAPI::TEST):
1356
1357 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1358
1359         [ews-build] Gracefully handle missing patch_id in events
1360         https://bugs.webkit.org/show_bug.cgi?id=196216
1361
1362         Reviewed by Lucas Forschler.
1363
1364         * BuildSlaveSupport/ews-build/events.py:
1365
1366 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1367
1368         [ews-build] use lz4 compression for improving buildbot performance
1369         https://bugs.webkit.org/show_bug.cgi?id=196155
1370
1371         Reviewed by Lucas Forschler.
1372
1373         * BuildSlaveSupport/ews-build/master.cfg:
1374
1375 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1376
1377         Pull some API testing helper methods out of TestWKWebView
1378         https://bugs.webkit.org/show_bug.cgi?id=196212
1379
1380         Reviewed by Tim Horton.
1381
1382         Refactor some more API testing utility methods, so that they can be used in
1383         tests that do not use TestWKWebView.
1384
1385         * TestWebKitAPI/cocoa/TestWKWebView.h:
1386         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1387         (-[WKWebView loadTestPageNamed:]):
1388         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1389         (-[WKWebView synchronouslyLoadHTMLString:]):
1390         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1391         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1392         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1393         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1394         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1395
1396 2019-03-25  Jer Noble  <jer.noble@apple.com>
1397
1398         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1399         https://bugs.webkit.org/show_bug.cgi?id=196097
1400
1401         Reviewed by Eric Carlson.
1402
1403         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1404
1405         * DumpRenderTree/mac/DumpRenderTree.mm:
1406         (resetWebPreferencesToConsistentValues):
1407         * WebKitTestRunner/TestController.cpp:
1408         (WTR::TestController::resetPreferencesToConsistentValues):
1409
1410 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1411
1412         Pull IPadUserInterfaceSwizzler out into a separate header file
1413         https://bugs.webkit.org/show_bug.cgi?id=196193
1414
1415         Reviewed by Anders Carlsson.
1416
1417         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1418         be used in other API tests.
1419
1420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1421         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1422         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1423         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1424         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1425         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1426         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1427
1428 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1429
1430         Remove NavigatorContentUtils in WebCore/Modules
1431         https://bugs.webkit.org/show_bug.cgi?id=196070
1432
1433         Reviewed by Alex Christensen.
1434
1435         NavigatorContentUtils was to support the custom scheme spec [1].
1436         However, in WebKit side, no port has supported the feature in
1437         WebKit layer after EFL port was removed. So there has been the
1438         only IDL implementation of the NavigatorContentUtils in WebCore.
1439         So we don't need to keep the implementation in WebCore anymore.
1440
1441         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1442
1443         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1444
1445 2019-03-24  Andy Estes  <aestes@apple.com>
1446
1447         [watchOS] Remove unused Proximity Networking code
1448         https://bugs.webkit.org/show_bug.cgi?id=196188
1449
1450         Reviewed by Tim Horton.
1451
1452         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1453         (TEST):
1454
1455 2019-03-23  Keith Miller  <keith_miller@apple.com>
1456
1457         Refactor clz/ctz and fix getLSBSet.
1458         https://bugs.webkit.org/show_bug.cgi?id=196162
1459
1460         Reviewed by Saam Barati.
1461
1462         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1463
1464         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1465         (TestWebKitAPI::TEST):
1466
1467 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1468
1469         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1470         https://bugs.webkit.org/show_bug.cgi?id=196143
1471
1472         Reviewed by Michael Catanzaro.
1473
1474         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1475         directories.
1476
1477         * Scripts/webkitpy/style/checkers/cpp.py:
1478         (check_identifier_name_in_declaration):
1479         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1480         (WebKitStyleTest.test_names):
1481
1482 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1483
1484         [Flatpak] Manifest expanding fails for qt WPE extension
1485         https://bugs.webkit.org/show_bug.cgi?id=196148
1486
1487         Reviewed by Alex Christensen.
1488
1489         * flatpak/flatpakutils.py:
1490         (expand_submodules_recurse): The last recurse manifest expand
1491         iteration might lead to a single module so take it into account
1492         and don't try to recurse further.
1493
1494 2019-03-22  Chris Dumez  <cdumez@apple.com>
1495
1496         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1497         https://bugs.webkit.org/show_bug.cgi?id=195348
1498         <rdar://problem/48622090>
1499
1500         Reviewed by Alex Christensen.
1501
1502         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1503         to NO when test.options().shouldIgnoreMetaViewport is false.
1504
1505         * WebKitTestRunner/ios/TestControllerIOS.mm:
1506         (WTR::TestController::platformConfigureViewForTest):
1507
1508 2019-03-22  Chris Dumez  <cdumez@apple.com>
1509
1510         Prewarmed processes should be usable with any website data store
1511         https://bugs.webkit.org/show_bug.cgi?id=196104
1512
1513         Reviewed by Alex Christensen.
1514
1515         Add API test coverage.
1516
1517         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1518         (runInitialWarmedProcessUsedTest):
1519         (TEST):
1520
1521 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1522
1523         Back out local changes to Alex's Subversion working directory
1524
1525         They were accidentally committed.
1526
1527         * Scripts/webkitpy/common/system/abstractexecutive.py:
1528         (AbstractExecutive.wait_newest):
1529         * Scripts/webkitpy/common/system/executive.py:
1530         (Executive.running_pids):
1531         * Scripts/webkitpy/common/system/executive_mock.py:
1532         (MockExecutive.running_pids):
1533         * Scripts/webkitpy/common/system/executive_unittest.py:
1534         (ExecutiveTest.serial_test_running_pids):
1535         * Scripts/webkitpy/port/darwin.py:
1536         (DarwinPort.check_for_leaks):
1537         * Scripts/webkitpy/port/leakdetector.py:
1538         (LeakDetector.check_for_leaks):
1539         - This was the hack attached to Bug 193772.
1540
1541         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1542         (+[WebKitTestRunnerEvent mouseLocation]):
1543         - This works around a crash on an internal build.
1544
1545 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1546
1547         Fix the build after r243354
1548         https://bugs.webkit.org/show_bug.cgi?id=196138
1549         <rdar://problem/49145951>
1550
1551         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1552         (TEST):
1553         * TestWebKitAPI/ios/UIKitSPI.h:
1554
1555 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1556
1557         Adopt UIWKDocumentContext
1558         https://bugs.webkit.org/show_bug.cgi?id=196040
1559         <rdar://problem/48642440>
1560
1561         Reviewed by Ryosuke Niwa.
1562
1563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1564         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1565         (makeRequest):
1566         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1567         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1568         (applyStyle):
1569         (TEST):
1570         Add tests for UIWKDocumentContext.
1571
1572         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1573         (TEST):
1574         (recursiveFindWKContentView): Deleted.
1575         * TestWebKitAPI/cocoa/TestWKWebView.h:
1576         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1577         (recursiveFindWKContentView):
1578         (-[TestWKWebView wkContentView]):
1579         * TestWebKitAPI/ios/UIKitSPI.h:
1580         Share the WKContentView finding code between tests.
1581
1582 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1583
1584         [iOS WK2] Turn on async overflow scrolling by default
1585         https://bugs.webkit.org/show_bug.cgi?id=196011
1586         rdar://problem/48453859
1587
1588         Reviewed by Antti Koivisto.
1589         
1590         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1591         since so many basic layout tests have different results when compositing is triggered for
1592         overflow.
1593         
1594         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1595
1596         * WebKitTestRunner/TestController.cpp:
1597         (WTR::TestController::resetPreferencesToConsistentValues):
1598
1599 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1600
1601         [ews-build] Retry API test in case of failures
1602         https://bugs.webkit.org/show_bug.cgi?id=196004
1603
1604         Reviewed by Lucas Forschler.
1605
1606         * BuildSlaveSupport/ews-build/steps.py:
1607         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1608         (CompileWebKitToT.doStepIf): Ditto.
1609         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1610         (ReRunAPITests): Re-run API tests.
1611         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1612         (RunAPITestsWithoutPatch): Run API tests without patch.
1613         (RunAPITestsWithoutPatch.doStepIf):
1614         (RunAPITestsWithoutPatch.hideStepIf):
1615         (RunAPITestsWithoutPatch.evaluateCommand):
1616         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1617         (AnalyzeAPITestsResults.start):
1618         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1619         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1620         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1621         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1622
1623 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1624
1625         [ews-build] Update queues configurations
1626         https://bugs.webkit.org/show_bug.cgi?id=196074
1627
1628         Reviewed by Dewei Zhu.
1629
1630         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1631         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1632
1633 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1634
1635         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1636         https://bugs.webkit.org/show_bug.cgi?id=195680
1637         <rdar://problem/48903534>
1638
1639         Unreviewed infrastructure fix.
1640
1641         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1642         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1643
1644 2019-03-21  Andy Estes  <aestes@apple.com>
1645
1646         [iOS] Apple Pay should be available in documents with no user agent scripts
1647         https://bugs.webkit.org/show_bug.cgi?id=196061
1648         <rdar://problem/48649391>
1649
1650         Reviewed by Brady Eidson.
1651
1652         Added API tests and related infrastructure.
1653
1654         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1655         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1656         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1657         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1658         (TestWebKitAPI::TEST):
1659         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1660         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1661         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1662         * TestWebKitAPI/cocoa/TestProtocol.mm:
1663         (-[TestProtocol startLoading]):
1664         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1665         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1666         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1667         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1668
1669 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1670
1671         REGRESSSION (r243297): webkitpy tests broken
1672         https://bugs.webkit.org/show_bug.cgi?id=196108
1673
1674         Reviewed by Aakash Jain.
1675
1676         r243297 updated contributors.json, which broke a few unit tests.
1677
1678         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1679         (IRCCommandTest.test_whois):
1680         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1681
1682 2019-03-21  Chris Dumez  <cdumez@apple.com>
1683
1684         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1685         https://bugs.webkit.org/show_bug.cgi?id=196041
1686         <rdar://problem/49083230>
1687
1688         Reviewed by Alex Christensen.
1689
1690         Add API test coverage.
1691
1692         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1693         (TEST):
1694
1695 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1696
1697         Add SPI to inform applications of WKContentRuleList actions
1698         https://bugs.webkit.org/show_bug.cgi?id=195965
1699         <rdar://problem/42664365>
1700
1701         Reviewed by Geoff Garen.
1702
1703         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1704         (TestWebKitAPI::allActionsForResourceLoad):
1705         (TestWebKitAPI::testRequest):
1706         (TestWebKitAPI::TEST_F):
1707         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1708         (Notification::description):
1709         (Notification::operator== const):
1710         (toVector):
1711         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1712         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1713         (makeContentRuleList):
1714         (TEST):
1715         (makeWarnContentRuleList): Deleted.
1716
1717 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1718
1719         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1720         https://bugs.webkit.org/show_bug.cgi?id=196088
1721
1722         Reviewed by Brian Burg.
1723
1724         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1725         Support checks when only one platform is specified. Also deprecate macosx() and
1726         force the use of macos() instead.
1727
1728         * Scripts/webkitpy/style/checkers/cpp.py:
1729         (check_min_versions_of_wk_api_available):
1730         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1731         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1732
1733 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1734
1735         Update status inactive committers' status to 'contributor'.
1736
1737         * Scripts/webkitpy/common/config/contributors.json:
1738
1739 2019-03-21  Xan Lopez  <xan@igalia.com>
1740
1741         [JSC][x86] Drop support for x87 floating point
1742         https://bugs.webkit.org/show_bug.cgi?id=194853
1743
1744         Reviewed by Don Olmstead.
1745
1746         Force SSE2 on x86/32bit builds.
1747
1748         * Scripts/webkitdirs.pm:
1749         (generateBuildSystemFromCMakeProject):
1750
1751 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1752
1753         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1754         https://bugs.webkit.org/show_bug.cgi?id=196073
1755
1756         Reviewed by Michael Catanzaro.
1757
1758         Add test cases to check functions and constructors with no arguments but receiving user data.
1759
1760         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1761         (checkUserData):
1762         (testJSCFunction):
1763         (fooCreateWithUserData):
1764         (testJSCClass):
1765
1766 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1767
1768         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1769
1770         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1771
1772         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1773
1774 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1775
1776         [GTK][WPE] Add API to provide geolocation information
1777         https://bugs.webkit.org/show_bug.cgi?id=195940
1778
1779         Reviewed by Michael Catanzaro.
1780
1781         Add a new test to check the new API.
1782
1783         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1784         (testGeolocationManagerCurrentPosition):
1785         (testGeolocationManagerWatchPosition):
1786         (beforeAll):
1787         (afterAll):
1788         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1789         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1790         (beforeAll): Ditto.
1791         * TestWebKitAPI/glib/CMakeLists.txt:
1792
1793 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1794
1795         [GLib] Returning G_TYPE_OBJECT from a method does not work
1796         https://bugs.webkit.org/show_bug.cgi?id=195574
1797
1798         Reviewed by Michael Catanzaro.
1799
1800         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1801
1802         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1803         (getGFile):
1804         (getParent):
1805         (createGString):
1806         (getGString):
1807         (getGStringCopyWillRaise):
1808         (getGStringCopy):
1809         (getGStringStr):
1810         (getGStringLen):
1811         (freeGString):
1812         (testJSCClass):
1813
1814 2019-03-20  Saam Barati  <sbarati@apple.com>
1815
1816         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1817         https://bugs.webkit.org/show_bug.cgi?id=195721
1818
1819         Reviewed by Filip Pizlo.
1820
1821         * Scripts/run-javascriptcore-tests:
1822
1823 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1824
1825         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1826         https://bugs.webkit.org/show_bug.cgi?id=196049
1827
1828         Reviewed by Tim Horton.
1829
1830         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1831         overflow scrolling in general, so rename it.
1832
1833         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1834
1835 2019-03-20  Daniel Bates  <dabates@apple.com>
1836
1837         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1838         https://bugs.webkit.org/show_bug.cgi?id=196031
1839         <rdar://problem/49078172>
1840
1841         Reviewed by Tim Horton.
1842
1843         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1844         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1845         same code path used when the Done button is pressed to dismiss the <select> picker.
1846
1847         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1848         (TestWebKitAPI::TEST):
1849
1850 2019-03-20  Chris Dumez  <cdumez@apple.com>
1851
1852         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1853         https://bugs.webkit.org/show_bug.cgi?id=196029
1854         <rdar://problem/48954651>
1855
1856         Reviewed by Tim Horton.
1857
1858         Add API test coverage.
1859
1860         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1861
1862 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1863
1864         [ews-build] Improve failure summary string for ApplyPatch step
1865         https://bugs.webkit.org/show_bug.cgi?id=195995
1866
1867         Reviewed by Alexey Proskuryakov.
1868
1869         * BuildSlaveSupport/ews-build/steps.py:
1870         (ApplyPatch.getResultSummary): Override getResultSummary.
1871
1872 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1873
1874         AX: Implement support for new meter ARIA role
1875         https://bugs.webkit.org/show_bug.cgi?id=195966
1876
1877         Reviewed by Chris Fleizach.
1878
1879         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1880         to AXLevelIndicator.
1881
1882         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1883
1884 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1885
1886         [WebAuthN] Implement FIDO AppID extension
1887         https://bugs.webkit.org/show_bug.cgi?id=143491
1888         <rdar://problem/48298273>
1889
1890         Reviewed by Brent Fulgham.
1891
1892         Add a test that covers the new flag of convertToU2fSignCommand.
1893
1894         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1895         (TestWebKitAPI::TEST):
1896         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1897         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1898         (TestWebKitAPI::TEST):
1899
1900 2019-03-19  Keith Rollin  <krollin@apple.com>
1901
1902         Add support for more platforms to generate-xcfilelists
1903         https://bugs.webkit.org/show_bug.cgi?id=195977
1904
1905         Reviewed by Alexey Proskuryakov.
1906
1907         generate-xcfilelists incorrectly complains when involved with building
1908         WebKit for iphonesimulator:
1909
1910             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1911             …
1912             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1913
1914         Address this by teaching generate-xcfilelists about more platforms.
1915
1916         * Scripts/generate-xcfilelists:
1917
1918 2019-03-19  John Wilander  <wilander@apple.com>
1919
1920         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1921         https://bugs.webkit.org/show_bug.cgi?id=195923
1922         <rdar://problem/49001272>
1923
1924         Reviewed by Alex Christensen.
1925
1926         This patch does the following to the TestRunner:
1927         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1928         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1929         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1930
1931         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1932         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1933         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1934         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1935         * WebKitTestRunner/TestController.cpp:
1936         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1937         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1938         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1939         * WebKitTestRunner/TestController.h:
1940         * WebKitTestRunner/TestInvocation.cpp:
1941         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1942
1943 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1944
1945         [CMake] Support more clang and gcc sanitizers
1946         https://bugs.webkit.org/show_bug.cgi?id=195956
1947
1948         Reviewed by Michael Catanzaro.
1949
1950         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1951
1952 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1953
1954         [ews-build] Improve summary for PrintConfiguration step
1955         https://bugs.webkit.org/show_bug.cgi?id=195945
1956
1957         Reviewed by Lucas Forschler.
1958
1959         * BuildSlaveSupport/ews-build/steps.py:
1960         (PrintConfiguration.getResultSummary): Override getResultSummary.
1961
1962 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1963
1964         [ews-build] Improve summary for CheckOutSource step
1965         https://bugs.webkit.org/show_bug.cgi?id=195963
1966
1967         Reviewed by Lucas Forschler.
1968
1969         * BuildSlaveSupport/ews-build/steps.py:
1970         (CheckOutSource.getResultSummary):
1971
1972 2019-03-19  Daniel Bates  <dabates@apple.com>
1973
1974         [iOS] Focus not preserved when switching between tabs
1975         https://bugs.webkit.org/show_bug.cgi?id=195820
1976         <rdar://problem/43614450>
1977
1978         Reviewed by Brent Fulgham.
1979
1980         Add tests to ensure that we restore focus when resigning and becoming first responder.
1981
1982         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1983         (TestWebKitAPI::TEST):
1984
1985 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1986
1987         Make WTFLogChannelState and WTFLogLevel enum classes
1988         https://bugs.webkit.org/show_bug.cgi?id=195904
1989
1990         Reviewed by Eric Carlson.
1991
1992         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1993         (TestWebKitAPI::TEST_F):
1994
1995 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1996
1997         [GStreamer][EME] Backported mssdemux protection data crash fix
1998         https://bugs.webkit.org/show_bug.cgi?id=195918
1999
2000         Reviewed by Philippe Normand.
2001
2002         * gstreamer/jhbuild.modules:
2003         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2004
2005 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2006
2007         Unreviewed, rolling out r243132.
2008
2009         Broke GTK build
2010
2011         Reverted changeset:
2012
2013         "Make WTFLogChannelState and WTFLogLevel enum classes"
2014         https://bugs.webkit.org/show_bug.cgi?id=195904
2015         https://trac.webkit.org/changeset/243132
2016
2017 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2018
2019         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2020
2021         * Scripts/webkitdirs.pm:
2022         (builtDylibPathForName): Adjust the shared library name that's changed
2023         with the API version bump in r243073.
2024
2025 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2026
2027         Make WTFLogChannelState and WTFLogLevel enum classes
2028         https://bugs.webkit.org/show_bug.cgi?id=195904
2029
2030         Reviewed by Eric Carlson.
2031
2032         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2033         (TestWebKitAPI::TEST_F):
2034
2035 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2036
2037         Disable flaky test added in r2431100
2038         https://webkit.org/b/195785
2039
2040         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2041         (TestWebKitAPI::TEST):
2042         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2043
2044 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2045
2046         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2047         https://bugs.webkit.org/show_bug.cgi?id=195916
2048
2049         Reviewed by Tim Horton.
2050
2051         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2052         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2053
2054 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2055
2056         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2057
2058         * Scripts/webkitpy/common/config/contributors.json:
2059
2060 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2061
2062         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2063         https://bugs.webkit.org/show_bug.cgi?id=195785
2064
2065         Reviewed by Geoffrey Garen.
2066
2067         * TestWebKitAPI/TCPServer.cpp: Added.
2068         (TestWebKitAPI::TCPServer::TCPServer):
2069         (TestWebKitAPI::TCPServer::~TCPServer):
2070         (TestWebKitAPI::TCPServer::socketBindListen):
2071         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2072         * TestWebKitAPI/TCPServer.h: Added.
2073         (TestWebKitAPI::TCPServer::port const):
2074         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2075         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2076         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2077         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2078         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2079         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2080         (TestWebKitAPI::respondSlowly):
2081         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2082         (TestWebKitAPI::downloadAtRate):
2083         (TestWebKitAPI::TEST):
2084
2085 2019-03-18  Saam Barati  <sbarati@apple.com>
2086
2087         Add a plan file for JetStream 2
2088         https://bugs.webkit.org/show_bug.cgi?id=190734
2089
2090         Reviewed by Mark Lam.
2091
2092         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2093
2094 2019-03-18  Chris Dumez  <cdumez@apple.com>
2095
2096         Delay WebProcess launch until a load is triggered in a Web view
2097         https://bugs.webkit.org/show_bug.cgi?id=195758
2098         <rdar://problem/48126013>
2099
2100         Reviewed by Geoff Garen.
2101
2102         Add API test coverage. Also update some existing API tests to not expect
2103         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2104
2105         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2106         (TestWebKitAPI::TEST):
2107         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2108         (TestWebKitAPI::TEST):
2109         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2110         (TEST):
2111         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2112         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2113         (TEST):
2114         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2115         (TEST):
2116         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2117
2118 2019-03-18  Xan Lopez  <xan@igalia.com>
2119
2120         [CMake] Prevent potential warning when determining $architecture
2121         https://bugs.webkit.org/show_bug.cgi?id=195891
2122
2123         Reviewed by Michael Catanzaro.
2124
2125         It's possible for generateBuildSystemForCMakeProject to be called
2126         before determineArchitecture() is ever called. This will make the
2127         first eq check with $architecture to be bogus (and print a
2128         warning). Change that to an eq check with architecture(), which
2129         implicitly calls determineArchitecture() if needed, and change all
2130         the other similar cases in the method in the same way to prevent
2131         future bugs like this one.
2132
2133         * Scripts/webkitdirs.pm:
2134         (generateBuildSystemFromCMakeProject):
2135
2136 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2137
2138         [WPE] Tarballs generated with “make dist” cannot build documentation
2139         https://bugs.webkit.org/show_bug.cgi?id=195885
2140
2141         Reviewed by Carlos Garcia Campos.
2142
2143         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2144
2145 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2146
2147         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2148         https://bugs.webkit.org/show_bug.cgi?id=195883
2149
2150         Reviewed by Carlos Garcia Campos.
2151
2152         * gtkdoc/gtkdoc.py:
2153         (GTKDoc._run_command): When commands fail to run, include the full command line for
2154         the program invocation and the output it has generated on the standard error stream.
2155
2156 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2157
2158         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2159         https://bugs.webkit.org/show_bug.cgi?id=195786
2160
2161         Reviewed by Philippe Normand.
2162
2163         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2164         * wpe/jhbuild.modules: Ditto.
2165
2166 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2167
2168         [ews-build] Don't run clean builds on EWS builders
2169         https://bugs.webkit.org/show_bug.cgi?id=195851
2170
2171         Reviewed by Geoffrey Garen.
2172
2173         * BuildSlaveSupport/ews-build/factories.py:
2174
2175 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2176
2177         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2178         https://bugs.webkit.org/show_bug.cgi?id=195849
2179
2180         Reviewed by Chris Dumez.
2181
2182         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2183
2184         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2185         (runWebsiteDataStoreCustomPaths):
2186
2187 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2188
2189         webkitpy: Upload test results
2190         https://bugs.webkit.org/show_bug.cgi?id=195755
2191         <rdar://problem/48896182>
2192
2193         Reviewed by Aakash Jain.
2194
2195         Establish a new format for uploading results that is not tied to layout tests, apply
2196         that format to webkitpy tests.
2197
2198         * Scripts/webkitpy/common/checkout/scm/git.py:
2199         (Git.native_branch): Return what branch the current checkout is on.
2200         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2201         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2202         * Scripts/webkitpy/common/checkout/scm/svn.py:
2203         (SVN.native_branch): Ditto.
2204         * Scripts/webkitpy/common/system/platforminfo.py:
2205         (PlatformInfo.build_version): Return a build version for Mac.
2206         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2207         (MockPlatformInfo.__init__):
2208         (MockPlatformInfo.build_version):
2209         * Scripts/webkitpy/results: Added.
2210         * Scripts/webkitpy/results/__init__.py: Added.
2211         * Scripts/webkitpy/results/options.py: Added.
2212         (upload_options): OptParse list for upload options.
2213         * Scripts/webkitpy/results/upload.py: Added.
2214         (Upload): Class which enforces the upload format expected by the results server.
2215         (Upload.Expectations):
2216         (Upload.create_configuration):
2217         (Upload.create_commit):
2218         (Upload.create_details):
2219         (Upload.create_run_stats):
2220         (Upload.create_test_result):
2221         (Upload.__init__):
2222         (Upload.Encoder): Encode Upload object as json.
2223         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2224         * Scripts/webkitpy/results/upload_unittest.py: Added.
2225         * Scripts/webkitpy/test/main.py:
2226         (Tester._parse_args): Add upload arguments.
2227         (Tester._run_tests): Allow results to be uploaded.
2228         * Scripts/webkitpy/test/runner.py:
2229         (Runner.__init__): Record which tests were run, rather than just counting them.
2230         (Runner.handle):
2231         * Scripts/webkitpy/test/runner_unittest.py:
2232         (RunnerTest.test_run):
2233         * Scripts/webkitpy/thirdparty/__init__.py:
2234         (AutoinstallImportHook.find_module): Add requests auto-install.
2235         (AutoinstallImportHook._install_requests):
2236         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2237         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2238
2239 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2240
2241         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2242         https://bugs.webkit.org/show_bug.cgi?id=195810
2243
2244         Reviewed by Tim Horton.
2245
2246         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2247         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2248         ending certain layout tests.
2249
2250         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2251         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2252         (-[TestRunnerWKWebView dealloc]):
2253         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2254
2255         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2256         helper method when destroying the web view, and when resetting state between tests.
2257
2258         * WebKitTestRunner/ios/TestControllerIOS.mm:
2259         (WTR::TestController::platformResetStateToConsistentValues):
2260
2261         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2262
2263 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2264
2265         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2266         https://bugs.webkit.org/show_bug.cgi?id=190350
2267         <rdar://problem/45089503>
2268
2269         Reviewed by Geoffrey Garen.
2270
2271         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2272         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2273         (TEST):
2274         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2275         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2276         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2277         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2278         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2279         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2280         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2281         (runTest):
2282         (createDirectories):
2283         (TEST):
2284         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2285         (TEST):
2286         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2287         (TEST):
2288
2289 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2290
2291         Add support to WebPage for getting the contents as an attributed string.
2292         https://bugs.webkit.org/show_bug.cgi?id=195636
2293         rdar://problem/45055697
2294
2295         Reviewed by Tim Horton.
2296
2297         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2298         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2299
2300 2019-03-15  Chris Dumez  <cdumez@apple.com>
2301
2302         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2303         https://bugs.webkit.org/show_bug.cgi?id=195747
2304
2305         Reviewed by Geoff Garen.
2306
2307         Add API test coverage.
2308
2309         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2310
2311 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2312
2313         Unreviewed, rolling out r242952.
2314
2315         Causing API failures on iOS Simulator
2316
2317         Reverted changeset:
2318
2319         "[PSON] Make sure the WebProcessCache is leverage when
2320         relaunching a process after termination"
2321         https://bugs.webkit.org/show_bug.cgi?id=195747
2322         https://trac.webkit.org/changeset/242952
2323
2324 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2325
2326         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2327         https://bugs.webkit.org/show_bug.cgi?id=195740
2328
2329         Reviewed by Ross Kirsling.
2330
2331         window.open doesn't work for WebKitBrowserWindow because it is not
2332         implemented yet.
2333
2334         1. Implemented createNewPage callback of WKPageUIClient.
2335         2. Changed MainWindow to take a BrowserWindow factory function
2336           instead of BrowserWindowType to be flexible to create
2337           BrowserWindow with extra settings.
2338         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2339           because it is not relevant with MainWindow anymore.
2340
2341         * MiniBrowser/win/Common.cpp:
2342         (parseCommandLine):
2343         * MiniBrowser/win/Common.h:
2344         (CommandLineOptions::CommandLineOptions):
2345         * MiniBrowser/win/MainWindow.cpp:
2346         (MainWindow::MainWindow):
2347         (MainWindow::create):
2348         (MainWindow::init):
2349         (MainWindow::WndProc):
2350         * MiniBrowser/win/MainWindow.h:
2351         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2352         (PrintWebUIDelegate::createWebViewWithRequest):
2353         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2354         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2355         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2356         (WebKitBrowserWindow::updateProxySettings):
2357         (WebKitBrowserWindow::createNewPage):
2358         * MiniBrowser/win/WebKitBrowserWindow.h:
2359         * MiniBrowser/win/WinMain.cpp:
2360         (wWinMain):
2361
2362 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2363
2364         Make it possible to test scrolling tree layer manipulation more easily
2365         https://bugs.webkit.org/show_bug.cgi?id=195780
2366
2367         Reviewed by Tim Horton.
2368         
2369         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2370         cuts off communication of scrolling tree scrolls back to the web process
2371         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2372         allows tests to trigger scrolls which run the scrolling tree layer positioning
2373         logic, but never get another commit from the web process that might mask
2374         scrolling tree bugs.
2375         
2376         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2377         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2378         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2379
2380         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2381         (WTR::UIScriptController::scrollUpdatesDisabled const):
2382         (WTR::UIScriptController::setScrollUpdatesDisabled):
2383         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2384         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2385         (WTR::UIScriptController::scrollUpdatesDisabled const):
2386         (WTR::UIScriptController::setScrollUpdatesDisabled):
2387         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2388         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2389         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2390         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2391         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2392         * WebKitTestRunner/ios/TestControllerIOS.mm:
2393         (WTR::TestController::platformResetStateToConsistentValues):
2394         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2395         (WTR::UIScriptController::scrollUpdatesDisabled const):
2396         (WTR::UIScriptController::setScrollUpdatesDisabled):
2397
2398 2019-03-14  Youenn Fablet  <youenn@apple.com>
2399
2400         Move IDB storage in private browsing mode to NetworkProcess
2401         https://bugs.webkit.org/show_bug.cgi?id=195602
2402
2403         Reviewed by Brady Eidson.
2404
2405         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2406         (TEST):
2407
2408 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2409
2410         [ews-build] Make descriptionDone messages more readable
2411         https://bugs.webkit.org/show_bug.cgi?id=195760
2412
2413         Reviewed by Lucas Forschler.
2414
2415         * BuildSlaveSupport/ews-build/steps.py:
2416         * BuildSlaveSupport/ews-build/steps_unittest.py:
2417
2418 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2419
2420         [ews-build] Generate status-bubble hover-over messages
2421         https://bugs.webkit.org/show_bug.cgi?id=195680
2422
2423         Reviewed by Lucas Forschler.
2424
2425         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2426         (StatusBubble):
2427         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2428         on hover-over.
2429         (StatusBubble._iso_time):
2430         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2431         hover-over message.
2432         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2433
2434 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2435
2436         [ews-app] Gracefully handle the case when state_string is None
2437         https://bugs.webkit.org/show_bug.cgi?id=195753
2438
2439         Reviewed by Lucas Forschler.
2440
2441         * BuildSlaveSupport/ews-app/ews/models/build.py:
2442         * BuildSlaveSupport/ews-app/ews/models/step.py:
2443
2444 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2445
2446         [ews-app] Status bubble display pending for currently running build step
2447         https://bugs.webkit.org/show_bug.cgi?id=195744
2448
2449         Reviewed by Lucas Forschler.
2450
2451         * BuildSlaveSupport/ews-build/events.py:
2452         (Events.stepStarted): If state_string is pending, replace it with step name.
2453
2454 2019-03-14  Chris Dumez  <cdumez@apple.com>
2455
2456         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2457         https://bugs.webkit.org/show_bug.cgi?id=195750
2458
2459         Reviewed by Geoffrey Garen.
2460
2461         Add API test coverage.
2462
2463         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2464         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2465         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2466         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2467
2468 2019-03-14  Chris Dumez  <cdumez@apple.com>
2469
2470         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2471         https://bugs.webkit.org/show_bug.cgi?id=195747
2472
2473         Reviewed by Geoff Garen.
2474
2475         Add API test coverage.
2476
2477         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2478
2479 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2480
2481         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2482         https://bugs.webkit.org/show_bug.cgi?id=195725
2483         <rdar://problem/48545062>
2484
2485         Reviewed by Tim Horton.
2486
2487         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2488         handler is nil.
2489
2490         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2491         (TestWebKitAPI::TEST):
2492
2493 2019-03-13  Sam Weinig  <sam@webkit.org>
2494
2495         Add utility function to allow easy reverse range-based iteration of a container
2496         https://bugs.webkit.org/show_bug.cgi?id=195542
2497
2498         Reviewed by Antti Koivisto.
2499
2500         * TestWebKitAPI/CMakeLists.txt:
2501         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2502         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2503         (TestWebKitAPI::TEST):
2504         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2505
2506 2019-03-13  Chris Dumez  <cdumez@apple.com>
2507
2508         Use a ServiceWorker process per registrable domain
2509         https://bugs.webkit.org/show_bug.cgi?id=195649
2510
2511         Reviewed by Youenn Fablet.
2512
2513         Update API test coverage.
2514
2515         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2516
2517 2019-03-13  Chris Dumez  <cdumez@apple.com>
2518
2519         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2520         https://bugs.webkit.org/show_bug.cgi?id=195684
2521         <rdar://problem/48294714>
2522
2523         Reviewed by Antti Koivisto.
2524
2525         Add API test coverage.
2526
2527         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2528
2529 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2530
2531         [ews-app] Remove unused patch view
2532         https://bugs.webkit.org/show_bug.cgi?id=195669
2533
2534         Reviewed by Lucas Forschler.
2535
2536         * BuildSlaveSupport/ews-app/ews/urls.py:
2537         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2538
2539 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2540
2541         [ews-app] Use Buildbot result code variables
2542         https://bugs.webkit.org/show_bug.cgi?id=195668
2543
2544         Reviewed by Alexey Proskuryakov.
2545
2546         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2547         (Buildbot): Added Buildbot result code variables.
2548         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2549         (StatusBubble._build_bubble): Used Buildbot result code variables.
2550
2551 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2552
2553         [Flatpak] Expand submodule recursively
2554         https://bugs.webkit.org/show_bug.cgi?id=195672
2555
2556         Building WPE with flatpak was impossible without that as it was raising an exception.
2557         Also update wpebackend-fdo to match what is built in jhbuild
2558
2559         Reviewed by Philippe Normand.
2560
2561         * flatpak/flatpakutils.py:
2562         (expand_submodules_recurse):
2563         (expand_manifest):
2564         * flatpak/org.webkit.WPEModules.yaml:
2565
2566 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2567
2568         [ews-app] status bubble should be hidden for certain builds
2569         https://bugs.webkit.org/show_bug.cgi?id=194597
2570
2571         Reviewed by Dewei Zhu.
2572
2573         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2574         (StatusBubble._build_bubble):
2575         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2576         because the patch didn't have relevant changes.
2577         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2578         in production yet.
2579
2580 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2581
2582         [Win] Fix a slew of simple clang-cl warnings.
2583         https://bugs.webkit.org/show_bug.cgi?id=195652
2584
2585         Reviewed by Don Olmstead.
2586
2587         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2588         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2589
2590 2019-03-12  Justin Fan  <justin_fan@apple.com>
2591
2592         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2593         https://bugs.webkit.org/show_bug.cgi?id=195518
2594         <rdar://problem/46322356>
2595
2596         Reviewed by Myles C. Maxfield.
2597
2598         * DumpRenderTree/DerivedSources-input.xcfilelist:
2599         * DumpRenderTree/DerivedSources-output.xcfilelist:
2600
2601 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2602
2603         Unreviewed, rolling out r242825.
2604         https://bugs.webkit.org/show_bug.cgi?id=195648
2605
2606         "Broke webkitpy tests with my change to
2607         lldb_dump_class_layout.py" (Requested by rmorisset on
2608         #webkit).
2609
2610         Reverted changeset:
2611
2612         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2613         classes with suspicious padding"
2614         https://bugs.webkit.org/show_bug.cgi?id=195573
2615         https://trac.webkit.org/changeset/242825
2616
2617 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2618
2619         [ews-build] Show status bubbles while the patch is waiting in queue
2620         https://bugs.webkit.org/show_bug.cgi?id=195618
2621
2622         Reviewed by Lucas Forschler.
2623
2624         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2625         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2626         enabled in initial deployment.
2627         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2628         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2629         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2630         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2631         (StatusBubble._build_bubbles_for_patch):
2632
2633 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2634
2635         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2636         https://bugs.webkit.org/show_bug.cgi?id=195573
2637
2638         Reviewed by Simon Fraser.
2639
2640         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2641
2642         * Scripts/dump-class-layout:
2643         (main):
2644         * lldb/lldb_dump_class_layout.py:
2645         (ClassLayout.__init__):
2646         (ClassLayout._compute_padding_recursive):
2647         (LLDBDebuggerInstance.dump_layout_for_classname):
2648         (LLDBDebuggerInstance):
2649         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2650         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2651
2652 2019-03-12  Chris Dumez  <cdumez@apple.com>
2653
2654         Device Orientation access permission should be denied unless explicitly granted by the client
2655         https://bugs.webkit.org/show_bug.cgi?id=195625
2656
2657         Reviewed by Youenn Fablet.
2658
2659         add API test coverage.
2660
2661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2662         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2663         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2664         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2665         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2666         (runDeviceOrientationTest):
2667         (TEST):
2668         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2669         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2670
2671 2019-03-12  Jer Noble  <jer.noble@apple.com>
2672
2673         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2674         https://bugs.webkit.org/show_bug.cgi?id=195137
2675         <rdar://problem/48810307>
2676
2677         Reviewed by Eric Carlson.
2678
2679         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2680         (TestWebKitAPI::TEST):
2681
2682 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2683
2684         [ews-build] Change urls from uat to production
2685         https://bugs.webkit.org/show_bug.cgi?id=195566
2686
2687         Reviewed by Lucas Forschler.
2688
2689         * BuildSlaveSupport/ews-app/ews/config.py:
2690         * BuildSlaveSupport/ews-build/events.py:
2691         * BuildSlaveSupport/ews-build/steps.py:
2692
2693 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2694
2695         [ews-build] change max_builds for local-worker to 1
2696         https://bugs.webkit.org/show_bug.cgi?id=195568
2697
2698         Reviewed by Lucas Forschler.
2699
2700         * BuildSlaveSupport/ews-build/loadConfig.py:
2701
2702 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2703
2704         Fix the build
2705
2706         * TestRunnerShared/spi/PencilKitTestSPI.h:
2707         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2708
2709 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2710
2711         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2712         https://bugs.webkit.org/show_bug.cgi?id=194131
2713
2714         Reviewed by Michael Catanzaro.
2715
2716         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2717         (uriChanged):
2718         (testUnfinishedSubresourceLoad):
2719         (serverCallback):
2720         (beforeAll):
2721
2722 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2723
2724         WTF::Expected should use std::addressof instead of operator&
2725         https://bugs.webkit.org/show_bug.cgi?id=195604
2726
2727         Reviewed by Myles Maxfield.
2728
2729         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2730         (TestWebKitAPI::Unique::Unique):
2731         (TestWebKitAPI::Unique::operator&):
2732         (TestWebKitAPI::TEST):
2733
2734 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2735
2736         Add Optional to Forward.h.
2737         https://bugs.webkit.org/show_bug.cgi?id=195586
2738
2739         Reviewed by Darin Adler.
2740
2741         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2742         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2743         Remove unnecessary includes from headers.
2744
2745 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2746
2747         Add testing API to hit-test and scroll overflow scrollers
2748         https://bugs.webkit.org/show_bug.cgi?id=195278
2749
2750         Reviewed by Antti Koivisto.
2751         
2752         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2753         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2754         
2755         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2756
2757         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2758         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2759         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2760         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2761         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2762         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2763         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2764         (WTR::enclosingScrollViewIncludingSelf):
2765         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2766
2767 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2768
2769         API test WebKit.RequestTextInputContext fails on iOS
2770         https://bugs.webkit.org/show_bug.cgi?id=195585
2771
2772         Reviewed by Wenson Hsieh and Simon Fraser.
2773
2774         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2775         (applyStyle):
2776         (TEST):
2777         Add a viewport, so that the coordinates match up on iOS.
2778         Scroll by moving the UIScrollView's contentOffset.
2779
2780 2019-03-11  Chris Dumez  <cdumez@apple.com>
2781
2782         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2783         https://bugs.webkit.org/show_bug.cgi?id=195506
2784         <rdar://problem/48733477>
2785
2786         Reviewed by Alex Christensen.
2787
2788         Add API test coverage.
2789
2790         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2791
2792 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2793
2794         Adding myself to contributors.json
2795
2796         Unreviewed, addming myself to contributors.json .
2797
2798         * Scripts/webkitpy/common/config/contributors.json:
2799
2800 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2801
2802         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2803         https://bugs.webkit.org/show_bug.cgi?id=195511
2804         <rdar://problem/44873269>
2805
2806         Reviewed by Darin Adler.
2807
2808         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2809         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2810         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2811         (TEST_F):
2812
2813 2019-03-11  Chris Dumez  <cdumez@apple.com>
2814
2815         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2816         https://bugs.webkit.org/show_bug.cgi?id=195561
2817
2818         Reviewed by Youenn Fablet.
2819
2820         Make sure the JS in the test requests for permission to receive device orientation events.
2821
2822         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2823
2824 2019-03-11  Youenn Fablet  <youenn@apple.com>
2825
2826         Allow storage quota increase by default in WTR
2827         https://bugs.webkit.org/show_bug.cgi?id=195541
2828
2829         Reviewed by Geoffrey Garen.
2830
2831         Allow storage quota increase by default in WTR.
2832         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2833         Use this for tests that explicitly need cache increase.
2834
2835         Instead of increasing quota by 2, make sure the next request is
2836         granted by adding all given parameters.
2837
2838         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2839         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2840         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2841         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2842         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2843         * WebKitTestRunner/TestController.cpp:
2844         (WTR::TestController::setAllowStorageQuotaIncrease):
2845         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2846         * WebKitTestRunner/TestController.h:
2847         * WebKitTestRunner/TestInvocation.cpp:
2848         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2849         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2850         (WTR::TestController::cocoaResetStateToConsistentValues):
2851         (WTR::TestController::setAllowStorageQuotaIncrease):
2852         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2853         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2854         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2855
2856 2019-03-11  Xan Lopez  <xan@igalia.com>
2857
2858         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2859         https://bugs.webkit.org/show_bug.cgi?id=194147
2860
2861         Reviewed by Michael Saboff.
2862
2863         To make --32-bit work correctly on Linux/64bit we need to:
2864
2865         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2866         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2867         unfortunately CMake only allows us to do this during
2868         crosscompilation, which is overkill here.
2869         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2870         pkg-config detection module uses the x86 .pc files instead of the
2871         x86_64 ones.
2872         - Set the -m32 flags for the compiler.
2873
2874         * Scripts/webkitdirs.pm:
2875         (generateBuildSystemFromCMakeProject):
2876
2877 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2878
2879         Add MotionMark-1.1 plan file for run-benchmark script.
2880         https://bugs.webkit.org/show_bug.cgi?id=195481
2881
2882         Rubber-stamped by Darin Adler.
2883
2884         Run-benchmark script should support MontionMark-1.1.
2885
2886         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2887
2888 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2889
2890         [ews-app] Add support for submit-to-ews url
2891         https://bugs.webkit.org/show_bug.cgi?id=195477
2892
2893         Reviewed by Lucas Forschler.
2894
2895         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2896         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2897         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2898         * BuildSlaveSupport/ews-app/ews/urls.py:
2899         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2900
2901 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2902
2903         Unreviewed, rolling out r242688, r242643, r242624.
2904
2905         Caused multiple layout test failures and crashes on iOS and macOS.
2906
2907         Reverted changeset:
2908
2909         "requestAnimationFrame should execute before the next frame"
2910         https://bugs.webkit.org/show_bug.cgi?id=177484
2911         https://trac.webkit.org/changeset/242624/webkit
2912
2913         * Tracing/SystemTracePoints.plist:
2914
2915 2019-03-11  John Wilander  <wilander@apple.com>
2916
2917         Resource Load Statistics: Make it possible exclude localhost from classification
2918         https://bugs.webkit.org/show_bug.cgi?id=195474
2919         <rdar://problem/47520577>
2920
2921         Reviewed by Brent Fulgham.
2922
2923         This patch allows for localhost to be excluded from classification and
2924         treatment as a prevalent resource.
2925
2926         The WebKit Tools change adds a new function called
2927         testRunner.setStatisticsIsRunningTest() which can be used to control this
2928         behavior.
2929
2930         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2931         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2932         (WTR::TestRunner::setStatisticsIsRunningTest):
2933         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2934         * WebKitTestRunner/TestController.cpp:
2935         (WTR::TestController::setStatisticsIsRunningTest):
2936         * WebKitTestRunner/TestController.h:
2937         * WebKitTestRunner/TestInvocation.cpp:
2938         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2939
2940 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2941
2942         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2943         https://bugs.webkit.org/show_bug.cgi?id=195560
2944
2945         Reviewed by Lucas Forschler.
2946
2947         * BuildSlaveSupport/ews-build/master.cfg:
2948
2949 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2950
2951         Unreviewed, rolling out r242698.
2952
2953         API test crashes on bots.
2954
2955         Reverted changeset:
2956
2957         "Add a WKContentRuleList variant that uses copied memory
2958         instead of mmap'd shared memory for class A containerized
2959         apps"
2960         https://bugs.webkit.org/show_bug.cgi?id=195511
2961         https://trac.webkit.org/changeset/242698
2962
2963 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2964
2965         [WPE] Enable web process sandbox
2966         https://bugs.webkit.org/show_bug.cgi?id=195169
2967
2968         Reviewed by Daniel Bates.
2969
2970         * wpe/install-dependencies:
2971         * wpe/jhbuild.modules:
2972
2973 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2974
2975         [ews-app] Use port 17000 for worker communication
2976         https://bugs.webkit.org/show_bug.cgi?id=195558
2977
2978         Reviewed by Lucas Forschler.
2979
2980         * BuildSlaveSupport/ews-build/master.cfg:
2981
2982 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2983
2984         [ews-build] unit-tests fail when passwords.json is missing
2985         https://bugs.webkit.org/show_bug.cgi?id=195557
2986
2987         Reviewed by Lucas Forschler.
2988
2989         * BuildSlaveSupport/ews-build/loadConfig.py:
2990         (loadBuilderConfig):
2991         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2992         (ConfigDotJSONTest.test_configuration):
2993         * BuildSlaveSupport/ews-build/master.cfg:
2994
2995 2019-03-11  Truitt Savell  <tsavell@apple.com>
2996
2997         Unreviewed, rolling out r242702.
2998
2999         Broke High Sierra builders.
3000
3001         Reverted changeset:
3002
3003         "Add utility function to allow easy reverse range-based
3004         iteration of a container"
3005         https://bugs.webkit.org/show_bug.cgi?id=195542
3006         https://trac.webkit.org/changeset/242702
3007
3008 2019-03-11  Sam Weinig  <sam@webkit.org>
3009
3010         Add utility function to allow easy reverse range-based iteration of a container
3011         https://bugs.webkit.org/show_bug.cgi?id=195542
3012
3013         Reviewed by Antti Koivisto.
3014
3015         * TestWebKitAPI/CMakeLists.txt:
3016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3017         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3018         (TestWebKitAPI::TEST):
3019         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3020
3021 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3022
3023         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3024         https://bugs.webkit.org/show_bug.cgi?id=195511
3025         <rdar://problem/44873269>
3026
3027         Reviewed by Darin Adler.
3028
3029         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3030         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3031         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3032         (TEST_F):
3033
3034 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3035
3036         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3037         https://bugs.webkit.org/show_bug.cgi?id=195499
3038
3039         Reviewed by Darin Adler.
3040
3041         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3042         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3043         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3044         (-[WKWebView synchronouslyFocusTextInputContext:]):
3045         (applyStyle):
3046         (applyIframe):
3047         (TEST):
3048         Add some tests for this SPI.
3049
3050 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3051
3052         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3053         https://bugs.webkit.org/show_bug.cgi?id=181151
3054
3055         Reviewed by Don Olmstead.
3056
3057         * TestWebKitAPI/CMakeLists.txt:
3058         * TestWebKitAPI/PlatformWin.cmake:
3059         Enable TestWTF RunLoop tests in all platforms.
3060
3061         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3062         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3063         (TestWebKitAPI::DerivedOneShotTimer::fired):
3064         (TestWebKitAPI::TEST):
3065         Only a few platforms support nested RunLoop.
3066
3067         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3068         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3069
3070 2019-03-10  David Quesada  <david_quesada@apple.com>
3071
3072         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3073         https://bugs.webkit.org/show_bug.cgi?id=152480
3074
3075         Reviewed by Chris Dumez.
3076
3077         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3078         there are no additional references to the process pool besides the one held by
3079         the download, waits for the download to finish (in the sense that the
3080         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3081         measure, also check that the process pool has been deallocated at the end of the
3082         test. The test wouldn't be meaningful if the process pool were still alive.
3083
3084         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3085         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3086         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3087             The download will be canceled because the delegate does not implement the
3088             method to decide the download's destination, so this is where we know the
3089             DownloadProxyMap is done with the DownloadProxy.
3090         (TEST):
3091
3092 2019-03-08  Chris Dumez  <cdumez@apple.com>
3093
3094         Add support for Device Orientation / Motion permission API
3095         https://bugs.webkit.org/show_bug.cgi?id=195329
3096         <rdar://problem/47645367>
3097
3098         Reviewed by Geoffrey Garen.
3099
3100         Add test infrastructure to help test the Device Orientation / Motion permission API.
3101
3102         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3103         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3104         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3105         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3106         * WebKitTestRunner/TestController.cpp:
3107         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3108         (WTR::TestController::createWebViewWithOptions):
3109         (WTR::TestController::resetStateToConsistentValues):
3110         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3111         * WebKitTestRunner/TestController.h:
3112         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3113         * WebKitTestRunner/TestInvocation.cpp:
3114         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3115
3116 2019-03-08  Saam barati  <sbarati@apple.com>
3117
3118         Add a compare-results script to compare benchmark results
3119         https://bugs.webkit.org/show_bug.cgi?id=195486
3120         <rdar://problem/48723397>
3121
3122         Reviewed by Geoffrey Garen.
3123
3124         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3125         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3126         to extend it to learn about our other benchmarks.
3127
3128         * Scripts/compare-results: Added.
3129         (readJSONFile):
3130         (detectJetStream2):
3131         (JetStream2Results):
3132         (detectSpeedometer2):
3133         (Speedometer2Results):
3134         (detectPLT5):
3135         (PLT5Results):
3136         (detectBenchmark):
3137         (biggerIsBetter):
3138         (ttest):
3139         (getOptions):
3140         (main):
3141
3142 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3143
3144         Ensure old tab state is cleared between iterations of run-benchmark
3145         https://bugs.webkit.org/show_bug.cgi?id=195393
3146         <rdar://problem/46885583>
3147
3148         Reviewed by Dewei Zhu.
3149
3150         a) ensure the default to restore state is not set
3151         b) terminate Safari correctly
3152         c) Set the system default to ignore Persistent State in Safari
3153
3154         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3155         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3156         (OSXBrowserDriver.prepare_env): 
3157         (OSXBrowserDriver.restore_env):
3158         (OSXBrowserDriver.close_browsers):
3159         (OSXBrowserDriver._terminate_processes):
3160         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3161         (OSXChromeDriver):
3162         (OSXChromeCanaryDriver):
3163         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3164         (OSXFirefoxDriver):
3165         (OSXFirefoxNightlyDriver):
3166         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3167         (OSXSafariDriver):
3168         (OSXSafariDriver.prepare_env):
3169
3170 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3171
3172         [GTK] Several InputMethodFilter tests are failing
3173         https://bugs.webkit.org/show_bug.cgi?id=195408
3174
3175         Reviewed by Carlos Garcia Campos.
3176
3177         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3178         Regressed in r241751.
3179         Hexadecimal values of keycodes are expressed now in upper letters.
3180         Composited characters should be cast to UTF8 strings.
3181
3182         (TestWebKitAPI::TEST):
3183
3184 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3185
3186         [GTK] Make Tools/gtkdoc python3 compatible
3187         https://bugs.webkit.org/show_bug.cgi?id=195359
3188
3189         Reviewed by Carlos Garcia Campos.
3190
3191         * gtkdoc/generate-gtkdoc:
3192         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3193         work with Python 2 and 3.
3194         (get_gtkdoc_module_paths):
3195         The iteritems() was removed in Python 3, so let's use items() that's
3196         available in Python 2 and 3.
3197         (get_generator_for_config):
3198         * gtkdoc/gtkdoc.py:
3199         (GTKDoc._run_command):
3200         The sys.stdout.write() is expecting str in Python 3 and not bytes
3201         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3202         for passing the bytes there.
3203
3204 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3205
3206         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3207         https://bugs.webkit.org/show_bug.cgi?id=195346
3208         <rdar://problem/48667048>
3209
3210         Unreviewed build fix for clang-cl.
3211
3212         * DumpRenderTree/win/DumpRenderTree.cpp:
3213         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3214
3215 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3216
3217         requestAnimationFrame should execute before the next frame
3218         https://bugs.webkit.org/show_bug.cgi?id=177484
3219
3220         Reviewed by Simon Fraser.
3221
3222         Add trace points for the page RenderingUpdate.
3223
3224         * Tracing/SystemTracePoints.plist:
3225
3226 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3227
3228         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3229         https://bugs.webkit.org/show_bug.cgi?id=195353
3230         <rdar://problem/48626394>
3231
3232         Reviewed by Simon Fraser.
3233
3234         * WebKitTestRunner/ios/TestControllerIOS.mm:
3235         (WTR::TestController::platformResetPreferencesToConsistentValues):
3236
3237 2019-03-07  John Wilander  <wilander@apple.com>
3238
3239         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3240         https://bugs.webkit.org/show_bug.cgi?id=195383
3241         <rdar://problem/48570136>
3242
3243         Reviewed by Brent Fulgham.
3244
3245         This patch adds test infrastructure to purge only script-accessible cookies,
3246         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3247
3248         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3249         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3250         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3251         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3252         * WebKitTestRunner/TestController.cpp:
3253         (WTR::TestController::statisticsDeleteCookiesForHost):
3254         * WebKitTestRunner/TestController.h:
3255         * WebKitTestRunner/TestInvocation.cpp:
3256         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3257
3258 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3259
3260         Unreviewed, rolling out r242354.
3261         https://bugs.webkit.org/show_bug.cgi?id=195402
3262
3263         breaks layout tests in all configurations (Requested by
3264         zdobersek on #webkit).
3265
3266         Reverted changeset:
3267
3268         "[WPE] Enable web process sandbox"
3269         https://bugs.webkit.org/show_bug.cgi?id=195169
3270         https://trac.webkit.org/changeset/242354
3271
3272 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3273
3274         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3275         https://bugs.webkit.org/show_bug.cgi?id=195346
3276
3277         Reviewed by Fujii Hironori.
3278
3279         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3280         (TestWebKitAPI::TEST):
3281         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3282
3283         * DumpRenderTree/win/DumpRenderTree.cpp:
3284         (findFontFallback):
3285         (addFontFallbackIfPresent):
3286         (removeFontFallbackIfPresent):
3287         (main):
3288         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3289         (TestWebKitAPI::Util::moduleDirectory):
3290         (TestWebKitAPI::Util::createInjectedBundlePath):
3291         Use wchar helpers as needed.
3292
3293 2019-03-06  Rob Buis  <rbuis@igalia.com>
3294
3295         Consider supporting the `referrerpolicy` attribute.
3296         https://bugs.webkit.org/show_bug.cgi?id=179053
3297
3298         Reviewed by Darin Adler.
3299
3300         Add a runtime flag for referrerpolicy attribute.
3301
3302         * DumpRenderTree/mac/DumpRenderTree.mm:
3303         (enableExperimentalFeatures):
3304
3305 2019-03-05  Daniel Bates  <dabates@apple.com>
3306
3307         Update expected API test result following r242379
3308         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3309
3310         Update expected x-coordinate of selection rect now that the left padding of
3311         a textarea is sized in ems (so dependent on the font size) just like the left
3312         padding of a text field.
3313
3314         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3315         (TestWebKitAPI::TEST):
3316
3317 2019-03-05  David Quesada  <david_quesada@apple.com>
3318
3319         [WK2] It should be possible to follow links with 'download' attributes
3320         https://bugs.webkit.org/show_bug.cgi?id=195145
3321         rdar://problem/48462642
3322
3323         Reviewed by Alex Christensen.
3324
3325         Add a unit test to verify that activating links with 'download' attributes now
3326         navigates to the linked resource, rather than starts downloading it. Add another
3327         to verify that it is still possible to explicitly download the link via the
3328         'Download' navigation action policy.
3329
3330         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3331         (-[DownloadAttributeTestDelegate init]):
3332         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3333         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3334         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3335         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3336         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3337         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3338         (TEST):
3339         * WebKitTestRunner/TestController.cpp:
3340         (WTR::TestController::decidePolicyForNavigationAction):
3341         * WebKitTestRunner/TestController.h:
3342
3343 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3344
3345         [Curl] Implement Cookie Accept Policy.
3346         https://bugs.webkit.org/show_bug.cgi?id=191645
3347
3348         Reviewed by Fujii Hironori.
3349
3350         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3351         (TestWebKitAPI::Curl::TEST_F):
3352
3353 2019-03-05  Youenn Fablet  <youenn@apple.com>
3354
3355         Rename requestCacheStorageSpace to requestStorageSpace
3356         https://bugs.webkit.org/show_bug.cgi?id=195282
3357
3358         Reviewed by Chris Dumez.
3359
3360         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3361         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3362         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3363
3364 2019-03-05  Brady Eidson  <beidson@apple.com>
3365
3366         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3367         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3368
3369         Reviewed by Tim Horton.
3370
3371         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3372         different directory into that same WKWebView should work.
3373
3374         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3375         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3376
3377 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3378
3379         Add WeakHashSet
3380         https://bugs.webkit.org/show_bug.cgi?id=195152
3381
3382         Reviewed by Antti Koivisto.
3383
3384         Added tests for WeakHashSet.
3385
3386         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3387         (TestWebKitAPI::Base::Base): Moved.
3388         (TestWebKitAPI::Derived::foo): Moved.
3389         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3390         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3391         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3392         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3393
3394 2019-03-04  Chris Dumez  <cdumez@apple.com>
3395
3396         Do not share WebProcesses between private and regular sessions
3397         https://bugs.webkit.org/show_bug.cgi?id=195189
3398         <rdar://problem/48421064>
3399
3400         Reviewed by Alex Christensen.
3401
3402         Add API test coverage.
3403
3404         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3405         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3406
3407 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3408
3409         [WPE] Enable web process sandbox
3410         https://bugs.webkit.org/show_bug.cgi?id=195169
3411
3412         Reviewed by Daniel Bates.
3413
3414         * wpe/install-dependencies:
3415         * wpe/jhbuild.modules:
3416
3417 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3418
3419         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3420         https://bugs.webkit.org/show_bug.cgi?id=195206
3421
3422         Reviewed by Žan Doberšek.
3423
3424         Add a new test case.
3425
3426         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3427         (testJSCClass):
3428
3429 2019-03-04  Charlie Turner  <cturner@igalia.com>
3430
3431         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3432         https://bugs.webkit.org/show_bug.cgi?id=194898
3433
3434         Reviewed by Žan Doberšek.
3435
3436         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3437         a GCC extension that permits arithmetic on void* pointer. Inline
3438         the macro until this issue is fixed upstream.
3439
3440 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3441
3442         Rid the world of WK_API_ENABLED
3443         https://bugs.webkit.org/show_bug.cgi?id=195263
3444
3445         Reviewed by Dan Bernstein.
3446
3447         List of changed files elided because it's useless.
3448
3449 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3450
3451         Unreviewed follow-up to r242292.
3452
3453         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3454
3455         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3456         (TestWebKitAPI::testStrip): Renamed from strip.
3457         (TestWebKitAPI::TEST):
3458
3459 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3460
3461         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3462
3463         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3464         and bug #194272 for details.
3465
3466         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3467
3468 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3469
3470         Remove some more unused 32-bit code
3471         https://bugs.webkit.org/show_bug.cgi?id=195255
3472
3473         Reviewed by Darin Adler.
3474
3475         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3476         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3477         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3478         (NPP_New):
3479         (NPP_HandleEvent):
3480         (handleEventCarbon): Deleted.
3481
3482 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3483
3484         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3485
3486         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3487         (TestWebKitAPI::TEST):
3488
3489 2019-03-01  Darin Adler  <darin@apple.com>
3490
3491         Finish removing String::format
3492         https://bugs.webkit.org/show_bug.cgi?id=194893
3493
3494         Reviewed by Daniel Bates.
3495 '
3496         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3497
3498 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3499
3500         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3501         https://bugs.webkit.org/show_bug.cgi?id=195229
3502         <rdar://problem/48520362>
3503
3504         Reviewed by Chris Dumez.
3505
3506         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3507         (TEST):
3508
3509 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3510
3511         Add a system trace scope for event region building
3512         https://bugs.webkit.org/show_bug.cgi?id=195226
3513
3514         Reviewed by Jon Lee.
3515
3516         This trace scope measures the time spend converting element rects into Region objects,
3517         which can be large on some pages.
3518
3519         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3520
3521         * Tracing/SystemTracePoints.plist:
3522
3523 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3524
3525         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3526         https://bugs.webkit.org/show_bug.cgi?id=194612
3527
3528         Reviewed by Alex Christensen.
3529
3530         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3531         Just test the new string-processing function and don't touch the actual environment.
3532         (Test cases are all as before, but based on operator== instead of strcmp.)
3533
3534 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3535
3536         [ews-app] Update primary keys for handling multiple Buildbot instances
3537         https://bugs.webkit.org/show_bug.cgi?id=195120
3538
3539         Reviewed by Stephanie Lewis.
3540
3541         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3542         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3543         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3544
3545         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3546         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3547         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3548         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3549         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3550         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3551
3552 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3553
3554         [WinCairo] Enable service worker
3555         https://bugs.webkit.org/show_bug.cgi?id=188318
3556
3557         Reviewed by Youenn Fablet.
3558
3559         * DumpRenderTree/DumpRenderTreePrefix.h:
3560         * TestWebKitAPI/PlatformWin.cmake:
3561         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3562         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3563         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3564
3565 2019-03-01  Justin Fan  <justin_fan@apple.com>
3566
3567         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3568         https://bugs.webkit.org/show_bug.cgi?id=195191
3569
3570         Rubber-stamped by Dean Jackson.
3571
3572         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3573
3574         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3575
3576 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3577
3578         Unreviewed, fix lldb webkitpy tests
3579         https://bugs.webkit.org/show_bug.cgi?id=194375
3580
3581         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3582
3583         * lldb/lldb_webkit.py:
3584         (WTFStringImplProvider.is_8bit):
3585
3586 2019-02-28  David Quesada  <david_quesada@apple.com>
3587
3588         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3589         https://bugs.webkit.org/show_bug.cgi?id=195121
3590         rdar://problem/48450302
3591
3592         Reviewed by Alex Christensen.
3593
3594         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3595         configurations where the 'download' attribute is absent, blank, or populated
3596         with a filename, and where the anchor element is same-origin or cross-origin
3597         (meaning the 'download' attribute shouldn't be honored).
3598
3599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3600         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3601         (-[NavigationActionTestDelegate init]):
3602         (-[NavigationActionTestDelegate navigationAction]):
3603         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3604         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3605         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3606         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3607         (TEST):
3608
3609 2019-02-28  Antoine Quint  <graouts@apple.com>
3610
3611         Enable the Pointer Events runtime flag by default
3612         https://bugs.webkit.org/show_bug.cgi?id=195156
3613
3614         Reviewed by Dean Jackson.
3615
3616         * DumpRenderTree/mac/DumpRenderTree.mm:
3617         (enableExperimentalFeatures):
3618
3619 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3620
3621         Several PasteImage API tests are flaky
3622         https://bugs.webkit.org/show_bug.cgi?id=195160
3623
3624         Reviewed by Tim Horton.
3625
3626         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3627         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3628         listening for a "load" event after image load is already complete.
3629
3630         To address this, make these tests first register a "load" event handler, then run script to insert an image
3631         element into the document, and finally wait until the load event is observed before checking image size.
3632
3633         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3634
3635 2019-02-28  Chris Dumez  <cdumez@apple.com>
3636
3637         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3638         https://bugs.webkit.org/show_bug.cgi?id=195107
3639
3640         Reviewed by Alex Christensen.
3641
3642         Give some time for the zoom level to get restored.
3643
3644         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3645
3646 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3647
3648         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3649         https://bugs.webkit.org/show_bug.cgi?id=194958
3650
3651         Reviewed by Geoffrey Garen.
3652
3653         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3654         (TEST):
3655
3656 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3657
3658         [ews-app] Update method to save build to handle builder_display_name
3659         https://bugs.webkit.org/show_bug.cgi?id=195047
3660
3661         Reviewed by Dewei Zhu.
3662
3663         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3664         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3665
3666 2019-02-28  Justin Fan  <justin_fan@apple.com>
3667
3668         [Web GPU] Enable Web GPU only on 64-bit
3669         https://bugs.webkit.org/show_bug.cgi?id=195139
3670
3671         Because Metal is only supported on 64 bit apps.
3672
3673         Unreviewed build fix.
3674
3675         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3676
3677 2019-02-27  Youenn Fablet  <youenn@apple.com>
3678
3679         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3680         https://bugs.webkit.org/show_bug.cgi?id=194959
3681
3682         Reviewed by Chris Dumez.
3683
3684         Spin loop until getting the condition to remove flakiness.
3685
3686         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3687
3688 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3689
3690         [ews-build] Buildbot should include builder_display_name in the build events
3691         https://bugs.webkit.org/show_bug.cgi?id=195045
3692
3693         Reviewed by Dewei Zhu.
3694
3695         * BuildSlaveSupport/ews-build/events.py:
3696         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3697         buildername to builder_name to be consistent in naming style.
3698         (Events.buildFinished): Ditto.
3699
3700 2019-02-27  Chris Dumez  <cdumez@apple.com>
3701
3702         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3703         https://bugs.webkit.org/show_bug.cgi?id=194480
3704
3705         Reviewed by Brady Eidson.
3706
3707         Update existing API test to make it more likely to reproduce the issue.
3708
3709         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3710
3711 2019-02-27  Brady Eidson  <beidson@apple.com>
3712
3713         Universal links from Google search results pages don't open the app.
3714         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3715
3716         Reviewed by Geoffrey Garen.
3717
3718         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3719         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3720         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3721         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3722
3723 2019-02-27  Chris Dumez  <cdumez@apple.com>
3724
3725         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3726         https://bugs.webkit.org/show_bug.cgi?id=195102
3727
3728         Reviewed by Geoffrey Garen.
3729
3730         If the number of processes is not yet what we expect, wait a bit and check again to give
3731         processes some time to exit.
3732
3733         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3734
3735 2019-02-27  Chris Dumez  <cdumez@apple.com>
3736
3737         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3738         https://bugs.webkit.org/show_bug.cgi?id=194545
3739
3740         Reviewed by Brady Eidson.
3741
3742         Make sure the test navigates forward and then back only once. Previously, navigating
3743         back would trigger a navigation again in a timer.
3744
3745         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3746
3747 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3748
3749         High Sierra Debug JSC test queue should use faster hardware
3750         https://bugs.webkit.org/show_bug.cgi?id=194603
3751
3752         Rubber-stamped by Alexey Proskuryakov.
3753
3754         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3755
3756         * BuildSlaveSupport/build.webkit.org-config/config.json:
3757         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3758         (BubbleQueueServer):
3759         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3760         (WebKitBuildbot):
3761         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3762         * QueueStatusServer/config/queues.py:
3763         * Scripts/webkitpy/common/config/ews.json:
3764         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3765         (test_ews_name):
3766
3767 2019-02-27  John Wilander  <wilander@apple.com>
3768
3769         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3770         https://bugs.webkit.org/show_bug.cgi?id=195071
3771         <rdar://problem/48417690>
3772
3773         Reviewed by Alex Christensen and Brent Fulgham.
3774
3775         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3776         (TestWebKitAPI::createURL):
3777             Convenience function.
3778         (TestWebKitAPI::TEST):
3779             WebCore::AdClickAttribution now takes a URL when creating Source and
3780             Destination.
3781         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3782         (TestWebKitAPI::TEST):
3783             WebCore::AdClickAttribution now takes a URL when creating Source and
3784             Destination.
3785
3786 2019-02-27  Antoine Quint  <graouts@apple.com>
3787
3788         Support Pointer Events on macOS
3789         https://bugs.webkit.org/show_bug.cgi?id=195008
3790         <rdar://problem/47454419>
3791
3792         Reviewed by Dean Jackson.
3793
3794         * DumpRenderTree/mac/DumpRenderTree.mm:
3795         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3796         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3797
3798 2019-02-26  Mark Lam  <mark.lam@apple.com>
3799
3800         Remove remaining poisoning code.
3801         https://bugs.webkit.org/show_bug.cgi?id=194138
3802
3803         Reviewed by Saam Barati.
3804
3805         * TestWebKitAPI/CMakeLists.txt:
3806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3807         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3808         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3809         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3810         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3811         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3812         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3813
3814 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3815
3816         Move ephemeral local storage from WebProcess to UIProcess
3817         https://bugs.webkit.org/show_bug.cgi?id=195074
3818         <rdar://problem/47937975>
3819
3820         Reviewed by Geoff Garen.
3821
3822         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3823
3824 2019-02-20  Jer Noble  <jer.noble@apple.com>
3825
3826         [Cocoa] Media elements will restart network buffering just before suspending
3827         https://bugs.webkit.org/show_bug.cgi?id=193691
3828
3829         Reviewed by Eric Carlson.
3830
3831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3832         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3833         (TEST):
3834
3835 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3836
3837         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3838         https://bugs.webkit.org/show_bug.cgi?id=191652
3839
3840         Reviewed by Alex Christensen.
3841
3842         Fix WinCairo MiniBrowser behavior of authentication dialog.
3843
3844         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3845         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3846
3847 2019-02-26  Youenn Fablet  <youenn@apple.com>
3848
3849         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3850         https://bugs.webkit.org/show_bug.cgi?id=195028
3851         <rdar://problem/48243733>
3852
3853         Reviewed by Eric Carlson.
3854
3855         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3856
3857 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3858
3859         [WPE] Add API for webview background color configuration
3860         https://bugs.webkit.org/show_bug.cgi?id=192305
3861
3862         Reviewed by Michael Catanzaro.
3863
3864         * MiniBrowser/wpe/main.cpp:
3865         (main): Add a new option to configure the webview background
3866         color. Example: --bg-color=transparent.
3867         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3868         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3869         (beforeAll): Ditto.
3870
3871 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3872
3873         scalableNativeWebpageParameters() is not preserved on new page navigation.
3874         https://bugs.webkit.org/show_bug.cgi?id=194892
3875         <rdar://problem/47538280>
3876
3877         Reviewed by Wenson Hsieh.
3878         
3879         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3880
3881         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3882         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3883         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3884         (WTR::UIScriptController::allowsViewportShrinkToFit):
3885         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3886         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3887         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3888         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3889         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3890         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3891
3892 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3893
3894         [ews-app] Add model for handling multiple Buildbot instances
3895         https://bugs.webkit.org/show_bug.cgi?id=194863
3896
3897         Reviewed by Stephanie Lewis.
3898
3899         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3900
3901 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3902
3903         [ews-app] Remove BuilderMapping table
3904         https://bugs.webkit.org/show_bug.cgi?id=194961
3905
3906         Reviewed by Stephanie Lewis.
3907
3908         Store builder name directly in build table, instead of having a separate
3909         table for it.
3910
3911         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3912         * BuildSlaveSupport/ews-app/ews/models/build.py:
3913         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3914         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3915
3916 2019-02-25  John Wilander  <wilander@apple.com>
3917
3918         Introduce and adopt new class RegistrableDomain for eTLD+1
3919         https://bugs.webkit.org/show_bug.cgi?id=194791
3920         <rdar://problem/48179240>
3921
3922         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3923
3924         This patch adds an API test and replaces two instances of
3925         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3926
3927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3928         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3929         (TestWebKitAPI::TEST):
3930             Changed two strings to make sure the registrable domains are still considered
3931             invalid and pass the test.
3932         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3933         (TestWebKitAPI::TEST):
3934         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3935         (WTR::InjectedBundle::didReceiveMessageToPage):
3936
3937 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3938
3939         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3940         https://bugs.webkit.org/show_bug.cgi?id=195001
3941
3942         Reviewed by Carlos Garcia Campos.
3943
3944         API version 1.0 always includes the functionality previously guarded with
3945         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3946         unconditionally.
3947
3948         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3949         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3950         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3951         (WebViewTest::showInWindow): Ditto.
3952         (WebViewTest::hideView): Ditto.
3953         * wpe/backends/HeadlessViewBackend.cpp:
3954         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3955         * wpe/backends/ViewBackend.cpp:
3956         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3957         * wpe/backends/WindowViewBackend.cpp:
3958         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3959         WPE_BACKEND_CHECK_VERSION().
3960         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3961
3962 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3963
3964         [Flatpak] Add support for flatpak > 1.1.2
3965         https://bugs.webkit.org/show_bug.cgi?id=194088
3966
3967         Flatpak 1.2 is now out so we need to support that
3968         version now.
3969
3970         Reviewed by Michael Catanzaro.
3971
3972         * flatpak/flatpakutils.py:
3973         (check_flatpak):
3974         (FlatpakPackages.__init__):
3975         (FlatpakPackages.__detect_packages):
3976         (FlatpakPackages.__detect_packages.in):
3977         (FlatpakRepos.update):
3978
3979 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3980
3981         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3982         https://bugs.webkit.org/show_bug.cgi?id=194998
3983
3984         Reviewed by Carlos Garcia Campos.
3985
3986         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3987         to a Git checkout and using the latest commit containing various fixes
3988         and improvements.
3989
3990 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3991
3992         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3993         https://bugs.webkit.org/show_bug.cgi?id=194981
3994
3995         Reviewed by Žan Doberšek.
3996
3997         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3998         (TestWebKitAPI::TEST):
3999
4000 2019-02-23  Keith Miller  <keith_miller@apple.com>
4001
4002         Add new mac target numbers
4003         https://bugs.webkit.org/show_bug.cgi?id=194955
4004
4005         Reviewed by Tim Horton.
4006
4007         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4008         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4009         * MiniBrowser/Configurations/Base.xcconfig:
4010         * TestWebKitAPI/Configurations/Base.xcconfig:
4011         * WebKitTestRunner/Configurations/Base.xcconfig:
4012
4013 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4014
4015         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4016         https://bugs.webkit.org/show_bug.cgi?id=194846
4017
4018         Reviewed by Don Olmstead.
4019
4020         Added _search_paths() and _port_specific_expectations_files() for
4021         WinCairoPort.
4022
4023         * Scripts/webkitpy/port/win.py:
4024         (WinCairoPort.default_baseline_search_path):
4025         (WinCairoPort):
4026         (WinCairoPort._port_specific_expectations_files):
4027         (WinCairoPort._search_paths):
4028
4029 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4030
4031         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4032         https://bugs.webkit.org/show_bug.cgi?id=194963
4033
4034         Reviewed by Dean Jackson.
4035
4036         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4037         Do a `contains` check instead of `equals`, because in debug builds we
4038         put the GraphicsLayer pointer in a prefix.
4039
4040 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4041
4042         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4043         https://bugs.webkit.org/show_bug.cgi?id=194873
4044         <rdar://problem/46701974>
4045
4046         Reviewed by Tim Horton.
4047
4048         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4049
4050         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4051         (WTR::UIScriptController::menuRect const):
4052         (WTR::UIScriptController::isShowingMenu const):
4053         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4054         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4055         (WTR::UIScriptController::menuRect const):
4056
4057         Add a function to query the bounds of the callout menu in content coordinates.
4058
4059         (WTR::UIScriptController::isShowingMenu const):
4060
4061         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4062
4063         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4064         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4065         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4066         (WTR::UIScriptController::rectForMenuAction const):
4067         (WTR::UIScriptController::menuRect const):
4068         (WTR::UIScriptController::isShowingMenu const):
4069         (WTR::findViewInHierarchyOfType): Deleted.
4070
4071 2019-02-22  Chris Dumez  <cdumez@apple.com>
4072
4073         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4074         https://bugs.webkit.org/show_bug.cgi?id=194954
4075         <rdar://problem/48127957>
4076
4077         Reviewed by Alex Christensen.
4078
4079         Add API test coverage.
4080
4081         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4082         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4083         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4084         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4085
4086 2019-02-22  Chris Dumez  <cdumez@apple.com>
4087
4088         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4089         https://bugs.webkit.org/show_bug.cgi?id=194924
4090         <rdar://problem/48216125>
4091
4092         Reviewed by Geoffrey Garen.
4093
4094         Add API test coverage.
4095
4096         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4097
4098 2019-02-22  Chris Dumez  <cdumez@apple.com>
4099
4100         Unreviewed, disable API test added in r241928 on iOS.
4101
4102         The cache is not enabled on devices with less than 3GB of RAM.
4103
4104         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4105
4106 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4107
4108         Hardcode Visual Viewports on everywhere except iOS WK1
4109         https://bugs.webkit.org/show_bug.cgi?id=194928
4110
4111         Reviewed by Zalan Bujtas.
4112
4113         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4114         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4115         set it to false. The setting has shipped for several years and there's no need to turn
4116         it off now.
4117
4118         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4119         Visual Viewports are not enabled.
4120         
4121         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4122         that only runs in WK2
4123
4124         * MiniBrowser/mac/SettingsController.h:
4125         * MiniBrowser/mac/SettingsController.m:
4126         (-[SettingsController init]):
4127         (-[SettingsController _populateMenu]):
4128         (-[SettingsController validateMenuItem:]):
4129         (-[SettingsController visualViewportEnabled]): Deleted.
4130         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4131         * MiniBrowser/mac/WK1BrowserWindowController.m:
4132         (-[WK1BrowserWindowController didChangeSettings]):
4133         * MiniBrowser/mac/WK2BrowserWindowController.m:
4134         (-[WK2BrowserWindowController didChangeSettings]):
4135
4136 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4137
4138         Discard cached processes when clearing website data store
4139         https://bugs.webkit.org/show_bug.cgi?id=194894
4140
4141         Reviewed by Chris Dumez.
4142
4143         Added a test case.
4144
4145         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4146         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4147
4148 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4149
4150         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4151         https://bugs.webkit.org/show_bug.cgi?id=194914
4152         <rdar://problem/47586889>
4153
4154         Reviewed by Geoffrey Garen.
4155
4156         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4157         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4158         (TEST):
4159         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4160
4161 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4162
4163         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4164         <https://webkit.org/b/194761>
4165
4166         Reviewed by Myles Maxfield.
4167
4168         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4169         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4170         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4171         to use ARC-compliant cast.
4172         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4173         ARC-compliant cast.
4174         (WTR::installFakeHelvetica): Log `error` to console if
4175         CTFontManagerRegisterFontsForURL() fails, but only on supported
4176         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4177         Call CFRelease() on `error` to fix the leak.  Update to use
4178         ARC-compliant cast.
4179         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4180         cast.
4181
4182 2019-02-21  Chris Dumez  <cdumez@apple.com>
4183
4184         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4185         https://bugs.webkit.org/show_bug.cgi?id=194481
4186
4187         Reviewed by Alex Christensen.
4188
4189         Give the processes a chance to shutdown and wait until we reached the expected number
4190         of processes.
4191
4192         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4193
4194 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4195
4196         Fix the macOS build
4197
4198         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4199
4200 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4201
4202         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4203
4204         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4205         I am a backwards.
4206
4207 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4208
4209         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4210
4211         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4212         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4213         We could force on UI-side compositing, but I feel like the test might be more
4214         valuable exercising the normal path on each platform (though the original
4215         bug was also UI-side specific). Though we can't validate that the overlay
4216         layer was installed successfully, there are layout tests that do that.
4217
4218 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4219
4220         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4221         https://bugs.webkit.org/show_bug.cgi?id=194845
4222         <rdar://problem/47944579>
4223
4224         Reviewed by Antti Koivisto.
4225
4226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4227         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4228
4229 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4230
4231         [LFC][Floats] Add support for placing formatting roots in-between floats.
4232         https://bugs.webkit.org/show_bug.cgi?id=194902
4233
4234         Reviewed by Antti Koivisto.
4235
4236         * LayoutReloaded/misc/LFC-passing-tests.txt:
4237
4238 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4239
4240         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4241         https://bugs.webkit.org/show_bug.cgi?id=194901
4242
4243         Unreviewed build fix.
4244
4245         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4246         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4247         WPEBackend-fdo-0.1 as library name.
4248
4249 2019-02-21  Rob Buis  <rbuis@igalia.com>
4250
4251         Update MIME type parser
4252         https://bugs.webkit.org/show_bug.cgi?id=180526
4253
4254         Reviewed by Darin Adler.
4255
4256         Add tests involving leading and trailing whitespace, non-token
4257         characters and quoted strings.
4258
4259         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4260         (TestWebKitAPI::TEST):
4261
4262 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4263
4264         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4265         https://bugs.webkit.org/show_bug.cgi?id=194884
4266
4267         Reviewed by Michael Catanzaro.
4268
4269         * PlatformWin.cmake:
4270
4271 2019-02-20  Chris Dumez  <cdumez@apple.com>
4272
4273         Add API test for <rdar://problem/47471222>
4274         https://bugs.webkit.org/show_bug.cgi?id=194847
4275
4276         Reviewed by Alex Christensen.
4277
4278         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4279
4280 2019-02-20  Chris Dumez  <cdumez@apple.com>
4281
4282         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4283         https://bugs.webkit.org/show_bug.cgi?id=194872
4284         <rdar://problem/47924500>
4285
4286         Reviewed by Alex Christensen.
4287
4288         Add API test coverage.
4289
4290         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4291
4292 2019-02-20  Jer Noble  <jer.noble@apple.com>
4293
4294         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4295         https://bugs.webkit.org/show_bug.cgi?id=191332
4296
4297         Reviewed by Dean Jackson.
4298
4299         * Scripts/git-is-in-range: Added.
4300
4301 2019-02-20  Andy Estes  <aestes@apple.com>
4302
4303         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4304         https://bugs.webkit.org/show_bug.cgi?id=194869
4305
4306         Rubber-stamped by Jer Noble.
4307
4308         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4309         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4310         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4311         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4312         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4313         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4314
4315 2019-02-20  Chris Dumez  <cdumez@apple.com>
4316
4317         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4318         https://bugs.webkit.org/show_bug.cgi?id=194857
4319         <rdar://problem/47759323>
4320
4321         Reviewed by Alex Christensen.
4322
4323         Add API test coverage.
4324
4325         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4326
4327 2019-02-20  Chris Dumez  <cdumez@apple.com>
4328
4329         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4330         https://bugs.webkit.org/show_bug.cgi?id=194829
4331         <rdar://problem/47889906>
4332
4333         Reviewed by Alexey Proskuryakov.
4334
4335         Every time the TestOptions were changing we were creating both a new Web view and
4336         a new WKContext, which would start a new Network process. In most cases, we only
4337         need to contruct a new Web view and we do can keep reusing the same WKContext.
4338         This patch implements this optimization and thus avoids spinning a lot of new
4339         Network processes while running the layout tests.
4340
4341         * WebKitTestRunner/TestController.cpp:
4342         (WTR::TestController::generateContextConfiguration const):
4343         (WTR::TestController::generatePageConfiguration):
4344         (WTR::TestController::createWebViewWithOptions):
4345         (WTR::TestController::resetPreferencesToConsistentValues):
4346         (WTR::updateTestOptionsFromTestHeader):
4347         * WebKitTestRunner/TestController.h:
4348         * WebKitTestRunner/TestOptions.h:
4349         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4350         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4351         (WTR::TestOptions::hasSameInitializationOptions const):
4352         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4353         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4354         (WTR::TestController::platformAddTestOptions const):
4355
4356 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4357
4358         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4359         https://bugs.webkit.org/show_bug.cgi?id=167941
4360
4361         Reviewed by Carlos Garcia Campos.
4362
4363         * MiniBrowser/gtk/main.c:
4364         (filterSavedCallback): Added.
4365         (main): Support loading a JSON rule set file for content filtering.
4366         * MiniBrowser/wpe/main.cpp:
4367         (filterSavedCallback): Added.
4368         (main): Support loading a JSON rule set file for content filtering.
4369         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.