Add a way to opt into modern compatibility mode in layout tests
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Add a way to opt into modern compatibility mode in layout tests
4         https://bugs.webkit.org/show_bug.cgi?id=196770
5         <rdar://problem/49777550>
6
7         Reviewed by Antoine Quint.
8
9         Add a new test option to enable modern compatibility mode in layout tests.
10
11         * WebKitTestRunner/TestController.cpp:
12         (WTR::updateTestOptionsFromTestHeader):
13         * WebKitTestRunner/TestController.h:
14         * WebKitTestRunner/TestOptions.h:
15         (WTR::TestOptions::hasSameInitializationOptions const):
16         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
17         (WTR::TestController::platformCreateWebView):
18         (WTR::TestController::enableModernCompatibilityMode):
19
20 2019-04-10  Andy Estes  <aestes@apple.com>
21
22         Try to fix the 32-bit watchOS build.
23
24         * TestWebKitAPI/cocoa/TestWKWebView.mm:
25         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
26
27 2019-04-10  Antoine Quint  <graouts@apple.com>
28
29         Enable Pointer Events on watchOS
30         https://bugs.webkit.org/show_bug.cgi?id=196771
31         <rdar://problem/49040909>
32
33         Reviewed by Dean Jackson.
34
35         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
36
37 2019-04-10  Philippe Normand  <pnormand@igalia.com>
38
39         Unreviewed. Fix WPE accessibility tests after r244059.
40
41         We are failing to load the injected bundle due to undefined symbol
42         AccessibilityUIElement::replaceTextInRange().
43
44         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
45         (WTR::AccessibilityUIElement::replaceTextInRange):
46
47 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
48
49         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
50         https://bugs.webkit.org/show_bug.cgi?id=196727
51
52         Reviewed by Fujii Hironori.
53
54         * MiniBrowser/win/WebKitBrowserWindow.cpp:
55         (WebKitBrowserWindow::create):
56
57 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
58
59         [ews-build] Add unit tests for PrintConfiguration
60         https://bugs.webkit.org/show_bug.cgi?id=196752
61
62         Reviewed by Dewei Zhu.
63
64         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
65
66 2019-04-09  Keith Rollin  <krollin@apple.com>
67
68         Unreviewed build maintenance -- update .xcfilelists.
69
70         * DumpRenderTree/DerivedSources-input.xcfilelist:
71         * DumpRenderTree/DerivedSources-output.xcfilelist:
72
73 2019-04-09  Zalan Bujtas  <zalan@apple.com>
74
75         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
76         https://bugs.webkit.org/show_bug.cgi?id=196743
77         <rdar://problem/43897551>
78
79         Reviewed by Tim Horton.
80
81         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
82         (TEST):
83
84 2019-04-09  Youenn Fablet  <youenn@apple.com>
85
86         Close service worker database on network process suspension
87         https://bugs.webkit.org/show_bug.cgi?id=196623
88         <rdar://problem/48930869>
89
90         Reviewed by Alex Christensen.
91
92         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
93
94 2019-04-09  Daniel Bates  <dabates@apple.com>
95
96         [iPad] Should open popover when the spacebar is pressed
97         https://bugs.webkit.org/show_bug.cgi?id=196360
98         <rdar://problem/49389129>
99
100         Reviewed by Brent Fulgham.
101
102         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
103
104         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
105         (WTR::UIScriptController::isShowingPopover const): Added.
106         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
107         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
108         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
109         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
110         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
111         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
112         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
113         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
114         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
115         (WTR::UIScriptController::isShowingPopover const): Added.
116         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
117         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
118         * TestRunnerShared/UIScriptContext/UIScriptController.h:
119         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
120         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
121         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
122         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
123         (-[TestRunnerWKWebView _willPresentPopover]): Added.
124         (-[TestRunnerWKWebView _didDismissPopover]): Added.
125         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
126         (WTR::UIScriptController::isShowingPopover const): Added.
127         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
128         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
129
130 2019-04-09  Alex Christensen  <achristensen@webkit.org>
131
132         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
133         https://bugs.webkit.org/show_bug.cgi?id=196665
134         <rdar://45115669>
135
136         Reviewed by Geoff Garen.
137
138         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
139         (goBack):
140         (+[SimpleLookupContext sharedLookupContext]):
141         (-[SimpleLookupContext lookUpURL:completionHandler:]):
142         (TEST):
143         (+[Simple3LookupContext sharedLookupContext]): Deleted.
144         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
145
146 2019-04-09  John Wilander  <wilander@apple.com>
147
148         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
149         https://bugs.webkit.org/show_bug.cgi?id=196558
150         <rdar://problem/47650245>
151
152         Reviewed by Youenn Fablet.
153
154         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
155         (TestWebKitAPI::TEST):
156             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
157
158 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
159
160         [CMake] Apple builds should use ICU_INCLUDE_DIRS
161         https://bugs.webkit.org/show_bug.cgi?id=196720
162
163         Reviewed by Konstantin Tokarev.
164
165         * TestWebKitAPI/PlatformMac.cmake:
166
167 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
168
169         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
170         https://bugs.webkit.org/show_bug.cgi?id=196694
171         <rdar://problem/48388734>
172
173         Rubber-stamped by Aakash Jain.
174
175         * Scripts/webkitpy/port/image_diff.py:
176         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
177         * Scripts/webkitpy/port/server_process.py:
178         (ServerProcess.has_available_stdout): Check if stdout has data in it.
179         (ServerProcess._wait_for_data_and_update_buffers_using_select):
180         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
181         * Scripts/webkitpy/port/server_process_mock.py:
182         (MockServerProcess.has_available_stdout):
183         * Scripts/webkitpy/port/server_process_unittest.py:
184         (TestServerProcess.serial_test_basic):
185
186 2019-04-09  Jer Noble  <jer.noble@apple.com>
187
188         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
189         https://bugs.webkit.org/show_bug.cgi?id=196097
190
191         Reviewed by Eric Carlson.
192
193         Drive-by bug fix: allow tests to play audio without a user gesture by default.
194
195         * DumpRenderTree/mac/DumpRenderTree.mm:
196         (resetWebPreferencesToConsistentValues):
197         * WebKitTestRunner/TestController.cpp:
198         (WTR::TestController::resetPreferencesToConsistentValues):
199
200 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
201
202         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
203         https://bugs.webkit.org/show_bug.cgi?id=196690
204
205         Reviewed by Michael Catanzaro.
206
207         * QueueStatusServer/config/queues.py:
208         * Scripts/webkitpy/common/config/ews.json:
209         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
210         (test_ews_name):
211
212 2019-04-09  Chris Dumez  <cdumez@apple.com>
213
214         Loads using loadHTMLString() cause flashing when process-swapping
215         https://bugs.webkit.org/show_bug.cgi?id=196714
216         <rdar://problem/49637354>
217
218         Reviewed by Antti Koivisto.
219
220         Add API test coverage.
221
222         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
223
224 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
225
226         Unreviewed. Fix ATK accessibility tests after r244059.
227
228         We are failing to load the injected bundle due to undefined symbol
229         AccessibilityUIElement::replaceTextInRange().
230
231         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
232         (WTR::AccessibilityUIElement::replaceTextInRange):
233
234 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
235
236         AX: Support API: accessibilityReplaceRange:withText
237         https://bugs.webkit.org/show_bug.cgi?id=196636
238
239         Unreviewed build fix for Windows port.
240
241         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
242         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
243
244 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
245
246         [CMake][WinCairo] Separate copied headers into different directories
247         https://bugs.webkit.org/show_bug.cgi?id=196655
248
249         Reviewed by Michael Catanzaro.
250
251         * DumpRenderTree/CMakeLists.txt:
252         * MiniBrowser/win/CMakeLists.txt:
253         * TestWebKitAPI/CMakeLists.txt:
254         * TestWebKitAPI/PlatformWin.cmake:
255
256 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
257
258         Log stack-trace for run-webkit-tests when interrupted
259         https://bugs.webkit.org/show_bug.cgi?id=176393
260         <rdar://problem/34262310>
261
262         Reviewed by Lucas Forschler.
263
264         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
265         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
266         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
267         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
268         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
269         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
270         (main): Set handlers to log stack trace on interruption.
271
272 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
273
274         AX: Support API: accessibilityReplaceRange:withText
275         https://bugs.webkit.org/show_bug.cgi?id=196636
276
277         Unreviewed build fix for Windows port.
278
279         * DumpRenderTree/AccessibilityUIElement.cpp:
280         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
281
282 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
283
284         [ews-build] Scripts using Buildbot API have CORS error
285         https://bugs.webkit.org/show_bug.cgi?id=196709
286
287         Reviewed by Alexey Proskuryakov.
288
289         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
290
291 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
292
293         AX: Support API: accessibilityReplaceRange:withText
294         https://bugs.webkit.org/show_bug.cgi?id=196636
295
296         Reviewed by Daniel Bates.
297
298         * DumpRenderTree/AccessibilityUIElement.cpp:
299         (replaceTextInRangeCallback):
300         (AccessibilityUIElement::replaceTextInRange):
301         (AccessibilityUIElement::getJSClass):
302         * DumpRenderTree/AccessibilityUIElement.h:
303         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
304         (AccessibilityUIElement::replaceTextInRange):
305         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
306         (AccessibilityUIElement::replaceTextInRange):
307         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
308         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
309         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
310         (WTR::AccessibilityUIElement::replaceTextInRange):
311         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
312         (WTR::AccessibilityUIElement::replaceTextInRange):
313
314 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
315
316         [iOS] Do not allow starting selection drags when selection views are not visible
317         https://bugs.webkit.org/show_bug.cgi?id=196686
318         <rdar://problem/49399192>
319
320         Reviewed by Tim Horton.
321
322         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
323         also add some new API tests to cover scenarios where the web view is not first responder.
324
325         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
326         (TestWebKitAPI::TEST):
327         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
328
329         Add a switch to optionally make the web view first responder when starting the simulated drag.
330
331         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
332         (-[DragAndDropSimulator initWithWebView:]):
333         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
334
335 2019-04-08  Justin Fan  <justin_fan@apple.com>
336
337         [Web GPU] Fix Web GPU experimental feature on iOS
338         https://bugs.webkit.org/show_bug.cgi?id=196632
339
340         Reviewed by Myles C. Maxfield.
341
342         Properly make Web GPU available on iOS 11+.
343
344         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
345
346 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
347
348         [ews-build] Do not upload archive when Compile Fails
349         https://bugs.webkit.org/show_bug.cgi?id=196674
350
351         Reviewed by Alexey Proskuryakov.
352
353         * BuildSlaveSupport/ews-build/factories.py:
354         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
355         * BuildSlaveSupport/ews-build/steps.py:
356         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
357         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
358         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
359
360 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
361
362         Enable DFG on MIPS
363         https://bugs.webkit.org/show_bug.cgi?id=196689
364
365         Reviewed by Žan Doberšek.
366
367         Since the bytecode change, we enabled the baseline JIT on mips in
368         r240432, but DFG is still missing. With this change, all tests are
369         passing on a ci20 board.
370
371         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
372
373 2019-04-08  Philippe Normand  <pnormand@igalia.com>
374
375         [Flatpak] Second run update-webkitwpe-flatpak fails
376         https://bugs.webkit.org/show_bug.cgi?id=192702
377
378         Reviewed by Carlos Garcia Campos.
379
380         * flatpak/flatpakutils.py:
381         (FlatpakObject.flatpak): Fix typo.
382         (FlatpakPackage.install): When installing, also update to the configured remote commit.
383         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
384
385 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
386
387         [GTK][WPE] outlook.live.com displays old-fashioned UI
388         https://bugs.webkit.org/show_bug.cgi?id=196642
389
390         Reviewed by Carlos Garcia Campos.
391
392         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
393         (TestWebKitAPI::TEST): New Mac platform quirk test.
394
395 2019-04-07  Commit Queue  <commit-queue@webkit.org>
396
397         Unreviewed, rolling out r243956.
398         https://bugs.webkit.org/show_bug.cgi?id=196688
399
400         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
401         by aakashjain on #webkit).
402
403         Reverted changeset:
404
405         "Clicking "Go Back" from a safe browsing warning from an
406         iframe should navigate the WKWebView back to the previous
407         page"
408         https://bugs.webkit.org/show_bug.cgi?id=196665
409         https://trac.webkit.org/changeset/243956
410
411 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
412
413         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
414         https://bugs.webkit.org/show_bug.cgi?id=196669
415
416         Reviewed by Geoffrey Garen.
417
418         Added three new unit tests for WeakHashSet.
419
420         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
421         (WTF_WeakPtr.WeakHashSetConstObjects):
422         (WTF_WeakPtr.WeakHashSetComputesEmpty):
423         (WTF_WeakPtr.WeakHashSetComputeSize):
424
425 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
426
427         Hide next and previous form control buttons when WKWebView is editable
428         https://bugs.webkit.org/show_bug.cgi?id=196672
429         <rdar://problem/35625321>
430
431         Reviewed by Tim Horton.
432
433         Add a new API test.
434
435         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
436         (-[TestWKWebView lastTrailingBarButtonGroup]):
437         (TestWebKitAPI::TEST):
438         * TestWebKitAPI/ios/UIKitSPI.h:
439
440 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
441
442         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
443         https://bugs.webkit.org/show_bug.cgi?id=196077
444         <rdar://problem/49108202>
445
446         Reviewed by Chris Dumez.
447
448         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
449         on new web view.
450
451         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
452
453 2019-04-05  Saam Barati  <sbarati@apple.com>
454
455         Make compare-results understand MotionMark
456         https://bugs.webkit.org/show_bug.cgi?id=196666
457
458         Reviewed by Yusuke Suzuki.
459
460         * Scripts/compare-results:
461         (PLT5Results):
462         (detectMotionMark):
463         (detectMotionMark1_1):
464         (motionMarkResults):
465         (motionMark1_1Results):
466         (detectBenchmark):
467         (biggerIsBetter):
468         (main):
469
470 2019-04-05  Alex Christensen  <achristensen@webkit.org>
471
472         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
473         https://bugs.webkit.org/show_bug.cgi?id=196665
474         <rdar://45115669>
475
476         Reviewed by Geoff Garen.
477
478         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
479         (goBack):
480         (+[SimpleLookupContext sharedLookupContext]):
481         (-[SimpleLookupContext lookUpURL:completionHandler:]):
482         (TEST):
483         (+[Simple3LookupContext sharedLookupContext]): Deleted.
484         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
485
486 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
487
488         [ews-build] Add configuration and architecture for windows builders
489         https://bugs.webkit.org/show_bug.cgi?id=196660
490
491         Reviewed by Lucas Forschler.
492
493         * BuildSlaveSupport/ews-build/config.json:
494
495 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
496
497         webkitpy: Don't run subsequent rounds if interrupted
498         https://bugs.webkit.org/show_bug.cgi?id=196646
499
500         Reviewed by Aakash Jain.
501
502         * Scripts/webkitpy/layout_tests/controllers/manager.py:
503         (Manager.run): Bail out if interrupted.
504
505 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
506
507         Test sessionStorage in PSON private browsing mode
508         https://bugs.webkit.org/show_bug.cgi?id=196561
509
510         Reviewed by Alex Christensen.
511
512         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
513
514 2019-04-05  Commit Queue  <commit-queue@webkit.org>
515
516         Unreviewed, rolling out r243833.
517         https://bugs.webkit.org/show_bug.cgi?id=196645
518
519         This change breaks build of WPE and GTK ports (Requested by
520         annulen on #webkit).
521
522         Reverted changeset:
523
524         "[CMake][WTF] Mirror XCode header directories"
525         https://bugs.webkit.org/show_bug.cgi?id=191662
526         https://trac.webkit.org/changeset/243833
527
528 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
529
530         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
531         https://bugs.webkit.org/show_bug.cgi?id=196635
532
533         Reviewed by Antti Koivisto.
534         
535         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
536         for a test to enable async frame scrolling via:
537             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
538         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
539         
540         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
541
542         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
543         (WTR::InjectedBundle::beginTesting):
544         * WebKitTestRunner/TestController.cpp:
545         (WTR::TestController::resetPreferencesToConsistentValues):
546
547 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
548
549         Use a correct LC_RPATH when building with ASan
550         https://bugs.webkit.org/show_bug.cgi?id=196576
551
552         Reviewed by David Kilzer.
553
554         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
555         so that ../Frameworks is checked. This is simpler and more reliable than updating
556         each SPC service xcconfig.
557
558 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
559
560         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
561         https://bugs.webkit.org/show_bug.cgi?id=196629
562
563         Reviewed by Lucas Forschler.
564
565         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
566
567 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
568
569         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
570         https://bugs.webkit.org/show_bug.cgi?id=196618
571
572         Reviewed by Lucas Forschler.
573
574         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
575         (StatusBubble): Added QUEUE_TRIGGERS.
576         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
577         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
578         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
579         its parent(builder).
580
581 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
582
583         [ews-app] Status-bubble steps are sometimes displayed in reverse order
584         https://bugs.webkit.org/show_bug.cgi?id=196625
585
586         Reviewed by Lucas Forschler.
587
588         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
589         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
590
591 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
592
593         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
594         https://bugs.webkit.org/show_bug.cgi?id=196630
595
596         Reviewed by Wenson Hsieh.
597
598         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
599
600 2019-04-04  Youenn Fablet  <youenn@apple.com>
601
602         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
603         https://bugs.webkit.org/show_bug.cgi?id=196543
604
605         Reviewed by Alex Christensen.
606
607         * WebKitTestRunner/TestController.cpp:
608         (WTR::TestController::generatePageConfiguration):
609
610 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
611
612         [ews-app] Status bubble should not display skipped buildbot steps
613         https://bugs.webkit.org/show_bug.cgi?id=196584
614
615         Reviewed by Lucas Forschler.
616
617         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
618
619 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
620
621         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
622         https://bugs.webkit.org/show_bug.cgi?id=196620
623
624         Reviewed by Lucas Forschler.
625
626         * BuildSlaveSupport/ews-app/ews/config.py:
627
628 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
629
630         [Win] DumpRenderTreeWatchDog.py is not checked into source
631         https://bugs.webkit.org/show_bug.cgi?id=196567
632         <rdar://problem/49525901>
633
634         Reviewed by Lucas Forschler.
635
636         This script is used on Win EWS bots to terminate hanging DRT processes.
637
638         * EWSTools/dumprendertreewatchdog.py: Added.
639
640 2019-04-04  Chris Dumez  <cdumez@apple.com>
641
642         Unreviewed, roll out r243858 which made tests time out.
643
644         Disable new API tests on Windows instead.
645
646         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
647         (TestWebKitAPI::TEST):
648
649 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
650
651         [ATK] Cleanup WebPageAccessibilityObjectAtk
652         https://bugs.webkit.org/show_bug.cgi?id=196537
653
654         Reviewed by Michael Catanzaro.
655
656         Also consider files under atk directories as exceptions for GObject conventions.
657
658         * Scripts/webkitpy/style/checkers/cpp.py:
659         (check_identifier_name_in_declaration):
660
661 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
662
663         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
664         https://bugs.webkit.org/show_bug.cgi?id=196588
665         <rdar://problem/49365787>
666
667         Unreviewed build fix for Windows port.
668
669         error C3861: 'kill': identifier not found
670
671         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
672         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
673
674 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
675
676         [ews-build] Cancel build and similar operations should have authentication
677         https://bugs.webkit.org/show_bug.cgi?id=196520
678
679         Reviewed by Dewei Zhu.
680
681         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
682         environment variables.
683
684 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
685
686         [ews-build] Do not trigger queues which are not in production yet
687         https://bugs.webkit.org/show_bug.cgi?id=196581
688
689         Reviewed by Dewei Zhu.
690
691         * BuildSlaveSupport/ews-build/config.json:
692
693 2019-04-03  Chris Dumez  <cdumez@apple.com>
694
695         Unreviewed, fix typo in the name of API test added in r243848.
696
697         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
698         (TestWebKitAPI::TEST):
699
700 2019-04-03  Chris Dumez  <cdumez@apple.com>
701
702         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
703         https://bugs.webkit.org/show_bug.cgi?id=196588
704         <rdar://problem/49365787>
705
706         Reviewed by Ryosuke Niwa.
707
708         Add API test coverage.
709
710         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
711         (TestWebKitAPI::nullJavaScriptCallback):
712         (TestWebKitAPI::didCrashCheckFrames):
713         (TestWebKitAPI::TEST):
714
715 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
716
717         run-webkit-tests: Upload test results (new results database)
718         https://bugs.webkit.org/show_bug.cgi?id=196577
719         <rdar://problem/34841155>
720
721         Reviewed by Lucas Forschler.
722
723         * Scripts/webkitpy/layout_tests/controllers/manager.py:
724         (Manager.run): Upload results after each device shard, since the configuration will be
725         different for each device.
726         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
727         uploaded to a results database.
728         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
729         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
730
731 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
732
733         -apple-trailing-word is needed for browser detection
734         https://bugs.webkit.org/show_bug.cgi?id=196575
735
736         Unreviewed.
737
738         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
739
740 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
741
742         [CMake][WTF] Mirror XCode header directories
743         https://bugs.webkit.org/show_bug.cgi?id=191662
744
745         Reviewed by Konstantin Tokarev.
746
747         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
748         builds.
749
750         * CMakeLists.txt:
751         * DumpRenderTree/CMakeLists.txt:
752         * DumpRenderTree/PlatformWin.cmake:
753         * MiniBrowser/win/CMakeLists.txt:
754         * TestWebKitAPI/CMakeLists.txt:
755         * TestWebKitAPI/PlatformWin.cmake:
756         * WebKitTestRunner/PlatformGTK.cmake:
757         * WebKitTestRunner/PlatformWin.cmake:
758
759 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
760
761         [ews-app] Status bubble should not display certain infrastructure status messages
762         https://bugs.webkit.org/show_bug.cgi?id=196550
763
764         Reviewed by Lucas Forschler.
765
766         Do not display the steps which are un-needed for end-user. This information is still avaiable
767         if the user click on the bubble and look at the Buildbot build.
768         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
769         (StatusBubble._steps_messages):
770         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
771
772 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
773
774         [ews-build] Use https for sending data to ews-app
775         https://bugs.webkit.org/show_bug.cgi?id=196492
776
777         Reviewed by Lucas Forschler.
778
779         * BuildSlaveSupport/ews-build/events.py:
780
781 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
782
783         Remove support for -apple-trailing-word
784         https://bugs.webkit.org/show_bug.cgi?id=196525
785
786         Reviewed by Zalan Bujtas.
787
788         This CSS property is nonstandard and not used.
789
790         * Scripts/webkitperl/FeatureList.pm:
791         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
792
793 2019-04-03  Youenn Fablet  <youenn@apple.com>
794
795         Add a test for DOMCache on multiple browsing in case of private browsing
796         https://bugs.webkit.org/show_bug.cgi?id=196524
797
798         Reviewed by Alex Christensen.
799
800         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
801         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
802
803 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
804
805         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
806         https://bugs.webkit.org/show_bug.cgi?id=196540
807
808         Reviewed by Aakash Jain.
809
810         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
811
812 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
813
814         Add plumbing for a compatibility mode preference in WebKit
815         https://bugs.webkit.org/show_bug.cgi?id=196005
816
817         Reviewed by Tim Horton.
818
819         Add new API tests.
820
821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
822         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
823
824 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
825
826         [WPE][GTK] Update libsrtp dependency package for Debian
827         https://bugs.webkit.org/show_bug.cgi?id=196528
828
829         Reviewed by Frédéric Wang.
830
831         * gtk/install-dependencies:
832         * wpe/install-dependencies:
833
834 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
835
836         [WK2] Add support for Window's beforeprint / afterprint events
837         https://bugs.webkit.org/show_bug.cgi?id=196478
838         <rdar://problem/49535124>
839
840         Unreviewed build fix for MSVC.
841
842         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
843
844         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
845
846         * WebKitTestRunner/TestController.cpp:
847         (WTR::printFrame): Use int and float literals.
848
849 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
850
851         [ews-build] Reassign bots to queues
852
853         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
854
855 2019-04-02  Chris Dumez  <cdumez@apple.com>
856
857         [WK2] Add support for Window's beforeprint / afterprint events
858         https://bugs.webkit.org/show_bug.cgi?id=196478
859
860         Reviewed by Alex Christensen.
861
862         Add minimal implementation for printFrame in WebKitTestRunner.
863
864         * WebKitTestRunner/TestController.cpp:
865         (WTR::printFrame):
866         (WTR::TestController::createOtherPage):
867         (WTR::TestController::createWebViewWithOptions):
868
869 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
870
871         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
872         https://bugs.webkit.org/show_bug.cgi?id=196491
873
874         Reviewed by Lucas Forschler.
875
876         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
877
878 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
879
880         [ews-build] Configure buildbot try credentials in environment variables
881         https://bugs.webkit.org/show_bug.cgi?id=196501
882
883         Reviewed by Lucas Forschler.
884
885         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
886         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
887         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
888
889 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
890
891         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
892         https://bugs.webkit.org/show_bug.cgi?id=196496
893         <rdar://problem/49521634>
894
895         Reviewed by Chris Dumez.
896
897         Add new API tests (see WebKit ChangeLog for more detail).
898
899         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
900         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
901         (TEST):
902
903 2019-04-02  David Kilzer  <ddkilzer@apple.com>
904
905         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
906         <https://webkit.org/b/196499>
907
908         Reviewed by Alexey Proskuryakov.
909
910         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
911         ENABLE_ADDRESS_SANITIZER.
912
913 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
914
915         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
916         https://bugs.webkit.org/show_bug.cgi?id=182757
917
918         Reviewed by Don Olmstead.
919
920         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
921         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
922
923 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
924
925         run-api-tests: Upload test results
926         https://bugs.webkit.org/show_bug.cgi?id=196323
927         <rdar://problem/49356714>
928
929         Reviewed by Lucas Forschler.
930
931         * Scripts/webkitpy/api_tests/manager.py:
932         (Manager):
933         (Manager.run): Upload results to a results database.
934         * Scripts/webkitpy/api_tests/run_api_tests.py:
935         (parse_args): Add upload arguments.
936         * Scripts/webkitpy/port/base.py:
937         (Port):
938         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
939         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
940         with commits from any other associated repositories.
941         * Scripts/webkitpy/port/device.py:
942         (Device):
943         (Device.build_version): Access build_versoin of underlying platform device.
944         * Scripts/webkitpy/port/ios_simulator_unittest.py:
945         (IOSSimulatorTest):
946         (IOSSimulatorTest.test_configuration_for_upload):
947         * Scripts/webkitpy/port/device_port.py:
948         (DevicePort):
949         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
950         the same as the machine uploading results.
951         * Scripts/webkitpy/port/mac.py:
952         (MacPort):
953         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
954         * Scripts/webkitpy/port/mac_unittest.py:
955         (MacTest):
956         (MacTest.test_configuration_for_upload):
957         * Scripts/webkitpy/xcode/simulated_device.py:
958         (SimulatedDeviceManager._create_device_with_runtime):
959         (SimulatedDevice.__init__): Create simulated device with a build_version.
960         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
961         (test_existing_simulator):
962
963 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
964
965         Remove extra newline characters (Follow-up fix to r243707)
966
967         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
968
969 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
970
971         [ews-app] Use API_KEY to accept results data
972         https://bugs.webkit.org/show_bug.cgi?id=196461
973
974         Reviewed by Dewei Zhu.
975
976         * BuildSlaveSupport/ews-app/ews/views/results.py:
977         (Results.post): Validate EWS_API_KEY before accepting any data.
978         * BuildSlaveSupport/ews-build/events.py:
979         (Events.sendData): Send EWS_API_KEY if available along with event data.
980
981 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
982
983         Unable to copy and paste a PDF from Notes into Mail compose body
984         https://bugs.webkit.org/show_bug.cgi?id=196442
985         <rdar://problem/48573098>
986
987         Reviewed by Tim Horton.
988
989         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
990         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
991         to be specified on the item providers.
992
993         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
994         (TestWebKitAPI::mapItemForTesting):
995         (TestWebKitAPI::contactItemForTesting):
996
997 2019-04-01  Tim Horton  <timothy_horton@apple.com>
998
999         Make UIWKDocumentContext rects per-character instead of per-word
1000         https://bugs.webkit.org/show_bug.cgi?id=196459
1001
1002         Reviewed by Wenson Hsieh.
1003
1004         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1005         (TEST):
1006         Adjust test results due to switching to per-character rects.
1007
1008 2019-04-01  Chris Dumez  <cdumez@apple.com>
1009
1010         UIProcess crash when a prewarmed process is terminated
1011         https://bugs.webkit.org/show_bug.cgi?id=196451
1012         <rdar://problem/49245471>
1013
1014         Reviewed by Geoffrey Garen.
1015
1016         Add API test coverage.
1017
1018         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1019         (TEST):
1020
1021 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1022
1023         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1024         https://bugs.webkit.org/show_bug.cgi?id=196449
1025
1026         Reviewed by Lucas Forschler.
1027
1028         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1029         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1030         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1031         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1032
1033 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1034
1035         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1036         https://bugs.webkit.org/show_bug.cgi?id=196444
1037
1038         Reviewed by Lucas Forschler.
1039
1040         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1041
1042 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1043
1044         Add SPI to canonicalize NSURLs with WTF::URL
1045         https://bugs.webkit.org/show_bug.cgi?id=196415
1046         <rdar://problem/44980271>
1047
1048         Reviewed by Darin Adler.
1049
1050         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1051         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1052         (TestWebKitAPI::TEST):
1053
1054 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1055
1056         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1057         https://bugs.webkit.org/show_bug.cgi?id=196441
1058
1059         Reviewed by Carlos Garcia Campos.
1060
1061         Don't cache the wpe_view_backend object that might not exist yet at the
1062         time of EventSenderProxy constructor invocation, but instead retrieve
1063         that object whenever it's required for event dispatching. This should
1064         avoid crashes in this constructor now that it's invoked before any
1065         PlatformWindow has been set up (as changed in r243496).
1066
1067         * WebKitTestRunner/EventSenderProxy.h:
1068         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1069         (WTR::viewBackend):
1070         (WTR::EventSenderProxy::EventSenderProxy):
1071         (WTR::EventSenderProxy::mouseDown):
1072         (WTR::EventSenderProxy::mouseUp):
1073         (WTR::EventSenderProxy::mouseMoveTo):
1074         (WTR::EventSenderProxy::mouseScrollBy):
1075         (WTR::EventSenderProxy::keyDown):
1076         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1077
1078 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1079
1080         [Win][WebKit] MiniBrowser should support high DPI display
1081         https://bugs.webkit.org/show_bug.cgi?id=196391
1082
1083         Reviewed by Alex Christensen.
1084
1085         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1086         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1087         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1088         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1089
1090 2019-03-31  Sam Weinig  <weinig@apple.com>
1091
1092         Remove more i386 specific configurations
1093         https://bugs.webkit.org/show_bug.cgi?id=196430
1094
1095         Reviewed by Alexey Proskuryakov.
1096
1097         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1098         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1099
1100 2019-03-31  Andy Estes  <aestes@apple.com>
1101
1102         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1103         https://bugs.webkit.org/show_bug.cgi?id=196433
1104         <rdar://problem/49293305>
1105
1106         Reviewed by Tim Horton.
1107
1108         Enhanced API test coverage to include all navigation response policy decisions in both
1109         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1110
1111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1112         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1113         (TestWebKitAPI::TEST):
1114         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1115         (readFile):
1116         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1117         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1118         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1119         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1120         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1121         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1122         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1123         (-[QuickLookDelegate _downloadDidStart:]):
1124         (-[QuickLookDelegate _download:didReceiveResponse:]):
1125         (-[QuickLookDelegate _download:didReceiveData:]):
1126         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1127         (-[QuickLookDelegate _downloadDidFinish:]):
1128         (-[QuickLookDelegate _download:didFailWithError:]):
1129         (-[QuickLookDelegate _downloadDidCancel:]):
1130         (-[QuickLookDelegate verifyDownload]):
1131         (runTest):
1132         (runTestDecideBeforeLoading):
1133         (runTestDecideAfterLoading):
1134         (TEST):
1135         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1136         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1137         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1138         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1139         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1140         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1141         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1142         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1143         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1144         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1145         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1146         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1147         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1148         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1149
1150 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1151
1152         [CMake] add testdfg as target with build-jsc
1153         https://bugs.webkit.org/show_bug.cgi?id=196393
1154
1155         Reviewed by Saam Barati.
1156
1157         Added testdfg as one of the targets to build when
1158         using CMake.
1159
1160         * Scripts/build-jsc:
1161
1162 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1163
1164         Delete WebMetal implementation in favor of WebGPU
1165         https://bugs.webkit.org/show_bug.cgi?id=195418
1166
1167         Reviewed by Dean Jackson.
1168
1169         * DumpRenderTree/mac/DumpRenderTree.mm:
1170         (enableExperimentalFeatures):
1171         (resetWebPreferencesToConsistentValues):
1172         * Scripts/webkitperl/FeatureList.pm:
1173         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1175         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1176         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1177         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1178         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1179         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1180         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1181         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1182         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1183         (WTR::InjectedBundle::beginTesting):
1184         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1185         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1186         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1187
1188 2019-03-29  Chris Dumez  <cdumez@apple.com>
1189
1190         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1191         https://bugs.webkit.org/show_bug.cgi?id=196405
1192         <rdar://problem/49428130>
1193
1194         Reviewed by Wenson Hsieh.
1195
1196         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1197         the popover presentation methods to be no-ops. Use this in the new test added in
1198         r243523 so that we do not swizzle those methods for all tests. This is needed because
1199         those WatchOS tests rely on the popover getting presented and interactive.
1200
1201         * WebKitTestRunner/TestController.cpp:
1202         (WTR::updateTestOptionsFromTestHeader):
1203         * WebKitTestRunner/TestController.h:
1204         * WebKitTestRunner/TestOptions.h:
1205         (WTR::TestOptions::hasSameInitializationOptions const):
1206         * WebKitTestRunner/ios/TestControllerIOS.mm:
1207         (WTR::TestController::platformInitialize):
1208         (WTR::TestController::platformResetStateToConsistentValues):
1209
1210 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1211
1212         [Curl] Add Server Trust Evaluation Support.
1213         https://bugs.webkit.org/show_bug.cgi?id=191646
1214
1215         Reviewed by Fujii Hironori.
1216
1217         Implemented MiniBrowser UI for asking if user trusts the server.
1218
1219         * MiniBrowser/win/Common.cpp:
1220         (askServerTrustEvaluation):
1221         (replaceString):
1222         * MiniBrowser/win/Common.h:
1223         * MiniBrowser/win/MiniBrowserLib.rc:
1224         * MiniBrowser/win/MiniBrowserLibResource.h:
1225         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1226         (createPEMString):
1227         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1228         (WebKitBrowserWindow::canTrustServerCertificate):
1229         * MiniBrowser/win/WebKitBrowserWindow.h:
1230
1231 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1232
1233         Implement ResizeObserver.
1234         https://bugs.webkit.org/show_bug.cgi?id=157743
1235
1236         Reviewed by Simon Fraser.
1237
1238         Support resizeObserverEnabled webPreferences.
1239
1240         * DumpRenderTree/TestOptions.cpp:
1241         (TestOptions::TestOptions):
1242         * DumpRenderTree/TestOptions.h:
1243         * DumpRenderTree/mac/DumpRenderTree.mm:
1244         (setWebPreferencesForTestOptions):
1245         * DumpRenderTree/win/DumpRenderTree.cpp:
1246         (enableExperimentalFeatures):
1247         * Scripts/webkitperl/FeatureList.pm:
1248         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1249
1250 2019-03-28  John Wilander  <wilander@apple.com>
1251
1252         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1253         https://bugs.webkit.org/show_bug.cgi?id=196281
1254         <rdar://problem/48938748>
1255
1256         Reviewed by Alex Christensen.
1257
1258         This patch adds the function isStatisticsHasLocalStorage() to the
1259         TestRunner. With it, the page can query the WebsiteDataStore in the
1260         UI process to make sure that it sees LocalStorage.
1261
1262         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1263         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1264         (WTR::TestRunner::isStatisticsHasLocalStorage):
1265         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1266         * WebKitTestRunner/TestController.cpp:
1267         (WTR::TestController::isStatisticsHasLocalStorage):
1268         * WebKitTestRunner/TestController.h:
1269         * WebKitTestRunner/TestInvocation.cpp:
1270         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1271
1272 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1273
1274         API::Data::createWithoutCopying should do a null check before calling CFRelease
1275         https://bugs.webkit.org/show_bug.cgi?id=196276
1276         <rdar://problem/48059859>
1277
1278         Reviewed by Alex Christensen.
1279
1280         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1281
1282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1283         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1284         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1285         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1286         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1287         (TestWebKitAPI::TEST):
1288
1289 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1290
1291         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1292         https://bugs.webkit.org/show_bug.cgi?id=186276
1293
1294         Reviewed by Carlos Garcia Campos.
1295
1296         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1297         (webViewLoadChanged):
1298         (testWebResourceGetDataError):
1299         (testWebResourceGetDataEmpty):
1300         (beforeAll):
1301         (webViewloadChanged): Deleted.
1302
1303 2019-03-27  Andy Estes  <aestes@apple.com>
1304
1305         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1306         https://bugs.webkit.org/show_bug.cgi?id=196317
1307
1308         Reviewed by Dan Bernstein.
1309
1310         package-root copies built products into a staging directory using ditto(1), which does not
1311         follow symbolic links as it traverses a directory. Now that the files in
1312         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1313         itself, these become broken links when ditto'd into the staging directory.
1314
1315         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1316
1317         * Scripts/package-root:
1318
1319 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1320
1321         [ews-app] Update display text of Submit for ews analysis
1322         https://bugs.webkit.org/show_bug.cgi?id=196309
1323
1324         Reviewed by Dewei Zhu.
1325
1326         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1327
1328 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1329
1330         run-webkit-tests should check for leaks in WebKit processes
1331         <https://webkit.org/b/193772>
1332         <rdar://problem/46526680>
1333
1334         Reviewed by Ryosuke Niwa.
1335
1336         This works by doing the following:
1337         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1338           The list of child processes are returned one per line:
1339           process.name: pid
1340         - Run the "#LIST CHILD PROCESSES" command just before the
1341           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1342           processes on the ServerProcess object.
1343         - When the `--leaks` switch is handled, run check_for_leaks() on
1344           each child process after the main test harness.
1345
1346         * DumpRenderTree/mac/DumpRenderTree.mm:
1347         (handleControlCommand):
1348         - Use strncmp() instead of strcmp().
1349         - Add support for handling "#LIST CHILD PROCESSES" command.
1350
1351         * Scripts/webkitpy/port/base.py:
1352         (Port.check_for_leaks):
1353         * Scripts/webkitpy/port/darwin.py:
1354         (DarwinPort.check_for_leaks):
1355         - Rename redundant 'process_pid' argument to 'process_id'.
1356
1357         * Scripts/webkitpy/port/driver.py:
1358         (Driver.do_post_tests_work):
1359         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1360           longer the only command this sends to WebKitTestRunner.
1361         - If the `--leaks` switch is present, send the
1362           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1363           result using Port.set_webkit_processes().
1364         (Driver._parse_child_processes_output):
1365         - Add helper method to parse list of child process names and
1366           process IDs returned from WebKitTestRunner.
1367
1368         * Scripts/webkitpy/port/ios_device.py:
1369         (IOSDevicePort.check_for_leaks):
1370         - Rename redundant 'process_pid' argument to 'process_id'.
1371
1372         * Scripts/webkitpy/port/leakdetector.py:
1373         (LeakDetector._parse_leaks_output):
1374         - Return early if there is no leaks_output.
1375         (LeakDetector.check_for_leaks):
1376         - Rename redundant 'process_pid' argument to 'process_id'.
1377
1378         * Scripts/webkitpy/port/server_process.py:
1379         (ServerProcess.__init__):
1380         (ServerProcess.child_processes):
1381         (ServerProcess.set_child_processes):
1382         - Add instance variable to Port to store list of child process
1383           names and process IDs returned from WebKitTestRunner.
1384         (ServerProcess._start):
1385         - Clear self._child_processes.
1386         (ServerProcess.stop):
1387         - If self._child_processes is set, call
1388           self._port.check_for_leaks() for each child process.
1389
1390         * Scripts/webkitpy/port/server_process_unittest.py:
1391         (TrivialMockPort.check_for_leaks):
1392         - Rename redundant 'process_pid' argument to 'process_id'.
1393
1394         * Scripts/webkitpy/port/simulator_process.py:
1395         (SimulatorProcess.stop):
1396         - If self._child_processes is set, call
1397           self._port.check_for_leaks() for each child process.
1398
1399         * Scripts/webkitpy/port/watch_device.py:
1400         (WatchDevicePort.check_for_leaks):
1401         - Rename redundant 'process_pid' argument to 'process_id'.
1402
1403         * WebKitTestRunner/TestController.cpp:
1404         (WTR::TestController::dumpResponse):
1405         - Extract method from findAndDumpWorldLeaks() so that it may be
1406           reused by findAndDumpWebKitProcessIdentifiers().
1407         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1408         - Add method to output process name and process ID of both the
1409           WebContent and Networking processes.
1410         (WTR::TestController::findAndDumpWorldLeaks):
1411         - Fix missing newline in output when there were no abandoned
1412           documents.
1413         - Call dumpResponse() for extracted code.
1414         (WTR::TestController::handleControlCommand):
1415         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1416         - Use strncmp() instead of strcmp().
1417         - Call findAndDumpWebKitProcessIdentifiers() when
1418           "#LIST CHILD PROCESSES" command is sent.
1419         * WebKitTestRunner/TestController.h:
1420         (WTR::TestController::dumpResponse):
1421         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1422         - Declare methods.
1423
1424 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1425
1426         Unreviewed. Add GLib API test cases after r243434.
1427
1428         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1429         (testWebViewActiveURI):
1430         (serverCallback):
1431         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1432         (sendRequestCallback):
1433
1434 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1435
1436         Geolocation request not complete when watch request was started in a different web process
1437         https://bugs.webkit.org/show_bug.cgi?id=195996
1438
1439         Reviewed by Alex Christensen.
1440
1441         Add a test case.
1442
1443         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1444         (TestWebKitAPI::runJavaScriptAlert):
1445         (TestWebKitAPI::TEST):
1446
1447 2019-03-26  Keith Rollin  <krollin@apple.com>
1448
1449         Update the way generate-xcfilelists returns strings from functions
1450         https://bugs.webkit.org/show_bug.cgi?id=195975
1451         <rdar://problem/49040807>
1452
1453         Reviewed by Dean Jackson.
1454
1455         There are places where generate-xcfilelists executes assignments with
1456         statements like:
1457
1458             FOO=$(some_function)
1459
1460         where "some_function" return a string by echoing it. E.g.
1461
1462             some_function()
1463             {
1464                 echo "Hello, World"
1465             }
1466
1467         This is a common idiom, but it has a problem if "some_function" needs
1468         to call "exit" in an attempt to halt the entire script right then and
1469         there. Since "some_function" is called inside of $(), it's being
1470         executed in a sub-shell. Calling exit in that sub-shell simply exits
1471         that shell; it doesn't not exit the outer shell in which the main part
1472         of the script is still running. As such, the main script keeps
1473         executing when the intent was for the script to halt.
1474
1475         The solution to this is to use a different idiom for returning
1476         strings. The one we now is to pass in the name of the variable to
1477         receive the string result:
1478
1479             some_function()
1480             {
1481                 variable_name=$1
1482                 eval $variable_name ="Hello, World"
1483             }
1484
1485         The call site now looks like
1486
1487             some_function FOO
1488
1489         Because there's no invocation of a sub-shell, some_function can now
1490         call "exit" if it wants to, and the entire script will exit at that
1491         point.
1492
1493         * Scripts/generate-xcfilelists:
1494
1495 2019-03-26  Chris Dumez  <cdumez@apple.com>
1496
1497         Add basic layout test coverage for File Picker on iOS
1498         https://bugs.webkit.org/show_bug.cgi?id=196265
1499
1500         Reviewed by Wenson Hsieh.
1501
1502         Add layout test infrastructure to test the file picker on iOS.
1503
1504         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1505         (WTR::UIScriptController::dismissFilePicker):
1506         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1507         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1508         (WTR::UIScriptController::dismissFilePicker):
1509         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1510         * WebKitTestRunner/TestController.cpp:
1511         (WTR::TestController::createWebViewWithOptions):
1512         (WTR::updateTestOptionsFromTestHeader):
1513         * WebKitTestRunner/TestOptions.h:
1514         (WTR::TestOptions::hasSameInitializationOptions const):
1515         * WebKitTestRunner/ios/TestControllerIOS.mm:
1516         (overridePresentViewController):
1517         (WTR::TestController::platformInitialize):
1518         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1519         (WTR::UIScriptController::dismissFilePicker):
1520
1521 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1522
1523         Implement async paste method on UIWKInteractionViewProtocol
1524         https://bugs.webkit.org/show_bug.cgi?id=196267
1525         <rdar://problem/49236346>
1526
1527         Reviewed by Tim Horton.
1528
1529         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1530         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1531         are now a part of all iOS 12 internal SDKs.
1532
1533         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1534
1535         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1536         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1537
1538         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1539         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1540         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1541         * TestWebKitAPI/ios/UIKitSPI.h:
1542
1543 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1544
1545         [ews-build] Use PostgreSQL for ews.webkit.org database
1546         https://bugs.webkit.org/show_bug.cgi?id=196270
1547
1548         Reviewed by Lucas Forschler.
1549
1550         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1551
1552 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1553
1554         [ews] Reset simctl states on reboot
1555         https://bugs.webkit.org/show_bug.cgi?id=196260
1556
1557         Rubber-stamped by Aakash Jain.
1558
1559         * EWSTools/start-queue-mac.sh:
1560
1561 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1562
1563         [ews-build] Use PostgreSQL for ews-build database
1564         https://bugs.webkit.org/show_bug.cgi?id=196229
1565
1566         Reviewed by Lucas Forschler.
1567
1568         * BuildSlaveSupport/ews-build/master.cfg:
1569
1570 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1571
1572         [ews-build] Get master_hostname dynamically in master.cfg
1573         https://bugs.webkit.org/show_bug.cgi?id=196255
1574
1575         Reviewed by Lucas Forschler.
1576
1577         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1578         send events data in test mode.
1579
1580 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1581
1582         [ews-app] Set db_constraint to False for Foreign Keys
1583         https://bugs.webkit.org/show_bug.cgi?id=196252
1584
1585         Reviewed by Lucas Forschler.
1586
1587         * BuildSlaveSupport/ews-app/ews/models/build.py:
1588         * BuildSlaveSupport/ews-app/ews/models/step.py:
1589
1590 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1591
1592         [ews-build] is_test_mode_enabled should default to True
1593         https://bugs.webkit.org/show_bug.cgi?id=196248
1594
1595         Reviewed by Lucas Forschler.
1596
1597         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1598
1599 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1600
1601         [ews-app] Add webkitperl to ENABLED_QUEUES
1602         https://bugs.webkit.org/show_bug.cgi?id=196253
1603
1604         Reviewed by Lucas Forschler.
1605
1606         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1607
1608 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1609
1610         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1611         https://bugs.webkit.org/show_bug.cgi?id=196211
1612         rdar://problem/49110552
1613
1614         Reviewed by Tim Horton.
1615
1616         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1617         Make sure that EventSenderProxy always exists when running tests. We used to create
1618         it when resetting before the first test, which is a bit too late.
1619
1620         * WebKitTestRunner/TestController.h:
1621         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1622         (WTR::TestController::platformCreateWebView):
1623         (WTR::TestController::platformCreateOtherPage):
1624         (WTR::TestController::finishCreatingPlatformWebView):
1625         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1626         (WTR::PlatformWebView::PlatformWebView):
1627         Moved some code that made NSWindow use NSEvent during web view creation. We may
1628         need to move more if some other case us found, but this is enough for now.
1629
1630 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1631
1632         Unreviewed. Fix typo in GLib geolocation API after r243285.
1633
1634         gelocation -> geolocation.
1635
1636         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1637         (testGeolocationManagerWatchPosition):
1638
1639 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1640
1641         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1642         https://bugs.webkit.org/show_bug.cgi?id=196213
1643
1644         Reviewed by Geoff Garen.
1645
1646         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1647         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1648         (credentialWithIdentityAndKeychainPath):
1649         (-[ChallengeDelegate webView:didFinishNavigation:]):
1650         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1651         (TestWebKitAPI::TEST):
1652
1653 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1654
1655         Expected shouldn't assume its contained types are copyable
1656         https://bugs.webkit.org/show_bug.cgi?id=195986
1657
1658         Reviewed by JF Bastien.
1659
1660         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1661         (TestWebKitAPI::NonCopyable::operator== const):
1662         (TestWebKitAPI::NonCopyable::operator!= const):
1663         (TestWebKitAPI::TEST):
1664
1665 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1666
1667         Remove some now-unnecessary dynamic class lookup
1668         https://bugs.webkit.org/show_bug.cgi?id=196237
1669
1670         Reviewed by Simon Fraser.
1671
1672         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1673         (makeRequest):
1674         (TEST):
1675
1676 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1677
1678         Unreviewed, rolling out r243450.
1679
1680         AppleWin and WinCairo port builds get broken.
1681
1682         Reverted changeset:
1683
1684         "Add test for fix of #196095"
1685         https://bugs.webkit.org/show_bug.cgi?id=196097
1686         https://trac.webkit.org/changeset/243450
1687
1688 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1689
1690         Unreviewed, rolling out r243465.
1691         https://bugs.webkit.org/show_bug.cgi?id=196226
1692
1693         the test doesn't build (Requested by thorton on #webkit).
1694
1695         Reverted changeset:
1696
1697         "Do not terminate the NetworkProcess if a third party
1698         application sends a NSCredential with a SecIdentityRef"
1699         https://bugs.webkit.org/show_bug.cgi?id=196213
1700         https://trac.webkit.org/changeset/243465
1701
1702 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1703
1704         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1705         https://bugs.webkit.org/show_bug.cgi?id=196213
1706
1707         Reviewed by Geoff Garen.
1708
1709         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1710         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1711         (credentialWithIdentityAndKeychainPath):
1712         (-[ChallengeDelegate webView:didFinishNavigation:]):
1713         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1714         (TestWebKitAPI::TEST):
1715
1716 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1717
1718         [ews-build] Gracefully handle missing patch_id in events
1719         https://bugs.webkit.org/show_bug.cgi?id=196216
1720
1721         Reviewed by Lucas Forschler.
1722
1723         * BuildSlaveSupport/ews-build/events.py:
1724
1725 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1726
1727         [ews-build] use lz4 compression for improving buildbot performance
1728         https://bugs.webkit.org/show_bug.cgi?id=196155
1729
1730         Reviewed by Lucas Forschler.
1731
1732         * BuildSlaveSupport/ews-build/master.cfg:
1733
1734 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1735
1736         Pull some API testing helper methods out of TestWKWebView
1737         https://bugs.webkit.org/show_bug.cgi?id=196212
1738
1739         Reviewed by Tim Horton.
1740
1741         Refactor some more API testing utility methods, so that they can be used in
1742         tests that do not use TestWKWebView.
1743
1744         * TestWebKitAPI/cocoa/TestWKWebView.h:
1745         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1746         (-[WKWebView loadTestPageNamed:]):
1747         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1748         (-[WKWebView synchronouslyLoadHTMLString:]):
1749         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1750         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1751         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1752         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1753         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1754
1755 2019-03-25  Jer Noble  <jer.noble@apple.com>
1756
1757         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1758         https://bugs.webkit.org/show_bug.cgi?id=196097
1759
1760         Reviewed by Eric Carlson.
1761
1762         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1763
1764         * DumpRenderTree/mac/DumpRenderTree.mm:
1765         (resetWebPreferencesToConsistentValues):
1766         * WebKitTestRunner/TestController.cpp:
1767         (WTR::TestController::resetPreferencesToConsistentValues):
1768
1769 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1770
1771         Pull IPadUserInterfaceSwizzler out into a separate header file
1772         https://bugs.webkit.org/show_bug.cgi?id=196193
1773
1774         Reviewed by Anders Carlsson.
1775
1776         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1777         be used in other API tests.
1778
1779         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1780         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1781         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1782         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1783         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1784         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1785         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1786
1787 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1788
1789         Remove NavigatorContentUtils in WebCore/Modules
1790         https://bugs.webkit.org/show_bug.cgi?id=196070
1791
1792         Reviewed by Alex Christensen.
1793
1794         NavigatorContentUtils was to support the custom scheme spec [1].
1795         However, in WebKit side, no port has supported the feature in
1796         WebKit layer after EFL port was removed. So there has been the
1797         only IDL implementation of the NavigatorContentUtils in WebCore.
1798         So we don't need to keep the implementation in WebCore anymore.
1799
1800         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1801
1802         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1803
1804 2019-03-24  Andy Estes  <aestes@apple.com>
1805
1806         [watchOS] Remove unused Proximity Networking code
1807         https://bugs.webkit.org/show_bug.cgi?id=196188
1808
1809         Reviewed by Tim Horton.
1810
1811         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1812         (TEST):
1813
1814 2019-03-23  Keith Miller  <keith_miller@apple.com>
1815
1816         Refactor clz/ctz and fix getLSBSet.
1817         https://bugs.webkit.org/show_bug.cgi?id=196162
1818
1819         Reviewed by Saam Barati.
1820
1821         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1822
1823         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1824         (TestWebKitAPI::TEST):
1825
1826 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1827
1828         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1829         https://bugs.webkit.org/show_bug.cgi?id=196143
1830
1831         Reviewed by Michael Catanzaro.
1832
1833         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1834         directories.
1835
1836         * Scripts/webkitpy/style/checkers/cpp.py:
1837         (check_identifier_name_in_declaration):
1838         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1839         (WebKitStyleTest.test_names):
1840
1841 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1842
1843         [Flatpak] Manifest expanding fails for qt WPE extension
1844         https://bugs.webkit.org/show_bug.cgi?id=196148
1845
1846         Reviewed by Alex Christensen.
1847
1848         * flatpak/flatpakutils.py:
1849         (expand_submodules_recurse): The last recurse manifest expand
1850         iteration might lead to a single module so take it into account
1851         and don't try to recurse further.
1852
1853 2019-03-22  Chris Dumez  <cdumez@apple.com>
1854
1855         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1856         https://bugs.webkit.org/show_bug.cgi?id=195348
1857         <rdar://problem/48622090>
1858
1859         Reviewed by Alex Christensen.
1860
1861         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1862         to NO when test.options().shouldIgnoreMetaViewport is false.
1863
1864         * WebKitTestRunner/ios/TestControllerIOS.mm:
1865         (WTR::TestController::platformConfigureViewForTest):
1866
1867 2019-03-22  Chris Dumez  <cdumez@apple.com>
1868
1869         Prewarmed processes should be usable with any website data store
1870         https://bugs.webkit.org/show_bug.cgi?id=196104
1871
1872         Reviewed by Alex Christensen.
1873
1874         Add API test coverage.
1875
1876         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1877         (runInitialWarmedProcessUsedTest):
1878         (TEST):
1879
1880 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1881
1882         Back out local changes to Alex's Subversion working directory
1883
1884         They were accidentally committed.
1885
1886         * Scripts/webkitpy/common/system/abstractexecutive.py:
1887         (AbstractExecutive.wait_newest):
1888         * Scripts/webkitpy/common/system/executive.py:
1889         (Executive.running_pids):
1890         * Scripts/webkitpy/common/system/executive_mock.py:
1891         (MockExecutive.running_pids):
1892         * Scripts/webkitpy/common/system/executive_unittest.py:
1893         (ExecutiveTest.serial_test_running_pids):
1894         * Scripts/webkitpy/port/darwin.py:
1895         (DarwinPort.check_for_leaks):
1896         * Scripts/webkitpy/port/leakdetector.py:
1897         (LeakDetector.check_for_leaks):
1898         - This was the hack attached to Bug 193772.
1899
1900         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1901         (+[WebKitTestRunnerEvent mouseLocation]):
1902         - This works around a crash on an internal build.
1903
1904 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1905
1906         Fix the build after r243354
1907         https://bugs.webkit.org/show_bug.cgi?id=196138
1908         <rdar://problem/49145951>
1909
1910         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1911         (TEST):
1912         * TestWebKitAPI/ios/UIKitSPI.h:
1913
1914 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1915
1916         Adopt UIWKDocumentContext
1917         https://bugs.webkit.org/show_bug.cgi?id=196040
1918         <rdar://problem/48642440>
1919
1920         Reviewed by Ryosuke Niwa.
1921
1922         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1923         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1924         (makeRequest):
1925         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1926         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1927         (applyStyle):
1928         (TEST):
1929         Add tests for UIWKDocumentContext.
1930
1931         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1932         (TEST):
1933         (recursiveFindWKContentView): Deleted.
1934         * TestWebKitAPI/cocoa/TestWKWebView.h:
1935         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1936         (recursiveFindWKContentView):
1937         (-[TestWKWebView wkContentView]):
1938         * TestWebKitAPI/ios/UIKitSPI.h:
1939         Share the WKContentView finding code between tests.
1940
1941 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1942
1943         [iOS WK2] Turn on async overflow scrolling by default
1944         https://bugs.webkit.org/show_bug.cgi?id=196011
1945         rdar://problem/48453859
1946
1947         Reviewed by Antti Koivisto.
1948         
1949         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1950         since so many basic layout tests have different results when compositing is triggered for
1951         overflow.
1952         
1953         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1954
1955         * WebKitTestRunner/TestController.cpp:
1956         (WTR::TestController::resetPreferencesToConsistentValues):
1957
1958 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1959
1960         [ews-build] Retry API test in case of failures
1961         https://bugs.webkit.org/show_bug.cgi?id=196004
1962
1963         Reviewed by Lucas Forschler.
1964
1965         * BuildSlaveSupport/ews-build/steps.py:
1966         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1967         (CompileWebKitToT.doStepIf): Ditto.
1968         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1969         (ReRunAPITests): Re-run API tests.
1970         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1971         (RunAPITestsWithoutPatch): Run API tests without patch.
1972         (RunAPITestsWithoutPatch.doStepIf):
1973         (RunAPITestsWithoutPatch.hideStepIf):
1974         (RunAPITestsWithoutPatch.evaluateCommand):
1975         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1976         (AnalyzeAPITestsResults.start):
1977         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1978         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1979         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1980         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1981
1982 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1983
1984         [ews-build] Update queues configurations
1985         https://bugs.webkit.org/show_bug.cgi?id=196074
1986
1987         Reviewed by Dewei Zhu.
1988
1989         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1990         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1991
1992 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1993
1994         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1995         https://bugs.webkit.org/show_bug.cgi?id=195680
1996         <rdar://problem/48903534>
1997
1998         Unreviewed infrastructure fix.
1999
2000         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2001         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2002
2003 2019-03-21  Andy Estes  <aestes@apple.com>
2004
2005         [iOS] Apple Pay should be available in documents with no user agent scripts
2006         https://bugs.webkit.org/show_bug.cgi?id=196061
2007         <rdar://problem/48649391>
2008
2009         Reviewed by Brady Eidson.
2010
2011         Added API tests and related infrastructure.
2012
2013         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2014         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2015         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2016         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2017         (TestWebKitAPI::TEST):
2018         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2019         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2020         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2021         * TestWebKitAPI/cocoa/TestProtocol.mm:
2022         (-[TestProtocol startLoading]):
2023         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2024         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2025         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2026         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2027
2028 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2029
2030         REGRESSSION (r243297): webkitpy tests broken
2031         https://bugs.webkit.org/show_bug.cgi?id=196108
2032
2033         Reviewed by Aakash Jain.
2034
2035         r243297 updated contributors.json, which broke a few unit tests.
2036
2037         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2038         (IRCCommandTest.test_whois):
2039         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2040
2041 2019-03-21  Chris Dumez  <cdumez@apple.com>
2042
2043         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2044         https://bugs.webkit.org/show_bug.cgi?id=196041
2045         <rdar://problem/49083230>
2046
2047         Reviewed by Alex Christensen.
2048
2049         Add API test coverage.
2050
2051         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2052         (TEST):
2053
2054 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2055
2056         Add SPI to inform applications of WKContentRuleList actions
2057         https://bugs.webkit.org/show_bug.cgi?id=195965
2058         <rdar://problem/42664365>
2059
2060         Reviewed by Geoff Garen.
2061
2062         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2063         (TestWebKitAPI::allActionsForResourceLoad):
2064         (TestWebKitAPI::testRequest):
2065         (TestWebKitAPI::TEST_F):
2066         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2067         (Notification::description):
2068         (Notification::operator== const):
2069         (toVector):
2070         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2071         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2072         (makeContentRuleList):
2073         (TEST):
2074         (makeWarnContentRuleList): Deleted.
2075
2076 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2077
2078         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2079         https://bugs.webkit.org/show_bug.cgi?id=196088
2080
2081         Reviewed by Brian Burg.
2082
2083         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2084         Support checks when only one platform is specified. Also deprecate macosx() and
2085         force the use of macos() instead.
2086
2087         * Scripts/webkitpy/style/checkers/cpp.py:
2088         (check_min_versions_of_wk_api_available):
2089         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2090         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2091
2092 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2093
2094         Update status inactive committers' status to 'contributor'.
2095
2096         * Scripts/webkitpy/common/config/contributors.json:
2097
2098 2019-03-21  Xan Lopez  <xan@igalia.com>
2099
2100         [JSC][x86] Drop support for x87 floating point
2101         https://bugs.webkit.org/show_bug.cgi?id=194853
2102
2103         Reviewed by Don Olmstead.
2104
2105         Force SSE2 on x86/32bit builds.
2106
2107         * Scripts/webkitdirs.pm:
2108         (generateBuildSystemFromCMakeProject):
2109
2110 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2111
2112         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2113         https://bugs.webkit.org/show_bug.cgi?id=196073
2114
2115         Reviewed by Michael Catanzaro.
2116
2117         Add test cases to check functions and constructors with no arguments but receiving user data.
2118
2119         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2120         (checkUserData):
2121         (testJSCFunction):
2122         (fooCreateWithUserData):
2123         (testJSCClass):
2124
2125 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2126
2127         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2128
2129         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2130
2131         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2132
2133 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2134
2135         [GTK][WPE] Add API to provide geolocation information
2136         https://bugs.webkit.org/show_bug.cgi?id=195940
2137
2138         Reviewed by Michael Catanzaro.
2139
2140         Add a new test to check the new API.
2141
2142         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2143         (testGeolocationManagerCurrentPosition):
2144         (testGeolocationManagerWatchPosition):
2145         (beforeAll):
2146         (afterAll):
2147         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2148         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2149         (beforeAll): Ditto.
2150         * TestWebKitAPI/glib/CMakeLists.txt:
2151
2152 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2153
2154         [GLib] Returning G_TYPE_OBJECT from a method does not work
2155         https://bugs.webkit.org/show_bug.cgi?id=195574
2156
2157         Reviewed by Michael Catanzaro.
2158
2159         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2160
2161         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2162         (getGFile):
2163         (getParent):
2164         (createGString):
2165         (getGString):
2166         (getGStringCopyWillRaise):
2167         (getGStringCopy):
2168         (getGStringStr):
2169         (getGStringLen):
2170         (freeGString):
2171         (testJSCClass):
2172
2173 2019-03-20  Saam Barati  <sbarati@apple.com>
2174
2175         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2176         https://bugs.webkit.org/show_bug.cgi?id=195721
2177
2178         Reviewed by Filip Pizlo.
2179
2180         * Scripts/run-javascriptcore-tests:
2181
2182 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2183
2184         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2185         https://bugs.webkit.org/show_bug.cgi?id=196049
2186
2187         Reviewed by Tim Horton.
2188
2189         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2190         overflow scrolling in general, so rename it.
2191
2192         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2193
2194 2019-03-20  Daniel Bates  <dabates@apple.com>
2195
2196         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2197         https://bugs.webkit.org/show_bug.cgi?id=196031
2198         <rdar://problem/49078172>
2199
2200         Reviewed by Tim Horton.
2201
2202         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2203         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2204         same code path used when the Done button is pressed to dismiss the <select> picker.
2205
2206         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2207         (TestWebKitAPI::TEST):
2208
2209 2019-03-20  Chris Dumez  <cdumez@apple.com>
2210
2211         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2212         https://bugs.webkit.org/show_bug.cgi?id=196029
2213         <rdar://problem/48954651>
2214
2215         Reviewed by Tim Horton.
2216
2217         Add API test coverage.
2218
2219         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2220
2221 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2222
2223         [ews-build] Improve failure summary string for ApplyPatch step
2224         https://bugs.webkit.org/show_bug.cgi?id=195995
2225
2226         Reviewed by Alexey Proskuryakov.
2227
2228         * BuildSlaveSupport/ews-build/steps.py:
2229         (ApplyPatch.getResultSummary): Override getResultSummary.
2230
2231 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2232
2233         AX: Implement support for new meter ARIA role
2234         https://bugs.webkit.org/show_bug.cgi?id=195966
2235
2236         Reviewed by Chris Fleizach.
2237
2238         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2239         to AXLevelIndicator.
2240
2241         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2242
2243 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2244
2245         [WebAuthN] Implement FIDO AppID extension
2246         https://bugs.webkit.org/show_bug.cgi?id=143491
2247         <rdar://problem/48298273>
2248
2249         Reviewed by Brent Fulgham.
2250
2251         Add a test that covers the new flag of convertToU2fSignCommand.
2252
2253         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2254         (TestWebKitAPI::TEST):
2255         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2256         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2257         (TestWebKitAPI::TEST):
2258
2259 2019-03-19  Keith Rollin  <krollin@apple.com>
2260
2261         Add support for more platforms to generate-xcfilelists
2262         https://bugs.webkit.org/show_bug.cgi?id=195977
2263
2264         Reviewed by Alexey Proskuryakov.
2265
2266         generate-xcfilelists incorrectly complains when involved with building
2267         WebKit for iphonesimulator:
2268
2269             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2270             …
2271             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2272
2273         Address this by teaching generate-xcfilelists about more platforms.
2274
2275         * Scripts/generate-xcfilelists:
2276
2277 2019-03-19  John Wilander  <wilander@apple.com>
2278
2279         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2280         https://bugs.webkit.org/show_bug.cgi?id=195923
2281         <rdar://problem/49001272>
2282
2283         Reviewed by Alex Christensen.
2284
2285         This patch does the following to the TestRunner:
2286         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2287         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2288         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2289
2290         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2291         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2292         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2293         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2294         * WebKitTestRunner/TestController.cpp:
2295         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2296         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2297         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2298         * WebKitTestRunner/TestController.h:
2299         * WebKitTestRunner/TestInvocation.cpp:
2300         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2301
2302 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2303
2304         [CMake] Support more clang and gcc sanitizers
2305         https://bugs.webkit.org/show_bug.cgi?id=195956
2306
2307         Reviewed by Michael Catanzaro.
2308
2309         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2310
2311 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2312
2313         [ews-build] Improve summary for PrintConfiguration step
2314         https://bugs.webkit.org/show_bug.cgi?id=195945
2315
2316         Reviewed by Lucas Forschler.
2317
2318         * BuildSlaveSupport/ews-build/steps.py:
2319         (PrintConfiguration.getResultSummary): Override getResultSummary.
2320
2321 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2322
2323         [ews-build] Improve summary for CheckOutSource step
2324         https://bugs.webkit.org/show_bug.cgi?id=195963
2325
2326         Reviewed by Lucas Forschler.
2327
2328         * BuildSlaveSupport/ews-build/steps.py:
2329         (CheckOutSource.getResultSummary):
2330
2331 2019-03-19  Daniel Bates  <dabates@apple.com>
2332
2333         [iOS] Focus not preserved when switching between tabs
2334         https://bugs.webkit.org/show_bug.cgi?id=195820
2335         <rdar://problem/43614450>
2336
2337         Reviewed by Brent Fulgham.
2338
2339         Add tests to ensure that we restore focus when resigning and becoming first responder.
2340
2341         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2342         (TestWebKitAPI::TEST):
2343
2344 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2345
2346         Make WTFLogChannelState and WTFLogLevel enum classes
2347         https://bugs.webkit.org/show_bug.cgi?id=195904
2348
2349         Reviewed by Eric Carlson.
2350
2351         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2352         (TestWebKitAPI::TEST_F):
2353
2354 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2355
2356         [GStreamer][EME] Backported mssdemux protection data crash fix
2357         https://bugs.webkit.org/show_bug.cgi?id=195918
2358
2359         Reviewed by Philippe Normand.
2360
2361         * gstreamer/jhbuild.modules:
2362         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2363
2364 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2365
2366         Unreviewed, rolling out r243132.
2367
2368         Broke GTK build
2369
2370         Reverted changeset:
2371
2372         "Make WTFLogChannelState and WTFLogLevel enum classes"
2373         https://bugs.webkit.org/show_bug.cgi?id=195904
2374         https://trac.webkit.org/changeset/243132
2375
2376 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2377
2378         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2379
2380         * Scripts/webkitdirs.pm:
2381         (builtDylibPathForName): Adjust the shared library name that's changed
2382         with the API version bump in r243073.
2383
2384 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2385
2386         Make WTFLogChannelState and WTFLogLevel enum classes
2387         https://bugs.webkit.org/show_bug.cgi?id=195904
2388
2389         Reviewed by Eric Carlson.
2390
2391         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2392         (TestWebKitAPI::TEST_F):
2393
2394 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2395
2396         Disable flaky test added in r2431100
2397         https://webkit.org/b/195785
2398
2399         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2400         (TestWebKitAPI::TEST):
2401         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2402
2403 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2404
2405         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2406         https://bugs.webkit.org/show_bug.cgi?id=195916
2407
2408         Reviewed by Tim Horton.
2409
2410         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2411         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2412
2413 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2414
2415         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2416
2417         * Scripts/webkitpy/common/config/contributors.json:
2418
2419 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2420
2421         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2422         https://bugs.webkit.org/show_bug.cgi?id=195785
2423
2424         Reviewed by Geoffrey Garen.
2425
2426         * TestWebKitAPI/TCPServer.cpp: Added.
2427         (TestWebKitAPI::TCPServer::TCPServer):
2428         (TestWebKitAPI::TCPServer::~TCPServer):
2429         (TestWebKitAPI::TCPServer::socketBindListen):
2430         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2431         * TestWebKitAPI/TCPServer.h: Added.
2432         (TestWebKitAPI::TCPServer::port const):
2433         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2434         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2435         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2436         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2437         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2438         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2439         (TestWebKitAPI::respondSlowly):
2440         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2441         (TestWebKitAPI::downloadAtRate):
2442         (TestWebKitAPI::TEST):
2443
2444 2019-03-18  Saam Barati  <sbarati@apple.com>
2445
2446         Add a plan file for JetStream 2
2447         https://bugs.webkit.org/show_bug.cgi?id=190734
2448
2449         Reviewed by Mark Lam.
2450
2451         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2452
2453 2019-03-18  Chris Dumez  <cdumez@apple.com>
2454
2455         Delay WebProcess launch until a load is triggered in a Web view
2456         https://bugs.webkit.org/show_bug.cgi?id=195758
2457         <rdar://problem/48126013>
2458
2459         Reviewed by Geoff Garen.
2460
2461         Add API test coverage. Also update some existing API tests to not expect
2462         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2463
2464         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2465         (TestWebKitAPI::TEST):
2466         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2467         (TestWebKitAPI::TEST):
2468         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2469         (TEST):
2470         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2471         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2472         (TEST):
2473         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2474         (TEST):
2475         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2476
2477 2019-03-18  Xan Lopez  <xan@igalia.com>
2478
2479         [CMake] Prevent potential warning when determining $architecture
2480         https://bugs.webkit.org/show_bug.cgi?id=195891
2481
2482         Reviewed by Michael Catanzaro.
2483
2484         It's possible for generateBuildSystemForCMakeProject to be called
2485         before determineArchitecture() is ever called. This will make the
2486         first eq check with $architecture to be bogus (and print a
2487         warning). Change that to an eq check with architecture(), which
2488         implicitly calls determineArchitecture() if needed, and change all
2489         the other similar cases in the method in the same way to prevent
2490         future bugs like this one.
2491
2492         * Scripts/webkitdirs.pm:
2493         (generateBuildSystemFromCMakeProject):
2494
2495 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2496
2497         [WPE] Tarballs generated with “make dist” cannot build documentation
2498         https://bugs.webkit.org/show_bug.cgi?id=195885
2499
2500         Reviewed by Carlos Garcia Campos.
2501
2502         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2503
2504 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2505
2506         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2507         https://bugs.webkit.org/show_bug.cgi?id=195883
2508
2509         Reviewed by Carlos Garcia Campos.
2510
2511         * gtkdoc/gtkdoc.py:
2512         (GTKDoc._run_command): When commands fail to run, include the full command line for
2513         the program invocation and the output it has generated on the standard error stream.
2514
2515 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2516
2517         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2518         https://bugs.webkit.org/show_bug.cgi?id=195786
2519
2520         Reviewed by Philippe Normand.
2521
2522         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2523         * wpe/jhbuild.modules: Ditto.
2524
2525 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2526
2527         [ews-build] Don't run clean builds on EWS builders
2528         https://bugs.webkit.org/show_bug.cgi?id=195851
2529
2530         Reviewed by Geoffrey Garen.
2531
2532         * BuildSlaveSupport/ews-build/factories.py:
2533
2534 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2535
2536         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2537         https://bugs.webkit.org/show_bug.cgi?id=195849
2538
2539         Reviewed by Chris Dumez.
2540
2541         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2542
2543         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2544         (runWebsiteDataStoreCustomPaths):
2545
2546 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2547
2548         webkitpy: Upload test results
2549         https://bugs.webkit.org/show_bug.cgi?id=195755
2550         <rdar://problem/48896182>
2551
2552         Reviewed by Aakash Jain.
2553
2554         Establish a new format for uploading results that is not tied to layout tests, apply
2555         that format to webkitpy tests.
2556
2557         * Scripts/webkitpy/common/checkout/scm/git.py:
2558         (Git.native_branch): Return what branch the current checkout is on.
2559         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2560         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2561         * Scripts/webkitpy/common/checkout/scm/svn.py:
2562         (SVN.native_branch): Ditto.
2563         * Scripts/webkitpy/common/system/platforminfo.py:
2564         (PlatformInfo.build_version): Return a build version for Mac.
2565         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2566         (MockPlatformInfo.__init__):
2567         (MockPlatformInfo.build_version):
2568         * Scripts/webkitpy/results: Added.
2569         * Scripts/webkitpy/results/__init__.py: Added.
2570         * Scripts/webkitpy/results/options.py: Added.
2571         (upload_options): OptParse list for upload options.
2572         * Scripts/webkitpy/results/upload.py: Added.
2573         (Upload): Class which enforces the upload format expected by the results server.
2574         (Upload.Expectations):
2575         (Upload.create_configuration):
2576         (Upload.create_commit):
2577         (Upload.create_details):
2578         (Upload.create_run_stats):
2579         (Upload.create_test_result):
2580         (Upload.__init__):
2581         (Upload.Encoder): Encode Upload object as json.
2582         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2583         * Scripts/webkitpy/results/upload_unittest.py: Added.
2584         * Scripts/webkitpy/test/main.py:
2585         (Tester._parse_args): Add upload arguments.
2586         (Tester._run_tests): Allow results to be uploaded.
2587         * Scripts/webkitpy/test/runner.py:
2588         (Runner.__init__): Record which tests were run, rather than just counting them.
2589         (Runner.handle):
2590         * Scripts/webkitpy/test/runner_unittest.py:
2591         (RunnerTest.test_run):
2592         * Scripts/webkitpy/thirdparty/__init__.py:
2593         (AutoinstallImportHook.find_module): Add requests auto-install.
2594         (AutoinstallImportHook._install_requests):
2595         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2596         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2597
2598 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2599
2600         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2601         https://bugs.webkit.org/show_bug.cgi?id=195810
2602
2603         Reviewed by Tim Horton.
2604
2605         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2606         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2607         ending certain layout tests.
2608
2609         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2610         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2611         (-[TestRunnerWKWebView dealloc]):
2612         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2613
2614         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2615         helper method when destroying the web view, and when resetting state between tests.
2616
2617         * WebKitTestRunner/ios/TestControllerIOS.mm:
2618         (WTR::TestController::platformResetStateToConsistentValues):
2619
2620         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2621
2622 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2623
2624         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2625         https://bugs.webkit.org/show_bug.cgi?id=190350
2626         <rdar://problem/45089503>
2627
2628         Reviewed by Geoffrey Garen.
2629
2630         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2631         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2632         (TEST):
2633         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2634         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2635         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2636         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2637         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2638         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2639         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2640         (runTest):
2641         (createDirectories):
2642         (TEST):
2643         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2644         (TEST):
2645         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2646         (TEST):
2647
2648 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2649
2650         Add support to WebPage for getting the contents as an attributed string.
2651         https://bugs.webkit.org/show_bug.cgi?id=195636
2652         rdar://problem/45055697
2653
2654         Reviewed by Tim Horton.
2655
2656         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2657         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2658
2659 2019-03-15  Chris Dumez  <cdumez@apple.com>
2660
2661         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2662         https://bugs.webkit.org/show_bug.cgi?id=195747
2663
2664         Reviewed by Geoff Garen.
2665
2666         Add API test coverage.
2667
2668         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2669
2670 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2671
2672         Unreviewed, rolling out r242952.
2673
2674         Causing API failures on iOS Simulator
2675
2676         Reverted changeset:
2677
2678         "[PSON] Make sure the WebProcessCache is leverage when
2679         relaunching a process after termination"
2680         https://bugs.webkit.org/show_bug.cgi?id=195747
2681         https://trac.webkit.org/changeset/242952
2682
2683 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2684
2685         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2686         https://bugs.webkit.org/show_bug.cgi?id=195740
2687
2688         Reviewed by Ross Kirsling.
2689
2690         window.open doesn't work for WebKitBrowserWindow because it is not
2691         implemented yet.
2692
2693         1. Implemented createNewPage callback of WKPageUIClient.
2694         2. Changed MainWindow to take a BrowserWindow factory function
2695           instead of BrowserWindowType to be flexible to create
2696           BrowserWindow with extra settings.
2697         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2698           because it is not relevant with MainWindow anymore.
2699
2700         * MiniBrowser/win/Common.cpp:
2701         (parseCommandLine):
2702         * MiniBrowser/win/Common.h:
2703         (CommandLineOptions::CommandLineOptions):
2704         * MiniBrowser/win/MainWindow.cpp:
2705         (MainWindow::MainWindow):
2706         (MainWindow::create):
2707         (MainWindow::init):
2708         (MainWindow::WndProc):
2709         * MiniBrowser/win/MainWindow.h:
2710         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2711         (PrintWebUIDelegate::createWebViewWithRequest):
2712         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2713         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2714         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2715         (WebKitBrowserWindow::updateProxySettings):
2716         (WebKitBrowserWindow::createNewPage):
2717         * MiniBrowser/win/WebKitBrowserWindow.h:
2718         * MiniBrowser/win/WinMain.cpp:
2719         (wWinMain):
2720
2721 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2722
2723         Make it possible to test scrolling tree layer manipulation more easily
2724         https://bugs.webkit.org/show_bug.cgi?id=195780
2725
2726         Reviewed by Tim Horton.
2727         
2728         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2729         cuts off communication of scrolling tree scrolls back to the web process
2730         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2731         allows tests to trigger scrolls which run the scrolling tree layer positioning
2732         logic, but never get another commit from the web process that might mask
2733         scrolling tree bugs.
2734         
2735         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2736         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2737         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2738
2739         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2740         (WTR::UIScriptController::scrollUpdatesDisabled const):
2741         (WTR::UIScriptController::setScrollUpdatesDisabled):
2742         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2743         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2744         (WTR::UIScriptController::scrollUpdatesDisabled const):
2745         (WTR::UIScriptController::setScrollUpdatesDisabled):
2746         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2747         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2748         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2749         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2750         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2751         * WebKitTestRunner/ios/TestControllerIOS.mm:
2752         (WTR::TestController::platformResetStateToConsistentValues):
2753         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2754         (WTR::UIScriptController::scrollUpdatesDisabled const):
2755         (WTR::UIScriptController::setScrollUpdatesDisabled):
2756
2757 2019-03-14  Youenn Fablet  <youenn@apple.com>
2758
2759         Move IDB storage in private browsing mode to NetworkProcess
2760         https://bugs.webkit.org/show_bug.cgi?id=195602
2761
2762         Reviewed by Brady Eidson.
2763
2764         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2765         (TEST):
2766
2767 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2768
2769         [ews-build] Make descriptionDone messages more readable
2770         https://bugs.webkit.org/show_bug.cgi?id=195760
2771
2772         Reviewed by Lucas Forschler.
2773
2774         * BuildSlaveSupport/ews-build/steps.py:
2775         * BuildSlaveSupport/ews-build/steps_unittest.py:
2776
2777 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2778
2779         [ews-build] Generate status-bubble hover-over messages
2780         https://bugs.webkit.org/show_bug.cgi?id=195680
2781
2782         Reviewed by Lucas Forschler.
2783
2784         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2785         (StatusBubble):
2786         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2787         on hover-over.
2788         (StatusBubble._iso_time):
2789         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2790         hover-over message.
2791         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2792
2793 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2794
2795         [ews-app] Gracefully handle the case when state_string is None
2796         https://bugs.webkit.org/show_bug.cgi?id=195753
2797
2798         Reviewed by Lucas Forschler.
2799
2800         * BuildSlaveSupport/ews-app/ews/models/build.py:
2801         * BuildSlaveSupport/ews-app/ews/models/step.py:
2802
2803 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2804
2805         [ews-app] Status bubble display pending for currently running build step
2806         https://bugs.webkit.org/show_bug.cgi?id=195744
2807
2808         Reviewed by Lucas Forschler.
2809
2810         * BuildSlaveSupport/ews-build/events.py:
2811         (Events.stepStarted): If state_string is pending, replace it with step name.
2812
2813 2019-03-14  Chris Dumez  <cdumez@apple.com>
2814
2815         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2816         https://bugs.webkit.org/show_bug.cgi?id=195750
2817
2818         Reviewed by Geoffrey Garen.
2819
2820         Add API test coverage.
2821
2822         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2823         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2824         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2825         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2826
2827 2019-03-14  Chris Dumez  <cdumez@apple.com>
2828
2829         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2830         https://bugs.webkit.org/show_bug.cgi?id=195747
2831
2832         Reviewed by Geoff Garen.
2833
2834         Add API test coverage.
2835
2836         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2837
2838 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2839
2840         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2841         https://bugs.webkit.org/show_bug.cgi?id=195725
2842         <rdar://problem/48545062>
2843
2844         Reviewed by Tim Horton.
2845
2846         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2847         handler is nil.
2848
2849         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2850         (TestWebKitAPI::TEST):
2851
2852 2019-03-13  Sam Weinig  <sam@webkit.org>
2853
2854         Add utility function to allow easy reverse range-based iteration of a container
2855         https://bugs.webkit.org/show_bug.cgi?id=195542
2856
2857         Reviewed by Antti Koivisto.
2858
2859         * TestWebKitAPI/CMakeLists.txt:
2860         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2861         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2862         (TestWebKitAPI::TEST):
2863         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2864
2865 2019-03-13  Chris Dumez  <cdumez@apple.com>
2866
2867         Use a ServiceWorker process per registrable domain
2868         https://bugs.webkit.org/show_bug.cgi?id=195649
2869
2870         Reviewed by Youenn Fablet.
2871
2872         Update API test coverage.
2873
2874         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2875
2876 2019-03-13  Chris Dumez  <cdumez@apple.com>
2877
2878         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2879         https://bugs.webkit.org/show_bug.cgi?id=195684
2880         <rdar://problem/48294714>
2881
2882         Reviewed by Antti Koivisto.
2883
2884         Add API test coverage.
2885
2886         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2887
2888 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2889
2890         [ews-app] Remove unused patch view
2891         https://bugs.webkit.org/show_bug.cgi?id=195669
2892
2893         Reviewed by Lucas Forschler.
2894
2895         * BuildSlaveSupport/ews-app/ews/urls.py:
2896         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2897
2898 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2899
2900         [ews-app] Use Buildbot result code variables
2901         https://bugs.webkit.org/show_bug.cgi?id=195668
2902
2903         Reviewed by Alexey Proskuryakov.
2904
2905         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2906         (Buildbot): Added Buildbot result code variables.
2907         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2908         (StatusBubble._build_bubble): Used Buildbot result code variables.
2909
2910 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2911
2912         [Flatpak] Expand submodule recursively
2913         https://bugs.webkit.org/show_bug.cgi?id=195672
2914
2915         Building WPE with flatpak was impossible without that as it was raising an exception.
2916         Also update wpebackend-fdo to match what is built in jhbuild
2917
2918         Reviewed by Philippe Normand.
2919
2920         * flatpak/flatpakutils.py:
2921         (expand_submodules_recurse):
2922         (expand_manifest):
2923         * flatpak/org.webkit.WPEModules.yaml:
2924
2925 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2926
2927         [ews-app] status bubble should be hidden for certain builds
2928         https://bugs.webkit.org/show_bug.cgi?id=194597
2929
2930         Reviewed by Dewei Zhu.
2931
2932         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2933         (StatusBubble._build_bubble):
2934         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2935         because the patch didn't have relevant changes.
2936         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2937         in production yet.
2938
2939 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2940
2941         [Win] Fix a slew of simple clang-cl warnings.
2942         https://bugs.webkit.org/show_bug.cgi?id=195652
2943
2944         Reviewed by Don Olmstead.
2945
2946         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2947         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2948
2949 2019-03-12  Justin Fan  <justin_fan@apple.com>
2950
2951         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2952         https://bugs.webkit.org/show_bug.cgi?id=195518
2953         <rdar://problem/46322356>
2954
2955         Reviewed by Myles C. Maxfield.
2956
2957         * DumpRenderTree/DerivedSources-input.xcfilelist:
2958         * DumpRenderTree/DerivedSources-output.xcfilelist:
2959
2960 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2961
2962         Unreviewed, rolling out r242825.
2963         https://bugs.webkit.org/show_bug.cgi?id=195648
2964
2965         "Broke webkitpy tests with my change to
2966         lldb_dump_class_layout.py" (Requested by rmorisset on
2967         #webkit).
2968
2969         Reverted changeset:
2970
2971         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2972         classes with suspicious padding"
2973         https://bugs.webkit.org/show_bug.cgi?id=195573
2974         https://trac.webkit.org/changeset/242825
2975
2976 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2977
2978         [ews-build] Show status bubbles while the patch is waiting in queue
2979         https://bugs.webkit.org/show_bug.cgi?id=195618
2980
2981         Reviewed by Lucas Forschler.
2982
2983         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2984         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2985         enabled in initial deployment.
2986         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2987         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2988         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2989         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2990         (StatusBubble._build_bubbles_for_patch):
2991
2992 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2993
2994         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2995         https://bugs.webkit.org/show_bug.cgi?id=195573
2996
2997         Reviewed by Simon Fraser.
2998
2999         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3000
3001         * Scripts/dump-class-layout:
3002         (main):
3003         * lldb/lldb_dump_class_layout.py:
3004         (ClassLayout.__init__):
3005         (ClassLayout._compute_padding_recursive):
3006         (LLDBDebuggerInstance.dump_layout_for_classname):
3007         (LLDBDebuggerInstance):
3008         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3009         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3010
3011 2019-03-12  Chris Dumez  <cdumez@apple.com>
3012
3013         Device Orientation access permission should be denied unless explicitly granted by the client
3014         https://bugs.webkit.org/show_bug.cgi?id=195625
3015
3016         Reviewed by Youenn Fablet.
3017
3018         add API test coverage.
3019
3020         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3021         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3022         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3023         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3024         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3025         (runDeviceOrientationTest):
3026         (TEST):
3027         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3028         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3029
3030 2019-03-12  Jer Noble  <jer.noble@apple.com>
3031
3032         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3033         https://bugs.webkit.org/show_bug.cgi?id=195137
3034         <rdar://problem/48810307>
3035
3036         Reviewed by Eric Carlson.
3037
3038         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3039         (TestWebKitAPI::TEST):
3040
3041 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3042
3043         [ews-build] Change urls from uat to production
3044         https://bugs.webkit.org/show_bug.cgi?id=195566
3045
3046         Reviewed by Lucas Forschler.
3047
3048         * BuildSlaveSupport/ews-app/ews/config.py:
3049         * BuildSlaveSupport/ews-build/events.py:
3050         * BuildSlaveSupport/ews-build/steps.py:
3051
3052 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3053
3054         [ews-build] change max_builds for local-worker to 1
3055         https://bugs.webkit.org/show_bug.cgi?id=195568
3056
3057         Reviewed by Lucas Forschler.
3058
3059         * BuildSlaveSupport/ews-build/loadConfig.py:
3060
3061 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3062
3063         Fix the build
3064
3065         * TestRunnerShared/spi/PencilKitTestSPI.h:
3066         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3067
3068 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3069
3070         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3071         https://bugs.webkit.org/show_bug.cgi?id=194131
3072
3073         Reviewed by Michael Catanzaro.
3074
3075         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3076         (uriChanged):
3077         (testUnfinishedSubresourceLoad):
3078         (serverCallback):
3079         (beforeAll):
3080
3081 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3082
3083         WTF::Expected should use std::addressof instead of operator&
3084         https://bugs.webkit.org/show_bug.cgi?id=195604
3085
3086         Reviewed by Myles Maxfield.
3087
3088         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3089         (TestWebKitAPI::Unique::Unique):
3090         (TestWebKitAPI::Unique::operator&):
3091         (TestWebKitAPI::TEST):
3092
3093 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3094
3095         Add Optional to Forward.h.
3096         https://bugs.webkit.org/show_bug.cgi?id=195586
3097
3098         Reviewed by Darin Adler.
3099
3100         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3101         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3102         Remove unnecessary includes from headers.
3103
3104 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3105
3106         Add testing API to hit-test and scroll overflow scrollers
3107         https://bugs.webkit.org/show_bug.cgi?id=195278
3108
3109         Reviewed by Antti Koivisto.
3110         
3111         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3112         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3113         
3114         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3115
3116         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3117         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3118         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3119         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3120         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3121         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3122         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3123         (WTR::enclosingScrollViewIncludingSelf):
3124         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3125
3126 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3127
3128         API test WebKit.RequestTextInputContext fails on iOS
3129         https://bugs.webkit.org/show_bug.cgi?id=195585
3130
3131         Reviewed by Wenson Hsieh and Simon Fraser.
3132
3133         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3134         (applyStyle):
3135         (TEST):
3136         Add a viewport, so that the coordinates match up on iOS.
3137         Scroll by moving the UIScrollView's contentOffset.
3138
3139 2019-03-11  Chris Dumez  <cdumez@apple.com>
3140
3141         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3142         https://bugs.webkit.org/show_bug.cgi?id=195506
3143         <rdar://problem/48733477>
3144
3145         Reviewed by Alex Christensen.
3146
3147         Add API test coverage.
3148
3149         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3150
3151 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3152
3153         Adding myself to contributors.json
3154
3155         Unreviewed, addming myself to contributors.json .
3156
3157         * Scripts/webkitpy/common/config/contributors.json:
3158
3159 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3160
3161         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3162         https://bugs.webkit.org/show_bug.cgi?id=195511
3163         <rdar://problem/44873269>
3164
3165         Reviewed by Darin Adler.
3166
3167         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3168         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3169         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3170         (TEST_F):
3171
3172 2019-03-11  Chris Dumez  <cdumez@apple.com>
3173
3174         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3175         https://bugs.webkit.org/show_bug.cgi?id=195561
3176
3177         Reviewed by Youenn Fablet.
3178
3179         Make sure the JS in the test requests for permission to receive device orientation events.
3180
3181         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3182
3183 2019-03-11  Youenn Fablet  <youenn@apple.com>
3184
3185         Allow storage quota increase by default in WTR
3186         https://bugs.webkit.org/show_bug.cgi?id=195541
3187
3188         Reviewed by Geoffrey Garen.
3189
3190         Allow storage quota increase by default in WTR.
3191         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3192         Use this for tests that explicitly need cache increase.
3193
3194         Instead of increasing quota by 2, make sure the next request is
3195         granted by adding all given parameters.
3196
3197         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3198         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3199         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3200         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3201         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3202         * WebKitTestRunner/TestController.cpp:
3203         (WTR::TestController::setAllowStorageQuotaIncrease):
3204         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3205         * WebKitTestRunner/TestController.h:
3206         * WebKitTestRunner/TestInvocation.cpp:
3207         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3208         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3209         (WTR::TestController::cocoaResetStateToConsistentValues):
3210         (WTR::TestController::setAllowStorageQuotaIncrease):
3211         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3212         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3213         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3214
3215 2019-03-11  Xan Lopez  <xan@igalia.com>
3216
3217         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3218         https://bugs.webkit.org/show_bug.cgi?id=194147
3219
3220         Reviewed by Michael Saboff.
3221
3222         To make --32-bit work correctly on Linux/64bit we need to:
3223
3224         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3225         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3226         unfortunately CMake only allows us to do this during
3227         crosscompilation, which is overkill here.
3228         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3229         pkg-config detection module uses the x86 .pc files instead of the
3230         x86_64 ones.
3231         - Set the -m32 flags for the compiler.
3232
3233         * Scripts/webkitdirs.pm:
3234         (generateBuildSystemFromCMakeProject):
3235
3236 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3237
3238         Add MotionMark-1.1 plan file for run-benchmark script.
3239         https://bugs.webkit.org/show_bug.cgi?id=195481
3240
3241         Rubber-stamped by Darin Adler.
3242
3243         Run-benchmark script should support MontionMark-1.1.
3244
3245         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3246
3247 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3248
3249         [ews-app] Add support for submit-to-ews url
3250         https://bugs.webkit.org/show_bug.cgi?id=195477
3251
3252         Reviewed by Lucas Forschler.
3253
3254         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3255         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3256         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3257         * BuildSlaveSupport/ews-app/ews/urls.py:
3258         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3259
3260 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3261
3262         Unreviewed, rolling out r242688, r242643, r242624.
3263
3264         Caused multiple layout test failures and crashes on iOS and macOS.
3265
3266         Reverted changeset:
3267
3268         "requestAnimationFrame should execute before the next frame"
3269         https://bugs.webkit.org/show_bug.cgi?id=177484
3270         https://trac.webkit.org/changeset/242624/webkit
3271
3272         * Tracing/SystemTracePoints.plist:
3273
3274 2019-03-11  John Wilander  <wilander@apple.com>
3275
3276         Resource Load Statistics: Make it possible exclude localhost from classification
3277         https://bugs.webkit.org/show_bug.cgi?id=195474
3278         <rdar://problem/47520577>
3279
3280         Reviewed by Brent Fulgham.
3281
3282         This patch allows for localhost to be excluded from classification and
3283         treatment as a prevalent resource.
3284
3285         The WebKit Tools change adds a new function called
3286         testRunner.setStatisticsIsRunningTest() which can be used to control this
3287         behavior.
3288
3289         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3290         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3291         (WTR::TestRunner::setStatisticsIsRunningTest):
3292         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3293         * WebKitTestRunner/TestController.cpp:
3294         (WTR::TestController::setStatisticsIsRunningTest):
3295         * WebKitTestRunner/TestController.h:
3296         * WebKitTestRunner/TestInvocation.cpp:
3297         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3298
3299 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3300
3301         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3302         https://bugs.webkit.org/show_bug.cgi?id=195560
3303
3304         Reviewed by Lucas Forschler.
3305
3306         * BuildSlaveSupport/ews-build/master.cfg:
3307
3308 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3309
3310         Unreviewed, rolling out r242698.
3311
3312         API test crashes on bots.
3313
3314         Reverted changeset:
3315
3316         "Add a WKContentRuleList variant that uses copied memory
3317         instead of mmap'd shared memory for class A containerized
3318         apps"
3319         https://bugs.webkit.org/show_bug.cgi?id=195511
3320         https://trac.webkit.org/changeset/242698
3321
3322 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3323
3324         [WPE] Enable web process sandbox
3325         https://bugs.webkit.org/show_bug.cgi?id=195169
3326
3327         Reviewed by Daniel Bates.
3328
3329         * wpe/install-dependencies:
3330         * wpe/jhbuild.modules:
3331
3332 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3333
3334         [ews-app] Use port 17000 for worker communication
3335         https://bugs.webkit.org/show_bug.cgi?id=195558
3336
3337         Reviewed by Lucas Forschler.
3338
3339         * BuildSlaveSupport/ews-build/master.cfg:
3340
3341 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3342
3343         [ews-build] unit-tests fail when passwords.json is missing
3344         https://bugs.webkit.org/show_bug.cgi?id=195557
3345
3346         Reviewed by Lucas Forschler.
3347
3348         * BuildSlaveSupport/ews-build/loadConfig.py:
3349         (loadBuilderConfig):
3350         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3351         (ConfigDotJSONTest.test_configuration):
3352         * BuildSlaveSupport/ews-build/master.cfg:
3353
3354 2019-03-11  Truitt Savell  <tsavell@apple.com>
3355
3356         Unreviewed, rolling out r242702.
3357
3358         Broke High Sierra builders.
3359
3360         Reverted changeset:
3361
3362         "Add utility function to allow easy reverse range-based
3363         iteration of a container"
3364         https://bugs.webkit.org/show_bug.cgi?id=195542
3365         https://trac.webkit.org/changeset/242702
3366
3367 2019-03-11  Sam Weinig  <sam@webkit.org>
3368
3369         Add utility function to allow easy reverse range-based iteration of a container
3370         https://bugs.webkit.org/show_bug.cgi?id=195542
3371
3372         Reviewed by Antti Koivisto.
3373
3374         * TestWebKitAPI/CMakeLists.txt:
3375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3376         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3377         (TestWebKitAPI::TEST):
3378         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3379
3380 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3381
3382         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3383         https://bugs.webkit.org/show_bug.cgi?id=195511
3384         <rdar://problem/44873269>
3385
3386         Reviewed by Darin Adler.
3387
3388         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3389         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3390         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3391         (TEST_F):
3392
3393 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3394
3395         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3396         https://bugs.webkit.org/show_bug.cgi?id=195499
3397
3398         Reviewed by Darin Adler.
3399
3400         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3401         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3402         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3403         (-[WKWebView synchronouslyFocusTextInputContext:]):
3404         (applyStyle):
3405         (applyIframe):
3406         (TEST):
3407         Add some tests for this SPI.
3408
3409 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3410
3411         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3412         https://bugs.webkit.org/show_bug.cgi?id=181151
3413
3414         Reviewed by Don Olmstead.
3415
3416         * TestWebKitAPI/CMakeLists.txt:
3417         * TestWebKitAPI/PlatformWin.cmake:
3418         Enable TestWTF RunLoop tests in all platforms.
3419
3420         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3421         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3422         (TestWebKitAPI::DerivedOneShotTimer::fired):
3423         (TestWebKitAPI::TEST):
3424         Only a few platforms support nested RunLoop.
3425
3426         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3427         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3428
3429 2019-03-10  David Quesada  <david_quesada@apple.com>
3430
3431         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3432         https://bugs.webkit.org/show_bug.cgi?id=152480
3433
3434         Reviewed by Chris Dumez.
3435
3436         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3437         there are no additional references to the process pool besides the one held by
3438         the download, waits for the download to finish (in the sense that the
3439         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3440         measure, also check that the process pool has been deallocated at the end of the
3441         test. The test wouldn't be meaningful if the process pool were still alive.
3442
3443         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3444         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3445         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3446             The download will be canceled because the delegate does not implement the
3447             method to decide the download's destination, so this is where we know the
3448             DownloadProxyMap is done with the DownloadProxy.
3449         (TEST):
3450
3451 2019-03-08  Chris Dumez  <cdumez@apple.com>
3452
3453         Add support for Device Orientation / Motion permission API
3454         https://bugs.webkit.org/show_bug.cgi?id=195329
3455         <rdar://problem/47645367>
3456
3457         Reviewed by Geoffrey Garen.
3458
3459         Add test infrastructure to help test the Device Orientation / Motion permission API.
3460
3461         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3462         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3463         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3464         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3465         * WebKitTestRunner/TestController.cpp:
3466         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3467         (WTR::TestController::createWebViewWithOptions):
3468         (WTR::TestController::resetStateToConsistentValues):
3469         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3470         * WebKitTestRunner/TestController.h:
3471         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3472         * WebKitTestRunner/TestInvocation.cpp:
3473         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3474
3475 2019-03-08  Saam barati  <sbarati@apple.com>
3476
3477         Add a compare-results script to compare benchmark results
3478         https://bugs.webkit.org/show_bug.cgi?id=195486
3479         <rdar://problem/48723397>
3480
3481         Reviewed by Geoffrey Garen.
3482
3483         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3484         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3485         to extend it to learn about our other benchmarks.
3486
3487         * Scripts/compare-results: Added.
3488         (readJSONFile):
3489         (detectJetStream2):
3490         (JetStream2Results):
3491         (detectSpeedometer2):
3492         (Speedometer2Results):
3493         (detectPLT5):
3494         (PLT5Results):
3495         (detectBenchmark):
3496         (biggerIsBetter):
3497         (ttest):
3498         (getOptions):
3499         (main):
3500
3501 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3502
3503         Ensure old tab state is cleared between iterations of run-benchmark
3504         https://bugs.webkit.org/show_bug.cgi?id=195393
3505         <rdar://problem/46885583>
3506
3507         Reviewed by Dewei Zhu.
3508
3509         a) ensure the default to restore state is not set
3510         b) terminate Safari correctly
3511         c) Set the system default to ignore Persistent State in Safari
3512
3513         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3514         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3515         (OSXBrowserDriver.prepare_env): 
3516         (OSXBrowserDriver.restore_env):
3517         (OSXBrowserDriver.close_browsers):
3518         (OSXBrowserDriver._terminate_processes):
3519         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3520         (OSXChromeDriver):
3521         (OSXChromeCanaryDriver):
3522         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3523         (OSXFirefoxDriver):
3524         (OSXFirefoxNightlyDriver):
3525         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3526         (OSXSafariDriver):
3527         (OSXSafariDriver.prepare_env):
3528
3529 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3530
3531         [GTK] Several InputMethodFilter tests are failing
3532         https://bugs.webkit.org/show_bug.cgi?id=195408
3533
3534         Reviewed by Carlos Garcia Campos.
3535
3536         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3537         Regressed in r241751.
3538         Hexadecimal values of keycodes are expressed now in upper letters.
3539         Composited characters should be cast to UTF8 strings.
3540
3541         (TestWebKitAPI::TEST):
3542
3543 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3544
3545         [GTK] Make Tools/gtkdoc python3 compatible
3546         https://bugs.webkit.org/show_bug.cgi?id=195359
3547
3548         Reviewed by Carlos Garcia Campos.
3549
3550         * gtkdoc/generate-gtkdoc:
3551         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3552         work with Python 2 and 3.
3553         (get_gtkdoc_module_paths):
3554         The iteritems() was removed in Python 3, so let's use items() that's
3555         available in Python 2 and 3.
3556         (get_generator_for_config):
3557         * gtkdoc/gtkdoc.py:
3558         (GTKDoc._run_command):
3559         The sys.stdout.write() is expecting str in Python 3 and not bytes
3560         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3561         for passing the bytes there.
3562
3563 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3564
3565         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3566         https://bugs.webkit.org/show_bug.cgi?id=195346
3567         <rdar://problem/48667048>
3568
3569         Unreviewed build fix for clang-cl.
3570
3571         * DumpRenderTree/win/DumpRenderTree.cpp:
3572         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3573
3574 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3575
3576         requestAnimationFrame should execute before the next frame
3577         https://bugs.webkit.org/show_bug.cgi?id=177484
3578
3579         Reviewed by Simon Fraser.
3580
3581         Add trace points for the page RenderingUpdate.
3582
3583         * Tracing/SystemTracePoints.plist:
3584
3585 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3586
3587         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3588         https://bugs.webkit.org/show_bug.cgi?id=195353
3589         <rdar://problem/48626394>
3590
3591         Reviewed by Simon Fraser.
3592
3593         * WebKitTestRunner/ios/TestControllerIOS.mm:
3594         (WTR::TestController::platformResetPreferencesToConsistentValues):
3595
3596 2019-03-07  John Wilander  <wilander@apple.com>
3597
3598         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3599         https://bugs.webkit.org/show_bug.cgi?id=195383
3600         <rdar://problem/48570136>
3601
3602         Reviewed by Brent Fulgham.
3603
3604         This patch adds test infrastructure to purge only script-accessible cookies,
3605         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3606
3607         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3608         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3609         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3610         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3611         * WebKitTestRunner/TestController.cpp:
3612         (WTR::TestController::statisticsDeleteCookiesForHost):
3613         * WebKitTestRunner/TestController.h:
3614         * WebKitTestRunner/TestInvocation.cpp:
3615         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3616
3617 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3618
3619         Unreviewed, rolling out r242354.
3620         https://bugs.webkit.org/show_bug.cgi?id=195402
3621
3622         breaks layout tests in all configurations (Requested by
3623         zdobersek on #webkit).
3624
3625         Reverted changeset:
3626
3627         "[WPE] Enable web process sandbox"
3628         https://bugs.webkit.org/show_bug.cgi?id=195169
3629         https://trac.webkit.org/changeset/242354
3630
3631 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3632
3633         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3634         https://bugs.webkit.org/show_bug.cgi?id=195346
3635
3636         Reviewed by Fujii Hironori.
3637
3638         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3639         (TestWebKitAPI::TEST):
3640         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3641
3642         * DumpRenderTree/win/DumpRenderTree.cpp:
3643         (findFontFallback):
3644         (addFontFallbackIfPresent):
3645         (removeFontFallbackIfPresent):
3646         (main):
3647         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3648         (TestWebKitAPI::Util::moduleDirectory):
3649         (TestWebKitAPI::Util::createInjectedBundlePath):
3650         Use wchar helpers as needed.
3651
3652 2019-03-06  Rob Buis  <rbuis@igalia.com>
3653
3654         Consider supporting the `referrerpolicy` attribute.
3655         https://bugs.webkit.org/show_bug.cgi?id=179053
3656
3657         Reviewed by Darin Adler.
3658
3659         Add a runtime flag for referrerpolicy attribute.
3660
3661         * DumpRenderTree/mac/DumpRenderTree.mm:
3662         (enableExperimentalFeatures):
3663
3664 2019-03-05  Daniel Bates  <dabates@apple.com>
3665
3666         Update expected API test result following r242379
3667         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3668
3669         Update expected x-coordinate of selection rect now that the left padding of
3670         a textarea is sized in ems (so dependent on the font size) just like the left
3671         padding of a text field.
3672
3673         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3674         (TestWebKitAPI::TEST):
3675
3676 2019-03-05  David Quesada  <david_quesada@apple.com>
3677
3678         [WK2] It should be possible to follow links with 'download' attributes
3679         https://bugs.webkit.org/show_bug.cgi?id=195145
3680         rdar://problem/48462642
3681
3682         Reviewed by Alex Christensen.
3683
3684         Add a unit test to verify that activating links with 'download' attributes now
3685         navigates to the linked resource, rather than starts downloading it. Add another
3686         to verify that it is still possible to explicitly download the link via the
3687         'Download' navigation action policy.
3688
3689         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3690         (-[DownloadAttributeTestDelegate init]):
3691         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3692         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3693         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3694         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3695         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3696         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3697         (TEST):
3698         * WebKitTestRunner/TestController.cpp:
3699         (WTR::TestController::decidePolicyForNavigationAction):
3700         * WebKitTestRunner/TestController.h:
3701
3702 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3703
3704         [Curl] Implement Cookie Accept Policy.
3705         https://bugs.webkit.org/show_bug.cgi?id=191645
3706
3707         Reviewed by Fujii Hironori.
3708
3709         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3710         (TestWebKitAPI::Curl::TEST_F):
3711
3712 2019-03-05  Youenn Fablet  <youenn@apple.com>
3713
3714         Rename requestCacheStorageSpace to requestStorageSpace
3715         https://bugs.webkit.org/show_bug.cgi?id=195282
3716
3717         Reviewed by Chris Dumez.
3718
3719         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3720         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3721         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3722
3723 2019-03-05  Brady Eidson  <beidson@apple.com>
3724
3725         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3726         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3727
3728         Reviewed by Tim Horton.
3729
3730         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3731         different directory into that same WKWebView should work.
3732
3733         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3734         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3735
3736 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3737
3738         Add WeakHashSet
3739         https://bugs.webkit.org/show_bug.cgi?id=195152
3740
3741         Reviewed by Antti Koivisto.
3742
3743         Added tests for WeakHashSet.
3744
3745         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3746         (TestWebKitAPI::Base::Base): Moved.
3747         (TestWebKitAPI::Derived::foo): Moved.
3748         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3749         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3750         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3751         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3752
3753 2019-03-04  Chris Dumez  <cdumez@apple.com>
3754
3755         Do not share WebProcesses between private and regular sessions
3756         https://bugs.webkit.org/show_bug.cgi?id=195189
3757         <rdar://problem/48421064>
3758
3759         Reviewed by Alex Christensen.
3760
3761         Add API test coverage.
3762
3763         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3764         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3765
3766 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3767
3768         [WPE] Enable web process sandbox
3769         https://bugs.webkit.org/show_bug.cgi?id=195169
3770
3771         Reviewed by Daniel Bates.
3772
3773         * wpe/install-dependencies:
3774         * wpe/jhbuild.modules:
3775
3776 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3777
3778         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3779         https://bugs.webkit.org/show_bug.cgi?id=195206
3780
3781         Reviewed by Žan Doberšek.
3782
3783         Add a new test case.
3784
3785         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3786         (testJSCClass):
3787
3788 2019-03-04  Charlie Turner  <cturner@igalia.com>
3789
3790         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3791         https://bugs.webkit.org/show_bug.cgi?id=194898
3792
3793         Reviewed by Žan Doberšek.
3794
3795         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3796         a GCC extension that permits arithmetic on void* pointer. Inline
3797         the macro until this issue is fixed upstream.
3798
3799 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3800
3801         Rid the world of WK_API_ENABLED
3802         https://bugs.webkit.org/show_bug.cgi?id=195263
3803
3804         Reviewed by Dan Bernstein.
3805
3806         List of changed files elided because it's useless.
3807
3808 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3809
3810         Unreviewed follow-up to r242292.
3811
3812         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3813
3814         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3815         (TestWebKitAPI::testStrip): Renamed from strip.
3816         (TestWebKitAPI::TEST):
3817
3818 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3819
3820         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3821
3822         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3823         and bug #194272 for details.
3824
3825         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3826
3827 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3828
3829         Remove some more unused 32-bit code
3830         https://bugs.webkit.org/show_bug.cgi?id=195255
3831
3832         Reviewed by Darin Adler.
3833
3834         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3835         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3836         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3837         (NPP_New):
3838         (NPP_HandleEvent):
3839         (handleEventCarbon): Deleted.
3840
3841 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3842
3843         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3844
3845         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3846         (TestWebKitAPI::TEST):
3847
3848 2019-03-01  Darin Adler  <darin@apple.com>
3849
3850         Finish removing String::format
3851         https://bugs.webkit.org/show_bug.cgi?id=194893
3852
3853         Reviewed by Daniel Bates.
3854 '
3855         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3856
3857 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3858
3859         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3860         https://bugs.webkit.org/show_bug.cgi?id=195229
3861         <rdar://problem/48520362>
3862
3863         Reviewed by Chris Dumez.
3864
3865         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3866         (TEST):
3867
3868 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3869
3870         Add a system trace scope for event region building
3871         https://bugs.webkit.org/show_bug.cgi?id=195226
3872
3873         Reviewed by Jon Lee.
3874
3875         This trace scope measures the time spend converting element rects into Region objects,
3876         which can be large on some pages.
3877
3878         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3879
3880         * Tracing/SystemTracePoints.plist:
3881
3882 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3883
3884         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3885         https://bugs.webkit.org/show_bug.cgi?id=194612
3886
3887         Reviewed by Alex Christensen.
3888
3889         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3890         Just test the new string-processing function and don't touch the actual environment.
3891         (Test cases are all as before, but based on operator== instead of strcmp.)
3892
3893 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3894
3895         [ews-app] Update primary keys for handling multiple Buildbot instances
3896         https://bugs.webkit.org/show_bug.cgi?id=195120
3897
3898         Reviewed by Stephanie Lewis.
3899
3900         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3901         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3902         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3903
3904         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3905         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3906         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3907         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3908         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3909         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3910
3911 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3912
3913         [WinCairo] Enable service worker
3914         https://bugs.webkit.org/show_bug.cgi?id=188318
3915
3916         Reviewed by Youenn Fablet.
3917
3918         * DumpRenderTree/DumpRenderTreePrefix.h:
3919         * TestWebKitAPI/PlatformWin.cmake:
3920         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3921         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3922         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3923
3924 2019-03-01  Justin Fan  <justin_fan@apple.com>
3925
3926         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3927         https://bugs.webkit.org/show_bug.cgi?id=195191
3928
3929         Rubber-stamped by Dean Jackson.
3930
3931         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3932
3933         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3934
3935 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3936
3937         Unreviewed, fix lldb webkitpy tests
3938         https://bugs.webkit.org/show_bug.cgi?id=194375
3939
3940         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3941
3942         * lldb/lldb_webkit.py:
3943         (WTFStringImplProvider.is_8bit):
3944
3945 2019-02-28  David Quesada  <david_quesada@apple.com>
3946
3947         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3948         https://bugs.webkit.org/show_bug.cgi?id=195121
3949         rdar://problem/48450302
3950
3951         Reviewed by Alex Christensen.
3952
3953         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3954         configurations where the 'download' attribute is absent, blank, or populated
3955         with a filename, and where the anchor element is same-origin or cross-origin
3956         (meaning the 'download' attribute shouldn't be honored).
3957
3958         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3959         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3960         (-[NavigationActionTestDelegate init]):
3961         (-[NavigationActionTestDelegate navigationAction]):
3962         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3963         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3964         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3965         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3966         (TEST):
3967
3968 2019-02-28  Antoine Quint  <graouts@apple.com>
3969
3970         Enable the Pointer Events runtime flag by default
3971         https://bugs.webkit.org/show_bug.cgi?id=195156
3972
3973         Reviewed by Dean Jackson.
3974
3975         * DumpRenderTree/mac/DumpRenderTree.mm:
3976         (enableExperimentalFeatures):
3977
3978 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3979
3980         Several PasteImage API tests are flaky
3981         https://bugs.webkit.org/show_bug.cgi?id=195160
3982
3983         Reviewed by Tim Horton.
3984
3985         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3986         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3987         listening for a "load" event after image load is already complete.
3988
3989         To address this, make these tests first register a "load" event handler, then run script to insert an image
3990         element into the document, and finally wait until the load event is observed before checking image size.
3991
3992         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3993
3994 2019-02-28  Chris Dumez  <cdumez@apple.com>
3995
3996         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3997         https://bugs.webkit.org/show_bug.cgi?id=195107
3998
3999         Reviewed by Alex Christensen.
4000
4001         Give some time for the zoom level to get restored.
4002
4003         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4004
4005 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4006
4007         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4008         https://bugs.webkit.org/show_bug.cgi?id=194958
4009
4010         Reviewed by Geoffrey Garen.
4011
4012         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4013         (TEST):
4014
4015 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4016
4017         [ews-app] Update method to save build to handle builder_display_name
4018         https://bugs.webkit.org/show_bug.cgi?id=195047
4019
4020         Reviewed by Dewei Zhu.
4021
4022         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4023         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4024
4025 2019-02-28  Justin Fan  <justin_fan@apple.com>
4026
4027         [Web GPU] Enable Web GPU only on 64-bit
4028         https://bugs.webkit.org/show_bug.cgi?id=195139
4029
4030         Because Metal is only supported on 64 bit apps.
4031
4032         Unreviewed build fix.
4033
4034         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4035
4036 2019-02-27  Youenn Fablet  <youenn@apple.com>
4037
4038         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4039         https://bugs.webkit.org/show_bug.cgi?id=194959
4040
4041         Reviewed by Chris Dumez.
4042
4043         Spin loop until getting the condition to remove flakiness.
4044
4045         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4046
4047 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4048
4049         [ews-build] Buildbot should include builder_display_name in the build events
4050         https://bugs.webkit.org/show_bug.cgi?id=195045
4051
4052         Reviewed by Dewei Zhu.
4053
4054         * BuildSlaveSupport/ews-build/events.py:
4055         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4056         buildername to builder_name to be consistent in naming style.
4057         (Events.buildFinished): Ditto.
4058
4059 2019-02-27  Chris Dumez  <cdumez@apple.com>
4060
4061         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4062         https://bugs.webkit.org/show_bug.cgi?id=194480
4063
4064         Reviewed by Brady Eidson.
4065
4066         Update existing API test to make it more likely to reproduce the issue.
4067
4068         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4069
4070 2019-02-27  Brady Eidson  <beidson@apple.com>
4071
4072         Universal links from Google search results pages don't open the app.
4073         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4074
4075         Reviewed by Geoffrey Garen.
4076
4077         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4078         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4079         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4080         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4081
4082 2019-02-27  Chris Dumez  <cdumez@apple.com>
4083
4084         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4085         https://bugs.webkit.org/show_bug.cgi?id=195102
4086
4087         Reviewed by Geoffrey Garen.
4088
4089         If the number of processes is not yet what we expect, wait a bit and check again to give
4090         processes some time to exit.
4091
4092         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4093
4094 2019-02-27  Chris Dumez  <cdumez@apple.com>
4095
4096         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4097         https://bugs.webkit.org/show_bug.cgi?id=194545
4098
4099         Reviewed by Brady Eidson.
4100
4101         Make sure the test navigates forward and then back only once. Previously, navigating
4102         back would trigger a navigation again in a timer.
4103
4104         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4105
4106 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4107
4108         High Sierra Debug JSC test queue should use faster hardware
4109         https://bugs.webkit.org/show_bug.cgi?id=194603
4110
4111         Rubber-stamped by Alexey Proskuryakov.
4112
4113         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4114
4115         * BuildSlaveSupport/build.webkit.org-config/config.json:
4116         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4117         (BubbleQueueServer):
4118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4119         (WebKitBuildbot):
4120         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4121         * QueueStatusServer/config/queues.py:
4122         * Scripts/webkitpy/common/config/ews.json:
4123         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4124         (test_ews_name):
4125
4126 2019-02-27  John Wilander  <wilander@apple.com>
4127
4128         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4129         https://bugs.webkit.org/show_bug.cgi?id=195071
4130         <rdar://problem/48417690>
4131
4132         Reviewed by Alex Christensen and Brent Fulgham.
4133
4134         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4135         (TestWebKitAPI::createURL):
4136             Convenience function.
4137         (TestWebKitAPI::TEST):
4138             WebCore::AdClickAttribution now takes a URL when creating Source and
4139             Destination.
4140         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4141         (TestWebKitAPI::TEST):
4142             WebCore::AdClickAttribution now takes a URL when creating Source and
4143             Destination.
4144
4145 2019-02-27  Antoine Quint  <graouts@apple.com>
4146
4147         Support Pointer Events on macOS
4148         https://bugs.webkit.org/show_bug.cgi?id=195008
4149         <rdar://problem/47454419>
4150
4151         Reviewed by Dean Jackson.
4152
4153         * DumpRenderTree/mac/DumpRenderTree.mm:
4154         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4155         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4156
4157 2019-02-26  Mark Lam  <mark.lam@apple.com>
4158
4159         Remove remaining poisoning code.
4160         https://bugs.webkit.org/show_bug.cgi?id=194138
4161
4162         Reviewed by Saam Barati.
4163
4164         * TestWebKitAPI/CMakeLists.txt:
4165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4166         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4167         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4168         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4169         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4170         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4171         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4172
4173 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4174
4175         Move ephemeral local storage from WebProcess to UIProcess
4176         https://bugs.webkit.org/show_bug.cgi?id=195074
4177         <rdar://problem/47937975>
4178
4179         Reviewed by Geoff Garen.
4180
4181         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4182
4183 2019-02-20  Jer Noble  <jer.noble@apple.com>
4184
4185         [Cocoa] Media elements will restart network buffering just before suspending
4186         https://bugs.webkit.org/show_bug.cgi?id=193691
4187
4188         Reviewed by Eric Carlson.
4189
4190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4191         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4192         (TEST):
4193
4194 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4195
4196         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4197         https://bugs.webkit.org/show_bug.cgi?id=191652
4198
4199         Reviewed by Alex Christensen.
4200
4201         Fix WinCairo MiniBrowser behavior of authentication dialog.
4202
4203         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4204         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4205
4206 2019-02-26  Youenn Fablet  <youenn@apple.com>
4207
4208         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4209         https://bugs.webkit.org/show_bug.cgi?id=195028
4210         <rdar://problem/48243733>
4211
4212         Reviewed by Eric Carlson.
4213
4214         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4215
4216 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4217
4218         [WPE] Add API for webview background color configuration
4219         https://bugs.webkit.org/show_bug.cgi?id=192305
4220
4221         Reviewed by Michael Catanzaro.
4222
4223         * MiniBrowser/wpe/main.cpp:
4224         (main): Add a new option to configure the webview background
4225         color. Example: --bg-color=transparent.
4226         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4227         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4228         (beforeAll): Ditto.
4229
4230 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4231
4232         scalableNativeWebpageParameters() is not preserved on new page navigation.
4233         https://bugs.webkit.org/show_bug.cgi?id=194892
4234         <rdar://problem/47538280>
4235
4236         Reviewed by Wenson Hsieh.
4237         
4238         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4239
4240         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4241         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4242         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4243         (WTR::UIScriptController::allowsViewportShrinkToFit):
4244         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4245         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4246         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4247         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4248         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4249         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4250
4251 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4252
4253         [ews-app] Add model for handling multiple Buildbot instances
4254         https://bugs.webkit.org/show_bug.cgi?id=194863
4255
4256         Reviewed by Stephanie Lewis.
4257
4258         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4259
4260 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4261
4262         [ews-app] Remove BuilderMapping table
4263         https://bugs.webkit.org/show_bug.cgi?id=194961
4264
4265         Reviewed by Stephanie Lewis.
4266
4267         Store builder name directly in build table, instead of having a separate
4268         table for it.
4269
4270         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4271         * BuildSlaveSupport/ews-app/ews/models/build.py:
4272         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4273         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4274
4275 2019-02-25  John Wilander  <wilander@apple.com>
4276
4277         Introduce and adopt new class RegistrableDomain for eTLD+1
4278         https://bugs.webkit.org/show_bug.cgi?id=194791
4279         <rdar://problem/48179240>
4280
4281         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4282
4283         This patch adds an API test and replaces two instances of
4284         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4285
4286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4287         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4288         (TestWebKitAPI::TEST):
4289             Changed two strings to make sure the registrable domains are still considered
4290             invalid and pass the test.
4291         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4292         (TestWebKitAPI::TEST):
4293         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4294         (WTR::InjectedBundle::didReceiveMessageToPage):
4295
4296 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4297
4298         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4299         https://bugs.webkit.org/show_bug.cgi?id=195001
4300
4301         Reviewed by Carlos Garcia Campos.
4302
4303         API version 1.0 always includes the functionality previously guarded with
4304         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4305         unconditionally.
4306
4307         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4308         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4309         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4310         (WebViewTest::showInWindow): Ditto.
4311         (WebViewTest::hideView): Ditto.
4312         * wpe/backends/HeadlessViewBackend.cpp:
4313         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4314         * wpe/backends/ViewBackend.cpp:
4315         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4316         * wpe/backends/WindowViewBackend.cpp:
4317         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4318         WPE_BACKEND_CHECK_VERSION().
4319         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4320
4321 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4322
4323         [Flatpak] Add support for flatpak > 1.1.2
4324         https://bugs.webkit.org/show_bug.cgi?id=194088
4325
4326         Flatpak 1.2 is now out so we need to support that
4327         version now.
4328
4329         Reviewed by Michael Catanzaro.
4330
4331         * flatpak/flatpakutils.py:
4332         (check_flatpak):
4333         (FlatpakPackages.__init__):
4334         (FlatpakPackages.__detect_packages):
4335         (FlatpakPackages.__detect_packages.in):
4336         (FlatpakRepos.update):
4337
4338 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4339
4340         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4341         https://bugs.webkit.org/show_bug.cgi?id=194998
4342
4343         Reviewed by Carlos Garcia Campos.
4344
4345         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4346         to a Git checkout and using the latest commit containing various fixes
4347         and improvements.
4348
4349 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4350
4351         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4352         https://bugs.webkit.org/show_bug.cgi?id=194981
4353
4354         Reviewed by Žan Doberšek.
4355
4356         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4357         (TestWebKitAPI::TEST):
4358
4359 2019-02-23  Keith Miller  <keith_miller@apple.com>
4360
4361         Add new mac target numbers
4362         https://bugs.webkit.org/show_bug.cgi?id=194955
4363
4364         Reviewed by Tim Horton.
4365
4366         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4367         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4368         * MiniBrowser/Configurations/Base.xcconfig:
4369         * TestWebKitAPI/Configurations/Base.xcconfig:
4370