Fix setup-commit-queue and temporarily disable testing on commit-queue
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Fix setup-commit-queue and temporarily disable testing on commit-queue
4         https://bugs.webkit.org/show_bug.cgi?id=113979
5
6         Reviewed by Benjamin Poulain.
7
8         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
9         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
10
11         * EWSTools/setup-commit-queue.sh:
12         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
13         (CommitQueueTask.run):
14
15 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
16
17         temporarily make flakiness dashboard work again webkit.org bots
18         https://bugs.webkit.org/show_bug.cgi?id=113972
19
20         Reviewed by Ojan Vafai.
21
22         This patch disables the chromium.org layout test bots TestExpectations
23         parsing temporarily until we can work out the right way to split into
24         two instances for webkit.org and chromium.org and figure out which
25         code to delete where :).
26
27         * TestResultServer/static-dashboards/flakiness_dashboard.js:
28
29 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
30
31         Fix webkitpy tests after r147678.
32
33         * Scripts/webkitpy/tool/commands/queues_unittest.py:
34         (CommitQueueTest.test_commit_queue):
35         (test_manual_reject_during_processing):
36
37 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
38
39         The commit queue should use Mac MountainLion port
40         https://bugs.webkit.org/show_bug.cgi?id=113971
41
42         Reviewed by Lucas Forschler.
43
44         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
45         * Scripts/webkitpy/tool/commands/queues.py:
46         (CommitQueue):
47
48 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
49
50         turn off running tests on chromium linux EWS bots
51         https://bugs.webkit.org/show_bug.cgi?id=113959
52
53         Reviewed by Geoffrey Garen.
54
55         Now that the Chromium port is no longer being maintained
56         there's little point in running the tests. Soon we should
57         just shut this bot off altogether.
58
59         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
60         (ChromiumLinuxEWS):
61
62 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
63
64         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
65
66         * Scripts/webkitpy/common/config/watchlist:
67
68 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
69
70         Indentation fix to get webkit-patch working again after r147625
71
72         Unreviewed.
73
74         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
75         (MacEWS):
76         (MacWK2EWS):
77
78 2013-04-04  Lucas Forschler  <lforschler@apple.com>
79
80         Turn tests back on for Mac WK1/WK2 EWS.
81         
82         Unreviewed.
83         
84         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
85         (MacEWS):
86         (MacWK2EWS):
87
88 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
89
90         [GTK][WK2] MiniBrowser custom URI scheme support
91         https://bugs.webkit.org/show_bug.cgi?id=112419
92
93         Reviewed by Carlos Garcia Campos.
94
95         Add support for about URIs in MiniBrowser. An example about page is show
96         with URI "about:minibrowser", the rest of the cases it will show a
97         proper message explaining that the about page didn't exist.
98
99         Internally it uses "minibrowser-about" prefix instead of "about", but
100         from the user point of view it works with "about" prefix.
101
102         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
103         (getInternalURI): Method to convert URIs from "about" prefix to
104         "minibrowser-about".
105         (getExternalURI): Opposite method.
106         (webViewURIChanged): Use "about" prefix to show the URI to users.
107         (webViewEnterFullScreen): Ditto.
108         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
109         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
110         (aboutURISchemeRequestCallback): Callback to manage about calls.
111         (main): Register the URI scheme to manage about URIs.
112
113 2013-04-03  Roger Fong  <roger_fong@apple.com>
114
115         Re-enable WinEWS tests.
116
117         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
118         (WinEWS):
119
120 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
121
122         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
123         https://bugs.webkit.org/show_bug.cgi?id=113883
124
125         Reviewed by Martin Robinson.
126
127         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
128         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
129         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
130
131 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
132
133         [GTK] Include Pango in jhbuild-optional.modules
134         https://bugs.webkit.org/show_bug.cgi?id=113878
135
136         Reviewed by Martin Robinson.
137
138         Since r147547 Pango 1.32.0 is required. Including the module in the
139         JHBuild optional moduleset.
140
141         * gtk/jhbuild-optional.modules: Add Pango module.
142
143 2013-04-03  Zeno Albisser  <zeno@webkit.org>
144
145         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
146         https://bugs.webkit.org/show_bug.cgi?id=113864
147
148         Moving setDefersLoading from TestRunnerQt to TestRunner
149         requires access to the non-Qt TestRunner.
150         As long as we instantiate both TestRunner and TestRunnerQt,
151         we need a separate getter for the non-Qt TestRunner instance.
152
153         Reviewed by Simon Hausmann.
154
155         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
156         (WebPage::resetSettings):
157         * DumpRenderTree/qt/DumpRenderTreeQt.h:
158         (DumpRenderTree::jscTestRunner):
159         * DumpRenderTree/qt/TestRunnerQt.cpp:
160         (TestRunner::setDefersLoading):
161             Moving setDefersLoading from TestRunnerQt
162             to TestRunner.
163         * DumpRenderTree/qt/TestRunnerQt.h:
164         (TestRunnerQt):
165
166 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
167
168         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
169         https://bugs.webkit.org/show_bug.cgi?id=104779
170
171         Reviewed by Carlos Garcia Campos.
172
173         * Scripts/run-gtk-tests:
174         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
175         passing in current trunk.
176
177 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
178
179         Fix HAVE(QTTESTSUPPORT) logic
180
181         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
182         resulting in HAVE(QTTESTSUPPORT) never being true.
183         Move that logic down in sanitizeFeatures.
184
185         Rubber-stamped by Tor Arne Vestbø.
186
187         * qmake/mkspecs/features/features.prf:
188
189 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
190
191         [GTK] Bump required versions of some dependencies
192         https://bugs.webkit.org/show_bug.cgi?id=113282
193
194         Reviewed by Martin Robinson.
195
196         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
197
198 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
199
200         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
201         https://bugs.webkit.org/show_bug.cgi?id=113809
202
203         Reviewed by Philippe Normand.
204
205         Newer Linux kernels have removed some deprecated macros from v4l2
206         headers, causing gst-plugins-good's build to break. We don't need it
207         right now, so just disable it.
208
209         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
210
211 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
212
213         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
214         https://bugs.webkit.org/show_bug.cgi?id=113535
215
216         Reviewed by Simon Hausmann.
217
218         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
219
220         * qmake/mkspecs/features/features.prf:
221
222 2013-04-03  Zeno Albisser  <zeno@webkit.org>
223
224         [Qt] Move logic of simple forwarding functions to TestRunner.
225         https://bugs.webkit.org/show_bug.cgi?id=113863
226
227         Reviewed by Simon Hausmann.
228
229         * DumpRenderTree/qt/TestRunnerQt.cpp:
230         (TestRunner::setTextDirection):
231         (TestRunner::goBack):
232         (TestRunner::evaluateScriptInIsolatedWorld):
233         (TestRunner::addUserStyleSheet):
234         * DumpRenderTree/qt/TestRunnerQt.h:
235         (TestRunnerQt):
236
237 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
238
239         [Qt] Disable media support using QuickTime if deployment target != SDK
240
241         We link to a single libWebKitSystemInterface static lib, so unless the
242         deployment target matches the SDK let's not pretend like we'll be able
243         to run on anything lower than the SDK version.
244
245         Reviewed by Simon Hausmann.
246
247         * qmake/mkspecs/features/features.prf:
248
249 2013-04-02  James Craig  <james@cookiecrook.com>
250
251         AXRoleDescripton for DL is "list"; should be "description list"
252         https://bugs.webkit.org/show_bug.cgi?id=111665
253
254         Reviewed by Chris Fleizach.
255
256         Defining the role and description strings.
257
258         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
259
260 2013-04-02  Roger Fong  <roger_fong@apple.com>
261
262         Unreviewed. Disable running tests on Win EWS queue.
263
264         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
265         (WinEWS):
266
267 2013-04-02  Lucas Forschler  <lforschler@apple.com>
268
269         Disable running tests on the MAC WK2 EWS queue.
270         
271         Unreviewed.
272         
273         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
274         (MacWK2EWS):
275
276 2013-04-02  Julie Parent  <jparent@chromium.org>
277
278         Dashboard refactor: Move dashboard specific history related features to History.
279         https://bugs.webkit.org/show_bug.cgi?id=113717
280
281         Reviewed by Ojan Vafai.
282         
283         Each dashboard now creates its own History object, with a custom
284         configuration. This changes from just overriding global functions
285         to passing in callbacks for generatePage, handleValidHashParameter,
286         and handleQueryParameterChange. Same with passing in defaultStateValues
287         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
288         variables.
289         
290         All functions related to these features are now (mostly) private
291         function on History. 
292         
293         Loader no longer needs a loadingComplete callback, since it can just
294         initialize the history object itself.
295
296         * TestResultServer/static-dashboards/aggregate_results.js:
297         (handleValidHashParameter):
298         * TestResultServer/static-dashboards/dashboard_base.js:
299         * TestResultServer/static-dashboards/flakiness_dashboard.js:
300         (generatePage):
301         (.switch.return):
302         (handleQueryParameterChange):
303         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
304         (resetGlobals):
305         * TestResultServer/static-dashboards/history.js:
306         (.):
307         * TestResultServer/static-dashboards/loader.js:
308         (.):
309         * TestResultServer/static-dashboards/loader_unittests.js:
310         * TestResultServer/static-dashboards/timeline_explorer.js:
311         (generatePage):
312         (initCurrentBuilderTestResults):
313         * TestResultServer/static-dashboards/treemap.js:
314         (generatePage):
315         (.switch.return):
316         (handleQueryParameterChange):
317
318 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
319
320         Unreviewed, rolling out r147401.
321         http://trac.webkit.org/changeset/147401
322         https://bugs.webkit.org/show_bug.cgi?id=113767
323
324         The patch makes it extremely hard to set up the dependencies
325         properly on the GTK builders (Requested by zdobersek on
326         #webkit).
327
328         * gtk/jhbuild.modules:
329
330 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
331
332         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
333         https://bugs.webkit.org/show_bug.cgi?id=113382
334
335         Reviewed by Gyuyoung Kim.
336
337         Do not show the empty tooltip box if the text is null.
338
339         * MiniBrowser/efl/main.c:
340         (popup_menu_populate):
341
342 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
343
344         [GTK] Bump required versions of some dependencies
345         https://bugs.webkit.org/show_bug.cgi?id=113282
346
347         Reviewed by Martin Robinson.
348
349         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
350
351 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
352
353         Unreviewed, rolling out r147319.
354         http://trac.webkit.org/changeset/147319
355         https://bugs.webkit.org/show_bug.cgi?id=113707
356
357         The unit test is still failing on the buildbot (Requested by
358         zdobersek on #webkit).
359
360         * Scripts/run-gtk-tests:
361         (TestRunner):
362
363 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
364
365         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
366         https://bugs.webkit.org/show_bug.cgi?id=104779
367
368         Reviewed by Carlos Garcia Campos.
369
370         * Scripts/run-gtk-tests:
371         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
372         passing in current trunk.
373
374 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
375
376         Unreviewed, rolling out r147289.
377         http://trac.webkit.org/changeset/147289
378         https://bugs.webkit.org/show_bug.cgi?id=113678
379
380         broke Win7 (dbg) build (Requested by shinyak|gardener on
381         #webkit).
382
383         * DumpRenderTree/DumpRenderTree.gypi:
384         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
385         (WebTestRunner):
386         (WebUserMediaClientMock):
387         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
388         (WebTestRunner::WebUserMediaClientMock::taskList):
389         * Scripts/webkitpy/style/checkers/cpp.py:
390         (check_function_definition):
391
392 2013-03-31  Adam Barth  <abarth@webkit.org>
393
394         configure-svn-config.sh fails
395         https://codereview.chromium.org/13392007/
396
397         Reviewed by Eric Seidel.
398
399         This script was trying to use "svn checkout" to dowload a file from
400         svn.webkit.org, but "svn checkout" only works with directories.
401         Instead, we should use "svn export".
402
403         * EWSTools/configure-svn-config.sh:
404
405 2013-03-31  Wei Jia  <wjia@chromium.org>
406
407         Allow WebUserMediaClientMock to be used by client
408         https://bugs.webkit.org/show_bug.cgi?id=113633
409
410         Reviewed by Adam Barth.
411
412         Export WebUserMediaClientMock.
413         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
414
415         * DumpRenderTree/DumpRenderTree.gypi:
416         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
417         (WebUserMediaClientMock):
418         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
419         * Scripts/webkitpy/style/checkers/cpp.py:
420         (check_function_definition):
421
422 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
423
424         Expose FeatureObserver data to WebKit clients
425         https://bugs.webkit.org/show_bug.cgi?id=113613
426
427         Reviewed by Sam Weinig.
428
429         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
430         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
431
432 2013-03-29  Greg Hughes  <ghughes@apple.com>
433
434         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
435         https://bugs.webkit.org/show_bug.cgi?id=112276
436
437         Reviewed by Chris Fleizach.
438
439         Added support to test accessibility search predicates with multiple keys.  
440
441         * DumpRenderTree/AccessibilityUIElement.cpp:
442         (uiElementForSearchPredicateCallback):
443         * DumpRenderTree/AccessibilityUIElement.h:
444         (AccessibilityUIElement):
445         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
446         (AccessibilityUIElement::uiElementForSearchPredicate):
447         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
448         (AccessibilityUIElement::uiElementForSearchPredicate):
449         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
450         (AccessibilityUIElement::uiElementForSearchPredicate):
451         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
452         (AccessibilityUIElement::uiElementForSearchPredicate):
453         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
454         (AccessibilityUIElement::uiElementForSearchPredicate):
455         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
456         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
457         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
458         (AccessibilityUIElement):
459         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
460         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
461         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
462         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
463         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
464
465 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
466
467         Fix a typo in r147147 to fix Mac EWS.
468
469         * Scripts/webkitpy/tool/commands/queues.py:
470         (PatchProcessingQueue._new_port_name_from_old):
471
472 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
473
474         [EFL] Build break with latest EFL libraries after r146265
475         https://bugs.webkit.org/show_bug.cgi?id=113558
476
477         Unreviewed build fix.
478
479         * TestWebKitAPI/PlatformWebView.h:
480         * WebKitTestRunner/PlatformWebView.h:
481
482 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
483
484         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
485
486         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
487         in libgcrypt build.
488
489 2013-03-28  Lucas Forschler  <lforschler@apple.com>
490
491         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
492
493         Unreviewed.
494
495         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
496         (MacEWS):
497
498 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
499
500         Use the right OS name on Mac EWS instead of mac-future.
501
502         Rubber-stamped by Dirk Pranke.
503
504         * Scripts/webkitpy/tool/commands/queues.py:
505         (PatchProcessingQueue._new_port_name_from_old):
506         (PatchProcessingQueue.begin_work_queue):
507         (PatchProcessingQueue._upload_results_archive_for_patch):
508
509 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
510
511         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
512         https://bugs.webkit.org/show_bug.cgi?id=112546
513
514         Reviewed by Martin Robinson.
515
516         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
517         moved back to Source/WebCore/platform. Fix an indentation issue as well.
518
519 2013-03-28  Ming Xie  <mxie@blackberry.com>
520
521         [BlackBerry] Committer Email Updates
522         https://bugs.webkit.org/show_bug.cgi?id=113435
523
524         Reviewed by Rob Buis.
525
526         Add the @blackberry.com email address for all our BlackBerry
527         WebKit committers. This is the first step for our email address
528         migration.
529
530         * Scripts/webkitpy/common/config/committers.py:
531
532 2013-03-28  Philippe Normand  <pnormand@igalia.com>
533
534         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
535         https://bugs.webkit.org/show_bug.cgi?id=113508
536
537         Reviewed by Martin Robinson.
538
539         Prevent the GStreamer plugin scanner to load system-wide
540         plugins. Only the ones built in JHBuild should be loaded and used
541         at runtime.
542
543         * efl/jhbuildrc:
544         * gtk/jhbuildrc:
545
546 2013-03-27  Philippe Normand  <pnormand@igalia.com>
547
548         [GTK] run-launcher --gtk -2 fails on a WK2-only build
549         https://bugs.webkit.org/show_bug.cgi?id=113386
550
551         Reviewed by Carlos Garcia Campos.
552
553         * Scripts/webkitdirs.pm:
554         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
555         version to 3.0. Reflect this change so the builtDylibPathForName
556         function doesn't fail to report the library as found.
557
558 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
559
560         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
561         https://bugs.webkit.org/show_bug.cgi?id=113484
562
563         Unreviewed build fix.
564
565         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
566
567         * TestWebKitAPI/CMakeLists.txt:
568         * WebKitTestRunner/CMakeLists.txt:
569
570 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
571
572         Revision for the internal jhbuild is too old
573         https://bugs.webkit.org/show_bug.cgi?id=113324
574
575         Reviewed by Martin Robinson.
576
577         Update the minimum required version to a point where jhbuild won't
578         fail installing packages when trying to remove a symlink to a directory.
579
580         * jhbuild/jhbuild-wrapper: Updated revision.
581
582 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
583
584         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
585         https://bugs.webkit.org/show_bug.cgi?id=113203
586
587         Reviewed by Philippe Normand.
588
589         We build our libsoup without GNOME support. gst-plugins-good does separate
590         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
591         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
592         build failures as the headers of those diverge. We do not use souphttpsrc, so
593         disable it when building gst-plugins-good.
594
595         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
596
597 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
598
599         Build fix after r146852. Please another reference to the Lion leaks builder.
600
601         * BuildSlaveSupport/build.webkit.org-config/config.json:
602
603 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
604
605         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
606         https://bugs.webkit.org/show_bug.cgi?id=113421
607
608         Reviewed by Dirk Pranke.
609
610         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
611         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
612         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
613         in the GTK-specific TestExpectations files.
614
615         To avoid this only enable the warnings only when not using WKTR.
616
617         * Scripts/webkitpy/layout_tests/port/gtk.py:
618         (GtkPort.warn_if_bug_missing_in_test_expectations):
619
620 2013-03-27  Antti Koivisto  <antti@apple.com>
621
622         Fix Zalan's email.
623
624         * Scripts/webkitpy/common/config/committers.py:
625
626 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
627
628         master.cfg cleanup
629         https://bugs.webkit.org/show_bug.cgi?id=113195
630
631         Reviewed by Ryosuke Niwa.
632
633         * BuildSlaveSupport/build.webkit.org-config/config.json:
634         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
635
636 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
637
638         master.cfg fine-tuning for Qt Mountain Lion Release bot
639         https://bugs.webkit.org/show_bug.cgi?id=113191
640
641         Reviewed by Ryosuke Niwa.
642
643         * BuildSlaveSupport/build.webkit.org-config/config.json:
644           - Rename the slave due to its location change.
645           - Update the platform of the slave.
646         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
647         (RunQtAPITests): Enable running WK2 API tests on Qt.
648         (RunQtAPITests.start):
649         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
650         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
651
652 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
653
654         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
655         https://bugs.webkit.org/show_bug.cgi?id=113403
656
657         Reviewed by Kenneth Rohde Christiansen.
658
659         As of Evas 1.7.5, when Wayland is detected on the system, support for
660         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
661         The code, however, seems to depend on a few other flags which must be
662         explicitly enabled.
663
664         If those additional GL-related options are passed, we end up
665         having issues on the WebKit side, so disable Wayland support for
666         now.
667
668         * efl/jhbuild.modules:
669
670 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
671
672         Unreviewed, rolling out r146864.
673         http://trac.webkit.org/changeset/146864
674         https://bugs.webkit.org/show_bug.cgi?id=113391
675
676         causes crashes on Wk2 EFL release bot (Requested by drott on
677         #webkit).
678
679         * Scripts/webkitperl/FeatureList.pm:
680
681 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
682
683         [jhbuild] Correctly specify an alternate number of make jobs.
684         https://bugs.webkit.org/show_bug.cgi?id=113396
685
686         Reviewed by Philippe Normand.
687
688         So far, we were using the `MAKEFLAGS' environment variable to pass the
689         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
690         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
691
692         We now behave more closely to the rest of the WebKit tools by first
693         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
694         not set, just letting jhbuild itself figure out how many jobs to use.
695
696         * efl/jhbuildrc:
697         * gtk/jhbuildrc:
698
699 2013-03-27  Zeno Albisser  <zeno@webkit.org>
700
701         [Qt] Remove Qt specific WorkQueueItem definitions.
702         https://bugs.webkit.org/show_bug.cgi?id=112891
703
704         This patch is preparation work for removing
705         WorkQueue related code from TestRunnerQt and
706         replacing it with generic TestRunner code.
707
708         Reviewed by Benjamin Poulain.
709
710         * DumpRenderTree/qt/TestRunnerQt.cpp:
711         (TestRunnerQt::queueBackNavigation):
712         (TestRunnerQt::queueForwardNavigation):
713         (TestRunnerQt::queueLoadHTMLString):
714         (TestRunnerQt::queueReload):
715         (TestRunnerQt::queueLoadingScript):
716         (TestRunnerQt::queueNonLoadingScript):
717         (TestRunner::queueLoad):
718         * DumpRenderTree/qt/TestRunnerQt.h:
719         (TestRunnerQt):
720         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
721         (LoadItem::invoke):
722         (LoadHTMLStringItem::invoke):
723         (LoadAlternateHTMLStringItem::invoke):
724         (ReloadItem::invoke):
725         (ScriptItem::invoke):
726         (BackForwardItem::invoke):
727         * DumpRenderTree/qt/WorkQueueItemQt.h:
728         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
729         (LoadAlternateHTMLStringItem):
730
731 2013-03-26  Julie Parent  <jparent@chromium.org>
732
733         Flakiness dashboard: simplify logic around which tests to show.
734         https://bugs.webkit.org/show_bug.cgi?id=113250
735
736         Reviewed by Ojan Vafai.
737         
738         The different filters for showing results are only used for layout
739         tests, otherwise, we show everything.
740         
741         Change the defaults to false (what layout tests used), and only
742         look at the values when viewing layout tests.
743
744         * TestResultServer/static-dashboards/flakiness_dashboard.js:
745         (htmlForTestsWithExpectationsButNoFailures):
746         (shouldHideTest):
747
748 2013-03-26  Isaac Levy  <ilevy@google.com>
749
750         Update bots on test-results.appspot
751         https://bugs.webkit.org/show_bug.cgi?id=113333
752
753         Reviewed by Ojan Vafai.
754
755         * TestResultServer/static-dashboards/builders.jsonp:
756
757 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
758
759         Unreviewed GTK gardening.
760
761         * Scripts/run-gtk-tests:
762         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
763
764 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
765
766         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
767         https://bugs.webkit.org/show_bug.cgi?id=113287
768
769         Reviewed by Jocelyn Turcotte.
770
771         * Scripts/run-qtwebkit-tests:
772         (Options.__init__):
773
774 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
775
776         [EFL] Enable IndexedDB by default
777         https://bugs.webkit.org/show_bug.cgi?id=107248
778
779         Reviewed by Laszlo Gombos.
780
781         * Scripts/webkitperl/FeatureList.pm:
782         Enable IndexedDB by default on EFL.
783
784 2013-03-26  Alan Cutter  <alancutter@chromium.org>
785
786         Sheriffbot should explain rollout failures in a human readable form.
787         https://bugs.webkit.org/show_bug.cgi?id=107092
788
789         Reviewed by Ryosuke Niwa.
790
791         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
792
793         * Scripts/webkitpy/tool/bot/irc_command.py:
794         (Rollout._check_diff_failure):
795         (Rollout.execute):
796         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
797         (IRCCommandTest.test_rollout):
798
799 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
800
801         Unreviewed GTK gardening.
802
803         * Scripts/run-gtk-tests:
804         (TestRunner): Skipping a failing unit test after r146518.
805
806 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
807
808         Remove Lion leaks builder
809         https://bugs.webkit.org/show_bug.cgi?id=113252
810
811         Reviewed by Andreas Kling.
812
813         Removed.
814
815         * BuildSlaveSupport/build.webkit.org-config/config.json:
816
817 2013-03-25  Kent Tamura  <tkent@chromium.org>
818
819         Rename ENABLE_INPUT_TYPE_DATETIME
820         https://bugs.webkit.org/show_bug.cgi?id=113254
821
822         Reviewed by Kentaro Hara.
823
824         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
825         Actually I'd like to remove the code, but we shouldn't remove it yet
826         because we shipped products with it on some platforms.
827
828         * Scripts/webkitperl/FeatureList.pm:
829         * qmake/mkspecs/features/features.pri:
830
831 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
832
833         Remove one more line that was intended to be removed in r146657.
834
835         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
836         (summarize_results):
837
838 2013-03-25  Roger Fong  <roger_fong@apple.com>
839
840         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
841         Re-enable WinEWS tests.
842
843         * Scripts/webkitpy/common/config/ports.py:
844         (WinPort.run_bindings_tests_command):
845         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
846         (WinEWS):
847
848 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
849
850         Unreviewed, rolling out r146793.
851         http://trac.webkit.org/changeset/146793
852         https://bugs.webkit.org/show_bug.cgi?id=113248
853
854         Fix did not work (Requested by rfong on #webkit).
855
856         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
857         (WinEWS):
858
859 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
860
861         REGRESSION(r146657): Test failures reported incorrectly
862         https://bugs.webkit.org/show_bug.cgi?id=113223
863
864         Reviewed by Dirk Pranke.
865
866         The bug was caused by BuildBotPrinter not taking the new behavior into account.
867
868         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
869         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
870
871         * Scripts/webkitpy/layout_tests/controllers/manager.py:
872         (Manager.run):
873
874         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
875         (RunDetails.__init__):
876         (summarize_results): Remove the line I intended to remove in r146657.
877
878         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
879         (logging_run): Return details instead of the exit code.
880         (run_and_capture): Ditto.
881
882         (RunTest.test_full_results_html):
883         (RunTest.test_hung_thread):
884         (RunTest.test_no_tests_found):
885         (RunTest.test_no_tests_found_2):
886         (RunTest.test_repeat_each_iterations_num_tests):
887         (RunTest.test_run_singly_actually_runs_tests):
888         (RunTest.test_test_list):
889         (RunTest.test_missing_and_unexpected_results):
890         (RunTest.test_pixel_test_directories):
891         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
892         (RunTest.test_crash_with_stderr):
893         (RunTest.test_no_image_failure_with_image_diff):
894         (RunTest.test_crash_log):
895         (RunTest.test_exit_after_n_failures_upload):
896         (RunTest.test_results_directory_absolute):
897         (RunTest.test_results_directory_relative):
898         (RunTest.test_retrying_and_flaky_tests):
899         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
900         (RunTest.test_retrying_uses_retries_directory):
901         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
902         (RunTest.test_output_diffs):
903         (EndToEndTest.test_reftest_with_two_notrefs):
904         (RebaselineTest.test_reset_results):
905         (RebaselineTest.test_missing_results):
906         (RebaselineTest.test_new_baseline):
907
908         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
909         (BuildBotPrinter.print_results):
910         (BuildBotPrinter.print_unexpected_results):
911         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
912         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
913
914 2013-03-25  Julie Parent  <jparent@chromium.org>
915
916         Dashboard refactor: Move cross dashboard history related code into history.js.
917         https://bugs.webkit.org/show_bug.cgi?id=113104
918
919         Reviewed by Ojan Vafai.
920
921         All functions relating to cross dashboard behavior move from being
922         globals to methods on the history.History object. Names stay the same,
923         except many are made private, ones that should have been constants now
924         are, and the long standing TODO to change "currentState" to 
925         dashboardSpecificState is done.
926         
927         We now create a global history object in dashboard_base, as an 
928         intermediate measure.  Once the dashboard specific code is
929         added to history, each DB will need to create its own, and this
930         global will be eliminated.
931         
932         * TestResultServer/static-dashboards/aggregate_results.js:
933         (handleValidHashParameter):
934         (htmlForBuilder):
935         (rawValuesHTML):
936         * TestResultServer/static-dashboards/dashboard_base.js:
937         (parseDashboardSpecificParameters):
938         (defaultValue):
939         (currentBuilderGroupCategory):
940         (currentBuilderGroupName):
941         (handleLocationChange):
942         (expectationsMap):
943         * TestResultServer/static-dashboards/flakiness_dashboard.js:
944         (generatePage):
945         (.switch.return):
946         (platformAndBuildType):
947         (individualTests):
948         (substringList):
949         (processMissingAndExtraExpectations):
950         (pathToFailureLog):
951         (showPopupForBuild):
952         (htmlForTestsWithExpectationsButNoFailures):
953         (shouldHideTest):
954         (isCrossBuilderView):
955         (tableHeaders):
956         (htmlForSingleTestRow):
957         (htmlForTableColumnHeader):
958         (generatePageForExpectationsUpdate):
959         (handleUpdate):
960         (nextUpdate):
961         (setUpdateIndex):
962         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
963         (.appendExpectationsItem):
964         (loadExpectations):
965         (.dummyNode.onload):
966         (loadExpectationsLayoutTests):
967         (appendExpectations):
968         (htmlForNavBar):
969         (checkBoxToToggleState):
970         (linkHTMLToToggleState):
971         (generatePageForBuilder):
972         (isInvalidKeyForCrossBuilderView):
973         (handleQueryParameterChange):
974         (showLegend):
975         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
976         (resetGlobals):
977         (test):
978         * TestResultServer/static-dashboards/history.js:
979         (.):
980         * TestResultServer/static-dashboards/history_unittests.js:
981         * TestResultServer/static-dashboards/loader.js:
982         (.):
983         * TestResultServer/static-dashboards/loader_unittests.js:
984         * TestResultServer/static-dashboards/timeline_explorer.js:
985         (generatePage):
986         (initCurrentBuilderTestResults):
987         (selectBuild):
988         (showResultsDelta):
989         * TestResultServer/static-dashboards/treemap.js:
990         (generatePage):
991         (.switch.return):
992         (handleFocus):
993         * TestResultServer/static-dashboards/ui.js:
994
995 2013-03-25  Roger Fong  <roger_fong@apple.com>
996
997         Unreviewed. Enable WinEWS tests again.
998
999         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1000         (WinEWS):
1001
1002 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1003
1004         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1005         https://bugs.webkit.org/show_bug.cgi?id=112166
1006
1007         HarfBuzz 0.9.14 merged my patch for icu detection without
1008         pkg-config files, as needed by for example Ubuntu 12.04.
1009         This obsoletes our local workaround. Removed it for GTK and EFL.
1010
1011         Reviewed by Martin Robinson.
1012
1013         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1014         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1015         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1016         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1017
1018 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1019
1020         Unreviewed.  Move self from contributor to committer list.
1021
1022         * Scripts/webkitpy/common/config/committers.py:
1023
1024 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1025
1026         EWS should use a human readable port name when uploading layout test archives
1027         https://bugs.webkit.org/show_bug.cgi?id=113099
1028
1029         Reviewed by Dirk Pranke.
1030
1031         Use new port's object's name() method to report human readable port names.
1032         This will also help us resolving the bug to apply layout test results posted by EWS.
1033
1034         * Scripts/webkitpy/tool/bot/botinfo.py:
1035         (BotInfo.__init__): Take port's name.
1036         (BotInfo.summary_text):
1037
1038         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1039         (BotInfoTest.test_summary_text):
1040
1041         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1042         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1043
1044         * Scripts/webkitpy/tool/commands/queues.py:
1045         (PatchProcessingQueue.__init__): Initialize self._port.
1046         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1047         and use that for the attachment filename and the comment posted.
1048
1049         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1050         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1051         "mac-snowleopard" as expected for TestPort.
1052
1053 2013-03-22  Roger Fong  <roger_fong@apple.com>
1054
1055         Unreviewed. Turn off EWS test on Win again.
1056         The battle continues.
1057
1058         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1059         (WinEWS):
1060
1061 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1062
1063         NRWT: Enable pixel tests when retrying tests
1064         https://bugs.webkit.org/show_bug.cgi?id=112898
1065
1066         Reviewed by Dirk Pranke.
1067
1068         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1069         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1070         if we've forced pixel tests in the retry.
1071         (Manager._run_tests):
1072         (Manager._clean_up_run): Fixed the capitalizations.
1073         (Manager._force_pixel_tests_if_needed): Added.
1074
1075         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1076         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1077         'image_diff_percent' if it doesn't already exist.
1078
1079         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1080         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1081         treat this as a regular regression instead of a flakiness.
1082
1083         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1084         run had image diffs.
1085
1086         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1087         (summarized_results):
1088
1089         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1090         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1091         Also removed some dead code.
1092
1093         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1094         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1095         is set and pixel_tests_enabled is set to false.
1096         (EndToEndTest.test_reftest_with_two_notrefs):
1097
1098 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1099
1100         Make it possible to run layout tests on Retina MBP
1101         https://bugs.webkit.org/show_bug.cgi?id=93673
1102
1103         Reviewed by Ryosuke Niwa.
1104
1105         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1106         windows on 2x machines still run at 1x.
1107
1108         * DumpRenderTree/mac/DumpRenderTree.mm:
1109         (createWebViewAndOffscreenWindow):
1110         Reset the window resolution to 1x on creation.
1111         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
1112         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1113         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
1114         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1115         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
1116         (WTR::PlatformWebView::PlatformWebView):
1117         Add NSWindow details, reset the window resolution to 1x on creation.
1118
1119 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1120
1121         Leak bots shouldn't build
1122         https://bugs.webkit.org/show_bug.cgi?id=112774
1123
1124         Reviewed by Simon Fraser.
1125
1126         Since leak bots use regular debug builds, there is no need to build on these bots.
1127         Simply downloading builds will dramatically improve the cycle time of these bots.
1128
1129         * BuildSlaveSupport/build.webkit.org-config/config.json:
1130         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1131         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
1132         TestFactory instead of BuildAndTestFactory.
1133
1134 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1135
1136         [Qt] Fix the TestWebKitAPI build
1137         https://bugs.webkit.org/show_bug.cgi?id=113044
1138
1139         Reviewed by Tor Arne Vestbø.
1140
1141         The generate-forwarding-headers script would only be run
1142         after the targets in InjectedBundle.pri since the second
1143         addStrictSubdirOrderBetween call in
1144         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
1145         the derived_sources -> injected_bundle order in SUBDIRS.
1146
1147         Fix it by only moving the dependent target at the end of
1148         SUBDIRS, don't touch its dependency.
1149
1150         * qmake/mkspecs/features/functions.prf:
1151
1152 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1153
1154         [EFL][WK2] View is not focused when fullscreen mode toggled
1155         https://bugs.webkit.org/show_bug.cgi?id=113009
1156
1157         Reviewed by Laszlo Gombos.
1158
1159         Set focus on view when fullscreen mode enabled/disabled
1160         by FullScreen API.
1161
1162         * MiniBrowser/efl/main.c:
1163         (on_fullscreen_accept):
1164         (on_fullscreen_deny):
1165
1166 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1167
1168         nrwt is no longer saving retry results in the retries/ subdirectory
1169         https://bugs.webkit.org/show_bug.cgi?id=112995
1170
1171         Reviewed by Ojan Vafai.
1172
1173         I think this has been broken a long time, unfortunately. This
1174         patch should fix that.
1175
1176         In order to do so, I had to pass the directory to use from
1177         the Worker object through the SingleTestWriter to the
1178         TestResultWriter. While I was plumbing that through, I rationalized
1179         the order of the parameter arguments a bit ...
1180
1181         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1182         (Worker._run_single_test):
1183         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1184         (run_single_test):
1185         (SingleTestRunner.__init__):
1186         (SingleTestRunner._run_compare_test):
1187         (SingleTestRunner._run_rebaseline):
1188         (SingleTestRunner._run_reftest):
1189         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1190         (write_test_result):
1191         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1192         (TestResultWriterTest.test_reftest_diff_image):
1193         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1194         (RunTest.test_retrying_uses_retries_directory):
1195
1196 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
1197
1198         JSC profiler should have an at-a-glance report of the success of DFG optimization
1199         https://bugs.webkit.org/show_bug.cgi?id=112988
1200
1201         Reviewed by Geoffrey Garen.
1202
1203         * Scripts/display-profiler-output:
1204
1205 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1206
1207         [chromium] Linux ASAN WebKit canary is running out of memory
1208         https://bugs.webkit.org/show_bug.cgi?id=112978
1209
1210         Reviewed by Tony Chang.
1211
1212         Running the AddressSanitizer on a crash takes a lot of
1213         memory, so we should serialize access to it to avoid running
1214         out of memory on a machine.
1215
1216         * Scripts/webkitpy/layout_tests/port/chromium.py:
1217         (ChromiumPort._get_crash_log):
1218         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1219         (HttpLock.__init__):
1220         (HttpLock.wait_for_httpd_lock):
1221
1222 2013-03-21  Min Qin  <qinmin@chromium.org>
1223
1224         Cleanup android media layout test code
1225         https://bugs.webkit.org/show_bug.cgi?id=112944
1226
1227         Reviewed by Adam Barth.
1228
1229         Chromium change: https://codereview.chromium.org/12892010/
1230         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
1231         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
1232         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
1233         Instead, we should switch to use content shell for layout tests.
1234
1235         * DumpRenderTree/chromium/TestShell.cpp:
1236         (TestShell::resetTestController):
1237
1238 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1239
1240         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
1241         https://bugs.webkit.org/show_bug.cgi?id=112953
1242
1243         Reviewed by Tony Chang.
1244
1245         When I created the DumpRenderTree_resources target in r144863 I
1246         forgot to declare the needed dependencies on the other resource
1247         targets. Due to a quirk of ordering, this appears to have been fine
1248         w/ ninja but not w/ Xcode (which is still being used on the chromium
1249         mac valgrind bots). Declaring the dependencies fixes the build
1250         failures.
1251
1252         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1253
1254 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
1255
1256         [WinCairo] Correct assert in Empty BitmapImage Test.
1257         https://bugs.webkit.org/show_bug.cgi?id=112934
1258
1259         Reviewed by Tim Horton.
1260
1261         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1262         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
1263         to avoid ref counting assertion when leaving test scope.
1264
1265 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
1266
1267         [GTK] generate-feature-defines-files is incompatible with Python3
1268         https://bugs.webkit.org/show_bug.cgi?id=112956
1269
1270         Reviewed by Martin Robinson.
1271
1272         Make the generate-feature-defines-files compatible with Python3 by calling the items()
1273         method on the dictionary objects when iterating through said dictionaries.
1274
1275         * gtk/generate-feature-defines-files:
1276         (write_feature_defines_header):
1277         (write_flattened_feature_defines_file):
1278
1279 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1280
1281         kill-old-processes spits out error messages on Mac
1282         https://bugs.webkit.org/show_bug.cgi?id=112878
1283
1284         Reviewed by Jessie Berlin.
1285
1286         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
1287         included in the list of options grep --help shows.
1288
1289         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
1290
1291         * BuildSlaveSupport/kill-old-processes:
1292         (main):
1293
1294 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
1295
1296         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
1297         https://bugs.webkit.org/show_bug.cgi?id=112597
1298
1299         Reviewed by Xan Lopez.
1300
1301         These were introduced for the Chromium port in r105295. We need
1302         dummy implementations in order to compile the BlackBerry port.
1303
1304         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1305         (AccessibilityUIElement::scrollToMakeVisible):
1306         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1307         (AccessibilityUIElement::scrollToGlobalPoint):
1308
1309 2013-03-21  Roger Fong  <roger_fong@apple.com>
1310
1311         Re-enable WinEWS tests following r146376.
1312
1313         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1314         (WinEWS):
1315
1316 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
1317
1318         Unreviewed. Add Bem Jones-Bey to the list of contributors.
1319
1320         * Scripts/webkitpy/common/config/committers.py:
1321
1322 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1323
1324         [GTK] Missing atk in install-dependencies script
1325         https://bugs.webkit.org/show_bug.cgi?id=112272
1326
1327         Reviewed by Gustavo Noronha Silva.
1328
1329         * gtk/install-dependencies: Add missing atk dependency.
1330
1331 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1332
1333         [GTK] Missing backslash in install-dependencies script
1334         https://bugs.webkit.org/show_bug.cgi?id=112907
1335
1336         Reviewed by Philippe Normand.
1337
1338         * gtk/install-dependencies: Add missing backslash to dependencies
1339         list.
1340
1341 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1342
1343         EWS bots have stopped uploading results to bugzilla
1344         https://bugs.webkit.org/show_bug.cgi?id=101091
1345
1346         Reviewed by Adam Barth.
1347
1348         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
1349         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
1350         this relative file path resoled to a file inside a non-existent directory for "zip".
1351
1352         Fixed the bug by resolving both test results directory and zip archive paths in
1353         LayoutTestResultsReader.archive.
1354
1355         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
1356         in the future.
1357
1358         * Scripts/webkitpy/common/system/filesystem_mock.py:
1359         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
1360
1361         * Scripts/webkitpy/common/system/workspace.py:
1362         (Workspace.create_zip): Log the source path when "zip" failed.
1363
1364         * Scripts/webkitpy/common/system/workspace_mock.py:
1365         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
1366
1367         * Scripts/webkitpy/common/system/workspace_unittest.py:
1368         (WorkspaceTest.test_create_zip_exception): Test that.
1369
1370         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1371         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
1372         This is the actual bug fix.
1373
1374         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1375         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
1376
1377 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
1378
1379         [chromium] move WebThemeEngine implementations to TestRunner library
1380         https://bugs.webkit.org/show_bug.cgi?id=112751
1381
1382         Reviewed by Adam Barth.
1383
1384         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1385         * DumpRenderTree/DumpRenderTree.gypi:
1386         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1387         (WebKit):
1388         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1389         (WebTestRunner::TestInterfaces::themeEngine):
1390         (WebTestRunner):
1391         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1392         (WebKit):
1393         (TestInterfaces):
1394         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1395         (WebTestRunner::WebTestInterfaces::themeEngine):
1396         (WebTestRunner):
1397         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1398         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1399         (WebTestRunner):
1400         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1401         (WebTestRunner::WebTestThemeControlWin::box):
1402         (WebTestRunner::WebTestThemeControlWin::line):
1403         (WebTestRunner::WebTestThemeControlWin::triangle):
1404         (WebTestRunner::WebTestThemeControlWin::roundRect):
1405         (WebTestRunner::WebTestThemeControlWin::oval):
1406         (WebTestRunner::WebTestThemeControlWin::circle):
1407         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1408         (WebTestRunner::WebTestThemeControlWin::markState):
1409         (WebTestRunner::WebTestThemeControlWin::draw):
1410         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1411         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1412         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1413         (WebTestRunner):
1414         (WebTestThemeControlWin):
1415         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1416         (WebTestRunner):
1417         (WebTestThemeEngineMac):
1418         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1419         (+[FakeActiveWindow alwaysActiveWindow]):
1420         (+[FakeActiveWindow alwaysInactiveWindow]):
1421         (-[FakeActiveWindow initWithActiveControls:]):
1422         (-[FakeActiveWindow _hasActiveControls]):
1423         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1424         (WebTestRunner):
1425         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1426         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1427         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1428         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1429         (WebTestRunner):
1430         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1431         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1432         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1433         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1434         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1435         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1436         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1437         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1438         (WebTestRunner::WebTestThemeEngineWin::getSize):
1439         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1440         (WebTestRunner):
1441         (WebTestThemeEngineWin):
1442         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1443         * DumpRenderTree/chromium/TestShell.cpp:
1444         (TestShell::initialize):
1445         * DumpRenderTree/chromium/TestShell.h:
1446         (WebKit):
1447         * DumpRenderTree/chromium/TestShellMac.mm:
1448         (platformInit):
1449         * DumpRenderTree/chromium/TestShellWin.cpp:
1450         (platformInit):
1451         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1452
1453 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1454
1455         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
1456
1457         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
1458         New property sheet that does not link against CoreFoundation and
1459         CFNetwork.
1460         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1461         Use new TestWebKitAPICommonWinCairo property sheet.
1462         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1463         Ditto.
1464
1465 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1466
1467         [WinCairo] Unreviewed build fix for VS2010.
1468
1469         Had to add WinCairo-specific property sheets to deal with some
1470         library and path differences with the main Apple port.
1471
1472         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1473         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1474         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1475         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
1476         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
1477         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
1478
1479 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
1480
1481         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
1482         https://bugs.webkit.org/show_bug.cgi?id=112849
1483
1484         Reviewed by Sam Weinig.
1485
1486         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1487         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1488         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1489
1490 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1491
1492         [WinCairo] Build WebKit Tools under VS2010
1493         https://bugs.webkit.org/show_bug.cgi?id=112821
1494
1495         Reviewed by Tim Horton.
1496
1497         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1498         Add WinCairo-specific build target.
1499         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
1500         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
1501         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
1502         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
1503         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1504         Add WinCairo-specific build target.
1505         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1506         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1507         Add WinCairo-specific build target.
1508         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
1509         WinCairo-specific build target.
1510         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
1511         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
1512         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
1513         specific build target.
1514         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
1515         WinCairo-specific build target.
1516         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
1517         * win/record-memory/record-memoryDebugWinCairo.props: Added.
1518         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
1519
1520 2013-03-20  Roger Fong  <roger_fong@apple.com>
1521
1522         API test gardening AppleWin port.
1523
1524         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
1525
1526         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1527         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1528
1529 2013-03-20  Roger Fong  <roger_fong@apple.com>
1530
1531         Test fix for Win EWS bots, catch various errors and restart script if necessary.
1532
1533         * EWSTools/start-queue-win.sh:
1534
1535 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
1536
1537         Unreviewed, add myself to committers.py.
1538
1539 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1540
1541         Unreviewed. Adding another email for me.
1542
1543         * Scripts/webkitpy/common/config/committers.py:
1544
1545 2013-03-20  Justin Novosad  <junov@google.com>
1546
1547         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
1548         https://bugs.webkit.org/show_bug.cgi?id=112605
1549
1550         Reviewed by James Robinson.
1551
1552         Deleting all the code that was used for propagating and supporting
1553         the Chromium setting for disabling deferred 2d canvas rendering.
1554
1555         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1556         (main):
1557         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1558         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1559         (WebTestRunner::WebPreferences::reset):
1560         (WebTestRunner::WebPreferences::applyTo):
1561         * DumpRenderTree/chromium/TestShell.cpp:
1562         (TestShell::TestShell):
1563         (TestShell::resetWebSettings):
1564         (TestShell::runFileTest):
1565         * DumpRenderTree/chromium/TestShell.h:
1566         (TestShell):
1567
1568 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
1569
1570         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
1571         https://bugs.webkit.org/show_bug.cgi?id=112699.
1572
1573         Reviewed by Adam Barth.
1574
1575         * Scripts/webkitpy/layout_tests/port/qt.py:
1576         (QtPort._search_paths):
1577         (QtPort._port_specific_expectations_files):
1578         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1579         (QtPortTest):
1580         (QtPortTest._assert_search_path):
1581         (QtPortTest._assert_expectations_files):
1582
1583 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1584
1585         [Qt] Enable kerning by default
1586         https://bugs.webkit.org/show_bug.cgi?id=112704
1587
1588         Reviewed by Jocelyn Turcotte.
1589
1590         Disable kerning by default, since some reference test expectations
1591         expect kerning to be default off.
1592
1593         * DumpRenderTree/qt/TestRunnerQt.cpp:
1594         (TestRunnerQt::reset):
1595         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1596         (WTR::activateFonts):
1597
1598 2013-03-20  Zeno Albisser  <zeno@webkit.org>
1599
1600         [Qt] Remove empty function stubs from TestRunnerQt.
1601         https://bugs.webkit.org/show_bug.cgi?id=112799
1602
1603         We are reducing the code in TestRunnerQt step by step,
1604         in order to finally replace all of it with the generic
1605         TestRunner implementation.
1606         This patch removes several simple function stubs that
1607         currently do not implement any actual functionality.
1608
1609         Reviewed by Kenneth Rohde Christiansen.
1610
1611         * DumpRenderTree/qt/TestRunnerQt.cpp:
1612         * DumpRenderTree/qt/TestRunnerQt.h:
1613         (TestRunnerQt):
1614
1615 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1616
1617         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
1618         https://bugs.webkit.org/show_bug.cgi?id=112687
1619
1620         Reviewed by Kenneth Rohde Christiansen.
1621
1622         Hide the SearchBar by default on window creation.
1623
1624         * MiniBrowser/efl/main.c:
1625         (window_create):
1626
1627 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1628
1629         Unreviewed, rolling out r146304.
1630         http://trac.webkit.org/changeset/146304
1631         https://bugs.webkit.org/show_bug.cgi?id=112788
1632
1633         to many expectations to update (Requested by antonm on
1634         #webkit).
1635
1636         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1637         * DumpRenderTree/DumpRenderTree.gypi:
1638         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1639         (WebKit):
1640         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1641         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1642         (TestInterfaces):
1643         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1644         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1645         * DumpRenderTree/chromium/TestShell.cpp:
1646         (TestShell::initialize):
1647         * DumpRenderTree/chromium/TestShell.h:
1648         (WebKit):
1649         * DumpRenderTree/chromium/TestShellMac.mm:
1650         (platformInit):
1651         * DumpRenderTree/chromium/TestShellWin.cpp:
1652         (platformInit):
1653         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1654         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1655         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1656         (WebThemeControlDRTWin::box):
1657         (WebThemeControlDRTWin::line):
1658         (WebThemeControlDRTWin::triangle):
1659         (WebThemeControlDRTWin::roundRect):
1660         (WebThemeControlDRTWin::oval):
1661         (WebThemeControlDRTWin::circle):
1662         (WebThemeControlDRTWin::nestedBoxes):
1663         (WebThemeControlDRTWin::markState):
1664         (WebThemeControlDRTWin::draw):
1665         (WebThemeControlDRTWin::drawTextField):
1666         (WebThemeControlDRTWin::drawProgressBar):
1667         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1668         (WebThemeControlDRTWin):
1669         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1670         (WebThemeEngineDRTMac):
1671         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1672         (+[FakeActiveWindow alwaysActiveWindow]):
1673         (+[FakeActiveWindow alwaysInactiveWindow]):
1674         (-[FakeActiveWindow initWithActiveControls:]):
1675         (-[FakeActiveWindow _hasActiveControls]):
1676         (WebThemeEngineDRTMac::paintScrollbarThumb):
1677         (stateToHIEnableState):
1678         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1679         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1680         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
1681         (webRectToSkIRect):
1682         (drawControl):
1683         (drawTextField):
1684         (drawProgressBar):
1685         (WebThemeEngineDRTWin::paintButton):
1686         (WebThemeEngineDRTWin::paintMenuList):
1687         (WebThemeEngineDRTWin::paintScrollbarArrow):
1688         (WebThemeEngineDRTWin::paintScrollbarThumb):
1689         (WebThemeEngineDRTWin::paintScrollbarTrack):
1690         (WebThemeEngineDRTWin::paintSpinButton):
1691         (WebThemeEngineDRTWin::paintTextField):
1692         (WebThemeEngineDRTWin::paintTrackbar):
1693         (WebThemeEngineDRTWin::paintProgressBar):
1694         (WebThemeEngineDRTWin::getSize):
1695         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
1696         (WebThemeEngineDRTWin):
1697         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1698
1699 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1700
1701         [Qt] Support -webkit-font-smoothing
1702         https://bugs.webkit.org/show_bug.cgi?id=106009
1703
1704         Reviewed by Jocelyn Turcotte.
1705
1706         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
1707
1708         * DumpRenderTree/qt/TestRunnerQt.cpp:
1709         (TestRunnerQt::reset):
1710
1711 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
1712
1713         [GTK] accessibility/aria-scrollbar-role.html is failing
1714         https://bugs.webkit.org/show_bug.cgi?id=98358
1715
1716         Reviewed by Martin Robinson.
1717
1718         Adds support for checking accessibility object's orientation.
1719         Orientation is checked by retrieving proper state of accessibility object.
1720
1721         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1722         (checkElementState):
1723         (AccessibilityUIElement::orientation):
1724         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1725         (WTR::AccessibilityUIElement::orientation):
1726
1727 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
1728
1729         [chromium] move WebThemeEngine implementations to TestRunner library
1730         https://bugs.webkit.org/show_bug.cgi?id=112751
1731
1732         Reviewed by Adam Barth.
1733
1734         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1735         * DumpRenderTree/DumpRenderTree.gypi:
1736         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1737         (WebKit):
1738         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1739         (WebTestRunner::TestInterfaces::themeEngine):
1740         (WebTestRunner):
1741         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1742         (WebKit):
1743         (TestInterfaces):
1744         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1745         (WebTestRunner::WebTestInterfaces::themeEngine):
1746         (WebTestRunner):
1747         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1748         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1749         (WebTestRunner):
1750         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1751         (WebTestRunner::WebTestThemeControlWin::box):
1752         (WebTestRunner::WebTestThemeControlWin::line):
1753         (WebTestRunner::WebTestThemeControlWin::triangle):
1754         (WebTestRunner::WebTestThemeControlWin::roundRect):
1755         (WebTestRunner::WebTestThemeControlWin::oval):
1756         (WebTestRunner::WebTestThemeControlWin::circle):
1757         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1758         (WebTestRunner::WebTestThemeControlWin::markState):
1759         (WebTestRunner::WebTestThemeControlWin::draw):
1760         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1761         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1762         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1763         (WebTestRunner):
1764         (WebTestThemeControlWin):
1765         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1766         (WebTestRunner):
1767         (WebTestThemeEngineMac):
1768         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1769         (+[FakeActiveWindow alwaysActiveWindow]):
1770         (+[FakeActiveWindow alwaysInactiveWindow]):
1771         (-[FakeActiveWindow initWithActiveControls:]):
1772         (-[FakeActiveWindow _hasActiveControls]):
1773         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1774         (WebTestRunner):
1775         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1776         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1777         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1778         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1779         (WebTestRunner):
1780         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1781         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1782         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1783         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1784         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1785         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1786         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1787         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1788         (WebTestRunner::WebTestThemeEngineWin::getSize):
1789         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1790         (WebTestRunner):
1791         (WebTestThemeEngineWin):
1792         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1793         * DumpRenderTree/chromium/TestShell.cpp:
1794         (TestShell::initialize):
1795         * DumpRenderTree/chromium/TestShell.h:
1796         (WebKit):
1797         * DumpRenderTree/chromium/TestShellMac.mm:
1798         (platformInit):
1799         * DumpRenderTree/chromium/TestShellWin.cpp:
1800         (platformInit):
1801         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1802
1803 2013-03-19  Tony Chang  <tony@chromium.org>
1804
1805         Move testRunner.setTouchDragDropEnabled to internals.settings
1806         https://bugs.webkit.org/show_bug.cgi?id=112739
1807
1808         Reviewed by Adam Barth.
1809
1810         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1811         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
1812         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1813         (TestRunner): Remove unnecessary code.
1814         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1815         (WebTestRunner::WebPreferences::reset):
1816         (WebTestRunner::WebPreferences::applyTo): Always set to false.
1817
1818 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
1819
1820         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
1821         https://bugs.webkit.org/show_bug.cgi?id=112754
1822
1823         Reviewed by Darin Fisher.
1824
1825         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
1826         now that it's always defined.
1827
1828         * DumpRenderTree/chromium/WebViewHost.cpp:
1829         * DumpRenderTree/chromium/WebViewHost.h:
1830         (WebViewHost):
1831
1832 2013-03-19  Kenneth Russell  <kbr@google.com>
1833
1834         Unreviewed, rolling out r146290.
1835         http://trac.webkit.org/changeset/146290
1836         https://bugs.webkit.org/show_bug.cgi?id=112751
1837
1838         Broke Chromium Mac build.
1839
1840         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1841         * DumpRenderTree/DumpRenderTree.gypi:
1842         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1843         (WebKit):
1844         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1845         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1846         (TestInterfaces):
1847         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1848         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1849         * DumpRenderTree/chromium/TestShell.cpp:
1850         (TestShell::initialize):
1851         * DumpRenderTree/chromium/TestShell.h:
1852         (WebKit):
1853         * DumpRenderTree/chromium/TestShellMac.mm:
1854         (platformInit):
1855         * DumpRenderTree/chromium/TestShellWin.cpp:
1856         (platformInit):
1857         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1858         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1859         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1860         (WebThemeControlDRTWin::box):
1861         (WebThemeControlDRTWin::line):
1862         (WebThemeControlDRTWin::triangle):
1863         (WebThemeControlDRTWin::roundRect):
1864         (WebThemeControlDRTWin::oval):
1865         (WebThemeControlDRTWin::circle):
1866         (WebThemeControlDRTWin::nestedBoxes):
1867         (WebThemeControlDRTWin::markState):
1868         (WebThemeControlDRTWin::draw):
1869         (WebThemeControlDRTWin::drawTextField):
1870         (WebThemeControlDRTWin::drawProgressBar):
1871         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1872         (WebThemeControlDRTWin):
1873         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1874         (WebThemeEngineDRTMac):
1875         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1876         (+[FakeActiveWindow alwaysActiveWindow]):
1877         (+[FakeActiveWindow alwaysInactiveWindow]):
1878         (-[FakeActiveWindow initWithActiveControls:]):
1879         (-[FakeActiveWindow _hasActiveControls]):
1880         (WebThemeEngineDRTMac::paintScrollbarThumb):
1881         (stateToHIEnableState):
1882         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1883         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1884         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
1885         (webRectToSkIRect):
1886         (drawControl):
1887         (drawTextField):
1888         (drawProgressBar):
1889         (WebThemeEngineDRTWin::paintButton):
1890         (WebThemeEngineDRTWin::paintMenuList):
1891         (WebThemeEngineDRTWin::paintScrollbarArrow):
1892         (WebThemeEngineDRTWin::paintScrollbarThumb):
1893         (WebThemeEngineDRTWin::paintScrollbarTrack):
1894         (WebThemeEngineDRTWin::paintSpinButton):
1895         (WebThemeEngineDRTWin::paintTextField):
1896         (WebThemeEngineDRTWin::paintTrackbar):
1897         (WebThemeEngineDRTWin::paintProgressBar):
1898         (WebThemeEngineDRTWin::getSize):
1899         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
1900         (WebThemeEngineDRTWin):
1901         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1902
1903 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
1904
1905         [EFL] canvas-fallback-content.html is failing
1906         https://bugs.webkit.org/show_bug.cgi?id=111998
1907
1908         Reviewed by Chris Fleizach.
1909
1910         Adds support for getting platform name.
1911
1912         * DumpRenderTree/TestRunner.cpp:
1913         (TestRunner::staticValues):
1914         * DumpRenderTree/TestRunner.h:
1915         (TestRunner):
1916         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1917         (TestRunner::platformName):
1918
1919 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
1920
1921         [chromium] move WebThemeEngine implementations to TestRunner library
1922         https://bugs.webkit.org/show_bug.cgi?id=112751
1923
1924         Reviewed by Adam Barth.
1925
1926         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1927         * DumpRenderTree/DumpRenderTree.gypi:
1928         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1929         (WebKit):
1930         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1931         (WebTestRunner::TestInterfaces::themeEngine):
1932         (WebTestRunner):
1933         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1934         (WebKit):
1935         (TestInterfaces):
1936         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1937         (WebTestRunner::WebTestInterfaces::themeEngine):
1938         (WebTestRunner):
1939         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1940         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1941         (WebTestRunner):
1942         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1943         (WebTestRunner::WebTestThemeControlWin::box):
1944         (WebTestRunner::WebTestThemeControlWin::line):
1945         (WebTestRunner::WebTestThemeControlWin::triangle):
1946         (WebTestRunner::WebTestThemeControlWin::roundRect):
1947         (WebTestRunner::WebTestThemeControlWin::oval):
1948         (WebTestRunner::WebTestThemeControlWin::circle):
1949         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1950         (WebTestRunner::WebTestThemeControlWin::markState):
1951         (WebTestRunner::WebTestThemeControlWin::draw):
1952         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1953         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1954         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1955         (WebTestRunner):
1956         (WebTestThemeControlWin):
1957         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1958         (WebTestRunner):
1959         (WebTestThemeEngineMac):
1960         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1961         (+[FakeActiveWindow alwaysActiveWindow]):
1962         (+[FakeActiveWindow alwaysInactiveWindow]):
1963         (-[FakeActiveWindow initWithActiveControls:]):
1964         (-[FakeActiveWindow _hasActiveControls]):
1965         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1966         (WebTestRunner):
1967         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1968         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1969         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1970         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1971         (WebTestRunner):
1972         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1973         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1974         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1975         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1976         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1977         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1978         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1979         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1980         (WebTestRunner::WebTestThemeEngineWin::getSize):
1981         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1982         (WebTestRunner):
1983         (WebTestThemeEngineWin):
1984         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1985         * DumpRenderTree/chromium/TestShell.cpp:
1986         (TestShell::initialize):
1987         * DumpRenderTree/chromium/TestShell.h:
1988         (WebKit):
1989         * DumpRenderTree/chromium/TestShellMac.mm:
1990         (platformInit):
1991         * DumpRenderTree/chromium/TestShellWin.cpp:
1992         (platformInit):
1993         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1994
1995 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1996
1997         [EFL][WK2] Separate WebView further from EwkView
1998         https://bugs.webkit.org/show_bug.cgi?id=111591
1999
2000         Reviewed by Caio Marcelo de Oliveira Filho.
2001
2002         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2003         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2004         since we can afford it having EWKViewGetWKView() private API to access WKView.
2005
2006         * TestWebKitAPI/PlatformWebView.h:
2007         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2008         (TestWebKitAPI::TEST):
2009         * TestWebKitAPI/efl/PlatformWebView.cpp:
2010         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2011         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2012         (TestWebKitAPI::PlatformWebView::resizeTo):
2013         (TestWebKitAPI::PlatformWebView::page):
2014         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2015         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2016         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2017         * WebKitTestRunner/PlatformWebView.h:
2018         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2019         (WTR::EventSenderProxy::dispatchEvent):
2020         (WTR::EventSenderProxy::keyDown):
2021         (WTR::EventSenderProxy::sendTouchEvent):
2022         (WTR::EventSenderProxy::setTouchModifier):
2023         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2024         (WTR::PlatformWebView::PlatformWebView):
2025         (WTR::PlatformWebView::~PlatformWebView):
2026         (WTR::PlatformWebView::resizeTo):
2027         (WTR::PlatformWebView::page):
2028         (WTR::PlatformWebView::focus):
2029         (WTR::PlatformWebView::windowSnapshotImage):
2030
2031 2013-03-19  Roger Fong  <roger_fong@apple.com>
2032
2033         Changes to VS2010 project files should only trigger builds on Windows bots.
2034         https://bugs.webkit.org/show_bug.cgi?id=112731
2035
2036         Reviewed by Timothy Horton.
2037
2038         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2039         (_should_file_trigger_build):
2040
2041 2013-03-19  Roger Fong  <roger_fong@apple.com>
2042
2043         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2044
2045         * Scripts/webkitpy/tool/steps/runtests.py:
2046         (RunTests.run):
2047         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2048         (RunTestsTest.test_webkit_run_unit_tests):
2049
2050 2013-03-19  Julie Parent  <jparent@chromium.org>
2051
2052         Dashboards: Introduce history namespace and unit tests.
2053         https://bugs.webkit.org/show_bug.cgi?id=112645
2054
2055         Reviewed by Ojan Vafai.
2056         
2057         Laying the framework for introducing the new history object and
2058         namespace.  This moves only static functions into the history
2059         namespace, and moves corresponding unit tests into seperate
2060         unit test file.
2061
2062         * TestResultServer/static-dashboards/aggregate_results.html:
2063         * TestResultServer/static-dashboards/dashboard_base.js:
2064         (parseCrossDashboardParameters):
2065         (parseDashboardSpecificParameters):
2066         (parseParameters):
2067         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2068         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2069         (.switch.return):
2070         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2071         * TestResultServer/static-dashboards/history.js: Added.
2072         * TestResultServer/static-dashboards/history_unittests.js: Added.
2073         * TestResultServer/static-dashboards/loader.js:
2074         (.):
2075         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2076         * TestResultServer/static-dashboards/run-unittests.html:
2077         * TestResultServer/static-dashboards/timeline_explorer.html:
2078         * TestResultServer/static-dashboards/timeline_explorer.js:
2079         * TestResultServer/static-dashboards/treemap.html:
2080         * TestResultServer/static-dashboards/treemap.js:
2081         (.switch.return):
2082         * TestResultServer/static-dashboards/ui.js:
2083
2084 2013-03-19  Daniel Bates  <dbates@webkit.org>
2085
2086         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2087         https://bugs.webkit.org/show_bug.cgi?id=112732
2088
2089         Reviewed by Eric Seidel.
2090
2091         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2092         of an existing file cannot be applied.
2093
2094         In particular, svn-{apply, unapply} compensate for differences in line endings
2095         by converting the line endings in a diff to match the line endings in the target
2096         file. The diff(1) command precedes the last line of a diff that adds a newline
2097         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2098         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2099         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2100         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2101         the newline characters in this special character sequence to match the line endings
2102         in the target file.
2103
2104         * Scripts/VCSUtils.pm:
2105         (parseDiff):
2106         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2107         Added tests:
2108             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2109             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2110             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2111             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2112         (escapeNewLineCharacters): Added.
2113         (toMacLineEndings): Added.
2114
2115 2013-03-19  James Robinson  <jamesr@chromium.org>
2116
2117         [chromium] Remove compositor settings that don't go through WebKit
2118         https://bugs.webkit.org/show_bug.cgi?id=112718
2119
2120         Reviewed by Adam Barth.
2121
2122         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2123         (main):
2124         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2125         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2126         (WebTestRunner::WebPreferences::reset):
2127         (WebTestRunner::WebPreferences::applyTo):
2128         * DumpRenderTree/chromium/TestShell.cpp:
2129         (TestShell::TestShell):
2130         (TestShell::resetWebSettings):
2131         * DumpRenderTree/chromium/TestShell.h:
2132         (TestShell):
2133
2134 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
2135
2136         Unreviewed, rolling out r146101.
2137         https://bugs.webkit.org/show_bug.cgi?id=111884
2138
2139         re-enable custom freetype on asan; this needs to be on
2140         now that the bot is running lucid.
2141
2142         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2143
2144 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
2145
2146         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
2147         https://bugs.webkit.org/show_bug.cgi?id=112365
2148
2149         Reviewed by Benjamin Poulain.
2150
2151         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
2152         harcoding it in wtf/Platform.h
2153
2154         * Scripts/webkitperl/FeatureList.pm:
2155
2156 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2157
2158         [Qt] Make ImageDiff similar to Chromium's ImageDiff
2159         https://bugs.webkit.org/show_bug.cgi?id=94782
2160
2161         Based on patch by Csaba Osztrogonác.
2162         Reviewed by Jocelyn Turcotte.
2163
2164         The diff image is generated with bright red indicating errors, but letting the base image
2165         shine through so the context of the error-pixel can be identified.
2166
2167         * DumpRenderTree/qt/ImageDiff.cpp:
2168         (main):
2169
2170 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
2171
2172         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
2173
2174         Rubber-stamped by Csaba Osztrogonác.
2175
2176         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
2177         since the latter might not cover the former.
2178
2179         * QtTestBrowser/launcherwindow.cpp:
2180         (LauncherWindow::print):
2181
2182 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2183
2184         Style tweeks to default.css.
2185         
2186         Rubber-stamped by David Kilzer.
2187         
2188         Give visited links a different color to other links, so you can
2189         see which builds you've viewed.
2190         
2191         Make the <small> text less tiny.
2192
2193         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2194         (small):
2195         (a:link,a:visited,a:active):
2196         (a:visited):
2197
2198 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2199
2200         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
2201         https://bugs.webkit.org/show_bug.cgi?id=112494
2202
2203         Reviewed by Dirk Pranke.
2204
2205         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
2206         Also merged two pairs of methods to cleanup the code.
2207
2208         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2209         (PerfTestsRunner.run): Merged _upload_and_show_results.
2210         (PerfTestsRunner._generate_results): Merged _generate_output_files.
2211
2212 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2213
2214         [chromium] build xdisplaycheck when building DRT
2215         https://bugs.webkit.org/show_bug.cgi?id=112636
2216
2217         Reviewed by Tony Chang.
2218
2219         It appears that we need xdisplaycheck to be built in order for
2220         Xvfb to be started correctly on the bots, and DRT was missing
2221         a dependency on it. This may be the cause of the ASAN bot not
2222         starting up properly (it only builds DRT).
2223
2224         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2225
2226 2013-03-18  David Levin  <levin@chromium.org>
2227
2228         Implement icon change notification dump for Chromium's test shell.
2229         https://bugs.webkit.org/show_bug.cgi?id=112614
2230
2231         This was previously implemented for some other platforms in r58111
2232         and r116547.
2233
2234         In r122806, fast/dom/icon-url-property.html stopped using it, but
2235         it is useful for tests, so I plan to re-add it to that test again.
2236
2237         Reviewed by Jochen Eisinger.
2238
2239         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2240         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
2241          icon change notifications from WebKit may be logged in test output.
2242         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2243         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
2244         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
2245         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
2246         (WebTestRunner):
2247         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
2248         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2249         (TestRunner):
2250         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2251         (WebTestRunner::WebTestProxyBase::didChangeIcon):
2252         (WebTestRunner):
2253         * DumpRenderTree/chromium/WebViewHost.cpp:
2254         (WebViewHost::didChangeIcon): Add the output about changing the icon.
2255         * DumpRenderTree/chromium/WebViewHost.h:
2256         (WebViewHost):
2257
2258 2013-03-18  Julie Parent  <jparent@chromium.org>
2259
2260         Cleanup: Move js for treemap and aggregate_results into own js files.
2261         https://bugs.webkit.org/show_bug.cgi?id=112618
2262
2263         Reviewed by Dirk Pranke.
2264         
2265         No functional changes, just moving the code into separate js file
2266         rather than inlined in the html, so we can test it, make it more
2267         modular, etc.  Other dashboard types are already done this way.
2268
2269         * TestResultServer/static-dashboards/aggregate_results.html:
2270         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
2271         (generatePage):
2272         (handleValidHashParameter):
2273         (htmlForBuilder):
2274         (rawValuesHTML):
2275         (chartHTML):
2276         (filteredValues):
2277         (chart):
2278         (htmlForRevisionRows):
2279         (wrapHTMLInTable):
2280         (htmlForSummaryTable):
2281         (valuesPerExpectation):
2282         (htmlForTestType):
2283         (htmlForTableRow):
2284         (extendedEncode):
2285         * TestResultServer/static-dashboards/treemap.html:
2286         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
2287         (humanReadableTime):
2288         (convertToWebTreemapFormat):
2289         (reverseSortByAverage):
2290         (generatePage):
2291         (focusPath):
2292         (.switch.return):
2293         (handleQueryParameterChange):
2294         (extractName):
2295         (fullName):
2296         (handleFocus.):
2297         (handleFocus):
2298
2299 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2300
2301         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
2302         https://bugs.webkit.org/show_bug.cgi?id=112622
2303
2304         Reviewed by Dirk Pranke.
2305
2306         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2307         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
2308
2309 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2310
2311         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
2312         https://bugs.webkit.org/show_bug.cgi?id=112619
2313
2314         Reviewed by Dirk Pranke.
2315
2316         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
2317         directory and then fall back to the generic LayoutTests/platform/gtk directory.
2318
2319         * Scripts/webkitpy/layout_tests/port/gtk.py:
2320         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
2321         Port._webkit_baseline_path method.
2322         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2323         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
2324         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
2325         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2326         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
2327         that are expected based on the builder name.
2328
2329 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
2330
2331         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
2332         https://bugs.webkit.org/show_bug.cgi?id=112571
2333
2334         Reviewed by Adam Barth.
2335
2336         Update function declarations for new WebFileSystemType enum. (All
2337         changes are behind an #ifdef so we can sync required changes in embedders.)
2338
2339         * DumpRenderTree/chromium/WebViewHost.cpp:
2340         (WebViewHost::openFileSystem):
2341         (WebViewHost::deleteFileSystem):
2342         * DumpRenderTree/chromium/WebViewHost.h:
2343         (WebViewHost):
2344
2345 2013-03-18  Julie Parent  <jparent@chromium.org>
2346
2347         Cleanup: Move timeline_exporer js out of html file into js.
2348         https://bugs.webkit.org/show_bug.cgi?id=112188
2349
2350         Reviewed by Dirk Pranke.
2351         
2352         Moves the javascript out of the html file and into a new js file.
2353         This follows the format of flakiness_dashboard.{html|js}.
2354         
2355         Also moves code from dashboard_base that is used only by this one
2356         dashboard, and makes it private to the dashboard.
2357
2358         * TestResultServer/static-dashboards/dashboard_base.js:
2359         * TestResultServer/static-dashboards/timeline_explorer.html:
2360         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
2361         (generatePage):
2362         (initCurrentBuilderTestResults):
2363         (shouldShowWebKitRevisionsOnly):
2364         (updateTimelineForBuilder.):
2365         (updateTimelineForBuilder):
2366         (selectBuild):
2367         (updateBuildIndicator):
2368         (.addRow):
2369         (.addNumberRow):
2370         (.inspectorNode.getElementsByTagName.0.onclick):
2371         (.inspectorNode.getElementsByTagName.1.onclick):
2372         (.inspectorNode.getElementsByTagName.2.onclick):
2373         (updateBuildInspector):
2374         (showResultsDelta):
2375         (decompressResults.addFlakyDelta):
2376         (decompressResults):
2377
2378 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2379
2380         Unreviewed, rolling out r145272.
2381         http://trac.webkit.org/changeset/145272
2382         https://bugs.webkit.org/show_bug.cgi?id=111884
2383
2384         Turns out the ASAN build is still broken; possibly there's
2385         something still setting LD_LIBRARY_PATH, or possibly there's
2386         something else wrong. In the meantime, we need it to work again.
2387
2388         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2389
2390 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2391
2392         delete-stale-build-files is too aggressive
2393         https://bugs.webkit.org/show_bug.cgi?id=112595
2394
2395         Reviewed by Tim Horton.
2396
2397         It appears that whitelisting file extensions to keep is not a good idea.
2398         Blacklist files to delete instead, and only delete .o files for now.
2399         We can add more file extensions as needed.
2400
2401         * BuildSlaveSupport/delete-stale-build-files:
2402
2403 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2404
2405         Disable accessibility notifications after each test
2406         https://bugs.webkit.org/show_bug.cgi?id=112579
2407
2408         Reviewed by Tim Horton.
2409         
2410         In WebKitTestRunner, if any tests triggered accessibility notifications,
2411         the global notification handler would thereafter be active, and fire
2412         notifications for all subsequent tests.
2413         
2414         Fix by implementing AccessibilityController::resetToConsistentState() for
2415         Mac, and using it to clear the global notification handler.
2416
2417         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2418         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2419         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
2420         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
2421         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
2422         (e.g. because of -autorelease).
2423         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
2424         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
2425         if there is one.
2426         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
2427         Add -stopObserving
2428         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2429         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
2430         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
2431         center.
2432
2433 2013-03-18  Dana Jansens  <danakj@chromium.org>
2434
2435         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
2436         https://bugs.webkit.org/show_bug.cgi?id=112392
2437
2438         Reviewed by James Robinson.
2439
2440         Removes the command line flag option from DRT.
2441
2442         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2443         (main):
2444
2445 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2446
2447         [GTK] plugins/plugin-clip-subframe.html is failing
2448         https://bugs.webkit.org/show_bug.cgi?id=112570
2449
2450         Reviewed by Martin Robinson.
2451
2452         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
2453
2454 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
2455
2456         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
2457         https://bugs.webkit.org/show_bug.cgi?id=112442
2458
2459         Reviewed by Gustavo Noronha Silva.
2460
2461         * GtkLauncher/main.c:
2462         (reloadCb):
2463         (createToolbar):
2464         (createWindow):
2465
2466 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2467
2468         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
2469         https://bugs.webkit.org/show_bug.cgi?id=112205
2470
2471         Disable this API test until Geoff can fix it.
2472
2473         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2474         (TestWebKitAPI::TEST):
2475
2476 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
2477
2478         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2479         https://bugs.webkit.org/show_bug.cgi?id=112478
2480
2481         Reviewed by Tony Chang.
2482
2483         There is nothing that ensures that the log messages from the plugin
2484         come in before the layout test finished loading.
2485
2486         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2487         (PassDifferentNPPStruct::NPP_SetWindow):
2488         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2489         (NPP_SetWindow):
2490
2491 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2492
2493         Have the mac port support per_test_timeout in webkitpy
2494         https://bugs.webkit.org/show_bug.cgi?id=112466
2495
2496         Reviewed by Dirk Pranke.
2497         
2498         Both WTR and DRT handle --timeout arguments, so we can
2499         have the scripts pass the timeout values down to the tools.
2500
2501         * Scripts/webkitpy/layout_tests/port/mac.py:
2502         (MacPort.supports_per_test_timeout):
2503
2504 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
2505
2506         Remove setAsynchronousSpellCheckingEnabled from test runners
2507         https://bugs.webkit.org/show_bug.cgi?id=112362
2508
2509         Reviewed by Tony Chang.
2510
2511         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
2512         in internals.settings, so all ports can share it.
2513
2514         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2515         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2516         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2517         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2518         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2519         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2520         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2521         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
2522         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2523         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
2524         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2525         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2526
2527 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2528
2529         Fix the stupid unit tests.
2530
2531         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2532         (test_sample_process):
2533
2534 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
2535
2536         Collect samples for unresponsive web processes
2537         https://bugs.webkit.org/show_bug.cgi?id=112409
2538
2539         Reviewed by Tim Horton.
2540         
2541         When we detect that a subprocess was unresponsive, run the 'sample'
2542         tool on that process, for the Mac port.
2543         
2544         The sample will be linked to from the results.html page, next
2545         to the crash log link.
2546
2547         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2548         (Manager._look_for_new_crash_logs): Before looking for crash logs,
2549         look for samples on disk.
2550         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2551         (TestResultWriter):
2552         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
2553         -sample.txt files, and have it copy their contents to a new file
2554         next to the test that spawned them (as we do for crash logs).
2555         * Scripts/webkitpy/layout_tests/port/base.py:
2556         (Port.look_for_new_samples): Base class does nothing for sampling.
2557         * Scripts/webkitpy/layout_tests/port/driver.py:
2558         (Driver._check_for_driver_crash): Kick off a sample if we detected
2559         that the subprocess was unresponsive.
2560         * Scripts/webkitpy/layout_tests/port/mac.py:
2561         (MacPort.sample_file_path): Utility to generate the file path
2562         to the generated sample files at the top level of layout-test-results.
2563         (MacPort.look_for_new_crash_logs): Fix typo
2564         (MacPort.look_for_new_samples): New function to find sample files.
2565         (MacPort.sample_process): Use the utility function to get the file path.
2566
2567 2013-03-15  Zeno Albisser  <zeno@webkit.org>
2568
2569         [Qt] Remove simple getters and setters from TestRunnerQt
2570         https://bugs.webkit.org/show_bug.cgi?id=112343
2571
2572         Reviewed by Benjamin Poulain.
2573
2574         The removed functions and boolean members
2575         are being replaced by the implementations in the
2576         generic TestRunner.h.
2577
2578         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2579         (DumpRenderTree::dumpFrameScrollPosition):
2580         (DumpRenderTree::dumpFramesAsText):
2581         (DumpRenderTree::dump):
2582         (DumpRenderTree::titleChanged):
2583         (DumpRenderTree::dumpDatabaseQuota):
2584         (DumpRenderTree::dumpApplicationCacheQuota):
2585         (DumpRenderTree::statusBarMessage):
2586         (DumpRenderTree::createWindow):
2587         * DumpRenderTree/qt/TestRunnerQt.cpp:
2588         (TestRunnerQt::reset):
2589         * DumpRenderTree/qt/TestRunnerQt.h:
2590         (TestRunnerQt):
2591
2592 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
2593
2594         Update the link on build.webkit.org to refer to perf.webkit.org
2595         https://bugs.webkit.org/show_bug.cgi?id=112416
2596
2597         Reviewed by Philip Rogers.
2598
2599         Updated the link. Also updated the template to use HTML5 DOCTYPE.
2600
2601         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2602
2603 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
2604
2605         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
2606         https://bugs.webkit.org/show_bug.cgi?id=112394
2607
2608         Reviewed by Philippe Normand.
2609
2610         * GtkLauncher/main.c:
2611         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
2612
2613 2013-03-14  Andreas Kling  <akling@apple.com>
2614
2615         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
2616         <http://webkit.org/b/111815>
2617         <rdar://problem/13380145>
2618
2619         Reviewed by Anders Carlsson.
2620
2621         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
2622         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
2623         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
2624
2625         * WebKitTestRunner/PlatformWebView.h:
2626         (PlatformWebView):
2627         * WebKitTestRunner/TestController.cpp:
2628         (WTR::TestController::createOtherPage):
2629         (WTR::TestController::createWebViewWithOptions):
2630         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2631         (WTR::PlatformWebView::didInitializeClients):
2632
2633 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2634
2635         [EFL][MiniBrowser] Add a search field to the MiniBrowser
2636         https://bugs.webkit.org/show_bug.cgi?id=112122
2637
2638         Reviewed by Kenneth Rohde Christiansen.
2639
2640         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
2641
2642         * MiniBrowser/efl/main.c:
2643         (_Browser_Window):
2644         (search_box_show):
2645         (search_box_hide):
2646         (on_key_down):
2647         (on_url_changed):
2648         (on_search_field_aborted):
2649         (on_search_field_activated):
2650         (on_search_field_clicked):
2651         (on_search_backward_button_clicked):
2652         (on_search_forward_button_clicked):
2653         (window_create):
2654
2655 2013-03-14  Julie Parent  <jparent@chromium.org>
2656
2657         Cleanup: Remove g_resourceLoader.
2658         https://bugs.webkit.org/show_bug.cgi?id=112305
2659
2660         Reviewed by Dirk Pranke.
2661         
2662         Removing another global.
2663         
2664         Now, each dashboard creates its own loader, rather than having
2665         a general global one.
2666         
2667         Remove usage of g_resourceLoader.isLoadingComplete from 
2668         handleLocationChange by ensuring that handleLocationChange is
2669         never called before the loader is done.  It was called in two
2670         places before: 1 was from the callback when the loader is done,
2671         so that was obviously true, and the other was from onhashchange,
2672         where it would just return rather than running.  Instead, lets
2673         only register the onhashchange handler once the loader is
2674         setup, so the check is no longer necessary.
2675         
2676         Remove isLoadingComplete since it is now unused.
2677         
2678         Callback for loader is now initializeHistory, rather than just
2679         handleLocationChange which will set up the hashchange handler now.
2680         This will all eventually be moving to a new History object.
2681
2682         * TestResultServer/static-dashboards/aggregate_results.html:
2683         * TestResultServer/static-dashboards/dashboard_base.js:
2684         (handleLocationChange):
2685         (intializeHistory):
2686         (decompressResults):
2687         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2688         (generatePage):
2689         * TestResultServer/static-dashboards/loader.js:
2690         (.):
2691         * TestResultServer/static-dashboards/loader_unittests.js:
2692         * TestResultServer/static-dashboards/timeline_explorer.html:
2693         * TestResultServer/static-dashboards/treemap.html:
2694
2695 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
2696
2697         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
2698         https://bugs.webkit.org/show_bug.cgi?id=109404
2699
2700         Reviewed by Tony Chang.
2701
2702         Removes all the code related to smartInsertDeleteEnabled and
2703         selectTrailingWhitespaceEnabled settings as they will be managed from
2704         internals from now on.
2705
2706         * DumpRenderTree/TestRunner.cpp:
2707         (TestRunner::staticFunctions):
2708         * DumpRenderTree/TestRunner.h:
2709         (TestRunner):
2710         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2711         (WebKit):
2712         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2713         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2714         (DumpRenderTree):
2715         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2716         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2717         (WebTestRunner::WebTestProxy::didStopLoading):
2718         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2719         (WebTestRunner::TestRunner::TestRunner):
2720         (WebTestRunner::TestRunner::reset):
2721         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2722         (TestRunner):
2723         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2724         (WebTestRunner::WebPreferences::applyTo): Set default values for
2725         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
2726         Chromium DRT default values are different from Chromium browser.
2727         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2728         * DumpRenderTree/chromium/WebViewHost.cpp:
2729         * DumpRenderTree/chromium/WebViewHost.h:
2730         (WebViewHost):
2731         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2732         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2733         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2734         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2735         (resetDefaultsToConsistentValues):
2736         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2737         * DumpRenderTree/mac/DumpRenderTree.mm:
2738         (resetWebViewToConsistentStateBeforeTesting):
2739         * DumpRenderTree/mac/TestRunnerMac.mm:
2740         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2741         (WebCore::WebPage::resetSettings):
2742         * DumpRenderTree/qt/TestRunnerQt.cpp:
2743         * DumpRenderTree/qt/TestRunnerQt.h:
2744         (TestRunnerQt):
2745         * DumpRenderTree/win/DumpRenderTree.cpp:
2746         (resetWebViewToConsistentStateBeforeTesting):
2747         * DumpRenderTree/win/TestRunnerWin.cpp:
2748         * DumpRenderTree/wx/TestRunnerWx.cpp:
2749
2750 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2751
2752         [Qt] Disable DRT on Windows
2753
2754         Reviewed by Jocelyn Turcotte.
2755
2756         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
2757
2758         * qmake/mkspecs/features/configure.prf:
2759
2760 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2761
2762         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
2763         https://bugs.webkit.org/show_bug.cgi?id=110728
2764
2765         Reviewed by Gyuyoung Kim.
2766
2767         Use the page group to create the view object.
2768
2769         * MiniBrowser/efl/main.c:
2770         (window_create):
2771
2772 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2773
2774         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
2775
2776         Reviewed by Tor Arne Vestbø.
2777
2778         The mock versions of these web facing features should be instantiated when
2779         running in DumpRenderTree only. In order for them to work, no extra Qt modules
2780         such as QtLocation are actually needed.
2781
2782         This patch decouples enabling device orientation/motion and geolocation from
2783         the underlying Qt modules and makes them available in developer builds
2784         (!production_build) and backed by mock backends when running in drt.
2785
2786         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
2787         developers the web facing features are always enabled (although requests will
2788         time out) and the mock backends are enabled inside DRT, allowing for the layout
2789         tests to run with less dependencies.
2790
2791         In addition this also enables the mock device motion client, which was
2792         previously never instantiated.
2793
2794         * qmake/mkspecs/features/features.prf:
2795
2796 2013-03-14  Zeno Albisser  <zeno@webkit.org>
2797
2798         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
2799         https://bugs.webkit.org/show_bug.cgi?id=112340
2800
2801         Reviewed by Simon Hausmann.
2802
2803         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2804         (DumpRenderTree::dump):
2805             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
2806         (DumpRenderTree::dumpApplicationCacheQuota):
2807         * DumpRenderTree/qt/TestRunnerQt.cpp:
2808         (TestRunnerQt::reset):
2809         * DumpRenderTree/qt/TestRunnerQt.h:
2810         (TestRunnerQt):
2811
2812 2013-03-14  Zeno Albisser  <zeno@webkit.org>
2813
2814         [Qt] Port DRT to use TestRunner::dumpAsText()
2815         https://bugs.webkit.org/show_bug.cgi?id=112260
2816
2817         Reviewed by Benjamin Poulain.
2818
2819         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2820         (WebCore::DumpRenderTree::open):
2821         (WebCore::methodNameStringForFailedTest):
2822             Change parameter from type TestRunnerQt* to TestRunner*.
2823         (WebCore::DumpRenderTree::dump):
2824             TestRunnerQt::shouldDumpPixels() always returned true in our case.
2825             Instead we should rely on TestRunner::generatePixelResults().
2826         * DumpRenderTree/qt/TestRunnerQt.cpp:
2827         (TestRunnerQt::reset):
2828         * DumpRenderTree/qt/TestRunnerQt.h:
2829         (TestRunnerQt):
2830
2831 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
2832
2833         Implement FontLoader interface
2834         https://bugs.webkit.org/show_bug.cgi?id=98395
2835
2836         Reviewed by Eric Seidel.
2837
2838         Enable FontLoadEvents runtime flag for TestShell.
2839
2840         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2841         (WebTestRunner::TestInterfaces::TestInterfaces):
2842
2843 2013-03-13  Julie Parent  <jparent@chromium.org>
2844
2845         CLeanup: remove unnecessary call to parseParameters.
2846         https://bugs.webkit.org/show_bug.cgi?id=112309
2847
2848         Reviewed by Ojan Vafai.
2849         
2850         We call parseCrossDashboardParameters when the dashboard initially
2851         loads to set the state required for loadBuildersList, and then we
2852         call it again once we are fully done with loading, so there is no
2853         reason to call it in the middle of the loading process here.
2854
2855         * TestResultServer/static-dashboards/loader.js:
2856         (.):
2857
2858 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
2859
2860         Unreviewed. Now I'm a reviewer :)
2861
2862         * Scripts/webkitpy/common/config/committers.py:
2863
2864 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
2865
2866         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
2867         https://bugs.webkit.org/show_bug.cgi?id=112277
2868
2869         Reviewed by Adam Barth.
2870
2871         * Scripts/webkitperl/FeatureList.pm:
2872         * qmake/mkspecs/features/features.pri:
2873
2874 2013-03-13  Adam Barth  <abarth@webkit.org>
2875
2876         run-perf-tests should support content_shell
2877         https://bugs.webkit.org/show_bug.cgi?id=112291
2878
2879         Reviewed by Eric Seidel.
2880
2881         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2882         (PerfTestsRunner._parse_args):
2883
2884 2013-03-13  Oliver Hunt  <oliver@apple.com>
2885
2886         Simplify Checked<> multiplication
2887         https://bugs.webkit.org/show_bug.cgi?id=112286
2888
2889         Reviewed by James Robinson.
2890
2891         Add tests for multiplication by zero and max to ensure we don't
2892         mess them up should we ever make changes to Checked<> in future.
2893
2894         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2895         (TestWebKitAPI):
2896
2897 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2898
2899         [Qt] Unreviewed prospective Windows build fix
2900
2901         Do the usual thing, include the moc generated code in the .cpp file instead
2902         of compiling it standalone, to ensure that config.h is included, too, and
2903         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
2904
2905         * DumpRenderTree/qt/EventSenderQt.cpp:
2906
2907 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2908
2909         [Qt] Port TestRunner::findString to shared interface
2910         https://bugs.webkit.org/show_bug.cgi?id=112147
2911
2912         Reviewed by Jocelyn Turcotte.
2913
2914         This patch also removes DumpRenderTree and some other helper classes from
2915         the WebCore namespace, to which they do not really belong.
2916
2917         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2918         (main):
2919         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2920         (DumpRenderTree::DumpRenderTree):
2921         (DumpRenderTree::~DumpRenderTree):
2922         (DumpRenderTree::instance):
2923         (DumpRenderTree::setShouldTimeout):
2924         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2925         (DumpRenderTree):
2926         * DumpRenderTree/qt/EventSenderQt.cpp:
2927         (EventSender::contextClick):
2928         (EventSender::sendEvent):
2929         (EventSender::postEvent):
2930         * DumpRenderTree/qt/EventSenderQt.h:
2931         (EventSender::isGraphicsBased):
2932         * DumpRenderTree/qt/TestRunnerQt.cpp:
2933         (TestRunnerQt::TestRunnerQt):
2934         (TestRunner::findString):
2935         (TestRunnerQt::setMockDeviceOrientation):
2936         (TestRunnerQt::setGeolocationPermission):
2937         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
2938         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
2939         (TestRunnerQt::setMockGeolocationPosition):
2940         * DumpRenderTree/qt/TestRunnerQt.h:
2941         (TestRunnerQt):
2942
2943 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
2944
2945         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
2946         https://bugs.webkit.org/show_bug.cgi?id=112129
2947
2948         Reviewed by Adam Barth.
2949
2950         Following Chromium
2951         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
2952         this is being renamed to better explain what it does.
2953
2954         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2955
2956 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2957
2958         [Qt] Unreviewed trivial typo fix
2959
2960         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
2961         TextRunner.h. Thanks Zeno :)
2962
2963 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
2964
2965         [Qt] Prepare DRT for transition to shared TestRunner interface
2966         https://bugs.webkit.org/show_bug.cgi?id=112144
2967
2968         Reviewed by Benjamin Poulain.
2969
2970         Prepare Qt's DRT for a transition from the QObject based TestRunner to
2971         the JSC C API based one.
2972
2973         This is impplemented by instantiating the QObject based testRunner in
2974         the global object, then instantiating the JSC C based TestRunner
2975         separately and placing it "behind" the QObject based testRunner through
2976         injection of the individual functions through proxies. (prototype
2977         chaining doesn't work due to the this object and Function.prototype.bind
2978         doesn't work due to the native function)
2979
2980         This allows for porting over method by method by removing the method
2981         from the QObject TestRunnerQt and implementing it in the JSC C based
2982         TestRunner.
2983
2984         In order for this to link and run dummy implementations of all the
2985         necessary TestRunner functions are provided.
2986
2987         * DumpRenderTree/qt/DumpRenderTree.pro:
2988         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2989         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2990         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2991         (WebCore::DumpRenderTree::initJSObjects):
2992         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2993         (DumpRenderTree):
2994         * DumpRenderTree/qt/TestRunnerQt.cpp:
2995         (TestRunner::~TestRunner):
2996         (TestRunner::addDisallowedURL):
2997         (TestRunner::queueLoad):
2998         (TestRunner::removeAllVisitedLinks):
2999         (TestRunner::setAcceptsEditing):
3000         (TestRunner::simulateLegacyWebNotificationClick):
3001         (TestRunner::setWindowIsKey):
3002         (TestRunner::setAlwaysAcceptCookies):
3003         (TestRunner::addOriginAccessWhitelistEntry):
3004         (TestRunner::setWebViewEditable):
3005         (TestRunner::clearAllApplicationCaches):
3006         (TestRunner::setTextDirection):
3007         (TestRunner::notifyDone):
3008         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3009         (TestRunner::overridePreference):
3010         (TestRunner::pathToLocalResource):
3011         (TestRunner::removeAllWebNotificationPermissions):
3012         (TestRunner::simulateWebNotificationClick):
3013         (TestRunner::closeIdleLocalStorageDatabases):
3014         (TestRunner::focusWebView):
3015         (TestRunner::setBackingScaleFactor):
3016         (TestRunner::removeChromeInputField):
3017         (TestRunner::addChromeInputField):
3018         (TestRunner::originsWithLocalStorage):
3019         (TestRunner::deleteAllLocalStorage):
3020         (TestRunner::deleteLocalStorageForOrigin):
3021         (TestRunner::observeStorageTrackerNotifications):
3022         (TestRunner::syncLocalStorage):
3023         (TestRunner::windowCount):
3024         (TestRunner::setWaitToDump):
3025         (TestRunner::waitForPolicyDelegate):
3026         (TestRunner::webHistoryItemCount):
3027         (TestRunner::showWebInspector):
3028         (TestRunner::closeWebInspector):
3029         (TestRunner::evaluateInWebInspector):
3030         (TestRunner::setSerializeHTTPLoads):
3031         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3032         (TestRunner::setCustomPolicyDelegate):
3033         (TestRunner::setDatabaseQuota):
3034         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3035         (TestRunner::resetPageVisibility):
3036         (TestRunner::keepWebHistory):
3037         (TestRunner::goBack):
3038         (TestRunner::originsWithApplicationCache):
3039         (TestRunner::applicationCacheDiskUsageForOrigin):
3040         (TestRunner::display):
3041         (TestRunner::dispatchPendingLoadRequests):
3042         (TestRunner::clearPersistentUserStyleSheet):
3043         (TestRunner::callShouldCloseOnWebView):
3044         (TestRunner::copyDecodedHostName):
3045         (TestRunner::clearBackForwardList):
3046         (TestRunner::clearAllDatabases):
3047         (TestRunner::clearApplicationCacheForOrigin):
3048         (TestRunner::apiTestGoToCurrentBackForwardItem):
3049         (TestRunner::authenticateSession):
3050         (TestRunner::abortModal):
3051         (TestRunner::setStorageDatabaseIdleInterval):
3052         (TestRunner::setAsynchronousSpellCheckingEnabled):
3053         (TestRunner::setXSSAuditorEnabled):
3054         (TestRunner::setSpatialNavigationEnabled):
3055         (TestRunner::setScrollbarPolicy):
3056         (TestRunner::setJavaScriptCanAccessClipboard):
3057         (TestRunner::setAutomaticLinkDetectionEnabled):
3058         (TestRunner::setUserStyleSheetEnabled):
3059         (TestRunner::setUserStyleSheetLocation):
3060         (TestRunner::setUseDashboardCompatibilityMode):
3061         (TestRunner::setTabKeyCyclesThroughElements):
3062         (TestRunner::setSmartInsertDeleteEnabled):
3063         (TestRunner::setSelectTrailingWhitespaceEnabled):
3064         (TestRunner::setPrivateBrowsingEnabled):
3065         (TestRunner::setPluginsEnabled):
3066         (TestRunner::setPopupBlockingEnabled):
3067         (TestRunner::setMockSpeechInputDumpRect):
3068         (TestRunner::setPersistentUserStyleSheetLocation):
3069         (TestRunner::setMockGeolocationPosition):
3070         (TestRunner::setMockGeolocationPositionUnavailableError):
3071         (TestRunner::setMockDeviceOrientation):
3072         (TestRunner::setMainFrameIsFirstResponder):
3073         (TestRunner::setIconDatabaseEnabled):
3074         (TestRunner::setGeolocationPermission):
3075         (TestRunner::setDefersLoading):
3076         (TestRunner::setCacheModel):
3077         (TestRunner::setAuthorAndUserStylesEnabled):
3078         (TestRunner::setAllowFileAccessFromFileURLs):
3079         (TestRunner::setAppCacheMaximumSize):
3080         (TestRunner::setAllowUniversalAccessFromFileURLs):
3081         (TestRunner::setApplicationCacheOriginQuota):
3082         (TestRunner::denyWebNotificationPermission):
3083         (TestRunner::grantWebNotificationPermission):
3084         (TestRunner::setValueForUser):
3085         (TestRunner::setViewModeMediaFeature):
3086         (TestRunner::setPageVisibility):
3087         (TestRunner::addMockSpeechInputResult):
3088         (TestRunner::removeOriginAccessWhitelistEntry):
3089         (TestRunner::addUserScript):
3090         (TestRunner::isCommandEnabled):
3091         (TestRunner::evaluateScriptInIsolatedWorld):
3092         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3093         (TestRunner::copyEncodedHostName):
3094         (TestRunner::addUserStyleSheet):
3095         (TestRunner::findString):
3096         (TestRunner::execCommand):
3097         (TestRunner::localStorageDiskUsageForOrigin):
3098
3099 2013-03-12  Julie Parent  <jparent@chromium.org>
3100
3101         Cleanup: Move flatten-trie to loader.
3102         https://bugs.webkit.org/show_bug.cgi?id=112196
3103
3104         Reviewed by Dirk Pranke.
3105
3106         flatten-trie is used only by the loader, so move it there and make it
3107         private, rather than global in dashbaord_base. Moved the corresponding
3108         unit test from flakiness_dashboard_unittests to loader_unittests.
3109         
3110         * TestResultServer/static-dashboards/dashboard_base.js:
3111         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3112         * TestResultServer/static-dashboards/loader.js:
3113         (.):
3114         * TestResultServer/static-dashboards/loader_unittests.js:
3115
3116 2013-03-12  Oliver Hunt  <oliver@apple.com>
3117
3118         Unbreak api tests
3119
3120         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3121         (TestWebKitAPI):
3122
3123 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3124
3125         Unreviewed, disabling tests for Win EWS.
3126
3127         win-ews obviously cannot keep up with running tests, it's >300 behind.
3128         Probably doesn't help that its (likely) running tests serially.
3129
3130         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3131         (WinEWS):
3132
3133 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3134
3135         Add a --build-directory argument to delete-stale-build-files
3136         https://bugs.webkit.org/show_bug.cgi?id=112198
3137
3138         Reviewed by Ryosuke Niwa.
3139
3140         * BuildSlaveSupport/delete-stale-build-files:
3141         (main): Add --build-directory argument.
3142
3143 2013-03-12  Oliver Hunt  <oliver@apple.com>
3144
3145         Appease MSVC
3146
3147         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3148         (TestWebKitAPI):
3149
3150 2013-03-12  Oliver Hunt  <oliver@apple.com>
3151
3152         Add more Checked<> tests
3153         https://bugs.webkit.org/show_bug.cgi?id=112190
3154
3155         Reviewed by Geoffrey Garen.
3156
3157         Tests!
3158
3159         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3160         (TestWebKitAPI):
3161
3162 2013-03-12  Julie Parent  <jparent@chromium.org>
3163
3164         Cleanup: Move loading complete function into callback, rather than global.
3165         https://bugs.webkit.org/show_bug.cgi?id=112167
3166
3167         Reviewed by Dirk Pranke.
3168         
3169         Stop calling global functions, pass in proper handler to Loader
3170         constructor. Note that the callback is optional, as tests, and
3171         some potential dashboards, do not need one.
3172
3173         * TestResultServer/static-dashboards/dashboard_base.js:
3174         * TestResultServer/static-dashboards/loader.js:
3175         (.):
3176         * TestResultServer/static-dashboards/loader_unittests.js:
3177
3178 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3179
3180         [EFL][WK2] Add popup menu support to MiniBrowser
3181         https://bugs.webkit.org/show_bug.cgi?id=108934
3182
3183         Reviewed by Kenneth Rohde Christiansen.
3184
3185         Implement popup menu support in MiniBrowser by handling popup_menu_show
3186         and popup_menu_hide smart functions on the view and using the Ewk popup
3187         menu API.
3188
3189         * MiniBrowser/efl/main.c:
3190         (_Browser_Window):
3191         (on_popup_menu_discarded):
3192         (on_popup_menu_item_clicked):
3193         (popup_menu_populate):
3194         (on_popup_menu_show):
3195         (on_popup_menu_hide):
3196         (window_create): Use calloc() instead of malloc() to allocate memory for
3197         Browser_Window. This makes sure all the structs members are initialized
3198         to 0 (such as the new elm_popup_menu pointer).
3199
3200 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3201
3202         [GTK] Set up the libPlatformGtk.la library
3203         https://bugs.webkit.org/show_bug.cgi?id=111738
3204
3205         Reviewed by Martin Robinson.
3206
3207         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3208         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
3209         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3210
3211 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3212
3213         [GTK] Enable Web Audio in development builds
3214         https://bugs.webkit.org/show_bug.cgi?id=111831
3215
3216         Reviewed by Philippe Normand.
3217
3218         Web Audio is already quite well supported on the GTK port but still has a few issues
3219         that must be addressed before it is enabled by default. Despite that it should be enabled
3220         in development builds just so we are up-to-date with future feature infrastructure changes.
3221         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3222         that's an obvious goal before enabling the feature in release builds.
3223
3224         * Scripts/webkitperl/FeatureList.pm:
3225
3226 2013-03-11  Andreas Kling  <akling@apple.com>
3227
3228         [Mac][WK1] Add support for alert() in MiniBrowser.
3229         <http://webkit.org/b/112090>
3230
3231         Reviewed by Anders Carlsson.
3232
3233         * MiniBrowser/mac/WK1BrowserWindowController.m:
3234         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3235
3236 2013-03-11  Julie Parent  <jparent@chromium.org>
3237
3238         Dashboard cleanup: Create ui.Errors
3239         https://bugs.webkit.org/show_bug.cgi?id=111785
3240
3241         Reviewed by Ojan Vafai.
3242         
3243         Create ui.Errors for handling errors the dashboards
3244         encounter. Loader now has a Error object that it can add to,
3245         and individual dashboards can show errors when desired.
3246         Currently, only flakiness_db shows errors, but this is 
3247         generic and there is no reason why other dbs wouldn't want to
3248         show errors.
3249
3250         * TestResultServer/static-dashboards/dashboard_base.js:
3251         (resourceLoadingComplete):
3252         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3253         (generatePage):
3254         * TestResultServer/static-dashboards/loader.js:
3255         (.):
3256         * TestResultServer/static-dashboards/ui.js:
3257         (.):
3258
3259 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
3260
3261         Some StringHasher tests are broken because of missing null termination
3262         https://bugs.webkit.org/show_bug.cgi?id=111284
3263
3264         Reviewed by Darin Adler.
3265
3266         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3267         (TestWebKitAPI): Added null termination since C strings are null-terminated.
3268         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
3269         the bug caught by it is now fixed.
3270
3271 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3272
3273         Unreviewed, rolling out r145200.
3274         http://trac.webkit.org/changeset/145200
3275         https://bugs.webkit.org/show_bug.cgi?id=112063
3276
3277         Broke a couple of unit tests (Requested by zdobersek on
3278         #webkit).
3279
3280         * Scripts/webkitperl/FeatureList.pm:
3281
3282 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
3283
3284         [GTK] WebKit2-only build fails
3285         https://bugs.webkit.org/show_bug.cgi?id=112033
3286
3287         Reviewed by Gustavo Noronha Silva.
3288
3289         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
3290         generic part, WebKit1-specific part and WebKit2-specific part.
3291         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
3292         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
3293         directly.
3294
3295 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
3296
3297         Adding myself to the committers list.
3298
3299         Unreviewed.
3300
3301         * Scripts/webkitpy/common/config/committers.py:
3302
3303 2013-03-11  Jeff Rogers  <jrogers@rim.com>
3304
3305         [BlackBerry] Disable MathML support
3306         https://bugs.webkit.org/show_bug.cgi?id=111929
3307
3308         Reviewed by Rob Buis.
3309
3310         * Scripts/webkitperl/FeatureList.pm:
3311
3312 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3313
3314         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
3315         https://bugs.webkit.org/show_bug.cgi?id=111970
3316
3317         Reviewed by Chris Fleizach.
3318
3319         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
3320         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
3321         undefined symbol.
3322
3323         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3324         (WTR::AccessibilityUIElement::supportedActions):
3325         (WTR):
3326
3327 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
3328
3329         [chromium] Android apk targets should depend directly on Java library targets
3330         https://bugs.webkit.org/show_bug.cgi?id=111746
3331
3332         Reviewed by Eric Seidel.
3333
3334         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3335         Make DumpRenderTree_apk depend directly on base_java and net_java.
3336         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3337         Make TestWebKitAPI_apk depend directly on base_java.
3338
3339 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
3340
3341         [chromium] remove obsolete user gesture methods from WebFrame
3342         https://bugs.webkit.org/show_bug.cgi?id=111696
3343
3344         Reviewed by Adam Barth.
3345
3346         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3347         (WebTestRunner::TestPlugin::handleInputEvent):
3348         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3349
3350 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
3351
3352         Unreviewed, add myself to commiters.py.
3353
3354         * Scripts/webkitpy/common/config/committers.py:
3355
3356 2013-03-08  Julie Parent  <jparent@chromium.org>
3357
3358         Cleanup: Remove dead code.
3359         https://bugs.webkit.org/show_bug.cgi?id=111900
3360
3361         Reviewed by Dirk Pranke.
3362         
3363         Treemap overrides a global function that used to be in 
3364         dashboard_base, but was removed months ago in
3365         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
3366         no caller. 
3367
3368         * TestResultServer/static-dashboards/treemap.html:
3369
3370 2013-03-08  Harald Alvestrand  <hta@chromium.org>
3371
3372         Implemented new API for RTCStatsReport object.
3373         https://bugs.webkit.org/show_bug.cgi?id=110333
3374
3375         Reviewed by Adam Barth.
3376
3377         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3378         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
3379
3380 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
3381
3382         [chromium] use custom freetype on linux asan builds again
3383         https://bugs.webkit.org/show_bug.cgi?id=111884
3384
3385         Reviewed by Tony Chang.
3386
3387         We no longer need the workaround after chromium r186540.
3388
3389         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3390
3391 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
3392
3393         Warning about the user not having edit rights on Bugzilla is confusing new contributors
3394         https://bugs.webkit.org/show_bug.cgi?id=111798
3395
3396         Reviewed by Dirk Pranke.
3397
3398         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
3399
3400         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3401
3402 2013-03-08  James Robinson  <jamesr@chromium.org>
3403
3404         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
3405         https://bugs.webkit.org/show_bug.cgi?id=111632
3406
3407         Reviewed by Adrienne Walker.
3408
3409         * DumpRenderTree/chromium/WebViewHost.cpp:
3410         (WebViewHost::initializeLayerTreeView):
3411         * DumpRenderTree/chromium/WebViewHost.h:
3412         (WebViewHost):
3413
3414 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
3415
3416         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
3417         https://bugs.webkit.org/show_bug.cgi?id=111297
3418
3419         Reviewed by Kenneth Rohde Christiansen.
3420
3421         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3422         (WTR::TestRunner::setViewModeMediaFeature):
3423
3424 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
3425
3426         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
3427         https://bugs.webkit.org/show_bug.cgi?id=111814
3428
3429         Reviewed by Ryosuke Niwa.
3430
3431         Add the needed supportedActions() attribute to WKTestRunner.
3432
3433         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3434         (WTR::AccessibilityUIElement::supportedActions):
3435         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3436         (AccessibilityUIElement):
3437         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3438         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3439         (WTR::AccessibilityUIElement::supportedActions):
3440
3441 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3442
3443         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
3444         https://bugs.webkit.org/show_bug.cgi?id=111851
3445
3446         Reviewed by Kenneth Rohde Christiansen.
3447
3448         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3449         (TestWebKitAPI::TEST):
3450
3451             Fixed WKURLRef instance leaking.
3452
3453 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3454
3455         [EFL] [WK2] Some authentication tests fail in WebKit2
3456         https://bugs.webkit.org/show_bug.cgi?id=106407
3457
3458         Reviewed by Kenneth Rohde Christiansen.
3459
3460         Add patch from upstream for libsoup 2.40 to fix several authentication
3461         test cases.
3462
3463         * efl/jhbuild.modules:
3464         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
3465
3466 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
3467
3468         [GTK] Enable Web Audio in development builds
3469         https://bugs.webkit.org/show_bug.cgi?id=111831
3470
3471         Reviewed by Philippe Normand.
3472
3473         Web Audio is already quite well supported on the GTK port but still has a few issues
3474         that must be addressed before it is enabled by default. Despite that it should be enabled
3475         in development builds just so we are up-to-date with future feature infrastructure changes.
3476         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3477         that's an obvious goal before enabling the feature in release builds.
3478
3479         * Scripts/webkitperl/FeatureList.pm:
3480
3481 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3482
3483         [chromium] delay clearing the TestRunners until the main view was deleted
3484         https://bugs.webkit.org/show_bug.cgi?id=111823
3485
3486         Reviewed by Eric Seidel.
3487
3488         During WebViewHost::shutdown, we navigate the WebView to about:blank.
3489         This may call into the test runners which assume that the delegate is
3490         always non-NULL.
3491
3492         * DumpRenderTree/chromium/TestShell.cpp:
3493         (TestShell::~TestShell):
3494
3495 2013-03-07  Alan Cutter  <alancutter@chromium.org>
3496
3497         Sheriffbot whois command can't search by full name
3498         https://bugs.webkit.org/show_bug.cgi?id=111825
3499
3500         Reviewed by Eric Seidel.
3501
3502         Allowed multiple arguments to Sheriffbot's whois command.
3503         Updated test expectations.
3504
3505         * Scripts/webkitpy/tool/bot/irc_command.py:
3506         (Whois.execute):
3507         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3508         (IRCCommandTest.test_whois):
3509
3510 2013-03-07  Nils Barth  <nbarth@chromium.org>
3511
3512         Add Nils Barth and Koji Hara to committers.py
3513         https://bugs.webkit.org/show_bug.cgi?id=111806
3514
3515         Reviewed by Eric Seidel.
3516
3517         * Scripts/webkitpy/common/config/committers.py:
3518
3519 2013-03-07  Glenn Adams  <glenn@skynav.com>
3520
3521         run-pert-tests should have a --test-runner-count option
3522         https://bugs.webkit.org/show_bug.cgi?id=111726
3523
3524         Reviewed by Ryosuke Niwa.
3525
3526         Add --test-runner-count option to run-perf-tests, with default value of 4.
3527         This option allows command line configuration of the number of times to invoke
3528         the test runner (serially, not in parallel) when running a specific test in
3529         a test set.
3530
3531         * Scripts/webkitpy/performance_tests/perftest.py:
3532         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
3533         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
3534         (PerfTest.run): Rename process_run_count to test_runner_count.
3535         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
3536         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
3537         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
3538         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
3539         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3540         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
3541         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
3542         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3543         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
3544         (MainTest.test_run_with_repeat):
3545         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
3546         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3547         (MainTest.test_default_args): Add test for default option argument values.
3548         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
3549
3550 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
3551
3552         Add myself to reviewers.py
3553         https://bugs.webkit.org/show_bug.cgi?id=111757
3554
3555         Reviewed by Eric Seidel.
3556
3557         * Scripts/webkitpy/common/config/committers.py:
3558
3559 2013-03-07  Glenn Adams  <glenn@skynav.com>
3560
3561         run-perf-tests should have a --repeat option
3562         https://bugs.webkit.org/show_bug.cgi?id=100030
3563
3564         Reviewed by Ryosuke Niwa.
3565
3566         Add --repeat option to run-perf-tests, with default value of 1. When greater
3567         than 1, runs test set specified number of times. Note that multiple runs are
3568         not aggregated for statistical purposes.
3569
3570         Incidentally fixed typo: s/suceeds/succeeds/.
3571
3572         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3573         (PerfTestsRunner._parse_args): Add repeat option.
3574         (PerfTestsRunner.run): Add outer repeat loop.
3575         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
3576         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
3577         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3578         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
3579         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
3580         (MainTest.test_run_with_json_output): Fix typo.
3581         (MainTest.test_run_with_description): Fix typo.
3582         (MainTest.test_run_respects_no_results): Fix typo.
3583         (MainTest.test_run_with_slave_config_json): Fix typo.
3584         (MainTest.test_run_with_multiple_repositories): Fix typo.
3585         (MainTest.test_run_with_upload_json): Fix typo.
3586         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
3587         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
3588         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3589         (MainTest.test_parse_args): Add test for repeat option parsing.
3590
3591 2013-03-07  Julie Parent  <jparent@chromium.org>
3592
3593         showAllRuns checkbox no longer works on the stats dashboard
3594         https://bugs.webkit.org/show_bug.cgi?id=111673
3595
3596         Reviewed by Ojan Vafai.
3597
3598         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
3599         so we were trying to index into an undefined object.
3600         
3601         * TestResultServer/static-dashboards/dashboard_base.js:
3602         (invalidateQueryParameters):
3603
3604 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
3605
3606         [Chromium] Update #include for WebStorageNamespace.h
3607         https://bugs.webkit.org/show_bug.cgi?id=111748
3608
3609         Reviewed by Adam Barth.
3610
3611         In anticipation of removing
3612         WK/chromium/public/WebStorageNamespace.h (once downstream
3613         references have been updated)
3614
3615         * DumpRenderTree/chromium/WebViewHost.cpp:
3616
3617 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3618
3619         run-perf-tests fails due to svn_revision not working on a pure git clone
3620         https://bugs.webkit.org/show_bug.cgi?id=110839
3621
3622         Reviewed by Ryosuke Niwa.
3623
3624         Previously we would call git svn find-rev to look up the commit for
3625         a given revision, and that'll hang in a pure git checkout.
3626
3627         This patch changes the way we look up svn revisions in a git
3628         repository to use git log --grep 'git-svn-id', which is much faster
3629         than grepping ourselves. It also renames timestamp_of_latest_commit()
3630         to timestamp_of_revision() in order to accurately reflect what
3631         the method is doing. Note that this patch only changes the logic
3632         inside latest_revision() and svn_revision(). I'll file a separate
3633         bug to change git_commit_from_svn_revision().
3634
3635         This patch also contains some fixes to unit tests that had bit-rotted
3636         or were otherwise fragile, so that test-webkitpy --all would pass
3637         cleanly, and a fix to outputcapture so that
3638         test-webkitpy -p would work correctly again.
3639
3640         * Scripts/webkitpy/common/checkout/scm/git.py:
3641         (Git.svn_revision):
3642         (Git.timestamp_of_revision):
3643         * Scripts/webkitpy/common/checkout/scm/scm.py:
3644         (SCM.svn_revision):
3645         (SCM.timestamp_of_revision):
3646         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3647         (MockSCM.timestamp_of_revision):
3648         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3649         (_shared_test_commit_with_message):
3650         (test_commit_without_authorization):
3651         (test_timestamp_of_revision):
3652         * Scripts/webkitpy/common/checkout/scm/svn.py:
3653         (SVN.timestamp_of_revision):
3654         * Scripts/webkitpy/common/system/outputcapture.py:
3655           Importing unittest2 directly may not be safe if this module is
3656           imported before the autoinstaller gets a chance to set things up
3657           properly. We don't actually need unittest2 here.
3658         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3659         (PerfTestsRunner._generate_results_dict):
3660
3661 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3662
3663         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
3664         https://bugs.webkit.org/show_bug.cgi?id=111756
3665
3666         Reviewed by Kenneth Rohde Christiansen.
3667
3668         Bump libsoup to v2.40.3 to fix the regressions introduced by
3669         previous v2.40.0 bump.
3670
3671         * efl/jhbuild.modules:
3672
3673 2013-03-07  Roger Fong  <roger_fong@apple.com>
3674
3675         Re-enable Win EWS tests.
3676
3677         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3678         (WinEWS):
3679
3680 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3681
3682         [nrwt] handle corrupt http server pid files cleanly
3683         https://bugs.webkit.org/show_bug.cgi?id=111628
3684
3685         Reviewed by Eric Seidel.
3686
3687         If the pid file from a previous http server is corrupt for some
3688         reason, NRWT will just raise errors and not clean it up or recover.
3689         This patch fixes that to at least delete the pid file and
3690         not throw; not that we may still have stale http servers left on
3691         the system, since there's no way to know which pid to kill if
3692         the file was corrupted.
3693
3694         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3695         (HttpServerBase.start):
3696         (HttpServerBase.stop):
3697         (HttpServerBase._remove_pid_file):
3698         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
3699         (TestHttpServerBase):
3700         (TestHttpServerBase.test_corrupt_pid_file):
3701
3702 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
3703
3704         AX: Can't activate links with VoiceOver in Safari
3705         https://bugs.webkit.org/show_bug.cgi?id=111755
3706
3707         Reviewed by Tim Horton.
3708
3709         * DumpRenderTree/AccessibilityUIElement.cpp:
3710         (supportedActionsCallback):
3711         (AccessibilityUIElement::getJSClass):
3712         * DumpRenderTree/AccessibilityUIElement.h:
3713         (AccessibilityUIElement):
3714         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3715         (AccessibilityUIElement::supportedActions):
3716
3717 2013-03-07  Roger Fong  <roger_fong@apple.com>
3718
3719         Windows debug layout tests are crashing like crazy again.
3720         Disable tests on Win EWS bots temporarily.
3721
3722         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3723         (WinEWS):
3724
3725 2013-03-07  Roger Fong  <roger_fong@apple.com>
3726
3727         Make EWS bots build and test in release.
3728
3729         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3730         (WinEWS):
3731         * Scripts/webkitpy/tool/steps/runtests.py:
3732         (RunTests.run):
3733
3734 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3735
3736         [chromium] don't track the top loading frame if no layout test is currently running
3737         https://bugs.webkit.org/show_bug.cgi?id=111716
3738
3739         Reviewed by Kentaro Hara.
3740
3741         In DRT, we synchronously stop the test and start loading the next test
3742         URL. However, in content_shell, this happens asynchronously. It's
3743         important that the top loading frame is not changed due to stray
3744         navigation events before the next test starts.
3745
3746         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3747         (WebTestRunner::TestRunner::setTopLoadingFrame):
3748
3749 2013-03-06  Julie Parent  <jparent@chromium.org>
3750
3751         Dashboard cleanup: Move all dashboard ui related code into ui.js.
3752         https://bugs.webkit.org/show_bug.cgi?id=111621
3753
3754         Reviewed by Ojan Vafai.
3755         
3756         Creates ui.js, a package for the common UI code the various
3757         dashboards use. HTML generation is now in the ui.html namespace
3758         and popup handling is in ui.popup.
3759         Also moves the event listening for popups to ui.popup.show and
3760         removes it on ui.popup.hid rather than having listener always
3761         around.
3762
3763         * TestResultServer/static-dashboards/aggregate_results.html:
3764         * TestResultServer/static-dashboards/dashboard_base.js:
3765         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3766         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3767         (showPopupForBuild):
3768         (htmlForNavBar):
3769         (generatePageForIndividualTests.if):
3770         (generatePageForIndividualTests):
3771         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
3772         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3773         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3774         * TestResultServer/static-dashboards/run-unittests.html:
3775         * TestResultServer/static-dashboards/timeline_explorer.html:
3776         * TestResultServer/static-dashboards/treemap.html:
3777         * TestResultServer/static-dashboards/ui.js: Added.
3778         (.):
3779
3780 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
3781
3782         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
3783         https://bugs.webkit.org/show_bug.cgi?id=110584
3784
3785         Reviewed by Gyuyoung Kim.
3786
3787         Adds missing implementation of AccessibilityControllerEfl
3788         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
3789         so that it can make accessibilityController as a js object.
3790
3791         * DumpRenderTree/AccessibilityController.h:
3792         (AccessibilityController):
3793         * DumpRenderTree/AccessibilityUIElement.h:
3794         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3795         (AccessibilityController::childElementById): Moved declaration to base class.
3796         Implementation can be shared among other ports.
3797         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
3798         (AccessibilityController::focusedElement):
3799         (AccessibilityController::rootElement):
3800         (AccessibilityController::accessibleElementById):
3801         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
3802         (AccessibilityUIElement::helpText):
3803         * DumpRenderTree/efl/CMakeLists.txt:
3804         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3805         (DumpRenderTreeChrome::DumpRenderTreeChrome):
3806         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3807         (DumpRenderTreeChrome::onWindowObjectCleared):
3808         (DumpRenderTreeChrome::accessibilityController):
3809         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3810         (DumpRenderTreeChrome):
3811         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3812
3813 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
3814
3815         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
3816         https://bugs.webkit.org/show_bug.cgi?id=42696
3817
3818         Reviewed by Andreas Kling.
3819
3820         * DumpRenderTree/TestRunner.cpp:
3821         (TestRunner::staticFunctions):
3822         * DumpRenderTree/TestRunner.h:
3823         (TestRunner):
3824         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3825         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3826         (WebTestRunner::TestRunner::TestRunner):
3827         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3828         (TestRunner):
3829         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3830         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3831         * DumpRenderTree/mac/TestRunnerMac.mm:
3832         * DumpRenderTree/qt/TestRunnerQt.cpp:
3833         * DumpRenderTree/qt/TestRunnerQt.h:
3834         (TestRunnerQt):
3835         * DumpRenderTree/win/TestRunnerWin.cpp:
3836         * DumpRenderTree/wx/TestRunnerWx.cpp:
3837
3838 2013-03-06  Roger Fong  <roger_fong@apple.com>
3839
3840         Re-enable WinEWS test and decrease iterations before clean build back to 10.
3841
3842         * EWSTools/start-queue-win.sh:
3843         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3844         (WinEWS):
3845
3846 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
3847
3848         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
3849         https://bugs.webkit.org/show_bug.cgi?id=82866
3850
3851         Reviewed by Martin Robinson.
3852
3853         * Scripts/run-gtk-tests:
3854         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
3855         it is passing now.
3856
3857 2013-03-06  Julie Parent  <jparent@chromium.org>
3858
3859         Dashboard cleanup: remove dashboard time logging.
3860         https://bugs.webkit.org/show_bug.cgi?id=111608
3861
3862         Reviewed by Dirk Pranke.
3863
3864         Remove logTime.  It was never accurate, and the dev tools
3865         have better ways to measure this if anyone cares to look
3866         into dashboard perf.
3867         
3868         * TestResultServer/static-dashboards/dashboard_base.js:
3869         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3870         (processTestRunsForBuilder):
3871         (appendHTML):
3872
3873 2013-03-06  Tony Chang  <tony@chromium.org>
3874
3875         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3876         https://bugs.webkit.org/show_bug.cgi?id=111509
3877
3878         Reviewed by Dirk Pranke.
3879
3880         Add DumpRenderTree.pak to DumpRenderTree.app again.
3881
3882         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3883
3884 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
3885
3886         [chromium] introduce WebUserGestureIndicator
3887         https://bugs.webkit.org/show_bug.cgi?id=111531
3888
3889         Reviewed by Adam Barth.
3890
3891         * DumpRenderTree/chromium/WebViewHost.cpp:
3892         (WebViewHost::createView):
3893
3894 2013-03-06  Alan Cutter  <alancutter@chromium.org>
3895
3896         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
3897         https://bugs.webkit.org/show_bug.cgi?id=73482
3898
3899         Reviewed by Ryosuke Niwa.
3900
3901         Added input checking to the UpdateChromiumDEPS step.
3902         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
3903
3904         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
3905         (RollChromiumDEPS):
3906         (RollChromiumDEPS._parse_args):
3907         (RollChromiumDEPS.execute):
3908         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
3909         (IRCCommandTest.test_roll_chromium_deps):
3910         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
3911         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
3912         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
3913         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
3914         (UpdateChromiumDEPS._fetch_last_known_good_revision):
3915         (UpdateChromiumDEPS):
3916         (UpdateChromiumDEPS._parse_revision_number):
3917         (UpdateChromiumDEPS._validate_revisions):
3918         (UpdateChromiumDEPS.run):
3919         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
3920         (UpdateChromiumDEPSTest):
3921         (UpdateChromiumDEPSTest.test_parse_revision_number):
3922         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
3923         (RollChromiumDEPS):
3924         (PostChromiumDEPSRoll):
3925
3926 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
3927
3928         [Qt][MiniBrowser] Touch mocking broken for chained getures
3929         https://bugs.webkit.org/show_bug.cgi?id=111430
3930
3931         Reviewed by Jocelyn Turcotte.
3932
3933         Make it possible again to use touch mocking to test gesture chains
3934         like pan->pinch->pan->pinch without lifting the primary "finger".
3935         For this to work we need to track the pressed mouse buttons and
3936         only synthesize touch release events when the ctrl key is released
3937         if no mouse button is pressed. Else the pressed mouse button(s)
3938         should result in a stationary touch point in a touch update event.
3939         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
3940         to check for the state of the ctrl key modifier instead of getting
3941         it from the mouse events.
3942
3943         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3944         (MiniBrowserApplication::MiniBrowserApplication):
3945         (MiniBrowserApplication::notify):
3946
3947 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3948
3949         [chromium] don't use custom freetype on linux asan for now
3950         https://bugs.webkit.org/show_bug.cgi?id=111516
3951
3952         Unreviewed, build fix.
3953
3954         Turns out the custom lib is getting picked up by other binaries
3955         on our bot, which is bad.
3956
3957         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3958
3959 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3960
3961         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3962         https://bugs.webkit.org/show_bug.cgi?id=111509
3963
3964         Unreviewed, build fix.
3965
3966         Actually comment out the flag :(.
3967
3968         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3969
3970 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3971
3972         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3973         https://bugs.webkit.org/show_bug.cgi?id=111509
3974
3975         Unreviewed, build fix.
3976
3977         r144863 appears to have broken the xcode build; I'm temporarily
3978         trying this instead, and if this doesn't work, I'll revert the
3979         other changes.
3980
3981         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3982
3983 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3984
3985         [chromium] build a DumpRenderTree.pak even on windows
3986         https://bugs.webkit.org/show_bug.cgi?id=111504
3987
3988         Reviewed by Tony Chang.
3989
3990         The Chromium Aura build uses the default theme to draw
3991         controls, and that theme requires the ui ResourceBundle
3992         to be initialized. On every other platform, we build
3993         a DumpRenderTree.pak that works for this, but on Windows we
3994         still compile the resources directly into DRT. As a first step,
3995         let's build the pak file. I will then need to land a patch
3996         in Chromium to actually load it. Then I can go back and move
3997         the resources over to just use the .pak file and no longer need
3998         the .rc's.
3999
4000         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4001
4002 2013-03-05  Julie Parent  <jparent@chromium.org>
4003         Dashboard cleanup: move string utilities into their own namespace.
4004         
4005         https://bugs.webkit.org/show_bug.cgi?id=111485
4006
4007         Reviewed by Ojan Vafai.
4008         
4009         One of many pieces to clean up dashboard_base.
4010         
4011         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
4012
4013         * TestResultServer/static-dashboards/aggregate_results.html:
4014         * TestResultServer/static-dashboards/dashboard_base.js:
4015         (isTreeMap):
4016         (isFlakinessDashboard):
4017         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4018         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4019         (determineWKPlatform):
4020         (chromiumPlatform):
4021         (platformAndBuildType):
4022         (substringList):
4023         (individualTestsForSubstringList):
4024         (filterBugs):
4025         (populateExpectationsData):
4026         (processMissingTestsWithExpectations):
4027         (processMissingAndExtraExpectations):
4028         (htmlForSingleTestRow):
4029         (.dummyNode.onload):
4030         (expectationsTitle):
4031         * TestResultServer/static-dashboards/run-embedded-unittests.html:
4032         * TestResultServer/static-dashboards/run-unittests.html:
4033         * TestResultServer/static-dashboards/string.js: Added.
4034         * TestResultServer/static-dashboards/timeline_explorer.html:
4035         * TestResultServer/static-dashboards/treemap.html:
4036
4037 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
4038
4039         [EFL] Build break with latest EFL libraries
4040         https://bugs.webkit.org/show_bug.cgi?id=111028
4041
4042         Reviewed by Dirk Pranke.
4043
4044         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
4045         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
4046         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
4047
4048 2013-03-05  Roger Fong  <roger_fong@apple.com>
4049
4050         Increase number of WinEWS iterations to 20.
4051         Don't reboot after each iteration set.
4052         Make EWS bots just build temporarily so that the queue catches up again.
4053
4054         * EWSTools/start-queue-win.sh:
4055         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4056         (WinEWS):
4057
4058 2013-03-04  James Robinson  <jamesr@chromium.org>
4059
4060         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
4061         https://bugs.webkit.org/show_bug.cgi?id=111386
4062
4063         Reviewed by Adrienne Walker.
4064
4065         * DumpRenderTree/chromium/TestShell.cpp:
4066         (TestShell::initialize):
4067
4068 2013-03-05  Min Qin  <qinmin@chromium.org>
4069
4070         Copy dictionary to the external storage before running layout test on android
4071         https://bugs.webkit.org/show_bug.cgi?id=111480
4072
4073         Reviewed by Adam Barth.
4074
4075         TestWebKitPlatformSupport now needs to read an external dictionary file.
4076         This file does not exist on the device. We need to copy it before running layout tests.
4077
4078         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4079         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
4080         (ChromiumAndroidDriver._push_platform_resources):
4081
4082 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4083
4084         [chromium] DRT crashes in an Aura/Win build
4085         https://bugs.webkit.org/show_bug.cgi?id=111394
4086
4087         Reviewed by Tony Chang.
4088
4089         When building (and running) with use_aura=1, we assume that
4090         we're using the default theme engine, but DRT creates the
4091         DRTWin theme engine and overwrites the default, leading to crashes
4092         in basically every test from the mismatch.
4093
4094         This fix gets us down to at least "lots of crashes" :).
4095
4096         * DumpRenderTree/chromium/TestShellWin.cpp:
4097         (platformInit):
4098
4099 2013-03-05  Eric Seidel  <eric@webkit.org>
4100
4101         Add html-parser-threaded perf test now that the threaded parser is enabled by default
4102         https://bugs.webkit.org/show_bug.cgi?id=111200
4103
4104         Reviewed by Ryosuke Niwa.
4105
4106         Had to teach run-perf-tests to ignore one more warning.
4107
4108         * Scripts/webkitpy/performance_tests/perftest.py:
4109         (PerfTest):
4110
4111 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
4112
4113         Update list of builders for test results server
4114         https://bugs.webkit.org/show_bug.cgi?id=111166
4115
4116         Reviewed by Ojan Vafai.
4117
4118         * TestResultServer/static-dashboards/builders.jsonp:
4119
4120 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
4121
4122         [GTK] Move basic dependency installation to a script
4123         https://bugs.webkit.org/show_bug.cgi?id=110692
4124
4125         Reviewed by Gustavo Noronha Silva.
4126
4127         * gtk/install-dependencies: Added. A Script which installs all dependencies
4128         necessary for building for Debian-based distributions and Fedora.
4129
4130 2013-03-05  James Robinson  <jamesr@chromium.org>
4131
4132         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
4133         https://bugs.webkit.org/show_bug.cgi?id=111440
4134
4135         Reviewed by Adrienne Walker.
4136
4137         Remove unnecessary WebCompositorSupport::shutdown call
4138
4139         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4140         (main):
4141
4142 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
4143
4144         Unreviewed build fix.
4145
4146         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
4147
4148 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
4149
4150         [Qt][MiniBrowser] Improve the update of touch indicators
4151         https://bugs.webkit.org/show_bug.cgi?id=111429
4152
4153         Reviewed by Jocelyn Turcotte.
4154
4155         MiniBrowserApplication::sendTouchEvent sends an empty list
4156         to BrowserWindow::updateVisualMockTouchPoints if the control
4157         button is released, in which case the touch indicators should
4158         be hidden so that we never end up with a leftover indicator
4159         sticking on the screen.
4160         This patch also simplifies the lookup of the indicator items by
4161         replacing the findChild search in the item tree with a QHash
4162         that stores the touch ID's and the pointers to the corresponding
4163         indicator items.
4164
4165         * MiniBrowser/qt/BrowserWindow.cpp:
4166         (BrowserWindow::updateVisualMockTouchPoints):
4167         * MiniBrowser/qt/BrowserWindow.h:
4168         (BrowserWindow):
4169
4170 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
4171
4172         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
4173         https://bugs.webkit.org/show_bug.cgi?id=81042
4174
4175         Reviewed by Enrica Casucci.
4176
4177         Add setAsynchronousSpellCheckingEnabled implementation for
4178         WebKitTestRunner to have the possibility to test asynchronous
4179         spell checking implementation from bug 109577.
4180
4181         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4182         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4183         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
4184         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4185         * WebKitTestRunner/TestController.cpp:
4186         (WTR::TestController::resetStateToConsistentValues):
4187
4188 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
4189
4190         MediaStream API: Add the getStreamById method on RTCPeerConnection
4191         https://bugs.webkit.org/show_bug.cgi?id=111311
4192
4193         Reviewed by Adam Barth.
4194
4195         Changing mocks to be more realistic.
4196
4197         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
4198         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
4199         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
4200         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
4201         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
4202
4203 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
4204
4205         Add content shell bots to garden-o-matic for general failurse
4206         https://bugs.webkit.org/show_bug.cgi?id=111168
4207
4208         Reviewed by Adam Barth.
4209
4210         All but the WebKit (Content Shell) Android bot is stable enough. While
4211         they're not green yet, there must not be any non-layout test failures on
4212         them.
4213
4214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4215         (.):
4216
4217 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
4218
4219         [chromium] remove deprecated WebTestRunner::setFocus API
4220         https://bugs.webkit.org/show_bug.cgi?id=111354
4221
4222         Reviewed by James Robinson.
4223
4224         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
4225         (WebTestDelegate):
4226
4227 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
4228
4229         Run the bindings generation tests on EWS and CQ bots
4230         https://bugs.webkit.org/show_bug.cgi?id=111358
4231
4232         Reviewed by Adam Barth.
4233
4234         The tests are super fast and not flaky.
4235
4236         * Scripts/webkitpy/common/config/ports.py:
4237         (DeprecatedPort.run_bindings_tests_command):
4238         * Scripts/webkitpy/common/config/ports_mock.py:
4239         (MockPort.run_webkit_tests_command):
4240         (MockPort):
4241         (MockPort.run_bindings_tests_command):
4242         * Scripts/webkitpy/tool/commands/download_unittest.py:
4243         * Scripts/webkitpy/tool/steps/runtests.py:
4244         (RunTests.run):
4245         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4246         (RunTestsTest.test_webkit_run_unit_tests):
4247         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4248
4249 2013-03-04  Eric Seidel  <eric@webkit.org>
4250
4251         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
4252         https://bugs.webkit.org/show_bug.cgi?id=111384
4253
4254         Reviewed by Ryosuke Niwa.
4255
4256         Sometimes I want to know why various LayoutTests are slow
4257         without having to convert them into PerformanceTests in order
4258         to use our fancy profiling.  The Driver already knows how to
4259         do the right thing, we just need to expose the options to the user.
4260
4261         Handling of these options is already unittested in the perftests_unittest.
4262
4263         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4264         (parse_args):
4265
4266 2013-03-04  Alan Cutter  <alancutter@chromium.org>
4267
4268         check-webkit-style says "Have to enable auto props in the subversion config file"
4269         https://bugs.webkit.org/show_bug.cgi?id=107724
4270
4271         Reviewed by Tony Chang.
4272
4273         Added a standard svn config file for WebKit developers to use.
4274         Updated the style and commit queue bot build scripts to load this file.
4275
4276         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
4277         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
4278         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
4279         * svn-config: Added.
4280
4281 2013-03-04  James Robinson  <jamesr@chromium.org>
4282
4283         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
4284         https://bugs.webkit.org/show_bug.cgi?id=111285
4285
4286         Reviewed by Adrienne Walker.
4287
4288         This removes the need for WebCompositorSupport::initialize and exposes
4289         slightly fewer entry points across the repository boundary.
4290
4291         * DumpRenderTree/chromium/TestShell.cpp:
4292         (TestShell::initialize):
4293         * DumpRenderTree/chromium/TestShell.h:
4294