Fix missing dependencies in extract-dependencies-from-makefile
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-25  Keith Rollin  <krollin@apple.com>
2
3         Fix missing dependencies in extract-dependencies-from-makefile
4         https://bugs.webkit.org/show_bug.cgi?id=193783
5         <rdar://problem/47201571>
6
7         Reviewed by Alex Christensen.
8
9         The extract-dependencies-from-makefile script generates .xcfilelists
10         for XCBuild by invoking a makefile in --debug mode, parsing the
11         dependency information in the output, and extracting information
12         regarding targets and dependents. However, the way `make` emits this
13         dependency information is not rigorous, and so we need to determine
14         what lines to look for and parse by trial and error. This approach
15         didn't coriginally atch all the information we needed to collect, so
16         update the script to look for the additional lines we now know to look
17         for.
18
19         * Scripts/extract-dependencies-from-makefile:
20         (Parser):
21         (Parser.addTarget):
22         (Parser.addPrereq):
23         (Parser.doParse):
24
25 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
26
27         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
28         https://bugs.webkit.org/show_bug.cgi?id=193297
29         <rdar://problem/47158841>
30
31         Reviewed by Alex Christensen.
32
33         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
34             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
35         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
36         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
37         activating the message used to trigger the callback when it is set.
38
39 2019-01-25  Alex Christensen  <achristensen@webkit.org>
40
41         WKWebView.goBack should reload if there is a safe browsing warning
42         https://bugs.webkit.org/show_bug.cgi?id=193805
43         <rdar://problem/46908216>
44
45         Reviewed by Geoff Garen.
46
47         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
48         (+[Simple3LookupContext sharedLookupContext]):
49         (-[Simple3LookupContext lookUpURL:completionHandler:]):
50         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
51         (TEST):
52
53 2019-01-25  Chris Dumez  <cdumez@apple.com>
54
55         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
56         https://bugs.webkit.org/show_bug.cgi?id=193788
57         <rdar://problem/47531231>
58
59         Reviewed by Alex Christensen.
60
61         Add API test coverage.
62
63         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
64         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
65
66 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
67
68         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
69         https://bugs.webkit.org/show_bug.cgi?id=193771
70
71         Unreviewed infrastructure fix.
72
73         * Scripts/webkitpy/port/darwin.py:
74         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
75
76 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
77
78         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
79
80 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
81
82         Add contributors.json entries for Ling Ho and for a new bot watchers group.
83
84         * Scripts/webkitpy/common/config/contributors.json:
85
86 2019-01-25  Chris Dumez  <cdumez@apple.com>
87
88         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
89         https://bugs.webkit.org/show_bug.cgi?id=193779
90         <rdar://problem/46170903>
91
92         Reviewed by Antti Koivisto.
93
94         Add API test that quickly navigates forward to a previous process without waiting for it to
95         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
96         the process' previous page when reconnecting the it for the forward navigation.
97
98         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
99
100 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
101
102         Need a way for JavaScript (or bundle) code to participate in undo
103         https://bugs.webkit.org/show_bug.cgi?id=190009
104         <rdar://problem/44807048>
105
106         Reviewed by Ryosuke Niwa.
107
108         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
109         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
110
111         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
112         (WTR::UIScriptController::lastUndoLabel const):
113         (WTR::UIScriptController::firstRedoLabel const):
114         (WTR::UIScriptController::platformUndoManager const):
115         * DumpRenderTree/mac/UIScriptControllerMac.mm:
116         (WTR::UIScriptController::lastUndoLabel const):
117         (WTR::UIScriptController::firstRedoLabel const):
118         (WTR::UIScriptController::platformUndoManager const):
119         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
120         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
121         (WTR::UIScriptController::lastUndoLabel const):
122         (WTR::UIScriptController::firstRedoLabel const):
123         * TestRunnerShared/UIScriptContext/UIScriptController.h:
124         * WebKitTestRunner/UIScriptControllerCocoa.mm:
125         (WTR::UIScriptController::lastUndoLabel const):
126         (WTR::UIScriptController::firstRedoLabel const):
127         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
128         (WTR::UIScriptController::platformUndoManager const):
129         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
130         (WTR::UIScriptController::platformUndoManager const):
131
132 2019-01-25  Zalan Bujtas  <zalan@apple.com>
133
134         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
135         https://bugs.webkit.org/show_bug.cgi?id=193824
136
137         Reviewed by Antti Koivisto.
138
139         * LayoutReloaded/misc/LFC-passing-tests.txt:
140
141 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
142
143         Update macOS JSC bot configurations
144         https://bugs.webkit.org/show_bug.cgi?id=193739
145
146         Reviewed by Alexey Proskuryakov.
147
148         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
149         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
150         (BubbleQueueServer): Move JSC EWS to Mojave section.
151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
152         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
153         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
154
155 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
156
157         [Win][WebKitTestRunner] Implement EventSenderProxy
158         https://bugs.webkit.org/show_bug.cgi?id=193755
159
160         Reviewed by Don Olmstead.
161
162         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
163         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
164         (WTR::EventSenderProxy::dispatchMessage):
165         (WTR::EventSenderProxy::EventSenderProxy):
166         (WTR::EventSenderProxy::mouseDown):
167         (WTR::EventSenderProxy::mouseUp):
168         (WTR::EventSenderProxy::mouseMoveTo):
169         (WTR::EventSenderProxy::mouseScrollBy):
170         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
171
172 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
173
174         Unreviewed fix for API test failure after r240437.
175
176         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
177
178         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
179
180 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
181
182         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
183         https://bugs.webkit.org/show_bug.cgi?id=193787
184         <rdar://problem/47497634>
185
186         Reviewed by Alexey Proskuryakov.
187
188         * Scripts/webkitdirs.pm:
189         (iosSimulatorApplicationsPath): Pick from available runtime directories.
190
191 2019-01-24  Truitt Savell  <tsavell@apple.com>
192
193         Unreviewed, rolling out r240446.
194
195         Casued 5 API failures
196
197         Reverted changeset:
198
199         "Activate the WebResourceLoadStatisticsStore in the
200         NetworkProcess and deactivate it in the UIProcess."
201         https://bugs.webkit.org/show_bug.cgi?id=193297
202         https://trac.webkit.org/changeset/240446
203
204 2019-01-24  Zalan Bujtas  <zalan@apple.com>
205
206         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
207         https://bugs.webkit.org/show_bug.cgi?id=193741
208         <rdar://problem/47135030>
209
210         Reviewed by Antti Koivisto and Simon Fraser.
211
212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
213         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
214         (TestWebKitAPI::TEST):
215
216 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
217
218         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
219         https://bugs.webkit.org/show_bug.cgi?id=193297
220         <rdar://problem/47158841>
221
222         Reviewed by Alex Christensen.
223
224         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
225         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
226         activating the message used to trigger the callback when it is set.
227
228 2019-01-24  John Wilander  <wilander@apple.com>
229
230         Add Ad Click Attribution as an internal/experimental feature
231         https://bugs.webkit.org/show_bug.cgi?id=193685
232         <rdar://problem/47450399>
233
234         Reviewed by Brent Fulgham.
235
236         Added test option adClickAttributionEnabled.
237
238         * DumpRenderTree/TestOptions.cpp:
239         (TestOptions::TestOptions):
240         * DumpRenderTree/TestOptions.h:
241         * DumpRenderTree/mac/DumpRenderTree.mm:
242         (setWebPreferencesForTestOptions):
243
244 2019-01-24  Antti Koivisto  <antti@apple.com>
245
246         [PSON] Flash on back navigation on Mac
247         https://bugs.webkit.org/show_bug.cgi?id=193716
248         <rdar://problem/47148458>
249
250         Reviewed by Chris Dumez.
251
252         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
253
254         Closing of the previous page is delayed so waiting for didFinishNavigation is
255         not sufficient to guarantee we have received all the messages. Wait for them.
256
257 2019-01-24  Chris Dumez  <cdumez@apple.com>
258
259         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
260         https://bugs.webkit.org/show_bug.cgi?id=193761
261         <rdar://problem/47456405>
262
263         Reviewed by Alex Christensen.
264
265         Add API test coverage.
266
267         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
268
269 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
270
271         webkitpy: Missing PID in crashlog name should not be fatal
272         https://bugs.webkit.org/show_bug.cgi?id=193771
273
274         If we can't determine the PID of a crashlog, just ignore the crashlog instead
275         of raising an exception.
276
277         Reviewed by Lucas Forschler.
278
279         * Scripts/webkitpy/port/darwin.py:
280         (DarwinPort._merge_crash_logs):
281
282 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
283
284         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
285         https://bugs.webkit.org/show_bug.cgi?id=193746
286
287         Reviewed by Youenn Fablet.
288
289         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
290         so we'd best just not call it.
291
292         * Scripts/webkitpy/w3c/test_exporter.py:
293         (WebPlatformTestExporter.create_branch_with_patch):
294
295 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
296
297         Move FileSystem to WTF
298         https://bugs.webkit.org/show_bug.cgi?id=193602
299
300         Reviewed by Yusuke Suzuki.
301
302         * DumpRenderTree/win/DumpRenderTree.cpp:
303         * TestWebKitAPI/CMakeLists.txt:
304         * TestWebKitAPI/PlatformGTK.cmake:
305         * TestWebKitAPI/PlatformJSCOnly.cmake:
306         * TestWebKitAPI/PlatformPlayStation.cmake:
307         * TestWebKitAPI/PlatformWPE.cmake:
308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
309         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
310         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
311         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
312         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
313         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
314         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
315         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
316         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
317         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
318
319 2019-01-24  Philippe Normand  <pnormand@igalia.com>
320
321         [WPE] Remove hard dependency on subprocess32 for the API tests
322
323         Rubber-stamped by Carlos Garcia Campos.
324
325         * glib/api_test_runner.py:
326         (TestRunner._run_test_qt): Lazily import subprocess32 and check
327         its presence only when running WPEQt tests.
328
329 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
330
331         [GLIB] Expose JavaScriptCore options in GLib public API
332         https://bugs.webkit.org/show_bug.cgi?id=188742
333
334         Reviewed by Michael Catanzaro.
335
336         Add a test for the new API.
337
338         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
339         (testsJSCOptions):
340         (main):
341
342 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
343
344         [GTK][WPE] Support JPEG 2000 images
345         https://bugs.webkit.org/show_bug.cgi?id=186272
346
347         Reviewed by Žan Doberšek.
348
349         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
350
351         * gtk/jhbuild.modules:
352         * wpe/jhbuild.modules:
353
354 2019-01-23  David Kilzer  <ddkilzer@apple.com>
355
356         check-webkit-style should warn when using soft-linking macros in a header
357         <https://webkit.org/b/193750>
358
359         Reviewed by Darin Adler.
360
361         * Scripts/webkitpy/style/checkers/cpp.py:
362         (check_language): Add softlink/header check by refactoring the
363         softlink/framework check.
364         (CppChecker): Enable softlink/header check by default.
365         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
366         (CppStyleTest.test_softlink_framework): Rename from
367         CppStyleTest.test_softlink() and change test framework name in
368         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
369         files. Set file_name for macros that only appear in headers.
370         (CppStyleTest.test_softlink_header): Add tests for using
371         soft-link macros in headers.
372
373 2019-01-23  Chris Dumez  <cdumez@apple.com>
374
375         Deprecate API to limit the maximum number of WebProcesses
376         https://bugs.webkit.org/show_bug.cgi?id=193725
377         <rdar://problem/47464879>
378
379         Reviewed by Geoff Garen.
380
381         Update existing API tests to stop using deprecated API.
382
383         * MiniBrowser/mac/AppDelegate.m:
384         (defaultConfiguration):
385         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
386         (TestWebKitAPI::TEST):
387         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
388         (TestWebKitAPI::TEST):
389         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
390         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
391         (TEST):
392         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
393         (TEST):
394
395 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
396
397         [ews-app] Rename ews model buildermappings to buildermapping
398         https://bugs.webkit.org/show_bug.cgi?id=193729
399
400         Reviewed by Lucas Forschler.
401
402         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
403         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
404         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
405
406 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
407
408         [ews-app] Rename ews model steps to step
409         https://bugs.webkit.org/show_bug.cgi?id=193697
410
411         Reviewed by Lucas Forschler.
412
413         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
414         (Step): Renamed Steps to Step.
415
416 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
417
418         Clean up IndexedDB files between tests
419         https://bugs.webkit.org/show_bug.cgi?id=192796
420         <rdar://problem/46824999>
421
422         Reviewed by Geoffrey Garen.
423
424         * DumpRenderTree/mac/DumpRenderTree.mm:
425         (runTest):
426         * WebKitTestRunner/TestController.cpp:
427         (WTR::TestController::resetStateToConsistentValues):
428         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
429         (WTR::RemoveAllIndexedDatabasesCallback):
430         (WTR::TestController::ClearIndexedDatabases):
431         * WebKitTestRunner/TestController.h:
432         * WebKitTestRunner/TestInvocation.cpp:
433         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
434
435 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
436
437         [ews-app] Rename ews model Builds to Build
438         https://bugs.webkit.org/show_bug.cgi?id=193695
439
440         Reviewed by Lucas Forschler.
441
442         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
443         (Build): Renamed Builds to Build.
444
445 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
446
447         webkitpy: Wait longer when launching WebKitTestRunner
448         https://bugs.webkit.org/show_bug.cgi?id=193734
449
450         Reviewed by Aakash Jain.
451
452         * Scripts/webkitpy/port/simulator_process.py:
453         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
454
455 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
456
457         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
458         https://bugs.webkit.org/show_bug.cgi?id=193182
459         <rdar://problem/47452154>
460
461         Reviewed by Tim Horton.
462
463         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
464         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
465         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
466
467         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
468         preventing later tests from recognizing gestures.
469
470         * WebKitTestRunner/ios/TestControllerIOS.mm:
471         (WTR::TestController::platformResetStateToConsistentValues):
472
473         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
474
475 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
476
477         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
478         https://bugs.webkit.org/show_bug.cgi?id=193722
479         <rdar://problem/47481475>
480
481         Reviewed by Lucas Forschler.
482
483         iPhone and iPad ports should both use the iOS config.
484
485         * Scripts/webkitpy/port/ios_simulator.py:
486         (IPhoneSimulatorPort.__init__):
487         (IPadSimulatorPort.__init__):
488
489 2019-01-23  Rob Buis  <rbuis@igalia.com>
490
491         Update MIME type parser
492         https://bugs.webkit.org/show_bug.cgi?id=180526
493
494         Reviewed by Frédéric Wang.
495
496         Add unit tests for both parse modes of ParsedContentType.
497
498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
499         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
500         (TestWebKitAPI::TEST):
501
502 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
503
504         [ews-app] fetch loop should not stop on network issues
505         https://bugs.webkit.org/show_bug.cgi?id=193666
506
507         Reviewed by Lucas Forschler.
508
509         * BuildSlaveSupport/ews-app/ews/fetcher.py:
510         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
511
512 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
513
514         [iOS] Multiple WKWebViewAutofillTests are flaky failures
515         https://bugs.webkit.org/show_bug.cgi?id=189165
516         <rdar://problem/47433765>
517
518         Reviewed by Tim Horton.
519
520         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
521         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
522         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
523         process in sufficient to ensure that any previous action that blurred the focused element in the web process
524         would make its way to the UI process by the time the layer tree commit is finished.
525
526         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
527         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
528         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
529         will fail because it asks for -_autofillContext too early.
530
531         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
532         is handled in the UI process.
533
534         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
535
536         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
537         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
538         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
539         input session.
540
541         (-[AutofillTestView textInputHasAutofillContext]):
542
543         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
544
545         * TestWebKitAPI/cocoa/TestWKWebView.h:
546         * TestWebKitAPI/cocoa/TestWKWebView.mm:
547         (nextInputSessionChangeCount):
548
549         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
550         This includes changing the focused element from one to another.
551
552         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
553         (-[TestWKWebView didStartFormControlInteraction]):
554         (-[TestWKWebView didEndFormControlInteraction]):
555         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
556
557         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
558         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
559         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
560         that doesn't require an input session to one that doesn't.
561
562 2019-01-22  David Kilzer  <ddkilzer@apple.com>
563
564         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
565         <https://webkit.org/b/193676>
566
567         Reviewed by Alexey Proskuryakov.
568
569         * Scripts/webkitpy/style/checkers/cpp.py:
570         (check_member_initialization_list):
571         - Don't report missing whitespace around colon if the colon at
572           the start of the line is formatted correctly.
573         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
574         (WebKitStyleTest.test_member_initialization_list):
575         - Add a test for a missing permutation of existing tests.
576         - Add a test this false-positive.
577         - Add blank lines between subtests to make them easier to read.
578
579 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
580
581         [build.webkit.org] Unit-test failure after r237113
582         https://bugs.webkit.org/show_bug.cgi?id=193669
583
584         Reviewed by Michael Catanzaro.
585
586         * BuildSlaveSupport/build.webkit.org-config/factories.py:
587         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
588         multiple or zero flags.
589
590 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
591
592         Cache bytecode to disk
593         https://bugs.webkit.org/show_bug.cgi?id=192782
594         <rdar://problem/46084932>
595
596         Reviewed by Keith Miller.
597
598         Add test helper to execute bytecode-cache tests: it executes each test
599         twice, the first with JSC_diskCachePath set to a temporary directory
600         and second with JSC_forceDiskCache=true (in addition to the cache path)
601         to guarantee that only the disk cache is being used and no new
602         UnlinkedCodeBlocks are being created.
603
604         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
605         * Scripts/run-jsc-stress-tests:
606
607 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
608
609         [css-logical] Implement flow-relative margin, padding and border shorthands
610         https://bugs.webkit.org/show_bug.cgi?id=188697
611
612         Reviewed by Simon Fraser and Antti Koivisto.
613
614         * DumpRenderTree/TestOptions.cpp:
615         (TestOptions::TestOptions):
616         * DumpRenderTree/TestOptions.h:
617         * DumpRenderTree/mac/DumpRenderTree.mm:
618         (setWebPreferencesForTestOptions):
619         Allow tests to enable the CSSLogicalEnabled flag in WK1.
620
621         * Scripts/webkitpy/style/checkers/jsonchecker.py:
622         (JSONCSSPropertiesChecker.check_codegen_properties):
623         Allow CSS property definitions to have a 'runtime-flag' parameter which
624         disables the property when the specified runtime flag is disabled.
625
626 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
627
628         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
629         https://bugs.webkit.org/show_bug.cgi?id=193643
630
631         Reviewed by Michael Catanzaro.
632
633         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
634         * wpe/jhbuild.modules: Ditto.
635
636 2019-01-21  Zalan Bujtas  <zalan@apple.com>
637
638         [LFC][Floats] Take float top position into account when computing containing block height.
639         https://bugs.webkit.org/show_bug.cgi?id=193655
640
641         Reviewed by Antti Koivisto.
642
643         * LayoutReloaded/misc/LFC-passing-tests.txt:
644
645 2019-01-21  David Kilzer  <ddkilzer@apple.com>
646
647         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
648         <https://webkit.org/b/193645>
649         <rdar://problem/47421574>
650
651         Reviewed by Alex Christensen.
652
653         - Now checks for local soft-linking of all frameworks that have
654           their own *SoftLinking.{cpp,h,mm} files.
655         - Changes softlink/uikit warning to softlink/framework.
656
657         * Scripts/webkitpy/style/checkers/cpp.py:
658         (check_language):
659         (CppChecker):
660         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
661         (CppStyleTest):
662
663 2019-01-20  Saam Barati  <sbarati@apple.com>
664
665         Rollout r240210: It broke tests on iOS
666         https://bugs.webkit.org/show_bug.cgi?id=193640
667
668         Unreviewed.
669
670         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
671         * Scripts/run-jsc-stress-tests:
672
673 2019-01-20  chris fleizach  <cfleizach@apple.com>
674
675         AX: Support returning relative frames for accessibility
676         https://bugs.webkit.org/show_bug.cgi?id=193414
677         <rdar://problem/47268501>
678
679         Reviewed by Zalan Bujtas.
680
681         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
682         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
683         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
684         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
685         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
686         (WTR::attributesOfElement):
687         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
688
689 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
690
691         Unreviewed, add my new email address
692
693         * Scripts/webkitpy/common/config/contributors.json:
694
695 2019-01-19  Zalan Bujtas  <zalan@apple.com>
696
697         [LFC][BFC] <body>'s overflow property value is propagated to viewport
698         https://bugs.webkit.org/show_bug.cgi?id=193617
699
700         Reviewed by Antti Koivisto.
701
702         * LayoutReloaded/misc/LFC-passing-tests.txt:
703
704 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
705
706         Unreviewed, rolling out r240209.
707
708         Broke GTK/WPE injected bundle
709
710         Reverted changeset:
711
712         "AX: Support returning relative frames for accessibility"
713         https://bugs.webkit.org/show_bug.cgi?id=193414
714         https://trac.webkit.org/changeset/240209
715
716 2019-01-12  Dan Bernstein  <mitz@apple.com>
717
718         [Cocoa] Avoid importing directly from subumbrella frameworks
719         https://bugs.webkit.org/show_bug.cgi?id=186016
720         <rdar://problem/40591038>
721
722         Reviewed by Sam Weinig.
723
724         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
725           LaunchServices header.
726         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
727           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
728         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
729           when using SDKs earlier than 10.13.
730         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
731           and OTHER_CPLUSPLUSFLAGS.
732         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
733           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
734         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
735           LaunchServices header.
736
737 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
738
739         Cache bytecode to disk
740         https://bugs.webkit.org/show_bug.cgi?id=192782
741         <rdar://problem/46084932>
742
743         Reviewed by Keith Miller.
744
745         Add test helper to execute bytecode-cache tests: it executes each test
746         twice, the first with JSC_diskCachePath set to a temporary directory
747         and second with JSC_forceDiskCache=true (in addition to the cache path)
748         to guarantee that only the disk cache is being used and no new
749         UnlinkedCodeBlocks are being created.
750
751         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
752         * Scripts/run-jsc-stress-tests:
753
754 2019-01-20  chris fleizach  <cfleizach@apple.com>
755
756         AX: Support returning relative frames for accessibility
757         https://bugs.webkit.org/show_bug.cgi?id=193414
758         <rdar://problem/47268501>
759
760         Reviewed by Zalan Bujtas.
761
762         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
763         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
764         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
765         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
766         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
767         (WTR::attributesOfElement):
768         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
769
770 2019-01-20  Antoine Quint  <graouts@apple.com>
771
772         Add a POINTER_EVENTS feature flag
773         https://bugs.webkit.org/show_bug.cgi?id=193577
774         <rdar://problem/47408511>
775
776         Unreviewed. Also enable Pointer Events for iosmac.
777
778         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
779
780 2019-01-19  Zalan Bujtas  <zalan@apple.com>
781
782         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
783         https://bugs.webkit.org/show_bug.cgi?id=193613
784
785         Reviewed by Antti Koivisto.
786
787         * LayoutReloaded/misc/LFC-passing-tests.txt:
788
789 2019-01-19  Antoine Quint  <graouts@apple.com>
790
791         Add a POINTER_EVENTS feature flag
792         https://bugs.webkit.org/show_bug.cgi?id=193577
793
794         Reviewed by Dean Jackson.
795
796         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
797
798 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
799
800         Disable the run-jsc-stress-test remote host key check [second round].
801         https://bugs.webkit.org/show_bug.cgi?id=192988
802
803         Reviewed by Dewei Zhu.
804
805         * Scripts/run-jsc-stress-tests:
806
807 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
808
809         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
810         https://bugs.webkit.org/show_bug.cgi?id=193597
811
812         Reviewed by Lucas Forschler.
813
814         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
815
816 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
817
818         [build.webkit.org] api tests failures are incorrectly named as unit test failures
819         https://bugs.webkit.org/show_bug.cgi?id=193595
820
821         Reviewed by Lucas Forschler.
822
823         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
824         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
825         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
826
827 2019-01-18  Chris Dumez  <cdumez@apple.com>
828
829         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
830         https://bugs.webkit.org/show_bug.cgi?id=193588
831         <rdar://problem/47131566>
832
833         Reviewed by Alex Christensen.
834
835         Add layout test coverage.
836
837         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
838
839 2019-01-18  Jer Noble  <jer.noble@apple.com>
840
841         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
842         https://bugs.webkit.org/show_bug.cgi?id=189553
843
844         Reviewed by Tim Horton.
845
846         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
847
848         * ContentExtensionTester/Configurations/Base.xcconfig:
849         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
850         * DumpRenderTree/mac/Configurations/Base.xcconfig:
851         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
852         * ImageDiff/cg/Configurations/Base.xcconfig:
853         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
854         * MiniBrowser/Configurations/Base.xcconfig:
855         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
856         * MobileMiniBrowser/Configurations/Base.xcconfig:
857         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
858         * Scripts/webkitpy/style/checker.py:
859         (_all_categories):
860         (FileType):
861         (CheckerDispatcher._file_type):
862         (CheckerDispatcher._create_checker):
863         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
864         (SDKVariantChecker):
865         (SDKVariantChecker.__init__):
866         (SDKVariantChecker.check):
867         * TestWebKitAPI/Configurations/Base.xcconfig:
868         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
869         * WebEditingTester/Configurations/Base.xcconfig:
870         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
871         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
872         * WebKitTestRunner/Configurations/Base.xcconfig:
873         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
874         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
875         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
876
877 2019-01-18  David Kilzer  <ddkilzer@apple.com>
878
879         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
880         <https://webkit.org/b/193568>
881         <rdar://problem/47381130>
882
883         Reviewed by Alex Christensen.
884
885         Make sure no one re-introduces UIKit soft-linking by adding a
886         style rule.
887
888         * Scripts/webkitpy/style/checkers/cpp.py:
889         (check_language): Add softlink/uikit check.
890         (CppChecker): Enable softlink/uikit check.
891         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
892         (CppStyleTest): Add test for softlink/uikit.
893
894 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
895
896         [GTK] install-dependencies tool looks for libunistring-dev for dnf
897         https://bugs.webkit.org/show_bug.cgi?id=193584
898
899         Change "-dev" to "-devel".
900
901         Reviewed by Michael Catanzaro.
902
903         * gtk/install-dependencies:
904
905 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
906
907         webkitpy: Add iPhone and iPad ports
908         https://bugs.webkit.org/show_bug.cgi?id=193537
909         <rdar://problem/47353390>
910
911         Reviewed by Lucas Forschler.
912
913         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
914         ports. Note that this separation is optional, the --ios-simulator command remains.
915
916         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
917         (RunTest.test_device_type_test_division): Drive-by fix.
918         (RunTest.test_device_type_specific_listing): Ditto.
919         (RunTest.test_ipad_test_division):
920         (RunTest):
921         (RunTest.test_ipad_listing):
922         * Scripts/webkitpy/port/factory.py:
923         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
924         (PortFactory):
925         * Scripts/webkitpy/port/ios_simulator.py:
926         (IPhoneSimulatorPort):
927         (IPadSimulatorPort):
928
929 2019-01-18  Chris Dumez  <cdumez@apple.com>
930
931         Regression(PSON) Scroll position is not always restored properly when navigating back
932         https://bugs.webkit.org/show_bug.cgi?id=193578
933         <rdar://problem/47386331>
934
935         Reviewed by Tim Horton.
936
937         Add API test coverage.
938
939         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
940
941 2019-01-18  Youenn Fablet  <youenn@apple.com>
942
943         Add a new SPI to request for cache storage quota increase
944         https://bugs.webkit.org/show_bug.cgi?id=193323
945
946         Reviewed by Alex Christensen.
947
948         Implement WebsiteDataStore quota delegate to handle quota requests.
949         By default, do not update quota.
950         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
951
952         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
953         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
954         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
955         * WebKitTestRunner/InjectedBundle/TestRunner.h:
956         * WebKitTestRunner/TestController.cpp:
957         (WTR::TestController::allowCacheStorageQuotaIncrease):
958         * WebKitTestRunner/TestController.h:
959         * WebKitTestRunner/TestInvocation.cpp:
960         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
961         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
962         (-[CacheStorageQuotaManager init]):
963         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
964         (WTR::initializeWebViewConfiguration):
965         (WTR::TestController::cocoaResetStateToConsistentValues):
966         (WTR::TestController::allowCacheStorageQuotaIncrease):
967
968 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
969
970         [ews-build] Pass owner to the triggered builds
971         https://bugs.webkit.org/show_bug.cgi?id=193574
972
973         Reviewed by Lucas Forschler.
974
975         * BuildSlaveSupport/ews-build/factories.py:
976         (BuildFactory.propertiesToPassToTriggers):
977
978 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
979
980         [ews-app] Send patch author as a build property
981         https://bugs.webkit.org/show_bug.cgi?id=193560
982
983         Reviewed by Lucas Forschler.
984
985         * BuildSlaveSupport/ews-app/ews/fetcher.py:
986         (BugzillaPatchFetcher.fetch):
987
988 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
989
990         webkitpy: Implement device type specific expected results (Follow-up fix)
991         https://bugs.webkit.org/show_bug.cgi?id=192162
992         <rdar://problem/46345449>
993
994         Unreviewed infrastructure fix.
995
996         * Scripts/webkitpy/layout_tests/controllers/manager.py:
997         (Manager.run): Don't boot a device if no tests are available to run on it.
998
999 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1000
1001         webkitpy: Implement device type specific expected results (Follow-up fix)
1002         https://bugs.webkit.org/show_bug.cgi?id=192162
1003         <rdar://problem/46345449>
1004
1005         Unreviewed infrastructure fix.
1006
1007         * Scripts/webkitpy/api_tests/manager.py:
1008         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
1009
1010 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1011
1012         webkitpy: Implement device type specific expected results (Part 2)
1013         https://bugs.webkit.org/show_bug.cgi?id=192162
1014         <rdar://problem/46345449>
1015
1016         Rubber-stamped by Aakash Jain.
1017
1018         This change uses device_type to select a different set of TestExpectation files based on the type of device running
1019         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
1020         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
1021
1022         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1023         (LayoutTestFinder.find_tests): Pass device_type through.
1024         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
1025         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
1026         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1027         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
1028         (Manager._collect_tests): Pass device type to test finder.
1029         (Manager._needs_web_platform_test):
1030         (Manager._prepare_lists): Index _expectations by device type.
1031         (Manager._test_input_for_file):
1032         (Manager._test_is_slow): Ditto.
1033         (Manager._test_should_dump_jsconsolelog_in_stderr):
1034         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
1035         (Manager._get_test_inputs):
1036         (Manager._update_worker_count):
1037         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
1038         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
1039         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
1040         the one which runs the test.
1041         (Manager._run_test_subset):
1042         (Manager._run_tests): Index _expectations by current_device_type.
1043         (Manager._print_expectation_line_for_test): Ditto.
1044         (Manager._print_expectations_for_subset): Ditto.
1045         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
1046         Unlike run, this function will behave the same regardless of what devices are available.
1047         (Manager._custom_device_for_test): Deleted.
1048         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1049         (ManagerTest.test_uses_custom_device): Deleted.
1050         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
1051         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1052         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
1053         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
1054         all of the expectations.
1055         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1056         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
1057         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1058         (TestExpectations.__init__): Allow device_type to be passed through.
1059         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
1060         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
1061         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1062         (summarize_results):
1063         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1064         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
1065         a test ran with, one must check all expectations to find the first non-skip expectation.
1066         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1067         (RunTest.test_device_type_test_division):
1068         (RunTest):
1069         (RunTest.test_device_type_specific_listing):
1070         * Scripts/webkitpy/port/base.py:
1071         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
1072         (Port.supported_device_types): The result of this function will change based on what devices are available.
1073         * Scripts/webkitpy/port/device_port.py:
1074         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1075         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1076         can be used.
1077         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1078         any, or the DEFAULT_DEVICE_TYPES of the port.
1079         * Scripts/webkitpy/port/ios.py:
1080         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1081         * Scripts/webkitpy/port/ios_simulator.py:
1082         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1083         * Scripts/webkitpy/port/watch.py:
1084         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1085         * Scripts/webkitpy/port/watch_simulator.py:
1086         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1087         * Scripts/webkitpy/xcode/device_type.py:
1088         (DeviceType):
1089         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1090
1091 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1092
1093         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1094         https://bugs.webkit.org/show_bug.cgi?id=193575
1095
1096         Reviewed by Michael Catanzaro.
1097
1098         Allow the script to run without explicit port argument because
1099         it's specific to the WPE port anyway.
1100
1101         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1102         and simplify the rest of the code accordingly.
1103
1104 2019-01-18  Charlie Turner  <cturner@igalia.com>
1105
1106         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1107         https://bugs.webkit.org/show_bug.cgi?id=192229
1108
1109         Reviewed by Xabier Rodriguez-Calvar.
1110
1111         * MiniBrowser/wpe/main.cpp:
1112         (main): Enable encrypted-media by default.
1113
1114 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1115
1116         [Flatpak] Missing KeyboardInterrupt exception handler
1117         https://bugs.webkit.org/show_bug.cgi?id=193570
1118
1119         Reviewed by Michael Catanzaro.
1120
1121         * flatpak/flatpakutils.py:
1122         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1123
1124 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1125
1126         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1127         https://bugs.webkit.org/show_bug.cgi?id=193564
1128
1129         Reviewed by Antti Koivisto.
1130
1131         * LayoutReloaded/misc/LFC-passing-tests.txt:
1132
1133 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1134
1135         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1136         https://bugs.webkit.org/show_bug.cgi?id=193562
1137
1138         Reviewed by Antti Koivisto.
1139
1140         * LayoutReloaded/misc/LFC-passing-tests.txt:
1141
1142 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1143
1144         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1145         https://bugs.webkit.org/show_bug.cgi?id=193555
1146
1147         Reviewed by Antti Koivisto.
1148
1149         * LayoutReloaded/misc/LFC-passing-tests.txt:
1150
1151 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1152
1153         [WPE] Add Qt extension
1154         https://bugs.webkit.org/show_bug.cgi?id=191464
1155
1156         Reviewed by Carlos Garcia Campos.
1157
1158         MiniBrowser and API tests for the WPE Qt API. To run the
1159         MiniBrowser a new script is introduced. Example invocation:
1160
1161         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1162
1163         Also note-worthy is the introduction of the python2-subprocess32
1164         dependency to run the GLib API tests.
1165
1166         * MiniBrowser/wpe/CMakeLists.txt:
1167         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1168         * MiniBrowser/wpe/qt/main.cpp: Added.
1169         (main):
1170         * MiniBrowser/wpe/qt/main.qml: Added.
1171         * MiniBrowser/wpe/qt/qml.qrc: Added.
1172         * Scripts/run-gtk-tests:
1173         (GtkTestRunner.is_google_test):
1174         (GtkTestRunner):
1175         (GtkTestRunner.is_qt_test):
1176         * Scripts/run-qt-wpe-minibrowser: Added.
1177         * Scripts/run-wpe-tests:
1178         (WPETestRunner):
1179         (WPETestRunner.is_google_test):
1180         (WPETestRunner.is_qt_test):
1181         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1182         (TestLoad::main):
1183         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1184         (TestLoadHtml::main):
1185         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1186         (TestLoadRequest::main):
1187         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1188         (TestRunJavaScript::main):
1189         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1190         (waitForSignal):
1191         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1192         (LoadSpy::LoadSpy):
1193         (LoadSpy::~LoadSpy):
1194         (LoadSpy::onLoadingChanged):
1195         (LoadStartedCatcher::LoadStartedCatcher):
1196         (LoadStartedCatcher::~LoadStartedCatcher):
1197         (LoadStartedCatcher::onLoadingChanged):
1198         (waitForLoadSucceeded):
1199         (waitForLoadFailed):
1200         * TestWebKitAPI/glib/CMakeLists.txt:
1201         * flatpak/flatpakutils.py:
1202         (WebkitFlatpak.load_from_args):
1203         (WebkitFlatpak.__init__):
1204         (WebkitFlatpak.clean_args):
1205         (WebkitFlatpak.run_in_sandbox):
1206         * flatpak/org.webkit.CommonModules.yaml:
1207         * flatpak/org.webkit.WPE.yaml:
1208         * flatpak/org.webkit.WPEModules.yaml:
1209         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1210         * flatpak/org.webkit.WebKit.yaml:
1211         * glib/api_test_runner.py:
1212         (TestRunner._run_test_qt):
1213         (TestRunner.is_qt_test):
1214         (TestRunner._run_test):
1215
1216 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1217
1218         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1219         https://bugs.webkit.org/show_bug.cgi?id=193494
1220         <rdar://problem/46859627>
1221
1222         Reviewed by Simon Fraser and Tim Horton.
1223
1224         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1225         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1226
1227         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1228         (WTR::UIScriptController::contentOffsetX const):
1229         (WTR::UIScriptController::contentOffsetY const):
1230         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1231         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1232         (WTR::UIScriptController::contentOffsetX const):
1233         (WTR::UIScriptController::contentOffsetY const):
1234         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1235
1236         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1237
1238         * WebKitTestRunner/TestController.cpp:
1239         (WTR::updateTestOptionsFromTestHeader):
1240         * WebKitTestRunner/TestOptions.h:
1241         (WTR::TestOptions::hasSameInitializationOptions const):
1242         * WebKitTestRunner/ios/TestControllerIOS.mm:
1243         (WTR::TestController::platformResetStateToConsistentValues):
1244         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1245         (WTR::UIScriptController::contentOffsetX const):
1246         (WTR::UIScriptController::contentOffsetY const):
1247
1248 2019-01-17  Truitt Savell  <tsavell@apple.com>
1249
1250         Unreviewed, rolling out r240124.
1251
1252         This commit broke an internal build.
1253
1254         Reverted changeset:
1255
1256         "SDK_VARIANT build destinations should be separate from non-
1257         SDK_VARIANT builds"
1258         https://bugs.webkit.org/show_bug.cgi?id=189553
1259         https://trac.webkit.org/changeset/240124
1260
1261 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1262
1263         Fix string concatenation API test after r239920
1264         https://bugs.webkit.org/show_bug.cgi?id=193551
1265         <rdar://problem/47359304>
1266
1267         Reviewed by Youenn Fablet.
1268
1269         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1270         (TestWebKitAPI::TEST):
1271         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1272         in WebKit's build configuration like it apparently is on Linux.
1273
1274 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1275
1276         [ews-build] validate-patch should handle the case when bug_id is None
1277         https://bugs.webkit.org/show_bug.cgi?id=193547
1278
1279         Reviewed by Lucas Forschler.
1280
1281         * BuildSlaveSupport/ews-build/steps.py:
1282         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1283         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1284
1285 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1286
1287         [ews-build] Add patch author information in build
1288         https://bugs.webkit.org/show_bug.cgi?id=193465
1289
1290         Reviewed by Lucas Forschler.
1291
1292         * BuildSlaveSupport/ews-build/steps.py:
1293         (ValidatePatch._is_patch_obsolete):
1294
1295 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1296
1297         [ews-build] Pass bug_id to the triggered builds
1298         https://bugs.webkit.org/show_bug.cgi?id=193548
1299
1300         Reviewed by Lucas Forschler.
1301
1302         * BuildSlaveSupport/ews-build/factories.py:
1303         (BuildFactory.propertiesToPassToTriggers):
1304
1305 2019-01-17  Jer Noble  <jer.noble@apple.com>
1306
1307         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1308         https://bugs.webkit.org/show_bug.cgi?id=189553
1309
1310         Reviewed by Tim Horton.
1311
1312         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1313
1314         * ContentExtensionTester/Configurations/Base.xcconfig:
1315         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1316         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1317         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1318         * ImageDiff/cg/Configurations/Base.xcconfig:
1319         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1320         * MiniBrowser/Configurations/Base.xcconfig:
1321         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1322         * MobileMiniBrowser/Configurations/Base.xcconfig:
1323         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1324         * Scripts/webkitpy/style/checker.py:
1325         (_all_categories):
1326         (FileType):
1327         (CheckerDispatcher._file_type):
1328         (CheckerDispatcher._create_checker):
1329         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1330         (SDKVariantChecker):
1331         (SDKVariantChecker.__init__):
1332         (SDKVariantChecker.check):
1333         * TestWebKitAPI/Configurations/Base.xcconfig:
1334         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1335         * WebEditingTester/Configurations/Base.xcconfig:
1336         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1337         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1338         * WebKitTestRunner/Configurations/Base.xcconfig:
1339         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1340         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1341         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1342
1343 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1344
1345         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1346         https://bugs.webkit.org/show_bug.cgi?id=193534
1347
1348         Reviewed by Antti Koivisto.
1349
1350         * LayoutReloaded/misc/LFC-passing-tests.txt:
1351
1352 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1353
1354         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1355         https://bugs.webkit.org/show_bug.cgi?id=193528
1356
1357         Reviewed by Antti Koivisto.
1358
1359         * LayoutReloaded/misc/LFC-passing-tests.txt:
1360
1361 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1362
1363         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1364         https://bugs.webkit.org/show_bug.cgi?id=193520
1365
1366         Reviewed by Antti Koivisto.
1367
1368         * LayoutReloaded/misc/LFC-passing-tests.txt:
1369
1370 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1371
1372         [ews-build] unapply-patch step should not update source
1373         https://bugs.webkit.org/show_bug.cgi?id=193234
1374
1375         Reviewed by Lucas Forschler.
1376
1377         * BuildSlaveSupport/ews-build/steps.py:
1378         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1379         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1380
1381 2019-01-16  Youenn Fablet  <youenn@apple.com>
1382
1383         Add a new SPI for controlling getUserMedia
1384         https://bugs.webkit.org/show_bug.cgi?id=192793
1385
1386         Reviewed by Eric Carlson.
1387
1388         * MiniBrowser/mac/WK2BrowserWindowController.m:
1389         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1390         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1391         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1392         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1393         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1394         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1395         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1396         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1397         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1398         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1399         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1400         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1401         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1402         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1403
1404 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1405
1406         [LFC][BFC] Inflow non-replaced used width should not be negative.
1407         https://bugs.webkit.org/show_bug.cgi?id=193495
1408
1409         Reviewed by Antti Koivisto.
1410
1411         * LayoutReloaded/misc/LFC-passing-tests.txt:
1412
1413 2019-01-16  Chris Dumez  <cdumez@apple.com>
1414
1415         Regression(PSON) View becomes blank after click a cross-site download link
1416         https://bugs.webkit.org/show_bug.cgi?id=193361
1417         <rdar://problem/47099573>
1418
1419         Reviewed by Geoffrey Garen.
1420
1421         Add API test coverage.
1422
1423         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1424         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1425
1426 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1427
1428         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1429         https://bugs.webkit.org/show_bug.cgi?id=193470
1430
1431         Reviewed by Antti Koivisto.
1432
1433         * LayoutReloaded/misc/LFC-passing-tests.txt:
1434
1435 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1436
1437         [LFC] Adjust margin box verification.
1438         https://bugs.webkit.org/show_bug.cgi?id=193482
1439
1440         Reviewed by Antti Koivisto.
1441
1442         * LayoutReloaded/misc/LFC-passing-tests.txt:
1443
1444 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1445
1446         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1447         https://bugs.webkit.org/show_bug.cgi?id=193451
1448
1449         Reviewed by Geoffrey Garen.
1450
1451         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1452         (TEST):
1453         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1454         (runWebsiteDataStoreCustomPaths):
1455
1456 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1457
1458         webkitpy: Support boolean simctl isAvailable
1459         https://bugs.webkit.org/show_bug.cgi?id=193472
1460         <rdar://problem/47296150>
1461
1462         Reviewed by Ryosuke Niwa.
1463
1464         * Scripts/webkitpy/xcode/simulated_device.py:
1465         (SimulatedDeviceManager._create_runtimes):
1466         (SimulatedDeviceManager._create_device_with_runtime):
1467
1468 2019-01-15  Chris Dumez  <cdumez@apple.com>
1469
1470         Unreviewed, rolling out r239993, r239995, r239997, and
1471         r239999.
1472
1473         Caused assertions under
1474         ViewGestureController::disconnectFromProcess()
1475
1476         Reverted changesets:
1477
1478         "Regression(PSON) View becomes blank after click a cross-site
1479         download link"
1480         https://bugs.webkit.org/show_bug.cgi?id=193361
1481         https://trac.webkit.org/changeset/239993
1482
1483         "Unreviewed iOS build fix after r239993."
1484         https://trac.webkit.org/changeset/239995
1485
1486         "Fix iOS build after r239993"
1487         https://bugs.webkit.org/show_bug.cgi?id=193361
1488         https://trac.webkit.org/changeset/239997
1489
1490         "Unreviewed, revert part of r239997 as it is not needed to fix
1491         the build."
1492         https://trac.webkit.org/changeset/239999
1493
1494 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1495
1496         Cannot tab out of WKWebView on macOS
1497         https://bugs.webkit.org/show_bug.cgi?id=161448
1498         <rdar://problem/28100085>
1499
1500         Reviewed by Dean Jackson.
1501
1502         Add a test that tabbing into and out of WKWebView works correctly.
1503
1504         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1505         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1506         (WebKit2_CommandBackForwardTest::SetUp):
1507         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1508         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1509         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1510         (-[FocusableView canBecomeKeyView]):
1511         (TEST):
1512         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1513         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1514         (-[OffscreenWindow initWithSize:]):
1515         (-[OffscreenWindow isKeyWindow]):
1516         (-[OffscreenWindow isVisible]):
1517         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1518         (TestWebKitAPI::PlatformWebView::initialize):
1519         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1520         (-[ActiveOffscreenWindow isVisible]): Deleted.
1521         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1522
1523 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1524
1525         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1526         https://bugs.webkit.org/show_bug.cgi?id=193459
1527
1528         Reviewed by Mark Lam.
1529
1530         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1531         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1532
1533 2019-01-15  Chris Dumez  <cdumez@apple.com>
1534
1535         Regression(PSON) View becomes blank after click a cross-site download link
1536         https://bugs.webkit.org/show_bug.cgi?id=193361
1537         <rdar://problem/47099573>
1538
1539         Reviewed by Geoff Garen.
1540
1541         Add API test coverage.
1542
1543         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1544         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1545
1546 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1547
1548         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
1549         https://bugs.webkit.org/show_bug.cgi?id=193448
1550
1551         Reviewed by Antti Koivisto.
1552
1553         * LayoutReloaded/misc/LFC-passing-tests.txt:
1554
1555 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1556
1557         webkitpy: Implement device type specific expected results (Part 1)
1558         https://bugs.webkit.org/show_bug.cgi?id=192162
1559
1560         Reviewed by Lucas Forschler.
1561
1562         Device type specific expected results covers two related ideas. The first (covered by this change)
1563         is where to search for -expected.* files. The second is which tests to run based on the
1564         TestExpectations.txt file.
1565
1566         After this change, the baseline search path will be determined by the type of device running a
1567         test. Device type will be passed into any function which picks a file based on the baseline search
1568         path.
1569
1570         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1571         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
1572         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1573         (Manager.run): Print baseline search path for each round of devices.
1574         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1575         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
1576         (SingleTestRunner._expected_driver_output): Ditto.
1577         (SingleTestRunner._driver_input): Ditto.
1578         * Scripts/webkitpy/layout_tests/views/printing.py:
1579         (Printer.print_config): Move printing of baseline search path to a separate function.
1580         (Printer.print_baseline_search_path): Moved from Printer.print_config.
1581         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1582         (Testprinter.test_print_config):
1583         (Testprinter.test_print_baseline_search_path):
1584         * Scripts/webkitpy/port/base.py:
1585         (Port.baseline_search_path): Pass device_type through.
1586         (Port._expected_baselines_for_suffixes): Ditto.
1587         (Port.expected_baselines): Ditto.
1588         (Port.expected_filename): Ditto.
1589         (Port.expected_checksum): Ditto.
1590         (Port.expected_image): Ditto.
1591         (Port.expected_audio): Ditto.
1592         (Port.expected_text): Ditto.
1593         (Port.reference_files): Ditto.
1594         (Port.tests): Ditto.
1595         (Port._expanded_paths): Ditto.
1596         (Port.skipped_layout_tests): Ditto.
1597         (Port.expectations_dict): Ditto.
1598         (Port._port_specific_expectations_files): Ditto.
1599         (Port.expectations_files): Ditto.
1600         (Port.test_search_path): Ditto.
1601         (Port._tests_for_other_platforms): Ditto.
1602         * Scripts/webkitpy/port/base_unittest.py:
1603         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
1604         (PortTest.test_nonexistant_expectations): Ditto.
1605         (test_ref_tests_platform_directory): Ditto.
1606         * Scripts/webkitpy/port/darwin.py:
1607         (DarwinPort._port_specific_expectations_files): Accept device_type.
1608         * Scripts/webkitpy/port/driver.py:
1609         (DriverProxy):
1610         (DriverProxy.host): Expose _target_host for device_type information.
1611         * Scripts/webkitpy/port/gtk.py:
1612         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
1613         * Scripts/webkitpy/port/ios.py:
1614         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1615         * Scripts/webkitpy/port/mac.py:
1616         (MacPort. default_baseline_search_path): Ditto.
1617         * Scripts/webkitpy/port/port_testcase.py:
1618         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
1619         * Scripts/webkitpy/port/test.py:
1620         * Scripts/webkitpy/port/watch.py:
1621         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1622         * Scripts/webkitpy/port/win.py:
1623         (WinPort.test_search_path): Accept, but do not use, device_type.
1624         * Scripts/webkitpy/port/wpe.py:
1625         (WPEPort._port_specific_expectations_files): Ditto.
1626         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1627         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
1628
1629 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1630
1631         [LFC] Use the containing block's padding box to position out-of-flow elements.
1632         https://bugs.webkit.org/show_bug.cgi?id=193431
1633
1634         Reviewed by Antti Koivisto.
1635
1636         * LayoutReloaded/misc/LFC-passing-tests.txt:
1637
1638 2019-01-14  Tim Horton  <timothy_horton@apple.com>
1639
1640         Move a test implementation file that got misplaced in the Xcode project
1641
1642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1643
1644 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1645
1646         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1647         r239913, and r239914.
1648         https://bugs.webkit.org/show_bug.cgi?id=193407
1649
1650         These revisions caused an internal failure (Requested by
1651         Truitt on #webkit).
1652
1653         Reverted changesets:
1654
1655         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1656         https://bugs.webkit.org/show_bug.cgi?id=186016
1657         https://trac.webkit.org/changeset/239901
1658
1659         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1660         https://trac.webkit.org/changeset/239909
1661
1662         "Tried to fix the build."
1663         https://trac.webkit.org/changeset/239910
1664
1665         "Fixed iOS builds after r239910."
1666         https://trac.webkit.org/changeset/239912
1667
1668         "More build fixing."
1669         https://trac.webkit.org/changeset/239913
1670
1671         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1672         https://trac.webkit.org/changeset/239914
1673
1674 2019-01-14  Mark Lam  <mark.lam@apple.com>
1675
1676         Re-enable ability to build --cloop builds.
1677         https://bugs.webkit.org/show_bug.cgi?id=192955
1678         <rdar://problem/46882363>
1679
1680         Reviewed by Saam barati and Keith Miller.
1681
1682         The --cloop build option was being ignored this whole time since r236381.
1683         This patch makes it possible to build CLoop builds again.
1684
1685         * Scripts/build-jsc:
1686         * Scripts/webkitperl/FeatureList.pm:
1687         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1688
1689 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1690
1691         webkitpy: Expose device_type from host-like objects
1692         https://bugs.webkit.org/show_bug.cgi?id=193406
1693         <rdar://problem/47262305>
1694
1695         Reviewed by Lucas Forschler.
1696
1697         Devices should expose device_type. As a result, all host objects should
1698         provide a device_type property, even if they do not yet define a device_type.
1699
1700         * Scripts/webkitpy/common/system/systemhost.py:
1701         (SystemHost):
1702         (SystemHost.device_type):
1703         * Scripts/webkitpy/common/system/systemhost_mock.py:
1704         (MockSystemHost):
1705         (MockSystemHost.device_type):
1706         * Scripts/webkitpy/port/device.py:
1707         (Device):
1708         (Device.device_type):
1709         * Scripts/webkitpy/xcode/simulated_device.py:
1710         (SimulatedDeviceManager._find_exisiting_device_for_request):
1711         (SimulatedDeviceManager._disambiguate_device_type):
1712         (SimulatedDeviceManager._does_fulfill_request):
1713         (SimulatedDeviceManager.device_count_for_type):
1714         (SimulatedDeviceManager.initialize_devices):
1715         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1716         (test_available_devices):
1717         (test_swapping_devices):
1718
1719 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1720
1721         webkitpy: Support alternate simctl device list output (Follow-up fix)
1722         https://bugs.webkit.org/show_bug.cgi?id=193362
1723         <rdar://problem/47122965>
1724
1725         Rubber-stamped by Lucas Forschler.
1726
1727         * Scripts/webkitpy/xcode/simulated_device.py:
1728         (SimulatedDeviceManager.populate_available_devices):
1729
1730 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1731
1732         [iOS] Expose SPI to access the current sentence boundary and selection state
1733         https://bugs.webkit.org/show_bug.cgi?id=193398
1734         <rdar://problem/45893108>
1735
1736         Reviewed by Dean Jackson.
1737
1738         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
1739         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
1740         expected.
1741
1742         * TestWebKitAPI/EditingTestHarness.h:
1743         * TestWebKitAPI/EditingTestHarness.mm:
1744         (-[EditingTestHarness moveBackward]):
1745         (-[EditingTestHarness moveForward]):
1746         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
1747
1748         Add a couple of new helper methods on EditingTestHarness.
1749
1750         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1751         (-[SelectionChangeObserver initWithWebView:]):
1752         (-[SelectionChangeObserver webView]):
1753         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
1754         (-[SelectionChangeObserver currentSelectionAttributes]):
1755
1756 2019-01-14  Zalan Bujtas  <zalan@apple.com>
1757
1758         [LFC][BFC] Add basic box-sizing support.
1759         https://bugs.webkit.org/show_bug.cgi?id=193392
1760
1761         Reviewed by Antti Koivisto.
1762
1763         * LayoutReloaded/misc/LFC-passing-tests.txt:
1764
1765 2019-01-14  Charlie Turner  <cturner@igalia.com>
1766
1767         [WPE] API test gardening
1768         https://bugs.webkit.org/show_bug.cgi?id=193319
1769
1770         Reviewed by Michael Catanzaro.
1771
1772         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
1773         passing tests.
1774
1775 2019-01-14  Charlie Turner  <cturner@igalia.com>
1776
1777         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
1778         https://bugs.webkit.org/show_bug.cgi?id=192977
1779
1780         Reviewed by Carlos Garcia Campos.
1781
1782         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
1783         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1784         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
1785         (TestWebKitAPI::GStreamerTest::SetUp):
1786         (TestWebKitAPI::GStreamerTest::TearDown):
1787         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
1788         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
1789         (TestWebKitAPI::TEST_F):
1790
1791 2019-01-14  Charlie Turner  <cturner@igalia.com>
1792
1793         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
1794         https://bugs.webkit.org/show_bug.cgi?id=193332
1795
1796         Reviewed by Michael Catanzaro.
1797
1798         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
1799         defined as a char16_t, which changed in ICU 59, the
1800         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
1801         unsigned short. This test is relying on the behaviour that
1802         UChar=unsigned short, which doesn't hold across platforms and ICU
1803         library versions. The full fix would be a special syntax for
1804         literal characters so that these ambiguities do not arise. That
1805         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
1806         (TestWebKitAPI::TEST):
1807
1808 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1809
1810         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
1811
1812         * Scripts/make-dist:
1813         (Distcheck.configure):
1814
1815 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
1816
1817         [ews-build] Update macOS queue configurations
1818         https://bugs.webkit.org/show_bug.cgi?id=193365
1819         <rdar://problem/47221073>
1820
1821         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
1822
1823         * BuildSlaveSupport/ews-build/config.json:
1824
1825 2019-01-13  Zalan Bujtas  <zalan@apple.com>
1826
1827         [LFC] Adjust assert for statically positioned fixed elements
1828         https://bugs.webkit.org/show_bug.cgi?id=193385
1829
1830         Reviewed by Antti Koivisto.
1831
1832         * LayoutReloaded/misc/LFC-passing-tests.txt:
1833
1834 2019-01-13  Philippe Normand  <pnormand@igalia.com>
1835
1836         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
1837         https://bugs.webkit.org/show_bug.cgi?id=193387
1838
1839         Reviewed by Carlos Garcia Campos.
1840
1841         * MiniBrowser/wpe/main.cpp:
1842         (main):
1843
1844 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1845
1846         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1847         https://bugs.webkit.org/show_bug.cgi?id=191655
1848         rdar://problem/46074680
1849
1850         Reviewed by Megan Gardner.
1851
1852         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1853         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1854
1855 2019-01-12  Dan Bernstein  <mitz@apple.com>
1856
1857         [Cocoa] Avoid importing directly from subumbrella frameworks
1858         https://bugs.webkit.org/show_bug.cgi?id=186016
1859         <rdar://problem/40591038>
1860
1861         Reviewed by Sam Weinig.
1862
1863         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1864           LaunchServices header.
1865         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1866           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1867         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1868           when using SDKs earlier than 10.13.
1869         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1870           and OTHER_CPLUSPLUSFLAGS.
1871         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1872           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1873         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1874           LaunchServices header.
1875
1876 2019-01-11  John Wilander  <wilander@apple.com>
1877
1878         Compile out Web API Statistics Collection
1879         https://bugs.webkit.org/show_bug.cgi?id=193370
1880         <rdar://problem/45388584>
1881
1882         Reviewed by Brent Fulgham.
1883
1884         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1885             Defined ENABLE_WEB_API_STATISTICS, off by default.
1886
1887 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1888
1889         [WPE] Add gtk-doc
1890         https://bugs.webkit.org/show_bug.cgi?id=178900
1891
1892         Reviewed by Michael Catanzaro.
1893
1894         Add Tools/gtkdoc to manifest.txt.in files.
1895         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
1896
1897         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
1898         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
1899
1900 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1901
1902         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
1903         https://bugs.webkit.org/show_bug.cgi?id=193364
1904         <rdar://problem/47214117>
1905
1906         Reviewed by Tim Horton.
1907
1908         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
1909         precise, whereas dragging near the middle of the textarea does.
1910
1911         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1912         (TestWebKitAPI::TEST):
1913
1914 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1915
1916         webkitpy: Support alternate simctl device list output
1917         https://bugs.webkit.org/show_bug.cgi?id=193362
1918         <rdar://problem/47122965>
1919
1920         Reviewed by Lucas Forschler.
1921
1922         * Scripts/webkitpy/xcode/simulated_device.py:
1923         (SimulatedDeviceManager.populate_available_devices):
1924
1925 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
1926
1927         [ews-build] Update macOS queue configurations
1928         https://bugs.webkit.org/show_bug.cgi?id=193365
1929
1930         Reviewed by Lucas Forschler.
1931
1932         * BuildSlaveSupport/ews-build/config.json:
1933
1934 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1935
1936         webkitpy: Incorporate device type into baseline search path
1937         https://bugs.webkit.org/show_bug.cgi?id=193356
1938         <rdar://problem/47215515>
1939
1940         Reviewed by Lucas Forschler.
1941
1942         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
1943
1944         * Scripts/webkitpy/port/base.py:
1945         (Port.default_baseline_search_path): Allow device type to be passed in.
1946         * Scripts/webkitpy/port/gtk.py:
1947         (GtkPort.default_baseline_search_path): Ignore device type.
1948         * Scripts/webkitpy/port/ios.py:
1949         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
1950         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
1951         * Scripts/webkitpy/port/ios_device_unittest.py:
1952         (IOSDeviceTest):
1953         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1954         (IOSSimulatorTest):
1955         * Scripts/webkitpy/port/mac.py:
1956         (MacPort.default_baseline_search_path): Ignore device type.
1957         * Scripts/webkitpy/port/watch.py:
1958         (WatchPort.default_baseline_search_path): Ditto.
1959         * Scripts/webkitpy/port/win.py:
1960         (WinPort.default_baseline_search_path): Ditto.
1961         (WinCairoPort.default_baseline_search_path): Ditto.
1962         * Scripts/webkitpy/port/wpe.py:
1963         (WPEPort.default_baseline_search_path): Ditto.
1964
1965 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1966
1967         webkitpy: Print abbreviated baseline search path that includes only folders that exist
1968         https://bugs.webkit.org/show_bug.cgi?id=193352
1969         <rdar://problem/47210736>
1970
1971         Reviewed by Lucas Forschler.
1972
1973         * Scripts/webkitpy/layout_tests/views/printing.py:
1974         (Printer.print_config): Print list on only baseline search paths which exist. 
1975         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1976         (Testprinter.test_print_config):
1977
1978 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
1979
1980         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
1981         https://bugs.webkit.org/show_bug.cgi?id=193340
1982
1983         Reviewed by David Kilzer.
1984
1985         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1986         (WTR::InjectedBundle::didReceiveMessageToPage):
1987         Pull the strings out into a WKRetainPtr.
1988
1989         * WebKitTestRunner/WebNotificationProvider.cpp:
1990         (WTR::WebNotificationProvider::closeWebNotification):
1991         Adopt the created value into the WKRetainPtr.
1992
1993         * WebKitTestRunner/mac/TestControllerMac.mm:
1994         (WTR::generateWhitelist):
1995         Immediately adopt a created value to avoid potential mistakes.
1996
1997 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
1998
1999         Enable DFG on ARM/Linux again
2000         https://bugs.webkit.org/show_bug.cgi?id=192496
2001
2002         Reviewed by Yusuke Suzuki.
2003
2004         After changing the bytecode format DFG was disabled on all 32-bit
2005         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2006         on ARM by default.
2007
2008         * Scripts/run-jsc-stress-tests:
2009
2010 2019-01-11  Timothy Hatcher  <timothy@apple.com>
2011
2012         Unreviewed, fix #ifdef in API test added in r239851.
2013         https://bugs.webkit.org/show_bug.cgi?id=193327
2014         rdar://problem/47093222
2015
2016         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
2017
2018 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2019
2020         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
2021         https://bugs.webkit.org/show_bug.cgi?id=193109
2022         <rdar://problem/44807048>
2023
2024         Reviewed by Ryosuke Niwa.
2025
2026         Introduce and respect a test option to enable the UndoManager API.
2027
2028         * WebKitTestRunner/TestController.cpp:
2029         (WTR::updateTestOptionsFromTestHeader):
2030         * WebKitTestRunner/TestOptions.h:
2031         (WTR::TestOptions::hasSameInitializationOptions const):
2032         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2033         (WTR::TestController::platformCreateWebView):
2034
2035 2019-01-11  Zalan Bujtas  <zalan@apple.com>
2036
2037         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
2038         https://bugs.webkit.org/show_bug.cgi?id=193346
2039
2040         Reviewed by Antti Koivisto.
2041
2042         * LayoutReloaded/misc/LFC-passing-tests.txt:
2043
2044 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2045
2046         Unreviewed, fix typo that breaks dashboard link.
2047
2048         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2049         (WebKitBuildbot):
2050
2051 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2052
2053         Update macOS queue configurations
2054         https://bugs.webkit.org/show_bug.cgi?id=193329
2055
2056         Reviewed by Alexey Proskuryakov.
2057
2058         * BuildSlaveSupport/build.webkit.org-config/config.json:
2059         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2060         (BubbleQueueServer):
2061         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2063         (WebKitBuildbot):
2064         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2065         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
2066         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2067
2068 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2069
2070         MiniBrowser should be able to navigate to about:blank
2071         https://bugs.webkit.org/show_bug.cgi?id=193345
2072
2073         Reviewed by Simon Fraser.
2074
2075         * MiniBrowser/mac/BrowserWindowController.m:
2076         (-[BrowserWindowController addProtocolIfNecessary:]):
2077         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2078
2079         * MiniBrowser/mac/WK1BrowserWindowController.m:
2080         (-[WK1BrowserWindowController fetch:]):
2081         * MiniBrowser/mac/WK2BrowserWindowController.m:
2082         (-[WK2BrowserWindowController fetch:]):
2083         Clean up the code that uses this to match style.
2084
2085 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2086
2087         Remove MiniBrowser custom "Process Swap" menu item which does not work
2088         https://bugs.webkit.org/show_bug.cgi?id=193344
2089
2090         Reviewed by Simon Fraser.
2091
2092         There is a menu item under the Experimental menu that does work.
2093
2094         * MiniBrowser/mac/AppDelegate.m:
2095         (defaultConfiguration):
2096         * MiniBrowser/mac/SettingsController.h:
2097         * MiniBrowser/mac/SettingsController.m:
2098         (-[SettingsController _populateMenu]):
2099         (-[SettingsController validateMenuItem:]):
2100         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2101         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2102
2103 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2104
2105         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2106         https://bugs.webkit.org/show_bug.cgi?id=193327
2107         rdar://problem/47093222
2108
2109         Reviewed by Tim Horton.
2110
2111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2112         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2113         (TestWebKitAPI::didFinishNavigation):
2114         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2115         (TestWebKitAPI::TEST):
2116         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2117         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2118         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2119         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2120         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2121
2122 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2123
2124         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2125         https://bugs.webkit.org/show_bug.cgi?id=193338
2126         <rdar://problem/46664774>
2127
2128         Reviewed by David Kilzer.
2129
2130         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2131         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2132
2133 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2134
2135         Unreviewed, rolling out r239825.
2136         https://bugs.webkit.org/show_bug.cgi?id=193330
2137
2138         Broke tests on armv7/linux bots (Requested by guijemont on
2139         #webkit).
2140
2141         Reverted changeset:
2142
2143         "Enable DFG on ARM/Linux again"
2144         https://bugs.webkit.org/show_bug.cgi?id=192496
2145         https://trac.webkit.org/changeset/239825
2146
2147 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2148
2149         Disable the run-jsc-stress-test remote host key check.
2150         https://bugs.webkit.org/show_bug.cgi?id=192988
2151
2152         Reviewed by Alexey Proskuryakov.
2153
2154         * Scripts/run-jsc-stress-tests:
2155
2156 2019-01-10  John Wilander  <wilander@apple.com>
2157
2158         Override the session configuration for cookieAcceptPolicy
2159         https://bugs.webkit.org/show_bug.cgi?id=190925
2160         <rdar://problem/45497382>
2161
2162         Reviewed by Alexey Proskuryakov and Alex Christensen.
2163
2164         Test infrastructure for setting a first-party-only cookie policy.
2165
2166         * DumpRenderTree/TestRunner.cpp:
2167         (setOnlyAcceptFirstPartyCookiesCallback):
2168         (TestRunner::staticFunctions):
2169         * DumpRenderTree/TestRunner.h:
2170         * DumpRenderTree/mac/TestRunnerMac.mm:
2171         (TestRunner::setOnlyAcceptFirstPartyCookies):
2172         * DumpRenderTree/win/TestRunnerWin.cpp:
2173         (TestRunner::setOnlyAcceptFirstPartyCookies):
2174         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2175         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2176         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2177         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2178         * WebKitTestRunner/TestInvocation.cpp:
2179         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2180
2181 2019-01-09  Matt Rajca  <mrajca@apple.com>
2182
2183         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2184         https://bugs.webkit.org/show_bug.cgi?id=193301
2185
2186         Reviewed by Jer Noble.
2187         
2188         Added API tests.
2189
2190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2191         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2192         (TEST):
2193         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2194
2195 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2196
2197         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2198         https://bugs.webkit.org/show_bug.cgi?id=193310
2199
2200         Reviewed by Antti Koivisto.
2201
2202         * LayoutReloaded/misc/LFC-passing-tests.txt:
2203
2204 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2205
2206         Enable DFG on ARM/Linux again
2207         https://bugs.webkit.org/show_bug.cgi?id=192496
2208
2209         Reviewed by Yusuke Suzuki.
2210
2211         After changing the bytecode format DFG was disabled on all 32-bit
2212         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2213         on ARM by default.
2214
2215         * Scripts/run-jsc-stress-tests:
2216
2217 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2218
2219         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2220         https://bugs.webkit.org/show_bug.cgi?id=193271
2221
2222         Reviewed by Brent Fulgham.
2223
2224         BSTR is a special data structure created by SysAllocString, not a
2225         wchar_t null-terminated string.
2226
2227         * DumpRenderTree/win/TestRunnerWin.cpp:
2228         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2229         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2230         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2231         BSTR from wide string literals.
2232
2233 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2234
2235         Tweak wording for build/version_check style checker error
2236         https://bugs.webkit.org/show_bug.cgi?id=193256
2237
2238         Reviewed by Tim Horton.
2239
2240         * Scripts/webkitpy/style/checkers/cpp.py:
2241         (check_os_version_checks):
2242         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2243         (WebKitStyleTest.test_os_version_checks):
2244
2245 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2246
2247         [ews-build] Add link to bug along with bug title
2248         https://bugs.webkit.org/show_bug.cgi?id=193293
2249
2250         Reviewed by Lucas Forschler.
2251
2252         * BuildSlaveSupport/ews-build/steps.py:
2253         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2254         (ConfigureBuild.add_bug_id_url): Deleted.
2255         (ConfigureBuild.getBugURL): Deleted.
2256
2257 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2258
2259         [ews-build] Use https for ews-build server
2260         https://bugs.webkit.org/show_bug.cgi?id=193193
2261
2262         Reviewed by Lucas Forschler.
2263
2264         * BuildSlaveSupport/ews-build/steps.py:
2265
2266 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2267
2268         [ews-build] Parse and display number of style failures
2269         https://bugs.webkit.org/show_bug.cgi?id=193280
2270
2271         Reviewed by Lucas Forschler.
2272
2273         * BuildSlaveSupport/ews-build/steps.py:
2274         (CheckStyle): Use TestWithFailureCount as base class.
2275         (CheckStyle.countFailures): Count the number of style failures.
2276
2277 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2278
2279         [ews-build] use patch_id instead of ewspatchid
2280         https://bugs.webkit.org/show_bug.cgi?id=193235
2281
2282         Reviewed by Lucas Forschler.
2283
2284         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2285         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2286         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2287
2288 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2289
2290         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2291         https://bugs.webkit.org/show_bug.cgi?id=192625
2292
2293         Reviewed by Antti Koivisto.
2294
2295         * LayoutReloaded/misc/LFC-passing-tests.txt:
2296
2297 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2298
2299         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2300         https://bugs.webkit.org/show_bug.cgi?id=192841
2301
2302         Reviewed by Carlos Garcia Campos.
2303
2304         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2305         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2306         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2307
2308         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2309
2310         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2311         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2312         (WebKitWebEditorTest::testSelectionChanged):
2313         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2314         (WebKitFrameTest::testMainFrame):
2315         (WebKitFrameTest::testURI):
2316         (WebKitFrameTest::testJavaScriptContext):
2317         (WebKitFrameTest::testJavaScriptValues):
2318         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2319         (testWebViewAuthenticationRequest):
2320         (testWebViewAuthenticationLoadCancelled):
2321         (testWebViewAuthenticationFailure):
2322         (testWebViewAuthenticationStorage):
2323         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2324         (testWebViewAuthenticationProxy):
2325         (testWebViewAuthenticationProxyHTTPS):
2326         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2327         (testAutomationSessionRequestSession):
2328         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2329         (testBackForwardListNavigation):
2330         (testWebKitWebViewSessionState):
2331         (testWebKitWebViewSessionStateWithFormData):
2332         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2333         (ConsoleMessageTest::consoleMessageReceivedCallback):
2334         (testWebKitConsoleMessageConsoleAPI):
2335         (testWebKitConsoleMessageJavaScriptException):
2336         (testWebKitConsoleMessageNetworkError):
2337         (testWebKitConsoleMessageSecurityError):
2338         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2339         (testCookieManagerAcceptPolicy):
2340         (testCookieManagerCookiesChanged):
2341         (testCookieManagerPersistentStorage):
2342         (testCookieManagerPersistentStorageDeleteAll):
2343         (testCookieManagerEphemeral):
2344         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2345         (testWebKitDOMElementAutoFill):
2346         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2347         (downloadLocalFileSuccessfully):
2348         (createFileAtDestination):
2349         (testDownloadOverwriteDestinationDisallowed):
2350         (testDownloadLocalFileError):
2351         (testDownloadRemoteFile):
2352         (testDownloadRemoteFileError):
2353         (testWebViewDownloadURI):
2354         (testPolicyResponseDownload):
2355         (testPolicyResponseDownloadCancel):
2356         (testDownloadMIMEType):
2357         (contextMenuCallback):
2358         (testContextMenuDownloadActions):
2359         (testBlobDownload):
2360         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2361         (testWebKitWebEditorSelectionChanged):
2362         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2363         (testWebKitFrameMainFrame):
2364         (testWebKitFrameURI):
2365         (testWebKitFrameJavaScriptContext):
2366         (testWebKitFrameJavaScriptValues):
2367         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2368         (LoadStopTrackingTest::loadFailed):
2369         (testWebViewTitle):
2370         (testURIRequestHTTPHeaders):
2371         (testURIRequestHTTPMethod):
2372         (testURIResponseHTTPHeaders):
2373         (testRedirectToDataURI):
2374         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2375         (testProcessPerWebView):
2376         (testWebProcessLimit):
2377         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2378         (testWebViewResources):
2379         (testWebResourceLoading):
2380         (testWebResourceSuggestedFilename):
2381         (testWebResourceGetData):
2382         (testWebResourceGetDataError):
2383         (testWebViewResourcesHistoryCache):
2384         (testWebResourceSendRequest):
2385         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2386         (testSSL):
2387         (testInsecureContent):
2388         (testTLSErrorsPolicy):
2389         (testTLSErrorsRedirect):
2390         (testTLSErrorsHTTPAuth):
2391         (testLoadFailedWithTLSErrors):
2392         (testSubresourceLoadFailedWithTLSErrors):
2393         (httpsServerCallback):
2394         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2395         (testWebViewCreateNavigationData):
2396         (testWebViewJavaScriptDialogs):
2397         (testWebViewWindowProperties):
2398         (testWebViewMouseTarget):
2399         (testWebViewFileChooserRequest):
2400         (testWebViewColorChooserRequest):
2401         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2402         (testWebExtensionGetTitle):
2403         (testDocumentLoadedSignal):
2404         (testWebKitWebViewProcessCrashed):
2405         (testWebExtensionWindowObjectCleared):
2406         (testWebExtensionIsolatedWorld):
2407         (permissionRequestCallback):
2408         (didAssociateFormControlsCallback):
2409         (testWebExtensionFormControlsAssociated):
2410         (FormSubmissionTest::FormSubmissionTest):
2411         (FormSubmissionTest::testFormSubmissionResult):
2412         (testWebExtensionFormSubmissionSteps):
2413         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2414         (testNotInitialized):
2415         (testClearDatabase):
2416         (testPrivateBrowsing):
2417         (testGetFavicon):
2418         (testWebViewFavicon):
2419         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2420         (testFindControllerTextFound):
2421         (testFindControllerTextNotFound):
2422         (testFindControllerMatchCount):
2423         (testFindControllerMaxMatchCount):
2424         (testFindControllerNext):
2425         (testFindControllerPrevious):
2426         (testFindControllerCountedMatches):
2427         (testFindControllerOptions):
2428         (testFindControllerHide):
2429         (testFindControllerInstance):
2430         (testFindControllerGetters):
2431         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2432         (testNavigationPolicy):
2433         (testResponsePolicy):
2434         (testNewWindowPolicy):
2435         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2436         (testSecurityOriginBasicConstructor):
2437         (testSecurityOriginURIConstructor):
2438         (testSecurityOriginDefaultPort):
2439         (testSecurityOriginFileURI):
2440         (testOpaqueSecurityOrigin):
2441         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2442         (testWebKitSettings):
2443         (testWebKitSettingsNewWithSettings):
2444         (testWebKitSettingsUserAgent):
2445         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2446         (testWebViewNewWithUserContentManager):
2447         (isStyleSheetInjectedForURLAtPath):
2448         (isScriptInjectedForURLAtPath):
2449         (testUserContentManagerInjectedStyleSheet):
2450         (testUserContentManagerInjectedScript):
2451         (UserScriptMessageTest::scriptMessageReceived):
2452         (UserScriptMessageTest::waitUntilMessageReceived):
2453         (UserScriptMessageTest::runJavaScriptFinished):
2454         (testUserContentManagerScriptMessageReceived):
2455         (testUserContentManagerScriptMessageInWorldReceived):
2456         (testUserContentManagerScriptMessageFromDOMBindings):
2457         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2458         (testWebContextDefault):
2459         (testWebContextEphemeral):
2460         (testWebContextGetPlugins):
2461         (testWebContextURIScheme):
2462         (testWebContextSpellChecker):
2463         (testWebContextLanguages):
2464         (consoleMessageReceivedCallback):
2465         (testWebContextSecurityFileXHR):
2466         (ProxyTest::ProxyTest):
2467         (testWebContextProxySettings):
2468         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2469         (testWebViewWebContext):
2470         (testWebViewWebBackend):
2471         (testWebViewEphemeral):
2472         (testWebViewCustomCharset):
2473         (testWebViewSettings):
2474         (testWebViewRunJavaScript):
2475         (testWebViewCanShowMIMEType):
2476         (testWebViewSubmitForm):
2477         (testWebViewSave):
2478         (testWebViewPageVisibility):
2479         (testWebViewSnapshot):
2480         (testWebViewNotification):
2481         (testWebViewNotificationInitialPermissionAllowed):
2482         (testWebViewNotificationInitialPermissionDisallowed):
2483         (testWebViewIsPlayingAudio):
2484         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2485         (WebsiteDataTest::WebsiteDataTest):
2486         (WebsiteDataTest::remove):
2487         (WebsiteDataTest::clear):
2488         (testWebsiteDataConfiguration):
2489         (testWebsiteDataEphemeral):
2490         (testWebsiteDataCache):
2491         (testWebsiteDataStorage):
2492         (testWebsiteDataDatabases):
2493         (testWebsiteDataAppcache):
2494         (testWebsiteDataCookies):
2495         (testWebsiteDataDeviceIdHashSalt):
2496         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2497         (emitDocumentLoaded):
2498         (emitURIChanged):
2499         (sendRequestCallback):
2500         (contextMenuCallback):
2501         (consoleMessageSentCallback):
2502         (emitFormControlsAssociated):
2503         (formControlsAssociatedCallback):
2504         (emitFormSubmissionEvent):
2505         (willSubmitFormCallback):
2506         (windowObjectCleared):
2507         (methodCallCallback):
2508         (registerGResource):
2509         (webkit_web_extension_initialize_with_user_data):
2510         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2511         (checkLeaks):
2512         (WebProcessTest::create):
2513         (runTest):
2514         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2515         (AutocleanupsTest::testWebProcessAutocleanups):
2516         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2517         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2518         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2519         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2520         (WebKitDOMDOMWindowTest::testSignals):
2521         (WebKitDOMDOMWindowTest::testDispatchEvent):
2522         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2523         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2524         (WebKitDOMNodeFilterTest::testTreeWalker):
2525         (WebKitDOMNodeFilterTest::testNodeIterator):
2526         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2527         (WebKitDOMNodeTest::testHierarchyNavigation):
2528         (WebKitDOMNodeTest::testInsertion):
2529         (WebKitDOMNodeTest::testTagNamesNodeList):
2530         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2531         (WebKitDOMNodeTest::testDOMCache):
2532         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2533         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2534         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2535         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2536         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2537         (testUIProcessAutocleanups):
2538         (testWebProcessAutocleanups):
2539         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2540         (testContextMenuPopulateMenu):
2541         (testContextMenuDismissed):
2542         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2543         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2544         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2545         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
2546         (testWebKitDOMDOMWindowSignals):
2547         (testWebKitDOMDOMWindowDispatchEvent):
2548         (testWebKitDOMDOMWindowGetComputedStyle):
2549         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
2550         (testWebKitDOMNodeHierarchyNavigation):
2551         (testWebKitDOMNodeInsertion):
2552         (testWebKitDOMNodeTagNamesNodeList):
2553         (testWebKitDOMNodeTagNamesHTMLCollection):
2554         (testWebKitDOMObjectCache):
2555         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
2556         (testWebKitDOMNodeFilterTreeWalker):
2557         (testWebKitDOMNodeFilterNodeIterator):
2558         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
2559         (testWebKitDOMXPathNSResolverNative):
2560         (testWebKitDOMXPathNSResolverCustom):
2561         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2562         (testInspectorDefault):
2563         (testInspectorManualAttachDetach):
2564         (testInspectorCustomContainerDestroyed):
2565         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
2566         (startTestServer):
2567         (testInspectorServerPageList):
2568         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
2569         (OptionMenuTest::showOptionMenuCallback):
2570         (OptionMenuTest::menuCloseCallback):
2571         (OptionMenuTest::close):
2572         (OptionMenuTest::activateItem):
2573         (OptionMenuTest::selectItem):
2574         (testOptionMenuSimple):
2575         (testOptionMenuGroups):
2576         (testOptionMenuActivate):
2577         (testOptionMenuSelect):
2578         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2579         (testPrintOperationPrintSettings):
2580         (webViewPrintCallback):
2581         (testPrintOperationPrint):
2582         (testPrintCustomWidget):
2583         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2584         (checkAtspiAccessible):
2585         (testAtspiBasicHierarchy):
2586         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
2587         (testWebKitCheckVersion):
2588         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2589         (testWebViewEditorCutCopyPasteNonEditable):
2590         (testWebViewEditorCutCopyPasteEditable):
2591         (testWebViewEditorSelectAllNonEditable):
2592         (testWebViewEditorSelectAllEditable):
2593         (loadContentsAndTryToCutSelection):
2594         (testWebViewEditorNonEditable):
2595         (testWebViewEditorEditable):
2596         (testWebViewEditorEditorStateTypingAttributes):
2597         (testWebViewEditorInsertImage):
2598         (testWebViewEditorCreateLink):
2599         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2600         (loadChangedCallback):
2601         (loadFailedCallback):
2602         (loadFailedWithTLSErrorsCallback):
2603         (LoadTrackingTest::LoadTrackingTest):
2604         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2605         (registerGResource):
2606         (removeNonEmptyDirectory):
2607         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2608         (Test::adoptView):
2609         (Test::~Test):
2610         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2611         (WebKitTestBus::getOrCreateConnection):
2612         (WebKitTestBus::createProxy):
2613         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2614         (WebKitTestServer::getWebSocketURIForPath const):
2615         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2616         (WebViewTest::initializeWebView):
2617         (WebViewTest::loadURI):
2618         (WebViewTest::loadHtml):
2619         (WebViewTest::loadPlainText):
2620         (WebViewTest::loadBytes):
2621         (WebViewTest::loadRequest):
2622         (WebViewTest::loadAlternateHTML):
2623         (WebViewTest::goBack):
2624         (WebViewTest::goForward):
2625         (WebViewTest::goToBackForwardListItem):
2626         (resourceGetDataCallback):
2627         (WebViewTest::mainResourceData):
2628         (WebViewTest::javascriptResultToCString):
2629         (WebViewTest::javascriptResultToNumber):
2630         (WebViewTest::javascriptResultToBoolean):
2631         (WebViewTest::javascriptResultIsNull):
2632         (WebViewTest::javascriptResultIsUndefined):
2633         (onSnapshotReady):
2634         (WebViewTest::runWebProcessTest):
2635         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
2636         (WebViewTest::platformInitializeWebView):
2637         (WebViewTest::showInWindow):
2638         (WebViewTest::showInWindowAndWaitUntilMapped):
2639         (WebViewTest::mouseMoveTo):
2640         (WebViewTest::emitPopupMenuSignal):
2641         (WebViewTest::keyStroke):
2642         (WebViewTest::doMouseButtonEvent):
2643
2644 2019-01-09  Philippe Normand  <pnormand@igalia.com>
2645
2646         [WPE] API tests can't run in flatpak environment
2647         https://bugs.webkit.org/show_bug.cgi?id=193242
2648
2649         Reviewed by Michael Catanzaro.
2650
2651         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
2652         flatpakutils so that it knows which port it's dealing with.
2653         * glib/common.py: Remove build_dir globals so that subsequent
2654         calls actually take args into account.
2655         (library_build_path):
2656         (binary_build_path):
2657
2658 2019-01-08  Dean Jackson  <dino@apple.com>
2659
2660         Blob references for System Previews don't get a correct file extension
2661         https://bugs.webkit.org/show_bug.cgi?id=193268
2662         <rdar://problem/47133037>
2663
2664         Reviewed by Tim Horton.
2665
2666         New test that a Blob download of a USDZ file gets named correctly.
2667
2668         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2669         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2670         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2671         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
2672         (TEST):
2673         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
2674
2675 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
2676
2677         [WebAuthN] Support U2F HID Authenticators on macOS
2678         https://bugs.webkit.org/show_bug.cgi?id=191535
2679         <rdar://problem/47102027>
2680
2681         Reviewed by Brent Fulgham.
2682
2683         This patch:
2684         1) adds support for U2F mocking mechanism;
2685         2) updates tests to reflect U2fCommandConstructor changes.
2686
2687         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2688         (TestWebKitAPI::TEST):
2689         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2690         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2691         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2692
2693 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2694
2695         [iOS] Dispatch a synthetic mousedown event prior to starting drags
2696         https://bugs.webkit.org/show_bug.cgi?id=193229
2697         <rdar://problem/46717097>
2698
2699         Reviewed by Tim Horton.
2700
2701         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
2702         prevents a drag from starting.
2703
2704         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2705         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
2706
2707         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
2708
2709 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
2710   
2711         Layout test will generate a perf metric file to results dir.
2712         https://bugs.webkit.org/show_bug.cgi?id=192030
2713         <rdar://problem/32779516>
2714
2715         Reviewed by Aakash Jain.
2716
2717         Layout test running time will be collected to a perf metric file.
2718         For now, instead of outputing running time of all tests (which is huge),
2719         we aggregate them by test directories which are at most two level deep. 
2720
2721         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2722         (Manager._end_test_run):
2723         (Manager._output_perf_metrics):
2724         (Manager._print_expectation_line_for_test):
2725         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2726         (add_test_perf_metric):
2727         (test_perf_metrics):
2728         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2729         (JSONGeneratorTest.test_test_timings_trie):
2730         (JSONGeneratorTest):
2731         (JSONGeneratorTest.test_test_perf_metrics):
2732         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2733         (RebaselineTest.test_reset_results):
2734         (RebaselineTest.test_missing_results):
2735         (RebaselineTest.test_new_baseline):
2736
2737 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
2738
2739         [WPE][GTK] Add php-json to install-dependencies
2740         https://bugs.webkit.org/show_bug.cgi?id=193233
2741
2742         Reviewed by Michael Catanzaro.
2743
2744         * gtk/install-dependencies:
2745         * wpe/install-dependencies:
2746
2747 2019-01-08  Chris Dumez  <cdumez@apple.com>
2748
2749         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
2750         https://bugs.webkit.org/show_bug.cgi?id=193224
2751         <rdar://problem/47097726>
2752
2753         Reviewed by Alex Christensen.
2754
2755         Add API test coverage.
2756
2757         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2758
2759 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2760
2761         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
2762         <https://webkit.org/b/193222>
2763         <rdar://problem/46862309>
2764
2765         Reviewed by Joseph Pecoraro.
2766
2767         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2768         (WTR::executeCallback): Fix camel case of variable name.
2769         (WTR::EventSendingController::callAfterScrollingCompletes): If
2770         WKBundlePageRegisterScrollOperationCompletionCallback() returns
2771         false, make sure to release the ScrollCompletionCallbackData
2772         object.  This fixes the leak.
2773
2774 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2775
2776         [Win] EWS: wincairo-ews cannot apply a patch with *.png
2777         https://bugs.webkit.org/show_bug.cgi?id=193044
2778
2779         Reviewed by Daniel Bates.
2780
2781         WinCairo EWS bots are using Windows Perl. Binary files should be
2782         opened as binary mode.
2783
2784         * Scripts/svn-apply:
2785         (handleGitBinaryChange): Use 'binmode' for binary file handles.
2786
2787 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
2788
2789         [CMake] Add ENABLE_CSS_TYPED_OM option
2790         https://bugs.webkit.org/show_bug.cgi?id=193216
2791
2792         Reviewed by Michael Catanzaro.
2793
2794         * Scripts/webkitperl/FeatureList.pm:
2795
2796 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2797
2798         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
2799         <https://webkit.org/b/193056>
2800
2801         Reviewed by Alex Christensen.
2802
2803         * Scripts/webkitpy/style/checker.py:
2804         - Ignore use of new runtime/retainptr check in
2805           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
2806           contains tests to ensure RetainPtr<NSObject *> is compatible
2807           with RetainPtr<NSObject>.
2808
2809         * Scripts/webkitpy/style/checkers/cpp.py:
2810         (check_language):
2811         (CppChecker):
2812         - Add checker for use of '*' in RetainPtr<> type.  A for loop
2813           was used instead of a single regex so that angle brackets
2814           could be matched up when checking the type contained within
2815           the RetainPtr<> type.
2816
2817         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2818         (CppStyleTest):
2819         - Add unit test for new runtime/retainptr check.
2820
2821         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
2822         * TestWebKitAPI/EditingTestHarness.h:
2823         - Remove '*' from RetainPtr<> type.
2824
2825         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2826         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
2827           regressed in r201938.
2828
2829         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2830         (TestWebKitAPI::TEST):
2831         - Update tests to match RetainPtr.mm tests (except for the
2832           `*SimilarNSType` tests since there is no CF equivalent of
2833           RetainPtr<NSString> and RetainPtr<NSString *>).
2834
2835         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2836         (TestWebKitAPI::TEST):
2837         - Update tests to:
2838           - Not conflict by name with equivalent CF tests in
2839             RetainPtr.cpp.
2840           - Add test cases for RetainPtr<NSObject>,
2841             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
2842           - Add `*SimilarNSType` tests for converting between
2843             RetainPtr<NSObject> and RetainPtr<NSObject *>.
2844           - Change `0` to `nil` as appropriate.
2845           - Re-alphabetize the tests by name.
2846           - Add Optional<RetainPtr<>> tests.
2847           - Add retainPtr() tests.
2848
2849         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2850         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2851         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
2852         (TEST):
2853         - Remove '*' from RetainPtr<> type.
2854
2855         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
2856         (TEST(WebKit, JITEnabled)):
2857         - Add missing WTFMove().  Apparently a temporary was being
2858           created before in the argument list due to mismatched
2859           RetainPtr<> types.
2860
2861         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2862         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2863         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
2864         (TestWebKitAPI::TEST):
2865         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2866         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2867         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2868         (WTR::resourcesDirectoryURL):
2869         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2870         (WTR::InjectedBundle::platformInitialize):
2871         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2872         - Remove '*' from RetainPtr<> type.
2873
2874 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
2875
2876         A MediaTime timescale must never be zero
2877         https://bugs.webkit.org/show_bug.cgi?id=193156
2878         <rdar://problem/32504501>
2879
2880         Reviewed by Jer Noble.
2881
2882         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2883         (TestWebKitAPI::TEST): Add tests for zero timescale.
2884
2885 2019-01-07  Youenn Fablet  <youenn@apple.com>
2886
2887         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
2888         https://bugs.webkit.org/show_bug.cgi?id=193175
2889
2890         Reviewed by Chris Dumez.
2891
2892         Updated API test as we bumped the SW schema to version 4.
2893
2894         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2895         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
2896         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2897         (TEST):
2898
2899 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2900
2901         [Win][Clang] Fix compilation warnings of MiniBrowser
2902         https://bugs.webkit.org/show_bug.cgi?id=193029
2903
2904         Reviewed by Ross Kirsling.
2905
2906         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
2907         and m_URLBarFont. Reorder member variables to fix -Wreorder
2908         warning.
2909         * MiniBrowser/win/PageLoadTestClient.cpp:
2910         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
2911         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
2912         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
2913         m_currentURLIndex.
2914         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2915         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
2916         navigationClient with '{ }' to fix the missing field warning.
2917         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2918         (initDocStruct): Changed the argument type docname to const.
2919
2920 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
2921
2922         [WebAuthN] Import U2F command/response converters from Chromium
2923         https://bugs.webkit.org/show_bug.cgi?id=193150
2924         <rdar://problem/47054028>
2925
2926         Reviewed by Brent Fulgham.
2927
2928         Adds API tests.
2929
2930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2931         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2932         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
2933         (TestWebKitAPI::getTestAuthenticatorDataBytes):
2934         (TestWebKitAPI::getTestAttestationObjectBytes):
2935         (TestWebKitAPI::getTestSignResponse):
2936         (TestWebKitAPI::getTestU2fRegisterResponse):
2937         (TestWebKitAPI::TEST):
2938         (TestWebKitAPI::convertToVector): Deleted.
2939         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2940         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
2941         (TestWebKitAPI::constructMakeCredentialRequest):
2942         (TestWebKitAPI::constructGetAssertionRequest):
2943         (TestWebKitAPI::TEST):
2944
2945 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
2946
2947         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
2948         https://bugs.webkit.org/show_bug.cgi?id=193136
2949
2950         Reviewed by Michael Catanzaro.
2951
2952         * gtk/install-dependencies:
2953         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
2954         they are needed by update-webkitgtk-libs.
2955
2956 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
2957
2958         Unreviewed follow-up fix to r239650
2959         https://bugs.webkit.org/show_bug.cgi?id=193140
2960         <rdar://problem/47063037>
2961
2962         Typecast patch_id to string.
2963
2964         * BuildSlaveSupport/ews-build/steps.py:
2965         (ValidatePatch._is_patch_obsolete):
2966
2967 2019-01-04  Daniel Bates  <dabates@apple.com>
2968
2969         [lldb-webkit]: Add support for pretty-printing raw bitmask types
2970         https://bugs.webkit.org/show_bug.cgi?id=193024
2971
2972         Reviewed by Jer Noble.
2973
2974         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
2975         for the bitmask type WebEventFlags as an example.
2976
2977         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
2978         that can be used to register summary and synthetic child formatters for a bitmask type.
2979         For example, consider the following enum and bitmask typedefs:
2980
2981         typedef enum {
2982             A = 1 << 0,
2983             B = 1 << 1,
2984             C = 1 << 2,
2985         } SpecialFlagValues;
2986         typedef unsigned SpecialFlags;
2987
2988         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
2989         __lldb_init_module():
2990
2991             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
2992                     1 << 0: "A",
2993                     1 << 1: "B",
2994                     1 << 2: "C",
2995             })
2996
2997         * lldb/lldb_webkit.py:
2998         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2999         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
3000         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
3001         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
3002         A convenience function to dynamically creaste a synthetic formatter class and summary
3003         string function for the specified bitmask type and enumerator value to name map. This
3004         function register the dynamically created class and function with LLDB.
3005
3006         (__lldb_init_module):
3007         (FlagEnumerationProvider):
3008         (FlagEnumerationProvider._enumerator_value_to_name_map):
3009         (FlagEnumerationProvider._bitmask):
3010         (FlagEnumerationProvider._update):
3011         (FlagEnumerationProvider.has_children):
3012         (FlagEnumerationProvider.num_children):
3013         (FlagEnumerationProvider.get_child_index):
3014         (FlagEnumerationProvider.get_child_at_index):
3015         (FlagEnumerationProvider.update):
3016         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
3017
3018         (WTFOptionSetProvider):
3019         (WTFOptionSetProvider._enumerator_value_to_name_map):
3020         (WTFOptionSetProvider._bitmask):
3021         (WTFOptionSetProvider._update):
3022         Write in terms of the base class.
3023
3024         (RawBitmaskProviderBase):
3025         (RawBitmaskProviderBase._enumerator_value_to_name_map):
3026         (RawBitmaskProviderBase._bitmask):
3027         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
3028         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
3029         {
3030             1 << 0: "A",
3031             1 << 1: "B",
3032             1 << 2: "C",
3033         }
3034         It is not necessary to instantiate such a derived class directory. Instead use the convenience
3035         function addSummaryAndSyntheticFormattersForRawBitmaskType.
3036
3037         (WTFOptionSetProvider.has_children): Deleted.
3038         (WTFOptionSetProvider.num_children): Deleted.
3039         (WTFOptionSetProvider.get_child_index): Deleted.
3040         (WTFOptionSetProvider.get_child_at_index): Deleted.
3041         (WTFOptionSetProvider.update): Deleted.
3042
3043 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3044
3045         [ews-build] Add build step to validate the patch before processing it
3046         https://bugs.webkit.org/show_bug.cgi?id=193140
3047
3048         Reviewed by Lucas Forschler.
3049
3050         * BuildSlaveSupport/ews-build/factories.py:
3051         (Factory.__init__): Added ValidatePatch step.
3052         * BuildSlaveSupport/ews-build/steps.py:
3053         (ValidatePatch):
3054         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
3055         (ValidatePatch.get_patch_json): Get patch json data.
3056         (ValidatePatch.get_bug_json): Get bug json data.
3057         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
3058         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
3059         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
3060         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
3061         (ValidatePatch.skip_build): Skip the build.
3062         (ValidatePatch.start):
3063
3064 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3065
3066         Progress towards fixing Mac CMake build
3067         https://bugs.webkit.org/show_bug.cgi?id=193105
3068
3069         Reviewed by Don Olmstead.
3070
3071         * TestWebKitAPI/PlatformMac.cmake:
3072
3073 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3074
3075         Fix API test after r239631
3076         https://bugs.webkit.org/show_bug.cgi?id=193118
3077
3078         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3079         (TestWebKitAPI::TEST):
3080         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
3081         Do the same thing via the API to fix the test.
3082
3083 2019-01-04  Jer Noble  <jer.noble@apple.com>
3084
3085         [WebKitLegacy] Media playback pauses on scroll
3086         https://bugs.webkit.org/show_bug.cgi?id=192829
3087
3088         Reviewed by Eric Carlson.
3089
3090         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3091         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
3092         (TestWebKitAPI::TEST):
3093         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
3094         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
3095         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
3096         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
3097         (TestWebKitAPI::TEST):
3098
3099 2019-01-04  Chris Dumez  <cdumez@apple.com>
3100
3101         Add support for toggling device orientation API support per site
3102         https://bugs.webkit.org/show_bug.cgi?id=193143
3103         <rdar://problem/46605724>
3104
3105         Reviewed by Alex Christensen.
3106
3107         Add API test coverage.
3108
3109         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3110         (-[DataMappingSchemeHandler setTaskHandler:]):
3111         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3112         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
3113         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3114         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
3115
3116 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3117
3118         [ews-build] use svn-apply script to apply the patches
3119         https://bugs.webkit.org/show_bug.cgi?id=193138
3120
3121         Reviewed by Lucas Forschler.
3122
3123         * BuildSlaveSupport/ews-build/factories.py:
3124         (Factory.__init__): Add the ApplyPatch step.
3125         * BuildSlaveSupport/ews-build/steps.py:
3126         (CheckOutSource): Added step name.
3127         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
3128         (ApplyPatch): Build step to apply patch using svn-apply script.
3129         (UnApplyPatchIfRequired):
3130         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
3131
3132 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3133
3134         Deprecate WKContextCreate
3135         https://bugs.webkit.org/show_bug.cgi?id=193118
3136
3137         Reviewed by Brady Eidson.
3138
3139         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3140         (WebKitBrowserWindow::WebKitBrowserWindow):
3141         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
3142         (TestWebKitAPI::TEST):
3143         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3144         (TestWebKitAPI::TEST):
3145         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3146         (TestWebKitAPI::TEST):
3147         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3148         (TestWebKitAPI::TEST):
3149         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3150         (TestWebKitAPI::TEST):
3151         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3152         (TestWebKitAPI::TEST):
3153         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3154         (TestWebKitAPI::TEST):
3155         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3156         (TestWebKitAPI::TEST):
3157         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3158         (TestWebKitAPI::TEST):
3159         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3160         (TestWebKitAPI::TEST):
3161         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3162         (TestWebKitAPI::TEST):
3163         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3164         (TestWebKitAPI::TEST):
3165         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3166         (TestWebKitAPI::TEST):
3167         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3168         (TestWebKitAPI::TEST):
3169         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3170         (TestWebKitAPI::TEST):
3171         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3172         (TestWebKitAPI::TEST):
3173         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3174         (TestWebKitAPI::TEST):
3175         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3176         (TestWebKitAPI::TEST):
3177         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3178         (TestWebKitAPI::loadAlternateHTMLString):
3179         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3180         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3181         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3182         (TestWebKitAPI::buildAndPerformTest):
3183         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3184         (TestWebKitAPI::TEST):
3185         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3186         (TestWebKitAPI::TEST):
3187         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3188         (TestWebKitAPI::TEST):
3189         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3190         (TestWebKitAPI::TEST):
3191         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3192         (TestWebKitAPI::TEST):
3193         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3194         (TestWebKitAPI::TEST):
3195         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3196         (TestWebKitAPI::TEST):
3197         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3198         (TestWebKitAPI::TEST):
3199         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3200         (TestWebKitAPI::TEST):
3201         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3202         (TestWebKitAPI::TEST):
3203         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3204         (TestWebKitAPI::TEST):
3205         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3206         (TestWebKitAPI::TEST):
3207         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3208         (TestWebKitAPI::TEST):
3209         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3210         (TestWebKitAPI::TEST):
3211         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3212         (TestWebKitAPI::TEST):
3213         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3214         (TestWebKitAPI::TEST):
3215         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3216         (TestWebKitAPI::TEST):
3217         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3218         (TestWebKitAPI::TEST):
3219         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3220         (TestWebKitAPI::TEST):
3221         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3222         (TestWebKitAPI::TEST):
3223         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3224         (TestWebKitAPI::TEST):
3225         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3226         (TestWebKitAPI::TEST):
3227         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3228         (TestWebKitAPI::TEST):
3229         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3230         (TestWebKitAPI::TEST):
3231         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3232         (TestWebKitAPI::TEST):
3233         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3234         (TestWebKitAPI::TEST):
3235         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3236         (WebKit2_CommandBackForwardTestWKView::SetUp):
3237         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3238         (TestWebKitAPI::TEST):
3239         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3240         (TestWebKitAPI::TEST):
3241         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3242         (TestWebKitAPI::TEST):
3243         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3244         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3245
3246 2019-01-03  Matt Rajca  <mrajca@apple.com>
3247
3248         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3249         https://bugs.webkit.org/show_bug.cgi?id=193128
3250         rdar://34554231
3251
3252         Reviewed by Jer Noble.
3253
3254         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3255         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3256         event along with a flag that indicates whether or not autoplay was actually prevented.
3257
3258         Tests: existing API tests were updated to reflect the new names. New API tests
3259         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3260
3261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3262         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3263         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3264         (TEST):
3265         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3266         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3267
3268 2019-01-04  Chris Dumez  <cdumez@apple.com>
3269
3270         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3271         https://bugs.webkit.org/show_bug.cgi?id=193120
3272
3273         Reviewed by Alex Christensen.
3274
3275         Add API test coverage.
3276
3277         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3278
3279 2019-01-04  Chris Dumez  <cdumez@apple.com>
3280
3281         Crash under WebProcessPool::addSuspendedPage()
3282         https://bugs.webkit.org/show_bug.cgi?id=193110
3283
3284         Reviewed by Youenn Fablet.
3285
3286         Add API test coverage.
3287
3288         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3289
3290 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3291
3292         [ews-build] Check patch relevance before applying the patch
3293         https://bugs.webkit.org/show_bug.cgi?id=193102
3294
3295         Reviewed by Lucas Forschler.
3296
3297         * BuildSlaveSupport/ews-build/factories.py:
3298         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3299
3300 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3301
3302         [ews-build] Check patch relevance step should print patch id
3303         https://bugs.webkit.org/show_bug.cgi?id=193137
3304
3305         Reviewed by Lucas Forschler.
3306
3307         * BuildSlaveSupport/ews-build/steps.py:
3308         (CheckPatchRelevance.start): Update the status to include patch id.
3309
3310 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3311
3312         webkitpy: Increase simulator teardown timeout
3313         https://bugs.webkit.org/show_bug.cgi?id=193141
3314         <rdar://problem/46174217>
3315
3316         Rubber-stamped by Aakash Jain.
3317
3318         * Scripts/webkitpy/xcode/simulated_device.py:
3319         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3320
3321 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3322
3323         test262-runner misbehaves when test file YAML has a trailing space
3324         https://bugs.webkit.org/show_bug.cgi?id=193053
3325
3326         Reviewed by Yusuke Suzuki.
3327
3328         * Scripts/test262/Runner.pm:
3329         (parseData):
3330         Accept trailing space when parsing a test file's YAML block.
3331
3332 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3333
3334         UserMedia test should use WKPageNavigationClient
3335         https://bugs.webkit.org/show_bug.cgi?id=192913
3336
3337         Reviewed by Youenn Fablet.
3338
3339         The test currently uses the deprecated WKPageLoaderClient. It should use
3340         WKPageNavigationClient instead, which provides the same callback under a similar name.
3341
3342         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3343         (TestWebKitAPI::TEST):
3344
3345 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3346
3347         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3348         https://bugs.webkit.org/show_bug.cgi?id=192944
3349
3350         Reviewed by Tim Horton.
3351
3352         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3353         (TestWebKitAPI::TEST):
3354
3355 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3356
3357         Add support for using the current text selection as the find string on iOS
3358         https://bugs.webkit.org/show_bug.cgi?id=193034
3359         <rdar://problem/45138739>
3360
3361         Reviewed by Tim Horton.
3362
3363         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3364         _setStringForFind) works as expected.
3365
3366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3367         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3368
3369 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3370
3371         [ews-build] Use git on OpenSource EWS bots
3372         https://bugs.webkit.org/show_bug.cgi?id=193092
3373
3374         Reviewed by Lucas Forschler.
3375
3376         * BuildSlaveSupport/ews-build/steps.py:
3377         (CheckOutSource): Use git instead of svn.
3378         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3379
3380 2019-01-02  Daniel Bates  <dabates@apple.com>
3381
3382         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3383         https://bugs.webkit.org/show_bug.cgi?id=193023
3384
3385         Reviewed by Simon Fraser.
3386
3387         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3388         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3389         enumerator values. We should just remove this code.
3390
3391         * lldb/lldb_webkit.py:
3392         (WTFOptionSetProvider.has_children):
3393         (WTFOptionSetProvider.num_children):
3394         (WTFOptionSetProvider.get_child_index):
3395         (WTFOptionSetProvider.get_child_at_index):
3396
3397 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3398
3399         .ycm_extra_conf.py should handle XXXInlines.h
3400         https://bugs.webkit.org/show_bug.cgi?id=193055
3401
3402         Reviewed by Carlos Garcia Campos.
3403
3404         compile_commands.json database only records flags and options for cpp source files.
3405         So, when we open headers, this database does not have any information for that.
3406         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3407         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3408         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3409         we attempt to find XXX.cpp and use the configuration if it exists.
3410
3411         * gtk/ycm_extra_conf.py:
3412         (getImplementationFilename):
3413         (FlagsForFile):
3414
3415 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3416
3417         Unreviewed. Support PHP 7.3 in Debian.
3418
3419         Add 7.3 to the list of php versions supported in Debian.
3420
3421         * Scripts/webkitpy/port/base.py:
3422         (Port._debian_php_version):
3423
3424 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3425
3426         Resurrect Mac CMake build
3427         https://bugs.webkit.org/show_bug.cgi?id=192658
3428
3429         Reviewed by Yusuke Suzuki.
3430
3431         * DumpRenderTree/PlatformMac.cmake:
3432         * MiniBrowser/mac/CMakeLists.txt:
3433         * TestWebKitAPI/PlatformMac.cmake:
3434
3435 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3436
3437         [Tools] Remove references to Bison and Flex
3438         https://bugs.webkit.org/show_bug.cgi?id=193033
3439
3440         Reviewed by Michael Catanzaro.
3441
3442         The Bison and Flex tools are not needed anymore since r209883.
3443
3444         * CygwinDownloader/cygwin-downloader.py:
3445         * EWSTools/ubuntu-ews-packages:
3446         * Scripts/filter-build-webkit:
3447         (shouldIgnoreLine):
3448         * gtk/install-dependencies:
3449         * wpe/install-dependencies:
3450
3451 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3452
3453         WebDriver: warn about non existing tests when parsing expectations
3454         https://bugs.webkit.org/show_bug.cgi?id=192979
3455
3456         Reviewed by Michael Catanzaro.
3457
3458         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
3459         renamed.
3460
3461         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3462         (WebDriverTestRunner.__init__):
3463
3464 2018-12-21  Chris Dumez  <cdumez@apple.com>
3465
3466         navigator.userAgent in service workers does not reflect customUserAgent set by client
3467         https://bugs.webkit.org/show_bug.cgi?id=192951
3468
3469         Reviewed by Youenn Fablet.
3470
3471         Extend API test coverage.
3472
3473         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3474         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
3475         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3476         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
3477         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3478
3479 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3480
3481         [WebAuthN] userPresence should always be true
3482         https://bugs.webkit.org/show_bug.cgi?id=192835
3483         <rdar://problem/46538788>
3484
3485         Reviewed by Brent Fulgham.
3486
3487         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3488         (TestWebKitAPI::TEST):
3489
3490 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
3491
3492         Add support to run-benchmark to use non-default copies of the browser apps
3493         https://bugs.webkit.org/show_bug.cgi?id=192905
3494         rdar://problem/46845840
3495
3496         Reviewed by Dewei Zhu.
3497         
3498         Add support for a --browser-path argument to run-benchmark, which allows you to use
3499         a custom app bundle for a given browser (only implemented for Safari at present).
3500
3501         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3502         (BenchmarkRunner.__init__):
3503         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3504         (BrowserDriver.__init__):
3505         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3506         (BrowserDriverFactory.create):
3507         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3508         (OSXBrowserDriver._launch_process):
3509         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
3510         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
3511         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3512         (OSXChromeCanaryDriver.launch_url):
3513         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3514         (OSXFirefoxNightlyDriver.launch_url):
3515         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3516         (OSXSafariDriver.__init__):
3517         (OSXSafariDriver.launch_url):
3518         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3519         (parse_args):
3520         (run_benchmark_plan):
3521         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3522         (WebServerBenchmarkRunner.__init__):
3523         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
3524         (FakeBenchmarkRunner.__init__):
3525
3526 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3527
3528         [WebAuthN] Import an APDU coder from Chromium
3529         https://bugs.webkit.org/show_bug.cgi?id=192949
3530         <rdar://problem/46879933>
3531
3532         Reviewed by Brent Fulgham.
3533
3534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3535         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
3536         (TestWebKitAPI::TEST):
3537
3538 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3539
3540         Setting the file wrapper and content type of an attachment to a PDF should update its image
3541         https://bugs.webkit.org/show_bug.cgi?id=192984
3542         <rdar://problem/46798028>
3543
3544         Reviewed by Tim Horton.
3545
3546         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
3547         PDF data correctly updates the image element.
3548
3549         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3550
3551 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3552
3553         Add JSCOnly to bot dashboard
3554         https://bugs.webkit.org/show_bug.cgi?id=192964
3555
3556         Reviewed by Alexey Proskuryakov.
3557
3558         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
3559         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
3560         useful if they were not so secret, so add them.
3561
3562         There appear to be no build-only bots, so the first column is blank. And of course there are
3563         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
3564         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
3565         and there's plenty of room in the final column for all the bots.
3566
3567         I had a hard time picking a logo to use, because the JavaScript language does not have an
3568         official logo. But I believe I've found one that will be satisfactory.
3569
3570         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
3571
3572         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
3573         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
3574         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3575         (BubbleQueueServer):
3576         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3577         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3578         (WebKitBuildbot):
3579         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3580         (table.queue-grid tr.platform.linux-jsconly img.logo):
3581
3582 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
3583
3584         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3585         https://bugs.webkit.org/show_bug.cgi?id=192821
3586
3587         Reviewed by Chris Dumez.
3588
3589         * DumpRenderTree/mac/DumpRenderTree.mm:
3590         (createWebViewAndOffscreenWindow):
3591         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3592
3593 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3594
3595         [Win][Clang] Fix compilation warnings of DumpRenderTree
3596         https://bugs.webkit.org/show_bug.cgi?id=192924
3597
3598         Reviewed by Alex Christensen.
3599
3600         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
3601         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3602         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
3603         * DumpRenderTree/win/DumpRenderTree.cpp:
3604         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
3605         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
3606         object to the argument of setDefaultTextEncodingName instead of a
3607         const string literal.
3608         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
3609         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
3610         (setCacheFolder): Deleted.
3611         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
3612         * DumpRenderTree/win/EditingDelegate.cpp:
3613         (dump): Use %d for int.
3614         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
3615         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3616         (BSTRFromString): Deleted unused function.
3617         * DumpRenderTree/win/TestRunnerWin.cpp:
3618         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
3619         the arguemnt of setQuota instead of const string literal.
3620         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3621         (jsStringRefToWString): Deleted unused function.
3622
3623 2018-12-20  Chris Dumez  <cdumez@apple.com>
3624
3625         Add API test coverage for customUserAgent client setting and service workers
3626         https://bugs.webkit.org/show_bug.cgi?id=192952
3627
3628         Reviewed by Alex Christensen.
3629
3630         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3631         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
3632         (-[SWSchemes webView:startURLSchemeTask:]):
3633         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3634         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3635
3636 2018-12-20  Chris Dumez  <cdumez@apple.com>
3637
3638         Use Optional::hasValue() instead of Optional::has_value()
3639         https://bugs.webkit.org/show_bug.cgi?id=192948
3640
3641         Reviewed by Tim Horton.
3642
3643         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
3644         (TestWebKitAPI::TEST):
3645         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
3646         (TestWebKitAPI::TEST):
3647         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3648         (TestWebKitAPI::TEST_F):
3649
3650 2018-12-20  Chris Dumez  <cdumez@apple.com>
3651
3652         Add style script rule to check for uses of std::optional<>
3653         https://bugs.webkit.org/show_bug.cgi?id=192931
3654
3655         Reviewed by Tim Horton.
3656
3657         * Scripts/webkitpy/style/checkers/cpp.py:
3658         (check_wtf_optional):
3659         (check_style):
3660
3661 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
3662
3663         [WebAuthN] Add a runtime flag for local authenticator
3664         https://bugs.webkit.org/show_bug.cgi?id=192792
3665         <rdar://problem/46798738>
3666
3667         Reviewed by Brent Fulgham.
3668
3669         * DumpRenderTree/TestOptions.cpp:
3670         (TestOptions::TestOptions):
3671         * DumpRenderTree/TestOptions.h:
3672         * DumpRenderTree/mac/DumpRenderTree.mm:
3673         (enableExperimentalFeatures):
3674         (setWebPreferencesForTestOptions):
3675         * WebKitTestRunner/TestController.cpp:
3676         (WTR::TestController::resetPreferencesToConsistentValues):
3677         (WTR::updateTestOptionsFromTestHeader):
3678         * WebKitTestRunner/TestOptions.h:
3679         (WTR::TestOptions::hasSameInitializationOptions const):
3680
3681 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
3682
3683         webkitpy: Autoinstall package URLs have changed
3684         https://bugs.webkit.org/show_bug.cgi?id=192909
3685         <rdar://problem/46860359>
3686
3687         Rubber-stamped by Alexey Proskuryakov.
3688
3689         PyPi urls have been moved around, we need to update our auto-installed packages.
3690
3691         We should check for Selenium before asking PyPi for the latest version.
3692
3693         * Scripts/webkitpy/thirdparty/__init__.py:
3694         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
3695         (AutoinstallImportHook._install_keyring): Ditto.
3696         (AutoinstallImportHook._install_pep8): Ditto.
3697         (AutoinstallImportHook._install_mozlog): Ditto.
3698         (AutoinstallImportHook._install_mozprocess): Ditto.
3699         (AutoinstallImportHook._install_pytest_timeout): Ditto.
3700         (AutoinstallImportHook._install_pytest): Ditto.
3701         (AutoinstallImportHook._install_pylint): Ditto.
3702         (AutoinstallImportHook._install_buildbot): Ditto.
3703         (AutoinstallImportHook._install_coverage): Ditto.
3704         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
3705         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
3706         for new Selenium if the installed version isn't sufficient.
3707         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
3708
3709 2018-12-20  Chris Dumez  <cdumez@apple.com>
3710
3711         Use Optional::valueOr() instead of Optional::value_or()
3712         https://bugs.webkit.org/show_bug.cgi?id=192933
3713
3714         Reviewed by Geoffrey Garen.
3715
3716         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3717         (TestWebKitAPI::checkURL):
3718         (TestWebKitAPI::checkRelativeURL):
3719         (TestWebKitAPI::checkURLDifferences):
3720         (TestWebKitAPI::checkRelativeURLDifferences):
3721         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
3722         (TestWebKitAPI::checkURL):
3723
3724 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
3725
3726         Unreviewed, rolling out r239417.
3727
3728         Introduced two API test failures on macOS.
3729
3730         Reverted changeset:
3731
3732         "<rdar://problem/46194315> macOS: WebKit1 does not handle
3733         occlusion changes"
3734         https://bugs.webkit.org/show_bug.cgi?id=192821
3735         https://trac.webkit.org/changeset/239417
3736
3737 2018-12-20  Devin Rousso  <drousso@apple.com>
3738
3739         Web Inspector: UIString should take an optional key and description to aid localization
3740         https://bugs.webkit.org/show_bug.cgi?id=153962
3741         <rdar://problem/24542505>
3742
3743         Reviewed by Brian Burg.
3744
3745         * Scripts/extract-localizable-js-strings:
3746
3747 2018-12-20  Tim Horton  <timothy_horton@apple.com>
3748
3749         Unparented WKWebView can't retrieve main resource data for a main frame plugin
3750         https://bugs.webkit.org/show_bug.cgi?id=192923
3751         <rdar://problem/46859068>
3752
3753         Reviewed by Wenson Hsieh.
3754
3755         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3756         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
3757         Add a test ensuring that both parented and unparented WKWebViews can
3758         retrieve main resource data when loading a PDF.
3759
3760 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3761
3762         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
3763         https://bugs.webkit.org/show_bug.cgi?id=192852
3764
3765         Reviewed by Michael Catanzaro.
3766
3767         EmojiOne font was replaced by Noto Color Emoji.
3768
3769         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
3770         * gtk/jhbuild.modules:
3771         * wpe/jhbuild.modules:
3772
3773 2018-12-19  Chris Dumez  <cdumez@apple.com>
3774
3775         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
3776         https://bugs.webkit.org/show_bug.cgi?id=192728
3777         <rdar://problem/46746779>
3778
3779         Reviewed by Geoff Garen.
3780
3781         * DumpRenderTree/*:
3782         * MiniBrowser/*:
3783         * TestRunnerShared/*:
3784         * TestWebKitAPI/*:
3785         * WebGPUAPIStructure/*:
3786         * WebKitTestRunner/*:
3787
3788 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
3789
3790         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3791         https://bugs.webkit.org/show_bug.cgi?id=192821
3792
3793         Reviewed by Chris Dumez.
3794
3795         * DumpRenderTree/mac/DumpRenderTree.mm:
3796         (createWebViewAndOffscreenWindow):
3797
3798 2018-12-19  Alex Christensen  <achristensen@webkit.org>
3799
3800         Navigations away from the SafeBrowsing interstitial show a flash of old content
3801         https://bugs.webkit.org/show_bug.cgi?id=192676
3802
3803         Reviewed by Chris Dumez.
3804
3805         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3806         (safeBrowsingView):
3807         (TEST):
3808         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3809
3810 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
3811
3812         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
3813         https://bugs.webkit.org/show_bug.cgi?id=192855
3814
3815         Reviewed by Michael Catanzaro.
3816
3817         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3818         (WTR::TestController::notifyDone): Use the WPE implementation.
3819         (WTR::TestController::platformRunUntil): Use the WPE implementation.
3820         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
3821         (WTR::TestController::platformRunUntil): Honor the condition flag.
3822
3823 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
3824
3825         Allow clients to set the navigator platform
3826         https://bugs.webkit.org/show_bug.cgi?id=192735
3827
3828         Reviewed by Tim Horton.
3829
3830         Add a test for setting a custom navigator platform.
3831
3832         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3833         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3834         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
3835
3836 2018-12-19  Truitt Savell  <tsavell@apple.com>
3837
3838         Unreviewed, rolling out r239358.
3839
3840         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
3841         crash on Debug bots
3842
3843         Reverted changeset:
3844
3845         "Clean up IndexedDB files between tests"
3846         https://bugs.webkit.org/show_bug.cgi?id=192796
3847         https://trac.webkit.org/changeset/239358
3848
3849 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3850
3851         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
3852         https://bugs.webkit.org/show_bug.cgi?id=192842
3853         <rdar://problem/46823586>
3854
3855         Reviewed by Tim Horton.
3856
3857         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
3858         item provider when dragging a rich text selection.
3859
3860         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3861
3862 2018-12-18  David Quesada  <david_quesada@apple.com>
3863
3864         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
3865         https://bugs.webkit.org/show_bug.cgi?id=192810
3866         <rdar://problem/46812536>
3867
3868         Reviewed by Alex Christensen.
3869
3870         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3871         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3872             After releasing our reference to the web view, wait until the next turn of the runloop
3873             before checking that the originatingWebView has been zeroed, since the web view might
3874             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
3875             testing general memory management of WKWebViews, only that _WKDownload does not retain
3876             its web view via the 'originatingWebView' property.
3877
3878 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
3879
3880         Clean up IndexedDB files between tests
3881         https://bugs.webkit.org/show_bug.cgi?id=192796
3882
3883         Reviewed by Geoffrey Garen.
3884
3885         * DumpRenderTree/mac/DumpRenderTree.mm:
3886         (runTest):
3887         * WebKitTestRunner/TestController.cpp:
3888         (WTR::TestController::resetStateToConsistentValues):
3889         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3890         (WTR::RemoveAllIndexedDatabasesCallback):
3891         (WTR::TestController::ClearIndexedDatabases):
3892         * WebKitTestRunner/TestController.h:
3893
3894 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3895
3896         Fix API test introduced in r239339 on iOS.
3897         https://bugs.webkit.org/show_bug.cgi?id=192675
3898
3899         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3900         (TEST):
3901         The iOS implementation of the safe browsing warning is a little different.
3902         It does some element creation when it is added to the window so it knows how big it is.
3903         To test these elements, we need to simulate adding it to the window.
3904         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
3905
3906 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
3907
3908         webkitpy: Ignore device type for test when using --force
3909         https://bugs.webkit.org/show_bug.cgi?id=192786
3910         <rdar://problem/46794894>
3911
3912         Reviewed by Daniel Bates.
3913
3914         It is sometimes the case that a contributor will wish to run a test on a specific device,
3915         despite expectations which indicate a test should not be run on that device.
3916
3917         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3918         (parse_args):
3919         * Scripts/webkitpy/port/device_port.py:
3920         (DevicePort.default_child_processes): Strip device type information when using --force.
3921         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
3922
3923 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3924
3925         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
3926         https://bugs.webkit.org/show_bug.cgi?id=192675
3927
3928         Reviewed by Geoffrey Garen.
3929
3930         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3931         (goBack):
3932         (TEST):
3933         (visitUnsafeSite):
3934         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
3935         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3936
3937 2018-12-18  Chris Dumez  <cdumez@apple.com>
3938
3939         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
3940         https://bugs.webkit.org/show_bug.cgi?id=192772
3941
3942         Reviewed by Antti Koivisto.
3943
3944         Add API test coverage.
3945
3946         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3947
3948 2018-12-18  Philippe Normand  <pnormand@igalia.com>
3949
3950         Unreviewed, JHBuild GTK build fix attempt
3951
3952         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
3953         There's no ninja module either, it should be provided by the
3954         host system.
3955
3956 2018-12-17  Chris Dumez  <cdumez@apple.com>
3957
3958         Allow passing nil as session state to [WKWebView _restoreSessionState:]
3959         https://bugs.webkit.org/show_bug.cgi?id=192789
3960         <rdar://problem/46755277>
3961
3962         Reviewed by Alex Christensen.
3963
3964         Add API test coverage.
3965
3966         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3967         (TEST):
3968
3969 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
3970
3971         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
3972         https://bugs.webkit.org/show_bug.cgi?id=192780
3973         rdar://problem/43394387
3974
3975         Reviewed by Tim Horton.
3976
3977         No need to set "AppleFontSmoothing" defaults for WK2.
3978
3979         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3980         (WTR::InjectedBundle::platformInitialize):
3981
3982 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
3983
3984         webkitpy: Handle case where stdout and stderr don't accept unicode
3985         https://bugs.webkit.org/show_bug.cgi?id=192775
3986         <rdar://problem/46497303>
3987
3988         Reviewed by Stephanie Lewis.
3989
3990         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3991         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
3992         characters with '?'.
3993         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3994         (RegularTest.test_stream_with_encoding):
3995
3996 2018-12-17  Daniel Bates  <dabates@apple.com>
3997
3998         Support concatenating StringView with other string types
3999         https://bugs.webkit.org/show_bug.cgi?id=177566
4000
4001         Reviewed by Darin Adler.
4002
4003         Add some tests to ensure we do not regress the number of allocations needed when performing
4004         string concatenation with string views.
4005
4006         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
4007         (TestWebKitAPI::TEST):
4008
4009 2018-12-17  Commit Queue  <commit-queue@webkit.org>
4010
4011         Unreviewed, rolling out r239265 and r239274.
4012         https://bugs.webkit.org/show_bug.cgi?id=192765
4013
4014         unorm_normalize is deprecated, and broke an internal build
4015         (Requested by Truitt on #webkit).
4016
4017         Reverted changesets:
4018
4019         "[GTK][WPE] Need a function to convert internal URI to display
4020         ("pretty") URI"
4021         https://bugs.webkit.org/show_bug.cgi?id=174816
4022         https://trac.webkit.org/changeset/239265
4023
4024         "Fix the Apple Internal Mac build with a newer SDK"
4025         https://trac.webkit.org/changeset/239274
4026
4027 2018-12-17  Daniel Bates  <dabates@apple.com>
4028
4029         Implement UIScriptController::toggleCapsLock() for iOS
4030         https://bugs.webkit.org/show_bug.cgi?id=191815
4031
4032         Reviewed by Andy Estes.
4033
4034         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
4035
4036         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4037         * WebKitTestRunner/TestController.cpp:
4038         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
4039         before running a test. This ensures that the caps lock state does not persist between
4040         tests should a test enable caps lock and not disable it.
4041         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4042         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
4043         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4044         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
4045         create the event. Also substituted NSString* for const String& as the data type for the first
4046         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
4047         below.
4048         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
4049         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
4050
4051 2018-12-17  Daniel Bates  <dabates@apple.com>
4052
4053         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
4054         https://bugs.webkit.org/show_bug.cgi?id=192633
4055
4056         Reviewed by Wenson Hsieh.
4057
4058         Update code to use the modern initializer.
4059
4060         * DumpRenderTree/mac/EventSendingController.mm:
4061         (-[EventSendingController keyDown:withModifiers:withLocation:]):
4062
4063 2018-12-17  Matt Lewis  <jlewis3@apple.com>
4064
4065         Unreviewed, rolling out r239254.
4066
4067         This broke the Windows 10 Debug build
4068
4069         Reverted changeset:
4070
4071         "Replace many uses of String::format with more type-safe
4072         alternatives"
4073         https://bugs.webkit.org/show_bug.cgi?id=192742
4074         https://trac.webkit.org/changeset/239254
4075
4076 2018-12-17  David Kilzer  <ddkilzer@apple.com>
4077
4078         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
4079         <https://webkit.org/b/192751>
4080         <rdar://problem/46771623>
4081
4082         Reviewed by Daniel Bates.
4083
4084         Change loop variables to const references to avoid unnecessary
4085         copies.
4086
4087         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
4088         (-[LocalPasteboard pasteboardItems]):
4089
4090 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
4091
4092         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
4093         https://bugs.webkit.org/show_bug.cgi?id=174816
4094
4095         Reviewed by Michael Catanzaro.
4096
4097         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
4098
4099         * TestWebKitAPI/CMakeLists.txt:
4100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4101         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
4102         (TestWebKitAPI::TEST):
4103         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
4104         (testURIForDisplayUnaffected):
4105         (testURIForDisplayAffected):
4106         (beforeAll):
4107         (afterAll):
4108         * TestWebKitAPI/glib/CMakeLists.txt:
4109
4110 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
4111
4112         [WPE] Add API to notify about frame displayed view backend callback
4113         https://bugs.webkit.org/show_bug.cgi?id=192224
4114
4115         Reviewed by Michael Catanzaro.
4116
4117         Add a test case to check the new API.
4118
4119         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4120         (testWebViewFrameDisplayed):
4121         (beforeAll):
4122         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
4123
4124 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
4125
4126         Unreviewed build fix after r239253
4127
4128         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
4129
4130 2018-12-15  Darin Adler  <darin@apple.com>
4131
4132         Use warning-ignoring macros more consistently and simply
4133         https://bugs.webkit.org/show_bug.cgi?id=192743
4134
4135         Reviewed by Mark Lam.
4136
4137         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4138         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
4139         * DumpRenderTree/mac/TextInputControllerMac.m:
4140         (-[TextInputController interpretKeyEvents:withSender:]): Use
4141         IGNORE_WARNINGS_BEGIN/END.
4142         * WebKitTestRunner/mac/EventSenderProxy.mm:
4143         (WTR::EventSenderProxy::mouseForceClick): Use
4144         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
4145         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
4146         (WTR::EventSenderProxy::mouseForceDown): Ditto.
4147         (WTR::EventSenderProxy::mouseForceUp): Ditto.
4148         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
4149
4150 2018-12-15  Darin Adler  <darin@apple.com>
4151
4152         Replace many uses of String::format with more type-safe alternatives
4153         https://bugs.webkit.org/show_bug.cgi?id=192742
4154
4155         Reviewed by Mark Lam.
4156
4157         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4158         (WTR::cacheTestRunnerCallback): Use makeString.
4159         * WebKitTestRunner/TestController.cpp:
4160         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
4161         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
4162
4163 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
4164
4165         [WPE][GTK] Add libpsl to JHBuild module sets
4166         https://bugs.webkit.org/show_bug.cgi?id=192740
4167
4168         Reviewed by Michael Catanzaro.
4169
4170         * gtk/jhbuild.modules: Add libpsl module.
4171         * wpe/jhbuild.modules: Ditto.
4172
4173 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
4174
4175         Add a style checker rule for Xcode version macros use
4176         https://bugs.webkit.org/show_bug.cgi?id=192703
4177
4178         Reviewed by Alex Christensen.
4179
4180         * Scripts/webkitpy/style/checkers/cpp.py:
4181         (check_os_version_checks):
4182         (process_line):
4183         (CppChecker):
4184         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4185         (WebKitStyleTest.test_os_version_checks):
4186
4187 2018-12-14  Chris Dumez  <cdumez@apple.com>
4188
4189         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
4190         https://bugs.webkit.org/show_bug.cgi?id=192704
4191
4192         Reviewed by Geoffrey Garen.
4193
4194         Extend existing API test to reproduce the problem.
4195
4196         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4197
4198 2018-12-14  Chris Dumez  <cdumez@apple.com>
4199
4200         [PSON] WebsitePolicies are lost on process-swap
4201         https://bugs.webkit.org/show_bug.cgi?id=192694
4202         <rdar://problem/46715748>
4203
4204         Reviewed by Brady Eidson.
4205
4206         Extend existing API test to reproduce the issue.
4207
4208         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4209
4210 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
4211
4212         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
4213         https://bugs.webkit.org/show_bug.cgi?id=192678
4214
4215         Reviewed by Carlos Garcia Campos.
4216
4217         Update our ancient versions of libsoup and glib-networking.
4218
4219         * gtk/install-dependencies:
4220         * gtk/jhbuild.modules:
4221         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
4222         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
4223         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
4224         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
4225         * wpe/install-dependencies:
4226         * wpe/jhbuild.modules:
4227         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
4228
4229 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4230
4231         [WPE] Use new view state API from libwpe
4232         https://bugs.webkit.org/show_bug.cgi?id=191906
4233
4234         Reviewed by Žan Doberšek.
4235
4236         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4237         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
4238         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4239         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
4240         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
4241         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4242         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
4243         wpe_view_activity_state_focused state flags.
4244         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
4245         * wpe/backends/HeadlessViewBackend.cpp:
4246         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
4247         * wpe/backends/WindowViewBackend.cpp:
4248         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
4249         received in configure callback.
4250         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
4251
4252 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
4253
4254         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
4255         https://bugs.webkit.org/show_bug.cgi?id=192688
4256
4257         Reviewed by Ross Kirsling.
4258
4259         * win/DLLLauncher/DLLLauncherMain.cpp:
4260         (copyEnvironmentVariable): Moved.
4261         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
4262         (applePathFromRegistry): Ditto.
4263         (appleApplicationSupportDirectory): Ditto.
4264         (prependPath): Ditto.
4265
4266 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
4267
4268         Unreviewed. Changed my status to a reviewer.
4269
4270         * Scripts/webkitpy/common/config/contributors.json:
4271
4272 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4273
4274         [iOS] Support dropping contact card data (public.vcard) in editable content
4275         https://bugs.webkit.org/show_bug.cgi?id=192570
4276         <rdar://problem/35626913>
4277
4278         Reviewed by Tim Horton.
4279
4280         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4281
4282         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
4283         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
4284         additionally inserts a link).
4285
4286         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4287         (TestWebKitAPI::createMapItemForTesting):
4288         (TestWebKitAPI::createContactItemForTesting):
4289
4290         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
4291         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
4292         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
4293         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
4294         files.
4295