Use a correct LC_RPATH when building with ASan
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
2
3         Use a correct LC_RPATH when building with ASan
4         https://bugs.webkit.org/show_bug.cgi?id=196576
5
6         Reviewed by David Kilzer.
7
8         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
9         so that ../Frameworks is checked. This is simpler and more reliable than updating
10         each SPC service xcconfig.
11
12 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
13
14         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
15         https://bugs.webkit.org/show_bug.cgi?id=196629
16
17         Reviewed by Lucas Forschler.
18
19         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
20
21 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
22
23         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
24         https://bugs.webkit.org/show_bug.cgi?id=196618
25
26         Reviewed by Lucas Forschler.
27
28         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
29         (StatusBubble): Added QUEUE_TRIGGERS.
30         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
31         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
32         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
33         its parent(builder).
34
35 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
36
37         [ews-app] Status-bubble steps are sometimes displayed in reverse order
38         https://bugs.webkit.org/show_bug.cgi?id=196625
39
40         Reviewed by Lucas Forschler.
41
42         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
43         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
44
45 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
46
47         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
48         https://bugs.webkit.org/show_bug.cgi?id=196630
49
50         Reviewed by Wenson Hsieh.
51
52         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
53
54 2019-04-04  Youenn Fablet  <youenn@apple.com>
55
56         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
57         https://bugs.webkit.org/show_bug.cgi?id=196543
58
59         Reviewed by Alex Christensen.
60
61         * WebKitTestRunner/TestController.cpp:
62         (WTR::TestController::generatePageConfiguration):
63
64 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
65
66         [ews-app] Status bubble should not display skipped buildbot steps
67         https://bugs.webkit.org/show_bug.cgi?id=196584
68
69         Reviewed by Lucas Forschler.
70
71         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
72
73 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
74
75         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
76         https://bugs.webkit.org/show_bug.cgi?id=196620
77
78         Reviewed by Lucas Forschler.
79
80         * BuildSlaveSupport/ews-app/ews/config.py:
81
82 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
83
84         [Win] DumpRenderTreeWatchDog.py is not checked into source
85         https://bugs.webkit.org/show_bug.cgi?id=196567
86         <rdar://problem/49525901>
87
88         Reviewed by Lucas Forschler.
89
90         This script is used on Win EWS bots to terminate hanging DRT processes.
91
92         * EWSTools/dumprendertreewatchdog.py: Added.
93
94 2019-04-04  Chris Dumez  <cdumez@apple.com>
95
96         Unreviewed, roll out r243858 which made tests time out.
97
98         Disable new API tests on Windows instead.
99
100         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
101         (TestWebKitAPI::TEST):
102
103 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
104
105         [ATK] Cleanup WebPageAccessibilityObjectAtk
106         https://bugs.webkit.org/show_bug.cgi?id=196537
107
108         Reviewed by Michael Catanzaro.
109
110         Also consider files under atk directories as exceptions for GObject conventions.
111
112         * Scripts/webkitpy/style/checkers/cpp.py:
113         (check_identifier_name_in_declaration):
114
115 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
116
117         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
118         https://bugs.webkit.org/show_bug.cgi?id=196588
119         <rdar://problem/49365787>
120
121         Unreviewed build fix for Windows port.
122
123         error C3861: 'kill': identifier not found
124
125         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
126         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
127
128 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
129
130         [ews-build] Cancel build and similar operations should have authentication
131         https://bugs.webkit.org/show_bug.cgi?id=196520
132
133         Reviewed by Dewei Zhu.
134
135         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
136         environment variables.
137
138 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
139
140         [ews-build] Do not trigger queues which are not in production yet
141         https://bugs.webkit.org/show_bug.cgi?id=196581
142
143         Reviewed by Dewei Zhu.
144
145         * BuildSlaveSupport/ews-build/config.json:
146
147 2019-04-03  Chris Dumez  <cdumez@apple.com>
148
149         Unreviewed, fix typo in the name of API test added in r243848.
150
151         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
152         (TestWebKitAPI::TEST):
153
154 2019-04-03  Chris Dumez  <cdumez@apple.com>
155
156         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
157         https://bugs.webkit.org/show_bug.cgi?id=196588
158         <rdar://problem/49365787>
159
160         Reviewed by Ryosuke Niwa.
161
162         Add API test coverage.
163
164         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
165         (TestWebKitAPI::nullJavaScriptCallback):
166         (TestWebKitAPI::didCrashCheckFrames):
167         (TestWebKitAPI::TEST):
168
169 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
170
171         run-webkit-tests: Upload test results (new results database)
172         https://bugs.webkit.org/show_bug.cgi?id=196577
173         <rdar://problem/34841155>
174
175         Reviewed by Lucas Forschler.
176
177         * Scripts/webkitpy/layout_tests/controllers/manager.py:
178         (Manager.run): Upload results after each device shard, since the configuration will be
179         different for each device.
180         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
181         uploaded to a results database.
182         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
183         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
184
185 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
186
187         -apple-trailing-word is needed for browser detection
188         https://bugs.webkit.org/show_bug.cgi?id=196575
189
190         Unreviewed.
191
192         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
193
194 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
195
196         [CMake][WTF] Mirror XCode header directories
197         https://bugs.webkit.org/show_bug.cgi?id=191662
198
199         Reviewed by Konstantin Tokarev.
200
201         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
202         builds.
203
204         * CMakeLists.txt:
205         * DumpRenderTree/CMakeLists.txt:
206         * DumpRenderTree/PlatformWin.cmake:
207         * MiniBrowser/win/CMakeLists.txt:
208         * TestWebKitAPI/CMakeLists.txt:
209         * TestWebKitAPI/PlatformWin.cmake:
210         * WebKitTestRunner/PlatformGTK.cmake:
211         * WebKitTestRunner/PlatformWin.cmake:
212
213 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
214
215         [ews-app] Status bubble should not display certain infrastructure status messages
216         https://bugs.webkit.org/show_bug.cgi?id=196550
217
218         Reviewed by Lucas Forschler.
219
220         Do not display the steps which are un-needed for end-user. This information is still avaiable
221         if the user click on the bubble and look at the Buildbot build.
222         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
223         (StatusBubble._steps_messages):
224         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
225
226 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
227
228         [ews-build] Use https for sending data to ews-app
229         https://bugs.webkit.org/show_bug.cgi?id=196492
230
231         Reviewed by Lucas Forschler.
232
233         * BuildSlaveSupport/ews-build/events.py:
234
235 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
236
237         Remove support for -apple-trailing-word
238         https://bugs.webkit.org/show_bug.cgi?id=196525
239
240         Reviewed by Zalan Bujtas.
241
242         This CSS property is nonstandard and not used.
243
244         * Scripts/webkitperl/FeatureList.pm:
245         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
246
247 2019-04-03  Youenn Fablet  <youenn@apple.com>
248
249         Add a test for DOMCache on multiple browsing in case of private browsing
250         https://bugs.webkit.org/show_bug.cgi?id=196524
251
252         Reviewed by Alex Christensen.
253
254         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
255         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
256
257 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
258
259         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
260         https://bugs.webkit.org/show_bug.cgi?id=196540
261
262         Reviewed by Aakash Jain.
263
264         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
265
266 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
267
268         Add plumbing for a compatibility mode preference in WebKit
269         https://bugs.webkit.org/show_bug.cgi?id=196005
270
271         Reviewed by Tim Horton.
272
273         Add new API tests.
274
275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
276         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
277
278 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
279
280         [WPE][GTK] Update libsrtp dependency package for Debian
281         https://bugs.webkit.org/show_bug.cgi?id=196528
282
283         Reviewed by Frédéric Wang.
284
285         * gtk/install-dependencies:
286         * wpe/install-dependencies:
287
288 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
289
290         [WK2] Add support for Window's beforeprint / afterprint events
291         https://bugs.webkit.org/show_bug.cgi?id=196478
292         <rdar://problem/49535124>
293
294         Unreviewed build fix for MSVC.
295
296         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
297
298         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
299
300         * WebKitTestRunner/TestController.cpp:
301         (WTR::printFrame): Use int and float literals.
302
303 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
304
305         [ews-build] Reassign bots to queues
306
307         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
308
309 2019-04-02  Chris Dumez  <cdumez@apple.com>
310
311         [WK2] Add support for Window's beforeprint / afterprint events
312         https://bugs.webkit.org/show_bug.cgi?id=196478
313
314         Reviewed by Alex Christensen.
315
316         Add minimal implementation for printFrame in WebKitTestRunner.
317
318         * WebKitTestRunner/TestController.cpp:
319         (WTR::printFrame):
320         (WTR::TestController::createOtherPage):
321         (WTR::TestController::createWebViewWithOptions):
322
323 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
324
325         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
326         https://bugs.webkit.org/show_bug.cgi?id=196491
327
328         Reviewed by Lucas Forschler.
329
330         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
331
332 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
333
334         [ews-build] Configure buildbot try credentials in environment variables
335         https://bugs.webkit.org/show_bug.cgi?id=196501
336
337         Reviewed by Lucas Forschler.
338
339         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
340         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
341         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
342
343 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
344
345         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
346         https://bugs.webkit.org/show_bug.cgi?id=196496
347         <rdar://problem/49521634>
348
349         Reviewed by Chris Dumez.
350
351         Add new API tests (see WebKit ChangeLog for more detail).
352
353         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
354         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
355         (TEST):
356
357 2019-04-02  David Kilzer  <ddkilzer@apple.com>
358
359         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
360         <https://webkit.org/b/196499>
361
362         Reviewed by Alexey Proskuryakov.
363
364         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
365         ENABLE_ADDRESS_SANITIZER.
366
367 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
368
369         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
370         https://bugs.webkit.org/show_bug.cgi?id=182757
371
372         Reviewed by Don Olmstead.
373
374         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
375         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
376
377 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
378
379         run-api-tests: Upload test results
380         https://bugs.webkit.org/show_bug.cgi?id=196323
381         <rdar://problem/49356714>
382
383         Reviewed by Lucas Forschler.
384
385         * Scripts/webkitpy/api_tests/manager.py:
386         (Manager):
387         (Manager.run): Upload results to a results database.
388         * Scripts/webkitpy/api_tests/run_api_tests.py:
389         (parse_args): Add upload arguments.
390         * Scripts/webkitpy/port/base.py:
391         (Port):
392         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
393         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
394         with commits from any other associated repositories.
395         * Scripts/webkitpy/port/device.py:
396         (Device):
397         (Device.build_version): Access build_versoin of underlying platform device.
398         * Scripts/webkitpy/port/ios_simulator_unittest.py:
399         (IOSSimulatorTest):
400         (IOSSimulatorTest.test_configuration_for_upload):
401         * Scripts/webkitpy/port/device_port.py:
402         (DevicePort):
403         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
404         the same as the machine uploading results.
405         * Scripts/webkitpy/port/mac.py:
406         (MacPort):
407         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
408         * Scripts/webkitpy/port/mac_unittest.py:
409         (MacTest):
410         (MacTest.test_configuration_for_upload):
411         * Scripts/webkitpy/xcode/simulated_device.py:
412         (SimulatedDeviceManager._create_device_with_runtime):
413         (SimulatedDevice.__init__): Create simulated device with a build_version.
414         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
415         (test_existing_simulator):
416
417 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
418
419         Remove extra newline characters (Follow-up fix to r243707)
420
421         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
422
423 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
424
425         [ews-app] Use API_KEY to accept results data
426         https://bugs.webkit.org/show_bug.cgi?id=196461
427
428         Reviewed by Dewei Zhu.
429
430         * BuildSlaveSupport/ews-app/ews/views/results.py:
431         (Results.post): Validate EWS_API_KEY before accepting any data.
432         * BuildSlaveSupport/ews-build/events.py:
433         (Events.sendData): Send EWS_API_KEY if available along with event data.
434
435 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
436
437         Unable to copy and paste a PDF from Notes into Mail compose body
438         https://bugs.webkit.org/show_bug.cgi?id=196442
439         <rdar://problem/48573098>
440
441         Reviewed by Tim Horton.
442
443         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
444         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
445         to be specified on the item providers.
446
447         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
448         (TestWebKitAPI::mapItemForTesting):
449         (TestWebKitAPI::contactItemForTesting):
450
451 2019-04-01  Tim Horton  <timothy_horton@apple.com>
452
453         Make UIWKDocumentContext rects per-character instead of per-word
454         https://bugs.webkit.org/show_bug.cgi?id=196459
455
456         Reviewed by Wenson Hsieh.
457
458         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
459         (TEST):
460         Adjust test results due to switching to per-character rects.
461
462 2019-04-01  Chris Dumez  <cdumez@apple.com>
463
464         UIProcess crash when a prewarmed process is terminated
465         https://bugs.webkit.org/show_bug.cgi?id=196451
466         <rdar://problem/49245471>
467
468         Reviewed by Geoffrey Garen.
469
470         Add API test coverage.
471
472         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
473         (TEST):
474
475 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
476
477         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
478         https://bugs.webkit.org/show_bug.cgi?id=196449
479
480         Reviewed by Lucas Forschler.
481
482         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
483         (StatusBubble.get_os_details): Method to get OS and Xcode details.
484         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
485         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
486
487 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
488
489         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
490         https://bugs.webkit.org/show_bug.cgi?id=196444
491
492         Reviewed by Lucas Forschler.
493
494         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
495
496 2019-04-01  Alex Christensen  <achristensen@webkit.org>
497
498         Add SPI to canonicalize NSURLs with WTF::URL
499         https://bugs.webkit.org/show_bug.cgi?id=196415
500         <rdar://problem/44980271>
501
502         Reviewed by Darin Adler.
503
504         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
505         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
506         (TestWebKitAPI::TEST):
507
508 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
509
510         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
511         https://bugs.webkit.org/show_bug.cgi?id=196441
512
513         Reviewed by Carlos Garcia Campos.
514
515         Don't cache the wpe_view_backend object that might not exist yet at the
516         time of EventSenderProxy constructor invocation, but instead retrieve
517         that object whenever it's required for event dispatching. This should
518         avoid crashes in this constructor now that it's invoked before any
519         PlatformWindow has been set up (as changed in r243496).
520
521         * WebKitTestRunner/EventSenderProxy.h:
522         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
523         (WTR::viewBackend):
524         (WTR::EventSenderProxy::EventSenderProxy):
525         (WTR::EventSenderProxy::mouseDown):
526         (WTR::EventSenderProxy::mouseUp):
527         (WTR::EventSenderProxy::mouseMoveTo):
528         (WTR::EventSenderProxy::mouseScrollBy):
529         (WTR::EventSenderProxy::keyDown):
530         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
531
532 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
533
534         [Win][WebKit] MiniBrowser should support high DPI display
535         https://bugs.webkit.org/show_bug.cgi?id=196391
536
537         Reviewed by Alex Christensen.
538
539         * MiniBrowser/win/WebKitBrowserWindow.cpp:
540         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
541         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
542         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
543
544 2019-03-31  Sam Weinig  <weinig@apple.com>
545
546         Remove more i386 specific configurations
547         https://bugs.webkit.org/show_bug.cgi?id=196430
548
549         Reviewed by Alexey Proskuryakov.
550
551         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
552         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
553
554 2019-03-31  Andy Estes  <aestes@apple.com>
555
556         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
557         https://bugs.webkit.org/show_bug.cgi?id=196433
558         <rdar://problem/49293305>
559
560         Reviewed by Tim Horton.
561
562         Enhanced API test coverage to include all navigation response policy decisions in both
563         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
564
565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
566         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
567         (TestWebKitAPI::TEST):
568         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
569         (readFile):
570         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
571         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
572         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
573         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
574         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
575         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
576         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
577         (-[QuickLookDelegate _downloadDidStart:]):
578         (-[QuickLookDelegate _download:didReceiveResponse:]):
579         (-[QuickLookDelegate _download:didReceiveData:]):
580         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
581         (-[QuickLookDelegate _downloadDidFinish:]):
582         (-[QuickLookDelegate _download:didFailWithError:]):
583         (-[QuickLookDelegate _downloadDidCancel:]):
584         (-[QuickLookDelegate verifyDownload]):
585         (runTest):
586         (runTestDecideBeforeLoading):
587         (runTestDecideAfterLoading):
588         (TEST):
589         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
590         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
591         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
592         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
593         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
594         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
595         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
596         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
597         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
598         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
599         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
600         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
601         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
602         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
603
604 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
605
606         [CMake] add testdfg as target with build-jsc
607         https://bugs.webkit.org/show_bug.cgi?id=196393
608
609         Reviewed by Saam Barati.
610
611         Added testdfg as one of the targets to build when
612         using CMake.
613
614         * Scripts/build-jsc:
615
616 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
617
618         Delete WebMetal implementation in favor of WebGPU
619         https://bugs.webkit.org/show_bug.cgi?id=195418
620
621         Reviewed by Dean Jackson.
622
623         * DumpRenderTree/mac/DumpRenderTree.mm:
624         (enableExperimentalFeatures):
625         (resetWebPreferencesToConsistentValues):
626         * Scripts/webkitperl/FeatureList.pm:
627         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
629         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
630         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
631         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
632         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
633         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
634         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
635         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
636         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
637         (WTR::InjectedBundle::beginTesting):
638         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
639         (WTR::TestRunner::setWebMetalEnabled): Deleted.
640         * WebKitTestRunner/InjectedBundle/TestRunner.h:
641
642 2019-03-29  Chris Dumez  <cdumez@apple.com>
643
644         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
645         https://bugs.webkit.org/show_bug.cgi?id=196405
646         <rdar://problem/49428130>
647
648         Reviewed by Wenson Hsieh.
649
650         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
651         the popover presentation methods to be no-ops. Use this in the new test added in
652         r243523 so that we do not swizzle those methods for all tests. This is needed because
653         those WatchOS tests rely on the popover getting presented and interactive.
654
655         * WebKitTestRunner/TestController.cpp:
656         (WTR::updateTestOptionsFromTestHeader):
657         * WebKitTestRunner/TestController.h:
658         * WebKitTestRunner/TestOptions.h:
659         (WTR::TestOptions::hasSameInitializationOptions const):
660         * WebKitTestRunner/ios/TestControllerIOS.mm:
661         (WTR::TestController::platformInitialize):
662         (WTR::TestController::platformResetStateToConsistentValues):
663
664 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
665
666         [Curl] Add Server Trust Evaluation Support.
667         https://bugs.webkit.org/show_bug.cgi?id=191646
668
669         Reviewed by Fujii Hironori.
670
671         Implemented MiniBrowser UI for asking if user trusts the server.
672
673         * MiniBrowser/win/Common.cpp:
674         (askServerTrustEvaluation):
675         (replaceString):
676         * MiniBrowser/win/Common.h:
677         * MiniBrowser/win/MiniBrowserLib.rc:
678         * MiniBrowser/win/MiniBrowserLibResource.h:
679         * MiniBrowser/win/WebKitBrowserWindow.cpp:
680         (createPEMString):
681         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
682         (WebKitBrowserWindow::canTrustServerCertificate):
683         * MiniBrowser/win/WebKitBrowserWindow.h:
684
685 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
686
687         Implement ResizeObserver.
688         https://bugs.webkit.org/show_bug.cgi?id=157743
689
690         Reviewed by Simon Fraser.
691
692         Support resizeObserverEnabled webPreferences.
693
694         * DumpRenderTree/TestOptions.cpp:
695         (TestOptions::TestOptions):
696         * DumpRenderTree/TestOptions.h:
697         * DumpRenderTree/mac/DumpRenderTree.mm:
698         (setWebPreferencesForTestOptions):
699         * DumpRenderTree/win/DumpRenderTree.cpp:
700         (enableExperimentalFeatures):
701         * Scripts/webkitperl/FeatureList.pm:
702         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
703
704 2019-03-28  John Wilander  <wilander@apple.com>
705
706         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
707         https://bugs.webkit.org/show_bug.cgi?id=196281
708         <rdar://problem/48938748>
709
710         Reviewed by Alex Christensen.
711
712         This patch adds the function isStatisticsHasLocalStorage() to the
713         TestRunner. With it, the page can query the WebsiteDataStore in the
714         UI process to make sure that it sees LocalStorage.
715
716         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
717         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
718         (WTR::TestRunner::isStatisticsHasLocalStorage):
719         * WebKitTestRunner/InjectedBundle/TestRunner.h:
720         * WebKitTestRunner/TestController.cpp:
721         (WTR::TestController::isStatisticsHasLocalStorage):
722         * WebKitTestRunner/TestController.h:
723         * WebKitTestRunner/TestInvocation.cpp:
724         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
725
726 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
727
728         API::Data::createWithoutCopying should do a null check before calling CFRelease
729         https://bugs.webkit.org/show_bug.cgi?id=196276
730         <rdar://problem/48059859>
731
732         Reviewed by Alex Christensen.
733
734         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
735
736         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
737         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
738         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
739         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
740         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
741         (TestWebKitAPI::TEST):
742
743 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
744
745         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
746         https://bugs.webkit.org/show_bug.cgi?id=186276
747
748         Reviewed by Carlos Garcia Campos.
749
750         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
751         (webViewLoadChanged):
752         (testWebResourceGetDataError):
753         (testWebResourceGetDataEmpty):
754         (beforeAll):
755         (webViewloadChanged): Deleted.
756
757 2019-03-27  Andy Estes  <aestes@apple.com>
758
759         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
760         https://bugs.webkit.org/show_bug.cgi?id=196317
761
762         Reviewed by Dan Bernstein.
763
764         package-root copies built products into a staging directory using ditto(1), which does not
765         follow symbolic links as it traverses a directory. Now that the files in
766         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
767         itself, these become broken links when ditto'd into the staging directory.
768
769         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
770
771         * Scripts/package-root:
772
773 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
774
775         [ews-app] Update display text of Submit for ews analysis
776         https://bugs.webkit.org/show_bug.cgi?id=196309
777
778         Reviewed by Dewei Zhu.
779
780         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
781
782 2019-03-27  David Kilzer  <ddkilzer@apple.com>
783
784         run-webkit-tests should check for leaks in WebKit processes
785         <https://webkit.org/b/193772>
786         <rdar://problem/46526680>
787
788         Reviewed by Ryosuke Niwa.
789
790         This works by doing the following:
791         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
792           The list of child processes are returned one per line:
793           process.name: pid
794         - Run the "#LIST CHILD PROCESSES" command just before the
795           "#CHECK FOR WORLD LEAKS" command, and store the list of child
796           processes on the ServerProcess object.
797         - When the `--leaks` switch is handled, run check_for_leaks() on
798           each child process after the main test harness.
799
800         * DumpRenderTree/mac/DumpRenderTree.mm:
801         (handleControlCommand):
802         - Use strncmp() instead of strcmp().
803         - Add support for handling "#LIST CHILD PROCESSES" command.
804
805         * Scripts/webkitpy/port/base.py:
806         (Port.check_for_leaks):
807         * Scripts/webkitpy/port/darwin.py:
808         (DarwinPort.check_for_leaks):
809         - Rename redundant 'process_pid' argument to 'process_id'.
810
811         * Scripts/webkitpy/port/driver.py:
812         (Driver.do_post_tests_work):
813         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
814           longer the only command this sends to WebKitTestRunner.
815         - If the `--leaks` switch is present, send the
816           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
817           result using Port.set_webkit_processes().
818         (Driver._parse_child_processes_output):
819         - Add helper method to parse list of child process names and
820           process IDs returned from WebKitTestRunner.
821
822         * Scripts/webkitpy/port/ios_device.py:
823         (IOSDevicePort.check_for_leaks):
824         - Rename redundant 'process_pid' argument to 'process_id'.
825
826         * Scripts/webkitpy/port/leakdetector.py:
827         (LeakDetector._parse_leaks_output):
828         - Return early if there is no leaks_output.
829         (LeakDetector.check_for_leaks):
830         - Rename redundant 'process_pid' argument to 'process_id'.
831
832         * Scripts/webkitpy/port/server_process.py:
833         (ServerProcess.__init__):
834         (ServerProcess.child_processes):
835         (ServerProcess.set_child_processes):
836         - Add instance variable to Port to store list of child process
837           names and process IDs returned from WebKitTestRunner.
838         (ServerProcess._start):
839         - Clear self._child_processes.
840         (ServerProcess.stop):
841         - If self._child_processes is set, call
842           self._port.check_for_leaks() for each child process.
843
844         * Scripts/webkitpy/port/server_process_unittest.py:
845         (TrivialMockPort.check_for_leaks):
846         - Rename redundant 'process_pid' argument to 'process_id'.
847
848         * Scripts/webkitpy/port/simulator_process.py:
849         (SimulatorProcess.stop):
850         - If self._child_processes is set, call
851           self._port.check_for_leaks() for each child process.
852
853         * Scripts/webkitpy/port/watch_device.py:
854         (WatchDevicePort.check_for_leaks):
855         - Rename redundant 'process_pid' argument to 'process_id'.
856
857         * WebKitTestRunner/TestController.cpp:
858         (WTR::TestController::dumpResponse):
859         - Extract method from findAndDumpWorldLeaks() so that it may be
860           reused by findAndDumpWebKitProcessIdentifiers().
861         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
862         - Add method to output process name and process ID of both the
863           WebContent and Networking processes.
864         (WTR::TestController::findAndDumpWorldLeaks):
865         - Fix missing newline in output when there were no abandoned
866           documents.
867         - Call dumpResponse() for extracted code.
868         (WTR::TestController::handleControlCommand):
869         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
870         - Use strncmp() instead of strcmp().
871         - Call findAndDumpWebKitProcessIdentifiers() when
872           "#LIST CHILD PROCESSES" command is sent.
873         * WebKitTestRunner/TestController.h:
874         (WTR::TestController::dumpResponse):
875         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
876         - Declare methods.
877
878 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
879
880         Unreviewed. Add GLib API test cases after r243434.
881
882         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
883         (testWebViewActiveURI):
884         (serverCallback):
885         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
886         (sendRequestCallback):
887
888 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
889
890         Geolocation request not complete when watch request was started in a different web process
891         https://bugs.webkit.org/show_bug.cgi?id=195996
892
893         Reviewed by Alex Christensen.
894
895         Add a test case.
896
897         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
898         (TestWebKitAPI::runJavaScriptAlert):
899         (TestWebKitAPI::TEST):
900
901 2019-03-26  Keith Rollin  <krollin@apple.com>
902
903         Update the way generate-xcfilelists returns strings from functions
904         https://bugs.webkit.org/show_bug.cgi?id=195975
905         <rdar://problem/49040807>
906
907         Reviewed by Dean Jackson.
908
909         There are places where generate-xcfilelists executes assignments with
910         statements like:
911
912             FOO=$(some_function)
913
914         where "some_function" return a string by echoing it. E.g.
915
916             some_function()
917             {
918                 echo "Hello, World"
919             }
920
921         This is a common idiom, but it has a problem if "some_function" needs
922         to call "exit" in an attempt to halt the entire script right then and
923         there. Since "some_function" is called inside of $(), it's being
924         executed in a sub-shell. Calling exit in that sub-shell simply exits
925         that shell; it doesn't not exit the outer shell in which the main part
926         of the script is still running. As such, the main script keeps
927         executing when the intent was for the script to halt.
928
929         The solution to this is to use a different idiom for returning
930         strings. The one we now is to pass in the name of the variable to
931         receive the string result:
932
933             some_function()
934             {
935                 variable_name=$1
936                 eval $variable_name ="Hello, World"
937             }
938
939         The call site now looks like
940
941             some_function FOO
942
943         Because there's no invocation of a sub-shell, some_function can now
944         call "exit" if it wants to, and the entire script will exit at that
945         point.
946
947         * Scripts/generate-xcfilelists:
948
949 2019-03-26  Chris Dumez  <cdumez@apple.com>
950
951         Add basic layout test coverage for File Picker on iOS
952         https://bugs.webkit.org/show_bug.cgi?id=196265
953
954         Reviewed by Wenson Hsieh.
955
956         Add layout test infrastructure to test the file picker on iOS.
957
958         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
959         (WTR::UIScriptController::dismissFilePicker):
960         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
961         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
962         (WTR::UIScriptController::dismissFilePicker):
963         * TestRunnerShared/UIScriptContext/UIScriptController.h:
964         * WebKitTestRunner/TestController.cpp:
965         (WTR::TestController::createWebViewWithOptions):
966         (WTR::updateTestOptionsFromTestHeader):
967         * WebKitTestRunner/TestOptions.h:
968         (WTR::TestOptions::hasSameInitializationOptions const):
969         * WebKitTestRunner/ios/TestControllerIOS.mm:
970         (overridePresentViewController):
971         (WTR::TestController::platformInitialize):
972         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
973         (WTR::UIScriptController::dismissFilePicker):
974
975 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
976
977         Implement async paste method on UIWKInteractionViewProtocol
978         https://bugs.webkit.org/show_bug.cgi?id=196267
979         <rdar://problem/49236346>
980
981         Reviewed by Tim Horton.
982
983         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
984         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
985         are now a part of all iOS 12 internal SDKs.
986
987         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
988
989         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
990         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
991
992         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
993         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
994         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
995         * TestWebKitAPI/ios/UIKitSPI.h:
996
997 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
998
999         [ews-build] Use PostgreSQL for ews.webkit.org database
1000         https://bugs.webkit.org/show_bug.cgi?id=196270
1001
1002         Reviewed by Lucas Forschler.
1003
1004         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1005
1006 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1007
1008         [ews] Reset simctl states on reboot
1009         https://bugs.webkit.org/show_bug.cgi?id=196260
1010
1011         Rubber-stamped by Aakash Jain.
1012
1013         * EWSTools/start-queue-mac.sh:
1014
1015 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1016
1017         [ews-build] Use PostgreSQL for ews-build database
1018         https://bugs.webkit.org/show_bug.cgi?id=196229
1019
1020         Reviewed by Lucas Forschler.
1021
1022         * BuildSlaveSupport/ews-build/master.cfg:
1023
1024 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1025
1026         [ews-build] Get master_hostname dynamically in master.cfg
1027         https://bugs.webkit.org/show_bug.cgi?id=196255
1028
1029         Reviewed by Lucas Forschler.
1030
1031         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1032         send events data in test mode.
1033
1034 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1035
1036         [ews-app] Set db_constraint to False for Foreign Keys
1037         https://bugs.webkit.org/show_bug.cgi?id=196252
1038
1039         Reviewed by Lucas Forschler.
1040
1041         * BuildSlaveSupport/ews-app/ews/models/build.py:
1042         * BuildSlaveSupport/ews-app/ews/models/step.py:
1043
1044 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1045
1046         [ews-build] is_test_mode_enabled should default to True
1047         https://bugs.webkit.org/show_bug.cgi?id=196248
1048
1049         Reviewed by Lucas Forschler.
1050
1051         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1052
1053 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1054
1055         [ews-app] Add webkitperl to ENABLED_QUEUES
1056         https://bugs.webkit.org/show_bug.cgi?id=196253
1057
1058         Reviewed by Lucas Forschler.
1059
1060         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1061
1062 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1063
1064         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1065         https://bugs.webkit.org/show_bug.cgi?id=196211
1066         rdar://problem/49110552
1067
1068         Reviewed by Tim Horton.
1069
1070         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1071         Make sure that EventSenderProxy always exists when running tests. We used to create
1072         it when resetting before the first test, which is a bit too late.
1073
1074         * WebKitTestRunner/TestController.h:
1075         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1076         (WTR::TestController::platformCreateWebView):
1077         (WTR::TestController::platformCreateOtherPage):
1078         (WTR::TestController::finishCreatingPlatformWebView):
1079         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1080         (WTR::PlatformWebView::PlatformWebView):
1081         Moved some code that made NSWindow use NSEvent during web view creation. We may
1082         need to move more if some other case us found, but this is enough for now.
1083
1084 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1085
1086         Unreviewed. Fix typo in GLib geolocation API after r243285.
1087
1088         gelocation -> geolocation.
1089
1090         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1091         (testGeolocationManagerWatchPosition):
1092
1093 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1094
1095         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1096         https://bugs.webkit.org/show_bug.cgi?id=196213
1097
1098         Reviewed by Geoff Garen.
1099
1100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1101         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1102         (credentialWithIdentityAndKeychainPath):
1103         (-[ChallengeDelegate webView:didFinishNavigation:]):
1104         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1105         (TestWebKitAPI::TEST):
1106
1107 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1108
1109         Expected shouldn't assume its contained types are copyable
1110         https://bugs.webkit.org/show_bug.cgi?id=195986
1111
1112         Reviewed by JF Bastien.
1113
1114         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1115         (TestWebKitAPI::NonCopyable::operator== const):
1116         (TestWebKitAPI::NonCopyable::operator!= const):
1117         (TestWebKitAPI::TEST):
1118
1119 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1120
1121         Remove some now-unnecessary dynamic class lookup
1122         https://bugs.webkit.org/show_bug.cgi?id=196237
1123
1124         Reviewed by Simon Fraser.
1125
1126         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1127         (makeRequest):
1128         (TEST):
1129
1130 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1131
1132         Unreviewed, rolling out r243450.
1133
1134         AppleWin and WinCairo port builds get broken.
1135
1136         Reverted changeset:
1137
1138         "Add test for fix of #196095"
1139         https://bugs.webkit.org/show_bug.cgi?id=196097
1140         https://trac.webkit.org/changeset/243450
1141
1142 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1143
1144         Unreviewed, rolling out r243465.
1145         https://bugs.webkit.org/show_bug.cgi?id=196226
1146
1147         the test doesn't build (Requested by thorton on #webkit).
1148
1149         Reverted changeset:
1150
1151         "Do not terminate the NetworkProcess if a third party
1152         application sends a NSCredential with a SecIdentityRef"
1153         https://bugs.webkit.org/show_bug.cgi?id=196213
1154         https://trac.webkit.org/changeset/243465
1155
1156 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1157
1158         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1159         https://bugs.webkit.org/show_bug.cgi?id=196213
1160
1161         Reviewed by Geoff Garen.
1162
1163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1164         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1165         (credentialWithIdentityAndKeychainPath):
1166         (-[ChallengeDelegate webView:didFinishNavigation:]):
1167         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1168         (TestWebKitAPI::TEST):
1169
1170 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1171
1172         [ews-build] Gracefully handle missing patch_id in events
1173         https://bugs.webkit.org/show_bug.cgi?id=196216
1174
1175         Reviewed by Lucas Forschler.
1176
1177         * BuildSlaveSupport/ews-build/events.py:
1178
1179 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1180
1181         [ews-build] use lz4 compression for improving buildbot performance
1182         https://bugs.webkit.org/show_bug.cgi?id=196155
1183
1184         Reviewed by Lucas Forschler.
1185
1186         * BuildSlaveSupport/ews-build/master.cfg:
1187
1188 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1189
1190         Pull some API testing helper methods out of TestWKWebView
1191         https://bugs.webkit.org/show_bug.cgi?id=196212
1192
1193         Reviewed by Tim Horton.
1194
1195         Refactor some more API testing utility methods, so that they can be used in
1196         tests that do not use TestWKWebView.
1197
1198         * TestWebKitAPI/cocoa/TestWKWebView.h:
1199         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1200         (-[WKWebView loadTestPageNamed:]):
1201         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1202         (-[WKWebView synchronouslyLoadHTMLString:]):
1203         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1204         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1205         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1206         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1207         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1208
1209 2019-03-25  Jer Noble  <jer.noble@apple.com>
1210
1211         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1212         https://bugs.webkit.org/show_bug.cgi?id=196097
1213
1214         Reviewed by Eric Carlson.
1215
1216         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1217
1218         * DumpRenderTree/mac/DumpRenderTree.mm:
1219         (resetWebPreferencesToConsistentValues):
1220         * WebKitTestRunner/TestController.cpp:
1221         (WTR::TestController::resetPreferencesToConsistentValues):
1222
1223 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1224
1225         Pull IPadUserInterfaceSwizzler out into a separate header file
1226         https://bugs.webkit.org/show_bug.cgi?id=196193
1227
1228         Reviewed by Anders Carlsson.
1229
1230         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1231         be used in other API tests.
1232
1233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1234         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1235         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1236         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1237         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1238         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1239         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1240
1241 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1242
1243         Remove NavigatorContentUtils in WebCore/Modules
1244         https://bugs.webkit.org/show_bug.cgi?id=196070
1245
1246         Reviewed by Alex Christensen.
1247
1248         NavigatorContentUtils was to support the custom scheme spec [1].
1249         However, in WebKit side, no port has supported the feature in
1250         WebKit layer after EFL port was removed. So there has been the
1251         only IDL implementation of the NavigatorContentUtils in WebCore.
1252         So we don't need to keep the implementation in WebCore anymore.
1253
1254         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1255
1256         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1257
1258 2019-03-24  Andy Estes  <aestes@apple.com>
1259
1260         [watchOS] Remove unused Proximity Networking code
1261         https://bugs.webkit.org/show_bug.cgi?id=196188
1262
1263         Reviewed by Tim Horton.
1264
1265         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1266         (TEST):
1267
1268 2019-03-23  Keith Miller  <keith_miller@apple.com>
1269
1270         Refactor clz/ctz and fix getLSBSet.
1271         https://bugs.webkit.org/show_bug.cgi?id=196162
1272
1273         Reviewed by Saam Barati.
1274
1275         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1276
1277         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1278         (TestWebKitAPI::TEST):
1279
1280 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1281
1282         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1283         https://bugs.webkit.org/show_bug.cgi?id=196143
1284
1285         Reviewed by Michael Catanzaro.
1286
1287         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1288         directories.
1289
1290         * Scripts/webkitpy/style/checkers/cpp.py:
1291         (check_identifier_name_in_declaration):
1292         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1293         (WebKitStyleTest.test_names):
1294
1295 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1296
1297         [Flatpak] Manifest expanding fails for qt WPE extension
1298         https://bugs.webkit.org/show_bug.cgi?id=196148
1299
1300         Reviewed by Alex Christensen.
1301
1302         * flatpak/flatpakutils.py:
1303         (expand_submodules_recurse): The last recurse manifest expand
1304         iteration might lead to a single module so take it into account
1305         and don't try to recurse further.
1306
1307 2019-03-22  Chris Dumez  <cdumez@apple.com>
1308
1309         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1310         https://bugs.webkit.org/show_bug.cgi?id=195348
1311         <rdar://problem/48622090>
1312
1313         Reviewed by Alex Christensen.
1314
1315         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1316         to NO when test.options().shouldIgnoreMetaViewport is false.
1317
1318         * WebKitTestRunner/ios/TestControllerIOS.mm:
1319         (WTR::TestController::platformConfigureViewForTest):
1320
1321 2019-03-22  Chris Dumez  <cdumez@apple.com>
1322
1323         Prewarmed processes should be usable with any website data store
1324         https://bugs.webkit.org/show_bug.cgi?id=196104
1325
1326         Reviewed by Alex Christensen.
1327
1328         Add API test coverage.
1329
1330         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1331         (runInitialWarmedProcessUsedTest):
1332         (TEST):
1333
1334 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1335
1336         Back out local changes to Alex's Subversion working directory
1337
1338         They were accidentally committed.
1339
1340         * Scripts/webkitpy/common/system/abstractexecutive.py:
1341         (AbstractExecutive.wait_newest):
1342         * Scripts/webkitpy/common/system/executive.py:
1343         (Executive.running_pids):
1344         * Scripts/webkitpy/common/system/executive_mock.py:
1345         (MockExecutive.running_pids):
1346         * Scripts/webkitpy/common/system/executive_unittest.py:
1347         (ExecutiveTest.serial_test_running_pids):
1348         * Scripts/webkitpy/port/darwin.py:
1349         (DarwinPort.check_for_leaks):
1350         * Scripts/webkitpy/port/leakdetector.py:
1351         (LeakDetector.check_for_leaks):
1352         - This was the hack attached to Bug 193772.
1353
1354         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1355         (+[WebKitTestRunnerEvent mouseLocation]):
1356         - This works around a crash on an internal build.
1357
1358 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1359
1360         Fix the build after r243354
1361         https://bugs.webkit.org/show_bug.cgi?id=196138
1362         <rdar://problem/49145951>
1363
1364         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1365         (TEST):
1366         * TestWebKitAPI/ios/UIKitSPI.h:
1367
1368 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1369
1370         Adopt UIWKDocumentContext
1371         https://bugs.webkit.org/show_bug.cgi?id=196040
1372         <rdar://problem/48642440>
1373
1374         Reviewed by Ryosuke Niwa.
1375
1376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1377         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1378         (makeRequest):
1379         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1380         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1381         (applyStyle):
1382         (TEST):
1383         Add tests for UIWKDocumentContext.
1384
1385         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1386         (TEST):
1387         (recursiveFindWKContentView): Deleted.
1388         * TestWebKitAPI/cocoa/TestWKWebView.h:
1389         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1390         (recursiveFindWKContentView):
1391         (-[TestWKWebView wkContentView]):
1392         * TestWebKitAPI/ios/UIKitSPI.h:
1393         Share the WKContentView finding code between tests.
1394
1395 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1396
1397         [iOS WK2] Turn on async overflow scrolling by default
1398         https://bugs.webkit.org/show_bug.cgi?id=196011
1399         rdar://problem/48453859
1400
1401         Reviewed by Antti Koivisto.
1402         
1403         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1404         since so many basic layout tests have different results when compositing is triggered for
1405         overflow.
1406         
1407         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1408
1409         * WebKitTestRunner/TestController.cpp:
1410         (WTR::TestController::resetPreferencesToConsistentValues):
1411
1412 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1413
1414         [ews-build] Retry API test in case of failures
1415         https://bugs.webkit.org/show_bug.cgi?id=196004
1416
1417         Reviewed by Lucas Forschler.
1418
1419         * BuildSlaveSupport/ews-build/steps.py:
1420         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1421         (CompileWebKitToT.doStepIf): Ditto.
1422         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1423         (ReRunAPITests): Re-run API tests.
1424         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1425         (RunAPITestsWithoutPatch): Run API tests without patch.
1426         (RunAPITestsWithoutPatch.doStepIf):
1427         (RunAPITestsWithoutPatch.hideStepIf):
1428         (RunAPITestsWithoutPatch.evaluateCommand):
1429         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1430         (AnalyzeAPITestsResults.start):
1431         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1432         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1433         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1434         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1435
1436 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1437
1438         [ews-build] Update queues configurations
1439         https://bugs.webkit.org/show_bug.cgi?id=196074
1440
1441         Reviewed by Dewei Zhu.
1442
1443         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1444         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1445
1446 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1447
1448         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1449         https://bugs.webkit.org/show_bug.cgi?id=195680
1450         <rdar://problem/48903534>
1451
1452         Unreviewed infrastructure fix.
1453
1454         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1455         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1456
1457 2019-03-21  Andy Estes  <aestes@apple.com>
1458
1459         [iOS] Apple Pay should be available in documents with no user agent scripts
1460         https://bugs.webkit.org/show_bug.cgi?id=196061
1461         <rdar://problem/48649391>
1462
1463         Reviewed by Brady Eidson.
1464
1465         Added API tests and related infrastructure.
1466
1467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1468         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1469         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1470         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1471         (TestWebKitAPI::TEST):
1472         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1473         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1474         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1475         * TestWebKitAPI/cocoa/TestProtocol.mm:
1476         (-[TestProtocol startLoading]):
1477         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1478         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1479         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1480         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1481
1482 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1483
1484         REGRESSSION (r243297): webkitpy tests broken
1485         https://bugs.webkit.org/show_bug.cgi?id=196108
1486
1487         Reviewed by Aakash Jain.
1488
1489         r243297 updated contributors.json, which broke a few unit tests.
1490
1491         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1492         (IRCCommandTest.test_whois):
1493         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1494
1495 2019-03-21  Chris Dumez  <cdumez@apple.com>
1496
1497         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1498         https://bugs.webkit.org/show_bug.cgi?id=196041
1499         <rdar://problem/49083230>
1500
1501         Reviewed by Alex Christensen.
1502
1503         Add API test coverage.
1504
1505         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1506         (TEST):
1507
1508 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1509
1510         Add SPI to inform applications of WKContentRuleList actions
1511         https://bugs.webkit.org/show_bug.cgi?id=195965
1512         <rdar://problem/42664365>
1513
1514         Reviewed by Geoff Garen.
1515
1516         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1517         (TestWebKitAPI::allActionsForResourceLoad):
1518         (TestWebKitAPI::testRequest):
1519         (TestWebKitAPI::TEST_F):
1520         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1521         (Notification::description):
1522         (Notification::operator== const):
1523         (toVector):
1524         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1525         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1526         (makeContentRuleList):
1527         (TEST):
1528         (makeWarnContentRuleList): Deleted.
1529
1530 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1531
1532         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1533         https://bugs.webkit.org/show_bug.cgi?id=196088
1534
1535         Reviewed by Brian Burg.
1536
1537         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1538         Support checks when only one platform is specified. Also deprecate macosx() and
1539         force the use of macos() instead.
1540
1541         * Scripts/webkitpy/style/checkers/cpp.py:
1542         (check_min_versions_of_wk_api_available):
1543         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1544         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1545
1546 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1547
1548         Update status inactive committers' status to 'contributor'.
1549
1550         * Scripts/webkitpy/common/config/contributors.json:
1551
1552 2019-03-21  Xan Lopez  <xan@igalia.com>
1553
1554         [JSC][x86] Drop support for x87 floating point
1555         https://bugs.webkit.org/show_bug.cgi?id=194853
1556
1557         Reviewed by Don Olmstead.
1558
1559         Force SSE2 on x86/32bit builds.
1560
1561         * Scripts/webkitdirs.pm:
1562         (generateBuildSystemFromCMakeProject):
1563
1564 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1565
1566         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1567         https://bugs.webkit.org/show_bug.cgi?id=196073
1568
1569         Reviewed by Michael Catanzaro.
1570
1571         Add test cases to check functions and constructors with no arguments but receiving user data.
1572
1573         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1574         (checkUserData):
1575         (testJSCFunction):
1576         (fooCreateWithUserData):
1577         (testJSCClass):
1578
1579 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1580
1581         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1582
1583         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1584
1585         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1586
1587 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1588
1589         [GTK][WPE] Add API to provide geolocation information
1590         https://bugs.webkit.org/show_bug.cgi?id=195940
1591
1592         Reviewed by Michael Catanzaro.
1593
1594         Add a new test to check the new API.
1595
1596         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1597         (testGeolocationManagerCurrentPosition):
1598         (testGeolocationManagerWatchPosition):
1599         (beforeAll):
1600         (afterAll):
1601         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1602         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1603         (beforeAll): Ditto.
1604         * TestWebKitAPI/glib/CMakeLists.txt:
1605
1606 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1607
1608         [GLib] Returning G_TYPE_OBJECT from a method does not work
1609         https://bugs.webkit.org/show_bug.cgi?id=195574
1610
1611         Reviewed by Michael Catanzaro.
1612
1613         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1614
1615         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1616         (getGFile):
1617         (getParent):
1618         (createGString):
1619         (getGString):
1620         (getGStringCopyWillRaise):
1621         (getGStringCopy):
1622         (getGStringStr):
1623         (getGStringLen):
1624         (freeGString):
1625         (testJSCClass):
1626
1627 2019-03-20  Saam Barati  <sbarati@apple.com>
1628
1629         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1630         https://bugs.webkit.org/show_bug.cgi?id=195721
1631
1632         Reviewed by Filip Pizlo.
1633
1634         * Scripts/run-javascriptcore-tests:
1635
1636 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1637
1638         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1639         https://bugs.webkit.org/show_bug.cgi?id=196049
1640
1641         Reviewed by Tim Horton.
1642
1643         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1644         overflow scrolling in general, so rename it.
1645
1646         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1647
1648 2019-03-20  Daniel Bates  <dabates@apple.com>
1649
1650         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1651         https://bugs.webkit.org/show_bug.cgi?id=196031
1652         <rdar://problem/49078172>
1653
1654         Reviewed by Tim Horton.
1655
1656         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1657         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1658         same code path used when the Done button is pressed to dismiss the <select> picker.
1659
1660         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1661         (TestWebKitAPI::TEST):
1662
1663 2019-03-20  Chris Dumez  <cdumez@apple.com>
1664
1665         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1666         https://bugs.webkit.org/show_bug.cgi?id=196029
1667         <rdar://problem/48954651>
1668
1669         Reviewed by Tim Horton.
1670
1671         Add API test coverage.
1672
1673         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1674
1675 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1676
1677         [ews-build] Improve failure summary string for ApplyPatch step
1678         https://bugs.webkit.org/show_bug.cgi?id=195995
1679
1680         Reviewed by Alexey Proskuryakov.
1681
1682         * BuildSlaveSupport/ews-build/steps.py:
1683         (ApplyPatch.getResultSummary): Override getResultSummary.
1684
1685 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1686
1687         AX: Implement support for new meter ARIA role
1688         https://bugs.webkit.org/show_bug.cgi?id=195966
1689
1690         Reviewed by Chris Fleizach.
1691
1692         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1693         to AXLevelIndicator.
1694
1695         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1696
1697 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1698
1699         [WebAuthN] Implement FIDO AppID extension
1700         https://bugs.webkit.org/show_bug.cgi?id=143491
1701         <rdar://problem/48298273>
1702
1703         Reviewed by Brent Fulgham.
1704
1705         Add a test that covers the new flag of convertToU2fSignCommand.
1706
1707         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1708         (TestWebKitAPI::TEST):
1709         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1710         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1711         (TestWebKitAPI::TEST):
1712
1713 2019-03-19  Keith Rollin  <krollin@apple.com>
1714
1715         Add support for more platforms to generate-xcfilelists
1716         https://bugs.webkit.org/show_bug.cgi?id=195977
1717
1718         Reviewed by Alexey Proskuryakov.
1719
1720         generate-xcfilelists incorrectly complains when involved with building
1721         WebKit for iphonesimulator:
1722
1723             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1724             …
1725             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1726
1727         Address this by teaching generate-xcfilelists about more platforms.
1728
1729         * Scripts/generate-xcfilelists:
1730
1731 2019-03-19  John Wilander  <wilander@apple.com>
1732
1733         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1734         https://bugs.webkit.org/show_bug.cgi?id=195923
1735         <rdar://problem/49001272>
1736
1737         Reviewed by Alex Christensen.
1738
1739         This patch does the following to the TestRunner:
1740         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1741         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1742         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1743
1744         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1745         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1746         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1747         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1748         * WebKitTestRunner/TestController.cpp:
1749         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1750         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1751         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1752         * WebKitTestRunner/TestController.h:
1753         * WebKitTestRunner/TestInvocation.cpp:
1754         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1755
1756 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1757
1758         [CMake] Support more clang and gcc sanitizers
1759         https://bugs.webkit.org/show_bug.cgi?id=195956
1760
1761         Reviewed by Michael Catanzaro.
1762
1763         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1764
1765 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1766
1767         [ews-build] Improve summary for PrintConfiguration step
1768         https://bugs.webkit.org/show_bug.cgi?id=195945
1769
1770         Reviewed by Lucas Forschler.
1771
1772         * BuildSlaveSupport/ews-build/steps.py:
1773         (PrintConfiguration.getResultSummary): Override getResultSummary.
1774
1775 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1776
1777         [ews-build] Improve summary for CheckOutSource step
1778         https://bugs.webkit.org/show_bug.cgi?id=195963
1779
1780         Reviewed by Lucas Forschler.
1781
1782         * BuildSlaveSupport/ews-build/steps.py:
1783         (CheckOutSource.getResultSummary):
1784
1785 2019-03-19  Daniel Bates  <dabates@apple.com>
1786
1787         [iOS] Focus not preserved when switching between tabs
1788         https://bugs.webkit.org/show_bug.cgi?id=195820
1789         <rdar://problem/43614450>
1790
1791         Reviewed by Brent Fulgham.
1792
1793         Add tests to ensure that we restore focus when resigning and becoming first responder.
1794
1795         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1796         (TestWebKitAPI::TEST):
1797
1798 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1799
1800         Make WTFLogChannelState and WTFLogLevel enum classes
1801         https://bugs.webkit.org/show_bug.cgi?id=195904
1802
1803         Reviewed by Eric Carlson.
1804
1805         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1806         (TestWebKitAPI::TEST_F):
1807
1808 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1809
1810         [GStreamer][EME] Backported mssdemux protection data crash fix
1811         https://bugs.webkit.org/show_bug.cgi?id=195918
1812
1813         Reviewed by Philippe Normand.
1814
1815         * gstreamer/jhbuild.modules:
1816         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1817
1818 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1819
1820         Unreviewed, rolling out r243132.
1821
1822         Broke GTK build
1823
1824         Reverted changeset:
1825
1826         "Make WTFLogChannelState and WTFLogLevel enum classes"
1827         https://bugs.webkit.org/show_bug.cgi?id=195904
1828         https://trac.webkit.org/changeset/243132
1829
1830 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1831
1832         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1833
1834         * Scripts/webkitdirs.pm:
1835         (builtDylibPathForName): Adjust the shared library name that's changed
1836         with the API version bump in r243073.
1837
1838 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1839
1840         Make WTFLogChannelState and WTFLogLevel enum classes
1841         https://bugs.webkit.org/show_bug.cgi?id=195904
1842
1843         Reviewed by Eric Carlson.
1844
1845         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1846         (TestWebKitAPI::TEST_F):
1847
1848 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1849
1850         Disable flaky test added in r2431100
1851         https://webkit.org/b/195785
1852
1853         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1854         (TestWebKitAPI::TEST):
1855         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1856
1857 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1858
1859         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1860         https://bugs.webkit.org/show_bug.cgi?id=195916
1861
1862         Reviewed by Tim Horton.
1863
1864         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1865         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1866
1867 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1868
1869         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1870
1871         * Scripts/webkitpy/common/config/contributors.json:
1872
1873 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1874
1875         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1876         https://bugs.webkit.org/show_bug.cgi?id=195785
1877
1878         Reviewed by Geoffrey Garen.
1879
1880         * TestWebKitAPI/TCPServer.cpp: Added.
1881         (TestWebKitAPI::TCPServer::TCPServer):
1882         (TestWebKitAPI::TCPServer::~TCPServer):
1883         (TestWebKitAPI::TCPServer::socketBindListen):
1884         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1885         * TestWebKitAPI/TCPServer.h: Added.
1886         (TestWebKitAPI::TCPServer::port const):
1887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1888         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1889         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1890         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1891         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1892         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1893         (TestWebKitAPI::respondSlowly):
1894         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1895         (TestWebKitAPI::downloadAtRate):
1896         (TestWebKitAPI::TEST):
1897
1898 2019-03-18  Saam Barati  <sbarati@apple.com>
1899
1900         Add a plan file for JetStream 2
1901         https://bugs.webkit.org/show_bug.cgi?id=190734
1902
1903         Reviewed by Mark Lam.
1904
1905         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1906
1907 2019-03-18  Chris Dumez  <cdumez@apple.com>
1908
1909         Delay WebProcess launch until a load is triggered in a Web view
1910         https://bugs.webkit.org/show_bug.cgi?id=195758
1911         <rdar://problem/48126013>
1912
1913         Reviewed by Geoff Garen.
1914
1915         Add API test coverage. Also update some existing API tests to not expect
1916         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1917
1918         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1919         (TestWebKitAPI::TEST):
1920         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1921         (TestWebKitAPI::TEST):
1922         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1923         (TEST):
1924         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1925         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1926         (TEST):
1927         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1928         (TEST):
1929         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1930
1931 2019-03-18  Xan Lopez  <xan@igalia.com>
1932
1933         [CMake] Prevent potential warning when determining $architecture
1934         https://bugs.webkit.org/show_bug.cgi?id=195891
1935
1936         Reviewed by Michael Catanzaro.
1937
1938         It's possible for generateBuildSystemForCMakeProject to be called
1939         before determineArchitecture() is ever called. This will make the
1940         first eq check with $architecture to be bogus (and print a
1941         warning). Change that to an eq check with architecture(), which
1942         implicitly calls determineArchitecture() if needed, and change all
1943         the other similar cases in the method in the same way to prevent
1944         future bugs like this one.
1945
1946         * Scripts/webkitdirs.pm:
1947         (generateBuildSystemFromCMakeProject):
1948
1949 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1950
1951         [WPE] Tarballs generated with “make dist” cannot build documentation
1952         https://bugs.webkit.org/show_bug.cgi?id=195885
1953
1954         Reviewed by Carlos Garcia Campos.
1955
1956         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1957
1958 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1959
1960         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1961         https://bugs.webkit.org/show_bug.cgi?id=195883
1962
1963         Reviewed by Carlos Garcia Campos.
1964
1965         * gtkdoc/gtkdoc.py:
1966         (GTKDoc._run_command): When commands fail to run, include the full command line for
1967         the program invocation and the output it has generated on the standard error stream.
1968
1969 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1970
1971         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1972         https://bugs.webkit.org/show_bug.cgi?id=195786
1973
1974         Reviewed by Philippe Normand.
1975
1976         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1977         * wpe/jhbuild.modules: Ditto.
1978
1979 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1980
1981         [ews-build] Don't run clean builds on EWS builders
1982         https://bugs.webkit.org/show_bug.cgi?id=195851
1983
1984         Reviewed by Geoffrey Garen.
1985
1986         * BuildSlaveSupport/ews-build/factories.py:
1987
1988 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1989
1990         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1991         https://bugs.webkit.org/show_bug.cgi?id=195849
1992
1993         Reviewed by Chris Dumez.
1994
1995         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1996
1997         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1998         (runWebsiteDataStoreCustomPaths):
1999
2000 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2001
2002         webkitpy: Upload test results
2003         https://bugs.webkit.org/show_bug.cgi?id=195755
2004         <rdar://problem/48896182>
2005
2006         Reviewed by Aakash Jain.
2007
2008         Establish a new format for uploading results that is not tied to layout tests, apply
2009         that format to webkitpy tests.
2010
2011         * Scripts/webkitpy/common/checkout/scm/git.py:
2012         (Git.native_branch): Return what branch the current checkout is on.
2013         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2014         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2015         * Scripts/webkitpy/common/checkout/scm/svn.py:
2016         (SVN.native_branch): Ditto.
2017         * Scripts/webkitpy/common/system/platforminfo.py:
2018         (PlatformInfo.build_version): Return a build version for Mac.
2019         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2020         (MockPlatformInfo.__init__):
2021         (MockPlatformInfo.build_version):
2022         * Scripts/webkitpy/results: Added.
2023         * Scripts/webkitpy/results/__init__.py: Added.
2024         * Scripts/webkitpy/results/options.py: Added.
2025         (upload_options): OptParse list for upload options.
2026         * Scripts/webkitpy/results/upload.py: Added.
2027         (Upload): Class which enforces the upload format expected by the results server.
2028         (Upload.Expectations):
2029         (Upload.create_configuration):
2030         (Upload.create_commit):
2031         (Upload.create_details):
2032         (Upload.create_run_stats):
2033         (Upload.create_test_result):
2034         (Upload.__init__):
2035         (Upload.Encoder): Encode Upload object as json.
2036         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2037         * Scripts/webkitpy/results/upload_unittest.py: Added.
2038         * Scripts/webkitpy/test/main.py:
2039         (Tester._parse_args): Add upload arguments.
2040         (Tester._run_tests): Allow results to be uploaded.
2041         * Scripts/webkitpy/test/runner.py:
2042         (Runner.__init__): Record which tests were run, rather than just counting them.
2043         (Runner.handle):
2044         * Scripts/webkitpy/test/runner_unittest.py:
2045         (RunnerTest.test_run):
2046         * Scripts/webkitpy/thirdparty/__init__.py:
2047         (AutoinstallImportHook.find_module): Add requests auto-install.
2048         (AutoinstallImportHook._install_requests):
2049         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2050         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2051
2052 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2053
2054         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2055         https://bugs.webkit.org/show_bug.cgi?id=195810
2056
2057         Reviewed by Tim Horton.
2058
2059         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2060         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2061         ending certain layout tests.
2062
2063         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2064         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2065         (-[TestRunnerWKWebView dealloc]):
2066         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2067
2068         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2069         helper method when destroying the web view, and when resetting state between tests.
2070
2071         * WebKitTestRunner/ios/TestControllerIOS.mm:
2072         (WTR::TestController::platformResetStateToConsistentValues):
2073
2074         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2075
2076 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2077
2078         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2079         https://bugs.webkit.org/show_bug.cgi?id=190350
2080         <rdar://problem/45089503>
2081
2082         Reviewed by Geoffrey Garen.
2083
2084         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2085         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2086         (TEST):
2087         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2088         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2089         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2090         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2091         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2092         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2093         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2094         (runTest):
2095         (createDirectories):
2096         (TEST):
2097         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2098         (TEST):
2099         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2100         (TEST):
2101
2102 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2103
2104         Add support to WebPage for getting the contents as an attributed string.
2105         https://bugs.webkit.org/show_bug.cgi?id=195636
2106         rdar://problem/45055697
2107
2108         Reviewed by Tim Horton.
2109
2110         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2111         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2112
2113 2019-03-15  Chris Dumez  <cdumez@apple.com>
2114
2115         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2116         https://bugs.webkit.org/show_bug.cgi?id=195747
2117
2118         Reviewed by Geoff Garen.
2119
2120         Add API test coverage.
2121
2122         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2123
2124 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2125
2126         Unreviewed, rolling out r242952.
2127
2128         Causing API failures on iOS Simulator
2129
2130         Reverted changeset:
2131
2132         "[PSON] Make sure the WebProcessCache is leverage when
2133         relaunching a process after termination"
2134         https://bugs.webkit.org/show_bug.cgi?id=195747
2135         https://trac.webkit.org/changeset/242952
2136
2137 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2138
2139         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2140         https://bugs.webkit.org/show_bug.cgi?id=195740
2141
2142         Reviewed by Ross Kirsling.
2143
2144         window.open doesn't work for WebKitBrowserWindow because it is not
2145         implemented yet.
2146
2147         1. Implemented createNewPage callback of WKPageUIClient.
2148         2. Changed MainWindow to take a BrowserWindow factory function
2149           instead of BrowserWindowType to be flexible to create
2150           BrowserWindow with extra settings.
2151         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2152           because it is not relevant with MainWindow anymore.
2153
2154         * MiniBrowser/win/Common.cpp:
2155         (parseCommandLine):
2156         * MiniBrowser/win/Common.h:
2157         (CommandLineOptions::CommandLineOptions):
2158         * MiniBrowser/win/MainWindow.cpp:
2159         (MainWindow::MainWindow):
2160         (MainWindow::create):
2161         (MainWindow::init):
2162         (MainWindow::WndProc):
2163         * MiniBrowser/win/MainWindow.h:
2164         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2165         (PrintWebUIDelegate::createWebViewWithRequest):
2166         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2167         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2168         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2169         (WebKitBrowserWindow::updateProxySettings):
2170         (WebKitBrowserWindow::createNewPage):
2171         * MiniBrowser/win/WebKitBrowserWindow.h:
2172         * MiniBrowser/win/WinMain.cpp:
2173         (wWinMain):
2174
2175 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2176
2177         Make it possible to test scrolling tree layer manipulation more easily
2178         https://bugs.webkit.org/show_bug.cgi?id=195780
2179
2180         Reviewed by Tim Horton.
2181         
2182         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2183         cuts off communication of scrolling tree scrolls back to the web process
2184         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2185         allows tests to trigger scrolls which run the scrolling tree layer positioning
2186         logic, but never get another commit from the web process that might mask
2187         scrolling tree bugs.
2188         
2189         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2190         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2191         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2192
2193         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2194         (WTR::UIScriptController::scrollUpdatesDisabled const):
2195         (WTR::UIScriptController::setScrollUpdatesDisabled):
2196         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2197         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2198         (WTR::UIScriptController::scrollUpdatesDisabled const):
2199         (WTR::UIScriptController::setScrollUpdatesDisabled):
2200         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2201         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2202         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2203         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2204         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2205         * WebKitTestRunner/ios/TestControllerIOS.mm:
2206         (WTR::TestController::platformResetStateToConsistentValues):
2207         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2208         (WTR::UIScriptController::scrollUpdatesDisabled const):
2209         (WTR::UIScriptController::setScrollUpdatesDisabled):
2210
2211 2019-03-14  Youenn Fablet  <youenn@apple.com>
2212
2213         Move IDB storage in private browsing mode to NetworkProcess
2214         https://bugs.webkit.org/show_bug.cgi?id=195602
2215
2216         Reviewed by Brady Eidson.
2217
2218         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2219         (TEST):
2220
2221 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2222
2223         [ews-build] Make descriptionDone messages more readable
2224         https://bugs.webkit.org/show_bug.cgi?id=195760
2225
2226         Reviewed by Lucas Forschler.
2227
2228         * BuildSlaveSupport/ews-build/steps.py:
2229         * BuildSlaveSupport/ews-build/steps_unittest.py:
2230
2231 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2232
2233         [ews-build] Generate status-bubble hover-over messages
2234         https://bugs.webkit.org/show_bug.cgi?id=195680
2235
2236         Reviewed by Lucas Forschler.
2237
2238         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2239         (StatusBubble):
2240         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2241         on hover-over.
2242         (StatusBubble._iso_time):
2243         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2244         hover-over message.
2245         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2246
2247 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2248
2249         [ews-app] Gracefully handle the case when state_string is None
2250         https://bugs.webkit.org/show_bug.cgi?id=195753
2251
2252         Reviewed by Lucas Forschler.
2253
2254         * BuildSlaveSupport/ews-app/ews/models/build.py:
2255         * BuildSlaveSupport/ews-app/ews/models/step.py:
2256
2257 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2258
2259         [ews-app] Status bubble display pending for currently running build step
2260         https://bugs.webkit.org/show_bug.cgi?id=195744
2261
2262         Reviewed by Lucas Forschler.
2263
2264         * BuildSlaveSupport/ews-build/events.py:
2265         (Events.stepStarted): If state_string is pending, replace it with step name.
2266
2267 2019-03-14  Chris Dumez  <cdumez@apple.com>
2268
2269         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2270         https://bugs.webkit.org/show_bug.cgi?id=195750
2271
2272         Reviewed by Geoffrey Garen.
2273
2274         Add API test coverage.
2275
2276         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2277         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2278         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2279         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2280
2281 2019-03-14  Chris Dumez  <cdumez@apple.com>
2282
2283         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2284         https://bugs.webkit.org/show_bug.cgi?id=195747
2285
2286         Reviewed by Geoff Garen.
2287
2288         Add API test coverage.
2289
2290         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2291
2292 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2293
2294         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2295         https://bugs.webkit.org/show_bug.cgi?id=195725
2296         <rdar://problem/48545062>
2297
2298         Reviewed by Tim Horton.
2299
2300         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2301         handler is nil.
2302
2303         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2304         (TestWebKitAPI::TEST):
2305
2306 2019-03-13  Sam Weinig  <sam@webkit.org>
2307
2308         Add utility function to allow easy reverse range-based iteration of a container
2309         https://bugs.webkit.org/show_bug.cgi?id=195542
2310
2311         Reviewed by Antti Koivisto.
2312
2313         * TestWebKitAPI/CMakeLists.txt:
2314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2315         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2316         (TestWebKitAPI::TEST):
2317         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2318
2319 2019-03-13  Chris Dumez  <cdumez@apple.com>
2320
2321         Use a ServiceWorker process per registrable domain
2322         https://bugs.webkit.org/show_bug.cgi?id=195649
2323
2324         Reviewed by Youenn Fablet.
2325
2326         Update API test coverage.
2327
2328         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2329
2330 2019-03-13  Chris Dumez  <cdumez@apple.com>
2331
2332         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2333         https://bugs.webkit.org/show_bug.cgi?id=195684
2334         <rdar://problem/48294714>
2335
2336         Reviewed by Antti Koivisto.
2337
2338         Add API test coverage.
2339
2340         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2341
2342 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2343
2344         [ews-app] Remove unused patch view
2345         https://bugs.webkit.org/show_bug.cgi?id=195669
2346
2347         Reviewed by Lucas Forschler.
2348
2349         * BuildSlaveSupport/ews-app/ews/urls.py:
2350         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2351
2352 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2353
2354         [ews-app] Use Buildbot result code variables
2355         https://bugs.webkit.org/show_bug.cgi?id=195668
2356
2357         Reviewed by Alexey Proskuryakov.
2358
2359         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2360         (Buildbot): Added Buildbot result code variables.
2361         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2362         (StatusBubble._build_bubble): Used Buildbot result code variables.
2363
2364 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2365
2366         [Flatpak] Expand submodule recursively
2367         https://bugs.webkit.org/show_bug.cgi?id=195672
2368
2369         Building WPE with flatpak was impossible without that as it was raising an exception.
2370         Also update wpebackend-fdo to match what is built in jhbuild
2371
2372         Reviewed by Philippe Normand.
2373
2374         * flatpak/flatpakutils.py:
2375         (expand_submodules_recurse):
2376         (expand_manifest):
2377         * flatpak/org.webkit.WPEModules.yaml:
2378
2379 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2380
2381         [ews-app] status bubble should be hidden for certain builds
2382         https://bugs.webkit.org/show_bug.cgi?id=194597
2383
2384         Reviewed by Dewei Zhu.
2385
2386         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2387         (StatusBubble._build_bubble):
2388         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2389         because the patch didn't have relevant changes.
2390         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2391         in production yet.
2392
2393 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2394
2395         [Win] Fix a slew of simple clang-cl warnings.
2396         https://bugs.webkit.org/show_bug.cgi?id=195652
2397
2398         Reviewed by Don Olmstead.
2399
2400         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2401         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2402
2403 2019-03-12  Justin Fan  <justin_fan@apple.com>
2404
2405         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2406         https://bugs.webkit.org/show_bug.cgi?id=195518
2407         <rdar://problem/46322356>
2408
2409         Reviewed by Myles C. Maxfield.
2410
2411         * DumpRenderTree/DerivedSources-input.xcfilelist:
2412         * DumpRenderTree/DerivedSources-output.xcfilelist:
2413
2414 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2415
2416         Unreviewed, rolling out r242825.
2417         https://bugs.webkit.org/show_bug.cgi?id=195648
2418
2419         "Broke webkitpy tests with my change to
2420         lldb_dump_class_layout.py" (Requested by rmorisset on
2421         #webkit).
2422
2423         Reverted changeset:
2424
2425         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2426         classes with suspicious padding"
2427         https://bugs.webkit.org/show_bug.cgi?id=195573
2428         https://trac.webkit.org/changeset/242825
2429
2430 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2431
2432         [ews-build] Show status bubbles while the patch is waiting in queue
2433         https://bugs.webkit.org/show_bug.cgi?id=195618
2434
2435         Reviewed by Lucas Forschler.
2436
2437         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2438         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2439         enabled in initial deployment.
2440         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2441         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2442         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2443         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2444         (StatusBubble._build_bubbles_for_patch):
2445
2446 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2447
2448         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2449         https://bugs.webkit.org/show_bug.cgi?id=195573
2450
2451         Reviewed by Simon Fraser.
2452
2453         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2454
2455         * Scripts/dump-class-layout:
2456         (main):
2457         * lldb/lldb_dump_class_layout.py:
2458         (ClassLayout.__init__):
2459         (ClassLayout._compute_padding_recursive):
2460         (LLDBDebuggerInstance.dump_layout_for_classname):
2461         (LLDBDebuggerInstance):
2462         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2463         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2464
2465 2019-03-12  Chris Dumez  <cdumez@apple.com>
2466
2467         Device Orientation access permission should be denied unless explicitly granted by the client
2468         https://bugs.webkit.org/show_bug.cgi?id=195625
2469
2470         Reviewed by Youenn Fablet.
2471
2472         add API test coverage.
2473
2474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2475         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2476         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2477         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2478         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2479         (runDeviceOrientationTest):
2480         (TEST):
2481         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2482         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2483
2484 2019-03-12  Jer Noble  <jer.noble@apple.com>
2485
2486         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2487         https://bugs.webkit.org/show_bug.cgi?id=195137
2488         <rdar://problem/48810307>
2489
2490         Reviewed by Eric Carlson.
2491
2492         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2493         (TestWebKitAPI::TEST):
2494
2495 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2496
2497         [ews-build] Change urls from uat to production
2498         https://bugs.webkit.org/show_bug.cgi?id=195566
2499
2500         Reviewed by Lucas Forschler.
2501
2502         * BuildSlaveSupport/ews-app/ews/config.py:
2503         * BuildSlaveSupport/ews-build/events.py:
2504         * BuildSlaveSupport/ews-build/steps.py:
2505
2506 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2507
2508         [ews-build] change max_builds for local-worker to 1
2509         https://bugs.webkit.org/show_bug.cgi?id=195568
2510
2511         Reviewed by Lucas Forschler.
2512
2513         * BuildSlaveSupport/ews-build/loadConfig.py:
2514
2515 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2516
2517         Fix the build
2518
2519         * TestRunnerShared/spi/PencilKitTestSPI.h:
2520         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2521
2522 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2523
2524         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2525         https://bugs.webkit.org/show_bug.cgi?id=194131
2526
2527         Reviewed by Michael Catanzaro.
2528
2529         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2530         (uriChanged):
2531         (testUnfinishedSubresourceLoad):
2532         (serverCallback):
2533         (beforeAll):
2534
2535 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2536
2537         WTF::Expected should use std::addressof instead of operator&
2538         https://bugs.webkit.org/show_bug.cgi?id=195604
2539
2540         Reviewed by Myles Maxfield.
2541
2542         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2543         (TestWebKitAPI::Unique::Unique):
2544         (TestWebKitAPI::Unique::operator&):
2545         (TestWebKitAPI::TEST):
2546
2547 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2548
2549         Add Optional to Forward.h.
2550         https://bugs.webkit.org/show_bug.cgi?id=195586
2551
2552         Reviewed by Darin Adler.
2553
2554         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2555         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2556         Remove unnecessary includes from headers.
2557
2558 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2559
2560         Add testing API to hit-test and scroll overflow scrollers
2561         https://bugs.webkit.org/show_bug.cgi?id=195278
2562
2563         Reviewed by Antti Koivisto.
2564         
2565         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2566         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2567         
2568         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2569
2570         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2571         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2572         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2573         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2574         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2575         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2576         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2577         (WTR::enclosingScrollViewIncludingSelf):
2578         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2579
2580 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2581
2582         API test WebKit.RequestTextInputContext fails on iOS
2583         https://bugs.webkit.org/show_bug.cgi?id=195585
2584
2585         Reviewed by Wenson Hsieh and Simon Fraser.
2586
2587         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2588         (applyStyle):
2589         (TEST):
2590         Add a viewport, so that the coordinates match up on iOS.
2591         Scroll by moving the UIScrollView's contentOffset.
2592
2593 2019-03-11  Chris Dumez  <cdumez@apple.com>
2594
2595         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2596         https://bugs.webkit.org/show_bug.cgi?id=195506
2597         <rdar://problem/48733477>
2598
2599         Reviewed by Alex Christensen.
2600
2601         Add API test coverage.
2602
2603         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2604
2605 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2606
2607         Adding myself to contributors.json
2608
2609         Unreviewed, addming myself to contributors.json .
2610
2611         * Scripts/webkitpy/common/config/contributors.json:
2612
2613 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2614
2615         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2616         https://bugs.webkit.org/show_bug.cgi?id=195511
2617         <rdar://problem/44873269>
2618
2619         Reviewed by Darin Adler.
2620
2621         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2622         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2623         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2624         (TEST_F):
2625
2626 2019-03-11  Chris Dumez  <cdumez@apple.com>
2627
2628         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2629         https://bugs.webkit.org/show_bug.cgi?id=195561
2630
2631         Reviewed by Youenn Fablet.
2632
2633         Make sure the JS in the test requests for permission to receive device orientation events.
2634
2635         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2636
2637 2019-03-11  Youenn Fablet  <youenn@apple.com>
2638
2639         Allow storage quota increase by default in WTR
2640         https://bugs.webkit.org/show_bug.cgi?id=195541
2641
2642         Reviewed by Geoffrey Garen.
2643
2644         Allow storage quota increase by default in WTR.
2645         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2646         Use this for tests that explicitly need cache increase.
2647
2648         Instead of increasing quota by 2, make sure the next request is
2649         granted by adding all given parameters.
2650
2651         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2652         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2653         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2654         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2655         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2656         * WebKitTestRunner/TestController.cpp:
2657         (WTR::TestController::setAllowStorageQuotaIncrease):
2658         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2659         * WebKitTestRunner/TestController.h:
2660         * WebKitTestRunner/TestInvocation.cpp:
2661         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2662         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2663         (WTR::TestController::cocoaResetStateToConsistentValues):
2664         (WTR::TestController::setAllowStorageQuotaIncrease):
2665         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2666         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2667         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2668
2669 2019-03-11  Xan Lopez  <xan@igalia.com>
2670
2671         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2672         https://bugs.webkit.org/show_bug.cgi?id=194147
2673
2674         Reviewed by Michael Saboff.
2675
2676         To make --32-bit work correctly on Linux/64bit we need to:
2677
2678         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2679         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2680         unfortunately CMake only allows us to do this during
2681         crosscompilation, which is overkill here.
2682         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2683         pkg-config detection module uses the x86 .pc files instead of the
2684         x86_64 ones.
2685         - Set the -m32 flags for the compiler.
2686
2687         * Scripts/webkitdirs.pm:
2688         (generateBuildSystemFromCMakeProject):
2689
2690 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2691
2692         Add MotionMark-1.1 plan file for run-benchmark script.
2693         https://bugs.webkit.org/show_bug.cgi?id=195481
2694
2695         Rubber-stamped by Darin Adler.
2696
2697         Run-benchmark script should support MontionMark-1.1.
2698
2699         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2700
2701 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2702
2703         [ews-app] Add support for submit-to-ews url
2704         https://bugs.webkit.org/show_bug.cgi?id=195477
2705
2706         Reviewed by Lucas Forschler.
2707
2708         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2709         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2710         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2711         * BuildSlaveSupport/ews-app/ews/urls.py:
2712         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2713
2714 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2715
2716         Unreviewed, rolling out r242688, r242643, r242624.
2717
2718         Caused multiple layout test failures and crashes on iOS and macOS.
2719
2720         Reverted changeset:
2721
2722         "requestAnimationFrame should execute before the next frame"
2723         https://bugs.webkit.org/show_bug.cgi?id=177484
2724         https://trac.webkit.org/changeset/242624/webkit
2725
2726         * Tracing/SystemTracePoints.plist:
2727
2728 2019-03-11  John Wilander  <wilander@apple.com>
2729
2730         Resource Load Statistics: Make it possible exclude localhost from classification
2731         https://bugs.webkit.org/show_bug.cgi?id=195474
2732         <rdar://problem/47520577>
2733
2734         Reviewed by Brent Fulgham.
2735
2736         This patch allows for localhost to be excluded from classification and
2737         treatment as a prevalent resource.
2738
2739         The WebKit Tools change adds a new function called
2740         testRunner.setStatisticsIsRunningTest() which can be used to control this
2741         behavior.
2742
2743         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2744         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2745         (WTR::TestRunner::setStatisticsIsRunningTest):
2746         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2747         * WebKitTestRunner/TestController.cpp:
2748         (WTR::TestController::setStatisticsIsRunningTest):
2749         * WebKitTestRunner/TestController.h:
2750         * WebKitTestRunner/TestInvocation.cpp:
2751         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2752
2753 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2754
2755         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2756         https://bugs.webkit.org/show_bug.cgi?id=195560
2757
2758         Reviewed by Lucas Forschler.
2759
2760         * BuildSlaveSupport/ews-build/master.cfg:
2761
2762 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2763
2764         Unreviewed, rolling out r242698.
2765
2766         API test crashes on bots.
2767
2768         Reverted changeset:
2769
2770         "Add a WKContentRuleList variant that uses copied memory
2771         instead of mmap'd shared memory for class A containerized
2772         apps"
2773         https://bugs.webkit.org/show_bug.cgi?id=195511
2774         https://trac.webkit.org/changeset/242698
2775
2776 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2777
2778         [WPE] Enable web process sandbox
2779         https://bugs.webkit.org/show_bug.cgi?id=195169
2780
2781         Reviewed by Daniel Bates.
2782
2783         * wpe/install-dependencies:
2784         * wpe/jhbuild.modules:
2785
2786 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2787
2788         [ews-app] Use port 17000 for worker communication
2789         https://bugs.webkit.org/show_bug.cgi?id=195558
2790
2791         Reviewed by Lucas Forschler.
2792
2793         * BuildSlaveSupport/ews-build/master.cfg:
2794
2795 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2796
2797         [ews-build] unit-tests fail when passwords.json is missing
2798         https://bugs.webkit.org/show_bug.cgi?id=195557
2799
2800         Reviewed by Lucas Forschler.
2801
2802         * BuildSlaveSupport/ews-build/loadConfig.py:
2803         (loadBuilderConfig):
2804         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2805         (ConfigDotJSONTest.test_configuration):
2806         * BuildSlaveSupport/ews-build/master.cfg:
2807
2808 2019-03-11  Truitt Savell  <tsavell@apple.com>
2809
2810         Unreviewed, rolling out r242702.
2811
2812         Broke High Sierra builders.
2813
2814         Reverted changeset:
2815
2816         "Add utility function to allow easy reverse range-based
2817         iteration of a container"
2818         https://bugs.webkit.org/show_bug.cgi?id=195542
2819         https://trac.webkit.org/changeset/242702
2820
2821 2019-03-11  Sam Weinig  <sam@webkit.org>
2822
2823         Add utility function to allow easy reverse range-based iteration of a container
2824         https://bugs.webkit.org/show_bug.cgi?id=195542
2825
2826         Reviewed by Antti Koivisto.
2827
2828         * TestWebKitAPI/CMakeLists.txt:
2829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2830         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2831         (TestWebKitAPI::TEST):
2832         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2833
2834 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2835
2836         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2837         https://bugs.webkit.org/show_bug.cgi?id=195511
2838         <rdar://problem/44873269>
2839
2840         Reviewed by Darin Adler.
2841
2842         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2843         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2844         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2845         (TEST_F):
2846
2847 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2848
2849         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2850         https://bugs.webkit.org/show_bug.cgi?id=195499
2851
2852         Reviewed by Darin Adler.
2853
2854         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2855         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2856         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2857         (-[WKWebView synchronouslyFocusTextInputContext:]):
2858         (applyStyle):
2859         (applyIframe):
2860         (TEST):
2861         Add some tests for this SPI.
2862
2863 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2864
2865         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2866         https://bugs.webkit.org/show_bug.cgi?id=181151
2867
2868         Reviewed by Don Olmstead.
2869
2870         * TestWebKitAPI/CMakeLists.txt:
2871         * TestWebKitAPI/PlatformWin.cmake:
2872         Enable TestWTF RunLoop tests in all platforms.
2873
2874         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2875         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2876         (TestWebKitAPI::DerivedOneShotTimer::fired):
2877         (TestWebKitAPI::TEST):
2878         Only a few platforms support nested RunLoop.
2879
2880         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2881         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2882
2883 2019-03-10  David Quesada  <david_quesada@apple.com>
2884
2885         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2886         https://bugs.webkit.org/show_bug.cgi?id=152480
2887
2888         Reviewed by Chris Dumez.
2889
2890         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2891         there are no additional references to the process pool besides the one held by
2892         the download, waits for the download to finish (in the sense that the
2893         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2894         measure, also check that the process pool has been deallocated at the end of the
2895         test. The test wouldn't be meaningful if the process pool were still alive.
2896
2897         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2898         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2899         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2900             The download will be canceled because the delegate does not implement the
2901             method to decide the download's destination, so this is where we know the
2902             DownloadProxyMap is done with the DownloadProxy.
2903         (TEST):
2904
2905 2019-03-08  Chris Dumez  <cdumez@apple.com>
2906
2907         Add support for Device Orientation / Motion permission API
2908         https://bugs.webkit.org/show_bug.cgi?id=195329
2909         <rdar://problem/47645367>
2910
2911         Reviewed by Geoffrey Garen.
2912
2913         Add test infrastructure to help test the Device Orientation / Motion permission API.
2914
2915         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2916         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2917         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2918         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2919         * WebKitTestRunner/TestController.cpp:
2920         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2921         (WTR::TestController::createWebViewWithOptions):
2922         (WTR::TestController::resetStateToConsistentValues):
2923         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2924         * WebKitTestRunner/TestController.h:
2925         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2926         * WebKitTestRunner/TestInvocation.cpp:
2927         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2928
2929 2019-03-08  Saam barati  <sbarati@apple.com>
2930
2931         Add a compare-results script to compare benchmark results
2932         https://bugs.webkit.org/show_bug.cgi?id=195486
2933         <rdar://problem/48723397>
2934
2935         Reviewed by Geoffrey Garen.
2936
2937         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2938         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2939         to extend it to learn about our other benchmarks.
2940
2941         * Scripts/compare-results: Added.
2942         (readJSONFile):
2943         (detectJetStream2):
2944         (JetStream2Results):
2945         (detectSpeedometer2):
2946         (Speedometer2Results):
2947         (detectPLT5):
2948         (PLT5Results):
2949         (detectBenchmark):
2950         (biggerIsBetter):
2951         (ttest):
2952         (getOptions):
2953         (main):
2954
2955 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2956
2957         Ensure old tab state is cleared between iterations of run-benchmark
2958         https://bugs.webkit.org/show_bug.cgi?id=195393
2959         <rdar://problem/46885583>
2960
2961         Reviewed by Dewei Zhu.
2962
2963         a) ensure the default to restore state is not set
2964         b) terminate Safari correctly
2965         c) Set the system default to ignore Persistent State in Safari
2966
2967         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2968         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2969         (OSXBrowserDriver.prepare_env): 
2970         (OSXBrowserDriver.restore_env):
2971         (OSXBrowserDriver.close_browsers):
2972         (OSXBrowserDriver._terminate_processes):
2973         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2974         (OSXChromeDriver):
2975         (OSXChromeCanaryDriver):
2976         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2977         (OSXFirefoxDriver):
2978         (OSXFirefoxNightlyDriver):
2979         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2980         (OSXSafariDriver):
2981         (OSXSafariDriver.prepare_env):
2982
2983 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2984
2985         [GTK] Several InputMethodFilter tests are failing
2986         https://bugs.webkit.org/show_bug.cgi?id=195408
2987
2988         Reviewed by Carlos Garcia Campos.
2989
2990         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2991         Regressed in r241751.
2992         Hexadecimal values of keycodes are expressed now in upper letters.
2993         Composited characters should be cast to UTF8 strings.
2994
2995         (TestWebKitAPI::TEST):
2996
2997 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2998
2999         [GTK] Make Tools/gtkdoc python3 compatible
3000         https://bugs.webkit.org/show_bug.cgi?id=195359
3001
3002         Reviewed by Carlos Garcia Campos.
3003
3004         * gtkdoc/generate-gtkdoc:
3005         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3006         work with Python 2 and 3.
3007         (get_gtkdoc_module_paths):
3008         The iteritems() was removed in Python 3, so let's use items() that's
3009         available in Python 2 and 3.
3010         (get_generator_for_config):
3011         * gtkdoc/gtkdoc.py:
3012         (GTKDoc._run_command):
3013         The sys.stdout.write() is expecting str in Python 3 and not bytes
3014         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3015         for passing the bytes there.
3016
3017 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3018
3019         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3020         https://bugs.webkit.org/show_bug.cgi?id=195346
3021         <rdar://problem/48667048>
3022
3023         Unreviewed build fix for clang-cl.
3024
3025         * DumpRenderTree/win/DumpRenderTree.cpp:
3026         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3027
3028 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3029
3030         requestAnimationFrame should execute before the next frame
3031         https://bugs.webkit.org/show_bug.cgi?id=177484
3032
3033         Reviewed by Simon Fraser.
3034
3035         Add trace points for the page RenderingUpdate.
3036
3037         * Tracing/SystemTracePoints.plist:
3038
3039 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3040
3041         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3042         https://bugs.webkit.org/show_bug.cgi?id=195353
3043         <rdar://problem/48626394>
3044
3045         Reviewed by Simon Fraser.
3046
3047         * WebKitTestRunner/ios/TestControllerIOS.mm:
3048         (WTR::TestController::platformResetPreferencesToConsistentValues):
3049
3050 2019-03-07  John Wilander  <wilander@apple.com>
3051
3052         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3053         https://bugs.webkit.org/show_bug.cgi?id=195383
3054         <rdar://problem/48570136>
3055
3056         Reviewed by Brent Fulgham.
3057
3058         This patch adds test infrastructure to purge only script-accessible cookies,
3059         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3060
3061         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3062         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3063         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3064         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3065         * WebKitTestRunner/TestController.cpp:
3066         (WTR::TestController::statisticsDeleteCookiesForHost):
3067         * WebKitTestRunner/TestController.h:
3068         * WebKitTestRunner/TestInvocation.cpp:
3069         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3070
3071 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3072
3073         Unreviewed, rolling out r242354.
3074         https://bugs.webkit.org/show_bug.cgi?id=195402
3075
3076         breaks layout tests in all configurations (Requested by
3077         zdobersek on #webkit).
3078
3079         Reverted changeset:
3080
3081         "[WPE] Enable web process sandbox"
3082         https://bugs.webkit.org/show_bug.cgi?id=195169
3083         https://trac.webkit.org/changeset/242354
3084
3085 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3086
3087         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3088         https://bugs.webkit.org/show_bug.cgi?id=195346
3089
3090         Reviewed by Fujii Hironori.
3091
3092         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3093         (TestWebKitAPI::TEST):
3094         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3095
3096         * DumpRenderTree/win/DumpRenderTree.cpp:
3097         (findFontFallback):
3098         (addFontFallbackIfPresent):
3099         (removeFontFallbackIfPresent):
3100         (main):
3101         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3102         (TestWebKitAPI::Util::moduleDirectory):
3103         (TestWebKitAPI::Util::createInjectedBundlePath):
3104         Use wchar helpers as needed.
3105
3106 2019-03-06  Rob Buis  <rbuis@igalia.com>
3107
3108         Consider supporting the `referrerpolicy` attribute.
3109         https://bugs.webkit.org/show_bug.cgi?id=179053
3110
3111         Reviewed by Darin Adler.
3112
3113         Add a runtime flag for referrerpolicy attribute.
3114
3115         * DumpRenderTree/mac/DumpRenderTree.mm:
3116         (enableExperimentalFeatures):
3117
3118 2019-03-05  Daniel Bates  <dabates@apple.com>
3119
3120         Update expected API test result following r242379
3121         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3122
3123         Update expected x-coordinate of selection rect now that the left padding of
3124         a textarea is sized in ems (so dependent on the font size) just like the left
3125         padding of a text field.
3126
3127         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3128         (TestWebKitAPI::TEST):
3129
3130 2019-03-05  David Quesada  <david_quesada@apple.com>
3131
3132         [WK2] It should be possible to follow links with 'download' attributes
3133         https://bugs.webkit.org/show_bug.cgi?id=195145
3134         rdar://problem/48462642
3135
3136         Reviewed by Alex Christensen.
3137
3138         Add a unit test to verify that activating links with 'download' attributes now
3139         navigates to the linked resource, rather than starts downloading it. Add another
3140         to verify that it is still possible to explicitly download the link via the
3141         'Download' navigation action policy.
3142
3143         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3144         (-[DownloadAttributeTestDelegate init]):
3145         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3146         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3147         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3148         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3149         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3150         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3151         (TEST):
3152         * WebKitTestRunner/TestController.cpp:
3153         (WTR::TestController::decidePolicyForNavigationAction):
3154         * WebKitTestRunner/TestController.h:
3155
3156 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3157
3158         [Curl] Implement Cookie Accept Policy.
3159         https://bugs.webkit.org/show_bug.cgi?id=191645
3160
3161         Reviewed by Fujii Hironori.
3162
3163         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3164         (TestWebKitAPI::Curl::TEST_F):
3165
3166 2019-03-05  Youenn Fablet  <youenn@apple.com>
3167
3168         Rename requestCacheStorageSpace to requestStorageSpace
3169         https://bugs.webkit.org/show_bug.cgi?id=195282
3170
3171         Reviewed by Chris Dumez.
3172
3173         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3174         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3175         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3176
3177 2019-03-05  Brady Eidson  <beidson@apple.com>
3178
3179         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3180         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3181
3182         Reviewed by Tim Horton.
3183
3184         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3185         different directory into that same WKWebView should work.
3186
3187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3188         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3189
3190 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3191
3192         Add WeakHashSet
3193         https://bugs.webkit.org/show_bug.cgi?id=195152
3194
3195         Reviewed by Antti Koivisto.
3196
3197         Added tests for WeakHashSet.
3198
3199         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3200         (TestWebKitAPI::Base::Base): Moved.
3201         (TestWebKitAPI::Derived::foo): Moved.
3202         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3203         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3204         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3205         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3206
3207 2019-03-04  Chris Dumez  <cdumez@apple.com>
3208
3209         Do not share WebProcesses between private and regular sessions
3210         https://bugs.webkit.org/show_bug.cgi?id=195189
3211         <rdar://problem/48421064>
3212
3213         Reviewed by Alex Christensen.
3214
3215         Add API test coverage.
3216
3217         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3218         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3219
3220 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3221
3222         [WPE] Enable web process sandbox
3223         https://bugs.webkit.org/show_bug.cgi?id=195169
3224
3225         Reviewed by Daniel Bates.
3226
3227         * wpe/install-dependencies:
3228         * wpe/jhbuild.modules:
3229
3230 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3231
3232         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3233         https://bugs.webkit.org/show_bug.cgi?id=195206
3234
3235         Reviewed by Žan Doberšek.
3236
3237         Add a new test case.
3238
3239         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3240         (testJSCClass):
3241
3242 2019-03-04  Charlie Turner  <cturner@igalia.com>
3243
3244         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3245         https://bugs.webkit.org/show_bug.cgi?id=194898
3246
3247         Reviewed by Žan Doberšek.
3248
3249         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3250         a GCC extension that permits arithmetic on void* pointer. Inline
3251         the macro until this issue is fixed upstream.
3252
3253 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3254
3255         Rid the world of WK_API_ENABLED
3256         https://bugs.webkit.org/show_bug.cgi?id=195263
3257
3258         Reviewed by Dan Bernstein.
3259
3260         List of changed files elided because it's useless.
3261
3262 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3263
3264         Unreviewed follow-up to r242292.
3265
3266         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3267
3268         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3269         (TestWebKitAPI::testStrip): Renamed from strip.
3270         (TestWebKitAPI::TEST):
3271
3272 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3273
3274         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3275
3276         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3277         and bug #194272 for details.
3278
3279         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3280
3281 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3282
3283         Remove some more unused 32-bit code
3284         https://bugs.webkit.org/show_bug.cgi?id=195255
3285
3286         Reviewed by Darin Adler.
3287
3288         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3289         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3290         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3291         (NPP_New):
3292         (NPP_HandleEvent):
3293         (handleEventCarbon): Deleted.
3294
3295 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3296
3297         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3298
3299         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3300         (TestWebKitAPI::TEST):
3301
3302 2019-03-01  Darin Adler  <darin@apple.com>
3303
3304         Finish removing String::format
3305         https://bugs.webkit.org/show_bug.cgi?id=194893
3306
3307         Reviewed by Daniel Bates.
3308 '
3309         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3310
3311 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3312
3313         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3314         https://bugs.webkit.org/show_bug.cgi?id=195229
3315         <rdar://problem/48520362>
3316
3317         Reviewed by Chris Dumez.
3318
3319         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3320         (TEST):
3321
3322 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3323
3324         Add a system trace scope for event region building
3325         https://bugs.webkit.org/show_bug.cgi?id=195226
3326
3327         Reviewed by Jon Lee.
3328
3329         This trace scope measures the time spend converting element rects into Region objects,
3330         which can be large on some pages.
3331
3332         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3333
3334         * Tracing/SystemTracePoints.plist:
3335
3336 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3337
3338         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3339         https://bugs.webkit.org/show_bug.cgi?id=194612
3340
3341         Reviewed by Alex Christensen.
3342
3343         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3344         Just test the new string-processing function and don't touch the actual environment.
3345         (Test cases are all as before, but based on operator== instead of strcmp.)
3346
3347 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3348
3349         [ews-app] Update primary keys for handling multiple Buildbot instances
3350         https://bugs.webkit.org/show_bug.cgi?id=195120
3351
3352         Reviewed by Stephanie Lewis.
3353
3354         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3355         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3356         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3357
3358         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3359         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3360         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3361         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3362         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3363         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3364
3365 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3366
3367         [WinCairo] Enable service worker
3368         https://bugs.webkit.org/show_bug.cgi?id=188318
3369
3370         Reviewed by Youenn Fablet.
3371
3372         * DumpRenderTree/DumpRenderTreePrefix.h:
3373         * TestWebKitAPI/PlatformWin.cmake:
3374         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3375         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3376         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3377
3378 2019-03-01  Justin Fan  <justin_fan@apple.com>
3379
3380         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3381         https://bugs.webkit.org/show_bug.cgi?id=195191
3382
3383         Rubber-stamped by Dean Jackson.
3384
3385         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3386
3387         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3388
3389 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3390
3391         Unreviewed, fix lldb webkitpy tests
3392         https://bugs.webkit.org/show_bug.cgi?id=194375
3393
3394         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3395
3396         * lldb/lldb_webkit.py:
3397         (WTFStringImplProvider.is_8bit):
3398
3399 2019-02-28  David Quesada  <david_quesada@apple.com>
3400
3401         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3402         https://bugs.webkit.org/show_bug.cgi?id=195121
3403         rdar://problem/48450302
3404
3405         Reviewed by Alex Christensen.
3406
3407         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3408         configurations where the 'download' attribute is absent, blank, or populated
3409         with a filename, and where the anchor element is same-origin or cross-origin
3410         (meaning the 'download' attribute shouldn't be honored).
3411
3412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3413         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3414         (-[NavigationActionTestDelegate init]):
3415         (-[NavigationActionTestDelegate navigationAction]):
3416         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3417         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3418         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3419         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3420         (TEST):
3421
3422 2019-02-28  Antoine Quint  <graouts@apple.com>
3423
3424         Enable the Pointer Events runtime flag by default
3425         https://bugs.webkit.org/show_bug.cgi?id=195156
3426
3427         Reviewed by Dean Jackson.
3428
3429         * DumpRenderTree/mac/DumpRenderTree.mm:
3430         (enableExperimentalFeatures):
3431
3432 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3433
3434         Several PasteImage API tests are flaky
3435         https://bugs.webkit.org/show_bug.cgi?id=195160
3436
3437         Reviewed by Tim Horton.
3438
3439         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3440         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3441         listening for a "load" event after image load is already complete.
3442
3443         To address this, make these tests first register a "load" event handler, then run script to insert an image
3444         element into the document, and finally wait until the load event is observed before checking image size.
3445
3446         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3447
3448 2019-02-28  Chris Dumez  <cdumez@apple.com>
3449
3450         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3451         https://bugs.webkit.org/show_bug.cgi?id=195107
3452
3453         Reviewed by Alex Christensen.
3454
3455         Give some time for the zoom level to get restored.
3456
3457         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3458
3459 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3460
3461         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3462         https://bugs.webkit.org/show_bug.cgi?id=194958
3463
3464         Reviewed by Geoffrey Garen.
3465
3466         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3467         (TEST):
3468
3469 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3470
3471         [ews-app] Update method to save build to handle builder_display_name
3472         https://bugs.webkit.org/show_bug.cgi?id=195047
3473
3474         Reviewed by Dewei Zhu.
3475
3476         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3477         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3478
3479 2019-02-28  Justin Fan  <justin_fan@apple.com>
3480
3481         [Web GPU] Enable Web GPU only on 64-bit
3482         https://bugs.webkit.org/show_bug.cgi?id=195139
3483
3484         Because Metal is only supported on 64 bit apps.
3485
3486         Unreviewed build fix.
3487
3488         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3489
3490 2019-02-27  Youenn Fablet  <youenn@apple.com>
3491
3492         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3493         https://bugs.webkit.org/show_bug.cgi?id=194959
3494
3495         Reviewed by Chris Dumez.
3496
3497         Spin loop until getting the condition to remove flakiness.
3498
3499         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3500
3501 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3502
3503         [ews-build] Buildbot should include builder_display_name in the build events
3504         https://bugs.webkit.org/show_bug.cgi?id=195045
3505
3506         Reviewed by Dewei Zhu.
3507
3508         * BuildSlaveSupport/ews-build/events.py:
3509         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3510         buildername to builder_name to be consistent in naming style.
3511         (Events.buildFinished): Ditto.
3512
3513 2019-02-27  Chris Dumez  <cdumez@apple.com>
3514
3515         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3516         https://bugs.webkit.org/show_bug.cgi?id=194480
3517
3518         Reviewed by Brady Eidson.
3519
3520         Update existing API test to make it more likely to reproduce the issue.
3521
3522         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3523
3524 2019-02-27  Brady Eidson  <beidson@apple.com>
3525
3526         Universal links from Google search results pages don't open the app.
3527         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3528
3529         Reviewed by Geoffrey Garen.
3530
3531         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3532         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3533         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3534         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3535
3536 2019-02-27  Chris Dumez  <cdumez@apple.com>
3537
3538         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3539         https://bugs.webkit.org/show_bug.cgi?id=195102
3540
3541         Reviewed by Geoffrey Garen.
3542
3543         If the number of processes is not yet what we expect, wait a bit and check again to give
3544         processes some time to exit.
3545
3546         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3547
3548 2019-02-27  Chris Dumez  <cdumez@apple.com>
3549
3550         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3551         https://bugs.webkit.org/show_bug.cgi?id=194545
3552
3553         Reviewed by Brady Eidson.
3554
3555         Make sure the test navigates forward and then back only once. Previously, navigating
3556         back would trigger a navigation again in a timer.
3557
3558         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3559
3560 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3561
3562         High Sierra Debug JSC test queue should use faster hardware
3563         https://bugs.webkit.org/show_bug.cgi?id=194603
3564
3565         Rubber-stamped by Alexey Proskuryakov.
3566
3567         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3568
3569         * BuildSlaveSupport/build.webkit.org-config/config.json:
3570         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3571         (BubbleQueueServer):
3572         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3573         (WebKitBuildbot):
3574         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3575         * QueueStatusServer/config/queues.py:
3576         * Scripts/webkitpy/common/config/ews.json:
3577         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3578         (test_ews_name):
3579
3580 2019-02-27  John Wilander  <wilander@apple.com>
3581
3582         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3583         https://bugs.webkit.org/show_bug.cgi?id=195071
3584         <rdar://problem/48417690>
3585
3586         Reviewed by Alex Christensen and Brent Fulgham.
3587
3588         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3589         (TestWebKitAPI::createURL):
3590             Convenience function.
3591         (TestWebKitAPI::TEST):
3592             WebCore::AdClickAttribution now takes a URL when creating Source and
3593             Destination.
3594         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3595         (TestWebKitAPI::TEST):
3596             WebCore::AdClickAttribution now takes a URL when creating Source and
3597             Destination.
3598
3599 2019-02-27  Antoine Quint  <graouts@apple.com>
3600
3601         Support Pointer Events on macOS
3602         https://bugs.webkit.org/show_bug.cgi?id=195008
3603         <rdar://problem/47454419>
3604
3605         Reviewed by Dean Jackson.
3606
3607         * DumpRenderTree/mac/DumpRenderTree.mm:
3608         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3609         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3610
3611 2019-02-26  Mark Lam  <mark.lam@apple.com>
3612
3613         Remove remaining poisoning code.
3614         https://bugs.webkit.org/show_bug.cgi?id=194138
3615
3616         Reviewed by Saam Barati.
3617
3618         * TestWebKitAPI/CMakeLists.txt:
3619         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3620         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3621         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3622         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3623         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3624         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3625         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3626
3627 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3628
3629         Move ephemeral local storage from WebProcess to UIProcess
3630         https://bugs.webkit.org/show_bug.cgi?id=195074
3631         <rdar://problem/47937975>
3632
3633         Reviewed by Geoff Garen.
3634
3635         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3636
3637 2019-02-20  Jer Noble  <jer.noble@apple.com>
3638
3639         [Cocoa] Media elements will restart network buffering just before suspending
3640         https://bugs.webkit.org/show_bug.cgi?id=193691
3641
3642         Reviewed by Eric Carlson.
3643
3644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3645         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3646         (TEST):
3647
3648 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3649
3650         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3651         https://bugs.webkit.org/show_bug.cgi?id=191652
3652
3653         Reviewed by Alex Christensen.
3654
3655         Fix WinCairo MiniBrowser behavior of authentication dialog.
3656
3657         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3658         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3659
3660 2019-02-26  Youenn Fablet  <youenn@apple.com>
3661
3662         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3663         https://bugs.webkit.org/show_bug.cgi?id=195028
3664         <rdar://problem/48243733>
3665
3666         Reviewed by Eric Carlson.
3667
3668         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3669
3670 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3671
3672         [WPE] Add API for webview background color configuration
3673         https://bugs.webkit.org/show_bug.cgi?id=192305
3674
3675         Reviewed by Michael Catanzaro.
3676
3677         * MiniBrowser/wpe/main.cpp:
3678         (main): Add a new option to configure the webview background
3679         color. Example: --bg-color=transparent.
3680         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3681         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3682         (beforeAll): Ditto.
3683
3684 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3685
3686         scalableNativeWebpageParameters() is not preserved on new page navigation.
3687         https://bugs.webkit.org/show_bug.cgi?id=194892
3688         <rdar://problem/47538280>
3689
3690         Reviewed by Wenson Hsieh.
3691         
3692         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3693
3694         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3695         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3696         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3697         (WTR::UIScriptController::allowsViewportShrinkToFit):
3698         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3699         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3700         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3701         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3702         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3703         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3704
3705 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3706
3707         [ews-app] Add model for handling multiple Buildbot instances
3708         https://bugs.webkit.org/show_bug.cgi?id=194863
3709
3710         Reviewed by Stephanie Lewis.
3711
3712         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3713
3714 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3715
3716         [ews-app] Remove BuilderMapping table
3717         https://bugs.webkit.org/show_bug.cgi?id=194961
3718
3719         Reviewed by Stephanie Lewis.
3720
3721         Store builder name directly in build table, instead of having a separate
3722         table for it.
3723
3724         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3725         * BuildSlaveSupport/ews-app/ews/models/build.py:
3726         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3727         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3728
3729 2019-02-25  John Wilander  <wilander@apple.com>
3730
3731         Introduce and adopt new class RegistrableDomain for eTLD+1
3732         https://bugs.webkit.org/show_bug.cgi?id=194791
3733         <rdar://problem/48179240>
3734
3735         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3736
3737         This patch adds an API test and replaces two instances of
3738         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3739
3740         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3741         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3742         (TestWebKitAPI::TEST):
3743             Changed two strings to make sure the registrable domains are still considered
3744             invalid and pass the test.
3745         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3746         (TestWebKitAPI::TEST):
3747         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3748         (WTR::InjectedBundle::didReceiveMessageToPage):
3749
3750 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3751
3752         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3753         https://bugs.webkit.org/show_bug.cgi?id=195001
3754
3755         Reviewed by Carlos Garcia Campos.
3756
3757         API version 1.0 always includes the functionality previously guarded with
3758         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3759         unconditionally.
3760
3761         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3762         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3763         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3764         (WebViewTest::showInWindow): Ditto.
3765         (WebViewTest::hideView): Ditto.
3766         * wpe/backends/HeadlessViewBackend.cpp:
3767         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3768         * wpe/backends/ViewBackend.cpp:
3769         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3770         * wpe/backends/WindowViewBackend.cpp:
3771         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3772         WPE_BACKEND_CHECK_VERSION().
3773         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3774
3775 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3776
3777         [Flatpak] Add support for flatpak > 1.1.2
3778         https://bugs.webkit.org/show_bug.cgi?id=194088
3779
3780         Flatpak 1.2 is now out so we need to support that
3781         version now.
3782
3783         Reviewed by Michael Catanzaro.
3784
3785         * flatpak/flatpakutils.py:
3786         (check_flatpak):
3787         (FlatpakPackages.__init__):
3788         (FlatpakPackages.__detect_packages):
3789         (FlatpakPackages.__detect_packages.in):
3790         (FlatpakRepos.update):
3791
3792 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3793
3794         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3795         https://bugs.webkit.org/show_bug.cgi?id=194998
3796
3797         Reviewed by Carlos Garcia Campos.
3798
3799         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3800         to a Git checkout and using the latest commit containing various fixes
3801         and improvements.
3802
3803 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3804
3805         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3806         https://bugs.webkit.org/show_bug.cgi?id=194981
3807
3808         Reviewed by Žan Doberšek.
3809
3810         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3811         (TestWebKitAPI::TEST):
3812
3813 2019-02-23  Keith Miller  <keith_miller@apple.com>
3814
3815         Add new mac target numbers
3816         https://bugs.webkit.org/show_bug.cgi?id=194955
3817
3818         Reviewed by Tim Horton.
3819
3820         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3821         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3822         * MiniBrowser/Configurations/Base.xcconfig:
3823         * TestWebKitAPI/Configurations/Base.xcconfig:
3824         * WebKitTestRunner/Configurations/Base.xcconfig:
3825
3826 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3827
3828         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3829         https://bugs.webkit.org/show_bug.cgi?id=194846
3830
3831         Reviewed by Don Olmstead.
3832
3833         Added _search_paths() and _port_specific_expectations_files() for
3834         WinCairoPort.
3835
3836         * Scripts/webkitpy/port/win.py:
3837         (WinCairoPort.default_baseline_search_path):
3838         (WinCairoPort):
3839         (WinCairoPort._port_specific_expectations_files):
3840         (WinCairoPort._search_paths):
3841
3842 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3843
3844         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3845         https://bugs.webkit.org/show_bug.cgi?id=194963
3846
3847         Reviewed by Dean Jackson.
3848
3849         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3850         Do a `contains` check instead of `equals`, because in debug builds we
3851         put the GraphicsLayer pointer in a prefix.
3852
3853 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3854
3855         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3856         https://bugs.webkit.org/show_bug.cgi?id=194873
3857         <rdar://problem/46701974>
3858
3859         Reviewed by Tim Horton.
3860
3861         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3862
3863         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3864         (WTR::UIScriptController::menuRect const):
3865         (WTR::UIScriptController::isShowingMenu const):
3866         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3867         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3868         (WTR::UIScriptController::menuRect const):
3869
3870         Add a function to query the bounds of the callout menu in content coordinates.
3871
3872         (WTR::UIScriptController::isShowingMenu const):
3873
3874         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3875
3876         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3877         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3878         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3879         (WTR::UIScriptController::rectForMenuAction const):
3880         (WTR::UIScriptController::menuRect const):
3881         (WTR::UIScriptController::isShowingMenu const):
3882         (WTR::findViewInHierarchyOfType): Deleted.
3883
3884 2019-02-22  Chris Dumez  <cdumez@apple.com>
3885
3886         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3887         https://bugs.webkit.org/show_bug.cgi?id=194954
3888         <rdar://problem/48127957>
3889
3890         Reviewed by Alex Christensen.
3891
3892         Add API test coverage.
3893
3894         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3895         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3896         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3897         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3898
3899 2019-02-22  Chris Dumez  <cdumez@apple.com>
3900
3901         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3902         https://bugs.webkit.org/show_bug.cgi?id=194924
3903         <rdar://problem/48216125>
3904
3905         Reviewed by Geoffrey Garen.
3906
3907         Add API test coverage.
3908
3909         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3910
3911 2019-02-22  Chris Dumez  <cdumez@apple.com>
3912
3913         Unreviewed, disable API test added in r241928 on iOS.
3914
3915         The cache is not enabled on devices with less than 3GB of RAM.
3916
3917         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3918
3919 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3920
3921         Hardcode Visual Viewports on everywhere except iOS WK1
3922         https://bugs.webkit.org/show_bug.cgi?id=194928
3923
3924         Reviewed by Zalan Bujtas.
3925
3926         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3927         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3928         set it to false. The setting has shipped for several years and there's no need to turn
3929         it off now.
3930
3931         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3932         Visual Viewports are not enabled.
3933         
3934         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3935         that only runs in WK2
3936
3937         * MiniBrowser/mac/SettingsController.h:
3938         * MiniBrowser/mac/SettingsController.m:
3939         (-[SettingsController init]):
3940         (-[SettingsController _populateMenu]):
3941         (-[SettingsController validateMenuItem:]):
3942         (-[SettingsController visualViewportEnabled]): Deleted.
3943         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3944         * MiniBrowser/mac/WK1BrowserWindowController.m:
3945         (-[WK1BrowserWindowController didChangeSettings]):
3946         * MiniBrowser/mac/WK2BrowserWindowController.m:
3947         (-[WK2BrowserWindowController didChangeSettings]):
3948
3949 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3950
3951         Discard cached processes when clearing website data store
3952         https://bugs.webkit.org/show_bug.cgi?id=194894
3953
3954         Reviewed by Chris Dumez.
3955
3956         Added a test case.
3957
3958         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3959         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3960
3961 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3962
3963         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3964         https://bugs.webkit.org/show_bug.cgi?id=194914
3965         <rdar://problem/47586889>
3966
3967         Reviewed by Geoffrey Garen.
3968
3969         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3970         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3971         (TEST):
3972         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3973
3974 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3975
3976         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3977         <https://webkit.org/b/194761>
3978
3979         Reviewed by Myles Maxfield.
3980
3981         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3982         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3983         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3984         to use ARC-compliant cast.
3985         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3986         ARC-compliant cast.
3987         (WTR::installFakeHelvetica): Log `error` to console if
3988         CTFontManagerRegisterFontsForURL() fails, but only on supported
3989         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3990         Call CFRelease() on `error` to fix the leak.  Update to use
3991         ARC-compliant cast.
3992         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3993         cast.
3994
3995 2019-02-21  Chris Dumez  <cdumez@apple.com>
3996
3997         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3998         https://bugs.webkit.org/show_bug.cgi?id=194481
3999
4000         Reviewed by Alex Christensen.
4001
4002         Give the processes a chance to shutdown and wait until we reached the expected number
4003         of processes.
4004
4005         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4006
4007 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4008
4009         Fix the macOS build
4010
4011         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4012
4013 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4014
4015         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4016
4017         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4018         I am a backwards.
4019
4020 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4021
4022         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4023
4024         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4025         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4026         We could force on UI-side compositing, but I feel like the test might be more
4027         valuable exercising the normal path on each platform (though the original
4028         bug was also UI-side specific). Though we can't validate that the overlay
4029         layer was installed successfully, there are layout tests that do that.
4030
4031 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4032
4033         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4034         https://bugs.webkit.org/show_bug.cgi?id=194845
4035         <rdar://problem/47944579>
4036
4037         Reviewed by Antti Koivisto.
4038
4039         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4040         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4041
4042 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4043
4044         [LFC][Floats] Add support for placing formatting roots in-between floats.
4045         https://bugs.webkit.org/show_bug.cgi?id=194902
4046
4047         Reviewed by Antti Koivisto.
4048
4049         * LayoutReloaded/misc/LFC-passing-tests.txt:
4050
4051 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4052
4053         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4054         https://bugs.webkit.org/show_bug.cgi?id=194901
4055
4056         Unreviewed build fix.
4057
4058         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4059         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4060         WPEBackend-fdo-0.1 as library name.
4061
4062 2019-02-21  Rob Buis  <rbuis@igalia.com>
4063
4064         Update MIME type parser
4065         https://bugs.webkit.org/show_bug.cgi?id=180526
4066
4067         Reviewed by Darin Adler.
4068
4069         Add tests involving leading and trailing whitespace, non-token
4070         characters and quoted strings.
4071
4072         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4073         (TestWebKitAPI::TEST):
4074
4075 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4076
4077         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4078         https://bugs.webkit.org/show_bug.cgi?id=194884
4079
4080         Reviewed by Michael Catanzaro.
4081
4082         * PlatformWin.cmake:
4083
4084 2019-02-20  Chris Dumez  <cdumez@apple.com>
4085
4086         Add API test for <rdar://problem/47471222>
4087         https://bugs.webkit.org/show_bug.cgi?id=194847
4088
4089         Reviewed by Alex Christensen.
4090
4091         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4092
4093 2019-02-20  Chris Dumez  <cdumez@apple.com>
4094
4095         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4096         https://bugs.webkit.org/show_bug.cgi?id=194872
4097         <rdar://problem/47924500>
4098
4099         Reviewed by Alex Christensen.
4100
4101         Add API test coverage.
4102
4103         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4104
4105 2019-02-20  Jer Noble  <jer.noble@apple.com>
4106
4107         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4108         https://bugs.webkit.org/show_bug.cgi?id=191332
4109
4110         Reviewed by Dean Jackson.
4111
4112         * Scripts/git-is-in-range: Added.
4113
4114 2019-02-20  Andy Estes  <aestes@apple.com>
4115
4116         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4117         https://bugs.webkit.org/show_bug.cgi?id=194869
4118
4119         Rubber-stamped by Jer Noble.
4120
4121         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4122         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4123         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4124         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4126         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4127
4128 2019-02-20  Chris Dumez  <cdumez@apple.com>
4129
4130         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4131         https://bugs.webkit.org/show_bug.cgi?id=194857
4132         <rdar://problem/47759323>
4133
4134         Reviewed by Alex Christensen.
4135
4136         Add API test coverage.
4137
4138         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4139
4140 2019-02-20  Chris Dumez  <cdumez@apple.com>
4141
4142         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4143         https://bugs.webkit.org/show_bug.cgi?id=194829
4144         <rdar://problem/47889906>
4145
4146         Reviewed by Alexey Proskuryakov.
4147
4148         Every time the TestOptions were changing we were creating both a new Web view and
4149         a new WKContext, which would start a new Network process. In most cases, we only
4150         need to contruct a new Web view and we do can keep reusing the same WKContext.
4151         This patch implements this optimization and thus avoids spinning a lot of new
4152         Network processes while running the layout tests.
4153
4154         * WebKitTestRunner/TestController.cpp:
4155         (WTR::TestController::generateContextConfiguration const):
4156         (WTR::TestController::generatePageConfiguration):
4157         (WTR::TestController::createWebViewWithOptions):
4158         (WTR::TestController::resetPreferencesToConsistentValues):
4159         (WTR::updateTestOptionsFromTestHeader):
4160         * WebKitTestRunner/TestController.h:
4161         * WebKitTestRunner/TestOptions.h:
4162         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4163         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4164         (WTR::TestOptions::hasSameInitializationOptions const):
4165         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4166         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4167         (WTR::TestController::platformAddTestOptions const):
4168
4169 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4170
4171         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4172         https://bugs.webkit.org/show_bug.cgi?id=167941
4173
4174         Reviewed by Carlos Garcia Campos.
4175
4176         * MiniBrowser/gtk/main.c:
4177         (filterSavedCallback): Added.
4178         (main): Support loading a JSON rule set file for content filtering.
4179         * MiniBrowser/wpe/main.cpp:
4180         (filterSavedCallback): Added.
4181         (main): Support loading a JSON rule set file for content filtering.
4182         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4183         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4184         (WTF::derefGPtr): Ditto.
4185         (testEmptyStore):
4186         (testSaveInvalidFilter):
4187         (testSaveLoadFilter):
4188         (testSavedFilterIdentifierMatch):
4189         (testRemoveFilter):
4190         (testSaveMultipleFilters):
4191         (testSaveFilterFromFile):
4192         (testFilterPersistence):
4193         (beforeAll):
4194         (afterAll):
4195         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4196         (removeOldInjectedContentAndResetLists): Also reset content filters.
4197         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4198         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4199         the element affected by the style sheet.
4200         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4201         and returns it to be used by tests.
4202         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4203         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4204         (serverCallback): Add support for serving a CSS style sheet for testing.
4205         (beforeAll): Add call to testUserContentManagerContentFilter().
4206         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4207
4208 2019-02-19  Keith Rollin  <krollin@apple.com>
4209
4210         Add timing information to build output
4211         https://bugs.webkit.org/show_bug.cgi?id=194839
4212         <rdar://problem/48219609>
4213
4214         Reviewed by Alexey Proskuryakov.
4215
4216         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4217         emit each project's build time to its output. E.g.,
4218
4219             ** BUILD SUCCEEDED ** [0.132 sec]
4220
4221         * Scripts/webkitdirs.pm:
4222         (XcodeOptions):
4223
4224 2019-02-19  Truitt Savell  <tsavell@apple.com>
4225
4226         Unreviewed, rolling out r241784.
4227
4228         Broke all OpenSource builds.
4229
4230         Reverted changeset:
4231
4232         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4233         instances view"
4234         https://bugs.webkit.org/show_bug.cgi?id=172848
4235         https://trac.webkit.org/changeset/241784
4236
4237 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4238
4239         [LFC][Floats] Remove redundant intersecting logic
4240         https://bugs.webkit.org/show_bug.cgi?id=194804
4241
4242         Reviewed by Antti Koivisto.
4243
4244         * LayoutReloaded/misc/LFC-passing-tests.txt:
4245
4246 2019-02-19  Dean Jackson  <dino@apple.com>
4247
4248         Clean-up output from generate-xcfilelists so it can be filtered
4249         https://bugs.webkit.org/show_bug.cgi?id=194795
4250
4251         Reviewed by Joseph Pecoraro (and Keith Rollin).
4252
4253         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4254         make a slight tweak to filter-build-webkit so such lines are marked
4255         as plain.
4256
4257         * Scripts/filter-build-webkit:
4258         * Scripts/generate-xcfilelists:
4259
4260 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4261
4262         pytest is not correctly auto-installed
4263         https://bugs.webkit.org/show_bug.cgi?id=194707
4264
4265         Reviewed by Carlos Garcia Campos.
4266
4267         * Scripts/webkitpy/thirdparty/__init__.py:
4268         (AutoinstallImportHook._install_pytest):
4269
4270 2019-02-18  Chris Dumez  <cdumez@apple.com>
4271
4272         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4273         https://bugs.webkit.org/show_bug.cgi?id=194797
4274         <rdar://problem/48055151>
4275
4276         Reviewed by Geoffrey Garen.
4277
4278         Add API test coverage.
4279
4280         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4281
4282 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4283
4284         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4285         https://bugs.webkit.org/show_bug.cgi?id=194670
4286         <rdar://problem/39066529>
4287
4288         Reviewed by Tim Horton.
4289
4290         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4291         pasted in an editable area as attachment elements.
4292
4293         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4294         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4295         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4296         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4297         (TestWebKitAPI::TEST):
4298         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4299         (WTR::InjectedBundlePage::InjectedBundlePage):
4300
4301 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4302
4303         Fix API test after r241728
4304        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4305
4306         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4307         (TEST):
4308         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4309
4310 2019-02-18  Daniel Bates  <dabates@apple.com>
4311
4312         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4313         https://bugs.webkit.org/show_bug.cgi?id=192824
4314         <rdar://problem/47100332>
4315
4316         Reviewed by Wenson Hsieh.
4317
4318         Fix a bug where the wrong usage code was used for F13 thru F24.
4319
4320         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4321         (keyCodeForDOMFunctionKey):
4322
4323 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4324
4325         Bytecode cache should a have a boot-specific validation
4326         https://bugs.webkit.org/show_bug.cgi?id=194769
4327         <rdar://problem/48149509>
4328
4329         Reviewed by Keith Miller.
4330
4331         Add test for WTF::bootSessionUUIDString()
4332
4333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4334         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4335         (TEST):
4336
4337 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4338
4339         Disable safe browsing in WKWebView and remove its WKPreferences API
4340         https://bugs.webkit.org/show_bug.cgi?id=194723
4341         <rdar://problem/48122993>
4342
4343         Reviewed by Geoffrey Garen.
4344
4345         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4346         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4347         (TEST):
4348         (safeBrowsingView):
4349         Make tests use SPI instead of API.
4350
4351 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4352
4353         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4354         https://bugs.webkit.org/show_bug.cgi?id=194586
4355
4356         Reviewed by Ross Kirsling.
4357
4358         * DumpRenderTree/win/DumpRenderTree.cpp:
4359         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4360         * Scripts/webkitpy/port/driver.py:
4361         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4362
4363 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4364