REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-29  Chris Dumez  <cdumez@apple.com>
2
3         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
4         https://bugs.webkit.org/show_bug.cgi?id=193932
5         <rdar://problem/47598947>
6
7         Reviewed by Brady Eidson.
8
9         Add API test coverage.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12
13 2019-01-29  Zalan Bujtas  <zalan@apple.com>
14
15         Adding new passing LFC tests.
16
17         Unreviewed test gardening.
18
19         * LayoutReloaded/misc/LFC-passing-tests.txt:
20
21 2019-01-29  Zalan Bujtas  <zalan@apple.com>
22
23         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
24         https://bugs.webkit.org/show_bug.cgi?id=193964
25
26         Reviewed by Antti Koivisto.
27
28         * LayoutReloaded/misc/LFC-passing-tests.txt:
29
30 2019-01-29  Zalan Bujtas  <zalan@apple.com>
31
32         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
33         https://bugs.webkit.org/show_bug.cgi?id=193954
34
35         Reviewed by Antti Koivisto.
36
37         * LayoutReloaded/misc/LFC-passing-tests.txt:
38
39 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
40
41         WebDriver: add support for running subtests
42         https://bugs.webkit.org/show_bug.cgi?id=193904
43
44         Reviewed by Michael Catanzaro.
45
46         pytest already supports it by passing test.py::subtest, so we can do the same.
47
48         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
49         (get_item_name): Made this global.
50         (CollectRecorder.__init__): Receive the parameter to ignore.
51         (CollectRecorder.pytest_collectreport): Collect also the subtests.
52         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
53         (collect): Add parameter to ignore.
54         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
55         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
56         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
57         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
58         (WebDriverTestRunnerSelenium.run): Ditto.
59         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
60         (WebDriverTestRunnerW3C.collect_tests): Ditto.
61         (WebDriverTestRunnerW3C.run): Ditto.
62
63 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
64
65         User agent string override for navigator.userAgent should be site specific quirks
66         https://bugs.webkit.org/show_bug.cgi?id=193950
67
68         Reviewed by Brent Fulgham.
69
70         Updated per the _WKWebsitePolicies rename.
71
72         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
73         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
74
75 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
76
77         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
78         https://bugs.webkit.org/show_bug.cgi?id=193941
79
80         Reviewed by Alex Christensen.
81
82         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
83         * TestWebKitAPI/Tests/WTF/Condition.cpp:
84         * TestWebKitAPI/Tests/WTF/Lock.cpp:
85         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
86         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
87         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
88         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
89         * TestWebKitAPI/Tests/WTF/Time.cpp:
90         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
91         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
92         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
93         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
94
95 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
96
97         Unreviewed, reorder my emails to fix autocomplete in bugzilla
98
99         * Scripts/webkitpy/common/config/contributors.json:
100
101 2019-01-28  Andy Estes  <aestes@apple.com>
102
103         [watchOS] Enable Parental Controls content filtering
104         https://bugs.webkit.org/show_bug.cgi?id=193939
105         <rdar://problem/46641912>
106
107         Reviewed by Ryosuke Niwa.
108
109         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
110
111 2019-01-28  David Kilzer  <ddkilzer@apple.com>
112
113         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
114         <https://webkit.org/b/193884>
115
116         Reviewed by Jiewen Tan.
117
118         * Scripts/webkitpy/style/checkers/cpp.py:
119         (check_language): Add LocalAuthentication to
120         `frameworks_with_soft_links`.
121
122 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
123
124         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
125         https://bugs.webkit.org/show_bug.cgi?id=193891
126
127         Reviewed by Ross Kirsling.
128
129         There were three problems in window sizes of WebView and the host window.
130         1. The sizes of pixel image output were incorrect.
131         2. The host window is going to appear after window.resize was invoked.
132         3. window.resize resized only the host window, not WebView.
133
134         This change solves them with a following approach.
135         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
136         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
137            as well as DumpRenderTree in order to match the client area and the window area.
138         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
139         d. PlatformWebView::setWindowFrame changes both window sizes.
140         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
141
142         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
143         (WTR::PlatformWebView::PlatformWebView): Create the host window
144         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
145         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
146         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
147
148 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
149
150         [ews-app] Add method to save Step data to database
151         https://bugs.webkit.org/show_bug.cgi?id=193890
152
153         Reviewed by Lucas Forschler.
154
155         * BuildSlaveSupport/ews-app/ews/models/step.py:
156         (Step.save_step): Method to save step data.
157         (Step.update_step): Method to update step data.
158         (Step.get_existing_step): Method to fetch existing step from database.
159         (Step.is_valid_result): Method to validate valid step result.
160
161 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
162
163         [ews-app] Add method to save Build data to database
164         https://bugs.webkit.org/show_bug.cgi?id=193735
165
166         Reviewed by Lucas Forschler.
167
168         * BuildSlaveSupport/ews-app/ews/models/build.py:
169         (Build.save_build): Method to save build information to database.
170         (Build.get_existing_build): Method to fetch existing build from database.
171         (Build.is_valid_result): Method to validate build result.
172         * BuildSlaveSupport/ews-app/ews/common/util.py:
173         (is_valid_int_id): Method to validate valid id.
174
175 2019-01-28  Chris Dumez  <cdumez@apple.com>
176
177         Regression(PSON) Crash under WebPageProxy::didStartProgress()
178         https://bugs.webkit.org/show_bug.cgi?id=193915
179         <rdar://problem/47560907>
180
181         Reviewed by Alex Christensen.
182
183         Add API test coverage.
184
185         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
186
187 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
188
189         [ews-app] Rename id variables
190         https://bugs.webkit.org/show_bug.cgi?id=193883
191
192         Reviewed by Lucas Forschler.
193
194         * BuildSlaveSupport/ews-app/ews/models/build.py:
195         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
196         * BuildSlaveSupport/ews-app/ews/models/step.py:
197         * BuildSlaveSupport/ews-app/ews/urls.py:
198         * BuildSlaveSupport/ews-app/ews/views/patch.py:
199         * BuildSlaveSupport/ews-app/ews/views/results.py:
200         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
201
202 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
203
204         [ews-app] Allow certain fields to be empty
205         https://bugs.webkit.org/show_bug.cgi?id=193892
206
207         Reviewed by Lucas Forschler.
208
209         * BuildSlaveSupport/ews-app/ews/models/build.py:
210         * BuildSlaveSupport/ews-app/ews/models/step.py:
211
212 2019-01-28  Rob Buis  <rbuis@igalia.com>
213
214         Update MIME type parser
215         https://bugs.webkit.org/show_bug.cgi?id=180526
216
217         Reviewed by Frédéric Wang.
218
219         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
220         (TestWebKitAPI::TEST):
221
222 2019-01-28  Zalan Bujtas  <zalan@apple.com>
223
224         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
225         https://bugs.webkit.org/show_bug.cgi?id=193896
226
227         Reviewed by Antti Koivisto.
228
229         * LayoutReloaded/misc/LFC-passing-tests.txt:
230
231 2018-12-15  Darin Adler  <darin@apple.com>
232
233         Replace many uses of String::format with more type-safe alternatives
234         https://bugs.webkit.org/show_bug.cgi?id=192742
235
236         Reviewed by Mark Lam.
237
238         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
239         (WTR::cacheTestRunnerCallback): Use makeString.
240         * WebKitTestRunner/TestController.cpp:
241         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
242         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
243
244 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
245
246         Use a load optimizer for some sites
247         https://bugs.webkit.org/show_bug.cgi?id=193881
248         <rdar://problem/46325455>
249
250         Reviewed by Brent Fulgham.
251
252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
253         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
254
255 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
256
257         AX: Introduce a static accessibility tree
258         https://bugs.webkit.org/show_bug.cgi?id=193348
259         <rdar://problem/47203295>
260
261         Reviewed by Ryosuke Niwa.
262
263         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
264
265 2019-01-26  Zalan Bujtas  <zalan@apple.com>
266
267         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
268         https://bugs.webkit.org/show_bug.cgi?id=193867
269
270         Reviewed by Antti Koivisto.
271
272         * LayoutReloaded/misc/LFC-passing-tests.txt:
273
274 2019-01-26  Zalan Bujtas  <zalan@apple.com>
275
276         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
277         https://bugs.webkit.org/show_bug.cgi?id=193865
278
279         Reviewed by Antti Koivisto.
280
281         * LayoutReloaded/misc/LFC-passing-tests.txt:
282
283 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
284
285         Need a mechanism to override navigator.userAgent
286         https://bugs.webkit.org/show_bug.cgi?id=193762
287         <rdar://problem/47504939>
288
289         Reviewed by Brent Fulgham.
290
291         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
292
293         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
294         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
295         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
296
297 2019-01-25  Dean Jackson  <dino@apple.com>
298
299         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
300         https://bugs.webkit.org/show_bug.cgi?id=193831
301         <rdar://problem/47399263>
302
303         Reviewed by Chris Dumez.
304
305         Two new tests that exercise cross-origin and same-origin System
306         Previews.
307
308         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
309
310 2019-01-25  Keith Rollin  <krollin@apple.com>
311
312         Update Xcode projects with "Check .xcfilelists" build phase
313         https://bugs.webkit.org/show_bug.cgi?id=193790
314         <rdar://problem/47201374>
315
316         Reviewed by Alex Christensen.
317
318         Support for XCBuild includes specifying inputs and outputs to various
319         Run Script build phases. These inputs and outputs are specified as
320         .xcfilelist files. Once created, these .xcfilelist files need to be
321         kept up-to-date. In order to check that they are up-to-date or not,
322         add an Xcode build step that invokes an external script that performs
323         the checking. If the .xcfilelists are found to be out-of-date, update
324         them, halt the build, and instruct the developer to restart the build
325         with up-to-date files.
326
327         At this time, the checking and regenerating is performed only if the
328         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
329         who want to use this facility can set this variable and test out the
330         checking/regenerating. Once it seems like there are no egregious
331         issues that upset a developer's workflow, we'll unconditionally enable
332         this facility.
333
334         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
335         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
336         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
337         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
338
339 2019-01-25  Keith Rollin  <krollin@apple.com>
340
341         Update Xcode projects with "Apply Configuration to XCFileLists" build target
342         https://bugs.webkit.org/show_bug.cgi?id=193781
343         <rdar://problem/47201153>
344
345         Reviewed by Alex Christensen.
346
347         Part of generating the .xcfilelists used as part of adopting XCBuild
348         includes running `make DerivedSources.make` from a standalone script.
349         It’s important for this invocation to have the same environment as
350         when the actual build invokes `make DerivedSources.make`. If the
351         environments are different, then the two invocations will provide
352         different results. In order to get the same environment in the
353         standalone script, have the script launch xcodebuild targeting the
354         "Apply Configuration to XCFileLists" build target, which will then
355         re-invoke our standalone script. The script is now running again, this
356         time in an environment with all workspace, project, target, xcconfig
357         and other environment variables established.
358
359         The "Apply Configuration to XCFileLists" build target accomplishes
360         this task via a small embedded shell script that consists only of:
361
362             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
363
364         The process that invokes "Apply Configuration to XCFileLists" first
365         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
366         evaluated and exports it into the shell environment. When xcodebuild
367         is invoked, it inherits the value of this variable and can `eval` the
368         contents of that variable. Our external standalone script can then set
369         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
370         of command-line parameters needed to restart itself in the appropriate
371         state.
372
373         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
374         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
375
376 2019-01-25  Alex Christensen  <achristensen@webkit.org>
377
378         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
379         https://bugs.webkit.org/show_bug.cgi?id=193802
380         <rdar://problem/46010580>
381
382         Reviewed by Andy Estes.
383
384         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
385         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
386         (TEST):
387
388 2019-01-25  Daniel Bates  <dabates@apple.com>
389
390         [iOS] uiController.keyDown() does not translate Control modified key
391         https://bugs.webkit.org/show_bug.cgi?id=192898
392
393         Reviewed by Wenson Hsieh.
394
395         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
396         key translation, as applicable. Among other cases, key translation occurs when performing
397         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
398         also makes the behavior of uiController.keyDown() more closely match the behavior of a
399         human pressing down and releasing key(s) using a hardware keyboard.
400
401         * WebKitTestRunner/ios/HIDEventGenerator.h:
402         * WebKitTestRunner/ios/HIDEventGenerator.mm:
403         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
404
405         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
406         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
407         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
408         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
409         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
410         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
411         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
412         (-[HIDEventGenerator longPress:completionBlock:]):
413         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
414         Update code for above renaming.
415
416         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
417         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
418
419         (-[HIDEventGenerator keyDown:]): Added.
420         (-[HIDEventGenerator keyUp:]): Added.
421         (-[HIDEventGenerator keyPress:completionBlock:]):
422         (-[HIDEventGenerator eventDispatchThreadEntry:]):
423         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
424         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
425         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
426         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
427         (WTR::parseModifier): Deleted.
428
429 2019-01-25  Keith Rollin  <krollin@apple.com>
430
431         Complete the implementation of generate-xcfilelists
432         https://bugs.webkit.org/show_bug.cgi?id=193782
433
434         Reviewed by Alex Christensen.
435
436         A preliminary version of generate-xcfilelists was added in r238008.
437         This patch updates that script in order to:
438
439         - Support checking of .xcfilelists
440         - Perform better execution of `make DerivedSources.make` by
441           relaunching generate-xcfilelists under xcodebuild
442         - Support incremental generation and checking of .xcfilelists
443         - Support supplementary .xcfilelists files from WebKitAdditions
444         - Support being wrapped by parallel version of generate-xcfilelists in
445           Internal that adds support for (re)generating WebKit projects in
446           that repo.
447         - Support builds that have been performed in WebKitBuild as well as
448           ~/Library/Developer/code/DerivedData
449         - Increase robustness and debugging facilities.
450
451         * Scripts/generate-xcfilelists:
452
453 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
454
455         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
456         https://bugs.webkit.org/show_bug.cgi?id=193297
457         <rdar://problem/47158841>
458
459         Unreviewed test case fix.
460
461         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
462         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
463
464         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
465         (TEST):
466
467 2019-01-25  Keith Rollin  <krollin@apple.com>
468
469         Update existing .xcfilelists
470         https://bugs.webkit.org/show_bug.cgi?id=193791
471         <rdar://problem/47201706>
472
473         Reviewed by Alex Christensen.
474
475         Many .xcfilelist files were added in r238824 in order to support
476         XCBuild. Update these with recent changes to the set of build files
477         and with the current generate-xcfilelist script.
478
479         * DumpRenderTree/DerivedSources-input.xcfilelist:
480         * DumpRenderTree/DerivedSources-output.xcfilelist:
481         * WebKitTestRunner/DerivedSources-input.xcfilelist:
482         * WebKitTestRunner/DerivedSources-output.xcfilelist:
483
484 2019-01-25  Keith Rollin  <krollin@apple.com>
485
486         Fix missing dependencies in extract-dependencies-from-makefile
487         https://bugs.webkit.org/show_bug.cgi?id=193783
488         <rdar://problem/47201571>
489
490         Reviewed by Alex Christensen.
491
492         The extract-dependencies-from-makefile script generates .xcfilelists
493         for XCBuild by invoking a makefile in --debug mode, parsing the
494         dependency information in the output, and extracting information
495         regarding targets and dependents. However, the way `make` emits this
496         dependency information is not rigorous, and so we need to determine
497         what lines to look for and parse by trial and error. This approach
498         didn't coriginally atch all the information we needed to collect, so
499         update the script to look for the additional lines we now know to look
500         for.
501
502         * Scripts/extract-dependencies-from-makefile:
503         (Parser):
504         (Parser.addTarget):
505         (Parser.addPrereq):
506         (Parser.doParse):
507
508 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
509
510         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
511         https://bugs.webkit.org/show_bug.cgi?id=193297
512         <rdar://problem/47158841>
513
514         Reviewed by Alex Christensen.
515
516         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
517             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
518         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
519         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
520         activating the message used to trigger the callback when it is set.
521
522 2019-01-25  Alex Christensen  <achristensen@webkit.org>
523
524         WKWebView.goBack should reload if there is a safe browsing warning
525         https://bugs.webkit.org/show_bug.cgi?id=193805
526         <rdar://problem/46908216>
527
528         Reviewed by Geoff Garen.
529
530         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
531         (+[Simple3LookupContext sharedLookupContext]):
532         (-[Simple3LookupContext lookUpURL:completionHandler:]):
533         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
534         (TEST):
535
536 2019-01-25  Chris Dumez  <cdumez@apple.com>
537
538         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
539         https://bugs.webkit.org/show_bug.cgi?id=193788
540         <rdar://problem/47531231>
541
542         Reviewed by Alex Christensen.
543
544         Add API test coverage.
545
546         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
547         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
548
549 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
550
551         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
552         https://bugs.webkit.org/show_bug.cgi?id=193771
553
554         Unreviewed infrastructure fix.
555
556         * Scripts/webkitpy/port/darwin.py:
557         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
558
559 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
560
561         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
562
563 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
564
565         Add contributors.json entries for Ling Ho and for a new bot watchers group.
566
567         * Scripts/webkitpy/common/config/contributors.json:
568
569 2019-01-25  Chris Dumez  <cdumez@apple.com>
570
571         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
572         https://bugs.webkit.org/show_bug.cgi?id=193779
573         <rdar://problem/46170903>
574
575         Reviewed by Antti Koivisto.
576
577         Add API test that quickly navigates forward to a previous process without waiting for it to
578         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
579         the process' previous page when reconnecting the it for the forward navigation.
580
581         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
582
583 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
584
585         Need a way for JavaScript (or bundle) code to participate in undo
586         https://bugs.webkit.org/show_bug.cgi?id=190009
587         <rdar://problem/44807048>
588
589         Reviewed by Ryosuke Niwa.
590
591         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
592         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
593
594         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
595         (WTR::UIScriptController::lastUndoLabel const):
596         (WTR::UIScriptController::firstRedoLabel const):
597         (WTR::UIScriptController::platformUndoManager const):
598         * DumpRenderTree/mac/UIScriptControllerMac.mm:
599         (WTR::UIScriptController::lastUndoLabel const):
600         (WTR::UIScriptController::firstRedoLabel const):
601         (WTR::UIScriptController::platformUndoManager const):
602         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
603         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
604         (WTR::UIScriptController::lastUndoLabel const):
605         (WTR::UIScriptController::firstRedoLabel const):
606         * TestRunnerShared/UIScriptContext/UIScriptController.h:
607         * WebKitTestRunner/UIScriptControllerCocoa.mm:
608         (WTR::UIScriptController::lastUndoLabel const):
609         (WTR::UIScriptController::firstRedoLabel const):
610         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
611         (WTR::UIScriptController::platformUndoManager const):
612         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
613         (WTR::UIScriptController::platformUndoManager const):
614
615 2019-01-25  Zalan Bujtas  <zalan@apple.com>
616
617         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
618         https://bugs.webkit.org/show_bug.cgi?id=193824
619
620         Reviewed by Antti Koivisto.
621
622         * LayoutReloaded/misc/LFC-passing-tests.txt:
623
624 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
625
626         Update macOS JSC bot configurations
627         https://bugs.webkit.org/show_bug.cgi?id=193739
628
629         Reviewed by Alexey Proskuryakov.
630
631         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
632         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
633         (BubbleQueueServer): Move JSC EWS to Mojave section.
634         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
635         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
636         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
637
638 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
639
640         [Win][WebKitTestRunner] Implement EventSenderProxy
641         https://bugs.webkit.org/show_bug.cgi?id=193755
642
643         Reviewed by Don Olmstead.
644
645         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
646         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
647         (WTR::EventSenderProxy::dispatchMessage):
648         (WTR::EventSenderProxy::EventSenderProxy):
649         (WTR::EventSenderProxy::mouseDown):
650         (WTR::EventSenderProxy::mouseUp):
651         (WTR::EventSenderProxy::mouseMoveTo):
652         (WTR::EventSenderProxy::mouseScrollBy):
653         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
654
655 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
656
657         Unreviewed fix for API test failure after r240437.
658
659         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
660
661         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
662
663 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
664
665         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
666         https://bugs.webkit.org/show_bug.cgi?id=193787
667         <rdar://problem/47497634>
668
669         Reviewed by Alexey Proskuryakov.
670
671         * Scripts/webkitdirs.pm:
672         (iosSimulatorApplicationsPath): Pick from available runtime directories.
673
674 2019-01-24  Truitt Savell  <tsavell@apple.com>
675
676         Unreviewed, rolling out r240446.
677
678         Casued 5 API failures
679
680         Reverted changeset:
681
682         "Activate the WebResourceLoadStatisticsStore in the
683         NetworkProcess and deactivate it in the UIProcess."
684         https://bugs.webkit.org/show_bug.cgi?id=193297
685         https://trac.webkit.org/changeset/240446
686
687 2019-01-24  Zalan Bujtas  <zalan@apple.com>
688
689         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
690         https://bugs.webkit.org/show_bug.cgi?id=193741
691         <rdar://problem/47135030>
692
693         Reviewed by Antti Koivisto and Simon Fraser.
694
695         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
696         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
697         (TestWebKitAPI::TEST):
698
699 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
700
701         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
702         https://bugs.webkit.org/show_bug.cgi?id=193297
703         <rdar://problem/47158841>
704
705         Reviewed by Alex Christensen.
706
707         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
708         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
709         activating the message used to trigger the callback when it is set.
710
711 2019-01-24  John Wilander  <wilander@apple.com>
712
713         Add Ad Click Attribution as an internal/experimental feature
714         https://bugs.webkit.org/show_bug.cgi?id=193685
715         <rdar://problem/47450399>
716
717         Reviewed by Brent Fulgham.
718
719         Added test option adClickAttributionEnabled.
720
721         * DumpRenderTree/TestOptions.cpp:
722         (TestOptions::TestOptions):
723         * DumpRenderTree/TestOptions.h:
724         * DumpRenderTree/mac/DumpRenderTree.mm:
725         (setWebPreferencesForTestOptions):
726
727 2019-01-24  Antti Koivisto  <antti@apple.com>
728
729         [PSON] Flash on back navigation on Mac
730         https://bugs.webkit.org/show_bug.cgi?id=193716
731         <rdar://problem/47148458>
732
733         Reviewed by Chris Dumez.
734
735         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
736
737         Closing of the previous page is delayed so waiting for didFinishNavigation is
738         not sufficient to guarantee we have received all the messages. Wait for them.
739
740 2019-01-24  Chris Dumez  <cdumez@apple.com>
741
742         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
743         https://bugs.webkit.org/show_bug.cgi?id=193761
744         <rdar://problem/47456405>
745
746         Reviewed by Alex Christensen.
747
748         Add API test coverage.
749
750         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
751
752 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
753
754         webkitpy: Missing PID in crashlog name should not be fatal
755         https://bugs.webkit.org/show_bug.cgi?id=193771
756
757         If we can't determine the PID of a crashlog, just ignore the crashlog instead
758         of raising an exception.
759
760         Reviewed by Lucas Forschler.
761
762         * Scripts/webkitpy/port/darwin.py:
763         (DarwinPort._merge_crash_logs):
764
765 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
766
767         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
768         https://bugs.webkit.org/show_bug.cgi?id=193746
769
770         Reviewed by Youenn Fablet.
771
772         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
773         so we'd best just not call it.
774
775         * Scripts/webkitpy/w3c/test_exporter.py:
776         (WebPlatformTestExporter.create_branch_with_patch):
777
778 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
779
780         Move FileSystem to WTF
781         https://bugs.webkit.org/show_bug.cgi?id=193602
782
783         Reviewed by Yusuke Suzuki.
784
785         * DumpRenderTree/win/DumpRenderTree.cpp:
786         * TestWebKitAPI/CMakeLists.txt:
787         * TestWebKitAPI/PlatformGTK.cmake:
788         * TestWebKitAPI/PlatformJSCOnly.cmake:
789         * TestWebKitAPI/PlatformPlayStation.cmake:
790         * TestWebKitAPI/PlatformWPE.cmake:
791         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
792         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
793         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
794         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
795         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
796         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
797         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
798         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
799         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
800         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
801
802 2019-01-24  Philippe Normand  <pnormand@igalia.com>
803
804         [WPE] Remove hard dependency on subprocess32 for the API tests
805
806         Rubber-stamped by Carlos Garcia Campos.
807
808         * glib/api_test_runner.py:
809         (TestRunner._run_test_qt): Lazily import subprocess32 and check
810         its presence only when running WPEQt tests.
811
812 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
813
814         [GLIB] Expose JavaScriptCore options in GLib public API
815         https://bugs.webkit.org/show_bug.cgi?id=188742
816
817         Reviewed by Michael Catanzaro.
818
819         Add a test for the new API.
820
821         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
822         (testsJSCOptions):
823         (main):
824
825 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
826
827         [GTK][WPE] Support JPEG 2000 images
828         https://bugs.webkit.org/show_bug.cgi?id=186272
829
830         Reviewed by Žan Doberšek.
831
832         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
833
834         * gtk/jhbuild.modules:
835         * wpe/jhbuild.modules:
836
837 2019-01-23  David Kilzer  <ddkilzer@apple.com>
838
839         check-webkit-style should warn when using soft-linking macros in a header
840         <https://webkit.org/b/193750>
841
842         Reviewed by Darin Adler.
843
844         * Scripts/webkitpy/style/checkers/cpp.py:
845         (check_language): Add softlink/header check by refactoring the
846         softlink/framework check.
847         (CppChecker): Enable softlink/header check by default.
848         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
849         (CppStyleTest.test_softlink_framework): Rename from
850         CppStyleTest.test_softlink() and change test framework name in
851         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
852         files. Set file_name for macros that only appear in headers.
853         (CppStyleTest.test_softlink_header): Add tests for using
854         soft-link macros in headers.
855
856 2019-01-23  Chris Dumez  <cdumez@apple.com>
857
858         Deprecate API to limit the maximum number of WebProcesses
859         https://bugs.webkit.org/show_bug.cgi?id=193725
860         <rdar://problem/47464879>
861
862         Reviewed by Geoff Garen.
863
864         Update existing API tests to stop using deprecated API.
865
866         * MiniBrowser/mac/AppDelegate.m:
867         (defaultConfiguration):
868         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
869         (TestWebKitAPI::TEST):
870         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
871         (TestWebKitAPI::TEST):
872         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
873         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
874         (TEST):
875         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
876         (TEST):
877
878 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
879
880         [ews-app] Rename ews model buildermappings to buildermapping
881         https://bugs.webkit.org/show_bug.cgi?id=193729
882
883         Reviewed by Lucas Forschler.
884
885         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
886         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
887         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
888
889 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
890
891         [ews-app] Rename ews model steps to step
892         https://bugs.webkit.org/show_bug.cgi?id=193697
893
894         Reviewed by Lucas Forschler.
895
896         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
897         (Step): Renamed Steps to Step.
898
899 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
900
901         Clean up IndexedDB files between tests
902         https://bugs.webkit.org/show_bug.cgi?id=192796
903         <rdar://problem/46824999>
904
905         Reviewed by Geoffrey Garen.
906
907         * DumpRenderTree/mac/DumpRenderTree.mm:
908         (runTest):
909         * WebKitTestRunner/TestController.cpp:
910         (WTR::TestController::resetStateToConsistentValues):
911         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
912         (WTR::RemoveAllIndexedDatabasesCallback):
913         (WTR::TestController::ClearIndexedDatabases):
914         * WebKitTestRunner/TestController.h:
915         * WebKitTestRunner/TestInvocation.cpp:
916         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
917
918 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
919
920         [ews-app] Rename ews model Builds to Build
921         https://bugs.webkit.org/show_bug.cgi?id=193695
922
923         Reviewed by Lucas Forschler.
924
925         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
926         (Build): Renamed Builds to Build.
927
928 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
929
930         webkitpy: Wait longer when launching WebKitTestRunner
931         https://bugs.webkit.org/show_bug.cgi?id=193734
932
933         Reviewed by Aakash Jain.
934
935         * Scripts/webkitpy/port/simulator_process.py:
936         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
937
938 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
939
940         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
941         https://bugs.webkit.org/show_bug.cgi?id=193182
942         <rdar://problem/47452154>
943
944         Reviewed by Tim Horton.
945
946         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
947         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
948         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
949
950         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
951         preventing later tests from recognizing gestures.
952
953         * WebKitTestRunner/ios/TestControllerIOS.mm:
954         (WTR::TestController::platformResetStateToConsistentValues):
955
956         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
957
958 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
959
960         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
961         https://bugs.webkit.org/show_bug.cgi?id=193722
962         <rdar://problem/47481475>
963
964         Reviewed by Lucas Forschler.
965
966         iPhone and iPad ports should both use the iOS config.
967
968         * Scripts/webkitpy/port/ios_simulator.py:
969         (IPhoneSimulatorPort.__init__):
970         (IPadSimulatorPort.__init__):
971
972 2019-01-23  Rob Buis  <rbuis@igalia.com>
973
974         Update MIME type parser
975         https://bugs.webkit.org/show_bug.cgi?id=180526
976
977         Reviewed by Frédéric Wang.
978
979         Add unit tests for both parse modes of ParsedContentType.
980
981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
982         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
983         (TestWebKitAPI::TEST):
984
985 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
986
987         [ews-app] fetch loop should not stop on network issues
988         https://bugs.webkit.org/show_bug.cgi?id=193666
989
990         Reviewed by Lucas Forschler.
991
992         * BuildSlaveSupport/ews-app/ews/fetcher.py:
993         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
994
995 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
996
997         [iOS] Multiple WKWebViewAutofillTests are flaky failures
998         https://bugs.webkit.org/show_bug.cgi?id=189165
999         <rdar://problem/47433765>
1000
1001         Reviewed by Tim Horton.
1002
1003         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
1004         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
1005         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
1006         process in sufficient to ensure that any previous action that blurred the focused element in the web process
1007         would make its way to the UI process by the time the layer tree commit is finished.
1008
1009         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
1010         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
1011         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
1012         will fail because it asks for -_autofillContext too early.
1013
1014         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
1015         is handled in the UI process.
1016
1017         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1018
1019         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
1020         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
1021         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
1022         input session.
1023
1024         (-[AutofillTestView textInputHasAutofillContext]):
1025
1026         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
1027
1028         * TestWebKitAPI/cocoa/TestWKWebView.h:
1029         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1030         (nextInputSessionChangeCount):
1031
1032         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
1033         This includes changing the focused element from one to another.
1034
1035         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1036         (-[TestWKWebView didStartFormControlInteraction]):
1037         (-[TestWKWebView didEndFormControlInteraction]):
1038         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1039
1040         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
1041         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
1042         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
1043         that doesn't require an input session to one that doesn't.
1044
1045 2019-01-22  David Kilzer  <ddkilzer@apple.com>
1046
1047         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
1048         <https://webkit.org/b/193676>
1049
1050         Reviewed by Alexey Proskuryakov.
1051
1052         * Scripts/webkitpy/style/checkers/cpp.py:
1053         (check_member_initialization_list):
1054         - Don't report missing whitespace around colon if the colon at
1055           the start of the line is formatted correctly.
1056         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1057         (WebKitStyleTest.test_member_initialization_list):
1058         - Add a test for a missing permutation of existing tests.
1059         - Add a test this false-positive.
1060         - Add blank lines between subtests to make them easier to read.
1061
1062 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1063
1064         [build.webkit.org] Unit-test failure after r237113
1065         https://bugs.webkit.org/show_bug.cgi?id=193669
1066
1067         Reviewed by Michael Catanzaro.
1068
1069         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1070         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
1071         multiple or zero flags.
1072
1073 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
1074
1075         Cache bytecode to disk
1076         https://bugs.webkit.org/show_bug.cgi?id=192782
1077         <rdar://problem/46084932>
1078
1079         Reviewed by Keith Miller.
1080
1081         Add test helper to execute bytecode-cache tests: it executes each test
1082         twice, the first with JSC_diskCachePath set to a temporary directory
1083         and second with JSC_forceDiskCache=true (in addition to the cache path)
1084         to guarantee that only the disk cache is being used and no new
1085         UnlinkedCodeBlocks are being created.
1086
1087         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
1088         * Scripts/run-jsc-stress-tests:
1089
1090 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
1091
1092         [css-logical] Implement flow-relative margin, padding and border shorthands
1093         https://bugs.webkit.org/show_bug.cgi?id=188697
1094
1095         Reviewed by Simon Fraser and Antti Koivisto.
1096
1097         * DumpRenderTree/TestOptions.cpp:
1098         (TestOptions::TestOptions):
1099         * DumpRenderTree/TestOptions.h:
1100         * DumpRenderTree/mac/DumpRenderTree.mm:
1101         (setWebPreferencesForTestOptions):
1102         Allow tests to enable the CSSLogicalEnabled flag in WK1.
1103
1104         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1105         (JSONCSSPropertiesChecker.check_codegen_properties):
1106         Allow CSS property definitions to have a 'runtime-flag' parameter which
1107         disables the property when the specified runtime flag is disabled.
1108
1109 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1110
1111         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
1112         https://bugs.webkit.org/show_bug.cgi?id=193643
1113
1114         Reviewed by Michael Catanzaro.
1115
1116         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
1117         * wpe/jhbuild.modules: Ditto.
1118
1119 2019-01-21  Zalan Bujtas  <zalan@apple.com>
1120
1121         [LFC][Floats] Take float top position into account when computing containing block height.
1122         https://bugs.webkit.org/show_bug.cgi?id=193655
1123
1124         Reviewed by Antti Koivisto.
1125
1126         * LayoutReloaded/misc/LFC-passing-tests.txt:
1127
1128 2019-01-21  David Kilzer  <ddkilzer@apple.com>
1129
1130         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
1131         <https://webkit.org/b/193645>
1132         <rdar://problem/47421574>
1133
1134         Reviewed by Alex Christensen.
1135
1136         - Now checks for local soft-linking of all frameworks that have
1137           their own *SoftLinking.{cpp,h,mm} files.
1138         - Changes softlink/uikit warning to softlink/framework.
1139
1140         * Scripts/webkitpy/style/checkers/cpp.py:
1141         (check_language):
1142         (CppChecker):
1143         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1144         (CppStyleTest):
1145
1146 2019-01-20  Saam Barati  <sbarati@apple.com>
1147
1148         Rollout r240210: It broke tests on iOS
1149         https://bugs.webkit.org/show_bug.cgi?id=193640
1150
1151         Unreviewed.
1152
1153         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
1154         * Scripts/run-jsc-stress-tests:
1155
1156 2019-01-20  chris fleizach  <cfleizach@apple.com>
1157
1158         AX: Support returning relative frames for accessibility
1159         https://bugs.webkit.org/show_bug.cgi?id=193414
1160         <rdar://problem/47268501>
1161
1162         Reviewed by Zalan Bujtas.
1163
1164         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1165         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1166         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1167         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1168         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1169         (WTR::attributesOfElement):
1170         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1171
1172 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
1173
1174         Unreviewed, add my new email address
1175
1176         * Scripts/webkitpy/common/config/contributors.json:
1177
1178 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1179
1180         [LFC][BFC] <body>'s overflow property value is propagated to viewport
1181         https://bugs.webkit.org/show_bug.cgi?id=193617
1182
1183         Reviewed by Antti Koivisto.
1184
1185         * LayoutReloaded/misc/LFC-passing-tests.txt:
1186
1187 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1188
1189         Unreviewed, rolling out r240209.
1190
1191         Broke GTK/WPE injected bundle
1192
1193         Reverted changeset:
1194
1195         "AX: Support returning relative frames for accessibility"
1196         https://bugs.webkit.org/show_bug.cgi?id=193414
1197         https://trac.webkit.org/changeset/240209
1198
1199 2019-01-12  Dan Bernstein  <mitz@apple.com>
1200
1201         [Cocoa] Avoid importing directly from subumbrella frameworks
1202         https://bugs.webkit.org/show_bug.cgi?id=186016
1203         <rdar://problem/40591038>
1204
1205         Reviewed by Sam Weinig.
1206
1207         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1208           LaunchServices header.
1209         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1210           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1211         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1212           when using SDKs earlier than 10.13.
1213         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1214           and OTHER_CPLUSPLUSFLAGS.
1215         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1216           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1217         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1218           LaunchServices header.
1219
1220 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
1221
1222         Cache bytecode to disk
1223         https://bugs.webkit.org/show_bug.cgi?id=192782
1224         <rdar://problem/46084932>
1225
1226         Reviewed by Keith Miller.
1227
1228         Add test helper to execute bytecode-cache tests: it executes each test
1229         twice, the first with JSC_diskCachePath set to a temporary directory
1230         and second with JSC_forceDiskCache=true (in addition to the cache path)
1231         to guarantee that only the disk cache is being used and no new
1232         UnlinkedCodeBlocks are being created.
1233
1234         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
1235         * Scripts/run-jsc-stress-tests:
1236
1237 2019-01-20  chris fleizach  <cfleizach@apple.com>
1238
1239         AX: Support returning relative frames for accessibility
1240         https://bugs.webkit.org/show_bug.cgi?id=193414
1241         <rdar://problem/47268501>
1242
1243         Reviewed by Zalan Bujtas.
1244
1245         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1246         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1247         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1248         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1249         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1250         (WTR::attributesOfElement):
1251         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1252
1253 2019-01-20  Antoine Quint  <graouts@apple.com>
1254
1255         Add a POINTER_EVENTS feature flag
1256         https://bugs.webkit.org/show_bug.cgi?id=193577
1257         <rdar://problem/47408511>
1258
1259         Unreviewed. Also enable Pointer Events for iosmac.
1260
1261         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1262
1263 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1264
1265         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
1266         https://bugs.webkit.org/show_bug.cgi?id=193613
1267
1268         Reviewed by Antti Koivisto.
1269
1270         * LayoutReloaded/misc/LFC-passing-tests.txt:
1271
1272 2019-01-19  Antoine Quint  <graouts@apple.com>
1273
1274         Add a POINTER_EVENTS feature flag
1275         https://bugs.webkit.org/show_bug.cgi?id=193577
1276
1277         Reviewed by Dean Jackson.
1278
1279         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1280
1281 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
1282
1283         Disable the run-jsc-stress-test remote host key check [second round].
1284         https://bugs.webkit.org/show_bug.cgi?id=192988
1285
1286         Reviewed by Dewei Zhu.
1287
1288         * Scripts/run-jsc-stress-tests:
1289
1290 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1291
1292         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
1293         https://bugs.webkit.org/show_bug.cgi?id=193597
1294
1295         Reviewed by Lucas Forschler.
1296
1297         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1298
1299 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1300
1301         [build.webkit.org] api tests failures are incorrectly named as unit test failures
1302         https://bugs.webkit.org/show_bug.cgi?id=193595
1303
1304         Reviewed by Lucas Forschler.
1305
1306         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
1307         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
1308         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
1309
1310 2019-01-18  Chris Dumez  <cdumez@apple.com>
1311
1312         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
1313         https://bugs.webkit.org/show_bug.cgi?id=193588
1314         <rdar://problem/47131566>
1315
1316         Reviewed by Alex Christensen.
1317
1318         Add layout test coverage.
1319
1320         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1321
1322 2019-01-18  Jer Noble  <jer.noble@apple.com>
1323
1324         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1325         https://bugs.webkit.org/show_bug.cgi?id=189553
1326
1327         Reviewed by Tim Horton.
1328
1329         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1330
1331         * ContentExtensionTester/Configurations/Base.xcconfig:
1332         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1333         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1334         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1335         * ImageDiff/cg/Configurations/Base.xcconfig:
1336         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1337         * MiniBrowser/Configurations/Base.xcconfig:
1338         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1339         * MobileMiniBrowser/Configurations/Base.xcconfig:
1340         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1341         * Scripts/webkitpy/style/checker.py:
1342         (_all_categories):
1343         (FileType):
1344         (CheckerDispatcher._file_type):
1345         (CheckerDispatcher._create_checker):
1346         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1347         (SDKVariantChecker):
1348         (SDKVariantChecker.__init__):
1349         (SDKVariantChecker.check):
1350         * TestWebKitAPI/Configurations/Base.xcconfig:
1351         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1352         * WebEditingTester/Configurations/Base.xcconfig:
1353         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1354         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1355         * WebKitTestRunner/Configurations/Base.xcconfig:
1356         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1357         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1358         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1359
1360 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1361
1362         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1363         <https://webkit.org/b/193568>
1364         <rdar://problem/47381130>
1365
1366         Reviewed by Alex Christensen.
1367
1368         Make sure no one re-introduces UIKit soft-linking by adding a
1369         style rule.
1370
1371         * Scripts/webkitpy/style/checkers/cpp.py:
1372         (check_language): Add softlink/uikit check.
1373         (CppChecker): Enable softlink/uikit check.
1374         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1375         (CppStyleTest): Add test for softlink/uikit.
1376
1377 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1378
1379         [GTK] install-dependencies tool looks for libunistring-dev for dnf
1380         https://bugs.webkit.org/show_bug.cgi?id=193584
1381
1382         Change "-dev" to "-devel".
1383
1384         Reviewed by Michael Catanzaro.
1385
1386         * gtk/install-dependencies:
1387
1388 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1389
1390         webkitpy: Add iPhone and iPad ports
1391         https://bugs.webkit.org/show_bug.cgi?id=193537
1392         <rdar://problem/47353390>
1393
1394         Reviewed by Lucas Forschler.
1395
1396         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
1397         ports. Note that this separation is optional, the --ios-simulator command remains.
1398
1399         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1400         (RunTest.test_device_type_test_division): Drive-by fix.
1401         (RunTest.test_device_type_specific_listing): Ditto.
1402         (RunTest.test_ipad_test_division):
1403         (RunTest):
1404         (RunTest.test_ipad_listing):
1405         * Scripts/webkitpy/port/factory.py:
1406         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
1407         (PortFactory):
1408         * Scripts/webkitpy/port/ios_simulator.py:
1409         (IPhoneSimulatorPort):
1410         (IPadSimulatorPort):
1411
1412 2019-01-18  Chris Dumez  <cdumez@apple.com>
1413
1414         Regression(PSON) Scroll position is not always restored properly when navigating back
1415         https://bugs.webkit.org/show_bug.cgi?id=193578
1416         <rdar://problem/47386331>
1417
1418         Reviewed by Tim Horton.
1419
1420         Add API test coverage.
1421
1422         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1423
1424 2019-01-18  Youenn Fablet  <youenn@apple.com>
1425
1426         Add a new SPI to request for cache storage quota increase
1427         https://bugs.webkit.org/show_bug.cgi?id=193323
1428
1429         Reviewed by Alex Christensen.
1430
1431         Implement WebsiteDataStore quota delegate to handle quota requests.
1432         By default, do not update quota.
1433         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
1434
1435         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1436         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1437         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
1438         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1439         * WebKitTestRunner/TestController.cpp:
1440         (WTR::TestController::allowCacheStorageQuotaIncrease):
1441         * WebKitTestRunner/TestController.h:
1442         * WebKitTestRunner/TestInvocation.cpp:
1443         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1444         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1445         (-[CacheStorageQuotaManager init]):
1446         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1447         (WTR::initializeWebViewConfiguration):
1448         (WTR::TestController::cocoaResetStateToConsistentValues):
1449         (WTR::TestController::allowCacheStorageQuotaIncrease):
1450
1451 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1452
1453         [ews-build] Pass owner to the triggered builds
1454         https://bugs.webkit.org/show_bug.cgi?id=193574
1455
1456         Reviewed by Lucas Forschler.
1457
1458         * BuildSlaveSupport/ews-build/factories.py:
1459         (BuildFactory.propertiesToPassToTriggers):
1460
1461 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1462
1463         [ews-app] Send patch author as a build property
1464         https://bugs.webkit.org/show_bug.cgi?id=193560
1465
1466         Reviewed by Lucas Forschler.
1467
1468         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1469         (BugzillaPatchFetcher.fetch):
1470
1471 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1472
1473         webkitpy: Implement device type specific expected results (Follow-up fix)
1474         https://bugs.webkit.org/show_bug.cgi?id=192162
1475         <rdar://problem/46345449>
1476
1477         Unreviewed infrastructure fix.
1478
1479         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1480         (Manager.run): Don't boot a device if no tests are available to run on it.
1481
1482 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1483
1484         webkitpy: Implement device type specific expected results (Follow-up fix)
1485         https://bugs.webkit.org/show_bug.cgi?id=192162
1486         <rdar://problem/46345449>
1487
1488         Unreviewed infrastructure fix.
1489
1490         * Scripts/webkitpy/api_tests/manager.py:
1491         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
1492
1493 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1494
1495         webkitpy: Implement device type specific expected results (Part 2)
1496         https://bugs.webkit.org/show_bug.cgi?id=192162
1497         <rdar://problem/46345449>
1498
1499         Rubber-stamped by Aakash Jain.
1500
1501         This change uses device_type to select a different set of TestExpectation files based on the type of device running
1502         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
1503         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
1504
1505         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1506         (LayoutTestFinder.find_tests): Pass device_type through.
1507         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
1508         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
1509         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1510         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
1511         (Manager._collect_tests): Pass device type to test finder.
1512         (Manager._needs_web_platform_test):
1513         (Manager._prepare_lists): Index _expectations by device type.
1514         (Manager._test_input_for_file):
1515         (Manager._test_is_slow): Ditto.
1516         (Manager._test_should_dump_jsconsolelog_in_stderr):
1517         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
1518         (Manager._get_test_inputs):
1519         (Manager._update_worker_count):
1520         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
1521         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
1522         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
1523         the one which runs the test.
1524         (Manager._run_test_subset):
1525         (Manager._run_tests): Index _expectations by current_device_type.
1526         (Manager._print_expectation_line_for_test): Ditto.
1527         (Manager._print_expectations_for_subset): Ditto.
1528         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
1529         Unlike run, this function will behave the same regardless of what devices are available.
1530         (Manager._custom_device_for_test): Deleted.
1531         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1532         (ManagerTest.test_uses_custom_device): Deleted.
1533         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
1534         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1535         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
1536         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
1537         all of the expectations.
1538         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1539         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
1540         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1541         (TestExpectations.__init__): Allow device_type to be passed through.
1542         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
1543         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
1544         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1545         (summarize_results):
1546         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1547         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
1548         a test ran with, one must check all expectations to find the first non-skip expectation.
1549         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1550         (RunTest.test_device_type_test_division):
1551         (RunTest):
1552         (RunTest.test_device_type_specific_listing):
1553         * Scripts/webkitpy/port/base.py:
1554         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
1555         (Port.supported_device_types): The result of this function will change based on what devices are available.
1556         * Scripts/webkitpy/port/device_port.py:
1557         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1558         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1559         can be used.
1560         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1561         any, or the DEFAULT_DEVICE_TYPES of the port.
1562         * Scripts/webkitpy/port/ios.py:
1563         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1564         * Scripts/webkitpy/port/ios_simulator.py:
1565         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1566         * Scripts/webkitpy/port/watch.py:
1567         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1568         * Scripts/webkitpy/port/watch_simulator.py:
1569         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1570         * Scripts/webkitpy/xcode/device_type.py:
1571         (DeviceType):
1572         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1573
1574 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1575
1576         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1577         https://bugs.webkit.org/show_bug.cgi?id=193575
1578
1579         Reviewed by Michael Catanzaro.
1580
1581         Allow the script to run without explicit port argument because
1582         it's specific to the WPE port anyway.
1583
1584         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1585         and simplify the rest of the code accordingly.
1586
1587 2019-01-18  Charlie Turner  <cturner@igalia.com>
1588
1589         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1590         https://bugs.webkit.org/show_bug.cgi?id=192229
1591
1592         Reviewed by Xabier Rodriguez-Calvar.
1593
1594         * MiniBrowser/wpe/main.cpp:
1595         (main): Enable encrypted-media by default.
1596
1597 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1598
1599         [Flatpak] Missing KeyboardInterrupt exception handler
1600         https://bugs.webkit.org/show_bug.cgi?id=193570
1601
1602         Reviewed by Michael Catanzaro.
1603
1604         * flatpak/flatpakutils.py:
1605         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1606
1607 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1608
1609         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1610         https://bugs.webkit.org/show_bug.cgi?id=193564
1611
1612         Reviewed by Antti Koivisto.
1613
1614         * LayoutReloaded/misc/LFC-passing-tests.txt:
1615
1616 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1617
1618         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1619         https://bugs.webkit.org/show_bug.cgi?id=193562
1620
1621         Reviewed by Antti Koivisto.
1622
1623         * LayoutReloaded/misc/LFC-passing-tests.txt:
1624
1625 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1626
1627         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1628         https://bugs.webkit.org/show_bug.cgi?id=193555
1629
1630         Reviewed by Antti Koivisto.
1631
1632         * LayoutReloaded/misc/LFC-passing-tests.txt:
1633
1634 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1635
1636         [WPE] Add Qt extension
1637         https://bugs.webkit.org/show_bug.cgi?id=191464
1638
1639         Reviewed by Carlos Garcia Campos.
1640
1641         MiniBrowser and API tests for the WPE Qt API. To run the
1642         MiniBrowser a new script is introduced. Example invocation:
1643
1644         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1645
1646         Also note-worthy is the introduction of the python2-subprocess32
1647         dependency to run the GLib API tests.
1648
1649         * MiniBrowser/wpe/CMakeLists.txt:
1650         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1651         * MiniBrowser/wpe/qt/main.cpp: Added.
1652         (main):
1653         * MiniBrowser/wpe/qt/main.qml: Added.
1654         * MiniBrowser/wpe/qt/qml.qrc: Added.
1655         * Scripts/run-gtk-tests:
1656         (GtkTestRunner.is_google_test):
1657         (GtkTestRunner):
1658         (GtkTestRunner.is_qt_test):
1659         * Scripts/run-qt-wpe-minibrowser: Added.
1660         * Scripts/run-wpe-tests:
1661         (WPETestRunner):
1662         (WPETestRunner.is_google_test):
1663         (WPETestRunner.is_qt_test):
1664         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1665         (TestLoad::main):
1666         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1667         (TestLoadHtml::main):
1668         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1669         (TestLoadRequest::main):
1670         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1671         (TestRunJavaScript::main):
1672         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1673         (waitForSignal):
1674         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1675         (LoadSpy::LoadSpy):
1676         (LoadSpy::~LoadSpy):
1677         (LoadSpy::onLoadingChanged):
1678         (LoadStartedCatcher::LoadStartedCatcher):
1679         (LoadStartedCatcher::~LoadStartedCatcher):
1680         (LoadStartedCatcher::onLoadingChanged):
1681         (waitForLoadSucceeded):
1682         (waitForLoadFailed):
1683         * TestWebKitAPI/glib/CMakeLists.txt:
1684         * flatpak/flatpakutils.py:
1685         (WebkitFlatpak.load_from_args):
1686         (WebkitFlatpak.__init__):
1687         (WebkitFlatpak.clean_args):
1688         (WebkitFlatpak.run_in_sandbox):
1689         * flatpak/org.webkit.CommonModules.yaml:
1690         * flatpak/org.webkit.WPE.yaml:
1691         * flatpak/org.webkit.WPEModules.yaml:
1692         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1693         * flatpak/org.webkit.WebKit.yaml:
1694         * glib/api_test_runner.py:
1695         (TestRunner._run_test_qt):
1696         (TestRunner.is_qt_test):
1697         (TestRunner._run_test):
1698
1699 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1700
1701         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1702         https://bugs.webkit.org/show_bug.cgi?id=193494
1703         <rdar://problem/46859627>
1704
1705         Reviewed by Simon Fraser and Tim Horton.
1706
1707         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1708         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1709
1710         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1711         (WTR::UIScriptController::contentOffsetX const):
1712         (WTR::UIScriptController::contentOffsetY const):
1713         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1714         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1715         (WTR::UIScriptController::contentOffsetX const):
1716         (WTR::UIScriptController::contentOffsetY const):
1717         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1718
1719         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1720
1721         * WebKitTestRunner/TestController.cpp:
1722         (WTR::updateTestOptionsFromTestHeader):
1723         * WebKitTestRunner/TestOptions.h:
1724         (WTR::TestOptions::hasSameInitializationOptions const):
1725         * WebKitTestRunner/ios/TestControllerIOS.mm:
1726         (WTR::TestController::platformResetStateToConsistentValues):
1727         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1728         (WTR::UIScriptController::contentOffsetX const):
1729         (WTR::UIScriptController::contentOffsetY const):
1730
1731 2019-01-17  Truitt Savell  <tsavell@apple.com>
1732
1733         Unreviewed, rolling out r240124.
1734
1735         This commit broke an internal build.
1736
1737         Reverted changeset:
1738
1739         "SDK_VARIANT build destinations should be separate from non-
1740         SDK_VARIANT builds"
1741         https://bugs.webkit.org/show_bug.cgi?id=189553
1742         https://trac.webkit.org/changeset/240124
1743
1744 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1745
1746         Fix string concatenation API test after r239920
1747         https://bugs.webkit.org/show_bug.cgi?id=193551
1748         <rdar://problem/47359304>
1749
1750         Reviewed by Youenn Fablet.
1751
1752         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1753         (TestWebKitAPI::TEST):
1754         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1755         in WebKit's build configuration like it apparently is on Linux.
1756
1757 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1758
1759         [ews-build] validate-patch should handle the case when bug_id is None
1760         https://bugs.webkit.org/show_bug.cgi?id=193547
1761
1762         Reviewed by Lucas Forschler.
1763
1764         * BuildSlaveSupport/ews-build/steps.py:
1765         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1766         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1767
1768 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1769
1770         [ews-build] Add patch author information in build
1771         https://bugs.webkit.org/show_bug.cgi?id=193465
1772
1773         Reviewed by Lucas Forschler.
1774
1775         * BuildSlaveSupport/ews-build/steps.py:
1776         (ValidatePatch._is_patch_obsolete):
1777
1778 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1779
1780         [ews-build] Pass bug_id to the triggered builds
1781         https://bugs.webkit.org/show_bug.cgi?id=193548
1782
1783         Reviewed by Lucas Forschler.
1784
1785         * BuildSlaveSupport/ews-build/factories.py:
1786         (BuildFactory.propertiesToPassToTriggers):
1787
1788 2019-01-17  Jer Noble  <jer.noble@apple.com>
1789
1790         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1791         https://bugs.webkit.org/show_bug.cgi?id=189553
1792
1793         Reviewed by Tim Horton.
1794
1795         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1796
1797         * ContentExtensionTester/Configurations/Base.xcconfig:
1798         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1799         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1800         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1801         * ImageDiff/cg/Configurations/Base.xcconfig:
1802         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1803         * MiniBrowser/Configurations/Base.xcconfig:
1804         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1805         * MobileMiniBrowser/Configurations/Base.xcconfig:
1806         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1807         * Scripts/webkitpy/style/checker.py:
1808         (_all_categories):
1809         (FileType):
1810         (CheckerDispatcher._file_type):
1811         (CheckerDispatcher._create_checker):
1812         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1813         (SDKVariantChecker):
1814         (SDKVariantChecker.__init__):
1815         (SDKVariantChecker.check):
1816         * TestWebKitAPI/Configurations/Base.xcconfig:
1817         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1818         * WebEditingTester/Configurations/Base.xcconfig:
1819         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1820         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1821         * WebKitTestRunner/Configurations/Base.xcconfig:
1822         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1823         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1824         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1825
1826 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1827
1828         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1829         https://bugs.webkit.org/show_bug.cgi?id=193534
1830
1831         Reviewed by Antti Koivisto.
1832
1833         * LayoutReloaded/misc/LFC-passing-tests.txt:
1834
1835 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1836
1837         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1838         https://bugs.webkit.org/show_bug.cgi?id=193528
1839
1840         Reviewed by Antti Koivisto.
1841
1842         * LayoutReloaded/misc/LFC-passing-tests.txt:
1843
1844 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1845
1846         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1847         https://bugs.webkit.org/show_bug.cgi?id=193520
1848
1849         Reviewed by Antti Koivisto.
1850
1851         * LayoutReloaded/misc/LFC-passing-tests.txt:
1852
1853 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1854
1855         [ews-build] unapply-patch step should not update source
1856         https://bugs.webkit.org/show_bug.cgi?id=193234
1857
1858         Reviewed by Lucas Forschler.
1859
1860         * BuildSlaveSupport/ews-build/steps.py:
1861         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1862         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1863
1864 2019-01-16  Youenn Fablet  <youenn@apple.com>
1865
1866         Add a new SPI for controlling getUserMedia
1867         https://bugs.webkit.org/show_bug.cgi?id=192793
1868
1869         Reviewed by Eric Carlson.
1870
1871         * MiniBrowser/mac/WK2BrowserWindowController.m:
1872         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1873         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1874         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1875         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1876         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1877         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1878         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1879         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1880         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1881         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1882         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1883         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1884         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1885         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1886
1887 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1888
1889         [LFC][BFC] Inflow non-replaced used width should not be negative.
1890         https://bugs.webkit.org/show_bug.cgi?id=193495
1891
1892         Reviewed by Antti Koivisto.
1893
1894         * LayoutReloaded/misc/LFC-passing-tests.txt:
1895
1896 2019-01-16  Chris Dumez  <cdumez@apple.com>
1897
1898         Regression(PSON) View becomes blank after click a cross-site download link
1899         https://bugs.webkit.org/show_bug.cgi?id=193361
1900         <rdar://problem/47099573>
1901
1902         Reviewed by Geoffrey Garen.
1903
1904         Add API test coverage.
1905
1906         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1907         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1908
1909 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1910
1911         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1912         https://bugs.webkit.org/show_bug.cgi?id=193470
1913
1914         Reviewed by Antti Koivisto.
1915
1916         * LayoutReloaded/misc/LFC-passing-tests.txt:
1917
1918 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1919
1920         [LFC] Adjust margin box verification.
1921         https://bugs.webkit.org/show_bug.cgi?id=193482
1922
1923         Reviewed by Antti Koivisto.
1924
1925         * LayoutReloaded/misc/LFC-passing-tests.txt:
1926
1927 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1928
1929         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1930         https://bugs.webkit.org/show_bug.cgi?id=193451
1931
1932         Reviewed by Geoffrey Garen.
1933
1934         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1935         (TEST):
1936         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1937         (runWebsiteDataStoreCustomPaths):
1938
1939 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1940
1941         webkitpy: Support boolean simctl isAvailable
1942         https://bugs.webkit.org/show_bug.cgi?id=193472
1943         <rdar://problem/47296150>
1944
1945         Reviewed by Ryosuke Niwa.
1946
1947         * Scripts/webkitpy/xcode/simulated_device.py:
1948         (SimulatedDeviceManager._create_runtimes):
1949         (SimulatedDeviceManager._create_device_with_runtime):
1950
1951 2019-01-15  Chris Dumez  <cdumez@apple.com>
1952
1953         Unreviewed, rolling out r239993, r239995, r239997, and
1954         r239999.
1955
1956         Caused assertions under
1957         ViewGestureController::disconnectFromProcess()
1958
1959         Reverted changesets:
1960
1961         "Regression(PSON) View becomes blank after click a cross-site
1962         download link"
1963         https://bugs.webkit.org/show_bug.cgi?id=193361
1964         https://trac.webkit.org/changeset/239993
1965
1966         "Unreviewed iOS build fix after r239993."
1967         https://trac.webkit.org/changeset/239995
1968
1969         "Fix iOS build after r239993"
1970         https://bugs.webkit.org/show_bug.cgi?id=193361
1971         https://trac.webkit.org/changeset/239997
1972
1973         "Unreviewed, revert part of r239997 as it is not needed to fix
1974         the build."
1975         https://trac.webkit.org/changeset/239999
1976
1977 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1978
1979         Cannot tab out of WKWebView on macOS
1980         https://bugs.webkit.org/show_bug.cgi?id=161448
1981         <rdar://problem/28100085>
1982
1983         Reviewed by Dean Jackson.
1984
1985         Add a test that tabbing into and out of WKWebView works correctly.
1986
1987         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1988         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1989         (WebKit2_CommandBackForwardTest::SetUp):
1990         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1991         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1992         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1993         (-[FocusableView canBecomeKeyView]):
1994         (TEST):
1995         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1996         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1997         (-[OffscreenWindow initWithSize:]):
1998         (-[OffscreenWindow isKeyWindow]):
1999         (-[OffscreenWindow isVisible]):
2000         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2001         (TestWebKitAPI::PlatformWebView::initialize):
2002         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
2003         (-[ActiveOffscreenWindow isVisible]): Deleted.
2004         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
2005
2006 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
2007
2008         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
2009         https://bugs.webkit.org/show_bug.cgi?id=193459
2010
2011         Reviewed by Mark Lam.
2012
2013         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2014         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
2015
2016 2019-01-15  Chris Dumez  <cdumez@apple.com>
2017
2018         Regression(PSON) View becomes blank after click a cross-site download link
2019         https://bugs.webkit.org/show_bug.cgi?id=193361
2020         <rdar://problem/47099573>
2021
2022         Reviewed by Geoff Garen.
2023
2024         Add API test coverage.
2025
2026         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2027         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2028
2029 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2030
2031         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
2032         https://bugs.webkit.org/show_bug.cgi?id=193448
2033
2034         Reviewed by Antti Koivisto.
2035
2036         * LayoutReloaded/misc/LFC-passing-tests.txt:
2037
2038 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2039
2040         webkitpy: Implement device type specific expected results (Part 1)
2041         https://bugs.webkit.org/show_bug.cgi?id=192162
2042
2043         Reviewed by Lucas Forschler.
2044
2045         Device type specific expected results covers two related ideas. The first (covered by this change)
2046         is where to search for -expected.* files. The second is which tests to run based on the
2047         TestExpectations.txt file.
2048
2049         After this change, the baseline search path will be determined by the type of device running a
2050         test. Device type will be passed into any function which picks a file based on the baseline search
2051         path.
2052
2053         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2054         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
2055         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2056         (Manager.run): Print baseline search path for each round of devices.
2057         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2058         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
2059         (SingleTestRunner._expected_driver_output): Ditto.
2060         (SingleTestRunner._driver_input): Ditto.
2061         * Scripts/webkitpy/layout_tests/views/printing.py:
2062         (Printer.print_config): Move printing of baseline search path to a separate function.
2063         (Printer.print_baseline_search_path): Moved from Printer.print_config.
2064         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2065         (Testprinter.test_print_config):
2066         (Testprinter.test_print_baseline_search_path):
2067         * Scripts/webkitpy/port/base.py:
2068         (Port.baseline_search_path): Pass device_type through.
2069         (Port._expected_baselines_for_suffixes): Ditto.
2070         (Port.expected_baselines): Ditto.
2071         (Port.expected_filename): Ditto.
2072         (Port.expected_checksum): Ditto.
2073         (Port.expected_image): Ditto.
2074         (Port.expected_audio): Ditto.
2075         (Port.expected_text): Ditto.
2076         (Port.reference_files): Ditto.
2077         (Port.tests): Ditto.
2078         (Port._expanded_paths): Ditto.
2079         (Port.skipped_layout_tests): Ditto.
2080         (Port.expectations_dict): Ditto.
2081         (Port._port_specific_expectations_files): Ditto.
2082         (Port.expectations_files): Ditto.
2083         (Port.test_search_path): Ditto.
2084         (Port._tests_for_other_platforms): Ditto.
2085         * Scripts/webkitpy/port/base_unittest.py:
2086         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
2087         (PortTest.test_nonexistant_expectations): Ditto.
2088         (test_ref_tests_platform_directory): Ditto.
2089         * Scripts/webkitpy/port/darwin.py:
2090         (DarwinPort._port_specific_expectations_files): Accept device_type.
2091         * Scripts/webkitpy/port/driver.py:
2092         (DriverProxy):
2093         (DriverProxy.host): Expose _target_host for device_type information.
2094         * Scripts/webkitpy/port/gtk.py:
2095         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
2096         * Scripts/webkitpy/port/ios.py:
2097         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2098         * Scripts/webkitpy/port/mac.py:
2099         (MacPort. default_baseline_search_path): Ditto.
2100         * Scripts/webkitpy/port/port_testcase.py:
2101         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
2102         * Scripts/webkitpy/port/test.py:
2103         * Scripts/webkitpy/port/watch.py:
2104         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2105         * Scripts/webkitpy/port/win.py:
2106         (WinPort.test_search_path): Accept, but do not use, device_type.
2107         * Scripts/webkitpy/port/wpe.py:
2108         (WPEPort._port_specific_expectations_files): Ditto.
2109         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2110         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
2111
2112 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2113
2114         [LFC] Use the containing block's padding box to position out-of-flow elements.
2115         https://bugs.webkit.org/show_bug.cgi?id=193431
2116
2117         Reviewed by Antti Koivisto.
2118
2119         * LayoutReloaded/misc/LFC-passing-tests.txt:
2120
2121 2019-01-14  Tim Horton  <timothy_horton@apple.com>
2122
2123         Move a test implementation file that got misplaced in the Xcode project
2124
2125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2126
2127 2019-01-14  Commit Queue  <commit-queue@webkit.org>
2128
2129         Unreviewed, rolling out r239901, r239909, r239910, r239912,
2130         r239913, and r239914.
2131         https://bugs.webkit.org/show_bug.cgi?id=193407
2132
2133         These revisions caused an internal failure (Requested by
2134         Truitt on #webkit).
2135
2136         Reverted changesets:
2137
2138         "[Cocoa] Avoid importing directly from subumbrella frameworks"
2139         https://bugs.webkit.org/show_bug.cgi?id=186016
2140         https://trac.webkit.org/changeset/239901
2141
2142         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
2143         https://trac.webkit.org/changeset/239909
2144
2145         "Tried to fix the build."
2146         https://trac.webkit.org/changeset/239910
2147
2148         "Fixed iOS builds after r239910."
2149         https://trac.webkit.org/changeset/239912
2150
2151         "More build fixing."
2152         https://trac.webkit.org/changeset/239913
2153
2154         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
2155         https://trac.webkit.org/changeset/239914
2156
2157 2019-01-14  Mark Lam  <mark.lam@apple.com>
2158
2159         Re-enable ability to build --cloop builds.
2160         https://bugs.webkit.org/show_bug.cgi?id=192955
2161         <rdar://problem/46882363>
2162
2163         Reviewed by Saam barati and Keith Miller.
2164
2165         The --cloop build option was being ignored this whole time since r236381.
2166         This patch makes it possible to build CLoop builds again.
2167
2168         * Scripts/build-jsc:
2169         * Scripts/webkitperl/FeatureList.pm:
2170         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2171
2172 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2173
2174         webkitpy: Expose device_type from host-like objects
2175         https://bugs.webkit.org/show_bug.cgi?id=193406
2176         <rdar://problem/47262305>
2177
2178         Reviewed by Lucas Forschler.
2179
2180         Devices should expose device_type. As a result, all host objects should
2181         provide a device_type property, even if they do not yet define a device_type.
2182
2183         * Scripts/webkitpy/common/system/systemhost.py:
2184         (SystemHost):
2185         (SystemHost.device_type):
2186         * Scripts/webkitpy/common/system/systemhost_mock.py:
2187         (MockSystemHost):
2188         (MockSystemHost.device_type):
2189         * Scripts/webkitpy/port/device.py:
2190         (Device):
2191         (Device.device_type):
2192         * Scripts/webkitpy/xcode/simulated_device.py:
2193         (SimulatedDeviceManager._find_exisiting_device_for_request):
2194         (SimulatedDeviceManager._disambiguate_device_type):
2195         (SimulatedDeviceManager._does_fulfill_request):
2196         (SimulatedDeviceManager.device_count_for_type):
2197         (SimulatedDeviceManager.initialize_devices):
2198         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2199         (test_available_devices):
2200         (test_swapping_devices):
2201
2202 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2203
2204         webkitpy: Support alternate simctl device list output (Follow-up fix)
2205         https://bugs.webkit.org/show_bug.cgi?id=193362
2206         <rdar://problem/47122965>
2207
2208         Rubber-stamped by Lucas Forschler.
2209
2210         * Scripts/webkitpy/xcode/simulated_device.py:
2211         (SimulatedDeviceManager.populate_available_devices):
2212
2213 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2214
2215         [iOS] Expose SPI to access the current sentence boundary and selection state
2216         https://bugs.webkit.org/show_bug.cgi?id=193398
2217         <rdar://problem/45893108>
2218
2219         Reviewed by Dean Jackson.
2220
2221         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
2222         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
2223         expected.
2224
2225         * TestWebKitAPI/EditingTestHarness.h:
2226         * TestWebKitAPI/EditingTestHarness.mm:
2227         (-[EditingTestHarness moveBackward]):
2228         (-[EditingTestHarness moveForward]):
2229         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
2230
2231         Add a couple of new helper methods on EditingTestHarness.
2232
2233         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2234         (-[SelectionChangeObserver initWithWebView:]):
2235         (-[SelectionChangeObserver webView]):
2236         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
2237         (-[SelectionChangeObserver currentSelectionAttributes]):
2238
2239 2019-01-14  Zalan Bujtas  <zalan@apple.com>
2240
2241         [LFC][BFC] Add basic box-sizing support.
2242         https://bugs.webkit.org/show_bug.cgi?id=193392
2243
2244         Reviewed by Antti Koivisto.
2245
2246         * LayoutReloaded/misc/LFC-passing-tests.txt:
2247
2248 2019-01-14  Charlie Turner  <cturner@igalia.com>
2249
2250         [WPE] API test gardening
2251         https://bugs.webkit.org/show_bug.cgi?id=193319
2252
2253         Reviewed by Michael Catanzaro.
2254
2255         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
2256         passing tests.
2257
2258 2019-01-14  Charlie Turner  <cturner@igalia.com>
2259
2260         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
2261         https://bugs.webkit.org/show_bug.cgi?id=192977
2262
2263         Reviewed by Carlos Garcia Campos.
2264
2265         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
2266         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2267         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
2268         (TestWebKitAPI::GStreamerTest::SetUp):
2269         (TestWebKitAPI::GStreamerTest::TearDown):
2270         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
2271         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
2272         (TestWebKitAPI::TEST_F):
2273
2274 2019-01-14  Charlie Turner  <cturner@igalia.com>
2275
2276         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
2277         https://bugs.webkit.org/show_bug.cgi?id=193332
2278
2279         Reviewed by Michael Catanzaro.
2280
2281         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
2282         defined as a char16_t, which changed in ICU 59, the
2283         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
2284         unsigned short. This test is relying on the behaviour that
2285         UChar=unsigned short, which doesn't hold across platforms and ICU
2286         library versions. The full fix would be a special syntax for
2287         literal characters so that these ambiguities do not arise. That
2288         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
2289         (TestWebKitAPI::TEST):
2290
2291 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2292
2293         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
2294
2295         * Scripts/make-dist:
2296         (Distcheck.configure):
2297
2298 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
2299
2300         [ews-build] Update macOS queue configurations
2301         https://bugs.webkit.org/show_bug.cgi?id=193365
2302         <rdar://problem/47221073>
2303
2304         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
2305
2306         * BuildSlaveSupport/ews-build/config.json:
2307
2308 2019-01-13  Zalan Bujtas  <zalan@apple.com>
2309
2310         [LFC] Adjust assert for statically positioned fixed elements
2311         https://bugs.webkit.org/show_bug.cgi?id=193385
2312
2313         Reviewed by Antti Koivisto.
2314
2315         * LayoutReloaded/misc/LFC-passing-tests.txt:
2316
2317 2019-01-13  Philippe Normand  <pnormand@igalia.com>
2318
2319         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
2320         https://bugs.webkit.org/show_bug.cgi?id=193387
2321
2322         Reviewed by Carlos Garcia Campos.
2323
2324         * MiniBrowser/wpe/main.cpp:
2325         (main):
2326
2327 2019-01-12  Timothy Hatcher  <timothy@apple.com>
2328
2329         Have prefers-color-scheme: light always match on macOS versions before Mojave.
2330         https://bugs.webkit.org/show_bug.cgi?id=191655
2331         rdar://problem/46074680
2332
2333         Reviewed by Megan Gardner.
2334
2335         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
2336         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2337
2338 2019-01-12  Dan Bernstein  <mitz@apple.com>
2339
2340         [Cocoa] Avoid importing directly from subumbrella frameworks
2341         https://bugs.webkit.org/show_bug.cgi?id=186016
2342         <rdar://problem/40591038>
2343
2344         Reviewed by Sam Weinig.
2345
2346         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2347           LaunchServices header.
2348         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2349           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2350         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2351           when using SDKs earlier than 10.13.
2352         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2353           and OTHER_CPLUSPLUSFLAGS.
2354         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2355           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2356         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2357           LaunchServices header.
2358
2359 2019-01-11  John Wilander  <wilander@apple.com>
2360
2361         Compile out Web API Statistics Collection
2362         https://bugs.webkit.org/show_bug.cgi?id=193370
2363         <rdar://problem/45388584>
2364
2365         Reviewed by Brent Fulgham.
2366
2367         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2368             Defined ENABLE_WEB_API_STATISTICS, off by default.
2369
2370 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2371
2372         [WPE] Add gtk-doc
2373         https://bugs.webkit.org/show_bug.cgi?id=178900
2374
2375         Reviewed by Michael Catanzaro.
2376
2377         Add Tools/gtkdoc to manifest.txt.in files.
2378         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
2379
2380         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
2381         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
2382
2383 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2384
2385         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
2386         https://bugs.webkit.org/show_bug.cgi?id=193364
2387         <rdar://problem/47214117>
2388
2389         Reviewed by Tim Horton.
2390
2391         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
2392         precise, whereas dragging near the middle of the textarea does.
2393
2394         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2395         (TestWebKitAPI::TEST):
2396
2397 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2398
2399         webkitpy: Support alternate simctl device list output
2400         https://bugs.webkit.org/show_bug.cgi?id=193362
2401         <rdar://problem/47122965>
2402
2403         Reviewed by Lucas Forschler.
2404
2405         * Scripts/webkitpy/xcode/simulated_device.py:
2406         (SimulatedDeviceManager.populate_available_devices):
2407
2408 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
2409
2410         [ews-build] Update macOS queue configurations
2411         https://bugs.webkit.org/show_bug.cgi?id=193365
2412
2413         Reviewed by Lucas Forschler.
2414
2415         * BuildSlaveSupport/ews-build/config.json:
2416
2417 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2418
2419         webkitpy: Incorporate device type into baseline search path
2420         https://bugs.webkit.org/show_bug.cgi?id=193356
2421         <rdar://problem/47215515>
2422
2423         Reviewed by Lucas Forschler.
2424
2425         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
2426
2427         * Scripts/webkitpy/port/base.py:
2428         (Port.default_baseline_search_path): Allow device type to be passed in.
2429         * Scripts/webkitpy/port/gtk.py:
2430         (GtkPort.default_baseline_search_path): Ignore device type.
2431         * Scripts/webkitpy/port/ios.py:
2432         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
2433         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
2434         * Scripts/webkitpy/port/ios_device_unittest.py:
2435         (IOSDeviceTest):
2436         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2437         (IOSSimulatorTest):
2438         * Scripts/webkitpy/port/mac.py:
2439         (MacPort.default_baseline_search_path): Ignore device type.
2440         * Scripts/webkitpy/port/watch.py:
2441         (WatchPort.default_baseline_search_path): Ditto.
2442         * Scripts/webkitpy/port/win.py:
2443         (WinPort.default_baseline_search_path): Ditto.
2444         (WinCairoPort.default_baseline_search_path): Ditto.
2445         * Scripts/webkitpy/port/wpe.py:
2446         (WPEPort.default_baseline_search_path): Ditto.
2447
2448 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2449
2450         webkitpy: Print abbreviated baseline search path that includes only folders that exist
2451         https://bugs.webkit.org/show_bug.cgi?id=193352
2452         <rdar://problem/47210736>
2453
2454         Reviewed by Lucas Forschler.
2455
2456         * Scripts/webkitpy/layout_tests/views/printing.py:
2457         (Printer.print_config): Print list on only baseline search paths which exist. 
2458         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2459         (Testprinter.test_print_config):
2460
2461 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
2462
2463         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
2464         https://bugs.webkit.org/show_bug.cgi?id=193340
2465
2466         Reviewed by David Kilzer.
2467
2468         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2469         (WTR::InjectedBundle::didReceiveMessageToPage):
2470         Pull the strings out into a WKRetainPtr.
2471
2472         * WebKitTestRunner/WebNotificationProvider.cpp:
2473         (WTR::WebNotificationProvider::closeWebNotification):
2474         Adopt the created value into the WKRetainPtr.
2475
2476         * WebKitTestRunner/mac/TestControllerMac.mm:
2477         (WTR::generateWhitelist):
2478         Immediately adopt a created value to avoid potential mistakes.
2479
2480 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
2481
2482         Enable DFG on ARM/Linux again
2483         https://bugs.webkit.org/show_bug.cgi?id=192496
2484
2485         Reviewed by Yusuke Suzuki.
2486
2487         After changing the bytecode format DFG was disabled on all 32-bit
2488         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2489         on ARM by default.
2490
2491         * Scripts/run-jsc-stress-tests:
2492
2493 2019-01-11  Timothy Hatcher  <timothy@apple.com>
2494
2495         Unreviewed, fix #ifdef in API test added in r239851.
2496         https://bugs.webkit.org/show_bug.cgi?id=193327
2497         rdar://problem/47093222
2498
2499         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
2500
2501 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2502
2503         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
2504         https://bugs.webkit.org/show_bug.cgi?id=193109
2505         <rdar://problem/44807048>
2506
2507         Reviewed by Ryosuke Niwa.
2508
2509         Introduce and respect a test option to enable the UndoManager API.
2510
2511         * WebKitTestRunner/TestController.cpp:
2512         (WTR::updateTestOptionsFromTestHeader):
2513         * WebKitTestRunner/TestOptions.h:
2514         (WTR::TestOptions::hasSameInitializationOptions const):
2515         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2516         (WTR::TestController::platformCreateWebView):
2517
2518 2019-01-11  Zalan Bujtas  <zalan@apple.com>
2519
2520         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
2521         https://bugs.webkit.org/show_bug.cgi?id=193346
2522
2523         Reviewed by Antti Koivisto.
2524
2525         * LayoutReloaded/misc/LFC-passing-tests.txt:
2526
2527 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2528
2529         Unreviewed, fix typo that breaks dashboard link.
2530
2531         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2532         (WebKitBuildbot):
2533
2534 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2535
2536         Update macOS queue configurations
2537         https://bugs.webkit.org/show_bug.cgi?id=193329
2538
2539         Reviewed by Alexey Proskuryakov.
2540
2541         * BuildSlaveSupport/build.webkit.org-config/config.json:
2542         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2543         (BubbleQueueServer):
2544         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2545         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2546         (WebKitBuildbot):
2547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2548         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
2549         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2550
2551 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2552
2553         MiniBrowser should be able to navigate to about:blank
2554         https://bugs.webkit.org/show_bug.cgi?id=193345
2555
2556         Reviewed by Simon Fraser.
2557
2558         * MiniBrowser/mac/BrowserWindowController.m:
2559         (-[BrowserWindowController addProtocolIfNecessary:]):
2560         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2561
2562         * MiniBrowser/mac/WK1BrowserWindowController.m:
2563         (-[WK1BrowserWindowController fetch:]):
2564         * MiniBrowser/mac/WK2BrowserWindowController.m:
2565         (-[WK2BrowserWindowController fetch:]):
2566         Clean up the code that uses this to match style.
2567
2568 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2569
2570         Remove MiniBrowser custom "Process Swap" menu item which does not work
2571         https://bugs.webkit.org/show_bug.cgi?id=193344
2572
2573         Reviewed by Simon Fraser.
2574
2575         There is a menu item under the Experimental menu that does work.
2576
2577         * MiniBrowser/mac/AppDelegate.m:
2578         (defaultConfiguration):
2579         * MiniBrowser/mac/SettingsController.h:
2580         * MiniBrowser/mac/SettingsController.m:
2581         (-[SettingsController _populateMenu]):
2582         (-[SettingsController validateMenuItem:]):
2583         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2584         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2585
2586 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2587
2588         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2589         https://bugs.webkit.org/show_bug.cgi?id=193327
2590         rdar://problem/47093222
2591
2592         Reviewed by Tim Horton.
2593
2594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2595         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2596         (TestWebKitAPI::didFinishNavigation):
2597         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2598         (TestWebKitAPI::TEST):
2599         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2600         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2601         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2602         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2603         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2604
2605 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2606
2607         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2608         https://bugs.webkit.org/show_bug.cgi?id=193338
2609         <rdar://problem/46664774>
2610
2611         Reviewed by David Kilzer.
2612
2613         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2614         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2615
2616 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2617
2618         Unreviewed, rolling out r239825.
2619         https://bugs.webkit.org/show_bug.cgi?id=193330
2620
2621         Broke tests on armv7/linux bots (Requested by guijemont on
2622         #webkit).
2623
2624         Reverted changeset:
2625
2626         "Enable DFG on ARM/Linux again"
2627         https://bugs.webkit.org/show_bug.cgi?id=192496
2628         https://trac.webkit.org/changeset/239825
2629
2630 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2631
2632         Disable the run-jsc-stress-test remote host key check.
2633         https://bugs.webkit.org/show_bug.cgi?id=192988
2634
2635         Reviewed by Alexey Proskuryakov.
2636
2637         * Scripts/run-jsc-stress-tests:
2638
2639 2019-01-10  John Wilander  <wilander@apple.com>
2640
2641         Override the session configuration for cookieAcceptPolicy
2642         https://bugs.webkit.org/show_bug.cgi?id=190925
2643         <rdar://problem/45497382>
2644
2645         Reviewed by Alexey Proskuryakov and Alex Christensen.
2646
2647         Test infrastructure for setting a first-party-only cookie policy.
2648
2649         * DumpRenderTree/TestRunner.cpp:
2650         (setOnlyAcceptFirstPartyCookiesCallback):
2651         (TestRunner::staticFunctions):
2652         * DumpRenderTree/TestRunner.h:
2653         * DumpRenderTree/mac/TestRunnerMac.mm:
2654         (TestRunner::setOnlyAcceptFirstPartyCookies):
2655         * DumpRenderTree/win/TestRunnerWin.cpp:
2656         (TestRunner::setOnlyAcceptFirstPartyCookies):
2657         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2658         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2659         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2660         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2661         * WebKitTestRunner/TestInvocation.cpp:
2662         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2663
2664 2019-01-09  Matt Rajca  <mrajca@apple.com>
2665
2666         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2667         https://bugs.webkit.org/show_bug.cgi?id=193301
2668
2669         Reviewed by Jer Noble.
2670         
2671         Added API tests.
2672
2673         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2674         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2675         (TEST):
2676         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2677
2678 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2679
2680         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2681         https://bugs.webkit.org/show_bug.cgi?id=193310
2682
2683         Reviewed by Antti Koivisto.
2684
2685         * LayoutReloaded/misc/LFC-passing-tests.txt:
2686
2687 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2688
2689         Enable DFG on ARM/Linux again
2690         https://bugs.webkit.org/show_bug.cgi?id=192496
2691
2692         Reviewed by Yusuke Suzuki.
2693
2694         After changing the bytecode format DFG was disabled on all 32-bit
2695         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2696         on ARM by default.
2697
2698         * Scripts/run-jsc-stress-tests:
2699
2700 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2701
2702         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2703         https://bugs.webkit.org/show_bug.cgi?id=193271
2704
2705         Reviewed by Brent Fulgham.
2706
2707         BSTR is a special data structure created by SysAllocString, not a
2708         wchar_t null-terminated string.
2709
2710         * DumpRenderTree/win/TestRunnerWin.cpp:
2711         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2712         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2713         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2714         BSTR from wide string literals.
2715
2716 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2717
2718         Tweak wording for build/version_check style checker error
2719         https://bugs.webkit.org/show_bug.cgi?id=193256
2720
2721         Reviewed by Tim Horton.
2722
2723         * Scripts/webkitpy/style/checkers/cpp.py:
2724         (check_os_version_checks):
2725         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2726         (WebKitStyleTest.test_os_version_checks):
2727
2728 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2729
2730         [ews-build] Add link to bug along with bug title
2731         https://bugs.webkit.org/show_bug.cgi?id=193293
2732
2733         Reviewed by Lucas Forschler.
2734
2735         * BuildSlaveSupport/ews-build/steps.py:
2736         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2737         (ConfigureBuild.add_bug_id_url): Deleted.
2738         (ConfigureBuild.getBugURL): Deleted.
2739
2740 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2741
2742         [ews-build] Use https for ews-build server
2743         https://bugs.webkit.org/show_bug.cgi?id=193193
2744
2745         Reviewed by Lucas Forschler.
2746
2747         * BuildSlaveSupport/ews-build/steps.py:
2748
2749 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2750
2751         [ews-build] Parse and display number of style failures
2752         https://bugs.webkit.org/show_bug.cgi?id=193280
2753
2754         Reviewed by Lucas Forschler.
2755
2756         * BuildSlaveSupport/ews-build/steps.py:
2757         (CheckStyle): Use TestWithFailureCount as base class.
2758         (CheckStyle.countFailures): Count the number of style failures.
2759
2760 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2761
2762         [ews-build] use patch_id instead of ewspatchid
2763         https://bugs.webkit.org/show_bug.cgi?id=193235
2764
2765         Reviewed by Lucas Forschler.
2766
2767         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2768         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2769         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2770
2771 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2772
2773         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2774         https://bugs.webkit.org/show_bug.cgi?id=192625
2775
2776         Reviewed by Antti Koivisto.
2777
2778         * LayoutReloaded/misc/LFC-passing-tests.txt:
2779
2780 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2781
2782         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2783         https://bugs.webkit.org/show_bug.cgi?id=192841
2784
2785         Reviewed by Carlos Garcia Campos.
2786
2787         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2788         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2789         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2790
2791         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2792
2793         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2794         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2795         (WebKitWebEditorTest::testSelectionChanged):
2796         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2797         (WebKitFrameTest::testMainFrame):
2798         (WebKitFrameTest::testURI):
2799         (WebKitFrameTest::testJavaScriptContext):
2800         (WebKitFrameTest::testJavaScriptValues):
2801         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2802         (testWebViewAuthenticationRequest):
2803         (testWebViewAuthenticationLoadCancelled):
2804         (testWebViewAuthenticationFailure):
2805         (testWebViewAuthenticationStorage):
2806         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2807         (testWebViewAuthenticationProxy):
2808         (testWebViewAuthenticationProxyHTTPS):
2809         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2810         (testAutomationSessionRequestSession):
2811         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2812         (testBackForwardListNavigation):
2813         (testWebKitWebViewSessionState):
2814         (testWebKitWebViewSessionStateWithFormData):
2815         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2816         (ConsoleMessageTest::consoleMessageReceivedCallback):
2817         (testWebKitConsoleMessageConsoleAPI):
2818         (testWebKitConsoleMessageJavaScriptException):
2819         (testWebKitConsoleMessageNetworkError):
2820         (testWebKitConsoleMessageSecurityError):
2821         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2822         (testCookieManagerAcceptPolicy):
2823         (testCookieManagerCookiesChanged):
2824         (testCookieManagerPersistentStorage):
2825         (testCookieManagerPersistentStorageDeleteAll):
2826         (testCookieManagerEphemeral):
2827         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2828         (testWebKitDOMElementAutoFill):
2829         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2830         (downloadLocalFileSuccessfully):
2831         (createFileAtDestination):
2832         (testDownloadOverwriteDestinationDisallowed):
2833         (testDownloadLocalFileError):
2834         (testDownloadRemoteFile):
2835         (testDownloadRemoteFileError):
2836         (testWebViewDownloadURI):
2837         (testPolicyResponseDownload):
2838         (testPolicyResponseDownloadCancel):
2839         (testDownloadMIMEType):
2840         (contextMenuCallback):
2841         (testContextMenuDownloadActions):
2842         (testBlobDownload):
2843         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2844         (testWebKitWebEditorSelectionChanged):
2845         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2846         (testWebKitFrameMainFrame):
2847         (testWebKitFrameURI):
2848         (testWebKitFrameJavaScriptContext):
2849         (testWebKitFrameJavaScriptValues):
2850         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2851         (LoadStopTrackingTest::loadFailed):
2852         (testWebViewTitle):
2853         (testURIRequestHTTPHeaders):
2854         (testURIRequestHTTPMethod):
2855         (testURIResponseHTTPHeaders):
2856         (testRedirectToDataURI):
2857         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2858         (testProcessPerWebView):
2859         (testWebProcessLimit):
2860         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2861         (testWebViewResources):
2862         (testWebResourceLoading):
2863         (testWebResourceSuggestedFilename):
2864         (testWebResourceGetData):
2865         (testWebResourceGetDataError):
2866         (testWebViewResourcesHistoryCache):
2867         (testWebResourceSendRequest):
2868         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2869         (testSSL):
2870         (testInsecureContent):
2871         (testTLSErrorsPolicy):
2872         (testTLSErrorsRedirect):
2873         (testTLSErrorsHTTPAuth):
2874         (testLoadFailedWithTLSErrors):
2875         (testSubresourceLoadFailedWithTLSErrors):
2876         (httpsServerCallback):
2877         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2878         (testWebViewCreateNavigationData):
2879         (testWebViewJavaScriptDialogs):
2880         (testWebViewWindowProperties):
2881         (testWebViewMouseTarget):
2882         (testWebViewFileChooserRequest):
2883         (testWebViewColorChooserRequest):
2884         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2885         (testWebExtensionGetTitle):
2886         (testDocumentLoadedSignal):
2887         (testWebKitWebViewProcessCrashed):
2888         (testWebExtensionWindowObjectCleared):
2889         (testWebExtensionIsolatedWorld):
2890         (permissionRequestCallback):
2891         (didAssociateFormControlsCallback):
2892         (testWebExtensionFormControlsAssociated):
2893         (FormSubmissionTest::FormSubmissionTest):
2894         (FormSubmissionTest::testFormSubmissionResult):
2895         (testWebExtensionFormSubmissionSteps):
2896         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2897         (testNotInitialized):
2898         (testClearDatabase):
2899         (testPrivateBrowsing):
2900         (testGetFavicon):
2901         (testWebViewFavicon):
2902         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2903         (testFindControllerTextFound):
2904         (testFindControllerTextNotFound):
2905         (testFindControllerMatchCount):
2906         (testFindControllerMaxMatchCount):
2907         (testFindControllerNext):
2908         (testFindControllerPrevious):
2909         (testFindControllerCountedMatches):
2910         (testFindControllerOptions):
2911         (testFindControllerHide):
2912         (testFindControllerInstance):
2913         (testFindControllerGetters):
2914         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2915         (testNavigationPolicy):
2916         (testResponsePolicy):
2917         (testNewWindowPolicy):
2918         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2919         (testSecurityOriginBasicConstructor):
2920         (testSecurityOriginURIConstructor):
2921         (testSecurityOriginDefaultPort):
2922         (testSecurityOriginFileURI):
2923         (testOpaqueSecurityOrigin):
2924         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2925         (testWebKitSettings):
2926         (testWebKitSettingsNewWithSettings):
2927         (testWebKitSettingsUserAgent):
2928         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2929         (testWebViewNewWithUserContentManager):
2930         (isStyleSheetInjectedForURLAtPath):
2931         (isScriptInjectedForURLAtPath):
2932         (testUserContentManagerInjectedStyleSheet):
2933         (testUserContentManagerInjectedScript):
2934         (UserScriptMessageTest::scriptMessageReceived):
2935         (UserScriptMessageTest::waitUntilMessageReceived):
2936         (UserScriptMessageTest::runJavaScriptFinished):
2937         (testUserContentManagerScriptMessageReceived):
2938         (testUserContentManagerScriptMessageInWorldReceived):
2939         (testUserContentManagerScriptMessageFromDOMBindings):
2940         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2941         (testWebContextDefault):
2942         (testWebContextEphemeral):
2943         (testWebContextGetPlugins):
2944         (testWebContextURIScheme):
2945         (testWebContextSpellChecker):
2946         (testWebContextLanguages):
2947         (consoleMessageReceivedCallback):
2948         (testWebContextSecurityFileXHR):
2949         (ProxyTest::ProxyTest):
2950         (testWebContextProxySettings):
2951         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2952         (testWebViewWebContext):
2953         (testWebViewWebBackend):
2954         (testWebViewEphemeral):
2955         (testWebViewCustomCharset):
2956         (testWebViewSettings):
2957         (testWebViewRunJavaScript):
2958         (testWebViewCanShowMIMEType):
2959         (testWebViewSubmitForm):
2960         (testWebViewSave):
2961         (testWebViewPageVisibility):
2962         (testWebViewSnapshot):
2963         (testWebViewNotification):
2964         (testWebViewNotificationInitialPermissionAllowed):
2965         (testWebViewNotificationInitialPermissionDisallowed):
2966         (testWebViewIsPlayingAudio):
2967         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2968         (WebsiteDataTest::WebsiteDataTest):
2969         (WebsiteDataTest::remove):
2970         (WebsiteDataTest::clear):
2971         (testWebsiteDataConfiguration):
2972         (testWebsiteDataEphemeral):
2973         (testWebsiteDataCache):
2974         (testWebsiteDataStorage):
2975         (testWebsiteDataDatabases):
2976         (testWebsiteDataAppcache):
2977         (testWebsiteDataCookies):
2978         (testWebsiteDataDeviceIdHashSalt):
2979         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2980         (emitDocumentLoaded):
2981         (emitURIChanged):
2982         (sendRequestCallback):
2983         (contextMenuCallback):
2984         (consoleMessageSentCallback):
2985         (emitFormControlsAssociated):
2986         (formControlsAssociatedCallback):
2987         (emitFormSubmissionEvent):
2988         (willSubmitFormCallback):
2989         (windowObjectCleared):
2990         (methodCallCallback):
2991         (registerGResource):
2992         (webkit_web_extension_initialize_with_user_data):
2993         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2994         (checkLeaks):
2995         (WebProcessTest::create):
2996         (runTest):
2997         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2998         (AutocleanupsTest::testWebProcessAutocleanups):
2999         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
3000         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
3001         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
3002         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
3003         (WebKitDOMDOMWindowTest::testSignals):
3004         (WebKitDOMDOMWindowTest::testDispatchEvent):
3005         (WebKitDOMDOMWindowTest::testGetComputedStyle):
3006         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
3007         (WebKitDOMNodeFilterTest::testTreeWalker):
3008         (WebKitDOMNodeFilterTest::testNodeIterator):
3009         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
3010         (WebKitDOMNodeTest::testHierarchyNavigation):
3011         (WebKitDOMNodeTest::testInsertion):
3012         (WebKitDOMNodeTest::testTagNamesNodeList):
3013         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
3014         (WebKitDOMNodeTest::testDOMCache):
3015         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
3016         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3017         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3018         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3019         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
3020         (testUIProcessAutocleanups):
3021         (testWebProcessAutocleanups):
3022         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3023         (testContextMenuPopulateMenu):
3024         (testContextMenuDismissed):
3025         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
3026         (testWebKitDOMClientRectDivBoundingClientRectPosition):
3027         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
3028         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
3029         (testWebKitDOMDOMWindowSignals):
3030         (testWebKitDOMDOMWindowDispatchEvent):
3031         (testWebKitDOMDOMWindowGetComputedStyle):
3032         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
3033         (testWebKitDOMNodeHierarchyNavigation):
3034         (testWebKitDOMNodeInsertion):
3035         (testWebKitDOMNodeTagNamesNodeList):
3036         (testWebKitDOMNodeTagNamesHTMLCollection):
3037         (testWebKitDOMObjectCache):
3038         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
3039         (testWebKitDOMNodeFilterTreeWalker):
3040         (testWebKitDOMNodeFilterNodeIterator):
3041         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
3042         (testWebKitDOMXPathNSResolverNative):
3043         (testWebKitDOMXPathNSResolverCustom):
3044         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
3045         (testInspectorDefault):
3046         (testInspectorManualAttachDetach):
3047         (testInspectorCustomContainerDestroyed):
3048         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
3049         (startTestServer):
3050         (testInspectorServerPageList):
3051         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
3052         (OptionMenuTest::showOptionMenuCallback):
3053         (OptionMenuTest::menuCloseCallback):
3054         (OptionMenuTest::close):
3055         (OptionMenuTest::activateItem):
3056         (OptionMenuTest::selectItem):
3057         (testOptionMenuSimple):
3058         (testOptionMenuGroups):
3059         (testOptionMenuActivate):
3060         (testOptionMenuSelect):
3061         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
3062         (testPrintOperationPrintSettings):
3063         (webViewPrintCallback):
3064         (testPrintOperationPrint):
3065         (testPrintCustomWidget):
3066         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3067         (checkAtspiAccessible):
3068         (testAtspiBasicHierarchy):
3069         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
3070         (testWebKitCheckVersion):
3071         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
3072         (testWebViewEditorCutCopyPasteNonEditable):
3073         (testWebViewEditorCutCopyPasteEditable):
3074         (testWebViewEditorSelectAllNonEditable):
3075         (testWebViewEditorSelectAllEditable):
3076         (loadContentsAndTryToCutSelection):
3077         (testWebViewEditorNonEditable):
3078         (testWebViewEditorEditable):
3079         (testWebViewEditorEditorStateTypingAttributes):
3080         (testWebViewEditorInsertImage):
3081         (testWebViewEditorCreateLink):
3082         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3083         (loadChangedCallback):
3084         (loadFailedCallback):
3085         (loadFailedWithTLSErrorsCallback):
3086         (LoadTrackingTest::LoadTrackingTest):
3087         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3088         (registerGResource):
3089         (removeNonEmptyDirectory):
3090         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3091         (Test::adoptView):
3092         (Test::~Test):
3093         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3094         (WebKitTestBus::getOrCreateConnection):
3095         (WebKitTestBus::createProxy):
3096         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
3097         (WebKitTestServer::getWebSocketURIForPath const):
3098         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3099         (WebViewTest::initializeWebView):
3100         (WebViewTest::loadURI):
3101         (WebViewTest::loadHtml):
3102         (WebViewTest::loadPlainText):
3103         (WebViewTest::loadBytes):
3104         (WebViewTest::loadRequest):
3105         (WebViewTest::loadAlternateHTML):
3106         (WebViewTest::goBack):
3107         (WebViewTest::goForward):
3108         (WebViewTest::goToBackForwardListItem):
3109         (resourceGetDataCallback):
3110         (WebViewTest::mainResourceData):
3111         (WebViewTest::javascriptResultToCString):
3112         (WebViewTest::javascriptResultToNumber):
3113         (WebViewTest::javascriptResultToBoolean):
3114         (WebViewTest::javascriptResultIsNull):
3115         (WebViewTest::javascriptResultIsUndefined):
3116         (onSnapshotReady):
3117         (WebViewTest::runWebProcessTest):
3118         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
3119         (WebViewTest::platformInitializeWebView):
3120         (WebViewTest::showInWindow):
3121         (WebViewTest::showInWindowAndWaitUntilMapped):
3122         (WebViewTest::mouseMoveTo):
3123         (WebViewTest::emitPopupMenuSignal):
3124         (WebViewTest::keyStroke):
3125         (WebViewTest::doMouseButtonEvent):
3126
3127 2019-01-09  Philippe Normand  <pnormand@igalia.com>
3128
3129         [WPE] API tests can't run in flatpak environment
3130         https://bugs.webkit.org/show_bug.cgi?id=193242
3131
3132         Reviewed by Michael Catanzaro.
3133
3134         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
3135         flatpakutils so that it knows which port it's dealing with.
3136         * glib/common.py: Remove build_dir globals so that subsequent
3137         calls actually take args into account.
3138         (library_build_path):
3139         (binary_build_path):
3140
3141 2019-01-08  Dean Jackson  <dino@apple.com>
3142
3143         Blob references for System Previews don't get a correct file extension
3144         https://bugs.webkit.org/show_bug.cgi?id=193268
3145         <rdar://problem/47133037>
3146
3147         Reviewed by Tim Horton.
3148
3149         New test that a Blob download of a USDZ file gets named correctly.
3150
3151         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3152         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3153         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3154         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
3155         (TEST):
3156         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
3157
3158 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
3159
3160         [WebAuthN] Support U2F HID Authenticators on macOS
3161         https://bugs.webkit.org/show_bug.cgi?id=191535
3162         <rdar://problem/47102027>
3163
3164         Reviewed by Brent Fulgham.
3165
3166         This patch:
3167         1) adds support for U2F mocking mechanism;
3168         2) updates tests to reflect U2fCommandConstructor changes.
3169
3170         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3171         (TestWebKitAPI::TEST):
3172         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3173         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3174         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3175
3176 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3177
3178         [iOS] Dispatch a synthetic mousedown event prior to starting drags
3179         https://bugs.webkit.org/show_bug.cgi?id=193229
3180         <rdar://problem/46717097>
3181
3182         Reviewed by Tim Horton.
3183
3184         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
3185         prevents a drag from starting.
3186
3187         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3188         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
3189
3190         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
3191
3192 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
3193   
3194         Layout test will generate a perf metric file to results dir.
3195         https://bugs.webkit.org/show_bug.cgi?id=192030
3196         <rdar://problem/32779516>
3197
3198         Reviewed by Aakash Jain.
3199
3200         Layout test running time will be collected to a perf metric file.
3201         For now, instead of outputing running time of all tests (which is huge),
3202         we aggregate them by test directories which are at most two level deep. 
3203
3204         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3205         (Manager._end_test_run):
3206         (Manager._output_perf_metrics):
3207         (Manager._print_expectation_line_for_test):
3208         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3209         (add_test_perf_metric):
3210         (test_perf_metrics):
3211         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3212         (JSONGeneratorTest.test_test_timings_trie):
3213         (JSONGeneratorTest):
3214         (JSONGeneratorTest.test_test_perf_metrics):
3215         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3216         (RebaselineTest.test_reset_results):
3217         (RebaselineTest.test_missing_results):
3218         (RebaselineTest.test_new_baseline):
3219
3220 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
3221
3222         [WPE][GTK] Add php-json to install-dependencies
3223         https://bugs.webkit.org/show_bug.cgi?id=193233
3224
3225         Reviewed by Michael Catanzaro.
3226
3227         * gtk/install-dependencies:
3228         * wpe/install-dependencies:
3229
3230 2019-01-08  Chris Dumez  <cdumez@apple.com>
3231
3232         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
3233         https://bugs.webkit.org/show_bug.cgi?id=193224
3234         <rdar://problem/47097726>
3235
3236         Reviewed by Alex Christensen.
3237
3238         Add API test coverage.
3239
3240         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3241
3242 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3243
3244         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
3245         <https://webkit.org/b/193222>
3246         <rdar://problem/46862309>
3247
3248         Reviewed by Joseph Pecoraro.
3249
3250         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3251         (WTR::executeCallback): Fix camel case of variable name.
3252         (WTR::EventSendingController::callAfterScrollingCompletes): If
3253         WKBundlePageRegisterScrollOperationCompletionCallback() returns
3254         false, make sure to release the ScrollCompletionCallbackData
3255         object.  This fixes the leak.
3256
3257 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3258
3259         [Win] EWS: wincairo-ews cannot apply a patch with *.png
3260         https://bugs.webkit.org/show_bug.cgi?id=193044
3261
3262         Reviewed by Daniel Bates.
3263
3264         WinCairo EWS bots are using Windows Perl. Binary files should be
3265         opened as binary mode.
3266
3267         * Scripts/svn-apply:
3268         (handleGitBinaryChange): Use 'binmode' for binary file handles.
3269
3270 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
3271
3272         [CMake] Add ENABLE_CSS_TYPED_OM option
3273         https://bugs.webkit.org/show_bug.cgi?id=193216
3274
3275         Reviewed by Michael Catanzaro.
3276
3277         * Scripts/webkitperl/FeatureList.pm:
3278
3279 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3280
3281         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
3282         <https://webkit.org/b/193056>
3283
3284         Reviewed by Alex Christensen.
3285
3286         * Scripts/webkitpy/style/checker.py:
3287         - Ignore use of new runtime/retainptr check in
3288           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
3289           contains tests to ensure RetainPtr<NSObject *> is compatible
3290           with RetainPtr<NSObject>.
3291
3292         * Scripts/webkitpy/style/checkers/cpp.py:
3293         (check_language):
3294         (CppChecker):
3295         - Add checker for use of '*' in RetainPtr<> type.  A for loop
3296           was used instead of a single regex so that angle brackets
3297           could be matched up when checking the type contained within
3298           the RetainPtr<> type.
3299
3300         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3301         (CppStyleTest):
3302         - Add unit test for new runtime/retainptr check.
3303
3304         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
3305         * TestWebKitAPI/EditingTestHarness.h:
3306         - Remove '*' from RetainPtr<> type.
3307
3308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3309         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
3310           regressed in r201938.
3311
3312         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3313         (TestWebKitAPI::TEST):
3314         - Update tests to match RetainPtr.mm tests (except for the
3315           `*SimilarNSType` tests since there is no CF equivalent of
3316           RetainPtr<NSString> and RetainPtr<NSString *>).
3317
3318         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3319         (TestWebKitAPI::TEST):
3320         - Update tests to:
3321           - Not conflict by name with equivalent CF tests in
3322             RetainPtr.cpp.
3323           - Add test cases for RetainPtr<NSObject>,
3324             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
3325           - Add `*SimilarNSType` tests for converting between
3326             RetainPtr<NSObject> and RetainPtr<NSObject *>.
3327           - Change `0` to `nil` as appropriate.
3328           - Re-alphabetize the tests by name.
3329           - Add Optional<RetainPtr<>> tests.
3330           - Add retainPtr() tests.
3331
3332         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3333         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3334         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
3335         (TEST):
3336         - Remove '*' from RetainPtr<> type.
3337
3338         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
3339         (TEST(WebKit, JITEnabled)):
3340         - Add missing WTFMove().  Apparently a temporary was being
3341           created before in the argument list due to mismatched
3342           RetainPtr<> types.
3343
3344         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3345         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
3346         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
3347         (TestWebKitAPI::TEST):
3348         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3349         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3350         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3351         (WTR::resourcesDirectoryURL):
3352         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3353         (WTR::InjectedBundle::platformInitialize):
3354         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3355         - Remove '*' from RetainPtr<> type.
3356
3357 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
3358
3359         A MediaTime timescale must never be zero
3360         https://bugs.webkit.org/show_bug.cgi?id=193156
3361         <rdar://problem/32504501>
3362
3363         Reviewed by Jer Noble.
3364
3365         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3366         (TestWebKitAPI::TEST): Add tests for zero timescale.
3367
3368 2019-01-07  Youenn Fablet  <youenn@apple.com>
3369
3370         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
3371         https://bugs.webkit.org/show_bug.cgi?id=193175
3372
3373         Reviewed by Chris Dumez.
3374
3375         Updated API test as we bumped the SW schema to version 4.
3376
3377         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3378         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
3379         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3380         (TEST):
3381
3382 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3383
3384         [Win][Clang] Fix compilation warnings of MiniBrowser
3385         https://bugs.webkit.org/show_bug.cgi?id=193029
3386
3387         Reviewed by Ross Kirsling.
3388
3389         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
3390         and m_URLBarFont. Reorder member variables to fix -Wreorder
3391         warning.
3392         * MiniBrowser/win/PageLoadTestClient.cpp:
3393         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
3394         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
3395         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
3396         m_currentURLIndex.
3397         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3398         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
3399         navigationClient with '{ }' to fix the missing field warning.
3400         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3401         (initDocStruct): Changed the argument type docname to const.
3402
3403 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
3404
3405         [WebAuthN] Import U2F command/response converters from Chromium
3406         https://bugs.webkit.org/show_bug.cgi?id=193150
3407         <rdar://problem/47054028>
3408
3409         Reviewed by Brent Fulgham.
3410
3411         Adds API tests.
3412
3413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3414         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3415         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
3416         (TestWebKitAPI::getTestAuthenticatorDataBytes):
3417         (TestWebKitAPI::getTestAttestationObjectBytes):
3418         (TestWebKitAPI::getTestSignResponse):
3419         (TestWebKitAPI::getTestU2fRegisterResponse):
3420         (TestWebKitAPI::TEST):
3421         (TestWebKitAPI::convertToVector): Deleted.
3422         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3423         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
3424         (TestWebKitAPI::constructMakeCredentialRequest):
3425         (TestWebKitAPI::constructGetAssertionRequest):
3426         (TestWebKitAPI::TEST):
3427
3428 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
3429
3430         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
3431         https://bugs.webkit.org/show_bug.cgi?id=193136
3432
3433         Reviewed by Michael Catanzaro.
3434
3435         * gtk/install-dependencies:
3436         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
3437         they are needed by update-webkitgtk-libs.
3438
3439 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
3440
3441         Unreviewed follow-up fix to r239650
3442         https://bugs.webkit.org/show_bug.cgi?id=193140
3443         <rdar://problem/47063037>
3444
3445         Typecast patch_id to string.
3446
3447         * BuildSlaveSupport/ews-build/steps.py:
3448         (ValidatePatch._is_patch_obsolete):
3449
3450 2019-01-04  Daniel Bates  <dabates@apple.com>
3451
3452         [lldb-webkit]: Add support for pretty-printing raw bitmask types
3453         https://bugs.webkit.org/show_bug.cgi?id=193024
3454
3455         Reviewed by Jer Noble.
3456
3457         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
3458         for the bitmask type WebEventFlags as an example.
3459
3460         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
3461         that can be used to register summary and synthetic child formatters for a bitmask type.
3462         For example, consider the following enum and bitmask typedefs:
3463
3464         typedef enum {
3465             A = 1 << 0,
3466             B = 1 << 1,
3467             C = 1 << 2,
3468         } SpecialFlagValues;
3469         typedef unsigned SpecialFlags;
3470
3471         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
3472         __lldb_init_module():
3473
3474             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
3475                     1 << 0: "A",
3476                     1 << 1: "B",
3477                     1 << 2: "C",
3478             })
3479
3480         * lldb/lldb_webkit.py:
3481         (addSummaryAndSyntheticFormattersForRawBitmaskType):
3482         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
3483         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
3484         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
3485         A convenience function to dynamically creaste a synthetic formatter class and summary
3486         string function for the specified bitmask type and enumerator value to name map. This
3487         function register the dynamically created class and function with LLDB.
3488
3489         (__lldb_init_module):
3490         (FlagEnumerationProvider):
3491         (FlagEnumerationProvider._enumerator_value_to_name_map):
3492         (FlagEnumerationProvider._bitmask):
3493         (FlagEnumerationProvider._update):
3494         (FlagEnumerationProvider.has_children):
3495         (FlagEnumerationProvider.num_children):
3496         (FlagEnumerationProvider.get_child_index):
3497         (FlagEnumerationProvider.get_child_at_index):
3498         (FlagEnumerationProvider.update):
3499         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
3500
3501         (WTFOptionSetProvider):
3502         (WTFOptionSetProvider._enumerator_value_to_name_map):
3503         (WTFOptionSetProvider._bitmask):
3504         (WTFOptionSetProvider._update):
3505         Write in terms of the base class.
3506
3507         (RawBitmaskProviderBase):
3508         (RawBitmaskProviderBase._enumerator_value_to_name_map):
3509         (RawBitmaskProviderBase._bitmask):
3510         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
3511         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
3512         {
3513             1 << 0: "A",
3514             1 << 1: "B",
3515             1 << 2: "C",
3516         }
3517         It is not necessary to instantiate such a derived class directory. Instead use the convenience
3518         function addSummaryAndSyntheticFormattersForRawBitmaskType.
3519
3520         (WTFOptionSetProvider.has_children): Deleted.
3521         (WTFOptionSetProvider.num_children): Deleted.
3522         (WTFOptionSetProvider.get_child_index): Deleted.
3523         (WTFOptionSetProvider.get_child_at_index): Deleted.
3524         (WTFOptionSetProvider.update): Deleted.
3525
3526 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3527
3528         [ews-build] Add build step to validate the patch before processing it
3529         https://bugs.webkit.org/show_bug.cgi?id=193140
3530
3531         Reviewed by Lucas Forschler.
3532
3533         * BuildSlaveSupport/ews-build/factories.py:
3534         (Factory.__init__): Added ValidatePatch step.
3535         * BuildSlaveSupport/ews-build/steps.py:
3536         (ValidatePatch):
3537         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
3538         (ValidatePatch.get_patch_json): Get patch json data.
3539         (ValidatePatch.get_bug_json): Get bug json data.
3540         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
3541         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
3542         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
3543         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
3544         (ValidatePatch.skip_build): Skip the build.
3545         (ValidatePatch.start):
3546
3547 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3548
3549         Progress towards fixing Mac CMake build
3550         https://bugs.webkit.org/show_bug.cgi?id=193105
3551
3552         Reviewed by Don Olmstead.
3553
3554         * TestWebKitAPI/PlatformMac.cmake:
3555
3556 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3557
3558         Fix API test after r239631
3559         https://bugs.webkit.org/show_bug.cgi?id=193118
3560
3561         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3562         (TestWebKitAPI::TEST):
3563         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
3564         Do the same thing via the API to fix the test.
3565
3566 2019-01-04  Jer Noble  <jer.noble@apple.com>
3567
3568         [WebKitLegacy] Media playback pauses on scroll
3569         https://bugs.webkit.org/show_bug.cgi?id=192829
3570
3571         Reviewed by Eric Carlson.
3572
3573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3574         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
3575         (TestWebKitAPI::TEST):
3576         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
3577         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
3578         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
3579         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
3580         (TestWebKitAPI::TEST):
3581
3582 2019-01-04  Chris Dumez  <cdumez@apple.com>
3583
3584         Add support for toggling device orientation API support per site
3585         https://bugs.webkit.org/show_bug.cgi?id=193143
3586         <rdar://problem/46605724>
3587
3588         Reviewed by Alex Christensen.
3589
3590         Add API test coverage.
3591
3592         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3593         (-[DataMappingSchemeHandler setTaskHandler:]):
3594         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3595         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
3596         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3597         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
3598
3599 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3600
3601         [ews-build] use svn-apply script to apply the patches
3602         https://bugs.webkit.org/show_bug.cgi?id=193138
3603
3604         Reviewed by Lucas Forschler.
3605
3606         * BuildSlaveSupport/ews-build/factories.py:
3607         (Factory.__init__): Add the ApplyPatch step.
3608         * BuildSlaveSupport/ews-build/steps.py:
3609         (CheckOutSource): Added step name.
3610         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
3611         (ApplyPatch): Build step to apply patch using svn-apply script.
3612         (UnApplyPatchIfRequired):
3613         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
3614
3615 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3616
3617         Deprecate WKContextCreate
3618         https://bugs.webkit.org/show_bug.cgi?id=193118
3619
3620         Reviewed by Brady Eidson.
3621
3622         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3623         (WebKitBrowserWindow::WebKitBrowserWindow):
3624         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
3625         (TestWebKitAPI::TEST):
3626         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3627         (TestWebKitAPI::TEST):
3628         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3629         (TestWebKitAPI::TEST):
3630         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3631         (TestWebKitAPI::TEST):
3632         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3633         (TestWebKitAPI::TEST):
3634         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3635         (TestWebKitAPI::TEST):
3636         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3637         (TestWebKitAPI::TEST):
3638         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3639         (TestWebKitAPI::TEST):
3640         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3641         (TestWebKitAPI::TEST):
3642         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3643         (TestWebKitAPI::TEST):
3644         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3645         (TestWebKitAPI::TEST):
3646         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3647         (TestWebKitAPI::TEST):
3648         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3649         (TestWebKitAPI::TEST):
3650         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3651         (TestWebKitAPI::TEST):
3652         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3653         (TestWebKitAPI::TEST):
3654         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3655         (TestWebKitAPI::TEST):
3656         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3657         (TestWebKitAPI::TEST):
3658         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3659         (TestWebKitAPI::TEST):
3660         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3661         (TestWebKitAPI::loadAlternateHTMLString):
3662         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3663         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3664         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3665         (TestWebKitAPI::buildAndPerformTest):
3666         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3667         (TestWebKitAPI::TEST):
3668         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3669         (TestWebKitAPI::TEST):
3670         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3671         (TestWebKitAPI::TEST):
3672         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3673         (TestWebKitAPI::TEST):
3674         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3675         (TestWebKitAPI::TEST):
3676         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3677         (TestWebKitAPI::TEST):
3678         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3679         (TestWebKitAPI::TEST):
3680         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3681         (TestWebKitAPI::TEST):
3682         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3683         (TestWebKitAPI::TEST):
3684         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3685         (TestWebKitAPI::TEST):
3686         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3687         (TestWebKitAPI::TEST):
3688         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3689         (TestWebKitAPI::TEST):
3690         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3691         (TestWebKitAPI::TEST):
3692         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3693         (TestWebKitAPI::TEST):
3694         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3695         (TestWebKitAPI::TEST):
3696         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3697         (TestWebKitAPI::TEST):
3698         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3699         (TestWebKitAPI::TEST):
3700         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3701         (TestWebKitAPI::TEST):
3702         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3703         (TestWebKitAPI::TEST):
3704         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3705         (TestWebKitAPI::TEST):
3706         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3707         (TestWebKitAPI::TEST):
3708         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3709         (TestWebKitAPI::TEST):
3710         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3711         (TestWebKitAPI::TEST):
3712         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3713         (TestWebKitAPI::TEST):
3714         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3715         (TestWebKitAPI::TEST):
3716         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3717         (TestWebKitAPI::TEST):
3718         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3719         (WebKit2_CommandBackForwardTestWKView::SetUp):
3720         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3721         (TestWebKitAPI::TEST):
3722         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3723         (TestWebKitAPI::TEST):
3724         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3725         (TestWebKitAPI::TEST):
3726         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3727         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3728
3729 2019-01-03  Matt Rajca  <mrajca@apple.com>
3730
3731         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3732         https://bugs.webkit.org/show_bug.cgi?id=193128
3733         rdar://34554231
3734
3735         Reviewed by Jer Noble.
3736
3737         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3738         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3739         event along with a flag that indicates whether or not autoplay was actually prevented.
3740
3741         Tests: existing API tests were updated to reflect the new names. New API tests
3742         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3743
3744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3745         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3746         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3747         (TEST):
3748         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3749         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3750
3751 2019-01-04  Chris Dumez  <cdumez@apple.com>
3752
3753         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3754         https://bugs.webkit.org/show_bug.cgi?id=193120
3755
3756         Reviewed by Alex Christensen.
3757
3758         Add API test coverage.
3759
3760         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3761
3762 2019-01-04  Chris Dumez  <cdumez@apple.com>
3763
3764         Crash under WebProcessPool::addSuspendedPage()
3765         https://bugs.webkit.org/show_bug.cgi?id=193110
3766
3767         Reviewed by Youenn Fablet.
3768
3769         Add API test coverage.
3770
3771         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3772
3773 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3774
3775         [ews-build] Check patch relevance before applying the patch
3776         https://bugs.webkit.org/show_bug.cgi?id=193102
3777
3778         Reviewed by Lucas Forschler.
3779
3780         * BuildSlaveSupport/ews-build/factories.py:
3781         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3782
3783 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3784
3785         [ews-build] Check patch relevance step should print patch id
3786         https://bugs.webkit.org/show_bug.cgi?id=193137
3787
3788         Reviewed by Lucas Forschler.
3789
3790         * BuildSlaveSupport/ews-build/steps.py:
3791         (CheckPatchRelevance.start): Update the status to include patch id.
3792
3793 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3794
3795         webkitpy: Increase simulator teardown timeout
3796         https://bugs.webkit.org/show_bug.cgi?id=193141
3797         <rdar://problem/46174217>
3798
3799         Rubber-stamped by Aakash Jain.
3800
3801         * Scripts/webkitpy/xcode/simulated_device.py:
3802         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3803
3804 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3805
3806         test262-runner misbehaves when test file YAML has a trailing space
3807         https://bugs.webkit.org/show_bug.cgi?id=193053
3808
3809         Reviewed by Yusuke Suzuki.
3810
3811         * Scripts/test262/Runner.pm:
3812         (parseData):
3813         Accept trailing space when parsing a test file's YAML block.
3814
3815 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3816
3817         UserMedia test should use WKPageNavigationClient
3818         https://bugs.webkit.org/show_bug.cgi?id=192913
3819
3820         Reviewed by Youenn Fablet.
3821
3822         The test currently uses the deprecated WKPageLoaderClient. It should use
3823         WKPageNavigationClient instead, which provides the same callback under a similar name.
3824
3825         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3826         (TestWebKitAPI::TEST):
3827
3828 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3829
3830         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3831         https://bugs.webkit.org/show_bug.cgi?id=192944
3832
3833         Reviewed by Tim Horton.
3834
3835         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3836         (TestWebKitAPI::TEST):
3837
3838 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3839
3840         Add support for using the current text selection as the find string on iOS
3841         https://bugs.webkit.org/show_bug.cgi?id=193034
3842         <rdar://problem/45138739>
3843
3844         Reviewed by Tim Horton.
3845
3846         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3847         _setStringForFind) works as expected.
3848
3849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3850         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3851
3852 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3853
3854         [ews-build] Use git on OpenSource EWS bots
3855         https://bugs.webkit.org/show_bug.cgi?id=193092
3856
3857         Reviewed by Lucas Forschler.
3858
3859         * BuildSlaveSupport/ews-build/steps.py:
3860         (CheckOutSource): Use git instead of svn.
3861         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3862
3863 2019-01-02  Daniel Bates  <dabates@apple.com>
3864
3865         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3866         https://bugs.webkit.org/show_bug.cgi?id=193023
3867
3868         Reviewed by Simon Fraser.
3869
3870         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3871         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3872         enumerator values. We should just remove this code.
3873
3874         * lldb/lldb_webkit.py:
3875         (WTFOptionSetProvider.has_children):
3876         (WTFOptionSetProvider.num_children):
3877         (WTFOptionSetProvider.get_child_index):
3878         (WTFOptionSetProvider.get_child_at_index):
3879
3880 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3881
3882         .ycm_extra_conf.py should handle XXXInlines.h
3883         https://bugs.webkit.org/show_bug.cgi?id=193055
3884
3885         Reviewed by Carlos Garcia Campos.
3886
3887         compile_commands.json database only records flags and options for cpp source files.
3888         So, when we open headers, this database does not have any information for that.
3889         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3890         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3891         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3892         we attempt to find XXX.cpp and use the configuration if it exists.
3893
3894         * gtk/ycm_extra_conf.py:
3895         (getImplementationFilename):
3896         (FlagsForFile):
3897
3898 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3899
3900         Unreviewed. Support PHP 7.3 in Debian.
3901
3902         Add 7.3 to the list of php versions supported in Debian.
3903
3904         * Scripts/webkitpy/port/base.py:
3905         (Port._debian_php_version):
3906
3907 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3908
3909         Resurrect Mac CMake build
3910         https://bugs.webkit.org/show_bug.cgi?id=192658
3911
3912         Reviewed by Yusuke Suzuki.
3913
3914         * DumpRenderTree/PlatformMac.cmake:
3915         * MiniBrowser/mac/CMakeLists.txt:
3916         * TestWebKitAPI/PlatformMac.cmake:
3917
3918 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3919
3920         [Tools] Remove references to Bison and Flex
3921         https://bugs.webkit.org/show_bug.cgi?id=193033
3922
3923         Reviewed by Michael Catanzaro.
3924
3925         The Bison and Flex tools are not needed anymore since r209883.
3926
3927         * CygwinDownloader/cygwin-downloader.py:
3928         * EWSTools/ubuntu-ews-packages:
3929         * Scripts/filter-build-webkit:
3930         (shouldIgnoreLine):
3931         * gtk/install-dependencies:
3932         * wpe/install-dependencies:
3933
3934 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3935
3936         WebDriver: warn about non existing tests when parsing expectations
3937         https://bugs.webkit.org/show_bug.cgi?id=192979
3938
3939         Reviewed by Michael Catanzaro.
3940
3941         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
3942         renamed.
3943
3944         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3945         (WebDriverTestRunner.__init__):
3946
3947 2018-12-21  Chris Dumez  <cdumez@apple.com>
3948
3949         navigator.userAgent in service workers does not reflect customUserAgent set by client
3950         https://bugs.webkit.org/show_bug.cgi?id=192951
3951
3952         Reviewed by Youenn Fablet.
3953
3954         Extend API test coverage.
3955
3956         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3957         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
3958         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3959         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
3960         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3961
3962 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3963
3964         [WebAuthN] userPresence should always be true
3965         https://bugs.webkit.org/show_bug.cgi?id=192835
3966         <rdar://problem/46538788>
3967
3968         Reviewed by Brent Fulgham.
3969
3970         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3971         (TestWebKitAPI::TEST):
3972
3973 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
3974
3975         Add support to run-benchmark to use non-default copies of the browser apps
3976         https://bugs.webkit.org/show_bug.cgi?id=192905
3977         rdar://problem/46845840
3978
3979         Reviewed by Dewei Zhu.
3980         
3981         Add support for a --browser-path argument to run-benchmark, which allows you to use
3982         a custom app bundle for a given browser (only implemented for Safari at present).
3983
3984         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3985         (BenchmarkRunner.__init__):
3986         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3987         (BrowserDriver.__init__):
3988         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3989         (BrowserDriverFactory.create):
3990         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3991         (OSXBrowserDriver._launch_process):
3992         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
3993         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
3994         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3995         (OSXChromeCanaryDriver.launch_url):
3996         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3997         (OSXFirefoxNightlyDriver.launch_url):
3998         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3999         (OSXSafariDriver.__init__):
4000         (OSXSafariDriver.launch_url):
4001         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
4002         (parse_args):
4003         (run_benchmark_plan):
4004         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
4005         (WebServerBenchmarkRunner.__init__):
4006         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
4007         (FakeBenchmarkRunner.__init__):
4008
4009 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
4010
4011         [WebAuthN] Import an APDU coder from Chromium
4012         https://bugs.webkit.org/show_bug.cgi?id=192949
4013         <rdar://problem/46879933>
4014
4015         Reviewed by Brent Fulgham.
4016
4017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4018         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
4019         (TestWebKitAPI::TEST):
4020
4021 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
4022
4023         Setting the file wrapper and content type of an attachment to a PDF should update its image
4024         https://bugs.webkit.org/show_bug.cgi?id=192984
4025         <rdar://problem/46798028>
4026
4027         Reviewed by Tim Horton.
4028
4029         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
4030         PDF data correctly updates the image element.
4031
4032         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4033
4034 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
4035
4036         Add JSCOnly to bot dashboard
4037         https://bugs.webkit.org/show_bug.cgi?id=192964
4038
4039         Reviewed by Alexey Proskuryakov.
4040
4041         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
4042         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
4043         useful if they were not so secret, so add them.
4044
4045         There appear to be no build-only bots, so the first column is blank. And of course there are
4046         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
4047         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
4048         and there's plenty of room in the final column for all the bots.
4049
4050         I had a hard time picking a logo to use, because the JavaScript language does not have an
4051         official logo. But I believe I've found one that will be satisfactory.
4052
4053         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
4054
4055         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
4056         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
4057         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4058         (BubbleQueueServer):
4059         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4060         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4061         (WebKitBuildbot):
4062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4063         (table.queue-grid tr.platform.linux-jsconly img.logo):
4064
4065 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
4066
4067         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
4068         https://bugs.webkit.org/show_bug.cgi?id=192821
4069
4070         Reviewed by Chris Dumez.
4071
4072         * DumpRenderTree/mac/DumpRenderTree.mm:
4073         (createWebViewAndOffscreenWindow):
4074         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
4075
4076 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
4077
4078         [Win][Clang] Fix compilation warnings of DumpRenderTree
4079         https://bugs.webkit.org/show_bug.cgi?id=192924
4080
4081         Reviewed by Alex Christensen.
4082
4083         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
4084         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4085         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
4086         * DumpRenderTree/win/DumpRenderTree.cpp:
4087         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
4088         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
4089         object to the argument of setDefaultTextEncodingName instead of a
4090         const string literal.
4091         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
4092         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
4093         (setCacheFolder): Deleted.
4094         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
4095         * DumpRenderTree/win/EditingDelegate.cpp:
4096         (dump): Use %d for int.
4097         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
4098         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4099         (BSTRFromString): Deleted unused function.
4100         * DumpRenderTree/win/TestRunnerWin.cpp:
4101         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
4102         the arguemnt of setQuota instead of const string literal.
4103         * DumpRenderTree/win/WorkQueueItemWin.cpp:
4104         (jsStringRefToWString): Deleted unused function.
4105
4106 2018-12-20  Chris Dumez  <cdumez@apple.com>
4107
4108         Add API test coverage for customUserAgent client setting and service workers
4109         https://bugs.webkit.org/show_bug.cgi?id=192952
4110
4111         Reviewed by Alex Christensen.
4112
4113         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4114         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
4115         (-[SWSchemes webView:startURLSchemeTask:]):
4116         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4117         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
4118
4119 2018-12-20  Chris Dumez  <cdumez@apple.com>
4120
4121         Use Optional::hasValue() instead of Optional::has_value()
4122         https://bugs.webkit.org/show_bug.cgi?id=192948
4123
4124         Reviewed by Tim Horton.
4125
4126         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
4127         (TestWebKitAPI::TEST):
4128         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
4129         (TestWebKitAPI::TEST):
4130         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
4131         (TestWebKitAPI::TEST_F):
4132
4133 2018-12-20  Chris Dumez  <cdumez@apple.com>
4134
4135         Add style script rule to check for uses of std::optional<>
4136         https://bugs.webkit.org/show_bug.cgi?id=192931
4137
4138         Reviewed by Tim Horton.
4139
4140         * Scripts/webkitpy/style/checkers/cpp.py:
4141         (check_wtf_optional):
4142         (check_style):
4143
4144 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
4145
4146         [WebAuthN] Add a runtime flag for local authenticator
4147         https://bugs.webkit.org/show_bug.cgi?id=192792
4148         <rdar://problem/46798738>
4149
4150         Reviewed by Brent Fulgham.
4151
4152         * DumpRenderTree/TestOptions.cpp:
4153         (TestOptions::TestOptions):
4154         * DumpRenderTree/TestOptions.h:
4155         * DumpRenderTree/mac/DumpRenderTree.mm:
4156         (enableExperimentalFeatures):
4157         (setWebPreferencesForTestOptions):
4158         * WebKitTestRunner/TestController.cpp:
4159         (WTR::TestController::resetPreferencesToConsistentValues):
4160         (WTR::updateTestOptionsFromTestHeader):
4161         * WebKitTestRunner/TestOptions.h:
4162         (WTR::TestOptions::hasSameInitializationOptions const):
4163
4164 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
4165
4166         webkitpy: Autoinstall package URLs have changed
4167         https://bugs.webkit.org/show_bug.cgi?id=192909
4168         <rdar://problem/46860359>
4169
4170         Rubber-stamped by Alexey Proskuryakov.
4171
4172         PyPi urls have been moved around, we need to update our auto-installed packages.
4173
4174         We should check for Selenium before asking PyPi for the latest version.
4175
4176         * Scripts/webkitpy/thirdparty/__init__.py:
4177         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
4178         (AutoinstallImportHook._install_keyring): Ditto.
4179         (AutoinstallImportHook._install_pep8): Ditto.
4180         (AutoinstallImportHook._install_mozlog): Ditto.
4181         (AutoinstallImportHook._install_mozprocess): Ditto.
4182         (AutoinstallImportHook._install_pytest_timeout): Ditto.
4183         (AutoinstallImportHook._install_pytest): Ditto.
4184         (AutoinstallImportHook._install_pylint): Ditto.
4185         (AutoinstallImportHook._install_buildbot): Ditto.
4186         (AutoinstallImportHook._install_coverage): Ditto.
4187         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
4188         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
4189         for new Selenium if the installed version isn't sufficient.
4190         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
4191
4192 2018-12-20  Chris Dumez  <cdumez@apple.com>
4193
4194         Use Optional::valueOr() instead of Optional::value_or()
4195         https://bugs.webkit.org/show_bug.cgi?id=192933
4196
4197         Reviewed by Geoffrey Garen.
4198
4199         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
4200         (TestWebKitAPI::checkURL):
4201         (TestWebKitAPI::checkRelativeURL):
4202         (TestWebKitAPI::checkURLDifferences):
4203         (TestWebKitAPI::checkRelativeURLDifferences):
4204         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
4205         (TestWebKitAPI::checkURL):
4206
4207 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
4208
4209         Unreviewed, rolling out r239417.
4210
4211         Introduced two API test failures on macOS.
4212
4213         Reverted changeset:
4214
4215         "<rdar://problem/46194315> macOS: WebKit1 does not handle
4216         occlusion changes"
4217         https://bugs.webkit.org/show_bug.cgi?id=192821
4218         https://trac.webkit.org/changeset/239417
4219
4220 2018-12-20  Devin Rousso  <drousso@apple.com>
4221
4222         Web Inspector: UIString should take an optional key and description to aid localization
4223         https://bugs.webkit.org/show_bug.cgi?id=153962
4224         <rdar://problem/24542505>
4225
4226         Reviewed by Brian Burg.
4227
4228         * Scripts/extract-localizable-js-strings:
4229
4230 2018-12-20  Tim Horton  <timothy_horton@apple.com>
4231
4232         Unparented WKWebView can't retrieve main resource data for a main frame plugin
4233         https://bugs.webkit.org/show_bug.cgi?id=192923
4234         <rdar://problem/46859068>
4235
4236         Reviewed by Wenson Hsieh.
4237
4238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4239         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
4240         Add a test ensuring that both parented and unparented WKWebViews can
4241         retrieve main resource data when loading a PDF.
4242
4243 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
4244
4245         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
4246         https://bugs.webkit.org/show_bug.cgi?id=192852
4247
4248         Reviewed by Michael Catanzaro.
4249
4250         EmojiOne font was replaced by Noto Color Emoji.
4251
4252         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
4253         * gtk/jhbuild.modules:
4254         * wpe/jhbuild.modules:
4255
4256 2018-12-19  Chris Dumez  <cdumez@apple.com>
4257
4258         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
4259         https://bugs.webkit.org/show_bug.cgi?id=192728
4260         <rdar://problem/46746779>
4261
4262         Reviewed by Geoff Garen.
4263
4264         * DumpRenderTree/*:
4265         * MiniBrowser/*:
4266         * TestRunnerShared/*:
4267         * TestWebKitAPI/*:
4268         * WebGPUAPIStructure/*:
4269         * WebKitTestRunner/*:
4270
4271 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
4272
4273         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
4274         https://bugs.webkit.org/show_bug.cgi?id=192821
4275
4276         Reviewed by Chris Dumez.
4277
4278         * DumpRenderTree/mac/DumpRenderTree.mm:
4279         (createWebViewAndOffscreenWindow):
4280
4281 2018-12-19  Alex Christensen  <achristensen@webkit.org>
4282
4283         Navigations away from the SafeBrowsing interstitial show a flash of old content
4284         https://bugs.webkit.org/show_bug.cgi?id=192676
4285
4286         Reviewed by Chris Dumez.
4287