Using Tools/Scripts/clean-webkit should not install requests
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2
3         Using Tools/Scripts/clean-webkit should not install requests
4         https://bugs.webkit.org/show_bug.cgi?id=196940
5
6         Reviewed by Lucas Forschler.
7
8         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
9         existing, depending on the path autoinstalled is run through.
10         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
11         needed.
12         (Port.configuration_for_upload):
13         (Port.commits_for_upload):
14
15 2019-04-15  Alex Christensen  <achristensen@webkit.org>
16
17         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
18         https://bugs.webkit.org/show_bug.cgi?id=196773
19
20         Reviewed by Jer Noble.
21
22         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
23         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
24         (TEST):
25
26 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
27
28         ews-build should clearly indicate flaky test failures
29         https://bugs.webkit.org/show_bug.cgi?id=196947
30
31         Reviewed by Lucas Forschler.
32
33         * BuildSlaveSupport/ews-build/steps.py:
34         (AnalyzeAPITestsResults.analyzeResults):
35
36 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
37
38         InjectedBundle parameters often need initialization function called before unarchiving
39         https://bugs.webkit.org/show_bug.cgi?id=189709
40         <rdar://problem/44573653>
41
42         Reviewed by Ryosuke Niwa.
43
44         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
45         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
46
47 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
48
49         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
50         https://bugs.webkit.org/show_bug.cgi?id=196681
51
52         Reviewed by Darin Adler.
53
54         Added tests.
55
56         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
57         (WTF_HashSet.RemoveIf):
58         (WTF_HashSet.RemoveIfShrinkToBestSize):
59
60 2019-04-15  John Wilander  <wilander@apple.com>
61
62         Send delayed Ad Click Attribution conversion requests to the click source
63         https://bugs.webkit.org/show_bug.cgi?id=196838
64         <rdar://problem/47650157>
65
66         Reviewed by Chris Dumez and Youenn Fablet.
67
68         This patch adds test infrastructure to override the default behavior in
69         WebKit::NetworkAdClickAttribution.
70
71         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
72         (TestWebKitAPI::TEST):
73         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
74         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
75         (WTR::TestRunner::dumpAdClickAttribution):
76         (WTR::TestRunner::clearAdClickAttribution):
77         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
78         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
79         * WebKitTestRunner/InjectedBundle/TestRunner.h:
80         * WebKitTestRunner/TestController.cpp:
81         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
82         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
83         * WebKitTestRunner/TestController.h:
84         * WebKitTestRunner/TestInvocation.cpp:
85         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
86
87 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
88
89         [ews-app] status-bubble should display position in queue
90         https://bugs.webkit.org/show_bug.cgi?id=196607
91
92         Reviewed by Lucas Forschler.
93
94         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
95         (StatusBubble._build_bubble):
96         (StatusBubble._queue_position): Method to calculate patch's position in queue.
97
98 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
99
100         [ews-build] Do not run clean build by default on EWS builders
101         https://bugs.webkit.org/show_bug.cgi?id=196897
102
103         Reviewed by Lucas Forschler.
104
105         * BuildSlaveSupport/ews-build/steps.py:
106         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
107         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
108         untracked directories like WebKitBuild).
109         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
110         untracked files/directories (like WebKitBuild).
111
112 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
113
114         TestRunner::notifyDone() should be safely reentrant
115         https://bugs.webkit.org/show_bug.cgi?id=196898
116
117         Reviewed by Darin Adler.
118
119         It is currently possible that TestRunner::notifyDone() will call itself, since
120         notifyDone() will force a repaint, which can start executing JavaScript, which
121         may call notifyDone() again. This can lead to test failures and flakiness.
122         Fix this by setting the m_waitToDump flag before calling the dump() method.
123
124         * DumpRenderTree/mac/TestRunnerMac.mm:
125         (TestRunner::notifyDone):
126         (TestRunner::forceImmediateCompletion):
127         * DumpRenderTree/win/TestRunnerWin.cpp:
128         (TestRunner::notifyDone):
129         (TestRunner::forceImmediateCompletion):
130
131 2019-04-15  Philippe Normand  <pnormand@igalia.com>
132
133         [GTK][WPE] Add enable-media websetting
134         https://bugs.webkit.org/show_bug.cgi?id=196863
135
136         Reviewed by Michael Catanzaro.
137
138         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
139         (testWebKitSettings): Add test for the enable-media web-setting.
140
141 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
142
143         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
144         https://bugs.webkit.org/show_bug.cgi?id=196905
145         <rdar://problem/49886096>
146
147         Reviewed by Tim Horton.
148
149         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
150         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
151         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
152         delay timer, we end up with this sequence of events in the problematic (failure) case:
153
154         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
155             ...IPC from UI to web process...
156         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
157             ...IPC from web to UI process...
158         (c) [UI]    Invoke completion handler for script #1
159         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
160             ...IPC from UI to web process...
161         (e) [Web]   Evaluate script #2 in the web process
162         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
163
164         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
165         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
166         #2 is run in step (e).
167
168         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
169         the UI process by waiting on a script message posted by the web process, after attachment updates are
170         dispatched.
171
172         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
173         (TestWebKitAPI::TEST):
174
175 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
176
177         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
178         https://bugs.webkit.org/show_bug.cgi?id=196909
179
180         Reviewed by Wenson Hsieh.
181
182         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
183         (TestWebKitAPI::TEST):
184
185 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
186
187         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
188         https://bugs.webkit.org/show_bug.cgi?id=196880
189
190         Reviewed by Yusuke Suzuki.
191
192         Add a new function for bytecode cache tests that does not forceDiskCache
193         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
194         test added in this patch, since the code is invalid and therefore won't be
195         cached. It should also be useful for tests that evaluate dynamically
196         generated code.
197
198         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
199         * Scripts/run-jsc-stress-tests:
200
201 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
202
203         Update AudioSession route sharing policy
204         https://bugs.webkit.org/show_bug.cgi?id=196776
205         <rdar://problem/46501611>
206
207         Reviewed by Jer Noble.
208
209         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
210         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
211         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
212         (TestWebKitAPI::TEST):
213
214 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
215
216         [iOS] Software keyboard is shown too frequently on some websites
217         https://bugs.webkit.org/show_bug.cgi?id=195856
218         <rdar://problem/49191395>
219
220         Reviewed by Darin Adler.
221
222         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
223
224         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
225         (WTR::UIScriptController::setHardwareKeyboardAttached):
226         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
227         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
228         (WTR::UIScriptController::setHardwareKeyboardAttached):
229         * TestRunnerShared/UIScriptContext/UIScriptController.h:
230         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
231
232         Additionally link against GraphicsServices in WebKitTestRunner.
233
234         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
235         (WTR::TestController::platformResetStateToConsistentValues):
236         (WTR::UIScriptController::setHardwareKeyboardAttached):
237
238 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
239
240         [GTK][WPE] Fix pacman install-dependencies packages
241         https://bugs.webkit.org/show_bug.cgi?id=196817
242
243         Reviewed by Žan Doberšek.
244         
245         python3-setuptools is called python-setuptools
246         ruby-highline is only available on AUR
247         libv4l-devel is incorporated in v4l-utils
248
249         * gtk/install-dependencies:
250         * wpe/install-dependencies:
251
252 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
253
254         [GTK] REGRESSION(r243860): Many tests failing
255         https://bugs.webkit.org/show_bug.cgi?id=196791
256
257         Reviewed by Joanmarie Diggs.
258
259         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
260         multiple documents and check that accessibility hierarchy is updated after a navigation.
261
262         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
263         (loadChangedCallback):
264         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
265         (AccessibilityTest::AccessibilityTest):
266         (AccessibilityTest::~AccessibilityTest):
267         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
268         (AccessibilityTest::findTestServerApplication):
269         (AccessibilityTest::findDocumentWeb):
270         (AccessibilityTest::findRootObject):
271         (AccessibilityTest::waitUntilChildrenRemoved):
272         (AccessibilityTest::ensureProxy):
273         (testAtspiBasicHierarchy):
274         (beforeAll):
275         (afterAll):
276
277 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
278
279         [ews-build] Handle bug titles with unicode characters
280         https://bugs.webkit.org/show_bug.cgi?id=196802
281
282         Reviewed by Dewei Zhu.
283
284         * BuildSlaveSupport/ews-build/steps.py:
285         (ValidatePatch._is_bug_closed):
286
287 2019-04-11  Michael Saboff  <msaboff@apple.com>
288
289         Improve the Inline Cache Stats code
290         https://bugs.webkit.org/show_bug.cgi?id=196836
291
292         Reviewed by Saam Barati.
293
294         Added a new script to consolidate and arrange the output of --useICStats option.
295
296         This script merges the output from every group into one large table and sorts it from most common to
297         least common.  It also counts the slow path GetById and PutById variants and then calculates the
298         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
299         Put together, this is useful to see what property accesses are not getting cached.
300
301         * Scripts/ic-stats.py: Added.
302         (ICStats):
303         (ICStats.__init__):
304         (ICStats.parse):
305         (ICStats.dumpStats):
306         (usage):
307
308 2019-04-10  Alex Christensen  <achristensen@webkit.org>
309
310         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
311         https://bugs.webkit.org/show_bug.cgi?id=196809
312         <rdar://49800762>
313
314         Reviewed by Brady Eidson.
315
316         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
317         (TEST):
318
319 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
320
321         requestAnimationFrame should execute before the next frame
322         https://bugs.webkit.org/show_bug.cgi?id=177484
323
324         Reviewed by Simon Fraser.
325
326         Add trace points for the page RenderingUpdate.
327
328         * Tracing/SystemTracePoints.plist:
329
330 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
331
332         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
333         https://bugs.webkit.org/show_bug.cgi?id=196760
334
335         Reviewed by Don Olmstead.
336
337         vswhere.exe has been bundled since Visual Studio 2017 version
338         15.2. We shouldn't download vswhere.exe.
339
340         * Scripts/build-jsc: Do not call update-vswhere.py.
341         * Scripts/build-webkit: Ditto.
342         * Scripts/update-vswhere.py: Removed.
343         * Scripts/webkitdirs.pm:
344         (requireModulesForVSWhere): Deleted.
345         (pickCurrentVisualStudioInstallation): Deleted.
346         (visualStudioInstallDirVSWhere): Return the latest installed VS
347         installation path by using the bundled vswhere.exe.
348         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
349         (visualStudioInstallDirFallback): Removed.
350
351 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
352
353         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
354         https://bugs.webkit.org/show_bug.cgi?id=196780
355
356         Reviewed by Alexey Proskuryakov.
357
358         * BuildSlaveSupport/ews-build/steps.py:
359         * BuildSlaveSupport/ews-build/steps_unittest.py:
360
361 2019-04-10  Alex Christensen  <achristensen@webkit.org>
362
363         Add SPI WKNavigationResponse._downloadAttribute
364         https://bugs.webkit.org/show_bug.cgi?id=196755
365         <rdar://49587365>
366
367         Reviewed by Brady Eidson.
368
369         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
370         (-[NavigationResponseTestDelegate navigationResponse]):
371         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
372         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
373         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
374         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
375         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
376         (readRequest):
377         (writeResponse):
378         (TEST):
379
380 2019-04-10  Tim Horton  <timothy_horton@apple.com>
381
382         Add modern API for overriding the page's specified viewport configuration
383         https://bugs.webkit.org/show_bug.cgi?id=167734
384         <rdar://problem/30331795>
385
386         Reviewed by Simon Fraser.
387
388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
389         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
390
391 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
392
393         Add support for incremental bytecode cache updates
394         https://bugs.webkit.org/show_bug.cgi?id=195000
395
396         Reviewed by Filip Pizlo.
397
398         Exit when the initial run to generate bytecode fails.
399
400         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
401
402 2019-04-10  Alex Christensen  <achristensen@webkit.org>
403
404         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
405         https://bugs.webkit.org/show_bug.cgi?id=196744
406         <rdar://49415309>
407
408         Reviewed by Chris Dumez.
409
410         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
411         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
412
413 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
414
415         Add a way to opt into modern compatibility mode in layout tests
416         https://bugs.webkit.org/show_bug.cgi?id=196770
417         <rdar://problem/49777550>
418
419         Reviewed by Antoine Quint.
420
421         Add a new test option to enable modern compatibility mode in layout tests.
422
423         * WebKitTestRunner/TestController.cpp:
424         (WTR::updateTestOptionsFromTestHeader):
425         * WebKitTestRunner/TestController.h:
426         * WebKitTestRunner/TestOptions.h:
427         (WTR::TestOptions::hasSameInitializationOptions const):
428         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
429         (WTR::TestController::platformCreateWebView):
430         (WTR::TestController::enableModernCompatibilityMode):
431
432 2019-04-10  Andy Estes  <aestes@apple.com>
433
434         Try to fix the 32-bit watchOS build.
435
436         * TestWebKitAPI/cocoa/TestWKWebView.mm:
437         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
438
439 2019-04-10  Antoine Quint  <graouts@apple.com>
440
441         Enable Pointer Events on watchOS
442         https://bugs.webkit.org/show_bug.cgi?id=196771
443         <rdar://problem/49040909>
444
445         Reviewed by Dean Jackson.
446
447         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
448
449 2019-04-10  Philippe Normand  <pnormand@igalia.com>
450
451         Unreviewed. Fix WPE accessibility tests after r244059.
452
453         We are failing to load the injected bundle due to undefined symbol
454         AccessibilityUIElement::replaceTextInRange().
455
456         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
457         (WTR::AccessibilityUIElement::replaceTextInRange):
458
459 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
460
461         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
462         https://bugs.webkit.org/show_bug.cgi?id=196727
463
464         Reviewed by Fujii Hironori.
465
466         * MiniBrowser/win/WebKitBrowserWindow.cpp:
467         (WebKitBrowserWindow::create):
468
469 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
470
471         [ews-build] Add unit tests for PrintConfiguration
472         https://bugs.webkit.org/show_bug.cgi?id=196752
473
474         Reviewed by Dewei Zhu.
475
476         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
477
478 2019-04-09  Keith Rollin  <krollin@apple.com>
479
480         Unreviewed build maintenance -- update .xcfilelists.
481
482         * DumpRenderTree/DerivedSources-input.xcfilelist:
483         * DumpRenderTree/DerivedSources-output.xcfilelist:
484
485 2019-04-09  Zalan Bujtas  <zalan@apple.com>
486
487         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
488         https://bugs.webkit.org/show_bug.cgi?id=196743
489         <rdar://problem/43897551>
490
491         Reviewed by Tim Horton.
492
493         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
494         (TEST):
495
496 2019-04-09  Youenn Fablet  <youenn@apple.com>
497
498         Close service worker database on network process suspension
499         https://bugs.webkit.org/show_bug.cgi?id=196623
500         <rdar://problem/48930869>
501
502         Reviewed by Alex Christensen.
503
504         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
505
506 2019-04-09  Daniel Bates  <dabates@apple.com>
507
508         [iPad] Should open popover when the spacebar is pressed
509         https://bugs.webkit.org/show_bug.cgi?id=196360
510         <rdar://problem/49389129>
511
512         Reviewed by Brent Fulgham.
513
514         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
515
516         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
517         (WTR::UIScriptController::isShowingPopover const): Added.
518         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
519         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
520         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
521         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
522         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
523         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
524         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
525         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
526         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
527         (WTR::UIScriptController::isShowingPopover const): Added.
528         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
529         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
530         * TestRunnerShared/UIScriptContext/UIScriptController.h:
531         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
532         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
533         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
534         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
535         (-[TestRunnerWKWebView _willPresentPopover]): Added.
536         (-[TestRunnerWKWebView _didDismissPopover]): Added.
537         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
538         (WTR::UIScriptController::isShowingPopover const): Added.
539         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
540         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
541
542 2019-04-09  Alex Christensen  <achristensen@webkit.org>
543
544         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
545         https://bugs.webkit.org/show_bug.cgi?id=196665
546         <rdar://45115669>
547
548         Reviewed by Geoff Garen.
549
550         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
551         (goBack):
552         (+[SimpleLookupContext sharedLookupContext]):
553         (-[SimpleLookupContext lookUpURL:completionHandler:]):
554         (TEST):
555         (+[Simple3LookupContext sharedLookupContext]): Deleted.
556         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
557
558 2019-04-09  John Wilander  <wilander@apple.com>
559
560         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
561         https://bugs.webkit.org/show_bug.cgi?id=196558
562         <rdar://problem/47650245>
563
564         Reviewed by Youenn Fablet.
565
566         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
567         (TestWebKitAPI::TEST):
568             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
569
570 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
571
572         [CMake] Apple builds should use ICU_INCLUDE_DIRS
573         https://bugs.webkit.org/show_bug.cgi?id=196720
574
575         Reviewed by Konstantin Tokarev.
576
577         * TestWebKitAPI/PlatformMac.cmake:
578
579 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
580
581         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
582         https://bugs.webkit.org/show_bug.cgi?id=196694
583         <rdar://problem/48388734>
584
585         Rubber-stamped by Aakash Jain.
586
587         * Scripts/webkitpy/port/image_diff.py:
588         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
589         * Scripts/webkitpy/port/server_process.py:
590         (ServerProcess.has_available_stdout): Check if stdout has data in it.
591         (ServerProcess._wait_for_data_and_update_buffers_using_select):
592         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
593         * Scripts/webkitpy/port/server_process_mock.py:
594         (MockServerProcess.has_available_stdout):
595         * Scripts/webkitpy/port/server_process_unittest.py:
596         (TestServerProcess.serial_test_basic):
597
598 2019-04-09  Jer Noble  <jer.noble@apple.com>
599
600         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
601         https://bugs.webkit.org/show_bug.cgi?id=196097
602
603         Reviewed by Eric Carlson.
604
605         Drive-by bug fix: allow tests to play audio without a user gesture by default.
606
607         * DumpRenderTree/mac/DumpRenderTree.mm:
608         (resetWebPreferencesToConsistentValues):
609         * WebKitTestRunner/TestController.cpp:
610         (WTR::TestController::resetPreferencesToConsistentValues):
611
612 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
613
614         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
615         https://bugs.webkit.org/show_bug.cgi?id=196690
616
617         Reviewed by Michael Catanzaro.
618
619         * QueueStatusServer/config/queues.py:
620         * Scripts/webkitpy/common/config/ews.json:
621         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
622         (test_ews_name):
623
624 2019-04-09  Chris Dumez  <cdumez@apple.com>
625
626         Loads using loadHTMLString() cause flashing when process-swapping
627         https://bugs.webkit.org/show_bug.cgi?id=196714
628         <rdar://problem/49637354>
629
630         Reviewed by Antti Koivisto.
631
632         Add API test coverage.
633
634         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
635
636 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
637
638         Unreviewed. Fix ATK accessibility tests after r244059.
639
640         We are failing to load the injected bundle due to undefined symbol
641         AccessibilityUIElement::replaceTextInRange().
642
643         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
644         (WTR::AccessibilityUIElement::replaceTextInRange):
645
646 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
647
648         AX: Support API: accessibilityReplaceRange:withText
649         https://bugs.webkit.org/show_bug.cgi?id=196636
650
651         Unreviewed build fix for Windows port.
652
653         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
654         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
655
656 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
657
658         [CMake][WinCairo] Separate copied headers into different directories
659         https://bugs.webkit.org/show_bug.cgi?id=196655
660
661         Reviewed by Michael Catanzaro.
662
663         * DumpRenderTree/CMakeLists.txt:
664         * MiniBrowser/win/CMakeLists.txt:
665         * TestWebKitAPI/CMakeLists.txt:
666         * TestWebKitAPI/PlatformWin.cmake:
667
668 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
669
670         Log stack-trace for run-webkit-tests when interrupted
671         https://bugs.webkit.org/show_bug.cgi?id=176393
672         <rdar://problem/34262310>
673
674         Reviewed by Lucas Forschler.
675
676         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
677         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
678         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
679         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
680         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
681         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
682         (main): Set handlers to log stack trace on interruption.
683
684 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
685
686         AX: Support API: accessibilityReplaceRange:withText
687         https://bugs.webkit.org/show_bug.cgi?id=196636
688
689         Unreviewed build fix for Windows port.
690
691         * DumpRenderTree/AccessibilityUIElement.cpp:
692         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
693
694 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
695
696         [ews-build] Scripts using Buildbot API have CORS error
697         https://bugs.webkit.org/show_bug.cgi?id=196709
698
699         Reviewed by Alexey Proskuryakov.
700
701         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
702
703 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
704
705         AX: Support API: accessibilityReplaceRange:withText
706         https://bugs.webkit.org/show_bug.cgi?id=196636
707
708         Reviewed by Daniel Bates.
709
710         * DumpRenderTree/AccessibilityUIElement.cpp:
711         (replaceTextInRangeCallback):
712         (AccessibilityUIElement::replaceTextInRange):
713         (AccessibilityUIElement::getJSClass):
714         * DumpRenderTree/AccessibilityUIElement.h:
715         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
716         (AccessibilityUIElement::replaceTextInRange):
717         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
718         (AccessibilityUIElement::replaceTextInRange):
719         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
720         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
721         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
722         (WTR::AccessibilityUIElement::replaceTextInRange):
723         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
724         (WTR::AccessibilityUIElement::replaceTextInRange):
725
726 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
727
728         [iOS] Do not allow starting selection drags when selection views are not visible
729         https://bugs.webkit.org/show_bug.cgi?id=196686
730         <rdar://problem/49399192>
731
732         Reviewed by Tim Horton.
733
734         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
735         also add some new API tests to cover scenarios where the web view is not first responder.
736
737         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
738         (TestWebKitAPI::TEST):
739         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
740
741         Add a switch to optionally make the web view first responder when starting the simulated drag.
742
743         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
744         (-[DragAndDropSimulator initWithWebView:]):
745         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
746
747 2019-04-08  Justin Fan  <justin_fan@apple.com>
748
749         [Web GPU] Fix Web GPU experimental feature on iOS
750         https://bugs.webkit.org/show_bug.cgi?id=196632
751
752         Reviewed by Myles C. Maxfield.
753
754         Properly make Web GPU available on iOS 11+.
755
756         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
757
758 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
759
760         [ews-build] Do not upload archive when Compile Fails
761         https://bugs.webkit.org/show_bug.cgi?id=196674
762
763         Reviewed by Alexey Proskuryakov.
764
765         * BuildSlaveSupport/ews-build/factories.py:
766         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
767         * BuildSlaveSupport/ews-build/steps.py:
768         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
769         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
770         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
771
772 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
773
774         Enable DFG on MIPS
775         https://bugs.webkit.org/show_bug.cgi?id=196689
776
777         Reviewed by Žan Doberšek.
778
779         Since the bytecode change, we enabled the baseline JIT on mips in
780         r240432, but DFG is still missing. With this change, all tests are
781         passing on a ci20 board.
782
783         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
784
785 2019-04-08  Philippe Normand  <pnormand@igalia.com>
786
787         [Flatpak] Second run update-webkitwpe-flatpak fails
788         https://bugs.webkit.org/show_bug.cgi?id=192702
789
790         Reviewed by Carlos Garcia Campos.
791
792         * flatpak/flatpakutils.py:
793         (FlatpakObject.flatpak): Fix typo.
794         (FlatpakPackage.install): When installing, also update to the configured remote commit.
795         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
796
797 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
798
799         [GTK][WPE] outlook.live.com displays old-fashioned UI
800         https://bugs.webkit.org/show_bug.cgi?id=196642
801
802         Reviewed by Carlos Garcia Campos.
803
804         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
805         (TestWebKitAPI::TEST): New Mac platform quirk test.
806
807 2019-04-07  Commit Queue  <commit-queue@webkit.org>
808
809         Unreviewed, rolling out r243956.
810         https://bugs.webkit.org/show_bug.cgi?id=196688
811
812         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
813         by aakashjain on #webkit).
814
815         Reverted changeset:
816
817         "Clicking "Go Back" from a safe browsing warning from an
818         iframe should navigate the WKWebView back to the previous
819         page"
820         https://bugs.webkit.org/show_bug.cgi?id=196665
821         https://trac.webkit.org/changeset/243956
822
823 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
824
825         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
826         https://bugs.webkit.org/show_bug.cgi?id=196669
827
828         Reviewed by Geoffrey Garen.
829
830         Added three new unit tests for WeakHashSet.
831
832         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
833         (WTF_WeakPtr.WeakHashSetConstObjects):
834         (WTF_WeakPtr.WeakHashSetComputesEmpty):
835         (WTF_WeakPtr.WeakHashSetComputeSize):
836
837 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
838
839         Hide next and previous form control buttons when WKWebView is editable
840         https://bugs.webkit.org/show_bug.cgi?id=196672
841         <rdar://problem/35625321>
842
843         Reviewed by Tim Horton.
844
845         Add a new API test.
846
847         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
848         (-[TestWKWebView lastTrailingBarButtonGroup]):
849         (TestWebKitAPI::TEST):
850         * TestWebKitAPI/ios/UIKitSPI.h:
851
852 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
853
854         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
855         https://bugs.webkit.org/show_bug.cgi?id=196077
856         <rdar://problem/49108202>
857
858         Reviewed by Chris Dumez.
859
860         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
861         on new web view.
862
863         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
864
865 2019-04-05  Saam Barati  <sbarati@apple.com>
866
867         Make compare-results understand MotionMark
868         https://bugs.webkit.org/show_bug.cgi?id=196666
869
870         Reviewed by Yusuke Suzuki.
871
872         * Scripts/compare-results:
873         (PLT5Results):
874         (detectMotionMark):
875         (detectMotionMark1_1):
876         (motionMarkResults):
877         (motionMark1_1Results):
878         (detectBenchmark):
879         (biggerIsBetter):
880         (main):
881
882 2019-04-05  Alex Christensen  <achristensen@webkit.org>
883
884         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
885         https://bugs.webkit.org/show_bug.cgi?id=196665
886         <rdar://45115669>
887
888         Reviewed by Geoff Garen.
889
890         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
891         (goBack):
892         (+[SimpleLookupContext sharedLookupContext]):
893         (-[SimpleLookupContext lookUpURL:completionHandler:]):
894         (TEST):
895         (+[Simple3LookupContext sharedLookupContext]): Deleted.
896         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
897
898 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
899
900         [ews-build] Add configuration and architecture for windows builders
901         https://bugs.webkit.org/show_bug.cgi?id=196660
902
903         Reviewed by Lucas Forschler.
904
905         * BuildSlaveSupport/ews-build/config.json:
906
907 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
908
909         webkitpy: Don't run subsequent rounds if interrupted
910         https://bugs.webkit.org/show_bug.cgi?id=196646
911
912         Reviewed by Aakash Jain.
913
914         * Scripts/webkitpy/layout_tests/controllers/manager.py:
915         (Manager.run): Bail out if interrupted.
916
917 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
918
919         Test sessionStorage in PSON private browsing mode
920         https://bugs.webkit.org/show_bug.cgi?id=196561
921
922         Reviewed by Alex Christensen.
923
924         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
925
926 2019-04-05  Commit Queue  <commit-queue@webkit.org>
927
928         Unreviewed, rolling out r243833.
929         https://bugs.webkit.org/show_bug.cgi?id=196645
930
931         This change breaks build of WPE and GTK ports (Requested by
932         annulen on #webkit).
933
934         Reverted changeset:
935
936         "[CMake][WTF] Mirror XCode header directories"
937         https://bugs.webkit.org/show_bug.cgi?id=191662
938         https://trac.webkit.org/changeset/243833
939
940 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
941
942         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
943         https://bugs.webkit.org/show_bug.cgi?id=196635
944
945         Reviewed by Antti Koivisto.
946         
947         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
948         for a test to enable async frame scrolling via:
949             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
950         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
951         
952         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
953
954         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
955         (WTR::InjectedBundle::beginTesting):
956         * WebKitTestRunner/TestController.cpp:
957         (WTR::TestController::resetPreferencesToConsistentValues):
958
959 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
960
961         Use a correct LC_RPATH when building with ASan
962         https://bugs.webkit.org/show_bug.cgi?id=196576
963
964         Reviewed by David Kilzer.
965
966         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
967         so that ../Frameworks is checked. This is simpler and more reliable than updating
968         each SPC service xcconfig.
969
970 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
971
972         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
973         https://bugs.webkit.org/show_bug.cgi?id=196629
974
975         Reviewed by Lucas Forschler.
976
977         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
978
979 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
980
981         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
982         https://bugs.webkit.org/show_bug.cgi?id=196618
983
984         Reviewed by Lucas Forschler.
985
986         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
987         (StatusBubble): Added QUEUE_TRIGGERS.
988         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
989         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
990         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
991         its parent(builder).
992
993 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
994
995         [ews-app] Status-bubble steps are sometimes displayed in reverse order
996         https://bugs.webkit.org/show_bug.cgi?id=196625
997
998         Reviewed by Lucas Forschler.
999
1000         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1001         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1002
1003 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1004
1005         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1006         https://bugs.webkit.org/show_bug.cgi?id=196630
1007
1008         Reviewed by Wenson Hsieh.
1009
1010         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1011
1012 2019-04-04  Youenn Fablet  <youenn@apple.com>
1013
1014         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1015         https://bugs.webkit.org/show_bug.cgi?id=196543
1016
1017         Reviewed by Alex Christensen.
1018
1019         * WebKitTestRunner/TestController.cpp:
1020         (WTR::TestController::generatePageConfiguration):
1021
1022 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1023
1024         [ews-app] Status bubble should not display skipped buildbot steps
1025         https://bugs.webkit.org/show_bug.cgi?id=196584
1026
1027         Reviewed by Lucas Forschler.
1028
1029         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1030
1031 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1032
1033         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1034         https://bugs.webkit.org/show_bug.cgi?id=196620
1035
1036         Reviewed by Lucas Forschler.
1037
1038         * BuildSlaveSupport/ews-app/ews/config.py:
1039
1040 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1041
1042         [Win] DumpRenderTreeWatchDog.py is not checked into source
1043         https://bugs.webkit.org/show_bug.cgi?id=196567
1044         <rdar://problem/49525901>
1045
1046         Reviewed by Lucas Forschler.
1047
1048         This script is used on Win EWS bots to terminate hanging DRT processes.
1049
1050         * EWSTools/dumprendertreewatchdog.py: Added.
1051
1052 2019-04-04  Chris Dumez  <cdumez@apple.com>
1053
1054         Unreviewed, roll out r243858 which made tests time out.
1055
1056         Disable new API tests on Windows instead.
1057
1058         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1059         (TestWebKitAPI::TEST):
1060
1061 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1062
1063         [ATK] Cleanup WebPageAccessibilityObjectAtk
1064         https://bugs.webkit.org/show_bug.cgi?id=196537
1065
1066         Reviewed by Michael Catanzaro.
1067
1068         Also consider files under atk directories as exceptions for GObject conventions.
1069
1070         * Scripts/webkitpy/style/checkers/cpp.py:
1071         (check_identifier_name_in_declaration):
1072
1073 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1074
1075         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1076         https://bugs.webkit.org/show_bug.cgi?id=196588
1077         <rdar://problem/49365787>
1078
1079         Unreviewed build fix for Windows port.
1080
1081         error C3861: 'kill': identifier not found
1082
1083         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1084         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1085
1086 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1087
1088         [ews-build] Cancel build and similar operations should have authentication
1089         https://bugs.webkit.org/show_bug.cgi?id=196520
1090
1091         Reviewed by Dewei Zhu.
1092
1093         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1094         environment variables.
1095
1096 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1097
1098         [ews-build] Do not trigger queues which are not in production yet
1099         https://bugs.webkit.org/show_bug.cgi?id=196581
1100
1101         Reviewed by Dewei Zhu.
1102
1103         * BuildSlaveSupport/ews-build/config.json:
1104
1105 2019-04-03  Chris Dumez  <cdumez@apple.com>
1106
1107         Unreviewed, fix typo in the name of API test added in r243848.
1108
1109         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1110         (TestWebKitAPI::TEST):
1111
1112 2019-04-03  Chris Dumez  <cdumez@apple.com>
1113
1114         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1115         https://bugs.webkit.org/show_bug.cgi?id=196588
1116         <rdar://problem/49365787>
1117
1118         Reviewed by Ryosuke Niwa.
1119
1120         Add API test coverage.
1121
1122         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1123         (TestWebKitAPI::nullJavaScriptCallback):
1124         (TestWebKitAPI::didCrashCheckFrames):
1125         (TestWebKitAPI::TEST):
1126
1127 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1128
1129         run-webkit-tests: Upload test results (new results database)
1130         https://bugs.webkit.org/show_bug.cgi?id=196577
1131         <rdar://problem/34841155>
1132
1133         Reviewed by Lucas Forschler.
1134
1135         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1136         (Manager.run): Upload results after each device shard, since the configuration will be
1137         different for each device.
1138         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1139         uploaded to a results database.
1140         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1141         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1142
1143 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1144
1145         -apple-trailing-word is needed for browser detection
1146         https://bugs.webkit.org/show_bug.cgi?id=196575
1147
1148         Unreviewed.
1149
1150         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1151
1152 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1153
1154         [CMake][WTF] Mirror XCode header directories
1155         https://bugs.webkit.org/show_bug.cgi?id=191662
1156
1157         Reviewed by Konstantin Tokarev.
1158
1159         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1160         builds.
1161
1162         * CMakeLists.txt:
1163         * DumpRenderTree/CMakeLists.txt:
1164         * DumpRenderTree/PlatformWin.cmake:
1165         * MiniBrowser/win/CMakeLists.txt:
1166         * TestWebKitAPI/CMakeLists.txt:
1167         * TestWebKitAPI/PlatformWin.cmake:
1168         * WebKitTestRunner/PlatformGTK.cmake:
1169         * WebKitTestRunner/PlatformWin.cmake:
1170
1171 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1172
1173         [ews-app] Status bubble should not display certain infrastructure status messages
1174         https://bugs.webkit.org/show_bug.cgi?id=196550
1175
1176         Reviewed by Lucas Forschler.
1177
1178         Do not display the steps which are un-needed for end-user. This information is still avaiable
1179         if the user click on the bubble and look at the Buildbot build.
1180         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1181         (StatusBubble._steps_messages):
1182         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1183
1184 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1185
1186         [ews-build] Use https for sending data to ews-app
1187         https://bugs.webkit.org/show_bug.cgi?id=196492
1188
1189         Reviewed by Lucas Forschler.
1190
1191         * BuildSlaveSupport/ews-build/events.py:
1192
1193 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1194
1195         Remove support for -apple-trailing-word
1196         https://bugs.webkit.org/show_bug.cgi?id=196525
1197
1198         Reviewed by Zalan Bujtas.
1199
1200         This CSS property is nonstandard and not used.
1201
1202         * Scripts/webkitperl/FeatureList.pm:
1203         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1204
1205 2019-04-03  Youenn Fablet  <youenn@apple.com>
1206
1207         Add a test for DOMCache on multiple browsing in case of private browsing
1208         https://bugs.webkit.org/show_bug.cgi?id=196524
1209
1210         Reviewed by Alex Christensen.
1211
1212         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1213         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1214
1215 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1216
1217         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1218         https://bugs.webkit.org/show_bug.cgi?id=196540
1219
1220         Reviewed by Aakash Jain.
1221
1222         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1223
1224 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1225
1226         Add plumbing for a compatibility mode preference in WebKit
1227         https://bugs.webkit.org/show_bug.cgi?id=196005
1228
1229         Reviewed by Tim Horton.
1230
1231         Add new API tests.
1232
1233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1234         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1235
1236 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1237
1238         [WPE][GTK] Update libsrtp dependency package for Debian
1239         https://bugs.webkit.org/show_bug.cgi?id=196528
1240
1241         Reviewed by Frédéric Wang.
1242
1243         * gtk/install-dependencies:
1244         * wpe/install-dependencies:
1245
1246 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1247
1248         [WK2] Add support for Window's beforeprint / afterprint events
1249         https://bugs.webkit.org/show_bug.cgi?id=196478
1250         <rdar://problem/49535124>
1251
1252         Unreviewed build fix for MSVC.
1253
1254         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1255
1256         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1257
1258         * WebKitTestRunner/TestController.cpp:
1259         (WTR::printFrame): Use int and float literals.
1260
1261 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1262
1263         [ews-build] Reassign bots to queues
1264
1265         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1266
1267 2019-04-02  Chris Dumez  <cdumez@apple.com>
1268
1269         [WK2] Add support for Window's beforeprint / afterprint events
1270         https://bugs.webkit.org/show_bug.cgi?id=196478
1271
1272         Reviewed by Alex Christensen.
1273
1274         Add minimal implementation for printFrame in WebKitTestRunner.
1275
1276         * WebKitTestRunner/TestController.cpp:
1277         (WTR::printFrame):
1278         (WTR::TestController::createOtherPage):
1279         (WTR::TestController::createWebViewWithOptions):
1280
1281 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1282
1283         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1284         https://bugs.webkit.org/show_bug.cgi?id=196491
1285
1286         Reviewed by Lucas Forschler.
1287
1288         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1289
1290 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1291
1292         [ews-build] Configure buildbot try credentials in environment variables
1293         https://bugs.webkit.org/show_bug.cgi?id=196501
1294
1295         Reviewed by Lucas Forschler.
1296
1297         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1298         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1299         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1300
1301 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1302
1303         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1304         https://bugs.webkit.org/show_bug.cgi?id=196496
1305         <rdar://problem/49521634>
1306
1307         Reviewed by Chris Dumez.
1308
1309         Add new API tests (see WebKit ChangeLog for more detail).
1310
1311         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1312         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1313         (TEST):
1314
1315 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1316
1317         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1318         <https://webkit.org/b/196499>
1319
1320         Reviewed by Alexey Proskuryakov.
1321
1322         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1323         ENABLE_ADDRESS_SANITIZER.
1324
1325 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1326
1327         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1328         https://bugs.webkit.org/show_bug.cgi?id=182757
1329
1330         Reviewed by Don Olmstead.
1331
1332         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1333         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1334
1335 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1336
1337         run-api-tests: Upload test results
1338         https://bugs.webkit.org/show_bug.cgi?id=196323
1339         <rdar://problem/49356714>
1340
1341         Reviewed by Lucas Forschler.
1342
1343         * Scripts/webkitpy/api_tests/manager.py:
1344         (Manager):
1345         (Manager.run): Upload results to a results database.
1346         * Scripts/webkitpy/api_tests/run_api_tests.py:
1347         (parse_args): Add upload arguments.
1348         * Scripts/webkitpy/port/base.py:
1349         (Port):
1350         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1351         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1352         with commits from any other associated repositories.
1353         * Scripts/webkitpy/port/device.py:
1354         (Device):
1355         (Device.build_version): Access build_versoin of underlying platform device.
1356         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1357         (IOSSimulatorTest):
1358         (IOSSimulatorTest.test_configuration_for_upload):
1359         * Scripts/webkitpy/port/device_port.py:
1360         (DevicePort):
1361         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1362         the same as the machine uploading results.
1363         * Scripts/webkitpy/port/mac.py:
1364         (MacPort):
1365         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1366         * Scripts/webkitpy/port/mac_unittest.py:
1367         (MacTest):
1368         (MacTest.test_configuration_for_upload):
1369         * Scripts/webkitpy/xcode/simulated_device.py:
1370         (SimulatedDeviceManager._create_device_with_runtime):
1371         (SimulatedDevice.__init__): Create simulated device with a build_version.
1372         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1373         (test_existing_simulator):
1374
1375 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1376
1377         Remove extra newline characters (Follow-up fix to r243707)
1378
1379         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1380
1381 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1382
1383         [ews-app] Use API_KEY to accept results data
1384         https://bugs.webkit.org/show_bug.cgi?id=196461
1385
1386         Reviewed by Dewei Zhu.
1387
1388         * BuildSlaveSupport/ews-app/ews/views/results.py:
1389         (Results.post): Validate EWS_API_KEY before accepting any data.
1390         * BuildSlaveSupport/ews-build/events.py:
1391         (Events.sendData): Send EWS_API_KEY if available along with event data.
1392
1393 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1394
1395         Unable to copy and paste a PDF from Notes into Mail compose body
1396         https://bugs.webkit.org/show_bug.cgi?id=196442
1397         <rdar://problem/48573098>
1398
1399         Reviewed by Tim Horton.
1400
1401         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1402         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1403         to be specified on the item providers.
1404
1405         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1406         (TestWebKitAPI::mapItemForTesting):
1407         (TestWebKitAPI::contactItemForTesting):
1408
1409 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1410
1411         Make UIWKDocumentContext rects per-character instead of per-word
1412         https://bugs.webkit.org/show_bug.cgi?id=196459
1413
1414         Reviewed by Wenson Hsieh.
1415
1416         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1417         (TEST):
1418         Adjust test results due to switching to per-character rects.
1419
1420 2019-04-01  Chris Dumez  <cdumez@apple.com>
1421
1422         UIProcess crash when a prewarmed process is terminated
1423         https://bugs.webkit.org/show_bug.cgi?id=196451
1424         <rdar://problem/49245471>
1425
1426         Reviewed by Geoffrey Garen.
1427
1428         Add API test coverage.
1429
1430         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1431         (TEST):
1432
1433 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1434
1435         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1436         https://bugs.webkit.org/show_bug.cgi?id=196449
1437
1438         Reviewed by Lucas Forschler.
1439
1440         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1441         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1442         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1443         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1444
1445 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1446
1447         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1448         https://bugs.webkit.org/show_bug.cgi?id=196444
1449
1450         Reviewed by Lucas Forschler.
1451
1452         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1453
1454 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1455
1456         Add SPI to canonicalize NSURLs with WTF::URL
1457         https://bugs.webkit.org/show_bug.cgi?id=196415
1458         <rdar://problem/44980271>
1459
1460         Reviewed by Darin Adler.
1461
1462         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1463         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1464         (TestWebKitAPI::TEST):
1465
1466 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1467
1468         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1469         https://bugs.webkit.org/show_bug.cgi?id=196441
1470
1471         Reviewed by Carlos Garcia Campos.
1472
1473         Don't cache the wpe_view_backend object that might not exist yet at the
1474         time of EventSenderProxy constructor invocation, but instead retrieve
1475         that object whenever it's required for event dispatching. This should
1476         avoid crashes in this constructor now that it's invoked before any
1477         PlatformWindow has been set up (as changed in r243496).
1478
1479         * WebKitTestRunner/EventSenderProxy.h:
1480         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1481         (WTR::viewBackend):
1482         (WTR::EventSenderProxy::EventSenderProxy):
1483         (WTR::EventSenderProxy::mouseDown):
1484         (WTR::EventSenderProxy::mouseUp):
1485         (WTR::EventSenderProxy::mouseMoveTo):
1486         (WTR::EventSenderProxy::mouseScrollBy):
1487         (WTR::EventSenderProxy::keyDown):
1488         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1489
1490 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1491
1492         [Win][WebKit] MiniBrowser should support high DPI display
1493         https://bugs.webkit.org/show_bug.cgi?id=196391
1494
1495         Reviewed by Alex Christensen.
1496
1497         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1498         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1499         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1500         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1501
1502 2019-03-31  Sam Weinig  <weinig@apple.com>
1503
1504         Remove more i386 specific configurations
1505         https://bugs.webkit.org/show_bug.cgi?id=196430
1506
1507         Reviewed by Alexey Proskuryakov.
1508
1509         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1510         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1511
1512 2019-03-31  Andy Estes  <aestes@apple.com>
1513
1514         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1515         https://bugs.webkit.org/show_bug.cgi?id=196433
1516         <rdar://problem/49293305>
1517
1518         Reviewed by Tim Horton.
1519
1520         Enhanced API test coverage to include all navigation response policy decisions in both
1521         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1522
1523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1524         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1525         (TestWebKitAPI::TEST):
1526         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1527         (readFile):
1528         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1529         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1530         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1531         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1532         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1533         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1534         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1535         (-[QuickLookDelegate _downloadDidStart:]):
1536         (-[QuickLookDelegate _download:didReceiveResponse:]):
1537         (-[QuickLookDelegate _download:didReceiveData:]):
1538         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1539         (-[QuickLookDelegate _downloadDidFinish:]):
1540         (-[QuickLookDelegate _download:didFailWithError:]):
1541         (-[QuickLookDelegate _downloadDidCancel:]):
1542         (-[QuickLookDelegate verifyDownload]):
1543         (runTest):
1544         (runTestDecideBeforeLoading):
1545         (runTestDecideAfterLoading):
1546         (TEST):
1547         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1548         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1549         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1550         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1551         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1552         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1553         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1554         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1555         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1556         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1557         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1558         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1559         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1560         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1561
1562 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1563
1564         [CMake] add testdfg as target with build-jsc
1565         https://bugs.webkit.org/show_bug.cgi?id=196393
1566
1567         Reviewed by Saam Barati.
1568
1569         Added testdfg as one of the targets to build when
1570         using CMake.
1571
1572         * Scripts/build-jsc:
1573
1574 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1575
1576         Delete WebMetal implementation in favor of WebGPU
1577         https://bugs.webkit.org/show_bug.cgi?id=195418
1578
1579         Reviewed by Dean Jackson.
1580
1581         * DumpRenderTree/mac/DumpRenderTree.mm:
1582         (enableExperimentalFeatures):
1583         (resetWebPreferencesToConsistentValues):
1584         * Scripts/webkitperl/FeatureList.pm:
1585         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1587         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1588         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1589         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1590         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1591         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1592         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1593         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1594         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1595         (WTR::InjectedBundle::beginTesting):
1596         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1597         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1598         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1599
1600 2019-03-29  Chris Dumez  <cdumez@apple.com>
1601
1602         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1603         https://bugs.webkit.org/show_bug.cgi?id=196405
1604         <rdar://problem/49428130>
1605
1606         Reviewed by Wenson Hsieh.
1607
1608         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1609         the popover presentation methods to be no-ops. Use this in the new test added in
1610         r243523 so that we do not swizzle those methods for all tests. This is needed because
1611         those WatchOS tests rely on the popover getting presented and interactive.
1612
1613         * WebKitTestRunner/TestController.cpp:
1614         (WTR::updateTestOptionsFromTestHeader):
1615         * WebKitTestRunner/TestController.h:
1616         * WebKitTestRunner/TestOptions.h:
1617         (WTR::TestOptions::hasSameInitializationOptions const):
1618         * WebKitTestRunner/ios/TestControllerIOS.mm:
1619         (WTR::TestController::platformInitialize):
1620         (WTR::TestController::platformResetStateToConsistentValues):
1621
1622 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1623
1624         [Curl] Add Server Trust Evaluation Support.
1625         https://bugs.webkit.org/show_bug.cgi?id=191646
1626
1627         Reviewed by Fujii Hironori.
1628
1629         Implemented MiniBrowser UI for asking if user trusts the server.
1630
1631         * MiniBrowser/win/Common.cpp:
1632         (askServerTrustEvaluation):
1633         (replaceString):
1634         * MiniBrowser/win/Common.h:
1635         * MiniBrowser/win/MiniBrowserLib.rc:
1636         * MiniBrowser/win/MiniBrowserLibResource.h:
1637         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1638         (createPEMString):
1639         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1640         (WebKitBrowserWindow::canTrustServerCertificate):
1641         * MiniBrowser/win/WebKitBrowserWindow.h:
1642
1643 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1644
1645         Implement ResizeObserver.
1646         https://bugs.webkit.org/show_bug.cgi?id=157743
1647
1648         Reviewed by Simon Fraser.
1649
1650         Support resizeObserverEnabled webPreferences.
1651
1652         * DumpRenderTree/TestOptions.cpp:
1653         (TestOptions::TestOptions):
1654         * DumpRenderTree/TestOptions.h:
1655         * DumpRenderTree/mac/DumpRenderTree.mm:
1656         (setWebPreferencesForTestOptions):
1657         * DumpRenderTree/win/DumpRenderTree.cpp:
1658         (enableExperimentalFeatures):
1659         * Scripts/webkitperl/FeatureList.pm:
1660         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1661
1662 2019-03-28  John Wilander  <wilander@apple.com>
1663
1664         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1665         https://bugs.webkit.org/show_bug.cgi?id=196281
1666         <rdar://problem/48938748>
1667
1668         Reviewed by Alex Christensen.
1669
1670         This patch adds the function isStatisticsHasLocalStorage() to the
1671         TestRunner. With it, the page can query the WebsiteDataStore in the
1672         UI process to make sure that it sees LocalStorage.
1673
1674         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1675         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1676         (WTR::TestRunner::isStatisticsHasLocalStorage):
1677         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1678         * WebKitTestRunner/TestController.cpp:
1679         (WTR::TestController::isStatisticsHasLocalStorage):
1680         * WebKitTestRunner/TestController.h:
1681         * WebKitTestRunner/TestInvocation.cpp:
1682         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1683
1684 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1685
1686         API::Data::createWithoutCopying should do a null check before calling CFRelease
1687         https://bugs.webkit.org/show_bug.cgi?id=196276
1688         <rdar://problem/48059859>
1689
1690         Reviewed by Alex Christensen.
1691
1692         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1693
1694         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1695         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1696         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1697         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1698         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1699         (TestWebKitAPI::TEST):
1700
1701 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1702
1703         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1704         https://bugs.webkit.org/show_bug.cgi?id=186276
1705
1706         Reviewed by Carlos Garcia Campos.
1707
1708         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1709         (webViewLoadChanged):
1710         (testWebResourceGetDataError):
1711         (testWebResourceGetDataEmpty):
1712         (beforeAll):
1713         (webViewloadChanged): Deleted.
1714
1715 2019-03-27  Andy Estes  <aestes@apple.com>
1716
1717         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1718         https://bugs.webkit.org/show_bug.cgi?id=196317
1719
1720         Reviewed by Dan Bernstein.
1721
1722         package-root copies built products into a staging directory using ditto(1), which does not
1723         follow symbolic links as it traverses a directory. Now that the files in
1724         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1725         itself, these become broken links when ditto'd into the staging directory.
1726
1727         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1728
1729         * Scripts/package-root:
1730
1731 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1732
1733         [ews-app] Update display text of Submit for ews analysis
1734         https://bugs.webkit.org/show_bug.cgi?id=196309
1735
1736         Reviewed by Dewei Zhu.
1737
1738         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1739
1740 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1741
1742         run-webkit-tests should check for leaks in WebKit processes
1743         <https://webkit.org/b/193772>
1744         <rdar://problem/46526680>
1745
1746         Reviewed by Ryosuke Niwa.
1747
1748         This works by doing the following:
1749         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1750           The list of child processes are returned one per line:
1751           process.name: pid
1752         - Run the "#LIST CHILD PROCESSES" command just before the
1753           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1754           processes on the ServerProcess object.
1755         - When the `--leaks` switch is handled, run check_for_leaks() on
1756           each child process after the main test harness.
1757
1758         * DumpRenderTree/mac/DumpRenderTree.mm:
1759         (handleControlCommand):
1760         - Use strncmp() instead of strcmp().
1761         - Add support for handling "#LIST CHILD PROCESSES" command.
1762
1763         * Scripts/webkitpy/port/base.py:
1764         (Port.check_for_leaks):
1765         * Scripts/webkitpy/port/darwin.py:
1766         (DarwinPort.check_for_leaks):
1767         - Rename redundant 'process_pid' argument to 'process_id'.
1768
1769         * Scripts/webkitpy/port/driver.py:
1770         (Driver.do_post_tests_work):
1771         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1772           longer the only command this sends to WebKitTestRunner.
1773         - If the `--leaks` switch is present, send the
1774           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1775           result using Port.set_webkit_processes().
1776         (Driver._parse_child_processes_output):
1777         - Add helper method to parse list of child process names and
1778           process IDs returned from WebKitTestRunner.
1779
1780         * Scripts/webkitpy/port/ios_device.py:
1781         (IOSDevicePort.check_for_leaks):
1782         - Rename redundant 'process_pid' argument to 'process_id'.
1783
1784         * Scripts/webkitpy/port/leakdetector.py:
1785         (LeakDetector._parse_leaks_output):
1786         - Return early if there is no leaks_output.
1787         (LeakDetector.check_for_leaks):
1788         - Rename redundant 'process_pid' argument to 'process_id'.
1789
1790         * Scripts/webkitpy/port/server_process.py:
1791         (ServerProcess.__init__):
1792         (ServerProcess.child_processes):
1793         (ServerProcess.set_child_processes):
1794         - Add instance variable to Port to store list of child process
1795           names and process IDs returned from WebKitTestRunner.
1796         (ServerProcess._start):
1797         - Clear self._child_processes.
1798         (ServerProcess.stop):
1799         - If self._child_processes is set, call
1800           self._port.check_for_leaks() for each child process.
1801
1802         * Scripts/webkitpy/port/server_process_unittest.py:
1803         (TrivialMockPort.check_for_leaks):
1804         - Rename redundant 'process_pid' argument to 'process_id'.
1805
1806         * Scripts/webkitpy/port/simulator_process.py:
1807         (SimulatorProcess.stop):
1808         - If self._child_processes is set, call
1809           self._port.check_for_leaks() for each child process.
1810
1811         * Scripts/webkitpy/port/watch_device.py:
1812         (WatchDevicePort.check_for_leaks):
1813         - Rename redundant 'process_pid' argument to 'process_id'.
1814
1815         * WebKitTestRunner/TestController.cpp:
1816         (WTR::TestController::dumpResponse):
1817         - Extract method from findAndDumpWorldLeaks() so that it may be
1818           reused by findAndDumpWebKitProcessIdentifiers().
1819         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1820         - Add method to output process name and process ID of both the
1821           WebContent and Networking processes.
1822         (WTR::TestController::findAndDumpWorldLeaks):
1823         - Fix missing newline in output when there were no abandoned
1824           documents.
1825         - Call dumpResponse() for extracted code.
1826         (WTR::TestController::handleControlCommand):
1827         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1828         - Use strncmp() instead of strcmp().
1829         - Call findAndDumpWebKitProcessIdentifiers() when
1830           "#LIST CHILD PROCESSES" command is sent.
1831         * WebKitTestRunner/TestController.h:
1832         (WTR::TestController::dumpResponse):
1833         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1834         - Declare methods.
1835
1836 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1837
1838         Unreviewed. Add GLib API test cases after r243434.
1839
1840         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1841         (testWebViewActiveURI):
1842         (serverCallback):
1843         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1844         (sendRequestCallback):
1845
1846 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1847
1848         Geolocation request not complete when watch request was started in a different web process
1849         https://bugs.webkit.org/show_bug.cgi?id=195996
1850
1851         Reviewed by Alex Christensen.
1852
1853         Add a test case.
1854
1855         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1856         (TestWebKitAPI::runJavaScriptAlert):
1857         (TestWebKitAPI::TEST):
1858
1859 2019-03-26  Keith Rollin  <krollin@apple.com>
1860
1861         Update the way generate-xcfilelists returns strings from functions
1862         https://bugs.webkit.org/show_bug.cgi?id=195975
1863         <rdar://problem/49040807>
1864
1865         Reviewed by Dean Jackson.
1866
1867         There are places where generate-xcfilelists executes assignments with
1868         statements like:
1869
1870             FOO=$(some_function)
1871
1872         where "some_function" return a string by echoing it. E.g.
1873
1874             some_function()
1875             {
1876                 echo "Hello, World"
1877             }
1878
1879         This is a common idiom, but it has a problem if "some_function" needs
1880         to call "exit" in an attempt to halt the entire script right then and
1881         there. Since "some_function" is called inside of $(), it's being
1882         executed in a sub-shell. Calling exit in that sub-shell simply exits
1883         that shell; it doesn't not exit the outer shell in which the main part
1884         of the script is still running. As such, the main script keeps
1885         executing when the intent was for the script to halt.
1886
1887         The solution to this is to use a different idiom for returning
1888         strings. The one we now is to pass in the name of the variable to
1889         receive the string result:
1890
1891             some_function()
1892             {
1893                 variable_name=$1
1894                 eval $variable_name ="Hello, World"
1895             }
1896
1897         The call site now looks like
1898
1899             some_function FOO
1900
1901         Because there's no invocation of a sub-shell, some_function can now
1902         call "exit" if it wants to, and the entire script will exit at that
1903         point.
1904
1905         * Scripts/generate-xcfilelists:
1906
1907 2019-03-26  Chris Dumez  <cdumez@apple.com>
1908
1909         Add basic layout test coverage for File Picker on iOS
1910         https://bugs.webkit.org/show_bug.cgi?id=196265
1911
1912         Reviewed by Wenson Hsieh.
1913
1914         Add layout test infrastructure to test the file picker on iOS.
1915
1916         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1917         (WTR::UIScriptController::dismissFilePicker):
1918         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1919         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1920         (WTR::UIScriptController::dismissFilePicker):
1921         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1922         * WebKitTestRunner/TestController.cpp:
1923         (WTR::TestController::createWebViewWithOptions):
1924         (WTR::updateTestOptionsFromTestHeader):
1925         * WebKitTestRunner/TestOptions.h:
1926         (WTR::TestOptions::hasSameInitializationOptions const):
1927         * WebKitTestRunner/ios/TestControllerIOS.mm:
1928         (overridePresentViewController):
1929         (WTR::TestController::platformInitialize):
1930         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1931         (WTR::UIScriptController::dismissFilePicker):
1932
1933 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1934
1935         Implement async paste method on UIWKInteractionViewProtocol
1936         https://bugs.webkit.org/show_bug.cgi?id=196267
1937         <rdar://problem/49236346>
1938
1939         Reviewed by Tim Horton.
1940
1941         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1942         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1943         are now a part of all iOS 12 internal SDKs.
1944
1945         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1946
1947         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1948         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1949
1950         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1951         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1952         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1953         * TestWebKitAPI/ios/UIKitSPI.h:
1954
1955 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1956
1957         [ews-build] Use PostgreSQL for ews.webkit.org database
1958         https://bugs.webkit.org/show_bug.cgi?id=196270
1959
1960         Reviewed by Lucas Forschler.
1961
1962         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1963
1964 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1965
1966         [ews] Reset simctl states on reboot
1967         https://bugs.webkit.org/show_bug.cgi?id=196260
1968
1969         Rubber-stamped by Aakash Jain.
1970
1971         * EWSTools/start-queue-mac.sh:
1972
1973 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1974
1975         [ews-build] Use PostgreSQL for ews-build database
1976         https://bugs.webkit.org/show_bug.cgi?id=196229
1977
1978         Reviewed by Lucas Forschler.
1979
1980         * BuildSlaveSupport/ews-build/master.cfg:
1981
1982 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1983
1984         [ews-build] Get master_hostname dynamically in master.cfg
1985         https://bugs.webkit.org/show_bug.cgi?id=196255
1986
1987         Reviewed by Lucas Forschler.
1988
1989         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1990         send events data in test mode.
1991
1992 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1993
1994         [ews-app] Set db_constraint to False for Foreign Keys
1995         https://bugs.webkit.org/show_bug.cgi?id=196252
1996
1997         Reviewed by Lucas Forschler.
1998
1999         * BuildSlaveSupport/ews-app/ews/models/build.py:
2000         * BuildSlaveSupport/ews-app/ews/models/step.py:
2001
2002 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2003
2004         [ews-build] is_test_mode_enabled should default to True
2005         https://bugs.webkit.org/show_bug.cgi?id=196248
2006
2007         Reviewed by Lucas Forschler.
2008
2009         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2010
2011 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2012
2013         [ews-app] Add webkitperl to ENABLED_QUEUES
2014         https://bugs.webkit.org/show_bug.cgi?id=196253
2015
2016         Reviewed by Lucas Forschler.
2017
2018         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2019
2020 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2021
2022         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2023         https://bugs.webkit.org/show_bug.cgi?id=196211
2024         rdar://problem/49110552
2025
2026         Reviewed by Tim Horton.
2027
2028         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2029         Make sure that EventSenderProxy always exists when running tests. We used to create
2030         it when resetting before the first test, which is a bit too late.
2031
2032         * WebKitTestRunner/TestController.h:
2033         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2034         (WTR::TestController::platformCreateWebView):
2035         (WTR::TestController::platformCreateOtherPage):
2036         (WTR::TestController::finishCreatingPlatformWebView):
2037         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2038         (WTR::PlatformWebView::PlatformWebView):
2039         Moved some code that made NSWindow use NSEvent during web view creation. We may
2040         need to move more if some other case us found, but this is enough for now.
2041
2042 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2043
2044         Unreviewed. Fix typo in GLib geolocation API after r243285.
2045
2046         gelocation -> geolocation.
2047
2048         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2049         (testGeolocationManagerWatchPosition):
2050
2051 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2052
2053         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2054         https://bugs.webkit.org/show_bug.cgi?id=196213
2055
2056         Reviewed by Geoff Garen.
2057
2058         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2059         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2060         (credentialWithIdentityAndKeychainPath):
2061         (-[ChallengeDelegate webView:didFinishNavigation:]):
2062         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2063         (TestWebKitAPI::TEST):
2064
2065 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2066
2067         Expected shouldn't assume its contained types are copyable
2068         https://bugs.webkit.org/show_bug.cgi?id=195986
2069
2070         Reviewed by JF Bastien.
2071
2072         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2073         (TestWebKitAPI::NonCopyable::operator== const):
2074         (TestWebKitAPI::NonCopyable::operator!= const):
2075         (TestWebKitAPI::TEST):
2076
2077 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2078
2079         Remove some now-unnecessary dynamic class lookup
2080         https://bugs.webkit.org/show_bug.cgi?id=196237
2081
2082         Reviewed by Simon Fraser.
2083
2084         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2085         (makeRequest):
2086         (TEST):
2087
2088 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2089
2090         Unreviewed, rolling out r243450.
2091
2092         AppleWin and WinCairo port builds get broken.
2093
2094         Reverted changeset:
2095
2096         "Add test for fix of #196095"
2097         https://bugs.webkit.org/show_bug.cgi?id=196097
2098         https://trac.webkit.org/changeset/243450
2099
2100 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2101
2102         Unreviewed, rolling out r243465.
2103         https://bugs.webkit.org/show_bug.cgi?id=196226
2104
2105         the test doesn't build (Requested by thorton on #webkit).
2106
2107         Reverted changeset:
2108
2109         "Do not terminate the NetworkProcess if a third party
2110         application sends a NSCredential with a SecIdentityRef"
2111         https://bugs.webkit.org/show_bug.cgi?id=196213
2112         https://trac.webkit.org/changeset/243465
2113
2114 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2115
2116         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2117         https://bugs.webkit.org/show_bug.cgi?id=196213
2118
2119         Reviewed by Geoff Garen.
2120
2121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2122         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2123         (credentialWithIdentityAndKeychainPath):
2124         (-[ChallengeDelegate webView:didFinishNavigation:]):
2125         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2126         (TestWebKitAPI::TEST):
2127
2128 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2129
2130         [ews-build] Gracefully handle missing patch_id in events
2131         https://bugs.webkit.org/show_bug.cgi?id=196216
2132
2133         Reviewed by Lucas Forschler.
2134
2135         * BuildSlaveSupport/ews-build/events.py:
2136
2137 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2138
2139         [ews-build] use lz4 compression for improving buildbot performance
2140         https://bugs.webkit.org/show_bug.cgi?id=196155
2141
2142         Reviewed by Lucas Forschler.
2143
2144         * BuildSlaveSupport/ews-build/master.cfg:
2145
2146 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2147
2148         Pull some API testing helper methods out of TestWKWebView
2149         https://bugs.webkit.org/show_bug.cgi?id=196212
2150
2151         Reviewed by Tim Horton.
2152
2153         Refactor some more API testing utility methods, so that they can be used in
2154         tests that do not use TestWKWebView.
2155
2156         * TestWebKitAPI/cocoa/TestWKWebView.h:
2157         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2158         (-[WKWebView loadTestPageNamed:]):
2159         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2160         (-[WKWebView synchronouslyLoadHTMLString:]):
2161         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2162         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2163         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2164         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2165         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2166
2167 2019-03-25  Jer Noble  <jer.noble@apple.com>
2168
2169         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2170         https://bugs.webkit.org/show_bug.cgi?id=196097
2171
2172         Reviewed by Eric Carlson.
2173
2174         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2175
2176         * DumpRenderTree/mac/DumpRenderTree.mm:
2177         (resetWebPreferencesToConsistentValues):
2178         * WebKitTestRunner/TestController.cpp:
2179         (WTR::TestController::resetPreferencesToConsistentValues):
2180
2181 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2182
2183         Pull IPadUserInterfaceSwizzler out into a separate header file
2184         https://bugs.webkit.org/show_bug.cgi?id=196193
2185
2186         Reviewed by Anders Carlsson.
2187
2188         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2189         be used in other API tests.
2190
2191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2192         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2193         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2194         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2195         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2196         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2197         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2198
2199 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2200
2201         Remove NavigatorContentUtils in WebCore/Modules
2202         https://bugs.webkit.org/show_bug.cgi?id=196070
2203
2204         Reviewed by Alex Christensen.
2205
2206         NavigatorContentUtils was to support the custom scheme spec [1].
2207         However, in WebKit side, no port has supported the feature in
2208         WebKit layer after EFL port was removed. So there has been the
2209         only IDL implementation of the NavigatorContentUtils in WebCore.
2210         So we don't need to keep the implementation in WebCore anymore.
2211
2212         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2213
2214         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2215
2216 2019-03-24  Andy Estes  <aestes@apple.com>
2217
2218         [watchOS] Remove unused Proximity Networking code
2219         https://bugs.webkit.org/show_bug.cgi?id=196188
2220
2221         Reviewed by Tim Horton.
2222
2223         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2224         (TEST):
2225
2226 2019-03-23  Keith Miller  <keith_miller@apple.com>
2227
2228         Refactor clz/ctz and fix getLSBSet.
2229         https://bugs.webkit.org/show_bug.cgi?id=196162
2230
2231         Reviewed by Saam Barati.
2232
2233         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2234
2235         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2236         (TestWebKitAPI::TEST):
2237
2238 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2239
2240         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2241         https://bugs.webkit.org/show_bug.cgi?id=196143
2242
2243         Reviewed by Michael Catanzaro.
2244
2245         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2246         directories.
2247
2248         * Scripts/webkitpy/style/checkers/cpp.py:
2249         (check_identifier_name_in_declaration):
2250         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2251         (WebKitStyleTest.test_names):
2252
2253 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2254
2255         [Flatpak] Manifest expanding fails for qt WPE extension
2256         https://bugs.webkit.org/show_bug.cgi?id=196148
2257
2258         Reviewed by Alex Christensen.
2259
2260         * flatpak/flatpakutils.py:
2261         (expand_submodules_recurse): The last recurse manifest expand
2262         iteration might lead to a single module so take it into account
2263         and don't try to recurse further.
2264
2265 2019-03-22  Chris Dumez  <cdumez@apple.com>
2266
2267         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2268         https://bugs.webkit.org/show_bug.cgi?id=195348
2269         <rdar://problem/48622090>
2270
2271         Reviewed by Alex Christensen.
2272
2273         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2274         to NO when test.options().shouldIgnoreMetaViewport is false.
2275
2276         * WebKitTestRunner/ios/TestControllerIOS.mm:
2277         (WTR::TestController::platformConfigureViewForTest):
2278
2279 2019-03-22  Chris Dumez  <cdumez@apple.com>
2280
2281         Prewarmed processes should be usable with any website data store
2282         https://bugs.webkit.org/show_bug.cgi?id=196104
2283
2284         Reviewed by Alex Christensen.
2285
2286         Add API test coverage.
2287
2288         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2289         (runInitialWarmedProcessUsedTest):
2290         (TEST):
2291
2292 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2293
2294         Back out local changes to Alex's Subversion working directory
2295
2296         They were accidentally committed.
2297
2298         * Scripts/webkitpy/common/system/abstractexecutive.py:
2299         (AbstractExecutive.wait_newest):
2300         * Scripts/webkitpy/common/system/executive.py:
2301         (Executive.running_pids):
2302         * Scripts/webkitpy/common/system/executive_mock.py:
2303         (MockExecutive.running_pids):
2304         * Scripts/webkitpy/common/system/executive_unittest.py:
2305         (ExecutiveTest.serial_test_running_pids):
2306         * Scripts/webkitpy/port/darwin.py:
2307         (DarwinPort.check_for_leaks):
2308         * Scripts/webkitpy/port/leakdetector.py:
2309         (LeakDetector.check_for_leaks):
2310         - This was the hack attached to Bug 193772.
2311
2312         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2313         (+[WebKitTestRunnerEvent mouseLocation]):
2314         - This works around a crash on an internal build.
2315
2316 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2317
2318         Fix the build after r243354
2319         https://bugs.webkit.org/show_bug.cgi?id=196138
2320         <rdar://problem/49145951>
2321
2322         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2323         (TEST):
2324         * TestWebKitAPI/ios/UIKitSPI.h:
2325
2326 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2327
2328         Adopt UIWKDocumentContext
2329         https://bugs.webkit.org/show_bug.cgi?id=196040
2330         <rdar://problem/48642440>
2331
2332         Reviewed by Ryosuke Niwa.
2333
2334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2335         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2336         (makeRequest):
2337         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2338         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2339         (applyStyle):
2340         (TEST):
2341         Add tests for UIWKDocumentContext.
2342
2343         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2344         (TEST):
2345         (recursiveFindWKContentView): Deleted.
2346         * TestWebKitAPI/cocoa/TestWKWebView.h:
2347         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2348         (recursiveFindWKContentView):
2349         (-[TestWKWebView wkContentView]):
2350         * TestWebKitAPI/ios/UIKitSPI.h:
2351         Share the WKContentView finding code between tests.
2352
2353 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2354
2355         [iOS WK2] Turn on async overflow scrolling by default
2356         https://bugs.webkit.org/show_bug.cgi?id=196011
2357         rdar://problem/48453859
2358
2359         Reviewed by Antti Koivisto.
2360         
2361         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2362         since so many basic layout tests have different results when compositing is triggered for
2363         overflow.
2364         
2365         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2366
2367         * WebKitTestRunner/TestController.cpp:
2368         (WTR::TestController::resetPreferencesToConsistentValues):
2369
2370 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2371
2372         [ews-build] Retry API test in case of failures
2373         https://bugs.webkit.org/show_bug.cgi?id=196004
2374
2375         Reviewed by Lucas Forschler.
2376
2377         * BuildSlaveSupport/ews-build/steps.py:
2378         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2379         (CompileWebKitToT.doStepIf): Ditto.
2380         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2381         (ReRunAPITests): Re-run API tests.
2382         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2383         (RunAPITestsWithoutPatch): Run API tests without patch.
2384         (RunAPITestsWithoutPatch.doStepIf):
2385         (RunAPITestsWithoutPatch.hideStepIf):
2386         (RunAPITestsWithoutPatch.evaluateCommand):
2387         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2388         (AnalyzeAPITestsResults.start):
2389         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2390         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2391         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2392         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2393
2394 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2395
2396         [ews-build] Update queues configurations
2397         https://bugs.webkit.org/show_bug.cgi?id=196074
2398
2399         Reviewed by Dewei Zhu.
2400
2401         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2402         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2403
2404 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2405
2406         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2407         https://bugs.webkit.org/show_bug.cgi?id=195680
2408         <rdar://problem/48903534>
2409
2410         Unreviewed infrastructure fix.
2411
2412         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2413         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2414
2415 2019-03-21  Andy Estes  <aestes@apple.com>
2416
2417         [iOS] Apple Pay should be available in documents with no user agent scripts
2418         https://bugs.webkit.org/show_bug.cgi?id=196061
2419         <rdar://problem/48649391>
2420
2421         Reviewed by Brady Eidson.
2422
2423         Added API tests and related infrastructure.
2424
2425         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2426         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2427         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2428         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2429         (TestWebKitAPI::TEST):
2430         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2431         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2432         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2433         * TestWebKitAPI/cocoa/TestProtocol.mm:
2434         (-[TestProtocol startLoading]):
2435         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2436         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2437         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2438         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2439
2440 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2441
2442         REGRESSSION (r243297): webkitpy tests broken
2443         https://bugs.webkit.org/show_bug.cgi?id=196108
2444
2445         Reviewed by Aakash Jain.
2446
2447         r243297 updated contributors.json, which broke a few unit tests.
2448
2449         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2450         (IRCCommandTest.test_whois):
2451         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2452
2453 2019-03-21  Chris Dumez  <cdumez@apple.com>
2454
2455         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2456         https://bugs.webkit.org/show_bug.cgi?id=196041
2457         <rdar://problem/49083230>
2458
2459         Reviewed by Alex Christensen.
2460
2461         Add API test coverage.
2462
2463         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2464         (TEST):
2465
2466 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2467
2468         Add SPI to inform applications of WKContentRuleList actions
2469         https://bugs.webkit.org/show_bug.cgi?id=195965
2470         <rdar://problem/42664365>
2471
2472         Reviewed by Geoff Garen.
2473
2474         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2475         (TestWebKitAPI::allActionsForResourceLoad):
2476         (TestWebKitAPI::testRequest):
2477         (TestWebKitAPI::TEST_F):
2478         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2479         (Notification::description):
2480         (Notification::operator== const):
2481         (toVector):
2482         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2483         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2484         (makeContentRuleList):
2485         (TEST):
2486         (makeWarnContentRuleList): Deleted.
2487
2488 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2489
2490         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2491         https://bugs.webkit.org/show_bug.cgi?id=196088
2492
2493         Reviewed by Brian Burg.
2494
2495         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2496         Support checks when only one platform is specified. Also deprecate macosx() and
2497         force the use of macos() instead.
2498
2499         * Scripts/webkitpy/style/checkers/cpp.py:
2500         (check_min_versions_of_wk_api_available):
2501         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2502         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2503
2504 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2505
2506         Update status inactive committers' status to 'contributor'.
2507
2508         * Scripts/webkitpy/common/config/contributors.json:
2509
2510 2019-03-21  Xan Lopez  <xan@igalia.com>
2511
2512         [JSC][x86] Drop support for x87 floating point
2513         https://bugs.webkit.org/show_bug.cgi?id=194853
2514
2515         Reviewed by Don Olmstead.
2516
2517         Force SSE2 on x86/32bit builds.
2518
2519         * Scripts/webkitdirs.pm:
2520         (generateBuildSystemFromCMakeProject):
2521
2522 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2523
2524         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2525         https://bugs.webkit.org/show_bug.cgi?id=196073
2526
2527         Reviewed by Michael Catanzaro.
2528
2529         Add test cases to check functions and constructors with no arguments but receiving user data.
2530
2531         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2532         (checkUserData):
2533         (testJSCFunction):
2534         (fooCreateWithUserData):
2535         (testJSCClass):
2536
2537 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2538
2539         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2540
2541         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2542
2543         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2544
2545 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2546
2547         [GTK][WPE] Add API to provide geolocation information
2548         https://bugs.webkit.org/show_bug.cgi?id=195940
2549
2550         Reviewed by Michael Catanzaro.
2551
2552         Add a new test to check the new API.
2553
2554         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2555         (testGeolocationManagerCurrentPosition):
2556         (testGeolocationManagerWatchPosition):
2557         (beforeAll):
2558         (afterAll):
2559         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2560         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2561         (beforeAll): Ditto.
2562         * TestWebKitAPI/glib/CMakeLists.txt:
2563
2564 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2565
2566         [GLib] Returning G_TYPE_OBJECT from a method does not work
2567         https://bugs.webkit.org/show_bug.cgi?id=195574
2568
2569         Reviewed by Michael Catanzaro.
2570
2571         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2572
2573         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2574         (getGFile):
2575         (getParent):
2576         (createGString):
2577         (getGString):
2578         (getGStringCopyWillRaise):
2579         (getGStringCopy):
2580         (getGStringStr):
2581         (getGStringLen):
2582         (freeGString):
2583         (testJSCClass):
2584
2585 2019-03-20  Saam Barati  <sbarati@apple.com>
2586
2587         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2588         https://bugs.webkit.org/show_bug.cgi?id=195721
2589
2590         Reviewed by Filip Pizlo.
2591
2592         * Scripts/run-javascriptcore-tests:
2593
2594 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2595
2596         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2597         https://bugs.webkit.org/show_bug.cgi?id=196049
2598
2599         Reviewed by Tim Horton.
2600
2601         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2602         overflow scrolling in general, so rename it.
2603
2604         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2605
2606 2019-03-20  Daniel Bates  <dabates@apple.com>
2607
2608         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2609         https://bugs.webkit.org/show_bug.cgi?id=196031
2610         <rdar://problem/49078172>
2611
2612         Reviewed by Tim Horton.
2613
2614         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2615         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2616         same code path used when the Done button is pressed to dismiss the <select> picker.
2617
2618         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2619         (TestWebKitAPI::TEST):
2620
2621 2019-03-20  Chris Dumez  <cdumez@apple.com>
2622
2623         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2624         https://bugs.webkit.org/show_bug.cgi?id=196029
2625         <rdar://problem/48954651>
2626
2627         Reviewed by Tim Horton.
2628
2629         Add API test coverage.
2630
2631         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2632
2633 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2634
2635         [ews-build] Improve failure summary string for ApplyPatch step
2636         https://bugs.webkit.org/show_bug.cgi?id=195995
2637
2638         Reviewed by Alexey Proskuryakov.
2639
2640         * BuildSlaveSupport/ews-build/steps.py:
2641         (ApplyPatch.getResultSummary): Override getResultSummary.
2642
2643 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2644
2645         AX: Implement support for new meter ARIA role
2646         https://bugs.webkit.org/show_bug.cgi?id=195966
2647
2648         Reviewed by Chris Fleizach.
2649
2650         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2651         to AXLevelIndicator.
2652
2653         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2654
2655 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2656
2657         [WebAuthN] Implement FIDO AppID extension
2658         https://bugs.webkit.org/show_bug.cgi?id=143491
2659         <rdar://problem/48298273>
2660
2661         Reviewed by Brent Fulgham.
2662
2663         Add a test that covers the new flag of convertToU2fSignCommand.
2664
2665         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2666         (TestWebKitAPI::TEST):
2667         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2668         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2669         (TestWebKitAPI::TEST):
2670
2671 2019-03-19  Keith Rollin  <krollin@apple.com>
2672
2673         Add support for more platforms to generate-xcfilelists
2674         https://bugs.webkit.org/show_bug.cgi?id=195977
2675
2676         Reviewed by Alexey Proskuryakov.
2677
2678         generate-xcfilelists incorrectly complains when involved with building
2679         WebKit for iphonesimulator:
2680
2681             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2682             …
2683             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2684
2685         Address this by teaching generate-xcfilelists about more platforms.
2686
2687         * Scripts/generate-xcfilelists:
2688
2689 2019-03-19  John Wilander  <wilander@apple.com>
2690
2691         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2692         https://bugs.webkit.org/show_bug.cgi?id=195923
2693         <rdar://problem/49001272>
2694
2695         Reviewed by Alex Christensen.
2696
2697         This patch does the following to the TestRunner:
2698         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2699         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2700         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2701
2702         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2703         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2704         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2705         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2706         * WebKitTestRunner/TestController.cpp:
2707         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2708         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2709         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2710         * WebKitTestRunner/TestController.h:
2711         * WebKitTestRunner/TestInvocation.cpp:
2712         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2713
2714 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2715
2716         [CMake] Support more clang and gcc sanitizers
2717         https://bugs.webkit.org/show_bug.cgi?id=195956
2718
2719         Reviewed by Michael Catanzaro.
2720
2721         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2722
2723 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2724
2725         [ews-build] Improve summary for PrintConfiguration step
2726         https://bugs.webkit.org/show_bug.cgi?id=195945
2727
2728         Reviewed by Lucas Forschler.
2729
2730         * BuildSlaveSupport/ews-build/steps.py:
2731         (PrintConfiguration.getResultSummary): Override getResultSummary.
2732
2733 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2734
2735         [ews-build] Improve summary for CheckOutSource step
2736         https://bugs.webkit.org/show_bug.cgi?id=195963
2737
2738         Reviewed by Lucas Forschler.
2739
2740         * BuildSlaveSupport/ews-build/steps.py:
2741         (CheckOutSource.getResultSummary):
2742
2743 2019-03-19  Daniel Bates  <dabates@apple.com>
2744
2745         [iOS] Focus not preserved when switching between tabs
2746         https://bugs.webkit.org/show_bug.cgi?id=195820
2747         <rdar://problem/43614450>
2748
2749         Reviewed by Brent Fulgham.
2750
2751         Add tests to ensure that we restore focus when resigning and becoming first responder.
2752
2753         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2754         (TestWebKitAPI::TEST):
2755
2756 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2757
2758         Make WTFLogChannelState and WTFLogLevel enum classes
2759         https://bugs.webkit.org/show_bug.cgi?id=195904
2760
2761         Reviewed by Eric Carlson.
2762
2763         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2764         (TestWebKitAPI::TEST_F):
2765
2766 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2767
2768         [GStreamer][EME] Backported mssdemux protection data crash fix
2769         https://bugs.webkit.org/show_bug.cgi?id=195918
2770
2771         Reviewed by Philippe Normand.
2772
2773         * gstreamer/jhbuild.modules:
2774         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2775
2776 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2777
2778         Unreviewed, rolling out r243132.
2779
2780         Broke GTK build
2781
2782         Reverted changeset:
2783
2784         "Make WTFLogChannelState and WTFLogLevel enum classes"
2785         https://bugs.webkit.org/show_bug.cgi?id=195904
2786         https://trac.webkit.org/changeset/243132
2787
2788 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2789
2790         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2791
2792         * Scripts/webkitdirs.pm:
2793         (builtDylibPathForName): Adjust the shared library name that's changed
2794         with the API version bump in r243073.
2795
2796 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2797
2798         Make WTFLogChannelState and WTFLogLevel enum classes
2799         https://bugs.webkit.org/show_bug.cgi?id=195904
2800
2801         Reviewed by Eric Carlson.
2802
2803         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2804         (TestWebKitAPI::TEST_F):
2805
2806 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2807
2808         Disable flaky test added in r2431100
2809         https://webkit.org/b/195785
2810
2811         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2812         (TestWebKitAPI::TEST):
2813         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2814
2815 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2816
2817         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2818         https://bugs.webkit.org/show_bug.cgi?id=195916
2819
2820         Reviewed by Tim Horton.
2821
2822         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2823         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2824
2825 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2826
2827         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2828
2829         * Scripts/webkitpy/common/config/contributors.json:
2830
2831 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2832
2833         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2834         https://bugs.webkit.org/show_bug.cgi?id=195785
2835
2836         Reviewed by Geoffrey Garen.
2837
2838         * TestWebKitAPI/TCPServer.cpp: Added.
2839         (TestWebKitAPI::TCPServer::TCPServer):
2840         (TestWebKitAPI::TCPServer::~TCPServer):
2841         (TestWebKitAPI::TCPServer::socketBindListen):
2842         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2843         * TestWebKitAPI/TCPServer.h: Added.
2844         (TestWebKitAPI::TCPServer::port const):
2845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2846         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2847         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2848         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2849         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2850         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2851         (TestWebKitAPI::respondSlowly):
2852         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2853         (TestWebKitAPI::downloadAtRate):
2854         (TestWebKitAPI::TEST):
2855
2856 2019-03-18  Saam Barati  <sbarati@apple.com>
2857
2858         Add a plan file for JetStream 2
2859         https://bugs.webkit.org/show_bug.cgi?id=190734
2860
2861         Reviewed by Mark Lam.
2862
2863         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2864
2865 2019-03-18  Chris Dumez  <cdumez@apple.com>
2866
2867         Delay WebProcess launch until a load is triggered in a Web view
2868         https://bugs.webkit.org/show_bug.cgi?id=195758
2869         <rdar://problem/48126013>
2870
2871         Reviewed by Geoff Garen.
2872
2873         Add API test coverage. Also update some existing API tests to not expect
2874         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2875
2876         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2877         (TestWebKitAPI::TEST):
2878         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2879         (TestWebKitAPI::TEST):
2880         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2881         (TEST):
2882         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2883         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2884         (TEST):
2885         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2886         (TEST):
2887         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2888
2889 2019-03-18  Xan Lopez  <xan@igalia.com>
2890
2891         [CMake] Prevent potential warning when determining $architecture
2892         https://bugs.webkit.org/show_bug.cgi?id=195891
2893
2894         Reviewed by Michael Catanzaro.
2895
2896         It's possible for generateBuildSystemForCMakeProject to be called
2897         before determineArchitecture() is ever called. This will make the
2898         first eq check with $architecture to be bogus (and print a
2899         warning). Change that to an eq check with architecture(), which
2900         implicitly calls determineArchitecture() if needed, and change all
2901         the other similar cases in the method in the same way to prevent
2902         future bugs like this one.
2903
2904         * Scripts/webkitdirs.pm:
2905         (generateBuildSystemFromCMakeProject):
2906
2907 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2908
2909         [WPE] Tarballs generated with “make dist” cannot build documentation
2910         https://bugs.webkit.org/show_bug.cgi?id=195885
2911
2912         Reviewed by Carlos Garcia Campos.
2913
2914         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2915
2916 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2917
2918         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2919         https://bugs.webkit.org/show_bug.cgi?id=195883
2920
2921         Reviewed by Carlos Garcia Campos.
2922
2923         * gtkdoc/gtkdoc.py:
2924         (GTKDoc._run_command): When commands fail to run, include the full command line for
2925         the program invocation and the output it has generated on the standard error stream.
2926
2927 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2928
2929         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2930         https://bugs.webkit.org/show_bug.cgi?id=195786
2931
2932         Reviewed by Philippe Normand.
2933
2934         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2935         * wpe/jhbuild.modules: Ditto.
2936
2937 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2938
2939         [ews-build] Don't run clean builds on EWS builders
2940         https://bugs.webkit.org/show_bug.cgi?id=195851
2941
2942         Reviewed by Geoffrey Garen.
2943
2944         * BuildSlaveSupport/ews-build/factories.py:
2945
2946 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2947
2948         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2949         https://bugs.webkit.org/show_bug.cgi?id=195849
2950
2951         Reviewed by Chris Dumez.
2952
2953         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2954
2955         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2956         (runWebsiteDataStoreCustomPaths):
2957
2958 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2959
2960         webkitpy: Upload test results
2961         https://bugs.webkit.org/show_bug.cgi?id=195755
2962         <rdar://problem/48896182>
2963
2964         Reviewed by Aakash Jain.
2965
2966         Establish a new format for uploading results that is not tied to layout tests, apply
2967         that format to webkitpy tests.
2968
2969         * Scripts/webkitpy/common/checkout/scm/git.py:
2970         (Git.native_branch): Return what branch the current checkout is on.
2971         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2972         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2973         * Scripts/webkitpy/common/checkout/scm/svn.py:
2974         (SVN.native_branch): Ditto.
2975         * Scripts/webkitpy/common/system/platforminfo.py:
2976         (PlatformInfo.build_version): Return a build version for Mac.
2977         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2978         (MockPlatformInfo.__init__):
2979         (MockPlatformInfo.build_version):
2980         * Scripts/webkitpy/results: Added.
2981         * Scripts/webkitpy/results/__init__.py: Added.
2982         * Scripts/webkitpy/results/options.py: Added.
2983         (upload_options): OptParse list for upload options.
2984         * Scripts/webkitpy/results/upload.py: Added.
2985         (Upload): Class which enforces the upload format expected by the results server.
2986         (Upload.Expectations):
2987         (Upload.create_configuration):
2988         (Upload.create_commit):
2989         (Upload.create_details):
2990         (Upload.create_run_stats):
2991         (Upload.create_test_result):
2992         (Upload.__init__):
2993         (Upload.Encoder): Encode Upload object as json.
2994         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2995         * Scripts/webkitpy/results/upload_unittest.py: Added.
2996         * Scripts/webkitpy/test/main.py:
2997         (Tester._parse_args): Add upload arguments.
2998         (Tester._run_tests): Allow results to be uploaded.
2999         * Scripts/webkitpy/test/runner.py:
3000         (Runner.__init__): Record which tests were run, rather than just counting them.
3001         (Runner.handle):
3002         * Scripts/webkitpy/test/runner_unittest.py:
3003         (RunnerTest.test_run):
3004         * Scripts/webkitpy/thirdparty/__init__.py:
3005         (AutoinstallImportHook.find_module): Add requests auto-install.
3006         (AutoinstallImportHook._install_requests):
3007         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3008         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3009
3010 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3011
3012         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3013         https://bugs.webkit.org/show_bug.cgi?id=195810
3014
3015         Reviewed by Tim Horton.
3016
3017         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3018         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3019         ending certain layout tests.
3020
3021         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3022         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3023         (-[TestRunnerWKWebView dealloc]):
3024         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3025
3026         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3027         helper method when destroying the web view, and when resetting state between tests.
3028
3029         * WebKitTestRunner/ios/TestControllerIOS.mm:
3030         (WTR::TestController::platformResetStateToConsistentValues):
3031
3032         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3033
3034 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3035
3036         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3037         https://bugs.webkit.org/show_bug.cgi?id=190350
3038         <rdar://problem/45089503>
3039
3040         Reviewed by Geoffrey Garen.
3041
3042         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3043         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3044         (TEST):
3045         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3046         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3047         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3048         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3049         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3050         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3051         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3052         (runTest):
3053         (createDirectories):
3054         (TEST):
3055         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3056         (TEST):
3057         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3058         (TEST):
3059
3060 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3061
3062         Add support to WebPage for getting the contents as an attributed string.
3063         https://bugs.webkit.org/show_bug.cgi?id=195636
3064         rdar://problem/45055697
3065
3066         Reviewed by Tim Horton.
3067
3068         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3069         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3070
3071 2019-03-15  Chris Dumez  <cdumez@apple.com>
3072
3073         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3074         https://bugs.webkit.org/show_bug.cgi?id=195747
3075
3076         Reviewed by Geoff Garen.
3077
3078         Add API test coverage.
3079
3080         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3081
3082 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3083
3084         Unreviewed, rolling out r242952.
3085
3086         Causing API failures on iOS Simulator
3087
3088         Reverted changeset:
3089
3090         "[PSON] Make sure the WebProcessCache is leverage when
3091         relaunching a process after termination"
3092         https://bugs.webkit.org/show_bug.cgi?id=195747
3093         https://trac.webkit.org/changeset/242952
3094
3095 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3096
3097         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3098         https://bugs.webkit.org/show_bug.cgi?id=195740
3099
3100         Reviewed by Ross Kirsling.
3101
3102         window.open doesn't work for WebKitBrowserWindow because it is not
3103         implemented yet.
3104
3105         1. Implemented createNewPage callback of WKPageUIClient.
3106         2. Changed MainWindow to take a BrowserWindow factory function
3107           instead of BrowserWindowType to be flexible to create
3108           BrowserWindow with extra settings.
3109         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3110           because it is not relevant with MainWindow anymore.
3111
3112         * MiniBrowser/win/Common.cpp:
3113         (parseCommandLine):
3114         * MiniBrowser/win/Common.h:
3115         (CommandLineOptions::CommandLineOptions):
3116         * MiniBrowser/win/MainWindow.cpp:
3117         (MainWindow::MainWindow):
3118         (MainWindow::create):
3119         (MainWindow::init):
3120         (MainWindow::WndProc):
3121         * MiniBrowser/win/MainWindow.h:
3122         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3123         (PrintWebUIDelegate::createWebViewWithRequest):
3124         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3125         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3126         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3127         (WebKitBrowserWindow::updateProxySettings):
3128         (WebKitBrowserWindow::createNewPage):
3129         * MiniBrowser/win/WebKitBrowserWindow.h:
3130         * MiniBrowser/win/WinMain.cpp:
3131         (wWinMain):
3132
3133 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3134
3135         Make it possible to test scrolling tree layer manipulation more easily
3136         https://bugs.webkit.org/show_bug.cgi?id=195780
3137
3138         Reviewed by Tim Horton.
3139         
3140         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3141         cuts off communication of scrolling tree scrolls back to the web process
3142         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3143         allows tests to trigger scrolls which run the scrolling tree layer positioning
3144         logic, but never get another commit from the web process that might mask
3145         scrolling tree bugs.
3146         
3147         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3148         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3149         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3150
3151         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3152         (WTR::UIScriptController::scrollUpdatesDisabled const):
3153         (WTR::UIScriptController::setScrollUpdatesDisabled):
3154         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3155         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3156         (WTR::UIScriptController::scrollUpdatesDisabled const):
3157         (WTR::UIScriptController::setScrollUpdatesDisabled):
3158         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3159         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3160         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3161         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3162         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3163         * WebKitTestRunner/ios/TestControllerIOS.mm:
3164         (WTR::TestController::platformResetStateToConsistentValues):
3165         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3166         (WTR::UIScriptController::scrollUpdatesDisabled const):
3167         (WTR::UIScriptController::setScrollUpdatesDisabled):
3168
3169 2019-03-14  Youenn Fablet  <youenn@apple.com>
3170
3171         Move IDB storage in private browsing mode to NetworkProcess
3172         https://bugs.webkit.org/show_bug.cgi?id=195602
3173
3174         Reviewed by Brady Eidson.
3175
3176         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3177         (TEST):
3178
3179 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3180
3181         [ews-build] Make descriptionDone messages more readable
3182         https://bugs.webkit.org/show_bug.cgi?id=195760
3183
3184         Reviewed by Lucas Forschler.
3185
3186         * BuildSlaveSupport/ews-build/steps.py:
3187         * BuildSlaveSupport/ews-build/steps_unittest.py:
3188
3189 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3190
3191         [ews-build] Generate status-bubble hover-over messages
3192         https://bugs.webkit.org/show_bug.cgi?id=195680
3193
3194         Reviewed by Lucas Forschler.
3195
3196         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3197         (StatusBubble):
3198         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3199         on hover-over.
3200         (StatusBubble._iso_time):
3201         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3202         hover-over message.
3203         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3204
3205 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3206
3207         [ews-app] Gracefully handle the case when state_string is None
3208         https://bugs.webkit.org/show_bug.cgi?id=195753
3209
3210         Reviewed by Lucas Forschler.
3211
3212         * BuildSlaveSupport/ews-app/ews/models/build.py:
3213         * BuildSlaveSupport/ews-app/ews/models/step.py:
3214
3215 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3216
3217         [ews-app] Status bubble display pending for currently running build step
3218         https://bugs.webkit.org/show_bug.cgi?id=195744
3219
3220         Reviewed by Lucas Forschler.
3221
3222         * BuildSlaveSupport/ews-build/events.py:
3223         (Events.stepStarted): If state_string is pending, replace it with step name.
3224
3225 2019-03-14  Chris Dumez  <cdumez@apple.com>
3226
3227         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3228         https://bugs.webkit.org/show_bug.cgi?id=195750
3229
3230         Reviewed by Geoffrey Garen.
3231
3232         Add API test coverage.
3233
3234         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3235         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3236         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3237         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3238
3239 2019-03-14  Chris Dumez  <cdumez@apple.com>
3240
3241         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3242         https://bugs.webkit.org/show_bug.cgi?id=195747
3243
3244         Reviewed by Geoff Garen.
3245
3246         Add API test coverage.
3247
3248         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3249
3250 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3251
3252         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3253         https://bugs.webkit.org/show_bug.cgi?id=195725
3254         <rdar://problem/48545062>
3255
3256         Reviewed by Tim Horton.
3257
3258         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3259         handler is nil.
3260
3261         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3262         (TestWebKitAPI::TEST):
3263
3264 2019-03-13  Sam Weinig  <sam@webkit.org>
3265
3266         Add utility function to allow easy reverse range-based iteration of a container
3267         https://bugs.webkit.org/show_bug.cgi?id=195542
3268
3269         Reviewed by Antti Koivisto.
3270
3271         * TestWebKitAPI/CMakeLists.txt:
3272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3273         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3274         (TestWebKitAPI::TEST):
3275         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3276
3277 2019-03-13  Chris Dumez  <cdumez@apple.com>
3278
3279         Use a ServiceWorker process per registrable domain
3280         https://bugs.webkit.org/show_bug.cgi?id=195649
3281
3282         Reviewed by Youenn Fablet.
3283
3284         Update API test coverage.
3285
3286         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3287
3288 2019-03-13  Chris Dumez  <cdumez@apple.com>
3289
3290         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3291         https://bugs.webkit.org/show_bug.cgi?id=195684
3292         <rdar://problem/48294714>
3293
3294         Reviewed by Antti Koivisto.
3295
3296         Add API test coverage.
3297
3298         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3299
3300 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3301
3302         [ews-app] Remove unused patch view
3303         https://bugs.webkit.org/show_bug.cgi?id=195669
3304
3305         Reviewed by Lucas Forschler.
3306
3307         * BuildSlaveSupport/ews-app/ews/urls.py:
3308         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3309
3310 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3311
3312         [ews-app] Use Buildbot result code variables
3313         https://bugs.webkit.org/show_bug.cgi?id=195668
3314
3315         Reviewed by Alexey Proskuryakov.
3316
3317         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3318         (Buildbot): Added Buildbot result code variables.
3319         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3320         (StatusBubble._build_bubble): Used Buildbot result code variables.
3321
3322 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3323
3324         [Flatpak] Expand submodule recursively
3325         https://bugs.webkit.org/show_bug.cgi?id=195672
3326
3327         Building WPE with flatpak was impossible without that as it was raising an exception.
3328         Also update wpebackend-fdo to match what is built in jhbuild
3329
3330         Reviewed by Philippe Normand.
3331
3332         * flatpak/flatpakutils.py:
3333         (expand_submodules_recurse):
3334         (expand_manifest):
3335         * flatpak/org.webkit.WPEModules.yaml:
3336
3337 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3338
3339         [ews-app] status bubble should be hidden for certain builds
3340         https://bugs.webkit.org/show_bug.cgi?id=194597
3341
3342         Reviewed by Dewei Zhu.
3343
3344         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3345         (StatusBubble._build_bubble):
3346         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3347         because the patch didn't have relevant changes.
3348         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3349         in production yet.
3350
3351 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3352
3353         [Win] Fix a slew of simple clang-cl warnings.
3354         https://bugs.webkit.org/show_bug.cgi?id=195652
3355
3356         Reviewed by Don Olmstead.
3357
3358         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3359         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3360
3361 2019-03-12  Justin Fan  <justin_fan@apple.com>
3362
3363         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3364         https://bugs.webkit.org/show_bug.cgi?id=195518
3365         <rdar://problem/46322356>
3366
3367         Reviewed by Myles C. Maxfield.
3368
3369         * DumpRenderTree/DerivedSources-input.xcfilelist:
3370         * DumpRenderTree/DerivedSources-output.xcfilelist:
3371
3372 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3373
3374         Unreviewed, rolling out r242825.
3375         https://bugs.webkit.org/show_bug.cgi?id=195648
3376
3377         "Broke webkitpy tests with my change to
3378         lldb_dump_class_layout.py" (Requested by rmorisset on
3379         #webkit).
3380
3381         Reverted changeset:
3382
3383         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3384         classes with suspicious padding"
3385         https://bugs.webkit.org/show_bug.cgi?id=195573
3386         https://trac.webkit.org/changeset/242825
3387
3388 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3389
3390         [ews-build] Show status bubbles while the patch is waiting in queue
3391         https://bugs.webkit.org/show_bug.cgi?id=195618
3392
3393         Reviewed by Lucas Forschler.
3394
3395         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3396         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3397         enabled in initial deployment.
3398         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3399         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3400         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3401         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3402         (StatusBubble._build_bubbles_for_patch):
3403
3404 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3405
3406         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3407         https://bugs.webkit.org/show_bug.cgi?id=195573
3408
3409         Reviewed by Simon Fraser.
3410
3411         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3412
3413         * Scripts/dump-class-layout:
3414         (main):
3415         * lldb/lldb_dump_class_layout.py:
3416         (ClassLayout.__init__):
3417         (ClassLayout._compute_padding_recursive):
3418         (LLDBDebuggerInstance.dump_layout_for_classname):
3419         (LLDBDebuggerInstance):
3420         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3421         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3422
3423 2019-03-12  Chris Dumez  <cdumez@apple.com>
3424
3425         Device Orientation access permission should be denied unless explicitly granted by the client
3426         https://bugs.webkit.org/show_bug.cgi?id=195625
3427
3428         Reviewed by Youenn Fablet.
3429
3430         add API test coverage.
3431
3432         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3433         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3434         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3435         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3436         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3437         (runDeviceOrientationTest):
3438         (TEST):
3439         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3440         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3441
3442 2019-03-12  Jer Noble  <jer.noble@apple.com>
3443
3444         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3445         https://bugs.webkit.org/show_bug.cgi?id=195137
3446         <rdar://problem/48810307>
3447
3448         Reviewed by Eric Carlson.
3449
3450         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3451         (TestWebKitAPI::TEST):
3452
3453 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3454
3455         [ews-build] Change urls from uat to production
3456         https://bugs.webkit.org/show_bug.cgi?id=195566
3457
3458         Reviewed by Lucas Forschler.
3459
3460         * BuildSlaveSupport/ews-app/ews/config.py:
3461         * BuildSlaveSupport/ews-build/events.py:
3462         * BuildSlaveSupport/ews-build/steps.py:
3463
3464 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3465
3466         [ews-build] change max_builds for local-worker to 1
3467         https://bugs.webkit.org/show_bug.cgi?id=195568
3468
3469         Reviewed by Lucas Forschler.
3470
3471         * BuildSlaveSupport/ews-build/loadConfig.py:
3472
3473 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3474
3475         Fix the build
3476
3477         * TestRunnerShared/spi/PencilKitTestSPI.h:
3478         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3479
3480 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3481
3482         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3483         https://bugs.webkit.org/show_bug.cgi?id=194131
3484
3485         Reviewed by Michael Catanzaro.
3486
3487         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3488         (uriChanged):
3489         (testUnfinishedSubresourceLoad):
3490         (serverCallback):
3491         (beforeAll):
3492
3493 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3494
3495         WTF::Expected should use std::addressof instead of operator&
3496         https://bugs.webkit.org/show_bug.cgi?id=195604
3497
3498         Reviewed by Myles Maxfield.
3499
3500         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3501         (TestWebKitAPI::Unique::Unique):
3502         (TestWebKitAPI::Unique::operator&):
3503         (TestWebKitAPI::TEST):
3504
3505 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3506
3507         Add Optional to Forward.h.
3508         https://bugs.webkit.org/show_bug.cgi?id=195586
3509
3510         Reviewed by Darin Adler.
3511
3512         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3513         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3514         Remove unnecessary includes from headers.
3515
3516 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3517
3518         Add testing API to hit-test and scroll overflow scrollers
3519         https://bugs.webkit.org/show_bug.cgi?id=195278
3520
3521         Reviewed by Antti Koivisto.
3522         
3523         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3524         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3525         
3526         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3527
3528         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3529         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3530         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3531         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3532         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3533         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3534         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3535         (WTR::enclosingScrollViewIncludingSelf):
3536         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3537
3538 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3539
3540         API test WebKit.RequestTextInputContext fails on iOS
3541         https://bugs.webkit.org/show_bug.cgi?id=195585
3542
3543         Reviewed by Wenson Hsieh and Simon Fraser.
3544
3545         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3546         (applyStyle):
3547         (TEST):
3548         Add a viewport, so that the coordinates match up on iOS.
3549         Scroll by moving the UIScrollView's contentOffset.
3550
3551 2019-03-11  Chris Dumez  <cdumez@apple.com>
3552
3553         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3554         https://bugs.webkit.org/show_bug.cgi?id=195506
3555         <rdar://problem/48733477>
3556
3557         Reviewed by Alex Christensen.
3558
3559         Add API test coverage.
3560
3561         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3562
3563 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3564
3565         Adding myself to contributors.json
3566
3567         Unreviewed, addming myself to contributors.json .
3568
3569         * Scripts/webkitpy/common/config/contributors.json:
3570
3571 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3572
3573         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3574         https://bugs.webkit.org/show_bug.cgi?id=195511
3575         <rdar://problem/44873269>
3576
3577         Reviewed by Darin Adler.
3578
3579         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3580         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3581         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3582         (TEST_F):
3583
3584 2019-03-11  Chris Dumez  <cdumez@apple.com>
3585
3586         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3587         https://bugs.webkit.org/show_bug.cgi?id=195561
3588
3589         Reviewed by Youenn Fablet.
3590
3591         Make sure the JS in the test requests for permission to receive device orientation events.
3592
3593         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3594
3595 2019-03-11  Youenn Fablet  <youenn@apple.com>
3596
3597         Allow storage quota increase by default in WTR
3598         https://bugs.webkit.org/show_bug.cgi?id=195541
3599
3600         Reviewed by Geoffrey Garen.
3601
3602         Allow storage quota increase by default in WTR.
3603         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3604         Use this for tests that explicitly need cache increase.
3605
3606         Instead of increasing quota by 2, make sure the next request is
3607         granted by adding all given parameters.
3608
3609         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3610         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3611         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3612         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3613         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3614         * WebKitTestRunner/TestController.cpp:
3615         (WTR::TestController::setAllowStorageQuotaIncrease):
3616         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3617         * WebKitTestRunner/TestController.h:
3618         * WebKitTestRunner/TestInvocation.cpp:
3619         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3620         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3621         (WTR::TestController::cocoaResetStateToConsistentValues):
3622         (WTR::TestController::setAllowStorageQuotaIncrease):
3623         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3624         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3625         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3626
3627 2019-03-11  Xan Lopez  <xan@igalia.com>
3628
3629         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3630         https://bugs.webkit.org/show_bug.cgi?id=194147
3631
3632         Reviewed by Michael Saboff.
3633
3634         To make --32-bit work correctly on Linux/64bit we need to:
3635
3636         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3637         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3638         unfortunately CMake only allows us to do this during
3639         crosscompilation, which is overkill here.
3640         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3641         pkg-config detection module uses the x86 .pc files instead of the
3642         x86_64 ones.
3643         - Set the -m32 flags for the compiler.
3644
3645         * Scripts/webkitdirs.pm:
3646         (generateBuildSystemFromCMakeProject):
3647
3648 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3649
3650         Add MotionMark-1.1 plan file for run-benchmark script.
3651         https://bugs.webkit.org/show_bug.cgi?id=195481
3652
3653         Rubber-stamped by Darin Adler.
3654
3655         Run-benchmark script should support MontionMark-1.1.
3656
3657         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3658
3659 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3660
3661         [ews-app] Add support for submit-to-ews url
3662         https://bugs.webkit.org/show_bug.cgi?id=195477
3663
3664         Reviewed by Lucas Forschler.
3665
3666         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3667         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3668         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3669         * BuildSlaveSupport/ews-app/ews/urls.py:
3670         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3671
3672 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3673
3674         Unreviewed, rolling out r242688, r242643, r242624.
3675
3676         Caused multiple layout test failures and crashes on iOS and macOS.
3677
3678         Reverted changeset:
3679
3680         "requestAnimationFrame should execute before the next frame"
3681         https://bugs.webkit.org/show_bug.cgi?id=177484
3682         https://trac.webkit.org/changeset/242624/webkit
3683
3684         * Tracing/SystemTracePoints.plist:
3685
3686 2019-03-11  John Wilander  <wilander@apple.com>
3687
3688         Resource Load Statistics: Make it possible exclude localhost from classification
3689         https://bugs.webkit.org/show_bug.cgi?id=195474
3690         <rdar://problem/47520577>
3691
3692         Reviewed by Brent Fulgham.
3693
3694         This patch allows for localhost to be excluded from classification and
3695         treatment as a prevalent resource.
3696
3697         The WebKit Tools change adds a new function called
3698         testRunner.setStatisticsIsRunningTest() which can be used to control this
3699         behavior.
3700
3701         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3702         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3703         (WTR::TestRunner::setStatisticsIsRunningTest):
3704         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3705         * WebKitTestRunner/TestController.cpp:
3706         (WTR::TestController::setStatisticsIsRunningTest):
3707         * WebKitTestRunner/TestController.h:
3708         * WebKitTestRunner/TestInvocation.cpp:
3709         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3710
3711 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3712
3713         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3714         https://bugs.webkit.org/show_bug.cgi?id=195560
3715
3716         Reviewed by Lucas Forschler.
3717
3718         * BuildSlaveSupport/ews-build/master.cfg:
3719
3720 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3721
3722         Unreviewed, rolling out r242698.
3723
3724         API test crashes on bots.
3725
3726         Reverted changeset:
3727
3728         "Add a WKContentRuleList variant that uses copied memory
3729         instead of mmap'd shared memory for class A containerized
3730         apps"
3731         https://bugs.webkit.org/show_bug.cgi?id=195511
3732         https://trac.webkit.org/changeset/242698
3733
3734 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3735
3736         [WPE] Enable web process sandbox
3737         https://bugs.webkit.org/show_bug.cgi?id=195169
3738
3739         Reviewed by Daniel Bates.
3740
3741         * wpe/install-dependencies:
3742         * wpe/jhbuild.modules:
3743
3744 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3745
3746         [ews-app] Use port 17000 for worker communication
3747         https://bugs.webkit.org/show_bug.cgi?id=195558
3748
3749         Reviewed by Lucas Forschler.
3750
3751         * BuildSlaveSupport/ews-build/master.cfg:
3752
3753 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3754
3755         [ews-build] unit-tests fail when passwords.json is missing
3756         https://bugs.webkit.org/show_bug.cgi?id=195557
3757
3758         Reviewed by Lucas Forschler.
3759
3760         * BuildSlaveSupport/ews-build/loadConfig.py:
3761         (loadBuilderConfig):
3762         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3763         (ConfigDotJSONTest.test_configuration):
3764         * BuildSlaveSupport/ews-build/master.cfg:
3765
3766 2019-03-11  Truitt Savell  <tsavell@apple.com>
3767
3768         Unreviewed, rolling out r242702.
3769
3770         Broke High Sierra builders.
3771
3772         Reverted changeset:
3773
3774         "Add utility function to allow easy reverse range-based
3775         iteration of a container"
3776         https://bugs.webkit.org/show_bug.cgi?id=195542
3777         https://trac.webkit.org/changeset/242702
3778
3779 2019-03-11  Sam Weinig  <sam@webkit.org>
3780
3781         Add utility function to allow easy reverse range-based iteration of a container
3782         https://bugs.webkit.org/show_bug.cgi?id=195542
3783
3784         Reviewed by Antti Koivisto.
3785
3786         * TestWebKitAPI/CMakeLists.txt:
3787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3788         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3789         (TestWebKitAPI::TEST):
3790         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3791
3792 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3793
3794         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3795         https://bugs.webkit.org/show_bug.cgi?id=195511
3796         <rdar://problem/44873269>
3797
3798         Reviewed by Darin Adler.
3799
3800         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3801         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3802         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3803         (TEST_F):
3804
3805 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3806
3807         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3808         https://bugs.webkit.org/show_bug.cgi?id=195499
3809
3810         Reviewed by Darin Adler.
3811
3812         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3813         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3814         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3815         (-[WKWebView synchronouslyFocusTextInputContext:]):
3816         (applyStyle):
3817         (applyIframe):
3818         (TEST):
3819         Add some tests for this SPI.
3820
3821 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3822
3823         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3824         https://bugs.webkit.org/show_bug.cgi?id=181151
3825
3826         Reviewed by Don Olmstead.
3827
3828         * TestWebKitAPI/CMakeLists.txt:
3829         * TestWebKitAPI/PlatformWin.cmake:
3830         Enable TestWTF RunLoop tests in all platforms.
3831
3832         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3833         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3834         (TestWebKitAPI::DerivedOneShotTimer::fired):
3835         (TestWebKitAPI::TEST):
3836         Only a few platforms support nested RunLoop.
3837
3838         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3839         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3840
3841 2019-03-10  David Quesada  <david_quesada@apple.com>
3842
3843         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3844         https://bugs.webkit.org/show_bug.cgi?id=152480
3845
3846         Reviewed by Chris Dumez.
3847
3848         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3849         there are no additional references to the process pool besides the one held by
3850         the download, waits for the download to finish (in the sense that the
3851         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3852         measure, also check that the process pool has been deallocated at the end of the
3853         test. The test wouldn't be meaningful if the process pool were still alive.
3854
3855         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3856         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3857         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3858             The download will be canceled because the delegate does not implement the
3859             method to decide the download's destination, so this is where we know the
3860             DownloadProxyMap is done with the DownloadProxy.
3861         (TEST):
3862
3863 2019-03-08  Chris Dumez  <cdumez@apple.com>
3864
3865         Add support for Device Orientation / Motion permission API
3866         https://bugs.webkit.org/show_bug.cgi?id=195329
3867         <rdar://problem/47645367>
3868
3869         Reviewed by Geoffrey Garen.
3870
3871         Add test infrastructure to help test the Device Orientation / Motion permission API.
3872
3873         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3874         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3875         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3876         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3877         * WebKitTestRunner/TestController.cpp:
3878         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3879         (WTR::TestController::createWebViewWithOptions):
3880         (WTR::TestController::resetStateToConsistentValues):
3881         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3882         * WebKitTestRunner/TestController.h:
3883         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3884         * WebKitTestRunner/TestInvocation.cpp:
3885         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3886
3887 2019-03-08  Saam barati  <sbarati@apple.com>
3888
3889         Add a compare-results script to compare benchmark results
3890         https://bugs.webkit.org/show_bug.cgi?id=195486
3891         <rdar://problem/48723397>
3892
3893         Reviewed by Geoffrey Garen.
3894
3895         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3896         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3897         to extend it to learn about our other benchmarks.
3898
3899         * Scripts/compare-results: Added.
3900         (readJSONFile):
3901         (detectJetStream2):
3902         (JetStream2Results):
3903         (detectSpeedometer2):
3904         (Speedometer2Results):
3905         (detectPLT5):
3906         (PLT5Results):
3907         (detectBenchmark):
3908         (biggerIsBetter):
3909         (ttest):
3910         (getOptions):
3911         (main):
3912
3913 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3914
3915         Ensure old tab state is cleared between iterations of run-benchmark
3916         https://bugs.webkit.org/show_bug.cgi?id=195393
3917         <rdar://problem/46885583>
3918
3919         Reviewed by Dewei Zhu.
3920
3921         a) ensure the default to restore state is not set
3922         b) terminate Safari correctly
3923         c) Set the system default to ignore Persistent State in Safari
3924
3925         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3926         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3927         (OSXBrowserDriver.prepare_env): 
3928         (OSXBrowserDriver.restore_env):
3929         (OSXBrowserDriver.close_browsers):
3930         (OSXBrowserDriver._terminate_processes):
3931         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3932         (OSXChromeDriver):
3933         (OSXChromeCanaryDriver):
3934         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3935         (OSXFirefoxDriver):
3936         (OSXFirefoxNightlyDriver):
3937         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3938         (OSXSafariDriver):
3939         (OSXSafariDriver.prepare_env):
3940
3941 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3942
3943         [GTK] Several InputMethodFilter tests are failing
3944         https://bugs.webkit.org/show_bug.cgi?id=195408
3945
3946         Reviewed by Carlos Garcia Campos.
3947
3948         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3949         Regressed in r241751.
3950         Hexadecimal values of keycodes are expressed now in upper letters.
3951         Composited characters should be cast to UTF8 strings.
3952
3953         (TestWebKitAPI::TEST):
3954
3955 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3956
3957         [GTK] Make Tools/gtkdoc python3 compatible
3958         https://bugs.webkit.org/show_bug.cgi?id=195359
3959
3960         Reviewed by Carlos Garcia Campos.
3961
3962         * gtkdoc/generate-gtkdoc:
3963         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3964         work with Python 2 and 3.
3965         (get_gtkdoc_module_paths):
3966         The iteritems() was removed in Python 3, so let's use items() that's
3967         available in Python 2 and 3.
3968         (get_generator_for_config):
3969         * gtkdoc/gtkdoc.py:
3970         (GTKDoc._run_command):
3971         The sys.stdout.write() is expecting str in Python 3 and not bytes
3972         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3973         for passing the bytes there.
3974
3975 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3976
3977         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3978         https://bugs.webkit.org/show_bug.cgi?id=195346
3979         <rdar://problem/48667048>
3980
3981         Unreviewed build fix for clang-cl.
3982
3983         * DumpRenderTree/win/DumpRenderTree.cpp:
3984         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3985
3986 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3987
3988         requestAnimationFrame should execute before the next frame
3989         https://bugs.webkit.org/show_bug.cgi?id=177484
3990
3991         Reviewed by Simon Fraser.
3992
3993         Add trace points for the page RenderingUpdate.
3994
3995         * Tracing/SystemTracePoints.plist:
3996
3997 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3998
3999         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
4000         https://bugs.webkit.org/show_bug.cgi?id=195353
4001         <rdar://problem/48626394>
4002
4003         Reviewed by Simon Fraser.
4004
4005         * WebKitTestRunner/ios/TestControllerIOS.mm:
4006         (WTR::TestController::platformResetPreferencesToConsistentValues):
4007
4008 2019-03-07  John Wilander  <wilander@apple.com>
4009
4010         Resource Load Statistics: Make it possible to purge only script-accessible cookies
4011         https://bugs.webkit.org/show_bug.cgi?id=195383
4012         <rdar://problem/48570136>
4013
4014         Reviewed by Brent Fulgham.
4015
4016         This patch adds test infrastructure to purge only script-accessible cookies,
4017         including a new testRunner function called statisticsDeleteCookiesForHost().git a
4018
4019         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4020         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4021         (WTR::TestRunner::statisticsDeleteCookiesForHost):
4022         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4023         * WebKitTestRunner/TestController.cpp:
4024         (WTR::TestController::statisticsDeleteCookiesForHost):
4025         * WebKitTestRunner/TestController.h:
4026         * WebKitTestRunner/TestInvocation.cpp:
4027         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4028
4029 2019-03-07  Commit Queue  <commit-queue@webkit.org>
4030
4031         Unreviewed, rolling out r242354.
4032         https://bugs.webkit.org/show_bug.cgi?id=195402
4033
4034         breaks layout tests in all configurations (Requested by
4035         zdobersek on #webkit).
4036
4037         Reverted changeset:
4038
4039         "[WPE] Enable web process sandbox"
4040         https://bugs.webkit.org/show_bug.cgi?id=195169
4041         https://trac.webkit.org/changeset/242354
4042
4043 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
4044
4045         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4046         https://bugs.webkit.org/show_bug.cgi?id=195346
4047
4048         Reviewed by Fujii Hironori.
4049
4050         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
4051         (TestWebKitAPI::TEST):
4052         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
4053
4054         * DumpRenderTree/win/DumpRenderTree.cpp:
4055         (findFontFallback):
4056         (addFontFallbackIfPresent):
4057         (removeFontFallbackIfPresent):
4058         (main):
4059         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4060         (TestWebKitAPI::Util::moduleDirectory):
4061         (TestWebKitAPI::Util::createInjectedBundlePath):
4062         Use wchar helpers as needed.
4063
4064 2019-03-06  Rob Buis  <rbuis@igalia.com>
4065
4066         Consider supporting the `referrerpolicy` attribute.
4067         https://bugs.webkit.org/show_bug.cgi?id=179053
4068
4069         Reviewed by Darin Adler.
4070
4071         Add a runtime flag for referrerpolicy attribute.
4072
4073         * DumpRenderTree/mac/DumpRenderTree.mm:
4074         (enableExperimentalFeatures):
4075
4076 2019-03-05  Daniel Bates  <dabates@apple.com>
4077
4078         Update expected API test result following r242379
4079         (https://bugs.webkit.org/show_bug.cgi?id=195125)
4080
4081         Update expected x-coordinate of selection rect now that the left padding of
4082         a textarea is sized in ems (so dependent on the font size) just like the left
4083         padding of a text field.
4084
4085         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4086         (TestWebKitAPI::TEST):
4087
4088 2019-03-05  David Quesada  <david_quesada@apple.com>
4089
4090         [WK2] It should be possible to follow links with 'download' attributes
4091         https://bugs.webkit.org/show_bug.cgi?id=195145
4092         rdar://problem/48462642
4093
4094         Reviewed by Alex Christensen.
4095
4096         Add a unit test to verify that activating links with 'download' attributes now
4097         navigates to the linked resource, rather than starts downloading it. Add another
4098         to verify that it is still possible to explicitly download the link via the
4099         'Download' navigation action policy.
4100
4101         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4102         (-[DownloadAttributeTestDelegate init]):
4103         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
4104         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
4105         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
4106         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
4107         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4108         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
4109         (TEST):
4110         * WebKitTestRunner/TestController.cpp:
4111         (WTR::TestController::decidePolicyForNavigationAction):
4112         * WebKitTestRunner/TestController.h:
4113
4114 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
4115
4116         [Curl] Implement Cookie Accept Policy.
4117         https://bugs.webkit.org/show_bug.cgi?id=191645
4118
4119         Reviewed by Fujii Hironori.
4120
4121         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4122         (TestWebKitAPI::Curl::TEST_F):
4123
4124 2019-03-05  Youenn Fablet  <youenn@apple.com>
4125
4126         Rename requestCacheStorageSpace to requestStorageSpace
4127         https://bugs.webkit.org/show_bug.cgi?id=195282
4128
4129         Reviewed by Chris Dumez.
4130
4131         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4132         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4133         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
4134
4135 2019-03-05  Brady Eidson  <beidson@apple.com>
4136
4137         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
4138         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
4139
4140         Reviewed by Tim Horton.
4141
4142         Loading a file: URL into a WKWebView and then loading another file: url from a completely
4143         different directory into that same WKWebView should work.
4144
4145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4146         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
4147
4148 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
4149
4150         Add WeakHashSet
4151         https://bugs.webkit.org/show_bug.cgi?id=195152
4152
4153         Reviewed by Antti Koivisto.
4154
4155         Added tests for WeakHashSet.
4156
4157         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4158         (TestWebKitAPI::Base::Base): Moved.
4159         (TestWebKitAPI::Derived::foo): Moved.
4160         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
4161         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
4162         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
4163         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
4164
4165 2019-03-04  Chris Dumez  <cdumez@apple.com>
4166
4167         Do not share WebProcesses between private and regular sessions
4168         https://bugs.webkit.org/show_bug.cgi?id=195189
4169         <rdar://problem/48421064>
4170
4171         Reviewed by Alex Christensen.
4172
4173         Add API test coverage.
4174
4175         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4176         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4177
4178 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
4179
4180         [WPE] Enable web process sandbox
4181         https://bugs.webkit.org/show_bug.cgi?id=195169
4182
4183         Reviewed by Daniel Bates.
4184
4185         * wpe/install-dependencies:
4186         * wpe/jhbuild.modules:
4187
4188 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4189
4190         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
4191         https://bugs.webkit.org/show_bug.cgi?id=195206
4192
4193         Reviewed by Žan Doberšek.
4194
4195         Add a new test case.
4196
4197         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4198         (testJSCClass):
4199
4200 2019-03-04  Charlie Turner  <cturner@igalia.com>
4201
4202         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
4203         https://bugs.webkit.org/show_bug.cgi?id=194898
4204
4205         Reviewed by Žan Doberšek.
4206
4207         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
4208         a GCC extension that permits arithmetic on void* pointer. Inline
4209         the macro until this issue is fixed upstream.
4210
4211 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4212
4213         Rid the world of WK_API_ENABLED
4214         https://bugs.webkit.org/show_bug.cgi?id=195263
4215
4216         Reviewed by Dan Bernstein.
4217
4218         List of changed files elided because it's useless.
4219
4220 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4221
4222         Unreviewed follow-up to r242292.
4223
4224         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4225
4226         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4227         (TestWebKitAPI::testStrip): Renamed from strip.
4228         (TestWebKitAPI::TEST):
4229
4230 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4231
4232         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4233
4234         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4235         and bug #194272 for details.
4236
4237         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4238
4239 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4240
4241         Remove some more unused 32-bit code
4242         https://bugs.webkit.org/show_bug.cgi?id=195255
4243
4244         Reviewed by Darin Adler.
4245
4246         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4247         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4248         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4249         (NPP_New):
4250         (NPP_HandleEvent):
4251         (handleEventCarbon): Deleted.
4252
4253 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4254
4255         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4256
4257         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4258         (TestWebKitAPI::TEST):
4259
4260 2019-03-01  Darin Adler  <darin@apple.com>
4261
4262         Finish removing String::format
4263         https://bugs.webkit.org/show_bug.cgi?id=194893
4264
4265         Reviewed by Daniel Bates.
4266 '
4267         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4268
4269 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4270
4271         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4272         https://bugs.webkit.org/show_bug.cgi?id=195229
4273         <rdar://problem/48520362>
4274
4275         Reviewed by Chris Dumez.
4276
4277         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4278         (TEST):
4279
4280 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4281
4282         Add a system trace scope for event region building
4283         https://bugs.webkit.org/show_bug.cgi?id=195226
4284
4285         Reviewed by Jon Lee.
4286
4287         This trace scope measures the time spend converting element rects into Region objects,
4288         which can be large on some pages.
4289
4290         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4291
4292         * Tracing/SystemTracePoints.plist:
4293
4294 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4295
4296         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4297         https://bugs.webkit.org/show_bug.cgi?id=194612
4298
4299         Reviewed by Alex Christensen.
4300
4301         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4302         Just test the new string-processing function and don't touch the actual environment.
4303         (Test cases are all as before, but based on operator== instead of strcmp.)
4304
4305 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4306
4307         [ews-app] Update primary keys for handling multiple Buildbot instances
4308         https://bugs.webkit.org/show_bug.cgi?id=195120
4309
4310         Reviewed by Stephanie Lewis.
4311
4312         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4313         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4314         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4315
4316         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4317         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4318         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4319         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4320         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4321         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4322
4323 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4324
4325         [WinCairo] Enable service worker
4326         https://bugs.webkit.org/show_bug.cgi?id=188318
4327
4328         Reviewed by Youenn Fablet.
4329
4330         * DumpRenderTree/DumpRenderTreePrefix.h:
4331         * TestWebKitAPI/PlatformWin.cmake:
4332         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4333         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4334         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4335
4336 2019-03-01  Justin Fan  <justin_fan@apple.com>
4337
4338         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4339         https://bugs.webkit.org/show_bug.cgi?id=195191
4340
4341         Rubber-stamped by Dean Jackson.
4342
4343         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4344
4345         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4346
4347 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4348
4349         Unreviewed, fix lldb webkitpy tests
4350         https://bugs.webkit.org/show_bug.cgi?id=194375
4351
4352         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4353
4354         * lldb/lldb_webkit.py:
4355         (WTFStringImplProvider.is_8bit):
4356
4357 2019-02-28  David Quesada  <david_quesada@apple.com>
4358
4359         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4360         https://bugs.webkit.org/show_bug.cgi?id=195121
4361         rdar://problem/48450302
4362
4363         Reviewed by Alex Christensen.