[Qt] Fix regression to test-webkitpy.
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-10  Glenn Adams  <glenn@skynav.com>
2
3         [Qt] Fix regression to test-webkitpy.
4         https://bugs.webkit.org/show_bug.cgi?id=114368
5
6         Reviewed by Ryosuke Niwa.
7
8         * Scripts/webkitpy/layout_tests/port/factory.py:
9         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
10         (PortFactory.get): Remove obsolete chromium port related code.
11         * Scripts/webkitpy/layout_tests/port/mac.py:
12         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
13
14 2013-04-10  Anders Carlsson  <andersca@apple.com>
15
16         Remove unneeded headers from FrameLoader.h
17         https://bugs.webkit.org/show_bug.cgi?id=114223
18
19         Reviewed by Geoffrey Garen.
20
21         Add back headers implicitly included by other headers.
22
23         * WebKitTestRunner/WorkQueueManager.cpp:
24
25 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
26
27         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
28         https://bugs.webkit.org/show_bug.cgi?id=114365
29
30         Reviewed by Martin Robinson.
31
32         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
33         The patch addresses crashes in the tally_event_reply method. It is already committed into the
34         at-spi2-atk source tree and will be available with the next stable release, after which the
35         patch should be removed and the dependency version bumped.
36
37         * gtk/jhbuild.modules:
38         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
39
40 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
41
42         [WinCairo] Unreviewed build fix. Correct DropBox download link.
43
44         * Scripts/update-webkit-wincairo-libs: Revise download URL to
45         match change in DropBox server behavior.
46
47 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
48
49         Removed an annoying message from svn-create-patch
50         https://bugs.webkit.org/show_bug.cgi?id=114332
51
52         Reviewed by Alexey Proskuryakov.
53
54         I see this message basically every time I write a patch, so it must not
55         be true.
56
57         * Scripts/svn-create-patch:
58         (generateDiff):
59
60 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
61
62         [GTK] Add support for Page Visibility
63         https://bugs.webkit.org/show_bug.cgi?id=97324
64
65         Reviewed by Sam Weinig.
66
67         Implemented test runner API for page visibility layout tests.
68
69         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
70         (TestRunner::resetPageVisibility):
71         (TestRunner::setPageVisibility):
72         * Scripts/webkitperl/FeatureList.pm:
73
74 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
75
76         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
77         https://bugs.webkit.org/show_bug.cgi?id=114342
78
79         Reviewed by Gyuyoung Kim.
80
81         Commit 148033 only added an implementation for the Mac port, which made
82         other ports fail most tests since loading the injected bundle failed
83         with a missing symbol.
84
85         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
86         (WTR::AccessibilityUIElement::pathDescription):
87
88 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
89
90         [EFL] Add spell checking option to MiniBrowser
91         https://bugs.webkit.org/show_bug.cgi?id=114282
92
93         Reviewed by Ryosuke Niwa.
94
95         Spell checking is enabled by adding a flag (t/text-checking)
96         with launching MiniBrowser.
97
98         * MiniBrowser/efl/main.c:
99         (window_create):
100         (elm_main):
101
102 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
103
104         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
105         https://bugs.webkit.org/show_bug.cgi?id=113281
106
107         Reviewed by Darin Adler.
108
109         * Scripts/run-gtk-tests:
110         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
111
112 2013-04-09  Glenn Adams  <glenn@skynav.com>
113
114         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
115
116         Unreviewed.
117
118         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
119         (RunTest.test_build_check):
120
121 2013-04-09  Glenn Adams  <glenn@skynav.com>
122
123         [webkitpy] Remove chromium ports.
124         https://bugs.webkit.org/show_bug.cgi?id=114326
125
126         Reviewed by Dirk Pranke.
127
128         As a side effect, also:
129
130         - remove chromium builders from webkitpy.layout_tests.port.builders
131         - remove chromium builders from rebaseline
132         - rewrite chromium dependent tests in rebaseline_unittest
133         - remove chromium platform from garden-o-matic
134         - select apple platform as default platform in garden-o-matic
135         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
136
137         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
138         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
139         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
140         (BaselineOptimizerTest.test_move_baselines):
141         (BaselineOptimizerTest.test_efl):
142         (BaselineOptimizerTest.test_no_add_mac_future):
143         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
144         (BaselineOptimizerTest.test_common_directory_includes_root):
145         (BaselineOptimizerTest.test_complex_shadowing):
146         (BaselineOptimizerTest.test_virtual_ports_filtered):
147         * Scripts/webkitpy/layout_tests/port/builders.py:
148         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
149         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
150         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
151         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
152         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
153         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
154         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
155         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
156         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
157         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
158         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
159         * Scripts/webkitpy/layout_tests/port/factory.py:
160         (platform_options):
161         (PortFactory):
162         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
163         (FactoryTest.test_qt):
164         (FactoryTest.test_get_from_builder_name):
165         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
166         (RunTest.test_build_check):
167         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
168         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
169         * Scripts/webkitpy/tool/commands/rebaseline.py:
170         (Rebaseline._builders_to_pull_from):
171         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
172         (_BaseTestCase):
173         (_BaseTestCase.setUp):
174         (TestRebaselineTest.setUp):
175         (TestRebaselineTest.test_baseline_directory):
176         (test_rebaseline_updates_expectations_file):
177         (test_rebaseline_does_not_include_overrides):
178         (test_rebaseline_test):
179         (test_rebaseline_test_and_print_scm_changes):
180         (test_rebaseline_and_copy_test):
181         (test_rebaseline_and_copy_test_no_existing_result):
182         (test_rebaseline_and_copy_test_with_lion_result):
183         (test_rebaseline_and_copy_no_overwrite_test):
184         (TestRebaselineExpectations.test_rebaseline_expectations):
185
186 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
187
188         newcommitbot (WKR) requires a subversion checkout
189         https://bugs.webkit.org/show_bug.cgi?id=114309
190
191         Reviewed by Benjamin Poulain.
192
193         Directly talk to the subversion server instead of relying on a local checkout.
194         This allows us to run WKR off of a git clone.
195
196         * Scripts/webkitpy/tool/commands/newcommitbot.py:
197         (NewCommitBot.next_work_item):
198         (NewCommitBot.process_work_item):
199
200 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
201
202         webkitbot refers to sheriffbot in help
203         https://bugs.webkit.org/show_bug.cgi?id=114307
204
205         Reviewed by Benjamin Poulain.
206
207         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
208
209         * Scripts/webkitpy/tool/bot/irc_command.py:
210         (Help):
211         (Help.execute):
212         (RollChromiumDEPS.execute):
213         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
214         (IRCBotTest.test_help):
215         * Scripts/webkitpy/tool/bot/sheriff.py:
216         (Sheriff.name):
217
218 2013-04-06  Roger Fong  <roger_fong@apple.com>
219
220         Kill old processes between runs on WinEWS bots.
221         Temporarily disable tests to let bots catch up again.
222
223         * EWSTools/start-queue-win.sh:
224         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
225         (WinEWS):
226
227 2013-04-09  Glenn Adams  <glenn@skynav.com>
228
229         [webkitpy] Remove chromium deprecated port support.
230         https://bugs.webkit.org/show_bug.cgi?id=114228
231
232         Reviewed by Ryosuke Niwa.
233
234         * Scripts/webkitpy/common/config/ports.py:
235         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
236         (ChromiumPort): Removed.
237         (ChromiumAndroidPort): Removed.
238         (ChromiumXVFBPort): Removed.
239         * Scripts/webkitpy/common/config/ports_unittest.py:
240         (DeprecatedPortTest.test_chromium_port): Removed.
241         (DeprecatedPortTest.test_chromium_android_port): Removed.
242         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
243         * Scripts/webkitpy/tool/steps/update_unittest.py:
244         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
245         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
246
247 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
248
249         AX: The bounding paths should be made available through accessibility
250         https://bugs.webkit.org/show_bug.cgi?id=113817
251
252         Reviewed by David Kilzer.
253
254         Add a pathDescription property for testing so that it's possible
255         to verify that a path is being returned correctly.
256
257         * DumpRenderTree/AccessibilityUIElement.cpp:
258         (getPathDescriptionCallback):
259         (AccessibilityUIElement::pathDescription):
260         (AccessibilityUIElement::getJSClass):
261         * DumpRenderTree/AccessibilityUIElement.h:
262         (AccessibilityUIElement):
263         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
264         (_CGPathEnumerationIteration):
265         (AccessibilityUIElement::pathDescription):
266         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
267         (AccessibilityUIElement::pathDescription):
268         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
269         (WTR::AccessibilityUIElement::pathDescription):
270         (WTR):
271         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
272         (AccessibilityUIElement):
273         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
274         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
275         (WTR::AccessibilityUIElement::pathDescription):
276         (WTR):
277
278 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
279
280         [EFL] Declare TEST_THEME_DIR in a single place.
281         https://bugs.webkit.org/show_bug.cgi?id=114285
282
283         Reviewed by Anders Carlsson.
284
285         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
286
287         * DumpRenderTree/efl/CMakeLists.txt:
288         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
289         (DumpRenderTreeChrome::createView):
290         (DumpRenderTreeChrome::createInspectorView):
291         (DumpRenderTreeChrome::initialize):
292         (DumpRenderTreeChrome::onDownloadRequest):
293         * EWebLauncher/CMakeLists.txt:
294         * EWebLauncher/main.c:
295         (findThemePath):
296         * EWebLauncher/url_bar.c:
297         (url_bar_add):
298         * MiniBrowser/efl/CMakeLists.txt:
299         * MiniBrowser/efl/main.c:
300         (window_create):
301         * TestWebKitAPI/PlatformEfl.cmake:
302         * TestWebKitAPI/efl/PlatformWebView.cpp:
303         (TestWebKitAPI::PlatformWebView::PlatformWebView):
304         * WebKitTestRunner/PlatformEfl.cmake:
305         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
306         (WTR::PlatformWebView::PlatformWebView):
307
308 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
309
310         [GTK][AC] upversion of clutter and its dependecy
311         https://bugs.webkit.org/show_bug.cgi?id=114016
312
313         Reviewed by Gustavo Noronha Silva.
314
315         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
316
317         * gtk/jhbuild-optional.modules:
318
319 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
320
321         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
322         https://bugs.webkit.org/show_bug.cgi?id=89875
323
324         Reviewed by Maciej Stachowiak.
325
326         Add unit tests to verify if the handling of the open, openat, creat syscall
327         is being done right. We check if the Read/Write/ReadAndWrite permissions
328         are respected, if the canonical path is being resolved and if
329         the permissions are falling back to the topmost parent directory with a
330         policy set when the directory being opened has no policy.
331
332         We also test if any attempt of blocking SIGSYS is silently ignored.
333         SIGSYS cannot be blocked because in it's handler is where we hook
334         syscalls to the broker process.
335
336         Also added libseccomp to EFL's jhbuild to make the life of developers
337         willing to help easier.
338
339         * Scripts/webkitperl/FeatureList.pm:
340         * TestWebKitAPI/PlatformEfl.cmake:
341         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
342         (TestWebKitAPI):
343         (SeccompEnvironment):
344         (TestWebKitAPI::SeccompEnvironment::SetUp):
345         (TestWebKitAPI::SeccompEnvironment::TearDown):
346         (TestWebKitAPI::dummyHandler):
347         (TestWebKitAPI::TEST):
348         (TestWebKitAPI::stressTest):
349         * efl/jhbuild.modules:
350         * qmake/mkspecs/features/features.pri:
351
352 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
353
354         REGRESSION: Autocorrection doesn't work in DumpRenderTree
355         https://bugs.webkit.org/show_bug.cgi?id=113846
356
357         Reviewed by Alexey Proskuryakov.
358
359         The problem was that we were replacing NSSpellCheck's dictionary with our own
360         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
361
362         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
363         and "would" respectively in DumpRenderTree.
364
365         * DumpRenderTree/mac/DumpRenderTree.mm:
366         (resetDefaultsToConsistentValues):
367
368 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
369
370         Remove the gyp files for Tools
371         https://bugs.webkit.org/show_bug.cgi?id=114248
372
373         Reviewed by Ryosuke Niwa.
374
375         * DumpRenderTree/DumpRenderTree.gyp: Removed.
376         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
377         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
378         * DumpRenderTree/DumpRenderTree.gypi: Removed.
379         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
380         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
381         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
382         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
383
384 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
385
386         WKR (new-commit-bot) is too slow
387         https://bugs.webkit.org/show_bug.cgi?id=110087
388
389         Reviewed by Geoffrey Garen.
390
391         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
392         Just run "svn log -r <revision>" instead to cut down the delay.
393
394         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
395
396         * Scripts/webkitpy/tool/commands/newcommitbot.py:
397         (NewCommitBot):
398         (NewCommitBot.next_work_item):
399         (NewCommitBot._is_empty_log):
400         (NewCommitBot._update_checkout):
401
402 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
403
404         Build fix. Can't remove appendCustomBuildFlags.
405
406         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
407         (appendCustomBuildFlags):
408
409 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
410
411         Remove Chromium builders from build.webkit.org
412         https://bugs.webkit.org/show_bug.cgi?id=113990
413
414         Reviewed by Benjamin Poulain.
415
416         Removed.
417
418         * BuildSlaveSupport/build.webkit.org-config/config.json:
419         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
420         (InstallGtkDependencies):
421         (RunUnitTests.start):
422         (RunWebKit2Tests.start):
423         (Factory.__init__):
424         (unitTestsSupported):
425         (TestFactory.__init__):
426         (BuildAndTestFactory.__init__):
427         (BuildAndPerfTestFactory.__init__):
428         (BuildAndPerfTestWebKit2Factory.__init__):
429         (DownloadAndPerfTestFactory.__init__):
430         (loadBuilderConfig):
431         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
432
433 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
434
435         Remove HTML Notification
436         https://bugs.webkit.org/show_bug.cgi?id=114231
437
438         Reviewed by Ryosuke Niwa.
439
440         * qmake/mkspecs/features/features.pri:
441
442 2013-04-08  Glenn Adams  <glenn@skynav.com>
443
444         Remove chromium EWS support, and fix broken test.
445         https://bugs.webkit.org/show_bug.cgi?id=114221
446
447         Reviewed by Ryosuke Niwa.
448
449         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
450         (AbstractChromiumEWS): Removed.
451         (ChromiumLinuxEWS): Removed.
452         (ChromiumLinuxDebugEWS): Removed.
453         (ChromiumWindowsEWS): Removed.
454         (ChromiumAndroidEWS): Removed.
455         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
456         (EarlyWarningSystemTest): Fix misspelled class name.
457         (test_ewses): Fix entry point name to ensure test is run.
458
459 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
460
461         [WIN] Remove WebKit2 source code
462         https://bugs.webkit.org/show_bug.cgi?id=114096
463
464         Reviewed by Anders Carlsson.
465
466         Remove the windows specific parts of the MiniBrowser.
467
468         * MiniBrowser/MiniBrowser.vcproj: Removed.
469         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
470         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
471         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
472         * MiniBrowser/win/BrowserView.cpp: Removed.
473         * MiniBrowser/win/BrowserView.h: Removed.
474         * MiniBrowser/win/BrowserWindow.cpp: Removed.
475         * MiniBrowser/win/BrowserWindow.h: Removed.
476         * MiniBrowser/win/MiniBrowser.cpp: Removed.
477         * MiniBrowser/win/MiniBrowser.h: Removed.
478         * MiniBrowser/win/MiniBrowser.rc: Removed.
479         * MiniBrowser/win/main.cpp: Removed.
480         * MiniBrowser/win/resource.h: Removed.
481         * MiniBrowser/win/stdafx.cpp: Removed.
482         * MiniBrowser/win/stdafx.h: Removed.
483
484 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
485
486         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
487
488         * Scripts/webkitpy/common/config/irc.py:
489
490 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
491
492         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
493         https://bugs.webkit.org/show_bug.cgi?id=113139
494
495         Reviewed by Anders Carlsson.
496
497         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
498         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
499         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
500         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
501         (ToStringAndValueOfObject):
502         (ToStringAndValueOfObject::ToStringAndValueOfObject):
503         (ScriptableObject):
504         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
505         (ToStringAndValueOfObject::ScriptableObject::invoke):
506         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
507         (ToStringAndValueOfObject::NPP_GetValue):
508         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
509         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
510         * GNUmakefile.am:
511
512 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
513
514         [GTK] Bump gnome-themes-standard to 3.6.0
515         https://bugs.webkit.org/show_bug.cgi?id=114155
516
517         Reviewed by Martin Robinson.
518
519         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
520         dependency of gnome-themes-standard accordingly.
521
522 2013-04-08  David Levin  <levin@chromium.org>
523
524         Remove my watchlist entries.
525         https://bugs.webkit.org/show_bug.cgi?id=114180
526
527         Reviewed by Adam Barth.
528
529         * Scripts/webkitpy/common/config/committers.py:
530         * Scripts/webkitpy/common/config/watchlist:
531
532 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
533
534         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
535         https://bugs.webkit.org/show_bug.cgi?id=114161
536
537         Reviewed by Gyuyoung Kim.
538
539         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
540         as it is crashing due to Bug 111074.
541
542         * TestWebKitAPI/PlatformEfl.cmake:
543
544 2013-04-07  David Kilzer  <ddkilzer@apple.com>
545
546         Remove the rest of SVG_DOM_OBJC_BINDINGS
547         <http://webkit.org/b/114112>
548
549         Reviewed by Geoffrey Garen.
550
551         * Scripts/webkitperl/FeatureList.pm:
552         - Remove --svg-dom-objc-bindings switch.
553         * qmake/mkspecs/features/features.pri:
554         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
555
556 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
557
558         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
559         https://bugs.webkit.org/show_bug.cgi?id=114089
560
561         Reviewed by Chris Fleizach.
562
563         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
564         * DumpRenderTree/AccessibilityController.cpp:
565         * DumpRenderTree/AccessibilityUIElement.cpp:
566         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
567         (DumpRenderTreeChrome::DumpRenderTreeChrome):
568         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
569         (DumpRenderTreeChrome):
570
571 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
572
573         Build fix after r147857, remove remaining USE(JSC) guards.
574
575         Unreviewed.
576
577         * DumpRenderTree/config.h:
578         * TestWebKitAPI/config.h:
579         * WebKitTestRunner/config.h:
580
581 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
582
583         Rename sheriffbot to webkitbot
584         https://bugs.webkit.org/show_bug.cgi?id=114109
585
586         Reviewed by Benjamin Poulain.
587
588         Renamed since sheriffbot will be used in Blink.
589
590         * Scripts/webkitpy/tool/commands/sheriffbot.py:
591         (SheriffBot):
592         (SheriffBot.begin_work_queue):
593
594 2013-04-06  Oliver Hunt  <oliver@apple.com>
595
596         Unify the many and varied stack trace mechanisms, and make the result sane.
597         https://bugs.webkit.org/show_bug.cgi?id=114072
598
599         Reviewed by Filip Pizlo.
600
601         The commandline jsc executable no longer requires arguments, so
602         I've made run-jsc work without them.
603
604         * Scripts/run-jsc:
605
606 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
607
608         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
609         https://bugs.webkit.org/show_bug.cgi?id=114086
610
611         Reviewed by Tim Horton.
612
613         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
614
615 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
616
617         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
618         https://bugs.webkit.org/show_bug.cgi?id=114083
619
620         Reviewed by Ryosuke Niwa.
621
622         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
623         in TestWebKitAPI and WebKitTestRunner.
624
625         * TestWebKitAPI/config.h:
626         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
627         (TestWebKitAPI::InjectedBundleController::platformInitialize):
628         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
629         (WTR::InjectedBundle::platformInitialize):
630
631 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
632
633         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
634         https://bugs.webkit.org/show_bug.cgi?id=114094
635
636         Reviewed by Anders Carlsson.
637
638         * Scripts/run-jsc:
639
640 2013-04-05  Ojan Vafai  <ojan@chromium.org>
641
642         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
643         https://bugs.webkit.org/show_bug.cgi?id=114080
644
645         Reviewed by Ryosuke Niwa.
646
647         This way, the WebKit and Blink dashboard code can change as appropriate without
648         needing to consider the other project's needs. This still doesn't update the
649         buildbots to upload to the new location, or the dashboard code to pull the
650         results.json files from the new location, but it at least allows for changing the
651         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
652
653         * TestResultServer/app.yaml:
654
655 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
656
657         Re-enable testing on the commit queue
658         https://bugs.webkit.org/show_bug.cgi?id=114078
659
660         Reviewed by Darin Adler.
661
662         Re-enabled the feature and the associated tests.
663
664         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
665         (CommitQueueTask.run):
666         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
667         (CommitQueueTaskTest._run_through_task):
668         * Scripts/webkitpy/tool/commands/queues_unittest.py:
669         (CommitQueueTest._mock_test_result):
670
671 2013-04-05  Oliver Hunt  <oliver@apple.com>
672
673         Unify the many and varied stack trace mechanisms, and make the result sane.
674         https://bugs.webkit.org/show_bug.cgi?id=114072
675
676         Reviewed by Filip Pizlo.
677
678         The commandline jsc executable no longer requires arguments, so
679         I've made run-jsc work without them.
680
681         * Scripts/run-jsc:
682
683 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
684
685         AX: Make SVG Group containers accessible elements
686         https://bugs.webkit.org/show_bug.cgi?id=113939
687
688         Reviewed by Simon Fraser.
689
690         Implement axController.elementAtPoint for iOS.
691         Implement a correct version of clickPoint for iOS.
692
693         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
694         (AccessibilityController::elementAtPoint):
695         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
696         (AccessibilityUIElement::clickPointX):
697         (AccessibilityUIElement::clickPointY):
698
699 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
700
701         Unreviewed, rolling out r147773 and r147774.
702         http://trac.webkit.org/changeset/147773
703         http://trac.webkit.org/changeset/147774
704         https://bugs.webkit.org/show_bug.cgi?id=114056
705
706         Causing some exceptions on AppEngine I don't understand
707         (Requested by rniwa on #webkit).
708
709         * QueueStatusServer/config/queues.py:
710         * QueueStatusServer/model/queues.py:
711         (Queue.short_name):
712         (Queue.display_name):
713         * QueueStatusServer/model/queues_unittest.py:
714         (QueueTest.test_short_name):
715         (QueueTest.test_display_name):
716         (QueueTest.test_name_with_underscores):
717
718 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
719
720         Fixed run-bindings-tests by removing V8
721         https://bugs.webkit.org/show_bug.cgi?id=114053
722
723         Reviewed by Benjamin Poulain.
724
725         * Scripts/run-bindings-tests:
726         (main):
727
728 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
729
730         Build fix.
731
732         * QueueStatusServer/model/queues.py:
733         (Queue.short_name):
734         (Queue.display_name):
735
736 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
737
738         Remove Chromium EWS bots from the queue status server
739         https://bugs.webkit.org/show_bug.cgi?id=113988
740
741         Reviewed by Benjamin Poulain.
742
743         Removed Chromium EWS bots.
744
745         * QueueStatusServer/config/queues.py:
746         * QueueStatusServer/model/queues.py:
747         (Queue.short_name):
748         (Queue.display_name):
749         * QueueStatusServer/model/queues_unittest.py:
750         (QueueTest.test_short_name):
751         (QueueTest.test_display_name):
752         (QueueTest.test_name_with_underscores):
753
754 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
755
756         [EFL] Enable indexed database
757         https://bugs.webkit.org/show_bug.cgi?id=107248
758
759         Reviewed by Alexis Menard.
760
761         * Scripts/webkitperl/FeatureList.pm:
762
763 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
764
765         Remove vestiges of Chromium bits from watchlists.
766         https://bugs.webkit.org/show_bug.cgi?id=114047
767
768         Reviewed by Ryosuke Niwa.
769
770         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
771
772 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
773
774         Add James Craig to the contributors list.
775
776         * Scripts/webkitpy/common/config/committers.py:
777
778 2013-04-04  Kent Tamura  <tkent@chromium.org>
779
780         Remove ChromiumPublicApi pattern, and cc/message rules for it.
781
782         * Scripts/webkitpy/common/config/watchlist:
783
784 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
785
786         Temporarily disable the Python unittests broken by the commit queue not running layout tests
787         https://bugs.webkit.org/show_bug.cgi?id=113997
788
789         Reviewed by Ryosuke Niwa.
790
791         Disable the tests until Ryosuke gets the time and hardware to have
792         a testing commit-queue.
793
794         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
795         (CommitQueueTaskTest):
796         * Scripts/webkitpy/tool/commands/queues_unittest.py:
797         (CommitQueueTest):
798
799 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
800
801         Remove Chromium builders from build.webkit.org
802         https://bugs.webkit.org/show_bug.cgi?id=113990
803
804         Reviewed by Benjamin Poulain.
805
806         Land the part to disable triggering of Chromium builders first so that we may start
807         deleting more Chromium code that breaks the update step.
808
809         * BuildSlaveSupport/build.webkit.org-config/config.json:
810
811 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
812
813         Remove Chromium's DumpRenderTree
814         https://bugs.webkit.org/show_bug.cgi?id=113989
815
816         Reviewed by Kent Tamura.
817
818         On second thought, let's not go to Camelot. It is a silly place.
819
820         * DumpRenderTree/mac/DumpRenderTree.mm:
821         (resetDefaultsToConsistentValues):
822
823 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
824
825         Nixed the defunct chromium folder from DumpRenderTree
826         https://bugs.webkit.org/show_bug.cgi?id=113993
827
828         Reviewed by Ryosuke Niwa.
829
830         * DumpRenderTree/chromium: Removed.
831         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
832         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
833         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
834         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
835         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
836         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
837         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
838         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
839         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
840         * DumpRenderTree/chromium/MockPlatform.h: Removed.
841         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
842         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
843         * DumpRenderTree/chromium/Task.cpp: Removed.
844         * DumpRenderTree/chromium/Task.h: Removed.
845         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
846         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
847         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
848         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
849         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
850         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
851         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
852         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
853         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
854         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
855         * DumpRenderTree/chromium/TestRunner: Removed.
856         * DumpRenderTree/chromium/TestRunner/public: Removed.
857         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
858         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
859         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
860         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
861         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
862         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
863         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
864         * DumpRenderTree/chromium/TestRunner/src: Removed.
865         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
866         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
867         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
868         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
869         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
870         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
871         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
872         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
873         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
874         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
875         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
876         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
877         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
878         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
879         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
880         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
881         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
882         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
883         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
884         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
885         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
886         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
887         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
888         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
889         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
890         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
891         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
892         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
893         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
894         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
895         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
896         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
897         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
898         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
899         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
900         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
901         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
902         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
903         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
904         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
905         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
906         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
907         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
908         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
909         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
910         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
911         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
912         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
913         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
914         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
915         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
916         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
917         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
918         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
919         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
920         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
921         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
922         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
923         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
924         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
925         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
926         * DumpRenderTree/chromium/TestShell.cpp: Removed.
927         * DumpRenderTree/chromium/TestShell.h: Removed.
928         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
929         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
930         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
931         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
932         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
933         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
934         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
935         * DumpRenderTree/chromium/WebViewHost.h: Removed.
936         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
937         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
938         * DumpRenderTree/chromium/config.h: Removed.
939         * DumpRenderTree/chromium/fonts.conf: Removed.
940
941 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
942
943         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
944
945         Rubber stamped by Benjamin Poulain.
946
947         * RebaselineQueueServer: Removed.
948         * RebaselineQueueServer/app.yaml: Removed.
949         * RebaselineQueueServer/handlers: Removed.
950         * RebaselineQueueServer/handlers/__init__.py: Removed.
951         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
952         * RebaselineQueueServer/handlers/pages.py: Removed.
953         * RebaselineQueueServer/index.yaml: Removed.
954         * RebaselineQueueServer/main.py: Removed.
955         * RebaselineQueueServer/model: Removed.
956         * RebaselineQueueServer/model/__init__.py: Removed.
957         * RebaselineQueueServer/model/queueentry.py: Removed.
958         * RebaselineQueueServer/static: Removed.
959         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
960         * RebaselineQueueServer/static/styles.css: Removed.
961         * RebaselineQueueServer/templates: Removed.
962         * RebaselineQueueServer/templates/builder-picker.html: Removed.
963         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
964         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
965         * RebaselineQueueServer/templates/home.html: Removed.
966
967 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
968
969         Fix setup-commit-queue and temporarily disable testing on commit-queue
970         https://bugs.webkit.org/show_bug.cgi?id=113979
971
972         Reviewed by Benjamin Poulain.
973
974         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
975         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
976
977         * EWSTools/setup-commit-queue.sh:
978         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
979         (CommitQueueTask.run):
980
981 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
982
983         temporarily make flakiness dashboard work again webkit.org bots
984         https://bugs.webkit.org/show_bug.cgi?id=113972
985
986         Reviewed by Ojan Vafai.
987
988         This patch disables the chromium.org layout test bots TestExpectations
989         parsing temporarily until we can work out the right way to split into
990         two instances for webkit.org and chromium.org and figure out which
991         code to delete where :).
992
993         * TestResultServer/static-dashboards/flakiness_dashboard.js:
994
995 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
996
997         Fix webkitpy tests after r147678.
998
999         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1000         (CommitQueueTest.test_commit_queue):
1001         (test_manual_reject_during_processing):
1002
1003 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1004
1005         The commit queue should use Mac MountainLion port
1006         https://bugs.webkit.org/show_bug.cgi?id=113971
1007
1008         Reviewed by Lucas Forschler.
1009
1010         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1011         * Scripts/webkitpy/tool/commands/queues.py:
1012         (CommitQueue):
1013
1014 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1015
1016         turn off running tests on chromium linux EWS bots
1017         https://bugs.webkit.org/show_bug.cgi?id=113959
1018
1019         Reviewed by Geoffrey Garen.
1020
1021         Now that the Chromium port is no longer being maintained
1022         there's little point in running the tests. Soon we should
1023         just shut this bot off altogether.
1024
1025         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1026         (ChromiumLinuxEWS):
1027
1028 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1029
1030         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1031
1032         * Scripts/webkitpy/common/config/watchlist:
1033
1034 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1035
1036         Indentation fix to get webkit-patch working again after r147625
1037
1038         Unreviewed.
1039
1040         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1041         (MacEWS):
1042         (MacWK2EWS):
1043
1044 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1045
1046         Turn tests back on for Mac WK1/WK2 EWS.
1047         
1048         Unreviewed.
1049         
1050         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1051         (MacEWS):
1052         (MacWK2EWS):
1053
1054 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1055
1056         [GTK][WK2] MiniBrowser custom URI scheme support
1057         https://bugs.webkit.org/show_bug.cgi?id=112419
1058
1059         Reviewed by Carlos Garcia Campos.
1060
1061         Add support for about URIs in MiniBrowser. An example about page is show
1062         with URI "about:minibrowser", the rest of the cases it will show a
1063         proper message explaining that the about page didn't exist.
1064
1065         Internally it uses "minibrowser-about" prefix instead of "about", but
1066         from the user point of view it works with "about" prefix.
1067
1068         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1069         (getInternalURI): Method to convert URIs from "about" prefix to
1070         "minibrowser-about".
1071         (getExternalURI): Opposite method.
1072         (webViewURIChanged): Use "about" prefix to show the URI to users.
1073         (webViewEnterFullScreen): Ditto.
1074         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1075         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1076         (aboutURISchemeRequestCallback): Callback to manage about calls.
1077         (main): Register the URI scheme to manage about URIs.
1078
1079 2013-04-03  Roger Fong  <roger_fong@apple.com>
1080
1081         Re-enable WinEWS tests.
1082
1083         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1084         (WinEWS):
1085
1086 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1087
1088         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1089         https://bugs.webkit.org/show_bug.cgi?id=113883
1090
1091         Reviewed by Martin Robinson.
1092
1093         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1094         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1095         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1096
1097 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1098
1099         [GTK] Include Pango in jhbuild-optional.modules
1100         https://bugs.webkit.org/show_bug.cgi?id=113878
1101
1102         Reviewed by Martin Robinson.
1103
1104         Since r147547 Pango 1.32.0 is required. Including the module in the
1105         JHBuild optional moduleset.
1106
1107         * gtk/jhbuild-optional.modules: Add Pango module.
1108
1109 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1110
1111         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1112         https://bugs.webkit.org/show_bug.cgi?id=113864
1113
1114         Moving setDefersLoading from TestRunnerQt to TestRunner
1115         requires access to the non-Qt TestRunner.
1116         As long as we instantiate both TestRunner and TestRunnerQt,
1117         we need a separate getter for the non-Qt TestRunner instance.
1118
1119         Reviewed by Simon Hausmann.
1120
1121         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1122         (WebPage::resetSettings):
1123         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1124         (DumpRenderTree::jscTestRunner):
1125         * DumpRenderTree/qt/TestRunnerQt.cpp:
1126         (TestRunner::setDefersLoading):
1127             Moving setDefersLoading from TestRunnerQt
1128             to TestRunner.
1129         * DumpRenderTree/qt/TestRunnerQt.h:
1130         (TestRunnerQt):
1131
1132 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1133
1134         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1135         https://bugs.webkit.org/show_bug.cgi?id=104779
1136
1137         Reviewed by Carlos Garcia Campos.
1138
1139         * Scripts/run-gtk-tests:
1140         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1141         passing in current trunk.
1142
1143 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1144
1145         Fix HAVE(QTTESTSUPPORT) logic
1146
1147         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1148         resulting in HAVE(QTTESTSUPPORT) never being true.
1149         Move that logic down in sanitizeFeatures.
1150
1151         Rubber-stamped by Tor Arne Vestbø.
1152
1153         * qmake/mkspecs/features/features.prf:
1154
1155 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1156
1157         [GTK] Bump required versions of some dependencies
1158         https://bugs.webkit.org/show_bug.cgi?id=113282
1159
1160         Reviewed by Martin Robinson.
1161
1162         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1163
1164 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1165
1166         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1167         https://bugs.webkit.org/show_bug.cgi?id=113809
1168
1169         Reviewed by Philippe Normand.
1170
1171         Newer Linux kernels have removed some deprecated macros from v4l2
1172         headers, causing gst-plugins-good's build to break. We don't need it
1173         right now, so just disable it.
1174
1175         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1176
1177 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1178
1179         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1180         https://bugs.webkit.org/show_bug.cgi?id=113535
1181
1182         Reviewed by Simon Hausmann.
1183
1184         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1185
1186         * qmake/mkspecs/features/features.prf:
1187
1188 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1189
1190         [Qt] Move logic of simple forwarding functions to TestRunner.
1191         https://bugs.webkit.org/show_bug.cgi?id=113863
1192
1193         Reviewed by Simon Hausmann.
1194
1195         * DumpRenderTree/qt/TestRunnerQt.cpp:
1196         (TestRunner::setTextDirection):
1197         (TestRunner::goBack):
1198         (TestRunner::evaluateScriptInIsolatedWorld):
1199         (TestRunner::addUserStyleSheet):
1200         * DumpRenderTree/qt/TestRunnerQt.h:
1201         (TestRunnerQt):
1202
1203 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1204
1205         [Qt] Disable media support using QuickTime if deployment target != SDK
1206
1207         We link to a single libWebKitSystemInterface static lib, so unless the
1208         deployment target matches the SDK let's not pretend like we'll be able
1209         to run on anything lower than the SDK version.
1210
1211         Reviewed by Simon Hausmann.
1212
1213         * qmake/mkspecs/features/features.prf:
1214
1215 2013-04-02  James Craig  <james@cookiecrook.com>
1216
1217         AXRoleDescripton for DL is "list"; should be "description list"
1218         https://bugs.webkit.org/show_bug.cgi?id=111665
1219
1220         Reviewed by Chris Fleizach.
1221
1222         Defining the role and description strings.
1223
1224         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1225
1226 2013-04-02  Roger Fong  <roger_fong@apple.com>
1227
1228         Unreviewed. Disable running tests on Win EWS queue.
1229
1230         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1231         (WinEWS):
1232
1233 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1234
1235         Disable running tests on the MAC WK2 EWS queue.
1236         
1237         Unreviewed.
1238         
1239         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1240         (MacWK2EWS):
1241
1242 2013-04-02  Julie Parent  <jparent@chromium.org>
1243
1244         Dashboard refactor: Move dashboard specific history related features to History.
1245         https://bugs.webkit.org/show_bug.cgi?id=113717
1246
1247         Reviewed by Ojan Vafai.
1248         
1249         Each dashboard now creates its own History object, with a custom
1250         configuration. This changes from just overriding global functions
1251         to passing in callbacks for generatePage, handleValidHashParameter,
1252         and handleQueryParameterChange. Same with passing in defaultStateValues
1253         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1254         variables.
1255         
1256         All functions related to these features are now (mostly) private
1257         function on History. 
1258         
1259         Loader no longer needs a loadingComplete callback, since it can just
1260         initialize the history object itself.
1261
1262         * TestResultServer/static-dashboards/aggregate_results.js:
1263         (handleValidHashParameter):
1264         * TestResultServer/static-dashboards/dashboard_base.js:
1265         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1266         (generatePage):
1267         (.switch.return):
1268         (handleQueryParameterChange):
1269         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1270         (resetGlobals):
1271         * TestResultServer/static-dashboards/history.js:
1272         (.):
1273         * TestResultServer/static-dashboards/loader.js:
1274         (.):
1275         * TestResultServer/static-dashboards/loader_unittests.js:
1276         * TestResultServer/static-dashboards/timeline_explorer.js:
1277         (generatePage):
1278         (initCurrentBuilderTestResults):
1279         * TestResultServer/static-dashboards/treemap.js:
1280         (generatePage):
1281         (.switch.return):
1282         (handleQueryParameterChange):
1283
1284 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1285
1286         Unreviewed, rolling out r147401.
1287         http://trac.webkit.org/changeset/147401
1288         https://bugs.webkit.org/show_bug.cgi?id=113767
1289
1290         The patch makes it extremely hard to set up the dependencies
1291         properly on the GTK builders (Requested by zdobersek on
1292         #webkit).
1293
1294         * gtk/jhbuild.modules:
1295
1296 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1297
1298         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1299         https://bugs.webkit.org/show_bug.cgi?id=113382
1300
1301         Reviewed by Gyuyoung Kim.
1302
1303         Do not show the empty tooltip box if the text is null.
1304
1305         * MiniBrowser/efl/main.c:
1306         (popup_menu_populate):
1307
1308 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1309
1310         [GTK] Bump required versions of some dependencies
1311         https://bugs.webkit.org/show_bug.cgi?id=113282
1312
1313         Reviewed by Martin Robinson.
1314
1315         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1316
1317 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1318
1319         Unreviewed, rolling out r147319.
1320         http://trac.webkit.org/changeset/147319
1321         https://bugs.webkit.org/show_bug.cgi?id=113707
1322
1323         The unit test is still failing on the buildbot (Requested by
1324         zdobersek on #webkit).
1325
1326         * Scripts/run-gtk-tests:
1327         (TestRunner):
1328
1329 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1330
1331         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1332         https://bugs.webkit.org/show_bug.cgi?id=104779
1333
1334         Reviewed by Carlos Garcia Campos.
1335
1336         * Scripts/run-gtk-tests:
1337         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1338         passing in current trunk.
1339
1340 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1341
1342         Unreviewed, rolling out r147289.
1343         http://trac.webkit.org/changeset/147289
1344         https://bugs.webkit.org/show_bug.cgi?id=113678
1345
1346         broke Win7 (dbg) build (Requested by shinyak|gardener on
1347         #webkit).
1348
1349         * DumpRenderTree/DumpRenderTree.gypi:
1350         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1351         (WebTestRunner):
1352         (WebUserMediaClientMock):
1353         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1354         (WebTestRunner::WebUserMediaClientMock::taskList):
1355         * Scripts/webkitpy/style/checkers/cpp.py:
1356         (check_function_definition):
1357
1358 2013-03-31  Adam Barth  <abarth@webkit.org>
1359
1360         configure-svn-config.sh fails
1361         https://codereview.chromium.org/13392007/
1362
1363         Reviewed by Eric Seidel.
1364
1365         This script was trying to use "svn checkout" to dowload a file from
1366         svn.webkit.org, but "svn checkout" only works with directories.
1367         Instead, we should use "svn export".
1368
1369         * EWSTools/configure-svn-config.sh:
1370
1371 2013-03-31  Wei Jia  <wjia@chromium.org>
1372
1373         Allow WebUserMediaClientMock to be used by client
1374         https://bugs.webkit.org/show_bug.cgi?id=113633
1375
1376         Reviewed by Adam Barth.
1377
1378         Export WebUserMediaClientMock.
1379         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1380
1381         * DumpRenderTree/DumpRenderTree.gypi:
1382         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1383         (WebUserMediaClientMock):
1384         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1385         * Scripts/webkitpy/style/checkers/cpp.py:
1386         (check_function_definition):
1387
1388 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1389
1390         Expose FeatureObserver data to WebKit clients
1391         https://bugs.webkit.org/show_bug.cgi?id=113613
1392
1393         Reviewed by Sam Weinig.
1394
1395         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1396         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1397
1398 2013-03-29  Greg Hughes  <ghughes@apple.com>
1399
1400         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1401         https://bugs.webkit.org/show_bug.cgi?id=112276
1402
1403         Reviewed by Chris Fleizach.
1404
1405         Added support to test accessibility search predicates with multiple keys.  
1406
1407         * DumpRenderTree/AccessibilityUIElement.cpp:
1408         (uiElementForSearchPredicateCallback):
1409         * DumpRenderTree/AccessibilityUIElement.h:
1410         (AccessibilityUIElement):
1411         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1412         (AccessibilityUIElement::uiElementForSearchPredicate):
1413         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1414         (AccessibilityUIElement::uiElementForSearchPredicate):
1415         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1416         (AccessibilityUIElement::uiElementForSearchPredicate):
1417         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1418         (AccessibilityUIElement::uiElementForSearchPredicate):
1419         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1420         (AccessibilityUIElement::uiElementForSearchPredicate):
1421         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1422         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1423         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1424         (AccessibilityUIElement):
1425         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1426         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1427         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1428         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1429         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1430
1431 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1432
1433         Fix a typo in r147147 to fix Mac EWS.
1434
1435         * Scripts/webkitpy/tool/commands/queues.py:
1436         (PatchProcessingQueue._new_port_name_from_old):
1437
1438 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1439
1440         [EFL] Build break with latest EFL libraries after r146265
1441         https://bugs.webkit.org/show_bug.cgi?id=113558
1442
1443         Unreviewed build fix.
1444
1445         * TestWebKitAPI/PlatformWebView.h:
1446         * WebKitTestRunner/PlatformWebView.h:
1447
1448 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1449
1450         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1451
1452         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1453         in libgcrypt build.
1454
1455 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1456
1457         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1458
1459         Unreviewed.
1460
1461         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1462         (MacEWS):
1463
1464 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1465
1466         Use the right OS name on Mac EWS instead of mac-future.
1467
1468         Rubber-stamped by Dirk Pranke.
1469
1470         * Scripts/webkitpy/tool/commands/queues.py:
1471         (PatchProcessingQueue._new_port_name_from_old):
1472         (PatchProcessingQueue.begin_work_queue):
1473         (PatchProcessingQueue._upload_results_archive_for_patch):
1474
1475 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1476
1477         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1478         https://bugs.webkit.org/show_bug.cgi?id=112546
1479
1480         Reviewed by Martin Robinson.
1481
1482         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1483         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1484
1485 2013-03-28  Ming Xie  <mxie@blackberry.com>
1486
1487         [BlackBerry] Committer Email Updates
1488         https://bugs.webkit.org/show_bug.cgi?id=113435
1489
1490         Reviewed by Rob Buis.
1491
1492         Add the @blackberry.com email address for all our BlackBerry
1493         WebKit committers. This is the first step for our email address
1494         migration.
1495
1496         * Scripts/webkitpy/common/config/committers.py:
1497
1498 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1499
1500         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1501         https://bugs.webkit.org/show_bug.cgi?id=113508
1502
1503         Reviewed by Martin Robinson.
1504
1505         Prevent the GStreamer plugin scanner to load system-wide
1506         plugins. Only the ones built in JHBuild should be loaded and used
1507         at runtime.
1508
1509         * efl/jhbuildrc:
1510         * gtk/jhbuildrc:
1511
1512 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1513
1514         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1515         https://bugs.webkit.org/show_bug.cgi?id=113386
1516
1517         Reviewed by Carlos Garcia Campos.
1518
1519         * Scripts/webkitdirs.pm:
1520         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1521         version to 3.0. Reflect this change so the builtDylibPathForName
1522         function doesn't fail to report the library as found.
1523
1524 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1525
1526         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1527         https://bugs.webkit.org/show_bug.cgi?id=113484
1528
1529         Unreviewed build fix.
1530
1531         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1532
1533         * TestWebKitAPI/CMakeLists.txt:
1534         * WebKitTestRunner/CMakeLists.txt:
1535
1536 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1537
1538         Revision for the internal jhbuild is too old
1539         https://bugs.webkit.org/show_bug.cgi?id=113324
1540
1541         Reviewed by Martin Robinson.
1542
1543         Update the minimum required version to a point where jhbuild won't
1544         fail installing packages when trying to remove a symlink to a directory.
1545
1546         * jhbuild/jhbuild-wrapper: Updated revision.
1547
1548 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1549
1550         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1551         https://bugs.webkit.org/show_bug.cgi?id=113203
1552
1553         Reviewed by Philippe Normand.
1554
1555         We build our libsoup without GNOME support. gst-plugins-good does separate
1556         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1557         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1558         build failures as the headers of those diverge. We do not use souphttpsrc, so
1559         disable it when building gst-plugins-good.
1560
1561         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1562
1563 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1564
1565         Build fix after r146852. Please another reference to the Lion leaks builder.
1566
1567         * BuildSlaveSupport/build.webkit.org-config/config.json:
1568
1569 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1570
1571         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1572         https://bugs.webkit.org/show_bug.cgi?id=113421
1573
1574         Reviewed by Dirk Pranke.
1575
1576         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1577         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1578         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1579         in the GTK-specific TestExpectations files.
1580
1581         To avoid this only enable the warnings only when not using WKTR.
1582
1583         * Scripts/webkitpy/layout_tests/port/gtk.py:
1584         (GtkPort.warn_if_bug_missing_in_test_expectations):
1585
1586 2013-03-27  Antti Koivisto  <antti@apple.com>
1587
1588         Fix Zalan's email.
1589
1590         * Scripts/webkitpy/common/config/committers.py:
1591
1592 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1593
1594         master.cfg cleanup
1595         https://bugs.webkit.org/show_bug.cgi?id=113195
1596
1597         Reviewed by Ryosuke Niwa.
1598
1599         * BuildSlaveSupport/build.webkit.org-config/config.json:
1600         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1601
1602 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1603
1604         master.cfg fine-tuning for Qt Mountain Lion Release bot
1605         https://bugs.webkit.org/show_bug.cgi?id=113191
1606
1607         Reviewed by Ryosuke Niwa.
1608
1609         * BuildSlaveSupport/build.webkit.org-config/config.json:
1610           - Rename the slave due to its location change.
1611           - Update the platform of the slave.
1612         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1613         (RunQtAPITests): Enable running WK2 API tests on Qt.
1614         (RunQtAPITests.start):
1615         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1616         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1617
1618 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1619
1620         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1621         https://bugs.webkit.org/show_bug.cgi?id=113403
1622
1623         Reviewed by Kenneth Rohde Christiansen.
1624
1625         As of Evas 1.7.5, when Wayland is detected on the system, support for
1626         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1627         The code, however, seems to depend on a few other flags which must be
1628         explicitly enabled.
1629
1630         If those additional GL-related options are passed, we end up
1631         having issues on the WebKit side, so disable Wayland support for
1632         now.
1633
1634         * efl/jhbuild.modules:
1635
1636 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1637
1638         Unreviewed, rolling out r146864.
1639         http://trac.webkit.org/changeset/146864
1640         https://bugs.webkit.org/show_bug.cgi?id=113391
1641
1642         causes crashes on Wk2 EFL release bot (Requested by drott on
1643         #webkit).
1644
1645         * Scripts/webkitperl/FeatureList.pm:
1646
1647 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1648
1649         [jhbuild] Correctly specify an alternate number of make jobs.
1650         https://bugs.webkit.org/show_bug.cgi?id=113396
1651
1652         Reviewed by Philippe Normand.
1653
1654         So far, we were using the `MAKEFLAGS' environment variable to pass the
1655         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1656         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1657
1658         We now behave more closely to the rest of the WebKit tools by first
1659         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1660         not set, just letting jhbuild itself figure out how many jobs to use.
1661
1662         * efl/jhbuildrc:
1663         * gtk/jhbuildrc:
1664
1665 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1666
1667         [Qt] Remove Qt specific WorkQueueItem definitions.
1668         https://bugs.webkit.org/show_bug.cgi?id=112891
1669
1670         This patch is preparation work for removing
1671         WorkQueue related code from TestRunnerQt and
1672         replacing it with generic TestRunner code.
1673
1674         Reviewed by Benjamin Poulain.
1675
1676         * DumpRenderTree/qt/TestRunnerQt.cpp:
1677         (TestRunnerQt::queueBackNavigation):
1678         (TestRunnerQt::queueForwardNavigation):
1679         (TestRunnerQt::queueLoadHTMLString):
1680         (TestRunnerQt::queueReload):
1681         (TestRunnerQt::queueLoadingScript):
1682         (TestRunnerQt::queueNonLoadingScript):
1683         (TestRunner::queueLoad):
1684         * DumpRenderTree/qt/TestRunnerQt.h:
1685         (TestRunnerQt):
1686         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1687         (LoadItem::invoke):
1688         (LoadHTMLStringItem::invoke):
1689         (LoadAlternateHTMLStringItem::invoke):
1690         (ReloadItem::invoke):
1691         (ScriptItem::invoke):
1692         (BackForwardItem::invoke):
1693         * DumpRenderTree/qt/WorkQueueItemQt.h:
1694         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1695         (LoadAlternateHTMLStringItem):
1696
1697 2013-03-26  Julie Parent  <jparent@chromium.org>
1698
1699         Flakiness dashboard: simplify logic around which tests to show.
1700         https://bugs.webkit.org/show_bug.cgi?id=113250
1701
1702         Reviewed by Ojan Vafai.
1703         
1704         The different filters for showing results are only used for layout
1705         tests, otherwise, we show everything.
1706         
1707         Change the defaults to false (what layout tests used), and only
1708         look at the values when viewing layout tests.
1709
1710         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1711         (htmlForTestsWithExpectationsButNoFailures):
1712         (shouldHideTest):
1713
1714 2013-03-26  Isaac Levy  <ilevy@google.com>
1715
1716         Update bots on test-results.appspot
1717         https://bugs.webkit.org/show_bug.cgi?id=113333
1718
1719         Reviewed by Ojan Vafai.
1720
1721         * TestResultServer/static-dashboards/builders.jsonp:
1722
1723 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1724
1725         Unreviewed GTK gardening.
1726
1727         * Scripts/run-gtk-tests:
1728         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1729
1730 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1731
1732         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1733         https://bugs.webkit.org/show_bug.cgi?id=113287
1734
1735         Reviewed by Jocelyn Turcotte.
1736
1737         * Scripts/run-qtwebkit-tests:
1738         (Options.__init__):
1739
1740 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1741
1742         [EFL] Enable IndexedDB by default
1743         https://bugs.webkit.org/show_bug.cgi?id=107248
1744
1745         Reviewed by Laszlo Gombos.
1746
1747         * Scripts/webkitperl/FeatureList.pm:
1748         Enable IndexedDB by default on EFL.
1749
1750 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1751
1752         Sheriffbot should explain rollout failures in a human readable form.
1753         https://bugs.webkit.org/show_bug.cgi?id=107092
1754
1755         Reviewed by Ryosuke Niwa.
1756
1757         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1758
1759         * Scripts/webkitpy/tool/bot/irc_command.py:
1760         (Rollout._check_diff_failure):
1761         (Rollout.execute):
1762         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1763         (IRCCommandTest.test_rollout):
1764
1765 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1766
1767         Unreviewed GTK gardening.
1768
1769         * Scripts/run-gtk-tests:
1770         (TestRunner): Skipping a failing unit test after r146518.
1771
1772 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1773
1774         Remove Lion leaks builder
1775         https://bugs.webkit.org/show_bug.cgi?id=113252
1776
1777         Reviewed by Andreas Kling.
1778
1779         Removed.
1780
1781         * BuildSlaveSupport/build.webkit.org-config/config.json:
1782
1783 2013-03-25  Kent Tamura  <tkent@chromium.org>
1784
1785         Rename ENABLE_INPUT_TYPE_DATETIME
1786         https://bugs.webkit.org/show_bug.cgi?id=113254
1787
1788         Reviewed by Kentaro Hara.
1789
1790         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1791         Actually I'd like to remove the code, but we shouldn't remove it yet
1792         because we shipped products with it on some platforms.
1793
1794         * Scripts/webkitperl/FeatureList.pm:
1795         * qmake/mkspecs/features/features.pri:
1796
1797 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1798
1799         Remove one more line that was intended to be removed in r146657.
1800
1801         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1802         (summarize_results):
1803
1804 2013-03-25  Roger Fong  <roger_fong@apple.com>
1805
1806         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1807         Re-enable WinEWS tests.
1808
1809         * Scripts/webkitpy/common/config/ports.py:
1810         (WinPort.run_bindings_tests_command):
1811         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1812         (WinEWS):
1813
1814 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1815
1816         Unreviewed, rolling out r146793.
1817         http://trac.webkit.org/changeset/146793
1818         https://bugs.webkit.org/show_bug.cgi?id=113248
1819
1820         Fix did not work (Requested by rfong on #webkit).
1821
1822         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1823         (WinEWS):
1824
1825 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1826
1827         REGRESSION(r146657): Test failures reported incorrectly
1828         https://bugs.webkit.org/show_bug.cgi?id=113223
1829
1830         Reviewed by Dirk Pranke.
1831
1832         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1833
1834         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1835         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1836
1837         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1838         (Manager.run):
1839
1840         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1841         (RunDetails.__init__):
1842         (summarize_results): Remove the line I intended to remove in r146657.
1843
1844         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1845         (logging_run): Return details instead of the exit code.
1846         (run_and_capture): Ditto.
1847
1848         (RunTest.test_full_results_html):
1849         (RunTest.test_hung_thread):
1850         (RunTest.test_no_tests_found):
1851         (RunTest.test_no_tests_found_2):
1852         (RunTest.test_repeat_each_iterations_num_tests):
1853         (RunTest.test_run_singly_actually_runs_tests):
1854         (RunTest.test_test_list):
1855         (RunTest.test_missing_and_unexpected_results):
1856         (RunTest.test_pixel_test_directories):
1857         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1858         (RunTest.test_crash_with_stderr):
1859         (RunTest.test_no_image_failure_with_image_diff):
1860         (RunTest.test_crash_log):
1861         (RunTest.test_exit_after_n_failures_upload):
1862         (RunTest.test_results_directory_absolute):
1863         (RunTest.test_results_directory_relative):
1864         (RunTest.test_retrying_and_flaky_tests):
1865         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1866         (RunTest.test_retrying_uses_retries_directory):
1867         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1868         (RunTest.test_output_diffs):
1869         (EndToEndTest.test_reftest_with_two_notrefs):
1870         (RebaselineTest.test_reset_results):
1871         (RebaselineTest.test_missing_results):
1872         (RebaselineTest.test_new_baseline):
1873
1874         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1875         (BuildBotPrinter.print_results):
1876         (BuildBotPrinter.print_unexpected_results):
1877         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1878         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1879
1880 2013-03-25  Julie Parent  <jparent@chromium.org>
1881
1882         Dashboard refactor: Move cross dashboard history related code into history.js.
1883         https://bugs.webkit.org/show_bug.cgi?id=113104
1884
1885         Reviewed by Ojan Vafai.
1886
1887         All functions relating to cross dashboard behavior move from being
1888         globals to methods on the history.History object. Names stay the same,
1889         except many are made private, ones that should have been constants now
1890         are, and the long standing TODO to change "currentState" to 
1891         dashboardSpecificState is done.
1892         
1893         We now create a global history object in dashboard_base, as an 
1894         intermediate measure.  Once the dashboard specific code is
1895         added to history, each DB will need to create its own, and this
1896         global will be eliminated.
1897         
1898         * TestResultServer/static-dashboards/aggregate_results.js:
1899         (handleValidHashParameter):
1900         (htmlForBuilder):
1901         (rawValuesHTML):
1902         * TestResultServer/static-dashboards/dashboard_base.js:
1903         (parseDashboardSpecificParameters):
1904         (defaultValue):
1905         (currentBuilderGroupCategory):
1906         (currentBuilderGroupName):
1907         (handleLocationChange):
1908         (expectationsMap):
1909         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1910         (generatePage):
1911         (.switch.return):
1912         (platformAndBuildType):
1913         (individualTests):
1914         (substringList):
1915         (processMissingAndExtraExpectations):
1916         (pathToFailureLog):
1917         (showPopupForBuild):
1918         (htmlForTestsWithExpectationsButNoFailures):
1919         (shouldHideTest):
1920         (isCrossBuilderView):
1921         (tableHeaders):
1922         (htmlForSingleTestRow):
1923         (htmlForTableColumnHeader):
1924         (generatePageForExpectationsUpdate):
1925         (handleUpdate):
1926         (nextUpdate):
1927         (setUpdateIndex):
1928         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1929         (.appendExpectationsItem):
1930         (loadExpectations):
1931         (.dummyNode.onload):
1932         (loadExpectationsLayoutTests):
1933         (appendExpectations):
1934         (htmlForNavBar):
1935         (checkBoxToToggleState):
1936         (linkHTMLToToggleState):
1937         (generatePageForBuilder):
1938         (isInvalidKeyForCrossBuilderView):
1939         (handleQueryParameterChange):
1940         (showLegend):
1941         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1942         (resetGlobals):
1943         (test):
1944         * TestResultServer/static-dashboards/history.js:
1945         (.):
1946         * TestResultServer/static-dashboards/history_unittests.js:
1947         * TestResultServer/static-dashboards/loader.js:
1948         (.):
1949         * TestResultServer/static-dashboards/loader_unittests.js:
1950         * TestResultServer/static-dashboards/timeline_explorer.js:
1951         (generatePage):
1952         (initCurrentBuilderTestResults):
1953         (selectBuild):
1954         (showResultsDelta):
1955         * TestResultServer/static-dashboards/treemap.js:
1956         (generatePage):
1957         (.switch.return):
1958         (handleFocus):
1959         * TestResultServer/static-dashboards/ui.js:
1960
1961 2013-03-25  Roger Fong  <roger_fong@apple.com>
1962
1963         Unreviewed. Enable WinEWS tests again.
1964
1965         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1966         (WinEWS):
1967
1968 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1969
1970         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1971         https://bugs.webkit.org/show_bug.cgi?id=112166
1972
1973         HarfBuzz 0.9.14 merged my patch for icu detection without
1974         pkg-config files, as needed by for example Ubuntu 12.04.
1975         This obsoletes our local workaround. Removed it for GTK and EFL.
1976
1977         Reviewed by Martin Robinson.
1978
1979         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1980         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1981         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1982         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1983
1984 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1985
1986         Unreviewed.  Move self from contributor to committer list.
1987
1988         * Scripts/webkitpy/common/config/committers.py:
1989
1990 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1991
1992         EWS should use a human readable port name when uploading layout test archives
1993         https://bugs.webkit.org/show_bug.cgi?id=113099
1994
1995         Reviewed by Dirk Pranke.
1996
1997         Use new port's object's name() method to report human readable port names.
1998         This will also help us resolving the bug to apply layout test results posted by EWS.
1999
2000         * Scripts/webkitpy/tool/bot/botinfo.py:
2001         (BotInfo.__init__): Take port's name.
2002         (BotInfo.summary_text):
2003
2004         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2005         (BotInfoTest.test_summary_text):
2006
2007         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2008         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2009
2010         * Scripts/webkitpy/tool/commands/queues.py:
2011         (PatchProcessingQueue.__init__): Initialize self._port.
2012         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2013         and use that for the attachment filename and the comment posted.
2014
2015         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2016         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2017         "mac-snowleopard" as expected for TestPort.
2018
2019 2013-03-22  Roger Fong  <roger_fong@apple.com>
2020
2021         Unreviewed. Turn off EWS test on Win again.
2022         The battle continues.
2023
2024         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2025         (WinEWS):
2026
2027 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2028
2029         NRWT: Enable pixel tests when retrying tests
2030         https://bugs.webkit.org/show_bug.cgi?id=112898
2031
2032         Reviewed by Dirk Pranke.
2033
2034         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2035         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2036         if we've forced pixel tests in the retry.
2037         (Manager._run_tests):
2038         (Manager._clean_up_run): Fixed the capitalizations.
2039         (Manager._force_pixel_tests_if_needed): Added.
2040
2041         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2042         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2043         'image_diff_percent' if it doesn't already exist.
2044
2045         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2046         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2047         treat this as a regular regression instead of a flakiness.
2048
2049         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2050         run had image diffs.
2051
2052         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2053         (summarized_results):
2054
2055         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2056         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2057         Also removed some dead code.
2058
2059         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2060         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2061         is set and pixel_tests_enabled is set to false.
2062         (EndToEndTest.test_reftest_with_two_notrefs):
2063
2064 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2065
2066         Make it possible to run layout tests on Retina MBP
2067         https://bugs.webkit.org/show_bug.cgi?id=93673
2068
2069         Reviewed by Ryosuke Niwa.
2070
2071         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2072         windows on 2x machines still run at 1x.
2073
2074         * DumpRenderTree/mac/DumpRenderTree.mm:
2075         (createWebViewAndOffscreenWindow):
2076         Reset the window resolution to 1x on creation.
2077         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2078         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2079         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2080         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2081         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2082         (WTR::PlatformWebView::PlatformWebView):
2083         Add NSWindow details, reset the window resolution to 1x on creation.
2084
2085 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2086
2087         Leak bots shouldn't build
2088         https://bugs.webkit.org/show_bug.cgi?id=112774
2089
2090         Reviewed by Simon Fraser.
2091
2092         Since leak bots use regular debug builds, there is no need to build on these bots.
2093         Simply downloading builds will dramatically improve the cycle time of these bots.
2094
2095         * BuildSlaveSupport/build.webkit.org-config/config.json:
2096         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2097         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2098         TestFactory instead of BuildAndTestFactory.
2099
2100 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2101
2102         [Qt] Fix the TestWebKitAPI build
2103         https://bugs.webkit.org/show_bug.cgi?id=113044
2104
2105         Reviewed by Tor Arne Vestbø.
2106
2107         The generate-forwarding-headers script would only be run
2108         after the targets in InjectedBundle.pri since the second
2109         addStrictSubdirOrderBetween call in
2110         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2111         the derived_sources -> injected_bundle order in SUBDIRS.
2112
2113         Fix it by only moving the dependent target at the end of
2114         SUBDIRS, don't touch its dependency.
2115
2116         * qmake/mkspecs/features/functions.prf:
2117
2118 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2119
2120         [EFL][WK2] View is not focused when fullscreen mode toggled
2121         https://bugs.webkit.org/show_bug.cgi?id=113009
2122
2123         Reviewed by Laszlo Gombos.
2124
2125         Set focus on view when fullscreen mode enabled/disabled
2126         by FullScreen API.
2127
2128         * MiniBrowser/efl/main.c:
2129         (on_fullscreen_accept):
2130         (on_fullscreen_deny):
2131
2132 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2133
2134         nrwt is no longer saving retry results in the retries/ subdirectory
2135         https://bugs.webkit.org/show_bug.cgi?id=112995
2136
2137         Reviewed by Ojan Vafai.
2138
2139         I think this has been broken a long time, unfortunately. This
2140         patch should fix that.
2141
2142         In order to do so, I had to pass the directory to use from
2143         the Worker object through the SingleTestWriter to the
2144         TestResultWriter. While I was plumbing that through, I rationalized
2145         the order of the parameter arguments a bit ...
2146
2147         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2148         (Worker._run_single_test):
2149         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2150         (run_single_test):
2151         (SingleTestRunner.__init__):
2152         (SingleTestRunner._run_compare_test):
2153         (SingleTestRunner._run_rebaseline):
2154         (SingleTestRunner._run_reftest):
2155         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2156         (write_test_result):
2157         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2158         (TestResultWriterTest.test_reftest_diff_image):
2159         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2160         (RunTest.test_retrying_uses_retries_directory):
2161
2162 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2163
2164         JSC profiler should have an at-a-glance report of the success of DFG optimization
2165         https://bugs.webkit.org/show_bug.cgi?id=112988
2166
2167         Reviewed by Geoffrey Garen.
2168
2169         * Scripts/display-profiler-output:
2170
2171 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2172
2173         [chromium] Linux ASAN WebKit canary is running out of memory
2174         https://bugs.webkit.org/show_bug.cgi?id=112978
2175
2176         Reviewed by Tony Chang.
2177
2178         Running the AddressSanitizer on a crash takes a lot of
2179         memory, so we should serialize access to it to avoid running
2180         out of memory on a machine.
2181
2182         * Scripts/webkitpy/layout_tests/port/chromium.py:
2183         (ChromiumPort._get_crash_log):
2184         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2185         (HttpLock.__init__):
2186         (HttpLock.wait_for_httpd_lock):
2187
2188 2013-03-21  Min Qin  <qinmin@chromium.org>
2189
2190         Cleanup android media layout test code
2191         https://bugs.webkit.org/show_bug.cgi?id=112944
2192
2193         Reviewed by Adam Barth.
2194
2195         Chromium change: https://codereview.chromium.org/12892010/
2196         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2197         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2198         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2199         Instead, we should switch to use content shell for layout tests.
2200
2201         * DumpRenderTree/chromium/TestShell.cpp:
2202         (TestShell::resetTestController):
2203
2204 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2205
2206         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2207         https://bugs.webkit.org/show_bug.cgi?id=112953
2208
2209         Reviewed by Tony Chang.
2210
2211         When I created the DumpRenderTree_resources target in r144863 I
2212         forgot to declare the needed dependencies on the other resource
2213         targets. Due to a quirk of ordering, this appears to have been fine
2214         w/ ninja but not w/ Xcode (which is still being used on the chromium
2215         mac valgrind bots). Declaring the dependencies fixes the build
2216         failures.
2217
2218         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2219
2220 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2221
2222         [WinCairo] Correct assert in Empty BitmapImage Test.
2223         https://bugs.webkit.org/show_bug.cgi?id=112934
2224
2225         Reviewed by Tim Horton.
2226
2227         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2228         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2229         to avoid ref counting assertion when leaving test scope.
2230
2231 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2232
2233         [GTK] generate-feature-defines-files is incompatible with Python3
2234         https://bugs.webkit.org/show_bug.cgi?id=112956
2235
2236         Reviewed by Martin Robinson.
2237
2238         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2239         method on the dictionary objects when iterating through said dictionaries.
2240
2241         * gtk/generate-feature-defines-files:
2242         (write_feature_defines_header):
2243         (write_flattened_feature_defines_file):
2244
2245 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2246
2247         kill-old-processes spits out error messages on Mac
2248         https://bugs.webkit.org/show_bug.cgi?id=112878
2249
2250         Reviewed by Jessie Berlin.
2251
2252         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2253         included in the list of options grep --help shows.
2254
2255         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2256
2257         * BuildSlaveSupport/kill-old-processes:
2258         (main):
2259
2260 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2261
2262         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2263         https://bugs.webkit.org/show_bug.cgi?id=112597
2264
2265         Reviewed by Xan Lopez.
2266
2267         These were introduced for the Chromium port in r105295. We need
2268         dummy implementations in order to compile the BlackBerry port.
2269
2270         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2271         (AccessibilityUIElement::scrollToMakeVisible):
2272         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2273         (AccessibilityUIElement::scrollToGlobalPoint):
2274
2275 2013-03-21  Roger Fong  <roger_fong@apple.com>
2276
2277         Re-enable WinEWS tests following r146376.
2278
2279         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2280         (WinEWS):
2281
2282 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2283
2284         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2285
2286         * Scripts/webkitpy/common/config/committers.py:
2287
2288 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2289
2290         [GTK] Missing atk in install-dependencies script
2291         https://bugs.webkit.org/show_bug.cgi?id=112272
2292
2293         Reviewed by Gustavo Noronha Silva.
2294
2295         * gtk/install-dependencies: Add missing atk dependency.
2296
2297 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2298
2299         [GTK] Missing backslash in install-dependencies script
2300         https://bugs.webkit.org/show_bug.cgi?id=112907
2301
2302         Reviewed by Philippe Normand.
2303
2304         * gtk/install-dependencies: Add missing backslash to dependencies
2305         list.
2306
2307 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2308
2309         EWS bots have stopped uploading results to bugzilla
2310         https://bugs.webkit.org/show_bug.cgi?id=101091
2311
2312         Reviewed by Adam Barth.
2313
2314         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2315         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2316         this relative file path resoled to a file inside a non-existent directory for "zip".
2317
2318         Fixed the bug by resolving both test results directory and zip archive paths in
2319         LayoutTestResultsReader.archive.
2320
2321         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2322         in the future.
2323
2324         * Scripts/webkitpy/common/system/filesystem_mock.py:
2325         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2326
2327         * Scripts/webkitpy/common/system/workspace.py:
2328         (Workspace.create_zip): Log the source path when "zip" failed.
2329
2330         * Scripts/webkitpy/common/system/workspace_mock.py:
2331         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2332
2333         * Scripts/webkitpy/common/system/workspace_unittest.py:
2334         (WorkspaceTest.test_create_zip_exception): Test that.
2335
2336         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2337         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2338         This is the actual bug fix.
2339
2340         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2341         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2342
2343 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2344
2345         [chromium] move WebThemeEngine implementations to TestRunner library
2346         https://bugs.webkit.org/show_bug.cgi?id=112751
2347
2348         Reviewed by Adam Barth.
2349
2350         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2351         * DumpRenderTree/DumpRenderTree.gypi:
2352         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2353         (WebKit):
2354         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2355         (WebTestRunner::TestInterfaces::themeEngine):
2356         (WebTestRunner):
2357         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2358         (WebKit):
2359         (TestInterfaces):
2360         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2361         (WebTestRunner::WebTestInterfaces::themeEngine):
2362         (WebTestRunner):
2363         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2364         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2365         (WebTestRunner):
2366         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2367         (WebTestRunner::WebTestThemeControlWin::box):
2368         (WebTestRunner::WebTestThemeControlWin::line):
2369         (WebTestRunner::WebTestThemeControlWin::triangle):
2370         (WebTestRunner::WebTestThemeControlWin::roundRect):
2371         (WebTestRunner::WebTestThemeControlWin::oval):
2372         (WebTestRunner::WebTestThemeControlWin::circle):
2373         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2374         (WebTestRunner::WebTestThemeControlWin::markState):
2375         (WebTestRunner::WebTestThemeControlWin::draw):
2376         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2377         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2378         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2379         (WebTestRunner):
2380         (WebTestThemeControlWin):
2381         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2382         (WebTestRunner):
2383         (WebTestThemeEngineMac):
2384         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2385         (+[FakeActiveWindow alwaysActiveWindow]):
2386         (+[FakeActiveWindow alwaysInactiveWindow]):
2387         (-[FakeActiveWindow initWithActiveControls:]):
2388         (-[FakeActiveWindow _hasActiveControls]):
2389         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2390         (WebTestRunner):
2391         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2392         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2393         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2394         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2395         (WebTestRunner):
2396         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2397         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2398         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2399         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2400         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2401         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2402         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2403         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2404         (WebTestRunner::WebTestThemeEngineWin::getSize):
2405         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2406         (WebTestRunner):
2407         (WebTestThemeEngineWin):
2408         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2409         * DumpRenderTree/chromium/TestShell.cpp:
2410         (TestShell::initialize):
2411         * DumpRenderTree/chromium/TestShell.h:
2412         (WebKit):
2413         * DumpRenderTree/chromium/TestShellMac.mm:
2414         (platformInit):
2415         * DumpRenderTree/chromium/TestShellWin.cpp:
2416         (platformInit):
2417         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2418
2419 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2420
2421         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2422
2423         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2424         New property sheet that does not link against CoreFoundation and
2425         CFNetwork.
2426         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2427         Use new TestWebKitAPICommonWinCairo property sheet.
2428         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2429         Ditto.
2430
2431 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2432
2433         [WinCairo] Unreviewed build fix for VS2010.
2434
2435         Had to add WinCairo-specific property sheets to deal with some
2436         library and path differences with the main Apple port.
2437
2438         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2439         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2440         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2441         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2442         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2443         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2444
2445 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2446
2447         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2448         https://bugs.webkit.org/show_bug.cgi?id=112849
2449
2450         Reviewed by Sam Weinig.
2451
2452         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2453         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2454         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2455
2456 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2457
2458         [WinCairo] Build WebKit Tools under VS2010
2459         https://bugs.webkit.org/show_bug.cgi?id=112821
2460
2461         Reviewed by Tim Horton.
2462
2463         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2464         Add WinCairo-specific build target.
2465         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2466         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2467         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2468         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2469         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2470         Add WinCairo-specific build target.
2471         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2472         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2473         Add WinCairo-specific build target.
2474         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2475         WinCairo-specific build target.
2476         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2477         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2478         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2479         specific build target.
2480         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2481         WinCairo-specific build target.
2482         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2483         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2484         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2485
2486 2013-03-20  Roger Fong  <roger_fong@apple.com>
2487
2488         API test gardening AppleWin port.
2489
2490         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2491
2492         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2493         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2494
2495 2013-03-20  Roger Fong  <roger_fong@apple.com>
2496
2497         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2498
2499         * EWSTools/start-queue-win.sh:
2500
2501 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2502
2503         Unreviewed, add myself to committers.py.
2504
2505 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2506
2507         Unreviewed. Adding another email for me.
2508
2509         * Scripts/webkitpy/common/config/committers.py:
2510
2511 2013-03-20  Justin Novosad  <junov@google.com>
2512
2513         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2514         https://bugs.webkit.org/show_bug.cgi?id=112605
2515
2516         Reviewed by James Robinson.
2517
2518         Deleting all the code that was used for propagating and supporting
2519         the Chromium setting for disabling deferred 2d canvas rendering.
2520
2521         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2522         (main):
2523         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2524         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2525         (WebTestRunner::WebPreferences::reset):
2526         (WebTestRunner::WebPreferences::applyTo):
2527         * DumpRenderTree/chromium/TestShell.cpp:
2528         (TestShell::TestShell):
2529         (TestShell::resetWebSettings):
2530         (TestShell::runFileTest):
2531         * DumpRenderTree/chromium/TestShell.h:
2532         (TestShell):
2533
2534 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2535
2536         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2537         https://bugs.webkit.org/show_bug.cgi?id=112699.
2538
2539         Reviewed by Adam Barth.
2540
2541         * Scripts/webkitpy/layout_tests/port/qt.py:
2542         (QtPort._search_paths):
2543         (QtPort._port_specific_expectations_files):
2544         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2545         (QtPortTest):
2546         (QtPortTest._assert_search_path):
2547         (QtPortTest._assert_expectations_files):
2548
2549 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2550
2551         [Qt] Enable kerning by default
2552         https://bugs.webkit.org/show_bug.cgi?id=112704
2553
2554         Reviewed by Jocelyn Turcotte.
2555
2556         Disable kerning by default, since some reference test expectations
2557         expect kerning to be default off.
2558
2559         * DumpRenderTree/qt/TestRunnerQt.cpp:
2560         (TestRunnerQt::reset):
2561         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2562         (WTR::activateFonts):
2563
2564 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2565
2566         [Qt] Remove empty function stubs from TestRunnerQt.
2567         https://bugs.webkit.org/show_bug.cgi?id=112799
2568
2569         We are reducing the code in TestRunnerQt step by step,
2570         in order to finally replace all of it with the generic
2571         TestRunner implementation.
2572         This patch removes several simple function stubs that
2573         currently do not implement any actual functionality.
2574
2575         Reviewed by Kenneth Rohde Christiansen.
2576
2577         * DumpRenderTree/qt/TestRunnerQt.cpp:
2578         * DumpRenderTree/qt/TestRunnerQt.h:
2579         (TestRunnerQt):
2580
2581 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2582
2583         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2584         https://bugs.webkit.org/show_bug.cgi?id=112687
2585
2586         Reviewed by Kenneth Rohde Christiansen.
2587
2588         Hide the SearchBar by default on window creation.
2589
2590         * MiniBrowser/efl/main.c:
2591         (window_create):
2592
2593 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2594
2595         Unreviewed, rolling out r146304.
2596         http://trac.webkit.org/changeset/146304
2597         https://bugs.webkit.org/show_bug.cgi?id=112788
2598
2599         to many expectations to update (Requested by antonm on
2600         #webkit).
2601
2602         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2603         * DumpRenderTree/DumpRenderTree.gypi:
2604         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2605         (WebKit):
2606         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2607         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2608         (TestInterfaces):
2609         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2610         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2611         * DumpRenderTree/chromium/TestShell.cpp:
2612         (TestShell::initialize):
2613         * DumpRenderTree/chromium/TestShell.h:
2614         (WebKit):
2615         * DumpRenderTree/chromium/TestShellMac.mm:
2616         (platformInit):
2617         * DumpRenderTree/chromium/TestShellWin.cpp:
2618         (platformInit):
2619         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2620         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2621         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2622         (WebThemeControlDRTWin::box):
2623         (WebThemeControlDRTWin::line):
2624         (WebThemeControlDRTWin::triangle):
2625         (WebThemeControlDRTWin::roundRect):
2626         (WebThemeControlDRTWin::oval):
2627         (WebThemeControlDRTWin::circle):
2628         (WebThemeControlDRTWin::nestedBoxes):
2629         (WebThemeControlDRTWin::markState):
2630         (WebThemeControlDRTWin::draw):
2631         (WebThemeControlDRTWin::drawTextField):
2632         (WebThemeControlDRTWin::drawProgressBar):
2633         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2634         (WebThemeControlDRTWin):
2635         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2636         (WebThemeEngineDRTMac):
2637         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2638         (+[FakeActiveWindow alwaysActiveWindow]):
2639         (+[FakeActiveWindow alwaysInactiveWindow]):
2640         (-[FakeActiveWindow initWithActiveControls:]):
2641         (-[FakeActiveWindow _hasActiveControls]):
2642         (WebThemeEngineDRTMac::paintScrollbarThumb):
2643         (stateToHIEnableState):
2644         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2645         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2646         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2647         (webRectToSkIRect):
2648         (drawControl):
2649         (drawTextField):
2650         (drawProgressBar):
2651         (WebThemeEngineDRTWin::paintButton):
2652         (WebThemeEngineDRTWin::paintMenuList):
2653         (WebThemeEngineDRTWin::paintScrollbarArrow):
2654         (WebThemeEngineDRTWin::paintScrollbarThumb):
2655         (WebThemeEngineDRTWin::paintScrollbarTrack):
2656         (WebThemeEngineDRTWin::paintSpinButton):
2657         (WebThemeEngineDRTWin::paintTextField):
2658         (WebThemeEngineDRTWin::paintTrackbar):
2659         (WebThemeEngineDRTWin::paintProgressBar):
2660         (WebThemeEngineDRTWin::getSize):
2661         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2662         (WebThemeEngineDRTWin):
2663         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2664
2665 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2666
2667         [Qt] Support -webkit-font-smoothing
2668         https://bugs.webkit.org/show_bug.cgi?id=106009
2669
2670         Reviewed by Jocelyn Turcotte.
2671
2672         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2673
2674         * DumpRenderTree/qt/TestRunnerQt.cpp:
2675         (TestRunnerQt::reset):
2676
2677 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2678
2679         [GTK] accessibility/aria-scrollbar-role.html is failing
2680         https://bugs.webkit.org/show_bug.cgi?id=98358
2681
2682         Reviewed by Martin Robinson.
2683
2684         Adds support for checking accessibility object's orientation.
2685         Orientation is checked by retrieving proper state of accessibility object.
2686
2687         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2688         (checkElementState):
2689         (AccessibilityUIElement::orientation):
2690         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2691         (WTR::AccessibilityUIElement::orientation):
2692
2693 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2694
2695         [chromium] move WebThemeEngine implementations to TestRunner library
2696         https://bugs.webkit.org/show_bug.cgi?id=112751
2697
2698         Reviewed by Adam Barth.
2699
2700         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2701         * DumpRenderTree/DumpRenderTree.gypi:
2702         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2703         (WebKit):
2704         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2705         (WebTestRunner::TestInterfaces::themeEngine):
2706         (WebTestRunner):
2707         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2708         (WebKit):
2709         (TestInterfaces):
2710         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2711         (WebTestRunner::WebTestInterfaces::themeEngine):
2712         (WebTestRunner):
2713         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2714         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2715         (WebTestRunner):
2716         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2717         (WebTestRunner::WebTestThemeControlWin::box):
2718         (WebTestRunner::WebTestThemeControlWin::line):
2719         (WebTestRunner::WebTestThemeControlWin::triangle):
2720         (WebTestRunner::WebTestThemeControlWin::roundRect):
2721         (WebTestRunner::WebTestThemeControlWin::oval):
2722         (WebTestRunner::WebTestThemeControlWin::circle):
2723         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2724         (WebTestRunner::WebTestThemeControlWin::markState):
2725         (WebTestRunner::WebTestThemeControlWin::draw):
2726         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2727         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2728         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2729         (WebTestRunner):
2730         (WebTestThemeControlWin):
2731         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2732         (WebTestRunner):
2733         (WebTestThemeEngineMac):
2734         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2735         (+[FakeActiveWindow alwaysActiveWindow]):
2736         (+[FakeActiveWindow alwaysInactiveWindow]):
2737         (-[FakeActiveWindow initWithActiveControls:]):
2738         (-[FakeActiveWindow _hasActiveControls]):
2739         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2740         (WebTestRunner):
2741         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2742         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2743         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2744         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2745         (WebTestRunner):
2746         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2747         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2748         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2749         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2750         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2751         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2752         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2753         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2754         (WebTestRunner::WebTestThemeEngineWin::getSize):
2755         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2756         (WebTestRunner):
2757         (WebTestThemeEngineWin):
2758         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2759         * DumpRenderTree/chromium/TestShell.cpp:
2760         (TestShell::initialize):
2761         * DumpRenderTree/chromium/TestShell.h:
2762         (WebKit):
2763         * DumpRenderTree/chromium/TestShellMac.mm:
2764         (platformInit):
2765         * DumpRenderTree/chromium/TestShellWin.cpp:
2766         (platformInit):
2767         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2768
2769 2013-03-19  Tony Chang  <tony@chromium.org>
2770
2771         Move testRunner.setTouchDragDropEnabled to internals.settings
2772         https://bugs.webkit.org/show_bug.cgi?id=112739
2773
2774         Reviewed by Adam Barth.
2775
2776         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2777         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2778         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2779         (TestRunner): Remove unnecessary code.
2780         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2781         (WebTestRunner::WebPreferences::reset):
2782         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2783
2784 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2785
2786         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2787         https://bugs.webkit.org/show_bug.cgi?id=112754
2788
2789         Reviewed by Darin Fisher.
2790
2791         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2792         now that it's always defined.
2793
2794         * DumpRenderTree/chromium/WebViewHost.cpp:
2795         * DumpRenderTree/chromium/WebViewHost.h:
2796         (WebViewHost):
2797
2798 2013-03-19  Kenneth Russell  <kbr@google.com>
2799
2800         Unreviewed, rolling out r146290.
2801         http://trac.webkit.org/changeset/146290
2802         https://bugs.webkit.org/show_bug.cgi?id=112751
2803
2804         Broke Chromium Mac build.
2805
2806         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2807         * DumpRenderTree/DumpRenderTree.gypi:
2808         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2809         (WebKit):
2810         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2811         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2812         (TestInterfaces):
2813         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2814         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2815         * DumpRenderTree/chromium/TestShell.cpp:
2816         (TestShell::initialize):
2817         * DumpRenderTree/chromium/TestShell.h:
2818         (WebKit):
2819         * DumpRenderTree/chromium/TestShellMac.mm:
2820         (platformInit):
2821         * DumpRenderTree/chromium/TestShellWin.cpp:
2822         (platformInit):
2823         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2824         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2825         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2826         (WebThemeControlDRTWin::box):
2827         (WebThemeControlDRTWin::line):
2828         (WebThemeControlDRTWin::triangle):
2829         (WebThemeControlDRTWin::roundRect):
2830         (WebThemeControlDRTWin::oval):
2831         (WebThemeControlDRTWin::circle):
2832         (WebThemeControlDRTWin::nestedBoxes):
2833         (WebThemeControlDRTWin::markState):
2834         (WebThemeControlDRTWin::draw):
2835         (WebThemeControlDRTWin::drawTextField):
2836         (WebThemeControlDRTWin::drawProgressBar):
2837         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2838         (WebThemeControlDRTWin):
2839         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2840         (WebThemeEngineDRTMac):
2841         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2842         (+[FakeActiveWindow alwaysActiveWindow]):
2843         (+[FakeActiveWindow alwaysInactiveWindow]):
2844         (-[FakeActiveWindow initWithActiveControls:]):
2845         (-[FakeActiveWindow _hasActiveControls]):
2846         (WebThemeEngineDRTMac::paintScrollbarThumb):
2847         (stateToHIEnableState):
2848         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2849         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2850         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2851         (webRectToSkIRect):
2852         (drawControl):
2853         (drawTextField):
2854         (drawProgressBar):
2855         (WebThemeEngineDRTWin::paintButton):
2856         (WebThemeEngineDRTWin::paintMenuList):
2857         (WebThemeEngineDRTWin::paintScrollbarArrow):
2858         (WebThemeEngineDRTWin::paintScrollbarThumb):
2859         (WebThemeEngineDRTWin::paintScrollbarTrack):
2860         (WebThemeEngineDRTWin::paintSpinButton):
2861         (WebThemeEngineDRTWin::paintTextField):
2862         (WebThemeEngineDRTWin::paintTrackbar):
2863         (WebThemeEngineDRTWin::paintProgressBar):
2864         (WebThemeEngineDRTWin::getSize):
2865         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2866         (WebThemeEngineDRTWin):
2867         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2868
2869 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2870
2871         [EFL] canvas-fallback-content.html is failing
2872         https://bugs.webkit.org/show_bug.cgi?id=111998
2873
2874         Reviewed by Chris Fleizach.
2875
2876         Adds support for getting platform name.
2877
2878         * DumpRenderTree/TestRunner.cpp:
2879         (TestRunner::staticValues):
2880         * DumpRenderTree/TestRunner.h:
2881         (TestRunner):
2882         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2883         (TestRunner::platformName):
2884
2885 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2886
2887         [chromium] move WebThemeEngine implementations to TestRunner library
2888         https://bugs.webkit.org/show_bug.cgi?id=112751
2889
2890         Reviewed by Adam Barth.
2891
2892         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2893         * DumpRenderTree/DumpRenderTree.gypi:
2894         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2895         (WebKit):
2896         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2897         (WebTestRunner::TestInterfaces::themeEngine):
2898         (WebTestRunner):
2899         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2900         (WebKit):
2901         (TestInterfaces):
2902         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2903         (WebTestRunner::WebTestInterfaces::themeEngine):
2904         (WebTestRunner):
2905         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2906         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2907         (WebTestRunner):
2908         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2909         (WebTestRunner::WebTestThemeControlWin::box):
2910         (WebTestRunner::WebTestThemeControlWin::line):
2911         (WebTestRunner::WebTestThemeControlWin::triangle):
2912         (WebTestRunner::WebTestThemeControlWin::roundRect):
2913         (WebTestRunner::WebTestThemeControlWin::oval):
2914         (WebTestRunner::WebTestThemeControlWin::circle):
2915         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2916         (WebTestRunner::WebTestThemeControlWin::markState):
2917         (WebTestRunner::WebTestThemeControlWin::draw):
2918         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2919         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2920         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2921         (WebTestRunner):
2922         (WebTestThemeControlWin):
2923         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2924         (WebTestRunner):
2925         (WebTestThemeEngineMac):
2926         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2927         (+[FakeActiveWindow alwaysActiveWindow]):
2928         (+[FakeActiveWindow alwaysInactiveWindow]):
2929         (-[FakeActiveWindow initWithActiveControls:]):
2930         (-[FakeActiveWindow _hasActiveControls]):
2931         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2932         (WebTestRunner):
2933         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2934         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2935         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2936         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2937         (WebTestRunner):
2938         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2939         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2940         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2941         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2942         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2943         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2944         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2945         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2946         (WebTestRunner::WebTestThemeEngineWin::getSize):
2947         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2948         (WebTestRunner):
2949         (WebTestThemeEngineWin):
2950         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2951         * DumpRenderTree/chromium/TestShell.cpp:
2952         (TestShell::initialize):
2953         * DumpRenderTree/chromium/TestShell.h:
2954         (WebKit):
2955         * DumpRenderTree/chromium/TestShellMac.mm:
2956         (platformInit):
2957         * DumpRenderTree/chromium/TestShellWin.cpp:
2958         (platformInit):
2959         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2960
2961 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2962
2963         [EFL][WK2] Separate WebView further from EwkView
2964         https://bugs.webkit.org/show_bug.cgi?id=111591
2965
2966         Reviewed by Caio Marcelo de Oliveira Filho.
2967
2968         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2969         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2970         since we can afford it having EWKViewGetWKView() private API to access WKView.
2971
2972         * TestWebKitAPI/PlatformWebView.h:
2973         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2974         (TestWebKitAPI::TEST):
2975         * TestWebKitAPI/efl/PlatformWebView.cpp:
2976         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2977         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2978         (TestWebKitAPI::PlatformWebView::resizeTo):
2979         (TestWebKitAPI::PlatformWebView::page):
2980         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2981         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2982         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2983         * WebKitTestRunner/PlatformWebView.h:
2984         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2985         (WTR::EventSenderProxy::dispatchEvent):
2986         (WTR::EventSenderProxy::keyDown):
2987         (WTR::EventSenderProxy::sendTouchEvent):
2988         (WTR::EventSenderProxy::setTouchModifier):
2989         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2990         (WTR::PlatformWebView::PlatformWebView):
2991         (WTR::PlatformWebView::~PlatformWebView):
2992         (WTR::PlatformWebView::resizeTo):
2993         (WTR::PlatformWebView::page):
2994         (WTR::PlatformWebView::focus):
2995         (WTR::PlatformWebView::windowSnapshotImage):
2996
2997 2013-03-19  Roger Fong  <roger_fong@apple.com>
2998
2999         Changes to VS2010 project files should only trigger builds on Windows bots.
3000         https://bugs.webkit.org/show_bug.cgi?id=112731
3001
3002         Reviewed by Timothy Horton.
3003
3004         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3005         (_should_file_trigger_build):
3006
3007 2013-03-19  Roger Fong  <roger_fong@apple.com>
3008
3009         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3010
3011         * Scripts/webkitpy/tool/steps/runtests.py:
3012         (RunTests.run):
3013         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3014         (RunTestsTest.test_webkit_run_unit_tests):
3015
3016 2013-03-19  Julie Parent  <jparent@chromium.org>
3017
3018         Dashboards: Introduce history namespace and unit tests.
3019         https://bugs.webkit.org/show_bug.cgi?id=112645
3020
3021         Reviewed by Ojan Vafai.
3022         
3023         Laying the framework for introducing the new history object and
3024         namespace.  This moves only static functions into the history
3025         namespace, and moves corresponding unit tests into seperate
3026         unit test file.
3027
3028         * TestResultServer/static-dashboards/aggregate_results.html:
3029         * TestResultServer/static-dashboards/dashboard_base.js:
3030         (parseCrossDashboardParameters):
3031         (parseDashboardSpecificParameters):
3032         (parseParameters):
3033         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3034         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3035         (.switch.return):
3036         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3037         * TestResultServer/static-dashboards/history.js: Added.
3038         * TestResultServer/static-dashboards/history_unittests.js: Added.
3039         * TestResultServer/static-dashboards/loader.js:
3040         (.):
3041         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3042         * TestResultServer/static-dashboards/run-unittests.html:
3043         * TestResultServer/static-dashboards/timeline_explorer.html:
3044         * TestResultServer/static-dashboards/timeline_explorer.js:
3045         * TestResultServer/static-dashboards/treemap.html:
3046         * TestResultServer/static-dashboards/treemap.js:
3047         (.switch.return):
3048         * TestResultServer/static-dashboards/ui.js:
3049
3050 2013-03-19  Daniel Bates  <dbates@webkit.org>
3051
3052         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3053         https://bugs.webkit.org/show_bug.cgi?id=112732
3054
3055         Reviewed by Eric Seidel.
3056
3057         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3058         of an existing file cannot be applied.
3059
3060         In particular, svn-{apply, unapply} compensate for differences in line endings
3061         by converting the line endings in a diff to match the line endings in the target
3062         file. The diff(1) command precedes the last line of a diff that adds a newline
3063         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3064         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3065         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3066         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3067         the newline characters in this special character sequence to match the line endings
3068         in the target file.
3069
3070         * Scripts/VCSUtils.pm:
3071         (parseDiff):
3072         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3073         Added tests:
3074             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3075             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3076             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3077             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3078         (escapeNewLineCharacters): Added.
3079         (toMacLineEndings): Added.
3080
3081 2013-03-19  James Robinson  <jamesr@chromium.org>
3082
3083         [chromium] Remove compositor settings that don't go through WebKit
3084         https://bugs.webkit.org/show_bug.cgi?id=112718
3085
3086         Reviewed by Adam Barth.
3087
3088         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3089         (main):
3090         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3091         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3092         (WebTestRunner::WebPreferences::reset):
3093         (WebTestRunner::WebPreferences::applyTo):
3094         * DumpRenderTree/chromium/TestShell.cpp:
3095         (TestShell::TestShell):
3096         (TestShell::resetWebSettings):
3097         * DumpRenderTree/chromium/TestShell.h:
3098         (TestShell):
3099
3100 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3101
3102         Unreviewed, rolling out r146101.
3103         https://bugs.webkit.org/show_bug.cgi?id=111884
3104
3105         re-enable custom freetype on asan; this needs to be on
3106         now that the bot is running lucid.
3107
3108         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3109
3110 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3111
3112         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3113         https://bugs.webkit.org/show_bug.cgi?id=112365
3114
3115         Reviewed by Benjamin Poulain.
3116
3117         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3118         harcoding it in wtf/Platform.h
3119
3120         * Scripts/webkitperl/FeatureList.pm:
3121
3122 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3123
3124         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3125         https://bugs.webkit.org/show_bug.cgi?id=94782
3126
3127         Based on patch by Csaba Osztrogonác.
3128         Reviewed by Jocelyn Turcotte.
3129
3130         The diff image is generated with bright red indicating errors, but letting the base image
3131         shine through so the context of the error-pixel can be identified.
3132
3133         * DumpRenderTree/qt/ImageDiff.cpp:
3134         (main):
3135
3136 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3137
3138         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3139
3140         Rubber-stamped by Csaba Osztrogonác.
3141
3142         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3143         since the latter might not cover the former.
3144
3145         * QtTestBrowser/launcherwindow.cpp:
3146         (LauncherWindow::print):
3147
3148 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3149
3150         Style tweeks to default.css.
3151         
3152         Rubber-stamped by David Kilzer.
3153         
3154         Give visited links a different color to other links, so you can
3155         see which builds you've viewed.
3156         
3157         Make the <small> text less tiny.
3158
3159         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3160         (small):
3161         (a:link,a:visited,a:active):
3162         (a:visited):
3163
3164 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3165
3166         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3167         https://bugs.webkit.org/show_bug.cgi?id=112494
3168
3169         Reviewed by Dirk Pranke.
3170
3171         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3172         Also merged two pairs of methods to cleanup the code.
3173
3174         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3175         (PerfTestsRunner.run): Merged _upload_and_show_results.
3176         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3177
3178 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3179
3180         [chromium] build xdisplaycheck when building DRT
3181         https://bugs.webkit.org/show_bug.cgi?id=112636
3182
3183         Reviewed by Tony Chang.
3184
3185         It appears that we need xdisplaycheck to be built in order for
3186         Xvfb to be started correctly on the bots, and DRT was missing
3187         a dependency on it. This may be the cause of the ASAN bot not
3188         starting up properly (it only builds DRT).
3189
3190         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3191
3192 2013-03-18  David Levin  <levin@chromium.org>
3193
3194         Implement icon change notification dump for Chromium's test shell.
3195         https://bugs.webkit.org/show_bug.cgi?id=112614
3196
3197         This was previously implemented for some other platforms in r58111
3198         and r116547.
3199
3200         In r122806, fast/dom/icon-url-property.html stopped using it, but
3201         it is useful for tests, so I plan to re-add it to that test again.
3202
3203         Reviewed by Jochen Eisinger.
3204
3205         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3206         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3207          icon change notifications from WebKit may be logged in test output.
3208         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3209         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3210         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3211         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3212         (WebTestRunner):
3213         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3214         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3215         (TestRunner):
3216         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3217         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3218         (WebTestRunner):
3219         * DumpRenderTree/chromium/WebViewHost.cpp:
3220         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3221         * DumpRenderTree/chromium/WebViewHost.h:
3222         (WebViewHost):
3223
3224 2013-03-18  Julie Parent  <jparent@chromium.org>
3225
3226         Cleanup: Move js for treemap and aggregate_results into own js files.
3227         https://bugs.webkit.org/show_bug.cgi?id=112618
3228
3229         Reviewed by Dirk Pranke.
3230         
3231         No functional changes, just moving the code into separate js file
3232         rather than inlined in the html, so we can test it, make it more
3233         modular, etc.  Other dashboard types are already done this way.
3234
3235         * TestResultServer/static-dashboards/aggregate_results.html:
3236         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3237         (generatePage):
3238         (handleValidHashParameter):
3239         (htmlForBuilder):
3240         (rawValuesHTML):
3241         (chartHTML):
3242         (filteredValues):
3243         (chart):
3244         (htmlForRevisionRows):
3245         (wrapHTMLInTable):
3246         (htmlForSummaryTable):
3247         (valuesPerExpectation):
3248         (htmlForTestType):
3249         (htmlForTableRow):
3250         (extendedEncode):
3251         * TestResultServer/static-dashboards/treemap.html:
3252         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3253         (humanReadableTime):
3254         (convertToWebTreemapFormat):
3255         (reverseSortByAverage):
3256         (generatePage):
3257         (focusPath):
3258         (.switch.return):
3259         (handleQueryParameterChange):
3260         (extractName):
3261         (fullName):
3262         (handleFocus.):
3263         (handleFocus):
3264
3265 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3266
3267         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3268         https://bugs.webkit.org/show_bug.cgi?id=112622
3269
3270         Reviewed by Dirk Pranke.
3271
3272         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3273         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3274
3275 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3276
3277         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3278         https://bugs.webkit.org/show_bug.cgi?id=112619
3279
3280         Reviewed by Dirk Pranke.
3281
3282         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3283         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3284
3285         * Scripts/webkitpy/layout_tests/port/gtk.py:
3286         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3287         Port._webkit_baseline_path method.
3288         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3289         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3290         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3291         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3292         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3293         that are expected based on the builder name.
3294
3295 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3296
3297         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3298         https://bugs.webkit.org/show_bug.cgi?id=112571
3299
3300         Reviewed by Adam Barth.
3301
3302         Update function declarations for new WebFileSystemType enum. (All
3303         changes are behind an #ifdef so we can sync required changes in embedders.)
3304
3305         * DumpRenderTree/chromium/WebViewHost.cpp:
3306         (WebViewHost::openFileSystem):
3307         (WebViewHost::deleteFileSystem):
3308         * DumpRenderTree/chromium/WebViewHost.h:
3309         (WebViewHost):
3310
3311 2013-03-18  Julie Parent  <jparent@chromium.org>
3312
3313         Cleanup: Move timeline_exporer js out of html file into js.
3314         https://bugs.webkit.org/show_bug.cgi?id=112188
3315
3316         Reviewed by Dirk Pranke.
3317         
3318         Moves the javascript out of the html file and into a new js file.
3319         This follows the format of flakiness_dashboard.{html|js}.
3320         
3321         Also moves code from dashboard_base that is used only by this one
3322         dashboard, and makes it private to the dashboard.
3323
3324         * TestResultServer/static-dashboards/dashboard_base.js:
3325         * TestResultServer/static-dashboards/timeline_explorer.html:
3326         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3327         (generatePage):
3328         (initCurrentBuilderTestResults):
3329         (shouldShowWebKitRevisionsOnly):
3330         (updateTimelineForBuilder.):
3331         (updateTimelineForBuilder):
3332         (selectBuild):
3333         (updateBuildIndicator):
3334         (.addRow):
3335         (.addNumberRow):
3336         (.inspectorNode.getElementsByTagName.0.onclick):
3337         (.inspectorNode.getElementsByTagName.1.onclick):
3338         (.inspectorNode.getElementsByTagName.2.onclick):
3339         (updateBuildInspector):
3340         (showResultsDelta):
3341         (decompressResults.addFlakyDelta):
3342         (decompressResults):
3343
3344 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3345
3346         Unreviewed, rolling out r145272.
3347         http://trac.webkit.org/changeset/145272
3348         https://bugs.webkit.org/show_bug.cgi?id=111884
3349
3350         Turns out the ASAN build is still broken; possibly there's
3351         something still setting LD_LIBRARY_PATH, or possibly there's
3352         something else wrong. In the meantime, we need it to work again.
3353
3354         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3355
3356 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3357
3358         delete-stale-build-files is too aggressive
3359         https://bugs.webkit.org/show_bug.cgi?id=112595
3360
3361         Reviewed by Tim Horton.
3362
3363         It appears that whitelisting file extensions to keep is not a good idea.
3364         Blacklist files to delete instead, and only delete .o files for now.
3365         We can add more file extensions as needed.
3366
3367         * BuildSlaveSupport/delete-stale-build-files:
3368
3369 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3370
3371         Disable accessibility notifications after each test
3372         https://bugs.webkit.org/show_bug.cgi?id=112579
3373
3374         Reviewed by Tim Horton.
3375         
3376         In WebKitTestRunner, if any tests triggered accessibility notifications,
3377         the global notification handler would thereafter be active, and fire
3378         notifications for all subsequent tests.
3379         
3380         Fix by implementing AccessibilityController::resetToConsistentState() for
3381         Mac, and using it to clear the global notification handler.
3382
3383         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3384         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3385         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3386         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3387         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3388         (e.g. because of -autorelease).
3389         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3390         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3391         if there is one.
3392         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3393         Add -stopObserving
3394         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3395         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3396         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3397         center.
3398
3399 2013-03-18  Dana Jansens  <danakj@chromium.org>
3400
3401         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3402         https://bugs.webkit.org/show_bug.cgi?id=112392
3403
3404         Reviewed by James Robinson.
3405
3406         Removes the command line flag option from DRT.
3407
3408         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3409         (main):
3410
3411 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3412
3413         [GTK] plugins/plugin-clip-subframe.html is failing
3414         https://bugs.webkit.org/show_bug.cgi?id=112570
3415
3416         Reviewed by Martin Robinson.
3417
3418         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3419
3420 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3421
3422         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3423         https://bugs.webkit.org/show_bug.cgi?id=112442
3424
3425         Reviewed by Gustavo Noronha Silva.
3426
3427         * GtkLauncher/main.c:
3428         (reloadCb):
3429         (createToolbar):
3430         (createWindow):
3431
3432 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3433
3434         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3435         https://bugs.webkit.org/show_bug.cgi?id=112205
3436
3437         Disable this API test until Geoff can fix it.
3438
3439         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3440         (TestWebKitAPI::TEST):
3441
3442 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3443
3444         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3445         https://bugs.webkit.org/show_bug.cgi?id=112478
3446
3447         Reviewed by Tony Chang.
3448
3449         There is nothing that ensures that the log messages from the plugin
3450         come in before the layout test finished loading.
3451
3452         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3453         (PassDifferentNPPStruct::NPP_SetWindow):
3454         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3455         (NPP_SetWindow):
3456
3457 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3458
3459         Have the mac port support per_test_timeout in webkitpy
3460         https://bugs.webkit.org/show_bug.cgi?id=112466
3461
3462         Reviewed by Dirk Pranke.
3463         
3464         Both WTR and DRT handle --timeout arguments, so we can
3465         have the scripts pass the timeout values down to the tools.
3466
3467         * Scripts/webkitpy/layout_tests/port/mac.py:
3468         (MacPort.supports_per_test_timeout):
3469
3470 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3471
3472         Remove setAsynchronousSpellCheckingEnabled from test runners
3473         https://bugs.webkit.org/show_bug.cgi?id=112362
3474
3475         Reviewed by Tony Chang.
3476
3477         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3478         in internals.settings, so all ports can share it.
3479
3480         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3481         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3482         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3483         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3484         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3485         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3486         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3487         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3488         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3489         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3490         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3491         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3492
3493 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3494
3495         Fix the stupid unit tests.
3496
3497         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3498         (test_sample_process):
3499
3500 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3501
3502         Collect samples for unresponsive web processes
3503         https://bugs.webkit.org/show_bug.cgi?id=112409
3504
3505         Reviewed by Tim Horton.
3506         
3507         When we detect that a subprocess was unresponsive, run the 'sample'
3508         tool on that process, for the Mac port.
3509         
3510         The sample will be linked to from the results.html page, next
3511         to the crash log link.
3512
3513         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3514         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3515         look for samples on disk.
3516         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3517         (TestResultWriter):
3518         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3519         -sample.txt files, and have it copy their contents to a new file
3520         next to the test that spawned them (as we do for crash logs).
3521         * Scripts/webkitpy/layout_tests/port/base.py:
3522         (Port.look_for_new_samples): Base class does nothing for sampling.
3523         * Scripts/webkitpy/layout_tests/port/driver.py:
3524         (Driver._check_for_driver_crash): Kick off a sample if we detected
3525         that the subprocess was unresponsive.
3526         * Scripts/webkitpy/layout_tests/port/mac.py:
3527         (MacPort.sample_file_path): Utility to generate the file path
3528         to the generated sample files at the top level of layout-test-results.
3529         (MacPort.look_for_new_crash_logs): Fix typo
3530         (MacPort.look_for_new_samples): New function to find sample files.
3531         (MacPort.sample_process): Use the utility function to get the file path.
3532
3533 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3534
3535         [Qt] Remove simple getters and setters from TestRunnerQt
3536         https://bugs.webkit.org/show_bug.cgi?id=112343
3537
3538         Reviewed by Benjamin Poulain.
3539
3540         The removed functions and boolean members
3541         are being replaced by the implementations in the
3542         generic TestRunner.h.
3543
3544         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3545         (DumpRenderTree::dumpFrameScrollPosition):
3546         (DumpRenderTree::dumpFramesAsText):
3547         (DumpRenderTree::dump):
3548         (DumpRenderTree::titleChanged):
3549         (DumpRenderTree::dumpDatabaseQuota):
3550         (DumpRenderTree::dumpApplicationCacheQuota):
3551         (DumpRenderTree::statusBarMessage):
3552         (DumpRenderTree::createWindow):
3553         * DumpRenderTree/qt/TestRunnerQt.cpp:
3554         (TestRunnerQt::reset):
3555         * DumpRenderTree/qt/TestRunnerQt.h:
3556         (TestRunnerQt):
3557
3558 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3559
3560         Update the link on build.webkit.org to refer to perf.webkit.org
3561         https://bugs.webkit.org/show_bug.cgi?id=112416
3562
3563         Reviewed by Philip Rogers.
3564
3565         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3566
3567         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3568
3569 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3570
3571         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3572         https://bugs.webkit.org/show_bug.cgi?id=112394
3573
3574         Reviewed by Philippe Normand.
3575
3576         * GtkLauncher/main.c:
3577         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3578
3579 2013-03-14  Andreas Kling  <akling@apple.com>
3580
3581         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3582         <http://webkit.org/b/111815>
3583         <rdar://problem/13380145>
3584
3585         Reviewed by Anders Carlsson.
3586
3587         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3588         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3589         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3590
3591         * WebKitTestRunner/PlatformWebView.h:
3592         (PlatformWebView):
3593         * WebKitTestRunner/TestController.cpp:
3594         (WTR::TestController::createOtherPage):
3595         (WTR::TestController::createWebViewWithOptions):
3596         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3597         (WTR::PlatformWebView::didInitializeClients):
3598
3599 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3600
3601         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3602         https://bugs.webkit.org/show_bug.cgi?id=112122
3603
3604         Reviewed by Kenneth Rohde Christiansen.
3605
3606         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3607
3608         * MiniBrowser/efl/main.c:
3609         (_Browser_Window):
3610         (search_box_show):
3611         (search_box_hide):
3612         (on_key_down):
3613         (on_url_changed):
3614         (on_search_field_aborted):
3615         (on_search_field_activated):
3616         (on_search_field_clicked):
3617         (on_search_backward_button_clicked):
3618         (on_search_forward_button_clicked):
3619         (window_create):
3620
3621 2013-03-14  Julie Parent  <jparent@chromium.org>
3622
3623         Cleanup: Remove g_resourceLoader.
3624         https://bugs.webkit.org/show_bug.cgi?id=112305
3625
3626         Reviewed by Dirk Pranke.
3627         
3628         Removing another global.
3629         
3630         Now, each dashboard creates its own loader, rather than having
3631         a general global one.
3632         
3633         Remove usage of g_resourceLoader.isLoadingComplete from 
3634         handleLocationChange by ensuring that handleLocationChange is
3635         never called before the loader is done.  It was called in two
3636         places before: 1 was from the callback when the loader is done,
3637         so that was obviously true, and the other was from onhashchange,
3638         where it would just return rather than running.  Instead, lets
3639         only register the onhashchange handler once the loader is
3640         setup, so the check is no longer necessary.
3641         
3642         Remove isLoadingComplete since it is now unused.
3643         
3644         Callback for loader is now initializeHistory, rather than just
3645         handleLocationChange which will set up the hashchange handler now.
3646         This will all eventually be moving to a new History object.
3647
3648         * TestResultServer/static-dashboards/aggregate_results.html:
3649         * TestResultServer/static-dashboards/dashboard_base.js:
3650         (handleLocationChange):
3651         (intializeHistory):
3652         (decompressResults):
3653         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3654         (generatePage):
3655         * TestResultServer/static-dashboards/loader.js:
3656         (.):
3657         * TestResultServer/static-dashboards/loader_unittests.js:
3658         * TestResultServer/static-dashboards/timeline_explorer.html:
3659         * TestResultServer/static-dashboards/treemap.html:
3660
3661 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3662
3663         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3664         https://bugs.webkit.org/show_bug.cgi?id=109404
3665
3666         Reviewed by Tony Chang.
3667
3668         Removes all the code related to smartInsertDeleteEnabled and
3669         selectTrailingWhitespaceEnabled settings as they will be managed from
3670         internals from now on.
3671
3672         * DumpRenderTree/TestRunner.cpp:
3673         (TestRunner::staticFunctions):
3674         * DumpRenderTree/TestRunner.h:
3675         (TestRunner):
3676         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3677         (WebKit):
3678         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3679         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3680         (DumpRenderTree):
3681         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3682         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3683         (WebTestRunner::WebTestProxy::didStopLoading):
3684         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3685         (WebTestRunner::TestRunner::TestRunner):
3686         (WebTestRunner::TestRunner::reset):
3687         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3688         (TestRunner):
3689         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3690         (WebTestRunner::WebPreferences::applyTo): Set default values for
3691         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3692         Chromium DRT default values are different from Chromium browser.
3693         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3694         * DumpRenderTree/chromium/WebViewHost.cpp:
3695         * DumpRenderTree/chromium/WebViewHost.h:
3696         (WebViewHost):
3697         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3698         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3699         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3700         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3701         (resetDefaultsToConsistentValues):
3702         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3703         * DumpRenderTree/mac/DumpRenderTree.mm:
3704         (resetWebViewToConsistentStateBeforeTesting):
3705         * DumpRenderTree/mac/TestRunnerMac.mm:
3706         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3707         (WebCore::WebPage::resetSettings):
3708         * DumpRenderTree/qt/TestRunnerQt.cpp:
3709         * DumpRenderTree/qt/TestRunnerQt.h:
3710         (TestRunnerQt):
3711         * DumpRenderTree/win/DumpRenderTree.cpp:
3712         (resetWebViewToConsistentStateBeforeTesting):
3713         * DumpRenderTree/win/TestRunnerWin.cpp:
3714         * DumpRenderTree/wx/TestRunnerWx.cpp:
3715
3716 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3717
3718         [Qt] Disable DRT on Windows
3719
3720         Reviewed by Jocelyn Turcotte.
3721
3722         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3723
3724         * qmake/mkspecs/features/configure.prf:
3725
3726 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3727
3728         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
3729         https://bugs.webkit.org/show_bug.cgi?id=110728
3730
3731         Reviewed by Gyuyoung Kim.
3732
3733         Use the page group to create the view object.
3734
3735         * MiniBrowser/efl/main.c:
3736         (window_create):
3737
3738 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3739
3740         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
3741
3742         Reviewed by Tor Arne Vestbø.
3743
3744         The mock versions of these web facing features should be instantiated when
3745         running in DumpRenderTree only. In order for them to work, no extra Qt modules
3746         such as QtLocation are actually needed.
3747
3748         This patch decouples enabling device orientation/motion and geolocation from
3749         the underlying Qt modules and makes them available in developer builds
3750         (!production_build) and backed by mock backends when running in drt.
3751
3752         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
3753         developers the web facing features are always enabled (although requests will
3754         time out) and the mock backends are enabled inside DRT, allowing for the layout
3755         tests to run with less dependencies.
3756
3757         In addition this also enables the mock device motion client, which was
3758         previously never instantiated.
3759
3760         * qmake/mkspecs/features/features.prf:
3761
3762 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3763
3764         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
3765         https://bugs.webkit.org/show_bug.cgi?id=112340
3766
3767         Reviewed by Simon Hausmann.
3768
3769         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3770         (DumpRenderTree::dump):
3771             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
3772         (DumpRenderTree::dumpApplicationCacheQuota):
3773         * DumpRenderTree/qt/TestRunnerQt.cpp:
3774         (TestRunnerQt::reset):
3775         * DumpRenderTree/qt/TestRunnerQt.h:
3776         (TestRunnerQt):
3777
3778 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3779
3780         [Qt] Port DRT to use TestRunner::dumpAsText()
3781         https://bugs.webkit.org/show_bug.cgi?id=112260
3782
3783         Reviewed by Benjamin Poulain.
3784
3785         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3786         (WebCore::DumpRenderTree::open):
3787         (WebCore::methodNameStringForFailedTest):
3788             Change parameter from type TestRunnerQt* to TestRunner*.
3789         (WebCore::DumpRenderTree::dump):
3790             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3791             Instead we should rely on TestRunner::generatePixelResults().
3792         * DumpRenderTree/qt/TestRunnerQt.cpp:
3793         (TestRunnerQt::reset):
3794         * DumpRenderTree/qt/TestRunnerQt.h:
3795         (TestRunnerQt):
3796
3797 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3798
3799         Implement FontLoader interface
3800         https://bugs.webkit.org/show_bug.cgi?id=98395
3801
3802         Reviewed by Eric Seidel.
3803
3804         Enable FontLoadEvents runtime flag for TestShell.
3805
3806         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3807         (WebTestRunner::TestInterfaces::TestInterfaces):
3808
3809 2013-03-13  Julie Parent  <jparent@chromium.org>
3810
3811         CLeanup: remove unnecessary call to parseParameters.
3812         https://bugs.webkit.org/show_bug.cgi?id=112309
3813
3814         Reviewed by Ojan Vafai.
3815         
3816         We call parseCrossDashboardParameters when the dashboard initially
3817         loads to set the state required for loadBuildersList, and then we
3818         call it again once we are fully done with loading, so there is no
3819         reason to call it in the middle of the loading process here.
3820
3821         * TestResultServer/static-dashboards/loader.js:
3822         (.):
3823
3824 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3825
3826         Unreviewed. Now I'm a reviewer :)
3827
3828         * Scripts/webkitpy/common/config/committers.py:
3829
3830 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3831
3832         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3833         https://bugs.webkit.org/show_bug.cgi?id=112277
3834
3835         Reviewed by Adam Barth.
3836
3837         * Scripts/webkitperl/FeatureList.pm:
3838         * qmake/mkspecs/features/features.pri:
3839
3840 2013-03-13  Adam Barth  <abarth@webkit.org>
3841
3842         run-perf-tests should support content_shell
3843         https://bugs.webkit.org/show_bug.cgi?id=112291
3844
3845         Reviewed by Eric Seidel.
3846
3847         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3848         (PerfTestsRunner._parse_args):
3849
3850 2013-03-13  Oliver Hunt  <oliver@apple.com>
3851
3852         Simplify Checked<> multiplication
3853         https://bugs.webkit.org/show_bug.cgi?id=112286
3854
3855         Reviewed by James Robinson.
3856
3857         Add tests for multiplication by zero and max to ensure we don't
3858         mess them up should we ever make changes to Checked<> in future.
3859
3860         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3861         (TestWebKitAPI):
3862
3863 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3864
3865         [Qt] Unreviewed prospective Windows build fix
3866
3867         Do the usual thing, include the moc generated code in the .cpp file instead
3868         of compiling it standalone, to ensure that config.h is included, too, and
3869         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3870
3871         * DumpRenderTree/qt/EventSenderQt.cpp:
3872
3873 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3874
3875         [Qt] Port TestRunner::findString to shared interface
3876         https://bugs.webkit.org/show_bug.cgi?id=112147
3877
3878         Reviewed by Jocelyn Turcotte.
3879
3880         This patch also removes DumpRenderTree and some other helper classes from
3881         the WebCore namespace, to which they do not really belong.
3882
3883         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3884         (main):
3885         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3886         (DumpRenderTree::DumpRenderTree):
3887         (DumpRenderTree::~DumpRenderTree):
3888         (DumpRenderTree::instance):
3889         (DumpRenderTree::setShouldTimeout):
3890         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3891         (DumpRenderTree):
3892         * DumpRenderTree/qt/EventSenderQt.cpp:
3893         (EventSender::contextClick):
3894         (EventSender::sendEvent):
3895         (EventSender::postEvent):
3896         * DumpRenderTree/qt/EventSenderQt.h:
3897         (EventSender::isGraphicsBased):
3898         * DumpRenderTree/qt/TestRunnerQt.cpp:
3899         (TestRunnerQt::TestRunnerQt):
3900         (TestRunner::findString):
3901         (TestRunnerQt::setMockDeviceOrientation):
3902         (TestRunnerQt::setGeolocationPermission):
3903         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3904         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3905         (TestRunnerQt::setMockGeolocationPosition):
3906         * DumpRenderTree/qt/TestRunnerQt.h:
3907         (TestRunnerQt):
3908
3909 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3910
3911         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3912         https://bugs.webkit.org/show_bug.cgi?id=112129
3913
3914         Reviewed by Adam Barth.
3915
3916         Following Chromium
3917         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3918         this is being renamed to better explain what it does.
3919
3920         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3921
3922 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3923
3924         [Qt] Unreviewed trivial typo fix
3925
3926         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3927         TextRunner.h. Thanks Zeno :)
3928
3929 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3930
3931         [Qt] Prepare DRT for transition to shared TestRunner interface
3932         https://bugs.webkit.org/show_bug.cgi?id=112144
3933
3934         Reviewed by Benjamin Poulain.
3935
3936         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3937         the JSC C API based one.
3938
3939         This is impplemented by instantiating the QObject based testRunner in
3940         the global object, then instantiating the JSC C based TestRunner
3941         separately and placing it "behind" the QObject based testRunner through
3942         injection of the individual functions through proxies. (prototype
3943         chaining doesn't work due to the this object and Function.prototype.bind
3944         doesn't work due to the native function)
3945
3946         This allows for porting over method by method by removing the method
3947         from the QObject TestRunnerQt and implementing it in the JSC C based
3948         TestRunner.
3949
3950         In order for this to link and run dummy implementations of all the
3951         necessary TestRunner functions are provided.
3952
3953         * DumpRenderTree/qt/DumpRenderTree.pro:
3954         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3955         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3956         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3957         (WebCore::DumpRenderTree::initJSObjects):
3958         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3959         (DumpRenderTree):
3960         * DumpRenderTree/qt/TestRunnerQt.cpp:
3961         (TestRunner::~TestRunner):
3962         (TestRunner::addDisallowedURL):
3963         (TestRunner::queueLoad):
3964         (TestRunner::removeAllVisitedLinks):
3965         (TestRunner::setAcceptsEditing):
3966         (TestRunner::simulateLegacyWebNotificationClick):
3967         (TestRunner::setWindowIsKey):
3968         (TestRunner::setAlwaysAcceptCookies):
3969         (TestRunner::addOriginAccessWhitelistEntry):
3970         (TestRunner::setWebViewEditable):
3971         (TestRunner::clearAllApplicationCaches):
3972         (TestRunner::setTextDirection):
3973         (TestRunner::notifyDone):
3974         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3975         (TestRunner::overridePreference):
3976         (TestRunner::pathToLocalResource):
3977         (TestRunner::removeAllWebNotificationPermissions):
3978         (TestRunner::simulateWebNotificationClick):
3979         (TestRunner::closeIdleLocalStorageDatabases):
3980         (TestRunner::focusWebView):
3981         (TestRunner::setBackingScaleFactor):
3982         (TestRunner::removeChromeInputField):
3983         (TestRunner::addChromeInputField):
3984         (TestRunner::originsWithLocalStorage):
3985         (TestRunner::deleteAllLocalStorage):
3986         (TestRunner::deleteLocalStorageForOrigin):
3987         (TestRunner::observeStorageTrackerNotifications):
3988         (TestRunner::syncLocalStorage):
3989         (TestRunner::windowCount):
3990         (TestRunner::setWaitToDump):
3991         (TestRunner::waitForPolicyDelegate):
3992         (TestRunner::webHistoryItemCount):
3993         (TestRunner::showWebInspector):
3994         (TestRunner::closeWebInspector):
3995         (TestRunner::evaluateInWebInspector):
3996         (TestRunner::setSerializeHTTPLoads):
3997         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3998         (TestRunner::setCustomPolicyDelegate):
3999         (TestRunner::setDatabaseQuota):
4000         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
4001         (TestRunner::resetPageVisibility):
4002         (TestRunner::keepWebHistory):
4003         (TestRunner::goBack):
4004         (TestRunner::originsWithApplicationCache):
4005         (TestRunner::applicationCacheDiskUsageForOrigin):
4006         (TestRunner::display):
4007         (TestRunner::dispatchPendingLoadRequests):
4008         (TestRunner::clearPersistentUserStyleSheet):
4009         (TestRunner::callShouldCloseOnWebView):
4010         (TestRunner::copyDecodedHostName):
4011         (TestRunner::clearBackForwardList):
4012         (TestRunner::clearAllDatabases):
4013         (TestRunner::clearApplicationCacheForOrigin):
4014         (TestRunner::apiTestGoToCurrentBackForwardItem):
4015         (TestRunner::authenticateSession):
4016         (TestRunner::abortModal):
4017         (TestRunner::setStorageDatabaseIdleInterval):
4018         (TestRunner::setAsynchronousSpellCheckingEnabled):
4019         (TestRunner::setXSSAuditorEnabled):
4020         (TestRunner::setSpatialNavigationEnabled):
4021         (TestRunner::setScrollbarPolicy):
4022         (TestRunner::setJavaScriptCanAccessClipboard):
4023         (TestRunner::setAutomaticLinkDetectionEnabled):
4024         (TestRunner::setUserStyleSheetEnabled):
4025         (TestRunner::setUserStyleSheetLocation):
4026         (TestRunner::setUseDashboardCompatibilityMode):
4027         (TestRunner::setTabKeyCyclesThroughElements):
4028         (TestRunner::setSmartInsertDeleteEnabled):
4029         (TestRunner::setSelectTrailingWhitespaceEnabled):
4030         (TestRunner::setPrivateBrowsingEnabled):
4031         (TestRunner::setPluginsEnabled):
4032         (TestRunner::setPopupBlockingEnabled):
4033         (TestRunner::setMockSpeechInputDumpRect):
4034         (TestRunner::setPersistentUserStyleSheetLocation):
4035         (TestRunner::setMockGeolocationPosition):
4036         (TestRunner::setMockGeolocationPositionUnavailableError):
4037         (TestRunner::setMockDeviceOrientation):
4038         (TestRunner::setMainFrameIsFirstResponder):
4039         (TestRunner::setIconDatabaseEnabled):
4040         (TestRunner::setGeolocationPermission):
4041         (TestRunner::setDefersLoading):
4042         (TestRunner::setCacheModel):
4043         (TestRunner::setAuthorAndUserStylesEnabled):
4044         (TestRunner::setAllowFileAccessFromFileURLs):
4045         (TestRunner::setAppCacheMaximumSize):
4046         (TestRunner::setAllowUniversalAccessFromFileURLs):
4047         (TestRunner::setApplicationCacheOriginQuota):
4048         (TestRunner::denyWebNotificationPermission):
4049         (TestRunner::grantWebNotificationPermission):
4050         (TestRunner::setValueForUser):
4051         (TestRunner::setViewModeMediaFeature):
4052         (TestRunner::setPageVisibility):
4053         (TestRunner::addMockSpeechInputResult):
4054         (TestRunner::removeOriginAccessWhitelistEntry):
4055         (TestRunner::addUserScript):
4056         (TestRunner::isCommandEnabled):
4057         (TestRunner::evaluateScriptInIsolatedWorld):
4058         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
4059         (TestRunner::copyEncodedHostName):
4060         (TestRunner::addUserStyleSheet):
4061         (TestRunner::findString):
4062         (TestRunner::execCommand):
4063         (TestRunner::localStorageDiskUsageForOrigin):
4064
4065 2013-03-12  Julie Parent  <jparent@chromium.org>
4066
4067         Cleanup: Move flatten-trie to loader.
4068         https://bugs.webkit.org/show_bug.cgi?id=112196
4069
4070         Reviewed by Dirk Pranke.
4071
4072         flatten-trie is used only by the loader, so move it there and make it
4073         private, rather than global in dashbaord_base. Moved the corresponding
4074         unit test from flakiness_dashboard_unittests to loader_unittests.
4075         
4076         * TestResultServer/static-dashboards/dashboard_base.js:
4077         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4078         * TestResultServer/static-dashboards/loader.js:
4079         (.):
4080         * TestResultServer/static-dashboards/loader_unittests.js:
4081
4082 2013-03-12  Oliver Hunt  <oliver@apple.com>
4083
4084         Unbreak api tests
4085
4086         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4087         (TestWebKitAPI):
4088
4089 2013-03-12  Tim Horton  <timothy_horton@apple.com>
4090
4091         Unreviewed, disabling tests for Win EWS.
4092
4093         win-ews obviously cannot keep up with running tests, it's >300 behind.
4094         Probably doesn't help that its (likely) running tests serially.
4095
4096         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4097         (WinEWS):
4098
4099 2013-03-12  Tim Horton  <timothy_horton@apple.com>
4100
4101         Add a --build-directory argument to delete-stale-build-files
4102         https://bugs.webkit.org/show_bug.cgi?id=112198
4103
4104         Reviewed by Ryosuke Niwa.
4105
4106         * BuildSlaveSupport/delete-stale-build-files:
4107         (main): Add --build-directory argument.
4108
4109 2013-03-12  Oliver Hunt  <oliver@apple.com>
4110
4111         Appease MSVC
4112
4113         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4114         (TestWebKitAPI):
4115
4116 2013-03-12  Oliver Hunt  <oliver@apple.com>
4117
4118         Add more Checked<> tests
4119         https://bugs.webkit.org/show_bug.cgi?id=112190
4120
4121         Reviewed by Geoffrey Garen.
4122
4123         Tests!
4124
4125         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4126         (TestWebKitAPI):
4127
4128 2013-03-12  Julie Parent  <jparent@chromium.org>
4129
4130         Cleanup: Move loading complete function into callback, rather than global.
4131         https://bugs.webkit.org/show_bug.cgi?id=112167
4132
4133         Reviewed by Dirk Pranke.
4134         
4135         Stop calling global functions, pass in proper handler to Loader
4136         constructor. Note that the callback is optional, as tests, and
4137         some potential dashboards, do not need one.
4138
4139         * TestResultServer/static-dashboards/dashboard_base.js:
4140         * TestResultServer/static-dashboards/loader.js:
4141         (.):
4142         * TestResultServer/static-dashboards/loader_unittests.js:
4143
4144 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4145
4146         [EFL][WK2] Add popup menu support to MiniBrowser
4147         https://bugs.webkit.org/show_bug.cgi?id=108934
4148
4149         Reviewed by Kenneth Rohde Christiansen.
4150
4151         Implement popup menu support in MiniBrowser by handling popup_menu_show
4152         and popup_menu_hide smart functions on the view and using the Ewk popup
4153         menu API.
4154
4155         * MiniBrowser/efl/main.c:
4156         (_Browser_Window):
4157         (on_popup_menu_discarded):
4158         (on_popup_menu_item_clicked):
4159         (popup_menu_populate):
4160         (on_popup_menu_show):
4161         (on_popup_menu_hide):
4162         (window_create): Use calloc() instead of malloc() to allocate memory for
4163         Browser_Window. This makes sure all the structs members are initialized
4164         to 0 (such as the new elm_popup_menu pointer).
4165
4166 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
4167
4168         [GTK] Set up the libPlatformGtk.la library
4169         https://bugs.webkit.org/show_bug.cgi?id=111738
4170
4171         Reviewed by Martin Robinson.
4172
4173         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
4174         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
4175         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
4176
4177 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
4178
4179         [GTK] Enable Web Audio in development builds
4180         https://bugs.webkit.org/show_bug.cgi?id=111831
4181
4182         Reviewed by Philippe Normand.
4183
4184         Web Audio is already quite well supported on the GTK port but still has a few issues
4185         that must be addressed before it is enabled by default. Despite that it should be enabled
4186         in development builds just so we are up-to-date with future feature infrastructure changes.
4187         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
4188         that's an obvious goal before enabling the feature in release builds.
4189
4190         * Scripts/webkitperl/FeatureList.pm:
4191
4192 2013-03-11  Andreas Kling  <akling@apple.com>
4193
4194         [Mac][WK1] Add support for alert() in MiniBrowser.
4195         <http://webkit.org/b/112090>
4196
4197         Reviewed by Anders Carlsson.
4198
4199         * MiniBrowser/mac/WK1BrowserWindowController.m:
4200         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
4201
4202 2013-03-11  Julie Parent  <jparent@chromium.org>
4203
4204         Dashboard cleanup: Create ui.Errors
4205         https://bugs.webkit.org/show_bug.cgi?id=111785
4206
4207         Reviewed by Ojan Vafai.
4208         
4209         Create ui.Errors for handling errors the dashboards
4210         encounter. Loader now has a Error object that it can add to,
4211         and individual dashboards can show errors when desired.
4212         Currently, only flakiness_db shows errors, but this is 
4213         generic and there is no reason why other dbs wouldn't want to
4214         show errors.
4215
4216         * TestResultServer/static-dashboards/dashboard_base.js:
4217         (resourceLoadingComplete):
4218         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4219         (generatePage):
4220         * TestResultServer/static-dashboards/loader.js:
4221         (.):
4222         * TestResultServer/static-dashboards/ui.js:
4223         (.):
4224
4225 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
4226
4227         Some StringHasher tests are broken because of missing null termination
4228         https://bugs.webkit.org/show_bug.cgi?id=111284
4229
4230         Reviewed by Darin Adler.
4231
4232         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
4233         (TestWebKitAPI): Added null termination since C strings are null-terminated.
4234         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
4235         the bug caught by it is now fixed.
4236
4237 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
4238
4239         Unreviewed, rolling out r145200.
4240         http://trac.webkit.org/changeset/145200
4241         https://bugs.webkit.org/show_bug.cgi?id=112063
4242
4243         Broke a couple of unit tests (Requested by zdobersek on
4244         #webkit).
4245
4246         * Scripts/webkitperl/FeatureList.pm:
4247
4248 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
4249
4250         [GTK] WebKit2-only build fails
4251         https://bugs.webkit.org/show_bug.cgi?id=112033
4252
4253         Reviewed by Gustavo Noronha Silva.
4254
4255         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
4256         generic part, WebKit1-specific part and WebKit2-specific part.
4257         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
4258         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
4259         directly.
4260
4261 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
4262
4263         Adding myself to the committers list.
4264
4265         Unreviewed.
4266
4267         * Scripts/webkitpy/common/config/committers.py:
4268
4269 2013-03-11  Jeff Rogers  <jrogers@rim.com>
4270
4271         [BlackBerry] Disable MathML support
4272         https://bugs.webkit.org/show_bug.cgi?id=111929
4273
4274         Reviewed by Rob Buis.
4275
4276         * Scripts/webkitperl/FeatureList.pm:
4277
4278 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4279
4280         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
4281         https://bugs.webkit.org/show_bug.cgi?id=111970
4282
4283         Reviewed by Chris Fleizach.
4284
4285         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
4286         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
4287         undefined symbol.
4288
4289         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4290         (WTR::AccessibilityUIElement::supportedActions):