Add an address-of operator to RetainPtr
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-15  Anders Carlsson  <andersca@apple.com>
2
3         Add an address-of operator to RetainPtr
4         https://bugs.webkit.org/show_bug.cgi?id=160879
5
6         Reviewed by Tim Horton.
7
8         Test HashMap and HashSet with an object whose operator& is deleted.
9
10         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11         Sort the Xcode project.
12
13         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
14         (DeletedAddressOfOperator::DeletedAddressOfOperator):
15         (DeletedAddressOfOperator::value):
16         (DeletedAddressOfOperator::operator==):
17         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
18         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
19         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
20         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
21         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
22         (TestWebKitAPI::TEST):
23         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
24         (TestWebKitAPI::TEST):
25
26 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
27
28         False crashes in fast/text/emoji-gender-* tests
29         https://bugs.webkit.org/show_bug.cgi?id=160779
30
31         Reviewed by Alexey Proskuryakov.
32
33         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
34
35         * Scripts/webkitpy/port/driver.py:
36         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
37         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
38         * Scripts/webkitpy/port/server_process.py:
39         (ServerProcess.write): Allow caller to disable crash flag on exception.
40
41 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
42
43         webkitpy error in TestRunResults.merge()
44         https://bugs.webkit.org/show_bug.cgi?id=160882
45
46         Reviewed by Daniel Bates.
47         
48         The argument to TestRunResults.merge() can be None if there are no device-specifc
49         initial results or retry results in Manager.run(), so just return early in that case.
50
51         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
52         (TestRunResults.merge):
53
54 2016-08-15  Sam Weinig  <sam@webkit.org>
55
56         Speed up compile times by not including wtf/Variant.h so much
57         https://bugs.webkit.org/show_bug.cgi?id=160847
58
59         Reviewed by Alex Christensen and Saam Barati.
60
61         * TestWebKitAPI/Tests/WTF/Variant.cpp:
62         (TestWebKitAPI::TEST):
63         Explicitly use std::experimental::variant.
64
65 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
66
67         Allow a port to run tests with a custom device setup
68         https://bugs.webkit.org/show_bug.cgi?id=160833
69
70         Reviewed by Daniel Bates.
71
72         These changes allow the IOSSimulator port to run tests in iPad mode.
73
74         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
75         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
76         a custom device will be collected into a set, and run in that device's environment after
77         the other tests have run.
78
79         * Scripts/webkitpy/layout_tests/controllers/manager.py:
80         (Manager._custom_device_for_test): If the test contains a directory matching a
81         custom device suffix, return that custom device.
82         (Manager._set_up_run): Push the custom device class, if any, into options so
83         that the Worker can get to it.
84         (Manager.run): Go through the list of tests, and break it down into device-generic
85         tests, and tests for each device class. _run_test_subset is then called for
86         each collection of tests, and the results merged.
87         (Manager._run_test_subset): Some lines unwrapped.
88         (Manager._end_test_run):
89         (Manager._run_tests):
90         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
91         (SingleTestRunner.__init__): Unwrapped a line.
92         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
93         (TestRunResults.merge): Add this function to merge TestRunResults
94         * Scripts/webkitpy/layout_tests/views/printing.py:
95         (Printer.print_workers_and_shards): Print the custom device, if any.
96         * Scripts/webkitpy/port/base.py:
97         (Port): Base port has empty array of custom devices.
98         (Port.setup_test_run): Add device_class argument.
99         * Scripts/webkitpy/port/driver.py:
100         (DriverInput.__repr__):
101         (Driver.check_driver.implementation):
102         * Scripts/webkitpy/port/efl.py:
103         (EflPort.setup_test_run):
104         * Scripts/webkitpy/port/gtk.py:
105         (GtkPort.setup_test_run):
106         * Scripts/webkitpy/port/ios.py:
107         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
108         (IOSSimulatorPort.__init__):
109         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
110         based on the custom device class.
111         (IOSSimulatorPort._set_device_class):
112         (IOSSimulatorPort._create_simulators): Factor some code into this function.
113         (IOSSimulatorPort.setup_test_run):
114         (IOSSimulatorPort.testing_device):
115         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
116         seemed wrong for this function. That was moved to setup_test_run().
117         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
118         but this happened too early, before we knew which kind of devices to create. Devices
119         are now created in setup_test_run().
120         * Scripts/webkitpy/port/win.py:
121         (WinPort.setup_test_run):
122
123 2016-08-15  Daniel Bates  <dabates@apple.com>
124
125         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
126         private frameworks and libraries
127         https://bugs.webkit.org/show_bug.cgi?id=155931
128         <rdar://problem/25807989>
129
130         Reviewed by Dan Bernstein.
131
132         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
133         where X is the major version of the active iOS SDK.
134
135         * DumpRenderTree/mac/Configurations/Base.xcconfig:
136         * WebKitTestRunner/Configurations/Base.xcconfig:
137
138 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
139
140         Add a setting and preferences to enable visual viewport mode
141         https://bugs.webkit.org/show_bug.cgi?id=160843
142
143         Reviewed by Sam Weinig.
144         
145         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
146
147         * MiniBrowser/mac/SettingsController.h:
148         * MiniBrowser/mac/SettingsController.m:
149         (-[SettingsController _populateMenu]):
150         (-[SettingsController validateMenuItem:]):
151         (-[SettingsController visualViewportEnabled]):
152         (-[SettingsController toggleVisualViewportEnabled:]):
153         * MiniBrowser/mac/WK1BrowserWindowController.m:
154         (-[WK1BrowserWindowController didChangeSettings]):
155         * MiniBrowser/mac/WK2BrowserWindowController.m:
156         (-[WK2BrowserWindowController didChangeSettings]):
157
158 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
159
160         Allow using make-dist with non-GTK ports
161         https://bugs.webkit.org/show_bug.cgi?id=160842
162
163         Reviewed by Michael Catanzaro.
164
165         This patch adds support for setting base name of tarball and argument
166         passed to cmake's -DPORT= via command line arguments.
167
168         * gtk/make-dist.py:
169         (Distcheck.configure):
170         (Distcheck.check):
171         (get_tarball_root_and_output_filename_from_arguments):
172
173 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
174
175         [GTK] Install script lacks gstreamer related dependencies
176         https://bugs.webkit.org/show_bug.cgi?id=160814
177
178         Reviewed by Carlos Garcia Campos.
179
180         * gtk/install-dependencies: Fedora case had already listed this dependencies,
181         but both Arch and Debian/Ubuntu were missing them.
182
183 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
184
185         make-dist.py should not allow unknown rules in manifest
186         https://bugs.webkit.org/show_bug.cgi?id=160841
187
188         Reviewed by Carlos Garcia Campos.
189
190         * gtk/make-dist.py:
191         (Manifest.process_line):
192
193 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
194
195         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
196         https://bugs.webkit.org/show_bug.cgi?id=160809
197
198         Reviewed by Carlos Garcia Campos.
199
200         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
201         case, and use it also for the new package names of libpng and libgeoclue.
202         * gtk/install-dependencies: Ditto.
203
204 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
205
206         Skip to check directories existence in build-webkit
207         https://bugs.webkit.org/show_bug.cgi?id=160691
208
209         Reviewed by Alex Christensen.
210
211         CMake checks if directories are there itself. So CMake ports
212         don't need to check it in the build-webkit script.
213
214         * Scripts/build-webkit:
215         * Scripts/webkitdirs.pm:
216         (determineSourceDir):
217         (isCMakeBuild):
218
219 2016-08-12  Alex Christensen  <achristensen@webkit.org>
220
221         Make URLParser work with URLs missing URL parts
222         https://bugs.webkit.org/show_bug.cgi?id=160824
223
224         Reviewed by Brady Eidson.
225
226         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
227         (TestWebKitAPI::s):
228         (TestWebKitAPI::checkURL):
229         (TestWebKitAPI::TEST_F):
230         (TestWebKitAPI::eq): Deleted.
231
232 2016-08-12  John Wilander  <wilander@apple.com>
233
234         Add HashCountedSet API tests to TestWTFLibrary target
235         https://bugs.webkit.org/show_bug.cgi?id=160815
236
237         Reviewed by Alex Christensen.
238
239         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
240             Added HashCountedSet.cpp and sorted the file reference section
241             according to UNIX sort.
242
243 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
244
245         run-benchmark should run JetStream 1.1 instead of 1.0.1
246         https://bugs.webkit.org/show_bug.cgi?id=160816
247
248         Reviewed by Filip Pizlo.
249
250         Use the latest JetStream 1.1 in run-benchmark.
251
252         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
253         (BenchmarkBuilder.__exit__):
254         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
255         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
256         change to JetStream directory.
257
258 2016-08-12  Alex Christensen  <achristensen@webkit.org>
259
260         Initial URLParser implementation
261         https://bugs.webkit.org/show_bug.cgi?id=160811
262
263         Reviewed by Brady Eidson.
264
265         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
266         (TestWebKitAPI::eq):
267         (TestWebKitAPI::checkURL):
268         (TestWebKitAPI::TEST_F):
269
270 2016-08-12  Brady Eidson  <beidson@apple.com>
271
272         Fix the 32-bit Mac build after:
273         Add WK2 ExperimentalFeature support to MiniBrowser
274         https://bugs.webkit.org/show_bug.cgi?id=160788
275
276         Unreviewed.
277
278         Sprinkle "#if WK_API_ENABLED"s liberally.
279         
280         * MiniBrowser/mac/AppDelegate.m:
281         (defaultConfiguration):
282         * MiniBrowser/mac/SettingsController.m:
283         (-[SettingsController _populateMenu]):
284         (-[SettingsController validateMenuItem:]):
285
286 2016-08-12  Philippe Normand  <pnormand@igalia.com>
287
288         [GStreamer][OWR] Video rendering fixes
289         https://bugs.webkit.org/show_bug.cgi?id=160764
290
291         Reviewed by Xabier Rodriguez-Calvar.
292
293         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
294
295 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
296
297         Add missing return statement in convertFast function added in r204376.
298
299         Unreviewed.
300
301         * Scripts/webkitpy/common/system/path.py:
302         (_CygPath.convertFast):
303
304 2016-08-11  Brady Eidson  <beidson@apple.com>
305
306         Add WK2 ExperimentalFeature support to MiniBrowser.
307         https://bugs.webkit.org/show_bug.cgi?id=160788
308
309         Reviewed by Alex Christensen.
310
311         * MiniBrowser/mac/AppDelegate.h:
312         * MiniBrowser/mac/AppDelegate.m:
313         (defaultConfiguration):
314         (defaultPreferences):
315         
316         * MiniBrowser/mac/SettingsController.m:
317         (-[SettingsController _populateMenu]):
318         (-[SettingsController validateMenuItem:]):
319         (-[SettingsController toggleExperimentalFeature:]):
320
321 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
322
323         Keep EWS logs for longer
324         https://bugs.webkit.org/show_bug.cgi?id=160776
325
326         Reviewed by Daniel Bates.
327
328         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
329
330 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
331
332         iOS DRT/WTR project cleanup
333         https://bugs.webkit.org/show_bug.cgi?id=160778
334
335         Reviewed by Tim Horton.
336
337         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
338
339         Remove AppDelegate.* which were unused.
340
341         Exclude ios/Launch.storyboard on more platforms.
342
343         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
344         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
345         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
346         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
347         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
348         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
349         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
350
351 2016-08-11  Alex Christensen  <achristensen@webkit.org>
352
353         Fix Yosemite bots' cookie accept policies after r204365.
354         https://bugs.webkit.org/show_bug.cgi?id=160758
355
356         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
357         (TEST):
358         This makes the test fully clean up after itself.
359
360 2016-08-11  Alex Christensen  <achristensen@webkit.org>
361
362         Fix Yosemite bots' cookie accept policies after r204365.
363         https://bugs.webkit.org/show_bug.cgi?id=160758
364
365         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
366         (TEST):
367         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
368         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
369         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
370         causing any problems because there are no other API tests that do anything with cookies.
371         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
372         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
373         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
374
375 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
376
377         EWS should check if the patch is still valid before executing every major step
378         https://bugs.webkit.org/show_bug.cgi?id=160739
379         rdar://problem/27768813
380
381         Reviewed by Alexey Proskuryakov.
382
383         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
384         (CommitQueueTask.run): validate method is now executed in base class.
385         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
386         (EarlyWarningSystemTask.run): validate method is now executed in base class.
387         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
388         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
389         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
390         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
391         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
392         * Scripts/webkitpy/tool/commands/perfalizer.py:
393         (PerfalizerTask.validate): Added.
394         * Scripts/webkitpy/tool/commands/queues_unittest.py:
395         (test_manual_reject_during_processing): Updated test case.
396
397 2016-08-11  Alex Christensen  <achristensen@webkit.org>
398
399         Add URLParser stub
400         https://bugs.webkit.org/show_bug.cgi?id=160770
401
402         Reviewed by Sam Weinig.
403
404         * TestWebKitAPI/PlatformGTK.cmake:
405         * TestWebKitAPI/PlatformWin.cmake:
406         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
407         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
408         (TestWebKitAPI::TEST_F):
409
410 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
411
412         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
413         https://bugs.webkit.org/show_bug.cgi?id=160761
414
415         Reviewed by Tim Horton.
416
417         Give iOS DRT a Launch storyboard.
418
419         Have it use a UIViewController so future forms testing works correctly.
420
421         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
422         can run in iPad mode.
423
424         Remove empty InfoPlist.strings files.
425
426         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
427         * DumpRenderTree/ios/Info.plist:
428         * DumpRenderTree/ios/Launch.storyboard: Added.
429         * DumpRenderTree/mac/DumpRenderTree.mm:
430         (createWebViewAndOffscreenWindow):
431         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
432         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
433         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
434         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
435
436 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
437
438         [Win] Unable to reliably run tests in parallel
439         https://bugs.webkit.org/show_bug.cgi?id=140914
440
441         Reviewed by Brent Fulgham.
442
443         The cygpath utility function can fail badly when running with multiple DumpRenderTree
444         processes. We can use string replacement to convert the Cygwin path to a Windows path
445         instead.
446
447         * Scripts/webkitpy/common/system/path.py:
448         (cygpathFast):
449         * Scripts/webkitpy/port/driver.py:
450         (Driver._command_from_driver_input):
451
452 2016-08-10  Alex Christensen  <achristensen@webkit.org>
453
454         Fix crash when changing cookie accept policy after r204327
455         https://bugs.webkit.org/show_bug.cgi?id=160758
456
457         Reviewed by Simon Fraser.
458
459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
460         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
461         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
462         (TEST):
463         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
464
465 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
466
467         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
468         https://bugs.webkit.org/show_bug.cgi?id=160757
469
470         Reviewed by Tim Horton.
471
472         When programmatically creating the test UIWindow, make a root UIViewController and parent
473         the WKWebView in its view. This makes the app more like a normal UIKit application.
474         
475         Move the WKWebView down 20px to avoid the status bar.
476         
477         Give the UIWindow a gray background so it's obvious where the window and view positioned.
478
479         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
480         
481         Remove duplicate references to Launch.storyboard.
482
483         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
484         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
485         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
486         (-[AppDelegate applicationWillResignActive:]): Deleted.
487         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
488         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
489         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
490         (-[AppDelegate applicationWillTerminate:]): Deleted.
491         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
492         (WTR::viewRectForWindowRect):
493         (WTR::PlatformWebView::PlatformWebView):
494         (WTR::PlatformWebView::setWindowFrame):
495
496 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
497
498         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
499         https://bugs.webkit.org/show_bug.cgi?id=160748
500
501         Reviewed by Tim Horton.
502         
503         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
504         opens the door for tests using other device sizes.
505
506         * WebKitTestRunner/ios/TestControllerIOS.mm:
507         (WTR::TestController::platformConfigureViewForTest):
508
509 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
510
511         Sort the feature flags in the FEATURE_DEFINES lines
512         https://bugs.webkit.org/show_bug.cgi?id=160742
513
514         Reviewed by Anders Carlsson.
515         
516         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
517
518 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
519
520         Logging and other minor improvements to iOS webkitpy
521         https://bugs.webkit.org/show_bug.cgi?id=160722
522
523         Reviewed by Dan Bates.
524
525         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
526         to make it easier to debug launching issues.
527
528         Have reset_preferences() reset the device, rather than just nuking the data
529         directory (which broke some versions of the simulator).
530
531         Make the Simulator.app launch in the background with open -g.
532
533         Wait for the simulator device to be in a known state in some more places.
534
535         * Scripts/webkitpy/port/ios.py:
536         (IOSSimulatorPort.setup_test_run):
537         (IOSSimulatorPort._quit_ios_simulator):
538         (IOSSimulatorPort.clean_up_test_run):
539         (IOSSimulatorPort.setup_environ_for_server):
540         (IOSSimulatorPort.reset_preferences):
541         * Scripts/webkitpy/xcode/simulator.py:
542         (Device.create):
543         (Device.delete):
544         (Device):
545         (Device.reset):
546         (Simulator.wait_until_device_is_booted):
547         (Simulator.wait_until_device_is_in_state):
548         (Simulator):
549         (Simulator.delete_device):
550         (Simulator.reset_device):
551         (Simulator.lookup_or_create_device):
552
553 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
554
555         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
556         https://bugs.webkit.org/show_bug.cgi?id=160697
557
558         Reviewed by Antonio Gomes.
559
560         * Scripts/webkitpy/port/base.py:
561         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
562         list of environment variables to copy.
563
564 2016-08-09  George Ruan  <gruan@apple.com>
565
566         Implement functionality of media capture on iOS
567         https://bugs.webkit.org/show_bug.cgi?id=158945
568         <rdar://problem/26893343>
569
570         Reviewed by Tim Horton.
571
572         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
573         Capture feature on iOS.
574
575 2016-08-09  Saam Barati  <sbarati@apple.com>
576
577         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
578         https://bugs.webkit.org/show_bug.cgi?id=160671
579         <rdar://problem/27756112>
580
581         Reviewed by Mark Lam.
582
583         * Scripts/run-jsc-stress-tests:
584
585 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
586
587         Make directory reading code in iOSSimulatorDevices() more strict
588         https://bugs.webkit.org/show_bug.cgi?id=160702
589
590         Reviewed by Tim Horton.
591
592         * Scripts/webkitdirs.pm:
593         (iOSSimulatorDevices):
594
595 2016-08-06  Sam Weinig  <sam@webkit.org>
596
597         Replace NodeOrString with std::variant<RefPtr<Node>, String>
598         https://bugs.webkit.org/show_bug.cgi?id=160638
599
600         Reviewed by Anders Carlsson.
601
602         * TestWebKitAPI/CMakeLists.txt:
603         * TestWebKitAPI/Tests/WTF/Variant.cpp:
604         Add additional tests for the initial state of std::variant and using
605         makeVisitor for visiting.
606
607 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
608
609         EWS logging should ensure the logging to file is stopped on queue termination
610         https://bugs.webkit.org/show_bug.cgi?id=160698
611         rdar://problem/24464570
612
613         Reviewed by Daniel Bates.
614
615         * Scripts/webkitpy/tool/bot/queueengine.py:
616         (QueueEngine._stopping): Stop logging to file on queue termination.
617         (QueueEngine._begin_logging): Configure the Python logger to log to file.
618         * Scripts/webkitpy/common/system/logutils.py:
619         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
620         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
621         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
622         * Scripts/webkitpy/tool/commands/queues.py:
623         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
624         (AbstractQueue.queue_log_path): Same.
625         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
626         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
627         which moved to QueueEngine now.
628         (PatchProcessingQueue.__init__): Same.
629         (CommitQueue.__init__): Same.
630         (AbstractReviewQueue.__init__): Same.
631         (StyleQueue.__init__): Same.
632         * Scripts/webkitpy/tool/commands/queues_unittest.py:
633         (TestCommitQueue): Removed host parameter.
634         (TestCommitQueue.__init__): Same.
635         (AbstractPatchQueueTest.test_next_patch): Same.
636         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
637         (test_commit_queue_failure): Same.
638         (mock_run_webkit_patch):
639         (MockCommitQueueTask.results_from_patch_test_run): Same.
640         (test_rollout_lands): Same.
641         (test_non_valid_patch): Same.
642         (test_auto_retry): Same.
643         (test_style_queue_with_watch_list_exception): Same.
644         (TestQueue.__init__): Deleted.
645         (TestReviewQueue.__init__): Deleted.
646         (TestFeederQueue.__init__): Deleted.
647
648 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
649
650         webkit-gtk tarball fails to build due to missing files
651         https://bugs.webkit.org/show_bug.cgi?id=160684
652
653         Reviewed by Alex Christensen.
654
655         * gtk/manifest.txt.in: Added back spi directories.
656
657 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
658
659         [GTK] Build the jhbuild with -O2 optimization level by default
660         https://bugs.webkit.org/show_bug.cgi?id=160544
661
662         Reviewed by Michael Catanzaro.
663
664         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
665         which don't increases the required disk space significatively and
666         provides better debug information than no passing it.
667
668 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
669
670         Allow more --cmakeargs option in build-jsc and build-webkit
671         https://bugs.webkit.org/show_bug.cgi?id=160340
672
673         Reviewed by Michael Catanzaro.
674
675         * Scripts/build-jsc:
676         * Scripts/build-webkit:
677
678 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
679
680         Do not check if WebKitLibraries folder exists on EFL and GTK
681         https://bugs.webkit.org/show_bug.cgi?id=160659
682
683         Reviewed by Csaba Osztrogonác.
684
685         Though WebKitLibraries is only needed by mac and win ports,
686         EFL and GTK ports have checked whether it exists.
687
688         * Scripts/build-webkit:
689
690 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
691
692         Some EWS console logs doesn't go to log file
693         https://bugs.webkit.org/show_bug.cgi?id=160585
694         rdar://problem/24464570
695
696         Reviewed by Daniel Bates.
697
698         * Scripts/webkitpy/common/system/logutils.py:
699         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
700         any possible overwriting.
701         * Scripts/webkitpy/common/system/filesystem.py:
702         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
703         * Scripts/webkitpy/common/system/filesystem_mock.py:
704         (MockFileSystem.open_text_file_for_writing): Same.
705         * Scripts/webkitpy/common/system/filesystem_unittest.py:
706         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
707         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
708         * Scripts/webkitpy/tool/commands/queues.py:
709         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
710         This will ensure that all the sub-modules inside webkitpy will log to file.
711
712 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
713
714         Have the iOS platform interit from the Apple platform in webkitpy
715         https://bugs.webkit.org/show_bug.cgi?id=160672
716
717         Reviewed by Dan Bates.
718         
719         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
720         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
721         ApplePort.
722         
723         Since WinPort also inherits from ApplePort, it needs to stub out some things
724         that are unavailable on Windows (leaks, sampling).
725         
726         Some SnowLeopard-related code and the associated test were removed.
727
728         * Scripts/webkitpy/port/apple.py:
729         (ApplePort.__init__):
730         (ApplePort):
731         (ApplePort._make_leak_detector):
732         (ApplePort.default_timeout_ms):
733         (ApplePort.supports_per_test_timeout):
734         (ApplePort.should_retry_crashes):
735         (ApplePort._generate_all_test_configurations):
736         (ApplePort.check_for_leaks):
737         (ApplePort.print_leaks_summary):
738         (ApplePort._path_to_webcore_library):
739         (ApplePort.show_results_html_file):
740         (ApplePort._merge_crash_logs):
741         (ApplePort._look_for_all_crash_logs_in_log_dir):
742         (ApplePort._get_crash_log):
743         (ApplePort.look_for_new_crash_logs):
744         (ApplePort.sample_process):
745         (ApplePort.sample_file_path):
746         (ApplePort.look_for_new_samples):
747         (ApplePort._path_to_helper):
748         (ApplePort.determine_full_port_name): Deleted.
749         * Scripts/webkitpy/port/ios.py:
750         (IOSSimulatorPort):
751         (IOSSimulatorPort.__init__):
752         (IOSSimulatorPort.default_timeout_ms): Deleted.
753         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
754         (IOSSimulatorPort.should_retry_crashes): Deleted.
755         (IOSSimulatorPort.check_for_leaks): Deleted.
756         (IOSSimulatorPort.print_leaks_summary): Deleted.
757         (IOSSimulatorPort._path_to_webcore_library): Deleted.
758         (IOSSimulatorPort.show_results_html_file): Deleted.
759         (IOSSimulatorPort.sample_file_path): Deleted.
760         (IOSSimulatorPort._merge_crash_logs): Deleted.
761         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
762         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
763         (IOSSimulatorPort.look_for_new_samples): Deleted.
764         (IOSSimulatorPort.sample_process): Deleted.
765         (IOSSimulatorPort._path_to_helper): Deleted.
766         (IOSSimulatorPort.make_command): Deleted.
767         * Scripts/webkitpy/port/mac.py:
768         (MacPort.__init__):
769         (MacPort.make_command):
770         (MacPort._build_java_test_support):
771         (MacPort): Deleted.
772         (MacPort.default_timeout_ms): Deleted.
773         (MacPort.supports_per_test_timeout): Deleted.
774         (MacPort.should_retry_crashes): Deleted.
775         (MacPort.default_child_processes): Deleted.
776         (MacPort.check_for_leaks): Deleted.
777         (MacPort.print_leaks_summary): Deleted.
778         (MacPort._path_to_webcore_library): Deleted.
779         (MacPort.show_results_html_file): Deleted.
780         (MacPort.sample_file_path): Deleted.
781         (MacPort._merge_crash_logs): Deleted.
782         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
783         (MacPort.look_for_new_crash_logs): Deleted.
784         (MacPort.look_for_new_samples): Deleted.
785         (MacPort.sample_process): Deleted.
786         (MacPort._path_to_helper): Deleted.
787         * Scripts/webkitpy/port/mac_unittest.py:
788         (MacTest.test_default_child_processes): Deleted.
789         * Scripts/webkitpy/port/win.py:
790         (WinPort.look_for_new_samples):
791         (WinPort):
792         (WinPort.sample_process):
793         (WinPort._make_leak_detector):
794         (WinPort.check_for_leaks):
795         (WinPort.print_leaks_summary):
796         (WinPort._path_to_webcore_library):
797
798 2016-08-08  Matt Baker  <mattbaker@apple.com>
799
800         Unreviewed: moved myself to the reviewers list.
801
802         * Scripts/webkitpy/common/config/contributors.json:
803
804 2016-08-08  Chris Dumez  <cdumez@apple.com>
805
806         Update API tests in mac/SetDocumentURI.mm after r204247
807         https://bugs.webkit.org/show_bug.cgi?id=160660
808
809         Reviewed by Alex Christensen.
810
811         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
812         (TestWebKitAPI::TEST):
813
814 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
815
816         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
817         https://bugs.webkit.org/show_bug.cgi?id=159827
818
819         Reviewed by Daniel Bates.
820
821         This change was spurred by a process hang which occurred between tests and did
822         not produce a meaningful crashlog.
823
824         * Scripts/webkitpy/port/driver.py:
825         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
826
827          * Scripts/webkitpy/port/ios.py:
828         (IOSSimulatorPort):
829         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
830         * Scripts/webkitpy/port/mac.py:
831         (MacPort):
832         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
833
834         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
835         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
836
837         * WebKitTestRunner/TestController.h:
838         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
839         * WebKitTestRunner/TestInvocation.cpp:
840         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
841
842 2016-08-07  Dan Bernstein  <mitz@apple.com>
843
844         [Cocoa] Reply block leaks if the remote object doesn’t call it
845         https://bugs.webkit.org/show_bug.cgi?id=160642
846
847         Reviewed by Sam Weinig.
848
849         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
850         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
851         (TEST): Added a test case that checks that the reply block is released even when it’s not
852           called.
853         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
854         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
855           calling the completion handler.
856
857 2016-08-07  Chris Dumez  <cdumez@apple.com>
858
859         Write API test to cover crash fix in r204135
860         https://bugs.webkit.org/show_bug.cgi?id=160587
861
862         Reviewed by Darin Adler.
863
864         Add API test to cover crash fix in r204135. This reproduces the crash
865         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
866         callback.
867
868         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
869         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
870         (TEST):
871
872 2016-08-06  Chris Dumez  <cdumez@apple.com>
873
874         Unreviewed, rolling out r204226.
875
876         Broke some API tests
877
878         Reverted changeset:
879
880         "Write API test to cover crash fix in r204135"
881         https://bugs.webkit.org/show_bug.cgi?id=160587
882         http://trac.webkit.org/changeset/204226
883
884 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
885
886         EWS Style Queue fails to process patches which fails validation
887         https://bugs.webkit.org/show_bug.cgi?id=160632
888
889         Reviewed by Alexey Proskuryakov.
890
891         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
892         (StyleQueueTask.validate): Add more information about validation failure.
893         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
894         * Scripts/webkitpy/tool/commands/queues_unittest.py:
895         (test_non_valid_patch): Add a unit test to test the above code path.
896
897 2016-08-06  Sam Weinig  <sam@webkit.org>
898
899         WTF needs a variant implementation
900         https://bugs.webkit.org/show_bug.cgi?id=160618
901
902         Reviewed by Darin Adler.
903
904         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
905         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
906         Add tests for the variant implementation.
907
908 2016-08-06  Chris Dumez  <cdumez@apple.com>
909
910         Write API test to cover crash fix in r204135
911         https://bugs.webkit.org/show_bug.cgi?id=160587
912
913         Reviewed by Darin Adler.
914
915         Add API test to cover crash fix in r204135. This reproduces the crash
916         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
917         callback.
918
919         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
920         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
921         (TEST):
922
923 2016-08-05  Tim Horton  <timothy_horton@apple.com>
924
925         run-api-tests should use a headed simulator
926         https://bugs.webkit.org/show_bug.cgi?id=160611
927
928         Reviewed by Sam Weinig.
929
930         CADisplayLink doesn't work in a headless simulator, but is
931         vital for the proper functioning of WebKit2 painting on iOS.
932         So, we should not use a headless simulator.
933
934         * Scripts/run-api-tests:
935         Launch a simulator app, don't just boot the simulator.
936
937         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
938         Re-enable a test that works now.
939
940 2016-08-05  Dan Bernstein  <mitz@apple.com>
941
942         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
943         https://bugs.webkit.org/show_bug.cgi?id=160589
944
945         Reviewed by Tim Horton.
946
947         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
948         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
949           blocks, which wasn’t caught because the test wasn’t run correctly.
950         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
951         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
952           added a test that sends over an NSRange.
953         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
954         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
955           handler with the range‘s location and length.
956
957 2016-08-05  Enrica Casucci  <enrica@apple.com>
958
959         Fixing tests failing after r204175.
960
961         Unreviewed.
962
963         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
964
965 2016-08-05  Enrica Casucci  <enrica@apple.com>
966
967         Build fix after 204053.
968
969         Unreviewed.
970
971         * TestWebKitAPI/Configurations/Base.xcconfig:
972         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
973         (-[MockContentFilterEnabler initWithCoder:]):
974         (-[MockContentFilterEnabler dealloc]):
975
976 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
977
978         Print test name in "Last character read from DRT..." error message.
979         https://bugs.webkit.org/show_bug.cgi?id=160559
980
981         Reviewed by Michael Catanzaro.
982
983         * Scripts/webkitpy/port/driver.py:
984         (Driver.run_test):
985         (Driver._read_first_block):
986         (Driver._read_optional_image_block):
987         (Driver._read_block):
988         * Scripts/webkitpy/port/driver_unittest.py:
989         (DriverTest.test_read_block):
990         (DriverTest.test_read_binary_block):
991         (DriverTest.test_read_base64_block):
992
993 2016-08-05  Commit Queue  <commit-queue@webkit.org>
994
995         Unreviewed, rolling out r204123.
996         https://bugs.webkit.org/show_bug.cgi?id=160597
997
998         Caused layout test timeouts on Windows. (Requested by perarne
999         on #webkit).
1000
1001         Reverted changeset:
1002
1003         "[Win] Unable to reliably run tests in parallel"
1004         https://bugs.webkit.org/show_bug.cgi?id=140914
1005         http://trac.webkit.org/changeset/204123
1006
1007 2016-08-04  Saam Barati  <sbarati@apple.com>
1008
1009         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1010         https://bugs.webkit.org/show_bug.cgi?id=151241
1011
1012         Reviewed by Benjamin Poulain.
1013
1014         * Scripts/run-jsc-stress-tests:
1015
1016 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1017
1018         UI improvements to Flakiness Dashboard.
1019         https://bugs.webkit.org/show_bug.cgi?id=153295
1020
1021         Reviewed by Alexey Proskuryakov.
1022
1023         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1024         (td.options-container): Center text in most fields.
1025         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1026         (createBugHTML): Text/Grammar updates.
1027         (tableHeaders): Ditto.
1028         (htmlForSingleTestRow): Ditto.
1029         (headerForTestTableHtml): Ditto.
1030         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1031         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1032
1033 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1034
1035         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1036         https://bugs.webkit.org/show_bug.cgi?id=160518
1037
1038         Reviewed by Michael Catanzaro.
1039
1040         * Scripts/webkitpy/thirdparty/__init__.py:
1041         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1042         * gtk/install-dependencies:
1043
1044 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1045
1046         Optimize bot watcher's dashboard a little
1047         https://bugs.webkit.org/show_bug.cgi?id=160515
1048         rdar://problem/26096900
1049
1050         Reviewed by Lucas Forschler.
1051
1052         Made re-sorting after loading an iteration more efficient.
1053
1054         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1055         (BuildbotIteration.prototype._updateWithData):
1056         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1057         (BuildbotQueue.prototype.updateIterationPosition):
1058
1059 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1060
1061         [Win] Unable to reliably run tests in parallel
1062         https://bugs.webkit.org/show_bug.cgi?id=140914
1063
1064         Reviewed by Brent Fulgham.
1065
1066         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1067         processes. We can use string replacement to convert the Cygwin path to a Windows path
1068         instead.
1069  
1070         * Scripts/webkitpy/common/system/path.py:
1071         (cygpathFast):
1072         * Scripts/webkitpy/port/driver.py:
1073         (Driver._command_from_driver_input):
1074
1075 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1076
1077         Document instructions for increasing process and file limits
1078         https://bugs.webkit.org/show_bug.cgi?id=160528
1079         rdar://problem/24777576
1080
1081         Reviewed by Alexey Proskuryakov.
1082
1083         * Scripts/webkitpy/port/ios.py:
1084         (IOSSimulatorPort.default_child_processes):
1085
1086 2016-08-03  Anders Carlsson  <andersca@apple.com>
1087
1088         Remove the Objective-C bindings generator
1089         https://bugs.webkit.org/show_bug.cgi?id=160526
1090
1091         Reviewed by Sam Weinig.
1092
1093         * Scripts/run-bindings-tests:
1094         Update test.
1095
1096 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1097
1098         Revise a TestWebKitAPI comment to mention the actual underlying problem
1099
1100         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1101         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1102
1103 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1104
1105         Benchmark test content-animation timeouts always
1106         https://bugs.webkit.org/show_bug.cgi?id=160057
1107
1108         Reviewed by Simon Fraser.
1109
1110         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1111         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1112         (start):
1113
1114 2016-08-02  Nan Wang  <n_wang@apple.com>
1115
1116         AX: Simulated touch events are not working on iOS
1117         https://bugs.webkit.org/show_bug.cgi?id=160395
1118         <rdar://problem/27633597>
1119
1120         Reviewed by Chris Fleizach.
1121
1122         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1123         (WTR::AccessibilityUIElement::press):
1124         (WTR::AccessibilityUIElement::setSelectedChild):
1125
1126 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1127
1128         run-javascriptcore-tests should accept multiple --extra-tests
1129         https://bugs.webkit.org/show_bug.cgi?id=160486
1130
1131         Reviewed by Saam Barati.
1132         
1133         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1134         test suites. This does it by using GetOpt::Long's array support.
1135
1136         * Scripts/run-javascriptcore-tests:
1137         (runJSCStressTests):
1138
1139 2016-08-02  Enrica Casucci  <enrica@apple.com>
1140
1141         Allow building with content filtering disabled.
1142         https://bugs.webkit.org/show_bug.cgi?id=160454
1143
1144         Reviewed by Simon Fraser.
1145
1146         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1147
1148 2016-08-02  Brady Eidson  <beidson@apple.com>
1149
1150         Removing IndexedDB WebsiteData can fail for some users.
1151         https://bugs.webkit.org/show_bug.cgi?id=160463
1152
1153         Reviewed by Alex Christensen.
1154
1155         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1156
1157 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1158
1159         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1160         https://bugs.webkit.org/show_bug.cgi?id=160437
1161         <rdar://problem/27578272>
1162
1163         Reviewed by Brady Eidson.
1164
1165         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1166         (-[DownloadDelegate _download:didReceiveResponse:]):
1167         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1168         (runTest):
1169         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1170
1171 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1172
1173         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1174         https://bugs.webkit.org/show_bug.cgi?id=160414
1175
1176         Reviewed by Michael Catanzaro.
1177
1178         * Scripts/webkitpy/port/linux_get_crash_log.py:
1179         (GDBCrashLogGenerator._wait_for_corefile):
1180
1181 2016-08-01  Youenn Fablet  <youenn@apple.com>
1182
1183         Make wpt server generate its certificates in layout test results folder
1184         https://bugs.webkit.org/show_bug.cgi?id=160422
1185
1186         Reviewed by Chris Dumez.
1187
1188         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1189         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1190
1191 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1192
1193         Function Call on NULL Object
1194         https://bugs.webkit.org/show_bug.cgi?id=160325
1195
1196         Reviewed by Darin Adler.
1197
1198         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1199         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1200         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1201
1202 2016-08-01  Keith Miller  <keith_miller@apple.com>
1203
1204         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1205         https://bugs.webkit.org/show_bug.cgi?id=160372
1206
1207         Rubber stamped by Geoffrey Garen.
1208
1209         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1210         a new top level directory, JSTests. Having the tests in the Source directory
1211         was both confusing an inconvenient for people that just want to checkout the
1212         source code of WebKit. Since there is no other obvious place to put all the
1213         JavaScript tests a new top level directory seemed the most sensible.
1214
1215         * Scripts/import-test262-tests:
1216         * Scripts/run-javascriptcore-tests:
1217         * Scripts/update-javascriptcore-test-res:
1218
1219 2016-07-31  Nan Wang  <n_wang@apple.com>
1220
1221         AX: Add a check for touch event listener on iOS accessibility object
1222         https://bugs.webkit.org/show_bug.cgi?id=160388
1223
1224         Reviewed by Chris Fleizach.
1225
1226         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1227         (AccessibilityUIElement::boolAttributeValue):
1228         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1229         (WTR::AccessibilityUIElement::boolAttributeValue):
1230
1231 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1232
1233         Unreviewed: add myself to the reviewers list.
1234
1235         * Scripts/webkitpy/common/config/contributors.json:
1236
1237 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1238
1239         Undo r203939, and copy over a rule that clips the logos.
1240
1241         Sierra wasn't the only logo without transparency.
1242
1243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1244         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1246
1247 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1248
1249         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1250         https://bugs.webkit.org/show_bug.cgi?id=160377
1251
1252         Reviewed by Brian Weinstein.
1253
1254         Update assets to remove the white background and use a transparent background instead.
1255
1256         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1257         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1258
1259 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1260
1261         Ignore most check-webkit-style checks for ANGLE project
1262         <https://webkit.org/b/160333>
1263
1264         Reviewed by Daniel Bates.
1265
1266         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1267         - No tabs.
1268         - No spaces at the end of lines.
1269         - No carriage returns (DOS line endings).
1270
1271 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1272
1273         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1274         https://bugs.webkit.org/show_bug.cgi?id=160360
1275         <rdar://problem/27179484>
1276
1277         Reviewed by Myles C. Maxfield.
1278
1279         Adds two tests verifying that videos may be considered main content as long as they
1280         are large enough and cover a majority of the mainframe's viewport.
1281
1282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1283         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1284         (TestWebKitAPI::TEST):
1285         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1286         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1287
1288 2016-07-29  Mark Lam  <mark.lam@apple.com>
1289
1290         Gardening: removed unused variable.
1291
1292         Not reviewed.
1293
1294         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1295         (TestWebKitAPI::TEST):
1296
1297 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1298
1299         Add TestWebKitAPI support for interacting with media controls
1300         https://bugs.webkit.org/show_bug.cgi?id=160342
1301         <rdar://problem/27610246>
1302
1303         Reviewed by Beth Dakin.
1304
1305         Adds support for testing interaction with some media controls, as well as a basic test
1306         verifying that media control teardown after interaction does not result in a crash.
1307
1308         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1309         (-[WKWebView mouseDownAtPoint:]):
1310         (-[WKWebView performAfterLoading:]):
1311         (TestWebKitAPI::TEST):
1312
1313 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1314
1315         Crash Log Clobbering on Unbound Crashes
1316         https://bugs.webkit.org/show_bug.cgi?id=160198
1317         <rdar://problem/27472618>
1318
1319         Reviewed by Alexey Proskuryakov.
1320
1321         * Scripts/webkitpy/common/system/crashlogs.py:
1322         (CrashLogs): Fix header order.
1323         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1324         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1325
1326 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1327
1328         Update for contributors.json
1329         https://bugs.webkit.org/show_bug.cgi?id=160294
1330
1331         * Scripts/webkitpy/common/config/contributors.json:
1332
1333 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1334
1335         Remove deprecated SPI for video inline / fullscreen controls
1336         https://bugs.webkit.org/show_bug.cgi?id=160318
1337
1338         Reviewed by Tim Horton.
1339
1340         * DumpRenderTree/mac/DumpRenderTree.mm:
1341         (setDefaultsToConsistentValuesForTesting): Deleted.
1342         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1343         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1344         * WebKitTestRunner/TestController.cpp:
1345         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1346         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1347         (WTR::initializeWebViewConfiguration): Deleted.
1348
1349 2016-07-28  Daniel Bates  <dabates@apple.com>
1350
1351         [iOS] TestWebKitAPI bundle targets are not code signed
1352         https://bugs.webkit.org/show_bug.cgi?id=160328
1353         <rdar://problem/27409246>
1354
1355         Reviewed by Andy Estes.
1356
1357         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1358         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1359         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1360
1361         * TestWebKitAPI/Configurations/Base.xcconfig:
1362
1363 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1364
1365         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1366
1367         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1368         (animatedResizeWebView):
1369         (TEST):
1370         This test times out only when run in the WebKit Testing simulator environment,
1371         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1372
1373 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1374
1375         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1376         https://bugs.webkit.org/show_bug.cgi?id=160289
1377         <rdar://problem/27553464>
1378
1379         Reviewed by Simon Fraser.
1380
1381         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1383         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1384         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1385         (-[AnimatedResizeWebView _endAnimatedResize]):
1386         (animatedResizeWebView):
1387         (TEST):
1388         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1389         Add two tests that ensure that hidden-content and animated resizes
1390         don't cause unnecessary synchronous waits. Only the hidden-content
1391         one fails before my patch, but it seemed reasonable to add both anyway.
1392
1393 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1394
1395         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1396         <https://webkit.org/b/83342>
1397
1398         Reviewed by Ryosuke Niwa.
1399
1400         * Scripts/webkitpy/common/checkout/scm/git.py:
1401         (Git.revisions_changing_file): Remove code to raise an exception
1402         when the file doesn't exist.  If a file was moved or renamed,
1403         then this caused the script to terminate, which was very
1404         frustrating when you wanted a list of reviewers.
1405         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1406         (SCMTest._shared_test_revisions_changing_file): Update test
1407         expectation to return an empty list of revisions.
1408         (test_create_patch_is_full_patch): Drive-by fix when running all
1409         webkitpy tests (including scm tests).
1410         * Scripts/webkitpy/common/checkout/scm/svn.py:
1411         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1412         return an empty array of revisions if this occurs.
1413
1414 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1415
1416         EWS error message "Error: * did not process patch" should include explanation
1417         https://bugs.webkit.org/show_bug.cgi?id=159903
1418         <rdar://problem/27410788>
1419
1420         Reviewed by Alexey Proskuryakov.
1421
1422         * QueueStatusServer/handlers/statusbubble.py:
1423         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1424         is not processed.
1425         * QueueStatusServer/handlers/processingtimesjson.py:
1426         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1427         of the code.
1428         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1429         (CommitQueueTask.validate): Add more information about validation failure.
1430         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1431         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1432         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1433         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1434         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1435         (PatchIsNotValid.__init__): Add the failure_message argument.
1436         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1437         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1438         failure details.
1439         * Scripts/webkitpy/tool/commands/queues.py:
1440         (CommitQueue.process_work_item): Same.
1441         (StyleQueue.review_patch): Same.
1442         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1443         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1444
1445 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1446
1447         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1448         https://bugs.webkit.org/show_bug.cgi?id=160262
1449
1450         Reviewed by Daniel Bates.
1451
1452         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1453         (-[LTRelayController installApp]):
1454
1455 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1456
1457         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1458         https://bugs.webkit.org/show_bug.cgi?id=160225
1459
1460         Reviewed by Alexey Proskuryakov.
1461
1462         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1463
1464 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1465
1466         [GTK] Fix some video/canvas tests that should be passing
1467         https://bugs.webkit.org/show_bug.cgi?id=160023
1468
1469         Reviewed by Carlos Garcia Campos.
1470
1471         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1472         EFL or GTK platforms.
1473
1474         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1475         (WTR::TestController::platformConfigureViewForTest):
1476         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1477         (WTR::TestController::platformConfigureViewForTest):
1478
1479 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1480
1481         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1482         https://bugs.webkit.org/show_bug.cgi?id=160247
1483
1484         Reviewed by Michael Catanzaro.
1485
1486         * BuildSlaveSupport/built-product-archive:
1487         (createZip):
1488         (dirContainsdwo):
1489         (archiveBuiltProduct):
1490
1491 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1492
1493         Fix tests after r203743.
1494         https://bugs.webkit.org/show_bug.cgi?id=156947
1495
1496         * WebKitTestRunner/TestController.cpp:
1497         (WTR::TestController::resetStateToConsistentValues):
1498         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1499
1500 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1501
1502         [iPhone] Playing a video on tudou.com plays only sound, no video
1503         https://bugs.webkit.org/show_bug.cgi?id=160178
1504         <rdar://problem/27535468>
1505
1506         Reviewed by Dan Bernstein.
1507
1508         * DumpRenderTree/mac/DumpRenderTree.mm:
1509         (setDefaultsToConsistentValuesForTesting):
1510         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1511         (RequiresUserActionForPlaybackTest::SetUp):
1512         * WebKitTestRunner/TestController.cpp:
1513         (WTR::TestController::resetPreferencesToConsistentValues):
1514         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1515         (WTR::initializeWebViewConfiguration):
1516
1517 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1518
1519         Allow LOG macros to be used outside the namespace, and other logging cleanup
1520         https://bugs.webkit.org/show_bug.cgi?id=160216
1521
1522         Reviewed by Anders Carlsson.
1523         
1524         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1525
1526         * DumpRenderTree/TestRunner.cpp:
1527         * DumpRenderTree/mac/DumpRenderTree.mm:
1528         (resetWebViewToConsistentStateBeforeTesting):
1529
1530 2016-07-26  David Kilzer <ddkilzer@apple.com>
1531
1532         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1533         https://bugs.webkit.org/show_bug.cgi?id=156947
1534         <rdar://problem/23325160>
1535
1536         Reviewed by Alex Christensen.
1537
1538         * DumpRenderTree/TestRunner.cpp:
1539         (TestRunner::TestRunner):
1540         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1541         * DumpRenderTree/TestRunner.h:
1542         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1543         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1544         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1545         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1546         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1547         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1548         (WTR::TestRunner::queueNonLoadingScript):
1549         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1550         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1551         * WebKitTestRunner/TestController.cpp:
1552         (WTR::TestController::didReceiveAuthenticationChallenge):
1553         * WebKitTestRunner/TestController.h:
1554         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1555         * WebKitTestRunner/TestInvocation.cpp:
1556         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1557         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1558
1559 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1560
1561         check-for-exit-time-destructors should be usable outside Xcode
1562         <https://webkit.org/b/160195>
1563
1564         Reviewed by Darin Adler.
1565
1566         * Scripts/check-for-exit-time-destructors: Update to parse
1567         -h|--help switch, or to take one argument to a binary to check
1568         for exit time destructors on the command-line.  The clang
1569         compiler will find these at compile-time with the
1570         -Wexit-time-destructors switch, but this script will check for
1571         them after-the-fact.
1572
1573 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1574
1575         Test svn.webkit.org functionality after maintenance.
1576
1577 2016-07-25  Brady Eidson  <beidson@apple.com>
1578
1579         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1580         https://bugs.webkit.org/show_bug.cgi?id=153783
1581
1582         Reviewed by Alex Christensen.
1583
1584         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
1585         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1586         
1587         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1588         
1589         Change the relevant API tests to make sure this continues to be no longer required.
1590
1591         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1592         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1593         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1594         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1595         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1596         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1597
1598 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1599
1600         Media controls should not be displayed for a video until it starts playing
1601         https://bugs.webkit.org/show_bug.cgi?id=160092
1602         <rdar://problem/26986673>
1603
1604         Reviewed by Beth Dakin.
1605
1606         Verify that multiple videos do or don't show the media controller depending on whether videos
1607         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1608         passing because we were always showing media controls for large videos with audio, even if they
1609         had not played back yet. This change ensures that large videos with audio show media controls
1610         only after they begin to play back, and not by virtue of being large enough for main content.
1611
1612         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1613         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1614         (TestWebKitAPI::TEST):
1615         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1616         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1617         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1618
1619 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1620
1621         Media controls on apple.com don't disappear when movie finishes playing
1622         https://bugs.webkit.org/show_bug.cgi?id=160068
1623         <rdar://problem/26668526>
1624
1625         Reviewed by Darin Adler.
1626
1627         Adds new API tests. Please see WebCore ChangeLog for more details.
1628
1629         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1630         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1631         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1632         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1633         (TestWebKitAPI::TEST):
1634         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1635         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1636         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1637         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1638         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1639
1640 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1641
1642         Unreviewed, fix test-webkitpy after r203674.
1643
1644         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1645         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1646
1647 2016-07-24  Philippe Normand  <pnormand@igalia.com>
1648
1649         Unreviewed, forgot to commit this file in r203674.
1650
1651         * Scripts/process-linux-coredump: Added.
1652         (main):
1653
1654 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1655
1656         Improve GDB backtrace generation for GTK/EFL
1657         https://bugs.webkit.org/show_bug.cgi?id=128928
1658
1659         Reviewed by Carlos Garcia Campos.
1660
1661         The PID of the crashed process is now correctly supplied to the
1662         crash log reporter. The kernel core_pattern needs to be updated
1663         after this change to something like:
1664
1665         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1666
1667         * Scripts/process-linux-coredump: Added.
1668         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1669         * Scripts/webkitpy/port/efl.py:
1670         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1671         * Scripts/webkitpy/port/gtk.py:
1672         (GtkPort._get_crash_log): Ditto.
1673         * Scripts/webkitpy/port/linux_get_crash_log.py:
1674         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1675         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1676         (GDBCrashLogGenerator): Deleted.
1677         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1678         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
1679         * WebKitTestRunner/TestController.cpp:
1680         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
1681         (WTR::TestController::databaseProcessDidCrash): Ditto.
1682         (WTR::TestController::processDidCrash): Ditto.
1683
1684 2016-07-23  Youenn Fablet  <youenn@apple.com>
1685
1686         WPT stash server should be kept running when launching wpt server
1687         https://bugs.webkit.org/show_bug.cgi?id=160052
1688
1689         Reviewed by Sam Weinig.
1690
1691         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1692         (main): waiting to read stdin while stash server is started.
1693
1694 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1695
1696         Media controls should be displayed for media in media documents
1697         https://bugs.webkit.org/show_bug.cgi?id=160104
1698         <rdar://problem/27438936>
1699
1700         Reviewed by Myles C. Maxfield.
1701
1702         Verifies that even a small video with audio in a media document gets media controls.
1703
1704         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1705         (TestWebKitAPI::TEST):
1706
1707 2016-07-22  Michael Saboff  <msaboff@apple.com>
1708
1709         REGRESSION(203616): no FTL testing was inadvertently removed
1710         https://bugs.webkit.org/show_bug.cgi?id=160100
1711
1712         Rubber-stamped by Filip Pizlo.
1713
1714         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
1715         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
1716         logic for the runLayout and runNoisy variants to match the run test logic,
1717         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
1718         enabled platforms.
1719
1720         * Scripts/run-jsc-stress-tests:
1721
1722 2016-07-22  Brady Eidson  <beidson@apple.com>
1723
1724         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
1725         https://bugs.webkit.org/show_bug.cgi?id=160089
1726
1727         Reviewed by Darin Adler.
1728
1729         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1730         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
1731         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
1732
1733 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
1734
1735         [GTK] Improved exclusion patterns in make-dist.py manifest.
1736         https://bugs.webkit.org/show_bug.cgi?id=160094
1737
1738         Reviewed by Michael Catanzaro.
1739
1740         * gtk/manifest.txt.in:
1741         Exclude Platform*.cmake files for more ports.
1742         Removed obsolete .gyp and .pro.user patterns.
1743         Exclude 'Configurations' and 'spi' directories.
1744         Exclude CMakeLists.txt.user (Qt Creator IDE).
1745
1746 2016-07-22  Michael Saboff  <msaboff@apple.com>
1747
1748         Don't run FTL related JSC stress tests on non-FTL platforms
1749         https://bugs.webkit.org/show_bug.cgi?id=160033
1750
1751         Reviewed by Mark Lam.
1752
1753         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
1754         Refactored several of the runXXX test methods to always runXXXDefault and made those
1755         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
1756         doesn't cause a problem.
1757
1758         * Scripts/run-jsc-stress-tests:
1759
1760 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
1761
1762         IWebView::mainFrame crashes if called after IWebView::close
1763         https://bugs.webkit.org/show_bug.cgi?id=32868
1764
1765         Reviewed by Brent Fulgham.
1766
1767         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1768         (TestWebKitAPI::TEST_F): Added test.
1769
1770 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1771
1772         [GTK] Enable threaded compositor by default
1773         https://bugs.webkit.org/show_bug.cgi?id=160079
1774
1775         Reviewed by Žan Doberšek.
1776
1777         * Scripts/webkitperl/FeatureList.pm:
1778
1779 2016-07-22  Youenn Fablet  <youenn@apple.com>
1780
1781         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
1782         https://bugs.webkit.org/show_bug.cgi?id=159921
1783
1784         Reviewed by Brian Burg.
1785
1786         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
1787
1788         * Scripts/webkitpy/codegen/main.py:
1789         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
1790         (BuiltinsGeneratorTests):
1791         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
1792         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
1793         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
1794         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
1795
1796 2016-07-21  Dan Bernstein  <mitz@apple.com>
1797
1798         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
1799         https://bugs.webkit.org/show_bug.cgi?id=160072
1800
1801         Reviewed by Andy Estes.
1802
1803         * Scripts/webkitdirs.pm:
1804         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
1805           for old Xcode versions.
1806         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
1807           to readXcodeUserDefault.
1808         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
1809           debugger.
1810         (determineDebugger): Ditto.
1811         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
1812           7.0.
1813         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
1814           switches.
1815         (execMacWebKitAppForDebugging): Removed support for GDB.
1816
1817 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1818
1819         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
1820         https://bugs.webkit.org/show_bug.cgi?id=160066
1821
1822         Reviewed by Dean Jackson.
1823
1824         * DumpRenderTree/mac/DumpRenderTree.mm:
1825         (setDefaultsToConsistentValuesForTesting): Deleted.
1826         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1827         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1828         * WebKitTestRunner/TestController.cpp:
1829         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1830         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1831         (WTR::initializeWebViewConfiguration): Deleted.
1832
1833 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
1834
1835         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
1836         https://bugs.webkit.org/show_bug.cgi?id=159980
1837         rdar://problem/27450825
1838
1839         Reviewed by Dan Bernstein.
1840
1841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1842         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
1843         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
1844         when our delegate has hit -dealloc.
1845         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
1846         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
1847         will not be messaged.
1848
1849 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1850
1851         Follow-up patch to r203520
1852         https://bugs.webkit.org/show_bug.cgi?id=159967
1853         <rdar://problem/26964090>
1854
1855         Unreviewed.
1856
1857         * DumpRenderTree/mac/DumpRenderTree.mm:
1858         (setDefaultsToConsistentValuesForTesting):
1859         * WebKitTestRunner/TestController.cpp:
1860         (WTR::TestController::resetPreferencesToConsistentValues):
1861
1862 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1863
1864         [iPhone] Playing a video on tudou.com plays only sound, no video
1865         https://bugs.webkit.org/show_bug.cgi?id=159967
1866         <rdar://problem/26964090>
1867
1868         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
1869
1870         Migrate tests to use new SPI.
1871
1872         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1873         (RequiresUserActionForPlaybackTest::SetUp):
1874         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1875         (WTR::initializeWebViewConfiguration):
1876
1877 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
1878
1879         Clarify testing mode names in run-jsc-stress-tests
1880         https://bugs.webkit.org/show_bug.cgi?id=160021
1881
1882         Reviewed by Mark Lam.
1883
1884         Default should mean really default, not default with disabled FTL, renamed
1885         - runMozillaTestDefault to runMozillaTestNoFTL
1886         - runMozillaTestDefaultFTL to runMozillaTestDefault
1887         - runDefault to runNoFTL
1888         - runDefaultFTL to runDefault
1889         - runLayoutTestDefault to runLayoutTestNoFTL
1890         - runLayoutTestDefaultFTL to runLayoutTestDefault
1891         - runNoisyTestDefault to runNoisyTestNoFTL
1892         - runNoisyTestDefaultFTL to runNoisyTestDefault
1893
1894         * Scripts/run-jsc-stress-tests:
1895
1896 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
1897
1898         WebBackForwardList's currentIndex could get out of bounds when filtering items.
1899         https://bugs.webkit.org/show_bug.cgi?id=159986
1900
1901         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
1902         to 0.
1903
1904         Reviewed by Dan Bernstein.
1905
1906         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1907         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
1908         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
1909         (TEST):
1910
1911 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1912
1913         [GTK] Web view background colors don't work in accelerated compositing mode
1914         https://bugs.webkit.org/show_bug.cgi?id=159455
1915
1916         Reviewed by Michael Catanzaro.
1917
1918         Set always RGBA visual to the view widget when setting a background color.
1919
1920         * MiniBrowser/gtk/BrowserWindow.c:
1921         (browser_window_set_background_color):
1922
1923 2016-07-20  Youenn Fablet  <youenn@apple.com>
1924
1925         Bots should run built-ins generator tests
1926         https://bugs.webkit.org/show_bug.cgi?id=159971
1927
1928         Reviewed by Alexey Proskuryakov.
1929
1930         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1931         (RunBuiltinsTests): New step to run built-in generator tests.
1932         (TestFactory.__init__): Adding an additional step for bultin generator tests.
1933         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
1934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
1935
1936 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1937
1938         Revert temporary fix r203417
1939         https://bugs.webkit.org/show_bug.cgi?id=160001
1940
1941         Reviewed by Alexey Proskuryakov.
1942
1943         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
1944
1945 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1946
1947         REGRESSION(r148588): ews classes might get garbage collected
1948         https://bugs.webkit.org/show_bug.cgi?id=159990
1949
1950         Reviewed by Ryosuke Niwa.
1951
1952         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
1953         in a variable so that they do not get garbage collected.
1954
1955 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
1956
1957         Add API test for layout constraints after exit fullscreen
1958         https://bugs.webkit.org/show_bug.cgi?id=159900
1959
1960         Reviewed by Jon Lee.
1961
1962         Added Fullscreen.LaytoutConstraints API test. 
1963         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
1964
1965         This test compares layout constraints on the web view before and after fullscreen to make sure 
1966         they are preserved.
1967
1968         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
1969         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
1970         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1971         (TestWebKitAPI::TEST):
1972
1973 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
1974
1975         Disable two failing API tests.
1976
1977         Unreviewed test gardening.
1978
1979         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
1980         (TestWebKitAPI::TEST):
1981
1982 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1983
1984         Unreviewed iOS build fix.
1985
1986         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
1987
1988 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1989
1990         Media controls don't appear when pausing a small autoplaying video
1991         https://bugs.webkit.org/show_bug.cgi?id=159972
1992         <rdar://problem/27180657>
1993
1994         Reviewed by Beth Dakin.
1995
1996         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
1997         for simulating basic user interaction in VideoControlsManager.
1998
1999         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2000         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2001         (-[WKWebView mouseDownAtPoint:]):
2002         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2003         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2004         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2005         (TestWebKitAPI::TEST):
2006         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2007
2008 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2009
2010         [Win] MathML fonts are not found.
2011         https://bugs.webkit.org/show_bug.cgi?id=159920
2012
2013         Reviewed by Alex Christensen.
2014
2015         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2016         for a specific registry key value.
2017
2018         * Scripts/webkitdirs.pm:
2019         (fontExists):
2020
2021 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2022
2023         Improve prepare-ChangeLog for @media blocks
2024         https://bugs.webkit.org/show_bug.cgi?id=159907
2025
2026         Reviewed by Timothy Hatcher.
2027
2028         * Scripts/prepare-ChangeLog:
2029         (get_selector_line_ranges_for_css):
2030         Get a range for @media blocks just like a selector.
2031             Start Line = line with '{'
2032             End line = line with '}'
2033             Name = "@media ..."
2034
2035         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2036         Improved error messages for unbalanced portions.
2037
2038         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2039         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2040         (.media-query::before):
2041         (@media only screen and (max-width: 980px)):
2042         (.media-query a):
2043         (@media (-webkit-min-device-pixel-ratio: 2)):
2044         (.both a):
2045         (.both b):
2046         (.media-query b):
2047         (.media-query::after):
2048
2049 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2050
2051         Fix expectedFailErrorHandler in run-jsc-stress-tests
2052         https://bugs.webkit.org/show_bug.cgi?id=159811
2053
2054         Reviewed by Yusuke Suzuki.
2055
2056         * Scripts/run-jsc-stress-tests:
2057
2058 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2059
2060         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2061
2062         * TestWebKitAPI/PlatformMac.cmake:
2063
2064 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2065
2066         The default testing mode should not involve disabling the FTL JIT
2067         https://bugs.webkit.org/show_bug.cgi?id=159929
2068
2069         Rubber stamped by Mark Lam and Saam Barati.
2070         
2071         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2072         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2073         FTL was not the default. You had to enable it with an option.
2074         
2075         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2076         all of the major ports. This has become a serious pain. For example, it's useful to be able
2077         to say that a test should only run in the default config that is representative of what a
2078         normal user would see if they ran JSC. Clearly, this would be a config that does not
2079         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2080         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2081         
2082         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2083         try to fix it, because:
2084         
2085         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2086           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2087           doesn't do anything. The code is not really structured to allow this.
2088         
2089         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2090           disabled in testing. On the other hand there are already build bots that do FTL tests
2091           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2092           preserving this broken feature, we should create something that (a) acknowledges the fact
2093           that the FTL is the default on those platforms that support it and (b) avoids running
2094           no-ftl tests on precisely those platforms that don't have FTL.
2095         
2096         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2097           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2098           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2099           pretending that the FTL JIT is not the default just because some bots used that as an
2100           optimization.
2101         
2102         This change allows me to speed up some debug tests and paint some bots green.
2103
2104         * Scripts/run-javascriptcore-tests:
2105         (runJSCStressTests):
2106         * Scripts/run-jsc-stress-tests:
2107
2108 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2109
2110         Fix API test after r203426.
2111         https://bugs.webkit.org/show_bug.cgi?id=159949
2112
2113         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2114         (TEST):
2115         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2116         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2117
2118 2016-07-19  Andy Estes  <aestes@apple.com>
2119
2120         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2121         https://bugs.webkit.org/show_bug.cgi?id=159956
2122
2123         Reviewed by Dan Bernstein.
2124
2125         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2126         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2127         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2128         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2129
2130 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2131
2132         Add regression test for r203392
2133         https://bugs.webkit.org/show_bug.cgi?id=159949
2134
2135         Reviewed by Brady Eidson.
2136
2137         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2138         (fileSize):
2139         (swizzledBundleIdentifierWebBookmarksD):
2140         (defaultApplicationCacheDirectory):
2141         (TEST):
2142         (swizzledBundleIdentifierMobileSafari): Deleted.
2143         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2144         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2145         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2146
2147 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2148
2149         Add regression test for r203392
2150         https://bugs.webkit.org/show_bug.cgi?id=159949
2151
2152         Reviewed by Brady Eidson.
2153
2154         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2155         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2156         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2157         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2158         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2159         (TEST):
2160         (fileSize):
2161         (swizzledBundleIdentifierMobileSafari):
2162         (swizzledBundleIdentifierWebBookmarksD):
2163         (defaultApplicationCacheDirectory):
2164         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2165         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2166         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2167         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2168
2169 2016-07-19  Keith Miller  <keith_miller@apple.com>
2170
2171         Test262 should have a file with the revision and url
2172         https://bugs.webkit.org/show_bug.cgi?id=159937
2173
2174         Reviewed by Mark Lam.
2175
2176         The import script should update the information from
2177         the path to the test262 repository it gets.
2178
2179         * Scripts/import-test262-tests:
2180
2181 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2182
2183         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2184         To be deleted once the root cause is found and addressed.
2185
2186         * EWSTools/start-queue-mac.sh:
2187
2188 2016-07-19  Frederic Wang  <fwang@igalia.com>
2189
2190         [win] Fixup the register name for STIX Math and Latin Modern Math
2191
2192         Unreviewed follow-up of r203406
2193
2194         * Scripts/webkitdirs.pm:
2195         (checkInstalledTools):
2196
2197 2016-07-19  Frederic Wang  <fwang@igalia.com>
2198
2199         [win] Update the list of MathML fonts
2200         https://bugs.webkit.org/show_bug.cgi?id=156838
2201
2202         The set of recommended math fonts is now described at
2203         https://trac.webkit.org/wiki/MathML/Fonts
2204         We update the Perl script to use the latest list of fonts.
2205
2206         Reviewed by Brent Fulgham.
2207
2208         * Scripts/webkitdirs.pm:
2209         (checkInstalledTools):
2210
2211 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2212
2213         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2214         https://bugs.webkit.org/show_bug.cgi?id=159342
2215
2216         Reviewed by Darin Adler.
2217
2218         Implement required functions in event sender.
2219
2220         * DumpRenderTree/PlatformWin.cmake:
2221         * DumpRenderTree/win/EventSender.cpp:
2222         (monitorWheelEvents): Added.
2223         (callAfterScrollingCompletes): Added.
2224
2225 2016-07-19  Youenn Fablet  <youenn@apple.com>
2226
2227         Add new aliases to http test server
2228         https://bugs.webkit.org/show_bug.cgi?id=159878
2229
2230         Reviewed by Darin Adler.
2231
2232         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2233         Adding explicitly these links to perl script.
2234         Extracting default alias in an aliases.json file.
2235         Reading that file from python scripts to initialize aliases from that file.
2236
2237         Python script changes covered by unit tests and changed layout test.
2238
2239         * Scripts/webkitperl/httpd.pm:
2240         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2241         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2242         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2243         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2244         Adding -c directives for each alias.
2245         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2246         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2247         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2248         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2249         Adding alias directive for each alias.
2250         (Lighttpd._prepare_config):
2251         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2252         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2253         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2254         layout tests directory.
2255         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2256         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2257         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2258
2259 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2260
2261         EWS console logs doesn't go to log file
2262         https://bugs.webkit.org/show_bug.cgi?id=159539
2263         <rdar://problem/24464570>
2264
2265         Reviewed by David Kilzer.
2266
2267         * Scripts/webkitpy/common/system/logutils.py:
2268         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2269         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2270         to filesystem. It also supports passing MockFilesystem.
2271         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2272         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2273         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2274         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2275         (_test_ews): Same.
2276         * Scripts/webkitpy/tool/commands/queues.py:
2277         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2278         (AbstractQueue._log_directory): Using filesystem object instead of os.
2279         (AbstractQueue.queue_log_path): Same.
2280         (AbstractQueue.__init__): Passed host parameter.
2281         (PatchProcessingQueue.__init__): Same.
2282         (CommitQueue.__init__): Same.
2283         (AbstractReviewQueue.__init__): Same.
2284         (StyleQueue.__init__): Same.
2285         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2286         (TestCommitQueue): Passed MockHost() as host.
2287         (TestCommitQueue.__init__): Same.
2288         (TestQueue.__init__): Same.
2289         (TestReviewQueue.__init__): Same.
2290         (TestFeederQueue.__init__): Same.
2291         (AbstractPatchQueueTest.test_next_patch): Same.
2292         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2293         (test_commit_queue_failure): Same.
2294         (MockCommitQueueTask.results_from_patch_test_run): Same.
2295         (test_rollout_lands): Same.
2296         (test_non_valid_patch): Same.
2297         (test_auto_retry): Same.
2298         (test_style_queue_with_watch_list_exception): Same.
2299
2300 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2301
2302         WTF::Lock should be fair eventually
2303         https://bugs.webkit.org/show_bug.cgi?id=159384
2304
2305         Reviewed by Geoffrey Garen.
2306
2307         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2308
2309 2016-07-17  Sam Weinig  <sam@webkit.org>
2310
2311         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2312         <rdar://problem/26554137>
2313         https://bugs.webkit.org/show_bug.cgi?id=159856
2314
2315         Reviewed by Dan Bernstein.
2316
2317         * MiniBrowser/mac/WK2BrowserWindowController.m:
2318         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2319         Add basic window.open implementation.
2320
2321         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2322         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2323         to open a single non-web URL, all others are dropped.
2324
2325         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2326         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2327         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2328         Add API for the new SPI.
2329
2330 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2331
2332         [JSC] Enable test262 module tests
2333         https://bugs.webkit.org/show_bug.cgi?id=159854
2334
2335         Reviewed by Saam Barati.
2336
2337         Use --module-file instead.
2338
2339         * Scripts/run-jsc-stress-tests:
2340
2341 2016-07-16  Chris Dumez  <cdumez@apple.com>
2342
2343         Unreviewed, rolling out r203318.
2344
2345         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2346         SunSpider)
2347
2348         Reverted changeset:
2349
2350         "[JSC] Change some parameters based on a random search"
2351         https://bugs.webkit.org/show_bug.cgi?id=158514
2352         http://trac.webkit.org/changeset/203318
2353
2354 2016-07-16  Chris Dumez  <cdumez@apple.com>
2355
2356         Add move constructor / assignment operator to ListHashSet
2357         https://bugs.webkit.org/show_bug.cgi?id=159837
2358
2359         Reviewed by Darin Adler.
2360
2361         Add API tests.
2362
2363         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2364         (TestWebKitAPI::TEST):
2365
2366 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2367
2368         [JSC] Change some parameters based on a random search
2369         https://bugs.webkit.org/show_bug.cgi?id=158514
2370
2371         Reviewed by Saam Barati.
2372
2373         * Scripts/run-jsc-stress-tests:
2374
2375 2016-07-15  Jon Davis  <jond@apple.com>
2376
2377         Changed the start page URL for WebKit Nightly builds.
2378         https://bugs.webkit.org/show_bug.cgi?id=159816
2379
2380         Reviewed by Timothy Hatcher.
2381
2382         * WebKitLauncher/start.html:
2383
2384 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2385
2386         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2387         https://bugs.webkit.org/show_bug.cgi?id=159414
2388
2389         Reviewed by Brent Fulgham.
2390
2391         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2392         when the HDC parameter is invalid.
2393
2394         * TestWebKitAPI/PlatformWin.cmake:
2395         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2396         (TestWebKitAPI::TEST):
2397
2398 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2399
2400         [GTK] Add basic tabs support to MiniBrowser
2401         https://bugs.webkit.org/show_bug.cgi?id=159803
2402
2403         Reviewed by Sergio Villar Senin.
2404
2405         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2406         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2407
2408         * MiniBrowser/gtk/BrowserTab.c: Added.
2409         (titleChanged):
2410         (isLoadingChanged):
2411         (decidePolicy):
2412         (removeChildIfInfoBar):
2413         (loadChanged):
2414         (createInfoBarQuestionMessage):
2415         (tlsErrorsDialogResponse):
2416         (loadFailedWithTLSerrors):
2417         (permissionRequestDialogResponse):
2418         (decidePermissionRequest):
2419         (colorChooserRGBAChanged):
2420         (popoverColorClosed):
2421         (colorChooserRequestFinished):
2422         (runColorChooserCallback):
2423         (inspectorOpenedInWindow):
2424         (inspectorClosed):
2425         (browserTabSetProperty):
2426         (browserTabFinalize):
2427         (browser_tab_init):
2428         (browserTabConstructed):
2429         (browser_tab_class_init):
2430         (getInternalURI):
2431         (browser_tab_new):
2432         (browser_tab_get_web_view):
2433         (browser_tab_load_uri):
2434         (browser_tab_get_title_widget):
2435         (browser_tab_set_status_text):
2436         (browser_tab_toggle_inspector):
2437         (browser_tab_start_search):
2438         (browser_tab_stop_search):
2439         (browser_tab_add_accelerators):
2440         (fullScreenMessageTimeoutCallback):
2441         (browser_tab_enter_fullscreen):
2442         (browser_tab_leave_fullscreen):
2443         * MiniBrowser/gtk/BrowserTab.h: Added.
2444         * MiniBrowser/gtk/BrowserWindow.c:
2445         (getExternalURI):
2446         (browserWindowSetStatusText):
2447         (reloadOrStopCallback):
2448         (goBackCallback):
2449         (goForwardCallback):
2450         (settingsCallback):
2451         (webViewURIChanged):
2452         (browserWindowHistoryItemActivated):
2453         (browserWindowUpdateNavigationActions):
2454         (webViewCreate):
2455         (webViewEnterFullScreen):
2456         (webViewLeaveFullScreen):
2457         (webViewDecidePolicy):
2458         (browserWindowCanZoomIn):
2459         (browserWindowCanZoomOut):
2460         (browserWindowZoomIn):
2461         (browserWindowZoomOut):
2462         (scrollEventCallback):
2463         (faviconChanged):
2464         (webViewIsLoadingChanged):
2465         (defaultZoomCallback):
2466         (searchCallback):
2467         (newTabCallback):
2468         (toggleWebInspector):
2469         (reloadPage):
2470         (reloadPageIgnoringCache):
2471         (stopPageLoad):
2472         (loadHomePage):
2473         (editingCommandCallback):
2474         (insertImageCommandCallback):
2475         (insertLinkCommandCallback):
2476         (browserWindowSetupEditorToolbar):
2477         (browserWindowSwitchTab):
2478         (browserWindowTabAddedOrRemoved):
2479         (browser_window_init):
2480         (browserWindowConstructed):
2481         (browserWindowSaveSession):
2482         (browserWindowDeleteEvent):
2483         (browser_window_new):
2484         (browser_window_append_view):
2485         (browser_window_load_uri):
2486         (browser_window_load_session):
2487         (browser_window_set_background_color):
2488         (resetStatusText): Deleted.
2489         (activateUriEntryCallback): Deleted.
2490         (webViewTitleChanged): Deleted.
2491         (resetEntryProgress): Deleted.
2492         (browserWindowCreateBackForwardMenu): Deleted.
2493         (webViewReadyToShow): Deleted.
2494         (webViewLoadFailed): Deleted.
2495         (webViewMouseTargetChanged): Deleted.
2496         (browserWindowUpdateZoomActions): Deleted.
2497         (webViewZoomLevelChanged): Deleted.
2498         (updateUriEntryIcon): Deleted.
2499         (zoomInCallback): Deleted.
2500         (zoomOutCallback): Deleted.
2501         (toggleFullScreen): Deleted.
2502         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2503         (browserWindowFinalize): Deleted.
2504         (browser_window_class_init): Deleted.
2505         * MiniBrowser/gtk/BrowserWindow.h:
2506         * MiniBrowser/gtk/CMakeLists.txt:
2507         * MiniBrowser/gtk/main.c:
2508         (createBrowserTab):
2509         (aboutURISchemeRequestCallback):
2510         (main):
2511         (parseBackgroundColor): Deleted.
2512
2513 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2514
2515         Allow RefPtrs of const RefCounted types
2516         https://bugs.webkit.org/show_bug.cgi?id=158269
2517
2518         Reviewed by Anders Carlsson.
2519
2520         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2521         (TestWebKitAPI::TEST):
2522         (TestWebKitAPI::ConstRefCounted::create):
2523         (TestWebKitAPI::returnConstRefCountedRef):
2524         (TestWebKitAPI::returnRefCountedRef):
2525
2526 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2527
2528         Test WTF.StringViewIterators is crashing since r203119
2529         https://bugs.webkit.org/show_bug.cgi?id=159710
2530
2531         Reviewed by Darin Adler.
2532
2533         There are two problems in the test case added in r203119. First is that it's testing
2534         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2535         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2536         const reference to the string view member of the deleted CodePoints object.
2537
2538         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2539         (TestWebKitAPI::TEST):
2540
2541 2016-07-13  Daniel Bates  <dabates@apple.com>
2542
2543         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2544         https://bugs.webkit.org/show_bug.cgi?id=159738
2545         <rdar://problem/27304649>
2546
2547         Reviewed by Dan Bernstein.
2548
2549         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2550         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2551         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2552         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2553
2554         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2555         * WebKitTestRunner/ios/TestControllerIOS.mm:
2556         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2557         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2558
2559 2016-07-13  Beth Dakin  <bdakin@apple.com>
2560
2561         Attempted build fix.
2562
2563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2564
2565 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2566
2567         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2568         https://bugs.webkit.org/show_bug.cgi?id=159686
2569
2570         Reviewed by Chris Dumez.
2571
2572         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2573
2574         * WebKitTestRunner/TestController.cpp:
2575         (WTR::runOpenPanel):
2576         (WTR::TestController::createOtherPage):
2577         (WTR::TestController::createWebViewWithOptions):
2578
2579 2016-07-13  Beth Dakin  <bdakin@apple.com>
2580
2581         Add more candidate tests
2582         https://bugs.webkit.org/show_bug.cgi?id=159730
2583
2584         Reviewed by Tim Horton.
2585
2586         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
2587         two new tests to that file.
2588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2589         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2590         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2591         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2592         (TestWebKitAPI::TEST):
2593         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2594
2595 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2596
2597         AX: [ATK] spinbutton-crash.html fails
2598         https://bugs.webkit.org/show_bug.cgi?id=159723
2599
2600         Reviewed by Chris Fleizach.
2601
2602         Implement support for AXDecrementButton and AXIncrementButton in
2603         ATK's AccessibilityUIElement::uiElementAttributeValue().
2604
2605         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2606         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2607
2608 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2609
2610         [EFL] [GTK] Enable back crypto subtle on development builds.
2611         https://bugs.webkit.org/show_bug.cgi?id=159260
2612
2613         Reviewed by Carlos Garcia Campos.
2614
2615         * Scripts/webkitperl/FeatureList.pm:
2616
2617 2016-07-12  Mark Lam  <mark.lam@apple.com>
2618
2619         We should use different stack limits for stack checks from JS and host code.
2620         https://bugs.webkit.org/show_bug.cgi?id=159442
2621         <rdar://problem/26889188>
2622
2623         Reviewed by Geoffrey Garen.
2624
2625         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2626         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
2627         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
2628         order to keep the js/regress-139548.html test happy with this patch.
2629
2630         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2631         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
2632
2633         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2634         (-[LTRelayController _environmentVariables]):
2635         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2636         (main):
2637
2638 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
2639
2640         platformUserPreferredLanguages on Mac should not try to put the region into the language
2641         https://bugs.webkit.org/show_bug.cgi?id=159693
2642
2643         Rubber stamped by Alexey Proskuryakov.
2644         
2645         Revert the test change in r200105.
2646
2647         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2648         (TestWebKitAPI::languageForSystemLanguage):
2649
2650 2016-07-12  Chris Dumez  <cdumez@apple.com>
2651
2652         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2653         https://bugs.webkit.org/show_bug.cgi?id=159663
2654         <rdar://problem/18995873>
2655
2656         Reviewed by Benjamin Poulain.
2657
2658         Add API test coverage.
2659
2660         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2661         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2662         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2663         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2664         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2665         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2666         (TEST):
2667
2668 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
2669
2670         Relax ordering requirements on StringView::CodePoints iterator
2671         https://bugs.webkit.org/show_bug.cgi?id=159609
2672
2673         Reviewed by Darin Adler.
2674
2675         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2676         (TestWebKitAPI::TEST):
2677
2678 2016-07-12  Youenn Fablet  <youenn@apple.com>
2679
2680         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
2681         https://bugs.webkit.org/show_bug.cgi?id=159564
2682
2683         Reviewed by Brian Burg.
2684
2685         * Scripts/webkitpy/codegen/main.py:
2686         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
2687
2688 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2689
2690         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2691         https://bugs.webkit.org/show_bug.cgi?id=159671
2692
2693         Reviewed by Csaba Osztrogonác.
2694
2695         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2696         https://bugs.webkit.org/show_bug.cgi?id=89235
2697
2698         So this guard can be removed in build scripts.
2699
2700         * Scripts/webkitperl/FeatureList.pm:
2701         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2702
2703 2016-07-11  Jason Marcell  <jmarcell@apple.com>
2704
2705         SVN.create_patch should find svn-create-patch relative to the WebKit root.
2706         https://bugs.webkit.org/show_bug.cgi?id=159652
2707
2708         Reviewed by Daniel Bates.
2709
2710         * Scripts/webkitpy/common/checkout/scm/svn.py:
2711         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
2712
2713 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2714
2715         Implement grapheme cluster iterator on StringView
2716         https://bugs.webkit.org/show_bug.cgi?id=159598
2717
2718         Reviewed by Anders Carlsson.
2719
2720         This is in preparation for honoring the second argument to FontFaceSet.load().
2721
2722         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2723         (TestWebKitAPI::compareLoopIterations):
2724         (TestWebKitAPI::TEST):
2725
2726 2016-07-11  Nan Wang  <n_wang@apple.com>
2727
2728         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
2729         https://bugs.webkit.org/show_bug.cgi?id=158364
2730
2731         Reviewed by Anders Carlsson.
2732
2733         Added a function in TestRunner so that we can toggle the ignoring viewport
2734         scale limits setting. Also added a test option for that in order to change the 
2735         configuration of the webview in test.
2736
2737         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2738         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2739         (WTR::TestRunner::setNavigationGesturesEnabled):
2740         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2741         (WTR::nextUIScriptCallbackID):
2742         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2743         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2744         * WebKitTestRunner/TestController.cpp:
2745         (WTR::TestController::resetStateToConsistentValues):
2746         (WTR::updateTestOptionsFromTestHeader):
2747         (WTR::TestController::setNavigationGesturesEnabled):
2748         (WTR::TestController::setIgnoresViewportScaleLimits):
2749         (WTR::TestController::platformWillRunTest):
2750         * WebKitTestRunner/TestController.h:
2751         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2752         * WebKitTestRunner/TestInvocation.cpp:
2753         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2754         * WebKitTestRunner/TestOptions.h:
2755         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2756         (WTR::TestController::platformCreateWebView):
2757
2758 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
2759
2760         [GTK] install-dependencies should not install packages built by jhbuild.
2761         https://bugs.webkit.org/show_bug.cgi?id=159628
2762
2763         Reviewed by Michael Catanzaro.
2764
2765         * gtk/install-dependencies:
2766         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
2767
2768 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
2769
2770         System proxy settings not used when building deps with jhbuild
2771         https://bugs.webkit.org/show_bug.cgi?id=159567
2772
2773         Reviewed by Michael Catanzaro.
2774
2775         This adds the gsettings-desktop-schemas-devel build dep to enable
2776         the libgiognomeproxy.so gio module in glib-networking, which uses
2777         GSettings on org.gnome.system.proxy.
2778         This is needed to query system proxy settings for Gnome desktops.
2779
2780         dconf can be manually added to jhbuild to build the
2781         libdconfsettings.so gio module for GSettings, so that
2782         libgiognomeproxy.so can access system settings.
2783           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
2784
2785         As an alternative to dconf settings, this commit also adds the
2786         libproxy-devel build dep to enable the libgiolibproxy.so module in
2787         glib-networking (suggested by Fujii Hironori).
2788
2789         It is useful to read proxy settings from environment variables.
2790         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
2791         environment variable to force using the envvar module in libproxy.
2792
2793         * gtk/install-dependencies:
2794
2795 2016-07-11  Mark Lam  <mark.lam@apple.com>
2796
2797         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
2798         https://bugs.webkit.org/show_bug.cgi?id=159524
2799
2800         Reviewed by Michael Saboff.
2801
2802         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
2803         Also fixed up some tests to behave better to work with this new limit.  This
2804         should make stack overflow tests complete sooner.
2805
2806         * Scripts/run-jsc-stress-tests:
2807         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2808         (main):
2809
2810 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2811
2812         [GTK] Whitespace fixes in install-dependencies script
2813
2814         Unreviewed.
2815
2816         * gtk/install-dependencies:
2817
2818 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2819
2820         [GTK] Install missing Fedora dependencies
2821
2822         Unreviewed.
2823
2824         * gtk/install-dependencies:
2825
2826 2016-07-09  Dan Bernstein  <mitz@apple.com>
2827
2828         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
2829         https://bugs.webkit.org/show_bug.cgi?id=159600
2830
2831         Reviewed by Daniel Bates.
2832
2833         * Scripts/git-add-reviewer:
2834         Added the -s|--rubber-stamp option.
2835         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
2836           new option.
2837
2838 2016-07-08  Andy Estes  <aestes@apple.com>
2839
2840         [Content Filtering] Load blocked pages more like other error pages are loaded
2841         https://bugs.webkit.org/show_bug.cgi?id=159485
2842         <rdar://problem/26014076>
2843
2844         Reviewed by Brady Eidson.
2845
2846         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2847         to a content filtering provisional navigation failure is ignored in preference of
2848         ContentFilter's own error page.
2849
2850         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2852         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2853         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2854         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2855         (loadAlternateTest):
2856         (TEST):
2857         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2858         (-[MockContentFilterEnabler initWithCoder:]):
2859         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2860         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2861         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2862         (TestWebKitAPI::loadAlternateTest):
2863         (TestWebKitAPI::TEST):
2864
2865 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2866
2867         Unreviewed, rolling out r202944.
2868         https://bugs.webkit.org/show_bug.cgi?id=159570
2869
2870         caused some tests to crash under GuardMalloc (Requested by
2871         estes on #webkit).
2872
2873         Reverted changeset:
2874
2875         "[Content Filtering] Load blocked pages more like other error
2876         pages are loaded"
2877         https://bugs.webkit.org/show_bug.cgi?id=159485
2878         http://trac.webkit.org/changeset/202944
2879
2880 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
2881
2882         Remove mrobinson from the MathML watchlist
2883         https://bugs.webkit.org/show_bug.cgi?id=159559
2884
2885         Reviewed by Philippe Normand.
2886
2887         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
2888
2889 2016-07-08  Brady Eidson  <beidson@apple.com>
2890
2891         Clearing LocalStorage doesn't also delete -wal and -shm files.
2892         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
2893
2894         Reviewed by Brent Fulgham.
2895         Also helpfully picked over by Andy "Never Forgets" Estes.
2896
2897         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2898         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
2899         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
2900
2901 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
2902
2903         Removed Qt leftovers from Tools.
2904         https://bugs.webkit.org/show_bug.cgi?id=159557
2905
2906         Reviewed by Csaba Osztrogonác.
2907
2908         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2909         Removed 'qt' platform config.
2910         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2911         Deleted non-functional e-mail address.
2912
2913 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2914
2915         Unreviewed, rolling out r202967.
2916         https://bugs.webkit.org/show_bug.cgi?id=159556
2917
2918         This patch caused crashes in https tests on Windows (Requested
2919         by perarne on #webkit).
2920
2921         Reverted changeset:
2922
2923         "[Win] The test http/tests/security/contentSecurityPolicy
2924         /upgrade-insecure-requests/basic-upgrade.https.html is
2925         failing."
2926         https://bugs.webkit.org/show_bug.cgi?id=159510
2927         http://trac.webkit.org/changeset/202967
2928
2929 2016-07-08  Youenn Fablet  <youenn@apple.com>
2930
2931         Generate WebCore builtin wrapper files
2932         https://bugs.webkit.org/show_bug.cgi?id=159461
2933
2934         Reviewed by Brian Burg.
2935
2936         * Scripts/webkitpy/codegen/main.py:
2937         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
2938         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
2939
2940 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
2941
2942         [EFL] Fix build when media-stream is enabled.
2943         https://bugs.webkit.org/show_bug.cgi?id=159206
2944
2945         Bump up the openwebrtc to find the correct package.
2946
2947         Reviewed by Gyuyoung Kim.
2948
2949         * efl/jhbuild.modules:
2950         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
2951
2952 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2953
2954         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
2955         https://bugs.webkit.org/show_bug.cgi?id=159510
2956
2957         Reviewed by Brent Fulgham.
2958
2959         Allow any https certificate when running tests.
2960
2961         * DumpRenderTree/win/DumpRenderTree.cpp:
2962         (runTest):
2963
2964 2016-07-07  Beth Dakin  <bdakin@apple.com>
2965
2966         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
2967         https://bugs.webkit.org/show_bug.cgi?id=159532
2968         -and corresponding-
2969         rdar://problem/27177179
2970
2971         Reviewed by Tim Horton.
2972
2973         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
2974         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
2975
2976 2016-07-07  Andy Estes  <aestes@apple.com>
2977
2978         [Content Filtering] Load blocked pages more like other error pages are loaded
2979         https://bugs.webkit.org/show_bug.cgi?id=159485
2980         <rdar://problem/26014076>
2981
2982         Reviewed by Brady Eidson.
2983
2984         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2985         to a content filtering provisional navigation failure is ignored in preference of
2986         ContentFilter's own error page.
2987
2988         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2989         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2990         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2991         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2992         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2993         (loadAlternateTest):
2994         (TEST):
2995         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2996         (-[MockContentFilterEnabler initWithCoder:]):
2997         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2998         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2999         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3000         (TestWebKitAPI::loadAlternateTest):
3001         (TestWebKitAPI::TEST):
3002
3003 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3004
3005         Unreviewed: add myself to the reviewers list.
3006
3007         * Scripts/webkitpy/common/config/contributors.json:
3008
3009 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3010
3011         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
3012         https://bugs.webkit.org/show_bug.cgi?id=159509
3013
3014         Reviewed by Alex Christensen.
3015
3016         We should always insert the url in the url map when identifierForInitialRequest
3017         is called. Otherwise we can end up with identifiers not having an entry in the
3018         url map when urls are written to the test output file. 
3019
3020         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3021         (ResourceLoadDelegate::identifierForInitialRequest):
3022
3023 2016-07-06  Tim Horton  <timothy_horton@apple.com>
3024
3025         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3026         https://bugs.webkit.org/show_bug.cgi?id=159498
3027         <rdar://problem/26719903>
3028
3029         Reviewed by Sam Weinig.
3030
3031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3032         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3033         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3034         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3035         (expectLinkCount):
3036         (TEST):
3037         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3038         when deciding what to linkify.
3039
3040 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3041
3042         Build fix - work around rdar://problem/27196668.
3043
3044         * LayoutTestRelay/Configurations/Base.xcconfig:
3045
3046 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3047
3048         Enhance Windows DRT implementation to support platform scroll wheel events.
3049         https://bugs.webkit.org/show_bug.cgi?id=36002
3050
3051         Reviewed by Brent Fulgham.
3052
3053         Implement function continuousMouseScrollBy in Windows event sender.
3054
3055         * DumpRenderTree/win/EventSender.cpp:
3056         (mouseScrollBy):
3057         (continuousMouseScrollBy):
3058
3059 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3060
3061         [Sierra] Rebaseline tests to use un-mocked system font metrics
3062         https://bugs.webkit.org/show_bug.cgi?id=159311
3063         <rdar://problem/24138411>
3064
3065         Reviewed in person by Alexey Proskuryakov.
3066
3067         Stop mocking the system font on Sierra.
3068
3069         * DumpRenderTree/mac/DumpRenderTree.mm:
3070         (setDefaultsToConsistentValuesForTesting):
3071         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3072         (WTR::InjectedBundle::platformInitialize):
3073
3074 2016-07-05  Brady Eidson  <beidson@apple.com>
3075
3076         Database process crashes deleting a corrupt SQLite database file (null deref).
3077         https://bugs.webkit.org/show_bug.cgi?id=155506.
3078
3079         Reviewed by Alex Christensen.
3080
3081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3082         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3083         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3084         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3085         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3086         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3087
3088 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3089
3090         run-webkit-tests should print more complete baseline search paths
3091         https://bugs.webkit.org/show_bug.cgi?id=159354
3092
3093         Reviewed by Daniel Bates.
3094
3095         run-webkit-tests used to only print directory names in baseline search paths.
3096         This was ok in basic usage, but quickly got confusing when using
3097         --additional-platform-directory flags.
3098
3099         * Scripts/webkitpy/layout_tests/views/printing.py:
3100         (Printer.print_config):
3101         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3102         (Testprinter.test_print_config):
3103         (Testprinter.test_print_one_line_summary):
3104
3105 2016-07-04  Brady Eidson  <beidson@apple.com>
3106
3107         WebProcesses don't handle DatabaseProcess going away uncleanly..
3108         https://bugs.webkit.org/show_bug.cgi?id=159371
3109
3110         Reviewed by Alex Christensen.
3111
3112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3113         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3114         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3115         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3116         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3117
3118 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3119
3120         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3121         https://bugs.webkit.org/show_bug.cgi?id=158141
3122
3123         Rubber-stamped by Michael Catanzaro.
3124
3125         Instead of checking for an specific Ubuntu version, query the apt
3126         database to see which version of PHP is available.
3127
3128         * efl/install-dependencies:
3129         * gtk/install-dependencies:
3130
3131 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3132
3133         webkit-patch failure-reason always raises TypeError
3134         https://bugs.webkit.org/show_bug.cgi?id=159394
3135
3136         Reviewed by Benjamin Poulain.
3137
3138         In r170637 (Bug 133067), the first and second arguments of
3139         pluralize were swapped.
3140
3141         * Scripts/webkitpy/tool/commands/queries.py:
3142         (FailureReason._builder_to_explain): Swap the first and second
3143         arguments of pluralize.
3144
3145 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3146
3147         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3148         https://bugs.webkit.org/show_bug.cgi?id=152486
3149
3150         Reviewed by Daniel Bates.
3151
3152         Add launch of web-platform-tests server by run-webkit-httpd.
3153         Add two options to disable starting httpd and web-platform-tests servers.
3154
3155         * Scripts/run-webkit-httpd:
3156         (parse_args):
3157         (main):
3158
3159 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3160
3161         REGRESSION(r189668): Notification tests are flakey
3162         https://bugs.webkit.org/show_bug.cgi?id=159375
3163         <rdar://problem/22760990>
3164
3165         Reviewed by Alexey Proskuryakov.
3166
3167         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3168         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3169         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3170         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3171
3172         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3173         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3174         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3175         global notification ID mapping, causing the wrong notification to be investigated.
3176
3177         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3178         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3179         notification is created or destroyed. However, because this object is implemented outside WebKit,
3180         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3181         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3182         WebNotificationProvider can properly map between the different IDs.
3183
3184         * WebKitTestRunner/TestController.cpp:
3185         (WTR::TestController::runTestingServerLoop):
3186         (WTR::TestController::simulateWebNotificationClick):
3187         * WebKitTestRunner/WebNotificationProvider.cpp:
3188         (WTR::WebNotificationProvider::showWebNotification):
3189         (WTR::removeGlobalIDFromIDMap):
3190         (WTR::WebNotificationProvider::closeWebNotification):
3191         (WTR::WebNotificationProvider::removeNotificationManager):
3192         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3193         (WTR::WebNotificationProvider::reset):
3194         * WebKitTestRunner/WebNotificationProvider.h:
3195
3196 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3197
3198         Simplify LayoutTestRelay
3199         https://bugs.webkit.org/show_bug.cgi?id=159353
3200
3201         Reviewed by Daniel Bates.
3202
3203         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3204         by name and runtime makes no sense.
3205         2. Removed code to create devices, webkitpy always does this in advance.
3206         3. Don't create copies of testing apps - we can install the same one into
3207         each simulator, now that we don't run multiple tester processes in a single simulator.
3208         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3209         5. Removed code that kept testing apps alive in the background.
3210         6. Slightly updated coding style in functions that I touched.
3211
3212         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3213         Updated for what we acually use at this point.
3214
3215         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3216         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3217         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3218         (-[LTRelayController ipcIdentifier]):
3219         (-[LTRelayController processName]):
3220         (-[LTRelayController didReceiveStdoutData:]):
3221         (-[LTRelayController didCrashWithMessage:]):
3222         (-[LTRelayController installApp]):
3223         (-[LTRelayController _environmentVariables]):
3224         (-[LTRelayController launchApp]):
3225         (-[LTRelayController start]):
3226         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3227         (-[LTRelayController uniqueAppPath]): Deleted.
3228         (-[LTRelayController uniqueAppURL]): Deleted.
3229         (-[LTRelayController uniqueAppIdentifier]): Deleted.
3230         (-[LTRelayController createUniqueApp]): Deleted.
3231         * LayoutTestRelay/LayoutTestRelay/main.m:
3232         (usage):
3233         (getRequiredStringArgument):
3234         (main):
3235         (getTestingSimDevice): Deleted.
3236         * Scripts/webkitpy/port/driver.py:
3237         (IOSSimulatorDriver.cmd_line):
3238         * WebKitTestRunner/ios/TestControllerIOS.mm:
3239         (WTR::TestController::platformInitialize):
3240         * WebKitTestRunner/ios/mainIOS.mm:
3241         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3242         * DumpRenderTree/mac/DumpRenderTree.mm:
3243         (dumpRenderTree):
3244         (-[DumpRenderTree applicationDidEnterBackground:]):
3245
3246 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
3247
3248         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3249         https://bugs.webkit.org/show_bug.cgi?id=159344
3250
3251         Reviewed by Alex Christensen.
3252
3253         * DumpRenderTree/CMakeLists.txt:
3254
3255 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3256
3257         Add a runtime flag for DOM iterators
3258         https://bugs.webkit.org/show_bug.cgi?id=159300
3259
3260         Reviewed by Alex Christensen.
3261
3262         * DumpRenderTree/mac/DumpRenderTree.mm:
3263         (resetWebPreferencesToConsistentValues):
3264         * DumpRenderTree/win/DumpRenderTree.cpp:
3265         (resetWebPreferencesToConsistentValues):
3266         * Scripts/webkitperl/FeatureList.pm:
3267         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3268         (WTR::InjectedBundle::beginTesting):
3269         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3270         (WTR::TestRunner::setDOMIteratorEnabled):
3271         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3272
3273 2016-06-30  Tina Liu  <iting_liu@apple.com>
3274
3275         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3276         https://bugs.webkit.org/show_bug.cgi?id=159326
3277
3278         Reviewed by Brady Eidson.
3279
3280         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3281         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3282         (TestWebKitAPI::didFinishLoadForFrame):
3283         (TestWebKitAPI::didChangeBackForwardListForPage):
3284         (TestWebKitAPI::setPageLoaderClient):
3285         Set the page loader client and register for didFinishLoadForFrame and
3286         didChangeBackForwardList callbacks.
3287         (TestWebKitAPI::createSessionStateData):
3288         Load a webpage ("simple.html") and return the session state for this page.
3289         (TestWebKitAPI::TEST):
3290         Restore the page session state with that of "simple.html" without navigation.
3291         Verify that the committed URL is NULL since there's no navigation involved.
3292         Verify that the current item in the back forward list, which should be what
3293         we restored from the session state, has the expected URL.
3294
3295 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
3296
3297         Generators violate bytecode liveness validation
3298         https://bugs.webkit.org/show_bug.cgi?id=159279
3299
3300         Reviewed by Yusuke Suzuki.
3301         
3302         Add Basic to our test harness.
3303
3304         * Scripts/run-javascriptcore-tests:
3305         (runJSCStressTests):
3306
3307 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
3308
3309         [Win][Debug] Assertion fails in TestWTF.
3310         https://bugs.webkit.org/show_bug.cgi?id=159299
3311
3312         Reviewed by Alex Christensen.
3313
3314         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3315         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3316         the assertion failure. Since the variable is actually used, there is no need to use the
3317         UNUSED_PARAM macro.
3318
3319         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3320         (TestWebKitAPI::TEST):
3321
3322 2016-06-30  Youenn Fablet  <youennf@gmail.com>
3323
3324         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
3325         https://bugs.webkit.org/show_bug.cgi?id=159166
3326         <rdar://problem/27051759>
3327
3328         Reviewed by Alexey Proskuryakov.
3329
3330         Setting the certificate directory to the copied config.json.
3331
3332         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3333         (WebPlatformTestServer._copy_webkit_test_files):
3334
3335 2016-06-29  Mark Lam  <mark.lam@apple.com>
3336
3337         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
3338         https://bugs.webkit.org/show_bug.cgi?id=159274
3339
3340         Reviewed by Keith Miller.
3341
3342         * DumpRenderTree/mac/DumpRenderTree.mm:
3343         (DumpRenderTreeMain):
3344
3345 2016-06-29  Alex Christensen  <achristensen@webkit.org>
3346
3347         WKWebView should ask WKNavigationDelegate about bad ssl certificates
3348         https://bugs.webkit.org/show_bug.cgi?id=159176
3349
3350         Reviewed by Sam Weinig.
3351
3352         * MiniBrowser/mac/WK2BrowserWindowController.m:
3353         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3354         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3355         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3356
3357 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3358
3359         [GTK] Add missing install dependency after r202619
3360         https://bugs.webkit.org/show_bug.cgi?id=156716
3361
3362         Unreviewed.
3363
3364         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3365
3366 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3367
3368         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3369         https://bugs.webkit.org/show_bug.cgi?id=156716
3370
3371         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3372
3373         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3374         (parse_args):
3375         * Scripts/webkitpy/port/gtk.py:
3376         (GtkPort.__init__):
3377         (GtkPort._driver_class):
3378         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3379         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3380         platform directory for storing the wayland specific layout test results and expectations for ${port}.
3381         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3382         test expectations file on the GTK port when running the tests with the --wayland command line switch.
3383         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3384         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3385         (WestonDriver.check_driver):
3386         (WestonDriver.__init__):
3387         (WestonDriver._start):
3388         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3389         (WestonXvfbDriverDisplayTest):
3390         (WestonXvfbDriverDisplayTest.__init__):
3391         (WestonXvfbDriverDisplayTest._xvfb_run):
3392         (WestonDriverTest.make_driver):
3393         (WestonDriverTest.test_start):
3394         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3395         or to satisfy the pkg-config check of the new added modules in JHBuild.
3396         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3397         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3398         provided by the system are already new enough.
3399         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3400         It was the only way to get the software EGL rasterizer working without depending on user drivers.
3401         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3402         feature to avoid building libdrm when the one provided by the system is new enough.
3403         * gtk/jhbuildrc:
3404         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
3405         Xorg had no support for searching the DRI drivers on a custom path at runtime.
3406         This patch implements support for that reusing the same variable that we use with Mesa to set the
3407         custom path for the DRI drivers path.
3408
3409 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
3410
3411         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
3412         https://bugs.webkit.org/show_bug.cgi?id=159256
3413
3414         Reviewed by Philippe Normand.
3415
3416         We need the last fixes in the repository to make the scream queue
3417         work with apprtc.
3418
3419         * gtk/jhbuild.modules:
3420
3421 2016-06-28  Commit Queue  <commit-queue@webkit.org>
3422
3423         Unreviewed, rolling out r202580.
3424         https://bugs.webkit.org/show_bug.cgi?id=159245
3425
3426         Caused all WKTR tests to fail on GuardMalloc and Production
3427         only for unknown reasons, investigating offline. (Requested by
3428         brrian on #webkit).
3429
3430         Reverted changeset:
3431
3432         "RunLoop::Timer should use constructor templates instead of
3433         class templates"
3434         https://bugs.webkit.org/show_bug.cgi?id=159153
3435         http://trac.webkit.org/changeset/202580
3436
3437 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3438
3439         Use a regex to check if a test step is for JavaScriptCore
3440         https://bugs.webkit.org/show_bug.cgi?id=159224
3441
3442         Reviewed by Geoffrey Garen.
3443
3444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3445         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
3446         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3447         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
3448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3449         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
3450
3451 2016-06-28  Michael Saboff  <msaboff@apple.com>
3452
3453         btjs no longer accepts optional frame count argument
3454         https://bugs.webkit.org/show_bug.cgi?id=159235
3455
3456         Reviewed by Saam Barati.
3457
3458         Fix the detection of optional backtrace-depth parameter to use the length
3459         of the command.
3460
3461         * lldb/lldb_webkit.py:
3462         (btjs):
3463
3464 2016-06-28  Jon Lee  <jonlee@apple.com>
3465
3466         Update animometer.plan
3467
3468         Rubber-stamped by Said Abou-Hallawa.
3469
3470         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
3471
3472 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
3473
3474         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
3475
3476         * Scripts/run-javascriptcore-tests:
3477         (runJSCStressTests):
3478
3479 2016-06-28  Brian Burg  <bburg@apple.com>
3480
3481         RunLoop::Timer should use constructor templates instead of class templates
3482         https://bugs.webkit.org/show_bug.cgi?id=159153
3483
3484         Reviewed by Alex Christensen.
3485
3486         Remove the RunLoop::Timer class template argument, and pass its constructor
3487         a reference to `this` instead of a pointer to `this`.
3488
3489         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3490         (WTR::TestRunner::TestRunner):
3491         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3492         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3493         (TestWebKitAPI::TEST):
3494
3495 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3496
3497         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3498         https://bugs.webkit.org/show_bug.cgi?id=159199
3499
3500         Reviewed by Alexey Proskuryakov.
3501
3502         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
3503
3504         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3505         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3506         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
3507         an input element getting automatically focused on Mac.
3508
3509 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
3510
3511         [Win] Custom elements tests are failing.
3512         https://bugs.webkit.org/show_bug.cgi?id=159139
3513
3514         Reviewed by Alex Christensen.
3515
3516         Enable custom element API when running tests.
3517
3518         * DumpRenderTree/win/DumpRenderTree.cpp:
3519         (resetWebPreferencesToConsistentValues):
3520
3521 2016-06-27  Lucas Forschler  <lforschler@apple.com>
3522
3523         Test commit. Please ignore.
3524         
3525 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3526
3527         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
3528         https://bugs.webkit.org/show_bug.cgi?id=155073
3529
3530         Reviewed by Daniel Bates.
3531
3532         * Scripts/webkitperl/FeatureList.pm:
3533
3534 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
3535
3536         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3537         https://bugs.webkit.org/show_bug.cgi?id=159077
3538
3539         Reviewed by Tim Horton.
3540
3541         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
3542
3543         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
3544         which is necessary for UI-side compositing.
3545
3546         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
3547         seems to happen for some tests that call window.resizeTo().
3548
3549         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3550         (WTR::InjectedBundlePage::dump): Deleted.
3551         * WebKitTestRunner/TestInvocation.cpp:
3552         (WTR::TestInvocation::dumpResults):
3553         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3554         (WTR::createCGContextFromImage):
3555         (WTR::computeMD5HashStringForContext):
3556         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3557         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3558         (WTR::PlatformWebView::windowSnapshotImage):
3559
3560 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3561
3562         [EFL] Support to build on Debian linux
3563         https://bugs.webkit.org/show_bug.cgi?id=159123
3564
3565         Reviewed by Antonio Gomes.
3566
3567         * efl/install-dependencies: Install libgnutls28-dev.
3568
3569 2016-06-27  Alex Christensen  <achristensen@webkit.org>
3570
3571         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
3572         https://bugs.webkit.org/show_bug.cgi?id=159071
3573
3574         Reviewed by Brady Eidson.
3575
3576         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3577         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3578         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3579         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3580         (WTR::TestRunner::setAuthenticationUsername):
3581         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3582         * WebKitTestRunner/TestController.cpp:
3583         (WTR::TestController::TestController):
3584         (WTR::TestController::resetStateToConsistentValues):
3585         (WTR::TestController::didFinishNavigation):
3586         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3587         (WTR::TestController::didReceiveAuthenticationChallenge):
3588         (WTR::TestController::didCommitNavigation):
3589         * WebKitTestRunner/TestController.h:
3590         (WTR::TestController::setBlockAllPlugins):
3591         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3592         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
3593         (WTR::TestController::isCurrentInvocation):
3594         * WebKitTestRunner/TestInvocation.cpp:
3595         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3596         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
3597
3598 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
3599
3600         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
3601         https://bugs.webkit.org/show_bug.cgi?id=159129
3602
3603         Reviewed by Alex Christensen.
3604
3605         Implement the function mouseScrollBy in the Windows event sender.
3606
3607         * DumpRenderTree/win/EventSender.cpp:
3608         (mouseScrollBy):
3609         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3610
3611 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
3612
3613         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3614         https://bugs.webkit.org/show_bug.cgi?id=159104
3615
3616         Reviewed by Dan Bernstein.
3617         
3618         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
3619         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
3620
3621         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3622         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
3624
3625 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
3626
3627         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
3628         https://bugs.webkit.org/show_bug.cgi?id=159086
3629
3630         Reviewed by Alex Christensen.
3631
3632         Implement required wheel event function in event sender.
3633  
3634         * DumpRenderTree/win/EventSender.cpp:
3635         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3636
3637 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
3638
3639         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3640         https://bugs.webkit.org/show_bug.cgi?id=159104
3641
3642         Reviewed by Mark Lam.
3643         
3644         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
3645         WK.
3646
3647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3648
3649 2016-06-24  David Kilzer  <ddkilzer@apple.com>
3650
3651         parser_unittests.pl should not hardcode list of tests
3652         <https://webkit.org/b/159074>
3653
3654         Reviewed by Daniel Bates.
3655
3656         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3657         Update to read the list of tests from the 'resources' directory,
3658         and instead map file extensions to subroutine names.  Switch to
3659         use File::Basename::fileparse() to get basename and file
3660         extension for each test.
3661         (readTestFiles): Added.  Reads files from the directory passed
3662         in and ignores: hidden files, anything that isn't a plain file,
3663         and expected test results files.
3664
3665 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3666
3667         Fix Windows build.
3668
3669         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3670         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3671
3672 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3673
3674         [EFL] Change download path of libxslt
3675
3676         Unreviewed EFL build fix.
3677
3678         In Korea current download path can't be accessed. Change it.
3679
3680         * efl/jhbuild.modules:
3681
3682 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3683
3684         https://bugs.webkit.org/show_bug.cgi?id=159077
3685
3686         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
3687         snapshot the final state of the test in release builds. 
3688
3689         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3690         (WTR::InjectedBundlePage::dump):
3691
3692 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3693
3694         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
3695
3696         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3697         (createBitmapContextFromWebView):
3698         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3699         (WTR::PlatformWebView::windowSnapshotImage):
3700
3701 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3702
3703         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3704         https://bugs.webkit.org/show_bug.cgi?id=159077
3705
3706         Reviewed by Tim Horton.
3707
3708         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
3709         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
3710         thus enabling testing of more things.
3711
3712         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3713         (createBitmapContext): Moved to this file to share it.
3714         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3715         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3716         (createBitmapContextFromWebView):
3717         (BitmapContext::createFromUIImage): Deleted.
3718         (BitmapContext::pixelData): Deleted.
3719         (BitmapContext::BitmapContext): Deleted.
3720         (computeMD5HashStringForBitmapContext): Deleted.
3721         (dumpBitmap): Deleted.
3722         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
3723         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3724         (createPagedBitmapContext):
3725         (createBitmapContext): Deleted.
3726         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
3727         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3728         (WTR::InjectedBundlePage::dump): Deleted.
3729         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3730         (WTR::PlatformWebView::windowSnapshotImage):
3731
3732 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3733
3734         [jhbuild] Added libxslt module.
3735         https://bugs.webkit.org/show_bug.cgi?id=159034
3736
3737         Unreviewed, followup for r202373.
3738
3739         * efl/install-dependencies: Removed libxslt 
3740         * gtk/install-dependencies: Ditto.
3741
3742 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3743
3744         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
3745         https://bugs.webkit.org/show_bug.cgi?id=159050
3746
3747         Reviewed by Antonio Gomes.
3748
3749         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
3750
3751         * efl/jhbuild.modules:
3752         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3753         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3754
3755 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3756
3757         [jhbuild] Added libxslt module.
3758         https://bugs.webkit.org/show_bug.cgi?id=159034
3759
3760         Reviewed by Michael Catanzaro.
3761
3762         * efl/jhbuild.modules:
3763         * gtk/jhbuild.modules:
3764
3765 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3766
3767         [Win] Use Windows api function to find top level parent.
3768         https://bugs.webkit.org/show_bug.cgi?id=159021
3769
3770         Reviewed by Brent Fulgham.
3771
3772         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
3773  
3774         * DumpRenderTree/win/UIDelegate.cpp:
3775         (UIDelegate::runModal):
3776         (findTopLevelParent): Deleted.
3777         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3778         (PrintWebUIDelegate::runModal):
3779         (findTopLevelParent): Deleted.
3780
3781 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3782
3783         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
3784         https://bugs.webkit.org/show_bug.cgi?id=158934
3785
3786         Reviewed by Brent Fulgham.
3787
3788         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
3789
3790         * DumpRenderTree/win/TestRunnerWin.cpp:
3791         (TestRunner::clearAllDatabases):
3792
3793 2016-06-22  Saam Barati  <sbarati@apple.com>
3794
3795         run-javascriptcore-tests should have some environment variables for commonly used settings
3796         https://bugs.webkit.org/show_bug.cgi?id=159047
3797
3798         Reviewed by Keith Miller.
3799
3800         This patch adds three environment variables that run-javascriptcore-tests
3801         consults:
3802         - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
3803           determines if we should run the api tests or not.
3804         - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
3805           determines if we will perform a build or not before running the tests.
3806           to set the default should-build setting.
3807         - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
3808           a yaml file. If set, we will run the extra tests it refers to.
3809
3810         All the values in these environment variables will be overridden if an
3811         option is explicitly passed in. For example, the following will run
3812         the api tests:
3813         `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
3814
3815         * Scripts/run-javascriptcore-tests:
3816
3817 2016-06-22  Saam barati  <sbarati@apple.com>
3818
3819         TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
3820         https://bugs.webkit.org/show_bug.cgi?id=159037
3821         <rdar://problem/26935349>
3822
3823         Reviewed by Benjamin Poulain.
3824
3825         Run typeProfiler.yaml tests under an additional CJIT enabled mode.
3826
3827         * Scripts/run-jsc-stress-tests:
3828
3829 2016-06-22  Aakash Jain  <aakash_jain@apple.com>
3830
3831         Fix style issues in webkitpy
3832         https://bugs.webkit.org/show_bug.cgi?id=159019
3833
3834         Reviewed by Daniel Bates.
3835
3836         Fixed the formatting issues as reported by check-webkit-style in webkitpy.
3837         There is no functionality change.
3838         Only affected file names retained below for brevity.
3839
3840         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3841         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3842         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3843         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3844         * Scripts/webkitpy/benchmark_runner/utils.py:
3845         * Scripts/webkitpy/common/checkout/changelog.py:
3846         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3847         * Scripts/webkitpy/common/checkout/checkout.py:
3848         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3849         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3850         * Scripts/webkitpy/common/checkout/commitinfo.py:
3851         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3852         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3853         * Scripts/webkitpy/common/checkout/scm/scm.py:
3854         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3855         * Scripts/webkitpy/common/config/committers_unittest.py:
3856         * Scripts/webkitpy/common/config/irc.py:
3857         * Scripts/webkitpy/common/config/ports.py:
3858         * Scripts/webkitpy/common/config/ports_unittest.py:
3859         * Scripts/webkitpy/common/config/urls.py:
3860         * Scripts/webkitpy/common/host_mock.py:
3861         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3862         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3863         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3864         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3865         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3866         * Scripts/webkitpy/common/net/credentials_unittest.py:
3867         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
3868         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3869         * Scripts/webkitpy/common/net/statusserver.py:
3870         * Scripts/webkitpy/common/system/autoinstall.py:
3871         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3872         * Scripts/webkitpy/common/system/executive.py:
3873         * Scripts/webkitpy/common/system/executive_mock.py:
3874         * Scripts/webkitpy/common/system/executive_unittest.py:
3875         * Scripts/webkitpy/common/system/filesystem_mock.py:
3876         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3877         * Scripts/webkitpy/common/system/logutils_unittest.py:
3878         * Scripts/webkitpy/common/system/path.py:
3879         * Scripts/webkitpy/common/system/path_unittest.py:
3880         * Scripts/webkitpy/common/system/platforminfo.py:
3881         * Scripts/webkitpy/common/system/user.py:
3882         * Scripts/webkitpy/common/system/user_unittest.py:
3883         * Scripts/webkitpy/common/system/workspace_unittest.py:
3884         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
3885         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
3886         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3887         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3888         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3889         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3890         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3891         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3892         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3893         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3894         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3895         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3896         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3897         * Scripts/webkitpy/layout_tests/views/printing.py:
3898         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3899         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3900         * Scripts/webkitpy/port/base_unittest.py:
3901         * Scripts/webkitpy/port/driver.py:
3902         * Scripts/webkitpy/port/driver_unittest.py:
3903         * Scripts/webkitpy/port/factory.py:
3904         * Scripts/webkitpy/port/gtk.py:
3905         * Scripts/webkitpy/port/server_process_unittest.py:
3906         * Scripts/webkitpy/port/test.py:
3907         * Scripts/webkitpy/port/win.py:
3908         * Scripts/webkitpy/style/checker.py:
3909         * Scripts/webkitpy/style/checkers/common_unittest.py:
3910         * Scripts/webkitpy/style/checkers/cpp.py:
3911         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3912         * Scripts/webkitpy/style/checkers/js.py:
3913         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3914         * Scripts/webkitpy/style/checkers/png.py:
3915         * Scripts/webkitpy/style/checkers/text.py:
3916         * Scripts/webkitpy/style/checkers/text_unittest.py:
3917         * Scripts/webkitpy/style/error_handlers.py:
3918         * Scripts/webkitpy/style/filter.py:
3919         * Scripts/webkitpy/style/filter_unittest.py:
3920         * Scripts/webkitpy/style/optparser.py:
3921         * Scripts/webkitpy/style/optparser_unittest.py:
3922         * Scripts/webkitpy/test/main.py:
3923         * Scripts/webkitpy/w3c/test_converter.py:
3924         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3925         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3926         * Scripts/webkitpy/xcode/simulator.py:
3927
3928 2016-06-22  Brady Eidson  <beidson@apple.com>
3929
3930         DatabaseProcess doesn't handle WebProcesses going away uncleanly.
3931         https://bugs.webkit.org/show_bug.cgi?id=158894
3932
3933         Reviewed by Alex Christensen.
3934
3935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3936         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
3937         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
3938         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3939
3940 2016-06-22  Jon Lee  <jonlee@apple.com>
3941
3942         Update animometer.plan
3943         https://bugs.webkit.org/show_bug.cgi?id=159012
3944
3945         Reviewed by Ryosuke Niwa.
3946
3947         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
3948
3949 2016-06-22  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3950
3951         W3C test importer should generate files to ignore by WebKit SCM
3952         https://bugs.webkit.org/show_bug.cgi?id=142743
3953
3954         Reviewed by Darin Adler.
3955
3956         TestDownloader generates the .gitignore file according submodules git repository information.
3957         TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.
3958
3959         * Scripts/webkitpy/w3c/test_downloader.py:
3960         (TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
3961         * Scripts/webkitpy/w3c/test_importer.py:
3962         (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
3963         (TestImporter):
3964         (TestImporter.write_init_py): Writing not empty __init__.py files.
3965         (TestImporter.import_tests): Using  of write_init_py. 
3966         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3967         (TestImporterTest.test_git_ignore_generation): Added .gitignore test.
3968         (TestImporterTest):
3969         (TestImporterTest.test_initpy_generation): Added __init__.py test.
3970
3971 2016-06-21  Sam Weinig  <sam@webkit.org>
3972
3973         WKWebView with no WKNavigationDelegate does not follow universal links
3974         <rdar://problem/24374110>
3975         https://bugs.webkit.org/show_bug.cgi?id=158997
3976
3977         Reviewed by Dan Bernstein.
3978
3979         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3980         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
3981         Add a new test that shows that we have a default navigation delegate by swizzling
3982         -[NSWorkspace openURL:]. This will only be called if there is a default client.
3983
3984 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3985
3986         [Win] Implement modal dialog support in MiniBrowser.
3987         https://bugs.webkit.org/show_bug.cgi?id=158976
3988
3989         Reviewed by Brent Fulgham.
3990
3991         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3992         (PrintWebUIDelegate::createWebViewWithRequest):
3993         (getHandleFromWebView):
3994         (PrintWebUIDelegate::webViewClose):
3995         (PrintWebUIDelegate::setFrame):
3996         (PrintWebUIDelegate::webViewFrame):
3997         (PrintWebUIDelegate::canRunModal):
3998         (findTopLevelParent):
3999         (PrintWebUIDelegate::runModal):
4000         (PrintWebUIDelegate::createModalDialog):
4001         * MiniBrowser/win/PrintWebUIDelegate.h:
4002         (PrintWebUIDelegate::webViewClose):
4003         (PrintWebUIDelegate::setFrame):
4004         (PrintWebUIDelegate::webViewFrame):
4005         (PrintWebUIDelegate::canRunModal):
4006         (PrintWebUIDelegate::runModal):
4007
4008 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4009
4010         window.showModalDialog doesn't work in DumpRenderTree on Windows
4011         https://bugs.webkit.org/show_bug.cgi?id=53675
4012
4013         Reviewed by Brent Fulgham.
4014
4015         Implement modal dialog support in DumpRenderTree.
4016
4017         * DumpRenderTree/win/UIDelegate.cpp:
4018         (UIDelegate::canRunModal):
4019         (getHandleFromWebView):
4020         (UIDelegate::createModalDialog):
4021         (findTopLevelParent):
4022         (UIDelegate::runModal):
4023         (UIDelegate::webViewClose):
4024         * DumpRenderTree/win/UIDelegate.h:
4025
4026 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
4027
4028         Fix formatting issues reported by check-webkit-style
4029         https://bugs.webkit.org/show_bug.cgi?id=159008
4030
4031         Reviewed by Alexey Proskuryakov.
4032
4033         Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
4034         There is no functionality change.
4035
4036         * Scripts/webkitpy/tool/bot/irc_command.py:
4037         (Restart.execute):
4038         (Rollout):
4039         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
4040         (IRCBotTest.test_exception_during_command):
4041         (IRCBotTest.test_exception_during_command.CommandWithException):
4042         (IRCBotTest.test_exception_during_command.CommandWithException.execute):
4043         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
4044         (test_missing_unit_test_results_path):
4045         (test_layout_test_results):
4046         * Scripts/webkitpy/tool/bot/queueengine.py:
4047         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
4048         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
4049         (AbstractSequencedCommand):
4050         (AbstractSequencedCommand.__init__):
4051         * Scripts/webkitpy/tool/commands/download.py:
4052         (Land):
4053         * Scripts/webkitpy/tool/commands/openbugs.py:
4054         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
4055         (OpenBugsTest):
4056         * Scripts/webkitpy/tool/commands/queries.py:
4057         (PatchesToCommitQueue):
4058         (PatchesToCommitQueue.__init__):
4059         (PatchesToCommitQueue._needs_commit_queue):
4060         * Scripts/webkitpy/tool/commands/queries_unittest.py:
4061         (PrintExpectationsTest.test_platform):
4062         (PrintBaselinesTest):
4063         (PrintBaselinesTest.setUp):
4064         * Scripts/webkitpy/tool/commands/queues.py:
4065         (AbstractQueue):
4066         (AbstractQueue.__init__):
4067         (AbstractQueue.execute):
4068         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4069         (test_auto_retry):
4070         * Scripts/webkitpy/tool/commands/rebaseline.py:
4071         (AbstractParallelRebaselineCommand._files_to_add):
4072         (AbstractParallelRebaselineCommand):
4073         (AbstractParallelRebaselineCommand._rebaseline):
4074         * Scripts/webkitpy/tool/commands/setupgitclone.py:
4075         (SetupGitClone):
4076         * Scripts/webkitpy/tool/commands/sheriffbot.py:
4077         * Scripts/webkitpy/tool/commands/stepsequence.py:
4078         * Scripts/webkitpy/tool/commands/upload.py:
4079         (PostCommits._comment_text_for_commit):
4080         (PostCommits):
4081         (PostCommits.execute):
4082         (MarkBugFixed):
4083         (MarkBugFixed.__init__):
4084         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4085         (UploadCommandsTest):
4086         (UploadCommandsTest.test_commit_message_for_current_diff):
4087         * Scripts/webkitpy/tool/grammar_unittest.py:
4088         (GrammarTest):
4089         (GrammarTest.test_join_with_separators):
4090         * Scripts/webkitpy/tool/multicommandtool.py:
4091         (HelpCommand.__init__):
4092         (HelpCommand):
4093         (HelpCommand._help_epilog):
4094         (HelpCommand._remove_help_options):
4095         (MultiCommandTool):
4096         (MultiCommandTool.__init__):
4097         (MultiCommandTool.main):
4098         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
4099         (TrivialCommand):
4100         (TrivialCommand.__init__):
4101         (MultiCommandToolTest):
4102         (MultiCommandToolTest._assert_tool_main_outputs):
4103         (MultiCommandToolTest.test_retry):
4104         (test_command_help):
4105         * Scripts/webkitpy/tool/steps/__init__.py:
4106         * Scripts/webkitpy/tool/steps/abstractstep.py:
4107         * Scripts/webkitpy/tool/steps/applypatch.py:
4108         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
4109         (ApplyPatchWithLocalCommit):
4110         (ApplyPatchWithLocalCommit.options):
4111         * Scripts/webkitpy/tool/steps/build.py:
4112         * Scripts/webkitpy/tool/steps/checkstyle.py:
4113         (CheckStyle):
4114         (CheckStyle.options):
4115         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4116         * Scripts/webkitpy/tool/steps/closebug.py:
4117         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
4118         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
4119         (CloseBugForLandDiffTest):
4120         (CloseBugForLandDiffTest.test_empty_state):
4121         * Scripts/webkitpy/tool/steps/closepatch.py:
4122         * Scripts/webkitpy/tool/steps/commit.py:
4123         (Commit.run):
4124         * Scripts/webkitpy/tool/steps/confirmdiff.py:
4125         * Scripts/webkitpy/tool/steps/editchangelog.py:
4126         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
4127         * Scripts/webkitpy/tool/steps/metastep.py:
4128         (MetaStep):
4129         (MetaStep.__init__):
4130         (MetaStep.run):
4131         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
4132         * Scripts/webkitpy/tool/steps/options.py:
4133         (Options):
4134         * Scripts/webkitpy/tool/steps/postdiff.py:
4135         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
4136         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
4137         * Scripts/webkitpy/tool/steps/preparechangelog.py:
4138         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
4139         (PrepareChangeLogTest):
4140         (PrepareChangeLogTest.test_resolve_existing_entry):
4141         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4142         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
4143         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
4144         * Scripts/webkitpy/tool/steps/revertrevision.py:
4145         * Scripts/webkitpy/tool/steps/runtests.py:
4146         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4147         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4148         (StepsTest):
4149         (StepsTest._step_options):
4150         * Scripts/webkitpy/tool/steps/update.py:
4151         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
4152         (UpdateChangeLogsWithReviewerTest):
4153         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
4154         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
4155         * Scripts/webkitpy/tool/steps/validatereviewer.py:
4156
4157 2016-06-21  Chris Dumez  <cdumez@apple.com>
4158
4159         Unreviewed, rolling out r202296.
4160
4161         Broke basic browsing in Safari
4162
4163         Reverted changeset:
4164
4165         "WKWebView with no WKNavigationDelegate does not follow
4166         universal links"
4167         https://bugs.webkit.org/show_bug.cgi?id=158997
4168         http://trac.webkit.org/changeset/202296
4169
4170 2016-06-21  Anders Carlsson  <andersca@apple.com>
4171
4172         Fix build.
4173
4174         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4175
4176 2016-06-21  Anders Carlsson  <andersca@apple.com>
4177
4178         Begin moving the Apple Pay code to the open source repository
4179         https://bugs.webkit.org/show_bug.cgi?id=158998
4180
4181         Reviewed by Tim Horton.
4182
4183         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4184         Add ENABLE_APPLE_PAY.
4185
4186 2016-06-21  Said Abou-Hallawa  <sabouhallawa@apple,com>
4187
4188         Add system tracing points for requestAnimationFrame() workflow
4189         https://bugs.webkit.org/show_bug.cgi?id=158723
4190
4191         Reviewed by Simon Fraser.
4192
4193         Add new plist entries to be used by kdebug_trace() viewing tools.
4194
4195         * Tracing/SystemTracePoints.plist:
4196
4197 2016-06-21  Sam Weinig  <sam@webkit.org>
4198
4199         WKWebView with no WKNavigationDelegate does not follow universal links
4200         <rdar://problem/24374110>
4201         https://bugs.webkit.org/show_bug.cgi?id=158997
4202
4203         Reviewed by Dan Bernstein.
4204
4205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4206         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
4207         Add a new test that shows that we have a default navigation delegate by swizzling
4208         -[NSWorkspace openURL:]. This will only be called if there is a default client.
4209
4210 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
4211
4212         run-javascriptcore-tests should have flag to skip mozilla tests
4213         https://bugs.webkit.org/show_bug.cgi?id=158963
4214         rdar://problem/25838924
4215
4216         Reviewed by Alexey Proskuryakov.
4217
4218         * Scripts/run-javascriptcore-tests:
4219         (runJSCStressTests): Added flag to skip mozilla tests.
4220
4221 2016-06-20  Commit Queue  <commit-queue@webkit.org>
4222
4223         Unreviewed, rolling out r202136.
4224         https://bugs.webkit.org/show_bug.cgi?id=158932
4225
4226         JSBench wasn't regressed by r202002 and r202111 on iOS after
4227         all (Requested by rniwa_ on #webkit).
4228
4229         Reverted changeset:
4230
4231         "Unreviewed, rolling out r202002 and r202111."
4232         https://bugs.webkit.org/show_bug.cgi?id=158638
4233         http://trac.webkit.org/changeset/202136
4234
4235 2016-06-20  Keith Rollin  <krollin@apple.com>
4236
4237         Remove RefPtr::release() and change calls sites to use WTFMove()
4238         https://bugs.webkit.org/show_bug.cgi?id=158369
4239
4240         Reviewed by Chris Dumez.
4241
4242         RefPtr::release() releases its managed pointer awkwardly. It's more
4243         direct and clearer to use WTFMove to transfer ownership of the managed
4244         pointer.
4245
4246         As part of this cleanup, also change a lot of explicit data types to
4247         'auto'.
4248
4249         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
4250         (createBitmapContextFromWebView):
4251         (createPagedBitmapContext):
4252         * DumpRenderTree/mac/TestRunnerMac.mm:
4253         (TestRunner::setMockGeolocationPosition):
4254         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
4255         (TestWebKitAPI::TEST):
4256         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4257         (TestWebKitAPI::TEST):
4258
4259 2016-06-20  Tim Horton  <timothy_horton@apple.com>
4260
4261         Add a API test for *DeferringViewInWindowChanges as fixed in r202230
4262         https://bugs.webkit.org/show_bug.cgi?id=158947
4263
4264         Reviewed by Simon Fraser.
4265
4266         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4267         * TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Added.
4268         (TestWebKitAPI::didFinishLoadForFrame):
4269         (TestWebKitAPI::setPageLoaderClient):
4270         (TestWebKitAPI::TEST):
4271         Add a test ensuring that in-window state changes are deferred when using
4272         the SPI for deferring them, as fixed in r202230.
4273
4274 2016-06-20  Fujii Hironori  <Hironori.Fujii@sony.com>
4275
4276         WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE"
4277         https://bugs.webkit.org/show_bug.cgi?id=158931
4278