UIProcess crash when a prewarmed process is terminated
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-01  Chris Dumez  <cdumez@apple.com>
2
3         UIProcess crash when a prewarmed process is terminated
4         https://bugs.webkit.org/show_bug.cgi?id=196451
5         <rdar://problem/49245471>
6
7         Reviewed by Geoffrey Garen.
8
9         Add API test coverage.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
12         (TEST):
13
14 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
15
16         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
17         https://bugs.webkit.org/show_bug.cgi?id=196449
18
19         Reviewed by Lucas Forschler.
20
21         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
22         (StatusBubble.get_os_details): Method to get OS and Xcode details.
23         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
24         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
25
26 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
27
28         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
29         https://bugs.webkit.org/show_bug.cgi?id=196444
30
31         Reviewed by Lucas Forschler.
32
33         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
34
35 2019-04-01  Alex Christensen  <achristensen@webkit.org>
36
37         Add SPI to canonicalize NSURLs with WTF::URL
38         https://bugs.webkit.org/show_bug.cgi?id=196415
39         <rdar://problem/44980271>
40
41         Reviewed by Darin Adler.
42
43         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
44         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
45         (TestWebKitAPI::TEST):
46
47 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
48
49         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
50         https://bugs.webkit.org/show_bug.cgi?id=196441
51
52         Reviewed by Carlos Garcia Campos.
53
54         Don't cache the wpe_view_backend object that might not exist yet at the
55         time of EventSenderProxy constructor invocation, but instead retrieve
56         that object whenever it's required for event dispatching. This should
57         avoid crashes in this constructor now that it's invoked before any
58         PlatformWindow has been set up (as changed in r243496).
59
60         * WebKitTestRunner/EventSenderProxy.h:
61         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
62         (WTR::viewBackend):
63         (WTR::EventSenderProxy::EventSenderProxy):
64         (WTR::EventSenderProxy::mouseDown):
65         (WTR::EventSenderProxy::mouseUp):
66         (WTR::EventSenderProxy::mouseMoveTo):
67         (WTR::EventSenderProxy::mouseScrollBy):
68         (WTR::EventSenderProxy::keyDown):
69         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
70
71 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
72
73         [Win][WebKit] MiniBrowser should support high DPI display
74         https://bugs.webkit.org/show_bug.cgi?id=196391
75
76         Reviewed by Alex Christensen.
77
78         * MiniBrowser/win/WebKitBrowserWindow.cpp:
79         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
80         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
81         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
82
83 2019-03-31  Sam Weinig  <weinig@apple.com>
84
85         Remove more i386 specific configurations
86         https://bugs.webkit.org/show_bug.cgi?id=196430
87
88         Reviewed by Alexey Proskuryakov.
89
90         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
91         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
92
93 2019-03-31  Andy Estes  <aestes@apple.com>
94
95         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
96         https://bugs.webkit.org/show_bug.cgi?id=196433
97         <rdar://problem/49293305>
98
99         Reviewed by Tim Horton.
100
101         Enhanced API test coverage to include all navigation response policy decisions in both
102         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
103
104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
105         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
106         (TestWebKitAPI::TEST):
107         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
108         (readFile):
109         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
110         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
111         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
112         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
113         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
114         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
115         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
116         (-[QuickLookDelegate _downloadDidStart:]):
117         (-[QuickLookDelegate _download:didReceiveResponse:]):
118         (-[QuickLookDelegate _download:didReceiveData:]):
119         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
120         (-[QuickLookDelegate _downloadDidFinish:]):
121         (-[QuickLookDelegate _download:didFailWithError:]):
122         (-[QuickLookDelegate _downloadDidCancel:]):
123         (-[QuickLookDelegate verifyDownload]):
124         (runTest):
125         (runTestDecideBeforeLoading):
126         (runTestDecideAfterLoading):
127         (TEST):
128         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
129         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
130         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
131         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
132         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
133         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
134         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
135         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
136         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
137         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
138         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
139         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
140         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
141         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
142
143 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
144
145         [CMake] add testdfg as target with build-jsc
146         https://bugs.webkit.org/show_bug.cgi?id=196393
147
148         Reviewed by Saam Barati.
149
150         Added testdfg as one of the targets to build when
151         using CMake.
152
153         * Scripts/build-jsc:
154
155 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
156
157         Delete WebMetal implementation in favor of WebGPU
158         https://bugs.webkit.org/show_bug.cgi?id=195418
159
160         Reviewed by Dean Jackson.
161
162         * DumpRenderTree/mac/DumpRenderTree.mm:
163         (enableExperimentalFeatures):
164         (resetWebPreferencesToConsistentValues):
165         * Scripts/webkitperl/FeatureList.pm:
166         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
168         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
169         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
170         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
171         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
172         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
173         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
174         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
175         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
176         (WTR::InjectedBundle::beginTesting):
177         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
178         (WTR::TestRunner::setWebMetalEnabled): Deleted.
179         * WebKitTestRunner/InjectedBundle/TestRunner.h:
180
181 2019-03-29  Chris Dumez  <cdumez@apple.com>
182
183         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
184         https://bugs.webkit.org/show_bug.cgi?id=196405
185         <rdar://problem/49428130>
186
187         Reviewed by Wenson Hsieh.
188
189         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
190         the popover presentation methods to be no-ops. Use this in the new test added in
191         r243523 so that we do not swizzle those methods for all tests. This is needed because
192         those WatchOS tests rely on the popover getting presented and interactive.
193
194         * WebKitTestRunner/TestController.cpp:
195         (WTR::updateTestOptionsFromTestHeader):
196         * WebKitTestRunner/TestController.h:
197         * WebKitTestRunner/TestOptions.h:
198         (WTR::TestOptions::hasSameInitializationOptions const):
199         * WebKitTestRunner/ios/TestControllerIOS.mm:
200         (WTR::TestController::platformInitialize):
201         (WTR::TestController::platformResetStateToConsistentValues):
202
203 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
204
205         [Curl] Add Server Trust Evaluation Support.
206         https://bugs.webkit.org/show_bug.cgi?id=191646
207
208         Reviewed by Fujii Hironori.
209
210         Implemented MiniBrowser UI for asking if user trusts the server.
211
212         * MiniBrowser/win/Common.cpp:
213         (askServerTrustEvaluation):
214         (replaceString):
215         * MiniBrowser/win/Common.h:
216         * MiniBrowser/win/MiniBrowserLib.rc:
217         * MiniBrowser/win/MiniBrowserLibResource.h:
218         * MiniBrowser/win/WebKitBrowserWindow.cpp:
219         (createPEMString):
220         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
221         (WebKitBrowserWindow::canTrustServerCertificate):
222         * MiniBrowser/win/WebKitBrowserWindow.h:
223
224 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
225
226         Implement ResizeObserver.
227         https://bugs.webkit.org/show_bug.cgi?id=157743
228
229         Reviewed by Simon Fraser.
230
231         Support resizeObserverEnabled webPreferences.
232
233         * DumpRenderTree/TestOptions.cpp:
234         (TestOptions::TestOptions):
235         * DumpRenderTree/TestOptions.h:
236         * DumpRenderTree/mac/DumpRenderTree.mm:
237         (setWebPreferencesForTestOptions):
238         * DumpRenderTree/win/DumpRenderTree.cpp:
239         (enableExperimentalFeatures):
240         * Scripts/webkitperl/FeatureList.pm:
241         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
242
243 2019-03-28  John Wilander  <wilander@apple.com>
244
245         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
246         https://bugs.webkit.org/show_bug.cgi?id=196281
247         <rdar://problem/48938748>
248
249         Reviewed by Alex Christensen.
250
251         This patch adds the function isStatisticsHasLocalStorage() to the
252         TestRunner. With it, the page can query the WebsiteDataStore in the
253         UI process to make sure that it sees LocalStorage.
254
255         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
256         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
257         (WTR::TestRunner::isStatisticsHasLocalStorage):
258         * WebKitTestRunner/InjectedBundle/TestRunner.h:
259         * WebKitTestRunner/TestController.cpp:
260         (WTR::TestController::isStatisticsHasLocalStorage):
261         * WebKitTestRunner/TestController.h:
262         * WebKitTestRunner/TestInvocation.cpp:
263         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
264
265 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
266
267         API::Data::createWithoutCopying should do a null check before calling CFRelease
268         https://bugs.webkit.org/show_bug.cgi?id=196276
269         <rdar://problem/48059859>
270
271         Reviewed by Alex Christensen.
272
273         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
274
275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
276         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
277         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
278         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
279         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
280         (TestWebKitAPI::TEST):
281
282 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
283
284         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
285         https://bugs.webkit.org/show_bug.cgi?id=186276
286
287         Reviewed by Carlos Garcia Campos.
288
289         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
290         (webViewLoadChanged):
291         (testWebResourceGetDataError):
292         (testWebResourceGetDataEmpty):
293         (beforeAll):
294         (webViewloadChanged): Deleted.
295
296 2019-03-27  Andy Estes  <aestes@apple.com>
297
298         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
299         https://bugs.webkit.org/show_bug.cgi?id=196317
300
301         Reviewed by Dan Bernstein.
302
303         package-root copies built products into a staging directory using ditto(1), which does not
304         follow symbolic links as it traverses a directory. Now that the files in
305         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
306         itself, these become broken links when ditto'd into the staging directory.
307
308         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
309
310         * Scripts/package-root:
311
312 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
313
314         [ews-app] Update display text of Submit for ews analysis
315         https://bugs.webkit.org/show_bug.cgi?id=196309
316
317         Reviewed by Dewei Zhu.
318
319         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
320
321 2019-03-27  David Kilzer  <ddkilzer@apple.com>
322
323         run-webkit-tests should check for leaks in WebKit processes
324         <https://webkit.org/b/193772>
325         <rdar://problem/46526680>
326
327         Reviewed by Ryosuke Niwa.
328
329         This works by doing the following:
330         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
331           The list of child processes are returned one per line:
332           process.name: pid
333         - Run the "#LIST CHILD PROCESSES" command just before the
334           "#CHECK FOR WORLD LEAKS" command, and store the list of child
335           processes on the ServerProcess object.
336         - When the `--leaks` switch is handled, run check_for_leaks() on
337           each child process after the main test harness.
338
339         * DumpRenderTree/mac/DumpRenderTree.mm:
340         (handleControlCommand):
341         - Use strncmp() instead of strcmp().
342         - Add support for handling "#LIST CHILD PROCESSES" command.
343
344         * Scripts/webkitpy/port/base.py:
345         (Port.check_for_leaks):
346         * Scripts/webkitpy/port/darwin.py:
347         (DarwinPort.check_for_leaks):
348         - Rename redundant 'process_pid' argument to 'process_id'.
349
350         * Scripts/webkitpy/port/driver.py:
351         (Driver.do_post_tests_work):
352         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
353           longer the only command this sends to WebKitTestRunner.
354         - If the `--leaks` switch is present, send the
355           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
356           result using Port.set_webkit_processes().
357         (Driver._parse_child_processes_output):
358         - Add helper method to parse list of child process names and
359           process IDs returned from WebKitTestRunner.
360
361         * Scripts/webkitpy/port/ios_device.py:
362         (IOSDevicePort.check_for_leaks):
363         - Rename redundant 'process_pid' argument to 'process_id'.
364
365         * Scripts/webkitpy/port/leakdetector.py:
366         (LeakDetector._parse_leaks_output):
367         - Return early if there is no leaks_output.
368         (LeakDetector.check_for_leaks):
369         - Rename redundant 'process_pid' argument to 'process_id'.
370
371         * Scripts/webkitpy/port/server_process.py:
372         (ServerProcess.__init__):
373         (ServerProcess.child_processes):
374         (ServerProcess.set_child_processes):
375         - Add instance variable to Port to store list of child process
376           names and process IDs returned from WebKitTestRunner.
377         (ServerProcess._start):
378         - Clear self._child_processes.
379         (ServerProcess.stop):
380         - If self._child_processes is set, call
381           self._port.check_for_leaks() for each child process.
382
383         * Scripts/webkitpy/port/server_process_unittest.py:
384         (TrivialMockPort.check_for_leaks):
385         - Rename redundant 'process_pid' argument to 'process_id'.
386
387         * Scripts/webkitpy/port/simulator_process.py:
388         (SimulatorProcess.stop):
389         - If self._child_processes is set, call
390           self._port.check_for_leaks() for each child process.
391
392         * Scripts/webkitpy/port/watch_device.py:
393         (WatchDevicePort.check_for_leaks):
394         - Rename redundant 'process_pid' argument to 'process_id'.
395
396         * WebKitTestRunner/TestController.cpp:
397         (WTR::TestController::dumpResponse):
398         - Extract method from findAndDumpWorldLeaks() so that it may be
399           reused by findAndDumpWebKitProcessIdentifiers().
400         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
401         - Add method to output process name and process ID of both the
402           WebContent and Networking processes.
403         (WTR::TestController::findAndDumpWorldLeaks):
404         - Fix missing newline in output when there were no abandoned
405           documents.
406         - Call dumpResponse() for extracted code.
407         (WTR::TestController::handleControlCommand):
408         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
409         - Use strncmp() instead of strcmp().
410         - Call findAndDumpWebKitProcessIdentifiers() when
411           "#LIST CHILD PROCESSES" command is sent.
412         * WebKitTestRunner/TestController.h:
413         (WTR::TestController::dumpResponse):
414         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
415         - Declare methods.
416
417 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
418
419         Unreviewed. Add GLib API test cases after r243434.
420
421         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
422         (testWebViewActiveURI):
423         (serverCallback):
424         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
425         (sendRequestCallback):
426
427 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
428
429         Geolocation request not complete when watch request was started in a different web process
430         https://bugs.webkit.org/show_bug.cgi?id=195996
431
432         Reviewed by Alex Christensen.
433
434         Add a test case.
435
436         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
437         (TestWebKitAPI::runJavaScriptAlert):
438         (TestWebKitAPI::TEST):
439
440 2019-03-26  Keith Rollin  <krollin@apple.com>
441
442         Update the way generate-xcfilelists returns strings from functions
443         https://bugs.webkit.org/show_bug.cgi?id=195975
444         <rdar://problem/49040807>
445
446         Reviewed by Dean Jackson.
447
448         There are places where generate-xcfilelists executes assignments with
449         statements like:
450
451             FOO=$(some_function)
452
453         where "some_function" return a string by echoing it. E.g.
454
455             some_function()
456             {
457                 echo "Hello, World"
458             }
459
460         This is a common idiom, but it has a problem if "some_function" needs
461         to call "exit" in an attempt to halt the entire script right then and
462         there. Since "some_function" is called inside of $(), it's being
463         executed in a sub-shell. Calling exit in that sub-shell simply exits
464         that shell; it doesn't not exit the outer shell in which the main part
465         of the script is still running. As such, the main script keeps
466         executing when the intent was for the script to halt.
467
468         The solution to this is to use a different idiom for returning
469         strings. The one we now is to pass in the name of the variable to
470         receive the string result:
471
472             some_function()
473             {
474                 variable_name=$1
475                 eval $variable_name ="Hello, World"
476             }
477
478         The call site now looks like
479
480             some_function FOO
481
482         Because there's no invocation of a sub-shell, some_function can now
483         call "exit" if it wants to, and the entire script will exit at that
484         point.
485
486         * Scripts/generate-xcfilelists:
487
488 2019-03-26  Chris Dumez  <cdumez@apple.com>
489
490         Add basic layout test coverage for File Picker on iOS
491         https://bugs.webkit.org/show_bug.cgi?id=196265
492
493         Reviewed by Wenson Hsieh.
494
495         Add layout test infrastructure to test the file picker on iOS.
496
497         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
498         (WTR::UIScriptController::dismissFilePicker):
499         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
500         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
501         (WTR::UIScriptController::dismissFilePicker):
502         * TestRunnerShared/UIScriptContext/UIScriptController.h:
503         * WebKitTestRunner/TestController.cpp:
504         (WTR::TestController::createWebViewWithOptions):
505         (WTR::updateTestOptionsFromTestHeader):
506         * WebKitTestRunner/TestOptions.h:
507         (WTR::TestOptions::hasSameInitializationOptions const):
508         * WebKitTestRunner/ios/TestControllerIOS.mm:
509         (overridePresentViewController):
510         (WTR::TestController::platformInitialize):
511         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
512         (WTR::UIScriptController::dismissFilePicker):
513
514 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
515
516         Implement async paste method on UIWKInteractionViewProtocol
517         https://bugs.webkit.org/show_bug.cgi?id=196267
518         <rdar://problem/49236346>
519
520         Reviewed by Tim Horton.
521
522         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
523         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
524         are now a part of all iOS 12 internal SDKs.
525
526         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
527
528         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
529         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
530
531         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
532         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
533         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
534         * TestWebKitAPI/ios/UIKitSPI.h:
535
536 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
537
538         [ews-build] Use PostgreSQL for ews.webkit.org database
539         https://bugs.webkit.org/show_bug.cgi?id=196270
540
541         Reviewed by Lucas Forschler.
542
543         * BuildSlaveSupport/ews-app/ews-app/settings.py:
544
545 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
546
547         [ews] Reset simctl states on reboot
548         https://bugs.webkit.org/show_bug.cgi?id=196260
549
550         Rubber-stamped by Aakash Jain.
551
552         * EWSTools/start-queue-mac.sh:
553
554 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
555
556         [ews-build] Use PostgreSQL for ews-build database
557         https://bugs.webkit.org/show_bug.cgi?id=196229
558
559         Reviewed by Lucas Forschler.
560
561         * BuildSlaveSupport/ews-build/master.cfg:
562
563 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
564
565         [ews-build] Get master_hostname dynamically in master.cfg
566         https://bugs.webkit.org/show_bug.cgi?id=196255
567
568         Reviewed by Lucas Forschler.
569
570         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
571         send events data in test mode.
572
573 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
574
575         [ews-app] Set db_constraint to False for Foreign Keys
576         https://bugs.webkit.org/show_bug.cgi?id=196252
577
578         Reviewed by Lucas Forschler.
579
580         * BuildSlaveSupport/ews-app/ews/models/build.py:
581         * BuildSlaveSupport/ews-app/ews/models/step.py:
582
583 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
584
585         [ews-build] is_test_mode_enabled should default to True
586         https://bugs.webkit.org/show_bug.cgi?id=196248
587
588         Reviewed by Lucas Forschler.
589
590         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
591
592 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
593
594         [ews-app] Add webkitperl to ENABLED_QUEUES
595         https://bugs.webkit.org/show_bug.cgi?id=196253
596
597         Reviewed by Lucas Forschler.
598
599         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
600
601 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
602
603         Address NSWindow sometimes using WebKitTestRunnerEvent too early
604         https://bugs.webkit.org/show_bug.cgi?id=196211
605         rdar://problem/49110552
606
607         Reviewed by Tim Horton.
608
609         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
610         Make sure that EventSenderProxy always exists when running tests. We used to create
611         it when resetting before the first test, which is a bit too late.
612
613         * WebKitTestRunner/TestController.h:
614         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
615         (WTR::TestController::platformCreateWebView):
616         (WTR::TestController::platformCreateOtherPage):
617         (WTR::TestController::finishCreatingPlatformWebView):
618         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
619         (WTR::PlatformWebView::PlatformWebView):
620         Moved some code that made NSWindow use NSEvent during web view creation. We may
621         need to move more if some other case us found, but this is enough for now.
622
623 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
624
625         Unreviewed. Fix typo in GLib geolocation API after r243285.
626
627         gelocation -> geolocation.
628
629         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
630         (testGeolocationManagerWatchPosition):
631
632 2019-03-25  Alex Christensen  <achristensen@webkit.org>
633
634         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
635         https://bugs.webkit.org/show_bug.cgi?id=196213
636
637         Reviewed by Geoff Garen.
638
639         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
640         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
641         (credentialWithIdentityAndKeychainPath):
642         (-[ChallengeDelegate webView:didFinishNavigation:]):
643         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
644         (TestWebKitAPI::TEST):
645
646 2019-03-25  Alex Christensen  <achristensen@webkit.org>
647
648         Expected shouldn't assume its contained types are copyable
649         https://bugs.webkit.org/show_bug.cgi?id=195986
650
651         Reviewed by JF Bastien.
652
653         * TestWebKitAPI/Tests/WTF/Expected.cpp:
654         (TestWebKitAPI::NonCopyable::operator== const):
655         (TestWebKitAPI::NonCopyable::operator!= const):
656         (TestWebKitAPI::TEST):
657
658 2019-03-25  Tim Horton  <timothy_horton@apple.com>
659
660         Remove some now-unnecessary dynamic class lookup
661         https://bugs.webkit.org/show_bug.cgi?id=196237
662
663         Reviewed by Simon Fraser.
664
665         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
666         (makeRequest):
667         (TEST):
668
669 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
670
671         Unreviewed, rolling out r243450.
672
673         AppleWin and WinCairo port builds get broken.
674
675         Reverted changeset:
676
677         "Add test for fix of #196095"
678         https://bugs.webkit.org/show_bug.cgi?id=196097
679         https://trac.webkit.org/changeset/243450
680
681 2019-03-25  Commit Queue  <commit-queue@webkit.org>
682
683         Unreviewed, rolling out r243465.
684         https://bugs.webkit.org/show_bug.cgi?id=196226
685
686         the test doesn't build (Requested by thorton on #webkit).
687
688         Reverted changeset:
689
690         "Do not terminate the NetworkProcess if a third party
691         application sends a NSCredential with a SecIdentityRef"
692         https://bugs.webkit.org/show_bug.cgi?id=196213
693         https://trac.webkit.org/changeset/243465
694
695 2019-03-25  Alex Christensen  <achristensen@webkit.org>
696
697         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
698         https://bugs.webkit.org/show_bug.cgi?id=196213
699
700         Reviewed by Geoff Garen.
701
702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
703         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
704         (credentialWithIdentityAndKeychainPath):
705         (-[ChallengeDelegate webView:didFinishNavigation:]):
706         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
707         (TestWebKitAPI::TEST):
708
709 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
710
711         [ews-build] Gracefully handle missing patch_id in events
712         https://bugs.webkit.org/show_bug.cgi?id=196216
713
714         Reviewed by Lucas Forschler.
715
716         * BuildSlaveSupport/ews-build/events.py:
717
718 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
719
720         [ews-build] use lz4 compression for improving buildbot performance
721         https://bugs.webkit.org/show_bug.cgi?id=196155
722
723         Reviewed by Lucas Forschler.
724
725         * BuildSlaveSupport/ews-build/master.cfg:
726
727 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
728
729         Pull some API testing helper methods out of TestWKWebView
730         https://bugs.webkit.org/show_bug.cgi?id=196212
731
732         Reviewed by Tim Horton.
733
734         Refactor some more API testing utility methods, so that they can be used in
735         tests that do not use TestWKWebView.
736
737         * TestWebKitAPI/cocoa/TestWKWebView.h:
738         * TestWebKitAPI/cocoa/TestWKWebView.mm:
739         (-[WKWebView loadTestPageNamed:]):
740         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
741         (-[WKWebView synchronouslyLoadHTMLString:]):
742         (-[WKWebView synchronouslyLoadTestPageNamed:]):
743         (-[TestWKWebView loadTestPageNamed:]): Deleted.
744         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
745         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
746         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
747
748 2019-03-25  Jer Noble  <jer.noble@apple.com>
749
750         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
751         https://bugs.webkit.org/show_bug.cgi?id=196097
752
753         Reviewed by Eric Carlson.
754
755         Drive-by bug fix: allow tests to play audio without a user gesture by default.
756
757         * DumpRenderTree/mac/DumpRenderTree.mm:
758         (resetWebPreferencesToConsistentValues):
759         * WebKitTestRunner/TestController.cpp:
760         (WTR::TestController::resetPreferencesToConsistentValues):
761
762 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
763
764         Pull IPadUserInterfaceSwizzler out into a separate header file
765         https://bugs.webkit.org/show_bug.cgi?id=196193
766
767         Reviewed by Anders Carlsson.
768
769         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
770         be used in other API tests.
771
772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
773         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
774         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
775         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
776         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
777         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
778         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
779
780 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
781
782         Remove NavigatorContentUtils in WebCore/Modules
783         https://bugs.webkit.org/show_bug.cgi?id=196070
784
785         Reviewed by Alex Christensen.
786
787         NavigatorContentUtils was to support the custom scheme spec [1].
788         However, in WebKit side, no port has supported the feature in
789         WebKit layer after EFL port was removed. So there has been the
790         only IDL implementation of the NavigatorContentUtils in WebCore.
791         So we don't need to keep the implementation in WebCore anymore.
792
793         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
794
795         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
796
797 2019-03-24  Andy Estes  <aestes@apple.com>
798
799         [watchOS] Remove unused Proximity Networking code
800         https://bugs.webkit.org/show_bug.cgi?id=196188
801
802         Reviewed by Tim Horton.
803
804         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
805         (TEST):
806
807 2019-03-23  Keith Miller  <keith_miller@apple.com>
808
809         Refactor clz/ctz and fix getLSBSet.
810         https://bugs.webkit.org/show_bug.cgi?id=196162
811
812         Reviewed by Saam Barati.
813
814         Add tests for clz, ctz, getLSBSet, and getMSBSet.
815
816         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
817         (TestWebKitAPI::TEST):
818
819 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
820
821         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
822         https://bugs.webkit.org/show_bug.cgi?id=196143
823
824         Reviewed by Michael Catanzaro.
825
826         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
827         directories.
828
829         * Scripts/webkitpy/style/checkers/cpp.py:
830         (check_identifier_name_in_declaration):
831         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
832         (WebKitStyleTest.test_names):
833
834 2019-03-22  Philippe Normand  <pnormand@igalia.com>
835
836         [Flatpak] Manifest expanding fails for qt WPE extension
837         https://bugs.webkit.org/show_bug.cgi?id=196148
838
839         Reviewed by Alex Christensen.
840
841         * flatpak/flatpakutils.py:
842         (expand_submodules_recurse): The last recurse manifest expand
843         iteration might lead to a single module so take it into account
844         and don't try to recurse further.
845
846 2019-03-22  Chris Dumez  <cdumez@apple.com>
847
848         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
849         https://bugs.webkit.org/show_bug.cgi?id=195348
850         <rdar://problem/48622090>
851
852         Reviewed by Alex Christensen.
853
854         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
855         to NO when test.options().shouldIgnoreMetaViewport is false.
856
857         * WebKitTestRunner/ios/TestControllerIOS.mm:
858         (WTR::TestController::platformConfigureViewForTest):
859
860 2019-03-22  Chris Dumez  <cdumez@apple.com>
861
862         Prewarmed processes should be usable with any website data store
863         https://bugs.webkit.org/show_bug.cgi?id=196104
864
865         Reviewed by Alex Christensen.
866
867         Add API test coverage.
868
869         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
870         (runInitialWarmedProcessUsedTest):
871         (TEST):
872
873 2019-03-22  David Kilzer  <ddkilzer@apple.com>
874
875         Back out local changes to Alex's Subversion working directory
876
877         They were accidentally committed.
878
879         * Scripts/webkitpy/common/system/abstractexecutive.py:
880         (AbstractExecutive.wait_newest):
881         * Scripts/webkitpy/common/system/executive.py:
882         (Executive.running_pids):
883         * Scripts/webkitpy/common/system/executive_mock.py:
884         (MockExecutive.running_pids):
885         * Scripts/webkitpy/common/system/executive_unittest.py:
886         (ExecutiveTest.serial_test_running_pids):
887         * Scripts/webkitpy/port/darwin.py:
888         (DarwinPort.check_for_leaks):
889         * Scripts/webkitpy/port/leakdetector.py:
890         (LeakDetector.check_for_leaks):
891         - This was the hack attached to Bug 193772.
892
893         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
894         (+[WebKitTestRunnerEvent mouseLocation]):
895         - This works around a crash on an internal build.
896
897 2019-03-22  Tim Horton  <timothy_horton@apple.com>
898
899         Fix the build after r243354
900         https://bugs.webkit.org/show_bug.cgi?id=196138
901         <rdar://problem/49145951>
902
903         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
904         (TEST):
905         * TestWebKitAPI/ios/UIKitSPI.h:
906
907 2019-03-21  Tim Horton  <timothy_horton@apple.com>
908
909         Adopt UIWKDocumentContext
910         https://bugs.webkit.org/show_bug.cgi?id=196040
911         <rdar://problem/48642440>
912
913         Reviewed by Ryosuke Niwa.
914
915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
916         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
917         (makeRequest):
918         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
919         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
920         (applyStyle):
921         (TEST):
922         Add tests for UIWKDocumentContext.
923
924         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
925         (TEST):
926         (recursiveFindWKContentView): Deleted.
927         * TestWebKitAPI/cocoa/TestWKWebView.h:
928         * TestWebKitAPI/cocoa/TestWKWebView.mm:
929         (recursiveFindWKContentView):
930         (-[TestWKWebView wkContentView]):
931         * TestWebKitAPI/ios/UIKitSPI.h:
932         Share the WKContentView finding code between tests.
933
934 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
935
936         [iOS WK2] Turn on async overflow scrolling by default
937         https://bugs.webkit.org/show_bug.cgi?id=196011
938         rdar://problem/48453859
939
940         Reviewed by Antti Koivisto.
941         
942         Explicitly turn off the async overflow scrolling internal feature for tests by default,
943         since so many basic layout tests have different results when compositing is triggered for
944         overflow.
945         
946         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
947
948         * WebKitTestRunner/TestController.cpp:
949         (WTR::TestController::resetPreferencesToConsistentValues):
950
951 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
952
953         [ews-build] Retry API test in case of failures
954         https://bugs.webkit.org/show_bug.cgi?id=196004
955
956         Reviewed by Lucas Forschler.
957
958         * BuildSlaveSupport/ews-build/steps.py:
959         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
960         (CompileWebKitToT.doStepIf): Ditto.
961         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
962         (ReRunAPITests): Re-run API tests.
963         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
964         (RunAPITestsWithoutPatch): Run API tests without patch.
965         (RunAPITestsWithoutPatch.doStepIf):
966         (RunAPITestsWithoutPatch.hideStepIf):
967         (RunAPITestsWithoutPatch.evaluateCommand):
968         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
969         (AnalyzeAPITestsResults.start):
970         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
971         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
972         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
973         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
974
975 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
976
977         [ews-build] Update queues configurations
978         https://bugs.webkit.org/show_bug.cgi?id=196074
979
980         Reviewed by Dewei Zhu.
981
982         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
983         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
984
985 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
986
987         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
988         https://bugs.webkit.org/show_bug.cgi?id=195680
989         <rdar://problem/48903534>
990
991         Unreviewed infrastructure fix.
992
993         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
994         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
995
996 2019-03-21  Andy Estes  <aestes@apple.com>
997
998         [iOS] Apple Pay should be available in documents with no user agent scripts
999         https://bugs.webkit.org/show_bug.cgi?id=196061
1000         <rdar://problem/48649391>
1001
1002         Reviewed by Brady Eidson.
1003
1004         Added API tests and related infrastructure.
1005
1006         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1007         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1008         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1009         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1010         (TestWebKitAPI::TEST):
1011         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1012         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1013         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1014         * TestWebKitAPI/cocoa/TestProtocol.mm:
1015         (-[TestProtocol startLoading]):
1016         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1017         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1018         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1019         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1020
1021 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1022
1023         REGRESSSION (r243297): webkitpy tests broken
1024         https://bugs.webkit.org/show_bug.cgi?id=196108
1025
1026         Reviewed by Aakash Jain.
1027
1028         r243297 updated contributors.json, which broke a few unit tests.
1029
1030         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1031         (IRCCommandTest.test_whois):
1032         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1033
1034 2019-03-21  Chris Dumez  <cdumez@apple.com>
1035
1036         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1037         https://bugs.webkit.org/show_bug.cgi?id=196041
1038         <rdar://problem/49083230>
1039
1040         Reviewed by Alex Christensen.
1041
1042         Add API test coverage.
1043
1044         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1045         (TEST):
1046
1047 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1048
1049         Add SPI to inform applications of WKContentRuleList actions
1050         https://bugs.webkit.org/show_bug.cgi?id=195965
1051         <rdar://problem/42664365>
1052
1053         Reviewed by Geoff Garen.
1054
1055         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1056         (TestWebKitAPI::allActionsForResourceLoad):
1057         (TestWebKitAPI::testRequest):
1058         (TestWebKitAPI::TEST_F):
1059         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1060         (Notification::description):
1061         (Notification::operator== const):
1062         (toVector):
1063         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1064         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1065         (makeContentRuleList):
1066         (TEST):
1067         (makeWarnContentRuleList): Deleted.
1068
1069 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1070
1071         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1072         https://bugs.webkit.org/show_bug.cgi?id=196088
1073
1074         Reviewed by Brian Burg.
1075
1076         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1077         Support checks when only one platform is specified. Also deprecate macosx() and
1078         force the use of macos() instead.
1079
1080         * Scripts/webkitpy/style/checkers/cpp.py:
1081         (check_min_versions_of_wk_api_available):
1082         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1083         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1084
1085 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1086
1087         Update status inactive committers' status to 'contributor'.
1088
1089         * Scripts/webkitpy/common/config/contributors.json:
1090
1091 2019-03-21  Xan Lopez  <xan@igalia.com>
1092
1093         [JSC][x86] Drop support for x87 floating point
1094         https://bugs.webkit.org/show_bug.cgi?id=194853
1095
1096         Reviewed by Don Olmstead.
1097
1098         Force SSE2 on x86/32bit builds.
1099
1100         * Scripts/webkitdirs.pm:
1101         (generateBuildSystemFromCMakeProject):
1102
1103 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1104
1105         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1106         https://bugs.webkit.org/show_bug.cgi?id=196073
1107
1108         Reviewed by Michael Catanzaro.
1109
1110         Add test cases to check functions and constructors with no arguments but receiving user data.
1111
1112         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1113         (checkUserData):
1114         (testJSCFunction):
1115         (fooCreateWithUserData):
1116         (testJSCClass):
1117
1118 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1119
1120         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1121
1122         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1123
1124         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1125
1126 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1127
1128         [GTK][WPE] Add API to provide geolocation information
1129         https://bugs.webkit.org/show_bug.cgi?id=195940
1130
1131         Reviewed by Michael Catanzaro.
1132
1133         Add a new test to check the new API.
1134
1135         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1136         (testGeolocationManagerCurrentPosition):
1137         (testGeolocationManagerWatchPosition):
1138         (beforeAll):
1139         (afterAll):
1140         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1141         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1142         (beforeAll): Ditto.
1143         * TestWebKitAPI/glib/CMakeLists.txt:
1144
1145 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1146
1147         [GLib] Returning G_TYPE_OBJECT from a method does not work
1148         https://bugs.webkit.org/show_bug.cgi?id=195574
1149
1150         Reviewed by Michael Catanzaro.
1151
1152         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1153
1154         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1155         (getGFile):
1156         (getParent):
1157         (createGString):
1158         (getGString):
1159         (getGStringCopyWillRaise):
1160         (getGStringCopy):
1161         (getGStringStr):
1162         (getGStringLen):
1163         (freeGString):
1164         (testJSCClass):
1165
1166 2019-03-20  Saam Barati  <sbarati@apple.com>
1167
1168         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1169         https://bugs.webkit.org/show_bug.cgi?id=195721
1170
1171         Reviewed by Filip Pizlo.
1172
1173         * Scripts/run-javascriptcore-tests:
1174
1175 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1176
1177         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1178         https://bugs.webkit.org/show_bug.cgi?id=196049
1179
1180         Reviewed by Tim Horton.
1181
1182         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1183         overflow scrolling in general, so rename it.
1184
1185         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1186
1187 2019-03-20  Daniel Bates  <dabates@apple.com>
1188
1189         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1190         https://bugs.webkit.org/show_bug.cgi?id=196031
1191         <rdar://problem/49078172>
1192
1193         Reviewed by Tim Horton.
1194
1195         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1196         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1197         same code path used when the Done button is pressed to dismiss the <select> picker.
1198
1199         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1200         (TestWebKitAPI::TEST):
1201
1202 2019-03-20  Chris Dumez  <cdumez@apple.com>
1203
1204         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1205         https://bugs.webkit.org/show_bug.cgi?id=196029
1206         <rdar://problem/48954651>
1207
1208         Reviewed by Tim Horton.
1209
1210         Add API test coverage.
1211
1212         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1213
1214 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1215
1216         [ews-build] Improve failure summary string for ApplyPatch step
1217         https://bugs.webkit.org/show_bug.cgi?id=195995
1218
1219         Reviewed by Alexey Proskuryakov.
1220
1221         * BuildSlaveSupport/ews-build/steps.py:
1222         (ApplyPatch.getResultSummary): Override getResultSummary.
1223
1224 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1225
1226         AX: Implement support for new meter ARIA role
1227         https://bugs.webkit.org/show_bug.cgi?id=195966
1228
1229         Reviewed by Chris Fleizach.
1230
1231         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1232         to AXLevelIndicator.
1233
1234         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1235
1236 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1237
1238         [WebAuthN] Implement FIDO AppID extension
1239         https://bugs.webkit.org/show_bug.cgi?id=143491
1240         <rdar://problem/48298273>
1241
1242         Reviewed by Brent Fulgham.
1243
1244         Add a test that covers the new flag of convertToU2fSignCommand.
1245
1246         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1247         (TestWebKitAPI::TEST):
1248         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1249         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1250         (TestWebKitAPI::TEST):
1251
1252 2019-03-19  Keith Rollin  <krollin@apple.com>
1253
1254         Add support for more platforms to generate-xcfilelists
1255         https://bugs.webkit.org/show_bug.cgi?id=195977
1256
1257         Reviewed by Alexey Proskuryakov.
1258
1259         generate-xcfilelists incorrectly complains when involved with building
1260         WebKit for iphonesimulator:
1261
1262             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1263             …
1264             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1265
1266         Address this by teaching generate-xcfilelists about more platforms.
1267
1268         * Scripts/generate-xcfilelists:
1269
1270 2019-03-19  John Wilander  <wilander@apple.com>
1271
1272         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1273         https://bugs.webkit.org/show_bug.cgi?id=195923
1274         <rdar://problem/49001272>
1275
1276         Reviewed by Alex Christensen.
1277
1278         This patch does the following to the TestRunner:
1279         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1280         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1281         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1282
1283         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1284         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1285         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1286         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1287         * WebKitTestRunner/TestController.cpp:
1288         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1289         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1290         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1291         * WebKitTestRunner/TestController.h:
1292         * WebKitTestRunner/TestInvocation.cpp:
1293         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1294
1295 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1296
1297         [CMake] Support more clang and gcc sanitizers
1298         https://bugs.webkit.org/show_bug.cgi?id=195956
1299
1300         Reviewed by Michael Catanzaro.
1301
1302         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1303
1304 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1305
1306         [ews-build] Improve summary for PrintConfiguration step
1307         https://bugs.webkit.org/show_bug.cgi?id=195945
1308
1309         Reviewed by Lucas Forschler.
1310
1311         * BuildSlaveSupport/ews-build/steps.py:
1312         (PrintConfiguration.getResultSummary): Override getResultSummary.
1313
1314 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1315
1316         [ews-build] Improve summary for CheckOutSource step
1317         https://bugs.webkit.org/show_bug.cgi?id=195963
1318
1319         Reviewed by Lucas Forschler.
1320
1321         * BuildSlaveSupport/ews-build/steps.py:
1322         (CheckOutSource.getResultSummary):
1323
1324 2019-03-19  Daniel Bates  <dabates@apple.com>
1325
1326         [iOS] Focus not preserved when switching between tabs
1327         https://bugs.webkit.org/show_bug.cgi?id=195820
1328         <rdar://problem/43614450>
1329
1330         Reviewed by Brent Fulgham.
1331
1332         Add tests to ensure that we restore focus when resigning and becoming first responder.
1333
1334         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1335         (TestWebKitAPI::TEST):
1336
1337 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1338
1339         Make WTFLogChannelState and WTFLogLevel enum classes
1340         https://bugs.webkit.org/show_bug.cgi?id=195904
1341
1342         Reviewed by Eric Carlson.
1343
1344         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1345         (TestWebKitAPI::TEST_F):
1346
1347 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1348
1349         [GStreamer][EME] Backported mssdemux protection data crash fix
1350         https://bugs.webkit.org/show_bug.cgi?id=195918
1351
1352         Reviewed by Philippe Normand.
1353
1354         * gstreamer/jhbuild.modules:
1355         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1356
1357 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1358
1359         Unreviewed, rolling out r243132.
1360
1361         Broke GTK build
1362
1363         Reverted changeset:
1364
1365         "Make WTFLogChannelState and WTFLogLevel enum classes"
1366         https://bugs.webkit.org/show_bug.cgi?id=195904
1367         https://trac.webkit.org/changeset/243132
1368
1369 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1370
1371         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1372
1373         * Scripts/webkitdirs.pm:
1374         (builtDylibPathForName): Adjust the shared library name that's changed
1375         with the API version bump in r243073.
1376
1377 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1378
1379         Make WTFLogChannelState and WTFLogLevel enum classes
1380         https://bugs.webkit.org/show_bug.cgi?id=195904
1381
1382         Reviewed by Eric Carlson.
1383
1384         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1385         (TestWebKitAPI::TEST_F):
1386
1387 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1388
1389         Disable flaky test added in r2431100
1390         https://webkit.org/b/195785
1391
1392         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1393         (TestWebKitAPI::TEST):
1394         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1395
1396 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1397
1398         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1399         https://bugs.webkit.org/show_bug.cgi?id=195916
1400
1401         Reviewed by Tim Horton.
1402
1403         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1404         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1405
1406 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1407
1408         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1409
1410         * Scripts/webkitpy/common/config/contributors.json:
1411
1412 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1413
1414         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1415         https://bugs.webkit.org/show_bug.cgi?id=195785
1416
1417         Reviewed by Geoffrey Garen.
1418
1419         * TestWebKitAPI/TCPServer.cpp: Added.
1420         (TestWebKitAPI::TCPServer::TCPServer):
1421         (TestWebKitAPI::TCPServer::~TCPServer):
1422         (TestWebKitAPI::TCPServer::socketBindListen):
1423         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1424         * TestWebKitAPI/TCPServer.h: Added.
1425         (TestWebKitAPI::TCPServer::port const):
1426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1427         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1428         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1429         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1430         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1431         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1432         (TestWebKitAPI::respondSlowly):
1433         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1434         (TestWebKitAPI::downloadAtRate):
1435         (TestWebKitAPI::TEST):
1436
1437 2019-03-18  Saam Barati  <sbarati@apple.com>
1438
1439         Add a plan file for JetStream 2
1440         https://bugs.webkit.org/show_bug.cgi?id=190734
1441
1442         Reviewed by Mark Lam.
1443
1444         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1445
1446 2019-03-18  Chris Dumez  <cdumez@apple.com>
1447
1448         Delay WebProcess launch until a load is triggered in a Web view
1449         https://bugs.webkit.org/show_bug.cgi?id=195758
1450         <rdar://problem/48126013>
1451
1452         Reviewed by Geoff Garen.
1453
1454         Add API test coverage. Also update some existing API tests to not expect
1455         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1456
1457         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1458         (TestWebKitAPI::TEST):
1459         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1460         (TestWebKitAPI::TEST):
1461         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1462         (TEST):
1463         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1464         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1465         (TEST):
1466         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1467         (TEST):
1468         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1469
1470 2019-03-18  Xan Lopez  <xan@igalia.com>
1471
1472         [CMake] Prevent potential warning when determining $architecture
1473         https://bugs.webkit.org/show_bug.cgi?id=195891
1474
1475         Reviewed by Michael Catanzaro.
1476
1477         It's possible for generateBuildSystemForCMakeProject to be called
1478         before determineArchitecture() is ever called. This will make the
1479         first eq check with $architecture to be bogus (and print a
1480         warning). Change that to an eq check with architecture(), which
1481         implicitly calls determineArchitecture() if needed, and change all
1482         the other similar cases in the method in the same way to prevent
1483         future bugs like this one.
1484
1485         * Scripts/webkitdirs.pm:
1486         (generateBuildSystemFromCMakeProject):
1487
1488 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1489
1490         [WPE] Tarballs generated with “make dist” cannot build documentation
1491         https://bugs.webkit.org/show_bug.cgi?id=195885
1492
1493         Reviewed by Carlos Garcia Campos.
1494
1495         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1496
1497 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1498
1499         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1500         https://bugs.webkit.org/show_bug.cgi?id=195883
1501
1502         Reviewed by Carlos Garcia Campos.
1503
1504         * gtkdoc/gtkdoc.py:
1505         (GTKDoc._run_command): When commands fail to run, include the full command line for
1506         the program invocation and the output it has generated on the standard error stream.
1507
1508 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1509
1510         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1511         https://bugs.webkit.org/show_bug.cgi?id=195786
1512
1513         Reviewed by Philippe Normand.
1514
1515         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1516         * wpe/jhbuild.modules: Ditto.
1517
1518 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1519
1520         [ews-build] Don't run clean builds on EWS builders
1521         https://bugs.webkit.org/show_bug.cgi?id=195851
1522
1523         Reviewed by Geoffrey Garen.
1524
1525         * BuildSlaveSupport/ews-build/factories.py:
1526
1527 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1528
1529         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1530         https://bugs.webkit.org/show_bug.cgi?id=195849
1531
1532         Reviewed by Chris Dumez.
1533
1534         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1535
1536         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1537         (runWebsiteDataStoreCustomPaths):
1538
1539 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1540
1541         webkitpy: Upload test results
1542         https://bugs.webkit.org/show_bug.cgi?id=195755
1543         <rdar://problem/48896182>
1544
1545         Reviewed by Aakash Jain.
1546
1547         Establish a new format for uploading results that is not tied to layout tests, apply
1548         that format to webkitpy tests.
1549
1550         * Scripts/webkitpy/common/checkout/scm/git.py:
1551         (Git.native_branch): Return what branch the current checkout is on.
1552         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1553         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1554         * Scripts/webkitpy/common/checkout/scm/svn.py:
1555         (SVN.native_branch): Ditto.
1556         * Scripts/webkitpy/common/system/platforminfo.py:
1557         (PlatformInfo.build_version): Return a build version for Mac.
1558         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1559         (MockPlatformInfo.__init__):
1560         (MockPlatformInfo.build_version):
1561         * Scripts/webkitpy/results: Added.
1562         * Scripts/webkitpy/results/__init__.py: Added.
1563         * Scripts/webkitpy/results/options.py: Added.
1564         (upload_options): OptParse list for upload options.
1565         * Scripts/webkitpy/results/upload.py: Added.
1566         (Upload): Class which enforces the upload format expected by the results server.
1567         (Upload.Expectations):
1568         (Upload.create_configuration):
1569         (Upload.create_commit):
1570         (Upload.create_details):
1571         (Upload.create_run_stats):
1572         (Upload.create_test_result):
1573         (Upload.__init__):
1574         (Upload.Encoder): Encode Upload object as json.
1575         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1576         * Scripts/webkitpy/results/upload_unittest.py: Added.
1577         * Scripts/webkitpy/test/main.py:
1578         (Tester._parse_args): Add upload arguments.
1579         (Tester._run_tests): Allow results to be uploaded.
1580         * Scripts/webkitpy/test/runner.py:
1581         (Runner.__init__): Record which tests were run, rather than just counting them.
1582         (Runner.handle):
1583         * Scripts/webkitpy/test/runner_unittest.py:
1584         (RunnerTest.test_run):
1585         * Scripts/webkitpy/thirdparty/__init__.py:
1586         (AutoinstallImportHook.find_module): Add requests auto-install.
1587         (AutoinstallImportHook._install_requests):
1588         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1589         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1590
1591 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1592
1593         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1594         https://bugs.webkit.org/show_bug.cgi?id=195810
1595
1596         Reviewed by Tim Horton.
1597
1598         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1599         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1600         ending certain layout tests.
1601
1602         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1603         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1604         (-[TestRunnerWKWebView dealloc]):
1605         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1606
1607         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1608         helper method when destroying the web view, and when resetting state between tests.
1609
1610         * WebKitTestRunner/ios/TestControllerIOS.mm:
1611         (WTR::TestController::platformResetStateToConsistentValues):
1612
1613         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1614
1615 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1616
1617         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1618         https://bugs.webkit.org/show_bug.cgi?id=190350
1619         <rdar://problem/45089503>
1620
1621         Reviewed by Geoffrey Garen.
1622
1623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1624         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1625         (TEST):
1626         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1627         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1628         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1629         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1630         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1631         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1632         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1633         (runTest):
1634         (createDirectories):
1635         (TEST):
1636         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1637         (TEST):
1638         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1639         (TEST):
1640
1641 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1642
1643         Add support to WebPage for getting the contents as an attributed string.
1644         https://bugs.webkit.org/show_bug.cgi?id=195636
1645         rdar://problem/45055697
1646
1647         Reviewed by Tim Horton.
1648
1649         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1650         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1651
1652 2019-03-15  Chris Dumez  <cdumez@apple.com>
1653
1654         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1655         https://bugs.webkit.org/show_bug.cgi?id=195747
1656
1657         Reviewed by Geoff Garen.
1658
1659         Add API test coverage.
1660
1661         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1662
1663 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1664
1665         Unreviewed, rolling out r242952.
1666
1667         Causing API failures on iOS Simulator
1668
1669         Reverted changeset:
1670
1671         "[PSON] Make sure the WebProcessCache is leverage when
1672         relaunching a process after termination"
1673         https://bugs.webkit.org/show_bug.cgi?id=195747
1674         https://trac.webkit.org/changeset/242952
1675
1676 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1677
1678         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1679         https://bugs.webkit.org/show_bug.cgi?id=195740
1680
1681         Reviewed by Ross Kirsling.
1682
1683         window.open doesn't work for WebKitBrowserWindow because it is not
1684         implemented yet.
1685
1686         1. Implemented createNewPage callback of WKPageUIClient.
1687         2. Changed MainWindow to take a BrowserWindow factory function
1688           instead of BrowserWindowType to be flexible to create
1689           BrowserWindow with extra settings.
1690         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1691           because it is not relevant with MainWindow anymore.
1692
1693         * MiniBrowser/win/Common.cpp:
1694         (parseCommandLine):
1695         * MiniBrowser/win/Common.h:
1696         (CommandLineOptions::CommandLineOptions):
1697         * MiniBrowser/win/MainWindow.cpp:
1698         (MainWindow::MainWindow):
1699         (MainWindow::create):
1700         (MainWindow::init):
1701         (MainWindow::WndProc):
1702         * MiniBrowser/win/MainWindow.h:
1703         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1704         (PrintWebUIDelegate::createWebViewWithRequest):
1705         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1706         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1707         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1708         (WebKitBrowserWindow::updateProxySettings):
1709         (WebKitBrowserWindow::createNewPage):
1710         * MiniBrowser/win/WebKitBrowserWindow.h:
1711         * MiniBrowser/win/WinMain.cpp:
1712         (wWinMain):
1713
1714 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1715
1716         Make it possible to test scrolling tree layer manipulation more easily
1717         https://bugs.webkit.org/show_bug.cgi?id=195780
1718
1719         Reviewed by Tim Horton.
1720         
1721         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1722         cuts off communication of scrolling tree scrolls back to the web process
1723         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1724         allows tests to trigger scrolls which run the scrolling tree layer positioning
1725         logic, but never get another commit from the web process that might mask
1726         scrolling tree bugs.
1727         
1728         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1729         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1730         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1731
1732         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1733         (WTR::UIScriptController::scrollUpdatesDisabled const):
1734         (WTR::UIScriptController::setScrollUpdatesDisabled):
1735         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1736         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1737         (WTR::UIScriptController::scrollUpdatesDisabled const):
1738         (WTR::UIScriptController::setScrollUpdatesDisabled):
1739         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1740         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1741         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1742         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1743         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1744         * WebKitTestRunner/ios/TestControllerIOS.mm:
1745         (WTR::TestController::platformResetStateToConsistentValues):
1746         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1747         (WTR::UIScriptController::scrollUpdatesDisabled const):
1748         (WTR::UIScriptController::setScrollUpdatesDisabled):
1749
1750 2019-03-14  Youenn Fablet  <youenn@apple.com>
1751
1752         Move IDB storage in private browsing mode to NetworkProcess
1753         https://bugs.webkit.org/show_bug.cgi?id=195602
1754
1755         Reviewed by Brady Eidson.
1756
1757         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1758         (TEST):
1759
1760 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1761
1762         [ews-build] Make descriptionDone messages more readable
1763         https://bugs.webkit.org/show_bug.cgi?id=195760
1764
1765         Reviewed by Lucas Forschler.
1766
1767         * BuildSlaveSupport/ews-build/steps.py:
1768         * BuildSlaveSupport/ews-build/steps_unittest.py:
1769
1770 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1771
1772         [ews-build] Generate status-bubble hover-over messages
1773         https://bugs.webkit.org/show_bug.cgi?id=195680
1774
1775         Reviewed by Lucas Forschler.
1776
1777         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1778         (StatusBubble):
1779         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1780         on hover-over.
1781         (StatusBubble._iso_time):
1782         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1783         hover-over message.
1784         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1785
1786 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1787
1788         [ews-app] Gracefully handle the case when state_string is None
1789         https://bugs.webkit.org/show_bug.cgi?id=195753
1790
1791         Reviewed by Lucas Forschler.
1792
1793         * BuildSlaveSupport/ews-app/ews/models/build.py:
1794         * BuildSlaveSupport/ews-app/ews/models/step.py:
1795
1796 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1797
1798         [ews-app] Status bubble display pending for currently running build step
1799         https://bugs.webkit.org/show_bug.cgi?id=195744
1800
1801         Reviewed by Lucas Forschler.
1802
1803         * BuildSlaveSupport/ews-build/events.py:
1804         (Events.stepStarted): If state_string is pending, replace it with step name.
1805
1806 2019-03-14  Chris Dumez  <cdumez@apple.com>
1807
1808         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1809         https://bugs.webkit.org/show_bug.cgi?id=195750
1810
1811         Reviewed by Geoffrey Garen.
1812
1813         Add API test coverage.
1814
1815         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1816         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1817         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1818         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1819
1820 2019-03-14  Chris Dumez  <cdumez@apple.com>
1821
1822         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1823         https://bugs.webkit.org/show_bug.cgi?id=195747
1824
1825         Reviewed by Geoff Garen.
1826
1827         Add API test coverage.
1828
1829         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1830
1831 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1832
1833         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1834         https://bugs.webkit.org/show_bug.cgi?id=195725
1835         <rdar://problem/48545062>
1836
1837         Reviewed by Tim Horton.
1838
1839         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1840         handler is nil.
1841
1842         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1843         (TestWebKitAPI::TEST):
1844
1845 2019-03-13  Sam Weinig  <sam@webkit.org>
1846
1847         Add utility function to allow easy reverse range-based iteration of a container
1848         https://bugs.webkit.org/show_bug.cgi?id=195542
1849
1850         Reviewed by Antti Koivisto.
1851
1852         * TestWebKitAPI/CMakeLists.txt:
1853         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1854         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1855         (TestWebKitAPI::TEST):
1856         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1857
1858 2019-03-13  Chris Dumez  <cdumez@apple.com>
1859
1860         Use a ServiceWorker process per registrable domain
1861         https://bugs.webkit.org/show_bug.cgi?id=195649
1862
1863         Reviewed by Youenn Fablet.
1864
1865         Update API test coverage.
1866
1867         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1868
1869 2019-03-13  Chris Dumez  <cdumez@apple.com>
1870
1871         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1872         https://bugs.webkit.org/show_bug.cgi?id=195684
1873         <rdar://problem/48294714>
1874
1875         Reviewed by Antti Koivisto.
1876
1877         Add API test coverage.
1878
1879         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1880
1881 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1882
1883         [ews-app] Remove unused patch view
1884         https://bugs.webkit.org/show_bug.cgi?id=195669
1885
1886         Reviewed by Lucas Forschler.
1887
1888         * BuildSlaveSupport/ews-app/ews/urls.py:
1889         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1890
1891 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1892
1893         [ews-app] Use Buildbot result code variables
1894         https://bugs.webkit.org/show_bug.cgi?id=195668
1895
1896         Reviewed by Alexey Proskuryakov.
1897
1898         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1899         (Buildbot): Added Buildbot result code variables.
1900         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1901         (StatusBubble._build_bubble): Used Buildbot result code variables.
1902
1903 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
1904
1905         [Flatpak] Expand submodule recursively
1906         https://bugs.webkit.org/show_bug.cgi?id=195672
1907
1908         Building WPE with flatpak was impossible without that as it was raising an exception.
1909         Also update wpebackend-fdo to match what is built in jhbuild
1910
1911         Reviewed by Philippe Normand.
1912
1913         * flatpak/flatpakutils.py:
1914         (expand_submodules_recurse):
1915         (expand_manifest):
1916         * flatpak/org.webkit.WPEModules.yaml:
1917
1918 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1919
1920         [ews-app] status bubble should be hidden for certain builds
1921         https://bugs.webkit.org/show_bug.cgi?id=194597
1922
1923         Reviewed by Dewei Zhu.
1924
1925         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1926         (StatusBubble._build_bubble):
1927         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
1928         because the patch didn't have relevant changes.
1929         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
1930         in production yet.
1931
1932 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
1933
1934         [Win] Fix a slew of simple clang-cl warnings.
1935         https://bugs.webkit.org/show_bug.cgi?id=195652
1936
1937         Reviewed by Don Olmstead.
1938
1939         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1940         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
1941
1942 2019-03-12  Justin Fan  <justin_fan@apple.com>
1943
1944         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
1945         https://bugs.webkit.org/show_bug.cgi?id=195518
1946         <rdar://problem/46322356>
1947
1948         Reviewed by Myles C. Maxfield.
1949
1950         * DumpRenderTree/DerivedSources-input.xcfilelist:
1951         * DumpRenderTree/DerivedSources-output.xcfilelist:
1952
1953 2019-03-12  Commit Queue  <commit-queue@webkit.org>
1954
1955         Unreviewed, rolling out r242825.
1956         https://bugs.webkit.org/show_bug.cgi?id=195648
1957
1958         "Broke webkitpy tests with my change to
1959         lldb_dump_class_layout.py" (Requested by rmorisset on
1960         #webkit).
1961
1962         Reverted changeset:
1963
1964         "Alter Tools/Scripts/dump-class-layout to be able to dump all
1965         classes with suspicious padding"
1966         https://bugs.webkit.org/show_bug.cgi?id=195573
1967         https://trac.webkit.org/changeset/242825
1968
1969 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1970
1971         [ews-build] Show status bubbles while the patch is waiting in queue
1972         https://bugs.webkit.org/show_bug.cgi?id=195618
1973
1974         Reviewed by Lucas Forschler.
1975
1976         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1977         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
1978         enabled in initial deployment.
1979         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
1980         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
1981         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
1982         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
1983         (StatusBubble._build_bubbles_for_patch):
1984
1985 2019-03-12  Robin Morisset  <rmorisset@apple.com>
1986
1987         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
1988         https://bugs.webkit.org/show_bug.cgi?id=195573
1989
1990         Reviewed by Simon Fraser.
1991
1992         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
1993
1994         * Scripts/dump-class-layout:
1995         (main):
1996         * lldb/lldb_dump_class_layout.py:
1997         (ClassLayout.__init__):
1998         (ClassLayout._compute_padding_recursive):
1999         (LLDBDebuggerInstance.dump_layout_for_classname):
2000         (LLDBDebuggerInstance):
2001         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2002         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2003
2004 2019-03-12  Chris Dumez  <cdumez@apple.com>
2005
2006         Device Orientation access permission should be denied unless explicitly granted by the client
2007         https://bugs.webkit.org/show_bug.cgi?id=195625
2008
2009         Reviewed by Youenn Fablet.
2010
2011         add API test coverage.
2012
2013         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2014         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2015         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2016         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2017         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2018         (runDeviceOrientationTest):
2019         (TEST):
2020         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2021         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2022
2023 2019-03-12  Jer Noble  <jer.noble@apple.com>
2024
2025         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2026         https://bugs.webkit.org/show_bug.cgi?id=195137
2027         <rdar://problem/48810307>
2028
2029         Reviewed by Eric Carlson.
2030
2031         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2032         (TestWebKitAPI::TEST):
2033
2034 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2035
2036         [ews-build] Change urls from uat to production
2037         https://bugs.webkit.org/show_bug.cgi?id=195566
2038
2039         Reviewed by Lucas Forschler.
2040
2041         * BuildSlaveSupport/ews-app/ews/config.py:
2042         * BuildSlaveSupport/ews-build/events.py:
2043         * BuildSlaveSupport/ews-build/steps.py:
2044
2045 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2046
2047         [ews-build] change max_builds for local-worker to 1
2048         https://bugs.webkit.org/show_bug.cgi?id=195568
2049
2050         Reviewed by Lucas Forschler.
2051
2052         * BuildSlaveSupport/ews-build/loadConfig.py:
2053
2054 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2055
2056         Fix the build
2057
2058         * TestRunnerShared/spi/PencilKitTestSPI.h:
2059         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2060
2061 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2062
2063         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2064         https://bugs.webkit.org/show_bug.cgi?id=194131
2065
2066         Reviewed by Michael Catanzaro.
2067
2068         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2069         (uriChanged):
2070         (testUnfinishedSubresourceLoad):
2071         (serverCallback):
2072         (beforeAll):
2073
2074 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2075
2076         WTF::Expected should use std::addressof instead of operator&
2077         https://bugs.webkit.org/show_bug.cgi?id=195604
2078
2079         Reviewed by Myles Maxfield.
2080
2081         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2082         (TestWebKitAPI::Unique::Unique):
2083         (TestWebKitAPI::Unique::operator&):
2084         (TestWebKitAPI::TEST):
2085
2086 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2087
2088         Add Optional to Forward.h.
2089         https://bugs.webkit.org/show_bug.cgi?id=195586
2090
2091         Reviewed by Darin Adler.
2092
2093         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2094         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2095         Remove unnecessary includes from headers.
2096
2097 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2098
2099         Add testing API to hit-test and scroll overflow scrollers
2100         https://bugs.webkit.org/show_bug.cgi?id=195278
2101
2102         Reviewed by Antti Koivisto.
2103         
2104         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2105         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2106         
2107         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2108
2109         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2110         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2111         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2112         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2113         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2114         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2115         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2116         (WTR::enclosingScrollViewIncludingSelf):
2117         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2118
2119 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2120
2121         API test WebKit.RequestTextInputContext fails on iOS
2122         https://bugs.webkit.org/show_bug.cgi?id=195585
2123
2124         Reviewed by Wenson Hsieh and Simon Fraser.
2125
2126         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2127         (applyStyle):
2128         (TEST):
2129         Add a viewport, so that the coordinates match up on iOS.
2130         Scroll by moving the UIScrollView's contentOffset.
2131
2132 2019-03-11  Chris Dumez  <cdumez@apple.com>
2133
2134         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2135         https://bugs.webkit.org/show_bug.cgi?id=195506
2136         <rdar://problem/48733477>
2137
2138         Reviewed by Alex Christensen.
2139
2140         Add API test coverage.
2141
2142         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2143
2144 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2145
2146         Adding myself to contributors.json
2147
2148         Unreviewed, addming myself to contributors.json .
2149
2150         * Scripts/webkitpy/common/config/contributors.json:
2151
2152 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2153
2154         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2155         https://bugs.webkit.org/show_bug.cgi?id=195511
2156         <rdar://problem/44873269>
2157
2158         Reviewed by Darin Adler.
2159
2160         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2161         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2162         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2163         (TEST_F):
2164
2165 2019-03-11  Chris Dumez  <cdumez@apple.com>
2166
2167         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2168         https://bugs.webkit.org/show_bug.cgi?id=195561
2169
2170         Reviewed by Youenn Fablet.
2171
2172         Make sure the JS in the test requests for permission to receive device orientation events.
2173
2174         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2175
2176 2019-03-11  Youenn Fablet  <youenn@apple.com>
2177
2178         Allow storage quota increase by default in WTR
2179         https://bugs.webkit.org/show_bug.cgi?id=195541
2180
2181         Reviewed by Geoffrey Garen.
2182
2183         Allow storage quota increase by default in WTR.
2184         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2185         Use this for tests that explicitly need cache increase.
2186
2187         Instead of increasing quota by 2, make sure the next request is
2188         granted by adding all given parameters.
2189
2190         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2191         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2192         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2193         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2194         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2195         * WebKitTestRunner/TestController.cpp:
2196         (WTR::TestController::setAllowStorageQuotaIncrease):
2197         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2198         * WebKitTestRunner/TestController.h:
2199         * WebKitTestRunner/TestInvocation.cpp:
2200         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2201         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2202         (WTR::TestController::cocoaResetStateToConsistentValues):
2203         (WTR::TestController::setAllowStorageQuotaIncrease):
2204         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2205         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2206         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2207
2208 2019-03-11  Xan Lopez  <xan@igalia.com>
2209
2210         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2211         https://bugs.webkit.org/show_bug.cgi?id=194147
2212
2213         Reviewed by Michael Saboff.
2214
2215         To make --32-bit work correctly on Linux/64bit we need to:
2216
2217         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2218         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2219         unfortunately CMake only allows us to do this during
2220         crosscompilation, which is overkill here.
2221         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2222         pkg-config detection module uses the x86 .pc files instead of the
2223         x86_64 ones.
2224         - Set the -m32 flags for the compiler.
2225
2226         * Scripts/webkitdirs.pm:
2227         (generateBuildSystemFromCMakeProject):
2228
2229 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2230
2231         Add MotionMark-1.1 plan file for run-benchmark script.
2232         https://bugs.webkit.org/show_bug.cgi?id=195481
2233
2234         Rubber-stamped by Darin Adler.
2235
2236         Run-benchmark script should support MontionMark-1.1.
2237
2238         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2239
2240 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2241
2242         [ews-app] Add support for submit-to-ews url
2243         https://bugs.webkit.org/show_bug.cgi?id=195477
2244
2245         Reviewed by Lucas Forschler.
2246
2247         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2248         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2249         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2250         * BuildSlaveSupport/ews-app/ews/urls.py:
2251         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2252
2253 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2254
2255         Unreviewed, rolling out r242688, r242643, r242624.
2256
2257         Caused multiple layout test failures and crashes on iOS and macOS.
2258
2259         Reverted changeset:
2260
2261         "requestAnimationFrame should execute before the next frame"
2262         https://bugs.webkit.org/show_bug.cgi?id=177484
2263         https://trac.webkit.org/changeset/242624/webkit
2264
2265         * Tracing/SystemTracePoints.plist:
2266
2267 2019-03-11  John Wilander  <wilander@apple.com>
2268
2269         Resource Load Statistics: Make it possible exclude localhost from classification
2270         https://bugs.webkit.org/show_bug.cgi?id=195474
2271         <rdar://problem/47520577>
2272
2273         Reviewed by Brent Fulgham.
2274
2275         This patch allows for localhost to be excluded from classification and
2276         treatment as a prevalent resource.
2277
2278         The WebKit Tools change adds a new function called
2279         testRunner.setStatisticsIsRunningTest() which can be used to control this
2280         behavior.
2281
2282         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2283         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2284         (WTR::TestRunner::setStatisticsIsRunningTest):
2285         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2286         * WebKitTestRunner/TestController.cpp:
2287         (WTR::TestController::setStatisticsIsRunningTest):
2288         * WebKitTestRunner/TestController.h:
2289         * WebKitTestRunner/TestInvocation.cpp:
2290         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2291
2292 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2293
2294         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2295         https://bugs.webkit.org/show_bug.cgi?id=195560
2296
2297         Reviewed by Lucas Forschler.
2298
2299         * BuildSlaveSupport/ews-build/master.cfg:
2300
2301 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2302
2303         Unreviewed, rolling out r242698.
2304
2305         API test crashes on bots.
2306
2307         Reverted changeset:
2308
2309         "Add a WKContentRuleList variant that uses copied memory
2310         instead of mmap'd shared memory for class A containerized
2311         apps"
2312         https://bugs.webkit.org/show_bug.cgi?id=195511
2313         https://trac.webkit.org/changeset/242698
2314
2315 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2316
2317         [WPE] Enable web process sandbox
2318         https://bugs.webkit.org/show_bug.cgi?id=195169
2319
2320         Reviewed by Daniel Bates.
2321
2322         * wpe/install-dependencies:
2323         * wpe/jhbuild.modules:
2324
2325 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2326
2327         [ews-app] Use port 17000 for worker communication
2328         https://bugs.webkit.org/show_bug.cgi?id=195558
2329
2330         Reviewed by Lucas Forschler.
2331
2332         * BuildSlaveSupport/ews-build/master.cfg:
2333
2334 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2335
2336         [ews-build] unit-tests fail when passwords.json is missing
2337         https://bugs.webkit.org/show_bug.cgi?id=195557
2338
2339         Reviewed by Lucas Forschler.
2340
2341         * BuildSlaveSupport/ews-build/loadConfig.py:
2342         (loadBuilderConfig):
2343         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2344         (ConfigDotJSONTest.test_configuration):
2345         * BuildSlaveSupport/ews-build/master.cfg:
2346
2347 2019-03-11  Truitt Savell  <tsavell@apple.com>
2348
2349         Unreviewed, rolling out r242702.
2350
2351         Broke High Sierra builders.
2352
2353         Reverted changeset:
2354
2355         "Add utility function to allow easy reverse range-based
2356         iteration of a container"
2357         https://bugs.webkit.org/show_bug.cgi?id=195542
2358         https://trac.webkit.org/changeset/242702
2359
2360 2019-03-11  Sam Weinig  <sam@webkit.org>
2361
2362         Add utility function to allow easy reverse range-based iteration of a container
2363         https://bugs.webkit.org/show_bug.cgi?id=195542
2364
2365         Reviewed by Antti Koivisto.
2366
2367         * TestWebKitAPI/CMakeLists.txt:
2368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2369         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2370         (TestWebKitAPI::TEST):
2371         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2372
2373 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2374
2375         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2376         https://bugs.webkit.org/show_bug.cgi?id=195511
2377         <rdar://problem/44873269>
2378
2379         Reviewed by Darin Adler.
2380
2381         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2382         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2383         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2384         (TEST_F):
2385
2386 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2387
2388         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2389         https://bugs.webkit.org/show_bug.cgi?id=195499
2390
2391         Reviewed by Darin Adler.
2392
2393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2394         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2395         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2396         (-[WKWebView synchronouslyFocusTextInputContext:]):
2397         (applyStyle):
2398         (applyIframe):
2399         (TEST):
2400         Add some tests for this SPI.
2401
2402 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2403
2404         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2405         https://bugs.webkit.org/show_bug.cgi?id=181151
2406
2407         Reviewed by Don Olmstead.
2408
2409         * TestWebKitAPI/CMakeLists.txt:
2410         * TestWebKitAPI/PlatformWin.cmake:
2411         Enable TestWTF RunLoop tests in all platforms.
2412
2413         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2414         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2415         (TestWebKitAPI::DerivedOneShotTimer::fired):
2416         (TestWebKitAPI::TEST):
2417         Only a few platforms support nested RunLoop.
2418
2419         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2420         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2421
2422 2019-03-10  David Quesada  <david_quesada@apple.com>
2423
2424         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2425         https://bugs.webkit.org/show_bug.cgi?id=152480
2426
2427         Reviewed by Chris Dumez.
2428
2429         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2430         there are no additional references to the process pool besides the one held by
2431         the download, waits for the download to finish (in the sense that the
2432         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2433         measure, also check that the process pool has been deallocated at the end of the
2434         test. The test wouldn't be meaningful if the process pool were still alive.
2435
2436         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2437         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2438         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2439             The download will be canceled because the delegate does not implement the
2440             method to decide the download's destination, so this is where we know the
2441             DownloadProxyMap is done with the DownloadProxy.
2442         (TEST):
2443
2444 2019-03-08  Chris Dumez  <cdumez@apple.com>
2445
2446         Add support for Device Orientation / Motion permission API
2447         https://bugs.webkit.org/show_bug.cgi?id=195329
2448         <rdar://problem/47645367>
2449
2450         Reviewed by Geoffrey Garen.
2451
2452         Add test infrastructure to help test the Device Orientation / Motion permission API.
2453
2454         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2455         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2456         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2457         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2458         * WebKitTestRunner/TestController.cpp:
2459         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2460         (WTR::TestController::createWebViewWithOptions):
2461         (WTR::TestController::resetStateToConsistentValues):
2462         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2463         * WebKitTestRunner/TestController.h:
2464         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2465         * WebKitTestRunner/TestInvocation.cpp:
2466         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2467
2468 2019-03-08  Saam barati  <sbarati@apple.com>
2469
2470         Add a compare-results script to compare benchmark results
2471         https://bugs.webkit.org/show_bug.cgi?id=195486
2472         <rdar://problem/48723397>
2473
2474         Reviewed by Geoffrey Garen.
2475
2476         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2477         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2478         to extend it to learn about our other benchmarks.
2479
2480         * Scripts/compare-results: Added.
2481         (readJSONFile):
2482         (detectJetStream2):
2483         (JetStream2Results):
2484         (detectSpeedometer2):
2485         (Speedometer2Results):
2486         (detectPLT5):
2487         (PLT5Results):
2488         (detectBenchmark):
2489         (biggerIsBetter):
2490         (ttest):
2491         (getOptions):
2492         (main):
2493
2494 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2495
2496         Ensure old tab state is cleared between iterations of run-benchmark
2497         https://bugs.webkit.org/show_bug.cgi?id=195393
2498         <rdar://problem/46885583>
2499
2500         Reviewed by Dewei Zhu.
2501
2502         a) ensure the default to restore state is not set
2503         b) terminate Safari correctly
2504         c) Set the system default to ignore Persistent State in Safari
2505
2506         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2507         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2508         (OSXBrowserDriver.prepare_env): 
2509         (OSXBrowserDriver.restore_env):
2510         (OSXBrowserDriver.close_browsers):
2511         (OSXBrowserDriver._terminate_processes):
2512         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2513         (OSXChromeDriver):
2514         (OSXChromeCanaryDriver):
2515         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2516         (OSXFirefoxDriver):
2517         (OSXFirefoxNightlyDriver):
2518         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2519         (OSXSafariDriver):
2520         (OSXSafariDriver.prepare_env):
2521
2522 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2523
2524         [GTK] Several InputMethodFilter tests are failing
2525         https://bugs.webkit.org/show_bug.cgi?id=195408
2526
2527         Reviewed by Carlos Garcia Campos.
2528
2529         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2530         Regressed in r241751.
2531         Hexadecimal values of keycodes are expressed now in upper letters.
2532         Composited characters should be cast to UTF8 strings.
2533
2534         (TestWebKitAPI::TEST):
2535
2536 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2537
2538         [GTK] Make Tools/gtkdoc python3 compatible
2539         https://bugs.webkit.org/show_bug.cgi?id=195359
2540
2541         Reviewed by Carlos Garcia Campos.
2542
2543         * gtkdoc/generate-gtkdoc:
2544         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2545         work with Python 2 and 3.
2546         (get_gtkdoc_module_paths):
2547         The iteritems() was removed in Python 3, so let's use items() that's
2548         available in Python 2 and 3.
2549         (get_generator_for_config):
2550         * gtkdoc/gtkdoc.py:
2551         (GTKDoc._run_command):
2552         The sys.stdout.write() is expecting str in Python 3 and not bytes
2553         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2554         for passing the bytes there.
2555
2556 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2557
2558         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2559         https://bugs.webkit.org/show_bug.cgi?id=195346
2560         <rdar://problem/48667048>
2561
2562         Unreviewed build fix for clang-cl.
2563
2564         * DumpRenderTree/win/DumpRenderTree.cpp:
2565         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2566
2567 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2568
2569         requestAnimationFrame should execute before the next frame
2570         https://bugs.webkit.org/show_bug.cgi?id=177484
2571
2572         Reviewed by Simon Fraser.
2573
2574         Add trace points for the page RenderingUpdate.
2575
2576         * Tracing/SystemTracePoints.plist:
2577
2578 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2579
2580         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2581         https://bugs.webkit.org/show_bug.cgi?id=195353
2582         <rdar://problem/48626394>
2583
2584         Reviewed by Simon Fraser.
2585
2586         * WebKitTestRunner/ios/TestControllerIOS.mm:
2587         (WTR::TestController::platformResetPreferencesToConsistentValues):
2588
2589 2019-03-07  John Wilander  <wilander@apple.com>
2590
2591         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2592         https://bugs.webkit.org/show_bug.cgi?id=195383
2593         <rdar://problem/48570136>
2594
2595         Reviewed by Brent Fulgham.
2596
2597         This patch adds test infrastructure to purge only script-accessible cookies,
2598         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2599
2600         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2601         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2602         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2603         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2604         * WebKitTestRunner/TestController.cpp:
2605         (WTR::TestController::statisticsDeleteCookiesForHost):
2606         * WebKitTestRunner/TestController.h:
2607         * WebKitTestRunner/TestInvocation.cpp:
2608         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2609
2610 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2611
2612         Unreviewed, rolling out r242354.
2613         https://bugs.webkit.org/show_bug.cgi?id=195402
2614
2615         breaks layout tests in all configurations (Requested by
2616         zdobersek on #webkit).
2617
2618         Reverted changeset:
2619
2620         "[WPE] Enable web process sandbox"
2621         https://bugs.webkit.org/show_bug.cgi?id=195169
2622         https://trac.webkit.org/changeset/242354
2623
2624 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2625
2626         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2627         https://bugs.webkit.org/show_bug.cgi?id=195346
2628
2629         Reviewed by Fujii Hironori.
2630
2631         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2632         (TestWebKitAPI::TEST):
2633         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2634
2635         * DumpRenderTree/win/DumpRenderTree.cpp:
2636         (findFontFallback):
2637         (addFontFallbackIfPresent):
2638         (removeFontFallbackIfPresent):
2639         (main):
2640         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2641         (TestWebKitAPI::Util::moduleDirectory):
2642         (TestWebKitAPI::Util::createInjectedBundlePath):
2643         Use wchar helpers as needed.
2644
2645 2019-03-06  Rob Buis  <rbuis@igalia.com>
2646
2647         Consider supporting the `referrerpolicy` attribute.
2648         https://bugs.webkit.org/show_bug.cgi?id=179053
2649
2650         Reviewed by Darin Adler.
2651
2652         Add a runtime flag for referrerpolicy attribute.
2653
2654         * DumpRenderTree/mac/DumpRenderTree.mm:
2655         (enableExperimentalFeatures):
2656
2657 2019-03-05  Daniel Bates  <dabates@apple.com>
2658
2659         Update expected API test result following r242379
2660         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2661
2662         Update expected x-coordinate of selection rect now that the left padding of
2663         a textarea is sized in ems (so dependent on the font size) just like the left
2664         padding of a text field.
2665
2666         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2667         (TestWebKitAPI::TEST):
2668
2669 2019-03-05  David Quesada  <david_quesada@apple.com>
2670
2671         [WK2] It should be possible to follow links with 'download' attributes
2672         https://bugs.webkit.org/show_bug.cgi?id=195145
2673         rdar://problem/48462642
2674
2675         Reviewed by Alex Christensen.
2676
2677         Add a unit test to verify that activating links with 'download' attributes now
2678         navigates to the linked resource, rather than starts downloading it. Add another
2679         to verify that it is still possible to explicitly download the link via the
2680         'Download' navigation action policy.
2681
2682         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2683         (-[DownloadAttributeTestDelegate init]):
2684         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2685         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2686         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2687         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2688         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2689         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2690         (TEST):
2691         * WebKitTestRunner/TestController.cpp:
2692         (WTR::TestController::decidePolicyForNavigationAction):
2693         * WebKitTestRunner/TestController.h:
2694
2695 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2696
2697         [Curl] Implement Cookie Accept Policy.
2698         https://bugs.webkit.org/show_bug.cgi?id=191645
2699
2700         Reviewed by Fujii Hironori.
2701
2702         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2703         (TestWebKitAPI::Curl::TEST_F):
2704
2705 2019-03-05  Youenn Fablet  <youenn@apple.com>
2706
2707         Rename requestCacheStorageSpace to requestStorageSpace
2708         https://bugs.webkit.org/show_bug.cgi?id=195282
2709
2710         Reviewed by Chris Dumez.
2711
2712         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2713         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2714         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2715
2716 2019-03-05  Brady Eidson  <beidson@apple.com>
2717
2718         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2719         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2720
2721         Reviewed by Tim Horton.
2722
2723         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2724         different directory into that same WKWebView should work.
2725
2726         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2727         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2728
2729 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2730
2731         Add WeakHashSet
2732         https://bugs.webkit.org/show_bug.cgi?id=195152
2733
2734         Reviewed by Antti Koivisto.
2735
2736         Added tests for WeakHashSet.
2737
2738         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2739         (TestWebKitAPI::Base::Base): Moved.
2740         (TestWebKitAPI::Derived::foo): Moved.
2741         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2742         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2743         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2744         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2745
2746 2019-03-04  Chris Dumez  <cdumez@apple.com>
2747
2748         Do not share WebProcesses between private and regular sessions
2749         https://bugs.webkit.org/show_bug.cgi?id=195189
2750         <rdar://problem/48421064>
2751
2752         Reviewed by Alex Christensen.
2753
2754         Add API test coverage.
2755
2756         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2757         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2758
2759 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2760
2761         [WPE] Enable web process sandbox
2762         https://bugs.webkit.org/show_bug.cgi?id=195169
2763
2764         Reviewed by Daniel Bates.
2765
2766         * wpe/install-dependencies:
2767         * wpe/jhbuild.modules:
2768
2769 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2770
2771         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2772         https://bugs.webkit.org/show_bug.cgi?id=195206
2773
2774         Reviewed by Žan Doberšek.
2775
2776         Add a new test case.
2777
2778         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2779         (testJSCClass):
2780
2781 2019-03-04  Charlie Turner  <cturner@igalia.com>
2782
2783         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2784         https://bugs.webkit.org/show_bug.cgi?id=194898
2785
2786         Reviewed by Žan Doberšek.
2787
2788         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2789         a GCC extension that permits arithmetic on void* pointer. Inline
2790         the macro until this issue is fixed upstream.
2791
2792 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2793
2794         Rid the world of WK_API_ENABLED
2795         https://bugs.webkit.org/show_bug.cgi?id=195263
2796
2797         Reviewed by Dan Bernstein.
2798
2799         List of changed files elided because it's useless.
2800
2801 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2802
2803         Unreviewed follow-up to r242292.
2804
2805         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2806
2807         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2808         (TestWebKitAPI::testStrip): Renamed from strip.
2809         (TestWebKitAPI::TEST):
2810
2811 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2812
2813         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2814
2815         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2816         and bug #194272 for details.
2817
2818         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2819
2820 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2821
2822         Remove some more unused 32-bit code
2823         https://bugs.webkit.org/show_bug.cgi?id=195255
2824
2825         Reviewed by Darin Adler.
2826
2827         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2828         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2829         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2830         (NPP_New):
2831         (NPP_HandleEvent):
2832         (handleEventCarbon): Deleted.
2833
2834 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2835
2836         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2837
2838         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2839         (TestWebKitAPI::TEST):
2840
2841 2019-03-01  Darin Adler  <darin@apple.com>
2842
2843         Finish removing String::format
2844         https://bugs.webkit.org/show_bug.cgi?id=194893
2845
2846         Reviewed by Daniel Bates.
2847 '
2848         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2849
2850 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2851
2852         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2853         https://bugs.webkit.org/show_bug.cgi?id=195229
2854         <rdar://problem/48520362>
2855
2856         Reviewed by Chris Dumez.
2857
2858         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2859         (TEST):
2860
2861 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2862
2863         Add a system trace scope for event region building
2864         https://bugs.webkit.org/show_bug.cgi?id=195226
2865
2866         Reviewed by Jon Lee.
2867
2868         This trace scope measures the time spend converting element rects into Region objects,
2869         which can be large on some pages.
2870
2871         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2872
2873         * Tracing/SystemTracePoints.plist:
2874
2875 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2876
2877         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2878         https://bugs.webkit.org/show_bug.cgi?id=194612
2879
2880         Reviewed by Alex Christensen.
2881
2882         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2883         Just test the new string-processing function and don't touch the actual environment.
2884         (Test cases are all as before, but based on operator== instead of strcmp.)
2885
2886 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2887
2888         [ews-app] Update primary keys for handling multiple Buildbot instances
2889         https://bugs.webkit.org/show_bug.cgi?id=195120
2890
2891         Reviewed by Stephanie Lewis.
2892
2893         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2894         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
2895         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
2896
2897         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
2898         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
2899         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
2900         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
2901         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
2902         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
2903
2904 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
2905
2906         [WinCairo] Enable service worker
2907         https://bugs.webkit.org/show_bug.cgi?id=188318
2908
2909         Reviewed by Youenn Fablet.
2910
2911         * DumpRenderTree/DumpRenderTreePrefix.h:
2912         * TestWebKitAPI/PlatformWin.cmake:
2913         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
2914         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
2915         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2916
2917 2019-03-01  Justin Fan  <justin_fan@apple.com>
2918
2919         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
2920         https://bugs.webkit.org/show_bug.cgi?id=195191
2921
2922         Rubber-stamped by Dean Jackson.
2923
2924         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
2925
2926         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2927
2928 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
2929
2930         Unreviewed, fix lldb webkitpy tests
2931         https://bugs.webkit.org/show_bug.cgi?id=194375
2932
2933         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
2934
2935         * lldb/lldb_webkit.py:
2936         (WTFStringImplProvider.is_8bit):
2937
2938 2019-02-28  David Quesada  <david_quesada@apple.com>
2939
2940         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
2941         https://bugs.webkit.org/show_bug.cgi?id=195121
2942         rdar://problem/48450302
2943
2944         Reviewed by Alex Christensen.
2945
2946         Add API tests for -WKNavigationAction._shouldPerformDownload in various
2947         configurations where the 'download' attribute is absent, blank, or populated
2948         with a filename, and where the anchor element is same-origin or cross-origin
2949         (meaning the 'download' attribute shouldn't be honored).
2950
2951         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2952         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
2953         (-[NavigationActionTestDelegate init]):
2954         (-[NavigationActionTestDelegate navigationAction]):
2955         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
2956         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
2957         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2958         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
2959         (TEST):
2960
2961 2019-02-28  Antoine Quint  <graouts@apple.com>
2962
2963         Enable the Pointer Events runtime flag by default
2964         https://bugs.webkit.org/show_bug.cgi?id=195156
2965
2966         Reviewed by Dean Jackson.
2967
2968         * DumpRenderTree/mac/DumpRenderTree.mm:
2969         (enableExperimentalFeatures):
2970
2971 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2972
2973         Several PasteImage API tests are flaky
2974         https://bugs.webkit.org/show_bug.cgi?id=195160
2975
2976         Reviewed by Tim Horton.
2977
2978         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
2979         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
2980         listening for a "load" event after image load is already complete.
2981
2982         To address this, make these tests first register a "load" event handler, then run script to insert an image
2983         element into the document, and finally wait until the load event is observed before checking image size.
2984
2985         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2986
2987 2019-02-28  Chris Dumez  <cdumez@apple.com>
2988
2989         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
2990         https://bugs.webkit.org/show_bug.cgi?id=195107
2991
2992         Reviewed by Alex Christensen.
2993
2994         Give some time for the zoom level to get restored.
2995
2996         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2997
2998 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
2999
3000         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3001         https://bugs.webkit.org/show_bug.cgi?id=194958
3002
3003         Reviewed by Geoffrey Garen.
3004
3005         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3006         (TEST):
3007
3008 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3009
3010         [ews-app] Update method to save build to handle builder_display_name
3011         https://bugs.webkit.org/show_bug.cgi?id=195047
3012
3013         Reviewed by Dewei Zhu.
3014
3015         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3016         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3017
3018 2019-02-28  Justin Fan  <justin_fan@apple.com>
3019
3020         [Web GPU] Enable Web GPU only on 64-bit
3021         https://bugs.webkit.org/show_bug.cgi?id=195139
3022
3023         Because Metal is only supported on 64 bit apps.
3024
3025         Unreviewed build fix.
3026
3027         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3028
3029 2019-02-27  Youenn Fablet  <youenn@apple.com>
3030
3031         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3032         https://bugs.webkit.org/show_bug.cgi?id=194959
3033
3034         Reviewed by Chris Dumez.
3035
3036         Spin loop until getting the condition to remove flakiness.
3037
3038         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3039
3040 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3041
3042         [ews-build] Buildbot should include builder_display_name in the build events
3043         https://bugs.webkit.org/show_bug.cgi?id=195045
3044
3045         Reviewed by Dewei Zhu.
3046
3047         * BuildSlaveSupport/ews-build/events.py:
3048         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3049         buildername to builder_name to be consistent in naming style.
3050         (Events.buildFinished): Ditto.
3051
3052 2019-02-27  Chris Dumez  <cdumez@apple.com>
3053
3054         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3055         https://bugs.webkit.org/show_bug.cgi?id=194480
3056
3057         Reviewed by Brady Eidson.
3058
3059         Update existing API test to make it more likely to reproduce the issue.
3060
3061         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3062
3063 2019-02-27  Brady Eidson  <beidson@apple.com>
3064
3065         Universal links from Google search results pages don't open the app.
3066         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3067
3068         Reviewed by Geoffrey Garen.
3069
3070         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3071         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3072         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3073         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3074
3075 2019-02-27  Chris Dumez  <cdumez@apple.com>
3076
3077         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3078         https://bugs.webkit.org/show_bug.cgi?id=195102
3079
3080         Reviewed by Geoffrey Garen.
3081
3082         If the number of processes is not yet what we expect, wait a bit and check again to give
3083         processes some time to exit.
3084
3085         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3086
3087 2019-02-27  Chris Dumez  <cdumez@apple.com>
3088
3089         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3090         https://bugs.webkit.org/show_bug.cgi?id=194545
3091
3092         Reviewed by Brady Eidson.
3093
3094         Make sure the test navigates forward and then back only once. Previously, navigating
3095         back would trigger a navigation again in a timer.
3096
3097         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3098
3099 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3100
3101         High Sierra Debug JSC test queue should use faster hardware
3102         https://bugs.webkit.org/show_bug.cgi?id=194603
3103
3104         Rubber-stamped by Alexey Proskuryakov.
3105
3106         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3107
3108         * BuildSlaveSupport/build.webkit.org-config/config.json:
3109         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3110         (BubbleQueueServer):
3111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3112         (WebKitBuildbot):
3113         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3114         * QueueStatusServer/config/queues.py:
3115         * Scripts/webkitpy/common/config/ews.json:
3116         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3117         (test_ews_name):
3118
3119 2019-02-27  John Wilander  <wilander@apple.com>
3120
3121         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3122         https://bugs.webkit.org/show_bug.cgi?id=195071
3123         <rdar://problem/48417690>
3124
3125         Reviewed by Alex Christensen and Brent Fulgham.
3126
3127         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3128         (TestWebKitAPI::createURL):
3129             Convenience function.
3130         (TestWebKitAPI::TEST):
3131             WebCore::AdClickAttribution now takes a URL when creating Source and
3132             Destination.
3133         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3134         (TestWebKitAPI::TEST):
3135             WebCore::AdClickAttribution now takes a URL when creating Source and
3136             Destination.
3137
3138 2019-02-27  Antoine Quint  <graouts@apple.com>
3139
3140         Support Pointer Events on macOS
3141         https://bugs.webkit.org/show_bug.cgi?id=195008
3142         <rdar://problem/47454419>
3143
3144         Reviewed by Dean Jackson.
3145
3146         * DumpRenderTree/mac/DumpRenderTree.mm:
3147         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3148         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3149
3150 2019-02-26  Mark Lam  <mark.lam@apple.com>
3151
3152         Remove remaining poisoning code.
3153         https://bugs.webkit.org/show_bug.cgi?id=194138
3154
3155         Reviewed by Saam Barati.
3156
3157         * TestWebKitAPI/CMakeLists.txt:
3158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3159         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3160         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3161         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3162         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3163         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3164         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3165
3166 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3167
3168         Move ephemeral local storage from WebProcess to UIProcess
3169         https://bugs.webkit.org/show_bug.cgi?id=195074
3170         <rdar://problem/47937975>
3171
3172         Reviewed by Geoff Garen.
3173
3174         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3175
3176 2019-02-20  Jer Noble  <jer.noble@apple.com>
3177
3178         [Cocoa] Media elements will restart network buffering just before suspending
3179         https://bugs.webkit.org/show_bug.cgi?id=193691
3180
3181         Reviewed by Eric Carlson.
3182
3183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3184         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3185         (TEST):
3186
3187 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3188
3189         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3190         https://bugs.webkit.org/show_bug.cgi?id=191652
3191
3192         Reviewed by Alex Christensen.
3193
3194         Fix WinCairo MiniBrowser behavior of authentication dialog.
3195
3196         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3197         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3198
3199 2019-02-26  Youenn Fablet  <youenn@apple.com>
3200
3201         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3202         https://bugs.webkit.org/show_bug.cgi?id=195028
3203         <rdar://problem/48243733>
3204
3205         Reviewed by Eric Carlson.
3206
3207         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3208
3209 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3210
3211         [WPE] Add API for webview background color configuration
3212         https://bugs.webkit.org/show_bug.cgi?id=192305
3213
3214         Reviewed by Michael Catanzaro.
3215
3216         * MiniBrowser/wpe/main.cpp:
3217         (main): Add a new option to configure the webview background
3218         color. Example: --bg-color=transparent.
3219         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3220         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3221         (beforeAll): Ditto.
3222
3223 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3224
3225         scalableNativeWebpageParameters() is not preserved on new page navigation.
3226         https://bugs.webkit.org/show_bug.cgi?id=194892
3227         <rdar://problem/47538280>
3228
3229         Reviewed by Wenson Hsieh.
3230         
3231         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3232
3233         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3234         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3235         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3236         (WTR::UIScriptController::allowsViewportShrinkToFit):
3237         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3238         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3239         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3240         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3241         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3242         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3243
3244 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3245
3246         [ews-app] Add model for handling multiple Buildbot instances
3247         https://bugs.webkit.org/show_bug.cgi?id=194863
3248
3249         Reviewed by Stephanie Lewis.
3250
3251         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3252
3253 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3254
3255         [ews-app] Remove BuilderMapping table
3256         https://bugs.webkit.org/show_bug.cgi?id=194961
3257
3258         Reviewed by Stephanie Lewis.
3259
3260         Store builder name directly in build table, instead of having a separate
3261         table for it.
3262
3263         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3264         * BuildSlaveSupport/ews-app/ews/models/build.py:
3265         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3266         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3267
3268 2019-02-25  John Wilander  <wilander@apple.com>
3269
3270         Introduce and adopt new class RegistrableDomain for eTLD+1
3271         https://bugs.webkit.org/show_bug.cgi?id=194791
3272         <rdar://problem/48179240>
3273
3274         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3275
3276         This patch adds an API test and replaces two instances of
3277         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3278
3279         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3280         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3281         (TestWebKitAPI::TEST):
3282             Changed two strings to make sure the registrable domains are still considered
3283             invalid and pass the test.
3284         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3285         (TestWebKitAPI::TEST):
3286         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3287         (WTR::InjectedBundle::didReceiveMessageToPage):
3288
3289 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3290
3291         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3292         https://bugs.webkit.org/show_bug.cgi?id=195001
3293
3294         Reviewed by Carlos Garcia Campos.
3295
3296         API version 1.0 always includes the functionality previously guarded with
3297         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3298         unconditionally.
3299
3300         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3301         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3302         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3303         (WebViewTest::showInWindow): Ditto.
3304         (WebViewTest::hideView): Ditto.
3305         * wpe/backends/HeadlessViewBackend.cpp:
3306         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3307         * wpe/backends/ViewBackend.cpp:
3308         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3309         * wpe/backends/WindowViewBackend.cpp:
3310         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3311         WPE_BACKEND_CHECK_VERSION().
3312         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3313
3314 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3315
3316         [Flatpak] Add support for flatpak > 1.1.2
3317         https://bugs.webkit.org/show_bug.cgi?id=194088
3318
3319         Flatpak 1.2 is now out so we need to support that
3320         version now.
3321
3322         Reviewed by Michael Catanzaro.
3323
3324         * flatpak/flatpakutils.py:
3325         (check_flatpak):
3326         (FlatpakPackages.__init__):
3327         (FlatpakPackages.__detect_packages):
3328         (FlatpakPackages.__detect_packages.in):
3329         (FlatpakRepos.update):
3330
3331 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3332
3333         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3334         https://bugs.webkit.org/show_bug.cgi?id=194998
3335
3336         Reviewed by Carlos Garcia Campos.
3337
3338         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3339         to a Git checkout and using the latest commit containing various fixes
3340         and improvements.
3341
3342 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3343
3344         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3345         https://bugs.webkit.org/show_bug.cgi?id=194981
3346
3347         Reviewed by Žan Doberšek.
3348
3349         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3350         (TestWebKitAPI::TEST):
3351
3352 2019-02-23  Keith Miller  <keith_miller@apple.com>
3353
3354         Add new mac target numbers
3355         https://bugs.webkit.org/show_bug.cgi?id=194955
3356
3357         Reviewed by Tim Horton.
3358
3359         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3360         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3361         * MiniBrowser/Configurations/Base.xcconfig:
3362         * TestWebKitAPI/Configurations/Base.xcconfig:
3363         * WebKitTestRunner/Configurations/Base.xcconfig:
3364
3365 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3366
3367         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3368         https://bugs.webkit.org/show_bug.cgi?id=194846
3369
3370         Reviewed by Don Olmstead.
3371
3372         Added _search_paths() and _port_specific_expectations_files() for
3373         WinCairoPort.
3374
3375         * Scripts/webkitpy/port/win.py:
3376         (WinCairoPort.default_baseline_search_path):
3377         (WinCairoPort):
3378         (WinCairoPort._port_specific_expectations_files):
3379         (WinCairoPort._search_paths):
3380
3381 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3382
3383         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3384         https://bugs.webkit.org/show_bug.cgi?id=194963
3385
3386         Reviewed by Dean Jackson.
3387
3388         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3389         Do a `contains` check instead of `equals`, because in debug builds we
3390         put the GraphicsLayer pointer in a prefix.
3391
3392 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3393
3394         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3395         https://bugs.webkit.org/show_bug.cgi?id=194873
3396         <rdar://problem/46701974>
3397
3398         Reviewed by Tim Horton.
3399
3400         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3401
3402         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3403         (WTR::UIScriptController::menuRect const):
3404         (WTR::UIScriptController::isShowingMenu const):
3405         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3406         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3407         (WTR::UIScriptController::menuRect const):
3408
3409         Add a function to query the bounds of the callout menu in content coordinates.
3410
3411         (WTR::UIScriptController::isShowingMenu const):
3412
3413         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3414
3415         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3416         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3417         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3418         (WTR::UIScriptController::rectForMenuAction const):
3419         (WTR::UIScriptController::menuRect const):
3420         (WTR::UIScriptController::isShowingMenu const):
3421         (WTR::findViewInHierarchyOfType): Deleted.
3422
3423 2019-02-22  Chris Dumez  <cdumez@apple.com>
3424
3425         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3426         https://bugs.webkit.org/show_bug.cgi?id=194954
3427         <rdar://problem/48127957>
3428
3429         Reviewed by Alex Christensen.
3430
3431         Add API test coverage.
3432
3433         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3434         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3435         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3436         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3437
3438 2019-02-22  Chris Dumez  <cdumez@apple.com>
3439
3440         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3441         https://bugs.webkit.org/show_bug.cgi?id=194924
3442         <rdar://problem/48216125>
3443
3444         Reviewed by Geoffrey Garen.
3445
3446         Add API test coverage.
3447
3448         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3449
3450 2019-02-22  Chris Dumez  <cdumez@apple.com>
3451
3452         Unreviewed, disable API test added in r241928 on iOS.
3453
3454         The cache is not enabled on devices with less than 3GB of RAM.
3455
3456         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3457
3458 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3459
3460         Hardcode Visual Viewports on everywhere except iOS WK1
3461         https://bugs.webkit.org/show_bug.cgi?id=194928
3462
3463         Reviewed by Zalan Bujtas.
3464
3465         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3466         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3467         set it to false. The setting has shipped for several years and there's no need to turn
3468         it off now.
3469
3470         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3471         Visual Viewports are not enabled.
3472         
3473         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3474         that only runs in WK2
3475
3476         * MiniBrowser/mac/SettingsController.h:
3477         * MiniBrowser/mac/SettingsController.m:
3478         (-[SettingsController init]):
3479         (-[SettingsController _populateMenu]):
3480         (-[SettingsController validateMenuItem:]):
3481         (-[SettingsController visualViewportEnabled]): Deleted.
3482         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3483         * MiniBrowser/mac/WK1BrowserWindowController.m:
3484         (-[WK1BrowserWindowController didChangeSettings]):
3485         * MiniBrowser/mac/WK2BrowserWindowController.m:
3486         (-[WK2BrowserWindowController didChangeSettings]):
3487
3488 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3489
3490         Discard cached processes when clearing website data store
3491         https://bugs.webkit.org/show_bug.cgi?id=194894
3492
3493         Reviewed by Chris Dumez.
3494
3495         Added a test case.
3496
3497         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3498         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3499
3500 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3501
3502         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3503         https://bugs.webkit.org/show_bug.cgi?id=194914
3504         <rdar://problem/47586889>
3505
3506         Reviewed by Geoffrey Garen.
3507
3508         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3509         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3510         (TEST):
3511         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3512
3513 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3514
3515         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3516         <https://webkit.org/b/194761>
3517
3518         Reviewed by Myles Maxfield.
3519
3520         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3521         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3522         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3523         to use ARC-compliant cast.
3524         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3525         ARC-compliant cast.
3526         (WTR::installFakeHelvetica): Log `error` to console if
3527         CTFontManagerRegisterFontsForURL() fails, but only on supported
3528         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3529         Call CFRelease() on `error` to fix the leak.  Update to use
3530         ARC-compliant cast.
3531         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3532         cast.
3533
3534 2019-02-21  Chris Dumez  <cdumez@apple.com>
3535
3536         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3537         https://bugs.webkit.org/show_bug.cgi?id=194481
3538
3539         Reviewed by Alex Christensen.
3540
3541         Give the processes a chance to shutdown and wait until we reached the expected number
3542         of processes.
3543
3544         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3545
3546 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3547
3548         Fix the macOS build
3549
3550         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3551
3552 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3553
3554         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3555
3556         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3557         I am a backwards.
3558
3559 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3560
3561         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3562
3563         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3564         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3565         We could force on UI-side compositing, but I feel like the test might be more
3566         valuable exercising the normal path on each platform (though the original
3567         bug was also UI-side specific). Though we can't validate that the overlay
3568         layer was installed successfully, there are layout tests that do that.
3569
3570 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3571
3572         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3573         https://bugs.webkit.org/show_bug.cgi?id=194845
3574         <rdar://problem/47944579>
3575
3576         Reviewed by Antti Koivisto.
3577
3578         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3579         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3580
3581 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3582
3583         [LFC][Floats] Add support for placing formatting roots in-between floats.
3584         https://bugs.webkit.org/show_bug.cgi?id=194902
3585
3586         Reviewed by Antti Koivisto.
3587
3588         * LayoutReloaded/misc/LFC-passing-tests.txt:
3589
3590 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3591
3592         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3593         https://bugs.webkit.org/show_bug.cgi?id=194901
3594
3595         Unreviewed build fix.
3596
3597         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3598         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3599         WPEBackend-fdo-0.1 as library name.
3600
3601 2019-02-21  Rob Buis  <rbuis@igalia.com>
3602
3603         Update MIME type parser
3604         https://bugs.webkit.org/show_bug.cgi?id=180526
3605
3606         Reviewed by Darin Adler.
3607
3608         Add tests involving leading and trailing whitespace, non-token
3609         characters and quoted strings.
3610
3611         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3612         (TestWebKitAPI::TEST):
3613
3614 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3615
3616         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3617         https://bugs.webkit.org/show_bug.cgi?id=194884
3618
3619         Reviewed by Michael Catanzaro.
3620
3621         * PlatformWin.cmake:
3622
3623 2019-02-20  Chris Dumez  <cdumez@apple.com>
3624
3625         Add API test for <rdar://problem/47471222>
3626         https://bugs.webkit.org/show_bug.cgi?id=194847
3627
3628         Reviewed by Alex Christensen.
3629
3630         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3631
3632 2019-02-20  Chris Dumez  <cdumez@apple.com>
3633
3634         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3635         https://bugs.webkit.org/show_bug.cgi?id=194872
3636         <rdar://problem/47924500>
3637
3638         Reviewed by Alex Christensen.
3639
3640         Add API test coverage.
3641
3642         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3643
3644 2019-02-20  Jer Noble  <jer.noble@apple.com>
3645
3646         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3647         https://bugs.webkit.org/show_bug.cgi?id=191332
3648
3649         Reviewed by Dean Jackson.
3650
3651         * Scripts/git-is-in-range: Added.
3652
3653 2019-02-20  Andy Estes  <aestes@apple.com>
3654
3655         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3656         https://bugs.webkit.org/show_bug.cgi?id=194869
3657
3658         Rubber-stamped by Jer Noble.
3659
3660         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3661         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3662         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3663         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3664         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3665         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3666
3667 2019-02-20  Chris Dumez  <cdumez@apple.com>
3668
3669         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3670         https://bugs.webkit.org/show_bug.cgi?id=194857
3671         <rdar://problem/47759323>
3672
3673         Reviewed by Alex Christensen.
3674
3675         Add API test coverage.
3676
3677         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3678
3679 2019-02-20  Chris Dumez  <cdumez@apple.com>
3680
3681         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3682         https://bugs.webkit.org/show_bug.cgi?id=194829
3683         <rdar://problem/47889906>
3684
3685         Reviewed by Alexey Proskuryakov.
3686
3687         Every time the TestOptions were changing we were creating both a new Web view and
3688         a new WKContext, which would start a new Network process. In most cases, we only
3689         need to contruct a new Web view and we do can keep reusing the same WKContext.
3690         This patch implements this optimization and thus avoids spinning a lot of new
3691         Network processes while running the layout tests.
3692
3693         * WebKitTestRunner/TestController.cpp:
3694         (WTR::TestController::generateContextConfiguration const):
3695         (WTR::TestController::generatePageConfiguration):
3696         (WTR::TestController::createWebViewWithOptions):
3697         (WTR::TestController::resetPreferencesToConsistentValues):
3698         (WTR::updateTestOptionsFromTestHeader):
3699         * WebKitTestRunner/TestController.h:
3700         * WebKitTestRunner/TestOptions.h:
3701         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3702         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3703         (WTR::TestOptions::hasSameInitializationOptions const):
3704         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3705         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3706         (WTR::TestController::platformAddTestOptions const):
3707
3708 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3709
3710         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3711         https://bugs.webkit.org/show_bug.cgi?id=167941
3712
3713         Reviewed by Carlos Garcia Campos.
3714
3715         * MiniBrowser/gtk/main.c:
3716         (filterSavedCallback): Added.
3717         (main): Support loading a JSON rule set file for content filtering.
3718         * MiniBrowser/wpe/main.cpp:
3719         (filterSavedCallback): Added.
3720         (main): Support loading a JSON rule set file for content filtering.
3721         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3722         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3723         (WTF::derefGPtr): Ditto.
3724         (testEmptyStore):
3725         (testSaveInvalidFilter):
3726         (testSaveLoadFilter):
3727         (testSavedFilterIdentifierMatch):
3728         (testRemoveFilter):
3729         (testSaveMultipleFilters):
3730         (testSaveFilterFromFile):
3731         (testFilterPersistence):
3732         (beforeAll):
3733         (afterAll):
3734         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3735         (removeOldInjectedContentAndResetLists): Also reset content filters.
3736         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3737         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3738         the element affected by the style sheet.
3739         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3740         and returns it to be used by tests.
3741         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3742         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3743         (serverCallback): Add support for serving a CSS style sheet for testing.
3744         (beforeAll): Add call to testUserContentManagerContentFilter().
3745         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3746
3747 2019-02-19  Keith Rollin  <krollin@apple.com>
3748
3749         Add timing information to build output
3750         https://bugs.webkit.org/show_bug.cgi?id=194839
3751         <rdar://problem/48219609>
3752
3753         Reviewed by Alexey Proskuryakov.
3754
3755         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3756         emit each project's build time to its output. E.g.,
3757
3758             ** BUILD SUCCEEDED ** [0.132 sec]
3759
3760         * Scripts/webkitdirs.pm:
3761         (XcodeOptions):
3762
3763 2019-02-19  Truitt Savell  <tsavell@apple.com>
3764
3765         Unreviewed, rolling out r241784.
3766
3767         Broke all OpenSource builds.
3768
3769         Reverted changeset:
3770
3771         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3772         instances view"
3773         https://bugs.webkit.org/show_bug.cgi?id=172848
3774         https://trac.webkit.org/changeset/241784
3775
3776 2019-02-19  Zalan Bujtas  <zalan@apple.com>
3777
3778         [LFC][Floats] Remove redundant intersecting logic
3779         https://bugs.webkit.org/show_bug.cgi?id=194804
3780
3781         Reviewed by Antti Koivisto.
3782
3783         * LayoutReloaded/misc/LFC-passing-tests.txt:
3784
3785 2019-02-19  Dean Jackson  <dino@apple.com>
3786
3787         Clean-up output from generate-xcfilelists so it can be filtered
3788         https://bugs.webkit.org/show_bug.cgi?id=194795
3789
3790         Reviewed by Joseph Pecoraro (and Keith Rollin).
3791
3792         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
3793         make a slight tweak to filter-build-webkit so such lines are marked
3794         as plain.
3795
3796         * Scripts/filter-build-webkit:
3797         * Scripts/generate-xcfilelists:
3798
3799 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3800
3801         pytest is not correctly auto-installed
3802         https://bugs.webkit.org/show_bug.cgi?id=194707
3803
3804         Reviewed by Carlos Garcia Campos.
3805
3806         * Scripts/webkitpy/thirdparty/__init__.py:
3807         (AutoinstallImportHook._install_pytest):
3808
3809 2019-02-18  Chris Dumez  <cdumez@apple.com>
3810
3811         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
3812         https://bugs.webkit.org/show_bug.cgi?id=194797
3813         <rdar://problem/48055151>
3814
3815         Reviewed by Geoffrey Garen.
3816
3817         Add API test coverage.
3818
3819         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3820
3821 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3822
3823         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
3824         https://bugs.webkit.org/show_bug.cgi?id=194670
3825         <rdar://problem/39066529>
3826
3827         Reviewed by Tim Horton.
3828
3829         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
3830         pasted in an editable area as attachment elements.
3831
3832         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3833         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3834         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
3835         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3836         (TestWebKitAPI::TEST):
3837         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3838         (WTR::InjectedBundlePage::InjectedBundlePage):
3839
3840 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3841
3842         Fix API test after r241728
3843        ​https://bugs.webkit.org/show_bug.cgi?id=194723
3844
3845         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3846         (TEST):
3847         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
3848
3849 2019-02-18  Daniel Bates  <dabates@apple.com>
3850
3851         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3852         https://bugs.webkit.org/show_bug.cgi?id=192824
3853         <rdar://problem/47100332>
3854
3855         Reviewed by Wenson Hsieh.
3856
3857         Fix a bug where the wrong usage code was used for F13 thru F24.
3858
3859         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3860         (keyCodeForDOMFunctionKey):
3861
3862 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
3863
3864         Bytecode cache should a have a boot-specific validation
3865         https://bugs.webkit.org/show_bug.cgi?id=194769
3866         <rdar://problem/48149509>
3867
3868         Reviewed by Keith Miller.
3869
3870         Add test for WTF::bootSessionUUIDString()
3871
3872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3873         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
3874         (TEST):
3875
3876 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3877
3878         Disable safe browsing in WKWebView and remove its WKPreferences API
3879         https://bugs.webkit.org/show_bug.cgi?id=194723
3880         <rdar://problem/48122993>
3881
3882         Reviewed by Geoffrey Garen.
3883
3884         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3885         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3886         (TEST):
3887         (safeBrowsingView):
3888         Make tests use SPI instead of API.
3889
3890 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3891
3892         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
3893         https://bugs.webkit.org/show_bug.cgi?id=194586
3894
3895         Reviewed by Ross Kirsling.
3896
3897         * DumpRenderTree/win/DumpRenderTree.cpp:
3898         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
3899         * Scripts/webkitpy/port/driver.py:
3900         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
3901
3902 2019-02-17  David Kilzer  <ddkilzer@apple.com>
3903
3904         Unreviewed, rolling out r241620.
3905
3906         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
3907         (Requested by ddkilzer on #webkit.)
3908
3909         Reverted changeset:
3910
3911         "[WTF] Add environment variable helpers"
3912         https://bugs.webkit.org/show_bug.cgi?id=192405
3913         https://trac.webkit.org/changeset/241620
3914
3915 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3916
3917         [LFC] RenderImage's default intrinsic size is 0.
3918         https://bugs.webkit.org/show_bug.cgi?id=194745
3919
3920         Reviewed by Antti Koivisto.
3921
3922         * LayoutReloaded/misc/LFC-passing-tests.txt:
3923
3924 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3925
3926         [LFC][BFC] Add support for block replaced intrinsic width.
3927         https://bugs.webkit.org/show_bug.cgi?id=194705
3928
3929         Reviewed by Simon Fraser.
3930
3931         * LayoutReloaded/misc/LFC-passing-tests.txt:
3932
3933 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3934
3935         [LFC] Apply min/max width constraints to preferred width computation
3936         https://bugs.webkit.org/show_bug.cgi?id=194739
3937
3938         Reviewed by Simon Fraser.
3939
3940         * LayoutReloaded/misc/LFC-passing-tests.txt:
3941
3942 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
3943
3944         [WTF] Add environment variable helpers
3945         https://bugs.webkit.org/show_bug.cgi?id=192405
3946
3947         Reviewed by Michael Catanzaro.
3948
3949         * DumpRenderTree/mac/DumpRenderTree.mm:
3950         (libraryPathForDumpRenderTree):
3951         * DumpRenderTree/win/DumpRenderTree.cpp:
3952         (libraryPathForDumpRenderTree):
3953         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3954         (setUpIOSLayoutTestCommunication):
3955         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3956         (beforeAll):
3957         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3958         (main):
3959         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3960         (WebKitTestBus::run):
3961         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3962         (WTR::getOutputDir):
3963         (WTR::initializeFontConfigSetting):
3964         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3965         (WTR::InjectedBundle::platformInitialize):
3966         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3967         (WTR::topLevelPath):
3968         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3969         (WTR::topLevelPath):
3970         (WTR::getOutputDir):
3971         (WTR::activateFonts):
3972         * WebKitTestRunner/TestController.cpp:
3973         (WTR::TestController::libraryPathForTesting):
3974         (WTR::TestController::generateContextConfiguration const):
3975         (WTR::TestController::generatePageConfiguration):
3976         (WTR::TestController::decideDestinationWithSuggestedFilename):
3977         (WTR::TestController::platformAdjustContext):
3978         * WebKitTestRunner/TestController.h:
3979         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3980         (WTR::TestController::cocoaPlatformInitialize):
3981         (WTR::TestController::platformAdjustContext):
3982         * WebKitTestRunner/gtk/main.cpp:
3983         (main):
3984         * WebKitTestRunner/mac/TestControllerMac.mm:
3985         (WTR::TestController::configureContentExtensionForTest):
3986         * WebKitTestRunner/wpe/main.cpp:
3987         (main):
3988         Utilize WTF::Environment where possible.
3989
3990 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3991
3992         [iOS] WKWebView callout bar is missing Change Writing Direction item
3993         https://bugs.webkit.org/show_bug.cgi?id=190015
3994         <rdar://problem/44810366>
3995
3996         Reviewed by Tim Horton.
3997
3998         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
3999         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
4000
4001         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
4002         (TestWebKitAPI::TEST):
4003
4004 2019-02-15  Chris Dumez  <cdumez@apple.com>
4005
4006         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
4007         https://bugs.webkit.org/show_bug.cgi?id=194717
4008         <rdar://problem/47884404>
4009
4010         Reviewed by Brady Eidson.
4011
4012         Add API test coverage.
4013
4014         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4015
4016 2019-02-15  Youenn Fablet  <youenn@apple.com>
4017
4018         Make navigator.mediaDevices SecureContext
4019         https://bugs.webkit.org/show_bug.cgi?id=194666
4020
4021         Reviewed by Eric Carlson.
4022
4023         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4024         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4025         (TEST_F):
4026
4027 2019-02-15  Brian Burg  <bburg@apple.com>
4028
4029         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4030         https://bugs.webkit.org/show_bug.cgi?id=194411
4031         <rdar://problem/47787614>
4032
4033         Reviewed by Joseph Pecoraro.
4034
4035         Remove unnecessary soft linking macro usage.
4036
4037         * DumpRenderTree/mac/TestRunnerMac.mm:
4038         (TestRunner::inspectorTestStubURL):
4039         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4040         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4041         (WTR::TestRunner::inspectorTestStubURL):
4042
4043 2019-02-15  Commit Queue  <commit-queue@webkit.org>
4044
4045         Unreviewed, rolling out r241559 and r241566.
4046         https://bugs.webkit.org/show_bug.cgi?id=194710
4047
4048         Causes layout test crashes under GuardMalloc (Requested by
4049         ryanhaddad on #webkit).
4050
4051         Reverted changesets:
4052
4053         "[WTF] Add environment variable helpers"
4054         https://bugs.webkit.org/show_bug.cgi?id=192405
4055         https://trac.webkit.org/changeset/241559
4056
4057         "Unreviewed build fix for WinCairo Debug after r241559."
4058         https://trac.webkit.org/changeset/241566
4059
4060 2019-02-15  Zalan Bujtas  <zalan@apple.com>
4061
4062         [LFC] Out-of-flow box is never a float box
4063         https://bugs.webkit.org/show_bug.cgi?id=194704
4064
4065         Reviewed by Antti Koivisto.
4066
4067         * LayoutReloaded/misc/LFC-passing-tests.txt:
4068
4069 2019-02-10  Darin Adler  <darin@apple.com>
4070
4071         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
4072         https://bugs.webkit.org/show_bug.cgi?id=194487
4073
4074         Reviewed by Daniel Bates.
4075
4076         * DumpRenderTree/win/DumpRenderTree.cpp:
4077         (applicationId): Use makeString instead of String::format.
4078         (main): Ditto.
4079         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4080         (TestWebKitAPI::Util::createURLForResource): Ditto.
4081         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
4082         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
4083
4084         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4085         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
4086         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
4087         (WTR::createStringWithAttributes): Use appendLiteral.
4088         (WTR::AccessibilityUIElement::helpText const): Ditto.
4089         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
4090         directly instead of using String::format.
4091         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
4092         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
4093
4094 2019-02-15  Truitt Savell  <tsavell@apple.com>
4095
4096         Unreviewed, rolling out r241564.
4097
4098         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
4099
4100         Reverted changeset:
4101
4102         "[Mac] WebInspectorUI.framework does not need to be soft-
4103         linked anymore"
4104         https://bugs.webkit.org/show_bug.cgi?id=194411
4105         https://trac.webkit.org/changeset/241564
4106
4107 2019-02-15  Saam barati  <sbarati@apple.com>
4108
4109         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
4110         https://bugs.webkit.org/show_bug.cgi?id=194036
4111
4112         Reviewed by Yusuke Suzuki.
4113
4114         * Scripts/run-jsc-stress-tests:
4115
4116 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4117
4118         Fix the build.
4119
4120         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4121         (WTR::UIScriptController::drawSquareInEditableImage):
4122         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4123         (TestWebKitAPI::drawSquareInEditableImage):
4124
4125 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4126
4127         Fix the build.
4128
4129         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4130         (WTR::UIScriptController::drawSquareInEditableImage):
4131         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4132         (TestWebKitAPI::drawSquareInEditableImage):
4133
4134 2019-02-14  Brian Burg  <bburg@apple.com>
4135
4136         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4137         https://bugs.webkit.org/show_bug.cgi?id=194411
4138         <rdar://problem/47787614>
4139
4140         Reviewed by Joseph Pecoraro.
4141
4142         Remove unnecessary soft linking macro usage.
4143
4144         * DumpRenderTree/mac/TestRunnerMac.mm:
4145         (TestRunner::inspectorTestStubURL):
4146         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4147         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4148         (WTR::TestRunner::inspectorTestStubURL):
4149
4150 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
4151
4152         [ews-app] status bubble should fetch builder name info from BuilderMapping table
4153         https://bugs.webkit.org/show_bug.cgi?id=194599
4154
4155         Reviewed by Lucas Forschler.
4156
4157         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4158         (StatusBubble._build_bubble):
4159
4160 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
4161
4162         [ews-app] Set Foreign Key in Django build model
4163         https://bugs.webkit.org/show_bug.cgi?id=194667
4164
4165         Reviewed by Lucas Forschler.
4166
4167         * BuildSlaveSupport/ews-app/ews/models/build.py:
4168         (Build):
4169
4170 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
4171
4172         [WTF] Add environment variable helpers
4173         https://bugs.webkit.org/show_bug.cgi?id=192405
4174
4175         Reviewed by Michael Catanzaro.
4176
4177         * DumpRenderTree/mac/DumpRenderTree.mm:
4178         (libraryPathForDumpRenderTree):
4179         * DumpRenderTree/win/DumpRenderTree.cpp:
4180         (libraryPathForDumpRenderTree):
4181         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4182         (setUpIOSLayoutTestCommunication):
4183         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4184         (TestWebKitAPI::strip):
4185         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4186         (beforeAll):
4187         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4188         (main):
4189         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4190         (WebKitTestBus::run):
4191         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4192         (WTR::getOutputDir):
4193         (WTR::initializeFontConfigSetting):
4194         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4195         (WTR::InjectedBundle::platformInitialize):
4196         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4197         (WTR::topLevelPath):
4198         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4199         (WTR::topLevelPath):
4200         (WTR::getOutputDir):
4201         (WTR::activateFonts):
4202         * WebKitTestRunner/TestController.cpp:
4203         (WTR::TestController::libraryPathForTesting):
4204         (WTR::TestController::generateContextConfiguration const):
4205         (WTR::TestController::generatePageConfiguration):
4206         (WTR::TestController::decideDestinationWithSuggestedFilename):
4207         (WTR::TestController::platformAdjustContext):
4208         * WebKitTestRunner/TestController.h:
4209         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4210         (WTR::TestController::cocoaPlatformInitialize):
4211         (WTR::TestController::platformAdjustContext):
4212         * WebKitTestRunner/gtk/main.cpp:
4213         (main):
4214         * WebKitTestRunner/mac/TestControllerMac.mm:
4215         (WTR::TestController::configureContentExtensionForTest):
4216         * WebKitTestRunner/wpe/main.cpp:
4217         (main):
4218         Utilize WTF::Environment where possible.
4219
4220 2019-02-14  Chris Dumez  <cdumez@apple.com>
4221
4222         [PSON] Introduce a WebContent Process cache
4223         https://bugs.webkit.org/show_bug.cgi?id=194594
4224         <rdar://problem/46793397>
4225
4226         Reviewed by Geoff Garen.
4227
4228         Update API tests to turn on the WebContent Process cache.
4229
4230         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4231
4232 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
4233
4234         Unreviewed, build fix after r241480
4235
4236         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4237         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
4238         (-[DragAndDropSimulator initWithWebView:]):
4239
4240 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
4241
4242         AX: ARIA Reflection was disabled in error
4243         https://bugs.webkit.org/show_bug.cgi?id=194647
4244         <rdar://problem/48068336>
4245
4246         Reviewed by Ryosuke Niwa.
4247
4248         Remove test override now that this feature should be enabled by default.
4249
4250         * WebKitTestRunner/TestController.cpp:
4251         (WTR::TestController::resetPreferencesToConsistentValues):
4252
4253 2019-02-14  Commit Queue  <commit-queue@webkit.org>
4254
4255         Unreviewed, rolling out r241486.
4256         https://bugs.webkit.org/show_bug.cgi?id=194655
4257
4258         causing API failures in builds (Requested by ShawnRoberts on
4259         #webkit).
4260
4261         Reverted changeset:
4262
4263         "[Cocoa] Media elements will restart network buffering just
4264         before suspending"
4265         https://bugs.webkit.org/show_bug.cgi?id=193691
4266         https://trac.webkit.org/changeset/241486
4267
4268 2019-02-14  Zalan Bujtas  <zalan@apple.com>
4269
4270         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
4271         https://bugs.webkit.org/show_bug.cgi?id=194622
4272
4273         Reviewed by Antti Koivisto.
4274
4275         * LayoutReloaded/misc/LFC-passing-tests.txt:
4276
4277 2019-02-14  Zalan Bujtas  <zalan@apple.com>
4278
4279         [LFC] Shrink-to-fit-width should be constrained by min/max width
4280         https://bugs.webkit.org/show_bug.cgi?id=194653
4281
4282         Reviewed by Antti Koivisto.
4283
4284         * LayoutReloaded/misc/LFC-passing-tests.txt:
4285
4286 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
4287
4288         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
4289         https://bugs.webkit.org/show_bug.cgi?id=194641
4290
4291         Reviewed by Geoffrey Garen.
4292
4293         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
4294         so that the test would fail without this fix.
4295
4296         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
4297         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
4298
4299 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
4300
4301         [ews-app] Change log level for a log statement
4302
4303         Unreviewed minor fix.
4304
4305         * BuildSlaveSupport/ews-app/ews/models/patch.py:
4306         (Patch.save_patch):
4307
4308 2019-02-13  Jer Noble  <jer.noble@apple.com>
4309
4310         [Cocoa] Media elements will restart network buffering just before suspending
4311         https://bugs.webkit.org/show_bug.cgi?id=193691
4312
4313         Reviewed by Eric Carlson.
4314
4315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4316         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4317         (TEST):
4318
4319 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
4320
4321         [ews-app] Fetch builder id to name mapping
4322         https://bugs.webkit.org/show_bug.cgi?id=194355
4323
4324         Reviewed by Lucas Forschler.
4325
4326         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
4327         (Buildbot.get_builder_id_to_name_mapping):
4328         (Buildbot._get_display_name_from_builder_name):
4329
4330 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
4331
4332         Further restricting webarchive loads
4333         https://bugs.webkit.org/show_bug.cgi?id=194567
4334         <rdar://problem/47610130>
4335
4336         Reviewed by Youenn Fablet.
4337
4338         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
4339         navigations on drop.
4340
4341         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4342         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
4343         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
4344         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
4345         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
4346         (TestWebKitAPI::TEST):
4347         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
4348         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
4349         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
4350         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
4351         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
4352         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
4353         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
4354
4355 2019-02-13  John Wilander  <wilander@apple.com>
4356
4357         Store Ad Click Attribution requests in the network process
4358         https://bugs.webkit.org/show_bug.cgi?id=194510
4359         <rdar://problem/47650118>
4360
4361         Reviewed by Alex Christensen and Daniel Bates.
4362
4363         This patch adds two TestRunner functions: