[Resource Timing] Enable Resource Timing by default in Tests
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
2
3         [Resource Timing] Enable Resource Timing by default in Tests
4         https://bugs.webkit.org/show_bug.cgi?id=168145
5
6         Reviewed by Ryosuke Niwa.
7
8         * DumpRenderTree/mac/DumpRenderTree.mm:
9         (resetWebPreferencesToConsistentValues):
10         * DumpRenderTree/win/DumpRenderTree.cpp:
11         (resetWebPreferencesToConsistentValues):
12         * WebKitTestRunner/TestController.cpp:
13         (WTR::TestController::resetPreferencesToConsistentValues):
14
15 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
16
17         Removing LayoutTestRelay
18         https://bugs.webkit.org/show_bug.cgi?id=165927
19
20         Reviewed by Daniel Bates.
21         Part 2
22
23         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
24         simulators through simctl (iOS 10 and later), use this functionality instead.
25
26         * BuildSlaveSupport/built-product-archive:
27         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
28         Added a FIXME that we will need to implement similar archiving machinery once we build
29         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
30         * BuildSlaveSupport/kill-old-processes:
31         (main): Remove LayoutTestRelay from list of processes.
32         * LayoutTestRelay: Removed LayoutTestRelay.
33         * Makefile:
34         * Scripts/build-layouttestrelay: Removed.
35         * Scripts/build-webkit: Removed LayoutTestRelay references.
36
37 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
38
39         [WebCrypto] Add WebCryptoAPI to watchlist
40         https://bugs.webkit.org/show_bug.cgi?id=168138
41
42         Reviewed by Youenn Fablet.
43
44         * Scripts/webkitpy/common/config/watchlist:
45
46 2017-02-10  Brady Eidson  <beidson@apple.com>
47
48         Replace all WebKit Library Version checks in WK2 with SDK version checks.
49         https://bugs.webkit.org/show_bug.cgi?id=168124
50
51         Reviewed by Geoffrey Garen.
52
53         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
54         
55         * MiniBrowser/mac/main.m:
56         (main):
57         * MobileMiniBrowser/MobileMiniBrowser/main.m:
58         (main):
59         * TestWebKitAPI/ios/mainIOS.mm:
60         (main):
61         * TestWebKitAPI/mac/mainMac.mm:
62         (main):
63         * WebKitTestRunner/ios/mainIOS.mm:
64         (main):
65         * WebKitTestRunner/mac/main.mm:
66         (setDefaultsToConsistentValuesForTesting):
67
68 2017-02-10  Alex Christensen  <achristensen@webkit.org>
69
70         Fix El Capitan build.
71
72         * Scripts/build-webkit:
73         Don't build libwebrtc anywhere for now.
74
75 2017-02-10  Andy Estes  <aestes@apple.com>
76
77         Move two MiniBrowserBundle settings out of the .pbxproj
78         https://bugs.webkit.org/show_bug.cgi?id=168106
79
80         Reviewed by Tim Horton.
81
82         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
83         the project file. This removes the project file override.
84
85         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
86
87         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
88         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
89
90 2017-02-10  Alex Christensen  <achristensen@webkit.org>
91
92         Fix 32-and-64-bit build on El Capitan.
93
94         * Scripts/build-webkit:
95         Somebody's building with something like this:
96         build-webkit ARCHS="i386 x86_64"
97         We want this to also not build libwebrtc for now.
98
99 2017-02-10  Alex Christensen  <achristensen@webkit.org>
100
101         Fix 32-bit build on El Capitan.
102
103         * Scripts/build-webkit:
104         The bot uses ARCHS=i386 instead of --32-bit.
105         This is a hack, but it should fix the bot until I can do a better fix in the morning.
106
107 2017-02-10  Alex Christensen  <achristensen@webkit.org>
108
109         Fix 32-bit build on El Capitan.
110
111         * Scripts/build-webkit:
112         Don't build i386 libwebrtc.
113
114 2017-02-09  Alex Christensen  <achristensen@webkit.org>
115
116         Unreviewed, rolling out r212040.
117
118         Broke build.  I'm not surprised
119
120         Reverted changeset:
121
122         "[WebRTC][Mac] Activate libwebrtc"
123         https://bugs.webkit.org/show_bug.cgi?id=167293
124         http://trac.webkit.org/changeset/212040
125
126 2017-02-09  Alex Christensen  <achristensen@webkit.org>
127
128         Build libwebrtc on bots without using it yet
129         https://bugs.webkit.org/show_bug.cgi?id=168062
130
131         Reviewed by Brent Fulgham.
132
133         * Scripts/build-webkit:
134
135 2017-02-09  Alex Christensen  <achristensen@webkit.org>
136
137         Don't build libwebrtc.
138
139         * Scripts/build-webkit:
140         Not ready yet.  It broke El Capitan and iOS.
141
142 2017-02-09  Alex Christensen  <achristensen@webkit.org>
143
144         Build libwebrtc on bots without using it yet
145         https://bugs.webkit.org/show_bug.cgi?id=168062
146
147         Reviewed by Brent Fulgham.
148
149         * Scripts/build-webkit:
150
151 2017-02-09  Alex Christensen  <achristensen@webkit.org>
152
153         Rename isAppleMacWebKit to isAppleCocoaWebKit
154         https://bugs.webkit.org/show_bug.cgi?id=168075
155
156         Reviewed by Geoffrey Garen.
157
158         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
159
160         * Scripts/build-api-tests:
161         * Scripts/build-dumprendertree:
162         * Scripts/build-jsc:
163         (buildMyProject):
164         * Scripts/build-layouttestrelay:
165         * Scripts/build-webkit:
166         * Scripts/build-webkittestrunner:
167         * Scripts/run-api-tests:
168         (isSupportedPlatform):
169         (runTest):
170         (listAllTests):
171         (prepareEnvironmentForRunningTestTool):
172         * Scripts/run-content-extension-tester:
173         * Scripts/run-javascriptcore-tests:
174         * Scripts/run-minibrowser:
175         * Scripts/show-pretty-diff:
176         * Scripts/webkitdirs.pm:
177         (determineBaseProductDir):
178         (determineArchitecture):
179         (determinePassedArchitecture):
180         (safariPath):
181         (builtDylibPathForName):
182         (checkFrameworks):
183         (isAppleWebKit):
184         (isAppleCocoaWebKit):
185         (determineNmPath):
186         (launcherName):
187         (wrapperPrefixIfNeeded):
188         (isCMakeBuild):
189         (mobileSafariBundle):
190         (debugSafari):
191         (runSafari):
192         (runMiniBrowser):
193         (debugMiniBrowser):
194         (runWebKitTestRunner):
195         (debugWebKitTestRunner):
196         (isAppleMacWebKit): Deleted.
197         * Scripts/webkitperl/FeatureList.pm:
198
199 2017-02-09  Alex Christensen  <achristensen@webkit.org>
200
201         Revert r211991
202         https://bugs.webkit.org/show_bug.cgi?id=168062
203
204         * Scripts/build-webkit:
205         Not quite ready yet.
206
207 2017-02-09  Alex Christensen  <achristensen@webkit.org>
208
209         Build libwebrtc on bots without using it yet
210         https://bugs.webkit.org/show_bug.cgi?id=168062
211
212         Reviewed by Brent Fulgham.
213
214         * Scripts/build-webkit:
215         Build libwebrtc on Mac when we build ANGLE.
216
217 2017-02-09  Youenn Fablet  <youenn@apple.com>
218
219         Improve W3C importer command line options
220         https://bugs.webkit.org/show_bug.cgi?id=167448
221
222         Reviewed by Ryosuke Niwa.
223
224         Making the list of test paths to import the main arguments of the script.
225         Allow passing the source directory to import as a -s option.
226         Adding a warning when given test paths are skipped by default in ImportExpectations.
227
228         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
229         Link conversion rules do not change when imported tests are downloaded by the script.
230
231         * Scripts/webkitpy/w3c/test_importer.py:
232         (main):
233         (parse_args):
234         (TestImporter.__init__):
235         (TestImporter.do_import):
236         (TestImporter):
237         (TestImporter.check_imported_expectations):
238
239 2017-02-08  Chris Dumez  <cdumez@apple.com>
240
241         Update web-platform-tests resources
242         https://bugs.webkit.org/show_bug.cgi?id=168026
243
244         Reviewed by Youenn Fablet.
245
246         Stop copying testharness.js from resources/ to web-platform-tests/resources.
247
248         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
249         (WebPlatformTestServer._copy_webkit_test_files):
250
251 2017-02-08  Andy Estes  <aestes@apple.com>
252
253         Custom protocols should not continue loading after a network process crash
254         https://bugs.webkit.org/show_bug.cgi?id=168028
255         <rdar://problem/27607520>
256
257         Reviewed by Brady Eidson.
258
259         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
260         (processGroup):
261         (-[CloseWhileStartingProtocol startLoading]):
262         (-[CloseWhileStartingProtocol stopLoading]):
263         (TestWebKitAPI::runTest):
264         (TestWebKitAPI::TEST):
265
266 2017-02-08  Dan Bernstein  <mitz@apple.com>
267
268         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
269         https://bugs.webkit.org/show_bug.cgi?id=168031
270
271         Reviewed by Tim Horton.
272
273         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
274         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
275         (TEST):
276         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
277         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
278
279 2017-02-08  Chris Dumez  <cdumez@apple.com>
280
281         Use smaller tiles in windows that are not active to facilitate App Napping
282         https://bugs.webkit.org/show_bug.cgi?id=167997
283         <rdar://problem/30358835>
284
285         Reviewed by Simon Fraser.
286
287         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
288         (WTR::PlatformWebView::setWindowIsKey):
289         Actually update windowIsKey state of NSWindow so the WebView
290         properly updates its activity state.
291
292 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
293
294         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
295         https://bugs.webkit.org/show_bug.cgi?id=167942
296         <rdar://problem/30315079>
297
298         Reviewed by Tim Horton.
299
300         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
301         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
302         contenteditable in these cases.
303
304         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
305         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
306         performDragOperation:) directly.
307
308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
309         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
310         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
311         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
312         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
313         (-[DragSource draggingSourceOperationMaskForLocal:]):
314         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
315         (-[DragInfo lastMousePosition]):
316         (-[DragInfo setLastMousePosition:]):
317         (-[DragInfo draggingDestinationWindow]):
318         (-[DragInfo draggingSourceOperationMask]):
319         (-[DragInfo draggingLocation]):
320         (-[DragInfo draggedImageLocation]):
321         (-[DragInfo draggedImage]):
322         (-[DragInfo draggingPasteboard]):
323         (-[DragInfo draggingSource]):
324         (-[DragInfo draggingSequenceNumber]):
325         (-[DragInfo slideDraggedImageTo:]):
326         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
327         (-[DragInfo draggingFormation]):
328         (-[DragInfo setDraggingFormation:]):
329         (-[DragInfo animatesToDestination]):
330         (-[DragInfo setAnimatesToDestination:]):
331         (-[DragInfo numberOfValidItemsForDrop]):
332         (-[DragInfo setNumberOfValidItemsForDrop:]):
333         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
334         (-[DragInfo springLoadingHighlight]):
335         (-[DragInfo resetSpringLoading]):
336         (TestWebKitAPI::getTestImage):
337         (TestWebKitAPI::webViewAfterPerformingDragOperation):
338         (TestWebKitAPI::TEST):
339         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
340
341 2017-02-08  Jer Noble  <jer.noble@apple.com>
342
343         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
344         https://bugs.webkit.org/show_bug.cgi?id=168007
345
346         Reviewed by Alex Christensen.
347
348         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
349         (didFinishLoadForFrame):
350         (TestWebKitAPI::TEST):
351
352 2017-02-08  Commit Queue  <commit-queue@webkit.org>
353
354         Unreviewed, rolling out r211873.
355         https://bugs.webkit.org/show_bug.cgi?id=168001
356
357         It's in jhbuild for consistent layout tests (Requested by
358         mcatanzaro on #webkit).
359
360         Reverted changeset:
361
362         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
363         https://bugs.webkit.org/show_bug.cgi?id=167993
364         http://trac.webkit.org/changeset/211873
365
366 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
367
368         [GTK] Add icu packages to Tools/gtk/install-dependencies
369         https://bugs.webkit.org/show_bug.cgi?id=167993
370
371         Reviewed by Michael Catanzaro.
372
373         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
374         depending in the GNU/Linux distribution)
375
376 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
377
378         Update flakiness dashboard configuration.
379         https://bugs.webkit.org/show_bug.cgi?id=167957
380
381         Reviewed by Alexey Proskuryakov.
382
383         * TestResultServer/static-dashboards/builders.jsonp:
384
385 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
386
387         Replace a bot that has an incorrect configuration.
388         https://bugs.webkit.org/show_bug.cgi?id=167747
389
390         Rubber-stamped by Alexey Proskuryakov.
391
392         * BuildSlaveSupport/build.webkit.org-config/config.json:
393
394 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
395
396         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
397         https://bugs.webkit.org/show_bug.cgi?id=167927
398
399         Reviewed by Brent Fulgham.
400
401         Enable ComplexTextController API tests on the Win and GTK ports.
402
403         * TestWebKitAPI/PlatformGTK.cmake:
404         * TestWebKitAPI/PlatformWin.cmake:
405
406 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
407
408         File index appended to previous file in svn-create-patch with SVN 1.9
409         https://bugs.webkit.org/show_bug.cgi?id=167903
410         <rdar://problem/30387395>
411
412         Reviewed by Daniel Bates.
413
414         * Scripts/VCSUtils.pm:
415         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
416         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
417         trailing newline character from the expected result before comparing it to the actual result.
418
419 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
420
421         [webkitdirs] remove unused host_processor variable in determineArchitecture()
422         https://bugs.webkit.org/show_bug.cgi?id=167936
423
424         Reviewed by Michael Catanzaro.
425
426         * Scripts/webkitdirs.pm:
427         (determineArchitecture):
428         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
429         since r195083.
430
431 2017-02-07  Youenn Fablet  <youenn@apple.com>
432
433         Use a JSON file to define which WPT files/folders to import
434         https://bugs.webkit.org/show_bug.cgi?id=167923
435
436         Reviewed by Alex Christensen.
437
438         * Scripts/webkitpy/w3c/test_downloader.py:
439         (TestDownloader.__init__):
440         (TestDownloader._init_paths_from_expectations):
441         * Scripts/webkitpy/w3c/test_importer.py:
442         (parse_args):
443         * Scripts/webkitpy/w3c/test_importer_unittest.py:
444
445 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
446
447         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
448         https://bugs.webkit.org/show_bug.cgi?id=167916
449
450         Reviewed by Carlos Garcia Campos.
451
452         URL of mesa-11.0.6.tar.xz has been moved.
453
454         * gtk/jhbuild.modules: Fix the module path.
455
456 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
457
458         Static Analyzer: Address some leaks in MiniBrowser
459         https://bugs.webkit.org/show_bug.cgi?id=167897
460
461         Reviewed by Alexey Proskuryakov.
462
463         * MiniBrowser/mac/BrowserWindowController.m:
464         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
465         * MiniBrowser/mac/ExtensionManagerWindowController.m:
466         (-[ExtensionManagerWindowController add:]):
467         (-[ExtensionManagerWindowController remove:]):
468         * MiniBrowser/mac/SettingsController.m:
469         (-[SettingsController _populateMenu]):
470         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
471         Address obvious leaks caught by the static analyzer.
472
473 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
474
475         Migrate ComplexTextController to use platform-independent types
476         https://bugs.webkit.org/show_bug.cgi?id=167833
477
478         Reviewed by Brent Fulgham.
479
480         Migrate tests away from platform-dependent types.
481
482         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
483         (TestWebKitAPI::TEST_F):
484
485 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
486
487         Correct File Path Handling in SecurityOrigin and FileSystem
488         https://bugs.webkit.org/show_bug.cgi?id=167894
489         <rdar://problem/30380080>
490
491         Reviewed by Alexey Proskuryakov.
492
493         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
494         and perform same-volume checks using filesystem-compatible paths.        
495         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
496         filesystem paths, and perform validation of same-volume checks.
497         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
498         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
499         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
500         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
501
502 2017-02-06  Jer Noble  <jer.noble@apple.com>
503
504         Playback stalls when a SourceBuffer append causes frame eviction
505         https://bugs.webkit.org/show_bug.cgi?id=167834
506
507         Reviewed by Eric Carlson.
508
509         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
510         for the WTF::MediaTime class.
511
512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
513         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
514         (TestWebKitAPI::TEST):
515         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
516         (WTF::operator<<):
517         (TestWebKitAPI::TestSample::create):
518         (TestWebKitAPI::TestSample::TestSample):
519         (TestWebKitAPI::TEST_F):
520
521 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
522
523         Change capitalization in platform name after r211735.
524
525         Unreviewed dashboard fix.
526
527         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
528         (WebKitBuildbot):
529
530 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
531
532         Move the Leaks bot to Sierra
533         https://bugs.webkit.org/show_bug.cgi?id=167886
534
535         Reviewed by Daniel Bates.
536
537         * BuildSlaveSupport/build.webkit.org-config/config.json:
538         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
539         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
540         (LeaksViewer._displayURLPrompt):
541         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
542         (WebKitBuildbot):
543
544 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
545
546         Prevent app crash on launch during simctl install workaround
547         https://bugs.webkit.org/show_bug.cgi?id=167685
548
549         Reviewed by Daniel Bates.
550
551         * Scripts/webkitpy/port/simulator_process.py:
552         (SimulatorProcess.__init__): Pass environment to install.
553         * Scripts/webkitpy/xcode/simulator.py:
554         (Device.install_app): Accept environment, pass environment to launch.
555
556 2017-02-06  Alex Christensen  <achristensen@webkit.org>
557
558         Rebase API tests after r211638
559         https://bugs.webkit.org/show_bug.cgi?id=167779
560
561         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
562         (TestWebKitAPI::TEST_F):
563         URLs with non-special schemes and characters like % in the host now fail to parse,
564         more like their special counterparts and according to spec.
565
566 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
567
568         Unreviewed trivial fix after r211697.
569         https://bugs.webkit.org/show_bug.cgi?id=167863
570
571         * Scripts/run-javascriptcore-tests:
572         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
573
574 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
575
576         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
577         https://bugs.webkit.org/show_bug.cgi?id=167850
578
579         Reviewed by Tim Horton.
580
581         * DumpRenderTree/TestRunner.cpp:
582         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
583
584 2017-02-04  Andreas Kling  <akling@apple.com>
585
586         Plug some leaks in TestController and UIScriptContext.
587         <https://webkit.org/b/167839>
588
589         Reviewed by Alexey Proskuryakov.
590
591         Fix a couple of the leaks seen on the leaks bot.
592
593         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
594         (UIScriptContext::runUIScript):
595         * WebKitTestRunner/TestController.cpp:
596         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
597         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
598
599 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
600
601         WK1 mouse events are missing movementX and movementY for pointerlock.
602         https://bugs.webkit.org/show_bug.cgi?id=167775
603         rdar://problem/30343810
604
605         Reviewed by Alexey Proskuryakov.
606
607         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
608
609         * DumpRenderTree/mac/EventSendingController.mm:
610         (-[EventSendingController mouseMoveToX:Y:]):
611         * WebKitTestRunner/mac/EventSenderProxy.mm:
612         (WTR::EventSenderProxy::mouseMoveTo):
613
614 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
615
616         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
617         https://bugs.webkit.org/show_bug.cgi?id=167774
618
619         Reviewed by Tim Horton.
620
621         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
622         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
623         web process are async, so the callback fires after the web process gets the new state.
624
625         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
626         (WTR::UIScriptController::removeViewFromWindow):
627         (WTR::UIScriptController::addViewToWindow):
628         * DumpRenderTree/mac/DumpRenderTree.mm:
629         (createWebViewAndOffscreenWindow):
630         (resetWebViewToConsistentStateBeforeTesting):
631         * DumpRenderTree/mac/DumpRenderTreeMac.h:
632         * DumpRenderTree/mac/UIScriptControllerMac.mm:
633         (WTR::UIScriptController::removeViewFromWindow):
634         (WTR::UIScriptController::addViewToWindow):
635         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
636         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
637         (WTR::UIScriptController::removeViewFromWindow):
638         (WTR::UIScriptController::addViewToWindow):
639         * TestRunnerShared/UIScriptContext/UIScriptController.h:
640         * WebKitTestRunner/PlatformWebView.h:
641         * WebKitTestRunner/TestController.cpp:
642         (WTR::TestController::resetStateToConsistentValues):
643         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
644         (WTR::PlatformWebView::removeFromWindow):
645         (WTR::PlatformWebView::addToWindow):
646         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
647         (WTR::UIScriptController::removeViewFromWindow):
648         (WTR::UIScriptController::addViewToWindow):
649         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
650         (WTR::PlatformWebView::removeFromWindow):
651         (WTR::PlatformWebView::addToWindow):
652         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
653         (WTR::UIScriptController::removeViewFromWindow):
654         (WTR::UIScriptController::addViewToWindow):
655
656 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
657
658         Remove check for SkipSafariExecutableEntitlementChecks
659         https://bugs.webkit.org/show_bug.cgi?id=167762
660
661         Reviewed by Dan Bernstein.
662
663         Follow-up fix: don't break internal behavior.
664
665         * Scripts/webkitdirs.pm:
666         (safariPath):
667         (executableHasEntitlements): Deleted.
668         (safariPathFromSafariBundle): Deleted.
669         (installedSafariPath): Deleted.
670
671 2017-02-03  Daniel Bates  <dabates@apple.com>
672
673         [Mac][WK2] Add SPI to override the Content Security Policy of a page
674         https://bugs.webkit.org/show_bug.cgi?id=167810
675         <rdar://problem/30102568>
676
677         Reviewed by Anders Carlsson.
678
679         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
680
681         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
682         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
683         (TEST):
684         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
685         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
686         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
687         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
688
689 2017-02-02  Alex Christensen  <achristensen@webkit.org>
690
691         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
692         https://bugs.webkit.org/show_bug.cgi?id=167773
693         <rdar://problem/30221102>
694
695         Reviewed by Ryosuke Niwa.
696
697         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
698         (TestWebKitAPI::TEST_F):
699
700 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
701
702         Remove check for SkipSafariExecutableEntitlementChecks
703         https://bugs.webkit.org/show_bug.cgi?id=167762
704         rdar://problem/22480673
705
706         Reviewed by Dan Bernstein.
707
708         * Scripts/webkitdirs.pm:
709         (safariPathFromSafariBundle):
710         (skipSafariExecutableEntitlementChecks): Deleted.
711
712 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
713
714         Undefined subroutine in svn-create-patch
715         https://bugs.webkit.org/show_bug.cgi?id=167742
716
717         Unreviewed build-fix after r211543.
718
719         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
720
721 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
722
723         Unreviewed. Fix jhbuild dependencies build.
724
725         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
726         Patch updated.
727
728 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
729
730         [EME][GStreamer] Fixed decryptor selection
731         https://bugs.webkit.org/show_bug.cgi?id=167588
732
733         Reviewed by Žan Doberšek.
734
735         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
736
737         * gtk/jhbuild.modules: Added patches to gstreamer and
738         gst-plugins-good packages.
739         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
740         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
741
742 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
743
744         Make run-benchmark script supports 'config' key in test plan.
745         https://bugs.webkit.org/show_bug.cgi?id=167715
746
747         Reviewed by Ryosuke Niwa.
748
749         Add support for 'config' key in test paln.
750         'config' key is a dictionary that specifies environment configurations while test is running.
751         Specifies orientation to be portrait in MotionMark benchmark.
752
753         * Scripts/webkitpy/benchmark_runner/README.md:
754         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
755         (BenchmarkRunner.__init__):
756         (BenchmarkRunner._run_benchmark):
757         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
758         (BrowserDriver.prepare_env):
759         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
760         (LinuxBrowserDriver.prepare_env):
761         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
762         (OSXBrowserDriver.prepare_env):
763         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
764         (OSXSafariDriver.prepare_env):
765         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
766
767 2017-02-01  Daniel Bates  <dabates@apple.com>
768
769         REGRESSION (r210820): svn-create-patch does not emit property change only diff
770         https://bugs.webkit.org/show_bug.cgi?id=167169
771
772         Reviewed by David Kilzer.
773
774         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
775         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
776         header from the output of "svn diff" on a file that was copied or moved.
777
778         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
779         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
780         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
781         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
782         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
783         of a file with only a property change also does not contain any chunk range lines. Therefore
784         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
785         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
786         we should directly test for the presence of a leading SVN diff header with an empty body and
787         remove such lines from the diff.
788
789         * Scripts/VCSUtils.pm:
790         (fixSVNPatchForAdditionWithHistory): Added.
791         * Scripts/svn-create-patch:
792         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
793         we have a non empty patch for an added file with history (i.e. a copied or moved file).
794         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
795
796 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
797
798         [Mac] Update CARingBuffer class
799         https://bugs.webkit.org/show_bug.cgi?id=167656
800
801         Reviewed by Jer Noble.
802
803         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
804         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
805         (TestWebKitAPI::CARingBufferTest::SetUp):
806         (TestWebKitAPI::CARingBufferTest::setup):
807         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
808         (TestWebKitAPI::CARingBufferTest::description):
809         (TestWebKitAPI::CARingBufferTest::bufferList):
810         (TestWebKitAPI::CARingBufferTest::ringBuffer):
811         (TestWebKitAPI::CARingBufferTest::capacity):
812         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
813         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
814         (TestWebKitAPI::TEST_F):
815         (TestWebKitAPI::MixingTest::run):
816
817 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
818
819         [Mac] TestWebKitAPI includes system frameworks incorrectly
820         https://bugs.webkit.org/show_bug.cgi?id=167703
821         rdar://problem/30301498
822
823         Reviewed by Ryosuke Niwa.
824
825         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
826         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
827
828         Also, reduced the number of subframework search paths, looks like we only need one now.
829
830         * TestWebKitAPI/Configurations/Base.xcconfig:
831
832 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
833
834         Correct "filesHaveSameVolume" predicate
835         https://bugs.webkit.org/show_bug.cgi?id=167696
836         <rdar://problem/30298722>
837
838         Reviewed by David Kilzer.
839
840         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
841         percent-escaped path inputs.
842
843         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
844         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
845         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
846         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
847         (TestWebKitAPI::TEST_F):
848
849 2017-02-01  Tomas Popela  <tpopela@redhat.com>
850
851         Unreviewed. Fix coding style in MiniBrowser
852
853         * MiniBrowser/gtk/BrowserWindow.c:
854         (editingCommandCallback):
855         (insertImageCommandCallback):
856         (insertLinkCommandCallback):
857
858 2017-02-01  Tomas Popela  <tpopela@redhat.com>
859
860         [GTK] Add an API to add a custom tab into the print dialog
861         https://bugs.webkit.org/show_bug.cgi?id=151998
862
863         Reviewed by Carlos Garcia Campos.
864
865         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
866         that is testing a newly added API.
867
868         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
869         (testPrintCustomWidget):
870         (beforeAll):
871
872 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
873
874         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
875         https://bugs.webkit.org/show_bug.cgi?id=166529
876
877         Reviewed by Xabier Rodriguez-Calvar.
878
879         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
880         New patch version accepted in GStreamer upstream.
881
882 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
883
884         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
885         https://bugs.webkit.org/show_bug.cgi?id=167498
886
887         Reviewed by Carlos Garcia Campos.
888
889         Depending on the distro version you can need either libxfont1-dev
890         or libfont-dev to build with jhbuild.
891
892         * gtk/install-dependencies:
893
894 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
895
896         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
897         https://bugs.webkit.org/show_bug.cgi?id=167594
898
899         Unreviewed test gardening.
900
901         Disabling this test while we investigate the cause of a timeout on ios-simulator.
902
903         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
904         (TEST):
905
906 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
907
908         Move slow-running microbenchmarks out of JSTests/microbenchmarks
909         https://bugs.webkit.org/show_bug.cgi?id=167676
910
911         Reviewed by Saam Barati.
912
913         * Scripts/run-javascriptcore-tests:
914         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
915
916 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
917
918         Make Dump Render Tree not crash
919         https://bugs.webkit.org/show_bug.cgi?id=167667
920
921         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
922         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
923         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
924         This does not fix any tests, it just fixes the crash.
925         
926         Reviewed by Simon Fraser.
927
928         * DumpRenderTree/TestRunner.cpp:
929         (TestRunner::callUIScriptCallback):
930
931 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
932
933         Workaround for simctl install failing to report install failure
934         https://bugs.webkit.org/show_bug.cgi?id=167654
935
936         Reviewed by Daniel Bates.
937
938         simctl install will sometimes report success even though install has failed.
939         To workaround this bug, we attempt an app launch after install to ensure
940         install has succeeded.
941
942         * Scripts/webkitpy/xcode/simulator.py:
943         (Device.install_app): Attempt app launch after install, retry install if launch fails.
944         (Device.launch_app): Correct comment.
945
946 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
947
948         Unreviewed webkitpy fix after r211405.
949
950         * Scripts/webkitpy/xcode/simulator.py:
951         (Device.launch_app): Remove @staticmethod on _log_debug_error.
952
953 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
954
955         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
956
957         * gtk/manifest.txt.in:
958
959 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
960
961         AX: enable search predication for iOS
962         https://bugs.webkit.org/show_bug.cgi?id=167558
963         <rdar://problem/30251367>
964
965         Reviewed by Joanmarie Diggs.
966
967         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
968         (AccessibilityUIElement::uiElementForSearchPredicate):
969         * DumpRenderTree/mac/AccessibilityCommonMac.h:
970         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
971         (searchPredicateParameterizedAttributeForSearchCriteria):
972         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
973         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
974         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
975         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
976         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
977         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
978         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
979         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
980         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
981         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
982         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
983
984 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
985
986         Workaround for simctl launch bug
987         https://bugs.webkit.org/show_bug.cgi?id=167613
988
989         Reviewed by Daniel Bates.
990
991         simctl launch will sometimes fail because of a race condition when many
992         simulators are being run simultaneously. These failures will always have
993         an exit code of 1. This change attempts to launch an app multiple times
994         before reporting a failure to workaround this bug.
995
996         * Scripts/webkitpy/xcode/simulator.py:
997         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
998
999 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
1000
1001         Commit queue fails to look at real name aliases for the reviewer
1002         https://bugs.webkit.org/show_bug.cgi?id=167422
1003
1004         Reviewed by Joseph Pecoraro.
1005
1006         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1007         (test_has_valid_reviewer): Added tests.
1008
1009         * Scripts/webkitpy/common/config/committers.py:
1010         (CommitterList._name_to_contributor_map):
1011         Made _name_to_contributor_map include alias names.
1012
1013         * Scripts/webkitpy/common/config/committers_unittest.py:
1014         (CommittersTest.test_contributors_by_fuzzy_match):
1015         Removed subtests that are now obsolete, as these matches are strict. It is not
1016         obvious if distance based fuzzy matching for names is useful at all, but we can
1017         look into that some other time.
1018
1019 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
1020
1021         QueueStatusServer should have an explicit timeout for _fetch_url
1022         https://bugs.webkit.org/show_bug.cgi?id=167467
1023
1024         Reviewed by Alexey Proskuryakov.
1025
1026         * Scripts/webkitpy/common/net/statusserver.py:
1027         (StatusServer._fetch_url): Add an explicit timeout of 300s.
1028
1029 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
1030
1031         Add support for Trac instances that host multiple projects.
1032         https://bugs.webkit.org/show_bug.cgi?id=167524
1033
1034         Reviewed by Alexey Proskuryakov.
1035
1036         When multiple projects are hosted on a single Trac instance, the current
1037         behavior will retrieve changesets from all tracked projects.
1038         This patch teaches Trac.js to get project-specific changesets from Trac.
1039         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
1040         when querying the Trac timeline.
1041
1042         To tell Trac to be aware of multi-project instances we leverage the 
1043         `options` parameter when creating a new instance: 
1044
1045             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
1046
1047         If this option is not provided, the original behaviour will prevail.
1048         Additionally, add corresponding tests.
1049
1050         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1051         (Trac): Reason about new optional parameter 'projectIdentifier'.
1052         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
1053         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
1054         replace default parameter `changeset=on` with `repo-projectname=on`.
1055         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
1056         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1057         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
1058         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1059         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
1060         Add the following tests:
1061             test("revisionURL")
1062             test("revisionURL with Trac Identifier")
1063             test("_xmlTimelineURL")
1064             test("_xmlTimelineURL with Trac Identifier")
1065         (this.view._latestProductiveIteration): Fix missing ';'.
1066
1067 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
1068
1069         Correct spacing regression on inter-element complex path shaping on some fonts
1070         https://bugs.webkit.org/show_bug.cgi?id=166013
1071
1072         Reviewed by Simon Fraser.
1073
1074         Unskip existing tests and make some new tests:
1075         - Testing complex text with no origins
1076         - Testing initial expansions
1077         - Testing the sign of vertical advances
1078
1079         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1080         (TestWebKitAPI::TEST_F):
1081
1082 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1083
1084         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1085         https://bugs.webkit.org/show_bug.cgi?id=167596
1086
1087         Reviewed by Daniel Bates.
1088
1089         We avoid needing a thin directory by invoking the zip program with
1090         the list of directories from the build directory to be zipped,
1091         and by using the zip feature to exclude files matching a pattern.
1092
1093         * BuildSlaveSupport/built-product-archive:
1094         (copyBuildFiles):
1095         (createZipFromList):
1096         (archiveBuiltProduct):
1097
1098 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1099
1100         Use simctl instead of LayoutTestRelay
1101         https://bugs.webkit.org/show_bug.cgi?id=165927
1102
1103         Reviewed by Daniel Bates.
1104
1105         Part 1
1106
1107         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1108         simulators through simctl (iOS 10 and later), use this functionality instead.
1109
1110         * Scripts/webkitpy/port/base.py:
1111         (Port.__init__): Added _test_runner_process_constructor.
1112         * Scripts/webkitpy/port/darwin.py:
1113         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1114         * Scripts/webkitpy/port/driver.py:
1115         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1116         (IOSSimulatorDriver): Deleted.
1117         * Scripts/webkitpy/port/driver_unittest.py:
1118         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1119         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1120         (DriverTest.test_start_actually_starts): Ditto.
1121         * Scripts/webkitpy/port/ios.py:
1122         (IOSSimulatorPort): Remove relay_name.
1123         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1124         (IOSSimulatorPort._create_simulators): Formatting change.
1125         (IOSSimulatorPort.relay_path): Deleted.
1126         (IOSSimulatorPort._check_relay): Deleted.
1127         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1128         (IOSSimulatorPort._build_relay): Deleted.
1129         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1130         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1131         * Scripts/webkitpy/port/ios_unittest.py:
1132         (iosTest.test_32bit): Update test.
1133         (iosTest.test_64bit): Update test.
1134         * Scripts/webkitpy/port/server_process.py:
1135         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1136         (ServerProcess._set_file_nonblocking): Added to share common code.
1137         * Scripts/webkitpy/port/server_process_mock.py:
1138         (MockServerProcess.__init__): Added argument worker_number.
1139         * Scripts/webkitpy/port/simulator_process.py: Added.
1140         (SimulatorProcess): Added.
1141         (SimulatorProcess.Popen): Added.
1142         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1143         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1144         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1145         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1146         (SimulatorProcess._reset): Added. Unlink fifos.
1147         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1148         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1149         * Scripts/webkitpy/xcode/simulator.py:
1150         (Device.__init__): Accept host to run install/launch/terminate.
1151         (Device.install_app): Install app to target Device.
1152         (Device.launch_app): Launch app on target Device.
1153         (Device.terminate_app): Shutdown app on target Device.
1154         (Simulator._parse_devices): Pass host to Device.
1155
1156 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1157
1158         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1159         https://bugs.webkit.org/show_bug.cgi?id=167411
1160
1161         Reviewed by Michael Catanzaro.
1162
1163         Disable the ARM iwMMXt fast path for pixman, because it triggers
1164         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1165
1166         * gtk/jhbuild.modules:
1167
1168 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1169
1170         [GTK] Add API to handle the accelerated compositing policy
1171         https://bugs.webkit.org/show_bug.cgi?id=167509
1172
1173         Reviewed by Michael Catanzaro.
1174
1175         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1176         as a special case. Also add test cases to the get/set API.
1177
1178         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1179         (hardwareAccelerationPolicyToString):
1180         (stringToHardwareAccelerationPolicy):
1181         (cellRendererChanged):
1182         (browserSettingsDialogConstructed):
1183         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1184         (testWebKitSettings):
1185
1186 2017-01-29  Andy Estes  <aestes@apple.com>
1187
1188         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1189         https://bugs.webkit.org/show_bug.cgi?id=167563
1190         <rdar://problem/30253207>
1191
1192         Reviewed by Andreas Kling.
1193
1194         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1195         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1196         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1197         (runTest):
1198         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1199         (TEST):
1200
1201 2017-01-29  Dan Bernstein  <mitz@apple.com>
1202
1203         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
1204         https://bugs.webkit.org/show_bug.cgi?id=167565
1205
1206         Reviewed by Sam Weinig.
1207
1208         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1209         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
1210         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
1211         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
1212         (TEST):
1213         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
1214         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1215         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1216         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
1217
1218 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1219
1220         Add Link Preload as an off-by-default experimental feature menu item.
1221         https://bugs.webkit.org/show_bug.cgi?id=167201
1222
1223         Reviewed by Ryosuke Niwa.
1224
1225         * DumpRenderTree/mac/DumpRenderTree.mm:
1226         (resetWebPreferencesToConsistentValues):
1227         * DumpRenderTree/win/DumpRenderTree.cpp:
1228         (resetWebPreferencesToConsistentValues):
1229
1230 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1231
1232         Add User Timing Experimental Feature
1233         https://bugs.webkit.org/show_bug.cgi?id=167542
1234         <rdar://problem/22746307>
1235
1236         Reviewed by Ryosuke Niwa.
1237
1238         * DumpRenderTree/mac/DumpRenderTree.mm:
1239         (enableExperimentalFeatures):
1240         (resetWebPreferencesToConsistentValues):
1241         * DumpRenderTree/win/DumpRenderTree.cpp:
1242         (enableExperimentalFeatures):
1243
1244 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1245
1246         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
1247         https://bugs.webkit.org/show_bug.cgi?id=167519
1248
1249         Reviewed by Ryosuke Niwa.
1250
1251         * QueueStatusServer/templates/statusbubble.html:
1252         To measure the bubbleContainer's width, it must not be wrapping based
1253         on its parent container. So when measuring the width temporarily set
1254         the parent to a very large width so as to not artificially wrap us.
1255         Restore the parent's width after measuring.
1256
1257 2017-01-27  Andy Estes  <aestes@apple.com>
1258
1259         [iOS] Add a test for _WKNSFileManagerExtras
1260         https://bugs.webkit.org/show_bug.cgi?id=167478
1261
1262         Reviewed by Andreas Kling.
1263
1264         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1265         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
1266         (expectAttributes):
1267         (TEST):
1268
1269 2017-01-27  Keith Miller  <keith_miller@apple.com>
1270
1271         run-benchmarks should make sure it passes the test url to the right application
1272         https://bugs.webkit.org/show_bug.cgi?id=167533
1273
1274         Reviewed by Joseph Pecoraro.
1275
1276         This fixes an issue when trying to run-benchmark script with the
1277         system default browser set to STP. Previously, it would run
1278         the test in STP rather than the provided build. Now, it should run
1279         in the provided build.
1280
1281         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1282         (OSXSafariDriver.launch_url):
1283
1284 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1285
1286         [Cocoa] Prepare ComplexTextController for unit testing
1287         https://bugs.webkit.org/show_bug.cgi?id=167493
1288
1289         Reviewed by Simon Fraser.
1290
1291         Addressing post-review comments from Simon Fraser.
1292
1293         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1294         (TestWebKitAPI::TEST_F):
1295
1296 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1297
1298         [Cocoa] Prepare ComplexTextController for unit testing
1299         https://bugs.webkit.org/show_bug.cgi?id=167493
1300
1301         Reviewed by Dean Jackson.
1302
1303         Create four unit tests.
1304
1305         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1306         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
1307         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
1308         (TestWebKitAPI::TEST_F):
1309
1310 2017-01-26  Chris Dumez  <cdumez@apple.com>
1311
1312         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1313         https://bugs.webkit.org/show_bug.cgi?id=167421
1314         <rdar://problem/30188490>
1315
1316         Reviewed by Darin Adler.
1317
1318         Add a new setting allowing layout tests to enable PageCache in a window
1319         that has an opener, for convenience.
1320
1321         * DumpRenderTree/mac/DumpRenderTree.mm:
1322         (resetWebPreferencesToConsistentValues):
1323         * DumpRenderTree/win/DumpRenderTree.cpp:
1324         (resetWebPreferencesToConsistentValues):
1325         * WebKitTestRunner/TestController.cpp:
1326         (WTR::TestController::resetPreferencesToConsistentValues):
1327
1328 2017-01-26  Keith Miller  <keith_miller@apple.com>
1329
1330         classInfo should take a VM so it is not materialized from the object on each call
1331         https://bugs.webkit.org/show_bug.cgi?id=167424
1332
1333         Rubber Stamped by Michael Saboff.
1334
1335         Previously, classInfo() would get the VM from the target's
1336         MarkedBlock.  Most callers already have a VM on hand, so it is
1337         wasteful to compute the VM from the marked block every time. This
1338         patch refactors some of the most common callers of classInfo(),
1339         jsDynamicCast and inherits to take a VM as well.
1340
1341         * DumpRenderTree/TestRunner.cpp:
1342         (setAudioResultCallback):
1343
1344 2017-01-26  Jer Noble  <jer.noble@apple.com>
1345
1346         Autoplay muted videos stop playback of any streaming app in the background
1347         https://bugs.webkit.org/show_bug.cgi?id=163993
1348         <rdar://problem/29020431>
1349
1350         Reviewed by Eric Carlson.
1351
1352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1353         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1354         (TestWebKitAPI::TEST):
1355         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
1356
1357 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
1358
1359         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
1360         https://bugs.webkit.org/show_bug.cgi?id=167466
1361
1362         Unreviewed test gardening.
1363
1364         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1365         (TEST):
1366
1367 2017-01-26  Matt Rajca  <mrajca@apple.com>
1368
1369         Notify clients when the user plays media otherwise prevented from autoplaying
1370         https://bugs.webkit.org/show_bug.cgi?id=167390
1371
1372         Reviewed by Alex Christensen.
1373
1374         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1375         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1376         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1377         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1378         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1379         (TEST):
1380         * TestWebKitAPI/cocoa/TestWKWebView.h:
1381         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1382         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1383         (-[TestWKWebView waitForLoad]):
1384         (-[TestWKWebView mouseUpAtPoint:]):
1385         * WebKitTestRunner/TestController.cpp:
1386         (WTR::TestController::createOtherPage):
1387         (WTR::TestController::createWebViewWithOptions):
1388
1389 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1390
1391         Crash when setting custom scale factor.
1392         https://bugs.webkit.org/show_bug.cgi?id=167369
1393
1394         Reviewed by Sam Weinig.
1395
1396         Added API test.
1397
1398         * TestWebKitAPI/PlatformWin.cmake:
1399         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1400         (TestWebKitAPI::WebKitCreateInstance):
1401         (TestWebKitAPI::ScaleWebView::SetUp):
1402         (TestWebKitAPI::ScaleWebView::TearDown):
1403         (TestWebKitAPI::TEST_F):
1404
1405 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1406
1407         run-benchmark nests MotionMark results by the suite name twice
1408         https://bugs.webkit.org/show_bug.cgi?id=164948
1409
1410         Reviewed by Said Abou-Hallawa.
1411
1412         Use a single level MotionMark now that this is the name of the benchmark,
1413         and we no longer have tests that aren't part of the MotionMark suite.
1414
1415         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1416
1417 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1418
1419         Unreviewed, rolling out r211193.
1420
1421         This change broke internal builds.
1422
1423         Reverted changeset:
1424
1425         "Notify clients when the user plays media otherwise prevented
1426         from autoplaying"
1427         https://bugs.webkit.org/show_bug.cgi?id=167390
1428         http://trac.webkit.org/changeset/211193
1429
1430 2017-01-25  Matt Rajca  <mrajca@apple.com>
1431
1432         Notify clients when the user plays media otherwise prevented from autoplaying
1433         https://bugs.webkit.org/show_bug.cgi?id=167390
1434
1435         Reviewed by Alex Christensen.
1436
1437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1438         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1439         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1440         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1441         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1442         (TEST):
1443         * TestWebKitAPI/cocoa/TestWKWebView.h:
1444         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1445         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1446         (-[TestWKWebView waitForLoad]):
1447         (-[TestWKWebView mouseUpAtPoint:]):
1448         * WebKitTestRunner/TestController.cpp:
1449         (WTR::TestController::createOtherPage):
1450         (WTR::TestController::createWebViewWithOptions):
1451
1452 2017-01-25  Matt Rajca  <mrajca@apple.com>
1453
1454         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1455         https://bugs.webkit.org/show_bug.cgi?id=167385
1456
1457         Reviewed by Alex Christensen.
1458
1459         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1460         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1461         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1462         (TEST): Allow inline (rather than full screen) media playback on iOS.
1463
1464 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1465
1466         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1467         https://bugs.webkit.org/show_bug.cgi?id=167414
1468
1469         Reviewed by Michael Catanzaro.
1470
1471         Add a test case to check ephemeral web views don't write favicons to the database.
1472
1473         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1474         (ephemeralViewLoadChanged):
1475         (testPrivateBrowsing):
1476         (testFaviconDatabase):
1477
1478 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1479
1480         [GTK] Add a private browsing mode to MiniBrowser
1481         https://bugs.webkit.org/show_bug.cgi?id=167413
1482
1483         Reviewed by Michael Catanzaro.
1484
1485         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1486         private windows, even on non-private instances.
1487
1488         * MiniBrowser/gtk/BrowserWindow.c:
1489         (webViewTitleChanged): Add [Private] to title window for private windows.
1490         (webViewCreate): Pass web context to browser_window_new.
1491         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1492         (browserWindowFinalize): Disconnect web context signal handlers.
1493         (browser_window_init): Add shortcut for opening private window.
1494         (browser_window_new): It now receives the context and connect to download-started here.
1495         (browser_window_get_web_context): Return the context.
1496         * MiniBrowser/gtk/BrowserWindow.h:
1497         * MiniBrowser/gtk/main.c:
1498         (createBrowserTab): Create the web view for the window web context.
1499         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1500         (aboutDataHandleRequest): Ditto.
1501         (aboutURISchemeRequestCallback): Ditto.
1502         (main): Create ephemeral web context if private command line option is used.
1503
1504 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1505
1506         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1507         https://bugs.webkit.org/show_bug.cgi?id=167409
1508
1509         Reviewed by Antti Koivisto.
1510
1511         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1512         as well as tests for the newly added matchingElementInFlatTree.
1513
1514         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1515         (TestWebKitAPI::runJavaScriptAlert):
1516         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1517         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1518         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1519
1520 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1521
1522         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1523         https://bugs.webkit.org/show_bug.cgi?id=167370
1524
1525         Reviewed by Michael Catanzaro.
1526
1527         Add several test cases of ephemeral web views.
1528
1529         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1530         (testWebViewAuthenticationStorage):
1531         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1532         (ephemeralViewloadChanged):
1533         (testCookieManagerEphemeral):
1534         (beforeAll):
1535         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1536         (testWebKitSettings):
1537         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1538         (testWebContextEphemeral):
1539         (ephemeralViewloadChanged):
1540         (testWebContextProxySettings):
1541         (beforeAll):
1542         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1543         (ephemeralViewloadChanged):
1544         (testWebViewEphemeral):
1545         (beforeAll):
1546         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1547         (ephemeralViewloadChanged):
1548         (testWebsiteDataEphemeral):
1549         (beforeAll):
1550
1551 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1552
1553         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1554         https://bugs.webkit.org/show_bug.cgi?id=167402
1555
1556         Reviewed by Ryosuke Niwa.
1557
1558         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1559         (TestWebKitAPI::TEST):
1560
1561 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1562
1563         Add simple line layout toggle to MiniBrowser
1564         https://bugs.webkit.org/show_bug.cgi?id=167405
1565
1566         Reviewed by Andreas Kling.
1567
1568         * MiniBrowser/mac/SettingsController.h:
1569         * MiniBrowser/mac/SettingsController.m:
1570         (-[SettingsController _populateMenu]):
1571         (-[SettingsController validateMenuItem:]):
1572         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1573         (-[SettingsController simpleLineLayoutEnabled]):
1574         * MiniBrowser/mac/WK1BrowserWindowController.m:
1575         (-[WK1BrowserWindowController didChangeSettings]):
1576         * MiniBrowser/mac/WK2BrowserWindowController.m:
1577         (-[WK2BrowserWindowController didChangeSettings]):
1578
1579 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1580
1581         WKR does not include my nick when commit-queue lands my patch
1582         https://bugs.webkit.org/show_bug.cgi?id=167388
1583
1584         Reviewed by Ryosuke Niwa.
1585
1586         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1587         (NewCommitBot._summarize_commit_log):
1588         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1589         Perform nickname insertion before grabbing "Patch by" details.
1590         This way we can include the nickname with the full name.
1591
1592 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1593
1594         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1595         https://bugs.webkit.org/show_bug.cgi?id=167394
1596
1597         Reviewed by Ryosuke Niwa.
1598
1599         * Scripts/webkitperl/FeatureList.pm:
1600         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1601
1602 2017-01-24  Youenn Fablet  <youenn@apple.com>
1603
1604         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1605         https://bugs.webkit.org/show_bug.cgi?id=167353
1606
1607         Reviewed by Alex Christensen.
1608
1609         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1610         (CMakeGenerator.initialize_targets):
1611
1612 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1613
1614         WKR should not confuse Miguel Gomez with Andres Gomez
1615         https://bugs.webkit.org/show_bug.cgi?id=167389
1616
1617         Reviewed by Lucas Forschler.
1618
1619         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1620         "mAndres Gomez". Fix this.
1621
1622         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1623         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1624         space on each side of the email address, so expect both spaces to be there before
1625         considering the email for replacement.
1626         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1627
1628 2017-01-24  Matt Rajca  <mrajca@apple.com>
1629
1630         Pass down website autoplay policies to media elements
1631         https://bugs.webkit.org/show_bug.cgi?id=167355
1632
1633         Reviewed by Alex Christensen.
1634
1635         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1636         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1637         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1638         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1639         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1640         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1641         (TEST):
1642
1643 2017-01-24  Nan Wang  <n_wang@apple.com>
1644
1645         AX: Speak Selection does not work in an iframe
1646         https://bugs.webkit.org/show_bug.cgi?id=166794
1647         <rdar://problem/29913013>
1648
1649         Reviewed by Chris Fleizach.
1650
1651         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1652         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1653         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1654         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1655         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1656         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1657         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1658         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1659         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1660         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1661         (-[TestRunnerWKWebView dealloc]):
1662         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1663         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1664         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1665         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1666         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1667
1668 2017-01-24  Daniel Bates  <dabates@apple.com>
1669
1670         StringView.split() should use an iterator design pattern instead of allocating a Vector
1671         https://bugs.webkit.org/show_bug.cgi?id=163225
1672
1673         Reviewed by Darin Adler.
1674
1675         Add unit tests for StringView.split().
1676
1677         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1678         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1679         used in the StringView.split() unit tests.
1680         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1681         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1682         object to a Vector of String objects.
1683         (TestWebKitAPI::TEST): Added the following tests:
1684             - WTF.StringViewSplitEmptyAndNullStrings
1685             - WTF.StringViewSplitBasic
1686             - WTF.StringViewSplitWithConsecutiveSeparators
1687
1688 2017-01-23  Anders Carlsson  <andersca@apple.com>
1689
1690         The Score Esports crashes on launch
1691         https://bugs.webkit.org/show_bug.cgi?id=167338
1692         rdar://problem/29948645
1693
1694         Reviewed by Dan Bernstein.
1695
1696         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1697         (TestWebKitAPI::TEST):
1698         Add a test.
1699
1700 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1701
1702         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1703         https://bugs.webkit.org/show_bug.cgi?id=146589
1704
1705         Reviewed by Michael Catanzaro.
1706
1707         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1708         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1709
1710         * MiniBrowser/gtk/BrowserWindow.c:
1711         (webViewDecidePolicy):
1712         (newTabCallback):
1713         * MiniBrowser/gtk/main.c:
1714         (createBrowserTab):
1715         (aboutDataRequestFree):
1716         (aboutDataRequestNew):
1717         (aboutDataRequestForView):
1718         (websiteDataRemovedCallback):
1719         (websiteDataClearedCallback):
1720         (aboutDataScriptMessageReceivedCallback):
1721         (domainListFree):
1722         (aboutDataFillTable):
1723         (gotWebsiteDataCallback):
1724         (aboutDataHandleRequest):
1725         (aboutURISchemeRequestCallback):
1726         (main):
1727         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1728         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1729         (serverCallback):
1730         (beforeAll):
1731         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
1732         (serverCallback):
1733         (WebsiteDataTest::WebsiteDataTest):
1734         (WebsiteDataTest::~WebsiteDataTest):
1735         (WebsiteDataTest::fetch):
1736         (WebsiteDataTest::remove):
1737         (WebsiteDataTest::clear):
1738         (testWebsiteDataConfiguration):
1739         (testWebsiteDataCache):
1740         (testWebsiteDataStorage):
1741         (testWebsiteDataDatabases):
1742         (testWebsiteDataAppcache):
1743         (beforeAll):
1744         (afterAll):
1745
1746 2017-01-23  Commit Queue  <commit-queue@webkit.org>
1747
1748         Unreviewed, rolling out r211062.
1749         https://bugs.webkit.org/show_bug.cgi?id=167354
1750
1751         broke API tests (Requested by alexchristensen on #webkit).
1752
1753         Reverted changeset:
1754
1755         "Pass down website autoplay policies to media elements"
1756         https://bugs.webkit.org/show_bug.cgi?id=167132
1757         http://trac.webkit.org/changeset/211062
1758
1759 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1760
1761         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
1762         https://bugs.webkit.org/show_bug.cgi?id=167330
1763
1764         Reviewed by Tim Horton.
1765
1766         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1767         (TestWebKitAPI::TEST_F):
1768
1769 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1770
1771         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
1772         https://bugs.webkit.org/show_bug.cgi?id=167317
1773
1774         Reviewed by Sam Weinig.
1775
1776         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1777         (TestWebKitAPI::TEST_F):
1778
1779 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
1780
1781         svn-create-patch should emit properties when files are moved or copied
1782         https://bugs.webkit.org/show_bug.cgi?id=167264
1783
1784         Reviewed by Daniel Bates.
1785
1786         * Scripts/svn-create-patch:
1787         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
1788
1789 2017-01-23  Youenn Fablet  <youenn@apple.com>
1790
1791         [WebRTC] Filter libwebrtc link flags
1792         https://bugs.webkit.org/show_bug.cgi?id=167287
1793
1794         Reviewed by Alex Christensen.
1795
1796         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1797         (CMakeGenerator._compute_link_flags):
1798         (CMakeGenerator._compute_link_flags.keep_flag):
1799         (CMakeGenerator._generate_compile_target_options):
1800
1801 2017-01-23  Youenn Fablet  <youennf@gmail.com>
1802
1803         [WebRTC] Make VP8 optional in libwebrtc
1804         https://bugs.webkit.org/show_bug.cgi?id=167257
1805
1806         Reviewed by Darin Adler.
1807
1808         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1809         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
1810
1811 2017-01-23  Jer Noble  <jer.noble@apple.com>
1812
1813         Video details does not apear and missing scrubber in Control Center
1814         https://bugs.webkit.org/show_bug.cgi?id=167233
1815
1816         Reviewed by Alex Christensen.
1817
1818         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
1819         NowPlayingControlTests for iOS.
1820
1821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1822         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1823         (-[NowPlayingTestWebView setWindowVisible:]):
1824         (TestWebKitAPI::TEST):
1825         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1826         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1827         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1828         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
1829         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
1830         (SOFT_LINK_CLASS):
1831         (-[TestMessageHandler addMessage:withHandler:]):
1832         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1833         (__simulated_forceClickAssociatedEventsMask):
1834         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1835         (-[TestWKWebViewHostWindow isKeyWindow]):
1836         (-[TestWKWebViewHostWindow makeKeyWindow]):
1837         (-[TestWKWebViewHostWindow resignKeyWindow]):
1838         (-[TestWKWebView initWithFrame:]):
1839         (-[TestWKWebView initWithFrame:configuration:]):
1840         (-[TestWKWebView _setUpTestWindow:]):
1841         (-[TestWKWebView performAfterReceivingMessage:action:]):
1842         (-[TestWKWebView loadTestPageNamed:]):
1843         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1844         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1845         (-[TestWKWebView waitForMessage:]):
1846         (-[TestWKWebView performAfterLoading:]):
1847         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1848         (-[TestWKWebView typeCharacter:]):
1849
1850 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1851
1852         Unreviewed. Bring back gtk-doc error messages after r209981.
1853
1854         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
1855         impossible to know what's wrong.
1856
1857         * gtk/gtkdoc.py:
1858         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
1859
1860 2017-01-20  Youenn Fablet  <youennf@gmail.com>
1861
1862         [WebRTC] Update build system to make G711 optional in libwebrtc
1863         https://bugs.webkit.org/show_bug.cgi?id=167256
1864
1865         Reviewed by Alex Christensen.
1866
1867         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1868         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
1869
1870 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1871
1872         Cleanup RuntimeEnabledFeatures
1873         https://bugs.webkit.org/show_bug.cgi?id=167228
1874
1875         Reviewed by Simon Fraser.
1876
1877         * DumpRenderTree/mac/DumpRenderTree.mm:
1878         (enableExperimentalFeatures):
1879         (resetWebPreferencesToConsistentValues):
1880         (setWebPreferencesForTestOptions):
1881         (resetWebViewToConsistentStateBeforeTesting):
1882         * DumpRenderTree/win/DumpRenderTree.cpp:
1883         (enableExperimentalFeatures):
1884         (resetWebPreferencesToConsistentValues):
1885         More closely match WebKitTestRunner initialization of preferences
1886         for experimental features.
1887
1888 2017-01-20  Alex Christensen  <achristensen@webkit.org>
1889
1890         Build Fix for Windows DumpRenderTree after r210976
1891         https://bugs.webkit.org/show_bug.cgi?id=167115
1892
1893         * DumpRenderTree/win/DumpRenderTree.cpp:
1894         (resetWebPreferencesToConsistentValues):
1895
1896 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1897
1898         Remove outdated ENABLE(CSP_NEXT) build flag
1899         https://bugs.webkit.org/show_bug.cgi?id=167252
1900
1901         Reviewed by Brent Fulgham.
1902
1903         * Scripts/webkitperl/FeatureList.pm:
1904         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1905
1906 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1907
1908         Build Fix for Windows DumpRenderTree after r210976
1909
1910         * DumpRenderTree/win/DumpRenderTree.cpp:
1911         (resetWebPreferencesToConsistentValues):
1912
1913 2017-01-20  Antoine Quint  <graouts@apple.com>
1914
1915         Web Animations should be off by default and enabled as an experimental feature
1916         https://bugs.webkit.org/show_bug.cgi?id=167115
1917         <rdar://problem/30048963>
1918
1919         Reviewed by Joseph Pecoraro.
1920
1921         Turn Web Animations on in DRT.
1922
1923         * DumpRenderTree/mac/DumpRenderTree.mm:
1924         (resetWebPreferencesToConsistentValues):
1925         * DumpRenderTree/win/DumpRenderTree.cpp:
1926         (resetWebPreferencesToConsistentValues):
1927
1928 2017-01-20  Youenn Fablet  <youenn@apple.com>
1929
1930         [WebRTC] Add libwebrtc build infrastructure
1931         https://bugs.webkit.org/show_bug.cgi?id=167207
1932
1933         Reviewed by Alex Christensen.
1934
1935         Adding a script doing the libwebrtc project json to CMake file conversion.
1936
1937         * Scripts/generate-libwebrtc-cmake: Added.
1938         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
1939         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
1940
1941 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1942
1943         Mini Browser: Show tooltip for Experimental Features
1944         https://bugs.webkit.org/show_bug.cgi?id=167225
1945
1946         Reviewed by Alex Christensen.
1947
1948         * MiniBrowser/mac/SettingsController.m:
1949         (-[SettingsController _populateMenu]):
1950         Include the full details string as a tooltip.
1951
1952 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
1953
1954         [Win] Test output results should not be written twice.
1955         https://bugs.webkit.org/show_bug.cgi?id=167197
1956
1957         Reviewed by Brent Fulgham.
1958
1959         Prevent test output from being written twice by returning early from
1960         the dump() function, if it already has been called.
1961         This patch also adds a missing newline to a test output line. 
1962         
1963         * DumpRenderTree/win/DumpRenderTree.cpp:
1964         (dump):
1965
1966 2017-01-20  Antoine Quint  <graouts@apple.com>
1967
1968         [Modern Media Controls] Turn modern media controls on by default
1969         https://bugs.webkit.org/show_bug.cgi?id=165668
1970
1971         Reviewed by Dean Jackson.
1972
1973         Enabled modern media controls by default in test runners.
1974
1975         * DumpRenderTree/TestOptions.h:
1976         * WebKitTestRunner/TestOptions.h:
1977
1978 2017-01-19  Chris Dumez  <cdumez@apple.com>
1979
1980         iterable<> should be enabled on WK1
1981         https://bugs.webkit.org/show_bug.cgi?id=167221
1982         <rdar://problem/30108531>
1983
1984         Reviewed by Youenn Fablet.
1985
1986         * DumpRenderTree/mac/DumpRenderTree.mm:
1987         (resetWebPreferencesToConsistentValues):
1988         * DumpRenderTree/win/DumpRenderTree.cpp:
1989         (resetWebPreferencesToConsistentValues):
1990         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1991         (WTR::InjectedBundle::beginTesting):
1992         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1993         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
1994         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1995
1996 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
1997
1998         Ensure status server logs go to log file
1999         https://bugs.webkit.org/show_bug.cgi?id=167210
2000
2001         Reviewed by Alexey Proskuryakov.
2002
2003         * Scripts/webkitpy/common/net/statusserver.py:
2004         (StatusServer.next_work_item): Change log level from debug to info in
2005         order to facilitate deubgging issues.
2006         (StatusServer.update_work_items): Same.
2007
2008 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
2009
2010         Additional selection tests and interpolation fix
2011         https://bugs.webkit.org/show_bug.cgi?id=167171
2012
2013         Reviewed by Simon Fraser.
2014
2015         We weren't adding the final event when interpolating event streams.
2016
2017         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2018         (-[HIDEventGenerator interpolatedEvents:]):
2019
2020 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2021
2022         [Cocoa] Variation fonts are erroneously disabled on iOS
2023         https://bugs.webkit.org/show_bug.cgi?id=167172
2024
2025         Reviewed by Simon Fraser.
2026
2027         OpenSource builders don't seem to understand sdk=embedded*.
2028
2029         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2030
2031 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2032
2033         Unreviewed. Fix GTK+ unit tests failing since r210531.
2034
2035         Avoid using paths to files that don't actually exist.
2036
2037         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2038         (testWebKitConsoleMessageNetworkError):
2039         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2040         (testContextMenuDefaultMenu):
2041         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
2042         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
2043         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
2044
2045 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2046
2047         [GTK] Provide API to set proxy settings
2048         https://bugs.webkit.org/show_bug.cgi?id=128674
2049
2050         Reviewed by Michael Catanzaro.
2051
2052         Add tests for new proxy settings API.
2053
2054         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2055         (serverCallback):
2056         (ProxyTest::ProxyTest):
2057         (ProxyTest::~ProxyTest):
2058         (ProxyTest::loadURIAndGetMainResourceData):
2059         (ProxyTest::proxyServerPortAsString):
2060         (testWebContextProxySettings):
2061         (beforeAll):
2062
2063 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2064
2065         Add back my old email address so old commits will still match it.
2066
2067         * Scripts/webkitpy/common/config/contributors.json:
2068
2069 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2070
2071         Remove my old email address from contributors.json and watchlist.
2072
2073         * Scripts/validate-committer-lists:
2074         (CommitterListFromGit): Change the mapping to the correct email.
2075         * Scripts/webkitpy/common/config/contributors.json:
2076         * Scripts/webkitpy/common/config/watchlist:
2077
2078 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2079
2080         Unreviewed, rolling out r210848.
2081
2082         This change introduced media-related LayoutTest failures and
2083         crashes on macOS.
2084
2085         Reverted changeset:
2086
2087         "[Modern Media Controls] Turn modern media controls on by
2088         default"
2089         https://bugs.webkit.org/show_bug.cgi?id=165668
2090         http://trac.webkit.org/changeset/210848
2091
2092 2017-01-18  Andreas Kling  <akling@apple.com>
2093
2094         Document::securityOrigin() should return a reference.
2095         <https://webkit.org/b/167124>
2096
2097         Reviewed by Sam Weinig.
2098
2099         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2100         (TestWebKitAPI::TEST_F):
2101
2102 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2103
2104         [Win] Clipboard tests are flaky.
2105         https://bugs.webkit.org/show_bug.cgi?id=167088
2106
2107         Reviewed by Brent Fulgham.
2108
2109         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2110         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2111
2112         * DumpRenderTree/win/DumpRenderTree.cpp:
2113         (main):
2114
2115 2017-01-18  Antoine Quint  <graouts@apple.com>
2116
2117         [Modern Media Controls] Turn modern media controls on by default
2118         https://bugs.webkit.org/show_bug.cgi?id=165668
2119
2120         Reviewed by Dean Jackson.
2121
2122         Enabled modern media controls by default in test runners. 
2123
2124         * DumpRenderTree/TestOptions.h:
2125         * WebKitTestRunner/TestOptions.h:
2126
2127 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2128
2129         Unreviewed, rolling out r210834
2130         https://bugs.webkit.org/show_bug.cgi?id=165668
2131
2132         It introduced dozens of test timeouts.
2133
2134         Reverted changeset:
2135         "[Modern Media Controls] Turn modern media controls on by default"
2136         https://bugs.webkit.org/show_bug.cgi?id=165668
2137         http://trac.webkit.org/changeset/210834
2138
2139 2017-01-17  Antoine Quint  <graouts@apple.com>
2140
2141         [Modern Media Controls] Turn modern media controls on by default
2142         https://bugs.webkit.org/show_bug.cgi?id=165668
2143
2144         Reviewed by Dean Jackson.
2145
2146         Enabled modern media controls by default in test runners. 
2147
2148         * DumpRenderTree/TestOptions.h:
2149         * WebKitTestRunner/TestOptions.h:
2150
2151 2017-01-17  Chris Dumez  <cdumez@apple.com>
2152
2153         Document title changed twice when setting document.title
2154         https://bugs.webkit.org/show_bug.cgi?id=167065
2155
2156         Reviewed by Darin Adler.
2157
2158         Add WebKit2GTK API test that was written by Michael Catanzaro.
2159
2160         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2161         (testWebViewTitleChange):
2162         (beforeAll):
2163
2164 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2165
2166         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2167         https://bugs.webkit.org/show_bug.cgi?id=116551
2168         <rdar://problem/13949830>
2169
2170         Reviewed by Alex Christensen.
2171
2172         * Scripts/webkitperl/FeatureList.pm:
2173         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2174         that is part of the existing WEB_TIMING feature.
2175
2176         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2177
2178 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
2179
2180         'webkit-patch post' no longer works with moved/copied files
2181         https://bugs.webkit.org/show_bug.cgi?id=166914
2182         <rdar://problem/29979707>
2183
2184         Reviewed by Daniel Bates.
2185
2186         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
2187         file outputs only the "Index:" line with an empty body.  This workaround
2188         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
2189         public email list tracking this bug is below.
2190         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
2191         
2192
2193         * Scripts/svn-create-patch:
2194         (generateDiff): Ignore an "Index:" line with an empty body.
2195
2196 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2197
2198         Remove the REQUEST_ANIMATION_FRAME flag
2199         https://bugs.webkit.org/show_bug.cgi?id=156980
2200         <rdar://problem/25906849>
2201
2202         Reviewed by Simon Fraser.
2203
2204         * Scripts/webkitperl/FeatureList.pm:
2205         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2206
2207 2017-01-15  Sam Weinig  <sam@webkit.org>
2208
2209         Add the ability to use numbers in makeString()
2210         https://bugs.webkit.org/show_bug.cgi?id=167087
2211
2212         Reviewed by Darin Adler.
2213
2214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2215         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
2216         Add tests for StringConcatenate, focusing on new numeric additions.
2217
2218 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2219
2220         Unreviewed, remove stale comment.
2221
2222         This test was fixed by r163173.
2223
2224         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2225
2226 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2227
2228         Annotate large string tests with largeHeap
2229         https://bugs.webkit.org/show_bug.cgi?id=167054
2230
2231         Reviewed by Filip Pizlo.
2232
2233         * Scripts/run-javascriptcore-tests:
2234         * Scripts/run-jsc-stress-tests:
2235
2236 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
2237
2238         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
2239         https://bugs.webkit.org/show_bug.cgi?id=167043
2240
2241         Reviewed by Darin Adler.
2242
2243         * Scripts/webkitperl/FeatureList.pm:
2244
2245 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2246
2247         Remove ENABLE(DETAILS_ELEMENT) guards
2248         https://bugs.webkit.org/show_bug.cgi?id=167042
2249
2250         Reviewed by Alex Christensen.
2251
2252         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2253
2254 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
2255
2256         26 MotionMark performance tests failing
2257         https://bugs.webkit.org/show_bug.cgi?id=166854
2258
2259         Reviewed by Ryosuke Niwa.
2260
2261         Unrelated change. This is the last place that we need to rename Animometer
2262         to MotionMark.
2263
2264         * Scripts/webkitpy/common/config/watchlist:
2265
2266 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2267
2268         run-jsc-benchmarks' echo should have -e option
2269         https://bugs.webkit.org/show_bug.cgi?id=167009
2270
2271         Reviewed by Sam Weinig.
2272
2273         echo requires `-e` option to use escape sequence.
2274         Without it, in some environment (in my Fedora 25), the escape sequence is not
2275         recognized and just dumped as `\c` etc.
2276
2277         * Scripts/run-jsc-benchmarks:
2278
2279 2017-01-12  Chris Dumez  <cdumez@apple.com>
2280
2281         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2282         https://bugs.webkit.org/show_bug.cgi?id=166995
2283
2284         Reviewed by Jer Noble.
2285
2286         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2287         as some people are having trouble building without it.
2288
2289         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2290
2291 2017-01-12  Sam Weinig  <sam@webkit.org>
2292
2293         Add the ability to filter the set of bindings tests you want to run
2294         https://bugs.webkit.org/show_bug.cgi?id=166977
2295
2296         Reviewed by Tim Horton.
2297
2298         Allows doing things like:
2299             run-bindings-tests TestObj* TestCEReactions*
2300         
2301         to run only those tests that match the patterns.
2302
2303         * Scripts/run-bindings-tests:
2304         (main):
2305         Switch to using optparse and pass the remaining args as the filters.
2306
2307         * Scripts/webkitpy/bindings/main.py:
2308         (BindingsTests.__init__):
2309         Store the pattens.
2310
2311         (BindingsTests.test_matches_patterns):
2312         Add helper predicate to determine if a test should be run. When no
2313         patterns are present, all tests should run.
2314
2315         (BindingsTests.run_tests):
2316         Filter tests using the passed in patterns.
2317
2318 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
2319
2320         Followup fix after r210503.
2321         https://bugs.webkit.org/show_bug.cgi?id=166887
2322
2323         Reviewed by Alex Christensen.
2324
2325         After <http://trac.webkit.org/changeset/210503>, test results are written to a
2326         duplicated file handle on Windows. This patch fixes the remaining call sites.
2327
2328         * DumpRenderTree/PixelDumpSupport.cpp:
2329         * DumpRenderTree/TestRunner.cpp:
2330         (TestRunner::waitToDumpWatchdogTimerFired):
2331         * DumpRenderTree/TestRunner.h:
2332         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2333         * DumpRenderTree/win/DumpRenderTree.cpp:
2334         * DumpRenderTree/win/DumpRenderTreeWin.h:
2335         * DumpRenderTree/win/TestRunnerWin.cpp:
2336         (TestRunner::setSpellCheckerLoggingEnabled):
2337
2338 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
2339
2340         Add committer status for Megan
2341         https://bugs.webkit.org/show_bug.cgi?id=166954
2342
2343         Reviewed by Tim Horton.
2344
2345         Add committer status for Megan Gardner
2346
2347         * Scripts/webkitpy/common/config/contributors.json:
2348
2349 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2350
2351         Unreviewed test fix after r210599.
2352
2353         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2354         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
2355
2356 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2357
2358         Unreviewed build fix after r210599.
2359
2360         Add missing files.
2361
2362         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2363         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2364
2365 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2366
2367         File scheme should not allow access of a resource on a different volume.
2368         https://bugs.webkit.org/show_bug.cgi?id=158552
2369         <rdar://problem/15307582>
2370
2371         Reviewed by Alex Christensen.
2372
2373         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2374         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2375         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2376
2377 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2378
2379         Unreviewed, rolling out r210571.
2380
2381         This change broke the 32-bit macOS build and caused LayoutTest
2382         failures.
2383
2384         Reverted changeset:
2385
2386         "File scheme should not allow access of a resource on a
2387         different volume."
2388         https://bugs.webkit.org/show_bug.cgi?id=158552
2389         http://trac.webkit.org/changeset/210571
2390
2391 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2392
2393         [GTK] install-dependencies script misses gdb
2394         https://bugs.webkit.org/show_bug.cgi?id=166917
2395
2396         Reviewed by Michael Catanzaro.
2397
2398         gdb is needed for generating the crash logs.
2399
2400         * gtk/install-dependencies:
2401
2402 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2403
2404         [GTK] No way for applications to set notification permissions without waiting for permission request
2405         https://bugs.webkit.org/show_bug.cgi?id=163366
2406
2407         Reviewed by Carlos Garcia Campos.
2408
2409         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2410         (testWebViewNotification):
2411         (setInitialNotificationPermissionsAllowedCallback):
2412         (setInitialNotificationPermissionsDisallowedCallback):
2413         (testWebViewNotificationInitialPermissionAllowed):
2414         (testWebViewNotificationInitialPermissionDisallowed):
2415         (beforeAll):
2416         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2417         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2418         (WebViewTest::WebViewTest):
2419         (WebViewTest::initializeWebView):
2420         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2421
2422 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2423
2424         MobileMiniBrowser tests don't work by default
2425         https://bugs.webkit.org/show_bug.cgi?id=166910
2426
2427         Reviewed by Alex Christensen.
2428
2429         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2430         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2431
2432 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2433
2434         File scheme should not allow access of a resource on a different volume.
2435         https://bugs.webkit.org/show_bug.cgi?id=158552
2436         <rdar://problem/15307582>
2437
2438         Reviewed by Alex Christensen.
2439
2440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2441         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2442         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2443
2444 2017-01-10  Mark Lam  <mark.lam@apple.com>
2445
2446         Reverting run-jsc-stress-tests' $buildType to use string values.
2447         https://bugs.webkit.org/show_bug.cgi?id=166912
2448
2449         Rubber stamped by Filip Pizlo.
2450
2451         This is so that we can test for it in the tests e.g.
2452         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2453
2454         * Scripts/run-jsc-stress-tests:
2455
2456 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2457
2458         Temporarily add back the file removed in r210463 to unbreak internal bots.
2459
2460         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2461
2462 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2463
2464         svn-apply failed to apply a patch (deleting file with svn property)
2465         https://bugs.webkit.org/show_bug.cgi?id=165953
2466
2467         Reviewed by Daniel Bates.
2468
2469         * Scripts/VCSUtils.pm:
2470         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2471         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2472
2473 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2474
2475         Update flakiness dashboard configuration.
2476         https://bugs.webkit.org/show_bug.cgi?id=166869
2477
2478         Reviewed by Alexey Proskuryakov.
2479
2480         * TestResultServer/static-dashboards/builders.jsonp:
2481         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2482
2483 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2484
2485         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2486         https://bugs.webkit.org/show_bug.cgi?id=165232
2487
2488         Unreviewed follow-up patch after r210539 and r210523.
2489
2490         Instead of using that environment variable, the argument
2491         --display-server=xorg should be passed now.
2492
2493         The GTK+ performance bot was the only bot using this, and is
2494         already passing --display-server=xorg after r210539.
2495
2496         * Scripts/webkitpy/port/gtk.py:
2497         (GtkPort._driver_class):
2498
2499 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2500
2501         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2502         https://bugs.webkit.org/show_bug.cgi?id=166872
2503
2504         Reviewed by Michael Catanzaro.
2505
2506         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2507         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2508         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2509         The step RunWebKitTests already has support for it.
2510
2511         * BuildSlaveSupport/build.webkit.org-config/config.json:
2512         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2513         (RunGtkAPITests.start):
2514         (RunAndUploadPerfTests.start):
2515         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2516
2517 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2518
2519         Unreviewed, rolling out r210531.
2520
2521         This change broke the 32-bit macOS build and caused LayoutTest
2522         failures.
2523
2524         Reverted changeset:
2525
2526         "File scheme should not allow access of a resource on a
2527         different volume."
2528         https://bugs.webkit.org/show_bug.cgi?id=158552
2529         http://trac.webkit.org/changeset/210531
2530
2531 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2532
2533         File scheme should not allow access of a resource on a different volume.
2534         https://bugs.webkit.org/show_bug.cgi?id=158552
2535         <rdar://problem/15307582>
2536
2537         Reviewed by Alex Christensen.
2538
2539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2540         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2541         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2542
2543 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2544
2545         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2546         https://bugs.webkit.org/show_bug.cgi?id=165232
2547
2548         Reviewed by Michael Catanzaro.
2549
2550         Add a new WaylandDriver to run the tests in the user current wayland session.
2551
2552         Also merge all the configuration options for selecting the display server inside one
2553         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2554
2555         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2556
2557         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2558         (TestRunner._create_driver):
2559         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2560         (parse_args):
2561         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2562         (PerfTestsRunner._parse_args):
2563         * Scripts/webkitpy/port/gtk.py:
2564         (GtkPort.__init__):
2565         (GtkPort._driver_class):
2566         (GtkPort._search_paths):
2567         * Scripts/webkitpy/port/waylanddriver.py: Added.
2568         (WaylandDriver):
2569         (WaylandDriver.check_driver):
2570         (WaylandDriver._setup_environ_for_test):
2571         (WaylandDriver._start):
2572
2573 2017-01-09  Andy Estes  <aestes@apple.com>
2574
2575         [QuickLook] Add a layout test for webkit.org/b/135651
2576         https://bugs.webkit.org/show_bug.cgi?id=166855
2577
2578         Reviewed by Andreas Kling.
2579
2580         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2581         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2582         errors with code WebKitErrorCannotShowURL.
2583         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2584         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2585         not specific to WebKit2 error codes.
2586
2587 2017-01-09  Antoine Quint  <graouts@apple.com>
2588
2589         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2590         https://bugs.webkit.org/show_bug.cgi?id=166837
2591
2592         Reviewed by Alex Christensen.
2593
2594         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2595         the provided value when trying to determine the path to the test file. Failing
2596         that, we use the computed URL or the raw path provided to cover all cases.
2597         
2598         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2599         by applying this patch and seeing the number test failures dramatically reduced
2600         with WK1 due to the option to turn modern media controls off for older media controls
2601         tests.
2602
2603         * DumpRenderTree/DumpRenderTree.h:
2604         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2605         (parseInputLine):
2606         * DumpRenderTree/TestOptions.h:
2607         * DumpRenderTree/TestOptions.mm:
2608         (TestOptions::TestOptions):
2609         * DumpRenderTree/mac/DumpRenderTree.mm:
2610         (runTest):
2611
2612 2017-01-09  Milan Crha  <mcrha@redhat.com>
2613
2614         prepare-ChangeLog: Correct help string for --style option
2615         https://bugs.webkit.org/show_bug.cgi?id=166725
2616
2617         Reviewed by Alexey Proskuryakov.
2618
2619         * Scripts/prepare-ChangeLog:
2620         (main):
2621
2622 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2623
2624         https://bugs.webkit.org/show_bug.cgi?id=166839
2625         Add php7 support for macOS.
2626         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2627
2628         Reviewed by Alexey Proskuryakov.
2629
2630         * Scripts/webkitpy/port/base.py:
2631         (Port._is_darwin_php_version_7):
2632         (Port._debian_php_version):
2633         (Port):
2634         (Port._darwin_php_version):
2635         (Port._apache_config_file_name_for_platform):
2636
2637 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2638
2639         [GTK] Should support key and code properties on keyboard events
2640         https://bugs.webkit.org/show_bug.cgi?id=166759
2641
2642         Reviewed by Carlos Garcia Campos.
2643
2644         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2645         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2646         on tests.
2647
2648 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2649
2650         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2651         https://bugs.webkit.org/show_bug.cgi?id=166760
2652
2653         Reviewed by Darin Adler.
2654
2655         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2656         We can work around that by duplicating and redirecting stdout.
2657
2658         * DumpRenderTree/PixelDumpSupport.cpp:
2659         (dumpWebViewAsPixelsAndCompareWithExpected):
2660         (printPNG):
2661         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2662         (logEventProc):
2663         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2664         (DRTDesktopNotificationPresenter::showDesktopNotification):
2665         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2666         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2667         * DumpRenderTree/win/DumpRenderTree.cpp:
2668         (dumpFrameScrollPosition):
2669         (dumpHistoryItem):
2670         (dumpBackForwardList):
2671         (dump):
2672         (runTest):
2673         (main):
2674         * DumpRenderTree/win/DumpRenderTreeWin.h:
2675         * DumpRenderTree/win/EditingDelegate.cpp:
2676         (EditingDelegate::shouldBeginEditingInDOMRange):
2677         (EditingDelegate::shouldEndEditingInDOMRange):
2678         (EditingDelegate::shouldInsertNode):
2679         (EditingDelegate::shouldInsertText):
2680         (EditingDelegate::shouldDeleteDOMRange):
2681         (EditingDelegate::shouldChangeSelectedDOMRange):
2682         (EditingDelegate::shouldApplyStyle):
2683         (EditingDelegate::shouldChangeTypingStyle):
2684         (EditingDelegate::doPlatformCommand):
2685         (EditingDelegate::webViewDidBeginEditing):
2686         (EditingDelegate::webViewDidChange):
2687         (EditingDelegate::webViewDidEndEditing):
2688         (EditingDelegate::webViewDidChangeTypingStyle):
2689         (EditingDelegate::webViewDidChangeSelection):
2690         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2691         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2692         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2693         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2694         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2695         (FrameLoadDelegate::didCommitLoadForFrame):
2696         (FrameLoadDelegate::didReceiveTitle):
2697         (FrameLoadDelegate::didFinishLoadForFrame):
2698         (FrameLoadDelegate::didFailLoadWithError):
2699         (FrameLoadDelegate::willPerformClientRedirectToURL):
2700         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2701         (FrameLoadDelegate::windowScriptObjectAvailable):
2702         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2703         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2704         (FrameLoadDelegate::didDisplayInsecureContent):
2705         (FrameLoadDelegate::didRunInsecureContent):
2706         (FrameLoadDelegate::webViewProgressFinishedNotification):
2707         * DumpRenderTree/win/HistoryDelegate.cpp:
2708         (HistoryDelegate::didNavigateWithNavigationData):
2709         (HistoryDelegate::didPerformClientRedirectFromURL):
2710         (HistoryDelegate::didPerformServerRedirectFromURL):
2711         (HistoryDelegate::updateHistoryTitle):
2712         (HistoryDelegate::populateVisitedLinksForWebView):
2713         * DumpRenderTree/win/PolicyDelegate.cpp:
2714         (PolicyDelegate::decidePolicyForNavigationAction):
2715         (PolicyDelegate::unableToImplementPolicyWithError):
2716         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2717         (ResourceLoadDelegate::willSendRequest):
2718         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2719         (ResourceLoadDelegate::didReceiveResponse):
2720         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2721         (ResourceLoadDelegate::didFailLoadingWithError):
2722         * DumpRenderTree/win/TestRunnerWin.cpp:
2723         (TestRunner::addDisallowedURL):
2724         (TestRunner::originsWithApplicationCache):
2725         (TestRunner::setStorageDatabaseIdleInterval):
2726         (TestRunner::closeIdleLocalStorageDatabases):
2727         (TestRunner::copyDecodedHostName):
2728         (TestRunner::copyEncodedHostName):
2729         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2730         (TestRunner::isGeolocationProviderActive):
2731         (TestRunner::pathToLocalResource):
2732         (TestRunner::setMockDeviceOrientation):
2733         (TestRunner::setMockGeolocationPosition):
2734         (TestRunner::setMockGeolocationPositionUnavailableError):
2735         (TestRunner::setSpatialNavigationEnabled):
2736         (TestRunner::setAutomaticLinkDetectionEnabled):
2737         (TestRunner::isCommandEnabled):
2738         (TestRunner::authenticateSession):
2739         (TestRunner::addChromeInputField):
2740         (TestRunner::removeChromeInputField):
2741         (TestRunner::focusWebView):
2742         (TestRunner::grantWebNotificationPermission):
2743         (TestRunner::denyWebNotificationPermission):
2744         (TestRunner::removeAllWebNotificationPermissions):
2745         (TestRunner::simulateWebNotificationClick):
2746         (TestRunner::imageCountInGeneralPasteboard):
2747         * DumpRenderTree/win/UIDelegate.cpp:
2748         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2749         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2750         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2751         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2752         (UIDelegate::webViewAddMessageToConsole):
2753         (UIDelegate::exceededDatabaseQuota):
2754         (UIDelegate::setStatusText):
2755         (UIDelegate::didPressMissingPluginButton):
2756
2757 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2758
2759         Add a setting to create editable MiniBrowser windows by default
2760         https://bugs.webkit.org/show_bug.cgi?id=166806
2761
2762         Reviewed by Beth Dakin.
2763
2764         * MiniBrowser/mac/AppDelegate.m:
2765         (-[BrowserAppDelegate createBrowserWindowController:]):
2766         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2767         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2768         * MiniBrowser/mac/SettingsController.h:
2769         * MiniBrowser/mac/SettingsController.m:
2770         (-[SettingsController _populateMenu]):
2771         (-[SettingsController validateMenuItem:]):
2772         (-[SettingsController toggleCreateEditorByDefault:]):
2773         (-[SettingsController createEditorByDefault]):
2774         Add a setting and update the key equivalents accordingly.
2775         Also make sure to make the right kind of window on launch.
2776
2777 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2778
2779         Fix the 32-bit build.
2780
2781         * MiniBrowser/mac/BrowserWindowController.h:
2782         * MiniBrowser/mac/BrowserWindowController.m:
2783
2784 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2785
2786         Fix the 32-bit build.
2787
2788         * MiniBrowser/mac/BrowserWindowController.m:
2789
2790 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2791
2792         Make it possible to drop HTML files on the MiniBrowser icon
2793         https://bugs.webkit.org/show_bug.cgi?id=166802
2794
2795         Reviewed by Simon Fraser.
2796
2797         * MiniBrowser/mac/AppDelegate.m:
2798         (-[BrowserAppDelegate application:openFile:]):
2799         * MiniBrowser/mac/Info.plist:
2800         If you're using an editable window, the usual trick of dropping on the
2801         window doesn't work anymore (it makes an <attachment> instead).
2802
2803 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2804
2805         MiniBrowser window gets smaller each time it is instantiated
2806         https://bugs.webkit.org/show_bug.cgi?id=166807
2807
2808         Reviewed by Andy Estes.
2809
2810         * MiniBrowser/mac/BrowserWindowController.m:
2811         (-[BrowserWindowController windowDidLoad]):
2812         * MiniBrowser/mac/BrowserWindow.xib:
2813         Turn on full-window content view support with IB, instead of waiting
2814         until after the views have been loaded. This seems to resolve the
2815         longstanding ever-shrinking-window problem.
2816
2817 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2818
2819         Add indent/outdent items to MiniBrowser's new format menu
2820         https://bugs.webkit.org/show_bug.cgi?id=166805
2821
2822         Reviewed by Dan Bernstein.
2823
2824         * MiniBrowser/mac/MainMenu.xib:
2825
2826 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2827
2828         Add a stock Format menu to MiniBrowser
2829         https://bugs.webkit.org/show_bug.cgi?id=166804
2830
2831         Reviewed by Andy Estes.
2832
2833         * MiniBrowser/mac/MainMenu.xib:
2834         Many of the features automatically work with editable web views.
2835         However, this seems to expose a bug where none of the font-related features
2836         (Cmd-B, for example) work until the first time the font panel is shown,
2837         per process, which will need to be investigated separately.
2838
2839 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2840
2841         Remove unused applicationWillTerminate methods from MiniBrowser
2842         https://bugs.webkit.org/show_bug.cgi?id=166803
2843
2844         Reviewed by Andy Estes.
2845
2846         * MiniBrowser/mac/AppDelegate.m:
2847         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
2848         * MiniBrowser/mac/BrowserWindowController.h:
2849         * MiniBrowser/mac/BrowserWindowController.m:
2850         (-[BrowserWindowController applicationTerminating]): Deleted.
2851         * MiniBrowser/mac/WK1BrowserWindowController.m:
2852         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
2853         * MiniBrowser/mac/WK2BrowserWindowController.m:
2854         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
2855
2856 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2857
2858         Add the ability to create empty contentEditable windows in MiniBrowser
2859         https://bugs.webkit.org/show_bug.cgi?id=166801
2860
2861         Reviewed by Wenson Hsieh.
2862
2863         * MiniBrowser/mac/AppDelegate.h:
2864         * MiniBrowser/mac/AppDelegate.m:
2865         (-[BrowserAppDelegate createBrowserWindowController:]):
2866         (-[BrowserAppDelegate newWindow:]):
2867         (-[BrowserAppDelegate newEditorWindow:]):
2868         (-[BrowserAppDelegate openDocument:]):
2869         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2870         * MiniBrowser/mac/BrowserWindowController.h:
2871         * MiniBrowser/mac/BrowserWindowController.m:
2872         (-[BrowserWindowController loadHTMLString:]):
2873         (-[BrowserWindowController toggleEditable:]):
2874         * MiniBrowser/mac/MainMenu.xib:
2875         * MiniBrowser/mac/WK1BrowserWindowController.m:
2876         (-[WK1BrowserWindowController awakeFromNib]):
2877         (-[WK1BrowserWindowController loadHTMLString:]):
2878         (-[WK1BrowserWindowController validateMenuItem:]):
2879         (-[WK1BrowserWindowController setEditable:]):
2880         (-[WK1BrowserWindowController updateTitle:]):
2881         * MiniBrowser/mac/WK2BrowserWindowController.m:
2882         (-[WK2BrowserWindowController awakeFromNib]):
2883         (-[WK2BrowserWindowController validateMenuItem:]):
2884         (-[WK2BrowserWindowController setEditable:]):
2885         (-[WK2BrowserWindowController updateTitle:]):
2886         (-[WK2BrowserWindowController loadHTMLString:]):
2887         Merge more functionality from WebEditingTester.
2888         Add two menu items for creating empty editable WebKit1/2 windows.
2889         Add a menu item to the Edit menu to toggle editability on any window.
2890
2891 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2892
2893         Implement find-in-page in MiniBrowser
2894         https://bugs.webkit.org/show_bug.cgi?id=166799
2895
2896         Reviewed by Andy Estes.
2897
2898         * MiniBrowser/mac/BrowserWindow.xib:
2899         * MiniBrowser/mac/BrowserWindowController.h:
2900         * MiniBrowser/mac/BrowserWindowController.m:
2901         (-[BrowserWindowController find:]): Deleted.
2902         * MiniBrowser/mac/MainMenu.xib:
2903         * MiniBrowser/mac/WK1BrowserWindowController.m:
2904         (-[WK1BrowserWindowController toggleShrinkToFit:]):
2905         (-[WK1BrowserWindowController find:]): Deleted.
2906         * MiniBrowser/mac/WK2BrowserWindowController.m:
2907         (-[WK2BrowserWindowController awakeFromNib]):
2908         (-[WK2BrowserWindowController dealloc]):
2909         (-[WK2BrowserWindowController validateMenuItem:]):
2910         (-[WK2BrowserWindowController performTextFinderAction:]):
2911         (-[WK2BrowserWindowController findBarView]):
2912         (-[WK2BrowserWindowController setFindBarView:]):
2913         (-[WK2BrowserWindowController isFindBarVisible]):
2914         (-[WK2BrowserWindowController setFindBarVisible:]):
2915         (-[WK2BrowserWindowController contentView]):
2916         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
2917         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
2918         (-[WK2BrowserWindowController find:]): Deleted.
2919         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
2920         protocol. At first glance, it's pretty broken, but vaguely works.
2921
2922 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2923
2924         Share the implementation of MiniBrowser view hiding functionality
2925         https://bugs.webkit.org/show_bug.cgi?id=166800
2926
2927         Reviewed by Andy Estes.
2928
2929         * MiniBrowser/mac/BrowserWindowController.m:
2930         (-[BrowserWindowController showHideWebView:]):
2931         (-[BrowserWindowController removeReinsertWebView:]):
2932         * MiniBrowser/mac/WK1BrowserWindowController.m:
2933         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
2934         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
2935         * MiniBrowser/mac/WK2BrowserWindowController.m:
2936         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
2937         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
2938         Move the implementation of these two things to the shared superclass,
2939         since they don't depend on WebKit-specific things.
2940         Also, there was no reason to retain the (WK)WebView while it was unparented,
2941         as the BrowserWindowController maintains a reference the entire time.
2942
2943 2017-01-06  Andy Estes  <aestes@apple.com>
2944
2945         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
2946         https://bugs.webkit.org/show_bug.cgi?id=166789
2947
2948         Reviewed by Alex Christensen.
2949
2950         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2951         * DumpRenderTree/PlatformMac.cmake:
2952         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
2953         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
2954         * DumpRenderTree/mac/DumpRenderTree.mm:
2955         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2956         createXMLStringFromWebArchiveData().
2957         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
2958         * WebKitTestRunner/Configurations/Base.xcconfig:
2959         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
2960         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2961         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2962         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2963         createXMLStringFromWebArchiveData().
2964         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
2965         * WebKitTestRunner/PlatformMac.cmake:
2966         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2967         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
2968
2969 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2970
2971         Minor cleanups to IndentOutdentCommand and related code
2972         https://bugs.webkit.org/show_bug.cgi?id=166791
2973
2974         Reviewed by Simon Fraser.
2975
2976         * WebEditingTester/EditingOperations.m:
2977         (editingOperations):
2978         Add the outdent operation to WebEditingTester.
2979
2980 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
2981
2982         Create a plan and a patch files for MotionMark and delete the Animometer's ones
2983         https://bugs.webkit.org/show_bug.cgi?id=166785
2984
2985         Reviewed by Ryosuke Niwa.
2986
2987         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2988         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
2989
2990 2017-01-06  Antoine Quint  <graouts@apple.com>
2991
2992         Support webkit-test-runner key-value pairs in http tests
2993         https://bugs.webkit.org/show_bug.cgi?id=149812
2994
2995         Reviewed by Alex Christensen.
2996
2997         We pass the absolute path for a test through to WKTR so that we can parse
2998         tests that are running as URLs for webkit-test-runner options.
2999
3000         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3001         (parseInputLine):
3002
3003         Explicitly skip the --absolute-path option in DRT or else we'd crash.
3004
3005         * Scripts/webkitpy/port/driver.py:
3006         (Driver._command_from_driver_input):
3007
3008         Pass the absolute path to the file through the CLI.
3009
3010         * WebKitTestRunner/TestController.cpp:
3011         (WTR::updateTestOptionsFromTestHeader):
3012         (WTR::TestController::testOptionsForTest):
3013         (WTR::parseInputLine):
3014         (WTR::TestController::runTest):
3015         * WebKitTestRunner/TestController.h:
3016
3017 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3018
3019         Warning about unconnectable outlets when opening a MiniBrowser window
3020         https://bugs.webkit.org/show_bug.cgi?id=166756
3021
3022         Reviewed by Dan Bernstein.
3023
3024         * MiniBrowser/mac/BrowserWindow.xib:
3025         When launching MiniBrowser, it says:
3026         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
3027             (MBToolbarItem): missing setter or instance variable
3028         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
3029             (NSButtonCell): missing setter or instance variable.
3030
3031         It looks like someone added the connection from the share button
3032         to the BrowserWindowController three times; only one of the connections
3033         is valid. Remove the other two.
3034
3035 2017-01-05  Keith Rollin  <krollin@apple.com>
3036
3037         Add WebCore::URL::protocolHostAndPort
3038         https://bugs.webkit.org/show_bug.cgi?id=166426
3039
3040         Reviewed by Alex Christensen.
3041
3042         Add test for protocolHostAndPort.
3043
3044         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3045         (TestWebKitAPI::TEST_F):
3046
3047 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
3048
3049         [Win] Archive test result is failing.
3050         https://bugs.webkit.org/show_bug.cgi?id=166720
3051
3052         Reviewed by Alex Christensen.
3053
3054         Deleting the layout test result folder is sometimes failing
3055         on Windows. This is not a critical error.
3056
3057         * BuildSlaveSupport/test-result-archive:
3058         (archiveTestResults):
3059
3060 2017-01-04  Tomas Popela  <tpopela@redhat.com>
3061
3062         [GTK] Minibrowser: Add printing support
3063         https://bugs.webkit.org/show_bug.cgi?id=165298
3064
3065         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
3066         an error during the print, it's printed on the console.
3067
3068         Reviewed by Michael Catanzaro.
3069
3070         * MiniBrowser/gtk/BrowserWindow.c:
3071         (webKitPrintOperationFailedCallback):
3072         (printPage):
3073         (browser_window_init):
3074
3075 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
3076
3077         [css-grid] Fix crash clamping grid lines
3078         https://bugs.webkit.org/show_bug.cgi?id=166637
3079
3080         Reviewed by Darin Adler.
3081
3082         Creates new unit test to verify that the maximum tracks limit
3083         is used in GridPosition too.
3084
3085         * TestWebKitAPI/PlatformEfl.cmake:
3086         * TestWebKitAPI/PlatformGTK.cmake:
3087         * TestWebKitAPI/PlatformWin.cmake:
3088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3089         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
3090         (TestWebKitAPI::TEST):
3091
3092 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3093
3094         Move editing history scripts to WebCore PrivateHeaders
3095         https://bugs.webkit.org/show_bug.cgi?id=166709
3096         <rdar://problem/29876612>
3097
3098         Reviewed by Dan Bernstein.
3099
3100         Update references to editing script files in WebCore that were moved.
3101
3102         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
3103
3104 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3105
3106         Unreviewed, build fix after r210313 part 2
3107         https://bugs.webkit.org/show_bug.cgi?id=166676
3108
3109         Add 'U' suffix.
3110
3111         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3112         (TestWebKitAPI::TEST):
3113         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3114         (TestWebKitAPI::TEST):
3115
3116 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3117
3118         Limit thread name appropriately
3119         https://bugs.webkit.org/show_bug.cgi?id=166676
3120
3121         Reviewed by Sam Weinig.
3122
3123         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3124         (TestWebKitAPI::TEST):
3125         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3126         (TestWebKitAPI::TEST):
3127
3128 2017-01-04  Andy Estes  <aestes@apple.com>
3129
3130         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
3131         https://bugs.webkit.org/show_bug.cgi?id=166696
3132
3133         Reviewed by Tim Horton.
3134
3135         * TestWebKitAPI/PlatformGTK.cmake:
3136         * TestWebKitAPI/PlatformWin.cmake:
3137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3138         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
3139         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
3140         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
3141         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
3142         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
3143         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
3144
3145 2017-01-03  Brian Burg  <bburg@apple.com>
3146
3147         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
3148         https://bugs.webkit.org/show_bug.cgi?id=166003
3149         <rdar://problem/28718990>
3150
3151         Reviewed by Joseph Pecoraro.
3152
3153         Teach run-inspector-generator-tests to generate test output using the platform name
3154         derived from the directory that the test is in. For example, tests in the /generic/
3155         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
3156
3157         * Scripts/webkitpy/inspector/main.py:
3158         (InspectorGeneratorTests.generate_from_json):
3159         (InspectorGeneratorTests.run_tests):
3160         (InspectorGeneratorTests.main):
3161
3162 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3163
3164         Unreviewed cmake buildfix after r210266.
3165
3166         * DumpRenderTree/PlatformMac.cmake:
3167
3168 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3169
3170         Provide a setting for clients to always prefer low-power WebGL
3171         https://bugs.webkit.org/show_bug.cgi?id=166675
3172         <rdar://problem/29834093>
3173
3174         Reviewed by Dan Bernstein.
3175
3176         * MiniBrowser/mac/Info.plist:
3177         Have MiniBrowser claim to be a modern app that supports
3178         automatic graphics switching. WebKit needs to support automatic
3179         graphics switching, so our test app might as well. Without this
3180         Info.plist parameter, this change has no effect, and bringing up
3181         a WebGL context still brings up the discrete GPU (also true of the
3182         existing web-exposed preferLowPowerToHighPerformance API).
3183
3184 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3185
3186         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
3187         https://bugs.webkit.org/show_bug.cgi?id=166645
3188
3189         Reviewed by Carlos Garcia Campos.
3190
3191         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3192         (TestWebKitAPI::TEST):
3193
3194 2017-01-03  Andy Estes  <aestes@apple.com>
3195
3196         Place all the Cocoa WebCore API tests in the same directory
3197         https://bugs.webkit.org/show_bug.cgi?id=166673
3198
3199         Reviewed by Michael Catanzaro.
3200
3201         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3202         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
3203         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
3204         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
3205
3206 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3207
3208         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3209         https://bugs.webkit.org/show_bug.cgi?id=166450
3210         <rdar://problem/29447824>
3211
3212         Reviewed by Darin Adler.
3213
3214         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3215         * DumpRenderTree/TestRunner.cpp:
3216         (TestRunner::staticFunctions):
3217         * DumpRenderTree/mac/TestRunnerMac.mm:
3218         (setSpellCheckerLoggingEnabledCallback):
3219         * DumpRenderTree/win/TestRunnerWin.cpp:
3220         (setSpellCheckerLoggingEnabledCallback):
3221         * DumpRenderTree/mac/DumpRenderTree.mm:
3222         (resetWebViewToConsistentStateBeforeTesting):
3223         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
3224         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
3225         (stringForCorrectionResponse):
3226         (drt_NSSpellChecker_recordResponseToCorrection):
3227         (swizzleNSSpellCheckerMethodsIfNeeded):
3228         (setSpellCheckerLoggingEnabled):
3229         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
3230         set to true, logs to stdout (which ends up in the test result) whenever
3231         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3232         is called, and then calls the original method. It is reset to false between tests.
3233
3234 2017-01-03  Sam Weinig  <sam@webkit.org>
3235
3236         Make WTF::Expected support Ref template parameters
3237         https://bugs.webkit.org/show_bug.cgi?id=166662
3238
3239         Reviewed by Alex Christensen.
3240
3241         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3242         (TestWebKitAPI::TEST):
3243         Add tests for using Ref with Expected.
3244
3245 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3246
3247         [GTK] Expose WebKitSecurityOrigin API
3248         https://bugs.webkit.org/show_bug.cgi?id=166632
3249
3250         Reviewed by Carlos Garcia Campos.
3251
3252         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3253         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
3254         (testSecurityOriginBasicConstructor):
3255         (testSecurityOriginURIConstructor):
3256         (testSecurityOriginDefaultPort):
3257         (testSecurityOriginFileURI):
3258         (testSecurityOriginDataURI):
3259         (beforeAll):
3260         (afterAll):
3261
3262 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3263
3264         [GTK] HTTP auth layout tests are flaky
3265         https://bugs.webkit.org/show_bug.cgi?id=158919
3266
3267         Reviewed by Michael Catanzaro.
3268
3269         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
3270         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
3271         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
3272         missing valac in the bots.
3273
3274 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3275
3276         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
3277         https://bugs.webkit.org/show_bug.cgi?id=165797
3278
3279         Reviewed by Michael Catanzaro.
3280
3281         Move directory ruleset after all exclude rules of Source rulset.
3282
3283         * gtk/manifest.txt.in:
3284
3285 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3286
3287         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
3288         https://bugs.webkit.org/show_bug.cgi?id=166636
3289
3290         Reviewed by Darin Adler.
3291
3292         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3293         (TestWebKitAPI::TEST):
3294
3295 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
3296
3297         [GTK] WebCore/CSSParser unit test is not being built
3298         https://bugs.webkit.org/show_bug.cgi?id=166492
3299
3300         Reviewed by Michael Catanzaro.
3301
3302         This test was introduced in r175930, but we were not building
3303         it on GTK+ port since r176015.
3304         This patch marks the test to be built again on GTK+.
3305         JFTR, the test is passing right now.
3306
3307         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
3308         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
3309
3310 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
3311
3312         AX: Expose block quote level to iOS API
3313         https://bugs.webkit.org/show_bug.cgi?id=166629
3314         <rdar://problem/29834793>
3315
3316         Reviewed by Darin Adler.
3317
3318         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3319         (AccessibilityUIElement::numberAttributeValue):
3320         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3321         (WTR::AccessibilityUIElement::numberAttributeValue):
3322
3323 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
3324
3325         SecurityOrigin::create triplet constructor does not canonicalize port
3326         https://bugs.webkit.org/show_bug.cgi?id=166624
3327
3328         Reviewed by Daniel Bates.
3329
3330         * TestWebKitAPI/PlatformGTK.cmake:
3331         * TestWebKitAPI/PlatformWin.cmake:
3332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3333         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
3334         (TestWebKitAPI::SecurityOriginTest::SetUp):
3335         (TestWebKitAPI::TEST_F):
3336
3337 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3338
3339         [GTK] Improve user agent construction
3340         https://bugs.webkit.org/show_bug.cgi?id=142074
3341
3342         Reviewed by Carlos Garcia Campos.
3343
3344         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3345         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3346         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3347         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3348         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3349         (TestWebKitAPI::TEST):
3350
3351 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3352
3353         [GTK] Improve user agent construction
3354         https://bugs.webkit.org/show_bug.cgi?id=142074
3355
3356         Reviewed by Carlos Garcia Campos.
3357
3358         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3359         (TestWebKitAPI::TEST):
3360
3361 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
3362
3363         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
3364         https://bugs.webkit.org/show_bug.cgi?id=166472
3365         rdar://problem/29675551
3366
3367         Reviewed by Tim Horton.
3368
3369         These changes are necessary to allow the mouse to leave the WTR window while
3370         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
3371         (which DRT does); we'd always go through mouseMoved, which hits an early return
3372         in WebViewImpl::mouseMoved() when the point is outside the view.
3373
3374         * WebKitTestRunner/mac/EventSenderProxy.mm:
3375         (WTR::EventSenderProxy::mouseMoveTo):
3376
3377 2016-12-23  Andy Estes  <aestes@apple.com>
3378
3379         [iOS] Fix some crashing webarchive tests
3380         https://bugs.webkit.org/show_bug.cgi?id=166470
3381
3382         Reviewed by Andreas Kling.
3383
3384         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
3385         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
3386         so this change uses that on both platforms.
3387
3388         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
3389         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
3390         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
3391         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
3392         * WebKitTestRunner/PlatformMac.cmake:
3393         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3394         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3395
3396 2016-12-22  Saam Barati  <sbarati@apple.com>
3397
3398         WebAssembly: Silence the output of the spec-tests
3399         https://bugs.webkit.org/show_bug.cgi?id=166417
3400
3401         Reviewed by Mark Lam.
3402
3403         * Scripts/run-jsc-stress-tests:
3404
3405 2016-12-22  Zhuo Li  <zachli@apple.com>
3406
3407         [Cocoa] SPI for setloadsImagesAutomatically.
3408         https://bugs.webkit.org/show_bug.cgi?id=166401.
3409
3410         Reviewed by Darin Adler.
3411
3412         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3413         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3414         _loadsImagesAutomatically returns YES.
3415
3416 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3417
3418         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3419         https://bugs.webkit.org/show_bug.cgi?id=161328
3420         <rdar://problem/28475977>
3421
3422         Reviewed by Darin Adler.
3423
3424         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3425         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3426         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3427         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3428         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3429         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3430         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3431         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3432         we finish running a test and before we load the next test.
3433
3434         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3435         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3436         previous test started zooming and then finished before zooming completed. Since this happens before the next
3437         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3438
3439         * WebKitTestRunner/ios/TestControllerIOS.mm:
3440         (WTR::TestController::platformResetStateToConsistentValues):
3441
3442 2016-12-22  Jer Noble  <jer.noble@apple.com>
3443
3444         Muted media element playback should not interrupt other audio playback
3445         https://bugs.webkit.org/show_bug.cgi?id=166347
3446
3447         Reviewed by Eric Carlson.
3448
3449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3450         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3451         (TestWebKitAPI::TEST):
3452         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3453
3454 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3455
3456         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3457         https://bugs.webkit.org/show_bug.cgi?id=166346
3458
3459         Reviewed by Carlos Garcia Campos.
3460
3461         Enable WebRTC by default to simplify testing.
3462
3463         * MiniBrowser/gtk/main.c:
3464         (main):
3465
3466 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3467
3468         REGRESSION: API test failure: WKWebView.LocalStorageClear
3469         https://bugs.webkit.org/show_bug.cgi?id=166032
3470         <rdar://problem/29758423>
3471
3472         Reviewed by Simon Fraser.
3473
3474         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3475         to ensure that the view is destroyed before the callback fires.
3476
3477         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3478         (TEST):
3479
3480 2016-12-21  Saam Barati  <sbarati@apple.com>
3481
3482         WebAssembly: Import spec tests
3483         https://bugs.webkit.org/show_bug.cgi?id=166395
3484
3485         Rubber stamped by Keith Miller.
3486
3487         * Scripts/run-jsc-stress-tests:
3488
3489 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3490
3491         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3492         https://bugs.webkit.org/show_bug.cgi?id=166033
3493         <rdar://problem/29758428>
3494
3495         Reviewed by Simon Fraser.
3496
3497         Add an @autoreleasepool around the code that allocates the WKWebView, 
3498         so that it can be destroyed by removing the last reference in _downloadDidStart.
3499
3500         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3501         (TEST):
3502
3503 2016-12-21  Daniel Bates  <dabates@apple.com>
3504
3505         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3506         https://bugs.webkit.org/show_bug.cgi?id=166356
3507
3508         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3509         as a means to allow a test to explicit allow an embedding client to open a new windows
3510         such that the default behavior is for the embedding client to forbid such an action.
3511         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3512         it is currently skipped on WebKit2 because questions were raised in the patch for
3513         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3514         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3515         this test.
3516
3517         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3518         (WTR::TestRunner::setCanOpenWindows):
3519
3520 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3521
3522         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3523         https://bugs.webkit.org/show_bug.cgi?id=166031
3524
3525         Reviewed by Tim Horton.
3526         
3527         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3528         to ensure that the view is destroyed before the callback fires.
3529
3530         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3531
3532 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3533
3534         Throw Exception when test doesn't clean up HID Events properly
3535         https://bugs.webkit.org/show_bug.cgi?id=166271
3536
3537         Reviewed by Simon Fraser.
3538
3539         Add in a check when UIScriptController is deleted to make sure that the HID event
3540         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3541         the program to crash without any good information. Crashes are race-y, and will still
3542         happen with malformed test, but the information will be much more helpful. 
3543
3544         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3545         (WTR::UIScriptController::checkForClean):
3546         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3547         (UIScriptContext::~UIScriptContext):
3548         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3549         (WTR::UIScriptController::checkForClean):
3550         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3551         * WebKitTestRunner/ios/HIDEventGenerator.h:
3552         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3553         (-[HIDEventGenerator checkHIDCallbacksClear]):
3554         * WebKitTestRunner/ios/TestControllerIOS.mm:
3555         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3556         (WTR::UIScriptController::checkForClean):
3557
3558 2016-12-20  Andy Estes  <aestes@apple.com>
3559
3560         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3561         https://bugs.webkit.org/show_bug.cgi?id=165992
3562
3563         Reviewed by Brady Eidson.
3564
3565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3566         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3567         (expectException):
3568         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3569         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3570         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3571         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3572         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3573         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3574         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3575         (TEST):
3576         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3577
3578 2016-12-20  Dean Jackson  <dino@apple.com>
3579
3580         Remove INDIE_UI
3581         https://bugs.webkit.org/show_bug.cgi?id=165881
3582         <rdar://problem/29672532>
3583
3584         Reviewed by Simon Fraser.
3585
3586         The Indie UI work has been discontinued.
3587
3588         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3589
3590 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3591
3592         [ES6] Enable ES6 Modules
3593         https://bugs.webkit.org/show_bug.cgi?id=165849
3594
3595         Reviewed by Geoffrey Garen.
3596
3597         * DumpRenderTree/mac/DumpRenderTree.mm:
3598         (resetWebPreferencesToConsistentValues):
3599         * DumpRenderTree/win/DumpRenderTree.cpp:
3600         (resetWebPreferencesToConsistentValues):
3601         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3602         (WTR::InjectedBundle::beginTesting):
3603         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3604         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3605         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3606
3607 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3608
3609         Repurpose bots and clean up dashboard.
3610         https://bugs.webkit.org/show_bug.cgi?id=166045
3611
3612         Reviewed by Lucas Forschler.
3613
3614         * BuildSlaveSupport/build.webkit.org-config/config.json:
3615         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3616         (BubbleQueueServer):
3617         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3618         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3619         (WebKitBuildbot):
3620         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3621         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3622
3623 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3624
3625         [CMake] TestWebKitAPIBase links to itself
3626         https://bugs.webkit.org/show_bug.cgi?id=165985
3627
3628         Reviewed by Alex Christensen.
3629
3630         Fix CMake warning about a target linking to itself, which makes no sense.
3631
3632         * TestWebKitAPI/CMakeLists.txt:
3633
3634 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3635
3636         [GTK] GtkDoc build should be quieter
3637         https://bugs.webkit.org/show_bug.cgi?id=165994
3638
3639         Reviewed by Carlos Garcia Campos.
3640
3641         Make it not print by default.
3642
3643         * gtk/generate-gtkdoc:
3644         (get_generator_for_config):
3645         (generate_doc):
3646         * gtk/gtkdoc.py:
3647         (GTKDoc._run_command):
3648         (GTKDoc._copy_doc_files_to_output_dir):
3649
3650 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3651
3652         Expose a way for MiniBrowser to simulate header and footer banners
3653         https://bugs.webkit.org/show_bug.cgi?id=166005
3654
3655         Reviewed by Wenson Hsieh.
3656         
3657         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3658         banners. This only works in WebKit2.
3659         
3660         We need to reset these on each navigation, since newly created FrameViews
3661         don't re-fetch the header and footer height stored on Page.
3662         
3663         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3664         as well as fixing webViewWebContentProcessDidTerminate:
3665
3666         * MiniBrowser/mac/SettingsController.h:
3667         * MiniBrowser/mac/SettingsController.m:
3668         (-[SettingsController _populateMenu]):
3669         (-[SettingsController validateMenuItem:]):
3670         (-[SettingsController toggleReserveSpaceForBanners:]):
3671         (-[SettingsController isSpaceReservedForBanners]):
3672         * MiniBrowser/mac/WK2BrowserWindowController.m:
3673         (-[WK2BrowserWindowController didChangeSettings]):
3674         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3675         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3676         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3677         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3678
3679 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3680
3681         Fix iOS test results after r209967.
3682         
3683         Subtracting out the status bar height was erroneously happening for all tests,
3684         not just for flexible viewport tests.
3685         
3686         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3687
3688         * WebKitTestRunner/PlatformWebView.h:
3689         * WebKitTestRunner/TestController.cpp:
3690         (WTR::TestController::resetStateToConsistentValues):
3691         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3692         (WTR::PlatformWebView::resizeTo):
3693         (WTR::PlatformWebView::setWindowFrame):
3694         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3695         (WTR::PlatformWebView::resizeTo):
3696         (WTR::PlatformWebView::setWindowFrame):
3697         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3698         (WTR::PlatformWebView::resizeTo):
3699         (WTR::PlatformWebView::setWindowFrame):
3700         * WebKitTestRunner/ios/TestControllerIOS.mm:
3701         (WTR::TestController::platformConfigureViewForTest):
3702         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3703         (WTR::PlatformWebView::resizeTo):
3704         (WTR::PlatformWebView::setWindowFrame):
3705
3706 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3707
3708         [EFL] bump EFL version to 1.18.4
3709         https://bugs.webkit.org/show_bug.cgi?id=166004
3710
3711         Reviewed by Gyuyoung Kim.
3712
3713         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3714
3715 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3716
3717         Visual viewports: bottom fixed elements disappear behind the keyboard
3718         https://bugs.webkit.org/show_bug.cgi?id=165983
3719         <rdar://problem/29409852>
3720
3721         Reviewed by Simon Fraser.
3722
3723         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
3724         the keyboard when it is up.
3725
3726         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3727         (WTR::UIScriptController::inputViewBounds):
3728         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3729         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3730         (WTR::UIScriptController::inputViewBounds):
3731         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3732         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3733         (WTR::viewRectForWindowRect):
3734
3735         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
3736         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
3737         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
3738
3739         (WTR::PlatformWebView::PlatformWebView):
3740         (WTR::PlatformWebView::setWindowFrame):
3741         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3742         (WTR::UIScriptController::inputViewBounds):
3743
3744 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3745
3746         Deleting a character converted from pinyin after an image causes a Safari crash
3747         https://bugs.webkit.org/show_bug.cgi?id=165839
3748         <rdar://problem/27951933>
3749
3750         Reviewed by Wenson Hsieh.
3751
3752         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
3753         while the proposed range contains an image. This should not cause a WebProcess to crash
3754         or send an invalid message to the UIProcess.
3755
3756         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3757         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
3758         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
3759         (TestWebKitAPI::didFinishLoadForFrame):
3760         (TestWebKitAPI::processDidCrash):
3761         (TestWebKitAPI::invalidMessageFunction):
3762         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
3763
3764 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3765
3766         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
3767         https://bugs.webkit.org/show_bug.cgi?id=165767
3768         <rdar://problem/29602382>
3769
3770         Reviewed by Simon Fraser.
3771
3772         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
3773         WebKit2 ChangeLog for more details.
3774
3775         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3776         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3777         (WTR::UIScriptController::textSelectionCaretRect):
3778         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3779         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3780         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3781         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3782         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3783         (WTR::UIScriptController::textSelectionCaretRect):
3784         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3785         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3786         (-[TestRunnerWKWebView _setStableStateOverride:]):
3787
3788         Force the WKWebView to update its visible content rects when changing the stable state override.
3789
3790         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3791         (WTR::toNSDictionary):
3792         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3793         (WTR::UIScriptController::selectionRangeViewRects):
3794         (WTR::UIScriptController::textSelectionCaretRect):
3795         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3796         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3797
3798 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
3799
3800         Arguments called in wrong order
3801         https://bugs.webkit.org/show_bug.cgi?id=165923
3802
3803         Reviewed by Simon Fraser.
3804
3805         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
3806         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
3807
3808         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3809         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
3810         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
3811
3812 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
3813
3814         [EFL] Disable non-srcdir builds for failing libraries
3815         https://bugs.webkit.org/show_bug.cgi?id=165896
3816
3817         Reviewed by Gyuyoung Kim.
3818
3819         * efl/jhbuild.modules: Set non srcdir builds to no
3820
3821 2016-12-15  Daniel Bates  <dabates@apple.com>
3822
3823         check-style should not complain about code in icu directories
3824         https://bugs.webkit.org/show_bug.cgi?id=53929
3825
3826         Reviewed by Darin Adler.
3827
3828         Skip style checking of imported ICU headers to avoid a deluge of style issues
3829         as they do not conform to the WebKit Code Style guideline. We want to preserve
3830         the formatting of these headers so as to make it straightforward to merge
3831         changes to them, if necessary.
3832
3833         * Scripts/webkitpy/style/checker.py:
3834
3835 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
3836
3837         Move JSC testers from Yosemite to Sierra
3838         https://bugs.webkit.org/show_bug.cgi?id=165925
3839
3840         Reviewed by Lucas Forschler.
3841
3842         * BuildSlaveSupport/build.webkit.org-config/config.json:
3843         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3844         (WebKitBuildbot):
3845
3846 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
3847
3848         Add coordinate space to event streams and streamline tests
3849         https://bugs.webkit.org/show_bug.cgi?id=165119
3850
3851         Reviewed by Simon Fraser.
3852
3853         Update event streams to allow for both content and global coordinate space.
3854         Update example script to more accurately show all the available options.
3855
3856         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3857         * WebKitTestRunner/ios/HIDEventGenerator.h:
3858         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3859         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3860         (WTR::convertCoordinates):
3861         (WTR::UIScriptController::sendEventStream):
3862
3863 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
3864
3865         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
3866         https://bugs.webkit.org/show_bug.cgi?id=165855
3867
3868         Reviewed by Philippe Normand.
3869
3870         GStreamer's autogen.sh enables gtk-doc always so we end up building
3871         docs even if we disable them. Use the configure script instead, since
3872         we build from packages and these include it already.
3873
3874         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
3875         upstream gstreamer packages.
3876
3877 2016-12-15  Alex Christensen  <achristensen@webkit.org>
3878
3879         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
3880         https://bugs.webkit.org/show_bug.cgi?id=165885
3881         <rdar://problem/29476917>
3882
3883         Reviewed by Darin Adler.
3884
3885         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3886         (TestWebKitAPI::utf16String): Deleted.
3887         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
3888         (TestWebKitAPI::TEST_F):
3889         * TestWebKitAPI/WTFStringUtilities.h:
3890         (utf16String):
3891         Moved from URLParser to share with other tests.
3892
3893 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3894
3895         iOS: An element with tabindex is not focusable unless there is no mouse event handler
3896         https://bugs.webkit.org/show_bug.cgi?id=165843
3897
3898         Reviewed by Antti Koivisto.
3899
3900         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
3901         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
3902         and DumpRenderTree's runUIScript would hit an assertion :(
3903
3904         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3905         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3906         (WTR::TestRunner::isWebKit2):
3907
3908 2016-12-14  Brady Eidson  <beidson@apple.com>
3909
3910         IndexedDB 2.0: Massively speedup IDBIndex.get().
3911         https://bugs.webkit.org/show_bug.cgi?id=165802
3912
3913         Reviewed by Alex Christensen.
3914
3915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3916         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
3917         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
3918         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
3919         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
3920
3921 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3922
3923         [GTK][EFL] Update the JHBuild version.
3924         https://bugs.webkit.org/show_bug.cgi?id=165838
3925
3926         Reviewed by Michael Catanzaro.
3927
3928         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
3929         usage of the JHBUILD_MIRROR feature with git repositories.
3930
3931 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3932
3933         [GTK] Yasm is needed for building the JHBuild after r208940
3934         https://bugs.webkit.org/show_bug.cgi?id=165837
3935
3936         Reviewed by Alejandro G. Castro.
3937
3938         * gtk/install-dependencies: Yasm is needed for building libvpx.
3939
3940 2016-12-14  Youenn Fablet  <youenn@apple.com>
3941
3942         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
3943         https://bugs.webkit.org/show_bug.cgi?id=161310
3944
3945         Reviewed by Ryosuke Niwa.
3946
3947         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
3948         When set, WTR and DRT output JS console log in the stderr and not the test output.
3949         This allows removing potentially flaky information while still being able to read it for investigation.
3950
3951         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
3952
3953         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
3954         This test should have this option when fetch API will start logging resource loader errors.
3955
3956         * DumpRenderTree/DumpRenderTree.h:
3957         (TestCommand::TestCommand): Deleted.
3958         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3959         (parseInputLine):
3960         * DumpRenderTree/TestRunner.h:
3961         (TestRunner::setDumpJSConsoleLogInStdErr):
3962         (TestRunner::dumpJSConsoleLogInStdErr):
3963         * DumpRenderTree/mac/DumpRenderTree.mm:
3964         (runTest):
3965         * DumpRenderTree/mac/UIDelegate.mm:
3966         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3967         * DumpRenderTree/win/DumpRenderTree.cpp:
3968         (runTest):
3969         * DumpRenderTree/win/UIDelegate.cpp:
3970         (UIDelegate::webViewAddMessageToConsole):
3971         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3972         (TestExpectationParser._tokenize_line):
3973         * Scripts/webkitpy/port/driver.py:
3974         (Driver._command_from_driver_input):
3975         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3976         (WTR::InjectedBundle::didReceiveMessageToPage):
3977         (WTR::InjectedBundle::dumpToStdErr):
3978         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3979         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
3980         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3981         (WTR::InjectedBundlePage::willAddMessageToConsole):
3982         * WebKitTestRunner/TestController.cpp:
3983         (WTR::parseInputLine):
3984         (WTR::TestController::runTest):
3985         (WTR::TestCommand::TestCommand): Deleted.
3986         * WebKitTestRunner/TestInvocation.cpp:
3987         (WTR::TestInvocation::invoke):
3988         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3989         * WebKitTestRunner/TestInvocation.h:
3990         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
3991
3992
3993 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
3994
3995         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
3996         https://bugs.webkit.org/show_bug.cgi?id=164022
3997
3998         Reviewed by Xabier Rodriguez-Calvar.
3999
4000         * Scripts/webkitperl/FeatureList.pm:
4001           Re-enable MEDIA_SOURCE for the GTK+ port.
4002
4003 2016-12-13  Alex Christensen  <achristensen@webkit.org>
4004
4005         Fix CMake build.
4006
4007         * DumpRenderTree/PlatformMac.cmake:
4008         Define NS_RETURNS_RETAINED as nothing for now.
4009
4010 2016-12-13  Jer Noble  <jer.noble@apple.com>
4011
4012         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
4013         https://bugs.webkit.org/show_bug.cgi?id=165697
4014
4015         Reviewed by Tim Horton.
4016
4017         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
4018         (TestWebKitAPI::TEST):
4019
4020 2016-12-13  Andy Estes  <aestes@apple.com>
4021
4022         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
4023         https://bugs.webkit.org/show_bug.cgi?id=165785
4024         <rdar://problem/26929398>
4025
4026         Reviewed by Darin Adler.
4027
4028         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4029         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
4030         expectations for the text, range, and action.
4031         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
4032         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
4033         plain-text string to the pasteboard, executed a paste action, and verified that the selected
4034         text in the web view did not change.
4035         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
4036         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
4037         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
4038         parameter.
4039         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
4040         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
4041         and returned the value of _editingDelegateShouldInsertText.
4042         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
4043         -shouldInsertText:replacingRange:givenAction:.
4044
4045 2016-12-13  Chris Dumez  <cdumez@apple.com>
4046
4047         Unreviewed, rolling out r209544.
4048
4049         Looks like r209489 did not cause the performance regression
4050         after all
4051
4052         Reverted changeset:
4053
4054         "Unreviewed, rolling out r209489."
4055         https://bugs.webkit.org/show_bug.cgi?id=165550
4056         http://trac.webkit.org/changeset/209544
4057
4058 2016-12-12  Sam Weinig  <sam@webkit.org>
4059
4060         [WebIDL] Remove use of Dictionary in ApplePaySession
4061         https://bugs.webkit.org/show_bug.cgi?id=165787
4062
4063         Reviewed by Anders Carlsson.
4064
4065         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4066         (WTR::initializeWebViewConfiguration):
4067         (WTR::TestController::platformCreateWebView):
4068         Enable ApplePay for the tests (where supported).
4069
4070 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
4071
4072         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
4073         https://bugs.webkit.org/show_bug.cgi?id=165251
4074
4075         Reviewed by Youenn Fablet.
4076
4077         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
4078         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
4079         the preferences have been set.
4080
4081 2016-12-08  Antti Koivisto  <antti@apple.com>
4082
4083         Enable network cache speculative revalidation in MiniBrowser
4084         https://bugs.webkit.org/show_bug.cgi?id=165616
4085
4086         Reviewed by Darin Adler.
4087
4088         Match Safari. Also add a menu item to disable it.
4089
4090         * MiniBrowser/mac/AppDelegate.m:
4091         (defaultConfiguration):
4092         * MiniBrowser/mac/SettingsController.h:
4093         * MiniBrowser/mac/SettingsController.m:
4094         (-[SettingsController _populateMenu]):
4095         (-[SettingsController validateMenuItem:]):
4096         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
4097         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
4098
4099 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
4100
4101         ChangeLogs become readonly after resolving a conflict
4102         https://bugs.webkit.org/show_bug.cgi?id=165440
4103         rdar://problem/29491002
4104
4105         Reviewed by Darin Adler.
4106
4107         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
4108         moving the file.
4109
4110 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
4111
4112         Re-enable collectContinuously since it doesn't crash anymore
4113
4114         Rubber stamped by Michael Saboff.
4115
4116         * Scripts/run-jsc-stress-tests:
4117
4118 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
4119
4120         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
4121         https://bugs.webkit.org/show_bug.cgi?id=165686
4122
4123         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
4124         so that right config.h comes first in include path.
4125
4126 2016-12-11  Dave Hyatt  <hyatt@apple.com>
4127
4128         [CSS Parser] Make sure content extensions initialize AtomicString
4129         https://bugs.webkit.org/show_bug.cgi?id=165737
4130
4131         Reviewed by Darin Adler.
4132
4133         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4134         (TestWebKitAPI::makeBackend):
4135
4136 2016-12-08  Dave Hyatt  <hyatt@apple.com>
4137
4138         [CSS Parser] Remove the old CSS Parser
4139         https://bugs.webkit.org/show_bug.cgi?id=165645
4140
4141         Reviewed by Daniel Bates.
4142
4143         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
4144         (TestWebKitAPI::TEST):
4145
4146 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
4147
4148         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
4149         https://bugs.webkit.org/show_bug.cgi?id=165686
4150
4151         Reviewed by Michael Catanzaro.
4152
4153         This change reduces duplication of include path lists between modules,
4154         and reduces future need for fixes like r209605 (broken build because of
4155         WebCore header suddenly becoming used in WebKit2).
4156
4157         * DumpRenderTree/CMakeLists.txt:
4158         * DumpRenderTree/PlatformMac.cmake:
4159         * ImageDiff/CMakeLists.txt:
4160         * MiniBrowser/gtk/CMakeLists.txt:
4161         * MiniBrowser/mac/CMakeLists.txt:
4162         * MiniBrowser/win/CMakeLists.txt:
4163         * TestWebKitAPI/CMakeLists.txt:
4164         * TestWebKitAPI/PlatformEfl.cmake:
4165         * TestWebKitAPI/PlatformJSCOnly.cmake:
4166         * TestWebKitAPI/PlatformMac.cmake:
4167         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
4168         * WebKitTestRunner/CMakeLists.txt:
4169         * WebKitTestRunner/PlatformGTK.cmake:
4170         * WebKitTestRunner/PlatformMac.cmake:
4171
4172 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
4173
4174         Unreviewed buildfix after r209630.
4175
4176         * Scripts/build-jsc: Remove building the non-existing testWASM.
4177
4178 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
4179
4180         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
4181         https://bugs.webkit.org/show_bug.cgi?id=165251
4182
4183         Reviewed by Dean Jackson.
4184
4185         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
4186
4187         * DumpRenderTree/mac/DumpRenderTree.mm:
4188         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
4189
4190         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4191         (WTR::InjectedBundle::beginTesting): Ditto.
4192
4193         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4194         (WTR::TestRunner::setMediaStreamEnabled): New.
4195         (WTR::TestRunner::setPeerConnectionEnabled): New.
4196         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4197
4198 2016-12-09  Brady Eidson  <beidson@apple.com> 
4199  
4200         Re-landing:
4201         Add _WKIconLoadingDelegate SPI. 
4202         https://bugs.webkit.org/show_bug.cgi?id=164894 
4203  
4204         Reviewed by Alex Christensen. 
4205         
4206         Add MiniBrowser support for this new SPI, configurable with a setting. 
4207  
4208         * MiniBrowser/mac/SettingsController.h: 
4209         * MiniBrowser/mac/SettingsController.m: 
4210         (-[SettingsController _populateMenu]): 
4211         (-[SettingsController validateMenuItem:]): 
4212         (-[SettingsController loadsAllSiteIcons]): 
4213         (-[SettingsController toggleLoadsAllSiteIcons:]): 
4214         * MiniBrowser/mac/WK2BrowserWindowController.m: 
4215         (-[WK2BrowserWindowController awakeFromNib]): 
4216         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
4217
4218 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
4219
4220         Fix the 32-bit build.
4221
4222         Unreviewed build fix.
4223
4224         * MiniBrowser/mac/SettingsController.h:
4225
4226 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4227
4228         Fedora also needs a PHP7 config file alternative
4229         https://bugs.webkit.org/show_bug.cgi?id=165606
4230
4231         Reviewed by Michael Catanzaro.
4232
4233         * Scripts/webkitpy/port/base.py:
4234         (Port._is_fedora_php_version_7): check for the php7 library.
4235         (Port._fedora_php_version): get the appropriate filename for Fedora.
4236         (Port._apache_config_file_name_for_platform):
4237
4238 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
4239
4240         Complete the revert of r208865.
4241         https://bugs.webkit.org/show_bug.cgi?id=164894
4242
4243         Unreviewed build fix.
4244
4245         * MiniBrowser/mac/SettingsController.h:
4246         * MiniBrowser/mac/SettingsController.m:
4247         (-[SettingsController _populateMenu]):
4248         (-[SettingsController validateMenuItem:]):
4249         (-[SettingsController loadsAllSiteIcons]): Deleted.
4250         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
4251         * MiniBrowser/mac/WK2BrowserWindowController.m:
4252         (-[WK2BrowserWindowController awakeFromNib]):
4253         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
4254
4255 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4256
4257         [GTK] Force GDK backend to x11 when running with XvfbDriver
4258         https://bugs.webkit.org/show_bug.cgi?id=165612
4259
4260         Reviewed by Michael Catanzaro.
4261
4262         When the developer is running a Wayland session, GDK may get confused
4263         and try to use its Wayland backend (which is higher priority) instead.
4264         This ensures it will use the appropriate backend when running under
4265         Xvfb.
4266
4267         * Scripts/webkitpy/port/gtk.py:
4268         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
4269         force GDK_BACKEND to x11.
4270
4271 2016-12-08  Keith Miller  <keith_miller@apple.com>
4272
4273         Add 64-bit signed LEB decode method
4274         https://bugs.webkit.org/show_bug.cgi?id=165630
4275
4276         Reviewed by Ryosuke Niwa.
4277
4278         Add tests for LEB int64 and uint64 decode since I guess
4279         I forgot to add tests before.
4280
4281         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
4282         (TestWebKitAPI::testUInt32LEBDecode):
4283         (TestWebKitAPI::TEST):
4284         (TestWebKitAPI::testUInt64LEBDecode):
4285         (TestWebKitAPI::testInt32LEBDecode):
4286         (TestWebKitAPI::testInt64LEBDecode):
4287         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
4288
4289 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
4290
4291         Make it easy to enable --force-collectContinuously
4292         https://bugs.webkit.org/show_bug.cgi?id=165638
4293
4294         Reviewed by Keith Miller.
4295
4296         * Scripts/run-javascriptcore-tests:
4297         (runJSCStressTests):
4298
4299 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
4300
4301         Disable the collectContinuously mode until I investigate failures.
4302
4303         Rubber stamped by Keith Miller.
4304         
4305         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
4306         while I investigate.
4307
4308         * Scripts/run-jsc-stress-tests:
4309
4310 2016-12-08  Alex Christensen  <achristensen@webkit.org>
4311
4312         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
4313         https://bugs.webkit.org/show_bug.cgi?id=165621
4314
4315         Reviewed by Dan Bernstein.
4316
4317         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4318         (TestWebKitAPI::TEST_F):
4319
4320 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
4321
4322         Concurrent GC should be stable enough to land enabled
4323         https://bugs.webkit.org/show_bug.cgi?id=164990
4324
4325         Reviewed by Geoffrey Garen.
4326         
4327         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
4328