fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work...
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
4         https://bugs.webkit.org/show_bug.cgi?id=194313
5
6         Reviewed by Tim Horton.
7
8         Add a helper to determine whether the web view is presenting modal UI.
9
10         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
11         (WTR::UIScriptController::isPresentingModally const):
12         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
13         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
14         (WTR::UIScriptController::isPresentingModally const):
15         * TestRunnerShared/UIScriptContext/UIScriptController.h:
16         * WebKitTestRunner/UIScriptControllerCocoa.mm:
17         (WTR::UIScriptController::calendarType const): Deleted.
18         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
19         (WTR::UIScriptController::isPresentingModally const):
20         (WTR::UIScriptController::calendarType const):
21         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
22         (WTR::UIScriptController::calendarType const):
23
24 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
25
26         GCHeapInspector: Show the retained sizes in more places
27         https://bugs.webkit.org/show_bug.cgi?id=194464
28
29         Reviewed by Simon Fraser.
30
31         * GCHeapInspector/gc-heap-inspector.html:
32         * GCHeapInspector/script/interface.js:
33         (HeapInspectorUtils.humanReadableSize):
34         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
35         (HeapInspectorUtils.spanForNode.span.span):
36         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
37         (HeapSnapshotInspector.prototype.buildRoots):
38
39 2019-02-11  Daniel Bates  <dabates@apple.com>
40
41         [iOS] Mouse/Touch/Pointer events are missing modifier keys
42         https://bugs.webkit.org/show_bug.cgi?id=191446
43         <rdar://problem/45929460>
44
45         Reviewed by Tim Horton.
46
47         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
48
49         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
50         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
51         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
52         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
53         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
54         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
55         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
56         * TestRunnerShared/UIScriptContext/UIScriptController.h:
57         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
58         (WTR::arrayLength):
59         (WTR::parseModifierArray):
60         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
61         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
62         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
63         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
64
65 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
66
67         DumpRenderTree should report unknown options
68         https://bugs.webkit.org/show_bug.cgi?id=191303
69
70         Reviewed by Frédéric Wang.
71
72         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
73         to report unknown options.
74         Added and assigned test options which are currently used in tests.
75
76         * DumpRenderTree/TestOptions.cpp:
77         (TestOptions::TestOptions):
78
79 2019-02-11  Truitt Savell  <tsavell@apple.com>
80
81         Unreviewed, rolling out r241229.
82
83         Revision broke internal builds for watchOS.
84
85         Reverted changeset:
86
87         "[Cocoa] Ask platform for generic font family mappings"
88         https://bugs.webkit.org/show_bug.cgi?id=187723
89         https://trac.webkit.org/changeset/241229
90
91 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
92
93         [WinCairo][MiniBrowser] Basic authentication always fails.
94         https://bugs.webkit.org/show_bug.cgi?id=194496
95
96         Reviewed by Don Olmstead.
97
98         * MiniBrowser/win/DialogHelper.h:
99         (Dialog::getText):
100
101 2019-02-11  Philippe Normand  <pnormand@igalia.com>
102
103         [GStreamer] GstMappedBuffer testsuite build fails
104         https://bugs.webkit.org/show_bug.cgi?id=194495
105
106         Reviewed by Carlos Garcia Campos.
107
108         Fix the build by explicitely adding the gstreamer1.0-audio include
109         directories to the include path.
110
111         * TestWebKitAPI/PlatformGTK.cmake:
112         * TestWebKitAPI/PlatformWPE.cmake:
113
114 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
115
116         [GTK][WPE] Add enable-javascript-markup setting
117         https://bugs.webkit.org/show_bug.cgi?id=193439
118
119         Reviewed by Michael Catanzaro.
120
121         Add test cases to check the new setting.
122
123         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
124         (testWebKitSettings):
125         (testWebKitSettingsJavaScriptMarkup):
126         (beforeAll):
127
128 2019-02-10  Darin Adler  <darin@apple.com>
129
130         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
131         https://bugs.webkit.org/show_bug.cgi?id=194485
132
133         Reviewed by Daniel Bates.
134
135         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
136
137 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
138
139         Add more tests for clampTo<>()
140         https://bugs.webkit.org/show_bug.cgi?id=194462
141
142         Reviewed by Geoffrey Garen.
143
144         Darin suggested to test the very last floating point number
145         at the boundaries when truncating to integer.
146         I added test for max/min and max-1/min-1.
147
148         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
149         (TestWebKitAPI::TEST):
150
151 2019-02-09  Darin Adler  <darin@apple.com>
152
153         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
154         https://bugs.webkit.org/show_bug.cgi?id=194021
155
156         Reviewed by Geoffrey Garen.
157
158         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
159         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
160         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
161
162 2019-02-09  Zalan Bujtas  <zalan@apple.com>
163
164         [LFC][IFC] Add intrinsic width support for basic inline containers
165         https://bugs.webkit.org/show_bug.cgi?id=194473
166
167         Reviewed by Antti Koivisto.
168
169         Expand tests coverage (11 new tests -> 798)
170
171         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
172
173 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
174
175         Fix MiniBrowser's entitlements
176         https://bugs.webkit.org/show_bug.cgi?id=192431
177
178         Reviewed by Joseph Pecoraro.
179
180         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
181         files, making it impossible to load any extension.
182
183         * MiniBrowser/MiniBrowser.entitlements:
184
185 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
186
187         [Cocoa] Ask platform for generic font family mappings
188         https://bugs.webkit.org/show_bug.cgi?id=187723
189         <rdar://problem/41892438>
190
191         Reviewed by Brent Fulgham.
192
193         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
194
195         * DumpRenderTree/mac/DumpRenderTree.mm:
196         (allowedFontFamilySet):
197         * WebKitTestRunner/mac/TestControllerMac.mm:
198         (WTR::allowedFontFamilySet):
199
200 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
201
202         [GTK] Implement back/forward touchpad gesture
203         https://bugs.webkit.org/show_bug.cgi?id=193919
204
205         Reviewed by Michael Catanzaro.
206
207         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
208         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
209
210 2019-02-08  Alex Christensen  <achristensen@webkit.org>
211
212         Add SPI to use networking daemon instead of XPC service
213         https://bugs.webkit.org/show_bug.cgi?id=194427
214
215         Reviewed by Geoffrey Garen
216
217         * MiniBrowser/MiniBrowser.entitlements:
218
219 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
220
221         [ews-build] Ensure that every builder in config.json has short name
222         https://bugs.webkit.org/show_bug.cgi?id=194461
223
224         Reviewed by Lucas Forschler.
225
226         * BuildSlaveSupport/ews-build/loadConfig.py:
227         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
228
229 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
230
231         [ews-build] Add short name to config.json
232         https://bugs.webkit.org/show_bug.cgi?id=194456
233
234         Reviewed by Lucas Forschler.
235
236         * BuildSlaveSupport/ews-build/config.json: Added short name.
237         * BuildSlaveSupport/ews-build/loadConfig.py:
238         (loadBuilderConfig): Set the short name as the builder description.
239
240 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
241
242         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
243         https://bugs.webkit.org/show_bug.cgi?id=194418
244
245         Reviewed by Lucas Forschler.
246
247         Do not include errors trying when finding crashlogs at the end of
248         a run-webkit-tests run since we don't process those errors.
249
250         * Scripts/webkitpy/port/darwin.py:
251         (DarwinPort._look_for_all_crash_logs_in_log_dir):
252         * Scripts/webkitpy/port/ios_device.py:
253         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
254         * Scripts/webkitpy/port/watch_device.py:
255         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
256
257 2019-02-08  Beth Dakin  <bdakin@apple.com>
258
259         Add afterScreenUpdates to WKSnapshotConfiguration
260         https://bugs.webkit.org/show_bug.cgi?id=194362
261         -and corresponding-
262         <rdar://problem/40655528> Please add an "after screen updates" property to 
263         WKSnapshotConfiguration (to solve blank snapshots)
264
265         Reviewed by Tim Horton.
266
267         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
268         (TEST):
269
270 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
271
272         clampTo(): do not convert the input to double when dealing with integers
273         https://bugs.webkit.org/show_bug.cgi?id=194263
274         <rdar://problem/47692312>
275
276         Reviewed by Darin Adler.
277
278         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
279         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
280         (TestWebKitAPI::testClampFloatingPointToInteger):
281         (TestWebKitAPI::testClampSameSignIntegers):
282         (TestWebKitAPI::testClampUnsignedToSigned):
283         (TestWebKitAPI::testClampSignedToUnsigned):
284
285 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
286
287         webkitpy: Respect --dedicated-simulators flag
288         https://bugs.webkit.org/show_bug.cgi?id=194416
289         <rdar://problem/47894722>
290
291         Reviewed by Lucas Forschler.
292
293         * Scripts/webkitpy/port/device_port.py:
294         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
295         available devices can be safely ignored.
296
297 2019-02-07  Keith Rollin  <krollin@apple.com>
298
299         Remove extra copy of 100x100-red.tga
300         https://bugs.webkit.org/show_bug.cgi?id=194371
301         <rdar://problem/47873465>
302
303         Reviewed by Said Abou-Hallawa.
304
305         In order to help it pass its tests, Bug 194190 added a second copy of
306         the file 100x100-red.tga. However, it turns out that this additional
307         file wasn't actually needed, and that that sole previous copy was
308         sufficient. At the same time, this second copy -- which was copied to
309         the same location in the build output as the first copy -- now caused
310         XCBuild to complain because there were two production rules for the
311         same output file. Address this by removing the newly-added extra copy.
312
313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
314         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
315
316 2019-02-07  Alex Christensen  <achristensen@webkit.org>
317
318         Deprecate WKBundlePageSetDefersLoading
319         https://bugs.webkit.org/show_bug.cgi?id=191394
320
321         Reviewed by Dean Jackson.
322
323         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
324         (WTR::TestRunner::setDefersLoading):
325
326 2019-02-07  Zalan Bujtas  <zalan@apple.com>
327
328         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
329         https://bugs.webkit.org/show_bug.cgi?id=194391
330
331         Reviewed by Antti Koivisto.
332
333         * LayoutReloaded/misc/LFC-passing-tests.txt:
334
335 2019-02-06  Keith Rollin  <krollin@apple.com>
336
337         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
338         https://bugs.webkit.org/show_bug.cgi?id=193975
339         <rdar://problem/47643306>
340
341         Reviewed by Tim Horton.
342
343         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
344         the Info.plist file into the bundle. This step is not necessary as the
345         implicit "bundle up all the build products into a framework" build
346         phase does this already. Having the Copy Bundle Resources phase do
347         this causes a conflict under XCBuild, which objects to two build
348         phases producing the same file (Info.plist). Address this by removing
349         Info.plist from the Copy Bundle Resources phase.
350
351         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
352
353 2019-02-06  Keith Rollin  <krollin@apple.com>
354
355         Really enable the automatic checking and regenerations of .xcfilelists during builds
356         https://bugs.webkit.org/show_bug.cgi?id=194357
357         <rdar://problem/47861231>
358
359         Reviewed by Chris Dumez.
360
361         Bug 194124 was supposed to enable the automatic checking and
362         regenerating of .xcfilelist files during the build. While related
363         changes were included in that patch, the change to actually enable the
364         operation somehow was omitted. This patch actually enables the
365         operation. The check-xcfilelist.sh scripts now check
366         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
367         from the checking.
368
369         * DumpRenderTree/Scripts/check-xcfilelists.sh:
370         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
371
372 2019-02-06  David Kilzer  <ddkilzer@apple.com>
373
374         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
375         <https://webkit.org/b/194286>
376         <rdar://problem/47815558>
377
378         Reviewed by Alexey Proskuryakov.
379
380         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
381         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
382         WKRetainPtr<> to avoid leaking the WKDataRef.
383
384 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
385
386         Unreviewed, fix a typo
387
388         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
389
390 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
391
392         [GTK][WPE] force libpsl build to use ICU in jhbuild
393         https://bugs.webkit.org/show_bug.cgi?id=194288
394
395         Reviewed by Carlos Garcia Campos.
396
397         * gtk/jhbuild.modules:
398         Require ICU for libpsl build in jhbuild, like done in WPE.
399
400 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
401
402         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
403         https://bugs.webkit.org/show_bug.cgi?id=194209
404
405         Reviewed by Carlos Garcia Campos.
406
407         Enhance TestCookieManager to ensure this doesn't happen again.
408
409         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
410         (testCookieManagerPersistentStorage):
411         (beforeAll):
412
413 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
414
415         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
416         https://bugs.webkit.org/show_bug.cgi?id=194324
417
418         Reviewed by Andy Estes.
419
420         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
421         part of the name is already implicit, since this is in testing code in TestOptions.
422
423         * WebKitTestRunner/TestController.cpp:
424         (WTR::TestController::generateContextConfiguration const):
425         (WTR::updateTestOptionsFromTestHeader):
426         * WebKitTestRunner/TestOptions.h:
427         (WTR::TestOptions::hasSameInitializationOptions const):
428
429 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
430
431         [ews-build] Allow * as platform for builders and workers
432         https://bugs.webkit.org/show_bug.cgi?id=188533
433
434         Reviewed by Lucas Forschler.
435
436         * BuildSlaveSupport/ews-build/loadConfig.py:
437         (checkWorkersAndBuildersForConsistency):
438
439 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
440
441         [ews-build] Add few bots to config.json
442         https://bugs.webkit.org/show_bug.cgi?id=194304
443
444         Reviewed by Lucas Forschler.
445
446         * BuildSlaveSupport/ews-build/config.json:
447
448 2019-02-05  Keith Rollin  <krollin@apple.com>
449
450         Enable the automatic checking and regenerations of .xcfilelists during builds
451         https://bugs.webkit.org/show_bug.cgi?id=194124
452         <rdar://problem/47721277>
453
454         Reviewed by Tim Horton.
455
456         Bug 193790 add a facility for checking -- during build time -- that
457         any needed .xcfilelist files are up-to-date and for updating them if
458         they are not. This facility was initially opt-in by setting
459         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
460         the process seemed robust. Its now time to enable this facility and
461         make it opt-out. If there is a need to disable this facility, set and
462         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
463         running `make` or `build-webkit`, or before running Xcode from the
464         command line.
465
466         Additionally, remove the step that generates a list of source files
467         going into the UnifiedSources build step. It's only necessarily to
468         specify Sources.txt and SourcesCocoa.txt as inputs.
469
470         * Scripts/generate-xcfilelists:
471
472 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
473
474         [GTK][WPE] force libpsl build to use ICU in jhbuild
475         https://bugs.webkit.org/show_bug.cgi?id=194288
476
477         Reviewed by Philippe Normand.
478
479         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
480         This can cause build failures if libidn is detected but libunistring is not available.
481
482         Make sure that ICU is used for runtime and builtin PSL data.
483
484         * gtk/jhbuild.modules:
485         * wpe/jhbuild.modules:
486
487 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
488
489         [ews-app] Modified timestamp should be updated on updating data
490         https://bugs.webkit.org/show_bug.cgi?id=194295
491
492         Reviewed by Lucas Forschler.
493
494         * BuildSlaveSupport/ews-app/ews/models/build.py:
495         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
496         * BuildSlaveSupport/ews-app/ews/models/step.py:
497
498 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
499
500         Unreviewed, rolling out r240742.
501
502         Causes crashes on iOS simulator.
503
504         Reverted changeset:
505
506         "[iOS] Keyups for non-modifier keys identified as "Dead" when
507         not focused in a content-editable element"
508         https://bugs.webkit.org/show_bug.cgi?id=192824
509         https://trac.webkit.org/changeset/240742
510
511 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
512
513         run-webkit-tests emits message "...running None" when running tests
514         https://bugs.webkit.org/show_bug.cgi?id=194133
515         <rdar://problem/47724738>
516
517         Reviewed by Lucas Forschler.
518
519         * Scripts/webkitpy/xcode/device_type.py:
520         (DeviceType.__str__): Use both version mapping tables and use just the variant
521         name if no version name is available.
522         * Scripts/webkitpy/xcode/device_type_unittest.py:
523         (DeviceTypeTest):
524         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
525         an associated named.
526
527 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
528
529         [WPE] require python3-setuptools for meson build in jhbuild
530         https://bugs.webkit.org/show_bug.cgi?id=194287
531
532         Reviewed by Philippe Normand.
533
534         python3-setuptools is needed to build meson in jhbuild.
535         It is already required by the GTK port.
536
537         * wpe/install-dependencies:
538
539 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
540
541         [ews-app] Add method to save BuilderMapping to database
542         https://bugs.webkit.org/show_bug.cgi?id=194264
543
544         Reviewed by Lucas Forschler.
545
546         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
547         (BuilderMapping.__str__):
548         (BuilderMapping):
549         (BuilderMapping.save_mapping):
550         (BuilderMapping.update_mapping):
551         (BuilderMapping.get_existing_mapping):
552         (BuilderMapping.is_valid_mapping):
553
554 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
555
556         [ews-app] Add timestamp fields for BuilderMappings
557         https://bugs.webkit.org/show_bug.cgi?id=194266
558
559         Reviewed by Lucas Forschler.
560
561         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
562         (BuilderMapping):
563
564 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
565
566         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
567         https://bugs.webkit.org/show_bug.cgi?id=174816
568
569         Reviewed by Michael Catanzaro.
570
571         Add tests for webkit_uri_for_display().
572
573         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
574         (testURIForDisplayUnaffected):
575         (testURIForDisplayAffected):
576         (beforeAll):
577         (afterAll):
578         * TestWebKitAPI/glib/CMakeLists.txt:
579
580 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
581
582         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
583         https://bugs.webkit.org/show_bug.cgi?id=194158
584         <rdar://problem/47737268>
585
586         Rubber-stamped by Aakash Jain.
587
588         * Scripts/webkitpy/port/device_port.py:
589         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
590
591 2019-02-04  Said Abou-Hallawa  <said@apple.com>
592
593         [CG] Enable setAdditionalSupportedImageTypes for WK1
594         https://bugs.webkit.org/show_bug.cgi?id=194190
595
596         Reviewed by Tim Horton.
597
598         Add a test similar to the one under WebKit Cocoa but make it create a
599         WebView instead of a WKWebView.
600
601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
602         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
603         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
604         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
605         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
606         (TestWebKitAPI::runTest):
607         (TestWebKitAPI::TEST):
608
609 2019-02-04  Zalan Bujtas  <zalan@apple.com>
610
611         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
612         https://bugs.webkit.org/show_bug.cgi?id=194168
613
614         Reviewed by Simon Fraser.
615
616         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
617
618         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
619         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
620         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
621         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
622         (TEST):
623         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
624         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
625
626 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
627
628         REGRESSION (r237269): webkit-patch what-broke is broken 
629         https://bugs.webkit.org/show_bug.cgi?id=193025
630
631         Reviewed by Aakash Jain.
632
633         * Scripts/webkitpy/common/host.py:
634         (Host.buildbot):
635         (Host.bugzilla): Renamed to 'buildbot'.
636
637 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
638
639         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
640         https://bugs.webkit.org/show_bug.cgi?id=194207
641
642         Reviewed by Tim Horton.
643
644         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
645         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
646         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
647         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
648         start and delete forwards to remove the original attachment.
649
650         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
651         (TestWebKitAPI::TEST):
652
653 2019-02-04  Youenn Fablet  <youenn@apple.com>
654
655         Capture state should be managed consistently when doing process swapping
656         https://bugs.webkit.org/show_bug.cgi?id=194122
657         <rdar://problem/47609293>
658
659         Reviewed by Eric Carlson.
660
661         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
662         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
663         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
664         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
665         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
666         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
667         (WTR::TestRunner::isDoingMediaCapture const):
668         * WebKitTestRunner/InjectedBundle/TestRunner.h:
669         * WebKitTestRunner/TestController.cpp:
670         (WTR::TestController::isDoingMediaCapture const):
671         * WebKitTestRunner/TestController.h:
672         * WebKitTestRunner/TestInvocation.cpp:
673         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
674         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
675         (WTR::TestController::isDoingMediaCapture const):
676
677 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
678
679         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
680         https://bugs.webkit.org/show_bug.cgi?id=194142
681
682         Reviewed by Ross Kirsling.
683
684         There three 'separator' variables in TestController.cpp. Renamed
685         it 'pathSeparator', and unified them.
686
687         * WebKitTestRunner/TestController.cpp:
688         (WTR::TestController::generateContextConfiguration const):
689         (WTR::createTestURL):
690         (WTR::TestController::platformAdjustContext):
691
692 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
693
694         Make setNeedsLayout on the root more explicitly about triggering its side-effects
695         https://bugs.webkit.org/show_bug.cgi?id=194198
696
697         Reviewed by Antti Koivisto.
698
699         No need to set the banner heights on navigation now, since Page stores them.
700
701         * MiniBrowser/mac/WK2BrowserWindowController.m:
702         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
703
704 2019-02-03  John Wilander  <wilander@apple.com>
705
706         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
707         https://bugs.webkit.org/show_bug.cgi?id=194104
708         <rdar://problem/47649991>
709
710         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
711
712         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
713         (TestWebKitAPI::TEST):
714             Changed numeric types from unsigned short to uint32_t.
715
716 2019-02-02  David Kilzer  <ddkilzer@apple.com>
717
718         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
719         <https://webkit.org/b/194178>
720         <rdar://problem/47753473>
721
722         Reviewed by Alexey Proskuryakov.
723
724         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
725         (WTR::uninstallFakeHelvetica): Pass nullptr into
726         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
727
728 2019-02-02  Zalan Bujtas  <zalan@apple.com>
729
730         [LFC] Initialize ICB's style with fixed width/height.
731         https://bugs.webkit.org/show_bug.cgi?id=194188
732
733         Reviewed by Antti Koivisto.
734
735         * LayoutReloaded/misc/LFC-passing-tests.txt:
736
737 2019-02-02  Zalan Bujtas  <zalan@apple.com>
738
739         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
740         https://bugs.webkit.org/show_bug.cgi?id=194185
741
742         Reviewed by Antti Koivisto.
743
744         * LayoutReloaded/misc/LFC-passing-tests.txt:
745
746 2018-12-16  Darin Adler  <darin@apple.com>
747
748         Convert additional String::format clients to alternative approaches
749         https://bugs.webkit.org/show_bug.cgi?id=192746
750
751         Reviewed by Alexey Proskuryakov.
752
753         * WebKitTestRunner/TestController.cpp:
754         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
755         as an intermediate in code that ultimately constructs a WTF::String.
756         (WTR::userMediaOriginHash): Use makeString.
757         (WTR::TestController::didNavigateWithNavigationData): More of the same.
758         (WTR::TestController::didPerformClientRedirect): Ditto.
759         (WTR::TestController::didPerformServerRedirect): Ditto.
760         (WTR::TestController::didUpdateHistoryTitle): Ditto.
761
762 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
763
764         [ews-build] Add unit test to verify builder keys
765         https://bugs.webkit.org/show_bug.cgi?id=194152
766
767         Reviewed by Lucas Forschler.
768
769         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
770         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
771
772 2019-02-01  Zalan Bujtas  <zalan@apple.com>
773
774         [LFC] Expand tests coverage (12 new tests -> 787)
775
776         Unreviewed test gardening.
777
778         * LayoutReloaded/misc/LFC-passing-tests.txt:
779
780 2019-02-01  Zalan Bujtas  <zalan@apple.com>
781
782         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
783         https://bugs.webkit.org/show_bug.cgi?id=194163
784
785         Reviewed by Simon Fraser.
786
787         775
788
789         * LayoutReloaded/misc/LFC-passing-tests.txt:
790
791 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
792
793         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
794         https://bugs.webkit.org/show_bug.cgi?id=194140
795         <rdar://problem/47728098>
796
797         Reviewed by Tim Horton.
798
799         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
800         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
801         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
802
803         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
804         test to induce an IPC deadlock when presenting a modal alert during touch start.
805
806         * WebKitTestRunner/InjectedBundle/TestRunner.h:
807         * WebKitTestRunner/TestController.cpp:
808         (WTR::runJavaScriptAlert):
809
810         Add a client callback function for running JavaScript alerts.
811
812         (WTR::TestController::createOtherPage):
813         (WTR::TestController::generateContextConfiguration const):
814
815         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
816         the fix in this patch.
817
818         (WTR::TestController::createWebViewWithOptions):
819
820         Plumb TestOptions to generateContextConfiguration.
821
822         (WTR::TestController::resetPreferencesToConsistentValues):
823         (WTR::TestController::resetStateToConsistentValues):
824         (WTR::updateTestOptionsFromTestHeader):
825         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
826         (WTR::TestController::handleJavaScriptAlert):
827         * WebKitTestRunner/TestController.h:
828         * WebKitTestRunner/TestInvocation.cpp:
829         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
830         * WebKitTestRunner/TestOptions.h:
831         (WTR::TestOptions::hasSameInitializationOptions const):
832
833 2019-02-01  Chris Dumez  <cdumez@apple.com>
834
835         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
836         https://bugs.webkit.org/show_bug.cgi?id=193740
837         <rdar://problem/47527267>
838
839         Reviewed by Alex Christensen.
840
841         Add API test coverage.
842
843         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
844
845 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
846
847         [ews-app] Add display name field to BuilderMapping model
848         https://bugs.webkit.org/show_bug.cgi?id=194153
849
850         Reviewed by Lucas Forschler.
851
852         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
853         (BuilderMapping):
854
855 2019-02-01  Youenn Fablet  <youenn@apple.com>
856
857         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
858         https://bugs.webkit.org/show_bug.cgi?id=194155
859
860         Reviewed by Eric Carlson.
861
862         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
863         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
864         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
865
866 2019-02-01  Zalan Bujtas  <zalan@apple.com>
867
868         [LFC] Adjust replaced element's intrinsic ratio
869         https://bugs.webkit.org/show_bug.cgi?id=194154
870
871         Reviewed by Antti Koivisto.
872
873         761
874
875         * LayoutReloaded/misc/LFC-passing-tests.txt:
876
877 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
878
879         [WPE] Show test results in minibrowser
880         https://bugs.webkit.org/show_bug.cgi?id=194150
881
882         Reviewed by Žan Doberšek.
883
884         * Scripts/webkitpy/port/wpe.py:
885         (WPEPort.show_results_html_file):
886
887 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
888
889         [WPE] MiniBrowser: add ky bindings for back/forward navigation
890         https://bugs.webkit.org/show_bug.cgi?id=194151
891
892         Reviewed by Žan Doberšek.
893
894         ALT + <- go back
895         ALT + -> go forward
896
897         * MiniBrowser/wpe/main.cpp:
898         (main):
899
900 2019-02-01  Zalan Bujtas  <zalan@apple.com>
901
902         [LFC] Set intrinsic size on Layout::Replaced
903         https://bugs.webkit.org/show_bug.cgi?id=194139
904
905         Reviewed by Antti Koivisto.
906
907         744
908
909         * LayoutReloaded/misc/LFC-passing-tests.txt:
910
911 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
912
913         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
914         https://bugs.webkit.org/show_bug.cgi?id=194146
915
916         Reviewed by Xabier Rodriguez-Calvar.
917
918         It allows to open relative paths.
919
920         * MiniBrowser/wpe/main.cpp:
921         (main):
922
923 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
924
925         Update flakiness dashboard configuration after recent queue changes
926         https://bugs.webkit.org/show_bug.cgi?id=194127
927
928         Rubber-stamped by Aakash Jain.
929
930         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
931
932         * TestResultServer/static-dashboards/builders.jsonp:
933
934 2019-01-31  Youenn Fablet  <youenn@apple.com>
935
936         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
937         https://bugs.webkit.org/show_bug.cgi?id=194106
938         <rdar://problem/47676333>
939
940         Reviewed by Ryosuke Niwa.
941
942         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
943         (TestWebKitAPI::didFinishNavigation):
944         (TestWebKitAPI::TEST):
945         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
946
947 2019-01-31  Chris Dumez  <cdumez@apple.com>
948
949         Page zoom level is lost after a process swap or a crash
950         https://bugs.webkit.org/show_bug.cgi?id=194105
951         <rdar://problem/47610781>
952
953         Reviewed by Alex Christensen.
954
955         Add API test coverage.
956
957         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
958         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
959
960 2019-01-31  Alex Christensen  <achristensen@webkit.org>
961
962         Revert r238819 which is unneeded and caused a performance regression.
963         https://bugs.webkit.org/show_bug.cgi?id=192272
964         <rdar://problem/46664625>
965
966         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
967         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
968         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
969
970 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
971
972         Formalize WebKitAdditions mechanism of LoadOptimizer
973         https://bugs.webkit.org/show_bug.cgi?id=193886
974         <rdar://problem/47696809>
975
976         Reviewed by Brent Fulgham.
977
978         * MiniBrowser/MiniBrowser.entitlements:
979         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
980
981 2019-01-31  Zalan Bujtas  <zalan@apple.com>
982
983         [LFC] Margin before/after/start/end initial value is 0 and not auto.
984         https://bugs.webkit.org/show_bug.cgi?id=194090
985
986         Reviewed by Antti Koivisto.
987
988         * LayoutReloaded/misc/LFC-passing-tests.txt:
989
990 2019-01-31  Zalan Bujtas  <zalan@apple.com>
991
992         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
993         https://bugs.webkit.org/show_bug.cgi?id=194074
994
995         Reviewed by Antti Koivisto.
996
997         * LayoutReloaded/misc/LFC-passing-tests.txt:
998
999 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1000
1001         [LFC][BFC] Add support for block level replaced box.
1002         https://bugs.webkit.org/show_bug.cgi?id=194071
1003
1004         Reviewed by Antti Koivisto.
1005
1006         * LayoutReloaded/misc/LFC-passing-tests.txt:
1007
1008 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1009
1010         Fix WebKitTestRunner's testPath with Windows full paths
1011         https://bugs.webkit.org/show_bug.cgi?id=194012
1012
1013         Reviewed by Alex Christensen.
1014
1015         updateTestOptionsFromTestHeader failed to open test files because
1016         testPath returned wrong file paths. It returned a path "/C:/..."
1017         if a URL "file:///C:/..." was given.
1018
1019         * WebKitTestRunner/TestController.cpp:
1020         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1021
1022 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1023
1024         [WPE] Bump font related dependencies to match the GTK+ port
1025         https://bugs.webkit.org/show_bug.cgi?id=194017
1026
1027         Reviewed by Žan Doberšek.
1028
1029         * wpe/jhbuild.modules:
1030         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1031         * wpe/patches/icudata-stdlibs.patch: Added.
1032
1033 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1034
1035         Enable swipe tests on iOS
1036         https://bugs.webkit.org/show_bug.cgi?id=194076
1037
1038         Reviewed by Geoffrey Garen.
1039
1040         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1041         it causes a debug assertion failure in runUIScript.
1042
1043         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1044         (WTR::UIScriptController::beginBackSwipe):
1045         (WTR::UIScriptController::completeBackSwipe):
1046
1047 2019-01-30  Keith Rollin  <krollin@apple.com>
1048
1049         Use correct printf format specifier
1050         https://bugs.webkit.org/show_bug.cgi?id=194062
1051         <rdar://problem/47686167>
1052
1053         Reviewed by Alexey Proskuryakov.
1054
1055         LayoutTestSpellChecker.mm is trying to format a variable of type
1056         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1057         actually an unsigned long long. Fix this by formatting with %llu.
1058
1059         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1060         (-[LayoutTestTextCheckingResult description]):
1061
1062 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1063
1064         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1065         https://bugs.webkit.org/show_bug.cgi?id=193979
1066
1067         Reviewed by Wenson Hsieh.
1068
1069         Fix the test for iOS. Make the test work with iOS UA string.
1070
1071         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1072
1073 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1074
1075         Replace High Sierra LLINT CLoop bot due to hardware failure
1076         https://bugs.webkit.org/show_bug.cgi?id=194066
1077
1078         Reviewed by Aakash Jain.
1079
1080         * BuildSlaveSupport/build.webkit.org-config/config.json:
1081
1082 2019-01-30  Keith Rollin  <krollin@apple.com>
1083
1084         [NSDragItem init] is unavailable
1085         https://bugs.webkit.org/show_bug.cgi?id=194059
1086         <rdar://problem/47685715>
1087
1088         Reviewed by Wenson Hsieh.
1089
1090         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1091         DumpRenderTree and TestWebKitAPI, which both try to create an
1092         NSDragItem in a manner that invokes this method. Address this by using
1093         -initWithPasteboardWriter instead.
1094
1095         Note that the parameter passed to initWithPasteboardWriter is likely
1096         incorrect. In both cases, the object passed does not conform to
1097         NSPasteboardWriting. However, with this fix, we're no worse off than
1098         before, and can now perform builds with newer compilers and SDKs until
1099         a real fix can be crafted. That work is tracked in
1100         https://bugs.webkit.org/show_bug.cgi?id=194060
1101
1102         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1103         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1104         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1105         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1106
1107 2019-01-30  Daniel Bates  <dabates@apple.com>
1108
1109         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1110         https://bugs.webkit.org/show_bug.cgi?id=192824
1111         <rdar://problem/47100332>
1112
1113         Reviewed by Wenson Hsieh.
1114
1115         Fix a bug where the wrong usage code was used for F13 thru F24.
1116
1117         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1118         (keyCodeForDOMFunctionKey):
1119
1120 2019-01-30  Chris Dumez  <cdumez@apple.com>
1121
1122         Regression(PSON) Load hang can occur on history navigation
1123         https://bugs.webkit.org/show_bug.cgi?id=194030
1124         <rdar://problem/47656939>
1125
1126         Reviewed by Antti Koivisto.
1127
1128         Add API test coverage.
1129
1130         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1131
1132 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1133
1134         [LFC] Expand tests coverage.
1135
1136         Unreviewed test gardening.
1137
1138         * LayoutReloaded/misc/LFC-passing-tests.txt:
1139
1140 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1141
1142         [Flatpak] Add openjpeg support
1143         https://bugs.webkit.org/show_bug.cgi?id=194019
1144
1145         Reviewed by Michael Catanzaro.
1146
1147         * flatpak/org.webkit.CommonModules.yaml:
1148
1149 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1150
1151         Unreviewed, rolling out r240708.
1152         https://bugs.webkit.org/show_bug.cgi?id=194022
1153
1154         It broke WPE build (Requested by KaL on #webkit).
1155
1156         Reverted changeset:
1157
1158         "[WPE] Bump font related dependencies to match the GTK+ port"
1159         https://bugs.webkit.org/show_bug.cgi?id=194017
1160         https://trac.webkit.org/changeset/240708
1161
1162 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1163
1164         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1165         https://bugs.webkit.org/show_bug.cgi?id=194001
1166
1167         Reviewed by Antti Koivisto.
1168
1169         * LayoutReloaded/misc/LFC-passing-tests.txt:
1170
1171 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1172
1173         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1174         https://bugs.webkit.org/show_bug.cgi?id=194020
1175
1176         Reviewed by Antti Koivisto.
1177
1178         * LayoutReloaded/misc/LFC-passing-tests.txt:
1179
1180 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1181
1182         AX: Support color well on iOS
1183         https://bugs.webkit.org/show_bug.cgi?id=194010
1184
1185         Reviewed by Joanmarie Diggs.
1186
1187         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1188         (WTR::AccessibilityUIElement::stringAttributeValue):
1189
1190 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1191
1192         [WPE] Bump font related dependencies to match the GTK+ port
1193         https://bugs.webkit.org/show_bug.cgi?id=194017
1194
1195         Reviewed by Žan Doberšek.
1196
1197         * wpe/jhbuild.modules:
1198         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1199         * wpe/patches/icudata-stdlibs.patch: Added.
1200
1201 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1202
1203         [Mac] Update window scale API usage
1204         https://bugs.webkit.org/show_bug.cgi?id=193991
1205         rdar://problem/47614795
1206
1207         Reviewed by Tim Horton.
1208
1209         * DumpRenderTree/mac/DumpRenderTree.mm:
1210         (changeWindowScaleIfNeeded):
1211         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1212         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1213         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1214
1215 2019-01-29  Chris Dumez  <cdumez@apple.com>
1216
1217         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1218         https://bugs.webkit.org/show_bug.cgi?id=193977
1219         <rdar://problem/47643716>
1220
1221         Reviewed by Geoff Garen.
1222
1223         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1224         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1225         to the previous provisional committing *before* we make the last load. 
1226
1227         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1228
1229 2019-01-29  Youenn Fablet  <youenn@apple.com>
1230
1231         Adopt new SPI to evaluate server certificate trust
1232         https://bugs.webkit.org/show_bug.cgi?id=193355
1233
1234         Reviewed by Alex Christensen.
1235
1236         Add infrastructure to handle HTTPS server trust evaluation testing.
1237
1238         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1239         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1240         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1241         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1242         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1243         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1244         * WebKitTestRunner/TestController.cpp:
1245         (WTR::TestController::resetPreferencesToConsistentValues):
1246         (WTR::TestController::didReceiveAuthenticationChallenge):
1247         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1248         * WebKitTestRunner/TestController.h:
1249         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1250         * WebKitTestRunner/TestInvocation.cpp:
1251         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1252         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1253         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1254
1255 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1256
1257         [ews-build] Add build step to print bot Configuration
1258         https://bugs.webkit.org/show_bug.cgi?id=193887
1259
1260         Reviewed by Lucas Forschler.
1261
1262         * BuildSlaveSupport/ews-build/steps.py:
1263         (PrintConfiguration): Build step to print configuration.
1264         * BuildSlaveSupport/ews-build/factories.py:
1265
1266 2019-01-29  Chris Dumez  <cdumez@apple.com>
1267
1268         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1269         https://bugs.webkit.org/show_bug.cgi?id=193967
1270         <rdar://problem/47635348>
1271
1272         Reviewed by Alex Christensen.
1273
1274         Add API test coverage.
1275
1276         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1277         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1278
1279 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1280
1281         [ews-app] Handle incoming results data
1282         https://bugs.webkit.org/show_bug.cgi?id=193973
1283
1284         Reviewed by Lucas Forschler.
1285
1286         * BuildSlaveSupport/ews-app/ews/views/results.py:
1287
1288 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1289
1290         [ews-app] Make the results url generic
1291         https://bugs.webkit.org/show_bug.cgi?id=193928
1292
1293         Reviewed by Lucas Forschler.
1294
1295         * BuildSlaveSupport/ews-app/ews/urls.py:
1296
1297 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1298
1299         [ews-build] Configure buildbot to send events to ews-app
1300         https://bugs.webkit.org/show_bug.cgi?id=193968
1301
1302         Reviewed by Lucas Forschler.
1303
1304         * BuildSlaveSupport/ews-build/events.py: Added.
1305         * BuildSlaveSupport/ews-build/master.cfg:
1306
1307 2019-01-29  Keith Rollin  <krollin@apple.com>
1308
1309         Add .xcfilelists to Run Script build phases
1310         https://bugs.webkit.org/show_bug.cgi?id=193792
1311         <rdar://problem/47201785>
1312
1313         Reviewed by Alex Christensen.
1314
1315         As part of supporting XCBuild, update the necessary Run Script build
1316         phases in their Xcode projects to refer to their associated
1317         .xcfilelist files.
1318
1319         Note that the addition of these files bumps the Xcode project version
1320         number to something that's Xcode 10 compatible. This change means that
1321         older versions of the Xcode IDE can't read these projects. Nor can it
1322         fully load workspaces that refer to these projects (the updated
1323         projects are shown as non-expandable placeholders). `xcodebuild` can
1324         still build these projects; it's just that the IDE can't open them.
1325
1326         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1327         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1328
1329 2019-01-29  John Wilander  <wilander@apple.com>
1330
1331         Add data abstraction and validation for Ad Click Attribution
1332         https://bugs.webkit.org/show_bug.cgi?id=193916
1333         <rdar://problem/47603481>
1334
1335         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1336
1337         Ad click attribution has two steps. First, the storage of an ad
1338         campaign ID for a click that takes the user to a destination
1339         site. Second, a conversion on the destination site that can be
1340         attributed to the ad click.
1341
1342         This patch adds a class that represents a request for ad click
1343         attribution. Validation makes sure that the bits of entropy
1344         reported through this mechanism is limited.
1345
1346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1347         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1348         (TestWebKitAPI::TEST):
1349
1350 2019-01-29  Chris Dumez  <cdumez@apple.com>
1351
1352         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1353         https://bugs.webkit.org/show_bug.cgi?id=193932
1354         <rdar://problem/47598947>
1355
1356         Reviewed by Brady Eidson.
1357
1358         Add API test coverage.
1359
1360         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1361
1362 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1363
1364         Adding new passing LFC tests.
1365
1366         Unreviewed test gardening.
1367
1368         * LayoutReloaded/misc/LFC-passing-tests.txt:
1369
1370 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1371
1372         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1373         https://bugs.webkit.org/show_bug.cgi?id=193964
1374
1375         Reviewed by Antti Koivisto.
1376
1377         * LayoutReloaded/misc/LFC-passing-tests.txt:
1378
1379 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1380
1381         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1382         https://bugs.webkit.org/show_bug.cgi?id=193954
1383
1384         Reviewed by Antti Koivisto.
1385
1386         * LayoutReloaded/misc/LFC-passing-tests.txt:
1387
1388 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1389
1390         WebDriver: add support for running subtests
1391         https://bugs.webkit.org/show_bug.cgi?id=193904
1392
1393         Reviewed by Michael Catanzaro.
1394
1395         pytest already supports it by passing test.py::subtest, so we can do the same.
1396
1397         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1398         (get_item_name): Made this global.
1399         (CollectRecorder.__init__): Receive the parameter to ignore.
1400         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1401         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1402         (collect): Add parameter to ignore.
1403         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1404         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1405         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1406         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1407         (WebDriverTestRunnerSelenium.run): Ditto.
1408         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1409         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1410         (WebDriverTestRunnerW3C.run): Ditto.
1411
1412 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1413
1414         User agent string override for navigator.userAgent should be site specific quirks
1415         https://bugs.webkit.org/show_bug.cgi?id=193950
1416
1417         Reviewed by Brent Fulgham.
1418
1419         Updated per the _WKWebsitePolicies rename.
1420
1421         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1422         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1423
1424 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1425
1426         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1427         https://bugs.webkit.org/show_bug.cgi?id=193941
1428
1429         Reviewed by Alex Christensen.
1430
1431         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1432         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1433         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1434         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1435         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1436         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1437         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1438         * TestWebKitAPI/Tests/WTF/Time.cpp:
1439         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1440         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1441         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1442         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1443
1444 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1445
1446         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1447
1448         * Scripts/webkitpy/common/config/contributors.json:
1449
1450 2019-01-28  Andy Estes  <aestes@apple.com>
1451
1452         [watchOS] Enable Parental Controls content filtering
1453         https://bugs.webkit.org/show_bug.cgi?id=193939
1454         <rdar://problem/46641912>
1455
1456         Reviewed by Ryosuke Niwa.
1457
1458         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1459
1460 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1461
1462         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1463         <https://webkit.org/b/193884>
1464
1465         Reviewed by Jiewen Tan.
1466
1467         * Scripts/webkitpy/style/checkers/cpp.py:
1468         (check_language): Add LocalAuthentication to
1469         `frameworks_with_soft_links`.
1470
1471 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1472
1473         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1474         https://bugs.webkit.org/show_bug.cgi?id=193891
1475
1476         Reviewed by Ross Kirsling.
1477
1478         There were three problems in window sizes of WebView and the host window.
1479         1. The sizes of pixel image output were incorrect.
1480         2. The host window is going to appear after window.resize was invoked.
1481         3. window.resize resized only the host window, not WebView.
1482
1483         This change solves them with a following approach.
1484         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1485         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1486            as well as DumpRenderTree in order to match the client area and the window area.
1487         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1488         d. PlatformWebView::setWindowFrame changes both window sizes.
1489         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1490
1491         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1492         (WTR::PlatformWebView::PlatformWebView): Create the host window
1493         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1494         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1495         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1496
1497 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1498
1499         [ews-app] Add method to save Step data to database
1500         https://bugs.webkit.org/show_bug.cgi?id=193890
1501
1502         Reviewed by Lucas Forschler.
1503
1504         * BuildSlaveSupport/ews-app/ews/models/step.py:
1505         (Step.save_step): Method to save step data.
1506         (Step.update_step): Method to update step data.
1507         (Step.get_existing_step): Method to fetch existing step from database.
1508         (Step.is_valid_result): Method to validate valid step result.
1509
1510 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1511
1512         [ews-app] Add method to save Build data to database
1513         https://bugs.webkit.org/show_bug.cgi?id=193735
1514
1515         Reviewed by Lucas Forschler.
1516
1517         * BuildSlaveSupport/ews-app/ews/models/build.py:
1518         (Build.save_build): Method to save build information to database.
1519         (Build.get_existing_build): Method to fetch existing build from database.
1520         (Build.is_valid_result): Method to validate build result.
1521         * BuildSlaveSupport/ews-app/ews/common/util.py:
1522         (is_valid_int_id): Method to validate valid id.
1523
1524 2019-01-28  Chris Dumez  <cdumez@apple.com>
1525
1526         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1527         https://bugs.webkit.org/show_bug.cgi?id=193915
1528         <rdar://problem/47560907>
1529
1530         Reviewed by Alex Christensen.
1531
1532         Add API test coverage.
1533
1534         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1535
1536 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1537
1538         [ews-app] Rename id variables
1539         https://bugs.webkit.org/show_bug.cgi?id=193883
1540
1541         Reviewed by Lucas Forschler.
1542
1543         * BuildSlaveSupport/ews-app/ews/models/build.py:
1544         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1545         * BuildSlaveSupport/ews-app/ews/models/step.py:
1546         * BuildSlaveSupport/ews-app/ews/urls.py:
1547         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1548         * BuildSlaveSupport/ews-app/ews/views/results.py:
1549         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1550
1551 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1552
1553         [ews-app] Allow certain fields to be empty
1554         https://bugs.webkit.org/show_bug.cgi?id=193892
1555
1556         Reviewed by Lucas Forschler.
1557
1558         * BuildSlaveSupport/ews-app/ews/models/build.py:
1559         * BuildSlaveSupport/ews-app/ews/models/step.py:
1560
1561 2019-01-28  Rob Buis  <rbuis@igalia.com>
1562
1563         Update MIME type parser
1564         https://bugs.webkit.org/show_bug.cgi?id=180526
1565
1566         Reviewed by Frédéric Wang.
1567
1568         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1569         (TestWebKitAPI::TEST):
1570
1571 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1572
1573         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1574         https://bugs.webkit.org/show_bug.cgi?id=193896
1575
1576         Reviewed by Antti Koivisto.
1577
1578         * LayoutReloaded/misc/LFC-passing-tests.txt:
1579
1580 2018-12-15  Darin Adler  <darin@apple.com>
1581
1582         Replace many uses of String::format with more type-safe alternatives
1583         https://bugs.webkit.org/show_bug.cgi?id=192742
1584
1585         Reviewed by Mark Lam.
1586
1587         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1588         (WTR::cacheTestRunnerCallback): Use makeString.
1589         * WebKitTestRunner/TestController.cpp:
1590         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1591         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1592
1593 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1594
1595         Use a load optimizer for some sites
1596         https://bugs.webkit.org/show_bug.cgi?id=193881
1597         <rdar://problem/46325455>
1598
1599         Reviewed by Brent Fulgham.
1600
1601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1602         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1603
1604 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1605
1606         AX: Introduce a static accessibility tree
1607         https://bugs.webkit.org/show_bug.cgi?id=193348
1608         <rdar://problem/47203295>
1609
1610         Reviewed by Ryosuke Niwa.
1611
1612         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1613
1614 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1615
1616         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1617         https://bugs.webkit.org/show_bug.cgi?id=193867
1618
1619         Reviewed by Antti Koivisto.
1620
1621         * LayoutReloaded/misc/LFC-passing-tests.txt:
1622
1623 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1624
1625         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1626         https://bugs.webkit.org/show_bug.cgi?id=193865
1627
1628         Reviewed by Antti Koivisto.
1629
1630         * LayoutReloaded/misc/LFC-passing-tests.txt:
1631
1632 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1633
1634         Need a mechanism to override navigator.userAgent
1635         https://bugs.webkit.org/show_bug.cgi?id=193762
1636         <rdar://problem/47504939>
1637
1638         Reviewed by Brent Fulgham.
1639
1640         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1641
1642         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1643         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1644         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1645
1646 2019-01-25  Dean Jackson  <dino@apple.com>
1647
1648         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1649         https://bugs.webkit.org/show_bug.cgi?id=193831
1650         <rdar://problem/47399263>
1651
1652         Reviewed by Chris Dumez.
1653
1654         Two new tests that exercise cross-origin and same-origin System
1655         Previews.
1656
1657         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1658
1659 2019-01-25  Keith Rollin  <krollin@apple.com>
1660
1661         Update Xcode projects with "Check .xcfilelists" build phase
1662         https://bugs.webkit.org/show_bug.cgi?id=193790
1663         <rdar://problem/47201374>
1664
1665         Reviewed by Alex Christensen.
1666
1667         Support for XCBuild includes specifying inputs and outputs to various
1668         Run Script build phases. These inputs and outputs are specified as
1669         .xcfilelist files. Once created, these .xcfilelist files need to be
1670         kept up-to-date. In order to check that they are up-to-date or not,
1671         add an Xcode build step that invokes an external script that performs
1672         the checking. If the .xcfilelists are found to be out-of-date, update
1673         them, halt the build, and instruct the developer to restart the build
1674         with up-to-date files.
1675
1676         At this time, the checking and regenerating is performed only if the
1677         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1678         who want to use this facility can set this variable and test out the
1679         checking/regenerating. Once it seems like there are no egregious
1680         issues that upset a developer's workflow, we'll unconditionally enable
1681         this facility.
1682
1683         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1684         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1685         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1686         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1687
1688 2019-01-25  Keith Rollin  <krollin@apple.com>
1689
1690         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1691         https://bugs.webkit.org/show_bug.cgi?id=193781
1692         <rdar://problem/47201153>
1693
1694         Reviewed by Alex Christensen.
1695
1696         Part of generating the .xcfilelists used as part of adopting XCBuild
1697         includes running `make DerivedSources.make` from a standalone script.
1698         It’s important for this invocation to have the same environment as
1699         when the actual build invokes `make DerivedSources.make`. If the
1700         environments are different, then the two invocations will provide
1701         different results. In order to get the same environment in the
1702         standalone script, have the script launch xcodebuild targeting the
1703         "Apply Configuration to XCFileLists" build target, which will then
1704         re-invoke our standalone script. The script is now running again, this
1705         time in an environment with all workspace, project, target, xcconfig
1706         and other environment variables established.
1707
1708         The "Apply Configuration to XCFileLists" build target accomplishes
1709         this task via a small embedded shell script that consists only of:
1710
1711             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1712
1713         The process that invokes "Apply Configuration to XCFileLists" first
1714         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1715         evaluated and exports it into the shell environment. When xcodebuild
1716         is invoked, it inherits the value of this variable and can `eval` the
1717         contents of that variable. Our external standalone script can then set
1718         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1719         of command-line parameters needed to restart itself in the appropriate
1720         state.
1721
1722         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1723         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1724
1725 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1726
1727         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1728         https://bugs.webkit.org/show_bug.cgi?id=193802
1729         <rdar://problem/46010580>
1730
1731         Reviewed by Andy Estes.
1732
1733         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1734         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1735         (TEST):
1736
1737 2019-01-25  Daniel Bates  <dabates@apple.com>
1738
1739         [iOS] uiController.keyDown() does not translate Control modified key
1740         https://bugs.webkit.org/show_bug.cgi?id=192898
1741
1742         Reviewed by Wenson Hsieh.
1743
1744         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1745         key translation, as applicable. Among other cases, key translation occurs when performing
1746         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1747         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1748         human pressing down and releasing key(s) using a hardware keyboard.
1749
1750         * WebKitTestRunner/ios/HIDEventGenerator.h:
1751         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1752         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1753
1754         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1755         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1756         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1757         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1758         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1759         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1760         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1761         (-[HIDEventGenerator longPress:completionBlock:]):
1762         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1763         Update code for above renaming.
1764
1765         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1766         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1767
1768         (-[HIDEventGenerator keyDown:]): Added.
1769         (-[HIDEventGenerator keyUp:]): Added.
1770         (-[HIDEventGenerator keyPress:completionBlock:]):
1771         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1772         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1773         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1774         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1775         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1776         (WTR::parseModifier): Deleted.
1777
1778 2019-01-25  Keith Rollin  <krollin@apple.com>
1779
1780         Complete the implementation of generate-xcfilelists
1781         https://bugs.webkit.org/show_bug.cgi?id=193782
1782
1783         Reviewed by Alex Christensen.
1784
1785         A preliminary version of generate-xcfilelists was added in r238008.
1786         This patch updates that script in order to:
1787
1788         - Support checking of .xcfilelists
1789         - Perform better execution of `make DerivedSources.make` by
1790           relaunching generate-xcfilelists under xcodebuild
1791         - Support incremental generation and checking of .xcfilelists
1792         - Support supplementary .xcfilelists files from WebKitAdditions
1793         - Support being wrapped by parallel version of generate-xcfilelists in
1794           Internal that adds support for (re)generating WebKit projects in
1795           that repo.
1796         - Support builds that have been performed in WebKitBuild as well as
1797           ~/Library/Developer/code/DerivedData
1798         - Increase robustness and debugging facilities.
1799
1800         * Scripts/generate-xcfilelists:
1801
1802 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1803
1804         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1805         https://bugs.webkit.org/show_bug.cgi?id=193297
1806         <rdar://problem/47158841>
1807
1808         Unreviewed test case fix.
1809
1810         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1811         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1812
1813         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1814         (TEST):
1815
1816 2019-01-25  Keith Rollin  <krollin@apple.com>
1817
1818         Update existing .xcfilelists
1819         https://bugs.webkit.org/show_bug.cgi?id=193791
1820         <rdar://problem/47201706>
1821
1822         Reviewed by Alex Christensen.
1823
1824         Many .xcfilelist files were added in r238824 in order to support
1825         XCBuild. Update these with recent changes to the set of build files
1826         and with the current generate-xcfilelist script.
1827
1828         * DumpRenderTree/DerivedSources-input.xcfilelist:
1829         * DumpRenderTree/DerivedSources-output.xcfilelist:
1830         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1831         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1832
1833 2019-01-25  Keith Rollin  <krollin@apple.com>
1834
1835         Fix missing dependencies in extract-dependencies-from-makefile
1836         https://bugs.webkit.org/show_bug.cgi?id=193783
1837         <rdar://problem/47201571>
1838
1839         Reviewed by Alex Christensen.
1840
1841         The extract-dependencies-from-makefile script generates .xcfilelists
1842         for XCBuild by invoking a makefile in --debug mode, parsing the
1843         dependency information in the output, and extracting information
1844         regarding targets and dependents. However, the way `make` emits this
1845         dependency information is not rigorous, and so we need to determine
1846         what lines to look for and parse by trial and error. This approach
1847         didn't coriginally atch all the information we needed to collect, so
1848         update the script to look for the additional lines we now know to look
1849         for.
1850
1851         * Scripts/extract-dependencies-from-makefile:
1852         (Parser):
1853         (Parser.addTarget):
1854         (Parser.addPrereq):
1855         (Parser.doParse):
1856
1857 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1858
1859         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1860         https://bugs.webkit.org/show_bug.cgi?id=193297
1861         <rdar://problem/47158841>
1862
1863         Reviewed by Alex Christensen.
1864
1865         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1866             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1867         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1868         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1869         activating the message used to trigger the callback when it is set.
1870
1871 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1872
1873         WKWebView.goBack should reload if there is a safe browsing warning
1874         https://bugs.webkit.org/show_bug.cgi?id=193805
1875         <rdar://problem/46908216>
1876
1877         Reviewed by Geoff Garen.
1878
1879         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1880         (+[Simple3LookupContext sharedLookupContext]):
1881         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1882         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1883         (TEST):
1884
1885 2019-01-25  Chris Dumez  <cdumez@apple.com>
1886
1887         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1888         https://bugs.webkit.org/show_bug.cgi?id=193788
1889         <rdar://problem/47531231>
1890
1891         Reviewed by Alex Christensen.
1892
1893         Add API test coverage.
1894
1895         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1896         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1897
1898 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1899
1900         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1901         https://bugs.webkit.org/show_bug.cgi?id=193771
1902
1903         Unreviewed infrastructure fix.
1904
1905         * Scripts/webkitpy/port/darwin.py:
1906         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1907
1908 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1909
1910         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1911
1912 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1913
1914         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1915
1916         * Scripts/webkitpy/common/config/contributors.json:
1917
1918 2019-01-25  Chris Dumez  <cdumez@apple.com>
1919
1920         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1921         https://bugs.webkit.org/show_bug.cgi?id=193779
1922         <rdar://problem/46170903>
1923
1924         Reviewed by Antti Koivisto.
1925
1926         Add API test that quickly navigates forward to a previous process without waiting for it to
1927         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1928         the process' previous page when reconnecting the it for the forward navigation.
1929
1930         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1931
1932 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1933
1934         Need a way for JavaScript (or bundle) code to participate in undo
1935         https://bugs.webkit.org/show_bug.cgi?id=190009
1936         <rdar://problem/44807048>
1937
1938         Reviewed by Ryosuke Niwa.
1939
1940         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1941         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1942
1943         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1944         (WTR::UIScriptController::lastUndoLabel const):
1945         (WTR::UIScriptController::firstRedoLabel const):
1946         (WTR::UIScriptController::platformUndoManager const):
1947         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1948         (WTR::UIScriptController::lastUndoLabel const):
1949         (WTR::UIScriptController::firstRedoLabel const):
1950         (WTR::UIScriptController::platformUndoManager const):
1951         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1952         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1953         (WTR::UIScriptController::lastUndoLabel const):
1954         (WTR::UIScriptController::firstRedoLabel const):
1955         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1956         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1957         (WTR::UIScriptController::lastUndoLabel const):
1958         (WTR::UIScriptController::firstRedoLabel const):
1959         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1960         (WTR::UIScriptController::platformUndoManager const):
1961         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1962         (WTR::UIScriptController::platformUndoManager const):
1963
1964 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1965
1966         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1967         https://bugs.webkit.org/show_bug.cgi?id=193824
1968
1969         Reviewed by Antti Koivisto.
1970
1971         * LayoutReloaded/misc/LFC-passing-tests.txt:
1972
1973 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1974
1975         Update macOS JSC bot configurations
1976         https://bugs.webkit.org/show_bug.cgi?id=193739
1977
1978         Reviewed by Alexey Proskuryakov.
1979
1980         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1982         (BubbleQueueServer): Move JSC EWS to Mojave section.
1983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1984         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1985         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1986
1987 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1988
1989         [Win][WebKitTestRunner] Implement EventSenderProxy
1990         https://bugs.webkit.org/show_bug.cgi?id=193755
1991
1992         Reviewed by Don Olmstead.
1993
1994         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1995         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1996         (WTR::EventSenderProxy::dispatchMessage):
1997         (WTR::EventSenderProxy::EventSenderProxy):
1998         (WTR::EventSenderProxy::mouseDown):
1999         (WTR::EventSenderProxy::mouseUp):
2000         (WTR::EventSenderProxy::mouseMoveTo):
2001         (WTR::EventSenderProxy::mouseScrollBy):
2002         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2003
2004 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2005
2006         Unreviewed fix for API test failure after r240437.
2007
2008         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2009
2010         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2011
2012 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2013
2014         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2015         https://bugs.webkit.org/show_bug.cgi?id=193787
2016         <rdar://problem/47497634>
2017
2018         Reviewed by Alexey Proskuryakov.
2019
2020         * Scripts/webkitdirs.pm:
2021         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2022
2023 2019-01-24  Truitt Savell  <tsavell@apple.com>
2024
2025         Unreviewed, rolling out r240446.
2026
2027         Casued 5 API failures
2028
2029         Reverted changeset:
2030
2031         "Activate the WebResourceLoadStatisticsStore in the
2032         NetworkProcess and deactivate it in the UIProcess."
2033         https://bugs.webkit.org/show_bug.cgi?id=193297
2034         https://trac.webkit.org/changeset/240446
2035
2036 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2037
2038         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2039         https://bugs.webkit.org/show_bug.cgi?id=193741
2040         <rdar://problem/47135030>
2041
2042         Reviewed by Antti Koivisto and Simon Fraser.
2043
2044         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2045         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2046         (TestWebKitAPI::TEST):
2047
2048 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2049
2050         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2051         https://bugs.webkit.org/show_bug.cgi?id=193297
2052         <rdar://problem/47158841>
2053
2054         Reviewed by Alex Christensen.
2055
2056         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2057         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2058         activating the message used to trigger the callback when it is set.
2059
2060 2019-01-24  John Wilander  <wilander@apple.com>
2061
2062         Add Ad Click Attribution as an internal/experimental feature
2063         https://bugs.webkit.org/show_bug.cgi?id=193685
2064         <rdar://problem/47450399>
2065
2066         Reviewed by Brent Fulgham.
2067
2068         Added test option adClickAttributionEnabled.
2069
2070         * DumpRenderTree/TestOptions.cpp:
2071         (TestOptions::TestOptions):
2072         * DumpRenderTree/TestOptions.h:
2073         * DumpRenderTree/mac/DumpRenderTree.mm:
2074         (setWebPreferencesForTestOptions):
2075
2076 2019-01-24  Antti Koivisto  <antti@apple.com>
2077
2078         [PSON] Flash on back navigation on Mac
2079         https://bugs.webkit.org/show_bug.cgi?id=193716
2080         <rdar://problem/47148458>
2081
2082         Reviewed by Chris Dumez.
2083
2084         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2085
2086         Closing of the previous page is delayed so waiting for didFinishNavigation is
2087         not sufficient to guarantee we have received all the messages. Wait for them.
2088
2089 2019-01-24  Chris Dumez  <cdumez@apple.com>
2090
2091         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2092         https://bugs.webkit.org/show_bug.cgi?id=193761
2093         <rdar://problem/47456405>
2094
2095         Reviewed by Alex Christensen.
2096
2097         Add API test coverage.
2098
2099         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2100
2101 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2102
2103         webkitpy: Missing PID in crashlog name should not be fatal
2104         https://bugs.webkit.org/show_bug.cgi?id=193771
2105
2106         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2107         of raising an exception.
2108
2109         Reviewed by Lucas Forschler.
2110
2111         * Scripts/webkitpy/port/darwin.py:
2112         (DarwinPort._merge_crash_logs):
2113
2114 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2115
2116         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2117         https://bugs.webkit.org/show_bug.cgi?id=193746
2118
2119         Reviewed by Youenn Fablet.
2120
2121         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2122         so we'd best just not call it.
2123
2124         * Scripts/webkitpy/w3c/test_exporter.py:
2125         (WebPlatformTestExporter.create_branch_with_patch):
2126
2127 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2128
2129         Move FileSystem to WTF
2130         https://bugs.webkit.org/show_bug.cgi?id=193602
2131
2132         Reviewed by Yusuke Suzuki.
2133
2134         * DumpRenderTree/win/DumpRenderTree.cpp:
2135         * TestWebKitAPI/CMakeLists.txt:
2136         * TestWebKitAPI/PlatformGTK.cmake:
2137         * TestWebKitAPI/PlatformJSCOnly.cmake:
2138         * TestWebKitAPI/PlatformPlayStation.cmake:
2139         * TestWebKitAPI/PlatformWPE.cmake:
2140         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2141         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2142         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2143         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2144         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2145         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2146         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2147         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2148         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2149         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2150
2151 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2152
2153         [WPE] Remove hard dependency on subprocess32 for the API tests
2154
2155         Rubber-stamped by Carlos Garcia Campos.
2156
2157         * glib/api_test_runner.py:
2158         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2159         its presence only when running WPEQt tests.
2160
2161 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2162
2163         [GLIB] Expose JavaScriptCore options in GLib public API
2164         https://bugs.webkit.org/show_bug.cgi?id=188742
2165
2166         Reviewed by Michael Catanzaro.
2167
2168         Add a test for the new API.
2169
2170         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2171         (testsJSCOptions):
2172         (main):
2173
2174 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2175
2176         [GTK][WPE] Support JPEG 2000 images
2177         https://bugs.webkit.org/show_bug.cgi?id=186272
2178
2179         Reviewed by Žan Doberšek.
2180
2181         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2182
2183         * gtk/jhbuild.modules:
2184         * wpe/jhbuild.modules:
2185
2186 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2187
2188         check-webkit-style should warn when using soft-linking macros in a header
2189         <https://webkit.org/b/193750>
2190
2191         Reviewed by Darin Adler.
2192
2193         * Scripts/webkitpy/style/checkers/cpp.py:
2194         (check_language): Add softlink/header check by refactoring the
2195         softlink/framework check.
2196         (CppChecker): Enable softlink/header check by default.
2197         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2198         (CppStyleTest.test_softlink_framework): Rename from
2199         CppStyleTest.test_softlink() and change test framework name in
2200         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2201         files. Set file_name for macros that only appear in headers.
2202         (CppStyleTest.test_softlink_header): Add tests for using
2203         soft-link macros in headers.
2204
2205 2019-01-23  Chris Dumez  <cdumez@apple.com>
2206
2207         Deprecate API to limit the maximum number of WebProcesses
2208         https://bugs.webkit.org/show_bug.cgi?id=193725
2209         <rdar://problem/47464879>
2210
2211         Reviewed by Geoff Garen.
2212
2213         Update existing API tests to stop using deprecated API.
2214
2215         * MiniBrowser/mac/AppDelegate.m:
2216         (defaultConfiguration):
2217         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2218         (TestWebKitAPI::TEST):
2219         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2220         (TestWebKitAPI::TEST):
2221         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2222         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2223         (TEST):
2224         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2225         (TEST):
2226
2227 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2228
2229         [ews-app] Rename ews model buildermappings to buildermapping
2230         https://bugs.webkit.org/show_bug.cgi?id=193729
2231
2232         Reviewed by Lucas Forschler.
2233
2234         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2235         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2236         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2237
2238 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2239
2240         [ews-app] Rename ews model steps to step
2241         https://bugs.webkit.org/show_bug.cgi?id=193697
2242
2243         Reviewed by Lucas Forschler.
2244
2245         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2246         (Step): Renamed Steps to Step.
2247
2248 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2249
2250         Clean up IndexedDB files between tests
2251         https://bugs.webkit.org/show_bug.cgi?id=192796
2252         <rdar://problem/46824999>
2253
2254         Reviewed by Geoffrey Garen.
2255
2256         * DumpRenderTree/mac/DumpRenderTree.mm:
2257         (runTest):
2258         * WebKitTestRunner/TestController.cpp:
2259         (WTR::TestController::resetStateToConsistentValues):
2260         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2261         (WTR::RemoveAllIndexedDatabasesCallback):
2262         (WTR::TestController::ClearIndexedDatabases):
2263         * WebKitTestRunner/TestController.h:
2264         * WebKitTestRunner/TestInvocation.cpp:
2265         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2266
2267 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2268
2269         [ews-app] Rename ews model Builds to Build
2270         https://bugs.webkit.org/show_bug.cgi?id=193695
2271
2272         Reviewed by Lucas Forschler.
2273
2274         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2275         (Build): Renamed Builds to Build.
2276
2277 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2278
2279         webkitpy: Wait longer when launching WebKitTestRunner
2280         https://bugs.webkit.org/show_bug.cgi?id=193734
2281
2282         Reviewed by Aakash Jain.
2283
2284         * Scripts/webkitpy/port/simulator_process.py:
2285         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2286
2287 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2288
2289         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2290         https://bugs.webkit.org/show_bug.cgi?id=193182
2291         <rdar://problem/47452154>
2292
2293         Reviewed by Tim Horton.
2294
2295         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2296         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2297         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2298
2299         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2300         preventing later tests from recognizing gestures.
2301
2302         * WebKitTestRunner/ios/TestControllerIOS.mm:
2303         (WTR::TestController::platformResetStateToConsistentValues):
2304
2305         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2306
2307 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2308
2309         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2310         https://bugs.webkit.org/show_bug.cgi?id=193722
2311         <rdar://problem/47481475>
2312
2313         Reviewed by Lucas Forschler.
2314
2315         iPhone and iPad ports should both use the iOS config.
2316
2317         * Scripts/webkitpy/port/ios_simulator.py:
2318         (IPhoneSimulatorPort.__init__):
2319         (IPadSimulatorPort.__init__):
2320
2321 2019-01-23  Rob Buis  <rbuis@igalia.com>
2322
2323         Update MIME type parser
2324         https://bugs.webkit.org/show_bug.cgi?id=180526
2325
2326         Reviewed by Frédéric Wang.
2327
2328         Add unit tests for both parse modes of ParsedContentType.
2329
2330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2331         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2332         (TestWebKitAPI::TEST):
2333
2334 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2335
2336         [ews-app] fetch loop should not stop on network issues
2337         https://bugs.webkit.org/show_bug.cgi?id=193666
2338
2339         Reviewed by Lucas Forschler.
2340
2341         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2342         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2343
2344 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2345
2346         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2347         https://bugs.webkit.org/show_bug.cgi?id=189165
2348         <rdar://problem/47433765>
2349
2350         Reviewed by Tim Horton.
2351
2352         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2353         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2354         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2355         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2356         would make its way to the UI process by the time the layer tree commit is finished.
2357
2358         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2359         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2360         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2361         will fail because it asks for -_autofillContext too early.
2362
2363         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2364         is handled in the UI process.
2365
2366         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2367
2368         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2369         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2370         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2371         input session.
2372
2373         (-[AutofillTestView textInputHasAutofillContext]):
2374
2375         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2376
2377         * TestWebKitAPI/cocoa/TestWKWebView.h:
2378         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2379         (nextInputSessionChangeCount):
2380
2381         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2382         This includes changing the focused element from one to another.
2383
2384         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2385         (-[TestWKWebView didStartFormControlInteraction]):
2386         (-[TestWKWebView didEndFormControlInteraction]):
2387         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2388
2389         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2390         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2391         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2392         that doesn't require an input session to one that doesn't.
2393
2394 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2395
2396         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2397         <https://webkit.org/b/193676>
2398
2399         Reviewed by Alexey Proskuryakov.
2400
2401         * Scripts/webkitpy/style/checkers/cpp.py:
2402         (check_member_initialization_list):
2403         - Don't report missing whitespace around colon if the colon at
2404           the start of the line is formatted correctly.
2405         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2406         (WebKitStyleTest.test_member_initialization_list):
2407         - Add a test for a missing permutation of existing tests.
2408         - Add a test this false-positive.
2409         - Add blank lines between subtests to make them easier to read.
2410
2411 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2412
2413         [build.webkit.org] Unit-test failure after r237113
2414         https://bugs.webkit.org/show_bug.cgi?id=193669
2415
2416         Reviewed by Michael Catanzaro.
2417
2418         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2419         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2420         multiple or zero flags.
2421
2422 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2423
2424         Cache bytecode to disk
2425         https://bugs.webkit.org/show_bug.cgi?id=192782
2426         <rdar://problem/46084932>
2427
2428         Reviewed by Keith Miller.
2429
2430         Add test helper to execute bytecode-cache tests: it executes each test
2431         twice, the first with JSC_diskCachePath set to a temporary directory
2432         and second with JSC_forceDiskCache=true (in addition to the cache path)
2433         to guarantee that only the disk cache is being used and no new
2434         UnlinkedCodeBlocks are being created.
2435
2436         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2437         * Scripts/run-jsc-stress-tests:
2438
2439 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2440
2441         [css-logical] Implement flow-relative margin, padding and border shorthands
2442         https://bugs.webkit.org/show_bug.cgi?id=188697
2443
2444         Reviewed by Simon Fraser and Antti Koivisto.
2445
2446         * DumpRenderTree/TestOptions.cpp:
2447         (TestOptions::TestOptions):
2448         * DumpRenderTree/TestOptions.h:
2449         * DumpRenderTree/mac/DumpRenderTree.mm:
2450         (setWebPreferencesForTestOptions):
2451         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2452
2453         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2454         (JSONCSSPropertiesChecker.check_codegen_properties):
2455         Allow CSS property definitions to have a 'runtime-flag' parameter which
2456         disables the property when the specified runtime flag is disabled.
2457
2458 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2459
2460         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2461         https://bugs.webkit.org/show_bug.cgi?id=193643
2462
2463         Reviewed by Michael Catanzaro.
2464
2465         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2466         * wpe/jhbuild.modules: Ditto.
2467
2468 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2469
2470         [LFC][Floats] Take float top position into account when computing containing block height.
2471         https://bugs.webkit.org/show_bug.cgi?id=193655
2472
2473         Reviewed by Antti Koivisto.
2474
2475         * LayoutReloaded/misc/LFC-passing-tests.txt:
2476
2477 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2478
2479         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2480         <https://webkit.org/b/193645>
2481         <rdar://problem/47421574>
2482
2483         Reviewed by Alex Christensen.
2484
2485         - Now checks for local soft-linking of all frameworks that have
2486           their own *SoftLinking.{cpp,h,mm} files.
2487         - Changes softlink/uikit warning to softlink/framework.
2488
2489         * Scripts/webkitpy/style/checkers/cpp.py:
2490         (check_language):
2491         (CppChecker):
2492         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2493         (CppStyleTest):
2494
2495 2019-01-20  Saam Barati  <sbarati@apple.com>
2496
2497         Rollout r240210: It broke tests on iOS
2498         https://bugs.webkit.org/show_bug.cgi?id=193640
2499
2500         Unreviewed.
2501
2502         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2503         * Scripts/run-jsc-stress-tests:
2504
2505 2019-01-20  chris fleizach  <cfleizach@apple.com>
2506
2507         AX: Support returning relative frames for accessibility
2508         https://bugs.webkit.org/show_bug.cgi?id=193414
2509         <rdar://problem/47268501>
2510
2511         Reviewed by Zalan Bujtas.
2512
2513         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2514         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2515         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2516         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2517         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2518         (WTR::attributesOfElement):
2519         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2520
2521 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2522
2523         Unreviewed, add my new email address
2524
2525         * Scripts/webkitpy/common/config/contributors.json:
2526
2527 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2528
2529         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2530         https://bugs.webkit.org/show_bug.cgi?id=193617
2531
2532         Reviewed by Antti Koivisto.
2533
2534         * LayoutReloaded/misc/LFC-passing-tests.txt:
2535
2536 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2537
2538         Unreviewed, rolling out r240209.
2539
2540         Broke GTK/WPE injected bundle
2541
2542         Reverted changeset:
2543
2544         "AX: Support returning relative frames for accessibility"
2545         https://bugs.webkit.org/show_bug.cgi?id=193414
2546         https://trac.webkit.org/changeset/240209
2547
2548 2019-01-12  Dan Bernstein  <mitz@apple.com>
2549
2550         [Cocoa] Avoid importing directly from subumbrella frameworks
2551         https://bugs.webkit.org/show_bug.cgi?id=186016
2552         <rdar://problem/40591038>
2553
2554         Reviewed by Sam Weinig.
2555
2556         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2557           LaunchServices header.
2558         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2559           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2560         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2561           when using SDKs earlier than 10.13.
2562         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2563           and OTHER_CPLUSPLUSFLAGS.
2564         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2565           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2566         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2567           LaunchServices header.
2568
2569 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2570
2571         Cache bytecode to disk
2572         https://bugs.webkit.org/show_bug.cgi?id=192782
2573         <rdar://problem/46084932>
2574
2575         Reviewed by Keith Miller.
2576
2577         Add test helper to execute bytecode-cache tests: it executes each test
2578         twice, the first with JSC_diskCachePath set to a temporary directory
2579         and second with JSC_forceDiskCache=true (in addition to the cache path)
2580         to guarantee that only the disk cache is being used and no new
2581         UnlinkedCodeBlocks are being created.
2582
2583         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2584         * Scripts/run-jsc-stress-tests:
2585
2586 2019-01-20  chris fleizach  <cfleizach@apple.com>
2587
2588         AX: Support returning relative frames for accessibility
2589         https://bugs.webkit.org/show_bug.cgi?id=193414
2590         <rdar://problem/47268501>
2591
2592         Reviewed by Zalan Bujtas.
2593
2594         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2595         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2596         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2597         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2598         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2599         (WTR::attributesOfElement):
2600         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2601
2602 2019-01-20  Antoine Quint  <graouts@apple.com>
2603
2604         Add a POINTER_EVENTS feature flag
2605         https://bugs.webkit.org/show_bug.cgi?id=193577
2606         <rdar://problem/47408511>
2607
2608         Unreviewed. Also enable Pointer Events for iosmac.
2609
2610         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2611
2612 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2613
2614         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2615         https://bugs.webkit.org/show_bug.cgi?id=193613
2616
2617         Reviewed by Antti Koivisto.
2618
2619         * LayoutReloaded/misc/LFC-passing-tests.txt:
2620
2621 2019-01-19  Antoine Quint  <graouts@apple.com>
2622
2623         Add a POINTER_EVENTS feature flag
2624         https://bugs.webkit.org/show_bug.cgi?id=193577
2625
2626         Reviewed by Dean Jackson.
2627
2628         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2629
2630 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2631
2632         Disable the run-jsc-stress-test remote host key check [second round].
2633         https://bugs.webkit.org/show_bug.cgi?id=192988
2634
2635         Reviewed by Dewei Zhu.
2636
2637         * Scripts/run-jsc-stress-tests:
2638
2639 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2640
2641         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2642         https://bugs.webkit.org/show_bug.cgi?id=193597
2643
2644         Reviewed by Lucas Forschler.
2645
2646         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2647
2648 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2649
2650         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2651         https://bugs.webkit.org/show_bug.cgi?id=193595
2652
2653         Reviewed by Lucas Forschler.
2654
2655         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2656         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2657         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2658
2659 2019-01-18  Chris Dumez  <cdumez@apple.com>
2660
2661         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2662         https://bugs.webkit.org/show_bug.cgi?id=193588
2663         <rdar://problem/47131566>
2664
2665         Reviewed by Alex Christensen.
2666
2667         Add layout test coverage.
2668
2669         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2670
2671 2019-01-18  Jer Noble  <jer.noble@apple.com>
2672
2673         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2674         https://bugs.webkit.org/show_bug.cgi?id=189553
2675
2676         Reviewed by Tim Horton.
2677
2678         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2679
2680         * ContentExtensionTester/Configurations/Base.xcconfig:
2681         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2682         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2683         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2684         * ImageDiff/cg/Configurations/Base.xcconfig:
2685         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2686         * MiniBrowser/Configurations/Base.xcconfig:
2687         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2688         * MobileMiniBrowser/Configurations/Base.xcconfig:
2689         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2690         * Scripts/webkitpy/style/checker.py:
2691         (_all_categories):
2692         (FileType):
2693         (CheckerDispatcher._file_type):
2694         (CheckerDispatcher._create_checker):
2695         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2696         (SDKVariantChecker):
2697         (SDKVariantChecker.__init__):
2698         (SDKVariantChecker.check):
2699         * TestWebKitAPI/Configurations/Base.xcconfig:
2700         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2701         * WebEditingTester/Configurations/Base.xcconfig:
2702         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2703         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2704         * WebKitTestRunner/Configurations/Base.xcconfig:
2705         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2706         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2707         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2708
2709 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2710
2711         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2712         <https://webkit.org/b/193568>
2713         <rdar://problem/47381130>
2714
2715         Reviewed by Alex Christensen.
2716
2717         Make sure no one re-introduces UIKit soft-linking by adding a
2718         style rule.
2719
2720         * Scripts/webkitpy/style/checkers/cpp.py:
2721         (check_language): Add softlink/uikit check.
2722         (CppChecker): Enable softlink/uikit check.
2723         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2724         (CppStyleTest): Add test for softlink/uikit.
2725
2726 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2727
2728         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2729         https://bugs.webkit.org/show_bug.cgi?id=193584
2730
2731         Change "-dev" to "-devel".
2732
2733         Reviewed by Michael Catanzaro.
2734
2735         * gtk/install-dependencies:
2736
2737 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2738
2739         webkitpy: Add iPhone and iPad ports
2740         https://bugs.webkit.org/show_bug.cgi?id=193537
2741         <rdar://problem/47353390>
2742
2743         Reviewed by Lucas Forschler.
2744
2745         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2746         ports. Note that this separation is optional, the --ios-simulator command remains.
2747
2748         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2749         (RunTest.test_device_type_test_division): Drive-by fix.
2750         (RunTest.test_device_type_specific_listing): Ditto.
2751         (RunTest.test_ipad_test_division):
2752         (RunTest):
2753         (RunTest.test_ipad_listing):
2754         * Scripts/webkitpy/port/factory.py:
2755         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2756         (PortFactory):
2757         * Scripts/webkitpy/port/ios_simulator.py:
2758         (IPhoneSimulatorPort):
2759         (IPadSimulatorPort):
2760
2761 2019-01-18  Chris Dumez  <cdumez@apple.com>
2762
2763         Regression(PSON) Scroll position is not always restored properly when navigating back
2764         https://bugs.webkit.org/show_bug.cgi?id=193578
2765         <rdar://problem/47386331>
2766
2767         Reviewed by Tim Horton.
2768
2769         Add API test coverage.
2770
2771         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2772
2773 2019-01-18  Youenn Fablet  <youenn@apple.com>
2774
2775         Add a new SPI to request for cache storage quota increase
2776         https://bugs.webkit.org/show_bug.cgi?id=193323
2777
2778         Reviewed by Alex Christensen.
2779
2780         Implement WebsiteDataStore quota delegate to handle quota requests.
2781         By default, do not update quota.
2782         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2783
2784         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2785         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2786         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2787         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2788         * WebKitTestRunner/TestController.cpp:
2789         (WTR::TestController::allowCacheStorageQuotaIncrease):
2790         * WebKitTestRunner/TestController.h:
2791         * WebKitTestRunner/TestInvocation.cpp:
2792         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2793         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2794         (-[CacheStorageQuotaManager init]):
2795         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2796         (WTR::initializeWebViewConfiguration):
2797         (WTR::TestController::cocoaResetStateToConsistentValues):
2798         (WTR::TestController::allowCacheStorageQuotaIncrease):
2799
2800 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2801
2802         [ews-build] Pass owner to the triggered builds
2803         https://bugs.webkit.org/show_bug.cgi?id=193574
2804
2805         Reviewed by Lucas Forschler.
2806
2807         * BuildSlaveSupport/ews-build/factories.py:
2808         (BuildFactory.propertiesToPassToTriggers):
2809
2810 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2811
2812         [ews-app] Send patch author as a build property
2813         https://bugs.webkit.org/show_bug.cgi?id=193560
2814
2815         Reviewed by Lucas Forschler.
2816
2817         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2818         (BugzillaPatchFetcher.fetch):
2819
2820 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2821
2822         webkitpy: Implement device type specific expected results (Follow-up fix)
2823         https://bugs.webkit.org/show_bug.cgi?id=192162
2824         <rdar://problem/46345449>
2825
2826         Unreviewed infrastructure fix.
2827
2828         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2829         (Manager.run): Don't boot a device if no tests are available to run on it.
2830
2831 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2832
2833         webkitpy: Implement device type specific expected results (Follow-up fix)
2834         https://bugs.webkit.org/show_bug.cgi?id=192162
2835         <rdar://problem/46345449>
2836
2837         Unreviewed infrastructure fix.
2838
2839         * Scripts/webkitpy/api_tests/manager.py:
2840         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2841
2842 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2843
2844         webkitpy: Implement device type specific expected results (Part 2)
2845         https://bugs.webkit.org/show_bug.cgi?id=192162
2846         <rdar://problem/46345449>
2847
2848         Rubber-stamped by Aakash Jain.
2849
2850         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2851         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2852         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2853
2854         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2855         (LayoutTestFinder.find_tests): Pass device_type through.
2856         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2857         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2858         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2859         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2860         (Manager._collect_tests): Pass device type to test finder.
2861         (Manager._needs_web_platform_test):
2862         (Manager._prepare_lists): Index _expectations by device type.
2863         (Manager._test_input_for_file):
2864         (Manager._test_is_slow): Ditto.
2865         (Manager._test_should_dump_jsconsolelog_in_stderr):
2866         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2867         (Manager._get_test_inputs):
2868         (Manager._update_worker_count):
2869         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2870         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2871         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2872         the one which runs the test.
2873         (Manager._run_test_subset):
2874         (Manager._run_tests): Index _expectations by current_device_type.
2875         (Manager._print_expectation_line_for_test): Ditto.
2876         (Manager._print_expectations_for_subset): Ditto.
2877         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2878         Unlike run, this function will behave the same regardless of what devices are available.
2879         (Manager._custom_device_for_test): Deleted.
2880         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2881         (ManagerTest.test_uses_custom_device): Deleted.
2882         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2883         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2884         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2885         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2886         all of the expectations.
2887         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2888         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2889         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2890         (TestExpectations.__init__): Allow device_type to be passed through.
2891         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2892         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2893         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2894         (summarize_results):
2895         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2896         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2897         a test ran with, one must check all expectations to find the first non-skip expectation.
2898         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2899         (RunTest.test_device_type_test_division):
2900         (RunTest):
2901         (RunTest.test_device_type_specific_listing):
2902         * Scripts/webkitpy/port/base.py:
2903         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2904         (Port.supported_device_types): The result of this function will change based on what devices are available.
2905         * Scripts/webkitpy/port/device_port.py:
2906         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2907         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2908         can be used.
2909         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2910         any, or the DEFAULT_DEVICE_TYPES of the port.
2911         * Scripts/webkitpy/port/ios.py:
2912         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2913         * Scripts/webkitpy/port/ios_simulator.py:
2914         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2915         * Scripts/webkitpy/port/watch.py:
2916         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2917         * Scripts/webkitpy/port/watch_simulator.py:
2918         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2919         * Scripts/webkitpy/xcode/device_type.py:
2920         (DeviceType):
2921         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2922
2923 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2924
2925         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2926         https://bugs.webkit.org/show_bug.cgi?id=193575
2927
2928         Reviewed by Michael Catanzaro.
2929
2930         Allow the script to run without explicit port argument because
2931         it's specific to the WPE port anyway.
2932
2933         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2934         and simplify the rest of the code accordingly.
2935
2936 2019-01-18  Charlie Turner  <cturner@igalia.com>
2937
2938         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2939         https://bugs.webkit.org/show_bug.cgi?id=192229
2940
2941         Reviewed by Xabier Rodriguez-Calvar.
2942
2943         * MiniBrowser/wpe/main.cpp:
2944         (main): Enable encrypted-media by default.
2945
2946 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2947
2948         [Flatpak] Missing KeyboardInterrupt exception handler
2949         https://bugs.webkit.org/show_bug.cgi?id=193570
2950
2951         Reviewed by Michael Catanzaro.
2952
2953         * flatpak/flatpakutils.py:
2954         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2955
2956 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2957
2958         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2959         https://bugs.webkit.org/show_bug.cgi?id=193564
2960
2961         Reviewed by Antti Koivisto.
2962
2963         * LayoutReloaded/misc/LFC-passing-tests.txt:
2964
2965 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2966
2967         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2968         https://bugs.webkit.org/show_bug.cgi?id=193562
2969
2970         Reviewed by Antti Koivisto.
2971
2972         * LayoutReloaded/misc/LFC-passing-tests.txt:
2973
2974 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2975
2976         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2977         https://bugs.webkit.org/show_bug.cgi?id=193555
2978
2979         Reviewed by Antti Koivisto.
2980
2981         * LayoutReloaded/misc/LFC-passing-tests.txt:
2982
2983 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2984
2985         [WPE] Add Qt extension
2986         https://bugs.webkit.org/show_bug.cgi?id=191464
2987
2988         Reviewed by Carlos Garcia Campos.
2989
2990         MiniBrowser and API tests for the WPE Qt API. To run the
2991         MiniBrowser a new script is introduced. Example invocation:
2992
2993         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2994
2995         Also note-worthy is the introduction of the python2-subprocess32
2996         dependency to run the GLib API tests.
2997
2998         * MiniBrowser/wpe/CMakeLists.txt:
2999         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3000         * MiniBrowser/wpe/qt/main.cpp: Added.
3001         (main):
3002         * MiniBrowser/wpe/qt/main.qml: Added.
3003         * MiniBrowser/wpe/qt/qml.qrc: Added.
3004         * Scripts/run-gtk-tests:
3005         (GtkTestRunner.is_google_test):
3006         (GtkTestRunner):
3007         (GtkTestRunner.is_qt_test):
3008         * Scripts/run-qt-wpe-minibrowser: Added.
3009         * Scripts/run-wpe-tests:
3010         (WPETestRunner):
3011         (WPETestRunner.is_google_test):
3012         (WPETestRunner.is_qt_test):
3013         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3014         (TestLoad::main):
3015         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3016         (TestLoadHtml::main):
3017         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3018         (TestLoadRequest::main):
3019         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3020         (TestRunJavaScript::main):
3021         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3022         (waitForSignal):
3023         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3024         (LoadSpy::LoadSpy):
3025         (LoadSpy::~LoadSpy):
3026         (LoadSpy::onLoadingChanged):
3027         (LoadStartedCatcher::LoadStartedCatcher):
3028         (LoadStartedCatcher::~LoadStartedCatcher):
3029         (LoadStartedCatcher::onLoadingChanged):
3030         (waitForLoadSucceeded):
3031         (waitForLoadFailed):
3032         * TestWebKitAPI/glib/CMakeLists.txt:
3033         * flatpak/flatpakutils.py:
3034         (WebkitFlatpak.load_from_args):
3035         (WebkitFlatpak.__init__):
3036         (WebkitFlatpak.clean_args):
3037         (WebkitFlatpak.run_in_sandbox):
3038         * flatpak/org.webkit.CommonModules.yaml:
3039         * flatpak/org.webkit.WPE.yaml:
3040         * flatpak/org.webkit.WPEModules.yaml:
3041         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3042         * flatpak/org.webkit.WebKit.yaml:
3043         * glib/api_test_runner.py:
3044         (TestRunner._run_test_qt):
3045         (TestRunner.is_qt_test):
3046         (TestRunner._run_test):
3047
3048 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3049
3050         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3051         https://bugs.webkit.org/show_bug.cgi?id=193494
3052         <rdar://problem/46859627>
3053
3054         Reviewed by Simon Fraser and Tim Horton.
3055
3056         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3057         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3058
3059         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3060         (WTR::UIScriptController::contentOffsetX const):
3061         (WTR::UIScriptController::contentOffsetY const):
3062         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3063         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3064         (WTR::UIScriptController::contentOffsetX const):
3065         (WTR::UIScriptController::contentOffsetY const):
3066         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3067
3068         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3069
3070         * WebKitTestRunner/TestController.cpp:
3071         (WTR::updateTestOptionsFromTestHeader):
3072         * WebKitTestRunner/TestOptions.h:
3073         (WTR::TestOptions::hasSameInitializationOptions const):
3074         * WebKitTestRunner/ios/TestControllerIOS.mm:
3075         (WTR::TestController::platformResetStateToConsistentValues):
3076         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3077         (WTR::UIScriptController::contentOffsetX const):
3078         (WTR::UIScriptController::contentOffsetY const):
3079
3080 2019-01-17  Truitt Savell  <tsavell@apple.com>
3081
3082         Unreviewed, rolling out r240124.
3083
3084         This commit broke an internal build.
3085
3086         Reverted changeset:
3087
3088         "SDK_VARIANT build destinations should be separate from non-
3089         SDK_VARIANT builds"
3090         https://bugs.webkit.org/show_bug.cgi?id=189553
3091         https://trac.webkit.org/changeset/240124
3092
3093 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3094
3095         Fix string concatenation API test after r239920
3096         https://bugs.webkit.org/show_bug.cgi?id=193551
3097         <rdar://problem/47359304>
3098
3099         Reviewed by Youenn Fablet.
3100
3101         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3102         (TestWebKitAPI::TEST):
3103         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3104         in WebKit's build configuration like it apparently is on Linux.
3105
3106 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3107
3108         [ews-build] validate-patch should handle the case when bug_id is None
3109         https://bugs.webkit.org/show_bug.cgi?id=193547
3110
3111         Reviewed by Lucas Forschler.
3112
3113         * BuildSlaveSupport/ews-build/steps.py:
3114         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3115         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3116
3117 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3118
3119         [ews-build] Add patch author information in build
3120         https://bugs.webkit.org/show_bug.cgi?id=193465
3121
3122         Reviewed by Lucas Forschler.
3123
3124         * BuildSlaveSupport/ews-build/steps.py:
3125         (ValidatePatch._is_patch_obsolete):
3126
3127 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3128
3129         [ews-build] Pass bug_id to the triggered builds
3130         https://bugs.webkit.org/show_bug.cgi?id=193548
3131
3132         Reviewed by Lucas Forschler.
3133
3134         * BuildSlaveSupport/ews-build/factories.py:
3135         (BuildFactory.propertiesToPassToTriggers):
3136
3137 2019-01-17  Jer Noble  <jer.noble@apple.com>
3138
3139         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3140         https://bugs.webkit.org/show_bug.cgi?id=189553
3141
3142         Reviewed by Tim Horton.
3143
3144         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3145
3146         * ContentExtensionTester/Configurations/Base.xcconfig:
3147         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3148         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3149         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3150         * ImageDiff/cg/Configurations/Base.xcconfig:
3151         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3152         * MiniBrowser/Configurations/Base.xcconfig:
3153         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3154         * MobileMiniBrowser/Configurations/Base.xcconfig:
3155         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3156         * Scripts/webkitpy/style/checker.py:
3157         (_all_categories):
3158         (FileType):
3159         (CheckerDispatcher._file_type):
3160         (CheckerDispatcher._create_checker):
3161         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3162         (SDKVariantChecker):
3163         (SDKVariantChecker.__init__):
3164         (SDKVariantChecker.check):
3165         * TestWebKitAPI/Configurations/Base.xcconfig:
3166         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3167         * WebEditingTester/Configurations/Base.xcconfig:
3168         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3169         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3170         * WebKitTestRunner/Configurations/Base.xcconfig:
3171         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3172         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3173         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3174
3175 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3176
3177         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3178         https://bugs.webkit.org/show_bug.cgi?id=193534
3179
3180         Reviewed by Antti Koivisto.
3181
3182         * LayoutReloaded/misc/LFC-passing-tests.txt:
3183
3184 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3185
3186         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3187         https://bugs.webkit.org/show_bug.cgi?id=193528
3188
3189         Reviewed by Antti Koivisto.
3190
3191         * LayoutReloaded/misc/LFC-passing-tests.txt:
3192
3193 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3194
3195         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3196         https://bugs.webkit.org/show_bug.cgi?id=193520
3197
3198         Reviewed by Antti Koivisto.
3199
3200         * LayoutReloaded/misc/LFC-passing-tests.txt:
3201
3202 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3203
3204         [ews-build] unapply-patch step should not update source
3205         https://bugs.webkit.org/show_bug.cgi?id=193234
3206
3207         Reviewed by Lucas Forschler.
3208
3209         * BuildSlaveSupport/ews-build/steps.py:
3210         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3211         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3212
3213 2019-01-16  Youenn Fablet  <youenn@apple.com>
3214
3215         Add a new SPI for controlling getUserMedia
3216         https://bugs.webkit.org/show_bug.cgi?id=192793
3217
3218         Reviewed by Eric Carlson.
3219
3220         * MiniBrowser/mac/WK2BrowserWindowController.m:
3221         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3222         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3223         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3224         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3225         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3226         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3227         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3228         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3229         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3230         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3231         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3232         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3233         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3234         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3235
3236 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3237
3238         [LFC][BFC] Inflow non-replaced used width should not be negative.
3239         https://bugs.webkit.org/show_bug.cgi?id=193495
3240
3241         Reviewed by Antti Koivisto.
3242
3243         * LayoutReloaded/misc/LFC-passing-tests.txt:
3244
3245 2019-01-16  Chris Dumez  <cdumez@apple.com>
3246
3247         Regression(PSON) View becomes blank after click a cross-site download link
3248         https://bugs.webkit.org/show_bug.cgi?id=193361
3249         <rdar://problem/47099573>
3250
3251         Reviewed by Geoffrey Garen.
3252
3253         Add API test coverage.
3254
3255         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3256         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3257
3258 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3259
3260         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3261         https://bugs.webkit.org/show_bug.cgi?id=193470
3262
3263         Reviewed by Antti Koivisto.
3264
3265         * LayoutReloaded/misc/LFC-passing-tests.txt:
3266
3267 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3268
3269         [LFC] Adjust margin box verification.
3270         https://bugs.webkit.org/show_bug.cgi?id=193482
3271
3272         Reviewed by Antti Koivisto.
3273
3274         * LayoutReloaded/misc/LFC-passing-tests.txt:
3275
3276 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3277
3278         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3279         https://bugs.webkit.org/show_bug.cgi?id=193451
3280
3281         Reviewed by Geoffrey Garen.
3282
3283         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3284         (TEST):
3285         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3286         (runWebsiteDataStoreCustomPaths):
3287
3288 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3289
3290         webkitpy: Support boolean simctl isAvailable
3291         https://bugs.webkit.org/show_bug.cgi?id=193472
3292         <rdar://problem/47296150>
3293
3294         Reviewed by Ryosuke Niwa.
3295
3296         * Scripts/webkitpy/xcode/simulated_device.py:
3297         (SimulatedDeviceManager._create_runtimes):
3298         (SimulatedDeviceManager._create_device_with_runtime):
3299
3300 2019-01-15  Chris Dumez  <cdumez@apple.com>
3301
3302         Unreviewed, rolling out r239993, r239995, r239997, and
3303         r239999.
3304
3305         Caused assertions under
3306         ViewGestureController::disconnectFromProcess()
3307
3308         Reverted changesets:
3309
3310         "Regression(PSON) View becomes blank after click a cross-site
3311         download link"
3312         https://bugs.webkit.org/show_bug.cgi?id=193361
3313         https://trac.webkit.org/changeset/239993
3314
3315         "Unreviewed iOS build fix after r239993."
3316         https://trac.webkit.org/changeset/239995
3317
3318         "Fix iOS build after r239993"
3319         https://bugs.webkit.org/show_bug.cgi?id=193361
3320         https://trac.webkit.org/changeset/239997
3321
3322         "Unreviewed, revert part of r239997 as it is not needed to fix
3323         the build."
3324         https://trac.webkit.org/changeset/239999
3325
3326 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3327
3328         Cannot tab out of WKWebView on macOS
3329         https://bugs.webkit.org/show_bug.cgi?id=161448
3330         <rdar://problem/28100085>
3331
3332         Reviewed by Dean Jackson.
3333
3334         Add a test that tabbing into and out of WKWebView works correctly.
3335
3336         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3337         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3338         (WebKit2_CommandBackForwardTest::SetUp):
3339         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3340         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3341         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3342         (-[FocusableView canBecomeKeyView]):
3343         (TEST):
3344         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3345         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3346         (-[OffscreenWindow initWithSize:]):
3347         (-[OffscreenWindow isKeyWindow]):
3348         (-[OffscreenWindow isVisible]):
3349         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3350         (TestWebKitAPI::PlatformWebView::initialize):
3351         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3352         (-[ActiveOffscreenWindow isVisible]): Deleted.
3353         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3354
3355 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3356
3357         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3358         https://bugs.webkit.org/show_bug.cgi?id=193459
3359
3360         Reviewed by Mark Lam.
3361
3362         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3363         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3364
3365 2019-01-15  Chris Dumez  <cdumez@apple.com>
3366
3367         Regression(PSON) View becomes blank after click a cross-site download link
3368         https://bugs.webkit.org/show_bug.cgi?id=193361
3369         <rdar://problem/47099573>
3370
3371         Reviewed by Geoff Garen.
3372
3373         Add API test coverage.
3374
3375         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3376         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3377
3378 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3379
3380         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3381         https://bugs.webkit.org/show_bug.cgi?id=193448
3382
3383         Reviewed by Antti Koivisto.
3384
3385         * LayoutReloaded/misc/LFC-passing-tests.txt:
3386
3387 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3388
3389         webkitpy: Implement device type specific expected results (Part 1)
3390         https://bugs.webkit.org/show_bug.cgi?id=192162
3391
3392         Reviewed by Lucas Forschler.
3393
3394         Device type specific expected results covers two related ideas. The first (covered by this change)
3395         is where to search for -expected.* files. The second is which tests to run based on the
3396         TestExpectations.txt file.
3397
3398         After this change, the baseline search path will be determined by the type of device running a
3399         test. Device type will be passed into any function which picks a file based on the baseline search
3400         path.
3401
3402         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3403         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3404         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3405         (Manager.run): Print baseline search path for each round of devices.
3406         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3407         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3408         (SingleTestRunner._expected_driver_output): Ditto.
3409         (SingleTestRunner._driver_input): Ditto.
3410         * Scripts/webkitpy/layout_tests/views/printing.py:
3411         (Printer.print_config): Move printing of baseline search path to a separate function.
3412         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3413         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3414         (Testprinter.test_print_config):
3415         (Testprinter.test_print_baseline_search_path):
3416         * Scripts/webkitpy/port/base.py:
3417         (Port.baseline_search_path): Pass device_type through.
3418         (Port._expected_baselines_for_suffixes): Ditto.
3419         (Port.expected_baselines): Ditto.
3420         (Port.expected_filename): Ditto.
3421         (Port.expected_checksum): Ditto.
3422         (Port.expected_image): Ditto.
3423         (Port.expected_audio): Ditto.
3424         (Port.expected_text): Ditto.
3425         (Port.reference_files): Ditto.
3426         (Port.tests): Ditto.
3427         (Port._expanded_paths): Ditto.
3428         (Port.skipped_layout_tests): Ditto.
3429         (Port.expectations_dict): Ditto.
3430         (Port._port_specific_expectations_files): Ditto.
3431         (Port.expectations_files): Ditto.
3432         (Port.test_search_path): Ditto.
3433         (Port._tests_for_other_platforms): Ditto.
3434         * Scripts/webkitpy/port/base_unittest.py:
3435         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3436         (PortTest.test_nonexistant_expectations): Ditto.
3437         (test_ref_tests_platform_directory): Ditto.
3438         * Scripts/webkitpy/port/darwin.py:
3439         (DarwinPort._port_specific_expectations_files): Accept device_type.
3440         * Scripts/webkitpy/port/driver.py:
3441         (DriverProxy):
3442         (DriverProxy.host): Expose _target_host for device_type information.
3443         * Scripts/webkitpy/port/gtk.py:
3444         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3445         * Scripts/webkitpy/port/ios.py:
3446         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3447         * Scripts/webkitpy/port/mac.py:
3448         (MacPort. default_baseline_search_path): Ditto.
3449         * Scripts/webkitpy/port/port_testcase.py:
3450         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3451         * Scripts/webkitpy/port/test.py:
3452         * Scripts/webkitpy/port/watch.py:
3453         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3454         * Scripts/webkitpy/port/win.py:
3455         (WinPort.test_search_path): Accept, but do not use, device_type.
3456         * Scripts/webkitpy/port/wpe.py:
3457         (WPEPort._port_specific_expectations_files): Ditto.
3458         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3459         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3460
3461 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3462
3463         [LFC] Use the containing block's padding box to position out-of-flow elements.
3464         https://bugs.webkit.org/show_bug.cgi?id=193431
3465
3466         Reviewed by Antti Koivisto.
3467
3468         * LayoutReloaded/misc/LFC-passing-tests.txt:
3469
3470 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3471
3472         Move a test implementation file that got misplaced in the Xcode project
3473
3474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3475
3476 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3477
3478         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3479         r239913, and r239914.
3480         https://bugs.webkit.org/show_bug.cgi?id=193407
3481
3482         These revisions caused an internal failure (Requested by
3483         Truitt on #webkit).
3484
3485         Reverted changesets:
3486
3487         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3488         https://bugs.webkit.org/show_bug.cgi?id=186016
3489         https://trac.webkit.org/changeset/239901
3490
3491         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3492         https://trac.webkit.org/changeset/239909
3493
3494         "Tried to fix the build."
3495         https://trac.webkit.org/changeset/239910
3496
3497         "Fixed iOS builds after r239910."
3498         https://trac.webkit.org/changeset/239912
3499
3500         "More build fixing."
3501         https://trac.webkit.org/changeset/239913
3502
3503         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3504         https://trac.webkit.org/changeset/239914
3505
3506 2019-01-14  Mark Lam  <mark.lam@apple.com>
3507
3508         Re-enable ability to build --cloop builds.
3509         https://bugs.webkit.org/show_bug.cgi?id=192955
3510         <rdar://problem/46882363>
3511
3512         Reviewed by Saam barati and Keith Miller.
3513
3514         The --cloop build option was being ignored this whole time since r236381.
3515         This patch makes it possible to build CLoop builds again.
3516
3517         * Scripts/build-jsc:
3518         * Scripts/webkitperl/FeatureList.pm:
3519         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3520
3521 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3522
3523         webkitpy: Expose device_type from host-like objects
3524         https://bugs.webkit.org/show_bug.cgi?id=193406
3525         <rdar://problem/47262305>
3526
3527         Reviewed by Lucas Forschler.
3528
3529         Devices should expose device_type. As a result, all host objects should
3530         provide a device_type property, even if they do not yet define a device_type.
3531
3532         * Scripts/webkitpy/common/system/systemhost.py:
3533         (SystemHost):
3534         (SystemHost.device_type):
3535         * Scripts/webkitpy/common/system/systemhost_mock.py:
3536         (MockSystemHost):
3537         (MockSystemHost.device_type):
3538         * Scripts/webkitpy/port/device.py:
3539         (Device):
3540         (Device.device_type):
3541         * Scripts/webkitpy/xcode/simulated_device.py:
3542         (SimulatedDeviceManager._find_exisiting_device_for_request):
3543         (SimulatedDeviceManager._disambiguate_device_type):
3544         (SimulatedDeviceManager._does_fulfill_request):
3545         (SimulatedDeviceManager.device_count_for_type):
3546         (SimulatedDeviceManager.initialize_devices):
3547         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3548         (test_available_devices):
3549         (test_swapping_devices):
3550
3551 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3552
3553         webkitpy: Support alternate simctl device list output (Follow-up fix)
3554         https://bugs.webkit.org/show_bug.cgi?id=193362
3555         <rdar://problem/47122965>
3556
3557         Rubber-stamped by Lucas Forschler.
3558
3559         * Scripts/webkitpy/xcode/simulated_device.py:
3560         (SimulatedDeviceManager.populate_available_devices):
3561
3562 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3563
3564         [iOS] Expose SPI to access the current sentence boundary and selection state
3565         https://bugs.webkit.org/show_bug.cgi?id=193398
3566         <rdar://problem/45893108>
3567
3568         Reviewed by Dean Jackson.
3569
3570         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3571         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3572         expected.
3573
3574         * TestWebKitAPI/EditingTestHarness.h:
3575         * TestWebKitAPI/EditingTestHarness.mm:
3576         (-[EditingTestHarness moveBackward]):
3577         (-[EditingTestHarness moveForward]):
3578         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3579
3580         Add a couple of new helper methods on EditingTestHarness.
3581
3582         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3583         (-[SelectionChangeObserver initWithWebView:]):
3584         (-[SelectionChangeObserver webView]):
3585         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3586         (-[SelectionChangeObserver currentSelectionAttributes]):
3587
3588 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3589
3590         [LFC][BFC] Add basic box-sizing support.
3591         https://bugs.webkit.org/show_bug.cgi?id=193392
3592
3593         Reviewed by Antti Koivisto.
3594
3595         * LayoutReloaded/misc/LFC-passing-tests.txt:
3596
3597 2019-01-14  Charlie Turner  <cturner@igalia.com>
3598
3599         [WPE] API test gardening
3600         https://bugs.webkit.org/show_bug.cgi?id=193319
3601
3602         Reviewed by Michael Catanzaro.
3603
3604         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3605         passing tests.
3606
3607 2019-01-14  Charlie Turner  <cturner@igalia.com>
3608
3609         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3610         https://bugs.webkit.org/show_bug.cgi?id=192977
3611
3612         Reviewed by Carlos Garcia Campos.
3613
3614         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3615         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3616         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3617         (TestWebKitAPI::GStreamerTest::SetUp):
3618         (TestWebKitAPI::GStreamerTest::TearDown):
3619         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3620         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3621         (TestWebKitAPI::TEST_F):
3622
3623 2019-01-14  Charlie Turner  <cturner@igalia.com>
3624
3625         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3626         https://bugs.webkit.org/show_bug.cgi?id=193332
3627
3628         Reviewed by Michael Catanzaro.
3629
3630         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3631         defined as a char16_t, which changed in ICU 59, the
3632         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3633         unsigned short. This test is relying on the behaviour that
3634         UChar=unsigned short, which doesn't hold across platforms and ICU
3635         library versions. The full fix would be a special syntax for
3636         literal characters so that these ambiguities do not arise. That
3637         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3638         (TestWebKitAPI::TEST):
3639
3640 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3641
3642         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3643
3644         * Scripts/make-dist:
3645         (Distcheck.configure):
3646
3647 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3648
3649         [ews-build] Update macOS queue configurations
3650         https://bugs.webkit.org/show_bug.cgi?id=193365
3651         <rdar://problem/47221073>
3652
3653         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3654
3655         * BuildSlaveSupport/ews-build/config.json:
3656
3657 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3658
3659         [LFC] Adjust assert for statically positioned fixed elements
3660         https://bugs.webkit.org/show_bug.cgi?id=193385
3661
3662         Reviewed by Antti Koivisto.
3663
3664         * LayoutReloaded/misc/LFC-passing-tests.txt:
3665
3666 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3667
3668         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3669         https://bugs.webkit.org/show_bug.cgi?id=193387
3670
3671         Reviewed by Carlos Garcia Campos.
3672
3673         * MiniBrowser/wpe/main.cpp:
3674         (main):
3675
3676 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3677
3678         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3679         https://bugs.webkit.org/show_bug.cgi?id=191655
3680         rdar://problem/46074680
3681
3682         Reviewed by Megan Gardner.
3683
3684         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3685         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3686
3687 2019-01-12  Dan Bernstein  <mitz@apple.com>
3688
3689         [Cocoa] Avoid importing directly from subumbrella frameworks
3690         https://bugs.webkit.org/show_bug.cgi?id=186016
3691         <rdar://problem/40591038>
3692
3693         Reviewed by Sam Weinig.
3694
3695         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3696           LaunchServices header.
3697         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3698           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3699         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3700           when using SDKs earlier than 10.13.
3701         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3702           and OTHER_CPLUSPLUSFLAGS.
3703         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3704           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3705         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3706           LaunchServices header.
3707
3708 2019-01-11  John Wilander  <wilander@apple.com>
3709
3710         Compile out Web API Statistics Collection
3711         https://bugs.webkit.org/show_bug.cgi?id=193370
3712         <rdar://problem/45388584>
3713
3714         Reviewed by Brent Fulgham.
3715
3716         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3717             Defined ENABLE_WEB_API_STATISTICS, off by default.
3718
3719 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3720
3721         [WPE] Add gtk-doc
3722         https://bugs.webkit.org/show_bug.cgi?id=178900
3723
3724         Reviewed by Michael Catanzaro.
3725
3726         Add Tools/gtkdoc to manifest.txt.in files.
3727         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3728
3729         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3730         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3731
3732 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3733
3734         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3735         https://bugs.webkit.org/show_bug.cgi?id=193364
3736         <rdar://problem/47214117>
3737
3738         Reviewed by Tim Horton.
3739
3740         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3741         precise, whereas dragging near the middle of the textarea does.
3742
3743         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3744         (TestWebKitAPI::TEST):
3745
3746 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3747
3748         webkitpy: Support alternate simctl device list output
3749         https://bugs.webkit.org/show_bug.cgi?id=193362
3750         <rdar://problem/47122965>
3751
3752         Reviewed by Lucas Forschler.
3753
3754         * Scripts/webkitpy/xcode/simulated_device.py:
3755         (SimulatedDeviceManager.populate_available_devices):
3756
3757 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3758
3759         [ews-build] Update macOS queue configurations
3760         https://bugs.webkit.org/show_bug.cgi?id=193365
3761
3762         Reviewed by Lucas Forschler.
3763
3764         * BuildSlaveSupport/ews-build/config.json:
3765
3766 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3767
3768         webkitpy: Incorporate device type into baseline search path
3769         https://bugs.webkit.org/show_bug.cgi?id=193356
3770         <rdar://problem/47215515>
3771
3772         Reviewed by Lucas Forschler.
3773
3774         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3775
3776         * Scripts/webkitpy/port/base.py:
3777         (Port.default_baseline_search_path): Allow device type to be passed in.
3778         * Scripts/webkitpy/port/gtk.py:
3779         (GtkPort.default_baseline_search_path): Ignore device type.
3780         * Scripts/webkitpy/port/ios.py:
3781         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3782         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3783         * Scripts/webkitpy/port/ios_device_unittest.py:
3784         (IOSDeviceTest):
3785         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3786         (IOSSimulatorTest):
3787         * Scripts/webkitpy/port/mac.py:
3788         (MacPort.default_baseline_search_path): Ignore device type.
3789         * Scripts/webkitpy/port/watch.py:
3790         (WatchPort.default_baseline_search_path): Ditto.
3791         * Scripts/webkitpy/port/win.py:
3792         (WinPort.default_baseline_search_path): Ditto.
3793         (WinCairoPort.default_baseline_search_path): Ditto.
3794         * Scripts/webkitpy/port/wpe.py:
3795         (WPEPort.default_baseline_search_path): Ditto.
3796
3797 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3798
3799         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3800         https://bugs.webkit.org/show_bug.cgi?id=193352
3801         <rdar://problem/47210736>
3802
3803         Reviewed by Lucas Forschler.
3804
3805         * Scripts/webkitpy/layout_tests/views/printing.py:
3806         (Printer.print_config): Print list on only baseline search paths which exist. 
3807         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3808         (Testprinter.test_print_config):
3809
3810 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3811
3812         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3813         https://bugs.webkit.org/show_bug.cgi?id=193340
3814
3815         Reviewed by David Kilzer.
3816
3817         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3818         (WTR::InjectedBundle::didReceiveMessageToPage):
3819         Pull the strings out into a WKRetainPtr.
3820
3821         * WebKitTestRunner/WebNotificationProvider.cpp:
3822         (WTR::WebNotificationProvider::closeWebNotification):
3823         Adopt the created value into the WKRetainPtr.
3824
3825         * WebKitTestRunner/mac/TestControllerMac.mm:
3826         (WTR::generateWhitelist):
3827         Immediately adopt a created value to avoid potential mistakes.
3828
3829 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3830
3831         Enable DFG on ARM/Linux again
3832         https://bugs.webkit.org/show_bug.cgi?id=192496
3833
3834         Reviewed by Yusuke Suzuki.
3835
3836         After changing the bytecode format DFG was disabled on all 32-bit
3837         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3838         on ARM by default.
3839
3840         * Scripts/run-jsc-stress-tests:
3841
3842 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3843
3844         Unreviewed, fix #ifdef in API test added in r239851.
3845         https://bugs.webkit.org/show_bug.cgi?id=193327
3846         rdar://problem/47093222
3847
3848         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3849
3850 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3851
3852         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3853         https://bugs.webkit.org/show_bug.cgi?id=193109
3854         <rdar://problem/44807048>
3855
3856         Reviewed by Ryosuke Niwa.
3857
3858         Introduce and respect a test option to enable the UndoManager API.
3859
3860         * WebKitTestRunner/TestController.cpp:
3861         (WTR::updateTestOptionsFromTestHeader):
3862         * WebKitTestRunner/TestOptions.h:
3863         (WTR::TestOptions::hasSameInitializationOptions const):
3864         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3865         (WTR::TestController::platformCreateWebView):
3866
3867 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3868
3869         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3870         https://bugs.webkit.org/show_bug.cgi?id=193346
3871
3872         Reviewed by Antti Koivisto.
3873
3874         * LayoutReloaded/misc/LFC-passing-tests.txt:
3875
3876 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3877
3878         Unreviewed, fix typo that breaks dashboard link.
3879
3880         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3881         (WebKitBuildbot):
3882
3883 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3884
3885         Update macOS queue configurations
3886         https://bugs.webkit.org/show_bug.cgi?id=193329
3887
3888         Reviewed by Alexey Proskuryakov.
3889
3890         * BuildSlaveSupport/build.webkit.org-config/config.json:
3891         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3892         (BubbleQueueServer):
3893         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3894         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3895         (WebKitBuildbot):
3896         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3897         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3898         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3899
3900 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3901
3902         MiniBrowser should be able to navigate to about:blank
3903         https://bugs.webkit.org/show_bug.cgi?id=193345
3904
3905         Reviewed by Simon Fraser.
3906
3907         * MiniBrowser/mac/BrowserWindowController.m:
3908         (-[BrowserWindowController addProtocolIfNecessary:]):
3909         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3910
3911         * MiniBrowser/mac/WK1BrowserWindowController.m:
3912         (-[WK1BrowserWindowController fetch:]):
3913         * MiniBrowser/mac/WK2BrowserWindowController.m:
3914         (-[WK2BrowserWindowController fetch:]):
3915         Clean up the code that uses this to match style.
3916
3917 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3918
3919         Remove MiniBrowser custom "Process Swap" menu item which does not work
3920         https://bugs.webkit.org/show_bug.cgi?id=193344
3921
3922         Reviewed by Simon Fraser.
3923
3924         There is a menu item under the Experimental menu that does work.
3925
3926         * MiniBrowser/mac/AppDelegate.m:
3927         (defaultConfiguration):
3928         * MiniBrowser/mac/SettingsController.h:
3929         * MiniBrowser/mac/SettingsController.m:
3930         (-[SettingsController _populateMenu]):
3931         (-[SettingsController validateMenuItem:]):
3932         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3933         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3934
3935 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3936
3937         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3938         https://bugs.webkit.org/show_bug.cgi?id=193327
3939         rdar://problem/47093222
3940
3941         Reviewed by Tim Horton.
3942
3943         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3944         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3945         (TestWebKitAPI::didFinishNavigation):
3946         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3947         (TestWebKitAPI::TEST):
3948         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3949         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3950         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3951         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3952         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3953
3954 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3955
3956         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3957         https://bugs.webkit.org/show_bug.cgi?id=193338
3958         <rdar://problem/46664774>
3959
3960         Reviewed by David Kilzer.
3961
3962         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3963         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3964
3965 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3966
3967         Unreviewed, rolling out r239825.
3968         https://bugs.webkit.org/show_bug.cgi?id=193330
3969
3970         Broke tests on armv7/linux bots (Requested by guijemont on
3971         #webkit).
3972
3973         Reverted changeset:
3974
3975         "Enable DFG on ARM/Linux again"
3976         https://bugs.webkit.org/show_bug.cgi?id=192496
3977         https://trac.webkit.org/changeset/239825
3978
3979 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3980
3981         Disable the run-jsc-stress-test remote host key check.
3982         https://bugs.webkit.org/show_bug.cgi?id=192988
3983
3984         Reviewed by Alexey Proskuryakov.
3985
3986         * Scripts/run-jsc-stress-tests:
3987
3988 2019-01-10  John Wilander  <wilander@apple.com>
3989
3990         Override the session configuration for cookieAcceptPolicy
3991         https://bugs.webkit.org/show_bug.cgi?id=190925
3992         <rdar://problem/45497382>
3993
3994         Reviewed by Alexey Proskuryakov and Alex Christensen.
3995
3996         Test infrastructure for setting a first-party-only cookie policy.
3997
3998         * DumpRenderTree/TestRunner.cpp:
3999         (setOnlyAcceptFirstPartyCookiesCallback):
4000         (TestRunner::staticFunctions):
4001         * DumpRenderTree/TestRunner.h:
4002         * DumpRenderTree/mac/TestRunnerMac.mm:
4003         (TestRunner::setOnlyAcceptFirstPartyCookies):
4004         * DumpRenderTree/win/TestRunnerWin.cpp:
4005         (TestRunner::setOnlyAcceptFirstPartyCookies):
4006         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4007         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4008         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
4009         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4010         * WebKitTestRunner/TestInvocation.cpp:
4011         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4012
4013 2019-01-09  Matt Rajca  <mrajca@apple.com>
4014
4015         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
4016         https://bugs.webkit.org/show_bug.cgi?id=193301
4017
4018         Reviewed by Jer Noble.
4019         
4020         Added API tests.
4021
4022         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4023         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4024         (TEST):
4025         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
4026
4027 2019-01-10  Zalan Bujtas  <zalan@apple.com>
4028
4029         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
4030         https://bugs.webkit.org/show_bug.cgi?id=193310
4031
4032         Reviewed by Antti Koivisto.
4033
4034         * LayoutReloaded/misc/LFC-passing-tests.txt:
4035
4036 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
4037
4038         Enable DFG on ARM/Linux again
4039         https://bugs.webkit.org/show_bug.cgi?id=192496
4040
4041         Reviewed by Yusuke Suzuki.
4042
4043         After changing the bytecode format DFG was disabled on all 32-bit
4044         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
4045         on ARM by default.
4046
4047         * Scripts/run-jsc-stress-tests:
4048
4049 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
4050
4051         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
4052         https://bugs.webkit.org/show_bug.cgi?id=193271
4053
4054         Reviewed by Brent Fulgham.
4055
4056         BSTR is a special data structure created by SysAllocString, not a
4057         wchar_t null-terminated string.
4058
4059         * DumpRenderTree/win/TestRunnerWin.cpp:
4060         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
4061         * MiniBrowser/win/MiniBrowserWebHost.cpp:
4062         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
4063         BSTR from wide string literals.
4064
4065 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
4066
4067         Tweak wording for build/version_check style checker error
4068         https://bugs.webkit.org/show_bug.cgi?id=193256
4069
4070         Reviewed by Tim Horton.
4071
4072         * Scripts/webkitpy/style/checkers/cpp.py:
4073         (check_os_version_checks):
4074         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4075         (WebKitStyleTest.test_os_version_checks):
4076
4077 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4078
4079         [ews-build] Add link to bug along with bug title
4080         https://bugs.webkit.org/show_bug.cgi?id=193293
4081
4082         Reviewed by Lucas Forschler.
4083
4084         * BuildSlaveSupport/ews-build/steps.py:
4085         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
4086         (ConfigureBuild.add_bug_id_url): Deleted.
4087         (ConfigureBuild.getBugURL): Deleted.
4088
4089 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4090
4091         [ews-build] Use https for ews-build server
4092         https://bugs.webkit.org/show_bug.cgi?id=193193
4093
4094         Reviewed by Lucas Forschler.
4095
4096         * BuildSlaveSupport/ews-build/steps.py:
4097
4098 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4099
4100         [ews-build] Parse and display number of style failures
4101         https://bugs.webkit.org/show_bug.cgi?id=193280
4102
4103         Reviewed by Lucas Forschler.
4104
4105         * BuildSlaveSupport/ews-build/steps.py:
4106         (CheckStyle): Use TestWithFailureCount as base class.
4107         (CheckStyle.countFailures): Count the number of style failures.
4108
4109 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4110
4111         [ews-build] use patch_id instead of ewspatchid
4112         https://bugs.webkit.org/show_bug.cgi?id=193235
4113
4114         Reviewed by Lucas Forschler.
4115
4116         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
4117         * BuildSlaveSupport/ews-build/steps.py: Ditto.
4118         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
4119
4120 2019-01-09  Zalan Bujtas  <zalan@apple.com>
4121
4122         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
4123         https://bugs.webkit.org/show_bug.cgi?id=192625
4124
4125         Reviewed by Antti Koivisto.
4126
4127         * LayoutReloaded/misc/LFC-passing-tests.txt:
4128
4129 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
4130
4131         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
4132         https://bugs.webkit.org/show_bug.cgi?id=192841
4133
4134         Reviewed by Carlos Garcia Campos.
4135
4136         There are separate g_assert_*() macros for use in tests, which we use inconsistently
4137         currently. Use them always. We'll get nicer error messages now when tests fail, and the
4138         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
4139
4140         Note that the documentation of g_assert() says that it is not to be used when writing tests.
4141
4142         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4143         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
4144         (WebKitWebEditorTest::testSelectionChanged):
4145         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
4146         (WebKitFrameTest::testMainFrame):
4147         (WebKitFrameTest::testURI):
4148         (WebKitFrameTest::testJavaScriptContext):
4149         (WebKitFrameTest::testJavaScriptValues):
4150         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
4151         (testWebViewAuthenticationRequest):
4152         (testWebViewAuthenticationLoadCancelled):
4153         (testWebViewAuthenticationFailure):
4154         (testWebViewAuthenticationStorage):
4155         (ProxyAuthenticationTest::ProxyAuthenticationTest):
4156         (testWebViewAuthenticationProxy):
4157         (testWebViewAuthenticationProxyHTTPS):
4158         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4159         (testAutomationSessionRequestSession):
4160         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
4161         (testBackForwardListNavigation):
4162         (testWebKitWebViewSessionState):
4163         (testWebKitWebViewSessionStateWithFormData):
4164         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
4165         (ConsoleMessageTest::consoleMessageReceivedCallback):
4166         (testWebKitConsoleMessageConsoleAPI):
4167         (testWebKitConsoleMessageJavaScriptException):
4168         (testWebKitConsoleMessageNetworkError):
4169         (testWebKitConsoleMessageSecurityError):
4170         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
4171         (testCookieManagerAcceptPolicy):
4172         (testCookieManagerCookiesChanged):
4173         (testCookieManagerPersistentStorage):
4174         (testCookieManagerPersistentStorageDeleteAll):
4175         (testCookieManagerEphemeral):
4176         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
4177         (testWebKitDOMElementAutoFill):
4178         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
4179         (downloadLocalFileSuccessfully):
4180         (createFileAtDestination):
4181         (testDownloadOverwriteDestinationDisallowed):
4182         (testDownloadLocalFileError):
4183         (testDownloadRemoteFile):
4184         (testDownloadRemoteFileError):
4185         (testWebViewDownloadURI):
4186         (testPolicyResponseDownload):
4187         (testPolicyResponseDownloadCancel):
4188         (testDownloadMIMEType):
4189         (contextMenuCallback):
4190         (testContextMenuDownloadActions):
4191         (testBlobDownload):
4192         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
4193         (testWebKitWebEditorSelectionChanged):
4194         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
4195         (testWebKitFrameMainFrame):
4196         (testWebKitFrameURI):
4197         (testWebKitFrameJavaScriptContext):
4198         (testWebKitFrameJavaScriptValues):
4199         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4200         (LoadStopTrackingTest::loadFailed):
4201         (testWebViewTitle):
4202         (testURIRequestHTTPHeaders):
4203         (testURIRequestHTTPMethod):
4204         (testURIResponseHTTPHeaders):
4205         (testRedirectToDataURI):
4206         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
4207         (testProcessPerWebView):
4208         (testWebProcessLimit):
4209         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
4210         (testWebViewResources):
4211         (testWebResourceLoading):
4212         (testWebResourceSuggestedFilename):
4213         (testWebResourceGetData):
4214         (testWebResourceGetDataError):
4215         (testWebViewResourcesHistoryCache):
4216         (testWebResourceSendRequest):
4217         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
4218         (testSSL):
4219         (testInsecureContent):
4220         (testTLSErrorsPolicy):
4221         (testTLSErrorsRedirect):
4222         (testTLSErrorsHTTPAuth):
4223         (testLoadFailedWithTLSErrors):
4224         (testSubresourceLoadFailedWithTLSErrors):
4225         (httpsServerCallback):
4226         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
4227         (testWebViewCreateNavigationData):
4228         (testWebViewJavaScriptDialogs):
4229         (testWebViewWindowProperties):
4230         (testWebViewMouseTarget):
4231         (testWebViewFileChooserRequest):
4232         (testWebViewColorChooserRequest):
4233         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
4234         (testWebExtensionGetTitle):
4235         (testDocumentLoadedSignal):
4236         (testWebKitWebViewProcessCrashed):
4237         (testWebExtensionWindowObjectCleared):
4238         (testWebExtensionIsolatedWorld):
4239         (permissionRequestCallback):
4240         (didAssociateFormControlsCallback):
4241         (testWebExtensionFormControlsAssociated):
4242         (FormSubmissionTest::FormSubmissionTest):
4243         (FormSubmissionTest::testFormSubmissionResult):
4244         (testWebExtensionFormSubmissionSteps):
4245         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
4246         (testNotInitialized):
4247         (testClearDatabase):
4248         (testPrivateBrowsing):
4249         (testGetFavicon):
4250         (testWebViewFavicon):
4251         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
4252         (testFindControllerTextFound):
4253         (testFindControllerTextNotFound):
4254         (testFindControllerMatchCount):
4255         (testFindControllerMaxMatchCount):
4256         (testFindControllerNext):
4257         (testFindControllerPrevious):
4258         (testFindControllerCountedMatches):
4259         (testFindControllerOptions):
4260         (testFindControllerHide):
4261         (testFindControllerInstance):
4262         (testFindControllerGetters):
4263         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
4264         (testNavigationPolicy):
4265         (testResponsePolicy):
4266         (testNewWindowPolicy):
4267         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
4268         (testSecurityOriginBasicConstructor):
4269         (testSecurityOriginURIConstructor):
4270         (testSecurityOriginDefaultPort):
4271         (testSecurityOriginFileURI):
4272         (testOpaqueSecurityOrigin):
4273         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
4274         (testWebKitSettings):
4275         (testWebKitSettingsNewWithSettings):
4276         (testWebKitSettingsUserAgent):
4277         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4278         (testWebViewNewWithUserContentManager):
4279         (isStyleSheetInjectedForURLAtPath):
4280         (isScriptInjectedForURLAtPath):
4281         (testUserContentManagerInjectedStyleSheet):
4282         (testUserContentManagerInjectedScript):
4283         (UserScriptMessageTest::scriptMessageReceived):
4284         (UserScriptMessageTest::waitUntilMessageReceived):
4285         (UserScriptMessageTest::runJavaScriptFinished):
4286         (testUserContentManagerScriptMessageReceived):
4287         (testUserContentManagerScriptMessageInWorldReceived):
4288         (testUserContentManagerScriptMessageFromDOMBindings):
4289         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
4290         (testWebContextDefault):
4291         (testWebContextEphemeral):
4292         (testWebContextGetPlugins):
4293         (testWebContextURIScheme):
4294         (testWebContextSpellChecker):
4295         (testWebContextLanguages):
4296         (consoleMessageReceivedCallback):
4297         (testWebContextSecurityFileXHR):
4298         (ProxyTest::ProxyTest):
4299         (testWebContextProxySettings):
4300         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4301         (testWebViewWebContext):
4302         (testWebViewWebBackend):
4303         (testWebViewEphemeral):
4304         (testWebViewCustomCharset):
4305         (testWebViewSettings):
4306         (testWebViewRunJavaScript):
4307         (testWebViewCanShowMIMEType):
4308         (testWebViewSubmitForm):
4309         (testWebViewSave):
4310         (testWebViewPageVisibility):
4311         (testWebViewSnapshot):
4312         (testWebViewNotification):
4313         (testWebViewNotificationInitialPermissionAllowed):
4314         (testWebViewNotificationInitialPermissionDisallowed):
4315         (testWebViewIsPlayingAudio):
4316         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
4317         (WebsiteDataTest::WebsiteDataTest):
4318         (WebsiteDataTest::remove):
4319         (WebsiteDataTest::clear):
4320         (testWebsiteDataConfiguration):
4321         (testWebsiteDataEphemeral):
4322         (testWebsiteDataCache):
4323         (testWebsiteDataStorage):
4324         (testWebsiteDataDatabases):
4325         (testWebsiteDataAppcache):
4326         (testWebsiteDataCookies):
4327         (testWebsiteDataDeviceIdHashSalt):
4328         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
4329         (emitDocumentLoaded):
4330         (emitURIChanged):
4331         (sendRequestCallback):
4332         (contextMenuCallback):
4333         (consoleMessageSentCallback):
4334         (emitFormControlsAssociated):
4335         (formControlsAssociatedCallback):
4336         (emitFormSubmissionEvent):