HashTable::removeIf always shrinks the hash table by half even if there is nothing...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2
3         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
4         https://bugs.webkit.org/show_bug.cgi?id=196681
5
6         Reviewed by Darin Adler.
7
8         Added tests.
9
10         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
11         (WTF_HashSet.RemoveIf):
12         (WTF_HashSet.RemoveIfShrinkToBestSize):
13
14 2019-04-15  John Wilander  <wilander@apple.com>
15
16         Send delayed Ad Click Attribution conversion requests to the click source
17         https://bugs.webkit.org/show_bug.cgi?id=196838
18         <rdar://problem/47650157>
19
20         Reviewed by Chris Dumez and Youenn Fablet.
21
22         This patch adds test infrastructure to override the default behavior in
23         WebKit::NetworkAdClickAttribution.
24
25         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
26         (TestWebKitAPI::TEST):
27         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
28         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
29         (WTR::TestRunner::dumpAdClickAttribution):
30         (WTR::TestRunner::clearAdClickAttribution):
31         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
32         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
33         * WebKitTestRunner/InjectedBundle/TestRunner.h:
34         * WebKitTestRunner/TestController.cpp:
35         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
36         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
37         * WebKitTestRunner/TestController.h:
38         * WebKitTestRunner/TestInvocation.cpp:
39         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
40
41 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
42
43         [ews-app] status-bubble should display position in queue
44         https://bugs.webkit.org/show_bug.cgi?id=196607
45
46         Reviewed by Lucas Forschler.
47
48         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
49         (StatusBubble._build_bubble):
50         (StatusBubble._queue_position): Method to calculate patch's position in queue.
51
52 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
53
54         [ews-build] Do not run clean build by default on EWS builders
55         https://bugs.webkit.org/show_bug.cgi?id=196897
56
57         Reviewed by Lucas Forschler.
58
59         * BuildSlaveSupport/ews-build/steps.py:
60         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
61         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
62         untracked directories like WebKitBuild).
63         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
64         untracked files/directories (like WebKitBuild).
65
66 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
67
68         TestRunner::notifyDone() should be safely reentrant
69         https://bugs.webkit.org/show_bug.cgi?id=196898
70
71         Reviewed by Darin Adler.
72
73         It is currently possible that TestRunner::notifyDone() will call itself, since
74         notifyDone() will force a repaint, which can start executing JavaScript, which
75         may call notifyDone() again. This can lead to test failures and flakiness.
76         Fix this by setting the m_waitToDump flag before calling the dump() method.
77
78         * DumpRenderTree/mac/TestRunnerMac.mm:
79         (TestRunner::notifyDone):
80         (TestRunner::forceImmediateCompletion):
81         * DumpRenderTree/win/TestRunnerWin.cpp:
82         (TestRunner::notifyDone):
83         (TestRunner::forceImmediateCompletion):
84
85 2019-04-15  Philippe Normand  <pnormand@igalia.com>
86
87         [GTK][WPE] Add enable-media websetting
88         https://bugs.webkit.org/show_bug.cgi?id=196863
89
90         Reviewed by Michael Catanzaro.
91
92         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
93         (testWebKitSettings): Add test for the enable-media web-setting.
94
95 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
96
97         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
98         https://bugs.webkit.org/show_bug.cgi?id=196905
99         <rdar://problem/49886096>
100
101         Reviewed by Tim Horton.
102
103         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
104         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
105         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
106         delay timer, we end up with this sequence of events in the problematic (failure) case:
107
108         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
109             ...IPC from UI to web process...
110         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
111             ...IPC from web to UI process...
112         (c) [UI]    Invoke completion handler for script #1
113         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
114             ...IPC from UI to web process...
115         (e) [Web]   Evaluate script #2 in the web process
116         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
117
118         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
119         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
120         #2 is run in step (e).
121
122         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
123         the UI process by waiting on a script message posted by the web process, after attachment updates are
124         dispatched.
125
126         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
127         (TestWebKitAPI::TEST):
128
129 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
130
131         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
132         https://bugs.webkit.org/show_bug.cgi?id=196909
133
134         Reviewed by Wenson Hsieh.
135
136         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
137         (TestWebKitAPI::TEST):
138
139 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
140
141         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
142         https://bugs.webkit.org/show_bug.cgi?id=196880
143
144         Reviewed by Yusuke Suzuki.
145
146         Add a new function for bytecode cache tests that does not forceDiskCache
147         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
148         test added in this patch, since the code is invalid and therefore won't be
149         cached. It should also be useful for tests that evaluate dynamically
150         generated code.
151
152         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
153         * Scripts/run-jsc-stress-tests:
154
155 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
156
157         Update AudioSession route sharing policy
158         https://bugs.webkit.org/show_bug.cgi?id=196776
159         <rdar://problem/46501611>
160
161         Reviewed by Jer Noble.
162
163         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
164         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
165         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
166         (TestWebKitAPI::TEST):
167
168 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
169
170         [iOS] Software keyboard is shown too frequently on some websites
171         https://bugs.webkit.org/show_bug.cgi?id=195856
172         <rdar://problem/49191395>
173
174         Reviewed by Darin Adler.
175
176         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
177
178         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
179         (WTR::UIScriptController::setHardwareKeyboardAttached):
180         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
181         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
182         (WTR::UIScriptController::setHardwareKeyboardAttached):
183         * TestRunnerShared/UIScriptContext/UIScriptController.h:
184         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
185
186         Additionally link against GraphicsServices in WebKitTestRunner.
187
188         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
189         (WTR::TestController::platformResetStateToConsistentValues):
190         (WTR::UIScriptController::setHardwareKeyboardAttached):
191
192 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
193
194         [GTK][WPE] Fix pacman install-dependencies packages
195         https://bugs.webkit.org/show_bug.cgi?id=196817
196
197         Reviewed by Žan Doberšek.
198         
199         python3-setuptools is called python-setuptools
200         ruby-highline is only available on AUR
201         libv4l-devel is incorporated in v4l-utils
202
203         * gtk/install-dependencies:
204         * wpe/install-dependencies:
205
206 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
207
208         [GTK] REGRESSION(r243860): Many tests failing
209         https://bugs.webkit.org/show_bug.cgi?id=196791
210
211         Reviewed by Joanmarie Diggs.
212
213         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
214         multiple documents and check that accessibility hierarchy is updated after a navigation.
215
216         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
217         (loadChangedCallback):
218         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
219         (AccessibilityTest::AccessibilityTest):
220         (AccessibilityTest::~AccessibilityTest):
221         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
222         (AccessibilityTest::findTestServerApplication):
223         (AccessibilityTest::findDocumentWeb):
224         (AccessibilityTest::findRootObject):
225         (AccessibilityTest::waitUntilChildrenRemoved):
226         (AccessibilityTest::ensureProxy):
227         (testAtspiBasicHierarchy):
228         (beforeAll):
229         (afterAll):
230
231 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
232
233         [ews-build] Handle bug titles with unicode characters
234         https://bugs.webkit.org/show_bug.cgi?id=196802
235
236         Reviewed by Dewei Zhu.
237
238         * BuildSlaveSupport/ews-build/steps.py:
239         (ValidatePatch._is_bug_closed):
240
241 2019-04-11  Michael Saboff  <msaboff@apple.com>
242
243         Improve the Inline Cache Stats code
244         https://bugs.webkit.org/show_bug.cgi?id=196836
245
246         Reviewed by Saam Barati.
247
248         Added a new script to consolidate and arrange the output of --useICStats option.
249
250         This script merges the output from every group into one large table and sorts it from most common to
251         least common.  It also counts the slow path GetById and PutById variants and then calculates the
252         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
253         Put together, this is useful to see what property accesses are not getting cached.
254
255         * Scripts/ic-stats.py: Added.
256         (ICStats):
257         (ICStats.__init__):
258         (ICStats.parse):
259         (ICStats.dumpStats):
260         (usage):
261
262 2019-04-10  Alex Christensen  <achristensen@webkit.org>
263
264         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
265         https://bugs.webkit.org/show_bug.cgi?id=196809
266         <rdar://49800762>
267
268         Reviewed by Brady Eidson.
269
270         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
271         (TEST):
272
273 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
274
275         requestAnimationFrame should execute before the next frame
276         https://bugs.webkit.org/show_bug.cgi?id=177484
277
278         Reviewed by Simon Fraser.
279
280         Add trace points for the page RenderingUpdate.
281
282         * Tracing/SystemTracePoints.plist:
283
284 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
285
286         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
287         https://bugs.webkit.org/show_bug.cgi?id=196760
288
289         Reviewed by Don Olmstead.
290
291         vswhere.exe has been bundled since Visual Studio 2017 version
292         15.2. We shouldn't download vswhere.exe.
293
294         * Scripts/build-jsc: Do not call update-vswhere.py.
295         * Scripts/build-webkit: Ditto.
296         * Scripts/update-vswhere.py: Removed.
297         * Scripts/webkitdirs.pm:
298         (requireModulesForVSWhere): Deleted.
299         (pickCurrentVisualStudioInstallation): Deleted.
300         (visualStudioInstallDirVSWhere): Return the latest installed VS
301         installation path by using the bundled vswhere.exe.
302         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
303         (visualStudioInstallDirFallback): Removed.
304
305 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
306
307         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
308         https://bugs.webkit.org/show_bug.cgi?id=196780
309
310         Reviewed by Alexey Proskuryakov.
311
312         * BuildSlaveSupport/ews-build/steps.py:
313         * BuildSlaveSupport/ews-build/steps_unittest.py:
314
315 2019-04-10  Alex Christensen  <achristensen@webkit.org>
316
317         Add SPI WKNavigationResponse._downloadAttribute
318         https://bugs.webkit.org/show_bug.cgi?id=196755
319         <rdar://49587365>
320
321         Reviewed by Brady Eidson.
322
323         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
324         (-[NavigationResponseTestDelegate navigationResponse]):
325         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
326         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
327         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
328         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
329         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
330         (readRequest):
331         (writeResponse):
332         (TEST):
333
334 2019-04-10  Tim Horton  <timothy_horton@apple.com>
335
336         Add modern API for overriding the page's specified viewport configuration
337         https://bugs.webkit.org/show_bug.cgi?id=167734
338         <rdar://problem/30331795>
339
340         Reviewed by Simon Fraser.
341
342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
343         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
344
345 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
346
347         Add support for incremental bytecode cache updates
348         https://bugs.webkit.org/show_bug.cgi?id=195000
349
350         Reviewed by Filip Pizlo.
351
352         Exit when the initial run to generate bytecode fails.
353
354         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
355
356 2019-04-10  Alex Christensen  <achristensen@webkit.org>
357
358         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
359         https://bugs.webkit.org/show_bug.cgi?id=196744
360         <rdar://49415309>
361
362         Reviewed by Chris Dumez.
363
364         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
365         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
366
367 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
368
369         Add a way to opt into modern compatibility mode in layout tests
370         https://bugs.webkit.org/show_bug.cgi?id=196770
371         <rdar://problem/49777550>
372
373         Reviewed by Antoine Quint.
374
375         Add a new test option to enable modern compatibility mode in layout tests.
376
377         * WebKitTestRunner/TestController.cpp:
378         (WTR::updateTestOptionsFromTestHeader):
379         * WebKitTestRunner/TestController.h:
380         * WebKitTestRunner/TestOptions.h:
381         (WTR::TestOptions::hasSameInitializationOptions const):
382         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
383         (WTR::TestController::platformCreateWebView):
384         (WTR::TestController::enableModernCompatibilityMode):
385
386 2019-04-10  Andy Estes  <aestes@apple.com>
387
388         Try to fix the 32-bit watchOS build.
389
390         * TestWebKitAPI/cocoa/TestWKWebView.mm:
391         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
392
393 2019-04-10  Antoine Quint  <graouts@apple.com>
394
395         Enable Pointer Events on watchOS
396         https://bugs.webkit.org/show_bug.cgi?id=196771
397         <rdar://problem/49040909>
398
399         Reviewed by Dean Jackson.
400
401         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
402
403 2019-04-10  Philippe Normand  <pnormand@igalia.com>
404
405         Unreviewed. Fix WPE accessibility tests after r244059.
406
407         We are failing to load the injected bundle due to undefined symbol
408         AccessibilityUIElement::replaceTextInRange().
409
410         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
411         (WTR::AccessibilityUIElement::replaceTextInRange):
412
413 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
414
415         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
416         https://bugs.webkit.org/show_bug.cgi?id=196727
417
418         Reviewed by Fujii Hironori.
419
420         * MiniBrowser/win/WebKitBrowserWindow.cpp:
421         (WebKitBrowserWindow::create):
422
423 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
424
425         [ews-build] Add unit tests for PrintConfiguration
426         https://bugs.webkit.org/show_bug.cgi?id=196752
427
428         Reviewed by Dewei Zhu.
429
430         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
431
432 2019-04-09  Keith Rollin  <krollin@apple.com>
433
434         Unreviewed build maintenance -- update .xcfilelists.
435
436         * DumpRenderTree/DerivedSources-input.xcfilelist:
437         * DumpRenderTree/DerivedSources-output.xcfilelist:
438
439 2019-04-09  Zalan Bujtas  <zalan@apple.com>
440
441         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
442         https://bugs.webkit.org/show_bug.cgi?id=196743
443         <rdar://problem/43897551>
444
445         Reviewed by Tim Horton.
446
447         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
448         (TEST):
449
450 2019-04-09  Youenn Fablet  <youenn@apple.com>
451
452         Close service worker database on network process suspension
453         https://bugs.webkit.org/show_bug.cgi?id=196623
454         <rdar://problem/48930869>
455
456         Reviewed by Alex Christensen.
457
458         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
459
460 2019-04-09  Daniel Bates  <dabates@apple.com>
461
462         [iPad] Should open popover when the spacebar is pressed
463         https://bugs.webkit.org/show_bug.cgi?id=196360
464         <rdar://problem/49389129>
465
466         Reviewed by Brent Fulgham.
467
468         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
469
470         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
471         (WTR::UIScriptController::isShowingPopover const): Added.
472         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
473         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
474         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
475         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
476         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
477         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
478         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
479         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
480         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
481         (WTR::UIScriptController::isShowingPopover const): Added.
482         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
483         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
484         * TestRunnerShared/UIScriptContext/UIScriptController.h:
485         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
486         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
487         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
488         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
489         (-[TestRunnerWKWebView _willPresentPopover]): Added.
490         (-[TestRunnerWKWebView _didDismissPopover]): Added.
491         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
492         (WTR::UIScriptController::isShowingPopover const): Added.
493         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
494         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
495
496 2019-04-09  Alex Christensen  <achristensen@webkit.org>
497
498         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
499         https://bugs.webkit.org/show_bug.cgi?id=196665
500         <rdar://45115669>
501
502         Reviewed by Geoff Garen.
503
504         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
505         (goBack):
506         (+[SimpleLookupContext sharedLookupContext]):
507         (-[SimpleLookupContext lookUpURL:completionHandler:]):
508         (TEST):
509         (+[Simple3LookupContext sharedLookupContext]): Deleted.
510         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
511
512 2019-04-09  John Wilander  <wilander@apple.com>
513
514         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
515         https://bugs.webkit.org/show_bug.cgi?id=196558
516         <rdar://problem/47650245>
517
518         Reviewed by Youenn Fablet.
519
520         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
521         (TestWebKitAPI::TEST):
522             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
523
524 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
525
526         [CMake] Apple builds should use ICU_INCLUDE_DIRS
527         https://bugs.webkit.org/show_bug.cgi?id=196720
528
529         Reviewed by Konstantin Tokarev.
530
531         * TestWebKitAPI/PlatformMac.cmake:
532
533 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
534
535         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
536         https://bugs.webkit.org/show_bug.cgi?id=196694
537         <rdar://problem/48388734>
538
539         Rubber-stamped by Aakash Jain.
540
541         * Scripts/webkitpy/port/image_diff.py:
542         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
543         * Scripts/webkitpy/port/server_process.py:
544         (ServerProcess.has_available_stdout): Check if stdout has data in it.
545         (ServerProcess._wait_for_data_and_update_buffers_using_select):
546         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
547         * Scripts/webkitpy/port/server_process_mock.py:
548         (MockServerProcess.has_available_stdout):
549         * Scripts/webkitpy/port/server_process_unittest.py:
550         (TestServerProcess.serial_test_basic):
551
552 2019-04-09  Jer Noble  <jer.noble@apple.com>
553
554         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
555         https://bugs.webkit.org/show_bug.cgi?id=196097
556
557         Reviewed by Eric Carlson.
558
559         Drive-by bug fix: allow tests to play audio without a user gesture by default.
560
561         * DumpRenderTree/mac/DumpRenderTree.mm:
562         (resetWebPreferencesToConsistentValues):
563         * WebKitTestRunner/TestController.cpp:
564         (WTR::TestController::resetPreferencesToConsistentValues):
565
566 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
567
568         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
569         https://bugs.webkit.org/show_bug.cgi?id=196690
570
571         Reviewed by Michael Catanzaro.
572
573         * QueueStatusServer/config/queues.py:
574         * Scripts/webkitpy/common/config/ews.json:
575         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
576         (test_ews_name):
577
578 2019-04-09  Chris Dumez  <cdumez@apple.com>
579
580         Loads using loadHTMLString() cause flashing when process-swapping
581         https://bugs.webkit.org/show_bug.cgi?id=196714
582         <rdar://problem/49637354>
583
584         Reviewed by Antti Koivisto.
585
586         Add API test coverage.
587
588         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
589
590 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
591
592         Unreviewed. Fix ATK accessibility tests after r244059.
593
594         We are failing to load the injected bundle due to undefined symbol
595         AccessibilityUIElement::replaceTextInRange().
596
597         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
598         (WTR::AccessibilityUIElement::replaceTextInRange):
599
600 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
601
602         AX: Support API: accessibilityReplaceRange:withText
603         https://bugs.webkit.org/show_bug.cgi?id=196636
604
605         Unreviewed build fix for Windows port.
606
607         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
608         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
609
610 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
611
612         [CMake][WinCairo] Separate copied headers into different directories
613         https://bugs.webkit.org/show_bug.cgi?id=196655
614
615         Reviewed by Michael Catanzaro.
616
617         * DumpRenderTree/CMakeLists.txt:
618         * MiniBrowser/win/CMakeLists.txt:
619         * TestWebKitAPI/CMakeLists.txt:
620         * TestWebKitAPI/PlatformWin.cmake:
621
622 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
623
624         Log stack-trace for run-webkit-tests when interrupted
625         https://bugs.webkit.org/show_bug.cgi?id=176393
626         <rdar://problem/34262310>
627
628         Reviewed by Lucas Forschler.
629
630         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
631         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
632         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
633         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
634         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
635         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
636         (main): Set handlers to log stack trace on interruption.
637
638 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
639
640         AX: Support API: accessibilityReplaceRange:withText
641         https://bugs.webkit.org/show_bug.cgi?id=196636
642
643         Unreviewed build fix for Windows port.
644
645         * DumpRenderTree/AccessibilityUIElement.cpp:
646         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
647
648 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
649
650         [ews-build] Scripts using Buildbot API have CORS error
651         https://bugs.webkit.org/show_bug.cgi?id=196709
652
653         Reviewed by Alexey Proskuryakov.
654
655         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
656
657 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
658
659         AX: Support API: accessibilityReplaceRange:withText
660         https://bugs.webkit.org/show_bug.cgi?id=196636
661
662         Reviewed by Daniel Bates.
663
664         * DumpRenderTree/AccessibilityUIElement.cpp:
665         (replaceTextInRangeCallback):
666         (AccessibilityUIElement::replaceTextInRange):
667         (AccessibilityUIElement::getJSClass):
668         * DumpRenderTree/AccessibilityUIElement.h:
669         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
670         (AccessibilityUIElement::replaceTextInRange):
671         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
672         (AccessibilityUIElement::replaceTextInRange):
673         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
674         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
675         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
676         (WTR::AccessibilityUIElement::replaceTextInRange):
677         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
678         (WTR::AccessibilityUIElement::replaceTextInRange):
679
680 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
681
682         [iOS] Do not allow starting selection drags when selection views are not visible
683         https://bugs.webkit.org/show_bug.cgi?id=196686
684         <rdar://problem/49399192>
685
686         Reviewed by Tim Horton.
687
688         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
689         also add some new API tests to cover scenarios where the web view is not first responder.
690
691         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
692         (TestWebKitAPI::TEST):
693         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
694
695         Add a switch to optionally make the web view first responder when starting the simulated drag.
696
697         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
698         (-[DragAndDropSimulator initWithWebView:]):
699         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
700
701 2019-04-08  Justin Fan  <justin_fan@apple.com>
702
703         [Web GPU] Fix Web GPU experimental feature on iOS
704         https://bugs.webkit.org/show_bug.cgi?id=196632
705
706         Reviewed by Myles C. Maxfield.
707
708         Properly make Web GPU available on iOS 11+.
709
710         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
711
712 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
713
714         [ews-build] Do not upload archive when Compile Fails
715         https://bugs.webkit.org/show_bug.cgi?id=196674
716
717         Reviewed by Alexey Proskuryakov.
718
719         * BuildSlaveSupport/ews-build/factories.py:
720         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
721         * BuildSlaveSupport/ews-build/steps.py:
722         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
723         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
724         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
725
726 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
727
728         Enable DFG on MIPS
729         https://bugs.webkit.org/show_bug.cgi?id=196689
730
731         Reviewed by Žan Doberšek.
732
733         Since the bytecode change, we enabled the baseline JIT on mips in
734         r240432, but DFG is still missing. With this change, all tests are
735         passing on a ci20 board.
736
737         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
738
739 2019-04-08  Philippe Normand  <pnormand@igalia.com>
740
741         [Flatpak] Second run update-webkitwpe-flatpak fails
742         https://bugs.webkit.org/show_bug.cgi?id=192702
743
744         Reviewed by Carlos Garcia Campos.
745
746         * flatpak/flatpakutils.py:
747         (FlatpakObject.flatpak): Fix typo.
748         (FlatpakPackage.install): When installing, also update to the configured remote commit.
749         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
750
751 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
752
753         [GTK][WPE] outlook.live.com displays old-fashioned UI
754         https://bugs.webkit.org/show_bug.cgi?id=196642
755
756         Reviewed by Carlos Garcia Campos.
757
758         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
759         (TestWebKitAPI::TEST): New Mac platform quirk test.
760
761 2019-04-07  Commit Queue  <commit-queue@webkit.org>
762
763         Unreviewed, rolling out r243956.
764         https://bugs.webkit.org/show_bug.cgi?id=196688
765
766         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
767         by aakashjain on #webkit).
768
769         Reverted changeset:
770
771         "Clicking "Go Back" from a safe browsing warning from an
772         iframe should navigate the WKWebView back to the previous
773         page"
774         https://bugs.webkit.org/show_bug.cgi?id=196665
775         https://trac.webkit.org/changeset/243956
776
777 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
778
779         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
780         https://bugs.webkit.org/show_bug.cgi?id=196669
781
782         Reviewed by Geoffrey Garen.
783
784         Added three new unit tests for WeakHashSet.
785
786         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
787         (WTF_WeakPtr.WeakHashSetConstObjects):
788         (WTF_WeakPtr.WeakHashSetComputesEmpty):
789         (WTF_WeakPtr.WeakHashSetComputeSize):
790
791 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
792
793         Hide next and previous form control buttons when WKWebView is editable
794         https://bugs.webkit.org/show_bug.cgi?id=196672
795         <rdar://problem/35625321>
796
797         Reviewed by Tim Horton.
798
799         Add a new API test.
800
801         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
802         (-[TestWKWebView lastTrailingBarButtonGroup]):
803         (TestWebKitAPI::TEST):
804         * TestWebKitAPI/ios/UIKitSPI.h:
805
806 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
807
808         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
809         https://bugs.webkit.org/show_bug.cgi?id=196077
810         <rdar://problem/49108202>
811
812         Reviewed by Chris Dumez.
813
814         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
815         on new web view.
816
817         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
818
819 2019-04-05  Saam Barati  <sbarati@apple.com>
820
821         Make compare-results understand MotionMark
822         https://bugs.webkit.org/show_bug.cgi?id=196666
823
824         Reviewed by Yusuke Suzuki.
825
826         * Scripts/compare-results:
827         (PLT5Results):
828         (detectMotionMark):
829         (detectMotionMark1_1):
830         (motionMarkResults):
831         (motionMark1_1Results):
832         (detectBenchmark):
833         (biggerIsBetter):
834         (main):
835
836 2019-04-05  Alex Christensen  <achristensen@webkit.org>
837
838         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
839         https://bugs.webkit.org/show_bug.cgi?id=196665
840         <rdar://45115669>
841
842         Reviewed by Geoff Garen.
843
844         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
845         (goBack):
846         (+[SimpleLookupContext sharedLookupContext]):
847         (-[SimpleLookupContext lookUpURL:completionHandler:]):
848         (TEST):
849         (+[Simple3LookupContext sharedLookupContext]): Deleted.
850         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
851
852 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
853
854         [ews-build] Add configuration and architecture for windows builders
855         https://bugs.webkit.org/show_bug.cgi?id=196660
856
857         Reviewed by Lucas Forschler.
858
859         * BuildSlaveSupport/ews-build/config.json:
860
861 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
862
863         webkitpy: Don't run subsequent rounds if interrupted
864         https://bugs.webkit.org/show_bug.cgi?id=196646
865
866         Reviewed by Aakash Jain.
867
868         * Scripts/webkitpy/layout_tests/controllers/manager.py:
869         (Manager.run): Bail out if interrupted.
870
871 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
872
873         Test sessionStorage in PSON private browsing mode
874         https://bugs.webkit.org/show_bug.cgi?id=196561
875
876         Reviewed by Alex Christensen.
877
878         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
879
880 2019-04-05  Commit Queue  <commit-queue@webkit.org>
881
882         Unreviewed, rolling out r243833.
883         https://bugs.webkit.org/show_bug.cgi?id=196645
884
885         This change breaks build of WPE and GTK ports (Requested by
886         annulen on #webkit).
887
888         Reverted changeset:
889
890         "[CMake][WTF] Mirror XCode header directories"
891         https://bugs.webkit.org/show_bug.cgi?id=191662
892         https://trac.webkit.org/changeset/243833
893
894 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
895
896         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
897         https://bugs.webkit.org/show_bug.cgi?id=196635
898
899         Reviewed by Antti Koivisto.
900         
901         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
902         for a test to enable async frame scrolling via:
903             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
904         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
905         
906         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
907
908         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
909         (WTR::InjectedBundle::beginTesting):
910         * WebKitTestRunner/TestController.cpp:
911         (WTR::TestController::resetPreferencesToConsistentValues):
912
913 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
914
915         Use a correct LC_RPATH when building with ASan
916         https://bugs.webkit.org/show_bug.cgi?id=196576
917
918         Reviewed by David Kilzer.
919
920         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
921         so that ../Frameworks is checked. This is simpler and more reliable than updating
922         each SPC service xcconfig.
923
924 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
925
926         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
927         https://bugs.webkit.org/show_bug.cgi?id=196629
928
929         Reviewed by Lucas Forschler.
930
931         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
932
933 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
934
935         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
936         https://bugs.webkit.org/show_bug.cgi?id=196618
937
938         Reviewed by Lucas Forschler.
939
940         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
941         (StatusBubble): Added QUEUE_TRIGGERS.
942         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
943         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
944         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
945         its parent(builder).
946
947 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
948
949         [ews-app] Status-bubble steps are sometimes displayed in reverse order
950         https://bugs.webkit.org/show_bug.cgi?id=196625
951
952         Reviewed by Lucas Forschler.
953
954         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
955         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
956
957 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
958
959         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
960         https://bugs.webkit.org/show_bug.cgi?id=196630
961
962         Reviewed by Wenson Hsieh.
963
964         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
965
966 2019-04-04  Youenn Fablet  <youenn@apple.com>
967
968         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
969         https://bugs.webkit.org/show_bug.cgi?id=196543
970
971         Reviewed by Alex Christensen.
972
973         * WebKitTestRunner/TestController.cpp:
974         (WTR::TestController::generatePageConfiguration):
975
976 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
977
978         [ews-app] Status bubble should not display skipped buildbot steps
979         https://bugs.webkit.org/show_bug.cgi?id=196584
980
981         Reviewed by Lucas Forschler.
982
983         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
984
985 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
986
987         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
988         https://bugs.webkit.org/show_bug.cgi?id=196620
989
990         Reviewed by Lucas Forschler.
991
992         * BuildSlaveSupport/ews-app/ews/config.py:
993
994 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
995
996         [Win] DumpRenderTreeWatchDog.py is not checked into source
997         https://bugs.webkit.org/show_bug.cgi?id=196567
998         <rdar://problem/49525901>
999
1000         Reviewed by Lucas Forschler.
1001
1002         This script is used on Win EWS bots to terminate hanging DRT processes.
1003
1004         * EWSTools/dumprendertreewatchdog.py: Added.
1005
1006 2019-04-04  Chris Dumez  <cdumez@apple.com>
1007
1008         Unreviewed, roll out r243858 which made tests time out.
1009
1010         Disable new API tests on Windows instead.
1011
1012         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1013         (TestWebKitAPI::TEST):
1014
1015 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1016
1017         [ATK] Cleanup WebPageAccessibilityObjectAtk
1018         https://bugs.webkit.org/show_bug.cgi?id=196537
1019
1020         Reviewed by Michael Catanzaro.
1021
1022         Also consider files under atk directories as exceptions for GObject conventions.
1023
1024         * Scripts/webkitpy/style/checkers/cpp.py:
1025         (check_identifier_name_in_declaration):
1026
1027 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1028
1029         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1030         https://bugs.webkit.org/show_bug.cgi?id=196588
1031         <rdar://problem/49365787>
1032
1033         Unreviewed build fix for Windows port.
1034
1035         error C3861: 'kill': identifier not found
1036
1037         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1038         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1039
1040 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1041
1042         [ews-build] Cancel build and similar operations should have authentication
1043         https://bugs.webkit.org/show_bug.cgi?id=196520
1044
1045         Reviewed by Dewei Zhu.
1046
1047         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1048         environment variables.
1049
1050 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1051
1052         [ews-build] Do not trigger queues which are not in production yet
1053         https://bugs.webkit.org/show_bug.cgi?id=196581
1054
1055         Reviewed by Dewei Zhu.
1056
1057         * BuildSlaveSupport/ews-build/config.json:
1058
1059 2019-04-03  Chris Dumez  <cdumez@apple.com>
1060
1061         Unreviewed, fix typo in the name of API test added in r243848.
1062
1063         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1064         (TestWebKitAPI::TEST):
1065
1066 2019-04-03  Chris Dumez  <cdumez@apple.com>
1067
1068         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1069         https://bugs.webkit.org/show_bug.cgi?id=196588
1070         <rdar://problem/49365787>
1071
1072         Reviewed by Ryosuke Niwa.
1073
1074         Add API test coverage.
1075
1076         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1077         (TestWebKitAPI::nullJavaScriptCallback):
1078         (TestWebKitAPI::didCrashCheckFrames):
1079         (TestWebKitAPI::TEST):
1080
1081 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1082
1083         run-webkit-tests: Upload test results (new results database)
1084         https://bugs.webkit.org/show_bug.cgi?id=196577
1085         <rdar://problem/34841155>
1086
1087         Reviewed by Lucas Forschler.
1088
1089         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1090         (Manager.run): Upload results after each device shard, since the configuration will be
1091         different for each device.
1092         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1093         uploaded to a results database.
1094         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1095         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1096
1097 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1098
1099         -apple-trailing-word is needed for browser detection
1100         https://bugs.webkit.org/show_bug.cgi?id=196575
1101
1102         Unreviewed.
1103
1104         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1105
1106 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1107
1108         [CMake][WTF] Mirror XCode header directories
1109         https://bugs.webkit.org/show_bug.cgi?id=191662
1110
1111         Reviewed by Konstantin Tokarev.
1112
1113         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1114         builds.
1115
1116         * CMakeLists.txt:
1117         * DumpRenderTree/CMakeLists.txt:
1118         * DumpRenderTree/PlatformWin.cmake:
1119         * MiniBrowser/win/CMakeLists.txt:
1120         * TestWebKitAPI/CMakeLists.txt:
1121         * TestWebKitAPI/PlatformWin.cmake:
1122         * WebKitTestRunner/PlatformGTK.cmake:
1123         * WebKitTestRunner/PlatformWin.cmake:
1124
1125 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1126
1127         [ews-app] Status bubble should not display certain infrastructure status messages
1128         https://bugs.webkit.org/show_bug.cgi?id=196550
1129
1130         Reviewed by Lucas Forschler.
1131
1132         Do not display the steps which are un-needed for end-user. This information is still avaiable
1133         if the user click on the bubble and look at the Buildbot build.
1134         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1135         (StatusBubble._steps_messages):
1136         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1137
1138 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1139
1140         [ews-build] Use https for sending data to ews-app
1141         https://bugs.webkit.org/show_bug.cgi?id=196492
1142
1143         Reviewed by Lucas Forschler.
1144
1145         * BuildSlaveSupport/ews-build/events.py:
1146
1147 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1148
1149         Remove support for -apple-trailing-word
1150         https://bugs.webkit.org/show_bug.cgi?id=196525
1151
1152         Reviewed by Zalan Bujtas.
1153
1154         This CSS property is nonstandard and not used.
1155
1156         * Scripts/webkitperl/FeatureList.pm:
1157         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1158
1159 2019-04-03  Youenn Fablet  <youenn@apple.com>
1160
1161         Add a test for DOMCache on multiple browsing in case of private browsing
1162         https://bugs.webkit.org/show_bug.cgi?id=196524
1163
1164         Reviewed by Alex Christensen.
1165
1166         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1167         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1168
1169 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1170
1171         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1172         https://bugs.webkit.org/show_bug.cgi?id=196540
1173
1174         Reviewed by Aakash Jain.
1175
1176         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1177
1178 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1179
1180         Add plumbing for a compatibility mode preference in WebKit
1181         https://bugs.webkit.org/show_bug.cgi?id=196005
1182
1183         Reviewed by Tim Horton.
1184
1185         Add new API tests.
1186
1187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1188         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1189
1190 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1191
1192         [WPE][GTK] Update libsrtp dependency package for Debian
1193         https://bugs.webkit.org/show_bug.cgi?id=196528
1194
1195         Reviewed by Frédéric Wang.
1196
1197         * gtk/install-dependencies:
1198         * wpe/install-dependencies:
1199
1200 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1201
1202         [WK2] Add support for Window's beforeprint / afterprint events
1203         https://bugs.webkit.org/show_bug.cgi?id=196478
1204         <rdar://problem/49535124>
1205
1206         Unreviewed build fix for MSVC.
1207
1208         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1209
1210         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1211
1212         * WebKitTestRunner/TestController.cpp:
1213         (WTR::printFrame): Use int and float literals.
1214
1215 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1216
1217         [ews-build] Reassign bots to queues
1218
1219         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1220
1221 2019-04-02  Chris Dumez  <cdumez@apple.com>
1222
1223         [WK2] Add support for Window's beforeprint / afterprint events
1224         https://bugs.webkit.org/show_bug.cgi?id=196478
1225
1226         Reviewed by Alex Christensen.
1227
1228         Add minimal implementation for printFrame in WebKitTestRunner.
1229
1230         * WebKitTestRunner/TestController.cpp:
1231         (WTR::printFrame):
1232         (WTR::TestController::createOtherPage):
1233         (WTR::TestController::createWebViewWithOptions):
1234
1235 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1236
1237         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1238         https://bugs.webkit.org/show_bug.cgi?id=196491
1239
1240         Reviewed by Lucas Forschler.
1241
1242         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1243
1244 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1245
1246         [ews-build] Configure buildbot try credentials in environment variables
1247         https://bugs.webkit.org/show_bug.cgi?id=196501
1248
1249         Reviewed by Lucas Forschler.
1250
1251         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1252         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1253         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1254
1255 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1256
1257         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1258         https://bugs.webkit.org/show_bug.cgi?id=196496
1259         <rdar://problem/49521634>
1260
1261         Reviewed by Chris Dumez.
1262
1263         Add new API tests (see WebKit ChangeLog for more detail).
1264
1265         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1266         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1267         (TEST):
1268
1269 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1270
1271         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1272         <https://webkit.org/b/196499>
1273
1274         Reviewed by Alexey Proskuryakov.
1275
1276         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1277         ENABLE_ADDRESS_SANITIZER.
1278
1279 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1280
1281         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1282         https://bugs.webkit.org/show_bug.cgi?id=182757
1283
1284         Reviewed by Don Olmstead.
1285
1286         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1287         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1288
1289 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1290
1291         run-api-tests: Upload test results
1292         https://bugs.webkit.org/show_bug.cgi?id=196323
1293         <rdar://problem/49356714>
1294
1295         Reviewed by Lucas Forschler.
1296
1297         * Scripts/webkitpy/api_tests/manager.py:
1298         (Manager):
1299         (Manager.run): Upload results to a results database.
1300         * Scripts/webkitpy/api_tests/run_api_tests.py:
1301         (parse_args): Add upload arguments.
1302         * Scripts/webkitpy/port/base.py:
1303         (Port):
1304         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1305         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1306         with commits from any other associated repositories.
1307         * Scripts/webkitpy/port/device.py:
1308         (Device):
1309         (Device.build_version): Access build_versoin of underlying platform device.
1310         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1311         (IOSSimulatorTest):
1312         (IOSSimulatorTest.test_configuration_for_upload):
1313         * Scripts/webkitpy/port/device_port.py:
1314         (DevicePort):
1315         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1316         the same as the machine uploading results.
1317         * Scripts/webkitpy/port/mac.py:
1318         (MacPort):
1319         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1320         * Scripts/webkitpy/port/mac_unittest.py:
1321         (MacTest):
1322         (MacTest.test_configuration_for_upload):
1323         * Scripts/webkitpy/xcode/simulated_device.py:
1324         (SimulatedDeviceManager._create_device_with_runtime):
1325         (SimulatedDevice.__init__): Create simulated device with a build_version.
1326         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1327         (test_existing_simulator):
1328
1329 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1330
1331         Remove extra newline characters (Follow-up fix to r243707)
1332
1333         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1334
1335 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1336
1337         [ews-app] Use API_KEY to accept results data
1338         https://bugs.webkit.org/show_bug.cgi?id=196461
1339
1340         Reviewed by Dewei Zhu.
1341
1342         * BuildSlaveSupport/ews-app/ews/views/results.py:
1343         (Results.post): Validate EWS_API_KEY before accepting any data.
1344         * BuildSlaveSupport/ews-build/events.py:
1345         (Events.sendData): Send EWS_API_KEY if available along with event data.
1346
1347 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1348
1349         Unable to copy and paste a PDF from Notes into Mail compose body
1350         https://bugs.webkit.org/show_bug.cgi?id=196442
1351         <rdar://problem/48573098>
1352
1353         Reviewed by Tim Horton.
1354
1355         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1356         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1357         to be specified on the item providers.
1358
1359         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1360         (TestWebKitAPI::mapItemForTesting):
1361         (TestWebKitAPI::contactItemForTesting):
1362
1363 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1364
1365         Make UIWKDocumentContext rects per-character instead of per-word
1366         https://bugs.webkit.org/show_bug.cgi?id=196459
1367
1368         Reviewed by Wenson Hsieh.
1369
1370         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1371         (TEST):
1372         Adjust test results due to switching to per-character rects.
1373
1374 2019-04-01  Chris Dumez  <cdumez@apple.com>
1375
1376         UIProcess crash when a prewarmed process is terminated
1377         https://bugs.webkit.org/show_bug.cgi?id=196451
1378         <rdar://problem/49245471>
1379
1380         Reviewed by Geoffrey Garen.
1381
1382         Add API test coverage.
1383
1384         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1385         (TEST):
1386
1387 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1388
1389         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1390         https://bugs.webkit.org/show_bug.cgi?id=196449
1391
1392         Reviewed by Lucas Forschler.
1393
1394         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1395         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1396         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1397         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1398
1399 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1400
1401         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1402         https://bugs.webkit.org/show_bug.cgi?id=196444
1403
1404         Reviewed by Lucas Forschler.
1405
1406         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1407
1408 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1409
1410         Add SPI to canonicalize NSURLs with WTF::URL
1411         https://bugs.webkit.org/show_bug.cgi?id=196415
1412         <rdar://problem/44980271>
1413
1414         Reviewed by Darin Adler.
1415
1416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1417         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1418         (TestWebKitAPI::TEST):
1419
1420 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1421
1422         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1423         https://bugs.webkit.org/show_bug.cgi?id=196441
1424
1425         Reviewed by Carlos Garcia Campos.
1426
1427         Don't cache the wpe_view_backend object that might not exist yet at the
1428         time of EventSenderProxy constructor invocation, but instead retrieve
1429         that object whenever it's required for event dispatching. This should
1430         avoid crashes in this constructor now that it's invoked before any
1431         PlatformWindow has been set up (as changed in r243496).
1432
1433         * WebKitTestRunner/EventSenderProxy.h:
1434         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1435         (WTR::viewBackend):
1436         (WTR::EventSenderProxy::EventSenderProxy):
1437         (WTR::EventSenderProxy::mouseDown):
1438         (WTR::EventSenderProxy::mouseUp):
1439         (WTR::EventSenderProxy::mouseMoveTo):
1440         (WTR::EventSenderProxy::mouseScrollBy):
1441         (WTR::EventSenderProxy::keyDown):
1442         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1443
1444 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1445
1446         [Win][WebKit] MiniBrowser should support high DPI display
1447         https://bugs.webkit.org/show_bug.cgi?id=196391
1448
1449         Reviewed by Alex Christensen.
1450
1451         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1452         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1453         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1454         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1455
1456 2019-03-31  Sam Weinig  <weinig@apple.com>
1457
1458         Remove more i386 specific configurations
1459         https://bugs.webkit.org/show_bug.cgi?id=196430
1460
1461         Reviewed by Alexey Proskuryakov.
1462
1463         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1464         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1465
1466 2019-03-31  Andy Estes  <aestes@apple.com>
1467
1468         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1469         https://bugs.webkit.org/show_bug.cgi?id=196433
1470         <rdar://problem/49293305>
1471
1472         Reviewed by Tim Horton.
1473
1474         Enhanced API test coverage to include all navigation response policy decisions in both
1475         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1476
1477         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1478         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1479         (TestWebKitAPI::TEST):
1480         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1481         (readFile):
1482         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1483         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1484         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1485         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1486         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1487         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1488         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1489         (-[QuickLookDelegate _downloadDidStart:]):
1490         (-[QuickLookDelegate _download:didReceiveResponse:]):
1491         (-[QuickLookDelegate _download:didReceiveData:]):
1492         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1493         (-[QuickLookDelegate _downloadDidFinish:]):
1494         (-[QuickLookDelegate _download:didFailWithError:]):
1495         (-[QuickLookDelegate _downloadDidCancel:]):
1496         (-[QuickLookDelegate verifyDownload]):
1497         (runTest):
1498         (runTestDecideBeforeLoading):
1499         (runTestDecideAfterLoading):
1500         (TEST):
1501         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1502         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1503         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1504         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1505         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1506         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1507         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1508         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1509         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1510         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1511         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1512         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1513         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1514         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1515
1516 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1517
1518         [CMake] add testdfg as target with build-jsc
1519         https://bugs.webkit.org/show_bug.cgi?id=196393
1520
1521         Reviewed by Saam Barati.
1522
1523         Added testdfg as one of the targets to build when
1524         using CMake.
1525
1526         * Scripts/build-jsc:
1527
1528 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1529
1530         Delete WebMetal implementation in favor of WebGPU
1531         https://bugs.webkit.org/show_bug.cgi?id=195418
1532
1533         Reviewed by Dean Jackson.
1534
1535         * DumpRenderTree/mac/DumpRenderTree.mm:
1536         (enableExperimentalFeatures):
1537         (resetWebPreferencesToConsistentValues):
1538         * Scripts/webkitperl/FeatureList.pm:
1539         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1541         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1542         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1543         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1544         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1545         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1546         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1547         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1548         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1549         (WTR::InjectedBundle::beginTesting):
1550         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1551         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1552         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1553
1554 2019-03-29  Chris Dumez  <cdumez@apple.com>
1555
1556         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1557         https://bugs.webkit.org/show_bug.cgi?id=196405
1558         <rdar://problem/49428130>
1559
1560         Reviewed by Wenson Hsieh.
1561
1562         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1563         the popover presentation methods to be no-ops. Use this in the new test added in
1564         r243523 so that we do not swizzle those methods for all tests. This is needed because
1565         those WatchOS tests rely on the popover getting presented and interactive.
1566
1567         * WebKitTestRunner/TestController.cpp:
1568         (WTR::updateTestOptionsFromTestHeader):
1569         * WebKitTestRunner/TestController.h:
1570         * WebKitTestRunner/TestOptions.h:
1571         (WTR::TestOptions::hasSameInitializationOptions const):
1572         * WebKitTestRunner/ios/TestControllerIOS.mm:
1573         (WTR::TestController::platformInitialize):
1574         (WTR::TestController::platformResetStateToConsistentValues):
1575
1576 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1577
1578         [Curl] Add Server Trust Evaluation Support.
1579         https://bugs.webkit.org/show_bug.cgi?id=191646
1580
1581         Reviewed by Fujii Hironori.
1582
1583         Implemented MiniBrowser UI for asking if user trusts the server.
1584
1585         * MiniBrowser/win/Common.cpp:
1586         (askServerTrustEvaluation):
1587         (replaceString):
1588         * MiniBrowser/win/Common.h:
1589         * MiniBrowser/win/MiniBrowserLib.rc:
1590         * MiniBrowser/win/MiniBrowserLibResource.h:
1591         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1592         (createPEMString):
1593         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1594         (WebKitBrowserWindow::canTrustServerCertificate):
1595         * MiniBrowser/win/WebKitBrowserWindow.h:
1596
1597 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1598
1599         Implement ResizeObserver.
1600         https://bugs.webkit.org/show_bug.cgi?id=157743
1601
1602         Reviewed by Simon Fraser.
1603
1604         Support resizeObserverEnabled webPreferences.
1605
1606         * DumpRenderTree/TestOptions.cpp:
1607         (TestOptions::TestOptions):
1608         * DumpRenderTree/TestOptions.h:
1609         * DumpRenderTree/mac/DumpRenderTree.mm:
1610         (setWebPreferencesForTestOptions):
1611         * DumpRenderTree/win/DumpRenderTree.cpp:
1612         (enableExperimentalFeatures):
1613         * Scripts/webkitperl/FeatureList.pm:
1614         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1615
1616 2019-03-28  John Wilander  <wilander@apple.com>
1617
1618         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1619         https://bugs.webkit.org/show_bug.cgi?id=196281
1620         <rdar://problem/48938748>
1621
1622         Reviewed by Alex Christensen.
1623
1624         This patch adds the function isStatisticsHasLocalStorage() to the
1625         TestRunner. With it, the page can query the WebsiteDataStore in the
1626         UI process to make sure that it sees LocalStorage.
1627
1628         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1629         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1630         (WTR::TestRunner::isStatisticsHasLocalStorage):
1631         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1632         * WebKitTestRunner/TestController.cpp:
1633         (WTR::TestController::isStatisticsHasLocalStorage):
1634         * WebKitTestRunner/TestController.h:
1635         * WebKitTestRunner/TestInvocation.cpp:
1636         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1637
1638 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1639
1640         API::Data::createWithoutCopying should do a null check before calling CFRelease
1641         https://bugs.webkit.org/show_bug.cgi?id=196276
1642         <rdar://problem/48059859>
1643
1644         Reviewed by Alex Christensen.
1645
1646         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1647
1648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1649         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1650         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1651         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1652         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1653         (TestWebKitAPI::TEST):
1654
1655 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1656
1657         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1658         https://bugs.webkit.org/show_bug.cgi?id=186276
1659
1660         Reviewed by Carlos Garcia Campos.
1661
1662         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1663         (webViewLoadChanged):
1664         (testWebResourceGetDataError):
1665         (testWebResourceGetDataEmpty):
1666         (beforeAll):
1667         (webViewloadChanged): Deleted.
1668
1669 2019-03-27  Andy Estes  <aestes@apple.com>
1670
1671         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1672         https://bugs.webkit.org/show_bug.cgi?id=196317
1673
1674         Reviewed by Dan Bernstein.
1675
1676         package-root copies built products into a staging directory using ditto(1), which does not
1677         follow symbolic links as it traverses a directory. Now that the files in
1678         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1679         itself, these become broken links when ditto'd into the staging directory.
1680
1681         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1682
1683         * Scripts/package-root:
1684
1685 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1686
1687         [ews-app] Update display text of Submit for ews analysis
1688         https://bugs.webkit.org/show_bug.cgi?id=196309
1689
1690         Reviewed by Dewei Zhu.
1691
1692         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1693
1694 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1695
1696         run-webkit-tests should check for leaks in WebKit processes
1697         <https://webkit.org/b/193772>
1698         <rdar://problem/46526680>
1699
1700         Reviewed by Ryosuke Niwa.
1701
1702         This works by doing the following:
1703         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1704           The list of child processes are returned one per line:
1705           process.name: pid
1706         - Run the "#LIST CHILD PROCESSES" command just before the
1707           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1708           processes on the ServerProcess object.
1709         - When the `--leaks` switch is handled, run check_for_leaks() on
1710           each child process after the main test harness.
1711
1712         * DumpRenderTree/mac/DumpRenderTree.mm:
1713         (handleControlCommand):
1714         - Use strncmp() instead of strcmp().
1715         - Add support for handling "#LIST CHILD PROCESSES" command.
1716
1717         * Scripts/webkitpy/port/base.py:
1718         (Port.check_for_leaks):
1719         * Scripts/webkitpy/port/darwin.py:
1720         (DarwinPort.check_for_leaks):
1721         - Rename redundant 'process_pid' argument to 'process_id'.
1722
1723         * Scripts/webkitpy/port/driver.py:
1724         (Driver.do_post_tests_work):
1725         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1726           longer the only command this sends to WebKitTestRunner.
1727         - If the `--leaks` switch is present, send the
1728           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1729           result using Port.set_webkit_processes().
1730         (Driver._parse_child_processes_output):
1731         - Add helper method to parse list of child process names and
1732           process IDs returned from WebKitTestRunner.
1733
1734         * Scripts/webkitpy/port/ios_device.py:
1735         (IOSDevicePort.check_for_leaks):
1736         - Rename redundant 'process_pid' argument to 'process_id'.
1737
1738         * Scripts/webkitpy/port/leakdetector.py:
1739         (LeakDetector._parse_leaks_output):
1740         - Return early if there is no leaks_output.
1741         (LeakDetector.check_for_leaks):
1742         - Rename redundant 'process_pid' argument to 'process_id'.
1743
1744         * Scripts/webkitpy/port/server_process.py:
1745         (ServerProcess.__init__):
1746         (ServerProcess.child_processes):
1747         (ServerProcess.set_child_processes):
1748         - Add instance variable to Port to store list of child process
1749           names and process IDs returned from WebKitTestRunner.
1750         (ServerProcess._start):
1751         - Clear self._child_processes.
1752         (ServerProcess.stop):
1753         - If self._child_processes is set, call
1754           self._port.check_for_leaks() for each child process.
1755
1756         * Scripts/webkitpy/port/server_process_unittest.py:
1757         (TrivialMockPort.check_for_leaks):
1758         - Rename redundant 'process_pid' argument to 'process_id'.
1759
1760         * Scripts/webkitpy/port/simulator_process.py:
1761         (SimulatorProcess.stop):
1762         - If self._child_processes is set, call
1763           self._port.check_for_leaks() for each child process.
1764
1765         * Scripts/webkitpy/port/watch_device.py:
1766         (WatchDevicePort.check_for_leaks):
1767         - Rename redundant 'process_pid' argument to 'process_id'.
1768
1769         * WebKitTestRunner/TestController.cpp:
1770         (WTR::TestController::dumpResponse):
1771         - Extract method from findAndDumpWorldLeaks() so that it may be
1772           reused by findAndDumpWebKitProcessIdentifiers().
1773         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1774         - Add method to output process name and process ID of both the
1775           WebContent and Networking processes.
1776         (WTR::TestController::findAndDumpWorldLeaks):
1777         - Fix missing newline in output when there were no abandoned
1778           documents.
1779         - Call dumpResponse() for extracted code.
1780         (WTR::TestController::handleControlCommand):
1781         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1782         - Use strncmp() instead of strcmp().
1783         - Call findAndDumpWebKitProcessIdentifiers() when
1784           "#LIST CHILD PROCESSES" command is sent.
1785         * WebKitTestRunner/TestController.h:
1786         (WTR::TestController::dumpResponse):
1787         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1788         - Declare methods.
1789
1790 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1791
1792         Unreviewed. Add GLib API test cases after r243434.
1793
1794         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1795         (testWebViewActiveURI):
1796         (serverCallback):
1797         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1798         (sendRequestCallback):
1799
1800 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1801
1802         Geolocation request not complete when watch request was started in a different web process
1803         https://bugs.webkit.org/show_bug.cgi?id=195996
1804
1805         Reviewed by Alex Christensen.
1806
1807         Add a test case.
1808
1809         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1810         (TestWebKitAPI::runJavaScriptAlert):
1811         (TestWebKitAPI::TEST):
1812
1813 2019-03-26  Keith Rollin  <krollin@apple.com>
1814
1815         Update the way generate-xcfilelists returns strings from functions
1816         https://bugs.webkit.org/show_bug.cgi?id=195975
1817         <rdar://problem/49040807>
1818
1819         Reviewed by Dean Jackson.
1820
1821         There are places where generate-xcfilelists executes assignments with
1822         statements like:
1823
1824             FOO=$(some_function)
1825
1826         where "some_function" return a string by echoing it. E.g.
1827
1828             some_function()
1829             {
1830                 echo "Hello, World"
1831             }
1832
1833         This is a common idiom, but it has a problem if "some_function" needs
1834         to call "exit" in an attempt to halt the entire script right then and
1835         there. Since "some_function" is called inside of $(), it's being
1836         executed in a sub-shell. Calling exit in that sub-shell simply exits
1837         that shell; it doesn't not exit the outer shell in which the main part
1838         of the script is still running. As such, the main script keeps
1839         executing when the intent was for the script to halt.
1840
1841         The solution to this is to use a different idiom for returning
1842         strings. The one we now is to pass in the name of the variable to
1843         receive the string result:
1844
1845             some_function()
1846             {
1847                 variable_name=$1
1848                 eval $variable_name ="Hello, World"
1849             }
1850
1851         The call site now looks like
1852
1853             some_function FOO
1854
1855         Because there's no invocation of a sub-shell, some_function can now
1856         call "exit" if it wants to, and the entire script will exit at that
1857         point.
1858
1859         * Scripts/generate-xcfilelists:
1860
1861 2019-03-26  Chris Dumez  <cdumez@apple.com>
1862
1863         Add basic layout test coverage for File Picker on iOS
1864         https://bugs.webkit.org/show_bug.cgi?id=196265
1865
1866         Reviewed by Wenson Hsieh.
1867
1868         Add layout test infrastructure to test the file picker on iOS.
1869
1870         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1871         (WTR::UIScriptController::dismissFilePicker):
1872         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1873         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1874         (WTR::UIScriptController::dismissFilePicker):
1875         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1876         * WebKitTestRunner/TestController.cpp:
1877         (WTR::TestController::createWebViewWithOptions):
1878         (WTR::updateTestOptionsFromTestHeader):
1879         * WebKitTestRunner/TestOptions.h:
1880         (WTR::TestOptions::hasSameInitializationOptions const):
1881         * WebKitTestRunner/ios/TestControllerIOS.mm:
1882         (overridePresentViewController):
1883         (WTR::TestController::platformInitialize):
1884         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1885         (WTR::UIScriptController::dismissFilePicker):
1886
1887 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1888
1889         Implement async paste method on UIWKInteractionViewProtocol
1890         https://bugs.webkit.org/show_bug.cgi?id=196267
1891         <rdar://problem/49236346>
1892
1893         Reviewed by Tim Horton.
1894
1895         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1896         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1897         are now a part of all iOS 12 internal SDKs.
1898
1899         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1900
1901         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1902         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1903
1904         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1905         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1906         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1907         * TestWebKitAPI/ios/UIKitSPI.h:
1908
1909 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1910
1911         [ews-build] Use PostgreSQL for ews.webkit.org database
1912         https://bugs.webkit.org/show_bug.cgi?id=196270
1913
1914         Reviewed by Lucas Forschler.
1915
1916         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1917
1918 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1919
1920         [ews] Reset simctl states on reboot
1921         https://bugs.webkit.org/show_bug.cgi?id=196260
1922
1923         Rubber-stamped by Aakash Jain.
1924
1925         * EWSTools/start-queue-mac.sh:
1926
1927 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1928
1929         [ews-build] Use PostgreSQL for ews-build database
1930         https://bugs.webkit.org/show_bug.cgi?id=196229
1931
1932         Reviewed by Lucas Forschler.
1933
1934         * BuildSlaveSupport/ews-build/master.cfg:
1935
1936 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1937
1938         [ews-build] Get master_hostname dynamically in master.cfg
1939         https://bugs.webkit.org/show_bug.cgi?id=196255
1940
1941         Reviewed by Lucas Forschler.
1942
1943         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1944         send events data in test mode.
1945
1946 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1947
1948         [ews-app] Set db_constraint to False for Foreign Keys
1949         https://bugs.webkit.org/show_bug.cgi?id=196252
1950
1951         Reviewed by Lucas Forschler.
1952
1953         * BuildSlaveSupport/ews-app/ews/models/build.py:
1954         * BuildSlaveSupport/ews-app/ews/models/step.py:
1955
1956 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1957
1958         [ews-build] is_test_mode_enabled should default to True
1959         https://bugs.webkit.org/show_bug.cgi?id=196248
1960
1961         Reviewed by Lucas Forschler.
1962
1963         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1964
1965 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1966
1967         [ews-app] Add webkitperl to ENABLED_QUEUES
1968         https://bugs.webkit.org/show_bug.cgi?id=196253
1969
1970         Reviewed by Lucas Forschler.
1971
1972         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1973
1974 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1975
1976         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1977         https://bugs.webkit.org/show_bug.cgi?id=196211
1978         rdar://problem/49110552
1979
1980         Reviewed by Tim Horton.
1981
1982         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1983         Make sure that EventSenderProxy always exists when running tests. We used to create
1984         it when resetting before the first test, which is a bit too late.
1985
1986         * WebKitTestRunner/TestController.h:
1987         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1988         (WTR::TestController::platformCreateWebView):
1989         (WTR::TestController::platformCreateOtherPage):
1990         (WTR::TestController::finishCreatingPlatformWebView):
1991         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1992         (WTR::PlatformWebView::PlatformWebView):
1993         Moved some code that made NSWindow use NSEvent during web view creation. We may
1994         need to move more if some other case us found, but this is enough for now.
1995
1996 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1997
1998         Unreviewed. Fix typo in GLib geolocation API after r243285.
1999
2000         gelocation -> geolocation.
2001
2002         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2003         (testGeolocationManagerWatchPosition):
2004
2005 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2006
2007         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2008         https://bugs.webkit.org/show_bug.cgi?id=196213
2009
2010         Reviewed by Geoff Garen.
2011
2012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2013         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2014         (credentialWithIdentityAndKeychainPath):
2015         (-[ChallengeDelegate webView:didFinishNavigation:]):
2016         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2017         (TestWebKitAPI::TEST):
2018
2019 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2020
2021         Expected shouldn't assume its contained types are copyable
2022         https://bugs.webkit.org/show_bug.cgi?id=195986
2023
2024         Reviewed by JF Bastien.
2025
2026         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2027         (TestWebKitAPI::NonCopyable::operator== const):
2028         (TestWebKitAPI::NonCopyable::operator!= const):
2029         (TestWebKitAPI::TEST):
2030
2031 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2032
2033         Remove some now-unnecessary dynamic class lookup
2034         https://bugs.webkit.org/show_bug.cgi?id=196237
2035
2036         Reviewed by Simon Fraser.
2037
2038         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2039         (makeRequest):
2040         (TEST):
2041
2042 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2043
2044         Unreviewed, rolling out r243450.
2045
2046         AppleWin and WinCairo port builds get broken.
2047
2048         Reverted changeset:
2049
2050         "Add test for fix of #196095"
2051         https://bugs.webkit.org/show_bug.cgi?id=196097
2052         https://trac.webkit.org/changeset/243450
2053
2054 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2055
2056         Unreviewed, rolling out r243465.
2057         https://bugs.webkit.org/show_bug.cgi?id=196226
2058
2059         the test doesn't build (Requested by thorton on #webkit).
2060
2061         Reverted changeset:
2062
2063         "Do not terminate the NetworkProcess if a third party
2064         application sends a NSCredential with a SecIdentityRef"
2065         https://bugs.webkit.org/show_bug.cgi?id=196213
2066         https://trac.webkit.org/changeset/243465
2067
2068 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2069
2070         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2071         https://bugs.webkit.org/show_bug.cgi?id=196213
2072
2073         Reviewed by Geoff Garen.
2074
2075         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2076         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2077         (credentialWithIdentityAndKeychainPath):
2078         (-[ChallengeDelegate webView:didFinishNavigation:]):
2079         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2080         (TestWebKitAPI::TEST):
2081
2082 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2083
2084         [ews-build] Gracefully handle missing patch_id in events
2085         https://bugs.webkit.org/show_bug.cgi?id=196216
2086
2087         Reviewed by Lucas Forschler.
2088
2089         * BuildSlaveSupport/ews-build/events.py:
2090
2091 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2092
2093         [ews-build] use lz4 compression for improving buildbot performance
2094         https://bugs.webkit.org/show_bug.cgi?id=196155
2095
2096         Reviewed by Lucas Forschler.
2097
2098         * BuildSlaveSupport/ews-build/master.cfg:
2099
2100 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2101
2102         Pull some API testing helper methods out of TestWKWebView
2103         https://bugs.webkit.org/show_bug.cgi?id=196212
2104
2105         Reviewed by Tim Horton.
2106
2107         Refactor some more API testing utility methods, so that they can be used in
2108         tests that do not use TestWKWebView.
2109
2110         * TestWebKitAPI/cocoa/TestWKWebView.h:
2111         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2112         (-[WKWebView loadTestPageNamed:]):
2113         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2114         (-[WKWebView synchronouslyLoadHTMLString:]):
2115         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2116         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2117         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2118         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2119         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2120
2121 2019-03-25  Jer Noble  <jer.noble@apple.com>
2122
2123         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2124         https://bugs.webkit.org/show_bug.cgi?id=196097
2125
2126         Reviewed by Eric Carlson.
2127
2128         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2129
2130         * DumpRenderTree/mac/DumpRenderTree.mm:
2131         (resetWebPreferencesToConsistentValues):
2132         * WebKitTestRunner/TestController.cpp:
2133         (WTR::TestController::resetPreferencesToConsistentValues):
2134
2135 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2136
2137         Pull IPadUserInterfaceSwizzler out into a separate header file
2138         https://bugs.webkit.org/show_bug.cgi?id=196193
2139
2140         Reviewed by Anders Carlsson.
2141
2142         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2143         be used in other API tests.
2144
2145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2146         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2147         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2148         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2149         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2150         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2151         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2152
2153 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2154
2155         Remove NavigatorContentUtils in WebCore/Modules
2156         https://bugs.webkit.org/show_bug.cgi?id=196070
2157
2158         Reviewed by Alex Christensen.
2159
2160         NavigatorContentUtils was to support the custom scheme spec [1].
2161         However, in WebKit side, no port has supported the feature in
2162         WebKit layer after EFL port was removed. So there has been the
2163         only IDL implementation of the NavigatorContentUtils in WebCore.
2164         So we don't need to keep the implementation in WebCore anymore.
2165
2166         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2167
2168         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2169
2170 2019-03-24  Andy Estes  <aestes@apple.com>
2171
2172         [watchOS] Remove unused Proximity Networking code
2173         https://bugs.webkit.org/show_bug.cgi?id=196188
2174
2175         Reviewed by Tim Horton.
2176
2177         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2178         (TEST):
2179
2180 2019-03-23  Keith Miller  <keith_miller@apple.com>
2181
2182         Refactor clz/ctz and fix getLSBSet.
2183         https://bugs.webkit.org/show_bug.cgi?id=196162
2184
2185         Reviewed by Saam Barati.
2186
2187         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2188
2189         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2190         (TestWebKitAPI::TEST):
2191
2192 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2193
2194         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2195         https://bugs.webkit.org/show_bug.cgi?id=196143
2196
2197         Reviewed by Michael Catanzaro.
2198
2199         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2200         directories.
2201
2202         * Scripts/webkitpy/style/checkers/cpp.py:
2203         (check_identifier_name_in_declaration):
2204         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2205         (WebKitStyleTest.test_names):
2206
2207 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2208
2209         [Flatpak] Manifest expanding fails for qt WPE extension
2210         https://bugs.webkit.org/show_bug.cgi?id=196148
2211
2212         Reviewed by Alex Christensen.
2213
2214         * flatpak/flatpakutils.py:
2215         (expand_submodules_recurse): The last recurse manifest expand
2216         iteration might lead to a single module so take it into account
2217         and don't try to recurse further.
2218
2219 2019-03-22  Chris Dumez  <cdumez@apple.com>
2220
2221         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2222         https://bugs.webkit.org/show_bug.cgi?id=195348
2223         <rdar://problem/48622090>
2224
2225         Reviewed by Alex Christensen.
2226
2227         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2228         to NO when test.options().shouldIgnoreMetaViewport is false.
2229
2230         * WebKitTestRunner/ios/TestControllerIOS.mm:
2231         (WTR::TestController::platformConfigureViewForTest):
2232
2233 2019-03-22  Chris Dumez  <cdumez@apple.com>
2234
2235         Prewarmed processes should be usable with any website data store
2236         https://bugs.webkit.org/show_bug.cgi?id=196104
2237
2238         Reviewed by Alex Christensen.
2239
2240         Add API test coverage.
2241
2242         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2243         (runInitialWarmedProcessUsedTest):
2244         (TEST):
2245
2246 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2247
2248         Back out local changes to Alex's Subversion working directory
2249
2250         They were accidentally committed.
2251
2252         * Scripts/webkitpy/common/system/abstractexecutive.py:
2253         (AbstractExecutive.wait_newest):
2254         * Scripts/webkitpy/common/system/executive.py:
2255         (Executive.running_pids):
2256         * Scripts/webkitpy/common/system/executive_mock.py:
2257         (MockExecutive.running_pids):
2258         * Scripts/webkitpy/common/system/executive_unittest.py:
2259         (ExecutiveTest.serial_test_running_pids):
2260         * Scripts/webkitpy/port/darwin.py:
2261         (DarwinPort.check_for_leaks):
2262         * Scripts/webkitpy/port/leakdetector.py:
2263         (LeakDetector.check_for_leaks):
2264         - This was the hack attached to Bug 193772.
2265
2266         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2267         (+[WebKitTestRunnerEvent mouseLocation]):
2268         - This works around a crash on an internal build.
2269
2270 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2271
2272         Fix the build after r243354
2273         https://bugs.webkit.org/show_bug.cgi?id=196138
2274         <rdar://problem/49145951>
2275
2276         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2277         (TEST):
2278         * TestWebKitAPI/ios/UIKitSPI.h:
2279
2280 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2281
2282         Adopt UIWKDocumentContext
2283         https://bugs.webkit.org/show_bug.cgi?id=196040
2284         <rdar://problem/48642440>
2285
2286         Reviewed by Ryosuke Niwa.
2287
2288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2289         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2290         (makeRequest):
2291         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2292         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2293         (applyStyle):
2294         (TEST):
2295         Add tests for UIWKDocumentContext.
2296
2297         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2298         (TEST):
2299         (recursiveFindWKContentView): Deleted.
2300         * TestWebKitAPI/cocoa/TestWKWebView.h:
2301         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2302         (recursiveFindWKContentView):
2303         (-[TestWKWebView wkContentView]):
2304         * TestWebKitAPI/ios/UIKitSPI.h:
2305         Share the WKContentView finding code between tests.
2306
2307 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2308
2309         [iOS WK2] Turn on async overflow scrolling by default
2310         https://bugs.webkit.org/show_bug.cgi?id=196011
2311         rdar://problem/48453859
2312
2313         Reviewed by Antti Koivisto.
2314         
2315         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2316         since so many basic layout tests have different results when compositing is triggered for
2317         overflow.
2318         
2319         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2320
2321         * WebKitTestRunner/TestController.cpp:
2322         (WTR::TestController::resetPreferencesToConsistentValues):
2323
2324 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2325
2326         [ews-build] Retry API test in case of failures
2327         https://bugs.webkit.org/show_bug.cgi?id=196004
2328
2329         Reviewed by Lucas Forschler.
2330
2331         * BuildSlaveSupport/ews-build/steps.py:
2332         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2333         (CompileWebKitToT.doStepIf): Ditto.
2334         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2335         (ReRunAPITests): Re-run API tests.
2336         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2337         (RunAPITestsWithoutPatch): Run API tests without patch.
2338         (RunAPITestsWithoutPatch.doStepIf):
2339         (RunAPITestsWithoutPatch.hideStepIf):
2340         (RunAPITestsWithoutPatch.evaluateCommand):
2341         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2342         (AnalyzeAPITestsResults.start):
2343         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2344         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2345         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2346         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2347
2348 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2349
2350         [ews-build] Update queues configurations
2351         https://bugs.webkit.org/show_bug.cgi?id=196074
2352
2353         Reviewed by Dewei Zhu.
2354
2355         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2356         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2357
2358 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2359
2360         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2361         https://bugs.webkit.org/show_bug.cgi?id=195680
2362         <rdar://problem/48903534>
2363
2364         Unreviewed infrastructure fix.
2365
2366         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2367         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2368
2369 2019-03-21  Andy Estes  <aestes@apple.com>
2370
2371         [iOS] Apple Pay should be available in documents with no user agent scripts
2372         https://bugs.webkit.org/show_bug.cgi?id=196061
2373         <rdar://problem/48649391>
2374
2375         Reviewed by Brady Eidson.
2376
2377         Added API tests and related infrastructure.
2378
2379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2380         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2381         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2382         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2383         (TestWebKitAPI::TEST):
2384         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2385         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2386         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2387         * TestWebKitAPI/cocoa/TestProtocol.mm:
2388         (-[TestProtocol startLoading]):
2389         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2390         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2391         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2392         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2393
2394 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2395
2396         REGRESSSION (r243297): webkitpy tests broken
2397         https://bugs.webkit.org/show_bug.cgi?id=196108
2398
2399         Reviewed by Aakash Jain.
2400
2401         r243297 updated contributors.json, which broke a few unit tests.
2402
2403         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2404         (IRCCommandTest.test_whois):
2405         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2406
2407 2019-03-21  Chris Dumez  <cdumez@apple.com>
2408
2409         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2410         https://bugs.webkit.org/show_bug.cgi?id=196041
2411         <rdar://problem/49083230>
2412
2413         Reviewed by Alex Christensen.
2414
2415         Add API test coverage.
2416
2417         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2418         (TEST):
2419
2420 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2421
2422         Add SPI to inform applications of WKContentRuleList actions
2423         https://bugs.webkit.org/show_bug.cgi?id=195965
2424         <rdar://problem/42664365>
2425
2426         Reviewed by Geoff Garen.
2427
2428         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2429         (TestWebKitAPI::allActionsForResourceLoad):
2430         (TestWebKitAPI::testRequest):
2431         (TestWebKitAPI::TEST_F):
2432         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2433         (Notification::description):
2434         (Notification::operator== const):
2435         (toVector):
2436         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2437         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2438         (makeContentRuleList):
2439         (TEST):
2440         (makeWarnContentRuleList): Deleted.
2441
2442 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2443
2444         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2445         https://bugs.webkit.org/show_bug.cgi?id=196088
2446
2447         Reviewed by Brian Burg.
2448
2449         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2450         Support checks when only one platform is specified. Also deprecate macosx() and
2451         force the use of macos() instead.
2452
2453         * Scripts/webkitpy/style/checkers/cpp.py:
2454         (check_min_versions_of_wk_api_available):
2455         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2456         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2457
2458 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2459
2460         Update status inactive committers' status to 'contributor'.
2461
2462         * Scripts/webkitpy/common/config/contributors.json:
2463
2464 2019-03-21  Xan Lopez  <xan@igalia.com>
2465
2466         [JSC][x86] Drop support for x87 floating point
2467         https://bugs.webkit.org/show_bug.cgi?id=194853
2468
2469         Reviewed by Don Olmstead.
2470
2471         Force SSE2 on x86/32bit builds.
2472
2473         * Scripts/webkitdirs.pm:
2474         (generateBuildSystemFromCMakeProject):
2475
2476 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2477
2478         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2479         https://bugs.webkit.org/show_bug.cgi?id=196073
2480
2481         Reviewed by Michael Catanzaro.
2482
2483         Add test cases to check functions and constructors with no arguments but receiving user data.
2484
2485         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2486         (checkUserData):
2487         (testJSCFunction):
2488         (fooCreateWithUserData):
2489         (testJSCClass):
2490
2491 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2492
2493         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2494
2495         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2496
2497         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2498
2499 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2500
2501         [GTK][WPE] Add API to provide geolocation information
2502         https://bugs.webkit.org/show_bug.cgi?id=195940
2503
2504         Reviewed by Michael Catanzaro.
2505
2506         Add a new test to check the new API.
2507
2508         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2509         (testGeolocationManagerCurrentPosition):
2510         (testGeolocationManagerWatchPosition):
2511         (beforeAll):
2512         (afterAll):
2513         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2514         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2515         (beforeAll): Ditto.
2516         * TestWebKitAPI/glib/CMakeLists.txt:
2517
2518 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2519
2520         [GLib] Returning G_TYPE_OBJECT from a method does not work
2521         https://bugs.webkit.org/show_bug.cgi?id=195574
2522
2523         Reviewed by Michael Catanzaro.
2524
2525         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2526
2527         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2528         (getGFile):
2529         (getParent):
2530         (createGString):
2531         (getGString):
2532         (getGStringCopyWillRaise):
2533         (getGStringCopy):
2534         (getGStringStr):
2535         (getGStringLen):
2536         (freeGString):
2537         (testJSCClass):
2538
2539 2019-03-20  Saam Barati  <sbarati@apple.com>
2540
2541         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2542         https://bugs.webkit.org/show_bug.cgi?id=195721
2543
2544         Reviewed by Filip Pizlo.
2545
2546         * Scripts/run-javascriptcore-tests:
2547
2548 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2549
2550         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2551         https://bugs.webkit.org/show_bug.cgi?id=196049
2552
2553         Reviewed by Tim Horton.
2554
2555         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2556         overflow scrolling in general, so rename it.
2557
2558         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2559
2560 2019-03-20  Daniel Bates  <dabates@apple.com>
2561
2562         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2563         https://bugs.webkit.org/show_bug.cgi?id=196031
2564         <rdar://problem/49078172>
2565
2566         Reviewed by Tim Horton.
2567
2568         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2569         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2570         same code path used when the Done button is pressed to dismiss the <select> picker.
2571
2572         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2573         (TestWebKitAPI::TEST):
2574
2575 2019-03-20  Chris Dumez  <cdumez@apple.com>
2576
2577         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2578         https://bugs.webkit.org/show_bug.cgi?id=196029
2579         <rdar://problem/48954651>
2580
2581         Reviewed by Tim Horton.
2582
2583         Add API test coverage.
2584
2585         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2586
2587 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2588
2589         [ews-build] Improve failure summary string for ApplyPatch step
2590         https://bugs.webkit.org/show_bug.cgi?id=195995
2591
2592         Reviewed by Alexey Proskuryakov.
2593
2594         * BuildSlaveSupport/ews-build/steps.py:
2595         (ApplyPatch.getResultSummary): Override getResultSummary.
2596
2597 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2598
2599         AX: Implement support for new meter ARIA role
2600         https://bugs.webkit.org/show_bug.cgi?id=195966
2601
2602         Reviewed by Chris Fleizach.
2603
2604         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2605         to AXLevelIndicator.
2606
2607         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2608
2609 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2610
2611         [WebAuthN] Implement FIDO AppID extension
2612         https://bugs.webkit.org/show_bug.cgi?id=143491
2613         <rdar://problem/48298273>
2614
2615         Reviewed by Brent Fulgham.
2616
2617         Add a test that covers the new flag of convertToU2fSignCommand.
2618
2619         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2620         (TestWebKitAPI::TEST):
2621         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2622         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2623         (TestWebKitAPI::TEST):
2624
2625 2019-03-19  Keith Rollin  <krollin@apple.com>
2626
2627         Add support for more platforms to generate-xcfilelists
2628         https://bugs.webkit.org/show_bug.cgi?id=195977
2629
2630         Reviewed by Alexey Proskuryakov.
2631
2632         generate-xcfilelists incorrectly complains when involved with building
2633         WebKit for iphonesimulator:
2634
2635             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2636             …
2637             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2638
2639         Address this by teaching generate-xcfilelists about more platforms.
2640
2641         * Scripts/generate-xcfilelists:
2642
2643 2019-03-19  John Wilander  <wilander@apple.com>
2644
2645         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2646         https://bugs.webkit.org/show_bug.cgi?id=195923
2647         <rdar://problem/49001272>
2648
2649         Reviewed by Alex Christensen.
2650
2651         This patch does the following to the TestRunner:
2652         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2653         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2654         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2655
2656         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2657         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2658         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2659         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2660         * WebKitTestRunner/TestController.cpp:
2661         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2662         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2663         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2664         * WebKitTestRunner/TestController.h:
2665         * WebKitTestRunner/TestInvocation.cpp:
2666         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2667
2668 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2669
2670         [CMake] Support more clang and gcc sanitizers
2671         https://bugs.webkit.org/show_bug.cgi?id=195956
2672
2673         Reviewed by Michael Catanzaro.
2674
2675         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2676
2677 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2678
2679         [ews-build] Improve summary for PrintConfiguration step
2680         https://bugs.webkit.org/show_bug.cgi?id=195945
2681
2682         Reviewed by Lucas Forschler.
2683
2684         * BuildSlaveSupport/ews-build/steps.py:
2685         (PrintConfiguration.getResultSummary): Override getResultSummary.
2686
2687 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2688
2689         [ews-build] Improve summary for CheckOutSource step
2690         https://bugs.webkit.org/show_bug.cgi?id=195963
2691
2692         Reviewed by Lucas Forschler.
2693
2694         * BuildSlaveSupport/ews-build/steps.py:
2695         (CheckOutSource.getResultSummary):
2696
2697 2019-03-19  Daniel Bates  <dabates@apple.com>
2698
2699         [iOS] Focus not preserved when switching between tabs
2700         https://bugs.webkit.org/show_bug.cgi?id=195820
2701         <rdar://problem/43614450>
2702
2703         Reviewed by Brent Fulgham.
2704
2705         Add tests to ensure that we restore focus when resigning and becoming first responder.
2706
2707         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2708         (TestWebKitAPI::TEST):
2709
2710 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2711
2712         Make WTFLogChannelState and WTFLogLevel enum classes
2713         https://bugs.webkit.org/show_bug.cgi?id=195904
2714
2715         Reviewed by Eric Carlson.
2716
2717         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2718         (TestWebKitAPI::TEST_F):
2719
2720 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2721
2722         [GStreamer][EME] Backported mssdemux protection data crash fix
2723         https://bugs.webkit.org/show_bug.cgi?id=195918
2724
2725         Reviewed by Philippe Normand.
2726
2727         * gstreamer/jhbuild.modules:
2728         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2729
2730 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2731
2732         Unreviewed, rolling out r243132.
2733
2734         Broke GTK build
2735
2736         Reverted changeset:
2737
2738         "Make WTFLogChannelState and WTFLogLevel enum classes"
2739         https://bugs.webkit.org/show_bug.cgi?id=195904
2740         https://trac.webkit.org/changeset/243132
2741
2742 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2743
2744         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2745
2746         * Scripts/webkitdirs.pm:
2747         (builtDylibPathForName): Adjust the shared library name that's changed
2748         with the API version bump in r243073.
2749
2750 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2751
2752         Make WTFLogChannelState and WTFLogLevel enum classes
2753         https://bugs.webkit.org/show_bug.cgi?id=195904
2754
2755         Reviewed by Eric Carlson.
2756
2757         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2758         (TestWebKitAPI::TEST_F):
2759
2760 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2761
2762         Disable flaky test added in r2431100
2763         https://webkit.org/b/195785
2764
2765         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2766         (TestWebKitAPI::TEST):
2767         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2768
2769 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2770
2771         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2772         https://bugs.webkit.org/show_bug.cgi?id=195916
2773
2774         Reviewed by Tim Horton.
2775
2776         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2777         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2778
2779 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2780
2781         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2782
2783         * Scripts/webkitpy/common/config/contributors.json:
2784
2785 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2786
2787         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2788         https://bugs.webkit.org/show_bug.cgi?id=195785
2789
2790         Reviewed by Geoffrey Garen.
2791
2792         * TestWebKitAPI/TCPServer.cpp: Added.
2793         (TestWebKitAPI::TCPServer::TCPServer):
2794         (TestWebKitAPI::TCPServer::~TCPServer):
2795         (TestWebKitAPI::TCPServer::socketBindListen):
2796         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2797         * TestWebKitAPI/TCPServer.h: Added.
2798         (TestWebKitAPI::TCPServer::port const):
2799         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2800         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2801         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2802         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2803         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2804         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2805         (TestWebKitAPI::respondSlowly):
2806         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2807         (TestWebKitAPI::downloadAtRate):
2808         (TestWebKitAPI::TEST):
2809
2810 2019-03-18  Saam Barati  <sbarati@apple.com>
2811
2812         Add a plan file for JetStream 2
2813         https://bugs.webkit.org/show_bug.cgi?id=190734
2814
2815         Reviewed by Mark Lam.
2816
2817         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2818
2819 2019-03-18  Chris Dumez  <cdumez@apple.com>
2820
2821         Delay WebProcess launch until a load is triggered in a Web view
2822         https://bugs.webkit.org/show_bug.cgi?id=195758
2823         <rdar://problem/48126013>
2824
2825         Reviewed by Geoff Garen.
2826
2827         Add API test coverage. Also update some existing API tests to not expect
2828         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2829
2830         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2831         (TestWebKitAPI::TEST):
2832         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2833         (TestWebKitAPI::TEST):
2834         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2835         (TEST):
2836         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2837         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2838         (TEST):
2839         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2840         (TEST):
2841         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2842
2843 2019-03-18  Xan Lopez  <xan@igalia.com>
2844
2845         [CMake] Prevent potential warning when determining $architecture
2846         https://bugs.webkit.org/show_bug.cgi?id=195891
2847
2848         Reviewed by Michael Catanzaro.
2849
2850         It's possible for generateBuildSystemForCMakeProject to be called
2851         before determineArchitecture() is ever called. This will make the
2852         first eq check with $architecture to be bogus (and print a
2853         warning). Change that to an eq check with architecture(), which
2854         implicitly calls determineArchitecture() if needed, and change all
2855         the other similar cases in the method in the same way to prevent
2856         future bugs like this one.
2857
2858         * Scripts/webkitdirs.pm:
2859         (generateBuildSystemFromCMakeProject):
2860
2861 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2862
2863         [WPE] Tarballs generated with “make dist” cannot build documentation
2864         https://bugs.webkit.org/show_bug.cgi?id=195885
2865
2866         Reviewed by Carlos Garcia Campos.
2867
2868         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2869
2870 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2871
2872         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2873         https://bugs.webkit.org/show_bug.cgi?id=195883
2874
2875         Reviewed by Carlos Garcia Campos.
2876
2877         * gtkdoc/gtkdoc.py:
2878         (GTKDoc._run_command): When commands fail to run, include the full command line for
2879         the program invocation and the output it has generated on the standard error stream.
2880
2881 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2882
2883         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2884         https://bugs.webkit.org/show_bug.cgi?id=195786
2885
2886         Reviewed by Philippe Normand.
2887
2888         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2889         * wpe/jhbuild.modules: Ditto.
2890
2891 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2892
2893         [ews-build] Don't run clean builds on EWS builders
2894         https://bugs.webkit.org/show_bug.cgi?id=195851
2895
2896         Reviewed by Geoffrey Garen.
2897
2898         * BuildSlaveSupport/ews-build/factories.py:
2899
2900 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2901
2902         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2903         https://bugs.webkit.org/show_bug.cgi?id=195849
2904
2905         Reviewed by Chris Dumez.
2906
2907         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2908
2909         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2910         (runWebsiteDataStoreCustomPaths):
2911
2912 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2913
2914         webkitpy: Upload test results
2915         https://bugs.webkit.org/show_bug.cgi?id=195755
2916         <rdar://problem/48896182>
2917
2918         Reviewed by Aakash Jain.
2919
2920         Establish a new format for uploading results that is not tied to layout tests, apply
2921         that format to webkitpy tests.
2922
2923         * Scripts/webkitpy/common/checkout/scm/git.py:
2924         (Git.native_branch): Return what branch the current checkout is on.
2925         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2926         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2927         * Scripts/webkitpy/common/checkout/scm/svn.py:
2928         (SVN.native_branch): Ditto.
2929         * Scripts/webkitpy/common/system/platforminfo.py:
2930         (PlatformInfo.build_version): Return a build version for Mac.
2931         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2932         (MockPlatformInfo.__init__):
2933         (MockPlatformInfo.build_version):
2934         * Scripts/webkitpy/results: Added.
2935         * Scripts/webkitpy/results/__init__.py: Added.
2936         * Scripts/webkitpy/results/options.py: Added.
2937         (upload_options): OptParse list for upload options.
2938         * Scripts/webkitpy/results/upload.py: Added.
2939         (Upload): Class which enforces the upload format expected by the results server.
2940         (Upload.Expectations):
2941         (Upload.create_configuration):
2942         (Upload.create_commit):
2943         (Upload.create_details):
2944         (Upload.create_run_stats):
2945         (Upload.create_test_result):
2946         (Upload.__init__):
2947         (Upload.Encoder): Encode Upload object as json.
2948         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2949         * Scripts/webkitpy/results/upload_unittest.py: Added.
2950         * Scripts/webkitpy/test/main.py:
2951         (Tester._parse_args): Add upload arguments.
2952         (Tester._run_tests): Allow results to be uploaded.
2953         * Scripts/webkitpy/test/runner.py:
2954         (Runner.__init__): Record which tests were run, rather than just counting them.
2955         (Runner.handle):
2956         * Scripts/webkitpy/test/runner_unittest.py:
2957         (RunnerTest.test_run):
2958         * Scripts/webkitpy/thirdparty/__init__.py:
2959         (AutoinstallImportHook.find_module): Add requests auto-install.
2960         (AutoinstallImportHook._install_requests):
2961         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2962         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2963
2964 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2965
2966         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2967         https://bugs.webkit.org/show_bug.cgi?id=195810
2968
2969         Reviewed by Tim Horton.
2970
2971         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2972         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2973         ending certain layout tests.
2974
2975         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2976         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2977         (-[TestRunnerWKWebView dealloc]):
2978         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2979
2980         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2981         helper method when destroying the web view, and when resetting state between tests.
2982
2983         * WebKitTestRunner/ios/TestControllerIOS.mm:
2984         (WTR::TestController::platformResetStateToConsistentValues):
2985
2986         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2987
2988 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2989
2990         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2991         https://bugs.webkit.org/show_bug.cgi?id=190350
2992         <rdar://problem/45089503>
2993
2994         Reviewed by Geoffrey Garen.
2995
2996         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2997         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2998         (TEST):
2999         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3000         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3001         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3002         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3003         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3004         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3005         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3006         (runTest):
3007         (createDirectories):
3008         (TEST):
3009         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3010         (TEST):
3011         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3012         (TEST):
3013
3014 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3015
3016         Add support to WebPage for getting the contents as an attributed string.
3017         https://bugs.webkit.org/show_bug.cgi?id=195636
3018         rdar://problem/45055697
3019
3020         Reviewed by Tim Horton.
3021
3022         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3023         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3024
3025 2019-03-15  Chris Dumez  <cdumez@apple.com>
3026
3027         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3028         https://bugs.webkit.org/show_bug.cgi?id=195747
3029
3030         Reviewed by Geoff Garen.
3031
3032         Add API test coverage.
3033
3034         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3035
3036 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3037
3038         Unreviewed, rolling out r242952.
3039
3040         Causing API failures on iOS Simulator
3041
3042         Reverted changeset:
3043
3044         "[PSON] Make sure the WebProcessCache is leverage when
3045         relaunching a process after termination"
3046         https://bugs.webkit.org/show_bug.cgi?id=195747
3047         https://trac.webkit.org/changeset/242952
3048
3049 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3050
3051         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3052         https://bugs.webkit.org/show_bug.cgi?id=195740
3053
3054         Reviewed by Ross Kirsling.
3055
3056         window.open doesn't work for WebKitBrowserWindow because it is not
3057         implemented yet.
3058
3059         1. Implemented createNewPage callback of WKPageUIClient.
3060         2. Changed MainWindow to take a BrowserWindow factory function
3061           instead of BrowserWindowType to be flexible to create
3062           BrowserWindow with extra settings.
3063         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3064           because it is not relevant with MainWindow anymore.
3065
3066         * MiniBrowser/win/Common.cpp:
3067         (parseCommandLine):
3068         * MiniBrowser/win/Common.h:
3069         (CommandLineOptions::CommandLineOptions):
3070         * MiniBrowser/win/MainWindow.cpp:
3071         (MainWindow::MainWindow):
3072         (MainWindow::create):
3073         (MainWindow::init):
3074         (MainWindow::WndProc):
3075         * MiniBrowser/win/MainWindow.h:
3076         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3077         (PrintWebUIDelegate::createWebViewWithRequest):
3078         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3079         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3080         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3081         (WebKitBrowserWindow::updateProxySettings):
3082         (WebKitBrowserWindow::createNewPage):
3083         * MiniBrowser/win/WebKitBrowserWindow.h:
3084         * MiniBrowser/win/WinMain.cpp:
3085         (wWinMain):
3086
3087 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3088
3089         Make it possible to test scrolling tree layer manipulation more easily
3090         https://bugs.webkit.org/show_bug.cgi?id=195780
3091
3092         Reviewed by Tim Horton.
3093         
3094         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3095         cuts off communication of scrolling tree scrolls back to the web process
3096         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3097         allows tests to trigger scrolls which run the scrolling tree layer positioning
3098         logic, but never get another commit from the web process that might mask
3099         scrolling tree bugs.
3100         
3101         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3102         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3103         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3104
3105         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3106         (WTR::UIScriptController::scrollUpdatesDisabled const):
3107         (WTR::UIScriptController::setScrollUpdatesDisabled):
3108         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3109         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3110         (WTR::UIScriptController::scrollUpdatesDisabled const):
3111         (WTR::UIScriptController::setScrollUpdatesDisabled):
3112         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3113         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3114         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3115         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3116         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3117         * WebKitTestRunner/ios/TestControllerIOS.mm:
3118         (WTR::TestController::platformResetStateToConsistentValues):
3119         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3120         (WTR::UIScriptController::scrollUpdatesDisabled const):
3121         (WTR::UIScriptController::setScrollUpdatesDisabled):
3122
3123 2019-03-14  Youenn Fablet  <youenn@apple.com>
3124
3125         Move IDB storage in private browsing mode to NetworkProcess
3126         https://bugs.webkit.org/show_bug.cgi?id=195602
3127
3128         Reviewed by Brady Eidson.
3129
3130         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3131         (TEST):
3132
3133 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3134
3135         [ews-build] Make descriptionDone messages more readable
3136         https://bugs.webkit.org/show_bug.cgi?id=195760
3137
3138         Reviewed by Lucas Forschler.
3139
3140         * BuildSlaveSupport/ews-build/steps.py:
3141         * BuildSlaveSupport/ews-build/steps_unittest.py:
3142
3143 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3144
3145         [ews-build] Generate status-bubble hover-over messages
3146         https://bugs.webkit.org/show_bug.cgi?id=195680
3147
3148         Reviewed by Lucas Forschler.
3149
3150         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3151         (StatusBubble):
3152         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3153         on hover-over.
3154         (StatusBubble._iso_time):
3155         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3156         hover-over message.
3157         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3158
3159 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3160
3161         [ews-app] Gracefully handle the case when state_string is None
3162         https://bugs.webkit.org/show_bug.cgi?id=195753
3163
3164         Reviewed by Lucas Forschler.
3165
3166         * BuildSlaveSupport/ews-app/ews/models/build.py:
3167         * BuildSlaveSupport/ews-app/ews/models/step.py:
3168
3169 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3170
3171         [ews-app] Status bubble display pending for currently running build step
3172         https://bugs.webkit.org/show_bug.cgi?id=195744
3173
3174         Reviewed by Lucas Forschler.
3175
3176         * BuildSlaveSupport/ews-build/events.py:
3177         (Events.stepStarted): If state_string is pending, replace it with step name.
3178
3179 2019-03-14  Chris Dumez  <cdumez@apple.com>
3180
3181         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3182         https://bugs.webkit.org/show_bug.cgi?id=195750
3183
3184         Reviewed by Geoffrey Garen.
3185
3186         Add API test coverage.
3187
3188         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3189         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3190         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3191         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3192
3193 2019-03-14  Chris Dumez  <cdumez@apple.com>
3194
3195         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3196         https://bugs.webkit.org/show_bug.cgi?id=195747
3197
3198         Reviewed by Geoff Garen.
3199
3200         Add API test coverage.
3201
3202         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3203
3204 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3205
3206         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3207         https://bugs.webkit.org/show_bug.cgi?id=195725
3208         <rdar://problem/48545062>
3209
3210         Reviewed by Tim Horton.
3211
3212         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3213         handler is nil.
3214
3215         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3216         (TestWebKitAPI::TEST):
3217
3218 2019-03-13  Sam Weinig  <sam@webkit.org>
3219
3220         Add utility function to allow easy reverse range-based iteration of a container
3221         https://bugs.webkit.org/show_bug.cgi?id=195542
3222
3223         Reviewed by Antti Koivisto.
3224
3225         * TestWebKitAPI/CMakeLists.txt:
3226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3227         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3228         (TestWebKitAPI::TEST):
3229         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3230
3231 2019-03-13  Chris Dumez  <cdumez@apple.com>
3232
3233         Use a ServiceWorker process per registrable domain
3234         https://bugs.webkit.org/show_bug.cgi?id=195649
3235
3236         Reviewed by Youenn Fablet.
3237
3238         Update API test coverage.
3239
3240         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3241
3242 2019-03-13  Chris Dumez  <cdumez@apple.com>
3243
3244         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3245         https://bugs.webkit.org/show_bug.cgi?id=195684
3246         <rdar://problem/48294714>
3247
3248         Reviewed by Antti Koivisto.
3249
3250         Add API test coverage.
3251
3252         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3253
3254 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3255
3256         [ews-app] Remove unused patch view
3257         https://bugs.webkit.org/show_bug.cgi?id=195669
3258
3259         Reviewed by Lucas Forschler.
3260
3261         * BuildSlaveSupport/ews-app/ews/urls.py:
3262         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3263
3264 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3265
3266         [ews-app] Use Buildbot result code variables
3267         https://bugs.webkit.org/show_bug.cgi?id=195668
3268
3269         Reviewed by Alexey Proskuryakov.
3270
3271         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3272         (Buildbot): Added Buildbot result code variables.
3273         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3274         (StatusBubble._build_bubble): Used Buildbot result code variables.
3275
3276 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3277
3278         [Flatpak] Expand submodule recursively
3279         https://bugs.webkit.org/show_bug.cgi?id=195672
3280
3281         Building WPE with flatpak was impossible without that as it was raising an exception.
3282         Also update wpebackend-fdo to match what is built in jhbuild
3283
3284         Reviewed by Philippe Normand.
3285
3286         * flatpak/flatpakutils.py:
3287         (expand_submodules_recurse):
3288         (expand_manifest):
3289         * flatpak/org.webkit.WPEModules.yaml:
3290
3291 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3292
3293         [ews-app] status bubble should be hidden for certain builds
3294         https://bugs.webkit.org/show_bug.cgi?id=194597
3295
3296         Reviewed by Dewei Zhu.
3297
3298         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3299         (StatusBubble._build_bubble):
3300         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3301         because the patch didn't have relevant changes.
3302         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3303         in production yet.
3304
3305 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3306
3307         [Win] Fix a slew of simple clang-cl warnings.
3308         https://bugs.webkit.org/show_bug.cgi?id=195652
3309
3310         Reviewed by Don Olmstead.
3311
3312         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3313         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3314
3315 2019-03-12  Justin Fan  <justin_fan@apple.com>
3316
3317         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3318         https://bugs.webkit.org/show_bug.cgi?id=195518
3319         <rdar://problem/46322356>
3320
3321         Reviewed by Myles C. Maxfield.
3322
3323         * DumpRenderTree/DerivedSources-input.xcfilelist:
3324         * DumpRenderTree/DerivedSources-output.xcfilelist:
3325
3326 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3327
3328         Unreviewed, rolling out r242825.
3329         https://bugs.webkit.org/show_bug.cgi?id=195648
3330
3331         "Broke webkitpy tests with my change to
3332         lldb_dump_class_layout.py" (Requested by rmorisset on
3333         #webkit).
3334
3335         Reverted changeset:
3336
3337         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3338         classes with suspicious padding"
3339         https://bugs.webkit.org/show_bug.cgi?id=195573
3340         https://trac.webkit.org/changeset/242825
3341
3342 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3343
3344         [ews-build] Show status bubbles while the patch is waiting in queue
3345         https://bugs.webkit.org/show_bug.cgi?id=195618
3346
3347         Reviewed by Lucas Forschler.
3348
3349         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3350         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3351         enabled in initial deployment.
3352         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3353         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3354         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3355         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3356         (StatusBubble._build_bubbles_for_patch):
3357
3358 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3359
3360         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3361         https://bugs.webkit.org/show_bug.cgi?id=195573
3362
3363         Reviewed by Simon Fraser.
3364
3365         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3366
3367         * Scripts/dump-class-layout:
3368         (main):
3369         * lldb/lldb_dump_class_layout.py:
3370         (ClassLayout.__init__):
3371         (ClassLayout._compute_padding_recursive):
3372         (LLDBDebuggerInstance.dump_layout_for_classname):
3373         (LLDBDebuggerInstance):
3374         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3375         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3376
3377 2019-03-12  Chris Dumez  <cdumez@apple.com>
3378
3379         Device Orientation access permission should be denied unless explicitly granted by the client
3380         https://bugs.webkit.org/show_bug.cgi?id=195625
3381
3382         Reviewed by Youenn Fablet.
3383
3384         add API test coverage.
3385
3386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3387         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3388         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3389         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3390         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3391         (runDeviceOrientationTest):
3392         (TEST):
3393         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3394         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3395
3396 2019-03-12  Jer Noble  <jer.noble@apple.com>
3397
3398         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3399         https://bugs.webkit.org/show_bug.cgi?id=195137
3400         <rdar://problem/48810307>
3401
3402         Reviewed by Eric Carlson.
3403
3404         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3405         (TestWebKitAPI::TEST):
3406
3407 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3408
3409         [ews-build] Change urls from uat to production
3410         https://bugs.webkit.org/show_bug.cgi?id=195566
3411
3412         Reviewed by Lucas Forschler.
3413
3414         * BuildSlaveSupport/ews-app/ews/config.py:
3415         * BuildSlaveSupport/ews-build/events.py:
3416         * BuildSlaveSupport/ews-build/steps.py:
3417
3418 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3419
3420         [ews-build] change max_builds for local-worker to 1
3421         https://bugs.webkit.org/show_bug.cgi?id=195568
3422
3423         Reviewed by Lucas Forschler.
3424
3425         * BuildSlaveSupport/ews-build/loadConfig.py:
3426
3427 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3428
3429         Fix the build
3430
3431         * TestRunnerShared/spi/PencilKitTestSPI.h:
3432         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3433
3434 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3435
3436         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3437         https://bugs.webkit.org/show_bug.cgi?id=194131
3438
3439         Reviewed by Michael Catanzaro.
3440
3441         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3442         (uriChanged):
3443         (testUnfinishedSubresourceLoad):
3444         (serverCallback):
3445         (beforeAll):
3446
3447 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3448
3449         WTF::Expected should use std::addressof instead of operator&
3450         https://bugs.webkit.org/show_bug.cgi?id=195604
3451
3452         Reviewed by Myles Maxfield.
3453
3454         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3455         (TestWebKitAPI::Unique::Unique):
3456         (TestWebKitAPI::Unique::operator&):
3457         (TestWebKitAPI::TEST):
3458
3459 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3460
3461         Add Optional to Forward.h.
3462         https://bugs.webkit.org/show_bug.cgi?id=195586
3463
3464         Reviewed by Darin Adler.
3465
3466         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3467         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3468         Remove unnecessary includes from headers.
3469
3470 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3471
3472         Add testing API to hit-test and scroll overflow scrollers
3473         https://bugs.webkit.org/show_bug.cgi?id=195278
3474
3475         Reviewed by Antti Koivisto.
3476         
3477         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3478         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3479         
3480         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3481
3482         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3483         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3484         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3485         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3486         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3487         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3488         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3489         (WTR::enclosingScrollViewIncludingSelf):
3490         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3491
3492 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3493
3494         API test WebKit.RequestTextInputContext fails on iOS
3495         https://bugs.webkit.org/show_bug.cgi?id=195585
3496
3497         Reviewed by Wenson Hsieh and Simon Fraser.
3498
3499         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3500         (applyStyle):
3501         (TEST):
3502         Add a viewport, so that the coordinates match up on iOS.
3503         Scroll by moving the UIScrollView's contentOffset.
3504
3505 2019-03-11  Chris Dumez  <cdumez@apple.com>
3506
3507         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3508         https://bugs.webkit.org/show_bug.cgi?id=195506
3509         <rdar://problem/48733477>
3510
3511         Reviewed by Alex Christensen.
3512
3513         Add API test coverage.
3514
3515         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3516
3517 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3518
3519         Adding myself to contributors.json
3520
3521         Unreviewed, addming myself to contributors.json .
3522
3523         * Scripts/webkitpy/common/config/contributors.json:
3524
3525 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3526
3527         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3528         https://bugs.webkit.org/show_bug.cgi?id=195511
3529         <rdar://problem/44873269>
3530
3531         Reviewed by Darin Adler.
3532
3533         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3534         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3535         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3536         (TEST_F):
3537
3538 2019-03-11  Chris Dumez  <cdumez@apple.com>
3539
3540         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3541         https://bugs.webkit.org/show_bug.cgi?id=195561
3542
3543         Reviewed by Youenn Fablet.
3544
3545         Make sure the JS in the test requests for permission to receive device orientation events.
3546
3547         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3548
3549 2019-03-11  Youenn Fablet  <youenn@apple.com>
3550
3551         Allow storage quota increase by default in WTR
3552         https://bugs.webkit.org/show_bug.cgi?id=195541
3553
3554         Reviewed by Geoffrey Garen.
3555
3556         Allow storage quota increase by default in WTR.
3557         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3558         Use this for tests that explicitly need cache increase.
3559
3560         Instead of increasing quota by 2, make sure the next request is
3561         granted by adding all given parameters.
3562
3563         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3564         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3565         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3566         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3567         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3568         * WebKitTestRunner/TestController.cpp:
3569         (WTR::TestController::setAllowStorageQuotaIncrease):
3570         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3571         * WebKitTestRunner/TestController.h:
3572         * WebKitTestRunner/TestInvocation.cpp:
3573         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3574         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3575         (WTR::TestController::cocoaResetStateToConsistentValues):
3576         (WTR::TestController::setAllowStorageQuotaIncrease):
3577         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3578         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3579         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3580
3581 2019-03-11  Xan Lopez  <xan@igalia.com>
3582
3583         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3584         https://bugs.webkit.org/show_bug.cgi?id=194147
3585
3586         Reviewed by Michael Saboff.
3587
3588         To make --32-bit work correctly on Linux/64bit we need to:
3589
3590         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3591         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3592         unfortunately CMake only allows us to do this during
3593         crosscompilation, which is overkill here.
3594         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3595         pkg-config detection module uses the x86 .pc files instead of the
3596         x86_64 ones.
3597         - Set the -m32 flags for the compiler.
3598
3599         * Scripts/webkitdirs.pm:
3600         (generateBuildSystemFromCMakeProject):
3601
3602 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3603
3604         Add MotionMark-1.1 plan file for run-benchmark script.
3605         https://bugs.webkit.org/show_bug.cgi?id=195481
3606
3607         Rubber-stamped by Darin Adler.
3608
3609         Run-benchmark script should support MontionMark-1.1.
3610
3611         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3612
3613 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3614
3615         [ews-app] Add support for submit-to-ews url
3616         https://bugs.webkit.org/show_bug.cgi?id=195477
3617
3618         Reviewed by Lucas Forschler.
3619
3620         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3621         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3622         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3623         * BuildSlaveSupport/ews-app/ews/urls.py:
3624         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3625
3626 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3627
3628         Unreviewed, rolling out r242688, r242643, r242624.
3629
3630         Caused multiple layout test failures and crashes on iOS and macOS.
3631
3632         Reverted changeset:
3633
3634         "requestAnimationFrame should execute before the next frame"
3635         https://bugs.webkit.org/show_bug.cgi?id=177484
3636         https://trac.webkit.org/changeset/242624/webkit
3637
3638         * Tracing/SystemTracePoints.plist:
3639
3640 2019-03-11  John Wilander  <wilander@apple.com>
3641
3642         Resource Load Statistics: Make it possible exclude localhost from classification
3643         https://bugs.webkit.org/show_bug.cgi?id=195474
3644         <rdar://problem/47520577>
3645
3646         Reviewed by Brent Fulgham.
3647
3648         This patch allows for localhost to be excluded from classification and
3649         treatment as a prevalent resource.
3650
3651         The WebKit Tools change adds a new function called
3652         testRunner.setStatisticsIsRunningTest() which can be used to control this
3653         behavior.
3654
3655         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3656         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3657         (WTR::TestRunner::setStatisticsIsRunningTest):
3658         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3659         * WebKitTestRunner/TestController.cpp:
3660         (WTR::TestController::setStatisticsIsRunningTest):
3661         * WebKitTestRunner/TestController.h:
3662         * WebKitTestRunner/TestInvocation.cpp:
3663         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3664
3665 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3666
3667         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3668         https://bugs.webkit.org/show_bug.cgi?id=195560
3669
3670         Reviewed by Lucas Forschler.
3671
3672         * BuildSlaveSupport/ews-build/master.cfg:
3673
3674 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3675
3676         Unreviewed, rolling out r242698.
3677
3678         API test crashes on bots.
3679
3680         Reverted changeset:
3681
3682         "Add a WKContentRuleList variant that uses copied memory
3683         instead of mmap'd shared memory for class A containerized
3684         apps"
3685         https://bugs.webkit.org/show_bug.cgi?id=195511
3686         https://trac.webkit.org/changeset/242698
3687
3688 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3689
3690         [WPE] Enable web process sandbox
3691         https://bugs.webkit.org/show_bug.cgi?id=195169
3692
3693         Reviewed by Daniel Bates.
3694
3695         * wpe/install-dependencies:
3696         * wpe/jhbuild.modules:
3697
3698 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3699
3700         [ews-app] Use port 17000 for worker communication
3701         https://bugs.webkit.org/show_bug.cgi?id=195558
3702
3703         Reviewed by Lucas Forschler.
3704
3705         * BuildSlaveSupport/ews-build/master.cfg:
3706
3707 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3708
3709         [ews-build] unit-tests fail when passwords.json is missing
3710         https://bugs.webkit.org/show_bug.cgi?id=195557
3711
3712         Reviewed by Lucas Forschler.
3713
3714         * BuildSlaveSupport/ews-build/loadConfig.py:
3715         (loadBuilderConfig):
3716         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3717         (ConfigDotJSONTest.test_configuration):
3718         * BuildSlaveSupport/ews-build/master.cfg:
3719
3720 2019-03-11  Truitt Savell  <tsavell@apple.com>
3721
3722         Unreviewed, rolling out r242702.
3723
3724         Broke High Sierra builders.
3725
3726         Reverted changeset:
3727
3728         "Add utility function to allow easy reverse range-based
3729         iteration of a container"
3730         https://bugs.webkit.org/show_bug.cgi?id=195542
3731         https://trac.webkit.org/changeset/242702
3732
3733 2019-03-11  Sam Weinig  <sam@webkit.org>
3734
3735         Add utility function to allow easy reverse range-based iteration of a container
3736         https://bugs.webkit.org/show_bug.cgi?id=195542
3737
3738         Reviewed by Antti Koivisto.
3739
3740         * TestWebKitAPI/CMakeLists.txt:
3741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3742         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3743         (TestWebKitAPI::TEST):
3744         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3745
3746 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3747
3748         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3749         https://bugs.webkit.org/show_bug.cgi?id=195511
3750         <rdar://problem/44873269>
3751
3752         Reviewed by Darin Adler.
3753
3754         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3755         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3756         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3757         (TEST_F):
3758
3759 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3760
3761         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3762         https://bugs.webkit.org/show_bug.cgi?id=195499
3763
3764         Reviewed by Darin Adler.
3765
3766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3767         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3768         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3769         (-[WKWebView synchronouslyFocusTextInputContext:]):
3770         (applyStyle):
3771         (applyIframe):
3772         (TEST):
3773         Add some tests for this SPI.
3774
3775 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3776
3777         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3778         https://bugs.webkit.org/show_bug.cgi?id=181151
3779
3780         Reviewed by Don Olmstead.
3781
3782         * TestWebKitAPI/CMakeLists.txt:
3783         * TestWebKitAPI/PlatformWin.cmake:
3784         Enable TestWTF RunLoop tests in all platforms.
3785
3786         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3787         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3788         (TestWebKitAPI::DerivedOneShotTimer::fired):
3789         (TestWebKitAPI::TEST):
3790         Only a few platforms support nested RunLoop.
3791
3792         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3793         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3794
3795 2019-03-10  David Quesada  <david_quesada@apple.com>
3796
3797         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3798         https://bugs.webkit.org/show_bug.cgi?id=152480
3799
3800         Reviewed by Chris Dumez.
3801
3802         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3803         there are no additional references to the process pool besides the one held by
3804         the download, waits for the download to finish (in the sense that the
3805         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3806         measure, also check that the process pool has been deallocated at the end of the
3807         test. The test wouldn't be meaningful if the process pool were still alive.
3808
3809         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3810         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3811         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3812             The download will be canceled because the delegate does not implement the
3813             method to decide the download's destination, so this is where we know the
3814             DownloadProxyMap is done with the DownloadProxy.
3815         (TEST):
3816
3817 2019-03-08  Chris Dumez  <cdumez@apple.com>
3818
3819         Add support for Device Orientation / Motion permission API
3820         https://bugs.webkit.org/show_bug.cgi?id=195329
3821         <rdar://problem/47645367>
3822
3823         Reviewed by Geoffrey Garen.
3824
3825         Add test infrastructure to help test the Device Orientation / Motion permission API.
3826
3827         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3828         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3829         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3830         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3831         * WebKitTestRunner/TestController.cpp:
3832         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3833         (WTR::TestController::createWebViewWithOptions):
3834         (WTR::TestController::resetStateToConsistentValues):
3835         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3836         * WebKitTestRunner/TestController.h:
3837         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3838         * WebKitTestRunner/TestInvocation.cpp:
3839         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3840
3841 2019-03-08  Saam barati  <sbarati@apple.com>
3842
3843         Add a compare-results script to compare benchmark results
3844         https://bugs.webkit.org/show_bug.cgi?id=195486
3845         <rdar://problem/48723397>
3846
3847         Reviewed by Geoffrey Garen.
3848
3849         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3850         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3851         to extend it to learn about our other benchmarks.
3852
3853         * Scripts/compare-results: Added.
3854         (readJSONFile):
3855         (detectJetStream2):
3856         (JetStream2Results):
3857         (detectSpeedometer2):
3858         (Speedometer2Results):
3859         (detectPLT5):
3860         (PLT5Results):
3861         (detectBenchmark):
3862         (biggerIsBetter):
3863         (ttest):
3864         (getOptions):
3865         (main):
3866
3867 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3868
3869         Ensure old tab state is cleared between iterations of run-benchmark
3870         https://bugs.webkit.org/show_bug.cgi?id=195393
3871         <rdar://problem/46885583>
3872
3873         Reviewed by Dewei Zhu.
3874
3875         a) ensure the default to restore state is not set
3876         b) terminate Safari correctly
3877         c) Set the system default to ignore Persistent State in Safari
3878
3879         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3880         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3881         (OSXBrowserDriver.prepare_env): 
3882         (OSXBrowserDriver.restore_env):
3883         (OSXBrowserDriver.close_browsers):
3884         (OSXBrowserDriver._terminate_processes):
3885         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3886         (OSXChromeDriver):
3887         (OSXChromeCanaryDriver):
3888         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3889         (OSXFirefoxDriver):
3890         (OSXFirefoxNightlyDriver):
3891         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3892         (OSXSafariDriver):
3893         (OSXSafariDriver.prepare_env):
3894
3895 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3896
3897         [GTK] Several InputMethodFilter tests are failing
3898         https://bugs.webkit.org/show_bug.cgi?id=195408
3899
3900         Reviewed by Carlos Garcia Campos.
3901
3902         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3903         Regressed in r241751.
3904         Hexadecimal values of keycodes are expressed now in upper letters.
3905         Composited characters should be cast to UTF8 strings.
3906
3907         (TestWebKitAPI::TEST):
3908
3909 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3910
3911         [GTK] Make Tools/gtkdoc python3 compatible
3912         https://bugs.webkit.org/show_bug.cgi?id=195359
3913
3914         Reviewed by Carlos Garcia Campos.
3915
3916         * gtkdoc/generate-gtkdoc:
3917         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3918         work with Python 2 and 3.
3919         (get_gtkdoc_module_paths):
3920         The iteritems() was removed in Python 3, so let's use items() that's
3921         available in Python 2 and 3.
3922         (get_generator_for_config):
3923         * gtkdoc/gtkdoc.py:
3924         (GTKDoc._run_command):
3925         The sys.stdout.write() is expecting str in Python 3 and not bytes
3926         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3927         for passing the bytes there.
3928
3929 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3930
3931         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3932         https://bugs.webkit.org/show_bug.cgi?id=195346
3933         <rdar://problem/48667048>
3934
3935         Unreviewed build fix for clang-cl.
3936
3937         * DumpRenderTree/win/DumpRenderTree.cpp:
3938         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3939
3940 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3941
3942         requestAnimationFrame should execute before the next frame
3943         https://bugs.webkit.org/show_bug.cgi?id=177484
3944
3945         Reviewed by Simon Fraser.
3946
3947         Add trace points for the page RenderingUpdate.
3948
3949         * Tracing/SystemTracePoints.plist:
3950
3951 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3952
3953         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3954         https://bugs.webkit.org/show_bug.cgi?id=195353
3955         <rdar://problem/48626394>
3956
3957         Reviewed by Simon Fraser.
3958
3959         * WebKitTestRunner/ios/TestControllerIOS.mm:
3960         (WTR::TestController::platformResetPreferencesToConsistentValues):
3961
3962 2019-03-07  John Wilander  <wilander@apple.com>
3963
3964         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3965         https://bugs.webkit.org/show_bug.cgi?id=195383
3966         <rdar://problem/48570136>
3967
3968         Reviewed by Brent Fulgham.
3969
3970         This patch adds test infrastructure to purge only script-accessible cookies,
3971         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3972
3973         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3974         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3975         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3976         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3977         * WebKitTestRunner/TestController.cpp:
3978         (WTR::TestController::statisticsDeleteCookiesForHost):
3979         * WebKitTestRunner/TestController.h:
3980         * WebKitTestRunner/TestInvocation.cpp:
3981         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3982
3983 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3984
3985         Unreviewed, rolling out r242354.
3986         https://bugs.webkit.org/show_bug.cgi?id=195402
3987
3988         breaks layout tests in all configurations (Requested by
3989         zdobersek on #webkit).
3990
3991         Reverted changeset:
3992
3993         "[WPE] Enable web process sandbox"
3994         https://bugs.webkit.org/show_bug.cgi?id=195169
3995         https://trac.webkit.org/changeset/242354
3996
3997 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3998
3999         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4000         https://bugs.webkit.org/show_bug.cgi?id=195346
4001
4002         Reviewed by Fujii Hironori.
4003
4004         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
4005         (TestWebKitAPI::TEST):
4006         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
4007
4008         * DumpRenderTree/win/DumpRenderTree.cpp:
4009         (findFontFallback):
4010         (addFontFallbackIfPresent):
4011         (removeFontFallbackIfPresent):
4012         (main):
4013         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4014         (TestWebKitAPI::Util::moduleDirectory):
4015         (TestWebKitAPI::Util::createInjectedBundlePath):
4016         Use wchar helpers as needed.
4017
4018 2019-03-06  Rob Buis  <rbuis@igalia.com>
4019
4020         Consider supporting the `referrerpolicy` attribute.
4021         https://bugs.webkit.org/show_bug.cgi?id=179053
4022
4023         Reviewed by Darin Adler.
4024
4025         Add a runtime flag for referrerpolicy attribute.
4026
4027         * DumpRenderTree/mac/DumpRenderTree.mm:
4028         (enableExperimentalFeatures):
4029
4030 2019-03-05  Daniel Bates  <dabates@apple.com>
4031
4032         Update expected API test result following r242379
4033         (https://bugs.webkit.org/show_bug.cgi?id=195125)
4034
4035         Update expected x-coordinate of selection rect now that the left padding of
4036         a textarea is sized in ems (so dependent on the font size) just like the left
4037         padding of a text field.
4038
4039         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4040         (TestWebKitAPI::TEST):
4041
4042 2019-03-05  David Quesada  <david_quesada@apple.com>
4043
4044         [WK2] It should be possible to follow links with 'download' attributes
4045         https://bugs.webkit.org/show_bug.cgi?id=195145
4046         rdar://problem/48462642
4047
4048         Reviewed by Alex Christensen.
4049
4050         Add a unit test to verify that activating links with 'download' attributes now
4051         navigates to the linked resource, rather than starts downloading it. Add another
4052         to verify that it is still possible to explicitly download the link via the
4053         'Download' navigation action policy.
4054
4055         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4056         (-[DownloadAttributeTestDelegate init]):
4057         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
4058         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
4059         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
4060         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
4061         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4062         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
4063         (TEST):
4064         * WebKitTestRunner/TestController.cpp:
4065         (WTR::TestController::decidePolicyForNavigationAction):
4066         * WebKitTestRunner/TestController.h:
4067
4068 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
4069
4070         [Curl] Implement Cookie Accept Policy.
4071         https://bugs.webkit.org/show_bug.cgi?id=191645
4072
4073         Reviewed by Fujii Hironori.
4074
4075         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4076         (TestWebKitAPI::Curl::TEST_F):
4077
4078 2019-03-05  Youenn Fablet  <youenn@apple.com>
4079
4080         Rename requestCacheStorageSpace to requestStorageSpace
4081         https://bugs.webkit.org/show_bug.cgi?id=195282
4082
4083         Reviewed by Chris Dumez.
4084
4085         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4086         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4087         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
4088
4089 2019-03-05  Brady Eidson  <beidson@apple.com>
4090
4091         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
4092         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
4093
4094         Reviewed by Tim Horton.
4095
4096         Loading a file: URL into a WKWebView and then loading another file: url from a completely
4097         different directory into that same WKWebView should work.
4098
4099         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4100         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
4101
4102 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
4103
4104         Add WeakHashSet
4105         https://bugs.webkit.org/show_bug.cgi?id=195152
4106
4107         Reviewed by Antti Koivisto.
4108
4109         Added tests for WeakHashSet.
4110
4111         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4112         (TestWebKitAPI::Base::Base): Moved.
4113         (TestWebKitAPI::Derived::foo): Moved.
4114         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
4115         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
4116         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
4117         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
4118
4119 2019-03-04  Chris Dumez  <cdumez@apple.com>
4120
4121         Do not share WebProcesses between private and regular sessions
4122         https://bugs.webkit.org/show_bug.cgi?id=195189
4123         <rdar://problem/48421064>
4124
4125         Reviewed by Alex Christensen.
4126
4127         Add API test coverage.
4128
4129         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4130         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4131
4132 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
4133
4134         [WPE] Enable web process sandbox
4135         https://bugs.webkit.org/show_bug.cgi?id=195169
4136
4137         Reviewed by Daniel Bates.
4138
4139         * wpe/install-dependencies:
4140         * wpe/jhbuild.modules:
4141
4142 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4143
4144         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
4145         https://bugs.webkit.org/show_bug.cgi?id=195206
4146
4147         Reviewed by Žan Doberšek.
4148
4149         Add a new test case.
4150
4151         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4152         (testJSCClass):
4153
4154 2019-03-04  Charlie Turner  <cturner@igalia.com>
4155
4156         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
4157         https://bugs.webkit.org/show_bug.cgi?id=194898
4158
4159         Reviewed by Žan Doberšek.
4160
4161         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
4162         a GCC extension that permits arithmetic on void* pointer. Inline
4163         the macro until this issue is fixed upstream.
4164
4165 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4166
4167         Rid the world of WK_API_ENABLED
4168         https://bugs.webkit.org/show_bug.cgi?id=195263
4169
4170         Reviewed by Dan Bernstein.
4171
4172         List of changed files elided because it's useless.
4173
4174 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4175
4176         Unreviewed follow-up to r242292.
4177
4178         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4179
4180         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4181         (TestWebKitAPI::testStrip): Renamed from strip.
4182         (TestWebKitAPI::TEST):
4183
4184 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4185
4186         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4187
4188         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4189         and bug #194272 for details.
4190
4191         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4192
4193 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4194
4195         Remove some more unused 32-bit code
4196         https://bugs.webkit.org/show_bug.cgi?id=195255
4197
4198         Reviewed by Darin Adler.
4199
4200         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4201         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4202         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4203         (NPP_New):
4204         (NPP_HandleEvent):
4205         (handleEventCarbon): Deleted.
4206
4207 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4208
4209         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4210
4211         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4212         (TestWebKitAPI::TEST):
4213
4214 2019-03-01  Darin Adler  <darin@apple.com>
4215
4216         Finish removing String::format
4217         https://bugs.webkit.org/show_bug.cgi?id=194893
4218
4219         Reviewed by Daniel Bates.
4220 '
4221         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4222
4223 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4224
4225         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4226         https://bugs.webkit.org/show_bug.cgi?id=195229
4227         <rdar://problem/48520362>
4228
4229         Reviewed by Chris Dumez.
4230
4231         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4232         (TEST):
4233
4234 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4235
4236         Add a system trace scope for event region building
4237         https://bugs.webkit.org/show_bug.cgi?id=195226
4238
4239         Reviewed by Jon Lee.
4240
4241         This trace scope measures the time spend converting element rects into Region objects,
4242         which can be large on some pages.
4243
4244         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4245
4246         * Tracing/SystemTracePoints.plist:
4247
4248 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4249
4250         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4251         https://bugs.webkit.org/show_bug.cgi?id=194612
4252
4253         Reviewed by Alex Christensen.
4254
4255         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4256         Just test the new string-processing function and don't touch the actual environment.
4257         (Test cases are all as before, but based on operator== instead of strcmp.)
4258
4259 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4260
4261         [ews-app] Update primary keys for handling multiple Buildbot instances
4262         https://bugs.webkit.org/show_bug.cgi?id=195120
4263
4264         Reviewed by Stephanie Lewis.
4265
4266         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4267         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4268         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4269
4270         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4271         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4272         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4273         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4274         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4275         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4276
4277 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4278
4279         [WinCairo] Enable service worker
4280         https://bugs.webkit.org/show_bug.cgi?id=188318
4281
4282         Reviewed by Youenn Fablet.
4283
4284         * DumpRenderTree/DumpRenderTreePrefix.h:
4285         * TestWebKitAPI/PlatformWin.cmake:
4286         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4287         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4288         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4289
4290 2019-03-01  Justin Fan  <justin_fan@apple.com>
4291
4292         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4293         https://bugs.webkit.org/show_bug.cgi?id=195191
4294
4295         Rubber-stamped by Dean Jackson.
4296
4297         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4298
4299         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4300
4301 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4302
4303         Unreviewed, fix lldb webkitpy tests
4304         https://bugs.webkit.org/show_bug.cgi?id=194375
4305
4306         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4307
4308         * lldb/lldb_webkit.py:
4309         (WTFStringImplProvider.is_8bit):
4310
4311 2019-02-28  David Quesada  <david_quesada@apple.com>
4312
4313         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4314         https://bugs.webkit.org/show_bug.cgi?id=195121
4315         rdar://problem/48450302
4316
4317         Reviewed by Alex Christensen.
4318
4319         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4320         configurations where the 'download' attribute is absent, blank, or populated
4321         with a filename, and where the anchor element is same-origin or cross-origin
4322         (meaning the 'download' attribute shouldn't be honored).
4323
4324         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4325         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4326         (-[NavigationActionTestDelegate init]):
4327         (-[NavigationActionTestDelegate navigationAction]):
4328         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4329         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4330         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4331         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4332         (TEST):
4333
4334 2019-02-28  Antoine Quint  <graouts@apple.com>
4335
4336         Enable the Pointer Events runtime flag by default
4337         https://bugs.webkit.org/show_bug.cgi?id=195156
4338
4339         Reviewed by Dean Jackson.
4340
4341         * DumpRenderTree/mac/DumpRenderTree.mm:
4342         (enableExperimentalFeatures):
4343
4344 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4345
4346         Several PasteImage API tests are flaky
4347         https://bugs.webkit.org/show_bug.cgi?id=195160
4348
4349         Reviewed by Tim Horton.
4350
4351         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4352         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4353         listening for a "load" event after image load is already complete.
4354
4355         To address this, make these tests first register a "load" event handler, then run script to insert an image
4356         element into the document, and finally wait until the load event is observed before checking image size.
4357
4358         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4359