Improve the Inline Cache Stats code
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-11  Michael Saboff  <msaboff@apple.com>
2
3         Improve the Inline Cache Stats code
4         https://bugs.webkit.org/show_bug.cgi?id=196836
5
6         Reviewed by Saam Barati.
7
8         Added a new script to consolidate and arrange the output of --useICStats option.
9
10         This script merges the output from every group into one large table and sorts it from most common to
11         least common.  It also counts the slow path GetById and PutById variants and then calculates the
12         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
13         Put together, this is useful to see what property accesses are not getting cached.
14
15         * Scripts/ic-stats.py: Added.
16         (ICStats):
17         (ICStats.__init__):
18         (ICStats.parse):
19         (ICStats.dumpStats):
20         (usage):
21
22 2019-04-10  Alex Christensen  <achristensen@webkit.org>
23
24         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
25         https://bugs.webkit.org/show_bug.cgi?id=196809
26         <rdar://49800762>
27
28         Reviewed by Brady Eidson.
29
30         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
31         (TEST):
32
33 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
34
35         requestAnimationFrame should execute before the next frame
36         https://bugs.webkit.org/show_bug.cgi?id=177484
37
38         Reviewed by Simon Fraser.
39
40         Add trace points for the page RenderingUpdate.
41
42         * Tracing/SystemTracePoints.plist:
43
44 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
45
46         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
47         https://bugs.webkit.org/show_bug.cgi?id=196760
48
49         Reviewed by Don Olmstead.
50
51         vswhere.exe has been bundled since Visual Studio 2017 version
52         15.2. We shouldn't download vswhere.exe.
53
54         * Scripts/build-jsc: Do not call update-vswhere.py.
55         * Scripts/build-webkit: Ditto.
56         * Scripts/update-vswhere.py: Removed.
57         * Scripts/webkitdirs.pm:
58         (requireModulesForVSWhere): Deleted.
59         (pickCurrentVisualStudioInstallation): Deleted.
60         (visualStudioInstallDirVSWhere): Return the latest installed VS
61         installation path by using the bundled vswhere.exe.
62         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
63         (visualStudioInstallDirFallback): Removed.
64
65 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
66
67         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
68         https://bugs.webkit.org/show_bug.cgi?id=196780
69
70         Reviewed by Alexey Proskuryakov.
71
72         * BuildSlaveSupport/ews-build/steps.py:
73         * BuildSlaveSupport/ews-build/steps_unittest.py:
74
75 2019-04-10  Alex Christensen  <achristensen@webkit.org>
76
77         Add SPI WKNavigationResponse._downloadAttribute
78         https://bugs.webkit.org/show_bug.cgi?id=196755
79         <rdar://49587365>
80
81         Reviewed by Brady Eidson.
82
83         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
84         (-[NavigationResponseTestDelegate navigationResponse]):
85         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
86         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
87         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
88         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
89         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
90         (readRequest):
91         (writeResponse):
92         (TEST):
93
94 2019-04-10  Tim Horton  <timothy_horton@apple.com>
95
96         Add modern API for overriding the page's specified viewport configuration
97         https://bugs.webkit.org/show_bug.cgi?id=167734
98         <rdar://problem/30331795>
99
100         Reviewed by Simon Fraser.
101
102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
103         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
104
105 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
106
107         Add support for incremental bytecode cache updates
108         https://bugs.webkit.org/show_bug.cgi?id=195000
109
110         Reviewed by Filip Pizlo.
111
112         Exit when the initial run to generate bytecode fails.
113
114         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
115
116 2019-04-10  Alex Christensen  <achristensen@webkit.org>
117
118         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
119         https://bugs.webkit.org/show_bug.cgi?id=196744
120         <rdar://49415309>
121
122         Reviewed by Chris Dumez.
123
124         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
125         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
126
127 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
128
129         Add a way to opt into modern compatibility mode in layout tests
130         https://bugs.webkit.org/show_bug.cgi?id=196770
131         <rdar://problem/49777550>
132
133         Reviewed by Antoine Quint.
134
135         Add a new test option to enable modern compatibility mode in layout tests.
136
137         * WebKitTestRunner/TestController.cpp:
138         (WTR::updateTestOptionsFromTestHeader):
139         * WebKitTestRunner/TestController.h:
140         * WebKitTestRunner/TestOptions.h:
141         (WTR::TestOptions::hasSameInitializationOptions const):
142         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
143         (WTR::TestController::platformCreateWebView):
144         (WTR::TestController::enableModernCompatibilityMode):
145
146 2019-04-10  Andy Estes  <aestes@apple.com>
147
148         Try to fix the 32-bit watchOS build.
149
150         * TestWebKitAPI/cocoa/TestWKWebView.mm:
151         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
152
153 2019-04-10  Antoine Quint  <graouts@apple.com>
154
155         Enable Pointer Events on watchOS
156         https://bugs.webkit.org/show_bug.cgi?id=196771
157         <rdar://problem/49040909>
158
159         Reviewed by Dean Jackson.
160
161         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
162
163 2019-04-10  Philippe Normand  <pnormand@igalia.com>
164
165         Unreviewed. Fix WPE accessibility tests after r244059.
166
167         We are failing to load the injected bundle due to undefined symbol
168         AccessibilityUIElement::replaceTextInRange().
169
170         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
171         (WTR::AccessibilityUIElement::replaceTextInRange):
172
173 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
174
175         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
176         https://bugs.webkit.org/show_bug.cgi?id=196727
177
178         Reviewed by Fujii Hironori.
179
180         * MiniBrowser/win/WebKitBrowserWindow.cpp:
181         (WebKitBrowserWindow::create):
182
183 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
184
185         [ews-build] Add unit tests for PrintConfiguration
186         https://bugs.webkit.org/show_bug.cgi?id=196752
187
188         Reviewed by Dewei Zhu.
189
190         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
191
192 2019-04-09  Keith Rollin  <krollin@apple.com>
193
194         Unreviewed build maintenance -- update .xcfilelists.
195
196         * DumpRenderTree/DerivedSources-input.xcfilelist:
197         * DumpRenderTree/DerivedSources-output.xcfilelist:
198
199 2019-04-09  Zalan Bujtas  <zalan@apple.com>
200
201         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
202         https://bugs.webkit.org/show_bug.cgi?id=196743
203         <rdar://problem/43897551>
204
205         Reviewed by Tim Horton.
206
207         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
208         (TEST):
209
210 2019-04-09  Youenn Fablet  <youenn@apple.com>
211
212         Close service worker database on network process suspension
213         https://bugs.webkit.org/show_bug.cgi?id=196623
214         <rdar://problem/48930869>
215
216         Reviewed by Alex Christensen.
217
218         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
219
220 2019-04-09  Daniel Bates  <dabates@apple.com>
221
222         [iPad] Should open popover when the spacebar is pressed
223         https://bugs.webkit.org/show_bug.cgi?id=196360
224         <rdar://problem/49389129>
225
226         Reviewed by Brent Fulgham.
227
228         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
229
230         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
231         (WTR::UIScriptController::isShowingPopover const): Added.
232         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
233         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
234         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
235         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
236         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
237         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
238         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
239         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
240         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
241         (WTR::UIScriptController::isShowingPopover const): Added.
242         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
243         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
244         * TestRunnerShared/UIScriptContext/UIScriptController.h:
245         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
246         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
247         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
248         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
249         (-[TestRunnerWKWebView _willPresentPopover]): Added.
250         (-[TestRunnerWKWebView _didDismissPopover]): Added.
251         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
252         (WTR::UIScriptController::isShowingPopover const): Added.
253         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
254         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
255
256 2019-04-09  Alex Christensen  <achristensen@webkit.org>
257
258         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
259         https://bugs.webkit.org/show_bug.cgi?id=196665
260         <rdar://45115669>
261
262         Reviewed by Geoff Garen.
263
264         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
265         (goBack):
266         (+[SimpleLookupContext sharedLookupContext]):
267         (-[SimpleLookupContext lookUpURL:completionHandler:]):
268         (TEST):
269         (+[Simple3LookupContext sharedLookupContext]): Deleted.
270         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
271
272 2019-04-09  John Wilander  <wilander@apple.com>
273
274         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
275         https://bugs.webkit.org/show_bug.cgi?id=196558
276         <rdar://problem/47650245>
277
278         Reviewed by Youenn Fablet.
279
280         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
281         (TestWebKitAPI::TEST):
282             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
283
284 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
285
286         [CMake] Apple builds should use ICU_INCLUDE_DIRS
287         https://bugs.webkit.org/show_bug.cgi?id=196720
288
289         Reviewed by Konstantin Tokarev.
290
291         * TestWebKitAPI/PlatformMac.cmake:
292
293 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
294
295         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
296         https://bugs.webkit.org/show_bug.cgi?id=196694
297         <rdar://problem/48388734>
298
299         Rubber-stamped by Aakash Jain.
300
301         * Scripts/webkitpy/port/image_diff.py:
302         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
303         * Scripts/webkitpy/port/server_process.py:
304         (ServerProcess.has_available_stdout): Check if stdout has data in it.
305         (ServerProcess._wait_for_data_and_update_buffers_using_select):
306         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
307         * Scripts/webkitpy/port/server_process_mock.py:
308         (MockServerProcess.has_available_stdout):
309         * Scripts/webkitpy/port/server_process_unittest.py:
310         (TestServerProcess.serial_test_basic):
311
312 2019-04-09  Jer Noble  <jer.noble@apple.com>
313
314         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
315         https://bugs.webkit.org/show_bug.cgi?id=196097
316
317         Reviewed by Eric Carlson.
318
319         Drive-by bug fix: allow tests to play audio without a user gesture by default.
320
321         * DumpRenderTree/mac/DumpRenderTree.mm:
322         (resetWebPreferencesToConsistentValues):
323         * WebKitTestRunner/TestController.cpp:
324         (WTR::TestController::resetPreferencesToConsistentValues):
325
326 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
327
328         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
329         https://bugs.webkit.org/show_bug.cgi?id=196690
330
331         Reviewed by Michael Catanzaro.
332
333         * QueueStatusServer/config/queues.py:
334         * Scripts/webkitpy/common/config/ews.json:
335         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
336         (test_ews_name):
337
338 2019-04-09  Chris Dumez  <cdumez@apple.com>
339
340         Loads using loadHTMLString() cause flashing when process-swapping
341         https://bugs.webkit.org/show_bug.cgi?id=196714
342         <rdar://problem/49637354>
343
344         Reviewed by Antti Koivisto.
345
346         Add API test coverage.
347
348         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
349
350 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
351
352         Unreviewed. Fix ATK accessibility tests after r244059.
353
354         We are failing to load the injected bundle due to undefined symbol
355         AccessibilityUIElement::replaceTextInRange().
356
357         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
358         (WTR::AccessibilityUIElement::replaceTextInRange):
359
360 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
361
362         AX: Support API: accessibilityReplaceRange:withText
363         https://bugs.webkit.org/show_bug.cgi?id=196636
364
365         Unreviewed build fix for Windows port.
366
367         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
368         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
369
370 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
371
372         [CMake][WinCairo] Separate copied headers into different directories
373         https://bugs.webkit.org/show_bug.cgi?id=196655
374
375         Reviewed by Michael Catanzaro.
376
377         * DumpRenderTree/CMakeLists.txt:
378         * MiniBrowser/win/CMakeLists.txt:
379         * TestWebKitAPI/CMakeLists.txt:
380         * TestWebKitAPI/PlatformWin.cmake:
381
382 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
383
384         Log stack-trace for run-webkit-tests when interrupted
385         https://bugs.webkit.org/show_bug.cgi?id=176393
386         <rdar://problem/34262310>
387
388         Reviewed by Lucas Forschler.
389
390         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
391         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
392         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
393         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
394         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
395         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
396         (main): Set handlers to log stack trace on interruption.
397
398 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
399
400         AX: Support API: accessibilityReplaceRange:withText
401         https://bugs.webkit.org/show_bug.cgi?id=196636
402
403         Unreviewed build fix for Windows port.
404
405         * DumpRenderTree/AccessibilityUIElement.cpp:
406         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
407
408 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
409
410         [ews-build] Scripts using Buildbot API have CORS error
411         https://bugs.webkit.org/show_bug.cgi?id=196709
412
413         Reviewed by Alexey Proskuryakov.
414
415         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
416
417 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
418
419         AX: Support API: accessibilityReplaceRange:withText
420         https://bugs.webkit.org/show_bug.cgi?id=196636
421
422         Reviewed by Daniel Bates.
423
424         * DumpRenderTree/AccessibilityUIElement.cpp:
425         (replaceTextInRangeCallback):
426         (AccessibilityUIElement::replaceTextInRange):
427         (AccessibilityUIElement::getJSClass):
428         * DumpRenderTree/AccessibilityUIElement.h:
429         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
430         (AccessibilityUIElement::replaceTextInRange):
431         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
432         (AccessibilityUIElement::replaceTextInRange):
433         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
434         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
435         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
436         (WTR::AccessibilityUIElement::replaceTextInRange):
437         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
438         (WTR::AccessibilityUIElement::replaceTextInRange):
439
440 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
441
442         [iOS] Do not allow starting selection drags when selection views are not visible
443         https://bugs.webkit.org/show_bug.cgi?id=196686
444         <rdar://problem/49399192>
445
446         Reviewed by Tim Horton.
447
448         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
449         also add some new API tests to cover scenarios where the web view is not first responder.
450
451         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
452         (TestWebKitAPI::TEST):
453         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
454
455         Add a switch to optionally make the web view first responder when starting the simulated drag.
456
457         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
458         (-[DragAndDropSimulator initWithWebView:]):
459         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
460
461 2019-04-08  Justin Fan  <justin_fan@apple.com>
462
463         [Web GPU] Fix Web GPU experimental feature on iOS
464         https://bugs.webkit.org/show_bug.cgi?id=196632
465
466         Reviewed by Myles C. Maxfield.
467
468         Properly make Web GPU available on iOS 11+.
469
470         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
471
472 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
473
474         [ews-build] Do not upload archive when Compile Fails
475         https://bugs.webkit.org/show_bug.cgi?id=196674
476
477         Reviewed by Alexey Proskuryakov.
478
479         * BuildSlaveSupport/ews-build/factories.py:
480         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
481         * BuildSlaveSupport/ews-build/steps.py:
482         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
483         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
484         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
485
486 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
487
488         Enable DFG on MIPS
489         https://bugs.webkit.org/show_bug.cgi?id=196689
490
491         Reviewed by Žan Doberšek.
492
493         Since the bytecode change, we enabled the baseline JIT on mips in
494         r240432, but DFG is still missing. With this change, all tests are
495         passing on a ci20 board.
496
497         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
498
499 2019-04-08  Philippe Normand  <pnormand@igalia.com>
500
501         [Flatpak] Second run update-webkitwpe-flatpak fails
502         https://bugs.webkit.org/show_bug.cgi?id=192702
503
504         Reviewed by Carlos Garcia Campos.
505
506         * flatpak/flatpakutils.py:
507         (FlatpakObject.flatpak): Fix typo.
508         (FlatpakPackage.install): When installing, also update to the configured remote commit.
509         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
510
511 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
512
513         [GTK][WPE] outlook.live.com displays old-fashioned UI
514         https://bugs.webkit.org/show_bug.cgi?id=196642
515
516         Reviewed by Carlos Garcia Campos.
517
518         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
519         (TestWebKitAPI::TEST): New Mac platform quirk test.
520
521 2019-04-07  Commit Queue  <commit-queue@webkit.org>
522
523         Unreviewed, rolling out r243956.
524         https://bugs.webkit.org/show_bug.cgi?id=196688
525
526         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
527         by aakashjain on #webkit).
528
529         Reverted changeset:
530
531         "Clicking "Go Back" from a safe browsing warning from an
532         iframe should navigate the WKWebView back to the previous
533         page"
534         https://bugs.webkit.org/show_bug.cgi?id=196665
535         https://trac.webkit.org/changeset/243956
536
537 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
538
539         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
540         https://bugs.webkit.org/show_bug.cgi?id=196669
541
542         Reviewed by Geoffrey Garen.
543
544         Added three new unit tests for WeakHashSet.
545
546         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
547         (WTF_WeakPtr.WeakHashSetConstObjects):
548         (WTF_WeakPtr.WeakHashSetComputesEmpty):
549         (WTF_WeakPtr.WeakHashSetComputeSize):
550
551 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
552
553         Hide next and previous form control buttons when WKWebView is editable
554         https://bugs.webkit.org/show_bug.cgi?id=196672
555         <rdar://problem/35625321>
556
557         Reviewed by Tim Horton.
558
559         Add a new API test.
560
561         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
562         (-[TestWKWebView lastTrailingBarButtonGroup]):
563         (TestWebKitAPI::TEST):
564         * TestWebKitAPI/ios/UIKitSPI.h:
565
566 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
567
568         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
569         https://bugs.webkit.org/show_bug.cgi?id=196077
570         <rdar://problem/49108202>
571
572         Reviewed by Chris Dumez.
573
574         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
575         on new web view.
576
577         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
578
579 2019-04-05  Saam Barati  <sbarati@apple.com>
580
581         Make compare-results understand MotionMark
582         https://bugs.webkit.org/show_bug.cgi?id=196666
583
584         Reviewed by Yusuke Suzuki.
585
586         * Scripts/compare-results:
587         (PLT5Results):
588         (detectMotionMark):
589         (detectMotionMark1_1):
590         (motionMarkResults):
591         (motionMark1_1Results):
592         (detectBenchmark):
593         (biggerIsBetter):
594         (main):
595
596 2019-04-05  Alex Christensen  <achristensen@webkit.org>
597
598         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
599         https://bugs.webkit.org/show_bug.cgi?id=196665
600         <rdar://45115669>
601
602         Reviewed by Geoff Garen.
603
604         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
605         (goBack):
606         (+[SimpleLookupContext sharedLookupContext]):
607         (-[SimpleLookupContext lookUpURL:completionHandler:]):
608         (TEST):
609         (+[Simple3LookupContext sharedLookupContext]): Deleted.
610         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
611
612 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
613
614         [ews-build] Add configuration and architecture for windows builders
615         https://bugs.webkit.org/show_bug.cgi?id=196660
616
617         Reviewed by Lucas Forschler.
618
619         * BuildSlaveSupport/ews-build/config.json:
620
621 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
622
623         webkitpy: Don't run subsequent rounds if interrupted
624         https://bugs.webkit.org/show_bug.cgi?id=196646
625
626         Reviewed by Aakash Jain.
627
628         * Scripts/webkitpy/layout_tests/controllers/manager.py:
629         (Manager.run): Bail out if interrupted.
630
631 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
632
633         Test sessionStorage in PSON private browsing mode
634         https://bugs.webkit.org/show_bug.cgi?id=196561
635
636         Reviewed by Alex Christensen.
637
638         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
639
640 2019-04-05  Commit Queue  <commit-queue@webkit.org>
641
642         Unreviewed, rolling out r243833.
643         https://bugs.webkit.org/show_bug.cgi?id=196645
644
645         This change breaks build of WPE and GTK ports (Requested by
646         annulen on #webkit).
647
648         Reverted changeset:
649
650         "[CMake][WTF] Mirror XCode header directories"
651         https://bugs.webkit.org/show_bug.cgi?id=191662
652         https://trac.webkit.org/changeset/243833
653
654 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
655
656         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
657         https://bugs.webkit.org/show_bug.cgi?id=196635
658
659         Reviewed by Antti Koivisto.
660         
661         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
662         for a test to enable async frame scrolling via:
663             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
664         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
665         
666         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
667
668         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
669         (WTR::InjectedBundle::beginTesting):
670         * WebKitTestRunner/TestController.cpp:
671         (WTR::TestController::resetPreferencesToConsistentValues):
672
673 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
674
675         Use a correct LC_RPATH when building with ASan
676         https://bugs.webkit.org/show_bug.cgi?id=196576
677
678         Reviewed by David Kilzer.
679
680         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
681         so that ../Frameworks is checked. This is simpler and more reliable than updating
682         each SPC service xcconfig.
683
684 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
685
686         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
687         https://bugs.webkit.org/show_bug.cgi?id=196629
688
689         Reviewed by Lucas Forschler.
690
691         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
692
693 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
694
695         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
696         https://bugs.webkit.org/show_bug.cgi?id=196618
697
698         Reviewed by Lucas Forschler.
699
700         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
701         (StatusBubble): Added QUEUE_TRIGGERS.
702         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
703         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
704         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
705         its parent(builder).
706
707 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
708
709         [ews-app] Status-bubble steps are sometimes displayed in reverse order
710         https://bugs.webkit.org/show_bug.cgi?id=196625
711
712         Reviewed by Lucas Forschler.
713
714         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
715         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
716
717 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
718
719         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
720         https://bugs.webkit.org/show_bug.cgi?id=196630
721
722         Reviewed by Wenson Hsieh.
723
724         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
725
726 2019-04-04  Youenn Fablet  <youenn@apple.com>
727
728         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
729         https://bugs.webkit.org/show_bug.cgi?id=196543
730
731         Reviewed by Alex Christensen.
732
733         * WebKitTestRunner/TestController.cpp:
734         (WTR::TestController::generatePageConfiguration):
735
736 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
737
738         [ews-app] Status bubble should not display skipped buildbot steps
739         https://bugs.webkit.org/show_bug.cgi?id=196584
740
741         Reviewed by Lucas Forschler.
742
743         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
744
745 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
746
747         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
748         https://bugs.webkit.org/show_bug.cgi?id=196620
749
750         Reviewed by Lucas Forschler.
751
752         * BuildSlaveSupport/ews-app/ews/config.py:
753
754 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
755
756         [Win] DumpRenderTreeWatchDog.py is not checked into source
757         https://bugs.webkit.org/show_bug.cgi?id=196567
758         <rdar://problem/49525901>
759
760         Reviewed by Lucas Forschler.
761
762         This script is used on Win EWS bots to terminate hanging DRT processes.
763
764         * EWSTools/dumprendertreewatchdog.py: Added.
765
766 2019-04-04  Chris Dumez  <cdumez@apple.com>
767
768         Unreviewed, roll out r243858 which made tests time out.
769
770         Disable new API tests on Windows instead.
771
772         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
773         (TestWebKitAPI::TEST):
774
775 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
776
777         [ATK] Cleanup WebPageAccessibilityObjectAtk
778         https://bugs.webkit.org/show_bug.cgi?id=196537
779
780         Reviewed by Michael Catanzaro.
781
782         Also consider files under atk directories as exceptions for GObject conventions.
783
784         * Scripts/webkitpy/style/checkers/cpp.py:
785         (check_identifier_name_in_declaration):
786
787 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
788
789         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
790         https://bugs.webkit.org/show_bug.cgi?id=196588
791         <rdar://problem/49365787>
792
793         Unreviewed build fix for Windows port.
794
795         error C3861: 'kill': identifier not found
796
797         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
798         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
799
800 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
801
802         [ews-build] Cancel build and similar operations should have authentication
803         https://bugs.webkit.org/show_bug.cgi?id=196520
804
805         Reviewed by Dewei Zhu.
806
807         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
808         environment variables.
809
810 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
811
812         [ews-build] Do not trigger queues which are not in production yet
813         https://bugs.webkit.org/show_bug.cgi?id=196581
814
815         Reviewed by Dewei Zhu.
816
817         * BuildSlaveSupport/ews-build/config.json:
818
819 2019-04-03  Chris Dumez  <cdumez@apple.com>
820
821         Unreviewed, fix typo in the name of API test added in r243848.
822
823         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
824         (TestWebKitAPI::TEST):
825
826 2019-04-03  Chris Dumez  <cdumez@apple.com>
827
828         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
829         https://bugs.webkit.org/show_bug.cgi?id=196588
830         <rdar://problem/49365787>
831
832         Reviewed by Ryosuke Niwa.
833
834         Add API test coverage.
835
836         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
837         (TestWebKitAPI::nullJavaScriptCallback):
838         (TestWebKitAPI::didCrashCheckFrames):
839         (TestWebKitAPI::TEST):
840
841 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
842
843         run-webkit-tests: Upload test results (new results database)
844         https://bugs.webkit.org/show_bug.cgi?id=196577
845         <rdar://problem/34841155>
846
847         Reviewed by Lucas Forschler.
848
849         * Scripts/webkitpy/layout_tests/controllers/manager.py:
850         (Manager.run): Upload results after each device shard, since the configuration will be
851         different for each device.
852         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
853         uploaded to a results database.
854         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
855         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
856
857 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
858
859         -apple-trailing-word is needed for browser detection
860         https://bugs.webkit.org/show_bug.cgi?id=196575
861
862         Unreviewed.
863
864         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
865
866 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
867
868         [CMake][WTF] Mirror XCode header directories
869         https://bugs.webkit.org/show_bug.cgi?id=191662
870
871         Reviewed by Konstantin Tokarev.
872
873         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
874         builds.
875
876         * CMakeLists.txt:
877         * DumpRenderTree/CMakeLists.txt:
878         * DumpRenderTree/PlatformWin.cmake:
879         * MiniBrowser/win/CMakeLists.txt:
880         * TestWebKitAPI/CMakeLists.txt:
881         * TestWebKitAPI/PlatformWin.cmake:
882         * WebKitTestRunner/PlatformGTK.cmake:
883         * WebKitTestRunner/PlatformWin.cmake:
884
885 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
886
887         [ews-app] Status bubble should not display certain infrastructure status messages
888         https://bugs.webkit.org/show_bug.cgi?id=196550
889
890         Reviewed by Lucas Forschler.
891
892         Do not display the steps which are un-needed for end-user. This information is still avaiable
893         if the user click on the bubble and look at the Buildbot build.
894         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
895         (StatusBubble._steps_messages):
896         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
897
898 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
899
900         [ews-build] Use https for sending data to ews-app
901         https://bugs.webkit.org/show_bug.cgi?id=196492
902
903         Reviewed by Lucas Forschler.
904
905         * BuildSlaveSupport/ews-build/events.py:
906
907 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
908
909         Remove support for -apple-trailing-word
910         https://bugs.webkit.org/show_bug.cgi?id=196525
911
912         Reviewed by Zalan Bujtas.
913
914         This CSS property is nonstandard and not used.
915
916         * Scripts/webkitperl/FeatureList.pm:
917         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
918
919 2019-04-03  Youenn Fablet  <youenn@apple.com>
920
921         Add a test for DOMCache on multiple browsing in case of private browsing
922         https://bugs.webkit.org/show_bug.cgi?id=196524
923
924         Reviewed by Alex Christensen.
925
926         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
927         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
928
929 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
930
931         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
932         https://bugs.webkit.org/show_bug.cgi?id=196540
933
934         Reviewed by Aakash Jain.
935
936         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
937
938 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
939
940         Add plumbing for a compatibility mode preference in WebKit
941         https://bugs.webkit.org/show_bug.cgi?id=196005
942
943         Reviewed by Tim Horton.
944
945         Add new API tests.
946
947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
948         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
949
950 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
951
952         [WPE][GTK] Update libsrtp dependency package for Debian
953         https://bugs.webkit.org/show_bug.cgi?id=196528
954
955         Reviewed by Frédéric Wang.
956
957         * gtk/install-dependencies:
958         * wpe/install-dependencies:
959
960 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
961
962         [WK2] Add support for Window's beforeprint / afterprint events
963         https://bugs.webkit.org/show_bug.cgi?id=196478
964         <rdar://problem/49535124>
965
966         Unreviewed build fix for MSVC.
967
968         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
969
970         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
971
972         * WebKitTestRunner/TestController.cpp:
973         (WTR::printFrame): Use int and float literals.
974
975 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
976
977         [ews-build] Reassign bots to queues
978
979         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
980
981 2019-04-02  Chris Dumez  <cdumez@apple.com>
982
983         [WK2] Add support for Window's beforeprint / afterprint events
984         https://bugs.webkit.org/show_bug.cgi?id=196478
985
986         Reviewed by Alex Christensen.
987
988         Add minimal implementation for printFrame in WebKitTestRunner.
989
990         * WebKitTestRunner/TestController.cpp:
991         (WTR::printFrame):
992         (WTR::TestController::createOtherPage):
993         (WTR::TestController::createWebViewWithOptions):
994
995 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
996
997         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
998         https://bugs.webkit.org/show_bug.cgi?id=196491
999
1000         Reviewed by Lucas Forschler.
1001
1002         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1003
1004 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1005
1006         [ews-build] Configure buildbot try credentials in environment variables
1007         https://bugs.webkit.org/show_bug.cgi?id=196501
1008
1009         Reviewed by Lucas Forschler.
1010
1011         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1012         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1013         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1014
1015 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1016
1017         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1018         https://bugs.webkit.org/show_bug.cgi?id=196496
1019         <rdar://problem/49521634>
1020
1021         Reviewed by Chris Dumez.
1022
1023         Add new API tests (see WebKit ChangeLog for more detail).
1024
1025         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1026         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1027         (TEST):
1028
1029 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1030
1031         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1032         <https://webkit.org/b/196499>
1033
1034         Reviewed by Alexey Proskuryakov.
1035
1036         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1037         ENABLE_ADDRESS_SANITIZER.
1038
1039 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1040
1041         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1042         https://bugs.webkit.org/show_bug.cgi?id=182757
1043
1044         Reviewed by Don Olmstead.
1045
1046         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1047         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1048
1049 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1050
1051         run-api-tests: Upload test results
1052         https://bugs.webkit.org/show_bug.cgi?id=196323
1053         <rdar://problem/49356714>
1054
1055         Reviewed by Lucas Forschler.
1056
1057         * Scripts/webkitpy/api_tests/manager.py:
1058         (Manager):
1059         (Manager.run): Upload results to a results database.
1060         * Scripts/webkitpy/api_tests/run_api_tests.py:
1061         (parse_args): Add upload arguments.
1062         * Scripts/webkitpy/port/base.py:
1063         (Port):
1064         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1065         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1066         with commits from any other associated repositories.
1067         * Scripts/webkitpy/port/device.py:
1068         (Device):
1069         (Device.build_version): Access build_versoin of underlying platform device.
1070         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1071         (IOSSimulatorTest):
1072         (IOSSimulatorTest.test_configuration_for_upload):
1073         * Scripts/webkitpy/port/device_port.py:
1074         (DevicePort):
1075         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1076         the same as the machine uploading results.
1077         * Scripts/webkitpy/port/mac.py:
1078         (MacPort):
1079         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1080         * Scripts/webkitpy/port/mac_unittest.py:
1081         (MacTest):
1082         (MacTest.test_configuration_for_upload):
1083         * Scripts/webkitpy/xcode/simulated_device.py:
1084         (SimulatedDeviceManager._create_device_with_runtime):
1085         (SimulatedDevice.__init__): Create simulated device with a build_version.
1086         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1087         (test_existing_simulator):
1088
1089 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1090
1091         Remove extra newline characters (Follow-up fix to r243707)
1092
1093         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1094
1095 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1096
1097         [ews-app] Use API_KEY to accept results data
1098         https://bugs.webkit.org/show_bug.cgi?id=196461
1099
1100         Reviewed by Dewei Zhu.
1101
1102         * BuildSlaveSupport/ews-app/ews/views/results.py:
1103         (Results.post): Validate EWS_API_KEY before accepting any data.
1104         * BuildSlaveSupport/ews-build/events.py:
1105         (Events.sendData): Send EWS_API_KEY if available along with event data.
1106
1107 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1108
1109         Unable to copy and paste a PDF from Notes into Mail compose body
1110         https://bugs.webkit.org/show_bug.cgi?id=196442
1111         <rdar://problem/48573098>
1112
1113         Reviewed by Tim Horton.
1114
1115         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1116         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1117         to be specified on the item providers.
1118
1119         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1120         (TestWebKitAPI::mapItemForTesting):
1121         (TestWebKitAPI::contactItemForTesting):
1122
1123 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1124
1125         Make UIWKDocumentContext rects per-character instead of per-word
1126         https://bugs.webkit.org/show_bug.cgi?id=196459
1127
1128         Reviewed by Wenson Hsieh.
1129
1130         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1131         (TEST):
1132         Adjust test results due to switching to per-character rects.
1133
1134 2019-04-01  Chris Dumez  <cdumez@apple.com>
1135
1136         UIProcess crash when a prewarmed process is terminated
1137         https://bugs.webkit.org/show_bug.cgi?id=196451
1138         <rdar://problem/49245471>
1139
1140         Reviewed by Geoffrey Garen.
1141
1142         Add API test coverage.
1143
1144         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1145         (TEST):
1146
1147 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1148
1149         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1150         https://bugs.webkit.org/show_bug.cgi?id=196449
1151
1152         Reviewed by Lucas Forschler.
1153
1154         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1155         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1156         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1157         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1158
1159 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1160
1161         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1162         https://bugs.webkit.org/show_bug.cgi?id=196444
1163
1164         Reviewed by Lucas Forschler.
1165
1166         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1167
1168 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1169
1170         Add SPI to canonicalize NSURLs with WTF::URL
1171         https://bugs.webkit.org/show_bug.cgi?id=196415
1172         <rdar://problem/44980271>
1173
1174         Reviewed by Darin Adler.
1175
1176         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1177         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1178         (TestWebKitAPI::TEST):
1179
1180 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1181
1182         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1183         https://bugs.webkit.org/show_bug.cgi?id=196441
1184
1185         Reviewed by Carlos Garcia Campos.
1186
1187         Don't cache the wpe_view_backend object that might not exist yet at the
1188         time of EventSenderProxy constructor invocation, but instead retrieve
1189         that object whenever it's required for event dispatching. This should
1190         avoid crashes in this constructor now that it's invoked before any
1191         PlatformWindow has been set up (as changed in r243496).
1192
1193         * WebKitTestRunner/EventSenderProxy.h:
1194         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1195         (WTR::viewBackend):
1196         (WTR::EventSenderProxy::EventSenderProxy):
1197         (WTR::EventSenderProxy::mouseDown):
1198         (WTR::EventSenderProxy::mouseUp):
1199         (WTR::EventSenderProxy::mouseMoveTo):
1200         (WTR::EventSenderProxy::mouseScrollBy):
1201         (WTR::EventSenderProxy::keyDown):
1202         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1203
1204 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1205
1206         [Win][WebKit] MiniBrowser should support high DPI display
1207         https://bugs.webkit.org/show_bug.cgi?id=196391
1208
1209         Reviewed by Alex Christensen.
1210
1211         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1212         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1213         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1214         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1215
1216 2019-03-31  Sam Weinig  <weinig@apple.com>
1217
1218         Remove more i386 specific configurations
1219         https://bugs.webkit.org/show_bug.cgi?id=196430
1220
1221         Reviewed by Alexey Proskuryakov.
1222
1223         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1224         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1225
1226 2019-03-31  Andy Estes  <aestes@apple.com>
1227
1228         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1229         https://bugs.webkit.org/show_bug.cgi?id=196433
1230         <rdar://problem/49293305>
1231
1232         Reviewed by Tim Horton.
1233
1234         Enhanced API test coverage to include all navigation response policy decisions in both
1235         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1236
1237         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1238         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1239         (TestWebKitAPI::TEST):
1240         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1241         (readFile):
1242         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1243         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1244         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1245         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1246         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1247         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1248         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1249         (-[QuickLookDelegate _downloadDidStart:]):
1250         (-[QuickLookDelegate _download:didReceiveResponse:]):
1251         (-[QuickLookDelegate _download:didReceiveData:]):
1252         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1253         (-[QuickLookDelegate _downloadDidFinish:]):
1254         (-[QuickLookDelegate _download:didFailWithError:]):
1255         (-[QuickLookDelegate _downloadDidCancel:]):
1256         (-[QuickLookDelegate verifyDownload]):
1257         (runTest):
1258         (runTestDecideBeforeLoading):
1259         (runTestDecideAfterLoading):
1260         (TEST):
1261         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1262         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1263         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1264         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1265         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1266         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1267         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1268         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1269         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1270         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1271         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1272         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1273         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1274         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1275
1276 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1277
1278         [CMake] add testdfg as target with build-jsc
1279         https://bugs.webkit.org/show_bug.cgi?id=196393
1280
1281         Reviewed by Saam Barati.
1282
1283         Added testdfg as one of the targets to build when
1284         using CMake.
1285
1286         * Scripts/build-jsc:
1287
1288 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1289
1290         Delete WebMetal implementation in favor of WebGPU
1291         https://bugs.webkit.org/show_bug.cgi?id=195418
1292
1293         Reviewed by Dean Jackson.
1294
1295         * DumpRenderTree/mac/DumpRenderTree.mm:
1296         (enableExperimentalFeatures):
1297         (resetWebPreferencesToConsistentValues):
1298         * Scripts/webkitperl/FeatureList.pm:
1299         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1301         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1302         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1303         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1304         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1305         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1306         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1307         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1308         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1309         (WTR::InjectedBundle::beginTesting):
1310         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1311         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1312         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1313
1314 2019-03-29  Chris Dumez  <cdumez@apple.com>
1315
1316         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1317         https://bugs.webkit.org/show_bug.cgi?id=196405
1318         <rdar://problem/49428130>
1319
1320         Reviewed by Wenson Hsieh.
1321
1322         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1323         the popover presentation methods to be no-ops. Use this in the new test added in
1324         r243523 so that we do not swizzle those methods for all tests. This is needed because
1325         those WatchOS tests rely on the popover getting presented and interactive.
1326
1327         * WebKitTestRunner/TestController.cpp:
1328         (WTR::updateTestOptionsFromTestHeader):
1329         * WebKitTestRunner/TestController.h:
1330         * WebKitTestRunner/TestOptions.h:
1331         (WTR::TestOptions::hasSameInitializationOptions const):
1332         * WebKitTestRunner/ios/TestControllerIOS.mm:
1333         (WTR::TestController::platformInitialize):
1334         (WTR::TestController::platformResetStateToConsistentValues):
1335
1336 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1337
1338         [Curl] Add Server Trust Evaluation Support.
1339         https://bugs.webkit.org/show_bug.cgi?id=191646
1340
1341         Reviewed by Fujii Hironori.
1342
1343         Implemented MiniBrowser UI for asking if user trusts the server.
1344
1345         * MiniBrowser/win/Common.cpp:
1346         (askServerTrustEvaluation):
1347         (replaceString):
1348         * MiniBrowser/win/Common.h:
1349         * MiniBrowser/win/MiniBrowserLib.rc:
1350         * MiniBrowser/win/MiniBrowserLibResource.h:
1351         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1352         (createPEMString):
1353         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1354         (WebKitBrowserWindow::canTrustServerCertificate):
1355         * MiniBrowser/win/WebKitBrowserWindow.h:
1356
1357 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1358
1359         Implement ResizeObserver.
1360         https://bugs.webkit.org/show_bug.cgi?id=157743
1361
1362         Reviewed by Simon Fraser.
1363
1364         Support resizeObserverEnabled webPreferences.
1365
1366         * DumpRenderTree/TestOptions.cpp:
1367         (TestOptions::TestOptions):
1368         * DumpRenderTree/TestOptions.h:
1369         * DumpRenderTree/mac/DumpRenderTree.mm:
1370         (setWebPreferencesForTestOptions):
1371         * DumpRenderTree/win/DumpRenderTree.cpp:
1372         (enableExperimentalFeatures):
1373         * Scripts/webkitperl/FeatureList.pm:
1374         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1375
1376 2019-03-28  John Wilander  <wilander@apple.com>
1377
1378         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1379         https://bugs.webkit.org/show_bug.cgi?id=196281
1380         <rdar://problem/48938748>
1381
1382         Reviewed by Alex Christensen.
1383
1384         This patch adds the function isStatisticsHasLocalStorage() to the
1385         TestRunner. With it, the page can query the WebsiteDataStore in the
1386         UI process to make sure that it sees LocalStorage.
1387
1388         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1389         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1390         (WTR::TestRunner::isStatisticsHasLocalStorage):
1391         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1392         * WebKitTestRunner/TestController.cpp:
1393         (WTR::TestController::isStatisticsHasLocalStorage):
1394         * WebKitTestRunner/TestController.h:
1395         * WebKitTestRunner/TestInvocation.cpp:
1396         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1397
1398 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1399
1400         API::Data::createWithoutCopying should do a null check before calling CFRelease
1401         https://bugs.webkit.org/show_bug.cgi?id=196276
1402         <rdar://problem/48059859>
1403
1404         Reviewed by Alex Christensen.
1405
1406         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1407
1408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1409         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1410         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1411         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1412         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1413         (TestWebKitAPI::TEST):
1414
1415 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1416
1417         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1418         https://bugs.webkit.org/show_bug.cgi?id=186276
1419
1420         Reviewed by Carlos Garcia Campos.
1421
1422         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1423         (webViewLoadChanged):
1424         (testWebResourceGetDataError):
1425         (testWebResourceGetDataEmpty):
1426         (beforeAll):
1427         (webViewloadChanged): Deleted.
1428
1429 2019-03-27  Andy Estes  <aestes@apple.com>
1430
1431         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1432         https://bugs.webkit.org/show_bug.cgi?id=196317
1433
1434         Reviewed by Dan Bernstein.
1435
1436         package-root copies built products into a staging directory using ditto(1), which does not
1437         follow symbolic links as it traverses a directory. Now that the files in
1438         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1439         itself, these become broken links when ditto'd into the staging directory.
1440
1441         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1442
1443         * Scripts/package-root:
1444
1445 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1446
1447         [ews-app] Update display text of Submit for ews analysis
1448         https://bugs.webkit.org/show_bug.cgi?id=196309
1449
1450         Reviewed by Dewei Zhu.
1451
1452         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1453
1454 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1455
1456         run-webkit-tests should check for leaks in WebKit processes
1457         <https://webkit.org/b/193772>
1458         <rdar://problem/46526680>
1459
1460         Reviewed by Ryosuke Niwa.
1461
1462         This works by doing the following:
1463         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1464           The list of child processes are returned one per line:
1465           process.name: pid
1466         - Run the "#LIST CHILD PROCESSES" command just before the
1467           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1468           processes on the ServerProcess object.
1469         - When the `--leaks` switch is handled, run check_for_leaks() on
1470           each child process after the main test harness.
1471
1472         * DumpRenderTree/mac/DumpRenderTree.mm:
1473         (handleControlCommand):
1474         - Use strncmp() instead of strcmp().
1475         - Add support for handling "#LIST CHILD PROCESSES" command.
1476
1477         * Scripts/webkitpy/port/base.py:
1478         (Port.check_for_leaks):
1479         * Scripts/webkitpy/port/darwin.py:
1480         (DarwinPort.check_for_leaks):
1481         - Rename redundant 'process_pid' argument to 'process_id'.
1482
1483         * Scripts/webkitpy/port/driver.py:
1484         (Driver.do_post_tests_work):
1485         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1486           longer the only command this sends to WebKitTestRunner.
1487         - If the `--leaks` switch is present, send the
1488           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1489           result using Port.set_webkit_processes().
1490         (Driver._parse_child_processes_output):
1491         - Add helper method to parse list of child process names and
1492           process IDs returned from WebKitTestRunner.
1493
1494         * Scripts/webkitpy/port/ios_device.py:
1495         (IOSDevicePort.check_for_leaks):
1496         - Rename redundant 'process_pid' argument to 'process_id'.
1497
1498         * Scripts/webkitpy/port/leakdetector.py:
1499         (LeakDetector._parse_leaks_output):
1500         - Return early if there is no leaks_output.
1501         (LeakDetector.check_for_leaks):
1502         - Rename redundant 'process_pid' argument to 'process_id'.
1503
1504         * Scripts/webkitpy/port/server_process.py:
1505         (ServerProcess.__init__):
1506         (ServerProcess.child_processes):
1507         (ServerProcess.set_child_processes):
1508         - Add instance variable to Port to store list of child process
1509           names and process IDs returned from WebKitTestRunner.
1510         (ServerProcess._start):
1511         - Clear self._child_processes.
1512         (ServerProcess.stop):
1513         - If self._child_processes is set, call
1514           self._port.check_for_leaks() for each child process.
1515
1516         * Scripts/webkitpy/port/server_process_unittest.py:
1517         (TrivialMockPort.check_for_leaks):
1518         - Rename redundant 'process_pid' argument to 'process_id'.
1519
1520         * Scripts/webkitpy/port/simulator_process.py:
1521         (SimulatorProcess.stop):
1522         - If self._child_processes is set, call
1523           self._port.check_for_leaks() for each child process.
1524
1525         * Scripts/webkitpy/port/watch_device.py:
1526         (WatchDevicePort.check_for_leaks):
1527         - Rename redundant 'process_pid' argument to 'process_id'.
1528
1529         * WebKitTestRunner/TestController.cpp:
1530         (WTR::TestController::dumpResponse):
1531         - Extract method from findAndDumpWorldLeaks() so that it may be
1532           reused by findAndDumpWebKitProcessIdentifiers().
1533         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1534         - Add method to output process name and process ID of both the
1535           WebContent and Networking processes.
1536         (WTR::TestController::findAndDumpWorldLeaks):
1537         - Fix missing newline in output when there were no abandoned
1538           documents.
1539         - Call dumpResponse() for extracted code.
1540         (WTR::TestController::handleControlCommand):
1541         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1542         - Use strncmp() instead of strcmp().
1543         - Call findAndDumpWebKitProcessIdentifiers() when
1544           "#LIST CHILD PROCESSES" command is sent.
1545         * WebKitTestRunner/TestController.h:
1546         (WTR::TestController::dumpResponse):
1547         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1548         - Declare methods.
1549
1550 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1551
1552         Unreviewed. Add GLib API test cases after r243434.
1553
1554         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1555         (testWebViewActiveURI):
1556         (serverCallback):
1557         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1558         (sendRequestCallback):
1559
1560 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1561
1562         Geolocation request not complete when watch request was started in a different web process
1563         https://bugs.webkit.org/show_bug.cgi?id=195996
1564
1565         Reviewed by Alex Christensen.
1566
1567         Add a test case.
1568
1569         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1570         (TestWebKitAPI::runJavaScriptAlert):
1571         (TestWebKitAPI::TEST):
1572
1573 2019-03-26  Keith Rollin  <krollin@apple.com>
1574
1575         Update the way generate-xcfilelists returns strings from functions
1576         https://bugs.webkit.org/show_bug.cgi?id=195975
1577         <rdar://problem/49040807>
1578
1579         Reviewed by Dean Jackson.
1580
1581         There are places where generate-xcfilelists executes assignments with
1582         statements like:
1583
1584             FOO=$(some_function)
1585
1586         where "some_function" return a string by echoing it. E.g.
1587
1588             some_function()
1589             {
1590                 echo "Hello, World"
1591             }
1592
1593         This is a common idiom, but it has a problem if "some_function" needs
1594         to call "exit" in an attempt to halt the entire script right then and
1595         there. Since "some_function" is called inside of $(), it's being
1596         executed in a sub-shell. Calling exit in that sub-shell simply exits
1597         that shell; it doesn't not exit the outer shell in which the main part
1598         of the script is still running. As such, the main script keeps
1599         executing when the intent was for the script to halt.
1600
1601         The solution to this is to use a different idiom for returning
1602         strings. The one we now is to pass in the name of the variable to
1603         receive the string result:
1604
1605             some_function()
1606             {
1607                 variable_name=$1
1608                 eval $variable_name ="Hello, World"
1609             }
1610
1611         The call site now looks like
1612
1613             some_function FOO
1614
1615         Because there's no invocation of a sub-shell, some_function can now
1616         call "exit" if it wants to, and the entire script will exit at that
1617         point.
1618
1619         * Scripts/generate-xcfilelists:
1620
1621 2019-03-26  Chris Dumez  <cdumez@apple.com>
1622
1623         Add basic layout test coverage for File Picker on iOS
1624         https://bugs.webkit.org/show_bug.cgi?id=196265
1625
1626         Reviewed by Wenson Hsieh.
1627
1628         Add layout test infrastructure to test the file picker on iOS.
1629
1630         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1631         (WTR::UIScriptController::dismissFilePicker):
1632         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1633         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1634         (WTR::UIScriptController::dismissFilePicker):
1635         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1636         * WebKitTestRunner/TestController.cpp:
1637         (WTR::TestController::createWebViewWithOptions):
1638         (WTR::updateTestOptionsFromTestHeader):
1639         * WebKitTestRunner/TestOptions.h:
1640         (WTR::TestOptions::hasSameInitializationOptions const):
1641         * WebKitTestRunner/ios/TestControllerIOS.mm:
1642         (overridePresentViewController):
1643         (WTR::TestController::platformInitialize):
1644         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1645         (WTR::UIScriptController::dismissFilePicker):
1646
1647 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1648
1649         Implement async paste method on UIWKInteractionViewProtocol
1650         https://bugs.webkit.org/show_bug.cgi?id=196267
1651         <rdar://problem/49236346>
1652
1653         Reviewed by Tim Horton.
1654
1655         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1656         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1657         are now a part of all iOS 12 internal SDKs.
1658
1659         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1660
1661         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1662         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1663
1664         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1665         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1666         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1667         * TestWebKitAPI/ios/UIKitSPI.h:
1668
1669 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1670
1671         [ews-build] Use PostgreSQL for ews.webkit.org database
1672         https://bugs.webkit.org/show_bug.cgi?id=196270
1673
1674         Reviewed by Lucas Forschler.
1675
1676         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1677
1678 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1679
1680         [ews] Reset simctl states on reboot
1681         https://bugs.webkit.org/show_bug.cgi?id=196260
1682
1683         Rubber-stamped by Aakash Jain.
1684
1685         * EWSTools/start-queue-mac.sh:
1686
1687 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1688
1689         [ews-build] Use PostgreSQL for ews-build database
1690         https://bugs.webkit.org/show_bug.cgi?id=196229
1691
1692         Reviewed by Lucas Forschler.
1693
1694         * BuildSlaveSupport/ews-build/master.cfg:
1695
1696 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1697
1698         [ews-build] Get master_hostname dynamically in master.cfg
1699         https://bugs.webkit.org/show_bug.cgi?id=196255
1700
1701         Reviewed by Lucas Forschler.
1702
1703         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1704         send events data in test mode.
1705
1706 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1707
1708         [ews-app] Set db_constraint to False for Foreign Keys
1709         https://bugs.webkit.org/show_bug.cgi?id=196252
1710
1711         Reviewed by Lucas Forschler.
1712
1713         * BuildSlaveSupport/ews-app/ews/models/build.py:
1714         * BuildSlaveSupport/ews-app/ews/models/step.py:
1715
1716 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1717
1718         [ews-build] is_test_mode_enabled should default to True
1719         https://bugs.webkit.org/show_bug.cgi?id=196248
1720
1721         Reviewed by Lucas Forschler.
1722
1723         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1724
1725 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1726
1727         [ews-app] Add webkitperl to ENABLED_QUEUES
1728         https://bugs.webkit.org/show_bug.cgi?id=196253
1729
1730         Reviewed by Lucas Forschler.
1731
1732         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1733
1734 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1735
1736         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1737         https://bugs.webkit.org/show_bug.cgi?id=196211
1738         rdar://problem/49110552
1739
1740         Reviewed by Tim Horton.
1741
1742         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1743         Make sure that EventSenderProxy always exists when running tests. We used to create
1744         it when resetting before the first test, which is a bit too late.
1745
1746         * WebKitTestRunner/TestController.h:
1747         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1748         (WTR::TestController::platformCreateWebView):
1749         (WTR::TestController::platformCreateOtherPage):
1750         (WTR::TestController::finishCreatingPlatformWebView):
1751         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1752         (WTR::PlatformWebView::PlatformWebView):
1753         Moved some code that made NSWindow use NSEvent during web view creation. We may
1754         need to move more if some other case us found, but this is enough for now.
1755
1756 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1757
1758         Unreviewed. Fix typo in GLib geolocation API after r243285.
1759
1760         gelocation -> geolocation.
1761
1762         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1763         (testGeolocationManagerWatchPosition):
1764
1765 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1766
1767         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1768         https://bugs.webkit.org/show_bug.cgi?id=196213
1769
1770         Reviewed by Geoff Garen.
1771
1772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1773         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1774         (credentialWithIdentityAndKeychainPath):
1775         (-[ChallengeDelegate webView:didFinishNavigation:]):
1776         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1777         (TestWebKitAPI::TEST):
1778
1779 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1780
1781         Expected shouldn't assume its contained types are copyable
1782         https://bugs.webkit.org/show_bug.cgi?id=195986
1783
1784         Reviewed by JF Bastien.
1785
1786         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1787         (TestWebKitAPI::NonCopyable::operator== const):
1788         (TestWebKitAPI::NonCopyable::operator!= const):
1789         (TestWebKitAPI::TEST):
1790
1791 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1792
1793         Remove some now-unnecessary dynamic class lookup
1794         https://bugs.webkit.org/show_bug.cgi?id=196237
1795
1796         Reviewed by Simon Fraser.
1797
1798         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1799         (makeRequest):
1800         (TEST):
1801
1802 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1803
1804         Unreviewed, rolling out r243450.
1805
1806         AppleWin and WinCairo port builds get broken.
1807
1808         Reverted changeset:
1809
1810         "Add test for fix of #196095"
1811         https://bugs.webkit.org/show_bug.cgi?id=196097
1812         https://trac.webkit.org/changeset/243450
1813
1814 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1815
1816         Unreviewed, rolling out r243465.
1817         https://bugs.webkit.org/show_bug.cgi?id=196226
1818
1819         the test doesn't build (Requested by thorton on #webkit).
1820
1821         Reverted changeset:
1822
1823         "Do not terminate the NetworkProcess if a third party
1824         application sends a NSCredential with a SecIdentityRef"
1825         https://bugs.webkit.org/show_bug.cgi?id=196213
1826         https://trac.webkit.org/changeset/243465
1827
1828 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1829
1830         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1831         https://bugs.webkit.org/show_bug.cgi?id=196213
1832
1833         Reviewed by Geoff Garen.
1834
1835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1836         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1837         (credentialWithIdentityAndKeychainPath):
1838         (-[ChallengeDelegate webView:didFinishNavigation:]):
1839         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1840         (TestWebKitAPI::TEST):
1841
1842 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1843
1844         [ews-build] Gracefully handle missing patch_id in events
1845         https://bugs.webkit.org/show_bug.cgi?id=196216
1846
1847         Reviewed by Lucas Forschler.
1848
1849         * BuildSlaveSupport/ews-build/events.py:
1850
1851 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1852
1853         [ews-build] use lz4 compression for improving buildbot performance
1854         https://bugs.webkit.org/show_bug.cgi?id=196155
1855
1856         Reviewed by Lucas Forschler.
1857
1858         * BuildSlaveSupport/ews-build/master.cfg:
1859
1860 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1861
1862         Pull some API testing helper methods out of TestWKWebView
1863         https://bugs.webkit.org/show_bug.cgi?id=196212
1864
1865         Reviewed by Tim Horton.
1866
1867         Refactor some more API testing utility methods, so that they can be used in
1868         tests that do not use TestWKWebView.
1869
1870         * TestWebKitAPI/cocoa/TestWKWebView.h:
1871         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1872         (-[WKWebView loadTestPageNamed:]):
1873         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1874         (-[WKWebView synchronouslyLoadHTMLString:]):
1875         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1876         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1877         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1878         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1879         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1880
1881 2019-03-25  Jer Noble  <jer.noble@apple.com>
1882
1883         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1884         https://bugs.webkit.org/show_bug.cgi?id=196097
1885
1886         Reviewed by Eric Carlson.
1887
1888         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1889
1890         * DumpRenderTree/mac/DumpRenderTree.mm:
1891         (resetWebPreferencesToConsistentValues):
1892         * WebKitTestRunner/TestController.cpp:
1893         (WTR::TestController::resetPreferencesToConsistentValues):
1894
1895 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1896
1897         Pull IPadUserInterfaceSwizzler out into a separate header file
1898         https://bugs.webkit.org/show_bug.cgi?id=196193
1899
1900         Reviewed by Anders Carlsson.
1901
1902         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1903         be used in other API tests.
1904
1905         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1906         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1907         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1908         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1909         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1910         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1911         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1912
1913 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1914
1915         Remove NavigatorContentUtils in WebCore/Modules
1916         https://bugs.webkit.org/show_bug.cgi?id=196070
1917
1918         Reviewed by Alex Christensen.
1919
1920         NavigatorContentUtils was to support the custom scheme spec [1].
1921         However, in WebKit side, no port has supported the feature in
1922         WebKit layer after EFL port was removed. So there has been the
1923         only IDL implementation of the NavigatorContentUtils in WebCore.
1924         So we don't need to keep the implementation in WebCore anymore.
1925
1926         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1927
1928         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1929
1930 2019-03-24  Andy Estes  <aestes@apple.com>
1931
1932         [watchOS] Remove unused Proximity Networking code
1933         https://bugs.webkit.org/show_bug.cgi?id=196188
1934
1935         Reviewed by Tim Horton.
1936
1937         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1938         (TEST):
1939
1940 2019-03-23  Keith Miller  <keith_miller@apple.com>
1941
1942         Refactor clz/ctz and fix getLSBSet.
1943         https://bugs.webkit.org/show_bug.cgi?id=196162
1944
1945         Reviewed by Saam Barati.
1946
1947         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1948
1949         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1950         (TestWebKitAPI::TEST):
1951
1952 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1953
1954         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1955         https://bugs.webkit.org/show_bug.cgi?id=196143
1956
1957         Reviewed by Michael Catanzaro.
1958
1959         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1960         directories.
1961
1962         * Scripts/webkitpy/style/checkers/cpp.py:
1963         (check_identifier_name_in_declaration):
1964         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1965         (WebKitStyleTest.test_names):
1966
1967 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1968
1969         [Flatpak] Manifest expanding fails for qt WPE extension
1970         https://bugs.webkit.org/show_bug.cgi?id=196148
1971
1972         Reviewed by Alex Christensen.
1973
1974         * flatpak/flatpakutils.py:
1975         (expand_submodules_recurse): The last recurse manifest expand
1976         iteration might lead to a single module so take it into account
1977         and don't try to recurse further.
1978
1979 2019-03-22  Chris Dumez  <cdumez@apple.com>
1980
1981         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1982         https://bugs.webkit.org/show_bug.cgi?id=195348
1983         <rdar://problem/48622090>
1984
1985         Reviewed by Alex Christensen.
1986
1987         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1988         to NO when test.options().shouldIgnoreMetaViewport is false.
1989
1990         * WebKitTestRunner/ios/TestControllerIOS.mm:
1991         (WTR::TestController::platformConfigureViewForTest):
1992
1993 2019-03-22  Chris Dumez  <cdumez@apple.com>
1994
1995         Prewarmed processes should be usable with any website data store
1996         https://bugs.webkit.org/show_bug.cgi?id=196104
1997
1998         Reviewed by Alex Christensen.
1999
2000         Add API test coverage.
2001
2002         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2003         (runInitialWarmedProcessUsedTest):
2004         (TEST):
2005
2006 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2007
2008         Back out local changes to Alex's Subversion working directory
2009
2010         They were accidentally committed.
2011
2012         * Scripts/webkitpy/common/system/abstractexecutive.py:
2013         (AbstractExecutive.wait_newest):
2014         * Scripts/webkitpy/common/system/executive.py:
2015         (Executive.running_pids):
2016         * Scripts/webkitpy/common/system/executive_mock.py:
2017         (MockExecutive.running_pids):
2018         * Scripts/webkitpy/common/system/executive_unittest.py:
2019         (ExecutiveTest.serial_test_running_pids):
2020         * Scripts/webkitpy/port/darwin.py:
2021         (DarwinPort.check_for_leaks):
2022         * Scripts/webkitpy/port/leakdetector.py:
2023         (LeakDetector.check_for_leaks):
2024         - This was the hack attached to Bug 193772.
2025
2026         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2027         (+[WebKitTestRunnerEvent mouseLocation]):
2028         - This works around a crash on an internal build.
2029
2030 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2031
2032         Fix the build after r243354
2033         https://bugs.webkit.org/show_bug.cgi?id=196138
2034         <rdar://problem/49145951>
2035
2036         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2037         (TEST):
2038         * TestWebKitAPI/ios/UIKitSPI.h:
2039
2040 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2041
2042         Adopt UIWKDocumentContext
2043         https://bugs.webkit.org/show_bug.cgi?id=196040
2044         <rdar://problem/48642440>
2045
2046         Reviewed by Ryosuke Niwa.
2047
2048         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2049         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2050         (makeRequest):
2051         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2052         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2053         (applyStyle):
2054         (TEST):
2055         Add tests for UIWKDocumentContext.
2056
2057         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2058         (TEST):
2059         (recursiveFindWKContentView): Deleted.
2060         * TestWebKitAPI/cocoa/TestWKWebView.h:
2061         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2062         (recursiveFindWKContentView):
2063         (-[TestWKWebView wkContentView]):
2064         * TestWebKitAPI/ios/UIKitSPI.h:
2065         Share the WKContentView finding code between tests.
2066
2067 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2068
2069         [iOS WK2] Turn on async overflow scrolling by default
2070         https://bugs.webkit.org/show_bug.cgi?id=196011
2071         rdar://problem/48453859
2072
2073         Reviewed by Antti Koivisto.
2074         
2075         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2076         since so many basic layout tests have different results when compositing is triggered for
2077         overflow.
2078         
2079         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2080
2081         * WebKitTestRunner/TestController.cpp:
2082         (WTR::TestController::resetPreferencesToConsistentValues):
2083
2084 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2085
2086         [ews-build] Retry API test in case of failures
2087         https://bugs.webkit.org/show_bug.cgi?id=196004
2088
2089         Reviewed by Lucas Forschler.
2090
2091         * BuildSlaveSupport/ews-build/steps.py:
2092         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2093         (CompileWebKitToT.doStepIf): Ditto.
2094         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2095         (ReRunAPITests): Re-run API tests.
2096         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2097         (RunAPITestsWithoutPatch): Run API tests without patch.
2098         (RunAPITestsWithoutPatch.doStepIf):
2099         (RunAPITestsWithoutPatch.hideStepIf):
2100         (RunAPITestsWithoutPatch.evaluateCommand):
2101         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2102         (AnalyzeAPITestsResults.start):
2103         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2104         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2105         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2106         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2107
2108 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2109
2110         [ews-build] Update queues configurations
2111         https://bugs.webkit.org/show_bug.cgi?id=196074
2112
2113         Reviewed by Dewei Zhu.
2114
2115         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2116         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2117
2118 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2119
2120         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2121         https://bugs.webkit.org/show_bug.cgi?id=195680
2122         <rdar://problem/48903534>
2123
2124         Unreviewed infrastructure fix.
2125
2126         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2127         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2128
2129 2019-03-21  Andy Estes  <aestes@apple.com>
2130
2131         [iOS] Apple Pay should be available in documents with no user agent scripts
2132         https://bugs.webkit.org/show_bug.cgi?id=196061
2133         <rdar://problem/48649391>
2134
2135         Reviewed by Brady Eidson.
2136
2137         Added API tests and related infrastructure.
2138
2139         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2140         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2141         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2142         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2143         (TestWebKitAPI::TEST):
2144         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2145         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2146         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2147         * TestWebKitAPI/cocoa/TestProtocol.mm:
2148         (-[TestProtocol startLoading]):
2149         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2150         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2151         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2152         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2153
2154 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2155
2156         REGRESSSION (r243297): webkitpy tests broken
2157         https://bugs.webkit.org/show_bug.cgi?id=196108
2158
2159         Reviewed by Aakash Jain.
2160
2161         r243297 updated contributors.json, which broke a few unit tests.
2162
2163         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2164         (IRCCommandTest.test_whois):
2165         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2166
2167 2019-03-21  Chris Dumez  <cdumez@apple.com>
2168
2169         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2170         https://bugs.webkit.org/show_bug.cgi?id=196041
2171         <rdar://problem/49083230>
2172
2173         Reviewed by Alex Christensen.
2174
2175         Add API test coverage.
2176
2177         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2178         (TEST):
2179
2180 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2181
2182         Add SPI to inform applications of WKContentRuleList actions
2183         https://bugs.webkit.org/show_bug.cgi?id=195965
2184         <rdar://problem/42664365>
2185
2186         Reviewed by Geoff Garen.
2187
2188         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2189         (TestWebKitAPI::allActionsForResourceLoad):
2190         (TestWebKitAPI::testRequest):
2191         (TestWebKitAPI::TEST_F):
2192         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2193         (Notification::description):
2194         (Notification::operator== const):
2195         (toVector):
2196         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2197         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2198         (makeContentRuleList):
2199         (TEST):
2200         (makeWarnContentRuleList): Deleted.
2201
2202 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2203
2204         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2205         https://bugs.webkit.org/show_bug.cgi?id=196088
2206
2207         Reviewed by Brian Burg.
2208
2209         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2210         Support checks when only one platform is specified. Also deprecate macosx() and
2211         force the use of macos() instead.
2212
2213         * Scripts/webkitpy/style/checkers/cpp.py:
2214         (check_min_versions_of_wk_api_available):
2215         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2216         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2217
2218 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2219
2220         Update status inactive committers' status to 'contributor'.
2221
2222         * Scripts/webkitpy/common/config/contributors.json:
2223
2224 2019-03-21  Xan Lopez  <xan@igalia.com>
2225
2226         [JSC][x86] Drop support for x87 floating point
2227         https://bugs.webkit.org/show_bug.cgi?id=194853
2228
2229         Reviewed by Don Olmstead.
2230
2231         Force SSE2 on x86/32bit builds.
2232
2233         * Scripts/webkitdirs.pm:
2234         (generateBuildSystemFromCMakeProject):
2235
2236 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2237
2238         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2239         https://bugs.webkit.org/show_bug.cgi?id=196073
2240
2241         Reviewed by Michael Catanzaro.
2242
2243         Add test cases to check functions and constructors with no arguments but receiving user data.
2244
2245         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2246         (checkUserData):
2247         (testJSCFunction):
2248         (fooCreateWithUserData):
2249         (testJSCClass):
2250
2251 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2252
2253         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2254
2255         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2256
2257         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2258
2259 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2260
2261         [GTK][WPE] Add API to provide geolocation information
2262         https://bugs.webkit.org/show_bug.cgi?id=195940
2263
2264         Reviewed by Michael Catanzaro.
2265
2266         Add a new test to check the new API.
2267
2268         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2269         (testGeolocationManagerCurrentPosition):
2270         (testGeolocationManagerWatchPosition):
2271         (beforeAll):
2272         (afterAll):
2273         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2274         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2275         (beforeAll): Ditto.
2276         * TestWebKitAPI/glib/CMakeLists.txt:
2277
2278 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2279
2280         [GLib] Returning G_TYPE_OBJECT from a method does not work
2281         https://bugs.webkit.org/show_bug.cgi?id=195574
2282
2283         Reviewed by Michael Catanzaro.
2284
2285         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2286
2287         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2288         (getGFile):
2289         (getParent):
2290         (createGString):
2291         (getGString):
2292         (getGStringCopyWillRaise):
2293         (getGStringCopy):
2294         (getGStringStr):
2295         (getGStringLen):
2296         (freeGString):
2297         (testJSCClass):
2298
2299 2019-03-20  Saam Barati  <sbarati@apple.com>
2300
2301         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2302         https://bugs.webkit.org/show_bug.cgi?id=195721
2303
2304         Reviewed by Filip Pizlo.
2305
2306         * Scripts/run-javascriptcore-tests:
2307
2308 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2309
2310         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2311         https://bugs.webkit.org/show_bug.cgi?id=196049
2312
2313         Reviewed by Tim Horton.
2314
2315         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2316         overflow scrolling in general, so rename it.
2317
2318         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2319
2320 2019-03-20  Daniel Bates  <dabates@apple.com>
2321
2322         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2323         https://bugs.webkit.org/show_bug.cgi?id=196031
2324         <rdar://problem/49078172>
2325
2326         Reviewed by Tim Horton.
2327
2328         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2329         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2330         same code path used when the Done button is pressed to dismiss the <select> picker.
2331
2332         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2333         (TestWebKitAPI::TEST):
2334
2335 2019-03-20  Chris Dumez  <cdumez@apple.com>
2336
2337         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2338         https://bugs.webkit.org/show_bug.cgi?id=196029
2339         <rdar://problem/48954651>
2340
2341         Reviewed by Tim Horton.
2342
2343         Add API test coverage.
2344
2345         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2346
2347 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2348
2349         [ews-build] Improve failure summary string for ApplyPatch step
2350         https://bugs.webkit.org/show_bug.cgi?id=195995
2351
2352         Reviewed by Alexey Proskuryakov.
2353
2354         * BuildSlaveSupport/ews-build/steps.py:
2355         (ApplyPatch.getResultSummary): Override getResultSummary.
2356
2357 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2358
2359         AX: Implement support for new meter ARIA role
2360         https://bugs.webkit.org/show_bug.cgi?id=195966
2361
2362         Reviewed by Chris Fleizach.
2363
2364         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2365         to AXLevelIndicator.
2366
2367         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2368
2369 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2370
2371         [WebAuthN] Implement FIDO AppID extension
2372         https://bugs.webkit.org/show_bug.cgi?id=143491
2373         <rdar://problem/48298273>
2374
2375         Reviewed by Brent Fulgham.
2376
2377         Add a test that covers the new flag of convertToU2fSignCommand.
2378
2379         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2380         (TestWebKitAPI::TEST):
2381         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2382         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2383         (TestWebKitAPI::TEST):
2384
2385 2019-03-19  Keith Rollin  <krollin@apple.com>
2386
2387         Add support for more platforms to generate-xcfilelists
2388         https://bugs.webkit.org/show_bug.cgi?id=195977
2389
2390         Reviewed by Alexey Proskuryakov.
2391
2392         generate-xcfilelists incorrectly complains when involved with building
2393         WebKit for iphonesimulator:
2394
2395             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2396             …
2397             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2398
2399         Address this by teaching generate-xcfilelists about more platforms.
2400
2401         * Scripts/generate-xcfilelists:
2402
2403 2019-03-19  John Wilander  <wilander@apple.com>
2404
2405         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2406         https://bugs.webkit.org/show_bug.cgi?id=195923
2407         <rdar://problem/49001272>
2408
2409         Reviewed by Alex Christensen.
2410
2411         This patch does the following to the TestRunner:
2412         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2413         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2414         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2415
2416         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2417         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2418         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2419         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2420         * WebKitTestRunner/TestController.cpp:
2421         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2422         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2423         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2424         * WebKitTestRunner/TestController.h:
2425         * WebKitTestRunner/TestInvocation.cpp:
2426         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2427
2428 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2429
2430         [CMake] Support more clang and gcc sanitizers
2431         https://bugs.webkit.org/show_bug.cgi?id=195956
2432
2433         Reviewed by Michael Catanzaro.
2434
2435         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2436
2437 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2438
2439         [ews-build] Improve summary for PrintConfiguration step
2440         https://bugs.webkit.org/show_bug.cgi?id=195945
2441
2442         Reviewed by Lucas Forschler.
2443
2444         * BuildSlaveSupport/ews-build/steps.py:
2445         (PrintConfiguration.getResultSummary): Override getResultSummary.
2446
2447 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2448
2449         [ews-build] Improve summary for CheckOutSource step
2450         https://bugs.webkit.org/show_bug.cgi?id=195963
2451
2452         Reviewed by Lucas Forschler.
2453
2454         * BuildSlaveSupport/ews-build/steps.py:
2455         (CheckOutSource.getResultSummary):
2456
2457 2019-03-19  Daniel Bates  <dabates@apple.com>
2458
2459         [iOS] Focus not preserved when switching between tabs
2460         https://bugs.webkit.org/show_bug.cgi?id=195820
2461         <rdar://problem/43614450>
2462
2463         Reviewed by Brent Fulgham.
2464
2465         Add tests to ensure that we restore focus when resigning and becoming first responder.
2466
2467         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2468         (TestWebKitAPI::TEST):
2469
2470 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2471
2472         Make WTFLogChannelState and WTFLogLevel enum classes
2473         https://bugs.webkit.org/show_bug.cgi?id=195904
2474
2475         Reviewed by Eric Carlson.
2476
2477         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2478         (TestWebKitAPI::TEST_F):
2479
2480 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2481
2482         [GStreamer][EME] Backported mssdemux protection data crash fix
2483         https://bugs.webkit.org/show_bug.cgi?id=195918
2484
2485         Reviewed by Philippe Normand.
2486
2487         * gstreamer/jhbuild.modules:
2488         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2489
2490 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2491
2492         Unreviewed, rolling out r243132.
2493
2494         Broke GTK build
2495
2496         Reverted changeset:
2497
2498         "Make WTFLogChannelState and WTFLogLevel enum classes"
2499         https://bugs.webkit.org/show_bug.cgi?id=195904
2500         https://trac.webkit.org/changeset/243132
2501
2502 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2503
2504         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2505
2506         * Scripts/webkitdirs.pm:
2507         (builtDylibPathForName): Adjust the shared library name that's changed
2508         with the API version bump in r243073.
2509
2510 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2511
2512         Make WTFLogChannelState and WTFLogLevel enum classes
2513         https://bugs.webkit.org/show_bug.cgi?id=195904
2514
2515         Reviewed by Eric Carlson.
2516
2517         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2518         (TestWebKitAPI::TEST_F):
2519
2520 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2521
2522         Disable flaky test added in r2431100
2523         https://webkit.org/b/195785
2524
2525         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2526         (TestWebKitAPI::TEST):
2527         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2528
2529 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2530
2531         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2532         https://bugs.webkit.org/show_bug.cgi?id=195916
2533
2534         Reviewed by Tim Horton.
2535
2536         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2537         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2538
2539 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2540
2541         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2542
2543         * Scripts/webkitpy/common/config/contributors.json:
2544
2545 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2546
2547         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2548         https://bugs.webkit.org/show_bug.cgi?id=195785
2549
2550         Reviewed by Geoffrey Garen.
2551
2552         * TestWebKitAPI/TCPServer.cpp: Added.
2553         (TestWebKitAPI::TCPServer::TCPServer):
2554         (TestWebKitAPI::TCPServer::~TCPServer):
2555         (TestWebKitAPI::TCPServer::socketBindListen):
2556         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2557         * TestWebKitAPI/TCPServer.h: Added.
2558         (TestWebKitAPI::TCPServer::port const):
2559         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2560         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2561         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2562         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2563         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2564         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2565         (TestWebKitAPI::respondSlowly):
2566         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2567         (TestWebKitAPI::downloadAtRate):
2568         (TestWebKitAPI::TEST):
2569
2570 2019-03-18  Saam Barati  <sbarati@apple.com>
2571
2572         Add a plan file for JetStream 2
2573         https://bugs.webkit.org/show_bug.cgi?id=190734
2574
2575         Reviewed by Mark Lam.
2576
2577         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2578
2579 2019-03-18  Chris Dumez  <cdumez@apple.com>
2580
2581         Delay WebProcess launch until a load is triggered in a Web view
2582         https://bugs.webkit.org/show_bug.cgi?id=195758
2583         <rdar://problem/48126013>
2584
2585         Reviewed by Geoff Garen.
2586
2587         Add API test coverage. Also update some existing API tests to not expect
2588         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2589
2590         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2591         (TestWebKitAPI::TEST):
2592         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2593         (TestWebKitAPI::TEST):
2594         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2595         (TEST):
2596         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2597         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2598         (TEST):
2599         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2600         (TEST):
2601         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2602
2603 2019-03-18  Xan Lopez  <xan@igalia.com>
2604
2605         [CMake] Prevent potential warning when determining $architecture
2606         https://bugs.webkit.org/show_bug.cgi?id=195891
2607
2608         Reviewed by Michael Catanzaro.
2609
2610         It's possible for generateBuildSystemForCMakeProject to be called
2611         before determineArchitecture() is ever called. This will make the
2612         first eq check with $architecture to be bogus (and print a
2613         warning). Change that to an eq check with architecture(), which
2614         implicitly calls determineArchitecture() if needed, and change all
2615         the other similar cases in the method in the same way to prevent
2616         future bugs like this one.
2617
2618         * Scripts/webkitdirs.pm:
2619         (generateBuildSystemFromCMakeProject):
2620
2621 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2622
2623         [WPE] Tarballs generated with “make dist” cannot build documentation
2624         https://bugs.webkit.org/show_bug.cgi?id=195885
2625
2626         Reviewed by Carlos Garcia Campos.
2627
2628         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2629
2630 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2631
2632         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2633         https://bugs.webkit.org/show_bug.cgi?id=195883
2634
2635         Reviewed by Carlos Garcia Campos.
2636
2637         * gtkdoc/gtkdoc.py:
2638         (GTKDoc._run_command): When commands fail to run, include the full command line for
2639         the program invocation and the output it has generated on the standard error stream.
2640
2641 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2642
2643         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2644         https://bugs.webkit.org/show_bug.cgi?id=195786
2645
2646         Reviewed by Philippe Normand.
2647
2648         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2649         * wpe/jhbuild.modules: Ditto.
2650
2651 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2652
2653         [ews-build] Don't run clean builds on EWS builders
2654         https://bugs.webkit.org/show_bug.cgi?id=195851
2655
2656         Reviewed by Geoffrey Garen.
2657
2658         * BuildSlaveSupport/ews-build/factories.py:
2659
2660 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2661
2662         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2663         https://bugs.webkit.org/show_bug.cgi?id=195849
2664
2665         Reviewed by Chris Dumez.
2666
2667         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2668
2669         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2670         (runWebsiteDataStoreCustomPaths):
2671
2672 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2673
2674         webkitpy: Upload test results
2675         https://bugs.webkit.org/show_bug.cgi?id=195755
2676         <rdar://problem/48896182>
2677
2678         Reviewed by Aakash Jain.
2679
2680         Establish a new format for uploading results that is not tied to layout tests, apply
2681         that format to webkitpy tests.
2682
2683         * Scripts/webkitpy/common/checkout/scm/git.py:
2684         (Git.native_branch): Return what branch the current checkout is on.
2685         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2686         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2687         * Scripts/webkitpy/common/checkout/scm/svn.py:
2688         (SVN.native_branch): Ditto.
2689         * Scripts/webkitpy/common/system/platforminfo.py:
2690         (PlatformInfo.build_version): Return a build version for Mac.
2691         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2692         (MockPlatformInfo.__init__):
2693         (MockPlatformInfo.build_version):
2694         * Scripts/webkitpy/results: Added.
2695         * Scripts/webkitpy/results/__init__.py: Added.
2696         * Scripts/webkitpy/results/options.py: Added.
2697         (upload_options): OptParse list for upload options.
2698         * Scripts/webkitpy/results/upload.py: Added.
2699         (Upload): Class which enforces the upload format expected by the results server.
2700         (Upload.Expectations):
2701         (Upload.create_configuration):
2702         (Upload.create_commit):
2703         (Upload.create_details):
2704         (Upload.create_run_stats):
2705         (Upload.create_test_result):
2706         (Upload.__init__):
2707         (Upload.Encoder): Encode Upload object as json.
2708         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2709         * Scripts/webkitpy/results/upload_unittest.py: Added.
2710         * Scripts/webkitpy/test/main.py:
2711         (Tester._parse_args): Add upload arguments.
2712         (Tester._run_tests): Allow results to be uploaded.
2713         * Scripts/webkitpy/test/runner.py:
2714         (Runner.__init__): Record which tests were run, rather than just counting them.
2715         (Runner.handle):
2716         * Scripts/webkitpy/test/runner_unittest.py:
2717         (RunnerTest.test_run):
2718         * Scripts/webkitpy/thirdparty/__init__.py:
2719         (AutoinstallImportHook.find_module): Add requests auto-install.
2720         (AutoinstallImportHook._install_requests):
2721         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2722         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2723
2724 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2725
2726         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2727         https://bugs.webkit.org/show_bug.cgi?id=195810
2728
2729         Reviewed by Tim Horton.
2730
2731         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2732         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2733         ending certain layout tests.
2734
2735         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2736         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2737         (-[TestRunnerWKWebView dealloc]):
2738         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2739
2740         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2741         helper method when destroying the web view, and when resetting state between tests.
2742
2743         * WebKitTestRunner/ios/TestControllerIOS.mm:
2744         (WTR::TestController::platformResetStateToConsistentValues):
2745
2746         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2747
2748 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2749
2750         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2751         https://bugs.webkit.org/show_bug.cgi?id=190350
2752         <rdar://problem/45089503>
2753
2754         Reviewed by Geoffrey Garen.
2755
2756         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2757         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2758         (TEST):
2759         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2760         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2761         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2762         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2763         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2764         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2765         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2766         (runTest):
2767         (createDirectories):
2768         (TEST):
2769         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2770         (TEST):
2771         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2772         (TEST):
2773
2774 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2775
2776         Add support to WebPage for getting the contents as an attributed string.
2777         https://bugs.webkit.org/show_bug.cgi?id=195636
2778         rdar://problem/45055697
2779
2780         Reviewed by Tim Horton.
2781
2782         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2783         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2784
2785 2019-03-15  Chris Dumez  <cdumez@apple.com>
2786
2787         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2788         https://bugs.webkit.org/show_bug.cgi?id=195747
2789
2790         Reviewed by Geoff Garen.
2791
2792         Add API test coverage.
2793
2794         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2795
2796 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2797
2798         Unreviewed, rolling out r242952.
2799
2800         Causing API failures on iOS Simulator
2801
2802         Reverted changeset:
2803
2804         "[PSON] Make sure the WebProcessCache is leverage when
2805         relaunching a process after termination"
2806         https://bugs.webkit.org/show_bug.cgi?id=195747
2807         https://trac.webkit.org/changeset/242952
2808
2809 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2810
2811         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2812         https://bugs.webkit.org/show_bug.cgi?id=195740
2813
2814         Reviewed by Ross Kirsling.
2815
2816         window.open doesn't work for WebKitBrowserWindow because it is not
2817         implemented yet.
2818
2819         1. Implemented createNewPage callback of WKPageUIClient.
2820         2. Changed MainWindow to take a BrowserWindow factory function
2821           instead of BrowserWindowType to be flexible to create
2822           BrowserWindow with extra settings.
2823         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2824           because it is not relevant with MainWindow anymore.
2825
2826         * MiniBrowser/win/Common.cpp:
2827         (parseCommandLine):
2828         * MiniBrowser/win/Common.h:
2829         (CommandLineOptions::CommandLineOptions):
2830         * MiniBrowser/win/MainWindow.cpp:
2831         (MainWindow::MainWindow):
2832         (MainWindow::create):
2833         (MainWindow::init):
2834         (MainWindow::WndProc):
2835         * MiniBrowser/win/MainWindow.h:
2836         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2837         (PrintWebUIDelegate::createWebViewWithRequest):
2838         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2839         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2840         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2841         (WebKitBrowserWindow::updateProxySettings):
2842         (WebKitBrowserWindow::createNewPage):
2843         * MiniBrowser/win/WebKitBrowserWindow.h:
2844         * MiniBrowser/win/WinMain.cpp:
2845         (wWinMain):
2846
2847 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2848
2849         Make it possible to test scrolling tree layer manipulation more easily
2850         https://bugs.webkit.org/show_bug.cgi?id=195780
2851
2852         Reviewed by Tim Horton.
2853         
2854         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2855         cuts off communication of scrolling tree scrolls back to the web process
2856         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2857         allows tests to trigger scrolls which run the scrolling tree layer positioning
2858         logic, but never get another commit from the web process that might mask
2859         scrolling tree bugs.
2860         
2861         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2862         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2863         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2864
2865         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2866         (WTR::UIScriptController::scrollUpdatesDisabled const):
2867         (WTR::UIScriptController::setScrollUpdatesDisabled):
2868         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2869         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2870         (WTR::UIScriptController::scrollUpdatesDisabled const):
2871         (WTR::UIScriptController::setScrollUpdatesDisabled):
2872         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2873         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2874         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2875         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2876         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2877         * WebKitTestRunner/ios/TestControllerIOS.mm:
2878         (WTR::TestController::platformResetStateToConsistentValues):
2879         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2880         (WTR::UIScriptController::scrollUpdatesDisabled const):
2881         (WTR::UIScriptController::setScrollUpdatesDisabled):
2882
2883 2019-03-14  Youenn Fablet  <youenn@apple.com>
2884
2885         Move IDB storage in private browsing mode to NetworkProcess
2886         https://bugs.webkit.org/show_bug.cgi?id=195602
2887
2888         Reviewed by Brady Eidson.
2889
2890         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2891         (TEST):
2892
2893 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2894
2895         [ews-build] Make descriptionDone messages more readable
2896         https://bugs.webkit.org/show_bug.cgi?id=195760
2897
2898         Reviewed by Lucas Forschler.
2899
2900         * BuildSlaveSupport/ews-build/steps.py:
2901         * BuildSlaveSupport/ews-build/steps_unittest.py:
2902
2903 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2904
2905         [ews-build] Generate status-bubble hover-over messages
2906         https://bugs.webkit.org/show_bug.cgi?id=195680
2907
2908         Reviewed by Lucas Forschler.
2909
2910         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2911         (StatusBubble):
2912         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2913         on hover-over.
2914         (StatusBubble._iso_time):
2915         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2916         hover-over message.
2917         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2918
2919 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2920
2921         [ews-app] Gracefully handle the case when state_string is None
2922         https://bugs.webkit.org/show_bug.cgi?id=195753
2923
2924         Reviewed by Lucas Forschler.
2925
2926         * BuildSlaveSupport/ews-app/ews/models/build.py:
2927         * BuildSlaveSupport/ews-app/ews/models/step.py:
2928
2929 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2930
2931         [ews-app] Status bubble display pending for currently running build step
2932         https://bugs.webkit.org/show_bug.cgi?id=195744
2933
2934         Reviewed by Lucas Forschler.
2935
2936         * BuildSlaveSupport/ews-build/events.py:
2937         (Events.stepStarted): If state_string is pending, replace it with step name.
2938
2939 2019-03-14  Chris Dumez  <cdumez@apple.com>
2940
2941         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2942         https://bugs.webkit.org/show_bug.cgi?id=195750
2943
2944         Reviewed by Geoffrey Garen.
2945
2946         Add API test coverage.
2947
2948         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2949         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2950         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2951         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2952
2953 2019-03-14  Chris Dumez  <cdumez@apple.com>
2954
2955         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2956         https://bugs.webkit.org/show_bug.cgi?id=195747
2957
2958         Reviewed by Geoff Garen.
2959
2960         Add API test coverage.
2961
2962         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2963
2964 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2965
2966         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2967         https://bugs.webkit.org/show_bug.cgi?id=195725
2968         <rdar://problem/48545062>
2969
2970         Reviewed by Tim Horton.
2971
2972         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2973         handler is nil.
2974
2975         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2976         (TestWebKitAPI::TEST):
2977
2978 2019-03-13  Sam Weinig  <sam@webkit.org>
2979
2980         Add utility function to allow easy reverse range-based iteration of a container
2981         https://bugs.webkit.org/show_bug.cgi?id=195542
2982
2983         Reviewed by Antti Koivisto.
2984
2985         * TestWebKitAPI/CMakeLists.txt:
2986         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2987         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2988         (TestWebKitAPI::TEST):
2989         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2990
2991 2019-03-13  Chris Dumez  <cdumez@apple.com>
2992
2993         Use a ServiceWorker process per registrable domain
2994         https://bugs.webkit.org/show_bug.cgi?id=195649
2995
2996         Reviewed by Youenn Fablet.
2997
2998         Update API test coverage.
2999
3000         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3001
3002 2019-03-13  Chris Dumez  <cdumez@apple.com>
3003
3004         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3005         https://bugs.webkit.org/show_bug.cgi?id=195684
3006         <rdar://problem/48294714>
3007
3008         Reviewed by Antti Koivisto.
3009
3010         Add API test coverage.
3011
3012         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3013
3014 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3015
3016         [ews-app] Remove unused patch view
3017         https://bugs.webkit.org/show_bug.cgi?id=195669
3018
3019         Reviewed by Lucas Forschler.
3020
3021         * BuildSlaveSupport/ews-app/ews/urls.py:
3022         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3023
3024 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3025
3026         [ews-app] Use Buildbot result code variables
3027         https://bugs.webkit.org/show_bug.cgi?id=195668
3028
3029         Reviewed by Alexey Proskuryakov.
3030
3031         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3032         (Buildbot): Added Buildbot result code variables.
3033         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3034         (StatusBubble._build_bubble): Used Buildbot result code variables.
3035
3036 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3037
3038         [Flatpak] Expand submodule recursively
3039         https://bugs.webkit.org/show_bug.cgi?id=195672
3040
3041         Building WPE with flatpak was impossible without that as it was raising an exception.
3042         Also update wpebackend-fdo to match what is built in jhbuild
3043
3044         Reviewed by Philippe Normand.
3045
3046         * flatpak/flatpakutils.py:
3047         (expand_submodules_recurse):
3048         (expand_manifest):
3049         * flatpak/org.webkit.WPEModules.yaml:
3050
3051 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3052
3053         [ews-app] status bubble should be hidden for certain builds
3054         https://bugs.webkit.org/show_bug.cgi?id=194597
3055
3056         Reviewed by Dewei Zhu.
3057
3058         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3059         (StatusBubble._build_bubble):
3060         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3061         because the patch didn't have relevant changes.
3062         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3063         in production yet.
3064
3065 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3066
3067         [Win] Fix a slew of simple clang-cl warnings.
3068         https://bugs.webkit.org/show_bug.cgi?id=195652
3069
3070         Reviewed by Don Olmstead.
3071
3072         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3073         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3074
3075 2019-03-12  Justin Fan  <justin_fan@apple.com>
3076
3077         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3078         https://bugs.webkit.org/show_bug.cgi?id=195518
3079         <rdar://problem/46322356>
3080
3081         Reviewed by Myles C. Maxfield.
3082
3083         * DumpRenderTree/DerivedSources-input.xcfilelist:
3084         * DumpRenderTree/DerivedSources-output.xcfilelist:
3085
3086 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3087
3088         Unreviewed, rolling out r242825.
3089         https://bugs.webkit.org/show_bug.cgi?id=195648
3090
3091         "Broke webkitpy tests with my change to
3092         lldb_dump_class_layout.py" (Requested by rmorisset on
3093         #webkit).
3094
3095         Reverted changeset:
3096
3097         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3098         classes with suspicious padding"
3099         https://bugs.webkit.org/show_bug.cgi?id=195573
3100         https://trac.webkit.org/changeset/242825
3101
3102 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3103
3104         [ews-build] Show status bubbles while the patch is waiting in queue
3105         https://bugs.webkit.org/show_bug.cgi?id=195618
3106
3107         Reviewed by Lucas Forschler.
3108
3109         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3110         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3111         enabled in initial deployment.
3112         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3113         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3114         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3115         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3116         (StatusBubble._build_bubbles_for_patch):
3117
3118 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3119
3120         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3121         https://bugs.webkit.org/show_bug.cgi?id=195573
3122
3123         Reviewed by Simon Fraser.
3124
3125         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3126
3127         * Scripts/dump-class-layout:
3128         (main):
3129         * lldb/lldb_dump_class_layout.py:
3130         (ClassLayout.__init__):
3131         (ClassLayout._compute_padding_recursive):
3132         (LLDBDebuggerInstance.dump_layout_for_classname):
3133         (LLDBDebuggerInstance):
3134         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3135         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3136
3137 2019-03-12  Chris Dumez  <cdumez@apple.com>
3138
3139         Device Orientation access permission should be denied unless explicitly granted by the client
3140         https://bugs.webkit.org/show_bug.cgi?id=195625
3141
3142         Reviewed by Youenn Fablet.
3143
3144         add API test coverage.
3145
3146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3147         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3148         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3149         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3150         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3151         (runDeviceOrientationTest):
3152         (TEST):
3153         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3154         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3155
3156 2019-03-12  Jer Noble  <jer.noble@apple.com>
3157
3158         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3159         https://bugs.webkit.org/show_bug.cgi?id=195137
3160         <rdar://problem/48810307>
3161
3162         Reviewed by Eric Carlson.
3163
3164         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3165         (TestWebKitAPI::TEST):
3166
3167 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3168
3169         [ews-build] Change urls from uat to production
3170         https://bugs.webkit.org/show_bug.cgi?id=195566
3171
3172         Reviewed by Lucas Forschler.
3173
3174         * BuildSlaveSupport/ews-app/ews/config.py:
3175         * BuildSlaveSupport/ews-build/events.py:
3176         * BuildSlaveSupport/ews-build/steps.py:
3177
3178 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3179
3180         [ews-build] change max_builds for local-worker to 1
3181         https://bugs.webkit.org/show_bug.cgi?id=195568
3182
3183         Reviewed by Lucas Forschler.
3184
3185         * BuildSlaveSupport/ews-build/loadConfig.py:
3186
3187 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3188
3189         Fix the build
3190
3191         * TestRunnerShared/spi/PencilKitTestSPI.h:
3192         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3193
3194 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3195
3196         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3197         https://bugs.webkit.org/show_bug.cgi?id=194131
3198
3199         Reviewed by Michael Catanzaro.
3200
3201         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3202         (uriChanged):
3203         (testUnfinishedSubresourceLoad):
3204         (serverCallback):
3205         (beforeAll):
3206
3207 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3208
3209         WTF::Expected should use std::addressof instead of operator&
3210         https://bugs.webkit.org/show_bug.cgi?id=195604
3211
3212         Reviewed by Myles Maxfield.
3213
3214         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3215         (TestWebKitAPI::Unique::Unique):
3216         (TestWebKitAPI::Unique::operator&):
3217         (TestWebKitAPI::TEST):
3218
3219 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3220
3221         Add Optional to Forward.h.
3222         https://bugs.webkit.org/show_bug.cgi?id=195586
3223
3224         Reviewed by Darin Adler.
3225
3226         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3227         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3228         Remove unnecessary includes from headers.
3229
3230 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3231
3232         Add testing API to hit-test and scroll overflow scrollers
3233         https://bugs.webkit.org/show_bug.cgi?id=195278
3234
3235         Reviewed by Antti Koivisto.
3236         
3237         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3238         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3239         
3240         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3241
3242         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3243         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3244         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3245         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3246         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3247         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3248         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3249         (WTR::enclosingScrollViewIncludingSelf):
3250         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3251
3252 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3253
3254         API test WebKit.RequestTextInputContext fails on iOS
3255         https://bugs.webkit.org/show_bug.cgi?id=195585
3256
3257         Reviewed by Wenson Hsieh and Simon Fraser.
3258
3259         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3260         (applyStyle):
3261         (TEST):
3262         Add a viewport, so that the coordinates match up on iOS.
3263         Scroll by moving the UIScrollView's contentOffset.
3264
3265 2019-03-11  Chris Dumez  <cdumez@apple.com>
3266
3267         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3268         https://bugs.webkit.org/show_bug.cgi?id=195506
3269         <rdar://problem/48733477>
3270
3271         Reviewed by Alex Christensen.
3272
3273         Add API test coverage.
3274
3275         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3276
3277 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3278
3279         Adding myself to contributors.json
3280
3281         Unreviewed, addming myself to contributors.json .
3282
3283         * Scripts/webkitpy/common/config/contributors.json:
3284
3285 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3286
3287         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3288         https://bugs.webkit.org/show_bug.cgi?id=195511
3289         <rdar://problem/44873269>
3290
3291         Reviewed by Darin Adler.
3292
3293         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3294         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3295         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3296         (TEST_F):
3297
3298 2019-03-11  Chris Dumez  <cdumez@apple.com>
3299
3300         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3301         https://bugs.webkit.org/show_bug.cgi?id=195561
3302
3303         Reviewed by Youenn Fablet.
3304
3305         Make sure the JS in the test requests for permission to receive device orientation events.
3306
3307         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3308
3309 2019-03-11  Youenn Fablet  <youenn@apple.com>
3310
3311         Allow storage quota increase by default in WTR
3312         https://bugs.webkit.org/show_bug.cgi?id=195541
3313
3314         Reviewed by Geoffrey Garen.
3315
3316         Allow storage quota increase by default in WTR.
3317         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3318         Use this for tests that explicitly need cache increase.
3319
3320         Instead of increasing quota by 2, make sure the next request is
3321         granted by adding all given parameters.
3322
3323         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3324         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3325         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3326         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3327         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3328         * WebKitTestRunner/TestController.cpp:
3329         (WTR::TestController::setAllowStorageQuotaIncrease):
3330         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3331         * WebKitTestRunner/TestController.h:
3332         * WebKitTestRunner/TestInvocation.cpp:
3333         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3334         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3335         (WTR::TestController::cocoaResetStateToConsistentValues):
3336         (WTR::TestController::setAllowStorageQuotaIncrease):
3337         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3338         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3339         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3340
3341 2019-03-11  Xan Lopez  <xan@igalia.com>
3342
3343         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3344         https://bugs.webkit.org/show_bug.cgi?id=194147
3345
3346         Reviewed by Michael Saboff.
3347
3348         To make --32-bit work correctly on Linux/64bit we need to:
3349
3350         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3351         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3352         unfortunately CMake only allows us to do this during
3353         crosscompilation, which is overkill here.
3354         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3355         pkg-config detection module uses the x86 .pc files instead of the
3356         x86_64 ones.
3357         - Set the -m32 flags for the compiler.
3358
3359         * Scripts/webkitdirs.pm:
3360         (generateBuildSystemFromCMakeProject):
3361
3362 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3363
3364         Add MotionMark-1.1 plan file for run-benchmark script.
3365         https://bugs.webkit.org/show_bug.cgi?id=195481
3366
3367         Rubber-stamped by Darin Adler.
3368
3369         Run-benchmark script should support MontionMark-1.1.
3370
3371         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3372
3373 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3374
3375         [ews-app] Add support for submit-to-ews url
3376         https://bugs.webkit.org/show_bug.cgi?id=195477
3377
3378         Reviewed by Lucas Forschler.
3379
3380         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3381         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3382         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3383         * BuildSlaveSupport/ews-app/ews/urls.py:
3384         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3385
3386 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3387
3388         Unreviewed, rolling out r242688, r242643, r242624.
3389
3390         Caused multiple layout test failures and crashes on iOS and macOS.
3391
3392         Reverted changeset:
3393
3394         "requestAnimationFrame should execute before the next frame"
3395         https://bugs.webkit.org/show_bug.cgi?id=177484
3396         https://trac.webkit.org/changeset/242624/webkit
3397
3398         * Tracing/SystemTracePoints.plist:
3399
3400 2019-03-11  John Wilander  <wilander@apple.com>
3401
3402         Resource Load Statistics: Make it possible exclude localhost from classification
3403         https://bugs.webkit.org/show_bug.cgi?id=195474
3404         <rdar://problem/47520577>
3405
3406         Reviewed by Brent Fulgham.
3407
3408         This patch allows for localhost to be excluded from classification and
3409         treatment as a prevalent resource.
3410
3411         The WebKit Tools change adds a new function called
3412         testRunner.setStatisticsIsRunningTest() which can be used to control this
3413         behavior.
3414
3415         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3416         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3417         (WTR::TestRunner::setStatisticsIsRunningTest):
3418         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3419         * WebKitTestRunner/TestController.cpp:
3420         (WTR::TestController::setStatisticsIsRunningTest):
3421         * WebKitTestRunner/TestController.h:
3422         * WebKitTestRunner/TestInvocation.cpp:
3423         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3424
3425 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3426
3427         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3428         https://bugs.webkit.org/show_bug.cgi?id=195560
3429
3430         Reviewed by Lucas Forschler.
3431
3432         * BuildSlaveSupport/ews-build/master.cfg:
3433
3434 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3435
3436         Unreviewed, rolling out r242698.
3437
3438         API test crashes on bots.
3439
3440         Reverted changeset:
3441
3442         "Add a WKContentRuleList variant that uses copied memory
3443         instead of mmap'd shared memory for class A containerized
3444         apps"
3445         https://bugs.webkit.org/show_bug.cgi?id=195511
3446         https://trac.webkit.org/changeset/242698
3447
3448 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3449
3450         [WPE] Enable web process sandbox
3451         https://bugs.webkit.org/show_bug.cgi?id=195169
3452
3453         Reviewed by Daniel Bates.
3454
3455         * wpe/install-dependencies:
3456         * wpe/jhbuild.modules:
3457
3458 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3459
3460         [ews-app] Use port 17000 for worker communication
3461         https://bugs.webkit.org/show_bug.cgi?id=195558
3462
3463         Reviewed by Lucas Forschler.
3464
3465         * BuildSlaveSupport/ews-build/master.cfg:
3466
3467 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3468
3469         [ews-build] unit-tests fail when passwords.json is missing
3470         https://bugs.webkit.org/show_bug.cgi?id=195557
3471
3472         Reviewed by Lucas Forschler.
3473
3474         * BuildSlaveSupport/ews-build/loadConfig.py:
3475         (loadBuilderConfig):
3476         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3477         (ConfigDotJSONTest.test_configuration):
3478         * BuildSlaveSupport/ews-build/master.cfg:
3479
3480 2019-03-11  Truitt Savell  <tsavell@apple.com>
3481
3482         Unreviewed, rolling out r242702.
3483
3484         Broke High Sierra builders.
3485
3486         Reverted changeset:
3487
3488         "Add utility function to allow easy reverse range-based
3489         iteration of a container"
3490         https://bugs.webkit.org/show_bug.cgi?id=195542
3491         https://trac.webkit.org/changeset/242702
3492
3493 2019-03-11  Sam Weinig  <sam@webkit.org>
3494
3495         Add utility function to allow easy reverse range-based iteration of a container
3496         https://bugs.webkit.org/show_bug.cgi?id=195542
3497
3498         Reviewed by Antti Koivisto.
3499
3500         * TestWebKitAPI/CMakeLists.txt:
3501         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3502         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3503         (TestWebKitAPI::TEST):
3504         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3505
3506 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3507
3508         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3509         https://bugs.webkit.org/show_bug.cgi?id=195511
3510         <rdar://problem/44873269>
3511
3512         Reviewed by Darin Adler.
3513
3514         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3515         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3516         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3517         (TEST_F):
3518
3519 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3520
3521         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3522         https://bugs.webkit.org/show_bug.cgi?id=195499
3523
3524         Reviewed by Darin Adler.
3525
3526         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3527         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3528         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3529         (-[WKWebView synchronouslyFocusTextInputContext:]):
3530         (applyStyle):
3531         (applyIframe):
3532         (TEST):
3533         Add some tests for this SPI.
3534
3535 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3536
3537         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3538         https://bugs.webkit.org/show_bug.cgi?id=181151
3539
3540         Reviewed by Don Olmstead.
3541
3542         * TestWebKitAPI/CMakeLists.txt:
3543         * TestWebKitAPI/PlatformWin.cmake:
3544         Enable TestWTF RunLoop tests in all platforms.
3545
3546         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3547         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3548         (TestWebKitAPI::DerivedOneShotTimer::fired):
3549         (TestWebKitAPI::TEST):
3550         Only a few platforms support nested RunLoop.
3551
3552         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3553         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3554
3555 2019-03-10  David Quesada  <david_quesada@apple.com>
3556
3557         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3558         https://bugs.webkit.org/show_bug.cgi?id=152480
3559
3560         Reviewed by Chris Dumez.
3561
3562         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3563         there are no additional references to the process pool besides the one held by
3564         the download, waits for the download to finish (in the sense that the
3565         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3566         measure, also check that the process pool has been deallocated at the end of the
3567         test. The test wouldn't be meaningful if the process pool were still alive.
3568
3569         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3570         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3571         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3572             The download will be canceled because the delegate does not implement the
3573             method to decide the download's destination, so this is where we know the
3574             DownloadProxyMap is done with the DownloadProxy.
3575         (TEST):
3576
3577 2019-03-08  Chris Dumez  <cdumez@apple.com>
3578
3579         Add support for Device Orientation / Motion permission API
3580         https://bugs.webkit.org/show_bug.cgi?id=195329
3581         <rdar://problem/47645367>
3582
3583         Reviewed by Geoffrey Garen.
3584
3585         Add test infrastructure to help test the Device Orientation / Motion permission API.
3586
3587         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3588         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3589         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3590         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3591         * WebKitTestRunner/TestController.cpp:
3592         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3593         (WTR::TestController::createWebViewWithOptions):
3594         (WTR::TestController::resetStateToConsistentValues):
3595         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3596         * WebKitTestRunner/TestController.h:
3597         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3598         * WebKitTestRunner/TestInvocation.cpp:
3599         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3600
3601 2019-03-08  Saam barati  <sbarati@apple.com>
3602
3603         Add a compare-results script to compare benchmark results
3604         https://bugs.webkit.org/show_bug.cgi?id=195486
3605         <rdar://problem/48723397>
3606
3607         Reviewed by Geoffrey Garen.
3608
3609         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3610         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3611         to extend it to learn about our other benchmarks.
3612
3613         * Scripts/compare-results: Added.
3614         (readJSONFile):
3615         (detectJetStream2):
3616         (JetStream2Results):
3617         (detectSpeedometer2):
3618         (Speedometer2Results):
3619         (detectPLT5):
3620         (PLT5Results):
3621         (detectBenchmark):
3622         (biggerIsBetter):
3623         (ttest):
3624         (getOptions):
3625         (main):
3626
3627 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3628
3629         Ensure old tab state is cleared between iterations of run-benchmark
3630         https://bugs.webkit.org/show_bug.cgi?id=195393
3631         <rdar://problem/46885583>
3632
3633         Reviewed by Dewei Zhu.
3634
3635         a) ensure the default to restore state is not set
3636         b) terminate Safari correctly
3637         c) Set the system default to ignore Persistent State in Safari
3638
3639         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3640         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3641         (OSXBrowserDriver.prepare_env): 
3642         (OSXBrowserDriver.restore_env):
3643         (OSXBrowserDriver.close_browsers):
3644         (OSXBrowserDriver._terminate_processes):
3645         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3646         (OSXChromeDriver):
3647         (OSXChromeCanaryDriver):
3648         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3649         (OSXFirefoxDriver):
3650         (OSXFirefoxNightlyDriver):
3651         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3652         (OSXSafariDriver):
3653         (OSXSafariDriver.prepare_env):
3654
3655 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3656
3657         [GTK] Several InputMethodFilter tests are failing
3658         https://bugs.webkit.org/show_bug.cgi?id=195408
3659
3660         Reviewed by Carlos Garcia Campos.
3661
3662         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3663         Regressed in r241751.
3664         Hexadecimal values of keycodes are expressed now in upper letters.
3665         Composited characters should be cast to UTF8 strings.
3666
3667         (TestWebKitAPI::TEST):
3668
3669 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3670
3671         [GTK] Make Tools/gtkdoc python3 compatible
3672         https://bugs.webkit.org/show_bug.cgi?id=195359
3673
3674         Reviewed by Carlos Garcia Campos.
3675
3676         * gtkdoc/generate-gtkdoc:
3677         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3678         work with Python 2 and 3.
3679         (get_gtkdoc_module_paths):
3680         The iteritems() was removed in Python 3, so let's use items() that's
3681         available in Python 2 and 3.
3682         (get_generator_for_config):
3683         * gtkdoc/gtkdoc.py:
3684         (GTKDoc._run_command):
3685         The sys.stdout.write() is expecting str in Python 3 and not bytes
3686         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3687         for passing the bytes there.
3688
3689 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3690
3691         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3692         https://bugs.webkit.org/show_bug.cgi?id=195346
3693         <rdar://problem/48667048>
3694
3695         Unreviewed build fix for clang-cl.
3696
3697         * DumpRenderTree/win/DumpRenderTree.cpp:
3698         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3699
3700 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3701
3702         requestAnimationFrame should execute before the next frame
3703         https://bugs.webkit.org/show_bug.cgi?id=177484
3704
3705         Reviewed by Simon Fraser.
3706
3707         Add trace points for the page RenderingUpdate.
3708
3709         * Tracing/SystemTracePoints.plist:
3710
3711 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3712
3713         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3714         https://bugs.webkit.org/show_bug.cgi?id=195353
3715         <rdar://problem/48626394>
3716
3717         Reviewed by Simon Fraser.
3718
3719         * WebKitTestRunner/ios/TestControllerIOS.mm:
3720         (WTR::TestController::platformResetPreferencesToConsistentValues):
3721
3722 2019-03-07  John Wilander  <wilander@apple.com>
3723
3724         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3725         https://bugs.webkit.org/show_bug.cgi?id=195383
3726         <rdar://problem/48570136>
3727
3728         Reviewed by Brent Fulgham.
3729
3730         This patch adds test infrastructure to purge only script-accessible cookies,
3731         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3732
3733         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3734         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3735         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3736         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3737         * WebKitTestRunner/TestController.cpp:
3738         (WTR::TestController::statisticsDeleteCookiesForHost):
3739         * WebKitTestRunner/TestController.h:
3740         * WebKitTestRunner/TestInvocation.cpp:
3741         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3742
3743 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3744
3745         Unreviewed, rolling out r242354.
3746         https://bugs.webkit.org/show_bug.cgi?id=195402
3747
3748         breaks layout tests in all configurations (Requested by
3749         zdobersek on #webkit).
3750
3751         Reverted changeset:
3752
3753         "[WPE] Enable web process sandbox"
3754         https://bugs.webkit.org/show_bug.cgi?id=195169
3755         https://trac.webkit.org/changeset/242354
3756
3757 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3758
3759         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3760         https://bugs.webkit.org/show_bug.cgi?id=195346
3761
3762         Reviewed by Fujii Hironori.
3763
3764         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3765         (TestWebKitAPI::TEST):
3766         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3767
3768         * DumpRenderTree/win/DumpRenderTree.cpp:
3769         (findFontFallback):
3770         (addFontFallbackIfPresent):
3771         (removeFontFallbackIfPresent):
3772         (main):
3773         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3774         (TestWebKitAPI::Util::moduleDirectory):
3775         (TestWebKitAPI::Util::createInjectedBundlePath):
3776         Use wchar helpers as needed.
3777
3778 2019-03-06  Rob Buis  <rbuis@igalia.com>
3779
3780         Consider supporting the `referrerpolicy` attribute.
3781         https://bugs.webkit.org/show_bug.cgi?id=179053
3782
3783         Reviewed by Darin Adler.
3784
3785         Add a runtime flag for referrerpolicy attribute.
3786
3787         * DumpRenderTree/mac/DumpRenderTree.mm:
3788         (enableExperimentalFeatures):
3789
3790 2019-03-05  Daniel Bates  <dabates@apple.com>
3791
3792         Update expected API test result following r242379
3793         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3794
3795         Update expected x-coordinate of selection rect now that the left padding of
3796         a textarea is sized in ems (so dependent on the font size) just like the left
3797         padding of a text field.
3798
3799         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3800         (TestWebKitAPI::TEST):
3801
3802 2019-03-05  David Quesada  <david_quesada@apple.com>
3803
3804         [WK2] It should be possible to follow links with 'download' attributes
3805         https://bugs.webkit.org/show_bug.cgi?id=195145
3806         rdar://problem/48462642
3807
3808         Reviewed by Alex Christensen.
3809
3810         Add a unit test to verify that activating links with 'download' attributes now
3811         navigates to the linked resource, rather than starts downloading it. Add another
3812         to verify that it is still possible to explicitly download the link via the
3813         'Download' navigation action policy.
3814
3815         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3816         (-[DownloadAttributeTestDelegate init]):
3817         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3818         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3819         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3820         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3821         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3822         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3823         (TEST):
3824         * WebKitTestRunner/TestController.cpp:
3825         (WTR::TestController::decidePolicyForNavigationAction):
3826         * WebKitTestRunner/TestController.h:
3827
3828 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3829
3830         [Curl] Implement Cookie Accept Policy.
3831         https://bugs.webkit.org/show_bug.cgi?id=191645
3832
3833         Reviewed by Fujii Hironori.
3834
3835         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3836         (TestWebKitAPI::Curl::TEST_F):
3837
3838 2019-03-05  Youenn Fablet  <youenn@apple.com>
3839
3840         Rename requestCacheStorageSpace to requestStorageSpace
3841         https://bugs.webkit.org/show_bug.cgi?id=195282
3842
3843         Reviewed by Chris Dumez.
3844
3845         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3846         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3847         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3848
3849 2019-03-05  Brady Eidson  <beidson@apple.com>
3850
3851         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3852         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3853
3854         Reviewed by Tim Horton.
3855
3856         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3857         different directory into that same WKWebView should work.
3858
3859         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3860         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3861
3862 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3863
3864         Add WeakHashSet
3865         https://bugs.webkit.org/show_bug.cgi?id=195152
3866
3867         Reviewed by Antti Koivisto.
3868
3869         Added tests for WeakHashSet.
3870
3871         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3872         (TestWebKitAPI::Base::Base): Moved.
3873         (TestWebKitAPI::Derived::foo): Moved.
3874         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3875         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3876         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3877         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3878
3879 2019-03-04  Chris Dumez  <cdumez@apple.com>
3880
3881         Do not share WebProcesses between private and regular sessions
3882         https://bugs.webkit.org/show_bug.cgi?id=195189
3883         <rdar://problem/48421064>
3884
3885         Reviewed by Alex Christensen.
3886
3887         Add API test coverage.
3888
3889         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3890         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3891
3892 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3893
3894         [WPE] Enable web process sandbox
3895         https://bugs.webkit.org/show_bug.cgi?id=195169
3896
3897         Reviewed by Daniel Bates.
3898
3899         * wpe/install-dependencies:
3900         * wpe/jhbuild.modules:
3901
3902 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3903
3904         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3905         https://bugs.webkit.org/show_bug.cgi?id=195206
3906
3907         Reviewed by Žan Doberšek.
3908
3909         Add a new test case.
3910
3911         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3912         (testJSCClass):
3913
3914 2019-03-04  Charlie Turner  <cturner@igalia.com>
3915
3916         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3917         https://bugs.webkit.org/show_bug.cgi?id=194898
3918
3919         Reviewed by Žan Doberšek.
3920
3921         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3922         a GCC extension that permits arithmetic on void* pointer. Inline
3923         the macro until this issue is fixed upstream.
3924
3925 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3926
3927         Rid the world of WK_API_ENABLED
3928         https://bugs.webkit.org/show_bug.cgi?id=195263
3929
3930         Reviewed by Dan Bernstein.
3931
3932         List of changed files elided because it's useless.
3933
3934 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3935
3936         Unreviewed follow-up to r242292.
3937
3938         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3939
3940         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3941         (TestWebKitAPI::testStrip): Renamed from strip.
3942         (TestWebKitAPI::TEST):
3943
3944 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3945
3946         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3947
3948         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3949         and bug #194272 for details.
3950
3951         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3952
3953 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3954
3955         Remove some more unused 32-bit code
3956         https://bugs.webkit.org/show_bug.cgi?id=195255
3957
3958         Reviewed by Darin Adler.
3959
3960         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3961         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3962         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3963         (NPP_New):
3964         (NPP_HandleEvent):
3965         (handleEventCarbon): Deleted.
3966
3967 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3968
3969         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3970
3971         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3972         (TestWebKitAPI::TEST):
3973
3974 2019-03-01  Darin Adler  <darin@apple.com>
3975
3976         Finish removing String::format
3977         https://bugs.webkit.org/show_bug.cgi?id=194893
3978
3979         Reviewed by Daniel Bates.
3980 '
3981         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3982
3983 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3984
3985         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3986         https://bugs.webkit.org/show_bug.cgi?id=195229
3987         <rdar://problem/48520362>
3988
3989         Reviewed by Chris Dumez.
3990
3991         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3992         (TEST):
3993
3994 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3995
3996         Add a system trace scope for event region building
3997         https://bugs.webkit.org/show_bug.cgi?id=195226
3998
3999         Reviewed by Jon Lee.
4000
4001         This trace scope measures the time spend converting element rects into Region objects,
4002         which can be large on some pages.
4003
4004         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4005
4006         * Tracing/SystemTracePoints.plist:
4007
4008 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4009
4010         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4011         https://bugs.webkit.org/show_bug.cgi?id=194612
4012
4013         Reviewed by Alex Christensen.
4014
4015         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4016         Just test the new string-processing function and don't touch the actual environment.
4017         (Test cases are all as before, but based on operator== instead of strcmp.)
4018
4019 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4020
4021         [ews-app] Update primary keys for handling multiple Buildbot instances
4022         https://bugs.webkit.org/show_bug.cgi?id=195120
4023
4024         Reviewed by Stephanie Lewis.
4025
4026         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4027         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4028         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4029
4030         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4031         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4032         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4033         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4034         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4035         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4036
4037 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4038
4039         [WinCairo] Enable service worker
4040         https://bugs.webkit.org/show_bug.cgi?id=188318
4041
4042         Reviewed by Youenn Fablet.
4043
4044         * DumpRenderTree/DumpRenderTreePrefix.h:
4045         * TestWebKitAPI/PlatformWin.cmake:
4046         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4047         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4048         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4049
4050 2019-03-01  Justin Fan  <justin_fan@apple.com>
4051
4052         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4053         https://bugs.webkit.org/show_bug.cgi?id=195191
4054
4055         Rubber-stamped by Dean Jackson.
4056
4057         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4058
4059         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4060
4061 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4062
4063         Unreviewed, fix lldb webkitpy tests
4064         https://bugs.webkit.org/show_bug.cgi?id=194375
4065
4066         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4067
4068         * lldb/lldb_webkit.py:
4069         (WTFStringImplProvider.is_8bit):
4070
4071 2019-02-28  David Quesada  <david_quesada@apple.com>
4072
4073         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4074         https://bugs.webkit.org/show_bug.cgi?id=195121
4075         rdar://problem/48450302
4076
4077         Reviewed by Alex Christensen.
4078
4079         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4080         configurations where the 'download' attribute is absent, blank, or populated
4081         with a filename, and where the anchor element is same-origin or cross-origin
4082         (meaning the 'download' attribute shouldn't be honored).
4083
4084         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4085         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4086         (-[NavigationActionTestDelegate init]):
4087         (-[NavigationActionTestDelegate navigationAction]):
4088         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4089         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4090         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4091         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4092         (TEST):
4093
4094 2019-02-28  Antoine Quint  <graouts@apple.com>
4095
4096         Enable the Pointer Events runtime flag by default
4097         https://bugs.webkit.org/show_bug.cgi?id=195156
4098
4099         Reviewed by Dean Jackson.
4100
4101         * DumpRenderTree/mac/DumpRenderTree.mm:
4102         (enableExperimentalFeatures):
4103
4104 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4105
4106         Several PasteImage API tests are flaky
4107         https://bugs.webkit.org/show_bug.cgi?id=195160
4108
4109         Reviewed by Tim Horton.
4110
4111         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4112         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4113         listening for a "load" event after image load is already complete.
4114
4115         To address this, make these tests first register a "load" event handler, then run script to insert an image
4116         element into the document, and finally wait until the load event is observed before checking image size.
4117
4118         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4119
4120 2019-02-28  Chris Dumez  <cdumez@apple.com>
4121
4122         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4123         https://bugs.webkit.org/show_bug.cgi?id=195107
4124
4125         Reviewed by Alex Christensen.
4126
4127         Give some time for the zoom level to get restored.
4128
4129         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4130
4131 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4132
4133         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4134         https://bugs.webkit.org/show_bug.cgi?id=194958
4135
4136         Reviewed by Geoffrey Garen.
4137
4138         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4139         (TEST):
4140
4141 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4142
4143         [ews-app] Update method to save build to handle builder_display_name
4144         https://bugs.webkit.org/show_bug.cgi?id=195047
4145
4146         Reviewed by Dewei Zhu.
4147
4148         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4149         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4150
4151 2019-02-28  Justin Fan  <justin_fan@apple.com>
4152
4153         [Web GPU] Enable Web GPU only on 64-bit
4154         https://bugs.webkit.org/show_bug.cgi?id=195139
4155
4156         Because Metal is only supported on 64 bit apps.
4157
4158         Unreviewed build fix.
4159
4160         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4161
4162 2019-02-27  Youenn Fablet  <youenn@apple.com>
4163
4164         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4165         https://bugs.webkit.org/show_bug.cgi?id=194959
4166
4167         Reviewed by Chris Dumez.
4168
4169         Spin loop until getting the condition to remove flakiness.
4170
4171         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4172
4173 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4174
4175         [ews-build] Buildbot should include builder_display_name in the build events
4176         https://bugs.webkit.org/show_bug.cgi?id=195045
4177
4178         Reviewed by Dewei Zhu.
4179
4180         * BuildSlaveSupport/ews-build/events.py:
4181         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4182         buildername to builder_name to be consistent in naming style.
4183         (Events.buildFinished): Ditto.
4184
4185 2019-02-27  Chris Dumez  <cdumez@apple.com>
4186
4187         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4188         https://bugs.webkit.org/show_bug.cgi?id=194480
4189
4190         Reviewed by Brady Eidson.
4191
4192         Update existing API test to make it more likely to reproduce the issue.
4193
4194         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4195
4196 2019-02-27  Brady Eidson  <beidson@apple.com>
4197
4198         Universal links from Google search results pages don't open the app.
4199         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4200
4201         Reviewed by Geoffrey Garen.
4202
4203         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4204         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4205         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4206         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4207
4208 2019-02-27  Chris Dumez  <cdumez@apple.com>
4209
4210         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4211         https://bugs.webkit.org/show_bug.cgi?id=195102
4212
4213         Reviewed by Geoffrey Garen.
4214
4215         If the number of processes is not yet what we expect, wait a bit and check again to give
4216         processes some time to exit.
4217
4218         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4219
4220 2019-02-27  Chris Dumez  <cdumez@apple.com>
4221
4222         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4223         https://bugs.webkit.org/show_bug.cgi?id=194545
4224
4225         Reviewed by Brady Eidson.
4226
4227         Make sure the test navigates forward and then back only once. Previously, navigating
4228         back would trigger a navigation again in a timer.
4229
4230         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4231
4232 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4233
4234         High Sierra Debug JSC test queue should use faster hardware
4235         https://bugs.webkit.org/show_bug.cgi?id=194603
4236
4237         Rubber-stamped by Alexey Proskuryakov.
4238
4239         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4240
4241         * BuildSlaveSupport/build.webkit.org-config/config.json:
4242         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4243         (BubbleQueueServer):
4244         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4245         (WebKitBuildbot):
4246         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4247         * QueueStatusServer/config/queues.py:
4248         * Scripts/webkitpy/common/config/ews.json:
4249         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4250         (test_ews_name):
4251
4252 2019-02-27  John Wilander  <wilander@apple.com>
4253
4254         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4255         https://bugs.webkit.org/show_bug.cgi?id=195071
4256         <rdar://problem/48417690>
4257
4258         Reviewed by Alex Christensen and Brent Fulgham.
4259
4260         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4261         (TestWebKitAPI::createURL):
4262             Convenience function.
4263         (TestWebKitAPI::TEST):
4264             WebCore::AdClickAttribution now takes a URL when creating Source and
4265             Destination.
4266         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4267         (TestWebKitAPI::TEST):
4268             WebCore::AdClickAttribution now takes a URL when creating Source and
4269             Destination.
4270
4271 2019-02-27  Antoine Quint  <graouts@apple.com>
4272
4273         Support Pointer Events on macOS
4274         https://bugs.webkit.org/show_bug.cgi?id=195008
4275         <rdar://problem/47454419>
4276
4277         Reviewed by Dean Jackson.
4278
4279         * DumpRenderTree/mac/DumpRenderTree.mm:
4280         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4281         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4282
4283 2019-02-26  Mark Lam  <mark.lam@apple.com>
4284
4285         Remove remaining poisoning code.
4286         https://bugs.webkit.org/show_bug.cgi?id=194138
4287
4288         Reviewed by Saam Barati.
4289
4290         * TestWebKitAPI/CMakeLists.txt:
4291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4292         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4293         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4294         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4295         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4296         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4297         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4298
4299 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4300
4301         Move ephemeral local storage from WebProcess to UIProcess
4302         https://bugs.webkit.org/show_bug.cgi?id=195074
4303         <rdar://problem/47937975>
4304
4305         Reviewed by Geoff Garen.
4306
4307         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4308
4309 2019-02-20  Jer Noble  <jer.noble@apple.com>
4310
4311         [Cocoa] Media elements will restart network buffering just before suspending
4312         https://bugs.webkit.org/show_bug.cgi?id=193691
4313
4314         Reviewed by Eric Carlson.
4315
4316         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4317         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4318         (TEST):
4319
4320 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4321
4322         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4323         https://bugs.webkit.org/show_bug.cgi?id=191652
4324
4325         Reviewed by Alex Christensen.
4326
4327         Fix WinCairo MiniBrowser behavior of authentication dialog.
4328
4329         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4330         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4331
4332 2019-02-26  Youenn Fablet  <youenn@apple.com>
4333
4334         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4335         https://bugs.webkit.org/show_bug.cgi?id=195028
4336         <rdar://problem/48243733>
4337
4338         Reviewed by Eric Carlson.
4339
4340         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4341
4342 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4343
4344         [WPE] Add API for webview background color configuration
4345         https://bugs.webkit.org/show_bug.cgi?id=192305
4346
4347         Reviewed by Michael Catanzaro.
4348
4349         * MiniBrowser/wpe/main.cpp:
4350         (main): Add a new option to configure the webview background
4351         color. Example: --bg-color=transparent.
4352         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4353         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4354         (beforeAll): Ditto.
4355
4356 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4357
4358         scalableNativeWebpageParameters() is not preserved on new page navigation.
4359         https://bugs.webkit.org/show_bug.cgi?id=194892
4360         <rdar://problem/47538280>
4361
4362         Reviewed by Wenson Hsieh.
4363         
4364         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4365
4366         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4367         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4368         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4369         (WTR::UIScriptController::allowsViewportShrinkToFit):
4370         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4371         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: