EWS should check if the patch is still valid before executing every major step
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
2
3         EWS should check if the patch is still valid before executing every major step
4         https://bugs.webkit.org/show_bug.cgi?id=160739
5         rdar://problem/27768813
6
7         Reviewed by Alexey Proskuryakov.
8
9         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
10         (CommitQueueTask.run): validate method is now executed in base class.
11         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
12         (EarlyWarningSystemTask.run): validate method is now executed in base class.
13         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
14         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
15         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
16         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
17         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
18         * Scripts/webkitpy/tool/commands/perfalizer.py:
19         (PerfalizerTask.validate): Added.
20         * Scripts/webkitpy/tool/commands/queues_unittest.py:
21         (test_manual_reject_during_processing): Updated test case.
22
23 2016-08-11  Alex Christensen  <achristensen@webkit.org>
24
25         Add URLParser stub
26         https://bugs.webkit.org/show_bug.cgi?id=160770
27
28         Reviewed by Sam Weinig.
29
30         * TestWebKitAPI/PlatformGTK.cmake:
31         * TestWebKitAPI/PlatformWin.cmake:
32         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
33         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
34         (TestWebKitAPI::TEST_F):
35
36 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
37
38         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
39         https://bugs.webkit.org/show_bug.cgi?id=160761
40
41         Reviewed by Tim Horton.
42
43         Give iOS DRT a Launch storyboard.
44
45         Have it use a UIViewController so future forms testing works correctly.
46
47         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
48         can run in iPad mode.
49
50         Remove empty InfoPlist.strings files.
51
52         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
53         * DumpRenderTree/ios/Info.plist:
54         * DumpRenderTree/ios/Launch.storyboard: Added.
55         * DumpRenderTree/mac/DumpRenderTree.mm:
56         (createWebViewAndOffscreenWindow):
57         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
58         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
59         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
60         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
61
62 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
63
64         [Win] Unable to reliably run tests in parallel
65         https://bugs.webkit.org/show_bug.cgi?id=140914
66
67         Reviewed by Brent Fulgham.
68
69         The cygpath utility function can fail badly when running with multiple DumpRenderTree
70         processes. We can use string replacement to convert the Cygwin path to a Windows path
71         instead.
72
73         * Scripts/webkitpy/common/system/path.py:
74         (cygpathFast):
75         * Scripts/webkitpy/port/driver.py:
76         (Driver._command_from_driver_input):
77
78 2016-08-10  Alex Christensen  <achristensen@webkit.org>
79
80         Fix crash when changing cookie accept policy after r204327
81         https://bugs.webkit.org/show_bug.cgi?id=160758
82
83         Reviewed by Simon Fraser.
84
85         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
86         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
87         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
88         (TEST):
89         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
90
91 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
92
93         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
94         https://bugs.webkit.org/show_bug.cgi?id=160757
95
96         Reviewed by Tim Horton.
97
98         When programmatically creating the test UIWindow, make a root UIViewController and parent
99         the WKWebView in its view. This makes the app more like a normal UIKit application.
100         
101         Move the WKWebView down 20px to avoid the status bar.
102         
103         Give the UIWindow a gray background so it's obvious where the window and view positioned.
104
105         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
106         
107         Remove duplicate references to Launch.storyboard.
108
109         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
110         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
111         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
112         (-[AppDelegate applicationWillResignActive:]): Deleted.
113         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
114         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
115         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
116         (-[AppDelegate applicationWillTerminate:]): Deleted.
117         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
118         (WTR::viewRectForWindowRect):
119         (WTR::PlatformWebView::PlatformWebView):
120         (WTR::PlatformWebView::setWindowFrame):
121
122 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
123
124         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
125         https://bugs.webkit.org/show_bug.cgi?id=160748
126
127         Reviewed by Tim Horton.
128         
129         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
130         opens the door for tests using other device sizes.
131
132         * WebKitTestRunner/ios/TestControllerIOS.mm:
133         (WTR::TestController::platformConfigureViewForTest):
134
135 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
136
137         Sort the feature flags in the FEATURE_DEFINES lines
138         https://bugs.webkit.org/show_bug.cgi?id=160742
139
140         Reviewed by Anders Carlsson.
141         
142         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
143
144 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
145
146         Logging and other minor improvements to iOS webkitpy
147         https://bugs.webkit.org/show_bug.cgi?id=160722
148
149         Reviewed by Dan Bates.
150
151         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
152         to make it easier to debug launching issues.
153
154         Have reset_preferences() reset the device, rather than just nuking the data
155         directory (which broke some versions of the simulator).
156
157         Make the Simulator.app launch in the background with open -g.
158
159         Wait for the simulator device to be in a known state in some more places.
160
161         * Scripts/webkitpy/port/ios.py:
162         (IOSSimulatorPort.setup_test_run):
163         (IOSSimulatorPort._quit_ios_simulator):
164         (IOSSimulatorPort.clean_up_test_run):
165         (IOSSimulatorPort.setup_environ_for_server):
166         (IOSSimulatorPort.reset_preferences):
167         * Scripts/webkitpy/xcode/simulator.py:
168         (Device.create):
169         (Device.delete):
170         (Device):
171         (Device.reset):
172         (Simulator.wait_until_device_is_booted):
173         (Simulator.wait_until_device_is_in_state):
174         (Simulator):
175         (Simulator.delete_device):
176         (Simulator.reset_device):
177         (Simulator.lookup_or_create_device):
178
179 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
180
181         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
182         https://bugs.webkit.org/show_bug.cgi?id=160697
183
184         Reviewed by Antonio Gomes.
185
186         * Scripts/webkitpy/port/base.py:
187         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
188         list of environment variables to copy.
189
190 2016-08-09  George Ruan  <gruan@apple.com>
191
192         Implement functionality of media capture on iOS
193         https://bugs.webkit.org/show_bug.cgi?id=158945
194         <rdar://problem/26893343>
195
196         Reviewed by Tim Horton.
197
198         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
199         Capture feature on iOS.
200
201 2016-08-09  Saam Barati  <sbarati@apple.com>
202
203         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
204         https://bugs.webkit.org/show_bug.cgi?id=160671
205         <rdar://problem/27756112>
206
207         Reviewed by Mark Lam.
208
209         * Scripts/run-jsc-stress-tests:
210
211 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
212
213         Make directory reading code in iOSSimulatorDevices() more strict
214         https://bugs.webkit.org/show_bug.cgi?id=160702
215
216         Reviewed by Tim Horton.
217
218         * Scripts/webkitdirs.pm:
219         (iOSSimulatorDevices):
220
221 2016-08-06  Sam Weinig  <sam@webkit.org>
222
223         Replace NodeOrString with std::variant<RefPtr<Node>, String>
224         https://bugs.webkit.org/show_bug.cgi?id=160638
225
226         Reviewed by Anders Carlsson.
227
228         * TestWebKitAPI/CMakeLists.txt:
229         * TestWebKitAPI/Tests/WTF/Variant.cpp:
230         Add additional tests for the initial state of std::variant and using
231         makeVisitor for visiting.
232
233 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
234
235         EWS logging should ensure the logging to file is stopped on queue termination
236         https://bugs.webkit.org/show_bug.cgi?id=160698
237         rdar://problem/24464570
238
239         Reviewed by Daniel Bates.
240
241         * Scripts/webkitpy/tool/bot/queueengine.py:
242         (QueueEngine._stopping): Stop logging to file on queue termination.
243         (QueueEngine._begin_logging): Configure the Python logger to log to file.
244         * Scripts/webkitpy/common/system/logutils.py:
245         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
246         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
247         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
248         * Scripts/webkitpy/tool/commands/queues.py:
249         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
250         (AbstractQueue.queue_log_path): Same.
251         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
252         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
253         which moved to QueueEngine now.
254         (PatchProcessingQueue.__init__): Same.
255         (CommitQueue.__init__): Same.
256         (AbstractReviewQueue.__init__): Same.
257         (StyleQueue.__init__): Same.
258         * Scripts/webkitpy/tool/commands/queues_unittest.py:
259         (TestCommitQueue): Removed host parameter.
260         (TestCommitQueue.__init__): Same.
261         (AbstractPatchQueueTest.test_next_patch): Same.
262         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
263         (test_commit_queue_failure): Same.
264         (mock_run_webkit_patch):
265         (MockCommitQueueTask.results_from_patch_test_run): Same.
266         (test_rollout_lands): Same.
267         (test_non_valid_patch): Same.
268         (test_auto_retry): Same.
269         (test_style_queue_with_watch_list_exception): Same.
270         (TestQueue.__init__): Deleted.
271         (TestReviewQueue.__init__): Deleted.
272         (TestFeederQueue.__init__): Deleted.
273
274 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
275
276         webkit-gtk tarball fails to build due to missing files
277         https://bugs.webkit.org/show_bug.cgi?id=160684
278
279         Reviewed by Alex Christensen.
280
281         * gtk/manifest.txt.in: Added back spi directories.
282
283 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
284
285         [GTK] Build the jhbuild with -O2 optimization level by default
286         https://bugs.webkit.org/show_bug.cgi?id=160544
287
288         Reviewed by Michael Catanzaro.
289
290         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
291         which don't increases the required disk space significatively and
292         provides better debug information than no passing it.
293
294 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
295
296         Allow more --cmakeargs option in build-jsc and build-webkit
297         https://bugs.webkit.org/show_bug.cgi?id=160340
298
299         Reviewed by Michael Catanzaro.
300
301         * Scripts/build-jsc:
302         * Scripts/build-webkit:
303
304 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
305
306         Do not check if WebKitLibraries folder exists on EFL and GTK
307         https://bugs.webkit.org/show_bug.cgi?id=160659
308
309         Reviewed by Csaba Osztrogonác.
310
311         Though WebKitLibraries is only needed by mac and win ports,
312         EFL and GTK ports have checked whether it exists.
313
314         * Scripts/build-webkit:
315
316 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
317
318         Some EWS console logs doesn't go to log file
319         https://bugs.webkit.org/show_bug.cgi?id=160585
320         rdar://problem/24464570
321
322         Reviewed by Daniel Bates.
323
324         * Scripts/webkitpy/common/system/logutils.py:
325         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
326         any possible overwriting.
327         * Scripts/webkitpy/common/system/filesystem.py:
328         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
329         * Scripts/webkitpy/common/system/filesystem_mock.py:
330         (MockFileSystem.open_text_file_for_writing): Same.
331         * Scripts/webkitpy/common/system/filesystem_unittest.py:
332         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
333         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
334         * Scripts/webkitpy/tool/commands/queues.py:
335         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
336         This will ensure that all the sub-modules inside webkitpy will log to file.
337
338 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
339
340         Have the iOS platform interit from the Apple platform in webkitpy
341         https://bugs.webkit.org/show_bug.cgi?id=160672
342
343         Reviewed by Dan Bates.
344         
345         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
346         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
347         ApplePort.
348         
349         Since WinPort also inherits from ApplePort, it needs to stub out some things
350         that are unavailable on Windows (leaks, sampling).
351         
352         Some SnowLeopard-related code and the associated test were removed.
353
354         * Scripts/webkitpy/port/apple.py:
355         (ApplePort.__init__):
356         (ApplePort):
357         (ApplePort._make_leak_detector):
358         (ApplePort.default_timeout_ms):
359         (ApplePort.supports_per_test_timeout):
360         (ApplePort.should_retry_crashes):
361         (ApplePort._generate_all_test_configurations):
362         (ApplePort.check_for_leaks):
363         (ApplePort.print_leaks_summary):
364         (ApplePort._path_to_webcore_library):
365         (ApplePort.show_results_html_file):
366         (ApplePort._merge_crash_logs):
367         (ApplePort._look_for_all_crash_logs_in_log_dir):
368         (ApplePort._get_crash_log):
369         (ApplePort.look_for_new_crash_logs):
370         (ApplePort.sample_process):
371         (ApplePort.sample_file_path):
372         (ApplePort.look_for_new_samples):
373         (ApplePort._path_to_helper):
374         (ApplePort.determine_full_port_name): Deleted.
375         * Scripts/webkitpy/port/ios.py:
376         (IOSSimulatorPort):
377         (IOSSimulatorPort.__init__):
378         (IOSSimulatorPort.default_timeout_ms): Deleted.
379         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
380         (IOSSimulatorPort.should_retry_crashes): Deleted.
381         (IOSSimulatorPort.check_for_leaks): Deleted.
382         (IOSSimulatorPort.print_leaks_summary): Deleted.
383         (IOSSimulatorPort._path_to_webcore_library): Deleted.
384         (IOSSimulatorPort.show_results_html_file): Deleted.
385         (IOSSimulatorPort.sample_file_path): Deleted.
386         (IOSSimulatorPort._merge_crash_logs): Deleted.
387         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
388         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
389         (IOSSimulatorPort.look_for_new_samples): Deleted.
390         (IOSSimulatorPort.sample_process): Deleted.
391         (IOSSimulatorPort._path_to_helper): Deleted.
392         (IOSSimulatorPort.make_command): Deleted.
393         * Scripts/webkitpy/port/mac.py:
394         (MacPort.__init__):
395         (MacPort.make_command):
396         (MacPort._build_java_test_support):
397         (MacPort): Deleted.
398         (MacPort.default_timeout_ms): Deleted.
399         (MacPort.supports_per_test_timeout): Deleted.
400         (MacPort.should_retry_crashes): Deleted.
401         (MacPort.default_child_processes): Deleted.
402         (MacPort.check_for_leaks): Deleted.
403         (MacPort.print_leaks_summary): Deleted.
404         (MacPort._path_to_webcore_library): Deleted.
405         (MacPort.show_results_html_file): Deleted.
406         (MacPort.sample_file_path): Deleted.
407         (MacPort._merge_crash_logs): Deleted.
408         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
409         (MacPort.look_for_new_crash_logs): Deleted.
410         (MacPort.look_for_new_samples): Deleted.
411         (MacPort.sample_process): Deleted.
412         (MacPort._path_to_helper): Deleted.
413         * Scripts/webkitpy/port/mac_unittest.py:
414         (MacTest.test_default_child_processes): Deleted.
415         * Scripts/webkitpy/port/win.py:
416         (WinPort.look_for_new_samples):
417         (WinPort):
418         (WinPort.sample_process):
419         (WinPort._make_leak_detector):
420         (WinPort.check_for_leaks):
421         (WinPort.print_leaks_summary):
422         (WinPort._path_to_webcore_library):
423
424 2016-08-08  Matt Baker  <mattbaker@apple.com>
425
426         Unreviewed: moved myself to the reviewers list.
427
428         * Scripts/webkitpy/common/config/contributors.json:
429
430 2016-08-08  Chris Dumez  <cdumez@apple.com>
431
432         Update API tests in mac/SetDocumentURI.mm after r204247
433         https://bugs.webkit.org/show_bug.cgi?id=160660
434
435         Reviewed by Alex Christensen.
436
437         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
438         (TestWebKitAPI::TEST):
439
440 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
441
442         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
443         https://bugs.webkit.org/show_bug.cgi?id=159827
444
445         Reviewed by Daniel Bates.
446
447         This change was spurred by a process hang which occurred between tests and did
448         not produce a meaningful crashlog.
449
450         * Scripts/webkitpy/port/driver.py:
451         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
452
453          * Scripts/webkitpy/port/ios.py:
454         (IOSSimulatorPort):
455         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
456         * Scripts/webkitpy/port/mac.py:
457         (MacPort):
458         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
459
460         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
461         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
462
463         * WebKitTestRunner/TestController.h:
464         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
465         * WebKitTestRunner/TestInvocation.cpp:
466         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
467
468 2016-08-07  Dan Bernstein  <mitz@apple.com>
469
470         [Cocoa] Reply block leaks if the remote object doesn’t call it
471         https://bugs.webkit.org/show_bug.cgi?id=160642
472
473         Reviewed by Sam Weinig.
474
475         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
476         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
477         (TEST): Added a test case that checks that the reply block is released even when it’s not
478           called.
479         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
480         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
481           calling the completion handler.
482
483 2016-08-07  Chris Dumez  <cdumez@apple.com>
484
485         Write API test to cover crash fix in r204135
486         https://bugs.webkit.org/show_bug.cgi?id=160587
487
488         Reviewed by Darin Adler.
489
490         Add API test to cover crash fix in r204135. This reproduces the crash
491         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
492         callback.
493
494         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
495         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
496         (TEST):
497
498 2016-08-06  Chris Dumez  <cdumez@apple.com>
499
500         Unreviewed, rolling out r204226.
501
502         Broke some API tests
503
504         Reverted changeset:
505
506         "Write API test to cover crash fix in r204135"
507         https://bugs.webkit.org/show_bug.cgi?id=160587
508         http://trac.webkit.org/changeset/204226
509
510 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
511
512         EWS Style Queue fails to process patches which fails validation
513         https://bugs.webkit.org/show_bug.cgi?id=160632
514
515         Reviewed by Alexey Proskuryakov.
516
517         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
518         (StyleQueueTask.validate): Add more information about validation failure.
519         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
520         * Scripts/webkitpy/tool/commands/queues_unittest.py:
521         (test_non_valid_patch): Add a unit test to test the above code path.
522
523 2016-08-06  Sam Weinig  <sam@webkit.org>
524
525         WTF needs a variant implementation
526         https://bugs.webkit.org/show_bug.cgi?id=160618
527
528         Reviewed by Darin Adler.
529
530         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
531         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
532         Add tests for the variant implementation.
533
534 2016-08-06  Chris Dumez  <cdumez@apple.com>
535
536         Write API test to cover crash fix in r204135
537         https://bugs.webkit.org/show_bug.cgi?id=160587
538
539         Reviewed by Darin Adler.
540
541         Add API test to cover crash fix in r204135. This reproduces the crash
542         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
543         callback.
544
545         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
546         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
547         (TEST):
548
549 2016-08-05  Tim Horton  <timothy_horton@apple.com>
550
551         run-api-tests should use a headed simulator
552         https://bugs.webkit.org/show_bug.cgi?id=160611
553
554         Reviewed by Sam Weinig.
555
556         CADisplayLink doesn't work in a headless simulator, but is
557         vital for the proper functioning of WebKit2 painting on iOS.
558         So, we should not use a headless simulator.
559
560         * Scripts/run-api-tests:
561         Launch a simulator app, don't just boot the simulator.
562
563         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
564         Re-enable a test that works now.
565
566 2016-08-05  Dan Bernstein  <mitz@apple.com>
567
568         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
569         https://bugs.webkit.org/show_bug.cgi?id=160589
570
571         Reviewed by Tim Horton.
572
573         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
574         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
575           blocks, which wasn’t caught because the test wasn’t run correctly.
576         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
577         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
578           added a test that sends over an NSRange.
579         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
580         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
581           handler with the range‘s location and length.
582
583 2016-08-05  Enrica Casucci  <enrica@apple.com>
584
585         Fixing tests failing after r204175.
586
587         Unreviewed.
588
589         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
590
591 2016-08-05  Enrica Casucci  <enrica@apple.com>
592
593         Build fix after 204053.
594
595         Unreviewed.
596
597         * TestWebKitAPI/Configurations/Base.xcconfig:
598         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
599         (-[MockContentFilterEnabler initWithCoder:]):
600         (-[MockContentFilterEnabler dealloc]):
601
602 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
603
604         Print test name in "Last character read from DRT..." error message.
605         https://bugs.webkit.org/show_bug.cgi?id=160559
606
607         Reviewed by Michael Catanzaro.
608
609         * Scripts/webkitpy/port/driver.py:
610         (Driver.run_test):
611         (Driver._read_first_block):
612         (Driver._read_optional_image_block):
613         (Driver._read_block):
614         * Scripts/webkitpy/port/driver_unittest.py:
615         (DriverTest.test_read_block):
616         (DriverTest.test_read_binary_block):
617         (DriverTest.test_read_base64_block):
618
619 2016-08-05  Commit Queue  <commit-queue@webkit.org>
620
621         Unreviewed, rolling out r204123.
622         https://bugs.webkit.org/show_bug.cgi?id=160597
623
624         Caused layout test timeouts on Windows. (Requested by perarne
625         on #webkit).
626
627         Reverted changeset:
628
629         "[Win] Unable to reliably run tests in parallel"
630         https://bugs.webkit.org/show_bug.cgi?id=140914
631         http://trac.webkit.org/changeset/204123
632
633 2016-08-04  Saam Barati  <sbarati@apple.com>
634
635         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
636         https://bugs.webkit.org/show_bug.cgi?id=151241
637
638         Reviewed by Benjamin Poulain.
639
640         * Scripts/run-jsc-stress-tests:
641
642 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
643
644         UI improvements to Flakiness Dashboard.
645         https://bugs.webkit.org/show_bug.cgi?id=153295
646
647         Reviewed by Alexey Proskuryakov.
648
649         * TestResultServer/static-dashboards/flakiness_dashboard.css:
650         (td.options-container): Center text in most fields.
651         * TestResultServer/static-dashboards/flakiness_dashboard.js:
652         (createBugHTML): Text/Grammar updates.
653         (tableHeaders): Ditto.
654         (htmlForSingleTestRow): Ditto.
655         (headerForTestTableHtml): Ditto.
656         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
657         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
658
659 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
660
661         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
662         https://bugs.webkit.org/show_bug.cgi?id=160518
663
664         Reviewed by Michael Catanzaro.
665
666         * Scripts/webkitpy/thirdparty/__init__.py:
667         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
668         * gtk/install-dependencies:
669
670 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
671
672         Optimize bot watcher's dashboard a little
673         https://bugs.webkit.org/show_bug.cgi?id=160515
674         rdar://problem/26096900
675
676         Reviewed by Lucas Forschler.
677
678         Made re-sorting after loading an iteration more efficient.
679
680         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
681         (BuildbotIteration.prototype._updateWithData):
682         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
683         (BuildbotQueue.prototype.updateIterationPosition):
684
685 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
686
687         [Win] Unable to reliably run tests in parallel
688         https://bugs.webkit.org/show_bug.cgi?id=140914
689
690         Reviewed by Brent Fulgham.
691
692         The cygpath utility function can fail badly when running with multiple DumpRenderTree
693         processes. We can use string replacement to convert the Cygwin path to a Windows path
694         instead.
695  
696         * Scripts/webkitpy/common/system/path.py:
697         (cygpathFast):
698         * Scripts/webkitpy/port/driver.py:
699         (Driver._command_from_driver_input):
700
701 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
702
703         Document instructions for increasing process and file limits
704         https://bugs.webkit.org/show_bug.cgi?id=160528
705         rdar://problem/24777576
706
707         Reviewed by Alexey Proskuryakov.
708
709         * Scripts/webkitpy/port/ios.py:
710         (IOSSimulatorPort.default_child_processes):
711
712 2016-08-03  Anders Carlsson  <andersca@apple.com>
713
714         Remove the Objective-C bindings generator
715         https://bugs.webkit.org/show_bug.cgi?id=160526
716
717         Reviewed by Sam Weinig.
718
719         * Scripts/run-bindings-tests:
720         Update test.
721
722 2016-08-03  Tim Horton  <timothy_horton@apple.com>
723
724         Revise a TestWebKitAPI comment to mention the actual underlying problem
725
726         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
727         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
728
729 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
730
731         Benchmark test content-animation timeouts always
732         https://bugs.webkit.org/show_bug.cgi?id=160057
733
734         Reviewed by Simon Fraser.
735
736         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
737         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
738         (start):
739
740 2016-08-02  Nan Wang  <n_wang@apple.com>
741
742         AX: Simulated touch events are not working on iOS
743         https://bugs.webkit.org/show_bug.cgi?id=160395
744         <rdar://problem/27633597>
745
746         Reviewed by Chris Fleizach.
747
748         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
749         (WTR::AccessibilityUIElement::press):
750         (WTR::AccessibilityUIElement::setSelectedChild):
751
752 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
753
754         run-javascriptcore-tests should accept multiple --extra-tests
755         https://bugs.webkit.org/show_bug.cgi?id=160486
756
757         Reviewed by Saam Barati.
758         
759         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
760         test suites. This does it by using GetOpt::Long's array support.
761
762         * Scripts/run-javascriptcore-tests:
763         (runJSCStressTests):
764
765 2016-08-02  Enrica Casucci  <enrica@apple.com>
766
767         Allow building with content filtering disabled.
768         https://bugs.webkit.org/show_bug.cgi?id=160454
769
770         Reviewed by Simon Fraser.
771
772         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
773
774 2016-08-02  Brady Eidson  <beidson@apple.com>
775
776         Removing IndexedDB WebsiteData can fail for some users.
777         https://bugs.webkit.org/show_bug.cgi?id=160463
778
779         Reviewed by Alex Christensen.
780
781         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
782
783 2016-08-01  Alex Christensen  <achristensen@webkit.org>
784
785         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
786         https://bugs.webkit.org/show_bug.cgi?id=160437
787         <rdar://problem/27578272>
788
789         Reviewed by Brady Eidson.
790
791         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
792         (-[DownloadDelegate _download:didReceiveResponse:]):
793         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
794         (runTest):
795         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
796
797 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
798
799         [Tools] The GDB backtrace report tool don't checks the gdb return code.
800         https://bugs.webkit.org/show_bug.cgi?id=160414
801
802         Reviewed by Michael Catanzaro.
803
804         * Scripts/webkitpy/port/linux_get_crash_log.py:
805         (GDBCrashLogGenerator._wait_for_corefile):
806
807 2016-08-01  Youenn Fablet  <youenn@apple.com>
808
809         Make wpt server generate its certificates in layout test results folder
810         https://bugs.webkit.org/show_bug.cgi?id=160422
811
812         Reviewed by Chris Dumez.
813
814         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
815         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
816
817 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
818
819         Function Call on NULL Object
820         https://bugs.webkit.org/show_bug.cgi?id=160325
821
822         Reviewed by Darin Adler.
823
824         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
825         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
826         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
827
828 2016-08-01  Keith Miller  <keith_miller@apple.com>
829
830         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
831         https://bugs.webkit.org/show_bug.cgi?id=160372
832
833         Rubber stamped by Geoffrey Garen.
834
835         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
836         a new top level directory, JSTests. Having the tests in the Source directory
837         was both confusing an inconvenient for people that just want to checkout the
838         source code of WebKit. Since there is no other obvious place to put all the
839         JavaScript tests a new top level directory seemed the most sensible.
840
841         * Scripts/import-test262-tests:
842         * Scripts/run-javascriptcore-tests:
843         * Scripts/update-javascriptcore-test-res:
844
845 2016-07-31  Nan Wang  <n_wang@apple.com>
846
847         AX: Add a check for touch event listener on iOS accessibility object
848         https://bugs.webkit.org/show_bug.cgi?id=160388
849
850         Reviewed by Chris Fleizach.
851
852         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
853         (AccessibilityUIElement::boolAttributeValue):
854         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
855         (WTR::AccessibilityUIElement::boolAttributeValue):
856
857 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
858
859         Unreviewed: add myself to the reviewers list.
860
861         * Scripts/webkitpy/common/config/contributors.json:
862
863 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
864
865         Undo r203939, and copy over a rule that clips the logos.
866
867         Sierra wasn't the only logo without transparency.
868
869         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
870         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
871         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
872
873 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
874
875         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
876         https://bugs.webkit.org/show_bug.cgi?id=160377
877
878         Reviewed by Brian Weinstein.
879
880         Update assets to remove the white background and use a transparent background instead.
881
882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
883         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
884
885 2016-07-29  David Kilzer  <ddkilzer@apple.com>
886
887         Ignore most check-webkit-style checks for ANGLE project
888         <https://webkit.org/b/160333>
889
890         Reviewed by Daniel Bates.
891
892         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
893         - No tabs.
894         - No spaces at the end of lines.
895         - No carriage returns (DOS line endings).
896
897 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
898
899         Media controls are not displayed for some autoplaying videos at certain browser dimensions
900         https://bugs.webkit.org/show_bug.cgi?id=160360
901         <rdar://problem/27179484>
902
903         Reviewed by Myles C. Maxfield.
904
905         Adds two tests verifying that videos may be considered main content as long as they
906         are large enough and cover a majority of the mainframe's viewport.
907
908         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
909         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
910         (TestWebKitAPI::TEST):
911         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
912         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
913
914 2016-07-29  Mark Lam  <mark.lam@apple.com>
915
916         Gardening: removed unused variable.
917
918         Not reviewed.
919
920         * TestWebKitAPI/Tests/WTF/StringView.cpp:
921         (TestWebKitAPI::TEST):
922
923 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
924
925         Add TestWebKitAPI support for interacting with media controls
926         https://bugs.webkit.org/show_bug.cgi?id=160342
927         <rdar://problem/27610246>
928
929         Reviewed by Beth Dakin.
930
931         Adds support for testing interaction with some media controls, as well as a basic test
932         verifying that media control teardown after interaction does not result in a crash.
933
934         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
935         (-[WKWebView mouseDownAtPoint:]):
936         (-[WKWebView performAfterLoading:]):
937         (TestWebKitAPI::TEST):
938
939 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
940
941         Crash Log Clobbering on Unbound Crashes
942         https://bugs.webkit.org/show_bug.cgi?id=160198
943         <rdar://problem/27472618>
944
945         Reviewed by Alexey Proskuryakov.
946
947         * Scripts/webkitpy/common/system/crashlogs.py:
948         (CrashLogs): Fix header order.
949         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
950         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
951
952 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
953
954         Update for contributors.json
955         https://bugs.webkit.org/show_bug.cgi?id=160294
956
957         * Scripts/webkitpy/common/config/contributors.json:
958
959 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
960
961         Remove deprecated SPI for video inline / fullscreen controls
962         https://bugs.webkit.org/show_bug.cgi?id=160318
963
964         Reviewed by Tim Horton.
965
966         * DumpRenderTree/mac/DumpRenderTree.mm:
967         (setDefaultsToConsistentValuesForTesting): Deleted.
968         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
969         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
970         * WebKitTestRunner/TestController.cpp:
971         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
972         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
973         (WTR::initializeWebViewConfiguration): Deleted.
974
975 2016-07-28  Daniel Bates  <dabates@apple.com>
976
977         [iOS] TestWebKitAPI bundle targets are not code signed
978         https://bugs.webkit.org/show_bug.cgi?id=160328
979         <rdar://problem/27409246>
980
981         Reviewed by Andy Estes.
982
983         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
984         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
985         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
986
987         * TestWebKitAPI/Configurations/Base.xcconfig:
988
989 2016-07-28  Tim Horton  <timothy_horton@apple.com>
990
991         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
992
993         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
994         (animatedResizeWebView):
995         (TEST):
996         This test times out only when run in the WebKit Testing simulator environment,
997         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
998
999 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1000
1001         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1002         https://bugs.webkit.org/show_bug.cgi?id=160289
1003         <rdar://problem/27553464>
1004
1005         Reviewed by Simon Fraser.
1006
1007         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1008         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1009         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1010         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1011         (-[AnimatedResizeWebView _endAnimatedResize]):
1012         (animatedResizeWebView):
1013         (TEST):
1014         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1015         Add two tests that ensure that hidden-content and animated resizes
1016         don't cause unnecessary synchronous waits. Only the hidden-content
1017         one fails before my patch, but it seemed reasonable to add both anyway.
1018
1019 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1020
1021         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1022         <https://webkit.org/b/83342>
1023
1024         Reviewed by Ryosuke Niwa.
1025
1026         * Scripts/webkitpy/common/checkout/scm/git.py:
1027         (Git.revisions_changing_file): Remove code to raise an exception
1028         when the file doesn't exist.  If a file was moved or renamed,
1029         then this caused the script to terminate, which was very
1030         frustrating when you wanted a list of reviewers.
1031         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1032         (SCMTest._shared_test_revisions_changing_file): Update test
1033         expectation to return an empty list of revisions.
1034         (test_create_patch_is_full_patch): Drive-by fix when running all
1035         webkitpy tests (including scm tests).
1036         * Scripts/webkitpy/common/checkout/scm/svn.py:
1037         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1038         return an empty array of revisions if this occurs.
1039
1040 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1041
1042         EWS error message "Error: * did not process patch" should include explanation
1043         https://bugs.webkit.org/show_bug.cgi?id=159903
1044         <rdar://problem/27410788>
1045
1046         Reviewed by Alexey Proskuryakov.
1047
1048         * QueueStatusServer/handlers/statusbubble.py:
1049         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1050         is not processed.
1051         * QueueStatusServer/handlers/processingtimesjson.py:
1052         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1053         of the code.
1054         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1055         (CommitQueueTask.validate): Add more information about validation failure.
1056         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1057         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1058         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1059         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1060         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1061         (PatchIsNotValid.__init__): Add the failure_message argument.
1062         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1063         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1064         failure details.
1065         * Scripts/webkitpy/tool/commands/queues.py:
1066         (CommitQueue.process_work_item): Same.
1067         (StyleQueue.review_patch): Same.
1068         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1069         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1070
1071 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1072
1073         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1074         https://bugs.webkit.org/show_bug.cgi?id=160262
1075
1076         Reviewed by Daniel Bates.
1077
1078         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1079         (-[LTRelayController installApp]):
1080
1081 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1082
1083         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1084         https://bugs.webkit.org/show_bug.cgi?id=160225
1085
1086         Reviewed by Alexey Proskuryakov.
1087
1088         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1089
1090 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1091
1092         [GTK] Fix some video/canvas tests that should be passing
1093         https://bugs.webkit.org/show_bug.cgi?id=160023
1094
1095         Reviewed by Carlos Garcia Campos.
1096
1097         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1098         EFL or GTK platforms.
1099
1100         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1101         (WTR::TestController::platformConfigureViewForTest):
1102         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1103         (WTR::TestController::platformConfigureViewForTest):
1104
1105 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1106
1107         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1108         https://bugs.webkit.org/show_bug.cgi?id=160247
1109
1110         Reviewed by Michael Catanzaro.
1111
1112         * BuildSlaveSupport/built-product-archive:
1113         (createZip):
1114         (dirContainsdwo):
1115         (archiveBuiltProduct):
1116
1117 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1118
1119         Fix tests after r203743.
1120         https://bugs.webkit.org/show_bug.cgi?id=156947
1121
1122         * WebKitTestRunner/TestController.cpp:
1123         (WTR::TestController::resetStateToConsistentValues):
1124         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1125
1126 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1127
1128         [iPhone] Playing a video on tudou.com plays only sound, no video
1129         https://bugs.webkit.org/show_bug.cgi?id=160178
1130         <rdar://problem/27535468>
1131
1132         Reviewed by Dan Bernstein.
1133
1134         * DumpRenderTree/mac/DumpRenderTree.mm:
1135         (setDefaultsToConsistentValuesForTesting):
1136         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1137         (RequiresUserActionForPlaybackTest::SetUp):
1138         * WebKitTestRunner/TestController.cpp:
1139         (WTR::TestController::resetPreferencesToConsistentValues):
1140         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1141         (WTR::initializeWebViewConfiguration):
1142
1143 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1144
1145         Allow LOG macros to be used outside the namespace, and other logging cleanup
1146         https://bugs.webkit.org/show_bug.cgi?id=160216
1147
1148         Reviewed by Anders Carlsson.
1149         
1150         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1151
1152         * DumpRenderTree/TestRunner.cpp:
1153         * DumpRenderTree/mac/DumpRenderTree.mm:
1154         (resetWebViewToConsistentStateBeforeTesting):
1155
1156 2016-07-26  David Kilzer <ddkilzer@apple.com>
1157
1158         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1159         https://bugs.webkit.org/show_bug.cgi?id=156947
1160         <rdar://problem/23325160>
1161
1162         Reviewed by Alex Christensen.
1163
1164         * DumpRenderTree/TestRunner.cpp:
1165         (TestRunner::TestRunner):
1166         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1167         * DumpRenderTree/TestRunner.h:
1168         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1169         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1170         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1171         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1172         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1173         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1174         (WTR::TestRunner::queueNonLoadingScript):
1175         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1176         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1177         * WebKitTestRunner/TestController.cpp:
1178         (WTR::TestController::didReceiveAuthenticationChallenge):
1179         * WebKitTestRunner/TestController.h:
1180         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1181         * WebKitTestRunner/TestInvocation.cpp:
1182         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1183         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1184
1185 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1186
1187         check-for-exit-time-destructors should be usable outside Xcode
1188         <https://webkit.org/b/160195>
1189
1190         Reviewed by Darin Adler.
1191
1192         * Scripts/check-for-exit-time-destructors: Update to parse
1193         -h|--help switch, or to take one argument to a binary to check
1194         for exit time destructors on the command-line.  The clang
1195         compiler will find these at compile-time with the
1196         -Wexit-time-destructors switch, but this script will check for
1197         them after-the-fact.
1198
1199 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1200
1201         Test svn.webkit.org functionality after maintenance.
1202
1203 2016-07-25  Brady Eidson  <beidson@apple.com>
1204
1205         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1206         https://bugs.webkit.org/show_bug.cgi?id=153783
1207
1208         Reviewed by Alex Christensen.
1209
1210         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
1211         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1212         
1213         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1214         
1215         Change the relevant API tests to make sure this continues to be no longer required.
1216
1217         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1218         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1219         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1220         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1221         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1222         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1223
1224 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1225
1226         Media controls should not be displayed for a video until it starts playing
1227         https://bugs.webkit.org/show_bug.cgi?id=160092
1228         <rdar://problem/26986673>
1229
1230         Reviewed by Beth Dakin.
1231
1232         Verify that multiple videos do or don't show the media controller depending on whether videos
1233         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1234         passing because we were always showing media controls for large videos with audio, even if they
1235         had not played back yet. This change ensures that large videos with audio show media controls
1236         only after they begin to play back, and not by virtue of being large enough for main content.
1237
1238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1239         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1240         (TestWebKitAPI::TEST):
1241         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1242         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1243         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1244
1245 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1246
1247         Media controls on apple.com don't disappear when movie finishes playing
1248         https://bugs.webkit.org/show_bug.cgi?id=160068
1249         <rdar://problem/26668526>
1250
1251         Reviewed by Darin Adler.
1252
1253         Adds new API tests. Please see WebCore ChangeLog for more details.
1254
1255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1256         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1257         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1258         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1259         (TestWebKitAPI::TEST):
1260         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1261         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1262         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1263         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1264         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1265
1266 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1267
1268         Unreviewed, fix test-webkitpy after r203674.
1269
1270         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1271         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1272
1273 2016-07-24  Philippe Normand  <pnormand@igalia.com>
1274
1275         Unreviewed, forgot to commit this file in r203674.
1276
1277         * Scripts/process-linux-coredump: Added.
1278         (main):
1279
1280 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1281
1282         Improve GDB backtrace generation for GTK/EFL
1283         https://bugs.webkit.org/show_bug.cgi?id=128928
1284
1285         Reviewed by Carlos Garcia Campos.
1286
1287         The PID of the crashed process is now correctly supplied to the
1288         crash log reporter. The kernel core_pattern needs to be updated
1289         after this change to something like:
1290
1291         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1292
1293         * Scripts/process-linux-coredump: Added.
1294         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1295         * Scripts/webkitpy/port/efl.py:
1296         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1297         * Scripts/webkitpy/port/gtk.py:
1298         (GtkPort._get_crash_log): Ditto.
1299         * Scripts/webkitpy/port/linux_get_crash_log.py:
1300         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1301         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1302         (GDBCrashLogGenerator): Deleted.
1303         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1304         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
1305         * WebKitTestRunner/TestController.cpp:
1306         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
1307         (WTR::TestController::databaseProcessDidCrash): Ditto.
1308         (WTR::TestController::processDidCrash): Ditto.
1309
1310 2016-07-23  Youenn Fablet  <youenn@apple.com>
1311
1312         WPT stash server should be kept running when launching wpt server
1313         https://bugs.webkit.org/show_bug.cgi?id=160052
1314
1315         Reviewed by Sam Weinig.
1316
1317         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1318         (main): waiting to read stdin while stash server is started.
1319
1320 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1321
1322         Media controls should be displayed for media in media documents
1323         https://bugs.webkit.org/show_bug.cgi?id=160104
1324         <rdar://problem/27438936>
1325
1326         Reviewed by Myles C. Maxfield.
1327
1328         Verifies that even a small video with audio in a media document gets media controls.
1329
1330         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1331         (TestWebKitAPI::TEST):
1332
1333 2016-07-22  Michael Saboff  <msaboff@apple.com>
1334
1335         REGRESSION(203616): no FTL testing was inadvertently removed
1336         https://bugs.webkit.org/show_bug.cgi?id=160100
1337
1338         Rubber-stamped by Filip Pizlo.
1339
1340         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
1341         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
1342         logic for the runLayout and runNoisy variants to match the run test logic,
1343         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
1344         enabled platforms.
1345
1346         * Scripts/run-jsc-stress-tests:
1347
1348 2016-07-22  Brady Eidson  <beidson@apple.com>
1349
1350         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
1351         https://bugs.webkit.org/show_bug.cgi?id=160089
1352
1353         Reviewed by Darin Adler.
1354
1355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1356         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
1357         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
1358
1359 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
1360
1361         [GTK] Improved exclusion patterns in make-dist.py manifest.
1362         https://bugs.webkit.org/show_bug.cgi?id=160094
1363
1364         Reviewed by Michael Catanzaro.
1365
1366         * gtk/manifest.txt.in:
1367         Exclude Platform*.cmake files for more ports.
1368         Removed obsolete .gyp and .pro.user patterns.
1369         Exclude 'Configurations' and 'spi' directories.
1370         Exclude CMakeLists.txt.user (Qt Creator IDE).
1371
1372 2016-07-22  Michael Saboff  <msaboff@apple.com>
1373
1374         Don't run FTL related JSC stress tests on non-FTL platforms
1375         https://bugs.webkit.org/show_bug.cgi?id=160033
1376
1377         Reviewed by Mark Lam.
1378
1379         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
1380         Refactored several of the runXXX test methods to always runXXXDefault and made those
1381         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
1382         doesn't cause a problem.
1383
1384         * Scripts/run-jsc-stress-tests:
1385
1386 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
1387
1388         IWebView::mainFrame crashes if called after IWebView::close
1389         https://bugs.webkit.org/show_bug.cgi?id=32868
1390
1391         Reviewed by Brent Fulgham.
1392
1393         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1394         (TestWebKitAPI::TEST_F): Added test.
1395
1396 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1397
1398         [GTK] Enable threaded compositor by default
1399         https://bugs.webkit.org/show_bug.cgi?id=160079
1400
1401         Reviewed by Žan Doberšek.
1402
1403         * Scripts/webkitperl/FeatureList.pm:
1404
1405 2016-07-22  Youenn Fablet  <youenn@apple.com>
1406
1407         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
1408         https://bugs.webkit.org/show_bug.cgi?id=159921
1409
1410         Reviewed by Brian Burg.
1411
1412         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
1413
1414         * Scripts/webkitpy/codegen/main.py:
1415         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
1416         (BuiltinsGeneratorTests):
1417         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
1418         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
1419         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
1420         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
1421
1422 2016-07-21  Dan Bernstein  <mitz@apple.com>
1423
1424         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
1425         https://bugs.webkit.org/show_bug.cgi?id=160072
1426
1427         Reviewed by Andy Estes.
1428
1429         * Scripts/webkitdirs.pm:
1430         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
1431           for old Xcode versions.
1432         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
1433           to readXcodeUserDefault.
1434         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
1435           debugger.
1436         (determineDebugger): Ditto.
1437         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
1438           7.0.
1439         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
1440           switches.
1441         (execMacWebKitAppForDebugging): Removed support for GDB.
1442
1443 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1444
1445         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
1446         https://bugs.webkit.org/show_bug.cgi?id=160066
1447
1448         Reviewed by Dean Jackson.
1449
1450         * DumpRenderTree/mac/DumpRenderTree.mm:
1451         (setDefaultsToConsistentValuesForTesting): Deleted.
1452         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1453         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1454         * WebKitTestRunner/TestController.cpp:
1455         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1456         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1457         (WTR::initializeWebViewConfiguration): Deleted.
1458
1459 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
1460
1461         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
1462         https://bugs.webkit.org/show_bug.cgi?id=159980
1463         rdar://problem/27450825
1464
1465         Reviewed by Dan Bernstein.
1466
1467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1468         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
1469         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
1470         when our delegate has hit -dealloc.
1471         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
1472         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
1473         will not be messaged.
1474
1475 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1476
1477         Follow-up patch to r203520
1478         https://bugs.webkit.org/show_bug.cgi?id=159967
1479         <rdar://problem/26964090>
1480
1481         Unreviewed.
1482
1483         * DumpRenderTree/mac/DumpRenderTree.mm:
1484         (setDefaultsToConsistentValuesForTesting):
1485         * WebKitTestRunner/TestController.cpp:
1486         (WTR::TestController::resetPreferencesToConsistentValues):
1487
1488 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1489
1490         [iPhone] Playing a video on tudou.com plays only sound, no video
1491         https://bugs.webkit.org/show_bug.cgi?id=159967
1492         <rdar://problem/26964090>
1493
1494         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
1495
1496         Migrate tests to use new SPI.
1497
1498         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1499         (RequiresUserActionForPlaybackTest::SetUp):
1500         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1501         (WTR::initializeWebViewConfiguration):
1502
1503 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
1504
1505         Clarify testing mode names in run-jsc-stress-tests
1506         https://bugs.webkit.org/show_bug.cgi?id=160021
1507
1508         Reviewed by Mark Lam.
1509
1510         Default should mean really default, not default with disabled FTL, renamed
1511         - runMozillaTestDefault to runMozillaTestNoFTL
1512         - runMozillaTestDefaultFTL to runMozillaTestDefault
1513         - runDefault to runNoFTL
1514         - runDefaultFTL to runDefault
1515         - runLayoutTestDefault to runLayoutTestNoFTL
1516         - runLayoutTestDefaultFTL to runLayoutTestDefault
1517         - runNoisyTestDefault to runNoisyTestNoFTL
1518         - runNoisyTestDefaultFTL to runNoisyTestDefault
1519
1520         * Scripts/run-jsc-stress-tests:
1521
1522 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
1523
1524         WebBackForwardList's currentIndex could get out of bounds when filtering items.
1525         https://bugs.webkit.org/show_bug.cgi?id=159986
1526
1527         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
1528         to 0.
1529
1530         Reviewed by Dan Bernstein.
1531
1532         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1533         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
1534         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
1535         (TEST):
1536
1537 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1538
1539         [GTK] Web view background colors don't work in accelerated compositing mode
1540         https://bugs.webkit.org/show_bug.cgi?id=159455
1541
1542         Reviewed by Michael Catanzaro.
1543
1544         Set always RGBA visual to the view widget when setting a background color.
1545
1546         * MiniBrowser/gtk/BrowserWindow.c:
1547         (browser_window_set_background_color):
1548
1549 2016-07-20  Youenn Fablet  <youenn@apple.com>
1550
1551         Bots should run built-ins generator tests
1552         https://bugs.webkit.org/show_bug.cgi?id=159971
1553
1554         Reviewed by Alexey Proskuryakov.
1555
1556         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1557         (RunBuiltinsTests): New step to run built-in generator tests.
1558         (TestFactory.__init__): Adding an additional step for bultin generator tests.
1559         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
1560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
1561
1562 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1563
1564         Revert temporary fix r203417
1565         https://bugs.webkit.org/show_bug.cgi?id=160001
1566
1567         Reviewed by Alexey Proskuryakov.
1568
1569         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
1570
1571 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1572
1573         REGRESSION(r148588): ews classes might get garbage collected
1574         https://bugs.webkit.org/show_bug.cgi?id=159990
1575
1576         Reviewed by Ryosuke Niwa.
1577
1578         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
1579         in a variable so that they do not get garbage collected.
1580
1581 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
1582
1583         Add API test for layout constraints after exit fullscreen
1584         https://bugs.webkit.org/show_bug.cgi?id=159900
1585
1586         Reviewed by Jon Lee.
1587
1588         Added Fullscreen.LaytoutConstraints API test. 
1589         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
1590
1591         This test compares layout constraints on the web view before and after fullscreen to make sure 
1592         they are preserved.
1593
1594         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
1595         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
1596         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1597         (TestWebKitAPI::TEST):
1598
1599 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
1600
1601         Disable two failing API tests.
1602
1603         Unreviewed test gardening.
1604
1605         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
1606         (TestWebKitAPI::TEST):
1607
1608 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1609
1610         Unreviewed iOS build fix.
1611
1612         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
1613
1614 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1615
1616         Media controls don't appear when pausing a small autoplaying video
1617         https://bugs.webkit.org/show_bug.cgi?id=159972
1618         <rdar://problem/27180657>
1619
1620         Reviewed by Beth Dakin.
1621
1622         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
1623         for simulating basic user interaction in VideoControlsManager.
1624
1625         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1626         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1627         (-[WKWebView mouseDownAtPoint:]):
1628         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
1629         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
1630         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
1631         (TestWebKitAPI::TEST):
1632         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
1633
1634 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
1635
1636         [Win] MathML fonts are not found.
1637         https://bugs.webkit.org/show_bug.cgi?id=159920
1638
1639         Reviewed by Alex Christensen.
1640
1641         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
1642         for a specific registry key value.
1643
1644         * Scripts/webkitdirs.pm:
1645         (fontExists):
1646
1647 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
1648
1649         Improve prepare-ChangeLog for @media blocks
1650         https://bugs.webkit.org/show_bug.cgi?id=159907
1651
1652         Reviewed by Timothy Hatcher.
1653
1654         * Scripts/prepare-ChangeLog:
1655         (get_selector_line_ranges_for_css):
1656         Get a range for @media blocks just like a selector.
1657             Start Line = line with '{'
1658             End line = line with '}'
1659             Name = "@media ..."
1660
1661         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
1662         Improved error messages for unbalanced portions.
1663
1664         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
1665         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
1666         (.media-query::before):
1667         (@media only screen and (max-width: 980px)):
1668         (.media-query a):
1669         (@media (-webkit-min-device-pixel-ratio: 2)):
1670         (.both a):
1671         (.both b):
1672         (.media-query b):
1673         (.media-query::after):
1674
1675 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
1676
1677         Fix expectedFailErrorHandler in run-jsc-stress-tests
1678         https://bugs.webkit.org/show_bug.cgi?id=159811
1679
1680         Reviewed by Yusuke Suzuki.
1681
1682         * Scripts/run-jsc-stress-tests:
1683
1684 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
1685
1686         Unreviewed Mac cmake buildfix after r203426. Just for fun.
1687
1688         * TestWebKitAPI/PlatformMac.cmake:
1689
1690 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
1691
1692         The default testing mode should not involve disabling the FTL JIT
1693         https://bugs.webkit.org/show_bug.cgi?id=159929
1694
1695         Rubber stamped by Mark Lam and Saam Barati.
1696         
1697         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
1698         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
1699         FTL was not the default. You had to enable it with an option.
1700         
1701         For some reason we have kept this arrangement even though the FTL JIT is now the default on
1702         all of the major ports. This has become a serious pain. For example, it's useful to be able
1703         to say that a test should only run in the default config that is representative of what a
1704         normal user would see if they ran JSC. Clearly, this would be a config that does not
1705         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
1706         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
1707         
1708         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
1709         try to fix it, because:
1710         
1711         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
1712           have the FTL enabled never run any tests that explicitly disable the FTL, since that
1713           doesn't do anything. The code is not really structured to allow this.
1714         
1715         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
1716           disabled in testing. On the other hand there are already build bots that do FTL tests
1717           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
1718           preserving this broken feature, we should create something that (a) acknowledges the fact
1719           that the FTL is the default on those platforms that support it and (b) avoids running
1720           no-ftl tests on precisely those platforms that don't have FTL.
1721         
1722         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
1723           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
1724           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
1725           pretending that the FTL JIT is not the default just because some bots used that as an
1726           optimization.
1727         
1728         This change allows me to speed up some debug tests and paint some bots green.
1729
1730         * Scripts/run-javascriptcore-tests:
1731         (runJSCStressTests):
1732         * Scripts/run-jsc-stress-tests:
1733
1734 2016-07-19  Alex Christensen  <achristensen@webkit.org>
1735
1736         Fix API test after r203426.
1737         https://bugs.webkit.org/show_bug.cgi?id=159949
1738
1739         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1740         (TEST):
1741         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
1742         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
1743
1744 2016-07-19  Andy Estes  <aestes@apple.com>
1745
1746         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
1747         https://bugs.webkit.org/show_bug.cgi?id=159956
1748
1749         Reviewed by Dan Bernstein.
1750
1751         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
1752         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1753         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
1754         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
1755
1756 2016-07-19  Alex Christensen  <achristensen@webkit.org>
1757
1758         Add regression test for r203392
1759         https://bugs.webkit.org/show_bug.cgi?id=159949
1760
1761         Reviewed by Brady Eidson.
1762
1763         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1764         (fileSize):
1765         (swizzledBundleIdentifierWebBookmarksD):
1766         (defaultApplicationCacheDirectory):
1767         (TEST):
1768         (swizzledBundleIdentifierMobileSafari): Deleted.
1769         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
1770         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
1771         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
1772
1773 2016-07-19  Alex Christensen  <achristensen@webkit.org>
1774
1775         Add regression test for r203392
1776         https://bugs.webkit.org/show_bug.cgi?id=159949
1777
1778         Reviewed by Brady Eidson.
1779
1780         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1781         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
1782         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
1783         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
1784         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1785         (TEST):
1786         (fileSize):
1787         (swizzledBundleIdentifierMobileSafari):
1788         (swizzledBundleIdentifierWebBookmarksD):
1789         (defaultApplicationCacheDirectory):
1790         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
1791         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
1792         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
1793         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
1794
1795 2016-07-19  Keith Miller  <keith_miller@apple.com>
1796
1797         Test262 should have a file with the revision and url
1798         https://bugs.webkit.org/show_bug.cgi?id=159937
1799
1800         Reviewed by Mark Lam.
1801
1802         The import script should update the information from
1803         the path to the test262 repository it gets.
1804
1805         * Scripts/import-test262-tests:
1806
1807 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
1808
1809         Temporary workaround for iOS EWS failing after the fix for bug 159539.
1810         To be deleted once the root cause is found and addressed.
1811
1812         * EWSTools/start-queue-mac.sh:
1813
1814 2016-07-19  Frederic Wang  <fwang@igalia.com>
1815
1816         [win] Fixup the register name for STIX Math and Latin Modern Math
1817
1818         Unreviewed follow-up of r203406
1819
1820         * Scripts/webkitdirs.pm:
1821         (checkInstalledTools):
1822
1823 2016-07-19  Frederic Wang  <fwang@igalia.com>
1824
1825         [win] Update the list of MathML fonts
1826         https://bugs.webkit.org/show_bug.cgi?id=156838
1827
1828         The set of recommended math fonts is now described at
1829         https://trac.webkit.org/wiki/MathML/Fonts
1830         We update the Perl script to use the latest list of fonts.
1831
1832         Reviewed by Brent Fulgham.
1833
1834         * Scripts/webkitdirs.pm:
1835         (checkInstalledTools):
1836
1837 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
1838
1839         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
1840         https://bugs.webkit.org/show_bug.cgi?id=159342
1841
1842         Reviewed by Darin Adler.
1843
1844         Implement required functions in event sender.
1845
1846         * DumpRenderTree/PlatformWin.cmake:
1847         * DumpRenderTree/win/EventSender.cpp:
1848         (monitorWheelEvents): Added.
1849         (callAfterScrollingCompletes): Added.
1850
1851 2016-07-19  Youenn Fablet  <youenn@apple.com>
1852
1853         Add new aliases to http test server
1854         https://bugs.webkit.org/show_bug.cgi?id=159878
1855
1856         Reviewed by Darin Adler.
1857
1858         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
1859         Adding explicitly these links to perl script.
1860         Extracting default alias in an aliases.json file.
1861         Reading that file from python scripts to initialize aliases from that file.
1862
1863         Python script changes covered by unit tests and changed layout test.
1864
1865         * Scripts/webkitperl/httpd.pm:
1866         (getDefaultConfigForTestDirectory): Adding 3 new aliases
1867         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
1868         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1869         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
1870         Adding -c directives for each alias.
1871         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1872         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
1873         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1874         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
1875         Adding alias directive for each alias.
1876         (Lighttpd._prepare_config):
1877         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1878         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
1879         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
1880         layout tests directory.
1881         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1882         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
1883         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
1884
1885 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
1886
1887         EWS console logs doesn't go to log file
1888         https://bugs.webkit.org/show_bug.cgi?id=159539
1889         <rdar://problem/24464570>
1890
1891         Reviewed by David Kilzer.
1892
1893         * Scripts/webkitpy/common/system/logutils.py:
1894         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
1895         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
1896         to filesystem. It also supports passing MockFilesystem.
1897         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
1898         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
1899         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1900         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
1901         (_test_ews): Same.
1902         * Scripts/webkitpy/tool/commands/queues.py:
1903         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
1904         (AbstractQueue._log_directory): Using filesystem object instead of os.
1905         (AbstractQueue.queue_log_path): Same.
1906         (AbstractQueue.__init__): Passed host parameter.
1907         (PatchProcessingQueue.__init__): Same.
1908         (CommitQueue.__init__): Same.
1909         (AbstractReviewQueue.__init__): Same.
1910         (StyleQueue.__init__): Same.
1911         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1912         (TestCommitQueue): Passed MockHost() as host.
1913         (TestCommitQueue.__init__): Same.
1914         (TestQueue.__init__): Same.
1915         (TestReviewQueue.__init__): Same.
1916         (TestFeederQueue.__init__): Same.
1917         (AbstractPatchQueueTest.test_next_patch): Same.
1918         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1919         (test_commit_queue_failure): Same.
1920         (MockCommitQueueTask.results_from_patch_test_run): Same.
1921         (test_rollout_lands): Same.
1922         (test_non_valid_patch): Same.
1923         (test_auto_retry): Same.
1924         (test_style_queue_with_watch_list_exception): Same.
1925
1926 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
1927
1928         WTF::Lock should be fair eventually
1929         https://bugs.webkit.org/show_bug.cgi?id=159384
1930
1931         Reviewed by Geoffrey Garen.
1932
1933         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1934
1935 2016-07-17  Sam Weinig  <sam@webkit.org>
1936
1937         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
1938         <rdar://problem/26554137>
1939         https://bugs.webkit.org/show_bug.cgi?id=159856
1940
1941         Reviewed by Dan Bernstein.
1942
1943         * MiniBrowser/mac/WK2BrowserWindowController.m:
1944         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1945         Add basic window.open implementation.
1946
1947         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
1948         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
1949         to open a single non-web URL, all others are dropped.
1950
1951         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1952         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
1953         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
1954         Add API for the new SPI.
1955
1956 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
1957
1958         [JSC] Enable test262 module tests
1959         https://bugs.webkit.org/show_bug.cgi?id=159854
1960
1961         Reviewed by Saam Barati.
1962
1963         Use --module-file instead.
1964
1965         * Scripts/run-jsc-stress-tests:
1966
1967 2016-07-16  Chris Dumez  <cdumez@apple.com>
1968
1969         Unreviewed, rolling out r203318.
1970
1971         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
1972         SunSpider)
1973
1974         Reverted changeset:
1975
1976         "[JSC] Change some parameters based on a random search"
1977         https://bugs.webkit.org/show_bug.cgi?id=158514
1978         http://trac.webkit.org/changeset/203318
1979
1980 2016-07-16  Chris Dumez  <cdumez@apple.com>
1981
1982         Add move constructor / assignment operator to ListHashSet
1983         https://bugs.webkit.org/show_bug.cgi?id=159837
1984
1985         Reviewed by Darin Adler.
1986
1987         Add API tests.
1988
1989         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1990         (TestWebKitAPI::TEST):
1991
1992 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
1993
1994         [JSC] Change some parameters based on a random search
1995         https://bugs.webkit.org/show_bug.cgi?id=158514
1996
1997         Reviewed by Saam Barati.
1998
1999         * Scripts/run-jsc-stress-tests:
2000
2001 2016-07-15  Jon Davis  <jond@apple.com>
2002
2003         Changed the start page URL for WebKit Nightly builds.
2004         https://bugs.webkit.org/show_bug.cgi?id=159816
2005
2006         Reviewed by Timothy Hatcher.
2007
2008         * WebKitLauncher/start.html:
2009
2010 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2011
2012         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2013         https://bugs.webkit.org/show_bug.cgi?id=159414
2014
2015         Reviewed by Brent Fulgham.
2016
2017         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2018         when the HDC parameter is invalid.
2019
2020         * TestWebKitAPI/PlatformWin.cmake:
2021         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2022         (TestWebKitAPI::TEST):
2023
2024 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2025
2026         [GTK] Add basic tabs support to MiniBrowser
2027         https://bugs.webkit.org/show_bug.cgi?id=159803
2028
2029         Reviewed by Sergio Villar Senin.
2030
2031         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2032         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2033
2034         * MiniBrowser/gtk/BrowserTab.c: Added.
2035         (titleChanged):
2036         (isLoadingChanged):
2037         (decidePolicy):
2038         (removeChildIfInfoBar):
2039         (loadChanged):
2040         (createInfoBarQuestionMessage):
2041         (tlsErrorsDialogResponse):
2042         (loadFailedWithTLSerrors):
2043         (permissionRequestDialogResponse):
2044         (decidePermissionRequest):
2045         (colorChooserRGBAChanged):
2046         (popoverColorClosed):
2047         (colorChooserRequestFinished):
2048         (runColorChooserCallback):
2049         (inspectorOpenedInWindow):
2050         (inspectorClosed):
2051         (browserTabSetProperty):
2052         (browserTabFinalize):
2053         (browser_tab_init):
2054         (browserTabConstructed):
2055         (browser_tab_class_init):
2056         (getInternalURI):
2057         (browser_tab_new):
2058         (browser_tab_get_web_view):
2059         (browser_tab_load_uri):
2060         (browser_tab_get_title_widget):
2061         (browser_tab_set_status_text):
2062         (browser_tab_toggle_inspector):
2063         (browser_tab_start_search):
2064         (browser_tab_stop_search):
2065         (browser_tab_add_accelerators):
2066         (fullScreenMessageTimeoutCallback):
2067         (browser_tab_enter_fullscreen):
2068         (browser_tab_leave_fullscreen):
2069         * MiniBrowser/gtk/BrowserTab.h: Added.
2070         * MiniBrowser/gtk/BrowserWindow.c:
2071         (getExternalURI):
2072         (browserWindowSetStatusText):
2073         (reloadOrStopCallback):
2074         (goBackCallback):
2075         (goForwardCallback):
2076         (settingsCallback):
2077         (webViewURIChanged):
2078         (browserWindowHistoryItemActivated):
2079         (browserWindowUpdateNavigationActions):
2080         (webViewCreate):
2081         (webViewEnterFullScreen):
2082         (webViewLeaveFullScreen):
2083         (webViewDecidePolicy):
2084         (browserWindowCanZoomIn):
2085         (browserWindowCanZoomOut):
2086         (browserWindowZoomIn):
2087         (browserWindowZoomOut):
2088         (scrollEventCallback):
2089         (faviconChanged):
2090         (webViewIsLoadingChanged):
2091         (defaultZoomCallback):
2092         (searchCallback):
2093         (newTabCallback):
2094         (toggleWebInspector):
2095         (reloadPage):
2096         (reloadPageIgnoringCache):
2097         (stopPageLoad):
2098         (loadHomePage):
2099         (editingCommandCallback):
2100         (insertImageCommandCallback):
2101         (insertLinkCommandCallback):
2102         (browserWindowSetupEditorToolbar):
2103         (browserWindowSwitchTab):
2104         (browserWindowTabAddedOrRemoved):
2105         (browser_window_init):
2106         (browserWindowConstructed):
2107         (browserWindowSaveSession):
2108         (browserWindowDeleteEvent):
2109         (browser_window_new):
2110         (browser_window_append_view):
2111         (browser_window_load_uri):
2112         (browser_window_load_session):
2113         (browser_window_set_background_color):
2114         (resetStatusText): Deleted.
2115         (activateUriEntryCallback): Deleted.
2116         (webViewTitleChanged): Deleted.
2117         (resetEntryProgress): Deleted.
2118         (browserWindowCreateBackForwardMenu): Deleted.
2119         (webViewReadyToShow): Deleted.
2120         (webViewLoadFailed): Deleted.
2121         (webViewMouseTargetChanged): Deleted.
2122         (browserWindowUpdateZoomActions): Deleted.
2123         (webViewZoomLevelChanged): Deleted.
2124         (updateUriEntryIcon): Deleted.
2125         (zoomInCallback): Deleted.
2126         (zoomOutCallback): Deleted.
2127         (toggleFullScreen): Deleted.
2128         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2129         (browserWindowFinalize): Deleted.
2130         (browser_window_class_init): Deleted.
2131         * MiniBrowser/gtk/BrowserWindow.h:
2132         * MiniBrowser/gtk/CMakeLists.txt:
2133         * MiniBrowser/gtk/main.c:
2134         (createBrowserTab):
2135         (aboutURISchemeRequestCallback):
2136         (main):
2137         (parseBackgroundColor): Deleted.
2138
2139 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2140
2141         Allow RefPtrs of const RefCounted types
2142         https://bugs.webkit.org/show_bug.cgi?id=158269
2143
2144         Reviewed by Anders Carlsson.
2145
2146         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2147         (TestWebKitAPI::TEST):
2148         (TestWebKitAPI::ConstRefCounted::create):
2149         (TestWebKitAPI::returnConstRefCountedRef):
2150         (TestWebKitAPI::returnRefCountedRef):
2151
2152 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2153
2154         Test WTF.StringViewIterators is crashing since r203119
2155         https://bugs.webkit.org/show_bug.cgi?id=159710
2156
2157         Reviewed by Darin Adler.
2158
2159         There are two problems in the test case added in r203119. First is that it's testing
2160         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2161         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2162         const reference to the string view member of the deleted CodePoints object.
2163
2164         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2165         (TestWebKitAPI::TEST):
2166
2167 2016-07-13  Daniel Bates  <dabates@apple.com>
2168
2169         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2170         https://bugs.webkit.org/show_bug.cgi?id=159738
2171         <rdar://problem/27304649>
2172
2173         Reviewed by Dan Bernstein.
2174
2175         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2176         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2177         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2178         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2179
2180         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2181         * WebKitTestRunner/ios/TestControllerIOS.mm:
2182         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2183         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2184
2185 2016-07-13  Beth Dakin  <bdakin@apple.com>
2186
2187         Attempted build fix.
2188
2189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2190
2191 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2192
2193         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2194         https://bugs.webkit.org/show_bug.cgi?id=159686
2195
2196         Reviewed by Chris Dumez.
2197
2198         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2199
2200         * WebKitTestRunner/TestController.cpp:
2201         (WTR::runOpenPanel):
2202         (WTR::TestController::createOtherPage):
2203         (WTR::TestController::createWebViewWithOptions):
2204
2205 2016-07-13  Beth Dakin  <bdakin@apple.com>
2206
2207         Add more candidate tests
2208         https://bugs.webkit.org/show_bug.cgi?id=159730
2209
2210         Reviewed by Tim Horton.
2211
2212         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
2213         two new tests to that file.
2214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2215         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2216         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2217         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2218         (TestWebKitAPI::TEST):
2219         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2220
2221 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2222
2223         AX: [ATK] spinbutton-crash.html fails
2224         https://bugs.webkit.org/show_bug.cgi?id=159723
2225
2226         Reviewed by Chris Fleizach.
2227
2228         Implement support for AXDecrementButton and AXIncrementButton in
2229         ATK's AccessibilityUIElement::uiElementAttributeValue().
2230
2231         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2232         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2233
2234 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2235
2236         [EFL] [GTK] Enable back crypto subtle on development builds.
2237         https://bugs.webkit.org/show_bug.cgi?id=159260
2238
2239         Reviewed by Carlos Garcia Campos.
2240
2241         * Scripts/webkitperl/FeatureList.pm:
2242
2243 2016-07-12  Mark Lam  <mark.lam@apple.com>
2244
2245         We should use different stack limits for stack checks from JS and host code.
2246         https://bugs.webkit.org/show_bug.cgi?id=159442
2247         <rdar://problem/26889188>
2248
2249         Reviewed by Geoffrey Garen.
2250
2251         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2252         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
2253         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
2254         order to keep the js/regress-139548.html test happy with this patch.
2255
2256         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2257         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
2258
2259         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2260         (-[LTRelayController _environmentVariables]):
2261         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2262         (main):
2263
2264 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
2265
2266         platformUserPreferredLanguages on Mac should not try to put the region into the language
2267         https://bugs.webkit.org/show_bug.cgi?id=159693
2268
2269         Rubber stamped by Alexey Proskuryakov.
2270         
2271         Revert the test change in r200105.
2272
2273         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2274         (TestWebKitAPI::languageForSystemLanguage):
2275
2276 2016-07-12  Chris Dumez  <cdumez@apple.com>
2277
2278         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2279         https://bugs.webkit.org/show_bug.cgi?id=159663
2280         <rdar://problem/18995873>
2281
2282         Reviewed by Benjamin Poulain.
2283
2284         Add API test coverage.
2285
2286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2287         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2288         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2289         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2290         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2291         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2292         (TEST):
2293
2294 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
2295
2296         Relax ordering requirements on StringView::CodePoints iterator
2297         https://bugs.webkit.org/show_bug.cgi?id=159609
2298
2299         Reviewed by Darin Adler.
2300
2301         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2302         (TestWebKitAPI::TEST):
2303
2304 2016-07-12  Youenn Fablet  <youenn@apple.com>
2305
2306         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
2307         https://bugs.webkit.org/show_bug.cgi?id=159564
2308
2309         Reviewed by Brian Burg.
2310
2311         * Scripts/webkitpy/codegen/main.py:
2312         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
2313
2314 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2315
2316         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2317         https://bugs.webkit.org/show_bug.cgi?id=159671
2318
2319         Reviewed by Csaba Osztrogonác.
2320
2321         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2322         https://bugs.webkit.org/show_bug.cgi?id=89235
2323
2324         So this guard can be removed in build scripts.
2325
2326         * Scripts/webkitperl/FeatureList.pm:
2327         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2328
2329 2016-07-11  Jason Marcell  <jmarcell@apple.com>
2330
2331         SVN.create_patch should find svn-create-patch relative to the WebKit root.
2332         https://bugs.webkit.org/show_bug.cgi?id=159652
2333
2334         Reviewed by Daniel Bates.
2335
2336         * Scripts/webkitpy/common/checkout/scm/svn.py:
2337         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
2338
2339 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2340
2341         Implement grapheme cluster iterator on StringView
2342         https://bugs.webkit.org/show_bug.cgi?id=159598
2343
2344         Reviewed by Anders Carlsson.
2345
2346         This is in preparation for honoring the second argument to FontFaceSet.load().
2347
2348         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2349         (TestWebKitAPI::compareLoopIterations):
2350         (TestWebKitAPI::TEST):
2351
2352 2016-07-11  Nan Wang  <n_wang@apple.com>
2353
2354         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
2355         https://bugs.webkit.org/show_bug.cgi?id=158364
2356
2357         Reviewed by Anders Carlsson.
2358
2359         Added a function in TestRunner so that we can toggle the ignoring viewport
2360         scale limits setting. Also added a test option for that in order to change the 
2361         configuration of the webview in test.
2362
2363         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2364         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2365         (WTR::TestRunner::setNavigationGesturesEnabled):
2366         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2367         (WTR::nextUIScriptCallbackID):
2368         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2369         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2370         * WebKitTestRunner/TestController.cpp:
2371         (WTR::TestController::resetStateToConsistentValues):
2372         (WTR::updateTestOptionsFromTestHeader):
2373         (WTR::TestController::setNavigationGesturesEnabled):
2374         (WTR::TestController::setIgnoresViewportScaleLimits):
2375         (WTR::TestController::platformWillRunTest):
2376         * WebKitTestRunner/TestController.h:
2377         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2378         * WebKitTestRunner/TestInvocation.cpp:
2379         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2380         * WebKitTestRunner/TestOptions.h:
2381         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2382         (WTR::TestController::platformCreateWebView):
2383
2384 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
2385
2386         [GTK] install-dependencies should not install packages built by jhbuild.
2387         https://bugs.webkit.org/show_bug.cgi?id=159628
2388
2389         Reviewed by Michael Catanzaro.
2390
2391         * gtk/install-dependencies:
2392         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
2393
2394 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
2395
2396         System proxy settings not used when building deps with jhbuild
2397         https://bugs.webkit.org/show_bug.cgi?id=159567
2398
2399         Reviewed by Michael Catanzaro.
2400
2401         This adds the gsettings-desktop-schemas-devel build dep to enable
2402         the libgiognomeproxy.so gio module in glib-networking, which uses
2403         GSettings on org.gnome.system.proxy.
2404         This is needed to query system proxy settings for Gnome desktops.
2405
2406         dconf can be manually added to jhbuild to build the
2407         libdconfsettings.so gio module for GSettings, so that
2408         libgiognomeproxy.so can access system settings.
2409           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
2410
2411         As an alternative to dconf settings, this commit also adds the
2412         libproxy-devel build dep to enable the libgiolibproxy.so module in
2413         glib-networking (suggested by Fujii Hironori).
2414
2415         It is useful to read proxy settings from environment variables.
2416         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
2417         environment variable to force using the envvar module in libproxy.
2418
2419         * gtk/install-dependencies:
2420
2421 2016-07-11  Mark Lam  <mark.lam@apple.com>
2422
2423         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
2424         https://bugs.webkit.org/show_bug.cgi?id=159524
2425
2426         Reviewed by Michael Saboff.
2427
2428         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
2429         Also fixed up some tests to behave better to work with this new limit.  This
2430         should make stack overflow tests complete sooner.
2431
2432         * Scripts/run-jsc-stress-tests:
2433         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2434         (main):
2435
2436 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2437
2438         [GTK] Whitespace fixes in install-dependencies script
2439
2440         Unreviewed.
2441
2442         * gtk/install-dependencies:
2443
2444 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2445
2446         [GTK] Install missing Fedora dependencies
2447
2448         Unreviewed.
2449
2450         * gtk/install-dependencies:
2451
2452 2016-07-09  Dan Bernstein  <mitz@apple.com>
2453
2454         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
2455         https://bugs.webkit.org/show_bug.cgi?id=159600
2456
2457         Reviewed by Daniel Bates.
2458
2459         * Scripts/git-add-reviewer:
2460         Added the -s|--rubber-stamp option.
2461         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
2462           new option.
2463
2464 2016-07-08  Andy Estes  <aestes@apple.com>
2465
2466         [Content Filtering] Load blocked pages more like other error pages are loaded
2467         https://bugs.webkit.org/show_bug.cgi?id=159485
2468         <rdar://problem/26014076>
2469
2470         Reviewed by Brady Eidson.
2471
2472         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2473         to a content filtering provisional navigation failure is ignored in preference of
2474         ContentFilter's own error page.
2475
2476         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2477         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2478         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2479         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2480         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2481         (loadAlternateTest):
2482         (TEST):
2483         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2484         (-[MockContentFilterEnabler initWithCoder:]):
2485         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2486         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2487         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2488         (TestWebKitAPI::loadAlternateTest):
2489         (TestWebKitAPI::TEST):
2490
2491 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2492
2493         Unreviewed, rolling out r202944.
2494         https://bugs.webkit.org/show_bug.cgi?id=159570
2495
2496         caused some tests to crash under GuardMalloc (Requested by
2497         estes on #webkit).
2498
2499         Reverted changeset:
2500
2501         "[Content Filtering] Load blocked pages more like other error
2502         pages are loaded"
2503         https://bugs.webkit.org/show_bug.cgi?id=159485
2504         http://trac.webkit.org/changeset/202944
2505
2506 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
2507
2508         Remove mrobinson from the MathML watchlist
2509         https://bugs.webkit.org/show_bug.cgi?id=159559
2510
2511         Reviewed by Philippe Normand.
2512
2513         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
2514
2515 2016-07-08  Brady Eidson  <beidson@apple.com>
2516
2517         Clearing LocalStorage doesn't also delete -wal and -shm files.
2518         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
2519
2520         Reviewed by Brent Fulgham.
2521         Also helpfully picked over by Andy "Never Forgets" Estes.
2522
2523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2524         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
2525         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
2526
2527 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
2528
2529         Removed Qt leftovers from Tools.
2530         https://bugs.webkit.org/show_bug.cgi?id=159557
2531
2532         Reviewed by Csaba Osztrogonác.
2533
2534         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2535         Removed 'qt' platform config.
2536         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2537         Deleted non-functional e-mail address.
2538
2539 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2540
2541         Unreviewed, rolling out r202967.
2542         https://bugs.webkit.org/show_bug.cgi?id=159556
2543
2544         This patch caused crashes in https tests on Windows (Requested
2545         by perarne on #webkit).
2546
2547         Reverted changeset:
2548
2549         "[Win] The test http/tests/security/contentSecurityPolicy
2550         /upgrade-insecure-requests/basic-upgrade.https.html is
2551         failing."
2552         https://bugs.webkit.org/show_bug.cgi?id=159510
2553         http://trac.webkit.org/changeset/202967
2554
2555 2016-07-08  Youenn Fablet  <youenn@apple.com>
2556
2557         Generate WebCore builtin wrapper files
2558         https://bugs.webkit.org/show_bug.cgi?id=159461
2559
2560         Reviewed by Brian Burg.
2561
2562         * Scripts/webkitpy/codegen/main.py:
2563         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
2564         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
2565
2566 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
2567
2568         [EFL] Fix build when media-stream is enabled.
2569         https://bugs.webkit.org/show_bug.cgi?id=159206
2570
2571         Bump up the openwebrtc to find the correct package.
2572
2573         Reviewed by Gyuyoung Kim.
2574
2575         * efl/jhbuild.modules:
2576         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
2577
2578 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2579
2580         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
2581         https://bugs.webkit.org/show_bug.cgi?id=159510
2582
2583         Reviewed by Brent Fulgham.
2584
2585         Allow any https certificate when running tests.
2586
2587         * DumpRenderTree/win/DumpRenderTree.cpp:
2588         (runTest):
2589
2590 2016-07-07  Beth Dakin  <bdakin@apple.com>
2591
2592         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
2593         https://bugs.webkit.org/show_bug.cgi?id=159532
2594         -and corresponding-
2595         rdar://problem/27177179
2596
2597         Reviewed by Tim Horton.
2598
2599         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
2600         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
2601
2602 2016-07-07  Andy Estes  <aestes@apple.com>
2603
2604         [Content Filtering] Load blocked pages more like other error pages are loaded
2605         https://bugs.webkit.org/show_bug.cgi?id=159485
2606         <rdar://problem/26014076>
2607
2608         Reviewed by Brady Eidson.
2609
2610         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2611         to a content filtering provisional navigation failure is ignored in preference of
2612         ContentFilter's own error page.
2613
2614         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2615         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2616         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2617         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2618         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2619         (loadAlternateTest):
2620         (TEST):
2621         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2622         (-[MockContentFilterEnabler initWithCoder:]):
2623         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2624         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2625         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2626         (TestWebKitAPI::loadAlternateTest):
2627         (TestWebKitAPI::TEST):
2628
2629 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2630
2631         Unreviewed: add myself to the reviewers list.
2632
2633         * Scripts/webkitpy/common/config/contributors.json:
2634
2635 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2636
2637         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
2638         https://bugs.webkit.org/show_bug.cgi?id=159509
2639
2640         Reviewed by Alex Christensen.
2641
2642         We should always insert the url in the url map when identifierForInitialRequest
2643         is called. Otherwise we can end up with identifiers not having an entry in the
2644         url map when urls are written to the test output file. 
2645
2646         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2647         (ResourceLoadDelegate::identifierForInitialRequest):
2648
2649 2016-07-06  Tim Horton  <timothy_horton@apple.com>
2650
2651         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
2652         https://bugs.webkit.org/show_bug.cgi?id=159498
2653         <rdar://problem/26719903>
2654
2655         Reviewed by Sam Weinig.
2656
2657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2658         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
2659         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
2660         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
2661         (expectLinkCount):
2662         (TEST):
2663         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
2664         when deciding what to linkify.
2665
2666 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
2667
2668         Build fix - work around rdar://problem/27196668.
2669
2670         * LayoutTestRelay/Configurations/Base.xcconfig:
2671
2672 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
2673
2674         Enhance Windows DRT implementation to support platform scroll wheel events.
2675         https://bugs.webkit.org/show_bug.cgi?id=36002
2676
2677         Reviewed by Brent Fulgham.
2678
2679         Implement function continuousMouseScrollBy in Windows event sender.
2680
2681         * DumpRenderTree/win/EventSender.cpp:
2682         (mouseScrollBy):
2683         (continuousMouseScrollBy):
2684
2685 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
2686
2687         [Sierra] Rebaseline tests to use un-mocked system font metrics
2688         https://bugs.webkit.org/show_bug.cgi?id=159311
2689         <rdar://problem/24138411>
2690
2691         Reviewed in person by Alexey Proskuryakov.
2692
2693         Stop mocking the system font on Sierra.
2694
2695         * DumpRenderTree/mac/DumpRenderTree.mm:
2696         (setDefaultsToConsistentValuesForTesting):
2697         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2698         (WTR::InjectedBundle::platformInitialize):
2699
2700 2016-07-05  Brady Eidson  <beidson@apple.com>
2701
2702         Database process crashes deleting a corrupt SQLite database file (null deref).
2703         https://bugs.webkit.org/show_bug.cgi?id=155506.
2704
2705         Reviewed by Alex Christensen.
2706
2707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2708         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
2709         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
2710         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
2711         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
2712         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
2713
2714 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
2715
2716         run-webkit-tests should print more complete baseline search paths
2717         https://bugs.webkit.org/show_bug.cgi?id=159354
2718
2719         Reviewed by Daniel Bates.
2720
2721         run-webkit-tests used to only print directory names in baseline search paths.
2722         This was ok in basic usage, but quickly got confusing when using
2723         --additional-platform-directory flags.
2724
2725         * Scripts/webkitpy/layout_tests/views/printing.py:
2726         (Printer.print_config):
2727         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2728         (Testprinter.test_print_config):
2729         (Testprinter.test_print_one_line_summary):
2730
2731 2016-07-04  Brady Eidson  <beidson@apple.com>
2732
2733         WebProcesses don't handle DatabaseProcess going away uncleanly..
2734         https://bugs.webkit.org/show_bug.cgi?id=159371
2735
2736         Reviewed by Alex Christensen.
2737
2738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2739         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
2740         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
2741         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
2742         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
2743
2744 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2745
2746         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
2747         https://bugs.webkit.org/show_bug.cgi?id=158141
2748
2749         Rubber-stamped by Michael Catanzaro.
2750
2751         Instead of checking for an specific Ubuntu version, query the apt
2752         database to see which version of PHP is available.
2753
2754         * efl/install-dependencies:
2755         * gtk/install-dependencies:
2756
2757 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
2758
2759         webkit-patch failure-reason always raises TypeError
2760         https://bugs.webkit.org/show_bug.cgi?id=159394
2761
2762         Reviewed by Benjamin Poulain.
2763
2764         In r170637 (Bug 133067), the first and second arguments of
2765         pluralize were swapped.
2766
2767         * Scripts/webkitpy/tool/commands/queries.py:
2768         (FailureReason._builder_to_explain): Swap the first and second
2769         arguments of pluralize.
2770
2771 2016-07-02  Youenn Fablet  <youennf@gmail.com>
2772
2773         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
2774         https://bugs.webkit.org/show_bug.cgi?id=152486
2775
2776         Reviewed by Daniel Bates.
2777
2778         Add launch of web-platform-tests server by run-webkit-httpd.
2779         Add two options to disable starting httpd and web-platform-tests servers.
2780
2781         * Scripts/run-webkit-httpd:
2782         (parse_args):
2783         (main):
2784
2785 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
2786
2787         REGRESSION(r189668): Notification tests are flakey
2788         https://bugs.webkit.org/show_bug.cgi?id=159375
2789         <rdar://problem/22760990>
2790
2791         Reviewed by Alexey Proskuryakov.
2792
2793         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
2794         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
2795         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
2796         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
2797
2798         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
2799         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
2800         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
2801         global notification ID mapping, causing the wrong notification to be investigated.
2802
2803         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
2804         manually perform this same mapping. Luckily, this object already receives callbacks every time a
2805         notification is created or destroyed. However, because this object is implemented outside WebKit,
2806         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
2807         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
2808         WebNotificationProvider can properly map between the different IDs.
2809
2810         * WebKitTestRunner/TestController.cpp:
2811         (WTR::TestController::runTestingServerLoop):
2812         (WTR::TestController::simulateWebNotificationClick):
2813         * WebKitTestRunner/WebNotificationProvider.cpp:
2814         (WTR::WebNotificationProvider::showWebNotification):
2815         (WTR::removeGlobalIDFromIDMap):
2816         (WTR::WebNotificationProvider::closeWebNotification):
2817         (WTR::WebNotificationProvider::removeNotificationManager):
2818         (WTR::WebNotificationProvider::simulateWebNotificationClick):
2819         (WTR::WebNotificationProvider::reset):
2820         * WebKitTestRunner/WebNotificationProvider.h:
2821
2822 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
2823
2824         Simplify LayoutTestRelay
2825         https://bugs.webkit.org/show_bug.cgi?id=159353
2826
2827         Reviewed by Daniel Bates.
2828
2829         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
2830         by name and runtime makes no sense.
2831         2. Removed code to create devices, webkitpy always does this in advance.
2832         3. Don't create copies of testing apps - we can install the same one into
2833         each simulator, now that we don't run multiple tester processes in a single simulator.
2834         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
2835         5. Removed code that kept testing apps alive in the background.
2836         6. Slightly updated coding style in functions that I touched.
2837
2838         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
2839         Updated for what we acually use at this point.
2840
2841         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
2842         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2843         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
2844         (-[LTRelayController ipcIdentifier]):
2845         (-[LTRelayController processName]):
2846         (-[LTRelayController didReceiveStdoutData:]):
2847         (-[LTRelayController didCrashWithMessage:]):
2848         (-[LTRelayController installApp]):
2849         (-[LTRelayController _environmentVariables]):
2850         (-[LTRelayController launchApp]):
2851         (-[LTRelayController start]):
2852         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
2853         (-[LTRelayController uniqueAppPath]): Deleted.
2854         (-[LTRelayController uniqueAppURL]): Deleted.
2855         (-[LTRelayController uniqueAppIdentifier]): Deleted.
2856         (-[LTRelayController createUniqueApp]): Deleted.
2857         * LayoutTestRelay/LayoutTestRelay/main.m:
2858         (usage):
2859         (getRequiredStringArgument):
2860         (main):
2861         (getTestingSimDevice): Deleted.
2862         * Scripts/webkitpy/port/driver.py:
2863         (IOSSimulatorDriver.cmd_line):
2864         * WebKitTestRunner/ios/TestControllerIOS.mm:
2865         (WTR::TestController::platformInitialize):
2866         * WebKitTestRunner/ios/mainIOS.mm:
2867         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
2868         * DumpRenderTree/mac/DumpRenderTree.mm:
2869         (dumpRenderTree):
2870         (-[DumpRenderTree applicationDidEnterBackground:]):
2871
2872 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
2873
2874         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
2875         https://bugs.webkit.org/show_bug.cgi?id=159344
2876
2877         Reviewed by Alex Christensen.
2878
2879         * DumpRenderTree/CMakeLists.txt:
2880
2881 2016-07-01  Youenn Fablet  <youennf@gmail.com>
2882
2883         Add a runtime flag for DOM iterators
2884         https://bugs.webkit.org/show_bug.cgi?id=159300
2885
2886         Reviewed by Alex Christensen.
2887
2888         * DumpRenderTree/mac/DumpRenderTree.mm:
2889         (resetWebPreferencesToConsistentValues):
2890         * DumpRenderTree/win/DumpRenderTree.cpp:
2891         (resetWebPreferencesToConsistentValues):
2892         * Scripts/webkitperl/FeatureList.pm:
2893         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2894         (WTR::InjectedBundle::beginTesting):
2895         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2896         (WTR::TestRunner::setDOMIteratorEnabled):
2897         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2898
2899 2016-06-30  Tina Liu  <iting_liu@apple.com>
2900
2901         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
2902         https://bugs.webkit.org/show_bug.cgi?id=159326
2903
2904         Reviewed by Brady Eidson.
2905
2906         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2907         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
2908         (TestWebKitAPI::didFinishLoadForFrame):
2909         (TestWebKitAPI::didChangeBackForwardListForPage):
2910         (TestWebKitAPI::setPageLoaderClient):
2911         Set the page loader client and register for didFinishLoadForFrame and
2912         didChangeBackForwardList callbacks.
2913         (TestWebKitAPI::createSessionStateData):
2914         Load a webpage ("simple.html") and return the session state for this page.
2915         (TestWebKitAPI::TEST):
2916         Restore the page session state with that of "simple.html" without navigation.
2917         Verify that the committed URL is NULL since there's no navigation involved.
2918         Verify that the current item in the back forward list, which should be what
2919         we restored from the session state, has the expected URL.
2920
2921 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
2922
2923         Generators violate bytecode liveness validation
2924         https://bugs.webkit.org/show_bug.cgi?id=159279
2925
2926         Reviewed by Yusuke Suzuki.
2927         
2928         Add Basic to our test harness.
2929
2930         * Scripts/run-javascriptcore-tests:
2931         (runJSCStressTests):
2932
2933 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
2934
2935         [Win][Debug] Assertion fails in TestWTF.
2936         https://bugs.webkit.org/show_bug.cgi?id=159299
2937
2938         Reviewed by Alex Christensen.
2939
2940         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
2941         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
2942         the assertion failure. Since the variable is actually used, there is no need to use the
2943         UNUSED_PARAM macro.
2944
2945         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
2946         (TestWebKitAPI::TEST):
2947
2948 2016-06-30  Youenn Fablet  <youennf@gmail.com>
2949
2950         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
2951         https://bugs.webkit.org/show_bug.cgi?id=159166
2952         <rdar://problem/27051759>
2953
2954         Reviewed by Alexey Proskuryakov.
2955
2956         Setting the certificate directory to the copied config.json.
2957
2958         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2959         (WebPlatformTestServer._copy_webkit_test_files):
2960
2961 2016-06-29  Mark Lam  <mark.lam@apple.com>
2962
2963         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
2964         https://bugs.webkit.org/show_bug.cgi?id=159274
2965
2966         Reviewed by Keith Miller.
2967
2968         * DumpRenderTree/mac/DumpRenderTree.mm:
2969         (DumpRenderTreeMain):
2970
2971 2016-06-29  Alex Christensen  <achristensen@webkit.org>
2972
2973         WKWebView should ask WKNavigationDelegate about bad ssl certificates
2974         https://bugs.webkit.org/show_bug.cgi?id=159176
2975
2976         Reviewed by Sam Weinig.
2977
2978         * MiniBrowser/mac/WK2BrowserWindowController.m:
2979         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2980         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
2981         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2982
2983 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2984
2985         [GTK] Add missing install dependency after r202619
2986         https://bugs.webkit.org/show_bug.cgi?id=156716
2987
2988         Unreviewed.
2989
2990         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
2991
2992 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2993
2994         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
2995         https://bugs.webkit.org/show_bug.cgi?id=156716
2996
2997         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
2998
2999         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3000         (parse_args):
3001         * Scripts/webkitpy/port/gtk.py:
3002         (GtkPort.__init__):
3003         (GtkPort._driver_class):
3004         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3005         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3006         platform directory for storing the wayland specific layout test results and expectations for ${port}.
3007         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3008         test expectations file on the GTK port when running the tests with the --wayland command line switch.
3009         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3010         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3011         (WestonDriver.check_driver):
3012         (WestonDriver.__init__):
3013         (WestonDriver._start):
3014         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3015         (WestonXvfbDriverDisplayTest):
3016         (WestonXvfbDriverDisplayTest.__init__):
3017         (WestonXvfbDriverDisplayTest._xvfb_run):
3018         (WestonDriverTest.make_driver):
3019         (WestonDriverTest.test_start):
3020         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3021         or to satisfy the pkg-config check of the new added modules in JHBuild.
3022         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3023         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3024         provided by the system are already new enough.
3025         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3026         It was the only way to get the software EGL rasterizer working without depending on user drivers.
3027         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3028         feature to avoid building libdrm when the one provided by the system is new enough.
3029         * gtk/jhbuildrc:
3030         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
3031         Xorg had no support for searching the DRI drivers on a custom path at runtime.
3032         This patch implements support for that reusing the same variable that we use with Mesa to set the
3033         custom path for the DRI drivers path.
3034
3035 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
3036
3037         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
3038         https://bugs.webkit.org/show_bug.cgi?id=159256
3039
3040         Reviewed by Philippe Normand.
3041
3042         We need the last fixes in the repository to make the scream queue
3043         work with apprtc.
3044
3045         * gtk/jhbuild.modules:
3046
3047 2016-06-28  Commit Queue  <commit-queue@webkit.org>
3048
3049         Unreviewed, rolling out r202580.
3050         https://bugs.webkit.org/show_bug.cgi?id=159245
3051
3052         Caused all WKTR tests to fail on GuardMalloc and Production
3053         only for unknown reasons, investigating offline. (Requested by
3054         brrian on #webkit).
3055
3056         Reverted changeset:
3057
3058         "RunLoop::Timer should use constructor templates instead of
3059         class templates"
3060         https://bugs.webkit.org/show_bug.cgi?id=159153
3061         http://trac.webkit.org/changeset/202580
3062
3063 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3064
3065         Use a regex to check if a test step is for JavaScriptCore
3066         https://bugs.webkit.org/show_bug.cgi?id=159224
3067
3068         Reviewed by Geoffrey Garen.
3069
3070         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3071         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
3072         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3073         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
3074         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3075         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
3076
3077 2016-06-28  Michael Saboff  <msaboff@apple.com>
3078
3079         btjs no longer accepts optional frame count argument
3080         https://bugs.webkit.org/show_bug.cgi?id=159235
3081
3082         Reviewed by Saam Barati.
3083
3084         Fix the detection of optional backtrace-depth parameter to use the length
3085         of the command.
3086
3087         * lldb/lldb_webkit.py:
3088         (btjs):
3089
3090 2016-06-28  Jon Lee  <jonlee@apple.com>
3091
3092         Update animometer.plan
3093
3094         Rubber-stamped by Said Abou-Hallawa.
3095
3096         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
3097
3098 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
3099
3100         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
3101
3102         * Scripts/run-javascriptcore-tests:
3103         (runJSCStressTests):
3104
3105 2016-06-28  Brian Burg  <bburg@apple.com>
3106
3107         RunLoop::Timer should use constructor templates instead of class templates
3108         https://bugs.webkit.org/show_bug.cgi?id=159153
3109
3110         Reviewed by Alex Christensen.
3111
3112         Remove the RunLoop::Timer class template argument, and pass its constructor
3113         a reference to `this` instead of a pointer to `this`.
3114
3115         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3116         (WTR::TestRunner::TestRunner):
3117         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3118         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3119         (TestWebKitAPI::TEST):
3120
3121 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3122
3123         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3124         https://bugs.webkit.org/show_bug.cgi?id=159199
3125
3126         Reviewed by Alexey Proskuryakov.
3127
3128         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
3129
3130         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3131         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3132         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
3133         an input element getting automatically focused on Mac.
3134
3135 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
3136
3137         [Win] Custom elements tests are failing.
3138         https://bugs.webkit.org/show_bug.cgi?id=159139
3139
3140         Reviewed by Alex Christensen.
3141
3142         Enable custom element API when running tests.
3143
3144         * DumpRenderTree/win/DumpRenderTree.cpp:
3145         (resetWebPreferencesToConsistentValues):
3146
3147 2016-06-27  Lucas Forschler  <lforschler@apple.com>
3148
3149         Test commit. Please ignore.
3150         
3151 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3152
3153         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
3154         https://bugs.webkit.org/show_bug.cgi?id=155073
3155
3156         Reviewed by Daniel Bates.
3157
3158         * Scripts/webkitperl/FeatureList.pm:
3159
3160 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
3161
3162         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3163         https://bugs.webkit.org/show_bug.cgi?id=159077
3164
3165         Reviewed by Tim Horton.
3166
3167         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
3168
3169         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
3170         which is necessary for UI-side compositing.
3171
3172         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
3173         seems to happen for some tests that call window.resizeTo().
3174
3175         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3176         (WTR::InjectedBundlePage::dump): Deleted.
3177         * WebKitTestRunner/TestInvocation.cpp:
3178         (WTR::TestInvocation::dumpResults):
3179         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3180         (WTR::createCGContextFromImage):
3181         (WTR::computeMD5HashStringForContext):
3182         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3183         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3184         (WTR::PlatformWebView::windowSnapshotImage):
3185
3186 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3187
3188         [EFL] Support to build on Debian linux
3189         https://bugs.webkit.org/show_bug.cgi?id=159123
3190
3191         Reviewed by Antonio Gomes.
3192
3193         * efl/install-dependencies: Install libgnutls28-dev.
3194
3195 2016-06-27  Alex Christensen  <achristensen@webkit.org>
3196
3197         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
3198         https://bugs.webkit.org/show_bug.cgi?id=159071
3199
3200         Reviewed by Brady Eidson.
3201
3202         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3203         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3204         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3205         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3206         (WTR::TestRunner::setAuthenticationUsername):
3207         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3208         * WebKitTestRunner/TestController.cpp:
3209         (WTR::TestController::TestController):
3210         (WTR::TestController::resetStateToConsistentValues):
3211         (WTR::TestController::didFinishNavigation):
3212         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3213         (WTR::TestController::didReceiveAuthenticationChallenge):
3214         (WTR::TestController::didCommitNavigation):
3215         * WebKitTestRunner/TestController.h:
3216         (WTR::TestController::setBlockAllPlugins):
3217         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3218         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
3219         (WTR::TestController::isCurrentInvocation):
3220         * WebKitTestRunner/TestInvocation.cpp:
3221         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3222         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
3223
3224 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
3225
3226         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
3227         https://bugs.webkit.org/show_bug.cgi?id=159129
3228
3229         Reviewed by Alex Christensen.
3230
3231         Implement the function mouseScrollBy in the Windows event sender.
3232
3233         * DumpRenderTree/win/EventSender.cpp:
3234         (mouseScrollBy):
3235         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3236
3237 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
3238
3239         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3240         https://bugs.webkit.org/show_bug.cgi?id=159104
3241
3242         Reviewed by Dan Bernstein.
3243         
3244         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
3245         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
3246
3247         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3248         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
3250
3251 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
3252
3253         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
3254         https://bugs.webkit.org/show_bug.cgi?id=159086
3255
3256         Reviewed by Alex Christensen.
3257
3258         Implement required wheel event function in event sender.
3259  
3260         * DumpRenderTree/win/EventSender.cpp:
3261         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3262
3263 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
3264
3265         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3266         https://bugs.webkit.org/show_bug.cgi?id=159104
3267
3268         Reviewed by Mark Lam.
3269         
3270         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
3271         WK.
3272
3273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3274
3275 2016-06-24  David Kilzer  <ddkilzer@apple.com>
3276
3277         parser_unittests.pl should not hardcode list of tests
3278         <https://webkit.org/b/159074>
3279
3280         Reviewed by Daniel Bates.
3281
3282         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3283         Update to read the list of tests from the 'resources' directory,
3284         and instead map file extensions to subroutine names.  Switch to
3285         use File::Basename::fileparse() to get basename and file
3286         extension for each test.
3287         (readTestFiles): Added.  Reads files from the directory passed
3288         in and ignores: hidden files, anything that isn't a plain file,
3289         and expected test results files.
3290
3291 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3292
3293         Fix Windows build.
3294
3295         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3296         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3297
3298 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3299
3300         [EFL] Change download path of libxslt
3301
3302         Unreviewed EFL build fix.
3303
3304         In Korea current download path can't be accessed. Change it.
3305
3306         * efl/jhbuild.modules:
3307
3308 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3309
3310         https://bugs.webkit.org/show_bug.cgi?id=159077
3311
3312         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
3313         snapshot the final state of the test in release builds. 
3314
3315         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3316         (WTR::InjectedBundlePage::dump):
3317
3318 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3319
3320         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
3321
3322         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3323         (createBitmapContextFromWebView):
3324         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3325         (WTR::PlatformWebView::windowSnapshotImage):
3326
3327 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3328
3329         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3330         https://bugs.webkit.org/show_bug.cgi?id=159077
3331
3332         Reviewed by Tim Horton.
3333
3334         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
3335         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
3336         thus enabling testing of more things.
3337
3338         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3339         (createBitmapContext): Moved to this file to share it.
3340         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3341         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3342         (createBitmapContextFromWebView):
3343         (BitmapContext::createFromUIImage): Deleted.
3344         (BitmapContext::pixelData): Deleted.
3345         (BitmapContext::BitmapContext): Deleted.
3346         (computeMD5HashStringForBitmapContext): Deleted.
3347         (dumpBitmap): Deleted.
3348         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
3349         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3350         (createPagedBitmapContext):
3351         (createBitmapContext): Deleted.
3352         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
3353         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3354         (WTR::InjectedBundlePage::dump): Deleted.
3355         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3356         (WTR::PlatformWebView::windowSnapshotImage):
3357
3358 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3359
3360         [jhbuild] Added libxslt module.
3361         https://bugs.webkit.org/show_bug.cgi?id=159034
3362
3363         Unreviewed, followup for r202373.
3364
3365         * efl/install-dependencies: Removed libxslt 
3366         * gtk/install-dependencies: Ditto.
3367
3368 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3369
3370         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
3371         https://bugs.webkit.org/show_bug.cgi?id=159050
3372
3373         Reviewed by Antonio Gomes.
3374
3375         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
3376
3377         * efl/jhbuild.modules:
3378         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3379         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3380
3381 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3382
3383         [jhbuild] Added libxslt module.
3384         https://bugs.webkit.org/show_bug.cgi?id=159034
3385
3386         Reviewed by Michael Catanzaro.
3387
3388         * efl/jhbuild.modules:
3389         * gtk/jhbuild.modules:
3390
3391 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3392
3393         [Win] Use Windows api function to find top level parent.
3394         https://bugs.webkit.org/show_bug.cgi?id=159021
3395
3396         Reviewed by Brent Fulgham.
3397
3398         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
3399  
3400         * DumpRenderTree/win/UIDelegate.cpp:
3401         (UIDelegate::runModal):
3402         (findTopLevelParent): Deleted.
3403         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3404         (PrintWebUIDelegate::runModal):
3405         (findTopLevelParent): Deleted.
3406
3407 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3408
3409         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
3410         https://bugs.webkit.org/show_bug.cgi?id=158934
3411
3412         Reviewed by Brent Fulgham.
3413
3414         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
3415
3416         * DumpRenderTree/win/TestRunnerWin.cpp:
3417         (TestRunner::clearAllDatabases):
3418
3419 2016-06-22  Saam Barati  <sbarati@apple.com>
3420
3421         run-javascriptcore-tests should have some environment variables for commonly used settings
3422         https://bugs.webkit.org/show_bug.cgi?id=159047
3423
3424         Reviewed by Keith Miller.
3425
3426         This patch adds three environment variables that run-javascriptcore-tests
3427         consults:
3428         - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
3429           determines if we should run the api tests or not.
3430         - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
3431           determines if we will perform a build or not before running the tests.
3432           to set the default should-build setting.
3433         - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
3434           a yaml file. If set, we will run the extra tests it refers to.
3435
3436         All the values in these environment variables will be overridden if an
3437         option is explicitly passed in. For example, the following will run
3438         the api tests:
3439         `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
3440
3441         * Scripts/run-javascriptcore-tests:
3442
3443 2016-06-22  Saam barati  <sbarati@apple.com>
3444
3445         TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
3446         https://bugs.webkit.org/show_bug.cgi?id=159037
3447         <rdar://problem/26935349>
3448
3449         Reviewed by Benjamin Poulain.
3450
3451         Run typeProfiler.yaml tests under an additional CJIT enabled mode.
3452
3453         * Scripts/run-jsc-stress-tests:
3454
3455 2016-06-22  Aakash Jain  <aakash_jain@apple.com>
3456
3457         Fix style issues in webkitpy
3458         https://bugs.webkit.org/show_bug.cgi?id=159019
3459
3460         Reviewed by Daniel Bates.
3461
3462         Fixed the formatting issues as reported by check-webkit-style in webkitpy.
3463         There is no functionality change.
3464         Only affected file names retained below for brevity.
3465
3466         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3467         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3468         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3469         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3470         * Scripts/webkitpy/benchmark_runner/utils.py:
3471         * Scripts/webkitpy/common/checkout/changelog.py:
3472         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3473         * Scripts/webkitpy/common/checkout/checkout.py:
3474         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3475         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3476         * Scripts/webkitpy/common/checkout/commitinfo.py:
3477         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3478         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3479         * Scripts/webkitpy/common/checkout/scm/scm.py:
3480         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3481         * Scripts/webkitpy/common/config/committers_unittest.py:
3482         * Scripts/webkitpy/common/config/irc.py:
3483         * Scripts/webkitpy/common/config/ports.py:
3484         * Scripts/webkitpy/common/config/ports_unittest.py:
3485         * Scripts/webkitpy/common/config/urls.py:
3486         * Scripts/webkitpy/common/host_mock.py:
3487         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3488         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3489         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3490         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3491         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3492         * Scripts/webkitpy/common/net/credentials_unittest.py:
3493         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
3494         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3495         * Scripts/webkitpy/common/net/statusserver.py:
3496         * Scripts/webkitpy/common/system/autoinstall.py:
3497         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3498         * Scripts/webkitpy/common/system/executive.py:
3499         * Scripts/webkitpy/common/system/executive_mock.py:
3500         * Scripts/webkitpy/common/system/executive_unittest.py:
3501         * Scripts/webkitpy/common/system/filesystem_mock.py:
3502         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3503         * Scripts/webkitpy/common/system/logutils_unittest.py:
3504         * Scripts/webkitpy/common/system/path.py:
3505         * Scripts/webkitpy/common/system/path_unittest.py:
3506         * Scripts/webkitpy/common/system/platforminfo.py:
3507         * Scripts/webkitpy/common/system/user.py:
3508         * Scripts/webkitpy/common/system/user_unittest.py:
3509         * Scripts/webkitpy/common/system/workspace_unittest.py:
3510         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
3511         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
3512         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3513         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3514         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3515         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3516         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3517         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3518         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3519         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3520         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3521         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3522         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3523         * Scripts/webkitpy/layout_tests/views/printing.py:
3524         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3525         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3526         * Scripts/webkitpy/port/base_unittest.py:
3527         * Scripts/webkitpy/port/driver.py:
3528         * Scripts/webkitpy/port/driver_unittest.py:
3529         * Scripts/webkitpy/port/factory.py:
3530         * Scripts/webkitpy/port/gtk.py:
3531         * Scripts/webkitpy/port/server_process_unittest.py:
3532         * Scripts/webkitpy/port/test.py:
3533         * Scripts/webkitpy/port/win.py:
3534         * Scripts/webkitpy/style/checker.py:
3535         * Scripts/webkitpy/style/checkers/common_unittest.py:
3536         * Scripts/webkitpy/style/checkers/cpp.py:
3537         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3538         * Scripts/webkitpy/style/checkers/js.py:
3539         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3540         * Scripts/webkitpy/style/checkers/png.py:
3541         * Scripts/webkitpy/style/checkers/text.py:
3542         * Scripts/webkitpy/style/checkers/text_unittest.py:
3543         * Scripts/webkitpy/style/error_handlers.py:
3544         * Scripts/webkitpy/style/filter.py:
3545         * Scripts/webkitpy/style/filter_unittest.py:
3546         * Scripts/webkitpy/style/optparser.py:
3547         * Scripts/webkitpy/style/optparser_unittest.py:
3548         * Scripts/webkitpy/test/main.py:
3549         * Scripts/webkitpy/w3c/test_converter.py:
3550         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3551         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3552         * Scripts/webkitpy/xcode/simulator.py:
3553
3554 2016-06-22  Brady Eidson  <beidson@apple.com>
3555
3556         DatabaseProcess doesn't handle WebProcesses going away uncleanly.
3557         https://bugs.webkit.org/show_bug.cgi?id=158894
3558
3559         Reviewed by Alex Christensen.
3560
3561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3562         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
3563         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
3564         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3565
3566 2016-06-22  Jon Lee  <jonlee@apple.com>
3567
3568         Update animometer.plan
3569         https://bugs.webkit.org/show_bug.cgi?id=159012
3570
3571         Reviewed by Ryosuke Niwa.
3572
3573         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
3574
3575 2016-06-22  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3576
3577         W3C test importer should generate files to ignore by WebKit SCM
3578         https://bugs.webkit.org/show_bug.cgi?id=142743
3579
3580         Reviewed by Darin Adler.
3581
3582         TestDownloader generates the .gitignore file according submodules git repository information.
3583         TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.
3584
3585         * Scripts/webkitpy/w3c/test_downloader.py:
3586         (TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
3587         * Scripts/webkitpy/w3c/test_importer.py:
3588         (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
3589         (TestImporter):
3590         (TestImporter.write_init_py): Writing not empty __init__.py files.
3591         (TestImporter.import_tests): Using  of write_init_py. 
3592         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3593         (TestImporterTest.test_git_ignore_generation): Added .gitignore test.
3594         (TestImporterTest):
3595         (TestImporterTest.test_initpy_generation): Added __init__.py test.
3596
3597 2016-06-21  Sam Weinig  <sam@webkit.org>
3598
3599         WKWebView with no WKNavigationDelegate does not follow universal links
3600         <rdar://problem/24374110>
3601         https://bugs.webkit.org/show_bug.cgi?id=158997
3602
3603         Reviewed by Dan Bernstein.
3604
3605         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3606         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
3607         Add a new test that shows that we have a default navigation delegate by swizzling
3608         -[NSWorkspace openURL:]. This will only be called if there is a default client.
3609
3610 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3611
3612         [Win] Implement modal dialog support in MiniBrowser.
3613         https://bugs.webkit.org/show_bug.cgi?id=158976
3614
3615         Reviewed by Brent Fulgham.
3616
3617         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3618         (PrintWebUIDelegate::createWebViewWithRequest):
3619         (getHandleFromWebView):
3620         (PrintWebUIDelegate::webViewClose):
3621         (PrintWebUIDelegate::setFrame):
3622         (PrintWebUIDelegate::webViewFrame):
3623         (PrintWebUIDelegate::canRunModal):
3624         (findTopLevelParent):
3625         (PrintWebUIDelegate::runModal):
3626         (PrintWebUIDelegate::createModalDialog):
3627         * MiniBrowser/win/PrintWebUIDelegate.h:
3628         (PrintWebUIDelegate::webViewClose):
3629         (PrintWebUIDelegate::setFrame):
3630         (PrintWebUIDelegate::webViewFrame):
3631         (PrintWebUIDelegate::canRunModal):
3632         (PrintWebUIDelegate::runModal):
3633
3634 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3635
3636         window.showModalDialog doesn't work in DumpRenderTree on Windows
3637         https://bugs.webkit.org/show_bug.cgi?id=53675
3638
3639         Reviewed by Brent Fulgham.
3640
3641         Implement modal dialog support in DumpRenderTree.
3642
3643         * DumpRenderTree/win/UIDelegate.cpp:
3644         (UIDelegate::canRunModal):
3645         (getHandleFromWebView):
3646         (UIDelegate::createModalDialog):
3647         (findTopLevelParent):
3648         (UIDelegate::runModal):
3649         (UIDelegate::webViewClose):
3650         * DumpRenderTree/win/UIDelegate.h:
3651
3652 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
3653
3654         Fix formatting issues reported by check-webkit-style
3655         https://bugs.webkit.org/show_bug.cgi?id=159008
3656
3657         Reviewed by Alexey Proskuryakov.
3658
3659         Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
3660         There is no functionality change.
3661
3662         * Scripts/webkitpy/tool/bot/irc_command.py:
3663         (Restart.execute):
3664         (Rollout):
3665         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3666         (IRCBotTest.test_exception_during_command):
3667         (IRCBotTest.test_exception_during_command.CommandWithException):
3668         (IRCBotTest.test_exception_during_command.CommandWithException.execute):
3669         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3670         (test_missing_unit_test_results_path):
3671         (test_layout_test_results):
3672         * Scripts/webkitpy/tool/bot/queueengine.py:
3673         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3674         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3675         (AbstractSequencedCommand):
3676         (AbstractSequencedCommand.__init__):
3677         * Scripts/webkitpy/tool/commands/download.py:
3678         (Land):
3679         * Scripts/webkitpy/tool/commands/openbugs.py:
3680         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3681         (OpenBugsTest):
3682         * Scripts/webkitpy/tool/commands/queries.py:
3683         (PatchesToCommitQueue):
3684         (PatchesToCommitQueue.__init__):
3685         (PatchesToCommitQueue._needs_commit_queue):
3686         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3687         (PrintExpectationsTest.test_platform):
3688         (PrintBaselinesTest):
3689         (PrintBaselinesTest.setUp):
3690         * Scripts/webkitpy/tool/commands/queues.py:
3691         (AbstractQueue):
3692         (AbstractQueue.__init__):
3693         (AbstractQueue.execute):
3694         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3695         (test_auto_retry):
3696         * Scripts/webkitpy/tool/commands/rebaseline.py:
3697         (AbstractParallelRebaselineCommand._files_to_add):
3698         (AbstractParallelRebaselineCommand):
3699         (AbstractParallelRebaselineCommand._rebaseline):
3700         * Scripts/webkitpy/tool/commands/setupgitclone.py:
3701         (SetupGitClone):
3702         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3703         * Scripts/webkitpy/tool/commands/stepsequence.py:
3704         * Scripts/webkitpy/tool/commands/upload.py:
3705         (PostCommits._comment_text_for_commit):
3706         (PostCommits):
3707         (PostCommits.execute):
3708         (MarkBugFixed):
3709         (MarkBugFixed.__init__):
3710         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3711         (UploadCommandsTest):
3712         (UploadCommandsTest.test_commit_message_for_current_diff):
3713         * Scripts/webkitpy/tool/grammar_unittest.py:
3714         (GrammarTest):
3715         (GrammarTest.test_join_with_separators):
3716         * Scripts/webkitpy/tool/multicommandtool.py:
3717         (HelpCommand.__init__):
3718         (HelpCommand):
3719         (HelpCommand._help_epilog):
3720         (HelpCommand._remove_help_options):
3721         (MultiCommandTool):
3722         (MultiCommandTool.__init__):
3723         (MultiCommandTool.main):
3724         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
3725         (TrivialCommand):
3726         (TrivialCommand.__init__):
3727         (MultiCommandToolTest):
3728         (MultiCommandToolTest._assert_tool_main_outputs):
3729         (MultiCommandToolTest.test_retry):
3730         (test_command_help):
3731         * Scripts/webkitpy/tool/steps/__init__.py:
3732         * Scripts/webkitpy/tool/steps/abstractstep.py:
3733         * Scripts/webkitpy/tool/steps/applypatch.py:
3734         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
3735         (ApplyPatchWithLocalCommit):
3736         (ApplyPatchWithLocalCommit.options):
3737         * Scripts/webkitpy/tool/steps/build.py:
3738         * Scripts/webkitpy/tool/steps/checkstyle.py:
3739         (CheckStyle):
3740         (CheckStyle.options):
3741         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3742         * Scripts/webkitpy/tool/steps/closebug.py:
3743         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
3744         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
3745         (CloseBugForLandDiffTest):
3746         (CloseBugForLandDiffTest.test_empty_state):
3747         * Scripts/webkitpy/tool/steps/closepatch.py:
3748         * Scripts/webkitpy/tool/steps/commit.py:
3749         (Commit.run):
3750         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3751         * Scripts/webkitpy/tool/steps/editchangelog.py:
3752         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
3753         * Scripts/webkitpy/tool/steps/metastep.py:
3754         (MetaStep):
3755         (MetaStep.__init__):
3756         (MetaStep.run):
3757         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
3758         * Scripts/webkitpy/tool/steps/options.py:
3759         (Options):
3760         * Scripts/webkitpy/tool/steps/postdiff.py:
3761         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
3762         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
3763         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3764         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
3765         (PrepareChangeLogTest):
3766         (PrepareChangeLogTest.test_resolve_existing_entry):
3767         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3768         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
3769         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3770         * Scripts/webkitpy/tool/steps/revertrevision.py:
3771         * Scripts/webkitpy/tool/steps/runtests.py:
3772         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3773         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3774         (StepsTest):
3775         (StepsTest._step_options):
3776         * Scripts/webkitpy/tool/steps/update.py:
3777         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
3778         (UpdateChangeLogsWithReviewerTest):
3779         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
3780         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3781         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3782
3783 2016-06-21  Chris Dumez  <cdumez@apple.com>
3784
3785         Unreviewed, rolling out r202296.
3786
3787         Broke basic browsing in Safari
3788
3789         Reverted changeset:
3790
3791         "WKWebView with no WKNavigationDelegate does not follow
3792         universal links"
3793         https://bugs.webkit.org/show_bug.cgi?id=158997
3794         http://trac.webkit.org/changeset/202296
3795
3796 2016-06-21  Anders Carlsson  <andersca@apple.com>
3797
3798         Fix build.
3799
3800         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3801
3802 2016-06-21  Anders Carlsson  <andersca@apple.com>
3803
3804         Begin moving the Apple Pay code to the open source repository
3805         https://bugs.webkit.org/show_bug.cgi?id=158998
3806
3807         Reviewed by Tim Horton.
3808
3809         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3810         Add ENABLE_APPLE_PAY.
3811
3812 2016-06-21  Said Abou-Hallawa  <sabouhallawa@apple,com>
3813
3814         Add system tracing points for requestAnimationFrame() workflow
3815         https://bugs.webkit.org/show_bug.cgi?id=158723
3816
3817         Reviewed by Simon Fraser.
3818
3819         Add new plist entries to be used by kdebug_trace() viewing tools.
3820
3821         * Tracing/SystemTracePoints.plist:
3822
3823 2016-06-21  Sam Weinig  <sam@webkit.org>
3824
3825         WKWebView with no WKNavigationDelegate does not follow universal links
3826         <rdar://problem/24374110>
3827         https://bugs.webkit.org/show_bug.cgi?id=158997
3828
3829         Reviewed by Dan Bernstein.
3830
3831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3832         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
3833         Add a new test that shows that we have a default navigation delegate by swizzling
3834         -[NSWorkspace openURL:]. This will only be called if there is a default client.
3835
3836 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
3837
3838         run-javascriptcore-tests should have flag to skip mozilla tests
3839         https://bugs.webkit.org/show_bug.cgi?id=158963
3840         rdar://problem/25838924
3841
3842         Reviewed by Alexey Proskuryakov.
3843
3844         * Scripts/run-javascriptcore-tests:
3845         (runJSCStressTests): Added flag to skip mozilla tests.
3846
3847 2016-06-20  Commit Queue  <commit-queue@webkit.org>
3848
3849         Unreviewed, rolling out r202136.
3850         https://bugs.webkit.org/show_bug.cgi?id=158932
3851
3852         JSBench wasn't regressed by r202002 and r202111 on iOS after
3853         all (Requested by rniwa_ on #webkit).
3854
3855         Reverted changeset:
3856
3857         "Unreviewed, rolling out r202002 and r202111."
3858         https://bugs.webkit.org/show_bug.cgi?id=158638
3859         http://trac.webkit.org/changeset/202136
3860
3861 2016-06-20  Keith Rollin  <krollin@apple.com>
3862
3863         Remove RefPtr::release() and change calls sites to use WTFMove()
3864         https://bugs.webkit.org/show_bug.cgi?id=158369
3865
3866         Reviewed by Chris Dumez.
3867
3868         RefPtr::release() releases its managed pointer awkwardly. It's more
3869         direct and clearer to use WTFMove to transfer ownership of the managed
3870         pointer.
3871
3872         As part of this cleanup, also change a lot of explicit data types to
3873         'auto'.
3874
3875         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3876         (createBitmapContextFromWebView):
3877         (createPagedBitmapContext):
3878         * DumpRenderTree/mac/TestRunnerMac.mm:
3879         (TestRunner::setMockGeolocationPosition):
3880         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
3881         (TestWebKitAPI::TEST):
3882         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3883         (TestWebKitAPI::TEST):
3884
3885 2016-06-20  Tim Horton  <timothy_horton@apple.com>
3886
3887         Add a API test for *DeferringViewInWindowChanges as fixed in r202230
3888         https://bugs.webkit.org/show_bug.cgi?id=158947
3889
3890         Reviewed by Simon Fraser.
3891
3892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3893         * TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Added.
3894         (TestWebKitAPI::didFinishLoadForFrame):
3895         (TestWebKitAPI::setPageLoaderClient):
3896         (TestWebKitAPI::TEST):
3897         Add a test ensuring that in-window state changes are deferred when using
3898         the SPI for deferring them, as fixed in r202230.
3899
3900 2016-06-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3901
3902         WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE"
3903         https://bugs.webkit.org/show_bug.cgi?id=158931
3904
3905         Reviewed by Alexey Proskuryakov.
3906
3907         * WebKitTestRunner/TestInvocation.cpp:
3908         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Appended missing \n at the end of line.
3909
3910 2016-06-17  Alexey Proskuryakov  <ap@apple.com>
3911
3912         Add test expectations for macOS Sierra
3913         https://bugs.webkit.org/show_bug.cgi?id=158903
3914
3915         Reviewed by Alex Christensen.
3916
3917         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png: Added.
3918         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png: Added.
3919         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3920         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3921         Added dashboard support.
3922
3923         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3924         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3925         Trigger the right build queues on check-in.
3926
3927         * Scripts/webkitpy/common/system/platforminfo.py:
3928         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3929         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3930         * Scripts/webkitpy/port/mac.py:
3931         * Scripts/webkitpy/port/mac_unittest.py:
3932         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3933         Added cases for Sierra, and updated tests for new baseline search paths.
3934
3935 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
3936
3937         Another buid fix for master.cfg.
3938
3939         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3940         (CompileWebKit.start):
3941
3942 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
3943
3944         Another buid fix for master.cfg.
3945
3946         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3947         (CompileWebKit.start):
3948
3949 2016-06-19  Lucas Forschler  <lforschler@apple.com>
3950
3951         Fix master.cfg
3952         
3953         Unreviewed build fix.
3954
3955         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3956         (CompileWebKit.start):
3957
3958 2016-06-19  Lucas Forschler  <lforschler@apple.com>
3959
3960         Test another commit.
3961         
3962         Unreviewed.
3963
3964 2016-06-19  Lucas Forschler  <lforschler@apple.com>
3965
3966         Testing fix for trac-mirror.
3967         
3968         Unreviewed.
3969
3970 2016-06-19  Lucas Forschler  <lforschler@apple.com>
3971
3972         Test a commit against the SVN 1.9 server upgrade.
3973         
3974         Unreviewed.
3975         
3976 2016-06-17  Daniel Bates  <dabates@apple.com>
3977
3978         Unreviewed, rolling out r202186.
3979
3980         Broke the Apple Windows, Apple Yosemite, GTK, and WinCairo
3981         builds.
3982
3983         Reverted changeset:
3984
3985         "File scheme should not allow access of a resource on a
3986         different volume."
3987         https://bugs.webkit.org/show_bug.cgi?id=158552
3988         http://trac.webkit.org/changeset/202186
3989
3990 2016-06-17  Pranjal Jumde  <pjumde@apple.com>
3991
3992         File scheme should not allow access of a resource on a different volume.
3993         https://bugs.webkit.org/show_bug.cgi?id=158552
3994         <rdar://problem/15307582>
3995
3996         Reviewed by Brent Fulgham.
3997
3998         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3999         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
4000         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
4001         (-[CrossPartitionFileSchemeAccessNavigationDelegate webView:didFinishNavigation:]):
4002         When the main page load is complete fetch the contents of the document to check if iframe was loaded
4003         (createPartition):
4004         Create a disk image and load the contents of the file.
4005         (cleanUp):
4006         (TestWebKitAPI::TEST):
4007
4008 2016-06-17  Enrique Ocaña González  <eocanha@igalia.com>
4009
4010         Unreviewed. Added myself to the list of committers.
4011
4012         * Scripts/webkitpy/common/config/contributors.json:
4013
4014 2016-06-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4015
4016         [EFL][GTK] LayoutTest doesn't run on Ubuntu 16.04
4017         https://bugs.webkit.org/show_bug.cgi?id=158141
4018
4019         Reviewed by Michael Catanzaro.
4020
4021         * Scripts/webkitpy/port/base.py: Detect php version in system, then use it.
4022         (Port._is_debian_php_version_7):
4023         (Port._debian_php_version):
4024         (Port._apache_config_file_name_for_platform):
4025         * efl/install-dependencies:
4026         * gtk/install-dependencies:
4027
4028 2016-06-16  Filip Pizlo  <fpizlo@apple.com>
4029
4030         Baseline JIT should be concurrent
4031         https://bugs.webkit.org/show_bug.cgi?id=158755
4032
4033         Reviewed by Geoffrey Garen.
4034         
4035         Need to disable concurrent JIT when running profiler tests. We should have been doing this
4036         all along.
4037
4038         * Scripts/run-jsc-stress-tests:
4039
4040 2016-06-16  Per Arne Vollan  <pvollan@apple.com>
4041
4042         [Win] Accessibility implementation unable to recurse through document (sometimes) to find named elements
4043         https://bugs.webkit.org/show_bug.cgi?id=140798
4044
4045         Reviewed by Brent Fulgham.
4046        
4047         Make sure layout is up-to-date before trying to find named elements. 
4048
4049         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4050         (AccessibilityController::rootElement):
4051
4052 2016-06-16  Chris Dumez  <cdumez@apple.com>
4053
4054         Unreviewed, rolling out r202002 and r202111.
4055
4056         Ryosuke says this was a JSBench regression on iOS
4057
4058         Reverted changesets:
4059
4060         "Make HashMap and HashSet work with Refs"
4061         https://bugs.webkit.org/show_bug.cgi?id=158638
4062         http://trac.webkit.org/changeset/202002
4063
4064         "Improve HashMap and HashSet support for Ref"
4065         https://bugs.webkit.org/show_bug.cgi?id=158789
4066         http://trac.webkit.org/changeset/202111
4067
4068 2016-06-15  Simon Fraser  <simon.fraser@apple.com>
4069
4070         [iOS WK2] On iPad, indirect focussing of a text field doesn't always scroll to the correct location
4071         https://bugs.webkit.org/show_bug.cgi?id=158828
4072
4073         Reviewed by Enrica Casucci.
4074         
4075         Expose "forceIPadStyleZoomOnInputFocus" on UIScriptController, which allows iPad-style
4076         zooming behavior on <input> focus in the iPhone simulator, which is used for testing.
4077
4078         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
4079         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
4080         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
4081         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
4082         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
4083         * WebKitTestRunner/ios/TestControllerIOS.mm:
4084         (WTR::TestController::platformResetStateToConsistentValues):
4085         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4086         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
4087         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
4088
4089 2016-06-15  Sam Weinig  <sam@webkit.org>
4090
4091         Forward/Back keyboard shortcuts need to flip for RTL
4092         https://bugs.webkit.org/show_bug.cgi?id=158823
4093         <rdar://problem/25975359>
4094
4095         Reviewed by Darin Adler.
4096
4097         Add tests for flipping the behavior of command-left and command-right
4098         under RTL mode.
4099
4100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4101         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Added.
4102         (-[CommandBackForwardOffscreenWindow isKeyWindow]):
4103         (-[CommandBackForwardOffscreenWindow isVisible]):
4104         (simulateCommandArrow):
4105         (WebKit2_CommandBackForwardTest::SetUp):
4106         (WebKit2_CommandBackForwardTestWKView::didFinishLoadForFrame):
4107         (WebKit2_CommandBackForwardTestWKView::SetUp):
4108         (WebKit2_CommandBackForwardTestWKView::loadFiles):
4109         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]):
4110         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
4111         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
4112
4113 2016-06-15  Tim Horton  <timothy_horton@apple.com>
4114
4115         Expose _shouldExpandContentToViewHeightForAutoLayout SPI on WKWebView
4116         https://bugs.webkit.org/show_bug.cgi?id=158824
4117         <rdar://problem/23713857>
4118
4119         Reviewed by Simon Fraser.
4120
4121         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
4122         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
4123         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
4124         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
4125         (TEST):
4126         Add a test for _shouldExpandContentToViewHeightForAutoLayout.
4127
4128 2016-06-13  Simon Fraser  <simon.fraser@apple.com>
4129
4130         [iOS WK2] Make it possible to test the Next/Previous buttons in the keyboard accessory bar
4131         https://bugs.webkit.org/show_bug.cgi?id=158714
4132
4133         Reviewed by Enrica Casucci.
4134
4135         Add UIScriptController.keyboardAccessoryBar{Next,Previous} and hook it up to the WKContentView
4136         method that gets called from UIKit.
4137
4138         Add a test that exercises it.
4139
4140         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
4141         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
4142         (WTR::UIScriptController::keyboardAccessoryBarNext):
4143         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
4144         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
4145         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4146         (WTR::UIScriptController::keyboardAccessoryBarNext):
4147         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
4148
4149 2016-06-15  Sam Weinig  <sam@webkit.org>
4150
4151         Improve HashMap and HashSet support for Ref
4152         https://bugs.webkit.org/show_bug.cgi?id=158789
4153
4154         Reviewed by Chris Dumez.
4155
4156         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4157         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4158         Add more cases to WTF_HashMap.Ref_Key, WTF_HashMap.Ref_Value and WTF_HashSet.Ref
4159
4160 2016-06-15  Aakash Jain  <aakash_jain@apple.com>
4161
4162         Too much log data generated during layout-tests on iOS Simulator
4163         https://bugs.webkit.org/show_bug.cgi?id=158751
4164
4165         Reviewed by Alexey Proskuryakov.
4166
4167         * Scripts/webkitpy/port/ios.py:
4168         (IOSSimulatorPort.developer_dir): memoized the property so that it is not called
4169         repeatedly.
4170
4171 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
4172
4173         [Win][CMake] Changes in WebKit options are not reflected in incremental builds.
4174         https://bugs.webkit.org/show_bug.cgi?id=158727
4175
4176         Reviewed by Alex Christensen.
4177
4178         Delete CMake cache file if WebKit options have been modified.
4179
4180         * Scripts/build-webkit:
4181         * Scripts/webkitdirs.pm:
4182         (shouldRemoveCMakeCache):
4183
4184 2016-06-15  Romain Bellessort  <romain.bellessort@crf.canon.fr>
4185
4186         Enabling Shadow DOM for all platforms
4187         https://bugs.webkit.org/show_bug.cgi?id=158738
4188
4189         Reviewed by Ryosuke Niwa.
4190
4191         Removed Shadow DOM from options (enabled by default)
4192
4193         * Scripts/webkitperl/FeatureList.pm:
4194         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4195
4196 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
4197
4198         [Win] The test accessibility/selected-text-range-aria-elements.html is failing.
4199         https://bugs.webkit.org/show_bug.cgi?id=158732
4200
4201         Reviewed by Brent Fulgham.
4202
4203         Implement selectedTextRange() method.
4204
4205         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4206         (AccessibilityUIElement::selectedTextRange):
4207
4208 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
4209
4210         [Win] MiniBrowser is not DPI aware.
4211         https://bugs.webkit.org/show_bug.cgi?id=158733
4212
4213         Reviewed by Brent Fulgham.
4214
4215         Call Win32 api function to let Windows know that we will scale the contents ourselves.
4216
4217         * MiniBrowser/win/WinMain.cpp:
4218         (wWinMain):
4219
4220 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
4221
4222         Unreviewed: add new email address to contributors.json.
4223
4224         * Scripts/webkitpy/common/config/contributors.json:
4225
4226 2016-06-14  Keith Miller  <keith_miller@apple.com>
4227
4228         JSBench should use geometric mean
4229         https://bugs.webkit.org/show_bug.cgi?id=158775
4230
4231         Reviewed by Mark Lam.
4232
4233         For some reason JSBench was using algebraic mean. Since each test
4234         is pretty substantially different it should use geometric mean
4235         instead.
4236
4237         * Scripts/run-jsc-benchmarks:
4238
4239 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
4240
4241         Debug crash logs are not fully symbolicated on Yosemite
4242         https://bugs.webkit.org/show_bug.cgi?id=158760
4243
4244         Reviewed by Darin Adler.
4245
4246         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Don't enable dSYM generation
4247         for debug builds on Yosemite.
4248
4249 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
4250
4251         Tests don't work in iOS Simulator when ASan is enabled
4252         https://bugs.webkit.org/show_bug.cgi?id=158726
4253
4254         Reviewed by David Kilzer.
4255
4256         * Scripts/webkitpy/port/driver.py:
4257         (Driver._setup_environ_for_driver): Added a FIXME.
4258         * Scripts/webkitpy/port/ios.py:
4259         (IOSSimulatorPort.setup_environ_for_server): Don't try to insert a dylib built for
4260         simulator into LayoutTestRelay, which is a macOS tool.
4261
4262 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
4263
4264         Continuous "Reentrancy avoided" error messages in run-webkit-tests if Simulator quits unexpectedly
4265         https://bugs.webkit.org/show_bug.cgi?id=158756
4266
4267         Reviewed by Alexey Proskuryakov.
4268
4269         * Scripts/webkitpy/xcode/simulator.py:
4270         (Simulator.wait_until_device_is_booted): If checking Simulator boot state fails, verify if
4271         the "simulator device" is still in booted state. Since we ensured that simulator device 
4272         was in booted state earlier in this method, this indicates that simulator device has shut down
4273         unexpectedly.
4274
4275 2016-06-14  David Kilzer  <ddkilzer@apple.com>
4276
4277         Follow-up fix #2: REGRESSION (r202020): El Capitan CMake Debug build broken
4278         <https://webkit.org/b/158743>
4279
4280         Unreviewed build fix.
4281
4282         * DumpRenderTree/PlatformMac.cmake: Fix silly typo.
4283
4284 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
4285
4286         Too much log data generated during layout-tests on iOS Simulator
4287         https://bugs.webkit.org/show_bug.cgi?id=158751
4288
4289         Reviewed by Alexey Proskuryakov.
4290
4291         * Scripts/webkitpy/port/ios.py: