[iOS] QuickLook documents loaded from file: URLs should be allowed to perform same...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-23  Andy Estes  <aestes@apple.com>
2
3         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
4         https://bugs.webkit.org/show_bug.cgi?id=196749
5         <rdar://problem/35773454>
6
7         Reviewed by Daniel Bates.
8
9         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
12         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
13         (-[QuickLookDelegate webView:didFinishNavigation:]):
14         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
15         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
16         (runTest):
17         (runTestDecideBeforeLoading):
18         (runTestDecideAfterLoading):
19         (TEST):
20
21 2019-04-23  John Wilander  <wilander@apple.com>
22
23         Remove Ad Click Attribution data when removing website data
24         https://bugs.webkit.org/show_bug.cgi?id=197215
25         <rdar://problem/47668988>
26
27         Reviewed by Chris Dumez.
28
29         This patch adds test infrastructure to delete Ad Click Attribution data
30         through WebsiteDataStore::removeData().
31
32         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
33         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
34         (WTR::TestRunner::clearAdClickAttribution):
35         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
36         * WebKitTestRunner/InjectedBundle/TestRunner.h:
37         * WebKitTestRunner/TestController.cpp:
38         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
39         * WebKitTestRunner/TestController.h:
40         * WebKitTestRunner/TestInvocation.cpp:
41         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
42
43 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
44
45         webkitpy: Kill unresponsive worker processes
46         https://bugs.webkit.org/show_bug.cgi?id=197205
47         <rdar://problem/50104388>
48
49         Reviewed by Lucas Forschler.
50
51         * Scripts/webkitpy/common/message_pool.py:
52         (_MessagePool.__init__): Add close timeout.
53         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
54
55 2019-04-23  Alex Christensen  <achristensen@webkit.org>
56
57         Add unit tests for WKWebView.serverTrust
58         https://bugs.webkit.org/show_bug.cgi?id=197202
59
60         Reviewed by Youenn Fablet
61
62         * TestWebKitAPI/TCPServer.cpp:
63         (TestWebKitAPI::deleter<BIO>::operator()):
64         (TestWebKitAPI::deleter<SSL>::operator()):
65         (TestWebKitAPI::deleter<X509>::operator()):
66         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
67         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
68         (TestWebKitAPI::TCPServer::TCPServer):
69         (TestWebKitAPI::TCPServer::listenForConnections):
70         * TestWebKitAPI/TCPServer.h:
71         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
72         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
73         (TestWebKitAPI::TEST):
74         (verifyCertificateAndPublicKey):
75         (-[ServerTrustDelegate webView:didFinishNavigation:]):
76         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
77         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
78         (TestWebKitAPI::downloadAtRate):
79         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
80         (TEST):
81         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
82         (TEST):
83
84 2019-04-23  Commit Queue  <commit-queue@webkit.org>
85
86         Unreviewed, rolling out r244556.
87         https://bugs.webkit.org/show_bug.cgi?id=197212
88
89         Causing build failures on multiple builders (Requested by
90         ShawnRoberts on #webkit).
91
92         Reverted changeset:
93
94         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
95         https://bugs.webkit.org/show_bug.cgi?id=197171
96         https://trac.webkit.org/changeset/244556
97
98 2019-04-23  Alex Christensen  <achristensen@webkit.org>
99
100         Fix iOS build.
101         https://bugs.webkit.org/show_bug.cgi?id=195537
102
103         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
104         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
105         AdoptWK constructor is private now.  Use adoptWK instead.
106
107 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
108
109         Accessibility text search and selection API enhancements.
110         https://bugs.webkit.org/show_bug.cgi?id=197095
111         <rdar://problem/48181791>
112
113         Reviewed by Chris Fleizach.
114
115         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
116
117         * DumpRenderTree/AccessibilityTextMarker.h:
118         * DumpRenderTree/AccessibilityUIElement.cpp:
119         (searchTextWithCriteriaCallback):
120         (AccessibilityUIElement::getJSClass):
121         * DumpRenderTree/AccessibilityUIElement.h:
122         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
123         (convertVectorToObjectArray):
124         (convertNSArrayToVector):
125         (searchTextParameterizedAttributeForCriteria):
126         (AccessibilityUIElement::getLinkedUIElements):
127         (AccessibilityUIElement::getDocumentLinks):
128         (AccessibilityUIElement::getChildren):
129         (AccessibilityUIElement::getChildrenWithRange):
130         (AccessibilityUIElement::rowHeaders const):
131         (AccessibilityUIElement::columnHeaders const):
132         (AccessibilityUIElement::uiElementArrayAttributeValue const):
133         (AccessibilityUIElement::searchTextWithCriteria):
134         (AccessibilityUIElement::attributesOfColumnHeaders):
135         (AccessibilityUIElement::attributesOfRowHeaders):
136         (AccessibilityUIElement::attributesOfColumns):
137         (AccessibilityUIElement::attributesOfRows):
138         (AccessibilityUIElement::attributesOfVisibleCells):
139         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
140         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
141         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
142         (WTR::convertVectorToObjectArray):
143         (WTR::convertNSArrayToVector):
144         (WTR::searchTextParameterizedAttributeForCriteria):
145         (WTR::AccessibilityUIElement::getLinkedUIElements):
146         (WTR::AccessibilityUIElement::getDocumentLinks):
147         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
148         (WTR::AccessibilityUIElement::getChildren):
149         (WTR::AccessibilityUIElement::getChildrenWithRange):
150         (WTR::AccessibilityUIElement::rowHeaders const):
151         (WTR::AccessibilityUIElement::columnHeaders const):
152         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
153         (WTR::AccessibilityUIElement::searchTextWithCriteria):
154         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
155         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
156         (WTR::AccessibilityUIElement::attributesOfColumns):
157         (WTR::AccessibilityUIElement::attributesOfRows):
158         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
159         (WTR::convertElementsToObjectArray): Deleted.
160
161 2019-04-23  Guy Lewin  <guy@lewin.co.il>
162
163         Multiple File Input Icon Set Regardless of File List
164         https://bugs.webkit.org/show_bug.cgi?id=195537
165
166         Reviewed by Alexey Proskuryakov.
167
168         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
169         display string in iOS file inputs
170
171         * DumpRenderTree/TestRunner.cpp:
172         (SetOpenPanelFilesMediaIconCallback):
173         (TestRunner::staticFunctions):
174         (TestRunner::setOpenPanelFilesMediaIcon):
175         * DumpRenderTree/TestRunner.h:
176         (TestRunner::openPanelFilesMediaIcon const):
177         * DumpRenderTree/mac/UIDelegate.mm:
178         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
179         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
180         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
181         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
182         * WebKitTestRunner/InjectedBundle/TestRunner.h:
183         * WebKitTestRunner/TestController.cpp:
184         (WTR::runOpenPanel):
185         (WTR::TestController::resetStateToConsistentValues):
186         * WebKitTestRunner/TestController.h:
187         (WTR::TestController::openPanelFileURLsMediaIcon const):
188         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
189         * WebKitTestRunner/TestInvocation.cpp:
190         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
191
192 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
193
194         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
195         https://bugs.webkit.org/show_bug.cgi?id=197171
196         <rdar://problem/47454979>
197
198         Reviewed by Youenn Fablet.
199
200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
201         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
202         (TestWebKitAPI::TEST):
203
204 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
205
206         [ews-build] Add unit tests for UnApplyPatchIfRequired
207         https://bugs.webkit.org/show_bug.cgi?id=197197
208
209         Reviewed by Lucas Forschler.
210
211         * BuildSlaveSupport/ews-build/steps_unittest.py:
212         (TestUnApplyPatchIfRequired):
213         (TestUnApplyPatchIfRequired.test_success):
214         (TestUnApplyPatchIfRequired.test_failure):
215         (TestUnApplyPatchIfRequired.test_skip):
216
217 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
218
219         [ews-build] Add unit tests for CleanWorkingDirectory
220         https://bugs.webkit.org/show_bug.cgi?id=197195
221
222         Reviewed by Lucas Forschler.
223
224         * BuildSlaveSupport/ews-build/steps_unittest.py:
225         (TestCleanWorkingDirectory):
226         (TestCleanWorkingDirectory.test_success):
227         (TestCleanWorkingDirectory.test_failure):
228
229 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
230
231         [ews-build] Use explicit imports instead of wildcard imports
232         https://bugs.webkit.org/show_bug.cgi?id=197194
233
234         Reviewed by Lucas Forschler.
235
236         * BuildSlaveSupport/ews-build/factories.py:
237         * BuildSlaveSupport/ews-build/loadConfig.py:
238         * BuildSlaveSupport/ews-build/steps_unittest.py:
239
240 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
241
242         [ews-build] Add unit tests for DownloadBuiltProduct
243         https://bugs.webkit.org/show_bug.cgi?id=197193
244
245         Reviewed by Lucas Forschler.
246
247         * BuildSlaveSupport/ews-build/steps_unittest.py:
248         (TestDownloadBuiltProduct):
249         (TestDownloadBuiltProduct.setUp):
250         (TestDownloadBuiltProduct.tearDown):
251         (TestDownloadBuiltProduct.test_success):
252         (TestDownloadBuiltProduct.test_failure):
253
254 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
255
256         [ews-app] Exception while loading status-bubble when no build step has started
257         https://bugs.webkit.org/show_bug.cgi?id=196676
258
259         Reviewed by Lucas Forschler.
260
261         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
262         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
263
264 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
265
266         [PlayStation] Support running of JSC tests on remote playstation devices
267         https://bugs.webkit.org/show_bug.cgi?id=197170
268
269         Reviewed by Ross Kirsling.
270
271         Script changes
272
273         * Scripts/run-javascriptcore-tests:
274         (runJSCStressTests): Pass arguments for playstation to
275         run-jsc-stress-tests
276         * Scripts/run-jsc-stress-tests:
277         Handle $hostOS=="playstation" for determineArchitecture, turning
278         off $isFTLPlatform and runProfiler and defaulting test writer.
279         * Scripts/webkitdirs.pm:
280         (jscPath): PlayStation WebKit executables have .elf extension
281         (executableProductDir): PlayStation builds on Windows hosts but
282         uses bin directory rather than bin64/bin32 for executable output
283         location.
284         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
285
286 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
287
288         [CMake][Win] Use target oriented design for WebKit
289         https://bugs.webkit.org/show_bug.cgi?id=197173
290
291         Reviewed by Alex Christensen.
292
293         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
294         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
295
296 2019-04-23  Chris Dumez  <cdumez@apple.com>
297
298         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
299         https://bugs.webkit.org/show_bug.cgi?id=197097
300         <rdar://problem/50048318>
301
302         Reviewed by Alex Christensen.
303
304         Add API test coverage.
305
306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
307         (-[PSONScheme webView:startURLSchemeTask:]):
308
309 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
310
311         [ATK] Implement AtkComponentIface scroll_to methods
312         https://bugs.webkit.org/show_bug.cgi?id=196856
313
314         Reviewed by Michael Catanzaro.
315
316         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
317         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
318         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
319         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
320
321 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
322
323         [ews-build] Improve summary for UploadBuiltProduct step
324         https://bugs.webkit.org/show_bug.cgi?id=197182
325
326         Reviewed by Lucas Forschler.
327
328         * BuildSlaveSupport/ews-build/steps.py:
329         (UploadBuiltProduct): Added descriptionDone.
330         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
331         * BuildSlaveSupport/ews-build/steps_unittest.py:
332         (TestUploadBuiltProduct.test_success): Updated unit-test.
333         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
334
335 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
336
337         [ews-build] Trigger queues only after uploading the archive
338         https://bugs.webkit.org/show_bug.cgi?id=197180
339
340         Reviewed by Lucas Forschler.
341
342         * BuildSlaveSupport/ews-build/factories.py:
343         (Factory.__init__):
344         (BuildFactory.__init__): Remove trigger step from factories.
345         (BuildFactory.propertiesToPassToTriggers): Deleted.
346         * BuildSlaveSupport/ews-build/steps.py:
347         (ConfigureBuild.__init__): Confiure triggers property.
348         (Trigger): Step to trigger other queues.
349         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
350         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
351
352 2019-04-22  Alex Christensen  <achristensen@webkit.org>
353
354         Deprecate WKContextCreateWithInjectedBundlePath
355         https://bugs.webkit.org/show_bug.cgi?id=197169
356
357         Reviewed by Youenn Fablet.
358
359         * TestWebKitAPI/PlatformUtilities.cpp:
360         (TestWebKitAPI::Util::createContextWithInjectedBundle):
361         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
362
363 2019-04-22  Alex Christensen  <achristensen@webkit.org>
364
365         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
366         https://bugs.webkit.org/show_bug.cgi?id=197093
367         <rdar://problem/49708268>
368
369         Reviewed by Chris Dumez.
370
371         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
372         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
373         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
374         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
375         and one for loads without credentials, so there are two TCP connections to the same server in this test.
376
377         * TestWebKitAPI/TCPServer.cpp:
378         (TestWebKitAPI::TCPServer::TCPServer):
379         (TestWebKitAPI::TCPServer::~TCPServer):
380         (TestWebKitAPI::TCPServer::socketBindListen):
381         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
382         * TestWebKitAPI/TCPServer.h:
383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
384         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
385         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
386         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
387         (respondWithChallengeThenOK):
388         (TestWebKitAPI::TEST):
389         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
390         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
391         (TEST):
392
393 2019-04-22  Chris Dumez  <cdumez@apple.com>
394
395         Delayed WebProcessLaunch may break the _relatedWebView SPI
396         https://bugs.webkit.org/show_bug.cgi?id=197160
397
398         Reviewed by Alex Christensen.
399
400         Add API test coverage.
401
402         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
403
404 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
405
406         Use curl to download packages for webkitpy autoinstaller
407         https://bugs.webkit.org/show_bug.cgi?id=197164
408
409         Reviewed by Darin Adler.
410
411         * Scripts/webkitpy/common/system/autoinstall.py:
412         (AutoInstaller._download): Use curl(1) to download packages necessary for
413         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
414         errors which are not present when using curl(1).
415
416 2019-04-22  Chris Dumez  <cdumez@apple.com>
417
418         Unreviewed, rolling out r244502.
419
420         Caused crashes on the bots
421
422         Reverted changeset:
423
424         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
425         https://bugs.webkit.org/show_bug.cgi?id=197160
426         https://trac.webkit.org/changeset/244502
427
428 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
429
430         Unreviewed, rolling out r244437.
431
432         Still breaks internal tests.
433
434         Reverted changeset:
435
436         "InjectedBundle parameters often need initialization function
437         called before unarchiving"
438         https://bugs.webkit.org/show_bug.cgi?id=189709
439         https://trac.webkit.org/changeset/244437
440
441 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
442
443         [ews-build] Use singular verb in failure description in case of single api test failure
444         https://bugs.webkit.org/show_bug.cgi?id=197013
445
446         Reviewed by Lucas Forschler.
447
448         * BuildSlaveSupport/ews-build/steps.py:
449         (AnalyzeAPITestsResults.analyzeResults):
450
451 2019-04-22  Chris Dumez  <cdumez@apple.com>
452
453         Delayed WebProcessLaunch may break the _relatedWebView SPI
454         https://bugs.webkit.org/show_bug.cgi?id=197160
455
456         Reviewed by Alex Christensen.
457
458         Add API test coverage.
459
460         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
461
462 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
463
464         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
465         https://bugs.webkit.org/show_bug.cgi?id=194630
466
467         Reviewed by Michael Catanzaro.
468
469         Return early from getAttributeSet() is passed in accessible is nullptr.
470
471         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
472
473 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
474
475         Defer EditorState updates until the next layer tree flush in a few additional circumstances
476         https://bugs.webkit.org/show_bug.cgi?id=197145
477         <rdar://problem/50078170>
478
479         Reviewed by Darin Adler.
480
481         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
482         focus, or showing the font manager.
483
484         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
485         (TestWebKitAPI::TEST):
486         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
487         (TEST):
488         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
489         (TestWebKitAPI::TEST):
490
491 2019-04-21  Brian Burg  <bburg@apple.com>
492
493         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
494         https://bugs.webkit.org/show_bug.cgi?id=197125
495         <rdar://problem/50061468>
496
497         Reviewed by Darin Adler.
498
499         Sometimes I want to run wptserve independently of tests. Make it easier to script that
500         using this class rather than making our own ./wpt serve invocation.
501
502         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
503         (WebDriverW3CWebServer):
504         (WebDriverW3CWebServer.document_root): Expose this to clients.
505         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
506
507         (WebDriverW3CWebServer.__enter__):
508         (WebDriverW3CWebServer.__exit__):
509         Make it possible to use the web server with a 'with' statement.
510
511 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
512
513         [CMake][Win] Use target oriented design for WebKitLegacy
514         https://bugs.webkit.org/show_bug.cgi?id=197112
515
516         Reviewed by Konstantin Tokarev.
517
518         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
519
520         * DumpRenderTree/CMakeLists.txt:
521         * DumpRenderTree/PlatformWin.cmake:
522         * DumpRenderTree/win/EventSender.cpp:
523
524 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
525
526         Update text for old EWS submit button
527         https://bugs.webkit.org/show_bug.cgi?id=197140
528
529         Reviewed by Alexey Proskuryakov.
530
531         * QueueStatusServer/templates/statusbubble.html:
532
533 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
534
535         [ews-app] New EWS should poll bugzilla more frequently
536         https://bugs.webkit.org/show_bug.cgi?id=197138
537
538         Reviewed by Alexey Proskuryakov.
539
540         * BuildSlaveSupport/ews-app/ews/fetcher.py:
541         (FetchLoop.__init__):
542
543 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
544
545         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
546         https://bugs.webkit.org/show_bug.cgi?id=197139
547
548         Reviewed by Alexey Proskuryakov.
549
550         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
551         * QueueStatusServer/templates/statusbubble.html:
552
553 2019-04-20  Chris Dumez  <cdumez@apple.com>
554
555         Unreviewed, fix iOS build with recent SDKs.
556
557         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
558
559 2019-04-19  Keith Miller  <keith_miller@apple.com>
560
561         Add script to merge run_benchmark jsons
562         https://bugs.webkit.org/show_bug.cgi?id=197107
563
564         Reviewed by Michael Saboff.
565
566         The script basically recursively decends through all json objects until it gets
567         to an array or JSON primitive and concats or takes the first value, respectively.
568
569         This patch also adds +x bits to the compare-results script so it
570         can be run directly from the command line. I had to add a new line so that svn
571         will accept the change... yay svn!
572
573         * Scripts/compare-results:
574         * Scripts/merge-result-jsons: Added.
575         (readJSONFile):
576         (deepAppend):
577         (mergeJSONs):
578         (main):
579
580 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
581
582         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
583         https://bugs.webkit.org/show_bug.cgi?id=197079
584
585         Reviewed by Darin Adler.
586
587         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
588
589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
590         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
591
592 2019-04-18  Commit Queue  <commit-queue@webkit.org>
593
594         Unreviewed, rolling out r244434.
595         https://bugs.webkit.org/show_bug.cgi?id=197089
596
597         caused 1 API test failure (Requested by zalan on #webkit).
598
599         Reverted changeset:
600
601         "Regression (r244291): Broken API Test
602         AutoLayoutRenderingProgressRelativeOrdering"
603         https://bugs.webkit.org/show_bug.cgi?id=196948
604         https://trac.webkit.org/changeset/244434
605
606 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
607
608         Add new compatibility mode API on WKNavigation
609         https://bugs.webkit.org/show_bug.cgi?id=197069
610         <rdar://problem/50025800>
611
612         Reviewed by Tim Horton.
613
614         Add a block property for -didCommitNavigation to TestNavigationDelegate.
615
616         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
617         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
618         (-[TestNavigationDelegate webView:didCommitNavigation:]):
619
620 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
621
622         [CMake] Make WebCore headers copies
623         https://bugs.webkit.org/show_bug.cgi?id=182512
624         <rdar://problem/37510435>
625
626         Reviewed by Alex Christensen.
627
628         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
629         ports.
630
631         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
632         of WebCore headers using "*.h" were modified to <WebCore/*.h>
633
634         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
635         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
636         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
637         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
638         * TestWebKitAPI/CMakeLists.txt:
639         * TestWebKitAPI/PlatformWin.cmake:
640         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
641         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
642         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
643
644 2019-04-18  Jer Noble  <jer.noble@apple.com>
645
646         Add support for parsing FairPlayStreaming PSSH boxes.
647         https://bugs.webkit.org/show_bug.cgi?id=197064
648
649         Reviewed by Eric Carlson.
650
651         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
652         (TestWebKitAPI::TEST):
653
654 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
655
656         InjectedBundle parameters often need initialization function called before unarchiving
657         https://bugs.webkit.org/show_bug.cgi?id=189709
658         <rdar://problem/44573653>
659
660         Reviewed by Ryosuke Niwa.
661
662         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
663         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
664
665 2019-04-18  Zalan Bujtas  <zalan@apple.com>
666
667         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
668         https://bugs.webkit.org/show_bug.cgi?id=196948
669         <rdar://problem/49927131>
670
671         Reviewed by Tim Horton.
672
673         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
674         (TEST): 
675         The expected order of incoming events is
676         1. didInvalidateIntrinsicContentSize
677         2. didFirstLayout
678         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
679         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
680         (and remember, all we care about is ordering).
681
682 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
683
684         Unreviewed, rolling out r244299.
685
686         Breaks internal tests.
687
688         Reverted changeset:
689
690         "InjectedBundle parameters often need initialization function
691         called before unarchiving"
692         https://bugs.webkit.org/show_bug.cgi?id=189709
693         https://trac.webkit.org/changeset/244299
694
695 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
696
697         [WTF] StringBuilder should set correct m_is8Bit flag when merging
698         https://bugs.webkit.org/show_bug.cgi?id=197053
699
700         Reviewed by Saam Barati.
701
702         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
703         (TestWebKitAPI::TEST):
704
705 2019-04-17  Tim Horton  <timothy_horton@apple.com>
706
707         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
708         https://bugs.webkit.org/show_bug.cgi?id=197028
709         <rdar://problem/49985290>
710
711         Reviewed by Wenson Hsieh.
712
713         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
714         (TEST):
715         Liberal application of waitForNextPresentationUpdate works around a race
716         where if the page rapidly changes its viewport arguments (or an API client
717         rapidly changes its viewport arguments), we'd get stuck thinking that the
718         user had intentionally zoomed the page, and stop resetting the initial scale.
719         This deserves a separate bug, but no need to keep the test failing while
720         we think about it.
721
722 2019-04-17  Tim Horton  <timothy_horton@apple.com>
723
724         REGRESSION (r241988): Switching tabs is slow
725         https://bugs.webkit.org/show_bug.cgi?id=197037
726         <rdar://problem/49951473>
727
728         Reviewed by Simon Fraser.
729
730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
731         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
732         (TEST):
733         * TestWebKitAPI/cocoa/TestWKWebView.h:
734         * TestWebKitAPI/cocoa/TestWKWebView.mm:
735         (-[TestWKWebView addToTestWindow]):
736         Add a test that hangs without this fix.
737
738 2019-04-17  Truitt Savell  <tsavell@apple.com>
739
740         Unreviewed, rolling out r244400.
741
742         Caused testing to exit early with assertionon Debug WK2
743
744         Reverted changeset:
745
746         "UI↔Web deadlock when printing with a JavaScript alert
747         visible"
748         https://bugs.webkit.org/show_bug.cgi?id=196839
749         https://trac.webkit.org/changeset/244400
750
751 2019-04-17  Brady Eidson  <beidson@apple.com>
752
753         Link clicks in PDFs shouldn't send referrer headers.
754         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
755
756         Reviewed by Tim Horton.
757
758         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
759         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
760         (putPDFBytesCallback):
761         (emptyReleaseInfoCallback):
762         (createPDFWithLinkToURL):
763         (TEST):
764
765 2019-04-17  Tim Horton  <timothy_horton@apple.com>
766
767         UI↔Web deadlock when printing with a JavaScript alert visible
768         https://bugs.webkit.org/show_bug.cgi?id=196839
769         <rdar://problem/49157642>
770
771         Reviewed by Andy Estes.
772
773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
774         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
775         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
776         (TEST):
777
778 2019-04-17  Alex Christensen  <achristensen@webkit.org>
779
780         WKRetainPtr's adoption constructor should be private
781         https://bugs.webkit.org/show_bug.cgi?id=197019
782
783         Reviewed by Tim Horton.
784
785         * DumpRenderTree/mac/DumpRenderTree.mm:
786         (dumpFramesAsText):
787         * TestWebKitAPI/InjectedBundleController.cpp:
788         (TestWebKitAPI::InjectedBundleController::initialize):
789         * TestWebKitAPI/PlatformUtilities.cpp:
790         (TestWebKitAPI::Util::createContextWithInjectedBundle):
791         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
792         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
793         (TestWebKitAPI::Util::toWK):
794         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
795         (TestWebKitAPI::TEST):
796         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
797         (TestWebKitAPI::TEST):
798         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
799         (TestWebKitAPI::TEST):
800         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
801         (TestWebKitAPI::TEST):
802         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
803         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
804         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
805         (TestWebKitAPI::TEST):
806         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
807         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
808         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
809         (TestWebKitAPI::TEST):
810         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
811         (TestWebKitAPI::TEST):
812         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
813         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
814         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
815         (TestWebKitAPI::TEST):
816         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
817         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
818         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
819         (TestWebKitAPI::TEST):
820         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
821         (TestWebKitAPI::TEST):
822         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
823         (TestWebKitAPI::TEST):
824         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
825         (TestWebKitAPI::TEST):
826         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
827         (TestWebKitAPI::TEST):
828         * TestWebKitAPI/Tests/WebKit/Find.cpp:
829         (TestWebKitAPI::TEST):
830         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
831         (TestWebKitAPI::TEST):
832         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
833         (TestWebKitAPI::TEST):
834         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
835         (TestWebKitAPI::TEST):
836         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
837         (TestWebKitAPI::TEST):
838         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
839         (TestWebKitAPI::TEST):
840         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
841         (TestWebKitAPI::TEST):
842         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
843         (TestWebKitAPI::TEST):
844         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
845         (TestWebKitAPI::TEST):
846         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
847         (TestWebKitAPI::TEST):
848         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
849         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
850         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
851         (TestWebKitAPI::TEST):
852         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
853         (TestWebKitAPI::TEST):
854         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
855         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
856         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
857         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
858         (TestWebKitAPI::TEST):
859         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
860         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
861         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
862         (TestWebKitAPI::TEST):
863         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
864         (TestWebKitAPI::TEST):
865         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
866         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
867         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
868         (TestWebKitAPI::TEST):
869         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
870         (TestWebKitAPI::loadAlternateHTMLString):
871         (TestWebKitAPI::TEST):
872         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
873         (TestWebKitAPI::TEST):
874         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
875         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
876         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
877         (TestWebKitAPI::buildAndPerformTest):
878         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
879         (TestWebKitAPI::TEST):
880         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
881         (TestWebKitAPI::TEST):
882         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
883         (TestWebKitAPI::TEST):
884         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
885         (TestWebKitAPI::TEST):
886         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
887         (TestWebKitAPI::TEST):
888         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
889         (TestWebKitAPI::TEST):
890         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
891         (TestWebKitAPI::TEST):
892         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
893         (TestWebKitAPI::TEST):
894         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
895         (TestWebKitAPI::TEST):
896         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
897         (TestWebKitAPI::TEST):
898         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
899         (TestWebKitAPI::TEST):
900         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
901         (TestWebKitAPI::TEST):
902         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
903         (TestWebKitAPI::TEST):
904         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
905         (TestWebKitAPI::TEST):
906         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
907         (TestWebKitAPI::TEST):
908         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
909         (TestWebKitAPI::TEST):
910         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
911         (TestWebKitAPI::TEST):
912         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
913         (TestWebKitAPI::TEST):
914         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
915         (TestWebKitAPI::TEST):
916         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
917         (TestWebKitAPI::TEST):
918         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
919         (TestWebKitAPI::TEST):
920         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
921         (TestWebKitAPI::TEST):
922         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
923         (TestWebKitAPI::TEST):
924         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
925         (TestWebKitAPI::TEST):
926         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
927         (TestWebKitAPI::TEST):
928         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
929         (TestWebKitAPI::TEST):
930         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
931         (TestWebKitAPI::TEST):
932         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
933         (TestWebKitAPI::TEST):
934         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
935         (TestWebKitAPI::TEST):
936         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
937         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
938         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
939         (TestWebKitAPI::TEST):
940         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
941         (TestWebKitAPI::TEST):
942         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
943         (TestWebKitAPI::TEST):
944         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
945         (TestWebKitAPI::TEST):
946         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
947         (TestWebKitAPI::TEST):
948         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
949         (TestWebKitAPI::TEST):
950         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
951         (TestWebKitAPI::TEST):
952         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
953         (TestWebKitAPI::TEST):
954         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
955         (TestWebKitAPI::TEST):
956         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
957         (TestWebKitAPI::TEST):
958         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
959         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
960         (TEST):
961         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
962         (TEST):
963         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
964         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
965         (TEST):
966         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
967         (TestWebKitAPI::TEST):
968         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
969         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
970         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
971         (WTR::getMenuItemTitleCallback):
972         (WTR::createMouseMessageBody):
973         (WTR::EventSendingController::mouseDown):
974         (WTR::EventSendingController::mouseUp):
975         (WTR::EventSendingController::mouseMoveTo):
976         (WTR::EventSendingController::mouseForceClick):
977         (WTR::EventSendingController::startAndCancelMouseForceClick):
978         (WTR::EventSendingController::mouseForceDown):
979         (WTR::EventSendingController::mouseForceUp):
980         (WTR::EventSendingController::mouseForceChanged):
981         (WTR::EventSendingController::leapForward):
982         (WTR::EventSendingController::scheduleAsynchronousClick):
983         (WTR::createKeyDownMessageBody):
984         (WTR::EventSendingController::keyDown):
985         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
986         (WTR::EventSendingController::mouseScrollBy):
987         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
988         (WTR::EventSendingController::continuousMouseScrollBy):
989         (WTR::EventSendingController::addTouchPoint):
990         (WTR::EventSendingController::updateTouchPoint):
991         (WTR::EventSendingController::setTouchModifier):
992         (WTR::EventSendingController::setTouchPointRadius):
993         (WTR::EventSendingController::touchStart):
994         (WTR::EventSendingController::touchMove):
995         (WTR::EventSendingController::touchEnd):
996         (WTR::EventSendingController::touchCancel):
997         (WTR::EventSendingController::clearTouchPoints):
998         (WTR::EventSendingController::releaseTouchPoint):
999         (WTR::EventSendingController::cancelTouchPoint):
1000         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1001         (WTR::InjectedBundle::didCreatePage):
1002         (WTR::InjectedBundle::didReceiveMessage):
1003         (WTR::InjectedBundle::didReceiveMessageToPage):
1004         (WTR::InjectedBundle::booleanForKey):
1005         (WTR::InjectedBundle::done):
1006         (WTR::InjectedBundle::dumpToStdErr):
1007         (WTR::InjectedBundle::outputText):
1008         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1009         (WTR::InjectedBundle::postAddChromeInputField):
1010         (WTR::InjectedBundle::postRemoveChromeInputField):
1011         (WTR::InjectedBundle::postFocusWebView):
1012         (WTR::InjectedBundle::postSetBackingScaleFactor):
1013         (WTR::InjectedBundle::postSetWindowIsKey):
1014         (WTR::InjectedBundle::postSetViewSize):
1015         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1016         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1017         (WTR::InjectedBundle::setGeolocationPermission):
1018         (WTR::InjectedBundle::setMockGeolocationPosition):
1019         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1020         (WTR::InjectedBundle::isGeolocationProviderActive const):
1021         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1022         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1023         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1024         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1025         (WTR::InjectedBundle::setCustomPolicyDelegate):
1026         (WTR::InjectedBundle::setHidden):
1027         (WTR::InjectedBundle::setCacheModel):
1028         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1029         (WTR::InjectedBundle::processWorkQueue):
1030         (WTR::InjectedBundle::queueBackNavigation):
1031         (WTR::InjectedBundle::queueForwardNavigation):
1032         (WTR::InjectedBundle::queueLoad):
1033         (WTR::InjectedBundle::queueLoadHTMLString):
1034         (WTR::InjectedBundle::queueReload):
1035         (WTR::InjectedBundle::queueLoadingScript):
1036         (WTR::InjectedBundle::queueNonLoadingScript):
1037         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1038         (WTR::frameToStr):
1039         (WTR::InjectedBundlePage::InjectedBundlePage):
1040         (WTR::dumpFrameDescriptionSuitableForTestResult):
1041         (WTR::dumpFrameScrollPosition):
1042         (WTR::dumpDescendantFrameScrollPositions):
1043         (WTR::dumpFrameText):
1044         (WTR::dumpDescendantFramesText):
1045         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1046         (WTR::TestRunner::shouldDumpPixels const):
1047         (WTR::TestRunner::setDumpPixels):
1048         (WTR::TestRunner::whatToDump const):
1049         (WTR::TestRunner::setWhatToDump):
1050         (WTR::TestRunner::setWaitUntilDone):
1051         (WTR::TestRunner::shouldWaitUntilDone const):
1052         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1053         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1054         (WTR::TestRunner::clearAllDatabases):
1055         (WTR::TestRunner::setIDBPerOriginQuota):
1056         (WTR::TestRunner::originsWithApplicationCache):
1057         (WTR::TestRunner::setCanOpenWindows):
1058         (WTR::TestRunner::setXSSAuditorEnabled):
1059         (WTR::TestRunner::setMediaDevicesEnabled):
1060         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1061         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1062         (WTR::TestRunner::setCustomUserAgent):
1063         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1064         (WTR::TestRunner::setModernMediaControlsEnabled):
1065         (WTR::TestRunner::setWebGL2Enabled):
1066         (WTR::TestRunner::setWritableStreamAPIEnabled):
1067         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1068         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1069         (WTR::TestRunner::setAllowsAnySSLCertificate):
1070         (WTR::TestRunner::setPluginsEnabled):
1071         (WTR::TestRunner::setValueForUser):
1072         (WTR::TestRunner::setAudioResult):
1073         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1074         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1075         (WTR::TestRunner::setAlwaysAcceptCookies):
1076         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1077         (WTR::TestRunner::isDoingMediaCapture const):
1078         (WTR::TestRunner::queueLoad):
1079         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1080         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1081         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1082         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1083         (WTR::TestRunner::setAuthenticationUsername):
1084         (WTR::TestRunner::setAuthenticationPassword):
1085         (WTR::TestRunner::secureEventInputIsEnabled const):
1086         (WTR::TestRunner::setBlockAllPlugins):
1087         (WTR::TestRunner::setPluginSupportedMode):
1088         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1089         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1090         (WTR::TestRunner::setNavigationGesturesEnabled):
1091         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1092         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1093         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1094         (WTR::TestRunner::terminateNetworkProcess):
1095         (WTR::TestRunner::terminateServiceWorkerProcess):
1096         (WTR::TestRunner::runUIScript):
1097         (WTR::TestRunner::setStatisticsDebugMode):
1098         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1099         (WTR::TestRunner::setStatisticsLastSeen):
1100         (WTR::TestRunner::setStatisticsPrevalentResource):
1101         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1102         (WTR::TestRunner::dumpResourceLoadStatistics):
1103         (WTR::TestRunner::isStatisticsPrevalentResource):
1104         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1105         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1106         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1107         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1108         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1109         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1110         (WTR::TestRunner::setStatisticsGrandfathered):
1111         (WTR::TestRunner::isStatisticsGrandfathered):
1112         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1113         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1114         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1115         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1116         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1117         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1118         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1119         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1120         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1121         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1122         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1123         (WTR::TestRunner::statisticsSubmitTelemetry):
1124         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1125         (WTR::TestRunner::setStatisticsIsRunningTest):
1126         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1127         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1128         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1129         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1130         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1131         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1132         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1133         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1134         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1135         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1136         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1137         (WTR::TestRunner::statisticsResetToConsistentState):
1138         (WTR::TestRunner::setStorageAccessAPIEnabled):
1139         (WTR::TestRunner::getAllStorageAccessEntries):
1140         (WTR::TestRunner::addMockMediaDevice):
1141         (WTR::TestRunner::clearMockMediaDevices):
1142         (WTR::TestRunner::removeMockMediaDevice):
1143         (WTR::TestRunner::resetMockMediaDevices):
1144         (WTR::TestRunner::connectMockGamepad):
1145         (WTR::TestRunner::disconnectMockGamepad):
1146         (WTR::TestRunner::setMockGamepadDetails):
1147         (WTR::TestRunner::setMockGamepadAxisValue):
1148         (WTR::TestRunner::setMockGamepadButtonValue):
1149         (WTR::TestRunner::removeAllSessionCredentials):
1150         (WTR::TestRunner::clearDOMCache):
1151         (WTR::TestRunner::clearDOMCaches):
1152         (WTR::TestRunner::hasDOMCache):
1153         (WTR::TestRunner::domCacheSize):
1154         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1155         (WTR::TestRunner::getApplicationManifestThen):
1156         (WTR::TestRunner::injectUserScript):
1157         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1158         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1159         (WTR::TestRunner::addTestKeyToKeychain):
1160         (WTR::TestRunner::cleanUpKeychain):
1161         (WTR::TestRunner::keyExistsInKeychain):
1162         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1163         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1164         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1165         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1166         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1167         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1168         * WebKitTestRunner/TestController.cpp:
1169         (WTR::TestController::initialize):
1170         (WTR::parseStringTestHeaderValueAsRelativePath):
1171         (WTR::updateTestOptionsFromTestHeader):
1172         (WTR::TestController::runTest):
1173         (WTR::TestController::didReceiveLiveDocumentsList):
1174         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1175         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1176         (WTR::TestController::didFinishNavigation):
1177         (WTR::TestController::didReceiveAuthenticationChallenge):
1178         * WebKitTestRunner/TestInvocation.cpp:
1179         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1180         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1181         (WTR::TestInvocation::uiScriptDidComplete):
1182         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1183         * WebKitTestRunner/WebNotificationProvider.cpp:
1184         (WTR::WebNotificationProvider::closeWebNotification):
1185         * WebKitTestRunner/WorkQueueManager.cpp:
1186         (WTR::ScriptItem::ScriptItem):
1187         (WTR::WorkQueueManager::queueLoad):
1188         (WTR::WorkQueueManager::queueLoadHTMLString):
1189
1190 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1191
1192         Add a comment to make my test from r244139 less mysterious.
1193         https://bugs.webkit.org/show_bug.cgi?id=196744
1194
1195         As suggested by Darin Adler.
1196
1197         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1198         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1199
1200 2019-04-17  Chris Dumez  <cdumez@apple.com>
1201
1202         Remember device orientation permission for the duration of the browsing session
1203         https://bugs.webkit.org/show_bug.cgi?id=196992
1204         <rdar://problem/49946067>
1205
1206         Reviewed by Alex Christensen.
1207
1208         Add API test coverage.
1209
1210         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1211         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1212         (TEST):
1213
1214 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1215
1216         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1217         https://bugs.webkit.org/show_bug.cgi?id=196675
1218
1219         Reviewed by Lucas Forschler.
1220
1221         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1222         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
1223
1224 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1225
1226         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
1227         https://bugs.webkit.org/show_bug.cgi?id=196919
1228         <rdar://problem/41630459>
1229
1230         Reviewed by Tim Horton.
1231
1232         Add iOS support for several new testing hooks. See below for more detail.
1233
1234         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1235         (WTR::UIScriptController::isDismissingMenu const):
1236
1237         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
1238         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
1239         by UIKit when dismissing the callout bar (i.e. UIMenuController).
1240
1241         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1242         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1243         (WTR::UIScriptController::isDismissingMenu const):
1244         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1245         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1246         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1247         (WTR::InjectedBundle::didReceiveMessageToPage):
1248         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1249         (WTR::TestRunner::setAllowedMenuActions):
1250
1251         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
1252         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
1253         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
1254         against the name of the custom action.
1255
1256         (WTR::TestRunner::installCustomMenuAction):
1257
1258         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
1259         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
1260         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
1261         triggered.
1262
1263         (WTR::TestRunner::performCustomMenuAction):
1264
1265         Invoked when the custom menu action is triggered.
1266
1267         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1268         * WebKitTestRunner/TestController.cpp:
1269         (WTR::TestController::installCustomMenuAction):
1270         (WTR::TestController::setAllowedMenuActions):
1271         * WebKitTestRunner/TestController.h:
1272         * WebKitTestRunner/TestInvocation.cpp:
1273         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1274         (WTR::TestInvocation::performCustomMenuAction):
1275
1276         Add plumbing to call back into the injected bundle when performing the custom action.
1277
1278         * WebKitTestRunner/TestInvocation.h:
1279         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1280         (WTR::TestController::installCustomMenuAction):
1281         (WTR::TestController::setAllowedMenuActions):
1282         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1283         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1284         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1285         (-[TestRunnerWKWebView becomeFirstResponder]):
1286         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
1287
1288         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
1289         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
1290         in the Mail app on iOS.
1291
1292         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
1293         (-[TestRunnerWKWebView setAllowedMenuActions:]):
1294         (-[TestRunnerWKWebView resetCustomMenuAction]):
1295         (-[TestRunnerWKWebView performCustomAction:]):
1296         (-[TestRunnerWKWebView canPerformAction:withSender:]):
1297         (-[TestRunnerWKWebView _willHideMenu]):
1298         (-[TestRunnerWKWebView _didHideMenu]):
1299         * WebKitTestRunner/ios/TestControllerIOS.mm:
1300         (WTR::TestController::platformResetStateToConsistentValues):
1301
1302         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
1303         if specified.
1304
1305         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1306         (WTR::UIScriptController::isDismissingMenu const):
1307
1308 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
1309
1310         Allow sharing from imageSheet on an image document
1311         https://bugs.webkit.org/show_bug.cgi?id=196891
1312         <rdar://problem/25377386>
1313
1314         Reviewed by Tim Horton.
1315
1316         Test to make sure that the correct imageURL is extracted from an image element.
1317
1318         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1319         (TestWebKitAPI::TEST):
1320
1321 2019-04-16  Alex Christensen  <achristensen@webkit.org>
1322
1323         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
1324         https://bugs.webkit.org/show_bug.cgi?id=196995
1325
1326         Reviewed by Brady Eidson.
1327
1328         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1329         (TEST):
1330
1331 2019-04-16  Chris Dumez  <cdumez@apple.com>
1332
1333         URL set by document.open() is not communicated to the UIProcess
1334         https://bugs.webkit.org/show_bug.cgi?id=196941
1335         <rdar://problem/49237544>
1336
1337         Reviewed by Geoff Garen.
1338
1339         Add API test coverage.
1340
1341         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1342         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1343         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1344         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1345         (TEST):
1346
1347 2019-04-16  Commit Queue  <commit-queue@webkit.org>
1348
1349         Unreviewed, rolling out r244321.
1350         https://bugs.webkit.org/show_bug.cgi?id=196968
1351
1352         Causing all WK2 Debug builds to exit early after Assertion
1353         failures. (Requested by ShawnRoberts on #webkit).
1354
1355         Reverted changeset:
1356
1357         "URL set by document.open() is not communicated to the
1358         UIProcess"
1359         https://bugs.webkit.org/show_bug.cgi?id=196941
1360         https://trac.webkit.org/changeset/244321
1361
1362 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1363
1364         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1365         https://bugs.webkit.org/show_bug.cgi?id=196948
1366
1367         Reviewed by Zalan Bujtas.
1368
1369         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1370         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
1371
1372 2019-04-15  Chris Dumez  <cdumez@apple.com>
1373
1374         URL set by document.open() is not communicated to the UIProcess
1375         https://bugs.webkit.org/show_bug.cgi?id=196941
1376         <rdar://problem/49237544>
1377
1378         Reviewed by Geoffrey Garen.
1379
1380         Add API test coverage.
1381
1382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1383         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1384         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1385         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1386         (TEST):
1387
1388 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
1389
1390         Using Tools/Scripts/clean-webkit should not install requests
1391         https://bugs.webkit.org/show_bug.cgi?id=196940
1392
1393         Reviewed by Lucas Forschler.
1394
1395         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
1396         existing, depending on the path autoinstalled is run through.
1397         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
1398         needed.
1399         (Port.configuration_for_upload):
1400         (Port.commits_for_upload):
1401
1402 2019-04-15  Alex Christensen  <achristensen@webkit.org>
1403
1404         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
1405         https://bugs.webkit.org/show_bug.cgi?id=196773
1406
1407         Reviewed by Jer Noble.
1408
1409         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
1410         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
1411         (TEST):
1412
1413 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1414
1415         ews-build should clearly indicate flaky test failures
1416         https://bugs.webkit.org/show_bug.cgi?id=196947
1417
1418         Reviewed by Lucas Forschler.
1419
1420         * BuildSlaveSupport/ews-build/steps.py:
1421         (AnalyzeAPITestsResults.analyzeResults):
1422
1423 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
1424
1425         InjectedBundle parameters often need initialization function called before unarchiving
1426         https://bugs.webkit.org/show_bug.cgi?id=189709
1427         <rdar://problem/44573653>
1428
1429         Reviewed by Ryosuke Niwa.
1430
1431         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1432         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1433
1434 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1435
1436         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
1437         https://bugs.webkit.org/show_bug.cgi?id=196681
1438
1439         Reviewed by Darin Adler.
1440
1441         Added tests.
1442
1443         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1444         (WTF_HashSet.RemoveIf):
1445         (WTF_HashSet.RemoveIfShrinkToBestSize):
1446
1447 2019-04-15  John Wilander  <wilander@apple.com>
1448
1449         Send delayed Ad Click Attribution conversion requests to the click source
1450         https://bugs.webkit.org/show_bug.cgi?id=196838
1451         <rdar://problem/47650157>
1452
1453         Reviewed by Chris Dumez and Youenn Fablet.
1454
1455         This patch adds test infrastructure to override the default behavior in
1456         WebKit::NetworkAdClickAttribution.
1457
1458         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1459         (TestWebKitAPI::TEST):
1460         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1461         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1462         (WTR::TestRunner::dumpAdClickAttribution):
1463         (WTR::TestRunner::clearAdClickAttribution):
1464         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1465         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1466         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1467         * WebKitTestRunner/TestController.cpp:
1468         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
1469         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
1470         * WebKitTestRunner/TestController.h:
1471         * WebKitTestRunner/TestInvocation.cpp:
1472         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1473
1474 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1475
1476         [ews-app] status-bubble should display position in queue
1477         https://bugs.webkit.org/show_bug.cgi?id=196607
1478
1479         Reviewed by Lucas Forschler.
1480
1481         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1482         (StatusBubble._build_bubble):
1483         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1484
1485 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1486
1487         [ews-build] Do not run clean build by default on EWS builders
1488         https://bugs.webkit.org/show_bug.cgi?id=196897
1489
1490         Reviewed by Lucas Forschler.
1491
1492         * BuildSlaveSupport/ews-build/steps.py:
1493         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1494         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1495         untracked directories like WebKitBuild).
1496         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1497         untracked files/directories (like WebKitBuild).
1498
1499 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1500
1501         TestRunner::notifyDone() should be safely reentrant
1502         https://bugs.webkit.org/show_bug.cgi?id=196898
1503
1504         Reviewed by Darin Adler.
1505
1506         It is currently possible that TestRunner::notifyDone() will call itself, since
1507         notifyDone() will force a repaint, which can start executing JavaScript, which
1508         may call notifyDone() again. This can lead to test failures and flakiness.
1509         Fix this by setting the m_waitToDump flag before calling the dump() method.
1510
1511         * DumpRenderTree/mac/TestRunnerMac.mm:
1512         (TestRunner::notifyDone):
1513         (TestRunner::forceImmediateCompletion):
1514         * DumpRenderTree/win/TestRunnerWin.cpp:
1515         (TestRunner::notifyDone):
1516         (TestRunner::forceImmediateCompletion):
1517
1518 2019-04-15  Philippe Normand  <pnormand@igalia.com>
1519
1520         [GTK][WPE] Add enable-media websetting
1521         https://bugs.webkit.org/show_bug.cgi?id=196863
1522
1523         Reviewed by Michael Catanzaro.
1524
1525         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1526         (testWebKitSettings): Add test for the enable-media web-setting.
1527
1528 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1529
1530         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1531         https://bugs.webkit.org/show_bug.cgi?id=196905
1532         <rdar://problem/49886096>
1533
1534         Reviewed by Tim Horton.
1535
1536         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1537         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1538         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1539         delay timer, we end up with this sequence of events in the problematic (failure) case:
1540
1541         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1542             ...IPC from UI to web process...
1543         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1544             ...IPC from web to UI process...
1545         (c) [UI]    Invoke completion handler for script #1
1546         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1547             ...IPC from UI to web process...
1548         (e) [Web]   Evaluate script #2 in the web process
1549         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1550
1551         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1552         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1553         #2 is run in step (e).
1554
1555         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1556         the UI process by waiting on a script message posted by the web process, after attachment updates are
1557         dispatched.
1558
1559         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1560         (TestWebKitAPI::TEST):
1561
1562 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1563
1564         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1565         https://bugs.webkit.org/show_bug.cgi?id=196909
1566
1567         Reviewed by Wenson Hsieh.
1568
1569         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1570         (TestWebKitAPI::TEST):
1571
1572 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1573
1574         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1575         https://bugs.webkit.org/show_bug.cgi?id=196880
1576
1577         Reviewed by Yusuke Suzuki.
1578
1579         Add a new function for bytecode cache tests that does not forceDiskCache
1580         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1581         test added in this patch, since the code is invalid and therefore won't be
1582         cached. It should also be useful for tests that evaluate dynamically
1583         generated code.
1584
1585         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1586         * Scripts/run-jsc-stress-tests:
1587
1588 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1589
1590         Update AudioSession route sharing policy
1591         https://bugs.webkit.org/show_bug.cgi?id=196776
1592         <rdar://problem/46501611>
1593
1594         Reviewed by Jer Noble.
1595
1596         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1597         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1598         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1599         (TestWebKitAPI::TEST):
1600
1601 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1602
1603         [iOS] Software keyboard is shown too frequently on some websites
1604         https://bugs.webkit.org/show_bug.cgi?id=195856
1605         <rdar://problem/49191395>
1606
1607         Reviewed by Darin Adler.
1608
1609         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1610
1611         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1612         (WTR::UIScriptController::setHardwareKeyboardAttached):
1613         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1614         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1615         (WTR::UIScriptController::setHardwareKeyboardAttached):
1616         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1617         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1618
1619         Additionally link against GraphicsServices in WebKitTestRunner.
1620
1621         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1622         (WTR::TestController::platformResetStateToConsistentValues):
1623         (WTR::UIScriptController::setHardwareKeyboardAttached):
1624
1625 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1626
1627         [GTK][WPE] Fix pacman install-dependencies packages
1628         https://bugs.webkit.org/show_bug.cgi?id=196817
1629
1630         Reviewed by Žan Doberšek.
1631         
1632         python3-setuptools is called python-setuptools
1633         ruby-highline is only available on AUR
1634         libv4l-devel is incorporated in v4l-utils
1635
1636         * gtk/install-dependencies:
1637         * wpe/install-dependencies:
1638
1639 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1640
1641         [GTK] REGRESSION(r243860): Many tests failing
1642         https://bugs.webkit.org/show_bug.cgi?id=196791
1643
1644         Reviewed by Joanmarie Diggs.
1645
1646         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1647         multiple documents and check that accessibility hierarchy is updated after a navigation.
1648
1649         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1650         (loadChangedCallback):
1651         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1652         (AccessibilityTest::AccessibilityTest):
1653         (AccessibilityTest::~AccessibilityTest):
1654         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1655         (AccessibilityTest::findTestServerApplication):
1656         (AccessibilityTest::findDocumentWeb):
1657         (AccessibilityTest::findRootObject):
1658         (AccessibilityTest::waitUntilChildrenRemoved):
1659         (AccessibilityTest::ensureProxy):
1660         (testAtspiBasicHierarchy):
1661         (beforeAll):
1662         (afterAll):
1663
1664 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1665
1666         [ews-build] Handle bug titles with unicode characters
1667         https://bugs.webkit.org/show_bug.cgi?id=196802
1668
1669         Reviewed by Dewei Zhu.
1670
1671         * BuildSlaveSupport/ews-build/steps.py:
1672         (ValidatePatch._is_bug_closed):
1673
1674 2019-04-11  Michael Saboff  <msaboff@apple.com>
1675
1676         Improve the Inline Cache Stats code
1677         https://bugs.webkit.org/show_bug.cgi?id=196836
1678
1679         Reviewed by Saam Barati.
1680
1681         Added a new script to consolidate and arrange the output of --useICStats option.
1682
1683         This script merges the output from every group into one large table and sorts it from most common to
1684         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1685         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1686         Put together, this is useful to see what property accesses are not getting cached.
1687
1688         * Scripts/ic-stats.py: Added.
1689         (ICStats):
1690         (ICStats.__init__):
1691         (ICStats.parse):
1692         (ICStats.dumpStats):
1693         (usage):
1694
1695 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1696
1697         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1698         https://bugs.webkit.org/show_bug.cgi?id=196809
1699         <rdar://49800762>
1700
1701         Reviewed by Brady Eidson.
1702
1703         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1704         (TEST):
1705
1706 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1707
1708         requestAnimationFrame should execute before the next frame
1709         https://bugs.webkit.org/show_bug.cgi?id=177484
1710
1711         Reviewed by Simon Fraser.
1712
1713         Add trace points for the page RenderingUpdate.
1714
1715         * Tracing/SystemTracePoints.plist:
1716
1717 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1718
1719         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1720         https://bugs.webkit.org/show_bug.cgi?id=196760
1721
1722         Reviewed by Don Olmstead.
1723
1724         vswhere.exe has been bundled since Visual Studio 2017 version
1725         15.2. We shouldn't download vswhere.exe.
1726
1727         * Scripts/build-jsc: Do not call update-vswhere.py.
1728         * Scripts/build-webkit: Ditto.
1729         * Scripts/update-vswhere.py: Removed.
1730         * Scripts/webkitdirs.pm:
1731         (requireModulesForVSWhere): Deleted.
1732         (pickCurrentVisualStudioInstallation): Deleted.
1733         (visualStudioInstallDirVSWhere): Return the latest installed VS
1734         installation path by using the bundled vswhere.exe.
1735         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1736         (visualStudioInstallDirFallback): Removed.
1737
1738 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1739
1740         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1741         https://bugs.webkit.org/show_bug.cgi?id=196780
1742
1743         Reviewed by Alexey Proskuryakov.
1744
1745         * BuildSlaveSupport/ews-build/steps.py:
1746         * BuildSlaveSupport/ews-build/steps_unittest.py:
1747
1748 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1749
1750         Add SPI WKNavigationResponse._downloadAttribute
1751         https://bugs.webkit.org/show_bug.cgi?id=196755
1752         <rdar://49587365>
1753
1754         Reviewed by Brady Eidson.
1755
1756         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1757         (-[NavigationResponseTestDelegate navigationResponse]):
1758         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1759         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1760         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1761         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1762         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1763         (readRequest):
1764         (writeResponse):
1765         (TEST):
1766
1767 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1768
1769         Add modern API for overriding the page's specified viewport configuration
1770         https://bugs.webkit.org/show_bug.cgi?id=167734
1771         <rdar://problem/30331795>
1772
1773         Reviewed by Simon Fraser.
1774
1775         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1776         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1777
1778 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1779
1780         Add support for incremental bytecode cache updates
1781         https://bugs.webkit.org/show_bug.cgi?id=195000
1782
1783         Reviewed by Filip Pizlo.
1784
1785         Exit when the initial run to generate bytecode fails.
1786
1787         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1788
1789 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1790
1791         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1792         https://bugs.webkit.org/show_bug.cgi?id=196744
1793         <rdar://49415309>
1794
1795         Reviewed by Chris Dumez.
1796
1797         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1798         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1799
1800 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1801
1802         Add a way to opt into modern compatibility mode in layout tests
1803         https://bugs.webkit.org/show_bug.cgi?id=196770
1804         <rdar://problem/49777550>
1805
1806         Reviewed by Antoine Quint.
1807
1808         Add a new test option to enable modern compatibility mode in layout tests.
1809
1810         * WebKitTestRunner/TestController.cpp:
1811         (WTR::updateTestOptionsFromTestHeader):
1812         * WebKitTestRunner/TestController.h:
1813         * WebKitTestRunner/TestOptions.h:
1814         (WTR::TestOptions::hasSameInitializationOptions const):
1815         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1816         (WTR::TestController::platformCreateWebView):
1817         (WTR::TestController::enableModernCompatibilityMode):
1818
1819 2019-04-10  Andy Estes  <aestes@apple.com>
1820
1821         Try to fix the 32-bit watchOS build.
1822
1823         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1824         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1825
1826 2019-04-10  Antoine Quint  <graouts@apple.com>
1827
1828         Enable Pointer Events on watchOS
1829         https://bugs.webkit.org/show_bug.cgi?id=196771
1830         <rdar://problem/49040909>
1831
1832         Reviewed by Dean Jackson.
1833
1834         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1835
1836 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1837
1838         Unreviewed. Fix WPE accessibility tests after r244059.
1839
1840         We are failing to load the injected bundle due to undefined symbol
1841         AccessibilityUIElement::replaceTextInRange().
1842
1843         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1844         (WTR::AccessibilityUIElement::replaceTextInRange):
1845
1846 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1847
1848         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1849         https://bugs.webkit.org/show_bug.cgi?id=196727
1850
1851         Reviewed by Fujii Hironori.
1852
1853         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1854         (WebKitBrowserWindow::create):
1855
1856 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1857
1858         [ews-build] Add unit tests for PrintConfiguration
1859         https://bugs.webkit.org/show_bug.cgi?id=196752
1860
1861         Reviewed by Dewei Zhu.
1862
1863         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1864
1865 2019-04-09  Keith Rollin  <krollin@apple.com>
1866
1867         Unreviewed build maintenance -- update .xcfilelists.
1868
1869         * DumpRenderTree/DerivedSources-input.xcfilelist:
1870         * DumpRenderTree/DerivedSources-output.xcfilelist:
1871
1872 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1873
1874         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1875         https://bugs.webkit.org/show_bug.cgi?id=196743
1876         <rdar://problem/43897551>
1877
1878         Reviewed by Tim Horton.
1879
1880         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1881         (TEST):
1882
1883 2019-04-09  Youenn Fablet  <youenn@apple.com>
1884
1885         Close service worker database on network process suspension
1886         https://bugs.webkit.org/show_bug.cgi?id=196623
1887         <rdar://problem/48930869>
1888
1889         Reviewed by Alex Christensen.
1890
1891         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1892
1893 2019-04-09  Daniel Bates  <dabates@apple.com>
1894
1895         [iPad] Should open popover when the spacebar is pressed
1896         https://bugs.webkit.org/show_bug.cgi?id=196360
1897         <rdar://problem/49389129>
1898
1899         Reviewed by Brent Fulgham.
1900
1901         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1902
1903         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1904         (WTR::UIScriptController::isShowingPopover const): Added.
1905         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1906         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1907         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1908         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1909         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1910         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1911         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1912         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1913         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1914         (WTR::UIScriptController::isShowingPopover const): Added.
1915         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1916         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1917         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1918         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1919         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1920         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1921         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1922         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1923         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1924         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1925         (WTR::UIScriptController::isShowingPopover const): Added.
1926         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1927         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1928
1929 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1930
1931         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1932         https://bugs.webkit.org/show_bug.cgi?id=196665
1933         <rdar://45115669>
1934
1935         Reviewed by Geoff Garen.
1936
1937         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1938         (goBack):
1939         (+[SimpleLookupContext sharedLookupContext]):
1940         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1941         (TEST):
1942         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1943         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1944
1945 2019-04-09  John Wilander  <wilander@apple.com>
1946
1947         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1948         https://bugs.webkit.org/show_bug.cgi?id=196558
1949         <rdar://problem/47650245>
1950
1951         Reviewed by Youenn Fablet.
1952
1953         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1954         (TestWebKitAPI::TEST):
1955             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1956
1957 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1958
1959         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1960         https://bugs.webkit.org/show_bug.cgi?id=196720
1961
1962         Reviewed by Konstantin Tokarev.
1963
1964         * TestWebKitAPI/PlatformMac.cmake:
1965
1966 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1967
1968         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1969         https://bugs.webkit.org/show_bug.cgi?id=196694
1970         <rdar://problem/48388734>
1971
1972         Rubber-stamped by Aakash Jain.
1973
1974         * Scripts/webkitpy/port/image_diff.py:
1975         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1976         * Scripts/webkitpy/port/server_process.py:
1977         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1978         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1979         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1980         * Scripts/webkitpy/port/server_process_mock.py:
1981         (MockServerProcess.has_available_stdout):
1982         * Scripts/webkitpy/port/server_process_unittest.py:
1983         (TestServerProcess.serial_test_basic):
1984
1985 2019-04-09  Jer Noble  <jer.noble@apple.com>
1986
1987         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1988         https://bugs.webkit.org/show_bug.cgi?id=196097
1989
1990         Reviewed by Eric Carlson.
1991
1992         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1993
1994         * DumpRenderTree/mac/DumpRenderTree.mm:
1995         (resetWebPreferencesToConsistentValues):
1996         * WebKitTestRunner/TestController.cpp:
1997         (WTR::TestController::resetPreferencesToConsistentValues):
1998
1999 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2000
2001         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2002         https://bugs.webkit.org/show_bug.cgi?id=196690
2003
2004         Reviewed by Michael Catanzaro.
2005
2006         * QueueStatusServer/config/queues.py:
2007         * Scripts/webkitpy/common/config/ews.json:
2008         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2009         (test_ews_name):
2010
2011 2019-04-09  Chris Dumez  <cdumez@apple.com>
2012
2013         Loads using loadHTMLString() cause flashing when process-swapping
2014         https://bugs.webkit.org/show_bug.cgi?id=196714
2015         <rdar://problem/49637354>
2016
2017         Reviewed by Antti Koivisto.
2018
2019         Add API test coverage.
2020
2021         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2022
2023 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2024
2025         Unreviewed. Fix ATK accessibility tests after r244059.
2026
2027         We are failing to load the injected bundle due to undefined symbol
2028         AccessibilityUIElement::replaceTextInRange().
2029
2030         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2031         (WTR::AccessibilityUIElement::replaceTextInRange):
2032
2033 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2034
2035         AX: Support API: accessibilityReplaceRange:withText
2036         https://bugs.webkit.org/show_bug.cgi?id=196636
2037
2038         Unreviewed build fix for Windows port.
2039
2040         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2041         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2042
2043 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2044
2045         [CMake][WinCairo] Separate copied headers into different directories
2046         https://bugs.webkit.org/show_bug.cgi?id=196655
2047
2048         Reviewed by Michael Catanzaro.
2049
2050         * DumpRenderTree/CMakeLists.txt:
2051         * MiniBrowser/win/CMakeLists.txt:
2052         * TestWebKitAPI/CMakeLists.txt:
2053         * TestWebKitAPI/PlatformWin.cmake:
2054
2055 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2056
2057         Log stack-trace for run-webkit-tests when interrupted
2058         https://bugs.webkit.org/show_bug.cgi?id=176393
2059         <rdar://problem/34262310>
2060
2061         Reviewed by Lucas Forschler.
2062
2063         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2064         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2065         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2066         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2067         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2068         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2069         (main): Set handlers to log stack trace on interruption.
2070
2071 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2072
2073         AX: Support API: accessibilityReplaceRange:withText
2074         https://bugs.webkit.org/show_bug.cgi?id=196636
2075
2076         Unreviewed build fix for Windows port.
2077
2078         * DumpRenderTree/AccessibilityUIElement.cpp:
2079         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2080
2081 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2082
2083         [ews-build] Scripts using Buildbot API have CORS error
2084         https://bugs.webkit.org/show_bug.cgi?id=196709
2085
2086         Reviewed by Alexey Proskuryakov.
2087
2088         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2089
2090 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2091
2092         AX: Support API: accessibilityReplaceRange:withText
2093         https://bugs.webkit.org/show_bug.cgi?id=196636
2094
2095         Reviewed by Daniel Bates.
2096
2097         * DumpRenderTree/AccessibilityUIElement.cpp:
2098         (replaceTextInRangeCallback):
2099         (AccessibilityUIElement::replaceTextInRange):
2100         (AccessibilityUIElement::getJSClass):
2101         * DumpRenderTree/AccessibilityUIElement.h:
2102         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2103         (AccessibilityUIElement::replaceTextInRange):
2104         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2105         (AccessibilityUIElement::replaceTextInRange):
2106         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2107         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2108         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2109         (WTR::AccessibilityUIElement::replaceTextInRange):
2110         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2111         (WTR::AccessibilityUIElement::replaceTextInRange):
2112
2113 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2114
2115         [iOS] Do not allow starting selection drags when selection views are not visible
2116         https://bugs.webkit.org/show_bug.cgi?id=196686
2117         <rdar://problem/49399192>
2118
2119         Reviewed by Tim Horton.
2120
2121         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2122         also add some new API tests to cover scenarios where the web view is not first responder.
2123
2124         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2125         (TestWebKitAPI::TEST):
2126         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2127
2128         Add a switch to optionally make the web view first responder when starting the simulated drag.
2129
2130         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2131         (-[DragAndDropSimulator initWithWebView:]):
2132         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2133
2134 2019-04-08  Justin Fan  <justin_fan@apple.com>
2135
2136         [Web GPU] Fix Web GPU experimental feature on iOS
2137         https://bugs.webkit.org/show_bug.cgi?id=196632
2138
2139         Reviewed by Myles C. Maxfield.
2140
2141         Properly make Web GPU available on iOS 11+.
2142
2143         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2144
2145 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2146
2147         [ews-build] Do not upload archive when Compile Fails
2148         https://bugs.webkit.org/show_bug.cgi?id=196674
2149
2150         Reviewed by Alexey Proskuryakov.
2151
2152         * BuildSlaveSupport/ews-build/factories.py:
2153         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2154         * BuildSlaveSupport/ews-build/steps.py:
2155         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2156         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2157         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2158
2159 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2160
2161         Enable DFG on MIPS
2162         https://bugs.webkit.org/show_bug.cgi?id=196689
2163
2164         Reviewed by Žan Doberšek.
2165
2166         Since the bytecode change, we enabled the baseline JIT on mips in
2167         r240432, but DFG is still missing. With this change, all tests are
2168         passing on a ci20 board.
2169
2170         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2171
2172 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2173
2174         [Flatpak] Second run update-webkitwpe-flatpak fails
2175         https://bugs.webkit.org/show_bug.cgi?id=192702
2176
2177         Reviewed by Carlos Garcia Campos.
2178
2179         * flatpak/flatpakutils.py:
2180         (FlatpakObject.flatpak): Fix typo.
2181         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2182         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2183
2184 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2185
2186         [GTK][WPE] outlook.live.com displays old-fashioned UI
2187         https://bugs.webkit.org/show_bug.cgi?id=196642
2188
2189         Reviewed by Carlos Garcia Campos.
2190
2191         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2192         (TestWebKitAPI::TEST): New Mac platform quirk test.
2193
2194 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2195
2196         Unreviewed, rolling out r243956.
2197         https://bugs.webkit.org/show_bug.cgi?id=196688
2198
2199         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2200         by aakashjain on #webkit).
2201
2202         Reverted changeset:
2203
2204         "Clicking "Go Back" from a safe browsing warning from an
2205         iframe should navigate the WKWebView back to the previous
2206         page"
2207         https://bugs.webkit.org/show_bug.cgi?id=196665
2208         https://trac.webkit.org/changeset/243956
2209
2210 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2211
2212         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2213         https://bugs.webkit.org/show_bug.cgi?id=196669
2214
2215         Reviewed by Geoffrey Garen.
2216
2217         Added three new unit tests for WeakHashSet.
2218
2219         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2220         (WTF_WeakPtr.WeakHashSetConstObjects):
2221         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2222         (WTF_WeakPtr.WeakHashSetComputeSize):
2223
2224 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2225
2226         Hide next and previous form control buttons when WKWebView is editable
2227         https://bugs.webkit.org/show_bug.cgi?id=196672
2228         <rdar://problem/35625321>
2229
2230         Reviewed by Tim Horton.
2231
2232         Add a new API test.
2233
2234         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2235         (-[TestWKWebView lastTrailingBarButtonGroup]):
2236         (TestWebKitAPI::TEST):
2237         * TestWebKitAPI/ios/UIKitSPI.h:
2238
2239 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2240
2241         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
2242         https://bugs.webkit.org/show_bug.cgi?id=196077
2243         <rdar://problem/49108202>
2244
2245         Reviewed by Chris Dumez.
2246
2247         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
2248         on new web view.
2249
2250         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2251
2252 2019-04-05  Saam Barati  <sbarati@apple.com>
2253
2254         Make compare-results understand MotionMark
2255         https://bugs.webkit.org/show_bug.cgi?id=196666
2256
2257         Reviewed by Yusuke Suzuki.
2258
2259         * Scripts/compare-results:
2260         (PLT5Results):
2261         (detectMotionMark):
2262         (detectMotionMark1_1):
2263         (motionMarkResults):
2264         (motionMark1_1Results):
2265         (detectBenchmark):
2266         (biggerIsBetter):
2267         (main):
2268
2269 2019-04-05  Alex Christensen  <achristensen@webkit.org>
2270
2271         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2272         https://bugs.webkit.org/show_bug.cgi?id=196665
2273         <rdar://45115669>
2274
2275         Reviewed by Geoff Garen.
2276
2277         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2278         (goBack):
2279         (+[SimpleLookupContext sharedLookupContext]):
2280         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2281         (TEST):
2282         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2283         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2284
2285 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
2286
2287         [ews-build] Add configuration and architecture for windows builders
2288         https://bugs.webkit.org/show_bug.cgi?id=196660
2289
2290         Reviewed by Lucas Forschler.
2291
2292         * BuildSlaveSupport/ews-build/config.json:
2293
2294 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
2295
2296         webkitpy: Don't run subsequent rounds if interrupted
2297         https://bugs.webkit.org/show_bug.cgi?id=196646
2298
2299         Reviewed by Aakash Jain.
2300
2301         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2302         (Manager.run): Bail out if interrupted.
2303
2304 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
2305
2306         Test sessionStorage in PSON private browsing mode
2307         https://bugs.webkit.org/show_bug.cgi?id=196561
2308
2309         Reviewed by Alex Christensen.
2310
2311         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2312
2313 2019-04-05  Commit Queue  <commit-queue@webkit.org>
2314
2315         Unreviewed, rolling out r243833.
2316         https://bugs.webkit.org/show_bug.cgi?id=196645
2317
2318         This change breaks build of WPE and GTK ports (Requested by
2319         annulen on #webkit).
2320
2321         Reverted changeset:
2322
2323         "[CMake][WTF] Mirror XCode header directories"
2324         https://bugs.webkit.org/show_bug.cgi?id=191662
2325         https://trac.webkit.org/changeset/243833
2326
2327 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
2328
2329         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
2330         https://bugs.webkit.org/show_bug.cgi?id=196635
2331
2332         Reviewed by Antti Koivisto.
2333         
2334         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
2335         for a test to enable async frame scrolling via:
2336             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
2337         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
2338         
2339         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
2340
2341         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2342         (WTR::InjectedBundle::beginTesting):
2343         * WebKitTestRunner/TestController.cpp:
2344         (WTR::TestController::resetPreferencesToConsistentValues):
2345
2346 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
2347
2348         Use a correct LC_RPATH when building with ASan
2349         https://bugs.webkit.org/show_bug.cgi?id=196576
2350
2351         Reviewed by David Kilzer.
2352
2353         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
2354         so that ../Frameworks is checked. This is simpler and more reliable than updating
2355         each SPC service xcconfig.
2356
2357 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2358
2359         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
2360         https://bugs.webkit.org/show_bug.cgi?id=196629
2361
2362         Reviewed by Lucas Forschler.
2363
2364         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2365
2366 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2367
2368         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
2369         https://bugs.webkit.org/show_bug.cgi?id=196618
2370
2371         Reviewed by Lucas Forschler.
2372
2373         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2374         (StatusBubble): Added QUEUE_TRIGGERS.
2375         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
2376         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
2377         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
2378         its parent(builder).
2379
2380 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2381
2382         [ews-app] Status-bubble steps are sometimes displayed in reverse order
2383         https://bugs.webkit.org/show_bug.cgi?id=196625
2384
2385         Reviewed by Lucas Forschler.
2386
2387         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2388         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
2389
2390 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2391
2392         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
2393         https://bugs.webkit.org/show_bug.cgi?id=196630
2394
2395         Reviewed by Wenson Hsieh.
2396
2397         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2398
2399 2019-04-04  Youenn Fablet  <youenn@apple.com>
2400
2401         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
2402         https://bugs.webkit.org/show_bug.cgi?id=196543
2403
2404         Reviewed by Alex Christensen.
2405
2406         * WebKitTestRunner/TestController.cpp:
2407         (WTR::TestController::generatePageConfiguration):
2408
2409 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2410
2411         [ews-app] Status bubble should not display skipped buildbot steps
2412         https://bugs.webkit.org/show_bug.cgi?id=196584
2413
2414         Reviewed by Lucas Forschler.
2415
2416         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2417
2418 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2419
2420         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
2421         https://bugs.webkit.org/show_bug.cgi?id=196620
2422
2423         Reviewed by Lucas Forschler.
2424
2425         * BuildSlaveSupport/ews-app/ews/config.py:
2426
2427 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
2428
2429         [Win] DumpRenderTreeWatchDog.py is not checked into source
2430         https://bugs.webkit.org/show_bug.cgi?id=196567
2431         <rdar://problem/49525901>
2432
2433         Reviewed by Lucas Forschler.
2434
2435         This script is used on Win EWS bots to terminate hanging DRT processes.
2436
2437         * EWSTools/dumprendertreewatchdog.py: Added.
2438
2439 2019-04-04  Chris Dumez  <cdumez@apple.com>
2440
2441         Unreviewed, roll out r243858 which made tests time out.
2442
2443         Disable new API tests on Windows instead.
2444
2445         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2446         (TestWebKitAPI::TEST):
2447
2448 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2449
2450         [ATK] Cleanup WebPageAccessibilityObjectAtk
2451         https://bugs.webkit.org/show_bug.cgi?id=196537
2452
2453         Reviewed by Michael Catanzaro.
2454
2455         Also consider files under atk directories as exceptions for GObject conventions.
2456
2457         * Scripts/webkitpy/style/checkers/cpp.py:
2458         (check_identifier_name_in_declaration):
2459
2460 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2461
2462         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2463         https://bugs.webkit.org/show_bug.cgi?id=196588
2464         <rdar://problem/49365787>
2465
2466         Unreviewed build fix for Windows port.
2467
2468         error C3861: 'kill': identifier not found
2469
2470         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2471         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2472
2473 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2474
2475         [ews-build] Cancel build and similar operations should have authentication
2476         https://bugs.webkit.org/show_bug.cgi?id=196520
2477
2478         Reviewed by Dewei Zhu.
2479
2480         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2481         environment variables.
2482
2483 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2484
2485         [ews-build] Do not trigger queues which are not in production yet
2486         https://bugs.webkit.org/show_bug.cgi?id=196581
2487
2488         Reviewed by Dewei Zhu.
2489
2490         * BuildSlaveSupport/ews-build/config.json:
2491
2492 2019-04-03  Chris Dumez  <cdumez@apple.com>
2493
2494         Unreviewed, fix typo in the name of API test added in r243848.
2495
2496         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2497         (TestWebKitAPI::TEST):
2498
2499 2019-04-03  Chris Dumez  <cdumez@apple.com>
2500
2501         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2502         https://bugs.webkit.org/show_bug.cgi?id=196588
2503         <rdar://problem/49365787>
2504
2505         Reviewed by Ryosuke Niwa.
2506
2507         Add API test coverage.
2508
2509         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2510         (TestWebKitAPI::nullJavaScriptCallback):
2511         (TestWebKitAPI::didCrashCheckFrames):
2512         (TestWebKitAPI::TEST):
2513
2514 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2515
2516         run-webkit-tests: Upload test results (new results database)
2517         https://bugs.webkit.org/show_bug.cgi?id=196577
2518         <rdar://problem/34841155>
2519
2520         Reviewed by Lucas Forschler.
2521
2522         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2523         (Manager.run): Upload results after each device shard, since the configuration will be
2524         different for each device.
2525         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2526         uploaded to a results database.
2527         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2528         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2529
2530 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2531
2532         -apple-trailing-word is needed for browser detection
2533         https://bugs.webkit.org/show_bug.cgi?id=196575
2534
2535         Unreviewed.
2536
2537         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2538
2539 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2540
2541         [CMake][WTF] Mirror XCode header directories
2542         https://bugs.webkit.org/show_bug.cgi?id=191662
2543
2544         Reviewed by Konstantin Tokarev.
2545
2546         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2547         builds.
2548
2549         * CMakeLists.txt:
2550         * DumpRenderTree/CMakeLists.txt:
2551         * DumpRenderTree/PlatformWin.cmake:
2552         * MiniBrowser/win/CMakeLists.txt:
2553         * TestWebKitAPI/CMakeLists.txt:
2554         * TestWebKitAPI/PlatformWin.cmake:
2555         * WebKitTestRunner/PlatformGTK.cmake:
2556         * WebKitTestRunner/PlatformWin.cmake:
2557
2558 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2559
2560         [ews-app] Status bubble should not display certain infrastructure status messages
2561         https://bugs.webkit.org/show_bug.cgi?id=196550
2562
2563         Reviewed by Lucas Forschler.
2564
2565         Do not display the steps which are un-needed for end-user. This information is still avaiable
2566         if the user click on the bubble and look at the Buildbot build.
2567         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2568         (StatusBubble._steps_messages):
2569         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2570
2571 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2572
2573         [ews-build] Use https for sending data to ews-app
2574         https://bugs.webkit.org/show_bug.cgi?id=196492
2575
2576         Reviewed by Lucas Forschler.
2577
2578         * BuildSlaveSupport/ews-build/events.py:
2579
2580 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2581
2582         Remove support for -apple-trailing-word
2583         https://bugs.webkit.org/show_bug.cgi?id=196525
2584
2585         Reviewed by Zalan Bujtas.
2586
2587         This CSS property is nonstandard and not used.
2588
2589         * Scripts/webkitperl/FeatureList.pm:
2590         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2591
2592 2019-04-03  Youenn Fablet  <youenn@apple.com>
2593
2594         Add a test for DOMCache on multiple browsing in case of private browsing
2595         https://bugs.webkit.org/show_bug.cgi?id=196524
2596
2597         Reviewed by Alex Christensen.
2598
2599         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2600         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2601
2602 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2603
2604         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2605         https://bugs.webkit.org/show_bug.cgi?id=196540
2606
2607         Reviewed by Aakash Jain.
2608
2609         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2610
2611 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2612
2613         Add plumbing for a compatibility mode preference in WebKit
2614         https://bugs.webkit.org/show_bug.cgi?id=196005
2615
2616         Reviewed by Tim Horton.
2617
2618         Add new API tests.
2619
2620         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2621         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2622
2623 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2624
2625         [WPE][GTK] Update libsrtp dependency package for Debian
2626         https://bugs.webkit.org/show_bug.cgi?id=196528
2627
2628         Reviewed by Frédéric Wang.
2629
2630         * gtk/install-dependencies:
2631         * wpe/install-dependencies:
2632
2633 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2634
2635         [WK2] Add support for Window's beforeprint / afterprint events
2636         https://bugs.webkit.org/show_bug.cgi?id=196478
2637         <rdar://problem/49535124>
2638
2639         Unreviewed build fix for MSVC.
2640
2641         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2642
2643         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2644
2645         * WebKitTestRunner/TestController.cpp:
2646         (WTR::printFrame): Use int and float literals.
2647
2648 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2649
2650         [ews-build] Reassign bots to queues
2651
2652         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2653
2654 2019-04-02  Chris Dumez  <cdumez@apple.com>
2655
2656         [WK2] Add support for Window's beforeprint / afterprint events
2657         https://bugs.webkit.org/show_bug.cgi?id=196478
2658
2659         Reviewed by Alex Christensen.
2660
2661         Add minimal implementation for printFrame in WebKitTestRunner.
2662
2663         * WebKitTestRunner/TestController.cpp:
2664         (WTR::printFrame):
2665         (WTR::TestController::createOtherPage):
2666         (WTR::TestController::createWebViewWithOptions):
2667
2668 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2669
2670         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2671         https://bugs.webkit.org/show_bug.cgi?id=196491
2672
2673         Reviewed by Lucas Forschler.
2674
2675         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2676
2677 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2678
2679         [ews-build] Configure buildbot try credentials in environment variables
2680         https://bugs.webkit.org/show_bug.cgi?id=196501
2681
2682         Reviewed by Lucas Forschler.
2683
2684         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2685         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2686         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2687
2688 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2689
2690         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2691         https://bugs.webkit.org/show_bug.cgi?id=196496
2692         <rdar://problem/49521634>
2693
2694         Reviewed by Chris Dumez.
2695
2696         Add new API tests (see WebKit ChangeLog for more detail).
2697
2698         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2699         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2700         (TEST):
2701
2702 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2703
2704         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2705         <https://webkit.org/b/196499>
2706
2707         Reviewed by Alexey Proskuryakov.
2708
2709         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2710         ENABLE_ADDRESS_SANITIZER.
2711
2712 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2713
2714         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2715         https://bugs.webkit.org/show_bug.cgi?id=182757
2716
2717         Reviewed by Don Olmstead.
2718
2719         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2720         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2721
2722 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2723
2724         run-api-tests: Upload test results
2725         https://bugs.webkit.org/show_bug.cgi?id=196323
2726         <rdar://problem/49356714>
2727
2728         Reviewed by Lucas Forschler.
2729
2730         * Scripts/webkitpy/api_tests/manager.py:
2731         (Manager):
2732         (Manager.run): Upload results to a results database.
2733         * Scripts/webkitpy/api_tests/run_api_tests.py:
2734         (parse_args): Add upload arguments.
2735         * Scripts/webkitpy/port/base.py:
2736         (Port):
2737         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2738         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2739         with commits from any other associated repositories.
2740         * Scripts/webkitpy/port/device.py:
2741         (Device):
2742         (Device.build_version): Access build_versoin of underlying platform device.
2743         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2744         (IOSSimulatorTest):
2745         (IOSSimulatorTest.test_configuration_for_upload):
2746         * Scripts/webkitpy/port/device_port.py:
2747         (DevicePort):
2748         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2749         the same as the machine uploading results.
2750         * Scripts/webkitpy/port/mac.py:
2751         (MacPort):
2752         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2753         * Scripts/webkitpy/port/mac_unittest.py:
2754         (MacTest):
2755         (MacTest.test_configuration_for_upload):
2756         * Scripts/webkitpy/xcode/simulated_device.py:
2757         (SimulatedDeviceManager._create_device_with_runtime):
2758         (SimulatedDevice.__init__): Create simulated device with a build_version.
2759         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2760         (test_existing_simulator):
2761
2762 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2763
2764         Remove extra newline characters (Follow-up fix to r243707)
2765
2766         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2767
2768 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2769
2770         [ews-app] Use API_KEY to accept results data
2771         https://bugs.webkit.org/show_bug.cgi?id=196461
2772
2773         Reviewed by Dewei Zhu.
2774
2775         * BuildSlaveSupport/ews-app/ews/views/results.py:
2776         (Results.post): Validate EWS_API_KEY before accepting any data.
2777         * BuildSlaveSupport/ews-build/events.py:
2778         (Events.sendData): Send EWS_API_KEY if available along with event data.
2779
2780 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2781
2782         Unable to copy and paste a PDF from Notes into Mail compose body
2783         https://bugs.webkit.org/show_bug.cgi?id=196442
2784         <rdar://problem/48573098>
2785
2786         Reviewed by Tim Horton.
2787
2788         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2789         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2790         to be specified on the item providers.
2791
2792         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2793         (TestWebKitAPI::mapItemForTesting):
2794         (TestWebKitAPI::contactItemForTesting):
2795
2796 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2797
2798         Make UIWKDocumentContext rects per-character instead of per-word
2799         https://bugs.webkit.org/show_bug.cgi?id=196459
2800
2801         Reviewed by Wenson Hsieh.
2802
2803         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2804         (TEST):
2805         Adjust test results due to switching to per-character rects.
2806
2807 2019-04-01  Chris Dumez  <cdumez@apple.com>
2808
2809         UIProcess crash when a prewarmed process is terminated
2810         https://bugs.webkit.org/show_bug.cgi?id=196451
2811         <rdar://problem/49245471>
2812
2813         Reviewed by Geoffrey Garen.
2814
2815         Add API test coverage.
2816
2817         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2818         (TEST):
2819
2820 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2821
2822         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2823         https://bugs.webkit.org/show_bug.cgi?id=196449
2824
2825         Reviewed by Lucas Forschler.
2826
2827         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2828         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2829         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2830         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2831
2832 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2833
2834         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2835         https://bugs.webkit.org/show_bug.cgi?id=196444
2836
2837         Reviewed by Lucas Forschler.
2838
2839         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2840
2841 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2842
2843         Add SPI to canonicalize NSURLs with WTF::URL
2844         https://bugs.webkit.org/show_bug.cgi?id=196415
2845         <rdar://problem/44980271>
2846
2847         Reviewed by Darin Adler.
2848
2849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2850         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2851         (TestWebKitAPI::TEST):
2852
2853 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2854
2855         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2856         https://bugs.webkit.org/show_bug.cgi?id=196441
2857
2858         Reviewed by Carlos Garcia Campos.
2859
2860         Don't cache the wpe_view_backend object that might not exist yet at the
2861         time of EventSenderProxy constructor invocation, but instead retrieve
2862         that object whenever it's required for event dispatching. This should
2863         avoid crashes in this constructor now that it's invoked before any
2864         PlatformWindow has been set up (as changed in r243496).
2865
2866         * WebKitTestRunner/EventSenderProxy.h:
2867         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2868         (WTR::viewBackend):
2869         (WTR::EventSenderProxy::EventSenderProxy):
2870         (WTR::EventSenderProxy::mouseDown):
2871         (WTR::EventSenderProxy::mouseUp):
2872         (WTR::EventSenderProxy::mouseMoveTo):
2873         (WTR::EventSenderProxy::mouseScrollBy):
2874         (WTR::EventSenderProxy::keyDown):
2875         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2876
2877 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2878
2879         [Win][WebKit] MiniBrowser should support high DPI display
2880         https://bugs.webkit.org/show_bug.cgi?id=196391
2881
2882         Reviewed by Alex Christensen.
2883
2884         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2885         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2886         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2887         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2888
2889 2019-03-31  Sam Weinig  <weinig@apple.com>
2890
2891         Remove more i386 specific configurations
2892         https://bugs.webkit.org/show_bug.cgi?id=196430
2893
2894         Reviewed by Alexey Proskuryakov.
2895
2896         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2897         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2898
2899 2019-03-31  Andy Estes  <aestes@apple.com>
2900
2901         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2902         https://bugs.webkit.org/show_bug.cgi?id=196433
2903         <rdar://problem/49293305>
2904
2905         Reviewed by Tim Horton.
2906
2907         Enhanced API test coverage to include all navigation response policy decisions in both
2908         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2909
2910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2911         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2912         (TestWebKitAPI::TEST):
2913         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2914         (readFile):
2915         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2916         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2917         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2918         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2919         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2920         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2921         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2922         (-[QuickLookDelegate _downloadDidStart:]):
2923         (-[QuickLookDelegate _download:didReceiveResponse:]):
2924         (-[QuickLookDelegate _download:didReceiveData:]):
2925         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2926         (-[QuickLookDelegate _downloadDidFinish:]):
2927         (-[QuickLookDelegate _download:didFailWithError:]):
2928         (-[QuickLookDelegate _downloadDidCancel:]):
2929         (-[QuickLookDelegate verifyDownload]):
2930         (runTest):
2931         (runTestDecideBeforeLoading):
2932         (runTestDecideAfterLoading):
2933         (TEST):
2934         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2935         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2936         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2937         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2938         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2939         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2940         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2941         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2942         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2943         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2944         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2945         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2946         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2947         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2948
2949 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2950
2951         [CMake] add testdfg as target with build-jsc
2952         https://bugs.webkit.org/show_bug.cgi?id=196393
2953
2954         Reviewed by Saam Barati.
2955
2956         Added testdfg as one of the targets to build when
2957         using CMake.
2958
2959         * Scripts/build-jsc:
2960
2961 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2962
2963         Delete WebMetal implementation in favor of WebGPU
2964         https://bugs.webkit.org/show_bug.cgi?id=195418
2965
2966         Reviewed by Dean Jackson.
2967
2968         * DumpRenderTree/mac/DumpRenderTree.mm:
2969         (enableExperimentalFeatures):
2970         (resetWebPreferencesToConsistentValues):
2971         * Scripts/webkitperl/FeatureList.pm:
2972         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2973         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2974         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2975         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2976         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2977         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2978         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2979         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2980         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2981         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2982         (WTR::InjectedBundle::beginTesting):
2983         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2984         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2985         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2986
2987 2019-03-29  Chris Dumez  <cdumez@apple.com>
2988
2989         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2990         https://bugs.webkit.org/show_bug.cgi?id=196405
2991         <rdar://problem/49428130>
2992
2993         Reviewed by Wenson Hsieh.
2994
2995         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2996         the popover presentation methods to be no-ops. Use this in the new test added in
2997         r243523 so that we do not swizzle those methods for all tests. This is needed because
2998         those WatchOS tests rely on the popover getting presented and interactive.
2999
3000         * WebKitTestRunner/TestController.cpp:
3001         (WTR::updateTestOptionsFromTestHeader):
3002         * WebKitTestRunner/TestController.h:
3003         * WebKitTestRunner/TestOptions.h:
3004         (WTR::TestOptions::hasSameInitializationOptions const):
3005         * WebKitTestRunner/ios/TestControllerIOS.mm:
3006         (WTR::TestController::platformInitialize):
3007         (WTR::TestController::platformResetStateToConsistentValues):
3008
3009 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3010
3011         [Curl] Add Server Trust Evaluation Support.
3012         https://bugs.webkit.org/show_bug.cgi?id=191646
3013
3014         Reviewed by Fujii Hironori.
3015
3016         Implemented MiniBrowser UI for asking if user trusts the server.
3017
3018         * MiniBrowser/win/Common.cpp:
3019         (askServerTrustEvaluation):
3020         (replaceString):
3021         * MiniBrowser/win/Common.h:
3022         * MiniBrowser/win/MiniBrowserLib.rc:
3023         * MiniBrowser/win/MiniBrowserLibResource.h:
3024         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3025         (createPEMString):
3026         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3027         (WebKitBrowserWindow::canTrustServerCertificate):
3028         * MiniBrowser/win/WebKitBrowserWindow.h:
3029
3030 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3031
3032         Implement ResizeObserver.
3033         https://bugs.webkit.org/show_bug.cgi?id=157743
3034
3035         Reviewed by Simon Fraser.
3036
3037         Support resizeObserverEnabled webPreferences.
3038
3039         * DumpRenderTree/TestOptions.cpp:
3040         (TestOptions::TestOptions):
3041         * DumpRenderTree/TestOptions.h:
3042         * DumpRenderTree/mac/DumpRenderTree.mm:
3043         (setWebPreferencesForTestOptions):
3044         * DumpRenderTree/win/DumpRenderTree.cpp:
3045         (enableExperimentalFeatures):
3046         * Scripts/webkitperl/FeatureList.pm:
3047         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3048
3049 2019-03-28  John Wilander  <wilander@apple.com>
3050
3051         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3052         https://bugs.webkit.org/show_bug.cgi?id=196281
3053         <rdar://problem/48938748>
3054
3055         Reviewed by Alex Christensen.
3056
3057         This patch adds the function isStatisticsHasLocalStorage() to the
3058         TestRunner. With it, the page can query the WebsiteDataStore in the
3059         UI process to make sure that it sees LocalStorage.
3060
3061         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3062         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3063         (WTR::TestRunner::isStatisticsHasLocalStorage):
3064         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3065         * WebKitTestRunner/TestController.cpp:
3066         (WTR::TestController::isStatisticsHasLocalStorage):
3067         * WebKitTestRunner/TestController.h:
3068         * WebKitTestRunner/TestInvocation.cpp:
3069         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3070
3071 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3072
3073         API::Data::createWithoutCopying should do a null check before calling CFRelease
3074         https://bugs.webkit.org/show_bug.cgi?id=196276
3075         <rdar://problem/48059859>
3076
3077         Reviewed by Alex Christensen.
3078
3079         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3080
3081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3082         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3083         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3084         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3085         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3086         (TestWebKitAPI::TEST):
3087
3088 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3089
3090         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3091         https://bugs.webkit.org/show_bug.cgi?id=186276
3092
3093         Reviewed by Carlos Garcia Campos.
3094
3095         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3096         (webViewLoadChanged):
3097         (testWebResourceGetDataError):
3098         (testWebResourceGetDataEmpty):
3099         (beforeAll):
3100         (webViewloadChanged): Deleted.
3101
3102 2019-03-27  Andy Estes  <aestes@apple.com>
3103
3104         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3105         https://bugs.webkit.org/show_bug.cgi?id=196317
3106
3107         Reviewed by Dan Bernstein.
3108
3109         package-root copies built products into a staging directory using ditto(1), which does not
3110         follow symbolic links as it traverses a directory. Now that the files in
3111         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3112         itself, these become broken links when ditto'd into the staging directory.
3113
3114         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3115
3116         * Scripts/package-root:
3117
3118 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3119
3120         [ews-app] Update display text of Submit for ews analysis
3121         https://bugs.webkit.org/show_bug.cgi?id=196309
3122
3123         Reviewed by Dewei Zhu.
3124
3125         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3126
3127 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3128
3129         run-webkit-tests should check for leaks in WebKit processes
3130         <https://webkit.org/b/193772>
3131         <rdar://problem/46526680>
3132
3133         Reviewed by Ryosuke Niwa.
3134
3135         This works by doing the following:
3136         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3137           The list of child processes are returned one per line:
3138           process.name: pid
3139         - Run the "#LIST CHILD PROCESSES" command just before the
3140           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3141           processes on the ServerProcess object.
3142         - When the `--leaks` switch is handled, run check_for_leaks() on
3143           each child process after the main test harness.
3144
3145         * DumpRenderTree/mac/DumpRenderTree.mm:
3146         (handleControlCommand):
3147         - Use strncmp() instead of strcmp().
3148         - Add support for handling "#LIST CHILD PROCESSES" command.
3149
3150         * Scripts/webkitpy/port/base.py:
3151         (Port.check_for_leaks):
3152         * Scripts/webkitpy/port/darwin.py:
3153         (DarwinPort.check_for_leaks):
3154         - Rename redundant 'process_pid' argument to 'process_id'.
3155
3156         * Scripts/webkitpy/port/driver.py:
3157         (Driver.do_post_tests_work):
3158         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3159           longer the only command this sends to WebKitTestRunner.
3160         - If the `--leaks` switch is present, send the
3161           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3162           result using Port.set_webkit_processes().
3163         (Driver._parse_child_processes_output):
3164         - Add helper method to parse list of child process names and
3165           process IDs returned from WebKitTestRunner.
3166
3167         * Scripts/webkitpy/port/ios_device.py:
3168         (IOSDevicePort.check_for_leaks):
3169         - Rename redundant 'process_pid' argument to 'process_id'.
3170
3171         * Scripts/webkitpy/port/leakdetector.py:
3172         (LeakDetector._parse_leaks_output):
3173         - Return early if there is no leaks_output.
3174         (LeakDetector.check_for_leaks):
3175         - Rename redundant 'process_pid' argument to 'process_id'.
3176
3177         * Scripts/webkitpy/port/server_process.py:
3178         (ServerProcess.__init__):
3179         (ServerProcess.child_processes):
3180         (ServerProcess.set_child_processes):
3181         - Add instance variable to Port to store list of child process
3182           names and process IDs returned from WebKitTestRunner.
3183         (ServerProcess._start):
3184         - Clear self._child_processes.
3185         (ServerProcess.stop):
3186         - If self._child_processes is set, call
3187           self._port.check_for_leaks() for each child process.
3188
3189         * Scripts/webkitpy/port/server_process_unittest.py:
3190         (TrivialMockPort.check_for_leaks):
3191         - Rename redundant 'process_pid' argument to 'process_id'.
3192
3193         * Scripts/webkitpy/port/simulator_process.py:
3194         (SimulatorProcess.stop):
3195         - If self._child_processes is set, call
3196           self._port.check_for_leaks() for each child process.
3197
3198         * Scripts/webkitpy/port/watch_device.py:
3199         (WatchDevicePort.check_for_leaks):
3200         - Rename redundant 'process_pid' argument to 'process_id'.
3201
3202         * WebKitTestRunner/TestController.cpp:
3203         (WTR::TestController::dumpResponse):
3204         - Extract method from findAndDumpWorldLeaks() so that it may be
3205           reused by findAndDumpWebKitProcessIdentifiers().
3206         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3207         - Add method to output process name and process ID of both the
3208           WebContent and Networking processes.
3209         (WTR::TestController::findAndDumpWorldLeaks):
3210         - Fix missing newline in output when there were no abandoned
3211           documents.
3212         - Call dumpResponse() for extracted code.
3213         (WTR::TestController::handleControlCommand):
3214         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3215         - Use strncmp() instead of strcmp().
3216         - Call findAndDumpWebKitProcessIdentifiers() when
3217           "#LIST CHILD PROCESSES" command is sent.
3218         * WebKitTestRunner/TestController.h:
3219         (WTR::TestController::dumpResponse):
3220         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3221         - Declare methods.
3222
3223 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3224
3225         Unreviewed. Add GLib API test cases after r243434.
3226
3227         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3228         (testWebViewActiveURI):
3229         (serverCallback):
3230         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3231         (sendRequestCallback):
3232
3233 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3234
3235         Geolocation request not complete when watch request was started in a different web process
3236         https://bugs.webkit.org/show_bug.cgi?id=195996
3237
3238         Reviewed by Alex Christensen.
3239
3240         Add a test case.
3241
3242         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3243         (TestWebKitAPI::runJavaScriptAlert):
3244         (TestWebKitAPI::TEST):
3245
3246 2019-03-26  Keith Rollin  <krollin@apple.com>
3247
3248         Update the way generate-xcfilelists returns strings from functions
3249         https://bugs.webkit.org/show_bug.cgi?id=195975
3250         <rdar://problem/49040807>
3251
3252         Reviewed by Dean Jackson.
3253
3254         There are places where generate-xcfilelists executes assignments with
3255         statements like:
3256
3257             FOO=$(some_function)
3258
3259         where "some_function" return a string by echoing it. E.g.
3260
3261             some_function()
3262             {
3263                 echo "Hello, World"
3264             }
3265
3266         This is a common idiom, but it has a problem if "some_function" needs
3267         to call "exit" in an attempt to halt the entire script right then and
3268         there. Since "some_function" is called inside of $(), it's being
3269         executed in a sub-shell. Calling exit in that sub-shell simply exits
3270         that shell; it doesn't not exit the outer shell in which the main part
3271         of the script is still running. As such, the main script keeps
3272         executing when the intent was for the script to halt.
3273
3274         The solution to this is to use a different idiom for returning
3275         strings. The one we now is to pass in the name of the variable to
3276         receive the string result:
3277
3278             some_function()
3279             {
3280                 variable_name=$1
3281                 eval $variable_name ="Hello, World"
3282             }
3283
3284         The call site now looks like
3285
3286             some_function FOO
3287
3288         Because there's no invocation of a sub-shell, some_function can now
3289         call "exit" if it wants to, and the entire script will exit at that
3290         point.
3291
3292         * Scripts/generate-xcfilelists:
3293
3294 2019-03-26  Chris Dumez  <cdumez@apple.com>
3295
3296         Add basic layout test coverage for File Picker on iOS
3297         https://bugs.webkit.org/show_bug.cgi?id=196265
3298
3299         Reviewed by Wenson Hsieh.
3300
3301         Add layout test infrastructure to test the file picker on iOS.
3302
3303         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3304         (WTR::UIScriptController::dismissFilePicker):
3305         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3306         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3307         (WTR::UIScriptController::dismissFilePicker):
3308         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3309         * WebKitTestRunner/TestController.cpp:
3310         (WTR::TestController::createWebViewWithOptions):
3311         (WTR::updateTestOptionsFromTestHeader):
3312         * WebKitTestRunner/TestOptions.h:
3313         (WTR::TestOptions::hasSameInitializationOptions const):
3314         * WebKitTestRunner/ios/TestControllerIOS.mm:
3315         (overridePresentViewController):
3316         (WTR::TestController::platformInitialize):
3317         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3318         (WTR::UIScriptController::dismissFilePicker):
3319
3320 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3321
3322         Implement async paste method on UIWKInteractionViewProtocol
3323         https://bugs.webkit.org/show_bug.cgi?id=196267
3324         <rdar://problem/49236346>
3325
3326         Reviewed by Tim Horton.
3327
3328         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
3329         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
3330         are now a part of all iOS 12 internal SDKs.
3331
3332         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3333
3334         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
3335         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
3336
3337         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3338         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3339         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
3340         * TestWebKitAPI/ios/UIKitSPI.h:
3341
3342 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3343
3344         [ews-build] Use PostgreSQL for ews.webkit.org database
3345         https://bugs.webkit.org/show_bug.cgi?id=196270
3346
3347         Reviewed by Lucas Forschler.
3348
3349         * BuildSlaveSupport/ews-app/ews-app/settings.py:
3350
3351 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
3352
3353         [ews] Reset simctl states on reboot
3354         https://bugs.webkit.org/show_bug.cgi?id=196260
3355
3356         Rubber-stamped by Aakash Jain.
3357
3358         * EWSTools/start-queue-mac.sh:
3359
3360 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3361
3362         [ews-build] Use PostgreSQL for ews-build database
3363         https://bugs.webkit.org/show_bug.cgi?id=196229
3364
3365         Reviewed by Lucas Forschler.
3366
3367         * BuildSlaveSupport/ews-build/master.cfg:
3368
3369 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3370
3371         [ews-build] Get master_hostname dynamically in master.cfg
3372         https://bugs.webkit.org/show_bug.cgi?id=196255
3373
3374         Reviewed by Lucas Forschler.
3375
3376         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
3377         send events data in test mode.
3378
3379 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3380
3381         [ews-app] Set db_constraint to False for Foreign Keys
3382         https://bugs.webkit.org/show_bug.cgi?id=196252
3383
3384         Reviewed by Lucas Forschler.
3385
3386         * BuildSlaveSupport/ews-app/ews/models/build.py:
3387         * BuildSlaveSupport/ews-app/ews/models/step.py:
3388
3389 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3390
3391         [ews-build] is_test_mode_enabled should default to True
3392         https://bugs.webkit.org/show_bug.cgi?id=196248
3393
3394         Reviewed by Lucas Forschler.
3395
3396         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
3397
3398 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3399
3400         [ews-app] Add webkitperl to ENABLED_QUEUES
3401         https://bugs.webkit.org/show_bug.cgi?id=196253
3402
3403         Reviewed by Lucas Forschler.
3404
3405         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3406
3407 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
3408
3409         Address NSWindow sometimes using WebKitTestRunnerEvent too early
3410         https://bugs.webkit.org/show_bug.cgi?id=196211
3411         rdar://problem/49110552
3412
3413         Reviewed by Tim Horton.
3414
3415         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
3416         Make sure that EventSenderProxy always exists when running tests. We used to create
3417         it when resetting before the first test, which is a bit too late.
3418
3419         * WebKitTestRunner/TestController.h:
3420         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3421         (WTR::TestController::platformCreateWebView):
3422         (WTR::TestController::platformCreateOtherPage):
3423         (WTR::TestController::finishCreatingPlatformWebView):
3424         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3425         (WTR::PlatformWebView::PlatformWebView):
3426         Moved some code that made NSWindow use NSEvent during web view creation. We may
3427         need to move more if some other case us found, but this is enough for now.
3428
3429 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3430
3431         Unreviewed. Fix typo in GLib geolocation API after r243285.
3432
3433         gelocation -> geolocation.
3434
3435         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
3436         (testGeolocationManagerWatchPosition):
3437
3438 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3439
3440         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3441         https://bugs.webkit.org/show_bug.cgi?id=196213
3442
3443         Reviewed by Geoff Garen.
3444
3445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3446         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3447         (credentialWithIdentityAndKeychainPath):
3448         (-[ChallengeDelegate webView:didFinishNavigation:]):
3449         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3450         (TestWebKitAPI::TEST):
3451
3452 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3453
3454         Expected shouldn't assume its contained types are copyable
3455         https://bugs.webkit.org/show_bug.cgi?id=195986
3456
3457         Reviewed by JF Bastien.
3458
3459         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3460         (TestWebKitAPI::NonCopyable::operator== const):
3461         (TestWebKitAPI::NonCopyable::operator!= const):
3462         (TestWebKitAPI::TEST):
3463
3464 2019-03-25  Tim Horton  <timothy_horton@apple.com>
3465
3466         Remove some now-unnecessary dynamic class lookup
3467         https://bugs.webkit.org/show_bug.cgi?id=196237
3468
3469         Reviewed by Simon Fraser.
3470
3471         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3472         (makeRequest):
3473         (TEST):
3474
3475 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
3476
3477         Unreviewed, rolling out r243450.
3478
3479         AppleWin and WinCairo port builds get broken.
3480
3481         Reverted changeset:
3482
3483         "Add test for fix of #196095"
3484         https://bugs.webkit.org/show_bug.cgi?id=196097
3485         https://trac.webkit.org/changeset/243450
3486
3487 2019-03-25  Commit Queue  <commit-queue@webkit.org>
3488
3489         Unreviewed, rolling out r243465.
3490         https://bugs.webkit.org/show_bug.cgi?id=196226
3491
3492         the test doesn't build (Requested by thorton on #webkit).
3493
3494         Reverted changeset:
3495
3496         "Do not terminate the NetworkProcess if a third party
3497         application sends a NSCredential with a SecIdentityRef"
3498         https://bugs.webkit.org/show_bug.cgi?id=196213
3499         https://trac.webkit.org/changeset/243465
3500
3501 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3502
3503         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3504         https://bugs.webkit.org/show_bug.cgi?id=196213
3505
3506         Reviewed by Geoff Garen.
3507
3508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3509         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3510         (credentialWithIdentityAndKeychainPath):
3511         (-[ChallengeDelegate webView:didFinishNavigation:]):
3512         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3513         (TestWebKitAPI::TEST):
3514
3515 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3516
3517         [ews-build] Gracefully handle missing patch_id in events
3518         https://bugs.webkit.org/show_bug.cgi?id=196216
3519
3520         Reviewed by Lucas Forschler.
3521
3522         * BuildSlaveSupport/ews-build/events.py:
3523
3524 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3525
3526         [ews-build] use lz4 compression for improving buildbot performance
3527         https://bugs.webkit.org/show_bug.cgi?id=196155
3528
3529         Reviewed by Lucas Forschler.
3530
3531         * BuildSlaveSupport/ews-build/master.cfg:
3532
3533 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3534
3535         Pull some API testing helper methods out of TestWKWebView
3536         https://bugs.webkit.org/show_bug.cgi?id=196212
3537
3538         Reviewed by Tim Horton.
3539
3540         Refactor some more API testing utility methods, so that they can be used in
3541         tests that do not use TestWKWebView.
3542
3543         * TestWebKitAPI/cocoa/TestWKWebView.h:
3544         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3545         (-[WKWebView loadTestPageNamed:]):
3546         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
3547         (-[WKWebView synchronouslyLoadHTMLString:]):
3548         (-[WKWebView synchronouslyLoadTestPageNamed:]):
3549         (-[TestWKWebView loadTestPageNamed:]): Deleted.
3550         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
3551         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
3552         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
3553
3554 2019-03-25  Jer Noble  <jer.noble@apple.com>
3555
3556         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3557         https://bugs.webkit.org/show_bug.cgi?id=196097
3558
3559         Reviewed by Eric Carlson.
3560
3561         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3562
3563         * DumpRenderTree/mac/DumpRenderTree.mm:
3564         (resetWebPreferencesToConsistentValues):
3565         * WebKitTestRunner/TestController.cpp:
3566         (WTR::TestController::resetPreferencesToConsistentValues):
3567
3568 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3569
3570         Pull IPadUserInterfaceSwizzler out into a separate header file
3571         https://bugs.webkit.org/show_bug.cgi?id=196193
3572
3573         Reviewed by Anders Carlsson.
3574
3575         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
3576         be used in other API tests.
3577
3578         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3579         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3580         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
3581         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
3582         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
3583         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3584         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3585
3586 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3587
3588         Remove NavigatorContentUtils in WebCore/Modules
3589         https://bugs.webkit.org/show_bug.cgi?id=196070
3590
3591         Reviewed by Alex Christensen.
3592
3593         NavigatorContentUtils was to support the custom scheme spec [1].
3594         However, in WebKit side, no port has supported the feature in
3595         WebKit layer after EFL port was removed. So there has been the
3596         only IDL implementation of the NavigatorContentUtils in WebCore.
3597         So we don't need to keep the implementation in WebCore anymore.
3598
3599         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
3600
3601         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3602
3603 2019-03-24  Andy Estes  <aestes@apple.com>
3604
3605         [watchOS] Remove unused Proximity Networking code
3606         https://bugs.webkit.org/show_bug.cgi?id=196188
3607
3608         Reviewed by Tim Horton.
3609
3610         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3611         (TEST):
3612
3613 2019-03-23  Keith Miller  <keith_miller@apple.com>
3614
3615         Refactor clz/ctz and fix getLSBSet.
3616         https://bugs.webkit.org/show_bug.cgi?id=196162
3617
3618         Reviewed by Saam Barati.
3619
3620         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3621
3622         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3623         (TestWebKitAPI::TEST):
3624
3625 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3626
3627         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3628         https://bugs.webkit.org/show_bug.cgi?id=196143
3629
3630         Reviewed by Michael Catanzaro.
3631
3632         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3633         directories.
3634
3635         * Scripts/webkitpy/style/checkers/cpp.py:
3636         (check_identifier_name_in_declaration):
3637         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3638         (WebKitStyleTest.test_names):
3639
3640 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3641
3642         [Flatpak] Manifest expanding fails for qt WPE extension
3643         https://bugs.webkit.org/show_bug.cgi?id=196148
3644
3645         Reviewed by Alex Christensen.
3646
3647         * flatpak/flatpakutils.py:
3648         (expand_submodules_recurse): The last recurse manifest expand
3649         iteration might lead to a single module so take it into account
3650         and don't try to recurse further.
3651
3652 2019-03-22  Chris Dumez  <cdumez@apple.com>
3653
3654         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3655         https://bugs.webkit.org/show_bug.cgi?id=195348
3656         <rdar://problem/48622090>
3657
3658         Reviewed by Alex Christensen.
3659
3660         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3661         to NO when test.options().shouldIgnoreMetaViewport is false.
3662
3663         * WebKitTestRunner/ios/TestControllerIOS.mm:
3664         (WTR::TestController::platformConfigureViewForTest):
3665
3666 2019-03-22  Chris Dumez  <cdumez@apple.com>
3667
3668         Prewarmed processes should be usable with any website data store
3669         https://bugs.webkit.org/show_bug.cgi?id=196104
3670
3671         Reviewed by Alex Christensen.
3672
3673         Add API test coverage.
3674
3675         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3676         (runInitialWarmedProcessUsedTest):
3677         (TEST):
3678
3679 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3680
3681         Back out local changes to Alex's Subversion working directory
3682
3683         They were accidentally committed.
3684
3685         * Scripts/webkitpy/common/system/abstractexecutive.py:
3686         (AbstractExecutive.wait_newest):
3687         * Scripts/webkitpy/common/system/executive.py:
3688         (Executive.running_pids):
3689         * Scripts/webkitpy/common/system/executive_mock.py:
3690         (MockExecutive.running_pids):
3691         * Scripts/webkitpy/common/system/executive_unittest.py:
3692         (ExecutiveTest.serial_test_running_pids):
3693         * Scripts/webkitpy/port/darwin.py:
3694         (DarwinPort.check_for_leaks):
3695         * Scripts/webkitpy/port/leakdetector.py:
3696         (LeakDetector.check_for_leaks):
3697         - This was the hack attached to Bug 193772.
3698
3699         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3700         (+[WebKitTestRunnerEvent mouseLocation]):
3701         - This works around a crash on an internal build.
3702
3703 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3704
3705         Fix the build after r243354
3706         https://bugs.webkit.org/show_bug.cgi?id=196138
3707         <rdar://problem/49145951>
3708
3709         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3710         (TEST):
3711         * TestWebKitAPI/ios/UIKitSPI.h:
3712
3713 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3714
3715         Adopt UIWKDocumentContext
3716         https://bugs.webkit.org/show_bug.cgi?id=196040
3717         <rdar://problem/48642440>
3718
3719         Reviewed by Ryosuke Niwa.
3720
3721         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3722         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3723         (makeRequest):
3724         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3725         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3726         (applyStyle):
3727         (TEST):
3728         Add tests for UIWKDocumentContext.
3729
3730         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3731         (TEST):
3732         (recursiveFindWKContentView): Deleted.
3733         * TestWebKitAPI/cocoa/TestWKWebView.h:
3734         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3735         (recursiveFindWKContentView):
3736         (-[TestWKWebView wkContentView]):
3737         * TestWebKitAPI/ios/UIKitSPI.h:
3738         Share the WKContentView finding code between tests.
3739
3740 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3741
3742         [iOS WK2] Turn on async overflow scrolling by default
3743         https://bugs.webkit.org/show_bug.cgi?id=196011
3744         rdar://problem/48453859
3745
3746         Reviewed by Antti Koivisto.
3747         
3748         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3749         since so many basic layout tests have different results when compositing is triggered for
3750         overflow.
3751         
3752         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3753
3754         * WebKitTestRunner/TestController.cpp:
3755         (WTR::TestController::resetPreferencesToConsistentValues):
3756
3757 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3758
3759         [ews-build] Retry API test in case of failures
3760         https://bugs.webkit.org/show_bug.cgi?id=196004
3761
3762         Reviewed by Lucas Forschler.
3763
3764         * BuildSlaveSupport/ews-build/steps.py:
3765         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3766         (CompileWebKitToT.doStepIf): Ditto.
3767         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3768         (ReRunAPITests): Re-run API tests.
3769         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3770         (RunAPITestsWithoutPatch): Run API tests without patch.
3771         (RunAPITestsWithoutPatch.doStepIf):
3772         (RunAPITestsWithoutPatch.hideStepIf):
3773         (RunAPITestsWithoutPatch.evaluateCommand):
3774         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3775         (AnalyzeAPITestsResults.start):
3776         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3777         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3778         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3779         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3780
3781 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3782
3783         [ews-build] Update queues configurations
3784         https://bugs.webkit.org/show_bug.cgi?id=196074
3785
3786         Reviewed by Dewei Zhu.
3787
3788         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3789         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3790
3791 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3792
3793         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3794         https://bugs.webkit.org/show_bug.cgi?id=195680
3795         <rdar://problem/48903534>
3796
3797         Unreviewed infrastructure fix.
3798
3799         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3800         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3801
3802 2019-03-21  Andy Estes  <aestes@apple.com>
3803
3804         [iOS] Apple Pay should be available in documents with no user agent scripts
3805         https://bugs.webkit.org/show_bug.cgi?id=196061
3806         <rdar://problem/48649391>
3807
3808         Reviewed by Brady Eidson.
3809
3810         Added API tests and related infrastructure.
3811
3812         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3813         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3814         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3815         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3816         (TestWebKitAPI::TEST):
3817         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3818         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3819         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3820         * TestWebKitAPI/cocoa/TestProtocol.mm:
3821         (-[TestProtocol startLoading]):
3822         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3823         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3824         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3825         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3826
3827 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3828
3829         REGRESSSION (r243297): webkitpy tests broken
3830         https://bugs.webkit.org/show_bug.cgi?id=196108
3831
3832         Reviewed by Aakash Jain.
3833
3834         r243297 updated contributors.json, which broke a few unit tests.
3835
3836         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3837         (IRCCommandTest.test_whois):
3838         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3839
3840 2019-03-21  Chris Dumez  <cdumez@apple.com>
3841
3842         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3843         https://bugs.webkit.org/show_bug.cgi?id=196041
3844         <rdar://problem/49083230>
3845
3846         Reviewed by Alex Christensen.
3847
3848         Add API test coverage.
3849
3850         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3851         (TEST):
3852
3853 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3854
3855         Add SPI to inform applications of WKContentRuleList actions
3856         https://bugs.webkit.org/show_bug.cgi?id=195965
3857         <rdar://problem/42664365>
3858
3859         Reviewed by Geoff Garen.
3860
3861         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3862         (TestWebKitAPI::allActionsForResourceLoad):
3863         (TestWebKitAPI::testRequest):
3864         (TestWebKitAPI::TEST_F):
3865         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3866         (Notification::description):
3867         (Notification::operator== const):
3868         (toVector):
3869         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3870         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3871         (makeContentRuleList):
3872         (TEST):
3873         (makeWarnContentRuleList): Deleted.
3874
3875 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3876
3877         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3878         https://bugs.webkit.org/show_bug.cgi?id=196088
3879
3880         Reviewed by Brian Burg.
3881
3882         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3883         Support checks when only one platform is specified. Also deprecate macosx() and
3884         force the use of macos() instead.
3885
3886         * Scripts/webkitpy/style/checkers/cpp.py:
3887         (check_min_versions_of_wk_api_available):
3888         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3889         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3890
3891 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3892
3893         Update status inactive committers' status to 'contributor'.
3894
3895         * Scripts/webkitpy/common/config/contributors.json:
3896
3897 2019-03-21  Xan Lopez  <xan@igalia.com>
3898
3899         [JSC][x86] Drop support for x87 floating point
3900         https://bugs.webkit.org/show_bug.cgi?id=194853
3901
3902         Reviewed by Don Olmstead.
3903
3904         Force SSE2 on x86/32bit builds.
3905
3906         * Scripts/webkitdirs.pm:
3907         (generateBuildSystemFromCMakeProject):
3908
3909 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3910
3911         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3912         https://bugs.webkit.org/show_bug.cgi?id=196073
3913
3914         Reviewed by Michael Catanzaro.
3915
3916         Add test cases to check functions and constructors with no arguments but receiving user data.
3917
3918         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3919         (checkUserData):
3920         (testJSCFunction):
3921         (fooCreateWithUserData):
3922         (testJSCClass):
3923
3924 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3925
3926         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3927
3928         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3929
3930         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3931
3932 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3933
3934         [GTK][WPE] Add API to provide geolocation information
3935         https://bugs.webkit.org/show_bug.cgi?id=195940
3936
3937         Reviewed by Michael Catanzaro.
3938
3939         Add a new test to check the new API.
3940
3941         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3942         (testGeolocationManagerCurrentPosition):
3943         (testGeolocationManagerWatchPosition):
3944         (beforeAll):
3945         (afterAll):
3946         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3947         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3948         (beforeAll): Ditto.
3949         * TestWebKitAPI/glib/CMakeLists.txt:
3950
3951 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3952
3953         [GLib] Returning G_TYPE_OBJECT from a method does not work
3954         https://bugs.webkit.org/show_bug.cgi?id=195574
3955
3956         Reviewed by Michael Catanzaro.
3957
3958         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3959
3960         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3961         (getGFile):
3962         (getParent):
3963         (createGString):
3964         (getGString):
3965         (getGStringCopyWillRaise):
3966         (getGStringCopy):
3967         (getGStringStr):
3968         (getGStringLen):
3969         (freeGString):
3970         (testJSCClass):
3971
3972 2019-03-20  Saam Barati  <sbarati@apple.com>
3973
3974         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3975         https://bugs.webkit.org/show_bug.cgi?id=195721
3976
3977         Reviewed by Filip Pizlo.
3978
3979         * Scripts/run-javascriptcore-tests:
3980
3981 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3982
3983         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3984         https://bugs.webkit.org/show_bug.cgi?id=196049
3985
3986         Reviewed by Tim Horton.
3987
3988         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3989         overflow scrolling in general, so rename it.
3990
3991         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3992
3993 2019-03-20  Daniel Bates  <dabates@apple.com>
3994
3995         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3996         https://bugs.webkit.org/show_bug.cgi?id=196031
3997         <rdar://problem/49078172>
3998
3999         Reviewed by Tim Horton.
4000
4001         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
4002         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
4003         same code path used when the Done button is pressed to dismiss the <select> picker.
4004
4005         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
4006         (TestWebKitAPI::TEST):
4007
4008 2019-03-20  Chris Dumez  <cdumez@apple.com>
4009
4010         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
4011         https://bugs.webkit.org/show_bug.cgi?id=196029
4012         <rdar://problem/48954651>
4013
4014         Reviewed by Tim Horton.
4015
4016         Add API test coverage.
4017
4018         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4019
4020 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
4021
4022         [ews-build] Improve failure summary string for ApplyPatch step
4023         https://bugs.webkit.org/show_bug.cgi?id=195995
4024
4025         Reviewed by Alexey Proskuryakov.
4026
4027         * BuildSlaveSupport/ews-build/steps.py:
4028         (ApplyPatch.getResultSummary): Override getResultSummary.
4029
4030 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
4031
4032         AX: Implement support for new meter ARIA role
4033         https://bugs.webkit.org/show_bug.cgi?id=195966
4034
4035         Reviewed by Chris Fleizach.
4036
4037         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
4038         to AXLevelIndicator.
4039
4040         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4041
4042 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
4043
4044         [WebAuthN] Implement FIDO AppID extension
4045         https://bugs.webkit.org/show_bug.cgi?id=143491
4046         <rdar://problem/48298273>
4047
4048         Reviewed by Brent Fulgham.
4049
4050         Add a test that covers the new flag of convertToU2fSignCommand.
4051
4052         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
4053         (TestWebKitAPI::TEST):
4054         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
4055         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
4056         (TestWebKitAPI::TEST):
4057
4058 2019-03-19  Keith Rollin  <krollin@apple.com>
4059
4060         Add support for more platforms to generate-xcfilelists
4061         https://bugs.webkit.org/show_bug.cgi?id=195977
4062
4063         Reviewed by Alexey Proskuryakov.
4064
4065         generate-xcfilelists incorrectly complains when involved with building
4066         WebKit for iphonesimulator:
4067
4068             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
4069             …
4070             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
4071
4072         Address this by teaching generate-xcfilelists about more platforms.
4073
4074         * Scripts/generate-xcfilelists:
4075
4076 2019-03-19  John Wilander  <wilander@apple.com>
4077
4078         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
4079         https://bugs.webkit.org/show_bug.cgi?id=195923
4080         <rdar://problem/49001272>
4081
4082         Reviewed by Alex Christensen.
4083
4084         This patch does the following to the TestRunner:
4085         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
4086         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
4087         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
4088
4089         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4090         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4091         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
4092         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4093         * WebKitTestRunner/TestController.cpp:
4094         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
4095         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
4096         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
4097         * WebKitTestRunner/TestController.h:
4098         * WebKitTestRunner/TestInvocation.cpp:
4099         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4100
4101 2019-03-19  Christopher Reid  <chris.reid@sony.com>
4102
4103         [CMake] Support more clang and gcc sanitizers
4104         https://bugs.webkit.org/show_bug.cgi?id=195956
4105
4106         Reviewed by Michael Catanzaro.
4107
4108         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
4109
4110 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
4111
4112         [ews-build] Improve summary for PrintConfiguration step
4113         https://bugs.webkit.org/show_bug.cgi?id=195945
4114
4115         Reviewed by Lucas Forschler.
4116
4117         * BuildSlaveSupport/ews-build/steps.py:
4118         (PrintConfiguration.getResultSummary): Override getResultSummary.
4119
4120 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
4121
4122         [ews-build] Improve summary for CheckOutSource step
4123         https://bugs.webkit.org/show_bug.cgi?id=195963
4124
4125         Reviewed by Lucas Forschler.
4126
4127         * BuildSlaveSupport/ews-build/steps.py:
4128         (CheckOutSource.getResultSummary):
4129
4130 2019-03-19  Daniel Bates  <dabates@apple.com>
4131
4132         [iOS] Focus not preserved when switching between tabs
4133         https://bugs.webkit.org/show_bug.cgi?id=195820
4134         <rdar://problem/43614450>
4135
4136         Reviewed by Brent Fulgham.
4137
4138         Add tests to ensure that we restore focus when resigning and becoming first responder.
4139
4140         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4141         (TestWebKitAPI::TEST):
4142
4143 2019-03-19  Alex Christensen  <achristensen@webkit.org>
4144
4145         Make WTFLogChannelState and WTFLogLevel enum classes
4146         https://bugs.webkit.org/show_bug.cgi?id=195904
4147
4148         Reviewed by Eric Carlson.
4149
4150         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
4151         (TestWebKitAPI::TEST_F):
4152
4153 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
4154
4155         [GStreamer][EME] Backported mssdemux protection data crash fix
4156         https://bugs.webkit.org/show_bug.cgi?id=195918
4157
4158         Reviewed by Philippe Normand.
4159
4160         * gstreamer/jhbuild.modules:
4161         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
4162
4163 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
4164
4165         Unreviewed, rolling out r243132.
4166
4167         Broke GTK build
4168
4169         Reverted changeset:
4170
4171         "Make WTFLogChannelState and WTFLogLevel enum classes"
4172         https://bugs.webkit.org/show_bug.cgi?id=195904
4173         https://trac.webkit.org/changeset/243132
4174
4175 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
4176
4177         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
4178
4179         * Scripts/webkitdirs.pm:
4180         (builtDylibPathForName): Adjust the shared library name that's changed
4181         with the API version bump in r243073.
4182
4183 2019-03-18  Alex Christensen  <achristensen@webkit.org>
4184
4185         Make WTFLogChannelState and WTFLogLevel enum classes
4186         https://bugs.webkit.org/show_bug.cgi?id=195904
4187
4188         Reviewed by Eric Carlson.
4189
4190         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
4191         (TestWebKitAPI::TEST_F):
4192
4193 2019-03-18  Alex Christensen  <achristensen@webkit.org>
4194
4195         Disable flaky test added in r2431100
4196         https://webkit.org/b/195785
4197
4198         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4199         (TestWebKitAPI::TEST):
4200         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
4201
4202 2019-03-18  Timothy Hatcher  <timothy@apple.com>
4203
4204         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
4205         https://bugs.webkit.org/show_bug.cgi?id=195916
4206
4207         Reviewed by Tim Horton.
4208
4209         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
4210         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
4211
4212 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
4213
4214         Add a secondary e-mail address for Fujii Hironori to make tools happier.
4215
4216         * Scripts/webkitpy/common/config/contributors.json:
4217
4218 2019-03-18  Alex Christensen  <achristensen@webkit.org>
4219
4220         Implement DownloadMonitor to prevent long-running slow downloads from background apps
4221         https://bugs.webkit.org/show_bug.cgi?id=195785
4222
4223         Reviewed by Geoffrey Garen.
4224
4225         * TestWebKitAPI/TCPServer.cpp: Added.
4226         (TestWebKitAPI::TCPServer::TCPServer):
4227         (TestWebKitAPI::TCPServer::~TCPServer):
4228         (TestWebKitAPI::TCPServer::socketBindListen):
4229         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
4230         * TestWebKitAPI/TCPServer.h: Added.
4231         (TestWebKitAPI::TCPServer::port const):
4232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4233         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4234         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
4235         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
4236         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4237         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
4238         (TestWebKitAPI::respondSlowly):
4239         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
4240         (TestWebKitAPI::downloadAtRate):
4241         (TestWebKitAPI::TEST):
4242
4243 2019-03-18  Saam Barati  <sbarati@apple.com>
4244
4245         Add a plan file for JetStream 2
4246         https://bugs.webkit.org/show_bug.cgi?id=190734
4247
4248         Reviewed by Mark Lam.
4249
4250         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
4251
4252 2019-03-18  Chris Dumez  <cdumez@apple.com>
4253
4254         Delay WebProcess launch until a load is triggered in a Web view
4255         https://bugs.webkit.org/show_bug.cgi?id=195758
4256         <rdar://problem/48126013>
4257
4258         Reviewed by Geoff Garen.
4259
4260         Add API test coverage. Also update some existing API tests to not expect
4261         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
4262
4263         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
4264         (TestWebKitAPI::TEST):
4265         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
4266         (TestWebKitAPI::TEST):
4267         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
4268         (TEST):
4269         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4270         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
4271         (TEST):
4272         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
4273         (TEST):
4274         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
4275
4276 2019-03-18  Xan Lopez  <xan@igalia.com>
4277
4278         [CMake] Prevent potential warning when determining $architecture
4279         https://bugs.webkit.org/show_bug.cgi?id=195891
4280
4281         Reviewed by Michael Catanzaro.
4282
4283         It's possible for generateBuildSystemForCMakeProject to be called
4284         before determineArchitecture() is ever called. This will make the
4285         first eq check with $architecture to be bogus (and print a
4286         warning). Change that to an eq check with architecture(), which
4287         implicitly calls determineArchitecture() if needed, and change all
4288         the other similar cases in the method in the same way to prevent
4289         future bugs like this one.
4290
4291         * Scripts/webkitdirs.pm:
4292         (generateBuildSystemFromCMakeProject):
4293
4294 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
4295
4296         [WPE] Tarballs generated with “make dist” cannot build documentation
4297         https://bugs.webkit.org/show_bug.cgi?id=195885
4298
4299         Reviewed by Carlos Garcia Campos.
4300
4301         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
4302
4303 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
4304
4305         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
4306         https://bugs.webkit.org/show_bug.cgi?id=195883
4307
4308         Reviewed by Carlos Garcia Campos.
4309
4310         * gtkdoc/gtkdoc.py:
4311         (GTKDoc._run_command): When commands fail to run, include the full command line for
4312         the program invocation and the output it has generated on the standard error stream.
4313
4314 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
4315
4316         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
4317         https://bugs.webkit.org/show_bug.cgi?id=195786
4318
4319         Reviewed by Philippe Normand.
4320
4321         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.