newcommitbot (WKR) requires a subversion checkout
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
2
3         newcommitbot (WKR) requires a subversion checkout
4         https://bugs.webkit.org/show_bug.cgi?id=114309
5
6         Reviewed by Benjamin Poulain.
7
8         Directly talk to the subversion server instead of relying on a local checkout.
9         This allows us to run WKR off of a git clone.
10
11         * Scripts/webkitpy/tool/commands/newcommitbot.py:
12         (NewCommitBot.next_work_item):
13         (NewCommitBot.process_work_item):
14
15 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
16
17         webkitbot refers to sheriffbot in help
18         https://bugs.webkit.org/show_bug.cgi?id=114307
19
20         Reviewed by Benjamin Poulain.
21
22         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
23
24         * Scripts/webkitpy/tool/bot/irc_command.py:
25         (Help):
26         (Help.execute):
27         (RollChromiumDEPS.execute):
28         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
29         (IRCBotTest.test_help):
30         * Scripts/webkitpy/tool/bot/sheriff.py:
31         (Sheriff.name):
32
33 2013-04-06  Roger Fong  <roger_fong@apple.com>
34
35         Kill old processes between runs on WinEWS bots.
36         Temporarily disable tests to let bots catch up again.
37
38         * EWSTools/start-queue-win.sh:
39         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
40         (WinEWS):
41
42 2013-04-09  Glenn Adams  <glenn@skynav.com>
43
44         [webkitpy] Remove chromium deprecated port support.
45         https://bugs.webkit.org/show_bug.cgi?id=114228
46
47         Reviewed by Ryosuke Niwa.
48
49         * Scripts/webkitpy/common/config/ports.py:
50         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
51         (ChromiumPort): Removed.
52         (ChromiumAndroidPort): Removed.
53         (ChromiumXVFBPort): Removed.
54         * Scripts/webkitpy/common/config/ports_unittest.py:
55         (DeprecatedPortTest.test_chromium_port): Removed.
56         (DeprecatedPortTest.test_chromium_android_port): Removed.
57         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
58         * Scripts/webkitpy/tool/steps/update_unittest.py:
59         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
60         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
61
62 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
63
64         AX: The bounding paths should be made available through accessibility
65         https://bugs.webkit.org/show_bug.cgi?id=113817
66
67         Reviewed by David Kilzer.
68
69         Add a pathDescription property for testing so that it's possible
70         to verify that a path is being returned correctly.
71
72         * DumpRenderTree/AccessibilityUIElement.cpp:
73         (getPathDescriptionCallback):
74         (AccessibilityUIElement::pathDescription):
75         (AccessibilityUIElement::getJSClass):
76         * DumpRenderTree/AccessibilityUIElement.h:
77         (AccessibilityUIElement):
78         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
79         (_CGPathEnumerationIteration):
80         (AccessibilityUIElement::pathDescription):
81         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
82         (AccessibilityUIElement::pathDescription):
83         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
84         (WTR::AccessibilityUIElement::pathDescription):
85         (WTR):
86         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
87         (AccessibilityUIElement):
88         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
89         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
90         (WTR::AccessibilityUIElement::pathDescription):
91         (WTR):
92
93 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
94
95         [EFL] Declare TEST_THEME_DIR in a single place.
96         https://bugs.webkit.org/show_bug.cgi?id=114285
97
98         Reviewed by Anders Carlsson.
99
100         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
101
102         * DumpRenderTree/efl/CMakeLists.txt:
103         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
104         (DumpRenderTreeChrome::createView):
105         (DumpRenderTreeChrome::createInspectorView):
106         (DumpRenderTreeChrome::initialize):
107         (DumpRenderTreeChrome::onDownloadRequest):
108         * EWebLauncher/CMakeLists.txt:
109         * EWebLauncher/main.c:
110         (findThemePath):
111         * EWebLauncher/url_bar.c:
112         (url_bar_add):
113         * MiniBrowser/efl/CMakeLists.txt:
114         * MiniBrowser/efl/main.c:
115         (window_create):
116         * TestWebKitAPI/PlatformEfl.cmake:
117         * TestWebKitAPI/efl/PlatformWebView.cpp:
118         (TestWebKitAPI::PlatformWebView::PlatformWebView):
119         * WebKitTestRunner/PlatformEfl.cmake:
120         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
121         (WTR::PlatformWebView::PlatformWebView):
122
123 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
124
125         [GTK][AC] upversion of clutter and its dependecy
126         https://bugs.webkit.org/show_bug.cgi?id=114016
127
128         Reviewed by Gustavo Noronha Silva.
129
130         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
131
132         * gtk/jhbuild-optional.modules:
133
134 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
135
136         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
137         https://bugs.webkit.org/show_bug.cgi?id=89875
138
139         Reviewed by Maciej Stachowiak.
140
141         Add unit tests to verify if the handling of the open, openat, creat syscall
142         is being done right. We check if the Read/Write/ReadAndWrite permissions
143         are respected, if the canonical path is being resolved and if
144         the permissions are falling back to the topmost parent directory with a
145         policy set when the directory being opened has no policy.
146
147         We also test if any attempt of blocking SIGSYS is silently ignored.
148         SIGSYS cannot be blocked because in it's handler is where we hook
149         syscalls to the broker process.
150
151         Also added libseccomp to EFL's jhbuild to make the life of developers
152         willing to help easier.
153
154         * Scripts/webkitperl/FeatureList.pm:
155         * TestWebKitAPI/PlatformEfl.cmake:
156         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
157         (TestWebKitAPI):
158         (SeccompEnvironment):
159         (TestWebKitAPI::SeccompEnvironment::SetUp):
160         (TestWebKitAPI::SeccompEnvironment::TearDown):
161         (TestWebKitAPI::dummyHandler):
162         (TestWebKitAPI::TEST):
163         (TestWebKitAPI::stressTest):
164         * efl/jhbuild.modules:
165         * qmake/mkspecs/features/features.pri:
166
167 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
168
169         REGRESSION: Autocorrection doesn't work in DumpRenderTree
170         https://bugs.webkit.org/show_bug.cgi?id=113846
171
172         Reviewed by Alexey Proskuryakov.
173
174         The problem was that we were replacing NSSpellCheck's dictionary with our own
175         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
176
177         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
178         and "would" respectively in DumpRenderTree.
179
180         * DumpRenderTree/mac/DumpRenderTree.mm:
181         (resetDefaultsToConsistentValues):
182
183 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
184
185         Remove the gyp files for Tools
186         https://bugs.webkit.org/show_bug.cgi?id=114248
187
188         Reviewed by Ryosuke Niwa.
189
190         * DumpRenderTree/DumpRenderTree.gyp: Removed.
191         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
192         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
193         * DumpRenderTree/DumpRenderTree.gypi: Removed.
194         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
195         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
196         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
197         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
198
199 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
200
201         WKR (new-commit-bot) is too slow
202         https://bugs.webkit.org/show_bug.cgi?id=110087
203
204         Reviewed by Geoffrey Garen.
205
206         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
207         Just run "svn log -r <revision>" instead to cut down the delay.
208
209         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
210
211         * Scripts/webkitpy/tool/commands/newcommitbot.py:
212         (NewCommitBot):
213         (NewCommitBot.next_work_item):
214         (NewCommitBot._is_empty_log):
215         (NewCommitBot._update_checkout):
216
217 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
218
219         Build fix. Can't remove appendCustomBuildFlags.
220
221         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
222         (appendCustomBuildFlags):
223
224 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
225
226         Remove Chromium builders from build.webkit.org
227         https://bugs.webkit.org/show_bug.cgi?id=113990
228
229         Reviewed by Benjamin Poulain.
230
231         Removed.
232
233         * BuildSlaveSupport/build.webkit.org-config/config.json:
234         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
235         (InstallGtkDependencies):
236         (RunUnitTests.start):
237         (RunWebKit2Tests.start):
238         (Factory.__init__):
239         (unitTestsSupported):
240         (TestFactory.__init__):
241         (BuildAndTestFactory.__init__):
242         (BuildAndPerfTestFactory.__init__):
243         (BuildAndPerfTestWebKit2Factory.__init__):
244         (DownloadAndPerfTestFactory.__init__):
245         (loadBuilderConfig):
246         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
247
248 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
249
250         Remove HTML Notification
251         https://bugs.webkit.org/show_bug.cgi?id=114231
252
253         Reviewed by Ryosuke Niwa.
254
255         * qmake/mkspecs/features/features.pri:
256
257 2013-04-08  Glenn Adams  <glenn@skynav.com>
258
259         Remove chromium EWS support, and fix broken test.
260         https://bugs.webkit.org/show_bug.cgi?id=114221
261
262         Reviewed by Ryosuke Niwa.
263
264         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
265         (AbstractChromiumEWS): Removed.
266         (ChromiumLinuxEWS): Removed.
267         (ChromiumLinuxDebugEWS): Removed.
268         (ChromiumWindowsEWS): Removed.
269         (ChromiumAndroidEWS): Removed.
270         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
271         (EarlyWarningSystemTest): Fix misspelled class name.
272         (test_ewses): Fix entry point name to ensure test is run.
273
274 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
275
276         [WIN] Remove WebKit2 source code
277         https://bugs.webkit.org/show_bug.cgi?id=114096
278
279         Reviewed by Anders Carlsson.
280
281         Remove the windows specific parts of the MiniBrowser.
282
283         * MiniBrowser/MiniBrowser.vcproj: Removed.
284         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
285         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
286         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
287         * MiniBrowser/win/BrowserView.cpp: Removed.
288         * MiniBrowser/win/BrowserView.h: Removed.
289         * MiniBrowser/win/BrowserWindow.cpp: Removed.
290         * MiniBrowser/win/BrowserWindow.h: Removed.
291         * MiniBrowser/win/MiniBrowser.cpp: Removed.
292         * MiniBrowser/win/MiniBrowser.h: Removed.
293         * MiniBrowser/win/MiniBrowser.rc: Removed.
294         * MiniBrowser/win/main.cpp: Removed.
295         * MiniBrowser/win/resource.h: Removed.
296         * MiniBrowser/win/stdafx.cpp: Removed.
297         * MiniBrowser/win/stdafx.h: Removed.
298
299 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
300
301         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
302
303         * Scripts/webkitpy/common/config/irc.py:
304
305 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
306
307         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
308         https://bugs.webkit.org/show_bug.cgi?id=113139
309
310         Reviewed by Anders Carlsson.
311
312         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
313         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
314         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
315         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
316         (ToStringAndValueOfObject):
317         (ToStringAndValueOfObject::ToStringAndValueOfObject):
318         (ScriptableObject):
319         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
320         (ToStringAndValueOfObject::ScriptableObject::invoke):
321         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
322         (ToStringAndValueOfObject::NPP_GetValue):
323         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
324         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
325         * GNUmakefile.am:
326
327 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
328
329         [GTK] Bump gnome-themes-standard to 3.6.0
330         https://bugs.webkit.org/show_bug.cgi?id=114155
331
332         Reviewed by Martin Robinson.
333
334         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
335         dependency of gnome-themes-standard accordingly.
336
337 2013-04-08  David Levin  <levin@chromium.org>
338
339         Remove my watchlist entries.
340         https://bugs.webkit.org/show_bug.cgi?id=114180
341
342         Reviewed by Adam Barth.
343
344         * Scripts/webkitpy/common/config/committers.py:
345         * Scripts/webkitpy/common/config/watchlist:
346
347 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
348
349         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
350         https://bugs.webkit.org/show_bug.cgi?id=114161
351
352         Reviewed by Gyuyoung Kim.
353
354         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
355         as it is crashing due to Bug 111074.
356
357         * TestWebKitAPI/PlatformEfl.cmake:
358
359 2013-04-07  David Kilzer  <ddkilzer@apple.com>
360
361         Remove the rest of SVG_DOM_OBJC_BINDINGS
362         <http://webkit.org/b/114112>
363
364         Reviewed by Geoffrey Garen.
365
366         * Scripts/webkitperl/FeatureList.pm:
367         - Remove --svg-dom-objc-bindings switch.
368         * qmake/mkspecs/features/features.pri:
369         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
370
371 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
372
373         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
374         https://bugs.webkit.org/show_bug.cgi?id=114089
375
376         Reviewed by Chris Fleizach.
377
378         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
379         * DumpRenderTree/AccessibilityController.cpp:
380         * DumpRenderTree/AccessibilityUIElement.cpp:
381         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
382         (DumpRenderTreeChrome::DumpRenderTreeChrome):
383         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
384         (DumpRenderTreeChrome):
385
386 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
387
388         Build fix after r147857, remove remaining USE(JSC) guards.
389
390         Unreviewed.
391
392         * DumpRenderTree/config.h:
393         * TestWebKitAPI/config.h:
394         * WebKitTestRunner/config.h:
395
396 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
397
398         Rename sheriffbot to webkitbot
399         https://bugs.webkit.org/show_bug.cgi?id=114109
400
401         Reviewed by Benjamin Poulain.
402
403         Renamed since sheriffbot will be used in Blink.
404
405         * Scripts/webkitpy/tool/commands/sheriffbot.py:
406         (SheriffBot):
407         (SheriffBot.begin_work_queue):
408
409 2013-04-06  Oliver Hunt  <oliver@apple.com>
410
411         Unify the many and varied stack trace mechanisms, and make the result sane.
412         https://bugs.webkit.org/show_bug.cgi?id=114072
413
414         Reviewed by Filip Pizlo.
415
416         The commandline jsc executable no longer requires arguments, so
417         I've made run-jsc work without them.
418
419         * Scripts/run-jsc:
420
421 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
422
423         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
424         https://bugs.webkit.org/show_bug.cgi?id=114086
425
426         Reviewed by Tim Horton.
427
428         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
429
430 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
431
432         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
433         https://bugs.webkit.org/show_bug.cgi?id=114083
434
435         Reviewed by Ryosuke Niwa.
436
437         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
438         in TestWebKitAPI and WebKitTestRunner.
439
440         * TestWebKitAPI/config.h:
441         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
442         (TestWebKitAPI::InjectedBundleController::platformInitialize):
443         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
444         (WTR::InjectedBundle::platformInitialize):
445
446 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
447
448         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
449         https://bugs.webkit.org/show_bug.cgi?id=114094
450
451         Reviewed by Anders Carlsson.
452
453         * Scripts/run-jsc:
454
455 2013-04-05  Ojan Vafai  <ojan@chromium.org>
456
457         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
458         https://bugs.webkit.org/show_bug.cgi?id=114080
459
460         Reviewed by Ryosuke Niwa.
461
462         This way, the WebKit and Blink dashboard code can change as appropriate without
463         needing to consider the other project's needs. This still doesn't update the
464         buildbots to upload to the new location, or the dashboard code to pull the
465         results.json files from the new location, but it at least allows for changing the
466         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
467
468         * TestResultServer/app.yaml:
469
470 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
471
472         Re-enable testing on the commit queue
473         https://bugs.webkit.org/show_bug.cgi?id=114078
474
475         Reviewed by Darin Adler.
476
477         Re-enabled the feature and the associated tests.
478
479         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
480         (CommitQueueTask.run):
481         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
482         (CommitQueueTaskTest._run_through_task):
483         * Scripts/webkitpy/tool/commands/queues_unittest.py:
484         (CommitQueueTest._mock_test_result):
485
486 2013-04-05  Oliver Hunt  <oliver@apple.com>
487
488         Unify the many and varied stack trace mechanisms, and make the result sane.
489         https://bugs.webkit.org/show_bug.cgi?id=114072
490
491         Reviewed by Filip Pizlo.
492
493         The commandline jsc executable no longer requires arguments, so
494         I've made run-jsc work without them.
495
496         * Scripts/run-jsc:
497
498 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
499
500         AX: Make SVG Group containers accessible elements
501         https://bugs.webkit.org/show_bug.cgi?id=113939
502
503         Reviewed by Simon Fraser.
504
505         Implement axController.elementAtPoint for iOS.
506         Implement a correct version of clickPoint for iOS.
507
508         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
509         (AccessibilityController::elementAtPoint):
510         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
511         (AccessibilityUIElement::clickPointX):
512         (AccessibilityUIElement::clickPointY):
513
514 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
515
516         Unreviewed, rolling out r147773 and r147774.
517         http://trac.webkit.org/changeset/147773
518         http://trac.webkit.org/changeset/147774
519         https://bugs.webkit.org/show_bug.cgi?id=114056
520
521         Causing some exceptions on AppEngine I don't understand
522         (Requested by rniwa on #webkit).
523
524         * QueueStatusServer/config/queues.py:
525         * QueueStatusServer/model/queues.py:
526         (Queue.short_name):
527         (Queue.display_name):
528         * QueueStatusServer/model/queues_unittest.py:
529         (QueueTest.test_short_name):
530         (QueueTest.test_display_name):
531         (QueueTest.test_name_with_underscores):
532
533 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
534
535         Fixed run-bindings-tests by removing V8
536         https://bugs.webkit.org/show_bug.cgi?id=114053
537
538         Reviewed by Benjamin Poulain.
539
540         * Scripts/run-bindings-tests:
541         (main):
542
543 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
544
545         Build fix.
546
547         * QueueStatusServer/model/queues.py:
548         (Queue.short_name):
549         (Queue.display_name):
550
551 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
552
553         Remove Chromium EWS bots from the queue status server
554         https://bugs.webkit.org/show_bug.cgi?id=113988
555
556         Reviewed by Benjamin Poulain.
557
558         Removed Chromium EWS bots.
559
560         * QueueStatusServer/config/queues.py:
561         * QueueStatusServer/model/queues.py:
562         (Queue.short_name):
563         (Queue.display_name):
564         * QueueStatusServer/model/queues_unittest.py:
565         (QueueTest.test_short_name):
566         (QueueTest.test_display_name):
567         (QueueTest.test_name_with_underscores):
568
569 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
570
571         [EFL] Enable indexed database
572         https://bugs.webkit.org/show_bug.cgi?id=107248
573
574         Reviewed by Alexis Menard.
575
576         * Scripts/webkitperl/FeatureList.pm:
577
578 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
579
580         Remove vestiges of Chromium bits from watchlists.
581         https://bugs.webkit.org/show_bug.cgi?id=114047
582
583         Reviewed by Ryosuke Niwa.
584
585         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
586
587 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
588
589         Add James Craig to the contributors list.
590
591         * Scripts/webkitpy/common/config/committers.py:
592
593 2013-04-04  Kent Tamura  <tkent@chromium.org>
594
595         Remove ChromiumPublicApi pattern, and cc/message rules for it.
596
597         * Scripts/webkitpy/common/config/watchlist:
598
599 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
600
601         Temporarily disable the Python unittests broken by the commit queue not running layout tests
602         https://bugs.webkit.org/show_bug.cgi?id=113997
603
604         Reviewed by Ryosuke Niwa.
605
606         Disable the tests until Ryosuke gets the time and hardware to have
607         a testing commit-queue.
608
609         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
610         (CommitQueueTaskTest):
611         * Scripts/webkitpy/tool/commands/queues_unittest.py:
612         (CommitQueueTest):
613
614 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
615
616         Remove Chromium builders from build.webkit.org
617         https://bugs.webkit.org/show_bug.cgi?id=113990
618
619         Reviewed by Benjamin Poulain.
620
621         Land the part to disable triggering of Chromium builders first so that we may start
622         deleting more Chromium code that breaks the update step.
623
624         * BuildSlaveSupport/build.webkit.org-config/config.json:
625
626 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
627
628         Remove Chromium's DumpRenderTree
629         https://bugs.webkit.org/show_bug.cgi?id=113989
630
631         Reviewed by Kent Tamura.
632
633         On second thought, let's not go to Camelot. It is a silly place.
634
635         * DumpRenderTree/mac/DumpRenderTree.mm:
636         (resetDefaultsToConsistentValues):
637
638 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
639
640         Nixed the defunct chromium folder from DumpRenderTree
641         https://bugs.webkit.org/show_bug.cgi?id=113993
642
643         Reviewed by Ryosuke Niwa.
644
645         * DumpRenderTree/chromium: Removed.
646         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
647         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
648         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
649         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
650         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
651         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
652         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
653         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
654         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
655         * DumpRenderTree/chromium/MockPlatform.h: Removed.
656         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
657         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
658         * DumpRenderTree/chromium/Task.cpp: Removed.
659         * DumpRenderTree/chromium/Task.h: Removed.
660         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
661         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
662         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
663         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
664         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
665         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
666         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
667         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
668         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
669         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
670         * DumpRenderTree/chromium/TestRunner: Removed.
671         * DumpRenderTree/chromium/TestRunner/public: Removed.
672         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
673         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
674         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
675         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
676         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
677         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
678         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
679         * DumpRenderTree/chromium/TestRunner/src: Removed.
680         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
681         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
682         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
683         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
684         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
685         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
686         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
687         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
688         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
689         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
690         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
691         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
692         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
693         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
694         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
695         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
696         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
697         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
698         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
699         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
700         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
701         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
702         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
703         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
704         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
705         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
706         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
707         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
708         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
709         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
710         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
711         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
712         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
713         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
714         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
715         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
716         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
717         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
718         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
719         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
720         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
721         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
722         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
723         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
724         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
725         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
726         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
727         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
728         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
729         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
730         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
731         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
732         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
733         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
734         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
735         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
736         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
737         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
738         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
739         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
740         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
741         * DumpRenderTree/chromium/TestShell.cpp: Removed.
742         * DumpRenderTree/chromium/TestShell.h: Removed.
743         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
744         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
745         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
746         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
747         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
748         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
749         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
750         * DumpRenderTree/chromium/WebViewHost.h: Removed.
751         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
752         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
753         * DumpRenderTree/chromium/config.h: Removed.
754         * DumpRenderTree/chromium/fonts.conf: Removed.
755
756 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
757
758         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
759
760         Rubber stamped by Benjamin Poulain.
761
762         * RebaselineQueueServer: Removed.
763         * RebaselineQueueServer/app.yaml: Removed.
764         * RebaselineQueueServer/handlers: Removed.
765         * RebaselineQueueServer/handlers/__init__.py: Removed.
766         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
767         * RebaselineQueueServer/handlers/pages.py: Removed.
768         * RebaselineQueueServer/index.yaml: Removed.
769         * RebaselineQueueServer/main.py: Removed.
770         * RebaselineQueueServer/model: Removed.
771         * RebaselineQueueServer/model/__init__.py: Removed.
772         * RebaselineQueueServer/model/queueentry.py: Removed.
773         * RebaselineQueueServer/static: Removed.
774         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
775         * RebaselineQueueServer/static/styles.css: Removed.
776         * RebaselineQueueServer/templates: Removed.
777         * RebaselineQueueServer/templates/builder-picker.html: Removed.
778         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
779         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
780         * RebaselineQueueServer/templates/home.html: Removed.
781
782 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
783
784         Fix setup-commit-queue and temporarily disable testing on commit-queue
785         https://bugs.webkit.org/show_bug.cgi?id=113979
786
787         Reviewed by Benjamin Poulain.
788
789         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
790         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
791
792         * EWSTools/setup-commit-queue.sh:
793         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
794         (CommitQueueTask.run):
795
796 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
797
798         temporarily make flakiness dashboard work again webkit.org bots
799         https://bugs.webkit.org/show_bug.cgi?id=113972
800
801         Reviewed by Ojan Vafai.
802
803         This patch disables the chromium.org layout test bots TestExpectations
804         parsing temporarily until we can work out the right way to split into
805         two instances for webkit.org and chromium.org and figure out which
806         code to delete where :).
807
808         * TestResultServer/static-dashboards/flakiness_dashboard.js:
809
810 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
811
812         Fix webkitpy tests after r147678.
813
814         * Scripts/webkitpy/tool/commands/queues_unittest.py:
815         (CommitQueueTest.test_commit_queue):
816         (test_manual_reject_during_processing):
817
818 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
819
820         The commit queue should use Mac MountainLion port
821         https://bugs.webkit.org/show_bug.cgi?id=113971
822
823         Reviewed by Lucas Forschler.
824
825         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
826         * Scripts/webkitpy/tool/commands/queues.py:
827         (CommitQueue):
828
829 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
830
831         turn off running tests on chromium linux EWS bots
832         https://bugs.webkit.org/show_bug.cgi?id=113959
833
834         Reviewed by Geoffrey Garen.
835
836         Now that the Chromium port is no longer being maintained
837         there's little point in running the tests. Soon we should
838         just shut this bot off altogether.
839
840         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
841         (ChromiumLinuxEWS):
842
843 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
844
845         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
846
847         * Scripts/webkitpy/common/config/watchlist:
848
849 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
850
851         Indentation fix to get webkit-patch working again after r147625
852
853         Unreviewed.
854
855         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
856         (MacEWS):
857         (MacWK2EWS):
858
859 2013-04-04  Lucas Forschler  <lforschler@apple.com>
860
861         Turn tests back on for Mac WK1/WK2 EWS.
862         
863         Unreviewed.
864         
865         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
866         (MacEWS):
867         (MacWK2EWS):
868
869 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
870
871         [GTK][WK2] MiniBrowser custom URI scheme support
872         https://bugs.webkit.org/show_bug.cgi?id=112419
873
874         Reviewed by Carlos Garcia Campos.
875
876         Add support for about URIs in MiniBrowser. An example about page is show
877         with URI "about:minibrowser", the rest of the cases it will show a
878         proper message explaining that the about page didn't exist.
879
880         Internally it uses "minibrowser-about" prefix instead of "about", but
881         from the user point of view it works with "about" prefix.
882
883         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
884         (getInternalURI): Method to convert URIs from "about" prefix to
885         "minibrowser-about".
886         (getExternalURI): Opposite method.
887         (webViewURIChanged): Use "about" prefix to show the URI to users.
888         (webViewEnterFullScreen): Ditto.
889         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
890         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
891         (aboutURISchemeRequestCallback): Callback to manage about calls.
892         (main): Register the URI scheme to manage about URIs.
893
894 2013-04-03  Roger Fong  <roger_fong@apple.com>
895
896         Re-enable WinEWS tests.
897
898         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
899         (WinEWS):
900
901 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
902
903         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
904         https://bugs.webkit.org/show_bug.cgi?id=113883
905
906         Reviewed by Martin Robinson.
907
908         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
909         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
910         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
911
912 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
913
914         [GTK] Include Pango in jhbuild-optional.modules
915         https://bugs.webkit.org/show_bug.cgi?id=113878
916
917         Reviewed by Martin Robinson.
918
919         Since r147547 Pango 1.32.0 is required. Including the module in the
920         JHBuild optional moduleset.
921
922         * gtk/jhbuild-optional.modules: Add Pango module.
923
924 2013-04-03  Zeno Albisser  <zeno@webkit.org>
925
926         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
927         https://bugs.webkit.org/show_bug.cgi?id=113864
928
929         Moving setDefersLoading from TestRunnerQt to TestRunner
930         requires access to the non-Qt TestRunner.
931         As long as we instantiate both TestRunner and TestRunnerQt,
932         we need a separate getter for the non-Qt TestRunner instance.
933
934         Reviewed by Simon Hausmann.
935
936         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
937         (WebPage::resetSettings):
938         * DumpRenderTree/qt/DumpRenderTreeQt.h:
939         (DumpRenderTree::jscTestRunner):
940         * DumpRenderTree/qt/TestRunnerQt.cpp:
941         (TestRunner::setDefersLoading):
942             Moving setDefersLoading from TestRunnerQt
943             to TestRunner.
944         * DumpRenderTree/qt/TestRunnerQt.h:
945         (TestRunnerQt):
946
947 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
948
949         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
950         https://bugs.webkit.org/show_bug.cgi?id=104779
951
952         Reviewed by Carlos Garcia Campos.
953
954         * Scripts/run-gtk-tests:
955         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
956         passing in current trunk.
957
958 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
959
960         Fix HAVE(QTTESTSUPPORT) logic
961
962         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
963         resulting in HAVE(QTTESTSUPPORT) never being true.
964         Move that logic down in sanitizeFeatures.
965
966         Rubber-stamped by Tor Arne Vestbø.
967
968         * qmake/mkspecs/features/features.prf:
969
970 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
971
972         [GTK] Bump required versions of some dependencies
973         https://bugs.webkit.org/show_bug.cgi?id=113282
974
975         Reviewed by Martin Robinson.
976
977         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
978
979 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
980
981         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
982         https://bugs.webkit.org/show_bug.cgi?id=113809
983
984         Reviewed by Philippe Normand.
985
986         Newer Linux kernels have removed some deprecated macros from v4l2
987         headers, causing gst-plugins-good's build to break. We don't need it
988         right now, so just disable it.
989
990         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
991
992 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
993
994         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
995         https://bugs.webkit.org/show_bug.cgi?id=113535
996
997         Reviewed by Simon Hausmann.
998
999         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1000
1001         * qmake/mkspecs/features/features.prf:
1002
1003 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1004
1005         [Qt] Move logic of simple forwarding functions to TestRunner.
1006         https://bugs.webkit.org/show_bug.cgi?id=113863
1007
1008         Reviewed by Simon Hausmann.
1009
1010         * DumpRenderTree/qt/TestRunnerQt.cpp:
1011         (TestRunner::setTextDirection):
1012         (TestRunner::goBack):
1013         (TestRunner::evaluateScriptInIsolatedWorld):
1014         (TestRunner::addUserStyleSheet):
1015         * DumpRenderTree/qt/TestRunnerQt.h:
1016         (TestRunnerQt):
1017
1018 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1019
1020         [Qt] Disable media support using QuickTime if deployment target != SDK
1021
1022         We link to a single libWebKitSystemInterface static lib, so unless the
1023         deployment target matches the SDK let's not pretend like we'll be able
1024         to run on anything lower than the SDK version.
1025
1026         Reviewed by Simon Hausmann.
1027
1028         * qmake/mkspecs/features/features.prf:
1029
1030 2013-04-02  James Craig  <james@cookiecrook.com>
1031
1032         AXRoleDescripton for DL is "list"; should be "description list"
1033         https://bugs.webkit.org/show_bug.cgi?id=111665
1034
1035         Reviewed by Chris Fleizach.
1036
1037         Defining the role and description strings.
1038
1039         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1040
1041 2013-04-02  Roger Fong  <roger_fong@apple.com>
1042
1043         Unreviewed. Disable running tests on Win EWS queue.
1044
1045         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1046         (WinEWS):
1047
1048 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1049
1050         Disable running tests on the MAC WK2 EWS queue.
1051         
1052         Unreviewed.
1053         
1054         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1055         (MacWK2EWS):
1056
1057 2013-04-02  Julie Parent  <jparent@chromium.org>
1058
1059         Dashboard refactor: Move dashboard specific history related features to History.
1060         https://bugs.webkit.org/show_bug.cgi?id=113717
1061
1062         Reviewed by Ojan Vafai.
1063         
1064         Each dashboard now creates its own History object, with a custom
1065         configuration. This changes from just overriding global functions
1066         to passing in callbacks for generatePage, handleValidHashParameter,
1067         and handleQueryParameterChange. Same with passing in defaultStateValues
1068         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1069         variables.
1070         
1071         All functions related to these features are now (mostly) private
1072         function on History. 
1073         
1074         Loader no longer needs a loadingComplete callback, since it can just
1075         initialize the history object itself.
1076
1077         * TestResultServer/static-dashboards/aggregate_results.js:
1078         (handleValidHashParameter):
1079         * TestResultServer/static-dashboards/dashboard_base.js:
1080         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1081         (generatePage):
1082         (.switch.return):
1083         (handleQueryParameterChange):
1084         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1085         (resetGlobals):
1086         * TestResultServer/static-dashboards/history.js:
1087         (.):
1088         * TestResultServer/static-dashboards/loader.js:
1089         (.):
1090         * TestResultServer/static-dashboards/loader_unittests.js:
1091         * TestResultServer/static-dashboards/timeline_explorer.js:
1092         (generatePage):
1093         (initCurrentBuilderTestResults):
1094         * TestResultServer/static-dashboards/treemap.js:
1095         (generatePage):
1096         (.switch.return):
1097         (handleQueryParameterChange):
1098
1099 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1100
1101         Unreviewed, rolling out r147401.
1102         http://trac.webkit.org/changeset/147401
1103         https://bugs.webkit.org/show_bug.cgi?id=113767
1104
1105         The patch makes it extremely hard to set up the dependencies
1106         properly on the GTK builders (Requested by zdobersek on
1107         #webkit).
1108
1109         * gtk/jhbuild.modules:
1110
1111 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1112
1113         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1114         https://bugs.webkit.org/show_bug.cgi?id=113382
1115
1116         Reviewed by Gyuyoung Kim.
1117
1118         Do not show the empty tooltip box if the text is null.
1119
1120         * MiniBrowser/efl/main.c:
1121         (popup_menu_populate):
1122
1123 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1124
1125         [GTK] Bump required versions of some dependencies
1126         https://bugs.webkit.org/show_bug.cgi?id=113282
1127
1128         Reviewed by Martin Robinson.
1129
1130         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1131
1132 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1133
1134         Unreviewed, rolling out r147319.
1135         http://trac.webkit.org/changeset/147319
1136         https://bugs.webkit.org/show_bug.cgi?id=113707
1137
1138         The unit test is still failing on the buildbot (Requested by
1139         zdobersek on #webkit).
1140
1141         * Scripts/run-gtk-tests:
1142         (TestRunner):
1143
1144 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1145
1146         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1147         https://bugs.webkit.org/show_bug.cgi?id=104779
1148
1149         Reviewed by Carlos Garcia Campos.
1150
1151         * Scripts/run-gtk-tests:
1152         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1153         passing in current trunk.
1154
1155 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1156
1157         Unreviewed, rolling out r147289.
1158         http://trac.webkit.org/changeset/147289
1159         https://bugs.webkit.org/show_bug.cgi?id=113678
1160
1161         broke Win7 (dbg) build (Requested by shinyak|gardener on
1162         #webkit).
1163
1164         * DumpRenderTree/DumpRenderTree.gypi:
1165         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1166         (WebTestRunner):
1167         (WebUserMediaClientMock):
1168         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1169         (WebTestRunner::WebUserMediaClientMock::taskList):
1170         * Scripts/webkitpy/style/checkers/cpp.py:
1171         (check_function_definition):
1172
1173 2013-03-31  Adam Barth  <abarth@webkit.org>
1174
1175         configure-svn-config.sh fails
1176         https://codereview.chromium.org/13392007/
1177
1178         Reviewed by Eric Seidel.
1179
1180         This script was trying to use "svn checkout" to dowload a file from
1181         svn.webkit.org, but "svn checkout" only works with directories.
1182         Instead, we should use "svn export".
1183
1184         * EWSTools/configure-svn-config.sh:
1185
1186 2013-03-31  Wei Jia  <wjia@chromium.org>
1187
1188         Allow WebUserMediaClientMock to be used by client
1189         https://bugs.webkit.org/show_bug.cgi?id=113633
1190
1191         Reviewed by Adam Barth.
1192
1193         Export WebUserMediaClientMock.
1194         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1195
1196         * DumpRenderTree/DumpRenderTree.gypi:
1197         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1198         (WebUserMediaClientMock):
1199         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1200         * Scripts/webkitpy/style/checkers/cpp.py:
1201         (check_function_definition):
1202
1203 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1204
1205         Expose FeatureObserver data to WebKit clients
1206         https://bugs.webkit.org/show_bug.cgi?id=113613
1207
1208         Reviewed by Sam Weinig.
1209
1210         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1211         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1212
1213 2013-03-29  Greg Hughes  <ghughes@apple.com>
1214
1215         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1216         https://bugs.webkit.org/show_bug.cgi?id=112276
1217
1218         Reviewed by Chris Fleizach.
1219
1220         Added support to test accessibility search predicates with multiple keys.  
1221
1222         * DumpRenderTree/AccessibilityUIElement.cpp:
1223         (uiElementForSearchPredicateCallback):
1224         * DumpRenderTree/AccessibilityUIElement.h:
1225         (AccessibilityUIElement):
1226         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1227         (AccessibilityUIElement::uiElementForSearchPredicate):
1228         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1229         (AccessibilityUIElement::uiElementForSearchPredicate):
1230         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1231         (AccessibilityUIElement::uiElementForSearchPredicate):
1232         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1233         (AccessibilityUIElement::uiElementForSearchPredicate):
1234         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1235         (AccessibilityUIElement::uiElementForSearchPredicate):
1236         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1237         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1238         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1239         (AccessibilityUIElement):
1240         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1241         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1242         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1243         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1244         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1245
1246 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1247
1248         Fix a typo in r147147 to fix Mac EWS.
1249
1250         * Scripts/webkitpy/tool/commands/queues.py:
1251         (PatchProcessingQueue._new_port_name_from_old):
1252
1253 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1254
1255         [EFL] Build break with latest EFL libraries after r146265
1256         https://bugs.webkit.org/show_bug.cgi?id=113558
1257
1258         Unreviewed build fix.
1259
1260         * TestWebKitAPI/PlatformWebView.h:
1261         * WebKitTestRunner/PlatformWebView.h:
1262
1263 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1264
1265         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1266
1267         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1268         in libgcrypt build.
1269
1270 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1271
1272         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1273
1274         Unreviewed.
1275
1276         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1277         (MacEWS):
1278
1279 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1280
1281         Use the right OS name on Mac EWS instead of mac-future.
1282
1283         Rubber-stamped by Dirk Pranke.
1284
1285         * Scripts/webkitpy/tool/commands/queues.py:
1286         (PatchProcessingQueue._new_port_name_from_old):
1287         (PatchProcessingQueue.begin_work_queue):
1288         (PatchProcessingQueue._upload_results_archive_for_patch):
1289
1290 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1291
1292         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1293         https://bugs.webkit.org/show_bug.cgi?id=112546
1294
1295         Reviewed by Martin Robinson.
1296
1297         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1298         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1299
1300 2013-03-28  Ming Xie  <mxie@blackberry.com>
1301
1302         [BlackBerry] Committer Email Updates
1303         https://bugs.webkit.org/show_bug.cgi?id=113435
1304
1305         Reviewed by Rob Buis.
1306
1307         Add the @blackberry.com email address for all our BlackBerry
1308         WebKit committers. This is the first step for our email address
1309         migration.
1310
1311         * Scripts/webkitpy/common/config/committers.py:
1312
1313 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1314
1315         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1316         https://bugs.webkit.org/show_bug.cgi?id=113508
1317
1318         Reviewed by Martin Robinson.
1319
1320         Prevent the GStreamer plugin scanner to load system-wide
1321         plugins. Only the ones built in JHBuild should be loaded and used
1322         at runtime.
1323
1324         * efl/jhbuildrc:
1325         * gtk/jhbuildrc:
1326
1327 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1328
1329         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1330         https://bugs.webkit.org/show_bug.cgi?id=113386
1331
1332         Reviewed by Carlos Garcia Campos.
1333
1334         * Scripts/webkitdirs.pm:
1335         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1336         version to 3.0. Reflect this change so the builtDylibPathForName
1337         function doesn't fail to report the library as found.
1338
1339 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1340
1341         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1342         https://bugs.webkit.org/show_bug.cgi?id=113484
1343
1344         Unreviewed build fix.
1345
1346         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1347
1348         * TestWebKitAPI/CMakeLists.txt:
1349         * WebKitTestRunner/CMakeLists.txt:
1350
1351 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1352
1353         Revision for the internal jhbuild is too old
1354         https://bugs.webkit.org/show_bug.cgi?id=113324
1355
1356         Reviewed by Martin Robinson.
1357
1358         Update the minimum required version to a point where jhbuild won't
1359         fail installing packages when trying to remove a symlink to a directory.
1360
1361         * jhbuild/jhbuild-wrapper: Updated revision.
1362
1363 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1364
1365         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1366         https://bugs.webkit.org/show_bug.cgi?id=113203
1367
1368         Reviewed by Philippe Normand.
1369
1370         We build our libsoup without GNOME support. gst-plugins-good does separate
1371         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1372         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1373         build failures as the headers of those diverge. We do not use souphttpsrc, so
1374         disable it when building gst-plugins-good.
1375
1376         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1377
1378 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1379
1380         Build fix after r146852. Please another reference to the Lion leaks builder.
1381
1382         * BuildSlaveSupport/build.webkit.org-config/config.json:
1383
1384 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1385
1386         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1387         https://bugs.webkit.org/show_bug.cgi?id=113421
1388
1389         Reviewed by Dirk Pranke.
1390
1391         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1392         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1393         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1394         in the GTK-specific TestExpectations files.
1395
1396         To avoid this only enable the warnings only when not using WKTR.
1397
1398         * Scripts/webkitpy/layout_tests/port/gtk.py:
1399         (GtkPort.warn_if_bug_missing_in_test_expectations):
1400
1401 2013-03-27  Antti Koivisto  <antti@apple.com>
1402
1403         Fix Zalan's email.
1404
1405         * Scripts/webkitpy/common/config/committers.py:
1406
1407 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1408
1409         master.cfg cleanup
1410         https://bugs.webkit.org/show_bug.cgi?id=113195
1411
1412         Reviewed by Ryosuke Niwa.
1413
1414         * BuildSlaveSupport/build.webkit.org-config/config.json:
1415         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1416
1417 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1418
1419         master.cfg fine-tuning for Qt Mountain Lion Release bot
1420         https://bugs.webkit.org/show_bug.cgi?id=113191
1421
1422         Reviewed by Ryosuke Niwa.
1423
1424         * BuildSlaveSupport/build.webkit.org-config/config.json:
1425           - Rename the slave due to its location change.
1426           - Update the platform of the slave.
1427         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1428         (RunQtAPITests): Enable running WK2 API tests on Qt.
1429         (RunQtAPITests.start):
1430         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1431         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1432
1433 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1434
1435         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1436         https://bugs.webkit.org/show_bug.cgi?id=113403
1437
1438         Reviewed by Kenneth Rohde Christiansen.
1439
1440         As of Evas 1.7.5, when Wayland is detected on the system, support for
1441         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1442         The code, however, seems to depend on a few other flags which must be
1443         explicitly enabled.
1444
1445         If those additional GL-related options are passed, we end up
1446         having issues on the WebKit side, so disable Wayland support for
1447         now.
1448
1449         * efl/jhbuild.modules:
1450
1451 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1452
1453         Unreviewed, rolling out r146864.
1454         http://trac.webkit.org/changeset/146864
1455         https://bugs.webkit.org/show_bug.cgi?id=113391
1456
1457         causes crashes on Wk2 EFL release bot (Requested by drott on
1458         #webkit).
1459
1460         * Scripts/webkitperl/FeatureList.pm:
1461
1462 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1463
1464         [jhbuild] Correctly specify an alternate number of make jobs.
1465         https://bugs.webkit.org/show_bug.cgi?id=113396
1466
1467         Reviewed by Philippe Normand.
1468
1469         So far, we were using the `MAKEFLAGS' environment variable to pass the
1470         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1471         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1472
1473         We now behave more closely to the rest of the WebKit tools by first
1474         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1475         not set, just letting jhbuild itself figure out how many jobs to use.
1476
1477         * efl/jhbuildrc:
1478         * gtk/jhbuildrc:
1479
1480 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1481
1482         [Qt] Remove Qt specific WorkQueueItem definitions.
1483         https://bugs.webkit.org/show_bug.cgi?id=112891
1484
1485         This patch is preparation work for removing
1486         WorkQueue related code from TestRunnerQt and
1487         replacing it with generic TestRunner code.
1488
1489         Reviewed by Benjamin Poulain.
1490
1491         * DumpRenderTree/qt/TestRunnerQt.cpp:
1492         (TestRunnerQt::queueBackNavigation):
1493         (TestRunnerQt::queueForwardNavigation):
1494         (TestRunnerQt::queueLoadHTMLString):
1495         (TestRunnerQt::queueReload):
1496         (TestRunnerQt::queueLoadingScript):
1497         (TestRunnerQt::queueNonLoadingScript):
1498         (TestRunner::queueLoad):
1499         * DumpRenderTree/qt/TestRunnerQt.h:
1500         (TestRunnerQt):
1501         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1502         (LoadItem::invoke):
1503         (LoadHTMLStringItem::invoke):
1504         (LoadAlternateHTMLStringItem::invoke):
1505         (ReloadItem::invoke):
1506         (ScriptItem::invoke):
1507         (BackForwardItem::invoke):
1508         * DumpRenderTree/qt/WorkQueueItemQt.h:
1509         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1510         (LoadAlternateHTMLStringItem):
1511
1512 2013-03-26  Julie Parent  <jparent@chromium.org>
1513
1514         Flakiness dashboard: simplify logic around which tests to show.
1515         https://bugs.webkit.org/show_bug.cgi?id=113250
1516
1517         Reviewed by Ojan Vafai.
1518         
1519         The different filters for showing results are only used for layout
1520         tests, otherwise, we show everything.
1521         
1522         Change the defaults to false (what layout tests used), and only
1523         look at the values when viewing layout tests.
1524
1525         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1526         (htmlForTestsWithExpectationsButNoFailures):
1527         (shouldHideTest):
1528
1529 2013-03-26  Isaac Levy  <ilevy@google.com>
1530
1531         Update bots on test-results.appspot
1532         https://bugs.webkit.org/show_bug.cgi?id=113333
1533
1534         Reviewed by Ojan Vafai.
1535
1536         * TestResultServer/static-dashboards/builders.jsonp:
1537
1538 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1539
1540         Unreviewed GTK gardening.
1541
1542         * Scripts/run-gtk-tests:
1543         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1544
1545 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1546
1547         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1548         https://bugs.webkit.org/show_bug.cgi?id=113287
1549
1550         Reviewed by Jocelyn Turcotte.
1551
1552         * Scripts/run-qtwebkit-tests:
1553         (Options.__init__):
1554
1555 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1556
1557         [EFL] Enable IndexedDB by default
1558         https://bugs.webkit.org/show_bug.cgi?id=107248
1559
1560         Reviewed by Laszlo Gombos.
1561
1562         * Scripts/webkitperl/FeatureList.pm:
1563         Enable IndexedDB by default on EFL.
1564
1565 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1566
1567         Sheriffbot should explain rollout failures in a human readable form.
1568         https://bugs.webkit.org/show_bug.cgi?id=107092
1569
1570         Reviewed by Ryosuke Niwa.
1571
1572         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1573
1574         * Scripts/webkitpy/tool/bot/irc_command.py:
1575         (Rollout._check_diff_failure):
1576         (Rollout.execute):
1577         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1578         (IRCCommandTest.test_rollout):
1579
1580 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1581
1582         Unreviewed GTK gardening.
1583
1584         * Scripts/run-gtk-tests:
1585         (TestRunner): Skipping a failing unit test after r146518.
1586
1587 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1588
1589         Remove Lion leaks builder
1590         https://bugs.webkit.org/show_bug.cgi?id=113252
1591
1592         Reviewed by Andreas Kling.
1593
1594         Removed.
1595
1596         * BuildSlaveSupport/build.webkit.org-config/config.json:
1597
1598 2013-03-25  Kent Tamura  <tkent@chromium.org>
1599
1600         Rename ENABLE_INPUT_TYPE_DATETIME
1601         https://bugs.webkit.org/show_bug.cgi?id=113254
1602
1603         Reviewed by Kentaro Hara.
1604
1605         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1606         Actually I'd like to remove the code, but we shouldn't remove it yet
1607         because we shipped products with it on some platforms.
1608
1609         * Scripts/webkitperl/FeatureList.pm:
1610         * qmake/mkspecs/features/features.pri:
1611
1612 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1613
1614         Remove one more line that was intended to be removed in r146657.
1615
1616         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1617         (summarize_results):
1618
1619 2013-03-25  Roger Fong  <roger_fong@apple.com>
1620
1621         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1622         Re-enable WinEWS tests.
1623
1624         * Scripts/webkitpy/common/config/ports.py:
1625         (WinPort.run_bindings_tests_command):
1626         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1627         (WinEWS):
1628
1629 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1630
1631         Unreviewed, rolling out r146793.
1632         http://trac.webkit.org/changeset/146793
1633         https://bugs.webkit.org/show_bug.cgi?id=113248
1634
1635         Fix did not work (Requested by rfong on #webkit).
1636
1637         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1638         (WinEWS):
1639
1640 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1641
1642         REGRESSION(r146657): Test failures reported incorrectly
1643         https://bugs.webkit.org/show_bug.cgi?id=113223
1644
1645         Reviewed by Dirk Pranke.
1646
1647         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1648
1649         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1650         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1651
1652         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1653         (Manager.run):
1654
1655         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1656         (RunDetails.__init__):
1657         (summarize_results): Remove the line I intended to remove in r146657.
1658
1659         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1660         (logging_run): Return details instead of the exit code.
1661         (run_and_capture): Ditto.
1662
1663         (RunTest.test_full_results_html):
1664         (RunTest.test_hung_thread):
1665         (RunTest.test_no_tests_found):
1666         (RunTest.test_no_tests_found_2):
1667         (RunTest.test_repeat_each_iterations_num_tests):
1668         (RunTest.test_run_singly_actually_runs_tests):
1669         (RunTest.test_test_list):
1670         (RunTest.test_missing_and_unexpected_results):
1671         (RunTest.test_pixel_test_directories):
1672         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1673         (RunTest.test_crash_with_stderr):
1674         (RunTest.test_no_image_failure_with_image_diff):
1675         (RunTest.test_crash_log):
1676         (RunTest.test_exit_after_n_failures_upload):
1677         (RunTest.test_results_directory_absolute):
1678         (RunTest.test_results_directory_relative):
1679         (RunTest.test_retrying_and_flaky_tests):
1680         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1681         (RunTest.test_retrying_uses_retries_directory):
1682         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1683         (RunTest.test_output_diffs):
1684         (EndToEndTest.test_reftest_with_two_notrefs):
1685         (RebaselineTest.test_reset_results):
1686         (RebaselineTest.test_missing_results):
1687         (RebaselineTest.test_new_baseline):
1688
1689         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1690         (BuildBotPrinter.print_results):
1691         (BuildBotPrinter.print_unexpected_results):
1692         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1693         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1694
1695 2013-03-25  Julie Parent  <jparent@chromium.org>
1696
1697         Dashboard refactor: Move cross dashboard history related code into history.js.
1698         https://bugs.webkit.org/show_bug.cgi?id=113104
1699
1700         Reviewed by Ojan Vafai.
1701
1702         All functions relating to cross dashboard behavior move from being
1703         globals to methods on the history.History object. Names stay the same,
1704         except many are made private, ones that should have been constants now
1705         are, and the long standing TODO to change "currentState" to 
1706         dashboardSpecificState is done.
1707         
1708         We now create a global history object in dashboard_base, as an 
1709         intermediate measure.  Once the dashboard specific code is
1710         added to history, each DB will need to create its own, and this
1711         global will be eliminated.
1712         
1713         * TestResultServer/static-dashboards/aggregate_results.js:
1714         (handleValidHashParameter):
1715         (htmlForBuilder):
1716         (rawValuesHTML):
1717         * TestResultServer/static-dashboards/dashboard_base.js:
1718         (parseDashboardSpecificParameters):
1719         (defaultValue):
1720         (currentBuilderGroupCategory):
1721         (currentBuilderGroupName):
1722         (handleLocationChange):
1723         (expectationsMap):
1724         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1725         (generatePage):
1726         (.switch.return):
1727         (platformAndBuildType):
1728         (individualTests):
1729         (substringList):
1730         (processMissingAndExtraExpectations):
1731         (pathToFailureLog):
1732         (showPopupForBuild):
1733         (htmlForTestsWithExpectationsButNoFailures):
1734         (shouldHideTest):
1735         (isCrossBuilderView):
1736         (tableHeaders):
1737         (htmlForSingleTestRow):
1738         (htmlForTableColumnHeader):
1739         (generatePageForExpectationsUpdate):
1740         (handleUpdate):
1741         (nextUpdate):
1742         (setUpdateIndex):
1743         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1744         (.appendExpectationsItem):
1745         (loadExpectations):
1746         (.dummyNode.onload):
1747         (loadExpectationsLayoutTests):
1748         (appendExpectations):
1749         (htmlForNavBar):
1750         (checkBoxToToggleState):
1751         (linkHTMLToToggleState):
1752         (generatePageForBuilder):
1753         (isInvalidKeyForCrossBuilderView):
1754         (handleQueryParameterChange):
1755         (showLegend):
1756         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1757         (resetGlobals):
1758         (test):
1759         * TestResultServer/static-dashboards/history.js:
1760         (.):
1761         * TestResultServer/static-dashboards/history_unittests.js:
1762         * TestResultServer/static-dashboards/loader.js:
1763         (.):
1764         * TestResultServer/static-dashboards/loader_unittests.js:
1765         * TestResultServer/static-dashboards/timeline_explorer.js:
1766         (generatePage):
1767         (initCurrentBuilderTestResults):
1768         (selectBuild):
1769         (showResultsDelta):
1770         * TestResultServer/static-dashboards/treemap.js:
1771         (generatePage):
1772         (.switch.return):
1773         (handleFocus):
1774         * TestResultServer/static-dashboards/ui.js:
1775
1776 2013-03-25  Roger Fong  <roger_fong@apple.com>
1777
1778         Unreviewed. Enable WinEWS tests again.
1779
1780         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1781         (WinEWS):
1782
1783 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1784
1785         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1786         https://bugs.webkit.org/show_bug.cgi?id=112166
1787
1788         HarfBuzz 0.9.14 merged my patch for icu detection without
1789         pkg-config files, as needed by for example Ubuntu 12.04.
1790         This obsoletes our local workaround. Removed it for GTK and EFL.
1791
1792         Reviewed by Martin Robinson.
1793
1794         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1795         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1796         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1797         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1798
1799 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1800
1801         Unreviewed.  Move self from contributor to committer list.
1802
1803         * Scripts/webkitpy/common/config/committers.py:
1804
1805 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1806
1807         EWS should use a human readable port name when uploading layout test archives
1808         https://bugs.webkit.org/show_bug.cgi?id=113099
1809
1810         Reviewed by Dirk Pranke.
1811
1812         Use new port's object's name() method to report human readable port names.
1813         This will also help us resolving the bug to apply layout test results posted by EWS.
1814
1815         * Scripts/webkitpy/tool/bot/botinfo.py:
1816         (BotInfo.__init__): Take port's name.
1817         (BotInfo.summary_text):
1818
1819         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1820         (BotInfoTest.test_summary_text):
1821
1822         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1823         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1824
1825         * Scripts/webkitpy/tool/commands/queues.py:
1826         (PatchProcessingQueue.__init__): Initialize self._port.
1827         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1828         and use that for the attachment filename and the comment posted.
1829
1830         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1831         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1832         "mac-snowleopard" as expected for TestPort.
1833
1834 2013-03-22  Roger Fong  <roger_fong@apple.com>
1835
1836         Unreviewed. Turn off EWS test on Win again.
1837         The battle continues.
1838
1839         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1840         (WinEWS):
1841
1842 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1843
1844         NRWT: Enable pixel tests when retrying tests
1845         https://bugs.webkit.org/show_bug.cgi?id=112898
1846
1847         Reviewed by Dirk Pranke.
1848
1849         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1850         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1851         if we've forced pixel tests in the retry.
1852         (Manager._run_tests):
1853         (Manager._clean_up_run): Fixed the capitalizations.
1854         (Manager._force_pixel_tests_if_needed): Added.
1855
1856         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1857         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1858         'image_diff_percent' if it doesn't already exist.
1859
1860         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1861         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1862         treat this as a regular regression instead of a flakiness.
1863
1864         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1865         run had image diffs.
1866
1867         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1868         (summarized_results):
1869
1870         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1871         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1872         Also removed some dead code.
1873
1874         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1875         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1876         is set and pixel_tests_enabled is set to false.
1877         (EndToEndTest.test_reftest_with_two_notrefs):
1878
1879 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1880
1881         Make it possible to run layout tests on Retina MBP
1882         https://bugs.webkit.org/show_bug.cgi?id=93673
1883
1884         Reviewed by Ryosuke Niwa.
1885
1886         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1887         windows on 2x machines still run at 1x.
1888
1889         * DumpRenderTree/mac/DumpRenderTree.mm:
1890         (createWebViewAndOffscreenWindow):
1891         Reset the window resolution to 1x on creation.
1892         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
1893         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1894         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
1895         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1896         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
1897         (WTR::PlatformWebView::PlatformWebView):
1898         Add NSWindow details, reset the window resolution to 1x on creation.
1899
1900 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1901
1902         Leak bots shouldn't build
1903         https://bugs.webkit.org/show_bug.cgi?id=112774
1904
1905         Reviewed by Simon Fraser.
1906
1907         Since leak bots use regular debug builds, there is no need to build on these bots.
1908         Simply downloading builds will dramatically improve the cycle time of these bots.
1909
1910         * BuildSlaveSupport/build.webkit.org-config/config.json:
1911         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1912         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
1913         TestFactory instead of BuildAndTestFactory.
1914
1915 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1916
1917         [Qt] Fix the TestWebKitAPI build
1918         https://bugs.webkit.org/show_bug.cgi?id=113044
1919
1920         Reviewed by Tor Arne Vestbø.
1921
1922         The generate-forwarding-headers script would only be run
1923         after the targets in InjectedBundle.pri since the second
1924         addStrictSubdirOrderBetween call in
1925         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
1926         the derived_sources -> injected_bundle order in SUBDIRS.
1927
1928         Fix it by only moving the dependent target at the end of
1929         SUBDIRS, don't touch its dependency.
1930
1931         * qmake/mkspecs/features/functions.prf:
1932
1933 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1934
1935         [EFL][WK2] View is not focused when fullscreen mode toggled
1936         https://bugs.webkit.org/show_bug.cgi?id=113009
1937
1938         Reviewed by Laszlo Gombos.
1939
1940         Set focus on view when fullscreen mode enabled/disabled
1941         by FullScreen API.
1942
1943         * MiniBrowser/efl/main.c:
1944         (on_fullscreen_accept):
1945         (on_fullscreen_deny):
1946
1947 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1948
1949         nrwt is no longer saving retry results in the retries/ subdirectory
1950         https://bugs.webkit.org/show_bug.cgi?id=112995
1951
1952         Reviewed by Ojan Vafai.
1953
1954         I think this has been broken a long time, unfortunately. This
1955         patch should fix that.
1956
1957         In order to do so, I had to pass the directory to use from
1958         the Worker object through the SingleTestWriter to the
1959         TestResultWriter. While I was plumbing that through, I rationalized
1960         the order of the parameter arguments a bit ...
1961
1962         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1963         (Worker._run_single_test):
1964         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1965         (run_single_test):
1966         (SingleTestRunner.__init__):
1967         (SingleTestRunner._run_compare_test):
1968         (SingleTestRunner._run_rebaseline):
1969         (SingleTestRunner._run_reftest):
1970         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1971         (write_test_result):
1972         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1973         (TestResultWriterTest.test_reftest_diff_image):
1974         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1975         (RunTest.test_retrying_uses_retries_directory):
1976
1977 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
1978
1979         JSC profiler should have an at-a-glance report of the success of DFG optimization
1980         https://bugs.webkit.org/show_bug.cgi?id=112988
1981
1982         Reviewed by Geoffrey Garen.
1983
1984         * Scripts/display-profiler-output:
1985
1986 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1987
1988         [chromium] Linux ASAN WebKit canary is running out of memory
1989         https://bugs.webkit.org/show_bug.cgi?id=112978
1990
1991         Reviewed by Tony Chang.
1992
1993         Running the AddressSanitizer on a crash takes a lot of
1994         memory, so we should serialize access to it to avoid running
1995         out of memory on a machine.
1996
1997         * Scripts/webkitpy/layout_tests/port/chromium.py:
1998         (ChromiumPort._get_crash_log):
1999         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2000         (HttpLock.__init__):
2001         (HttpLock.wait_for_httpd_lock):
2002
2003 2013-03-21  Min Qin  <qinmin@chromium.org>
2004
2005         Cleanup android media layout test code
2006         https://bugs.webkit.org/show_bug.cgi?id=112944
2007
2008         Reviewed by Adam Barth.
2009
2010         Chromium change: https://codereview.chromium.org/12892010/
2011         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2012         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2013         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2014         Instead, we should switch to use content shell for layout tests.
2015
2016         * DumpRenderTree/chromium/TestShell.cpp:
2017         (TestShell::resetTestController):
2018
2019 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2020
2021         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2022         https://bugs.webkit.org/show_bug.cgi?id=112953
2023
2024         Reviewed by Tony Chang.
2025
2026         When I created the DumpRenderTree_resources target in r144863 I
2027         forgot to declare the needed dependencies on the other resource
2028         targets. Due to a quirk of ordering, this appears to have been fine
2029         w/ ninja but not w/ Xcode (which is still being used on the chromium
2030         mac valgrind bots). Declaring the dependencies fixes the build
2031         failures.
2032
2033         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2034
2035 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2036
2037         [WinCairo] Correct assert in Empty BitmapImage Test.
2038         https://bugs.webkit.org/show_bug.cgi?id=112934
2039
2040         Reviewed by Tim Horton.
2041
2042         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2043         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2044         to avoid ref counting assertion when leaving test scope.
2045
2046 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2047
2048         [GTK] generate-feature-defines-files is incompatible with Python3
2049         https://bugs.webkit.org/show_bug.cgi?id=112956
2050
2051         Reviewed by Martin Robinson.
2052
2053         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2054         method on the dictionary objects when iterating through said dictionaries.
2055
2056         * gtk/generate-feature-defines-files:
2057         (write_feature_defines_header):
2058         (write_flattened_feature_defines_file):
2059
2060 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2061
2062         kill-old-processes spits out error messages on Mac
2063         https://bugs.webkit.org/show_bug.cgi?id=112878
2064
2065         Reviewed by Jessie Berlin.
2066
2067         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2068         included in the list of options grep --help shows.
2069
2070         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2071
2072         * BuildSlaveSupport/kill-old-processes:
2073         (main):
2074
2075 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2076
2077         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2078         https://bugs.webkit.org/show_bug.cgi?id=112597
2079
2080         Reviewed by Xan Lopez.
2081
2082         These were introduced for the Chromium port in r105295. We need
2083         dummy implementations in order to compile the BlackBerry port.
2084
2085         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2086         (AccessibilityUIElement::scrollToMakeVisible):
2087         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2088         (AccessibilityUIElement::scrollToGlobalPoint):
2089
2090 2013-03-21  Roger Fong  <roger_fong@apple.com>
2091
2092         Re-enable WinEWS tests following r146376.
2093
2094         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2095         (WinEWS):
2096
2097 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2098
2099         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2100
2101         * Scripts/webkitpy/common/config/committers.py:
2102
2103 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2104
2105         [GTK] Missing atk in install-dependencies script
2106         https://bugs.webkit.org/show_bug.cgi?id=112272
2107
2108         Reviewed by Gustavo Noronha Silva.
2109
2110         * gtk/install-dependencies: Add missing atk dependency.
2111
2112 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2113
2114         [GTK] Missing backslash in install-dependencies script
2115         https://bugs.webkit.org/show_bug.cgi?id=112907
2116
2117         Reviewed by Philippe Normand.
2118
2119         * gtk/install-dependencies: Add missing backslash to dependencies
2120         list.
2121
2122 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2123
2124         EWS bots have stopped uploading results to bugzilla
2125         https://bugs.webkit.org/show_bug.cgi?id=101091
2126
2127         Reviewed by Adam Barth.
2128
2129         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2130         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2131         this relative file path resoled to a file inside a non-existent directory for "zip".
2132
2133         Fixed the bug by resolving both test results directory and zip archive paths in
2134         LayoutTestResultsReader.archive.
2135
2136         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2137         in the future.
2138
2139         * Scripts/webkitpy/common/system/filesystem_mock.py:
2140         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2141
2142         * Scripts/webkitpy/common/system/workspace.py:
2143         (Workspace.create_zip): Log the source path when "zip" failed.
2144
2145         * Scripts/webkitpy/common/system/workspace_mock.py:
2146         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2147
2148         * Scripts/webkitpy/common/system/workspace_unittest.py:
2149         (WorkspaceTest.test_create_zip_exception): Test that.
2150
2151         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2152         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2153         This is the actual bug fix.
2154
2155         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2156         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2157
2158 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2159
2160         [chromium] move WebThemeEngine implementations to TestRunner library
2161         https://bugs.webkit.org/show_bug.cgi?id=112751
2162
2163         Reviewed by Adam Barth.
2164
2165         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2166         * DumpRenderTree/DumpRenderTree.gypi:
2167         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2168         (WebKit):
2169         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2170         (WebTestRunner::TestInterfaces::themeEngine):
2171         (WebTestRunner):
2172         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2173         (WebKit):
2174         (TestInterfaces):
2175         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2176         (WebTestRunner::WebTestInterfaces::themeEngine):
2177         (WebTestRunner):
2178         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2179         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2180         (WebTestRunner):
2181         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2182         (WebTestRunner::WebTestThemeControlWin::box):
2183         (WebTestRunner::WebTestThemeControlWin::line):
2184         (WebTestRunner::WebTestThemeControlWin::triangle):
2185         (WebTestRunner::WebTestThemeControlWin::roundRect):
2186         (WebTestRunner::WebTestThemeControlWin::oval):
2187         (WebTestRunner::WebTestThemeControlWin::circle):
2188         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2189         (WebTestRunner::WebTestThemeControlWin::markState):
2190         (WebTestRunner::WebTestThemeControlWin::draw):
2191         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2192         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2193         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2194         (WebTestRunner):
2195         (WebTestThemeControlWin):
2196         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2197         (WebTestRunner):
2198         (WebTestThemeEngineMac):
2199         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2200         (+[FakeActiveWindow alwaysActiveWindow]):
2201         (+[FakeActiveWindow alwaysInactiveWindow]):
2202         (-[FakeActiveWindow initWithActiveControls:]):
2203         (-[FakeActiveWindow _hasActiveControls]):
2204         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2205         (WebTestRunner):
2206         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2207         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2208         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2209         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2210         (WebTestRunner):
2211         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2212         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2213         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2214         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2215         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2216         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2217         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2218         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2219         (WebTestRunner::WebTestThemeEngineWin::getSize):
2220         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2221         (WebTestRunner):
2222         (WebTestThemeEngineWin):
2223         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2224         * DumpRenderTree/chromium/TestShell.cpp:
2225         (TestShell::initialize):
2226         * DumpRenderTree/chromium/TestShell.h:
2227         (WebKit):
2228         * DumpRenderTree/chromium/TestShellMac.mm:
2229         (platformInit):
2230         * DumpRenderTree/chromium/TestShellWin.cpp:
2231         (platformInit):
2232         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2233
2234 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2235
2236         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2237
2238         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2239         New property sheet that does not link against CoreFoundation and
2240         CFNetwork.
2241         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2242         Use new TestWebKitAPICommonWinCairo property sheet.
2243         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2244         Ditto.
2245
2246 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2247
2248         [WinCairo] Unreviewed build fix for VS2010.
2249
2250         Had to add WinCairo-specific property sheets to deal with some
2251         library and path differences with the main Apple port.
2252
2253         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2254         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2255         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2256         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2257         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2258         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2259
2260 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2261
2262         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2263         https://bugs.webkit.org/show_bug.cgi?id=112849
2264
2265         Reviewed by Sam Weinig.
2266
2267         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2268         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2269         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2270
2271 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2272
2273         [WinCairo] Build WebKit Tools under VS2010
2274         https://bugs.webkit.org/show_bug.cgi?id=112821
2275
2276         Reviewed by Tim Horton.
2277
2278         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2279         Add WinCairo-specific build target.
2280         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2281         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2282         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2283         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2284         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2285         Add WinCairo-specific build target.
2286         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2287         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2288         Add WinCairo-specific build target.
2289         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2290         WinCairo-specific build target.
2291         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2292         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2293         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2294         specific build target.
2295         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2296         WinCairo-specific build target.
2297         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2298         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2299         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2300
2301 2013-03-20  Roger Fong  <roger_fong@apple.com>
2302
2303         API test gardening AppleWin port.
2304
2305         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2306
2307         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2308         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2309
2310 2013-03-20  Roger Fong  <roger_fong@apple.com>
2311
2312         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2313
2314         * EWSTools/start-queue-win.sh:
2315
2316 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2317
2318         Unreviewed, add myself to committers.py.
2319
2320 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2321
2322         Unreviewed. Adding another email for me.
2323
2324         * Scripts/webkitpy/common/config/committers.py:
2325
2326 2013-03-20  Justin Novosad  <junov@google.com>
2327
2328         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2329         https://bugs.webkit.org/show_bug.cgi?id=112605
2330
2331         Reviewed by James Robinson.
2332
2333         Deleting all the code that was used for propagating and supporting
2334         the Chromium setting for disabling deferred 2d canvas rendering.
2335
2336         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2337         (main):
2338         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2339         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2340         (WebTestRunner::WebPreferences::reset):
2341         (WebTestRunner::WebPreferences::applyTo):
2342         * DumpRenderTree/chromium/TestShell.cpp:
2343         (TestShell::TestShell):
2344         (TestShell::resetWebSettings):
2345         (TestShell::runFileTest):
2346         * DumpRenderTree/chromium/TestShell.h:
2347         (TestShell):
2348
2349 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2350
2351         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2352         https://bugs.webkit.org/show_bug.cgi?id=112699.
2353
2354         Reviewed by Adam Barth.
2355
2356         * Scripts/webkitpy/layout_tests/port/qt.py:
2357         (QtPort._search_paths):
2358         (QtPort._port_specific_expectations_files):
2359         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2360         (QtPortTest):
2361         (QtPortTest._assert_search_path):
2362         (QtPortTest._assert_expectations_files):
2363
2364 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2365
2366         [Qt] Enable kerning by default
2367         https://bugs.webkit.org/show_bug.cgi?id=112704
2368
2369         Reviewed by Jocelyn Turcotte.
2370
2371         Disable kerning by default, since some reference test expectations
2372         expect kerning to be default off.
2373
2374         * DumpRenderTree/qt/TestRunnerQt.cpp:
2375         (TestRunnerQt::reset):
2376         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2377         (WTR::activateFonts):
2378
2379 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2380
2381         [Qt] Remove empty function stubs from TestRunnerQt.
2382         https://bugs.webkit.org/show_bug.cgi?id=112799
2383
2384         We are reducing the code in TestRunnerQt step by step,
2385         in order to finally replace all of it with the generic
2386         TestRunner implementation.
2387         This patch removes several simple function stubs that
2388         currently do not implement any actual functionality.
2389
2390         Reviewed by Kenneth Rohde Christiansen.
2391
2392         * DumpRenderTree/qt/TestRunnerQt.cpp:
2393         * DumpRenderTree/qt/TestRunnerQt.h:
2394         (TestRunnerQt):
2395
2396 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2397
2398         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2399         https://bugs.webkit.org/show_bug.cgi?id=112687
2400
2401         Reviewed by Kenneth Rohde Christiansen.
2402
2403         Hide the SearchBar by default on window creation.
2404
2405         * MiniBrowser/efl/main.c:
2406         (window_create):
2407
2408 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2409
2410         Unreviewed, rolling out r146304.
2411         http://trac.webkit.org/changeset/146304
2412         https://bugs.webkit.org/show_bug.cgi?id=112788
2413
2414         to many expectations to update (Requested by antonm on
2415         #webkit).
2416
2417         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2418         * DumpRenderTree/DumpRenderTree.gypi:
2419         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2420         (WebKit):
2421         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2422         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2423         (TestInterfaces):
2424         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2425         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2426         * DumpRenderTree/chromium/TestShell.cpp:
2427         (TestShell::initialize):
2428         * DumpRenderTree/chromium/TestShell.h:
2429         (WebKit):
2430         * DumpRenderTree/chromium/TestShellMac.mm:
2431         (platformInit):
2432         * DumpRenderTree/chromium/TestShellWin.cpp:
2433         (platformInit):
2434         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2435         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2436         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2437         (WebThemeControlDRTWin::box):
2438         (WebThemeControlDRTWin::line):
2439         (WebThemeControlDRTWin::triangle):
2440         (WebThemeControlDRTWin::roundRect):
2441         (WebThemeControlDRTWin::oval):
2442         (WebThemeControlDRTWin::circle):
2443         (WebThemeControlDRTWin::nestedBoxes):
2444         (WebThemeControlDRTWin::markState):
2445         (WebThemeControlDRTWin::draw):
2446         (WebThemeControlDRTWin::drawTextField):
2447         (WebThemeControlDRTWin::drawProgressBar):
2448         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2449         (WebThemeControlDRTWin):
2450         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2451         (WebThemeEngineDRTMac):
2452         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2453         (+[FakeActiveWindow alwaysActiveWindow]):
2454         (+[FakeActiveWindow alwaysInactiveWindow]):
2455         (-[FakeActiveWindow initWithActiveControls:]):
2456         (-[FakeActiveWindow _hasActiveControls]):
2457         (WebThemeEngineDRTMac::paintScrollbarThumb):
2458         (stateToHIEnableState):
2459         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2460         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2461         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2462         (webRectToSkIRect):
2463         (drawControl):
2464         (drawTextField):
2465         (drawProgressBar):
2466         (WebThemeEngineDRTWin::paintButton):
2467         (WebThemeEngineDRTWin::paintMenuList):
2468         (WebThemeEngineDRTWin::paintScrollbarArrow):
2469         (WebThemeEngineDRTWin::paintScrollbarThumb):
2470         (WebThemeEngineDRTWin::paintScrollbarTrack):
2471         (WebThemeEngineDRTWin::paintSpinButton):
2472         (WebThemeEngineDRTWin::paintTextField):
2473         (WebThemeEngineDRTWin::paintTrackbar):
2474         (WebThemeEngineDRTWin::paintProgressBar):
2475         (WebThemeEngineDRTWin::getSize):
2476         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2477         (WebThemeEngineDRTWin):
2478         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2479
2480 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2481
2482         [Qt] Support -webkit-font-smoothing
2483         https://bugs.webkit.org/show_bug.cgi?id=106009
2484
2485         Reviewed by Jocelyn Turcotte.
2486
2487         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2488
2489         * DumpRenderTree/qt/TestRunnerQt.cpp:
2490         (TestRunnerQt::reset):
2491
2492 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2493
2494         [GTK] accessibility/aria-scrollbar-role.html is failing
2495         https://bugs.webkit.org/show_bug.cgi?id=98358
2496
2497         Reviewed by Martin Robinson.
2498
2499         Adds support for checking accessibility object's orientation.
2500         Orientation is checked by retrieving proper state of accessibility object.
2501
2502         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2503         (checkElementState):
2504         (AccessibilityUIElement::orientation):
2505         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2506         (WTR::AccessibilityUIElement::orientation):
2507
2508 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2509
2510         [chromium] move WebThemeEngine implementations to TestRunner library
2511         https://bugs.webkit.org/show_bug.cgi?id=112751
2512
2513         Reviewed by Adam Barth.
2514
2515         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2516         * DumpRenderTree/DumpRenderTree.gypi:
2517         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2518         (WebKit):
2519         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2520         (WebTestRunner::TestInterfaces::themeEngine):
2521         (WebTestRunner):
2522         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2523         (WebKit):
2524         (TestInterfaces):
2525         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2526         (WebTestRunner::WebTestInterfaces::themeEngine):
2527         (WebTestRunner):
2528         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2529         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2530         (WebTestRunner):
2531         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2532         (WebTestRunner::WebTestThemeControlWin::box):
2533         (WebTestRunner::WebTestThemeControlWin::line):
2534         (WebTestRunner::WebTestThemeControlWin::triangle):
2535         (WebTestRunner::WebTestThemeControlWin::roundRect):
2536         (WebTestRunner::WebTestThemeControlWin::oval):
2537         (WebTestRunner::WebTestThemeControlWin::circle):
2538         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2539         (WebTestRunner::WebTestThemeControlWin::markState):
2540         (WebTestRunner::WebTestThemeControlWin::draw):
2541         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2542         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2543         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2544         (WebTestRunner):
2545         (WebTestThemeControlWin):
2546         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2547         (WebTestRunner):
2548         (WebTestThemeEngineMac):
2549         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2550         (+[FakeActiveWindow alwaysActiveWindow]):
2551         (+[FakeActiveWindow alwaysInactiveWindow]):
2552         (-[FakeActiveWindow initWithActiveControls:]):
2553         (-[FakeActiveWindow _hasActiveControls]):
2554         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2555         (WebTestRunner):
2556         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2557         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2558         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2559         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2560         (WebTestRunner):
2561         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2562         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2563         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2564         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2565         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2566         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2567         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2568         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2569         (WebTestRunner::WebTestThemeEngineWin::getSize):
2570         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2571         (WebTestRunner):
2572         (WebTestThemeEngineWin):
2573         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2574         * DumpRenderTree/chromium/TestShell.cpp:
2575         (TestShell::initialize):
2576         * DumpRenderTree/chromium/TestShell.h:
2577         (WebKit):
2578         * DumpRenderTree/chromium/TestShellMac.mm:
2579         (platformInit):
2580         * DumpRenderTree/chromium/TestShellWin.cpp:
2581         (platformInit):
2582         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2583
2584 2013-03-19  Tony Chang  <tony@chromium.org>
2585
2586         Move testRunner.setTouchDragDropEnabled to internals.settings
2587         https://bugs.webkit.org/show_bug.cgi?id=112739
2588
2589         Reviewed by Adam Barth.
2590
2591         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2592         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2593         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2594         (TestRunner): Remove unnecessary code.
2595         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2596         (WebTestRunner::WebPreferences::reset):
2597         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2598
2599 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2600
2601         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2602         https://bugs.webkit.org/show_bug.cgi?id=112754
2603
2604         Reviewed by Darin Fisher.
2605
2606         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2607         now that it's always defined.
2608
2609         * DumpRenderTree/chromium/WebViewHost.cpp:
2610         * DumpRenderTree/chromium/WebViewHost.h:
2611         (WebViewHost):
2612
2613 2013-03-19  Kenneth Russell  <kbr@google.com>
2614
2615         Unreviewed, rolling out r146290.
2616         http://trac.webkit.org/changeset/146290
2617         https://bugs.webkit.org/show_bug.cgi?id=112751
2618
2619         Broke Chromium Mac build.
2620
2621         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2622         * DumpRenderTree/DumpRenderTree.gypi:
2623         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2624         (WebKit):
2625         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2626         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2627         (TestInterfaces):
2628         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2629         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2630         * DumpRenderTree/chromium/TestShell.cpp:
2631         (TestShell::initialize):
2632         * DumpRenderTree/chromium/TestShell.h:
2633         (WebKit):
2634         * DumpRenderTree/chromium/TestShellMac.mm:
2635         (platformInit):
2636         * DumpRenderTree/chromium/TestShellWin.cpp:
2637         (platformInit):
2638         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2639         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2640         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2641         (WebThemeControlDRTWin::box):
2642         (WebThemeControlDRTWin::line):
2643         (WebThemeControlDRTWin::triangle):
2644         (WebThemeControlDRTWin::roundRect):
2645         (WebThemeControlDRTWin::oval):
2646         (WebThemeControlDRTWin::circle):
2647         (WebThemeControlDRTWin::nestedBoxes):
2648         (WebThemeControlDRTWin::markState):
2649         (WebThemeControlDRTWin::draw):
2650         (WebThemeControlDRTWin::drawTextField):
2651         (WebThemeControlDRTWin::drawProgressBar):
2652         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2653         (WebThemeControlDRTWin):
2654         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2655         (WebThemeEngineDRTMac):
2656         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2657         (+[FakeActiveWindow alwaysActiveWindow]):
2658         (+[FakeActiveWindow alwaysInactiveWindow]):
2659         (-[FakeActiveWindow initWithActiveControls:]):
2660         (-[FakeActiveWindow _hasActiveControls]):
2661         (WebThemeEngineDRTMac::paintScrollbarThumb):
2662         (stateToHIEnableState):
2663         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2664         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2665         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2666         (webRectToSkIRect):
2667         (drawControl):
2668         (drawTextField):
2669         (drawProgressBar):
2670         (WebThemeEngineDRTWin::paintButton):
2671         (WebThemeEngineDRTWin::paintMenuList):
2672         (WebThemeEngineDRTWin::paintScrollbarArrow):
2673         (WebThemeEngineDRTWin::paintScrollbarThumb):
2674         (WebThemeEngineDRTWin::paintScrollbarTrack):
2675         (WebThemeEngineDRTWin::paintSpinButton):
2676         (WebThemeEngineDRTWin::paintTextField):
2677         (WebThemeEngineDRTWin::paintTrackbar):
2678         (WebThemeEngineDRTWin::paintProgressBar):
2679         (WebThemeEngineDRTWin::getSize):
2680         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2681         (WebThemeEngineDRTWin):
2682         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2683
2684 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2685
2686         [EFL] canvas-fallback-content.html is failing
2687         https://bugs.webkit.org/show_bug.cgi?id=111998
2688
2689         Reviewed by Chris Fleizach.
2690
2691         Adds support for getting platform name.
2692
2693         * DumpRenderTree/TestRunner.cpp:
2694         (TestRunner::staticValues):
2695         * DumpRenderTree/TestRunner.h:
2696         (TestRunner):
2697         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2698         (TestRunner::platformName):
2699
2700 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2701
2702         [chromium] move WebThemeEngine implementations to TestRunner library
2703         https://bugs.webkit.org/show_bug.cgi?id=112751
2704
2705         Reviewed by Adam Barth.
2706
2707         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2708         * DumpRenderTree/DumpRenderTree.gypi:
2709         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2710         (WebKit):
2711         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2712         (WebTestRunner::TestInterfaces::themeEngine):
2713         (WebTestRunner):
2714         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2715         (WebKit):
2716         (TestInterfaces):
2717         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2718         (WebTestRunner::WebTestInterfaces::themeEngine):
2719         (WebTestRunner):
2720         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2721         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2722         (WebTestRunner):
2723         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2724         (WebTestRunner::WebTestThemeControlWin::box):
2725         (WebTestRunner::WebTestThemeControlWin::line):
2726         (WebTestRunner::WebTestThemeControlWin::triangle):
2727         (WebTestRunner::WebTestThemeControlWin::roundRect):
2728         (WebTestRunner::WebTestThemeControlWin::oval):
2729         (WebTestRunner::WebTestThemeControlWin::circle):
2730         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2731         (WebTestRunner::WebTestThemeControlWin::markState):
2732         (WebTestRunner::WebTestThemeControlWin::draw):
2733         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2734         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2735         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2736         (WebTestRunner):
2737         (WebTestThemeControlWin):
2738         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2739         (WebTestRunner):
2740         (WebTestThemeEngineMac):
2741         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2742         (+[FakeActiveWindow alwaysActiveWindow]):
2743         (+[FakeActiveWindow alwaysInactiveWindow]):
2744         (-[FakeActiveWindow initWithActiveControls:]):
2745         (-[FakeActiveWindow _hasActiveControls]):
2746         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2747         (WebTestRunner):
2748         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2749         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2750         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2751         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2752         (WebTestRunner):
2753         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2754         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2755         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2756         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2757         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2758         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2759         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2760         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2761         (WebTestRunner::WebTestThemeEngineWin::getSize):
2762         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2763         (WebTestRunner):
2764         (WebTestThemeEngineWin):
2765         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2766         * DumpRenderTree/chromium/TestShell.cpp:
2767         (TestShell::initialize):
2768         * DumpRenderTree/chromium/TestShell.h:
2769         (WebKit):
2770         * DumpRenderTree/chromium/TestShellMac.mm:
2771         (platformInit):
2772         * DumpRenderTree/chromium/TestShellWin.cpp:
2773         (platformInit):
2774         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2775
2776 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2777
2778         [EFL][WK2] Separate WebView further from EwkView
2779         https://bugs.webkit.org/show_bug.cgi?id=111591
2780
2781         Reviewed by Caio Marcelo de Oliveira Filho.
2782
2783         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2784         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2785         since we can afford it having EWKViewGetWKView() private API to access WKView.
2786
2787         * TestWebKitAPI/PlatformWebView.h:
2788         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2789         (TestWebKitAPI::TEST):
2790         * TestWebKitAPI/efl/PlatformWebView.cpp:
2791         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2792         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2793         (TestWebKitAPI::PlatformWebView::resizeTo):
2794         (TestWebKitAPI::PlatformWebView::page):
2795         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2796         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2797         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2798         * WebKitTestRunner/PlatformWebView.h:
2799         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2800         (WTR::EventSenderProxy::dispatchEvent):
2801         (WTR::EventSenderProxy::keyDown):
2802         (WTR::EventSenderProxy::sendTouchEvent):
2803         (WTR::EventSenderProxy::setTouchModifier):
2804         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2805         (WTR::PlatformWebView::PlatformWebView):
2806         (WTR::PlatformWebView::~PlatformWebView):
2807         (WTR::PlatformWebView::resizeTo):
2808         (WTR::PlatformWebView::page):
2809         (WTR::PlatformWebView::focus):
2810         (WTR::PlatformWebView::windowSnapshotImage):
2811
2812 2013-03-19  Roger Fong  <roger_fong@apple.com>
2813
2814         Changes to VS2010 project files should only trigger builds on Windows bots.
2815         https://bugs.webkit.org/show_bug.cgi?id=112731
2816
2817         Reviewed by Timothy Horton.
2818
2819         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2820         (_should_file_trigger_build):
2821
2822 2013-03-19  Roger Fong  <roger_fong@apple.com>
2823
2824         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2825
2826         * Scripts/webkitpy/tool/steps/runtests.py:
2827         (RunTests.run):
2828         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2829         (RunTestsTest.test_webkit_run_unit_tests):
2830
2831 2013-03-19  Julie Parent  <jparent@chromium.org>
2832
2833         Dashboards: Introduce history namespace and unit tests.
2834         https://bugs.webkit.org/show_bug.cgi?id=112645
2835
2836         Reviewed by Ojan Vafai.
2837         
2838         Laying the framework for introducing the new history object and
2839         namespace.  This moves only static functions into the history
2840         namespace, and moves corresponding unit tests into seperate
2841         unit test file.
2842
2843         * TestResultServer/static-dashboards/aggregate_results.html:
2844         * TestResultServer/static-dashboards/dashboard_base.js:
2845         (parseCrossDashboardParameters):
2846         (parseDashboardSpecificParameters):
2847         (parseParameters):
2848         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2849         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2850         (.switch.return):
2851         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2852         * TestResultServer/static-dashboards/history.js: Added.
2853         * TestResultServer/static-dashboards/history_unittests.js: Added.
2854         * TestResultServer/static-dashboards/loader.js:
2855         (.):
2856         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2857         * TestResultServer/static-dashboards/run-unittests.html:
2858         * TestResultServer/static-dashboards/timeline_explorer.html:
2859         * TestResultServer/static-dashboards/timeline_explorer.js:
2860         * TestResultServer/static-dashboards/treemap.html:
2861         * TestResultServer/static-dashboards/treemap.js:
2862         (.switch.return):
2863         * TestResultServer/static-dashboards/ui.js:
2864
2865 2013-03-19  Daniel Bates  <dbates@webkit.org>
2866
2867         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2868         https://bugs.webkit.org/show_bug.cgi?id=112732
2869
2870         Reviewed by Eric Seidel.
2871
2872         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2873         of an existing file cannot be applied.
2874
2875         In particular, svn-{apply, unapply} compensate for differences in line endings
2876         by converting the line endings in a diff to match the line endings in the target
2877         file. The diff(1) command precedes the last line of a diff that adds a newline
2878         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2879         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2880         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2881         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2882         the newline characters in this special character sequence to match the line endings
2883         in the target file.
2884
2885         * Scripts/VCSUtils.pm:
2886         (parseDiff):
2887         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2888         Added tests:
2889             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2890             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2891             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2892             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2893         (escapeNewLineCharacters): Added.
2894         (toMacLineEndings): Added.
2895
2896 2013-03-19  James Robinson  <jamesr@chromium.org>
2897
2898         [chromium] Remove compositor settings that don't go through WebKit
2899         https://bugs.webkit.org/show_bug.cgi?id=112718
2900
2901         Reviewed by Adam Barth.
2902
2903         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2904         (main):
2905         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2906         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2907         (WebTestRunner::WebPreferences::reset):
2908         (WebTestRunner::WebPreferences::applyTo):
2909         * DumpRenderTree/chromium/TestShell.cpp:
2910         (TestShell::TestShell):
2911         (TestShell::resetWebSettings):
2912         * DumpRenderTree/chromium/TestShell.h:
2913         (TestShell):
2914
2915 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
2916
2917         Unreviewed, rolling out r146101.
2918         https://bugs.webkit.org/show_bug.cgi?id=111884
2919
2920         re-enable custom freetype on asan; this needs to be on
2921         now that the bot is running lucid.
2922
2923         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2924
2925 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
2926
2927         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
2928         https://bugs.webkit.org/show_bug.cgi?id=112365
2929
2930         Reviewed by Benjamin Poulain.
2931
2932         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
2933         harcoding it in wtf/Platform.h
2934
2935         * Scripts/webkitperl/FeatureList.pm:
2936
2937 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2938
2939         [Qt] Make ImageDiff similar to Chromium's ImageDiff
2940         https://bugs.webkit.org/show_bug.cgi?id=94782
2941
2942         Based on patch by Csaba Osztrogonác.
2943         Reviewed by Jocelyn Turcotte.
2944
2945         The diff image is generated with bright red indicating errors, but letting the base image
2946         shine through so the context of the error-pixel can be identified.
2947
2948         * DumpRenderTree/qt/ImageDiff.cpp:
2949         (main):
2950
2951 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
2952
2953         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
2954
2955         Rubber-stamped by Csaba Osztrogonác.
2956
2957         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
2958         since the latter might not cover the former.
2959
2960         * QtTestBrowser/launcherwindow.cpp:
2961         (LauncherWindow::print):
2962
2963 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2964
2965         Style tweeks to default.css.
2966         
2967         Rubber-stamped by David Kilzer.
2968         
2969         Give visited links a different color to other links, so you can
2970         see which builds you've viewed.
2971         
2972         Make the <small> text less tiny.
2973
2974         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2975         (small):
2976         (a:link,a:visited,a:active):
2977         (a:visited):
2978
2979 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2980
2981         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
2982         https://bugs.webkit.org/show_bug.cgi?id=112494
2983
2984         Reviewed by Dirk Pranke.
2985
2986         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
2987         Also merged two pairs of methods to cleanup the code.
2988
2989         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2990         (PerfTestsRunner.run): Merged _upload_and_show_results.
2991         (PerfTestsRunner._generate_results): Merged _generate_output_files.
2992
2993 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2994
2995         [chromium] build xdisplaycheck when building DRT
2996         https://bugs.webkit.org/show_bug.cgi?id=112636
2997
2998         Reviewed by Tony Chang.
2999
3000         It appears that we need xdisplaycheck to be built in order for
3001         Xvfb to be started correctly on the bots, and DRT was missing
3002         a dependency on it. This may be the cause of the ASAN bot not
3003         starting up properly (it only builds DRT).
3004
3005         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3006
3007 2013-03-18  David Levin  <levin@chromium.org>
3008
3009         Implement icon change notification dump for Chromium's test shell.
3010         https://bugs.webkit.org/show_bug.cgi?id=112614
3011
3012         This was previously implemented for some other platforms in r58111
3013         and r116547.
3014
3015         In r122806, fast/dom/icon-url-property.html stopped using it, but
3016         it is useful for tests, so I plan to re-add it to that test again.
3017
3018         Reviewed by Jochen Eisinger.
3019
3020         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3021         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3022          icon change notifications from WebKit may be logged in test output.
3023         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3024         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3025         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3026         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3027         (WebTestRunner):
3028         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3029         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3030         (TestRunner):
3031         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3032         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3033         (WebTestRunner):
3034         * DumpRenderTree/chromium/WebViewHost.cpp:
3035         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3036         * DumpRenderTree/chromium/WebViewHost.h:
3037         (WebViewHost):
3038
3039 2013-03-18  Julie Parent  <jparent@chromium.org>
3040
3041         Cleanup: Move js for treemap and aggregate_results into own js files.
3042         https://bugs.webkit.org/show_bug.cgi?id=112618
3043
3044         Reviewed by Dirk Pranke.
3045         
3046         No functional changes, just moving the code into separate js file
3047         rather than inlined in the html, so we can test it, make it more
3048         modular, etc.  Other dashboard types are already done this way.
3049
3050         * TestResultServer/static-dashboards/aggregate_results.html:
3051         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3052         (generatePage):
3053         (handleValidHashParameter):
3054         (htmlForBuilder):
3055         (rawValuesHTML):
3056         (chartHTML):
3057         (filteredValues):
3058         (chart):
3059         (htmlForRevisionRows):
3060         (wrapHTMLInTable):
3061         (htmlForSummaryTable):
3062         (valuesPerExpectation):
3063         (htmlForTestType):
3064         (htmlForTableRow):
3065         (extendedEncode):
3066         * TestResultServer/static-dashboards/treemap.html:
3067         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3068         (humanReadableTime):
3069         (convertToWebTreemapFormat):
3070         (reverseSortByAverage):
3071         (generatePage):
3072         (focusPath):
3073         (.switch.return):
3074         (handleQueryParameterChange):
3075         (extractName):
3076         (fullName):
3077         (handleFocus.):
3078         (handleFocus):
3079
3080 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3081
3082         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3083         https://bugs.webkit.org/show_bug.cgi?id=112622
3084
3085         Reviewed by Dirk Pranke.
3086
3087         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3088         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3089
3090 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3091
3092         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3093         https://bugs.webkit.org/show_bug.cgi?id=112619
3094
3095         Reviewed by Dirk Pranke.
3096
3097         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3098         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3099
3100         * Scripts/webkitpy/layout_tests/port/gtk.py:
3101         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3102         Port._webkit_baseline_path method.
3103         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3104         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3105         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3106         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3107         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3108         that are expected based on the builder name.
3109
3110 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3111
3112         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3113         https://bugs.webkit.org/show_bug.cgi?id=112571
3114
3115         Reviewed by Adam Barth.
3116
3117         Update function declarations for new WebFileSystemType enum. (All
3118         changes are behind an #ifdef so we can sync required changes in embedders.)
3119
3120         * DumpRenderTree/chromium/WebViewHost.cpp:
3121         (WebViewHost::openFileSystem):
3122         (WebViewHost::deleteFileSystem):
3123         * DumpRenderTree/chromium/WebViewHost.h:
3124         (WebViewHost):
3125
3126 2013-03-18  Julie Parent  <jparent@chromium.org>
3127
3128         Cleanup: Move timeline_exporer js out of html file into js.
3129         https://bugs.webkit.org/show_bug.cgi?id=112188
3130
3131         Reviewed by Dirk Pranke.
3132         
3133         Moves the javascript out of the html file and into a new js file.
3134         This follows the format of flakiness_dashboard.{html|js}.
3135         
3136         Also moves code from dashboard_base that is used only by this one
3137         dashboard, and makes it private to the dashboard.
3138
3139         * TestResultServer/static-dashboards/dashboard_base.js:
3140         * TestResultServer/static-dashboards/timeline_explorer.html:
3141         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3142         (generatePage):
3143         (initCurrentBuilderTestResults):
3144         (shouldShowWebKitRevisionsOnly):
3145         (updateTimelineForBuilder.):
3146         (updateTimelineForBuilder):
3147         (selectBuild):
3148         (updateBuildIndicator):
3149         (.addRow):
3150         (.addNumberRow):
3151         (.inspectorNode.getElementsByTagName.0.onclick):
3152         (.inspectorNode.getElementsByTagName.1.onclick):
3153         (.inspectorNode.getElementsByTagName.2.onclick):
3154         (updateBuildInspector):
3155         (showResultsDelta):
3156         (decompressResults.addFlakyDelta):
3157         (decompressResults):
3158
3159 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3160
3161         Unreviewed, rolling out r145272.
3162         http://trac.webkit.org/changeset/145272
3163         https://bugs.webkit.org/show_bug.cgi?id=111884
3164
3165         Turns out the ASAN build is still broken; possibly there's
3166         something still setting LD_LIBRARY_PATH, or possibly there's
3167         something else wrong. In the meantime, we need it to work again.
3168
3169         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3170
3171 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3172
3173         delete-stale-build-files is too aggressive
3174         https://bugs.webkit.org/show_bug.cgi?id=112595
3175
3176         Reviewed by Tim Horton.
3177
3178         It appears that whitelisting file extensions to keep is not a good idea.
3179         Blacklist files to delete instead, and only delete .o files for now.
3180         We can add more file extensions as needed.
3181
3182         * BuildSlaveSupport/delete-stale-build-files:
3183
3184 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3185
3186         Disable accessibility notifications after each test
3187         https://bugs.webkit.org/show_bug.cgi?id=112579
3188
3189         Reviewed by Tim Horton.
3190         
3191         In WebKitTestRunner, if any tests triggered accessibility notifications,
3192         the global notification handler would thereafter be active, and fire
3193         notifications for all subsequent tests.
3194         
3195         Fix by implementing AccessibilityController::resetToConsistentState() for
3196         Mac, and using it to clear the global notification handler.
3197
3198         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3199         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3200         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3201         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3202         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3203         (e.g. because of -autorelease).
3204         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3205         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3206         if there is one.
3207         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3208         Add -stopObserving
3209         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3210         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3211         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3212         center.
3213
3214 2013-03-18  Dana Jansens  <danakj@chromium.org>
3215
3216         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3217         https://bugs.webkit.org/show_bug.cgi?id=112392
3218
3219         Reviewed by James Robinson.
3220
3221         Removes the command line flag option from DRT.
3222
3223         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3224         (main):
3225
3226 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3227
3228         [GTK] plugins/plugin-clip-subframe.html is failing
3229         https://bugs.webkit.org/show_bug.cgi?id=112570
3230
3231         Reviewed by Martin Robinson.
3232
3233         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3234
3235 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3236
3237         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3238         https://bugs.webkit.org/show_bug.cgi?id=112442
3239
3240         Reviewed by Gustavo Noronha Silva.
3241
3242         * GtkLauncher/main.c:
3243         (reloadCb):
3244         (createToolbar):
3245         (createWindow):
3246
3247 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3248
3249         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3250         https://bugs.webkit.org/show_bug.cgi?id=112205
3251
3252         Disable this API test until Geoff can fix it.
3253
3254         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3255         (TestWebKitAPI::TEST):
3256
3257 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3258
3259         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3260         https://bugs.webkit.org/show_bug.cgi?id=112478
3261
3262         Reviewed by Tony Chang.
3263
3264         There is nothing that ensures that the log messages from the plugin
3265         come in before the layout test finished loading.
3266
3267         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3268         (PassDifferentNPPStruct::NPP_SetWindow):
3269         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3270         (NPP_SetWindow):
3271
3272 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3273
3274         Have the mac port support per_test_timeout in webkitpy
3275         https://bugs.webkit.org/show_bug.cgi?id=112466
3276
3277         Reviewed by Dirk Pranke.
3278         
3279         Both WTR and DRT handle --timeout arguments, so we can
3280         have the scripts pass the timeout values down to the tools.
3281
3282         * Scripts/webkitpy/layout_tests/port/mac.py:
3283         (MacPort.supports_per_test_timeout):
3284
3285 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3286
3287         Remove setAsynchronousSpellCheckingEnabled from test runners
3288         https://bugs.webkit.org/show_bug.cgi?id=112362
3289
3290         Reviewed by Tony Chang.
3291
3292         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3293         in internals.settings, so all ports can share it.
3294
3295         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3296         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3297         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3298         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3299         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3300         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3301         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3302         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3303         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3304         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3305         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3306         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3307
3308 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3309
3310         Fix the stupid unit tests.
3311
3312         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3313         (test_sample_process):
3314
3315 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3316
3317         Collect samples for unresponsive web processes
3318         https://bugs.webkit.org/show_bug.cgi?id=112409
3319
3320         Reviewed by Tim Horton.
3321         
3322         When we detect that a subprocess was unresponsive, run the 'sample'
3323         tool on that process, for the Mac port.
3324         
3325         The sample will be linked to from the results.html page, next
3326         to the crash log link.
3327
3328         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3329         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3330         look for samples on disk.
3331         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3332         (TestResultWriter):
3333         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3334         -sample.txt files, and have it copy their contents to a new file
3335         next to the test that spawned them (as we do for crash logs).
3336         * Scripts/webkitpy/layout_tests/port/base.py:
3337         (Port.look_for_new_samples): Base class does nothing for sampling.
3338         * Scripts/webkitpy/layout_tests/port/driver.py:
3339         (Driver._check_for_driver_crash): Kick off a sample if we detected
3340         that the subprocess was unresponsive.
3341         * Scripts/webkitpy/layout_tests/port/mac.py:
3342         (MacPort.sample_file_path): Utility to generate the file path
3343         to the generated sample files at the top level of layout-test-results.
3344         (MacPort.look_for_new_crash_logs): Fix typo
3345         (MacPort.look_for_new_samples): New function to find sample files.
3346         (MacPort.sample_process): Use the utility function to get the file path.
3347
3348 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3349
3350         [Qt] Remove simple getters and setters from TestRunnerQt
3351         https://bugs.webkit.org/show_bug.cgi?id=112343
3352
3353         Reviewed by Benjamin Poulain.
3354
3355         The removed functions and boolean members
3356         are being replaced by the implementations in the
3357         generic TestRunner.h.
3358
3359         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3360         (DumpRenderTree::dumpFrameScrollPosition):
3361         (DumpRenderTree::dumpFramesAsText):
3362         (DumpRenderTree::dump):
3363         (DumpRenderTree::titleChanged):
3364         (DumpRenderTree::dumpDatabaseQuota):
3365         (DumpRenderTree::dumpApplicationCacheQuota):
3366         (DumpRenderTree::statusBarMessage):
3367         (DumpRenderTree::createWindow):
3368         * DumpRenderTree/qt/TestRunnerQt.cpp:
3369         (TestRunnerQt::reset):
3370         * DumpRenderTree/qt/TestRunnerQt.h:
3371         (TestRunnerQt):
3372
3373 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3374
3375         Update the link on build.webkit.org to refer to perf.webkit.org
3376         https://bugs.webkit.org/show_bug.cgi?id=112416
3377
3378         Reviewed by Philip Rogers.
3379
3380         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3381
3382         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3383
3384 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3385
3386         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3387         https://bugs.webkit.org/show_bug.cgi?id=112394
3388
3389         Reviewed by Philippe Normand.
3390
3391         * GtkLauncher/main.c:
3392         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3393
3394 2013-03-14  Andreas Kling  <akling@apple.com>
3395
3396         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3397         <http://webkit.org/b/111815>
3398         <rdar://problem/13380145>
3399
3400         Reviewed by Anders Carlsson.
3401
3402         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3403         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3404         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3405
3406         * WebKitTestRunner/PlatformWebView.h:
3407         (PlatformWebView):
3408         * WebKitTestRunner/TestController.cpp:
3409         (WTR::TestController::createOtherPage):
3410         (WTR::TestController::createWebViewWithOptions):
3411         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3412         (WTR::PlatformWebView::didInitializeClients):
3413
3414 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3415
3416         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3417         https://bugs.webkit.org/show_bug.cgi?id=112122
3418
3419         Reviewed by Kenneth Rohde Christiansen.
3420
3421         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3422
3423         * MiniBrowser/efl/main.c:
3424         (_Browser_Window):
3425         (search_box_show):
3426         (search_box_hide):
3427         (on_key_down):
3428         (on_url_changed):
3429         (on_search_field_aborted):
3430         (on_search_field_activated):
3431         (on_search_field_clicked):
3432         (on_search_backward_button_clicked):
3433         (on_search_forward_button_clicked):
3434         (window_create):
3435
3436 2013-03-14  Julie Parent  <jparent@chromium.org>
3437
3438         Cleanup: Remove g_resourceLoader.
3439         https://bugs.webkit.org/show_bug.cgi?id=112305
3440
3441         Reviewed by Dirk Pranke.
3442         
3443         Removing another global.
3444         
3445         Now, each dashboard creates its own loader, rather than having
3446         a general global one.
3447         
3448         Remove usage of g_resourceLoader.isLoadingComplete from 
3449         handleLocationChange by ensuring that handleLocationChange is
3450         never called before the loader is done.  It was called in two
3451         places before: 1 was from the callback when the loader is done,
3452         so that was obviously true, and the other was from onhashchange,
3453         where it would just return rather than running.  Instead, lets
3454         only register the onhashchange handler once the loader is
3455         setup, so the check is no longer necessary.
3456         
3457         Remove isLoadingComplete since it is now unused.
3458         
3459         Callback for loader is now initializeHistory, rather than just
3460         handleLocationChange which will set up the hashchange handler now.
3461         This will all eventually be moving to a new History object.
3462
3463         * TestResultServer/static-dashboards/aggregate_results.html:
3464         * TestResultServer/static-dashboards/dashboard_base.js:
3465         (handleLocationChange):
3466         (intializeHistory):
3467         (decompressResults):
3468         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3469         (generatePage):
3470         * TestResultServer/static-dashboards/loader.js:
3471         (.):
3472         * TestResultServer/static-dashboards/loader_unittests.js:
3473         * TestResultServer/static-dashboards/timeline_explorer.html:
3474         * TestResultServer/static-dashboards/treemap.html:
3475
3476 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3477
3478         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3479         https://bugs.webkit.org/show_bug.cgi?id=109404
3480
3481         Reviewed by Tony Chang.
3482
3483         Removes all the code related to smartInsertDeleteEnabled and
3484         selectTrailingWhitespaceEnabled settings as they will be managed from
3485         internals from now on.
3486
3487         * DumpRenderTree/TestRunner.cpp:
3488         (TestRunner::staticFunctions):
3489         * DumpRenderTree/TestRunner.h:
3490         (TestRunner):
3491         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3492         (WebKit):
3493         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3494         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3495         (DumpRenderTree):
3496         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3497         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3498         (WebTestRunner::WebTestProxy::didStopLoading):
3499         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3500         (WebTestRunner::TestRunner::TestRunner):
3501         (WebTestRunner::TestRunner::reset):
3502         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3503         (TestRunner):
3504         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3505         (WebTestRunner::WebPreferences::applyTo): Set default values for
3506         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3507         Chromium DRT default values are different from Chromium browser.
3508         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3509         * DumpRenderTree/chromium/WebViewHost.cpp:
3510         * DumpRenderTree/chromium/WebViewHost.h:
3511         (WebViewHost):
3512         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3513         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3514         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3515         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3516         (resetDefaultsToConsistentValues):
3517         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3518         * DumpRenderTree/mac/DumpRenderTree.mm:
3519         (resetWebViewToConsistentStateBeforeTesting):
3520         * DumpRenderTree/mac/TestRunnerMac.mm:
3521         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3522         (WebCore::WebPage::resetSettings):
3523         * DumpRenderTree/qt/TestRunnerQt.cpp:
3524         * DumpRenderTree/qt/TestRunnerQt.h:
3525         (TestRunnerQt):
3526         * DumpRenderTree/win/DumpRenderTree.cpp:
3527         (resetWebViewToConsistentStateBeforeTesting):
3528         * DumpRenderTree/win/TestRunnerWin.cpp:
3529         * DumpRenderTree/wx/TestRunnerWx.cpp:
3530
3531 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3532
3533         [Qt] Disable DRT on Windows
3534
3535         Reviewed by Jocelyn Turcotte.
3536
3537         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3538
3539         * qmake/mkspecs/features/configure.prf:
3540
3541 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3542
3543         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
3544         https://bugs.webkit.org/show_bug.cgi?id=110728
3545
3546         Reviewed by Gyuyoung Kim.
3547
3548         Use the page group to create the view object.
3549
3550         * MiniBrowser/efl/main.c:
3551         (window_create):
3552
3553 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3554
3555         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
3556
3557         Reviewed by Tor Arne Vestbø.
3558
3559         The mock versions of these web facing features should be instantiated when
3560         running in DumpRenderTree only. In order for them to work, no extra Qt modules
3561         such as QtLocation are actually needed.
3562
3563         This patch decouples enabling device orientation/motion and geolocation from
3564         the underlying Qt modules and makes them available in developer builds
3565         (!production_build) and backed by mock backends when running in drt.
3566
3567         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
3568         developers the web facing features are always enabled (although requests will
3569         time out) and the mock backends are enabled inside DRT, allowing for the layout
3570         tests to run with less dependencies.
3571
3572         In addition this also enables the mock device motion client, which was
3573         previously never instantiated.
3574
3575         * qmake/mkspecs/features/features.prf:
3576
3577 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3578
3579         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
3580         https://bugs.webkit.org/show_bug.cgi?id=112340
3581
3582         Reviewed by Simon Hausmann.
3583
3584         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3585         (DumpRenderTree::dump):
3586             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
3587         (DumpRenderTree::dumpApplicationCacheQuota):
3588         * DumpRenderTree/qt/TestRunnerQt.cpp:
3589         (TestRunnerQt::reset):
3590         * DumpRenderTree/qt/TestRunnerQt.h:
3591         (TestRunnerQt):
3592
3593 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3594
3595         [Qt] Port DRT to use TestRunner::dumpAsText()
3596         https://bugs.webkit.org/show_bug.cgi?id=112260
3597
3598         Reviewed by Benjamin Poulain.
3599
3600         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3601         (WebCore::DumpRenderTree::open):
3602         (WebCore::methodNameStringForFailedTest):
3603             Change parameter from type TestRunnerQt* to TestRunner*.
3604         (WebCore::DumpRenderTree::dump):
3605             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3606             Instead we should rely on TestRunner::generatePixelResults().
3607         * DumpRenderTree/qt/TestRunnerQt.cpp:
3608         (TestRunnerQt::reset):
3609         * DumpRenderTree/qt/TestRunnerQt.h:
3610         (TestRunnerQt):
3611
3612 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3613
3614         Implement FontLoader interface
3615         https://bugs.webkit.org/show_bug.cgi?id=98395
3616
3617         Reviewed by Eric Seidel.
3618
3619         Enable FontLoadEvents runtime flag for TestShell.
3620
3621         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3622         (WebTestRunner::TestInterfaces::TestInterfaces):
3623
3624 2013-03-13  Julie Parent  <jparent@chromium.org>
3625
3626         CLeanup: remove unnecessary call to parseParameters.
3627         https://bugs.webkit.org/show_bug.cgi?id=112309
3628
3629         Reviewed by Ojan Vafai.
3630         
3631         We call parseCrossDashboardParameters when the dashboard initially
3632         loads to set the state required for loadBuildersList, and then we
3633         call it again once we are fully done with loading, so there is no
3634         reason to call it in the middle of the loading process here.
3635
3636         * TestResultServer/static-dashboards/loader.js:
3637         (.):
3638
3639 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3640
3641         Unreviewed. Now I'm a reviewer :)
3642
3643         * Scripts/webkitpy/common/config/committers.py:
3644
3645 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3646
3647         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3648         https://bugs.webkit.org/show_bug.cgi?id=112277
3649
3650         Reviewed by Adam Barth.
3651
3652         * Scripts/webkitperl/FeatureList.pm:
3653         * qmake/mkspecs/features/features.pri:
3654
3655 2013-03-13  Adam Barth  <abarth@webkit.org>
3656
3657         run-perf-tests should support content_shell
3658         https://bugs.webkit.org/show_bug.cgi?id=112291
3659
3660         Reviewed by Eric Seidel.
3661
3662         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3663         (PerfTestsRunner._parse_args):
3664
3665 2013-03-13  Oliver Hunt  <oliver@apple.com>
3666
3667         Simplify Checked<> multiplication
3668         https://bugs.webkit.org/show_bug.cgi?id=112286
3669
3670         Reviewed by James Robinson.
3671
3672         Add tests for multiplication by zero and max to ensure we don't
3673         mess them up should we ever make changes to Checked<> in future.
3674
3675         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3676         (TestWebKitAPI):
3677
3678 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3679
3680         [Qt] Unreviewed prospective Windows build fix
3681
3682         Do the usual thing, include the moc generated code in the .cpp file instead
3683         of compiling it standalone, to ensure that config.h is included, too, and
3684         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3685
3686         * DumpRenderTree/qt/EventSenderQt.cpp:
3687
3688 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3689
3690         [Qt] Port TestRunner::findString to shared interface
3691         https://bugs.webkit.org/show_bug.cgi?id=112147
3692
3693         Reviewed by Jocelyn Turcotte.
3694
3695         This patch also removes DumpRenderTree and some other helper classes from
3696         the WebCore namespace, to which they do not really belong.
3697
3698         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3699         (main):
3700         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3701         (DumpRenderTree::DumpRenderTree):
3702         (DumpRenderTree::~DumpRenderTree):
3703         (DumpRenderTree::instance):
3704         (DumpRenderTree::setShouldTimeout):
3705         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3706         (DumpRenderTree):
3707         * DumpRenderTree/qt/EventSenderQt.cpp:
3708         (EventSender::contextClick):
3709         (EventSender::sendEvent):
3710         (EventSender::postEvent):
3711         * DumpRenderTree/qt/EventSenderQt.h:
3712         (EventSender::isGraphicsBased):
3713         * DumpRenderTree/qt/TestRunnerQt.cpp:
3714         (TestRunnerQt::TestRunnerQt):
3715         (TestRunner::findString):
3716         (TestRunnerQt::setMockDeviceOrientation):
3717         (TestRunnerQt::setGeolocationPermission):
3718         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3719         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3720         (TestRunnerQt::setMockGeolocationPosition):
3721         * DumpRenderTree/qt/TestRunnerQt.h:
3722         (TestRunnerQt):
3723
3724 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3725
3726         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3727         https://bugs.webkit.org/show_bug.cgi?id=112129
3728
3729         Reviewed by Adam Barth.
3730
3731         Following Chromium
3732         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3733         this is being renamed to better explain what it does.
3734
3735         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3736
3737 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3738
3739         [Qt] Unreviewed trivial typo fix
3740
3741         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3742         TextRunner.h. Thanks Zeno :)
3743
3744 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3745
3746         [Qt] Prepare DRT for transition to shared TestRunner interface
3747         https://bugs.webkit.org/show_bug.cgi?id=112144
3748
3749         Reviewed by Benjamin Poulain.
3750
3751         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3752         the JSC C API based one.
3753
3754         This is impplemented by instantiating the QObject based testRunner in
3755         the global object, then instantiating the JSC C based TestRunner
3756         separately and placing it "behind" the QObject based testRunner through
3757         injection of the individual functions through proxies. (prototype
3758         chaining doesn't work due to the this object and Function.prototype.bind
3759         doesn't work due to the native function)
3760
3761         This allows for porting over method by method by removing the method
3762         from the QObject TestRunnerQt and implementing it in the JSC C based
3763         TestRunner.
3764
3765         In order for this to link and run dummy implementations of all the
3766         necessary TestRunner functions are provided.
3767
3768         * DumpRenderTree/qt/DumpRenderTree.pro:
3769         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3770         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3771         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3772         (WebCore::DumpRenderTree::initJSObjects):
3773         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3774         (DumpRenderTree):
3775         * DumpRenderTree/qt/TestRunnerQt.cpp:
3776         (TestRunner::~TestRunner):
3777         (TestRunner::addDisallowedURL):
3778         (TestRunner::queueLoad):
3779         (TestRunner::removeAllVisitedLinks):
3780         (TestRunner::setAcceptsEditing):
3781         (TestRunner::simulateLegacyWebNotificationClick):
3782         (TestRunner::setWindowIsKey):
3783         (TestRunner::setAlwaysAcceptCookies):
3784         (TestRunner::addOriginAccessWhitelistEntry):
3785         (TestRunner::setWebViewEditable):
3786         (TestRunner::clearAllApplicationCaches):
3787         (TestRunner::setTextDirection):
3788         (TestRunner::notifyDone):
3789         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3790         (TestRunner::overridePreference):
3791         (TestRunner::pathToLocalResource):
3792         (TestRunner::removeAllWebNotificationPermissions):
3793         (TestRunner::simulateWebNotificationClick):
3794         (TestRunner::closeIdleLocalStorageDatabases):
3795         (TestRunner::focusWebView):
3796         (TestRunner::setBackingScaleFactor):
3797         (TestRunner::removeChromeInputField):
3798         (TestRunner::addChromeInputField):
3799         (TestRunner::originsWithLocalStorage):
3800         (TestRunner::deleteAllLocalStorage):
3801         (TestRunner::deleteLocalStorageForOrigin):
3802         (TestRunner::observeStorageTrackerNotifications):
3803         (TestRunner::syncLocalStorage):
3804         (TestRunner::windowCount):
3805         (TestRunner::setWaitToDump):
3806         (TestRunner::waitForPolicyDelegate):
3807         (TestRunner::webHistoryItemCount):
3808         (TestRunner::showWebInspector):
3809         (TestRunner::closeWebInspector):
3810         (TestRunner::evaluateInWebInspector):
3811         (TestRunner::setSerializeHTTPLoads):
3812         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3813         (TestRunner::setCustomPolicyDelegate):
3814         (TestRunner::setDatabaseQuota):
3815         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3816         (TestRunner::resetPageVisibility):
3817         (TestRunner::keepWebHistory):
3818         (TestRunner::goBack):
3819         (TestRunner::originsWithApplicationCache):
3820         (TestRunner::applicationCacheDiskUsageForOrigin):
3821         (TestRunner::display):
3822         (TestRunner::dispatchPendingLoadRequests):
3823         (TestRunner::clearPersistentUserStyleSheet):
3824         (TestRunner::callShouldCloseOnWebView):
3825         (TestRunner::copyDecodedHostName):
3826         (TestRunner::clearBackForwardList):
3827         (TestRunner::clearAllDatabases):
3828         (TestRunner::clearApplicationCacheForOrigin):
3829         (TestRunner::apiTestGoToCurrentBackForwardItem):
3830         (TestRunner::authenticateSession):
3831         (TestRunner::abortModal):
3832         (TestRunner::setStorageDatabaseIdleInterval):
3833         (TestRunner::setAsynchronousSpellCheckingEnabled):
3834         (TestRunner::setXSSAuditorEnabled):
3835         (TestRunner::setSpatialNavigationEnabled):
3836         (TestRunner::setScrollbarPolicy):
3837         (TestRunner::setJavaScriptCanAccessClipboard):
3838         (TestRunner::setAutomaticLinkDetectionEnabled):
3839         (TestRunner::setUserStyleSheetEnabled):
3840         (TestRunner::setUserStyleSheetLocation):
3841         (TestRunner::setUseDashboardCompatibilityMode):
3842         (TestRunner::setTabKeyCyclesThroughElements):
3843         (TestRunner::setSmartInsertDeleteEnabled):
3844         (TestRunner::setSelectTrailingWhitespaceEnabled):
3845         (TestRunner::setPrivateBrowsingEnabled):
3846         (TestRunner::setPluginsEnabled):
3847         (TestRunner::setPopupBlockingEnabled):
3848         (TestRunner::setMockSpeechInputDumpRect):
3849         (TestRunner::setPersistentUserStyleSheetLocation):
3850         (TestRunner::setMockGeolocationPosition):
3851         (TestRunner::setMockGeolocationPositionUnavailableError):
3852         (TestRunner::setMockDeviceOrientation):
3853         (TestRunner::setMainFrameIsFirstResponder):
3854         (TestRunner::setIconDatabaseEnabled):
3855         (TestRunner::setGeolocationPermission):
3856         (TestRunner::setDefersLoading):
3857         (TestRunner::setCacheModel):
3858         (TestRunner::setAuthorAndUserStylesEnabled):
3859         (TestRunner::setAllowFileAccessFromFileURLs):
3860         (TestRunner::setAppCacheMaximumSize):
3861         (TestRunner::setAllowUniversalAccessFromFileURLs):
3862         (TestRunner::setApplicationCacheOriginQuota):
3863         (TestRunner::denyWebNotificationPermission):
3864         (TestRunner::grantWebNotificationPermission):
3865         (TestRunner::setValueForUser):
3866         (TestRunner::setViewModeMediaFeature):
3867         (TestRunner::setPageVisibility):
3868         (TestRunner::addMockSpeechInputResult):
3869         (TestRunner::removeOriginAccessWhitelistEntry):
3870         (TestRunner::addUserScript):
3871         (TestRunner::isCommandEnabled):
3872         (TestRunner::evaluateScriptInIsolatedWorld):
3873         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3874         (TestRunner::copyEncodedHostName):
3875         (TestRunner::addUserStyleSheet):
3876         (TestRunner::findString):
3877         (TestRunner::execCommand):
3878         (TestRunner::localStorageDiskUsageForOrigin):
3879
3880 2013-03-12  Julie Parent  <jparent@chromium.org>
3881
3882         Cleanup: Move flatten-trie to loader.
3883         https://bugs.webkit.org/show_bug.cgi?id=112196
3884
3885         Reviewed by Dirk Pranke.
3886
3887         flatten-trie is used only by the loader, so move it there and make it
3888         private, rather than global in dashbaord_base. Moved the corresponding
3889         unit test from flakiness_dashboard_unittests to loader_unittests.
3890         
3891         * TestResultServer/static-dashboards/dashboard_base.js:
3892         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3893         * TestResultServer/static-dashboards/loader.js:
3894         (.):
3895         * TestResultServer/static-dashboards/loader_unittests.js:
3896
3897 2013-03-12  Oliver Hunt  <oliver@apple.com>
3898
3899         Unbreak api tests
3900
3901         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3902         (TestWebKitAPI):
3903
3904 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3905
3906         Unreviewed, disabling tests for Win EWS.
3907
3908         win-ews obviously cannot keep up with running tests, it's >300 behind.
3909         Probably doesn't help that its (likely) running tests serially.
3910
3911         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3912         (WinEWS):
3913
3914 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3915
3916         Add a --build-directory argument to delete-stale-build-files
3917         https://bugs.webkit.org/show_bug.cgi?id=112198
3918
3919         Reviewed by Ryosuke Niwa.
3920
3921         * BuildSlaveSupport/delete-stale-build-files:
3922         (main): Add --build-directory argument.
3923
3924 2013-03-12  Oliver Hunt  <oliver@apple.com>
3925
3926         Appease MSVC
3927
3928         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3929         (TestWebKitAPI):
3930
3931 2013-03-12  Oliver Hunt  <oliver@apple.com>
3932
3933         Add more Checked<> tests
3934         https://bugs.webkit.org/show_bug.cgi?id=112190
3935
3936         Reviewed by Geoffrey Garen.
3937
3938         Tests!
3939
3940         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3941         (TestWebKitAPI):
3942
3943 2013-03-12  Julie Parent  <jparent@chromium.org>
3944
3945         Cleanup: Move loading complete function into callback, rather than global.
3946         https://bugs.webkit.org/show_bug.cgi?id=112167
3947
3948         Reviewed by Dirk Pranke.
3949         
3950         Stop calling global functions, pass in proper handler to Loader
3951         constructor. Note that the callback is optional, as tests, and
3952         some potential dashboards, do not need one.
3953
3954         * TestResultServer/static-dashboards/dashboard_base.js:
3955         * TestResultServer/static-dashboards/loader.js:
3956         (.):
3957         * TestResultServer/static-dashboards/loader_unittests.js:
3958
3959 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3960
3961         [EFL][WK2] Add popup menu support to MiniBrowser
3962         https://bugs.webkit.org/show_bug.cgi?id=108934
3963
3964         Reviewed by Kenneth Rohde Christiansen.
3965
3966         Implement popup menu support in MiniBrowser by handling popup_menu_show
3967         and popup_menu_hide smart functions on the view and using the Ewk popup
3968         menu API.
3969
3970         * MiniBrowser/efl/main.c:
3971         (_Browser_Window):
3972         (on_popup_menu_discarded):
3973         (on_popup_menu_item_clicked):
3974         (popup_menu_populate):
3975         (on_popup_menu_show):
3976         (on_popup_menu_hide):
3977         (window_create): Use calloc() instead of malloc() to allocate memory for
3978         Browser_Window. This makes sure all the structs members are initialized
3979         to 0 (such as the new elm_popup_menu pointer).
3980
3981 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3982
3983         [GTK] Set up the libPlatformGtk.la library
3984         https://bugs.webkit.org/show_bug.cgi?id=111738
3985
3986         Reviewed by Martin Robinson.
3987
3988         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3989         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
3990         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3991
3992 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3993
3994         [GTK] Enable Web Audio in development builds
3995         https://bugs.webkit.org/show_bug.cgi?id=111831
3996
3997         Reviewed by Philippe Normand.
3998
3999         Web Audio is already quite well supported on the GTK port but still has a few issues
4000         that must be addressed before it is enabled by default. Despite that it should be enabled
4001         in development builds just so we are up-to-date with future feature infrastructure changes.
4002         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
4003         that's an obvious goal before enabling the feature in release builds.
4004
4005         * Scripts/webkitperl/FeatureList.pm:
4006
4007 2013-03-11  Andreas Kling  <akling@apple.com>
4008
4009         [Mac][WK1] Add support for alert() in MiniBrowser.
4010         <http://webkit.org/b/112090>
4011
4012         Reviewed by Anders Carlsson.
4013
4014         * MiniBrowser/mac/WK1BrowserWindowController.m:
4015         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
4016
4017 2013-03-11  Julie Parent  <jparent@chromium.org>
4018
4019         Dashboard cleanup: Create ui.Errors
4020         https://bugs.webkit.org/show_bug.cgi?id=111785
4021
4022         Reviewed by Ojan Vafai.
4023         
4024         Create ui.Errors for handling errors the dashboards
4025         encounter. Loader now has a Error object that it can add to,
4026         and individual dashboards can show errors when desired.
4027         Currently, only flakiness_db shows errors, but this is 
4028         generic and there is no reason why other dbs wouldn't want to
4029         show errors.
4030
4031         * TestResultServer/static-dashboards/dashboard_base.js:
4032         (resourceLoadingComplete):
4033         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4034         (generatePage):
4035         * TestResultServer/static-dashboards/loader.js:
4036         (.):
4037         * TestResultServer/static-dashboards/ui.js:
4038         (.):
4039
4040 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
4041
4042         Some StringHasher tests are broken because of missing null termination
4043         https://bugs.webkit.org/show_bug.cgi?id=111284
4044
4045         Reviewed by Darin Adler.
4046
4047         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
4048         (TestWebKitAPI): Added null termination since C strings are null-terminated.
4049         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
4050         the bug caught by it is now fixed.
4051
4052 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
4053
4054         Unreviewed, rolling out r145200.
4055         http://trac.webkit.org/changeset/145200
4056         https://bugs.webkit.org/show_bug.cgi?id=112063
4057
4058         Broke a couple of unit tests (Requested by zdobersek on
4059         #webkit).
4060
4061         * Scripts/webkitperl/FeatureList.pm:
4062
4063 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
4064
4065         [GTK] WebKit2-only build fails
4066         https://bugs.webkit.org/show_bug.cgi?id=112033
4067
4068         Reviewed by Gustavo Noronha Silva.
4069
4070         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
4071         generic part, WebKit1-specific part and WebKit2-specific part.
4072         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
4073         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
4074         directly.
4075
4076 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
4077
4078         Adding myself to the committers list.
4079
4080         Unreviewed.
4081
4082         * Scripts/webkitpy/common/config/committers.py:
4083
4084 2013-03-11  Jeff Rogers  <jrogers@rim.com>
4085
4086         [BlackBerry] Disable MathML support
4087         https://bugs.webkit.org/show_bug.cgi?id=111929
4088
4089         Reviewed by Rob Buis.
4090
4091         * Scripts/webkitperl/FeatureList.pm:
4092
4093 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4094
4095         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
4096         https://bugs.webkit.org/show_bug.cgi?id=111970
4097
4098         Reviewed by Chris Fleizach.
4099
4100         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
4101         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
4102         undefined symbol.
4103
4104         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4105         (WTR::AccessibilityUIElement::supportedActions):
4106         (WTR):
4107
4108 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
4109
4110         [chromium] Android apk targets should depend directly on Java library targets
4111         https://bugs.webkit.org/show_bug.cgi?id=111746
4112
4113         Reviewed by Eric Seidel.
4114
4115         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4116         Make DumpRenderTree_apk depend directly on base_java and net_java.
4117         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
4118         Make TestWebKitAPI_apk depend directly on base_java.
4119
4120 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
4121
4122         [chromium] remove obsolete user gesture methods from WebFrame
4123         https://bugs.webkit.org/show_bug.cgi?id=111696
4124
4125         Reviewed by Adam Barth.
4126
4127         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
4128         (WebTestRunner::TestPlugin::handleInputEvent):
4129         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4130
4131 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
4132
4133         Unreviewed, add myself to commiters.py.
4134
4135         * Scripts/webkitpy/common/config/committers.py:
4136
4137 2013-03-08  Julie Parent  <jparent@chromium.org>
4138
4139         Cleanup: Remove dead code.
4140         https://bugs.webkit.org/show_bug.cgi?id=111900
4141
4142         Reviewed by Dirk Pranke.
4143         
4144         Treemap overrides a global function that used to be in 
4145         dashboard_base, but was removed months ago in
4146         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
4147         no caller. 
4148
4149         * TestResultServer/static-dashboards/treemap.html:
4150
4151 2013-03-08  Harald Alvestrand  <hta@chromium.org>
4152
4153         Implemented new API for RTCStatsReport object.
4154         https://bugs.webkit.org/show_bug.cgi?id=110333
4155
4156         Reviewed by Adam Barth.
4157
4158         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
4159         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
4160
4161 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
4162
4163         [chromium] use custom freetype on linux asan builds again
4164         https://bugs.webkit.org/show_bug.cgi?id=111884
4165
4166         Reviewed by Tony Chang.
4167
4168         We no longer need the workaround after chromium r186540.
4169
4170         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4171
4172 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
4173
4174         Warning about the user not having edit rights on Bugzilla is confusing new contributors
4175         https://bugs.webkit.org/show_bug.cgi?id=111798
4176
4177         Reviewed by Dirk Pranke.
4178
4179         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
4180
4181         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4182
4183 2013-03-08  James Robinson  <jamesr@chromium.org>
4184
4185         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
4186         https://bugs.webkit.org/show_bug.cgi?id=111632
4187
4188         Reviewed by Adrienne Walker.
4189
4190         * DumpRenderTree/chromium/WebViewHost.cpp:
4191         (WebViewHost::initializeLayerTreeView):
4192         * DumpRenderTree/chromium/WebViewHost.h:
4193         (WebViewHost):
4194
4195 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
4196
4197         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
4198         https://bugs.webkit.org/show_bug.cgi?id=111297
4199
4200         Reviewed by Kenneth Rohde Christiansen.
4201
4202         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4203         (WTR::TestRunner::setViewModeMediaFeature):
4204
4205 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
4206
4207         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
4208         https://bugs.webkit.org/show_bug.cgi?id=111814
4209
4210         Reviewed by Ryosuke Niwa.
4211
4212         Add the needed supportedActions() attribute to WKTestRunner.
4213
4214         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4215         (WTR::AccessibilityUIElement::supportedActions):
4216         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4217         (AccessibilityUIElement):
4218         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4219         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4220         (WTR::AccessibilityUIElement::supportedActions):
4221
4222 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4223
4224         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
4225         https://bugs.webkit.org/show_bug.cgi?id=111851
4226
4227         Reviewed by Kenneth Rohde Christiansen.
4228
4229         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
4230         (TestWebKitAPI::TEST):
4231
4232             Fixed WKURLRef instance leaking.
4233
4234 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4235
4236         [EFL] [WK2] Some authentication tests fail in WebKit2
4237         https://bugs.webkit.org/show_bug.cgi?id=106407
4238
4239         Reviewed by Kenneth Rohde Christiansen.
4240
4241         Add patch from upstream for libsoup 2.40 to fix several authentication
4242         test cases.
4243
4244         * efl/jhbuild.modules:
4245         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
4246
4247 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
4248
4249         [GTK] Enable Web Audio in development builds
4250         https://bugs.webkit.org/show_bug.cgi?id=111831
4251
4252         Reviewed by Philippe Normand.
4253
4254         Web Audio is already quite well supported on the GTK port but still has a few issues
4255         that must be addressed before it is enabled by default. Despite that it should be enabled
4256         in development builds just so we are up-to-date with future feature infrastructure changes.
4257         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
4258         that's an obvious goal before enabling the feature in release builds.
4259
4260         * Scripts/webkitperl/FeatureList.pm:
4261
4262 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
4263
4264         [chromium] delay clearing the TestRunners until the main view was deleted
4265         https://bugs.webkit.org/show_bug.cgi?id=111823
4266
4267         Reviewed by Eric Seidel.
4268
4269         During WebViewHost::shutdown, we navigate the WebView to about:blank.
4270         This may call into the test runners which assume that the delegate is
4271         always non-NULL.
4272
4273         * DumpRenderTree/chromium/TestShell.cpp:
4274         (TestShell::~TestShell):
4275
4276 2013-03-07  Alan Cutter  <alancutter@chromium.org>
4277
4278         Sheriffbot whois command can't search by full name
4279         https://bugs.webkit.org/show_bug.cgi?id=111825
4280
4281         Reviewed by Eric Seidel.
4282
4283         Allowed multiple arguments to Sheriffbot's whois command.
4284         Updated test expectations.
4285
4286         * Scripts/webkitpy/tool/bot/irc_command.py:
4287         (Whois.execute):
4288         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
4289         (IRCCommandTest.test_whois):
4290
4291 2013-03-07  Nils Barth  <nbarth@chromium.org>
4292
4293         Add Nils Barth and Koji Hara to committers.py
4294         https://bugs.webkit.org/show_bug.cgi?id=111806
4295
4296         Reviewed by Eric Seidel.
4297
4298         * Scripts/webkitpy/common/config/committers.py: