webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2
3         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
4         https://bugs.webkit.org/show_bug.cgi?id=193771
5
6         Unreviewed infrastructure fix.
7
8         * Scripts/webkitpy/port/darwin.py:
9         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
10
11 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
12
13         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
14
15 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
16
17         Add contributors.json entries for Ling Ho and for a new bot watchers group.
18
19         * Scripts/webkitpy/common/config/contributors.json:
20
21 2019-01-25  Chris Dumez  <cdumez@apple.com>
22
23         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
24         https://bugs.webkit.org/show_bug.cgi?id=193779
25         <rdar://problem/46170903>
26
27         Reviewed by Antti Koivisto.
28
29         Add API test that quickly navigates forward to a previous process without waiting for it to
30         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
31         the process' previous page when reconnecting the it for the forward navigation.
32
33         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
34
35 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
36
37         Need a way for JavaScript (or bundle) code to participate in undo
38         https://bugs.webkit.org/show_bug.cgi?id=190009
39         <rdar://problem/44807048>
40
41         Reviewed by Ryosuke Niwa.
42
43         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
44         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
45
46         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
47         (WTR::UIScriptController::lastUndoLabel const):
48         (WTR::UIScriptController::firstRedoLabel const):
49         (WTR::UIScriptController::platformUndoManager const):
50         * DumpRenderTree/mac/UIScriptControllerMac.mm:
51         (WTR::UIScriptController::lastUndoLabel const):
52         (WTR::UIScriptController::firstRedoLabel const):
53         (WTR::UIScriptController::platformUndoManager const):
54         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
55         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
56         (WTR::UIScriptController::lastUndoLabel const):
57         (WTR::UIScriptController::firstRedoLabel const):
58         * TestRunnerShared/UIScriptContext/UIScriptController.h:
59         * WebKitTestRunner/UIScriptControllerCocoa.mm:
60         (WTR::UIScriptController::lastUndoLabel const):
61         (WTR::UIScriptController::firstRedoLabel const):
62         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
63         (WTR::UIScriptController::platformUndoManager const):
64         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
65         (WTR::UIScriptController::platformUndoManager const):
66
67 2019-01-25  Zalan Bujtas  <zalan@apple.com>
68
69         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
70         https://bugs.webkit.org/show_bug.cgi?id=193824
71
72         Reviewed by Antti Koivisto.
73
74         * LayoutReloaded/misc/LFC-passing-tests.txt:
75
76 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
77
78         Update macOS JSC bot configurations
79         https://bugs.webkit.org/show_bug.cgi?id=193739
80
81         Reviewed by Alexey Proskuryakov.
82
83         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
84         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
85         (BubbleQueueServer): Move JSC EWS to Mojave section.
86         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
87         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
88         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
89
90 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
91
92         [Win][WebKitTestRunner] Implement EventSenderProxy
93         https://bugs.webkit.org/show_bug.cgi?id=193755
94
95         Reviewed by Don Olmstead.
96
97         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
98         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
99         (WTR::EventSenderProxy::dispatchMessage):
100         (WTR::EventSenderProxy::EventSenderProxy):
101         (WTR::EventSenderProxy::mouseDown):
102         (WTR::EventSenderProxy::mouseUp):
103         (WTR::EventSenderProxy::mouseMoveTo):
104         (WTR::EventSenderProxy::mouseScrollBy):
105         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
106
107 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
108
109         Unreviewed fix for API test failure after r240437.
110
111         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
112
113         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
114
115 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
116
117         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
118         https://bugs.webkit.org/show_bug.cgi?id=193787
119         <rdar://problem/47497634>
120
121         Reviewed by Alexey Proskuryakov.
122
123         * Scripts/webkitdirs.pm:
124         (iosSimulatorApplicationsPath): Pick from available runtime directories.
125
126 2019-01-24  Truitt Savell  <tsavell@apple.com>
127
128         Unreviewed, rolling out r240446.
129
130         Casued 5 API failures
131
132         Reverted changeset:
133
134         "Activate the WebResourceLoadStatisticsStore in the
135         NetworkProcess and deactivate it in the UIProcess."
136         https://bugs.webkit.org/show_bug.cgi?id=193297
137         https://trac.webkit.org/changeset/240446
138
139 2019-01-24  Zalan Bujtas  <zalan@apple.com>
140
141         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
142         https://bugs.webkit.org/show_bug.cgi?id=193741
143         <rdar://problem/47135030>
144
145         Reviewed by Antti Koivisto and Simon Fraser.
146
147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
148         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
149         (TestWebKitAPI::TEST):
150
151 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
152
153         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
154         https://bugs.webkit.org/show_bug.cgi?id=193297
155         <rdar://problem/47158841>
156
157         Reviewed by Alex Christensen.
158
159         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
160         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
161         activating the message used to trigger the callback when it is set.
162
163 2019-01-24  John Wilander  <wilander@apple.com>
164
165         Add Ad Click Attribution as an internal/experimental feature
166         https://bugs.webkit.org/show_bug.cgi?id=193685
167         <rdar://problem/47450399>
168
169         Reviewed by Brent Fulgham.
170
171         Added test option adClickAttributionEnabled.
172
173         * DumpRenderTree/TestOptions.cpp:
174         (TestOptions::TestOptions):
175         * DumpRenderTree/TestOptions.h:
176         * DumpRenderTree/mac/DumpRenderTree.mm:
177         (setWebPreferencesForTestOptions):
178
179 2019-01-24  Antti Koivisto  <antti@apple.com>
180
181         [PSON] Flash on back navigation on Mac
182         https://bugs.webkit.org/show_bug.cgi?id=193716
183         <rdar://problem/47148458>
184
185         Reviewed by Chris Dumez.
186
187         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
188
189         Closing of the previous page is delayed so waiting for didFinishNavigation is
190         not sufficient to guarantee we have received all the messages. Wait for them.
191
192 2019-01-24  Chris Dumez  <cdumez@apple.com>
193
194         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
195         https://bugs.webkit.org/show_bug.cgi?id=193761
196         <rdar://problem/47456405>
197
198         Reviewed by Alex Christensen.
199
200         Add API test coverage.
201
202         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
203
204 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
205
206         webkitpy: Missing PID in crashlog name should not be fatal
207         https://bugs.webkit.org/show_bug.cgi?id=193771
208
209         If we can't determine the PID of a crashlog, just ignore the crashlog instead
210         of raising an exception.
211
212         Reviewed by Lucas Forschler.
213
214         * Scripts/webkitpy/port/darwin.py:
215         (DarwinPort._merge_crash_logs):
216
217 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
218
219         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
220         https://bugs.webkit.org/show_bug.cgi?id=193746
221
222         Reviewed by Youenn Fablet.
223
224         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
225         so we'd best just not call it.
226
227         * Scripts/webkitpy/w3c/test_exporter.py:
228         (WebPlatformTestExporter.create_branch_with_patch):
229
230 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
231
232         Move FileSystem to WTF
233         https://bugs.webkit.org/show_bug.cgi?id=193602
234
235         Reviewed by Yusuke Suzuki.
236
237         * DumpRenderTree/win/DumpRenderTree.cpp:
238         * TestWebKitAPI/CMakeLists.txt:
239         * TestWebKitAPI/PlatformGTK.cmake:
240         * TestWebKitAPI/PlatformJSCOnly.cmake:
241         * TestWebKitAPI/PlatformPlayStation.cmake:
242         * TestWebKitAPI/PlatformWPE.cmake:
243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
244         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
245         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
246         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
247         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
248         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
249         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
250         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
251         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
252         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
253
254 2019-01-24  Philippe Normand  <pnormand@igalia.com>
255
256         [WPE] Remove hard dependency on subprocess32 for the API tests
257
258         Rubber-stamped by Carlos Garcia Campos.
259
260         * glib/api_test_runner.py:
261         (TestRunner._run_test_qt): Lazily import subprocess32 and check
262         its presence only when running WPEQt tests.
263
264 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
265
266         [GLIB] Expose JavaScriptCore options in GLib public API
267         https://bugs.webkit.org/show_bug.cgi?id=188742
268
269         Reviewed by Michael Catanzaro.
270
271         Add a test for the new API.
272
273         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
274         (testsJSCOptions):
275         (main):
276
277 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
278
279         [GTK][WPE] Support JPEG 2000 images
280         https://bugs.webkit.org/show_bug.cgi?id=186272
281
282         Reviewed by Žan Doberšek.
283
284         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
285
286         * gtk/jhbuild.modules:
287         * wpe/jhbuild.modules:
288
289 2019-01-23  David Kilzer  <ddkilzer@apple.com>
290
291         check-webkit-style should warn when using soft-linking macros in a header
292         <https://webkit.org/b/193750>
293
294         Reviewed by Darin Adler.
295
296         * Scripts/webkitpy/style/checkers/cpp.py:
297         (check_language): Add softlink/header check by refactoring the
298         softlink/framework check.
299         (CppChecker): Enable softlink/header check by default.
300         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
301         (CppStyleTest.test_softlink_framework): Rename from
302         CppStyleTest.test_softlink() and change test framework name in
303         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
304         files. Set file_name for macros that only appear in headers.
305         (CppStyleTest.test_softlink_header): Add tests for using
306         soft-link macros in headers.
307
308 2019-01-23  Chris Dumez  <cdumez@apple.com>
309
310         Deprecate API to limit the maximum number of WebProcesses
311         https://bugs.webkit.org/show_bug.cgi?id=193725
312         <rdar://problem/47464879>
313
314         Reviewed by Geoff Garen.
315
316         Update existing API tests to stop using deprecated API.
317
318         * MiniBrowser/mac/AppDelegate.m:
319         (defaultConfiguration):
320         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
321         (TestWebKitAPI::TEST):
322         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
323         (TestWebKitAPI::TEST):
324         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
325         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
326         (TEST):
327         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
328         (TEST):
329
330 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
331
332         [ews-app] Rename ews model buildermappings to buildermapping
333         https://bugs.webkit.org/show_bug.cgi?id=193729
334
335         Reviewed by Lucas Forschler.
336
337         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
338         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
339         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
340
341 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
342
343         [ews-app] Rename ews model steps to step
344         https://bugs.webkit.org/show_bug.cgi?id=193697
345
346         Reviewed by Lucas Forschler.
347
348         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
349         (Step): Renamed Steps to Step.
350
351 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
352
353         Clean up IndexedDB files between tests
354         https://bugs.webkit.org/show_bug.cgi?id=192796
355         <rdar://problem/46824999>
356
357         Reviewed by Geoffrey Garen.
358
359         * DumpRenderTree/mac/DumpRenderTree.mm:
360         (runTest):
361         * WebKitTestRunner/TestController.cpp:
362         (WTR::TestController::resetStateToConsistentValues):
363         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
364         (WTR::RemoveAllIndexedDatabasesCallback):
365         (WTR::TestController::ClearIndexedDatabases):
366         * WebKitTestRunner/TestController.h:
367         * WebKitTestRunner/TestInvocation.cpp:
368         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
369
370 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
371
372         [ews-app] Rename ews model Builds to Build
373         https://bugs.webkit.org/show_bug.cgi?id=193695
374
375         Reviewed by Lucas Forschler.
376
377         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
378         (Build): Renamed Builds to Build.
379
380 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
381
382         webkitpy: Wait longer when launching WebKitTestRunner
383         https://bugs.webkit.org/show_bug.cgi?id=193734
384
385         Reviewed by Aakash Jain.
386
387         * Scripts/webkitpy/port/simulator_process.py:
388         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
389
390 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
391
392         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
393         https://bugs.webkit.org/show_bug.cgi?id=193182
394         <rdar://problem/47452154>
395
396         Reviewed by Tim Horton.
397
398         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
399         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
400         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
401
402         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
403         preventing later tests from recognizing gestures.
404
405         * WebKitTestRunner/ios/TestControllerIOS.mm:
406         (WTR::TestController::platformResetStateToConsistentValues):
407
408         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
409
410 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
411
412         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
413         https://bugs.webkit.org/show_bug.cgi?id=193722
414         <rdar://problem/47481475>
415
416         Reviewed by Lucas Forschler.
417
418         iPhone and iPad ports should both use the iOS config.
419
420         * Scripts/webkitpy/port/ios_simulator.py:
421         (IPhoneSimulatorPort.__init__):
422         (IPadSimulatorPort.__init__):
423
424 2019-01-23  Rob Buis  <rbuis@igalia.com>
425
426         Update MIME type parser
427         https://bugs.webkit.org/show_bug.cgi?id=180526
428
429         Reviewed by Frédéric Wang.
430
431         Add unit tests for both parse modes of ParsedContentType.
432
433         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
434         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
435         (TestWebKitAPI::TEST):
436
437 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
438
439         [ews-app] fetch loop should not stop on network issues
440         https://bugs.webkit.org/show_bug.cgi?id=193666
441
442         Reviewed by Lucas Forschler.
443
444         * BuildSlaveSupport/ews-app/ews/fetcher.py:
445         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
446
447 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
448
449         [iOS] Multiple WKWebViewAutofillTests are flaky failures
450         https://bugs.webkit.org/show_bug.cgi?id=189165
451         <rdar://problem/47433765>
452
453         Reviewed by Tim Horton.
454
455         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
456         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
457         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
458         process in sufficient to ensure that any previous action that blurred the focused element in the web process
459         would make its way to the UI process by the time the layer tree commit is finished.
460
461         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
462         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
463         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
464         will fail because it asks for -_autofillContext too early.
465
466         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
467         is handled in the UI process.
468
469         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
470
471         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
472         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
473         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
474         input session.
475
476         (-[AutofillTestView textInputHasAutofillContext]):
477
478         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
479
480         * TestWebKitAPI/cocoa/TestWKWebView.h:
481         * TestWebKitAPI/cocoa/TestWKWebView.mm:
482         (nextInputSessionChangeCount):
483
484         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
485         This includes changing the focused element from one to another.
486
487         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
488         (-[TestWKWebView didStartFormControlInteraction]):
489         (-[TestWKWebView didEndFormControlInteraction]):
490         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
491
492         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
493         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
494         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
495         that doesn't require an input session to one that doesn't.
496
497 2019-01-22  David Kilzer  <ddkilzer@apple.com>
498
499         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
500         <https://webkit.org/b/193676>
501
502         Reviewed by Alexey Proskuryakov.
503
504         * Scripts/webkitpy/style/checkers/cpp.py:
505         (check_member_initialization_list):
506         - Don't report missing whitespace around colon if the colon at
507           the start of the line is formatted correctly.
508         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
509         (WebKitStyleTest.test_member_initialization_list):
510         - Add a test for a missing permutation of existing tests.
511         - Add a test this false-positive.
512         - Add blank lines between subtests to make them easier to read.
513
514 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
515
516         [build.webkit.org] Unit-test failure after r237113
517         https://bugs.webkit.org/show_bug.cgi?id=193669
518
519         Reviewed by Michael Catanzaro.
520
521         * BuildSlaveSupport/build.webkit.org-config/factories.py:
522         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
523         multiple or zero flags.
524
525 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
526
527         Cache bytecode to disk
528         https://bugs.webkit.org/show_bug.cgi?id=192782
529         <rdar://problem/46084932>
530
531         Reviewed by Keith Miller.
532
533         Add test helper to execute bytecode-cache tests: it executes each test
534         twice, the first with JSC_diskCachePath set to a temporary directory
535         and second with JSC_forceDiskCache=true (in addition to the cache path)
536         to guarantee that only the disk cache is being used and no new
537         UnlinkedCodeBlocks are being created.
538
539         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
540         * Scripts/run-jsc-stress-tests:
541
542 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
543
544         [css-logical] Implement flow-relative margin, padding and border shorthands
545         https://bugs.webkit.org/show_bug.cgi?id=188697
546
547         Reviewed by Simon Fraser and Antti Koivisto.
548
549         * DumpRenderTree/TestOptions.cpp:
550         (TestOptions::TestOptions):
551         * DumpRenderTree/TestOptions.h:
552         * DumpRenderTree/mac/DumpRenderTree.mm:
553         (setWebPreferencesForTestOptions):
554         Allow tests to enable the CSSLogicalEnabled flag in WK1.
555
556         * Scripts/webkitpy/style/checkers/jsonchecker.py:
557         (JSONCSSPropertiesChecker.check_codegen_properties):
558         Allow CSS property definitions to have a 'runtime-flag' parameter which
559         disables the property when the specified runtime flag is disabled.
560
561 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
562
563         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
564         https://bugs.webkit.org/show_bug.cgi?id=193643
565
566         Reviewed by Michael Catanzaro.
567
568         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
569         * wpe/jhbuild.modules: Ditto.
570
571 2019-01-21  Zalan Bujtas  <zalan@apple.com>
572
573         [LFC][Floats] Take float top position into account when computing containing block height.
574         https://bugs.webkit.org/show_bug.cgi?id=193655
575
576         Reviewed by Antti Koivisto.
577
578         * LayoutReloaded/misc/LFC-passing-tests.txt:
579
580 2019-01-21  David Kilzer  <ddkilzer@apple.com>
581
582         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
583         <https://webkit.org/b/193645>
584         <rdar://problem/47421574>
585
586         Reviewed by Alex Christensen.
587
588         - Now checks for local soft-linking of all frameworks that have
589           their own *SoftLinking.{cpp,h,mm} files.
590         - Changes softlink/uikit warning to softlink/framework.
591
592         * Scripts/webkitpy/style/checkers/cpp.py:
593         (check_language):
594         (CppChecker):
595         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
596         (CppStyleTest):
597
598 2019-01-20  Saam Barati  <sbarati@apple.com>
599
600         Rollout r240210: It broke tests on iOS
601         https://bugs.webkit.org/show_bug.cgi?id=193640
602
603         Unreviewed.
604
605         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
606         * Scripts/run-jsc-stress-tests:
607
608 2019-01-20  chris fleizach  <cfleizach@apple.com>
609
610         AX: Support returning relative frames for accessibility
611         https://bugs.webkit.org/show_bug.cgi?id=193414
612         <rdar://problem/47268501>
613
614         Reviewed by Zalan Bujtas.
615
616         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
617         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
618         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
619         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
620         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
621         (WTR::attributesOfElement):
622         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
623
624 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
625
626         Unreviewed, add my new email address
627
628         * Scripts/webkitpy/common/config/contributors.json:
629
630 2019-01-19  Zalan Bujtas  <zalan@apple.com>
631
632         [LFC][BFC] <body>'s overflow property value is propagated to viewport
633         https://bugs.webkit.org/show_bug.cgi?id=193617
634
635         Reviewed by Antti Koivisto.
636
637         * LayoutReloaded/misc/LFC-passing-tests.txt:
638
639 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
640
641         Unreviewed, rolling out r240209.
642
643         Broke GTK/WPE injected bundle
644
645         Reverted changeset:
646
647         "AX: Support returning relative frames for accessibility"
648         https://bugs.webkit.org/show_bug.cgi?id=193414
649         https://trac.webkit.org/changeset/240209
650
651 2019-01-12  Dan Bernstein  <mitz@apple.com>
652
653         [Cocoa] Avoid importing directly from subumbrella frameworks
654         https://bugs.webkit.org/show_bug.cgi?id=186016
655         <rdar://problem/40591038>
656
657         Reviewed by Sam Weinig.
658
659         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
660           LaunchServices header.
661         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
662           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
663         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
664           when using SDKs earlier than 10.13.
665         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
666           and OTHER_CPLUSPLUSFLAGS.
667         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
668           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
669         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
670           LaunchServices header.
671
672 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
673
674         Cache bytecode to disk
675         https://bugs.webkit.org/show_bug.cgi?id=192782
676         <rdar://problem/46084932>
677
678         Reviewed by Keith Miller.
679
680         Add test helper to execute bytecode-cache tests: it executes each test
681         twice, the first with JSC_diskCachePath set to a temporary directory
682         and second with JSC_forceDiskCache=true (in addition to the cache path)
683         to guarantee that only the disk cache is being used and no new
684         UnlinkedCodeBlocks are being created.
685
686         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
687         * Scripts/run-jsc-stress-tests:
688
689 2019-01-20  chris fleizach  <cfleizach@apple.com>
690
691         AX: Support returning relative frames for accessibility
692         https://bugs.webkit.org/show_bug.cgi?id=193414
693         <rdar://problem/47268501>
694
695         Reviewed by Zalan Bujtas.
696
697         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
698         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
699         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
700         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
701         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
702         (WTR::attributesOfElement):
703         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
704
705 2019-01-20  Antoine Quint  <graouts@apple.com>
706
707         Add a POINTER_EVENTS feature flag
708         https://bugs.webkit.org/show_bug.cgi?id=193577
709         <rdar://problem/47408511>
710
711         Unreviewed. Also enable Pointer Events for iosmac.
712
713         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
714
715 2019-01-19  Zalan Bujtas  <zalan@apple.com>
716
717         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
718         https://bugs.webkit.org/show_bug.cgi?id=193613
719
720         Reviewed by Antti Koivisto.
721
722         * LayoutReloaded/misc/LFC-passing-tests.txt:
723
724 2019-01-19  Antoine Quint  <graouts@apple.com>
725
726         Add a POINTER_EVENTS feature flag
727         https://bugs.webkit.org/show_bug.cgi?id=193577
728
729         Reviewed by Dean Jackson.
730
731         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
732
733 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
734
735         Disable the run-jsc-stress-test remote host key check [second round].
736         https://bugs.webkit.org/show_bug.cgi?id=192988
737
738         Reviewed by Dewei Zhu.
739
740         * Scripts/run-jsc-stress-tests:
741
742 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
743
744         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
745         https://bugs.webkit.org/show_bug.cgi?id=193597
746
747         Reviewed by Lucas Forschler.
748
749         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
750
751 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
752
753         [build.webkit.org] api tests failures are incorrectly named as unit test failures
754         https://bugs.webkit.org/show_bug.cgi?id=193595
755
756         Reviewed by Lucas Forschler.
757
758         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
759         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
760         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
761
762 2019-01-18  Chris Dumez  <cdumez@apple.com>
763
764         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
765         https://bugs.webkit.org/show_bug.cgi?id=193588
766         <rdar://problem/47131566>
767
768         Reviewed by Alex Christensen.
769
770         Add layout test coverage.
771
772         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
773
774 2019-01-18  Jer Noble  <jer.noble@apple.com>
775
776         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
777         https://bugs.webkit.org/show_bug.cgi?id=189553
778
779         Reviewed by Tim Horton.
780
781         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
782
783         * ContentExtensionTester/Configurations/Base.xcconfig:
784         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
785         * DumpRenderTree/mac/Configurations/Base.xcconfig:
786         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
787         * ImageDiff/cg/Configurations/Base.xcconfig:
788         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
789         * MiniBrowser/Configurations/Base.xcconfig:
790         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
791         * MobileMiniBrowser/Configurations/Base.xcconfig:
792         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
793         * Scripts/webkitpy/style/checker.py:
794         (_all_categories):
795         (FileType):
796         (CheckerDispatcher._file_type):
797         (CheckerDispatcher._create_checker):
798         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
799         (SDKVariantChecker):
800         (SDKVariantChecker.__init__):
801         (SDKVariantChecker.check):
802         * TestWebKitAPI/Configurations/Base.xcconfig:
803         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
804         * WebEditingTester/Configurations/Base.xcconfig:
805         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
806         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
807         * WebKitTestRunner/Configurations/Base.xcconfig:
808         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
809         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
810         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
811
812 2019-01-18  David Kilzer  <ddkilzer@apple.com>
813
814         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
815         <https://webkit.org/b/193568>
816         <rdar://problem/47381130>
817
818         Reviewed by Alex Christensen.
819
820         Make sure no one re-introduces UIKit soft-linking by adding a
821         style rule.
822
823         * Scripts/webkitpy/style/checkers/cpp.py:
824         (check_language): Add softlink/uikit check.
825         (CppChecker): Enable softlink/uikit check.
826         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
827         (CppStyleTest): Add test for softlink/uikit.
828
829 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
830
831         [GTK] install-dependencies tool looks for libunistring-dev for dnf
832         https://bugs.webkit.org/show_bug.cgi?id=193584
833
834         Change "-dev" to "-devel".
835
836         Reviewed by Michael Catanzaro.
837
838         * gtk/install-dependencies:
839
840 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
841
842         webkitpy: Add iPhone and iPad ports
843         https://bugs.webkit.org/show_bug.cgi?id=193537
844         <rdar://problem/47353390>
845
846         Reviewed by Lucas Forschler.
847
848         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
849         ports. Note that this separation is optional, the --ios-simulator command remains.
850
851         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
852         (RunTest.test_device_type_test_division): Drive-by fix.
853         (RunTest.test_device_type_specific_listing): Ditto.
854         (RunTest.test_ipad_test_division):
855         (RunTest):
856         (RunTest.test_ipad_listing):
857         * Scripts/webkitpy/port/factory.py:
858         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
859         (PortFactory):
860         * Scripts/webkitpy/port/ios_simulator.py:
861         (IPhoneSimulatorPort):
862         (IPadSimulatorPort):
863
864 2019-01-18  Chris Dumez  <cdumez@apple.com>
865
866         Regression(PSON) Scroll position is not always restored properly when navigating back
867         https://bugs.webkit.org/show_bug.cgi?id=193578
868         <rdar://problem/47386331>
869
870         Reviewed by Tim Horton.
871
872         Add API test coverage.
873
874         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
875
876 2019-01-18  Youenn Fablet  <youenn@apple.com>
877
878         Add a new SPI to request for cache storage quota increase
879         https://bugs.webkit.org/show_bug.cgi?id=193323
880
881         Reviewed by Alex Christensen.
882
883         Implement WebsiteDataStore quota delegate to handle quota requests.
884         By default, do not update quota.
885         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
886
887         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
888         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
889         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
890         * WebKitTestRunner/InjectedBundle/TestRunner.h:
891         * WebKitTestRunner/TestController.cpp:
892         (WTR::TestController::allowCacheStorageQuotaIncrease):
893         * WebKitTestRunner/TestController.h:
894         * WebKitTestRunner/TestInvocation.cpp:
895         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
896         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
897         (-[CacheStorageQuotaManager init]):
898         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
899         (WTR::initializeWebViewConfiguration):
900         (WTR::TestController::cocoaResetStateToConsistentValues):
901         (WTR::TestController::allowCacheStorageQuotaIncrease):
902
903 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
904
905         [ews-build] Pass owner to the triggered builds
906         https://bugs.webkit.org/show_bug.cgi?id=193574
907
908         Reviewed by Lucas Forschler.
909
910         * BuildSlaveSupport/ews-build/factories.py:
911         (BuildFactory.propertiesToPassToTriggers):
912
913 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
914
915         [ews-app] Send patch author as a build property
916         https://bugs.webkit.org/show_bug.cgi?id=193560
917
918         Reviewed by Lucas Forschler.
919
920         * BuildSlaveSupport/ews-app/ews/fetcher.py:
921         (BugzillaPatchFetcher.fetch):
922
923 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
924
925         webkitpy: Implement device type specific expected results (Follow-up fix)
926         https://bugs.webkit.org/show_bug.cgi?id=192162
927         <rdar://problem/46345449>
928
929         Unreviewed infrastructure fix.
930
931         * Scripts/webkitpy/layout_tests/controllers/manager.py:
932         (Manager.run): Don't boot a device if no tests are available to run on it.
933
934 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
935
936         webkitpy: Implement device type specific expected results (Follow-up fix)
937         https://bugs.webkit.org/show_bug.cgi?id=192162
938         <rdar://problem/46345449>
939
940         Unreviewed infrastructure fix.
941
942         * Scripts/webkitpy/api_tests/manager.py:
943         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
944
945 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
946
947         webkitpy: Implement device type specific expected results (Part 2)
948         https://bugs.webkit.org/show_bug.cgi?id=192162
949         <rdar://problem/46345449>
950
951         Rubber-stamped by Aakash Jain.
952
953         This change uses device_type to select a different set of TestExpectation files based on the type of device running
954         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
955         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
956
957         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
958         (LayoutTestFinder.find_tests): Pass device_type through.
959         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
960         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
961         * Scripts/webkitpy/layout_tests/controllers/manager.py:
962         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
963         (Manager._collect_tests): Pass device type to test finder.
964         (Manager._needs_web_platform_test):
965         (Manager._prepare_lists): Index _expectations by device type.
966         (Manager._test_input_for_file):
967         (Manager._test_is_slow): Ditto.
968         (Manager._test_should_dump_jsconsolelog_in_stderr):
969         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
970         (Manager._get_test_inputs):
971         (Manager._update_worker_count):
972         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
973         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
974         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
975         the one which runs the test.
976         (Manager._run_test_subset):
977         (Manager._run_tests): Index _expectations by current_device_type.
978         (Manager._print_expectation_line_for_test): Ditto.
979         (Manager._print_expectations_for_subset): Ditto.
980         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
981         Unlike run, this function will behave the same regardless of what devices are available.
982         (Manager._custom_device_for_test): Deleted.
983         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
984         (ManagerTest.test_uses_custom_device): Deleted.
985         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
986         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
987         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
988         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
989         all of the expectations.
990         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
991         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
992         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
993         (TestExpectations.__init__): Allow device_type to be passed through.
994         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
995         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
996         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
997         (summarize_results):
998         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
999         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
1000         a test ran with, one must check all expectations to find the first non-skip expectation.
1001         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1002         (RunTest.test_device_type_test_division):
1003         (RunTest):
1004         (RunTest.test_device_type_specific_listing):
1005         * Scripts/webkitpy/port/base.py:
1006         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
1007         (Port.supported_device_types): The result of this function will change based on what devices are available.
1008         * Scripts/webkitpy/port/device_port.py:
1009         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1010         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1011         can be used.
1012         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1013         any, or the DEFAULT_DEVICE_TYPES of the port.
1014         * Scripts/webkitpy/port/ios.py:
1015         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1016         * Scripts/webkitpy/port/ios_simulator.py:
1017         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1018         * Scripts/webkitpy/port/watch.py:
1019         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1020         * Scripts/webkitpy/port/watch_simulator.py:
1021         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1022         * Scripts/webkitpy/xcode/device_type.py:
1023         (DeviceType):
1024         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1025
1026 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1027
1028         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1029         https://bugs.webkit.org/show_bug.cgi?id=193575
1030
1031         Reviewed by Michael Catanzaro.
1032
1033         Allow the script to run without explicit port argument because
1034         it's specific to the WPE port anyway.
1035
1036         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1037         and simplify the rest of the code accordingly.
1038
1039 2019-01-18  Charlie Turner  <cturner@igalia.com>
1040
1041         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1042         https://bugs.webkit.org/show_bug.cgi?id=192229
1043
1044         Reviewed by Xabier Rodriguez-Calvar.
1045
1046         * MiniBrowser/wpe/main.cpp:
1047         (main): Enable encrypted-media by default.
1048
1049 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1050
1051         [Flatpak] Missing KeyboardInterrupt exception handler
1052         https://bugs.webkit.org/show_bug.cgi?id=193570
1053
1054         Reviewed by Michael Catanzaro.
1055
1056         * flatpak/flatpakutils.py:
1057         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1058
1059 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1060
1061         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1062         https://bugs.webkit.org/show_bug.cgi?id=193564
1063
1064         Reviewed by Antti Koivisto.
1065
1066         * LayoutReloaded/misc/LFC-passing-tests.txt:
1067
1068 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1069
1070         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1071         https://bugs.webkit.org/show_bug.cgi?id=193562
1072
1073         Reviewed by Antti Koivisto.
1074
1075         * LayoutReloaded/misc/LFC-passing-tests.txt:
1076
1077 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1078
1079         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1080         https://bugs.webkit.org/show_bug.cgi?id=193555
1081
1082         Reviewed by Antti Koivisto.
1083
1084         * LayoutReloaded/misc/LFC-passing-tests.txt:
1085
1086 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1087
1088         [WPE] Add Qt extension
1089         https://bugs.webkit.org/show_bug.cgi?id=191464
1090
1091         Reviewed by Carlos Garcia Campos.
1092
1093         MiniBrowser and API tests for the WPE Qt API. To run the
1094         MiniBrowser a new script is introduced. Example invocation:
1095
1096         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1097
1098         Also note-worthy is the introduction of the python2-subprocess32
1099         dependency to run the GLib API tests.
1100
1101         * MiniBrowser/wpe/CMakeLists.txt:
1102         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1103         * MiniBrowser/wpe/qt/main.cpp: Added.
1104         (main):
1105         * MiniBrowser/wpe/qt/main.qml: Added.
1106         * MiniBrowser/wpe/qt/qml.qrc: Added.
1107         * Scripts/run-gtk-tests:
1108         (GtkTestRunner.is_google_test):
1109         (GtkTestRunner):
1110         (GtkTestRunner.is_qt_test):
1111         * Scripts/run-qt-wpe-minibrowser: Added.
1112         * Scripts/run-wpe-tests:
1113         (WPETestRunner):
1114         (WPETestRunner.is_google_test):
1115         (WPETestRunner.is_qt_test):
1116         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1117         (TestLoad::main):
1118         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1119         (TestLoadHtml::main):
1120         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1121         (TestLoadRequest::main):
1122         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1123         (TestRunJavaScript::main):
1124         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1125         (waitForSignal):
1126         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1127         (LoadSpy::LoadSpy):
1128         (LoadSpy::~LoadSpy):
1129         (LoadSpy::onLoadingChanged):
1130         (LoadStartedCatcher::LoadStartedCatcher):
1131         (LoadStartedCatcher::~LoadStartedCatcher):
1132         (LoadStartedCatcher::onLoadingChanged):
1133         (waitForLoadSucceeded):
1134         (waitForLoadFailed):
1135         * TestWebKitAPI/glib/CMakeLists.txt:
1136         * flatpak/flatpakutils.py:
1137         (WebkitFlatpak.load_from_args):
1138         (WebkitFlatpak.__init__):
1139         (WebkitFlatpak.clean_args):
1140         (WebkitFlatpak.run_in_sandbox):
1141         * flatpak/org.webkit.CommonModules.yaml:
1142         * flatpak/org.webkit.WPE.yaml:
1143         * flatpak/org.webkit.WPEModules.yaml:
1144         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1145         * flatpak/org.webkit.WebKit.yaml:
1146         * glib/api_test_runner.py:
1147         (TestRunner._run_test_qt):
1148         (TestRunner.is_qt_test):
1149         (TestRunner._run_test):
1150
1151 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1152
1153         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1154         https://bugs.webkit.org/show_bug.cgi?id=193494
1155         <rdar://problem/46859627>
1156
1157         Reviewed by Simon Fraser and Tim Horton.
1158
1159         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1160         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1161
1162         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1163         (WTR::UIScriptController::contentOffsetX const):
1164         (WTR::UIScriptController::contentOffsetY const):
1165         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1166         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1167         (WTR::UIScriptController::contentOffsetX const):
1168         (WTR::UIScriptController::contentOffsetY const):
1169         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1170
1171         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1172
1173         * WebKitTestRunner/TestController.cpp:
1174         (WTR::updateTestOptionsFromTestHeader):
1175         * WebKitTestRunner/TestOptions.h:
1176         (WTR::TestOptions::hasSameInitializationOptions const):
1177         * WebKitTestRunner/ios/TestControllerIOS.mm:
1178         (WTR::TestController::platformResetStateToConsistentValues):
1179         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1180         (WTR::UIScriptController::contentOffsetX const):
1181         (WTR::UIScriptController::contentOffsetY const):
1182
1183 2019-01-17  Truitt Savell  <tsavell@apple.com>
1184
1185         Unreviewed, rolling out r240124.
1186
1187         This commit broke an internal build.
1188
1189         Reverted changeset:
1190
1191         "SDK_VARIANT build destinations should be separate from non-
1192         SDK_VARIANT builds"
1193         https://bugs.webkit.org/show_bug.cgi?id=189553
1194         https://trac.webkit.org/changeset/240124
1195
1196 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1197
1198         Fix string concatenation API test after r239920
1199         https://bugs.webkit.org/show_bug.cgi?id=193551
1200         <rdar://problem/47359304>
1201
1202         Reviewed by Youenn Fablet.
1203
1204         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1205         (TestWebKitAPI::TEST):
1206         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1207         in WebKit's build configuration like it apparently is on Linux.
1208
1209 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1210
1211         [ews-build] validate-patch should handle the case when bug_id is None
1212         https://bugs.webkit.org/show_bug.cgi?id=193547
1213
1214         Reviewed by Lucas Forschler.
1215
1216         * BuildSlaveSupport/ews-build/steps.py:
1217         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1218         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1219
1220 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1221
1222         [ews-build] Add patch author information in build
1223         https://bugs.webkit.org/show_bug.cgi?id=193465
1224
1225         Reviewed by Lucas Forschler.
1226
1227         * BuildSlaveSupport/ews-build/steps.py:
1228         (ValidatePatch._is_patch_obsolete):
1229
1230 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1231
1232         [ews-build] Pass bug_id to the triggered builds
1233         https://bugs.webkit.org/show_bug.cgi?id=193548
1234
1235         Reviewed by Lucas Forschler.
1236
1237         * BuildSlaveSupport/ews-build/factories.py:
1238         (BuildFactory.propertiesToPassToTriggers):
1239
1240 2019-01-17  Jer Noble  <jer.noble@apple.com>
1241
1242         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1243         https://bugs.webkit.org/show_bug.cgi?id=189553
1244
1245         Reviewed by Tim Horton.
1246
1247         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1248
1249         * ContentExtensionTester/Configurations/Base.xcconfig:
1250         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1251         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1252         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1253         * ImageDiff/cg/Configurations/Base.xcconfig:
1254         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1255         * MiniBrowser/Configurations/Base.xcconfig:
1256         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1257         * MobileMiniBrowser/Configurations/Base.xcconfig:
1258         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1259         * Scripts/webkitpy/style/checker.py:
1260         (_all_categories):
1261         (FileType):
1262         (CheckerDispatcher._file_type):
1263         (CheckerDispatcher._create_checker):
1264         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1265         (SDKVariantChecker):
1266         (SDKVariantChecker.__init__):
1267         (SDKVariantChecker.check):
1268         * TestWebKitAPI/Configurations/Base.xcconfig:
1269         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1270         * WebEditingTester/Configurations/Base.xcconfig:
1271         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1272         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1273         * WebKitTestRunner/Configurations/Base.xcconfig:
1274         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1275         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1276         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1277
1278 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1279
1280         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1281         https://bugs.webkit.org/show_bug.cgi?id=193534
1282
1283         Reviewed by Antti Koivisto.
1284
1285         * LayoutReloaded/misc/LFC-passing-tests.txt:
1286
1287 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1288
1289         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1290         https://bugs.webkit.org/show_bug.cgi?id=193528
1291
1292         Reviewed by Antti Koivisto.
1293
1294         * LayoutReloaded/misc/LFC-passing-tests.txt:
1295
1296 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1297
1298         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1299         https://bugs.webkit.org/show_bug.cgi?id=193520
1300
1301         Reviewed by Antti Koivisto.
1302
1303         * LayoutReloaded/misc/LFC-passing-tests.txt:
1304
1305 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1306
1307         [ews-build] unapply-patch step should not update source
1308         https://bugs.webkit.org/show_bug.cgi?id=193234
1309
1310         Reviewed by Lucas Forschler.
1311
1312         * BuildSlaveSupport/ews-build/steps.py:
1313         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1314         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1315
1316 2019-01-16  Youenn Fablet  <youenn@apple.com>
1317
1318         Add a new SPI for controlling getUserMedia
1319         https://bugs.webkit.org/show_bug.cgi?id=192793
1320
1321         Reviewed by Eric Carlson.
1322
1323         * MiniBrowser/mac/WK2BrowserWindowController.m:
1324         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1325         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1326         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1327         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1328         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1329         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1330         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1331         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1332         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1333         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1334         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1335         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1336         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1337         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1338
1339 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1340
1341         [LFC][BFC] Inflow non-replaced used width should not be negative.
1342         https://bugs.webkit.org/show_bug.cgi?id=193495
1343
1344         Reviewed by Antti Koivisto.
1345
1346         * LayoutReloaded/misc/LFC-passing-tests.txt:
1347
1348 2019-01-16  Chris Dumez  <cdumez@apple.com>
1349
1350         Regression(PSON) View becomes blank after click a cross-site download link
1351         https://bugs.webkit.org/show_bug.cgi?id=193361
1352         <rdar://problem/47099573>
1353
1354         Reviewed by Geoffrey Garen.
1355
1356         Add API test coverage.
1357
1358         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1359         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1360
1361 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1362
1363         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1364         https://bugs.webkit.org/show_bug.cgi?id=193470
1365
1366         Reviewed by Antti Koivisto.
1367
1368         * LayoutReloaded/misc/LFC-passing-tests.txt:
1369
1370 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1371
1372         [LFC] Adjust margin box verification.
1373         https://bugs.webkit.org/show_bug.cgi?id=193482
1374
1375         Reviewed by Antti Koivisto.
1376
1377         * LayoutReloaded/misc/LFC-passing-tests.txt:
1378
1379 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1380
1381         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1382         https://bugs.webkit.org/show_bug.cgi?id=193451
1383
1384         Reviewed by Geoffrey Garen.
1385
1386         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1387         (TEST):
1388         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1389         (runWebsiteDataStoreCustomPaths):
1390
1391 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1392
1393         webkitpy: Support boolean simctl isAvailable
1394         https://bugs.webkit.org/show_bug.cgi?id=193472
1395         <rdar://problem/47296150>
1396
1397         Reviewed by Ryosuke Niwa.
1398
1399         * Scripts/webkitpy/xcode/simulated_device.py:
1400         (SimulatedDeviceManager._create_runtimes):
1401         (SimulatedDeviceManager._create_device_with_runtime):
1402
1403 2019-01-15  Chris Dumez  <cdumez@apple.com>
1404
1405         Unreviewed, rolling out r239993, r239995, r239997, and
1406         r239999.
1407
1408         Caused assertions under
1409         ViewGestureController::disconnectFromProcess()
1410
1411         Reverted changesets:
1412
1413         "Regression(PSON) View becomes blank after click a cross-site
1414         download link"
1415         https://bugs.webkit.org/show_bug.cgi?id=193361
1416         https://trac.webkit.org/changeset/239993
1417
1418         "Unreviewed iOS build fix after r239993."
1419         https://trac.webkit.org/changeset/239995
1420
1421         "Fix iOS build after r239993"
1422         https://bugs.webkit.org/show_bug.cgi?id=193361
1423         https://trac.webkit.org/changeset/239997
1424
1425         "Unreviewed, revert part of r239997 as it is not needed to fix
1426         the build."
1427         https://trac.webkit.org/changeset/239999
1428
1429 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1430
1431         Cannot tab out of WKWebView on macOS
1432         https://bugs.webkit.org/show_bug.cgi?id=161448
1433         <rdar://problem/28100085>
1434
1435         Reviewed by Dean Jackson.
1436
1437         Add a test that tabbing into and out of WKWebView works correctly.
1438
1439         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1440         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1441         (WebKit2_CommandBackForwardTest::SetUp):
1442         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1443         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1444         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1445         (-[FocusableView canBecomeKeyView]):
1446         (TEST):
1447         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1448         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1449         (-[OffscreenWindow initWithSize:]):
1450         (-[OffscreenWindow isKeyWindow]):
1451         (-[OffscreenWindow isVisible]):
1452         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1453         (TestWebKitAPI::PlatformWebView::initialize):
1454         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1455         (-[ActiveOffscreenWindow isVisible]): Deleted.
1456         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1457
1458 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1459
1460         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1461         https://bugs.webkit.org/show_bug.cgi?id=193459
1462
1463         Reviewed by Mark Lam.
1464
1465         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1466         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1467
1468 2019-01-15  Chris Dumez  <cdumez@apple.com>
1469
1470         Regression(PSON) View becomes blank after click a cross-site download link
1471         https://bugs.webkit.org/show_bug.cgi?id=193361
1472         <rdar://problem/47099573>
1473
1474         Reviewed by Geoff Garen.
1475
1476         Add API test coverage.
1477
1478         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1479         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1480
1481 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1482
1483         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
1484         https://bugs.webkit.org/show_bug.cgi?id=193448
1485
1486         Reviewed by Antti Koivisto.
1487
1488         * LayoutReloaded/misc/LFC-passing-tests.txt:
1489
1490 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1491
1492         webkitpy: Implement device type specific expected results (Part 1)
1493         https://bugs.webkit.org/show_bug.cgi?id=192162
1494
1495         Reviewed by Lucas Forschler.
1496
1497         Device type specific expected results covers two related ideas. The first (covered by this change)
1498         is where to search for -expected.* files. The second is which tests to run based on the
1499         TestExpectations.txt file.
1500
1501         After this change, the baseline search path will be determined by the type of device running a
1502         test. Device type will be passed into any function which picks a file based on the baseline search
1503         path.
1504
1505         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1506         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
1507         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1508         (Manager.run): Print baseline search path for each round of devices.
1509         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1510         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
1511         (SingleTestRunner._expected_driver_output): Ditto.
1512         (SingleTestRunner._driver_input): Ditto.
1513         * Scripts/webkitpy/layout_tests/views/printing.py:
1514         (Printer.print_config): Move printing of baseline search path to a separate function.
1515         (Printer.print_baseline_search_path): Moved from Printer.print_config.
1516         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1517         (Testprinter.test_print_config):
1518         (Testprinter.test_print_baseline_search_path):
1519         * Scripts/webkitpy/port/base.py:
1520         (Port.baseline_search_path): Pass device_type through.
1521         (Port._expected_baselines_for_suffixes): Ditto.
1522         (Port.expected_baselines): Ditto.
1523         (Port.expected_filename): Ditto.
1524         (Port.expected_checksum): Ditto.
1525         (Port.expected_image): Ditto.
1526         (Port.expected_audio): Ditto.
1527         (Port.expected_text): Ditto.
1528         (Port.reference_files): Ditto.
1529         (Port.tests): Ditto.
1530         (Port._expanded_paths): Ditto.
1531         (Port.skipped_layout_tests): Ditto.
1532         (Port.expectations_dict): Ditto.
1533         (Port._port_specific_expectations_files): Ditto.
1534         (Port.expectations_files): Ditto.
1535         (Port.test_search_path): Ditto.
1536         (Port._tests_for_other_platforms): Ditto.
1537         * Scripts/webkitpy/port/base_unittest.py:
1538         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
1539         (PortTest.test_nonexistant_expectations): Ditto.
1540         (test_ref_tests_platform_directory): Ditto.
1541         * Scripts/webkitpy/port/darwin.py:
1542         (DarwinPort._port_specific_expectations_files): Accept device_type.
1543         * Scripts/webkitpy/port/driver.py:
1544         (DriverProxy):
1545         (DriverProxy.host): Expose _target_host for device_type information.
1546         * Scripts/webkitpy/port/gtk.py:
1547         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
1548         * Scripts/webkitpy/port/ios.py:
1549         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1550         * Scripts/webkitpy/port/mac.py:
1551         (MacPort. default_baseline_search_path): Ditto.
1552         * Scripts/webkitpy/port/port_testcase.py:
1553         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
1554         * Scripts/webkitpy/port/test.py:
1555         * Scripts/webkitpy/port/watch.py:
1556         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1557         * Scripts/webkitpy/port/win.py:
1558         (WinPort.test_search_path): Accept, but do not use, device_type.
1559         * Scripts/webkitpy/port/wpe.py:
1560         (WPEPort._port_specific_expectations_files): Ditto.
1561         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1562         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
1563
1564 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1565
1566         [LFC] Use the containing block's padding box to position out-of-flow elements.
1567         https://bugs.webkit.org/show_bug.cgi?id=193431
1568
1569         Reviewed by Antti Koivisto.
1570
1571         * LayoutReloaded/misc/LFC-passing-tests.txt:
1572
1573 2019-01-14  Tim Horton  <timothy_horton@apple.com>
1574
1575         Move a test implementation file that got misplaced in the Xcode project
1576
1577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1578
1579 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1580
1581         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1582         r239913, and r239914.
1583         https://bugs.webkit.org/show_bug.cgi?id=193407
1584
1585         These revisions caused an internal failure (Requested by
1586         Truitt on #webkit).
1587
1588         Reverted changesets:
1589
1590         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1591         https://bugs.webkit.org/show_bug.cgi?id=186016
1592         https://trac.webkit.org/changeset/239901
1593
1594         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1595         https://trac.webkit.org/changeset/239909
1596
1597         "Tried to fix the build."
1598         https://trac.webkit.org/changeset/239910
1599
1600         "Fixed iOS builds after r239910."
1601         https://trac.webkit.org/changeset/239912
1602
1603         "More build fixing."
1604         https://trac.webkit.org/changeset/239913
1605
1606         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1607         https://trac.webkit.org/changeset/239914
1608
1609 2019-01-14  Mark Lam  <mark.lam@apple.com>
1610
1611         Re-enable ability to build --cloop builds.
1612         https://bugs.webkit.org/show_bug.cgi?id=192955
1613         <rdar://problem/46882363>
1614
1615         Reviewed by Saam barati and Keith Miller.
1616
1617         The --cloop build option was being ignored this whole time since r236381.
1618         This patch makes it possible to build CLoop builds again.
1619
1620         * Scripts/build-jsc:
1621         * Scripts/webkitperl/FeatureList.pm:
1622         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1623
1624 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1625
1626         webkitpy: Expose device_type from host-like objects
1627         https://bugs.webkit.org/show_bug.cgi?id=193406
1628         <rdar://problem/47262305>
1629
1630         Reviewed by Lucas Forschler.
1631
1632         Devices should expose device_type. As a result, all host objects should
1633         provide a device_type property, even if they do not yet define a device_type.
1634
1635         * Scripts/webkitpy/common/system/systemhost.py:
1636         (SystemHost):
1637         (SystemHost.device_type):
1638         * Scripts/webkitpy/common/system/systemhost_mock.py:
1639         (MockSystemHost):
1640         (MockSystemHost.device_type):
1641         * Scripts/webkitpy/port/device.py:
1642         (Device):
1643         (Device.device_type):
1644         * Scripts/webkitpy/xcode/simulated_device.py:
1645         (SimulatedDeviceManager._find_exisiting_device_for_request):
1646         (SimulatedDeviceManager._disambiguate_device_type):
1647         (SimulatedDeviceManager._does_fulfill_request):
1648         (SimulatedDeviceManager.device_count_for_type):
1649         (SimulatedDeviceManager.initialize_devices):
1650         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1651         (test_available_devices):
1652         (test_swapping_devices):
1653
1654 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1655
1656         webkitpy: Support alternate simctl device list output (Follow-up fix)
1657         https://bugs.webkit.org/show_bug.cgi?id=193362
1658         <rdar://problem/47122965>
1659
1660         Rubber-stamped by Lucas Forschler.
1661
1662         * Scripts/webkitpy/xcode/simulated_device.py:
1663         (SimulatedDeviceManager.populate_available_devices):
1664
1665 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1666
1667         [iOS] Expose SPI to access the current sentence boundary and selection state
1668         https://bugs.webkit.org/show_bug.cgi?id=193398
1669         <rdar://problem/45893108>
1670
1671         Reviewed by Dean Jackson.
1672
1673         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
1674         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
1675         expected.
1676
1677         * TestWebKitAPI/EditingTestHarness.h:
1678         * TestWebKitAPI/EditingTestHarness.mm:
1679         (-[EditingTestHarness moveBackward]):
1680         (-[EditingTestHarness moveForward]):
1681         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
1682
1683         Add a couple of new helper methods on EditingTestHarness.
1684
1685         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1686         (-[SelectionChangeObserver initWithWebView:]):
1687         (-[SelectionChangeObserver webView]):
1688         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
1689         (-[SelectionChangeObserver currentSelectionAttributes]):
1690
1691 2019-01-14  Zalan Bujtas  <zalan@apple.com>
1692
1693         [LFC][BFC] Add basic box-sizing support.
1694         https://bugs.webkit.org/show_bug.cgi?id=193392
1695
1696         Reviewed by Antti Koivisto.
1697
1698         * LayoutReloaded/misc/LFC-passing-tests.txt:
1699
1700 2019-01-14  Charlie Turner  <cturner@igalia.com>
1701
1702         [WPE] API test gardening
1703         https://bugs.webkit.org/show_bug.cgi?id=193319
1704
1705         Reviewed by Michael Catanzaro.
1706
1707         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
1708         passing tests.
1709
1710 2019-01-14  Charlie Turner  <cturner@igalia.com>
1711
1712         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
1713         https://bugs.webkit.org/show_bug.cgi?id=192977
1714
1715         Reviewed by Carlos Garcia Campos.
1716
1717         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
1718         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1719         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
1720         (TestWebKitAPI::GStreamerTest::SetUp):
1721         (TestWebKitAPI::GStreamerTest::TearDown):
1722         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
1723         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
1724         (TestWebKitAPI::TEST_F):
1725
1726 2019-01-14  Charlie Turner  <cturner@igalia.com>
1727
1728         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
1729         https://bugs.webkit.org/show_bug.cgi?id=193332
1730
1731         Reviewed by Michael Catanzaro.
1732
1733         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
1734         defined as a char16_t, which changed in ICU 59, the
1735         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
1736         unsigned short. This test is relying on the behaviour that
1737         UChar=unsigned short, which doesn't hold across platforms and ICU
1738         library versions. The full fix would be a special syntax for
1739         literal characters so that these ambiguities do not arise. That
1740         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
1741         (TestWebKitAPI::TEST):
1742
1743 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1744
1745         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
1746
1747         * Scripts/make-dist:
1748         (Distcheck.configure):
1749
1750 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
1751
1752         [ews-build] Update macOS queue configurations
1753         https://bugs.webkit.org/show_bug.cgi?id=193365
1754         <rdar://problem/47221073>
1755
1756         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
1757
1758         * BuildSlaveSupport/ews-build/config.json:
1759
1760 2019-01-13  Zalan Bujtas  <zalan@apple.com>
1761
1762         [LFC] Adjust assert for statically positioned fixed elements
1763         https://bugs.webkit.org/show_bug.cgi?id=193385
1764
1765         Reviewed by Antti Koivisto.
1766
1767         * LayoutReloaded/misc/LFC-passing-tests.txt:
1768
1769 2019-01-13  Philippe Normand  <pnormand@igalia.com>
1770
1771         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
1772         https://bugs.webkit.org/show_bug.cgi?id=193387
1773
1774         Reviewed by Carlos Garcia Campos.
1775
1776         * MiniBrowser/wpe/main.cpp:
1777         (main):
1778
1779 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1780
1781         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1782         https://bugs.webkit.org/show_bug.cgi?id=191655
1783         rdar://problem/46074680
1784
1785         Reviewed by Megan Gardner.
1786
1787         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1788         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1789
1790 2019-01-12  Dan Bernstein  <mitz@apple.com>
1791
1792         [Cocoa] Avoid importing directly from subumbrella frameworks
1793         https://bugs.webkit.org/show_bug.cgi?id=186016
1794         <rdar://problem/40591038>
1795
1796         Reviewed by Sam Weinig.
1797
1798         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1799           LaunchServices header.
1800         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1801           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1802         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1803           when using SDKs earlier than 10.13.
1804         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1805           and OTHER_CPLUSPLUSFLAGS.
1806         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1807           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1808         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1809           LaunchServices header.
1810
1811 2019-01-11  John Wilander  <wilander@apple.com>
1812
1813         Compile out Web API Statistics Collection
1814         https://bugs.webkit.org/show_bug.cgi?id=193370
1815         <rdar://problem/45388584>
1816
1817         Reviewed by Brent Fulgham.
1818
1819         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1820             Defined ENABLE_WEB_API_STATISTICS, off by default.
1821
1822 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1823
1824         [WPE] Add gtk-doc
1825         https://bugs.webkit.org/show_bug.cgi?id=178900
1826
1827         Reviewed by Michael Catanzaro.
1828
1829         Add Tools/gtkdoc to manifest.txt.in files.
1830         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
1831
1832         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
1833         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
1834
1835 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1836
1837         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
1838         https://bugs.webkit.org/show_bug.cgi?id=193364
1839         <rdar://problem/47214117>
1840
1841         Reviewed by Tim Horton.
1842
1843         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
1844         precise, whereas dragging near the middle of the textarea does.
1845
1846         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1847         (TestWebKitAPI::TEST):
1848
1849 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1850
1851         webkitpy: Support alternate simctl device list output
1852         https://bugs.webkit.org/show_bug.cgi?id=193362
1853         <rdar://problem/47122965>
1854
1855         Reviewed by Lucas Forschler.
1856
1857         * Scripts/webkitpy/xcode/simulated_device.py:
1858         (SimulatedDeviceManager.populate_available_devices):
1859
1860 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
1861
1862         [ews-build] Update macOS queue configurations
1863         https://bugs.webkit.org/show_bug.cgi?id=193365
1864
1865         Reviewed by Lucas Forschler.
1866
1867         * BuildSlaveSupport/ews-build/config.json:
1868
1869 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1870
1871         webkitpy: Incorporate device type into baseline search path
1872         https://bugs.webkit.org/show_bug.cgi?id=193356
1873         <rdar://problem/47215515>
1874
1875         Reviewed by Lucas Forschler.
1876
1877         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
1878
1879         * Scripts/webkitpy/port/base.py:
1880         (Port.default_baseline_search_path): Allow device type to be passed in.
1881         * Scripts/webkitpy/port/gtk.py:
1882         (GtkPort.default_baseline_search_path): Ignore device type.
1883         * Scripts/webkitpy/port/ios.py:
1884         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
1885         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
1886         * Scripts/webkitpy/port/ios_device_unittest.py:
1887         (IOSDeviceTest):
1888         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1889         (IOSSimulatorTest):
1890         * Scripts/webkitpy/port/mac.py:
1891         (MacPort.default_baseline_search_path): Ignore device type.
1892         * Scripts/webkitpy/port/watch.py:
1893         (WatchPort.default_baseline_search_path): Ditto.
1894         * Scripts/webkitpy/port/win.py:
1895         (WinPort.default_baseline_search_path): Ditto.
1896         (WinCairoPort.default_baseline_search_path): Ditto.
1897         * Scripts/webkitpy/port/wpe.py:
1898         (WPEPort.default_baseline_search_path): Ditto.
1899
1900 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1901
1902         webkitpy: Print abbreviated baseline search path that includes only folders that exist
1903         https://bugs.webkit.org/show_bug.cgi?id=193352
1904         <rdar://problem/47210736>
1905
1906         Reviewed by Lucas Forschler.
1907
1908         * Scripts/webkitpy/layout_tests/views/printing.py:
1909         (Printer.print_config): Print list on only baseline search paths which exist. 
1910         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1911         (Testprinter.test_print_config):
1912
1913 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
1914
1915         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
1916         https://bugs.webkit.org/show_bug.cgi?id=193340
1917
1918         Reviewed by David Kilzer.
1919
1920         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1921         (WTR::InjectedBundle::didReceiveMessageToPage):
1922         Pull the strings out into a WKRetainPtr.
1923
1924         * WebKitTestRunner/WebNotificationProvider.cpp:
1925         (WTR::WebNotificationProvider::closeWebNotification):
1926         Adopt the created value into the WKRetainPtr.
1927
1928         * WebKitTestRunner/mac/TestControllerMac.mm:
1929         (WTR::generateWhitelist):
1930         Immediately adopt a created value to avoid potential mistakes.
1931
1932 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
1933
1934         Enable DFG on ARM/Linux again
1935         https://bugs.webkit.org/show_bug.cgi?id=192496
1936
1937         Reviewed by Yusuke Suzuki.
1938
1939         After changing the bytecode format DFG was disabled on all 32-bit
1940         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1941         on ARM by default.
1942
1943         * Scripts/run-jsc-stress-tests:
1944
1945 2019-01-11  Timothy Hatcher  <timothy@apple.com>
1946
1947         Unreviewed, fix #ifdef in API test added in r239851.
1948         https://bugs.webkit.org/show_bug.cgi?id=193327
1949         rdar://problem/47093222
1950
1951         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1952
1953 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1954
1955         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
1956         https://bugs.webkit.org/show_bug.cgi?id=193109
1957         <rdar://problem/44807048>
1958
1959         Reviewed by Ryosuke Niwa.
1960
1961         Introduce and respect a test option to enable the UndoManager API.
1962
1963         * WebKitTestRunner/TestController.cpp:
1964         (WTR::updateTestOptionsFromTestHeader):
1965         * WebKitTestRunner/TestOptions.h:
1966         (WTR::TestOptions::hasSameInitializationOptions const):
1967         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1968         (WTR::TestController::platformCreateWebView):
1969
1970 2019-01-11  Zalan Bujtas  <zalan@apple.com>
1971
1972         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
1973         https://bugs.webkit.org/show_bug.cgi?id=193346
1974
1975         Reviewed by Antti Koivisto.
1976
1977         * LayoutReloaded/misc/LFC-passing-tests.txt:
1978
1979 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1980
1981         Unreviewed, fix typo that breaks dashboard link.
1982
1983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1984         (WebKitBuildbot):
1985
1986 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1987
1988         Update macOS queue configurations
1989         https://bugs.webkit.org/show_bug.cgi?id=193329
1990
1991         Reviewed by Alexey Proskuryakov.
1992
1993         * BuildSlaveSupport/build.webkit.org-config/config.json:
1994         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1995         (BubbleQueueServer):
1996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1997         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1998         (WebKitBuildbot):
1999         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2000         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
2001         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2002
2003 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2004
2005         MiniBrowser should be able to navigate to about:blank
2006         https://bugs.webkit.org/show_bug.cgi?id=193345
2007
2008         Reviewed by Simon Fraser.
2009
2010         * MiniBrowser/mac/BrowserWindowController.m:
2011         (-[BrowserWindowController addProtocolIfNecessary:]):
2012         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2013
2014         * MiniBrowser/mac/WK1BrowserWindowController.m:
2015         (-[WK1BrowserWindowController fetch:]):
2016         * MiniBrowser/mac/WK2BrowserWindowController.m:
2017         (-[WK2BrowserWindowController fetch:]):
2018         Clean up the code that uses this to match style.
2019
2020 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2021
2022         Remove MiniBrowser custom "Process Swap" menu item which does not work
2023         https://bugs.webkit.org/show_bug.cgi?id=193344
2024
2025         Reviewed by Simon Fraser.
2026
2027         There is a menu item under the Experimental menu that does work.
2028
2029         * MiniBrowser/mac/AppDelegate.m:
2030         (defaultConfiguration):
2031         * MiniBrowser/mac/SettingsController.h:
2032         * MiniBrowser/mac/SettingsController.m:
2033         (-[SettingsController _populateMenu]):
2034         (-[SettingsController validateMenuItem:]):
2035         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2036         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2037
2038 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2039
2040         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2041         https://bugs.webkit.org/show_bug.cgi?id=193327
2042         rdar://problem/47093222
2043
2044         Reviewed by Tim Horton.
2045
2046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2047         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2048         (TestWebKitAPI::didFinishNavigation):
2049         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2050         (TestWebKitAPI::TEST):
2051         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2052         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2053         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2054         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2055         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2056
2057 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2058
2059         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2060         https://bugs.webkit.org/show_bug.cgi?id=193338
2061         <rdar://problem/46664774>
2062
2063         Reviewed by David Kilzer.
2064
2065         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2066         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2067
2068 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2069
2070         Unreviewed, rolling out r239825.
2071         https://bugs.webkit.org/show_bug.cgi?id=193330
2072
2073         Broke tests on armv7/linux bots (Requested by guijemont on
2074         #webkit).
2075
2076         Reverted changeset:
2077
2078         "Enable DFG on ARM/Linux again"
2079         https://bugs.webkit.org/show_bug.cgi?id=192496
2080         https://trac.webkit.org/changeset/239825
2081
2082 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2083
2084         Disable the run-jsc-stress-test remote host key check.
2085         https://bugs.webkit.org/show_bug.cgi?id=192988
2086
2087         Reviewed by Alexey Proskuryakov.
2088
2089         * Scripts/run-jsc-stress-tests:
2090
2091 2019-01-10  John Wilander  <wilander@apple.com>
2092
2093         Override the session configuration for cookieAcceptPolicy
2094         https://bugs.webkit.org/show_bug.cgi?id=190925
2095         <rdar://problem/45497382>
2096
2097         Reviewed by Alexey Proskuryakov and Alex Christensen.
2098
2099         Test infrastructure for setting a first-party-only cookie policy.
2100
2101         * DumpRenderTree/TestRunner.cpp:
2102         (setOnlyAcceptFirstPartyCookiesCallback):
2103         (TestRunner::staticFunctions):
2104         * DumpRenderTree/TestRunner.h:
2105         * DumpRenderTree/mac/TestRunnerMac.mm:
2106         (TestRunner::setOnlyAcceptFirstPartyCookies):
2107         * DumpRenderTree/win/TestRunnerWin.cpp:
2108         (TestRunner::setOnlyAcceptFirstPartyCookies):
2109         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2110         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2111         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2112         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2113         * WebKitTestRunner/TestInvocation.cpp:
2114         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2115
2116 2019-01-09  Matt Rajca  <mrajca@apple.com>
2117
2118         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2119         https://bugs.webkit.org/show_bug.cgi?id=193301
2120
2121         Reviewed by Jer Noble.
2122         
2123         Added API tests.
2124
2125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2126         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2127         (TEST):
2128         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2129
2130 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2131
2132         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2133         https://bugs.webkit.org/show_bug.cgi?id=193310
2134
2135         Reviewed by Antti Koivisto.
2136
2137         * LayoutReloaded/misc/LFC-passing-tests.txt:
2138
2139 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2140
2141         Enable DFG on ARM/Linux again
2142         https://bugs.webkit.org/show_bug.cgi?id=192496
2143
2144         Reviewed by Yusuke Suzuki.
2145
2146         After changing the bytecode format DFG was disabled on all 32-bit
2147         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2148         on ARM by default.
2149
2150         * Scripts/run-jsc-stress-tests:
2151
2152 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2153
2154         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2155         https://bugs.webkit.org/show_bug.cgi?id=193271
2156
2157         Reviewed by Brent Fulgham.
2158
2159         BSTR is a special data structure created by SysAllocString, not a
2160         wchar_t null-terminated string.
2161
2162         * DumpRenderTree/win/TestRunnerWin.cpp:
2163         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2164         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2165         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2166         BSTR from wide string literals.
2167
2168 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2169
2170         Tweak wording for build/version_check style checker error
2171         https://bugs.webkit.org/show_bug.cgi?id=193256
2172
2173         Reviewed by Tim Horton.
2174
2175         * Scripts/webkitpy/style/checkers/cpp.py:
2176         (check_os_version_checks):
2177         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2178         (WebKitStyleTest.test_os_version_checks):
2179
2180 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2181
2182         [ews-build] Add link to bug along with bug title
2183         https://bugs.webkit.org/show_bug.cgi?id=193293
2184
2185         Reviewed by Lucas Forschler.
2186
2187         * BuildSlaveSupport/ews-build/steps.py:
2188         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2189         (ConfigureBuild.add_bug_id_url): Deleted.
2190         (ConfigureBuild.getBugURL): Deleted.
2191
2192 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2193
2194         [ews-build] Use https for ews-build server
2195         https://bugs.webkit.org/show_bug.cgi?id=193193
2196
2197         Reviewed by Lucas Forschler.
2198
2199         * BuildSlaveSupport/ews-build/steps.py:
2200
2201 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2202
2203         [ews-build] Parse and display number of style failures
2204         https://bugs.webkit.org/show_bug.cgi?id=193280
2205
2206         Reviewed by Lucas Forschler.
2207
2208         * BuildSlaveSupport/ews-build/steps.py:
2209         (CheckStyle): Use TestWithFailureCount as base class.
2210         (CheckStyle.countFailures): Count the number of style failures.
2211
2212 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2213
2214         [ews-build] use patch_id instead of ewspatchid
2215         https://bugs.webkit.org/show_bug.cgi?id=193235
2216
2217         Reviewed by Lucas Forschler.
2218
2219         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2220         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2221         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2222
2223 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2224
2225         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2226         https://bugs.webkit.org/show_bug.cgi?id=192625
2227
2228         Reviewed by Antti Koivisto.
2229
2230         * LayoutReloaded/misc/LFC-passing-tests.txt:
2231
2232 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2233
2234         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2235         https://bugs.webkit.org/show_bug.cgi?id=192841
2236
2237         Reviewed by Carlos Garcia Campos.
2238
2239         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2240         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2241         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2242
2243         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2244
2245         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2246         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2247         (WebKitWebEditorTest::testSelectionChanged):
2248         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2249         (WebKitFrameTest::testMainFrame):
2250         (WebKitFrameTest::testURI):
2251         (WebKitFrameTest::testJavaScriptContext):
2252         (WebKitFrameTest::testJavaScriptValues):
2253         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2254         (testWebViewAuthenticationRequest):
2255         (testWebViewAuthenticationLoadCancelled):
2256         (testWebViewAuthenticationFailure):
2257         (testWebViewAuthenticationStorage):
2258         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2259         (testWebViewAuthenticationProxy):
2260         (testWebViewAuthenticationProxyHTTPS):
2261         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2262         (testAutomationSessionRequestSession):
2263         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2264         (testBackForwardListNavigation):
2265         (testWebKitWebViewSessionState):
2266         (testWebKitWebViewSessionStateWithFormData):
2267         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2268         (ConsoleMessageTest::consoleMessageReceivedCallback):
2269         (testWebKitConsoleMessageConsoleAPI):
2270         (testWebKitConsoleMessageJavaScriptException):
2271         (testWebKitConsoleMessageNetworkError):
2272         (testWebKitConsoleMessageSecurityError):
2273         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2274         (testCookieManagerAcceptPolicy):
2275         (testCookieManagerCookiesChanged):
2276         (testCookieManagerPersistentStorage):
2277         (testCookieManagerPersistentStorageDeleteAll):
2278         (testCookieManagerEphemeral):
2279         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2280         (testWebKitDOMElementAutoFill):
2281         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2282         (downloadLocalFileSuccessfully):
2283         (createFileAtDestination):
2284         (testDownloadOverwriteDestinationDisallowed):
2285         (testDownloadLocalFileError):
2286         (testDownloadRemoteFile):
2287         (testDownloadRemoteFileError):
2288         (testWebViewDownloadURI):
2289         (testPolicyResponseDownload):
2290         (testPolicyResponseDownloadCancel):
2291         (testDownloadMIMEType):
2292         (contextMenuCallback):
2293         (testContextMenuDownloadActions):
2294         (testBlobDownload):
2295         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2296         (testWebKitWebEditorSelectionChanged):
2297         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2298         (testWebKitFrameMainFrame):
2299         (testWebKitFrameURI):
2300         (testWebKitFrameJavaScriptContext):
2301         (testWebKitFrameJavaScriptValues):
2302         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2303         (LoadStopTrackingTest::loadFailed):
2304         (testWebViewTitle):
2305         (testURIRequestHTTPHeaders):
2306         (testURIRequestHTTPMethod):
2307         (testURIResponseHTTPHeaders):
2308         (testRedirectToDataURI):
2309         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2310         (testProcessPerWebView):
2311         (testWebProcessLimit):
2312         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2313         (testWebViewResources):
2314         (testWebResourceLoading):
2315         (testWebResourceSuggestedFilename):
2316         (testWebResourceGetData):
2317         (testWebResourceGetDataError):
2318         (testWebViewResourcesHistoryCache):
2319         (testWebResourceSendRequest):
2320         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2321         (testSSL):
2322         (testInsecureContent):
2323         (testTLSErrorsPolicy):
2324         (testTLSErrorsRedirect):
2325         (testTLSErrorsHTTPAuth):
2326         (testLoadFailedWithTLSErrors):
2327         (testSubresourceLoadFailedWithTLSErrors):
2328         (httpsServerCallback):
2329         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2330         (testWebViewCreateNavigationData):
2331         (testWebViewJavaScriptDialogs):
2332         (testWebViewWindowProperties):
2333         (testWebViewMouseTarget):
2334         (testWebViewFileChooserRequest):
2335         (testWebViewColorChooserRequest):
2336         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2337         (testWebExtensionGetTitle):
2338         (testDocumentLoadedSignal):
2339         (testWebKitWebViewProcessCrashed):
2340         (testWebExtensionWindowObjectCleared):
2341         (testWebExtensionIsolatedWorld):
2342         (permissionRequestCallback):
2343         (didAssociateFormControlsCallback):
2344         (testWebExtensionFormControlsAssociated):
2345         (FormSubmissionTest::FormSubmissionTest):
2346         (FormSubmissionTest::testFormSubmissionResult):
2347         (testWebExtensionFormSubmissionSteps):
2348         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2349         (testNotInitialized):
2350         (testClearDatabase):
2351         (testPrivateBrowsing):
2352         (testGetFavicon):
2353         (testWebViewFavicon):
2354         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2355         (testFindControllerTextFound):
2356         (testFindControllerTextNotFound):
2357         (testFindControllerMatchCount):
2358         (testFindControllerMaxMatchCount):
2359         (testFindControllerNext):
2360         (testFindControllerPrevious):
2361         (testFindControllerCountedMatches):
2362         (testFindControllerOptions):
2363         (testFindControllerHide):
2364         (testFindControllerInstance):
2365         (testFindControllerGetters):
2366         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2367         (testNavigationPolicy):
2368         (testResponsePolicy):
2369         (testNewWindowPolicy):
2370         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2371         (testSecurityOriginBasicConstructor):
2372         (testSecurityOriginURIConstructor):
2373         (testSecurityOriginDefaultPort):
2374         (testSecurityOriginFileURI):
2375         (testOpaqueSecurityOrigin):
2376         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2377         (testWebKitSettings):
2378         (testWebKitSettingsNewWithSettings):
2379         (testWebKitSettingsUserAgent):
2380         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2381         (testWebViewNewWithUserContentManager):
2382         (isStyleSheetInjectedForURLAtPath):
2383         (isScriptInjectedForURLAtPath):
2384         (testUserContentManagerInjectedStyleSheet):
2385         (testUserContentManagerInjectedScript):
2386         (UserScriptMessageTest::scriptMessageReceived):
2387         (UserScriptMessageTest::waitUntilMessageReceived):
2388         (UserScriptMessageTest::runJavaScriptFinished):
2389         (testUserContentManagerScriptMessageReceived):
2390         (testUserContentManagerScriptMessageInWorldReceived):
2391         (testUserContentManagerScriptMessageFromDOMBindings):
2392         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2393         (testWebContextDefault):
2394         (testWebContextEphemeral):
2395         (testWebContextGetPlugins):
2396         (testWebContextURIScheme):
2397         (testWebContextSpellChecker):
2398         (testWebContextLanguages):
2399         (consoleMessageReceivedCallback):
2400         (testWebContextSecurityFileXHR):
2401         (ProxyTest::ProxyTest):
2402         (testWebContextProxySettings):
2403         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2404         (testWebViewWebContext):
2405         (testWebViewWebBackend):
2406         (testWebViewEphemeral):
2407         (testWebViewCustomCharset):
2408         (testWebViewSettings):
2409         (testWebViewRunJavaScript):
2410         (testWebViewCanShowMIMEType):
2411         (testWebViewSubmitForm):
2412         (testWebViewSave):
2413         (testWebViewPageVisibility):
2414         (testWebViewSnapshot):
2415         (testWebViewNotification):
2416         (testWebViewNotificationInitialPermissionAllowed):
2417         (testWebViewNotificationInitialPermissionDisallowed):
2418         (testWebViewIsPlayingAudio):
2419         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2420         (WebsiteDataTest::WebsiteDataTest):
2421         (WebsiteDataTest::remove):
2422         (WebsiteDataTest::clear):
2423         (testWebsiteDataConfiguration):
2424         (testWebsiteDataEphemeral):
2425         (testWebsiteDataCache):
2426         (testWebsiteDataStorage):
2427         (testWebsiteDataDatabases):
2428         (testWebsiteDataAppcache):
2429         (testWebsiteDataCookies):
2430         (testWebsiteDataDeviceIdHashSalt):
2431         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2432         (emitDocumentLoaded):
2433         (emitURIChanged):
2434         (sendRequestCallback):
2435         (contextMenuCallback):
2436         (consoleMessageSentCallback):
2437         (emitFormControlsAssociated):
2438         (formControlsAssociatedCallback):
2439         (emitFormSubmissionEvent):
2440         (willSubmitFormCallback):
2441         (windowObjectCleared):
2442         (methodCallCallback):
2443         (registerGResource):
2444         (webkit_web_extension_initialize_with_user_data):
2445         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2446         (checkLeaks):
2447         (WebProcessTest::create):
2448         (runTest):
2449         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2450         (AutocleanupsTest::testWebProcessAutocleanups):
2451         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2452         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2453         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2454         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2455         (WebKitDOMDOMWindowTest::testSignals):
2456         (WebKitDOMDOMWindowTest::testDispatchEvent):
2457         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2458         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2459         (WebKitDOMNodeFilterTest::testTreeWalker):
2460         (WebKitDOMNodeFilterTest::testNodeIterator):
2461         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2462         (WebKitDOMNodeTest::testHierarchyNavigation):
2463         (WebKitDOMNodeTest::testInsertion):
2464         (WebKitDOMNodeTest::testTagNamesNodeList):
2465         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2466         (WebKitDOMNodeTest::testDOMCache):
2467         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2468         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2469         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2470         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2471         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2472         (testUIProcessAutocleanups):
2473         (testWebProcessAutocleanups):
2474         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2475         (testContextMenuPopulateMenu):
2476         (testContextMenuDismissed):
2477         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2478         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2479         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2480         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
2481         (testWebKitDOMDOMWindowSignals):
2482         (testWebKitDOMDOMWindowDispatchEvent):
2483         (testWebKitDOMDOMWindowGetComputedStyle):
2484         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
2485         (testWebKitDOMNodeHierarchyNavigation):
2486         (testWebKitDOMNodeInsertion):
2487         (testWebKitDOMNodeTagNamesNodeList):
2488         (testWebKitDOMNodeTagNamesHTMLCollection):
2489         (testWebKitDOMObjectCache):
2490         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
2491         (testWebKitDOMNodeFilterTreeWalker):
2492         (testWebKitDOMNodeFilterNodeIterator):
2493         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
2494         (testWebKitDOMXPathNSResolverNative):
2495         (testWebKitDOMXPathNSResolverCustom):
2496         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2497         (testInspectorDefault):
2498         (testInspectorManualAttachDetach):
2499         (testInspectorCustomContainerDestroyed):
2500         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
2501         (startTestServer):
2502         (testInspectorServerPageList):
2503         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
2504         (OptionMenuTest::showOptionMenuCallback):
2505         (OptionMenuTest::menuCloseCallback):
2506         (OptionMenuTest::close):
2507         (OptionMenuTest::activateItem):
2508         (OptionMenuTest::selectItem):
2509         (testOptionMenuSimple):
2510         (testOptionMenuGroups):
2511         (testOptionMenuActivate):
2512         (testOptionMenuSelect):
2513         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2514         (testPrintOperationPrintSettings):
2515         (webViewPrintCallback):
2516         (testPrintOperationPrint):
2517         (testPrintCustomWidget):
2518         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2519         (checkAtspiAccessible):
2520         (testAtspiBasicHierarchy):
2521         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
2522         (testWebKitCheckVersion):
2523         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2524         (testWebViewEditorCutCopyPasteNonEditable):
2525         (testWebViewEditorCutCopyPasteEditable):
2526         (testWebViewEditorSelectAllNonEditable):
2527         (testWebViewEditorSelectAllEditable):
2528         (loadContentsAndTryToCutSelection):
2529         (testWebViewEditorNonEditable):
2530         (testWebViewEditorEditable):
2531         (testWebViewEditorEditorStateTypingAttributes):
2532         (testWebViewEditorInsertImage):
2533         (testWebViewEditorCreateLink):
2534         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2535         (loadChangedCallback):
2536         (loadFailedCallback):
2537         (loadFailedWithTLSErrorsCallback):
2538         (LoadTrackingTest::LoadTrackingTest):
2539         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2540         (registerGResource):
2541         (removeNonEmptyDirectory):
2542         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2543         (Test::adoptView):
2544         (Test::~Test):
2545         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2546         (WebKitTestBus::getOrCreateConnection):
2547         (WebKitTestBus::createProxy):
2548         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2549         (WebKitTestServer::getWebSocketURIForPath const):
2550         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2551         (WebViewTest::initializeWebView):
2552         (WebViewTest::loadURI):
2553         (WebViewTest::loadHtml):
2554         (WebViewTest::loadPlainText):
2555         (WebViewTest::loadBytes):
2556         (WebViewTest::loadRequest):
2557         (WebViewTest::loadAlternateHTML):
2558         (WebViewTest::goBack):
2559         (WebViewTest::goForward):
2560         (WebViewTest::goToBackForwardListItem):
2561         (resourceGetDataCallback):
2562         (WebViewTest::mainResourceData):
2563         (WebViewTest::javascriptResultToCString):
2564         (WebViewTest::javascriptResultToNumber):
2565         (WebViewTest::javascriptResultToBoolean):
2566         (WebViewTest::javascriptResultIsNull):
2567         (WebViewTest::javascriptResultIsUndefined):
2568         (onSnapshotReady):
2569         (WebViewTest::runWebProcessTest):
2570         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
2571         (WebViewTest::platformInitializeWebView):
2572         (WebViewTest::showInWindow):
2573         (WebViewTest::showInWindowAndWaitUntilMapped):
2574         (WebViewTest::mouseMoveTo):
2575         (WebViewTest::emitPopupMenuSignal):
2576         (WebViewTest::keyStroke):
2577         (WebViewTest::doMouseButtonEvent):
2578
2579 2019-01-09  Philippe Normand  <pnormand@igalia.com>
2580
2581         [WPE] API tests can't run in flatpak environment
2582         https://bugs.webkit.org/show_bug.cgi?id=193242
2583
2584         Reviewed by Michael Catanzaro.
2585
2586         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
2587         flatpakutils so that it knows which port it's dealing with.
2588         * glib/common.py: Remove build_dir globals so that subsequent
2589         calls actually take args into account.
2590         (library_build_path):
2591         (binary_build_path):
2592
2593 2019-01-08  Dean Jackson  <dino@apple.com>
2594
2595         Blob references for System Previews don't get a correct file extension
2596         https://bugs.webkit.org/show_bug.cgi?id=193268
2597         <rdar://problem/47133037>
2598
2599         Reviewed by Tim Horton.
2600
2601         New test that a Blob download of a USDZ file gets named correctly.
2602
2603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2604         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2605         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2606         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
2607         (TEST):
2608         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
2609
2610 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
2611
2612         [WebAuthN] Support U2F HID Authenticators on macOS
2613         https://bugs.webkit.org/show_bug.cgi?id=191535
2614         <rdar://problem/47102027>
2615
2616         Reviewed by Brent Fulgham.
2617
2618         This patch:
2619         1) adds support for U2F mocking mechanism;
2620         2) updates tests to reflect U2fCommandConstructor changes.
2621
2622         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2623         (TestWebKitAPI::TEST):
2624         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2625         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2626         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2627
2628 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2629
2630         [iOS] Dispatch a synthetic mousedown event prior to starting drags
2631         https://bugs.webkit.org/show_bug.cgi?id=193229
2632         <rdar://problem/46717097>
2633
2634         Reviewed by Tim Horton.
2635
2636         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
2637         prevents a drag from starting.
2638
2639         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2640         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
2641
2642         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
2643
2644 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
2645   
2646         Layout test will generate a perf metric file to results dir.
2647         https://bugs.webkit.org/show_bug.cgi?id=192030
2648         <rdar://problem/32779516>
2649
2650         Reviewed by Aakash Jain.
2651
2652         Layout test running time will be collected to a perf metric file.
2653         For now, instead of outputing running time of all tests (which is huge),
2654         we aggregate them by test directories which are at most two level deep. 
2655
2656         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2657         (Manager._end_test_run):
2658         (Manager._output_perf_metrics):
2659         (Manager._print_expectation_line_for_test):
2660         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2661         (add_test_perf_metric):
2662         (test_perf_metrics):
2663         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2664         (JSONGeneratorTest.test_test_timings_trie):
2665         (JSONGeneratorTest):
2666         (JSONGeneratorTest.test_test_perf_metrics):
2667         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2668         (RebaselineTest.test_reset_results):
2669         (RebaselineTest.test_missing_results):
2670         (RebaselineTest.test_new_baseline):
2671
2672 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
2673
2674         [WPE][GTK] Add php-json to install-dependencies
2675         https://bugs.webkit.org/show_bug.cgi?id=193233
2676
2677         Reviewed by Michael Catanzaro.
2678
2679         * gtk/install-dependencies:
2680         * wpe/install-dependencies:
2681
2682 2019-01-08  Chris Dumez  <cdumez@apple.com>
2683
2684         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
2685         https://bugs.webkit.org/show_bug.cgi?id=193224
2686         <rdar://problem/47097726>
2687
2688         Reviewed by Alex Christensen.
2689
2690         Add API test coverage.
2691
2692         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2693
2694 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2695
2696         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
2697         <https://webkit.org/b/193222>
2698         <rdar://problem/46862309>
2699
2700         Reviewed by Joseph Pecoraro.
2701
2702         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2703         (WTR::executeCallback): Fix camel case of variable name.
2704         (WTR::EventSendingController::callAfterScrollingCompletes): If
2705         WKBundlePageRegisterScrollOperationCompletionCallback() returns
2706         false, make sure to release the ScrollCompletionCallbackData
2707         object.  This fixes the leak.
2708
2709 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2710
2711         [Win] EWS: wincairo-ews cannot apply a patch with *.png
2712         https://bugs.webkit.org/show_bug.cgi?id=193044
2713
2714         Reviewed by Daniel Bates.
2715
2716         WinCairo EWS bots are using Windows Perl. Binary files should be
2717         opened as binary mode.
2718
2719         * Scripts/svn-apply:
2720         (handleGitBinaryChange): Use 'binmode' for binary file handles.
2721
2722 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
2723
2724         [CMake] Add ENABLE_CSS_TYPED_OM option
2725         https://bugs.webkit.org/show_bug.cgi?id=193216
2726
2727         Reviewed by Michael Catanzaro.
2728
2729         * Scripts/webkitperl/FeatureList.pm:
2730
2731 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2732
2733         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
2734         <https://webkit.org/b/193056>
2735
2736         Reviewed by Alex Christensen.
2737
2738         * Scripts/webkitpy/style/checker.py:
2739         - Ignore use of new runtime/retainptr check in
2740           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
2741           contains tests to ensure RetainPtr<NSObject *> is compatible
2742           with RetainPtr<NSObject>.
2743
2744         * Scripts/webkitpy/style/checkers/cpp.py:
2745         (check_language):
2746         (CppChecker):
2747         - Add checker for use of '*' in RetainPtr<> type.  A for loop
2748           was used instead of a single regex so that angle brackets
2749           could be matched up when checking the type contained within
2750           the RetainPtr<> type.
2751
2752         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2753         (CppStyleTest):
2754         - Add unit test for new runtime/retainptr check.
2755
2756         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
2757         * TestWebKitAPI/EditingTestHarness.h:
2758         - Remove '*' from RetainPtr<> type.
2759
2760         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2761         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
2762           regressed in r201938.
2763
2764         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2765         (TestWebKitAPI::TEST):
2766         - Update tests to match RetainPtr.mm tests (except for the
2767           `*SimilarNSType` tests since there is no CF equivalent of
2768           RetainPtr<NSString> and RetainPtr<NSString *>).
2769
2770         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2771         (TestWebKitAPI::TEST):
2772         - Update tests to:
2773           - Not conflict by name with equivalent CF tests in
2774             RetainPtr.cpp.
2775           - Add test cases for RetainPtr<NSObject>,
2776             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
2777           - Add `*SimilarNSType` tests for converting between
2778             RetainPtr<NSObject> and RetainPtr<NSObject *>.
2779           - Change `0` to `nil` as appropriate.
2780           - Re-alphabetize the tests by name.
2781           - Add Optional<RetainPtr<>> tests.
2782           - Add retainPtr() tests.
2783
2784         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2785         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2786         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
2787         (TEST):
2788         - Remove '*' from RetainPtr<> type.
2789
2790         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
2791         (TEST(WebKit, JITEnabled)):
2792         - Add missing WTFMove().  Apparently a temporary was being
2793           created before in the argument list due to mismatched
2794           RetainPtr<> types.
2795
2796         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2797         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2798         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
2799         (TestWebKitAPI::TEST):
2800         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2801         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2802         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2803         (WTR::resourcesDirectoryURL):
2804         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2805         (WTR::InjectedBundle::platformInitialize):
2806         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2807         - Remove '*' from RetainPtr<> type.
2808
2809 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
2810
2811         A MediaTime timescale must never be zero
2812         https://bugs.webkit.org/show_bug.cgi?id=193156
2813         <rdar://problem/32504501>
2814
2815         Reviewed by Jer Noble.
2816
2817         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2818         (TestWebKitAPI::TEST): Add tests for zero timescale.
2819
2820 2019-01-07  Youenn Fablet  <youenn@apple.com>
2821
2822         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
2823         https://bugs.webkit.org/show_bug.cgi?id=193175
2824
2825         Reviewed by Chris Dumez.
2826
2827         Updated API test as we bumped the SW schema to version 4.
2828
2829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2830         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
2831         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2832         (TEST):
2833
2834 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2835
2836         [Win][Clang] Fix compilation warnings of MiniBrowser
2837         https://bugs.webkit.org/show_bug.cgi?id=193029
2838
2839         Reviewed by Ross Kirsling.
2840
2841         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
2842         and m_URLBarFont. Reorder member variables to fix -Wreorder
2843         warning.
2844         * MiniBrowser/win/PageLoadTestClient.cpp:
2845         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
2846         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
2847         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
2848         m_currentURLIndex.
2849         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2850         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
2851         navigationClient with '{ }' to fix the missing field warning.
2852         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2853         (initDocStruct): Changed the argument type docname to const.
2854
2855 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
2856
2857         [WebAuthN] Import U2F command/response converters from Chromium
2858         https://bugs.webkit.org/show_bug.cgi?id=193150
2859         <rdar://problem/47054028>
2860
2861         Reviewed by Brent Fulgham.
2862
2863         Adds API tests.
2864
2865         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2866         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2867         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
2868         (TestWebKitAPI::getTestAuthenticatorDataBytes):
2869         (TestWebKitAPI::getTestAttestationObjectBytes):
2870         (TestWebKitAPI::getTestSignResponse):
2871         (TestWebKitAPI::getTestU2fRegisterResponse):
2872         (TestWebKitAPI::TEST):
2873         (TestWebKitAPI::convertToVector): Deleted.
2874         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2875         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
2876         (TestWebKitAPI::constructMakeCredentialRequest):
2877         (TestWebKitAPI::constructGetAssertionRequest):
2878         (TestWebKitAPI::TEST):
2879
2880 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
2881
2882         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
2883         https://bugs.webkit.org/show_bug.cgi?id=193136
2884
2885         Reviewed by Michael Catanzaro.
2886
2887         * gtk/install-dependencies:
2888         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
2889         they are needed by update-webkitgtk-libs.
2890
2891 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
2892
2893         Unreviewed follow-up fix to r239650
2894         https://bugs.webkit.org/show_bug.cgi?id=193140
2895         <rdar://problem/47063037>
2896
2897         Typecast patch_id to string.
2898
2899         * BuildSlaveSupport/ews-build/steps.py:
2900         (ValidatePatch._is_patch_obsolete):
2901
2902 2019-01-04  Daniel Bates  <dabates@apple.com>
2903
2904         [lldb-webkit]: Add support for pretty-printing raw bitmask types
2905         https://bugs.webkit.org/show_bug.cgi?id=193024
2906
2907         Reviewed by Jer Noble.
2908
2909         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
2910         for the bitmask type WebEventFlags as an example.
2911
2912         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
2913         that can be used to register summary and synthetic child formatters for a bitmask type.
2914         For example, consider the following enum and bitmask typedefs:
2915
2916         typedef enum {
2917             A = 1 << 0,
2918             B = 1 << 1,
2919             C = 1 << 2,
2920         } SpecialFlagValues;
2921         typedef unsigned SpecialFlags;
2922
2923         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
2924         __lldb_init_module():
2925
2926             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
2927                     1 << 0: "A",
2928                     1 << 1: "B",
2929                     1 << 2: "C",
2930             })
2931
2932         * lldb/lldb_webkit.py:
2933         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2934         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
2935         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
2936         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
2937         A convenience function to dynamically creaste a synthetic formatter class and summary
2938         string function for the specified bitmask type and enumerator value to name map. This
2939         function register the dynamically created class and function with LLDB.
2940
2941         (__lldb_init_module):
2942         (FlagEnumerationProvider):
2943         (FlagEnumerationProvider._enumerator_value_to_name_map):
2944         (FlagEnumerationProvider._bitmask):
2945         (FlagEnumerationProvider._update):
2946         (FlagEnumerationProvider.has_children):
2947         (FlagEnumerationProvider.num_children):
2948         (FlagEnumerationProvider.get_child_index):
2949         (FlagEnumerationProvider.get_child_at_index):
2950         (FlagEnumerationProvider.update):
2951         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
2952
2953         (WTFOptionSetProvider):
2954         (WTFOptionSetProvider._enumerator_value_to_name_map):
2955         (WTFOptionSetProvider._bitmask):
2956         (WTFOptionSetProvider._update):
2957         Write in terms of the base class.
2958
2959         (RawBitmaskProviderBase):
2960         (RawBitmaskProviderBase._enumerator_value_to_name_map):
2961         (RawBitmaskProviderBase._bitmask):
2962         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
2963         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
2964         {
2965             1 << 0: "A",
2966             1 << 1: "B",
2967             1 << 2: "C",
2968         }
2969         It is not necessary to instantiate such a derived class directory. Instead use the convenience
2970         function addSummaryAndSyntheticFormattersForRawBitmaskType.
2971
2972         (WTFOptionSetProvider.has_children): Deleted.
2973         (WTFOptionSetProvider.num_children): Deleted.
2974         (WTFOptionSetProvider.get_child_index): Deleted.
2975         (WTFOptionSetProvider.get_child_at_index): Deleted.
2976         (WTFOptionSetProvider.update): Deleted.
2977
2978 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2979
2980         [ews-build] Add build step to validate the patch before processing it
2981         https://bugs.webkit.org/show_bug.cgi?id=193140
2982
2983         Reviewed by Lucas Forschler.
2984
2985         * BuildSlaveSupport/ews-build/factories.py:
2986         (Factory.__init__): Added ValidatePatch step.
2987         * BuildSlaveSupport/ews-build/steps.py:
2988         (ValidatePatch):
2989         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
2990         (ValidatePatch.get_patch_json): Get patch json data.
2991         (ValidatePatch.get_bug_json): Get bug json data.
2992         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
2993         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
2994         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
2995         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
2996         (ValidatePatch.skip_build): Skip the build.
2997         (ValidatePatch.start):
2998
2999 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3000
3001         Progress towards fixing Mac CMake build
3002         https://bugs.webkit.org/show_bug.cgi?id=193105
3003
3004         Reviewed by Don Olmstead.
3005
3006         * TestWebKitAPI/PlatformMac.cmake:
3007
3008 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3009
3010         Fix API test after r239631
3011         https://bugs.webkit.org/show_bug.cgi?id=193118
3012
3013         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3014         (TestWebKitAPI::TEST):
3015         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
3016         Do the same thing via the API to fix the test.
3017
3018 2019-01-04  Jer Noble  <jer.noble@apple.com>
3019
3020         [WebKitLegacy] Media playback pauses on scroll
3021         https://bugs.webkit.org/show_bug.cgi?id=192829
3022
3023         Reviewed by Eric Carlson.
3024
3025         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3026         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
3027         (TestWebKitAPI::TEST):
3028         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
3029         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
3030         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
3031         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
3032         (TestWebKitAPI::TEST):
3033
3034 2019-01-04  Chris Dumez  <cdumez@apple.com>
3035
3036         Add support for toggling device orientation API support per site
3037         https://bugs.webkit.org/show_bug.cgi?id=193143
3038         <rdar://problem/46605724>
3039
3040         Reviewed by Alex Christensen.
3041
3042         Add API test coverage.
3043
3044         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3045         (-[DataMappingSchemeHandler setTaskHandler:]):
3046         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3047         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
3048         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3049         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
3050
3051 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3052
3053         [ews-build] use svn-apply script to apply the patches
3054         https://bugs.webkit.org/show_bug.cgi?id=193138
3055
3056         Reviewed by Lucas Forschler.
3057
3058         * BuildSlaveSupport/ews-build/factories.py:
3059         (Factory.__init__): Add the ApplyPatch step.
3060         * BuildSlaveSupport/ews-build/steps.py:
3061         (CheckOutSource): Added step name.
3062         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
3063         (ApplyPatch): Build step to apply patch using svn-apply script.
3064         (UnApplyPatchIfRequired):
3065         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
3066
3067 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3068
3069         Deprecate WKContextCreate
3070         https://bugs.webkit.org/show_bug.cgi?id=193118
3071
3072         Reviewed by Brady Eidson.
3073
3074         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3075         (WebKitBrowserWindow::WebKitBrowserWindow):
3076         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
3077         (TestWebKitAPI::TEST):
3078         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3079         (TestWebKitAPI::TEST):
3080         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3081         (TestWebKitAPI::TEST):
3082         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3083         (TestWebKitAPI::TEST):
3084         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3085         (TestWebKitAPI::TEST):
3086         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3087         (TestWebKitAPI::TEST):
3088         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3089         (TestWebKitAPI::TEST):
3090         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3091         (TestWebKitAPI::TEST):
3092         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3093         (TestWebKitAPI::TEST):
3094         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3095         (TestWebKitAPI::TEST):
3096         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3097         (TestWebKitAPI::TEST):
3098         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3099         (TestWebKitAPI::TEST):
3100         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3101         (TestWebKitAPI::TEST):
3102         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3103         (TestWebKitAPI::TEST):
3104         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3105         (TestWebKitAPI::TEST):
3106         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3107         (TestWebKitAPI::TEST):
3108         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3109         (TestWebKitAPI::TEST):
3110         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3111         (TestWebKitAPI::TEST):
3112         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3113         (TestWebKitAPI::loadAlternateHTMLString):
3114         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3115         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3116         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3117         (TestWebKitAPI::buildAndPerformTest):
3118         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3119         (TestWebKitAPI::TEST):
3120         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3121         (TestWebKitAPI::TEST):
3122         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3123         (TestWebKitAPI::TEST):
3124         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3125         (TestWebKitAPI::TEST):
3126         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3127         (TestWebKitAPI::TEST):
3128         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3129         (TestWebKitAPI::TEST):
3130         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3131         (TestWebKitAPI::TEST):
3132         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3133         (TestWebKitAPI::TEST):
3134         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3135         (TestWebKitAPI::TEST):
3136         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3137         (TestWebKitAPI::TEST):
3138         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3139         (TestWebKitAPI::TEST):
3140         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3141         (TestWebKitAPI::TEST):
3142         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3143         (TestWebKitAPI::TEST):
3144         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3145         (TestWebKitAPI::TEST):
3146         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3147         (TestWebKitAPI::TEST):
3148         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3149         (TestWebKitAPI::TEST):
3150         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3151         (TestWebKitAPI::TEST):
3152         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3153         (TestWebKitAPI::TEST):
3154         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3155         (TestWebKitAPI::TEST):
3156         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3157         (TestWebKitAPI::TEST):
3158         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3159         (TestWebKitAPI::TEST):
3160         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3161         (TestWebKitAPI::TEST):
3162         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3163         (TestWebKitAPI::TEST):
3164         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3165         (TestWebKitAPI::TEST):
3166         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3167         (TestWebKitAPI::TEST):
3168         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3169         (TestWebKitAPI::TEST):
3170         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3171         (WebKit2_CommandBackForwardTestWKView::SetUp):
3172         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3173         (TestWebKitAPI::TEST):
3174         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3175         (TestWebKitAPI::TEST):
3176         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3177         (TestWebKitAPI::TEST):
3178         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3179         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3180
3181 2019-01-03  Matt Rajca  <mrajca@apple.com>
3182
3183         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3184         https://bugs.webkit.org/show_bug.cgi?id=193128
3185         rdar://34554231
3186
3187         Reviewed by Jer Noble.
3188
3189         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3190         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3191         event along with a flag that indicates whether or not autoplay was actually prevented.
3192
3193         Tests: existing API tests were updated to reflect the new names. New API tests
3194         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3195
3196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3197         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3198         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3199         (TEST):
3200         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3201         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3202
3203 2019-01-04  Chris Dumez  <cdumez@apple.com>
3204
3205         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3206         https://bugs.webkit.org/show_bug.cgi?id=193120
3207
3208         Reviewed by Alex Christensen.
3209
3210         Add API test coverage.
3211
3212         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3213
3214 2019-01-04  Chris Dumez  <cdumez@apple.com>
3215
3216         Crash under WebProcessPool::addSuspendedPage()
3217         https://bugs.webkit.org/show_bug.cgi?id=193110
3218
3219         Reviewed by Youenn Fablet.
3220
3221         Add API test coverage.
3222
3223         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3224
3225 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3226
3227         [ews-build] Check patch relevance before applying the patch
3228         https://bugs.webkit.org/show_bug.cgi?id=193102
3229
3230         Reviewed by Lucas Forschler.
3231
3232         * BuildSlaveSupport/ews-build/factories.py:
3233         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3234
3235 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3236
3237         [ews-build] Check patch relevance step should print patch id
3238         https://bugs.webkit.org/show_bug.cgi?id=193137
3239
3240         Reviewed by Lucas Forschler.
3241
3242         * BuildSlaveSupport/ews-build/steps.py:
3243         (CheckPatchRelevance.start): Update the status to include patch id.
3244
3245 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3246
3247         webkitpy: Increase simulator teardown timeout
3248         https://bugs.webkit.org/show_bug.cgi?id=193141
3249         <rdar://problem/46174217>
3250
3251         Rubber-stamped by Aakash Jain.
3252
3253         * Scripts/webkitpy/xcode/simulated_device.py:
3254         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3255
3256 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3257
3258         test262-runner misbehaves when test file YAML has a trailing space
3259         https://bugs.webkit.org/show_bug.cgi?id=193053
3260
3261         Reviewed by Yusuke Suzuki.
3262
3263         * Scripts/test262/Runner.pm:
3264         (parseData):
3265         Accept trailing space when parsing a test file's YAML block.
3266
3267 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3268
3269         UserMedia test should use WKPageNavigationClient
3270         https://bugs.webkit.org/show_bug.cgi?id=192913
3271
3272         Reviewed by Youenn Fablet.
3273
3274         The test currently uses the deprecated WKPageLoaderClient. It should use
3275         WKPageNavigationClient instead, which provides the same callback under a similar name.
3276
3277         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3278         (TestWebKitAPI::TEST):
3279
3280 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3281
3282         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3283         https://bugs.webkit.org/show_bug.cgi?id=192944
3284
3285         Reviewed by Tim Horton.
3286
3287         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3288         (TestWebKitAPI::TEST):
3289
3290 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3291
3292         Add support for using the current text selection as the find string on iOS
3293         https://bugs.webkit.org/show_bug.cgi?id=193034
3294         <rdar://problem/45138739>
3295
3296         Reviewed by Tim Horton.
3297
3298         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3299         _setStringForFind) works as expected.
3300
3301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3302         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3303
3304 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3305
3306         [ews-build] Use git on OpenSource EWS bots
3307         https://bugs.webkit.org/show_bug.cgi?id=193092
3308
3309         Reviewed by Lucas Forschler.
3310
3311         * BuildSlaveSupport/ews-build/steps.py:
3312         (CheckOutSource): Use git instead of svn.
3313         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3314
3315 2019-01-02  Daniel Bates  <dabates@apple.com>
3316
3317         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3318         https://bugs.webkit.org/show_bug.cgi?id=193023
3319
3320         Reviewed by Simon Fraser.
3321
3322         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3323         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3324         enumerator values. We should just remove this code.
3325
3326         * lldb/lldb_webkit.py:
3327         (WTFOptionSetProvider.has_children):
3328         (WTFOptionSetProvider.num_children):
3329         (WTFOptionSetProvider.get_child_index):
3330         (WTFOptionSetProvider.get_child_at_index):
3331
3332 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3333
3334         .ycm_extra_conf.py should handle XXXInlines.h
3335         https://bugs.webkit.org/show_bug.cgi?id=193055
3336
3337         Reviewed by Carlos Garcia Campos.
3338
3339         compile_commands.json database only records flags and options for cpp source files.
3340         So, when we open headers, this database does not have any information for that.
3341         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3342         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3343         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3344         we attempt to find XXX.cpp and use the configuration if it exists.
3345
3346         * gtk/ycm_extra_conf.py:
3347         (getImplementationFilename):
3348         (FlagsForFile):
3349
3350 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3351
3352         Unreviewed. Support PHP 7.3 in Debian.
3353
3354         Add 7.3 to the list of php versions supported in Debian.
3355
3356         * Scripts/webkitpy/port/base.py:
3357         (Port._debian_php_version):
3358
3359 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3360
3361         Resurrect Mac CMake build
3362         https://bugs.webkit.org/show_bug.cgi?id=192658
3363
3364         Reviewed by Yusuke Suzuki.
3365
3366         * DumpRenderTree/PlatformMac.cmake:
3367         * MiniBrowser/mac/CMakeLists.txt:
3368         * TestWebKitAPI/PlatformMac.cmake:
3369
3370 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3371
3372         [Tools] Remove references to Bison and Flex
3373         https://bugs.webkit.org/show_bug.cgi?id=193033
3374
3375         Reviewed by Michael Catanzaro.
3376
3377         The Bison and Flex tools are not needed anymore since r209883.
3378
3379         * CygwinDownloader/cygwin-downloader.py:
3380         * EWSTools/ubuntu-ews-packages:
3381         * Scripts/filter-build-webkit:
3382         (shouldIgnoreLine):
3383         * gtk/install-dependencies:
3384         * wpe/install-dependencies:
3385
3386 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3387
3388         WebDriver: warn about non existing tests when parsing expectations
3389         https://bugs.webkit.org/show_bug.cgi?id=192979
3390
3391         Reviewed by Michael Catanzaro.
3392
3393         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
3394         renamed.
3395
3396         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3397         (WebDriverTestRunner.__init__):
3398
3399 2018-12-21  Chris Dumez  <cdumez@apple.com>
3400
3401         navigator.userAgent in service workers does not reflect customUserAgent set by client
3402         https://bugs.webkit.org/show_bug.cgi?id=192951
3403
3404         Reviewed by Youenn Fablet.
3405
3406         Extend API test coverage.
3407
3408         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3409         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
3410         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3411         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
3412         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3413
3414 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3415
3416         [WebAuthN] userPresence should always be true
3417         https://bugs.webkit.org/show_bug.cgi?id=192835
3418         <rdar://problem/46538788>
3419
3420         Reviewed by Brent Fulgham.
3421
3422         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3423         (TestWebKitAPI::TEST):
3424
3425 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
3426
3427         Add support to run-benchmark to use non-default copies of the browser apps
3428         https://bugs.webkit.org/show_bug.cgi?id=192905
3429         rdar://problem/46845840
3430
3431         Reviewed by Dewei Zhu.
3432         
3433         Add support for a --browser-path argument to run-benchmark, which allows you to use
3434         a custom app bundle for a given browser (only implemented for Safari at present).
3435
3436         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3437         (BenchmarkRunner.__init__):
3438         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3439         (BrowserDriver.__init__):
3440         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3441         (BrowserDriverFactory.create):
3442         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3443         (OSXBrowserDriver._launch_process):
3444         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
3445         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
3446         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3447         (OSXChromeCanaryDriver.launch_url):
3448         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3449         (OSXFirefoxNightlyDriver.launch_url):
3450         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3451         (OSXSafariDriver.__init__):
3452         (OSXSafariDriver.launch_url):
3453         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3454         (parse_args):
3455         (run_benchmark_plan):
3456         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3457         (WebServerBenchmarkRunner.__init__):
3458         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
3459         (FakeBenchmarkRunner.__init__):
3460
3461 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3462
3463         [WebAuthN] Import an APDU coder from Chromium
3464         https://bugs.webkit.org/show_bug.cgi?id=192949
3465         <rdar://problem/46879933>
3466
3467         Reviewed by Brent Fulgham.
3468
3469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3470         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
3471         (TestWebKitAPI::TEST):
3472
3473 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3474
3475         Setting the file wrapper and content type of an attachment to a PDF should update its image
3476         https://bugs.webkit.org/show_bug.cgi?id=192984
3477         <rdar://problem/46798028>
3478
3479         Reviewed by Tim Horton.
3480
3481         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
3482         PDF data correctly updates the image element.
3483
3484         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3485
3486 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3487
3488         Add JSCOnly to bot dashboard
3489         https://bugs.webkit.org/show_bug.cgi?id=192964
3490
3491         Reviewed by Alexey Proskuryakov.
3492
3493         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
3494         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
3495         useful if they were not so secret, so add them.
3496
3497         There appear to be no build-only bots, so the first column is blank. And of course there are
3498         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
3499         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
3500         and there's plenty of room in the final column for all the bots.
3501
3502         I had a hard time picking a logo to use, because the JavaScript language does not have an
3503         official logo. But I believe I've found one that will be satisfactory.
3504
3505         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
3506
3507         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
3508         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
3509         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3510         (BubbleQueueServer):
3511         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3512         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3513         (WebKitBuildbot):
3514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3515         (table.queue-grid tr.platform.linux-jsconly img.logo):
3516
3517 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
3518
3519         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3520         https://bugs.webkit.org/show_bug.cgi?id=192821
3521
3522         Reviewed by Chris Dumez.
3523
3524         * DumpRenderTree/mac/DumpRenderTree.mm:
3525         (createWebViewAndOffscreenWindow):
3526         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3527
3528 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3529
3530         [Win][Clang] Fix compilation warnings of DumpRenderTree
3531         https://bugs.webkit.org/show_bug.cgi?id=192924
3532
3533         Reviewed by Alex Christensen.
3534
3535         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
3536         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3537         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
3538         * DumpRenderTree/win/DumpRenderTree.cpp:
3539         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
3540         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
3541         object to the argument of setDefaultTextEncodingName instead of a
3542         const string literal.
3543         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
3544         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
3545         (setCacheFolder): Deleted.
3546         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
3547         * DumpRenderTree/win/EditingDelegate.cpp:
3548         (dump): Use %d for int.
3549         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
3550         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3551         (BSTRFromString): Deleted unused function.
3552         * DumpRenderTree/win/TestRunnerWin.cpp:
3553         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
3554         the arguemnt of setQuota instead of const string literal.
3555         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3556         (jsStringRefToWString): Deleted unused function.
3557
3558 2018-12-20  Chris Dumez  <cdumez@apple.com>
3559
3560         Add API test coverage for customUserAgent client setting and service workers
3561         https://bugs.webkit.org/show_bug.cgi?id=192952
3562
3563         Reviewed by Alex Christensen.
3564
3565         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3566         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
3567         (-[SWSchemes webView:startURLSchemeTask:]):
3568         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3569         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3570
3571 2018-12-20  Chris Dumez  <cdumez@apple.com>
3572
3573         Use Optional::hasValue() instead of Optional::has_value()
3574         https://bugs.webkit.org/show_bug.cgi?id=192948
3575
3576         Reviewed by Tim Horton.
3577
3578         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
3579         (TestWebKitAPI::TEST):
3580         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
3581         (TestWebKitAPI::TEST):
3582         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3583         (TestWebKitAPI::TEST_F):
3584
3585 2018-12-20  Chris Dumez  <cdumez@apple.com>
3586
3587         Add style script rule to check for uses of std::optional<>
3588         https://bugs.webkit.org/show_bug.cgi?id=192931
3589
3590         Reviewed by Tim Horton.
3591
3592         * Scripts/webkitpy/style/checkers/cpp.py:
3593         (check_wtf_optional):
3594         (check_style):
3595
3596 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
3597
3598         [WebAuthN] Add a runtime flag for local authenticator
3599         https://bugs.webkit.org/show_bug.cgi?id=192792
3600         <rdar://problem/46798738>
3601
3602         Reviewed by Brent Fulgham.
3603
3604         * DumpRenderTree/TestOptions.cpp:
3605         (TestOptions::TestOptions):
3606         * DumpRenderTree/TestOptions.h:
3607         * DumpRenderTree/mac/DumpRenderTree.mm:
3608         (enableExperimentalFeatures):
3609         (setWebPreferencesForTestOptions):
3610         * WebKitTestRunner/TestController.cpp:
3611         (WTR::TestController::resetPreferencesToConsistentValues):
3612         (WTR::updateTestOptionsFromTestHeader):
3613         * WebKitTestRunner/TestOptions.h:
3614         (WTR::TestOptions::hasSameInitializationOptions const):
3615
3616 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
3617
3618         webkitpy: Autoinstall package URLs have changed
3619         https://bugs.webkit.org/show_bug.cgi?id=192909
3620         <rdar://problem/46860359>
3621
3622         Rubber-stamped by Alexey Proskuryakov.
3623
3624         PyPi urls have been moved around, we need to update our auto-installed packages.
3625
3626         We should check for Selenium before asking PyPi for the latest version.
3627
3628         * Scripts/webkitpy/thirdparty/__init__.py:
3629         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
3630         (AutoinstallImportHook._install_keyring): Ditto.
3631         (AutoinstallImportHook._install_pep8): Ditto.
3632         (AutoinstallImportHook._install_mozlog): Ditto.
3633         (AutoinstallImportHook._install_mozprocess): Ditto.
3634         (AutoinstallImportHook._install_pytest_timeout): Ditto.
3635         (AutoinstallImportHook._install_pytest): Ditto.
3636         (AutoinstallImportHook._install_pylint): Ditto.
3637         (AutoinstallImportHook._install_buildbot): Ditto.
3638         (AutoinstallImportHook._install_coverage): Ditto.
3639         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
3640         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
3641         for new Selenium if the installed version isn't sufficient.
3642         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
3643
3644 2018-12-20  Chris Dumez  <cdumez@apple.com>
3645
3646         Use Optional::valueOr() instead of Optional::value_or()
3647         https://bugs.webkit.org/show_bug.cgi?id=192933
3648
3649         Reviewed by Geoffrey Garen.
3650
3651         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3652         (TestWebKitAPI::checkURL):
3653         (TestWebKitAPI::checkRelativeURL):
3654         (TestWebKitAPI::checkURLDifferences):
3655         (TestWebKitAPI::checkRelativeURLDifferences):
3656         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
3657         (TestWebKitAPI::checkURL):
3658
3659 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
3660
3661         Unreviewed, rolling out r239417.
3662
3663         Introduced two API test failures on macOS.
3664
3665         Reverted changeset:
3666
3667         "<rdar://problem/46194315> macOS: WebKit1 does not handle
3668         occlusion changes"
3669         https://bugs.webkit.org/show_bug.cgi?id=192821
3670         https://trac.webkit.org/changeset/239417
3671
3672 2018-12-20  Devin Rousso  <drousso@apple.com>
3673
3674         Web Inspector: UIString should take an optional key and description to aid localization
3675         https://bugs.webkit.org/show_bug.cgi?id=153962
3676         <rdar://problem/24542505>
3677
3678         Reviewed by Brian Burg.
3679
3680         * Scripts/extract-localizable-js-strings:
3681
3682 2018-12-20  Tim Horton  <timothy_horton@apple.com>
3683
3684         Unparented WKWebView can't retrieve main resource data for a main frame plugin
3685         https://bugs.webkit.org/show_bug.cgi?id=192923
3686         <rdar://problem/46859068>
3687
3688         Reviewed by Wenson Hsieh.
3689
3690         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3691         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
3692         Add a test ensuring that both parented and unparented WKWebViews can
3693         retrieve main resource data when loading a PDF.
3694
3695 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3696
3697         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
3698         https://bugs.webkit.org/show_bug.cgi?id=192852
3699
3700         Reviewed by Michael Catanzaro.
3701
3702         EmojiOne font was replaced by Noto Color Emoji.
3703
3704         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
3705         * gtk/jhbuild.modules:
3706         * wpe/jhbuild.modules:
3707
3708 2018-12-19  Chris Dumez  <cdumez@apple.com>
3709
3710         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
3711         https://bugs.webkit.org/show_bug.cgi?id=192728
3712         <rdar://problem/46746779>
3713
3714         Reviewed by Geoff Garen.
3715
3716         * DumpRenderTree/*:
3717         * MiniBrowser/*:
3718         * TestRunnerShared/*:
3719         * TestWebKitAPI/*:
3720         * WebGPUAPIStructure/*:
3721         * WebKitTestRunner/*:
3722
3723 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
3724
3725         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3726         https://bugs.webkit.org/show_bug.cgi?id=192821
3727
3728         Reviewed by Chris Dumez.
3729
3730         * DumpRenderTree/mac/DumpRenderTree.mm:
3731         (createWebViewAndOffscreenWindow):
3732
3733 2018-12-19  Alex Christensen  <achristensen@webkit.org>
3734
3735         Navigations away from the SafeBrowsing interstitial show a flash of old content
3736         https://bugs.webkit.org/show_bug.cgi?id=192676
3737
3738         Reviewed by Chris Dumez.
3739
3740         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3741         (safeBrowsingView):
3742         (TEST):
3743         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3744
3745 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
3746
3747         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
3748         https://bugs.webkit.org/show_bug.cgi?id=192855
3749
3750         Reviewed by Michael Catanzaro.
3751
3752         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3753         (WTR::TestController::notifyDone): Use the WPE implementation.
3754         (WTR::TestController::platformRunUntil): Use the WPE implementation.
3755         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
3756         (WTR::TestController::platformRunUntil): Honor the condition flag.
3757
3758 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
3759
3760         Allow clients to set the navigator platform
3761         https://bugs.webkit.org/show_bug.cgi?id=192735
3762
3763         Reviewed by Tim Horton.
3764
3765         Add a test for setting a custom navigator platform.
3766
3767         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3768         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3769         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
3770
3771 2018-12-19  Truitt Savell  <tsavell@apple.com>
3772
3773         Unreviewed, rolling out r239358.
3774
3775         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
3776         crash on Debug bots
3777
3778         Reverted changeset:
3779
3780         "Clean up IndexedDB files between tests"
3781         https://bugs.webkit.org/show_bug.cgi?id=192796
3782         https://trac.webkit.org/changeset/239358
3783
3784 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3785
3786         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
3787         https://bugs.webkit.org/show_bug.cgi?id=192842
3788         <rdar://problem/46823586>
3789
3790         Reviewed by Tim Horton.
3791
3792         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
3793         item provider when dragging a rich text selection.
3794
3795         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3796
3797 2018-12-18  David Quesada  <david_quesada@apple.com>
3798
3799         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
3800         https://bugs.webkit.org/show_bug.cgi?id=192810
3801         <rdar://problem/46812536>
3802
3803         Reviewed by Alex Christensen.
3804
3805         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3806         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3807             After releasing our reference to the web view, wait until the next turn of the runloop
3808             before checking that the originatingWebView has been zeroed, since the web view might
3809             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
3810             testing general memory management of WKWebViews, only that _WKDownload does not retain
3811             its web view via the 'originatingWebView' property.
3812
3813 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
3814
3815         Clean up IndexedDB files between tests
3816         https://bugs.webkit.org/show_bug.cgi?id=192796
3817
3818         Reviewed by Geoffrey Garen.
3819
3820         * DumpRenderTree/mac/DumpRenderTree.mm:
3821         (runTest):
3822         * WebKitTestRunner/TestController.cpp:
3823         (WTR::TestController::resetStateToConsistentValues):
3824         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3825         (WTR::RemoveAllIndexedDatabasesCallback):
3826         (WTR::TestController::ClearIndexedDatabases):
3827         * WebKitTestRunner/TestController.h:
3828
3829 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3830
3831         Fix API test introduced in r239339 on iOS.
3832         https://bugs.webkit.org/show_bug.cgi?id=192675
3833
3834         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3835         (TEST):
3836         The iOS implementation of the safe browsing warning is a little different.
3837         It does some element creation when it is added to the window so it knows how big it is.
3838         To test these elements, we need to simulate adding it to the window.
3839         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
3840
3841 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
3842
3843         webkitpy: Ignore device type for test when using --force
3844         https://bugs.webkit.org/show_bug.cgi?id=192786
3845         <rdar://problem/46794894>
3846
3847         Reviewed by Daniel Bates.
3848
3849         It is sometimes the case that a contributor will wish to run a test on a specific device,
3850         despite expectations which indicate a test should not be run on that device.
3851
3852         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3853         (parse_args):
3854         * Scripts/webkitpy/port/device_port.py:
3855         (DevicePort.default_child_processes): Strip device type information when using --force.
3856         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
3857
3858 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3859
3860         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
3861         https://bugs.webkit.org/show_bug.cgi?id=192675
3862
3863         Reviewed by Geoffrey Garen.
3864
3865         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3866         (goBack):
3867         (TEST):
3868         (visitUnsafeSite):
3869         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
3870         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3871
3872 2018-12-18  Chris Dumez  <cdumez@apple.com>
3873
3874         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
3875         https://bugs.webkit.org/show_bug.cgi?id=192772
3876
3877         Reviewed by Antti Koivisto.
3878
3879         Add API test coverage.
3880
3881         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3882
3883 2018-12-18  Philippe Normand  <pnormand@igalia.com>
3884
3885         Unreviewed, JHBuild GTK build fix attempt
3886
3887         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
3888         There's no ninja module either, it should be provided by the
3889         host system.
3890
3891 2018-12-17  Chris Dumez  <cdumez@apple.com>
3892
3893         Allow passing nil as session state to [WKWebView _restoreSessionState:]
3894         https://bugs.webkit.org/show_bug.cgi?id=192789
3895         <rdar://problem/46755277>
3896
3897         Reviewed by Alex Christensen.
3898
3899         Add API test coverage.
3900
3901         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3902         (TEST):
3903
3904 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
3905
3906         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
3907         https://bugs.webkit.org/show_bug.cgi?id=192780
3908         rdar://problem/43394387
3909
3910         Reviewed by Tim Horton.
3911
3912         No need to set "AppleFontSmoothing" defaults for WK2.
3913
3914         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3915         (WTR::InjectedBundle::platformInitialize):
3916
3917 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
3918
3919         webkitpy: Handle case where stdout and stderr don't accept unicode
3920         https://bugs.webkit.org/show_bug.cgi?id=192775
3921         <rdar://problem/46497303>
3922
3923         Reviewed by Stephanie Lewis.
3924
3925         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3926         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
3927         characters with '?'.
3928         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3929         (RegularTest.test_stream_with_encoding):
3930
3931 2018-12-17  Daniel Bates  <dabates@apple.com>
3932
3933         Support concatenating StringView with other string types
3934         https://bugs.webkit.org/show_bug.cgi?id=177566
3935
3936         Reviewed by Darin Adler.
3937
3938         Add some tests to ensure we do not regress the number of allocations needed when performing
3939         string concatenation with string views.
3940
3941         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3942         (TestWebKitAPI::TEST):
3943
3944 2018-12-17  Commit Queue  <commit-queue@webkit.org>
3945
3946         Unreviewed, rolling out r239265 and r239274.
3947         https://bugs.webkit.org/show_bug.cgi?id=192765
3948
3949         unorm_normalize is deprecated, and broke an internal build
3950         (Requested by Truitt on #webkit).
3951
3952         Reverted changesets:
3953
3954         "[GTK][WPE] Need a function to convert internal URI to display
3955         ("pretty") URI"
3956         https://bugs.webkit.org/show_bug.cgi?id=174816
3957         https://trac.webkit.org/changeset/239265
3958
3959         "Fix the Apple Internal Mac build with a newer SDK"
3960         https://trac.webkit.org/changeset/239274
3961
3962 2018-12-17  Daniel Bates  <dabates@apple.com>
3963
3964         Implement UIScriptController::toggleCapsLock() for iOS
3965         https://bugs.webkit.org/show_bug.cgi?id=191815
3966
3967         Reviewed by Andy Estes.
3968
3969         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
3970
3971         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3972         * WebKitTestRunner/TestController.cpp:
3973         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
3974         before running a test. This ensures that the caps lock state does not persist between
3975         tests should a test enable caps lock and not disable it.
3976         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3977         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
3978         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3979         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
3980         create the event. Also substituted NSString* for const String& as the data type for the first
3981         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
3982         below.
3983         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
3984         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
3985
3986 2018-12-17  Daniel Bates  <dabates@apple.com>
3987
3988         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
3989         https://bugs.webkit.org/show_bug.cgi?id=192633
3990
3991         Reviewed by Wenson Hsieh.
3992
3993         Update code to use the modern initializer.
3994
3995         * DumpRenderTree/mac/EventSendingController.mm:
3996         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3997
3998 2018-12-17  Matt Lewis  <jlewis3@apple.com>
3999
4000         Unreviewed, rolling out r239254.
4001
4002         This broke the Windows 10 Debug build
4003
4004         Reverted changeset:
4005
4006         "Replace many uses of String::format with more type-safe
4007         alternatives"
4008         https://bugs.webkit.org/show_bug.cgi?id=192742
4009         https://trac.webkit.org/changeset/239254
4010
4011 2018-12-17  David Kilzer  <ddkilzer@apple.com>
4012
4013         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
4014         <https://webkit.org/b/192751>
4015         <rdar://problem/46771623>
4016
4017         Reviewed by Daniel Bates.
4018
4019         Change loop variables to const references to avoid unnecessary
4020         copies.
4021
4022         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
4023         (-[LocalPasteboard pasteboardItems]):
4024
4025 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
4026
4027         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
4028         https://bugs.webkit.org/show_bug.cgi?id=174816
4029
4030         Reviewed by Michael Catanzaro.
4031
4032         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
4033
4034         * TestWebKitAPI/CMakeLists.txt:
4035         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4036         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
4037         (TestWebKitAPI::TEST):
4038         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
4039         (testURIForDisplayUnaffected):
4040         (testURIForDisplayAffected):
4041         (beforeAll):
4042         (afterAll):
4043         * TestWebKitAPI/glib/CMakeLists.txt:
4044
4045 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
4046
4047         [WPE] Add API to notify about frame displayed view backend callback
4048         https://bugs.webkit.org/show_bug.cgi?id=192224
4049
4050         Reviewed by Michael Catanzaro.
4051
4052         Add a test case to check the new API.
4053
4054         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4055         (testWebViewFrameDisplayed):
4056         (beforeAll):
4057         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
4058
4059 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
4060
4061         Unreviewed build fix after r239253
4062
4063         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
4064
4065 2018-12-15  Darin Adler  <darin@apple.com>
4066
4067         Use warning-ignoring macros more consistently and simply
4068         https://bugs.webkit.org/show_bug.cgi?id=192743
4069
4070         Reviewed by Mark Lam.
4071
4072         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4073         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
4074         * DumpRenderTree/mac/TextInputControllerMac.m:
4075         (-[TextInputController interpretKeyEvents:withSender:]): Use
4076         IGNORE_WARNINGS_BEGIN/END.
4077         * WebKitTestRunner/mac/EventSenderProxy.mm:
4078         (WTR::EventSenderProxy::mouseForceClick): Use
4079         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
4080         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
4081         (WTR::EventSenderProxy::mouseForceDown): Ditto.
4082         (WTR::EventSenderProxy::mouseForceUp): Ditto.
4083         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
4084
4085 2018-12-15  Darin Adler  <darin@apple.com>
4086
4087         Replace many uses of String::format with more type-safe alternatives
4088         https://bugs.webkit.org/show_bug.cgi?id=192742
4089
4090         Reviewed by Mark Lam.
4091
4092         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4093         (WTR::cacheTestRunnerCallback): Use makeString.
4094         * WebKitTestRunner/TestController.cpp:
4095         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
4096         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
4097
4098 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
4099
4100         [WPE][GTK] Add libpsl to JHBuild module sets
4101         https://bugs.webkit.org/show_bug.cgi?id=192740
4102
4103         Reviewed by Michael Catanzaro.
4104
4105         * gtk/jhbuild.modules: Add libpsl module.
4106         * wpe/jhbuild.modules: Ditto.
4107
4108 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
4109
4110         Add a style checker rule for Xcode version macros use
4111         https://bugs.webkit.org/show_bug.cgi?id=192703
4112
4113         Reviewed by Alex Christensen.
4114
4115         * Scripts/webkitpy/style/checkers/cpp.py:
4116         (check_os_version_checks):
4117         (process_line):
4118         (CppChecker):
4119         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4120         (WebKitStyleTest.test_os_version_checks):
4121
4122 2018-12-14  Chris Dumez  <cdumez@apple.com>
4123
4124         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
4125         https://bugs.webkit.org/show_bug.cgi?id=192704
4126
4127         Reviewed by Geoffrey Garen.
4128
4129         Extend existing API test to reproduce the problem.
4130
4131         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4132
4133 2018-12-14  Chris Dumez  <cdumez@apple.com>
4134
4135         [PSON] WebsitePolicies are lost on process-swap
4136         https://bugs.webkit.org/show_bug.cgi?id=192694
4137         <rdar://problem/46715748>
4138
4139         Reviewed by Brady Eidson.
4140
4141         Extend existing API test to reproduce the issue.
4142
4143         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4144
4145 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
4146
4147         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
4148         https://bugs.webkit.org/show_bug.cgi?id=192678
4149
4150         Reviewed by Carlos Garcia Campos.
4151
4152         Update our ancient versions of libsoup and glib-networking.
4153
4154         * gtk/install-dependencies:
4155         * gtk/jhbuild.modules:
4156         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
4157         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
4158         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
4159         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
4160         * wpe/install-dependencies:
4161         * wpe/jhbuild.modules:
4162         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
4163
4164 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4165
4166         [WPE] Use new view state API from libwpe
4167         https://bugs.webkit.org/show_bug.cgi?id=191906
4168
4169         Reviewed by Žan Doberšek.
4170
4171         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4172         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
4173         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4174         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
4175         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
4176         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4177         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
4178         wpe_view_activity_state_focused state flags.
4179         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
4180         * wpe/backends/HeadlessViewBackend.cpp:
4181         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
4182         * wpe/backends/WindowViewBackend.cpp:
4183         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
4184         received in configure callback.
4185         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
4186
4187 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
4188
4189         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
4190         https://bugs.webkit.org/show_bug.cgi?id=192688
4191
4192         Reviewed by Ross Kirsling.
4193
4194         * win/DLLLauncher/DLLLauncherMain.cpp:
4195         (copyEnvironmentVariable): Moved.
4196         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
4197         (applePathFromRegistry): Ditto.
4198         (appleApplicationSupportDirectory): Ditto.
4199         (prependPath): Ditto.
4200
4201 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
4202
4203         Unreviewed. Changed my status to a reviewer.
4204
4205         * Scripts/webkitpy/common/config/contributors.json:
4206
4207 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4208
4209         [iOS] Support dropping contact card data (public.vcard) in editable content
4210         https://bugs.webkit.org/show_bug.cgi?id=192570
4211         <rdar://problem/35626913>
4212
4213         Reviewed by Tim Horton.
4214
4215         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4216
4217         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
4218         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
4219         additionally inserts a link).
4220
4221         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4222         (TestWebKitAPI::createMapItemForTesting):
4223         (TestWebKitAPI::createContactItemForTesting):
4224
4225         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
4226         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
4227         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
4228         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
4229         files.
4230
4231 2018-12-13  Ross Kirsling  <ross.kirsling@sony.com>
4232
4233         Unreviewed -- update my status to "reviewer".
4234
4235         * Scripts/webkitpy/common/config/contributors.json:
4236
4237 2018-12-13  Youenn Fablet  <youenn@apple.com>
4238
4239         On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
4240         https://bugs.webkit.org/show_bug.cgi?id=192657
4241
4242         Reviewed by Eric Carlson.
4243
4244         Add a test that loads a page registering ondevicechange,
4245         load another page in the same process, closes the first page.
4246         Ensure that the process does not crash in that case.
4247
4248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4249         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4250         (TestWebKitAPI::TEST):
4251         (TestWebKitAPI::didCrashCallback):
4252         * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
4253
4254 2018-12-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4255
4256         [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
4257         https://bugs.webkit.org/show_bug.cgi?id=192643
4258
4259         Reviewed by Philippe Normand.
4260
4261         This problem happens with Arch Linux users which have libfdk-2.0.0
4262         installed (which is anybody with gst-plugins-bad 1.14.4 installed).
4263
4264         The problem has already been solved upstream at
4265         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
4266
4267         Adding patches while this problem is not in a release yet.
4268
4269         * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
4270         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
4271         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
4272
4273 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4274
4275         [FreeType] Add initial implementation of variation fonts
4276         https://bugs.webkit.org/show_bug.cgi?id=192151
4277
4278         Reviewed by Michael Catanzaro.
4279
4280         Add cairo patch to avoid crashes.
4281
4282         * gtk/jhbuild.modules:
4283         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
4284
4285 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
4286
4287         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
4288         https://bugs.webkit.org/show_bug.cgi?id=192618
4289
4290         Reviewed by Alex Christensen.
4291
4292         * DumpRenderTree/win/DRTDataObject.cpp:
4293         * DumpRenderTree/win/DRTDataObject.h:
4294         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
4295         * DumpRenderTree/win/DRTDropSource.h:
4296         * DumpRenderTree/win/EditingDelegate.h:
4297         *