[ews-app] Remove BuilderMapping table
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] Remove BuilderMapping table
4         https://bugs.webkit.org/show_bug.cgi?id=194961
5
6         Reviewed by Stephanie Lewis.
7
8         Store builder name directly in build table, instead of having a separate
9         table for it.
10
11         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
12         * BuildSlaveSupport/ews-app/ews/models/build.py:
13         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
14         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
15
16 2019-02-25  John Wilander  <wilander@apple.com>
17
18         Introduce and adopt new class RegistrableDomain for eTLD+1
19         https://bugs.webkit.org/show_bug.cgi?id=194791
20         <rdar://problem/48179240>
21
22         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
23
24         This patch adds an API test and replaces two instances of
25         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
26
27         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
28         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
29         (TestWebKitAPI::TEST):
30             Changed two strings to make sure the registrable domains are still considered
31             invalid and pass the test.
32         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
33         (TestWebKitAPI::TEST):
34         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
35         (WTR::InjectedBundle::didReceiveMessageToPage):
36
37 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
38
39         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
40         https://bugs.webkit.org/show_bug.cgi?id=195001
41
42         Reviewed by Carlos Garcia Campos.
43
44         API version 1.0 always includes the functionality previously guarded with
45         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
46         unconditionally.
47
48         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
49         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
50         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
51         (WebViewTest::showInWindow): Ditto.
52         (WebViewTest::hideView): Ditto.
53         * wpe/backends/HeadlessViewBackend.cpp:
54         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
55         * wpe/backends/ViewBackend.cpp:
56         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
57         * wpe/backends/WindowViewBackend.cpp:
58         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
59         WPE_BACKEND_CHECK_VERSION().
60         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
61
62 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
63
64         [Flatpak] Add support for flatpak > 1.1.2
65         https://bugs.webkit.org/show_bug.cgi?id=194088
66
67         Flatpak 1.2 is now out so we need to support that
68         version now.
69
70         Reviewed by Michael Catanzaro.
71
72         * flatpak/flatpakutils.py:
73         (check_flatpak):
74         (FlatpakPackages.__init__):
75         (FlatpakPackages.__detect_packages):
76         (FlatpakPackages.__detect_packages.in):
77         (FlatpakRepos.update):
78
79 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
80
81         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
82         https://bugs.webkit.org/show_bug.cgi?id=194998
83
84         Reviewed by Carlos Garcia Campos.
85
86         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
87         to a Git checkout and using the latest commit containing various fixes
88         and improvements.
89
90 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
91
92         [WPE][GTK] Remove user agent quirk for washingtonpost.com
93         https://bugs.webkit.org/show_bug.cgi?id=194981
94
95         Reviewed by Žan Doberšek.
96
97         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
98         (TestWebKitAPI::TEST):
99
100 2019-02-23  Keith Miller  <keith_miller@apple.com>
101
102         Add new mac target numbers
103         https://bugs.webkit.org/show_bug.cgi?id=194955
104
105         Reviewed by Tim Horton.
106
107         * DumpRenderTree/mac/Configurations/Base.xcconfig:
108         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
109         * MiniBrowser/Configurations/Base.xcconfig:
110         * TestWebKitAPI/Configurations/Base.xcconfig:
111         * WebKitTestRunner/Configurations/Base.xcconfig:
112
113 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
114
115         [WinCairo] Enable wk1/wk2 suffix for platform search path.
116         https://bugs.webkit.org/show_bug.cgi?id=194846
117
118         Reviewed by Don Olmstead.
119
120         Added _search_paths() and _port_specific_expectations_files() for
121         WinCairoPort.
122
123         * Scripts/webkitpy/port/win.py:
124         (WinCairoPort.default_baseline_search_path):
125         (WinCairoPort):
126         (WinCairoPort._port_specific_expectations_files):
127         (WinCairoPort._search_paths):
128
129 2019-02-22  Tim Horton  <timothy_horton@apple.com>
130
131         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
132         https://bugs.webkit.org/show_bug.cgi?id=194963
133
134         Reviewed by Dean Jackson.
135
136         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
137         Do a `contains` check instead of `equals`, because in debug builds we
138         put the GraphicsLayer pointer in a prefix.
139
140 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
141
142         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
143         https://bugs.webkit.org/show_bug.cgi?id=194873
144         <rdar://problem/46701974>
145
146         Reviewed by Tim Horton.
147
148         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
149
150         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
151         (WTR::UIScriptController::menuRect const):
152         (WTR::UIScriptController::isShowingMenu const):
153         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
154         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
155         (WTR::UIScriptController::menuRect const):
156
157         Add a function to query the bounds of the callout menu in content coordinates.
158
159         (WTR::UIScriptController::isShowingMenu const):
160
161         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
162
163         * TestRunnerShared/UIScriptContext/UIScriptController.h:
164         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
165         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
166         (WTR::UIScriptController::rectForMenuAction const):
167         (WTR::UIScriptController::menuRect const):
168         (WTR::UIScriptController::isShowingMenu const):
169         (WTR::findViewInHierarchyOfType): Deleted.
170
171 2019-02-22  Chris Dumez  <cdumez@apple.com>
172
173         Regression(PSON) Unable to preview password-protected documents on iCloud.com
174         https://bugs.webkit.org/show_bug.cgi?id=194954
175         <rdar://problem/48127957>
176
177         Reviewed by Alex Christensen.
178
179         Add API test coverage.
180
181         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
182         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
183         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
184         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
185
186 2019-02-22  Chris Dumez  <cdumez@apple.com>
187
188         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
189         https://bugs.webkit.org/show_bug.cgi?id=194924
190         <rdar://problem/48216125>
191
192         Reviewed by Geoffrey Garen.
193
194         Add API test coverage.
195
196         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
197
198 2019-02-22  Chris Dumez  <cdumez@apple.com>
199
200         Unreviewed, disable API test added in r241928 on iOS.
201
202         The cache is not enabled on devices with less than 3GB of RAM.
203
204         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
205
206 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
207
208         Hardcode Visual Viewports on everywhere except iOS WK1
209         https://bugs.webkit.org/show_bug.cgi?id=194928
210
211         Reviewed by Zalan Bujtas.
212
213         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
214         change the default value of the Setting to 'true', and hardcode WebView on iOS to
215         set it to false. The setting has shipped for several years and there's no need to turn
216         it off now.
217
218         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
219         Visual Viewports are not enabled.
220         
221         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
222         that only runs in WK2
223
224         * MiniBrowser/mac/SettingsController.h:
225         * MiniBrowser/mac/SettingsController.m:
226         (-[SettingsController init]):
227         (-[SettingsController _populateMenu]):
228         (-[SettingsController validateMenuItem:]):
229         (-[SettingsController visualViewportEnabled]): Deleted.
230         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
231         * MiniBrowser/mac/WK1BrowserWindowController.m:
232         (-[WK1BrowserWindowController didChangeSettings]):
233         * MiniBrowser/mac/WK2BrowserWindowController.m:
234         (-[WK2BrowserWindowController didChangeSettings]):
235
236 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
237
238         Discard cached processes when clearing website data store
239         https://bugs.webkit.org/show_bug.cgi?id=194894
240
241         Reviewed by Chris Dumez.
242
243         Added a test case.
244
245         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
246         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
247
248 2019-02-21  Alex Christensen  <achristensen@webkit.org>
249
250         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
251         https://bugs.webkit.org/show_bug.cgi?id=194914
252         <rdar://problem/47586889>
253
254         Reviewed by Geoffrey Garen.
255
256         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
257         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
258         (TEST):
259         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
260
261 2019-02-21  David Kilzer  <ddkilzer@apple.com>
262
263         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
264         <https://webkit.org/b/194761>
265
266         Reviewed by Myles Maxfield.
267
268         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
269         (WTR::activateSystemCoreWebFonts): Log `error` to console if
270         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
271         to use ARC-compliant cast.
272         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
273         ARC-compliant cast.
274         (WTR::installFakeHelvetica): Log `error` to console if
275         CTFontManagerRegisterFontsForURL() fails, but only on supported
276         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
277         Call CFRelease() on `error` to fix the leak.  Update to use
278         ARC-compliant cast.
279         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
280         cast.
281
282 2019-02-21  Chris Dumez  <cdumez@apple.com>
283
284         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
285         https://bugs.webkit.org/show_bug.cgi?id=194481
286
287         Reviewed by Alex Christensen.
288
289         Give the processes a chance to shutdown and wait until we reached the expected number
290         of processes.
291
292         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
293
294 2019-02-21  Tim Horton  <timothy_horton@apple.com>
295
296         Fix the macOS build
297
298         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
299
300 2019-02-21  Tim Horton  <timothy_horton@apple.com>
301
302         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
303
304         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
305         I am a backwards.
306
307 2019-02-21  Tim Horton  <timothy_horton@apple.com>
308
309         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
310
311         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
312         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
313         We could force on UI-side compositing, but I feel like the test might be more
314         valuable exercising the normal path on each platform (though the original
315         bug was also UI-side specific). Though we can't validate that the overlay
316         layer was installed successfully, there are layout tests that do that.
317
318 2019-02-21  Tim Horton  <timothy_horton@apple.com>
319
320         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
321         https://bugs.webkit.org/show_bug.cgi?id=194845
322         <rdar://problem/47944579>
323
324         Reviewed by Antti Koivisto.
325
326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
327         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
328
329 2019-02-21  Zalan Bujtas  <zalan@apple.com>
330
331         [LFC][Floats] Add support for placing formatting roots in-between floats.
332         https://bugs.webkit.org/show_bug.cgi?id=194902
333
334         Reviewed by Antti Koivisto.
335
336         * LayoutReloaded/misc/LFC-passing-tests.txt:
337
338 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
339
340         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
341         https://bugs.webkit.org/show_bug.cgi?id=194901
342
343         Unreviewed build fix.
344
345         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
346         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
347         WPEBackend-fdo-0.1 as library name.
348
349 2019-02-21  Rob Buis  <rbuis@igalia.com>
350
351         Update MIME type parser
352         https://bugs.webkit.org/show_bug.cgi?id=180526
353
354         Reviewed by Darin Adler.
355
356         Add tests involving leading and trailing whitespace, non-token
357         characters and quoted strings.
358
359         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
360         (TestWebKitAPI::TEST):
361
362 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
363
364         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
365         https://bugs.webkit.org/show_bug.cgi?id=194884
366
367         Reviewed by Michael Catanzaro.
368
369         * PlatformWin.cmake:
370
371 2019-02-20  Chris Dumez  <cdumez@apple.com>
372
373         Add API test for <rdar://problem/47471222>
374         https://bugs.webkit.org/show_bug.cgi?id=194847
375
376         Reviewed by Alex Christensen.
377
378         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
379
380 2019-02-20  Chris Dumez  <cdumez@apple.com>
381
382         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
383         https://bugs.webkit.org/show_bug.cgi?id=194872
384         <rdar://problem/47924500>
385
386         Reviewed by Alex Christensen.
387
388         Add API test coverage.
389
390         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
391
392 2019-02-20  Jer Noble  <jer.noble@apple.com>
393
394         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
395         https://bugs.webkit.org/show_bug.cgi?id=191332
396
397         Reviewed by Dean Jackson.
398
399         * Scripts/git-is-in-range: Added.
400
401 2019-02-20  Andy Estes  <aestes@apple.com>
402
403         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
404         https://bugs.webkit.org/show_bug.cgi?id=194869
405
406         Rubber-stamped by Jer Noble.
407
408         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
409         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
410         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
411         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
413         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
414
415 2019-02-20  Chris Dumez  <cdumez@apple.com>
416
417         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
418         https://bugs.webkit.org/show_bug.cgi?id=194857
419         <rdar://problem/47759323>
420
421         Reviewed by Alex Christensen.
422
423         Add API test coverage.
424
425         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
426
427 2019-02-20  Chris Dumez  <cdumez@apple.com>
428
429         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
430         https://bugs.webkit.org/show_bug.cgi?id=194829
431         <rdar://problem/47889906>
432
433         Reviewed by Alexey Proskuryakov.
434
435         Every time the TestOptions were changing we were creating both a new Web view and
436         a new WKContext, which would start a new Network process. In most cases, we only
437         need to contruct a new Web view and we do can keep reusing the same WKContext.
438         This patch implements this optimization and thus avoids spinning a lot of new
439         Network processes while running the layout tests.
440
441         * WebKitTestRunner/TestController.cpp:
442         (WTR::TestController::generateContextConfiguration const):
443         (WTR::TestController::generatePageConfiguration):
444         (WTR::TestController::createWebViewWithOptions):
445         (WTR::TestController::resetPreferencesToConsistentValues):
446         (WTR::updateTestOptionsFromTestHeader):
447         * WebKitTestRunner/TestController.h:
448         * WebKitTestRunner/TestOptions.h:
449         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
450         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
451         (WTR::TestOptions::hasSameInitializationOptions const):
452         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
453         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
454         (WTR::TestController::platformAddTestOptions const):
455
456 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
457
458         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
459         https://bugs.webkit.org/show_bug.cgi?id=167941
460
461         Reviewed by Carlos Garcia Campos.
462
463         * MiniBrowser/gtk/main.c:
464         (filterSavedCallback): Added.
465         (main): Support loading a JSON rule set file for content filtering.
466         * MiniBrowser/wpe/main.cpp:
467         (filterSavedCallback): Added.
468         (main): Support loading a JSON rule set file for content filtering.
469         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
470         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
471         (WTF::derefGPtr): Ditto.
472         (testEmptyStore):
473         (testSaveInvalidFilter):
474         (testSaveLoadFilter):
475         (testSavedFilterIdentifierMatch):
476         (testRemoveFilter):
477         (testSaveMultipleFilters):
478         (testSaveFilterFromFile):
479         (testFilterPersistence):
480         (beforeAll):
481         (afterAll):
482         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
483         (removeOldInjectedContentAndResetLists): Also reset content filters.
484         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
485         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
486         the element affected by the style sheet.
487         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
488         and returns it to be used by tests.
489         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
490         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
491         (serverCallback): Add support for serving a CSS style sheet for testing.
492         (beforeAll): Add call to testUserContentManagerContentFilter().
493         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
494
495 2019-02-19  Keith Rollin  <krollin@apple.com>
496
497         Add timing information to build output
498         https://bugs.webkit.org/show_bug.cgi?id=194839
499         <rdar://problem/48219609>
500
501         Reviewed by Alexey Proskuryakov.
502
503         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
504         emit each project's build time to its output. E.g.,
505
506             ** BUILD SUCCEEDED ** [0.132 sec]
507
508         * Scripts/webkitdirs.pm:
509         (XcodeOptions):
510
511 2019-02-19  Truitt Savell  <tsavell@apple.com>
512
513         Unreviewed, rolling out r241784.
514
515         Broke all OpenSource builds.
516
517         Reverted changeset:
518
519         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
520         instances view"
521         https://bugs.webkit.org/show_bug.cgi?id=172848
522         https://trac.webkit.org/changeset/241784
523
524 2019-02-19  Zalan Bujtas  <zalan@apple.com>
525
526         [LFC][Floats] Remove redundant intersecting logic
527         https://bugs.webkit.org/show_bug.cgi?id=194804
528
529         Reviewed by Antti Koivisto.
530
531         * LayoutReloaded/misc/LFC-passing-tests.txt:
532
533 2019-02-19  Dean Jackson  <dino@apple.com>
534
535         Clean-up output from generate-xcfilelists so it can be filtered
536         https://bugs.webkit.org/show_bug.cgi?id=194795
537
538         Reviewed by Joseph Pecoraro (and Keith Rollin).
539
540         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
541         make a slight tweak to filter-build-webkit so such lines are marked
542         as plain.
543
544         * Scripts/filter-build-webkit:
545         * Scripts/generate-xcfilelists:
546
547 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
548
549         pytest is not correctly auto-installed
550         https://bugs.webkit.org/show_bug.cgi?id=194707
551
552         Reviewed by Carlos Garcia Campos.
553
554         * Scripts/webkitpy/thirdparty/__init__.py:
555         (AutoinstallImportHook._install_pytest):
556
557 2019-02-18  Chris Dumez  <cdumez@apple.com>
558
559         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
560         https://bugs.webkit.org/show_bug.cgi?id=194797
561         <rdar://problem/48055151>
562
563         Reviewed by Geoffrey Garen.
564
565         Add API test coverage.
566
567         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
568
569 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
570
571         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
572         https://bugs.webkit.org/show_bug.cgi?id=194670
573         <rdar://problem/39066529>
574
575         Reviewed by Tim Horton.
576
577         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
578         pasted in an editable area as attachment elements.
579
580         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
581         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
582         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
583         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
584         (TestWebKitAPI::TEST):
585         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
586         (WTR::InjectedBundlePage::InjectedBundlePage):
587
588 2019-02-18  Alex Christensen  <achristensen@webkit.org>
589
590         Fix API test after r241728
591        ​https://bugs.webkit.org/show_bug.cgi?id=194723
592
593         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
594         (TEST):
595         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
596
597 2019-02-18  Daniel Bates  <dabates@apple.com>
598
599         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
600         https://bugs.webkit.org/show_bug.cgi?id=192824
601         <rdar://problem/47100332>
602
603         Reviewed by Wenson Hsieh.
604
605         Fix a bug where the wrong usage code was used for F13 thru F24.
606
607         * WebKitTestRunner/ios/HIDEventGenerator.mm:
608         (keyCodeForDOMFunctionKey):
609
610 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
611
612         Bytecode cache should a have a boot-specific validation
613         https://bugs.webkit.org/show_bug.cgi?id=194769
614         <rdar://problem/48149509>
615
616         Reviewed by Keith Miller.
617
618         Add test for WTF::bootSessionUUIDString()
619
620         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
621         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
622         (TEST):
623
624 2019-02-18  Alex Christensen  <achristensen@webkit.org>
625
626         Disable safe browsing in WKWebView and remove its WKPreferences API
627         https://bugs.webkit.org/show_bug.cgi?id=194723
628         <rdar://problem/48122993>
629
630         Reviewed by Geoffrey Garen.
631
632         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
633         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
634         (TEST):
635         (safeBrowsingView):
636         Make tests use SPI instead of API.
637
638 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
639
640         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
641         https://bugs.webkit.org/show_bug.cgi?id=194586
642
643         Reviewed by Ross Kirsling.
644
645         * DumpRenderTree/win/DumpRenderTree.cpp:
646         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
647         * Scripts/webkitpy/port/driver.py:
648         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
649
650 2019-02-17  David Kilzer  <ddkilzer@apple.com>
651
652         Unreviewed, rolling out r241620.
653
654         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
655         (Requested by ddkilzer on #webkit.)
656
657         Reverted changeset:
658
659         "[WTF] Add environment variable helpers"
660         https://bugs.webkit.org/show_bug.cgi?id=192405
661         https://trac.webkit.org/changeset/241620
662
663 2019-02-16  Zalan Bujtas  <zalan@apple.com>
664
665         [LFC] RenderImage's default intrinsic size is 0.
666         https://bugs.webkit.org/show_bug.cgi?id=194745
667
668         Reviewed by Antti Koivisto.
669
670         * LayoutReloaded/misc/LFC-passing-tests.txt:
671
672 2019-02-16  Zalan Bujtas  <zalan@apple.com>
673
674         [LFC][BFC] Add support for block replaced intrinsic width.
675         https://bugs.webkit.org/show_bug.cgi?id=194705
676
677         Reviewed by Simon Fraser.
678
679         * LayoutReloaded/misc/LFC-passing-tests.txt:
680
681 2019-02-16  Zalan Bujtas  <zalan@apple.com>
682
683         [LFC] Apply min/max width constraints to preferred width computation
684         https://bugs.webkit.org/show_bug.cgi?id=194739
685
686         Reviewed by Simon Fraser.
687
688         * LayoutReloaded/misc/LFC-passing-tests.txt:
689
690 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
691
692         [WTF] Add environment variable helpers
693         https://bugs.webkit.org/show_bug.cgi?id=192405
694
695         Reviewed by Michael Catanzaro.
696
697         * DumpRenderTree/mac/DumpRenderTree.mm:
698         (libraryPathForDumpRenderTree):
699         * DumpRenderTree/win/DumpRenderTree.cpp:
700         (libraryPathForDumpRenderTree):
701         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
702         (setUpIOSLayoutTestCommunication):
703         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
704         (beforeAll):
705         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
706         (main):
707         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
708         (WebKitTestBus::run):
709         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
710         (WTR::getOutputDir):
711         (WTR::initializeFontConfigSetting):
712         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
713         (WTR::InjectedBundle::platformInitialize):
714         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
715         (WTR::topLevelPath):
716         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
717         (WTR::topLevelPath):
718         (WTR::getOutputDir):
719         (WTR::activateFonts):
720         * WebKitTestRunner/TestController.cpp:
721         (WTR::TestController::libraryPathForTesting):
722         (WTR::TestController::generateContextConfiguration const):
723         (WTR::TestController::generatePageConfiguration):
724         (WTR::TestController::decideDestinationWithSuggestedFilename):
725         (WTR::TestController::platformAdjustContext):
726         * WebKitTestRunner/TestController.h:
727         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
728         (WTR::TestController::cocoaPlatformInitialize):
729         (WTR::TestController::platformAdjustContext):
730         * WebKitTestRunner/gtk/main.cpp:
731         (main):
732         * WebKitTestRunner/mac/TestControllerMac.mm:
733         (WTR::TestController::configureContentExtensionForTest):
734         * WebKitTestRunner/wpe/main.cpp:
735         (main):
736         Utilize WTF::Environment where possible.
737
738 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
739
740         [iOS] WKWebView callout bar is missing Change Writing Direction item
741         https://bugs.webkit.org/show_bug.cgi?id=190015
742         <rdar://problem/44810366>
743
744         Reviewed by Tim Horton.
745
746         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
747         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
748
749         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
750         (TestWebKitAPI::TEST):
751
752 2019-02-15  Chris Dumez  <cdumez@apple.com>
753
754         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
755         https://bugs.webkit.org/show_bug.cgi?id=194717
756         <rdar://problem/47884404>
757
758         Reviewed by Brady Eidson.
759
760         Add API test coverage.
761
762         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
763
764 2019-02-15  Youenn Fablet  <youenn@apple.com>
765
766         Make navigator.mediaDevices SecureContext
767         https://bugs.webkit.org/show_bug.cgi?id=194666
768
769         Reviewed by Eric Carlson.
770
771         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
772         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
773         (TEST_F):
774
775 2019-02-15  Brian Burg  <bburg@apple.com>
776
777         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
778         https://bugs.webkit.org/show_bug.cgi?id=194411
779         <rdar://problem/47787614>
780
781         Reviewed by Joseph Pecoraro.
782
783         Remove unnecessary soft linking macro usage.
784
785         * DumpRenderTree/mac/TestRunnerMac.mm:
786         (TestRunner::inspectorTestStubURL):
787         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
788         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
789         (WTR::TestRunner::inspectorTestStubURL):
790
791 2019-02-15  Commit Queue  <commit-queue@webkit.org>
792
793         Unreviewed, rolling out r241559 and r241566.
794         https://bugs.webkit.org/show_bug.cgi?id=194710
795
796         Causes layout test crashes under GuardMalloc (Requested by
797         ryanhaddad on #webkit).
798
799         Reverted changesets:
800
801         "[WTF] Add environment variable helpers"
802         https://bugs.webkit.org/show_bug.cgi?id=192405
803         https://trac.webkit.org/changeset/241559
804
805         "Unreviewed build fix for WinCairo Debug after r241559."
806         https://trac.webkit.org/changeset/241566
807
808 2019-02-15  Zalan Bujtas  <zalan@apple.com>
809
810         [LFC] Out-of-flow box is never a float box
811         https://bugs.webkit.org/show_bug.cgi?id=194704
812
813         Reviewed by Antti Koivisto.
814
815         * LayoutReloaded/misc/LFC-passing-tests.txt:
816
817 2019-02-10  Darin Adler  <darin@apple.com>
818
819         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
820         https://bugs.webkit.org/show_bug.cgi?id=194487
821
822         Reviewed by Daniel Bates.
823
824         * DumpRenderTree/win/DumpRenderTree.cpp:
825         (applicationId): Use makeString instead of String::format.
826         (main): Ditto.
827         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
828         (TestWebKitAPI::Util::createURLForResource): Ditto.
829         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
830         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
831
832         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
833         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
834         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
835         (WTR::createStringWithAttributes): Use appendLiteral.
836         (WTR::AccessibilityUIElement::helpText const): Ditto.
837         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
838         directly instead of using String::format.
839         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
840         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
841
842 2019-02-15  Truitt Savell  <tsavell@apple.com>
843
844         Unreviewed, rolling out r241564.
845
846         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
847
848         Reverted changeset:
849
850         "[Mac] WebInspectorUI.framework does not need to be soft-
851         linked anymore"
852         https://bugs.webkit.org/show_bug.cgi?id=194411
853         https://trac.webkit.org/changeset/241564
854
855 2019-02-15  Saam barati  <sbarati@apple.com>
856
857         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
858         https://bugs.webkit.org/show_bug.cgi?id=194036
859
860         Reviewed by Yusuke Suzuki.
861
862         * Scripts/run-jsc-stress-tests:
863
864 2019-02-14  Tim Horton  <timothy_horton@apple.com>
865
866         Fix the build.
867
868         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
869         (WTR::UIScriptController::drawSquareInEditableImage):
870         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
871         (TestWebKitAPI::drawSquareInEditableImage):
872
873 2019-02-14  Tim Horton  <timothy_horton@apple.com>
874
875         Fix the build.
876
877         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
878         (WTR::UIScriptController::drawSquareInEditableImage):
879         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
880         (TestWebKitAPI::drawSquareInEditableImage):
881
882 2019-02-14  Brian Burg  <bburg@apple.com>
883
884         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
885         https://bugs.webkit.org/show_bug.cgi?id=194411
886         <rdar://problem/47787614>
887
888         Reviewed by Joseph Pecoraro.
889
890         Remove unnecessary soft linking macro usage.
891
892         * DumpRenderTree/mac/TestRunnerMac.mm:
893         (TestRunner::inspectorTestStubURL):
894         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
895         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
896         (WTR::TestRunner::inspectorTestStubURL):
897
898 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
899
900         [ews-app] status bubble should fetch builder name info from BuilderMapping table
901         https://bugs.webkit.org/show_bug.cgi?id=194599
902
903         Reviewed by Lucas Forschler.
904
905         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
906         (StatusBubble._build_bubble):
907
908 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
909
910         [ews-app] Set Foreign Key in Django build model
911         https://bugs.webkit.org/show_bug.cgi?id=194667
912
913         Reviewed by Lucas Forschler.
914
915         * BuildSlaveSupport/ews-app/ews/models/build.py:
916         (Build):
917
918 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
919
920         [WTF] Add environment variable helpers
921         https://bugs.webkit.org/show_bug.cgi?id=192405
922
923         Reviewed by Michael Catanzaro.
924
925         * DumpRenderTree/mac/DumpRenderTree.mm:
926         (libraryPathForDumpRenderTree):
927         * DumpRenderTree/win/DumpRenderTree.cpp:
928         (libraryPathForDumpRenderTree):
929         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
930         (setUpIOSLayoutTestCommunication):
931         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
932         (TestWebKitAPI::strip):
933         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
934         (beforeAll):
935         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
936         (main):
937         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
938         (WebKitTestBus::run):
939         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
940         (WTR::getOutputDir):
941         (WTR::initializeFontConfigSetting):
942         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
943         (WTR::InjectedBundle::platformInitialize):
944         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
945         (WTR::topLevelPath):
946         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
947         (WTR::topLevelPath):
948         (WTR::getOutputDir):
949         (WTR::activateFonts):
950         * WebKitTestRunner/TestController.cpp:
951         (WTR::TestController::libraryPathForTesting):
952         (WTR::TestController::generateContextConfiguration const):
953         (WTR::TestController::generatePageConfiguration):
954         (WTR::TestController::decideDestinationWithSuggestedFilename):
955         (WTR::TestController::platformAdjustContext):
956         * WebKitTestRunner/TestController.h:
957         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
958         (WTR::TestController::cocoaPlatformInitialize):
959         (WTR::TestController::platformAdjustContext):
960         * WebKitTestRunner/gtk/main.cpp:
961         (main):
962         * WebKitTestRunner/mac/TestControllerMac.mm:
963         (WTR::TestController::configureContentExtensionForTest):
964         * WebKitTestRunner/wpe/main.cpp:
965         (main):
966         Utilize WTF::Environment where possible.
967
968 2019-02-14  Chris Dumez  <cdumez@apple.com>
969
970         [PSON] Introduce a WebContent Process cache
971         https://bugs.webkit.org/show_bug.cgi?id=194594
972         <rdar://problem/46793397>
973
974         Reviewed by Geoff Garen.
975
976         Update API tests to turn on the WebContent Process cache.
977
978         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
979
980 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
981
982         Unreviewed, build fix after r241480
983
984         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
985         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
986         (-[DragAndDropSimulator initWithWebView:]):
987
988 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
989
990         AX: ARIA Reflection was disabled in error
991         https://bugs.webkit.org/show_bug.cgi?id=194647
992         <rdar://problem/48068336>
993
994         Reviewed by Ryosuke Niwa.
995
996         Remove test override now that this feature should be enabled by default.
997
998         * WebKitTestRunner/TestController.cpp:
999         (WTR::TestController::resetPreferencesToConsistentValues):
1000
1001 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1002
1003         Unreviewed, rolling out r241486.
1004         https://bugs.webkit.org/show_bug.cgi?id=194655
1005
1006         causing API failures in builds (Requested by ShawnRoberts on
1007         #webkit).
1008
1009         Reverted changeset:
1010
1011         "[Cocoa] Media elements will restart network buffering just
1012         before suspending"
1013         https://bugs.webkit.org/show_bug.cgi?id=193691
1014         https://trac.webkit.org/changeset/241486
1015
1016 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1017
1018         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1019         https://bugs.webkit.org/show_bug.cgi?id=194622
1020
1021         Reviewed by Antti Koivisto.
1022
1023         * LayoutReloaded/misc/LFC-passing-tests.txt:
1024
1025 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1026
1027         [LFC] Shrink-to-fit-width should be constrained by min/max width
1028         https://bugs.webkit.org/show_bug.cgi?id=194653
1029
1030         Reviewed by Antti Koivisto.
1031
1032         * LayoutReloaded/misc/LFC-passing-tests.txt:
1033
1034 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1035
1036         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1037         https://bugs.webkit.org/show_bug.cgi?id=194641
1038
1039         Reviewed by Geoffrey Garen.
1040
1041         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1042         so that the test would fail without this fix.
1043
1044         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1045         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1046
1047 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1048
1049         [ews-app] Change log level for a log statement
1050
1051         Unreviewed minor fix.
1052
1053         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1054         (Patch.save_patch):
1055
1056 2019-02-13  Jer Noble  <jer.noble@apple.com>
1057
1058         [Cocoa] Media elements will restart network buffering just before suspending
1059         https://bugs.webkit.org/show_bug.cgi?id=193691
1060
1061         Reviewed by Eric Carlson.
1062
1063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1064         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1065         (TEST):
1066
1067 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1068
1069         [ews-app] Fetch builder id to name mapping
1070         https://bugs.webkit.org/show_bug.cgi?id=194355
1071
1072         Reviewed by Lucas Forschler.
1073
1074         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1075         (Buildbot.get_builder_id_to_name_mapping):
1076         (Buildbot._get_display_name_from_builder_name):
1077
1078 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1079
1080         Further restricting webarchive loads
1081         https://bugs.webkit.org/show_bug.cgi?id=194567
1082         <rdar://problem/47610130>
1083
1084         Reviewed by Youenn Fablet.
1085
1086         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1087         navigations on drop.
1088
1089         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1090         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1091         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1092         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1093         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1094         (TestWebKitAPI::TEST):
1095         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1096         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1097         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1098         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1099         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1100         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1101         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1102
1103 2019-02-13  John Wilander  <wilander@apple.com>
1104
1105         Store Ad Click Attribution requests in the network process
1106         https://bugs.webkit.org/show_bug.cgi?id=194510
1107         <rdar://problem/47650118>
1108
1109         Reviewed by Alex Christensen and Daniel Bates.
1110
1111         This patch adds two TestRunner functions:
1112         - dumpAdClickAttribution()
1113         - clearAdClickAttribution()
1114
1115         They call into the network process to dump and clear Ad Click
1116         Attribution state, respectively.
1117
1118         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1119         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1120         (WTR::TestRunner::dumpAdClickAttribution):
1121         (WTR::TestRunner::clearAdClickAttribution):
1122         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1123         * WebKitTestRunner/TestController.cpp:
1124         (WTR::TestController::resetStateToConsistentValues):
1125         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1126         (WTR::adClickAttributionStringResultCallback):
1127         (WTR::TestController::dumpAdClickAttribution):
1128         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1129         (WTR::adClickAttributionVoidCallback):
1130         (WTR::TestController::clearAdClickAttribution):
1131         * WebKitTestRunner/TestController.h:
1132         * WebKitTestRunner/TestInvocation.cpp:
1133         (WTR::TestInvocation::dumpResults):
1134         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1135         (WTR::TestInvocation::dumpAdClickAttribution):
1136         * WebKitTestRunner/TestInvocation.h:
1137
1138 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1139
1140         [ews-app] Generate status-bubble
1141         https://bugs.webkit.org/show_bug.cgi?id=194572
1142
1143         Reviewed by Lucas Forschler.
1144
1145         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1146         (StatusBubble._build_bubble):
1147         (StatusBubble._should_show_bubble_for):
1148         (StatusBubble._build_bubbles_for_patch):
1149
1150 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1151
1152         [ews-app] Add status bubble html template
1153         https://bugs.webkit.org/show_bug.cgi?id=194571
1154
1155         Reviewed by Lucas Forschler.
1156
1157         * BuildSlaveSupport/ews-app/ews/templates: Added.
1158         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1159
1160 2019-02-12  Chris Dumez  <cdumez@apple.com>
1161
1162         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1163         https://bugs.webkit.org/show_bug.cgi?id=194568
1164         <rdar://problem/47944490>
1165
1166         Reviewed by Ryosuke Niwa.
1167
1168         Add API test coverage.
1169
1170         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1171         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1172
1173 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1174
1175         webkitpy: Remove bug_dummy from parsed test expectations
1176         https://bugs.webkit.org/show_bug.cgi?id=194562
1177         <rdar://problem/47853999>
1178
1179         Reviewed by Lucas Forschler.
1180
1181         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1182         (TestExpectationParser):
1183         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1184         skipped tests.
1185         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1186
1187 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1188
1189         [ews-app] Add method to fetch patch
1190         https://bugs.webkit.org/show_bug.cgi?id=194518
1191
1192         Reviewed by Lucas Forschler.
1193
1194         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1195         (Patch.get_patch):
1196
1197 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1198
1199         [LFC] Expand tests coverage (60 new tests -> 860)
1200
1201         Unreviewed test gardening (run-singly, --child-processes=1).
1202
1203         * LayoutReloaded/misc/LFC-passing-tests.txt:
1204
1205 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1206
1207         Allow pages to trigger programmatic paste from script on iOS
1208         https://bugs.webkit.org/show_bug.cgi?id=194271
1209         <rdar://problem/47808810>
1210
1211         Reviewed by Tim Horton.
1212
1213         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1214
1215         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1216         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1217         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1218         (WTR::UIScriptController::rectForMenuAction const):
1219
1220         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1221         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1222         for when the menu is shown or hidden.
1223
1224         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1225         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1226         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1227         (WTR::UIScriptController::setDidShowMenuCallback):
1228         (WTR::UIScriptController::didShowMenuCallback const):
1229         (WTR::UIScriptController::setDidHideMenuCallback):
1230         (WTR::UIScriptController::didHideMenuCallback const):
1231         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1232         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1233         (WTR::UIScriptController::rectForMenuAction const):
1234         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1235         * WebKitTestRunner/TestController.cpp:
1236         (WTR::TestController::resetPreferencesToConsistentValues):
1237         (WTR::updateTestOptionsFromTestHeader):
1238         * WebKitTestRunner/TestOptions.h:
1239
1240         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1241         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1242
1243         (WTR::TestOptions::hasSameInitializationOptions const):
1244         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1245         (WTR::UIScriptController::calendarType const):
1246         (WTR::UIScriptController::platformUndoManager const):
1247         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1248         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1249         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1250         (-[TestRunnerWKWebView dealloc]):
1251         (-[TestRunnerWKWebView _didShowMenu]):
1252         (-[TestRunnerWKWebView _didHideMenu]):
1253
1254         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1255
1256         * WebKitTestRunner/ios/TestControllerIOS.mm:
1257         (WTR::handleMenuWillHideNotification):
1258         (WTR::handleMenuDidHideNotification):
1259         (WTR::TestController::platformInitialize):
1260         (WTR::TestController::platformDestroy):
1261         (WTR::TestController::platformResetStateToConsistentValues):
1262
1263         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1264         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1265
1266         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1267         (WTR::forEachViewInHierarchy):
1268         (WTR::findViewInHierarchyOfType):
1269
1270         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1271         functions that dig through a given view's hierarchy in search of a view of a given class.
1272
1273         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1274         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1275         (WTR::UIScriptController::selectionCaretViewRect const):
1276         (WTR::UIScriptController::selectionRangeViewRects const):
1277         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1278         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1279
1280         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1281
1282         (WTR::UIScriptController::rectForMenuAction const):
1283
1284         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1285         callout bar) whose label matches the given string.
1286
1287         (WTR::UIScriptController::platformContentView const):
1288
1289         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1290         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1291         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1292
1293         (WTR::UIScriptController::platformUndoManager const): Deleted.
1294         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1295         (WTR::UIScriptController::platformContentView const):
1296         (WTR::UIScriptController::platformUndoManager const): Deleted.
1297
1298 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1299
1300         webkitpy: No option to only show unexpected failures in results.html for iPad
1301         https://bugs.webkit.org/show_bug.cgi?id=194554
1302         <rdar://problem/47922442>
1303
1304         Rubber-stamped by Aakash Jain.
1305
1306         Just because a TestExpecations file does not exist for a specific platform does not mean that
1307         TestExpecations are not being used, given that platforms inherit test expectations.
1308
1309         * Scripts/webkitpy/port/base.py:
1310         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1311         * Scripts/webkitpy/port/base_unittest.py:
1312         (PortTest.test_uses_test_expectations_file):
1313
1314 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1315
1316         Remove setDefersLoading infrastructure from WebKit2
1317         https://bugs.webkit.org/show_bug.cgi?id=194506
1318
1319         Reviewed by Brady Eidson.
1320
1321         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1322         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1323         (WTR::TestRunner::setDefersLoading): Deleted.
1324         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1325
1326 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1327
1328         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1329         https://bugs.webkit.org/show_bug.cgi?id=194522
1330         <rdar://problem/47789393>
1331
1332         Reviewed by Chris Dumez.
1333
1334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1335         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1336         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1337         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1338
1339 2019-02-12  Andy Estes  <aestes@apple.com>
1340
1341         [iOSMac] Enable Parental Controls Content Filtering
1342         https://bugs.webkit.org/show_bug.cgi?id=194521
1343         <rdar://39732376>
1344
1345         Reviewed by Tim Horton.
1346
1347         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1348
1349 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1350
1351         [LFC][IFC] Add intrinsic width support for float boxes.
1352         https://bugs.webkit.org/show_bug.cgi?id=194528
1353
1354         Reviewed by Antti Koivisto.
1355
1356         Expand tests coverage (2 new tests -> 800).
1357         (This is the correct test ordering --runs-singly --child-processes=1)
1358
1359         * LayoutReloaded/misc/LFC-passing-tests.txt:
1360
1361 2019-02-12  Rob Buis  <rbuis@igalia.com>
1362
1363         Implement serializing in MIME type parser
1364         https://bugs.webkit.org/show_bug.cgi?id=193909
1365
1366         Reviewed by Darin Adler.
1367
1368         Add various tests involving upper case, non-ASCII, control/null characters,
1369         various HTTP whitespace, single quotes and an unpaired surrogate.
1370
1371         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1372         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1373         (TestWebKitAPI::serializeIfValid):
1374         (TestWebKitAPI::TEST):
1375
1376 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1377
1378         [Cocoa] Ask platform for generic font family mappings
1379         https://bugs.webkit.org/show_bug.cgi?id=187723
1380         <rdar://problem/41892438>
1381
1382         Reviewed by Brent Fulgham.
1383
1384         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1385
1386         * DumpRenderTree/mac/DumpRenderTree.mm:
1387         (allowedFontFamilySet):
1388         * WebKitTestRunner/mac/TestControllerMac.mm:
1389         (WTR::allowedFontFamilySet):
1390
1391 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1392
1393         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1394         https://bugs.webkit.org/show_bug.cgi?id=193622
1395
1396         Reviewed by Michael Catanzaro.
1397
1398         This adds support for loading content extension rule sets from the JSON files which
1399         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1400         of WKTR for this could be removed, but that is left for a follow-up patch with
1401         cleanups.
1402
1403         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1404         * WebKitTestRunner/TestController.cpp:
1405         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1406         avoid having the null-terminator copied into the result.
1407         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1408         part of the preparations to run a test.
1409         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1410         (WTR::contentExtensionStoreCallback): Added.
1411         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1412         used for content extensions test.
1413         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1414         extensions and compiling the JSON rule set for tests involving content extensions.
1415         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1416         testing and disables content extensions.
1417         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1418         resetContentExtensions().
1419         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1420         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1421         configureContentExtensionForTest(), and userContentController().
1422
1423 2019-02-11  Daniel Bates  <dabates@apple.com>
1424
1425         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1426         https://bugs.webkit.org/show_bug.cgi?id=191446
1427         <rdar://problem/45929460>
1428
1429         Reviewed by Tim Horton.
1430
1431         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1432
1433         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1434         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1435         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1436         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1437         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1438         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1439         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1440         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1441         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1442         (WTR::arrayLength):
1443         (WTR::parseModifierArray):
1444         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1445         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1446         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1447         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1448
1449 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1450
1451         Unreviewed, rolling out r241272 and r241276.
1452         https://bugs.webkit.org/show_bug.cgi?id=194514
1453
1454         Broke the Apple Internal build and the fix requires human
1455         intervention :( (Requested by dydz on #webkit).
1456
1457         Reverted changesets:
1458
1459         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1460         https://bugs.webkit.org/show_bug.cgi?id=191446
1461         https://trac.webkit.org/changeset/241272
1462
1463         "Fix internal iOS build after r241272"
1464         https://bugs.webkit.org/show_bug.cgi?id=191446
1465         https://trac.webkit.org/changeset/241276
1466
1467 2019-02-11  Truitt Savell  <tsavell@apple.com>
1468
1469         Unreviewed, rolling out r241269.
1470
1471         Caused 5 layout tests crashes on Mac WK1
1472
1473         Reverted changeset:
1474
1475         "DumpRenderTree should report unknown options"
1476         https://bugs.webkit.org/show_bug.cgi?id=191303
1477         https://trac.webkit.org/changeset/241269
1478
1479 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1480
1481         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1482         https://bugs.webkit.org/show_bug.cgi?id=194313
1483
1484         Reviewed by Tim Horton.
1485
1486         Add a helper to determine whether the web view is presenting modal UI.
1487
1488         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1489         (WTR::UIScriptController::isPresentingModally const):
1490         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1491         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1492         (WTR::UIScriptController::isPresentingModally const):
1493         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1494         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1495         (WTR::UIScriptController::calendarType const): Deleted.
1496         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1497         (WTR::UIScriptController::isPresentingModally const):
1498         (WTR::UIScriptController::calendarType const):
1499         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1500         (WTR::UIScriptController::calendarType const):
1501
1502 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1503
1504         GCHeapInspector: Show the retained sizes in more places
1505         https://bugs.webkit.org/show_bug.cgi?id=194464
1506
1507         Reviewed by Simon Fraser.
1508
1509         * GCHeapInspector/gc-heap-inspector.html:
1510         * GCHeapInspector/script/interface.js:
1511         (HeapInspectorUtils.humanReadableSize):
1512         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1513         (HeapInspectorUtils.spanForNode.span.span):
1514         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1515         (HeapSnapshotInspector.prototype.buildRoots):
1516
1517 2019-02-11  Daniel Bates  <dabates@apple.com>
1518
1519         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1520         https://bugs.webkit.org/show_bug.cgi?id=191446
1521         <rdar://problem/45929460>
1522
1523         Reviewed by Tim Horton.
1524
1525         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1526
1527         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1528         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1529         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1530         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1531         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1532         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1533         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1534         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1535         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1536         (WTR::arrayLength):
1537         (WTR::parseModifierArray):
1538         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1539         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1540         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1541         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1542
1543 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1544
1545         DumpRenderTree should report unknown options
1546         https://bugs.webkit.org/show_bug.cgi?id=191303
1547
1548         Reviewed by Frédéric Wang.
1549
1550         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1551         to report unknown options.
1552         Added and assigned test options which are currently used in tests.
1553
1554         * DumpRenderTree/TestOptions.cpp:
1555         (TestOptions::TestOptions):
1556
1557 2019-02-11  Truitt Savell  <tsavell@apple.com>
1558
1559         Unreviewed, rolling out r241229.
1560
1561         Revision broke internal builds for watchOS.
1562
1563         Reverted changeset:
1564
1565         "[Cocoa] Ask platform for generic font family mappings"
1566         https://bugs.webkit.org/show_bug.cgi?id=187723
1567         https://trac.webkit.org/changeset/241229
1568
1569 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1570
1571         [WinCairo][MiniBrowser] Basic authentication always fails.
1572         https://bugs.webkit.org/show_bug.cgi?id=194496
1573
1574         Reviewed by Don Olmstead.
1575
1576         * MiniBrowser/win/DialogHelper.h:
1577         (Dialog::getText):
1578
1579 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1580
1581         [GStreamer] GstMappedBuffer testsuite build fails
1582         https://bugs.webkit.org/show_bug.cgi?id=194495
1583
1584         Reviewed by Carlos Garcia Campos.
1585
1586         Fix the build by explicitely adding the gstreamer1.0-audio include
1587         directories to the include path.
1588
1589         * TestWebKitAPI/PlatformGTK.cmake:
1590         * TestWebKitAPI/PlatformWPE.cmake:
1591
1592 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1593
1594         [GTK][WPE] Add enable-javascript-markup setting
1595         https://bugs.webkit.org/show_bug.cgi?id=193439
1596
1597         Reviewed by Michael Catanzaro.
1598
1599         Add test cases to check the new setting.
1600
1601         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1602         (testWebKitSettings):
1603         (testWebKitSettingsJavaScriptMarkup):
1604         (beforeAll):
1605
1606 2019-02-10  Darin Adler  <darin@apple.com>
1607
1608         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1609         https://bugs.webkit.org/show_bug.cgi?id=194485
1610
1611         Reviewed by Daniel Bates.
1612
1613         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1614
1615 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1616
1617         Add more tests for clampTo<>()
1618         https://bugs.webkit.org/show_bug.cgi?id=194462
1619
1620         Reviewed by Geoffrey Garen.
1621
1622         Darin suggested to test the very last floating point number
1623         at the boundaries when truncating to integer.
1624         I added test for max/min and max-1/min-1.
1625
1626         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1627         (TestWebKitAPI::TEST):
1628
1629 2019-02-09  Darin Adler  <darin@apple.com>
1630
1631         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1632         https://bugs.webkit.org/show_bug.cgi?id=194021
1633
1634         Reviewed by Geoffrey Garen.
1635
1636         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1637         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1638         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1639
1640 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1641
1642         [LFC][IFC] Add intrinsic width support for basic inline containers
1643         https://bugs.webkit.org/show_bug.cgi?id=194473
1644
1645         Reviewed by Antti Koivisto.
1646
1647         Expand tests coverage (11 new tests -> 798)
1648
1649         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1650
1651 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1652
1653         Fix MiniBrowser's entitlements
1654         https://bugs.webkit.org/show_bug.cgi?id=192431
1655
1656         Reviewed by Joseph Pecoraro.
1657
1658         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1659         files, making it impossible to load any extension.
1660
1661         * MiniBrowser/MiniBrowser.entitlements:
1662
1663 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1664
1665         [Cocoa] Ask platform for generic font family mappings
1666         https://bugs.webkit.org/show_bug.cgi?id=187723
1667         <rdar://problem/41892438>
1668
1669         Reviewed by Brent Fulgham.
1670
1671         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1672
1673         * DumpRenderTree/mac/DumpRenderTree.mm:
1674         (allowedFontFamilySet):
1675         * WebKitTestRunner/mac/TestControllerMac.mm:
1676         (WTR::allowedFontFamilySet):
1677
1678 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1679
1680         [GTK] Implement back/forward touchpad gesture
1681         https://bugs.webkit.org/show_bug.cgi?id=193919
1682
1683         Reviewed by Michael Catanzaro.
1684
1685         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1686         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1687
1688 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1689
1690         Add SPI to use networking daemon instead of XPC service
1691         https://bugs.webkit.org/show_bug.cgi?id=194427
1692
1693         Reviewed by Geoffrey Garen
1694
1695         * MiniBrowser/MiniBrowser.entitlements:
1696
1697 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1698
1699         [ews-build] Ensure that every builder in config.json has short name
1700         https://bugs.webkit.org/show_bug.cgi?id=194461
1701
1702         Reviewed by Lucas Forschler.
1703
1704         * BuildSlaveSupport/ews-build/loadConfig.py:
1705         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1706
1707 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1708
1709         [ews-build] Add short name to config.json
1710         https://bugs.webkit.org/show_bug.cgi?id=194456
1711
1712         Reviewed by Lucas Forschler.
1713
1714         * BuildSlaveSupport/ews-build/config.json: Added short name.
1715         * BuildSlaveSupport/ews-build/loadConfig.py:
1716         (loadBuilderConfig): Set the short name as the builder description.
1717
1718 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1719
1720         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1721         https://bugs.webkit.org/show_bug.cgi?id=194418
1722
1723         Reviewed by Lucas Forschler.
1724
1725         Do not include errors trying when finding crashlogs at the end of
1726         a run-webkit-tests run since we don't process those errors.
1727
1728         * Scripts/webkitpy/port/darwin.py:
1729         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1730         * Scripts/webkitpy/port/ios_device.py:
1731         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1732         * Scripts/webkitpy/port/watch_device.py:
1733         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1734
1735 2019-02-08  Beth Dakin  <bdakin@apple.com>
1736
1737         Add afterScreenUpdates to WKSnapshotConfiguration
1738         https://bugs.webkit.org/show_bug.cgi?id=194362
1739         -and corresponding-
1740         <rdar://problem/40655528> Please add an "after screen updates" property to 
1741         WKSnapshotConfiguration (to solve blank snapshots)
1742
1743         Reviewed by Tim Horton.
1744
1745         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1746         (TEST):
1747
1748 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1749
1750         clampTo(): do not convert the input to double when dealing with integers
1751         https://bugs.webkit.org/show_bug.cgi?id=194263
1752         <rdar://problem/47692312>
1753
1754         Reviewed by Darin Adler.
1755
1756         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1757         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1758         (TestWebKitAPI::testClampFloatingPointToInteger):
1759         (TestWebKitAPI::testClampSameSignIntegers):
1760         (TestWebKitAPI::testClampUnsignedToSigned):
1761         (TestWebKitAPI::testClampSignedToUnsigned):
1762
1763 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1764
1765         webkitpy: Respect --dedicated-simulators flag
1766         https://bugs.webkit.org/show_bug.cgi?id=194416
1767         <rdar://problem/47894722>
1768
1769         Reviewed by Lucas Forschler.
1770
1771         * Scripts/webkitpy/port/device_port.py:
1772         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1773         available devices can be safely ignored.
1774
1775 2019-02-07  Keith Rollin  <krollin@apple.com>
1776
1777         Remove extra copy of 100x100-red.tga
1778         https://bugs.webkit.org/show_bug.cgi?id=194371
1779         <rdar://problem/47873465>
1780
1781         Reviewed by Said Abou-Hallawa.
1782
1783         In order to help it pass its tests, Bug 194190 added a second copy of
1784         the file 100x100-red.tga. However, it turns out that this additional
1785         file wasn't actually needed, and that that sole previous copy was
1786         sufficient. At the same time, this second copy -- which was copied to
1787         the same location in the build output as the first copy -- now caused
1788         XCBuild to complain because there were two production rules for the
1789         same output file. Address this by removing the newly-added extra copy.
1790
1791         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1792         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1793
1794 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1795
1796         Deprecate WKBundlePageSetDefersLoading
1797         https://bugs.webkit.org/show_bug.cgi?id=191394
1798
1799         Reviewed by Dean Jackson.
1800
1801         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1802         (WTR::TestRunner::setDefersLoading):
1803
1804 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1805
1806         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1807         https://bugs.webkit.org/show_bug.cgi?id=194391
1808
1809         Reviewed by Antti Koivisto.
1810
1811         * LayoutReloaded/misc/LFC-passing-tests.txt:
1812
1813 2019-02-06  Keith Rollin  <krollin@apple.com>
1814
1815         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1816         https://bugs.webkit.org/show_bug.cgi?id=193975
1817         <rdar://problem/47643306>
1818
1819         Reviewed by Tim Horton.
1820
1821         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1822         the Info.plist file into the bundle. This step is not necessary as the
1823         implicit "bundle up all the build products into a framework" build
1824         phase does this already. Having the Copy Bundle Resources phase do
1825         this causes a conflict under XCBuild, which objects to two build
1826         phases producing the same file (Info.plist). Address this by removing
1827         Info.plist from the Copy Bundle Resources phase.
1828
1829         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1830
1831 2019-02-06  Keith Rollin  <krollin@apple.com>
1832
1833         Really enable the automatic checking and regenerations of .xcfilelists during builds
1834         https://bugs.webkit.org/show_bug.cgi?id=194357
1835         <rdar://problem/47861231>
1836
1837         Reviewed by Chris Dumez.
1838
1839         Bug 194124 was supposed to enable the automatic checking and
1840         regenerating of .xcfilelist files during the build. While related
1841         changes were included in that patch, the change to actually enable the
1842         operation somehow was omitted. This patch actually enables the
1843         operation. The check-xcfilelist.sh scripts now check
1844         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1845         from the checking.
1846
1847         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1848         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1849
1850 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1851
1852         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1853         <https://webkit.org/b/194286>
1854         <rdar://problem/47815558>
1855
1856         Reviewed by Alexey Proskuryakov.
1857
1858         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1859         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1860         WKRetainPtr<> to avoid leaking the WKDataRef.
1861
1862 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1863
1864         Unreviewed, fix a typo
1865
1866         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1867
1868 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1869
1870         [GTK][WPE] force libpsl build to use ICU in jhbuild
1871         https://bugs.webkit.org/show_bug.cgi?id=194288
1872
1873         Reviewed by Carlos Garcia Campos.
1874
1875         * gtk/jhbuild.modules:
1876         Require ICU for libpsl build in jhbuild, like done in WPE.
1877
1878 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1879
1880         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1881         https://bugs.webkit.org/show_bug.cgi?id=194209
1882
1883         Reviewed by Carlos Garcia Campos.
1884
1885         Enhance TestCookieManager to ensure this doesn't happen again.
1886
1887         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1888         (testCookieManagerPersistentStorage):
1889         (beforeAll):
1890
1891 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1892
1893         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1894         https://bugs.webkit.org/show_bug.cgi?id=194324
1895
1896         Reviewed by Andy Estes.
1897
1898         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1899         part of the name is already implicit, since this is in testing code in TestOptions.
1900
1901         * WebKitTestRunner/TestController.cpp:
1902         (WTR::TestController::generateContextConfiguration const):
1903         (WTR::updateTestOptionsFromTestHeader):
1904         * WebKitTestRunner/TestOptions.h:
1905         (WTR::TestOptions::hasSameInitializationOptions const):
1906
1907 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1908
1909         [ews-build] Allow * as platform for builders and workers
1910         https://bugs.webkit.org/show_bug.cgi?id=188533
1911
1912         Reviewed by Lucas Forschler.
1913
1914         * BuildSlaveSupport/ews-build/loadConfig.py:
1915         (checkWorkersAndBuildersForConsistency):
1916
1917 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1918
1919         [ews-build] Add few bots to config.json
1920         https://bugs.webkit.org/show_bug.cgi?id=194304
1921
1922         Reviewed by Lucas Forschler.
1923
1924         * BuildSlaveSupport/ews-build/config.json:
1925
1926 2019-02-05  Keith Rollin  <krollin@apple.com>
1927
1928         Enable the automatic checking and regenerations of .xcfilelists during builds
1929         https://bugs.webkit.org/show_bug.cgi?id=194124
1930         <rdar://problem/47721277>
1931
1932         Reviewed by Tim Horton.
1933
1934         Bug 193790 add a facility for checking -- during build time -- that
1935         any needed .xcfilelist files are up-to-date and for updating them if
1936         they are not. This facility was initially opt-in by setting
1937         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1938         the process seemed robust. Its now time to enable this facility and
1939         make it opt-out. If there is a need to disable this facility, set and
1940         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1941         running `make` or `build-webkit`, or before running Xcode from the
1942         command line.
1943
1944         Additionally, remove the step that generates a list of source files
1945         going into the UnifiedSources build step. It's only necessarily to
1946         specify Sources.txt and SourcesCocoa.txt as inputs.
1947
1948         * Scripts/generate-xcfilelists:
1949
1950 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1951
1952         [GTK][WPE] force libpsl build to use ICU in jhbuild
1953         https://bugs.webkit.org/show_bug.cgi?id=194288
1954
1955         Reviewed by Philippe Normand.
1956
1957         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1958         This can cause build failures if libidn is detected but libunistring is not available.
1959
1960         Make sure that ICU is used for runtime and builtin PSL data.
1961
1962         * gtk/jhbuild.modules:
1963         * wpe/jhbuild.modules:
1964
1965 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1966
1967         [ews-app] Modified timestamp should be updated on updating data
1968         https://bugs.webkit.org/show_bug.cgi?id=194295
1969
1970         Reviewed by Lucas Forschler.
1971
1972         * BuildSlaveSupport/ews-app/ews/models/build.py:
1973         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1974         * BuildSlaveSupport/ews-app/ews/models/step.py:
1975
1976 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1977
1978         Unreviewed, rolling out r240742.
1979
1980         Causes crashes on iOS simulator.
1981
1982         Reverted changeset:
1983
1984         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1985         not focused in a content-editable element"
1986         https://bugs.webkit.org/show_bug.cgi?id=192824
1987         https://trac.webkit.org/changeset/240742
1988
1989 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1990
1991         run-webkit-tests emits message "...running None" when running tests
1992         https://bugs.webkit.org/show_bug.cgi?id=194133
1993         <rdar://problem/47724738>
1994
1995         Reviewed by Lucas Forschler.
1996
1997         * Scripts/webkitpy/xcode/device_type.py:
1998         (DeviceType.__str__): Use both version mapping tables and use just the variant
1999         name if no version name is available.
2000         * Scripts/webkitpy/xcode/device_type_unittest.py:
2001         (DeviceTypeTest):
2002         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2003         an associated named.
2004
2005 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2006
2007         [WPE] require python3-setuptools for meson build in jhbuild
2008         https://bugs.webkit.org/show_bug.cgi?id=194287
2009
2010         Reviewed by Philippe Normand.
2011
2012         python3-setuptools is needed to build meson in jhbuild.
2013         It is already required by the GTK port.
2014
2015         * wpe/install-dependencies:
2016
2017 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2018
2019         [ews-app] Add method to save BuilderMapping to database
2020         https://bugs.webkit.org/show_bug.cgi?id=194264
2021
2022         Reviewed by Lucas Forschler.
2023
2024         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2025         (BuilderMapping.__str__):
2026         (BuilderMapping):
2027         (BuilderMapping.save_mapping):
2028         (BuilderMapping.update_mapping):
2029         (BuilderMapping.get_existing_mapping):
2030         (BuilderMapping.is_valid_mapping):
2031
2032 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2033
2034         [ews-app] Add timestamp fields for BuilderMappings
2035         https://bugs.webkit.org/show_bug.cgi?id=194266
2036
2037         Reviewed by Lucas Forschler.
2038
2039         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2040         (BuilderMapping):
2041
2042 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2043
2044         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2045         https://bugs.webkit.org/show_bug.cgi?id=174816
2046
2047         Reviewed by Michael Catanzaro.
2048
2049         Add tests for webkit_uri_for_display().
2050
2051         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2052         (testURIForDisplayUnaffected):
2053         (testURIForDisplayAffected):
2054         (beforeAll):
2055         (afterAll):
2056         * TestWebKitAPI/glib/CMakeLists.txt:
2057
2058 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2059
2060         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2061         https://bugs.webkit.org/show_bug.cgi?id=194158
2062         <rdar://problem/47737268>
2063
2064         Rubber-stamped by Aakash Jain.
2065
2066         * Scripts/webkitpy/port/device_port.py:
2067         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2068
2069 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2070
2071         [CG] Enable setAdditionalSupportedImageTypes for WK1
2072         https://bugs.webkit.org/show_bug.cgi?id=194190
2073
2074         Reviewed by Tim Horton.
2075
2076         Add a test similar to the one under WebKit Cocoa but make it create a
2077         WebView instead of a WKWebView.
2078
2079         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2080         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2081         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2082         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2083         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2084         (TestWebKitAPI::runTest):
2085         (TestWebKitAPI::TEST):
2086
2087 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2088
2089         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2090         https://bugs.webkit.org/show_bug.cgi?id=194168
2091
2092         Reviewed by Simon Fraser.
2093
2094         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2095
2096         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2097         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2098         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2099         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2100         (TEST):
2101         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2102         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2103
2104 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2105
2106         REGRESSION (r237269): webkit-patch what-broke is broken 
2107         https://bugs.webkit.org/show_bug.cgi?id=193025
2108
2109         Reviewed by Aakash Jain.
2110
2111         * Scripts/webkitpy/common/host.py:
2112         (Host.buildbot):
2113         (Host.bugzilla): Renamed to 'buildbot'.
2114
2115 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2116
2117         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2118         https://bugs.webkit.org/show_bug.cgi?id=194207
2119
2120         Reviewed by Tim Horton.
2121
2122         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2123         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2124         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2125         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2126         start and delete forwards to remove the original attachment.
2127
2128         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2129         (TestWebKitAPI::TEST):
2130
2131 2019-02-04  Youenn Fablet  <youenn@apple.com>
2132
2133         Capture state should be managed consistently when doing process swapping
2134         https://bugs.webkit.org/show_bug.cgi?id=194122
2135         <rdar://problem/47609293>
2136
2137         Reviewed by Eric Carlson.
2138
2139         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2140         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2141         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2142         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2143         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2144         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2145         (WTR::TestRunner::isDoingMediaCapture const):
2146         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2147         * WebKitTestRunner/TestController.cpp:
2148         (WTR::TestController::isDoingMediaCapture const):
2149         * WebKitTestRunner/TestController.h:
2150         * WebKitTestRunner/TestInvocation.cpp:
2151         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2152         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2153         (WTR::TestController::isDoingMediaCapture const):
2154
2155 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2156
2157         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2158         https://bugs.webkit.org/show_bug.cgi?id=194142
2159
2160         Reviewed by Ross Kirsling.
2161
2162         There three 'separator' variables in TestController.cpp. Renamed
2163         it 'pathSeparator', and unified them.
2164
2165         * WebKitTestRunner/TestController.cpp:
2166         (WTR::TestController::generateContextConfiguration const):
2167         (WTR::createTestURL):
2168         (WTR::TestController::platformAdjustContext):
2169
2170 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2171
2172         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2173         https://bugs.webkit.org/show_bug.cgi?id=194198
2174
2175         Reviewed by Antti Koivisto.
2176
2177         No need to set the banner heights on navigation now, since Page stores them.
2178
2179         * MiniBrowser/mac/WK2BrowserWindowController.m:
2180         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2181
2182 2019-02-03  John Wilander  <wilander@apple.com>
2183
2184         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2185         https://bugs.webkit.org/show_bug.cgi?id=194104
2186         <rdar://problem/47649991>
2187
2188         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2189
2190         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2191         (TestWebKitAPI::TEST):
2192             Changed numeric types from unsigned short to uint32_t.
2193
2194 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2195
2196         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2197         <https://webkit.org/b/194178>
2198         <rdar://problem/47753473>
2199
2200         Reviewed by Alexey Proskuryakov.
2201
2202         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2203         (WTR::uninstallFakeHelvetica): Pass nullptr into
2204         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2205
2206 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2207
2208         [LFC] Initialize ICB's style with fixed width/height.
2209         https://bugs.webkit.org/show_bug.cgi?id=194188
2210
2211         Reviewed by Antti Koivisto.
2212
2213         * LayoutReloaded/misc/LFC-passing-tests.txt:
2214
2215 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2216
2217         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2218         https://bugs.webkit.org/show_bug.cgi?id=194185
2219
2220         Reviewed by Antti Koivisto.
2221
2222         * LayoutReloaded/misc/LFC-passing-tests.txt:
2223
2224 2018-12-16  Darin Adler  <darin@apple.com>
2225
2226         Convert additional String::format clients to alternative approaches
2227         https://bugs.webkit.org/show_bug.cgi?id=192746
2228
2229         Reviewed by Alexey Proskuryakov.
2230
2231         * WebKitTestRunner/TestController.cpp:
2232         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2233         as an intermediate in code that ultimately constructs a WTF::String.
2234         (WTR::userMediaOriginHash): Use makeString.
2235         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2236         (WTR::TestController::didPerformClientRedirect): Ditto.
2237         (WTR::TestController::didPerformServerRedirect): Ditto.
2238         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2239
2240 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2241
2242         [ews-build] Add unit test to verify builder keys
2243         https://bugs.webkit.org/show_bug.cgi?id=194152
2244
2245         Reviewed by Lucas Forschler.
2246
2247         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2248         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2249
2250 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2251
2252         [LFC] Expand tests coverage (12 new tests -> 787)
2253
2254         Unreviewed test gardening.
2255
2256         * LayoutReloaded/misc/LFC-passing-tests.txt:
2257
2258 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2259
2260         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2261         https://bugs.webkit.org/show_bug.cgi?id=194163
2262
2263         Reviewed by Simon Fraser.
2264
2265         775
2266
2267         * LayoutReloaded/misc/LFC-passing-tests.txt:
2268
2269 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2270
2271         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2272         https://bugs.webkit.org/show_bug.cgi?id=194140
2273         <rdar://problem/47728098>
2274
2275         Reviewed by Tim Horton.
2276
2277         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2278         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2279         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2280
2281         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2282         test to induce an IPC deadlock when presenting a modal alert during touch start.
2283
2284         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2285         * WebKitTestRunner/TestController.cpp:
2286         (WTR::runJavaScriptAlert):
2287
2288         Add a client callback function for running JavaScript alerts.
2289
2290         (WTR::TestController::createOtherPage):
2291         (WTR::TestController::generateContextConfiguration const):
2292
2293         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2294         the fix in this patch.
2295
2296         (WTR::TestController::createWebViewWithOptions):
2297
2298         Plumb TestOptions to generateContextConfiguration.
2299
2300         (WTR::TestController::resetPreferencesToConsistentValues):
2301         (WTR::TestController::resetStateToConsistentValues):
2302         (WTR::updateTestOptionsFromTestHeader):
2303         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2304         (WTR::TestController::handleJavaScriptAlert):
2305         * WebKitTestRunner/TestController.h:
2306         * WebKitTestRunner/TestInvocation.cpp:
2307         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2308         * WebKitTestRunner/TestOptions.h:
2309         (WTR::TestOptions::hasSameInitializationOptions const):
2310
2311 2019-02-01  Chris Dumez  <cdumez@apple.com>
2312
2313         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2314         https://bugs.webkit.org/show_bug.cgi?id=193740
2315         <rdar://problem/47527267>
2316
2317         Reviewed by Alex Christensen.
2318
2319         Add API test coverage.
2320
2321         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2322
2323 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2324
2325         [ews-app] Add display name field to BuilderMapping model
2326         https://bugs.webkit.org/show_bug.cgi?id=194153
2327
2328         Reviewed by Lucas Forschler.
2329
2330         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2331         (BuilderMapping):
2332
2333 2019-02-01  Youenn Fablet  <youenn@apple.com>
2334
2335         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2336         https://bugs.webkit.org/show_bug.cgi?id=194155
2337
2338         Reviewed by Eric Carlson.
2339
2340         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2341         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2342         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2343
2344 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2345
2346         [LFC] Adjust replaced element's intrinsic ratio
2347         https://bugs.webkit.org/show_bug.cgi?id=194154
2348
2349         Reviewed by Antti Koivisto.
2350
2351         761
2352
2353         * LayoutReloaded/misc/LFC-passing-tests.txt:
2354
2355 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2356
2357         [WPE] Show test results in minibrowser
2358         https://bugs.webkit.org/show_bug.cgi?id=194150
2359
2360         Reviewed by Žan Doberšek.
2361
2362         * Scripts/webkitpy/port/wpe.py:
2363         (WPEPort.show_results_html_file):
2364
2365 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2366
2367         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2368         https://bugs.webkit.org/show_bug.cgi?id=194151
2369
2370         Reviewed by Žan Doberšek.
2371
2372         ALT + <- go back
2373         ALT + -> go forward
2374
2375         * MiniBrowser/wpe/main.cpp:
2376         (main):
2377
2378 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2379
2380         [LFC] Set intrinsic size on Layout::Replaced
2381         https://bugs.webkit.org/show_bug.cgi?id=194139
2382
2383         Reviewed by Antti Koivisto.
2384
2385         744
2386
2387         * LayoutReloaded/misc/LFC-passing-tests.txt:
2388
2389 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2390
2391         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2392         https://bugs.webkit.org/show_bug.cgi?id=194146
2393
2394         Reviewed by Xabier Rodriguez-Calvar.
2395
2396         It allows to open relative paths.
2397
2398         * MiniBrowser/wpe/main.cpp:
2399         (main):
2400
2401 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2402
2403         Update flakiness dashboard configuration after recent queue changes
2404         https://bugs.webkit.org/show_bug.cgi?id=194127
2405
2406         Rubber-stamped by Aakash Jain.
2407
2408         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2409
2410         * TestResultServer/static-dashboards/builders.jsonp:
2411
2412 2019-01-31  Youenn Fablet  <youenn@apple.com>
2413
2414         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2415         https://bugs.webkit.org/show_bug.cgi?id=194106
2416         <rdar://problem/47676333>
2417
2418         Reviewed by Ryosuke Niwa.
2419
2420         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2421         (TestWebKitAPI::didFinishNavigation):
2422         (TestWebKitAPI::TEST):
2423         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2424
2425 2019-01-31  Chris Dumez  <cdumez@apple.com>
2426
2427         Page zoom level is lost after a process swap or a crash
2428         https://bugs.webkit.org/show_bug.cgi?id=194105
2429         <rdar://problem/47610781>
2430
2431         Reviewed by Alex Christensen.
2432
2433         Add API test coverage.
2434
2435         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2436         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2437
2438 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2439
2440         Revert r238819 which is unneeded and caused a performance regression.
2441         https://bugs.webkit.org/show_bug.cgi?id=192272
2442         <rdar://problem/46664625>
2443
2444         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2445         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2446         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2447
2448 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2449
2450         Formalize WebKitAdditions mechanism of LoadOptimizer
2451         https://bugs.webkit.org/show_bug.cgi?id=193886
2452         <rdar://problem/47696809>
2453
2454         Reviewed by Brent Fulgham.
2455
2456         * MiniBrowser/MiniBrowser.entitlements:
2457         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2458
2459 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2460
2461         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2462         https://bugs.webkit.org/show_bug.cgi?id=194090
2463
2464         Reviewed by Antti Koivisto.
2465
2466         * LayoutReloaded/misc/LFC-passing-tests.txt:
2467
2468 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2469
2470         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2471         https://bugs.webkit.org/show_bug.cgi?id=194074
2472
2473         Reviewed by Antti Koivisto.
2474
2475         * LayoutReloaded/misc/LFC-passing-tests.txt:
2476
2477 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2478
2479         [LFC][BFC] Add support for block level replaced box.
2480         https://bugs.webkit.org/show_bug.cgi?id=194071
2481
2482         Reviewed by Antti Koivisto.
2483
2484         * LayoutReloaded/misc/LFC-passing-tests.txt:
2485
2486 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2487
2488         Fix WebKitTestRunner's testPath with Windows full paths
2489         https://bugs.webkit.org/show_bug.cgi?id=194012
2490
2491         Reviewed by Alex Christensen.
2492
2493         updateTestOptionsFromTestHeader failed to open test files because
2494         testPath returned wrong file paths. It returned a path "/C:/..."
2495         if a URL "file:///C:/..." was given.
2496
2497         * WebKitTestRunner/TestController.cpp:
2498         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2499
2500 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2501
2502         [WPE] Bump font related dependencies to match the GTK+ port
2503         https://bugs.webkit.org/show_bug.cgi?id=194017
2504
2505         Reviewed by Žan Doberšek.
2506
2507         * wpe/jhbuild.modules:
2508         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2509         * wpe/patches/icudata-stdlibs.patch: Added.
2510
2511 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2512
2513         Enable swipe tests on iOS
2514         https://bugs.webkit.org/show_bug.cgi?id=194076
2515
2516         Reviewed by Geoffrey Garen.
2517
2518         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2519         it causes a debug assertion failure in runUIScript.
2520
2521         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2522         (WTR::UIScriptController::beginBackSwipe):
2523         (WTR::UIScriptController::completeBackSwipe):
2524
2525 2019-01-30  Keith Rollin  <krollin@apple.com>
2526
2527         Use correct printf format specifier
2528         https://bugs.webkit.org/show_bug.cgi?id=194062
2529         <rdar://problem/47686167>
2530
2531         Reviewed by Alexey Proskuryakov.
2532
2533         LayoutTestSpellChecker.mm is trying to format a variable of type
2534         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2535         actually an unsigned long long. Fix this by formatting with %llu.
2536
2537         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2538         (-[LayoutTestTextCheckingResult description]):
2539
2540 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2541
2542         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2543         https://bugs.webkit.org/show_bug.cgi?id=193979
2544
2545         Reviewed by Wenson Hsieh.
2546
2547         Fix the test for iOS. Make the test work with iOS UA string.
2548
2549         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2550
2551 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2552
2553         Replace High Sierra LLINT CLoop bot due to hardware failure
2554         https://bugs.webkit.org/show_bug.cgi?id=194066
2555
2556         Reviewed by Aakash Jain.
2557
2558         * BuildSlaveSupport/build.webkit.org-config/config.json:
2559
2560 2019-01-30  Keith Rollin  <krollin@apple.com>
2561
2562         [NSDragItem init] is unavailable
2563         https://bugs.webkit.org/show_bug.cgi?id=194059
2564         <rdar://problem/47685715>
2565
2566         Reviewed by Wenson Hsieh.
2567
2568         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2569         DumpRenderTree and TestWebKitAPI, which both try to create an
2570         NSDragItem in a manner that invokes this method. Address this by using
2571         -initWithPasteboardWriter instead.
2572
2573         Note that the parameter passed to initWithPasteboardWriter is likely
2574         incorrect. In both cases, the object passed does not conform to
2575         NSPasteboardWriting. However, with this fix, we're no worse off than
2576         before, and can now perform builds with newer compilers and SDKs until
2577         a real fix can be crafted. That work is tracked in
2578         https://bugs.webkit.org/show_bug.cgi?id=194060
2579
2580         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2581         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2582         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2583         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2584
2585 2019-01-30  Daniel Bates  <dabates@apple.com>
2586
2587         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2588         https://bugs.webkit.org/show_bug.cgi?id=192824
2589         <rdar://problem/47100332>
2590
2591         Reviewed by Wenson Hsieh.
2592
2593         Fix a bug where the wrong usage code was used for F13 thru F24.
2594
2595         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2596         (keyCodeForDOMFunctionKey):
2597
2598 2019-01-30  Chris Dumez  <cdumez@apple.com>
2599
2600         Regression(PSON) Load hang can occur on history navigation
2601         https://bugs.webkit.org/show_bug.cgi?id=194030
2602         <rdar://problem/47656939>
2603
2604         Reviewed by Antti Koivisto.
2605
2606         Add API test coverage.
2607
2608         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2609
2610 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2611
2612         [LFC] Expand tests coverage.
2613
2614         Unreviewed test gardening.
2615
2616         * LayoutReloaded/misc/LFC-passing-tests.txt:
2617
2618 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2619
2620         [Flatpak] Add openjpeg support
2621         https://bugs.webkit.org/show_bug.cgi?id=194019
2622
2623         Reviewed by Michael Catanzaro.
2624
2625         * flatpak/org.webkit.CommonModules.yaml:
2626
2627 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2628
2629         Unreviewed, rolling out r240708.
2630         https://bugs.webkit.org/show_bug.cgi?id=194022
2631
2632         It broke WPE build (Requested by KaL on #webkit).
2633
2634         Reverted changeset:
2635
2636         "[WPE] Bump font related dependencies to match the GTK+ port"
2637         https://bugs.webkit.org/show_bug.cgi?id=194017
2638         https://trac.webkit.org/changeset/240708
2639
2640 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2641
2642         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2643         https://bugs.webkit.org/show_bug.cgi?id=194001
2644
2645         Reviewed by Antti Koivisto.
2646
2647         * LayoutReloaded/misc/LFC-passing-tests.txt:
2648
2649 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2650
2651         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2652         https://bugs.webkit.org/show_bug.cgi?id=194020
2653
2654         Reviewed by Antti Koivisto.
2655
2656         * LayoutReloaded/misc/LFC-passing-tests.txt:
2657
2658 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2659
2660         AX: Support color well on iOS
2661         https://bugs.webkit.org/show_bug.cgi?id=194010
2662
2663         Reviewed by Joanmarie Diggs.
2664
2665         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2666         (WTR::AccessibilityUIElement::stringAttributeValue):
2667
2668 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2669
2670         [WPE] Bump font related dependencies to match the GTK+ port
2671         https://bugs.webkit.org/show_bug.cgi?id=194017
2672
2673         Reviewed by Žan Doberšek.
2674
2675         * wpe/jhbuild.modules:
2676         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2677         * wpe/patches/icudata-stdlibs.patch: Added.
2678
2679 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2680
2681         [Mac] Update window scale API usage
2682         https://bugs.webkit.org/show_bug.cgi?id=193991
2683         rdar://problem/47614795
2684
2685         Reviewed by Tim Horton.
2686
2687         * DumpRenderTree/mac/DumpRenderTree.mm:
2688         (changeWindowScaleIfNeeded):
2689         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2690         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2691         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2692
2693 2019-01-29  Chris Dumez  <cdumez@apple.com>
2694
2695         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2696         https://bugs.webkit.org/show_bug.cgi?id=193977
2697         <rdar://problem/47643716>
2698
2699         Reviewed by Geoff Garen.
2700
2701         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2702         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2703         to the previous provisional committing *before* we make the last load. 
2704
2705         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2706
2707 2019-01-29  Youenn Fablet  <youenn@apple.com>
2708
2709         Adopt new SPI to evaluate server certificate trust
2710         https://bugs.webkit.org/show_bug.cgi?id=193355
2711
2712         Reviewed by Alex Christensen.
2713
2714         Add infrastructure to handle HTTPS server trust evaluation testing.
2715
2716         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2717         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2718         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2719         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2720         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2721         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2722         * WebKitTestRunner/TestController.cpp:
2723         (WTR::TestController::resetPreferencesToConsistentValues):
2724         (WTR::TestController::didReceiveAuthenticationChallenge):
2725         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2726         * WebKitTestRunner/TestController.h:
2727         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2728         * WebKitTestRunner/TestInvocation.cpp:
2729         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2730         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2731         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2732
2733 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2734
2735         [ews-build] Add build step to print bot Configuration
2736         https://bugs.webkit.org/show_bug.cgi?id=193887
2737
2738         Reviewed by Lucas Forschler.
2739
2740         * BuildSlaveSupport/ews-build/steps.py:
2741         (PrintConfiguration): Build step to print configuration.
2742         * BuildSlaveSupport/ews-build/factories.py:
2743
2744 2019-01-29  Chris Dumez  <cdumez@apple.com>
2745
2746         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2747         https://bugs.webkit.org/show_bug.cgi?id=193967
2748         <rdar://problem/47635348>
2749
2750         Reviewed by Alex Christensen.
2751
2752         Add API test coverage.
2753
2754         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2755         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2756
2757 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2758
2759         [ews-app] Handle incoming results data
2760         https://bugs.webkit.org/show_bug.cgi?id=193973
2761
2762         Reviewed by Lucas Forschler.
2763
2764         * BuildSlaveSupport/ews-app/ews/views/results.py:
2765
2766 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2767
2768         [ews-app] Make the results url generic
2769         https://bugs.webkit.org/show_bug.cgi?id=193928
2770
2771         Reviewed by Lucas Forschler.
2772
2773         * BuildSlaveSupport/ews-app/ews/urls.py:
2774
2775 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2776
2777         [ews-build] Configure buildbot to send events to ews-app
2778         https://bugs.webkit.org/show_bug.cgi?id=193968
2779
2780         Reviewed by Lucas Forschler.
2781
2782         * BuildSlaveSupport/ews-build/events.py: Added.
2783         * BuildSlaveSupport/ews-build/master.cfg:
2784
2785 2019-01-29  Keith Rollin  <krollin@apple.com>
2786
2787         Add .xcfilelists to Run Script build phases
2788         https://bugs.webkit.org/show_bug.cgi?id=193792
2789         <rdar://problem/47201785>
2790
2791         Reviewed by Alex Christensen.
2792
2793         As part of supporting XCBuild, update the necessary Run Script build
2794         phases in their Xcode projects to refer to their associated
2795         .xcfilelist files.
2796
2797         Note that the addition of these files bumps the Xcode project version
2798         number to something that's Xcode 10 compatible. This change means that
2799         older versions of the Xcode IDE can't read these projects. Nor can it
2800         fully load workspaces that refer to these projects (the updated
2801         projects are shown as non-expandable placeholders). `xcodebuild` can
2802         still build these projects; it's just that the IDE can't open them.
2803
2804         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2805         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2806
2807 2019-01-29  John Wilander  <wilander@apple.com>
2808
2809         Add data abstraction and validation for Ad Click Attribution
2810         https://bugs.webkit.org/show_bug.cgi?id=193916
2811         <rdar://problem/47603481>
2812
2813         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2814
2815         Ad click attribution has two steps. First, the storage of an ad
2816         campaign ID for a click that takes the user to a destination
2817         site. Second, a conversion on the destination site that can be
2818         attributed to the ad click.
2819
2820         This patch adds a class that represents a request for ad click
2821         attribution. Validation makes sure that the bits of entropy
2822         reported through this mechanism is limited.
2823
2824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2825         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2826         (TestWebKitAPI::TEST):
2827
2828 2019-01-29  Chris Dumez  <cdumez@apple.com>
2829
2830         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2831         https://bugs.webkit.org/show_bug.cgi?id=193932
2832         <rdar://problem/47598947>
2833
2834         Reviewed by Brady Eidson.
2835
2836         Add API test coverage.
2837
2838         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2839
2840 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2841
2842         Adding new passing LFC tests.
2843
2844         Unreviewed test gardening.
2845
2846         * LayoutReloaded/misc/LFC-passing-tests.txt:
2847
2848 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2849
2850         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2851         https://bugs.webkit.org/show_bug.cgi?id=193964
2852
2853         Reviewed by Antti Koivisto.
2854
2855         * LayoutReloaded/misc/LFC-passing-tests.txt:
2856
2857 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2858
2859         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2860         https://bugs.webkit.org/show_bug.cgi?id=193954
2861
2862         Reviewed by Antti Koivisto.
2863
2864         * LayoutReloaded/misc/LFC-passing-tests.txt:
2865
2866 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2867
2868         WebDriver: add support for running subtests
2869         https://bugs.webkit.org/show_bug.cgi?id=193904
2870
2871         Reviewed by Michael Catanzaro.
2872
2873         pytest already supports it by passing test.py::subtest, so we can do the same.
2874
2875         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2876         (get_item_name): Made this global.
2877         (CollectRecorder.__init__): Receive the parameter to ignore.
2878         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2879         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2880         (collect): Add parameter to ignore.
2881         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2882         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2883         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2884         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2885         (WebDriverTestRunnerSelenium.run): Ditto.
2886         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2887         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2888         (WebDriverTestRunnerW3C.run): Ditto.
2889
2890 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2891
2892         User agent string override for navigator.userAgent should be site specific quirks
2893         https://bugs.webkit.org/show_bug.cgi?id=193950
2894
2895         Reviewed by Brent Fulgham.
2896
2897         Updated per the _WKWebsitePolicies rename.
2898
2899         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2900         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2901
2902 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2903
2904         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2905         https://bugs.webkit.org/show_bug.cgi?id=193941
2906
2907         Reviewed by Alex Christensen.
2908
2909         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2910         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2911         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2912         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2913         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2914         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2915         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2916         * TestWebKitAPI/Tests/WTF/Time.cpp:
2917         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2918         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2919         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2920         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2921
2922 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2923
2924         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2925
2926         * Scripts/webkitpy/common/config/contributors.json:
2927
2928 2019-01-28  Andy Estes  <aestes@apple.com>
2929
2930         [watchOS] Enable Parental Controls content filtering
2931         https://bugs.webkit.org/show_bug.cgi?id=193939
2932         <rdar://problem/46641912>
2933
2934         Reviewed by Ryosuke Niwa.
2935
2936         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2937
2938 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2939
2940         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2941         <https://webkit.org/b/193884>
2942
2943         Reviewed by Jiewen Tan.
2944
2945         * Scripts/webkitpy/style/checkers/cpp.py:
2946         (check_language): Add LocalAuthentication to
2947         `frameworks_with_soft_links`.
2948
2949 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2950
2951         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2952         https://bugs.webkit.org/show_bug.cgi?id=193891
2953
2954         Reviewed by Ross Kirsling.
2955
2956         There were three problems in window sizes of WebView and the host window.
2957         1. The sizes of pixel image output were incorrect.
2958         2. The host window is going to appear after window.resize was invoked.
2959         3. window.resize resized only the host window, not WebView.
2960
2961         This change solves them with a following approach.
2962         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2963         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2964            as well as DumpRenderTree in order to match the client area and the window area.
2965         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2966         d. PlatformWebView::setWindowFrame changes both window sizes.
2967         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2968
2969         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2970         (WTR::PlatformWebView::PlatformWebView): Create the host window
2971         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2972         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2973         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2974
2975 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2976
2977         [ews-app] Add method to save Step data to database
2978         https://bugs.webkit.org/show_bug.cgi?id=193890
2979
2980         Reviewed by Lucas Forschler.
2981
2982         * BuildSlaveSupport/ews-app/ews/models/step.py:
2983         (Step.save_step): Method to save step data.
2984         (Step.update_step): Method to update step data.
2985         (Step.get_existing_step): Method to fetch existing step from database.
2986         (Step.is_valid_result): Method to validate valid step result.
2987
2988 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2989
2990         [ews-app] Add method to save Build data to database
2991         https://bugs.webkit.org/show_bug.cgi?id=193735
2992
2993         Reviewed by Lucas Forschler.
2994
2995         * BuildSlaveSupport/ews-app/ews/models/build.py:
2996         (Build.save_build): Method to save build information to database.
2997         (Build.get_existing_build): Method to fetch existing build from database.
2998         (Build.is_valid_result): Method to validate build result.
2999         * BuildSlaveSupport/ews-app/ews/common/util.py:
3000         (is_valid_int_id): Method to validate valid id.
3001
3002 2019-01-28  Chris Dumez  <cdumez@apple.com>
3003
3004         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3005         https://bugs.webkit.org/show_bug.cgi?id=193915
3006         <rdar://problem/47560907>
3007
3008         Reviewed by Alex Christensen.
3009
3010         Add API test coverage.
3011
3012         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3013
3014 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3015
3016         [ews-app] Rename id variables
3017         https://bugs.webkit.org/show_bug.cgi?id=193883
3018
3019         Reviewed by Lucas Forschler.
3020
3021         * BuildSlaveSupport/ews-app/ews/models/build.py:
3022         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3023         * BuildSlaveSupport/ews-app/ews/models/step.py:
3024         * BuildSlaveSupport/ews-app/ews/urls.py:
3025         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3026         * BuildSlaveSupport/ews-app/ews/views/results.py:
3027         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3028
3029 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3030
3031         [ews-app] Allow certain fields to be empty
3032         https://bugs.webkit.org/show_bug.cgi?id=193892
3033
3034         Reviewed by Lucas Forschler.
3035
3036         * BuildSlaveSupport/ews-app/ews/models/build.py:
3037         * BuildSlaveSupport/ews-app/ews/models/step.py:
3038
3039 2019-01-28  Rob Buis  <rbuis@igalia.com>
3040
3041         Update MIME type parser
3042         https://bugs.webkit.org/show_bug.cgi?id=180526
3043
3044         Reviewed by Frédéric Wang.
3045
3046         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3047         (TestWebKitAPI::TEST):
3048
3049 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3050
3051         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3052         https://bugs.webkit.org/show_bug.cgi?id=193896
3053
3054         Reviewed by Antti Koivisto.
3055
3056         * LayoutReloaded/misc/LFC-passing-tests.txt:
3057
3058 2018-12-15  Darin Adler  <darin@apple.com>
3059
3060         Replace many uses of String::format with more type-safe alternatives
3061         https://bugs.webkit.org/show_bug.cgi?id=192742
3062
3063         Reviewed by Mark Lam.
3064
3065         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3066         (WTR::cacheTestRunnerCallback): Use makeString.
3067         * WebKitTestRunner/TestController.cpp:
3068         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3069         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3070
3071 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3072
3073         Use a load optimizer for some sites
3074         https://bugs.webkit.org/show_bug.cgi?id=193881
3075         <rdar://problem/46325455>
3076
3077         Reviewed by Brent Fulgham.
3078
3079         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3080         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3081
3082 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3083
3084         AX: Introduce a static accessibility tree
3085         https://bugs.webkit.org/show_bug.cgi?id=193348
3086         <rdar://problem/47203295>
3087
3088         Reviewed by Ryosuke Niwa.
3089
3090         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3091
3092 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3093
3094         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3095         https://bugs.webkit.org/show_bug.cgi?id=193867
3096
3097         Reviewed by Antti Koivisto.
3098
3099         * LayoutReloaded/misc/LFC-passing-tests.txt:
3100
3101 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3102
3103         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3104         https://bugs.webkit.org/show_bug.cgi?id=193865
3105
3106         Reviewed by Antti Koivisto.
3107
3108         * LayoutReloaded/misc/LFC-passing-tests.txt:
3109
3110 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3111
3112         Need a mechanism to override navigator.userAgent
3113         https://bugs.webkit.org/show_bug.cgi?id=193762
3114         <rdar://problem/47504939>
3115
3116         Reviewed by Brent Fulgham.
3117
3118         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3119
3120         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3121         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3122         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3123
3124 2019-01-25  Dean Jackson  <dino@apple.com>
3125
3126         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3127         https://bugs.webkit.org/show_bug.cgi?id=193831
3128         <rdar://problem/47399263>
3129
3130         Reviewed by Chris Dumez.
3131
3132         Two new tests that exercise cross-origin and same-origin System
3133         Previews.
3134
3135         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3136
3137 2019-01-25  Keith Rollin  <krollin@apple.com>
3138
3139         Update Xcode projects with "Check .xcfilelists" build phase
3140         https://bugs.webkit.org/show_bug.cgi?id=193790
3141         <rdar://problem/47201374>
3142
3143         Reviewed by Alex Christensen.
3144
3145         Support for XCBuild includes specifying inputs and outputs to various
3146         Run Script build phases. These inputs and outputs are specified as
3147         .xcfilelist files. Once created, these .xcfilelist files need to be
3148         kept up-to-date. In order to check that they are up-to-date or not,
3149         add an Xcode build step that invokes an external script that performs
3150         the checking. If the .xcfilelists are found to be out-of-date, update
3151         them, halt the build, and instruct the developer to restart the build
3152         with up-to-date files.
3153
3154         At this time, the checking and regenerating is performed only if the
3155         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3156         who want to use this facility can set this variable and test out the
3157         checking/regenerating. Once it seems like there are no egregious
3158         issues that upset a developer's workflow, we'll unconditionally enable
3159         this facility.
3160
3161         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3162         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3163         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3164         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3165
3166 2019-01-25  Keith Rollin  <krollin@apple.com>
3167
3168         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3169         https://bugs.webkit.org/show_bug.cgi?id=193781
3170         <rdar://problem/47201153>
3171
3172         Reviewed by Alex Christensen.
3173
3174         Part of generating the .xcfilelists used as part of adopting XCBuild
3175         includes running `make DerivedSources.make` from a standalone script.
3176         It’s important for this invocation to have the same environment as
3177         when the actual build invokes `make DerivedSources.make`. If the
3178         environments are different, then the two invocations will provide
3179         different results. In order to get the same environment in the
3180         standalone script, have the script launch xcodebuild targeting the
3181         "Apply Configuration to XCFileLists" build target, which will then
3182         re-invoke our standalone script. The script is now running again, this
3183         time in an environment with all workspace, project, target, xcconfig
3184         and other environment variables established.
3185
3186         The "Apply Configuration to XCFileLists" build target accomplishes
3187         this task via a small embedded shell script that consists only of:
3188
3189             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3190
3191         The process that invokes "Apply Configuration to XCFileLists" first
3192         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3193         evaluated and exports it into the shell environment. When xcodebuild
3194         is invoked, it inherits the value of this variable and can `eval` the
3195         contents of that variable. Our external standalone script can then set
3196         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3197         of command-line parameters needed to restart itself in the appropriate
3198         state.
3199
3200         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3201         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3202
3203 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3204
3205         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3206         https://bugs.webkit.org/show_bug.cgi?id=193802
3207         <rdar://problem/46010580>
3208
3209         Reviewed by Andy Estes.
3210
3211         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3212         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3213         (TEST):
3214
3215 2019-01-25  Daniel Bates  <dabates@apple.com>
3216
3217         [iOS] uiController.keyDown() does not translate Control modified key
3218         https://bugs.webkit.org/show_bug.cgi?id=192898
3219
3220         Reviewed by Wenson Hsieh.
3221
3222         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3223         key translation, as applicable. Among other cases, key translation occurs when performing
3224         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3225         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3226         human pressing down and releasing key(s) using a hardware keyboard.
3227
3228         * WebKitTestRunner/ios/HIDEventGenerator.h:
3229         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3230         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3231
3232         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3233         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3234         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3235         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3236         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3237         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3238         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3239         (-[HIDEventGenerator longPress:completionBlock:]):
3240         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3241         Update code for above renaming.
3242
3243         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3244         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3245
3246         (-[HIDEventGenerator keyDown:]): Added.
3247         (-[HIDEventGenerator keyUp:]): Added.
3248         (-[HIDEventGenerator keyPress:completionBlock:]):
3249         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3250         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3251         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3252         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3253         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3254         (WTR::parseModifier): Deleted.
3255
3256 2019-01-25  Keith Rollin  <krollin@apple.com>
3257
3258         Complete the implementation of generate-xcfilelists
3259         https://bugs.webkit.org/show_bug.cgi?id=193782
3260
3261         Reviewed by Alex Christensen.
3262
3263         A preliminary version of generate-xcfilelists was added in r238008.
3264         This patch updates that script in order to:
3265
3266         - Support checking of .xcfilelists
3267         - Perform better execution of `make DerivedSources.make` by
3268           relaunching generate-xcfilelists under xcodebuild
3269         - Support incremental generation and checking of .xcfilelists
3270         - Support supplementary .xcfilelists files from WebKitAdditions
3271         - Support being wrapped by parallel version of generate-xcfilelists in
3272           Internal that adds support for (re)generating WebKit projects in
3273           that repo.
3274         - Support builds that have been performed in WebKitBuild as well as
3275           ~/Library/Developer/code/DerivedData
3276         - Increase robustness and debugging facilities.
3277
3278         * Scripts/generate-xcfilelists:
3279
3280 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3281
3282         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3283         https://bugs.webkit.org/show_bug.cgi?id=193297
3284         <rdar://problem/47158841>
3285
3286         Unreviewed test case fix.
3287
3288         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3289         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3290
3291         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3292         (TEST):
3293
3294 2019-01-25  Keith Rollin  <krollin@apple.com>
3295
3296         Update existing .xcfilelists
3297         https://bugs.webkit.org/show_bug.cgi?id=193791
3298         <rdar://problem/47201706>
3299
3300         Reviewed by Alex Christensen.
3301
3302         Many .xcfilelist files were added in r238824 in order to support
3303         XCBuild. Update these with recent changes to the set of build files
3304         and with the current generate-xcfilelist script.
3305
3306         * DumpRenderTree/DerivedSources-input.xcfilelist:
3307         * DumpRenderTree/DerivedSources-output.xcfilelist:
3308         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3309         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3310
3311 2019-01-25  Keith Rollin  <krollin@apple.com>
3312
3313         Fix missing dependencies in extract-dependencies-from-makefile
3314         https://bugs.webkit.org/show_bug.cgi?id=193783
3315         <rdar://problem/47201571>
3316
3317         Reviewed by Alex Christensen.
3318
3319         The extract-dependencies-from-makefile script generates .xcfilelists
3320         for XCBuild by invoking a makefile in --debug mode, parsing the
3321         dependency information in the output, and extracting information
3322         regarding targets and dependents. However, the way `make` emits this
3323         dependency information is not rigorous, and so we need to determine
3324         what lines to look for and parse by trial and error. This approach
3325         didn't coriginally atch all the information we needed to collect, so
3326         update the script to look for the additional lines we now know to look
3327         for.
3328
3329         * Scripts/extract-dependencies-from-makefile:
3330         (Parser):
3331         (Parser.addTarget):
3332         (Parser.addPrereq):
3333         (Parser.doParse):
3334
3335 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3336
3337         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3338         https://bugs.webkit.org/show_bug.cgi?id=193297
3339         <rdar://problem/47158841>
3340
3341         Reviewed by Alex Christensen.
3342
3343         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3344             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3345         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3346         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3347         activating the message used to trigger the callback when it is set.
3348
3349 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3350
3351         WKWebView.goBack should reload if there is a safe browsing warning
3352         https://bugs.webkit.org/show_bug.cgi?id=193805
3353         <rdar://problem/46908216>
3354
3355         Reviewed by Geoff Garen.
3356
3357         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3358         (+[Simple3LookupContext sharedLookupContext]):
3359         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3360         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3361         (TEST):
3362
3363 2019-01-25  Chris Dumez  <cdumez@apple.com>
3364
3365         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3366         https://bugs.webkit.org/show_bug.cgi?id=193788
3367         <rdar://problem/47531231>
3368
3369         Reviewed by Alex Christensen.
3370
3371         Add API test coverage.
3372
3373         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3374         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3375
3376 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3377
3378         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3379         https://bugs.webkit.org/show_bug.cgi?id=193771
3380
3381         Unreviewed infrastructure fix.
3382
3383         * Scripts/webkitpy/port/darwin.py:
3384         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3385
3386 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3387
3388         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3389
3390 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3391
3392         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3393
3394         * Scripts/webkitpy/common/config/contributors.json:
3395
3396 2019-01-25  Chris Dumez  <cdumez@apple.com>
3397
3398         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3399         https://bugs.webkit.org/show_bug.cgi?id=193779
3400         <rdar://problem/46170903>
3401
3402         Reviewed by Antti Koivisto.
3403
3404         Add API test that quickly navigates forward to a previous process without waiting for it to
3405         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3406         the process' previous page when reconnecting the it for the forward navigation.
3407
3408         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3409
3410 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3411
3412         Need a way for JavaScript (or bundle) code to participate in undo
3413         https://bugs.webkit.org/show_bug.cgi?id=190009
3414         <rdar://problem/44807048>
3415
3416         Reviewed by Ryosuke Niwa.
3417
3418         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3419         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3420
3421         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3422         (WTR::UIScriptController::lastUndoLabel const):
3423         (WTR::UIScriptController::firstRedoLabel const):
3424         (WTR::UIScriptController::platformUndoManager const):
3425         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3426         (WTR::UIScriptController::lastUndoLabel const):
3427         (WTR::UIScriptController::firstRedoLabel const):
3428         (WTR::UIScriptController::platformUndoManager const):
3429         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3430         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3431         (WTR::UIScriptController::lastUndoLabel const):
3432         (WTR::UIScriptController::firstRedoLabel const):
3433         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3434         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3435         (WTR::UIScriptController::lastUndoLabel const):
3436         (WTR::UIScriptController::firstRedoLabel const):
3437         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3438         (WTR::UIScriptController::platformUndoManager const):
3439         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3440         (WTR::UIScriptController::platformUndoManager const):
3441
3442 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3443
3444         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3445         https://bugs.webkit.org/show_bug.cgi?id=193824
3446
3447         Reviewed by Antti Koivisto.
3448
3449         * LayoutReloaded/misc/LFC-passing-tests.txt:
3450
3451 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3452
3453         Update macOS JSC bot configurations
3454         https://bugs.webkit.org/show_bug.cgi?id=193739
3455
3456         Reviewed by Alexey Proskuryakov.
3457
3458         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3459         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3460         (BubbleQueueServer): Move JSC EWS to Mojave section.
3461         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3462         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3463         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3464
3465 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3466
3467         [Win][WebKitTestRunner] Implement EventSenderProxy
3468         https://bugs.webkit.org/show_bug.cgi?id=193755
3469
3470         Reviewed by Don Olmstead.
3471
3472         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3473         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3474         (WTR::EventSenderProxy::dispatchMessage):
3475         (WTR::EventSenderProxy::EventSenderProxy):
3476         (WTR::EventSenderProxy::mouseDown):
3477         (WTR::EventSenderProxy::mouseUp):
3478         (WTR::EventSenderProxy::mouseMoveTo):
3479         (WTR::EventSenderProxy::mouseScrollBy):
3480         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3481
3482 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3483
3484         Unreviewed fix for API test failure after r240437.
3485
3486         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3487
3488         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3489
3490 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3491
3492         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3493         https://bugs.webkit.org/show_bug.cgi?id=193787
3494         <rdar://problem/47497634>
3495
3496         Reviewed by Alexey Proskuryakov.
3497
3498         * Scripts/webkitdirs.pm:
3499         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3500
3501 2019-01-24  Truitt Savell  <tsavell@apple.com>
3502
3503         Unreviewed, rolling out r240446.
3504
3505         Casued 5 API failures
3506
3507         Reverted changeset:
3508
3509         "Activate the WebResourceLoadStatisticsStore in the
3510         NetworkProcess and deactivate it in the UIProcess."
3511         https://bugs.webkit.org/show_bug.cgi?id=193297
3512         https://trac.webkit.org/changeset/240446
3513
3514 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3515
3516         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3517         https://bugs.webkit.org/show_bug.cgi?id=193741
3518         <rdar://problem/47135030>
3519
3520         Reviewed by Antti Koivisto and Simon Fraser.
3521
3522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3523         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3524         (TestWebKitAPI::TEST):
3525
3526 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3527
3528         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3529         https://bugs.webkit.org/show_bug.cgi?id=193297
3530         <rdar://problem/47158841>
3531
3532         Reviewed by Alex Christensen.
3533
3534         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3535         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3536         activating the message used to trigger the callback when it is set.
3537
3538 2019-01-24  John Wilander  <wilander@apple.com>
3539
3540         Add Ad Click Attribution as an internal/experimental feature
3541         https://bugs.webkit.org/show_bug.cgi?id=193685
3542         <rdar://problem/47450399>
3543
3544         Reviewed by Brent Fulgham.
3545
3546         Added test option adClickAttributionEnabled.
3547
3548         * DumpRenderTree/TestOptions.cpp:
3549         (TestOptions::TestOptions):
3550         * DumpRenderTree/TestOptions.h:
3551         * DumpRenderTree/mac/DumpRenderTree.mm:
3552         (setWebPreferencesForTestOptions):
3553
3554 2019-01-24  Antti Koivisto  <antti@apple.com>
3555
3556         [PSON] Flash on back navigation on Mac
3557         https://bugs.webkit.org/show_bug.cgi?id=193716
3558         <rdar://problem/47148458>
3559
3560         Reviewed by Chris Dumez.
3561
3562         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3563
3564         Closing of the previous page is delayed so waiting for didFinishNavigation is
3565         not sufficient to guarantee we have received all the messages. Wait for them.
3566
3567 2019-01-24  Chris Dumez  <cdumez@apple.com>
3568
3569         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3570         https://bugs.webkit.org/show_bug.cgi?id=193761
3571         <rdar://problem/47456405>
3572
3573         Reviewed by Alex Christensen.
3574
3575         Add API test coverage.
3576
3577         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3578
3579 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3580
3581         webkitpy: Missing PID in crashlog name should not be fatal
3582         https://bugs.webkit.org/show_bug.cgi?id=193771
3583
3584         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3585         of raising an exception.
3586
3587         Reviewed by Lucas Forschler.
3588
3589         * Scripts/webkitpy/port/darwin.py:
3590         (DarwinPort._merge_crash_logs):
3591
3592 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3593
3594         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3595         https://bugs.webkit.org/show_bug.cgi?id=193746
3596
3597         Reviewed by Youenn Fablet.
3598
3599         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3600         so we'd best just not call it.
3601
3602         * Scripts/webkitpy/w3c/test_exporter.py:
3603         (WebPlatformTestExporter.create_branch_with_patch):
3604
3605 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3606
3607         Move FileSystem to WTF
3608         https://bugs.webkit.org/show_bug.cgi?id=193602
3609
3610         Reviewed by Yusuke Suzuki.
3611
3612         * DumpRenderTree/win/DumpRenderTree.cpp:
3613         * TestWebKitAPI/CMakeLists.txt:
3614         * TestWebKitAPI/PlatformGTK.cmake:
3615         * TestWebKitAPI/PlatformJSCOnly.cmake:
3616         * TestWebKitAPI/PlatformPlayStation.cmake:
3617         * TestWebKitAPI/PlatformWPE.cmake:
3618         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3619         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3620         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3621         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3622         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3623         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3624         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3625         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3626         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3627         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3628
3629 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3630
3631         [WPE] Remove hard dependency on subprocess32 for the API tests
3632
3633         Rubber-stamped by Carlos Garcia Campos.
3634
3635         * glib/api_test_runner.py:
3636         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3637         its presence only when running WPEQt tests.
3638
3639 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3640
3641         [GLIB] Expose JavaScriptCore options in GLib public API
3642         https://bugs.webkit.org/show_bug.cgi?id=188742
3643
3644         Reviewed by Michael Catanzaro.
3645
3646         Add a test for the new API.
3647
3648         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3649         (testsJSCOptions):
3650         (main):
3651
3652 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3653
3654         [GTK][WPE] Support JPEG 2000 images
3655         https://bugs.webkit.org/show_bug.cgi?id=186272
3656
3657         Reviewed by Žan Doberšek.
3658
3659         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3660
3661         * gtk/jhbuild.modules:
3662         * wpe/jhbuild.modules:
3663
3664 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3665
3666         check-webkit-style should warn when using soft-linking macros in a header
3667         <https://webkit.org/b/193750>
3668
3669         Reviewed by Darin Adler.
3670
3671         * Scripts/webkitpy/style/checkers/cpp.py:
3672         (check_language): Add softlink/header check by refactoring the
3673         softlink/framework check.
3674         (CppChecker): Enable softlink/header check by default.
3675         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3676         (CppStyleTest.test_softlink_framework): Rename from
3677         CppStyleTest.test_softlink() and change test framework name in
3678         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3679         files. Set file_name for macros that only appear in headers.
3680         (CppStyleTest.test_softlink_header): Add tests for using
3681         soft-link macros in headers.
3682
3683 2019-01-23  Chris Dumez  <cdumez@apple.com>
3684
3685         Deprecate API to limit the maximum number of WebProcesses
3686         https://bugs.webkit.org/show_bug.cgi?id=193725
3687         <rdar://problem/47464879>
3688
3689         Reviewed by Geoff Garen.
3690
3691         Update existing API tests to stop using deprecated API.
3692
3693         * MiniBrowser/mac/AppDelegate.m:
3694         (defaultConfiguration):
3695         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3696         (TestWebKitAPI::TEST):
3697         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3698         (TestWebKitAPI::TEST):
3699         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3700         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3701         (TEST):
3702         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3703         (TEST):
3704
3705 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3706
3707         [ews-app] Rename ews model buildermappings to buildermapping
3708         https://bugs.webkit.org/show_bug.cgi?id=193729
3709
3710         Reviewed by Lucas Forschler.
3711
3712         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3713         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3714         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3715
3716 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3717
3718         [ews-app] Rename ews model steps to step
3719         https://bugs.webkit.org/show_bug.cgi?id=193697
3720
3721         Reviewed by Lucas Forschler.
3722
3723         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3724         (Step): Renamed Steps to Step.
3725
3726 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3727
3728         Clean up IndexedDB files between tests
3729         https://bugs.webkit.org/show_bug.cgi?id=192796
3730         <rdar://problem/46824999>
3731
3732         Reviewed by Geoffrey Garen.
3733
3734         * DumpRenderTree/mac/DumpRenderTree.mm:
3735         (runTest):
3736         * WebKitTestRunner/TestController.cpp:
3737         (WTR::TestController::resetStateToConsistentValues):
3738         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3739         (WTR::RemoveAllIndexedDatabasesCallback):
3740         (WTR::TestController::ClearIndexedDatabases):
3741         * WebKitTestRunner/TestController.h:
3742         * WebKitTestRunner/TestInvocation.cpp:
3743         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3744
3745 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3746
3747         [ews-app] Rename ews model Builds to Build
3748         https://bugs.webkit.org/show_bug.cgi?id=193695
3749
3750         Reviewed by Lucas Forschler.
3751
3752         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3753         (Build): Renamed Builds to Build.
3754
3755 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3756
3757         webkitpy: Wait longer when launching WebKitTestRunner
3758         https://bugs.webkit.org/show_bug.cgi?id=193734
3759
3760         Reviewed by Aakash Jain.
3761
3762         * Scripts/webkitpy/port/simulator_process.py:
3763         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3764
3765 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3766
3767         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3768         https://bugs.webkit.org/show_bug.cgi?id=193182
3769         <rdar://problem/47452154>
3770
3771         Reviewed by Tim Horton.
3772
3773         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3774         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3775         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3776
3777         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3778         preventing later tests from recognizing gestures.
3779
3780         * WebKitTestRunner/ios/TestControllerIOS.mm:
3781         (WTR::TestController::platformResetStateToConsistentValues):
3782
3783         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3784
3785 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3786
3787         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3788         https://bugs.webkit.org/show_bug.cgi?id=193722
3789         <rdar://problem/47481475>
3790
3791         Reviewed by Lucas Forschler.
3792
3793         iPhone and iPad ports should both use the iOS config.
3794
3795         * Scripts/webkitpy/port/ios_simulator.py:
3796         (IPhoneSimulatorPort.__init__):
3797         (IPadSimulatorPort.__init__):
3798
3799 2019-01-23  Rob Buis  <rbuis@igalia.com>
3800
3801         Update MIME type parser
3802         https://bugs.webkit.org/show_bug.cgi?id=180526
3803
3804         Reviewed by Frédéric Wang.
3805
3806         Add unit tests for both parse modes of ParsedContentType.
3807
3808         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3809         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3810         (TestWebKitAPI::TEST):
3811
3812 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3813
3814         [ews-app] fetch loop should not stop on network issues
3815         https://bugs.webkit.org/show_bug.cgi?id=193666
3816
3817         Reviewed by Lucas Forschler.
3818
3819         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3820         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3821
3822 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3823
3824         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3825         https://bugs.webkit.org/show_bug.cgi?id=189165
3826         <rdar://problem/47433765>
3827
3828         Reviewed by Tim Horton.
3829
3830         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3831         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3832         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3833         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3834         would make its way to the UI process by the time the layer tree commit is finished.
3835
3836         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3837         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3838         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3839         will fail because it asks for -_autofillContext too early.
3840
3841         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3842         is handled in the UI process.
3843
3844         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3845
3846         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3847         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3848         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3849         input session.
3850
3851         (-[AutofillTestView textInputHasAutofillContext]):
3852
3853         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3854
3855         * TestWebKitAPI/cocoa/TestWKWebView.h:
3856         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3857         (nextInputSessionChangeCount):
3858
3859         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3860         This includes changing the focused element from one to another.
3861
3862         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3863         (-[TestWKWebView didStartFormControlInteraction]):
3864         (-[TestWKWebView didEndFormControlInteraction]):
3865         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3866
3867         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3868         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3869         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3870         that doesn't require an input session to one that doesn't.
3871
3872 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3873
3874         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3875         <https://webkit.org/b/193676>
3876
3877         Reviewed by Alexey Proskuryakov.
3878
3879         * Scripts/webkitpy/style/checkers/cpp.py:
3880         (check_member_initialization_list):
3881         - Don't report missing whitespace around colon if the colon at
3882           the start of the line is formatted correctly.
3883         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3884         (WebKitStyleTest.test_member_initialization_list):
3885         - Add a test for a missing permutation of existing tests.
3886         - Add a test this false-positive.
3887         - Add blank lines between subtests to make them easier to read.
3888
3889 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3890
3891         [build.webkit.org] Unit-test failure after r237113
3892         https://bugs.webkit.org/show_bug.cgi?id=193669
3893
3894         Reviewed by Michael Catanzaro.
3895
3896         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3897         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3898         multiple or zero flags.
3899
3900 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3901
3902         Cache bytecode to disk
3903         https://bugs.webkit.org/show_bug.cgi?id=192782
3904         <rdar://problem/46084932>
3905
3906         Reviewed by Keith Miller.
3907
3908         Add test helper to execute bytecode-cache tests: it executes each test
3909         twice, the first with JSC_diskCachePath set to a temporary directory
3910         and second with JSC_forceDiskCache=true (in addition to the cache path)
3911         to guarantee that only the disk cache is being used and no new
3912         UnlinkedCodeBlocks are being created.
3913
3914         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3915         * Scripts/run-jsc-stress-tests:
3916
3917 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3918
3919         [css-logical] Implement flow-relative margin, padding and border shorthands
3920         https://bugs.webkit.org/show_bug.cgi?id=188697
3921
3922         Reviewed by Simon Fraser and Antti Koivisto.
3923
3924         * DumpRenderTree/TestOptions.cpp:
3925         (TestOptions::TestOptions):
3926         * DumpRenderTree/TestOptions.h:
3927         * DumpRenderTree/mac/DumpRenderTree.mm:
3928         (setWebPreferencesForTestOptions):
3929         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3930
3931         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3932         (JSONCSSPropertiesChecker.check_codegen_properties):
3933         Allow CSS property definitions to have a 'runtime-flag' parameter which
3934         disables the property when the specified runtime flag is disabled.
3935
3936 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3937
3938         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3939         https://bugs.webkit.org/show_bug.cgi?id=193643
3940
3941         Reviewed by Michael Catanzaro.
3942
3943         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3944         * wpe/jhbuild.modules: Ditto.
3945
3946 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3947
3948         [LFC][Floats] Take float top position into account when computing containing block height.
3949         https://bugs.webkit.org/show_bug.cgi?id=193655
3950
3951         Reviewed by Antti Koivisto.
3952
3953         * LayoutReloaded/misc/LFC-passing-tests.txt:
3954
3955 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3956
3957         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3958         <https://webkit.org/b/193645>
3959         <rdar://problem/47421574>
3960
3961         Reviewed by Alex Christensen.
3962
3963         - Now checks for local soft-linking of all frameworks that have
3964           their own *SoftLinking.{cpp,h,mm} files.
3965         - Changes softlink/uikit warning to softlink/framework.
3966
3967         * Scripts/webkitpy/style/checkers/cpp.py:
3968         (check_language):
3969         (CppChecker):
3970         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3971         (CppStyleTest):
3972
3973 2019-01-20  Saam Barati  <sbarati@apple.com>
3974
3975         Rollout r240210: It broke tests on iOS
3976         https://bugs.webkit.org/show_bug.cgi?id=193640
3977
3978         Unreviewed.
3979
3980         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3981         * Scripts/run-jsc-stress-tests:
3982
3983 2019-01-20  chris fleizach  <cfleizach@apple.com>
3984
3985         AX: Support returning relative frames for accessibility
3986         https://bugs.webkit.org/show_bug.cgi?id=193414
3987         <rdar://problem/47268501>
3988
3989         Reviewed by Zalan Bujtas.
3990
3991         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3992         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3993         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3994         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3995         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3996         (WTR::attributesOfElement):
3997         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3998
3999 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
4000
4001         Unreviewed, add my new email address
4002
4003         * Scripts/webkitpy/common/config/contributors.json:
4004
4005 2019-01-19  Zalan Bujtas  <zalan@apple.com>
4006
4007         [LFC][BFC] <body>'s overflow property value is propagated to viewport
4008         https://bugs.webkit.org/show_bug.cgi?id=193617
4009
4010         Reviewed by Antti Koivisto.
4011
4012         * LayoutReloaded/misc/LFC-passing-tests.txt:
4013
4014 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
4015
4016         Unreviewed, rolling out r240209.
4017
4018         Broke GTK/WPE injected bundle
4019
4020         Reverted changeset:
4021
4022         "AX: Support returning relative frames for accessibility"
4023         https://bugs.webkit.org/show_bug.cgi?id=193414
4024         https://trac.webkit.org/changeset/240209
4025
4026 2019-01-12  Dan Bernstein  <mitz@apple.com>
4027
4028         [Cocoa] Avoid importing directly from subumbrella frameworks
4029         https://bugs.webkit.org/show_bug.cgi?id=186016
4030         <rdar://problem/40591038>
4031
4032         Reviewed by Sam Weinig.
4033
4034         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4035           LaunchServices header.
4036         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4037           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4038         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4039           when using SDKs earlier than 10.13.
4040         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4041           and OTHER_CPLUSPLUSFLAGS.
4042         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4043           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4044         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4045           LaunchServices header.
4046
4047 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
4048
4049         Cache bytecode to disk
4050         https://bugs.webkit.org/show_bug.cgi?id=192782
4051         <rdar://problem/46084932>
4052
4053         Reviewed by Keith Miller.
4054
4055         Add test helper to execute bytecode-cache tests: it executes each test
4056         twice, the first with JSC_diskCachePath set to a temporary directory
4057         and second with JSC_forceDiskCache=true (in addition to the cache path)
4058         to guarantee that only the disk cache is being used and no new
4059         UnlinkedCodeBlocks are being created.
4060
4061         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
4062         * Scripts/run-jsc-stress-tests:
4063
4064 2019-01-20  chris fleizach  <cfleizach@apple.com>
4065
4066         AX: Support returning relative frames for accessibility
4067         https://bugs.webkit.org/show_bug.cgi?id=193414
4068         <rdar://problem/47268501>
4069
4070         Reviewed by Zalan Bujtas.
4071
4072         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4073         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4074         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4075         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4076         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4077         (WTR::attributesOfElement):
4078         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4079
4080 2019-01-20  Antoine Quint  <graouts@apple.com>
4081
4082         Add a POINTER_EVENTS feature flag
4083         https://bugs.webkit.org/show_bug.cgi?id=193577
4084         <rdar://problem/47408511>
4085
4086         Unreviewed. Also enable Pointer Events for iosmac.
4087
4088         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4089
4090 2019-01-19  Zalan Bujtas  <zalan@apple.com>
4091
4092         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
4093         https://bugs.webkit.org/show_bug.cgi?id=193613
4094
4095         Reviewed by Antti Koivisto.
4096
4097         * LayoutReloaded/misc/LFC-passing-tests.txt:
4098
4099 2019-01-19  Antoine Quint  <graouts@apple.com>
4100
4101         Add a POINTER_EVENTS feature flag
4102         https://bugs.webkit.org/show_bug.cgi?id=193577
4103
4104         Reviewed by Dean Jackson.
4105
4106         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4107
4108 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
4109
4110         Disable the run-jsc-stress-test remote host key check [second round].
4111         https://bugs.webkit.org/show_bug.cgi?id=192988
4112
4113         Reviewed by Dewei Zhu.
4114
4115         * Scripts/run-jsc-stress-tests:
4116
4117 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4118
4119         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
4120         https://bugs.webkit.org/show_bug.cgi?id=193597
4121
4122         Reviewed by Lucas Forschler.
4123
4124         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4125
4126 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4127
4128         [build.webkit.org] api tests failures are incorrectly named as unit test failures
4129         https://bugs.webkit.org/show_bug.cgi?id=193595
4130
4131         Reviewed by Lucas Forschler.
4132
4133         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
4134         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
4135         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
4136
4137 2019-01-18  Chris Dumez  <cdumez@apple.com>
4138
4139         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
4140         https://bugs.webkit.org/show_bug.cgi?id=193588
4141         <rdar://problem/47131566>
4142
4143         Reviewed by Alex Christensen.
4144
4145         Add layout test coverage.
4146
4147         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4148
4149 2019-01-18  Jer Noble  <jer.noble@apple.com>
4150
4151         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
4152         https://bugs.webkit.org/show_bug.cgi?id=189553
4153
4154         Reviewed by Tim Horton.
4155
4156         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
4157
4158         * ContentExtensionTester/Configurations/Base.xcconfig:
4159         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
4160         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4161         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
4162         * ImageDiff/cg/Configurations/Base.xcconfig:
4163         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
4164         * MiniBrowser/Configurations/Base.xcconfig:
4165         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4166         * MobileMiniBrowser/Configurations/Base.xcconfig:
4167         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4168         * Scripts/webkitpy/style/checker.py:
4169         (_all_categories):
4170         (FileType):
4171         (CheckerDispatcher._file_type):
4172         (CheckerDispatcher._create_checker):
4173         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
4174         (SDKVariantChecker):
4175         (SDKVariantChecker.__init__):
4176         (SDKVariantChecker.check):
4177         * TestWebKitAPI/Configurations/Base.xcconfig:
4178         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
4179         * WebEditingTester/Configurations/Base.xcconfig:
4180         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
4181         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
4182         * WebKitTestRunner/Configurations/Base.xcconfig:
4183         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
4184         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
4185         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
4186
4187 2019-01-18  David Kilzer  <ddkilzer@apple.com>
4188
4189         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
4190         <https://webkit.org/b/193568>
4191         <rdar://problem/47381130>
4192
4193         Reviewed by Alex Christensen.
4194
4195         Make sure no one re-introduces UIKit soft-linking by adding a
4196         style rule.
4197
4198         * Scripts/webkitpy/style/checkers/cpp.py:
4199         (check_language): Add softlink/uikit check.
4200         (CppChecker): Enable softlink/uikit check.
4201         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4202         (CppStyleTest): Add test for softlink/uikit.
4203
4204 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
4205
4206         [GTK] install-dependencies tool looks for libunistring-dev for dnf
4207         https://bugs.webkit.org/show_bug.cgi?id=193584
4208
4209         Change "-dev" to "-devel".
4210
4211         Reviewed by Michael Catanzaro.
4212
4213         * gtk/install-dependencies:
4214
4215 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4216
4217         webkitpy: Add iPhone and iPad ports
4218         https://bugs.webkit.org/show_bug.cgi?id=193537
4219         <rdar://problem/47353390>
4220
4221         Reviewed by Lucas Forschler.
4222
4223         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
4224         ports. Note that this separation is optional, the --ios-simulator command remains.
4225
4226         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4227         (RunTest.test_device_type_test_division): Drive-by fix.
4228         (RunTest.test_device_type_specific_listing): Ditto.
4229         (RunTest.test_ipad_test_division):
4230         (RunTest):
4231         (RunTest.test_ipad_listing):
4232         * Scripts/webkitpy/port/factory.py:
4233         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
4234         (PortFactory):
4235         * Scripts/webkitpy/port/ios_simulator.py:
4236         (IPhoneSimulatorPort):
4237         (IPadSimulatorPort):
4238
4239 2019-01-18  Chris Dumez  <cdumez@apple.com>
4240
4241         Regression(PSON) Scroll position is not always restored properly when navigating back
4242         https://bugs.webkit.org/show_bug.cgi?id=193578
4243         <rdar://problem/47386331>
4244
4245         Reviewed by Tim Horton.
4246
4247         Add API test coverage.
4248
4249         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4250
4251 2019-01-18  Youenn Fablet  <youenn@apple.com>
4252
4253         Add a new SPI to request for cache storage quota increase
4254         https://bugs.webkit.org/show_bug.cgi?id=193323
4255
4256         Reviewed by Alex Christensen.
4257
4258         Implement WebsiteDataStore quota delegate to handle quota requests.
4259         By default, do not update quota.
4260         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
4261
4262         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4263         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4264         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
4265         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4266         * WebKitTestRunner/TestController.cpp:
4267         (WTR::TestController::allowCacheStorageQuotaIncrease):
4268         * WebKitTestRunner/TestController.h:
4269         * WebKitTestRunner/TestInvocation.cpp:
4270         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4271         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4272         (-[CacheStorageQuotaManager init]):
4273         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4274         (WTR::initializeWebViewConfiguration):
4275         (WTR::TestController::cocoaResetStateToConsistentValues):
4276         (WTR::TestController::allowCacheStorageQuotaIncrease):
4277
4278 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4279
4280         [ews-build] Pass owner to the triggered builds
4281         https://bugs.webkit.org/show_bug.cgi?id=193574
4282
4283         Reviewed by Lucas Forschler.
4284
4285         * BuildSlaveSupport/ews-build/factories.py:
4286         (BuildFactory.propertiesToPassToTriggers):
4287
4288 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4289
4290         [ews-app] Send patch author as a build property
4291         https://bugs.webkit.org/show_bug.cgi?id=193560
4292
4293         Reviewed by Lucas Forschler.
4294
4295         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4296         (BugzillaPatchFetcher.fetch):
4297
4298 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4299
4300         webkitpy: Implement device type specific expected results (Follow-up fix)
4301         https://bugs.webkit.org/show_bug.cgi?id=192162
4302         <rdar://problem/46345449>
4303
4304         Unreviewed infrastructure fix.
4305
4306         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4307         (Manager.run): Don't boot a device if no tests are available to run on it.
4308
4309 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4310
4311         webkitpy: Implement device type specific expected results (Follow-up fix)
4312         https://bugs.webkit.org/show_bug.cgi?id=192162
4313         <rdar://problem/46345449>
4314
4315         Unreviewed infrastructure fix.
4316
4317         * Scripts/webkitpy/api_tests/manager.py:
4318         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
4319
4320 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4321
4322         webkitpy: Implement device type specific expected results (Part 2)
4323         https://bugs.webkit.org/show_bug.cgi?id=192162
4324         <rdar://problem/46345449>
4325
4326         Rubber-stamped by Aakash Jain.
4327
4328         This change uses device_type to select a different set of TestExpectation files based on the type of device running
4329         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
4330         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
4331
4332         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
4333         (LayoutTestFinder.find_tests): Pass device_type through.
4334         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
4335         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
4336         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4337         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
4338         (Manager._collect_tests): Pass device type to test finder.
4339         (Manager._needs_web_platform_test):
4340         (Manager._prepare_lists): Index _expectations by device type.
4341         (Manager._test_input_for_file):
4342         (Manager._test_is_slow): Ditto.
4343         (Manager._test_should_dump_jsconsolelog_in_stderr):
4344         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
4345         (Manager._get_test_inputs):
4346         (Manager._update_worker_count):
4347         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
4348         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
4349         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
4350         the one which runs the test.
4351         (Manager._run_test_subset):